GitHub PullRequestReviewCommentEvent at 2014-11-20 15:22:01
Repository: gaia
Actor: davehunt
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/20651766","id":20651766,"diff_hunk":"@@ -0,0 +1,366 @@\n+# This Source Code Form is subject to the terms of the Mozilla Public\n+# License, v. 2.0. If a copy of the MPL was not distributed with thisgit\n+# file, You can obtain one at http://mozilla.org/MPL/2.0/.\n+import inspect\n+import tempfile\n+\n+from gaiatest import GaiaTestCase\n+from mixins.imagecompare import GaiaImageCompareTestCaseMixin\n+import mozversion\n+import os\n+import subprocess\n+import time\n+from marionette.marionette import Actions\n+from marionette.marionette import MultiActions\n+\n+\n+class GaiaImageCompareTestCase(GaiaTestCase, GaiaImageCompareTestCaseMixin):\n+    def __init__(self, *args, **kwargs):\n+        GaiaTestCase.__init__(self, *args, **kwargs)\n+        GaiaImageCompareTestCaseMixin.__init__(self, *args, **kwargs)\n+\n+        self.temp_dir = tempfile.mkdtemp()\n+        self.local_path = '.'\n+        self.device_info = mozversion.get_version(dm_type='adb')\n+        if not os.path.exists(os.path.join(self.local_path, self.ref_dir)):\n+            os.makedirs(os.path.join(self.local_path, self.ref_dir))\n+        if not os.path.exists(os.path.join(self.local_path, self.shots_dir)):\n+            os.makedirs(os.path.join(self.local_path, self.shots_dir))\n+\n+    def setUp(self):\n+        GaiaTestCase.setUp(self)\n+        # # Setup image comparison specific methods\n+        self.device_name = self.get_device_name()\n+\n+        # if self.device_name == \"flame\":\n+        #    self.screenshot_location = \"/storage/sdcard0/screenshots/\"\n+\n+        if self.get_gaia_version() >= 34:\n+            self.post2dot0 = True\n+\n+        # use reflection method to find its own test name\n+        frm = inspect.stack()[1]\n+        mod = inspect.getmodule(frm[0])\n+        self.module_name = mod.__name__\n+\n+    def tearDown(self):\n+        # # Cleanup image comparison specific methods\n+        self.execute_image_job()\n+        GaiaTestCase.tearDown(self)\n+\n+    def get_device_name(self):\n+        return self.device_info.pop('device_id')\n+\n+    def get_gaia_version(self):\n+        version = self.device_info.pop('application_version')\n+        version = version[0:version.find('.')]\n+        return int(version)","path":"tests/python/gaia-ui-tests/gaiatest/gaia_graphics_test.py","position":57,"original_position":57,"commit_id":"3340c245d3e9edf095362fa81c75494f84494234","original_commit_id":"3340c245d3e9edf095362fa81c75494f84494234","user":{"login":"davehunt","id":122800,"avatar_url":"https://avatars.githubusercontent.com/u/122800?v=3","gravatar_id":"","url":"https://api.github.com/users/davehunt","html_url":"https://github.com/davehunt","followers_url":"https://api.github.com/users/davehunt/followers","following_url":"https://api.github.com/users/davehunt/following{/other_user}","gists_url":"https://api.github.com/users/davehunt/gists{/gist_id}","starred_url":"https://api.github.com/users/davehunt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davehunt/subscriptions","organizations_url":"https://api.github.com/users/davehunt/orgs","repos_url":"https://api.github.com/users/davehunt/repos","events_url":"https://api.github.com/users/davehunt/events{/privacy}","received_events_url":"https://api.github.com/users/davehunt/received_events","type":"User","site_admin":false},"body":"As mentioned I wonder if this is still needed..?","created_at":"2014-11-20T15:22:01Z","updated_at":"2014-11-20T15:22:01Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/26159#discussion_r20651766","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/26159","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/20651766"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/26159#discussion_r20651766"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/26159"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/26159","id":24467906,"html_url":"https://github.com/mozilla-b2g/gaia/pull/26159","diff_url":"https://github.com/mozilla-b2g/gaia/pull/26159.diff","patch_url":"https://github.com/mozilla-b2g/gaia/pull/26159.patch","issue_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/26159","number":26159,"state":"open","locked":false,"title":"Bug 1054326: Initial attempt to submit Imagecompare test framework and test cases int...","user":{"login":"npark-mozilla","id":6930774,"avatar_url":"https://avatars.githubusercontent.com/u/6930774?v=3","gravatar_id":"","url":"https://api.github.com/users/npark-mozilla","html_url":"https://github.com/npark-mozilla","followers_url":"https://api.github.com/users/npark-mozilla/followers","following_url":"https://api.github.com/users/npark-mozilla/following{/other_user}","gists_url":"https://api.github.com/users/npark-mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/npark-mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/npark-mozilla/subscriptions","organizations_url":"https://api.github.com/users/npark-mozilla/orgs","repos_url":"https://api.github.com/users/npark-mozilla/repos","events_url":"https://api.github.com/users/npark-mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/npark-mozilla/received_events","type":"User","site_admin":false},"body":"...o the main branch","created_at":"2014-11-14T20:25:57Z","updated_at":"2014-11-20T15:22:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a2dd04cbfee978d64c754b7473a3a02d5abda795","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/26159/commits","review_comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/26159/comments","review_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/26159/comments","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/3340c245d3e9edf095362fa81c75494f84494234","head":{"label":"npark-mozilla:IC_Submit","ref":"IC_Submit","sha":"3340c245d3e9edf095362fa81c75494f84494234","user":{"login":"npark-mozilla","id":6930774,"avatar_url":"https://avatars.githubusercontent.com/u/6930774?v=3","gravatar_id":"","url":"https://api.github.com/users/npark-mozilla","html_url":"https://github.com/npark-mozilla","followers_url":"https://api.github.com/users/npark-mozilla/followers","following_url":"https://api.github.com/users/npark-mozilla/following{/other_user}","gists_url":"https://api.github.com/users/npark-mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/npark-mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/npark-mozilla/subscriptions","organizations_url":"https://api.github.com/users/npark-mozilla/orgs","repos_url":"https://api.github.com/users/npark-mozilla/repos","events_url":"https://api.github.com/users/npark-mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/npark-mozilla/received_events","type":"User","site_admin":false},"repo":{"id":18301296,"name":"gaia","full_name":"npark-mozilla/gaia","owner":{"login":"npark-mozilla","id":6930774,"avatar_url":"https://avatars.githubusercontent.com/u/6930774?v=3","gravatar_id":"","url":"https://api.github.com/users/npark-mozilla","html_url":"https://github.com/npark-mozilla","followers_url":"https://api.github.com/users/npark-mozilla/followers","following_url":"https://api.github.com/users/npark-mozilla/following{/other_user}","gists_url":"https://api.github.com/users/npark-mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/npark-mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/npark-mozilla/subscriptions","organizations_url":"https://api.github.com/users/npark-mozilla/orgs","repos_url":"https://api.github.com/users/npark-mozilla/repos","events_url":"https://api.github.com/users/npark-mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/npark-mozilla/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/npark-mozilla/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see https://wiki.mozilla.org/Release_Management/B2G_Landing","fork":true,"url":"https://api.github.com/repos/npark-mozilla/gaia","forks_url":"https://api.github.com/repos/npark-mozilla/gaia/forks","keys_url":"https://api.github.com/repos/npark-mozilla/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/npark-mozilla/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/npark-mozilla/gaia/teams","hooks_url":"https://api.github.com/repos/npark-mozilla/gaia/hooks","issue_events_url":"https://api.github.com/repos/npark-mozilla/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/npark-mozilla/gaia/events","assignees_url":"https://api.github.com/repos/npark-mozilla/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/npark-mozilla/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/npark-mozilla/gaia/tags","blobs_url":"https://api.github.com/repos/npark-mozilla/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/npark-mozilla/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/npark-mozilla/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/npark-mozilla/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/npark-mozilla/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/npark-mozilla/gaia/languages","stargazers_url":"https://api.github.com/repos/npark-mozilla/gaia/stargazers","contributors_url":"https://api.github.com/repos/npark-mozilla/gaia/contributors","subscribers_url":"https://api.github.com/repos/npark-mozilla/gaia/subscribers","subscription_url":"https://api.github.com/repos/npark-mozilla/gaia/subscription","commits_url":"https://api.github.com/repos/npark-mozilla/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/npark-mozilla/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/npark-mozilla/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/npark-mozilla/gaia/issues/comments/{number}","contents_url":"https://api.github.com/repos/npark-mozilla/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/npark-mozilla/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/npark-mozilla/gaia/merges","archive_url":"https://api.github.com/repos/npark-mozilla/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/npark-mozilla/gaia/downloads","issues_url":"https://api.github.com/repos/npark-mozilla/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/npark-mozilla/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/npark-mozilla/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/npark-mozilla/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/npark-mozilla/gaia/labels{/name}","releases_url":"https://api.github.com/repos/npark-mozilla/gaia/releases{/id}","created_at":"2014-03-31T17:15:03Z","updated_at":"2014-11-18T18:39:58Z","pushed_at":"2014-11-18T20:09:30Z","git_url":"git://github.com/npark-mozilla/gaia.git","ssh_url":"git@github.com:npark-mozilla/gaia.git","clone_url":"https://github.com/npark-mozilla/gaia.git","svn_url":"https://github.com/npark-mozilla/gaia","homepage":"https://wiki.mozilla.org/B2G","size":862886,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-b2g:master","ref":"master","sha":"ccda843399fe0d26fac7747fd787e5fe2e8dfdf7","user":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"repo":{"id":2317369,"name":"gaia","full_name":"mozilla-b2g/gaia","owner":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-b2g/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see","fork":false,"url":"https://api.github.com/repos/mozilla-b2g/gaia","forks_url":"https://api.github.com/repos/mozilla-b2g/gaia/forks","keys_url":"https://api.github.com/repos/mozilla-b2g/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-b2g/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-b2g/gaia/teams","hooks_url":"https://api.github.com/repos/mozilla-b2g/gaia/hooks","issue_events_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-b2g/gaia/events","assignees_url":"https://api.github.com/repos/mozilla-b2g/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-b2g/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/tags","blobs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-b2g/gaia/languages","stargazers_url":"https://api.github.com/repos/mozilla-b2g/gaia/stargazers","contributors_url":"https://api.github.com/repos/mozilla-b2g/gaia/contributors","subscribers_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscribers","subscription_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscription","commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla-b2g/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-b2g/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-b2g/gaia/merges","archive_url":"https://api.github.com/repos/mozilla-b2g/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-b2g/gaia/downloads","issues_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-b2g/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-b2g/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-b2g/gaia/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-b2g/gaia/releases{/id}","created_at":"2011-09-03T01:38:46Z","updated_at":"2014-11-20T14:44:46Z","pushed_at":"2014-11-20T15:08:38Z","git_url":"git://github.com/mozilla-b2g/gaia.git","ssh_url":"git@github.com:mozilla-b2g/gaia.git","clone_url":"https://github.com/mozilla-b2g/gaia.git","svn_url":"https://github.com/mozilla-b2g/gaia","homepage":"https://wiki.mozilla.org/B2G","size":1557498,"stargazers_count":1805,"watchers_count":1805,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2056,"mirror_url":null,"open_issues_count":711,"forks":2056,"open_issues":711,"watchers":1805,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/26159"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/26159"},"issue":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/26159"},"comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/26159/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/26159/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/26159/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/3340c245d3e9edf095362fa81c75494f84494234"}}}}