GitHub PullRequestReviewCommentEvent at 2014-08-26 11:20:52
Repository: vraptor4
Actor: Turini
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/caelum/vraptor4/pulls/comments/16707501","id":16707501,"diff_hunk":"@@ -142,8 +142,8 @@ public Validator add(Message message) {\n \t\tresult.include(\"errors\", getErrors());\n \t\toutjector.outjectRequestMap();\n \t\t\n-\t\tlogger.debug(\"there are errors on result: {}\", getErrors());\n-\t\treturn viewsFactory.instanceFor(view, getErrors());\n+\t\tlogger.debug(\"there are errors on result: {}\", messages.handleErrors());","path":"vraptor-core/src/main/java/br/com/caelum/vraptor/validator/DefaultValidator.java","position":6,"original_position":6,"commit_id":"b89218ed0d74ba04da71c8b137e50ed2b08f175e","original_commit_id":"b89218ed0d74ba04da71c8b137e50ed2b08f175e","user":{"login":"Turini","id":1529021,"avatar_url":"https://avatars.githubusercontent.com/u/1529021?v=2","gravatar_id":"8757ffa706118c797421d81fdf2603e8","url":"https://api.github.com/users/Turini","html_url":"https://github.com/Turini","followers_url":"https://api.github.com/users/Turini/followers","following_url":"https://api.github.com/users/Turini/following{/other_user}","gists_url":"https://api.github.com/users/Turini/gists{/gist_id}","starred_url":"https://api.github.com/users/Turini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Turini/subscriptions","organizations_url":"https://api.github.com/users/Turini/orgs","repos_url":"https://api.github.com/users/Turini/repos","events_url":"https://api.github.com/users/Turini/events{/privacy}","received_events_url":"https://api.github.com/users/Turini/received_events","type":"User","site_admin":false},"body":"it includes `getErrors()` to the view, but now we're logging `messages.handleErrors()`. Is it right?","created_at":"2014-08-26T11:20:52Z","updated_at":"2014-08-26T11:20:52Z","html_url":"https://github.com/caelum/vraptor4/pull/725#discussion_r16707501","pull_request_url":"https://api.github.com/repos/caelum/vraptor4/pulls/725","_links":{"self":{"href":"https://api.github.com/repos/caelum/vraptor4/pulls/comments/16707501"},"html":{"href":"https://github.com/caelum/vraptor4/pull/725#discussion_r16707501"},"pull_request":{"href":"https://api.github.com/repos/caelum/vraptor4/pulls/725"}}},"pull_request":{"url":"https://api.github.com/repos/caelum/vraptor4/pulls/725","id":19246568,"html_url":"https://github.com/caelum/vraptor4/pull/725","diff_url":"https://github.com/caelum/vraptor4/pull/725.diff","patch_url":"https://github.com/caelum/vraptor4/pull/725.patch","issue_url":"https://api.github.com/repos/caelum/vraptor4/issues/725","number":725,"state":"open","locked":false,"title":"Fixing problem: validation errors ignored on redirects. Closes #476","user":{"login":"renanigt","id":212554,"avatar_url":"https://avatars.githubusercontent.com/u/212554?v=2","gravatar_id":"3ceb47e5f936a03217c3ba8f1b6b629d","url":"https://api.github.com/users/renanigt","html_url":"https://github.com/renanigt","followers_url":"https://api.github.com/users/renanigt/followers","following_url":"https://api.github.com/users/renanigt/following{/other_user}","gists_url":"https://api.github.com/users/renanigt/gists{/gist_id}","starred_url":"https://api.github.com/users/renanigt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renanigt/subscriptions","organizations_url":"https://api.github.com/users/renanigt/orgs","repos_url":"https://api.github.com/users/renanigt/repos","events_url":"https://api.github.com/users/renanigt/events{/privacy}","received_events_url":"https://api.github.com/users/renanigt/received_events","type":"User","site_admin":false},"body":"In conversation on Issue #476, @lucascs asked me to send this PR to start the bug fix.\r\n\r\nHere the gist with the problematic controller as he asked me: [Problematic Controller](https://gist.github.com/renanigt/6f88e6fced50bce47ac9)","created_at":"2014-08-02T14:43:01Z","updated_at":"2014-08-26T11:20:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"76083f555e48e2d5f92dc397ecaafd9fe1ee0b19","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/caelum/vraptor4/pulls/725/commits","review_comments_url":"https://api.github.com/repos/caelum/vraptor4/pulls/725/comments","review_comment_url":"https://api.github.com/repos/caelum/vraptor4/pulls/comments/{number}","comments_url":"https://api.github.com/repos/caelum/vraptor4/issues/725/comments","statuses_url":"https://api.github.com/repos/caelum/vraptor4/statuses/b89218ed0d74ba04da71c8b137e50ed2b08f175e","head":{"label":"renanigt:validationIgnoredOnRedirects","ref":"validationIgnoredOnRedirects","sha":"b89218ed0d74ba04da71c8b137e50ed2b08f175e","user":{"login":"renanigt","id":212554,"avatar_url":"https://avatars.githubusercontent.com/u/212554?v=2","gravatar_id":"3ceb47e5f936a03217c3ba8f1b6b629d","url":"https://api.github.com/users/renanigt","html_url":"https://github.com/renanigt","followers_url":"https://api.github.com/users/renanigt/followers","following_url":"https://api.github.com/users/renanigt/following{/other_user}","gists_url":"https://api.github.com/users/renanigt/gists{/gist_id}","starred_url":"https://api.github.com/users/renanigt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renanigt/subscriptions","organizations_url":"https://api.github.com/users/renanigt/orgs","repos_url":"https://api.github.com/users/renanigt/repos","events_url":"https://api.github.com/users/renanigt/events{/privacy}","received_events_url":"https://api.github.com/users/renanigt/received_events","type":"User","site_admin":false},"repo":{"id":20528780,"name":"vraptor4","full_name":"renanigt/vraptor4","owner":{"login":"renanigt","id":212554,"avatar_url":"https://avatars.githubusercontent.com/u/212554?v=2","gravatar_id":"3ceb47e5f936a03217c3ba8f1b6b629d","url":"https://api.github.com/users/renanigt","html_url":"https://github.com/renanigt","followers_url":"https://api.github.com/users/renanigt/followers","following_url":"https://api.github.com/users/renanigt/following{/other_user}","gists_url":"https://api.github.com/users/renanigt/gists{/gist_id}","starred_url":"https://api.github.com/users/renanigt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renanigt/subscriptions","organizations_url":"https://api.github.com/users/renanigt/orgs","repos_url":"https://api.github.com/users/renanigt/repos","events_url":"https://api.github.com/users/renanigt/events{/privacy}","received_events_url":"https://api.github.com/users/renanigt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/renanigt/vraptor4","description":"A Java web MVC action-based framework","fork":true,"url":"https://api.github.com/repos/renanigt/vraptor4","forks_url":"https://api.github.com/repos/renanigt/vraptor4/forks","keys_url":"https://api.github.com/repos/renanigt/vraptor4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/renanigt/vraptor4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/renanigt/vraptor4/teams","hooks_url":"https://api.github.com/repos/renanigt/vraptor4/hooks","issue_events_url":"https://api.github.com/repos/renanigt/vraptor4/issues/events{/number}","events_url":"https://api.github.com/repos/renanigt/vraptor4/events","assignees_url":"https://api.github.com/repos/renanigt/vraptor4/assignees{/user}","branches_url":"https://api.github.com/repos/renanigt/vraptor4/branches{/branch}","tags_url":"https://api.github.com/repos/renanigt/vraptor4/tags","blobs_url":"https://api.github.com/repos/renanigt/vraptor4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/renanigt/vraptor4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/renanigt/vraptor4/git/refs{/sha}","trees_url":"https://api.github.com/repos/renanigt/vraptor4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/renanigt/vraptor4/statuses/{sha}","languages_url":"https://api.github.com/repos/renanigt/vraptor4/languages","stargazers_url":"https://api.github.com/repos/renanigt/vraptor4/stargazers","contributors_url":"https://api.github.com/repos/renanigt/vraptor4/contributors","subscribers_url":"https://api.github.com/repos/renanigt/vraptor4/subscribers","subscription_url":"https://api.github.com/repos/renanigt/vraptor4/subscription","commits_url":"https://api.github.com/repos/renanigt/vraptor4/commits{/sha}","git_commits_url":"https://api.github.com/repos/renanigt/vraptor4/git/commits{/sha}","comments_url":"https://api.github.com/repos/renanigt/vraptor4/comments{/number}","issue_comment_url":"https://api.github.com/repos/renanigt/vraptor4/issues/comments/{number}","contents_url":"https://api.github.com/repos/renanigt/vraptor4/contents/{+path}","compare_url":"https://api.github.com/repos/renanigt/vraptor4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/renanigt/vraptor4/merges","archive_url":"https://api.github.com/repos/renanigt/vraptor4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/renanigt/vraptor4/downloads","issues_url":"https://api.github.com/repos/renanigt/vraptor4/issues{/number}","pulls_url":"https://api.github.com/repos/renanigt/vraptor4/pulls{/number}","milestones_url":"https://api.github.com/repos/renanigt/vraptor4/milestones{/number}","notifications_url":"https://api.github.com/repos/renanigt/vraptor4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/renanigt/vraptor4/labels{/name}","releases_url":"https://api.github.com/repos/renanigt/vraptor4/releases{/id}","created_at":"2014-06-05T14:43:08Z","updated_at":"2014-06-27T00:10:22Z","pushed_at":"2014-08-26T03:38:46Z","git_url":"git://github.com/renanigt/vraptor4.git","ssh_url":"git@github.com:renanigt/vraptor4.git","clone_url":"https://github.com/renanigt/vraptor4.git","svn_url":"https://github.com/renanigt/vraptor4","homepage":"vraptor.org","size":13510,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"caelum:master","ref":"master","sha":"2f170bfa1c95b3b2787d663f92bd54a83e8ac9c5","user":{"login":"caelum","id":65012,"avatar_url":"https://avatars.githubusercontent.com/u/65012?v=2","gravatar_id":"89f2c16e318c3b2068c9d37c46a83989","url":"https://api.github.com/users/caelum","html_url":"https://github.com/caelum","followers_url":"https://api.github.com/users/caelum/followers","following_url":"https://api.github.com/users/caelum/following{/other_user}","gists_url":"https://api.github.com/users/caelum/gists{/gist_id}","starred_url":"https://api.github.com/users/caelum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caelum/subscriptions","organizations_url":"https://api.github.com/users/caelum/orgs","repos_url":"https://api.github.com/users/caelum/repos","events_url":"https://api.github.com/users/caelum/events{/privacy}","received_events_url":"https://api.github.com/users/caelum/received_events","type":"Organization","site_admin":false},"repo":{"id":9821876,"name":"vraptor4","full_name":"caelum/vraptor4","owner":{"login":"caelum","id":65012,"avatar_url":"https://avatars.githubusercontent.com/u/65012?v=2","gravatar_id":"89f2c16e318c3b2068c9d37c46a83989","url":"https://api.github.com/users/caelum","html_url":"https://github.com/caelum","followers_url":"https://api.github.com/users/caelum/followers","following_url":"https://api.github.com/users/caelum/following{/other_user}","gists_url":"https://api.github.com/users/caelum/gists{/gist_id}","starred_url":"https://api.github.com/users/caelum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caelum/subscriptions","organizations_url":"https://api.github.com/users/caelum/orgs","repos_url":"https://api.github.com/users/caelum/repos","events_url":"https://api.github.com/users/caelum/events{/privacy}","received_events_url":"https://api.github.com/users/caelum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caelum/vraptor4","description":"A Java web MVC action-based framework","fork":false,"url":"https://api.github.com/repos/caelum/vraptor4","forks_url":"https://api.github.com/repos/caelum/vraptor4/forks","keys_url":"https://api.github.com/repos/caelum/vraptor4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caelum/vraptor4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caelum/vraptor4/teams","hooks_url":"https://api.github.com/repos/caelum/vraptor4/hooks","issue_events_url":"https://api.github.com/repos/caelum/vraptor4/issues/events{/number}","events_url":"https://api.github.com/repos/caelum/vraptor4/events","assignees_url":"https://api.github.com/repos/caelum/vraptor4/assignees{/user}","branches_url":"https://api.github.com/repos/caelum/vraptor4/branches{/branch}","tags_url":"https://api.github.com/repos/caelum/vraptor4/tags","blobs_url":"https://api.github.com/repos/caelum/vraptor4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caelum/vraptor4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caelum/vraptor4/git/refs{/sha}","trees_url":"https://api.github.com/repos/caelum/vraptor4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caelum/vraptor4/statuses/{sha}","languages_url":"https://api.github.com/repos/caelum/vraptor4/languages","stargazers_url":"https://api.github.com/repos/caelum/vraptor4/stargazers","contributors_url":"https://api.github.com/repos/caelum/vraptor4/contributors","subscribers_url":"https://api.github.com/repos/caelum/vraptor4/subscribers","subscription_url":"https://api.github.com/repos/caelum/vraptor4/subscription","commits_url":"https://api.github.com/repos/caelum/vraptor4/commits{/sha}","git_commits_url":"https://api.github.com/repos/caelum/vraptor4/git/commits{/sha}","comments_url":"https://api.github.com/repos/caelum/vraptor4/comments{/number}","issue_comment_url":"https://api.github.com/repos/caelum/vraptor4/issues/comments/{number}","contents_url":"https://api.github.com/repos/caelum/vraptor4/contents/{+path}","compare_url":"https://api.github.com/repos/caelum/vraptor4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caelum/vraptor4/merges","archive_url":"https://api.github.com/repos/caelum/vraptor4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caelum/vraptor4/downloads","issues_url":"https://api.github.com/repos/caelum/vraptor4/issues{/number}","pulls_url":"https://api.github.com/repos/caelum/vraptor4/pulls{/number}","milestones_url":"https://api.github.com/repos/caelum/vraptor4/milestones{/number}","notifications_url":"https://api.github.com/repos/caelum/vraptor4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caelum/vraptor4/labels{/name}","releases_url":"https://api.github.com/repos/caelum/vraptor4/releases{/id}","created_at":"2013-05-02T20:22:14Z","updated_at":"2014-08-25T14:40:57Z","pushed_at":"2014-08-23T17:26:59Z","git_url":"git://github.com/caelum/vraptor4.git","ssh_url":"git@github.com:caelum/vraptor4.git","clone_url":"https://github.com/caelum/vraptor4.git","svn_url":"https://github.com/caelum/vraptor4","homepage":"vraptor.org","size":33547,"stargazers_count":119,"watchers_count":119,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":84,"mirror_url":null,"open_issues_count":24,"forks":84,"open_issues":24,"watchers":119,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/caelum/vraptor4/pulls/725"},"html":{"href":"https://github.com/caelum/vraptor4/pull/725"},"issue":{"href":"https://api.github.com/repos/caelum/vraptor4/issues/725"},"comments":{"href":"https://api.github.com/repos/caelum/vraptor4/issues/725/comments"},"review_comments":{"href":"https://api.github.com/repos/caelum/vraptor4/pulls/725/comments"},"review_comment":{"href":"https://api.github.com/repos/caelum/vraptor4/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/caelum/vraptor4/pulls/725/commits"},"statuses":{"href":"https://api.github.com/repos/caelum/vraptor4/statuses/b89218ed0d74ba04da71c8b137e50ed2b08f175e"}}}}