GitHub PullRequestEvent at 2014-01-14 00:08:20
Repository: jenkins
Actor: sethvargo
Payload: {"action":"closed","number":114,"pull_request":{"url":"https://api.github.com/repos/opscode-cookbooks/jenkins/pulls/114","id":10498117,"html_url":"https://github.com/opscode-cookbooks/jenkins/pull/114","diff_url":"https://github.com/opscode-cookbooks/jenkins/pull/114.diff","patch_url":"https://github.com/opscode-cookbooks/jenkins/pull/114.patch","issue_url":"https://github.com/opscode-cookbooks/jenkins/pull/114","number":114,"state":"closed","title":"Use the Groovy API","user":{"login":"sethvargo","id":408570,"avatar_url":"https://gravatar.com/avatar/87f282c6c2cdad13100dffe8c1daf77d?d=https%3A%2F%2Fidenticons.github.com%2Fb75f58301305183b958bf0488a88add8.png&r=x","gravatar_id":"87f282c6c2cdad13100dffe8c1daf77d","url":"https://api.github.com/users/sethvargo","html_url":"https://github.com/sethvargo","followers_url":"https://api.github.com/users/sethvargo/followers","following_url":"https://api.github.com/users/sethvargo/following{/other_user}","gists_url":"https://api.github.com/users/sethvargo/gists{/gist_id}","starred_url":"https://api.github.com/users/sethvargo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sethvargo/subscriptions","organizations_url":"https://api.github.com/users/sethvargo/orgs","repos_url":"https://api.github.com/users/sethvargo/repos","events_url":"https://api.github.com/users/sethvargo/events{/privacy}","received_events_url":"https://api.github.com/users/sethvargo/received_events","type":"User","site_admin":false},"body":"For anyone that watches this repository, feel free to comment and take a look, but we are using GitHub to review some potential refactors in the Jenkins cookbook. There's no COOK ticket for this PR.\r\n\r\n### TODO\r\n\r\n- [x] Move everything to HWRPs\r\n- [x] Cleanup attributes\r\n- [x] Remove plugin attributes\r\n- [x] Add smoke tests\r\n- [x] Add timeouts and retries to the executor\r\n- [x] Remove slave/useless recipes\r\n- [ ] Enable issues on this repo\r\n- [ ] Triage existing JIRA tickets and Pull Requests\r\n- [x] Test with authentication\r\n- [x] Remove Java dependency\r\n- [x] Document installing Java\r\n- [x] `jenkins_script` LWRP\r\n- [x] Create Jenkins group\r\n- [x] Figure out authentication bits\r\n- [x] Append `JENKINS_ARGS`\r\n\r\n### Fixes\r\n\r\n- Fixes #119\r\n- Fixes #117 \r\n- Fixes #116 \r\n- Closes #115 \r\n- Fixes #113 \r\n- Fixes #111\r\n- Closes #110\r\n- Closes #109 \r\n- Closes #107 \r\n- Fixes #105 \r\n- Fixes #104 \r\n- Fixes #103 \r\n- Fixes #102 \r\n- Fixes #100 \r\n- Fixes #99 \r\n- Fixes #98 \r\n- Fixes #96 \r\n- Fixes #95 \r\n- Fixes #88 \r\n- Closes #83 \r\n- Closes #82 \r\n- Closes #59\r\n\r\n\r\n/cc @opscode-cookbooks/release-engineers","created_at":"2013-12-04T01:38:32Z","updated_at":"2014-01-14T00:08:18Z","closed_at":"2014-01-14T00:08:18Z","merged_at":"2014-01-14T00:08:18Z","merge_commit_sha":"2775a0acebeaa8b8727a280370e7662d71c88ef6","assignee":{"login":"sethvargo","id":408570,"avatar_url":"https://gravatar.com/avatar/87f282c6c2cdad13100dffe8c1daf77d?d=https%3A%2F%2Fidenticons.github.com%2Fb75f58301305183b958bf0488a88add8.png&r=x","gravatar_id":"87f282c6c2cdad13100dffe8c1daf77d","url":"https://api.github.com/users/sethvargo","html_url":"https://github.com/sethvargo","followers_url":"https://api.github.com/users/sethvargo/followers","following_url":"https://api.github.com/users/sethvargo/following{/other_user}","gists_url":"https://api.github.com/users/sethvargo/gists{/gist_id}","starred_url":"https://api.github.com/users/sethvargo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sethvargo/subscriptions","organizations_url":"https://api.github.com/users/sethvargo/orgs","repos_url":"https://api.github.com/users/sethvargo/repos","events_url":"https://api.github.com/users/sethvargo/events{/privacy}","received_events_url":"https://api.github.com/users/sethvargo/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://github.com/opscode-cookbooks/jenkins/pull/114/commits","review_comments_url":"https://github.com/opscode-cookbooks/jenkins/pull/114/comments","review_comment_url":"/repos/opscode-cookbooks/jenkins/pulls/comments/{number}","comments_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/issues/114/comments","statuses_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/statuses/bdcb658c51f56d481e4534e1030b527f174324bf","head":{"label":"opscode-cookbooks:sethvargo/groovy","ref":"sethvargo/groovy","sha":"bdcb658c51f56d481e4534e1030b527f174324bf","user":{"login":"opscode-cookbooks","id":1537126,"avatar_url":"https://gravatar.com/avatar/d325d33d2ed66c370c0d031e45cf608d?d=https%3A%2F%2Fidenticons.github.com%2F10be37765474641d53381962f0ae2766.png&r=x","gravatar_id":"d325d33d2ed66c370c0d031e45cf608d","url":"https://api.github.com/users/opscode-cookbooks","html_url":"https://github.com/opscode-cookbooks","followers_url":"https://api.github.com/users/opscode-cookbooks/followers","following_url":"https://api.github.com/users/opscode-cookbooks/following{/other_user}","gists_url":"https://api.github.com/users/opscode-cookbooks/gists{/gist_id}","starred_url":"https://api.github.com/users/opscode-cookbooks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opscode-cookbooks/subscriptions","organizations_url":"https://api.github.com/users/opscode-cookbooks/orgs","repos_url":"https://api.github.com/users/opscode-cookbooks/repos","events_url":"https://api.github.com/users/opscode-cookbooks/events{/privacy}","received_events_url":"https://api.github.com/users/opscode-cookbooks/received_events","type":"Organization","site_admin":false},"repo":{"id":7950974,"name":"jenkins","full_name":"opscode-cookbooks/jenkins","owner":{"login":"opscode-cookbooks","id":1537126,"avatar_url":"https://gravatar.com/avatar/d325d33d2ed66c370c0d031e45cf608d?d=https%3A%2F%2Fidenticons.github.com%2F10be37765474641d53381962f0ae2766.png&r=x","gravatar_id":"d325d33d2ed66c370c0d031e45cf608d","url":"https://api.github.com/users/opscode-cookbooks","html_url":"https://github.com/opscode-cookbooks","followers_url":"https://api.github.com/users/opscode-cookbooks/followers","following_url":"https://api.github.com/users/opscode-cookbooks/following{/other_user}","gists_url":"https://api.github.com/users/opscode-cookbooks/gists{/gist_id}","starred_url":"https://api.github.com/users/opscode-cookbooks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opscode-cookbooks/subscriptions","organizations_url":"https://api.github.com/users/opscode-cookbooks/orgs","repos_url":"https://api.github.com/users/opscode-cookbooks/repos","events_url":"https://api.github.com/users/opscode-cookbooks/events{/privacy}","received_events_url":"https://api.github.com/users/opscode-cookbooks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opscode-cookbooks/jenkins","description":"Development repository for Opscode Cookbook jenkins","fork":false,"url":"https://api.github.com/repos/opscode-cookbooks/jenkins","forks_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/forks","keys_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/teams","hooks_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/hooks","issue_events_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/events","assignees_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/tags","blobs_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/languages","stargazers_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/stargazers","contributors_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/contributors","subscribers_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/subscribers","subscription_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/subscription","commits_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/issues/comments/{number}","contents_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/merges","archive_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/downloads","issues_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/labels{/name}","releases_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/releases{/id}","created_at":"2013-02-01T03:23:46Z","updated_at":"2014-01-14T00:08:20Z","pushed_at":"2014-01-14T00:08:17Z","git_url":"git://github.com/opscode-cookbooks/jenkins.git","ssh_url":"git@github.com:opscode-cookbooks/jenkins.git","clone_url":"https://github.com/opscode-cookbooks/jenkins.git","svn_url":"https://github.com/opscode-cookbooks/jenkins","homepage":null,"size":1736,"stargazers_count":61,"watchers_count":61,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":159,"mirror_url":null,"open_issues_count":20,"forks":159,"open_issues":20,"watchers":61,"default_branch":"master","master_branch":"master"}},"base":{"label":"opscode-cookbooks:master","ref":"master","sha":"ece633c2067620edb80c20160991615e539e06a4","user":{"login":"opscode-cookbooks","id":1537126,"avatar_url":"https://gravatar.com/avatar/d325d33d2ed66c370c0d031e45cf608d?d=https%3A%2F%2Fidenticons.github.com%2F10be37765474641d53381962f0ae2766.png&r=x","gravatar_id":"d325d33d2ed66c370c0d031e45cf608d","url":"https://api.github.com/users/opscode-cookbooks","html_url":"https://github.com/opscode-cookbooks","followers_url":"https://api.github.com/users/opscode-cookbooks/followers","following_url":"https://api.github.com/users/opscode-cookbooks/following{/other_user}","gists_url":"https://api.github.com/users/opscode-cookbooks/gists{/gist_id}","starred_url":"https://api.github.com/users/opscode-cookbooks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opscode-cookbooks/subscriptions","organizations_url":"https://api.github.com/users/opscode-cookbooks/orgs","repos_url":"https://api.github.com/users/opscode-cookbooks/repos","events_url":"https://api.github.com/users/opscode-cookbooks/events{/privacy}","received_events_url":"https://api.github.com/users/opscode-cookbooks/received_events","type":"Organization","site_admin":false},"repo":{"id":7950974,"name":"jenkins","full_name":"opscode-cookbooks/jenkins","owner":{"login":"opscode-cookbooks","id":1537126,"avatar_url":"https://gravatar.com/avatar/d325d33d2ed66c370c0d031e45cf608d?d=https%3A%2F%2Fidenticons.github.com%2F10be37765474641d53381962f0ae2766.png&r=x","gravatar_id":"d325d33d2ed66c370c0d031e45cf608d","url":"https://api.github.com/users/opscode-cookbooks","html_url":"https://github.com/opscode-cookbooks","followers_url":"https://api.github.com/users/opscode-cookbooks/followers","following_url":"https://api.github.com/users/opscode-cookbooks/following{/other_user}","gists_url":"https://api.github.com/users/opscode-cookbooks/gists{/gist_id}","starred_url":"https://api.github.com/users/opscode-cookbooks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opscode-cookbooks/subscriptions","organizations_url":"https://api.github.com/users/opscode-cookbooks/orgs","repos_url":"https://api.github.com/users/opscode-cookbooks/repos","events_url":"https://api.github.com/users/opscode-cookbooks/events{/privacy}","received_events_url":"https://api.github.com/users/opscode-cookbooks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opscode-cookbooks/jenkins","description":"Development repository for Opscode Cookbook jenkins","fork":false,"url":"https://api.github.com/repos/opscode-cookbooks/jenkins","forks_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/forks","keys_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/teams","hooks_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/hooks","issue_events_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/events","assignees_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/tags","blobs_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/languages","stargazers_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/stargazers","contributors_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/contributors","subscribers_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/subscribers","subscription_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/subscription","commits_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/issues/comments/{number}","contents_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/merges","archive_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/downloads","issues_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/labels{/name}","releases_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/releases{/id}","created_at":"2013-02-01T03:23:46Z","updated_at":"2014-01-14T00:08:20Z","pushed_at":"2014-01-14T00:08:17Z","git_url":"git://github.com/opscode-cookbooks/jenkins.git","ssh_url":"git@github.com:opscode-cookbooks/jenkins.git","clone_url":"https://github.com/opscode-cookbooks/jenkins.git","svn_url":"https://github.com/opscode-cookbooks/jenkins","homepage":null,"size":1736,"stargazers_count":61,"watchers_count":61,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":159,"mirror_url":null,"open_issues_count":20,"forks":159,"open_issues":20,"watchers":61,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opscode-cookbooks/jenkins/pulls/114"},"html":{"href":"https://github.com/opscode-cookbooks/jenkins/pull/114"},"issue":{"href":"https://api.github.com/repos/opscode-cookbooks/jenkins/issues/114"},"comments":{"href":"https://api.github.com/repos/opscode-cookbooks/jenkins/issues/114/comments"},"review_comments":{"href":"https://api.github.com/repos/opscode-cookbooks/jenkins/pulls/114/comments"},"statuses":{"href":"https://api.github.com/repos/opscode-cookbooks/jenkins/statuses/bdcb658c51f56d481e4534e1030b527f174324bf"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"sethvargo","id":408570,"avatar_url":"https://gravatar.com/avatar/87f282c6c2cdad13100dffe8c1daf77d?d=https%3A%2F%2Fidenticons.github.com%2Fb75f58301305183b958bf0488a88add8.png&r=x","gravatar_id":"87f282c6c2cdad13100dffe8c1daf77d","url":"https://api.github.com/users/sethvargo","html_url":"https://github.com/sethvargo","followers_url":"https://api.github.com/users/sethvargo/followers","following_url":"https://api.github.com/users/sethvargo/following{/other_user}","gists_url":"https://api.github.com/users/sethvargo/gists{/gist_id}","starred_url":"https://api.github.com/users/sethvargo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sethvargo/subscriptions","organizations_url":"https://api.github.com/users/sethvargo/orgs","repos_url":"https://api.github.com/users/sethvargo/repos","events_url":"https://api.github.com/users/sethvargo/events{/privacy}","received_events_url":"https://api.github.com/users/sethvargo/received_events","type":"User","site_admin":false},"comments":0,"review_comments":17,"commits":88,"additions":5734,"deletions":3005,"changed_files":145}}