GitHub PullRequestReviewCommentEvent at 2014-09-25 21:29:28
Repository: mapstruct
Actor: gunnarmorling
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mapstruct/mapstruct/pulls/comments/18061534","id":18061534,"diff_hunk":"@@ -0,0 +1,47 @@\n+/**\n+ *  Copyright 2012-2014 Gunnar Morling (http://www.gunnarmorling.de/)\n+ *  and/or other contributors as indicated by the @authors tag. See the\n+ *  copyright.txt file in the distribution for a full listing of all\n+ *  contributors.\n+ *\n+ *  Licensed under the Apache License, Version 2.0 (the \"License\");\n+ *  you may not use this file except in compliance with the License.\n+ *  You may obtain a copy of the License at\n+ *\n+ *      http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ *  Unless required by applicable law or agreed to in writing, software\n+ *  distributed under the License is distributed on an \"AS IS\" BASIS,\n+ *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ *  See the License for the specific language governing permissions and\n+ *  limitations under the License.\n+ */\n+package org.mapstruct.ap.test.selection.qualifier;\n+\n+import org.mapstruct.ap.test.selection.qualifier.bean.GermanRelease;\n+import org.mapstruct.ap.test.selection.qualifier.bean.OriginalRelease;\n+import org.mapstruct.ap.test.selection.qualifier.handwritten.Titles;\n+import org.mapstruct.Mapper;\n+import org.mapstruct.Mapping;\n+import org.mapstruct.Mappings;\n+import org.mapstruct.ap.test.selection.qualifier.annotation.EnglishToGerman;\n+import org.mapstruct.ap.test.selection.qualifier.annotation.TitleTranslator;\n+import org.mapstruct.ap.test.selection.qualifier.handwritten.SomeOtherMapper;\n+import org.mapstruct.factory.Mappers;\n+\n+/**\n+ *\n+ * @author Sjaak Derksen\n+ */\n+@Mapper( uses = { Titles.class, SomeOtherMapper.class, KeyWordMapper.class, FactMapper.class } )\n+public interface MovieMapper {\n+\n+    MovieMapper INSTANCE = Mappers.getMapper( MovieMapper.class );\n+\n+    @Mappings( {\n+        @Mapping( source = \"title\", qualifiers = { TitleTranslator.class, EnglishToGerman.class } ),\n+//        @Mapping( source = \"keyWords\", target = \"keyWords\", qualifiers = { EnglishToGerman.class } ),","path":"processor/src/test/java/org/mapstruct/ap/test/selection/qualifier/MovieMapper.java","position":43,"original_position":43,"commit_id":"552f80689e5251e285af4213144d3b0a6cbef7c7","original_commit_id":"552f80689e5251e285af4213144d3b0a6cbef7c7","user":{"login":"gunnarmorling","id":28612,"avatar_url":"https://avatars.githubusercontent.com/u/28612?v=2","gravatar_id":"","url":"https://api.github.com/users/gunnarmorling","html_url":"https://github.com/gunnarmorling","followers_url":"https://api.github.com/users/gunnarmorling/followers","following_url":"https://api.github.com/users/gunnarmorling/following{/other_user}","gists_url":"https://api.github.com/users/gunnarmorling/gists{/gist_id}","starred_url":"https://api.github.com/users/gunnarmorling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gunnarmorling/subscriptions","organizations_url":"https://api.github.com/users/gunnarmorling/orgs","repos_url":"https://api.github.com/users/gunnarmorling/repos","events_url":"https://api.github.com/users/gunnarmorling/events{/privacy}","received_events_url":"https://api.github.com/users/gunnarmorling/received_events","type":"User","site_admin":false},"body":"Is this a left-over?","created_at":"2014-09-25T21:29:28Z","updated_at":"2014-09-25T21:29:28Z","html_url":"https://github.com/mapstruct/mapstruct/pull/269#discussion_r18061534","pull_request_url":"https://api.github.com/repos/mapstruct/mapstruct/pulls/269","_links":{"self":{"href":"https://api.github.com/repos/mapstruct/mapstruct/pulls/comments/18061534"},"html":{"href":"https://github.com/mapstruct/mapstruct/pull/269#discussion_r18061534"},"pull_request":{"href":"https://api.github.com/repos/mapstruct/mapstruct/pulls/269"}}},"pull_request":{"url":"https://api.github.com/repos/mapstruct/mapstruct/pulls/269","id":18375518,"html_url":"https://github.com/mapstruct/mapstruct/pull/269","diff_url":"https://github.com/mapstruct/mapstruct/pull/269.diff","patch_url":"https://github.com/mapstruct/mapstruct/pull/269.patch","issue_url":"https://api.github.com/repos/mapstruct/mapstruct/issues/269","number":269,"state":"open","locked":false,"title":"#268 introduction of qualifier","user":{"login":"sjaakd","id":6173283,"avatar_url":"https://avatars.githubusercontent.com/u/6173283?v=2","gravatar_id":"","url":"https://api.github.com/users/sjaakd","html_url":"https://github.com/sjaakd","followers_url":"https://api.github.com/users/sjaakd/followers","following_url":"https://api.github.com/users/sjaakd/following{/other_user}","gists_url":"https://api.github.com/users/sjaakd/gists{/gist_id}","starred_url":"https://api.github.com/users/sjaakd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjaakd/subscriptions","organizations_url":"https://api.github.com/users/sjaakd/orgs","repos_url":"https://api.github.com/users/sjaakd/repos","events_url":"https://api.github.com/users/sjaakd/events{/privacy}","received_events_url":"https://api.github.com/users/sjaakd/received_events","type":"User","site_admin":false},"body":"The solution is more-or less ready.\r\n\r\nI need to add some additional tests to cover different kind of qualifying situations such as:\r\n1. class\r\n2. #method\r\n\r\nAlso I need to add test cases for the `@MapMapping` and `@IterableMapping`.","created_at":"2014-07-14T21:31:57Z","updated_at":"2014-09-25T21:29:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2b922ea96753ed250194c99eadd358613ed50fff","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mapstruct/mapstruct/pulls/269/commits","review_comments_url":"https://api.github.com/repos/mapstruct/mapstruct/pulls/269/comments","review_comment_url":"https://api.github.com/repos/mapstruct/mapstruct/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mapstruct/mapstruct/issues/269/comments","statuses_url":"https://api.github.com/repos/mapstruct/mapstruct/statuses/552f80689e5251e285af4213144d3b0a6cbef7c7","head":{"label":"sjaakd:268","ref":"268","sha":"552f80689e5251e285af4213144d3b0a6cbef7c7","user":{"login":"sjaakd","id":6173283,"avatar_url":"https://avatars.githubusercontent.com/u/6173283?v=2","gravatar_id":"","url":"https://api.github.com/users/sjaakd","html_url":"https://github.com/sjaakd","followers_url":"https://api.github.com/users/sjaakd/followers","following_url":"https://api.github.com/users/sjaakd/following{/other_user}","gists_url":"https://api.github.com/users/sjaakd/gists{/gist_id}","starred_url":"https://api.github.com/users/sjaakd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjaakd/subscriptions","organizations_url":"https://api.github.com/users/sjaakd/orgs","repos_url":"https://api.github.com/users/sjaakd/repos","events_url":"https://api.github.com/users/sjaakd/events{/privacy}","received_events_url":"https://api.github.com/users/sjaakd/received_events","type":"User","site_admin":false},"repo":{"id":15548682,"name":"mapstruct","full_name":"sjaakd/mapstruct","owner":{"login":"sjaakd","id":6173283,"avatar_url":"https://avatars.githubusercontent.com/u/6173283?v=2","gravatar_id":"","url":"https://api.github.com/users/sjaakd","html_url":"https://github.com/sjaakd","followers_url":"https://api.github.com/users/sjaakd/followers","following_url":"https://api.github.com/users/sjaakd/following{/other_user}","gists_url":"https://api.github.com/users/sjaakd/gists{/gist_id}","starred_url":"https://api.github.com/users/sjaakd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjaakd/subscriptions","organizations_url":"https://api.github.com/users/sjaakd/orgs","repos_url":"https://api.github.com/users/sjaakd/repos","events_url":"https://api.github.com/users/sjaakd/events{/privacy}","received_events_url":"https://api.github.com/users/sjaakd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sjaakd/mapstruct","description":"An annotation processor for generating type-safe bean mappers","fork":true,"url":"https://api.github.com/repos/sjaakd/mapstruct","forks_url":"https://api.github.com/repos/sjaakd/mapstruct/forks","keys_url":"https://api.github.com/repos/sjaakd/mapstruct/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sjaakd/mapstruct/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sjaakd/mapstruct/teams","hooks_url":"https://api.github.com/repos/sjaakd/mapstruct/hooks","issue_events_url":"https://api.github.com/repos/sjaakd/mapstruct/issues/events{/number}","events_url":"https://api.github.com/repos/sjaakd/mapstruct/events","assignees_url":"https://api.github.com/repos/sjaakd/mapstruct/assignees{/user}","branches_url":"https://api.github.com/repos/sjaakd/mapstruct/branches{/branch}","tags_url":"https://api.github.com/repos/sjaakd/mapstruct/tags","blobs_url":"https://api.github.com/repos/sjaakd/mapstruct/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sjaakd/mapstruct/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sjaakd/mapstruct/git/refs{/sha}","trees_url":"https://api.github.com/repos/sjaakd/mapstruct/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sjaakd/mapstruct/statuses/{sha}","languages_url":"https://api.github.com/repos/sjaakd/mapstruct/languages","stargazers_url":"https://api.github.com/repos/sjaakd/mapstruct/stargazers","contributors_url":"https://api.github.com/repos/sjaakd/mapstruct/contributors","subscribers_url":"https://api.github.com/repos/sjaakd/mapstruct/subscribers","subscription_url":"https://api.github.com/repos/sjaakd/mapstruct/subscription","commits_url":"https://api.github.com/repos/sjaakd/mapstruct/commits{/sha}","git_commits_url":"https://api.github.com/repos/sjaakd/mapstruct/git/commits{/sha}","comments_url":"https://api.github.com/repos/sjaakd/mapstruct/comments{/number}","issue_comment_url":"https://api.github.com/repos/sjaakd/mapstruct/issues/comments/{number}","contents_url":"https://api.github.com/repos/sjaakd/mapstruct/contents/{+path}","compare_url":"https://api.github.com/repos/sjaakd/mapstruct/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sjaakd/mapstruct/merges","archive_url":"https://api.github.com/repos/sjaakd/mapstruct/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sjaakd/mapstruct/downloads","issues_url":"https://api.github.com/repos/sjaakd/mapstruct/issues{/number}","pulls_url":"https://api.github.com/repos/sjaakd/mapstruct/pulls{/number}","milestones_url":"https://api.github.com/repos/sjaakd/mapstruct/milestones{/number}","notifications_url":"https://api.github.com/repos/sjaakd/mapstruct/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sjaakd/mapstruct/labels{/name}","releases_url":"https://api.github.com/repos/sjaakd/mapstruct/releases{/id}","created_at":"2013-12-31T11:17:00Z","updated_at":"2014-09-02T19:42:05Z","pushed_at":"2014-09-23T22:09:39Z","git_url":"git://github.com/sjaakd/mapstruct.git","ssh_url":"git@github.com:sjaakd/mapstruct.git","clone_url":"https://github.com/sjaakd/mapstruct.git","svn_url":"https://github.com/sjaakd/mapstruct","homepage":"http://mapstruct.org/","size":3935,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mapstruct:master","ref":"master","sha":"2ca4ce5fd52504cdaa707d575a8ecb1e6a21e8fc","user":{"login":"mapstruct","id":4086779,"avatar_url":"https://avatars.githubusercontent.com/u/4086779?v=2","gravatar_id":"","url":"https://api.github.com/users/mapstruct","html_url":"https://github.com/mapstruct","followers_url":"https://api.github.com/users/mapstruct/followers","following_url":"https://api.github.com/users/mapstruct/following{/other_user}","gists_url":"https://api.github.com/users/mapstruct/gists{/gist_id}","starred_url":"https://api.github.com/users/mapstruct/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapstruct/subscriptions","organizations_url":"https://api.github.com/users/mapstruct/orgs","repos_url":"https://api.github.com/users/mapstruct/repos","events_url":"https://api.github.com/users/mapstruct/events{/privacy}","received_events_url":"https://api.github.com/users/mapstruct/received_events","type":"Organization","site_admin":false},"repo":{"id":4470435,"name":"mapstruct","full_name":"mapstruct/mapstruct","owner":{"login":"mapstruct","id":4086779,"avatar_url":"https://avatars.githubusercontent.com/u/4086779?v=2","gravatar_id":"","url":"https://api.github.com/users/mapstruct","html_url":"https://github.com/mapstruct","followers_url":"https://api.github.com/users/mapstruct/followers","following_url":"https://api.github.com/users/mapstruct/following{/other_user}","gists_url":"https://api.github.com/users/mapstruct/gists{/gist_id}","starred_url":"https://api.github.com/users/mapstruct/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapstruct/subscriptions","organizations_url":"https://api.github.com/users/mapstruct/orgs","repos_url":"https://api.github.com/users/mapstruct/repos","events_url":"https://api.github.com/users/mapstruct/events{/privacy}","received_events_url":"https://api.github.com/users/mapstruct/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapstruct/mapstruct","description":"An annotation processor for generating type-safe bean mappers","fork":false,"url":"https://api.github.com/repos/mapstruct/mapstruct","forks_url":"https://api.github.com/repos/mapstruct/mapstruct/forks","keys_url":"https://api.github.com/repos/mapstruct/mapstruct/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapstruct/mapstruct/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapstruct/mapstruct/teams","hooks_url":"https://api.github.com/repos/mapstruct/mapstruct/hooks","issue_events_url":"https://api.github.com/repos/mapstruct/mapstruct/issues/events{/number}","events_url":"https://api.github.com/repos/mapstruct/mapstruct/events","assignees_url":"https://api.github.com/repos/mapstruct/mapstruct/assignees{/user}","branches_url":"https://api.github.com/repos/mapstruct/mapstruct/branches{/branch}","tags_url":"https://api.github.com/repos/mapstruct/mapstruct/tags","blobs_url":"https://api.github.com/repos/mapstruct/mapstruct/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapstruct/mapstruct/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapstruct/mapstruct/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapstruct/mapstruct/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapstruct/mapstruct/statuses/{sha}","languages_url":"https://api.github.com/repos/mapstruct/mapstruct/languages","stargazers_url":"https://api.github.com/repos/mapstruct/mapstruct/stargazers","contributors_url":"https://api.github.com/repos/mapstruct/mapstruct/contributors","subscribers_url":"https://api.github.com/repos/mapstruct/mapstruct/subscribers","subscription_url":"https://api.github.com/repos/mapstruct/mapstruct/subscription","commits_url":"https://api.github.com/repos/mapstruct/mapstruct/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapstruct/mapstruct/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapstruct/mapstruct/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapstruct/mapstruct/issues/comments/{number}","contents_url":"https://api.github.com/repos/mapstruct/mapstruct/contents/{+path}","compare_url":"https://api.github.com/repos/mapstruct/mapstruct/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapstruct/mapstruct/merges","archive_url":"https://api.github.com/repos/mapstruct/mapstruct/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapstruct/mapstruct/downloads","issues_url":"https://api.github.com/repos/mapstruct/mapstruct/issues{/number}","pulls_url":"https://api.github.com/repos/mapstruct/mapstruct/pulls{/number}","milestones_url":"https://api.github.com/repos/mapstruct/mapstruct/milestones{/number}","notifications_url":"https://api.github.com/repos/mapstruct/mapstruct/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapstruct/mapstruct/labels{/name}","releases_url":"https://api.github.com/repos/mapstruct/mapstruct/releases{/id}","created_at":"2012-05-28T12:42:42Z","updated_at":"2014-09-08T11:18:04Z","pushed_at":"2014-09-25T21:16:14Z","git_url":"git://github.com/mapstruct/mapstruct.git","ssh_url":"git@github.com:mapstruct/mapstruct.git","clone_url":"https://github.com/mapstruct/mapstruct.git","svn_url":"https://github.com/mapstruct/mapstruct","homepage":"http://mapstruct.org/","size":5172,"stargazers_count":46,"watchers_count":46,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":64,"forks":15,"open_issues":64,"watchers":46,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapstruct/mapstruct/pulls/269"},"html":{"href":"https://github.com/mapstruct/mapstruct/pull/269"},"issue":{"href":"https://api.github.com/repos/mapstruct/mapstruct/issues/269"},"comments":{"href":"https://api.github.com/repos/mapstruct/mapstruct/issues/269/comments"},"review_comments":{"href":"https://api.github.com/repos/mapstruct/mapstruct/pulls/269/comments"},"review_comment":{"href":"https://api.github.com/repos/mapstruct/mapstruct/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mapstruct/mapstruct/pulls/269/commits"},"statuses":{"href":"https://api.github.com/repos/mapstruct/mapstruct/statuses/552f80689e5251e285af4213144d3b0a6cbef7c7"}}}}