GitHub PullRequestReviewCommentEvent at 2014-07-25 13:53:34
Repository: elasticsearch
Actor: s1monw
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/comments/15401247","id":15401247,"diff_hunk":"@@ -938,6 +938,13 @@ public synchronized ClusterService clusterService() {\n         return getInstances(clazz, new DataNodePredicate());\n     }\n \n+    /**","path":"src/test/java/org/elasticsearch/test/InternalTestCluster.java","position":4,"original_position":4,"commit_id":"f465af66aa837793092722ecfe39b7b90fc2bdda","original_commit_id":"f465af66aa837793092722ecfe39b7b90fc2bdda","user":{"login":"s1monw","id":973334,"avatar_url":"https://avatars.githubusercontent.com/u/973334?","gravatar_id":"8c12b7030c2431ff54d71891a722ff9a","url":"https://api.github.com/users/s1monw","html_url":"https://github.com/s1monw","followers_url":"https://api.github.com/users/s1monw/followers","following_url":"https://api.github.com/users/s1monw/following{/other_user}","gists_url":"https://api.github.com/users/s1monw/gists{/gist_id}","starred_url":"https://api.github.com/users/s1monw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s1monw/subscriptions","organizations_url":"https://api.github.com/users/s1monw/orgs","repos_url":"https://api.github.com/users/s1monw/repos","events_url":"https://api.github.com/users/s1monw/events{/privacy}","received_events_url":"https://api.github.com/users/s1monw/received_events","type":"User","site_admin":false},"body":"since this class is used for the REST tests you also need to enable at least one node to be a benchmark node. There is a setting in the ctor called `enableRandomBenchNodes` and it's currently only used for client nodes and only sometimes but you need to make sure that there is at least one node that is allowed to run benchmarks.","created_at":"2014-07-25T13:53:34Z","updated_at":"2014-07-25T13:53:34Z","html_url":"https://github.com/elasticsearch/elasticsearch/pull/7018#discussion_r15401247","pull_request_url":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/7018","_links":{"self":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/comments/15401247"},"html":{"href":"https://github.com/elasticsearch/elasticsearch/pull/7018#discussion_r15401247"},"pull_request":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/7018"}}},"pull_request":{"url":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/7018","id":18841130,"html_url":"https://github.com/elasticsearch/elasticsearch/pull/7018","diff_url":"https://github.com/elasticsearch/elasticsearch/pull/7018.diff","patch_url":"https://github.com/elasticsearch/elasticsearch/pull/7018.patch","issue_url":"https://api.github.com/repos/elasticsearch/elasticsearch/issues/7018","number":7018,"state":"open","title":"Benchmarks: Re-factored benchmark infra","user":{"login":"aleph-zero","id":452273,"avatar_url":"https://avatars.githubusercontent.com/u/452273?","gravatar_id":"6d1cdd7a4dee25f4338c05ddc917488a","url":"https://api.github.com/users/aleph-zero","html_url":"https://github.com/aleph-zero","followers_url":"https://api.github.com/users/aleph-zero/followers","following_url":"https://api.github.com/users/aleph-zero/following{/other_user}","gists_url":"https://api.github.com/users/aleph-zero/gists{/gist_id}","starred_url":"https://api.github.com/users/aleph-zero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aleph-zero/subscriptions","organizations_url":"https://api.github.com/users/aleph-zero/orgs","repos_url":"https://api.github.com/users/aleph-zero/repos","events_url":"https://api.github.com/users/aleph-zero/events{/privacy}","received_events_url":"https://api.github.com/users/aleph-zero/received_events","type":"User","site_admin":false},"body":"Major re-factoring to use a dual-channel strategy for executing\r\nbenchmarks. Uses cluster metadata for managing lifecycle events, but\r\ntransport channel to send benchmark definitions and results between\r\nmaster and executor nodes.","created_at":"2014-07-24T14:42:22Z","updated_at":"2014-07-25T13:53:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6860c9069a05aadc1c088c650bf8e9fc42d57f39","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/7018/commits","review_comments_url":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/7018/comments","review_comment_url":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/comments/{number}","comments_url":"https://api.github.com/repos/elasticsearch/elasticsearch/issues/7018/comments","statuses_url":"https://api.github.com/repos/elasticsearch/elasticsearch/statuses/f465af66aa837793092722ecfe39b7b90fc2bdda","head":{"label":"aleph-zero:feature/benchmark","ref":"feature/benchmark","sha":"f465af66aa837793092722ecfe39b7b90fc2bdda","user":{"login":"aleph-zero","id":452273,"avatar_url":"https://avatars.githubusercontent.com/u/452273?","gravatar_id":"6d1cdd7a4dee25f4338c05ddc917488a","url":"https://api.github.com/users/aleph-zero","html_url":"https://github.com/aleph-zero","followers_url":"https://api.github.com/users/aleph-zero/followers","following_url":"https://api.github.com/users/aleph-zero/following{/other_user}","gists_url":"https://api.github.com/users/aleph-zero/gists{/gist_id}","starred_url":"https://api.github.com/users/aleph-zero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aleph-zero/subscriptions","organizations_url":"https://api.github.com/users/aleph-zero/orgs","repos_url":"https://api.github.com/users/aleph-zero/repos","events_url":"https://api.github.com/users/aleph-zero/events{/privacy}","received_events_url":"https://api.github.com/users/aleph-zero/received_events","type":"User","site_admin":false},"repo":{"id":15147680,"name":"elasticsearch","full_name":"aleph-zero/elasticsearch","owner":{"login":"aleph-zero","id":452273,"avatar_url":"https://avatars.githubusercontent.com/u/452273?","gravatar_id":"6d1cdd7a4dee25f4338c05ddc917488a","url":"https://api.github.com/users/aleph-zero","html_url":"https://github.com/aleph-zero","followers_url":"https://api.github.com/users/aleph-zero/followers","following_url":"https://api.github.com/users/aleph-zero/following{/other_user}","gists_url":"https://api.github.com/users/aleph-zero/gists{/gist_id}","starred_url":"https://api.github.com/users/aleph-zero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aleph-zero/subscriptions","organizations_url":"https://api.github.com/users/aleph-zero/orgs","repos_url":"https://api.github.com/users/aleph-zero/repos","events_url":"https://api.github.com/users/aleph-zero/events{/privacy}","received_events_url":"https://api.github.com/users/aleph-zero/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aleph-zero/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":true,"url":"https://api.github.com/repos/aleph-zero/elasticsearch","forks_url":"https://api.github.com/repos/aleph-zero/elasticsearch/forks","keys_url":"https://api.github.com/repos/aleph-zero/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aleph-zero/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aleph-zero/elasticsearch/teams","hooks_url":"https://api.github.com/repos/aleph-zero/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/aleph-zero/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/aleph-zero/elasticsearch/events","assignees_url":"https://api.github.com/repos/aleph-zero/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/aleph-zero/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/aleph-zero/elasticsearch/tags","blobs_url":"https://api.github.com/repos/aleph-zero/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aleph-zero/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aleph-zero/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/aleph-zero/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aleph-zero/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/aleph-zero/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/aleph-zero/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/aleph-zero/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/aleph-zero/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/aleph-zero/elasticsearch/subscription","commits_url":"https://api.github.com/repos/aleph-zero/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/aleph-zero/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/aleph-zero/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/aleph-zero/elasticsearch/issues/comments/{number}","contents_url":"https://api.github.com/repos/aleph-zero/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/aleph-zero/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aleph-zero/elasticsearch/merges","archive_url":"https://api.github.com/repos/aleph-zero/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aleph-zero/elasticsearch/downloads","issues_url":"https://api.github.com/repos/aleph-zero/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/aleph-zero/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/aleph-zero/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/aleph-zero/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aleph-zero/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/aleph-zero/elasticsearch/releases{/id}","created_at":"2013-12-12T21:17:10Z","updated_at":"2014-07-14T05:30:29Z","pushed_at":"2014-07-24T14:39:32Z","git_url":"git://github.com/aleph-zero/elasticsearch.git","ssh_url":"git@github.com:aleph-zero/elasticsearch.git","clone_url":"https://github.com/aleph-zero/elasticsearch.git","svn_url":"https://github.com/aleph-zero/elasticsearch","homepage":"http://elasticsearch.org","size":60601,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elasticsearch:feature/benchmark","ref":"feature/benchmark","sha":"c47ad85d6093368681f954c91468bf189ff4364c","user":{"login":"elasticsearch","id":141304,"avatar_url":"https://avatars.githubusercontent.com/u/141304?","gravatar_id":"1aecf795625bbc7251068cfbc39800ab","url":"https://api.github.com/users/elasticsearch","html_url":"https://github.com/elasticsearch","followers_url":"https://api.github.com/users/elasticsearch/followers","following_url":"https://api.github.com/users/elasticsearch/following{/other_user}","gists_url":"https://api.github.com/users/elasticsearch/gists{/gist_id}","starred_url":"https://api.github.com/users/elasticsearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elasticsearch/subscriptions","organizations_url":"https://api.github.com/users/elasticsearch/orgs","repos_url":"https://api.github.com/users/elasticsearch/repos","events_url":"https://api.github.com/users/elasticsearch/events{/privacy}","received_events_url":"https://api.github.com/users/elasticsearch/received_events","type":"Organization","site_admin":false},"repo":{"id":507775,"name":"elasticsearch","full_name":"elasticsearch/elasticsearch","owner":{"login":"elasticsearch","id":141304,"avatar_url":"https://avatars.githubusercontent.com/u/141304?","gravatar_id":"1aecf795625bbc7251068cfbc39800ab","url":"https://api.github.com/users/elasticsearch","html_url":"https://github.com/elasticsearch","followers_url":"https://api.github.com/users/elasticsearch/followers","following_url":"https://api.github.com/users/elasticsearch/following{/other_user}","gists_url":"https://api.github.com/users/elasticsearch/gists{/gist_id}","starred_url":"https://api.github.com/users/elasticsearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elasticsearch/subscriptions","organizations_url":"https://api.github.com/users/elasticsearch/orgs","repos_url":"https://api.github.com/users/elasticsearch/repos","events_url":"https://api.github.com/users/elasticsearch/events{/privacy}","received_events_url":"https://api.github.com/users/elasticsearch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elasticsearch/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":false,"url":"https://api.github.com/repos/elasticsearch/elasticsearch","forks_url":"https://api.github.com/repos/elasticsearch/elasticsearch/forks","keys_url":"https://api.github.com/repos/elasticsearch/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elasticsearch/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elasticsearch/elasticsearch/teams","hooks_url":"https://api.github.com/repos/elasticsearch/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/elasticsearch/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/elasticsearch/elasticsearch/events","assignees_url":"https://api.github.com/repos/elasticsearch/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/elasticsearch/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/elasticsearch/elasticsearch/tags","blobs_url":"https://api.github.com/repos/elasticsearch/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elasticsearch/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elasticsearch/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/elasticsearch/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elasticsearch/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/elasticsearch/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/elasticsearch/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/elasticsearch/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/elasticsearch/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/elasticsearch/elasticsearch/subscription","commits_url":"https://api.github.com/repos/elasticsearch/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/elasticsearch/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/elasticsearch/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/elasticsearch/elasticsearch/issues/comments/{number}","contents_url":"https://api.github.com/repos/elasticsearch/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/elasticsearch/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elasticsearch/elasticsearch/merges","archive_url":"https://api.github.com/repos/elasticsearch/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elasticsearch/elasticsearch/downloads","issues_url":"https://api.github.com/repos/elasticsearch/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/elasticsearch/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/elasticsearch/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elasticsearch/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/elasticsearch/elasticsearch/releases{/id}","created_at":"2010-02-08T13:20:56Z","updated_at":"2014-07-25T12:07:14Z","pushed_at":"2014-07-25T13:25:28Z","git_url":"git://github.com/elasticsearch/elasticsearch.git","ssh_url":"git@github.com:elasticsearch/elasticsearch.git","clone_url":"https://github.com/elasticsearch/elasticsearch.git","svn_url":"https://github.com/elasticsearch/elasticsearch","homepage":"http://elasticsearch.org","size":228870,"stargazers_count":7720,"watchers_count":7720,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":2220,"mirror_url":null,"open_issues_count":889,"forks":2220,"open_issues":889,"watchers":7720,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/7018"},"html":{"href":"https://github.com/elasticsearch/elasticsearch/pull/7018"},"issue":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/issues/7018"},"comments":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/issues/7018/comments"},"review_comments":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/7018/comments"},"review_comment":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/7018/commits"},"statuses":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/statuses/f465af66aa837793092722ecfe39b7b90fc2bdda"}}}}