GitHub PullRequestEvent at 2014-06-27 14:00:40
Repository: EzPriceBundle
Actor: bdunogier
Payload: {"action":"closed","number":12,"pull_request":{"url":"https://api.github.com/repos/ezsystems/EzPriceBundle/pulls/12","id":17639635,"html_url":"https://github.com/ezsystems/EzPriceBundle/pull/12","diff_url":"https://github.com/ezsystems/EzPriceBundle/pull/12.diff","patch_url":"https://github.com/ezsystems/EzPriceBundle/pull/12.patch","issue_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/issues/12","number":12,"state":"closed","title":"Implemented basic Price FieldType.","user":{"login":"bdunogier","id":235928,"avatar_url":"https://avatars.githubusercontent.com/u/235928?","gravatar_id":"b457a5f2bc72a471f47448dc15a3351f","url":"https://api.github.com/users/bdunogier","html_url":"https://github.com/bdunogier","followers_url":"https://api.github.com/users/bdunogier/followers","following_url":"https://api.github.com/users/bdunogier/following{/other_user}","gists_url":"https://api.github.com/users/bdunogier/gists{/gist_id}","starred_url":"https://api.github.com/users/bdunogier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdunogier/subscriptions","organizations_url":"https://api.github.com/users/bdunogier/orgs","repos_url":"https://api.github.com/users/bdunogier/repos","events_url":"https://api.github.com/users/bdunogier/events{/privacy}","received_events_url":"https://api.github.com/users/bdunogier/received_events","type":"User","site_admin":false},"body":"> Part of [EZP-23034](https://jira.ez.no/browse/EZP-23034)\r\n\r\n## Solved use-cases\r\nSimple prices without any kind VAT of conversion.\r\n\r\n## Synopsis\r\n### Value\r\nIt has two properties: `(float)$price` and `(bool)$isVatIncluded`.\r\nIt accepts as input either a float + a boolean, or a hash with the properties as keys.\r\n\r\n### Type\r\n`fromHash()` and `toHash()` are simple dumps or the value's properties.\r\n`acceptValue()` accepts a float as the price\r\n\r\n### Converter\r\nMaps `data_float` to `price`.\r\n`data_text` is split on comma if not empty, and the first item is set to `isVatIncluded`. The second item, `vatId` is ignored\r\n\r\n### Testing\r\nUnit & SPI tests. No API tests yet.\r\n\r\n## Follow-up\r\nManual VAT handling is being worked on in #17. It will be provided via dedicated services with persistence layer implementation.","created_at":"2014-06-26T10:12:37Z","updated_at":"2014-06-27T14:00:39Z","closed_at":"2014-06-27T14:00:39Z","merged_at":"2014-06-27T14:00:39Z","merge_commit_sha":"1a2ee941d4bd46293cda37377e60d8177bfc9cbe","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/pulls/12/commits","review_comments_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/pulls/12/comments","review_comment_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/issues/12/comments","statuses_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/statuses/9b9e30ee689ec5cd647a25d304a2e73013a27fb9","head":{"label":"ezsystems:dev","ref":"dev","sha":"9b9e30ee689ec5cd647a25d304a2e73013a27fb9","user":{"login":"ezsystems","id":295311,"avatar_url":"https://avatars.githubusercontent.com/u/295311?","gravatar_id":"dbbdb060113a80091749fe80be36cff7","url":"https://api.github.com/users/ezsystems","html_url":"https://github.com/ezsystems","followers_url":"https://api.github.com/users/ezsystems/followers","following_url":"https://api.github.com/users/ezsystems/following{/other_user}","gists_url":"https://api.github.com/users/ezsystems/gists{/gist_id}","starred_url":"https://api.github.com/users/ezsystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezsystems/subscriptions","organizations_url":"https://api.github.com/users/ezsystems/orgs","repos_url":"https://api.github.com/users/ezsystems/repos","events_url":"https://api.github.com/users/ezsystems/events{/privacy}","received_events_url":"https://api.github.com/users/ezsystems/received_events","type":"Organization","site_admin":false},"repo":{"id":21032922,"name":"EzPriceBundle","full_name":"ezsystems/EzPriceBundle","owner":{"login":"ezsystems","id":295311,"avatar_url":"https://avatars.githubusercontent.com/u/295311?","gravatar_id":"dbbdb060113a80091749fe80be36cff7","url":"https://api.github.com/users/ezsystems","html_url":"https://github.com/ezsystems","followers_url":"https://api.github.com/users/ezsystems/followers","following_url":"https://api.github.com/users/ezsystems/following{/other_user}","gists_url":"https://api.github.com/users/ezsystems/gists{/gist_id}","starred_url":"https://api.github.com/users/ezsystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezsystems/subscriptions","organizations_url":"https://api.github.com/users/ezsystems/orgs","repos_url":"https://api.github.com/users/ezsystems/repos","events_url":"https://api.github.com/users/ezsystems/events{/privacy}","received_events_url":"https://api.github.com/users/ezsystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ezsystems/EzPriceBundle","description":"Support for products price in eZ Publish 5.x","fork":false,"url":"https://api.github.com/repos/ezsystems/EzPriceBundle","forks_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/forks","keys_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/teams","hooks_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/hooks","issue_events_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/issues/events{/number}","events_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/events","assignees_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/assignees{/user}","branches_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/branches{/branch}","tags_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/tags","blobs_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/languages","stargazers_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/stargazers","contributors_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/contributors","subscribers_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/subscribers","subscription_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/subscription","commits_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/issues/comments/{number}","contents_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/contents/{+path}","compare_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/merges","archive_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/downloads","issues_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/issues{/number}","pulls_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/labels{/name}","releases_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/releases{/id}","created_at":"2014-06-20T09:40:22Z","updated_at":"2014-06-24T18:41:02Z","pushed_at":"2014-06-27T14:00:39Z","git_url":"git://github.com/ezsystems/EzPriceBundle.git","ssh_url":"git@github.com:ezsystems/EzPriceBundle.git","clone_url":"https://github.com/ezsystems/EzPriceBundle.git","svn_url":"https://github.com/ezsystems/EzPriceBundle","homepage":null,"size":823,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1,"mirror_url":null,"open_issues_count":4,"forks":1,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"ezsystems:master","ref":"master","sha":"1e43ed2ebce197b0585bd49e307a5fd3cfd115ed","user":{"login":"ezsystems","id":295311,"avatar_url":"https://avatars.githubusercontent.com/u/295311?","gravatar_id":"dbbdb060113a80091749fe80be36cff7","url":"https://api.github.com/users/ezsystems","html_url":"https://github.com/ezsystems","followers_url":"https://api.github.com/users/ezsystems/followers","following_url":"https://api.github.com/users/ezsystems/following{/other_user}","gists_url":"https://api.github.com/users/ezsystems/gists{/gist_id}","starred_url":"https://api.github.com/users/ezsystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezsystems/subscriptions","organizations_url":"https://api.github.com/users/ezsystems/orgs","repos_url":"https://api.github.com/users/ezsystems/repos","events_url":"https://api.github.com/users/ezsystems/events{/privacy}","received_events_url":"https://api.github.com/users/ezsystems/received_events","type":"Organization","site_admin":false},"repo":{"id":21032922,"name":"EzPriceBundle","full_name":"ezsystems/EzPriceBundle","owner":{"login":"ezsystems","id":295311,"avatar_url":"https://avatars.githubusercontent.com/u/295311?","gravatar_id":"dbbdb060113a80091749fe80be36cff7","url":"https://api.github.com/users/ezsystems","html_url":"https://github.com/ezsystems","followers_url":"https://api.github.com/users/ezsystems/followers","following_url":"https://api.github.com/users/ezsystems/following{/other_user}","gists_url":"https://api.github.com/users/ezsystems/gists{/gist_id}","starred_url":"https://api.github.com/users/ezsystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezsystems/subscriptions","organizations_url":"https://api.github.com/users/ezsystems/orgs","repos_url":"https://api.github.com/users/ezsystems/repos","events_url":"https://api.github.com/users/ezsystems/events{/privacy}","received_events_url":"https://api.github.com/users/ezsystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ezsystems/EzPriceBundle","description":"Support for products price in eZ Publish 5.x","fork":false,"url":"https://api.github.com/repos/ezsystems/EzPriceBundle","forks_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/forks","keys_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/teams","hooks_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/hooks","issue_events_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/issues/events{/number}","events_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/events","assignees_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/assignees{/user}","branches_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/branches{/branch}","tags_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/tags","blobs_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/languages","stargazers_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/stargazers","contributors_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/contributors","subscribers_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/subscribers","subscription_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/subscription","commits_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/issues/comments/{number}","contents_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/contents/{+path}","compare_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/merges","archive_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/downloads","issues_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/issues{/number}","pulls_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/labels{/name}","releases_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/releases{/id}","created_at":"2014-06-20T09:40:22Z","updated_at":"2014-06-24T18:41:02Z","pushed_at":"2014-06-27T14:00:39Z","git_url":"git://github.com/ezsystems/EzPriceBundle.git","ssh_url":"git@github.com:ezsystems/EzPriceBundle.git","clone_url":"https://github.com/ezsystems/EzPriceBundle.git","svn_url":"https://github.com/ezsystems/EzPriceBundle","homepage":null,"size":823,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1,"mirror_url":null,"open_issues_count":4,"forks":1,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ezsystems/EzPriceBundle/pulls/12"},"html":{"href":"https://github.com/ezsystems/EzPriceBundle/pull/12"},"issue":{"href":"https://api.github.com/repos/ezsystems/EzPriceBundle/issues/12"},"comments":{"href":"https://api.github.com/repos/ezsystems/EzPriceBundle/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/ezsystems/EzPriceBundle/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/ezsystems/EzPriceBundle/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ezsystems/EzPriceBundle/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/ezsystems/EzPriceBundle/statuses/9b9e30ee689ec5cd647a25d304a2e73013a27fb9"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"bdunogier","id":235928,"avatar_url":"https://avatars.githubusercontent.com/u/235928?","gravatar_id":"b457a5f2bc72a471f47448dc15a3351f","url":"https://api.github.com/users/bdunogier","html_url":"https://github.com/bdunogier","followers_url":"https://api.github.com/users/bdunogier/followers","following_url":"https://api.github.com/users/bdunogier/following{/other_user}","gists_url":"https://api.github.com/users/bdunogier/gists{/gist_id}","starred_url":"https://api.github.com/users/bdunogier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdunogier/subscriptions","organizations_url":"https://api.github.com/users/bdunogier/orgs","repos_url":"https://api.github.com/users/bdunogier/repos","events_url":"https://api.github.com/users/bdunogier/events{/privacy}","received_events_url":"https://api.github.com/users/bdunogier/received_events","type":"User","site_admin":false},"comments":4,"review_comments":19,"commits":8,"additions":804,"deletions":0,"changed_files":17}}