GitHub PullRequestReviewCommentEvent at 2014-03-05 12:02:32
Repository: rhq
Actor: metlos
Payload: {"comment":{"url":"https://api.github.com/repos/rhq-project/rhq/pulls/comments/10296707","id":10296707,"diff_hunk":"@@ -2289,6 +2289,10 @@\n             <schemaSpec version=\"2.143\">\n               <schema-alterColumn table=\"RHQ_RAW_CONFIG\" column=\"config_ID\" nullable=\"true\"/>\n             </schemaSpec>\n+            <schemaSpec version=\"2.144\">\n+                <schema-addColumn table=\"RHQ_ALERT\" column=\"RECOVERY_TIME\" columnType=\"LONG\" />\n+                <schema-addColumn table=\"RHQ_ALERT\" column=\"RECOVERY_TIME\" nullable=\"false\" />","path":"modules/core/dbutils/src/main/scripts/dbupgrade/db-upgrade.xml","position":6,"original_position":6,"commit_id":"32ab194cd0bf1552caf64332abfe1f648dd37714","original_commit_id":"32ab194cd0bf1552caf64332abfe1f648dd37714","user":{"login":"metlos","id":19999,"avatar_url":"https://gravatar.com/avatar/e8093878046a6dc4d46331e53d59558e?d=https%3A%2F%2Fidenticons.github.com%2F64ce463c6856e0e3867dea50033e8a29.png&r=x","gravatar_id":"e8093878046a6dc4d46331e53d59558e","url":"https://api.github.com/users/metlos","html_url":"https://github.com/metlos","followers_url":"https://api.github.com/users/metlos/followers","following_url":"https://api.github.com/users/metlos/following{/other_user}","gists_url":"https://api.github.com/users/metlos/gists{/gist_id}","starred_url":"https://api.github.com/users/metlos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metlos/subscriptions","organizations_url":"https://api.github.com/users/metlos/orgs","repos_url":"https://api.github.com/users/metlos/repos","events_url":"https://api.github.com/users/metlos/events{/privacy}","received_events_url":"https://api.github.com/users/metlos/received_events","type":"User","site_admin":false},"body":"Shouldn't the second `schema-addColumn` be `schema-alterColumn`? Also, in the dbsetup schema, you set the `RECOVERY_TIME` column to `required=false` which, I believe translates to the column being nullable, while in here, you set it to be non-null.","created_at":"2014-03-05T12:02:32Z","updated_at":"2014-03-05T12:02:32Z","html_url":"https://github.com/rhq-project/rhq/pull/2#discussion_r10296707","pull_request_url":"https://api.github.com/repos/rhq-project/rhq/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/rhq-project/rhq/pulls/comments/10296707"},"html":{"href":"https://github.com/rhq-project/rhq/pull/2#discussion_r10296707"},"pull_request":{"href":"https://api.github.com/repos/rhq-project/rhq/pulls/2"}}}}