GitHub PullRequestReviewCommentEvent at 2014-06-17 20:08:13
Repository: mapzen-android-demo
Actor: ecgreb
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mapzen/mapzen-android-demo/pulls/comments/13881982","id":13881982,"diff_hunk":"@@ -367,6 +365,14 @@ public void onFocusChange(View v, boolean hasFocus) {\n         });\n     }\n \n+    /**\n+     * Returns a reference to the {@link AutoCompleteTextView} inside the given {@link SearchView}.\n+     */\n+    public AutoCompleteTextView getSearchQueryTextView(SearchView searchView) {\n+        return (AutoCompleteTextView) searchView.findViewById(searchView.getContext()\n+                .getResources().getIdentifier(\"android:id/search_src_text\", null, null));","path":"src/main/java/com/mapzen/activity/BaseActivity.java","position":20,"original_position":20,"commit_id":"57074c5447433699957d930eb7860b40d41f0127","original_commit_id":"57074c5447433699957d930eb7860b40d41f0127","user":{"login":"ecgreb","id":464123,"avatar_url":"https://avatars.githubusercontent.com/u/464123?","gravatar_id":"613633962e5ab27cf572e7699e43d368","url":"https://api.github.com/users/ecgreb","html_url":"https://github.com/ecgreb","followers_url":"https://api.github.com/users/ecgreb/followers","following_url":"https://api.github.com/users/ecgreb/following{/other_user}","gists_url":"https://api.github.com/users/ecgreb/gists{/gist_id}","starred_url":"https://api.github.com/users/ecgreb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ecgreb/subscriptions","organizations_url":"https://api.github.com/users/ecgreb/orgs","repos_url":"https://api.github.com/users/ecgreb/repos","events_url":"https://api.github.com/users/ecgreb/events{/privacy}","received_events_url":"https://api.github.com/users/ecgreb/received_events","type":"User","site_admin":false},"body":"Usually the line break is before the operator unless it is an assignment (=) operator.\r\n\r\nhttps://google-styleguide.googlecode.com/svn/trunk/javaguide.html#s4.5.1-line-wrapping-where-to-break","created_at":"2014-06-17T20:08:13Z","updated_at":"2014-06-17T20:08:13Z","html_url":"https://github.com/mapzen/mapzen-android-demo/pull/195#discussion_r13881982","pull_request_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/pulls/195","_links":{"self":{"href":"https://api.github.com/repos/mapzen/mapzen-android-demo/pulls/comments/13881982"},"html":{"href":"https://github.com/mapzen/mapzen-android-demo/pull/195#discussion_r13881982"},"pull_request":{"href":"https://api.github.com/repos/mapzen/mapzen-android-demo/pulls/195"}}},"pull_request":{"url":"https://api.github.com/repos/mapzen/mapzen-android-demo/pulls/195","id":17257305,"html_url":"https://github.com/mapzen/mapzen-android-demo/pull/195","diff_url":"https://github.com/mapzen/mapzen-android-demo/pull/195.diff","patch_url":"https://github.com/mapzen/mapzen-android-demo/pull/195.patch","issue_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/issues/195","number":195,"state":"open","title":"Single search result view","user":{"login":"ecgreb","id":464123,"avatar_url":"https://avatars.githubusercontent.com/u/464123?","gravatar_id":"613633962e5ab27cf572e7699e43d368","url":"https://api.github.com/users/ecgreb","html_url":"https://github.com/ecgreb","followers_url":"https://api.github.com/users/ecgreb/followers","following_url":"https://api.github.com/users/ecgreb/following{/other_user}","gists_url":"https://api.github.com/users/ecgreb/gists{/gist_id}","starred_url":"https://api.github.com/users/ecgreb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ecgreb/subscriptions","organizations_url":"https://api.github.com/users/ecgreb/orgs","repos_url":"https://api.github.com/users/ecgreb/repos","events_url":"https://api.github.com/users/ecgreb/events{/privacy}","received_events_url":"https://api.github.com/users/ecgreb/received_events","type":"User","site_admin":false},"body":"* You got here from selecting from autocomplete\r\n* < takes you all the way out of search mode but keeps the current map view the same\r\n* tapping the text input brings you back to search/ autocomplete w keyboard up\r\n* tapping 'x' clears out search term and brings you back to search view w recent searches and keyboard up.","created_at":"2014-06-17T19:52:26Z","updated_at":"2014-06-17T20:08:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"30c87ea0b77f0b86aa8c07caa3896bb95e729304","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/pulls/195/commits","review_comments_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/pulls/195/comments","review_comment_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/issues/195/comments","statuses_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/statuses/57074c5447433699957d930eb7860b40d41f0127","head":{"label":"mapzen:chuck/single-result-view","ref":"chuck/single-result-view","sha":"57074c5447433699957d930eb7860b40d41f0127","user":{"login":"mapzen","id":5435747,"avatar_url":"https://avatars.githubusercontent.com/u/5435747?","gravatar_id":null,"url":"https://api.github.com/users/mapzen","html_url":"https://github.com/mapzen","followers_url":"https://api.github.com/users/mapzen/followers","following_url":"https://api.github.com/users/mapzen/following{/other_user}","gists_url":"https://api.github.com/users/mapzen/gists{/gist_id}","starred_url":"https://api.github.com/users/mapzen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapzen/subscriptions","organizations_url":"https://api.github.com/users/mapzen/orgs","repos_url":"https://api.github.com/users/mapzen/repos","events_url":"https://api.github.com/users/mapzen/events{/privacy}","received_events_url":"https://api.github.com/users/mapzen/received_events","type":"Organization","site_admin":false},"repo":{"id":14398471,"name":"mapzen-android-demo","full_name":"mapzen/mapzen-android-demo","owner":{"login":"mapzen","id":5435747,"avatar_url":"https://avatars.githubusercontent.com/u/5435747?","gravatar_id":null,"url":"https://api.github.com/users/mapzen","html_url":"https://github.com/mapzen","followers_url":"https://api.github.com/users/mapzen/followers","following_url":"https://api.github.com/users/mapzen/following{/other_user}","gists_url":"https://api.github.com/users/mapzen/gists{/gist_id}","starred_url":"https://api.github.com/users/mapzen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapzen/subscriptions","organizations_url":"https://api.github.com/users/mapzen/orgs","repos_url":"https://api.github.com/users/mapzen/repos","events_url":"https://api.github.com/users/mapzen/events{/privacy}","received_events_url":"https://api.github.com/users/mapzen/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapzen/mapzen-android-demo","description":"Demo app using Mapzen SDKs","fork":false,"url":"https://api.github.com/repos/mapzen/mapzen-android-demo","forks_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/forks","keys_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/teams","hooks_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/hooks","issue_events_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/issues/events{/number}","events_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/events","assignees_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/assignees{/user}","branches_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/branches{/branch}","tags_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/tags","blobs_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/statuses/{sha}","languages_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/languages","stargazers_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/stargazers","contributors_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/contributors","subscribers_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/subscribers","subscription_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/subscription","commits_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/issues/comments/{number}","contents_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/contents/{+path}","compare_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/merges","archive_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/downloads","issues_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/issues{/number}","pulls_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/pulls{/number}","milestones_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/milestones{/number}","notifications_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/labels{/name}","releases_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/releases{/id}","created_at":"2013-11-14T15:12:51Z","updated_at":"2014-06-17T19:52:26Z","pushed_at":"2014-06-17T18:57:48Z","git_url":"git://github.com/mapzen/mapzen-android-demo.git","ssh_url":"git@github.com:mapzen/mapzen-android-demo.git","clone_url":"https://github.com/mapzen/mapzen-android-demo.git","svn_url":"https://github.com/mapzen/mapzen-android-demo","homepage":"","size":27980,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":4,"mirror_url":null,"open_issues_count":6,"forks":4,"open_issues":6,"watchers":9,"default_branch":"master"}},"base":{"label":"mapzen:master","ref":"master","sha":"ccc667463b53f092e2458a5411d64438daeedac3","user":{"login":"mapzen","id":5435747,"avatar_url":"https://avatars.githubusercontent.com/u/5435747?","gravatar_id":null,"url":"https://api.github.com/users/mapzen","html_url":"https://github.com/mapzen","followers_url":"https://api.github.com/users/mapzen/followers","following_url":"https://api.github.com/users/mapzen/following{/other_user}","gists_url":"https://api.github.com/users/mapzen/gists{/gist_id}","starred_url":"https://api.github.com/users/mapzen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapzen/subscriptions","organizations_url":"https://api.github.com/users/mapzen/orgs","repos_url":"https://api.github.com/users/mapzen/repos","events_url":"https://api.github.com/users/mapzen/events{/privacy}","received_events_url":"https://api.github.com/users/mapzen/received_events","type":"Organization","site_admin":false},"repo":{"id":14398471,"name":"mapzen-android-demo","full_name":"mapzen/mapzen-android-demo","owner":{"login":"mapzen","id":5435747,"avatar_url":"https://avatars.githubusercontent.com/u/5435747?","gravatar_id":null,"url":"https://api.github.com/users/mapzen","html_url":"https://github.com/mapzen","followers_url":"https://api.github.com/users/mapzen/followers","following_url":"https://api.github.com/users/mapzen/following{/other_user}","gists_url":"https://api.github.com/users/mapzen/gists{/gist_id}","starred_url":"https://api.github.com/users/mapzen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapzen/subscriptions","organizations_url":"https://api.github.com/users/mapzen/orgs","repos_url":"https://api.github.com/users/mapzen/repos","events_url":"https://api.github.com/users/mapzen/events{/privacy}","received_events_url":"https://api.github.com/users/mapzen/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapzen/mapzen-android-demo","description":"Demo app using Mapzen SDKs","fork":false,"url":"https://api.github.com/repos/mapzen/mapzen-android-demo","forks_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/forks","keys_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/teams","hooks_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/hooks","issue_events_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/issues/events{/number}","events_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/events","assignees_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/assignees{/user}","branches_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/branches{/branch}","tags_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/tags","blobs_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/statuses/{sha}","languages_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/languages","stargazers_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/stargazers","contributors_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/contributors","subscribers_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/subscribers","subscription_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/subscription","commits_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/issues/comments/{number}","contents_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/contents/{+path}","compare_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/merges","archive_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/downloads","issues_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/issues{/number}","pulls_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/pulls{/number}","milestones_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/milestones{/number}","notifications_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/labels{/name}","releases_url":"https://api.github.com/repos/mapzen/mapzen-android-demo/releases{/id}","created_at":"2013-11-14T15:12:51Z","updated_at":"2014-06-17T19:52:26Z","pushed_at":"2014-06-17T18:57:48Z","git_url":"git://github.com/mapzen/mapzen-android-demo.git","ssh_url":"git@github.com:mapzen/mapzen-android-demo.git","clone_url":"https://github.com/mapzen/mapzen-android-demo.git","svn_url":"https://github.com/mapzen/mapzen-android-demo","homepage":"","size":27980,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":4,"mirror_url":null,"open_issues_count":6,"forks":4,"open_issues":6,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapzen/mapzen-android-demo/pulls/195"},"html":{"href":"https://github.com/mapzen/mapzen-android-demo/pull/195"},"issue":{"href":"https://api.github.com/repos/mapzen/mapzen-android-demo/issues/195"},"comments":{"href":"https://api.github.com/repos/mapzen/mapzen-android-demo/issues/195/comments"},"review_comments":{"href":"https://api.github.com/repos/mapzen/mapzen-android-demo/pulls/195/comments"},"review_comment":{"href":"https://api.github.com/repos/mapzen/mapzen-android-demo/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mapzen/mapzen-android-demo/pulls/195/commits"},"statuses":{"href":"https://api.github.com/repos/mapzen/mapzen-android-demo/statuses/57074c5447433699957d930eb7860b40d41f0127"}}}}