GitHub PullRequestReviewCommentEvent at 2014-07-22 17:20:35
Repository: puppetdb
Actor: kbarber
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/comments/15241793","id":15241793,"diff_hunk":"@@ -69,14 +69,14 @@ Restart PuppetDB and monitor your logs for errors. If all goes well your connect\n \n ### Placing your own self-signed CA in a Java Keystore\n \n-If you so desire you can follow the documentation provided in the [PostgreSQL JDBC SSL Client Setup](http://jdbc.postgresql.org/documentation/head/ssl-client.html) instructions. This talks about how to generate a brand new SSL certificate, key and CA. Make sure you place your signed certificate and private key in the locations specified by the `ssl_cert_file` and `ssl_key_file` locations, and that you change the `ssl` setting to `on` in your `postgresql.conf`.\n+If you so desire you can follow the documentation provided in the [PostgreSQL JDBC SSL Client Setup](http://jdbc.postgresql.org/documentation/head/ssl-client.html) instructions. This talks about how to generate a brand new SSL certificate, key and CA. Make sure you place your signed certificate and private key in the locations specified by the `ssl_cert_file` and `ssl_key_file` locations, and that you change the `ssl` setting to `on` in your `postgresql.conf`. Don't forget to give the correct permissions for each file (i.e. `chmod 0600 file`). Otherwise postgresql will reject the key and cert files.\n \n Once this is done you must modify the JDBC url in the database configuration section for PuppetDB. For example:\n \n     [database]\n     classname = org.postgresql.Driver\n     subprotocol = postgresql\n-    subname = //<HOST>:<PORT>/<DATABASE>?ssl=true\n+    subname = //<HOST>:<PORT>/<DATABASE>?ssl=true&sslfactory=org.postgresql.ssl.jdbc4.LibPQFactory&sslmode=verify-ca&sslrootcert=/etc/puppetdb/ssl/ca.pem","path":"documentation/postgres_ssl.markdown","position":16,"original_position":13,"commit_id":"56b21665e5e08715708d402de7bef2cc00a9028e","original_commit_id":"ab57fbd37e3aa79d2f88d2a37d6471b5176003d5","user":{"login":"kbarber","id":80595,"avatar_url":"https://avatars.githubusercontent.com/u/80595?","gravatar_id":"9accebe46504a4777d7b3c9707549dc6","url":"https://api.github.com/users/kbarber","html_url":"https://github.com/kbarber","followers_url":"https://api.github.com/users/kbarber/followers","following_url":"https://api.github.com/users/kbarber/following{/other_user}","gists_url":"https://api.github.com/users/kbarber/gists{/gist_id}","starred_url":"https://api.github.com/users/kbarber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbarber/subscriptions","organizations_url":"https://api.github.com/users/kbarber/orgs","repos_url":"https://api.github.com/users/kbarber/repos","events_url":"https://api.github.com/users/kbarber/events{/privacy}","received_events_url":"https://api.github.com/users/kbarber/received_events","type":"User","site_admin":false},"body":"I'm not even sure client auth is overkill for your requirements though.","created_at":"2014-07-22T17:20:35Z","updated_at":"2014-07-22T17:20:35Z","html_url":"https://github.com/puppetlabs/puppetdb/pull/1017#discussion_r15241793","pull_request_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1017","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/comments/15241793"},"html":{"href":"https://github.com/puppetlabs/puppetdb/pull/1017#discussion_r15241793"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1017"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1017","id":18671114,"html_url":"https://github.com/puppetlabs/puppetdb/pull/1017","diff_url":"https://github.com/puppetlabs/puppetdb/pull/1017.diff","patch_url":"https://github.com/puppetlabs/puppetdb/pull/1017.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/1017","number":1017,"state":"open","title":"Update puppetDB docs to include info on LibPQFactory","user":{"login":"briancain","id":810277,"avatar_url":"https://avatars.githubusercontent.com/u/810277?","gravatar_id":"dcb438117ec14a9eea701fe495053173","url":"https://api.github.com/users/briancain","html_url":"https://github.com/briancain","followers_url":"https://api.github.com/users/briancain/followers","following_url":"https://api.github.com/users/briancain/following{/other_user}","gists_url":"https://api.github.com/users/briancain/gists{/gist_id}","starred_url":"https://api.github.com/users/briancain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briancain/subscriptions","organizations_url":"https://api.github.com/users/briancain/orgs","repos_url":"https://api.github.com/users/briancain/repos","events_url":"https://api.github.com/users/briancain/events{/privacy}","received_events_url":"https://api.github.com/users/briancain/received_events","type":"User","site_admin":false},"body":"Prior to this commit, the docs only enabled ssl for postgresql\r\nconnections. This commit changes the docs to add a few extra lines in\r\nthe database.ini file to use host cert/key and CA cert for verification\r\nwith ssl.","created_at":"2014-07-21T18:34:28Z","updated_at":"2014-07-22T17:20:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"19a1a032e27296b0eb0da7baa0df2ff20628566d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1017/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1017/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/comments/{number}","comments_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/1017/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppetdb/statuses/56b21665e5e08715708d402de7bef2cc00a9028e","head":{"label":"briancain:maint/master/modify-psql-ssl-docs","ref":"maint/master/modify-psql-ssl-docs","sha":"56b21665e5e08715708d402de7bef2cc00a9028e","user":{"login":"briancain","id":810277,"avatar_url":"https://avatars.githubusercontent.com/u/810277?","gravatar_id":"dcb438117ec14a9eea701fe495053173","url":"https://api.github.com/users/briancain","html_url":"https://github.com/briancain","followers_url":"https://api.github.com/users/briancain/followers","following_url":"https://api.github.com/users/briancain/following{/other_user}","gists_url":"https://api.github.com/users/briancain/gists{/gist_id}","starred_url":"https://api.github.com/users/briancain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briancain/subscriptions","organizations_url":"https://api.github.com/users/briancain/orgs","repos_url":"https://api.github.com/users/briancain/repos","events_url":"https://api.github.com/users/briancain/events{/privacy}","received_events_url":"https://api.github.com/users/briancain/received_events","type":"User","site_admin":false},"repo":{"id":10394598,"name":"puppetdb","full_name":"briancain/puppetdb","owner":{"login":"briancain","id":810277,"avatar_url":"https://avatars.githubusercontent.com/u/810277?","gravatar_id":"dcb438117ec14a9eea701fe495053173","url":"https://api.github.com/users/briancain","html_url":"https://github.com/briancain","followers_url":"https://api.github.com/users/briancain/followers","following_url":"https://api.github.com/users/briancain/following{/other_user}","gists_url":"https://api.github.com/users/briancain/gists{/gist_id}","starred_url":"https://api.github.com/users/briancain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briancain/subscriptions","organizations_url":"https://api.github.com/users/briancain/orgs","repos_url":"https://api.github.com/users/briancain/repos","events_url":"https://api.github.com/users/briancain/events{/privacy}","received_events_url":"https://api.github.com/users/briancain/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/briancain/puppetdb","description":"Centralized Puppet Storage","fork":true,"url":"https://api.github.com/repos/briancain/puppetdb","forks_url":"https://api.github.com/repos/briancain/puppetdb/forks","keys_url":"https://api.github.com/repos/briancain/puppetdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/briancain/puppetdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/briancain/puppetdb/teams","hooks_url":"https://api.github.com/repos/briancain/puppetdb/hooks","issue_events_url":"https://api.github.com/repos/briancain/puppetdb/issues/events{/number}","events_url":"https://api.github.com/repos/briancain/puppetdb/events","assignees_url":"https://api.github.com/repos/briancain/puppetdb/assignees{/user}","branches_url":"https://api.github.com/repos/briancain/puppetdb/branches{/branch}","tags_url":"https://api.github.com/repos/briancain/puppetdb/tags","blobs_url":"https://api.github.com/repos/briancain/puppetdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/briancain/puppetdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/briancain/puppetdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/briancain/puppetdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/briancain/puppetdb/statuses/{sha}","languages_url":"https://api.github.com/repos/briancain/puppetdb/languages","stargazers_url":"https://api.github.com/repos/briancain/puppetdb/stargazers","contributors_url":"https://api.github.com/repos/briancain/puppetdb/contributors","subscribers_url":"https://api.github.com/repos/briancain/puppetdb/subscribers","subscription_url":"https://api.github.com/repos/briancain/puppetdb/subscription","commits_url":"https://api.github.com/repos/briancain/puppetdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/briancain/puppetdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/briancain/puppetdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/briancain/puppetdb/issues/comments/{number}","contents_url":"https://api.github.com/repos/briancain/puppetdb/contents/{+path}","compare_url":"https://api.github.com/repos/briancain/puppetdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/briancain/puppetdb/merges","archive_url":"https://api.github.com/repos/briancain/puppetdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/briancain/puppetdb/downloads","issues_url":"https://api.github.com/repos/briancain/puppetdb/issues{/number}","pulls_url":"https://api.github.com/repos/briancain/puppetdb/pulls{/number}","milestones_url":"https://api.github.com/repos/briancain/puppetdb/milestones{/number}","notifications_url":"https://api.github.com/repos/briancain/puppetdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/briancain/puppetdb/labels{/name}","releases_url":"https://api.github.com/repos/briancain/puppetdb/releases{/id}","created_at":"2013-05-31T00:03:17Z","updated_at":"2014-07-21T16:04:59Z","pushed_at":"2014-07-22T16:45:53Z","git_url":"git://github.com/briancain/puppetdb.git","ssh_url":"git@github.com:briancain/puppetdb.git","clone_url":"https://github.com/briancain/puppetdb.git","svn_url":"https://github.com/briancain/puppetdb","homepage":"http://docs.puppetlabs.com/puppetdb","size":5900,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"fadbeec019c8cf6817decd494ad98caf9c27f972","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?","gravatar_id":"eb454c2139c156db7c8266a875519a1f","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":2193032,"name":"puppetdb","full_name":"puppetlabs/puppetdb","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?","gravatar_id":"eb454c2139c156db7c8266a875519a1f","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppetdb","description":"Centralized Puppet Storage","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppetdb","forks_url":"https://api.github.com/repos/puppetlabs/puppetdb/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppetdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppetdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppetdb/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppetdb/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppetdb/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppetdb/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppetdb/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppetdb/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppetdb/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppetdb/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppetdb/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppetdb/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppetdb/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppetdb/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppetdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppetdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/comments/{number}","contents_url":"https://api.github.com/repos/puppetlabs/puppetdb/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppetdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppetdb/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppetdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppetdb/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppetdb/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppetdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppetdb/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppetdb/releases{/id}","created_at":"2011-08-11T18:54:46Z","updated_at":"2014-06-30T10:53:36Z","pushed_at":"2014-07-22T09:37:25Z","git_url":"git://github.com/puppetlabs/puppetdb.git","ssh_url":"git@github.com:puppetlabs/puppetdb.git","clone_url":"https://github.com/puppetlabs/puppetdb.git","svn_url":"https://github.com/puppetlabs/puppetdb","homepage":"http://docs.puppetlabs.com/puppetdb","size":17206,"stargazers_count":141,"watchers_count":141,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":104,"mirror_url":null,"open_issues_count":2,"forks":104,"open_issues":2,"watchers":141,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1017"},"html":{"href":"https://github.com/puppetlabs/puppetdb/pull/1017"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/issues/1017"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/issues/1017/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1017/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1017/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/statuses/56b21665e5e08715708d402de7bef2cc00a9028e"}}}}