GitHub PullRequestReviewCommentEvent at 2014-08-23 16:45:56
Repository: core
Actor: craigh
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/zikula/core/pulls/comments/16631600","id":16631600,"diff_hunk":"@@ -209,38 +209,12 @@ function smarty_function_pager($params, Zikula_View $view)\n                         }\n                         break;\n                     case 'lang':\n-                        $addcurrentlang2url = System::getVar('languageurl');\n-                        if ($addcurrentlang2url == 0) {\n+                        if (System::getVar('languageurl') == 0) {\n                             $pager['args'][$k] =  $v;\n                         }\n                         break;\n                     default:\n-                        if (is_array($v)) {\n-                            foreach ($v as $kk => $vv) {\n-                                if (is_array($vv)) {\n-                                    foreach ($vv as $kkk => $vvv) {\n-                                        if (is_array($vvv)) {\n-                                            foreach ($vvv as $kkkk => $vvvv) {\n-                                                if (strlen($vvvv)) {\n-                                                    $tkey = $k . '[' . $kk . '][' . $kkk . '][' . $kkkk . ']';\n-                                                    $pager['args'][$tkey] = $vvvv;\n-                                                }\n-                                            }\n-                                        } elseif (strlen($vvv)) {\n-                                            $tkey = $k . '[' . $kk . '][' . $kkk . ']';\n-                                            $pager['args'][$tkey] = $vvv;\n-                                        }\n-                                    }\n-                                } elseif (strlen($vv)) {\n-                                    $tkey = $k . '[' . $kk . ']';\n-                                    $pager['args'][$tkey] =  $vv;\n-                                }\n-                            }\n-                        } else {\n-                            if (strlen($v)) {\n-                                $pager['args'][$k] =  $v;\n-                            }\n-                        }\n+                        $pager['args'][$k] =  $v;\n                 }","path":"src/lib/legacy/viewplugins/function.pager.php","position":38,"original_position":38,"commit_id":"66c17e51b8e936484493697700a2fcb79f292ffd","original_commit_id":"66c17e51b8e936484493697700a2fcb79f292ffd","user":{"login":"craigh","id":350048,"avatar_url":"https://avatars.githubusercontent.com/u/350048?v=2","gravatar_id":"dbb409dcf37f0c1cfc45d22afacb1d09","url":"https://api.github.com/users/craigh","html_url":"https://github.com/craigh","followers_url":"https://api.github.com/users/craigh/followers","following_url":"https://api.github.com/users/craigh/following{/other_user}","gists_url":"https://api.github.com/users/craigh/gists{/gist_id}","starred_url":"https://api.github.com/users/craigh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craigh/subscriptions","organizations_url":"https://api.github.com/users/craigh/orgs","repos_url":"https://api.github.com/users/craigh/repos","events_url":"https://api.github.com/users/craigh/events{/privacy}","received_events_url":"https://api.github.com/users/craigh/received_events","type":"User","site_admin":false},"body":"extra space.","created_at":"2014-08-23T16:45:56Z","updated_at":"2014-08-23T16:45:56Z","html_url":"https://github.com/zikula/core/pull/1944#discussion_r16631600","pull_request_url":"https://api.github.com/repos/zikula/core/pulls/1944","_links":{"self":{"href":"https://api.github.com/repos/zikula/core/pulls/comments/16631600"},"html":{"href":"https://github.com/zikula/core/pull/1944#discussion_r16631600"},"pull_request":{"href":"https://api.github.com/repos/zikula/core/pulls/1944"}}},"pull_request":{"url":"https://api.github.com/repos/zikula/core/pulls/1944","id":19991389,"html_url":"https://github.com/zikula/core/pull/1944","diff_url":"https://github.com/zikula/core/pull/1944.diff","patch_url":"https://github.com/zikula/core/pull/1944.patch","issue_url":"https://api.github.com/repos/zikula/core/issues/1944","number":1944,"state":"open","locked":false,"title":"[WIP] Better query creation","user":{"login":"cmfcmf","id":2145092,"avatar_url":"https://avatars.githubusercontent.com/u/2145092?v=2","gravatar_id":"7ed38fddec9e6f79b68797cceb4577c2","url":"https://api.github.com/users/cmfcmf","html_url":"https://github.com/cmfcmf","followers_url":"https://api.github.com/users/cmfcmf/followers","following_url":"https://api.github.com/users/cmfcmf/following{/other_user}","gists_url":"https://api.github.com/users/cmfcmf/gists{/gist_id}","starred_url":"https://api.github.com/users/cmfcmf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmfcmf/subscriptions","organizations_url":"https://api.github.com/users/cmfcmf/orgs","repos_url":"https://api.github.com/users/cmfcmf/repos","events_url":"https://api.github.com/users/cmfcmf/events{/privacy}","received_events_url":"https://api.github.com/users/cmfcmf/received_events","type":"User","site_admin":false},"body":"I will need to test the url generation before merge.","created_at":"2014-08-19T16:19:08Z","updated_at":"2014-08-23T16:45:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e66eb411f1e770856334d57a9a82facf782857c4","assignee":null,"milestone":{"url":"https://api.github.com/repos/zikula/core/milestones/8","labels_url":"https://api.github.com/repos/zikula/core/milestones/8/labels","id":219097,"number":8,"title":"1.4.0","description":"Standards:\r\n- [x] maintain BC with 1.3.x\r\n\r\nNew Features:\r\n- [x] Basic integration of Symfony\r\n  - [ ] Symfony routing\r\n  - [x] Symfony events\r\n  - [x] Full Doctrine integration\r\n- [x] Namespaced extensions (psr-0 & psr-4)\r\n- [x] Integration of Composer and use of dependencies\r\n","creator":{"login":"drak","id":251852,"avatar_url":"https://avatars.githubusercontent.com/u/251852?v=2","gravatar_id":"14b567df9276f4bdb5acbcbc72b03bec","url":"https://api.github.com/users/drak","html_url":"https://github.com/drak","followers_url":"https://api.github.com/users/drak/followers","following_url":"https://api.github.com/users/drak/following{/other_user}","gists_url":"https://api.github.com/users/drak/gists{/gist_id}","starred_url":"https://api.github.com/users/drak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drak/subscriptions","organizations_url":"https://api.github.com/users/drak/orgs","repos_url":"https://api.github.com/users/drak/repos","events_url":"https://api.github.com/users/drak/events{/privacy}","received_events_url":"https://api.github.com/users/drak/received_events","type":"User","site_admin":false},"open_issues":62,"closed_issues":931,"state":"open","created_at":"2012-11-26T19:19:16Z","updated_at":"2014-08-23T16:38:17Z","due_on":"2014-08-31T07:00:00Z"},"commits_url":"https://api.github.com/repos/zikula/core/pulls/1944/commits","review_comments_url":"https://api.github.com/repos/zikula/core/pulls/1944/comments","review_comment_url":"https://api.github.com/repos/zikula/core/pulls/comments/{number}","comments_url":"https://api.github.com/repos/zikula/core/issues/1944/comments","statuses_url":"https://api.github.com/repos/zikula/core/statuses/66c17e51b8e936484493697700a2fcb79f292ffd","head":{"label":"cmfcmf:better-query-creation","ref":"better-query-creation","sha":"66c17e51b8e936484493697700a2fcb79f292ffd","user":{"login":"cmfcmf","id":2145092,"avatar_url":"https://avatars.githubusercontent.com/u/2145092?v=2","gravatar_id":"7ed38fddec9e6f79b68797cceb4577c2","url":"https://api.github.com/users/cmfcmf","html_url":"https://github.com/cmfcmf","followers_url":"https://api.github.com/users/cmfcmf/followers","following_url":"https://api.github.com/users/cmfcmf/following{/other_user}","gists_url":"https://api.github.com/users/cmfcmf/gists{/gist_id}","starred_url":"https://api.github.com/users/cmfcmf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmfcmf/subscriptions","organizations_url":"https://api.github.com/users/cmfcmf/orgs","repos_url":"https://api.github.com/users/cmfcmf/repos","events_url":"https://api.github.com/users/cmfcmf/events{/privacy}","received_events_url":"https://api.github.com/users/cmfcmf/received_events","type":"User","site_admin":false},"repo":{"id":7422263,"name":"core","full_name":"cmfcmf/core","owner":{"login":"cmfcmf","id":2145092,"avatar_url":"https://avatars.githubusercontent.com/u/2145092?v=2","gravatar_id":"7ed38fddec9e6f79b68797cceb4577c2","url":"https://api.github.com/users/cmfcmf","html_url":"https://github.com/cmfcmf","followers_url":"https://api.github.com/users/cmfcmf/followers","following_url":"https://api.github.com/users/cmfcmf/following{/other_user}","gists_url":"https://api.github.com/users/cmfcmf/gists{/gist_id}","starred_url":"https://api.github.com/users/cmfcmf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmfcmf/subscriptions","organizations_url":"https://api.github.com/users/cmfcmf/orgs","repos_url":"https://api.github.com/users/cmfcmf/repos","events_url":"https://api.github.com/users/cmfcmf/events{/privacy}","received_events_url":"https://api.github.com/users/cmfcmf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cmfcmf/core","description":"Zikula Core Framework","fork":true,"url":"https://api.github.com/repos/cmfcmf/core","forks_url":"https://api.github.com/repos/cmfcmf/core/forks","keys_url":"https://api.github.com/repos/cmfcmf/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cmfcmf/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cmfcmf/core/teams","hooks_url":"https://api.github.com/repos/cmfcmf/core/hooks","issue_events_url":"https://api.github.com/repos/cmfcmf/core/issues/events{/number}","events_url":"https://api.github.com/repos/cmfcmf/core/events","assignees_url":"https://api.github.com/repos/cmfcmf/core/assignees{/user}","branches_url":"https://api.github.com/repos/cmfcmf/core/branches{/branch}","tags_url":"https://api.github.com/repos/cmfcmf/core/tags","blobs_url":"https://api.github.com/repos/cmfcmf/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cmfcmf/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cmfcmf/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/cmfcmf/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cmfcmf/core/statuses/{sha}","languages_url":"https://api.github.com/repos/cmfcmf/core/languages","stargazers_url":"https://api.github.com/repos/cmfcmf/core/stargazers","contributors_url":"https://api.github.com/repos/cmfcmf/core/contributors","subscribers_url":"https://api.github.com/repos/cmfcmf/core/subscribers","subscription_url":"https://api.github.com/repos/cmfcmf/core/subscription","commits_url":"https://api.github.com/repos/cmfcmf/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/cmfcmf/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/cmfcmf/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/cmfcmf/core/issues/comments/{number}","contents_url":"https://api.github.com/repos/cmfcmf/core/contents/{+path}","compare_url":"https://api.github.com/repos/cmfcmf/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cmfcmf/core/merges","archive_url":"https://api.github.com/repos/cmfcmf/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cmfcmf/core/downloads","issues_url":"https://api.github.com/repos/cmfcmf/core/issues{/number}","pulls_url":"https://api.github.com/repos/cmfcmf/core/pulls{/number}","milestones_url":"https://api.github.com/repos/cmfcmf/core/milestones{/number}","notifications_url":"https://api.github.com/repos/cmfcmf/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cmfcmf/core/labels{/name}","releases_url":"https://api.github.com/repos/cmfcmf/core/releases{/id}","created_at":"2013-01-03T12:08:11Z","updated_at":"2014-07-22T17:47:58Z","pushed_at":"2014-08-23T14:36:11Z","git_url":"git://github.com/cmfcmf/core.git","ssh_url":"git@github.com:cmfcmf/core.git","clone_url":"https://github.com/cmfcmf/core.git","svn_url":"https://github.com/cmfcmf/core","homepage":"http://zikula.org/","size":45459,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"1.4"}},"base":{"label":"zikula:1.4","ref":"1.4","sha":"1651c81789046697c009762705ee6c9b9a1a58ec","user":{"login":"zikula","id":251211,"avatar_url":"https://avatars.githubusercontent.com/u/251211?v=2","gravatar_id":"3fd5789306d06e2132208fd964a7b9f5","url":"https://api.github.com/users/zikula","html_url":"https://github.com/zikula","followers_url":"https://api.github.com/users/zikula/followers","following_url":"https://api.github.com/users/zikula/following{/other_user}","gists_url":"https://api.github.com/users/zikula/gists{/gist_id}","starred_url":"https://api.github.com/users/zikula/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zikula/subscriptions","organizations_url":"https://api.github.com/users/zikula/orgs","repos_url":"https://api.github.com/users/zikula/repos","events_url":"https://api.github.com/users/zikula/events{/privacy}","received_events_url":"https://api.github.com/users/zikula/received_events","type":"Organization","site_admin":false},"repo":{"id":781544,"name":"core","full_name":"zikula/core","owner":{"login":"zikula","id":251211,"avatar_url":"https://avatars.githubusercontent.com/u/251211?v=2","gravatar_id":"3fd5789306d06e2132208fd964a7b9f5","url":"https://api.github.com/users/zikula","html_url":"https://github.com/zikula","followers_url":"https://api.github.com/users/zikula/followers","following_url":"https://api.github.com/users/zikula/following{/other_user}","gists_url":"https://api.github.com/users/zikula/gists{/gist_id}","starred_url":"https://api.github.com/users/zikula/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zikula/subscriptions","organizations_url":"https://api.github.com/users/zikula/orgs","repos_url":"https://api.github.com/users/zikula/repos","events_url":"https://api.github.com/users/zikula/events{/privacy}","received_events_url":"https://api.github.com/users/zikula/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zikula/core","description":"Zikula Core Framework","fork":false,"url":"https://api.github.com/repos/zikula/core","forks_url":"https://api.github.com/repos/zikula/core/forks","keys_url":"https://api.github.com/repos/zikula/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zikula/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zikula/core/teams","hooks_url":"https://api.github.com/repos/zikula/core/hooks","issue_events_url":"https://api.github.com/repos/zikula/core/issues/events{/number}","events_url":"https://api.github.com/repos/zikula/core/events","assignees_url":"https://api.github.com/repos/zikula/core/assignees{/user}","branches_url":"https://api.github.com/repos/zikula/core/branches{/branch}","tags_url":"https://api.github.com/repos/zikula/core/tags","blobs_url":"https://api.github.com/repos/zikula/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zikula/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zikula/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/zikula/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zikula/core/statuses/{sha}","languages_url":"https://api.github.com/repos/zikula/core/languages","stargazers_url":"https://api.github.com/repos/zikula/core/stargazers","contributors_url":"https://api.github.com/repos/zikula/core/contributors","subscribers_url":"https://api.github.com/repos/zikula/core/subscribers","subscription_url":"https://api.github.com/repos/zikula/core/subscription","commits_url":"https://api.github.com/repos/zikula/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/zikula/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/zikula/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/zikula/core/issues/comments/{number}","contents_url":"https://api.github.com/repos/zikula/core/contents/{+path}","compare_url":"https://api.github.com/repos/zikula/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zikula/core/merges","archive_url":"https://api.github.com/repos/zikula/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zikula/core/downloads","issues_url":"https://api.github.com/repos/zikula/core/issues{/number}","pulls_url":"https://api.github.com/repos/zikula/core/pulls{/number}","milestones_url":"https://api.github.com/repos/zikula/core/milestones{/number}","notifications_url":"https://api.github.com/repos/zikula/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zikula/core/labels{/name}","releases_url":"https://api.github.com/repos/zikula/core/releases{/id}","created_at":"2010-07-18T10:35:53Z","updated_at":"2014-07-25T10:58:59Z","pushed_at":"2014-08-23T14:41:30Z","git_url":"git://github.com/zikula/core.git","ssh_url":"git@github.com:zikula/core.git","clone_url":"https://github.com/zikula/core.git","svn_url":"https://github.com/zikula/core","homepage":"http://zikula.org/","size":59082,"stargazers_count":145,"watchers_count":145,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":68,"mirror_url":null,"open_issues_count":111,"forks":68,"open_issues":111,"watchers":145,"default_branch":"1.4"}},"_links":{"self":{"href":"https://api.github.com/repos/zikula/core/pulls/1944"},"html":{"href":"https://github.com/zikula/core/pull/1944"},"issue":{"href":"https://api.github.com/repos/zikula/core/issues/1944"},"comments":{"href":"https://api.github.com/repos/zikula/core/issues/1944/comments"},"review_comments":{"href":"https://api.github.com/repos/zikula/core/pulls/1944/comments"},"review_comment":{"href":"https://api.github.com/repos/zikula/core/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/zikula/core/pulls/1944/commits"},"statuses":{"href":"https://api.github.com/repos/zikula/core/statuses/66c17e51b8e936484493697700a2fcb79f292ffd"}}}}