GitHub PullRequestReviewCommentEvent at 2014-05-09 22:19:09
Repository: https-everywhere
Actor: jgillula
Payload: {"comment":{"url":"https://api.github.com/repos/EFForg/https-everywhere/pulls/comments/12498494","id":12498494,"diff_hunk":"@@ -43,6 +43,12 @@ to turn it on?\">-->\n <!ENTITY ssl-observatory.prefs.asn_tooltip\n \"هذا سيجلب و يرسل &quot;رقم النظام المستقل&quot; الخاص بشبكتك. هذا سيساعدنا على تحديد موقع الهجمات ضد HTTPS، وتحديد ما إذا كان لدينا ملاحظات من شبكات في أماكن مثل سوريا وإيران حيث هذه الهجمات شائعة نسبياً.\">\n \n+<!ENTITY ssl-observatory.prefs.show_cert_warning","path":"src/chrome/locale/ar/ssl-observatory.dtd","position":4,"original_position":4,"commit_id":"99480fe2259c424f861e2cd80f625bdb9e40d5f0","original_commit_id":"99480fe2259c424f861e2cd80f625bdb9e40d5f0","user":{"login":"jgillula","id":6627267,"avatar_url":"https://avatars.githubusercontent.com/u/6627267?","gravatar_id":"14dd2d627d534d4630a9871e87e838d7","url":"https://api.github.com/users/jgillula","html_url":"https://github.com/jgillula","followers_url":"https://api.github.com/users/jgillula/followers","following_url":"https://api.github.com/users/jgillula/following{/other_user}","gists_url":"https://api.github.com/users/jgillula/gists{/gist_id}","starred_url":"https://api.github.com/users/jgillula/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgillula/subscriptions","organizations_url":"https://api.github.com/users/jgillula/orgs","repos_url":"https://api.github.com/users/jgillula/repos","events_url":"https://api.github.com/users/jgillula/events{/privacy}","received_events_url":"https://api.github.com/users/jgillula/received_events","type":"User","site_admin":false},"body":"Yeah, I left it that way since I found a few other places where \ntranslations were missing and left blank instead of having the English \nequivalent, so I thought that was our default.  I'll go ahead and change \nit and submit a new pull request.\nOn 05/09/2014 03:17 PM, Yan Zhu wrote:\n>\n> In src/chrome/locale/ar/ssl-observatory.dtd:\n>\n> > @@ -43,6 +43,12 @@ to turn it on?\">-->\n> >  <!ENTITY ssl-observatory.prefs.asn_tooltip\n> >  \"هذا سيجلب و يرسل &quot;رقم النظام المستقل&quot; الخاص بشبكتك. هذا سيساعدنا على تحديد موقع الهجمات ضد HTTPS، وتحديد ما إذا كان لدينا ملاحظات من شبكات في أماكن مثل سوريا وإيران حيث هذه الهجمات شائعة نسبياً.\">\n> >\n> > +<!ENTITY ssl-observatory.prefs.show_cert_warning\n>\n> Won't this mean that the warning is just empty for non-english \n> locales? Better to show them the english text so they can copy and \n> paste into an automatic translator if needed.\n>\n> —\n> Reply to this email directly or view it on GitHub \n> <https://github.com/EFForg/https-everywhere/pull/278/files#r12498453>.\n>","created_at":"2014-05-09T22:19:09Z","updated_at":"2014-05-09T22:19:09Z","html_url":"https://github.com/EFForg/https-everywhere/pull/278#discussion_r12498494","pull_request_url":"https://api.github.com/repos/EFForg/https-everywhere/pulls/278","_links":{"self":{"href":"https://api.github.com/repos/EFForg/https-everywhere/pulls/comments/12498494"},"html":{"href":"https://github.com/EFForg/https-everywhere/pull/278#discussion_r12498494"},"pull_request":{"href":"https://api.github.com/repos/EFForg/https-everywhere/pulls/278"}}}}