GitHub PushEvent at 2014-06-22 09:53:01
Repository: ofbiz
Actor: asfgit
Payload: {"shas":[["601d6b5a6f74f41a2dab1ec712fa6536942a1c54","811c1987b169139c3599e569bb8f018ce8f2d742@apache.org","\"Applied fix from trunk for revision: 1604554\" \n------------------------------------------------------------------------\nr1604554 | jleroux | 2014-06-22 11:18:39 +0200 (dim. 22 juin 2014) | 7 lignes\n\nA proposed fix by chunlinyao for \"checkExistsImage method in ImageManagementServices\" at https://issues.apache.org/jira/browse/OFBIZ-5658\n\nI think indexOf(\".\") in these code should be lastIndexOf(\".\"). \nFrom CATALOG -> Image Management -> Upload view. upload some Images it will call this method. This method is intended to add (count) to the image name, when the file name was already exist. I debugged in it, the imagePath was the absolute path of the image file. So If any parent folder name contains \".\" , it will not works correctly.\n\nchunlinyao's Note: And after review the whole ImageManagementServices.java file. I found it use static variables (ex. imageCount imagePath). It is not thread safe.\n\n------------------------------------------------------------------------\n?\\026\n\ngit-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release12.04@1604557 13f79535-47bb-0310-9956-ffa450edef68","Jacques Le Roux",true]],"size":1,"ref":"refs/heads/release12.04","head":"601d6b5a6f74f41a2dab1ec712fa6536942a1c54"}