GitHub PullRequestReviewCommentEvent at 2014-11-24 20:44:32
Repository: phinx
Actor: shadowhand
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/robmorgan/phinx/pulls/comments/20820564","id":20820564,"diff_hunk":"@@ -35,6 +36,20 @@ public function testAdapterMethods()\n         $this->assertTrue($migrationStub->getAdapter() instanceof AdapterInterface);\n     }\n \n+    public function testSetOutputMethods()\n+    {\n+        // stub migration\n+        $migrationStub = $this->getMockForAbstractClass('\\Phinx\\Migration\\AbstractMigration', array(0));\n+\n+        // stub output\n+        $outputStub = $this->getMock('\\Symfony\\Component\\Console\\Output\\OutputInterface', array(), array(array()));\n+\n+        // test methods\n+        $this->assertNull($migrationStub->getOutput());\n+        $migrationStub->setOutput($outputStub);\n+        $this->assertTrue($migrationStub->getOutput() instanceof OutputInterface);","path":"tests/Phinx/Migration/AbstractMigrationTest.php","position":23,"original_position":23,"commit_id":"cec266bcd157ddac4a191a8144967fd23f4b55a7","original_commit_id":"cec266bcd157ddac4a191a8144967fd23f4b55a7","user":{"login":"shadowhand","id":38203,"avatar_url":"https://avatars.githubusercontent.com/u/38203?v=3","gravatar_id":"","url":"https://api.github.com/users/shadowhand","html_url":"https://github.com/shadowhand","followers_url":"https://api.github.com/users/shadowhand/followers","following_url":"https://api.github.com/users/shadowhand/following{/other_user}","gists_url":"https://api.github.com/users/shadowhand/gists{/gist_id}","starred_url":"https://api.github.com/users/shadowhand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shadowhand/subscriptions","organizations_url":"https://api.github.com/users/shadowhand/orgs","repos_url":"https://api.github.com/users/shadowhand/repos","events_url":"https://api.github.com/users/shadowhand/events{/privacy}","received_events_url":"https://api.github.com/users/shadowhand/received_events","type":"User","site_admin":false},"body":"Ideally, this would use `assertInstanceOf`, but no harm.","created_at":"2014-11-24T20:44:32Z","updated_at":"2014-11-24T20:44:32Z","html_url":"https://github.com/robmorgan/phinx/pull/185#discussion_r20820564","pull_request_url":"https://api.github.com/repos/robmorgan/phinx/pulls/185","_links":{"self":{"href":"https://api.github.com/repos/robmorgan/phinx/pulls/comments/20820564"},"html":{"href":"https://github.com/robmorgan/phinx/pull/185#discussion_r20820564"},"pull_request":{"href":"https://api.github.com/repos/robmorgan/phinx/pulls/185"}}},"pull_request":{"url":"https://api.github.com/repos/robmorgan/phinx/pulls/185","id":12264360,"html_url":"https://github.com/robmorgan/phinx/pull/185","diff_url":"https://github.com/robmorgan/phinx/pull/185.diff","patch_url":"https://github.com/robmorgan/phinx/pull/185.patch","issue_url":"https://api.github.com/repos/robmorgan/phinx/issues/185","number":185,"state":"open","locked":false,"title":"Add possible console output inside migration objects","user":{"login":"jbourdin","id":1675069,"avatar_url":"https://avatars.githubusercontent.com/u/1675069?v=3","gravatar_id":"","url":"https://api.github.com/users/jbourdin","html_url":"https://github.com/jbourdin","followers_url":"https://api.github.com/users/jbourdin/followers","following_url":"https://api.github.com/users/jbourdin/following{/other_user}","gists_url":"https://api.github.com/users/jbourdin/gists{/gist_id}","starred_url":"https://api.github.com/users/jbourdin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbourdin/subscriptions","organizations_url":"https://api.github.com/users/jbourdin/orgs","repos_url":"https://api.github.com/users/jbourdin/repos","events_url":"https://api.github.com/users/jbourdin/events{/privacy}","received_events_url":"https://api.github.com/users/jbourdin/received_events","type":"User","site_admin":false},"body":"Provide the Console Output object inside migrations objects. Allow a little bit of migration feedback when applying or reverting.","created_at":"2014-02-06T12:08:49Z","updated_at":"2014-11-24T20:44:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0bdbdd00e4d81e0d26c7b1c76add63977fc2a8c3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/robmorgan/phinx/pulls/185/commits","review_comments_url":"https://api.github.com/repos/robmorgan/phinx/pulls/185/comments","review_comment_url":"https://api.github.com/repos/robmorgan/phinx/pulls/comments/{number}","comments_url":"https://api.github.com/repos/robmorgan/phinx/issues/185/comments","statuses_url":"https://api.github.com/repos/robmorgan/phinx/statuses/cec266bcd157ddac4a191a8144967fd23f4b55a7","head":{"label":"jbourdin:feature-console-output","ref":"feature-console-output","sha":"cec266bcd157ddac4a191a8144967fd23f4b55a7","user":{"login":"jbourdin","id":1675069,"avatar_url":"https://avatars.githubusercontent.com/u/1675069?v=3","gravatar_id":"","url":"https://api.github.com/users/jbourdin","html_url":"https://github.com/jbourdin","followers_url":"https://api.github.com/users/jbourdin/followers","following_url":"https://api.github.com/users/jbourdin/following{/other_user}","gists_url":"https://api.github.com/users/jbourdin/gists{/gist_id}","starred_url":"https://api.github.com/users/jbourdin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbourdin/subscriptions","organizations_url":"https://api.github.com/users/jbourdin/orgs","repos_url":"https://api.github.com/users/jbourdin/repos","events_url":"https://api.github.com/users/jbourdin/events{/privacy}","received_events_url":"https://api.github.com/users/jbourdin/received_events","type":"User","site_admin":false},"repo":{"id":16542536,"name":"phinx","full_name":"jbourdin/phinx","owner":{"login":"jbourdin","id":1675069,"avatar_url":"https://avatars.githubusercontent.com/u/1675069?v=3","gravatar_id":"","url":"https://api.github.com/users/jbourdin","html_url":"https://github.com/jbourdin","followers_url":"https://api.github.com/users/jbourdin/followers","following_url":"https://api.github.com/users/jbourdin/following{/other_user}","gists_url":"https://api.github.com/users/jbourdin/gists{/gist_id}","starred_url":"https://api.github.com/users/jbourdin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbourdin/subscriptions","organizations_url":"https://api.github.com/users/jbourdin/orgs","repos_url":"https://api.github.com/users/jbourdin/repos","events_url":"https://api.github.com/users/jbourdin/events{/privacy}","received_events_url":"https://api.github.com/users/jbourdin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jbourdin/phinx","description":"PHP Database Migrations for Everyone","fork":true,"url":"https://api.github.com/repos/jbourdin/phinx","forks_url":"https://api.github.com/repos/jbourdin/phinx/forks","keys_url":"https://api.github.com/repos/jbourdin/phinx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jbourdin/phinx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jbourdin/phinx/teams","hooks_url":"https://api.github.com/repos/jbourdin/phinx/hooks","issue_events_url":"https://api.github.com/repos/jbourdin/phinx/issues/events{/number}","events_url":"https://api.github.com/repos/jbourdin/phinx/events","assignees_url":"https://api.github.com/repos/jbourdin/phinx/assignees{/user}","branches_url":"https://api.github.com/repos/jbourdin/phinx/branches{/branch}","tags_url":"https://api.github.com/repos/jbourdin/phinx/tags","blobs_url":"https://api.github.com/repos/jbourdin/phinx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jbourdin/phinx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jbourdin/phinx/git/refs{/sha}","trees_url":"https://api.github.com/repos/jbourdin/phinx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jbourdin/phinx/statuses/{sha}","languages_url":"https://api.github.com/repos/jbourdin/phinx/languages","stargazers_url":"https://api.github.com/repos/jbourdin/phinx/stargazers","contributors_url":"https://api.github.com/repos/jbourdin/phinx/contributors","subscribers_url":"https://api.github.com/repos/jbourdin/phinx/subscribers","subscription_url":"https://api.github.com/repos/jbourdin/phinx/subscription","commits_url":"https://api.github.com/repos/jbourdin/phinx/commits{/sha}","git_commits_url":"https://api.github.com/repos/jbourdin/phinx/git/commits{/sha}","comments_url":"https://api.github.com/repos/jbourdin/phinx/comments{/number}","issue_comment_url":"https://api.github.com/repos/jbourdin/phinx/issues/comments/{number}","contents_url":"https://api.github.com/repos/jbourdin/phinx/contents/{+path}","compare_url":"https://api.github.com/repos/jbourdin/phinx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jbourdin/phinx/merges","archive_url":"https://api.github.com/repos/jbourdin/phinx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jbourdin/phinx/downloads","issues_url":"https://api.github.com/repos/jbourdin/phinx/issues{/number}","pulls_url":"https://api.github.com/repos/jbourdin/phinx/pulls{/number}","milestones_url":"https://api.github.com/repos/jbourdin/phinx/milestones{/number}","notifications_url":"https://api.github.com/repos/jbourdin/phinx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jbourdin/phinx/labels{/name}","releases_url":"https://api.github.com/repos/jbourdin/phinx/releases{/id}","created_at":"2014-02-05T11:12:09Z","updated_at":"2014-11-23T16:55:44Z","pushed_at":"2014-11-23T17:35:58Z","git_url":"git://github.com/jbourdin/phinx.git","ssh_url":"git@github.com:jbourdin/phinx.git","clone_url":"https://github.com/jbourdin/phinx.git","svn_url":"https://github.com/jbourdin/phinx","homepage":"http://phinx.org","size":2504,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"0.3.x-dev"}},"base":{"label":"robmorgan:0.3.x-dev","ref":"0.3.x-dev","sha":"053aff553427ebd3eb976372c438538bb2b74641","user":{"login":"robmorgan","id":178939,"avatar_url":"https://avatars.githubusercontent.com/u/178939?v=3","gravatar_id":"","url":"https://api.github.com/users/robmorgan","html_url":"https://github.com/robmorgan","followers_url":"https://api.github.com/users/robmorgan/followers","following_url":"https://api.github.com/users/robmorgan/following{/other_user}","gists_url":"https://api.github.com/users/robmorgan/gists{/gist_id}","starred_url":"https://api.github.com/users/robmorgan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robmorgan/subscriptions","organizations_url":"https://api.github.com/users/robmorgan/orgs","repos_url":"https://api.github.com/users/robmorgan/repos","events_url":"https://api.github.com/users/robmorgan/events{/privacy}","received_events_url":"https://api.github.com/users/robmorgan/received_events","type":"User","site_admin":false},"repo":{"id":3055234,"name":"phinx","full_name":"robmorgan/phinx","owner":{"login":"robmorgan","id":178939,"avatar_url":"https://avatars.githubusercontent.com/u/178939?v=3","gravatar_id":"","url":"https://api.github.com/users/robmorgan","html_url":"https://github.com/robmorgan","followers_url":"https://api.github.com/users/robmorgan/followers","following_url":"https://api.github.com/users/robmorgan/following{/other_user}","gists_url":"https://api.github.com/users/robmorgan/gists{/gist_id}","starred_url":"https://api.github.com/users/robmorgan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robmorgan/subscriptions","organizations_url":"https://api.github.com/users/robmorgan/orgs","repos_url":"https://api.github.com/users/robmorgan/repos","events_url":"https://api.github.com/users/robmorgan/events{/privacy}","received_events_url":"https://api.github.com/users/robmorgan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/robmorgan/phinx","description":"PHP Database Migrations for Everyone","fork":false,"url":"https://api.github.com/repos/robmorgan/phinx","forks_url":"https://api.github.com/repos/robmorgan/phinx/forks","keys_url":"https://api.github.com/repos/robmorgan/phinx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robmorgan/phinx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robmorgan/phinx/teams","hooks_url":"https://api.github.com/repos/robmorgan/phinx/hooks","issue_events_url":"https://api.github.com/repos/robmorgan/phinx/issues/events{/number}","events_url":"https://api.github.com/repos/robmorgan/phinx/events","assignees_url":"https://api.github.com/repos/robmorgan/phinx/assignees{/user}","branches_url":"https://api.github.com/repos/robmorgan/phinx/branches{/branch}","tags_url":"https://api.github.com/repos/robmorgan/phinx/tags","blobs_url":"https://api.github.com/repos/robmorgan/phinx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robmorgan/phinx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robmorgan/phinx/git/refs{/sha}","trees_url":"https://api.github.com/repos/robmorgan/phinx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robmorgan/phinx/statuses/{sha}","languages_url":"https://api.github.com/repos/robmorgan/phinx/languages","stargazers_url":"https://api.github.com/repos/robmorgan/phinx/stargazers","contributors_url":"https://api.github.com/repos/robmorgan/phinx/contributors","subscribers_url":"https://api.github.com/repos/robmorgan/phinx/subscribers","subscription_url":"https://api.github.com/repos/robmorgan/phinx/subscription","commits_url":"https://api.github.com/repos/robmorgan/phinx/commits{/sha}","git_commits_url":"https://api.github.com/repos/robmorgan/phinx/git/commits{/sha}","comments_url":"https://api.github.com/repos/robmorgan/phinx/comments{/number}","issue_comment_url":"https://api.github.com/repos/robmorgan/phinx/issues/comments/{number}","contents_url":"https://api.github.com/repos/robmorgan/phinx/contents/{+path}","compare_url":"https://api.github.com/repos/robmorgan/phinx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robmorgan/phinx/merges","archive_url":"https://api.github.com/repos/robmorgan/phinx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robmorgan/phinx/downloads","issues_url":"https://api.github.com/repos/robmorgan/phinx/issues{/number}","pulls_url":"https://api.github.com/repos/robmorgan/phinx/pulls{/number}","milestones_url":"https://api.github.com/repos/robmorgan/phinx/milestones{/number}","notifications_url":"https://api.github.com/repos/robmorgan/phinx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robmorgan/phinx/labels{/name}","releases_url":"https://api.github.com/repos/robmorgan/phinx/releases{/id}","created_at":"2011-12-27T06:49:45Z","updated_at":"2014-11-24T14:49:20Z","pushed_at":"2014-11-24T00:03:12Z","git_url":"git://github.com/robmorgan/phinx.git","ssh_url":"git@github.com:robmorgan/phinx.git","clone_url":"https://github.com/robmorgan/phinx.git","svn_url":"https://github.com/robmorgan/phinx","homepage":"https://phinx.org","size":7065,"stargazers_count":1027,"watchers_count":1027,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":234,"mirror_url":null,"open_issues_count":127,"forks":234,"open_issues":127,"watchers":1027,"default_branch":"0.3.x-dev"}},"_links":{"self":{"href":"https://api.github.com/repos/robmorgan/phinx/pulls/185"},"html":{"href":"https://github.com/robmorgan/phinx/pull/185"},"issue":{"href":"https://api.github.com/repos/robmorgan/phinx/issues/185"},"comments":{"href":"https://api.github.com/repos/robmorgan/phinx/issues/185/comments"},"review_comments":{"href":"https://api.github.com/repos/robmorgan/phinx/pulls/185/comments"},"review_comment":{"href":"https://api.github.com/repos/robmorgan/phinx/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/robmorgan/phinx/pulls/185/commits"},"statuses":{"href":"https://api.github.com/repos/robmorgan/phinx/statuses/cec266bcd157ddac4a191a8144967fd23f4b55a7"}}}}