GitHub PullRequestReviewCommentEvent at 2014-10-13 19:14:28
Repository: iD
Actor: jfirebaugh
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/openstreetmap/iD/pulls/comments/18788796","id":18788796,"diff_hunk":"@@ -65,7 +31,7 @@ iD.svg.Areas = function(projection) {\n         });\n \n         var data = {\n-            clip: areas.filter(clip),","path":"js/id/svg/areas.js","position":43,"original_position":43,"commit_id":"10667a65c5a407a2af8ff09db7b56d7f404e5bed","original_commit_id":"10667a65c5a407a2af8ff09db7b56d7f404e5bed","user":{"login":"jfirebaugh","id":98601,"avatar_url":"https://avatars.githubusercontent.com/u/98601?v=2","gravatar_id":"","url":"https://api.github.com/users/jfirebaugh","html_url":"https://github.com/jfirebaugh","followers_url":"https://api.github.com/users/jfirebaugh/followers","following_url":"https://api.github.com/users/jfirebaugh/following{/other_user}","gists_url":"https://api.github.com/users/jfirebaugh/gists{/gist_id}","starred_url":"https://api.github.com/users/jfirebaugh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfirebaugh/subscriptions","organizations_url":"https://api.github.com/users/jfirebaugh/orgs","repos_url":"https://api.github.com/users/jfirebaugh/repos","events_url":"https://api.github.com/users/jfirebaugh/events{/privacy}","received_events_url":"https://api.github.com/users/jfirebaugh/received_events","type":"User","site_admin":false},"body":"I was assuming there would be a performance penalty to creating and using a clip path for every area (e.g. every building footprint) even though they are only needed for the landuse areas that have the thick inner \"stroke\". Have you tested this?","created_at":"2014-10-13T19:14:28Z","updated_at":"2014-10-13T19:14:28Z","html_url":"https://github.com/openstreetmap/iD/pull/2357#discussion_r18788796","pull_request_url":"https://api.github.com/repos/openstreetmap/iD/pulls/2357","_links":{"self":{"href":"https://api.github.com/repos/openstreetmap/iD/pulls/comments/18788796"},"html":{"href":"https://github.com/openstreetmap/iD/pull/2357#discussion_r18788796"},"pull_request":{"href":"https://api.github.com/repos/openstreetmap/iD/pulls/2357"}}},"pull_request":{"url":"https://api.github.com/repos/openstreetmap/iD/pulls/2357","id":21325267,"html_url":"https://github.com/openstreetmap/iD/pull/2357","diff_url":"https://github.com/openstreetmap/iD/pull/2357.diff","patch_url":"https://github.com/openstreetmap/iD/pull/2357.patch","issue_url":"https://api.github.com/repos/openstreetmap/iD/issues/2357","number":2357,"state":"open","locked":false,"title":"Feature filtering","user":{"login":"bhousel","id":38784,"avatar_url":"https://avatars.githubusercontent.com/u/38784?v=2","gravatar_id":"","url":"https://api.github.com/users/bhousel","html_url":"https://github.com/bhousel","followers_url":"https://api.github.com/users/bhousel/followers","following_url":"https://api.github.com/users/bhousel/following{/other_user}","gists_url":"https://api.github.com/users/bhousel/gists{/gist_id}","starred_url":"https://api.github.com/users/bhousel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhousel/subscriptions","organizations_url":"https://api.github.com/users/bhousel/orgs","repos_url":"https://api.github.com/users/bhousel/repos","events_url":"https://api.github.com/users/bhousel/events{/privacy}","received_events_url":"https://api.github.com/users/bhousel/received_events","type":"User","site_admin":false},"body":"This addresses #1299, #1871, #2033 \r\n\r\nAdds:\r\n* flexible feature definition\r\n* sidebar to allow user to toggle features (hotkey 'F')\r\n* info bar on bottom to warn user when features are hidden\r\n* supports auto-hiding features (currently auto-hides >100 points, >100 buildings)\r\n\r\nNot ready to merge yet, but looking for feedback.\r\nI really like how this is coming together - dense areas are way easier to edit now.\r\n\r\nTODO:\r\n- [ ] tests\r\n- [ ] replace hamburger icon\r\n- [X] adjust text/tooltip language?\r\n- [X] better handling of multipolygons? (e.g. should really hide inner 'holes' when hiding an 'outer' landuse)\r\n- [X] restrict some edits if a feature is hidden? (e.g. moves, deletes?)\r\n- [X] add wireframe mode? (#813)\r\n- [X] make gpx tracks features instead of background? (related #2352, #2335)\r\n\r\n![screenshot 2014-09-16 16 02 48](https://cloud.githubusercontent.com/assets/38784/4294306/5bbdca92-3dde-11e4-9faa-339e99e47acc.png)\r\n","created_at":"2014-09-16T20:17:13Z","updated_at":"2014-10-13T19:14:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"97df237154ee1a37749af883679a3a8ad782962f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openstreetmap/iD/pulls/2357/commits","review_comments_url":"https://api.github.com/repos/openstreetmap/iD/pulls/2357/comments","review_comment_url":"https://api.github.com/repos/openstreetmap/iD/pulls/comments/{number}","comments_url":"https://api.github.com/repos/openstreetmap/iD/issues/2357/comments","statuses_url":"https://api.github.com/repos/openstreetmap/iD/statuses/10667a65c5a407a2af8ff09db7b56d7f404e5bed","head":{"label":"bhousel:feature-filtering","ref":"feature-filtering","sha":"10667a65c5a407a2af8ff09db7b56d7f404e5bed","user":{"login":"bhousel","id":38784,"avatar_url":"https://avatars.githubusercontent.com/u/38784?v=2","gravatar_id":"","url":"https://api.github.com/users/bhousel","html_url":"https://github.com/bhousel","followers_url":"https://api.github.com/users/bhousel/followers","following_url":"https://api.github.com/users/bhousel/following{/other_user}","gists_url":"https://api.github.com/users/bhousel/gists{/gist_id}","starred_url":"https://api.github.com/users/bhousel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhousel/subscriptions","organizations_url":"https://api.github.com/users/bhousel/orgs","repos_url":"https://api.github.com/users/bhousel/repos","events_url":"https://api.github.com/users/bhousel/events{/privacy}","received_events_url":"https://api.github.com/users/bhousel/received_events","type":"User","site_admin":false},"repo":{"id":15274618,"name":"iD","full_name":"bhousel/iD","owner":{"login":"bhousel","id":38784,"avatar_url":"https://avatars.githubusercontent.com/u/38784?v=2","gravatar_id":"","url":"https://api.github.com/users/bhousel","html_url":"https://github.com/bhousel","followers_url":"https://api.github.com/users/bhousel/followers","following_url":"https://api.github.com/users/bhousel/following{/other_user}","gists_url":"https://api.github.com/users/bhousel/gists{/gist_id}","starred_url":"https://api.github.com/users/bhousel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhousel/subscriptions","organizations_url":"https://api.github.com/users/bhousel/orgs","repos_url":"https://api.github.com/users/bhousel/repos","events_url":"https://api.github.com/users/bhousel/events{/privacy}","received_events_url":"https://api.github.com/users/bhousel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bhousel/iD","description":"The easy-to-use OpenStreetMap editor in JavaScript.","fork":true,"url":"https://api.github.com/repos/bhousel/iD","forks_url":"https://api.github.com/repos/bhousel/iD/forks","keys_url":"https://api.github.com/repos/bhousel/iD/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bhousel/iD/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bhousel/iD/teams","hooks_url":"https://api.github.com/repos/bhousel/iD/hooks","issue_events_url":"https://api.github.com/repos/bhousel/iD/issues/events{/number}","events_url":"https://api.github.com/repos/bhousel/iD/events","assignees_url":"https://api.github.com/repos/bhousel/iD/assignees{/user}","branches_url":"https://api.github.com/repos/bhousel/iD/branches{/branch}","tags_url":"https://api.github.com/repos/bhousel/iD/tags","blobs_url":"https://api.github.com/repos/bhousel/iD/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bhousel/iD/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bhousel/iD/git/refs{/sha}","trees_url":"https://api.github.com/repos/bhousel/iD/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bhousel/iD/statuses/{sha}","languages_url":"https://api.github.com/repos/bhousel/iD/languages","stargazers_url":"https://api.github.com/repos/bhousel/iD/stargazers","contributors_url":"https://api.github.com/repos/bhousel/iD/contributors","subscribers_url":"https://api.github.com/repos/bhousel/iD/subscribers","subscription_url":"https://api.github.com/repos/bhousel/iD/subscription","commits_url":"https://api.github.com/repos/bhousel/iD/commits{/sha}","git_commits_url":"https://api.github.com/repos/bhousel/iD/git/commits{/sha}","comments_url":"https://api.github.com/repos/bhousel/iD/comments{/number}","issue_comment_url":"https://api.github.com/repos/bhousel/iD/issues/comments/{number}","contents_url":"https://api.github.com/repos/bhousel/iD/contents/{+path}","compare_url":"https://api.github.com/repos/bhousel/iD/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bhousel/iD/merges","archive_url":"https://api.github.com/repos/bhousel/iD/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bhousel/iD/downloads","issues_url":"https://api.github.com/repos/bhousel/iD/issues{/number}","pulls_url":"https://api.github.com/repos/bhousel/iD/pulls{/number}","milestones_url":"https://api.github.com/repos/bhousel/iD/milestones{/number}","notifications_url":"https://api.github.com/repos/bhousel/iD/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bhousel/iD/labels{/name}","releases_url":"https://api.github.com/repos/bhousel/iD/releases{/id}","created_at":"2013-12-18T05:31:51Z","updated_at":"2014-06-25T19:46:44Z","pushed_at":"2014-10-12T05:40:40Z","git_url":"git://github.com/bhousel/iD.git","ssh_url":"git@github.com:bhousel/iD.git","clone_url":"https://github.com/bhousel/iD.git","svn_url":"https://github.com/bhousel/iD","homepage":"http://ideditor.com/","size":35002,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"openstreetmap:master","ref":"master","sha":"0b1ec49402aa9a8ccd1aebeac9e7468586168221","user":{"login":"openstreetmap","id":261431,"avatar_url":"https://avatars.githubusercontent.com/u/261431?v=2","gravatar_id":"","url":"https://api.github.com/users/openstreetmap","html_url":"https://github.com/openstreetmap","followers_url":"https://api.github.com/users/openstreetmap/followers","following_url":"https://api.github.com/users/openstreetmap/following{/other_user}","gists_url":"https://api.github.com/users/openstreetmap/gists{/gist_id}","starred_url":"https://api.github.com/users/openstreetmap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openstreetmap/subscriptions","organizations_url":"https://api.github.com/users/openstreetmap/orgs","repos_url":"https://api.github.com/users/openstreetmap/repos","events_url":"https://api.github.com/users/openstreetmap/events{/privacy}","received_events_url":"https://api.github.com/users/openstreetmap/received_events","type":"Organization","site_admin":false},"repo":{"id":4989235,"name":"iD","full_name":"openstreetmap/iD","owner":{"login":"openstreetmap","id":261431,"avatar_url":"https://avatars.githubusercontent.com/u/261431?v=2","gravatar_id":"","url":"https://api.github.com/users/openstreetmap","html_url":"https://github.com/openstreetmap","followers_url":"https://api.github.com/users/openstreetmap/followers","following_url":"https://api.github.com/users/openstreetmap/following{/other_user}","gists_url":"https://api.github.com/users/openstreetmap/gists{/gist_id}","starred_url":"https://api.github.com/users/openstreetmap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openstreetmap/subscriptions","organizations_url":"https://api.github.com/users/openstreetmap/orgs","repos_url":"https://api.github.com/users/openstreetmap/repos","events_url":"https://api.github.com/users/openstreetmap/events{/privacy}","received_events_url":"https://api.github.com/users/openstreetmap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openstreetmap/iD","description":"The easy-to-use OpenStreetMap editor in JavaScript.","fork":false,"url":"https://api.github.com/repos/openstreetmap/iD","forks_url":"https://api.github.com/repos/openstreetmap/iD/forks","keys_url":"https://api.github.com/repos/openstreetmap/iD/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openstreetmap/iD/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openstreetmap/iD/teams","hooks_url":"https://api.github.com/repos/openstreetmap/iD/hooks","issue_events_url":"https://api.github.com/repos/openstreetmap/iD/issues/events{/number}","events_url":"https://api.github.com/repos/openstreetmap/iD/events","assignees_url":"https://api.github.com/repos/openstreetmap/iD/assignees{/user}","branches_url":"https://api.github.com/repos/openstreetmap/iD/branches{/branch}","tags_url":"https://api.github.com/repos/openstreetmap/iD/tags","blobs_url":"https://api.github.com/repos/openstreetmap/iD/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openstreetmap/iD/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openstreetmap/iD/git/refs{/sha}","trees_url":"https://api.github.com/repos/openstreetmap/iD/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openstreetmap/iD/statuses/{sha}","languages_url":"https://api.github.com/repos/openstreetmap/iD/languages","stargazers_url":"https://api.github.com/repos/openstreetmap/iD/stargazers","contributors_url":"https://api.github.com/repos/openstreetmap/iD/contributors","subscribers_url":"https://api.github.com/repos/openstreetmap/iD/subscribers","subscription_url":"https://api.github.com/repos/openstreetmap/iD/subscription","commits_url":"https://api.github.com/repos/openstreetmap/iD/commits{/sha}","git_commits_url":"https://api.github.com/repos/openstreetmap/iD/git/commits{/sha}","comments_url":"https://api.github.com/repos/openstreetmap/iD/comments{/number}","issue_comment_url":"https://api.github.com/repos/openstreetmap/iD/issues/comments/{number}","contents_url":"https://api.github.com/repos/openstreetmap/iD/contents/{+path}","compare_url":"https://api.github.com/repos/openstreetmap/iD/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openstreetmap/iD/merges","archive_url":"https://api.github.com/repos/openstreetmap/iD/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openstreetmap/iD/downloads","issues_url":"https://api.github.com/repos/openstreetmap/iD/issues{/number}","pulls_url":"https://api.github.com/repos/openstreetmap/iD/pulls{/number}","milestones_url":"https://api.github.com/repos/openstreetmap/iD/milestones{/number}","notifications_url":"https://api.github.com/repos/openstreetmap/iD/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openstreetmap/iD/labels{/name}","releases_url":"https://api.github.com/repos/openstreetmap/iD/releases{/id}","created_at":"2012-07-11T13:20:04Z","updated_at":"2014-10-13T09:40:24Z","pushed_at":"2014-10-12T05:40:37Z","git_url":"git://github.com/openstreetmap/iD.git","ssh_url":"git@github.com:openstreetmap/iD.git","clone_url":"https://github.com/openstreetmap/iD.git","svn_url":"https://github.com/openstreetmap/iD","homepage":"http://ideditor.com/","size":61883,"stargazers_count":799,"watchers_count":799,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":286,"mirror_url":null,"open_issues_count":188,"forks":286,"open_issues":188,"watchers":799,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openstreetmap/iD/pulls/2357"},"html":{"href":"https://github.com/openstreetmap/iD/pull/2357"},"issue":{"href":"https://api.github.com/repos/openstreetmap/iD/issues/2357"},"comments":{"href":"https://api.github.com/repos/openstreetmap/iD/issues/2357/comments"},"review_comments":{"href":"https://api.github.com/repos/openstreetmap/iD/pulls/2357/comments"},"review_comment":{"href":"https://api.github.com/repos/openstreetmap/iD/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/openstreetmap/iD/pulls/2357/commits"},"statuses":{"href":"https://api.github.com/repos/openstreetmap/iD/statuses/10667a65c5a407a2af8ff09db7b56d7f404e5bed"}}}}