GitHub PullRequestReviewCommentEvent at 2014-11-16 05:37:33
Repository: gaia
Actor: DouglasSherk
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/20407302","id":20407302,"diff_hunk":"@@ -710,6 +712,54 @@ suite('calls handler', function() {\n         sinon.assert.calledOnce(MockCallScreen.hideIncoming);\n       });\n \n+      test('should not resume the pending call if put on hold by the user',\n+      function() {\n+        this.sinon.spy(firstCall, 'resume');\n+        MockNavigatorMozTelephony.active = MockNavigatorMozTelephony.calls[0];\n+        MockNavigatorMozTelephony.calls[0].state = 'connected';\n+        CallsHandler.holdOrResumeSingleCall(true);\n+        MockNavigatorMozTelephony.calls[0].state = 'held';\n+        MockNavigatorMozTelephony.mTriggerCallsChanged();\n+        sinon.assert.notCalled(firstCall.resume);\n+      });\n+\n+      test('should resume the pending call if put on hold but not by the user',\n+      function() {\n+        this.sinon.spy(firstCall, 'resume');\n+        MockNavigatorMozTelephony.active = MockNavigatorMozTelephony.calls[0];\n+        MockNavigatorMozTelephony.calls[0].state = 'connected';\n+        CallsHandler.holdOrResumeSingleCall();\n+        MockNavigatorMozTelephony.calls[0].state = 'held';\n+        MockNavigatorMozTelephony.mTriggerCallsChanged();\n+        sinon.assert.calledOnce(firstCall.resume);\n+      });\n+\n+      test('should resume the pending call if the user toggled between them',\n+      function() {\n+        this.sinon.spy(firstCall, 'resume');\n+        MockNavigatorMozTelephony.active = MockNavigatorMozTelephony.calls[0];\n+        MockNavigatorMozTelephony.calls[0].state = 'connected';\n+        CallsHandler.holdOrResumeSingleCall(true);\n+        MockNavigatorMozTelephony.active = null;\n+        MockNavigatorMozTelephony.calls[0].state = 'held';\n+        CallsHandler.toggleCalls();\n+        MockNavigatorMozTelephony.mTriggerCallsChanged();\n+        sinon.assert.calledTwice(firstCall.resume);","path":"apps/callscreen/test/unit/calls_handler_test.js","position":48,"original_position":48,"commit_id":"a4751ec7171ba3637b6ed31aaf54ef487a7afa71","original_commit_id":"a4751ec7171ba3637b6ed31aaf54ef487a7afa71","user":{"login":"DouglasSherk","id":1310914,"avatar_url":"https://avatars.githubusercontent.com/u/1310914?v=3","gravatar_id":"","url":"https://api.github.com/users/DouglasSherk","html_url":"https://github.com/DouglasSherk","followers_url":"https://api.github.com/users/DouglasSherk/followers","following_url":"https://api.github.com/users/DouglasSherk/following{/other_user}","gists_url":"https://api.github.com/users/DouglasSherk/gists{/gist_id}","starred_url":"https://api.github.com/users/DouglasSherk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DouglasSherk/subscriptions","organizations_url":"https://api.github.com/users/DouglasSherk/orgs","repos_url":"https://api.github.com/users/DouglasSherk/repos","events_url":"https://api.github.com/users/DouglasSherk/events{/privacy}","received_events_url":"https://api.github.com/users/DouglasSherk/received_events","type":"User","site_admin":false},"body":"Why does this get called twice?","created_at":"2014-11-16T05:37:33Z","updated_at":"2014-11-16T05:37:33Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/26055#discussion_r20407302","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/26055","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/20407302"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/26055#discussion_r20407302"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/26055"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/26055","id":24282735,"html_url":"https://github.com/mozilla-b2g/gaia/pull/26055","diff_url":"https://github.com/mozilla-b2g/gaia/pull/26055.diff","patch_url":"https://github.com/mozilla-b2g/gaia/pull/26055.patch","issue_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/26055","number":26055,"state":"open","locked":false,"title":"Bug 1094878 - Call is not on hold anymore after hanging up another call even though the icon says it is","user":{"login":"gtorodelvalle","id":667284,"avatar_url":"https://avatars.githubusercontent.com/u/667284?v=3","gravatar_id":"","url":"https://api.github.com/users/gtorodelvalle","html_url":"https://github.com/gtorodelvalle","followers_url":"https://api.github.com/users/gtorodelvalle/followers","following_url":"https://api.github.com/users/gtorodelvalle/following{/other_user}","gists_url":"https://api.github.com/users/gtorodelvalle/gists{/gist_id}","starred_url":"https://api.github.com/users/gtorodelvalle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtorodelvalle/subscriptions","organizations_url":"https://api.github.com/users/gtorodelvalle/orgs","repos_url":"https://api.github.com/users/gtorodelvalle/repos","events_url":"https://api.github.com/users/gtorodelvalle/events{/privacy}","received_events_url":"https://api.github.com/users/gtorodelvalle/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-11-12T10:27:59Z","updated_at":"2014-11-16T05:37:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d7c04e01509c6c70fe3622c8c59c794ed976d534","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/26055/commits","review_comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/26055/comments","review_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/26055/comments","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/a4751ec7171ba3637b6ed31aaf54ef487a7afa71","head":{"label":"gtorodelvalle:callscreen-bug-1094878-on-hold-memory","ref":"callscreen-bug-1094878-on-hold-memory","sha":"a4751ec7171ba3637b6ed31aaf54ef487a7afa71","user":{"login":"gtorodelvalle","id":667284,"avatar_url":"https://avatars.githubusercontent.com/u/667284?v=3","gravatar_id":"","url":"https://api.github.com/users/gtorodelvalle","html_url":"https://github.com/gtorodelvalle","followers_url":"https://api.github.com/users/gtorodelvalle/followers","following_url":"https://api.github.com/users/gtorodelvalle/following{/other_user}","gists_url":"https://api.github.com/users/gtorodelvalle/gists{/gist_id}","starred_url":"https://api.github.com/users/gtorodelvalle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtorodelvalle/subscriptions","organizations_url":"https://api.github.com/users/gtorodelvalle/orgs","repos_url":"https://api.github.com/users/gtorodelvalle/repos","events_url":"https://api.github.com/users/gtorodelvalle/events{/privacy}","received_events_url":"https://api.github.com/users/gtorodelvalle/received_events","type":"User","site_admin":false},"repo":{"id":13437645,"name":"gaia","full_name":"gtorodelvalle/gaia","owner":{"login":"gtorodelvalle","id":667284,"avatar_url":"https://avatars.githubusercontent.com/u/667284?v=3","gravatar_id":"","url":"https://api.github.com/users/gtorodelvalle","html_url":"https://github.com/gtorodelvalle","followers_url":"https://api.github.com/users/gtorodelvalle/followers","following_url":"https://api.github.com/users/gtorodelvalle/following{/other_user}","gists_url":"https://api.github.com/users/gtorodelvalle/gists{/gist_id}","starred_url":"https://api.github.com/users/gtorodelvalle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtorodelvalle/subscriptions","organizations_url":"https://api.github.com/users/gtorodelvalle/orgs","repos_url":"https://api.github.com/users/gtorodelvalle/repos","events_url":"https://api.github.com/users/gtorodelvalle/events{/privacy}","received_events_url":"https://api.github.com/users/gtorodelvalle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gtorodelvalle/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see https://wiki.mozilla.org/Release_Management/B2G_Landing","fork":true,"url":"https://api.github.com/repos/gtorodelvalle/gaia","forks_url":"https://api.github.com/repos/gtorodelvalle/gaia/forks","keys_url":"https://api.github.com/repos/gtorodelvalle/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gtorodelvalle/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gtorodelvalle/gaia/teams","hooks_url":"https://api.github.com/repos/gtorodelvalle/gaia/hooks","issue_events_url":"https://api.github.com/repos/gtorodelvalle/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/gtorodelvalle/gaia/events","assignees_url":"https://api.github.com/repos/gtorodelvalle/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/gtorodelvalle/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/gtorodelvalle/gaia/tags","blobs_url":"https://api.github.com/repos/gtorodelvalle/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gtorodelvalle/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gtorodelvalle/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/gtorodelvalle/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gtorodelvalle/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/gtorodelvalle/gaia/languages","stargazers_url":"https://api.github.com/repos/gtorodelvalle/gaia/stargazers","contributors_url":"https://api.github.com/repos/gtorodelvalle/gaia/contributors","subscribers_url":"https://api.github.com/repos/gtorodelvalle/gaia/subscribers","subscription_url":"https://api.github.com/repos/gtorodelvalle/gaia/subscription","commits_url":"https://api.github.com/repos/gtorodelvalle/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/gtorodelvalle/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/gtorodelvalle/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/gtorodelvalle/gaia/issues/comments/{number}","contents_url":"https://api.github.com/repos/gtorodelvalle/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/gtorodelvalle/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gtorodelvalle/gaia/merges","archive_url":"https://api.github.com/repos/gtorodelvalle/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gtorodelvalle/gaia/downloads","issues_url":"https://api.github.com/repos/gtorodelvalle/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/gtorodelvalle/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/gtorodelvalle/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/gtorodelvalle/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gtorodelvalle/gaia/labels{/name}","releases_url":"https://api.github.com/repos/gtorodelvalle/gaia/releases{/id}","created_at":"2013-10-09T09:00:01Z","updated_at":"2014-06-26T11:07:46Z","pushed_at":"2014-11-14T13:13:38Z","git_url":"git://github.com/gtorodelvalle/gaia.git","ssh_url":"git@github.com:gtorodelvalle/gaia.git","clone_url":"https://github.com/gtorodelvalle/gaia.git","svn_url":"https://github.com/gtorodelvalle/gaia","homepage":"https://wiki.mozilla.org/B2G","size":858443,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-b2g:master","ref":"master","sha":"3ae38e3ec37eb0f455f3fd997eed0c5f3cb7c109","user":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"repo":{"id":2317369,"name":"gaia","full_name":"mozilla-b2g/gaia","owner":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-b2g/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see","fork":false,"url":"https://api.github.com/repos/mozilla-b2g/gaia","forks_url":"https://api.github.com/repos/mozilla-b2g/gaia/forks","keys_url":"https://api.github.com/repos/mozilla-b2g/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-b2g/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-b2g/gaia/teams","hooks_url":"https://api.github.com/repos/mozilla-b2g/gaia/hooks","issue_events_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-b2g/gaia/events","assignees_url":"https://api.github.com/repos/mozilla-b2g/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-b2g/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/tags","blobs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-b2g/gaia/languages","stargazers_url":"https://api.github.com/repos/mozilla-b2g/gaia/stargazers","contributors_url":"https://api.github.com/repos/mozilla-b2g/gaia/contributors","subscribers_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscribers","subscription_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscription","commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla-b2g/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-b2g/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-b2g/gaia/merges","archive_url":"https://api.github.com/repos/mozilla-b2g/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-b2g/gaia/downloads","issues_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-b2g/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-b2g/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-b2g/gaia/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-b2g/gaia/releases{/id}","created_at":"2011-09-03T01:38:46Z","updated_at":"2014-11-15T21:45:40Z","pushed_at":"2014-11-15T20:10:26Z","git_url":"git://github.com/mozilla-b2g/gaia.git","ssh_url":"git@github.com:mozilla-b2g/gaia.git","clone_url":"https://github.com/mozilla-b2g/gaia.git","svn_url":"https://github.com/mozilla-b2g/gaia","homepage":"https://wiki.mozilla.org/B2G","size":1551135,"stargazers_count":1796,"watchers_count":1796,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2051,"mirror_url":null,"open_issues_count":660,"forks":2051,"open_issues":660,"watchers":1796,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/26055"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/26055"},"issue":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/26055"},"comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/26055/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/26055/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/26055/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/a4751ec7171ba3637b6ed31aaf54ef487a7afa71"}}}}