GitHub PullRequestReviewCommentEvent at 2014-07-22 09:18:18
Repository: android-chat
Actor: aniaMu
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Wikia/android-chat/pulls/comments/15217736","id":15217736,"diff_hunk":"@@ -1,34 +1,71 @@\n package com.wikia.chat.library;\n \n-import com.wikia.chat.library.SendMessageFragment.OnSendButtonClickedListener;\n-\n import android.os.Bundle;\n import android.support.v4.app.FragmentActivity;\n-import android.util.Log;\n+\n+import com.wikia.chat.library.FirebaseManager.FirebaseMessagesListener;\n+import com.wikia.chat.library.LoginDialogFragment.OnJoinNowButtonClickedListener;\n+import com.wikia.chat.library.SendMessageFragment.OnViewClickedListener;","path":"library/src/com/wikia/chat/library/ChatActivity.java","position":11,"original_position":11,"commit_id":"8b26ac882d291bd03ba7f86d2efd7deed3afbd7c","original_commit_id":"8b26ac882d291bd03ba7f86d2efd7deed3afbd7c","user":{"login":"aniaMu","id":6084737,"avatar_url":"https://avatars.githubusercontent.com/u/6084737?","gravatar_id":"3007edcd42f07529325a8ef7d6a4a2b3","url":"https://api.github.com/users/aniaMu","html_url":"https://github.com/aniaMu","followers_url":"https://api.github.com/users/aniaMu/followers","following_url":"https://api.github.com/users/aniaMu/following{/other_user}","gists_url":"https://api.github.com/users/aniaMu/gists{/gist_id}","starred_url":"https://api.github.com/users/aniaMu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aniaMu/subscriptions","organizations_url":"https://api.github.com/users/aniaMu/orgs","repos_url":"https://api.github.com/users/aniaMu/repos","events_url":"https://api.github.com/users/aniaMu/events{/privacy}","received_events_url":"https://api.github.com/users/aniaMu/received_events","type":"User","site_admin":false},"body":"please change the name of this listener to a more self explanatory name, because there is a general onViewClickedListener available in Android","created_at":"2014-07-22T09:18:18Z","updated_at":"2014-07-22T09:18:18Z","html_url":"https://github.com/Wikia/android-chat/pull/5#discussion_r15217736","pull_request_url":"https://api.github.com/repos/Wikia/android-chat/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/Wikia/android-chat/pulls/comments/15217736"},"html":{"href":"https://github.com/Wikia/android-chat/pull/5#discussion_r15217736"},"pull_request":{"href":"https://api.github.com/repos/Wikia/android-chat/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/Wikia/android-chat/pulls/5","id":18702327,"html_url":"https://github.com/Wikia/android-chat/pull/5","diff_url":"https://github.com/Wikia/android-chat/pull/5.diff","patch_url":"https://github.com/Wikia/android-chat/pull/5.patch","issue_url":"https://api.github.com/repos/Wikia/android-chat/issues/5","number":5,"state":"open","title":"Feature/mob 2142 login","user":{"login":"JakubCie","id":6317068,"avatar_url":"https://avatars.githubusercontent.com/u/6317068?","gravatar_id":"73d9a71e661f3def23f9d981e28fa666","url":"https://api.github.com/users/JakubCie","html_url":"https://github.com/JakubCie","followers_url":"https://api.github.com/users/JakubCie/followers","following_url":"https://api.github.com/users/JakubCie/following{/other_user}","gists_url":"https://api.github.com/users/JakubCie/gists{/gist_id}","starred_url":"https://api.github.com/users/JakubCie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JakubCie/subscriptions","organizations_url":"https://api.github.com/users/JakubCie/orgs","repos_url":"https://api.github.com/users/JakubCie/repos","events_url":"https://api.github.com/users/JakubCie/events{/privacy}","received_events_url":"https://api.github.com/users/JakubCie/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-07-22T09:10:22Z","updated_at":"2014-07-22T09:18:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f056b2f5a5c15ba33c9846d1dd51ec09eb03b7c3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Wikia/android-chat/pulls/5/commits","review_comments_url":"https://api.github.com/repos/Wikia/android-chat/pulls/5/comments","review_comment_url":"https://api.github.com/repos/Wikia/android-chat/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Wikia/android-chat/issues/5/comments","statuses_url":"https://api.github.com/repos/Wikia/android-chat/statuses/8b26ac882d291bd03ba7f86d2efd7deed3afbd7c","head":{"label":"Wikia:feature/MOB-2142_login","ref":"feature/MOB-2142_login","sha":"8b26ac882d291bd03ba7f86d2efd7deed3afbd7c","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?","gravatar_id":"7d465709e42f40da92f14aae7e005558","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":21649089,"name":"android-chat","full_name":"Wikia/android-chat","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?","gravatar_id":"7d465709e42f40da92f14aae7e005558","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/android-chat","description":"","fork":false,"url":"https://api.github.com/repos/Wikia/android-chat","forks_url":"https://api.github.com/repos/Wikia/android-chat/forks","keys_url":"https://api.github.com/repos/Wikia/android-chat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/android-chat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/android-chat/teams","hooks_url":"https://api.github.com/repos/Wikia/android-chat/hooks","issue_events_url":"https://api.github.com/repos/Wikia/android-chat/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/android-chat/events","assignees_url":"https://api.github.com/repos/Wikia/android-chat/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/android-chat/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/android-chat/tags","blobs_url":"https://api.github.com/repos/Wikia/android-chat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/android-chat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/android-chat/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/android-chat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/android-chat/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/android-chat/languages","stargazers_url":"https://api.github.com/repos/Wikia/android-chat/stargazers","contributors_url":"https://api.github.com/repos/Wikia/android-chat/contributors","subscribers_url":"https://api.github.com/repos/Wikia/android-chat/subscribers","subscription_url":"https://api.github.com/repos/Wikia/android-chat/subscription","commits_url":"https://api.github.com/repos/Wikia/android-chat/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/android-chat/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/android-chat/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/android-chat/issues/comments/{number}","contents_url":"https://api.github.com/repos/Wikia/android-chat/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/android-chat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/android-chat/merges","archive_url":"https://api.github.com/repos/Wikia/android-chat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/android-chat/downloads","issues_url":"https://api.github.com/repos/Wikia/android-chat/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/android-chat/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/android-chat/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/android-chat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/android-chat/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/android-chat/releases{/id}","created_at":"2014-07-09T10:54:07Z","updated_at":"2014-07-16T12:53:43Z","pushed_at":"2014-07-22T09:09:37Z","git_url":"git://github.com/Wikia/android-chat.git","ssh_url":"git@github.com:Wikia/android-chat.git","clone_url":"https://github.com/Wikia/android-chat.git","svn_url":"https://github.com/Wikia/android-chat","homepage":null,"size":872,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"Wikia:develop","ref":"develop","sha":"a59cf5f2ea773c24db6d94482fcc333cd8dd3c42","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?","gravatar_id":"7d465709e42f40da92f14aae7e005558","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":21649089,"name":"android-chat","full_name":"Wikia/android-chat","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?","gravatar_id":"7d465709e42f40da92f14aae7e005558","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/android-chat","description":"","fork":false,"url":"https://api.github.com/repos/Wikia/android-chat","forks_url":"https://api.github.com/repos/Wikia/android-chat/forks","keys_url":"https://api.github.com/repos/Wikia/android-chat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/android-chat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/android-chat/teams","hooks_url":"https://api.github.com/repos/Wikia/android-chat/hooks","issue_events_url":"https://api.github.com/repos/Wikia/android-chat/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/android-chat/events","assignees_url":"https://api.github.com/repos/Wikia/android-chat/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/android-chat/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/android-chat/tags","blobs_url":"https://api.github.com/repos/Wikia/android-chat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/android-chat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/android-chat/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/android-chat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/android-chat/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/android-chat/languages","stargazers_url":"https://api.github.com/repos/Wikia/android-chat/stargazers","contributors_url":"https://api.github.com/repos/Wikia/android-chat/contributors","subscribers_url":"https://api.github.com/repos/Wikia/android-chat/subscribers","subscription_url":"https://api.github.com/repos/Wikia/android-chat/subscription","commits_url":"https://api.github.com/repos/Wikia/android-chat/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/android-chat/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/android-chat/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/android-chat/issues/comments/{number}","contents_url":"https://api.github.com/repos/Wikia/android-chat/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/android-chat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/android-chat/merges","archive_url":"https://api.github.com/repos/Wikia/android-chat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/android-chat/downloads","issues_url":"https://api.github.com/repos/Wikia/android-chat/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/android-chat/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/android-chat/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/android-chat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/android-chat/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/android-chat/releases{/id}","created_at":"2014-07-09T10:54:07Z","updated_at":"2014-07-16T12:53:43Z","pushed_at":"2014-07-22T09:09:37Z","git_url":"git://github.com/Wikia/android-chat.git","ssh_url":"git@github.com:Wikia/android-chat.git","clone_url":"https://github.com/Wikia/android-chat.git","svn_url":"https://github.com/Wikia/android-chat","homepage":null,"size":872,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Wikia/android-chat/pulls/5"},"html":{"href":"https://github.com/Wikia/android-chat/pull/5"},"issue":{"href":"https://api.github.com/repos/Wikia/android-chat/issues/5"},"comments":{"href":"https://api.github.com/repos/Wikia/android-chat/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/Wikia/android-chat/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/Wikia/android-chat/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Wikia/android-chat/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/Wikia/android-chat/statuses/8b26ac882d291bd03ba7f86d2efd7deed3afbd7c"}}}}