GitHub PullRequestEvent at 2014-12-22 22:34:36
Repository: wsandroid
Actor: rfay
Payload: {"action":"opened","number":157,"pull_request":{"url":"https://api.github.com/repos/warmshowers/wsandroid/pulls/157","id":26485371,"html_url":"https://github.com/warmshowers/wsandroid/pull/157","diff_url":"https://github.com/warmshowers/wsandroid/pull/157.diff","patch_url":"https://github.com/warmshowers/wsandroid/pull/157.patch","issue_url":"https://api.github.com/repos/warmshowers/wsandroid/issues/157","number":157,"state":"open","locked":false,"title":"Handle case where maps setup returns null","user":{"login":"rfay","id":112444,"avatar_url":"https://avatars.githubusercontent.com/u/112444?v=3","gravatar_id":"","url":"https://api.github.com/users/rfay","html_url":"https://github.com/rfay","followers_url":"https://api.github.com/users/rfay/followers","following_url":"https://api.github.com/users/rfay/following{/other_user}","gists_url":"https://api.github.com/users/rfay/gists{/gist_id}","starred_url":"https://api.github.com/users/rfay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfay/subscriptions","organizations_url":"https://api.github.com/users/rfay/orgs","repos_url":"https://api.github.com/users/rfay/repos","events_url":"https://api.github.com/users/rfay/events{/privacy}","received_events_url":"https://api.github.com/users/rfay/received_events","type":"User","site_admin":false},"body":"I noticed over in the Play Store crash reports a NullPointerException and tracked it a bit. \r\n\r\n[Report is here](https://play.google.com/apps/publish/?dev_acc=03117883992032047165#ErrorClusterDetailsPlace:p=fi.bitrite.android.ws&et=CRASH&sh=false&lr=LAST_7_DAYS&ecn=java.lang.NullPointerException&tf=Maps2Activity.java&tc=fi.bitrite.android.ws.activity.Maps2Activity&tm=onCreate&nid&an&c&s=new_status_desc)\r\n\r\nIt turns out getMap() can return null, resulting in null pointer problems after that. And it also turns out that in Play Services 6.5 they've deprecated getMap and replace with getMapAsync(), which is guaranteed to return a map. This little hack just notifies the user instead of crashing. The real fix is getting 6.5 in there.","created_at":"2014-12-22T22:34:35Z","updated_at":"2014-12-22T22:34:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/warmshowers/wsandroid/pulls/157/commits","review_comments_url":"https://api.github.com/repos/warmshowers/wsandroid/pulls/157/comments","review_comment_url":"https://api.github.com/repos/warmshowers/wsandroid/pulls/comments/{number}","comments_url":"https://api.github.com/repos/warmshowers/wsandroid/issues/157/comments","statuses_url":"https://api.github.com/repos/warmshowers/wsandroid/statuses/98d720eb55d0daf153833cbe99d2a7924e47f2e8","head":{"label":"rfay:20141222_fix_maps_null_pointer","ref":"20141222_fix_maps_null_pointer","sha":"98d720eb55d0daf153833cbe99d2a7924e47f2e8","user":{"login":"rfay","id":112444,"avatar_url":"https://avatars.githubusercontent.com/u/112444?v=3","gravatar_id":"","url":"https://api.github.com/users/rfay","html_url":"https://github.com/rfay","followers_url":"https://api.github.com/users/rfay/followers","following_url":"https://api.github.com/users/rfay/following{/other_user}","gists_url":"https://api.github.com/users/rfay/gists{/gist_id}","starred_url":"https://api.github.com/users/rfay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfay/subscriptions","organizations_url":"https://api.github.com/users/rfay/orgs","repos_url":"https://api.github.com/users/rfay/repos","events_url":"https://api.github.com/users/rfay/events{/privacy}","received_events_url":"https://api.github.com/users/rfay/received_events","type":"User","site_admin":false},"repo":{"id":8589376,"name":"wsandroid","full_name":"rfay/wsandroid","owner":{"login":"rfay","id":112444,"avatar_url":"https://avatars.githubusercontent.com/u/112444?v=3","gravatar_id":"","url":"https://api.github.com/users/rfay","html_url":"https://github.com/rfay","followers_url":"https://api.github.com/users/rfay/followers","following_url":"https://api.github.com/users/rfay/following{/other_user}","gists_url":"https://api.github.com/users/rfay/gists{/gist_id}","starred_url":"https://api.github.com/users/rfay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfay/subscriptions","organizations_url":"https://api.github.com/users/rfay/orgs","repos_url":"https://api.github.com/users/rfay/repos","events_url":"https://api.github.com/users/rfay/events{/privacy}","received_events_url":"https://api.github.com/users/rfay/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rfay/wsandroid","description":"WarmShowers for Android","fork":true,"url":"https://api.github.com/repos/rfay/wsandroid","forks_url":"https://api.github.com/repos/rfay/wsandroid/forks","keys_url":"https://api.github.com/repos/rfay/wsandroid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rfay/wsandroid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rfay/wsandroid/teams","hooks_url":"https://api.github.com/repos/rfay/wsandroid/hooks","issue_events_url":"https://api.github.com/repos/rfay/wsandroid/issues/events{/number}","events_url":"https://api.github.com/repos/rfay/wsandroid/events","assignees_url":"https://api.github.com/repos/rfay/wsandroid/assignees{/user}","branches_url":"https://api.github.com/repos/rfay/wsandroid/branches{/branch}","tags_url":"https://api.github.com/repos/rfay/wsandroid/tags","blobs_url":"https://api.github.com/repos/rfay/wsandroid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rfay/wsandroid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rfay/wsandroid/git/refs{/sha}","trees_url":"https://api.github.com/repos/rfay/wsandroid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rfay/wsandroid/statuses/{sha}","languages_url":"https://api.github.com/repos/rfay/wsandroid/languages","stargazers_url":"https://api.github.com/repos/rfay/wsandroid/stargazers","contributors_url":"https://api.github.com/repos/rfay/wsandroid/contributors","subscribers_url":"https://api.github.com/repos/rfay/wsandroid/subscribers","subscription_url":"https://api.github.com/repos/rfay/wsandroid/subscription","commits_url":"https://api.github.com/repos/rfay/wsandroid/commits{/sha}","git_commits_url":"https://api.github.com/repos/rfay/wsandroid/git/commits{/sha}","comments_url":"https://api.github.com/repos/rfay/wsandroid/comments{/number}","issue_comment_url":"https://api.github.com/repos/rfay/wsandroid/issues/comments/{number}","contents_url":"https://api.github.com/repos/rfay/wsandroid/contents/{+path}","compare_url":"https://api.github.com/repos/rfay/wsandroid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rfay/wsandroid/merges","archive_url":"https://api.github.com/repos/rfay/wsandroid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rfay/wsandroid/downloads","issues_url":"https://api.github.com/repos/rfay/wsandroid/issues{/number}","pulls_url":"https://api.github.com/repos/rfay/wsandroid/pulls{/number}","milestones_url":"https://api.github.com/repos/rfay/wsandroid/milestones{/number}","notifications_url":"https://api.github.com/repos/rfay/wsandroid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rfay/wsandroid/labels{/name}","releases_url":"https://api.github.com/repos/rfay/wsandroid/releases{/id}","created_at":"2013-03-05T21:20:05Z","updated_at":"2014-10-02T00:23:27Z","pushed_at":"2014-12-22T22:32:12Z","git_url":"git://github.com/rfay/wsandroid.git","ssh_url":"git@github.com:rfay/wsandroid.git","clone_url":"https://github.com/rfay/wsandroid.git","svn_url":"https://github.com/rfay/wsandroid","homepage":"","size":2652,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"warmshowers:master","ref":"master","sha":"4240834a8846ab373d9736d31f331f5d4afb91e8","user":{"login":"warmshowers","id":5882513,"avatar_url":"https://avatars.githubusercontent.com/u/5882513?v=3","gravatar_id":"","url":"https://api.github.com/users/warmshowers","html_url":"https://github.com/warmshowers","followers_url":"https://api.github.com/users/warmshowers/followers","following_url":"https://api.github.com/users/warmshowers/following{/other_user}","gists_url":"https://api.github.com/users/warmshowers/gists{/gist_id}","starred_url":"https://api.github.com/users/warmshowers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/warmshowers/subscriptions","organizations_url":"https://api.github.com/users/warmshowers/orgs","repos_url":"https://api.github.com/users/warmshowers/repos","events_url":"https://api.github.com/users/warmshowers/events{/privacy}","received_events_url":"https://api.github.com/users/warmshowers/received_events","type":"Organization","site_admin":false},"repo":{"id":3242289,"name":"wsandroid","full_name":"warmshowers/wsandroid","owner":{"login":"warmshowers","id":5882513,"avatar_url":"https://avatars.githubusercontent.com/u/5882513?v=3","gravatar_id":"","url":"https://api.github.com/users/warmshowers","html_url":"https://github.com/warmshowers","followers_url":"https://api.github.com/users/warmshowers/followers","following_url":"https://api.github.com/users/warmshowers/following{/other_user}","gists_url":"https://api.github.com/users/warmshowers/gists{/gist_id}","starred_url":"https://api.github.com/users/warmshowers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/warmshowers/subscriptions","organizations_url":"https://api.github.com/users/warmshowers/orgs","repos_url":"https://api.github.com/users/warmshowers/repos","events_url":"https://api.github.com/users/warmshowers/events{/privacy}","received_events_url":"https://api.github.com/users/warmshowers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/warmshowers/wsandroid","description":"WarmShowers for Android","fork":false,"url":"https://api.github.com/repos/warmshowers/wsandroid","forks_url":"https://api.github.com/repos/warmshowers/wsandroid/forks","keys_url":"https://api.github.com/repos/warmshowers/wsandroid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/warmshowers/wsandroid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/warmshowers/wsandroid/teams","hooks_url":"https://api.github.com/repos/warmshowers/wsandroid/hooks","issue_events_url":"https://api.github.com/repos/warmshowers/wsandroid/issues/events{/number}","events_url":"https://api.github.com/repos/warmshowers/wsandroid/events","assignees_url":"https://api.github.com/repos/warmshowers/wsandroid/assignees{/user}","branches_url":"https://api.github.com/repos/warmshowers/wsandroid/branches{/branch}","tags_url":"https://api.github.com/repos/warmshowers/wsandroid/tags","blobs_url":"https://api.github.com/repos/warmshowers/wsandroid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/warmshowers/wsandroid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/warmshowers/wsandroid/git/refs{/sha}","trees_url":"https://api.github.com/repos/warmshowers/wsandroid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/warmshowers/wsandroid/statuses/{sha}","languages_url":"https://api.github.com/repos/warmshowers/wsandroid/languages","stargazers_url":"https://api.github.com/repos/warmshowers/wsandroid/stargazers","contributors_url":"https://api.github.com/repos/warmshowers/wsandroid/contributors","subscribers_url":"https://api.github.com/repos/warmshowers/wsandroid/subscribers","subscription_url":"https://api.github.com/repos/warmshowers/wsandroid/subscription","commits_url":"https://api.github.com/repos/warmshowers/wsandroid/commits{/sha}","git_commits_url":"https://api.github.com/repos/warmshowers/wsandroid/git/commits{/sha}","comments_url":"https://api.github.com/repos/warmshowers/wsandroid/comments{/number}","issue_comment_url":"https://api.github.com/repos/warmshowers/wsandroid/issues/comments/{number}","contents_url":"https://api.github.com/repos/warmshowers/wsandroid/contents/{+path}","compare_url":"https://api.github.com/repos/warmshowers/wsandroid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/warmshowers/wsandroid/merges","archive_url":"https://api.github.com/repos/warmshowers/wsandroid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/warmshowers/wsandroid/downloads","issues_url":"https://api.github.com/repos/warmshowers/wsandroid/issues{/number}","pulls_url":"https://api.github.com/repos/warmshowers/wsandroid/pulls{/number}","milestones_url":"https://api.github.com/repos/warmshowers/wsandroid/milestones{/number}","notifications_url":"https://api.github.com/repos/warmshowers/wsandroid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/warmshowers/wsandroid/labels{/name}","releases_url":"https://api.github.com/repos/warmshowers/wsandroid/releases{/id}","created_at":"2012-01-22T21:41:33Z","updated_at":"2014-12-21T02:33:24Z","pushed_at":"2014-12-21T02:36:12Z","git_url":"git://github.com/warmshowers/wsandroid.git","ssh_url":"git@github.com:warmshowers/wsandroid.git","clone_url":"https://github.com/warmshowers/wsandroid.git","svn_url":"https://github.com/warmshowers/wsandroid","homepage":"","size":2796,"stargazers_count":13,"watchers_count":13,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":33,"forks":5,"open_issues":33,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/warmshowers/wsandroid/pulls/157"},"html":{"href":"https://github.com/warmshowers/wsandroid/pull/157"},"issue":{"href":"https://api.github.com/repos/warmshowers/wsandroid/issues/157"},"comments":{"href":"https://api.github.com/repos/warmshowers/wsandroid/issues/157/comments"},"review_comments":{"href":"https://api.github.com/repos/warmshowers/wsandroid/pulls/157/comments"},"review_comment":{"href":"https://api.github.com/repos/warmshowers/wsandroid/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/warmshowers/wsandroid/pulls/157/commits"},"statuses":{"href":"https://api.github.com/repos/warmshowers/wsandroid/statuses/98d720eb55d0daf153833cbe99d2a7924e47f2e8"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":14,"deletions":3,"changed_files":2}}