GitHub PullRequestReviewCommentEvent at 2014-05-23 09:05:57
Repository: pyclaw
Actor: hadjimy
Payload: {"comment":{"url":"https://api.github.com/repos/clawpack/pyclaw/pulls/comments/12991147","id":12991147,"diff_hunk":"@@ -496,28 +543,38 @@ def _allocate_registers(self,solution):\n \n \n     def get_cfl_max(self):\n-        if self.time_integrator == 'SSPMS32' and self.step_index > 2:\n-            sigma0 = self._registers[-3].cfl + self._registers[-2].cfl\n-            sigma1 = sigma0 / (self._sspcoeff[self.time_integrator] * sigma0 + self.cfl_max)\n+        \"\"\"\n+        Set maximum CFL number for current step depending on time integrator\n+        \"\"\"\n+        if self.time_integrator[:-2] == 'SSPMS' and self.step_index >= len(self._registers):","path":"src/pyclaw/sharpclaw/solver.py","position":140,"original_position":140,"commit_id":"efe30bcd3e1a811e9e841553fd06d583e5071b04","original_commit_id":"efe30bcd3e1a811e9e841553fd06d583e5071b04","user":{"login":"hadjimy","id":1243823,"avatar_url":"https://avatars.githubusercontent.com/u/1243823?","gravatar_id":"d39c43034b24e1becbc7e5321f270da9","url":"https://api.github.com/users/hadjimy","html_url":"https://github.com/hadjimy","followers_url":"https://api.github.com/users/hadjimy/followers","following_url":"https://api.github.com/users/hadjimy/following{/other_user}","gists_url":"https://api.github.com/users/hadjimy/gists{/gist_id}","starred_url":"https://api.github.com/users/hadjimy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hadjimy/subscriptions","organizations_url":"https://api.github.com/users/hadjimy/orgs","repos_url":"https://api.github.com/users/hadjimy/repos","events_url":"https://api.github.com/users/hadjimy/events{/privacy}","received_events_url":"https://api.github.com/users/hadjimy/received_events","type":"User","site_admin":false},"body":"I added a comment in ```_allocate_registers``` function saying the the number of registers of the starting procedure should not be larger than the registers used by the LMM.","created_at":"2014-05-23T09:05:57Z","updated_at":"2014-05-23T09:05:57Z","html_url":"https://github.com/clawpack/pyclaw/pull/403#discussion_r12991147","pull_request_url":"https://api.github.com/repos/clawpack/pyclaw/pulls/403","_links":{"self":{"href":"https://api.github.com/repos/clawpack/pyclaw/pulls/comments/12991147"},"html":{"href":"https://github.com/clawpack/pyclaw/pull/403#discussion_r12991147"},"pull_request":{"href":"https://api.github.com/repos/clawpack/pyclaw/pulls/403"}}}}