GitHub PullRequestReviewCommentEvent at 2014-12-29 17:46:18
Repository: logstash-contrib
Actor: semiosis
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/elasticsearch/logstash-contrib/pulls/comments/22320662","id":22320662,"diff_hunk":"@@ -0,0 +1,223 @@\n+# encoding: utf-8\n+require \"logstash/inputs/base\"\n+require \"logstash/namespace\"\n+require \"socket\" # for Socket.gethostname\n+\n+# Read events from a Java NIO.2 Path.\n+#\n+# By default, each event is assumed to be one line. If you\n+# want to join lines, you'll want to use the multiline filter.\n+class LogStash::Inputs::Nio2Path < LogStash::Inputs::Base\n+  config_name \"nio2path\"\n+  milestone 1\n+\n+  default :codec, \"line\"\n+  \n+  # A path glob for monitored files\n+  # \n+  # The directory must be exact, but the filename can be a pattern.\n+  # This can not be a recursive glob (** is not supported).\n+  #","path":"lib/logstash/inputs/nio2path.rb","position":20,"original_position":20,"commit_id":"b391cbbfb4657b9177f87da05f67757db1af5870","original_commit_id":"b391cbbfb4657b9177f87da05f67757db1af5870","user":{"login":"semiosis","id":1179099,"avatar_url":"https://avatars.githubusercontent.com/u/1179099?v=3","gravatar_id":"","url":"https://api.github.com/users/semiosis","html_url":"https://github.com/semiosis","followers_url":"https://api.github.com/users/semiosis/followers","following_url":"https://api.github.com/users/semiosis/following{/other_user}","gists_url":"https://api.github.com/users/semiosis/gists{/gist_id}","starred_url":"https://api.github.com/users/semiosis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/semiosis/subscriptions","organizations_url":"https://api.github.com/users/semiosis/orgs","repos_url":"https://api.github.com/users/semiosis/repos","events_url":"https://api.github.com/users/semiosis/events{/privacy}","received_events_url":"https://api.github.com/users/semiosis/received_events","type":"User","site_admin":false},"body":"I think you can do that with the file input.  Is there any reason why you need to use nio2path input instead?","created_at":"2014-12-29T17:46:18Z","updated_at":"2014-12-29T17:46:18Z","html_url":"https://github.com/elasticsearch/logstash-contrib/pull/35#discussion_r22320662","pull_request_url":"https://api.github.com/repos/elasticsearch/logstash-contrib/pulls/35","_links":{"self":{"href":"https://api.github.com/repos/elasticsearch/logstash-contrib/pulls/comments/22320662"},"html":{"href":"https://github.com/elasticsearch/logstash-contrib/pull/35#discussion_r22320662"},"pull_request":{"href":"https://api.github.com/repos/elasticsearch/logstash-contrib/pulls/35"}}},"pull_request":{"url":"https://api.github.com/repos/elasticsearch/logstash-contrib/pulls/35","id":13936687,"html_url":"https://github.com/elasticsearch/logstash-contrib/pull/35","diff_url":"https://github.com/elasticsearch/logstash-contrib/pull/35.diff","patch_url":"https://github.com/elasticsearch/logstash-contrib/pull/35.patch","issue_url":"https://api.github.com/repos/elasticsearch/logstash-contrib/issues/35","number":35,"state":"open","locked":false,"title":"LOGSTASH-1201 - Java 7 NIO.2 Input Plugin","user":{"login":"semiosis","id":1179099,"avatar_url":"https://avatars.githubusercontent.com/u/1179099?v=3","gravatar_id":"","url":"https://api.github.com/users/semiosis","html_url":"https://github.com/semiosis","followers_url":"https://api.github.com/users/semiosis/followers","following_url":"https://api.github.com/users/semiosis/following{/other_user}","gists_url":"https://api.github.com/users/semiosis/gists{/gist_id}","starred_url":"https://api.github.com/users/semiosis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/semiosis/subscriptions","organizations_url":"https://api.github.com/users/semiosis/orgs","repos_url":"https://api.github.com/users/semiosis/repos","events_url":"https://api.github.com/users/semiosis/events{/privacy}","received_events_url":"https://api.github.com/users/semiosis/received_events","type":"User","site_admin":false},"body":"File Input backed by Java 7 NIO.2\r\n\r\nhttps://logstash.jira.com/browse/LOGSTASH-1201","created_at":"2014-03-25T04:39:31Z","updated_at":"2014-12-29T17:46:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86ad6eab2138f90dafcc40ce80799fa5d6ddbe6f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/elasticsearch/logstash-contrib/pulls/35/commits","review_comments_url":"https://api.github.com/repos/elasticsearch/logstash-contrib/pulls/35/comments","review_comment_url":"https://api.github.com/repos/elasticsearch/logstash-contrib/pulls/comments/{number}","comments_url":"https://api.github.com/repos/elasticsearch/logstash-contrib/issues/35/comments","statuses_url":"https://api.github.com/repos/elasticsearch/logstash-contrib/statuses/b391cbbfb4657b9177f87da05f67757db1af5870","head":{"label":"semiosis:LOGSTASH-1201","ref":"LOGSTASH-1201","sha":"b391cbbfb4657b9177f87da05f67757db1af5870","user":{"login":"semiosis","id":1179099,"avatar_url":"https://avatars.githubusercontent.com/u/1179099?v=3","gravatar_id":"","url":"https://api.github.com/users/semiosis","html_url":"https://github.com/semiosis","followers_url":"https://api.github.com/users/semiosis/followers","following_url":"https://api.github.com/users/semiosis/following{/other_user}","gists_url":"https://api.github.com/users/semiosis/gists{/gist_id}","starred_url":"https://api.github.com/users/semiosis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/semiosis/subscriptions","organizations_url":"https://api.github.com/users/semiosis/orgs","repos_url":"https://api.github.com/users/semiosis/repos","events_url":"https://api.github.com/users/semiosis/events{/privacy}","received_events_url":"https://api.github.com/users/semiosis/received_events","type":"User","site_admin":false},"repo":{"id":18088868,"name":"logstash-contrib","full_name":"semiosis/logstash-contrib","owner":{"login":"semiosis","id":1179099,"avatar_url":"https://avatars.githubusercontent.com/u/1179099?v=3","gravatar_id":"","url":"https://api.github.com/users/semiosis","html_url":"https://github.com/semiosis","followers_url":"https://api.github.com/users/semiosis/followers","following_url":"https://api.github.com/users/semiosis/following{/other_user}","gists_url":"https://api.github.com/users/semiosis/gists{/gist_id}","starred_url":"https://api.github.com/users/semiosis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/semiosis/subscriptions","organizations_url":"https://api.github.com/users/semiosis/orgs","repos_url":"https://api.github.com/users/semiosis/repos","events_url":"https://api.github.com/users/semiosis/events{/privacy}","received_events_url":"https://api.github.com/users/semiosis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/semiosis/logstash-contrib","description":"community-maintained logstash plugin repository","fork":true,"url":"https://api.github.com/repos/semiosis/logstash-contrib","forks_url":"https://api.github.com/repos/semiosis/logstash-contrib/forks","keys_url":"https://api.github.com/repos/semiosis/logstash-contrib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/semiosis/logstash-contrib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/semiosis/logstash-contrib/teams","hooks_url":"https://api.github.com/repos/semiosis/logstash-contrib/hooks","issue_events_url":"https://api.github.com/repos/semiosis/logstash-contrib/issues/events{/number}","events_url":"https://api.github.com/repos/semiosis/logstash-contrib/events","assignees_url":"https://api.github.com/repos/semiosis/logstash-contrib/assignees{/user}","branches_url":"https://api.github.com/repos/semiosis/logstash-contrib/branches{/branch}","tags_url":"https://api.github.com/repos/semiosis/logstash-contrib/tags","blobs_url":"https://api.github.com/repos/semiosis/logstash-contrib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/semiosis/logstash-contrib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/semiosis/logstash-contrib/git/refs{/sha}","trees_url":"https://api.github.com/repos/semiosis/logstash-contrib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/semiosis/logstash-contrib/statuses/{sha}","languages_url":"https://api.github.com/repos/semiosis/logstash-contrib/languages","stargazers_url":"https://api.github.com/repos/semiosis/logstash-contrib/stargazers","contributors_url":"https://api.github.com/repos/semiosis/logstash-contrib/contributors","subscribers_url":"https://api.github.com/repos/semiosis/logstash-contrib/subscribers","subscription_url":"https://api.github.com/repos/semiosis/logstash-contrib/subscription","commits_url":"https://api.github.com/repos/semiosis/logstash-contrib/commits{/sha}","git_commits_url":"https://api.github.com/repos/semiosis/logstash-contrib/git/commits{/sha}","comments_url":"https://api.github.com/repos/semiosis/logstash-contrib/comments{/number}","issue_comment_url":"https://api.github.com/repos/semiosis/logstash-contrib/issues/comments/{number}","contents_url":"https://api.github.com/repos/semiosis/logstash-contrib/contents/{+path}","compare_url":"https://api.github.com/repos/semiosis/logstash-contrib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/semiosis/logstash-contrib/merges","archive_url":"https://api.github.com/repos/semiosis/logstash-contrib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/semiosis/logstash-contrib/downloads","issues_url":"https://api.github.com/repos/semiosis/logstash-contrib/issues{/number}","pulls_url":"https://api.github.com/repos/semiosis/logstash-contrib/pulls{/number}","milestones_url":"https://api.github.com/repos/semiosis/logstash-contrib/milestones{/number}","notifications_url":"https://api.github.com/repos/semiosis/logstash-contrib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/semiosis/logstash-contrib/labels{/name}","releases_url":"https://api.github.com/repos/semiosis/logstash-contrib/releases{/id}","created_at":"2014-03-25T04:35:42Z","updated_at":"2014-03-31T17:50:14Z","pushed_at":"2014-03-31T17:50:12Z","git_url":"git://github.com/semiosis/logstash-contrib.git","ssh_url":"git@github.com:semiosis/logstash-contrib.git","clone_url":"https://github.com/semiosis/logstash-contrib.git","svn_url":"https://github.com/semiosis/logstash-contrib","homepage":"http://logstash.net/","size":2601,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elasticsearch:master","ref":"master","sha":"aed7e1462f027ac41d8e778ddc30abe522b34408","user":{"login":"elasticsearch","id":141304,"avatar_url":"https://avatars.githubusercontent.com/u/141304?v=3","gravatar_id":"","url":"https://api.github.com/users/elasticsearch","html_url":"https://github.com/elasticsearch","followers_url":"https://api.github.com/users/elasticsearch/followers","following_url":"https://api.github.com/users/elasticsearch/following{/other_user}","gists_url":"https://api.github.com/users/elasticsearch/gists{/gist_id}","starred_url":"https://api.github.com/users/elasticsearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elasticsearch/subscriptions","organizations_url":"https://api.github.com/users/elasticsearch/orgs","repos_url":"https://api.github.com/users/elasticsearch/repos","events_url":"https://api.github.com/users/elasticsearch/events{/privacy}","received_events_url":"https://api.github.com/users/elasticsearch/received_events","type":"Organization","site_admin":false},"repo":{"id":15172931,"name":"logstash-contrib","full_name":"elasticsearch/logstash-contrib","owner":{"login":"elasticsearch","id":141304,"avatar_url":"https://avatars.githubusercontent.com/u/141304?v=3","gravatar_id":"","url":"https://api.github.com/users/elasticsearch","html_url":"https://github.com/elasticsearch","followers_url":"https://api.github.com/users/elasticsearch/followers","following_url":"https://api.github.com/users/elasticsearch/following{/other_user}","gists_url":"https://api.github.com/users/elasticsearch/gists{/gist_id}","starred_url":"https://api.github.com/users/elasticsearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elasticsearch/subscriptions","organizations_url":"https://api.github.com/users/elasticsearch/orgs","repos_url":"https://api.github.com/users/elasticsearch/repos","events_url":"https://api.github.com/users/elasticsearch/events{/privacy}","received_events_url":"https://api.github.com/users/elasticsearch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elasticsearch/logstash-contrib","description":"community-maintained logstash plugin repository","fork":false,"url":"https://api.github.com/repos/elasticsearch/logstash-contrib","forks_url":"https://api.github.com/repos/elasticsearch/logstash-contrib/forks","keys_url":"https://api.github.com/repos/elasticsearch/logstash-contrib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elasticsearch/logstash-contrib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elasticsearch/logstash-contrib/teams","hooks_url":"https://api.github.com/repos/elasticsearch/logstash-contrib/hooks","issue_events_url":"https://api.github.com/repos/elasticsearch/logstash-contrib/issues/events{/number}","events_url":"https://api.github.com/repos/elasticsearch/logstash-contrib/events","assignees_url":"https://api.github.com/repos/elasticsearch/logstash-contrib/assignees{/user}","branches_url":"https://api.github.com/repos/elasticsearch/logstash-contrib/branches{/branch}","tags_url":"https://api.github.com/repos/elasticsearch/logstash-contrib/tags","blobs_url":"https://api.github.com/repos/elasticsearch/logstash-contrib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elasticsearch/logstash-contrib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elasticsearch/logstash-contrib/git/refs{/sha}","trees_url":"https://api.github.com/repos/elasticsearch/logstash-contrib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elasticsearch/logstash-contrib/statuses/{sha}","languages_url":"https://api.github.com/repos/elasticsearch/logstash-contrib/languages","stargazers_url":"https://api.github.com/repos/elasticsearch/logstash-contrib/stargazers","contributors_url":"https://api.github.com/repos/elasticsearch/logstash-contrib/contributors","subscribers_url":"https://api.github.com/repos/elasticsearch/logstash-contrib/subscribers","subscription_url":"https://api.github.com/repos/elasticsearch/logstash-contrib/subscription","commits_url":"https://api.github.com/repos/elasticsearch/logstash-contrib/commits{/sha}","git_commits_url":"https://api.github.com/repos/elasticsearch/logstash-contrib/git/commits{/sha}","comments_url":"https://api.github.com/repos/elasticsearch/logstash-contrib/comments{/number}","issue_comment_url":"https://api.github.com/repos/elasticsearch/logstash-contrib/issues/comments/{number}","contents_url":"https://api.github.com/repos/elasticsearch/logstash-contrib/contents/{+path}","compare_url":"https://api.github.com/repos/elasticsearch/logstash-contrib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elasticsearch/logstash-contrib/merges","archive_url":"https://api.github.com/repos/elasticsearch/logstash-contrib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elasticsearch/logstash-contrib/downloads","issues_url":"https://api.github.com/repos/elasticsearch/logstash-contrib/issues{/number}","pulls_url":"https://api.github.com/repos/elasticsearch/logstash-contrib/pulls{/number}","milestones_url":"https://api.github.com/repos/elasticsearch/logstash-contrib/milestones{/number}","notifications_url":"https://api.github.com/repos/elasticsearch/logstash-contrib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elasticsearch/logstash-contrib/labels{/name}","releases_url":"https://api.github.com/repos/elasticsearch/logstash-contrib/releases{/id}","created_at":"2013-12-13T20:08:24Z","updated_at":"2014-12-27T04:33:16Z","pushed_at":"2014-12-11T00:43:49Z","git_url":"git://github.com/elasticsearch/logstash-contrib.git","ssh_url":"git@github.com:elasticsearch/logstash-contrib.git","clone_url":"https://github.com/elasticsearch/logstash-contrib.git","svn_url":"https://github.com/elasticsearch/logstash-contrib","homepage":"http://logstash.net/","size":5145,"stargazers_count":121,"watchers_count":121,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":160,"mirror_url":null,"open_issues_count":96,"forks":160,"open_issues":96,"watchers":121,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elasticsearch/logstash-contrib/pulls/35"},"html":{"href":"https://github.com/elasticsearch/logstash-contrib/pull/35"},"issue":{"href":"https://api.github.com/repos/elasticsearch/logstash-contrib/issues/35"},"comments":{"href":"https://api.github.com/repos/elasticsearch/logstash-contrib/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/elasticsearch/logstash-contrib/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/elasticsearch/logstash-contrib/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/elasticsearch/logstash-contrib/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/elasticsearch/logstash-contrib/statuses/b391cbbfb4657b9177f87da05f67757db1af5870"}}}}