GitHub PullRequestReviewCommentEvent at 2014-07-01 22:50:06
Repository: xbmc
Actor: jmarshallnz
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/14432968","id":14432968,"diff_hunk":"@@ -248,12 +269,21 @@ bool CAESinkDARWINOSX::Initialize(AEAudioFormat &format, std::string &device)\n   /* Update our AE format */\n   format.m_sampleRate    = outputFormat.mSampleRate;\n   \n-  m_outputBitstream   = passthrough && outputFormat.mFormatID == kAudioFormatLinearPCM;\n+  m_outputBitstream   = passthrough == PassthroughModeBitstream;\n \n   std::string formatString;\n   CLog::Log(LOGDEBUG, \"%s: Selected stream[%u] - id: 0x%04X, Physical Format: %s %s\", __FUNCTION__, (unsigned int)0, (unsigned int)outputStream, StreamDescriptionToString(outputFormat, formatString), m_outputBitstream ? \"bitstreamed passthrough\" : \"\");\n \n-  SetHogMode(passthrough);\n+  SetHogMode(passthrough != PassthroughModeNone);\n+  \n+  //in case this is a dedicated passthroughformat\n+  //unregister the default output device changed callback\n+  //because setting an encoded format might change the default output\n+  //device - and we will end up looping with output device change ping pong\n+  if (passthrough == PassthroughModeNative)\n+    RegisterDefaultOutputDeviceChangedCB(false, this);\n+  else\n+    RegisterDefaultOutputDeviceChangedCB(true, this);","path":"xbmc/cores/AudioEngine/Sinks/AESinkDARWINOSX.cpp","position":102,"original_position":102,"commit_id":"3f2d8679432426899fe8d6c99f48e9896c497b30","original_commit_id":"3f2d8679432426899fe8d6c99f48e9896c497b30","user":{"login":"jmarshallnz","id":406571,"avatar_url":"https://avatars.githubusercontent.com/u/406571?","gravatar_id":"f2f465d1d46f3f4436a7658f9817fa95","url":"https://api.github.com/users/jmarshallnz","html_url":"https://github.com/jmarshallnz","followers_url":"https://api.github.com/users/jmarshallnz/followers","following_url":"https://api.github.com/users/jmarshallnz/following{/other_user}","gists_url":"https://api.github.com/users/jmarshallnz/gists{/gist_id}","starred_url":"https://api.github.com/users/jmarshallnz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmarshallnz/subscriptions","organizations_url":"https://api.github.com/users/jmarshallnz/orgs","repos_url":"https://api.github.com/users/jmarshallnz/repos","events_url":"https://api.github.com/users/jmarshallnz/events{/privacy}","received_events_url":"https://api.github.com/users/jmarshallnz/received_events","type":"User","site_admin":false},"body":"Sure, but you don't want the enumeration to occur *in this case*, right?  As that's what is causing the problem?","created_at":"2014-07-01T22:50:06Z","updated_at":"2014-07-01T22:50:06Z","html_url":"https://github.com/xbmc/xbmc/pull/4975#discussion_r14432968","pull_request_url":"https://api.github.com/repos/xbmc/xbmc/pulls/4975","_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/14432968"},"html":{"href":"https://github.com/xbmc/xbmc/pull/4975#discussion_r14432968"},"pull_request":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/4975"}}},"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/4975","id":17854828,"html_url":"https://github.com/xbmc/xbmc/pull/4975","diff_url":"https://github.com/xbmc/xbmc/pull/4975.diff","patch_url":"https://github.com/xbmc/xbmc/pull/4975.patch","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/4975","number":4975,"state":"open","title":"[AE/osxsink] - fix possible device changed loop when using passthrough","user":{"login":"Memphiz","id":701326,"avatar_url":"https://avatars.githubusercontent.com/u/701326?","gravatar_id":"f4afe5681251b71d93bc8f750ef74062","url":"https://api.github.com/users/Memphiz","html_url":"https://github.com/Memphiz","followers_url":"https://api.github.com/users/Memphiz/followers","following_url":"https://api.github.com/users/Memphiz/following{/other_user}","gists_url":"https://api.github.com/users/Memphiz/gists{/gist_id}","starred_url":"https://api.github.com/users/Memphiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Memphiz/subscriptions","organizations_url":"https://api.github.com/users/Memphiz/orgs","repos_url":"https://api.github.com/users/Memphiz/repos","events_url":"https://api.github.com/users/Memphiz/events{/privacy}","received_events_url":"https://api.github.com/users/Memphiz/received_events","type":"User","site_admin":false},"body":"Damnit - that one slipped in when i added the registration to the default output device changed callback.\r\n\r\n@jmarshalnz for review - Gotham material sadly.","created_at":"2014-07-01T21:03:24Z","updated_at":"2014-07-01T22:50:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f308c22a47191f7943a254775f9b2de007a0de0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/xbmc/xbmc/pulls/4975/commits","review_comments_url":"https://api.github.com/repos/xbmc/xbmc/pulls/4975/comments","review_comment_url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/{number}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/4975/comments","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/3f2d8679432426899fe8d6c99f48e9896c497b30","head":{"label":"Memphiz:osx_fix_devicechanged_recursion","ref":"osx_fix_devicechanged_recursion","sha":"3f2d8679432426899fe8d6c99f48e9896c497b30","user":{"login":"Memphiz","id":701326,"avatar_url":"https://avatars.githubusercontent.com/u/701326?","gravatar_id":"f4afe5681251b71d93bc8f750ef74062","url":"https://api.github.com/users/Memphiz","html_url":"https://github.com/Memphiz","followers_url":"https://api.github.com/users/Memphiz/followers","following_url":"https://api.github.com/users/Memphiz/following{/other_user}","gists_url":"https://api.github.com/users/Memphiz/gists{/gist_id}","starred_url":"https://api.github.com/users/Memphiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Memphiz/subscriptions","organizations_url":"https://api.github.com/users/Memphiz/orgs","repos_url":"https://api.github.com/users/Memphiz/repos","events_url":"https://api.github.com/users/Memphiz/events{/privacy}","received_events_url":"https://api.github.com/users/Memphiz/received_events","type":"User","site_admin":false},"repo":{"id":1550525,"name":"xbmc","full_name":"Memphiz/xbmc","owner":{"login":"Memphiz","id":701326,"avatar_url":"https://avatars.githubusercontent.com/u/701326?","gravatar_id":"f4afe5681251b71d93bc8f750ef74062","url":"https://api.github.com/users/Memphiz","html_url":"https://github.com/Memphiz","followers_url":"https://api.github.com/users/Memphiz/followers","following_url":"https://api.github.com/users/Memphiz/following{/other_user}","gists_url":"https://api.github.com/users/Memphiz/gists{/gist_id}","starred_url":"https://api.github.com/users/Memphiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Memphiz/subscriptions","organizations_url":"https://api.github.com/users/Memphiz/orgs","repos_url":"https://api.github.com/users/Memphiz/repos","events_url":"https://api.github.com/users/Memphiz/events{/privacy}","received_events_url":"https://api.github.com/users/Memphiz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Memphiz/xbmc","description":"XBMC Main Repository","fork":true,"url":"https://api.github.com/repos/Memphiz/xbmc","forks_url":"https://api.github.com/repos/Memphiz/xbmc/forks","keys_url":"https://api.github.com/repos/Memphiz/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Memphiz/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Memphiz/xbmc/teams","hooks_url":"https://api.github.com/repos/Memphiz/xbmc/hooks","issue_events_url":"https://api.github.com/repos/Memphiz/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/Memphiz/xbmc/events","assignees_url":"https://api.github.com/repos/Memphiz/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/Memphiz/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/Memphiz/xbmc/tags","blobs_url":"https://api.github.com/repos/Memphiz/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Memphiz/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Memphiz/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/Memphiz/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Memphiz/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/Memphiz/xbmc/languages","stargazers_url":"https://api.github.com/repos/Memphiz/xbmc/stargazers","contributors_url":"https://api.github.com/repos/Memphiz/xbmc/contributors","subscribers_url":"https://api.github.com/repos/Memphiz/xbmc/subscribers","subscription_url":"https://api.github.com/repos/Memphiz/xbmc/subscription","commits_url":"https://api.github.com/repos/Memphiz/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/Memphiz/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/Memphiz/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/Memphiz/xbmc/issues/comments/{number}","contents_url":"https://api.github.com/repos/Memphiz/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/Memphiz/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Memphiz/xbmc/merges","archive_url":"https://api.github.com/repos/Memphiz/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Memphiz/xbmc/downloads","issues_url":"https://api.github.com/repos/Memphiz/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/Memphiz/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/Memphiz/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/Memphiz/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Memphiz/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/Memphiz/xbmc/releases{/id}","created_at":"2011-03-31T11:10:34Z","updated_at":"2014-06-25T22:19:29Z","pushed_at":"2014-07-01T21:04:18Z","git_url":"git://github.com/Memphiz/xbmc.git","ssh_url":"git@github.com:Memphiz/xbmc.git","clone_url":"https://github.com/Memphiz/xbmc.git","svn_url":"https://github.com/Memphiz/xbmc","homepage":"http://xbmc.org","size":631313,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":2,"mirror_url":null,"open_issues_count":5,"forks":2,"open_issues":5,"watchers":5,"default_branch":"master"}},"base":{"label":"xbmc:master","ref":"master","sha":"fde760bcbcff3ca75f3d6eea91b6230ed74c7009","user":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?","gravatar_id":"8a14492c66bf09a3016b416347a5dcc9","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"repo":{"id":1217614,"name":"xbmc","full_name":"xbmc/xbmc","owner":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?","gravatar_id":"8a14492c66bf09a3016b416347a5dcc9","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xbmc/xbmc","description":"XBMC Main Repository","fork":false,"url":"https://api.github.com/repos/xbmc/xbmc","forks_url":"https://api.github.com/repos/xbmc/xbmc/forks","keys_url":"https://api.github.com/repos/xbmc/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xbmc/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xbmc/xbmc/teams","hooks_url":"https://api.github.com/repos/xbmc/xbmc/hooks","issue_events_url":"https://api.github.com/repos/xbmc/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/xbmc/xbmc/events","assignees_url":"https://api.github.com/repos/xbmc/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/xbmc/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/xbmc/xbmc/tags","blobs_url":"https://api.github.com/repos/xbmc/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xbmc/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xbmc/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/xbmc/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/xbmc/xbmc/languages","stargazers_url":"https://api.github.com/repos/xbmc/xbmc/stargazers","contributors_url":"https://api.github.com/repos/xbmc/xbmc/contributors","subscribers_url":"https://api.github.com/repos/xbmc/xbmc/subscribers","subscription_url":"https://api.github.com/repos/xbmc/xbmc/subscription","commits_url":"https://api.github.com/repos/xbmc/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/xbmc/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/xbmc/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/xbmc/xbmc/issues/comments/{number}","contents_url":"https://api.github.com/repos/xbmc/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/xbmc/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xbmc/xbmc/merges","archive_url":"https://api.github.com/repos/xbmc/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xbmc/xbmc/downloads","issues_url":"https://api.github.com/repos/xbmc/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/xbmc/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/xbmc/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/xbmc/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xbmc/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/xbmc/xbmc/releases{/id}","created_at":"2011-01-03T21:18:51Z","updated_at":"2014-07-01T21:48:15Z","pushed_at":"2014-07-01T22:12:37Z","git_url":"git://github.com/xbmc/xbmc.git","ssh_url":"git@github.com:xbmc/xbmc.git","clone_url":"https://github.com/xbmc/xbmc.git","svn_url":"https://github.com/xbmc/xbmc","homepage":"http://xbmc.org","size":1736621,"stargazers_count":3233,"watchers_count":3233,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":2223,"mirror_url":null,"open_issues_count":186,"forks":2223,"open_issues":186,"watchers":3233,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/4975"},"html":{"href":"https://github.com/xbmc/xbmc/pull/4975"},"issue":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/4975"},"comments":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/4975/comments"},"review_comments":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/4975/comments"},"review_comment":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/4975/commits"},"statuses":{"href":"https://api.github.com/repos/xbmc/xbmc/statuses/3f2d8679432426899fe8d6c99f48e9896c497b30"}}}}