GitHub PullRequestReviewCommentEvent at 2014-06-24 17:39:23
Repository: nt2
Actor: jfalcou
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/MetaScale/nt2/pulls/comments/14143372","id":14143372,"diff_hunk":"@@ -24,4 +27,21 @@ namespace boost { namespace dispatch { namespace meta\n   };\n } } }\n \n+namespace nt2 { namespace meta\n+{\n+  /// INTERNAL ONLY : Option of expression use its settings and semantic\n+  template<typename Expr, typename Result, typename Tag>\n+  struct  option< nt2::container::expression<Expr, Result> , Tag>","path":"modules/core/sdk/include/nt2/core/container/dsl/details/expression.hpp","position":null,"original_position":18,"commit_id":"73f649e5c8243e20e515e57dc1b8d50f40b87b15","original_commit_id":"d4f595a7fa4c47bedf109ef4f48d829df6af3552","user":{"login":"jfalcou","id":285977,"avatar_url":"https://avatars.githubusercontent.com/u/285977?","gravatar_id":"7acf7a92dcaa6a37f8151eeb865715b2","url":"https://api.github.com/users/jfalcou","html_url":"https://github.com/jfalcou","followers_url":"https://api.github.com/users/jfalcou/followers","following_url":"https://api.github.com/users/jfalcou/following{/other_user}","gists_url":"https://api.github.com/users/jfalcou/gists{/gist_id}","starred_url":"https://api.github.com/users/jfalcou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfalcou/subscriptions","organizations_url":"https://api.github.com/users/jfalcou/orgs","repos_url":"https://api.github.com/users/jfalcou/repos","events_url":"https://api.github.com/users/jfalcou/events{/privacy}","received_events_url":"https://api.github.com/users/jfalcou/received_events","type":"User","site_admin":false},"body":"Nope we add it for a lot of thing but the expression case was not handled. We actually never had code requiring an full expression's option set. Incidentally, I changed the implementation to be more correct.","created_at":"2014-06-24T17:39:23Z","updated_at":"2014-06-24T17:39:23Z","html_url":"https://github.com/MetaScale/nt2/pull/767#discussion_r14143372","pull_request_url":"https://api.github.com/repos/MetaScale/nt2/pulls/767","_links":{"self":{"href":"https://api.github.com/repos/MetaScale/nt2/pulls/comments/14143372"},"html":{"href":"https://github.com/MetaScale/nt2/pull/767#discussion_r14143372"},"pull_request":{"href":"https://api.github.com/repos/MetaScale/nt2/pulls/767"}}},"pull_request":{"url":"https://api.github.com/repos/MetaScale/nt2/pulls/767","id":17450390,"html_url":"https://github.com/MetaScale/nt2/pull/767","diff_url":"https://github.com/MetaScale/nt2/pull/767.diff","patch_url":"https://github.com/MetaScale/nt2/pull/767.patch","issue_url":"https://api.github.com/repos/MetaScale/nt2/issues/767","number":767,"state":"open","title":"Fix for #390","user":{"login":"jfalcou","id":285977,"avatar_url":"https://avatars.githubusercontent.com/u/285977?","gravatar_id":"7acf7a92dcaa6a37f8151eeb865715b2","url":"https://api.github.com/users/jfalcou","html_url":"https://github.com/jfalcou","followers_url":"https://api.github.com/users/jfalcou/followers","following_url":"https://api.github.com/users/jfalcou/following{/other_user}","gists_url":"https://api.github.com/users/jfalcou/gists{/gist_id}","starred_url":"https://api.github.com/users/jfalcou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfalcou/subscriptions","organizations_url":"https://api.github.com/users/jfalcou/orgs","repos_url":"https://api.github.com/users/jfalcou/repos","events_url":"https://api.github.com/users/jfalcou/events{/privacy}","received_events_url":"https://api.github.com/users/jfalcou/received_events","type":"User","site_admin":false},"body":"storage_size_<N> is a setting that notify the container that its storage will be an automatic storage of N elements. Compared to of_size_ and automatic_/dynamic_, storage_size_ allows for the actual extent of an automatic_ container to be mutable as long as it fits inside the memory allocated.\r\n\r\nThis PR also fix cons which was the main use case for storage size and make table with static size have automatic storage by default.","created_at":"2014-06-22T18:02:56Z","updated_at":"2014-06-24T17:39:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"38556dcafb2d69fe87cb9e1be2d8c2de39082569","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/MetaScale/nt2/pulls/767/commits","review_comments_url":"https://api.github.com/repos/MetaScale/nt2/pulls/767/comments","review_comment_url":"https://api.github.com/repos/MetaScale/nt2/pulls/comments/{number}","comments_url":"https://api.github.com/repos/MetaScale/nt2/issues/767/comments","statuses_url":"https://api.github.com/repos/MetaScale/nt2/statuses/73f649e5c8243e20e515e57dc1b8d50f40b87b15","head":{"label":"MetaScale:issue_390-storage_size","ref":"issue_390-storage_size","sha":"73f649e5c8243e20e515e57dc1b8d50f40b87b15","user":{"login":"MetaScale","id":451929,"avatar_url":"https://avatars.githubusercontent.com/u/451929?","gravatar_id":"eb36b51fe86a74c839b94a13fe99b45d","url":"https://api.github.com/users/MetaScale","html_url":"https://github.com/MetaScale","followers_url":"https://api.github.com/users/MetaScale/followers","following_url":"https://api.github.com/users/MetaScale/following{/other_user}","gists_url":"https://api.github.com/users/MetaScale/gists{/gist_id}","starred_url":"https://api.github.com/users/MetaScale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MetaScale/subscriptions","organizations_url":"https://api.github.com/users/MetaScale/orgs","repos_url":"https://api.github.com/users/MetaScale/repos","events_url":"https://api.github.com/users/MetaScale/events{/privacy}","received_events_url":"https://api.github.com/users/MetaScale/received_events","type":"Organization","site_admin":false},"repo":{"id":704698,"name":"nt2","full_name":"MetaScale/nt2","owner":{"login":"MetaScale","id":451929,"avatar_url":"https://avatars.githubusercontent.com/u/451929?","gravatar_id":"eb36b51fe86a74c839b94a13fe99b45d","url":"https://api.github.com/users/MetaScale","html_url":"https://github.com/MetaScale","followers_url":"https://api.github.com/users/MetaScale/followers","following_url":"https://api.github.com/users/MetaScale/following{/other_user}","gists_url":"https://api.github.com/users/MetaScale/gists{/gist_id}","starred_url":"https://api.github.com/users/MetaScale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MetaScale/subscriptions","organizations_url":"https://api.github.com/users/MetaScale/orgs","repos_url":"https://api.github.com/users/MetaScale/repos","events_url":"https://api.github.com/users/MetaScale/events{/privacy}","received_events_url":"https://api.github.com/users/MetaScale/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MetaScale/nt2","description":"The Numerical Template Toolbox - C++ Scientific Computing Made Easy","fork":false,"url":"https://api.github.com/repos/MetaScale/nt2","forks_url":"https://api.github.com/repos/MetaScale/nt2/forks","keys_url":"https://api.github.com/repos/MetaScale/nt2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MetaScale/nt2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MetaScale/nt2/teams","hooks_url":"https://api.github.com/repos/MetaScale/nt2/hooks","issue_events_url":"https://api.github.com/repos/MetaScale/nt2/issues/events{/number}","events_url":"https://api.github.com/repos/MetaScale/nt2/events","assignees_url":"https://api.github.com/repos/MetaScale/nt2/assignees{/user}","branches_url":"https://api.github.com/repos/MetaScale/nt2/branches{/branch}","tags_url":"https://api.github.com/repos/MetaScale/nt2/tags","blobs_url":"https://api.github.com/repos/MetaScale/nt2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MetaScale/nt2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MetaScale/nt2/git/refs{/sha}","trees_url":"https://api.github.com/repos/MetaScale/nt2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MetaScale/nt2/statuses/{sha}","languages_url":"https://api.github.com/repos/MetaScale/nt2/languages","stargazers_url":"https://api.github.com/repos/MetaScale/nt2/stargazers","contributors_url":"https://api.github.com/repos/MetaScale/nt2/contributors","subscribers_url":"https://api.github.com/repos/MetaScale/nt2/subscribers","subscription_url":"https://api.github.com/repos/MetaScale/nt2/subscription","commits_url":"https://api.github.com/repos/MetaScale/nt2/commits{/sha}","git_commits_url":"https://api.github.com/repos/MetaScale/nt2/git/commits{/sha}","comments_url":"https://api.github.com/repos/MetaScale/nt2/comments{/number}","issue_comment_url":"https://api.github.com/repos/MetaScale/nt2/issues/comments/{number}","contents_url":"https://api.github.com/repos/MetaScale/nt2/contents/{+path}","compare_url":"https://api.github.com/repos/MetaScale/nt2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MetaScale/nt2/merges","archive_url":"https://api.github.com/repos/MetaScale/nt2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MetaScale/nt2/downloads","issues_url":"https://api.github.com/repos/MetaScale/nt2/issues{/number}","pulls_url":"https://api.github.com/repos/MetaScale/nt2/pulls{/number}","milestones_url":"https://api.github.com/repos/MetaScale/nt2/milestones{/number}","notifications_url":"https://api.github.com/repos/MetaScale/nt2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MetaScale/nt2/labels{/name}","releases_url":"https://api.github.com/repos/MetaScale/nt2/releases{/id}","created_at":"2010-06-05T11:44:49Z","updated_at":"2014-06-24T17:38:29Z","pushed_at":"2014-06-24T17:38:29Z","git_url":"git://github.com/MetaScale/nt2.git","ssh_url":"git@github.com:MetaScale/nt2.git","clone_url":"https://github.com/MetaScale/nt2.git","svn_url":"https://github.com/MetaScale/nt2","homepage":"http://nt2.metascale.org","size":151080,"stargazers_count":132,"watchers_count":132,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":32,"mirror_url":null,"open_issues_count":95,"forks":32,"open_issues":95,"watchers":132,"default_branch":"master"}},"base":{"label":"MetaScale:master","ref":"master","sha":"40b1138d85f0e71b3ae5555bf6b0a5601a19a2db","user":{"login":"MetaScale","id":451929,"avatar_url":"https://avatars.githubusercontent.com/u/451929?","gravatar_id":"eb36b51fe86a74c839b94a13fe99b45d","url":"https://api.github.com/users/MetaScale","html_url":"https://github.com/MetaScale","followers_url":"https://api.github.com/users/MetaScale/followers","following_url":"https://api.github.com/users/MetaScale/following{/other_user}","gists_url":"https://api.github.com/users/MetaScale/gists{/gist_id}","starred_url":"https://api.github.com/users/MetaScale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MetaScale/subscriptions","organizations_url":"https://api.github.com/users/MetaScale/orgs","repos_url":"https://api.github.com/users/MetaScale/repos","events_url":"https://api.github.com/users/MetaScale/events{/privacy}","received_events_url":"https://api.github.com/users/MetaScale/received_events","type":"Organization","site_admin":false},"repo":{"id":704698,"name":"nt2","full_name":"MetaScale/nt2","owner":{"login":"MetaScale","id":451929,"avatar_url":"https://avatars.githubusercontent.com/u/451929?","gravatar_id":"eb36b51fe86a74c839b94a13fe99b45d","url":"https://api.github.com/users/MetaScale","html_url":"https://github.com/MetaScale","followers_url":"https://api.github.com/users/MetaScale/followers","following_url":"https://api.github.com/users/MetaScale/following{/other_user}","gists_url":"https://api.github.com/users/MetaScale/gists{/gist_id}","starred_url":"https://api.github.com/users/MetaScale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MetaScale/subscriptions","organizations_url":"https://api.github.com/users/MetaScale/orgs","repos_url":"https://api.github.com/users/MetaScale/repos","events_url":"https://api.github.com/users/MetaScale/events{/privacy}","received_events_url":"https://api.github.com/users/MetaScale/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MetaScale/nt2","description":"The Numerical Template Toolbox - C++ Scientific Computing Made Easy","fork":false,"url":"https://api.github.com/repos/MetaScale/nt2","forks_url":"https://api.github.com/repos/MetaScale/nt2/forks","keys_url":"https://api.github.com/repos/MetaScale/nt2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MetaScale/nt2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MetaScale/nt2/teams","hooks_url":"https://api.github.com/repos/MetaScale/nt2/hooks","issue_events_url":"https://api.github.com/repos/MetaScale/nt2/issues/events{/number}","events_url":"https://api.github.com/repos/MetaScale/nt2/events","assignees_url":"https://api.github.com/repos/MetaScale/nt2/assignees{/user}","branches_url":"https://api.github.com/repos/MetaScale/nt2/branches{/branch}","tags_url":"https://api.github.com/repos/MetaScale/nt2/tags","blobs_url":"https://api.github.com/repos/MetaScale/nt2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MetaScale/nt2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MetaScale/nt2/git/refs{/sha}","trees_url":"https://api.github.com/repos/MetaScale/nt2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MetaScale/nt2/statuses/{sha}","languages_url":"https://api.github.com/repos/MetaScale/nt2/languages","stargazers_url":"https://api.github.com/repos/MetaScale/nt2/stargazers","contributors_url":"https://api.github.com/repos/MetaScale/nt2/contributors","subscribers_url":"https://api.github.com/repos/MetaScale/nt2/subscribers","subscription_url":"https://api.github.com/repos/MetaScale/nt2/subscription","commits_url":"https://api.github.com/repos/MetaScale/nt2/commits{/sha}","git_commits_url":"https://api.github.com/repos/MetaScale/nt2/git/commits{/sha}","comments_url":"https://api.github.com/repos/MetaScale/nt2/comments{/number}","issue_comment_url":"https://api.github.com/repos/MetaScale/nt2/issues/comments/{number}","contents_url":"https://api.github.com/repos/MetaScale/nt2/contents/{+path}","compare_url":"https://api.github.com/repos/MetaScale/nt2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MetaScale/nt2/merges","archive_url":"https://api.github.com/repos/MetaScale/nt2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MetaScale/nt2/downloads","issues_url":"https://api.github.com/repos/MetaScale/nt2/issues{/number}","pulls_url":"https://api.github.com/repos/MetaScale/nt2/pulls{/number}","milestones_url":"https://api.github.com/repos/MetaScale/nt2/milestones{/number}","notifications_url":"https://api.github.com/repos/MetaScale/nt2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MetaScale/nt2/labels{/name}","releases_url":"https://api.github.com/repos/MetaScale/nt2/releases{/id}","created_at":"2010-06-05T11:44:49Z","updated_at":"2014-06-24T17:38:29Z","pushed_at":"2014-06-24T17:38:29Z","git_url":"git://github.com/MetaScale/nt2.git","ssh_url":"git@github.com:MetaScale/nt2.git","clone_url":"https://github.com/MetaScale/nt2.git","svn_url":"https://github.com/MetaScale/nt2","homepage":"http://nt2.metascale.org","size":151080,"stargazers_count":132,"watchers_count":132,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":32,"mirror_url":null,"open_issues_count":95,"forks":32,"open_issues":95,"watchers":132,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MetaScale/nt2/pulls/767"},"html":{"href":"https://github.com/MetaScale/nt2/pull/767"},"issue":{"href":"https://api.github.com/repos/MetaScale/nt2/issues/767"},"comments":{"href":"https://api.github.com/repos/MetaScale/nt2/issues/767/comments"},"review_comments":{"href":"https://api.github.com/repos/MetaScale/nt2/pulls/767/comments"},"review_comment":{"href":"https://api.github.com/repos/MetaScale/nt2/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/MetaScale/nt2/pulls/767/commits"},"statuses":{"href":"https://api.github.com/repos/MetaScale/nt2/statuses/73f649e5c8243e20e515e57dc1b8d50f40b87b15"}}}}