GitHub PullRequestReviewCommentEvent at 2014-03-01 11:58:43
Repository: collectfast
Actor: antonagestam
Payload: {"comment":{"url":"https://api.github.com/repos/antonagestam/collectfast/pulls/comments/10190440","id":10190440,"diff_hunk":"@@ -12,6 +13,18 @@\n from django.utils.encoding import smart_str\n \n \n+def check_location(method):\n+    @wraps(method)\n+    def add_location(self, path):\n+        try:\n+            if not path.startswith(self.storage.location):","path":"collectfast/management/commands/collectstatic.py","position":16,"original_position":16,"commit_id":"154aca1e9d4c381404458c115ea75a1f7a02b004","original_commit_id":"154aca1e9d4c381404458c115ea75a1f7a02b004","user":{"login":"antonagestam","id":218551,"avatar_url":"https://avatars.githubusercontent.com/u/218551","gravatar_id":"bd00c999f7a024574a0b3cc53e188f65","url":"https://api.github.com/users/antonagestam","html_url":"https://github.com/antonagestam","followers_url":"https://api.github.com/users/antonagestam/followers","following_url":"https://api.github.com/users/antonagestam/following{/other_user}","gists_url":"https://api.github.com/users/antonagestam/gists{/gist_id}","starred_url":"https://api.github.com/users/antonagestam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antonagestam/subscriptions","organizations_url":"https://api.github.com/users/antonagestam/orgs","repos_url":"https://api.github.com/users/antonagestam/repos","events_url":"https://api.github.com/users/antonagestam/events{/privacy}","received_events_url":"https://api.github.com/users/antonagestam/received_events","type":"User","site_admin":false},"body":"Why should the normalization not always be applied? In what case will it already be prepended?\r\n\r\nWill this code work with files with names starting with the location name?","created_at":"2014-03-01T11:58:43Z","updated_at":"2014-03-01T11:58:43Z","html_url":"https://github.com/antonagestam/collectfast/pull/21#discussion_r10190440","pull_request_url":"https://api.github.com/repos/antonagestam/collectfast/pulls/21","_links":{"self":{"href":"https://api.github.com/repos/antonagestam/collectfast/pulls/comments/10190440"},"html":{"href":"https://github.com/antonagestam/collectfast/pull/21#discussion_r10190440"},"pull_request":{"href":"https://api.github.com/repos/antonagestam/collectfast/pulls/21"}}}}