GitHub PullRequestEvent at 2014-12-10 16:29:36
Repository: Slatwall
Actor: gregmoser
Payload: {"action":"closed","number":2686,"pull_request":{"url":"https://api.github.com/repos/ten24/Slatwall/pulls/2686","id":25787459,"html_url":"https://github.com/ten24/Slatwall/pull/2686","diff_url":"https://github.com/ten24/Slatwall/pull/2686.diff","patch_url":"https://github.com/ten24/Slatwall/pull/2686.patch","issue_url":"https://api.github.com/repos/ten24/Slatwall/issues/2686","number":2686,"state":"closed","locked":false,"title":"Potential Fix for this issue","user":{"login":"DavidShaughnessy","id":4706783,"avatar_url":"https://avatars.githubusercontent.com/u/4706783?v=3","gravatar_id":"","url":"https://api.github.com/users/DavidShaughnessy","html_url":"https://github.com/DavidShaughnessy","followers_url":"https://api.github.com/users/DavidShaughnessy/followers","following_url":"https://api.github.com/users/DavidShaughnessy/following{/other_user}","gists_url":"https://api.github.com/users/DavidShaughnessy/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidShaughnessy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidShaughnessy/subscriptions","organizations_url":"https://api.github.com/users/DavidShaughnessy/orgs","repos_url":"https://api.github.com/users/DavidShaughnessy/repos","events_url":"https://api.github.com/users/DavidShaughnessy/events{/privacy}","received_events_url":"https://api.github.com/users/DavidShaughnessy/received_events","type":"User","site_admin":false},"body":"This is a potential fix for the issue.  The issue was being caused by the class btn-group on the hibachiActionCallerDropdown's output. This was doubling up on some of the listing pages create buttons that had dropdowns.  However just removing the extra btn-group would then break other places that were utilizing hibachiActionCallerDropdown.  I added an attribute that could be passed into hibachiActionCallerDropdown and depending the boolean value hibachiActionCallerDropdown would then output html with/without the btn-group class.  I only applied this to product's listing view so that you could see it working.  If you give me the green light with this fix, I'll implement it throughout the rest of the core.","created_at":"2014-12-09T23:41:41Z","updated_at":"2014-12-10T16:29:36Z","closed_at":"2014-12-10T16:29:36Z","merged_at":null,"merge_commit_sha":"c01c8ea30bc41d89d4c939e2ec7bd2249c02dc34","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ten24/Slatwall/pulls/2686/commits","review_comments_url":"https://api.github.com/repos/ten24/Slatwall/pulls/2686/comments","review_comment_url":"https://api.github.com/repos/ten24/Slatwall/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ten24/Slatwall/issues/2686/comments","statuses_url":"https://api.github.com/repos/ten24/Slatwall/statuses/6aed9a3a0f90c284d6df81c5b38f956ac75eaa5e","head":{"label":"ten24:feature-ds-roundedEdgesIssue","ref":"feature-ds-roundedEdgesIssue","sha":"6aed9a3a0f90c284d6df81c5b38f956ac75eaa5e","user":{"login":"ten24","id":615272,"avatar_url":"https://avatars.githubusercontent.com/u/615272?v=3","gravatar_id":"","url":"https://api.github.com/users/ten24","html_url":"https://github.com/ten24","followers_url":"https://api.github.com/users/ten24/followers","following_url":"https://api.github.com/users/ten24/following{/other_user}","gists_url":"https://api.github.com/users/ten24/gists{/gist_id}","starred_url":"https://api.github.com/users/ten24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ten24/subscriptions","organizations_url":"https://api.github.com/users/ten24/orgs","repos_url":"https://api.github.com/users/ten24/repos","events_url":"https://api.github.com/users/ten24/events{/privacy}","received_events_url":"https://api.github.com/users/ten24/received_events","type":"Organization","site_admin":false},"repo":{"id":1483572,"name":"Slatwall","full_name":"ten24/Slatwall","owner":{"login":"ten24","id":615272,"avatar_url":"https://avatars.githubusercontent.com/u/615272?v=3","gravatar_id":"","url":"https://api.github.com/users/ten24","html_url":"https://github.com/ten24","followers_url":"https://api.github.com/users/ten24/followers","following_url":"https://api.github.com/users/ten24/following{/other_user}","gists_url":"https://api.github.com/users/ten24/gists{/gist_id}","starred_url":"https://api.github.com/users/ten24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ten24/subscriptions","organizations_url":"https://api.github.com/users/ten24/orgs","repos_url":"https://api.github.com/users/ten24/repos","events_url":"https://api.github.com/users/ten24/events{/privacy}","received_events_url":"https://api.github.com/users/ten24/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ten24/Slatwall","description":"Slatwall - An Open Source Commerce Platform","fork":false,"url":"https://api.github.com/repos/ten24/Slatwall","forks_url":"https://api.github.com/repos/ten24/Slatwall/forks","keys_url":"https://api.github.com/repos/ten24/Slatwall/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ten24/Slatwall/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ten24/Slatwall/teams","hooks_url":"https://api.github.com/repos/ten24/Slatwall/hooks","issue_events_url":"https://api.github.com/repos/ten24/Slatwall/issues/events{/number}","events_url":"https://api.github.com/repos/ten24/Slatwall/events","assignees_url":"https://api.github.com/repos/ten24/Slatwall/assignees{/user}","branches_url":"https://api.github.com/repos/ten24/Slatwall/branches{/branch}","tags_url":"https://api.github.com/repos/ten24/Slatwall/tags","blobs_url":"https://api.github.com/repos/ten24/Slatwall/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ten24/Slatwall/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ten24/Slatwall/git/refs{/sha}","trees_url":"https://api.github.com/repos/ten24/Slatwall/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ten24/Slatwall/statuses/{sha}","languages_url":"https://api.github.com/repos/ten24/Slatwall/languages","stargazers_url":"https://api.github.com/repos/ten24/Slatwall/stargazers","contributors_url":"https://api.github.com/repos/ten24/Slatwall/contributors","subscribers_url":"https://api.github.com/repos/ten24/Slatwall/subscribers","subscription_url":"https://api.github.com/repos/ten24/Slatwall/subscription","commits_url":"https://api.github.com/repos/ten24/Slatwall/commits{/sha}","git_commits_url":"https://api.github.com/repos/ten24/Slatwall/git/commits{/sha}","comments_url":"https://api.github.com/repos/ten24/Slatwall/comments{/number}","issue_comment_url":"https://api.github.com/repos/ten24/Slatwall/issues/comments/{number}","contents_url":"https://api.github.com/repos/ten24/Slatwall/contents/{+path}","compare_url":"https://api.github.com/repos/ten24/Slatwall/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ten24/Slatwall/merges","archive_url":"https://api.github.com/repos/ten24/Slatwall/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ten24/Slatwall/downloads","issues_url":"https://api.github.com/repos/ten24/Slatwall/issues{/number}","pulls_url":"https://api.github.com/repos/ten24/Slatwall/pulls{/number}","milestones_url":"https://api.github.com/repos/ten24/Slatwall/milestones{/number}","notifications_url":"https://api.github.com/repos/ten24/Slatwall/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ten24/Slatwall/labels{/name}","releases_url":"https://api.github.com/repos/ten24/Slatwall/releases{/id}","created_at":"2011-03-15T16:58:28Z","updated_at":"2014-12-09T23:32:07Z","pushed_at":"2014-12-10T16:24:24Z","git_url":"git://github.com/ten24/Slatwall.git","ssh_url":"git@github.com:ten24/Slatwall.git","clone_url":"https://github.com/ten24/Slatwall.git","svn_url":"https://github.com/ten24/Slatwall","homepage":"http://www.getslatwall.com","size":59251,"stargazers_count":93,"watchers_count":93,"language":"ColdFusion","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":58,"mirror_url":null,"open_issues_count":274,"forks":58,"open_issues":274,"watchers":93,"default_branch":"master"}},"base":{"label":"ten24:feature","ref":"feature","sha":"0d5ede34756109c4ded5c24b679d7d98db0bff0a","user":{"login":"ten24","id":615272,"avatar_url":"https://avatars.githubusercontent.com/u/615272?v=3","gravatar_id":"","url":"https://api.github.com/users/ten24","html_url":"https://github.com/ten24","followers_url":"https://api.github.com/users/ten24/followers","following_url":"https://api.github.com/users/ten24/following{/other_user}","gists_url":"https://api.github.com/users/ten24/gists{/gist_id}","starred_url":"https://api.github.com/users/ten24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ten24/subscriptions","organizations_url":"https://api.github.com/users/ten24/orgs","repos_url":"https://api.github.com/users/ten24/repos","events_url":"https://api.github.com/users/ten24/events{/privacy}","received_events_url":"https://api.github.com/users/ten24/received_events","type":"Organization","site_admin":false},"repo":{"id":1483572,"name":"Slatwall","full_name":"ten24/Slatwall","owner":{"login":"ten24","id":615272,"avatar_url":"https://avatars.githubusercontent.com/u/615272?v=3","gravatar_id":"","url":"https://api.github.com/users/ten24","html_url":"https://github.com/ten24","followers_url":"https://api.github.com/users/ten24/followers","following_url":"https://api.github.com/users/ten24/following{/other_user}","gists_url":"https://api.github.com/users/ten24/gists{/gist_id}","starred_url":"https://api.github.com/users/ten24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ten24/subscriptions","organizations_url":"https://api.github.com/users/ten24/orgs","repos_url":"https://api.github.com/users/ten24/repos","events_url":"https://api.github.com/users/ten24/events{/privacy}","received_events_url":"https://api.github.com/users/ten24/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ten24/Slatwall","description":"Slatwall - An Open Source Commerce Platform","fork":false,"url":"https://api.github.com/repos/ten24/Slatwall","forks_url":"https://api.github.com/repos/ten24/Slatwall/forks","keys_url":"https://api.github.com/repos/ten24/Slatwall/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ten24/Slatwall/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ten24/Slatwall/teams","hooks_url":"https://api.github.com/repos/ten24/Slatwall/hooks","issue_events_url":"https://api.github.com/repos/ten24/Slatwall/issues/events{/number}","events_url":"https://api.github.com/repos/ten24/Slatwall/events","assignees_url":"https://api.github.com/repos/ten24/Slatwall/assignees{/user}","branches_url":"https://api.github.com/repos/ten24/Slatwall/branches{/branch}","tags_url":"https://api.github.com/repos/ten24/Slatwall/tags","blobs_url":"https://api.github.com/repos/ten24/Slatwall/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ten24/Slatwall/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ten24/Slatwall/git/refs{/sha}","trees_url":"https://api.github.com/repos/ten24/Slatwall/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ten24/Slatwall/statuses/{sha}","languages_url":"https://api.github.com/repos/ten24/Slatwall/languages","stargazers_url":"https://api.github.com/repos/ten24/Slatwall/stargazers","contributors_url":"https://api.github.com/repos/ten24/Slatwall/contributors","subscribers_url":"https://api.github.com/repos/ten24/Slatwall/subscribers","subscription_url":"https://api.github.com/repos/ten24/Slatwall/subscription","commits_url":"https://api.github.com/repos/ten24/Slatwall/commits{/sha}","git_commits_url":"https://api.github.com/repos/ten24/Slatwall/git/commits{/sha}","comments_url":"https://api.github.com/repos/ten24/Slatwall/comments{/number}","issue_comment_url":"https://api.github.com/repos/ten24/Slatwall/issues/comments/{number}","contents_url":"https://api.github.com/repos/ten24/Slatwall/contents/{+path}","compare_url":"https://api.github.com/repos/ten24/Slatwall/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ten24/Slatwall/merges","archive_url":"https://api.github.com/repos/ten24/Slatwall/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ten24/Slatwall/downloads","issues_url":"https://api.github.com/repos/ten24/Slatwall/issues{/number}","pulls_url":"https://api.github.com/repos/ten24/Slatwall/pulls{/number}","milestones_url":"https://api.github.com/repos/ten24/Slatwall/milestones{/number}","notifications_url":"https://api.github.com/repos/ten24/Slatwall/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ten24/Slatwall/labels{/name}","releases_url":"https://api.github.com/repos/ten24/Slatwall/releases{/id}","created_at":"2011-03-15T16:58:28Z","updated_at":"2014-12-09T23:32:07Z","pushed_at":"2014-12-10T16:24:24Z","git_url":"git://github.com/ten24/Slatwall.git","ssh_url":"git@github.com:ten24/Slatwall.git","clone_url":"https://github.com/ten24/Slatwall.git","svn_url":"https://github.com/ten24/Slatwall","homepage":"http://www.getslatwall.com","size":59251,"stargazers_count":93,"watchers_count":93,"language":"ColdFusion","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":58,"mirror_url":null,"open_issues_count":274,"forks":58,"open_issues":274,"watchers":93,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ten24/Slatwall/pulls/2686"},"html":{"href":"https://github.com/ten24/Slatwall/pull/2686"},"issue":{"href":"https://api.github.com/repos/ten24/Slatwall/issues/2686"},"comments":{"href":"https://api.github.com/repos/ten24/Slatwall/issues/2686/comments"},"review_comments":{"href":"https://api.github.com/repos/ten24/Slatwall/pulls/2686/comments"},"review_comment":{"href":"https://api.github.com/repos/ten24/Slatwall/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ten24/Slatwall/pulls/2686/commits"},"statuses":{"href":"https://api.github.com/repos/ten24/Slatwall/statuses/6aed9a3a0f90c284d6df81c5b38f956ac75eaa5e"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":13,"deletions":2,"changed_files":2}}