GitHub PullRequestEvent at 2014-01-07 18:01:47
Repository: bleno
Actor: FredericRuaudel
Payload: {"action":"opened","number":10,"pull_request":{"url":"https://api.github.com/repos/sandeepmistry/bleno/pulls/10","id":11293853,"html_url":"https://github.com/sandeepmistry/bleno/pull/10","diff_url":"https://github.com/sandeepmistry/bleno/pull/10.diff","patch_url":"https://github.com/sandeepmistry/bleno/pull/10.patch","issue_url":"https://github.com/sandeepmistry/bleno/pull/10","number":10,"state":"open","title":"Enhance the advertisement data","user":{"login":"FredericRuaudel","id":3808140,"avatar_url":"https://gravatar.com/avatar/ec8e3ada6a54027d7503ce97a7974eec?d=https%3A%2F%2Fidenticons.github.com%2Fa7779f9db47906ab607386d349cffbeb.png&r=x","gravatar_id":"ec8e3ada6a54027d7503ce97a7974eec","url":"https://api.github.com/users/FredericRuaudel","html_url":"https://github.com/FredericRuaudel","followers_url":"https://api.github.com/users/FredericRuaudel/followers","following_url":"https://api.github.com/users/FredericRuaudel/following{/other_user}","gists_url":"https://api.github.com/users/FredericRuaudel/gists{/gist_id}","starred_url":"https://api.github.com/users/FredericRuaudel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FredericRuaudel/subscriptions","organizations_url":"https://api.github.com/users/FredericRuaudel/orgs","repos_url":"https://api.github.com/users/FredericRuaudel/repos","events_url":"https://api.github.com/users/FredericRuaudel/events{/privacy}","received_events_url":"https://api.github.com/users/FredericRuaudel/received_events","type":"User","site_admin":false},"body":"Hi Sandeep,\r\n\r\n    Here is my last proposition. \r\n\r\nWhen scanning a bleno peripheral using some app like lightBlue on iOS, the description of my peripheral wasn't complete. It didn't display the localName and the advertised services. In my iOS code, I also wasn't able to scan for my advertised services using CoreBluetooth API. \r\n\r\nSo I try to add the local name and service UUIDs to the advertisement data in addition with in the scan response data and it make all works like a charm.\r\n\r\nI also add some comment to clarify the flags ;)\r\n\r\nRegards,\r\n\r\nFred","created_at":"2014-01-07T18:01:46Z","updated_at":"2014-01-07T18:01:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://github.com/sandeepmistry/bleno/pull/10/commits","review_comments_url":"https://github.com/sandeepmistry/bleno/pull/10/comments","review_comment_url":"/repos/sandeepmistry/bleno/pulls/comments/{number}","comments_url":"https://api.github.com/repos/sandeepmistry/bleno/issues/10/comments","statuses_url":"https://api.github.com/repos/sandeepmistry/bleno/statuses/0420c11be7cb55d4547477d3d77cdcf6fe7f984d","head":{"label":"FredericRuaudel:EnhanceAdvertisingData","ref":"EnhanceAdvertisingData","sha":"0420c11be7cb55d4547477d3d77cdcf6fe7f984d","user":{"login":"FredericRuaudel","id":3808140,"avatar_url":"https://gravatar.com/avatar/ec8e3ada6a54027d7503ce97a7974eec?d=https%3A%2F%2Fidenticons.github.com%2Fa7779f9db47906ab607386d349cffbeb.png&r=x","gravatar_id":"ec8e3ada6a54027d7503ce97a7974eec","url":"https://api.github.com/users/FredericRuaudel","html_url":"https://github.com/FredericRuaudel","followers_url":"https://api.github.com/users/FredericRuaudel/followers","following_url":"https://api.github.com/users/FredericRuaudel/following{/other_user}","gists_url":"https://api.github.com/users/FredericRuaudel/gists{/gist_id}","starred_url":"https://api.github.com/users/FredericRuaudel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FredericRuaudel/subscriptions","organizations_url":"https://api.github.com/users/FredericRuaudel/orgs","repos_url":"https://api.github.com/users/FredericRuaudel/repos","events_url":"https://api.github.com/users/FredericRuaudel/events{/privacy}","received_events_url":"https://api.github.com/users/FredericRuaudel/received_events","type":"User","site_admin":false},"repo":{"id":15167294,"name":"bleno","full_name":"FredericRuaudel/bleno","owner":{"login":"FredericRuaudel","id":3808140,"avatar_url":"https://gravatar.com/avatar/ec8e3ada6a54027d7503ce97a7974eec?d=https%3A%2F%2Fidenticons.github.com%2Fa7779f9db47906ab607386d349cffbeb.png&r=x","gravatar_id":"ec8e3ada6a54027d7503ce97a7974eec","url":"https://api.github.com/users/FredericRuaudel","html_url":"https://github.com/FredericRuaudel","followers_url":"https://api.github.com/users/FredericRuaudel/followers","following_url":"https://api.github.com/users/FredericRuaudel/following{/other_user}","gists_url":"https://api.github.com/users/FredericRuaudel/gists{/gist_id}","starred_url":"https://api.github.com/users/FredericRuaudel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FredericRuaudel/subscriptions","organizations_url":"https://api.github.com/users/FredericRuaudel/orgs","repos_url":"https://api.github.com/users/FredericRuaudel/repos","events_url":"https://api.github.com/users/FredericRuaudel/events{/privacy}","received_events_url":"https://api.github.com/users/FredericRuaudel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/FredericRuaudel/bleno","description":"A node.js module for implementing BLE (Bluetooth low energy) peripherals","fork":true,"url":"https://api.github.com/repos/FredericRuaudel/bleno","forks_url":"https://api.github.com/repos/FredericRuaudel/bleno/forks","keys_url":"https://api.github.com/repos/FredericRuaudel/bleno/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FredericRuaudel/bleno/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FredericRuaudel/bleno/teams","hooks_url":"https://api.github.com/repos/FredericRuaudel/bleno/hooks","issue_events_url":"https://api.github.com/repos/FredericRuaudel/bleno/issues/events{/number}","events_url":"https://api.github.com/repos/FredericRuaudel/bleno/events","assignees_url":"https://api.github.com/repos/FredericRuaudel/bleno/assignees{/user}","branches_url":"https://api.github.com/repos/FredericRuaudel/bleno/branches{/branch}","tags_url":"https://api.github.com/repos/FredericRuaudel/bleno/tags","blobs_url":"https://api.github.com/repos/FredericRuaudel/bleno/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FredericRuaudel/bleno/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FredericRuaudel/bleno/git/refs{/sha}","trees_url":"https://api.github.com/repos/FredericRuaudel/bleno/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FredericRuaudel/bleno/statuses/{sha}","languages_url":"https://api.github.com/repos/FredericRuaudel/bleno/languages","stargazers_url":"https://api.github.com/repos/FredericRuaudel/bleno/stargazers","contributors_url":"https://api.github.com/repos/FredericRuaudel/bleno/contributors","subscribers_url":"https://api.github.com/repos/FredericRuaudel/bleno/subscribers","subscription_url":"https://api.github.com/repos/FredericRuaudel/bleno/subscription","commits_url":"https://api.github.com/repos/FredericRuaudel/bleno/commits{/sha}","git_commits_url":"https://api.github.com/repos/FredericRuaudel/bleno/git/commits{/sha}","comments_url":"https://api.github.com/repos/FredericRuaudel/bleno/comments{/number}","issue_comment_url":"https://api.github.com/repos/FredericRuaudel/bleno/issues/comments/{number}","contents_url":"https://api.github.com/repos/FredericRuaudel/bleno/contents/{+path}","compare_url":"https://api.github.com/repos/FredericRuaudel/bleno/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FredericRuaudel/bleno/merges","archive_url":"https://api.github.com/repos/FredericRuaudel/bleno/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FredericRuaudel/bleno/downloads","issues_url":"https://api.github.com/repos/FredericRuaudel/bleno/issues{/number}","pulls_url":"https://api.github.com/repos/FredericRuaudel/bleno/pulls{/number}","milestones_url":"https://api.github.com/repos/FredericRuaudel/bleno/milestones{/number}","notifications_url":"https://api.github.com/repos/FredericRuaudel/bleno/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FredericRuaudel/bleno/labels{/name}","releases_url":"https://api.github.com/repos/FredericRuaudel/bleno/releases{/id}","created_at":"2013-12-13T15:42:18Z","updated_at":"2014-01-07T18:01:46Z","pushed_at":"2014-01-07T17:55:23Z","git_url":"git://github.com/FredericRuaudel/bleno.git","ssh_url":"git@github.com:FredericRuaudel/bleno.git","clone_url":"https://github.com/FredericRuaudel/bleno.git","svn_url":"https://github.com/FredericRuaudel/bleno","homepage":"","size":158,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"sandeepmistry:master","ref":"master","sha":"aad9fc14da8f86b26ac75a04a114567fac3eb72d","user":{"login":"sandeepmistry","id":1163840,"avatar_url":"https://gravatar.com/avatar/68ad31880a3e9b72d50a6240347e48dc?d=https%3A%2F%2Fidenticons.github.com%2Faf6fa9af3bac25aa8665a825f4000434.png&r=x","gravatar_id":"68ad31880a3e9b72d50a6240347e48dc","url":"https://api.github.com/users/sandeepmistry","html_url":"https://github.com/sandeepmistry","followers_url":"https://api.github.com/users/sandeepmistry/followers","following_url":"https://api.github.com/users/sandeepmistry/following{/other_user}","gists_url":"https://api.github.com/users/sandeepmistry/gists{/gist_id}","starred_url":"https://api.github.com/users/sandeepmistry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandeepmistry/subscriptions","organizations_url":"https://api.github.com/users/sandeepmistry/orgs","repos_url":"https://api.github.com/users/sandeepmistry/repos","events_url":"https://api.github.com/users/sandeepmistry/events{/privacy}","received_events_url":"https://api.github.com/users/sandeepmistry/received_events","type":"User","site_admin":false},"repo":{"id":13964535,"name":"bleno","full_name":"sandeepmistry/bleno","owner":{"login":"sandeepmistry","id":1163840,"avatar_url":"https://gravatar.com/avatar/68ad31880a3e9b72d50a6240347e48dc?d=https%3A%2F%2Fidenticons.github.com%2Faf6fa9af3bac25aa8665a825f4000434.png&r=x","gravatar_id":"68ad31880a3e9b72d50a6240347e48dc","url":"https://api.github.com/users/sandeepmistry","html_url":"https://github.com/sandeepmistry","followers_url":"https://api.github.com/users/sandeepmistry/followers","following_url":"https://api.github.com/users/sandeepmistry/following{/other_user}","gists_url":"https://api.github.com/users/sandeepmistry/gists{/gist_id}","starred_url":"https://api.github.com/users/sandeepmistry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandeepmistry/subscriptions","organizations_url":"https://api.github.com/users/sandeepmistry/orgs","repos_url":"https://api.github.com/users/sandeepmistry/repos","events_url":"https://api.github.com/users/sandeepmistry/events{/privacy}","received_events_url":"https://api.github.com/users/sandeepmistry/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sandeepmistry/bleno","description":"A node.js module for implementing BLE (Bluetooth low energy) peripherals","fork":false,"url":"https://api.github.com/repos/sandeepmistry/bleno","forks_url":"https://api.github.com/repos/sandeepmistry/bleno/forks","keys_url":"https://api.github.com/repos/sandeepmistry/bleno/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sandeepmistry/bleno/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sandeepmistry/bleno/teams","hooks_url":"https://api.github.com/repos/sandeepmistry/bleno/hooks","issue_events_url":"https://api.github.com/repos/sandeepmistry/bleno/issues/events{/number}","events_url":"https://api.github.com/repos/sandeepmistry/bleno/events","assignees_url":"https://api.github.com/repos/sandeepmistry/bleno/assignees{/user}","branches_url":"https://api.github.com/repos/sandeepmistry/bleno/branches{/branch}","tags_url":"https://api.github.com/repos/sandeepmistry/bleno/tags","blobs_url":"https://api.github.com/repos/sandeepmistry/bleno/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sandeepmistry/bleno/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sandeepmistry/bleno/git/refs{/sha}","trees_url":"https://api.github.com/repos/sandeepmistry/bleno/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sandeepmistry/bleno/statuses/{sha}","languages_url":"https://api.github.com/repos/sandeepmistry/bleno/languages","stargazers_url":"https://api.github.com/repos/sandeepmistry/bleno/stargazers","contributors_url":"https://api.github.com/repos/sandeepmistry/bleno/contributors","subscribers_url":"https://api.github.com/repos/sandeepmistry/bleno/subscribers","subscription_url":"https://api.github.com/repos/sandeepmistry/bleno/subscription","commits_url":"https://api.github.com/repos/sandeepmistry/bleno/commits{/sha}","git_commits_url":"https://api.github.com/repos/sandeepmistry/bleno/git/commits{/sha}","comments_url":"https://api.github.com/repos/sandeepmistry/bleno/comments{/number}","issue_comment_url":"https://api.github.com/repos/sandeepmistry/bleno/issues/comments/{number}","contents_url":"https://api.github.com/repos/sandeepmistry/bleno/contents/{+path}","compare_url":"https://api.github.com/repos/sandeepmistry/bleno/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sandeepmistry/bleno/merges","archive_url":"https://api.github.com/repos/sandeepmistry/bleno/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sandeepmistry/bleno/downloads","issues_url":"https://api.github.com/repos/sandeepmistry/bleno/issues{/number}","pulls_url":"https://api.github.com/repos/sandeepmistry/bleno/pulls{/number}","milestones_url":"https://api.github.com/repos/sandeepmistry/bleno/milestones{/number}","notifications_url":"https://api.github.com/repos/sandeepmistry/bleno/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sandeepmistry/bleno/labels{/name}","releases_url":"https://api.github.com/repos/sandeepmistry/bleno/releases{/id}","created_at":"2013-10-29T18:22:06Z","updated_at":"2014-01-06T09:47:12Z","pushed_at":"2014-01-02T16:56:46Z","git_url":"git://github.com/sandeepmistry/bleno.git","ssh_url":"git@github.com:sandeepmistry/bleno.git","clone_url":"https://github.com/sandeepmistry/bleno.git","svn_url":"https://github.com/sandeepmistry/bleno","homepage":"","size":355,"stargazers_count":40,"watchers_count":40,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":7,"mirror_url":null,"open_issues_count":4,"forks":7,"open_issues":4,"watchers":40,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sandeepmistry/bleno/pulls/10"},"html":{"href":"https://github.com/sandeepmistry/bleno/pull/10"},"issue":{"href":"https://api.github.com/repos/sandeepmistry/bleno/issues/10"},"comments":{"href":"https://api.github.com/repos/sandeepmistry/bleno/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/sandeepmistry/bleno/pulls/10/comments"},"statuses":{"href":"https://api.github.com/repos/sandeepmistry/bleno/statuses/0420c11be7cb55d4547477d3d77cdcf6fe7f984d"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":5,"deletions":3,"changed_files":1}}