GitHub PullRequestReviewCommentEvent at 2014-09-27 14:37:41
Repository: dyn-js
Actor: elopezanaya
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/dyninc/dyn-js/pulls/comments/18123920","id":18123920,"diff_hunk":"@@ -361,7 +364,7 @@ Dyn = (opts) ->\n   messaging.senders.create            = (email, seeding) -> callWithError messaging.senders._create._call(messaging, {}, _.defaults({emailaddress:email,seeding:seeding||'0'}, {apikey:messaging.defaults.apikey})), \"senders.create\", msgIsOk, extractMsgData, throwMsgMessages\n   messaging.senders.update            = (email, seeding) -> callWithError messaging.senders._update._call(messaging, {}, _.defaults({emailaddress:email}, {apikey:messaging.defaults.apikey})), \"senders.update\", msgIsOk, extractMsgData, throwMsgMessages\n   messaging.senders.details           = (email)          -> callWithError messaging.senders._details._call(messaging, {}, _.defaults({emailaddress:email}, {apikey:messaging.defaults.apikey})), \"senders.details\", msgIsOk, extractMsgData, throwMsgMessages\n-  messaging.senders.status            = (email)          -> callWithError messaging.senders._status._call(messaging, {}, _.defaults({emailaddress:email}, {apikey:messaging.defaults.apikey})), \"senders.status\", msgIsOk, extractMsgData, throwMsgMessages\n+  messaging.senders.status            = (email)          -> callWithError messaging.senders._status._call(messaging, {}, _.defaults({emailaddress:email}, {apikey:messaging.defaults.apikey})), \"senders.status\", msgIsOk, extractMsgData, throwResponse","path":"src/dyn-js.coffee","position":33,"original_position":33,"commit_id":"c9f9ad1aa222da2482a595ee5165938f5aaeca0a","original_commit_id":"c9f9ad1aa222da2482a595ee5165938f5aaeca0a","user":{"login":"elopezanaya","id":981914,"avatar_url":"https://avatars.githubusercontent.com/u/981914?v=2","gravatar_id":"","url":"https://api.github.com/users/elopezanaya","html_url":"https://github.com/elopezanaya","followers_url":"https://api.github.com/users/elopezanaya/followers","following_url":"https://api.github.com/users/elopezanaya/following{/other_user}","gists_url":"https://api.github.com/users/elopezanaya/gists{/gist_id}","starred_url":"https://api.github.com/users/elopezanaya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elopezanaya/subscriptions","organizations_url":"https://api.github.com/users/elopezanaya/orgs","repos_url":"https://api.github.com/users/elopezanaya/repos","events_url":"https://api.github.com/users/elopezanaya/events{/privacy}","received_events_url":"https://api.github.com/users/elopezanaya/received_events","type":"User","site_admin":false},"body":"change of throwMessage to throwResponse, now it doesn't matter the result, the client always recive the response as result of the call","created_at":"2014-09-27T14:37:41Z","updated_at":"2014-09-27T14:37:41Z","html_url":"https://github.com/dyninc/dyn-js/pull/4#discussion_r18123920","pull_request_url":"https://api.github.com/repos/dyninc/dyn-js/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/dyninc/dyn-js/pulls/comments/18123920"},"html":{"href":"https://github.com/dyninc/dyn-js/pull/4#discussion_r18123920"},"pull_request":{"href":"https://api.github.com/repos/dyninc/dyn-js/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/dyninc/dyn-js/pulls/4","id":21889956,"html_url":"https://github.com/dyninc/dyn-js/pull/4","diff_url":"https://github.com/dyninc/dyn-js/pull/4.diff","patch_url":"https://github.com/dyninc/dyn-js/pull/4.patch","issue_url":"https://api.github.com/repos/dyninc/dyn-js/issues/4","number":4,"state":"open","locked":false,"title":"change to use return instead throw","user":{"login":"elopezanaya","id":981914,"avatar_url":"https://avatars.githubusercontent.com/u/981914?v=2","gravatar_id":"","url":"https://api.github.com/users/elopezanaya","html_url":"https://github.com/elopezanaya","followers_url":"https://api.github.com/users/elopezanaya/followers","following_url":"https://api.github.com/users/elopezanaya/following{/other_user}","gists_url":"https://api.github.com/users/elopezanaya/gists{/gist_id}","starred_url":"https://api.github.com/users/elopezanaya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elopezanaya/subscriptions","organizations_url":"https://api.github.com/users/elopezanaya/orgs","repos_url":"https://api.github.com/users/elopezanaya/repos","events_url":"https://api.github.com/users/elopezanaya/events{/privacy}","received_events_url":"https://api.github.com/users/elopezanaya/received_events","type":"User","site_admin":false},"body":"for sender.status operation I'm changing the error case , instead of throw an exception I'm returning the error response.\r\n\r\nthis solve the problem that when the sender.status call return  false , the response is never reached by the client that made the call, because the exception is never caught..","created_at":"2014-09-27T14:32:49Z","updated_at":"2014-09-27T14:37:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"70684ad6224776feae7ef39443b52fe5f42eaf08","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dyninc/dyn-js/pulls/4/commits","review_comments_url":"https://api.github.com/repos/dyninc/dyn-js/pulls/4/comments","review_comment_url":"https://api.github.com/repos/dyninc/dyn-js/pulls/comments/{number}","comments_url":"https://api.github.com/repos/dyninc/dyn-js/issues/4/comments","statuses_url":"https://api.github.com/repos/dyninc/dyn-js/statuses/c9f9ad1aa222da2482a595ee5165938f5aaeca0a","head":{"label":"elopezanaya:master","ref":"master","sha":"c9f9ad1aa222da2482a595ee5165938f5aaeca0a","user":{"login":"elopezanaya","id":981914,"avatar_url":"https://avatars.githubusercontent.com/u/981914?v=2","gravatar_id":"","url":"https://api.github.com/users/elopezanaya","html_url":"https://github.com/elopezanaya","followers_url":"https://api.github.com/users/elopezanaya/followers","following_url":"https://api.github.com/users/elopezanaya/following{/other_user}","gists_url":"https://api.github.com/users/elopezanaya/gists{/gist_id}","starred_url":"https://api.github.com/users/elopezanaya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elopezanaya/subscriptions","organizations_url":"https://api.github.com/users/elopezanaya/orgs","repos_url":"https://api.github.com/users/elopezanaya/repos","events_url":"https://api.github.com/users/elopezanaya/events{/privacy}","received_events_url":"https://api.github.com/users/elopezanaya/received_events","type":"User","site_admin":false},"repo":{"id":24521809,"name":"dyn-js","full_name":"elopezanaya/dyn-js","owner":{"login":"elopezanaya","id":981914,"avatar_url":"https://avatars.githubusercontent.com/u/981914?v=2","gravatar_id":"","url":"https://api.github.com/users/elopezanaya","html_url":"https://github.com/elopezanaya","followers_url":"https://api.github.com/users/elopezanaya/followers","following_url":"https://api.github.com/users/elopezanaya/following{/other_user}","gists_url":"https://api.github.com/users/elopezanaya/gists{/gist_id}","starred_url":"https://api.github.com/users/elopezanaya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elopezanaya/subscriptions","organizations_url":"https://api.github.com/users/elopezanaya/orgs","repos_url":"https://api.github.com/users/elopezanaya/repos","events_url":"https://api.github.com/users/elopezanaya/events{/privacy}","received_events_url":"https://api.github.com/users/elopezanaya/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/elopezanaya/dyn-js","description":"Dyn SDK for Node.JS","fork":true,"url":"https://api.github.com/repos/elopezanaya/dyn-js","forks_url":"https://api.github.com/repos/elopezanaya/dyn-js/forks","keys_url":"https://api.github.com/repos/elopezanaya/dyn-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elopezanaya/dyn-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elopezanaya/dyn-js/teams","hooks_url":"https://api.github.com/repos/elopezanaya/dyn-js/hooks","issue_events_url":"https://api.github.com/repos/elopezanaya/dyn-js/issues/events{/number}","events_url":"https://api.github.com/repos/elopezanaya/dyn-js/events","assignees_url":"https://api.github.com/repos/elopezanaya/dyn-js/assignees{/user}","branches_url":"https://api.github.com/repos/elopezanaya/dyn-js/branches{/branch}","tags_url":"https://api.github.com/repos/elopezanaya/dyn-js/tags","blobs_url":"https://api.github.com/repos/elopezanaya/dyn-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elopezanaya/dyn-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elopezanaya/dyn-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/elopezanaya/dyn-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elopezanaya/dyn-js/statuses/{sha}","languages_url":"https://api.github.com/repos/elopezanaya/dyn-js/languages","stargazers_url":"https://api.github.com/repos/elopezanaya/dyn-js/stargazers","contributors_url":"https://api.github.com/repos/elopezanaya/dyn-js/contributors","subscribers_url":"https://api.github.com/repos/elopezanaya/dyn-js/subscribers","subscription_url":"https://api.github.com/repos/elopezanaya/dyn-js/subscription","commits_url":"https://api.github.com/repos/elopezanaya/dyn-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/elopezanaya/dyn-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/elopezanaya/dyn-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/elopezanaya/dyn-js/issues/comments/{number}","contents_url":"https://api.github.com/repos/elopezanaya/dyn-js/contents/{+path}","compare_url":"https://api.github.com/repos/elopezanaya/dyn-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elopezanaya/dyn-js/merges","archive_url":"https://api.github.com/repos/elopezanaya/dyn-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elopezanaya/dyn-js/downloads","issues_url":"https://api.github.com/repos/elopezanaya/dyn-js/issues{/number}","pulls_url":"https://api.github.com/repos/elopezanaya/dyn-js/pulls{/number}","milestones_url":"https://api.github.com/repos/elopezanaya/dyn-js/milestones{/number}","notifications_url":"https://api.github.com/repos/elopezanaya/dyn-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elopezanaya/dyn-js/labels{/name}","releases_url":"https://api.github.com/repos/elopezanaya/dyn-js/releases{/id}","created_at":"2014-09-27T02:46:17Z","updated_at":"2014-09-27T03:43:11Z","pushed_at":"2014-09-27T03:32:02Z","git_url":"git://github.com/elopezanaya/dyn-js.git","ssh_url":"git@github.com:elopezanaya/dyn-js.git","clone_url":"https://github.com/elopezanaya/dyn-js.git","svn_url":"https://github.com/elopezanaya/dyn-js","homepage":null,"size":142,"stargazers_count":1,"watchers_count":1,"language":"CoffeeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"dyninc:master","ref":"master","sha":"f5460e0e7cd066f0809afef2b156054f4dbfd313","user":{"login":"dyninc","id":1084880,"avatar_url":"https://avatars.githubusercontent.com/u/1084880?v=2","gravatar_id":"","url":"https://api.github.com/users/dyninc","html_url":"https://github.com/dyninc","followers_url":"https://api.github.com/users/dyninc/followers","following_url":"https://api.github.com/users/dyninc/following{/other_user}","gists_url":"https://api.github.com/users/dyninc/gists{/gist_id}","starred_url":"https://api.github.com/users/dyninc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dyninc/subscriptions","organizations_url":"https://api.github.com/users/dyninc/orgs","repos_url":"https://api.github.com/users/dyninc/repos","events_url":"https://api.github.com/users/dyninc/events{/privacy}","received_events_url":"https://api.github.com/users/dyninc/received_events","type":"Organization","site_admin":false},"repo":{"id":17936308,"name":"dyn-js","full_name":"dyninc/dyn-js","owner":{"login":"dyninc","id":1084880,"avatar_url":"https://avatars.githubusercontent.com/u/1084880?v=2","gravatar_id":"","url":"https://api.github.com/users/dyninc","html_url":"https://github.com/dyninc","followers_url":"https://api.github.com/users/dyninc/followers","following_url":"https://api.github.com/users/dyninc/following{/other_user}","gists_url":"https://api.github.com/users/dyninc/gists{/gist_id}","starred_url":"https://api.github.com/users/dyninc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dyninc/subscriptions","organizations_url":"https://api.github.com/users/dyninc/orgs","repos_url":"https://api.github.com/users/dyninc/repos","events_url":"https://api.github.com/users/dyninc/events{/privacy}","received_events_url":"https://api.github.com/users/dyninc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dyninc/dyn-js","description":"Dyn SDK for Node.JS","fork":false,"url":"https://api.github.com/repos/dyninc/dyn-js","forks_url":"https://api.github.com/repos/dyninc/dyn-js/forks","keys_url":"https://api.github.com/repos/dyninc/dyn-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dyninc/dyn-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dyninc/dyn-js/teams","hooks_url":"https://api.github.com/repos/dyninc/dyn-js/hooks","issue_events_url":"https://api.github.com/repos/dyninc/dyn-js/issues/events{/number}","events_url":"https://api.github.com/repos/dyninc/dyn-js/events","assignees_url":"https://api.github.com/repos/dyninc/dyn-js/assignees{/user}","branches_url":"https://api.github.com/repos/dyninc/dyn-js/branches{/branch}","tags_url":"https://api.github.com/repos/dyninc/dyn-js/tags","blobs_url":"https://api.github.com/repos/dyninc/dyn-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dyninc/dyn-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dyninc/dyn-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/dyninc/dyn-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dyninc/dyn-js/statuses/{sha}","languages_url":"https://api.github.com/repos/dyninc/dyn-js/languages","stargazers_url":"https://api.github.com/repos/dyninc/dyn-js/stargazers","contributors_url":"https://api.github.com/repos/dyninc/dyn-js/contributors","subscribers_url":"https://api.github.com/repos/dyninc/dyn-js/subscribers","subscription_url":"https://api.github.com/repos/dyninc/dyn-js/subscription","commits_url":"https://api.github.com/repos/dyninc/dyn-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/dyninc/dyn-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/dyninc/dyn-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/dyninc/dyn-js/issues/comments/{number}","contents_url":"https://api.github.com/repos/dyninc/dyn-js/contents/{+path}","compare_url":"https://api.github.com/repos/dyninc/dyn-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dyninc/dyn-js/merges","archive_url":"https://api.github.com/repos/dyninc/dyn-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dyninc/dyn-js/downloads","issues_url":"https://api.github.com/repos/dyninc/dyn-js/issues{/number}","pulls_url":"https://api.github.com/repos/dyninc/dyn-js/pulls{/number}","milestones_url":"https://api.github.com/repos/dyninc/dyn-js/milestones{/number}","notifications_url":"https://api.github.com/repos/dyninc/dyn-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dyninc/dyn-js/labels{/name}","releases_url":"https://api.github.com/repos/dyninc/dyn-js/releases{/id}","created_at":"2014-03-20T09:03:16Z","updated_at":"2014-07-14T14:03:29Z","pushed_at":"2014-07-16T18:38:56Z","git_url":"git://github.com/dyninc/dyn-js.git","ssh_url":"git@github.com:dyninc/dyn-js.git","clone_url":"https://github.com/dyninc/dyn-js.git","svn_url":"https://github.com/dyninc/dyn-js","homepage":null,"size":337,"stargazers_count":3,"watchers_count":3,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dyninc/dyn-js/pulls/4"},"html":{"href":"https://github.com/dyninc/dyn-js/pull/4"},"issue":{"href":"https://api.github.com/repos/dyninc/dyn-js/issues/4"},"comments":{"href":"https://api.github.com/repos/dyninc/dyn-js/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/dyninc/dyn-js/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/dyninc/dyn-js/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/dyninc/dyn-js/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/dyninc/dyn-js/statuses/c9f9ad1aa222da2482a595ee5165938f5aaeca0a"}}}}