GitHub PullRequestReviewCommentEvent at 2014-10-29 07:43:33
Repository: robottelo
Actor: sghai
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/comments/19523135","id":19523135,"diff_hunk":"@@ -932,12 +933,70 @@ def test_usage_limit(self):\n \n         @Assert: System Registration fails. Appropriate error shown\n \n-        @Status: Manual\n-\n-        @BZ: 1078676\n-\n         \"\"\"\n-        pass\n+        name = gen_string(\"alpha\", 10)\n+        host_limit = \"1\"\n+        with Session(self.browser) as session:\n+            make_activationkey(session, org=self.org_name,\n+                               name=name, env=ENVIRONMENT)\n+            self.assertIsNotNone(self.activationkey.search_key(name))\n+            self.activationkey.update(name, limit=host_limit)\n+            self.assertIsNotNone(self.activationkey.wait_until_element\n+                                 (common_locators[\"alert.success\"]))\n+            server_name = conf.properties['main.server.hostname']","path":"tests/foreman/ui/test_activationkey.py","position":29,"original_position":29,"commit_id":"30e903834e2081b38080940428ba81d5cbfa34cd","original_commit_id":"e75c2e26904228af2672287abf28917d1733f819","user":{"login":"sghai","id":620852,"avatar_url":"https://avatars.githubusercontent.com/u/620852?v=2","gravatar_id":"","url":"https://api.github.com/users/sghai","html_url":"https://github.com/sghai","followers_url":"https://api.github.com/users/sghai/followers","following_url":"https://api.github.com/users/sghai/following{/other_user}","gists_url":"https://api.github.com/users/sghai/gists{/gist_id}","starred_url":"https://api.github.com/users/sghai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sghai/subscriptions","organizations_url":"https://api.github.com/users/sghai/orgs","repos_url":"https://api.github.com/users/sghai/repos","events_url":"https://api.github.com/users/sghai/events{/privacy}","received_events_url":"https://api.github.com/users/sghai/received_events","type":"User","site_admin":false},"body":"Thanks @kbidarkar. I understand what you said in your previous comment. So I just wanted to know whether I should define the server_name in setUp fn or shall I use other class method.. \r\nBut as per IRC comment.. if you want me to test what you've suggested. I'll do that for now..","created_at":"2014-10-29T07:43:33Z","updated_at":"2014-10-29T07:43:33Z","html_url":"https://github.com/SatelliteQE/robottelo/pull/1630#discussion_r19523135","pull_request_url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/1630","_links":{"self":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/comments/19523135"},"html":{"href":"https://github.com/SatelliteQE/robottelo/pull/1630#discussion_r19523135"},"pull_request":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/1630"}}},"pull_request":{"url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/1630","id":23450190,"html_url":"https://github.com/SatelliteQE/robottelo/pull/1630","diff_url":"https://github.com/SatelliteQE/robottelo/pull/1630.diff","patch_url":"https://github.com/SatelliteQE/robottelo/pull/1630.patch","issue_url":"https://api.github.com/repos/SatelliteQE/robottelo/issues/1630","number":1630,"state":"open","locked":false,"title":"Test to check if the activation-key's content-host limit actually limits its usage","user":{"login":"sghai","id":620852,"avatar_url":"https://avatars.githubusercontent.com/u/620852?v=2","gravatar_id":"","url":"https://api.github.com/users/sghai","html_url":"https://github.com/sghai","followers_url":"https://api.github.com/users/sghai/followers","following_url":"https://api.github.com/users/sghai/following{/other_user}","gists_url":"https://api.github.com/users/sghai/gists{/gist_id}","starred_url":"https://api.github.com/users/sghai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sghai/subscriptions","organizations_url":"https://api.github.com/users/sghai/orgs","repos_url":"https://api.github.com/users/sghai/repos","events_url":"https://api.github.com/users/sghai/events{/privacy}","received_events_url":"https://api.github.com/users/sghai/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-10-28T11:44:49Z","updated_at":"2014-10-29T07:43:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"08ae3007d405d213978ffdeea0f5952e1578b711","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/1630/commits","review_comments_url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/1630/comments","review_comment_url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/comments/{number}","comments_url":"https://api.github.com/repos/SatelliteQE/robottelo/issues/1630/comments","statuses_url":"https://api.github.com/repos/SatelliteQE/robottelo/statuses/30e903834e2081b38080940428ba81d5cbfa34cd","head":{"label":"sghai:ak-limit-test","ref":"ak-limit-test","sha":"30e903834e2081b38080940428ba81d5cbfa34cd","user":{"login":"sghai","id":620852,"avatar_url":"https://avatars.githubusercontent.com/u/620852?v=2","gravatar_id":"","url":"https://api.github.com/users/sghai","html_url":"https://github.com/sghai","followers_url":"https://api.github.com/users/sghai/followers","following_url":"https://api.github.com/users/sghai/following{/other_user}","gists_url":"https://api.github.com/users/sghai/gists{/gist_id}","starred_url":"https://api.github.com/users/sghai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sghai/subscriptions","organizations_url":"https://api.github.com/users/sghai/orgs","repos_url":"https://api.github.com/users/sghai/repos","events_url":"https://api.github.com/users/sghai/events{/privacy}","received_events_url":"https://api.github.com/users/sghai/received_events","type":"User","site_admin":false},"repo":{"id":14514487,"name":"robottelo","full_name":"sghai/robottelo","owner":{"login":"sghai","id":620852,"avatar_url":"https://avatars.githubusercontent.com/u/620852?v=2","gravatar_id":"","url":"https://api.github.com/users/sghai","html_url":"https://github.com/sghai","followers_url":"https://api.github.com/users/sghai/followers","following_url":"https://api.github.com/users/sghai/following{/other_user}","gists_url":"https://api.github.com/users/sghai/gists{/gist_id}","starred_url":"https://api.github.com/users/sghai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sghai/subscriptions","organizations_url":"https://api.github.com/users/sghai/orgs","repos_url":"https://api.github.com/users/sghai/repos","events_url":"https://api.github.com/users/sghai/events{/privacy}","received_events_url":"https://api.github.com/users/sghai/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sghai/robottelo","description":"An automation testing framework for the Katello project.","fork":true,"url":"https://api.github.com/repos/sghai/robottelo","forks_url":"https://api.github.com/repos/sghai/robottelo/forks","keys_url":"https://api.github.com/repos/sghai/robottelo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sghai/robottelo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sghai/robottelo/teams","hooks_url":"https://api.github.com/repos/sghai/robottelo/hooks","issue_events_url":"https://api.github.com/repos/sghai/robottelo/issues/events{/number}","events_url":"https://api.github.com/repos/sghai/robottelo/events","assignees_url":"https://api.github.com/repos/sghai/robottelo/assignees{/user}","branches_url":"https://api.github.com/repos/sghai/robottelo/branches{/branch}","tags_url":"https://api.github.com/repos/sghai/robottelo/tags","blobs_url":"https://api.github.com/repos/sghai/robottelo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sghai/robottelo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sghai/robottelo/git/refs{/sha}","trees_url":"https://api.github.com/repos/sghai/robottelo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sghai/robottelo/statuses/{sha}","languages_url":"https://api.github.com/repos/sghai/robottelo/languages","stargazers_url":"https://api.github.com/repos/sghai/robottelo/stargazers","contributors_url":"https://api.github.com/repos/sghai/robottelo/contributors","subscribers_url":"https://api.github.com/repos/sghai/robottelo/subscribers","subscription_url":"https://api.github.com/repos/sghai/robottelo/subscription","commits_url":"https://api.github.com/repos/sghai/robottelo/commits{/sha}","git_commits_url":"https://api.github.com/repos/sghai/robottelo/git/commits{/sha}","comments_url":"https://api.github.com/repos/sghai/robottelo/comments{/number}","issue_comment_url":"https://api.github.com/repos/sghai/robottelo/issues/comments/{number}","contents_url":"https://api.github.com/repos/sghai/robottelo/contents/{+path}","compare_url":"https://api.github.com/repos/sghai/robottelo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sghai/robottelo/merges","archive_url":"https://api.github.com/repos/sghai/robottelo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sghai/robottelo/downloads","issues_url":"https://api.github.com/repos/sghai/robottelo/issues{/number}","pulls_url":"https://api.github.com/repos/sghai/robottelo/pulls{/number}","milestones_url":"https://api.github.com/repos/sghai/robottelo/milestones{/number}","notifications_url":"https://api.github.com/repos/sghai/robottelo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sghai/robottelo/labels{/name}","releases_url":"https://api.github.com/repos/sghai/robottelo/releases{/id}","created_at":"2013-11-19T04:46:42Z","updated_at":"2014-07-08T08:41:11Z","pushed_at":"2014-10-29T07:21:55Z","git_url":"git://github.com/sghai/robottelo.git","ssh_url":"git@github.com:sghai/robottelo.git","clone_url":"https://github.com/sghai/robottelo.git","svn_url":"https://github.com/sghai/robottelo","homepage":null,"size":9590,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SatelliteQE:master","ref":"master","sha":"0f1b4aa5a06c3f0fdeb7223391553e6f13fd68f8","user":{"login":"SatelliteQE","id":8754276,"avatar_url":"https://avatars.githubusercontent.com/u/8754276?v=2","gravatar_id":"","url":"https://api.github.com/users/SatelliteQE","html_url":"https://github.com/SatelliteQE","followers_url":"https://api.github.com/users/SatelliteQE/followers","following_url":"https://api.github.com/users/SatelliteQE/following{/other_user}","gists_url":"https://api.github.com/users/SatelliteQE/gists{/gist_id}","starred_url":"https://api.github.com/users/SatelliteQE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SatelliteQE/subscriptions","organizations_url":"https://api.github.com/users/SatelliteQE/orgs","repos_url":"https://api.github.com/users/SatelliteQE/repos","events_url":"https://api.github.com/users/SatelliteQE/events{/privacy}","received_events_url":"https://api.github.com/users/SatelliteQE/received_events","type":"Organization","site_admin":false},"repo":{"id":4000279,"name":"robottelo","full_name":"SatelliteQE/robottelo","owner":{"login":"SatelliteQE","id":8754276,"avatar_url":"https://avatars.githubusercontent.com/u/8754276?v=2","gravatar_id":"","url":"https://api.github.com/users/SatelliteQE","html_url":"https://github.com/SatelliteQE","followers_url":"https://api.github.com/users/SatelliteQE/followers","following_url":"https://api.github.com/users/SatelliteQE/following{/other_user}","gists_url":"https://api.github.com/users/SatelliteQE/gists{/gist_id}","starred_url":"https://api.github.com/users/SatelliteQE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SatelliteQE/subscriptions","organizations_url":"https://api.github.com/users/SatelliteQE/orgs","repos_url":"https://api.github.com/users/SatelliteQE/repos","events_url":"https://api.github.com/users/SatelliteQE/events{/privacy}","received_events_url":"https://api.github.com/users/SatelliteQE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SatelliteQE/robottelo","description":"An automation testing framework for the Katello project.","fork":false,"url":"https://api.github.com/repos/SatelliteQE/robottelo","forks_url":"https://api.github.com/repos/SatelliteQE/robottelo/forks","keys_url":"https://api.github.com/repos/SatelliteQE/robottelo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SatelliteQE/robottelo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SatelliteQE/robottelo/teams","hooks_url":"https://api.github.com/repos/SatelliteQE/robottelo/hooks","issue_events_url":"https://api.github.com/repos/SatelliteQE/robottelo/issues/events{/number}","events_url":"https://api.github.com/repos/SatelliteQE/robottelo/events","assignees_url":"https://api.github.com/repos/SatelliteQE/robottelo/assignees{/user}","branches_url":"https://api.github.com/repos/SatelliteQE/robottelo/branches{/branch}","tags_url":"https://api.github.com/repos/SatelliteQE/robottelo/tags","blobs_url":"https://api.github.com/repos/SatelliteQE/robottelo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SatelliteQE/robottelo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SatelliteQE/robottelo/git/refs{/sha}","trees_url":"https://api.github.com/repos/SatelliteQE/robottelo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SatelliteQE/robottelo/statuses/{sha}","languages_url":"https://api.github.com/repos/SatelliteQE/robottelo/languages","stargazers_url":"https://api.github.com/repos/SatelliteQE/robottelo/stargazers","contributors_url":"https://api.github.com/repos/SatelliteQE/robottelo/contributors","subscribers_url":"https://api.github.com/repos/SatelliteQE/robottelo/subscribers","subscription_url":"https://api.github.com/repos/SatelliteQE/robottelo/subscription","commits_url":"https://api.github.com/repos/SatelliteQE/robottelo/commits{/sha}","git_commits_url":"https://api.github.com/repos/SatelliteQE/robottelo/git/commits{/sha}","comments_url":"https://api.github.com/repos/SatelliteQE/robottelo/comments{/number}","issue_comment_url":"https://api.github.com/repos/SatelliteQE/robottelo/issues/comments/{number}","contents_url":"https://api.github.com/repos/SatelliteQE/robottelo/contents/{+path}","compare_url":"https://api.github.com/repos/SatelliteQE/robottelo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SatelliteQE/robottelo/merges","archive_url":"https://api.github.com/repos/SatelliteQE/robottelo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SatelliteQE/robottelo/downloads","issues_url":"https://api.github.com/repos/SatelliteQE/robottelo/issues{/number}","pulls_url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls{/number}","milestones_url":"https://api.github.com/repos/SatelliteQE/robottelo/milestones{/number}","notifications_url":"https://api.github.com/repos/SatelliteQE/robottelo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SatelliteQE/robottelo/labels{/name}","releases_url":"https://api.github.com/repos/SatelliteQE/robottelo/releases{/id}","created_at":"2012-04-12T01:36:39Z","updated_at":"2014-10-03T18:11:55Z","pushed_at":"2014-10-28T15:51:31Z","git_url":"git://github.com/SatelliteQE/robottelo.git","ssh_url":"git@github.com:SatelliteQE/robottelo.git","clone_url":"https://github.com/SatelliteQE/robottelo.git","svn_url":"https://github.com/SatelliteQE/robottelo","homepage":null,"size":25953,"stargazers_count":17,"watchers_count":17,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":20,"mirror_url":null,"open_issues_count":110,"forks":20,"open_issues":110,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/1630"},"html":{"href":"https://github.com/SatelliteQE/robottelo/pull/1630"},"issue":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/issues/1630"},"comments":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/issues/1630/comments"},"review_comments":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/1630/comments"},"review_comment":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/1630/commits"},"statuses":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/statuses/30e903834e2081b38080940428ba81d5cbfa34cd"}}}}