GitHub PullRequestReviewCommentEvent at 2014-07-24 12:56:57
Repository: elasticsearch
Actor: jpountz
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/comments/15344239","id":15344239,"diff_hunk":"@@ -167,6 +166,8 @@ public void onRemoval(RemovalNotification<WeightedFilterCache.FilterCacheKey, Do\n      */\n     class ReaderCleaner implements Runnable {\n \n+        private final ObjectOpenHashSet<Object> keys = ObjectOpenHashSet.newInstance();","path":"src/main/java/org/elasticsearch/indices/cache/filter/IndicesFilterCache.java","position":35,"original_position":12,"commit_id":"e73f5e8854124988fee5518940797eab19da7380","original_commit_id":"a604a30cba52462e2b1c1ada5f18233c0e0cec09","user":{"login":"jpountz","id":299848,"avatar_url":"https://avatars.githubusercontent.com/u/299848?","gravatar_id":"e0ad83ea7b832220d0a3231e529f4338","url":"https://api.github.com/users/jpountz","html_url":"https://github.com/jpountz","followers_url":"https://api.github.com/users/jpountz/followers","following_url":"https://api.github.com/users/jpountz/following{/other_user}","gists_url":"https://api.github.com/users/jpountz/gists{/gist_id}","starred_url":"https://api.github.com/users/jpountz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpountz/subscriptions","organizations_url":"https://api.github.com/users/jpountz/orgs","repos_url":"https://api.github.com/users/jpountz/repos","events_url":"https://api.github.com/users/jpountz/events{/privacy}","received_events_url":"https://api.github.com/users/jpountz/received_events","type":"User","site_admin":false},"body":"Can you just leave a comment about it?","created_at":"2014-07-24T12:56:57Z","updated_at":"2014-07-24T12:56:57Z","html_url":"https://github.com/elasticsearch/elasticsearch/pull/7012#discussion_r15344239","pull_request_url":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/7012","_links":{"self":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/comments/15344239"},"html":{"href":"https://github.com/elasticsearch/elasticsearch/pull/7012#discussion_r15344239"},"pull_request":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/7012"}}},"pull_request":{"url":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/7012","id":18834470,"html_url":"https://github.com/elasticsearch/elasticsearch/pull/7012","diff_url":"https://github.com/elasticsearch/elasticsearch/pull/7012.diff","patch_url":"https://github.com/elasticsearch/elasticsearch/pull/7012.patch","issue_url":"https://api.github.com/repos/elasticsearch/elasticsearch/issues/7012","number":7012,"state":"open","title":"remove use of recycled set in filters eviction","user":{"login":"kimchy","id":41300,"avatar_url":"https://avatars.githubusercontent.com/u/41300?","gravatar_id":"fd44bb3c96e34e000c5453a0078900d6","url":"https://api.github.com/users/kimchy","html_url":"https://github.com/kimchy","followers_url":"https://api.github.com/users/kimchy/followers","following_url":"https://api.github.com/users/kimchy/following{/other_user}","gists_url":"https://api.github.com/users/kimchy/gists{/gist_id}","starred_url":"https://api.github.com/users/kimchy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kimchy/subscriptions","organizations_url":"https://api.github.com/users/kimchy/orgs","repos_url":"https://api.github.com/users/kimchy/repos","events_url":"https://api.github.com/users/kimchy/events{/privacy}","received_events_url":"https://api.github.com/users/kimchy/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-07-24T12:44:43Z","updated_at":"2014-07-24T12:56:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"629c4e073f83dad76c5e37e0574b0d28defe992c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/7012/commits","review_comments_url":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/7012/comments","review_comment_url":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/comments/{number}","comments_url":"https://api.github.com/repos/elasticsearch/elasticsearch/issues/7012/comments","statuses_url":"https://api.github.com/repos/elasticsearch/elasticsearch/statuses/e73f5e8854124988fee5518940797eab19da7380","head":{"label":"kimchy:remove_recycler_set","ref":"remove_recycler_set","sha":"e73f5e8854124988fee5518940797eab19da7380","user":{"login":"kimchy","id":41300,"avatar_url":"https://avatars.githubusercontent.com/u/41300?","gravatar_id":"fd44bb3c96e34e000c5453a0078900d6","url":"https://api.github.com/users/kimchy","html_url":"https://github.com/kimchy","followers_url":"https://api.github.com/users/kimchy/followers","following_url":"https://api.github.com/users/kimchy/following{/other_user}","gists_url":"https://api.github.com/users/kimchy/gists{/gist_id}","starred_url":"https://api.github.com/users/kimchy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kimchy/subscriptions","organizations_url":"https://api.github.com/users/kimchy/orgs","repos_url":"https://api.github.com/users/kimchy/repos","events_url":"https://api.github.com/users/kimchy/events{/privacy}","received_events_url":"https://api.github.com/users/kimchy/received_events","type":"User","site_admin":false},"repo":{"id":9790572,"name":"elasticsearch","full_name":"kimchy/elasticsearch","owner":{"login":"kimchy","id":41300,"avatar_url":"https://avatars.githubusercontent.com/u/41300?","gravatar_id":"fd44bb3c96e34e000c5453a0078900d6","url":"https://api.github.com/users/kimchy","html_url":"https://github.com/kimchy","followers_url":"https://api.github.com/users/kimchy/followers","following_url":"https://api.github.com/users/kimchy/following{/other_user}","gists_url":"https://api.github.com/users/kimchy/gists{/gist_id}","starred_url":"https://api.github.com/users/kimchy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kimchy/subscriptions","organizations_url":"https://api.github.com/users/kimchy/orgs","repos_url":"https://api.github.com/users/kimchy/repos","events_url":"https://api.github.com/users/kimchy/events{/privacy}","received_events_url":"https://api.github.com/users/kimchy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kimchy/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":true,"url":"https://api.github.com/repos/kimchy/elasticsearch","forks_url":"https://api.github.com/repos/kimchy/elasticsearch/forks","keys_url":"https://api.github.com/repos/kimchy/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kimchy/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kimchy/elasticsearch/teams","hooks_url":"https://api.github.com/repos/kimchy/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/kimchy/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/kimchy/elasticsearch/events","assignees_url":"https://api.github.com/repos/kimchy/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/kimchy/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/kimchy/elasticsearch/tags","blobs_url":"https://api.github.com/repos/kimchy/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kimchy/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kimchy/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/kimchy/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kimchy/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/kimchy/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/kimchy/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/kimchy/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/kimchy/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/kimchy/elasticsearch/subscription","commits_url":"https://api.github.com/repos/kimchy/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/kimchy/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/kimchy/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/kimchy/elasticsearch/issues/comments/{number}","contents_url":"https://api.github.com/repos/kimchy/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/kimchy/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kimchy/elasticsearch/merges","archive_url":"https://api.github.com/repos/kimchy/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kimchy/elasticsearch/downloads","issues_url":"https://api.github.com/repos/kimchy/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/kimchy/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/kimchy/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/kimchy/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kimchy/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/kimchy/elasticsearch/releases{/id}","created_at":"2013-05-01T11:50:20Z","updated_at":"2014-07-02T16:43:52Z","pushed_at":"2014-07-24T12:56:43Z","git_url":"git://github.com/kimchy/elasticsearch.git","ssh_url":"git@github.com:kimchy/elasticsearch.git","clone_url":"https://github.com/kimchy/elasticsearch.git","svn_url":"https://github.com/kimchy/elasticsearch","homepage":"http://elasticsearch.org","size":58293,"stargazers_count":5,"watchers_count":5,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":5,"default_branch":"master"}},"base":{"label":"elasticsearch:master","ref":"master","sha":"d9ff42f88a93f1219b23e4a7861cfbf9bc7242c8","user":{"login":"elasticsearch","id":141304,"avatar_url":"https://avatars.githubusercontent.com/u/141304?","gravatar_id":"1aecf795625bbc7251068cfbc39800ab","url":"https://api.github.com/users/elasticsearch","html_url":"https://github.com/elasticsearch","followers_url":"https://api.github.com/users/elasticsearch/followers","following_url":"https://api.github.com/users/elasticsearch/following{/other_user}","gists_url":"https://api.github.com/users/elasticsearch/gists{/gist_id}","starred_url":"https://api.github.com/users/elasticsearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elasticsearch/subscriptions","organizations_url":"https://api.github.com/users/elasticsearch/orgs","repos_url":"https://api.github.com/users/elasticsearch/repos","events_url":"https://api.github.com/users/elasticsearch/events{/privacy}","received_events_url":"https://api.github.com/users/elasticsearch/received_events","type":"Organization","site_admin":false},"repo":{"id":507775,"name":"elasticsearch","full_name":"elasticsearch/elasticsearch","owner":{"login":"elasticsearch","id":141304,"avatar_url":"https://avatars.githubusercontent.com/u/141304?","gravatar_id":"1aecf795625bbc7251068cfbc39800ab","url":"https://api.github.com/users/elasticsearch","html_url":"https://github.com/elasticsearch","followers_url":"https://api.github.com/users/elasticsearch/followers","following_url":"https://api.github.com/users/elasticsearch/following{/other_user}","gists_url":"https://api.github.com/users/elasticsearch/gists{/gist_id}","starred_url":"https://api.github.com/users/elasticsearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elasticsearch/subscriptions","organizations_url":"https://api.github.com/users/elasticsearch/orgs","repos_url":"https://api.github.com/users/elasticsearch/repos","events_url":"https://api.github.com/users/elasticsearch/events{/privacy}","received_events_url":"https://api.github.com/users/elasticsearch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elasticsearch/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":false,"url":"https://api.github.com/repos/elasticsearch/elasticsearch","forks_url":"https://api.github.com/repos/elasticsearch/elasticsearch/forks","keys_url":"https://api.github.com/repos/elasticsearch/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elasticsearch/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elasticsearch/elasticsearch/teams","hooks_url":"https://api.github.com/repos/elasticsearch/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/elasticsearch/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/elasticsearch/elasticsearch/events","assignees_url":"https://api.github.com/repos/elasticsearch/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/elasticsearch/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/elasticsearch/elasticsearch/tags","blobs_url":"https://api.github.com/repos/elasticsearch/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elasticsearch/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elasticsearch/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/elasticsearch/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elasticsearch/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/elasticsearch/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/elasticsearch/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/elasticsearch/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/elasticsearch/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/elasticsearch/elasticsearch/subscription","commits_url":"https://api.github.com/repos/elasticsearch/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/elasticsearch/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/elasticsearch/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/elasticsearch/elasticsearch/issues/comments/{number}","contents_url":"https://api.github.com/repos/elasticsearch/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/elasticsearch/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elasticsearch/elasticsearch/merges","archive_url":"https://api.github.com/repos/elasticsearch/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elasticsearch/elasticsearch/downloads","issues_url":"https://api.github.com/repos/elasticsearch/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/elasticsearch/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/elasticsearch/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elasticsearch/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/elasticsearch/elasticsearch/releases{/id}","created_at":"2010-02-08T13:20:56Z","updated_at":"2014-07-24T07:29:45Z","pushed_at":"2014-07-24T12:53:11Z","git_url":"git://github.com/elasticsearch/elasticsearch.git","ssh_url":"git@github.com:elasticsearch/elasticsearch.git","clone_url":"https://github.com/elasticsearch/elasticsearch.git","svn_url":"https://github.com/elasticsearch/elasticsearch","homepage":"http://elasticsearch.org","size":228753,"stargazers_count":7709,"watchers_count":7709,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":2211,"mirror_url":null,"open_issues_count":912,"forks":2211,"open_issues":912,"watchers":7709,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/7012"},"html":{"href":"https://github.com/elasticsearch/elasticsearch/pull/7012"},"issue":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/issues/7012"},"comments":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/issues/7012/comments"},"review_comments":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/7012/comments"},"review_comment":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/7012/commits"},"statuses":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/statuses/e73f5e8854124988fee5518940797eab19da7380"}}}}