GitHub PullRequestEvent at 2014-06-09 15:36:18
Repository: MonoGame
Actor: tomspilman
Payload: {"action":"closed","number":2658,"pull_request":{"url":"https://api.github.com/repos/mono/MonoGame/pulls/2658","id":16605773,"html_url":"https://github.com/mono/MonoGame/pull/2658","diff_url":"https://github.com/mono/MonoGame/pull/2658.diff","patch_url":"https://github.com/mono/MonoGame/pull/2658.patch","issue_url":"https://api.github.com/repos/mono/MonoGame/issues/2658","number":2658,"state":"closed","title":"Fixed bug in detection of \"natural\" orientation of Android device.","user":{"login":"Andreyul","id":1127000,"avatar_url":"https://avatars.githubusercontent.com/u/1127000?","gravatar_id":"2df7d565991047037be3afce4a00f3bb","url":"https://api.github.com/users/Andreyul","html_url":"https://github.com/Andreyul","followers_url":"https://api.github.com/users/Andreyul/followers","following_url":"https://api.github.com/users/Andreyul/following{/other_user}","gists_url":"https://api.github.com/users/Andreyul/gists{/gist_id}","starred_url":"https://api.github.com/users/Andreyul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Andreyul/subscriptions","organizations_url":"https://api.github.com/users/Andreyul/orgs","repos_url":"https://api.github.com/users/Andreyul/repos","events_url":"https://api.github.com/users/Andreyul/events{/privacy}","received_events_url":"https://api.github.com/users/Andreyul/received_events","type":"User","site_admin":false},"body":"My setup: landscape game running on a 480*854 device having portrait \"natural\" orientation.\r\nDevice is lying on a flat surface, I launch the game. `OrientationListener.GetDeviceDefaultOrientation()` is called from `Activity.OnCreate()`, it returns `Landscape` \"natural\" orientation, which is wrong.\r\nI grab device in my hand and rotate it. The screen flips when phone orientation is portrait or reverse portrait.\r\n\r\nThis pull request contains fixes:\r\n- Value of \"natural\" orientation is computed on first `OnOrientationChanged()` call (not in ctor, because it may return invalid value if called too early).\r\n- Orientation listener is active between `Activity.OnResume()`/`OnPause()` calls.\r\n- Orientation value of `OrientationUnknown` (-1) is ignored.","created_at":"2014-06-02T15:32:58Z","updated_at":"2014-06-09T15:36:17Z","closed_at":"2014-06-09T15:36:17Z","merged_at":"2014-06-09T15:36:17Z","merge_commit_sha":"78a6de47aaf34a18b036ac9abdbbdc33f78646d4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mono/MonoGame/pulls/2658/commits","review_comments_url":"https://api.github.com/repos/mono/MonoGame/pulls/2658/comments","review_comment_url":"https://api.github.com/repos/mono/MonoGame/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mono/MonoGame/issues/2658/comments","statuses_url":"https://api.github.com/repos/mono/MonoGame/statuses/7a9c0ba15fd59128576153c10b6803421f9e377b","head":{"label":"Andreyul:orientation","ref":"orientation","sha":"7a9c0ba15fd59128576153c10b6803421f9e377b","user":{"login":"Andreyul","id":1127000,"avatar_url":"https://avatars.githubusercontent.com/u/1127000?","gravatar_id":"2df7d565991047037be3afce4a00f3bb","url":"https://api.github.com/users/Andreyul","html_url":"https://github.com/Andreyul","followers_url":"https://api.github.com/users/Andreyul/followers","following_url":"https://api.github.com/users/Andreyul/following{/other_user}","gists_url":"https://api.github.com/users/Andreyul/gists{/gist_id}","starred_url":"https://api.github.com/users/Andreyul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Andreyul/subscriptions","organizations_url":"https://api.github.com/users/Andreyul/orgs","repos_url":"https://api.github.com/users/Andreyul/repos","events_url":"https://api.github.com/users/Andreyul/events{/privacy}","received_events_url":"https://api.github.com/users/Andreyul/received_events","type":"User","site_admin":false},"repo":{"id":19491822,"name":"MonoGame","full_name":"Andreyul/MonoGame","owner":{"login":"Andreyul","id":1127000,"avatar_url":"https://avatars.githubusercontent.com/u/1127000?","gravatar_id":"2df7d565991047037be3afce4a00f3bb","url":"https://api.github.com/users/Andreyul","html_url":"https://github.com/Andreyul","followers_url":"https://api.github.com/users/Andreyul/followers","following_url":"https://api.github.com/users/Andreyul/following{/other_user}","gists_url":"https://api.github.com/users/Andreyul/gists{/gist_id}","starred_url":"https://api.github.com/users/Andreyul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Andreyul/subscriptions","organizations_url":"https://api.github.com/users/Andreyul/orgs","repos_url":"https://api.github.com/users/Andreyul/repos","events_url":"https://api.github.com/users/Andreyul/events{/privacy}","received_events_url":"https://api.github.com/users/Andreyul/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Andreyul/MonoGame","description":"One framework for creating powerful cross-platform games.","fork":true,"url":"https://api.github.com/repos/Andreyul/MonoGame","forks_url":"https://api.github.com/repos/Andreyul/MonoGame/forks","keys_url":"https://api.github.com/repos/Andreyul/MonoGame/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Andreyul/MonoGame/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Andreyul/MonoGame/teams","hooks_url":"https://api.github.com/repos/Andreyul/MonoGame/hooks","issue_events_url":"https://api.github.com/repos/Andreyul/MonoGame/issues/events{/number}","events_url":"https://api.github.com/repos/Andreyul/MonoGame/events","assignees_url":"https://api.github.com/repos/Andreyul/MonoGame/assignees{/user}","branches_url":"https://api.github.com/repos/Andreyul/MonoGame/branches{/branch}","tags_url":"https://api.github.com/repos/Andreyul/MonoGame/tags","blobs_url":"https://api.github.com/repos/Andreyul/MonoGame/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Andreyul/MonoGame/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Andreyul/MonoGame/git/refs{/sha}","trees_url":"https://api.github.com/repos/Andreyul/MonoGame/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Andreyul/MonoGame/statuses/{sha}","languages_url":"https://api.github.com/repos/Andreyul/MonoGame/languages","stargazers_url":"https://api.github.com/repos/Andreyul/MonoGame/stargazers","contributors_url":"https://api.github.com/repos/Andreyul/MonoGame/contributors","subscribers_url":"https://api.github.com/repos/Andreyul/MonoGame/subscribers","subscription_url":"https://api.github.com/repos/Andreyul/MonoGame/subscription","commits_url":"https://api.github.com/repos/Andreyul/MonoGame/commits{/sha}","git_commits_url":"https://api.github.com/repos/Andreyul/MonoGame/git/commits{/sha}","comments_url":"https://api.github.com/repos/Andreyul/MonoGame/comments{/number}","issue_comment_url":"https://api.github.com/repos/Andreyul/MonoGame/issues/comments/{number}","contents_url":"https://api.github.com/repos/Andreyul/MonoGame/contents/{+path}","compare_url":"https://api.github.com/repos/Andreyul/MonoGame/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Andreyul/MonoGame/merges","archive_url":"https://api.github.com/repos/Andreyul/MonoGame/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Andreyul/MonoGame/downloads","issues_url":"https://api.github.com/repos/Andreyul/MonoGame/issues{/number}","pulls_url":"https://api.github.com/repos/Andreyul/MonoGame/pulls{/number}","milestones_url":"https://api.github.com/repos/Andreyul/MonoGame/milestones{/number}","notifications_url":"https://api.github.com/repos/Andreyul/MonoGame/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Andreyul/MonoGame/labels{/name}","releases_url":"https://api.github.com/repos/Andreyul/MonoGame/releases{/id}","created_at":"2014-05-06T11:31:15Z","updated_at":"2014-06-09T15:36:17Z","pushed_at":"2014-06-05T00:32:27Z","git_url":"git://github.com/Andreyul/MonoGame.git","ssh_url":"git@github.com:Andreyul/MonoGame.git","clone_url":"https://github.com/Andreyul/MonoGame.git","svn_url":"https://github.com/Andreyul/MonoGame","homepage":"http://www.monogame.net","size":44817,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"mono:develop","ref":"develop","sha":"d8d21d4e51a3fba88a2ba938c08a227758f79e8a","user":{"login":"mono","id":53395,"avatar_url":"https://avatars.githubusercontent.com/u/53395?","gravatar_id":"f275a99c0b4e6044d3e81daf445f8174","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"repo":{"id":1579990,"name":"MonoGame","full_name":"mono/MonoGame","owner":{"login":"mono","id":53395,"avatar_url":"https://avatars.githubusercontent.com/u/53395?","gravatar_id":"f275a99c0b4e6044d3e81daf445f8174","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mono/MonoGame","description":"One framework for creating powerful cross-platform games.","fork":false,"url":"https://api.github.com/repos/mono/MonoGame","forks_url":"https://api.github.com/repos/mono/MonoGame/forks","keys_url":"https://api.github.com/repos/mono/MonoGame/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mono/MonoGame/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mono/MonoGame/teams","hooks_url":"https://api.github.com/repos/mono/MonoGame/hooks","issue_events_url":"https://api.github.com/repos/mono/MonoGame/issues/events{/number}","events_url":"https://api.github.com/repos/mono/MonoGame/events","assignees_url":"https://api.github.com/repos/mono/MonoGame/assignees{/user}","branches_url":"https://api.github.com/repos/mono/MonoGame/branches{/branch}","tags_url":"https://api.github.com/repos/mono/MonoGame/tags","blobs_url":"https://api.github.com/repos/mono/MonoGame/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mono/MonoGame/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mono/MonoGame/git/refs{/sha}","trees_url":"https://api.github.com/repos/mono/MonoGame/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mono/MonoGame/statuses/{sha}","languages_url":"https://api.github.com/repos/mono/MonoGame/languages","stargazers_url":"https://api.github.com/repos/mono/MonoGame/stargazers","contributors_url":"https://api.github.com/repos/mono/MonoGame/contributors","subscribers_url":"https://api.github.com/repos/mono/MonoGame/subscribers","subscription_url":"https://api.github.com/repos/mono/MonoGame/subscription","commits_url":"https://api.github.com/repos/mono/MonoGame/commits{/sha}","git_commits_url":"https://api.github.com/repos/mono/MonoGame/git/commits{/sha}","comments_url":"https://api.github.com/repos/mono/MonoGame/comments{/number}","issue_comment_url":"https://api.github.com/repos/mono/MonoGame/issues/comments/{number}","contents_url":"https://api.github.com/repos/mono/MonoGame/contents/{+path}","compare_url":"https://api.github.com/repos/mono/MonoGame/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mono/MonoGame/merges","archive_url":"https://api.github.com/repos/mono/MonoGame/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mono/MonoGame/downloads","issues_url":"https://api.github.com/repos/mono/MonoGame/issues{/number}","pulls_url":"https://api.github.com/repos/mono/MonoGame/pulls{/number}","milestones_url":"https://api.github.com/repos/mono/MonoGame/milestones{/number}","notifications_url":"https://api.github.com/repos/mono/MonoGame/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mono/MonoGame/labels{/name}","releases_url":"https://api.github.com/repos/mono/MonoGame/releases{/id}","created_at":"2011-04-07T00:23:40Z","updated_at":"2014-06-09T15:36:17Z","pushed_at":"2014-06-09T15:36:17Z","git_url":"git://github.com/mono/MonoGame.git","ssh_url":"git@github.com:mono/MonoGame.git","clone_url":"https://github.com/mono/MonoGame.git","svn_url":"https://github.com/mono/MonoGame","homepage":"http://www.monogame.net","size":312300,"stargazers_count":2091,"watchers_count":2091,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1183,"mirror_url":null,"open_issues_count":424,"forks":1183,"open_issues":424,"watchers":2091,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/mono/MonoGame/pulls/2658"},"html":{"href":"https://github.com/mono/MonoGame/pull/2658"},"issue":{"href":"https://api.github.com/repos/mono/MonoGame/issues/2658"},"comments":{"href":"https://api.github.com/repos/mono/MonoGame/issues/2658/comments"},"review_comments":{"href":"https://api.github.com/repos/mono/MonoGame/pulls/2658/comments"},"review_comment":{"href":"https://api.github.com/repos/mono/MonoGame/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mono/MonoGame/pulls/2658/commits"},"statuses":{"href":"https://api.github.com/repos/mono/MonoGame/statuses/7a9c0ba15fd59128576153c10b6803421f9e377b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"tomspilman","id":103522,"avatar_url":"https://avatars.githubusercontent.com/u/103522?","gravatar_id":"8d025ee1bc863257127e15e64d6438b1","url":"https://api.github.com/users/tomspilman","html_url":"https://github.com/tomspilman","followers_url":"https://api.github.com/users/tomspilman/followers","following_url":"https://api.github.com/users/tomspilman/following{/other_user}","gists_url":"https://api.github.com/users/tomspilman/gists{/gist_id}","starred_url":"https://api.github.com/users/tomspilman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomspilman/subscriptions","organizations_url":"https://api.github.com/users/tomspilman/orgs","repos_url":"https://api.github.com/users/tomspilman/repos","events_url":"https://api.github.com/users/tomspilman/events{/privacy}","received_events_url":"https://api.github.com/users/tomspilman/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"commits":1,"additions":43,"deletions":59,"changed_files":3}}