GitHub PullRequestEvent at 2014-12-02 01:27:06
Repository: scss-lint
Actor: mbertolacci
Payload: {"action":"opened","number":306,"pull_request":{"url":"https://api.github.com/repos/causes/scss-lint/pulls/306","id":25313028,"html_url":"https://github.com/causes/scss-lint/pull/306","diff_url":"https://github.com/causes/scss-lint/pull/306.diff","patch_url":"https://github.com/causes/scss-lint/pull/306.patch","issue_url":"https://api.github.com/repos/causes/scss-lint/issues/306","number":306,"state":"open","locked":false,"title":"Use line numbers to implement control comments instead of visit order","user":{"login":"mbertolacci","id":1761597,"avatar_url":"https://avatars.githubusercontent.com/u/1761597?v=3","gravatar_id":"","url":"https://api.github.com/users/mbertolacci","html_url":"https://github.com/mbertolacci","followers_url":"https://api.github.com/users/mbertolacci/followers","following_url":"https://api.github.com/users/mbertolacci/following{/other_user}","gists_url":"https://api.github.com/users/mbertolacci/gists{/gist_id}","starred_url":"https://api.github.com/users/mbertolacci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbertolacci/subscriptions","organizations_url":"https://api.github.com/users/mbertolacci/orgs","repos_url":"https://api.github.com/users/mbertolacci/repos","events_url":"https://api.github.com/users/mbertolacci/events{/privacy}","received_events_url":"https://api.github.com/users/mbertolacci/received_events","type":"User","site_admin":false},"body":"Addresses DuplicateProperty bug reported in #150 \r\n\r\nI've split the control comments code into a separate file and removed the brittleness whereby the visit order is crucial to the operation of the control comments. The downside is that it is now brittle to determining the line numbers to which the control comments apply, see lines 49-59 of lib/scss_lint/control_comments.rb to see what I mean.\r\n\r\nI've also updated the test to detect this bug.","created_at":"2014-12-02T01:27:05Z","updated_at":"2014-12-02T01:27:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/causes/scss-lint/pulls/306/commits","review_comments_url":"https://api.github.com/repos/causes/scss-lint/pulls/306/comments","review_comment_url":"https://api.github.com/repos/causes/scss-lint/pulls/comments/{number}","comments_url":"https://api.github.com/repos/causes/scss-lint/issues/306/comments","statuses_url":"https://api.github.com/repos/causes/scss-lint/statuses/4a75ca0e1d2954750a352acc971c0b06739dde5e","head":{"label":"burnsred:feature/control-comment-robustness","ref":"feature/control-comment-robustness","sha":"4a75ca0e1d2954750a352acc971c0b06739dde5e","user":{"login":"burnsred","id":5327331,"avatar_url":"https://avatars.githubusercontent.com/u/5327331?v=3","gravatar_id":"","url":"https://api.github.com/users/burnsred","html_url":"https://github.com/burnsred","followers_url":"https://api.github.com/users/burnsred/followers","following_url":"https://api.github.com/users/burnsred/following{/other_user}","gists_url":"https://api.github.com/users/burnsred/gists{/gist_id}","starred_url":"https://api.github.com/users/burnsred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burnsred/subscriptions","organizations_url":"https://api.github.com/users/burnsred/orgs","repos_url":"https://api.github.com/users/burnsred/repos","events_url":"https://api.github.com/users/burnsred/events{/privacy}","received_events_url":"https://api.github.com/users/burnsred/received_events","type":"Organization","site_admin":false},"repo":{"id":27250849,"name":"scss-lint","full_name":"burnsred/scss-lint","owner":{"login":"burnsred","id":5327331,"avatar_url":"https://avatars.githubusercontent.com/u/5327331?v=3","gravatar_id":"","url":"https://api.github.com/users/burnsred","html_url":"https://github.com/burnsred","followers_url":"https://api.github.com/users/burnsred/followers","following_url":"https://api.github.com/users/burnsred/following{/other_user}","gists_url":"https://api.github.com/users/burnsred/gists{/gist_id}","starred_url":"https://api.github.com/users/burnsred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burnsred/subscriptions","organizations_url":"https://api.github.com/users/burnsred/orgs","repos_url":"https://api.github.com/users/burnsred/repos","events_url":"https://api.github.com/users/burnsred/events{/privacy}","received_events_url":"https://api.github.com/users/burnsred/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/burnsred/scss-lint","description":"Configurable tool for writing clean and consistent SCSS","fork":true,"url":"https://api.github.com/repos/burnsred/scss-lint","forks_url":"https://api.github.com/repos/burnsred/scss-lint/forks","keys_url":"https://api.github.com/repos/burnsred/scss-lint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/burnsred/scss-lint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/burnsred/scss-lint/teams","hooks_url":"https://api.github.com/repos/burnsred/scss-lint/hooks","issue_events_url":"https://api.github.com/repos/burnsred/scss-lint/issues/events{/number}","events_url":"https://api.github.com/repos/burnsred/scss-lint/events","assignees_url":"https://api.github.com/repos/burnsred/scss-lint/assignees{/user}","branches_url":"https://api.github.com/repos/burnsred/scss-lint/branches{/branch}","tags_url":"https://api.github.com/repos/burnsred/scss-lint/tags","blobs_url":"https://api.github.com/repos/burnsred/scss-lint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/burnsred/scss-lint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/burnsred/scss-lint/git/refs{/sha}","trees_url":"https://api.github.com/repos/burnsred/scss-lint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/burnsred/scss-lint/statuses/{sha}","languages_url":"https://api.github.com/repos/burnsred/scss-lint/languages","stargazers_url":"https://api.github.com/repos/burnsred/scss-lint/stargazers","contributors_url":"https://api.github.com/repos/burnsred/scss-lint/contributors","subscribers_url":"https://api.github.com/repos/burnsred/scss-lint/subscribers","subscription_url":"https://api.github.com/repos/burnsred/scss-lint/subscription","commits_url":"https://api.github.com/repos/burnsred/scss-lint/commits{/sha}","git_commits_url":"https://api.github.com/repos/burnsred/scss-lint/git/commits{/sha}","comments_url":"https://api.github.com/repos/burnsred/scss-lint/comments{/number}","issue_comment_url":"https://api.github.com/repos/burnsred/scss-lint/issues/comments/{number}","contents_url":"https://api.github.com/repos/burnsred/scss-lint/contents/{+path}","compare_url":"https://api.github.com/repos/burnsred/scss-lint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/burnsred/scss-lint/merges","archive_url":"https://api.github.com/repos/burnsred/scss-lint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/burnsred/scss-lint/downloads","issues_url":"https://api.github.com/repos/burnsred/scss-lint/issues{/number}","pulls_url":"https://api.github.com/repos/burnsred/scss-lint/pulls{/number}","milestones_url":"https://api.github.com/repos/burnsred/scss-lint/milestones{/number}","notifications_url":"https://api.github.com/repos/burnsred/scss-lint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/burnsred/scss-lint/labels{/name}","releases_url":"https://api.github.com/repos/burnsred/scss-lint/releases{/id}","created_at":"2014-11-28T03:52:29Z","updated_at":"2014-12-02T01:23:30Z","pushed_at":"2014-12-02T01:23:30Z","git_url":"git://github.com/burnsred/scss-lint.git","ssh_url":"git@github.com:burnsred/scss-lint.git","clone_url":"https://github.com/burnsred/scss-lint.git","svn_url":"https://github.com/burnsred/scss-lint","homepage":"","size":5563,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"causes:master","ref":"master","sha":"4b336a2f1cb1b0deb1536d932adce34fb62e26d0","user":{"login":"causes","id":7448,"avatar_url":"https://avatars.githubusercontent.com/u/7448?v=3","gravatar_id":"","url":"https://api.github.com/users/causes","html_url":"https://github.com/causes","followers_url":"https://api.github.com/users/causes/followers","following_url":"https://api.github.com/users/causes/following{/other_user}","gists_url":"https://api.github.com/users/causes/gists{/gist_id}","starred_url":"https://api.github.com/users/causes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/causes/subscriptions","organizations_url":"https://api.github.com/users/causes/orgs","repos_url":"https://api.github.com/users/causes/repos","events_url":"https://api.github.com/users/causes/events{/privacy}","received_events_url":"https://api.github.com/users/causes/received_events","type":"Organization","site_admin":false},"repo":{"id":7228264,"name":"scss-lint","full_name":"causes/scss-lint","owner":{"login":"causes","id":7448,"avatar_url":"https://avatars.githubusercontent.com/u/7448?v=3","gravatar_id":"","url":"https://api.github.com/users/causes","html_url":"https://github.com/causes","followers_url":"https://api.github.com/users/causes/followers","following_url":"https://api.github.com/users/causes/following{/other_user}","gists_url":"https://api.github.com/users/causes/gists{/gist_id}","starred_url":"https://api.github.com/users/causes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/causes/subscriptions","organizations_url":"https://api.github.com/users/causes/orgs","repos_url":"https://api.github.com/users/causes/repos","events_url":"https://api.github.com/users/causes/events{/privacy}","received_events_url":"https://api.github.com/users/causes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/causes/scss-lint","description":"Configurable tool for writing clean and consistent SCSS","fork":false,"url":"https://api.github.com/repos/causes/scss-lint","forks_url":"https://api.github.com/repos/causes/scss-lint/forks","keys_url":"https://api.github.com/repos/causes/scss-lint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/causes/scss-lint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/causes/scss-lint/teams","hooks_url":"https://api.github.com/repos/causes/scss-lint/hooks","issue_events_url":"https://api.github.com/repos/causes/scss-lint/issues/events{/number}","events_url":"https://api.github.com/repos/causes/scss-lint/events","assignees_url":"https://api.github.com/repos/causes/scss-lint/assignees{/user}","branches_url":"https://api.github.com/repos/causes/scss-lint/branches{/branch}","tags_url":"https://api.github.com/repos/causes/scss-lint/tags","blobs_url":"https://api.github.com/repos/causes/scss-lint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/causes/scss-lint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/causes/scss-lint/git/refs{/sha}","trees_url":"https://api.github.com/repos/causes/scss-lint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/causes/scss-lint/statuses/{sha}","languages_url":"https://api.github.com/repos/causes/scss-lint/languages","stargazers_url":"https://api.github.com/repos/causes/scss-lint/stargazers","contributors_url":"https://api.github.com/repos/causes/scss-lint/contributors","subscribers_url":"https://api.github.com/repos/causes/scss-lint/subscribers","subscription_url":"https://api.github.com/repos/causes/scss-lint/subscription","commits_url":"https://api.github.com/repos/causes/scss-lint/commits{/sha}","git_commits_url":"https://api.github.com/repos/causes/scss-lint/git/commits{/sha}","comments_url":"https://api.github.com/repos/causes/scss-lint/comments{/number}","issue_comment_url":"https://api.github.com/repos/causes/scss-lint/issues/comments/{number}","contents_url":"https://api.github.com/repos/causes/scss-lint/contents/{+path}","compare_url":"https://api.github.com/repos/causes/scss-lint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/causes/scss-lint/merges","archive_url":"https://api.github.com/repos/causes/scss-lint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/causes/scss-lint/downloads","issues_url":"https://api.github.com/repos/causes/scss-lint/issues{/number}","pulls_url":"https://api.github.com/repos/causes/scss-lint/pulls{/number}","milestones_url":"https://api.github.com/repos/causes/scss-lint/milestones{/number}","notifications_url":"https://api.github.com/repos/causes/scss-lint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/causes/scss-lint/labels{/name}","releases_url":"https://api.github.com/repos/causes/scss-lint/releases{/id}","created_at":"2012-12-18T18:31:42Z","updated_at":"2014-12-01T22:31:21Z","pushed_at":"2014-12-01T22:31:21Z","git_url":"git://github.com/causes/scss-lint.git","ssh_url":"git@github.com:causes/scss-lint.git","clone_url":"https://github.com/causes/scss-lint.git","svn_url":"https://github.com/causes/scss-lint","homepage":"","size":5563,"stargazers_count":932,"watchers_count":932,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":97,"mirror_url":null,"open_issues_count":6,"forks":97,"open_issues":6,"watchers":932,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/causes/scss-lint/pulls/306"},"html":{"href":"https://github.com/causes/scss-lint/pull/306"},"issue":{"href":"https://api.github.com/repos/causes/scss-lint/issues/306"},"comments":{"href":"https://api.github.com/repos/causes/scss-lint/issues/306/comments"},"review_comments":{"href":"https://api.github.com/repos/causes/scss-lint/pulls/306/comments"},"review_comment":{"href":"https://api.github.com/repos/causes/scss-lint/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/causes/scss-lint/pulls/306/commits"},"statuses":{"href":"https://api.github.com/repos/causes/scss-lint/statuses/4a75ca0e1d2954750a352acc971c0b06739dde5e"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":115,"deletions":42,"changed_files":4}}