GitHub PullRequestReviewCommentEvent at 2014-06-12 16:15:31
Repository: openproject
Actor: tilt
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/opf/openproject/pulls/comments/13710344","id":13710344,"diff_hunk":"@@ -26,27 +26,51 @@\n // See doc/COPYRIGHT.rdoc for more details.\n //++\n \n-openprojectApp.config([\n+angular.module('openproject')\n+\n+.config([\n   '$stateProvider',\n   '$urlRouterProvider',\n   function($stateProvider, $urlRouterProvider) {\n \n-  $urlRouterProvider.otherwise(\"/wp\");\n+  // All unmatched routes should be handled by Rails\n+  // (i.e. invoke a full-page load)\n+  //\n+  // a better behaviour here would be for Angular's HTML5-mode to provide an\n+  // option to turn link hijacking off by default (and use a `target` attribute\n+  // to turn it on for selected links).\n+\n+  $urlRouterProvider.otherwise(function($injector, $location) {","path":"app/assets/javascripts/angular/routing.js","position":20,"original_position":20,"commit_id":"73a6059f6309b54f906c35d751dec4da40809dfa","original_commit_id":"73a6059f6309b54f906c35d751dec4da40809dfa","user":{"login":"tilt","id":35519,"avatar_url":"https://avatars.githubusercontent.com/u/35519?","gravatar_id":"d945de63aec09f1a171e9f4c775f4c0d","url":"https://api.github.com/users/tilt","html_url":"https://github.com/tilt","followers_url":"https://api.github.com/users/tilt/followers","following_url":"https://api.github.com/users/tilt/following{/other_user}","gists_url":"https://api.github.com/users/tilt/gists{/gist_id}","starred_url":"https://api.github.com/users/tilt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tilt/subscriptions","organizations_url":"https://api.github.com/users/tilt/orgs","repos_url":"https://api.github.com/users/tilt/repos","events_url":"https://api.github.com/users/tilt/events{/privacy}","received_events_url":"https://api.github.com/users/tilt/received_events","type":"User","site_admin":false},"body":"that postgres spec failure seems to be recurring btw","created_at":"2014-06-12T16:15:31Z","updated_at":"2014-06-12T16:15:31Z","html_url":"https://github.com/opf/openproject/pull/1453#discussion_r13710344","pull_request_url":"https://api.github.com/repos/opf/openproject/pulls/1453","_links":{"self":{"href":"https://api.github.com/repos/opf/openproject/pulls/comments/13710344"},"html":{"href":"https://github.com/opf/openproject/pull/1453#discussion_r13710344"},"pull_request":{"href":"https://api.github.com/repos/opf/openproject/pulls/1453"}}},"pull_request":{"url":"https://api.github.com/repos/opf/openproject/pulls/1453","id":16994324,"html_url":"https://github.com/opf/openproject/pull/1453","diff_url":"https://github.com/opf/openproject/pull/1453.diff","patch_url":"https://github.com/opf/openproject/pull/1453.patch","issue_url":"https://api.github.com/repos/opf/openproject/issues/1453","number":1453,"state":"open","title":"Feature/client side routing serialize query","user":{"login":"tilt","id":35519,"avatar_url":"https://avatars.githubusercontent.com/u/35519?","gravatar_id":"d945de63aec09f1a171e9f4c775f4c0d","url":"https://api.github.com/users/tilt","html_url":"https://github.com/tilt","followers_url":"https://api.github.com/users/tilt/followers","following_url":"https://api.github.com/users/tilt/following{/other_user}","gists_url":"https://api.github.com/users/tilt/gists{/gist_id}","starred_url":"https://api.github.com/users/tilt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tilt/subscriptions","organizations_url":"https://api.github.com/users/tilt/orgs","repos_url":"https://api.github.com/users/tilt/repos","events_url":"https://api.github.com/users/tilt/events{/privacy}","received_events_url":"https://api.github.com/users/tilt/received_events","type":"User","site_admin":false},"body":"https://www.openproject.org/work_packages/8444","created_at":"2014-06-11T12:24:50Z","updated_at":"2014-06-12T16:15:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c4295f1b2e120779797e34cbb0909a5934920125","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/opf/openproject/pulls/1453/commits","review_comments_url":"https://api.github.com/repos/opf/openproject/pulls/1453/comments","review_comment_url":"https://api.github.com/repos/opf/openproject/pulls/comments/{number}","comments_url":"https://api.github.com/repos/opf/openproject/issues/1453/comments","statuses_url":"https://api.github.com/repos/opf/openproject/statuses/73a6059f6309b54f906c35d751dec4da40809dfa","head":{"label":"opf:feature/client-side-routing-serialize-query","ref":"feature/client-side-routing-serialize-query","sha":"73a6059f6309b54f906c35d751dec4da40809dfa","user":{"login":"opf","id":1756674,"avatar_url":"https://avatars.githubusercontent.com/u/1756674?","gravatar_id":"5bbd957d96ff8bf94937a799938e1d62","url":"https://api.github.com/users/opf","html_url":"https://github.com/opf","followers_url":"https://api.github.com/users/opf/followers","following_url":"https://api.github.com/users/opf/following{/other_user}","gists_url":"https://api.github.com/users/opf/gists{/gist_id}","starred_url":"https://api.github.com/users/opf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opf/subscriptions","organizations_url":"https://api.github.com/users/opf/orgs","repos_url":"https://api.github.com/users/opf/repos","events_url":"https://api.github.com/users/opf/events{/privacy}","received_events_url":"https://api.github.com/users/opf/received_events","type":"Organization","site_admin":false},"repo":{"id":6899875,"name":"openproject","full_name":"opf/openproject","owner":{"login":"opf","id":1756674,"avatar_url":"https://avatars.githubusercontent.com/u/1756674?","gravatar_id":"5bbd957d96ff8bf94937a799938e1d62","url":"https://api.github.com/users/opf","html_url":"https://github.com/opf","followers_url":"https://api.github.com/users/opf/followers","following_url":"https://api.github.com/users/opf/following{/other_user}","gists_url":"https://api.github.com/users/opf/gists{/gist_id}","starred_url":"https://api.github.com/users/opf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opf/subscriptions","organizations_url":"https://api.github.com/users/opf/orgs","repos_url":"https://api.github.com/users/opf/repos","events_url":"https://api.github.com/users/opf/events{/privacy}","received_events_url":"https://api.github.com/users/opf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opf/openproject","description":"OpenProject is a web based project management system built on Ruby on Rails","fork":false,"url":"https://api.github.com/repos/opf/openproject","forks_url":"https://api.github.com/repos/opf/openproject/forks","keys_url":"https://api.github.com/repos/opf/openproject/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opf/openproject/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opf/openproject/teams","hooks_url":"https://api.github.com/repos/opf/openproject/hooks","issue_events_url":"https://api.github.com/repos/opf/openproject/issues/events{/number}","events_url":"https://api.github.com/repos/opf/openproject/events","assignees_url":"https://api.github.com/repos/opf/openproject/assignees{/user}","branches_url":"https://api.github.com/repos/opf/openproject/branches{/branch}","tags_url":"https://api.github.com/repos/opf/openproject/tags","blobs_url":"https://api.github.com/repos/opf/openproject/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opf/openproject/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opf/openproject/git/refs{/sha}","trees_url":"https://api.github.com/repos/opf/openproject/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opf/openproject/statuses/{sha}","languages_url":"https://api.github.com/repos/opf/openproject/languages","stargazers_url":"https://api.github.com/repos/opf/openproject/stargazers","contributors_url":"https://api.github.com/repos/opf/openproject/contributors","subscribers_url":"https://api.github.com/repos/opf/openproject/subscribers","subscription_url":"https://api.github.com/repos/opf/openproject/subscription","commits_url":"https://api.github.com/repos/opf/openproject/commits{/sha}","git_commits_url":"https://api.github.com/repos/opf/openproject/git/commits{/sha}","comments_url":"https://api.github.com/repos/opf/openproject/comments{/number}","issue_comment_url":"https://api.github.com/repos/opf/openproject/issues/comments/{number}","contents_url":"https://api.github.com/repos/opf/openproject/contents/{+path}","compare_url":"https://api.github.com/repos/opf/openproject/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opf/openproject/merges","archive_url":"https://api.github.com/repos/opf/openproject/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opf/openproject/downloads","issues_url":"https://api.github.com/repos/opf/openproject/issues{/number}","pulls_url":"https://api.github.com/repos/opf/openproject/pulls{/number}","milestones_url":"https://api.github.com/repos/opf/openproject/milestones{/number}","notifications_url":"https://api.github.com/repos/opf/openproject/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opf/openproject/labels{/name}","releases_url":"https://api.github.com/repos/opf/openproject/releases{/id}","created_at":"2012-11-28T09:59:11Z","updated_at":"2014-06-12T15:50:37Z","pushed_at":"2014-06-12T15:48:53Z","git_url":"git://github.com/opf/openproject.git","ssh_url":"git@github.com:opf/openproject.git","clone_url":"https://github.com/opf/openproject.git","svn_url":"https://github.com/opf/openproject","homepage":"https://openproject.org","size":126922,"stargazers_count":224,"watchers_count":224,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":114,"mirror_url":null,"open_issues_count":42,"forks":114,"open_issues":42,"watchers":224,"default_branch":"dev"}},"base":{"label":"opf:dev","ref":"dev","sha":"ffb7a55cdfcd2845eede594aa01665c16a76da28","user":{"login":"opf","id":1756674,"avatar_url":"https://avatars.githubusercontent.com/u/1756674?","gravatar_id":"5bbd957d96ff8bf94937a799938e1d62","url":"https://api.github.com/users/opf","html_url":"https://github.com/opf","followers_url":"https://api.github.com/users/opf/followers","following_url":"https://api.github.com/users/opf/following{/other_user}","gists_url":"https://api.github.com/users/opf/gists{/gist_id}","starred_url":"https://api.github.com/users/opf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opf/subscriptions","organizations_url":"https://api.github.com/users/opf/orgs","repos_url":"https://api.github.com/users/opf/repos","events_url":"https://api.github.com/users/opf/events{/privacy}","received_events_url":"https://api.github.com/users/opf/received_events","type":"Organization","site_admin":false},"repo":{"id":6899875,"name":"openproject","full_name":"opf/openproject","owner":{"login":"opf","id":1756674,"avatar_url":"https://avatars.githubusercontent.com/u/1756674?","gravatar_id":"5bbd957d96ff8bf94937a799938e1d62","url":"https://api.github.com/users/opf","html_url":"https://github.com/opf","followers_url":"https://api.github.com/users/opf/followers","following_url":"https://api.github.com/users/opf/following{/other_user}","gists_url":"https://api.github.com/users/opf/gists{/gist_id}","starred_url":"https://api.github.com/users/opf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opf/subscriptions","organizations_url":"https://api.github.com/users/opf/orgs","repos_url":"https://api.github.com/users/opf/repos","events_url":"https://api.github.com/users/opf/events{/privacy}","received_events_url":"https://api.github.com/users/opf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opf/openproject","description":"OpenProject is a web based project management system built on Ruby on Rails","fork":false,"url":"https://api.github.com/repos/opf/openproject","forks_url":"https://api.github.com/repos/opf/openproject/forks","keys_url":"https://api.github.com/repos/opf/openproject/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opf/openproject/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opf/openproject/teams","hooks_url":"https://api.github.com/repos/opf/openproject/hooks","issue_events_url":"https://api.github.com/repos/opf/openproject/issues/events{/number}","events_url":"https://api.github.com/repos/opf/openproject/events","assignees_url":"https://api.github.com/repos/opf/openproject/assignees{/user}","branches_url":"https://api.github.com/repos/opf/openproject/branches{/branch}","tags_url":"https://api.github.com/repos/opf/openproject/tags","blobs_url":"https://api.github.com/repos/opf/openproject/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opf/openproject/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opf/openproject/git/refs{/sha}","trees_url":"https://api.github.com/repos/opf/openproject/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opf/openproject/statuses/{sha}","languages_url":"https://api.github.com/repos/opf/openproject/languages","stargazers_url":"https://api.github.com/repos/opf/openproject/stargazers","contributors_url":"https://api.github.com/repos/opf/openproject/contributors","subscribers_url":"https://api.github.com/repos/opf/openproject/subscribers","subscription_url":"https://api.github.com/repos/opf/openproject/subscription","commits_url":"https://api.github.com/repos/opf/openproject/commits{/sha}","git_commits_url":"https://api.github.com/repos/opf/openproject/git/commits{/sha}","comments_url":"https://api.github.com/repos/opf/openproject/comments{/number}","issue_comment_url":"https://api.github.com/repos/opf/openproject/issues/comments/{number}","contents_url":"https://api.github.com/repos/opf/openproject/contents/{+path}","compare_url":"https://api.github.com/repos/opf/openproject/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opf/openproject/merges","archive_url":"https://api.github.com/repos/opf/openproject/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opf/openproject/downloads","issues_url":"https://api.github.com/repos/opf/openproject/issues{/number}","pulls_url":"https://api.github.com/repos/opf/openproject/pulls{/number}","milestones_url":"https://api.github.com/repos/opf/openproject/milestones{/number}","notifications_url":"https://api.github.com/repos/opf/openproject/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opf/openproject/labels{/name}","releases_url":"https://api.github.com/repos/opf/openproject/releases{/id}","created_at":"2012-11-28T09:59:11Z","updated_at":"2014-06-12T15:50:37Z","pushed_at":"2014-06-12T15:48:53Z","git_url":"git://github.com/opf/openproject.git","ssh_url":"git@github.com:opf/openproject.git","clone_url":"https://github.com/opf/openproject.git","svn_url":"https://github.com/opf/openproject","homepage":"https://openproject.org","size":126922,"stargazers_count":224,"watchers_count":224,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":114,"mirror_url":null,"open_issues_count":42,"forks":114,"open_issues":42,"watchers":224,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/opf/openproject/pulls/1453"},"html":{"href":"https://github.com/opf/openproject/pull/1453"},"issue":{"href":"https://api.github.com/repos/opf/openproject/issues/1453"},"comments":{"href":"https://api.github.com/repos/opf/openproject/issues/1453/comments"},"review_comments":{"href":"https://api.github.com/repos/opf/openproject/pulls/1453/comments"},"review_comment":{"href":"https://api.github.com/repos/opf/openproject/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/opf/openproject/pulls/1453/commits"},"statuses":{"href":"https://api.github.com/repos/opf/openproject/statuses/73a6059f6309b54f906c35d751dec4da40809dfa"}}}}