GitHub PullRequestEvent at 2014-12-01 00:20:06
Repository: roots
Actor: leopuleo
Payload: {"action":"opened","number":1217,"pull_request":{"url":"https://api.github.com/repos/roots/roots/pulls/1217","id":25242321,"html_url":"https://github.com/roots/roots/pull/1217","diff_url":"https://github.com/roots/roots/pull/1217.diff","patch_url":"https://github.com/roots/roots/pull/1217.patch","issue_url":"https://api.github.com/repos/roots/roots/issues/1217","number":1217,"state":"open","locked":false,"title":"Remove Roots_Nav_Walker as default for all menu","user":{"login":"leopuleo","id":2866531,"avatar_url":"https://avatars.githubusercontent.com/u/2866531?v=3","gravatar_id":"","url":"https://api.github.com/users/leopuleo","html_url":"https://github.com/leopuleo","followers_url":"https://api.github.com/users/leopuleo/followers","following_url":"https://api.github.com/users/leopuleo/following{/other_user}","gists_url":"https://api.github.com/users/leopuleo/gists{/gist_id}","starred_url":"https://api.github.com/users/leopuleo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leopuleo/subscriptions","organizations_url":"https://api.github.com/users/leopuleo/orgs","repos_url":"https://api.github.com/users/leopuleo/repos","events_url":"https://api.github.com/users/leopuleo/events{/privacy}","received_events_url":"https://api.github.com/users/leopuleo/received_events","type":"User","site_admin":false},"body":"I love how `Roots_Nav_Walker()` create menu html.\r\nBut, I believe that apply by default to all menus is too much.\r\n\r\nOften I use the menu widget to show complex menus with sub-element.\r\nIn these situations sub-elements are wrapped in dropdown menus, which is fine for primary menu but not for aside or footer.\r\n\r\nI suggest to:\r\n* remove `Roots_Nav_Walker()` as default for all menus\r\n* add `Roots_Nav_Walker()` to Primary menu\r\n\r\nIn this way:\r\n* if user wants another menu using `Roots_Nav_Walker()`, can simply copy and paste the code in `header.php`\r\n* user can add other custom Nav_Walkers \r\n* Widget menus can have as many level as user likes.","created_at":"2014-12-01T00:20:05Z","updated_at":"2014-12-01T00:20:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f1ebe70095f504076c9f69e08dedc683fe77c9c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/roots/roots/pulls/1217/commits","review_comments_url":"https://api.github.com/repos/roots/roots/pulls/1217/comments","review_comment_url":"https://api.github.com/repos/roots/roots/pulls/comments/{number}","comments_url":"https://api.github.com/repos/roots/roots/issues/1217/comments","statuses_url":"https://api.github.com/repos/roots/roots/statuses/3d422638cbe188c5930bbd251a846db82a5db867","head":{"label":"leopuleo:master","ref":"master","sha":"3d422638cbe188c5930bbd251a846db82a5db867","user":{"login":"leopuleo","id":2866531,"avatar_url":"https://avatars.githubusercontent.com/u/2866531?v=3","gravatar_id":"","url":"https://api.github.com/users/leopuleo","html_url":"https://github.com/leopuleo","followers_url":"https://api.github.com/users/leopuleo/followers","following_url":"https://api.github.com/users/leopuleo/following{/other_user}","gists_url":"https://api.github.com/users/leopuleo/gists{/gist_id}","starred_url":"https://api.github.com/users/leopuleo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leopuleo/subscriptions","organizations_url":"https://api.github.com/users/leopuleo/orgs","repos_url":"https://api.github.com/users/leopuleo/repos","events_url":"https://api.github.com/users/leopuleo/events{/privacy}","received_events_url":"https://api.github.com/users/leopuleo/received_events","type":"User","site_admin":false},"repo":{"id":27349178,"name":"roots","full_name":"leopuleo/roots","owner":{"login":"leopuleo","id":2866531,"avatar_url":"https://avatars.githubusercontent.com/u/2866531?v=3","gravatar_id":"","url":"https://api.github.com/users/leopuleo","html_url":"https://github.com/leopuleo","followers_url":"https://api.github.com/users/leopuleo/followers","following_url":"https://api.github.com/users/leopuleo/following{/other_user}","gists_url":"https://api.github.com/users/leopuleo/gists{/gist_id}","starred_url":"https://api.github.com/users/leopuleo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leopuleo/subscriptions","organizations_url":"https://api.github.com/users/leopuleo/orgs","repos_url":"https://api.github.com/users/leopuleo/repos","events_url":"https://api.github.com/users/leopuleo/events{/privacy}","received_events_url":"https://api.github.com/users/leopuleo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/leopuleo/roots","description":"WordPress starter theme based on HTML5 Boilerplate & Bootstrap","fork":true,"url":"https://api.github.com/repos/leopuleo/roots","forks_url":"https://api.github.com/repos/leopuleo/roots/forks","keys_url":"https://api.github.com/repos/leopuleo/roots/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leopuleo/roots/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leopuleo/roots/teams","hooks_url":"https://api.github.com/repos/leopuleo/roots/hooks","issue_events_url":"https://api.github.com/repos/leopuleo/roots/issues/events{/number}","events_url":"https://api.github.com/repos/leopuleo/roots/events","assignees_url":"https://api.github.com/repos/leopuleo/roots/assignees{/user}","branches_url":"https://api.github.com/repos/leopuleo/roots/branches{/branch}","tags_url":"https://api.github.com/repos/leopuleo/roots/tags","blobs_url":"https://api.github.com/repos/leopuleo/roots/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leopuleo/roots/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leopuleo/roots/git/refs{/sha}","trees_url":"https://api.github.com/repos/leopuleo/roots/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leopuleo/roots/statuses/{sha}","languages_url":"https://api.github.com/repos/leopuleo/roots/languages","stargazers_url":"https://api.github.com/repos/leopuleo/roots/stargazers","contributors_url":"https://api.github.com/repos/leopuleo/roots/contributors","subscribers_url":"https://api.github.com/repos/leopuleo/roots/subscribers","subscription_url":"https://api.github.com/repos/leopuleo/roots/subscription","commits_url":"https://api.github.com/repos/leopuleo/roots/commits{/sha}","git_commits_url":"https://api.github.com/repos/leopuleo/roots/git/commits{/sha}","comments_url":"https://api.github.com/repos/leopuleo/roots/comments{/number}","issue_comment_url":"https://api.github.com/repos/leopuleo/roots/issues/comments/{number}","contents_url":"https://api.github.com/repos/leopuleo/roots/contents/{+path}","compare_url":"https://api.github.com/repos/leopuleo/roots/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leopuleo/roots/merges","archive_url":"https://api.github.com/repos/leopuleo/roots/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leopuleo/roots/downloads","issues_url":"https://api.github.com/repos/leopuleo/roots/issues{/number}","pulls_url":"https://api.github.com/repos/leopuleo/roots/pulls{/number}","milestones_url":"https://api.github.com/repos/leopuleo/roots/milestones{/number}","notifications_url":"https://api.github.com/repos/leopuleo/roots/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leopuleo/roots/labels{/name}","releases_url":"https://api.github.com/repos/leopuleo/roots/releases{/id}","created_at":"2014-11-30T20:36:29Z","updated_at":"2014-12-01T00:04:59Z","pushed_at":"2014-12-01T00:04:59Z","git_url":"git://github.com/leopuleo/roots.git","ssh_url":"git@github.com:leopuleo/roots.git","clone_url":"https://github.com/leopuleo/roots.git","svn_url":"https://github.com/leopuleo/roots","homepage":"http://roots.io/starter-theme/","size":71978,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"roots:master","ref":"master","sha":"3f2c5a89a80bbe96531bfa225eaba4de76b97b84","user":{"login":"roots","id":4986074,"avatar_url":"https://avatars.githubusercontent.com/u/4986074?v=3","gravatar_id":"","url":"https://api.github.com/users/roots","html_url":"https://github.com/roots","followers_url":"https://api.github.com/users/roots/followers","following_url":"https://api.github.com/users/roots/following{/other_user}","gists_url":"https://api.github.com/users/roots/gists{/gist_id}","starred_url":"https://api.github.com/users/roots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roots/subscriptions","organizations_url":"https://api.github.com/users/roots/orgs","repos_url":"https://api.github.com/users/roots/repos","events_url":"https://api.github.com/users/roots/events{/privacy}","received_events_url":"https://api.github.com/users/roots/received_events","type":"Organization","site_admin":false},"repo":{"id":1305114,"name":"roots","full_name":"roots/roots","owner":{"login":"roots","id":4986074,"avatar_url":"https://avatars.githubusercontent.com/u/4986074?v=3","gravatar_id":"","url":"https://api.github.com/users/roots","html_url":"https://github.com/roots","followers_url":"https://api.github.com/users/roots/followers","following_url":"https://api.github.com/users/roots/following{/other_user}","gists_url":"https://api.github.com/users/roots/gists{/gist_id}","starred_url":"https://api.github.com/users/roots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roots/subscriptions","organizations_url":"https://api.github.com/users/roots/orgs","repos_url":"https://api.github.com/users/roots/repos","events_url":"https://api.github.com/users/roots/events{/privacy}","received_events_url":"https://api.github.com/users/roots/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/roots/roots","description":"WordPress starter theme based on HTML5 Boilerplate & Bootstrap","fork":false,"url":"https://api.github.com/repos/roots/roots","forks_url":"https://api.github.com/repos/roots/roots/forks","keys_url":"https://api.github.com/repos/roots/roots/keys{/key_id}","collaborators_url":"https://api.github.com/repos/roots/roots/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/roots/roots/teams","hooks_url":"https://api.github.com/repos/roots/roots/hooks","issue_events_url":"https://api.github.com/repos/roots/roots/issues/events{/number}","events_url":"https://api.github.com/repos/roots/roots/events","assignees_url":"https://api.github.com/repos/roots/roots/assignees{/user}","branches_url":"https://api.github.com/repos/roots/roots/branches{/branch}","tags_url":"https://api.github.com/repos/roots/roots/tags","blobs_url":"https://api.github.com/repos/roots/roots/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/roots/roots/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/roots/roots/git/refs{/sha}","trees_url":"https://api.github.com/repos/roots/roots/git/trees{/sha}","statuses_url":"https://api.github.com/repos/roots/roots/statuses/{sha}","languages_url":"https://api.github.com/repos/roots/roots/languages","stargazers_url":"https://api.github.com/repos/roots/roots/stargazers","contributors_url":"https://api.github.com/repos/roots/roots/contributors","subscribers_url":"https://api.github.com/repos/roots/roots/subscribers","subscription_url":"https://api.github.com/repos/roots/roots/subscription","commits_url":"https://api.github.com/repos/roots/roots/commits{/sha}","git_commits_url":"https://api.github.com/repos/roots/roots/git/commits{/sha}","comments_url":"https://api.github.com/repos/roots/roots/comments{/number}","issue_comment_url":"https://api.github.com/repos/roots/roots/issues/comments/{number}","contents_url":"https://api.github.com/repos/roots/roots/contents/{+path}","compare_url":"https://api.github.com/repos/roots/roots/compare/{base}...{head}","merges_url":"https://api.github.com/repos/roots/roots/merges","archive_url":"https://api.github.com/repos/roots/roots/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/roots/roots/downloads","issues_url":"https://api.github.com/repos/roots/roots/issues{/number}","pulls_url":"https://api.github.com/repos/roots/roots/pulls{/number}","milestones_url":"https://api.github.com/repos/roots/roots/milestones{/number}","notifications_url":"https://api.github.com/repos/roots/roots/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/roots/roots/labels{/name}","releases_url":"https://api.github.com/repos/roots/roots/releases{/id}","created_at":"2011-01-29T03:12:09Z","updated_at":"2014-11-29T22:37:46Z","pushed_at":"2014-11-17T21:31:39Z","git_url":"git://github.com/roots/roots.git","ssh_url":"git@github.com:roots/roots.git","clone_url":"https://github.com/roots/roots.git","svn_url":"https://github.com/roots/roots","homepage":"http://roots.io/starter-theme/","size":71978,"stargazers_count":4897,"watchers_count":4897,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1720,"mirror_url":null,"open_issues_count":18,"forks":1720,"open_issues":18,"watchers":4897,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/roots/roots/pulls/1217"},"html":{"href":"https://github.com/roots/roots/pull/1217"},"issue":{"href":"https://api.github.com/repos/roots/roots/issues/1217"},"comments":{"href":"https://api.github.com/repos/roots/roots/issues/1217/comments"},"review_comments":{"href":"https://api.github.com/repos/roots/roots/pulls/1217/comments"},"review_comment":{"href":"https://api.github.com/repos/roots/roots/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/roots/roots/pulls/1217/commits"},"statuses":{"href":"https://api.github.com/repos/roots/roots/statuses/3d422638cbe188c5930bbd251a846db82a5db867"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":1,"deletions":5,"changed_files":2}}