GitHub PullRequestReviewCommentEvent at 2014-04-02 14:15:53
Repository: phph-site
Actor: asgrim
Payload: {"comment":{"url":"https://api.github.com/repos/phphants/phph-site/pulls/comments/11206760","id":11206760,"diff_hunk":"@@ -1,146 +1,455 @@\n+\n+/* reset */\n+* {\n+\t-webkit-box-sizing: border-box;\n+\t   -moz-box-sizing: border-box;\n+\t\tbox-sizing: border-box;\n+\n+\tmargin: 0; padding: 0;\t\n+\t/* box-sizing means widths are calculated to include paddings and borders */\n+}\n+\n html {\n \tposition: relative;\n \tmin-height: 100%;\n }\n+\n body {\n-\tbackground-color: #eeeeee;\n+\tmargin-bottom: 100px;\n+\tpadding-bottom: 25px;\n+\t\n \tfont-family: \"Open Sans\", sans-serif;\n-\tmargin: 0;\n-\tpadding: 0;\n-\tmargin-bottom: 120px;\n+\n+\tbackground: #eee;\n }\n-a {\n-\tcolor: #ec7748;\n+\n+a{ color: #ec7748; }\n+\n+.gradient-wrapper{\n+\tbackground-color: #223e80; /* fallback color if gradients are not supported */\n+\tbackground-image: -webkit-linear-gradient(top, #223e80, #466BB9);\n+\tbackground-image:    -moz-linear-gradient(top, #223e80, #466BB9);\n+\tbackground-image:     -ms-linear-gradient(top, #223e80, #466BB9);\n+\tbackground-image:      -o-linear-gradient(top, #223e80, #466BB9);\n+\tbackground-image:         linear-gradient(to bottom, #223e80, #466BB9);\n+\tbackground-attachment: fixed;\n }\n-.fixed-width {\n-\twidth: 990px;\n+\n+.wrapper {\n+\twidth: 80%;\n+\tmax-width: 990px;\n \tmargin: 0 auto;\n }\n+\n+@media (max-width: 800px) {\n+\t.wrapper {\n+\t\twidth: 90%;\n+\t}\n+}\n+\n+@media (max-width: 600px) {\n+\t.wrapper {\n+\t\twidth: 100%;\n+\t}\n+}\n+\n header {\n-\tbackground-color: #223e80;\n-\tcolor: white;\n-\tbox-shadow: 0px 2px 5px 0px rgba(50, 50, 50, 0.75);\n+\tpadding: 15px 10px;\n+\toverflow: auto; /* clearfix */\n+\t\n+\tcolor: #fff;\n+}\n+\n+.header-logo {\n+\tdisplay: block;\n+\tfloat: left;\n+\twidth: 140px;\n+\theight: 70px;\n+\n+\ttext-indent: -9999px; /* hides the text */\n+\n+\tbackground: url('../images/phphants.png') no-repeat center;\n+\tbackground-size: 100%;\n+}\n+\n+.header-logo:hover {\n+\topacity: .9;\n+}\n+\n+@media (max-width: 600px) {\n+\t.header-logo {\n+\t\twidth: 100px;\n+\t\theight: 50px;\n+\t}\n }\n-header nav ul {\n+\n+header nav {\n \tfloat: right;\n-\tpadding: 0;\n-\tmargin: 40px 0 0 0;\n+\tmax-width: 80%;\n+\toverflow: hidden;\n }\n+\n+@media (max-width: 600px) {\n+\theader nav {\n+\t\tmax-height: 0;\n+\t\tmax-width: 100%;\n+\t\twidth: 100%;\n+\t\n+\t\t-webkit-transition: max-height .75s ease-in-out;\n+\t\t\t\ttransition: all .75s ease-in-out;\n+\t}\n+\n+\theader .nav--shown {\n+\t\tmax-height: 500px;\n+\t}\n+}\n+\n header nav ul li {\n-\tmargin-left: 15px;\n-\tdisplay: inline;\n+\tdisplay: inline-block;\n+\t\n+\tcolor: #d8d8d8;\n+\n+\tlist-style: none;\n \ttext-transform: uppercase;\n }\n+\n+@media (max-width: 800px) {\n+\theader nav ul li {\n+\t\tfont-size: .75em;\n+\t}\n+}\n+\n header nav ul li a {\n-\tcolor: #d8d8d8;\n+\tdisplay: block;\n+\tpadding: 20px 10px;\n+\n+\tcolor: inherit;\n \ttext-decoration: none;\n+\n+\t-webkit-transition: color .15s;\n+\t\t\ttransition: color .15s;\n }\n+\n+@media (max-width: 600px) {\n+\theader nav ul {\n+\t\tpadding-top: 5px;\n+\t}\n+\n+\theader nav ul li {\n+\t\twidth: 100%;\n+\n+\t\tfont-size: 1.15em;\n+\t\tfont-weight: 600;\n+\t\ttext-align: center;\n+\n+\t\tborder-bottom: 1px solid #aaa;\n+\t}\n+\n+\theader nav ul li a {\n+\t\tpadding: 10px 5px;\n+\t}\n+\t\n+\theader nav ul li:hover { background: rgba(255,255,255,.45); }\n+\t\n+\theader nav ul li:last-child { border: none; }\n+}\n+\n header nav ul li a:hover {\n \tcolor: #ffffff;\n }\n+\n header nav ul li.active a {\n \tcolor: #ec7748;\n }\n-#logo {\n-\tmargin: 15px 0 15px 20px;\n-}\n-footer {\n-\tbackground-color: white;\n-\tbox-shadow: 0px -2px 5px 0px rgba(50, 50, 50, 0.25);\n-\ttext-align: center;\n-\tposition: absolute;\n-\tbottom: 0;\n-\twidth: 100%;\n-}\n-footer p {\n-\tmargin: 0;\n-\tpadding: 20px 0 0 0;\n-}\n-footer nav ul {\n-\tmargin: 0;\n-\tpadding: 0 0 20px 0;\n-}\n-footer nav ul li {\n-\tdisplay: inline;\n+\n+header .nav-button{\n+\tdisplay: none;\n+\tfloat: right;\n+\tpadding: 10px;\n+\n+\tfont-size: .8em;\n+\ttext-decoration: none;\n+\ttext-transform: uppercase;\n+\tcolor: white;\n+\n+\tbackground: rgba(255,255,255,.25);\n+\tborder-radius: 5px;\n }\n-#content {\n-\tmargin: 15px auto;\n+\n+@media (max-width: 600px){\n+\theader .nav-button{\n+\t\tdisplay: block;\n+\t}\n }\n-#hero {\n-\tbackground-color: #8ca1d1;\n-\tbox-shadow: 0px 2px 5px 0px rgba(50, 50, 50, 0.75);\n+\n+.hero {\n+\tpadding: 25px 0;\n \ttext-align: center;\n }\n-#hero h1 {\n-\tfont-family: 'Yanone Kaffeesatz', arial, serif;\n-\tfont-size: 60px;\n-\tmargin: 0;\n-\tpadding: 35px 0 30px 0;\n+\n+@media (max-width: 600px) {\n+\t.hero { font-size: .75em; }\n+}\n+\n+.hero h1 {\n+\tfont-family: 'Yanone Kaffeesatz', sans-serif;\n+\tfont-size: 4em;\n \tcolor: #ededf5;\n-\ttext-shadow: 1px 1px 2px rgba(0, 0, 0, 0.4);\n+\ttext-shadow: 0 3px 0 rgba(0,0,0,.15);\n }\n-#hero p {\n-\tfont-size: 26px;\n+\n+.hero p {\n+\twidth: 80%;","path":"public/css/style.css","position":253,"original_position":253,"commit_id":"f05d2f1b36961f5ab55951b8262ef4b0aa321315","original_commit_id":"f05d2f1b36961f5ab55951b8262ef4b0aa321315","user":{"login":"asgrim","id":496145,"avatar_url":"https://avatars.githubusercontent.com/u/496145?","gravatar_id":"e1bd9a357173c0e4697a54cb404bd966","url":"https://api.github.com/users/asgrim","html_url":"https://github.com/asgrim","followers_url":"https://api.github.com/users/asgrim/followers","following_url":"https://api.github.com/users/asgrim/following{/other_user}","gists_url":"https://api.github.com/users/asgrim/gists{/gist_id}","starred_url":"https://api.github.com/users/asgrim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asgrim/subscriptions","organizations_url":"https://api.github.com/users/asgrim/orgs","repos_url":"https://api.github.com/users/asgrim/repos","events_url":"https://api.github.com/users/asgrim/events{/privacy}","received_events_url":"https://api.github.com/users/asgrim/received_events","type":"User","site_admin":false},"body":"Also, `.hero p { width: 85% }` to keep text on 2 lines at max res","created_at":"2014-04-02T14:15:53Z","updated_at":"2014-04-02T14:15:53Z","html_url":"https://github.com/phphants/phph-site/pull/45#discussion_r11206760","pull_request_url":"https://api.github.com/repos/phphants/phph-site/pulls/45","_links":{"self":{"href":"https://api.github.com/repos/phphants/phph-site/pulls/comments/11206760"},"html":{"href":"https://github.com/phphants/phph-site/pull/45#discussion_r11206760"},"pull_request":{"href":"https://api.github.com/repos/phphants/phph-site/pulls/45"}}}}