GitHub PullRequestReviewCommentEvent at 2014-09-13 16:02:46
Repository: ember.js
Actor: fivetanley
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/emberjs/ember.js/pulls/comments/17512848","id":17512848,"diff_hunk":"@@ -165,7 +165,11 @@ export var ViewHelper = EmberObject.create({\n     makeBindings(thisContext, options);\n \n     var container = this.container || (data && data.view && data.view.container);\n-    newView = handlebarsGetView(thisContext, path, container, options.data);\n+\n+    if(options.types[0] === 'STRING')","path":"packages/ember-handlebars/lib/helpers/view.js","position":6,"original_position":6,"commit_id":"0a3dec675581ab2946aece53b250a10f954f1b2b","original_commit_id":"0a3dec675581ab2946aece53b250a10f954f1b2b","user":{"login":"fivetanley","id":1275021,"avatar_url":"https://avatars.githubusercontent.com/u/1275021?v=2","gravatar_id":"45dcf10a40723044f4f5859c11202557","url":"https://api.github.com/users/fivetanley","html_url":"https://github.com/fivetanley","followers_url":"https://api.github.com/users/fivetanley/followers","following_url":"https://api.github.com/users/fivetanley/following{/other_user}","gists_url":"https://api.github.com/users/fivetanley/gists{/gist_id}","starred_url":"https://api.github.com/users/fivetanley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fivetanley/subscriptions","organizations_url":"https://api.github.com/users/fivetanley/orgs","repos_url":"https://api.github.com/users/fivetanley/repos","events_url":"https://api.github.com/users/fivetanley/events{/privacy}","received_events_url":"https://api.github.com/users/fivetanley/received_events","type":"User","site_admin":false},"body":"stylistically the rest of the code base uses brackets always for `if` statements, could you update to reflect that?","created_at":"2014-09-13T16:02:46Z","updated_at":"2014-09-13T16:02:46Z","html_url":"https://github.com/emberjs/ember.js/pull/5582#discussion_r17512848","pull_request_url":"https://api.github.com/repos/emberjs/ember.js/pulls/5582","_links":{"self":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/comments/17512848"},"html":{"href":"https://github.com/emberjs/ember.js/pull/5582#discussion_r17512848"},"pull_request":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/5582"}}},"pull_request":{"url":"https://api.github.com/repos/emberjs/ember.js/pulls/5582","id":21132184,"html_url":"https://github.com/emberjs/ember.js/pull/5582","diff_url":"https://github.com/emberjs/ember.js/pull/5582.diff","patch_url":"https://github.com/emberjs/ember.js/pull/5582.patch","issue_url":"https://api.github.com/repos/emberjs/ember.js/issues/5582","number":5582,"state":"open","locked":false,"title":"Fix for #5579","user":{"login":"briandunn","id":93310,"avatar_url":"https://avatars.githubusercontent.com/u/93310?v=2","gravatar_id":"d4a6d23822816a8f7a534281d89067f2","url":"https://api.github.com/users/briandunn","html_url":"https://github.com/briandunn","followers_url":"https://api.github.com/users/briandunn/followers","following_url":"https://api.github.com/users/briandunn/following{/other_user}","gists_url":"https://api.github.com/users/briandunn/gists{/gist_id}","starred_url":"https://api.github.com/users/briandunn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briandunn/subscriptions","organizations_url":"https://api.github.com/users/briandunn/orgs","repos_url":"https://api.github.com/users/briandunn/repos","events_url":"https://api.github.com/users/briandunn/events{/privacy}","received_events_url":"https://api.github.com/users/briandunn/received_events","type":"User","site_admin":false},"body":"Certainly this is too naive since it mutates the keyword hash, but it illustrates the problem.","created_at":"2014-09-12T04:16:45Z","updated_at":"2014-09-13T16:02:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d9cd9fc7683bd31ca42591d0f610e7e8d15fe49a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/emberjs/ember.js/pulls/5582/commits","review_comments_url":"https://api.github.com/repos/emberjs/ember.js/pulls/5582/comments","review_comment_url":"https://api.github.com/repos/emberjs/ember.js/pulls/comments/{number}","comments_url":"https://api.github.com/repos/emberjs/ember.js/issues/5582/comments","statuses_url":"https://api.github.com/repos/emberjs/ember.js/statuses/0a3dec675581ab2946aece53b250a10f954f1b2b","head":{"label":"briandunn:fix-view-lookup","ref":"fix-view-lookup","sha":"0a3dec675581ab2946aece53b250a10f954f1b2b","user":{"login":"briandunn","id":93310,"avatar_url":"https://avatars.githubusercontent.com/u/93310?v=2","gravatar_id":"d4a6d23822816a8f7a534281d89067f2","url":"https://api.github.com/users/briandunn","html_url":"https://github.com/briandunn","followers_url":"https://api.github.com/users/briandunn/followers","following_url":"https://api.github.com/users/briandunn/following{/other_user}","gists_url":"https://api.github.com/users/briandunn/gists{/gist_id}","starred_url":"https://api.github.com/users/briandunn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briandunn/subscriptions","organizations_url":"https://api.github.com/users/briandunn/orgs","repos_url":"https://api.github.com/users/briandunn/repos","events_url":"https://api.github.com/users/briandunn/events{/privacy}","received_events_url":"https://api.github.com/users/briandunn/received_events","type":"User","site_admin":false},"repo":{"id":23923783,"name":"ember.js","full_name":"briandunn/ember.js","owner":{"login":"briandunn","id":93310,"avatar_url":"https://avatars.githubusercontent.com/u/93310?v=2","gravatar_id":"d4a6d23822816a8f7a534281d89067f2","url":"https://api.github.com/users/briandunn","html_url":"https://github.com/briandunn","followers_url":"https://api.github.com/users/briandunn/followers","following_url":"https://api.github.com/users/briandunn/following{/other_user}","gists_url":"https://api.github.com/users/briandunn/gists{/gist_id}","starred_url":"https://api.github.com/users/briandunn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briandunn/subscriptions","organizations_url":"https://api.github.com/users/briandunn/orgs","repos_url":"https://api.github.com/users/briandunn/repos","events_url":"https://api.github.com/users/briandunn/events{/privacy}","received_events_url":"https://api.github.com/users/briandunn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/briandunn/ember.js","description":"Ember.js - A JavaScript framework for creating ambitious web applications","fork":true,"url":"https://api.github.com/repos/briandunn/ember.js","forks_url":"https://api.github.com/repos/briandunn/ember.js/forks","keys_url":"https://api.github.com/repos/briandunn/ember.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/briandunn/ember.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/briandunn/ember.js/teams","hooks_url":"https://api.github.com/repos/briandunn/ember.js/hooks","issue_events_url":"https://api.github.com/repos/briandunn/ember.js/issues/events{/number}","events_url":"https://api.github.com/repos/briandunn/ember.js/events","assignees_url":"https://api.github.com/repos/briandunn/ember.js/assignees{/user}","branches_url":"https://api.github.com/repos/briandunn/ember.js/branches{/branch}","tags_url":"https://api.github.com/repos/briandunn/ember.js/tags","blobs_url":"https://api.github.com/repos/briandunn/ember.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/briandunn/ember.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/briandunn/ember.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/briandunn/ember.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/briandunn/ember.js/statuses/{sha}","languages_url":"https://api.github.com/repos/briandunn/ember.js/languages","stargazers_url":"https://api.github.com/repos/briandunn/ember.js/stargazers","contributors_url":"https://api.github.com/repos/briandunn/ember.js/contributors","subscribers_url":"https://api.github.com/repos/briandunn/ember.js/subscribers","subscription_url":"https://api.github.com/repos/briandunn/ember.js/subscription","commits_url":"https://api.github.com/repos/briandunn/ember.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/briandunn/ember.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/briandunn/ember.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/briandunn/ember.js/issues/comments/{number}","contents_url":"https://api.github.com/repos/briandunn/ember.js/contents/{+path}","compare_url":"https://api.github.com/repos/briandunn/ember.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/briandunn/ember.js/merges","archive_url":"https://api.github.com/repos/briandunn/ember.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/briandunn/ember.js/downloads","issues_url":"https://api.github.com/repos/briandunn/ember.js/issues{/number}","pulls_url":"https://api.github.com/repos/briandunn/ember.js/pulls{/number}","milestones_url":"https://api.github.com/repos/briandunn/ember.js/milestones{/number}","notifications_url":"https://api.github.com/repos/briandunn/ember.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/briandunn/ember.js/labels{/name}","releases_url":"https://api.github.com/repos/briandunn/ember.js/releases{/id}","created_at":"2014-09-11T15:21:34Z","updated_at":"2014-09-11T15:14:45Z","pushed_at":"2014-09-12T04:14:55Z","git_url":"git://github.com/briandunn/ember.js.git","ssh_url":"git@github.com:briandunn/ember.js.git","clone_url":"https://github.com/briandunn/ember.js.git","svn_url":"https://github.com/briandunn/ember.js","homepage":"http://www.emberjs.com","size":17124,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"emberjs:master","ref":"master","sha":"9620ae659b257946e583197906d0336ed9f4da88","user":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=2","gravatar_id":"792333d2bad390e8a2e23f5e2f41f214","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":1801829,"name":"ember.js","full_name":"emberjs/ember.js","owner":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=2","gravatar_id":"792333d2bad390e8a2e23f5e2f41f214","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emberjs/ember.js","description":"Ember.js - A JavaScript framework for creating ambitious web applications","fork":false,"url":"https://api.github.com/repos/emberjs/ember.js","forks_url":"https://api.github.com/repos/emberjs/ember.js/forks","keys_url":"https://api.github.com/repos/emberjs/ember.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emberjs/ember.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emberjs/ember.js/teams","hooks_url":"https://api.github.com/repos/emberjs/ember.js/hooks","issue_events_url":"https://api.github.com/repos/emberjs/ember.js/issues/events{/number}","events_url":"https://api.github.com/repos/emberjs/ember.js/events","assignees_url":"https://api.github.com/repos/emberjs/ember.js/assignees{/user}","branches_url":"https://api.github.com/repos/emberjs/ember.js/branches{/branch}","tags_url":"https://api.github.com/repos/emberjs/ember.js/tags","blobs_url":"https://api.github.com/repos/emberjs/ember.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emberjs/ember.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emberjs/ember.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/emberjs/ember.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emberjs/ember.js/statuses/{sha}","languages_url":"https://api.github.com/repos/emberjs/ember.js/languages","stargazers_url":"https://api.github.com/repos/emberjs/ember.js/stargazers","contributors_url":"https://api.github.com/repos/emberjs/ember.js/contributors","subscribers_url":"https://api.github.com/repos/emberjs/ember.js/subscribers","subscription_url":"https://api.github.com/repos/emberjs/ember.js/subscription","commits_url":"https://api.github.com/repos/emberjs/ember.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/emberjs/ember.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/emberjs/ember.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/emberjs/ember.js/issues/comments/{number}","contents_url":"https://api.github.com/repos/emberjs/ember.js/contents/{+path}","compare_url":"https://api.github.com/repos/emberjs/ember.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emberjs/ember.js/merges","archive_url":"https://api.github.com/repos/emberjs/ember.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emberjs/ember.js/downloads","issues_url":"https://api.github.com/repos/emberjs/ember.js/issues{/number}","pulls_url":"https://api.github.com/repos/emberjs/ember.js/pulls{/number}","milestones_url":"https://api.github.com/repos/emberjs/ember.js/milestones{/number}","notifications_url":"https://api.github.com/repos/emberjs/ember.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emberjs/ember.js/labels{/name}","releases_url":"https://api.github.com/repos/emberjs/ember.js/releases{/id}","created_at":"2011-05-25T23:39:40Z","updated_at":"2014-09-13T14:01:34Z","pushed_at":"2014-09-12T22:01:27Z","git_url":"git://github.com/emberjs/ember.js.git","ssh_url":"git@github.com:emberjs/ember.js.git","clone_url":"https://github.com/emberjs/ember.js.git","svn_url":"https://github.com/emberjs/ember.js","homepage":"http://www.emberjs.com","size":68654,"stargazers_count":11245,"watchers_count":11245,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":2435,"mirror_url":null,"open_issues_count":183,"forks":2435,"open_issues":183,"watchers":11245,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/5582"},"html":{"href":"https://github.com/emberjs/ember.js/pull/5582"},"issue":{"href":"https://api.github.com/repos/emberjs/ember.js/issues/5582"},"comments":{"href":"https://api.github.com/repos/emberjs/ember.js/issues/5582/comments"},"review_comments":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/5582/comments"},"review_comment":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/5582/commits"},"statuses":{"href":"https://api.github.com/repos/emberjs/ember.js/statuses/0a3dec675581ab2946aece53b250a10f954f1b2b"}}}}