GitHub PullRequestEvent at 2014-06-26 22:41:45
Repository: sparkgs
Actor: mattgode
Payload: {"action":"opened","number":1,"pull_request":{"url":"https://api.github.com/repos/sparkgs/sparkgs/pulls/1","id":17677625,"html_url":"https://github.com/sparkgs/sparkgs/pull/1","diff_url":"https://github.com/sparkgs/sparkgs/pull/1.diff","patch_url":"https://github.com/sparkgs/sparkgs/pull/1.patch","issue_url":"https://api.github.com/repos/sparkgs/sparkgs/issues/1","number":1,"state":"open","title":"Change in ordering of route generation ","user":{"login":"mattgode","id":5922425,"avatar_url":"https://avatars.githubusercontent.com/u/5922425?","gravatar_id":"068d7c66076bc2bd6b1a70865dc7d8a1","url":"https://api.github.com/users/mattgode","html_url":"https://github.com/mattgode","followers_url":"https://api.github.com/users/mattgode/followers","following_url":"https://api.github.com/users/mattgode/following{/other_user}","gists_url":"https://api.github.com/users/mattgode/gists{/gist_id}","starred_url":"https://api.github.com/users/mattgode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattgode/subscriptions","organizations_url":"https://api.github.com/users/mattgode/orgs","repos_url":"https://api.github.com/users/mattgode/repos","events_url":"https://api.github.com/users/mattgode/events{/privacy}","received_events_url":"https://api.github.com/users/mattgode/received_events","type":"User","site_admin":false},"body":"Routes appear to be evaluated in the order in which they are added in Spark Java. This was causing the /root/:id path to catch all paths that should have gone to methods with no arguments. For example, if there was a public method on a class that implements IResourceController with the definition function foo() {}, it should be accessible through the route /root/foo. This was being routed to show(id : String) instead. ","created_at":"2014-06-26T22:41:45Z","updated_at":"2014-06-26T22:41:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sparkgs/sparkgs/pulls/1/commits","review_comments_url":"https://api.github.com/repos/sparkgs/sparkgs/pulls/1/comments","review_comment_url":"https://api.github.com/repos/sparkgs/sparkgs/pulls/comments/{number}","comments_url":"https://api.github.com/repos/sparkgs/sparkgs/issues/1/comments","statuses_url":"https://api.github.com/repos/sparkgs/sparkgs/statuses/f287d7aac4cf20ee72c1248d364b48493ca11513","head":{"label":"mattgode:master","ref":"master","sha":"f287d7aac4cf20ee72c1248d364b48493ca11513","user":{"login":"mattgode","id":5922425,"avatar_url":"https://avatars.githubusercontent.com/u/5922425?","gravatar_id":"068d7c66076bc2bd6b1a70865dc7d8a1","url":"https://api.github.com/users/mattgode","html_url":"https://github.com/mattgode","followers_url":"https://api.github.com/users/mattgode/followers","following_url":"https://api.github.com/users/mattgode/following{/other_user}","gists_url":"https://api.github.com/users/mattgode/gists{/gist_id}","starred_url":"https://api.github.com/users/mattgode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattgode/subscriptions","organizations_url":"https://api.github.com/users/mattgode/orgs","repos_url":"https://api.github.com/users/mattgode/repos","events_url":"https://api.github.com/users/mattgode/events{/privacy}","received_events_url":"https://api.github.com/users/mattgode/received_events","type":"User","site_admin":false},"repo":{"id":21254808,"name":"sparkgs","full_name":"mattgode/sparkgs","owner":{"login":"mattgode","id":5922425,"avatar_url":"https://avatars.githubusercontent.com/u/5922425?","gravatar_id":"068d7c66076bc2bd6b1a70865dc7d8a1","url":"https://api.github.com/users/mattgode","html_url":"https://github.com/mattgode","followers_url":"https://api.github.com/users/mattgode/followers","following_url":"https://api.github.com/users/mattgode/following{/other_user}","gists_url":"https://api.github.com/users/mattgode/gists{/gist_id}","starred_url":"https://api.github.com/users/mattgode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattgode/subscriptions","organizations_url":"https://api.github.com/users/mattgode/orgs","repos_url":"https://api.github.com/users/mattgode/repos","events_url":"https://api.github.com/users/mattgode/events{/privacy}","received_events_url":"https://api.github.com/users/mattgode/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mattgode/sparkgs","description":"","fork":true,"url":"https://api.github.com/repos/mattgode/sparkgs","forks_url":"https://api.github.com/repos/mattgode/sparkgs/forks","keys_url":"https://api.github.com/repos/mattgode/sparkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattgode/sparkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattgode/sparkgs/teams","hooks_url":"https://api.github.com/repos/mattgode/sparkgs/hooks","issue_events_url":"https://api.github.com/repos/mattgode/sparkgs/issues/events{/number}","events_url":"https://api.github.com/repos/mattgode/sparkgs/events","assignees_url":"https://api.github.com/repos/mattgode/sparkgs/assignees{/user}","branches_url":"https://api.github.com/repos/mattgode/sparkgs/branches{/branch}","tags_url":"https://api.github.com/repos/mattgode/sparkgs/tags","blobs_url":"https://api.github.com/repos/mattgode/sparkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattgode/sparkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattgode/sparkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattgode/sparkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattgode/sparkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/mattgode/sparkgs/languages","stargazers_url":"https://api.github.com/repos/mattgode/sparkgs/stargazers","contributors_url":"https://api.github.com/repos/mattgode/sparkgs/contributors","subscribers_url":"https://api.github.com/repos/mattgode/sparkgs/subscribers","subscription_url":"https://api.github.com/repos/mattgode/sparkgs/subscription","commits_url":"https://api.github.com/repos/mattgode/sparkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattgode/sparkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattgode/sparkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattgode/sparkgs/issues/comments/{number}","contents_url":"https://api.github.com/repos/mattgode/sparkgs/contents/{+path}","compare_url":"https://api.github.com/repos/mattgode/sparkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattgode/sparkgs/merges","archive_url":"https://api.github.com/repos/mattgode/sparkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattgode/sparkgs/downloads","issues_url":"https://api.github.com/repos/mattgode/sparkgs/issues{/number}","pulls_url":"https://api.github.com/repos/mattgode/sparkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/mattgode/sparkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/mattgode/sparkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattgode/sparkgs/labels{/name}","releases_url":"https://api.github.com/repos/mattgode/sparkgs/releases{/id}","created_at":"2014-06-26T20:56:33Z","updated_at":"2014-06-04T22:49:31Z","pushed_at":"2014-06-26T22:35:46Z","git_url":"git://github.com/mattgode/sparkgs.git","ssh_url":"git@github.com:mattgode/sparkgs.git","clone_url":"https://github.com/mattgode/sparkgs.git","svn_url":"https://github.com/mattgode/sparkgs","homepage":null,"size":320,"stargazers_count":0,"watchers_count":0,"language":"Gosu","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sparkgs:master","ref":"master","sha":"1deea0a1448b127414e2c480b19000e66264c5b3","user":{"login":"sparkgs","id":6892373,"avatar_url":"https://avatars.githubusercontent.com/u/6892373?","gravatar_id":null,"url":"https://api.github.com/users/sparkgs","html_url":"https://github.com/sparkgs","followers_url":"https://api.github.com/users/sparkgs/followers","following_url":"https://api.github.com/users/sparkgs/following{/other_user}","gists_url":"https://api.github.com/users/sparkgs/gists{/gist_id}","starred_url":"https://api.github.com/users/sparkgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sparkgs/subscriptions","organizations_url":"https://api.github.com/users/sparkgs/orgs","repos_url":"https://api.github.com/users/sparkgs/repos","events_url":"https://api.github.com/users/sparkgs/events{/privacy}","received_events_url":"https://api.github.com/users/sparkgs/received_events","type":"Organization","site_admin":false},"repo":{"id":17609905,"name":"sparkgs","full_name":"sparkgs/sparkgs","owner":{"login":"sparkgs","id":6892373,"avatar_url":"https://avatars.githubusercontent.com/u/6892373?","gravatar_id":null,"url":"https://api.github.com/users/sparkgs","html_url":"https://github.com/sparkgs","followers_url":"https://api.github.com/users/sparkgs/followers","following_url":"https://api.github.com/users/sparkgs/following{/other_user}","gists_url":"https://api.github.com/users/sparkgs/gists{/gist_id}","starred_url":"https://api.github.com/users/sparkgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sparkgs/subscriptions","organizations_url":"https://api.github.com/users/sparkgs/orgs","repos_url":"https://api.github.com/users/sparkgs/repos","events_url":"https://api.github.com/users/sparkgs/events{/privacy}","received_events_url":"https://api.github.com/users/sparkgs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sparkgs/sparkgs","description":"","fork":false,"url":"https://api.github.com/repos/sparkgs/sparkgs","forks_url":"https://api.github.com/repos/sparkgs/sparkgs/forks","keys_url":"https://api.github.com/repos/sparkgs/sparkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sparkgs/sparkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sparkgs/sparkgs/teams","hooks_url":"https://api.github.com/repos/sparkgs/sparkgs/hooks","issue_events_url":"https://api.github.com/repos/sparkgs/sparkgs/issues/events{/number}","events_url":"https://api.github.com/repos/sparkgs/sparkgs/events","assignees_url":"https://api.github.com/repos/sparkgs/sparkgs/assignees{/user}","branches_url":"https://api.github.com/repos/sparkgs/sparkgs/branches{/branch}","tags_url":"https://api.github.com/repos/sparkgs/sparkgs/tags","blobs_url":"https://api.github.com/repos/sparkgs/sparkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sparkgs/sparkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sparkgs/sparkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/sparkgs/sparkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sparkgs/sparkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/sparkgs/sparkgs/languages","stargazers_url":"https://api.github.com/repos/sparkgs/sparkgs/stargazers","contributors_url":"https://api.github.com/repos/sparkgs/sparkgs/contributors","subscribers_url":"https://api.github.com/repos/sparkgs/sparkgs/subscribers","subscription_url":"https://api.github.com/repos/sparkgs/sparkgs/subscription","commits_url":"https://api.github.com/repos/sparkgs/sparkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/sparkgs/sparkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/sparkgs/sparkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/sparkgs/sparkgs/issues/comments/{number}","contents_url":"https://api.github.com/repos/sparkgs/sparkgs/contents/{+path}","compare_url":"https://api.github.com/repos/sparkgs/sparkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sparkgs/sparkgs/merges","archive_url":"https://api.github.com/repos/sparkgs/sparkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sparkgs/sparkgs/downloads","issues_url":"https://api.github.com/repos/sparkgs/sparkgs/issues{/number}","pulls_url":"https://api.github.com/repos/sparkgs/sparkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/sparkgs/sparkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/sparkgs/sparkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sparkgs/sparkgs/labels{/name}","releases_url":"https://api.github.com/repos/sparkgs/sparkgs/releases{/id}","created_at":"2014-03-10T21:52:34Z","updated_at":"2014-06-04T22:49:31Z","pushed_at":"2014-06-04T22:49:31Z","git_url":"git://github.com/sparkgs/sparkgs.git","ssh_url":"git@github.com:sparkgs/sparkgs.git","clone_url":"https://github.com/sparkgs/sparkgs.git","svn_url":"https://github.com/sparkgs/sparkgs","homepage":null,"size":320,"stargazers_count":0,"watchers_count":0,"language":"Gosu","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sparkgs/sparkgs/pulls/1"},"html":{"href":"https://github.com/sparkgs/sparkgs/pull/1"},"issue":{"href":"https://api.github.com/repos/sparkgs/sparkgs/issues/1"},"comments":{"href":"https://api.github.com/repos/sparkgs/sparkgs/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/sparkgs/sparkgs/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/sparkgs/sparkgs/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/sparkgs/sparkgs/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/sparkgs/sparkgs/statuses/f287d7aac4cf20ee72c1248d364b48493ca11513"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":5,"deletions":5,"changed_files":1}}