GitHub PullRequestReviewCommentEvent at 2014-01-17 05:53:48
Repository: hibernate-orm
Actor: brmeyer
Payload: {"comment":{"url":"https://api.github.com/repos/hibernate/hibernate-orm/pulls/comments/8957871","id":8957871,"diff_hunk":"@@ -87,11 +87,6 @@ public Oracle9Dialect() {\n \t\tregisterColumnType( Types.BLOB, \"blob\" );\n \t\tregisterColumnType( Types.CLOB, \"clob\" );\n \n-\t\t// Oracle driver reports to support getGeneratedKeys(), but they only\n-\t\t// support the version taking an array of the names of the columns to\n-\t\t// be returned (via its RETURNING clause).  No other driver seems to\n-\t\t// support this overloaded version.\n-\t\tgetDefaultProperties().setProperty( Environment.USE_GET_GENERATED_KEYS, \"false\" );","path":"hibernate-core/src/main/java/org/hibernate/dialect/Oracle9Dialect.java","position":8,"original_position":8,"commit_id":"02c9efbcaddf2169ed7f9cf6f4184a7926426fea","original_commit_id":"02c9efbcaddf2169ed7f9cf6f4184a7926426fea","user":{"login":"brmeyer","id":812741,"avatar_url":"https://gravatar.com/avatar/bfda4c8ce231d748d1123620ca048231?d=https%3A%2F%2Fidenticons.github.com%2Fb8c1db064250580cb53cca889c3e2a27.png&r=x","gravatar_id":"bfda4c8ce231d748d1123620ca048231","url":"https://api.github.com/users/brmeyer","html_url":"https://github.com/brmeyer","followers_url":"https://api.github.com/users/brmeyer/followers","following_url":"https://api.github.com/users/brmeyer/following{/other_user}","gists_url":"https://api.github.com/users/brmeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/brmeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brmeyer/subscriptions","organizations_url":"https://api.github.com/users/brmeyer/orgs","repos_url":"https://api.github.com/users/brmeyer/repos","events_url":"https://api.github.com/users/brmeyer/events{/privacy}","received_events_url":"https://api.github.com/users/brmeyer/received_events","type":"User","site_admin":false},"body":"Is this changed needed only for Oracle 12?  Worried about removing it for all Oracle Dialects.  Instead, override registerDefaultProperties in Oracle12cDialect?","created_at":"2014-01-17T05:53:48Z","updated_at":"2014-01-17T05:53:48Z","html_url":"https://github.com/hibernate/hibernate-orm/pull/652#discussion_r8957871","pull_request_url":"https://api.github.com/repos/hibernate/hibernate-orm/pulls/652","_links":{"self":{"href":"https://api.github.com/repos/hibernate/hibernate-orm/pulls/comments/8957871"},"html":{"href":"https://github.com/hibernate/hibernate-orm/pull/652#discussion_r8957871"},"pull_request":{"href":"https://api.github.com/repos/hibernate/hibernate-orm/pulls/652"}}}}