GitHub PullRequestEvent at 2014-05-23 22:38:58
Repository: splitlog
Actor: triceo
Payload: {"action":"opened","number":55,"pull_request":{"url":"https://api.github.com/repos/triceo/splitlog/pulls/55","id":16298205,"html_url":"https://github.com/triceo/splitlog/pull/55","diff_url":"https://github.com/triceo/splitlog/pull/55.diff","patch_url":"https://github.com/triceo/splitlog/pull/55.patch","issue_url":"https://api.github.com/repos/triceo/splitlog/issues/55","number":55,"state":"open","title":"Greatly reduced the number of INCOMING messages","user":{"login":"triceo","id":247403,"avatar_url":"https://avatars.githubusercontent.com/u/247403?","gravatar_id":"c950743f532471ac34022e92193563c3","url":"https://api.github.com/users/triceo","html_url":"https://github.com/triceo","followers_url":"https://api.github.com/users/triceo/followers","following_url":"https://api.github.com/users/triceo/following{/other_user}","gists_url":"https://api.github.com/users/triceo/gists{/gist_id}","starred_url":"https://api.github.com/users/triceo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/triceo/subscriptions","organizations_url":"https://api.github.com/users/triceo/orgs","repos_url":"https://api.github.com/users/triceo/repos","events_url":"https://api.github.com/users/triceo/events{/privacy}","received_events_url":"https://api.github.com/users/triceo/received_events","type":"User","site_admin":false},"body":"The way tailing works, it reads files in burts with delays between them. In practice, this results in multiple lines of the file being read at once, and then no lines being read.\r\n\r\nUntil now, *Splitlog* has processed each line separately and waited for the next line to decide whether the previous line is already a full message. And before that next line arrived, it sent the previous line as ```MessageDeliveryStatus.INCOMING```. This behavior wasn't very easy to explain and it certainly was not expected by users of the tool.\r\n\r\nWith the recent refactoring of the Tailer, we are now able to tell when the read burst starts and when it ends. Therefore, between these two events, we will not emit ```INCOMING``` messages. Instead, we will buffer the lines for as long as we can. The only time that Splitlog will now emit an ```INCOMING``` message would be at the end of a burst, when the last line being read couldn't be identified as an end of a message. \r\n\r\nFurthermore, the last message before the tailing is terminated will now also be transformed to either ```ACCEPTED``` or ```REJECTED```. Until now, it was only ever ```INCOMING```.\r\n\r\nThis pull request changes the way that *Splitlog* works in a manner that is backwards compatible. Users will only be affected if they are specifically binding their Expectations and Metrics to the ```INCOMING``` messages.","created_at":"2014-05-23T22:38:58Z","updated_at":"2014-05-23T22:38:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/triceo/splitlog/pulls/55/commits","review_comments_url":"https://api.github.com/repos/triceo/splitlog/pulls/55/comments","review_comment_url":"https://api.github.com/repos/triceo/splitlog/pulls/comments/{number}","comments_url":"https://api.github.com/repos/triceo/splitlog/issues/55/comments","statuses_url":"https://api.github.com/repos/triceo/splitlog/statuses/7d6c38a437160f1c769574623dce0c87e5f045f2","head":{"label":"triceo:lookahead","ref":"lookahead","sha":"7d6c38a437160f1c769574623dce0c87e5f045f2","user":{"login":"triceo","id":247403,"avatar_url":"https://avatars.githubusercontent.com/u/247403?","gravatar_id":"c950743f532471ac34022e92193563c3","url":"https://api.github.com/users/triceo","html_url":"https://github.com/triceo","followers_url":"https://api.github.com/users/triceo/followers","following_url":"https://api.github.com/users/triceo/following{/other_user}","gists_url":"https://api.github.com/users/triceo/gists{/gist_id}","starred_url":"https://api.github.com/users/triceo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/triceo/subscriptions","organizations_url":"https://api.github.com/users/triceo/orgs","repos_url":"https://api.github.com/users/triceo/repos","events_url":"https://api.github.com/users/triceo/events{/privacy}","received_events_url":"https://api.github.com/users/triceo/received_events","type":"User","site_admin":false},"repo":{"id":16359940,"name":"splitlog","full_name":"triceo/splitlog","owner":{"login":"triceo","id":247403,"avatar_url":"https://avatars.githubusercontent.com/u/247403?","gravatar_id":"c950743f532471ac34022e92193563c3","url":"https://api.github.com/users/triceo","html_url":"https://github.com/triceo","followers_url":"https://api.github.com/users/triceo/followers","following_url":"https://api.github.com/users/triceo/following{/other_user}","gists_url":"https://api.github.com/users/triceo/gists{/gist_id}","starred_url":"https://api.github.com/users/triceo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/triceo/subscriptions","organizations_url":"https://api.github.com/users/triceo/orgs","repos_url":"https://api.github.com/users/triceo/repos","events_url":"https://api.github.com/users/triceo/events{/privacy}","received_events_url":"https://api.github.com/users/triceo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/triceo/splitlog","description":"Tool to monitor log files from your Java applications as they fill.","fork":false,"url":"https://api.github.com/repos/triceo/splitlog","forks_url":"https://api.github.com/repos/triceo/splitlog/forks","keys_url":"https://api.github.com/repos/triceo/splitlog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/triceo/splitlog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/triceo/splitlog/teams","hooks_url":"https://api.github.com/repos/triceo/splitlog/hooks","issue_events_url":"https://api.github.com/repos/triceo/splitlog/issues/events{/number}","events_url":"https://api.github.com/repos/triceo/splitlog/events","assignees_url":"https://api.github.com/repos/triceo/splitlog/assignees{/user}","branches_url":"https://api.github.com/repos/triceo/splitlog/branches{/branch}","tags_url":"https://api.github.com/repos/triceo/splitlog/tags","blobs_url":"https://api.github.com/repos/triceo/splitlog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/triceo/splitlog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/triceo/splitlog/git/refs{/sha}","trees_url":"https://api.github.com/repos/triceo/splitlog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/triceo/splitlog/statuses/{sha}","languages_url":"https://api.github.com/repos/triceo/splitlog/languages","stargazers_url":"https://api.github.com/repos/triceo/splitlog/stargazers","contributors_url":"https://api.github.com/repos/triceo/splitlog/contributors","subscribers_url":"https://api.github.com/repos/triceo/splitlog/subscribers","subscription_url":"https://api.github.com/repos/triceo/splitlog/subscription","commits_url":"https://api.github.com/repos/triceo/splitlog/commits{/sha}","git_commits_url":"https://api.github.com/repos/triceo/splitlog/git/commits{/sha}","comments_url":"https://api.github.com/repos/triceo/splitlog/comments{/number}","issue_comment_url":"https://api.github.com/repos/triceo/splitlog/issues/comments/{number}","contents_url":"https://api.github.com/repos/triceo/splitlog/contents/{+path}","compare_url":"https://api.github.com/repos/triceo/splitlog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/triceo/splitlog/merges","archive_url":"https://api.github.com/repos/triceo/splitlog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/triceo/splitlog/downloads","issues_url":"https://api.github.com/repos/triceo/splitlog/issues{/number}","pulls_url":"https://api.github.com/repos/triceo/splitlog/pulls{/number}","milestones_url":"https://api.github.com/repos/triceo/splitlog/milestones{/number}","notifications_url":"https://api.github.com/repos/triceo/splitlog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/triceo/splitlog/labels{/name}","releases_url":"https://api.github.com/repos/triceo/splitlog/releases{/id}","created_at":"2014-01-29T21:38:11Z","updated_at":"2014-05-23T22:38:58Z","pushed_at":"2014-05-23T22:30:34Z","git_url":"git://github.com/triceo/splitlog.git","ssh_url":"git@github.com:triceo/splitlog.git","clone_url":"https://github.com/triceo/splitlog.git","svn_url":"https://github.com/triceo/splitlog","homepage":"http://triceo.github.io/splitlog/","size":9118,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":2,"default_branch":"master"}},"base":{"label":"triceo:master","ref":"master","sha":"04a64ed6721bc3644fda9a1fd2c5d47296a26548","user":{"login":"triceo","id":247403,"avatar_url":"https://avatars.githubusercontent.com/u/247403?","gravatar_id":"c950743f532471ac34022e92193563c3","url":"https://api.github.com/users/triceo","html_url":"https://github.com/triceo","followers_url":"https://api.github.com/users/triceo/followers","following_url":"https://api.github.com/users/triceo/following{/other_user}","gists_url":"https://api.github.com/users/triceo/gists{/gist_id}","starred_url":"https://api.github.com/users/triceo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/triceo/subscriptions","organizations_url":"https://api.github.com/users/triceo/orgs","repos_url":"https://api.github.com/users/triceo/repos","events_url":"https://api.github.com/users/triceo/events{/privacy}","received_events_url":"https://api.github.com/users/triceo/received_events","type":"User","site_admin":false},"repo":{"id":16359940,"name":"splitlog","full_name":"triceo/splitlog","owner":{"login":"triceo","id":247403,"avatar_url":"https://avatars.githubusercontent.com/u/247403?","gravatar_id":"c950743f532471ac34022e92193563c3","url":"https://api.github.com/users/triceo","html_url":"https://github.com/triceo","followers_url":"https://api.github.com/users/triceo/followers","following_url":"https://api.github.com/users/triceo/following{/other_user}","gists_url":"https://api.github.com/users/triceo/gists{/gist_id}","starred_url":"https://api.github.com/users/triceo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/triceo/subscriptions","organizations_url":"https://api.github.com/users/triceo/orgs","repos_url":"https://api.github.com/users/triceo/repos","events_url":"https://api.github.com/users/triceo/events{/privacy}","received_events_url":"https://api.github.com/users/triceo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/triceo/splitlog","description":"Tool to monitor log files from your Java applications as they fill.","fork":false,"url":"https://api.github.com/repos/triceo/splitlog","forks_url":"https://api.github.com/repos/triceo/splitlog/forks","keys_url":"https://api.github.com/repos/triceo/splitlog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/triceo/splitlog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/triceo/splitlog/teams","hooks_url":"https://api.github.com/repos/triceo/splitlog/hooks","issue_events_url":"https://api.github.com/repos/triceo/splitlog/issues/events{/number}","events_url":"https://api.github.com/repos/triceo/splitlog/events","assignees_url":"https://api.github.com/repos/triceo/splitlog/assignees{/user}","branches_url":"https://api.github.com/repos/triceo/splitlog/branches{/branch}","tags_url":"https://api.github.com/repos/triceo/splitlog/tags","blobs_url":"https://api.github.com/repos/triceo/splitlog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/triceo/splitlog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/triceo/splitlog/git/refs{/sha}","trees_url":"https://api.github.com/repos/triceo/splitlog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/triceo/splitlog/statuses/{sha}","languages_url":"https://api.github.com/repos/triceo/splitlog/languages","stargazers_url":"https://api.github.com/repos/triceo/splitlog/stargazers","contributors_url":"https://api.github.com/repos/triceo/splitlog/contributors","subscribers_url":"https://api.github.com/repos/triceo/splitlog/subscribers","subscription_url":"https://api.github.com/repos/triceo/splitlog/subscription","commits_url":"https://api.github.com/repos/triceo/splitlog/commits{/sha}","git_commits_url":"https://api.github.com/repos/triceo/splitlog/git/commits{/sha}","comments_url":"https://api.github.com/repos/triceo/splitlog/comments{/number}","issue_comment_url":"https://api.github.com/repos/triceo/splitlog/issues/comments/{number}","contents_url":"https://api.github.com/repos/triceo/splitlog/contents/{+path}","compare_url":"https://api.github.com/repos/triceo/splitlog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/triceo/splitlog/merges","archive_url":"https://api.github.com/repos/triceo/splitlog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/triceo/splitlog/downloads","issues_url":"https://api.github.com/repos/triceo/splitlog/issues{/number}","pulls_url":"https://api.github.com/repos/triceo/splitlog/pulls{/number}","milestones_url":"https://api.github.com/repos/triceo/splitlog/milestones{/number}","notifications_url":"https://api.github.com/repos/triceo/splitlog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/triceo/splitlog/labels{/name}","releases_url":"https://api.github.com/repos/triceo/splitlog/releases{/id}","created_at":"2014-01-29T21:38:11Z","updated_at":"2014-05-23T22:38:58Z","pushed_at":"2014-05-23T22:30:34Z","git_url":"git://github.com/triceo/splitlog.git","ssh_url":"git@github.com:triceo/splitlog.git","clone_url":"https://github.com/triceo/splitlog.git","svn_url":"https://github.com/triceo/splitlog","homepage":"http://triceo.github.io/splitlog/","size":9118,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/triceo/splitlog/pulls/55"},"html":{"href":"https://github.com/triceo/splitlog/pull/55"},"issue":{"href":"https://api.github.com/repos/triceo/splitlog/issues/55"},"comments":{"href":"https://api.github.com/repos/triceo/splitlog/issues/55/comments"},"review_comments":{"href":"https://api.github.com/repos/triceo/splitlog/pulls/55/comments"},"review_comment":{"href":"https://api.github.com/repos/triceo/splitlog/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/triceo/splitlog/pulls/55/commits"},"statuses":{"href":"https://api.github.com/repos/triceo/splitlog/statuses/7d6c38a437160f1c769574623dce0c87e5f045f2"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":7,"additions":315,"deletions":183,"changed_files":14}}