GitHub PullRequestReviewCommentEvent at 2014-05-07 15:47:43
Repository: engine-mode
Actor: hrs
Payload: {"comment":{"url":"https://api.github.com/repos/hrs/engine-mode/pulls/comments/12384820","id":12384820,"diff_hunk":"@@ -86,14 +87,15 @@\n        (quote ,(engine/function-name engine-name)))))\n \n (defmacro defengine (engine-name search-engine-url &optional keybinding)\n-  (let ((evaled-engine-name engine-name)\n-        (search-term (gensym)))\n-    `(progn (defun ,(engine/function-name evaled-engine-name) (,search-term)\n-              ,(engine/docstring evaled-engine-name)\n-              (interactive\n-               (list (engine/get-query ,(symbol-name evaled-engine-name))))\n-              (engine/execute-search ,search-engine-url ,search-term))\n-            ,(engine/bind-key evaled-engine-name keybinding))))\n+  (assert (symbolp engine-name))","path":"engine-mode.el","position":29,"original_position":29,"commit_id":"3ecd9f864dc415c0ac7a94a7ce1cd157d16b7f68","original_commit_id":"3ecd9f864dc415c0ac7a94a7ce1cd157d16b7f68","user":{"login":"hrs","id":278853,"avatar_url":"https://avatars.githubusercontent.com/u/278853?","gravatar_id":"40d9a03d29a80414bea7a23cb915d573","url":"https://api.github.com/users/hrs","html_url":"https://github.com/hrs","followers_url":"https://api.github.com/users/hrs/followers","following_url":"https://api.github.com/users/hrs/following{/other_user}","gists_url":"https://api.github.com/users/hrs/gists{/gist_id}","starred_url":"https://api.github.com/users/hrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hrs/subscriptions","organizations_url":"https://api.github.com/users/hrs/orgs","repos_url":"https://api.github.com/users/hrs/repos","events_url":"https://api.github.com/users/hrs/events{/privacy}","received_events_url":"https://api.github.com/users/hrs/received_events","type":"User","site_admin":false},"body":"Would it be better to use the `cl-` prefixed functions for stuff from `cl`?","created_at":"2014-05-07T15:47:43Z","updated_at":"2014-05-07T15:47:43Z","html_url":"https://github.com/hrs/engine-mode/pull/1#discussion_r12384820","pull_request_url":"https://api.github.com/repos/hrs/engine-mode/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/hrs/engine-mode/pulls/comments/12384820"},"html":{"href":"https://github.com/hrs/engine-mode/pull/1#discussion_r12384820"},"pull_request":{"href":"https://api.github.com/repos/hrs/engine-mode/pulls/1"}}}}