GitHub PullRequestEvent at 2014-12-11 21:27:37
Repository: azure-sdk-for-node
Actor: weswigham
Payload: {"action":"opened","number":1362,"pull_request":{"url":"https://api.github.com/repos/Azure/azure-sdk-for-node/pulls/1362","id":25933512,"html_url":"https://github.com/Azure/azure-sdk-for-node/pull/1362","diff_url":"https://github.com/Azure/azure-sdk-for-node/pull/1362.diff","patch_url":"https://github.com/Azure/azure-sdk-for-node/pull/1362.patch","issue_url":"https://api.github.com/repos/Azure/azure-sdk-for-node/issues/1362","number":1362,"state":"open","locked":false,"title":"Swallow EPIPE errors","user":{"login":"weswigham","id":2932786,"avatar_url":"https://avatars.githubusercontent.com/u/2932786?v=3","gravatar_id":"","url":"https://api.github.com/users/weswigham","html_url":"https://github.com/weswigham","followers_url":"https://api.github.com/users/weswigham/followers","following_url":"https://api.github.com/users/weswigham/following{/other_user}","gists_url":"https://api.github.com/users/weswigham/gists{/gist_id}","starred_url":"https://api.github.com/users/weswigham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weswigham/subscriptions","organizations_url":"https://api.github.com/users/weswigham/orgs","repos_url":"https://api.github.com/users/weswigham/repos","events_url":"https://api.github.com/users/weswigham/events{/privacy}","received_events_url":"https://api.github.com/users/weswigham/received_events","type":"User","site_admin":false},"body":" When thrown in a named pipe input channel - usually on pipe connection end. \r\n\r\nUnder the current scheme, functions like `RoleEnvironment.getConfigurationSettings` take a callback which handles an error or a success. Except there's a problem - assuming you do handle the error (and don't kill the process because of it) the handler will get called TWICE. And the second time will be with the actual configuration data (as the first was passed the EPIPE shutdown that was thrown). \r\n\r\nWhile, for a lot of architectures, this simply means the EPIPE error gets logged or otherwise dealt with, then data handled, this is unacceptable when wrapping the API in promises, ala `Promise.denodify`. If I'm not mistaken, many of these callbacks are meant to be triggered once and considered done - not reused.\r\n\r\nThis might not be the way to change this to support this, but considering a `shutdown EPIPE` is always thrown on connection close (which `NamedPipeInputChannel` does automatically), it's probably not the worst idea.\r\n\r\nThough, this may also be a good opportunity to ask how anyone feels about updating the API to work with promises correctly, rather than needing to wrap it.","created_at":"2014-12-11T21:27:36Z","updated_at":"2014-12-11T21:27:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-sdk-for-node/pulls/1362/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-sdk-for-node/pulls/1362/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-sdk-for-node/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Azure/azure-sdk-for-node/issues/1362/comments","statuses_url":"https://api.github.com/repos/Azure/azure-sdk-for-node/statuses/3e36268625016c49966eed60b9ded5cb8cfb0478","head":{"label":"weswigham:patch-1","ref":"patch-1","sha":"3e36268625016c49966eed60b9ded5cb8cfb0478","user":{"login":"weswigham","id":2932786,"avatar_url":"https://avatars.githubusercontent.com/u/2932786?v=3","gravatar_id":"","url":"https://api.github.com/users/weswigham","html_url":"https://github.com/weswigham","followers_url":"https://api.github.com/users/weswigham/followers","following_url":"https://api.github.com/users/weswigham/following{/other_user}","gists_url":"https://api.github.com/users/weswigham/gists{/gist_id}","starred_url":"https://api.github.com/users/weswigham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weswigham/subscriptions","organizations_url":"https://api.github.com/users/weswigham/orgs","repos_url":"https://api.github.com/users/weswigham/repos","events_url":"https://api.github.com/users/weswigham/events{/privacy}","received_events_url":"https://api.github.com/users/weswigham/received_events","type":"User","site_admin":false},"repo":{"id":27892020,"name":"azure-sdk-for-node","full_name":"weswigham/azure-sdk-for-node","owner":{"login":"weswigham","id":2932786,"avatar_url":"https://avatars.githubusercontent.com/u/2932786?v=3","gravatar_id":"","url":"https://api.github.com/users/weswigham","html_url":"https://github.com/weswigham","followers_url":"https://api.github.com/users/weswigham/followers","following_url":"https://api.github.com/users/weswigham/following{/other_user}","gists_url":"https://api.github.com/users/weswigham/gists{/gist_id}","starred_url":"https://api.github.com/users/weswigham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weswigham/subscriptions","organizations_url":"https://api.github.com/users/weswigham/orgs","repos_url":"https://api.github.com/users/weswigham/repos","events_url":"https://api.github.com/users/weswigham/events{/privacy}","received_events_url":"https://api.github.com/users/weswigham/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/weswigham/azure-sdk-for-node","description":"Microsoft Azure SDK for Node.js","fork":true,"url":"https://api.github.com/repos/weswigham/azure-sdk-for-node","forks_url":"https://api.github.com/repos/weswigham/azure-sdk-for-node/forks","keys_url":"https://api.github.com/repos/weswigham/azure-sdk-for-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weswigham/azure-sdk-for-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weswigham/azure-sdk-for-node/teams","hooks_url":"https://api.github.com/repos/weswigham/azure-sdk-for-node/hooks","issue_events_url":"https://api.github.com/repos/weswigham/azure-sdk-for-node/issues/events{/number}","events_url":"https://api.github.com/repos/weswigham/azure-sdk-for-node/events","assignees_url":"https://api.github.com/repos/weswigham/azure-sdk-for-node/assignees{/user}","branches_url":"https://api.github.com/repos/weswigham/azure-sdk-for-node/branches{/branch}","tags_url":"https://api.github.com/repos/weswigham/azure-sdk-for-node/tags","blobs_url":"https://api.github.com/repos/weswigham/azure-sdk-for-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weswigham/azure-sdk-for-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weswigham/azure-sdk-for-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/weswigham/azure-sdk-for-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weswigham/azure-sdk-for-node/statuses/{sha}","languages_url":"https://api.github.com/repos/weswigham/azure-sdk-for-node/languages","stargazers_url":"https://api.github.com/repos/weswigham/azure-sdk-for-node/stargazers","contributors_url":"https://api.github.com/repos/weswigham/azure-sdk-for-node/contributors","subscribers_url":"https://api.github.com/repos/weswigham/azure-sdk-for-node/subscribers","subscription_url":"https://api.github.com/repos/weswigham/azure-sdk-for-node/subscription","commits_url":"https://api.github.com/repos/weswigham/azure-sdk-for-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/weswigham/azure-sdk-for-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/weswigham/azure-sdk-for-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/weswigham/azure-sdk-for-node/issues/comments/{number}","contents_url":"https://api.github.com/repos/weswigham/azure-sdk-for-node/contents/{+path}","compare_url":"https://api.github.com/repos/weswigham/azure-sdk-for-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weswigham/azure-sdk-for-node/merges","archive_url":"https://api.github.com/repos/weswigham/azure-sdk-for-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weswigham/azure-sdk-for-node/downloads","issues_url":"https://api.github.com/repos/weswigham/azure-sdk-for-node/issues{/number}","pulls_url":"https://api.github.com/repos/weswigham/azure-sdk-for-node/pulls{/number}","milestones_url":"https://api.github.com/repos/weswigham/azure-sdk-for-node/milestones{/number}","notifications_url":"https://api.github.com/repos/weswigham/azure-sdk-for-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weswigham/azure-sdk-for-node/labels{/name}","releases_url":"https://api.github.com/repos/weswigham/azure-sdk-for-node/releases{/id}","created_at":"2014-12-11T21:16:05Z","updated_at":"2014-12-11T21:16:08Z","pushed_at":"2014-12-11T21:26:35Z","git_url":"git://github.com/weswigham/azure-sdk-for-node.git","ssh_url":"git@github.com:weswigham/azure-sdk-for-node.git","clone_url":"https://github.com/weswigham/azure-sdk-for-node.git","svn_url":"https://github.com/weswigham/azure-sdk-for-node","homepage":"http://azure.microsoft.com/en-us/develop/nodejs/","size":18667,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"a39018205669b33dd9b89b08d29fb4fadd5eb0d1","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":2950981,"name":"azure-sdk-for-node","full_name":"Azure/azure-sdk-for-node","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-sdk-for-node","description":"Microsoft Azure SDK for Node.js","fork":false,"url":"https://api.github.com/repos/Azure/azure-sdk-for-node","forks_url":"https://api.github.com/repos/Azure/azure-sdk-for-node/forks","keys_url":"https://api.github.com/repos/Azure/azure-sdk-for-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-sdk-for-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-sdk-for-node/teams","hooks_url":"https://api.github.com/repos/Azure/azure-sdk-for-node/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-sdk-for-node/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-sdk-for-node/events","assignees_url":"https://api.github.com/repos/Azure/azure-sdk-for-node/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-sdk-for-node/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-sdk-for-node/tags","blobs_url":"https://api.github.com/repos/Azure/azure-sdk-for-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-sdk-for-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-sdk-for-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-sdk-for-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-sdk-for-node/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-sdk-for-node/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-sdk-for-node/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-sdk-for-node/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-sdk-for-node/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-sdk-for-node/subscription","commits_url":"https://api.github.com/repos/Azure/azure-sdk-for-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-sdk-for-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-sdk-for-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-sdk-for-node/issues/comments/{number}","contents_url":"https://api.github.com/repos/Azure/azure-sdk-for-node/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-sdk-for-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-sdk-for-node/merges","archive_url":"https://api.github.com/repos/Azure/azure-sdk-for-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-sdk-for-node/downloads","issues_url":"https://api.github.com/repos/Azure/azure-sdk-for-node/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-sdk-for-node/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-sdk-for-node/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-sdk-for-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-sdk-for-node/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-sdk-for-node/releases{/id}","created_at":"2011-12-09T23:38:42Z","updated_at":"2014-12-10T00:22:33Z","pushed_at":"2014-12-03T18:10:40Z","git_url":"git://github.com/Azure/azure-sdk-for-node.git","ssh_url":"git@github.com:Azure/azure-sdk-for-node.git","clone_url":"https://github.com/Azure/azure-sdk-for-node.git","svn_url":"https://github.com/Azure/azure-sdk-for-node","homepage":"http://azure.microsoft.com/en-us/develop/nodejs/","size":18667,"stargazers_count":567,"watchers_count":567,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":183,"mirror_url":null,"open_issues_count":23,"forks":183,"open_issues":23,"watchers":567,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-node/pulls/1362"},"html":{"href":"https://github.com/Azure/azure-sdk-for-node/pull/1362"},"issue":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-node/issues/1362"},"comments":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-node/issues/1362/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-node/pulls/1362/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-node/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-node/pulls/1362/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-node/statuses/3e36268625016c49966eed60b9ded5cb8cfb0478"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":1,"changed_files":1}}