GitHub PullRequestReviewCommentEvent at 2014-12-21 05:52:46
Repository: spree
Actor: houndci
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/spree/spree/pulls/comments/22145924","id":22145924,"diff_hunk":"@@ -2,15 +2,15 @@\n require 'shared_examples/protect_product_actions'\n \n module Spree\n-  describe Spree::Api::ProductPropertiesController, :type => :controller do\n+  describe Spree::Api::ProductPropertiesController, type: :controller do\n     render_views\n \n     let!(:product) { create(:product) }\n-    let!(:property_1) {product.product_properties.create(:property_name => \"My Property 1\", :value => \"my value 1\", :position => 0)}\n-    let!(:property_2) {product.product_properties.create(:property_name => \"My Property 2\", :value => \"my value 2\", :position => 1)}\n+    let!(:property_1) { product.product_properties.create(property_name: \"My Property 1\", value: \"my value 1\", position: 0) }","path":"api/spec/controllers/spree/api/product_properties_controller_spec.rb","position":11,"original_position":11,"commit_id":"095ff88326e9f991756bf38c777ca5cadc29ad15","original_commit_id":"095ff88326e9f991756bf38c777ca5cadc29ad15","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Line is too long. [125/100]","created_at":"2014-12-21T05:52:46Z","updated_at":"2014-12-21T05:52:46Z","html_url":"https://github.com/spree/spree/pull/5815#discussion_r22145924","pull_request_url":"https://api.github.com/repos/spree/spree/pulls/5815","_links":{"self":{"href":"https://api.github.com/repos/spree/spree/pulls/comments/22145924"},"html":{"href":"https://github.com/spree/spree/pull/5815#discussion_r22145924"},"pull_request":{"href":"https://api.github.com/repos/spree/spree/pulls/5815"}}},"pull_request":{"url":"https://api.github.com/repos/spree/spree/pulls/5815","id":26424564,"html_url":"https://github.com/spree/spree/pull/5815","diff_url":"https://github.com/spree/spree/pull/5815.diff","patch_url":"https://github.com/spree/spree/pull/5815.patch","issue_url":"https://api.github.com/repos/spree/spree/issues/5815","number":5815,"state":"open","locked":false,"title":"Rails 4 2 updates","user":{"login":"BenMorganIO","id":3117356,"avatar_url":"https://avatars.githubusercontent.com/u/3117356?v=3","gravatar_id":"","url":"https://api.github.com/users/BenMorganIO","html_url":"https://github.com/BenMorganIO","followers_url":"https://api.github.com/users/BenMorganIO/followers","following_url":"https://api.github.com/users/BenMorganIO/following{/other_user}","gists_url":"https://api.github.com/users/BenMorganIO/gists{/gist_id}","starred_url":"https://api.github.com/users/BenMorganIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenMorganIO/subscriptions","organizations_url":"https://api.github.com/users/BenMorganIO/orgs","repos_url":"https://api.github.com/users/BenMorganIO/repos","events_url":"https://api.github.com/users/BenMorganIO/events{/privacy}","received_events_url":"https://api.github.com/users/BenMorganIO/received_events","type":"User","site_admin":false},"body":"This PR will soon have a checklist of the Rails 4.2 changes to be fixed and any issues I've encountered.\r\n\r\nPR work in progress.\r\n\r\n__Major Features__:\r\n - [ ] Stock Items Creation Job\r\n - [ ] Email Jobs\r\n - [ ] Web Console\r\n - [ ] Foreign Key Support\r\n\r\n__Incompatibilities__:\r\n - [ ] `render` with a String Argument\r\n - [ ] respond_with / Class-Level respond_to\r\n - [ ] Default Host for rails server\r\n - [ ] HTML Sanitizer\r\n - [ ] assert_select\r\n\r\n__Railties__:\r\n- [ ] Removals\r\n- [ ] Deprecations\r\n- [ ] Notable changes\r\n\r\n__Action Pack__:\r\n- [ ] Removals\r\n- [ ] Deprecations\r\n- [ ] Notable Changes\r\n\r\n__Action View__:\r\n- [ ] Removals\r\n- [ ] Deprecations\r\n- [ ] Notable Changes\r\n\r\n__Action Mailer__:\r\n- [ ] Removals\r\n- [ ] Deprecations\r\n- [ ] Notable Changes\r\n\r\n__Active Record__:\r\n- [ ] Removals\r\n- [ ] Deprecations\r\n- [ ] Notable Changes\r\n\r\n__Active Model__:\r\n- [ ] Removals\r\n- [ ] Deprecations\r\n- [ ] Notable Changes\r\n\r\n__Active Support__:\r\n- [ ] Removals\r\n- [ ] Deprecations\r\n- [ ] Notable Changes\r\n","created_at":"2014-12-21T05:28:48Z","updated_at":"2014-12-21T05:52:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e91680953a4452464a294c60dbbf5feb0a8ef02","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/spree/spree/pulls/5815/commits","review_comments_url":"https://api.github.com/repos/spree/spree/pulls/5815/comments","review_comment_url":"https://api.github.com/repos/spree/spree/pulls/comments/{number}","comments_url":"https://api.github.com/repos/spree/spree/issues/5815/comments","statuses_url":"https://api.github.com/repos/spree/spree/statuses/095ff88326e9f991756bf38c777ca5cadc29ad15","head":{"label":"BenMorganIO:rails-4-2-updates","ref":"rails-4-2-updates","sha":"095ff88326e9f991756bf38c777ca5cadc29ad15","user":{"login":"BenMorganIO","id":3117356,"avatar_url":"https://avatars.githubusercontent.com/u/3117356?v=3","gravatar_id":"","url":"https://api.github.com/users/BenMorganIO","html_url":"https://github.com/BenMorganIO","followers_url":"https://api.github.com/users/BenMorganIO/followers","following_url":"https://api.github.com/users/BenMorganIO/following{/other_user}","gists_url":"https://api.github.com/users/BenMorganIO/gists{/gist_id}","starred_url":"https://api.github.com/users/BenMorganIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenMorganIO/subscriptions","organizations_url":"https://api.github.com/users/BenMorganIO/orgs","repos_url":"https://api.github.com/users/BenMorganIO/repos","events_url":"https://api.github.com/users/BenMorganIO/events{/privacy}","received_events_url":"https://api.github.com/users/BenMorganIO/received_events","type":"User","site_admin":false},"repo":{"id":21265635,"name":"spree","full_name":"BenMorganIO/spree","owner":{"login":"BenMorganIO","id":3117356,"avatar_url":"https://avatars.githubusercontent.com/u/3117356?v=3","gravatar_id":"","url":"https://api.github.com/users/BenMorganIO","html_url":"https://github.com/BenMorganIO","followers_url":"https://api.github.com/users/BenMorganIO/followers","following_url":"https://api.github.com/users/BenMorganIO/following{/other_user}","gists_url":"https://api.github.com/users/BenMorganIO/gists{/gist_id}","starred_url":"https://api.github.com/users/BenMorganIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenMorganIO/subscriptions","organizations_url":"https://api.github.com/users/BenMorganIO/orgs","repos_url":"https://api.github.com/users/BenMorganIO/repos","events_url":"https://api.github.com/users/BenMorganIO/events{/privacy}","received_events_url":"https://api.github.com/users/BenMorganIO/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BenMorganIO/spree","description":"Spree is a complete open source e-commerce solution for Ruby on Rails.","fork":true,"url":"https://api.github.com/repos/BenMorganIO/spree","forks_url":"https://api.github.com/repos/BenMorganIO/spree/forks","keys_url":"https://api.github.com/repos/BenMorganIO/spree/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BenMorganIO/spree/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BenMorganIO/spree/teams","hooks_url":"https://api.github.com/repos/BenMorganIO/spree/hooks","issue_events_url":"https://api.github.com/repos/BenMorganIO/spree/issues/events{/number}","events_url":"https://api.github.com/repos/BenMorganIO/spree/events","assignees_url":"https://api.github.com/repos/BenMorganIO/spree/assignees{/user}","branches_url":"https://api.github.com/repos/BenMorganIO/spree/branches{/branch}","tags_url":"https://api.github.com/repos/BenMorganIO/spree/tags","blobs_url":"https://api.github.com/repos/BenMorganIO/spree/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BenMorganIO/spree/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BenMorganIO/spree/git/refs{/sha}","trees_url":"https://api.github.com/repos/BenMorganIO/spree/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BenMorganIO/spree/statuses/{sha}","languages_url":"https://api.github.com/repos/BenMorganIO/spree/languages","stargazers_url":"https://api.github.com/repos/BenMorganIO/spree/stargazers","contributors_url":"https://api.github.com/repos/BenMorganIO/spree/contributors","subscribers_url":"https://api.github.com/repos/BenMorganIO/spree/subscribers","subscription_url":"https://api.github.com/repos/BenMorganIO/spree/subscription","commits_url":"https://api.github.com/repos/BenMorganIO/spree/commits{/sha}","git_commits_url":"https://api.github.com/repos/BenMorganIO/spree/git/commits{/sha}","comments_url":"https://api.github.com/repos/BenMorganIO/spree/comments{/number}","issue_comment_url":"https://api.github.com/repos/BenMorganIO/spree/issues/comments/{number}","contents_url":"https://api.github.com/repos/BenMorganIO/spree/contents/{+path}","compare_url":"https://api.github.com/repos/BenMorganIO/spree/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BenMorganIO/spree/merges","archive_url":"https://api.github.com/repos/BenMorganIO/spree/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BenMorganIO/spree/downloads","issues_url":"https://api.github.com/repos/BenMorganIO/spree/issues{/number}","pulls_url":"https://api.github.com/repos/BenMorganIO/spree/pulls{/number}","milestones_url":"https://api.github.com/repos/BenMorganIO/spree/milestones{/number}","notifications_url":"https://api.github.com/repos/BenMorganIO/spree/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BenMorganIO/spree/labels{/name}","releases_url":"https://api.github.com/repos/BenMorganIO/spree/releases{/id}","created_at":"2014-06-27T05:59:41Z","updated_at":"2014-12-21T05:24:12Z","pushed_at":"2014-12-21T05:52:32Z","git_url":"git://github.com/BenMorganIO/spree.git","ssh_url":"git@github.com:BenMorganIO/spree.git","clone_url":"https://github.com/BenMorganIO/spree.git","svn_url":"https://github.com/BenMorganIO/spree","homepage":"http://spreecommerce.com","size":69987,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"spree:master","ref":"master","sha":"7ff3bcc81af3a421ed0013511c6ee3049fb240c2","user":{"login":"spree","id":56702,"avatar_url":"https://avatars.githubusercontent.com/u/56702?v=3","gravatar_id":"","url":"https://api.github.com/users/spree","html_url":"https://github.com/spree","followers_url":"https://api.github.com/users/spree/followers","following_url":"https://api.github.com/users/spree/following{/other_user}","gists_url":"https://api.github.com/users/spree/gists{/gist_id}","starred_url":"https://api.github.com/users/spree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spree/subscriptions","organizations_url":"https://api.github.com/users/spree/orgs","repos_url":"https://api.github.com/users/spree/repos","events_url":"https://api.github.com/users/spree/events{/privacy}","received_events_url":"https://api.github.com/users/spree/received_events","type":"Organization","site_admin":false},"repo":{"id":3314,"name":"spree","full_name":"spree/spree","owner":{"login":"spree","id":56702,"avatar_url":"https://avatars.githubusercontent.com/u/56702?v=3","gravatar_id":"","url":"https://api.github.com/users/spree","html_url":"https://github.com/spree","followers_url":"https://api.github.com/users/spree/followers","following_url":"https://api.github.com/users/spree/following{/other_user}","gists_url":"https://api.github.com/users/spree/gists{/gist_id}","starred_url":"https://api.github.com/users/spree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spree/subscriptions","organizations_url":"https://api.github.com/users/spree/orgs","repos_url":"https://api.github.com/users/spree/repos","events_url":"https://api.github.com/users/spree/events{/privacy}","received_events_url":"https://api.github.com/users/spree/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spree/spree","description":"Spree is a complete open source e-commerce solution for Ruby on Rails.","fork":false,"url":"https://api.github.com/repos/spree/spree","forks_url":"https://api.github.com/repos/spree/spree/forks","keys_url":"https://api.github.com/repos/spree/spree/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spree/spree/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spree/spree/teams","hooks_url":"https://api.github.com/repos/spree/spree/hooks","issue_events_url":"https://api.github.com/repos/spree/spree/issues/events{/number}","events_url":"https://api.github.com/repos/spree/spree/events","assignees_url":"https://api.github.com/repos/spree/spree/assignees{/user}","branches_url":"https://api.github.com/repos/spree/spree/branches{/branch}","tags_url":"https://api.github.com/repos/spree/spree/tags","blobs_url":"https://api.github.com/repos/spree/spree/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spree/spree/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spree/spree/git/refs{/sha}","trees_url":"https://api.github.com/repos/spree/spree/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spree/spree/statuses/{sha}","languages_url":"https://api.github.com/repos/spree/spree/languages","stargazers_url":"https://api.github.com/repos/spree/spree/stargazers","contributors_url":"https://api.github.com/repos/spree/spree/contributors","subscribers_url":"https://api.github.com/repos/spree/spree/subscribers","subscription_url":"https://api.github.com/repos/spree/spree/subscription","commits_url":"https://api.github.com/repos/spree/spree/commits{/sha}","git_commits_url":"https://api.github.com/repos/spree/spree/git/commits{/sha}","comments_url":"https://api.github.com/repos/spree/spree/comments{/number}","issue_comment_url":"https://api.github.com/repos/spree/spree/issues/comments/{number}","contents_url":"https://api.github.com/repos/spree/spree/contents/{+path}","compare_url":"https://api.github.com/repos/spree/spree/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spree/spree/merges","archive_url":"https://api.github.com/repos/spree/spree/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spree/spree/downloads","issues_url":"https://api.github.com/repos/spree/spree/issues{/number}","pulls_url":"https://api.github.com/repos/spree/spree/pulls{/number}","milestones_url":"https://api.github.com/repos/spree/spree/milestones{/number}","notifications_url":"https://api.github.com/repos/spree/spree/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spree/spree/labels{/name}","releases_url":"https://api.github.com/repos/spree/spree/releases{/id}","created_at":"2008-03-10T14:45:35Z","updated_at":"2014-12-20T17:29:12Z","pushed_at":"2014-12-18T21:33:15Z","git_url":"git://github.com/spree/spree.git","ssh_url":"git@github.com:spree/spree.git","clone_url":"https://github.com/spree/spree.git","svn_url":"https://github.com/spree/spree","homepage":"http://spreecommerce.com","size":123230,"stargazers_count":5782,"watchers_count":5782,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2688,"mirror_url":null,"open_issues_count":121,"forks":2688,"open_issues":121,"watchers":5782,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spree/spree/pulls/5815"},"html":{"href":"https://github.com/spree/spree/pull/5815"},"issue":{"href":"https://api.github.com/repos/spree/spree/issues/5815"},"comments":{"href":"https://api.github.com/repos/spree/spree/issues/5815/comments"},"review_comments":{"href":"https://api.github.com/repos/spree/spree/pulls/5815/comments"},"review_comment":{"href":"https://api.github.com/repos/spree/spree/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/spree/spree/pulls/5815/commits"},"statuses":{"href":"https://api.github.com/repos/spree/spree/statuses/095ff88326e9f991756bf38c777ca5cadc29ad15"}}}}