GitHub PullRequestReviewCommentEvent at 2014-12-12 15:13:23
Repository: hazelcast-stabilizer
Actor: Donnerbart
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/pulls/comments/21749422","id":21749422,"diff_hunk":"@@ -187,8 +187,6 @@ public static void main(String[] args) {\n \n         log.info(\"Starting Stabilizer Worker\");\n \n-        registerLog4jShutdownHandler();","path":"stabilizer/src/main/java/com/hazelcast/stabilizer/worker/MemberWorker.java","position":4,"original_position":4,"commit_id":"6180d278bb0886e2d734365cd4040b157f792682","original_commit_id":"6180d278bb0886e2d734365cd4040b157f792682","user":{"login":"Donnerbart","id":4196298,"avatar_url":"https://avatars.githubusercontent.com/u/4196298?v=3","gravatar_id":"","url":"https://api.github.com/users/Donnerbart","html_url":"https://github.com/Donnerbart","followers_url":"https://api.github.com/users/Donnerbart/followers","following_url":"https://api.github.com/users/Donnerbart/following{/other_user}","gists_url":"https://api.github.com/users/Donnerbart/gists{/gist_id}","starred_url":"https://api.github.com/users/Donnerbart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Donnerbart/subscriptions","organizations_url":"https://api.github.com/users/Donnerbart/orgs","repos_url":"https://api.github.com/users/Donnerbart/repos","events_url":"https://api.github.com/users/Donnerbart/events{/privacy}","received_events_url":"https://api.github.com/users/Donnerbart/received_events","type":"User","site_admin":false},"body":"Please have a look at the whole file. The same method is already invoked in line 186. It should be sufficient to register that handler once or did I miss something?","created_at":"2014-12-12T15:13:23Z","updated_at":"2014-12-12T15:13:23Z","html_url":"https://github.com/hazelcast/hazelcast-stabilizer/pull/436#discussion_r21749422","pull_request_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/pulls/436","_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/pulls/comments/21749422"},"html":{"href":"https://github.com/hazelcast/hazelcast-stabilizer/pull/436#discussion_r21749422"},"pull_request":{"href":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/pulls/436"}}},"pull_request":{"url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/pulls/436","id":25968415,"html_url":"https://github.com/hazelcast/hazelcast-stabilizer/pull/436","diff_url":"https://github.com/hazelcast/hazelcast-stabilizer/pull/436.diff","patch_url":"https://github.com/hazelcast/hazelcast-stabilizer/pull/436.patch","issue_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/issues/436","number":436,"state":"open","locked":false,"title":"Default stabilizer config should use rolling file appender for worker","user":{"login":"Donnerbart","id":4196298,"avatar_url":"https://avatars.githubusercontent.com/u/4196298?v=3","gravatar_id":"","url":"https://api.github.com/users/Donnerbart","html_url":"https://github.com/Donnerbart","followers_url":"https://api.github.com/users/Donnerbart/followers","following_url":"https://api.github.com/users/Donnerbart/following{/other_user}","gists_url":"https://api.github.com/users/Donnerbart/gists{/gist_id}","starred_url":"https://api.github.com/users/Donnerbart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Donnerbart/subscriptions","organizations_url":"https://api.github.com/users/Donnerbart/orgs","repos_url":"https://api.github.com/users/Donnerbart/repos","events_url":"https://api.github.com/users/Donnerbart/events{/privacy}","received_events_url":"https://api.github.com/users/Donnerbart/received_events","type":"User","site_admin":false},"body":"Changed default Log4j appender to RollingFileAppender. Default values are 1gb per file and 5 backup files (which creates 6 gb of log data in 6 files at maximum). The Log4j configuration file can be overwritten by a local file in the working directory.\r\n\r\nThis resolves issue #363.","created_at":"2014-12-12T11:49:27Z","updated_at":"2014-12-12T15:13:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a48d5d3bb8a674e5b75e2c0fb6c436afa4a13439","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/pulls/436/commits","review_comments_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/pulls/436/comments","review_comment_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/pulls/comments/{number}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/issues/436/comments","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/statuses/6180d278bb0886e2d734365cd4040b157f792682","head":{"label":"Donnerbart:fixIssue363","ref":"fixIssue363","sha":"6180d278bb0886e2d734365cd4040b157f792682","user":{"login":"Donnerbart","id":4196298,"avatar_url":"https://avatars.githubusercontent.com/u/4196298?v=3","gravatar_id":"","url":"https://api.github.com/users/Donnerbart","html_url":"https://github.com/Donnerbart","followers_url":"https://api.github.com/users/Donnerbart/followers","following_url":"https://api.github.com/users/Donnerbart/following{/other_user}","gists_url":"https://api.github.com/users/Donnerbart/gists{/gist_id}","starred_url":"https://api.github.com/users/Donnerbart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Donnerbart/subscriptions","organizations_url":"https://api.github.com/users/Donnerbart/orgs","repos_url":"https://api.github.com/users/Donnerbart/repos","events_url":"https://api.github.com/users/Donnerbart/events{/privacy}","received_events_url":"https://api.github.com/users/Donnerbart/received_events","type":"User","site_admin":false},"repo":{"id":26756293,"name":"hazelcast-stabilizer","full_name":"Donnerbart/hazelcast-stabilizer","owner":{"login":"Donnerbart","id":4196298,"avatar_url":"https://avatars.githubusercontent.com/u/4196298?v=3","gravatar_id":"","url":"https://api.github.com/users/Donnerbart","html_url":"https://github.com/Donnerbart","followers_url":"https://api.github.com/users/Donnerbart/followers","following_url":"https://api.github.com/users/Donnerbart/following{/other_user}","gists_url":"https://api.github.com/users/Donnerbart/gists{/gist_id}","starred_url":"https://api.github.com/users/Donnerbart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Donnerbart/subscriptions","organizations_url":"https://api.github.com/users/Donnerbart/orgs","repos_url":"https://api.github.com/users/Donnerbart/repos","events_url":"https://api.github.com/users/Donnerbart/events{/privacy}","received_events_url":"https://api.github.com/users/Donnerbart/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Donnerbart/hazelcast-stabilizer","description":"A tool for stress testing Hazelcast","fork":true,"url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer","forks_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/forks","keys_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/teams","hooks_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/hooks","issue_events_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/issues/events{/number}","events_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/events","assignees_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/assignees{/user}","branches_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/branches{/branch}","tags_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/tags","blobs_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/git/refs{/sha}","trees_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/statuses/{sha}","languages_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/languages","stargazers_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/stargazers","contributors_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/contributors","subscribers_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/subscribers","subscription_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/subscription","commits_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/commits{/sha}","git_commits_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/git/commits{/sha}","comments_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/comments{/number}","issue_comment_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/issues/comments/{number}","contents_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/contents/{+path}","compare_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/merges","archive_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/downloads","issues_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/issues{/number}","pulls_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/pulls{/number}","milestones_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/milestones{/number}","notifications_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/labels{/name}","releases_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/releases{/id}","created_at":"2014-11-17T12:48:31Z","updated_at":"2014-12-11T16:07:16Z","pushed_at":"2014-12-12T15:01:57Z","git_url":"git://github.com/Donnerbart/hazelcast-stabilizer.git","ssh_url":"git@github.com:Donnerbart/hazelcast-stabilizer.git","clone_url":"https://github.com/Donnerbart/hazelcast-stabilizer.git","svn_url":"https://github.com/Donnerbart/hazelcast-stabilizer","homepage":null,"size":7088,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hazelcast:master","ref":"master","sha":"6b6a1bc65d7dbf46802ae2a9cdd400d85c5c369d","user":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"repo":{"id":11445479,"name":"hazelcast-stabilizer","full_name":"hazelcast/hazelcast-stabilizer","owner":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hazelcast/hazelcast-stabilizer","description":"A tool for stress testing Hazelcast","fork":false,"url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer","forks_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/forks","keys_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/teams","hooks_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/hooks","issue_events_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/issues/events{/number}","events_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/events","assignees_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/assignees{/user}","branches_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/branches{/branch}","tags_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/tags","blobs_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/git/refs{/sha}","trees_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/statuses/{sha}","languages_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/languages","stargazers_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/stargazers","contributors_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/contributors","subscribers_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/subscribers","subscription_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/subscription","commits_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/commits{/sha}","git_commits_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/git/commits{/sha}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/comments{/number}","issue_comment_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/issues/comments/{number}","contents_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/contents/{+path}","compare_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/merges","archive_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/downloads","issues_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/issues{/number}","pulls_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/pulls{/number}","milestones_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/milestones{/number}","notifications_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/labels{/name}","releases_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/releases{/id}","created_at":"2013-07-16T09:18:54Z","updated_at":"2014-12-11T16:04:24Z","pushed_at":"2014-12-12T09:57:12Z","git_url":"git://github.com/hazelcast/hazelcast-stabilizer.git","ssh_url":"git@github.com:hazelcast/hazelcast-stabilizer.git","clone_url":"https://github.com/hazelcast/hazelcast-stabilizer.git","svn_url":"https://github.com/hazelcast/hazelcast-stabilizer","homepage":null,"size":11147,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":91,"forks":11,"open_issues":91,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/pulls/436"},"html":{"href":"https://github.com/hazelcast/hazelcast-stabilizer/pull/436"},"issue":{"href":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/issues/436"},"comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/issues/436/comments"},"review_comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/pulls/436/comments"},"review_comment":{"href":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/pulls/436/commits"},"statuses":{"href":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/statuses/6180d278bb0886e2d734365cd4040b157f792682"}}}}