GitHub PullRequestReviewCommentEvent at 2014-08-29 15:39:15
Repository: daybed.js
Actor: Natim
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/spiral-project/daybed.js/pulls/comments/16904477","id":16904477,"diff_hunk":"@@ -70,23 +100,36 @@\n     });\n   }\n \n+  function startSession(host, options) {\n+    options = options || {\n+      credentials: undefined,\n+      getToken: undefined\n+    };\n+\n+    var credentials = options.credentials;\n+    var token = options.getToken && options.getToken();","path":"index.js","position":73,"original_position":73,"commit_id":"11a5e0fdc3ae43a148158122a7750b44320036ac","original_commit_id":"11a5e0fdc3ae43a148158122a7750b44320036ac","user":{"login":"Natim","id":229453,"avatar_url":"https://avatars.githubusercontent.com/u/229453?v=2","gravatar_id":"48e87ebebf7bee2a0ca10aa2362795a6","url":"https://api.github.com/users/Natim","html_url":"https://github.com/Natim","followers_url":"https://api.github.com/users/Natim/followers","following_url":"https://api.github.com/users/Natim/following{/other_user}","gists_url":"https://api.github.com/users/Natim/gists{/gist_id}","starred_url":"https://api.github.com/users/Natim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Natim/subscriptions","organizations_url":"https://api.github.com/users/Natim/orgs","repos_url":"https://api.github.com/users/Natim/repos","events_url":"https://api.github.com/users/Natim/events{/privacy}","received_events_url":"https://api.github.com/users/Natim/received_events","type":"User","site_admin":false},"body":"I don't understand the `options.getToken()` here. Shouldn't it raise the `\"host\" missing` error?","created_at":"2014-08-29T15:39:15Z","updated_at":"2014-08-29T15:39:15Z","html_url":"https://github.com/spiral-project/daybed.js/pull/7#discussion_r16904477","pull_request_url":"https://api.github.com/repos/spiral-project/daybed.js/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/spiral-project/daybed.js/pulls/comments/16904477"},"html":{"href":"https://github.com/spiral-project/daybed.js/pull/7#discussion_r16904477"},"pull_request":{"href":"https://api.github.com/repos/spiral-project/daybed.js/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/spiral-project/daybed.js/pulls/7","id":20449250,"html_url":"https://github.com/spiral-project/daybed.js/pull/7","diff_url":"https://github.com/spiral-project/daybed.js/pull/7.diff","patch_url":"https://github.com/spiral-project/daybed.js/pull/7.patch","issue_url":"https://api.github.com/repos/spiral-project/daybed.js/issues/7","number":7,"state":"open","locked":false,"title":"Get or create token","user":{"login":"leplatrem","id":546692,"avatar_url":"https://avatars.githubusercontent.com/u/546692?v=2","gravatar_id":"921bc8b5b7474924e953e8b972c9b01d","url":"https://api.github.com/users/leplatrem","html_url":"https://github.com/leplatrem","followers_url":"https://api.github.com/users/leplatrem/followers","following_url":"https://api.github.com/users/leplatrem/following{/other_user}","gists_url":"https://api.github.com/users/leplatrem/gists{/gist_id}","starred_url":"https://api.github.com/users/leplatrem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leplatrem/subscriptions","organizations_url":"https://api.github.com/users/leplatrem/orgs","repos_url":"https://api.github.com/users/leplatrem/repos","events_url":"https://api.github.com/users/leplatrem/events{/privacy}","received_events_url":"https://api.github.com/users/leplatrem/received_events","type":"User","site_admin":false},"body":"Rewrite of #5 ","created_at":"2014-08-28T16:12:02Z","updated_at":"2014-08-29T15:39:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8081ecf8042e94821257d63255c7e59a8bea3e9c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/spiral-project/daybed.js/pulls/7/commits","review_comments_url":"https://api.github.com/repos/spiral-project/daybed.js/pulls/7/comments","review_comment_url":"https://api.github.com/repos/spiral-project/daybed.js/pulls/comments/{number}","comments_url":"https://api.github.com/repos/spiral-project/daybed.js/issues/7/comments","statuses_url":"https://api.github.com/repos/spiral-project/daybed.js/statuses/11a5e0fdc3ae43a148158122a7750b44320036ac","head":{"label":"spiral-project:get_or_create_token","ref":"get_or_create_token","sha":"11a5e0fdc3ae43a148158122a7750b44320036ac","user":{"login":"spiral-project","id":991307,"avatar_url":"https://avatars.githubusercontent.com/u/991307?v=2","gravatar_id":"149544843e9dac05d3a0dc1fd0eef7c7","url":"https://api.github.com/users/spiral-project","html_url":"https://github.com/spiral-project","followers_url":"https://api.github.com/users/spiral-project/followers","following_url":"https://api.github.com/users/spiral-project/following{/other_user}","gists_url":"https://api.github.com/users/spiral-project/gists{/gist_id}","starred_url":"https://api.github.com/users/spiral-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spiral-project/subscriptions","organizations_url":"https://api.github.com/users/spiral-project/orgs","repos_url":"https://api.github.com/users/spiral-project/repos","events_url":"https://api.github.com/users/spiral-project/events{/privacy}","received_events_url":"https://api.github.com/users/spiral-project/received_events","type":"Organization","site_admin":false},"repo":{"id":22210713,"name":"daybed.js","full_name":"spiral-project/daybed.js","owner":{"login":"spiral-project","id":991307,"avatar_url":"https://avatars.githubusercontent.com/u/991307?v=2","gravatar_id":"149544843e9dac05d3a0dc1fd0eef7c7","url":"https://api.github.com/users/spiral-project","html_url":"https://github.com/spiral-project","followers_url":"https://api.github.com/users/spiral-project/followers","following_url":"https://api.github.com/users/spiral-project/following{/other_user}","gists_url":"https://api.github.com/users/spiral-project/gists{/gist_id}","starred_url":"https://api.github.com/users/spiral-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spiral-project/subscriptions","organizations_url":"https://api.github.com/users/spiral-project/orgs","repos_url":"https://api.github.com/users/spiral-project/repos","events_url":"https://api.github.com/users/spiral-project/events{/privacy}","received_events_url":"https://api.github.com/users/spiral-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spiral-project/daybed.js","description":"Javascript Toolkit to use Daybed in your HTML5 app","fork":false,"url":"https://api.github.com/repos/spiral-project/daybed.js","forks_url":"https://api.github.com/repos/spiral-project/daybed.js/forks","keys_url":"https://api.github.com/repos/spiral-project/daybed.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spiral-project/daybed.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spiral-project/daybed.js/teams","hooks_url":"https://api.github.com/repos/spiral-project/daybed.js/hooks","issue_events_url":"https://api.github.com/repos/spiral-project/daybed.js/issues/events{/number}","events_url":"https://api.github.com/repos/spiral-project/daybed.js/events","assignees_url":"https://api.github.com/repos/spiral-project/daybed.js/assignees{/user}","branches_url":"https://api.github.com/repos/spiral-project/daybed.js/branches{/branch}","tags_url":"https://api.github.com/repos/spiral-project/daybed.js/tags","blobs_url":"https://api.github.com/repos/spiral-project/daybed.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spiral-project/daybed.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spiral-project/daybed.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/spiral-project/daybed.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spiral-project/daybed.js/statuses/{sha}","languages_url":"https://api.github.com/repos/spiral-project/daybed.js/languages","stargazers_url":"https://api.github.com/repos/spiral-project/daybed.js/stargazers","contributors_url":"https://api.github.com/repos/spiral-project/daybed.js/contributors","subscribers_url":"https://api.github.com/repos/spiral-project/daybed.js/subscribers","subscription_url":"https://api.github.com/repos/spiral-project/daybed.js/subscription","commits_url":"https://api.github.com/repos/spiral-project/daybed.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/spiral-project/daybed.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/spiral-project/daybed.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/spiral-project/daybed.js/issues/comments/{number}","contents_url":"https://api.github.com/repos/spiral-project/daybed.js/contents/{+path}","compare_url":"https://api.github.com/repos/spiral-project/daybed.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spiral-project/daybed.js/merges","archive_url":"https://api.github.com/repos/spiral-project/daybed.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spiral-project/daybed.js/downloads","issues_url":"https://api.github.com/repos/spiral-project/daybed.js/issues{/number}","pulls_url":"https://api.github.com/repos/spiral-project/daybed.js/pulls{/number}","milestones_url":"https://api.github.com/repos/spiral-project/daybed.js/milestones{/number}","notifications_url":"https://api.github.com/repos/spiral-project/daybed.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spiral-project/daybed.js/labels{/name}","releases_url":"https://api.github.com/repos/spiral-project/daybed.js/releases{/id}","created_at":"2014-07-24T11:38:01Z","updated_at":"2014-07-30T16:32:21Z","pushed_at":"2014-08-29T15:13:57Z","git_url":"git://github.com/spiral-project/daybed.js.git","ssh_url":"git@github.com:spiral-project/daybed.js.git","clone_url":"https://github.com/spiral-project/daybed.js.git","svn_url":"https://github.com/spiral-project/daybed.js","homepage":"","size":412,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"spiral-project:master","ref":"master","sha":"9157f7007b5994777b0b13b761abea3e8f0fef45","user":{"login":"spiral-project","id":991307,"avatar_url":"https://avatars.githubusercontent.com/u/991307?v=2","gravatar_id":"149544843e9dac05d3a0dc1fd0eef7c7","url":"https://api.github.com/users/spiral-project","html_url":"https://github.com/spiral-project","followers_url":"https://api.github.com/users/spiral-project/followers","following_url":"https://api.github.com/users/spiral-project/following{/other_user}","gists_url":"https://api.github.com/users/spiral-project/gists{/gist_id}","starred_url":"https://api.github.com/users/spiral-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spiral-project/subscriptions","organizations_url":"https://api.github.com/users/spiral-project/orgs","repos_url":"https://api.github.com/users/spiral-project/repos","events_url":"https://api.github.com/users/spiral-project/events{/privacy}","received_events_url":"https://api.github.com/users/spiral-project/received_events","type":"Organization","site_admin":false},"repo":{"id":22210713,"name":"daybed.js","full_name":"spiral-project/daybed.js","owner":{"login":"spiral-project","id":991307,"avatar_url":"https://avatars.githubusercontent.com/u/991307?v=2","gravatar_id":"149544843e9dac05d3a0dc1fd0eef7c7","url":"https://api.github.com/users/spiral-project","html_url":"https://github.com/spiral-project","followers_url":"https://api.github.com/users/spiral-project/followers","following_url":"https://api.github.com/users/spiral-project/following{/other_user}","gists_url":"https://api.github.com/users/spiral-project/gists{/gist_id}","starred_url":"https://api.github.com/users/spiral-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spiral-project/subscriptions","organizations_url":"https://api.github.com/users/spiral-project/orgs","repos_url":"https://api.github.com/users/spiral-project/repos","events_url":"https://api.github.com/users/spiral-project/events{/privacy}","received_events_url":"https://api.github.com/users/spiral-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spiral-project/daybed.js","description":"Javascript Toolkit to use Daybed in your HTML5 app","fork":false,"url":"https://api.github.com/repos/spiral-project/daybed.js","forks_url":"https://api.github.com/repos/spiral-project/daybed.js/forks","keys_url":"https://api.github.com/repos/spiral-project/daybed.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spiral-project/daybed.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spiral-project/daybed.js/teams","hooks_url":"https://api.github.com/repos/spiral-project/daybed.js/hooks","issue_events_url":"https://api.github.com/repos/spiral-project/daybed.js/issues/events{/number}","events_url":"https://api.github.com/repos/spiral-project/daybed.js/events","assignees_url":"https://api.github.com/repos/spiral-project/daybed.js/assignees{/user}","branches_url":"https://api.github.com/repos/spiral-project/daybed.js/branches{/branch}","tags_url":"https://api.github.com/repos/spiral-project/daybed.js/tags","blobs_url":"https://api.github.com/repos/spiral-project/daybed.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spiral-project/daybed.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spiral-project/daybed.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/spiral-project/daybed.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spiral-project/daybed.js/statuses/{sha}","languages_url":"https://api.github.com/repos/spiral-project/daybed.js/languages","stargazers_url":"https://api.github.com/repos/spiral-project/daybed.js/stargazers","contributors_url":"https://api.github.com/repos/spiral-project/daybed.js/contributors","subscribers_url":"https://api.github.com/repos/spiral-project/daybed.js/subscribers","subscription_url":"https://api.github.com/repos/spiral-project/daybed.js/subscription","commits_url":"https://api.github.com/repos/spiral-project/daybed.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/spiral-project/daybed.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/spiral-project/daybed.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/spiral-project/daybed.js/issues/comments/{number}","contents_url":"https://api.github.com/repos/spiral-project/daybed.js/contents/{+path}","compare_url":"https://api.github.com/repos/spiral-project/daybed.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spiral-project/daybed.js/merges","archive_url":"https://api.github.com/repos/spiral-project/daybed.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spiral-project/daybed.js/downloads","issues_url":"https://api.github.com/repos/spiral-project/daybed.js/issues{/number}","pulls_url":"https://api.github.com/repos/spiral-project/daybed.js/pulls{/number}","milestones_url":"https://api.github.com/repos/spiral-project/daybed.js/milestones{/number}","notifications_url":"https://api.github.com/repos/spiral-project/daybed.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spiral-project/daybed.js/labels{/name}","releases_url":"https://api.github.com/repos/spiral-project/daybed.js/releases{/id}","created_at":"2014-07-24T11:38:01Z","updated_at":"2014-07-30T16:32:21Z","pushed_at":"2014-08-29T15:13:57Z","git_url":"git://github.com/spiral-project/daybed.js.git","ssh_url":"git@github.com:spiral-project/daybed.js.git","clone_url":"https://github.com/spiral-project/daybed.js.git","svn_url":"https://github.com/spiral-project/daybed.js","homepage":"","size":412,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spiral-project/daybed.js/pulls/7"},"html":{"href":"https://github.com/spiral-project/daybed.js/pull/7"},"issue":{"href":"https://api.github.com/repos/spiral-project/daybed.js/issues/7"},"comments":{"href":"https://api.github.com/repos/spiral-project/daybed.js/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/spiral-project/daybed.js/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/spiral-project/daybed.js/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/spiral-project/daybed.js/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/spiral-project/daybed.js/statuses/11a5e0fdc3ae43a148158122a7750b44320036ac"}}}}