GitHub PullRequestReviewCommentEvent at 2014-10-27 15:48:34
Repository: gist-prototype
Actor: KirillC
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/egeorg/gist-prototype/pulls/comments/19413733","id":19413733,"diff_hunk":"@@ -4,22 +4,22 @@\n \n template <typename P>\n Gist<P>::Gist(int u, int l) {\n-    upperBound = u;\n-    lowerBound = l;\n-    root = new Node<P>();\n+    max_fanout = u;\n+    min_fanout = l;\n+    root = new InnerEntry<P>();","path":"src/gist/gist.cxx","position":9,"original_position":9,"commit_id":"bb7cdc475d9596bedb4150a5f05e4776df185305","original_commit_id":"bb7cdc475d9596bedb4150a5f05e4776df185305","user":{"login":"KirillC","id":9052127,"avatar_url":"https://avatars.githubusercontent.com/u/9052127?v=2","gravatar_id":"","url":"https://api.github.com/users/KirillC","html_url":"https://github.com/KirillC","followers_url":"https://api.github.com/users/KirillC/followers","following_url":"https://api.github.com/users/KirillC/following{/other_user}","gists_url":"https://api.github.com/users/KirillC/gists{/gist_id}","starred_url":"https://api.github.com/users/KirillC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KirillC/subscriptions","organizations_url":"https://api.github.com/users/KirillC/orgs","repos_url":"https://api.github.com/users/KirillC/repos","events_url":"https://api.github.com/users/KirillC/events{/privacy}","received_events_url":"https://api.github.com/users/KirillC/received_events","type":"User","site_admin":false},"body":"Почему Inner? Изначально, когда только создаётся GiST и в него вставляются записи все они лежат в одной Entry. Соответственно она листовая. Или что-то другое под этим понималось?\r\nВообще можно например тут корень не инициализировать, а делать это при вставке, если это необходимо.","created_at":"2014-10-27T15:48:34Z","updated_at":"2014-10-27T15:48:34Z","html_url":"https://github.com/egeorg/gist-prototype/pull/5#discussion_r19413733","pull_request_url":"https://api.github.com/repos/egeorg/gist-prototype/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/egeorg/gist-prototype/pulls/comments/19413733"},"html":{"href":"https://github.com/egeorg/gist-prototype/pull/5#discussion_r19413733"},"pull_request":{"href":"https://api.github.com/repos/egeorg/gist-prototype/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/egeorg/gist-prototype/pulls/5","id":23391680,"html_url":"https://github.com/egeorg/gist-prototype/pull/5","diff_url":"https://github.com/egeorg/gist-prototype/pull/5.diff","patch_url":"https://github.com/egeorg/gist-prototype/pull/5.patch","issue_url":"https://api.github.com/repos/egeorg/gist-prototype/issues/5","number":5,"state":"open","locked":false,"title":"Gist::search() implementation =^.^=","user":{"login":"alinadubatovka","id":6866408,"avatar_url":"https://avatars.githubusercontent.com/u/6866408?v=2","gravatar_id":"","url":"https://api.github.com/users/alinadubatovka","html_url":"https://github.com/alinadubatovka","followers_url":"https://api.github.com/users/alinadubatovka/followers","following_url":"https://api.github.com/users/alinadubatovka/following{/other_user}","gists_url":"https://api.github.com/users/alinadubatovka/gists{/gist_id}","starred_url":"https://api.github.com/users/alinadubatovka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alinadubatovka/subscriptions","organizations_url":"https://api.github.com/users/alinadubatovka/orgs","repos_url":"https://api.github.com/users/alinadubatovka/repos","events_url":"https://api.github.com/users/alinadubatovka/events{/privacy}","received_events_url":"https://api.github.com/users/alinadubatovka/received_events","type":"User","site_admin":false},"body":"Для реализации Gist::search() пришлось ввести Entry::find() -- по факту, обход дерева в глубину. Это почти что виртуальный метод (он наотрез отказался стать виртуальным), для того, чтобы не проверять Entry на тип: Inner или Leaf, так как у каждого из них свой find. И Gist::search(), и Entry::find() возвращают vector<LeafEntry<P>*>. \r\n\r\nВ случае чего, можно не закрывать пулл-реквест, а просто оставить как есть. Он будет обновляться параллельно с изменениями в моём репозитории, пока не станет хорошо :)","created_at":"2014-10-27T15:36:03Z","updated_at":"2014-10-27T15:48:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"517b1e562f67f6fb9096062d4e4afd3b92e9c0f6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/egeorg/gist-prototype/pulls/5/commits","review_comments_url":"https://api.github.com/repos/egeorg/gist-prototype/pulls/5/comments","review_comment_url":"https://api.github.com/repos/egeorg/gist-prototype/pulls/comments/{number}","comments_url":"https://api.github.com/repos/egeorg/gist-prototype/issues/5/comments","statuses_url":"https://api.github.com/repos/egeorg/gist-prototype/statuses/bb7cdc475d9596bedb4150a5f05e4776df185305","head":{"label":"alinadubatovka:master","ref":"master","sha":"bb7cdc475d9596bedb4150a5f05e4776df185305","user":{"login":"alinadubatovka","id":6866408,"avatar_url":"https://avatars.githubusercontent.com/u/6866408?v=2","gravatar_id":"","url":"https://api.github.com/users/alinadubatovka","html_url":"https://github.com/alinadubatovka","followers_url":"https://api.github.com/users/alinadubatovka/followers","following_url":"https://api.github.com/users/alinadubatovka/following{/other_user}","gists_url":"https://api.github.com/users/alinadubatovka/gists{/gist_id}","starred_url":"https://api.github.com/users/alinadubatovka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alinadubatovka/subscriptions","organizations_url":"https://api.github.com/users/alinadubatovka/orgs","repos_url":"https://api.github.com/users/alinadubatovka/repos","events_url":"https://api.github.com/users/alinadubatovka/events{/privacy}","received_events_url":"https://api.github.com/users/alinadubatovka/received_events","type":"User","site_admin":false},"repo":{"id":25176168,"name":"gist-prototype","full_name":"alinadubatovka/gist-prototype","owner":{"login":"alinadubatovka","id":6866408,"avatar_url":"https://avatars.githubusercontent.com/u/6866408?v=2","gravatar_id":"","url":"https://api.github.com/users/alinadubatovka","html_url":"https://github.com/alinadubatovka","followers_url":"https://api.github.com/users/alinadubatovka/followers","following_url":"https://api.github.com/users/alinadubatovka/following{/other_user}","gists_url":"https://api.github.com/users/alinadubatovka/gists{/gist_id}","starred_url":"https://api.github.com/users/alinadubatovka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alinadubatovka/subscriptions","organizations_url":"https://api.github.com/users/alinadubatovka/orgs","repos_url":"https://api.github.com/users/alinadubatovka/repos","events_url":"https://api.github.com/users/alinadubatovka/events{/privacy}","received_events_url":"https://api.github.com/users/alinadubatovka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alinadubatovka/gist-prototype","description":"","fork":true,"url":"https://api.github.com/repos/alinadubatovka/gist-prototype","forks_url":"https://api.github.com/repos/alinadubatovka/gist-prototype/forks","keys_url":"https://api.github.com/repos/alinadubatovka/gist-prototype/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alinadubatovka/gist-prototype/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alinadubatovka/gist-prototype/teams","hooks_url":"https://api.github.com/repos/alinadubatovka/gist-prototype/hooks","issue_events_url":"https://api.github.com/repos/alinadubatovka/gist-prototype/issues/events{/number}","events_url":"https://api.github.com/repos/alinadubatovka/gist-prototype/events","assignees_url":"https://api.github.com/repos/alinadubatovka/gist-prototype/assignees{/user}","branches_url":"https://api.github.com/repos/alinadubatovka/gist-prototype/branches{/branch}","tags_url":"https://api.github.com/repos/alinadubatovka/gist-prototype/tags","blobs_url":"https://api.github.com/repos/alinadubatovka/gist-prototype/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alinadubatovka/gist-prototype/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alinadubatovka/gist-prototype/git/refs{/sha}","trees_url":"https://api.github.com/repos/alinadubatovka/gist-prototype/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alinadubatovka/gist-prototype/statuses/{sha}","languages_url":"https://api.github.com/repos/alinadubatovka/gist-prototype/languages","stargazers_url":"https://api.github.com/repos/alinadubatovka/gist-prototype/stargazers","contributors_url":"https://api.github.com/repos/alinadubatovka/gist-prototype/contributors","subscribers_url":"https://api.github.com/repos/alinadubatovka/gist-prototype/subscribers","subscription_url":"https://api.github.com/repos/alinadubatovka/gist-prototype/subscription","commits_url":"https://api.github.com/repos/alinadubatovka/gist-prototype/commits{/sha}","git_commits_url":"https://api.github.com/repos/alinadubatovka/gist-prototype/git/commits{/sha}","comments_url":"https://api.github.com/repos/alinadubatovka/gist-prototype/comments{/number}","issue_comment_url":"https://api.github.com/repos/alinadubatovka/gist-prototype/issues/comments/{number}","contents_url":"https://api.github.com/repos/alinadubatovka/gist-prototype/contents/{+path}","compare_url":"https://api.github.com/repos/alinadubatovka/gist-prototype/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alinadubatovka/gist-prototype/merges","archive_url":"https://api.github.com/repos/alinadubatovka/gist-prototype/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alinadubatovka/gist-prototype/downloads","issues_url":"https://api.github.com/repos/alinadubatovka/gist-prototype/issues{/number}","pulls_url":"https://api.github.com/repos/alinadubatovka/gist-prototype/pulls{/number}","milestones_url":"https://api.github.com/repos/alinadubatovka/gist-prototype/milestones{/number}","notifications_url":"https://api.github.com/repos/alinadubatovka/gist-prototype/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alinadubatovka/gist-prototype/labels{/name}","releases_url":"https://api.github.com/repos/alinadubatovka/gist-prototype/releases{/id}","created_at":"2014-10-13T20:23:15Z","updated_at":"2014-10-13T20:46:26Z","pushed_at":"2014-10-27T15:20:05Z","git_url":"git://github.com/alinadubatovka/gist-prototype.git","ssh_url":"git@github.com:alinadubatovka/gist-prototype.git","clone_url":"https://github.com/alinadubatovka/gist-prototype.git","svn_url":"https://github.com/alinadubatovka/gist-prototype","homepage":null,"size":173,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"egeorg:master","ref":"master","sha":"38b001a7c16c58f06d55ba820efda801e99f1108","user":{"login":"egeorg","id":5992164,"avatar_url":"https://avatars.githubusercontent.com/u/5992164?v=2","gravatar_id":"","url":"https://api.github.com/users/egeorg","html_url":"https://github.com/egeorg","followers_url":"https://api.github.com/users/egeorg/followers","following_url":"https://api.github.com/users/egeorg/following{/other_user}","gists_url":"https://api.github.com/users/egeorg/gists{/gist_id}","starred_url":"https://api.github.com/users/egeorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/egeorg/subscriptions","organizations_url":"https://api.github.com/users/egeorg/orgs","repos_url":"https://api.github.com/users/egeorg/repos","events_url":"https://api.github.com/users/egeorg/events{/privacy}","received_events_url":"https://api.github.com/users/egeorg/received_events","type":"User","site_admin":false},"repo":{"id":24888563,"name":"gist-prototype","full_name":"egeorg/gist-prototype","owner":{"login":"egeorg","id":5992164,"avatar_url":"https://avatars.githubusercontent.com/u/5992164?v=2","gravatar_id":"","url":"https://api.github.com/users/egeorg","html_url":"https://github.com/egeorg","followers_url":"https://api.github.com/users/egeorg/followers","following_url":"https://api.github.com/users/egeorg/following{/other_user}","gists_url":"https://api.github.com/users/egeorg/gists{/gist_id}","starred_url":"https://api.github.com/users/egeorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/egeorg/subscriptions","organizations_url":"https://api.github.com/users/egeorg/orgs","repos_url":"https://api.github.com/users/egeorg/repos","events_url":"https://api.github.com/users/egeorg/events{/privacy}","received_events_url":"https://api.github.com/users/egeorg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/egeorg/gist-prototype","description":"","fork":false,"url":"https://api.github.com/repos/egeorg/gist-prototype","forks_url":"https://api.github.com/repos/egeorg/gist-prototype/forks","keys_url":"https://api.github.com/repos/egeorg/gist-prototype/keys{/key_id}","collaborators_url":"https://api.github.com/repos/egeorg/gist-prototype/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/egeorg/gist-prototype/teams","hooks_url":"https://api.github.com/repos/egeorg/gist-prototype/hooks","issue_events_url":"https://api.github.com/repos/egeorg/gist-prototype/issues/events{/number}","events_url":"https://api.github.com/repos/egeorg/gist-prototype/events","assignees_url":"https://api.github.com/repos/egeorg/gist-prototype/assignees{/user}","branches_url":"https://api.github.com/repos/egeorg/gist-prototype/branches{/branch}","tags_url":"https://api.github.com/repos/egeorg/gist-prototype/tags","blobs_url":"https://api.github.com/repos/egeorg/gist-prototype/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/egeorg/gist-prototype/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/egeorg/gist-prototype/git/refs{/sha}","trees_url":"https://api.github.com/repos/egeorg/gist-prototype/git/trees{/sha}","statuses_url":"https://api.github.com/repos/egeorg/gist-prototype/statuses/{sha}","languages_url":"https://api.github.com/repos/egeorg/gist-prototype/languages","stargazers_url":"https://api.github.com/repos/egeorg/gist-prototype/stargazers","contributors_url":"https://api.github.com/repos/egeorg/gist-prototype/contributors","subscribers_url":"https://api.github.com/repos/egeorg/gist-prototype/subscribers","subscription_url":"https://api.github.com/repos/egeorg/gist-prototype/subscription","commits_url":"https://api.github.com/repos/egeorg/gist-prototype/commits{/sha}","git_commits_url":"https://api.github.com/repos/egeorg/gist-prototype/git/commits{/sha}","comments_url":"https://api.github.com/repos/egeorg/gist-prototype/comments{/number}","issue_comment_url":"https://api.github.com/repos/egeorg/gist-prototype/issues/comments/{number}","contents_url":"https://api.github.com/repos/egeorg/gist-prototype/contents/{+path}","compare_url":"https://api.github.com/repos/egeorg/gist-prototype/compare/{base}...{head}","merges_url":"https://api.github.com/repos/egeorg/gist-prototype/merges","archive_url":"https://api.github.com/repos/egeorg/gist-prototype/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/egeorg/gist-prototype/downloads","issues_url":"https://api.github.com/repos/egeorg/gist-prototype/issues{/number}","pulls_url":"https://api.github.com/repos/egeorg/gist-prototype/pulls{/number}","milestones_url":"https://api.github.com/repos/egeorg/gist-prototype/milestones{/number}","notifications_url":"https://api.github.com/repos/egeorg/gist-prototype/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/egeorg/gist-prototype/labels{/name}","releases_url":"https://api.github.com/repos/egeorg/gist-prototype/releases{/id}","created_at":"2014-10-07T12:06:34Z","updated_at":"2014-10-15T17:32:51Z","pushed_at":"2014-10-20T17:50:37Z","git_url":"git://github.com/egeorg/gist-prototype.git","ssh_url":"git@github.com:egeorg/gist-prototype.git","clone_url":"https://github.com/egeorg/gist-prototype.git","svn_url":"https://github.com/egeorg/gist-prototype","homepage":null,"size":257,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/egeorg/gist-prototype/pulls/5"},"html":{"href":"https://github.com/egeorg/gist-prototype/pull/5"},"issue":{"href":"https://api.github.com/repos/egeorg/gist-prototype/issues/5"},"comments":{"href":"https://api.github.com/repos/egeorg/gist-prototype/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/egeorg/gist-prototype/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/egeorg/gist-prototype/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/egeorg/gist-prototype/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/egeorg/gist-prototype/statuses/bb7cdc475d9596bedb4150a5f05e4776df185305"}}}}