GitHub PullRequestReviewCommentEvent at 2014-07-07 10:37:04
Repository: phpbb
Actor: PayBas
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/phpbb/phpbb/pulls/comments/14589732","id":14589732,"diff_hunk":"@@ -1,91 +1,92 @@\n \n <!-- BEGIN forumrow -->\n \t<!-- IF (forumrow.S_IS_CAT and not forumrow.S_FIRST_ROW) or forumrow.S_NO_CAT  -->\n-\t\t\t</ul>\n-\n+\t\t\t\t\t</ul>\n+\t\t\t\t</div>\n \t\t\t</div>\n \t\t</div>\n \t<!-- ENDIF -->\n \n \t<!-- EVENT forumlist_body_category_header_before -->\n \t<!-- IF forumrow.S_IS_CAT or forumrow.S_FIRST_ROW  or forumrow.S_NO_CAT  -->\n-\t\t<div class=\"forabg\">\n-\t\t\t<div class=\"inner\">\n-\t\t\t<ul class=\"topiclist\">\n-\t\t\t\t<li class=\"header\">\n-\t\t\t\t\t<dl class=\"icon\">\n-\t\t\t\t\t\t<dt><div class=\"list-inner\"><!-- IF forumrow.S_IS_CAT --><a href=\"{forumrow.U_VIEWFORUM}\">{forumrow.FORUM_NAME}</a><!-- ELSE -->{L_FORUM}<!-- ENDIF --></div></dt>\n-\t\t\t\t\t\t<dd class=\"topics\">{L_TOPICS}</dd>\n-\t\t\t\t\t\t<dd class=\"posts\">{L_POSTS}</dd>\n-\t\t\t\t\t\t<dd class=\"lastpost\"><span>{L_LAST_POST}</span></dd>\n-\t\t\t\t\t</dl>\n-\t\t\t\t</li>\n-\t\t\t</ul>\n-\t\t\t<ul class=\"topiclist forums\">\n+\t\t<div class=\"topics\">","path":"phpBB/styles/prosilver/template/forumlist_body.html","position":27,"original_position":27,"commit_id":"661919f7ea4389cdf52b075827226743a9136913","original_commit_id":"661919f7ea4389cdf52b075827226743a9136913","user":{"login":"PayBas","id":3015760,"avatar_url":"https://avatars.githubusercontent.com/u/3015760?","gravatar_id":"09358afdb1e3b9c34c0b368002b55dee","url":"https://api.github.com/users/PayBas","html_url":"https://github.com/PayBas","followers_url":"https://api.github.com/users/PayBas/followers","following_url":"https://api.github.com/users/PayBas/following{/other_user}","gists_url":"https://api.github.com/users/PayBas/gists{/gist_id}","starred_url":"https://api.github.com/users/PayBas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PayBas/subscriptions","organizations_url":"https://api.github.com/users/PayBas/orgs","repos_url":"https://api.github.com/users/PayBas/repos","events_url":"https://api.github.com/users/PayBas/events{/privacy}","received_events_url":"https://api.github.com/users/PayBas/received_events","type":"User","site_admin":false},"body":"No it's not. This is the forum-list for the index.php page (and possibly viewforum.php if it has subforums).\r\n\r\n`forabg` simply indicates that it is the wrap/background of the forums-list.","created_at":"2014-07-07T10:37:04Z","updated_at":"2014-07-07T10:37:04Z","html_url":"https://github.com/phpbb/phpbb/pull/2702#discussion_r14589732","pull_request_url":"https://api.github.com/repos/phpbb/phpbb/pulls/2702","_links":{"self":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/comments/14589732"},"html":{"href":"https://github.com/phpbb/phpbb/pull/2702#discussion_r14589732"},"pull_request":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/2702"}}},"pull_request":{"url":"https://api.github.com/repos/phpbb/phpbb/pulls/2702","id":18017503,"html_url":"https://github.com/phpbb/phpbb/pull/2702","diff_url":"https://github.com/phpbb/phpbb/pull/2702.diff","patch_url":"https://github.com/phpbb/phpbb/pull/2702.patch","issue_url":"https://api.github.com/repos/phpbb/phpbb/issues/2702","number":2702,"state":"open","title":"[ticket/12821] Fix All gradients","user":{"login":"hanakin","id":73081,"avatar_url":"https://avatars.githubusercontent.com/u/73081?","gravatar_id":"e71d16fc7fcce713ef08faac6ae587e8","url":"https://api.github.com/users/hanakin","html_url":"https://github.com/hanakin","followers_url":"https://api.github.com/users/hanakin/followers","following_url":"https://api.github.com/users/hanakin/following{/other_user}","gists_url":"https://api.github.com/users/hanakin/gists{/gist_id}","starred_url":"https://api.github.com/users/hanakin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hanakin/subscriptions","organizations_url":"https://api.github.com/users/hanakin/orgs","repos_url":"https://api.github.com/users/hanakin/repos","events_url":"https://api.github.com/users/hanakin/events{/privacy}","received_events_url":"https://api.github.com/users/hanakin/received_events","type":"User","site_admin":false},"body":"This is two changes\r\n1. Fix all the current gradients to be consistent and handled correctly\r\n2. Replace the remaining gradient gifs with css gradients IE: .headerbar, .forabg, .forumbg, .button1-3 , .forums, .dropdown-extended .header\r\n\r\nTODO:\r\n- [x] Chrome (Mac)\r\n- [x] Firefox (Mac)\r\n- [x] Safari (Mac)\r\n- [ ] Opera (Mac)\r\n- [x] Chrome (Win)\r\n- [x] Firefox (Win)\r\n- [ ] Opera (Win)\r\n- [x] IE 8\r\n- [x] IE 9\r\n- [ ] IE 10\r\n- [x] Safari (IOS)\r\n- [x] Chrome (IOS)\r\n- [ ] Android\r\n\r\nTicket: https://tracker.phpbb.com/browse/PHPBB3-12821\r\n\r\nPHPBB3-12821","created_at":"2014-07-06T11:12:48Z","updated_at":"2014-07-07T10:37:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6ff35cf5b276de3f284dbdfb74531051954b3de1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/phpbb/phpbb/pulls/2702/commits","review_comments_url":"https://api.github.com/repos/phpbb/phpbb/pulls/2702/comments","review_comment_url":"https://api.github.com/repos/phpbb/phpbb/pulls/comments/{number}","comments_url":"https://api.github.com/repos/phpbb/phpbb/issues/2702/comments","statuses_url":"https://api.github.com/repos/phpbb/phpbb/statuses/661919f7ea4389cdf52b075827226743a9136913","head":{"label":"hanakin:ticket/12821","ref":"ticket/12821","sha":"661919f7ea4389cdf52b075827226743a9136913","user":{"login":"hanakin","id":73081,"avatar_url":"https://avatars.githubusercontent.com/u/73081?","gravatar_id":"e71d16fc7fcce713ef08faac6ae587e8","url":"https://api.github.com/users/hanakin","html_url":"https://github.com/hanakin","followers_url":"https://api.github.com/users/hanakin/followers","following_url":"https://api.github.com/users/hanakin/following{/other_user}","gists_url":"https://api.github.com/users/hanakin/gists{/gist_id}","starred_url":"https://api.github.com/users/hanakin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hanakin/subscriptions","organizations_url":"https://api.github.com/users/hanakin/orgs","repos_url":"https://api.github.com/users/hanakin/repos","events_url":"https://api.github.com/users/hanakin/events{/privacy}","received_events_url":"https://api.github.com/users/hanakin/received_events","type":"User","site_admin":false},"repo":{"id":20864087,"name":"phpbb","full_name":"hanakin/phpbb","owner":{"login":"hanakin","id":73081,"avatar_url":"https://avatars.githubusercontent.com/u/73081?","gravatar_id":"e71d16fc7fcce713ef08faac6ae587e8","url":"https://api.github.com/users/hanakin","html_url":"https://github.com/hanakin","followers_url":"https://api.github.com/users/hanakin/followers","following_url":"https://api.github.com/users/hanakin/following{/other_user}","gists_url":"https://api.github.com/users/hanakin/gists{/gist_id}","starred_url":"https://api.github.com/users/hanakin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hanakin/subscriptions","organizations_url":"https://api.github.com/users/hanakin/orgs","repos_url":"https://api.github.com/users/hanakin/repos","events_url":"https://api.github.com/users/hanakin/events{/privacy}","received_events_url":"https://api.github.com/users/hanakin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hanakin/phpbb","description":" phpBB 3 Development: phpBB is a popular open-source bulletin board written in PHP. This repository also contains the history of version 2.","fork":true,"url":"https://api.github.com/repos/hanakin/phpbb","forks_url":"https://api.github.com/repos/hanakin/phpbb/forks","keys_url":"https://api.github.com/repos/hanakin/phpbb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hanakin/phpbb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hanakin/phpbb/teams","hooks_url":"https://api.github.com/repos/hanakin/phpbb/hooks","issue_events_url":"https://api.github.com/repos/hanakin/phpbb/issues/events{/number}","events_url":"https://api.github.com/repos/hanakin/phpbb/events","assignees_url":"https://api.github.com/repos/hanakin/phpbb/assignees{/user}","branches_url":"https://api.github.com/repos/hanakin/phpbb/branches{/branch}","tags_url":"https://api.github.com/repos/hanakin/phpbb/tags","blobs_url":"https://api.github.com/repos/hanakin/phpbb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hanakin/phpbb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hanakin/phpbb/git/refs{/sha}","trees_url":"https://api.github.com/repos/hanakin/phpbb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hanakin/phpbb/statuses/{sha}","languages_url":"https://api.github.com/repos/hanakin/phpbb/languages","stargazers_url":"https://api.github.com/repos/hanakin/phpbb/stargazers","contributors_url":"https://api.github.com/repos/hanakin/phpbb/contributors","subscribers_url":"https://api.github.com/repos/hanakin/phpbb/subscribers","subscription_url":"https://api.github.com/repos/hanakin/phpbb/subscription","commits_url":"https://api.github.com/repos/hanakin/phpbb/commits{/sha}","git_commits_url":"https://api.github.com/repos/hanakin/phpbb/git/commits{/sha}","comments_url":"https://api.github.com/repos/hanakin/phpbb/comments{/number}","issue_comment_url":"https://api.github.com/repos/hanakin/phpbb/issues/comments/{number}","contents_url":"https://api.github.com/repos/hanakin/phpbb/contents/{+path}","compare_url":"https://api.github.com/repos/hanakin/phpbb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hanakin/phpbb/merges","archive_url":"https://api.github.com/repos/hanakin/phpbb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hanakin/phpbb/downloads","issues_url":"https://api.github.com/repos/hanakin/phpbb/issues{/number}","pulls_url":"https://api.github.com/repos/hanakin/phpbb/pulls{/number}","milestones_url":"https://api.github.com/repos/hanakin/phpbb/milestones{/number}","notifications_url":"https://api.github.com/repos/hanakin/phpbb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hanakin/phpbb/labels{/name}","releases_url":"https://api.github.com/repos/hanakin/phpbb/releases{/id}","created_at":"2014-06-15T20:01:50Z","updated_at":"2014-06-25T17:57:42Z","pushed_at":"2014-07-07T09:06:30Z","git_url":"git://github.com/hanakin/phpbb.git","ssh_url":"git@github.com:hanakin/phpbb.git","clone_url":"https://github.com/hanakin/phpbb.git","svn_url":"https://github.com/hanakin/phpbb","homepage":"http://www.phpbb.com","size":46452,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop-ascraeus"}},"base":{"label":"phpbb:develop-ascraeus","ref":"develop-ascraeus","sha":"3a317edc9295812343038146caa6082e8b6f7483","user":{"login":"phpbb","id":176697,"avatar_url":"https://avatars.githubusercontent.com/u/176697?","gravatar_id":"cf23934d15908c132f1c236369262eb6","url":"https://api.github.com/users/phpbb","html_url":"https://github.com/phpbb","followers_url":"https://api.github.com/users/phpbb/followers","following_url":"https://api.github.com/users/phpbb/following{/other_user}","gists_url":"https://api.github.com/users/phpbb/gists{/gist_id}","starred_url":"https://api.github.com/users/phpbb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phpbb/subscriptions","organizations_url":"https://api.github.com/users/phpbb/orgs","repos_url":"https://api.github.com/users/phpbb/repos","events_url":"https://api.github.com/users/phpbb/events{/privacy}","received_events_url":"https://api.github.com/users/phpbb/received_events","type":"Organization","site_admin":false},"repo":{"id":541983,"name":"phpbb","full_name":"phpbb/phpbb","owner":{"login":"phpbb","id":176697,"avatar_url":"https://avatars.githubusercontent.com/u/176697?","gravatar_id":"cf23934d15908c132f1c236369262eb6","url":"https://api.github.com/users/phpbb","html_url":"https://github.com/phpbb","followers_url":"https://api.github.com/users/phpbb/followers","following_url":"https://api.github.com/users/phpbb/following{/other_user}","gists_url":"https://api.github.com/users/phpbb/gists{/gist_id}","starred_url":"https://api.github.com/users/phpbb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phpbb/subscriptions","organizations_url":"https://api.github.com/users/phpbb/orgs","repos_url":"https://api.github.com/users/phpbb/repos","events_url":"https://api.github.com/users/phpbb/events{/privacy}","received_events_url":"https://api.github.com/users/phpbb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/phpbb/phpbb","description":" phpBB 3 Development: phpBB is a popular open-source bulletin board written in PHP. This repository also contains the history of version 2.","fork":false,"url":"https://api.github.com/repos/phpbb/phpbb","forks_url":"https://api.github.com/repos/phpbb/phpbb/forks","keys_url":"https://api.github.com/repos/phpbb/phpbb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phpbb/phpbb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phpbb/phpbb/teams","hooks_url":"https://api.github.com/repos/phpbb/phpbb/hooks","issue_events_url":"https://api.github.com/repos/phpbb/phpbb/issues/events{/number}","events_url":"https://api.github.com/repos/phpbb/phpbb/events","assignees_url":"https://api.github.com/repos/phpbb/phpbb/assignees{/user}","branches_url":"https://api.github.com/repos/phpbb/phpbb/branches{/branch}","tags_url":"https://api.github.com/repos/phpbb/phpbb/tags","blobs_url":"https://api.github.com/repos/phpbb/phpbb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phpbb/phpbb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phpbb/phpbb/git/refs{/sha}","trees_url":"https://api.github.com/repos/phpbb/phpbb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phpbb/phpbb/statuses/{sha}","languages_url":"https://api.github.com/repos/phpbb/phpbb/languages","stargazers_url":"https://api.github.com/repos/phpbb/phpbb/stargazers","contributors_url":"https://api.github.com/repos/phpbb/phpbb/contributors","subscribers_url":"https://api.github.com/repos/phpbb/phpbb/subscribers","subscription_url":"https://api.github.com/repos/phpbb/phpbb/subscription","commits_url":"https://api.github.com/repos/phpbb/phpbb/commits{/sha}","git_commits_url":"https://api.github.com/repos/phpbb/phpbb/git/commits{/sha}","comments_url":"https://api.github.com/repos/phpbb/phpbb/comments{/number}","issue_comment_url":"https://api.github.com/repos/phpbb/phpbb/issues/comments/{number}","contents_url":"https://api.github.com/repos/phpbb/phpbb/contents/{+path}","compare_url":"https://api.github.com/repos/phpbb/phpbb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phpbb/phpbb/merges","archive_url":"https://api.github.com/repos/phpbb/phpbb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phpbb/phpbb/downloads","issues_url":"https://api.github.com/repos/phpbb/phpbb/issues{/number}","pulls_url":"https://api.github.com/repos/phpbb/phpbb/pulls{/number}","milestones_url":"https://api.github.com/repos/phpbb/phpbb/milestones{/number}","notifications_url":"https://api.github.com/repos/phpbb/phpbb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phpbb/phpbb/labels{/name}","releases_url":"https://api.github.com/repos/phpbb/phpbb/releases{/id}","created_at":"2010-03-01T22:33:17Z","updated_at":"2014-07-05T17:25:35Z","pushed_at":"2014-07-07T08:34:17Z","git_url":"git://github.com/phpbb/phpbb.git","ssh_url":"git@github.com:phpbb/phpbb.git","clone_url":"https://github.com/phpbb/phpbb.git","svn_url":"https://github.com/phpbb/phpbb","homepage":"http://www.phpbb.com","size":99992,"stargazers_count":629,"watchers_count":629,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":364,"mirror_url":null,"open_issues_count":67,"forks":364,"open_issues":67,"watchers":629,"default_branch":"develop-ascraeus"}},"_links":{"self":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/2702"},"html":{"href":"https://github.com/phpbb/phpbb/pull/2702"},"issue":{"href":"https://api.github.com/repos/phpbb/phpbb/issues/2702"},"comments":{"href":"https://api.github.com/repos/phpbb/phpbb/issues/2702/comments"},"review_comments":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/2702/comments"},"review_comment":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/2702/commits"},"statuses":{"href":"https://api.github.com/repos/phpbb/phpbb/statuses/661919f7ea4389cdf52b075827226743a9136913"}}}}