GitHub PullRequestReviewCommentEvent at 2014-05-30 15:45:20
Repository: dolphin
Actor: degasus
Payload: {"comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/13234872","id":13234872,"diff_hunk":"@@ -247,32 +247,43 @@ void VertexShaderManager::SetConstants()\n \t\t// lights don't have a 1 to 1 mapping, the color component needs to be converted to 4 floats\n \t\tint istart = nLightsChanged[0] / 0x10;\n \t\tint iend = (nLightsChanged[1] + 15) / 0x10;\n-\t\tconst float* xfmemptr = (const float*)&xfmem.lights[0x10 * istart];\n \n \t\tfor (int i = istart; i < iend; ++i)\n \t\t{\n-\t\t\tu32 color = *(const u32*)(xfmemptr + 3);\n-\t\t\tconstants.light_colors[i][0] = (color >> 24) & 0xFF;\n-\t\t\tconstants.light_colors[i][1] = (color >> 16) & 0xFF;\n-\t\t\tconstants.light_colors[i][2] = (color >> 8)  & 0xFF;\n-\t\t\tconstants.light_colors[i][3] = (color)       & 0xFF;\n-\t\t\txfmemptr += 4;\n-\n-\t\t\tfor (int j = 0; j < 4; ++j, xfmemptr += 3)\n+\t\t\tLight& light = xfmem.lights[i];\n+\t\t\tVertexShaderConstants::Light& dstlight = constants.lights[i];\n+\n+\t\t\tdstlight.color[0] = light.color[3];","path":"Source/Core/VideoCommon/VertexShaderManager.cpp","position":19,"original_position":19,"commit_id":"50bf7fdc800e09e6eaede1e7483827f660a97bff","original_commit_id":"50bf7fdc800e09e6eaede1e7483827f660a97bff","user":{"login":"degasus","id":2787141,"avatar_url":"https://avatars.githubusercontent.com/u/2787141?","gravatar_id":"2a6aaa713b73414f2b78d0645fd67690","url":"https://api.github.com/users/degasus","html_url":"https://github.com/degasus","followers_url":"https://api.github.com/users/degasus/followers","following_url":"https://api.github.com/users/degasus/following{/other_user}","gists_url":"https://api.github.com/users/degasus/gists{/gist_id}","starred_url":"https://api.github.com/users/degasus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/degasus/subscriptions","organizations_url":"https://api.github.com/users/degasus/orgs","repos_url":"https://api.github.com/users/degasus/repos","events_url":"https://api.github.com/users/degasus/events{/privacy}","received_events_url":"https://api.github.com/users/degasus/received_events","type":"User","site_admin":false},"body":"Do you mean which one is red, green, blue?","created_at":"2014-05-30T15:45:20Z","updated_at":"2014-05-30T15:45:20Z","html_url":"https://github.com/dolphin-emu/dolphin/pull/439#discussion_r13234872","pull_request_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/439","_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/13234872"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/439#discussion_r13234872"},"pull_request":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/439"}}}}