GitHub PullRequestReviewCommentEvent at 2014-06-02 10:58:19
Repository: HPCC-Platform
Actor: jakesmith
Payload: {"comment":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/13279128","id":13279128,"diff_hunk":"@@ -86,8 +86,13 @@ public:\n     {\n         if (connected)\n         {\n-            bool deleteRoot = false;","path":"dali/base/dacsds.ipp","position":4,"original_position":4,"commit_id":"212a5946ff663f81e02bcb078b32aa054d600a01","original_commit_id":"212a5946ff663f81e02bcb078b32aa054d600a01","user":{"login":"jakesmith","id":902700,"avatar_url":"https://avatars.githubusercontent.com/u/902700?","gravatar_id":"8eff4f840b1605e58ce34b0c3b5eea5a","url":"https://api.github.com/users/jakesmith","html_url":"https://github.com/jakesmith","followers_url":"https://api.github.com/users/jakesmith/followers","following_url":"https://api.github.com/users/jakesmith/following{/other_user}","gists_url":"https://api.github.com/users/jakesmith/gists{/gist_id}","starred_url":"https://api.github.com/users/jakesmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakesmith/subscriptions","organizations_url":"https://api.github.com/users/jakesmith/orgs","repos_url":"https://api.github.com/users/jakesmith/repos","events_url":"https://api.github.com/users/jakesmith/events{/privacy}","received_events_url":"https://api.github.com/users/jakesmith/received_events","type":"User","site_admin":false},"body":"could do..\r\nI consider this invalid use, to leave dangling object after SDS has closed down..\r\n\r\nBut, if I simply mark as connected=false , then it becomes valid to shutdown SDS before connections are destroyed.. \r\nWhich could be regarded as a feature..\r\n\r\nI'm undecided.. it could be useful to spot \"leaked\" connections like this that were supposed to be disconnected before client closedown....\r\n","created_at":"2014-06-02T10:58:19Z","updated_at":"2014-06-02T10:58:19Z","html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/5979#discussion_r13279128","pull_request_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/5979","_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/13279128"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/5979#discussion_r13279128"},"pull_request":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/5979"}}}}