GitHub PullRequestReviewCommentEvent at 2014-09-18 00:20:00
Repository: rust
Actor: nick29581
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/17702727","id":17702727,"diff_hunk":"@@ -212,15 +212,15 @@ pub enum Json {\n     I64(i64),\n     U64(u64),\n     F64(f64),\n-    String(String),\n+    String(string::String),\n     Boolean(bool),\n-    List(List),\n-    Object(Object),\n+    Array(List),","path":"src/libserialize/json.rs","position":null,"original_position":18,"commit_id":"5af123d7c5a32818dda582e98c2083ad6de2829d","original_commit_id":"2279fbb956d5a2b9a554ba65acbc3661ca8b239b","user":{"login":"nick29581","id":762626,"avatar_url":"https://avatars.githubusercontent.com/u/762626?v=2","gravatar_id":"fbd53a3405ed31e6e3a1fe235ca797be","url":"https://api.github.com/users/nick29581","html_url":"https://github.com/nick29581","followers_url":"https://api.github.com/users/nick29581/followers","following_url":"https://api.github.com/users/nick29581/following{/other_user}","gists_url":"https://api.github.com/users/nick29581/gists{/gist_id}","starred_url":"https://api.github.com/users/nick29581/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nick29581/subscriptions","organizations_url":"https://api.github.com/users/nick29581/orgs","repos_url":"https://api.github.com/users/nick29581/repos","events_url":"https://api.github.com/users/nick29581/events{/privacy}","received_events_url":"https://api.github.com/users/nick29581/received_events","type":"User","site_admin":false},"body":"So I fixed this as List{JsonList) to be consistent with Object. I thought changing to Array(JsonArray) was a bigger change and overstepped the mark of this PR.","created_at":"2014-09-18T00:20:00Z","updated_at":"2014-09-18T00:20:00Z","html_url":"https://github.com/rust-lang/rust/pull/17338#discussion_r17702727","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/17338","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/17702727"},"html":{"href":"https://github.com/rust-lang/rust/pull/17338#discussion_r17702727"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/17338"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/17338","id":21354981,"html_url":"https://github.com/rust-lang/rust/pull/17338","diff_url":"https://github.com/rust-lang/rust/pull/17338.diff","patch_url":"https://github.com/rust-lang/rust/pull/17338.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/17338","number":17338,"state":"open","locked":false,"title":"Add enum variants to the type namespace","user":{"login":"nick29581","id":762626,"avatar_url":"https://avatars.githubusercontent.com/u/762626?v=2","gravatar_id":"fbd53a3405ed31e6e3a1fe235ca797be","url":"https://api.github.com/users/nick29581","html_url":"https://github.com/nick29581","followers_url":"https://api.github.com/users/nick29581/followers","following_url":"https://api.github.com/users/nick29581/following{/other_user}","gists_url":"https://api.github.com/users/nick29581/gists{/gist_id}","starred_url":"https://api.github.com/users/nick29581/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nick29581/subscriptions","organizations_url":"https://api.github.com/users/nick29581/orgs","repos_url":"https://api.github.com/users/nick29581/repos","events_url":"https://api.github.com/users/nick29581/events{/privacy}","received_events_url":"https://api.github.com/users/nick29581/received_events","type":"User","site_admin":false},"body":"Change to resolve and update compiler and libs for uses.\r\n\r\n[breaking-change]\r\n\r\nEnum variants are now in both the value and type namespaces. This means that\r\nif you have a variant with the same name as a type in scope in a module, you\r\nwill get a name clash and thus an error. The solution is to either rename the\r\ntype or the variant.\r\n\r\ncloses #17323\r\n\r\nr? anyone? (I realise this still needs a cfail test (and the commit message, I just noticed), but otherwise does it look OK? I expect some of the new names could be better).","created_at":"2014-09-17T09:41:58Z","updated_at":"2014-09-18T00:20:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fcd79c914b7cd0403f997aaa380170de2a300491","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/17338/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/17338/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/17338/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/5af123d7c5a32818dda582e98c2083ad6de2829d","head":{"label":"nick29581:variants-namespace","ref":"variants-namespace","sha":"5af123d7c5a32818dda582e98c2083ad6de2829d","user":{"login":"nick29581","id":762626,"avatar_url":"https://avatars.githubusercontent.com/u/762626?v=2","gravatar_id":"fbd53a3405ed31e6e3a1fe235ca797be","url":"https://api.github.com/users/nick29581","html_url":"https://github.com/nick29581","followers_url":"https://api.github.com/users/nick29581/followers","following_url":"https://api.github.com/users/nick29581/following{/other_user}","gists_url":"https://api.github.com/users/nick29581/gists{/gist_id}","starred_url":"https://api.github.com/users/nick29581/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nick29581/subscriptions","organizations_url":"https://api.github.com/users/nick29581/orgs","repos_url":"https://api.github.com/users/nick29581/repos","events_url":"https://api.github.com/users/nick29581/events{/privacy}","received_events_url":"https://api.github.com/users/nick29581/received_events","type":"User","site_admin":false},"repo":{"id":11998169,"name":"rust","full_name":"nick29581/rust","owner":{"login":"nick29581","id":762626,"avatar_url":"https://avatars.githubusercontent.com/u/762626?v=2","gravatar_id":"fbd53a3405ed31e6e3a1fe235ca797be","url":"https://api.github.com/users/nick29581","html_url":"https://github.com/nick29581","followers_url":"https://api.github.com/users/nick29581/followers","following_url":"https://api.github.com/users/nick29581/following{/other_user}","gists_url":"https://api.github.com/users/nick29581/gists{/gist_id}","starred_url":"https://api.github.com/users/nick29581/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nick29581/subscriptions","organizations_url":"https://api.github.com/users/nick29581/orgs","repos_url":"https://api.github.com/users/nick29581/repos","events_url":"https://api.github.com/users/nick29581/events{/privacy}","received_events_url":"https://api.github.com/users/nick29581/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nick29581/rust","description":"a safe, concurrent, practical language","fork":true,"url":"https://api.github.com/repos/nick29581/rust","forks_url":"https://api.github.com/repos/nick29581/rust/forks","keys_url":"https://api.github.com/repos/nick29581/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nick29581/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nick29581/rust/teams","hooks_url":"https://api.github.com/repos/nick29581/rust/hooks","issue_events_url":"https://api.github.com/repos/nick29581/rust/issues/events{/number}","events_url":"https://api.github.com/repos/nick29581/rust/events","assignees_url":"https://api.github.com/repos/nick29581/rust/assignees{/user}","branches_url":"https://api.github.com/repos/nick29581/rust/branches{/branch}","tags_url":"https://api.github.com/repos/nick29581/rust/tags","blobs_url":"https://api.github.com/repos/nick29581/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nick29581/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nick29581/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/nick29581/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nick29581/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/nick29581/rust/languages","stargazers_url":"https://api.github.com/repos/nick29581/rust/stargazers","contributors_url":"https://api.github.com/repos/nick29581/rust/contributors","subscribers_url":"https://api.github.com/repos/nick29581/rust/subscribers","subscription_url":"https://api.github.com/repos/nick29581/rust/subscription","commits_url":"https://api.github.com/repos/nick29581/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/nick29581/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/nick29581/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/nick29581/rust/issues/comments/{number}","contents_url":"https://api.github.com/repos/nick29581/rust/contents/{+path}","compare_url":"https://api.github.com/repos/nick29581/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nick29581/rust/merges","archive_url":"https://api.github.com/repos/nick29581/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nick29581/rust/downloads","issues_url":"https://api.github.com/repos/nick29581/rust/issues{/number}","pulls_url":"https://api.github.com/repos/nick29581/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/nick29581/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/nick29581/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nick29581/rust/labels{/name}","releases_url":"https://api.github.com/repos/nick29581/rust/releases{/id}","created_at":"2013-08-09T10:00:46Z","updated_at":"2014-08-26T00:37:24Z","pushed_at":"2014-09-18T00:18:20Z","git_url":"git://github.com/nick29581/rust.git","ssh_url":"git@github.com:nick29581/rust.git","clone_url":"https://github.com/nick29581/rust.git","svn_url":"https://github.com/nick29581/rust","homepage":"http://www.rust-lang.org","size":218400,"stargazers_count":1,"watchers_count":1,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"8067f4425d245a210c732a0333245fbe83190e89","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=2","gravatar_id":"a4268b59e433144466a0f67cbcfd8cdc","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=2","gravatar_id":"a4268b59e433144466a0f67cbcfd8cdc","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"a safe, concurrent, practical language","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments/{number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","created_at":"2010-06-16T20:39:03Z","updated_at":"2014-09-17T22:51:22Z","pushed_at":"2014-09-17T23:45:37Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"http://www.rust-lang.org","size":463641,"stargazers_count":6435,"watchers_count":6435,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1274,"mirror_url":null,"open_issues_count":1949,"forks":1274,"open_issues":1949,"watchers":6435,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/17338"},"html":{"href":"https://github.com/rust-lang/rust/pull/17338"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/17338"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/17338/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/17338/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/17338/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/5af123d7c5a32818dda582e98c2083ad6de2829d"}}}}