GitHub PullRequestReviewCommentEvent at 2014-01-03 12:11:41
Repository: core
Actor: ediosyncratic
Payload: {"comment":{"url":"https://api.github.com/repos/cfengine/core/pulls/comments/8633037","id":8633037,"diff_hunk":"@@ -45,7 +45,7 @@ bool IsPendingTermination(void)\n  * using select() with real sockets. This means also using send() and recv()\n  * instead of write() and read().\n  */\n-void MakeSignalPipe()\n+void MakeSignalPipe(void)","path":"libpromises/signals.c","position":23,"original_position":23,"commit_id":"055bd225522ed912c27ffe87e7b38611d496dc0a","original_commit_id":"055bd225522ed912c27ffe87e7b38611d496dc0a","user":{"login":"ediosyncratic","id":2255042,"avatar_url":"https://gravatar.com/avatar/bbe766bb0c7aee798888f5de85063c8c?d=https%3A%2F%2Fidenticons.github.com%2Ff3e9467a13890e88f3cb0e85a8792507.png&r=x","gravatar_id":"bbe766bb0c7aee798888f5de85063c8c","url":"https://api.github.com/users/ediosyncratic","html_url":"https://github.com/ediosyncratic","followers_url":"https://api.github.com/users/ediosyncratic/followers","following_url":"https://api.github.com/users/ediosyncratic/following{/other_user}","gists_url":"https://api.github.com/users/ediosyncratic/gists{/gist_id}","starred_url":"https://api.github.com/users/ediosyncratic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ediosyncratic/subscriptions","organizations_url":"https://api.github.com/users/ediosyncratic/orgs","repos_url":"https://api.github.com/users/ediosyncratic/repos","events_url":"https://api.github.com/users/ediosyncratic/events{/privacy}","received_events_url":"https://api.github.com/users/ediosyncratic/received_events","type":"User","site_admin":false},"body":"The (void) is harmless, but not needed in a definition (where the function has a body that implements it); it's only needed in a declaration (where there is no implementation).  Traditional-K&R C would have actual arguments between the declaration-like first line of the definition and its body, so the lack of any makes the definition unambiguously take no arguments; but the plain declaration doesn't have that, so can't distinguish between no args and unspecified args.  So you only need the (void) in the header's declaration, you don't need it here - but it does no harm here.","created_at":"2014-01-03T12:11:41Z","updated_at":"2014-01-03T12:11:41Z","html_url":"https://github.com/cfengine/core/pull/1230#discussion_r8633037","pull_request_url":"https://api.github.com/repos/cfengine/core/pulls/1230","_links":{"self":{"href":"https://api.github.com/repos/cfengine/core/pulls/comments/8633037"},"html":{"href":"https://github.com/cfengine/core/pull/1230#discussion_r8633037"},"pull_request":{"href":"https://api.github.com/repos/cfengine/core/pulls/1230"}}}}