GitHub PullRequestReviewCommentEvent at 2014-12-12 16:09:23
Repository: accelerated_claims
Actor: houndci
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/pulls/comments/21753583","id":21753583,"diff_hunk":"@@ -80,33 +102,29 @@\n \n   context 'when property address is populated' do\n     let(:postcode) { 'BH22 8HR' }\n-    let(:production_json) do\n+    let(:court_data) do\n       [{\n-         'name' => 'Bournemouth and Poole County Court and Family Court',\n-         'address' => {\n-           'town' => 'Bournemouth',\n-           'address_lines' => ['Bournemouth and Poole County Court and Family Court hearing centre',\n-                               'Courts of Justice',\n-                               'Deansleigh Road'],\n-           'type' => 'Visiting',\n-           'postcode' => 'BH7 7DS',\n-           'county' => 'Dorset'\n-         }\n-       }].to_json\n+          'name' => 'Bournemouth and Poole County Court and Family Court',\n+          'address' => {\n+            'town' => 'Bournemouth',\n+            'address_lines' => ['Bournemouth and Poole County Court and Family Court hearing centre',\n+                                'Courts of Justice',\n+                                'Deansleigh Road'],\n+            'type' => 'Visiting',\n+            'postcode' => 'BH7 7DS',\n+            'county' => 'Dorset'\n+          }\n+       }]\n     end\n \n-    let(:json) {\n-      ENV['env'] == 'production' ? production_json : \\\n-        CourtfinderController::TEST_RESPONSE_DATA.to_json\n-    }\n-\n     let(:court_name) do\n-      bournemouth = 'Bournemouth and Poole County Court and Family Court'\n-      cambridge = 'Cambridge County Court and Family Court'\n-      ENV['env'] == 'production' ?  bournemouth : cambridge\n+      'Bournemouth and Poole County Court and Family Court'\n     end\n \n-    before { court_finder_stub(postcode, body: json) }\n+    before {","path":"spec/features/court_address_lookup_spec.rb","position":73,"original_position":73,"commit_id":"985c436313f9dffe7fba7039ee3cc7499ba29cf0","original_commit_id":"985c436313f9dffe7fba7039ee3cc7499ba29cf0","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Avoid using {...} for multi-line blocks.","created_at":"2014-12-12T16:09:23Z","updated_at":"2014-12-12T16:09:23Z","html_url":"https://github.com/ministryofjustice/accelerated_claims/pull/563#discussion_r21753583","pull_request_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/pulls/563","_links":{"self":{"href":"https://api.github.com/repos/ministryofjustice/accelerated_claims/pulls/comments/21753583"},"html":{"href":"https://github.com/ministryofjustice/accelerated_claims/pull/563#discussion_r21753583"},"pull_request":{"href":"https://api.github.com/repos/ministryofjustice/accelerated_claims/pulls/563"}}},"pull_request":{"url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/pulls/563","id":25982113,"html_url":"https://github.com/ministryofjustice/accelerated_claims/pull/563","diff_url":"https://github.com/ministryofjustice/accelerated_claims/pull/563.diff","patch_url":"https://github.com/ministryofjustice/accelerated_claims/pull/563.patch","issue_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/issues/563","number":563,"state":"open","locked":false,"title":"Stub away","user":{"login":"dotemacs","id":152363,"avatar_url":"https://avatars.githubusercontent.com/u/152363?v=3","gravatar_id":"","url":"https://api.github.com/users/dotemacs","html_url":"https://github.com/dotemacs","followers_url":"https://api.github.com/users/dotemacs/followers","following_url":"https://api.github.com/users/dotemacs/following{/other_user}","gists_url":"https://api.github.com/users/dotemacs/gists{/gist_id}","starred_url":"https://api.github.com/users/dotemacs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotemacs/subscriptions","organizations_url":"https://api.github.com/users/dotemacs/orgs","repos_url":"https://api.github.com/users/dotemacs/repos","events_url":"https://api.github.com/users/dotemacs/events{/privacy}","received_events_url":"https://api.github.com/users/dotemacs/received_events","type":"User","site_admin":false},"body":"Removed the setup where the Courtfinder would act differently depending on what environment it ran under.\r\n\r\nNow all the responses for the Courtfinder lookup are stubbed out, as you would expect.\r\n\r\n:helicopter: ","created_at":"2014-12-12T15:49:17Z","updated_at":"2014-12-12T16:09:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"916264e60e3d3c55d6b69e22e5817c68310a8f59","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/pulls/563/commits","review_comments_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/pulls/563/comments","review_comment_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/issues/563/comments","statuses_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/statuses/985c436313f9dffe7fba7039ee3cc7499ba29cf0","head":{"label":"ministryofjustice:stub-away","ref":"stub-away","sha":"985c436313f9dffe7fba7039ee3cc7499ba29cf0","user":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars.githubusercontent.com/u/2203574?v=3","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"repo":{"id":16478131,"name":"accelerated_claims","full_name":"ministryofjustice/accelerated_claims","owner":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars.githubusercontent.com/u/2203574?v=3","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ministryofjustice/accelerated_claims","description":"Accelerated Claims app","fork":false,"url":"https://api.github.com/repos/ministryofjustice/accelerated_claims","forks_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/forks","keys_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/teams","hooks_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/hooks","issue_events_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/issues/events{/number}","events_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/events","assignees_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/assignees{/user}","branches_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/branches{/branch}","tags_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/tags","blobs_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/git/refs{/sha}","trees_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/statuses/{sha}","languages_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/languages","stargazers_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/stargazers","contributors_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/contributors","subscribers_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/subscribers","subscription_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/subscription","commits_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/commits{/sha}","git_commits_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/git/commits{/sha}","comments_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/comments{/number}","issue_comment_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/issues/comments/{number}","contents_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/contents/{+path}","compare_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/merges","archive_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/downloads","issues_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/issues{/number}","pulls_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/pulls{/number}","milestones_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/milestones{/number}","notifications_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/labels{/name}","releases_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/releases{/id}","created_at":"2014-02-03T11:56:45Z","updated_at":"2014-12-11T09:30:08Z","pushed_at":"2014-12-12T16:09:16Z","git_url":"git://github.com/ministryofjustice/accelerated_claims.git","ssh_url":"git@github.com:ministryofjustice/accelerated_claims.git","clone_url":"https://github.com/ministryofjustice/accelerated_claims.git","svn_url":"https://github.com/ministryofjustice/accelerated_claims","homepage":null,"size":41368,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":7,"forks":0,"open_issues":7,"watchers":0,"default_branch":"master"}},"base":{"label":"ministryofjustice:master","ref":"master","sha":"3023ddd8ec79f18371d07c26379aa72ef515446d","user":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars.githubusercontent.com/u/2203574?v=3","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"repo":{"id":16478131,"name":"accelerated_claims","full_name":"ministryofjustice/accelerated_claims","owner":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars.githubusercontent.com/u/2203574?v=3","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ministryofjustice/accelerated_claims","description":"Accelerated Claims app","fork":false,"url":"https://api.github.com/repos/ministryofjustice/accelerated_claims","forks_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/forks","keys_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/teams","hooks_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/hooks","issue_events_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/issues/events{/number}","events_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/events","assignees_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/assignees{/user}","branches_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/branches{/branch}","tags_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/tags","blobs_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/git/refs{/sha}","trees_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/statuses/{sha}","languages_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/languages","stargazers_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/stargazers","contributors_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/contributors","subscribers_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/subscribers","subscription_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/subscription","commits_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/commits{/sha}","git_commits_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/git/commits{/sha}","comments_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/comments{/number}","issue_comment_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/issues/comments/{number}","contents_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/contents/{+path}","compare_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/merges","archive_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/downloads","issues_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/issues{/number}","pulls_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/pulls{/number}","milestones_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/milestones{/number}","notifications_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/labels{/name}","releases_url":"https://api.github.com/repos/ministryofjustice/accelerated_claims/releases{/id}","created_at":"2014-02-03T11:56:45Z","updated_at":"2014-12-11T09:30:08Z","pushed_at":"2014-12-12T16:09:16Z","git_url":"git://github.com/ministryofjustice/accelerated_claims.git","ssh_url":"git@github.com:ministryofjustice/accelerated_claims.git","clone_url":"https://github.com/ministryofjustice/accelerated_claims.git","svn_url":"https://github.com/ministryofjustice/accelerated_claims","homepage":null,"size":41368,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":7,"forks":0,"open_issues":7,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ministryofjustice/accelerated_claims/pulls/563"},"html":{"href":"https://github.com/ministryofjustice/accelerated_claims/pull/563"},"issue":{"href":"https://api.github.com/repos/ministryofjustice/accelerated_claims/issues/563"},"comments":{"href":"https://api.github.com/repos/ministryofjustice/accelerated_claims/issues/563/comments"},"review_comments":{"href":"https://api.github.com/repos/ministryofjustice/accelerated_claims/pulls/563/comments"},"review_comment":{"href":"https://api.github.com/repos/ministryofjustice/accelerated_claims/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ministryofjustice/accelerated_claims/pulls/563/commits"},"statuses":{"href":"https://api.github.com/repos/ministryofjustice/accelerated_claims/statuses/985c436313f9dffe7fba7039ee3cc7499ba29cf0"}}}}