GitHub PullRequestEvent at 2014-09-16 06:09:19
Repository: schema
Actor: w01fe
Payload: {"action":"opened","number":146,"pull_request":{"url":"https://api.github.com/repos/Prismatic/schema/pulls/146","id":21278159,"html_url":"https://github.com/Prismatic/schema/pull/146","diff_url":"https://github.com/Prismatic/schema/pull/146.diff","patch_url":"https://github.com/Prismatic/schema/pull/146.patch","issue_url":"https://api.github.com/repos/Prismatic/schema/issues/146","number":146,"state":"open","locked":false,"title":"Deprecate old ^{:s } syntax","user":{"login":"w01fe","id":135078,"avatar_url":"https://avatars.githubusercontent.com/u/135078?v=2","gravatar_id":"e6b62d981155b5945a29d84a2e439663","url":"https://api.github.com/users/w01fe","html_url":"https://github.com/w01fe","followers_url":"https://api.github.com/users/w01fe/followers","following_url":"https://api.github.com/users/w01fe/following{/other_user}","gists_url":"https://api.github.com/users/w01fe/gists{/gist_id}","starred_url":"https://api.github.com/users/w01fe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w01fe/subscriptions","organizations_url":"https://api.github.com/users/w01fe/orgs","repos_url":"https://api.github.com/users/w01fe/repos","events_url":"https://api.github.com/users/w01fe/events{/privacy}","received_events_url":"https://api.github.com/users/w01fe/received_events","type":"User","site_admin":false},"body":"The `^{:s ...}` syntax predates the introduction of `:-` syntax (and the public release), and introduces complexity and style variation without buying anything.  A subsequent release will most likely remove this syntax, while retaining just the ability to use `^Class` syntax to provide type hint overrides (for avoiding reflection) to Clojure. \r\n\r\nFor example, in\r\n```clojure\r\n(s/defn foo :- String\r\n ...)\r\n\r\n(s/defn ^String bar :- (s/pred #(and (string? %) (< 10 (count %))) 'short-string?)\r\n ...)\r\n```\r\n\r\n`foo` has both output schema and Clojure type-hint `String`, whereas `bar` has a more complex output schema but still the `String` type hint. \r\n\r\nThis seems like it should be uncontroversial, but if it will cause issues for anyone please comment here.","created_at":"2014-09-16T06:09:19Z","updated_at":"2014-09-16T06:09:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Prismatic/schema/pulls/146/commits","review_comments_url":"https://api.github.com/repos/Prismatic/schema/pulls/146/comments","review_comment_url":"https://api.github.com/repos/Prismatic/schema/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Prismatic/schema/issues/146/comments","statuses_url":"https://api.github.com/repos/Prismatic/schema/statuses/ebbde95c1b30facdebfe613a72e67603d77fd02a","head":{"label":"Prismatic:deprecate-old-syntax","ref":"deprecate-old-syntax","sha":"ebbde95c1b30facdebfe613a72e67603d77fd02a","user":{"login":"Prismatic","id":1073038,"avatar_url":"https://avatars.githubusercontent.com/u/1073038?v=2","gravatar_id":"46e1fc9156d7e5bfdacdfa68acda4b9a","url":"https://api.github.com/users/Prismatic","html_url":"https://github.com/Prismatic","followers_url":"https://api.github.com/users/Prismatic/followers","following_url":"https://api.github.com/users/Prismatic/following{/other_user}","gists_url":"https://api.github.com/users/Prismatic/gists{/gist_id}","starred_url":"https://api.github.com/users/Prismatic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Prismatic/subscriptions","organizations_url":"https://api.github.com/users/Prismatic/orgs","repos_url":"https://api.github.com/users/Prismatic/repos","events_url":"https://api.github.com/users/Prismatic/events{/privacy}","received_events_url":"https://api.github.com/users/Prismatic/received_events","type":"Organization","site_admin":false},"repo":{"id":11594840,"name":"schema","full_name":"Prismatic/schema","owner":{"login":"Prismatic","id":1073038,"avatar_url":"https://avatars.githubusercontent.com/u/1073038?v=2","gravatar_id":"46e1fc9156d7e5bfdacdfa68acda4b9a","url":"https://api.github.com/users/Prismatic","html_url":"https://github.com/Prismatic","followers_url":"https://api.github.com/users/Prismatic/followers","following_url":"https://api.github.com/users/Prismatic/following{/other_user}","gists_url":"https://api.github.com/users/Prismatic/gists{/gist_id}","starred_url":"https://api.github.com/users/Prismatic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Prismatic/subscriptions","organizations_url":"https://api.github.com/users/Prismatic/orgs","repos_url":"https://api.github.com/users/Prismatic/repos","events_url":"https://api.github.com/users/Prismatic/events{/privacy}","received_events_url":"https://api.github.com/users/Prismatic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Prismatic/schema","description":"Clojure(Script) library for declarative data description and validation","fork":false,"url":"https://api.github.com/repos/Prismatic/schema","forks_url":"https://api.github.com/repos/Prismatic/schema/forks","keys_url":"https://api.github.com/repos/Prismatic/schema/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Prismatic/schema/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Prismatic/schema/teams","hooks_url":"https://api.github.com/repos/Prismatic/schema/hooks","issue_events_url":"https://api.github.com/repos/Prismatic/schema/issues/events{/number}","events_url":"https://api.github.com/repos/Prismatic/schema/events","assignees_url":"https://api.github.com/repos/Prismatic/schema/assignees{/user}","branches_url":"https://api.github.com/repos/Prismatic/schema/branches{/branch}","tags_url":"https://api.github.com/repos/Prismatic/schema/tags","blobs_url":"https://api.github.com/repos/Prismatic/schema/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Prismatic/schema/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Prismatic/schema/git/refs{/sha}","trees_url":"https://api.github.com/repos/Prismatic/schema/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Prismatic/schema/statuses/{sha}","languages_url":"https://api.github.com/repos/Prismatic/schema/languages","stargazers_url":"https://api.github.com/repos/Prismatic/schema/stargazers","contributors_url":"https://api.github.com/repos/Prismatic/schema/contributors","subscribers_url":"https://api.github.com/repos/Prismatic/schema/subscribers","subscription_url":"https://api.github.com/repos/Prismatic/schema/subscription","commits_url":"https://api.github.com/repos/Prismatic/schema/commits{/sha}","git_commits_url":"https://api.github.com/repos/Prismatic/schema/git/commits{/sha}","comments_url":"https://api.github.com/repos/Prismatic/schema/comments{/number}","issue_comment_url":"https://api.github.com/repos/Prismatic/schema/issues/comments/{number}","contents_url":"https://api.github.com/repos/Prismatic/schema/contents/{+path}","compare_url":"https://api.github.com/repos/Prismatic/schema/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Prismatic/schema/merges","archive_url":"https://api.github.com/repos/Prismatic/schema/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Prismatic/schema/downloads","issues_url":"https://api.github.com/repos/Prismatic/schema/issues{/number}","pulls_url":"https://api.github.com/repos/Prismatic/schema/pulls{/number}","milestones_url":"https://api.github.com/repos/Prismatic/schema/milestones{/number}","notifications_url":"https://api.github.com/repos/Prismatic/schema/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Prismatic/schema/labels{/name}","releases_url":"https://api.github.com/repos/Prismatic/schema/releases{/id}","created_at":"2013-07-22T23:26:46Z","updated_at":"2014-09-15T16:45:06Z","pushed_at":"2014-09-16T06:02:21Z","git_url":"git://github.com/Prismatic/schema.git","ssh_url":"git@github.com:Prismatic/schema.git","clone_url":"https://github.com/Prismatic/schema.git","svn_url":"https://github.com/Prismatic/schema","homepage":"","size":4056,"stargazers_count":702,"watchers_count":702,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":62,"mirror_url":null,"open_issues_count":15,"forks":62,"open_issues":15,"watchers":702,"default_branch":"master"}},"base":{"label":"Prismatic:master","ref":"master","sha":"79b3a29167466b140245d8e62d31e1f251669485","user":{"login":"Prismatic","id":1073038,"avatar_url":"https://avatars.githubusercontent.com/u/1073038?v=2","gravatar_id":"46e1fc9156d7e5bfdacdfa68acda4b9a","url":"https://api.github.com/users/Prismatic","html_url":"https://github.com/Prismatic","followers_url":"https://api.github.com/users/Prismatic/followers","following_url":"https://api.github.com/users/Prismatic/following{/other_user}","gists_url":"https://api.github.com/users/Prismatic/gists{/gist_id}","starred_url":"https://api.github.com/users/Prismatic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Prismatic/subscriptions","organizations_url":"https://api.github.com/users/Prismatic/orgs","repos_url":"https://api.github.com/users/Prismatic/repos","events_url":"https://api.github.com/users/Prismatic/events{/privacy}","received_events_url":"https://api.github.com/users/Prismatic/received_events","type":"Organization","site_admin":false},"repo":{"id":11594840,"name":"schema","full_name":"Prismatic/schema","owner":{"login":"Prismatic","id":1073038,"avatar_url":"https://avatars.githubusercontent.com/u/1073038?v=2","gravatar_id":"46e1fc9156d7e5bfdacdfa68acda4b9a","url":"https://api.github.com/users/Prismatic","html_url":"https://github.com/Prismatic","followers_url":"https://api.github.com/users/Prismatic/followers","following_url":"https://api.github.com/users/Prismatic/following{/other_user}","gists_url":"https://api.github.com/users/Prismatic/gists{/gist_id}","starred_url":"https://api.github.com/users/Prismatic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Prismatic/subscriptions","organizations_url":"https://api.github.com/users/Prismatic/orgs","repos_url":"https://api.github.com/users/Prismatic/repos","events_url":"https://api.github.com/users/Prismatic/events{/privacy}","received_events_url":"https://api.github.com/users/Prismatic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Prismatic/schema","description":"Clojure(Script) library for declarative data description and validation","fork":false,"url":"https://api.github.com/repos/Prismatic/schema","forks_url":"https://api.github.com/repos/Prismatic/schema/forks","keys_url":"https://api.github.com/repos/Prismatic/schema/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Prismatic/schema/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Prismatic/schema/teams","hooks_url":"https://api.github.com/repos/Prismatic/schema/hooks","issue_events_url":"https://api.github.com/repos/Prismatic/schema/issues/events{/number}","events_url":"https://api.github.com/repos/Prismatic/schema/events","assignees_url":"https://api.github.com/repos/Prismatic/schema/assignees{/user}","branches_url":"https://api.github.com/repos/Prismatic/schema/branches{/branch}","tags_url":"https://api.github.com/repos/Prismatic/schema/tags","blobs_url":"https://api.github.com/repos/Prismatic/schema/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Prismatic/schema/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Prismatic/schema/git/refs{/sha}","trees_url":"https://api.github.com/repos/Prismatic/schema/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Prismatic/schema/statuses/{sha}","languages_url":"https://api.github.com/repos/Prismatic/schema/languages","stargazers_url":"https://api.github.com/repos/Prismatic/schema/stargazers","contributors_url":"https://api.github.com/repos/Prismatic/schema/contributors","subscribers_url":"https://api.github.com/repos/Prismatic/schema/subscribers","subscription_url":"https://api.github.com/repos/Prismatic/schema/subscription","commits_url":"https://api.github.com/repos/Prismatic/schema/commits{/sha}","git_commits_url":"https://api.github.com/repos/Prismatic/schema/git/commits{/sha}","comments_url":"https://api.github.com/repos/Prismatic/schema/comments{/number}","issue_comment_url":"https://api.github.com/repos/Prismatic/schema/issues/comments/{number}","contents_url":"https://api.github.com/repos/Prismatic/schema/contents/{+path}","compare_url":"https://api.github.com/repos/Prismatic/schema/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Prismatic/schema/merges","archive_url":"https://api.github.com/repos/Prismatic/schema/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Prismatic/schema/downloads","issues_url":"https://api.github.com/repos/Prismatic/schema/issues{/number}","pulls_url":"https://api.github.com/repos/Prismatic/schema/pulls{/number}","milestones_url":"https://api.github.com/repos/Prismatic/schema/milestones{/number}","notifications_url":"https://api.github.com/repos/Prismatic/schema/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Prismatic/schema/labels{/name}","releases_url":"https://api.github.com/repos/Prismatic/schema/releases{/id}","created_at":"2013-07-22T23:26:46Z","updated_at":"2014-09-15T16:45:06Z","pushed_at":"2014-09-16T06:02:21Z","git_url":"git://github.com/Prismatic/schema.git","ssh_url":"git@github.com:Prismatic/schema.git","clone_url":"https://github.com/Prismatic/schema.git","svn_url":"https://github.com/Prismatic/schema","homepage":"","size":4056,"stargazers_count":702,"watchers_count":702,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":62,"mirror_url":null,"open_issues_count":15,"forks":62,"open_issues":15,"watchers":702,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Prismatic/schema/pulls/146"},"html":{"href":"https://github.com/Prismatic/schema/pull/146"},"issue":{"href":"https://api.github.com/repos/Prismatic/schema/issues/146"},"comments":{"href":"https://api.github.com/repos/Prismatic/schema/issues/146/comments"},"review_comments":{"href":"https://api.github.com/repos/Prismatic/schema/pulls/146/comments"},"review_comment":{"href":"https://api.github.com/repos/Prismatic/schema/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Prismatic/schema/pulls/146/commits"},"statuses":{"href":"https://api.github.com/repos/Prismatic/schema/statuses/ebbde95c1b30facdebfe613a72e67603d77fd02a"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":8,"deletions":4,"changed_files":4}}