GitHub PullRequestEvent at 2014-12-27 02:13:29
Repository: gomega
Actor: onsi
Payload: {"action":"closed","number":78,"pull_request":{"url":"https://api.github.com/repos/onsi/gomega/pulls/78","id":26610139,"html_url":"https://github.com/onsi/gomega/pull/78","diff_url":"https://github.com/onsi/gomega/pull/78.diff","patch_url":"https://github.com/onsi/gomega/pull/78.patch","issue_url":"https://api.github.com/repos/onsi/gomega/issues/78","number":78,"state":"closed","locked":false,"title":"prefix writer: simplify, preserve trailing \\n","user":{"login":"vito","id":1880,"avatar_url":"https://avatars.githubusercontent.com/u/1880?v=3","gravatar_id":"","url":"https://api.github.com/users/vito","html_url":"https://github.com/vito","followers_url":"https://api.github.com/users/vito/followers","following_url":"https://api.github.com/users/vito/following{/other_user}","gists_url":"https://api.github.com/users/vito/gists{/gist_id}","starred_url":"https://api.github.com/users/vito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vito/subscriptions","organizations_url":"https://api.github.com/users/vito/orgs","repos_url":"https://api.github.com/users/vito/repos","events_url":"https://api.github.com/users/vito/events{/privacy}","received_events_url":"https://api.github.com/users/vito/received_events","type":"User","site_admin":false},"body":"not sure if i'm missing any of the subtleties of the previous code. noticed it was lopping off trailing linebreaks and munging things together awkwardly some times. updated the test to preserve trailing linebreak and ended up rewriting the algorithm.\r\n\r\nthis is what I was seeing before:\r\n\r\nhttp://cl.ly/image/0V2M0y233V3h","created_at":"2014-12-27T02:07:24Z","updated_at":"2014-12-27T02:13:28Z","closed_at":"2014-12-27T02:13:28Z","merged_at":"2014-12-27T02:13:28Z","merge_commit_sha":"9ff33adf9e0608cf527f57b32c41af278647dd96","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/onsi/gomega/pulls/78/commits","review_comments_url":"https://api.github.com/repos/onsi/gomega/pulls/78/comments","review_comment_url":"https://api.github.com/repos/onsi/gomega/pulls/comments/{number}","comments_url":"https://api.github.com/repos/onsi/gomega/issues/78/comments","statuses_url":"https://api.github.com/repos/onsi/gomega/statuses/425de3e8a2c4b8d31fe6795544744225aa076e4b","head":{"label":"vito:simpler-prefix-writer","ref":"simpler-prefix-writer","sha":"425de3e8a2c4b8d31fe6795544744225aa076e4b","user":{"login":"vito","id":1880,"avatar_url":"https://avatars.githubusercontent.com/u/1880?v=3","gravatar_id":"","url":"https://api.github.com/users/vito","html_url":"https://github.com/vito","followers_url":"https://api.github.com/users/vito/followers","following_url":"https://api.github.com/users/vito/following{/other_user}","gists_url":"https://api.github.com/users/vito/gists{/gist_id}","starred_url":"https://api.github.com/users/vito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vito/subscriptions","organizations_url":"https://api.github.com/users/vito/orgs","repos_url":"https://api.github.com/users/vito/repos","events_url":"https://api.github.com/users/vito/events{/privacy}","received_events_url":"https://api.github.com/users/vito/received_events","type":"User","site_admin":false},"repo":{"id":13366327,"name":"gomega","full_name":"vito/gomega","owner":{"login":"vito","id":1880,"avatar_url":"https://avatars.githubusercontent.com/u/1880?v=3","gravatar_id":"","url":"https://api.github.com/users/vito","html_url":"https://github.com/vito","followers_url":"https://api.github.com/users/vito/followers","following_url":"https://api.github.com/users/vito/following{/other_user}","gists_url":"https://api.github.com/users/vito/gists{/gist_id}","starred_url":"https://api.github.com/users/vito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vito/subscriptions","organizations_url":"https://api.github.com/users/vito/orgs","repos_url":"https://api.github.com/users/vito/repos","events_url":"https://api.github.com/users/vito/events{/privacy}","received_events_url":"https://api.github.com/users/vito/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vito/gomega","description":"Matching library for Ginkgo","fork":true,"url":"https://api.github.com/repos/vito/gomega","forks_url":"https://api.github.com/repos/vito/gomega/forks","keys_url":"https://api.github.com/repos/vito/gomega/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vito/gomega/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vito/gomega/teams","hooks_url":"https://api.github.com/repos/vito/gomega/hooks","issue_events_url":"https://api.github.com/repos/vito/gomega/issues/events{/number}","events_url":"https://api.github.com/repos/vito/gomega/events","assignees_url":"https://api.github.com/repos/vito/gomega/assignees{/user}","branches_url":"https://api.github.com/repos/vito/gomega/branches{/branch}","tags_url":"https://api.github.com/repos/vito/gomega/tags","blobs_url":"https://api.github.com/repos/vito/gomega/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vito/gomega/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vito/gomega/git/refs{/sha}","trees_url":"https://api.github.com/repos/vito/gomega/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vito/gomega/statuses/{sha}","languages_url":"https://api.github.com/repos/vito/gomega/languages","stargazers_url":"https://api.github.com/repos/vito/gomega/stargazers","contributors_url":"https://api.github.com/repos/vito/gomega/contributors","subscribers_url":"https://api.github.com/repos/vito/gomega/subscribers","subscription_url":"https://api.github.com/repos/vito/gomega/subscription","commits_url":"https://api.github.com/repos/vito/gomega/commits{/sha}","git_commits_url":"https://api.github.com/repos/vito/gomega/git/commits{/sha}","comments_url":"https://api.github.com/repos/vito/gomega/comments{/number}","issue_comment_url":"https://api.github.com/repos/vito/gomega/issues/comments/{number}","contents_url":"https://api.github.com/repos/vito/gomega/contents/{+path}","compare_url":"https://api.github.com/repos/vito/gomega/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vito/gomega/merges","archive_url":"https://api.github.com/repos/vito/gomega/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vito/gomega/downloads","issues_url":"https://api.github.com/repos/vito/gomega/issues{/number}","pulls_url":"https://api.github.com/repos/vito/gomega/pulls{/number}","milestones_url":"https://api.github.com/repos/vito/gomega/milestones{/number}","notifications_url":"https://api.github.com/repos/vito/gomega/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vito/gomega/labels{/name}","releases_url":"https://api.github.com/repos/vito/gomega/releases{/id}","created_at":"2013-10-06T17:52:06Z","updated_at":"2013-11-04T22:00:43Z","pushed_at":"2014-12-27T02:05:59Z","git_url":"git://github.com/vito/gomega.git","ssh_url":"git@github.com:vito/gomega.git","clone_url":"https://github.com/vito/gomega.git","svn_url":"https://github.com/vito/gomega","homepage":"http://onsi.github.io/gomega/","size":462,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"onsi:master","ref":"master","sha":"dc751ce5f266d83c26fae5c0a9093973b29cb61d","user":{"login":"onsi","id":558230,"avatar_url":"https://avatars.githubusercontent.com/u/558230?v=3","gravatar_id":"","url":"https://api.github.com/users/onsi","html_url":"https://github.com/onsi","followers_url":"https://api.github.com/users/onsi/followers","following_url":"https://api.github.com/users/onsi/following{/other_user}","gists_url":"https://api.github.com/users/onsi/gists{/gist_id}","starred_url":"https://api.github.com/users/onsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onsi/subscriptions","organizations_url":"https://api.github.com/users/onsi/orgs","repos_url":"https://api.github.com/users/onsi/repos","events_url":"https://api.github.com/users/onsi/events{/privacy}","received_events_url":"https://api.github.com/users/onsi/received_events","type":"User","site_admin":false},"repo":{"id":12332483,"name":"gomega","full_name":"onsi/gomega","owner":{"login":"onsi","id":558230,"avatar_url":"https://avatars.githubusercontent.com/u/558230?v=3","gravatar_id":"","url":"https://api.github.com/users/onsi","html_url":"https://github.com/onsi","followers_url":"https://api.github.com/users/onsi/followers","following_url":"https://api.github.com/users/onsi/following{/other_user}","gists_url":"https://api.github.com/users/onsi/gists{/gist_id}","starred_url":"https://api.github.com/users/onsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onsi/subscriptions","organizations_url":"https://api.github.com/users/onsi/orgs","repos_url":"https://api.github.com/users/onsi/repos","events_url":"https://api.github.com/users/onsi/events{/privacy}","received_events_url":"https://api.github.com/users/onsi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/onsi/gomega","description":"Ginkgo's Preferred Matcher Library","fork":false,"url":"https://api.github.com/repos/onsi/gomega","forks_url":"https://api.github.com/repos/onsi/gomega/forks","keys_url":"https://api.github.com/repos/onsi/gomega/keys{/key_id}","collaborators_url":"https://api.github.com/repos/onsi/gomega/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/onsi/gomega/teams","hooks_url":"https://api.github.com/repos/onsi/gomega/hooks","issue_events_url":"https://api.github.com/repos/onsi/gomega/issues/events{/number}","events_url":"https://api.github.com/repos/onsi/gomega/events","assignees_url":"https://api.github.com/repos/onsi/gomega/assignees{/user}","branches_url":"https://api.github.com/repos/onsi/gomega/branches{/branch}","tags_url":"https://api.github.com/repos/onsi/gomega/tags","blobs_url":"https://api.github.com/repos/onsi/gomega/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/onsi/gomega/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/onsi/gomega/git/refs{/sha}","trees_url":"https://api.github.com/repos/onsi/gomega/git/trees{/sha}","statuses_url":"https://api.github.com/repos/onsi/gomega/statuses/{sha}","languages_url":"https://api.github.com/repos/onsi/gomega/languages","stargazers_url":"https://api.github.com/repos/onsi/gomega/stargazers","contributors_url":"https://api.github.com/repos/onsi/gomega/contributors","subscribers_url":"https://api.github.com/repos/onsi/gomega/subscribers","subscription_url":"https://api.github.com/repos/onsi/gomega/subscription","commits_url":"https://api.github.com/repos/onsi/gomega/commits{/sha}","git_commits_url":"https://api.github.com/repos/onsi/gomega/git/commits{/sha}","comments_url":"https://api.github.com/repos/onsi/gomega/comments{/number}","issue_comment_url":"https://api.github.com/repos/onsi/gomega/issues/comments/{number}","contents_url":"https://api.github.com/repos/onsi/gomega/contents/{+path}","compare_url":"https://api.github.com/repos/onsi/gomega/compare/{base}...{head}","merges_url":"https://api.github.com/repos/onsi/gomega/merges","archive_url":"https://api.github.com/repos/onsi/gomega/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/onsi/gomega/downloads","issues_url":"https://api.github.com/repos/onsi/gomega/issues{/number}","pulls_url":"https://api.github.com/repos/onsi/gomega/pulls{/number}","milestones_url":"https://api.github.com/repos/onsi/gomega/milestones{/number}","notifications_url":"https://api.github.com/repos/onsi/gomega/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/onsi/gomega/labels{/name}","releases_url":"https://api.github.com/repos/onsi/gomega/releases{/id}","created_at":"2013-08-23T20:54:42Z","updated_at":"2014-12-26T17:39:09Z","pushed_at":"2014-12-27T02:13:28Z","git_url":"git://github.com/onsi/gomega.git","ssh_url":"git@github.com:onsi/gomega.git","clone_url":"https://github.com/onsi/gomega.git","svn_url":"https://github.com/onsi/gomega","homepage":"http://onsi.github.io/gomega/","size":1515,"stargazers_count":185,"watchers_count":185,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":23,"mirror_url":null,"open_issues_count":4,"forks":23,"open_issues":4,"watchers":185,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/onsi/gomega/pulls/78"},"html":{"href":"https://github.com/onsi/gomega/pull/78"},"issue":{"href":"https://api.github.com/repos/onsi/gomega/issues/78"},"comments":{"href":"https://api.github.com/repos/onsi/gomega/issues/78/comments"},"review_comments":{"href":"https://api.github.com/repos/onsi/gomega/pulls/78/comments"},"review_comment":{"href":"https://api.github.com/repos/onsi/gomega/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/onsi/gomega/pulls/78/commits"},"statuses":{"href":"https://api.github.com/repos/onsi/gomega/statuses/425de3e8a2c4b8d31fe6795544744225aa076e4b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"onsi","id":558230,"avatar_url":"https://avatars.githubusercontent.com/u/558230?v=3","gravatar_id":"","url":"https://api.github.com/users/onsi","html_url":"https://github.com/onsi","followers_url":"https://api.github.com/users/onsi/followers","following_url":"https://api.github.com/users/onsi/following{/other_user}","gists_url":"https://api.github.com/users/onsi/gists{/gist_id}","starred_url":"https://api.github.com/users/onsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onsi/subscriptions","organizations_url":"https://api.github.com/users/onsi/orgs","repos_url":"https://api.github.com/users/onsi/repos","events_url":"https://api.github.com/users/onsi/events{/privacy}","received_events_url":"https://api.github.com/users/onsi/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":20,"deletions":45,"changed_files":2}}