GitHub PullRequestReviewCommentEvent at 2014-07-08 15:32:52
Repository: rsvp-party
Actor: stefanpenner
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/stefanpenner/rsvp-party/pulls/comments/14659724","id":14659724,"diff_hunk":"@@ -0,0 +1,66 @@\n+define(\n+  [\"rsvp\",\"exports\"],\n+  function(__dependency1__, __exports__) {\n+    \"use strict\";\n+    var _RSVP = __dependency1__[\"default\"] || __dependency1__;\n+\n+    var _Promise = _RSVP.Promise;\n+\n+    function Promise(resolver, label) {\n+      this._superConstructor(resolver, label);\n+    }\n+\n+    Promise.prototype = Object.create(_Promise.prototype);\n+    Promise.prototype.constructor = Promise;\n+    Promise.prototype._superConstructor = _Promise;\n+    Promise.__proto__ = _Promise;","path":"dist/amd/rsvp-party/promise.js","position":16,"original_position":16,"commit_id":"f0ecc89604b296657d0e9b0301cb248896922d7a","original_commit_id":"f0ecc89604b296657d0e9b0301cb248896922d7a","user":{"login":"stefanpenner","id":1377,"avatar_url":"https://avatars.githubusercontent.com/u/1377?","gravatar_id":"8ccebbc3d28f903d5c214efd3447ac71","url":"https://api.github.com/users/stefanpenner","html_url":"https://github.com/stefanpenner","followers_url":"https://api.github.com/users/stefanpenner/followers","following_url":"https://api.github.com/users/stefanpenner/following{/other_user}","gists_url":"https://api.github.com/users/stefanpenner/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanpenner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanpenner/subscriptions","organizations_url":"https://api.github.com/users/stefanpenner/orgs","repos_url":"https://api.github.com/users/stefanpenner/repos","events_url":"https://api.github.com/users/stefanpenner/events{/privacy}","received_events_url":"https://api.github.com/users/stefanpenner/received_events","type":"User","site_admin":false},"body":"`Promise.__proto__` isn't something that is cross platform (or something we can actually rely on going forward)\r\n\r\nthe future adds `setPrototypeOf` but __proto__ is a nice hack for node world today.\r\n\r\nWe will likely need to copy each method from `_Promise` over to `Promise`","created_at":"2014-07-08T15:32:52Z","updated_at":"2014-07-08T15:32:52Z","html_url":"https://github.com/stefanpenner/rsvp-party/pull/3#discussion_r14659724","pull_request_url":"https://api.github.com/repos/stefanpenner/rsvp-party/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/stefanpenner/rsvp-party/pulls/comments/14659724"},"html":{"href":"https://github.com/stefanpenner/rsvp-party/pull/3#discussion_r14659724"},"pull_request":{"href":"https://api.github.com/repos/stefanpenner/rsvp-party/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/stefanpenner/rsvp-party/pulls/3","id":17831183,"html_url":"https://github.com/stefanpenner/rsvp-party/pull/3","diff_url":"https://github.com/stefanpenner/rsvp-party/pull/3.diff","patch_url":"https://github.com/stefanpenner/rsvp-party/pull/3.patch","issue_url":"https://api.github.com/repos/stefanpenner/rsvp-party/issues/3","number":3,"state":"open","title":"WIP: testing setup","user":{"login":"jakecraige","id":3799709,"avatar_url":"https://avatars.githubusercontent.com/u/3799709?","gravatar_id":"3936556ea5500c2edf892b80ad8e834e","url":"https://api.github.com/users/jakecraige","html_url":"https://github.com/jakecraige","followers_url":"https://api.github.com/users/jakecraige/followers","following_url":"https://api.github.com/users/jakecraige/following{/other_user}","gists_url":"https://api.github.com/users/jakecraige/gists{/gist_id}","starred_url":"https://api.github.com/users/jakecraige/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakecraige/subscriptions","organizations_url":"https://api.github.com/users/jakecraige/orgs","repos_url":"https://api.github.com/users/jakecraige/repos","events_url":"https://api.github.com/users/jakecraige/events{/privacy}","received_events_url":"https://api.github.com/users/jakecraige/received_events","type":"User","site_admin":false},"body":"WIP","created_at":"2014-07-01T13:51:03Z","updated_at":"2014-07-08T15:32:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e2a92e6c50f5c33e5705f374fedc6ce874fcb77b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/stefanpenner/rsvp-party/pulls/3/commits","review_comments_url":"https://api.github.com/repos/stefanpenner/rsvp-party/pulls/3/comments","review_comment_url":"https://api.github.com/repos/stefanpenner/rsvp-party/pulls/comments/{number}","comments_url":"https://api.github.com/repos/stefanpenner/rsvp-party/issues/3/comments","statuses_url":"https://api.github.com/repos/stefanpenner/rsvp-party/statuses/f0ecc89604b296657d0e9b0301cb248896922d7a","head":{"label":"jakecraige:test_setup","ref":"test_setup","sha":"f0ecc89604b296657d0e9b0301cb248896922d7a","user":{"login":"jakecraige","id":3799709,"avatar_url":"https://avatars.githubusercontent.com/u/3799709?","gravatar_id":"3936556ea5500c2edf892b80ad8e834e","url":"https://api.github.com/users/jakecraige","html_url":"https://github.com/jakecraige","followers_url":"https://api.github.com/users/jakecraige/followers","following_url":"https://api.github.com/users/jakecraige/following{/other_user}","gists_url":"https://api.github.com/users/jakecraige/gists{/gist_id}","starred_url":"https://api.github.com/users/jakecraige/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakecraige/subscriptions","organizations_url":"https://api.github.com/users/jakecraige/orgs","repos_url":"https://api.github.com/users/jakecraige/repos","events_url":"https://api.github.com/users/jakecraige/events{/privacy}","received_events_url":"https://api.github.com/users/jakecraige/received_events","type":"User","site_admin":false},"repo":{"id":21387970,"name":"rsvp-party","full_name":"jakecraige/rsvp-party","owner":{"login":"jakecraige","id":3799709,"avatar_url":"https://avatars.githubusercontent.com/u/3799709?","gravatar_id":"3936556ea5500c2edf892b80ad8e834e","url":"https://api.github.com/users/jakecraige","html_url":"https://github.com/jakecraige","followers_url":"https://api.github.com/users/jakecraige/followers","following_url":"https://api.github.com/users/jakecraige/following{/other_user}","gists_url":"https://api.github.com/users/jakecraige/gists{/gist_id}","starred_url":"https://api.github.com/users/jakecraige/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakecraige/subscriptions","organizations_url":"https://api.github.com/users/jakecraige/orgs","repos_url":"https://api.github.com/users/jakecraige/repos","events_url":"https://api.github.com/users/jakecraige/events{/privacy}","received_events_url":"https://api.github.com/users/jakecraige/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jakecraige/rsvp-party","description":"","fork":true,"url":"https://api.github.com/repos/jakecraige/rsvp-party","forks_url":"https://api.github.com/repos/jakecraige/rsvp-party/forks","keys_url":"https://api.github.com/repos/jakecraige/rsvp-party/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jakecraige/rsvp-party/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jakecraige/rsvp-party/teams","hooks_url":"https://api.github.com/repos/jakecraige/rsvp-party/hooks","issue_events_url":"https://api.github.com/repos/jakecraige/rsvp-party/issues/events{/number}","events_url":"https://api.github.com/repos/jakecraige/rsvp-party/events","assignees_url":"https://api.github.com/repos/jakecraige/rsvp-party/assignees{/user}","branches_url":"https://api.github.com/repos/jakecraige/rsvp-party/branches{/branch}","tags_url":"https://api.github.com/repos/jakecraige/rsvp-party/tags","blobs_url":"https://api.github.com/repos/jakecraige/rsvp-party/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jakecraige/rsvp-party/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jakecraige/rsvp-party/git/refs{/sha}","trees_url":"https://api.github.com/repos/jakecraige/rsvp-party/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jakecraige/rsvp-party/statuses/{sha}","languages_url":"https://api.github.com/repos/jakecraige/rsvp-party/languages","stargazers_url":"https://api.github.com/repos/jakecraige/rsvp-party/stargazers","contributors_url":"https://api.github.com/repos/jakecraige/rsvp-party/contributors","subscribers_url":"https://api.github.com/repos/jakecraige/rsvp-party/subscribers","subscription_url":"https://api.github.com/repos/jakecraige/rsvp-party/subscription","commits_url":"https://api.github.com/repos/jakecraige/rsvp-party/commits{/sha}","git_commits_url":"https://api.github.com/repos/jakecraige/rsvp-party/git/commits{/sha}","comments_url":"https://api.github.com/repos/jakecraige/rsvp-party/comments{/number}","issue_comment_url":"https://api.github.com/repos/jakecraige/rsvp-party/issues/comments/{number}","contents_url":"https://api.github.com/repos/jakecraige/rsvp-party/contents/{+path}","compare_url":"https://api.github.com/repos/jakecraige/rsvp-party/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jakecraige/rsvp-party/merges","archive_url":"https://api.github.com/repos/jakecraige/rsvp-party/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jakecraige/rsvp-party/downloads","issues_url":"https://api.github.com/repos/jakecraige/rsvp-party/issues{/number}","pulls_url":"https://api.github.com/repos/jakecraige/rsvp-party/pulls{/number}","milestones_url":"https://api.github.com/repos/jakecraige/rsvp-party/milestones{/number}","notifications_url":"https://api.github.com/repos/jakecraige/rsvp-party/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jakecraige/rsvp-party/labels{/name}","releases_url":"https://api.github.com/repos/jakecraige/rsvp-party/releases{/id}","created_at":"2014-07-01T13:07:33Z","updated_at":"2014-06-28T15:28:36Z","pushed_at":"2014-07-06T16:23:46Z","git_url":"git://github.com/jakecraige/rsvp-party.git","ssh_url":"git@github.com:jakecraige/rsvp-party.git","clone_url":"https://github.com/jakecraige/rsvp-party.git","svn_url":"https://github.com/jakecraige/rsvp-party","homepage":null,"size":167,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"stefanpenner:master","ref":"master","sha":"a58057da64b8d13dac1e90abab34ba704d89df30","user":{"login":"stefanpenner","id":1377,"avatar_url":"https://avatars.githubusercontent.com/u/1377?","gravatar_id":"8ccebbc3d28f903d5c214efd3447ac71","url":"https://api.github.com/users/stefanpenner","html_url":"https://github.com/stefanpenner","followers_url":"https://api.github.com/users/stefanpenner/followers","following_url":"https://api.github.com/users/stefanpenner/following{/other_user}","gists_url":"https://api.github.com/users/stefanpenner/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanpenner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanpenner/subscriptions","organizations_url":"https://api.github.com/users/stefanpenner/orgs","repos_url":"https://api.github.com/users/stefanpenner/repos","events_url":"https://api.github.com/users/stefanpenner/events{/privacy}","received_events_url":"https://api.github.com/users/stefanpenner/received_events","type":"User","site_admin":false},"repo":{"id":16904027,"name":"rsvp-party","full_name":"stefanpenner/rsvp-party","owner":{"login":"stefanpenner","id":1377,"avatar_url":"https://avatars.githubusercontent.com/u/1377?","gravatar_id":"8ccebbc3d28f903d5c214efd3447ac71","url":"https://api.github.com/users/stefanpenner","html_url":"https://github.com/stefanpenner","followers_url":"https://api.github.com/users/stefanpenner/followers","following_url":"https://api.github.com/users/stefanpenner/following{/other_user}","gists_url":"https://api.github.com/users/stefanpenner/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanpenner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanpenner/subscriptions","organizations_url":"https://api.github.com/users/stefanpenner/orgs","repos_url":"https://api.github.com/users/stefanpenner/repos","events_url":"https://api.github.com/users/stefanpenner/events{/privacy}","received_events_url":"https://api.github.com/users/stefanpenner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stefanpenner/rsvp-party","description":"","fork":false,"url":"https://api.github.com/repos/stefanpenner/rsvp-party","forks_url":"https://api.github.com/repos/stefanpenner/rsvp-party/forks","keys_url":"https://api.github.com/repos/stefanpenner/rsvp-party/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stefanpenner/rsvp-party/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stefanpenner/rsvp-party/teams","hooks_url":"https://api.github.com/repos/stefanpenner/rsvp-party/hooks","issue_events_url":"https://api.github.com/repos/stefanpenner/rsvp-party/issues/events{/number}","events_url":"https://api.github.com/repos/stefanpenner/rsvp-party/events","assignees_url":"https://api.github.com/repos/stefanpenner/rsvp-party/assignees{/user}","branches_url":"https://api.github.com/repos/stefanpenner/rsvp-party/branches{/branch}","tags_url":"https://api.github.com/repos/stefanpenner/rsvp-party/tags","blobs_url":"https://api.github.com/repos/stefanpenner/rsvp-party/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stefanpenner/rsvp-party/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stefanpenner/rsvp-party/git/refs{/sha}","trees_url":"https://api.github.com/repos/stefanpenner/rsvp-party/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stefanpenner/rsvp-party/statuses/{sha}","languages_url":"https://api.github.com/repos/stefanpenner/rsvp-party/languages","stargazers_url":"https://api.github.com/repos/stefanpenner/rsvp-party/stargazers","contributors_url":"https://api.github.com/repos/stefanpenner/rsvp-party/contributors","subscribers_url":"https://api.github.com/repos/stefanpenner/rsvp-party/subscribers","subscription_url":"https://api.github.com/repos/stefanpenner/rsvp-party/subscription","commits_url":"https://api.github.com/repos/stefanpenner/rsvp-party/commits{/sha}","git_commits_url":"https://api.github.com/repos/stefanpenner/rsvp-party/git/commits{/sha}","comments_url":"https://api.github.com/repos/stefanpenner/rsvp-party/comments{/number}","issue_comment_url":"https://api.github.com/repos/stefanpenner/rsvp-party/issues/comments/{number}","contents_url":"https://api.github.com/repos/stefanpenner/rsvp-party/contents/{+path}","compare_url":"https://api.github.com/repos/stefanpenner/rsvp-party/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stefanpenner/rsvp-party/merges","archive_url":"https://api.github.com/repos/stefanpenner/rsvp-party/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stefanpenner/rsvp-party/downloads","issues_url":"https://api.github.com/repos/stefanpenner/rsvp-party/issues{/number}","pulls_url":"https://api.github.com/repos/stefanpenner/rsvp-party/pulls{/number}","milestones_url":"https://api.github.com/repos/stefanpenner/rsvp-party/milestones{/number}","notifications_url":"https://api.github.com/repos/stefanpenner/rsvp-party/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stefanpenner/rsvp-party/labels{/name}","releases_url":"https://api.github.com/repos/stefanpenner/rsvp-party/releases{/id}","created_at":"2014-02-17T06:32:29Z","updated_at":"2014-07-01T13:51:20Z","pushed_at":"2014-06-28T15:28:33Z","git_url":"git://github.com/stefanpenner/rsvp-party.git","ssh_url":"git@github.com:stefanpenner/rsvp-party.git","clone_url":"https://github.com/stefanpenner/rsvp-party.git","svn_url":"https://github.com/stefanpenner/rsvp-party","homepage":null,"size":219,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stefanpenner/rsvp-party/pulls/3"},"html":{"href":"https://github.com/stefanpenner/rsvp-party/pull/3"},"issue":{"href":"https://api.github.com/repos/stefanpenner/rsvp-party/issues/3"},"comments":{"href":"https://api.github.com/repos/stefanpenner/rsvp-party/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/stefanpenner/rsvp-party/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/stefanpenner/rsvp-party/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/stefanpenner/rsvp-party/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/stefanpenner/rsvp-party/statuses/f0ecc89604b296657d0e9b0301cb248896922d7a"}}}}