GitHub PullRequestReviewCommentEvent at 2014-06-18 10:44:29
Repository: pyao
Actor: ntielen
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/faitdivers/pyao/pulls/comments/13908912","id":13908912,"diff_hunk":"@@ -56,42 +56,45 @@\n \n \\section*{Introduction}\n \n-In the previous part of this report, we already mentioned the first steps in the use of adaptive optics. First we described waverfront generating and wavefront sensing. In this chapter of the report, we take a closer look at the reconstruction of the wavefront. \n+In the previous part of this report, we already mentioned the first steps in the use of adaptive optics. First we described waverfront generating and wavefront sensing. In this chapter of the report, we direct our focus to the reconstruction of the wavefront. \n \n \\section{Zonal Reconstruction}\n-In order to describe the gradient of the wavefront, we first take a look at a zonal reconstruction method. With zonal reconstruction, we split up the wavefront in zones. These zones can represent a regular grid of square or rectangular elements or some other local region such as a hexagonal or other shape. For Shack-Hartmann wavefront sensors, the type of sensor that is used, these zones are generally chosen to match the lenslets.\n+In order to describe the gradient of the wavefront, we first take a look at a zonal reconstruction method. With zonal reconstruction, we split up the wavefront in zones. These zones can represent a regular grid of square or rectangular elements or some other local region such as a hexagonal or other shape. For Shack-Hartmann wavefront sensors, the type of sensor that is used, these zones are generally chosen to match the lenslet array.","path":"doc/WFR/wfr_doc.tex","position":null,"original_position":29,"commit_id":"698cef7b2bb15ff6f37d7b814de5834934f43b55","original_commit_id":"32296de5ddaa927bc269b62070268e0d3d49f433","user":{"login":"ntielen","id":7489903,"avatar_url":"https://avatars.githubusercontent.com/u/7489903?","gravatar_id":"34a73b3b5031dd9ef5765d7a4313b26c","url":"https://api.github.com/users/ntielen","html_url":"https://github.com/ntielen","followers_url":"https://api.github.com/users/ntielen/followers","following_url":"https://api.github.com/users/ntielen/following{/other_user}","gists_url":"https://api.github.com/users/ntielen/gists{/gist_id}","starred_url":"https://api.github.com/users/ntielen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ntielen/subscriptions","organizations_url":"https://api.github.com/users/ntielen/orgs","repos_url":"https://api.github.com/users/ntielen/repos","events_url":"https://api.github.com/users/ntielen/events{/privacy}","received_events_url":"https://api.github.com/users/ntielen/received_events","type":"User","site_admin":false},"body":"fixed\r\n","created_at":"2014-06-18T10:44:29Z","updated_at":"2014-06-18T10:44:29Z","html_url":"https://github.com/faitdivers/pyao/pull/79#discussion_r13908912","pull_request_url":"https://api.github.com/repos/faitdivers/pyao/pulls/79","_links":{"self":{"href":"https://api.github.com/repos/faitdivers/pyao/pulls/comments/13908912"},"html":{"href":"https://github.com/faitdivers/pyao/pull/79#discussion_r13908912"},"pull_request":{"href":"https://api.github.com/repos/faitdivers/pyao/pulls/79"}}},"pull_request":{"url":"https://api.github.com/repos/faitdivers/pyao/pulls/79","id":17086430,"html_url":"https://github.com/faitdivers/pyao/pull/79","diff_url":"https://github.com/faitdivers/pyao/pull/79.diff","patch_url":"https://github.com/faitdivers/pyao/pull/79.patch","issue_url":"https://api.github.com/repos/faitdivers/pyao/issues/79","number":79,"state":"open","title":"Iss47","user":{"login":"ntielen","id":7489903,"avatar_url":"https://avatars.githubusercontent.com/u/7489903?","gravatar_id":"34a73b3b5031dd9ef5765d7a4313b26c","url":"https://api.github.com/users/ntielen","html_url":"https://github.com/ntielen","followers_url":"https://api.github.com/users/ntielen/followers","following_url":"https://api.github.com/users/ntielen/following{/other_user}","gists_url":"https://api.github.com/users/ntielen/gists{/gist_id}","starred_url":"https://api.github.com/users/ntielen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ntielen/subscriptions","organizations_url":"https://api.github.com/users/ntielen/orgs","repos_url":"https://api.github.com/users/ntielen/repos","events_url":"https://api.github.com/users/ntielen/events{/privacy}","received_events_url":"https://api.github.com/users/ntielen/received_events","type":"User","site_admin":false},"body":"Add documentation\r\n","created_at":"2014-06-12T23:40:28Z","updated_at":"2014-06-18T10:44:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"20e2714c4b86255cefcf6c9e05a96b3be2edf723","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/faitdivers/pyao/pulls/79/commits","review_comments_url":"https://api.github.com/repos/faitdivers/pyao/pulls/79/comments","review_comment_url":"https://api.github.com/repos/faitdivers/pyao/pulls/comments/{number}","comments_url":"https://api.github.com/repos/faitdivers/pyao/issues/79/comments","statuses_url":"https://api.github.com/repos/faitdivers/pyao/statuses/698cef7b2bb15ff6f37d7b814de5834934f43b55","head":{"label":"faitdivers:iss47","ref":"iss47","sha":"698cef7b2bb15ff6f37d7b814de5834934f43b55","user":{"login":"faitdivers","id":1611375,"avatar_url":"https://avatars.githubusercontent.com/u/1611375?","gravatar_id":"1da230deb180f9418d12a70a75944600","url":"https://api.github.com/users/faitdivers","html_url":"https://github.com/faitdivers","followers_url":"https://api.github.com/users/faitdivers/followers","following_url":"https://api.github.com/users/faitdivers/following{/other_user}","gists_url":"https://api.github.com/users/faitdivers/gists{/gist_id}","starred_url":"https://api.github.com/users/faitdivers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faitdivers/subscriptions","organizations_url":"https://api.github.com/users/faitdivers/orgs","repos_url":"https://api.github.com/users/faitdivers/repos","events_url":"https://api.github.com/users/faitdivers/events{/privacy}","received_events_url":"https://api.github.com/users/faitdivers/received_events","type":"User","site_admin":false},"repo":{"id":19397453,"name":"pyao","full_name":"faitdivers/pyao","owner":{"login":"faitdivers","id":1611375,"avatar_url":"https://avatars.githubusercontent.com/u/1611375?","gravatar_id":"1da230deb180f9418d12a70a75944600","url":"https://api.github.com/users/faitdivers","html_url":"https://github.com/faitdivers","followers_url":"https://api.github.com/users/faitdivers/followers","following_url":"https://api.github.com/users/faitdivers/following{/other_user}","gists_url":"https://api.github.com/users/faitdivers/gists{/gist_id}","starred_url":"https://api.github.com/users/faitdivers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faitdivers/subscriptions","organizations_url":"https://api.github.com/users/faitdivers/orgs","repos_url":"https://api.github.com/users/faitdivers/repos","events_url":"https://api.github.com/users/faitdivers/events{/privacy}","received_events_url":"https://api.github.com/users/faitdivers/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/faitdivers/pyao","description":"PyAO - Adaptive Optics simulation package","fork":false,"url":"https://api.github.com/repos/faitdivers/pyao","forks_url":"https://api.github.com/repos/faitdivers/pyao/forks","keys_url":"https://api.github.com/repos/faitdivers/pyao/keys{/key_id}","collaborators_url":"https://api.github.com/repos/faitdivers/pyao/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/faitdivers/pyao/teams","hooks_url":"https://api.github.com/repos/faitdivers/pyao/hooks","issue_events_url":"https://api.github.com/repos/faitdivers/pyao/issues/events{/number}","events_url":"https://api.github.com/repos/faitdivers/pyao/events","assignees_url":"https://api.github.com/repos/faitdivers/pyao/assignees{/user}","branches_url":"https://api.github.com/repos/faitdivers/pyao/branches{/branch}","tags_url":"https://api.github.com/repos/faitdivers/pyao/tags","blobs_url":"https://api.github.com/repos/faitdivers/pyao/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/faitdivers/pyao/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/faitdivers/pyao/git/refs{/sha}","trees_url":"https://api.github.com/repos/faitdivers/pyao/git/trees{/sha}","statuses_url":"https://api.github.com/repos/faitdivers/pyao/statuses/{sha}","languages_url":"https://api.github.com/repos/faitdivers/pyao/languages","stargazers_url":"https://api.github.com/repos/faitdivers/pyao/stargazers","contributors_url":"https://api.github.com/repos/faitdivers/pyao/contributors","subscribers_url":"https://api.github.com/repos/faitdivers/pyao/subscribers","subscription_url":"https://api.github.com/repos/faitdivers/pyao/subscription","commits_url":"https://api.github.com/repos/faitdivers/pyao/commits{/sha}","git_commits_url":"https://api.github.com/repos/faitdivers/pyao/git/commits{/sha}","comments_url":"https://api.github.com/repos/faitdivers/pyao/comments{/number}","issue_comment_url":"https://api.github.com/repos/faitdivers/pyao/issues/comments/{number}","contents_url":"https://api.github.com/repos/faitdivers/pyao/contents/{+path}","compare_url":"https://api.github.com/repos/faitdivers/pyao/compare/{base}...{head}","merges_url":"https://api.github.com/repos/faitdivers/pyao/merges","archive_url":"https://api.github.com/repos/faitdivers/pyao/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/faitdivers/pyao/downloads","issues_url":"https://api.github.com/repos/faitdivers/pyao/issues{/number}","pulls_url":"https://api.github.com/repos/faitdivers/pyao/pulls{/number}","milestones_url":"https://api.github.com/repos/faitdivers/pyao/milestones{/number}","notifications_url":"https://api.github.com/repos/faitdivers/pyao/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/faitdivers/pyao/labels{/name}","releases_url":"https://api.github.com/repos/faitdivers/pyao/releases{/id}","created_at":"2014-05-03T06:50:50Z","updated_at":"2014-06-18T10:44:07Z","pushed_at":"2014-06-18T10:44:08Z","git_url":"git://github.com/faitdivers/pyao.git","ssh_url":"git@github.com:faitdivers/pyao.git","clone_url":"https://github.com/faitdivers/pyao.git","svn_url":"https://github.com/faitdivers/pyao","homepage":"","size":5715,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":30,"forks":0,"open_issues":30,"watchers":5,"default_branch":"master"}},"base":{"label":"faitdivers:master","ref":"master","sha":"f50adbe8ccd21505d552e0a51f771de18e5bd60e","user":{"login":"faitdivers","id":1611375,"avatar_url":"https://avatars.githubusercontent.com/u/1611375?","gravatar_id":"1da230deb180f9418d12a70a75944600","url":"https://api.github.com/users/faitdivers","html_url":"https://github.com/faitdivers","followers_url":"https://api.github.com/users/faitdivers/followers","following_url":"https://api.github.com/users/faitdivers/following{/other_user}","gists_url":"https://api.github.com/users/faitdivers/gists{/gist_id}","starred_url":"https://api.github.com/users/faitdivers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faitdivers/subscriptions","organizations_url":"https://api.github.com/users/faitdivers/orgs","repos_url":"https://api.github.com/users/faitdivers/repos","events_url":"https://api.github.com/users/faitdivers/events{/privacy}","received_events_url":"https://api.github.com/users/faitdivers/received_events","type":"User","site_admin":false},"repo":{"id":19397453,"name":"pyao","full_name":"faitdivers/pyao","owner":{"login":"faitdivers","id":1611375,"avatar_url":"https://avatars.githubusercontent.com/u/1611375?","gravatar_id":"1da230deb180f9418d12a70a75944600","url":"https://api.github.com/users/faitdivers","html_url":"https://github.com/faitdivers","followers_url":"https://api.github.com/users/faitdivers/followers","following_url":"https://api.github.com/users/faitdivers/following{/other_user}","gists_url":"https://api.github.com/users/faitdivers/gists{/gist_id}","starred_url":"https://api.github.com/users/faitdivers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faitdivers/subscriptions","organizations_url":"https://api.github.com/users/faitdivers/orgs","repos_url":"https://api.github.com/users/faitdivers/repos","events_url":"https://api.github.com/users/faitdivers/events{/privacy}","received_events_url":"https://api.github.com/users/faitdivers/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/faitdivers/pyao","description":"PyAO - Adaptive Optics simulation package","fork":false,"url":"https://api.github.com/repos/faitdivers/pyao","forks_url":"https://api.github.com/repos/faitdivers/pyao/forks","keys_url":"https://api.github.com/repos/faitdivers/pyao/keys{/key_id}","collaborators_url":"https://api.github.com/repos/faitdivers/pyao/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/faitdivers/pyao/teams","hooks_url":"https://api.github.com/repos/faitdivers/pyao/hooks","issue_events_url":"https://api.github.com/repos/faitdivers/pyao/issues/events{/number}","events_url":"https://api.github.com/repos/faitdivers/pyao/events","assignees_url":"https://api.github.com/repos/faitdivers/pyao/assignees{/user}","branches_url":"https://api.github.com/repos/faitdivers/pyao/branches{/branch}","tags_url":"https://api.github.com/repos/faitdivers/pyao/tags","blobs_url":"https://api.github.com/repos/faitdivers/pyao/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/faitdivers/pyao/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/faitdivers/pyao/git/refs{/sha}","trees_url":"https://api.github.com/repos/faitdivers/pyao/git/trees{/sha}","statuses_url":"https://api.github.com/repos/faitdivers/pyao/statuses/{sha}","languages_url":"https://api.github.com/repos/faitdivers/pyao/languages","stargazers_url":"https://api.github.com/repos/faitdivers/pyao/stargazers","contributors_url":"https://api.github.com/repos/faitdivers/pyao/contributors","subscribers_url":"https://api.github.com/repos/faitdivers/pyao/subscribers","subscription_url":"https://api.github.com/repos/faitdivers/pyao/subscription","commits_url":"https://api.github.com/repos/faitdivers/pyao/commits{/sha}","git_commits_url":"https://api.github.com/repos/faitdivers/pyao/git/commits{/sha}","comments_url":"https://api.github.com/repos/faitdivers/pyao/comments{/number}","issue_comment_url":"https://api.github.com/repos/faitdivers/pyao/issues/comments/{number}","contents_url":"https://api.github.com/repos/faitdivers/pyao/contents/{+path}","compare_url":"https://api.github.com/repos/faitdivers/pyao/compare/{base}...{head}","merges_url":"https://api.github.com/repos/faitdivers/pyao/merges","archive_url":"https://api.github.com/repos/faitdivers/pyao/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/faitdivers/pyao/downloads","issues_url":"https://api.github.com/repos/faitdivers/pyao/issues{/number}","pulls_url":"https://api.github.com/repos/faitdivers/pyao/pulls{/number}","milestones_url":"https://api.github.com/repos/faitdivers/pyao/milestones{/number}","notifications_url":"https://api.github.com/repos/faitdivers/pyao/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/faitdivers/pyao/labels{/name}","releases_url":"https://api.github.com/repos/faitdivers/pyao/releases{/id}","created_at":"2014-05-03T06:50:50Z","updated_at":"2014-06-18T10:44:07Z","pushed_at":"2014-06-18T10:44:08Z","git_url":"git://github.com/faitdivers/pyao.git","ssh_url":"git@github.com:faitdivers/pyao.git","clone_url":"https://github.com/faitdivers/pyao.git","svn_url":"https://github.com/faitdivers/pyao","homepage":"","size":5715,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":30,"forks":0,"open_issues":30,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/faitdivers/pyao/pulls/79"},"html":{"href":"https://github.com/faitdivers/pyao/pull/79"},"issue":{"href":"https://api.github.com/repos/faitdivers/pyao/issues/79"},"comments":{"href":"https://api.github.com/repos/faitdivers/pyao/issues/79/comments"},"review_comments":{"href":"https://api.github.com/repos/faitdivers/pyao/pulls/79/comments"},"review_comment":{"href":"https://api.github.com/repos/faitdivers/pyao/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/faitdivers/pyao/pulls/79/commits"},"statuses":{"href":"https://api.github.com/repos/faitdivers/pyao/statuses/698cef7b2bb15ff6f37d7b814de5834934f43b55"}}}}