GitHub PushEvent at 2014-12-02 05:18:59
Repository: VCard-Tools
Actor: evought
Payload: {"shas":[["c7981662773bdd05f8b8c37864b74915c9f9ac64","7717ea05746df75b62d9ec034b73d3ce4bbadc2b@pobox.com","Added new testcase for __toString(), initializing from raw vCard text, and\ninitializing from .vcf files. Added several .vcf vcard files for testing\npurposes.\nFound and fixed two issues:\n1) Empty fields in structured components on import were being\nset to empty string instead of not being set, causing round-trip comparisons\nto fail.\n2) The load path on file import was being saved in an internal property of\nvCard and this also caused round-trip comparisons to fail. vCard->Path was\nprivate, could not be set/unset/modified to cause comparisons to succeed,\nand *it was not being used anywhere*. There is no reciprocal ability to\n*save* a vCard back out to make use of the stored Path, for instance. Arguably,\nthere should be, but it can be just as easily argued that initializing from a\nfile *doesn't belong in vCard* (as we can already load from a string) and, if it\ndoes belong, that we need to think about the interface for storing/loading and\ndo it right (and do we want to load from URLs as well?). For now, I removed\nthe internal property so that equality comparisons succeeed.","Eric Vought",true]],"size":1,"ref":"refs/heads/vcardToolsRefactor","head":"c7981662773bdd05f8b8c37864b74915c9f9ac64"}