GitHub PullRequestEvent at 2014-04-11 19:06:31
Repository: curate_uc
Actor: hortongn
Payload: {"action":"closed","number":33,"pull_request":{"url":"https://api.github.com/repos/uclibs/curate_uc/pulls/33","id":14512039,"html_url":"https://github.com/uclibs/curate_uc/pull/33","diff_url":"https://github.com/uclibs/curate_uc/pull/33.diff","patch_url":"https://github.com/uclibs/curate_uc/pull/33.patch","issue_url":"https://api.github.com/repos/uclibs/curate_uc/issues/33","number":33,"state":"closed","title":"Feature/#29 permissions","user":{"login":"jamesvanmil","id":2651187,"avatar_url":"https://avatars.githubusercontent.com/u/2651187?","gravatar_id":"c816210394e5639c7ba06970ff7ed7ab","url":"https://api.github.com/users/jamesvanmil","html_url":"https://github.com/jamesvanmil","followers_url":"https://api.github.com/users/jamesvanmil/followers","following_url":"https://api.github.com/users/jamesvanmil/following{/other_user}","gists_url":"https://api.github.com/users/jamesvanmil/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesvanmil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesvanmil/subscriptions","organizations_url":"https://api.github.com/users/jamesvanmil/orgs","repos_url":"https://api.github.com/users/jamesvanmil/repos","events_url":"https://api.github.com/users/jamesvanmil/events{/privacy}","received_events_url":"https://api.github.com/users/jamesvanmil/received_events","type":"User","site_admin":false},"body":"For both works and collections, the default checkbox is being selected based on a default permissions view on the @collections/@curation_concern var, e.g.:\r\n\r\nhttps://github.com/projecthydra/curate/blob/1b0822d0c6749b3919f42578948cc91c422d5d29/app/views/curate/collections/_form_permission.html.erb#L22\r\n\r\nIt looks like private? is returning true because the permissions have not already been set otherwise:\r\n\r\nhttps://github.com/projecthydra/hydra-head/blob/506c67ac8338e9ae8d38c1b3c9b34a4542328088/hydra-access-controls/app/models/concerns/hydra/access_controls/access_right.rb#L50\r\n\r\nI've addressed this by setting the visibility explicitly before the form is called, with, for example:\r\n\r\n<% @collection.visibility = Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_PUBLIC %>\r\n\r\nAnd I've manually confirmed that the selected privacy sticks if you change it during item creation. I haven't written any tests for this feature.","created_at":"2014-04-08T17:32:48Z","updated_at":"2014-04-11T19:06:30Z","closed_at":"2014-04-11T19:06:30Z","merged_at":"2014-04-11T19:06:30Z","merge_commit_sha":"5eaeb8b9ca9f6af88254a284b03282a165c96772","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/uclibs/curate_uc/pulls/33/commits","review_comments_url":"https://api.github.com/repos/uclibs/curate_uc/pulls/33/comments","review_comment_url":"https://api.github.com/repos/uclibs/curate_uc/pulls/comments/{number}","comments_url":"https://api.github.com/repos/uclibs/curate_uc/issues/33/comments","statuses_url":"https://api.github.com/repos/uclibs/curate_uc/statuses/2676e277dcf4ee35897920e593b4e72b2a683ca5","head":{"label":"uclibs:feature/#29-permissions","ref":"feature/#29-permissions","sha":"2676e277dcf4ee35897920e593b4e72b2a683ca5","user":{"login":"uclibs","id":6144529,"avatar_url":"https://avatars.githubusercontent.com/u/6144529?","gravatar_id":"d95729439af1df891b92a47daedf8b8d","url":"https://api.github.com/users/uclibs","html_url":"https://github.com/uclibs","followers_url":"https://api.github.com/users/uclibs/followers","following_url":"https://api.github.com/users/uclibs/following{/other_user}","gists_url":"https://api.github.com/users/uclibs/gists{/gist_id}","starred_url":"https://api.github.com/users/uclibs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uclibs/subscriptions","organizations_url":"https://api.github.com/users/uclibs/orgs","repos_url":"https://api.github.com/users/uclibs/repos","events_url":"https://api.github.com/users/uclibs/events{/privacy}","received_events_url":"https://api.github.com/users/uclibs/received_events","type":"Organization","site_admin":false},"repo":{"id":15346914,"name":"curate_uc","full_name":"uclibs/curate_uc","owner":{"login":"uclibs","id":6144529,"avatar_url":"https://avatars.githubusercontent.com/u/6144529?","gravatar_id":"d95729439af1df891b92a47daedf8b8d","url":"https://api.github.com/users/uclibs","html_url":"https://github.com/uclibs","followers_url":"https://api.github.com/users/uclibs/followers","following_url":"https://api.github.com/users/uclibs/following{/other_user}","gists_url":"https://api.github.com/users/uclibs/gists{/gist_id}","starred_url":"https://api.github.com/users/uclibs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uclibs/subscriptions","organizations_url":"https://api.github.com/users/uclibs/orgs","repos_url":"https://api.github.com/users/uclibs/repos","events_url":"https://api.github.com/users/uclibs/events{/privacy}","received_events_url":"https://api.github.com/users/uclibs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uclibs/curate_uc","description":"University of Cincinnati's application generated from curate.  https://github.com/projecthydra/curate","fork":false,"url":"https://api.github.com/repos/uclibs/curate_uc","forks_url":"https://api.github.com/repos/uclibs/curate_uc/forks","keys_url":"https://api.github.com/repos/uclibs/curate_uc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uclibs/curate_uc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uclibs/curate_uc/teams","hooks_url":"https://api.github.com/repos/uclibs/curate_uc/hooks","issue_events_url":"https://api.github.com/repos/uclibs/curate_uc/issues/events{/number}","events_url":"https://api.github.com/repos/uclibs/curate_uc/events","assignees_url":"https://api.github.com/repos/uclibs/curate_uc/assignees{/user}","branches_url":"https://api.github.com/repos/uclibs/curate_uc/branches{/branch}","tags_url":"https://api.github.com/repos/uclibs/curate_uc/tags","blobs_url":"https://api.github.com/repos/uclibs/curate_uc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uclibs/curate_uc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uclibs/curate_uc/git/refs{/sha}","trees_url":"https://api.github.com/repos/uclibs/curate_uc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uclibs/curate_uc/statuses/{sha}","languages_url":"https://api.github.com/repos/uclibs/curate_uc/languages","stargazers_url":"https://api.github.com/repos/uclibs/curate_uc/stargazers","contributors_url":"https://api.github.com/repos/uclibs/curate_uc/contributors","subscribers_url":"https://api.github.com/repos/uclibs/curate_uc/subscribers","subscription_url":"https://api.github.com/repos/uclibs/curate_uc/subscription","commits_url":"https://api.github.com/repos/uclibs/curate_uc/commits{/sha}","git_commits_url":"https://api.github.com/repos/uclibs/curate_uc/git/commits{/sha}","comments_url":"https://api.github.com/repos/uclibs/curate_uc/comments{/number}","issue_comment_url":"https://api.github.com/repos/uclibs/curate_uc/issues/comments/{number}","contents_url":"https://api.github.com/repos/uclibs/curate_uc/contents/{+path}","compare_url":"https://api.github.com/repos/uclibs/curate_uc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uclibs/curate_uc/merges","archive_url":"https://api.github.com/repos/uclibs/curate_uc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uclibs/curate_uc/downloads","issues_url":"https://api.github.com/repos/uclibs/curate_uc/issues{/number}","pulls_url":"https://api.github.com/repos/uclibs/curate_uc/pulls{/number}","milestones_url":"https://api.github.com/repos/uclibs/curate_uc/milestones{/number}","notifications_url":"https://api.github.com/repos/uclibs/curate_uc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uclibs/curate_uc/labels{/name}","releases_url":"https://api.github.com/repos/uclibs/curate_uc/releases{/id}","created_at":"2013-12-20T19:53:26Z","updated_at":"2014-04-11T19:06:30Z","pushed_at":"2014-04-11T19:06:30Z","git_url":"git://github.com/uclibs/curate_uc.git","ssh_url":"git@github.com:uclibs/curate_uc.git","clone_url":"https://github.com/uclibs/curate_uc.git","svn_url":"https://github.com/uclibs/curate_uc","homepage":null,"size":604,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":27,"forks":0,"open_issues":27,"watchers":1,"default_branch":"develop","master_branch":"develop"}},"base":{"label":"uclibs:develop","ref":"develop","sha":"1683d11191566d87c9ea14bad83e0e59226337c7","user":{"login":"uclibs","id":6144529,"avatar_url":"https://avatars.githubusercontent.com/u/6144529?","gravatar_id":"d95729439af1df891b92a47daedf8b8d","url":"https://api.github.com/users/uclibs","html_url":"https://github.com/uclibs","followers_url":"https://api.github.com/users/uclibs/followers","following_url":"https://api.github.com/users/uclibs/following{/other_user}","gists_url":"https://api.github.com/users/uclibs/gists{/gist_id}","starred_url":"https://api.github.com/users/uclibs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uclibs/subscriptions","organizations_url":"https://api.github.com/users/uclibs/orgs","repos_url":"https://api.github.com/users/uclibs/repos","events_url":"https://api.github.com/users/uclibs/events{/privacy}","received_events_url":"https://api.github.com/users/uclibs/received_events","type":"Organization","site_admin":false},"repo":{"id":15346914,"name":"curate_uc","full_name":"uclibs/curate_uc","owner":{"login":"uclibs","id":6144529,"avatar_url":"https://avatars.githubusercontent.com/u/6144529?","gravatar_id":"d95729439af1df891b92a47daedf8b8d","url":"https://api.github.com/users/uclibs","html_url":"https://github.com/uclibs","followers_url":"https://api.github.com/users/uclibs/followers","following_url":"https://api.github.com/users/uclibs/following{/other_user}","gists_url":"https://api.github.com/users/uclibs/gists{/gist_id}","starred_url":"https://api.github.com/users/uclibs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uclibs/subscriptions","organizations_url":"https://api.github.com/users/uclibs/orgs","repos_url":"https://api.github.com/users/uclibs/repos","events_url":"https://api.github.com/users/uclibs/events{/privacy}","received_events_url":"https://api.github.com/users/uclibs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uclibs/curate_uc","description":"University of Cincinnati's application generated from curate.  https://github.com/projecthydra/curate","fork":false,"url":"https://api.github.com/repos/uclibs/curate_uc","forks_url":"https://api.github.com/repos/uclibs/curate_uc/forks","keys_url":"https://api.github.com/repos/uclibs/curate_uc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uclibs/curate_uc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uclibs/curate_uc/teams","hooks_url":"https://api.github.com/repos/uclibs/curate_uc/hooks","issue_events_url":"https://api.github.com/repos/uclibs/curate_uc/issues/events{/number}","events_url":"https://api.github.com/repos/uclibs/curate_uc/events","assignees_url":"https://api.github.com/repos/uclibs/curate_uc/assignees{/user}","branches_url":"https://api.github.com/repos/uclibs/curate_uc/branches{/branch}","tags_url":"https://api.github.com/repos/uclibs/curate_uc/tags","blobs_url":"https://api.github.com/repos/uclibs/curate_uc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uclibs/curate_uc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uclibs/curate_uc/git/refs{/sha}","trees_url":"https://api.github.com/repos/uclibs/curate_uc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uclibs/curate_uc/statuses/{sha}","languages_url":"https://api.github.com/repos/uclibs/curate_uc/languages","stargazers_url":"https://api.github.com/repos/uclibs/curate_uc/stargazers","contributors_url":"https://api.github.com/repos/uclibs/curate_uc/contributors","subscribers_url":"https://api.github.com/repos/uclibs/curate_uc/subscribers","subscription_url":"https://api.github.com/repos/uclibs/curate_uc/subscription","commits_url":"https://api.github.com/repos/uclibs/curate_uc/commits{/sha}","git_commits_url":"https://api.github.com/repos/uclibs/curate_uc/git/commits{/sha}","comments_url":"https://api.github.com/repos/uclibs/curate_uc/comments{/number}","issue_comment_url":"https://api.github.com/repos/uclibs/curate_uc/issues/comments/{number}","contents_url":"https://api.github.com/repos/uclibs/curate_uc/contents/{+path}","compare_url":"https://api.github.com/repos/uclibs/curate_uc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uclibs/curate_uc/merges","archive_url":"https://api.github.com/repos/uclibs/curate_uc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uclibs/curate_uc/downloads","issues_url":"https://api.github.com/repos/uclibs/curate_uc/issues{/number}","pulls_url":"https://api.github.com/repos/uclibs/curate_uc/pulls{/number}","milestones_url":"https://api.github.com/repos/uclibs/curate_uc/milestones{/number}","notifications_url":"https://api.github.com/repos/uclibs/curate_uc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uclibs/curate_uc/labels{/name}","releases_url":"https://api.github.com/repos/uclibs/curate_uc/releases{/id}","created_at":"2013-12-20T19:53:26Z","updated_at":"2014-04-11T19:06:30Z","pushed_at":"2014-04-11T19:06:30Z","git_url":"git://github.com/uclibs/curate_uc.git","ssh_url":"git@github.com:uclibs/curate_uc.git","clone_url":"https://github.com/uclibs/curate_uc.git","svn_url":"https://github.com/uclibs/curate_uc","homepage":null,"size":604,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":27,"forks":0,"open_issues":27,"watchers":1,"default_branch":"develop","master_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/uclibs/curate_uc/pulls/33"},"html":{"href":"https://github.com/uclibs/curate_uc/pull/33"},"issue":{"href":"https://api.github.com/repos/uclibs/curate_uc/issues/33"},"comments":{"href":"https://api.github.com/repos/uclibs/curate_uc/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/uclibs/curate_uc/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/uclibs/curate_uc/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/uclibs/curate_uc/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/uclibs/curate_uc/statuses/2676e277dcf4ee35897920e593b4e72b2a683ca5"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"hortongn","id":5639859,"avatar_url":"https://avatars.githubusercontent.com/u/5639859?","gravatar_id":"4f3c33071baed97c69c6bc0d9e490ad4","url":"https://api.github.com/users/hortongn","html_url":"https://github.com/hortongn","followers_url":"https://api.github.com/users/hortongn/followers","following_url":"https://api.github.com/users/hortongn/following{/other_user}","gists_url":"https://api.github.com/users/hortongn/gists{/gist_id}","starred_url":"https://api.github.com/users/hortongn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hortongn/subscriptions","organizations_url":"https://api.github.com/users/hortongn/orgs","repos_url":"https://api.github.com/users/hortongn/repos","events_url":"https://api.github.com/users/hortongn/events{/privacy}","received_events_url":"https://api.github.com/users/hortongn/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":521,"deletions":103,"changed_files":19}}