GitHub PullRequestEvent at 2014-12-03 11:03:22
Repository: spark
Actor: asfgit
Payload: {"action":"closed","number":3565,"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/3565","id":25389405,"html_url":"https://github.com/apache/spark/pull/3565","diff_url":"https://github.com/apache/spark/pull/3565.diff","patch_url":"https://github.com/apache/spark/pull/3565.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/3565","number":3565,"state":"closed","locked":false,"title":"[SPARK-4708][MLLib] Make k-mean runs two/three times faster with dense/sparse sample","user":{"login":"dbtsai","id":1134574,"avatar_url":"https://avatars.githubusercontent.com/u/1134574?v=3","gravatar_id":"","url":"https://api.github.com/users/dbtsai","html_url":"https://github.com/dbtsai","followers_url":"https://api.github.com/users/dbtsai/followers","following_url":"https://api.github.com/users/dbtsai/following{/other_user}","gists_url":"https://api.github.com/users/dbtsai/gists{/gist_id}","starred_url":"https://api.github.com/users/dbtsai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbtsai/subscriptions","organizations_url":"https://api.github.com/users/dbtsai/orgs","repos_url":"https://api.github.com/users/dbtsai/repos","events_url":"https://api.github.com/users/dbtsai/events{/privacy}","received_events_url":"https://api.github.com/users/dbtsai/received_events","type":"User","site_admin":false},"body":"Note that the usage of `breezeSquaredDistance` in \r\n`org.apache.spark.mllib.util.MLUtils.fastSquaredDistance` \r\nis in the critical path, and `breezeSquaredDistance` is slow. \r\nWe should replace it with our own implementation.\r\n\r\nHere is the benchmark against mnist8m dataset.\r\n\r\nBefore\r\nDenseVector: 70.04secs\r\nSparseVector: 59.05secs\r\n\r\nWith this PR\r\nDenseVector: 30.58secs\r\nSparseVector: 21.14secs\r\n","created_at":"2014-12-03T01:22:21Z","updated_at":"2014-12-03T11:03:21Z","closed_at":"2014-12-03T11:03:21Z","merged_at":null,"merge_commit_sha":"209fada8c82ea6473fbf5398bc56ca0bdf8511be","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/3565/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/3565/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments/{number}","comments_url":"https://api.github.com/repos/apache/spark/issues/3565/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/08bc068edd49f4e988b8e97a0c11ea57a371dca1","head":{"label":"AlpineNow:kmean","ref":"kmean","sha":"08bc068edd49f4e988b8e97a0c11ea57a371dca1","user":{"login":"AlpineNow","id":6020016,"avatar_url":"https://avatars.githubusercontent.com/u/6020016?v=3","gravatar_id":"","url":"https://api.github.com/users/AlpineNow","html_url":"https://github.com/AlpineNow","followers_url":"https://api.github.com/users/AlpineNow/followers","following_url":"https://api.github.com/users/AlpineNow/following{/other_user}","gists_url":"https://api.github.com/users/AlpineNow/gists{/gist_id}","starred_url":"https://api.github.com/users/AlpineNow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlpineNow/subscriptions","organizations_url":"https://api.github.com/users/AlpineNow/orgs","repos_url":"https://api.github.com/users/AlpineNow/repos","events_url":"https://api.github.com/users/AlpineNow/events{/privacy}","received_events_url":"https://api.github.com/users/AlpineNow/received_events","type":"Organization","site_admin":false},"repo":{"id":17268927,"name":"spark","full_name":"AlpineNow/spark","owner":{"login":"AlpineNow","id":6020016,"avatar_url":"https://avatars.githubusercontent.com/u/6020016?v=3","gravatar_id":"","url":"https://api.github.com/users/AlpineNow","html_url":"https://github.com/AlpineNow","followers_url":"https://api.github.com/users/AlpineNow/followers","following_url":"https://api.github.com/users/AlpineNow/following{/other_user}","gists_url":"https://api.github.com/users/AlpineNow/gists{/gist_id}","starred_url":"https://api.github.com/users/AlpineNow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlpineNow/subscriptions","organizations_url":"https://api.github.com/users/AlpineNow/orgs","repos_url":"https://api.github.com/users/AlpineNow/repos","events_url":"https://api.github.com/users/AlpineNow/events{/privacy}","received_events_url":"https://api.github.com/users/AlpineNow/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AlpineNow/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/AlpineNow/spark","forks_url":"https://api.github.com/repos/AlpineNow/spark/forks","keys_url":"https://api.github.com/repos/AlpineNow/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AlpineNow/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AlpineNow/spark/teams","hooks_url":"https://api.github.com/repos/AlpineNow/spark/hooks","issue_events_url":"https://api.github.com/repos/AlpineNow/spark/issues/events{/number}","events_url":"https://api.github.com/repos/AlpineNow/spark/events","assignees_url":"https://api.github.com/repos/AlpineNow/spark/assignees{/user}","branches_url":"https://api.github.com/repos/AlpineNow/spark/branches{/branch}","tags_url":"https://api.github.com/repos/AlpineNow/spark/tags","blobs_url":"https://api.github.com/repos/AlpineNow/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AlpineNow/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AlpineNow/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/AlpineNow/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AlpineNow/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/AlpineNow/spark/languages","stargazers_url":"https://api.github.com/repos/AlpineNow/spark/stargazers","contributors_url":"https://api.github.com/repos/AlpineNow/spark/contributors","subscribers_url":"https://api.github.com/repos/AlpineNow/spark/subscribers","subscription_url":"https://api.github.com/repos/AlpineNow/spark/subscription","commits_url":"https://api.github.com/repos/AlpineNow/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/AlpineNow/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/AlpineNow/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/AlpineNow/spark/issues/comments/{number}","contents_url":"https://api.github.com/repos/AlpineNow/spark/contents/{+path}","compare_url":"https://api.github.com/repos/AlpineNow/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AlpineNow/spark/merges","archive_url":"https://api.github.com/repos/AlpineNow/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AlpineNow/spark/downloads","issues_url":"https://api.github.com/repos/AlpineNow/spark/issues{/number}","pulls_url":"https://api.github.com/repos/AlpineNow/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/AlpineNow/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/AlpineNow/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AlpineNow/spark/labels{/name}","releases_url":"https://api.github.com/repos/AlpineNow/spark/releases{/id}","created_at":"2014-02-27T23:35:04Z","updated_at":"2014-12-03T10:10:11Z","pushed_at":"2014-12-03T10:10:10Z","git_url":"git://github.com/AlpineNow/spark.git","ssh_url":"git@github.com:AlpineNow/spark.git","clone_url":"https://github.com/AlpineNow/spark.git","svn_url":"https://github.com/AlpineNow/spark","homepage":null,"size":90028,"stargazers_count":1,"watchers_count":1,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"17c162f6682520e6e2790626e37da3a074471793","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments/{number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2014-12-03T11:02:37Z","pushed_at":"2014-12-03T11:02:59Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":1000220,"stargazers_count":2200,"watchers_count":2200,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1965,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":321,"forks":1965,"open_issues":321,"watchers":2200,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/3565"},"html":{"href":"https://github.com/apache/spark/pull/3565"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/3565"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/3565/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/3565/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/3565/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/08bc068edd49f4e988b8e97a0c11ea57a371dca1"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":10,"review_comments":4,"commits":4,"additions":70,"deletions":68,"changed_files":5}}