GitHub PullRequestReviewCommentEvent at 2014-06-26 20:18:06
Repository: vwf
Actor: eric79
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/virtual-world-framework/vwf/pulls/comments/14263877","id":14263877,"diff_hunk":"@@ -1064,28 +1085,29 @@ future.hasOwnProperty( eventName ) ||  // TODO: calculate so that properties tak\n             },\n \n             set: unsettable ? undefined : function( value ) {  // `this` is the container\n-                var node = this.node || this;  // the node via node.events.node, or just node\n+                var node = this.node || this;  // the node via node.*collection*.node, or just node\n+                var namespacedName = eventNamespace ? [ eventNamespace, eventName ] : eventName;\n                 if ( typeof value == \"function\" || value instanceof Function ) {\n-                    self.kernel.addEventListener.call( self, node.id, eventName,\n+                    self.kernel.addEventListener.call( self, node.id, namespacedName,\n                         value, node.id );  // for container.*event* = function() { ... }, context is the target node\n                 } else if ( value.add ) {\n                     if ( ! value.phases || value.phases instanceof Array ) {\n-                        self.kernel.addEventListener.call( self, node.id, eventName,\n+                        self.kernel.addEventListener.call( self, node.id, namespacedName,\n                             value.handler, value.context && value.context.id, value.phases );\n                     } else {\n-                        self.kernel.addEventListener.call( self, node.id, eventName,\n+                        self.kernel.addEventListener.call( self, node.id, namespacedName,\n                             value.handler, value.context && value.context.id, [ value.phases ] );\n                     }\n                 } else if ( value.remove ) {\n-                    self.kernel.removeEventListener.call( self, node.id, eventName,\n+                    self.kernel.removeEventListener.call( self, node.id, namespacedName,\n                         value.handler );\n                 } else if ( value.flush ) {\n-                    self.kernel.flushEventListeners.call( self, node.id, eventName,\n+                    self.kernel.flushEventListeners.call( self, node.id, namespacedName,\n                         value.context && value.context.id );\n                 }\n             },\n \n-            enumerable: true,\n+            enumerable: ! eventNamespace,","path":"support/client/lib/vwf/model/javascript.js","position":113,"original_position":113,"commit_id":"57eac0eb27574f2d66781d43952aeb1ab6386fff","original_commit_id":"57eac0eb27574f2d66781d43952aeb1ab6386fff","user":{"login":"eric79","id":3160246,"avatar_url":"https://avatars.githubusercontent.com/u/3160246?","gravatar_id":"4415aa6694e175736b82fc39ae6f1e5e","url":"https://api.github.com/users/eric79","html_url":"https://github.com/eric79","followers_url":"https://api.github.com/users/eric79/followers","following_url":"https://api.github.com/users/eric79/following{/other_user}","gists_url":"https://api.github.com/users/eric79/gists{/gist_id}","starred_url":"https://api.github.com/users/eric79/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eric79/subscriptions","organizations_url":"https://api.github.com/users/eric79/orgs","repos_url":"https://api.github.com/users/eric79/repos","events_url":"https://api.github.com/users/eric79/events{/privacy}","received_events_url":"https://api.github.com/users/eric79/received_events","type":"User","site_admin":false},"body":"Gotcha.","created_at":"2014-06-26T20:18:06Z","updated_at":"2014-06-26T20:18:06Z","html_url":"https://github.com/virtual-world-framework/vwf/pull/145#discussion_r14263877","pull_request_url":"https://api.github.com/repos/virtual-world-framework/vwf/pulls/145","_links":{"self":{"href":"https://api.github.com/repos/virtual-world-framework/vwf/pulls/comments/14263877"},"html":{"href":"https://github.com/virtual-world-framework/vwf/pull/145#discussion_r14263877"},"pull_request":{"href":"https://api.github.com/repos/virtual-world-framework/vwf/pulls/145"}}},"pull_request":{"url":"https://api.github.com/repos/virtual-world-framework/vwf/pulls/145","id":12873464,"html_url":"https://github.com/virtual-world-framework/vwf/pull/145","diff_url":"https://github.com/virtual-world-framework/vwf/pull/145.diff","patch_url":"https://github.com/virtual-world-framework/vwf/pull/145.patch","issue_url":"https://api.github.com/repos/virtual-world-framework/vwf/issues/145","number":145,"state":"open","title":"Collection events","user":{"login":"davideaster","id":1580409,"avatar_url":"https://avatars.githubusercontent.com/u/1580409?","gravatar_id":"f30497f5e997fadbbfe3a0161e802838","url":"https://api.github.com/users/davideaster","html_url":"https://github.com/davideaster","followers_url":"https://api.github.com/users/davideaster/followers","following_url":"https://api.github.com/users/davideaster/following{/other_user}","gists_url":"https://api.github.com/users/davideaster/gists{/gist_id}","starred_url":"https://api.github.com/users/davideaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davideaster/subscriptions","organizations_url":"https://api.github.com/users/davideaster/orgs","repos_url":"https://api.github.com/users/davideaster/repos","events_url":"https://api.github.com/users/davideaster/events{/privacy}","received_events_url":"https://api.github.com/users/davideaster/received_events","type":"User","site_admin":false},"body":"Send meta events from the kernel into the application notifying the application about changes to the `children`, `properties`, `methods`, and `events` collections. Add pseudo events at `node.children.{added,removed}`, `node.properties.{created,initialized,deleted}`, `node.methods.{created,deleted}`, and `node.events.{created,deleted}` to manage listeners for the meta events.\r\n\r\n@eric79, @allisoncorey, please review. @scottnc27603, @jessmartin, fyi.\r\n","created_at":"2014-02-24T20:51:29Z","updated_at":"2014-06-26T20:18:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f962ecd577efd095139b3ef21d96e74ab4cb6d1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/virtual-world-framework/vwf/pulls/145/commits","review_comments_url":"https://api.github.com/repos/virtual-world-framework/vwf/pulls/145/comments","review_comment_url":"https://api.github.com/repos/virtual-world-framework/vwf/pulls/comments/{number}","comments_url":"https://api.github.com/repos/virtual-world-framework/vwf/issues/145/comments","statuses_url":"https://api.github.com/repos/virtual-world-framework/vwf/statuses/57eac0eb27574f2d66781d43952aeb1ab6386fff","head":{"label":"virtual-world-framework:branch/collection-events","ref":"branch/collection-events","sha":"57eac0eb27574f2d66781d43952aeb1ab6386fff","user":{"login":"virtual-world-framework","id":1552130,"avatar_url":"https://avatars.githubusercontent.com/u/1552130?","gravatar_id":"4030558125d47329a00e5378c95d401b","url":"https://api.github.com/users/virtual-world-framework","html_url":"https://github.com/virtual-world-framework","followers_url":"https://api.github.com/users/virtual-world-framework/followers","following_url":"https://api.github.com/users/virtual-world-framework/following{/other_user}","gists_url":"https://api.github.com/users/virtual-world-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/virtual-world-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/virtual-world-framework/subscriptions","organizations_url":"https://api.github.com/users/virtual-world-framework/orgs","repos_url":"https://api.github.com/users/virtual-world-framework/repos","events_url":"https://api.github.com/users/virtual-world-framework/events{/privacy}","received_events_url":"https://api.github.com/users/virtual-world-framework/received_events","type":"Organization","site_admin":false},"repo":{"id":3857149,"name":"vwf","full_name":"virtual-world-framework/vwf","owner":{"login":"virtual-world-framework","id":1552130,"avatar_url":"https://avatars.githubusercontent.com/u/1552130?","gravatar_id":"4030558125d47329a00e5378c95d401b","url":"https://api.github.com/users/virtual-world-framework","html_url":"https://github.com/virtual-world-framework","followers_url":"https://api.github.com/users/virtual-world-framework/followers","following_url":"https://api.github.com/users/virtual-world-framework/following{/other_user}","gists_url":"https://api.github.com/users/virtual-world-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/virtual-world-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/virtual-world-framework/subscriptions","organizations_url":"https://api.github.com/users/virtual-world-framework/orgs","repos_url":"https://api.github.com/users/virtual-world-framework/repos","events_url":"https://api.github.com/users/virtual-world-framework/events{/privacy}","received_events_url":"https://api.github.com/users/virtual-world-framework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/virtual-world-framework/vwf","description":"Virtual World Framework","fork":false,"url":"https://api.github.com/repos/virtual-world-framework/vwf","forks_url":"https://api.github.com/repos/virtual-world-framework/vwf/forks","keys_url":"https://api.github.com/repos/virtual-world-framework/vwf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/virtual-world-framework/vwf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/virtual-world-framework/vwf/teams","hooks_url":"https://api.github.com/repos/virtual-world-framework/vwf/hooks","issue_events_url":"https://api.github.com/repos/virtual-world-framework/vwf/issues/events{/number}","events_url":"https://api.github.com/repos/virtual-world-framework/vwf/events","assignees_url":"https://api.github.com/repos/virtual-world-framework/vwf/assignees{/user}","branches_url":"https://api.github.com/repos/virtual-world-framework/vwf/branches{/branch}","tags_url":"https://api.github.com/repos/virtual-world-framework/vwf/tags","blobs_url":"https://api.github.com/repos/virtual-world-framework/vwf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/virtual-world-framework/vwf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/virtual-world-framework/vwf/git/refs{/sha}","trees_url":"https://api.github.com/repos/virtual-world-framework/vwf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/virtual-world-framework/vwf/statuses/{sha}","languages_url":"https://api.github.com/repos/virtual-world-framework/vwf/languages","stargazers_url":"https://api.github.com/repos/virtual-world-framework/vwf/stargazers","contributors_url":"https://api.github.com/repos/virtual-world-framework/vwf/contributors","subscribers_url":"https://api.github.com/repos/virtual-world-framework/vwf/subscribers","subscription_url":"https://api.github.com/repos/virtual-world-framework/vwf/subscription","commits_url":"https://api.github.com/repos/virtual-world-framework/vwf/commits{/sha}","git_commits_url":"https://api.github.com/repos/virtual-world-framework/vwf/git/commits{/sha}","comments_url":"https://api.github.com/repos/virtual-world-framework/vwf/comments{/number}","issue_comment_url":"https://api.github.com/repos/virtual-world-framework/vwf/issues/comments/{number}","contents_url":"https://api.github.com/repos/virtual-world-framework/vwf/contents/{+path}","compare_url":"https://api.github.com/repos/virtual-world-framework/vwf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/virtual-world-framework/vwf/merges","archive_url":"https://api.github.com/repos/virtual-world-framework/vwf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/virtual-world-framework/vwf/downloads","issues_url":"https://api.github.com/repos/virtual-world-framework/vwf/issues{/number}","pulls_url":"https://api.github.com/repos/virtual-world-framework/vwf/pulls{/number}","milestones_url":"https://api.github.com/repos/virtual-world-framework/vwf/milestones{/number}","notifications_url":"https://api.github.com/repos/virtual-world-framework/vwf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/virtual-world-framework/vwf/labels{/name}","releases_url":"https://api.github.com/repos/virtual-world-framework/vwf/releases{/id}","created_at":"2012-03-28T16:40:09Z","updated_at":"2014-06-25T04:38:06Z","pushed_at":"2014-06-26T18:46:24Z","git_url":"git://github.com/virtual-world-framework/vwf.git","ssh_url":"git@github.com:virtual-world-framework/vwf.git","clone_url":"https://github.com/virtual-world-framework/vwf.git","svn_url":"https://github.com/virtual-world-framework/vwf","homepage":"http://virtual.wf","size":733020,"stargazers_count":72,"watchers_count":72,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":40,"mirror_url":null,"open_issues_count":22,"forks":40,"open_issues":22,"watchers":72,"default_branch":"master"}},"base":{"label":"virtual-world-framework:branch/node-references","ref":"branch/node-references","sha":"f0d28fdc9f9051e482ea30967c16c7d800ee5855","user":{"login":"virtual-world-framework","id":1552130,"avatar_url":"https://avatars.githubusercontent.com/u/1552130?","gravatar_id":"4030558125d47329a00e5378c95d401b","url":"https://api.github.com/users/virtual-world-framework","html_url":"https://github.com/virtual-world-framework","followers_url":"https://api.github.com/users/virtual-world-framework/followers","following_url":"https://api.github.com/users/virtual-world-framework/following{/other_user}","gists_url":"https://api.github.com/users/virtual-world-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/virtual-world-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/virtual-world-framework/subscriptions","organizations_url":"https://api.github.com/users/virtual-world-framework/orgs","repos_url":"https://api.github.com/users/virtual-world-framework/repos","events_url":"https://api.github.com/users/virtual-world-framework/events{/privacy}","received_events_url":"https://api.github.com/users/virtual-world-framework/received_events","type":"Organization","site_admin":false},"repo":{"id":3857149,"name":"vwf","full_name":"virtual-world-framework/vwf","owner":{"login":"virtual-world-framework","id":1552130,"avatar_url":"https://avatars.githubusercontent.com/u/1552130?","gravatar_id":"4030558125d47329a00e5378c95d401b","url":"https://api.github.com/users/virtual-world-framework","html_url":"https://github.com/virtual-world-framework","followers_url":"https://api.github.com/users/virtual-world-framework/followers","following_url":"https://api.github.com/users/virtual-world-framework/following{/other_user}","gists_url":"https://api.github.com/users/virtual-world-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/virtual-world-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/virtual-world-framework/subscriptions","organizations_url":"https://api.github.com/users/virtual-world-framework/orgs","repos_url":"https://api.github.com/users/virtual-world-framework/repos","events_url":"https://api.github.com/users/virtual-world-framework/events{/privacy}","received_events_url":"https://api.github.com/users/virtual-world-framework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/virtual-world-framework/vwf","description":"Virtual World Framework","fork":false,"url":"https://api.github.com/repos/virtual-world-framework/vwf","forks_url":"https://api.github.com/repos/virtual-world-framework/vwf/forks","keys_url":"https://api.github.com/repos/virtual-world-framework/vwf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/virtual-world-framework/vwf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/virtual-world-framework/vwf/teams","hooks_url":"https://api.github.com/repos/virtual-world-framework/vwf/hooks","issue_events_url":"https://api.github.com/repos/virtual-world-framework/vwf/issues/events{/number}","events_url":"https://api.github.com/repos/virtual-world-framework/vwf/events","assignees_url":"https://api.github.com/repos/virtual-world-framework/vwf/assignees{/user}","branches_url":"https://api.github.com/repos/virtual-world-framework/vwf/branches{/branch}","tags_url":"https://api.github.com/repos/virtual-world-framework/vwf/tags","blobs_url":"https://api.github.com/repos/virtual-world-framework/vwf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/virtual-world-framework/vwf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/virtual-world-framework/vwf/git/refs{/sha}","trees_url":"https://api.github.com/repos/virtual-world-framework/vwf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/virtual-world-framework/vwf/statuses/{sha}","languages_url":"https://api.github.com/repos/virtual-world-framework/vwf/languages","stargazers_url":"https://api.github.com/repos/virtual-world-framework/vwf/stargazers","contributors_url":"https://api.github.com/repos/virtual-world-framework/vwf/contributors","subscribers_url":"https://api.github.com/repos/virtual-world-framework/vwf/subscribers","subscription_url":"https://api.github.com/repos/virtual-world-framework/vwf/subscription","commits_url":"https://api.github.com/repos/virtual-world-framework/vwf/commits{/sha}","git_commits_url":"https://api.github.com/repos/virtual-world-framework/vwf/git/commits{/sha}","comments_url":"https://api.github.com/repos/virtual-world-framework/vwf/comments{/number}","issue_comment_url":"https://api.github.com/repos/virtual-world-framework/vwf/issues/comments/{number}","contents_url":"https://api.github.com/repos/virtual-world-framework/vwf/contents/{+path}","compare_url":"https://api.github.com/repos/virtual-world-framework/vwf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/virtual-world-framework/vwf/merges","archive_url":"https://api.github.com/repos/virtual-world-framework/vwf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/virtual-world-framework/vwf/downloads","issues_url":"https://api.github.com/repos/virtual-world-framework/vwf/issues{/number}","pulls_url":"https://api.github.com/repos/virtual-world-framework/vwf/pulls{/number}","milestones_url":"https://api.github.com/repos/virtual-world-framework/vwf/milestones{/number}","notifications_url":"https://api.github.com/repos/virtual-world-framework/vwf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/virtual-world-framework/vwf/labels{/name}","releases_url":"https://api.github.com/repos/virtual-world-framework/vwf/releases{/id}","created_at":"2012-03-28T16:40:09Z","updated_at":"2014-06-25T04:38:06Z","pushed_at":"2014-06-26T18:46:24Z","git_url":"git://github.com/virtual-world-framework/vwf.git","ssh_url":"git@github.com:virtual-world-framework/vwf.git","clone_url":"https://github.com/virtual-world-framework/vwf.git","svn_url":"https://github.com/virtual-world-framework/vwf","homepage":"http://virtual.wf","size":733020,"stargazers_count":72,"watchers_count":72,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":40,"mirror_url":null,"open_issues_count":22,"forks":40,"open_issues":22,"watchers":72,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/virtual-world-framework/vwf/pulls/145"},"html":{"href":"https://github.com/virtual-world-framework/vwf/pull/145"},"issue":{"href":"https://api.github.com/repos/virtual-world-framework/vwf/issues/145"},"comments":{"href":"https://api.github.com/repos/virtual-world-framework/vwf/issues/145/comments"},"review_comments":{"href":"https://api.github.com/repos/virtual-world-framework/vwf/pulls/145/comments"},"review_comment":{"href":"https://api.github.com/repos/virtual-world-framework/vwf/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/virtual-world-framework/vwf/pulls/145/commits"},"statuses":{"href":"https://api.github.com/repos/virtual-world-framework/vwf/statuses/57eac0eb27574f2d66781d43952aeb1ab6386fff"}}}}