GitHub PullRequestEvent at 2014-02-14 14:17:53
Repository: UICollectionView-Spring-Demo
Actor: AshFurrow
Payload: {"action":"closed","number":9,"pull_request":{"url":"https://api.github.com/repos/TeehanLax/UICollectionView-Spring-Demo/pulls/9","id":12548156,"html_url":"https://github.com/TeehanLax/UICollectionView-Spring-Demo/pull/9","diff_url":"https://github.com/TeehanLax/UICollectionView-Spring-Demo/pull/9.diff","patch_url":"https://github.com/TeehanLax/UICollectionView-Spring-Demo/pull/9.patch","issue_url":"https://api.github.com/repos/TeehanLax/UICollectionView-Spring-Demo/issues/9","number":9,"state":"closed","title":"crash on insert, disappearing header / footer","user":{"login":"odyth","id":947020,"avatar_url":"https://gravatar.com/avatar/1895b194abc6bbb39520cf190f18a87f?d=https%3A%2F%2Fidenticons.github.com%2Fc84674e6165e8a96fa1f5ae2176e3cae.png&r=x","gravatar_id":"1895b194abc6bbb39520cf190f18a87f","url":"https://api.github.com/users/odyth","html_url":"https://github.com/odyth","followers_url":"https://api.github.com/users/odyth/followers","following_url":"https://api.github.com/users/odyth/following{/other_user}","gists_url":"https://api.github.com/users/odyth/gists{/gist_id}","starred_url":"https://api.github.com/users/odyth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odyth/subscriptions","organizations_url":"https://api.github.com/users/odyth/orgs","repos_url":"https://api.github.com/users/odyth/repos","events_url":"https://api.github.com/users/odyth/events{/privacy}","received_events_url":"https://api.github.com/users/odyth/received_events","type":"User","site_admin":false},"body":"This fixes two issues.\r\n\r\n1) there is a crash when inserting cells if you are trying to reuse a UIAttachmentBehavior if its already in the dynamic animator\r\n\r\n2) if you have headers or footers they will disappear once scrolled out of view, but since headers and footer share the same index path as the first and last item they wont reappear consistently.  Added a set just for headers and footers.","created_at":"2014-02-14T09:54:17Z","updated_at":"2014-02-14T14:17:53Z","closed_at":"2014-02-14T14:17:53Z","merged_at":"2014-02-14T14:17:53Z","merge_commit_sha":"8ff6405419fe6af2945556b581f1d39745b19f6a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/TeehanLax/UICollectionView-Spring-Demo/pulls/9/commits","review_comments_url":"https://api.github.com/repos/TeehanLax/UICollectionView-Spring-Demo/pulls/9/comments","review_comment_url":"https://api.github.com/repos/TeehanLax/UICollectionView-Spring-Demo/pulls/comments/{number}","comments_url":"https://api.github.com/repos/TeehanLax/UICollectionView-Spring-Demo/issues/9/comments","statuses_url":"https://api.github.com/repos/TeehanLax/UICollectionView-Spring-Demo/statuses/4d52b8dfb8852192ae3831f4d0f9e4d9d39ddd79","head":{"label":"odyth:master","ref":"master","sha":"4d52b8dfb8852192ae3831f4d0f9e4d9d39ddd79","user":{"login":"odyth","id":947020,"avatar_url":"https://gravatar.com/avatar/1895b194abc6bbb39520cf190f18a87f?d=https%3A%2F%2Fidenticons.github.com%2Fc84674e6165e8a96fa1f5ae2176e3cae.png&r=x","gravatar_id":"1895b194abc6bbb39520cf190f18a87f","url":"https://api.github.com/users/odyth","html_url":"https://github.com/odyth","followers_url":"https://api.github.com/users/odyth/followers","following_url":"https://api.github.com/users/odyth/following{/other_user}","gists_url":"https://api.github.com/users/odyth/gists{/gist_id}","starred_url":"https://api.github.com/users/odyth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odyth/subscriptions","organizations_url":"https://api.github.com/users/odyth/orgs","repos_url":"https://api.github.com/users/odyth/repos","events_url":"https://api.github.com/users/odyth/events{/privacy}","received_events_url":"https://api.github.com/users/odyth/received_events","type":"User","site_admin":false},"repo":{"id":16833384,"name":"UICollectionView-Spring-Demo","full_name":"odyth/UICollectionView-Spring-Demo","owner":{"login":"odyth","id":947020,"avatar_url":"https://gravatar.com/avatar/1895b194abc6bbb39520cf190f18a87f?d=https%3A%2F%2Fidenticons.github.com%2Fc84674e6165e8a96fa1f5ae2176e3cae.png&r=x","gravatar_id":"1895b194abc6bbb39520cf190f18a87f","url":"https://api.github.com/users/odyth","html_url":"https://github.com/odyth","followers_url":"https://api.github.com/users/odyth/followers","following_url":"https://api.github.com/users/odyth/following{/other_user}","gists_url":"https://api.github.com/users/odyth/gists{/gist_id}","starred_url":"https://api.github.com/users/odyth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odyth/subscriptions","organizations_url":"https://api.github.com/users/odyth/orgs","repos_url":"https://api.github.com/users/odyth/repos","events_url":"https://api.github.com/users/odyth/events{/privacy}","received_events_url":"https://api.github.com/users/odyth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/odyth/UICollectionView-Spring-Demo","description":"A demonstration of UICollectionView and UIKit Dynamics","fork":true,"url":"https://api.github.com/repos/odyth/UICollectionView-Spring-Demo","forks_url":"https://api.github.com/repos/odyth/UICollectionView-Spring-Demo/forks","keys_url":"https://api.github.com/repos/odyth/UICollectionView-Spring-Demo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/odyth/UICollectionView-Spring-Demo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/odyth/UICollectionView-Spring-Demo/teams","hooks_url":"https://api.github.com/repos/odyth/UICollectionView-Spring-Demo/hooks","issue_events_url":"https://api.github.com/repos/odyth/UICollectionView-Spring-Demo/issues/events{/number}","events_url":"https://api.github.com/repos/odyth/UICollectionView-Spring-Demo/events","assignees_url":"https://api.github.com/repos/odyth/UICollectionView-Spring-Demo/assignees{/user}","branches_url":"https://api.github.com/repos/odyth/UICollectionView-Spring-Demo/branches{/branch}","tags_url":"https://api.github.com/repos/odyth/UICollectionView-Spring-Demo/tags","blobs_url":"https://api.github.com/repos/odyth/UICollectionView-Spring-Demo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/odyth/UICollectionView-Spring-Demo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/odyth/UICollectionView-Spring-Demo/git/refs{/sha}","trees_url":"https://api.github.com/repos/odyth/UICollectionView-Spring-Demo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/odyth/UICollectionView-Spring-Demo/statuses/{sha}","languages_url":"https://api.github.com/repos/odyth/UICollectionView-Spring-Demo/languages","stargazers_url":"https://api.github.com/repos/odyth/UICollectionView-Spring-Demo/stargazers","contributors_url":"https://api.github.com/repos/odyth/UICollectionView-Spring-Demo/contributors","subscribers_url":"https://api.github.com/repos/odyth/UICollectionView-Spring-Demo/subscribers","subscription_url":"https://api.github.com/repos/odyth/UICollectionView-Spring-Demo/subscription","commits_url":"https://api.github.com/repos/odyth/UICollectionView-Spring-Demo/commits{/sha}","git_commits_url":"https://api.github.com/repos/odyth/UICollectionView-Spring-Demo/git/commits{/sha}","comments_url":"https://api.github.com/repos/odyth/UICollectionView-Spring-Demo/comments{/number}","issue_comment_url":"https://api.github.com/repos/odyth/UICollectionView-Spring-Demo/issues/comments/{number}","contents_url":"https://api.github.com/repos/odyth/UICollectionView-Spring-Demo/contents/{+path}","compare_url":"https://api.github.com/repos/odyth/UICollectionView-Spring-Demo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/odyth/UICollectionView-Spring-Demo/merges","archive_url":"https://api.github.com/repos/odyth/UICollectionView-Spring-Demo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/odyth/UICollectionView-Spring-Demo/downloads","issues_url":"https://api.github.com/repos/odyth/UICollectionView-Spring-Demo/issues{/number}","pulls_url":"https://api.github.com/repos/odyth/UICollectionView-Spring-Demo/pulls{/number}","milestones_url":"https://api.github.com/repos/odyth/UICollectionView-Spring-Demo/milestones{/number}","notifications_url":"https://api.github.com/repos/odyth/UICollectionView-Spring-Demo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/odyth/UICollectionView-Spring-Demo/labels{/name}","releases_url":"https://api.github.com/repos/odyth/UICollectionView-Spring-Demo/releases{/id}","created_at":"2014-02-14T09:50:48Z","updated_at":"2014-02-14T14:17:53Z","pushed_at":"2014-02-14T09:52:26Z","git_url":"git://github.com/odyth/UICollectionView-Spring-Demo.git","ssh_url":"git@github.com:odyth/UICollectionView-Spring-Demo.git","clone_url":"https://github.com/odyth/UICollectionView-Spring-Demo.git","svn_url":"https://github.com/odyth/UICollectionView-Spring-Demo","homepage":null,"size":168,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"TeehanLax:master","ref":"master","sha":"8ca3a6e7c5ec21623a19da5180b2551702c94c90","user":{"login":"TeehanLax","id":721218,"avatar_url":"https://gravatar.com/avatar/3d72641e04efd782cf8b5274d0dc5572?d=https%3A%2F%2Fidenticons.github.com%2F9da6695ac660014a49e424f50c51b6b5.png&r=x","gravatar_id":"3d72641e04efd782cf8b5274d0dc5572","url":"https://api.github.com/users/TeehanLax","html_url":"https://github.com/TeehanLax","followers_url":"https://api.github.com/users/TeehanLax/followers","following_url":"https://api.github.com/users/TeehanLax/following{/other_user}","gists_url":"https://api.github.com/users/TeehanLax/gists{/gist_id}","starred_url":"https://api.github.com/users/TeehanLax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TeehanLax/subscriptions","organizations_url":"https://api.github.com/users/TeehanLax/orgs","repos_url":"https://api.github.com/users/TeehanLax/repos","events_url":"https://api.github.com/users/TeehanLax/events{/privacy}","received_events_url":"https://api.github.com/users/TeehanLax/received_events","type":"Organization","site_admin":false},"repo":{"id":11983669,"name":"UICollectionView-Spring-Demo","full_name":"TeehanLax/UICollectionView-Spring-Demo","owner":{"login":"TeehanLax","id":721218,"avatar_url":"https://gravatar.com/avatar/3d72641e04efd782cf8b5274d0dc5572?d=https%3A%2F%2Fidenticons.github.com%2F9da6695ac660014a49e424f50c51b6b5.png&r=x","gravatar_id":"3d72641e04efd782cf8b5274d0dc5572","url":"https://api.github.com/users/TeehanLax","html_url":"https://github.com/TeehanLax","followers_url":"https://api.github.com/users/TeehanLax/followers","following_url":"https://api.github.com/users/TeehanLax/following{/other_user}","gists_url":"https://api.github.com/users/TeehanLax/gists{/gist_id}","starred_url":"https://api.github.com/users/TeehanLax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TeehanLax/subscriptions","organizations_url":"https://api.github.com/users/TeehanLax/orgs","repos_url":"https://api.github.com/users/TeehanLax/repos","events_url":"https://api.github.com/users/TeehanLax/events{/privacy}","received_events_url":"https://api.github.com/users/TeehanLax/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TeehanLax/UICollectionView-Spring-Demo","description":"A demonstration of UICollectionView and UIKit Dynamics","fork":false,"url":"https://api.github.com/repos/TeehanLax/UICollectionView-Spring-Demo","forks_url":"https://api.github.com/repos/TeehanLax/UICollectionView-Spring-Demo/forks","keys_url":"https://api.github.com/repos/TeehanLax/UICollectionView-Spring-Demo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TeehanLax/UICollectionView-Spring-Demo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TeehanLax/UICollectionView-Spring-Demo/teams","hooks_url":"https://api.github.com/repos/TeehanLax/UICollectionView-Spring-Demo/hooks","issue_events_url":"https://api.github.com/repos/TeehanLax/UICollectionView-Spring-Demo/issues/events{/number}","events_url":"https://api.github.com/repos/TeehanLax/UICollectionView-Spring-Demo/events","assignees_url":"https://api.github.com/repos/TeehanLax/UICollectionView-Spring-Demo/assignees{/user}","branches_url":"https://api.github.com/repos/TeehanLax/UICollectionView-Spring-Demo/branches{/branch}","tags_url":"https://api.github.com/repos/TeehanLax/UICollectionView-Spring-Demo/tags","blobs_url":"https://api.github.com/repos/TeehanLax/UICollectionView-Spring-Demo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TeehanLax/UICollectionView-Spring-Demo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TeehanLax/UICollectionView-Spring-Demo/git/refs{/sha}","trees_url":"https://api.github.com/repos/TeehanLax/UICollectionView-Spring-Demo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TeehanLax/UICollectionView-Spring-Demo/statuses/{sha}","languages_url":"https://api.github.com/repos/TeehanLax/UICollectionView-Spring-Demo/languages","stargazers_url":"https://api.github.com/repos/TeehanLax/UICollectionView-Spring-Demo/stargazers","contributors_url":"https://api.github.com/repos/TeehanLax/UICollectionView-Spring-Demo/contributors","subscribers_url":"https://api.github.com/repos/TeehanLax/UICollectionView-Spring-Demo/subscribers","subscription_url":"https://api.github.com/repos/TeehanLax/UICollectionView-Spring-Demo/subscription","commits_url":"https://api.github.com/repos/TeehanLax/UICollectionView-Spring-Demo/commits{/sha}","git_commits_url":"https://api.github.com/repos/TeehanLax/UICollectionView-Spring-Demo/git/commits{/sha}","comments_url":"https://api.github.com/repos/TeehanLax/UICollectionView-Spring-Demo/comments{/number}","issue_comment_url":"https://api.github.com/repos/TeehanLax/UICollectionView-Spring-Demo/issues/comments/{number}","contents_url":"https://api.github.com/repos/TeehanLax/UICollectionView-Spring-Demo/contents/{+path}","compare_url":"https://api.github.com/repos/TeehanLax/UICollectionView-Spring-Demo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TeehanLax/UICollectionView-Spring-Demo/merges","archive_url":"https://api.github.com/repos/TeehanLax/UICollectionView-Spring-Demo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TeehanLax/UICollectionView-Spring-Demo/downloads","issues_url":"https://api.github.com/repos/TeehanLax/UICollectionView-Spring-Demo/issues{/number}","pulls_url":"https://api.github.com/repos/TeehanLax/UICollectionView-Spring-Demo/pulls{/number}","milestones_url":"https://api.github.com/repos/TeehanLax/UICollectionView-Spring-Demo/milestones{/number}","notifications_url":"https://api.github.com/repos/TeehanLax/UICollectionView-Spring-Demo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TeehanLax/UICollectionView-Spring-Demo/labels{/name}","releases_url":"https://api.github.com/repos/TeehanLax/UICollectionView-Spring-Demo/releases{/id}","created_at":"2013-08-08T18:43:06Z","updated_at":"2014-02-14T14:17:53Z","pushed_at":"2014-02-14T14:17:53Z","git_url":"git://github.com/TeehanLax/UICollectionView-Spring-Demo.git","ssh_url":"git@github.com:TeehanLax/UICollectionView-Spring-Demo.git","clone_url":"https://github.com/TeehanLax/UICollectionView-Spring-Demo.git","svn_url":"https://github.com/TeehanLax/UICollectionView-Spring-Demo","homepage":null,"size":168,"stargazers_count":91,"watchers_count":91,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":16,"mirror_url":null,"open_issues_count":2,"forks":16,"open_issues":2,"watchers":91,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TeehanLax/UICollectionView-Spring-Demo/pulls/9"},"html":{"href":"https://github.com/TeehanLax/UICollectionView-Spring-Demo/pull/9"},"issue":{"href":"https://api.github.com/repos/TeehanLax/UICollectionView-Spring-Demo/issues/9"},"comments":{"href":"https://api.github.com/repos/TeehanLax/UICollectionView-Spring-Demo/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/TeehanLax/UICollectionView-Spring-Demo/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/TeehanLax/UICollectionView-Spring-Demo/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/TeehanLax/UICollectionView-Spring-Demo/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/TeehanLax/UICollectionView-Spring-Demo/statuses/4d52b8dfb8852192ae3831f4d0f9e4d9d39ddd79"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"AshFurrow","id":498212,"avatar_url":"https://gravatar.com/avatar/0ebf471a3ae8df42a84f93a7efbbdbd0?d=https%3A%2F%2Fidenticons.github.com%2Fbe454dbb655695cab481cf277981b115.png&r=x","gravatar_id":"0ebf471a3ae8df42a84f93a7efbbdbd0","url":"https://api.github.com/users/AshFurrow","html_url":"https://github.com/AshFurrow","followers_url":"https://api.github.com/users/AshFurrow/followers","following_url":"https://api.github.com/users/AshFurrow/following{/other_user}","gists_url":"https://api.github.com/users/AshFurrow/gists{/gist_id}","starred_url":"https://api.github.com/users/AshFurrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AshFurrow/subscriptions","organizations_url":"https://api.github.com/users/AshFurrow/orgs","repos_url":"https://api.github.com/users/AshFurrow/repos","events_url":"https://api.github.com/users/AshFurrow/events{/privacy}","received_events_url":"https://api.github.com/users/AshFurrow/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":2,"additions":19,"deletions":5,"changed_files":1}}