GitHub PushEvent at 2014-12-12 17:33:32
Repository: phabricator
Actor: csilvers
Payload: {"shas":[["f5301e8e94965fdc912d75e2279b71c99e4c60dc","c34c009102e60d77975598e1f414f8a701c22d0b@chadsdomain.com","Move 'Query' in Maniphest Search to be above the fold\n\nSummary: (Needed a clean branch). Moves the field up and renames to Query\n\nTest Plan: Visit Maniphest Search, see new field, test a query\n\nReviewers: epriestley\n\nReviewed By: epriestley\n\nSubscribers: Korvin, epriestley\n\nDifferential Revision: https://secure.phabricator.com/D10971","Chad Little",true],["b718b429afc61796475cf537b7623c6c7b9c48ae","3abdeb20bbfaf7f3efaf2a217619f0ce681d08bb@phacility.com","Transactions - make quotes work for older transactions\n\nSummary: Fixes T6731. I don't really understand the intent behind the two view classes here, but to get this to work I need to pass yet more data to the lower-level class.\n\nTest Plan: Viewed a task with many comments. Clicked \"show older\". Quoted everything I could. Verified for each quote that it quoted correctly, inlcuding linking to the prior transaction.\n\nReviewers: epriestley\n\nReviewed By: epriestley\n\nSubscribers: Korvin, epriestley\n\nManiphest Tasks: T6731\n\nDifferential Revision: https://secure.phabricator.com/D10973","Bob Trahan",true],["a2126631f36b26e5dbcd884809fad5a45827ef44","3abdeb20bbfaf7f3efaf2a217619f0ce681d08bb@phacility.com","Maniphest - fix bug updating tasks with blocked relationships\n\nSummary: Ref T5604. Found this trying to open T5604 live. Basically this internal query needs the needSubscriberPHID set to true.\n\nTest Plan: doing it live\n\nReviewers: epriestley\n\nReviewed By: epriestley\n\nSubscribers: Korvin, epriestley\n\nManiphest Tasks: T5604\n\nDifferential Revision: https://secure.phabricator.com/D10975","Bob Trahan",true],["bc5598865f62d4ddd3be8521f07850238b967011","46f1a0bd5592a2f9244ca321b129902a06b53e03@epriestley.com","Fix a stray comma on File previews\n\nSummary:\nThere's a comma to the lower-left of my profile picture here:\n\n{F248962}\n\nThis is on a page like https://secure.phabricator.com/F248948\n\nWhat's happening is that some `render()` method is returning a valid result like `array($stuff, null)`. This is getting passed to JS as an array, which is implicitly `join()`'ing it into a string, adding a comma.\n\nInstead, make sure we render these to strings on the server side before shipping them to the client.\n\nTest Plan: No more comma on file previews.\n\nReviewers: btrahan\n\nReviewed By: btrahan\n\nSubscribers: epriestley\n\nDifferential Revision: https://secure.phabricator.com/D10974","epriestley",true],["dda8e64a3e311ddea6b48171fb600257e2d1f855","3abdeb20bbfaf7f3efaf2a217619f0ce681d08bb@phacility.com","Maniphest - load subscribers in getApplicationTransactionsObject\n\nSummary: Fixes T6734. This is a very generic fix, which basically attaches the subscribers if necessary. This seems like a good idea given there's some crazy generic code doing this sort of thing? This would end up being a new pattern for these types of objects that may be loaded by a general object query but then get some editor action against them.\n\nTest Plan: I can't actually reproduce this in my sandbox so I'll verify live again.\n\nReviewers: epriestley\n\nReviewed By: epriestley\n\nSubscribers: Korvin, epriestley\n\nManiphest Tasks: T6734\n\nDifferential Revision: https://secure.phabricator.com/D10976","Bob Trahan",true],["b8de0fef6a0a870debfc616bd2fef275661f8f5e","be5acd4cab620d494846b6383e5e26dbab0e82f4@khanacademy.org","Merge branch 'master' of github.com:facebook/phabricator","Craig Silverstein",true]],"size":6,"ref":"refs/heads/master","head":"b8de0fef6a0a870debfc616bd2fef275661f8f5e"}