GitHub PullRequestEvent at 2014-09-08 16:12:10
Repository: pioneer
Actor: impaktor
Payload: {"action":"opened","number":3168,"pull_request":{"url":"https://api.github.com/repos/pioneerspacesim/pioneer/pulls/3168","id":20899947,"html_url":"https://github.com/pioneerspacesim/pioneer/pull/3168","diff_url":"https://github.com/pioneerspacesim/pioneer/pull/3168.diff","patch_url":"https://github.com/pioneerspacesim/pioneer/pull/3168.patch","issue_url":"https://api.github.com/repos/pioneerspacesim/pioneer/issues/3168","number":3168,"state":"open","locked":false,"title":"Cargo body improvement","user":{"login":"impaktor","id":619390,"avatar_url":"https://avatars.githubusercontent.com/u/619390?v=2","gravatar_id":null,"url":"https://api.github.com/users/impaktor","html_url":"https://github.com/impaktor","followers_url":"https://api.github.com/users/impaktor/followers","following_url":"https://api.github.com/users/impaktor/following{/other_user}","gists_url":"https://api.github.com/users/impaktor/gists{/gist_id}","starred_url":"https://api.github.com/users/impaktor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/impaktor/subscriptions","organizations_url":"https://api.github.com/users/impaktor/orgs","repos_url":"https://api.github.com/users/impaktor/repos","events_url":"https://api.github.com/users/impaktor/events{/privacy}","received_events_url":"https://api.github.com/users/impaktor/received_events","type":"User","site_admin":false},"body":"Closes #1659. Implemented it as suggested by robn's comment in that issue. \r\n\r\n- cargo takes damage on collision unless with ship carrying cargo scoop.\r\n- cargo self destructs after some time (default 24 h).\r\n- cargo self destruct can be set or disabled from Lua.\r\n- since cargo is very light (1t) remove lower cap on collision damage.\r\n\r\nTo test the Lua API part:\r\n\r\n```lua\r\nh = import(\"Equipment\").cargo.hydrogen\r\nimport(\"Game\").player:SpawnCargo(h)    -- default self destruct 24 h\r\nimport(\"Game\").player:SpawnCargo(h,30) -- shorter self destruct, 30 s\r\nimport(\"Game\").player:SpawnCargo(h,0)  -- no selfdestruct\r\n```","created_at":"2014-09-08T16:12:09Z","updated_at":"2014-09-08T16:12:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pioneerspacesim/pioneer/pulls/3168/commits","review_comments_url":"https://api.github.com/repos/pioneerspacesim/pioneer/pulls/3168/comments","review_comment_url":"https://api.github.com/repos/pioneerspacesim/pioneer/pulls/comments/{number}","comments_url":"https://api.github.com/repos/pioneerspacesim/pioneer/issues/3168/comments","statuses_url":"https://api.github.com/repos/pioneerspacesim/pioneer/statuses/bdda6101e8fdb38f4d22d9f7c793043eba580e21","head":{"label":"impaktor:cargo_body_improvement","ref":"cargo_body_improvement","sha":"bdda6101e8fdb38f4d22d9f7c793043eba580e21","user":{"login":"impaktor","id":619390,"avatar_url":"https://avatars.githubusercontent.com/u/619390?v=2","gravatar_id":null,"url":"https://api.github.com/users/impaktor","html_url":"https://github.com/impaktor","followers_url":"https://api.github.com/users/impaktor/followers","following_url":"https://api.github.com/users/impaktor/following{/other_user}","gists_url":"https://api.github.com/users/impaktor/gists{/gist_id}","starred_url":"https://api.github.com/users/impaktor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/impaktor/subscriptions","organizations_url":"https://api.github.com/users/impaktor/orgs","repos_url":"https://api.github.com/users/impaktor/repos","events_url":"https://api.github.com/users/impaktor/events{/privacy}","received_events_url":"https://api.github.com/users/impaktor/received_events","type":"User","site_admin":false},"repo":{"id":15562687,"name":"pioneer","full_name":"impaktor/pioneer","owner":{"login":"impaktor","id":619390,"avatar_url":"https://avatars.githubusercontent.com/u/619390?v=2","gravatar_id":null,"url":"https://api.github.com/users/impaktor","html_url":"https://github.com/impaktor","followers_url":"https://api.github.com/users/impaktor/followers","following_url":"https://api.github.com/users/impaktor/following{/other_user}","gists_url":"https://api.github.com/users/impaktor/gists{/gist_id}","starred_url":"https://api.github.com/users/impaktor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/impaktor/subscriptions","organizations_url":"https://api.github.com/users/impaktor/orgs","repos_url":"https://api.github.com/users/impaktor/repos","events_url":"https://api.github.com/users/impaktor/events{/privacy}","received_events_url":"https://api.github.com/users/impaktor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/impaktor/pioneer","description":"A game of lonely space adventure","fork":true,"url":"https://api.github.com/repos/impaktor/pioneer","forks_url":"https://api.github.com/repos/impaktor/pioneer/forks","keys_url":"https://api.github.com/repos/impaktor/pioneer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/impaktor/pioneer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/impaktor/pioneer/teams","hooks_url":"https://api.github.com/repos/impaktor/pioneer/hooks","issue_events_url":"https://api.github.com/repos/impaktor/pioneer/issues/events{/number}","events_url":"https://api.github.com/repos/impaktor/pioneer/events","assignees_url":"https://api.github.com/repos/impaktor/pioneer/assignees{/user}","branches_url":"https://api.github.com/repos/impaktor/pioneer/branches{/branch}","tags_url":"https://api.github.com/repos/impaktor/pioneer/tags","blobs_url":"https://api.github.com/repos/impaktor/pioneer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/impaktor/pioneer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/impaktor/pioneer/git/refs{/sha}","trees_url":"https://api.github.com/repos/impaktor/pioneer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/impaktor/pioneer/statuses/{sha}","languages_url":"https://api.github.com/repos/impaktor/pioneer/languages","stargazers_url":"https://api.github.com/repos/impaktor/pioneer/stargazers","contributors_url":"https://api.github.com/repos/impaktor/pioneer/contributors","subscribers_url":"https://api.github.com/repos/impaktor/pioneer/subscribers","subscription_url":"https://api.github.com/repos/impaktor/pioneer/subscription","commits_url":"https://api.github.com/repos/impaktor/pioneer/commits{/sha}","git_commits_url":"https://api.github.com/repos/impaktor/pioneer/git/commits{/sha}","comments_url":"https://api.github.com/repos/impaktor/pioneer/comments{/number}","issue_comment_url":"https://api.github.com/repos/impaktor/pioneer/issues/comments/{number}","contents_url":"https://api.github.com/repos/impaktor/pioneer/contents/{+path}","compare_url":"https://api.github.com/repos/impaktor/pioneer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/impaktor/pioneer/merges","archive_url":"https://api.github.com/repos/impaktor/pioneer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/impaktor/pioneer/downloads","issues_url":"https://api.github.com/repos/impaktor/pioneer/issues{/number}","pulls_url":"https://api.github.com/repos/impaktor/pioneer/pulls{/number}","milestones_url":"https://api.github.com/repos/impaktor/pioneer/milestones{/number}","notifications_url":"https://api.github.com/repos/impaktor/pioneer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/impaktor/pioneer/labels{/name}","releases_url":"https://api.github.com/repos/impaktor/pioneer/releases{/id}","created_at":"2014-01-01T09:53:20Z","updated_at":"2014-06-26T10:57:57Z","pushed_at":"2014-09-08T16:07:45Z","git_url":"git://github.com/impaktor/pioneer.git","ssh_url":"git@github.com:impaktor/pioneer.git","clone_url":"https://github.com/impaktor/pioneer.git","svn_url":"https://github.com/impaktor/pioneer","homepage":"http://pioneerspacesim.net/","size":740406,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pioneerspacesim:master","ref":"master","sha":"a6897e2dfa06befd32e3a2ebc2d77fa3c87a52e6","user":{"login":"pioneerspacesim","id":719820,"avatar_url":"https://avatars.githubusercontent.com/u/719820?v=2","gravatar_id":"0e33109a8fba33cbf66e04a5f63428c3","url":"https://api.github.com/users/pioneerspacesim","html_url":"https://github.com/pioneerspacesim","followers_url":"https://api.github.com/users/pioneerspacesim/followers","following_url":"https://api.github.com/users/pioneerspacesim/following{/other_user}","gists_url":"https://api.github.com/users/pioneerspacesim/gists{/gist_id}","starred_url":"https://api.github.com/users/pioneerspacesim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pioneerspacesim/subscriptions","organizations_url":"https://api.github.com/users/pioneerspacesim/orgs","repos_url":"https://api.github.com/users/pioneerspacesim/repos","events_url":"https://api.github.com/users/pioneerspacesim/events{/privacy}","received_events_url":"https://api.github.com/users/pioneerspacesim/received_events","type":"Organization","site_admin":false},"repo":{"id":1593053,"name":"pioneer","full_name":"pioneerspacesim/pioneer","owner":{"login":"pioneerspacesim","id":719820,"avatar_url":"https://avatars.githubusercontent.com/u/719820?v=2","gravatar_id":"0e33109a8fba33cbf66e04a5f63428c3","url":"https://api.github.com/users/pioneerspacesim","html_url":"https://github.com/pioneerspacesim","followers_url":"https://api.github.com/users/pioneerspacesim/followers","following_url":"https://api.github.com/users/pioneerspacesim/following{/other_user}","gists_url":"https://api.github.com/users/pioneerspacesim/gists{/gist_id}","starred_url":"https://api.github.com/users/pioneerspacesim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pioneerspacesim/subscriptions","organizations_url":"https://api.github.com/users/pioneerspacesim/orgs","repos_url":"https://api.github.com/users/pioneerspacesim/repos","events_url":"https://api.github.com/users/pioneerspacesim/events{/privacy}","received_events_url":"https://api.github.com/users/pioneerspacesim/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pioneerspacesim/pioneer","description":"A game of lonely space adventure","fork":false,"url":"https://api.github.com/repos/pioneerspacesim/pioneer","forks_url":"https://api.github.com/repos/pioneerspacesim/pioneer/forks","keys_url":"https://api.github.com/repos/pioneerspacesim/pioneer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pioneerspacesim/pioneer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pioneerspacesim/pioneer/teams","hooks_url":"https://api.github.com/repos/pioneerspacesim/pioneer/hooks","issue_events_url":"https://api.github.com/repos/pioneerspacesim/pioneer/issues/events{/number}","events_url":"https://api.github.com/repos/pioneerspacesim/pioneer/events","assignees_url":"https://api.github.com/repos/pioneerspacesim/pioneer/assignees{/user}","branches_url":"https://api.github.com/repos/pioneerspacesim/pioneer/branches{/branch}","tags_url":"https://api.github.com/repos/pioneerspacesim/pioneer/tags","blobs_url":"https://api.github.com/repos/pioneerspacesim/pioneer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pioneerspacesim/pioneer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pioneerspacesim/pioneer/git/refs{/sha}","trees_url":"https://api.github.com/repos/pioneerspacesim/pioneer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pioneerspacesim/pioneer/statuses/{sha}","languages_url":"https://api.github.com/repos/pioneerspacesim/pioneer/languages","stargazers_url":"https://api.github.com/repos/pioneerspacesim/pioneer/stargazers","contributors_url":"https://api.github.com/repos/pioneerspacesim/pioneer/contributors","subscribers_url":"https://api.github.com/repos/pioneerspacesim/pioneer/subscribers","subscription_url":"https://api.github.com/repos/pioneerspacesim/pioneer/subscription","commits_url":"https://api.github.com/repos/pioneerspacesim/pioneer/commits{/sha}","git_commits_url":"https://api.github.com/repos/pioneerspacesim/pioneer/git/commits{/sha}","comments_url":"https://api.github.com/repos/pioneerspacesim/pioneer/comments{/number}","issue_comment_url":"https://api.github.com/repos/pioneerspacesim/pioneer/issues/comments/{number}","contents_url":"https://api.github.com/repos/pioneerspacesim/pioneer/contents/{+path}","compare_url":"https://api.github.com/repos/pioneerspacesim/pioneer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pioneerspacesim/pioneer/merges","archive_url":"https://api.github.com/repos/pioneerspacesim/pioneer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pioneerspacesim/pioneer/downloads","issues_url":"https://api.github.com/repos/pioneerspacesim/pioneer/issues{/number}","pulls_url":"https://api.github.com/repos/pioneerspacesim/pioneer/pulls{/number}","milestones_url":"https://api.github.com/repos/pioneerspacesim/pioneer/milestones{/number}","notifications_url":"https://api.github.com/repos/pioneerspacesim/pioneer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pioneerspacesim/pioneer/labels{/name}","releases_url":"https://api.github.com/repos/pioneerspacesim/pioneer/releases{/id}","created_at":"2011-04-09T22:17:05Z","updated_at":"2014-09-05T22:26:18Z","pushed_at":"2014-09-08T11:18:55Z","git_url":"git://github.com/pioneerspacesim/pioneer.git","ssh_url":"git@github.com:pioneerspacesim/pioneer.git","clone_url":"https://github.com/pioneerspacesim/pioneer.git","svn_url":"https://github.com/pioneerspacesim/pioneer","homepage":"http://pioneerspacesim.net/","size":1446622,"stargazers_count":395,"watchers_count":395,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":170,"mirror_url":null,"open_issues_count":328,"forks":170,"open_issues":328,"watchers":395,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pioneerspacesim/pioneer/pulls/3168"},"html":{"href":"https://github.com/pioneerspacesim/pioneer/pull/3168"},"issue":{"href":"https://api.github.com/repos/pioneerspacesim/pioneer/issues/3168"},"comments":{"href":"https://api.github.com/repos/pioneerspacesim/pioneer/issues/3168/comments"},"review_comments":{"href":"https://api.github.com/repos/pioneerspacesim/pioneer/pulls/3168/comments"},"review_comment":{"href":"https://api.github.com/repos/pioneerspacesim/pioneer/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/pioneerspacesim/pioneer/pulls/3168/commits"},"statuses":{"href":"https://api.github.com/repos/pioneerspacesim/pioneer/statuses/bdda6101e8fdb38f4d22d9f7c793043eba580e21"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":4,"additions":64,"deletions":10,"changed_files":4}}