GitHub PullRequestReviewCommentEvent at 2014-06-30 21:07:47
Repository: candlepin
Actor: cakofony
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/candlepin/candlepin/pulls/comments/14375670","id":14375670,"diff_hunk":"@@ -52,7 +53,7 @@\n     @Size(max = 255)\n     protected String value;\n \n-    @ManyToOne\n+    @ManyToOne(fetch = FetchType.LAZY)","path":"src/main/java/org/candlepin/model/AbstractPoolAttribute.java","position":13,"original_position":13,"commit_id":"8771e6e926cfb92080fd26c1c21a059430daad96","original_commit_id":"8771e6e926cfb92080fd26c1c21a059430daad96","user":{"login":"cakofony","id":3854321,"avatar_url":"https://avatars.githubusercontent.com/u/3854321?","gravatar_id":"ab111ab05cd1e4f33434d9f76bb0c96d","url":"https://api.github.com/users/cakofony","html_url":"https://github.com/cakofony","followers_url":"https://api.github.com/users/cakofony/followers","following_url":"https://api.github.com/users/cakofony/following{/other_user}","gists_url":"https://api.github.com/users/cakofony/gists{/gist_id}","starred_url":"https://api.github.com/users/cakofony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cakofony/subscriptions","organizations_url":"https://api.github.com/users/cakofony/orgs","repos_url":"https://api.github.com/users/cakofony/repos","events_url":"https://api.github.com/users/cakofony/events{/privacy}","received_events_url":"https://api.github.com/users/cakofony/received_events","type":"User","site_admin":false},"body":"It is the default for collections, I believe.\r\n\r\nDefault is eager for ManyToOne and OneToOne.  It's defined in the declaration of those annotations.","created_at":"2014-06-30T21:07:47Z","updated_at":"2014-06-30T21:07:47Z","html_url":"https://github.com/candlepin/candlepin/pull/622#discussion_r14375670","pull_request_url":"https://api.github.com/repos/candlepin/candlepin/pulls/622","_links":{"self":{"href":"https://api.github.com/repos/candlepin/candlepin/pulls/comments/14375670"},"html":{"href":"https://github.com/candlepin/candlepin/pull/622#discussion_r14375670"},"pull_request":{"href":"https://api.github.com/repos/candlepin/candlepin/pulls/622"}}},"pull_request":{"url":"https://api.github.com/repos/candlepin/candlepin/pulls/622","id":17794071,"html_url":"https://github.com/candlepin/candlepin/pull/622","diff_url":"https://github.com/candlepin/candlepin/pull/622.diff","patch_url":"https://github.com/candlepin/candlepin/pull/622.patch","issue_url":"https://api.github.com/repos/candlepin/candlepin/issues/622","number":622,"state":"open","title":"Don't force one-to-ones on the child side to be loaded eagerly","user":{"login":"cakofony","id":3854321,"avatar_url":"https://avatars.githubusercontent.com/u/3854321?","gravatar_id":"ab111ab05cd1e4f33434d9f76bb0c96d","url":"https://api.github.com/users/cakofony","html_url":"https://github.com/cakofony","followers_url":"https://api.github.com/users/cakofony/followers","following_url":"https://api.github.com/users/cakofony/following{/other_user}","gists_url":"https://api.github.com/users/cakofony/gists{/gist_id}","starred_url":"https://api.github.com/users/cakofony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cakofony/subscriptions","organizations_url":"https://api.github.com/users/cakofony/orgs","repos_url":"https://api.github.com/users/cakofony/repos","events_url":"https://api.github.com/users/cakofony/events{/privacy}","received_events_url":"https://api.github.com/users/cakofony/received_events","type":"User","site_admin":false},"body":"Hibernate should be able to tell that it already has the object\r\nloaded (the parent).  I'm not sure why this doesn't apply\r\nwhen we run the query.\r\n\r\nTo verify, list available subscriptions on this branch as well as master.  Listing consumers is also much faster.","created_at":"2014-06-30T19:52:28Z","updated_at":"2014-06-30T21:07:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"40335d4b597443a7b3aeae7153bcf57e97a6505b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/candlepin/candlepin/pulls/622/commits","review_comments_url":"https://api.github.com/repos/candlepin/candlepin/pulls/622/comments","review_comment_url":"https://api.github.com/repos/candlepin/candlepin/pulls/comments/{number}","comments_url":"https://api.github.com/repos/candlepin/candlepin/issues/622/comments","statuses_url":"https://api.github.com/repos/candlepin/candlepin/statuses/8771e6e926cfb92080fd26c1c21a059430daad96","head":{"label":"candlepin:ckozak/loop_joins","ref":"ckozak/loop_joins","sha":"8771e6e926cfb92080fd26c1c21a059430daad96","user":{"login":"candlepin","id":1749632,"avatar_url":"https://avatars.githubusercontent.com/u/1749632?","gravatar_id":"8210547cb1a421e2100459c7690915c2","url":"https://api.github.com/users/candlepin","html_url":"https://github.com/candlepin","followers_url":"https://api.github.com/users/candlepin/followers","following_url":"https://api.github.com/users/candlepin/following{/other_user}","gists_url":"https://api.github.com/users/candlepin/gists{/gist_id}","starred_url":"https://api.github.com/users/candlepin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/candlepin/subscriptions","organizations_url":"https://api.github.com/users/candlepin/orgs","repos_url":"https://api.github.com/users/candlepin/repos","events_url":"https://api.github.com/users/candlepin/events{/privacy}","received_events_url":"https://api.github.com/users/candlepin/received_events","type":"Organization","site_admin":false},"repo":{"id":4586516,"name":"candlepin","full_name":"candlepin/candlepin","owner":{"login":"candlepin","id":1749632,"avatar_url":"https://avatars.githubusercontent.com/u/1749632?","gravatar_id":"8210547cb1a421e2100459c7690915c2","url":"https://api.github.com/users/candlepin","html_url":"https://github.com/candlepin","followers_url":"https://api.github.com/users/candlepin/followers","following_url":"https://api.github.com/users/candlepin/following{/other_user}","gists_url":"https://api.github.com/users/candlepin/gists{/gist_id}","starred_url":"https://api.github.com/users/candlepin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/candlepin/subscriptions","organizations_url":"https://api.github.com/users/candlepin/orgs","repos_url":"https://api.github.com/users/candlepin/repos","events_url":"https://api.github.com/users/candlepin/events{/privacy}","received_events_url":"https://api.github.com/users/candlepin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/candlepin/candlepin","description":"The Candlepin entitlement engine","fork":false,"url":"https://api.github.com/repos/candlepin/candlepin","forks_url":"https://api.github.com/repos/candlepin/candlepin/forks","keys_url":"https://api.github.com/repos/candlepin/candlepin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/candlepin/candlepin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/candlepin/candlepin/teams","hooks_url":"https://api.github.com/repos/candlepin/candlepin/hooks","issue_events_url":"https://api.github.com/repos/candlepin/candlepin/issues/events{/number}","events_url":"https://api.github.com/repos/candlepin/candlepin/events","assignees_url":"https://api.github.com/repos/candlepin/candlepin/assignees{/user}","branches_url":"https://api.github.com/repos/candlepin/candlepin/branches{/branch}","tags_url":"https://api.github.com/repos/candlepin/candlepin/tags","blobs_url":"https://api.github.com/repos/candlepin/candlepin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/candlepin/candlepin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/candlepin/candlepin/git/refs{/sha}","trees_url":"https://api.github.com/repos/candlepin/candlepin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/candlepin/candlepin/statuses/{sha}","languages_url":"https://api.github.com/repos/candlepin/candlepin/languages","stargazers_url":"https://api.github.com/repos/candlepin/candlepin/stargazers","contributors_url":"https://api.github.com/repos/candlepin/candlepin/contributors","subscribers_url":"https://api.github.com/repos/candlepin/candlepin/subscribers","subscription_url":"https://api.github.com/repos/candlepin/candlepin/subscription","commits_url":"https://api.github.com/repos/candlepin/candlepin/commits{/sha}","git_commits_url":"https://api.github.com/repos/candlepin/candlepin/git/commits{/sha}","comments_url":"https://api.github.com/repos/candlepin/candlepin/comments{/number}","issue_comment_url":"https://api.github.com/repos/candlepin/candlepin/issues/comments/{number}","contents_url":"https://api.github.com/repos/candlepin/candlepin/contents/{+path}","compare_url":"https://api.github.com/repos/candlepin/candlepin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/candlepin/candlepin/merges","archive_url":"https://api.github.com/repos/candlepin/candlepin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/candlepin/candlepin/downloads","issues_url":"https://api.github.com/repos/candlepin/candlepin/issues{/number}","pulls_url":"https://api.github.com/repos/candlepin/candlepin/pulls{/number}","milestones_url":"https://api.github.com/repos/candlepin/candlepin/milestones{/number}","notifications_url":"https://api.github.com/repos/candlepin/candlepin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/candlepin/candlepin/labels{/name}","releases_url":"https://api.github.com/repos/candlepin/candlepin/releases{/id}","created_at":"2012-06-07T14:58:35Z","updated_at":"2014-06-25T14:45:39Z","pushed_at":"2014-06-30T20:49:53Z","git_url":"git://github.com/candlepin/candlepin.git","ssh_url":"git@github.com:candlepin/candlepin.git","clone_url":"https://github.com/candlepin/candlepin.git","svn_url":"https://github.com/candlepin/candlepin","homepage":"http://candlepinproject.org","size":47495,"stargazers_count":17,"watchers_count":17,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":15,"mirror_url":null,"open_issues_count":1,"forks":15,"open_issues":1,"watchers":17,"default_branch":"master"}},"base":{"label":"candlepin:master","ref":"master","sha":"b5146deaeef26555d0bf794216996e1649348ac1","user":{"login":"candlepin","id":1749632,"avatar_url":"https://avatars.githubusercontent.com/u/1749632?","gravatar_id":"8210547cb1a421e2100459c7690915c2","url":"https://api.github.com/users/candlepin","html_url":"https://github.com/candlepin","followers_url":"https://api.github.com/users/candlepin/followers","following_url":"https://api.github.com/users/candlepin/following{/other_user}","gists_url":"https://api.github.com/users/candlepin/gists{/gist_id}","starred_url":"https://api.github.com/users/candlepin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/candlepin/subscriptions","organizations_url":"https://api.github.com/users/candlepin/orgs","repos_url":"https://api.github.com/users/candlepin/repos","events_url":"https://api.github.com/users/candlepin/events{/privacy}","received_events_url":"https://api.github.com/users/candlepin/received_events","type":"Organization","site_admin":false},"repo":{"id":4586516,"name":"candlepin","full_name":"candlepin/candlepin","owner":{"login":"candlepin","id":1749632,"avatar_url":"https://avatars.githubusercontent.com/u/1749632?","gravatar_id":"8210547cb1a421e2100459c7690915c2","url":"https://api.github.com/users/candlepin","html_url":"https://github.com/candlepin","followers_url":"https://api.github.com/users/candlepin/followers","following_url":"https://api.github.com/users/candlepin/following{/other_user}","gists_url":"https://api.github.com/users/candlepin/gists{/gist_id}","starred_url":"https://api.github.com/users/candlepin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/candlepin/subscriptions","organizations_url":"https://api.github.com/users/candlepin/orgs","repos_url":"https://api.github.com/users/candlepin/repos","events_url":"https://api.github.com/users/candlepin/events{/privacy}","received_events_url":"https://api.github.com/users/candlepin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/candlepin/candlepin","description":"The Candlepin entitlement engine","fork":false,"url":"https://api.github.com/repos/candlepin/candlepin","forks_url":"https://api.github.com/repos/candlepin/candlepin/forks","keys_url":"https://api.github.com/repos/candlepin/candlepin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/candlepin/candlepin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/candlepin/candlepin/teams","hooks_url":"https://api.github.com/repos/candlepin/candlepin/hooks","issue_events_url":"https://api.github.com/repos/candlepin/candlepin/issues/events{/number}","events_url":"https://api.github.com/repos/candlepin/candlepin/events","assignees_url":"https://api.github.com/repos/candlepin/candlepin/assignees{/user}","branches_url":"https://api.github.com/repos/candlepin/candlepin/branches{/branch}","tags_url":"https://api.github.com/repos/candlepin/candlepin/tags","blobs_url":"https://api.github.com/repos/candlepin/candlepin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/candlepin/candlepin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/candlepin/candlepin/git/refs{/sha}","trees_url":"https://api.github.com/repos/candlepin/candlepin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/candlepin/candlepin/statuses/{sha}","languages_url":"https://api.github.com/repos/candlepin/candlepin/languages","stargazers_url":"https://api.github.com/repos/candlepin/candlepin/stargazers","contributors_url":"https://api.github.com/repos/candlepin/candlepin/contributors","subscribers_url":"https://api.github.com/repos/candlepin/candlepin/subscribers","subscription_url":"https://api.github.com/repos/candlepin/candlepin/subscription","commits_url":"https://api.github.com/repos/candlepin/candlepin/commits{/sha}","git_commits_url":"https://api.github.com/repos/candlepin/candlepin/git/commits{/sha}","comments_url":"https://api.github.com/repos/candlepin/candlepin/comments{/number}","issue_comment_url":"https://api.github.com/repos/candlepin/candlepin/issues/comments/{number}","contents_url":"https://api.github.com/repos/candlepin/candlepin/contents/{+path}","compare_url":"https://api.github.com/repos/candlepin/candlepin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/candlepin/candlepin/merges","archive_url":"https://api.github.com/repos/candlepin/candlepin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/candlepin/candlepin/downloads","issues_url":"https://api.github.com/repos/candlepin/candlepin/issues{/number}","pulls_url":"https://api.github.com/repos/candlepin/candlepin/pulls{/number}","milestones_url":"https://api.github.com/repos/candlepin/candlepin/milestones{/number}","notifications_url":"https://api.github.com/repos/candlepin/candlepin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/candlepin/candlepin/labels{/name}","releases_url":"https://api.github.com/repos/candlepin/candlepin/releases{/id}","created_at":"2012-06-07T14:58:35Z","updated_at":"2014-06-25T14:45:39Z","pushed_at":"2014-06-30T20:49:53Z","git_url":"git://github.com/candlepin/candlepin.git","ssh_url":"git@github.com:candlepin/candlepin.git","clone_url":"https://github.com/candlepin/candlepin.git","svn_url":"https://github.com/candlepin/candlepin","homepage":"http://candlepinproject.org","size":47495,"stargazers_count":17,"watchers_count":17,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":15,"mirror_url":null,"open_issues_count":1,"forks":15,"open_issues":1,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/candlepin/candlepin/pulls/622"},"html":{"href":"https://github.com/candlepin/candlepin/pull/622"},"issue":{"href":"https://api.github.com/repos/candlepin/candlepin/issues/622"},"comments":{"href":"https://api.github.com/repos/candlepin/candlepin/issues/622/comments"},"review_comments":{"href":"https://api.github.com/repos/candlepin/candlepin/pulls/622/comments"},"review_comment":{"href":"https://api.github.com/repos/candlepin/candlepin/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/candlepin/candlepin/pulls/622/commits"},"statuses":{"href":"https://api.github.com/repos/candlepin/candlepin/statuses/8771e6e926cfb92080fd26c1c21a059430daad96"}}}}