GitHub PullRequestReviewCommentEvent at 2014-08-05 13:55:06
Repository: craigstr
Actor: halogenandtoast
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/reshleman/craigstr/pulls/comments/15812984","id":15812984,"diff_hunk":"@@ -0,0 +1,3 @@\n+class Location < ActiveRecord::Base\n+  validates :name, presence: true, null: false","path":"app/models/location.rb","position":2,"original_position":2,"commit_id":"e85dda6c2d46d8be87203e61007f5d78acb8a616","original_commit_id":"e85dda6c2d46d8be87203e61007f5d78acb8a616","user":{"login":"halogenandtoast","id":201288,"avatar_url":"https://avatars.githubusercontent.com/u/201288?v=2","gravatar_id":"b066cb3c505933f832faa83238489a89","url":"https://api.github.com/users/halogenandtoast","html_url":"https://github.com/halogenandtoast","followers_url":"https://api.github.com/users/halogenandtoast/followers","following_url":"https://api.github.com/users/halogenandtoast/following{/other_user}","gists_url":"https://api.github.com/users/halogenandtoast/gists{/gist_id}","starred_url":"https://api.github.com/users/halogenandtoast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halogenandtoast/subscriptions","organizations_url":"https://api.github.com/users/halogenandtoast/orgs","repos_url":"https://api.github.com/users/halogenandtoast/repos","events_url":"https://api.github.com/users/halogenandtoast/events{/privacy}","received_events_url":"https://api.github.com/users/halogenandtoast/received_events","type":"User","site_admin":false},"body":"`null: false` ?","created_at":"2014-08-05T13:55:06Z","updated_at":"2014-08-05T13:55:06Z","html_url":"https://github.com/reshleman/craigstr/pull/3#discussion_r15812984","pull_request_url":"https://api.github.com/repos/reshleman/craigstr/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/reshleman/craigstr/pulls/comments/15812984"},"html":{"href":"https://github.com/reshleman/craigstr/pull/3#discussion_r15812984"},"pull_request":{"href":"https://api.github.com/repos/reshleman/craigstr/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/reshleman/craigstr/pulls/3","id":19317723,"html_url":"https://github.com/reshleman/craigstr/pull/3","diff_url":"https://github.com/reshleman/craigstr/pull/3.diff","patch_url":"https://github.com/reshleman/craigstr/pull/3.patch","issue_url":"https://api.github.com/repos/reshleman/craigstr/issues/3","number":3,"state":"open","title":"Admins can add geographic regions (\"locations\")","user":{"login":"reshleman","id":7756801,"avatar_url":"https://avatars.githubusercontent.com/u/7756801?v=2","gravatar_id":"b8588f0798a1634c6df33f91da1fd928","url":"https://api.github.com/users/reshleman","html_url":"https://github.com/reshleman","followers_url":"https://api.github.com/users/reshleman/followers","following_url":"https://api.github.com/users/reshleman/following{/other_user}","gists_url":"https://api.github.com/users/reshleman/gists{/gist_id}","starred_url":"https://api.github.com/users/reshleman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reshleman/subscriptions","organizations_url":"https://api.github.com/users/reshleman/orgs","repos_url":"https://api.github.com/users/reshleman/repos","events_url":"https://api.github.com/users/reshleman/events{/privacy}","received_events_url":"https://api.github.com/users/reshleman/received_events","type":"User","site_admin":false},"body":"Many of these changes are background work related to validating a user's admin status, plus the actual changes for adding locations.\r\n\r\nHere's the overview:\r\n\r\n* Create model and migration for locations\r\n* Add route, controller, view, and partial for displaying a list of all locations (Locations#index)\r\n* Create an AdminController which by default checks that a user is an admin\r\n* Add namespaced routes and Admin::LocationsController to handle #new and #create actions (this controller inherits from AdminController, so only admin users can access it)\r\n* Add admin/locations#new view\r\n* Add links to the application layout for \"Home\" and \"Sign Out\"\r\n\r\nhttps://trello.com/c/JdYZB41D\r\n\r\nIf anyone has questions about what the admin-related code is doing, comment on the lines that are unclear, or let me know tomorrow and I'll do my best to explain. The [Rails Guides](http://guides.rubyonrails.org/routing.html#controller-namespaces-and-routing) have a short explanation of namespaced routing as well.","created_at":"2014-08-05T01:17:57Z","updated_at":"2014-08-05T13:55:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2c243df39797788948f0c0ed695d6e2f410ce7e2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/reshleman/craigstr/pulls/3/commits","review_comments_url":"https://api.github.com/repos/reshleman/craigstr/pulls/3/comments","review_comment_url":"https://api.github.com/repos/reshleman/craigstr/pulls/comments/{number}","comments_url":"https://api.github.com/repos/reshleman/craigstr/issues/3/comments","statuses_url":"https://api.github.com/repos/reshleman/craigstr/statuses/e85dda6c2d46d8be87203e61007f5d78acb8a616","head":{"label":"reshleman:re-locations","ref":"re-locations","sha":"e85dda6c2d46d8be87203e61007f5d78acb8a616","user":{"login":"reshleman","id":7756801,"avatar_url":"https://avatars.githubusercontent.com/u/7756801?v=2","gravatar_id":"b8588f0798a1634c6df33f91da1fd928","url":"https://api.github.com/users/reshleman","html_url":"https://github.com/reshleman","followers_url":"https://api.github.com/users/reshleman/followers","following_url":"https://api.github.com/users/reshleman/following{/other_user}","gists_url":"https://api.github.com/users/reshleman/gists{/gist_id}","starred_url":"https://api.github.com/users/reshleman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reshleman/subscriptions","organizations_url":"https://api.github.com/users/reshleman/orgs","repos_url":"https://api.github.com/users/reshleman/repos","events_url":"https://api.github.com/users/reshleman/events{/privacy}","received_events_url":"https://api.github.com/users/reshleman/received_events","type":"User","site_admin":false},"repo":{"id":22606808,"name":"craigstr","full_name":"reshleman/craigstr","owner":{"login":"reshleman","id":7756801,"avatar_url":"https://avatars.githubusercontent.com/u/7756801?v=2","gravatar_id":"b8588f0798a1634c6df33f91da1fd928","url":"https://api.github.com/users/reshleman","html_url":"https://github.com/reshleman","followers_url":"https://api.github.com/users/reshleman/followers","following_url":"https://api.github.com/users/reshleman/following{/other_user}","gists_url":"https://api.github.com/users/reshleman/gists{/gist_id}","starred_url":"https://api.github.com/users/reshleman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reshleman/subscriptions","organizations_url":"https://api.github.com/users/reshleman/orgs","repos_url":"https://api.github.com/users/reshleman/repos","events_url":"https://api.github.com/users/reshleman/events{/privacy}","received_events_url":"https://api.github.com/users/reshleman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/reshleman/craigstr","description":"A Craigslist clone, written for Metis. Team: @ikalu, @wowenstine & @twentee7","fork":false,"url":"https://api.github.com/repos/reshleman/craigstr","forks_url":"https://api.github.com/repos/reshleman/craigstr/forks","keys_url":"https://api.github.com/repos/reshleman/craigstr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reshleman/craigstr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reshleman/craigstr/teams","hooks_url":"https://api.github.com/repos/reshleman/craigstr/hooks","issue_events_url":"https://api.github.com/repos/reshleman/craigstr/issues/events{/number}","events_url":"https://api.github.com/repos/reshleman/craigstr/events","assignees_url":"https://api.github.com/repos/reshleman/craigstr/assignees{/user}","branches_url":"https://api.github.com/repos/reshleman/craigstr/branches{/branch}","tags_url":"https://api.github.com/repos/reshleman/craigstr/tags","blobs_url":"https://api.github.com/repos/reshleman/craigstr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reshleman/craigstr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reshleman/craigstr/git/refs{/sha}","trees_url":"https://api.github.com/repos/reshleman/craigstr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reshleman/craigstr/statuses/{sha}","languages_url":"https://api.github.com/repos/reshleman/craigstr/languages","stargazers_url":"https://api.github.com/repos/reshleman/craigstr/stargazers","contributors_url":"https://api.github.com/repos/reshleman/craigstr/contributors","subscribers_url":"https://api.github.com/repos/reshleman/craigstr/subscribers","subscription_url":"https://api.github.com/repos/reshleman/craigstr/subscription","commits_url":"https://api.github.com/repos/reshleman/craigstr/commits{/sha}","git_commits_url":"https://api.github.com/repos/reshleman/craigstr/git/commits{/sha}","comments_url":"https://api.github.com/repos/reshleman/craigstr/comments{/number}","issue_comment_url":"https://api.github.com/repos/reshleman/craigstr/issues/comments/{number}","contents_url":"https://api.github.com/repos/reshleman/craigstr/contents/{+path}","compare_url":"https://api.github.com/repos/reshleman/craigstr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reshleman/craigstr/merges","archive_url":"https://api.github.com/repos/reshleman/craigstr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reshleman/craigstr/downloads","issues_url":"https://api.github.com/repos/reshleman/craigstr/issues{/number}","pulls_url":"https://api.github.com/repos/reshleman/craigstr/pulls{/number}","milestones_url":"https://api.github.com/repos/reshleman/craigstr/milestones{/number}","notifications_url":"https://api.github.com/repos/reshleman/craigstr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reshleman/craigstr/labels{/name}","releases_url":"https://api.github.com/repos/reshleman/craigstr/releases{/id}","created_at":"2014-08-04T14:18:23Z","updated_at":"2014-08-05T01:22:38Z","pushed_at":"2014-08-05T01:00:14Z","git_url":"git://github.com/reshleman/craigstr.git","ssh_url":"git@github.com:reshleman/craigstr.git","clone_url":"https://github.com/reshleman/craigstr.git","svn_url":"https://github.com/reshleman/craigstr","homepage":"","size":0,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"reshleman:master","ref":"master","sha":"6080850d801afbf19a59c9c7a1c3396e05b446e0","user":{"login":"reshleman","id":7756801,"avatar_url":"https://avatars.githubusercontent.com/u/7756801?v=2","gravatar_id":"b8588f0798a1634c6df33f91da1fd928","url":"https://api.github.com/users/reshleman","html_url":"https://github.com/reshleman","followers_url":"https://api.github.com/users/reshleman/followers","following_url":"https://api.github.com/users/reshleman/following{/other_user}","gists_url":"https://api.github.com/users/reshleman/gists{/gist_id}","starred_url":"https://api.github.com/users/reshleman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reshleman/subscriptions","organizations_url":"https://api.github.com/users/reshleman/orgs","repos_url":"https://api.github.com/users/reshleman/repos","events_url":"https://api.github.com/users/reshleman/events{/privacy}","received_events_url":"https://api.github.com/users/reshleman/received_events","type":"User","site_admin":false},"repo":{"id":22606808,"name":"craigstr","full_name":"reshleman/craigstr","owner":{"login":"reshleman","id":7756801,"avatar_url":"https://avatars.githubusercontent.com/u/7756801?v=2","gravatar_id":"b8588f0798a1634c6df33f91da1fd928","url":"https://api.github.com/users/reshleman","html_url":"https://github.com/reshleman","followers_url":"https://api.github.com/users/reshleman/followers","following_url":"https://api.github.com/users/reshleman/following{/other_user}","gists_url":"https://api.github.com/users/reshleman/gists{/gist_id}","starred_url":"https://api.github.com/users/reshleman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reshleman/subscriptions","organizations_url":"https://api.github.com/users/reshleman/orgs","repos_url":"https://api.github.com/users/reshleman/repos","events_url":"https://api.github.com/users/reshleman/events{/privacy}","received_events_url":"https://api.github.com/users/reshleman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/reshleman/craigstr","description":"A Craigslist clone, written for Metis. Team: @ikalu, @wowenstine & @twentee7","fork":false,"url":"https://api.github.com/repos/reshleman/craigstr","forks_url":"https://api.github.com/repos/reshleman/craigstr/forks","keys_url":"https://api.github.com/repos/reshleman/craigstr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reshleman/craigstr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reshleman/craigstr/teams","hooks_url":"https://api.github.com/repos/reshleman/craigstr/hooks","issue_events_url":"https://api.github.com/repos/reshleman/craigstr/issues/events{/number}","events_url":"https://api.github.com/repos/reshleman/craigstr/events","assignees_url":"https://api.github.com/repos/reshleman/craigstr/assignees{/user}","branches_url":"https://api.github.com/repos/reshleman/craigstr/branches{/branch}","tags_url":"https://api.github.com/repos/reshleman/craigstr/tags","blobs_url":"https://api.github.com/repos/reshleman/craigstr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reshleman/craigstr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reshleman/craigstr/git/refs{/sha}","trees_url":"https://api.github.com/repos/reshleman/craigstr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reshleman/craigstr/statuses/{sha}","languages_url":"https://api.github.com/repos/reshleman/craigstr/languages","stargazers_url":"https://api.github.com/repos/reshleman/craigstr/stargazers","contributors_url":"https://api.github.com/repos/reshleman/craigstr/contributors","subscribers_url":"https://api.github.com/repos/reshleman/craigstr/subscribers","subscription_url":"https://api.github.com/repos/reshleman/craigstr/subscription","commits_url":"https://api.github.com/repos/reshleman/craigstr/commits{/sha}","git_commits_url":"https://api.github.com/repos/reshleman/craigstr/git/commits{/sha}","comments_url":"https://api.github.com/repos/reshleman/craigstr/comments{/number}","issue_comment_url":"https://api.github.com/repos/reshleman/craigstr/issues/comments/{number}","contents_url":"https://api.github.com/repos/reshleman/craigstr/contents/{+path}","compare_url":"https://api.github.com/repos/reshleman/craigstr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reshleman/craigstr/merges","archive_url":"https://api.github.com/repos/reshleman/craigstr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reshleman/craigstr/downloads","issues_url":"https://api.github.com/repos/reshleman/craigstr/issues{/number}","pulls_url":"https://api.github.com/repos/reshleman/craigstr/pulls{/number}","milestones_url":"https://api.github.com/repos/reshleman/craigstr/milestones{/number}","notifications_url":"https://api.github.com/repos/reshleman/craigstr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reshleman/craigstr/labels{/name}","releases_url":"https://api.github.com/repos/reshleman/craigstr/releases{/id}","created_at":"2014-08-04T14:18:23Z","updated_at":"2014-08-05T01:22:38Z","pushed_at":"2014-08-05T01:00:14Z","git_url":"git://github.com/reshleman/craigstr.git","ssh_url":"git@github.com:reshleman/craigstr.git","clone_url":"https://github.com/reshleman/craigstr.git","svn_url":"https://github.com/reshleman/craigstr","homepage":"","size":0,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/reshleman/craigstr/pulls/3"},"html":{"href":"https://github.com/reshleman/craigstr/pull/3"},"issue":{"href":"https://api.github.com/repos/reshleman/craigstr/issues/3"},"comments":{"href":"https://api.github.com/repos/reshleman/craigstr/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/reshleman/craigstr/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/reshleman/craigstr/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/reshleman/craigstr/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/reshleman/craigstr/statuses/e85dda6c2d46d8be87203e61007f5d78acb8a616"}}}}