GitHub PullRequestEvent at 2014-07-20 15:34:04
Repository: Sia
Actor: DavidVorick
Payload: {"action":"opened","number":175,"pull_request":{"url":"https://api.github.com/repos/NebulousLabs/Sia/pulls/175","id":18630631,"html_url":"https://github.com/NebulousLabs/Sia/pull/175","diff_url":"https://github.com/NebulousLabs/Sia/pull/175.diff","patch_url":"https://github.com/NebulousLabs/Sia/pull/175.patch","issue_url":"https://api.github.com/repos/NebulousLabs/Sia/issues/175","number":175,"state":"open","title":"Get single-participant bootstrapping working","user":{"login":"DavidVorick","id":2316841,"avatar_url":"https://avatars.githubusercontent.com/u/2316841?","gravatar_id":"a1b91895dc4907980e69a0c1c4f4c064","url":"https://api.github.com/users/DavidVorick","html_url":"https://github.com/DavidVorick","followers_url":"https://api.github.com/users/DavidVorick/followers","following_url":"https://api.github.com/users/DavidVorick/following{/other_user}","gists_url":"https://api.github.com/users/DavidVorick/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidVorick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidVorick/subscriptions","organizations_url":"https://api.github.com/users/DavidVorick/orgs","repos_url":"https://api.github.com/users/DavidVorick/repos","events_url":"https://api.github.com/users/DavidVorick/events{/privacy}","received_events_url":"https://api.github.com/users/DavidVorick/received_events","type":"User","site_admin":false},"body":"There are some pretty big changes. I changed the siacrypto functions to remove 'SignedMessage' as a struct. Instead you just get back a signature, and are expected to have the original message. When passing stuff around on the wire, the signature should always come first, followed by the message. I don't think it'll cause bugs if you don't do it this way, but best to be consistent with the nacl libraries.\r\n\r\nThe test suite is slightly more comprehensive than before.\r\n\r\nPort numbers have been more carefully assigned, they can still interfere with each other if there are errors (such as no internet connectivity).\r\n\r\nI haven't picked all the numbers, but the 9000's are reserved for actual use, the 10,000's are reserved for testing the network package, the 11,000's reserved for the consensus package. Each file should pick a range, so it doesn't step on the toes of the other files. I don't have a perfect solution for that, but the ranges should jump by 25 (25 ports should be enough for a whole file of testing, but if it's not it can just consume 2 ranges). This also gives a total of 40 testing files per package, which should also be enough. If it's not the testing package can get another range of 1000 ports. Current implementation gives files their own range of 100, but whatevs\r\n\r\nI think the most significant changes are to the bootstrapping process and the consensus process. The consensus process is more strict about what updates it considers (it's now secure), and the bootstrap process has been broken into a bunch of functions. The new format for bootstrapping is pretty messy, could use some polishing.\r\n\r\nI realized that I haven't implemented block hashing yet, which means the 'strict' new consensus algorithm is effectively not any more strict at all. But it will be once block hashing is implemented.","created_at":"2014-07-20T15:34:04Z","updated_at":"2014-07-20T15:34:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/NebulousLabs/Sia/pulls/175/commits","review_comments_url":"https://api.github.com/repos/NebulousLabs/Sia/pulls/175/comments","review_comment_url":"https://api.github.com/repos/NebulousLabs/Sia/pulls/comments/{number}","comments_url":"https://api.github.com/repos/NebulousLabs/Sia/issues/175/comments","statuses_url":"https://api.github.com/repos/NebulousLabs/Sia/statuses/5a8edd4804b5b12a5f46c6c116f5c958dd2330c6","head":{"label":"DavidVorick:review","ref":"review","sha":"5a8edd4804b5b12a5f46c6c116f5c958dd2330c6","user":{"login":"DavidVorick","id":2316841,"avatar_url":"https://avatars.githubusercontent.com/u/2316841?","gravatar_id":"a1b91895dc4907980e69a0c1c4f4c064","url":"https://api.github.com/users/DavidVorick","html_url":"https://github.com/DavidVorick","followers_url":"https://api.github.com/users/DavidVorick/followers","following_url":"https://api.github.com/users/DavidVorick/following{/other_user}","gists_url":"https://api.github.com/users/DavidVorick/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidVorick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidVorick/subscriptions","organizations_url":"https://api.github.com/users/DavidVorick/orgs","repos_url":"https://api.github.com/users/DavidVorick/repos","events_url":"https://api.github.com/users/DavidVorick/events{/privacy}","received_events_url":"https://api.github.com/users/DavidVorick/received_events","type":"User","site_admin":false},"repo":{"id":16572584,"name":"Sia","full_name":"DavidVorick/Sia","owner":{"login":"DavidVorick","id":2316841,"avatar_url":"https://avatars.githubusercontent.com/u/2316841?","gravatar_id":"a1b91895dc4907980e69a0c1c4f4c064","url":"https://api.github.com/users/DavidVorick","html_url":"https://github.com/DavidVorick","followers_url":"https://api.github.com/users/DavidVorick/followers","following_url":"https://api.github.com/users/DavidVorick/following{/other_user}","gists_url":"https://api.github.com/users/DavidVorick/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidVorick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidVorick/subscriptions","organizations_url":"https://api.github.com/users/DavidVorick/orgs","repos_url":"https://api.github.com/users/DavidVorick/repos","events_url":"https://api.github.com/users/DavidVorick/events{/privacy}","received_events_url":"https://api.github.com/users/DavidVorick/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DavidVorick/Sia","description":"Blocktree Based Market For Cloud Storage","fork":true,"url":"https://api.github.com/repos/DavidVorick/Sia","forks_url":"https://api.github.com/repos/DavidVorick/Sia/forks","keys_url":"https://api.github.com/repos/DavidVorick/Sia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DavidVorick/Sia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DavidVorick/Sia/teams","hooks_url":"https://api.github.com/repos/DavidVorick/Sia/hooks","issue_events_url":"https://api.github.com/repos/DavidVorick/Sia/issues/events{/number}","events_url":"https://api.github.com/repos/DavidVorick/Sia/events","assignees_url":"https://api.github.com/repos/DavidVorick/Sia/assignees{/user}","branches_url":"https://api.github.com/repos/DavidVorick/Sia/branches{/branch}","tags_url":"https://api.github.com/repos/DavidVorick/Sia/tags","blobs_url":"https://api.github.com/repos/DavidVorick/Sia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DavidVorick/Sia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DavidVorick/Sia/git/refs{/sha}","trees_url":"https://api.github.com/repos/DavidVorick/Sia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DavidVorick/Sia/statuses/{sha}","languages_url":"https://api.github.com/repos/DavidVorick/Sia/languages","stargazers_url":"https://api.github.com/repos/DavidVorick/Sia/stargazers","contributors_url":"https://api.github.com/repos/DavidVorick/Sia/contributors","subscribers_url":"https://api.github.com/repos/DavidVorick/Sia/subscribers","subscription_url":"https://api.github.com/repos/DavidVorick/Sia/subscription","commits_url":"https://api.github.com/repos/DavidVorick/Sia/commits{/sha}","git_commits_url":"https://api.github.com/repos/DavidVorick/Sia/git/commits{/sha}","comments_url":"https://api.github.com/repos/DavidVorick/Sia/comments{/number}","issue_comment_url":"https://api.github.com/repos/DavidVorick/Sia/issues/comments/{number}","contents_url":"https://api.github.com/repos/DavidVorick/Sia/contents/{+path}","compare_url":"https://api.github.com/repos/DavidVorick/Sia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DavidVorick/Sia/merges","archive_url":"https://api.github.com/repos/DavidVorick/Sia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DavidVorick/Sia/downloads","issues_url":"https://api.github.com/repos/DavidVorick/Sia/issues{/number}","pulls_url":"https://api.github.com/repos/DavidVorick/Sia/pulls{/number}","milestones_url":"https://api.github.com/repos/DavidVorick/Sia/milestones{/number}","notifications_url":"https://api.github.com/repos/DavidVorick/Sia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DavidVorick/Sia/labels{/name}","releases_url":"https://api.github.com/repos/DavidVorick/Sia/releases{/id}","created_at":"2014-02-06T08:07:47Z","updated_at":"2014-06-25T22:30:20Z","pushed_at":"2014-07-20T15:23:46Z","git_url":"git://github.com/DavidVorick/Sia.git","ssh_url":"git@github.com:DavidVorick/Sia.git","clone_url":"https://github.com/DavidVorick/Sia.git","svn_url":"https://github.com/DavidVorick/Sia","homepage":null,"size":8296,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"NebulousLabs:master","ref":"master","sha":"e39c6a043482fdb390804ae6049c8ad7e8585684","user":{"login":"NebulousLabs","id":7471422,"avatar_url":"https://avatars.githubusercontent.com/u/7471422?","gravatar_id":null,"url":"https://api.github.com/users/NebulousLabs","html_url":"https://github.com/NebulousLabs","followers_url":"https://api.github.com/users/NebulousLabs/followers","following_url":"https://api.github.com/users/NebulousLabs/following{/other_user}","gists_url":"https://api.github.com/users/NebulousLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/NebulousLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NebulousLabs/subscriptions","organizations_url":"https://api.github.com/users/NebulousLabs/orgs","repos_url":"https://api.github.com/users/NebulousLabs/repos","events_url":"https://api.github.com/users/NebulousLabs/events{/privacy}","received_events_url":"https://api.github.com/users/NebulousLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":16556844,"name":"Sia","full_name":"NebulousLabs/Sia","owner":{"login":"NebulousLabs","id":7471422,"avatar_url":"https://avatars.githubusercontent.com/u/7471422?","gravatar_id":null,"url":"https://api.github.com/users/NebulousLabs","html_url":"https://github.com/NebulousLabs","followers_url":"https://api.github.com/users/NebulousLabs/followers","following_url":"https://api.github.com/users/NebulousLabs/following{/other_user}","gists_url":"https://api.github.com/users/NebulousLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/NebulousLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NebulousLabs/subscriptions","organizations_url":"https://api.github.com/users/NebulousLabs/orgs","repos_url":"https://api.github.com/users/NebulousLabs/repos","events_url":"https://api.github.com/users/NebulousLabs/events{/privacy}","received_events_url":"https://api.github.com/users/NebulousLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NebulousLabs/Sia","description":"Blocktree Based Market For Cloud Storage","fork":false,"url":"https://api.github.com/repos/NebulousLabs/Sia","forks_url":"https://api.github.com/repos/NebulousLabs/Sia/forks","keys_url":"https://api.github.com/repos/NebulousLabs/Sia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NebulousLabs/Sia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NebulousLabs/Sia/teams","hooks_url":"https://api.github.com/repos/NebulousLabs/Sia/hooks","issue_events_url":"https://api.github.com/repos/NebulousLabs/Sia/issues/events{/number}","events_url":"https://api.github.com/repos/NebulousLabs/Sia/events","assignees_url":"https://api.github.com/repos/NebulousLabs/Sia/assignees{/user}","branches_url":"https://api.github.com/repos/NebulousLabs/Sia/branches{/branch}","tags_url":"https://api.github.com/repos/NebulousLabs/Sia/tags","blobs_url":"https://api.github.com/repos/NebulousLabs/Sia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NebulousLabs/Sia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NebulousLabs/Sia/git/refs{/sha}","trees_url":"https://api.github.com/repos/NebulousLabs/Sia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NebulousLabs/Sia/statuses/{sha}","languages_url":"https://api.github.com/repos/NebulousLabs/Sia/languages","stargazers_url":"https://api.github.com/repos/NebulousLabs/Sia/stargazers","contributors_url":"https://api.github.com/repos/NebulousLabs/Sia/contributors","subscribers_url":"https://api.github.com/repos/NebulousLabs/Sia/subscribers","subscription_url":"https://api.github.com/repos/NebulousLabs/Sia/subscription","commits_url":"https://api.github.com/repos/NebulousLabs/Sia/commits{/sha}","git_commits_url":"https://api.github.com/repos/NebulousLabs/Sia/git/commits{/sha}","comments_url":"https://api.github.com/repos/NebulousLabs/Sia/comments{/number}","issue_comment_url":"https://api.github.com/repos/NebulousLabs/Sia/issues/comments/{number}","contents_url":"https://api.github.com/repos/NebulousLabs/Sia/contents/{+path}","compare_url":"https://api.github.com/repos/NebulousLabs/Sia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NebulousLabs/Sia/merges","archive_url":"https://api.github.com/repos/NebulousLabs/Sia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NebulousLabs/Sia/downloads","issues_url":"https://api.github.com/repos/NebulousLabs/Sia/issues{/number}","pulls_url":"https://api.github.com/repos/NebulousLabs/Sia/pulls{/number}","milestones_url":"https://api.github.com/repos/NebulousLabs/Sia/milestones{/number}","notifications_url":"https://api.github.com/repos/NebulousLabs/Sia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NebulousLabs/Sia/labels{/name}","releases_url":"https://api.github.com/repos/NebulousLabs/Sia/releases{/id}","created_at":"2014-02-05T20:14:12Z","updated_at":"2014-07-17T18:46:38Z","pushed_at":"2014-07-17T04:11:52Z","git_url":"git://github.com/NebulousLabs/Sia.git","ssh_url":"git@github.com:NebulousLabs/Sia.git","clone_url":"https://github.com/NebulousLabs/Sia.git","svn_url":"https://github.com/NebulousLabs/Sia","homepage":null,"size":7002,"stargazers_count":36,"watchers_count":36,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":12,"mirror_url":null,"open_issues_count":7,"forks":12,"open_issues":7,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NebulousLabs/Sia/pulls/175"},"html":{"href":"https://github.com/NebulousLabs/Sia/pull/175"},"issue":{"href":"https://api.github.com/repos/NebulousLabs/Sia/issues/175"},"comments":{"href":"https://api.github.com/repos/NebulousLabs/Sia/issues/175/comments"},"review_comments":{"href":"https://api.github.com/repos/NebulousLabs/Sia/pulls/175/comments"},"review_comment":{"href":"https://api.github.com/repos/NebulousLabs/Sia/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/NebulousLabs/Sia/pulls/175/commits"},"statuses":{"href":"https://api.github.com/repos/NebulousLabs/Sia/statuses/5a8edd4804b5b12a5f46c6c116f5c958dd2330c6"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":23,"additions":823,"deletions":1620,"changed_files":48}}