GitHub PullRequestEvent at 2014-07-06 04:47:26
Repository: random-name
Actor: dtudury
Payload: {"action":"closed","number":2,"pull_request":{"url":"https://api.github.com/repos/dominictarr/random-name/pulls/2","id":18010809,"html_url":"https://github.com/dominictarr/random-name/pull/2","diff_url":"https://github.com/dominictarr/random-name/pull/2.diff","patch_url":"https://github.com/dominictarr/random-name/pull/2.patch","issue_url":"https://api.github.com/repos/dominictarr/random-name/issues/2","number":2,"state":"closed","title":"now with markov chains","user":{"login":"dtudury","id":878029,"avatar_url":"https://avatars.githubusercontent.com/u/878029?","gravatar_id":"e85cfb82c331e8e431bd0732e78975aa","url":"https://api.github.com/users/dtudury","html_url":"https://github.com/dtudury","followers_url":"https://api.github.com/users/dtudury/followers","following_url":"https://api.github.com/users/dtudury/following{/other_user}","gists_url":"https://api.github.com/users/dtudury/gists{/gist_id}","starred_url":"https://api.github.com/users/dtudury/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtudury/subscriptions","organizations_url":"https://api.github.com/users/dtudury/orgs","repos_url":"https://api.github.com/users/dtudury/repos","events_url":"https://api.github.com/users/dtudury/events{/privacy}","received_events_url":"https://api.github.com/users/dtudury/received_events","type":"User","site_admin":false},"body":"_at nodeconf and there's no one to play four-square with yet so I may as well submit this..._\r\n\r\n\r\n\r\nI couldn't avoid adding complexity so it ended up being a pretty deep change:\r\n* there's an optional argument for the name functions that will make it do a markov chain generation rather than random selection\r\n* if you don't pass the argument they behave the same\r\n* there's a person function that generates an object\r\n* the readme has been updated\r\n* there's a new test (it passes)\r\n* the data files are currently truncated to 500 for browser-friendliness (so far this seems like plenty)\r\n* the data files can be regenerated for non-browser use\r\n* data is from U.S. census (as it has statistical information and a structure that made it pretty easy to use)\r\n\r\nI wouldn't bother looking at the diff as everything changed... there still isn't that much code, but it's hidden amongst the data files\r\n\r\nsample markov-chain output from `random.person(true).toString())`:\r\n```\r\nMather Williotte from Los Angeles, California\r\nJam Jamiel Walds from Goodyear, Arizona\r\nThon Petevenr Fis from Albuquerque, New Mexico\r\nKarbarie Conne Lamstevers from Hollywood, Florida\r\nAntherrah Brown from Charlotte, North Carolina\r\nCouran Eline Martiz from Boston, Massachusetts\r\nRober Johnsey from Mesa, Arizona\r\nChrististis Brown from St. Louis, Missouri\r\nSandren Mill from Overland Park, Kansas\r\nMarildret Mice Hilton from Philadelphia, Pennsylvania\r\nKatrie Chri Johns from Washington, District of Columbia\r\nGared Mickie Byrds from Omaha, Nebraska\r\nAnna Cyn Ferez from Vallejo, California\r\nSaroth Cla Full from Hawthorne, California\r\nPatie Marolyn Johns from Wichita, Kansas\r\nWilliff Par from San Francisco, California\r\nBerairley Adrette Rey from Grand Rapids, Michigan\r\nHazela Ann Thomerson from Virginia Beach, Virginia\r\nCath Sha Priguez from Austin, Texas\r\nJorgert Cald Cohnson from Greensboro, North Carolina\r\nRan Wil Dixonzalerne from Phoenix, Arizona\r\nSha Mara Murphez from Oklahoma City, Oklahoma\r\nEverendra Marothel Evanchers from Jonesboro, Arkansas\r\nJames Johnalli Boy from Irvine, California\r\nEladysthae Theiditt Hown from Norwalk, Connecticut\r\nDamuel Michard Willero from Escondido, California\r\n```","created_at":"2014-07-05T14:49:45Z","updated_at":"2014-07-06T04:47:26Z","closed_at":"2014-07-06T04:47:26Z","merged_at":null,"merge_commit_sha":"560dc0cc7780de83f92d62204ff1df2fbe178241","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dominictarr/random-name/pulls/2/commits","review_comments_url":"https://api.github.com/repos/dominictarr/random-name/pulls/2/comments","review_comment_url":"https://api.github.com/repos/dominictarr/random-name/pulls/comments/{number}","comments_url":"https://api.github.com/repos/dominictarr/random-name/issues/2/comments","statuses_url":"https://api.github.com/repos/dominictarr/random-name/statuses/37c5874e9a160143c574d45a87c309b9c44eeb43","head":{"label":"dtudury:master","ref":"master","sha":"37c5874e9a160143c574d45a87c309b9c44eeb43","user":{"login":"dtudury","id":878029,"avatar_url":"https://avatars.githubusercontent.com/u/878029?","gravatar_id":"e85cfb82c331e8e431bd0732e78975aa","url":"https://api.github.com/users/dtudury","html_url":"https://github.com/dtudury","followers_url":"https://api.github.com/users/dtudury/followers","following_url":"https://api.github.com/users/dtudury/following{/other_user}","gists_url":"https://api.github.com/users/dtudury/gists{/gist_id}","starred_url":"https://api.github.com/users/dtudury/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtudury/subscriptions","organizations_url":"https://api.github.com/users/dtudury/orgs","repos_url":"https://api.github.com/users/dtudury/repos","events_url":"https://api.github.com/users/dtudury/events{/privacy}","received_events_url":"https://api.github.com/users/dtudury/received_events","type":"User","site_admin":false},"repo":{"id":20849009,"name":"random-person","full_name":"dtudury/random-person","owner":{"login":"dtudury","id":878029,"avatar_url":"https://avatars.githubusercontent.com/u/878029?","gravatar_id":"e85cfb82c331e8e431bd0732e78975aa","url":"https://api.github.com/users/dtudury","html_url":"https://github.com/dtudury","followers_url":"https://api.github.com/users/dtudury/followers","following_url":"https://api.github.com/users/dtudury/following{/other_user}","gists_url":"https://api.github.com/users/dtudury/gists{/gist_id}","starred_url":"https://api.github.com/users/dtudury/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtudury/subscriptions","organizations_url":"https://api.github.com/users/dtudury/orgs","repos_url":"https://api.github.com/users/dtudury/repos","events_url":"https://api.github.com/users/dtudury/events{/privacy}","received_events_url":"https://api.github.com/users/dtudury/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dtudury/random-person","description":null,"fork":true,"url":"https://api.github.com/repos/dtudury/random-person","forks_url":"https://api.github.com/repos/dtudury/random-person/forks","keys_url":"https://api.github.com/repos/dtudury/random-person/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dtudury/random-person/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dtudury/random-person/teams","hooks_url":"https://api.github.com/repos/dtudury/random-person/hooks","issue_events_url":"https://api.github.com/repos/dtudury/random-person/issues/events{/number}","events_url":"https://api.github.com/repos/dtudury/random-person/events","assignees_url":"https://api.github.com/repos/dtudury/random-person/assignees{/user}","branches_url":"https://api.github.com/repos/dtudury/random-person/branches{/branch}","tags_url":"https://api.github.com/repos/dtudury/random-person/tags","blobs_url":"https://api.github.com/repos/dtudury/random-person/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dtudury/random-person/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dtudury/random-person/git/refs{/sha}","trees_url":"https://api.github.com/repos/dtudury/random-person/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dtudury/random-person/statuses/{sha}","languages_url":"https://api.github.com/repos/dtudury/random-person/languages","stargazers_url":"https://api.github.com/repos/dtudury/random-person/stargazers","contributors_url":"https://api.github.com/repos/dtudury/random-person/contributors","subscribers_url":"https://api.github.com/repos/dtudury/random-person/subscribers","subscription_url":"https://api.github.com/repos/dtudury/random-person/subscription","commits_url":"https://api.github.com/repos/dtudury/random-person/commits{/sha}","git_commits_url":"https://api.github.com/repos/dtudury/random-person/git/commits{/sha}","comments_url":"https://api.github.com/repos/dtudury/random-person/comments{/number}","issue_comment_url":"https://api.github.com/repos/dtudury/random-person/issues/comments/{number}","contents_url":"https://api.github.com/repos/dtudury/random-person/contents/{+path}","compare_url":"https://api.github.com/repos/dtudury/random-person/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dtudury/random-person/merges","archive_url":"https://api.github.com/repos/dtudury/random-person/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dtudury/random-person/downloads","issues_url":"https://api.github.com/repos/dtudury/random-person/issues{/number}","pulls_url":"https://api.github.com/repos/dtudury/random-person/pulls{/number}","milestones_url":"https://api.github.com/repos/dtudury/random-person/milestones{/number}","notifications_url":"https://api.github.com/repos/dtudury/random-person/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dtudury/random-person/labels{/name}","releases_url":"https://api.github.com/repos/dtudury/random-person/releases{/id}","created_at":"2014-06-15T05:43:20Z","updated_at":"2014-07-05T20:28:22Z","pushed_at":"2014-07-05T14:18:18Z","git_url":"git://github.com/dtudury/random-person.git","ssh_url":"git@github.com:dtudury/random-person.git","clone_url":"https://github.com/dtudury/random-person.git","svn_url":"https://github.com/dtudury/random-person","homepage":null,"size":1641,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dominictarr:master","ref":"master","sha":"7af9e19a9a3727f995df7dc94e89eb7fecd0050e","user":{"login":"dominictarr","id":259374,"avatar_url":"https://avatars.githubusercontent.com/u/259374?","gravatar_id":"8225d7ca5e83a3f9f0bb89a61d5df72c","url":"https://api.github.com/users/dominictarr","html_url":"https://github.com/dominictarr","followers_url":"https://api.github.com/users/dominictarr/followers","following_url":"https://api.github.com/users/dominictarr/following{/other_user}","gists_url":"https://api.github.com/users/dominictarr/gists{/gist_id}","starred_url":"https://api.github.com/users/dominictarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dominictarr/subscriptions","organizations_url":"https://api.github.com/users/dominictarr/orgs","repos_url":"https://api.github.com/users/dominictarr/repos","events_url":"https://api.github.com/users/dominictarr/events{/privacy}","received_events_url":"https://api.github.com/users/dominictarr/received_events","type":"User","site_admin":false},"repo":{"id":5927438,"name":"random-name","full_name":"dominictarr/random-name","owner":{"login":"dominictarr","id":259374,"avatar_url":"https://avatars.githubusercontent.com/u/259374?","gravatar_id":"8225d7ca5e83a3f9f0bb89a61d5df72c","url":"https://api.github.com/users/dominictarr","html_url":"https://github.com/dominictarr","followers_url":"https://api.github.com/users/dominictarr/followers","following_url":"https://api.github.com/users/dominictarr/following{/other_user}","gists_url":"https://api.github.com/users/dominictarr/gists{/gist_id}","starred_url":"https://api.github.com/users/dominictarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dominictarr/subscriptions","organizations_url":"https://api.github.com/users/dominictarr/orgs","repos_url":"https://api.github.com/users/dominictarr/repos","events_url":"https://api.github.com/users/dominictarr/events{/privacy}","received_events_url":"https://api.github.com/users/dominictarr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dominictarr/random-name","description":null,"fork":false,"url":"https://api.github.com/repos/dominictarr/random-name","forks_url":"https://api.github.com/repos/dominictarr/random-name/forks","keys_url":"https://api.github.com/repos/dominictarr/random-name/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dominictarr/random-name/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dominictarr/random-name/teams","hooks_url":"https://api.github.com/repos/dominictarr/random-name/hooks","issue_events_url":"https://api.github.com/repos/dominictarr/random-name/issues/events{/number}","events_url":"https://api.github.com/repos/dominictarr/random-name/events","assignees_url":"https://api.github.com/repos/dominictarr/random-name/assignees{/user}","branches_url":"https://api.github.com/repos/dominictarr/random-name/branches{/branch}","tags_url":"https://api.github.com/repos/dominictarr/random-name/tags","blobs_url":"https://api.github.com/repos/dominictarr/random-name/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dominictarr/random-name/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dominictarr/random-name/git/refs{/sha}","trees_url":"https://api.github.com/repos/dominictarr/random-name/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dominictarr/random-name/statuses/{sha}","languages_url":"https://api.github.com/repos/dominictarr/random-name/languages","stargazers_url":"https://api.github.com/repos/dominictarr/random-name/stargazers","contributors_url":"https://api.github.com/repos/dominictarr/random-name/contributors","subscribers_url":"https://api.github.com/repos/dominictarr/random-name/subscribers","subscription_url":"https://api.github.com/repos/dominictarr/random-name/subscription","commits_url":"https://api.github.com/repos/dominictarr/random-name/commits{/sha}","git_commits_url":"https://api.github.com/repos/dominictarr/random-name/git/commits{/sha}","comments_url":"https://api.github.com/repos/dominictarr/random-name/comments{/number}","issue_comment_url":"https://api.github.com/repos/dominictarr/random-name/issues/comments/{number}","contents_url":"https://api.github.com/repos/dominictarr/random-name/contents/{+path}","compare_url":"https://api.github.com/repos/dominictarr/random-name/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dominictarr/random-name/merges","archive_url":"https://api.github.com/repos/dominictarr/random-name/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dominictarr/random-name/downloads","issues_url":"https://api.github.com/repos/dominictarr/random-name/issues{/number}","pulls_url":"https://api.github.com/repos/dominictarr/random-name/pulls{/number}","milestones_url":"https://api.github.com/repos/dominictarr/random-name/milestones{/number}","notifications_url":"https://api.github.com/repos/dominictarr/random-name/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dominictarr/random-name/labels{/name}","releases_url":"https://api.github.com/repos/dominictarr/random-name/releases{/id}","created_at":"2012-09-24T00:05:04Z","updated_at":"2013-11-07T23:53:23Z","pushed_at":"2012-11-14T05:08:29Z","git_url":"git://github.com/dominictarr/random-name.git","ssh_url":"git@github.com:dominictarr/random-name.git","clone_url":"https://github.com/dominictarr/random-name.git","svn_url":"https://github.com/dominictarr/random-name","homepage":null,"size":338,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":5,"mirror_url":null,"open_issues_count":0,"forks":5,"open_issues":0,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dominictarr/random-name/pulls/2"},"html":{"href":"https://github.com/dominictarr/random-name/pull/2"},"issue":{"href":"https://api.github.com/repos/dominictarr/random-name/issues/2"},"comments":{"href":"https://api.github.com/repos/dominictarr/random-name/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/dominictarr/random-name/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/dominictarr/random-name/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/dominictarr/random-name/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/dominictarr/random-name/statuses/37c5874e9a160143c574d45a87c309b9c44eeb43"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":5,"additions":97249,"deletions":123116,"changed_files":23}}