GitHub PullRequestReviewCommentEvent at 2014-01-28 19:06:57
Repository: cesium
Actor: pjcozzi
Payload: {"comment":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments/9239472","id":9239472,"diff_hunk":"@@ -142,11 +166,32 @@ define([\n         this._clearColorCommand.color = new Color();\n         this._clearColorCommand.owner = true;\n \n-        var clearDepthStencilCommand = new ClearCommand();\n-        clearDepthStencilCommand.depth = 1.0;\n-        clearDepthStencilCommand.stencil = 1.0;\n-        clearDepthStencilCommand.owner = this;\n-        this._clearDepthStencilCommand = clearDepthStencilCommand;\n+        var opaqueClearCommand = new ClearCommand();\n+        opaqueClearCommand.color = new Color(0.0, 0.0, 0.0, 0.0);\n+        opaqueClearCommand.depth = 1.0;\n+        opaqueClearCommand.stencil = 1.0;\n+        opaqueClearCommand.owner = this;\n+        this._opaqueClearCommand = opaqueClearCommand;\n+\n+        var translucentClearCommand = new ClearCommand();\n+        translucentClearCommand.color = new Color(0.0, 0.0, 0.0, 1.0);\n+        translucentClearCommand.owner = this;\n+        this._translucentClearCommand = translucentClearCommand;\n+\n+        if (!context.getDrawBuffers()) {\n+            translucentClearCommand.color.alpha = 0.0;\n+\n+            var alphaClearCommand = new ClearCommand();\n+            alphaClearCommand.color = new Color(1.0, 1.0, 1.0, 1.0);\n+            alphaClearCommand.owner = this;\n+            this._alphaClearCommand = alphaClearCommand;\n+        }\n+\n+        var depthStencilClearCommand = new ClearCommand();\n+        depthStencilClearCommand.depth = 1.0;\n+        depthStencilClearCommand.stencil = 1.0;","path":"Source/Scene/Scene.js","position":96,"original_position":96,"commit_id":"1b1fccd989c4a343dece1eb0f10498fa8b8d8a5e","original_commit_id":"1b1fccd989c4a343dece1eb0f10498fa8b8d8a5e","user":{"login":"pjcozzi","id":782098,"avatar_url":"https://gravatar.com/avatar/744fc861be12525cb0e08418aeb372d2?d=https%3A%2F%2Fidenticons.github.com%2F0d206dad3952396d4f98cbb43db4a272.png&r=x","gravatar_id":"744fc861be12525cb0e08418aeb372d2","url":"https://api.github.com/users/pjcozzi","html_url":"https://github.com/pjcozzi","followers_url":"https://api.github.com/users/pjcozzi/followers","following_url":"https://api.github.com/users/pjcozzi/following{/other_user}","gists_url":"https://api.github.com/users/pjcozzi/gists{/gist_id}","starred_url":"https://api.github.com/users/pjcozzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjcozzi/subscriptions","organizations_url":"https://api.github.com/users/pjcozzi/orgs","repos_url":"https://api.github.com/users/pjcozzi/repos","events_url":"https://api.github.com/users/pjcozzi/events{/privacy}","received_events_url":"https://api.github.com/users/pjcozzi/received_events","type":"User","site_admin":false},"body":"Or need it here.  Maybe for some tests?","created_at":"2014-01-28T19:06:57Z","updated_at":"2014-01-28T19:06:57Z","html_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/1412#discussion_r9239472","pull_request_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/1412","_links":{"self":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments/9239472"},"html":{"href":"https://github.com/AnalyticalGraphicsInc/cesium/pull/1412#discussion_r9239472"},"pull_request":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/1412"}}}}