GitHub PullRequestReviewCommentEvent at 2014-04-14 17:11:13
Repository: neovim
Actor: philix
Payload: {"comment":{"url":"https://api.github.com/repos/neovim/neovim/pulls/comments/11595499","id":11595499,"diff_hunk":"@@ -3647,6 +3647,35 @@ void do_sub(exarg_T *eap)\n     endcolumn = (curwin->w_curswant == MAXCOL);\n   }\n \n+  // Recognize \":%s/\\n//\" and turn it into a join command, which is much\n+  // more efficient.\n+  // TODO: find a generic solution to make line-joining operations more\n+  // efficient, avoid allocating a string that grows in size.\n+  if (strcmp((const char *)pat, \"\\\\n\") == 0","path":"src/ex_cmds.c","position":8,"original_position":8,"commit_id":"f386616368fcd64fe1c9f9837172b6cdc82fa458","original_commit_id":"f386616368fcd64fe1c9f9837172b6cdc82fa458","user":{"login":"philix","id":207795,"avatar_url":"https://avatars.githubusercontent.com/u/207795?","gravatar_id":"57cd99746126aa0518136a4271f1f9c1","url":"https://api.github.com/users/philix","html_url":"https://github.com/philix","followers_url":"https://api.github.com/users/philix/followers","following_url":"https://api.github.com/users/philix/following{/other_user}","gists_url":"https://api.github.com/users/philix/gists{/gist_id}","starred_url":"https://api.github.com/users/philix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philix/subscriptions","organizations_url":"https://api.github.com/users/philix/orgs","repos_url":"https://api.github.com/users/philix/repos","events_url":"https://api.github.com/users/philix/events{/privacy}","received_events_url":"https://api.github.com/users/philix/received_events","type":"User","site_admin":false},"body":"Exactly. Keep moving away from these macros.\r\n\r\nGreat work porting all these patches.\r\nOn Apr 14, 2014 12:49 PM, \"Marco Hinz\" <notifications@github.com> wrote:\r\n\r\n> In src/ex_cmds.c:\r\n>\r\n> > @@ -3647,6 +3647,35 @@ void do_sub(exarg_T *eap)\r\n> >      endcolumn = (curwin->w_curswant == MAXCOL);\r\n> >    }\r\n> >\r\n> > +  // Recognize \":%s/\\n//\" and turn it into a join command, which is much\r\n> > +  // more efficient.\r\n> > +  // TODO: find a generic solution to make line-joining operations more\r\n> > +  // efficient, avoid allocating a string that grows in size.\r\n> > +  if (strcmp((const char *)pat, \"\\\\n\") == 0\r\n>\r\n> I thought there was the general tendency to remove them. They're not doing\r\n> anything useful anyway. We should go for the *normal* functions and later\r\n> change the types in all the files.\r\n>\r\n> E.g. uint8_t * instead of char_u *. This change alone would save tons of\r\n> casts all over the current code base. :)\r\n>\r\n> —\r\n> Reply to this email directly or view it on GitHub<https://github.com/neovim/neovim/pull/529/files#r11591209>\r\n> .\r\n>","created_at":"2014-04-14T17:11:13Z","updated_at":"2014-04-14T17:11:13Z","html_url":"https://github.com/neovim/neovim/pull/529#discussion_r11595499","pull_request_url":"https://api.github.com/repos/neovim/neovim/pulls/529","_links":{"self":{"href":"https://api.github.com/repos/neovim/neovim/pulls/comments/11595499"},"html":{"href":"https://github.com/neovim/neovim/pull/529#discussion_r11595499"},"pull_request":{"href":"https://api.github.com/repos/neovim/neovim/pulls/529"}}}}