GitHub PullRequestReviewCommentEvent at 2014-12-30 06:50:20
Repository: edx-platform
Actor: polesye
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/22339993","id":22339993,"diff_hunk":"@@ -211,148 +211,27 @@\n \n     <section class=\"course-content\" id=\"course-content\">\n       ${fragment.body_html()}\n-      % if is_edxnotes_enabled(course):\n-        <%include file=\"/edxnotes/toggle_notes.html\" args=\"course=course\"/>\n-      % endif\n     </section>\n   </div>\n </div>\n \n-% if show_chat:\n-  <div id=\"chat-wrapper\">\n-    <div id=\"chat-toggle\" class=\"closed\">\n-      <span id=\"chat-open\">Open Chat <em class=\"icon-chevron-up\"></em></span>\n-      <span id=\"chat-close\">Close Chat <em class=\"icon-chevron-down\"></em></span>\n-    </div>\n-    <div id=\"chat-block\">\n-      ## The Candy.js plugin wants to render in an element with #candy\n-      <div id=\"candy\"></div>\n-    </div>\n-  </div>\n-% endif\n-\n-% if course.show_calculator:\n-  <div class=\"calc-main\">\n-    <a title=\"${_('Open Calculator')}\" href=\"#\" role=\"button\" aria-controls=\"calculator_wrapper\" aria-expanded=\"false\" class=\"calc\">${_(\"Open Calculator\")}</a>\n-\n-    <div id=\"calculator_wrapper\">\n-      <form id=\"calculator\">\n-        <div class=\"input-wrapper\">\n-          <input type=\"text\" id=\"calculator_input\" title=\"${_('Calculator Input Field')}\" tabindex=\"-1\" />\n-\n-          <div class=\"help-wrapper\">\n-            <p class=\"sr\" id=\"hint-instructions\">${_('Use the arrow keys to navigate the tips or use the tab key to return to the calculator')}</p>\n-\n-            <a id=\"calculator_hint\" href=\"#\" role=\"button\" aria-haspopup=\"true\" tabindex=\"-1\" aria-describedby=\"hint-instructions\">${_(\"Hints\")}</a>\n+<nav class=\"nav-utilities\">\n+  <h2 class=\"sr nav-utilities-title\">Course Utilities Navigation</h2>","path":"lms/templates/courseware/courseware.html","position":38,"original_position":38,"commit_id":"5263fade9e873a420fa772e69e25fbad60a0995d","original_commit_id":"5263fade9e873a420fa772e69e25fbad60a0995d","user":{"login":"polesye","id":1247491,"avatar_url":"https://avatars.githubusercontent.com/u/1247491?v=3","gravatar_id":"","url":"https://api.github.com/users/polesye","html_url":"https://github.com/polesye","followers_url":"https://api.github.com/users/polesye/followers","following_url":"https://api.github.com/users/polesye/following{/other_user}","gists_url":"https://api.github.com/users/polesye/gists{/gist_id}","starred_url":"https://api.github.com/users/polesye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/polesye/subscriptions","organizations_url":"https://api.github.com/users/polesye/orgs","repos_url":"https://api.github.com/users/polesye/repos","events_url":"https://api.github.com/users/polesye/events{/privacy}","received_events_url":"https://api.github.com/users/polesye/received_events","type":"User","site_admin":false},"body":"i18n?","created_at":"2014-12-30T06:50:20Z","updated_at":"2014-12-30T06:50:20Z","html_url":"https://github.com/edx/edx-platform/pull/6384#discussion_r22339993","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/6384","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/22339993"},"html":{"href":"https://github.com/edx/edx-platform/pull/6384#discussion_r22339993"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/6384"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/6384","id":26628852,"html_url":"https://github.com/edx/edx-platform/pull/6384","diff_url":"https://github.com/edx/edx-platform/pull/6384.diff","patch_url":"https://github.com/edx/edx-platform/pull/6384.patch","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/6384","number":6384,"state":"open","locked":false,"title":"LMS: Student Notes - Toggle Visibility (UX-1125)","user":{"login":"talbs","id":163763,"avatar_url":"https://avatars.githubusercontent.com/u/163763?v=3","gravatar_id":"","url":"https://api.github.com/users/talbs","html_url":"https://github.com/talbs","followers_url":"https://api.github.com/users/talbs/followers","following_url":"https://api.github.com/users/talbs/following{/other_user}","gists_url":"https://api.github.com/users/talbs/gists{/gist_id}","starred_url":"https://api.github.com/users/talbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talbs/subscriptions","organizations_url":"https://api.github.com/users/talbs/orgs","repos_url":"https://api.github.com/users/talbs/repos","events_url":"https://api.github.com/users/talbs/events{/privacy}","received_events_url":"https://api.github.com/users/talbs/received_events","type":"User","site_admin":false},"body":"This work styles the toggle notes on and off UI being added to the LMS. Included in this work is:\r\n\r\n* partial abstraction of utility-based navigation styling/markup\r\n* brief clean up of Sass partial organization (adding in modules)\r\n* styling/rendering of toggle notes specific UI\r\n* styling/rendering of toggle notes errors (both system and vendor errors)\r\n\r\n- - -\r\n\r\n**Known Concerns**\r\n* The calculator's styling and markup are particular to that element - the UI added here has been positioned around this element, but utility navigation should be more robust when supporting multiple items per course.\r\n* This UI may not play well with the chat feature, which has not been reviewed.\r\n* The vendor's error message is still displayed when the notes server cannot be reached\r\n* The system message (for when there is an error in toggling) is limited in content and is currently not using a known system feedback pattern\r\n\r\n- - -\r\n\r\n**TODOS**\r\n* Wire in the ``.has-error`` stateful class to ``.edx-notes-visibility`` element (display is controlled by this toggle)\r\n* Wire correctly the ``.is-active`` class on the ``.action-toggle-notes`` elements (currently added in HTML, but JS is not toggling class while maintaining state)\r\n\r\n- - -\r\n\r\n**Screengrab - Notes Toggled Off**\r\n![screen shot 2014-12-29 at 2 27 42 pm](https://cloud.githubusercontent.com/assets/163763/5572099/80697b54-8f67-11e4-9124-596c44e63898.png)\r\n\r\n**Screengrab - Notes Toggled On**\r\n![screen shot 2014-12-29 at 2 27 26 pm](https://cloud.githubusercontent.com/assets/163763/5572098/7b7c0eb8-8f67-11e4-9129-6a761a617b17.png)\r\n\r\n**Screengrab - Notes Toggle with System Error**\r\n![screen shot 2014-12-29 at 2 29 35 pm](https://cloud.githubusercontent.com/assets/163763/5572103/8c4a79b4-8f67-11e4-987c-027c07d91c7c.png)","created_at":"2014-12-28T23:22:08Z","updated_at":"2014-12-30T06:50:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4f8e1375ca60b291cd02cf826bfc487880f4150c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-platform/pulls/6384/commits","review_comments_url":"https://api.github.com/repos/edx/edx-platform/pulls/6384/comments","review_comment_url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/{number}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/6384/comments","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/5263fade9e873a420fa772e69e25fbad60a0995d","head":{"label":"edx:talbs/edxnotes-togglenotes-v2","ref":"talbs/edxnotes-togglenotes-v2","sha":"5263fade9e873a420fa772e69e25fbad60a0995d","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"Open edX, the edX platform that powers http://edx.org","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments/{number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","created_at":"2013-05-30T20:20:38Z","updated_at":"2014-12-30T05:16:40Z","pushed_at":"2014-12-30T06:39:34Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://openedx.org/","size":1531069,"stargazers_count":1638,"watchers_count":1638,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":942,"mirror_url":null,"open_issues_count":150,"forks":942,"open_issues":150,"watchers":1638,"default_branch":"master"}},"base":{"label":"edx:feature/edxnotes","ref":"feature/edxnotes","sha":"2aa3667948f2ab8c64752a7c8864dfc11171cf2b","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"Open edX, the edX platform that powers http://edx.org","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments/{number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","created_at":"2013-05-30T20:20:38Z","updated_at":"2014-12-30T05:16:40Z","pushed_at":"2014-12-30T06:39:34Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://openedx.org/","size":1531069,"stargazers_count":1638,"watchers_count":1638,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":942,"mirror_url":null,"open_issues_count":150,"forks":942,"open_issues":150,"watchers":1638,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/6384"},"html":{"href":"https://github.com/edx/edx-platform/pull/6384"},"issue":{"href":"https://api.github.com/repos/edx/edx-platform/issues/6384"},"comments":{"href":"https://api.github.com/repos/edx/edx-platform/issues/6384/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/6384/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/6384/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-platform/statuses/5263fade9e873a420fa772e69e25fbad60a0995d"}}}}