GitHub PullRequestReviewCommentEvent at 2014-06-30 16:18:26
Repository: puppet-foreman
Actor: ekohl
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/theforeman/puppet-foreman/pulls/comments/14359077","id":14359077,"diff_hunk":"@@ -50,4 +50,134 @@\n   if $foreman::passenger  {\n     class { '::foreman::config::passenger': } -> anchor { 'foreman::config_end': }\n   }\n+\n+  if $foreman::enable_ipa {\n+    if \"${::default_ipa_server}\" == '' or \"${::default_ipa_realm}\" == '' {\n+      fail(\"${::hostname}: The system does not seem to be IPA-enrolled\")\n+    }\n+\n+    selboolean { 'allow_httpd_mod_auth_pam':\n+      persistent => true,\n+      value      => 'on',\n+    }\n+\n+    exec { 'setsebool httpd_dbus_sssd':","path":"manifests/config.pp","position":15,"original_position":15,"commit_id":"7443bc0dd4769393255cb5b0c45c8ab7208dea34","original_commit_id":"7443bc0dd4769393255cb5b0c45c8ab7208dea34","user":{"login":"ekohl","id":155810,"avatar_url":"https://avatars.githubusercontent.com/u/155810?","gravatar_id":"0a94fde0a807ef39cf12c60b9422a34f","url":"https://api.github.com/users/ekohl","html_url":"https://github.com/ekohl","followers_url":"https://api.github.com/users/ekohl/followers","following_url":"https://api.github.com/users/ekohl/following{/other_user}","gists_url":"https://api.github.com/users/ekohl/gists{/gist_id}","starred_url":"https://api.github.com/users/ekohl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekohl/subscriptions","organizations_url":"https://api.github.com/users/ekohl/orgs","repos_url":"https://api.github.com/users/ekohl/repos","events_url":"https://api.github.com/users/ekohl/events{/privacy}","received_events_url":"https://api.github.com/users/ekohl/received_events","type":"User","site_admin":false},"body":"I'd appreciate a comment here that explains why ```selboolean``` can't be used.","created_at":"2014-06-30T16:18:26Z","updated_at":"2014-06-30T16:18:26Z","html_url":"https://github.com/theforeman/puppet-foreman/pull/199#discussion_r14359077","pull_request_url":"https://api.github.com/repos/theforeman/puppet-foreman/pulls/199","_links":{"self":{"href":"https://api.github.com/repos/theforeman/puppet-foreman/pulls/comments/14359077"},"html":{"href":"https://github.com/theforeman/puppet-foreman/pull/199#discussion_r14359077"},"pull_request":{"href":"https://api.github.com/repos/theforeman/puppet-foreman/pulls/199"}}},"pull_request":{"url":"https://api.github.com/repos/theforeman/puppet-foreman/pulls/199","id":17782395,"html_url":"https://github.com/theforeman/puppet-foreman/pull/199","diff_url":"https://github.com/theforeman/puppet-foreman/pull/199.diff","patch_url":"https://github.com/theforeman/puppet-foreman/pull/199.patch","issue_url":"https://api.github.com/repos/theforeman/puppet-foreman/issues/199","number":199,"state":"open","title":"fixes #6445 - Configure external authentication via FreeIPA.","user":{"login":"adelton","id":2536912,"avatar_url":"https://avatars.githubusercontent.com/u/2536912?","gravatar_id":"98cf5a00a15c92a723474aac48c4201a","url":"https://api.github.com/users/adelton","html_url":"https://github.com/adelton","followers_url":"https://api.github.com/users/adelton/followers","following_url":"https://api.github.com/users/adelton/following{/other_user}","gists_url":"https://api.github.com/users/adelton/gists{/gist_id}","starred_url":"https://api.github.com/users/adelton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adelton/subscriptions","organizations_url":"https://api.github.com/users/adelton/orgs","repos_url":"https://api.github.com/users/adelton/repos","events_url":"https://api.github.com/users/adelton/events{/privacy}","received_events_url":"https://api.github.com/users/adelton/received_events","type":"User","site_admin":false},"body":"With these changes, ```foreman-installer --foreman-enable-ipa=true``` will configure external authentication using FreeIPA per http://theforeman.org/manuals/1.5/index.html#5.7ExternalAuthentication, provided the machine where Foreman is being installer (or reconfigured) is IPA-enrolled and HTTP/foreman-fqdn service exists in the FreeIPA server.","created_at":"2014-06-30T16:13:06Z","updated_at":"2014-06-30T16:18:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1f7671cad45e9959aa70a82aad71e771c4f6df33","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/theforeman/puppet-foreman/pulls/199/commits","review_comments_url":"https://api.github.com/repos/theforeman/puppet-foreman/pulls/199/comments","review_comment_url":"https://api.github.com/repos/theforeman/puppet-foreman/pulls/comments/{number}","comments_url":"https://api.github.com/repos/theforeman/puppet-foreman/issues/199/comments","statuses_url":"https://api.github.com/repos/theforeman/puppet-foreman/statuses/7443bc0dd4769393255cb5b0c45c8ab7208dea34","head":{"label":"adelton:foreman-ipa","ref":"foreman-ipa","sha":"7443bc0dd4769393255cb5b0c45c8ab7208dea34","user":{"login":"adelton","id":2536912,"avatar_url":"https://avatars.githubusercontent.com/u/2536912?","gravatar_id":"98cf5a00a15c92a723474aac48c4201a","url":"https://api.github.com/users/adelton","html_url":"https://github.com/adelton","followers_url":"https://api.github.com/users/adelton/followers","following_url":"https://api.github.com/users/adelton/following{/other_user}","gists_url":"https://api.github.com/users/adelton/gists{/gist_id}","starred_url":"https://api.github.com/users/adelton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adelton/subscriptions","organizations_url":"https://api.github.com/users/adelton/orgs","repos_url":"https://api.github.com/users/adelton/repos","events_url":"https://api.github.com/users/adelton/events{/privacy}","received_events_url":"https://api.github.com/users/adelton/received_events","type":"User","site_admin":false},"repo":{"id":21353432,"name":"puppet-foreman","full_name":"adelton/puppet-foreman","owner":{"login":"adelton","id":2536912,"avatar_url":"https://avatars.githubusercontent.com/u/2536912?","gravatar_id":"98cf5a00a15c92a723474aac48c4201a","url":"https://api.github.com/users/adelton","html_url":"https://github.com/adelton","followers_url":"https://api.github.com/users/adelton/followers","following_url":"https://api.github.com/users/adelton/following{/other_user}","gists_url":"https://api.github.com/users/adelton/gists{/gist_id}","starred_url":"https://api.github.com/users/adelton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adelton/subscriptions","organizations_url":"https://api.github.com/users/adelton/orgs","repos_url":"https://api.github.com/users/adelton/repos","events_url":"https://api.github.com/users/adelton/events{/privacy}","received_events_url":"https://api.github.com/users/adelton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adelton/puppet-foreman","description":"Puppet module for Foreman","fork":true,"url":"https://api.github.com/repos/adelton/puppet-foreman","forks_url":"https://api.github.com/repos/adelton/puppet-foreman/forks","keys_url":"https://api.github.com/repos/adelton/puppet-foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adelton/puppet-foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adelton/puppet-foreman/teams","hooks_url":"https://api.github.com/repos/adelton/puppet-foreman/hooks","issue_events_url":"https://api.github.com/repos/adelton/puppet-foreman/issues/events{/number}","events_url":"https://api.github.com/repos/adelton/puppet-foreman/events","assignees_url":"https://api.github.com/repos/adelton/puppet-foreman/assignees{/user}","branches_url":"https://api.github.com/repos/adelton/puppet-foreman/branches{/branch}","tags_url":"https://api.github.com/repos/adelton/puppet-foreman/tags","blobs_url":"https://api.github.com/repos/adelton/puppet-foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adelton/puppet-foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adelton/puppet-foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/adelton/puppet-foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adelton/puppet-foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/adelton/puppet-foreman/languages","stargazers_url":"https://api.github.com/repos/adelton/puppet-foreman/stargazers","contributors_url":"https://api.github.com/repos/adelton/puppet-foreman/contributors","subscribers_url":"https://api.github.com/repos/adelton/puppet-foreman/subscribers","subscription_url":"https://api.github.com/repos/adelton/puppet-foreman/subscription","commits_url":"https://api.github.com/repos/adelton/puppet-foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/adelton/puppet-foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/adelton/puppet-foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/adelton/puppet-foreman/issues/comments/{number}","contents_url":"https://api.github.com/repos/adelton/puppet-foreman/contents/{+path}","compare_url":"https://api.github.com/repos/adelton/puppet-foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adelton/puppet-foreman/merges","archive_url":"https://api.github.com/repos/adelton/puppet-foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adelton/puppet-foreman/downloads","issues_url":"https://api.github.com/repos/adelton/puppet-foreman/issues{/number}","pulls_url":"https://api.github.com/repos/adelton/puppet-foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/adelton/puppet-foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/adelton/puppet-foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adelton/puppet-foreman/labels{/name}","releases_url":"https://api.github.com/repos/adelton/puppet-foreman/releases{/id}","created_at":"2014-06-30T14:12:31Z","updated_at":"2014-06-30T12:29:12Z","pushed_at":"2014-06-30T16:10:39Z","git_url":"git://github.com/adelton/puppet-foreman.git","ssh_url":"git@github.com:adelton/puppet-foreman.git","clone_url":"https://github.com/adelton/puppet-foreman.git","svn_url":"https://github.com/adelton/puppet-foreman","homepage":"","size":2920,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"theforeman:master","ref":"master","sha":"5534df907c17a4d9c81ea948697ebf35d773e8a0","user":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?","gravatar_id":"debaffa7d317b9ec76a588682fb1e640","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":3449583,"name":"puppet-foreman","full_name":"theforeman/puppet-foreman","owner":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?","gravatar_id":"debaffa7d317b9ec76a588682fb1e640","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theforeman/puppet-foreman","description":"Puppet module for Foreman","fork":false,"url":"https://api.github.com/repos/theforeman/puppet-foreman","forks_url":"https://api.github.com/repos/theforeman/puppet-foreman/forks","keys_url":"https://api.github.com/repos/theforeman/puppet-foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/puppet-foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/puppet-foreman/teams","hooks_url":"https://api.github.com/repos/theforeman/puppet-foreman/hooks","issue_events_url":"https://api.github.com/repos/theforeman/puppet-foreman/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/puppet-foreman/events","assignees_url":"https://api.github.com/repos/theforeman/puppet-foreman/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/puppet-foreman/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/puppet-foreman/tags","blobs_url":"https://api.github.com/repos/theforeman/puppet-foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/puppet-foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/puppet-foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/puppet-foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/puppet-foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/puppet-foreman/languages","stargazers_url":"https://api.github.com/repos/theforeman/puppet-foreman/stargazers","contributors_url":"https://api.github.com/repos/theforeman/puppet-foreman/contributors","subscribers_url":"https://api.github.com/repos/theforeman/puppet-foreman/subscribers","subscription_url":"https://api.github.com/repos/theforeman/puppet-foreman/subscription","commits_url":"https://api.github.com/repos/theforeman/puppet-foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/puppet-foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/puppet-foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/puppet-foreman/issues/comments/{number}","contents_url":"https://api.github.com/repos/theforeman/puppet-foreman/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/puppet-foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/puppet-foreman/merges","archive_url":"https://api.github.com/repos/theforeman/puppet-foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/puppet-foreman/downloads","issues_url":"https://api.github.com/repos/theforeman/puppet-foreman/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/puppet-foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/puppet-foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/puppet-foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/puppet-foreman/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/puppet-foreman/releases{/id}","created_at":"2012-02-15T13:19:01Z","updated_at":"2014-06-30T12:29:12Z","pushed_at":"2014-06-30T12:29:12Z","git_url":"git://github.com/theforeman/puppet-foreman.git","ssh_url":"git@github.com:theforeman/puppet-foreman.git","clone_url":"https://github.com/theforeman/puppet-foreman.git","svn_url":"https://github.com/theforeman/puppet-foreman","homepage":"","size":2920,"stargazers_count":43,"watchers_count":43,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":93,"mirror_url":null,"open_issues_count":17,"forks":93,"open_issues":17,"watchers":43,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/puppet-foreman/pulls/199"},"html":{"href":"https://github.com/theforeman/puppet-foreman/pull/199"},"issue":{"href":"https://api.github.com/repos/theforeman/puppet-foreman/issues/199"},"comments":{"href":"https://api.github.com/repos/theforeman/puppet-foreman/issues/199/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/puppet-foreman/pulls/199/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/puppet-foreman/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/theforeman/puppet-foreman/pulls/199/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/puppet-foreman/statuses/7443bc0dd4769393255cb5b0c45c8ab7208dea34"}}}}