GitHub PullRequestEvent at 2014-09-23 18:36:17
Repository: liferay-portal
Actor: blzaugg
Payload: {"action":"closed","number":105,"pull_request":{"url":"https://api.github.com/repos/blzaugg/liferay-portal/pulls/105","id":19691676,"html_url":"https://github.com/blzaugg/liferay-portal/pull/105","diff_url":"https://github.com/blzaugg/liferay-portal/pull/105.diff","patch_url":"https://github.com/blzaugg/liferay-portal/pull/105.patch","issue_url":"https://api.github.com/repos/blzaugg/liferay-portal/issues/105","number":105,"state":"closed","locked":false,"title":"LPS-23441 Manage Site iframe adjusts height for dialog contents","user":{"login":"noellekimiko","id":6542536,"avatar_url":"https://avatars.githubusercontent.com/u/6542536?v=2","gravatar_id":"","url":"https://api.github.com/users/noellekimiko","html_url":"https://github.com/noellekimiko","followers_url":"https://api.github.com/users/noellekimiko/followers","following_url":"https://api.github.com/users/noellekimiko/following{/other_user}","gists_url":"https://api.github.com/users/noellekimiko/gists{/gist_id}","starred_url":"https://api.github.com/users/noellekimiko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noellekimiko/subscriptions","organizations_url":"https://api.github.com/users/noellekimiko/orgs","repos_url":"https://api.github.com/users/noellekimiko/repos","events_url":"https://api.github.com/users/noellekimiko/events{/privacy}","received_events_url":"https://api.github.com/users/noellekimiko/received_events","type":"User","site_admin":false},"body":"Jira ticket: https://issues.liferay.com/browse/LPS-23441\r\nCaused by: https://issues.liferay.com/browse/AUI-1602\r\n\r\n* The Manage Content Window is an instance of the aui-resize-iframe component and so the code controlling its appearance is in aui-resize-iframe.js\r\n* In this file, there is a function _onResize that should automatically adjust the height of the iframe to show all of its contents.\r\n   * First, the function computes the height of its contents with _getContentHeight\r\n   * Then, it passes this value to _uiSetHeight to adjust the height\r\n* So the problem is in _getContentHeight. \r\n   * As it was originally written, _getContentHeight does not detect the height of dialog elements in its contents which is why the window does not resize\r\n   * For the case where there is a dialog element in the contents, code was added. The largest is found and checked to see if it is larger than the contents would be otherwise. If so, this value is used as the height instead.\r\n* Checked in IE 7-11, Chrome and Firefox","created_at":"2014-08-12T21:38:26Z","updated_at":"2014-09-23T18:36:16Z","closed_at":"2014-09-23T18:36:16Z","merged_at":null,"merge_commit_sha":"e3c4747d202cff799fd8d50667b0d864c9d83b99","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/blzaugg/liferay-portal/pulls/105/commits","review_comments_url":"https://api.github.com/repos/blzaugg/liferay-portal/pulls/105/comments","review_comment_url":"https://api.github.com/repos/blzaugg/liferay-portal/pulls/comments/{number}","comments_url":"https://api.github.com/repos/blzaugg/liferay-portal/issues/105/comments","statuses_url":"https://api.github.com/repos/blzaugg/liferay-portal/statuses/4542dc72b3610ee4dfae418f6529f444b50e1fb7","head":{"label":"noellekimiko:LPS-23441","ref":"LPS-23441","sha":"4542dc72b3610ee4dfae418f6529f444b50e1fb7","user":{"login":"noellekimiko","id":6542536,"avatar_url":"https://avatars.githubusercontent.com/u/6542536?v=2","gravatar_id":"","url":"https://api.github.com/users/noellekimiko","html_url":"https://github.com/noellekimiko","followers_url":"https://api.github.com/users/noellekimiko/followers","following_url":"https://api.github.com/users/noellekimiko/following{/other_user}","gists_url":"https://api.github.com/users/noellekimiko/gists{/gist_id}","starred_url":"https://api.github.com/users/noellekimiko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noellekimiko/subscriptions","organizations_url":"https://api.github.com/users/noellekimiko/orgs","repos_url":"https://api.github.com/users/noellekimiko/repos","events_url":"https://api.github.com/users/noellekimiko/events{/privacy}","received_events_url":"https://api.github.com/users/noellekimiko/received_events","type":"User","site_admin":false},"repo":{"id":20310991,"name":"liferay-portal","full_name":"noellekimiko/liferay-portal","owner":{"login":"noellekimiko","id":6542536,"avatar_url":"https://avatars.githubusercontent.com/u/6542536?v=2","gravatar_id":"","url":"https://api.github.com/users/noellekimiko","html_url":"https://github.com/noellekimiko","followers_url":"https://api.github.com/users/noellekimiko/followers","following_url":"https://api.github.com/users/noellekimiko/following{/other_user}","gists_url":"https://api.github.com/users/noellekimiko/gists{/gist_id}","starred_url":"https://api.github.com/users/noellekimiko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noellekimiko/subscriptions","organizations_url":"https://api.github.com/users/noellekimiko/orgs","repos_url":"https://api.github.com/users/noellekimiko/repos","events_url":"https://api.github.com/users/noellekimiko/events{/privacy}","received_events_url":"https://api.github.com/users/noellekimiko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/noellekimiko/liferay-portal","description":"","fork":true,"url":"https://api.github.com/repos/noellekimiko/liferay-portal","forks_url":"https://api.github.com/repos/noellekimiko/liferay-portal/forks","keys_url":"https://api.github.com/repos/noellekimiko/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/noellekimiko/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/noellekimiko/liferay-portal/teams","hooks_url":"https://api.github.com/repos/noellekimiko/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/noellekimiko/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/noellekimiko/liferay-portal/events","assignees_url":"https://api.github.com/repos/noellekimiko/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/noellekimiko/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/noellekimiko/liferay-portal/tags","blobs_url":"https://api.github.com/repos/noellekimiko/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/noellekimiko/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/noellekimiko/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/noellekimiko/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/noellekimiko/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/noellekimiko/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/noellekimiko/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/noellekimiko/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/noellekimiko/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/noellekimiko/liferay-portal/subscription","commits_url":"https://api.github.com/repos/noellekimiko/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/noellekimiko/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/noellekimiko/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/noellekimiko/liferay-portal/issues/comments/{number}","contents_url":"https://api.github.com/repos/noellekimiko/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/noellekimiko/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/noellekimiko/liferay-portal/merges","archive_url":"https://api.github.com/repos/noellekimiko/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/noellekimiko/liferay-portal/downloads","issues_url":"https://api.github.com/repos/noellekimiko/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/noellekimiko/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/noellekimiko/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/noellekimiko/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/noellekimiko/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/noellekimiko/liferay-portal/releases{/id}","created_at":"2014-05-29T23:03:30Z","updated_at":"2014-07-11T18:23:27Z","pushed_at":"2014-09-12T23:41:26Z","git_url":"git://github.com/noellekimiko/liferay-portal.git","ssh_url":"git@github.com:noellekimiko/liferay-portal.git","clone_url":"https://github.com/noellekimiko/liferay-portal.git","svn_url":"https://github.com/noellekimiko/liferay-portal","homepage":"http://liferay.com","size":3774009,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"blzaugg:6.1.x","ref":"6.1.x","sha":"3c31bd74260db32c626f99af19eef4ad956e754f","user":{"login":"blzaugg","id":1626739,"avatar_url":"https://avatars.githubusercontent.com/u/1626739?v=2","gravatar_id":"","url":"https://api.github.com/users/blzaugg","html_url":"https://github.com/blzaugg","followers_url":"https://api.github.com/users/blzaugg/followers","following_url":"https://api.github.com/users/blzaugg/following{/other_user}","gists_url":"https://api.github.com/users/blzaugg/gists{/gist_id}","starred_url":"https://api.github.com/users/blzaugg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blzaugg/subscriptions","organizations_url":"https://api.github.com/users/blzaugg/orgs","repos_url":"https://api.github.com/users/blzaugg/repos","events_url":"https://api.github.com/users/blzaugg/events{/privacy}","received_events_url":"https://api.github.com/users/blzaugg/received_events","type":"User","site_admin":false},"repo":{"id":3974886,"name":"liferay-portal","full_name":"blzaugg/liferay-portal","owner":{"login":"blzaugg","id":1626739,"avatar_url":"https://avatars.githubusercontent.com/u/1626739?v=2","gravatar_id":"","url":"https://api.github.com/users/blzaugg","html_url":"https://github.com/blzaugg","followers_url":"https://api.github.com/users/blzaugg/followers","following_url":"https://api.github.com/users/blzaugg/following{/other_user}","gists_url":"https://api.github.com/users/blzaugg/gists{/gist_id}","starred_url":"https://api.github.com/users/blzaugg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blzaugg/subscriptions","organizations_url":"https://api.github.com/users/blzaugg/orgs","repos_url":"https://api.github.com/users/blzaugg/repos","events_url":"https://api.github.com/users/blzaugg/events{/privacy}","received_events_url":"https://api.github.com/users/blzaugg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/blzaugg/liferay-portal","description":"","fork":true,"url":"https://api.github.com/repos/blzaugg/liferay-portal","forks_url":"https://api.github.com/repos/blzaugg/liferay-portal/forks","keys_url":"https://api.github.com/repos/blzaugg/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blzaugg/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blzaugg/liferay-portal/teams","hooks_url":"https://api.github.com/repos/blzaugg/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/blzaugg/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/blzaugg/liferay-portal/events","assignees_url":"https://api.github.com/repos/blzaugg/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/blzaugg/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/blzaugg/liferay-portal/tags","blobs_url":"https://api.github.com/repos/blzaugg/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blzaugg/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blzaugg/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/blzaugg/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blzaugg/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/blzaugg/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/blzaugg/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/blzaugg/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/blzaugg/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/blzaugg/liferay-portal/subscription","commits_url":"https://api.github.com/repos/blzaugg/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/blzaugg/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/blzaugg/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/blzaugg/liferay-portal/issues/comments/{number}","contents_url":"https://api.github.com/repos/blzaugg/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/blzaugg/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blzaugg/liferay-portal/merges","archive_url":"https://api.github.com/repos/blzaugg/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blzaugg/liferay-portal/downloads","issues_url":"https://api.github.com/repos/blzaugg/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/blzaugg/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/blzaugg/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/blzaugg/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blzaugg/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/blzaugg/liferay-portal/releases{/id}","created_at":"2012-04-09T19:04:05Z","updated_at":"2014-08-13T18:43:13Z","pushed_at":"2014-08-22T18:44:05Z","git_url":"git://github.com/blzaugg/liferay-portal.git","ssh_url":"git@github.com:blzaugg/liferay-portal.git","clone_url":"https://github.com/blzaugg/liferay-portal.git","svn_url":"https://github.com/blzaugg/liferay-portal","homepage":"http://liferay.com","size":3710364,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":7,"forks":0,"open_issues":7,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/blzaugg/liferay-portal/pulls/105"},"html":{"href":"https://github.com/blzaugg/liferay-portal/pull/105"},"issue":{"href":"https://api.github.com/repos/blzaugg/liferay-portal/issues/105"},"comments":{"href":"https://api.github.com/repos/blzaugg/liferay-portal/issues/105/comments"},"review_comments":{"href":"https://api.github.com/repos/blzaugg/liferay-portal/pulls/105/comments"},"review_comment":{"href":"https://api.github.com/repos/blzaugg/liferay-portal/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/blzaugg/liferay-portal/pulls/105/commits"},"statuses":{"href":"https://api.github.com/repos/blzaugg/liferay-portal/statuses/4542dc72b3610ee4dfae418f6529f444b50e1fb7"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":24,"additions":356947,"deletions":24767,"changed_files":71036}}