GitHub PullRequestReviewCommentEvent at 2014-12-23 15:07:48
Repository: assetic
Actor: stof
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/kriswallsmith/assetic/pulls/comments/22218104","id":22218104,"diff_hunk":"@@ -0,0 +1,48 @@\n+<?php\n+\n+/*\n+ * This file is part of the Assetic package, an OpenSky project.\n+ *\n+ * (c) 2010-2014 OpenSky Project Inc\n+ *\n+ * For the full copyright and license information, please view the LICENSE\n+ * file that was distributed with this source code.\n+ */\n+\n+namespace Assetic\\Test\\Asset\\Iterator;\n+\n+use Assetic\\Asset\\AssetReference;\n+use Assetic\\Asset\\FileAsset;\n+use Assetic\\Asset\\Iterator\\AssetCollectionIterator;\n+\n+class AssetCollectionTest extends \\PHPUnit_Framework_TestCase","path":"tests/Assetic/Test/Asset/Iterator/AssetCollectionIteratorTest.php","position":18,"original_position":18,"commit_id":"5a431d22eac8926fe442230c185099a6200fbc5b","original_commit_id":"5a431d22eac8926fe442230c185099a6200fbc5b","user":{"login":"stof","id":439401,"avatar_url":"https://avatars.githubusercontent.com/u/439401?v=3","gravatar_id":"","url":"https://api.github.com/users/stof","html_url":"https://github.com/stof","followers_url":"https://api.github.com/users/stof/followers","following_url":"https://api.github.com/users/stof/following{/other_user}","gists_url":"https://api.github.com/users/stof/gists{/gist_id}","starred_url":"https://api.github.com/users/stof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stof/subscriptions","organizations_url":"https://api.github.com/users/stof/orgs","repos_url":"https://api.github.com/users/stof/repos","events_url":"https://api.github.com/users/stof/events{/privacy}","received_events_url":"https://api.github.com/users/stof/received_events","type":"User","site_admin":false},"body":"the class name does not match the file name","created_at":"2014-12-23T15:07:48Z","updated_at":"2014-12-23T15:07:48Z","html_url":"https://github.com/kriswallsmith/assetic/pull/694#discussion_r22218104","pull_request_url":"https://api.github.com/repos/kriswallsmith/assetic/pulls/694","_links":{"self":{"href":"https://api.github.com/repos/kriswallsmith/assetic/pulls/comments/22218104"},"html":{"href":"https://github.com/kriswallsmith/assetic/pull/694#discussion_r22218104"},"pull_request":{"href":"https://api.github.com/repos/kriswallsmith/assetic/pulls/694"}}},"pull_request":{"url":"https://api.github.com/repos/kriswallsmith/assetic/pulls/694","id":26514419,"html_url":"https://github.com/kriswallsmith/assetic/pull/694","diff_url":"https://github.com/kriswallsmith/assetic/pull/694.diff","patch_url":"https://github.com/kriswallsmith/assetic/pull/694.patch","issue_url":"https://api.github.com/repos/kriswallsmith/assetic/issues/694","number":694,"state":"open","locked":false,"title":"optimize asset reference filenames","user":{"login":"deeky666","id":1411514,"avatar_url":"https://avatars.githubusercontent.com/u/1411514?v=3","gravatar_id":"","url":"https://api.github.com/users/deeky666","html_url":"https://github.com/deeky666","followers_url":"https://api.github.com/users/deeky666/followers","following_url":"https://api.github.com/users/deeky666/following{/other_user}","gists_url":"https://api.github.com/users/deeky666/gists{/gist_id}","starred_url":"https://api.github.com/users/deeky666/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deeky666/subscriptions","organizations_url":"https://api.github.com/users/deeky666/orgs","repos_url":"https://api.github.com/users/deeky666/repos","events_url":"https://api.github.com/users/deeky666/events{/privacy}","received_events_url":"https://api.github.com/users/deeky666/received_events","type":"User","site_admin":false},"body":"Currently asset references get dumped with generic filenames like `fb32317_part_1.js`, `fb32317_part_2.js` etc.\r\nUnfortunately these filenames don't tell you which asset reference they represent which would be very useful for debugging purposes IMO (especially when you have lots of assets).\r\nSo instead the asset reference name should be used instead of `part`: `fb32317_jquery_1.js`, `fb32317_bootstrap_2.js`.\r\n\r\nWhat do you think?","created_at":"2014-12-23T15:01:39Z","updated_at":"2014-12-23T15:07:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0c427a7b1910f46d1713eb3942345b517b320523","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kriswallsmith/assetic/pulls/694/commits","review_comments_url":"https://api.github.com/repos/kriswallsmith/assetic/pulls/694/comments","review_comment_url":"https://api.github.com/repos/kriswallsmith/assetic/pulls/comments/{number}","comments_url":"https://api.github.com/repos/kriswallsmith/assetic/issues/694/comments","statuses_url":"https://api.github.com/repos/kriswallsmith/assetic/statuses/5a431d22eac8926fe442230c185099a6200fbc5b","head":{"label":"deeky666:optimize-asset-reference-filenames","ref":"optimize-asset-reference-filenames","sha":"5a431d22eac8926fe442230c185099a6200fbc5b","user":{"login":"deeky666","id":1411514,"avatar_url":"https://avatars.githubusercontent.com/u/1411514?v=3","gravatar_id":"","url":"https://api.github.com/users/deeky666","html_url":"https://github.com/deeky666","followers_url":"https://api.github.com/users/deeky666/followers","following_url":"https://api.github.com/users/deeky666/following{/other_user}","gists_url":"https://api.github.com/users/deeky666/gists{/gist_id}","starred_url":"https://api.github.com/users/deeky666/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deeky666/subscriptions","organizations_url":"https://api.github.com/users/deeky666/orgs","repos_url":"https://api.github.com/users/deeky666/repos","events_url":"https://api.github.com/users/deeky666/events{/privacy}","received_events_url":"https://api.github.com/users/deeky666/received_events","type":"User","site_admin":false},"repo":{"id":28399251,"name":"assetic","full_name":"deeky666/assetic","owner":{"login":"deeky666","id":1411514,"avatar_url":"https://avatars.githubusercontent.com/u/1411514?v=3","gravatar_id":"","url":"https://api.github.com/users/deeky666","html_url":"https://github.com/deeky666","followers_url":"https://api.github.com/users/deeky666/followers","following_url":"https://api.github.com/users/deeky666/following{/other_user}","gists_url":"https://api.github.com/users/deeky666/gists{/gist_id}","starred_url":"https://api.github.com/users/deeky666/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deeky666/subscriptions","organizations_url":"https://api.github.com/users/deeky666/orgs","repos_url":"https://api.github.com/users/deeky666/repos","events_url":"https://api.github.com/users/deeky666/events{/privacy}","received_events_url":"https://api.github.com/users/deeky666/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/deeky666/assetic","description":"Asset Management for PHP","fork":true,"url":"https://api.github.com/repos/deeky666/assetic","forks_url":"https://api.github.com/repos/deeky666/assetic/forks","keys_url":"https://api.github.com/repos/deeky666/assetic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deeky666/assetic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deeky666/assetic/teams","hooks_url":"https://api.github.com/repos/deeky666/assetic/hooks","issue_events_url":"https://api.github.com/repos/deeky666/assetic/issues/events{/number}","events_url":"https://api.github.com/repos/deeky666/assetic/events","assignees_url":"https://api.github.com/repos/deeky666/assetic/assignees{/user}","branches_url":"https://api.github.com/repos/deeky666/assetic/branches{/branch}","tags_url":"https://api.github.com/repos/deeky666/assetic/tags","blobs_url":"https://api.github.com/repos/deeky666/assetic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deeky666/assetic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deeky666/assetic/git/refs{/sha}","trees_url":"https://api.github.com/repos/deeky666/assetic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deeky666/assetic/statuses/{sha}","languages_url":"https://api.github.com/repos/deeky666/assetic/languages","stargazers_url":"https://api.github.com/repos/deeky666/assetic/stargazers","contributors_url":"https://api.github.com/repos/deeky666/assetic/contributors","subscribers_url":"https://api.github.com/repos/deeky666/assetic/subscribers","subscription_url":"https://api.github.com/repos/deeky666/assetic/subscription","commits_url":"https://api.github.com/repos/deeky666/assetic/commits{/sha}","git_commits_url":"https://api.github.com/repos/deeky666/assetic/git/commits{/sha}","comments_url":"https://api.github.com/repos/deeky666/assetic/comments{/number}","issue_comment_url":"https://api.github.com/repos/deeky666/assetic/issues/comments/{number}","contents_url":"https://api.github.com/repos/deeky666/assetic/contents/{+path}","compare_url":"https://api.github.com/repos/deeky666/assetic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deeky666/assetic/merges","archive_url":"https://api.github.com/repos/deeky666/assetic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deeky666/assetic/downloads","issues_url":"https://api.github.com/repos/deeky666/assetic/issues{/number}","pulls_url":"https://api.github.com/repos/deeky666/assetic/pulls{/number}","milestones_url":"https://api.github.com/repos/deeky666/assetic/milestones{/number}","notifications_url":"https://api.github.com/repos/deeky666/assetic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deeky666/assetic/labels{/name}","releases_url":"https://api.github.com/repos/deeky666/assetic/releases{/id}","created_at":"2014-12-23T13:24:04Z","updated_at":"2014-12-23T13:24:05Z","pushed_at":"2014-12-23T15:01:30Z","git_url":"git://github.com/deeky666/assetic.git","ssh_url":"git@github.com:deeky666/assetic.git","clone_url":"https://github.com/deeky666/assetic.git","svn_url":"https://github.com/deeky666/assetic","homepage":"","size":5375,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kriswallsmith:master","ref":"master","sha":"bdd814c775a554522838c583af9e381f3a5cc95a","user":{"login":"kriswallsmith","id":33886,"avatar_url":"https://avatars.githubusercontent.com/u/33886?v=3","gravatar_id":"","url":"https://api.github.com/users/kriswallsmith","html_url":"https://github.com/kriswallsmith","followers_url":"https://api.github.com/users/kriswallsmith/followers","following_url":"https://api.github.com/users/kriswallsmith/following{/other_user}","gists_url":"https://api.github.com/users/kriswallsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/kriswallsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kriswallsmith/subscriptions","organizations_url":"https://api.github.com/users/kriswallsmith/orgs","repos_url":"https://api.github.com/users/kriswallsmith/repos","events_url":"https://api.github.com/users/kriswallsmith/events{/privacy}","received_events_url":"https://api.github.com/users/kriswallsmith/received_events","type":"User","site_admin":false},"repo":{"id":1238771,"name":"assetic","full_name":"kriswallsmith/assetic","owner":{"login":"kriswallsmith","id":33886,"avatar_url":"https://avatars.githubusercontent.com/u/33886?v=3","gravatar_id":"","url":"https://api.github.com/users/kriswallsmith","html_url":"https://github.com/kriswallsmith","followers_url":"https://api.github.com/users/kriswallsmith/followers","following_url":"https://api.github.com/users/kriswallsmith/following{/other_user}","gists_url":"https://api.github.com/users/kriswallsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/kriswallsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kriswallsmith/subscriptions","organizations_url":"https://api.github.com/users/kriswallsmith/orgs","repos_url":"https://api.github.com/users/kriswallsmith/repos","events_url":"https://api.github.com/users/kriswallsmith/events{/privacy}","received_events_url":"https://api.github.com/users/kriswallsmith/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kriswallsmith/assetic","description":"Asset Management for PHP","fork":false,"url":"https://api.github.com/repos/kriswallsmith/assetic","forks_url":"https://api.github.com/repos/kriswallsmith/assetic/forks","keys_url":"https://api.github.com/repos/kriswallsmith/assetic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kriswallsmith/assetic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kriswallsmith/assetic/teams","hooks_url":"https://api.github.com/repos/kriswallsmith/assetic/hooks","issue_events_url":"https://api.github.com/repos/kriswallsmith/assetic/issues/events{/number}","events_url":"https://api.github.com/repos/kriswallsmith/assetic/events","assignees_url":"https://api.github.com/repos/kriswallsmith/assetic/assignees{/user}","branches_url":"https://api.github.com/repos/kriswallsmith/assetic/branches{/branch}","tags_url":"https://api.github.com/repos/kriswallsmith/assetic/tags","blobs_url":"https://api.github.com/repos/kriswallsmith/assetic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kriswallsmith/assetic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kriswallsmith/assetic/git/refs{/sha}","trees_url":"https://api.github.com/repos/kriswallsmith/assetic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kriswallsmith/assetic/statuses/{sha}","languages_url":"https://api.github.com/repos/kriswallsmith/assetic/languages","stargazers_url":"https://api.github.com/repos/kriswallsmith/assetic/stargazers","contributors_url":"https://api.github.com/repos/kriswallsmith/assetic/contributors","subscribers_url":"https://api.github.com/repos/kriswallsmith/assetic/subscribers","subscription_url":"https://api.github.com/repos/kriswallsmith/assetic/subscription","commits_url":"https://api.github.com/repos/kriswallsmith/assetic/commits{/sha}","git_commits_url":"https://api.github.com/repos/kriswallsmith/assetic/git/commits{/sha}","comments_url":"https://api.github.com/repos/kriswallsmith/assetic/comments{/number}","issue_comment_url":"https://api.github.com/repos/kriswallsmith/assetic/issues/comments/{number}","contents_url":"https://api.github.com/repos/kriswallsmith/assetic/contents/{+path}","compare_url":"https://api.github.com/repos/kriswallsmith/assetic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kriswallsmith/assetic/merges","archive_url":"https://api.github.com/repos/kriswallsmith/assetic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kriswallsmith/assetic/downloads","issues_url":"https://api.github.com/repos/kriswallsmith/assetic/issues{/number}","pulls_url":"https://api.github.com/repos/kriswallsmith/assetic/pulls{/number}","milestones_url":"https://api.github.com/repos/kriswallsmith/assetic/milestones{/number}","notifications_url":"https://api.github.com/repos/kriswallsmith/assetic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kriswallsmith/assetic/labels{/name}","releases_url":"https://api.github.com/repos/kriswallsmith/assetic/releases{/id}","created_at":"2011-01-10T17:47:13Z","updated_at":"2014-12-23T10:45:44Z","pushed_at":"2014-12-17T11:34:04Z","git_url":"git://github.com/kriswallsmith/assetic.git","ssh_url":"git@github.com:kriswallsmith/assetic.git","clone_url":"https://github.com/kriswallsmith/assetic.git","svn_url":"https://github.com/kriswallsmith/assetic","homepage":"","size":5375,"stargazers_count":2800,"watchers_count":2800,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":478,"mirror_url":null,"open_issues_count":233,"forks":478,"open_issues":233,"watchers":2800,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kriswallsmith/assetic/pulls/694"},"html":{"href":"https://github.com/kriswallsmith/assetic/pull/694"},"issue":{"href":"https://api.github.com/repos/kriswallsmith/assetic/issues/694"},"comments":{"href":"https://api.github.com/repos/kriswallsmith/assetic/issues/694/comments"},"review_comments":{"href":"https://api.github.com/repos/kriswallsmith/assetic/pulls/694/comments"},"review_comment":{"href":"https://api.github.com/repos/kriswallsmith/assetic/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/kriswallsmith/assetic/pulls/694/commits"},"statuses":{"href":"https://api.github.com/repos/kriswallsmith/assetic/statuses/5a431d22eac8926fe442230c185099a6200fbc5b"}}}}