GitHub PullRequestEvent at 2014-07-10 07:25:27
Repository: matplotlib
Actor: mikofski
Payload: {"action":"opened","number":6,"pull_request":{"url":"https://api.github.com/repos/tacaswell/matplotlib/pulls/6","id":18204278,"html_url":"https://github.com/tacaswell/matplotlib/pull/6","diff_url":"https://github.com/tacaswell/matplotlib/pull/6.diff","patch_url":"https://github.com/tacaswell/matplotlib/pull/6.patch","issue_url":"https://api.github.com/repos/tacaswell/matplotlib/issues/6","number":6,"state":"open","title":"reverse changes to imports in embedding_webagg","user":{"login":"mikofski","id":1385621,"avatar_url":"https://avatars.githubusercontent.com/u/1385621?","gravatar_id":"155b46c9d301fa5a4c1a2a9ad4f2849e","url":"https://api.github.com/users/mikofski","html_url":"https://github.com/mikofski","followers_url":"https://api.github.com/users/mikofski/followers","following_url":"https://api.github.com/users/mikofski/following{/other_user}","gists_url":"https://api.github.com/users/mikofski/gists{/gist_id}","starred_url":"https://api.github.com/users/mikofski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikofski/subscriptions","organizations_url":"https://api.github.com/users/mikofski/orgs","repos_url":"https://api.github.com/users/mikofski/repos","events_url":"https://api.github.com/users/mikofski/events{/privacy}","received_events_url":"https://api.github.com/users/mikofski/received_events","type":"User","site_admin":false},"body":"As describted in #3204 and #3205, changes to `embedding_webagg.py` were not meant to be in this pull request.\r\n\r\nI tested this on Windows-7 (x64) and Ubuntu-14.14 in a virtualenv with [`e9c7dcb`](https://github.com/mikofski/matplotlib/commit/e9c7dcb6028492d7dd31a4034f122f6b50ecbfb9) installed by calling:\r\n\r\n    $ python ~/matplotlib/examples/user_interfaces/embedding_webagg.py\r\n\r\nPrior to the patch running `embedding_webagg.py` raised exceptions, because [`FigureManagerWebAgg.get_javascript()`](https://github.com/mikofski/matplotlib/blob/master/lib/matplotlib/backends/backend_webagg_core.py#L335) calls [`FigureCanvasWebAggCore.get_default_filetype()`](https://github.com/mikofski/matplotlib/blob/master/lib/matplotlib/backends/backend_webagg_core.py#L365) and [`FigureCanvasWebAggCore.get_supported_filetypes_grouped()`](https://github.com/mikofski/matplotlib/blob/master/lib/matplotlib/backends/backend_webagg_core.py#L357) as if they were class methods.","created_at":"2014-07-10T07:25:27Z","updated_at":"2014-07-10T07:25:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tacaswell/matplotlib/pulls/6/commits","review_comments_url":"https://api.github.com/repos/tacaswell/matplotlib/pulls/6/comments","review_comment_url":"https://api.github.com/repos/tacaswell/matplotlib/pulls/comments/{number}","comments_url":"https://api.github.com/repos/tacaswell/matplotlib/issues/6/comments","statuses_url":"https://api.github.com/repos/tacaswell/matplotlib/statuses/e9c7dcb6028492d7dd31a4034f122f6b50ecbfb9","head":{"label":"mikofski:webagg_fix","ref":"webagg_fix","sha":"e9c7dcb6028492d7dd31a4034f122f6b50ecbfb9","user":{"login":"mikofski","id":1385621,"avatar_url":"https://avatars.githubusercontent.com/u/1385621?","gravatar_id":"155b46c9d301fa5a4c1a2a9ad4f2849e","url":"https://api.github.com/users/mikofski","html_url":"https://github.com/mikofski","followers_url":"https://api.github.com/users/mikofski/followers","following_url":"https://api.github.com/users/mikofski/following{/other_user}","gists_url":"https://api.github.com/users/mikofski/gists{/gist_id}","starred_url":"https://api.github.com/users/mikofski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikofski/subscriptions","organizations_url":"https://api.github.com/users/mikofski/orgs","repos_url":"https://api.github.com/users/mikofski/repos","events_url":"https://api.github.com/users/mikofski/events{/privacy}","received_events_url":"https://api.github.com/users/mikofski/received_events","type":"User","site_admin":false},"repo":{"id":21681846,"name":"matplotlib","full_name":"mikofski/matplotlib","owner":{"login":"mikofski","id":1385621,"avatar_url":"https://avatars.githubusercontent.com/u/1385621?","gravatar_id":"155b46c9d301fa5a4c1a2a9ad4f2849e","url":"https://api.github.com/users/mikofski","html_url":"https://github.com/mikofski","followers_url":"https://api.github.com/users/mikofski/followers","following_url":"https://api.github.com/users/mikofski/following{/other_user}","gists_url":"https://api.github.com/users/mikofski/gists{/gist_id}","starred_url":"https://api.github.com/users/mikofski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikofski/subscriptions","organizations_url":"https://api.github.com/users/mikofski/orgs","repos_url":"https://api.github.com/users/mikofski/repos","events_url":"https://api.github.com/users/mikofski/events{/privacy}","received_events_url":"https://api.github.com/users/mikofski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mikofski/matplotlib","description":"matplotlib: plotting with Python","fork":true,"url":"https://api.github.com/repos/mikofski/matplotlib","forks_url":"https://api.github.com/repos/mikofski/matplotlib/forks","keys_url":"https://api.github.com/repos/mikofski/matplotlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mikofski/matplotlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mikofski/matplotlib/teams","hooks_url":"https://api.github.com/repos/mikofski/matplotlib/hooks","issue_events_url":"https://api.github.com/repos/mikofski/matplotlib/issues/events{/number}","events_url":"https://api.github.com/repos/mikofski/matplotlib/events","assignees_url":"https://api.github.com/repos/mikofski/matplotlib/assignees{/user}","branches_url":"https://api.github.com/repos/mikofski/matplotlib/branches{/branch}","tags_url":"https://api.github.com/repos/mikofski/matplotlib/tags","blobs_url":"https://api.github.com/repos/mikofski/matplotlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mikofski/matplotlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mikofski/matplotlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/mikofski/matplotlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mikofski/matplotlib/statuses/{sha}","languages_url":"https://api.github.com/repos/mikofski/matplotlib/languages","stargazers_url":"https://api.github.com/repos/mikofski/matplotlib/stargazers","contributors_url":"https://api.github.com/repos/mikofski/matplotlib/contributors","subscribers_url":"https://api.github.com/repos/mikofski/matplotlib/subscribers","subscription_url":"https://api.github.com/repos/mikofski/matplotlib/subscription","commits_url":"https://api.github.com/repos/mikofski/matplotlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/mikofski/matplotlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/mikofski/matplotlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/mikofski/matplotlib/issues/comments/{number}","contents_url":"https://api.github.com/repos/mikofski/matplotlib/contents/{+path}","compare_url":"https://api.github.com/repos/mikofski/matplotlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mikofski/matplotlib/merges","archive_url":"https://api.github.com/repos/mikofski/matplotlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mikofski/matplotlib/downloads","issues_url":"https://api.github.com/repos/mikofski/matplotlib/issues{/number}","pulls_url":"https://api.github.com/repos/mikofski/matplotlib/pulls{/number}","milestones_url":"https://api.github.com/repos/mikofski/matplotlib/milestones{/number}","notifications_url":"https://api.github.com/repos/mikofski/matplotlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mikofski/matplotlib/labels{/name}","releases_url":"https://api.github.com/repos/mikofski/matplotlib/releases{/id}","created_at":"2014-07-10T06:07:05Z","updated_at":"2014-07-10T02:19:41Z","pushed_at":"2014-07-10T06:51:35Z","git_url":"git://github.com/mikofski/matplotlib.git","ssh_url":"git@github.com:mikofski/matplotlib.git","clone_url":"https://github.com/mikofski/matplotlib.git","svn_url":"https://github.com/mikofski/matplotlib","homepage":"http://matplotlib.org/","size":225010,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tacaswell:webagg_fix","ref":"webagg_fix","sha":"61d3faf6db5ba6d6db5f6e06bac6447494c96ecc","user":{"login":"tacaswell","id":199813,"avatar_url":"https://avatars.githubusercontent.com/u/199813?","gravatar_id":"8744048060e5931c500d3c9d1ecb997e","url":"https://api.github.com/users/tacaswell","html_url":"https://github.com/tacaswell","followers_url":"https://api.github.com/users/tacaswell/followers","following_url":"https://api.github.com/users/tacaswell/following{/other_user}","gists_url":"https://api.github.com/users/tacaswell/gists{/gist_id}","starred_url":"https://api.github.com/users/tacaswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tacaswell/subscriptions","organizations_url":"https://api.github.com/users/tacaswell/orgs","repos_url":"https://api.github.com/users/tacaswell/repos","events_url":"https://api.github.com/users/tacaswell/events{/privacy}","received_events_url":"https://api.github.com/users/tacaswell/received_events","type":"User","site_admin":false},"repo":{"id":5345572,"name":"matplotlib","full_name":"tacaswell/matplotlib","owner":{"login":"tacaswell","id":199813,"avatar_url":"https://avatars.githubusercontent.com/u/199813?","gravatar_id":"8744048060e5931c500d3c9d1ecb997e","url":"https://api.github.com/users/tacaswell","html_url":"https://github.com/tacaswell","followers_url":"https://api.github.com/users/tacaswell/followers","following_url":"https://api.github.com/users/tacaswell/following{/other_user}","gists_url":"https://api.github.com/users/tacaswell/gists{/gist_id}","starred_url":"https://api.github.com/users/tacaswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tacaswell/subscriptions","organizations_url":"https://api.github.com/users/tacaswell/orgs","repos_url":"https://api.github.com/users/tacaswell/repos","events_url":"https://api.github.com/users/tacaswell/events{/privacy}","received_events_url":"https://api.github.com/users/tacaswell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tacaswell/matplotlib","description":"","fork":true,"url":"https://api.github.com/repos/tacaswell/matplotlib","forks_url":"https://api.github.com/repos/tacaswell/matplotlib/forks","keys_url":"https://api.github.com/repos/tacaswell/matplotlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tacaswell/matplotlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tacaswell/matplotlib/teams","hooks_url":"https://api.github.com/repos/tacaswell/matplotlib/hooks","issue_events_url":"https://api.github.com/repos/tacaswell/matplotlib/issues/events{/number}","events_url":"https://api.github.com/repos/tacaswell/matplotlib/events","assignees_url":"https://api.github.com/repos/tacaswell/matplotlib/assignees{/user}","branches_url":"https://api.github.com/repos/tacaswell/matplotlib/branches{/branch}","tags_url":"https://api.github.com/repos/tacaswell/matplotlib/tags","blobs_url":"https://api.github.com/repos/tacaswell/matplotlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tacaswell/matplotlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tacaswell/matplotlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/tacaswell/matplotlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tacaswell/matplotlib/statuses/{sha}","languages_url":"https://api.github.com/repos/tacaswell/matplotlib/languages","stargazers_url":"https://api.github.com/repos/tacaswell/matplotlib/stargazers","contributors_url":"https://api.github.com/repos/tacaswell/matplotlib/contributors","subscribers_url":"https://api.github.com/repos/tacaswell/matplotlib/subscribers","subscription_url":"https://api.github.com/repos/tacaswell/matplotlib/subscription","commits_url":"https://api.github.com/repos/tacaswell/matplotlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/tacaswell/matplotlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/tacaswell/matplotlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/tacaswell/matplotlib/issues/comments/{number}","contents_url":"https://api.github.com/repos/tacaswell/matplotlib/contents/{+path}","compare_url":"https://api.github.com/repos/tacaswell/matplotlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tacaswell/matplotlib/merges","archive_url":"https://api.github.com/repos/tacaswell/matplotlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tacaswell/matplotlib/downloads","issues_url":"https://api.github.com/repos/tacaswell/matplotlib/issues{/number}","pulls_url":"https://api.github.com/repos/tacaswell/matplotlib/pulls{/number}","milestones_url":"https://api.github.com/repos/tacaswell/matplotlib/milestones{/number}","notifications_url":"https://api.github.com/repos/tacaswell/matplotlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tacaswell/matplotlib/labels{/name}","releases_url":"https://api.github.com/repos/tacaswell/matplotlib/releases{/id}","created_at":"2012-08-08T18:19:38Z","updated_at":"2014-06-12T17:33:34Z","pushed_at":"2014-07-10T02:54:17Z","git_url":"git://github.com/tacaswell/matplotlib.git","ssh_url":"git@github.com:tacaswell/matplotlib.git","clone_url":"https://github.com/tacaswell/matplotlib.git","svn_url":"https://github.com/tacaswell/matplotlib","homepage":"","size":196507,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tacaswell/matplotlib/pulls/6"},"html":{"href":"https://github.com/tacaswell/matplotlib/pull/6"},"issue":{"href":"https://api.github.com/repos/tacaswell/matplotlib/issues/6"},"comments":{"href":"https://api.github.com/repos/tacaswell/matplotlib/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/tacaswell/matplotlib/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/tacaswell/matplotlib/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/tacaswell/matplotlib/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/tacaswell/matplotlib/statuses/e9c7dcb6028492d7dd31a4034f122f6b50ecbfb9"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}