GitHub PullRequestReviewCommentEvent at 2014-05-21 15:10:59
Repository: cryptography
Actor: alex
Payload: {"comment":{"url":"https://api.github.com/repos/pyca/cryptography/pulls/comments/12901193","id":12901193,"diff_hunk":"@@ -198,10 +206,18 @@ def _register_default_ciphers(self):\n         )\n \n     def create_symmetric_encryption_ctx(self, cipher, mode):\n-        return _CipherContext(self, cipher, mode, _CipherContext._ENCRYPT)\n+        if (isinstance(mode, CTR) and isinstance(cipher, AES)","path":"cryptography/hazmat/backends/openssl/backend.py","position":20,"original_position":20,"commit_id":"6e6ac23ad11bc1932b34d3013b39fc858a16a53e","original_commit_id":"6e6ac23ad11bc1932b34d3013b39fc858a16a53e","user":{"login":"alex","id":772,"avatar_url":"https://avatars.githubusercontent.com/u/772?","gravatar_id":"edcdfd5affb524e0f88ec1a00ed3fe5d","url":"https://api.github.com/users/alex","html_url":"https://github.com/alex","followers_url":"https://api.github.com/users/alex/followers","following_url":"https://api.github.com/users/alex/following{/other_user}","gists_url":"https://api.github.com/users/alex/gists{/gist_id}","starred_url":"https://api.github.com/users/alex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alex/subscriptions","organizations_url":"https://api.github.com/users/alex/orgs","repos_url":"https://api.github.com/users/alex/repos","events_url":"https://api.github.com/users/alex/events{/privacy}","received_events_url":"https://api.github.com/users/alex/received_events","type":"User","site_admin":false},"body":"Can we also add a test that asserts that AES-CTR is always available on\r\nOpenSSL.\r\n\r\n\r\nOn Wed, May 21, 2014 at 8:09 AM, Alex Stapleton <notifications@github.com>wrote:\r\n\r\n> In cryptography/hazmat/backends/openssl/backend.py:\r\n>\r\n> > @@ -198,10 +206,18 @@ def _register_default_ciphers(self):\r\n> >          )\r\n> >\r\n> >      def create_symmetric_encryption_ctx(self, cipher, mode):\r\n> > -        return _CipherContext(self, cipher, mode, _CipherContext._ENCRYPT)\r\n> > +        if (isinstance(mode, CTR) and isinstance(cipher, AES)\r\n>\r\n> Could use a comment explaining that this is due to OpenSSL 0.9.8?\r\n>\r\n> —\r\n> Reply to this email directly or view it on GitHub<https://github.com/pyca/cryptography/pull/1068/files#r12901118>\r\n> .\r\n>\r\n\r\n\r\n\r\n-- \r\n\"I disapprove of what you say, but I will defend to the death your right to\r\nsay it.\" -- Evelyn Beatrice Hall (summarizing Voltaire)\r\n\"The people's good is the highest law.\" -- Cicero\r\nGPG Key fingerprint: 125F 5C67 DFE9 4084","created_at":"2014-05-21T15:10:59Z","updated_at":"2014-05-21T15:10:59Z","html_url":"https://github.com/pyca/cryptography/pull/1068#discussion_r12901193","pull_request_url":"https://api.github.com/repos/pyca/cryptography/pulls/1068","_links":{"self":{"href":"https://api.github.com/repos/pyca/cryptography/pulls/comments/12901193"},"html":{"href":"https://github.com/pyca/cryptography/pull/1068#discussion_r12901193"},"pull_request":{"href":"https://api.github.com/repos/pyca/cryptography/pulls/1068"}}}}