GitHub PullRequestReviewCommentEvent at 2014-11-04 14:41:25
Repository: sumo_db
Actor: elvisinaka
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/inaka/sumo_db/pulls/comments/19805720","id":19805720,"diff_hunk":"@@ -0,0 +1,117 @@\n+-module(sumo_find_SUITE).\n+\n+-export([\n+         all/0,\n+         init_per_suite/1,\n+         end_per_suite/1\n+        ]).\n+\n+-export([\n+         find_sort_mysql/1,\n+         find_sort_mongo/1\n+        ]).\n+\n+-define(EXCLUDED_FUNS,\n+        [\n+         module_info,\n+         all,\n+         test,\n+         init_per_suite,\n+         end_per_suite,\n+         find_by_sort,\n+         find_all_sort\n+        ]).\n+\n+-type config() :: [{atom(), term()}].\n+\n+%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%\n+%% Common test\n+%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%\n+\n+-spec all() -> [atom()].\n+all() ->\n+  Exports = ?MODULE:module_info(exports),\n+  [F || {F, _} <- Exports, not lists:member(F, ?EXCLUDED_FUNS)].\n+\n+-spec init_per_suite(config()) -> config().\n+init_per_suite(Config) ->\n+  application:ensure_all_started(emysql),\n+  application:ensure_all_started(emongo),\n+  application:ensure_all_started(sumo_db),\n+\n+    Fun =\n+    fun (Module) ->\n+        sumo:create_schema(Module),\n+        sumo:delete_all(Module),\n+\n+        sumo:persist(Module, Module:new(\"A\", \"E\", 6)),\n+        sumo:persist(Module, Module:new(\"B\", \"D\", 3)),\n+        sumo:persist(Module, Module:new(\"C\", \"C\", 5)),\n+        sumo:persist(Module, Module:new(\"D\", \"B\", 4)),","path":"test/sumo_find_SUITE.erl","position":50,"original_position":50,"commit_id":"41e02964d17c325dedc79ae78594fca8c2b064a6","original_commit_id":"41e02964d17c325dedc79ae78594fca8c2b064a6","user":{"login":"elvisinaka","id":8136322,"avatar_url":"https://avatars.githubusercontent.com/u/8136322?v=2","gravatar_id":"","url":"https://api.github.com/users/elvisinaka","html_url":"https://github.com/elvisinaka","followers_url":"https://api.github.com/users/elvisinaka/followers","following_url":"https://api.github.com/users/elvisinaka/following{/other_user}","gists_url":"https://api.github.com/users/elvisinaka/gists{/gist_id}","starred_url":"https://api.github.com/users/elvisinaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elvisinaka/subscriptions","organizations_url":"https://api.github.com/users/elvisinaka/orgs","repos_url":"https://api.github.com/users/elvisinaka/repos","events_url":"https://api.github.com/users/elvisinaka/events{/privacy}","received_events_url":"https://api.github.com/users/elvisinaka/received_events","type":"User","site_admin":false},"body":"Remove the dynamic function call on line 50. Only modules that define callbacks should make dynamic calls.","created_at":"2014-11-04T14:41:25Z","updated_at":"2014-11-04T14:41:25Z","html_url":"https://github.com/inaka/sumo_db/pull/95#discussion_r19805720","pull_request_url":"https://api.github.com/repos/inaka/sumo_db/pulls/95","_links":{"self":{"href":"https://api.github.com/repos/inaka/sumo_db/pulls/comments/19805720"},"html":{"href":"https://github.com/inaka/sumo_db/pull/95#discussion_r19805720"},"pull_request":{"href":"https://api.github.com/repos/inaka/sumo_db/pulls/95"}}},"pull_request":{"url":"https://api.github.com/repos/inaka/sumo_db/pulls/95","id":23835649,"html_url":"https://github.com/inaka/sumo_db/pull/95","diff_url":"https://github.com/inaka/sumo_db/pull/95.diff","patch_url":"https://github.com/inaka/sumo_db/pull/95.patch","issue_url":"https://api.github.com/repos/inaka/sumo_db/issues/95","number":95,"state":"open","locked":false,"title":"[#21] Support for sorting asc/desc","user":{"login":"jfacorro","id":1522569,"avatar_url":"https://avatars.githubusercontent.com/u/1522569?v=2","gravatar_id":"","url":"https://api.github.com/users/jfacorro","html_url":"https://github.com/jfacorro","followers_url":"https://api.github.com/users/jfacorro/followers","following_url":"https://api.github.com/users/jfacorro/following{/other_user}","gists_url":"https://api.github.com/users/jfacorro/gists{/gist_id}","starred_url":"https://api.github.com/users/jfacorro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfacorro/subscriptions","organizations_url":"https://api.github.com/users/jfacorro/orgs","repos_url":"https://api.github.com/users/jfacorro/repos","events_url":"https://api.github.com/users/jfacorro/events{/privacy}","received_events_url":"https://api.github.com/users/jfacorro/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-11-04T14:41:22Z","updated_at":"2014-11-04T14:41:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3ba1b514e4a66ec522fd77c21e4436df44c1fc8c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/inaka/sumo_db/pulls/95/commits","review_comments_url":"https://api.github.com/repos/inaka/sumo_db/pulls/95/comments","review_comment_url":"https://api.github.com/repos/inaka/sumo_db/pulls/comments/{number}","comments_url":"https://api.github.com/repos/inaka/sumo_db/issues/95/comments","statuses_url":"https://api.github.com/repos/inaka/sumo_db/statuses/41e02964d17c325dedc79ae78594fca8c2b064a6","head":{"label":"inaka:jfacorro.21.order.asc.desc","ref":"jfacorro.21.order.asc.desc","sha":"41e02964d17c325dedc79ae78594fca8c2b064a6","user":{"login":"inaka","id":867053,"avatar_url":"https://avatars.githubusercontent.com/u/867053?v=2","gravatar_id":"","url":"https://api.github.com/users/inaka","html_url":"https://github.com/inaka","followers_url":"https://api.github.com/users/inaka/followers","following_url":"https://api.github.com/users/inaka/following{/other_user}","gists_url":"https://api.github.com/users/inaka/gists{/gist_id}","starred_url":"https://api.github.com/users/inaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inaka/subscriptions","organizations_url":"https://api.github.com/users/inaka/orgs","repos_url":"https://api.github.com/users/inaka/repos","events_url":"https://api.github.com/users/inaka/events{/privacy}","received_events_url":"https://api.github.com/users/inaka/received_events","type":"Organization","site_admin":false},"repo":{"id":11457919,"name":"sumo_db","full_name":"inaka/sumo_db","owner":{"login":"inaka","id":867053,"avatar_url":"https://avatars.githubusercontent.com/u/867053?v=2","gravatar_id":"","url":"https://api.github.com/users/inaka","html_url":"https://github.com/inaka","followers_url":"https://api.github.com/users/inaka/followers","following_url":"https://api.github.com/users/inaka/following{/other_user}","gists_url":"https://api.github.com/users/inaka/gists{/gist_id}","starred_url":"https://api.github.com/users/inaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inaka/subscriptions","organizations_url":"https://api.github.com/users/inaka/orgs","repos_url":"https://api.github.com/users/inaka/repos","events_url":"https://api.github.com/users/inaka/events{/privacy}","received_events_url":"https://api.github.com/users/inaka/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/inaka/sumo_db","description":"Erlang Persistency Framework","fork":false,"url":"https://api.github.com/repos/inaka/sumo_db","forks_url":"https://api.github.com/repos/inaka/sumo_db/forks","keys_url":"https://api.github.com/repos/inaka/sumo_db/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inaka/sumo_db/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inaka/sumo_db/teams","hooks_url":"https://api.github.com/repos/inaka/sumo_db/hooks","issue_events_url":"https://api.github.com/repos/inaka/sumo_db/issues/events{/number}","events_url":"https://api.github.com/repos/inaka/sumo_db/events","assignees_url":"https://api.github.com/repos/inaka/sumo_db/assignees{/user}","branches_url":"https://api.github.com/repos/inaka/sumo_db/branches{/branch}","tags_url":"https://api.github.com/repos/inaka/sumo_db/tags","blobs_url":"https://api.github.com/repos/inaka/sumo_db/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inaka/sumo_db/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inaka/sumo_db/git/refs{/sha}","trees_url":"https://api.github.com/repos/inaka/sumo_db/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inaka/sumo_db/statuses/{sha}","languages_url":"https://api.github.com/repos/inaka/sumo_db/languages","stargazers_url":"https://api.github.com/repos/inaka/sumo_db/stargazers","contributors_url":"https://api.github.com/repos/inaka/sumo_db/contributors","subscribers_url":"https://api.github.com/repos/inaka/sumo_db/subscribers","subscription_url":"https://api.github.com/repos/inaka/sumo_db/subscription","commits_url":"https://api.github.com/repos/inaka/sumo_db/commits{/sha}","git_commits_url":"https://api.github.com/repos/inaka/sumo_db/git/commits{/sha}","comments_url":"https://api.github.com/repos/inaka/sumo_db/comments{/number}","issue_comment_url":"https://api.github.com/repos/inaka/sumo_db/issues/comments/{number}","contents_url":"https://api.github.com/repos/inaka/sumo_db/contents/{+path}","compare_url":"https://api.github.com/repos/inaka/sumo_db/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inaka/sumo_db/merges","archive_url":"https://api.github.com/repos/inaka/sumo_db/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inaka/sumo_db/downloads","issues_url":"https://api.github.com/repos/inaka/sumo_db/issues{/number}","pulls_url":"https://api.github.com/repos/inaka/sumo_db/pulls{/number}","milestones_url":"https://api.github.com/repos/inaka/sumo_db/milestones{/number}","notifications_url":"https://api.github.com/repos/inaka/sumo_db/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inaka/sumo_db/labels{/name}","releases_url":"https://api.github.com/repos/inaka/sumo_db/releases{/id}","created_at":"2013-07-16T19:15:37Z","updated_at":"2014-10-30T20:05:00Z","pushed_at":"2014-11-04T14:39:55Z","git_url":"git://github.com/inaka/sumo_db.git","ssh_url":"git@github.com:inaka/sumo_db.git","clone_url":"https://github.com/inaka/sumo_db.git","svn_url":"https://github.com/inaka/sumo_db","homepage":"http://inaka.github.io/sumo_db/","size":1738,"stargazers_count":37,"watchers_count":37,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"open_issues_count":18,"forks":5,"open_issues":18,"watchers":37,"default_branch":"master"}},"base":{"label":"inaka:master","ref":"master","sha":"25248afdc6803823389b80d879c70ca02000acc6","user":{"login":"inaka","id":867053,"avatar_url":"https://avatars.githubusercontent.com/u/867053?v=2","gravatar_id":"","url":"https://api.github.com/users/inaka","html_url":"https://github.com/inaka","followers_url":"https://api.github.com/users/inaka/followers","following_url":"https://api.github.com/users/inaka/following{/other_user}","gists_url":"https://api.github.com/users/inaka/gists{/gist_id}","starred_url":"https://api.github.com/users/inaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inaka/subscriptions","organizations_url":"https://api.github.com/users/inaka/orgs","repos_url":"https://api.github.com/users/inaka/repos","events_url":"https://api.github.com/users/inaka/events{/privacy}","received_events_url":"https://api.github.com/users/inaka/received_events","type":"Organization","site_admin":false},"repo":{"id":11457919,"name":"sumo_db","full_name":"inaka/sumo_db","owner":{"login":"inaka","id":867053,"avatar_url":"https://avatars.githubusercontent.com/u/867053?v=2","gravatar_id":"","url":"https://api.github.com/users/inaka","html_url":"https://github.com/inaka","followers_url":"https://api.github.com/users/inaka/followers","following_url":"https://api.github.com/users/inaka/following{/other_user}","gists_url":"https://api.github.com/users/inaka/gists{/gist_id}","starred_url":"https://api.github.com/users/inaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inaka/subscriptions","organizations_url":"https://api.github.com/users/inaka/orgs","repos_url":"https://api.github.com/users/inaka/repos","events_url":"https://api.github.com/users/inaka/events{/privacy}","received_events_url":"https://api.github.com/users/inaka/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/inaka/sumo_db","description":"Erlang Persistency Framework","fork":false,"url":"https://api.github.com/repos/inaka/sumo_db","forks_url":"https://api.github.com/repos/inaka/sumo_db/forks","keys_url":"https://api.github.com/repos/inaka/sumo_db/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inaka/sumo_db/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inaka/sumo_db/teams","hooks_url":"https://api.github.com/repos/inaka/sumo_db/hooks","issue_events_url":"https://api.github.com/repos/inaka/sumo_db/issues/events{/number}","events_url":"https://api.github.com/repos/inaka/sumo_db/events","assignees_url":"https://api.github.com/repos/inaka/sumo_db/assignees{/user}","branches_url":"https://api.github.com/repos/inaka/sumo_db/branches{/branch}","tags_url":"https://api.github.com/repos/inaka/sumo_db/tags","blobs_url":"https://api.github.com/repos/inaka/sumo_db/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inaka/sumo_db/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inaka/sumo_db/git/refs{/sha}","trees_url":"https://api.github.com/repos/inaka/sumo_db/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inaka/sumo_db/statuses/{sha}","languages_url":"https://api.github.com/repos/inaka/sumo_db/languages","stargazers_url":"https://api.github.com/repos/inaka/sumo_db/stargazers","contributors_url":"https://api.github.com/repos/inaka/sumo_db/contributors","subscribers_url":"https://api.github.com/repos/inaka/sumo_db/subscribers","subscription_url":"https://api.github.com/repos/inaka/sumo_db/subscription","commits_url":"https://api.github.com/repos/inaka/sumo_db/commits{/sha}","git_commits_url":"https://api.github.com/repos/inaka/sumo_db/git/commits{/sha}","comments_url":"https://api.github.com/repos/inaka/sumo_db/comments{/number}","issue_comment_url":"https://api.github.com/repos/inaka/sumo_db/issues/comments/{number}","contents_url":"https://api.github.com/repos/inaka/sumo_db/contents/{+path}","compare_url":"https://api.github.com/repos/inaka/sumo_db/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inaka/sumo_db/merges","archive_url":"https://api.github.com/repos/inaka/sumo_db/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inaka/sumo_db/downloads","issues_url":"https://api.github.com/repos/inaka/sumo_db/issues{/number}","pulls_url":"https://api.github.com/repos/inaka/sumo_db/pulls{/number}","milestones_url":"https://api.github.com/repos/inaka/sumo_db/milestones{/number}","notifications_url":"https://api.github.com/repos/inaka/sumo_db/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inaka/sumo_db/labels{/name}","releases_url":"https://api.github.com/repos/inaka/sumo_db/releases{/id}","created_at":"2013-07-16T19:15:37Z","updated_at":"2014-10-30T20:05:00Z","pushed_at":"2014-11-04T14:39:55Z","git_url":"git://github.com/inaka/sumo_db.git","ssh_url":"git@github.com:inaka/sumo_db.git","clone_url":"https://github.com/inaka/sumo_db.git","svn_url":"https://github.com/inaka/sumo_db","homepage":"http://inaka.github.io/sumo_db/","size":1738,"stargazers_count":37,"watchers_count":37,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"open_issues_count":18,"forks":5,"open_issues":18,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/inaka/sumo_db/pulls/95"},"html":{"href":"https://github.com/inaka/sumo_db/pull/95"},"issue":{"href":"https://api.github.com/repos/inaka/sumo_db/issues/95"},"comments":{"href":"https://api.github.com/repos/inaka/sumo_db/issues/95/comments"},"review_comments":{"href":"https://api.github.com/repos/inaka/sumo_db/pulls/95/comments"},"review_comment":{"href":"https://api.github.com/repos/inaka/sumo_db/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/inaka/sumo_db/pulls/95/commits"},"statuses":{"href":"https://api.github.com/repos/inaka/sumo_db/statuses/41e02964d17c325dedc79ae78594fca8c2b064a6"}}}}