GitHub PullRequestEvent at 2014-04-06 19:09:10
Repository: cakephp
Actor: lorenzo
Payload: {"action":"closed","number":3002,"pull_request":{"url":"https://api.github.com/repos/cakephp/cakephp/pulls/3002","id":13423217,"html_url":"https://github.com/cakephp/cakephp/pull/3002","diff_url":"https://github.com/cakephp/cakephp/pull/3002.diff","patch_url":"https://github.com/cakephp/cakephp/pull/3002.patch","issue_url":"https://api.github.com/repos/cakephp/cakephp/issues/3002","number":3002,"state":"closed","title":"Allow chaining in the addCrumb method","user":{"login":"moberemk","id":2866757,"avatar_url":"https://avatars.githubusercontent.com/u/2866757?","gravatar_id":"f97b6acbed0f47cd6d2349cefd2a7466","url":"https://api.github.com/users/moberemk","html_url":"https://github.com/moberemk","followers_url":"https://api.github.com/users/moberemk/followers","following_url":"https://api.github.com/users/moberemk/following{/other_user}","gists_url":"https://api.github.com/users/moberemk/gists{/gist_id}","starred_url":"https://api.github.com/users/moberemk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moberemk/subscriptions","organizations_url":"https://api.github.com/users/moberemk/orgs","repos_url":"https://api.github.com/users/moberemk/repos","events_url":"https://api.github.com/users/moberemk/events{/privacy}","received_events_url":"https://api.github.com/users/moberemk/received_events","type":"User","site_admin":false},"body":"For convenience I think it might be valuable to allow addCrumb (and possibly other similar functions) to return $this to permit chained calls such as this:\r\n\r\n    $this->Html->addCrumb('Admin', '/admin')->addCrumb('Blogs', '/admin/users')->addCrumb('Add');\r\n\r\nas opposed to the considerably more verbose version that needs to be used now:\r\n\r\n    $this->Html->addCrumb('Admin', '/admin');\r\n    $this->Html->addCrumb('Blogs', '/admin/users');\r\n    $this->Html->addCrumb('Add');\r\n\r\nI'm not sure if this violates some API conventions for helpers but it does seem rather more convenient to work with to me.","created_at":"2014-03-11T14:38:01Z","updated_at":"2014-04-06T19:09:10Z","closed_at":"2014-04-06T19:09:10Z","merged_at":"2014-04-06T19:09:10Z","merge_commit_sha":"f6608519fb04ea068190a8434a2a3f157029d9cd","assignee":null,"milestone":{"url":"https://api.github.com/repos/cakephp/cakephp/milestones/3","labels_url":"https://api.github.com/repos/cakephp/cakephp/milestones/3/labels","id":453024,"number":3,"title":"2.5.0","description":"Backwards compatible enhancements and improvements to the 2.x release series.\r\n\r\nSee [the roadmap](https://github.com/cakephp/cakephp/wiki/2.5-roadmap) for additional information.","creator":{"login":"lh-import","id":5175817,"avatar_url":"https://avatars.githubusercontent.com/u/5175817?","gravatar_id":"4ef95846cf708177ecfcec8a92325b95","url":"https://api.github.com/users/lh-import","html_url":"https://github.com/lh-import","followers_url":"https://api.github.com/users/lh-import/followers","following_url":"https://api.github.com/users/lh-import/following{/other_user}","gists_url":"https://api.github.com/users/lh-import/gists{/gist_id}","starred_url":"https://api.github.com/users/lh-import/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lh-import/subscriptions","organizations_url":"https://api.github.com/users/lh-import/orgs","repos_url":"https://api.github.com/users/lh-import/repos","events_url":"https://api.github.com/users/lh-import/events{/privacy}","received_events_url":"https://api.github.com/users/lh-import/received_events","type":"User","site_admin":false},"open_issues":16,"closed_issues":62,"state":"open","created_at":"2013-10-11T20:37:53Z","updated_at":"2014-04-06T19:09:10Z","due_on":"2014-04-06T07:00:00Z"},"commits_url":"https://api.github.com/repos/cakephp/cakephp/pulls/3002/commits","review_comments_url":"https://api.github.com/repos/cakephp/cakephp/pulls/3002/comments","review_comment_url":"https://api.github.com/repos/cakephp/cakephp/pulls/comments/{number}","comments_url":"https://api.github.com/repos/cakephp/cakephp/issues/3002/comments","statuses_url":"https://api.github.com/repos/cakephp/cakephp/statuses/3f7eff18436c7900c563362d9218cf1351422c68","head":{"label":"moberemk:patch-2","ref":"patch-2","sha":"3f7eff18436c7900c563362d9218cf1351422c68","user":{"login":"moberemk","id":2866757,"avatar_url":"https://avatars.githubusercontent.com/u/2866757?","gravatar_id":"f97b6acbed0f47cd6d2349cefd2a7466","url":"https://api.github.com/users/moberemk","html_url":"https://github.com/moberemk","followers_url":"https://api.github.com/users/moberemk/followers","following_url":"https://api.github.com/users/moberemk/following{/other_user}","gists_url":"https://api.github.com/users/moberemk/gists{/gist_id}","starred_url":"https://api.github.com/users/moberemk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moberemk/subscriptions","organizations_url":"https://api.github.com/users/moberemk/orgs","repos_url":"https://api.github.com/users/moberemk/repos","events_url":"https://api.github.com/users/moberemk/events{/privacy}","received_events_url":"https://api.github.com/users/moberemk/received_events","type":"User","site_admin":false},"repo":{"id":12166838,"name":"cakephp","full_name":"moberemk/cakephp","owner":{"login":"moberemk","id":2866757,"avatar_url":"https://avatars.githubusercontent.com/u/2866757?","gravatar_id":"f97b6acbed0f47cd6d2349cefd2a7466","url":"https://api.github.com/users/moberemk","html_url":"https://github.com/moberemk","followers_url":"https://api.github.com/users/moberemk/followers","following_url":"https://api.github.com/users/moberemk/following{/other_user}","gists_url":"https://api.github.com/users/moberemk/gists{/gist_id}","starred_url":"https://api.github.com/users/moberemk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moberemk/subscriptions","organizations_url":"https://api.github.com/users/moberemk/orgs","repos_url":"https://api.github.com/users/moberemk/repos","events_url":"https://api.github.com/users/moberemk/events{/privacy}","received_events_url":"https://api.github.com/users/moberemk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/moberemk/cakephp","description":"CakePHP: The Rapid Development Framework for PHP - Official Repository","fork":true,"url":"https://api.github.com/repos/moberemk/cakephp","forks_url":"https://api.github.com/repos/moberemk/cakephp/forks","keys_url":"https://api.github.com/repos/moberemk/cakephp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moberemk/cakephp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moberemk/cakephp/teams","hooks_url":"https://api.github.com/repos/moberemk/cakephp/hooks","issue_events_url":"https://api.github.com/repos/moberemk/cakephp/issues/events{/number}","events_url":"https://api.github.com/repos/moberemk/cakephp/events","assignees_url":"https://api.github.com/repos/moberemk/cakephp/assignees{/user}","branches_url":"https://api.github.com/repos/moberemk/cakephp/branches{/branch}","tags_url":"https://api.github.com/repos/moberemk/cakephp/tags","blobs_url":"https://api.github.com/repos/moberemk/cakephp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moberemk/cakephp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moberemk/cakephp/git/refs{/sha}","trees_url":"https://api.github.com/repos/moberemk/cakephp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moberemk/cakephp/statuses/{sha}","languages_url":"https://api.github.com/repos/moberemk/cakephp/languages","stargazers_url":"https://api.github.com/repos/moberemk/cakephp/stargazers","contributors_url":"https://api.github.com/repos/moberemk/cakephp/contributors","subscribers_url":"https://api.github.com/repos/moberemk/cakephp/subscribers","subscription_url":"https://api.github.com/repos/moberemk/cakephp/subscription","commits_url":"https://api.github.com/repos/moberemk/cakephp/commits{/sha}","git_commits_url":"https://api.github.com/repos/moberemk/cakephp/git/commits{/sha}","comments_url":"https://api.github.com/repos/moberemk/cakephp/comments{/number}","issue_comment_url":"https://api.github.com/repos/moberemk/cakephp/issues/comments/{number}","contents_url":"https://api.github.com/repos/moberemk/cakephp/contents/{+path}","compare_url":"https://api.github.com/repos/moberemk/cakephp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moberemk/cakephp/merges","archive_url":"https://api.github.com/repos/moberemk/cakephp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moberemk/cakephp/downloads","issues_url":"https://api.github.com/repos/moberemk/cakephp/issues{/number}","pulls_url":"https://api.github.com/repos/moberemk/cakephp/pulls{/number}","milestones_url":"https://api.github.com/repos/moberemk/cakephp/milestones{/number}","notifications_url":"https://api.github.com/repos/moberemk/cakephp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moberemk/cakephp/labels{/name}","releases_url":"https://api.github.com/repos/moberemk/cakephp/releases{/id}","created_at":"2013-08-16T19:51:53Z","updated_at":"2014-04-06T19:09:10Z","pushed_at":"2014-03-12T12:59:12Z","git_url":"git://github.com/moberemk/cakephp.git","ssh_url":"git@github.com:moberemk/cakephp.git","clone_url":"https://github.com/moberemk/cakephp.git","svn_url":"https://github.com/moberemk/cakephp","homepage":"http://cakephp.org","size":46421,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"cakephp:master","ref":"master","sha":"c0ac61117e041b3d832454d38e5ddf66e9f33065","user":{"login":"cakephp","id":23666,"avatar_url":"https://avatars.githubusercontent.com/u/23666?","gravatar_id":"12cd092be901674cdbf0d3d964e945d5","url":"https://api.github.com/users/cakephp","html_url":"https://github.com/cakephp","followers_url":"https://api.github.com/users/cakephp/followers","following_url":"https://api.github.com/users/cakephp/following{/other_user}","gists_url":"https://api.github.com/users/cakephp/gists{/gist_id}","starred_url":"https://api.github.com/users/cakephp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cakephp/subscriptions","organizations_url":"https://api.github.com/users/cakephp/orgs","repos_url":"https://api.github.com/users/cakephp/repos","events_url":"https://api.github.com/users/cakephp/events{/privacy}","received_events_url":"https://api.github.com/users/cakephp/received_events","type":"Organization","site_admin":false},"repo":{"id":656494,"name":"cakephp","full_name":"cakephp/cakephp","owner":{"login":"cakephp","id":23666,"avatar_url":"https://avatars.githubusercontent.com/u/23666?","gravatar_id":"12cd092be901674cdbf0d3d964e945d5","url":"https://api.github.com/users/cakephp","html_url":"https://github.com/cakephp","followers_url":"https://api.github.com/users/cakephp/followers","following_url":"https://api.github.com/users/cakephp/following{/other_user}","gists_url":"https://api.github.com/users/cakephp/gists{/gist_id}","starred_url":"https://api.github.com/users/cakephp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cakephp/subscriptions","organizations_url":"https://api.github.com/users/cakephp/orgs","repos_url":"https://api.github.com/users/cakephp/repos","events_url":"https://api.github.com/users/cakephp/events{/privacy}","received_events_url":"https://api.github.com/users/cakephp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cakephp/cakephp","description":"CakePHP: The Rapid Development Framework for PHP - Official Repository","fork":false,"url":"https://api.github.com/repos/cakephp/cakephp","forks_url":"https://api.github.com/repos/cakephp/cakephp/forks","keys_url":"https://api.github.com/repos/cakephp/cakephp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cakephp/cakephp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cakephp/cakephp/teams","hooks_url":"https://api.github.com/repos/cakephp/cakephp/hooks","issue_events_url":"https://api.github.com/repos/cakephp/cakephp/issues/events{/number}","events_url":"https://api.github.com/repos/cakephp/cakephp/events","assignees_url":"https://api.github.com/repos/cakephp/cakephp/assignees{/user}","branches_url":"https://api.github.com/repos/cakephp/cakephp/branches{/branch}","tags_url":"https://api.github.com/repos/cakephp/cakephp/tags","blobs_url":"https://api.github.com/repos/cakephp/cakephp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cakephp/cakephp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cakephp/cakephp/git/refs{/sha}","trees_url":"https://api.github.com/repos/cakephp/cakephp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cakephp/cakephp/statuses/{sha}","languages_url":"https://api.github.com/repos/cakephp/cakephp/languages","stargazers_url":"https://api.github.com/repos/cakephp/cakephp/stargazers","contributors_url":"https://api.github.com/repos/cakephp/cakephp/contributors","subscribers_url":"https://api.github.com/repos/cakephp/cakephp/subscribers","subscription_url":"https://api.github.com/repos/cakephp/cakephp/subscription","commits_url":"https://api.github.com/repos/cakephp/cakephp/commits{/sha}","git_commits_url":"https://api.github.com/repos/cakephp/cakephp/git/commits{/sha}","comments_url":"https://api.github.com/repos/cakephp/cakephp/comments{/number}","issue_comment_url":"https://api.github.com/repos/cakephp/cakephp/issues/comments/{number}","contents_url":"https://api.github.com/repos/cakephp/cakephp/contents/{+path}","compare_url":"https://api.github.com/repos/cakephp/cakephp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cakephp/cakephp/merges","archive_url":"https://api.github.com/repos/cakephp/cakephp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cakephp/cakephp/downloads","issues_url":"https://api.github.com/repos/cakephp/cakephp/issues{/number}","pulls_url":"https://api.github.com/repos/cakephp/cakephp/pulls{/number}","milestones_url":"https://api.github.com/repos/cakephp/cakephp/milestones{/number}","notifications_url":"https://api.github.com/repos/cakephp/cakephp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cakephp/cakephp/labels{/name}","releases_url":"https://api.github.com/repos/cakephp/cakephp/releases{/id}","created_at":"2010-05-08T14:38:22Z","updated_at":"2014-04-06T19:09:10Z","pushed_at":"2014-04-06T19:09:10Z","git_url":"git://github.com/cakephp/cakephp.git","ssh_url":"git@github.com:cakephp/cakephp.git","clone_url":"https://github.com/cakephp/cakephp.git","svn_url":"https://github.com/cakephp/cakephp","homepage":"http://cakephp.org","size":120702,"stargazers_count":4647,"watchers_count":4647,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1912,"mirror_url":null,"open_issues_count":198,"forks":1912,"open_issues":198,"watchers":4647,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/3002"},"html":{"href":"https://github.com/cakephp/cakephp/pull/3002"},"issue":{"href":"https://api.github.com/repos/cakephp/cakephp/issues/3002"},"comments":{"href":"https://api.github.com/repos/cakephp/cakephp/issues/3002/comments"},"review_comments":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/3002/comments"},"review_comment":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/3002/commits"},"statuses":{"href":"https://api.github.com/repos/cakephp/cakephp/statuses/3f7eff18436c7900c563362d9218cf1351422c68"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"lorenzo","id":37621,"avatar_url":"https://avatars.githubusercontent.com/u/37621?","gravatar_id":"5b883d5e78e97a9cf371e0c9b458dc72","url":"https://api.github.com/users/lorenzo","html_url":"https://github.com/lorenzo","followers_url":"https://api.github.com/users/lorenzo/followers","following_url":"https://api.github.com/users/lorenzo/following{/other_user}","gists_url":"https://api.github.com/users/lorenzo/gists{/gist_id}","starred_url":"https://api.github.com/users/lorenzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lorenzo/subscriptions","organizations_url":"https://api.github.com/users/lorenzo/orgs","repos_url":"https://api.github.com/users/lorenzo/repos","events_url":"https://api.github.com/users/lorenzo/events{/privacy}","received_events_url":"https://api.github.com/users/lorenzo/received_events","type":"User","site_admin":false},"comments":19,"review_comments":3,"commits":2,"additions":2,"deletions":1,"changed_files":1}}