GitHub PullRequestEvent at 2014-10-03 21:27:39
Repository: jetty-alpn
Actor: Scottmitch
Payload: {"action":"closed","number":3,"pull_request":{"url":"https://api.github.com/repos/jetty-project/jetty-alpn/pulls/3","id":22231064,"html_url":"https://github.com/jetty-project/jetty-alpn/pull/3","diff_url":"https://github.com/jetty-project/jetty-alpn/pull/3.diff","patch_url":"https://github.com/jetty-project/jetty-alpn/pull/3.patch","issue_url":"https://api.github.com/repos/jetty-project/jetty-alpn/issues/3","number":3,"state":"closed","locked":false,"title":"Fail SSL Handshake if no supported Application Protocols","user":{"login":"Scottmitch","id":7562868,"avatar_url":"https://avatars.githubusercontent.com/u/7562868?v=2","gravatar_id":"","url":"https://api.github.com/users/Scottmitch","html_url":"https://github.com/Scottmitch","followers_url":"https://api.github.com/users/Scottmitch/followers","following_url":"https://api.github.com/users/Scottmitch/following{/other_user}","gists_url":"https://api.github.com/users/Scottmitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Scottmitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Scottmitch/subscriptions","organizations_url":"https://api.github.com/users/Scottmitch/orgs","repos_url":"https://api.github.com/users/Scottmitch/repos","events_url":"https://api.github.com/users/Scottmitch/events{/privacy}","received_events_url":"https://api.github.com/users/Scottmitch/received_events","type":"User","site_admin":false},"body":"Motiviation:\r\njetty-alpn does not support the no_application_protocol alert as defined in http://tools.ietf.org/html/rfc7301#section-3.2.  This should be supported to fail the handshake if there are no supported protocols found.\r\n\r\nModifications:\r\n-Allow ALPN.ServerProvider.select to return null.\r\n-ALPN.ServerProvider.select will be handled by ServerHandshaker.java as a fatal handshake error\r\n-Add an Alerts.java to provide the missing alert_no_application_protocol definition\r\n-Add unit tests to test this case\r\n\r\nResult:\r\n-jetty-boot supports no_application_protocol alert as defined in http://tools.ietf.org/html/rfc7301#section-3.2","created_at":"2014-10-03T21:26:46Z","updated_at":"2014-10-03T21:27:38Z","closed_at":"2014-10-03T21:27:38Z","merged_at":null,"merge_commit_sha":"403ac04ddc5b7b5e3d922dacb7b2c093846779ef","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jetty-project/jetty-alpn/pulls/3/commits","review_comments_url":"https://api.github.com/repos/jetty-project/jetty-alpn/pulls/3/comments","review_comment_url":"https://api.github.com/repos/jetty-project/jetty-alpn/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jetty-project/jetty-alpn/issues/3/comments","statuses_url":"https://api.github.com/repos/jetty-project/jetty-alpn/statuses/32ac0ed47ef196d831544d5cf4704688b3bba171","head":{"label":"akamai:no_application_protocol","ref":"no_application_protocol","sha":"32ac0ed47ef196d831544d5cf4704688b3bba171","user":{"login":"akamai","id":7504551,"avatar_url":"https://avatars.githubusercontent.com/u/7504551?v=2","gravatar_id":"","url":"https://api.github.com/users/akamai","html_url":"https://github.com/akamai","followers_url":"https://api.github.com/users/akamai/followers","following_url":"https://api.github.com/users/akamai/following{/other_user}","gists_url":"https://api.github.com/users/akamai/gists{/gist_id}","starred_url":"https://api.github.com/users/akamai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akamai/subscriptions","organizations_url":"https://api.github.com/users/akamai/orgs","repos_url":"https://api.github.com/users/akamai/repos","events_url":"https://api.github.com/users/akamai/events{/privacy}","received_events_url":"https://api.github.com/users/akamai/received_events","type":"Organization","site_admin":false},"repo":{"id":24774143,"name":"jetty-alpn","full_name":"akamai/jetty-alpn","owner":{"login":"akamai","id":7504551,"avatar_url":"https://avatars.githubusercontent.com/u/7504551?v=2","gravatar_id":"","url":"https://api.github.com/users/akamai","html_url":"https://github.com/akamai","followers_url":"https://api.github.com/users/akamai/followers","following_url":"https://api.github.com/users/akamai/following{/other_user}","gists_url":"https://api.github.com/users/akamai/gists{/gist_id}","starred_url":"https://api.github.com/users/akamai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akamai/subscriptions","organizations_url":"https://api.github.com/users/akamai/orgs","repos_url":"https://api.github.com/users/akamai/repos","events_url":"https://api.github.com/users/akamai/events{/privacy}","received_events_url":"https://api.github.com/users/akamai/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akamai/jetty-alpn","description":"Implementation of ALPN (Application Layer Protocol Negotiation) Specification for OpenJDK 7 or greater","fork":true,"url":"https://api.github.com/repos/akamai/jetty-alpn","forks_url":"https://api.github.com/repos/akamai/jetty-alpn/forks","keys_url":"https://api.github.com/repos/akamai/jetty-alpn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akamai/jetty-alpn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akamai/jetty-alpn/teams","hooks_url":"https://api.github.com/repos/akamai/jetty-alpn/hooks","issue_events_url":"https://api.github.com/repos/akamai/jetty-alpn/issues/events{/number}","events_url":"https://api.github.com/repos/akamai/jetty-alpn/events","assignees_url":"https://api.github.com/repos/akamai/jetty-alpn/assignees{/user}","branches_url":"https://api.github.com/repos/akamai/jetty-alpn/branches{/branch}","tags_url":"https://api.github.com/repos/akamai/jetty-alpn/tags","blobs_url":"https://api.github.com/repos/akamai/jetty-alpn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akamai/jetty-alpn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akamai/jetty-alpn/git/refs{/sha}","trees_url":"https://api.github.com/repos/akamai/jetty-alpn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akamai/jetty-alpn/statuses/{sha}","languages_url":"https://api.github.com/repos/akamai/jetty-alpn/languages","stargazers_url":"https://api.github.com/repos/akamai/jetty-alpn/stargazers","contributors_url":"https://api.github.com/repos/akamai/jetty-alpn/contributors","subscribers_url":"https://api.github.com/repos/akamai/jetty-alpn/subscribers","subscription_url":"https://api.github.com/repos/akamai/jetty-alpn/subscription","commits_url":"https://api.github.com/repos/akamai/jetty-alpn/commits{/sha}","git_commits_url":"https://api.github.com/repos/akamai/jetty-alpn/git/commits{/sha}","comments_url":"https://api.github.com/repos/akamai/jetty-alpn/comments{/number}","issue_comment_url":"https://api.github.com/repos/akamai/jetty-alpn/issues/comments/{number}","contents_url":"https://api.github.com/repos/akamai/jetty-alpn/contents/{+path}","compare_url":"https://api.github.com/repos/akamai/jetty-alpn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akamai/jetty-alpn/merges","archive_url":"https://api.github.com/repos/akamai/jetty-alpn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akamai/jetty-alpn/downloads","issues_url":"https://api.github.com/repos/akamai/jetty-alpn/issues{/number}","pulls_url":"https://api.github.com/repos/akamai/jetty-alpn/pulls{/number}","milestones_url":"https://api.github.com/repos/akamai/jetty-alpn/milestones{/number}","notifications_url":"https://api.github.com/repos/akamai/jetty-alpn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akamai/jetty-alpn/labels{/name}","releases_url":"https://api.github.com/repos/akamai/jetty-alpn/releases{/id}","created_at":"2014-10-03T21:19:32Z","updated_at":"2014-06-11T23:49:31Z","pushed_at":"2014-10-03T21:26:28Z","git_url":"git://github.com/akamai/jetty-alpn.git","ssh_url":"git@github.com:akamai/jetty-alpn.git","clone_url":"https://github.com/akamai/jetty-alpn.git","svn_url":"https://github.com/akamai/jetty-alpn","homepage":null,"size":272,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jetty-project:master","ref":"master","sha":"2159406e7f1a6255b4bc5bbe1824d7ef04a7bc72","user":{"login":"jetty-project","id":903858,"avatar_url":"https://avatars.githubusercontent.com/u/903858?v=2","gravatar_id":"","url":"https://api.github.com/users/jetty-project","html_url":"https://github.com/jetty-project","followers_url":"https://api.github.com/users/jetty-project/followers","following_url":"https://api.github.com/users/jetty-project/following{/other_user}","gists_url":"https://api.github.com/users/jetty-project/gists{/gist_id}","starred_url":"https://api.github.com/users/jetty-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jetty-project/subscriptions","organizations_url":"https://api.github.com/users/jetty-project/orgs","repos_url":"https://api.github.com/users/jetty-project/repos","events_url":"https://api.github.com/users/jetty-project/events{/privacy}","received_events_url":"https://api.github.com/users/jetty-project/received_events","type":"Organization","site_admin":false},"repo":{"id":17845280,"name":"jetty-alpn","full_name":"jetty-project/jetty-alpn","owner":{"login":"jetty-project","id":903858,"avatar_url":"https://avatars.githubusercontent.com/u/903858?v=2","gravatar_id":"","url":"https://api.github.com/users/jetty-project","html_url":"https://github.com/jetty-project","followers_url":"https://api.github.com/users/jetty-project/followers","following_url":"https://api.github.com/users/jetty-project/following{/other_user}","gists_url":"https://api.github.com/users/jetty-project/gists{/gist_id}","starred_url":"https://api.github.com/users/jetty-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jetty-project/subscriptions","organizations_url":"https://api.github.com/users/jetty-project/orgs","repos_url":"https://api.github.com/users/jetty-project/repos","events_url":"https://api.github.com/users/jetty-project/events{/privacy}","received_events_url":"https://api.github.com/users/jetty-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jetty-project/jetty-alpn","description":"Implementation of ALPN (Application Layer Protocol Negotiation) Specification for OpenJDK 7 or greater","fork":false,"url":"https://api.github.com/repos/jetty-project/jetty-alpn","forks_url":"https://api.github.com/repos/jetty-project/jetty-alpn/forks","keys_url":"https://api.github.com/repos/jetty-project/jetty-alpn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jetty-project/jetty-alpn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jetty-project/jetty-alpn/teams","hooks_url":"https://api.github.com/repos/jetty-project/jetty-alpn/hooks","issue_events_url":"https://api.github.com/repos/jetty-project/jetty-alpn/issues/events{/number}","events_url":"https://api.github.com/repos/jetty-project/jetty-alpn/events","assignees_url":"https://api.github.com/repos/jetty-project/jetty-alpn/assignees{/user}","branches_url":"https://api.github.com/repos/jetty-project/jetty-alpn/branches{/branch}","tags_url":"https://api.github.com/repos/jetty-project/jetty-alpn/tags","blobs_url":"https://api.github.com/repos/jetty-project/jetty-alpn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jetty-project/jetty-alpn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jetty-project/jetty-alpn/git/refs{/sha}","trees_url":"https://api.github.com/repos/jetty-project/jetty-alpn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jetty-project/jetty-alpn/statuses/{sha}","languages_url":"https://api.github.com/repos/jetty-project/jetty-alpn/languages","stargazers_url":"https://api.github.com/repos/jetty-project/jetty-alpn/stargazers","contributors_url":"https://api.github.com/repos/jetty-project/jetty-alpn/contributors","subscribers_url":"https://api.github.com/repos/jetty-project/jetty-alpn/subscribers","subscription_url":"https://api.github.com/repos/jetty-project/jetty-alpn/subscription","commits_url":"https://api.github.com/repos/jetty-project/jetty-alpn/commits{/sha}","git_commits_url":"https://api.github.com/repos/jetty-project/jetty-alpn/git/commits{/sha}","comments_url":"https://api.github.com/repos/jetty-project/jetty-alpn/comments{/number}","issue_comment_url":"https://api.github.com/repos/jetty-project/jetty-alpn/issues/comments/{number}","contents_url":"https://api.github.com/repos/jetty-project/jetty-alpn/contents/{+path}","compare_url":"https://api.github.com/repos/jetty-project/jetty-alpn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jetty-project/jetty-alpn/merges","archive_url":"https://api.github.com/repos/jetty-project/jetty-alpn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jetty-project/jetty-alpn/downloads","issues_url":"https://api.github.com/repos/jetty-project/jetty-alpn/issues{/number}","pulls_url":"https://api.github.com/repos/jetty-project/jetty-alpn/pulls{/number}","milestones_url":"https://api.github.com/repos/jetty-project/jetty-alpn/milestones{/number}","notifications_url":"https://api.github.com/repos/jetty-project/jetty-alpn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jetty-project/jetty-alpn/labels{/name}","releases_url":"https://api.github.com/repos/jetty-project/jetty-alpn/releases{/id}","created_at":"2014-03-17T22:14:32Z","updated_at":"2014-06-11T23:49:31Z","pushed_at":"2014-04-17T11:49:27Z","git_url":"git://github.com/jetty-project/jetty-alpn.git","ssh_url":"git@github.com:jetty-project/jetty-alpn.git","clone_url":"https://github.com/jetty-project/jetty-alpn.git","svn_url":"https://github.com/jetty-project/jetty-alpn","homepage":null,"size":272,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jetty-project/jetty-alpn/pulls/3"},"html":{"href":"https://github.com/jetty-project/jetty-alpn/pull/3"},"issue":{"href":"https://api.github.com/repos/jetty-project/jetty-alpn/issues/3"},"comments":{"href":"https://api.github.com/repos/jetty-project/jetty-alpn/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/jetty-project/jetty-alpn/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/jetty-project/jetty-alpn/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jetty-project/jetty-alpn/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/jetty-project/jetty-alpn/statuses/32ac0ed47ef196d831544d5cf4704688b3bba171"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":383,"deletions":0,"changed_files":4}}