GitHub PushEvent at 2014-07-30 22:16:01
Repository: angular.js
Actor: petebacondarwin
Payload: {"shas":[["61871da9de5fecfa2484c20d3452862ce03a208b","2331edbce7b730168173d2bbf793a717d6b694c5@google.com","revert(select): avoid checking option element selected properties in render\n\nThis reverts commit dc149de9364c66b988f169f67cad39577ba43434. That commit fixes a bug caused by\nFirefox updating `select.value` on hover. However, it\ncauses other bugs with select including the issue described in #7715. This issue details how\nselects with a blank disabled option skip to the second option. We filed a bug\nwith Firefox for the problematic behavior the reverted commit addresses\nhttps://bugzilla.mozilla.org/show_bug.cgi?id=1039047, and alternate Angular fixes are being\ninvestigated.\n\nCloses #7715 #7855","Erin Altenhof-Long",true],["812277c257a25fc21d4829aa4dd220cac93e3f12","2331edbce7b730168173d2bbf793a717d6b694c5@google.com","test(select): add test against updating selected property on digest with no change event\n\nCommit dc149de9364c66b988f169f67cad39577ba43434 was reverted to fix regressions #7715 and #7855.\nThis commit introduced this test case and a corresponding fix for preventing the update of the\nselected property of an option element on a digest with no change event. Although the previous fix\nintroduced regressions, the test covers a valid issue and should be included.","Erin Altenhof-Long",true],["b770c353bc01888515103adb023657b648717128","2331edbce7b730168173d2bbf793a717d6b694c5@google.com","test(select): add test cases for selects with blank disabled options\n\nAn earlier commit dc149de9364c66b988f169f67cad39577ba43434 caused an error where the first option of\na select would be skipped over if it had a blank disabled value. These tests demonstrate that with\nthat commit in place, blank disabled options are skipped in a select. When the commit is reverted,\nthe correct behavior is seen that the blank disabled option is still selected in both selects\nmarked with required and those that have optional choices.\n\nRelates to #7715","Erin Altenhof-Long",true],["d018ac2a9a568f6f86c069dcfd10c633675d5ceb","2331edbce7b730168173d2bbf793a717d6b694c5@google.com","test(select): add test of updating the model because of ng-change\n\nA regression #7855 was introduced by\nhttps://github.com/angular/angular.js/commit/dc149de9364c66b988f169f67cad39577ba43434\nThis test ensures that reverting that commit fixes this regression.\nIn the regression, changes to a bound model in ng-change were not propagated back to the view.\n\nTest for #7855","Erin Altenhof-Long",true],["e9a00fbdc30a17e794ea01d874482b08a48fcb97","e3b6cda228242c30b711ac17cb264f1dbadfd0b6@bacondarwin.com","test(select): add extra expectations and comments for clarity","Peter Bacon Darwin",true],["c2860944c61a0b910f703fe8a9717188ed387893","e3b6cda228242c30b711ac17cb264f1dbadfd0b6@bacondarwin.com","fix(select): do not update selected property of an option element on digest with no change event\n\nThe `render()` method was being invoked on every turn of the digest cycle,\nwhich was inadvertently updating the DOM even when a `change` event had\nnot been triggered.\n\nThis change only calls the `render()` method when `ctrl.$render()` is called,\nas part of the NgModelController` lifecycle and when the `modelValue` has\nsignificantly changed.\n\nCloses #8221\nCloses #7715","Peter Bacon Darwin",true]],"size":6,"ref":"refs/heads/v1.2.x","head":"c2860944c61a0b910f703fe8a9717188ed387893"}