GitHub PullRequestEvent at 2014-09-09 06:01:29
Repository: calamari
Actor: dmick
Payload: {"action":"closed","number":192,"pull_request":{"url":"https://api.github.com/repos/ceph/calamari/pulls/192","id":20934411,"html_url":"https://github.com/ceph/calamari/pull/192","diff_url":"https://github.com/ceph/calamari/pull/192.diff","patch_url":"https://github.com/ceph/calamari/pull/192.patch","issue_url":"https://api.github.com/repos/ceph/calamari/issues/192","number":192,"state":"closed","locked":false,"title":"tests: cope better with `ceph pg stat` output","user":{"login":"tserong","id":754700,"avatar_url":"https://avatars.githubusercontent.com/u/754700?v=2","gravatar_id":"d77037a59943b777e059845272b9a123","url":"https://api.github.com/users/tserong","html_url":"https://github.com/tserong","followers_url":"https://api.github.com/users/tserong/followers","following_url":"https://api.github.com/users/tserong/following{/other_user}","gists_url":"https://api.github.com/users/tserong/gists{/gist_id}","starred_url":"https://api.github.com/users/tserong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tserong/subscriptions","organizations_url":"https://api.github.com/users/tserong/orgs","repos_url":"https://api.github.com/users/tserong/repos","events_url":"https://api.github.com/users/tserong/events{/privacy}","received_events_url":"https://api.github.com/users/tserong/received_events","type":"User","site_admin":false},"body":"Most of the time, `ceph pg stat` gives output like:\r\n\r\n\"v211: 192 pgs: 192 active+clean; 16 bytes data, 232 MB used, 11154 GB /\r\n11154 GB avail\"\r\n\r\nThe current code splits on ':' and ';', and expects this to result in\r\nfour parts.  Occasionally though, `ceph pg stat` has some extra\r\ninformation about recovery, which gives five parts:\r\n\r\n\"v136: 192 pgs: 192 active+clean; 16 bytes data, 239 MB used, 11154 GB /\r\n11154 GB avail; 5 B/s, 0 objects/s recovering\"\r\n\r\nThe way the splitting and assignment was implemented, the second output\r\nwould raise ValueError: too many values to unpack.  This change slices\r\nthe split to only grab total_stat and pg_stat, which is what we actually\r\ncare about.\r\n\r\nSigned-off-by: Tim Serong <tserong@suse.com>","created_at":"2014-09-09T05:23:44Z","updated_at":"2014-09-09T06:01:29Z","closed_at":"2014-09-09T06:01:29Z","merged_at":"2014-09-09T06:01:29Z","merge_commit_sha":"f45413e59b6aa626dd603566a05307718d928ec6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ceph/calamari/pulls/192/commits","review_comments_url":"https://api.github.com/repos/ceph/calamari/pulls/192/comments","review_comment_url":"https://api.github.com/repos/ceph/calamari/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ceph/calamari/issues/192/comments","statuses_url":"https://api.github.com/repos/ceph/calamari/statuses/05a9704d4ca41cddb598676a5ec5a597b5d13443","head":{"label":"SUSE:wip-fix-server-tests","ref":"wip-fix-server-tests","sha":"05a9704d4ca41cddb598676a5ec5a597b5d13443","user":{"login":"SUSE","id":1067733,"avatar_url":"https://avatars.githubusercontent.com/u/1067733?v=2","gravatar_id":"5a3b77ef77146dde2115a5b03ab61201","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"repo":{"id":22716827,"name":"calamari","full_name":"SUSE/calamari","owner":{"login":"SUSE","id":1067733,"avatar_url":"https://avatars.githubusercontent.com/u/1067733?v=2","gravatar_id":"5a3b77ef77146dde2115a5b03ab61201","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SUSE/calamari","description":"Web-based monitoring and management for Ceph","fork":true,"url":"https://api.github.com/repos/SUSE/calamari","forks_url":"https://api.github.com/repos/SUSE/calamari/forks","keys_url":"https://api.github.com/repos/SUSE/calamari/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SUSE/calamari/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SUSE/calamari/teams","hooks_url":"https://api.github.com/repos/SUSE/calamari/hooks","issue_events_url":"https://api.github.com/repos/SUSE/calamari/issues/events{/number}","events_url":"https://api.github.com/repos/SUSE/calamari/events","assignees_url":"https://api.github.com/repos/SUSE/calamari/assignees{/user}","branches_url":"https://api.github.com/repos/SUSE/calamari/branches{/branch}","tags_url":"https://api.github.com/repos/SUSE/calamari/tags","blobs_url":"https://api.github.com/repos/SUSE/calamari/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SUSE/calamari/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SUSE/calamari/git/refs{/sha}","trees_url":"https://api.github.com/repos/SUSE/calamari/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SUSE/calamari/statuses/{sha}","languages_url":"https://api.github.com/repos/SUSE/calamari/languages","stargazers_url":"https://api.github.com/repos/SUSE/calamari/stargazers","contributors_url":"https://api.github.com/repos/SUSE/calamari/contributors","subscribers_url":"https://api.github.com/repos/SUSE/calamari/subscribers","subscription_url":"https://api.github.com/repos/SUSE/calamari/subscription","commits_url":"https://api.github.com/repos/SUSE/calamari/commits{/sha}","git_commits_url":"https://api.github.com/repos/SUSE/calamari/git/commits{/sha}","comments_url":"https://api.github.com/repos/SUSE/calamari/comments{/number}","issue_comment_url":"https://api.github.com/repos/SUSE/calamari/issues/comments/{number}","contents_url":"https://api.github.com/repos/SUSE/calamari/contents/{+path}","compare_url":"https://api.github.com/repos/SUSE/calamari/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SUSE/calamari/merges","archive_url":"https://api.github.com/repos/SUSE/calamari/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SUSE/calamari/downloads","issues_url":"https://api.github.com/repos/SUSE/calamari/issues{/number}","pulls_url":"https://api.github.com/repos/SUSE/calamari/pulls{/number}","milestones_url":"https://api.github.com/repos/SUSE/calamari/milestones{/number}","notifications_url":"https://api.github.com/repos/SUSE/calamari/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SUSE/calamari/labels{/name}","releases_url":"https://api.github.com/repos/SUSE/calamari/releases{/id}","created_at":"2014-08-07T10:06:01Z","updated_at":"2014-08-28T13:21:34Z","pushed_at":"2014-09-09T05:23:20Z","git_url":"git://github.com/SUSE/calamari.git","ssh_url":"git@github.com:SUSE/calamari.git","clone_url":"https://github.com/SUSE/calamari.git","svn_url":"https://github.com/SUSE/calamari","homepage":"","size":21163,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"1be433c618c9c6a235bd34455ca961b34a0a06cc","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=2","gravatar_id":"05461e7575b7a9bb4499cec987f9da6d","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":10654725,"name":"calamari","full_name":"ceph/calamari","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=2","gravatar_id":"05461e7575b7a9bb4499cec987f9da6d","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/calamari","description":"Web-based monitoring and management for Ceph","fork":false,"url":"https://api.github.com/repos/ceph/calamari","forks_url":"https://api.github.com/repos/ceph/calamari/forks","keys_url":"https://api.github.com/repos/ceph/calamari/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/calamari/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/calamari/teams","hooks_url":"https://api.github.com/repos/ceph/calamari/hooks","issue_events_url":"https://api.github.com/repos/ceph/calamari/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/calamari/events","assignees_url":"https://api.github.com/repos/ceph/calamari/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/calamari/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/calamari/tags","blobs_url":"https://api.github.com/repos/ceph/calamari/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/calamari/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/calamari/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/calamari/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/calamari/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/calamari/languages","stargazers_url":"https://api.github.com/repos/ceph/calamari/stargazers","contributors_url":"https://api.github.com/repos/ceph/calamari/contributors","subscribers_url":"https://api.github.com/repos/ceph/calamari/subscribers","subscription_url":"https://api.github.com/repos/ceph/calamari/subscription","commits_url":"https://api.github.com/repos/ceph/calamari/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/calamari/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/calamari/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/calamari/issues/comments/{number}","contents_url":"https://api.github.com/repos/ceph/calamari/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/calamari/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/calamari/merges","archive_url":"https://api.github.com/repos/ceph/calamari/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/calamari/downloads","issues_url":"https://api.github.com/repos/ceph/calamari/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/calamari/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/calamari/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/calamari/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/calamari/labels{/name}","releases_url":"https://api.github.com/repos/ceph/calamari/releases{/id}","created_at":"2013-06-12T23:32:33Z","updated_at":"2014-09-08T18:08:57Z","pushed_at":"2014-09-09T06:01:29Z","git_url":"git://github.com/ceph/calamari.git","ssh_url":"git@github.com:ceph/calamari.git","clone_url":"https://github.com/ceph/calamari.git","svn_url":"https://github.com/ceph/calamari","homepage":"","size":30860,"stargazers_count":51,"watchers_count":51,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":29,"mirror_url":null,"open_issues_count":7,"forks":29,"open_issues":7,"watchers":51,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/calamari/pulls/192"},"html":{"href":"https://github.com/ceph/calamari/pull/192"},"issue":{"href":"https://api.github.com/repos/ceph/calamari/issues/192"},"comments":{"href":"https://api.github.com/repos/ceph/calamari/issues/192/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/calamari/pulls/192/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/calamari/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ceph/calamari/pulls/192/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/calamari/statuses/05a9704d4ca41cddb598676a5ec5a597b5d13443"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"dmick","id":1350673,"avatar_url":"https://avatars.githubusercontent.com/u/1350673?v=2","gravatar_id":"faa91a5ba6a629d7abae256e6e80e614","url":"https://api.github.com/users/dmick","html_url":"https://github.com/dmick","followers_url":"https://api.github.com/users/dmick/followers","following_url":"https://api.github.com/users/dmick/following{/other_user}","gists_url":"https://api.github.com/users/dmick/gists{/gist_id}","starred_url":"https://api.github.com/users/dmick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmick/subscriptions","organizations_url":"https://api.github.com/users/dmick/orgs","repos_url":"https://api.github.com/users/dmick/repos","events_url":"https://api.github.com/users/dmick/events{/privacy}","received_events_url":"https://api.github.com/users/dmick/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}