GitHub PullRequestReviewCommentEvent at 2014-09-10 00:04:42
Repository: ka-lite
Actor: jamalex
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/learningequality/ka-lite/pulls/comments/17336317","id":17336317,"diff_hunk":"@@ -0,0 +1,11 @@\n+<div class=\"form-group\">\n+    <label for=\"zone-name\" class=\"col-xs-2\">Zone</label>\n+    <div class=\"col-xs-8\">\n+        <select class=\"form-control\" id=\"zone-name\">\n+            <option>All</option>{{!-- Default to all --}} \n+            {{#each zones}}\n+                <option data-zone-id=\"{{id}}\" {{#ifcond ../selection \"===\" id }}selected{{/ifcond}}>{{ name }}</option>","path":"kalite/control_panel/hbtemplates/data_export/zone-select.handlebars","position":7,"original_position":7,"commit_id":"da59574b08c8312812ce961caaca54c13e5e532d","original_commit_id":"da59574b08c8312812ce961caaca54c13e5e532d","user":{"login":"jamalex","id":618416,"avatar_url":"https://avatars.githubusercontent.com/u/618416?v=2","gravatar_id":"781806afa6818820d42255fc87bf2626","url":"https://api.github.com/users/jamalex","html_url":"https://github.com/jamalex","followers_url":"https://api.github.com/users/jamalex/followers","following_url":"https://api.github.com/users/jamalex/following{/other_user}","gists_url":"https://api.github.com/users/jamalex/gists{/gist_id}","starred_url":"https://api.github.com/users/jamalex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamalex/subscriptions","organizations_url":"https://api.github.com/users/jamalex/orgs","repos_url":"https://api.github.com/users/jamalex/repos","events_url":"https://api.github.com/users/jamalex/events{/privacy}","received_events_url":"https://api.github.com/users/jamalex/received_events","type":"User","site_admin":false},"body":"Might be cleaner/more idiomatic to use the `value` attribute instead of `data-zone-id` (see http://www.w3schools.com/tags/tag_option.asp)","created_at":"2014-09-10T00:04:42Z","updated_at":"2014-09-10T00:04:42Z","html_url":"https://github.com/learningequality/ka-lite/pull/2345#discussion_r17336317","pull_request_url":"https://api.github.com/repos/learningequality/ka-lite/pulls/2345","_links":{"self":{"href":"https://api.github.com/repos/learningequality/ka-lite/pulls/comments/17336317"},"html":{"href":"https://github.com/learningequality/ka-lite/pull/2345#discussion_r17336317"},"pull_request":{"href":"https://api.github.com/repos/learningequality/ka-lite/pulls/2345"}}},"pull_request":{"url":"https://api.github.com/repos/learningequality/ka-lite/pulls/2345","id":20836668,"html_url":"https://github.com/learningequality/ka-lite/pull/2345","diff_url":"https://github.com/learningequality/ka-lite/pull/2345.diff","patch_url":"https://github.com/learningequality/ka-lite/pull/2345.patch","issue_url":"https://api.github.com/repos/learningequality/ka-lite/issues/2345","number":2345,"state":"open","locked":false,"title":"Csv export auth","user":{"login":"dylanjbarth","id":1319950,"avatar_url":"https://avatars.githubusercontent.com/u/1319950?v=2","gravatar_id":"bf7e02d643066ba8afdf2b0ee0fc07cd","url":"https://api.github.com/users/dylanjbarth","html_url":"https://github.com/dylanjbarth","followers_url":"https://api.github.com/users/dylanjbarth/followers","following_url":"https://api.github.com/users/dylanjbarth/following{/other_user}","gists_url":"https://api.github.com/users/dylanjbarth/gists{/gist_id}","starred_url":"https://api.github.com/users/dylanjbarth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dylanjbarth/subscriptions","organizations_url":"https://api.github.com/users/dylanjbarth/orgs","repos_url":"https://api.github.com/users/dylanjbarth/repos","events_url":"https://api.github.com/users/dylanjbarth/events{/privacy}","received_events_url":"https://api.github.com/users/dylanjbarth/received_events","type":"User","site_admin":false},"body":"Sorry this is from learningequality to learningequality. I think because of some trouble with the kalite-submodule (working from the central codebase) I set my origin to learningequality rather than my own fork and forgot about it. \r\n\r\nSummary: Adds 3 api endpoints (FacilityUser, TestLog, and AttemptLog), which allow filtering based on zone, facility, or group, and return the appropriate data serialized to CSV. Also includes a backbone app which serves as the front-end for the API. Pics below. \r\n\r\nFrom central server, admins can select combination of zone, facility, student group, and resource type (users, test, or attempts:\r\n\r\n![selection_067](https://cloud.githubusercontent.com/assets/1319950/4172155/11550ebc-3545-11e4-8767-4d0c799a280e.png)\r\n\r\nOn distributed, same idea, minus the ability to select zone:\r\n![selection_068](https://cloud.githubusercontent.com/assets/1319950/4172159/20a60a9c-3545-11e4-87fe-bed2d563a0fc.png)\r\n\r\nLingering issues:\r\n* no tests yet (although works in manual testing) \r\n* currently returns a blank CSV when an admin picks a combination that returns 0 results. Eg if there are no students at a facility and they click export, it will be empty rather than returning an error message. Currently this is by design, but we could handle it better in future. \r\n* File names are currently just 'download' without an extension. I couldn't figure out how to do this easily, and I think it's ok for now, but something to flag for follow up \r\n* May need refactor, see my comments on Part 1 in central server codebase: https://github.com/fle-internal/ka-lite-central/pull/190\r\n","created_at":"2014-09-05T21:43:02Z","updated_at":"2014-09-10T00:04:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/learningequality/ka-lite/pulls/2345/commits","review_comments_url":"https://api.github.com/repos/learningequality/ka-lite/pulls/2345/comments","review_comment_url":"https://api.github.com/repos/learningequality/ka-lite/pulls/comments/{number}","comments_url":"https://api.github.com/repos/learningequality/ka-lite/issues/2345/comments","statuses_url":"https://api.github.com/repos/learningequality/ka-lite/statuses/da59574b08c8312812ce961caaca54c13e5e532d","head":{"label":"learningequality:csv_export_auth","ref":"csv_export_auth","sha":"da59574b08c8312812ce961caaca54c13e5e532d","user":{"login":"learningequality","id":3926525,"avatar_url":"https://avatars.githubusercontent.com/u/3926525?v=2","gravatar_id":"56ac3f6863c7474d8148e19a35a4e28f","url":"https://api.github.com/users/learningequality","html_url":"https://github.com/learningequality","followers_url":"https://api.github.com/users/learningequality/followers","following_url":"https://api.github.com/users/learningequality/following{/other_user}","gists_url":"https://api.github.com/users/learningequality/gists{/gist_id}","starred_url":"https://api.github.com/users/learningequality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/learningequality/subscriptions","organizations_url":"https://api.github.com/users/learningequality/orgs","repos_url":"https://api.github.com/users/learningequality/repos","events_url":"https://api.github.com/users/learningequality/events{/privacy}","received_events_url":"https://api.github.com/users/learningequality/received_events","type":"Organization","site_admin":false},"repo":{"id":5741125,"name":"ka-lite","full_name":"learningequality/ka-lite","owner":{"login":"learningequality","id":3926525,"avatar_url":"https://avatars.githubusercontent.com/u/3926525?v=2","gravatar_id":"56ac3f6863c7474d8148e19a35a4e28f","url":"https://api.github.com/users/learningequality","html_url":"https://github.com/learningequality","followers_url":"https://api.github.com/users/learningequality/followers","following_url":"https://api.github.com/users/learningequality/following{/other_user}","gists_url":"https://api.github.com/users/learningequality/gists{/gist_id}","starred_url":"https://api.github.com/users/learningequality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/learningequality/subscriptions","organizations_url":"https://api.github.com/users/learningequality/orgs","repos_url":"https://api.github.com/users/learningequality/repos","events_url":"https://api.github.com/users/learningequality/events{/privacy}","received_events_url":"https://api.github.com/users/learningequality/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/learningequality/ka-lite","description":"KA Lite: lightweight web server for serving core Khan Academy content (videos and exercises) without needing internet connectivity","fork":false,"url":"https://api.github.com/repos/learningequality/ka-lite","forks_url":"https://api.github.com/repos/learningequality/ka-lite/forks","keys_url":"https://api.github.com/repos/learningequality/ka-lite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/learningequality/ka-lite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/learningequality/ka-lite/teams","hooks_url":"https://api.github.com/repos/learningequality/ka-lite/hooks","issue_events_url":"https://api.github.com/repos/learningequality/ka-lite/issues/events{/number}","events_url":"https://api.github.com/repos/learningequality/ka-lite/events","assignees_url":"https://api.github.com/repos/learningequality/ka-lite/assignees{/user}","branches_url":"https://api.github.com/repos/learningequality/ka-lite/branches{/branch}","tags_url":"https://api.github.com/repos/learningequality/ka-lite/tags","blobs_url":"https://api.github.com/repos/learningequality/ka-lite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/learningequality/ka-lite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/learningequality/ka-lite/git/refs{/sha}","trees_url":"https://api.github.com/repos/learningequality/ka-lite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/learningequality/ka-lite/statuses/{sha}","languages_url":"https://api.github.com/repos/learningequality/ka-lite/languages","stargazers_url":"https://api.github.com/repos/learningequality/ka-lite/stargazers","contributors_url":"https://api.github.com/repos/learningequality/ka-lite/contributors","subscribers_url":"https://api.github.com/repos/learningequality/ka-lite/subscribers","subscription_url":"https://api.github.com/repos/learningequality/ka-lite/subscription","commits_url":"https://api.github.com/repos/learningequality/ka-lite/commits{/sha}","git_commits_url":"https://api.github.com/repos/learningequality/ka-lite/git/commits{/sha}","comments_url":"https://api.github.com/repos/learningequality/ka-lite/comments{/number}","issue_comment_url":"https://api.github.com/repos/learningequality/ka-lite/issues/comments/{number}","contents_url":"https://api.github.com/repos/learningequality/ka-lite/contents/{+path}","compare_url":"https://api.github.com/repos/learningequality/ka-lite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/learningequality/ka-lite/merges","archive_url":"https://api.github.com/repos/learningequality/ka-lite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/learningequality/ka-lite/downloads","issues_url":"https://api.github.com/repos/learningequality/ka-lite/issues{/number}","pulls_url":"https://api.github.com/repos/learningequality/ka-lite/pulls{/number}","milestones_url":"https://api.github.com/repos/learningequality/ka-lite/milestones{/number}","notifications_url":"https://api.github.com/repos/learningequality/ka-lite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/learningequality/ka-lite/labels{/name}","releases_url":"https://api.github.com/repos/learningequality/ka-lite/releases{/id}","created_at":"2012-09-09T20:01:40Z","updated_at":"2014-09-09T09:13:07Z","pushed_at":"2014-09-09T22:02:12Z","git_url":"git://github.com/learningequality/ka-lite.git","ssh_url":"git@github.com:learningequality/ka-lite.git","clone_url":"https://github.com/learningequality/ka-lite.git","svn_url":"https://github.com/learningequality/ka-lite","homepage":"https://learningequality.org/ka-lite/","size":163800,"stargazers_count":127,"watchers_count":127,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":159,"mirror_url":null,"open_issues_count":279,"forks":159,"open_issues":279,"watchers":127,"default_branch":"master"}},"base":{"label":"learningequality:nalanda-rct3","ref":"nalanda-rct3","sha":"06f4cd7f829d58a7b5d6c007923ea78c0e918a7d","user":{"login":"learningequality","id":3926525,"avatar_url":"https://avatars.githubusercontent.com/u/3926525?v=2","gravatar_id":"56ac3f6863c7474d8148e19a35a4e28f","url":"https://api.github.com/users/learningequality","html_url":"https://github.com/learningequality","followers_url":"https://api.github.com/users/learningequality/followers","following_url":"https://api.github.com/users/learningequality/following{/other_user}","gists_url":"https://api.github.com/users/learningequality/gists{/gist_id}","starred_url":"https://api.github.com/users/learningequality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/learningequality/subscriptions","organizations_url":"https://api.github.com/users/learningequality/orgs","repos_url":"https://api.github.com/users/learningequality/repos","events_url":"https://api.github.com/users/learningequality/events{/privacy}","received_events_url":"https://api.github.com/users/learningequality/received_events","type":"Organization","site_admin":false},"repo":{"id":5741125,"name":"ka-lite","full_name":"learningequality/ka-lite","owner":{"login":"learningequality","id":3926525,"avatar_url":"https://avatars.githubusercontent.com/u/3926525?v=2","gravatar_id":"56ac3f6863c7474d8148e19a35a4e28f","url":"https://api.github.com/users/learningequality","html_url":"https://github.com/learningequality","followers_url":"https://api.github.com/users/learningequality/followers","following_url":"https://api.github.com/users/learningequality/following{/other_user}","gists_url":"https://api.github.com/users/learningequality/gists{/gist_id}","starred_url":"https://api.github.com/users/learningequality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/learningequality/subscriptions","organizations_url":"https://api.github.com/users/learningequality/orgs","repos_url":"https://api.github.com/users/learningequality/repos","events_url":"https://api.github.com/users/learningequality/events{/privacy}","received_events_url":"https://api.github.com/users/learningequality/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/learningequality/ka-lite","description":"KA Lite: lightweight web server for serving core Khan Academy content (videos and exercises) without needing internet connectivity","fork":false,"url":"https://api.github.com/repos/learningequality/ka-lite","forks_url":"https://api.github.com/repos/learningequality/ka-lite/forks","keys_url":"https://api.github.com/repos/learningequality/ka-lite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/learningequality/ka-lite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/learningequality/ka-lite/teams","hooks_url":"https://api.github.com/repos/learningequality/ka-lite/hooks","issue_events_url":"https://api.github.com/repos/learningequality/ka-lite/issues/events{/number}","events_url":"https://api.github.com/repos/learningequality/ka-lite/events","assignees_url":"https://api.github.com/repos/learningequality/ka-lite/assignees{/user}","branches_url":"https://api.github.com/repos/learningequality/ka-lite/branches{/branch}","tags_url":"https://api.github.com/repos/learningequality/ka-lite/tags","blobs_url":"https://api.github.com/repos/learningequality/ka-lite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/learningequality/ka-lite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/learningequality/ka-lite/git/refs{/sha}","trees_url":"https://api.github.com/repos/learningequality/ka-lite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/learningequality/ka-lite/statuses/{sha}","languages_url":"https://api.github.com/repos/learningequality/ka-lite/languages","stargazers_url":"https://api.github.com/repos/learningequality/ka-lite/stargazers","contributors_url":"https://api.github.com/repos/learningequality/ka-lite/contributors","subscribers_url":"https://api.github.com/repos/learningequality/ka-lite/subscribers","subscription_url":"https://api.github.com/repos/learningequality/ka-lite/subscription","commits_url":"https://api.github.com/repos/learningequality/ka-lite/commits{/sha}","git_commits_url":"https://api.github.com/repos/learningequality/ka-lite/git/commits{/sha}","comments_url":"https://api.github.com/repos/learningequality/ka-lite/comments{/number}","issue_comment_url":"https://api.github.com/repos/learningequality/ka-lite/issues/comments/{number}","contents_url":"https://api.github.com/repos/learningequality/ka-lite/contents/{+path}","compare_url":"https://api.github.com/repos/learningequality/ka-lite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/learningequality/ka-lite/merges","archive_url":"https://api.github.com/repos/learningequality/ka-lite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/learningequality/ka-lite/downloads","issues_url":"https://api.github.com/repos/learningequality/ka-lite/issues{/number}","pulls_url":"https://api.github.com/repos/learningequality/ka-lite/pulls{/number}","milestones_url":"https://api.github.com/repos/learningequality/ka-lite/milestones{/number}","notifications_url":"https://api.github.com/repos/learningequality/ka-lite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/learningequality/ka-lite/labels{/name}","releases_url":"https://api.github.com/repos/learningequality/ka-lite/releases{/id}","created_at":"2012-09-09T20:01:40Z","updated_at":"2014-09-09T09:13:07Z","pushed_at":"2014-09-09T22:02:12Z","git_url":"git://github.com/learningequality/ka-lite.git","ssh_url":"git@github.com:learningequality/ka-lite.git","clone_url":"https://github.com/learningequality/ka-lite.git","svn_url":"https://github.com/learningequality/ka-lite","homepage":"https://learningequality.org/ka-lite/","size":163800,"stargazers_count":127,"watchers_count":127,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":159,"mirror_url":null,"open_issues_count":279,"forks":159,"open_issues":279,"watchers":127,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/learningequality/ka-lite/pulls/2345"},"html":{"href":"https://github.com/learningequality/ka-lite/pull/2345"},"issue":{"href":"https://api.github.com/repos/learningequality/ka-lite/issues/2345"},"comments":{"href":"https://api.github.com/repos/learningequality/ka-lite/issues/2345/comments"},"review_comments":{"href":"https://api.github.com/repos/learningequality/ka-lite/pulls/2345/comments"},"review_comment":{"href":"https://api.github.com/repos/learningequality/ka-lite/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/learningequality/ka-lite/pulls/2345/commits"},"statuses":{"href":"https://api.github.com/repos/learningequality/ka-lite/statuses/da59574b08c8312812ce961caaca54c13e5e532d"}}}}