GitHub PullRequestReviewCommentEvent at 2014-08-09 21:00:12
Repository: pq
Actor: johto
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/lib/pq/pulls/comments/16027960","id":16027960,"diff_hunk":"@@ -173,7 +181,7 @@ func Open(name string) (_ driver.Conn, err error) {\n \treturn cn, err\n }\n \n-func dial(o values) (net.Conn, error) {\n+func dial(d dialer, o values) (net.Conn, error) {","path":"conn.go","position":36,"original_position":36,"commit_id":"05aa1edd6b322fc969873a338f0681dc9045996b","original_commit_id":"05aa1edd6b322fc969873a338f0681dc9045996b","user":{"login":"johto","id":951744,"avatar_url":"https://avatars.githubusercontent.com/u/951744?v=2","gravatar_id":"99c80e7f65001e40abc9e125fe8d6ff2","url":"https://api.github.com/users/johto","html_url":"https://github.com/johto","followers_url":"https://api.github.com/users/johto/followers","following_url":"https://api.github.com/users/johto/following{/other_user}","gists_url":"https://api.github.com/users/johto/gists{/gist_id}","starred_url":"https://api.github.com/users/johto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johto/subscriptions","organizations_url":"https://api.github.com/users/johto/orgs","repos_url":"https://api.github.com/users/johto/repos","events_url":"https://api.github.com/users/johto/events{/privacy}","received_events_url":"https://api.github.com/users/johto/received_events","type":"User","site_admin":false},"body":"This must handle the DialTimeout case, too, or the behaviour is way too surprising.","created_at":"2014-08-09T21:00:12Z","updated_at":"2014-08-09T21:00:12Z","html_url":"https://github.com/lib/pq/pull/287#discussion_r16027960","pull_request_url":"https://api.github.com/repos/lib/pq/pulls/287","_links":{"self":{"href":"https://api.github.com/repos/lib/pq/pulls/comments/16027960"},"html":{"href":"https://github.com/lib/pq/pull/287#discussion_r16027960"},"pull_request":{"href":"https://api.github.com/repos/lib/pq/pulls/287"}}},"pull_request":{"url":"https://api.github.com/repos/lib/pq/pulls/287","id":19486351,"html_url":"https://github.com/lib/pq/pull/287","diff_url":"https://github.com/lib/pq/pull/287.diff","patch_url":"https://github.com/lib/pq/pull/287.patch","issue_url":"https://api.github.com/repos/lib/pq/issues/287","number":287,"state":"open","title":"Support arbitrary network dialers","user":{"login":"fumin","id":765222,"avatar_url":"https://avatars.githubusercontent.com/u/765222?v=2","gravatar_id":"209915cd89411bb3a715c4fcf499402f","url":"https://api.github.com/users/fumin","html_url":"https://github.com/fumin","followers_url":"https://api.github.com/users/fumin/followers","following_url":"https://api.github.com/users/fumin/following{/other_user}","gists_url":"https://api.github.com/users/fumin/gists{/gist_id}","starred_url":"https://api.github.com/users/fumin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fumin/subscriptions","organizations_url":"https://api.github.com/users/fumin/orgs","repos_url":"https://api.github.com/users/fumin/repos","events_url":"https://api.github.com/users/fumin/events{/privacy}","received_events_url":"https://api.github.com/users/fumin/received_events","type":"User","site_admin":false},"body":"One such use case is to use the library within the constraints of Google\r\nApp Engine\r\nhttps://developers.google.com/appengine/docs/go/sockets/reference","created_at":"2014-08-07T18:49:18Z","updated_at":"2014-08-09T21:00:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f8c7f9c75106f41ca5ac255f0c96ce9aa8ef546e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lib/pq/pulls/287/commits","review_comments_url":"https://api.github.com/repos/lib/pq/pulls/287/comments","review_comment_url":"https://api.github.com/repos/lib/pq/pulls/comments/{number}","comments_url":"https://api.github.com/repos/lib/pq/issues/287/comments","statuses_url":"https://api.github.com/repos/lib/pq/statuses/05aa1edd6b322fc969873a338f0681dc9045996b","head":{"label":"fumin:master","ref":"master","sha":"05aa1edd6b322fc969873a338f0681dc9045996b","user":{"login":"fumin","id":765222,"avatar_url":"https://avatars.githubusercontent.com/u/765222?v=2","gravatar_id":"209915cd89411bb3a715c4fcf499402f","url":"https://api.github.com/users/fumin","html_url":"https://github.com/fumin","followers_url":"https://api.github.com/users/fumin/followers","following_url":"https://api.github.com/users/fumin/following{/other_user}","gists_url":"https://api.github.com/users/fumin/gists{/gist_id}","starred_url":"https://api.github.com/users/fumin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fumin/subscriptions","organizations_url":"https://api.github.com/users/fumin/orgs","repos_url":"https://api.github.com/users/fumin/repos","events_url":"https://api.github.com/users/fumin/events{/privacy}","received_events_url":"https://api.github.com/users/fumin/received_events","type":"User","site_admin":false},"repo":{"id":22731635,"name":"pq","full_name":"fumin/pq","owner":{"login":"fumin","id":765222,"avatar_url":"https://avatars.githubusercontent.com/u/765222?v=2","gravatar_id":"209915cd89411bb3a715c4fcf499402f","url":"https://api.github.com/users/fumin","html_url":"https://github.com/fumin","followers_url":"https://api.github.com/users/fumin/followers","following_url":"https://api.github.com/users/fumin/following{/other_user}","gists_url":"https://api.github.com/users/fumin/gists{/gist_id}","starred_url":"https://api.github.com/users/fumin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fumin/subscriptions","organizations_url":"https://api.github.com/users/fumin/orgs","repos_url":"https://api.github.com/users/fumin/repos","events_url":"https://api.github.com/users/fumin/events{/privacy}","received_events_url":"https://api.github.com/users/fumin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fumin/pq","description":"Pure Go Postgres driver for database/sql","fork":true,"url":"https://api.github.com/repos/fumin/pq","forks_url":"https://api.github.com/repos/fumin/pq/forks","keys_url":"https://api.github.com/repos/fumin/pq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fumin/pq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fumin/pq/teams","hooks_url":"https://api.github.com/repos/fumin/pq/hooks","issue_events_url":"https://api.github.com/repos/fumin/pq/issues/events{/number}","events_url":"https://api.github.com/repos/fumin/pq/events","assignees_url":"https://api.github.com/repos/fumin/pq/assignees{/user}","branches_url":"https://api.github.com/repos/fumin/pq/branches{/branch}","tags_url":"https://api.github.com/repos/fumin/pq/tags","blobs_url":"https://api.github.com/repos/fumin/pq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fumin/pq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fumin/pq/git/refs{/sha}","trees_url":"https://api.github.com/repos/fumin/pq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fumin/pq/statuses/{sha}","languages_url":"https://api.github.com/repos/fumin/pq/languages","stargazers_url":"https://api.github.com/repos/fumin/pq/stargazers","contributors_url":"https://api.github.com/repos/fumin/pq/contributors","subscribers_url":"https://api.github.com/repos/fumin/pq/subscribers","subscription_url":"https://api.github.com/repos/fumin/pq/subscription","commits_url":"https://api.github.com/repos/fumin/pq/commits{/sha}","git_commits_url":"https://api.github.com/repos/fumin/pq/git/commits{/sha}","comments_url":"https://api.github.com/repos/fumin/pq/comments{/number}","issue_comment_url":"https://api.github.com/repos/fumin/pq/issues/comments/{number}","contents_url":"https://api.github.com/repos/fumin/pq/contents/{+path}","compare_url":"https://api.github.com/repos/fumin/pq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fumin/pq/merges","archive_url":"https://api.github.com/repos/fumin/pq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fumin/pq/downloads","issues_url":"https://api.github.com/repos/fumin/pq/issues{/number}","pulls_url":"https://api.github.com/repos/fumin/pq/pulls{/number}","milestones_url":"https://api.github.com/repos/fumin/pq/milestones{/number}","notifications_url":"https://api.github.com/repos/fumin/pq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fumin/pq/labels{/name}","releases_url":"https://api.github.com/repos/fumin/pq/releases{/id}","created_at":"2014-08-07T18:20:31Z","updated_at":"2014-08-07T18:48:15Z","pushed_at":"2014-08-07T18:48:15Z","git_url":"git://github.com/fumin/pq.git","ssh_url":"git@github.com:fumin/pq.git","clone_url":"https://github.com/fumin/pq.git","svn_url":"https://github.com/fumin/pq","homepage":"http://godoc.org/github.com/lib/pq","size":2706,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lib:master","ref":"master","sha":"3e0659e626f761e9af7a8bd1c8b6aaea6770495b","user":{"login":"lib","id":3791026,"avatar_url":"https://avatars.githubusercontent.com/u/3791026?v=2","gravatar_id":null,"url":"https://api.github.com/users/lib","html_url":"https://github.com/lib","followers_url":"https://api.github.com/users/lib/followers","following_url":"https://api.github.com/users/lib/following{/other_user}","gists_url":"https://api.github.com/users/lib/gists{/gist_id}","starred_url":"https://api.github.com/users/lib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lib/subscriptions","organizations_url":"https://api.github.com/users/lib/orgs","repos_url":"https://api.github.com/users/lib/repos","events_url":"https://api.github.com/users/lib/events{/privacy}","received_events_url":"https://api.github.com/users/lib/received_events","type":"Organization","site_admin":false},"repo":{"id":3698588,"name":"pq","full_name":"lib/pq","owner":{"login":"lib","id":3791026,"avatar_url":"https://avatars.githubusercontent.com/u/3791026?v=2","gravatar_id":null,"url":"https://api.github.com/users/lib","html_url":"https://github.com/lib","followers_url":"https://api.github.com/users/lib/followers","following_url":"https://api.github.com/users/lib/following{/other_user}","gists_url":"https://api.github.com/users/lib/gists{/gist_id}","starred_url":"https://api.github.com/users/lib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lib/subscriptions","organizations_url":"https://api.github.com/users/lib/orgs","repos_url":"https://api.github.com/users/lib/repos","events_url":"https://api.github.com/users/lib/events{/privacy}","received_events_url":"https://api.github.com/users/lib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lib/pq","description":"Pure Go Postgres driver for database/sql","fork":false,"url":"https://api.github.com/repos/lib/pq","forks_url":"https://api.github.com/repos/lib/pq/forks","keys_url":"https://api.github.com/repos/lib/pq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lib/pq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lib/pq/teams","hooks_url":"https://api.github.com/repos/lib/pq/hooks","issue_events_url":"https://api.github.com/repos/lib/pq/issues/events{/number}","events_url":"https://api.github.com/repos/lib/pq/events","assignees_url":"https://api.github.com/repos/lib/pq/assignees{/user}","branches_url":"https://api.github.com/repos/lib/pq/branches{/branch}","tags_url":"https://api.github.com/repos/lib/pq/tags","blobs_url":"https://api.github.com/repos/lib/pq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lib/pq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lib/pq/git/refs{/sha}","trees_url":"https://api.github.com/repos/lib/pq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lib/pq/statuses/{sha}","languages_url":"https://api.github.com/repos/lib/pq/languages","stargazers_url":"https://api.github.com/repos/lib/pq/stargazers","contributors_url":"https://api.github.com/repos/lib/pq/contributors","subscribers_url":"https://api.github.com/repos/lib/pq/subscribers","subscription_url":"https://api.github.com/repos/lib/pq/subscription","commits_url":"https://api.github.com/repos/lib/pq/commits{/sha}","git_commits_url":"https://api.github.com/repos/lib/pq/git/commits{/sha}","comments_url":"https://api.github.com/repos/lib/pq/comments{/number}","issue_comment_url":"https://api.github.com/repos/lib/pq/issues/comments/{number}","contents_url":"https://api.github.com/repos/lib/pq/contents/{+path}","compare_url":"https://api.github.com/repos/lib/pq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lib/pq/merges","archive_url":"https://api.github.com/repos/lib/pq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lib/pq/downloads","issues_url":"https://api.github.com/repos/lib/pq/issues{/number}","pulls_url":"https://api.github.com/repos/lib/pq/pulls{/number}","milestones_url":"https://api.github.com/repos/lib/pq/milestones{/number}","notifications_url":"https://api.github.com/repos/lib/pq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lib/pq/labels{/name}","releases_url":"https://api.github.com/repos/lib/pq/releases{/id}","created_at":"2012-03-12T18:50:22Z","updated_at":"2014-08-09T17:54:28Z","pushed_at":"2014-08-09T12:02:00Z","git_url":"git://github.com/lib/pq.git","ssh_url":"git@github.com:lib/pq.git","clone_url":"https://github.com/lib/pq.git","svn_url":"https://github.com/lib/pq","homepage":"http://godoc.org/github.com/lib/pq","size":2706,"stargazers_count":833,"watchers_count":833,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":158,"mirror_url":null,"open_issues_count":40,"forks":158,"open_issues":40,"watchers":833,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lib/pq/pulls/287"},"html":{"href":"https://github.com/lib/pq/pull/287"},"issue":{"href":"https://api.github.com/repos/lib/pq/issues/287"},"comments":{"href":"https://api.github.com/repos/lib/pq/issues/287/comments"},"review_comments":{"href":"https://api.github.com/repos/lib/pq/pulls/287/comments"},"review_comment":{"href":"https://api.github.com/repos/lib/pq/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/lib/pq/pulls/287/commits"},"statuses":{"href":"https://api.github.com/repos/lib/pq/statuses/05aa1edd6b322fc969873a338f0681dc9045996b"}}}}