GitHub PullRequestEvent at 2014-03-26 00:15:15
Repository: ipython
Actor: minrk
Payload: {"action":"closed","number":5426,"pull_request":{"url":"https://api.github.com/repos/ipython/ipython/pulls/5426","id":13968757,"html_url":"https://github.com/ipython/ipython/pull/5426","diff_url":"https://github.com/ipython/ipython/pull/5426.diff","patch_url":"https://github.com/ipython/ipython/pull/5426.patch","issue_url":"https://api.github.com/repos/ipython/ipython/issues/5426","number":5426,"state":"closed","title":"Separate get_session_info between HistoryAccessor and HistoryManager","user":{"login":"takluyver","id":327925,"avatar_url":"https://avatars.githubusercontent.com/u/327925?","gravatar_id":"7f1ae3f14fd5b87c2c3f7b36014e185c","url":"https://api.github.com/users/takluyver","html_url":"https://github.com/takluyver","followers_url":"https://api.github.com/users/takluyver/followers","following_url":"https://api.github.com/users/takluyver/following{/other_user}","gists_url":"https://api.github.com/users/takluyver/gists{/gist_id}","starred_url":"https://api.github.com/users/takluyver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takluyver/subscriptions","organizations_url":"https://api.github.com/users/takluyver/orgs","repos_url":"https://api.github.com/users/takluyver/repos","events_url":"https://api.github.com/users/takluyver/events{/privacy}","received_events_url":"https://api.github.com/users/takluyver/received_events","type":"User","site_admin":false},"body":"HistoryAccessor has no concept of the current session, whereas HistoryManager does. HistoryAccessor should therefore always be used with a session number > 0. However, I have added get_last_session_id() to HistoryAccessor to make it easier to work with recent history.\r\n\r\nCloses gh-5348","created_at":"2014-03-25T18:30:48Z","updated_at":"2014-03-26T00:15:14Z","closed_at":"2014-03-26T00:15:14Z","merged_at":"2014-03-26T00:15:14Z","merge_commit_sha":"fbca1b5f5280d10381e1a6e1c44cf5dc7534d7a3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ipython/ipython/pulls/5426/commits","review_comments_url":"https://api.github.com/repos/ipython/ipython/pulls/5426/comments","review_comment_url":"https://api.github.com/repos/ipython/ipython/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ipython/ipython/issues/5426/comments","statuses_url":"https://api.github.com/repos/ipython/ipython/statuses/326b5fcdfe76d95e145818e8e7f0732b6d3de910","head":{"label":"takluyver:i5348","ref":"i5348","sha":"326b5fcdfe76d95e145818e8e7f0732b6d3de910","user":{"login":"takluyver","id":327925,"avatar_url":"https://avatars.githubusercontent.com/u/327925?","gravatar_id":"7f1ae3f14fd5b87c2c3f7b36014e185c","url":"https://api.github.com/users/takluyver","html_url":"https://github.com/takluyver","followers_url":"https://api.github.com/users/takluyver/followers","following_url":"https://api.github.com/users/takluyver/following{/other_user}","gists_url":"https://api.github.com/users/takluyver/gists{/gist_id}","starred_url":"https://api.github.com/users/takluyver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takluyver/subscriptions","organizations_url":"https://api.github.com/users/takluyver/orgs","repos_url":"https://api.github.com/users/takluyver/repos","events_url":"https://api.github.com/users/takluyver/events{/privacy}","received_events_url":"https://api.github.com/users/takluyver/received_events","type":"User","site_admin":false},"repo":{"id":1236003,"name":"ipython","full_name":"takluyver/ipython","owner":{"login":"takluyver","id":327925,"avatar_url":"https://avatars.githubusercontent.com/u/327925?","gravatar_id":"7f1ae3f14fd5b87c2c3f7b36014e185c","url":"https://api.github.com/users/takluyver","html_url":"https://github.com/takluyver","followers_url":"https://api.github.com/users/takluyver/followers","following_url":"https://api.github.com/users/takluyver/following{/other_user}","gists_url":"https://api.github.com/users/takluyver/gists{/gist_id}","starred_url":"https://api.github.com/users/takluyver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takluyver/subscriptions","organizations_url":"https://api.github.com/users/takluyver/orgs","repos_url":"https://api.github.com/users/takluyver/repos","events_url":"https://api.github.com/users/takluyver/events{/privacy}","received_events_url":"https://api.github.com/users/takluyver/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/takluyver/ipython","description":"","fork":true,"url":"https://api.github.com/repos/takluyver/ipython","forks_url":"https://api.github.com/repos/takluyver/ipython/forks","keys_url":"https://api.github.com/repos/takluyver/ipython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/takluyver/ipython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/takluyver/ipython/teams","hooks_url":"https://api.github.com/repos/takluyver/ipython/hooks","issue_events_url":"https://api.github.com/repos/takluyver/ipython/issues/events{/number}","events_url":"https://api.github.com/repos/takluyver/ipython/events","assignees_url":"https://api.github.com/repos/takluyver/ipython/assignees{/user}","branches_url":"https://api.github.com/repos/takluyver/ipython/branches{/branch}","tags_url":"https://api.github.com/repos/takluyver/ipython/tags","blobs_url":"https://api.github.com/repos/takluyver/ipython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/takluyver/ipython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/takluyver/ipython/git/refs{/sha}","trees_url":"https://api.github.com/repos/takluyver/ipython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/takluyver/ipython/statuses/{sha}","languages_url":"https://api.github.com/repos/takluyver/ipython/languages","stargazers_url":"https://api.github.com/repos/takluyver/ipython/stargazers","contributors_url":"https://api.github.com/repos/takluyver/ipython/contributors","subscribers_url":"https://api.github.com/repos/takluyver/ipython/subscribers","subscription_url":"https://api.github.com/repos/takluyver/ipython/subscription","commits_url":"https://api.github.com/repos/takluyver/ipython/commits{/sha}","git_commits_url":"https://api.github.com/repos/takluyver/ipython/git/commits{/sha}","comments_url":"https://api.github.com/repos/takluyver/ipython/comments{/number}","issue_comment_url":"https://api.github.com/repos/takluyver/ipython/issues/comments/{number}","contents_url":"https://api.github.com/repos/takluyver/ipython/contents/{+path}","compare_url":"https://api.github.com/repos/takluyver/ipython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/takluyver/ipython/merges","archive_url":"https://api.github.com/repos/takluyver/ipython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/takluyver/ipython/downloads","issues_url":"https://api.github.com/repos/takluyver/ipython/issues{/number}","pulls_url":"https://api.github.com/repos/takluyver/ipython/pulls{/number}","milestones_url":"https://api.github.com/repos/takluyver/ipython/milestones{/number}","notifications_url":"https://api.github.com/repos/takluyver/ipython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/takluyver/ipython/labels{/name}","releases_url":"https://api.github.com/repos/takluyver/ipython/releases{/id}","created_at":"2011-01-09T20:50:17Z","updated_at":"2014-03-26T00:15:14Z","pushed_at":"2014-03-25T18:30:28Z","git_url":"git://github.com/takluyver/ipython.git","ssh_url":"git@github.com:takluyver/ipython.git","clone_url":"https://github.com/takluyver/ipython.git","svn_url":"https://github.com/takluyver/ipython","homepage":"http://ipython.org","size":57697,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master","master_branch":"master"}},"base":{"label":"ipython:master","ref":"master","sha":"ece49ebf568ba7a94e23d2a813f9de788c7e8b7c","user":{"login":"ipython","id":230453,"avatar_url":"https://avatars.githubusercontent.com/u/230453?","gravatar_id":"f72497397dd9a0a79c654c8182460bb1","url":"https://api.github.com/users/ipython","html_url":"https://github.com/ipython","followers_url":"https://api.github.com/users/ipython/followers","following_url":"https://api.github.com/users/ipython/following{/other_user}","gists_url":"https://api.github.com/users/ipython/gists{/gist_id}","starred_url":"https://api.github.com/users/ipython/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipython/subscriptions","organizations_url":"https://api.github.com/users/ipython/orgs","repos_url":"https://api.github.com/users/ipython/repos","events_url":"https://api.github.com/users/ipython/events{/privacy}","received_events_url":"https://api.github.com/users/ipython/received_events","type":"Organization","site_admin":false},"repo":{"id":658518,"name":"ipython","full_name":"ipython/ipython","owner":{"login":"ipython","id":230453,"avatar_url":"https://avatars.githubusercontent.com/u/230453?","gravatar_id":"f72497397dd9a0a79c654c8182460bb1","url":"https://api.github.com/users/ipython","html_url":"https://github.com/ipython","followers_url":"https://api.github.com/users/ipython/followers","following_url":"https://api.github.com/users/ipython/following{/other_user}","gists_url":"https://api.github.com/users/ipython/gists{/gist_id}","starred_url":"https://api.github.com/users/ipython/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipython/subscriptions","organizations_url":"https://api.github.com/users/ipython/orgs","repos_url":"https://api.github.com/users/ipython/repos","events_url":"https://api.github.com/users/ipython/events{/privacy}","received_events_url":"https://api.github.com/users/ipython/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ipython/ipython","description":"Official repository for IPython itself. Other repos in the IPython organization contain things like the website, documentation builds, etc.","fork":false,"url":"https://api.github.com/repos/ipython/ipython","forks_url":"https://api.github.com/repos/ipython/ipython/forks","keys_url":"https://api.github.com/repos/ipython/ipython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ipython/ipython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ipython/ipython/teams","hooks_url":"https://api.github.com/repos/ipython/ipython/hooks","issue_events_url":"https://api.github.com/repos/ipython/ipython/issues/events{/number}","events_url":"https://api.github.com/repos/ipython/ipython/events","assignees_url":"https://api.github.com/repos/ipython/ipython/assignees{/user}","branches_url":"https://api.github.com/repos/ipython/ipython/branches{/branch}","tags_url":"https://api.github.com/repos/ipython/ipython/tags","blobs_url":"https://api.github.com/repos/ipython/ipython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ipython/ipython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ipython/ipython/git/refs{/sha}","trees_url":"https://api.github.com/repos/ipython/ipython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ipython/ipython/statuses/{sha}","languages_url":"https://api.github.com/repos/ipython/ipython/languages","stargazers_url":"https://api.github.com/repos/ipython/ipython/stargazers","contributors_url":"https://api.github.com/repos/ipython/ipython/contributors","subscribers_url":"https://api.github.com/repos/ipython/ipython/subscribers","subscription_url":"https://api.github.com/repos/ipython/ipython/subscription","commits_url":"https://api.github.com/repos/ipython/ipython/commits{/sha}","git_commits_url":"https://api.github.com/repos/ipython/ipython/git/commits{/sha}","comments_url":"https://api.github.com/repos/ipython/ipython/comments{/number}","issue_comment_url":"https://api.github.com/repos/ipython/ipython/issues/comments/{number}","contents_url":"https://api.github.com/repos/ipython/ipython/contents/{+path}","compare_url":"https://api.github.com/repos/ipython/ipython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ipython/ipython/merges","archive_url":"https://api.github.com/repos/ipython/ipython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ipython/ipython/downloads","issues_url":"https://api.github.com/repos/ipython/ipython/issues{/number}","pulls_url":"https://api.github.com/repos/ipython/ipython/pulls{/number}","milestones_url":"https://api.github.com/repos/ipython/ipython/milestones{/number}","notifications_url":"https://api.github.com/repos/ipython/ipython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ipython/ipython/labels{/name}","releases_url":"https://api.github.com/repos/ipython/ipython/releases{/id}","created_at":"2010-05-10T04:46:06Z","updated_at":"2014-03-26T00:15:14Z","pushed_at":"2014-03-26T00:15:14Z","git_url":"git://github.com/ipython/ipython.git","ssh_url":"git@github.com:ipython/ipython.git","clone_url":"https://github.com/ipython/ipython.git","svn_url":"https://github.com/ipython/ipython","homepage":"http://ipython.org","size":91909,"stargazers_count":3412,"watchers_count":3412,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1003,"mirror_url":null,"open_issues_count":694,"forks":1003,"open_issues":694,"watchers":3412,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ipython/ipython/pulls/5426"},"html":{"href":"https://github.com/ipython/ipython/pull/5426"},"issue":{"href":"https://api.github.com/repos/ipython/ipython/issues/5426"},"comments":{"href":"https://api.github.com/repos/ipython/ipython/issues/5426/comments"},"review_comments":{"href":"https://api.github.com/repos/ipython/ipython/pulls/5426/comments"},"review_comment":{"href":"https://api.github.com/repos/ipython/ipython/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ipython/ipython/pulls/5426/commits"},"statuses":{"href":"https://api.github.com/repos/ipython/ipython/statuses/326b5fcdfe76d95e145818e8e7f0732b6d3de910"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"minrk","id":151929,"avatar_url":"https://avatars.githubusercontent.com/u/151929?","gravatar_id":"d5b897c37001627c2e3ad3c1e8a7e6fb","url":"https://api.github.com/users/minrk","html_url":"https://github.com/minrk","followers_url":"https://api.github.com/users/minrk/followers","following_url":"https://api.github.com/users/minrk/following{/other_user}","gists_url":"https://api.github.com/users/minrk/gists{/gist_id}","starred_url":"https://api.github.com/users/minrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minrk/subscriptions","organizations_url":"https://api.github.com/users/minrk/orgs","repos_url":"https://api.github.com/users/minrk/repos","events_url":"https://api.github.com/users/minrk/events{/privacy}","received_events_url":"https://api.github.com/users/minrk/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":51,"deletions":13,"changed_files":1}}