GitHub PullRequestReviewCommentEvent at 2014-12-26 11:39:47
Repository: vzlogger
Actor: andig
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/volkszaehler/vzlogger/pulls/comments/22282536","id":22282536,"diff_hunk":"@@ -136,12 +129,13 @@ Obis::Obis(const char *strClear) {\n }\n \n Obis::Obis(){\n-\t_obisId._raw[0]=0;\n-\t_obisId._raw[1]=0;\n-\t_obisId._raw[2]=0;\n-\t_obisId._raw[3]=0;\n-\t_obisId._raw[4]=0;\n-\t_obisId._raw[5]=0;\n+\t// to be more consistent we initialize with DC/255.","path":"src/Obis.cpp","position":42,"original_position":42,"commit_id":"3d28083466b852c6a684ddd7bff44d57b0c95708","original_commit_id":"3d28083466b852c6a684ddd7bff44d57b0c95708","user":{"login":"andig","id":184815,"avatar_url":"https://avatars.githubusercontent.com/u/184815?v=3","gravatar_id":"","url":"https://api.github.com/users/andig","html_url":"https://github.com/andig","followers_url":"https://api.github.com/users/andig/followers","following_url":"https://api.github.com/users/andig/following{/other_user}","gists_url":"https://api.github.com/users/andig/gists{/gist_id}","starred_url":"https://api.github.com/users/andig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andig/subscriptions","organizations_url":"https://api.github.com/users/andig/orgs","repos_url":"https://api.github.com/users/andig/repos","events_url":"https://api.github.com/users/andig/events{/privacy}","received_events_url":"https://api.github.com/users/andig/received_events","type":"User","site_admin":false},"body":"Should use DC instead of 255?","created_at":"2014-12-26T11:39:47Z","updated_at":"2014-12-26T11:39:47Z","html_url":"https://github.com/volkszaehler/vzlogger/pull/78#discussion_r22282536","pull_request_url":"https://api.github.com/repos/volkszaehler/vzlogger/pulls/78","_links":{"self":{"href":"https://api.github.com/repos/volkszaehler/vzlogger/pulls/comments/22282536"},"html":{"href":"https://github.com/volkszaehler/vzlogger/pull/78#discussion_r22282536"},"pull_request":{"href":"https://api.github.com/repos/volkszaehler/vzlogger/pulls/78"}}},"pull_request":{"url":"https://api.github.com/repos/volkszaehler/vzlogger/pulls/78","id":26594608,"html_url":"https://github.com/volkszaehler/vzlogger/pull/78","diff_url":"https://github.com/volkszaehler/vzlogger/pull/78.diff","patch_url":"https://github.com/volkszaehler/vzlogger/pull/78.patch","issue_url":"https://api.github.com/repos/volkszaehler/vzlogger/issues/78","number":78,"state":"open","locked":false,"title":"removed wildcard handling to fix #71","user":{"login":"mbehr1","id":3258891,"avatar_url":"https://avatars.githubusercontent.com/u/3258891?v=3","gravatar_id":"","url":"https://api.github.com/users/mbehr1","html_url":"https://github.com/mbehr1","followers_url":"https://api.github.com/users/mbehr1/followers","following_url":"https://api.github.com/users/mbehr1/following{/other_user}","gists_url":"https://api.github.com/users/mbehr1/gists{/gist_id}","starred_url":"https://api.github.com/users/mbehr1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbehr1/subscriptions","organizations_url":"https://api.github.com/users/mbehr1/orgs","repos_url":"https://api.github.com/users/mbehr1/repos","events_url":"https://api.github.com/users/mbehr1/events{/privacy}","received_events_url":"https://api.github.com/users/mbehr1/received_events","type":"User","site_admin":false},"body":"Following the discussion from #71 here are the changes:\r\n- disabled wildcard handling in Obis identifier comparison.\r\n- added stricter handling on parsing codes to throw an exception if hex codes are used or invalid numbers.\r\n- default Obis constructor now initializes with 0xff to be more in line with string parsing. \r\n- some more unit tests for obis\r\n- added exception handling for MeterD0 around Obis string parsing. Invalid values will just be ignored but parsing continued. Later we could remove the strong restriction to only allow obis_codes starting with 1 or 2 (especially since all EDIS meter will report 255....) but somebody with a Landis&Gyr E350 needs to test this first.\r\n\r\nI tested with my Hager EHZ361 and had no issues and no need to adjust my config file.\r\nPlease do intensive testing and let me know any issues.","created_at":"2014-12-26T09:01:50Z","updated_at":"2014-12-26T11:39:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7551107fe87b0c0ae2efac5fd2575fd1454d0c7a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/volkszaehler/vzlogger/pulls/78/commits","review_comments_url":"https://api.github.com/repos/volkszaehler/vzlogger/pulls/78/comments","review_comment_url":"https://api.github.com/repos/volkszaehler/vzlogger/pulls/comments/{number}","comments_url":"https://api.github.com/repos/volkszaehler/vzlogger/issues/78/comments","statuses_url":"https://api.github.com/repos/volkszaehler/vzlogger/statuses/3d28083466b852c6a684ddd7bff44d57b0c95708","head":{"label":"mbehr1:remove_wildcard","ref":"remove_wildcard","sha":"3d28083466b852c6a684ddd7bff44d57b0c95708","user":{"login":"mbehr1","id":3258891,"avatar_url":"https://avatars.githubusercontent.com/u/3258891?v=3","gravatar_id":"","url":"https://api.github.com/users/mbehr1","html_url":"https://github.com/mbehr1","followers_url":"https://api.github.com/users/mbehr1/followers","following_url":"https://api.github.com/users/mbehr1/following{/other_user}","gists_url":"https://api.github.com/users/mbehr1/gists{/gist_id}","starred_url":"https://api.github.com/users/mbehr1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbehr1/subscriptions","organizations_url":"https://api.github.com/users/mbehr1/orgs","repos_url":"https://api.github.com/users/mbehr1/repos","events_url":"https://api.github.com/users/mbehr1/events{/privacy}","received_events_url":"https://api.github.com/users/mbehr1/received_events","type":"User","site_admin":false},"repo":{"id":20813176,"name":"vzlogger","full_name":"mbehr1/vzlogger","owner":{"login":"mbehr1","id":3258891,"avatar_url":"https://avatars.githubusercontent.com/u/3258891?v=3","gravatar_id":"","url":"https://api.github.com/users/mbehr1","html_url":"https://github.com/mbehr1","followers_url":"https://api.github.com/users/mbehr1/followers","following_url":"https://api.github.com/users/mbehr1/following{/other_user}","gists_url":"https://api.github.com/users/mbehr1/gists{/gist_id}","starred_url":"https://api.github.com/users/mbehr1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbehr1/subscriptions","organizations_url":"https://api.github.com/users/mbehr1/orgs","repos_url":"https://api.github.com/users/mbehr1/repos","events_url":"https://api.github.com/users/mbehr1/events{/privacy}","received_events_url":"https://api.github.com/users/mbehr1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mbehr1/vzlogger","description":"Logging utility for several meters & sensors","fork":true,"url":"https://api.github.com/repos/mbehr1/vzlogger","forks_url":"https://api.github.com/repos/mbehr1/vzlogger/forks","keys_url":"https://api.github.com/repos/mbehr1/vzlogger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mbehr1/vzlogger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mbehr1/vzlogger/teams","hooks_url":"https://api.github.com/repos/mbehr1/vzlogger/hooks","issue_events_url":"https://api.github.com/repos/mbehr1/vzlogger/issues/events{/number}","events_url":"https://api.github.com/repos/mbehr1/vzlogger/events","assignees_url":"https://api.github.com/repos/mbehr1/vzlogger/assignees{/user}","branches_url":"https://api.github.com/repos/mbehr1/vzlogger/branches{/branch}","tags_url":"https://api.github.com/repos/mbehr1/vzlogger/tags","blobs_url":"https://api.github.com/repos/mbehr1/vzlogger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mbehr1/vzlogger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mbehr1/vzlogger/git/refs{/sha}","trees_url":"https://api.github.com/repos/mbehr1/vzlogger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mbehr1/vzlogger/statuses/{sha}","languages_url":"https://api.github.com/repos/mbehr1/vzlogger/languages","stargazers_url":"https://api.github.com/repos/mbehr1/vzlogger/stargazers","contributors_url":"https://api.github.com/repos/mbehr1/vzlogger/contributors","subscribers_url":"https://api.github.com/repos/mbehr1/vzlogger/subscribers","subscription_url":"https://api.github.com/repos/mbehr1/vzlogger/subscription","commits_url":"https://api.github.com/repos/mbehr1/vzlogger/commits{/sha}","git_commits_url":"https://api.github.com/repos/mbehr1/vzlogger/git/commits{/sha}","comments_url":"https://api.github.com/repos/mbehr1/vzlogger/comments{/number}","issue_comment_url":"https://api.github.com/repos/mbehr1/vzlogger/issues/comments/{number}","contents_url":"https://api.github.com/repos/mbehr1/vzlogger/contents/{+path}","compare_url":"https://api.github.com/repos/mbehr1/vzlogger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mbehr1/vzlogger/merges","archive_url":"https://api.github.com/repos/mbehr1/vzlogger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mbehr1/vzlogger/downloads","issues_url":"https://api.github.com/repos/mbehr1/vzlogger/issues{/number}","pulls_url":"https://api.github.com/repos/mbehr1/vzlogger/pulls{/number}","milestones_url":"https://api.github.com/repos/mbehr1/vzlogger/milestones{/number}","notifications_url":"https://api.github.com/repos/mbehr1/vzlogger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mbehr1/vzlogger/labels{/name}","releases_url":"https://api.github.com/repos/mbehr1/vzlogger/releases{/id}","created_at":"2014-06-13T18:07:39Z","updated_at":"2014-12-23T21:27:23Z","pushed_at":"2014-12-26T08:53:45Z","git_url":"git://github.com/mbehr1/vzlogger.git","ssh_url":"git@github.com:mbehr1/vzlogger.git","clone_url":"https://github.com/mbehr1/vzlogger.git","svn_url":"https://github.com/mbehr1/vzlogger","homepage":"http://wiki.volkszaehler.org/software/controller/vzlogger","size":2877,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"volkszaehler:master","ref":"master","sha":"9f4ada0077df50fa57daf600aa8ff0ab8ae49c2e","user":{"login":"volkszaehler","id":340617,"avatar_url":"https://avatars.githubusercontent.com/u/340617?v=3","gravatar_id":"","url":"https://api.github.com/users/volkszaehler","html_url":"https://github.com/volkszaehler","followers_url":"https://api.github.com/users/volkszaehler/followers","following_url":"https://api.github.com/users/volkszaehler/following{/other_user}","gists_url":"https://api.github.com/users/volkszaehler/gists{/gist_id}","starred_url":"https://api.github.com/users/volkszaehler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/volkszaehler/subscriptions","organizations_url":"https://api.github.com/users/volkszaehler/orgs","repos_url":"https://api.github.com/users/volkszaehler/repos","events_url":"https://api.github.com/users/volkszaehler/events{/privacy}","received_events_url":"https://api.github.com/users/volkszaehler/received_events","type":"Organization","site_admin":false},"repo":{"id":2298269,"name":"vzlogger","full_name":"volkszaehler/vzlogger","owner":{"login":"volkszaehler","id":340617,"avatar_url":"https://avatars.githubusercontent.com/u/340617?v=3","gravatar_id":"","url":"https://api.github.com/users/volkszaehler","html_url":"https://github.com/volkszaehler","followers_url":"https://api.github.com/users/volkszaehler/followers","following_url":"https://api.github.com/users/volkszaehler/following{/other_user}","gists_url":"https://api.github.com/users/volkszaehler/gists{/gist_id}","starred_url":"https://api.github.com/users/volkszaehler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/volkszaehler/subscriptions","organizations_url":"https://api.github.com/users/volkszaehler/orgs","repos_url":"https://api.github.com/users/volkszaehler/repos","events_url":"https://api.github.com/users/volkszaehler/events{/privacy}","received_events_url":"https://api.github.com/users/volkszaehler/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/volkszaehler/vzlogger","description":"Logging utility for several meters & sensors","fork":false,"url":"https://api.github.com/repos/volkszaehler/vzlogger","forks_url":"https://api.github.com/repos/volkszaehler/vzlogger/forks","keys_url":"https://api.github.com/repos/volkszaehler/vzlogger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/volkszaehler/vzlogger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/volkszaehler/vzlogger/teams","hooks_url":"https://api.github.com/repos/volkszaehler/vzlogger/hooks","issue_events_url":"https://api.github.com/repos/volkszaehler/vzlogger/issues/events{/number}","events_url":"https://api.github.com/repos/volkszaehler/vzlogger/events","assignees_url":"https://api.github.com/repos/volkszaehler/vzlogger/assignees{/user}","branches_url":"https://api.github.com/repos/volkszaehler/vzlogger/branches{/branch}","tags_url":"https://api.github.com/repos/volkszaehler/vzlogger/tags","blobs_url":"https://api.github.com/repos/volkszaehler/vzlogger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/volkszaehler/vzlogger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/volkszaehler/vzlogger/git/refs{/sha}","trees_url":"https://api.github.com/repos/volkszaehler/vzlogger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/volkszaehler/vzlogger/statuses/{sha}","languages_url":"https://api.github.com/repos/volkszaehler/vzlogger/languages","stargazers_url":"https://api.github.com/repos/volkszaehler/vzlogger/stargazers","contributors_url":"https://api.github.com/repos/volkszaehler/vzlogger/contributors","subscribers_url":"https://api.github.com/repos/volkszaehler/vzlogger/subscribers","subscription_url":"https://api.github.com/repos/volkszaehler/vzlogger/subscription","commits_url":"https://api.github.com/repos/volkszaehler/vzlogger/commits{/sha}","git_commits_url":"https://api.github.com/repos/volkszaehler/vzlogger/git/commits{/sha}","comments_url":"https://api.github.com/repos/volkszaehler/vzlogger/comments{/number}","issue_comment_url":"https://api.github.com/repos/volkszaehler/vzlogger/issues/comments/{number}","contents_url":"https://api.github.com/repos/volkszaehler/vzlogger/contents/{+path}","compare_url":"https://api.github.com/repos/volkszaehler/vzlogger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/volkszaehler/vzlogger/merges","archive_url":"https://api.github.com/repos/volkszaehler/vzlogger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/volkszaehler/vzlogger/downloads","issues_url":"https://api.github.com/repos/volkszaehler/vzlogger/issues{/number}","pulls_url":"https://api.github.com/repos/volkszaehler/vzlogger/pulls{/number}","milestones_url":"https://api.github.com/repos/volkszaehler/vzlogger/milestones{/number}","notifications_url":"https://api.github.com/repos/volkszaehler/vzlogger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/volkszaehler/vzlogger/labels{/name}","releases_url":"https://api.github.com/repos/volkszaehler/vzlogger/releases{/id}","created_at":"2011-08-30T22:41:50Z","updated_at":"2014-12-23T20:00:43Z","pushed_at":"2014-12-23T20:00:43Z","git_url":"git://github.com/volkszaehler/vzlogger.git","ssh_url":"git@github.com:volkszaehler/vzlogger.git","clone_url":"https://github.com/volkszaehler/vzlogger.git","svn_url":"https://github.com/volkszaehler/vzlogger","homepage":"http://wiki.volkszaehler.org/software/controller/vzlogger","size":3039,"stargazers_count":10,"watchers_count":10,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":9,"forks":22,"open_issues":9,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/volkszaehler/vzlogger/pulls/78"},"html":{"href":"https://github.com/volkszaehler/vzlogger/pull/78"},"issue":{"href":"https://api.github.com/repos/volkszaehler/vzlogger/issues/78"},"comments":{"href":"https://api.github.com/repos/volkszaehler/vzlogger/issues/78/comments"},"review_comments":{"href":"https://api.github.com/repos/volkszaehler/vzlogger/pulls/78/comments"},"review_comment":{"href":"https://api.github.com/repos/volkszaehler/vzlogger/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/volkszaehler/vzlogger/pulls/78/commits"},"statuses":{"href":"https://api.github.com/repos/volkszaehler/vzlogger/statuses/3d28083466b852c6a684ddd7bff44d57b0c95708"}}}}