GitHub PullRequestReviewCommentEvent at 2014-06-17 17:18:59
Repository: aead
Actor: Lordnibbler
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/onelogin/aead/pulls/comments/13872529","id":13872529,"diff_hunk":"@@ -110,7 +111,7 @@ def nonce_len\n   #\n   def encrypt(nonce, aad, plaintext)\n     _verify_nonce_bytesize(nonce, self.nonce_len)\n-    _verify_plaintext_presence(plaintext)\n+    #_verify_plaintext_presence(plaintext)","path":"lib/aead/cipher.rb","position":22,"original_position":22,"commit_id":"63a7589977f5b713f25acac76758e42db6ddc996","original_commit_id":"63a7589977f5b713f25acac76758e42db6ddc996","user":{"login":"Lordnibbler","id":199422,"avatar_url":"https://avatars.githubusercontent.com/u/199422?","gravatar_id":"667204dab1087ca67d197e6b064113df","url":"https://api.github.com/users/Lordnibbler","html_url":"https://github.com/Lordnibbler","followers_url":"https://api.github.com/users/Lordnibbler/followers","following_url":"https://api.github.com/users/Lordnibbler/following{/other_user}","gists_url":"https://api.github.com/users/Lordnibbler/gists{/gist_id}","starred_url":"https://api.github.com/users/Lordnibbler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lordnibbler/subscriptions","organizations_url":"https://api.github.com/users/Lordnibbler/orgs","repos_url":"https://api.github.com/users/Lordnibbler/repos","events_url":"https://api.github.com/users/Lordnibbler/events{/privacy}","received_events_url":"https://api.github.com/users/Lordnibbler/received_events","type":"User","site_admin":false},"body":"rather than commenting out, can you nuke this line?","created_at":"2014-06-17T17:18:59Z","updated_at":"2014-06-17T17:18:59Z","html_url":"https://github.com/onelogin/aead/pull/3#discussion_r13872529","pull_request_url":"https://api.github.com/repos/onelogin/aead/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/onelogin/aead/pulls/comments/13872529"},"html":{"href":"https://github.com/onelogin/aead/pull/3#discussion_r13872529"},"pull_request":{"href":"https://api.github.com/repos/onelogin/aead/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/onelogin/aead/pulls/3","id":7439272,"html_url":"https://github.com/onelogin/aead/pull/3","diff_url":"https://github.com/onelogin/aead/pull/3.diff","patch_url":"https://github.com/onelogin/aead/pull/3.patch","issue_url":"https://api.github.com/repos/onelogin/aead/issues/3","number":3,"state":"open","title":"Added AES-128-GCM cipher with some extra options","user":{"login":"AKoetsier","id":523991,"avatar_url":"https://avatars.githubusercontent.com/u/523991?","gravatar_id":"77275ed61564066b0977bea1d5953fef","url":"https://api.github.com/users/AKoetsier","html_url":"https://github.com/AKoetsier","followers_url":"https://api.github.com/users/AKoetsier/followers","following_url":"https://api.github.com/users/AKoetsier/following{/other_user}","gists_url":"https://api.github.com/users/AKoetsier/gists{/gist_id}","starred_url":"https://api.github.com/users/AKoetsier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AKoetsier/subscriptions","organizations_url":"https://api.github.com/users/AKoetsier/orgs","repos_url":"https://api.github.com/users/AKoetsier/repos","events_url":"https://api.github.com/users/AKoetsier/events{/privacy}","received_events_url":"https://api.github.com/users/AKoetsier/received_events","type":"User","site_admin":false},"body":"Added AES-128-GCM cipher with possibility to set iv-length on BCM-mode and allow empty text to be 'encrypted' for computational purposes.","created_at":"2013-08-07T08:30:28Z","updated_at":"2014-06-17T17:18:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ad4e24126924a9266d5de8c8a7267982b1e957bd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/onelogin/aead/pulls/3/commits","review_comments_url":"https://api.github.com/repos/onelogin/aead/pulls/3/comments","review_comment_url":"https://api.github.com/repos/onelogin/aead/pulls/comments/{number}","comments_url":"https://api.github.com/repos/onelogin/aead/issues/3/comments","statuses_url":"https://api.github.com/repos/onelogin/aead/statuses/63a7589977f5b713f25acac76758e42db6ddc996","head":{"label":"AKoetsier:master","ref":"master","sha":"63a7589977f5b713f25acac76758e42db6ddc996","user":{"login":"AKoetsier","id":523991,"avatar_url":"https://avatars.githubusercontent.com/u/523991?","gravatar_id":"77275ed61564066b0977bea1d5953fef","url":"https://api.github.com/users/AKoetsier","html_url":"https://github.com/AKoetsier","followers_url":"https://api.github.com/users/AKoetsier/followers","following_url":"https://api.github.com/users/AKoetsier/following{/other_user}","gists_url":"https://api.github.com/users/AKoetsier/gists{/gist_id}","starred_url":"https://api.github.com/users/AKoetsier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AKoetsier/subscriptions","organizations_url":"https://api.github.com/users/AKoetsier/orgs","repos_url":"https://api.github.com/users/AKoetsier/repos","events_url":"https://api.github.com/users/AKoetsier/events{/privacy}","received_events_url":"https://api.github.com/users/AKoetsier/received_events","type":"User","site_admin":false},"repo":{"id":11603300,"name":"aead","full_name":"AKoetsier/aead","owner":{"login":"AKoetsier","id":523991,"avatar_url":"https://avatars.githubusercontent.com/u/523991?","gravatar_id":"77275ed61564066b0977bea1d5953fef","url":"https://api.github.com/users/AKoetsier","html_url":"https://github.com/AKoetsier","followers_url":"https://api.github.com/users/AKoetsier/followers","following_url":"https://api.github.com/users/AKoetsier/following{/other_user}","gists_url":"https://api.github.com/users/AKoetsier/gists{/gist_id}","starred_url":"https://api.github.com/users/AKoetsier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AKoetsier/subscriptions","organizations_url":"https://api.github.com/users/AKoetsier/orgs","repos_url":"https://api.github.com/users/AKoetsier/repos","events_url":"https://api.github.com/users/AKoetsier/events{/privacy}","received_events_url":"https://api.github.com/users/AKoetsier/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AKoetsier/aead","description":null,"fork":true,"url":"https://api.github.com/repos/AKoetsier/aead","forks_url":"https://api.github.com/repos/AKoetsier/aead/forks","keys_url":"https://api.github.com/repos/AKoetsier/aead/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AKoetsier/aead/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AKoetsier/aead/teams","hooks_url":"https://api.github.com/repos/AKoetsier/aead/hooks","issue_events_url":"https://api.github.com/repos/AKoetsier/aead/issues/events{/number}","events_url":"https://api.github.com/repos/AKoetsier/aead/events","assignees_url":"https://api.github.com/repos/AKoetsier/aead/assignees{/user}","branches_url":"https://api.github.com/repos/AKoetsier/aead/branches{/branch}","tags_url":"https://api.github.com/repos/AKoetsier/aead/tags","blobs_url":"https://api.github.com/repos/AKoetsier/aead/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AKoetsier/aead/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AKoetsier/aead/git/refs{/sha}","trees_url":"https://api.github.com/repos/AKoetsier/aead/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AKoetsier/aead/statuses/{sha}","languages_url":"https://api.github.com/repos/AKoetsier/aead/languages","stargazers_url":"https://api.github.com/repos/AKoetsier/aead/stargazers","contributors_url":"https://api.github.com/repos/AKoetsier/aead/contributors","subscribers_url":"https://api.github.com/repos/AKoetsier/aead/subscribers","subscription_url":"https://api.github.com/repos/AKoetsier/aead/subscription","commits_url":"https://api.github.com/repos/AKoetsier/aead/commits{/sha}","git_commits_url":"https://api.github.com/repos/AKoetsier/aead/git/commits{/sha}","comments_url":"https://api.github.com/repos/AKoetsier/aead/comments{/number}","issue_comment_url":"https://api.github.com/repos/AKoetsier/aead/issues/comments/{number}","contents_url":"https://api.github.com/repos/AKoetsier/aead/contents/{+path}","compare_url":"https://api.github.com/repos/AKoetsier/aead/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AKoetsier/aead/merges","archive_url":"https://api.github.com/repos/AKoetsier/aead/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AKoetsier/aead/downloads","issues_url":"https://api.github.com/repos/AKoetsier/aead/issues{/number}","pulls_url":"https://api.github.com/repos/AKoetsier/aead/pulls{/number}","milestones_url":"https://api.github.com/repos/AKoetsier/aead/milestones{/number}","notifications_url":"https://api.github.com/repos/AKoetsier/aead/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AKoetsier/aead/labels{/name}","releases_url":"https://api.github.com/repos/AKoetsier/aead/releases{/id}","created_at":"2013-07-23T08:23:10Z","updated_at":"2013-08-07T08:30:28Z","pushed_at":"2013-07-23T13:54:08Z","git_url":"git://github.com/AKoetsier/aead.git","ssh_url":"git@github.com:AKoetsier/aead.git","clone_url":"https://github.com/AKoetsier/aead.git","svn_url":"https://github.com/AKoetsier/aead","homepage":null,"size":116,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"onelogin:master","ref":"master","sha":"65154a8e5f790e34b6446f5b27709fbbb80cf3d8","user":{"login":"onelogin","id":263373,"avatar_url":"https://avatars.githubusercontent.com/u/263373?","gravatar_id":null,"url":"https://api.github.com/users/onelogin","html_url":"https://github.com/onelogin","followers_url":"https://api.github.com/users/onelogin/followers","following_url":"https://api.github.com/users/onelogin/following{/other_user}","gists_url":"https://api.github.com/users/onelogin/gists{/gist_id}","starred_url":"https://api.github.com/users/onelogin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onelogin/subscriptions","organizations_url":"https://api.github.com/users/onelogin/orgs","repos_url":"https://api.github.com/users/onelogin/repos","events_url":"https://api.github.com/users/onelogin/events{/privacy}","received_events_url":"https://api.github.com/users/onelogin/received_events","type":"Organization","site_admin":false},"repo":{"id":5801236,"name":"aead","full_name":"onelogin/aead","owner":{"login":"onelogin","id":263373,"avatar_url":"https://avatars.githubusercontent.com/u/263373?","gravatar_id":null,"url":"https://api.github.com/users/onelogin","html_url":"https://github.com/onelogin","followers_url":"https://api.github.com/users/onelogin/followers","following_url":"https://api.github.com/users/onelogin/following{/other_user}","gists_url":"https://api.github.com/users/onelogin/gists{/gist_id}","starred_url":"https://api.github.com/users/onelogin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onelogin/subscriptions","organizations_url":"https://api.github.com/users/onelogin/orgs","repos_url":"https://api.github.com/users/onelogin/repos","events_url":"https://api.github.com/users/onelogin/events{/privacy}","received_events_url":"https://api.github.com/users/onelogin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/onelogin/aead","description":null,"fork":false,"url":"https://api.github.com/repos/onelogin/aead","forks_url":"https://api.github.com/repos/onelogin/aead/forks","keys_url":"https://api.github.com/repos/onelogin/aead/keys{/key_id}","collaborators_url":"https://api.github.com/repos/onelogin/aead/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/onelogin/aead/teams","hooks_url":"https://api.github.com/repos/onelogin/aead/hooks","issue_events_url":"https://api.github.com/repos/onelogin/aead/issues/events{/number}","events_url":"https://api.github.com/repos/onelogin/aead/events","assignees_url":"https://api.github.com/repos/onelogin/aead/assignees{/user}","branches_url":"https://api.github.com/repos/onelogin/aead/branches{/branch}","tags_url":"https://api.github.com/repos/onelogin/aead/tags","blobs_url":"https://api.github.com/repos/onelogin/aead/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/onelogin/aead/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/onelogin/aead/git/refs{/sha}","trees_url":"https://api.github.com/repos/onelogin/aead/git/trees{/sha}","statuses_url":"https://api.github.com/repos/onelogin/aead/statuses/{sha}","languages_url":"https://api.github.com/repos/onelogin/aead/languages","stargazers_url":"https://api.github.com/repos/onelogin/aead/stargazers","contributors_url":"https://api.github.com/repos/onelogin/aead/contributors","subscribers_url":"https://api.github.com/repos/onelogin/aead/subscribers","subscription_url":"https://api.github.com/repos/onelogin/aead/subscription","commits_url":"https://api.github.com/repos/onelogin/aead/commits{/sha}","git_commits_url":"https://api.github.com/repos/onelogin/aead/git/commits{/sha}","comments_url":"https://api.github.com/repos/onelogin/aead/comments{/number}","issue_comment_url":"https://api.github.com/repos/onelogin/aead/issues/comments/{number}","contents_url":"https://api.github.com/repos/onelogin/aead/contents/{+path}","compare_url":"https://api.github.com/repos/onelogin/aead/compare/{base}...{head}","merges_url":"https://api.github.com/repos/onelogin/aead/merges","archive_url":"https://api.github.com/repos/onelogin/aead/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/onelogin/aead/downloads","issues_url":"https://api.github.com/repos/onelogin/aead/issues{/number}","pulls_url":"https://api.github.com/repos/onelogin/aead/pulls{/number}","milestones_url":"https://api.github.com/repos/onelogin/aead/milestones{/number}","notifications_url":"https://api.github.com/repos/onelogin/aead/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/onelogin/aead/labels{/name}","releases_url":"https://api.github.com/repos/onelogin/aead/releases{/id}","created_at":"2012-09-13T21:20:32Z","updated_at":"2014-06-17T17:18:33Z","pushed_at":"2014-06-17T17:18:33Z","git_url":"git://github.com/onelogin/aead.git","ssh_url":"git@github.com:onelogin/aead.git","clone_url":"https://github.com/onelogin/aead.git","svn_url":"https://github.com/onelogin/aead","homepage":null,"size":337,"stargazers_count":8,"watchers_count":8,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":4,"mirror_url":null,"open_issues_count":2,"forks":4,"open_issues":2,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/onelogin/aead/pulls/3"},"html":{"href":"https://github.com/onelogin/aead/pull/3"},"issue":{"href":"https://api.github.com/repos/onelogin/aead/issues/3"},"comments":{"href":"https://api.github.com/repos/onelogin/aead/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/onelogin/aead/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/onelogin/aead/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/onelogin/aead/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/onelogin/aead/statuses/63a7589977f5b713f25acac76758e42db6ddc996"}}}}