GitHub PullRequestReviewCommentEvent at 2014-06-18 17:13:16
Repository: osTicket-1.8
Actor: greezybacon
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/osTicket/osTicket-1.8/pulls/comments/13927239","id":13927239,"diff_hunk":"@@ -446,6 +450,21 @@ function getAttachments($part, $index=0) {\n                     && $part->type > 0) {\n                 $filename = $this->findFilename($part->parameters);\n             }\n+            if (!$filename && strcasecmp('message/rfc822',$mime ) == 0\n+                    && $part->type > 0\n+                ) {\n+                $headers = imap_rfc822_parse_headers(imap_fetchbody($this->mbox, 1, '3'));","path":"include/class.mailfetch.php","position":29,"original_position":29,"commit_id":"0df9f5a08ad844873c742e66b85d5ebc6831ba6a","original_commit_id":"0df9f5a08ad844873c742e66b85d5ebc6831ba6a","user":{"login":"greezybacon","id":672074,"avatar_url":"https://avatars.githubusercontent.com/u/672074?","gravatar_id":"9c3620f41b41a013dfc20fbc90eb19ed","url":"https://api.github.com/users/greezybacon","html_url":"https://github.com/greezybacon","followers_url":"https://api.github.com/users/greezybacon/followers","following_url":"https://api.github.com/users/greezybacon/following{/other_user}","gists_url":"https://api.github.com/users/greezybacon/gists{/gist_id}","starred_url":"https://api.github.com/users/greezybacon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greezybacon/subscriptions","organizations_url":"https://api.github.com/users/greezybacon/orgs","repos_url":"https://api.github.com/users/greezybacon/repos","events_url":"https://api.github.com/users/greezybacon/events{/privacy}","received_events_url":"https://api.github.com/users/greezybacon/received_events","type":"User","site_admin":false},"body":"'3' here should be `$index`?","created_at":"2014-06-18T17:13:16Z","updated_at":"2014-06-18T17:13:16Z","html_url":"https://github.com/osTicket/osTicket-1.8/pull/715#discussion_r13927239","pull_request_url":"https://api.github.com/repos/osTicket/osTicket-1.8/pulls/715","_links":{"self":{"href":"https://api.github.com/repos/osTicket/osTicket-1.8/pulls/comments/13927239"},"html":{"href":"https://github.com/osTicket/osTicket-1.8/pull/715#discussion_r13927239"},"pull_request":{"href":"https://api.github.com/repos/osTicket/osTicket-1.8/pulls/715"}}},"pull_request":{"url":"https://api.github.com/repos/osTicket/osTicket-1.8/pulls/715","id":13828087,"html_url":"https://github.com/osTicket/osTicket-1.8/pull/715","diff_url":"https://github.com/osTicket/osTicket-1.8/pull/715.diff","patch_url":"https://github.com/osTicket/osTicket-1.8/pull/715.patch","issue_url":"https://api.github.com/repos/osTicket/osTicket-1.8/issues/715","number":715,"state":"open","title":"Control whatever to read attached RFC822 mail content","user":{"login":"kasper-f","id":2758723,"avatar_url":"https://avatars.githubusercontent.com/u/2758723?","gravatar_id":"c80df0cd48f8682a8039b68f374e7e5a","url":"https://api.github.com/users/kasper-f","html_url":"https://github.com/kasper-f","followers_url":"https://api.github.com/users/kasper-f/followers","following_url":"https://api.github.com/users/kasper-f/following{/other_user}","gists_url":"https://api.github.com/users/kasper-f/gists{/gist_id}","starred_url":"https://api.github.com/users/kasper-f/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kasper-f/subscriptions","organizations_url":"https://api.github.com/users/kasper-f/orgs","repos_url":"https://api.github.com/users/kasper-f/repos","events_url":"https://api.github.com/users/kasper-f/events{/privacy}","received_events_url":"https://api.github.com/users/kasper-f/received_events","type":"User","site_admin":false},"body":"Reading into the attached RFC822 message as osTicket does by default may cause troubles when the first mail section does not contain a content type text/html. OsTicket will in this case use the body from the attached mail as content as it searches recursive for text/html content first. Email clients will normally show this messages as attachments\r\n\r\nWe have several cases where emails are handled wrongly especially spam reports.\r\n\r\nThis change will add an option in the admin panel settings->email tab to control whatever the inline message content should be read or treated as an attachment by osTicket","created_at":"2014-03-21T09:29:55Z","updated_at":"2014-06-18T17:13:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"97bbf43edea9c962bfd2dc6a76017f7822d2f159","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/osTicket/osTicket-1.8/pulls/715/commits","review_comments_url":"https://api.github.com/repos/osTicket/osTicket-1.8/pulls/715/comments","review_comment_url":"https://api.github.com/repos/osTicket/osTicket-1.8/pulls/comments/{number}","comments_url":"https://api.github.com/repos/osTicket/osTicket-1.8/issues/715/comments","statuses_url":"https://api.github.com/repos/osTicket/osTicket-1.8/statuses/0df9f5a08ad844873c742e66b85d5ebc6831ba6a","head":{"label":"kasper-f:develop","ref":"develop","sha":"0df9f5a08ad844873c742e66b85d5ebc6831ba6a","user":{"login":"kasper-f","id":2758723,"avatar_url":"https://avatars.githubusercontent.com/u/2758723?","gravatar_id":"c80df0cd48f8682a8039b68f374e7e5a","url":"https://api.github.com/users/kasper-f","html_url":"https://github.com/kasper-f","followers_url":"https://api.github.com/users/kasper-f/followers","following_url":"https://api.github.com/users/kasper-f/following{/other_user}","gists_url":"https://api.github.com/users/kasper-f/gists{/gist_id}","starred_url":"https://api.github.com/users/kasper-f/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kasper-f/subscriptions","organizations_url":"https://api.github.com/users/kasper-f/orgs","repos_url":"https://api.github.com/users/kasper-f/repos","events_url":"https://api.github.com/users/kasper-f/events{/privacy}","received_events_url":"https://api.github.com/users/kasper-f/received_events","type":"User","site_admin":false},"repo":{"id":17973625,"name":"osTicket-1.8","full_name":"kasper-f/osTicket-1.8","owner":{"login":"kasper-f","id":2758723,"avatar_url":"https://avatars.githubusercontent.com/u/2758723?","gravatar_id":"c80df0cd48f8682a8039b68f374e7e5a","url":"https://api.github.com/users/kasper-f","html_url":"https://github.com/kasper-f","followers_url":"https://api.github.com/users/kasper-f/followers","following_url":"https://api.github.com/users/kasper-f/following{/other_user}","gists_url":"https://api.github.com/users/kasper-f/gists{/gist_id}","starred_url":"https://api.github.com/users/kasper-f/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kasper-f/subscriptions","organizations_url":"https://api.github.com/users/kasper-f/orgs","repos_url":"https://api.github.com/users/kasper-f/repos","events_url":"https://api.github.com/users/kasper-f/events{/privacy}","received_events_url":"https://api.github.com/users/kasper-f/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kasper-f/osTicket-1.8","description":"Codename: Rumors","fork":true,"url":"https://api.github.com/repos/kasper-f/osTicket-1.8","forks_url":"https://api.github.com/repos/kasper-f/osTicket-1.8/forks","keys_url":"https://api.github.com/repos/kasper-f/osTicket-1.8/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kasper-f/osTicket-1.8/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kasper-f/osTicket-1.8/teams","hooks_url":"https://api.github.com/repos/kasper-f/osTicket-1.8/hooks","issue_events_url":"https://api.github.com/repos/kasper-f/osTicket-1.8/issues/events{/number}","events_url":"https://api.github.com/repos/kasper-f/osTicket-1.8/events","assignees_url":"https://api.github.com/repos/kasper-f/osTicket-1.8/assignees{/user}","branches_url":"https://api.github.com/repos/kasper-f/osTicket-1.8/branches{/branch}","tags_url":"https://api.github.com/repos/kasper-f/osTicket-1.8/tags","blobs_url":"https://api.github.com/repos/kasper-f/osTicket-1.8/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kasper-f/osTicket-1.8/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kasper-f/osTicket-1.8/git/refs{/sha}","trees_url":"https://api.github.com/repos/kasper-f/osTicket-1.8/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kasper-f/osTicket-1.8/statuses/{sha}","languages_url":"https://api.github.com/repos/kasper-f/osTicket-1.8/languages","stargazers_url":"https://api.github.com/repos/kasper-f/osTicket-1.8/stargazers","contributors_url":"https://api.github.com/repos/kasper-f/osTicket-1.8/contributors","subscribers_url":"https://api.github.com/repos/kasper-f/osTicket-1.8/subscribers","subscription_url":"https://api.github.com/repos/kasper-f/osTicket-1.8/subscription","commits_url":"https://api.github.com/repos/kasper-f/osTicket-1.8/commits{/sha}","git_commits_url":"https://api.github.com/repos/kasper-f/osTicket-1.8/git/commits{/sha}","comments_url":"https://api.github.com/repos/kasper-f/osTicket-1.8/comments{/number}","issue_comment_url":"https://api.github.com/repos/kasper-f/osTicket-1.8/issues/comments/{number}","contents_url":"https://api.github.com/repos/kasper-f/osTicket-1.8/contents/{+path}","compare_url":"https://api.github.com/repos/kasper-f/osTicket-1.8/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kasper-f/osTicket-1.8/merges","archive_url":"https://api.github.com/repos/kasper-f/osTicket-1.8/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kasper-f/osTicket-1.8/downloads","issues_url":"https://api.github.com/repos/kasper-f/osTicket-1.8/issues{/number}","pulls_url":"https://api.github.com/repos/kasper-f/osTicket-1.8/pulls{/number}","milestones_url":"https://api.github.com/repos/kasper-f/osTicket-1.8/milestones{/number}","notifications_url":"https://api.github.com/repos/kasper-f/osTicket-1.8/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kasper-f/osTicket-1.8/labels{/name}","releases_url":"https://api.github.com/repos/kasper-f/osTicket-1.8/releases{/id}","created_at":"2014-03-21T08:52:36Z","updated_at":"2014-04-22T10:53:16Z","pushed_at":"2014-04-22T10:53:16Z","git_url":"git://github.com/kasper-f/osTicket-1.8.git","ssh_url":"git@github.com:kasper-f/osTicket-1.8.git","clone_url":"https://github.com/kasper-f/osTicket-1.8.git","svn_url":"https://github.com/kasper-f/osTicket-1.8","homepage":null,"size":10835,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"osTicket:develop","ref":"develop","sha":"1c757ba4fce57d2a2caef00a9e2fc8f502ca3ad0","user":{"login":"osTicket","id":371413,"avatar_url":"https://avatars.githubusercontent.com/u/371413?","gravatar_id":"b09d4d61892d9ab0f63d29650a4ad9a6","url":"https://api.github.com/users/osTicket","html_url":"https://github.com/osTicket","followers_url":"https://api.github.com/users/osTicket/followers","following_url":"https://api.github.com/users/osTicket/following{/other_user}","gists_url":"https://api.github.com/users/osTicket/gists{/gist_id}","starred_url":"https://api.github.com/users/osTicket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osTicket/subscriptions","organizations_url":"https://api.github.com/users/osTicket/orgs","repos_url":"https://api.github.com/users/osTicket/repos","events_url":"https://api.github.com/users/osTicket/events{/privacy}","received_events_url":"https://api.github.com/users/osTicket/received_events","type":"Organization","site_admin":false},"repo":{"id":12063996,"name":"osTicket-1.8","full_name":"osTicket/osTicket-1.8","owner":{"login":"osTicket","id":371413,"avatar_url":"https://avatars.githubusercontent.com/u/371413?","gravatar_id":"b09d4d61892d9ab0f63d29650a4ad9a6","url":"https://api.github.com/users/osTicket","html_url":"https://github.com/osTicket","followers_url":"https://api.github.com/users/osTicket/followers","following_url":"https://api.github.com/users/osTicket/following{/other_user}","gists_url":"https://api.github.com/users/osTicket/gists{/gist_id}","starred_url":"https://api.github.com/users/osTicket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osTicket/subscriptions","organizations_url":"https://api.github.com/users/osTicket/orgs","repos_url":"https://api.github.com/users/osTicket/repos","events_url":"https://api.github.com/users/osTicket/events{/privacy}","received_events_url":"https://api.github.com/users/osTicket/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/osTicket/osTicket-1.8","description":"Codename: Rumors","fork":false,"url":"https://api.github.com/repos/osTicket/osTicket-1.8","forks_url":"https://api.github.com/repos/osTicket/osTicket-1.8/forks","keys_url":"https://api.github.com/repos/osTicket/osTicket-1.8/keys{/key_id}","collaborators_url":"https://api.github.com/repos/osTicket/osTicket-1.8/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/osTicket/osTicket-1.8/teams","hooks_url":"https://api.github.com/repos/osTicket/osTicket-1.8/hooks","issue_events_url":"https://api.github.com/repos/osTicket/osTicket-1.8/issues/events{/number}","events_url":"https://api.github.com/repos/osTicket/osTicket-1.8/events","assignees_url":"https://api.github.com/repos/osTicket/osTicket-1.8/assignees{/user}","branches_url":"https://api.github.com/repos/osTicket/osTicket-1.8/branches{/branch}","tags_url":"https://api.github.com/repos/osTicket/osTicket-1.8/tags","blobs_url":"https://api.github.com/repos/osTicket/osTicket-1.8/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/osTicket/osTicket-1.8/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/osTicket/osTicket-1.8/git/refs{/sha}","trees_url":"https://api.github.com/repos/osTicket/osTicket-1.8/git/trees{/sha}","statuses_url":"https://api.github.com/repos/osTicket/osTicket-1.8/statuses/{sha}","languages_url":"https://api.github.com/repos/osTicket/osTicket-1.8/languages","stargazers_url":"https://api.github.com/repos/osTicket/osTicket-1.8/stargazers","contributors_url":"https://api.github.com/repos/osTicket/osTicket-1.8/contributors","subscribers_url":"https://api.github.com/repos/osTicket/osTicket-1.8/subscribers","subscription_url":"https://api.github.com/repos/osTicket/osTicket-1.8/subscription","commits_url":"https://api.github.com/repos/osTicket/osTicket-1.8/commits{/sha}","git_commits_url":"https://api.github.com/repos/osTicket/osTicket-1.8/git/commits{/sha}","comments_url":"https://api.github.com/repos/osTicket/osTicket-1.8/comments{/number}","issue_comment_url":"https://api.github.com/repos/osTicket/osTicket-1.8/issues/comments/{number}","contents_url":"https://api.github.com/repos/osTicket/osTicket-1.8/contents/{+path}","compare_url":"https://api.github.com/repos/osTicket/osTicket-1.8/compare/{base}...{head}","merges_url":"https://api.github.com/repos/osTicket/osTicket-1.8/merges","archive_url":"https://api.github.com/repos/osTicket/osTicket-1.8/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/osTicket/osTicket-1.8/downloads","issues_url":"https://api.github.com/repos/osTicket/osTicket-1.8/issues{/number}","pulls_url":"https://api.github.com/repos/osTicket/osTicket-1.8/pulls{/number}","milestones_url":"https://api.github.com/repos/osTicket/osTicket-1.8/milestones{/number}","notifications_url":"https://api.github.com/repos/osTicket/osTicket-1.8/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/osTicket/osTicket-1.8/labels{/name}","releases_url":"https://api.github.com/repos/osTicket/osTicket-1.8/releases{/id}","created_at":"2013-08-12T19:10:14Z","updated_at":"2014-06-18T17:06:03Z","pushed_at":"2014-06-18T17:06:00Z","git_url":"git://github.com/osTicket/osTicket-1.8.git","ssh_url":"git@github.com:osTicket/osTicket-1.8.git","clone_url":"https://github.com/osTicket/osTicket-1.8.git","svn_url":"https://github.com/osTicket/osTicket-1.8","homepage":null,"size":23391,"stargazers_count":145,"watchers_count":145,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":161,"mirror_url":null,"open_issues_count":348,"forks":161,"open_issues":348,"watchers":145,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/osTicket/osTicket-1.8/pulls/715"},"html":{"href":"https://github.com/osTicket/osTicket-1.8/pull/715"},"issue":{"href":"https://api.github.com/repos/osTicket/osTicket-1.8/issues/715"},"comments":{"href":"https://api.github.com/repos/osTicket/osTicket-1.8/issues/715/comments"},"review_comments":{"href":"https://api.github.com/repos/osTicket/osTicket-1.8/pulls/715/comments"},"review_comment":{"href":"https://api.github.com/repos/osTicket/osTicket-1.8/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/osTicket/osTicket-1.8/pulls/715/commits"},"statuses":{"href":"https://api.github.com/repos/osTicket/osTicket-1.8/statuses/0df9f5a08ad844873c742e66b85d5ebc6831ba6a"}}}}