GitHub PullRequestReviewCommentEvent at 2014-02-12 22:11:44
Repository: puppet-gatling
Actor: briancain
Payload: {"comment":{"url":"https://api.github.com/repos/puppetlabs/puppet-gatling/pulls/comments/9688646","id":9688646,"diff_hunk":"@@ -2,3 +2,49 @@ Puppet Gatling Jenkins Plugin\n ================================\n \n A Jenkins plugin that post-processes gatling simulation data to generate useful reports for Puppet\n+\n+## Setup\n+\n+In this section of the readme, I will detail how to set up the plugin.\n+\n+### Installation\n+\n+First, you will need Maven to set up this plugin. If you are using Homebrew on OSX, it can be as easy as this:\n+\n+    $ brew install maven\n+\n+Next, make sure you are within the project repository so that you can install the required projects with maven.\n+\n+    $ mvn install\n+\n+This will download and install everything you need. (This might also take a while....) At the end, you should get a \"Build Success\" from maven like what you see below:\n+\n+    [INFO] ------------------------------------------------------------------------\n+    [INFO] BUILD SUCCESS\n+    [INFO] ------------------------------------------------------------------------\n+    [INFO] Total time: 8:25.535s\n+    [INFO] Finished at: Mon Jan 06 14:25:02 CST 2014\n+    [INFO] Final Memory: 32M/87M\n+    [INFO] ------------------------------------------------------------------------\n+\n+With the success of the install, you can run a local development copy of Jenkins with maven by running:\n+\n+    $ mvn hpi:run\n+\n+Again, on the first run this may take some time to set up, but once it does it should deploy to your localhost...likely on port 8080. To visit Jenkins, you need to go to `localhost:8080/jenkins`. This is where you can set up the plugin for testing.\n+\n+### Setup on Jenkins\n+\n+### Note On Development\n+\n+If you wish to modify the code for this plugin, I highly suggest using IntelliJ IDEA Community Edition. It's a free IDE that plays really nice with the Jenkins plugin code. There are some gross tricks that you have to do if you want to use an IDE like Eclipse, where as with IntelliJ you do not. Both work, but I found that IntelliJ worked better for this project.\n+\n+### Deployment to a real Jenkins Server\n+\n+If you are ready to deploy to a _real_ jenkins server, and not the development one Maven gives you, you can package the plugin. This is done by running the command:\n+\n+    $ mvn package\n+\n+The resulting packaged plugin should be located in the _target_ directory in the root dir of the project. It should have something like _puppet-gatling-jenkins-plugin.jar_ and _puppet-gatling-jenkins-plugin.hpi_.\n+\n+Now that we have the packaged plugin, we must upload it to the Jenkins server. To do this, click on the link \"Manage Jenkins\" on the left hand side of the Jenkins Dashboard. Then go to \"Manage Plugins\", and click the \"Advanced\" tab. There should be a heading called \"Upload Plugin\". Here is where you will upload the puppet-gatling-jenkins-plugin.hpi file we created. Once you do this, the plugin should be installed on the Jenkins server.","path":"README.md","position":49,"original_position":49,"commit_id":"36a56316f35c7e53136fcd6998dcaee36397a84b","original_commit_id":"2cf48fe7daa8bc9566f46309414f561c0d084123","user":{"login":"briancain","id":810277,"avatar_url":"https://gravatar.com/avatar/dcb438117ec14a9eea701fe495053173?d=https%3A%2F%2Fidenticons.github.com%2Fc104b3e0c644ccfede6bfea1a27b6da6.png&r=x","gravatar_id":"dcb438117ec14a9eea701fe495053173","url":"https://api.github.com/users/briancain","html_url":"https://github.com/briancain","followers_url":"https://api.github.com/users/briancain/followers","following_url":"https://api.github.com/users/briancain/following{/other_user}","gists_url":"https://api.github.com/users/briancain/gists{/gist_id}","starred_url":"https://api.github.com/users/briancain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briancain/subscriptions","organizations_url":"https://api.github.com/users/briancain/orgs","repos_url":"https://api.github.com/users/briancain/repos","events_url":"https://api.github.com/users/briancain/events{/privacy}","received_events_url":"https://api.github.com/users/briancain/received_events","type":"User","site_admin":false},"body":"@cprice404 I think it updated correctly in the pull request after rebasing and force pushing the commit. Looks that way when I go into the detailed view of the file on the pull request.","created_at":"2014-02-12T22:11:44Z","updated_at":"2014-02-12T22:11:44Z","html_url":"https://github.com/puppetlabs/puppet-gatling/pull/8#discussion_r9688646","pull_request_url":"https://api.github.com/repos/puppetlabs/puppet-gatling/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet-gatling/pulls/comments/9688646"},"html":{"href":"https://github.com/puppetlabs/puppet-gatling/pull/8#discussion_r9688646"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppet-gatling/pulls/8"}}}}