GitHub PullRequestReviewCommentEvent at 2014-09-15 11:57:09
Repository: frontend
Actor: ironsidevsquincy
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/guardian/frontend/pulls/comments/17537531","id":17537531,"diff_hunk":"@@ -74,7 +74,7 @@\n                     title=\"@comment.numRecommends recommendations\">\n                     <span class=\"d-comment__recommend-button\">\n                         <span class=\"d-comment__recommend-pulse\"></span>\n-                        <i class=\"i i-recommend\"></i>\n+                        <i></i>","path":"discussion/app/views/fragments/comment.scala.html","position":5,"original_position":5,"commit_id":"ec92958a1a683af5048a3bb35e9465cdf5f00a0e","original_commit_id":"be5ebc319a28bb52e6e346d4b04703444117ced1","user":{"login":"ironsidevsquincy","id":74132,"avatar_url":"https://avatars.githubusercontent.com/u/74132?v=2","gravatar_id":"3995af57bb75c35dbc360f7178d113f0","url":"https://api.github.com/users/ironsidevsquincy","html_url":"https://github.com/ironsidevsquincy","followers_url":"https://api.github.com/users/ironsidevsquincy/followers","following_url":"https://api.github.com/users/ironsidevsquincy/following{/other_user}","gists_url":"https://api.github.com/users/ironsidevsquincy/gists{/gist_id}","starred_url":"https://api.github.com/users/ironsidevsquincy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ironsidevsquincy/subscriptions","organizations_url":"https://api.github.com/users/ironsidevsquincy/orgs","repos_url":"https://api.github.com/users/ironsidevsquincy/repos","events_url":"https://api.github.com/users/ironsidevsquincy/events{/privacy}","received_events_url":"https://api.github.com/users/ironsidevsquincy/received_events","type":"User","site_admin":false},"body":"We've been using `:before` for these, e.g. https://github.com/guardian/frontend/blob/master/common/app/assets/stylesheets/module/facia/_icons.scss \r\n\r\nnote that that means there won't be a png fallback (it needs the `i` class), so make sure it still looks acceptable on a non-svg device, and that you're not adding unnecessary css, e.g. background-position, etc","created_at":"2014-09-15T11:57:09Z","updated_at":"2014-09-15T11:57:09Z","html_url":"https://github.com/guardian/frontend/pull/5934#discussion_r17537531","pull_request_url":"https://api.github.com/repos/guardian/frontend/pulls/5934","_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments/17537531"},"html":{"href":"https://github.com/guardian/frontend/pull/5934#discussion_r17537531"},"pull_request":{"href":"https://api.github.com/repos/guardian/frontend/pulls/5934"}}},"pull_request":{"url":"https://api.github.com/repos/guardian/frontend/pulls/5934","id":21167328,"html_url":"https://github.com/guardian/frontend/pull/5934","diff_url":"https://github.com/guardian/frontend/pull/5934.diff","patch_url":"https://github.com/guardian/frontend/pull/5934.patch","issue_url":"https://api.github.com/repos/guardian/frontend/issues/5934","number":5934,"state":"closed","locked":false,"title":"Gallery lightbox","user":{"login":"mattosborn","id":960919,"avatar_url":"https://avatars.githubusercontent.com/u/960919?v=2","gravatar_id":"4218a68542dac009a8c8407e658fcbde","url":"https://api.github.com/users/mattosborn","html_url":"https://github.com/mattosborn","followers_url":"https://api.github.com/users/mattosborn/followers","following_url":"https://api.github.com/users/mattosborn/following{/other_user}","gists_url":"https://api.github.com/users/mattosborn/gists{/gist_id}","starred_url":"https://api.github.com/users/mattosborn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattosborn/subscriptions","organizations_url":"https://api.github.com/users/mattosborn/orgs","repos_url":"https://api.github.com/users/mattosborn/repos","events_url":"https://api.github.com/users/mattosborn/events{/privacy}","received_events_url":"https://api.github.com/users/mattosborn/received_events","type":"User","site_admin":false},"body":"\r\n![image](https://cloud.githubusercontent.com/assets/960919/4253675/44c1c278-3aa3-11e4-897c-001e790bd98e.png)\r\n\r\n\r\nfinally\r\n![image](http://media.giphy.com/media/UdqUo8xvEcvgA/giphy.gif)","created_at":"2014-09-12T17:36:25Z","updated_at":"2014-09-15T11:57:09Z","closed_at":"2014-09-15T11:33:16Z","merged_at":"2014-09-15T11:33:16Z","merge_commit_sha":"9a1b698872733002f99bac6d49b5d4ec37f75933","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/guardian/frontend/pulls/5934/commits","review_comments_url":"https://api.github.com/repos/guardian/frontend/pulls/5934/comments","review_comment_url":"https://api.github.com/repos/guardian/frontend/pulls/comments/{number}","comments_url":"https://api.github.com/repos/guardian/frontend/issues/5934/comments","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/ec92958a1a683af5048a3bb35e9465cdf5f00a0e","head":{"label":"guardian:gallery-lightbox","ref":"gallery-lightbox","sha":"ec92958a1a683af5048a3bb35e9465cdf5f00a0e","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=2","gravatar_id":"2ddf2e74b78084fcf451b3cdeb075e73","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=2","gravatar_id":"2ddf2e74b78084fcf451b3cdeb075e73","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for the Guardian's responsive site, coming soon to a desktop near you...","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments/{number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","created_at":"2012-05-18T15:39:15Z","updated_at":"2014-09-15T04:09:36Z","pushed_at":"2014-09-15T11:55:22Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"http://www.theguardian.com/uk?view=mobile","size":468271,"stargazers_count":2296,"watchers_count":2296,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":196,"mirror_url":null,"open_issues_count":72,"forks":196,"open_issues":72,"watchers":2296,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"fd4d53e27e041968604d67df383bc63b65fa9314","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=2","gravatar_id":"2ddf2e74b78084fcf451b3cdeb075e73","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=2","gravatar_id":"2ddf2e74b78084fcf451b3cdeb075e73","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for the Guardian's responsive site, coming soon to a desktop near you...","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments/{number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","created_at":"2012-05-18T15:39:15Z","updated_at":"2014-09-15T04:09:36Z","pushed_at":"2014-09-15T11:55:22Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"http://www.theguardian.com/uk?view=mobile","size":468271,"stargazers_count":2296,"watchers_count":2296,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":196,"mirror_url":null,"open_issues_count":72,"forks":196,"open_issues":72,"watchers":2296,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/5934"},"html":{"href":"https://github.com/guardian/frontend/pull/5934"},"issue":{"href":"https://api.github.com/repos/guardian/frontend/issues/5934"},"comments":{"href":"https://api.github.com/repos/guardian/frontend/issues/5934/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/frontend/pulls/5934/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/guardian/frontend/pulls/5934/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/frontend/statuses/ec92958a1a683af5048a3bb35e9465cdf5f00a0e"}}}}