GitHub PullRequestReviewCommentEvent at 2014-07-25 07:13:28
Repository: hibernate-validator
Actor: gunnarmorling
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/hibernate/hibernate-validator/pulls/comments/15388604","id":15388604,"diff_hunk":"@@ -728,6 +748,22 @@ else if ( isIndexable ) {\n \t\t}\n \t}\n \n+\tprivate void validateTypeArgumentConstraints(ValidationContext<?> context, ValueContext<?, Object> valueContext, Object value, Set<TypeArgumentMetaData> typeArgumentMetaDataSet) {\n+\t\tvalueContext.setCurrentValidatedValue( value );\n+\t\tvalueContext.setValidatedValueHandler( null );","path":"engine/src/main/java/org/hibernate/validator/internal/engine/ValidatorImpl.java","position":116,"original_position":116,"commit_id":"ff600d31083847183a70a0e32892c305961b69a9","original_commit_id":"ff600d31083847183a70a0e32892c305961b69a9","user":{"login":"gunnarmorling","id":28612,"avatar_url":"https://avatars.githubusercontent.com/u/28612?","gravatar_id":"8e25c0ca4bf25113bd9c0ccc5d118164","url":"https://api.github.com/users/gunnarmorling","html_url":"https://github.com/gunnarmorling","followers_url":"https://api.github.com/users/gunnarmorling/followers","following_url":"https://api.github.com/users/gunnarmorling/following{/other_user}","gists_url":"https://api.github.com/users/gunnarmorling/gists{/gist_id}","starred_url":"https://api.github.com/users/gunnarmorling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gunnarmorling/subscriptions","organizations_url":"https://api.github.com/users/gunnarmorling/orgs","repos_url":"https://api.github.com/users/gunnarmorling/repos","events_url":"https://api.github.com/users/gunnarmorling/events{/privacy}","received_events_url":"https://api.github.com/users/gunnarmorling/received_events","type":"User","site_admin":false},"body":"Why is the value handler set to null here? Isn't it re-set later on anyways?","created_at":"2014-07-25T07:13:28Z","updated_at":"2014-07-25T07:13:28Z","html_url":"https://github.com/hibernate/hibernate-validator/pull/332#discussion_r15388604","pull_request_url":"https://api.github.com/repos/hibernate/hibernate-validator/pulls/332","_links":{"self":{"href":"https://api.github.com/repos/hibernate/hibernate-validator/pulls/comments/15388604"},"html":{"href":"https://github.com/hibernate/hibernate-validator/pull/332#discussion_r15388604"},"pull_request":{"href":"https://api.github.com/repos/hibernate/hibernate-validator/pulls/332"}}},"pull_request":{"url":"https://api.github.com/repos/hibernate/hibernate-validator/pulls/332","id":18869205,"html_url":"https://github.com/hibernate/hibernate-validator/pull/332","diff_url":"https://github.com/hibernate/hibernate-validator/pull/332.diff","patch_url":"https://github.com/hibernate/hibernate-validator/pull/332.patch","issue_url":"https://api.github.com/repos/hibernate/hibernate-validator/issues/332","number":332,"state":"open","title":"HV-877 Supporting type use constraints on type arguments","user":{"login":"khalidq","id":3060068,"avatar_url":"https://avatars.githubusercontent.com/u/3060068?","gravatar_id":"5f1948099c402ff11e3ab09eb9e380dd","url":"https://api.github.com/users/khalidq","html_url":"https://github.com/khalidq","followers_url":"https://api.github.com/users/khalidq/followers","following_url":"https://api.github.com/users/khalidq/following{/other_user}","gists_url":"https://api.github.com/users/khalidq/gists{/gist_id}","starred_url":"https://api.github.com/users/khalidq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khalidq/subscriptions","organizations_url":"https://api.github.com/users/khalidq/orgs","repos_url":"https://api.github.com/users/khalidq/repos","events_url":"https://api.github.com/users/khalidq/events{/privacy}","received_events_url":"https://api.github.com/users/khalidq/received_events","type":"User","site_admin":false},"body":"This applies to `PropertyMetaData`. After your feedback, I'll continue the work on parameters and return values and I'll extend `ParameterMetaData` and `ReturnValueMetaData`.","created_at":"2014-07-24T22:47:37Z","updated_at":"2014-07-25T07:13:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"56324654adae0be4baf147a0a0c2589fde4d336a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hibernate/hibernate-validator/pulls/332/commits","review_comments_url":"https://api.github.com/repos/hibernate/hibernate-validator/pulls/332/comments","review_comment_url":"https://api.github.com/repos/hibernate/hibernate-validator/pulls/comments/{number}","comments_url":"https://api.github.com/repos/hibernate/hibernate-validator/issues/332/comments","statuses_url":"https://api.github.com/repos/hibernate/hibernate-validator/statuses/ff600d31083847183a70a0e32892c305961b69a9","head":{"label":"khalidq:HV-877","ref":"HV-877","sha":"ff600d31083847183a70a0e32892c305961b69a9","user":{"login":"khalidq","id":3060068,"avatar_url":"https://avatars.githubusercontent.com/u/3060068?","gravatar_id":"5f1948099c402ff11e3ab09eb9e380dd","url":"https://api.github.com/users/khalidq","html_url":"https://github.com/khalidq","followers_url":"https://api.github.com/users/khalidq/followers","following_url":"https://api.github.com/users/khalidq/following{/other_user}","gists_url":"https://api.github.com/users/khalidq/gists{/gist_id}","starred_url":"https://api.github.com/users/khalidq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khalidq/subscriptions","organizations_url":"https://api.github.com/users/khalidq/orgs","repos_url":"https://api.github.com/users/khalidq/repos","events_url":"https://api.github.com/users/khalidq/events{/privacy}","received_events_url":"https://api.github.com/users/khalidq/received_events","type":"User","site_admin":false},"repo":{"id":17596698,"name":"hibernate-validator","full_name":"khalidq/hibernate-validator","owner":{"login":"khalidq","id":3060068,"avatar_url":"https://avatars.githubusercontent.com/u/3060068?","gravatar_id":"5f1948099c402ff11e3ab09eb9e380dd","url":"https://api.github.com/users/khalidq","html_url":"https://github.com/khalidq","followers_url":"https://api.github.com/users/khalidq/followers","following_url":"https://api.github.com/users/khalidq/following{/other_user}","gists_url":"https://api.github.com/users/khalidq/gists{/gist_id}","starred_url":"https://api.github.com/users/khalidq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khalidq/subscriptions","organizations_url":"https://api.github.com/users/khalidq/orgs","repos_url":"https://api.github.com/users/khalidq/repos","events_url":"https://api.github.com/users/khalidq/events{/privacy}","received_events_url":"https://api.github.com/users/khalidq/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/khalidq/hibernate-validator","description":"Hibernate Validator - Bean Validation 1.1 (JSR 349) Reference Implementation","fork":true,"url":"https://api.github.com/repos/khalidq/hibernate-validator","forks_url":"https://api.github.com/repos/khalidq/hibernate-validator/forks","keys_url":"https://api.github.com/repos/khalidq/hibernate-validator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/khalidq/hibernate-validator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/khalidq/hibernate-validator/teams","hooks_url":"https://api.github.com/repos/khalidq/hibernate-validator/hooks","issue_events_url":"https://api.github.com/repos/khalidq/hibernate-validator/issues/events{/number}","events_url":"https://api.github.com/repos/khalidq/hibernate-validator/events","assignees_url":"https://api.github.com/repos/khalidq/hibernate-validator/assignees{/user}","branches_url":"https://api.github.com/repos/khalidq/hibernate-validator/branches{/branch}","tags_url":"https://api.github.com/repos/khalidq/hibernate-validator/tags","blobs_url":"https://api.github.com/repos/khalidq/hibernate-validator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/khalidq/hibernate-validator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/khalidq/hibernate-validator/git/refs{/sha}","trees_url":"https://api.github.com/repos/khalidq/hibernate-validator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/khalidq/hibernate-validator/statuses/{sha}","languages_url":"https://api.github.com/repos/khalidq/hibernate-validator/languages","stargazers_url":"https://api.github.com/repos/khalidq/hibernate-validator/stargazers","contributors_url":"https://api.github.com/repos/khalidq/hibernate-validator/contributors","subscribers_url":"https://api.github.com/repos/khalidq/hibernate-validator/subscribers","subscription_url":"https://api.github.com/repos/khalidq/hibernate-validator/subscription","commits_url":"https://api.github.com/repos/khalidq/hibernate-validator/commits{/sha}","git_commits_url":"https://api.github.com/repos/khalidq/hibernate-validator/git/commits{/sha}","comments_url":"https://api.github.com/repos/khalidq/hibernate-validator/comments{/number}","issue_comment_url":"https://api.github.com/repos/khalidq/hibernate-validator/issues/comments/{number}","contents_url":"https://api.github.com/repos/khalidq/hibernate-validator/contents/{+path}","compare_url":"https://api.github.com/repos/khalidq/hibernate-validator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/khalidq/hibernate-validator/merges","archive_url":"https://api.github.com/repos/khalidq/hibernate-validator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/khalidq/hibernate-validator/downloads","issues_url":"https://api.github.com/repos/khalidq/hibernate-validator/issues{/number}","pulls_url":"https://api.github.com/repos/khalidq/hibernate-validator/pulls{/number}","milestones_url":"https://api.github.com/repos/khalidq/hibernate-validator/milestones{/number}","notifications_url":"https://api.github.com/repos/khalidq/hibernate-validator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/khalidq/hibernate-validator/labels{/name}","releases_url":"https://api.github.com/repos/khalidq/hibernate-validator/releases{/id}","created_at":"2014-03-10T15:01:50Z","updated_at":"2014-06-30T16:36:52Z","pushed_at":"2014-07-24T23:23:48Z","git_url":"git://github.com/khalidq/hibernate-validator.git","ssh_url":"git@github.com:khalidq/hibernate-validator.git","clone_url":"https://github.com/khalidq/hibernate-validator.git","svn_url":"https://github.com/khalidq/hibernate-validator","homepage":"http://validator.hibernate.org/","size":19270,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hibernate:master","ref":"master","sha":"f97c2021a03c825abdeca1692f5be51e77e76a8f","user":{"login":"hibernate","id":348262,"avatar_url":"https://avatars.githubusercontent.com/u/348262?","gravatar_id":"ce9572f319e848be149196b772776981","url":"https://api.github.com/users/hibernate","html_url":"https://github.com/hibernate","followers_url":"https://api.github.com/users/hibernate/followers","following_url":"https://api.github.com/users/hibernate/following{/other_user}","gists_url":"https://api.github.com/users/hibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/hibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hibernate/subscriptions","organizations_url":"https://api.github.com/users/hibernate/orgs","repos_url":"https://api.github.com/users/hibernate/repos","events_url":"https://api.github.com/users/hibernate/events{/privacy}","received_events_url":"https://api.github.com/users/hibernate/received_events","type":"Organization","site_admin":false},"repo":{"id":972205,"name":"hibernate-validator","full_name":"hibernate/hibernate-validator","owner":{"login":"hibernate","id":348262,"avatar_url":"https://avatars.githubusercontent.com/u/348262?","gravatar_id":"ce9572f319e848be149196b772776981","url":"https://api.github.com/users/hibernate","html_url":"https://github.com/hibernate","followers_url":"https://api.github.com/users/hibernate/followers","following_url":"https://api.github.com/users/hibernate/following{/other_user}","gists_url":"https://api.github.com/users/hibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/hibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hibernate/subscriptions","organizations_url":"https://api.github.com/users/hibernate/orgs","repos_url":"https://api.github.com/users/hibernate/repos","events_url":"https://api.github.com/users/hibernate/events{/privacy}","received_events_url":"https://api.github.com/users/hibernate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hibernate/hibernate-validator","description":"Hibernate Validator - Bean Validation 1.1 (JSR 349) Reference Implementation","fork":false,"url":"https://api.github.com/repos/hibernate/hibernate-validator","forks_url":"https://api.github.com/repos/hibernate/hibernate-validator/forks","keys_url":"https://api.github.com/repos/hibernate/hibernate-validator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hibernate/hibernate-validator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hibernate/hibernate-validator/teams","hooks_url":"https://api.github.com/repos/hibernate/hibernate-validator/hooks","issue_events_url":"https://api.github.com/repos/hibernate/hibernate-validator/issues/events{/number}","events_url":"https://api.github.com/repos/hibernate/hibernate-validator/events","assignees_url":"https://api.github.com/repos/hibernate/hibernate-validator/assignees{/user}","branches_url":"https://api.github.com/repos/hibernate/hibernate-validator/branches{/branch}","tags_url":"https://api.github.com/repos/hibernate/hibernate-validator/tags","blobs_url":"https://api.github.com/repos/hibernate/hibernate-validator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hibernate/hibernate-validator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hibernate/hibernate-validator/git/refs{/sha}","trees_url":"https://api.github.com/repos/hibernate/hibernate-validator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hibernate/hibernate-validator/statuses/{sha}","languages_url":"https://api.github.com/repos/hibernate/hibernate-validator/languages","stargazers_url":"https://api.github.com/repos/hibernate/hibernate-validator/stargazers","contributors_url":"https://api.github.com/repos/hibernate/hibernate-validator/contributors","subscribers_url":"https://api.github.com/repos/hibernate/hibernate-validator/subscribers","subscription_url":"https://api.github.com/repos/hibernate/hibernate-validator/subscription","commits_url":"https://api.github.com/repos/hibernate/hibernate-validator/commits{/sha}","git_commits_url":"https://api.github.com/repos/hibernate/hibernate-validator/git/commits{/sha}","comments_url":"https://api.github.com/repos/hibernate/hibernate-validator/comments{/number}","issue_comment_url":"https://api.github.com/repos/hibernate/hibernate-validator/issues/comments/{number}","contents_url":"https://api.github.com/repos/hibernate/hibernate-validator/contents/{+path}","compare_url":"https://api.github.com/repos/hibernate/hibernate-validator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hibernate/hibernate-validator/merges","archive_url":"https://api.github.com/repos/hibernate/hibernate-validator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hibernate/hibernate-validator/downloads","issues_url":"https://api.github.com/repos/hibernate/hibernate-validator/issues{/number}","pulls_url":"https://api.github.com/repos/hibernate/hibernate-validator/pulls{/number}","milestones_url":"https://api.github.com/repos/hibernate/hibernate-validator/milestones{/number}","notifications_url":"https://api.github.com/repos/hibernate/hibernate-validator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hibernate/hibernate-validator/labels{/name}","releases_url":"https://api.github.com/repos/hibernate/hibernate-validator/releases{/id}","created_at":"2010-10-08T13:25:07Z","updated_at":"2014-07-16T23:24:42Z","pushed_at":"2014-07-24T20:21:39Z","git_url":"git://github.com/hibernate/hibernate-validator.git","ssh_url":"git@github.com:hibernate/hibernate-validator.git","clone_url":"https://github.com/hibernate/hibernate-validator.git","svn_url":"https://github.com/hibernate/hibernate-validator","homepage":"http://validator.hibernate.org/","size":26176,"stargazers_count":114,"watchers_count":114,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"forks_count":74,"mirror_url":null,"open_issues_count":1,"forks":74,"open_issues":1,"watchers":114,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hibernate/hibernate-validator/pulls/332"},"html":{"href":"https://github.com/hibernate/hibernate-validator/pull/332"},"issue":{"href":"https://api.github.com/repos/hibernate/hibernate-validator/issues/332"},"comments":{"href":"https://api.github.com/repos/hibernate/hibernate-validator/issues/332/comments"},"review_comments":{"href":"https://api.github.com/repos/hibernate/hibernate-validator/pulls/332/comments"},"review_comment":{"href":"https://api.github.com/repos/hibernate/hibernate-validator/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/hibernate/hibernate-validator/pulls/332/commits"},"statuses":{"href":"https://api.github.com/repos/hibernate/hibernate-validator/statuses/ff600d31083847183a70a0e32892c305961b69a9"}}}}