GitHub PullRequestReviewCommentEvent at 2014-09-17 17:35:06
Repository: puppet
Actor: jpartlow
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/17679866","id":17679866,"diff_hunk":"@@ -2,6 +2,38 @@ module Puppet\n   module Acceptance\n     module ModuleUtils\n \n+      # Return an array of module paths for a given host.\n+      #\n+      # Example return value:\n+      #\n+      # [\n+      #   \"/etc/puppetlabs/puppet/environments/production/modules\",\n+      #   \"/etc/puppetlabs/puppet/modules\",\n+      #   \"/opt/puppet/share/puppet/modules\",\n+      # ]\n+      #\n+      # @param host [String] hostname\n+      # @return [Array] paths for found modulepath\n+      def get_modulepaths_for_host (host)\n+        separator = ':'\n+        if host['platform'] =~ /windows/\n+          separator = ';'\n+        end\n+        on(host, puppet(\"agent --configprint modulepath\")).stdout.chomp.split(separator)","path":"acceptance/lib/puppet/acceptance/module_utils.rb","position":21,"original_position":21,"commit_id":"7a7c3cfb55c311683f5abe345cd12934255a7b80","original_commit_id":"7a7c3cfb55c311683f5abe345cd12934255a7b80","user":{"login":"jpartlow","id":183241,"avatar_url":"https://avatars.githubusercontent.com/u/183241?v=2","gravatar_id":"e9ebfedba32a338542b3adb482cf0e0f","url":"https://api.github.com/users/jpartlow","html_url":"https://github.com/jpartlow","followers_url":"https://api.github.com/users/jpartlow/followers","following_url":"https://api.github.com/users/jpartlow/following{/other_user}","gists_url":"https://api.github.com/users/jpartlow/gists{/gist_id}","starred_url":"https://api.github.com/users/jpartlow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpartlow/subscriptions","organizations_url":"https://api.github.com/users/jpartlow/orgs","repos_url":"https://api.github.com/users/jpartlow/repos","events_url":"https://api.github.com/users/jpartlow/events{/privacy}","received_events_url":"https://api.github.com/users/jpartlow/received_events","type":"User","site_admin":false},"body":"I think this is probably better specified as a 'puppet config print modulepath --environment <someenvironment>'; default could be 'production'.  Otherwise we're just obtaining the modulepath for whatever environment happens to be associated with the agent section of puppet.conf, (which is likely to be the default, 'production', but it's a little vague).","created_at":"2014-09-17T17:35:06Z","updated_at":"2014-09-17T17:35:06Z","html_url":"https://github.com/puppetlabs/puppet/pull/3099#discussion_r17679866","pull_request_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/3099","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/17679866"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/3099#discussion_r17679866"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/3099"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/3099","id":21248133,"html_url":"https://github.com/puppetlabs/puppet/pull/3099","diff_url":"https://github.com/puppetlabs/puppet/pull/3099.diff","patch_url":"https://github.com/puppetlabs/puppet/pull/3099.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppet/issues/3099","number":3099,"state":"open","locked":false,"title":"(PUP-3248) Fix PMT tests for directory environment","user":{"login":"johnduarte","id":1040859,"avatar_url":"https://avatars.githubusercontent.com/u/1040859?v=2","gravatar_id":"d3ecfb48f2538382a947add82aa392f1","url":"https://api.github.com/users/johnduarte","html_url":"https://github.com/johnduarte","followers_url":"https://api.github.com/users/johnduarte/followers","following_url":"https://api.github.com/users/johnduarte/following{/other_user}","gists_url":"https://api.github.com/users/johnduarte/gists{/gist_id}","starred_url":"https://api.github.com/users/johnduarte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnduarte/subscriptions","organizations_url":"https://api.github.com/users/johnduarte/orgs","repos_url":"https://api.github.com/users/johnduarte/repos","events_url":"https://api.github.com/users/johnduarte/events{/privacy}","received_events_url":"https://api.github.com/users/johnduarte/received_events","type":"User","site_admin":false},"body":"The beaker host['distmoduledir'] variable is not meaningful if the\r\nhost is using directory environments (e.g. 'production').\r\n\r\nThis commit updates the helper methods for validating that a module\r\nis (or is not) installed on the host by iterating over the\r\nmodulepath if a specific modulepath is not provided.\r\n\r\nThe calls to these helper methods have been updated for the change\r\nin parameter ordering in the helper methods.","created_at":"2014-09-15T17:46:40Z","updated_at":"2014-09-17T17:35:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3b151c2afb298df20b2266239267ecbaef619452","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/3099/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/3099/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/{number}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/issues/3099/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/7a7c3cfb55c311683f5abe345cd12934255a7b80","head":{"label":"johnduarte:pmt_directory_env_support","ref":"pmt_directory_env_support","sha":"7a7c3cfb55c311683f5abe345cd12934255a7b80","user":{"login":"johnduarte","id":1040859,"avatar_url":"https://avatars.githubusercontent.com/u/1040859?v=2","gravatar_id":"d3ecfb48f2538382a947add82aa392f1","url":"https://api.github.com/users/johnduarte","html_url":"https://github.com/johnduarte","followers_url":"https://api.github.com/users/johnduarte/followers","following_url":"https://api.github.com/users/johnduarte/following{/other_user}","gists_url":"https://api.github.com/users/johnduarte/gists{/gist_id}","starred_url":"https://api.github.com/users/johnduarte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnduarte/subscriptions","organizations_url":"https://api.github.com/users/johnduarte/orgs","repos_url":"https://api.github.com/users/johnduarte/repos","events_url":"https://api.github.com/users/johnduarte/events{/privacy}","received_events_url":"https://api.github.com/users/johnduarte/received_events","type":"User","site_admin":false},"repo":{"id":10199100,"name":"puppet","full_name":"johnduarte/puppet","owner":{"login":"johnduarte","id":1040859,"avatar_url":"https://avatars.githubusercontent.com/u/1040859?v=2","gravatar_id":"d3ecfb48f2538382a947add82aa392f1","url":"https://api.github.com/users/johnduarte","html_url":"https://github.com/johnduarte","followers_url":"https://api.github.com/users/johnduarte/followers","following_url":"https://api.github.com/users/johnduarte/following{/other_user}","gists_url":"https://api.github.com/users/johnduarte/gists{/gist_id}","starred_url":"https://api.github.com/users/johnduarte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnduarte/subscriptions","organizations_url":"https://api.github.com/users/johnduarte/orgs","repos_url":"https://api.github.com/users/johnduarte/repos","events_url":"https://api.github.com/users/johnduarte/events{/privacy}","received_events_url":"https://api.github.com/users/johnduarte/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/johnduarte/puppet","description":"Server automation framework and application","fork":true,"url":"https://api.github.com/repos/johnduarte/puppet","forks_url":"https://api.github.com/repos/johnduarte/puppet/forks","keys_url":"https://api.github.com/repos/johnduarte/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johnduarte/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johnduarte/puppet/teams","hooks_url":"https://api.github.com/repos/johnduarte/puppet/hooks","issue_events_url":"https://api.github.com/repos/johnduarte/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/johnduarte/puppet/events","assignees_url":"https://api.github.com/repos/johnduarte/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/johnduarte/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/johnduarte/puppet/tags","blobs_url":"https://api.github.com/repos/johnduarte/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johnduarte/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johnduarte/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/johnduarte/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johnduarte/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/johnduarte/puppet/languages","stargazers_url":"https://api.github.com/repos/johnduarte/puppet/stargazers","contributors_url":"https://api.github.com/repos/johnduarte/puppet/contributors","subscribers_url":"https://api.github.com/repos/johnduarte/puppet/subscribers","subscription_url":"https://api.github.com/repos/johnduarte/puppet/subscription","commits_url":"https://api.github.com/repos/johnduarte/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/johnduarte/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/johnduarte/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/johnduarte/puppet/issues/comments/{number}","contents_url":"https://api.github.com/repos/johnduarte/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/johnduarte/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johnduarte/puppet/merges","archive_url":"https://api.github.com/repos/johnduarte/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johnduarte/puppet/downloads","issues_url":"https://api.github.com/repos/johnduarte/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/johnduarte/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/johnduarte/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/johnduarte/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johnduarte/puppet/labels{/name}","releases_url":"https://api.github.com/repos/johnduarte/puppet/releases{/id}","created_at":"2013-05-21T15:31:44Z","updated_at":"2014-06-27T20:43:31Z","pushed_at":"2014-09-17T16:01:07Z","git_url":"git://github.com/johnduarte/puppet.git","ssh_url":"git@github.com:johnduarte/puppet.git","clone_url":"https://github.com/johnduarte/puppet.git","svn_url":"https://github.com/johnduarte/puppet","homepage":"http://www.puppetlabs.com/puppet/introduction/","size":42960,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"7a10309541f45570abf667986a02da25419350dd","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=2","gravatar_id":"eb454c2139c156db7c8266a875519a1f","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":910744,"name":"puppet","full_name":"puppetlabs/puppet","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=2","gravatar_id":"eb454c2139c156db7c8266a875519a1f","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppet","description":"Server automation framework and application","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppet","forks_url":"https://api.github.com/repos/puppetlabs/puppet/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppet/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppet/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppet/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppet/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppet/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppet/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppet/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppet/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppet/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppet/issues/comments/{number}","contents_url":"https://api.github.com/repos/puppetlabs/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppet/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppet/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppet/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppet/releases{/id}","created_at":"2010-09-14T19:26:44Z","updated_at":"2014-09-17T03:23:37Z","pushed_at":"2014-09-17T04:40:59Z","git_url":"git://github.com/puppetlabs/puppet.git","ssh_url":"git@github.com:puppetlabs/puppet.git","clone_url":"https://github.com/puppetlabs/puppet.git","svn_url":"https://github.com/puppetlabs/puppet","homepage":"http://www.puppetlabs.com/puppet/introduction/","size":110040,"stargazers_count":2633,"watchers_count":2633,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1125,"mirror_url":null,"open_issues_count":38,"forks":1125,"open_issues":38,"watchers":2633,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/3099"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/3099"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/3099"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/3099/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/3099/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/3099/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppet/statuses/7a7c3cfb55c311683f5abe345cd12934255a7b80"}}}}