GitHub PullRequestReviewCommentEvent at 2014-03-05 18:30:32
Repository: backbone
Actor: wyuenho
Payload: {"comment":{"url":"https://api.github.com/repos/jashkenas/backbone/pulls/comments/10311516","id":10311516,"diff_hunk":"@@ -1062,20 +1062,28 @@\n       return this;\n     },\n \n-    // Remove this view by taking the element out of the DOM, and removing any\n-    // applicable Backbone.Events listeners.\n+    // Remove this view by taking the element out of the document, remove all\n+    // the DOM event listeners attached to it, and remove any applicable\n+    // Backbone.Events listeners.\n     remove: function() {\n-      this.$el.remove();\n+      this.undelegateEvents();\n+      this._removeElement();","path":"backbone.js","position":12,"original_position":12,"commit_id":"27111856c199779da21f7a1cbb486b3d9ddab901","original_commit_id":"27111856c199779da21f7a1cbb486b3d9ddab901","user":{"login":"wyuenho","id":160028,"avatar_url":"https://gravatar.com/avatar/8c68a839282f699145cb8bc314287555?d=https%3A%2F%2Fidenticons.github.com%2F9128f527533fa934adcd07f95cbadb3e.png&r=x","gravatar_id":"8c68a839282f699145cb8bc314287555","url":"https://api.github.com/users/wyuenho","html_url":"https://github.com/wyuenho","followers_url":"https://api.github.com/users/wyuenho/followers","following_url":"https://api.github.com/users/wyuenho/following{/other_user}","gists_url":"https://api.github.com/users/wyuenho/gists{/gist_id}","starred_url":"https://api.github.com/users/wyuenho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wyuenho/subscriptions","organizations_url":"https://api.github.com/users/wyuenho/orgs","repos_url":"https://api.github.com/users/wyuenho/repos","events_url":"https://api.github.com/users/wyuenho/events{/privacy}","received_events_url":"https://api.github.com/users/wyuenho/received_events","type":"User","site_admin":false},"body":"Ok fair enough. There's a new `delegate` method for you though. Global replace `this.$el.on` with `this.delegate` ? Otherwise I'm gonna sleep on this one for a bit. @akre54 you have any ideas?","created_at":"2014-03-05T18:30:32Z","updated_at":"2014-03-05T18:30:32Z","html_url":"https://github.com/jashkenas/backbone/pull/3003#discussion_r10311516","pull_request_url":"https://api.github.com/repos/jashkenas/backbone/pulls/3003","_links":{"self":{"href":"https://api.github.com/repos/jashkenas/backbone/pulls/comments/10311516"},"html":{"href":"https://github.com/jashkenas/backbone/pull/3003#discussion_r10311516"},"pull_request":{"href":"https://api.github.com/repos/jashkenas/backbone/pulls/3003"}}}}