GitHub PullRequestReviewCommentEvent at 2014-09-18 03:59:25
Repository: MonoGame
Actor: tomspilman
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mono/MonoGame/pulls/comments/17708233","id":17708233,"diff_hunk":"@@ -318,12 +318,20 @@ public void Reset()\n             // Manually resetting the device is not currently supported.\r\n             throw new NotImplementedException();\r\n         }\r\n+        */\r\n \r\n+#if WINDOWS && DIRECTX\r","path":"MonoGame.Framework/Graphics/GraphicsDevice.cs","position":6,"original_position":6,"commit_id":"7a0cdaaf43f379294341808f477b2f03eb79e4fb","original_commit_id":"7a0cdaaf43f379294341808f477b2f03eb79e4fb","user":{"login":"tomspilman","id":103522,"avatar_url":"https://avatars.githubusercontent.com/u/103522?v=2","gravatar_id":"8d025ee1bc863257127e15e64d6438b1","url":"https://api.github.com/users/tomspilman","html_url":"https://github.com/tomspilman","followers_url":"https://api.github.com/users/tomspilman/followers","following_url":"https://api.github.com/users/tomspilman/following{/other_user}","gists_url":"https://api.github.com/users/tomspilman/gists{/gist_id}","starred_url":"https://api.github.com/users/tomspilman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomspilman/subscriptions","organizations_url":"https://api.github.com/users/tomspilman/orgs","repos_url":"https://api.github.com/users/tomspilman/repos","events_url":"https://api.github.com/users/tomspilman/events{/privacy}","received_events_url":"https://api.github.com/users/tomspilman/received_events","type":"User","site_admin":false},"body":"Yea...  at one point we commented out all unimplemented functions to make it clear at compile time that something wasn't supported.  This is an obvious rule to follow for things that are not implemented...  for things that are partially implemented it becomes less clear what to do.\r\n\r\nThinking...","created_at":"2014-09-18T03:59:25Z","updated_at":"2014-09-18T03:59:25Z","html_url":"https://github.com/mono/MonoGame/pull/2996#discussion_r17708233","pull_request_url":"https://api.github.com/repos/mono/MonoGame/pulls/2996","_links":{"self":{"href":"https://api.github.com/repos/mono/MonoGame/pulls/comments/17708233"},"html":{"href":"https://github.com/mono/MonoGame/pull/2996#discussion_r17708233"},"pull_request":{"href":"https://api.github.com/repos/mono/MonoGame/pulls/2996"}}},"pull_request":{"url":"https://api.github.com/repos/mono/MonoGame/pulls/2996","id":21409525,"html_url":"https://github.com/mono/MonoGame/pull/2996","diff_url":"https://github.com/mono/MonoGame/pull/2996.diff","patch_url":"https://github.com/mono/MonoGame/pull/2996.patch","issue_url":"https://api.github.com/repos/mono/MonoGame/issues/2996","number":2996,"state":"open","locked":false,"title":"Implemented GraphicsDevice.Reset, Windows/DirectX only.","user":{"login":"jamesford42","id":155688,"avatar_url":"https://avatars.githubusercontent.com/u/155688?v=2","gravatar_id":"13bde3addda2bad230453d387b8430e4","url":"https://api.github.com/users/jamesford42","html_url":"https://github.com/jamesford42","followers_url":"https://api.github.com/users/jamesford42/followers","following_url":"https://api.github.com/users/jamesford42/following{/other_user}","gists_url":"https://api.github.com/users/jamesford42/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesford42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesford42/subscriptions","organizations_url":"https://api.github.com/users/jamesford42/orgs","repos_url":"https://api.github.com/users/jamesford42/repos","events_url":"https://api.github.com/users/jamesford42/events{/privacy}","received_events_url":"https://api.github.com/users/jamesford42/received_events","type":"User","site_admin":false},"body":"Does the same thing as GraphicsDeviceManager.ApplyChanges within its Windows/DirectX block.\r\nThe common situation this is used is for a tool that needs to do xna rendering on a single control and doesn't even have a game/graphicsdevicemanager.","created_at":"2014-09-18T02:57:19Z","updated_at":"2014-09-18T03:59:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f6c3f2abbf51a8ae6b3e4dc5911c515b8bd1f95","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mono/MonoGame/pulls/2996/commits","review_comments_url":"https://api.github.com/repos/mono/MonoGame/pulls/2996/comments","review_comment_url":"https://api.github.com/repos/mono/MonoGame/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mono/MonoGame/issues/2996/comments","statuses_url":"https://api.github.com/repos/mono/MonoGame/statuses/7a0cdaaf43f379294341808f477b2f03eb79e4fb","head":{"label":"SickheadGames:GraphicsDevice.Reset","ref":"GraphicsDevice.Reset","sha":"7a0cdaaf43f379294341808f477b2f03eb79e4fb","user":{"login":"SickheadGames","id":1481255,"avatar_url":"https://avatars.githubusercontent.com/u/1481255?v=2","gravatar_id":"6b6bc29f314df5b338c3c305409eec79","url":"https://api.github.com/users/SickheadGames","html_url":"https://github.com/SickheadGames","followers_url":"https://api.github.com/users/SickheadGames/followers","following_url":"https://api.github.com/users/SickheadGames/following{/other_user}","gists_url":"https://api.github.com/users/SickheadGames/gists{/gist_id}","starred_url":"https://api.github.com/users/SickheadGames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SickheadGames/subscriptions","organizations_url":"https://api.github.com/users/SickheadGames/orgs","repos_url":"https://api.github.com/users/SickheadGames/repos","events_url":"https://api.github.com/users/SickheadGames/events{/privacy}","received_events_url":"https://api.github.com/users/SickheadGames/received_events","type":"Organization","site_admin":false},"repo":{"id":3569373,"name":"MonoGame","full_name":"SickheadGames/MonoGame","owner":{"login":"SickheadGames","id":1481255,"avatar_url":"https://avatars.githubusercontent.com/u/1481255?v=2","gravatar_id":"6b6bc29f314df5b338c3c305409eec79","url":"https://api.github.com/users/SickheadGames","html_url":"https://github.com/SickheadGames","followers_url":"https://api.github.com/users/SickheadGames/followers","following_url":"https://api.github.com/users/SickheadGames/following{/other_user}","gists_url":"https://api.github.com/users/SickheadGames/gists{/gist_id}","starred_url":"https://api.github.com/users/SickheadGames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SickheadGames/subscriptions","organizations_url":"https://api.github.com/users/SickheadGames/orgs","repos_url":"https://api.github.com/users/SickheadGames/repos","events_url":"https://api.github.com/users/SickheadGames/events{/privacy}","received_events_url":"https://api.github.com/users/SickheadGames/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SickheadGames/MonoGame","description":"One framework for creating powerful cross-platform games.","fork":true,"url":"https://api.github.com/repos/SickheadGames/MonoGame","forks_url":"https://api.github.com/repos/SickheadGames/MonoGame/forks","keys_url":"https://api.github.com/repos/SickheadGames/MonoGame/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SickheadGames/MonoGame/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SickheadGames/MonoGame/teams","hooks_url":"https://api.github.com/repos/SickheadGames/MonoGame/hooks","issue_events_url":"https://api.github.com/repos/SickheadGames/MonoGame/issues/events{/number}","events_url":"https://api.github.com/repos/SickheadGames/MonoGame/events","assignees_url":"https://api.github.com/repos/SickheadGames/MonoGame/assignees{/user}","branches_url":"https://api.github.com/repos/SickheadGames/MonoGame/branches{/branch}","tags_url":"https://api.github.com/repos/SickheadGames/MonoGame/tags","blobs_url":"https://api.github.com/repos/SickheadGames/MonoGame/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SickheadGames/MonoGame/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SickheadGames/MonoGame/git/refs{/sha}","trees_url":"https://api.github.com/repos/SickheadGames/MonoGame/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SickheadGames/MonoGame/statuses/{sha}","languages_url":"https://api.github.com/repos/SickheadGames/MonoGame/languages","stargazers_url":"https://api.github.com/repos/SickheadGames/MonoGame/stargazers","contributors_url":"https://api.github.com/repos/SickheadGames/MonoGame/contributors","subscribers_url":"https://api.github.com/repos/SickheadGames/MonoGame/subscribers","subscription_url":"https://api.github.com/repos/SickheadGames/MonoGame/subscription","commits_url":"https://api.github.com/repos/SickheadGames/MonoGame/commits{/sha}","git_commits_url":"https://api.github.com/repos/SickheadGames/MonoGame/git/commits{/sha}","comments_url":"https://api.github.com/repos/SickheadGames/MonoGame/comments{/number}","issue_comment_url":"https://api.github.com/repos/SickheadGames/MonoGame/issues/comments/{number}","contents_url":"https://api.github.com/repos/SickheadGames/MonoGame/contents/{+path}","compare_url":"https://api.github.com/repos/SickheadGames/MonoGame/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SickheadGames/MonoGame/merges","archive_url":"https://api.github.com/repos/SickheadGames/MonoGame/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SickheadGames/MonoGame/downloads","issues_url":"https://api.github.com/repos/SickheadGames/MonoGame/issues{/number}","pulls_url":"https://api.github.com/repos/SickheadGames/MonoGame/pulls{/number}","milestones_url":"https://api.github.com/repos/SickheadGames/MonoGame/milestones{/number}","notifications_url":"https://api.github.com/repos/SickheadGames/MonoGame/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SickheadGames/MonoGame/labels{/name}","releases_url":"https://api.github.com/repos/SickheadGames/MonoGame/releases{/id}","created_at":"2012-02-28T08:32:29Z","updated_at":"2014-07-23T06:19:25Z","pushed_at":"2014-09-18T02:52:45Z","git_url":"git://github.com/SickheadGames/MonoGame.git","ssh_url":"git@github.com:SickheadGames/MonoGame.git","clone_url":"https://github.com/SickheadGames/MonoGame.git","svn_url":"https://github.com/SickheadGames/MonoGame","homepage":"http://www.monogame.net","size":55817,"stargazers_count":14,"watchers_count":14,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":0,"forks":3,"open_issues":0,"watchers":14,"default_branch":"develop"}},"base":{"label":"mono:develop","ref":"develop","sha":"d8f8a017ac09465f3c6b7fc0950f4cf5ad479df5","user":{"login":"mono","id":53395,"avatar_url":"https://avatars.githubusercontent.com/u/53395?v=2","gravatar_id":"f275a99c0b4e6044d3e81daf445f8174","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"repo":{"id":1579990,"name":"MonoGame","full_name":"mono/MonoGame","owner":{"login":"mono","id":53395,"avatar_url":"https://avatars.githubusercontent.com/u/53395?v=2","gravatar_id":"f275a99c0b4e6044d3e81daf445f8174","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mono/MonoGame","description":"One framework for creating powerful cross-platform games.","fork":false,"url":"https://api.github.com/repos/mono/MonoGame","forks_url":"https://api.github.com/repos/mono/MonoGame/forks","keys_url":"https://api.github.com/repos/mono/MonoGame/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mono/MonoGame/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mono/MonoGame/teams","hooks_url":"https://api.github.com/repos/mono/MonoGame/hooks","issue_events_url":"https://api.github.com/repos/mono/MonoGame/issues/events{/number}","events_url":"https://api.github.com/repos/mono/MonoGame/events","assignees_url":"https://api.github.com/repos/mono/MonoGame/assignees{/user}","branches_url":"https://api.github.com/repos/mono/MonoGame/branches{/branch}","tags_url":"https://api.github.com/repos/mono/MonoGame/tags","blobs_url":"https://api.github.com/repos/mono/MonoGame/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mono/MonoGame/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mono/MonoGame/git/refs{/sha}","trees_url":"https://api.github.com/repos/mono/MonoGame/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mono/MonoGame/statuses/{sha}","languages_url":"https://api.github.com/repos/mono/MonoGame/languages","stargazers_url":"https://api.github.com/repos/mono/MonoGame/stargazers","contributors_url":"https://api.github.com/repos/mono/MonoGame/contributors","subscribers_url":"https://api.github.com/repos/mono/MonoGame/subscribers","subscription_url":"https://api.github.com/repos/mono/MonoGame/subscription","commits_url":"https://api.github.com/repos/mono/MonoGame/commits{/sha}","git_commits_url":"https://api.github.com/repos/mono/MonoGame/git/commits{/sha}","comments_url":"https://api.github.com/repos/mono/MonoGame/comments{/number}","issue_comment_url":"https://api.github.com/repos/mono/MonoGame/issues/comments/{number}","contents_url":"https://api.github.com/repos/mono/MonoGame/contents/{+path}","compare_url":"https://api.github.com/repos/mono/MonoGame/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mono/MonoGame/merges","archive_url":"https://api.github.com/repos/mono/MonoGame/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mono/MonoGame/downloads","issues_url":"https://api.github.com/repos/mono/MonoGame/issues{/number}","pulls_url":"https://api.github.com/repos/mono/MonoGame/pulls{/number}","milestones_url":"https://api.github.com/repos/mono/MonoGame/milestones{/number}","notifications_url":"https://api.github.com/repos/mono/MonoGame/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mono/MonoGame/labels{/name}","releases_url":"https://api.github.com/repos/mono/MonoGame/releases{/id}","created_at":"2011-04-07T00:23:40Z","updated_at":"2014-09-17T10:58:31Z","pushed_at":"2014-09-18T03:47:29Z","git_url":"git://github.com/mono/MonoGame.git","ssh_url":"git@github.com:mono/MonoGame.git","clone_url":"https://github.com/mono/MonoGame.git","svn_url":"https://github.com/mono/MonoGame","homepage":"http://www.monogame.net","size":317878,"stargazers_count":2281,"watchers_count":2281,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1305,"mirror_url":null,"open_issues_count":471,"forks":1305,"open_issues":471,"watchers":2281,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/mono/MonoGame/pulls/2996"},"html":{"href":"https://github.com/mono/MonoGame/pull/2996"},"issue":{"href":"https://api.github.com/repos/mono/MonoGame/issues/2996"},"comments":{"href":"https://api.github.com/repos/mono/MonoGame/issues/2996/comments"},"review_comments":{"href":"https://api.github.com/repos/mono/MonoGame/pulls/2996/comments"},"review_comment":{"href":"https://api.github.com/repos/mono/MonoGame/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mono/MonoGame/pulls/2996/commits"},"statuses":{"href":"https://api.github.com/repos/mono/MonoGame/statuses/7a0cdaaf43f379294341808f477b2f03eb79e4fb"}}}}