GitHub PushEvent at 2014-06-16 13:59:27
Repository: django
Actor: duncanparkes
Payload: {"shas":[["fe060d0b97705637e10d813b097393336a69ff85","f69bf5514fde50d7fb64e12e8052d5aebfc37e06@mysociety.org","Improved documentation for QueryDict.\n\nAdded __init__ method to the documentation.\nReworded some parts around mutability of QueryDicts.\n\nAlso improved the docstring of the QueryDict class a bit.","Duncan Parkes",true],["f693bffd857a52e90af246c555ff918e7888cd2f","f69bf5514fde50d7fb64e12e8052d5aebfc37e06@mysociety.org","Made query_string argument to QueryDict optional defaulting to None.\n\nPreviously, a blank QueryDict could be created by calling\n\nQueryDict(str('')) or QueryDict(None)\n\nIt seems rather nicer to just allow the query_string argument to\ndefault to None so that we can just write QueryDict().","Duncan Parkes",true],["8a263f579bb577e0c3d212a127233e47860b5754","f69bf5514fde50d7fb64e12e8052d5aebfc37e06@mysociety.org","Made GET and POST on HttpRequest QueryDicts, and FILES a MultiValueDict.\n\nPreviously, GET, POST and FILES on an HttpRequest were created in\nthe __init__ method as dictionaries. This was not something you would\nusually notice causing trouble in production as you'd only see a\nWSGIRequest, but in testing using the test client, calling .getlist\non GET, POST, or FILES for a request with no get/post data used to\nresult in an AttributeError.\n\nChanged GET and POST on a vanilla HttpRequest object to be mutable\nQueryDicts (mutable because the Django tests, and probably many\nthird party tests, were expecting it). Changed FILES to be a\nMultiValueDict.\n\nAlso added a regression test for this by adding calls to .urlencode on\nGET and POST, and to .getlist on FILES, to the test on a newly created\nHttpRequest.","Duncan Parkes",true]],"size":3,"ref":"refs/heads/GET_and_POST_should_be_querydicts","head":"8a263f579bb577e0c3d212a127233e47860b5754"}