GitHub PullRequestReviewCommentEvent at 2014-05-04 22:37:37
Repository: osem
Actor: houndci
Payload: {"comment":{"url":"https://api.github.com/repos/openSUSE/osem/pulls/comments/12264656","id":12264656,"diff_hunk":"@@ -2,14 +2,13 @@ class Admin::UsersController < ApplicationController\n   before_filter :verify_admin\n \n   def index\n-    @users = User.all(:joins => :person,\n-                      :order => \"people.last_name ASC\",\n-                      :select => \"users.*,\n+    @users = User.select(\"users.*,\n                                   people.last_name AS last_name,\n                                   people.first_name AS first_name,\n                                   people.public_name AS public_name,\n-                                  people.email AS email\")\n-  end\n+                                  people.email AS email\").joins(:person).load.order(\"people.last_name ASC\")\n+","path":"app/controllers/admin/users_controller.rb","position":14,"original_position":14,"commit_id":"0eb82bb11f3090d98734c0294ee9bb45bd95b99b","original_commit_id":"0eb82bb11f3090d98734c0294ee9bb45bd95b99b","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?","gravatar_id":"38d9cefd9971a05bf447f07c6cd332cc","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Extra empty line detected at body end.","created_at":"2014-05-04T22:37:37Z","updated_at":"2014-05-04T22:37:37Z","html_url":"https://github.com/openSUSE/osem/pull/95#discussion_r12264656","pull_request_url":"https://api.github.com/repos/openSUSE/osem/pulls/95","_links":{"self":{"href":"https://api.github.com/repos/openSUSE/osem/pulls/comments/12264656"},"html":{"href":"https://github.com/openSUSE/osem/pull/95#discussion_r12264656"},"pull_request":{"href":"https://api.github.com/repos/openSUSE/osem/pulls/95"}}}}