GitHub PullRequestReviewCommentEvent at 2014-06-12 12:13:25
Repository: frontend
Actor: rich-nguyen
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/guardian/frontend/pulls/comments/13698061","id":13698061,"diff_hunk":"@@ -61,6 +63,18 @@\n }\n \n @* there is currently no SSL version of the beacon *@\n-@if(!Configuration.environment.secure){\n-    <img src=\"@Configuration.debug.beaconUrl/count/pv.gif\" alt=\"\" style=\"display: none;\" rel=\"nofollow\"/>\n+@if(!Configuration.environment.secure) {\n+    <img src=\"@Configuration.debug.beaconUrl/count/pv.gif\" alt=\"\" style=\"display : none ;\" rel=\"nofollow\"/>\n+\n+    @if(FreshnessLoggingSwitch.isSwitchedOn) {\n+        @defining(DateTime.now) { now =>\n+\n+            @if(Edition.isEditionFront(request)) {\n+                <img src=\"@Configuration.debug.beaconUrl/freshness/front/@{now.getMillis}\" alt=\"\" style=\"display : none ;\" rel=\"nofollow\"/>\n+            } else {\n+                <img src=\"@Configuration.debug.beaconUrl/freshness/@{now.getMillis}\" alt=\"\" style=\"display : none ;\" rel=\"nofollow\"/>\n+            }\n+            <!-- @now.toString() -->","path":"common/app/views/fragments/analytics.scala.html","position":25,"original_position":25,"commit_id":"5459a64805f91087ca8d1f7f7f90a28e676ed7a0","original_commit_id":"5459a64805f91087ca8d1f7f7f90a28e676ed7a0","user":{"login":"rich-nguyen","id":4549425,"avatar_url":"https://avatars.githubusercontent.com/u/4549425?","gravatar_id":"6529bec0781ebbcac57c07e4b58258be","url":"https://api.github.com/users/rich-nguyen","html_url":"https://github.com/rich-nguyen","followers_url":"https://api.github.com/users/rich-nguyen/followers","following_url":"https://api.github.com/users/rich-nguyen/following{/other_user}","gists_url":"https://api.github.com/users/rich-nguyen/gists{/gist_id}","starred_url":"https://api.github.com/users/rich-nguyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rich-nguyen/subscriptions","organizations_url":"https://api.github.com/users/rich-nguyen/orgs","repos_url":"https://api.github.com/users/rich-nguyen/repos","events_url":"https://api.github.com/users/rich-nguyen/events{/privacy}","received_events_url":"https://api.github.com/users/rich-nguyen/received_events","type":"User","site_admin":false},"body":"ok, just for troubleshooting","created_at":"2014-06-12T12:13:25Z","updated_at":"2014-06-12T12:13:25Z","html_url":"https://github.com/guardian/frontend/pull/4663#discussion_r13698061","pull_request_url":"https://api.github.com/repos/guardian/frontend/pulls/4663","_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments/13698061"},"html":{"href":"https://github.com/guardian/frontend/pull/4663#discussion_r13698061"},"pull_request":{"href":"https://api.github.com/repos/guardian/frontend/pulls/4663"}}},"pull_request":{"url":"https://api.github.com/repos/guardian/frontend/pulls/4663","id":17049729,"html_url":"https://github.com/guardian/frontend/pull/4663","diff_url":"https://github.com/guardian/frontend/pull/4663.diff","patch_url":"https://github.com/guardian/frontend/pull/4663.patch","issue_url":"https://api.github.com/repos/guardian/frontend/issues/4663","number":4663,"state":"open","title":"Added some metrics to help us determine how 'fresh' our fronts are","user":{"login":"gklopper","id":76709,"avatar_url":"https://avatars.githubusercontent.com/u/76709?","gravatar_id":"312bababa25300e6d8bb79423a6be986","url":"https://api.github.com/users/gklopper","html_url":"https://github.com/gklopper","followers_url":"https://api.github.com/users/gklopper/followers","following_url":"https://api.github.com/users/gklopper/following{/other_user}","gists_url":"https://api.github.com/users/gklopper/gists{/gist_id}","starred_url":"https://api.github.com/users/gklopper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gklopper/subscriptions","organizations_url":"https://api.github.com/users/gklopper/orgs","repos_url":"https://api.github.com/users/gklopper/repos","events_url":"https://api.github.com/users/gklopper/events{/privacy}","received_events_url":"https://api.github.com/users/gklopper/received_events","type":"User","site_admin":false},"body":"For the 3 edition fronts (/uk, /us and /au) we will get the average time in seconds since the page was rendered.\r\n\r\nFor other pages we will get buckets, e.g. less than a minute, less than an hour and so on. \r\n\r\nThe buckets are (slightly) arbitrary, but I want to get an idea of the distribution first, and then we can have a think about it.\r\n\r\nLater on we can possibly set alerts based on this.","created_at":"2014-06-12T11:28:13Z","updated_at":"2014-06-12T12:13:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"41457533b1feebec1a5fb1c63b651c40673d0ae3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/guardian/frontend/pulls/4663/commits","review_comments_url":"https://api.github.com/repos/guardian/frontend/pulls/4663/comments","review_comment_url":"https://api.github.com/repos/guardian/frontend/pulls/comments/{number}","comments_url":"https://api.github.com/repos/guardian/frontend/issues/4663/comments","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/5459a64805f91087ca8d1f7f7f90a28e676ed7a0","head":{"label":"guardian:freshness","ref":"freshness","sha":"5459a64805f91087ca8d1f7f7f90a28e676ed7a0","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?","gravatar_id":"2ddf2e74b78084fcf451b3cdeb075e73","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?","gravatar_id":"2ddf2e74b78084fcf451b3cdeb075e73","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for the Guardian's responsive site, coming soon to a desktop near you...","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments/{number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","created_at":"2012-05-18T15:39:15Z","updated_at":"2014-06-12T12:05:39Z","pushed_at":"2014-06-12T12:05:34Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"http://www.theguardian.com/uk?view=mobile","size":373970,"stargazers_count":2120,"watchers_count":2120,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":177,"mirror_url":null,"open_issues_count":60,"forks":177,"open_issues":60,"watchers":2120,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"ad563ddbbdae18f07746d14a3a114f437d3d3f39","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?","gravatar_id":"2ddf2e74b78084fcf451b3cdeb075e73","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?","gravatar_id":"2ddf2e74b78084fcf451b3cdeb075e73","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for the Guardian's responsive site, coming soon to a desktop near you...","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments/{number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","created_at":"2012-05-18T15:39:15Z","updated_at":"2014-06-12T12:05:39Z","pushed_at":"2014-06-12T12:05:34Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"http://www.theguardian.com/uk?view=mobile","size":373970,"stargazers_count":2120,"watchers_count":2120,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":177,"mirror_url":null,"open_issues_count":60,"forks":177,"open_issues":60,"watchers":2120,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/4663"},"html":{"href":"https://github.com/guardian/frontend/pull/4663"},"issue":{"href":"https://api.github.com/repos/guardian/frontend/issues/4663"},"comments":{"href":"https://api.github.com/repos/guardian/frontend/issues/4663/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/frontend/pulls/4663/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/guardian/frontend/pulls/4663/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/frontend/statuses/5459a64805f91087ca8d1f7f7f90a28e676ed7a0"}}}}