GitHub PullRequestReviewCommentEvent at 2014-10-16 20:58:15
Repository: homebrew
Actor: mikemcquaid
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/18986111","id":18986111,"diff_hunk":"@@ -13,11 +18,18 @@ def install\n       --disable-dependency-tracking\n       --prefix=#{prefix}\n       --mandir=#{man}\n+      --with-ssl=#{Formula[\"openssl\"].opt_prefix}\n     ]\n \n-    args << \"--enable-graphics\" if build.with? 'x11'\n+    args << \"--enable-graphics\" if build.with? \"x11\"\n+    args << \"--without-libtiff\" if build.without? \"libtiff\"\n+    args << \"--without-libjpeg\" if build.without? \"jpeg\"\n \n     system \"./configure\", *args\n-    system \"make install\"\n+    system \"make\", \"install\"\n+  end\n+\n+  test do\n+    system \"#{bin}/links\", \"-version\"","path":"Library/Formula/links.rb","position":39,"original_position":39,"commit_id":"a208a3a8a7dffe6f464fa494521eadbfe1a7e190","original_commit_id":"a208a3a8a7dffe6f464fa494521eadbfe1a7e190","user":{"login":"mikemcquaid","id":125011,"avatar_url":"https://avatars.githubusercontent.com/u/125011?v=2","gravatar_id":"","url":"https://api.github.com/users/mikemcquaid","html_url":"https://github.com/mikemcquaid","followers_url":"https://api.github.com/users/mikemcquaid/followers","following_url":"https://api.github.com/users/mikemcquaid/following{/other_user}","gists_url":"https://api.github.com/users/mikemcquaid/gists{/gist_id}","starred_url":"https://api.github.com/users/mikemcquaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikemcquaid/subscriptions","organizations_url":"https://api.github.com/users/mikemcquaid/orgs","repos_url":"https://api.github.com/users/mikemcquaid/repos","events_url":"https://api.github.com/users/mikemcquaid/events{/privacy}","received_events_url":"https://api.github.com/users/mikemcquaid/received_events","type":"User","site_admin":true},"body":"Nothing better non-interactive we can do here?","created_at":"2014-10-16T20:58:15Z","updated_at":"2014-10-16T20:58:15Z","html_url":"https://github.com/Homebrew/homebrew/pull/33233#discussion_r18986111","pull_request_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/33233","_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/18986111"},"html":{"href":"https://github.com/Homebrew/homebrew/pull/33233#discussion_r18986111"},"pull_request":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/33233"}}},"pull_request":{"url":"https://api.github.com/repos/Homebrew/homebrew/pulls/33233","id":22884945,"html_url":"https://github.com/Homebrew/homebrew/pull/33233","diff_url":"https://github.com/Homebrew/homebrew/pull/33233.diff","patch_url":"https://github.com/Homebrew/homebrew/pull/33233.patch","issue_url":"https://api.github.com/repos/Homebrew/homebrew/issues/33233","number":33233,"state":"open","locked":false,"title":"links: additional dependencies","user":{"login":"DomT4","id":6998367,"avatar_url":"https://avatars.githubusercontent.com/u/6998367?v=2","gravatar_id":"","url":"https://api.github.com/users/DomT4","html_url":"https://github.com/DomT4","followers_url":"https://api.github.com/users/DomT4/followers","following_url":"https://api.github.com/users/DomT4/following{/other_user}","gists_url":"https://api.github.com/users/DomT4/gists{/gist_id}","starred_url":"https://api.github.com/users/DomT4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DomT4/subscriptions","organizations_url":"https://api.github.com/users/DomT4/orgs","repos_url":"https://api.github.com/users/DomT4/repos","events_url":"https://api.github.com/users/DomT4/events{/privacy}","received_events_url":"https://api.github.com/users/DomT4/received_events","type":"User","site_admin":false},"body":"So, yeah, Links has been using the system OpenSSL for secure connections.\r\n\r\nAdditional dependencies based on what the configure script recommends, and a mirror, and a test, and style changes.","created_at":"2014-10-16T20:41:33Z","updated_at":"2014-10-16T20:58:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2e2403fbff736a4ca60086ec81bf611b05193fe9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/33233/commits","review_comments_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/33233/comments","review_comment_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Homebrew/homebrew/issues/33233/comments","statuses_url":"https://api.github.com/repos/Homebrew/homebrew/statuses/a208a3a8a7dffe6f464fa494521eadbfe1a7e190","head":{"label":"DomT4:links","ref":"links","sha":"a208a3a8a7dffe6f464fa494521eadbfe1a7e190","user":{"login":"DomT4","id":6998367,"avatar_url":"https://avatars.githubusercontent.com/u/6998367?v=2","gravatar_id":"","url":"https://api.github.com/users/DomT4","html_url":"https://github.com/DomT4","followers_url":"https://api.github.com/users/DomT4/followers","following_url":"https://api.github.com/users/DomT4/following{/other_user}","gists_url":"https://api.github.com/users/DomT4/gists{/gist_id}","starred_url":"https://api.github.com/users/DomT4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DomT4/subscriptions","organizations_url":"https://api.github.com/users/DomT4/orgs","repos_url":"https://api.github.com/users/DomT4/repos","events_url":"https://api.github.com/users/DomT4/events{/privacy}","received_events_url":"https://api.github.com/users/DomT4/received_events","type":"User","site_admin":false},"repo":{"id":23289808,"name":"homebrew","full_name":"DomT4/homebrew","owner":{"login":"DomT4","id":6998367,"avatar_url":"https://avatars.githubusercontent.com/u/6998367?v=2","gravatar_id":"","url":"https://api.github.com/users/DomT4","html_url":"https://github.com/DomT4","followers_url":"https://api.github.com/users/DomT4/followers","following_url":"https://api.github.com/users/DomT4/following{/other_user}","gists_url":"https://api.github.com/users/DomT4/gists{/gist_id}","starred_url":"https://api.github.com/users/DomT4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DomT4/subscriptions","organizations_url":"https://api.github.com/users/DomT4/orgs","repos_url":"https://api.github.com/users/DomT4/repos","events_url":"https://api.github.com/users/DomT4/events{/privacy}","received_events_url":"https://api.github.com/users/DomT4/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DomT4/homebrew","description":"The missing package manager for OS X.","fork":true,"url":"https://api.github.com/repos/DomT4/homebrew","forks_url":"https://api.github.com/repos/DomT4/homebrew/forks","keys_url":"https://api.github.com/repos/DomT4/homebrew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DomT4/homebrew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DomT4/homebrew/teams","hooks_url":"https://api.github.com/repos/DomT4/homebrew/hooks","issue_events_url":"https://api.github.com/repos/DomT4/homebrew/issues/events{/number}","events_url":"https://api.github.com/repos/DomT4/homebrew/events","assignees_url":"https://api.github.com/repos/DomT4/homebrew/assignees{/user}","branches_url":"https://api.github.com/repos/DomT4/homebrew/branches{/branch}","tags_url":"https://api.github.com/repos/DomT4/homebrew/tags","blobs_url":"https://api.github.com/repos/DomT4/homebrew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DomT4/homebrew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DomT4/homebrew/git/refs{/sha}","trees_url":"https://api.github.com/repos/DomT4/homebrew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DomT4/homebrew/statuses/{sha}","languages_url":"https://api.github.com/repos/DomT4/homebrew/languages","stargazers_url":"https://api.github.com/repos/DomT4/homebrew/stargazers","contributors_url":"https://api.github.com/repos/DomT4/homebrew/contributors","subscribers_url":"https://api.github.com/repos/DomT4/homebrew/subscribers","subscription_url":"https://api.github.com/repos/DomT4/homebrew/subscription","commits_url":"https://api.github.com/repos/DomT4/homebrew/commits{/sha}","git_commits_url":"https://api.github.com/repos/DomT4/homebrew/git/commits{/sha}","comments_url":"https://api.github.com/repos/DomT4/homebrew/comments{/number}","issue_comment_url":"https://api.github.com/repos/DomT4/homebrew/issues/comments/{number}","contents_url":"https://api.github.com/repos/DomT4/homebrew/contents/{+path}","compare_url":"https://api.github.com/repos/DomT4/homebrew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DomT4/homebrew/merges","archive_url":"https://api.github.com/repos/DomT4/homebrew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DomT4/homebrew/downloads","issues_url":"https://api.github.com/repos/DomT4/homebrew/issues{/number}","pulls_url":"https://api.github.com/repos/DomT4/homebrew/pulls{/number}","milestones_url":"https://api.github.com/repos/DomT4/homebrew/milestones{/number}","notifications_url":"https://api.github.com/repos/DomT4/homebrew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DomT4/homebrew/labels{/name}","releases_url":"https://api.github.com/repos/DomT4/homebrew/releases{/id}","created_at":"2014-08-24T19:01:40Z","updated_at":"2014-08-28T22:39:49Z","pushed_at":"2014-10-16T20:47:19Z","git_url":"git://github.com/DomT4/homebrew.git","ssh_url":"git@github.com:DomT4/homebrew.git","clone_url":"https://github.com/DomT4/homebrew.git","svn_url":"https://github.com/DomT4/homebrew","homepage":"http://brew.sh","size":45664,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Homebrew:master","ref":"master","sha":"0ecedd7c0c671d6dee2dafeb7421aaf6c7b58d63","user":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=2","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"repo":{"id":206084,"name":"homebrew","full_name":"Homebrew/homebrew","owner":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=2","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Homebrew/homebrew","description":"The missing package manager for OS X.","fork":false,"url":"https://api.github.com/repos/Homebrew/homebrew","forks_url":"https://api.github.com/repos/Homebrew/homebrew/forks","keys_url":"https://api.github.com/repos/Homebrew/homebrew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Homebrew/homebrew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Homebrew/homebrew/teams","hooks_url":"https://api.github.com/repos/Homebrew/homebrew/hooks","issue_events_url":"https://api.github.com/repos/Homebrew/homebrew/issues/events{/number}","events_url":"https://api.github.com/repos/Homebrew/homebrew/events","assignees_url":"https://api.github.com/repos/Homebrew/homebrew/assignees{/user}","branches_url":"https://api.github.com/repos/Homebrew/homebrew/branches{/branch}","tags_url":"https://api.github.com/repos/Homebrew/homebrew/tags","blobs_url":"https://api.github.com/repos/Homebrew/homebrew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Homebrew/homebrew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Homebrew/homebrew/git/refs{/sha}","trees_url":"https://api.github.com/repos/Homebrew/homebrew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Homebrew/homebrew/statuses/{sha}","languages_url":"https://api.github.com/repos/Homebrew/homebrew/languages","stargazers_url":"https://api.github.com/repos/Homebrew/homebrew/stargazers","contributors_url":"https://api.github.com/repos/Homebrew/homebrew/contributors","subscribers_url":"https://api.github.com/repos/Homebrew/homebrew/subscribers","subscription_url":"https://api.github.com/repos/Homebrew/homebrew/subscription","commits_url":"https://api.github.com/repos/Homebrew/homebrew/commits{/sha}","git_commits_url":"https://api.github.com/repos/Homebrew/homebrew/git/commits{/sha}","comments_url":"https://api.github.com/repos/Homebrew/homebrew/comments{/number}","issue_comment_url":"https://api.github.com/repos/Homebrew/homebrew/issues/comments/{number}","contents_url":"https://api.github.com/repos/Homebrew/homebrew/contents/{+path}","compare_url":"https://api.github.com/repos/Homebrew/homebrew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Homebrew/homebrew/merges","archive_url":"https://api.github.com/repos/Homebrew/homebrew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Homebrew/homebrew/downloads","issues_url":"https://api.github.com/repos/Homebrew/homebrew/issues{/number}","pulls_url":"https://api.github.com/repos/Homebrew/homebrew/pulls{/number}","milestones_url":"https://api.github.com/repos/Homebrew/homebrew/milestones{/number}","notifications_url":"https://api.github.com/repos/Homebrew/homebrew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Homebrew/homebrew/labels{/name}","releases_url":"https://api.github.com/repos/Homebrew/homebrew/releases{/id}","created_at":"2009-05-20T19:38:37Z","updated_at":"2014-10-16T20:28:11Z","pushed_at":"2014-10-16T20:57:31Z","git_url":"git://github.com/Homebrew/homebrew.git","ssh_url":"git@github.com:Homebrew/homebrew.git","clone_url":"https://github.com/Homebrew/homebrew.git","svn_url":"https://github.com/Homebrew/homebrew","homepage":"http://brew.sh","size":1223476,"stargazers_count":19516,"watchers_count":19516,"language":"Ruby","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":9695,"mirror_url":null,"open_issues_count":198,"forks":9695,"open_issues":198,"watchers":19516,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/33233"},"html":{"href":"https://github.com/Homebrew/homebrew/pull/33233"},"issue":{"href":"https://api.github.com/repos/Homebrew/homebrew/issues/33233"},"comments":{"href":"https://api.github.com/repos/Homebrew/homebrew/issues/33233/comments"},"review_comments":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/33233/comments"},"review_comment":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/33233/commits"},"statuses":{"href":"https://api.github.com/repos/Homebrew/homebrew/statuses/a208a3a8a7dffe6f464fa494521eadbfe1a7e190"}}}}