GitHub PullRequestEvent at 2014-02-19 13:49:04
Repository: express-couchUser
Actor: twilson63
Payload: {"action":"closed","number":2,"pull_request":{"url":"https://api.github.com/repos/twilson63/express-couchUser/pulls/2","id":12698031,"html_url":"https://github.com/twilson63/express-couchUser/pull/2","diff_url":"https://github.com/twilson63/express-couchUser/pull/2.diff","patch_url":"https://github.com/twilson63/express-couchUser/pull/2.patch","issue_url":"https://api.github.com/repos/twilson63/express-couchUser/issues/2","number":2,"state":"closed","title":"Adding error handling for user lookup during forgot password request","user":{"login":"warrensplayer","id":1702361,"avatar_url":"https://gravatar.com/avatar/6f7fba206b59f73af84c58e893d3fe88?d=https%3A%2F%2Fidenticons.github.com%2Fd2e61313f3f4b4c20a01dfc6bf0f611b.png&r=x","gravatar_id":"6f7fba206b59f73af84c58e893d3fe88","url":"https://api.github.com/users/warrensplayer","html_url":"https://github.com/warrensplayer","followers_url":"https://api.github.com/users/warrensplayer/followers","following_url":"https://api.github.com/users/warrensplayer/following{/other_user}","gists_url":"https://api.github.com/users/warrensplayer/gists{/gist_id}","starred_url":"https://api.github.com/users/warrensplayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/warrensplayer/subscriptions","organizations_url":"https://api.github.com/users/warrensplayer/orgs","repos_url":"https://api.github.com/users/warrensplayer/repos","events_url":"https://api.github.com/users/warrensplayer/events{/privacy}","received_events_url":"https://api.github.com/users/warrensplayer/received_events","type":"User","site_admin":false},"body":"**Main Issue**\r\nError was happening when a user tried to perform the forgot password functionality and entered an email that did not exist in the database.\r\n\r\n**Solution**\r\nAdded check around the result from the user lookup to return an error message if no user was found.\r\n\r\n_Additional_\r\nAdded an api call to look up a user based on the users reset code set during the forgot password request.  This query leverages the \"code\" view in the CouchDB design document that was already present.","created_at":"2014-02-19T13:47:56Z","updated_at":"2014-02-19T13:49:04Z","closed_at":"2014-02-19T13:49:04Z","merged_at":"2014-02-19T13:49:04Z","merge_commit_sha":"19672bda59e2baf42fc511aa8965fca0e8387de1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/twilson63/express-couchUser/pulls/2/commits","review_comments_url":"https://api.github.com/repos/twilson63/express-couchUser/pulls/2/comments","review_comment_url":"https://api.github.com/repos/twilson63/express-couchUser/pulls/comments/{number}","comments_url":"https://api.github.com/repos/twilson63/express-couchUser/issues/2/comments","statuses_url":"https://api.github.com/repos/twilson63/express-couchUser/statuses/bd242515f0c71d1b9bab81464866a03b3a815141","head":{"label":"warrensplayer:update_forgot_password","ref":"update_forgot_password","sha":"bd242515f0c71d1b9bab81464866a03b3a815141","user":{"login":"warrensplayer","id":1702361,"avatar_url":"https://gravatar.com/avatar/6f7fba206b59f73af84c58e893d3fe88?d=https%3A%2F%2Fidenticons.github.com%2Fd2e61313f3f4b4c20a01dfc6bf0f611b.png&r=x","gravatar_id":"6f7fba206b59f73af84c58e893d3fe88","url":"https://api.github.com/users/warrensplayer","html_url":"https://github.com/warrensplayer","followers_url":"https://api.github.com/users/warrensplayer/followers","following_url":"https://api.github.com/users/warrensplayer/following{/other_user}","gists_url":"https://api.github.com/users/warrensplayer/gists{/gist_id}","starred_url":"https://api.github.com/users/warrensplayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/warrensplayer/subscriptions","organizations_url":"https://api.github.com/users/warrensplayer/orgs","repos_url":"https://api.github.com/users/warrensplayer/repos","events_url":"https://api.github.com/users/warrensplayer/events{/privacy}","received_events_url":"https://api.github.com/users/warrensplayer/received_events","type":"User","site_admin":false},"repo":{"id":14991382,"name":"express-couchUser","full_name":"warrensplayer/express-couchUser","owner":{"login":"warrensplayer","id":1702361,"avatar_url":"https://gravatar.com/avatar/6f7fba206b59f73af84c58e893d3fe88?d=https%3A%2F%2Fidenticons.github.com%2Fd2e61313f3f4b4c20a01dfc6bf0f611b.png&r=x","gravatar_id":"6f7fba206b59f73af84c58e893d3fe88","url":"https://api.github.com/users/warrensplayer","html_url":"https://github.com/warrensplayer","followers_url":"https://api.github.com/users/warrensplayer/followers","following_url":"https://api.github.com/users/warrensplayer/following{/other_user}","gists_url":"https://api.github.com/users/warrensplayer/gists{/gist_id}","starred_url":"https://api.github.com/users/warrensplayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/warrensplayer/subscriptions","organizations_url":"https://api.github.com/users/warrensplayer/orgs","repos_url":"https://api.github.com/users/warrensplayer/repos","events_url":"https://api.github.com/users/warrensplayer/events{/privacy}","received_events_url":"https://api.github.com/users/warrensplayer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/warrensplayer/express-couchUser","description":"A express module for CouchDb based User Authentication Module","fork":true,"url":"https://api.github.com/repos/warrensplayer/express-couchUser","forks_url":"https://api.github.com/repos/warrensplayer/express-couchUser/forks","keys_url":"https://api.github.com/repos/warrensplayer/express-couchUser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/warrensplayer/express-couchUser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/warrensplayer/express-couchUser/teams","hooks_url":"https://api.github.com/repos/warrensplayer/express-couchUser/hooks","issue_events_url":"https://api.github.com/repos/warrensplayer/express-couchUser/issues/events{/number}","events_url":"https://api.github.com/repos/warrensplayer/express-couchUser/events","assignees_url":"https://api.github.com/repos/warrensplayer/express-couchUser/assignees{/user}","branches_url":"https://api.github.com/repos/warrensplayer/express-couchUser/branches{/branch}","tags_url":"https://api.github.com/repos/warrensplayer/express-couchUser/tags","blobs_url":"https://api.github.com/repos/warrensplayer/express-couchUser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/warrensplayer/express-couchUser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/warrensplayer/express-couchUser/git/refs{/sha}","trees_url":"https://api.github.com/repos/warrensplayer/express-couchUser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/warrensplayer/express-couchUser/statuses/{sha}","languages_url":"https://api.github.com/repos/warrensplayer/express-couchUser/languages","stargazers_url":"https://api.github.com/repos/warrensplayer/express-couchUser/stargazers","contributors_url":"https://api.github.com/repos/warrensplayer/express-couchUser/contributors","subscribers_url":"https://api.github.com/repos/warrensplayer/express-couchUser/subscribers","subscription_url":"https://api.github.com/repos/warrensplayer/express-couchUser/subscription","commits_url":"https://api.github.com/repos/warrensplayer/express-couchUser/commits{/sha}","git_commits_url":"https://api.github.com/repos/warrensplayer/express-couchUser/git/commits{/sha}","comments_url":"https://api.github.com/repos/warrensplayer/express-couchUser/comments{/number}","issue_comment_url":"https://api.github.com/repos/warrensplayer/express-couchUser/issues/comments/{number}","contents_url":"https://api.github.com/repos/warrensplayer/express-couchUser/contents/{+path}","compare_url":"https://api.github.com/repos/warrensplayer/express-couchUser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/warrensplayer/express-couchUser/merges","archive_url":"https://api.github.com/repos/warrensplayer/express-couchUser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/warrensplayer/express-couchUser/downloads","issues_url":"https://api.github.com/repos/warrensplayer/express-couchUser/issues{/number}","pulls_url":"https://api.github.com/repos/warrensplayer/express-couchUser/pulls{/number}","milestones_url":"https://api.github.com/repos/warrensplayer/express-couchUser/milestones{/number}","notifications_url":"https://api.github.com/repos/warrensplayer/express-couchUser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/warrensplayer/express-couchUser/labels{/name}","releases_url":"https://api.github.com/repos/warrensplayer/express-couchUser/releases{/id}","created_at":"2013-12-06T19:27:42Z","updated_at":"2014-02-19T13:49:04Z","pushed_at":"2014-02-19T03:15:35Z","git_url":"git://github.com/warrensplayer/express-couchUser.git","ssh_url":"git@github.com:warrensplayer/express-couchUser.git","clone_url":"https://github.com/warrensplayer/express-couchUser.git","svn_url":"https://github.com/warrensplayer/express-couchUser","homepage":null,"size":120,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"twilson63:master","ref":"master","sha":"9b69c528ce645c9b1606205a2b60eb4ece36c2f6","user":{"login":"twilson63","id":21292,"avatar_url":"https://gravatar.com/avatar/ebd63577f6cef101bf22245572781d5d?d=https%3A%2F%2Fidenticons.github.com%2F085774e529f8c6611741cdb352f364bc.png&r=x","gravatar_id":"ebd63577f6cef101bf22245572781d5d","url":"https://api.github.com/users/twilson63","html_url":"https://github.com/twilson63","followers_url":"https://api.github.com/users/twilson63/followers","following_url":"https://api.github.com/users/twilson63/following{/other_user}","gists_url":"https://api.github.com/users/twilson63/gists{/gist_id}","starred_url":"https://api.github.com/users/twilson63/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twilson63/subscriptions","organizations_url":"https://api.github.com/users/twilson63/orgs","repos_url":"https://api.github.com/users/twilson63/repos","events_url":"https://api.github.com/users/twilson63/events{/privacy}","received_events_url":"https://api.github.com/users/twilson63/received_events","type":"User","site_admin":false},"repo":{"id":10656307,"name":"express-couchUser","full_name":"twilson63/express-couchUser","owner":{"login":"twilson63","id":21292,"avatar_url":"https://gravatar.com/avatar/ebd63577f6cef101bf22245572781d5d?d=https%3A%2F%2Fidenticons.github.com%2F085774e529f8c6611741cdb352f364bc.png&r=x","gravatar_id":"ebd63577f6cef101bf22245572781d5d","url":"https://api.github.com/users/twilson63","html_url":"https://github.com/twilson63","followers_url":"https://api.github.com/users/twilson63/followers","following_url":"https://api.github.com/users/twilson63/following{/other_user}","gists_url":"https://api.github.com/users/twilson63/gists{/gist_id}","starred_url":"https://api.github.com/users/twilson63/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twilson63/subscriptions","organizations_url":"https://api.github.com/users/twilson63/orgs","repos_url":"https://api.github.com/users/twilson63/repos","events_url":"https://api.github.com/users/twilson63/events{/privacy}","received_events_url":"https://api.github.com/users/twilson63/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/twilson63/express-couchUser","description":"A express module for CouchDb based User Authentication Module","fork":false,"url":"https://api.github.com/repos/twilson63/express-couchUser","forks_url":"https://api.github.com/repos/twilson63/express-couchUser/forks","keys_url":"https://api.github.com/repos/twilson63/express-couchUser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twilson63/express-couchUser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twilson63/express-couchUser/teams","hooks_url":"https://api.github.com/repos/twilson63/express-couchUser/hooks","issue_events_url":"https://api.github.com/repos/twilson63/express-couchUser/issues/events{/number}","events_url":"https://api.github.com/repos/twilson63/express-couchUser/events","assignees_url":"https://api.github.com/repos/twilson63/express-couchUser/assignees{/user}","branches_url":"https://api.github.com/repos/twilson63/express-couchUser/branches{/branch}","tags_url":"https://api.github.com/repos/twilson63/express-couchUser/tags","blobs_url":"https://api.github.com/repos/twilson63/express-couchUser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twilson63/express-couchUser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twilson63/express-couchUser/git/refs{/sha}","trees_url":"https://api.github.com/repos/twilson63/express-couchUser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twilson63/express-couchUser/statuses/{sha}","languages_url":"https://api.github.com/repos/twilson63/express-couchUser/languages","stargazers_url":"https://api.github.com/repos/twilson63/express-couchUser/stargazers","contributors_url":"https://api.github.com/repos/twilson63/express-couchUser/contributors","subscribers_url":"https://api.github.com/repos/twilson63/express-couchUser/subscribers","subscription_url":"https://api.github.com/repos/twilson63/express-couchUser/subscription","commits_url":"https://api.github.com/repos/twilson63/express-couchUser/commits{/sha}","git_commits_url":"https://api.github.com/repos/twilson63/express-couchUser/git/commits{/sha}","comments_url":"https://api.github.com/repos/twilson63/express-couchUser/comments{/number}","issue_comment_url":"https://api.github.com/repos/twilson63/express-couchUser/issues/comments/{number}","contents_url":"https://api.github.com/repos/twilson63/express-couchUser/contents/{+path}","compare_url":"https://api.github.com/repos/twilson63/express-couchUser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twilson63/express-couchUser/merges","archive_url":"https://api.github.com/repos/twilson63/express-couchUser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twilson63/express-couchUser/downloads","issues_url":"https://api.github.com/repos/twilson63/express-couchUser/issues{/number}","pulls_url":"https://api.github.com/repos/twilson63/express-couchUser/pulls{/number}","milestones_url":"https://api.github.com/repos/twilson63/express-couchUser/milestones{/number}","notifications_url":"https://api.github.com/repos/twilson63/express-couchUser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twilson63/express-couchUser/labels{/name}","releases_url":"https://api.github.com/repos/twilson63/express-couchUser/releases{/id}","created_at":"2013-06-13T01:31:06Z","updated_at":"2014-02-19T13:49:04Z","pushed_at":"2014-02-19T13:49:04Z","git_url":"git://github.com/twilson63/express-couchUser.git","ssh_url":"git@github.com:twilson63/express-couchUser.git","clone_url":"https://github.com/twilson63/express-couchUser.git","svn_url":"https://github.com/twilson63/express-couchUser","homepage":null,"size":360,"stargazers_count":11,"watchers_count":11,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":11,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/twilson63/express-couchUser/pulls/2"},"html":{"href":"https://github.com/twilson63/express-couchUser/pull/2"},"issue":{"href":"https://api.github.com/repos/twilson63/express-couchUser/issues/2"},"comments":{"href":"https://api.github.com/repos/twilson63/express-couchUser/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/twilson63/express-couchUser/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/twilson63/express-couchUser/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/twilson63/express-couchUser/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/twilson63/express-couchUser/statuses/bd242515f0c71d1b9bab81464866a03b3a815141"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"twilson63","id":21292,"avatar_url":"https://gravatar.com/avatar/ebd63577f6cef101bf22245572781d5d?d=https%3A%2F%2Fidenticons.github.com%2F085774e529f8c6611741cdb352f364bc.png&r=x","gravatar_id":"ebd63577f6cef101bf22245572781d5d","url":"https://api.github.com/users/twilson63","html_url":"https://github.com/twilson63","followers_url":"https://api.github.com/users/twilson63/followers","following_url":"https://api.github.com/users/twilson63/following{/other_user}","gists_url":"https://api.github.com/users/twilson63/gists{/gist_id}","starred_url":"https://api.github.com/users/twilson63/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twilson63/subscriptions","organizations_url":"https://api.github.com/users/twilson63/orgs","repos_url":"https://api.github.com/users/twilson63/repos","events_url":"https://api.github.com/users/twilson63/events{/privacy}","received_events_url":"https://api.github.com/users/twilson63/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":31,"deletions":4,"changed_files":1}}