GitHub PullRequestReviewCommentEvent at 2014-10-28 15:23:29
Repository: wildfly-core
Actor: bstansberry
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments/19477983","id":19477983,"diff_hunk":"@@ -50,7 +50,7 @@ public ManagementChannelHandler startReceiving(Channel channel) {\n         }\n \n         handler.addHandlerFactory(new ModelControllerClientOperationHandler(getController(), handler, subject));\n-\n+        channel.addCloseHandler(handler);","path":"controller/src/main/java/org/jboss/as/controller/remote/ModelControllerClientOperationHandlerFactoryService.java","position":5,"original_position":5,"commit_id":"d921cf6e9f66dd2cd7fab24fd4ca3c1ea35929b5","original_commit_id":"d921cf6e9f66dd2cd7fab24fd4ca3c1ea35929b5","user":{"login":"bstansberry","id":299242,"avatar_url":"https://avatars.githubusercontent.com/u/299242?v=2","gravatar_id":"","url":"https://api.github.com/users/bstansberry","html_url":"https://github.com/bstansberry","followers_url":"https://api.github.com/users/bstansberry/followers","following_url":"https://api.github.com/users/bstansberry/following{/other_user}","gists_url":"https://api.github.com/users/bstansberry/gists{/gist_id}","starred_url":"https://api.github.com/users/bstansberry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bstansberry/subscriptions","organizations_url":"https://api.github.com/users/bstansberry/orgs","repos_url":"https://api.github.com/users/bstansberry/repos","events_url":"https://api.github.com/users/bstansberry/events{/privacy}","received_events_url":"https://api.github.com/users/bstansberry/received_events","type":"User","site_admin":false},"body":"I'll look into the duplication between this and ManagementChannelShutdownHandle. Maybe this just isn't needed, and simply getting that \"disconnected\" out of the sync block would have fixed the hang. \r\n\r\nI'll look if the ManagementChannelShutdownHandle stuff is called regardless of service shutdown; i.e. if it is called from a close handler. The hang was caused due to the remote side closing the channel, and we need properly cancellation when that happens.\r\n\r\nRelated to this is https://issues.jboss.org/browse/WFCORE-199. I think we may need to treat requests where the local process is the client differently from ones where it is the server. Cut off new requests from the remote end without cutting off the ability to send requests. In that case we may want two different shutdown mechanisms.","created_at":"2014-10-28T15:23:29Z","updated_at":"2014-10-28T15:23:29Z","html_url":"https://github.com/wildfly/wildfly-core/pull/265#discussion_r19477983","pull_request_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/265","_links":{"self":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments/19477983"},"html":{"href":"https://github.com/wildfly/wildfly-core/pull/265#discussion_r19477983"},"pull_request":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/265"}}},"pull_request":{"url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/265","id":23261990,"html_url":"https://github.com/wildfly/wildfly-core/pull/265","diff_url":"https://github.com/wildfly/wildfly-core/pull/265.diff","patch_url":"https://github.com/wildfly/wildfly-core/pull/265.patch","issue_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/265","number":265,"state":"open","locked":false,"title":"[WFCORE-196] Don't call ManagedServerProxy.disconnected with the Managed...","user":{"login":"bstansberry","id":299242,"avatar_url":"https://avatars.githubusercontent.com/u/299242?v=2","gravatar_id":"","url":"https://api.github.com/users/bstansberry","html_url":"https://github.com/bstansberry","followers_url":"https://api.github.com/users/bstansberry/followers","following_url":"https://api.github.com/users/bstansberry/following{/other_user}","gists_url":"https://api.github.com/users/bstansberry/gists{/gist_id}","starred_url":"https://api.github.com/users/bstansberry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bstansberry/subscriptions","organizations_url":"https://api.github.com/users/bstansberry/orgs","repos_url":"https://api.github.com/users/bstansberry/repos","events_url":"https://api.github.com/users/bstansberry/events{/privacy}","received_events_url":"https://api.github.com/users/bstansberry/received_events","type":"User","site_admin":false},"body":"...Server lock held","created_at":"2014-10-23T21:42:42Z","updated_at":"2014-10-28T15:23:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d9afe9fc7ec52e5b624b5b271dd6e2388bf9999a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/265/commits","review_comments_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/265/comments","review_comment_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments/{number}","comments_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/265/comments","statuses_url":"https://api.github.com/repos/wildfly/wildfly-core/statuses/d921cf6e9f66dd2cd7fab24fd4ca3c1ea35929b5","head":{"label":"bstansberry:WFCORE-196","ref":"WFCORE-196","sha":"d921cf6e9f66dd2cd7fab24fd4ca3c1ea35929b5","user":{"login":"bstansberry","id":299242,"avatar_url":"https://avatars.githubusercontent.com/u/299242?v=2","gravatar_id":"","url":"https://api.github.com/users/bstansberry","html_url":"https://github.com/bstansberry","followers_url":"https://api.github.com/users/bstansberry/followers","following_url":"https://api.github.com/users/bstansberry/following{/other_user}","gists_url":"https://api.github.com/users/bstansberry/gists{/gist_id}","starred_url":"https://api.github.com/users/bstansberry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bstansberry/subscriptions","organizations_url":"https://api.github.com/users/bstansberry/orgs","repos_url":"https://api.github.com/users/bstansberry/repos","events_url":"https://api.github.com/users/bstansberry/events{/privacy}","received_events_url":"https://api.github.com/users/bstansberry/received_events","type":"User","site_admin":false},"repo":{"id":21433119,"name":"wildfly-core","full_name":"bstansberry/wildfly-core","owner":{"login":"bstansberry","id":299242,"avatar_url":"https://avatars.githubusercontent.com/u/299242?v=2","gravatar_id":"","url":"https://api.github.com/users/bstansberry","html_url":"https://github.com/bstansberry","followers_url":"https://api.github.com/users/bstansberry/followers","following_url":"https://api.github.com/users/bstansberry/following{/other_user}","gists_url":"https://api.github.com/users/bstansberry/gists{/gist_id}","starred_url":"https://api.github.com/users/bstansberry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bstansberry/subscriptions","organizations_url":"https://api.github.com/users/bstansberry/orgs","repos_url":"https://api.github.com/users/bstansberry/repos","events_url":"https://api.github.com/users/bstansberry/events{/privacy}","received_events_url":"https://api.github.com/users/bstansberry/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bstansberry/wildfly-core","description":"The core runtime that is used by the Wildfly application server","fork":true,"url":"https://api.github.com/repos/bstansberry/wildfly-core","forks_url":"https://api.github.com/repos/bstansberry/wildfly-core/forks","keys_url":"https://api.github.com/repos/bstansberry/wildfly-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bstansberry/wildfly-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bstansberry/wildfly-core/teams","hooks_url":"https://api.github.com/repos/bstansberry/wildfly-core/hooks","issue_events_url":"https://api.github.com/repos/bstansberry/wildfly-core/issues/events{/number}","events_url":"https://api.github.com/repos/bstansberry/wildfly-core/events","assignees_url":"https://api.github.com/repos/bstansberry/wildfly-core/assignees{/user}","branches_url":"https://api.github.com/repos/bstansberry/wildfly-core/branches{/branch}","tags_url":"https://api.github.com/repos/bstansberry/wildfly-core/tags","blobs_url":"https://api.github.com/repos/bstansberry/wildfly-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bstansberry/wildfly-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bstansberry/wildfly-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/bstansberry/wildfly-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bstansberry/wildfly-core/statuses/{sha}","languages_url":"https://api.github.com/repos/bstansberry/wildfly-core/languages","stargazers_url":"https://api.github.com/repos/bstansberry/wildfly-core/stargazers","contributors_url":"https://api.github.com/repos/bstansberry/wildfly-core/contributors","subscribers_url":"https://api.github.com/repos/bstansberry/wildfly-core/subscribers","subscription_url":"https://api.github.com/repos/bstansberry/wildfly-core/subscription","commits_url":"https://api.github.com/repos/bstansberry/wildfly-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/bstansberry/wildfly-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/bstansberry/wildfly-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/bstansberry/wildfly-core/issues/comments/{number}","contents_url":"https://api.github.com/repos/bstansberry/wildfly-core/contents/{+path}","compare_url":"https://api.github.com/repos/bstansberry/wildfly-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bstansberry/wildfly-core/merges","archive_url":"https://api.github.com/repos/bstansberry/wildfly-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bstansberry/wildfly-core/downloads","issues_url":"https://api.github.com/repos/bstansberry/wildfly-core/issues{/number}","pulls_url":"https://api.github.com/repos/bstansberry/wildfly-core/pulls{/number}","milestones_url":"https://api.github.com/repos/bstansberry/wildfly-core/milestones{/number}","notifications_url":"https://api.github.com/repos/bstansberry/wildfly-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bstansberry/wildfly-core/labels{/name}","releases_url":"https://api.github.com/repos/bstansberry/wildfly-core/releases{/id}","created_at":"2014-07-02T17:20:55Z","updated_at":"2014-07-08T16:21:31Z","pushed_at":"2014-10-28T15:09:34Z","git_url":"git://github.com/bstansberry/wildfly-core.git","ssh_url":"git@github.com:bstansberry/wildfly-core.git","clone_url":"https://github.com/bstansberry/wildfly-core.git","svn_url":"https://github.com/bstansberry/wildfly-core","homepage":null,"size":35981,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wildfly:master","ref":"master","sha":"783673931f86d056323c2478427ab8cb111a5e3f","user":{"login":"wildfly","id":3066274,"avatar_url":"https://avatars.githubusercontent.com/u/3066274?v=2","gravatar_id":"","url":"https://api.github.com/users/wildfly","html_url":"https://github.com/wildfly","followers_url":"https://api.github.com/users/wildfly/followers","following_url":"https://api.github.com/users/wildfly/following{/other_user}","gists_url":"https://api.github.com/users/wildfly/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly/subscriptions","organizations_url":"https://api.github.com/users/wildfly/orgs","repos_url":"https://api.github.com/users/wildfly/repos","events_url":"https://api.github.com/users/wildfly/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly/received_events","type":"Organization","site_admin":false},"repo":{"id":21394954,"name":"wildfly-core","full_name":"wildfly/wildfly-core","owner":{"login":"wildfly","id":3066274,"avatar_url":"https://avatars.githubusercontent.com/u/3066274?v=2","gravatar_id":"","url":"https://api.github.com/users/wildfly","html_url":"https://github.com/wildfly","followers_url":"https://api.github.com/users/wildfly/followers","following_url":"https://api.github.com/users/wildfly/following{/other_user}","gists_url":"https://api.github.com/users/wildfly/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly/subscriptions","organizations_url":"https://api.github.com/users/wildfly/orgs","repos_url":"https://api.github.com/users/wildfly/repos","events_url":"https://api.github.com/users/wildfly/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wildfly/wildfly-core","description":"The core runtime that is used by the Wildfly application server","fork":false,"url":"https://api.github.com/repos/wildfly/wildfly-core","forks_url":"https://api.github.com/repos/wildfly/wildfly-core/forks","keys_url":"https://api.github.com/repos/wildfly/wildfly-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wildfly/wildfly-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wildfly/wildfly-core/teams","hooks_url":"https://api.github.com/repos/wildfly/wildfly-core/hooks","issue_events_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/events{/number}","events_url":"https://api.github.com/repos/wildfly/wildfly-core/events","assignees_url":"https://api.github.com/repos/wildfly/wildfly-core/assignees{/user}","branches_url":"https://api.github.com/repos/wildfly/wildfly-core/branches{/branch}","tags_url":"https://api.github.com/repos/wildfly/wildfly-core/tags","blobs_url":"https://api.github.com/repos/wildfly/wildfly-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wildfly/wildfly-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wildfly/wildfly-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/wildfly/wildfly-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wildfly/wildfly-core/statuses/{sha}","languages_url":"https://api.github.com/repos/wildfly/wildfly-core/languages","stargazers_url":"https://api.github.com/repos/wildfly/wildfly-core/stargazers","contributors_url":"https://api.github.com/repos/wildfly/wildfly-core/contributors","subscribers_url":"https://api.github.com/repos/wildfly/wildfly-core/subscribers","subscription_url":"https://api.github.com/repos/wildfly/wildfly-core/subscription","commits_url":"https://api.github.com/repos/wildfly/wildfly-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/wildfly/wildfly-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/wildfly/wildfly-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/comments/{number}","contents_url":"https://api.github.com/repos/wildfly/wildfly-core/contents/{+path}","compare_url":"https://api.github.com/repos/wildfly/wildfly-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wildfly/wildfly-core/merges","archive_url":"https://api.github.com/repos/wildfly/wildfly-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wildfly/wildfly-core/downloads","issues_url":"https://api.github.com/repos/wildfly/wildfly-core/issues{/number}","pulls_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls{/number}","milestones_url":"https://api.github.com/repos/wildfly/wildfly-core/milestones{/number}","notifications_url":"https://api.github.com/repos/wildfly/wildfly-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wildfly/wildfly-core/labels{/name}","releases_url":"https://api.github.com/repos/wildfly/wildfly-core/releases{/id}","created_at":"2014-07-01T16:33:34Z","updated_at":"2014-10-23T21:05:45Z","pushed_at":"2014-10-28T09:32:07Z","git_url":"git://github.com/wildfly/wildfly-core.git","ssh_url":"git@github.com:wildfly/wildfly-core.git","clone_url":"https://github.com/wildfly/wildfly-core.git","svn_url":"https://github.com/wildfly/wildfly-core","homepage":null,"size":39526,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":74,"mirror_url":null,"open_issues_count":22,"forks":74,"open_issues":22,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/265"},"html":{"href":"https://github.com/wildfly/wildfly-core/pull/265"},"issue":{"href":"https://api.github.com/repos/wildfly/wildfly-core/issues/265"},"comments":{"href":"https://api.github.com/repos/wildfly/wildfly-core/issues/265/comments"},"review_comments":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/265/comments"},"review_comment":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/265/commits"},"statuses":{"href":"https://api.github.com/repos/wildfly/wildfly-core/statuses/d921cf6e9f66dd2cd7fab24fd4ca3c1ea35929b5"}}}}