GitHub PullRequestReviewCommentEvent at 2014-07-11 22:45:29
Repository: ppsspp
Actor: unknownbrackets
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/hrydgard/ppsspp/pulls/comments/14847794","id":14847794,"diff_hunk":"@@ -177,64 +226,70 @@ typedef struct SceNetAdhocctlGameModeInfo {\n   s32_le num;\n   SceNetEtherAddr member[ADHOCCTL_GAMEMODE_MAX_MEMBERS];\n } PACK SceNetAdhocctlGameModeInfo;\n-#ifdef _MSC_VER \n-#pragma pack(pop)\n-#endif\n-\n-// Adhoc ID (Game Product Key)\n-#define ADHOCCTL_ADHOCID_LEN 9\n-typedef struct SceNetAdhocctlAdhocId {\n-  s32_le type;\n-  uint8_t data[ADHOCCTL_ADHOCID_LEN];\n-  uint8_t padding[3];\n-} SceNetAdhocctlAdhocId;\n \n // Socket Polling Event Listener\n-struct SceNetAdhocPollSd {\n+typedef struct SceNetAdhocPollSd{\n   s32_le id;\n   s32_le events;\n   s32_le revents;\n-};\n+} PACK SceNetAdhocPollSd;\n \n // PDP Socket Status\n-struct SceNetAdhocPdpStat {\n-  struct SceNetAdhocPdpStat * next;\n+typedef struct SceNetAdhocPdpStat{\n+  u32_le next; // struct SceNetAdhocPdpStat * next;\n   s32_le id;\n   SceNetEtherAddr laddr;\n   u16_le lport;\n   u32_le rcv_sb_cc;\n-};\n+} PACK SceNetAdhocPdpStat;\n \n // PTP Socket Status\n-struct SceNetAdhocPtpStat {\n+typedef struct SceNetAdhocPtpStat {\n   u32_le next; // Changed the pointer to u32\n   s32_le id;\n   SceNetEtherAddr laddr;\n   SceNetEtherAddr paddr;\n   u16_le lport;\n   u16_le pport;\n-  u32_le snd_sb_cc;\n-  u32_le rcv_sb_cc;\n+  s32_le snd_sb_cc;\n+  s32_le rcv_sb_cc;\n   s32_le state;\n-};\n+} PACK SceNetAdhocPtpStat;\n \n // Gamemode Optional Peer Buffer Data\n-struct SceNetAdhocGameModeOptData {\n+typedef struct SceNetAdhocGameModeOptData {\n   u32_le size;\n   u32_le flag;\n   u64_le last_recv;\n-};\n+} PACK SceNetAdhocGameModeOptData;\n \n // Gamemode Buffer Status\n-struct SceNetAdhocGameModeBufferStat {\n-  struct SceNetAdhocGameModeBufferStat * next;\n+typedef struct SceNetAdhocGameModeBufferStat {\n+  struct SceNetAdhocGameModeBufferStat * next; //should be u32_le ?\n   s32_le id;\n   void * ptr;\n   u32_le size;\n   u32_le master;\n   SceNetAdhocGameModeOptData opt;\n-};\n+} PACK SceNetAdhocGameModeBufferStat;\n+#ifdef _MSC_VER \n+#pragma pack(pop)\n+#endif\n \n+// Adhoc ID (Game Product Key)\n+#define ADHOCCTL_ADHOCID_LEN 9\n+typedef struct SceNetAdhocctlAdhocId {\n+\ts32_le type;\n+\tuint8_t data[ADHOCCTL_ADHOCID_LEN];\n+\tuint8_t padding[3];\n+} SceNetAdhocctlAdhocId; // should this be packed?\n+\n+// Polling Event Field\n+typedef struct SceNetInetPollfd {\n+\tint fd;\n+\tshort events;\n+\tshort revents;","path":"Core/HLE/proAdhoc.h","position":185,"original_position":185,"commit_id":"c2d371911fe5f60994d9d2f591527e3c7b204c7e","original_commit_id":"c2d371911fe5f60994d9d2f591527e3c7b204c7e","user":{"login":"unknownbrackets","id":191233,"avatar_url":"https://avatars.githubusercontent.com/u/191233?","gravatar_id":"f10adb38bc3813ae73942676eb05046e","url":"https://api.github.com/users/unknownbrackets","html_url":"https://github.com/unknownbrackets","followers_url":"https://api.github.com/users/unknownbrackets/followers","following_url":"https://api.github.com/users/unknownbrackets/following{/other_user}","gists_url":"https://api.github.com/users/unknownbrackets/gists{/gist_id}","starred_url":"https://api.github.com/users/unknownbrackets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unknownbrackets/subscriptions","organizations_url":"https://api.github.com/users/unknownbrackets/orgs","repos_url":"https://api.github.com/users/unknownbrackets/repos","events_url":"https://api.github.com/users/unknownbrackets/events{/privacy}","received_events_url":"https://api.github.com/users/unknownbrackets/received_events","type":"User","site_admin":false},"body":"All structs for PSP memory need to specify endianness.  `int`, `short`, etc. should not be used - instead, `s32_le` and `s16_le`.\r\n\r\nThe Xbox 360 port is not active currently (which may be the only big endian platform PPSSPP has been run on), but since there's already structs in this file using _le it's best to stay consistent.\r\n\r\n-[Unknown]","created_at":"2014-07-11T22:45:29Z","updated_at":"2014-07-11T22:45:29Z","html_url":"https://github.com/hrydgard/ppsspp/pull/6539#discussion_r14847794","pull_request_url":"https://api.github.com/repos/hrydgard/ppsspp/pulls/6539","_links":{"self":{"href":"https://api.github.com/repos/hrydgard/ppsspp/pulls/comments/14847794"},"html":{"href":"https://github.com/hrydgard/ppsspp/pull/6539#discussion_r14847794"},"pull_request":{"href":"https://api.github.com/repos/hrydgard/ppsspp/pulls/6539"}}},"pull_request":{"url":"https://api.github.com/repos/hrydgard/ppsspp/pulls/6539","id":18271805,"html_url":"https://github.com/hrydgard/ppsspp/pull/6539","diff_url":"https://github.com/hrydgard/ppsspp/pull/6539.diff","patch_url":"https://github.com/hrydgard/ppsspp/pull/6539.patch","issue_url":"https://api.github.com/repos/hrydgard/ppsspp/issues/6539","number":6539,"state":"open","title":"More Adhoc functions implemented","user":{"login":"ANR2ME","id":7974720,"avatar_url":"https://avatars.githubusercontent.com/u/7974720?","gravatar_id":"347320a101039f361da2146dff9c70f8","url":"https://api.github.com/users/ANR2ME","html_url":"https://github.com/ANR2ME","followers_url":"https://api.github.com/users/ANR2ME/followers","following_url":"https://api.github.com/users/ANR2ME/following{/other_user}","gists_url":"https://api.github.com/users/ANR2ME/gists{/gist_id}","starred_url":"https://api.github.com/users/ANR2ME/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ANR2ME/subscriptions","organizations_url":"https://api.github.com/users/ANR2ME/orgs","repos_url":"https://api.github.com/users/ANR2ME/repos","events_url":"https://api.github.com/users/ANR2ME/events{/privacy}","received_events_url":"https://api.github.com/users/ANR2ME/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-07-11T10:45:54Z","updated_at":"2014-07-11T22:45:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ffb4fd9db8e3669da4dd55f4ef66cf3e4ccd3990","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hrydgard/ppsspp/pulls/6539/commits","review_comments_url":"https://api.github.com/repos/hrydgard/ppsspp/pulls/6539/comments","review_comment_url":"https://api.github.com/repos/hrydgard/ppsspp/pulls/comments/{number}","comments_url":"https://api.github.com/repos/hrydgard/ppsspp/issues/6539/comments","statuses_url":"https://api.github.com/repos/hrydgard/ppsspp/statuses/c2d371911fe5f60994d9d2f591527e3c7b204c7e","head":{"label":"ANR2ME:adhoc_","ref":"adhoc_","sha":"c2d371911fe5f60994d9d2f591527e3c7b204c7e","user":{"login":"ANR2ME","id":7974720,"avatar_url":"https://avatars.githubusercontent.com/u/7974720?","gravatar_id":"347320a101039f361da2146dff9c70f8","url":"https://api.github.com/users/ANR2ME","html_url":"https://github.com/ANR2ME","followers_url":"https://api.github.com/users/ANR2ME/followers","following_url":"https://api.github.com/users/ANR2ME/following{/other_user}","gists_url":"https://api.github.com/users/ANR2ME/gists{/gist_id}","starred_url":"https://api.github.com/users/ANR2ME/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ANR2ME/subscriptions","organizations_url":"https://api.github.com/users/ANR2ME/orgs","repos_url":"https://api.github.com/users/ANR2ME/repos","events_url":"https://api.github.com/users/ANR2ME/events{/privacy}","received_events_url":"https://api.github.com/users/ANR2ME/received_events","type":"User","site_admin":false},"repo":{"id":21162475,"name":"ppsspp","full_name":"ANR2ME/ppsspp","owner":{"login":"ANR2ME","id":7974720,"avatar_url":"https://avatars.githubusercontent.com/u/7974720?","gravatar_id":"347320a101039f361da2146dff9c70f8","url":"https://api.github.com/users/ANR2ME","html_url":"https://github.com/ANR2ME","followers_url":"https://api.github.com/users/ANR2ME/followers","following_url":"https://api.github.com/users/ANR2ME/following{/other_user}","gists_url":"https://api.github.com/users/ANR2ME/gists{/gist_id}","starred_url":"https://api.github.com/users/ANR2ME/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ANR2ME/subscriptions","organizations_url":"https://api.github.com/users/ANR2ME/orgs","repos_url":"https://api.github.com/users/ANR2ME/repos","events_url":"https://api.github.com/users/ANR2ME/events{/privacy}","received_events_url":"https://api.github.com/users/ANR2ME/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ANR2ME/ppsspp","description":"A PSP emulator for Android, Windows, Mac, Linux and Blackberry 10, written in C++. Want to contribute? Join us in #ppsspp on freenode (IRC) or just send pull requests / issues.","fork":true,"url":"https://api.github.com/repos/ANR2ME/ppsspp","forks_url":"https://api.github.com/repos/ANR2ME/ppsspp/forks","keys_url":"https://api.github.com/repos/ANR2ME/ppsspp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ANR2ME/ppsspp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ANR2ME/ppsspp/teams","hooks_url":"https://api.github.com/repos/ANR2ME/ppsspp/hooks","issue_events_url":"https://api.github.com/repos/ANR2ME/ppsspp/issues/events{/number}","events_url":"https://api.github.com/repos/ANR2ME/ppsspp/events","assignees_url":"https://api.github.com/repos/ANR2ME/ppsspp/assignees{/user}","branches_url":"https://api.github.com/repos/ANR2ME/ppsspp/branches{/branch}","tags_url":"https://api.github.com/repos/ANR2ME/ppsspp/tags","blobs_url":"https://api.github.com/repos/ANR2ME/ppsspp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ANR2ME/ppsspp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ANR2ME/ppsspp/git/refs{/sha}","trees_url":"https://api.github.com/repos/ANR2ME/ppsspp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ANR2ME/ppsspp/statuses/{sha}","languages_url":"https://api.github.com/repos/ANR2ME/ppsspp/languages","stargazers_url":"https://api.github.com/repos/ANR2ME/ppsspp/stargazers","contributors_url":"https://api.github.com/repos/ANR2ME/ppsspp/contributors","subscribers_url":"https://api.github.com/repos/ANR2ME/ppsspp/subscribers","subscription_url":"https://api.github.com/repos/ANR2ME/ppsspp/subscription","commits_url":"https://api.github.com/repos/ANR2ME/ppsspp/commits{/sha}","git_commits_url":"https://api.github.com/repos/ANR2ME/ppsspp/git/commits{/sha}","comments_url":"https://api.github.com/repos/ANR2ME/ppsspp/comments{/number}","issue_comment_url":"https://api.github.com/repos/ANR2ME/ppsspp/issues/comments/{number}","contents_url":"https://api.github.com/repos/ANR2ME/ppsspp/contents/{+path}","compare_url":"https://api.github.com/repos/ANR2ME/ppsspp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ANR2ME/ppsspp/merges","archive_url":"https://api.github.com/repos/ANR2ME/ppsspp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ANR2ME/ppsspp/downloads","issues_url":"https://api.github.com/repos/ANR2ME/ppsspp/issues{/number}","pulls_url":"https://api.github.com/repos/ANR2ME/ppsspp/pulls{/number}","milestones_url":"https://api.github.com/repos/ANR2ME/ppsspp/milestones{/number}","notifications_url":"https://api.github.com/repos/ANR2ME/ppsspp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ANR2ME/ppsspp/labels{/name}","releases_url":"https://api.github.com/repos/ANR2ME/ppsspp/releases{/id}","created_at":"2014-06-24T11:38:02Z","updated_at":"2014-07-11T08:48:07Z","pushed_at":"2014-07-11T10:43:52Z","git_url":"git://github.com/ANR2ME/ppsspp.git","ssh_url":"git@github.com:ANR2ME/ppsspp.git","clone_url":"https://github.com/ANR2ME/ppsspp.git","svn_url":"https://github.com/ANR2ME/ppsspp","homepage":"http://www.ppsspp.org","size":62988,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hrydgard:master","ref":"master","sha":"88cfcf7e26f9a3cad58c7bd34fc1f9c1e94ef4bc","user":{"login":"hrydgard","id":130929,"avatar_url":"https://avatars.githubusercontent.com/u/130929?","gravatar_id":"2d47f033439c83a9aa9a9212e8b93096","url":"https://api.github.com/users/hrydgard","html_url":"https://github.com/hrydgard","followers_url":"https://api.github.com/users/hrydgard/followers","following_url":"https://api.github.com/users/hrydgard/following{/other_user}","gists_url":"https://api.github.com/users/hrydgard/gists{/gist_id}","starred_url":"https://api.github.com/users/hrydgard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hrydgard/subscriptions","organizations_url":"https://api.github.com/users/hrydgard/orgs","repos_url":"https://api.github.com/users/hrydgard/repos","events_url":"https://api.github.com/users/hrydgard/events{/privacy}","received_events_url":"https://api.github.com/users/hrydgard/received_events","type":"User","site_admin":false},"repo":{"id":6486826,"name":"ppsspp","full_name":"hrydgard/ppsspp","owner":{"login":"hrydgard","id":130929,"avatar_url":"https://avatars.githubusercontent.com/u/130929?","gravatar_id":"2d47f033439c83a9aa9a9212e8b93096","url":"https://api.github.com/users/hrydgard","html_url":"https://github.com/hrydgard","followers_url":"https://api.github.com/users/hrydgard/followers","following_url":"https://api.github.com/users/hrydgard/following{/other_user}","gists_url":"https://api.github.com/users/hrydgard/gists{/gist_id}","starred_url":"https://api.github.com/users/hrydgard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hrydgard/subscriptions","organizations_url":"https://api.github.com/users/hrydgard/orgs","repos_url":"https://api.github.com/users/hrydgard/repos","events_url":"https://api.github.com/users/hrydgard/events{/privacy}","received_events_url":"https://api.github.com/users/hrydgard/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hrydgard/ppsspp","description":"A PSP emulator for Android, Windows, Mac, Linux and Blackberry 10, written in C++. Want to contribute? Join us in #ppsspp on freenode (IRC) or just send pull requests / issues.","fork":false,"url":"https://api.github.com/repos/hrydgard/ppsspp","forks_url":"https://api.github.com/repos/hrydgard/ppsspp/forks","keys_url":"https://api.github.com/repos/hrydgard/ppsspp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hrydgard/ppsspp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hrydgard/ppsspp/teams","hooks_url":"https://api.github.com/repos/hrydgard/ppsspp/hooks","issue_events_url":"https://api.github.com/repos/hrydgard/ppsspp/issues/events{/number}","events_url":"https://api.github.com/repos/hrydgard/ppsspp/events","assignees_url":"https://api.github.com/repos/hrydgard/ppsspp/assignees{/user}","branches_url":"https://api.github.com/repos/hrydgard/ppsspp/branches{/branch}","tags_url":"https://api.github.com/repos/hrydgard/ppsspp/tags","blobs_url":"https://api.github.com/repos/hrydgard/ppsspp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hrydgard/ppsspp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hrydgard/ppsspp/git/refs{/sha}","trees_url":"https://api.github.com/repos/hrydgard/ppsspp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hrydgard/ppsspp/statuses/{sha}","languages_url":"https://api.github.com/repos/hrydgard/ppsspp/languages","stargazers_url":"https://api.github.com/repos/hrydgard/ppsspp/stargazers","contributors_url":"https://api.github.com/repos/hrydgard/ppsspp/contributors","subscribers_url":"https://api.github.com/repos/hrydgard/ppsspp/subscribers","subscription_url":"https://api.github.com/repos/hrydgard/ppsspp/subscription","commits_url":"https://api.github.com/repos/hrydgard/ppsspp/commits{/sha}","git_commits_url":"https://api.github.com/repos/hrydgard/ppsspp/git/commits{/sha}","comments_url":"https://api.github.com/repos/hrydgard/ppsspp/comments{/number}","issue_comment_url":"https://api.github.com/repos/hrydgard/ppsspp/issues/comments/{number}","contents_url":"https://api.github.com/repos/hrydgard/ppsspp/contents/{+path}","compare_url":"https://api.github.com/repos/hrydgard/ppsspp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hrydgard/ppsspp/merges","archive_url":"https://api.github.com/repos/hrydgard/ppsspp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hrydgard/ppsspp/downloads","issues_url":"https://api.github.com/repos/hrydgard/ppsspp/issues{/number}","pulls_url":"https://api.github.com/repos/hrydgard/ppsspp/pulls{/number}","milestones_url":"https://api.github.com/repos/hrydgard/ppsspp/milestones{/number}","notifications_url":"https://api.github.com/repos/hrydgard/ppsspp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hrydgard/ppsspp/labels{/name}","releases_url":"https://api.github.com/repos/hrydgard/ppsspp/releases{/id}","created_at":"2012-11-01T08:41:48Z","updated_at":"2014-07-08T16:33:44Z","pushed_at":"2014-07-10T16:41:39Z","git_url":"git://github.com/hrydgard/ppsspp.git","ssh_url":"git@github.com:hrydgard/ppsspp.git","clone_url":"https://github.com/hrydgard/ppsspp.git","svn_url":"https://github.com/hrydgard/ppsspp","homepage":"http://www.ppsspp.org","size":201694,"stargazers_count":1154,"watchers_count":1154,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":579,"mirror_url":null,"open_issues_count":420,"forks":579,"open_issues":420,"watchers":1154,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hrydgard/ppsspp/pulls/6539"},"html":{"href":"https://github.com/hrydgard/ppsspp/pull/6539"},"issue":{"href":"https://api.github.com/repos/hrydgard/ppsspp/issues/6539"},"comments":{"href":"https://api.github.com/repos/hrydgard/ppsspp/issues/6539/comments"},"review_comments":{"href":"https://api.github.com/repos/hrydgard/ppsspp/pulls/6539/comments"},"review_comment":{"href":"https://api.github.com/repos/hrydgard/ppsspp/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/hrydgard/ppsspp/pulls/6539/commits"},"statuses":{"href":"https://api.github.com/repos/hrydgard/ppsspp/statuses/c2d371911fe5f60994d9d2f591527e3c7b204c7e"}}}}