GitHub PullRequestReviewCommentEvent at 2014-12-09 04:45:38
Repository: pyne
Actor: makeclean
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/pyne/pyne/pulls/comments/21506928","id":21506928,"diff_hunk":"@@ -219,6 +219,9 @@ namespace pyne\n     /// used (and stored on the instance) as the atoms_per_molecule for this calculation.\n     /// If \\a apm and atoms_per_molecule on this instance are both negative, then the best\n     /// guess value calculated from the normailized composition is used here.\n+    comp_map activity();\n+\t\t/// Calculates the activity of a material based on the composition and each nuclide's","path":"src/material.h","position":5,"original_position":5,"commit_id":"03cf9bdf556014bd012ebbaeb072090965a1384d","original_commit_id":"03cf9bdf556014bd012ebbaeb072090965a1384d","user":{"login":"makeclean","id":2439754,"avatar_url":"https://avatars.githubusercontent.com/u/2439754?v=3","gravatar_id":"","url":"https://api.github.com/users/makeclean","html_url":"https://github.com/makeclean","followers_url":"https://api.github.com/users/makeclean/followers","following_url":"https://api.github.com/users/makeclean/following{/other_user}","gists_url":"https://api.github.com/users/makeclean/gists{/gist_id}","starred_url":"https://api.github.com/users/makeclean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makeclean/subscriptions","organizations_url":"https://api.github.com/users/makeclean/orgs","repos_url":"https://api.github.com/users/makeclean/repos","events_url":"https://api.github.com/users/makeclean/events{/privacy}","received_events_url":"https://api.github.com/users/makeclean/received_events","type":"User","site_admin":false},"body":"Or sudo rm -rf /usr/bin/vi* :) For a good deep clean.\n\n\nSent on a Sprint Samsung Galaxy Note® 3\n\n<div>-------- Original message --------</div><div>From: Katy Huff <notifications@github.com> </div><div>Date:12/08/2014  10:29 PM  (GMT-06:00) </div><div>To: pyne/pyne <pyne@noreply.github.com> </div><div>Cc: Andrew Davis <davisa@engr.wisc.edu> </div><div>Subject: Re: [pyne] adding activity method to Material (#617) </div><div>\n</div>In src/material.h:\n\n> @@ -219,6 +219,9 @@ namespace pyne\n>      /// used (and stored on the instance) as the atoms_per_molecule for this calculation.\n>      /// If \\a apm and atoms_per_molecule on this instance are both negative, then the best\n>      /// guess value calculated from the normailized composition is used here.\n> +    comp_map activity();\n> +\t\t/// Calculates the activity of a material based on the composition and each nuclide's\nThis is probably a text editor thing. In vi, you have to add \"set expandtab\" to your .vimrc file. If you use emacs, maybe you can ctrl-x ctrl-c until it goes away.* *joking\n…\n—\nReply to this email directly or view it on GitHub.\n\n","created_at":"2014-12-09T04:45:38Z","updated_at":"2014-12-09T04:45:38Z","html_url":"https://github.com/pyne/pyne/pull/617#discussion_r21506928","pull_request_url":"https://api.github.com/repos/pyne/pyne/pulls/617","_links":{"self":{"href":"https://api.github.com/repos/pyne/pyne/pulls/comments/21506928"},"html":{"href":"https://github.com/pyne/pyne/pull/617#discussion_r21506928"},"pull_request":{"href":"https://api.github.com/repos/pyne/pyne/pulls/617"}}},"pull_request":{"url":"https://api.github.com/repos/pyne/pyne/pulls/617","id":25708236,"html_url":"https://github.com/pyne/pyne/pull/617","diff_url":"https://github.com/pyne/pyne/pull/617.diff","patch_url":"https://github.com/pyne/pyne/pull/617.patch","issue_url":"https://api.github.com/repos/pyne/pyne/issues/617","number":617,"state":"open","locked":false,"title":"adding activity method to Material","user":{"login":"opotowsky","id":5347433,"avatar_url":"https://avatars.githubusercontent.com/u/5347433?v=3","gravatar_id":"","url":"https://api.github.com/users/opotowsky","html_url":"https://github.com/opotowsky","followers_url":"https://api.github.com/users/opotowsky/followers","following_url":"https://api.github.com/users/opotowsky/following{/other_user}","gists_url":"https://api.github.com/users/opotowsky/gists{/gist_id}","starred_url":"https://api.github.com/users/opotowsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opotowsky/subscriptions","organizations_url":"https://api.github.com/users/opotowsky/orgs","repos_url":"https://api.github.com/users/opotowsky/repos","events_url":"https://api.github.com/users/opotowsky/events{/privacy}","received_events_url":"https://api.github.com/users/opotowsky/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-12-08T23:51:35Z","updated_at":"2014-12-09T04:45:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a5183ab85018194cfcbde3cdba4638c7ba7b222e","assignee":null,"milestone":{"url":"https://api.github.com/repos/pyne/pyne/milestones/8","labels_url":"https://api.github.com/repos/pyne/pyne/milestones/8/labels","id":612524,"number":8,"title":"v0.5","description":"","creator":{"login":"scopatz","id":320553,"avatar_url":"https://avatars.githubusercontent.com/u/320553?v=3","gravatar_id":"","url":"https://api.github.com/users/scopatz","html_url":"https://github.com/scopatz","followers_url":"https://api.github.com/users/scopatz/followers","following_url":"https://api.github.com/users/scopatz/following{/other_user}","gists_url":"https://api.github.com/users/scopatz/gists{/gist_id}","starred_url":"https://api.github.com/users/scopatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scopatz/subscriptions","organizations_url":"https://api.github.com/users/scopatz/orgs","repos_url":"https://api.github.com/users/scopatz/repos","events_url":"https://api.github.com/users/scopatz/events{/privacy}","received_events_url":"https://api.github.com/users/scopatz/received_events","type":"User","site_admin":false},"open_issues":16,"closed_issues":105,"state":"open","created_at":"2014-03-27T21:01:25Z","updated_at":"2014-12-08T23:53:06Z","due_on":"2014-12-15T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/pyne/pyne/pulls/617/commits","review_comments_url":"https://api.github.com/repos/pyne/pyne/pulls/617/comments","review_comment_url":"https://api.github.com/repos/pyne/pyne/pulls/comments/{number}","comments_url":"https://api.github.com/repos/pyne/pyne/issues/617/comments","statuses_url":"https://api.github.com/repos/pyne/pyne/statuses/03cf9bdf556014bd012ebbaeb072090965a1384d","head":{"label":"opotowsky:act","ref":"act","sha":"03cf9bdf556014bd012ebbaeb072090965a1384d","user":{"login":"opotowsky","id":5347433,"avatar_url":"https://avatars.githubusercontent.com/u/5347433?v=3","gravatar_id":"","url":"https://api.github.com/users/opotowsky","html_url":"https://github.com/opotowsky","followers_url":"https://api.github.com/users/opotowsky/followers","following_url":"https://api.github.com/users/opotowsky/following{/other_user}","gists_url":"https://api.github.com/users/opotowsky/gists{/gist_id}","starred_url":"https://api.github.com/users/opotowsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opotowsky/subscriptions","organizations_url":"https://api.github.com/users/opotowsky/orgs","repos_url":"https://api.github.com/users/opotowsky/repos","events_url":"https://api.github.com/users/opotowsky/events{/privacy}","received_events_url":"https://api.github.com/users/opotowsky/received_events","type":"User","site_admin":false},"repo":{"id":17190278,"name":"pyne","full_name":"opotowsky/pyne","owner":{"login":"opotowsky","id":5347433,"avatar_url":"https://avatars.githubusercontent.com/u/5347433?v=3","gravatar_id":"","url":"https://api.github.com/users/opotowsky","html_url":"https://github.com/opotowsky","followers_url":"https://api.github.com/users/opotowsky/followers","following_url":"https://api.github.com/users/opotowsky/following{/other_user}","gists_url":"https://api.github.com/users/opotowsky/gists{/gist_id}","starred_url":"https://api.github.com/users/opotowsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opotowsky/subscriptions","organizations_url":"https://api.github.com/users/opotowsky/orgs","repos_url":"https://api.github.com/users/opotowsky/repos","events_url":"https://api.github.com/users/opotowsky/events{/privacy}","received_events_url":"https://api.github.com/users/opotowsky/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/opotowsky/pyne","description":"PyNE: The Nuclear Engineering Toolkit","fork":true,"url":"https://api.github.com/repos/opotowsky/pyne","forks_url":"https://api.github.com/repos/opotowsky/pyne/forks","keys_url":"https://api.github.com/repos/opotowsky/pyne/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opotowsky/pyne/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opotowsky/pyne/teams","hooks_url":"https://api.github.com/repos/opotowsky/pyne/hooks","issue_events_url":"https://api.github.com/repos/opotowsky/pyne/issues/events{/number}","events_url":"https://api.github.com/repos/opotowsky/pyne/events","assignees_url":"https://api.github.com/repos/opotowsky/pyne/assignees{/user}","branches_url":"https://api.github.com/repos/opotowsky/pyne/branches{/branch}","tags_url":"https://api.github.com/repos/opotowsky/pyne/tags","blobs_url":"https://api.github.com/repos/opotowsky/pyne/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opotowsky/pyne/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opotowsky/pyne/git/refs{/sha}","trees_url":"https://api.github.com/repos/opotowsky/pyne/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opotowsky/pyne/statuses/{sha}","languages_url":"https://api.github.com/repos/opotowsky/pyne/languages","stargazers_url":"https://api.github.com/repos/opotowsky/pyne/stargazers","contributors_url":"https://api.github.com/repos/opotowsky/pyne/contributors","subscribers_url":"https://api.github.com/repos/opotowsky/pyne/subscribers","subscription_url":"https://api.github.com/repos/opotowsky/pyne/subscription","commits_url":"https://api.github.com/repos/opotowsky/pyne/commits{/sha}","git_commits_url":"https://api.github.com/repos/opotowsky/pyne/git/commits{/sha}","comments_url":"https://api.github.com/repos/opotowsky/pyne/comments{/number}","issue_comment_url":"https://api.github.com/repos/opotowsky/pyne/issues/comments/{number}","contents_url":"https://api.github.com/repos/opotowsky/pyne/contents/{+path}","compare_url":"https://api.github.com/repos/opotowsky/pyne/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opotowsky/pyne/merges","archive_url":"https://api.github.com/repos/opotowsky/pyne/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opotowsky/pyne/downloads","issues_url":"https://api.github.com/repos/opotowsky/pyne/issues{/number}","pulls_url":"https://api.github.com/repos/opotowsky/pyne/pulls{/number}","milestones_url":"https://api.github.com/repos/opotowsky/pyne/milestones{/number}","notifications_url":"https://api.github.com/repos/opotowsky/pyne/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opotowsky/pyne/labels{/name}","releases_url":"https://api.github.com/repos/opotowsky/pyne/releases{/id}","created_at":"2014-02-25T22:21:09Z","updated_at":"2014-06-16T22:48:44Z","pushed_at":"2014-12-08T23:58:06Z","git_url":"git://github.com/opotowsky/pyne.git","ssh_url":"git@github.com:opotowsky/pyne.git","clone_url":"https://github.com/opotowsky/pyne.git","svn_url":"https://github.com/opotowsky/pyne","homepage":"http://pyne.io/","size":12830,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"staging"}},"base":{"label":"pyne:develop","ref":"develop","sha":"bf3e09e02992c26358b43dfdbd31d2cce9dfabaf","user":{"login":"pyne","id":760696,"avatar_url":"https://avatars.githubusercontent.com/u/760696?v=3","gravatar_id":"","url":"https://api.github.com/users/pyne","html_url":"https://github.com/pyne","followers_url":"https://api.github.com/users/pyne/followers","following_url":"https://api.github.com/users/pyne/following{/other_user}","gists_url":"https://api.github.com/users/pyne/gists{/gist_id}","starred_url":"https://api.github.com/users/pyne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyne/subscriptions","organizations_url":"https://api.github.com/users/pyne/orgs","repos_url":"https://api.github.com/users/pyne/repos","events_url":"https://api.github.com/users/pyne/events{/privacy}","received_events_url":"https://api.github.com/users/pyne/received_events","type":"Organization","site_admin":false},"repo":{"id":1684953,"name":"pyne","full_name":"pyne/pyne","owner":{"login":"pyne","id":760696,"avatar_url":"https://avatars.githubusercontent.com/u/760696?v=3","gravatar_id":"","url":"https://api.github.com/users/pyne","html_url":"https://github.com/pyne","followers_url":"https://api.github.com/users/pyne/followers","following_url":"https://api.github.com/users/pyne/following{/other_user}","gists_url":"https://api.github.com/users/pyne/gists{/gist_id}","starred_url":"https://api.github.com/users/pyne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyne/subscriptions","organizations_url":"https://api.github.com/users/pyne/orgs","repos_url":"https://api.github.com/users/pyne/repos","events_url":"https://api.github.com/users/pyne/events{/privacy}","received_events_url":"https://api.github.com/users/pyne/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pyne/pyne","description":"PyNE: The Nuclear Engineering Toolkit","fork":false,"url":"https://api.github.com/repos/pyne/pyne","forks_url":"https://api.github.com/repos/pyne/pyne/forks","keys_url":"https://api.github.com/repos/pyne/pyne/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pyne/pyne/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pyne/pyne/teams","hooks_url":"https://api.github.com/repos/pyne/pyne/hooks","issue_events_url":"https://api.github.com/repos/pyne/pyne/issues/events{/number}","events_url":"https://api.github.com/repos/pyne/pyne/events","assignees_url":"https://api.github.com/repos/pyne/pyne/assignees{/user}","branches_url":"https://api.github.com/repos/pyne/pyne/branches{/branch}","tags_url":"https://api.github.com/repos/pyne/pyne/tags","blobs_url":"https://api.github.com/repos/pyne/pyne/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pyne/pyne/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pyne/pyne/git/refs{/sha}","trees_url":"https://api.github.com/repos/pyne/pyne/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pyne/pyne/statuses/{sha}","languages_url":"https://api.github.com/repos/pyne/pyne/languages","stargazers_url":"https://api.github.com/repos/pyne/pyne/stargazers","contributors_url":"https://api.github.com/repos/pyne/pyne/contributors","subscribers_url":"https://api.github.com/repos/pyne/pyne/subscribers","subscription_url":"https://api.github.com/repos/pyne/pyne/subscription","commits_url":"https://api.github.com/repos/pyne/pyne/commits{/sha}","git_commits_url":"https://api.github.com/repos/pyne/pyne/git/commits{/sha}","comments_url":"https://api.github.com/repos/pyne/pyne/comments{/number}","issue_comment_url":"https://api.github.com/repos/pyne/pyne/issues/comments/{number}","contents_url":"https://api.github.com/repos/pyne/pyne/contents/{+path}","compare_url":"https://api.github.com/repos/pyne/pyne/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pyne/pyne/merges","archive_url":"https://api.github.com/repos/pyne/pyne/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pyne/pyne/downloads","issues_url":"https://api.github.com/repos/pyne/pyne/issues{/number}","pulls_url":"https://api.github.com/repos/pyne/pyne/pulls{/number}","milestones_url":"https://api.github.com/repos/pyne/pyne/milestones{/number}","notifications_url":"https://api.github.com/repos/pyne/pyne/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pyne/pyne/labels{/name}","releases_url":"https://api.github.com/repos/pyne/pyne/releases{/id}","created_at":"2011-04-30T15:04:07Z","updated_at":"2014-12-05T21:08:43Z","pushed_at":"2014-12-05T21:08:43Z","git_url":"git://github.com/pyne/pyne.git","ssh_url":"git@github.com:pyne/pyne.git","clone_url":"https://github.com/pyne/pyne.git","svn_url":"https://github.com/pyne/pyne","homepage":"http://pyne.io/","size":63770,"stargazers_count":38,"watchers_count":38,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":52,"mirror_url":null,"open_issues_count":58,"forks":52,"open_issues":58,"watchers":38,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/pyne/pyne/pulls/617"},"html":{"href":"https://github.com/pyne/pyne/pull/617"},"issue":{"href":"https://api.github.com/repos/pyne/pyne/issues/617"},"comments":{"href":"https://api.github.com/repos/pyne/pyne/issues/617/comments"},"review_comments":{"href":"https://api.github.com/repos/pyne/pyne/pulls/617/comments"},"review_comment":{"href":"https://api.github.com/repos/pyne/pyne/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/pyne/pyne/pulls/617/commits"},"statuses":{"href":"https://api.github.com/repos/pyne/pyne/statuses/03cf9bdf556014bd012ebbaeb072090965a1384d"}}}}