GitHub PullRequestReviewCommentEvent at 2014-08-28 11:01:58
Repository: iris
Actor: esc24
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/SciTools/iris/pulls/comments/16832598","id":16832598,"diff_hunk":"@@ -43,23 +43,39 @@ class LazyArray(object):\n     computed and cached for any subsequent access.\n \n     \"\"\"\n-    def __init__(self, shape, func):\n+    def __init__(self, shape, dtype, func):\n         \"\"\"\n         Args:\n \n         * shape (tuple):\n             The shape of the array which will be created.\n+        * dtype (np.dtype):\n+            The numpy dtype of the array which will be created.\n         * func:\n             The function which will be called to supply the real array.\n \n         \"\"\"\n         self.shape = tuple(shape)\n+        self.dtype = dtype\n         self._func = func\n         self._array = None\n \n     def __repr__(self):\n         return '<LazyArray(shape={})>'.format(self.shape)\n \n+    # pickle can't handle function objects, so force the evaluation.\n+    def __getstate__(self):\n+        return {'shape': self.shape, 'dtype': self.dtype, '_func': None,\n+                '_array': self._cached_array()}\n+\n+    # Don't want copy/deepcopy to use the pickle interface (because of the\n+    # evaluation side-effect), so provide an explicit implementation.\n+    def __copy__(self):\n+        return self","path":"lib/iris/aux_factory.py","position":33,"original_position":33,"commit_id":"e2d856980ee8650fbd723c485accea77af53e4df","original_commit_id":"e2d856980ee8650fbd723c485accea77af53e4df","user":{"login":"esc24","id":1634089,"avatar_url":"https://avatars.githubusercontent.com/u/1634089?v=2","gravatar_id":"8bd0e92cdf61b60bc2e2aa4bd77cfc3e","url":"https://api.github.com/users/esc24","html_url":"https://github.com/esc24","followers_url":"https://api.github.com/users/esc24/followers","following_url":"https://api.github.com/users/esc24/following{/other_user}","gists_url":"https://api.github.com/users/esc24/gists{/gist_id}","starred_url":"https://api.github.com/users/esc24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esc24/subscriptions","organizations_url":"https://api.github.com/users/esc24/orgs","repos_url":"https://api.github.com/users/esc24/repos","events_url":"https://api.github.com/users/esc24/events{/privacy}","received_events_url":"https://api.github.com/users/esc24/received_events","type":"User","site_admin":false},"body":"Not sure about this. How about instantiating a new one and setting `_array` manually?","created_at":"2014-08-28T11:01:58Z","updated_at":"2014-08-28T11:01:58Z","html_url":"https://github.com/SciTools/iris/pull/1291#discussion_r16832598","pull_request_url":"https://api.github.com/repos/SciTools/iris/pulls/1291","_links":{"self":{"href":"https://api.github.com/repos/SciTools/iris/pulls/comments/16832598"},"html":{"href":"https://github.com/SciTools/iris/pull/1291#discussion_r16832598"},"pull_request":{"href":"https://api.github.com/repos/SciTools/iris/pulls/1291"}}},"pull_request":{"url":"https://api.github.com/repos/SciTools/iris/pulls/1291","id":20373962,"html_url":"https://github.com/SciTools/iris/pull/1291","diff_url":"https://github.com/SciTools/iris/pull/1291.diff","patch_url":"https://github.com/SciTools/iris/pull/1291.patch","issue_url":"https://api.github.com/repos/SciTools/iris/issues/1291","number":1291,"state":"open","locked":false,"title":"Preserve deferred loading of netCDF aux coords.","user":{"login":"rhattersley","id":917914,"avatar_url":"https://avatars.githubusercontent.com/u/917914?v=2","gravatar_id":"1889af9f21c3e07af149e04f23a9619b","url":"https://api.github.com/users/rhattersley","html_url":"https://github.com/rhattersley","followers_url":"https://api.github.com/users/rhattersley/followers","following_url":"https://api.github.com/users/rhattersley/following{/other_user}","gists_url":"https://api.github.com/users/rhattersley/gists{/gist_id}","starred_url":"https://api.github.com/users/rhattersley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhattersley/subscriptions","organizations_url":"https://api.github.com/users/rhattersley/orgs","repos_url":"https://api.github.com/users/rhattersley/repos","events_url":"https://api.github.com/users/rhattersley/events{/privacy}","received_events_url":"https://api.github.com/users/rhattersley/received_events","type":"User","site_admin":false},"body":"Fix for #1287.\r\n\r\n(Replaces #1290.)","created_at":"2014-08-27T13:43:49Z","updated_at":"2014-08-28T11:01:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"13586d2501372d0b7aa287e568c976ab95daff28","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SciTools/iris/pulls/1291/commits","review_comments_url":"https://api.github.com/repos/SciTools/iris/pulls/1291/comments","review_comment_url":"https://api.github.com/repos/SciTools/iris/pulls/comments/{number}","comments_url":"https://api.github.com/repos/SciTools/iris/issues/1291/comments","statuses_url":"https://api.github.com/repos/SciTools/iris/statuses/e2d856980ee8650fbd723c485accea77af53e4df","head":{"label":"rhattersley:lazy-dtype","ref":"lazy-dtype","sha":"e2d856980ee8650fbd723c485accea77af53e4df","user":{"login":"rhattersley","id":917914,"avatar_url":"https://avatars.githubusercontent.com/u/917914?v=2","gravatar_id":"1889af9f21c3e07af149e04f23a9619b","url":"https://api.github.com/users/rhattersley","html_url":"https://github.com/rhattersley","followers_url":"https://api.github.com/users/rhattersley/followers","following_url":"https://api.github.com/users/rhattersley/following{/other_user}","gists_url":"https://api.github.com/users/rhattersley/gists{/gist_id}","starred_url":"https://api.github.com/users/rhattersley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhattersley/subscriptions","organizations_url":"https://api.github.com/users/rhattersley/orgs","repos_url":"https://api.github.com/users/rhattersley/repos","events_url":"https://api.github.com/users/rhattersley/events{/privacy}","received_events_url":"https://api.github.com/users/rhattersley/received_events","type":"User","site_admin":false},"repo":{"id":5312787,"name":"iris","full_name":"rhattersley/iris","owner":{"login":"rhattersley","id":917914,"avatar_url":"https://avatars.githubusercontent.com/u/917914?v=2","gravatar_id":"1889af9f21c3e07af149e04f23a9619b","url":"https://api.github.com/users/rhattersley","html_url":"https://github.com/rhattersley","followers_url":"https://api.github.com/users/rhattersley/followers","following_url":"https://api.github.com/users/rhattersley/following{/other_user}","gists_url":"https://api.github.com/users/rhattersley/gists{/gist_id}","starred_url":"https://api.github.com/users/rhattersley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhattersley/subscriptions","organizations_url":"https://api.github.com/users/rhattersley/orgs","repos_url":"https://api.github.com/users/rhattersley/repos","events_url":"https://api.github.com/users/rhattersley/events{/privacy}","received_events_url":"https://api.github.com/users/rhattersley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rhattersley/iris","description":"","fork":true,"url":"https://api.github.com/repos/rhattersley/iris","forks_url":"https://api.github.com/repos/rhattersley/iris/forks","keys_url":"https://api.github.com/repos/rhattersley/iris/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rhattersley/iris/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rhattersley/iris/teams","hooks_url":"https://api.github.com/repos/rhattersley/iris/hooks","issue_events_url":"https://api.github.com/repos/rhattersley/iris/issues/events{/number}","events_url":"https://api.github.com/repos/rhattersley/iris/events","assignees_url":"https://api.github.com/repos/rhattersley/iris/assignees{/user}","branches_url":"https://api.github.com/repos/rhattersley/iris/branches{/branch}","tags_url":"https://api.github.com/repos/rhattersley/iris/tags","blobs_url":"https://api.github.com/repos/rhattersley/iris/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rhattersley/iris/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rhattersley/iris/git/refs{/sha}","trees_url":"https://api.github.com/repos/rhattersley/iris/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rhattersley/iris/statuses/{sha}","languages_url":"https://api.github.com/repos/rhattersley/iris/languages","stargazers_url":"https://api.github.com/repos/rhattersley/iris/stargazers","contributors_url":"https://api.github.com/repos/rhattersley/iris/contributors","subscribers_url":"https://api.github.com/repos/rhattersley/iris/subscribers","subscription_url":"https://api.github.com/repos/rhattersley/iris/subscription","commits_url":"https://api.github.com/repos/rhattersley/iris/commits{/sha}","git_commits_url":"https://api.github.com/repos/rhattersley/iris/git/commits{/sha}","comments_url":"https://api.github.com/repos/rhattersley/iris/comments{/number}","issue_comment_url":"https://api.github.com/repos/rhattersley/iris/issues/comments/{number}","contents_url":"https://api.github.com/repos/rhattersley/iris/contents/{+path}","compare_url":"https://api.github.com/repos/rhattersley/iris/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rhattersley/iris/merges","archive_url":"https://api.github.com/repos/rhattersley/iris/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rhattersley/iris/downloads","issues_url":"https://api.github.com/repos/rhattersley/iris/issues{/number}","pulls_url":"https://api.github.com/repos/rhattersley/iris/pulls{/number}","milestones_url":"https://api.github.com/repos/rhattersley/iris/milestones{/number}","notifications_url":"https://api.github.com/repos/rhattersley/iris/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rhattersley/iris/labels{/name}","releases_url":"https://api.github.com/repos/rhattersley/iris/releases{/id}","created_at":"2012-08-06T10:24:45Z","updated_at":"2014-06-25T15:40:53Z","pushed_at":"2014-08-28T07:35:57Z","git_url":"git://github.com/rhattersley/iris.git","ssh_url":"git@github.com:rhattersley/iris.git","clone_url":"https://github.com/rhattersley/iris.git","svn_url":"https://github.com/rhattersley/iris","homepage":null,"size":97461,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"SciTools:v1.7.x","ref":"v1.7.x","sha":"4d4280d5a09e478959811efdbe2d387a6727971c","user":{"login":"SciTools","id":1391487,"avatar_url":"https://avatars.githubusercontent.com/u/1391487?v=2","gravatar_id":null,"url":"https://api.github.com/users/SciTools","html_url":"https://github.com/SciTools","followers_url":"https://api.github.com/users/SciTools/followers","following_url":"https://api.github.com/users/SciTools/following{/other_user}","gists_url":"https://api.github.com/users/SciTools/gists{/gist_id}","starred_url":"https://api.github.com/users/SciTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SciTools/subscriptions","organizations_url":"https://api.github.com/users/SciTools/orgs","repos_url":"https://api.github.com/users/SciTools/repos","events_url":"https://api.github.com/users/SciTools/events{/privacy}","received_events_url":"https://api.github.com/users/SciTools/received_events","type":"Organization","site_admin":false},"repo":{"id":5312648,"name":"iris","full_name":"SciTools/iris","owner":{"login":"SciTools","id":1391487,"avatar_url":"https://avatars.githubusercontent.com/u/1391487?v=2","gravatar_id":null,"url":"https://api.github.com/users/SciTools","html_url":"https://github.com/SciTools","followers_url":"https://api.github.com/users/SciTools/followers","following_url":"https://api.github.com/users/SciTools/following{/other_user}","gists_url":"https://api.github.com/users/SciTools/gists{/gist_id}","starred_url":"https://api.github.com/users/SciTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SciTools/subscriptions","organizations_url":"https://api.github.com/users/SciTools/orgs","repos_url":"https://api.github.com/users/SciTools/repos","events_url":"https://api.github.com/users/SciTools/events{/privacy}","received_events_url":"https://api.github.com/users/SciTools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SciTools/iris","description":"A powerful, easy to use, and community-driven Python library for analysing and visualising meteorological and oceanographic data sets.","fork":false,"url":"https://api.github.com/repos/SciTools/iris","forks_url":"https://api.github.com/repos/SciTools/iris/forks","keys_url":"https://api.github.com/repos/SciTools/iris/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SciTools/iris/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SciTools/iris/teams","hooks_url":"https://api.github.com/repos/SciTools/iris/hooks","issue_events_url":"https://api.github.com/repos/SciTools/iris/issues/events{/number}","events_url":"https://api.github.com/repos/SciTools/iris/events","assignees_url":"https://api.github.com/repos/SciTools/iris/assignees{/user}","branches_url":"https://api.github.com/repos/SciTools/iris/branches{/branch}","tags_url":"https://api.github.com/repos/SciTools/iris/tags","blobs_url":"https://api.github.com/repos/SciTools/iris/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SciTools/iris/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SciTools/iris/git/refs{/sha}","trees_url":"https://api.github.com/repos/SciTools/iris/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SciTools/iris/statuses/{sha}","languages_url":"https://api.github.com/repos/SciTools/iris/languages","stargazers_url":"https://api.github.com/repos/SciTools/iris/stargazers","contributors_url":"https://api.github.com/repos/SciTools/iris/contributors","subscribers_url":"https://api.github.com/repos/SciTools/iris/subscribers","subscription_url":"https://api.github.com/repos/SciTools/iris/subscription","commits_url":"https://api.github.com/repos/SciTools/iris/commits{/sha}","git_commits_url":"https://api.github.com/repos/SciTools/iris/git/commits{/sha}","comments_url":"https://api.github.com/repos/SciTools/iris/comments{/number}","issue_comment_url":"https://api.github.com/repos/SciTools/iris/issues/comments/{number}","contents_url":"https://api.github.com/repos/SciTools/iris/contents/{+path}","compare_url":"https://api.github.com/repos/SciTools/iris/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SciTools/iris/merges","archive_url":"https://api.github.com/repos/SciTools/iris/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SciTools/iris/downloads","issues_url":"https://api.github.com/repos/SciTools/iris/issues{/number}","pulls_url":"https://api.github.com/repos/SciTools/iris/pulls{/number}","milestones_url":"https://api.github.com/repos/SciTools/iris/milestones{/number}","notifications_url":"https://api.github.com/repos/SciTools/iris/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SciTools/iris/labels{/name}","releases_url":"https://api.github.com/repos/SciTools/iris/releases{/id}","created_at":"2012-08-06T10:09:14Z","updated_at":"2014-08-26T08:07:02Z","pushed_at":"2014-08-27T20:51:07Z","git_url":"git://github.com/SciTools/iris.git","ssh_url":"git@github.com:SciTools/iris.git","clone_url":"https://github.com/SciTools/iris.git","svn_url":"https://github.com/SciTools/iris","homepage":"http://scitools.org.uk/iris/","size":143640,"stargazers_count":70,"watchers_count":70,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":59,"mirror_url":null,"open_issues_count":141,"forks":59,"open_issues":141,"watchers":70,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SciTools/iris/pulls/1291"},"html":{"href":"https://github.com/SciTools/iris/pull/1291"},"issue":{"href":"https://api.github.com/repos/SciTools/iris/issues/1291"},"comments":{"href":"https://api.github.com/repos/SciTools/iris/issues/1291/comments"},"review_comments":{"href":"https://api.github.com/repos/SciTools/iris/pulls/1291/comments"},"review_comment":{"href":"https://api.github.com/repos/SciTools/iris/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/SciTools/iris/pulls/1291/commits"},"statuses":{"href":"https://api.github.com/repos/SciTools/iris/statuses/e2d856980ee8650fbd723c485accea77af53e4df"}}}}