GitHub PullRequestReviewCommentEvent at 2014-04-20 02:01:41
Repository: rmc
Actor: JGulbronson
Payload: {"comment":{"url":"https://api.github.com/repos/UWFlow/rmc/pulls/comments/11796567","id":11796567,"diff_hunk":"@@ -1,46 +1,26 @@\n // TODO(jeff): Reuse main.js from the main Javascript folder, adding in the\n // testing libraries mocha and chai\n-require.config({\n-  baseUrl: '../',\n-  paths: {\n-    'ext/jquery': 'ext/jquery-1.8.1',\n-    'ext/underscore': 'ext/underscore-1.3.3',\n-    'ext/underscore.string': 'ext/underscore.string-2.0.0',\n-    'moment': 'ext/moment',\n-    'moment-timezone': 'ext/moment-timezone',\n-    'mocha': 'js_tests/vendor/mocha',\n-    'chai': 'js_tests/vendor/chai'\n-  },\n-  shim: {\n-    'ext/underscore': {\n-      exports: '_'\n-    },\n-    'ext/jquery': {\n-      exports: '$'\n-    },\n-    'ext/underscore.string': {\n-      deps: ['ext/underscore'],\n-      exports: function(_) {\n-        return _.string;\n-      }\n-    },\n-    'ext/moment': {\n-      exports: 'moment'\n-    }\n-  }\n-});\n+require(['../config_settings'], function(config_settings) {\n+  var testPaths  = config_settings.paths;\n+  testPaths['chai'] = 'js_tests/vendor/chai';\n+  testPaths['mocha'] = 'js_tests/vendor/mocha';\n+  require.config({\n+    baseUrl: '../',\n+    paths: testPaths,\n+    shim: config_settings.shim\n+  });\n \n-require(['require', 'chai', 'mocha', 'ext/jquery'],\n-\t\tfunction(require, chai){\n+  require(['require', 'chai', 'mocha', 'ext/jquery'],","path":"server/static/js/js_tests/main.js","position":44,"original_position":44,"commit_id":"38861b14df06ab432cd65b5611a66ddbbde51839","original_commit_id":"4e5ca76b72b7f6e0c2ae9590feda8caffcd9b04c","user":{"login":"JGulbronson","id":2644780,"avatar_url":"https://avatars.githubusercontent.com/u/2644780?","gravatar_id":"3076bfceac93247ef71ad9d15df87180","url":"https://api.github.com/users/JGulbronson","html_url":"https://github.com/JGulbronson","followers_url":"https://api.github.com/users/JGulbronson/followers","following_url":"https://api.github.com/users/JGulbronson/following{/other_user}","gists_url":"https://api.github.com/users/JGulbronson/gists{/gist_id}","starred_url":"https://api.github.com/users/JGulbronson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JGulbronson/subscriptions","organizations_url":"https://api.github.com/users/JGulbronson/orgs","repos_url":"https://api.github.com/users/JGulbronson/repos","events_url":"https://api.github.com/users/JGulbronson/events{/privacy}","received_events_url":"https://api.github.com/users/JGulbronson/received_events","type":"User","site_admin":false},"body":"Hmm, you're right... let me see what I can remove.","created_at":"2014-04-20T02:01:41Z","updated_at":"2014-04-20T02:01:41Z","html_url":"https://github.com/UWFlow/rmc/pull/161#discussion_r11796567","pull_request_url":"https://api.github.com/repos/UWFlow/rmc/pulls/161","_links":{"self":{"href":"https://api.github.com/repos/UWFlow/rmc/pulls/comments/11796567"},"html":{"href":"https://github.com/UWFlow/rmc/pull/161#discussion_r11796567"},"pull_request":{"href":"https://api.github.com/repos/UWFlow/rmc/pulls/161"}}}}