GitHub PullRequestReviewCommentEvent at 2014-07-11 18:44:39
Repository: incubator-twill
Actor: anew
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-twill/pulls/comments/14837073","id":14837073,"diff_hunk":"@@ -252,6 +305,84 @@ public RunnableSetter apply() {\n       }\n     }\n \n+    public interface MorePlacementPolicies {\n+      PlacementPolicySetter add(Hosts hosts, String name, String... names);","path":"twill-api/src/main/java/org/apache/twill/api/TwillSpecification.java","position":93,"original_position":93,"commit_id":"a91bf4b394a59bf97516765d76acc0affb52d890","original_commit_id":"a91bf4b394a59bf97516765d76acc0affb52d890","user":{"login":"anew","id":483004,"avatar_url":"https://avatars.githubusercontent.com/u/483004?","gravatar_id":"acaf9037c364efb3a80c4bc7061054b7","url":"https://api.github.com/users/anew","html_url":"https://github.com/anew","followers_url":"https://api.github.com/users/anew/followers","following_url":"https://api.github.com/users/anew/following{/other_user}","gists_url":"https://api.github.com/users/anew/gists{/gist_id}","starred_url":"https://api.github.com/users/anew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anew/subscriptions","organizations_url":"https://api.github.com/users/anew/orgs","repos_url":"https://api.github.com/users/anew/repos","events_url":"https://api.github.com/users/anew/events{/privacy}","received_events_url":"https://api.github.com/users/anew/received_events","type":"User","site_admin":false},"body":"Could you add javadoc what these mean? So name, names is the list of runnables it applies to?","created_at":"2014-07-11T18:44:39Z","updated_at":"2014-07-11T18:44:39Z","html_url":"https://github.com/apache/incubator-twill/pull/7#discussion_r14837073","pull_request_url":"https://api.github.com/repos/apache/incubator-twill/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-twill/pulls/comments/14837073"},"html":{"href":"https://github.com/apache/incubator-twill/pull/7#discussion_r14837073"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-twill/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-twill/pulls/7","id":17285885,"html_url":"https://github.com/apache/incubator-twill/pull/7","diff_url":"https://github.com/apache/incubator-twill/pull/7.diff","patch_url":"https://github.com/apache/incubator-twill/pull/7.patch","issue_url":"https://api.github.com/repos/apache/incubator-twill/issues/7","number":7,"state":"open","title":"Placement Policy API","user":{"login":"gkhaneja","id":2020935,"avatar_url":"https://avatars.githubusercontent.com/u/2020935?","gravatar_id":"22e78a46eea814298ce1838d5109312b","url":"https://api.github.com/users/gkhaneja","html_url":"https://github.com/gkhaneja","followers_url":"https://api.github.com/users/gkhaneja/followers","following_url":"https://api.github.com/users/gkhaneja/following{/other_user}","gists_url":"https://api.github.com/users/gkhaneja/gists{/gist_id}","starred_url":"https://api.github.com/users/gkhaneja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkhaneja/subscriptions","organizations_url":"https://api.github.com/users/gkhaneja/orgs","repos_url":"https://api.github.com/users/gkhaneja/repos","events_url":"https://api.github.com/users/gkhaneja/events{/privacy}","received_events_url":"https://api.github.com/users/gkhaneja/received_events","type":"User","site_admin":false},"body":"1. Added PlacementPolicy API. Only supporting DISTRIBUTED runnables for now.\r\n2. Allocating Containers for one runnable instance at a time, instead of grouping them together based on Resource Specs. \r\n3. Added blacklist support for DISTRIBUTED PlacementPolicy. \r\n4. TODO: Implement PlacementHints (added placeholder). \r\n5. Added PlacementPolicyTestRun Class with a method testDistributedPlacementPolicy to test the current implementation.\r\n\r\nGourav","created_at":"2014-06-18T10:33:36Z","updated_at":"2014-07-11T18:44:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a6f93e4e81b2dd6487d7086d7205fc67e70634c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-twill/pulls/7/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-twill/pulls/7/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-twill/pulls/comments/{number}","comments_url":"https://api.github.com/repos/apache/incubator-twill/issues/7/comments","statuses_url":"https://api.github.com/repos/apache/incubator-twill/statuses/a91bf4b394a59bf97516765d76acc0affb52d890","head":{"label":"gkhaneja:master","ref":"master","sha":"a91bf4b394a59bf97516765d76acc0affb52d890","user":{"login":"gkhaneja","id":2020935,"avatar_url":"https://avatars.githubusercontent.com/u/2020935?","gravatar_id":"22e78a46eea814298ce1838d5109312b","url":"https://api.github.com/users/gkhaneja","html_url":"https://github.com/gkhaneja","followers_url":"https://api.github.com/users/gkhaneja/followers","following_url":"https://api.github.com/users/gkhaneja/following{/other_user}","gists_url":"https://api.github.com/users/gkhaneja/gists{/gist_id}","starred_url":"https://api.github.com/users/gkhaneja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkhaneja/subscriptions","organizations_url":"https://api.github.com/users/gkhaneja/orgs","repos_url":"https://api.github.com/users/gkhaneja/repos","events_url":"https://api.github.com/users/gkhaneja/events{/privacy}","received_events_url":"https://api.github.com/users/gkhaneja/received_events","type":"User","site_admin":false},"repo":{"id":20820737,"name":"incubator-twill","full_name":"gkhaneja/incubator-twill","owner":{"login":"gkhaneja","id":2020935,"avatar_url":"https://avatars.githubusercontent.com/u/2020935?","gravatar_id":"22e78a46eea814298ce1838d5109312b","url":"https://api.github.com/users/gkhaneja","html_url":"https://github.com/gkhaneja","followers_url":"https://api.github.com/users/gkhaneja/followers","following_url":"https://api.github.com/users/gkhaneja/following{/other_user}","gists_url":"https://api.github.com/users/gkhaneja/gists{/gist_id}","starred_url":"https://api.github.com/users/gkhaneja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkhaneja/subscriptions","organizations_url":"https://api.github.com/users/gkhaneja/orgs","repos_url":"https://api.github.com/users/gkhaneja/repos","events_url":"https://api.github.com/users/gkhaneja/events{/privacy}","received_events_url":"https://api.github.com/users/gkhaneja/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gkhaneja/incubator-twill","description":"Mirror of Apache Twill","fork":true,"url":"https://api.github.com/repos/gkhaneja/incubator-twill","forks_url":"https://api.github.com/repos/gkhaneja/incubator-twill/forks","keys_url":"https://api.github.com/repos/gkhaneja/incubator-twill/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gkhaneja/incubator-twill/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gkhaneja/incubator-twill/teams","hooks_url":"https://api.github.com/repos/gkhaneja/incubator-twill/hooks","issue_events_url":"https://api.github.com/repos/gkhaneja/incubator-twill/issues/events{/number}","events_url":"https://api.github.com/repos/gkhaneja/incubator-twill/events","assignees_url":"https://api.github.com/repos/gkhaneja/incubator-twill/assignees{/user}","branches_url":"https://api.github.com/repos/gkhaneja/incubator-twill/branches{/branch}","tags_url":"https://api.github.com/repos/gkhaneja/incubator-twill/tags","blobs_url":"https://api.github.com/repos/gkhaneja/incubator-twill/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gkhaneja/incubator-twill/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gkhaneja/incubator-twill/git/refs{/sha}","trees_url":"https://api.github.com/repos/gkhaneja/incubator-twill/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gkhaneja/incubator-twill/statuses/{sha}","languages_url":"https://api.github.com/repos/gkhaneja/incubator-twill/languages","stargazers_url":"https://api.github.com/repos/gkhaneja/incubator-twill/stargazers","contributors_url":"https://api.github.com/repos/gkhaneja/incubator-twill/contributors","subscribers_url":"https://api.github.com/repos/gkhaneja/incubator-twill/subscribers","subscription_url":"https://api.github.com/repos/gkhaneja/incubator-twill/subscription","commits_url":"https://api.github.com/repos/gkhaneja/incubator-twill/commits{/sha}","git_commits_url":"https://api.github.com/repos/gkhaneja/incubator-twill/git/commits{/sha}","comments_url":"https://api.github.com/repos/gkhaneja/incubator-twill/comments{/number}","issue_comment_url":"https://api.github.com/repos/gkhaneja/incubator-twill/issues/comments/{number}","contents_url":"https://api.github.com/repos/gkhaneja/incubator-twill/contents/{+path}","compare_url":"https://api.github.com/repos/gkhaneja/incubator-twill/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gkhaneja/incubator-twill/merges","archive_url":"https://api.github.com/repos/gkhaneja/incubator-twill/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gkhaneja/incubator-twill/downloads","issues_url":"https://api.github.com/repos/gkhaneja/incubator-twill/issues{/number}","pulls_url":"https://api.github.com/repos/gkhaneja/incubator-twill/pulls{/number}","milestones_url":"https://api.github.com/repos/gkhaneja/incubator-twill/milestones{/number}","notifications_url":"https://api.github.com/repos/gkhaneja/incubator-twill/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gkhaneja/incubator-twill/labels{/name}","releases_url":"https://api.github.com/repos/gkhaneja/incubator-twill/releases{/id}","created_at":"2014-06-13T23:31:35Z","updated_at":"2014-07-07T20:00:07Z","pushed_at":"2014-07-07T20:00:07Z","git_url":"git://github.com/gkhaneja/incubator-twill.git","ssh_url":"git@github.com:gkhaneja/incubator-twill.git","clone_url":"https://github.com/gkhaneja/incubator-twill.git","svn_url":"https://github.com/gkhaneja/incubator-twill","homepage":null,"size":9623,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"36b9df175cd41ae5733f50f89e2f842e0e6d2c1e","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?","gravatar_id":"a676c0bf448fcd49f588249ead719b4c","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":16249272,"name":"incubator-twill","full_name":"apache/incubator-twill","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?","gravatar_id":"a676c0bf448fcd49f588249ead719b4c","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-twill","description":"Mirror of Apache Twill","fork":false,"url":"https://api.github.com/repos/apache/incubator-twill","forks_url":"https://api.github.com/repos/apache/incubator-twill/forks","keys_url":"https://api.github.com/repos/apache/incubator-twill/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-twill/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-twill/teams","hooks_url":"https://api.github.com/repos/apache/incubator-twill/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-twill/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-twill/events","assignees_url":"https://api.github.com/repos/apache/incubator-twill/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-twill/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-twill/tags","blobs_url":"https://api.github.com/repos/apache/incubator-twill/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-twill/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-twill/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-twill/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-twill/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-twill/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-twill/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-twill/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-twill/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-twill/subscription","commits_url":"https://api.github.com/repos/apache/incubator-twill/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-twill/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-twill/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-twill/issues/comments/{number}","contents_url":"https://api.github.com/repos/apache/incubator-twill/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-twill/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-twill/merges","archive_url":"https://api.github.com/repos/apache/incubator-twill/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-twill/downloads","issues_url":"https://api.github.com/repos/apache/incubator-twill/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-twill/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-twill/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-twill/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-twill/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-twill/releases{/id}","created_at":"2014-01-26T08:00:07Z","updated_at":"2014-07-07T19:01:02Z","pushed_at":"2014-07-11T18:24:35Z","git_url":"git://github.com/apache/incubator-twill.git","ssh_url":"git@github.com:apache/incubator-twill.git","clone_url":"https://github.com/apache/incubator-twill.git","svn_url":"https://github.com/apache/incubator-twill","homepage":null,"size":10314,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":8,"mirror_url":"git://git.apache.org/incubator-twill.git","open_issues_count":2,"forks":8,"open_issues":2,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-twill/pulls/7"},"html":{"href":"https://github.com/apache/incubator-twill/pull/7"},"issue":{"href":"https://api.github.com/repos/apache/incubator-twill/issues/7"},"comments":{"href":"https://api.github.com/repos/apache/incubator-twill/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-twill/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-twill/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-twill/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-twill/statuses/a91bf4b394a59bf97516765d76acc0affb52d890"}}}}