GitHub PullRequestReviewCommentEvent at 2014-02-17 16:34:22
Repository: narayana
Actor: mmusgrov
Payload: {"comment":{"url":"https://api.github.com/repos/jbosstm/narayana/pulls/comments/9796995","id":9796995,"diff_hunk":"@@ -765,17 +783,25 @@ public boolean enlistResource(XAResource xaRes, Object[] params)\n     private AbstractRecord createRecord(XAResource xaRes, Object[] params, Xid xid)\n     {\n         final AbstractRecord record;\n+        \n+        if (_exceptionDeferrers == null)","path":"ArjunaJTA/jta/classes/com/arjuna/ats/internal/jta/transaction/arjunacore/TransactionImple.java","position":69,"original_position":69,"commit_id":"bb1f0ea20fb361db165d137d331ef74bf33edcbe","original_commit_id":"bb1f0ea20fb361db165d137d331ef74bf33edcbe","user":{"login":"mmusgrov","id":493492,"avatar_url":"https://gravatar.com/avatar/36b27759ac4cad9fc91c8024a50cedce?d=https%3A%2F%2Fidenticons.github.com%2Fcf8428495d920235b1975bb58c538417.png&r=x","gravatar_id":"36b27759ac4cad9fc91c8024a50cedce","url":"https://api.github.com/users/mmusgrov","html_url":"https://github.com/mmusgrov","followers_url":"https://api.github.com/users/mmusgrov/followers","following_url":"https://api.github.com/users/mmusgrov/following{/other_user}","gists_url":"https://api.github.com/users/mmusgrov/gists{/gist_id}","starred_url":"https://api.github.com/users/mmusgrov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmusgrov/subscriptions","organizations_url":"https://api.github.com/users/mmusgrov/orgs","repos_url":"https://api.github.com/users/mmusgrov/repos","events_url":"https://api.github.com/users/mmusgrov/events{/privacy}","received_events_url":"https://api.github.com/users/mmusgrov/received_events","type":"User","site_admin":false},"body":"Every transaction is now maintaining an extra collection as part of its state. Would it be possible to create the collection at the point where an exception is about to be thrown by inspecting the failedList.in BasicAction (super class of this class) and then ask each member of the failed list to report any deferred exceptions.\r\n\r\nI am also wondering whether the interface method List<Throwable> getDeferredThrowables(); could be rewritten as void getDeferredThrowables(List<Throwable>); so that the resource record does not have to always create a collection to maintain its own list of throwables.","created_at":"2014-02-17T16:34:22Z","updated_at":"2014-02-17T16:34:22Z","html_url":"https://github.com/jbosstm/narayana/pull/598#discussion_r9796995","pull_request_url":"https://api.github.com/repos/jbosstm/narayana/pulls/598","_links":{"self":{"href":"https://api.github.com/repos/jbosstm/narayana/pulls/comments/9796995"},"html":{"href":"https://github.com/jbosstm/narayana/pull/598#discussion_r9796995"},"pull_request":{"href":"https://api.github.com/repos/jbosstm/narayana/pulls/598"}}}}