GitHub PullRequestReviewCommentEvent at 2014-12-11 22:00:27
Repository: fcrepo4
Actor: cbeer
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/comments/21713204","id":21713204,"diff_hunk":"@@ -443,10 +452,17 @@ public Boolean isNew() {\n      */\n     @Override\n     public void replaceProperties(final IdentifierConverter<Resource, FedoraResource> idTranslator,\n-        final Model inputModel, final RdfStream originalTriples) throws MalformedRdfException {\n+        final Model inputModel, final RdfStream originalTriples)\n+        throws MalformedRdfException, FedoraInvalidNamespaceException {\n \n         final RdfStream replacementStream = new RdfStream().namespaces(inputModel.getNsPrefixMap());\n \n+        // reject if update request contains any fcr namespacess\n+        final String fcrNS = inputModel.getNsPrefixURI(\"fcr\");","path":"fcrepo-kernel-impl/src/main/java/org/fcrepo/kernel/impl/FedoraResourceImpl.java","position":56,"original_position":56,"commit_id":"efd3eab5322ebad0670551011be7ecba9ad81aa8","original_commit_id":"efd3eab5322ebad0670551011be7ecba9ad81aa8","user":{"login":"cbeer","id":111218,"avatar_url":"https://avatars.githubusercontent.com/u/111218?v=3","gravatar_id":"","url":"https://api.github.com/users/cbeer","html_url":"https://github.com/cbeer","followers_url":"https://api.github.com/users/cbeer/followers","following_url":"https://api.github.com/users/cbeer/following{/other_user}","gists_url":"https://api.github.com/users/cbeer/gists{/gist_id}","starred_url":"https://api.github.com/users/cbeer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbeer/subscriptions","organizations_url":"https://api.github.com/users/cbeer/orgs","repos_url":"https://api.github.com/users/cbeer/repos","events_url":"https://api.github.com/users/cbeer/events{/privacy}","received_events_url":"https://api.github.com/users/cbeer/received_events","type":"User","site_admin":false},"body":"@awoods Doesn't this prevent round-tripping graphs that fcrepo4 provides with an `fcr` prefix?","created_at":"2014-12-11T22:00:27Z","updated_at":"2014-12-11T22:00:27Z","html_url":"https://github.com/fcrepo4/fcrepo4/pull/673#discussion_r21713204","pull_request_url":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/673","_links":{"self":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/comments/21713204"},"html":{"href":"https://github.com/fcrepo4/fcrepo4/pull/673#discussion_r21713204"},"pull_request":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/673"}}},"pull_request":{"url":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/673","id":25611505,"html_url":"https://github.com/fcrepo4/fcrepo4/pull/673","diff_url":"https://github.com/fcrepo4/fcrepo4/pull/673.diff","patch_url":"https://github.com/fcrepo4/fcrepo4/pull/673.patch","issue_url":"https://api.github.com/repos/fcrepo4/fcrepo4/issues/673","number":673,"state":"closed","locked":false,"title":"Reject fedora resource property update that contains fcr namespace prefix.","user":{"login":"lsitu","id":2430784,"avatar_url":"https://avatars.githubusercontent.com/u/2430784?v=3","gravatar_id":"","url":"https://api.github.com/users/lsitu","html_url":"https://github.com/lsitu","followers_url":"https://api.github.com/users/lsitu/followers","following_url":"https://api.github.com/users/lsitu/following{/other_user}","gists_url":"https://api.github.com/users/lsitu/gists{/gist_id}","starred_url":"https://api.github.com/users/lsitu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsitu/subscriptions","organizations_url":"https://api.github.com/users/lsitu/orgs","repos_url":"https://api.github.com/users/lsitu/repos","events_url":"https://api.github.com/users/lsitu/events{/privacy}","received_events_url":"https://api.github.com/users/lsitu/received_events","type":"User","site_admin":false},"body":"https://jira.duraspace.org/browse/FCREPO-1244\r\n","created_at":"2014-12-06T01:02:31Z","updated_at":"2014-12-11T22:00:27Z","closed_at":"2014-12-11T21:39:14Z","merged_at":null,"merge_commit_sha":"59639dbf7ef6e98f6a4e5e4b115c7240baf9b64d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/673/commits","review_comments_url":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/673/comments","review_comment_url":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/comments/{number}","comments_url":"https://api.github.com/repos/fcrepo4/fcrepo4/issues/673/comments","statuses_url":"https://api.github.com/repos/fcrepo4/fcrepo4/statuses/efd3eab5322ebad0670551011be7ecba9ad81aa8","head":{"label":"lsitu:feature/namespace-fcr","ref":"feature/namespace-fcr","sha":"efd3eab5322ebad0670551011be7ecba9ad81aa8","user":{"login":"lsitu","id":2430784,"avatar_url":"https://avatars.githubusercontent.com/u/2430784?v=3","gravatar_id":"","url":"https://api.github.com/users/lsitu","html_url":"https://github.com/lsitu","followers_url":"https://api.github.com/users/lsitu/followers","following_url":"https://api.github.com/users/lsitu/following{/other_user}","gists_url":"https://api.github.com/users/lsitu/gists{/gist_id}","starred_url":"https://api.github.com/users/lsitu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsitu/subscriptions","organizations_url":"https://api.github.com/users/lsitu/orgs","repos_url":"https://api.github.com/users/lsitu/repos","events_url":"https://api.github.com/users/lsitu/events{/privacy}","received_events_url":"https://api.github.com/users/lsitu/received_events","type":"User","site_admin":false},"repo":{"id":18497364,"name":"fcrepo4","full_name":"lsitu/fcrepo4","owner":{"login":"lsitu","id":2430784,"avatar_url":"https://avatars.githubusercontent.com/u/2430784?v=3","gravatar_id":"","url":"https://api.github.com/users/lsitu","html_url":"https://github.com/lsitu","followers_url":"https://api.github.com/users/lsitu/followers","following_url":"https://api.github.com/users/lsitu/following{/other_user}","gists_url":"https://api.github.com/users/lsitu/gists{/gist_id}","starred_url":"https://api.github.com/users/lsitu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsitu/subscriptions","organizations_url":"https://api.github.com/users/lsitu/orgs","repos_url":"https://api.github.com/users/lsitu/repos","events_url":"https://api.github.com/users/lsitu/events{/privacy}","received_events_url":"https://api.github.com/users/lsitu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lsitu/fcrepo4","description":"Fedora 4: \"Changing everything, two weeks at a time\"","fork":true,"url":"https://api.github.com/repos/lsitu/fcrepo4","forks_url":"https://api.github.com/repos/lsitu/fcrepo4/forks","keys_url":"https://api.github.com/repos/lsitu/fcrepo4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsitu/fcrepo4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsitu/fcrepo4/teams","hooks_url":"https://api.github.com/repos/lsitu/fcrepo4/hooks","issue_events_url":"https://api.github.com/repos/lsitu/fcrepo4/issues/events{/number}","events_url":"https://api.github.com/repos/lsitu/fcrepo4/events","assignees_url":"https://api.github.com/repos/lsitu/fcrepo4/assignees{/user}","branches_url":"https://api.github.com/repos/lsitu/fcrepo4/branches{/branch}","tags_url":"https://api.github.com/repos/lsitu/fcrepo4/tags","blobs_url":"https://api.github.com/repos/lsitu/fcrepo4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsitu/fcrepo4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsitu/fcrepo4/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsitu/fcrepo4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsitu/fcrepo4/statuses/{sha}","languages_url":"https://api.github.com/repos/lsitu/fcrepo4/languages","stargazers_url":"https://api.github.com/repos/lsitu/fcrepo4/stargazers","contributors_url":"https://api.github.com/repos/lsitu/fcrepo4/contributors","subscribers_url":"https://api.github.com/repos/lsitu/fcrepo4/subscribers","subscription_url":"https://api.github.com/repos/lsitu/fcrepo4/subscription","commits_url":"https://api.github.com/repos/lsitu/fcrepo4/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsitu/fcrepo4/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsitu/fcrepo4/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsitu/fcrepo4/issues/comments/{number}","contents_url":"https://api.github.com/repos/lsitu/fcrepo4/contents/{+path}","compare_url":"https://api.github.com/repos/lsitu/fcrepo4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsitu/fcrepo4/merges","archive_url":"https://api.github.com/repos/lsitu/fcrepo4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsitu/fcrepo4/downloads","issues_url":"https://api.github.com/repos/lsitu/fcrepo4/issues{/number}","pulls_url":"https://api.github.com/repos/lsitu/fcrepo4/pulls{/number}","milestones_url":"https://api.github.com/repos/lsitu/fcrepo4/milestones{/number}","notifications_url":"https://api.github.com/repos/lsitu/fcrepo4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsitu/fcrepo4/labels{/name}","releases_url":"https://api.github.com/repos/lsitu/fcrepo4/releases{/id}","created_at":"2014-04-06T19:27:16Z","updated_at":"2014-12-05T00:14:18Z","pushed_at":"2014-12-11T20:48:11Z","git_url":"git://github.com/lsitu/fcrepo4.git","ssh_url":"git@github.com:lsitu/fcrepo4.git","clone_url":"https://github.com/lsitu/fcrepo4.git","svn_url":"https://github.com/lsitu/fcrepo4","homepage":"http://futures.github.com/fcrepo4/","size":47478,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"fcrepo4:master","ref":"master","sha":"ef5cc864705a5ba9d8848dd446cbb7d8b227e015","user":{"login":"fcrepo4","id":3057565,"avatar_url":"https://avatars.githubusercontent.com/u/3057565?v=3","gravatar_id":"","url":"https://api.github.com/users/fcrepo4","html_url":"https://github.com/fcrepo4","followers_url":"https://api.github.com/users/fcrepo4/followers","following_url":"https://api.github.com/users/fcrepo4/following{/other_user}","gists_url":"https://api.github.com/users/fcrepo4/gists{/gist_id}","starred_url":"https://api.github.com/users/fcrepo4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fcrepo4/subscriptions","organizations_url":"https://api.github.com/users/fcrepo4/orgs","repos_url":"https://api.github.com/users/fcrepo4/repos","events_url":"https://api.github.com/users/fcrepo4/events{/privacy}","received_events_url":"https://api.github.com/users/fcrepo4/received_events","type":"Organization","site_admin":false},"repo":{"id":7992797,"name":"fcrepo4","full_name":"fcrepo4/fcrepo4","owner":{"login":"fcrepo4","id":3057565,"avatar_url":"https://avatars.githubusercontent.com/u/3057565?v=3","gravatar_id":"","url":"https://api.github.com/users/fcrepo4","html_url":"https://github.com/fcrepo4","followers_url":"https://api.github.com/users/fcrepo4/followers","following_url":"https://api.github.com/users/fcrepo4/following{/other_user}","gists_url":"https://api.github.com/users/fcrepo4/gists{/gist_id}","starred_url":"https://api.github.com/users/fcrepo4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fcrepo4/subscriptions","organizations_url":"https://api.github.com/users/fcrepo4/orgs","repos_url":"https://api.github.com/users/fcrepo4/repos","events_url":"https://api.github.com/users/fcrepo4/events{/privacy}","received_events_url":"https://api.github.com/users/fcrepo4/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fcrepo4/fcrepo4","description":"Fedora 4","fork":false,"url":"https://api.github.com/repos/fcrepo4/fcrepo4","forks_url":"https://api.github.com/repos/fcrepo4/fcrepo4/forks","keys_url":"https://api.github.com/repos/fcrepo4/fcrepo4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fcrepo4/fcrepo4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fcrepo4/fcrepo4/teams","hooks_url":"https://api.github.com/repos/fcrepo4/fcrepo4/hooks","issue_events_url":"https://api.github.com/repos/fcrepo4/fcrepo4/issues/events{/number}","events_url":"https://api.github.com/repos/fcrepo4/fcrepo4/events","assignees_url":"https://api.github.com/repos/fcrepo4/fcrepo4/assignees{/user}","branches_url":"https://api.github.com/repos/fcrepo4/fcrepo4/branches{/branch}","tags_url":"https://api.github.com/repos/fcrepo4/fcrepo4/tags","blobs_url":"https://api.github.com/repos/fcrepo4/fcrepo4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fcrepo4/fcrepo4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fcrepo4/fcrepo4/git/refs{/sha}","trees_url":"https://api.github.com/repos/fcrepo4/fcrepo4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fcrepo4/fcrepo4/statuses/{sha}","languages_url":"https://api.github.com/repos/fcrepo4/fcrepo4/languages","stargazers_url":"https://api.github.com/repos/fcrepo4/fcrepo4/stargazers","contributors_url":"https://api.github.com/repos/fcrepo4/fcrepo4/contributors","subscribers_url":"https://api.github.com/repos/fcrepo4/fcrepo4/subscribers","subscription_url":"https://api.github.com/repos/fcrepo4/fcrepo4/subscription","commits_url":"https://api.github.com/repos/fcrepo4/fcrepo4/commits{/sha}","git_commits_url":"https://api.github.com/repos/fcrepo4/fcrepo4/git/commits{/sha}","comments_url":"https://api.github.com/repos/fcrepo4/fcrepo4/comments{/number}","issue_comment_url":"https://api.github.com/repos/fcrepo4/fcrepo4/issues/comments/{number}","contents_url":"https://api.github.com/repos/fcrepo4/fcrepo4/contents/{+path}","compare_url":"https://api.github.com/repos/fcrepo4/fcrepo4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fcrepo4/fcrepo4/merges","archive_url":"https://api.github.com/repos/fcrepo4/fcrepo4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fcrepo4/fcrepo4/downloads","issues_url":"https://api.github.com/repos/fcrepo4/fcrepo4/issues{/number}","pulls_url":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls{/number}","milestones_url":"https://api.github.com/repos/fcrepo4/fcrepo4/milestones{/number}","notifications_url":"https://api.github.com/repos/fcrepo4/fcrepo4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fcrepo4/fcrepo4/labels{/name}","releases_url":"https://api.github.com/repos/fcrepo4/fcrepo4/releases{/id}","created_at":"2013-02-03T16:18:55Z","updated_at":"2014-12-11T21:38:46Z","pushed_at":"2014-12-11T21:38:46Z","git_url":"git://github.com/fcrepo4/fcrepo4.git","ssh_url":"git@github.com:fcrepo4/fcrepo4.git","clone_url":"https://github.com/fcrepo4/fcrepo4.git","svn_url":"https://github.com/fcrepo4/fcrepo4","homepage":"http://github.com/fcrepo4/fcrepo4","size":126713,"stargazers_count":38,"watchers_count":38,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":57,"mirror_url":null,"open_issues_count":38,"forks":57,"open_issues":38,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/673"},"html":{"href":"https://github.com/fcrepo4/fcrepo4/pull/673"},"issue":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/issues/673"},"comments":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/issues/673/comments"},"review_comments":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/673/comments"},"review_comment":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/673/commits"},"statuses":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/statuses/efd3eab5322ebad0670551011be7ecba9ad81aa8"}}}}