GitHub PullRequestReviewCommentEvent at 2014-02-03 23:18:31
Repository: uPortal
Actor: apetro
Payload: {"comment":{"url":"https://api.github.com/repos/Jasig/uPortal/pulls/comments/9404552","id":9404552,"diff_hunk":"@@ -294,6 +294,9 @@\n       <xsl:variable name=\"editable\">\n           <xsl:if test=\"parameter[@name='editable'] and parameter[@name='editable']/@value = 'true'\">true</xsl:if>\n       </xsl:variable>\n+      <xsl:variable name=\"configurable\">","path":"uportal-war/src/main/resources/layout/theme/respondr/content.xsl","position":4,"original_position":4,"commit_id":"135648e1956b44fc5184dd94e27359bf6d36381a","original_commit_id":"135648e1956b44fc5184dd94e27359bf6d36381a","user":{"login":"apetro","id":952283,"avatar_url":"https://gravatar.com/avatar/6b678c1cc265b5b91863a16cc48b2287?d=https%3A%2F%2Fidenticons.github.com%2Fba94864e28bb20cc8d853b6044126470.png&r=x","gravatar_id":"6b678c1cc265b5b91863a16cc48b2287","url":"https://api.github.com/users/apetro","html_url":"https://github.com/apetro","followers_url":"https://api.github.com/users/apetro/followers","following_url":"https://api.github.com/users/apetro/following{/other_user}","gists_url":"https://api.github.com/users/apetro/gists{/gist_id}","starred_url":"https://api.github.com/users/apetro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apetro/subscriptions","organizations_url":"https://api.github.com/users/apetro/orgs","repos_url":"https://api.github.com/users/apetro/repos","events_url":"https://api.github.com/users/apetro/events{/privacy}","received_events_url":"https://api.github.com/users/apetro/received_events","type":"User","site_admin":false},"body":"Would it be clearer to name this variable something other than exactly the name of the parameter (`configurable`), as in, say, `configurableByThisUser`, to differentiate the variable and its semantics from the parameter and its semantics?  The below test would then be `<xsl:if test=\"$configurableByThisUser='true'\">`.","created_at":"2014-02-03T23:18:31Z","updated_at":"2014-02-03T23:18:31Z","html_url":"https://github.com/Jasig/uPortal/pull/218#discussion_r9404552","pull_request_url":"https://api.github.com/repos/Jasig/uPortal/pulls/218","_links":{"self":{"href":"https://api.github.com/repos/Jasig/uPortal/pulls/comments/9404552"},"html":{"href":"https://github.com/Jasig/uPortal/pull/218#discussion_r9404552"},"pull_request":{"href":"https://api.github.com/repos/Jasig/uPortal/pulls/218"}}}}