GitHub PullRequestReviewCommentEvent at 2014-10-02 01:41:47
Repository: trunk8
Actor: rviscomi
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/rviscomi/trunk8/pulls/comments/18319063","id":18319063,"diff_hunk":"@@ -226,8 +226,18 @@\n \t\t\t\tif (!data) {\n \t\t\t\t\t$this.data('trunk8', (data = new trunk8(this)));\n \t\t\t\t}\n-\t\t\t\t\n+\t\t\t\t// add data-trunk8-* support\n+\t\t\t\tvar elAttr = {};\n+\t\t\t\tvar attributes = $this[0].attributes;\n+\t\t\t\tif(attributes) {\n+\t\t\t\t\t$.each(attributes,function(index,atr){","path":"trunk8.js","position":36,"original_position":36,"commit_id":"756d171832a655400092ddc6a2e9816cb586ccca","original_commit_id":"756d171832a655400092ddc6a2e9816cb586ccca","user":{"login":"rviscomi","id":1120896,"avatar_url":"https://avatars.githubusercontent.com/u/1120896?v=2","gravatar_id":"","url":"https://api.github.com/users/rviscomi","html_url":"https://github.com/rviscomi","followers_url":"https://api.github.com/users/rviscomi/followers","following_url":"https://api.github.com/users/rviscomi/following{/other_user}","gists_url":"https://api.github.com/users/rviscomi/gists{/gist_id}","starred_url":"https://api.github.com/users/rviscomi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rviscomi/subscriptions","organizations_url":"https://api.github.com/users/rviscomi/orgs","repos_url":"https://api.github.com/users/rviscomi/repos","events_url":"https://api.github.com/users/rviscomi/events{/privacy}","received_events_url":"https://api.github.com/users/rviscomi/received_events","type":"User","site_admin":false},"body":"Space before function, atr, and {.\r\n\r\nRename \"atr\" to \"attribute\".","created_at":"2014-10-02T01:41:47Z","updated_at":"2014-10-02T01:41:47Z","html_url":"https://github.com/rviscomi/trunk8/pull/44#discussion_r18319063","pull_request_url":"https://api.github.com/repos/rviscomi/trunk8/pulls/44","_links":{"self":{"href":"https://api.github.com/repos/rviscomi/trunk8/pulls/comments/18319063"},"html":{"href":"https://github.com/rviscomi/trunk8/pull/44#discussion_r18319063"},"pull_request":{"href":"https://api.github.com/repos/rviscomi/trunk8/pulls/44"}}},"pull_request":{"url":"https://api.github.com/repos/rviscomi/trunk8/pulls/44","id":15226477,"html_url":"https://github.com/rviscomi/trunk8/pull/44","diff_url":"https://github.com/rviscomi/trunk8/pull/44.diff","patch_url":"https://github.com/rviscomi/trunk8/pull/44.patch","issue_url":"https://api.github.com/repos/rviscomi/trunk8/issues/44","number":44,"state":"open","locked":false,"title":"add data-trunk8-* support","user":{"login":"waitingmyself","id":11735,"avatar_url":"https://avatars.githubusercontent.com/u/11735?v=2","gravatar_id":"","url":"https://api.github.com/users/waitingmyself","html_url":"https://github.com/waitingmyself","followers_url":"https://api.github.com/users/waitingmyself/followers","following_url":"https://api.github.com/users/waitingmyself/following{/other_user}","gists_url":"https://api.github.com/users/waitingmyself/gists{/gist_id}","starred_url":"https://api.github.com/users/waitingmyself/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waitingmyself/subscriptions","organizations_url":"https://api.github.com/users/waitingmyself/orgs","repos_url":"https://api.github.com/users/waitingmyself/repos","events_url":"https://api.github.com/users/waitingmyself/events{/privacy}","received_events_url":"https://api.github.com/users/waitingmyself/received_events","type":"User","site_admin":false},"body":"add attribute  data-trunk8-* to each element for special settings\r\n@rviscomi sorry for my english,i am uncertain if i understand your words\r\n<pre>It should not take precedence over the options object in init.</pre>\r\nthe order of the config is :\r\ntrunk8.defaults -- trunk8 config -- element attribute\r\n and the next will override the last","created_at":"2014-04-28T08:53:32Z","updated_at":"2014-10-02T01:41:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"68879389dc07b3498c70b7e5609fc464548e7e57","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rviscomi/trunk8/pulls/44/commits","review_comments_url":"https://api.github.com/repos/rviscomi/trunk8/pulls/44/comments","review_comment_url":"https://api.github.com/repos/rviscomi/trunk8/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rviscomi/trunk8/issues/44/comments","statuses_url":"https://api.github.com/repos/rviscomi/trunk8/statuses/756d171832a655400092ddc6a2e9816cb586ccca","head":{"label":"waitingmyself:master","ref":"master","sha":"756d171832a655400092ddc6a2e9816cb586ccca","user":{"login":"waitingmyself","id":11735,"avatar_url":"https://avatars.githubusercontent.com/u/11735?v=2","gravatar_id":"","url":"https://api.github.com/users/waitingmyself","html_url":"https://github.com/waitingmyself","followers_url":"https://api.github.com/users/waitingmyself/followers","following_url":"https://api.github.com/users/waitingmyself/following{/other_user}","gists_url":"https://api.github.com/users/waitingmyself/gists{/gist_id}","starred_url":"https://api.github.com/users/waitingmyself/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waitingmyself/subscriptions","organizations_url":"https://api.github.com/users/waitingmyself/orgs","repos_url":"https://api.github.com/users/waitingmyself/repos","events_url":"https://api.github.com/users/waitingmyself/events{/privacy}","received_events_url":"https://api.github.com/users/waitingmyself/received_events","type":"User","site_admin":false},"repo":{"id":19232057,"name":"trunk8","full_name":"waitingmyself/trunk8","owner":{"login":"waitingmyself","id":11735,"avatar_url":"https://avatars.githubusercontent.com/u/11735?v=2","gravatar_id":"","url":"https://api.github.com/users/waitingmyself","html_url":"https://github.com/waitingmyself","followers_url":"https://api.github.com/users/waitingmyself/followers","following_url":"https://api.github.com/users/waitingmyself/following{/other_user}","gists_url":"https://api.github.com/users/waitingmyself/gists{/gist_id}","starred_url":"https://api.github.com/users/waitingmyself/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waitingmyself/subscriptions","organizations_url":"https://api.github.com/users/waitingmyself/orgs","repos_url":"https://api.github.com/users/waitingmyself/repos","events_url":"https://api.github.com/users/waitingmyself/events{/privacy}","received_events_url":"https://api.github.com/users/waitingmyself/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/waitingmyself/trunk8","description":"jQuery Truncation Plugin","fork":true,"url":"https://api.github.com/repos/waitingmyself/trunk8","forks_url":"https://api.github.com/repos/waitingmyself/trunk8/forks","keys_url":"https://api.github.com/repos/waitingmyself/trunk8/keys{/key_id}","collaborators_url":"https://api.github.com/repos/waitingmyself/trunk8/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/waitingmyself/trunk8/teams","hooks_url":"https://api.github.com/repos/waitingmyself/trunk8/hooks","issue_events_url":"https://api.github.com/repos/waitingmyself/trunk8/issues/events{/number}","events_url":"https://api.github.com/repos/waitingmyself/trunk8/events","assignees_url":"https://api.github.com/repos/waitingmyself/trunk8/assignees{/user}","branches_url":"https://api.github.com/repos/waitingmyself/trunk8/branches{/branch}","tags_url":"https://api.github.com/repos/waitingmyself/trunk8/tags","blobs_url":"https://api.github.com/repos/waitingmyself/trunk8/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/waitingmyself/trunk8/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/waitingmyself/trunk8/git/refs{/sha}","trees_url":"https://api.github.com/repos/waitingmyself/trunk8/git/trees{/sha}","statuses_url":"https://api.github.com/repos/waitingmyself/trunk8/statuses/{sha}","languages_url":"https://api.github.com/repos/waitingmyself/trunk8/languages","stargazers_url":"https://api.github.com/repos/waitingmyself/trunk8/stargazers","contributors_url":"https://api.github.com/repos/waitingmyself/trunk8/contributors","subscribers_url":"https://api.github.com/repos/waitingmyself/trunk8/subscribers","subscription_url":"https://api.github.com/repos/waitingmyself/trunk8/subscription","commits_url":"https://api.github.com/repos/waitingmyself/trunk8/commits{/sha}","git_commits_url":"https://api.github.com/repos/waitingmyself/trunk8/git/commits{/sha}","comments_url":"https://api.github.com/repos/waitingmyself/trunk8/comments{/number}","issue_comment_url":"https://api.github.com/repos/waitingmyself/trunk8/issues/comments/{number}","contents_url":"https://api.github.com/repos/waitingmyself/trunk8/contents/{+path}","compare_url":"https://api.github.com/repos/waitingmyself/trunk8/compare/{base}...{head}","merges_url":"https://api.github.com/repos/waitingmyself/trunk8/merges","archive_url":"https://api.github.com/repos/waitingmyself/trunk8/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/waitingmyself/trunk8/downloads","issues_url":"https://api.github.com/repos/waitingmyself/trunk8/issues{/number}","pulls_url":"https://api.github.com/repos/waitingmyself/trunk8/pulls{/number}","milestones_url":"https://api.github.com/repos/waitingmyself/trunk8/milestones{/number}","notifications_url":"https://api.github.com/repos/waitingmyself/trunk8/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/waitingmyself/trunk8/labels{/name}","releases_url":"https://api.github.com/repos/waitingmyself/trunk8/releases{/id}","created_at":"2014-04-28T08:33:10Z","updated_at":"2014-04-28T08:53:32Z","pushed_at":"2014-04-28T08:36:15Z","git_url":"git://github.com/waitingmyself/trunk8.git","ssh_url":"git@github.com:waitingmyself/trunk8.git","clone_url":"https://github.com/waitingmyself/trunk8.git","svn_url":"https://github.com/waitingmyself/trunk8","homepage":null,"size":170,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rviscomi:master","ref":"master","sha":"386b8614283156abc47c4547979a89c7aba91a2c","user":{"login":"rviscomi","id":1120896,"avatar_url":"https://avatars.githubusercontent.com/u/1120896?v=2","gravatar_id":"","url":"https://api.github.com/users/rviscomi","html_url":"https://github.com/rviscomi","followers_url":"https://api.github.com/users/rviscomi/followers","following_url":"https://api.github.com/users/rviscomi/following{/other_user}","gists_url":"https://api.github.com/users/rviscomi/gists{/gist_id}","starred_url":"https://api.github.com/users/rviscomi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rviscomi/subscriptions","organizations_url":"https://api.github.com/users/rviscomi/orgs","repos_url":"https://api.github.com/users/rviscomi/repos","events_url":"https://api.github.com/users/rviscomi/events{/privacy}","received_events_url":"https://api.github.com/users/rviscomi/received_events","type":"User","site_admin":false},"repo":{"id":4682570,"name":"trunk8","full_name":"rviscomi/trunk8","owner":{"login":"rviscomi","id":1120896,"avatar_url":"https://avatars.githubusercontent.com/u/1120896?v=2","gravatar_id":"","url":"https://api.github.com/users/rviscomi","html_url":"https://github.com/rviscomi","followers_url":"https://api.github.com/users/rviscomi/followers","following_url":"https://api.github.com/users/rviscomi/following{/other_user}","gists_url":"https://api.github.com/users/rviscomi/gists{/gist_id}","starred_url":"https://api.github.com/users/rviscomi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rviscomi/subscriptions","organizations_url":"https://api.github.com/users/rviscomi/orgs","repos_url":"https://api.github.com/users/rviscomi/repos","events_url":"https://api.github.com/users/rviscomi/events{/privacy}","received_events_url":"https://api.github.com/users/rviscomi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rviscomi/trunk8","description":"jQuery Truncation Plugin","fork":false,"url":"https://api.github.com/repos/rviscomi/trunk8","forks_url":"https://api.github.com/repos/rviscomi/trunk8/forks","keys_url":"https://api.github.com/repos/rviscomi/trunk8/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rviscomi/trunk8/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rviscomi/trunk8/teams","hooks_url":"https://api.github.com/repos/rviscomi/trunk8/hooks","issue_events_url":"https://api.github.com/repos/rviscomi/trunk8/issues/events{/number}","events_url":"https://api.github.com/repos/rviscomi/trunk8/events","assignees_url":"https://api.github.com/repos/rviscomi/trunk8/assignees{/user}","branches_url":"https://api.github.com/repos/rviscomi/trunk8/branches{/branch}","tags_url":"https://api.github.com/repos/rviscomi/trunk8/tags","blobs_url":"https://api.github.com/repos/rviscomi/trunk8/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rviscomi/trunk8/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rviscomi/trunk8/git/refs{/sha}","trees_url":"https://api.github.com/repos/rviscomi/trunk8/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rviscomi/trunk8/statuses/{sha}","languages_url":"https://api.github.com/repos/rviscomi/trunk8/languages","stargazers_url":"https://api.github.com/repos/rviscomi/trunk8/stargazers","contributors_url":"https://api.github.com/repos/rviscomi/trunk8/contributors","subscribers_url":"https://api.github.com/repos/rviscomi/trunk8/subscribers","subscription_url":"https://api.github.com/repos/rviscomi/trunk8/subscription","commits_url":"https://api.github.com/repos/rviscomi/trunk8/commits{/sha}","git_commits_url":"https://api.github.com/repos/rviscomi/trunk8/git/commits{/sha}","comments_url":"https://api.github.com/repos/rviscomi/trunk8/comments{/number}","issue_comment_url":"https://api.github.com/repos/rviscomi/trunk8/issues/comments/{number}","contents_url":"https://api.github.com/repos/rviscomi/trunk8/contents/{+path}","compare_url":"https://api.github.com/repos/rviscomi/trunk8/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rviscomi/trunk8/merges","archive_url":"https://api.github.com/repos/rviscomi/trunk8/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rviscomi/trunk8/downloads","issues_url":"https://api.github.com/repos/rviscomi/trunk8/issues{/number}","pulls_url":"https://api.github.com/repos/rviscomi/trunk8/pulls{/number}","milestones_url":"https://api.github.com/repos/rviscomi/trunk8/milestones{/number}","notifications_url":"https://api.github.com/repos/rviscomi/trunk8/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rviscomi/trunk8/labels{/name}","releases_url":"https://api.github.com/repos/rviscomi/trunk8/releases{/id}","created_at":"2012-06-16T05:25:05Z","updated_at":"2014-09-25T23:20:25Z","pushed_at":"2014-10-02T01:29:27Z","git_url":"git://github.com/rviscomi/trunk8.git","ssh_url":"git@github.com:rviscomi/trunk8.git","clone_url":"https://github.com/rviscomi/trunk8.git","svn_url":"https://github.com/rviscomi/trunk8","homepage":null,"size":281,"stargazers_count":593,"watchers_count":593,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":59,"mirror_url":null,"open_issues_count":22,"forks":59,"open_issues":22,"watchers":593,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rviscomi/trunk8/pulls/44"},"html":{"href":"https://github.com/rviscomi/trunk8/pull/44"},"issue":{"href":"https://api.github.com/repos/rviscomi/trunk8/issues/44"},"comments":{"href":"https://api.github.com/repos/rviscomi/trunk8/issues/44/comments"},"review_comments":{"href":"https://api.github.com/repos/rviscomi/trunk8/pulls/44/comments"},"review_comment":{"href":"https://api.github.com/repos/rviscomi/trunk8/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rviscomi/trunk8/pulls/44/commits"},"statuses":{"href":"https://api.github.com/repos/rviscomi/trunk8/statuses/756d171832a655400092ddc6a2e9816cb586ccca"}}}}