GitHub PullRequestEvent at 2014-01-17 21:52:51
Repository: ember-jj-abrams-resolver
Actor: rjackson
Payload: {"action":"opened","number":15,"pull_request":{"url":"https://api.github.com/repos/stefanpenner/ember-jj-abrams-resolver/pulls/15","id":11638801,"html_url":"https://github.com/stefanpenner/ember-jj-abrams-resolver/pull/15","diff_url":"https://github.com/stefanpenner/ember-jj-abrams-resolver/pull/15.diff","patch_url":"https://github.com/stefanpenner/ember-jj-abrams-resolver/pull/15.patch","issue_url":"https://github.com/stefanpenner/ember-jj-abrams-resolver/pull/15","number":15,"state":"open","title":"Allow 'some-type:main' modules to be looked up easier.","user":{"login":"rjackson","id":12637,"avatar_url":"https://gravatar.com/avatar/0dfd10ad198ae5a87640da046a77a90a?d=https%3A%2F%2Fidenticons.github.com%2Fca0226c1b273bb50a210ba4a8db4ce8c.png&r=x","gravatar_id":"0dfd10ad198ae5a87640da046a77a90a","url":"https://api.github.com/users/rjackson","html_url":"https://github.com/rjackson","followers_url":"https://api.github.com/users/rjackson/followers","following_url":"https://api.github.com/users/rjackson/following{/other_user}","gists_url":"https://api.github.com/users/rjackson/gists{/gist_id}","starred_url":"https://api.github.com/users/rjackson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjackson/subscriptions","organizations_url":"https://api.github.com/users/rjackson/orgs","repos_url":"https://api.github.com/users/rjackson/repos","events_url":"https://api.github.com/users/rjackson/events{/privacy}","received_events_url":"https://api.github.com/users/rjackson/received_events","type":"User","site_admin":false},"body":"This removes the need to define custom resolver methods for every type that\nalso has a `main` module.\n\nSpecifically, in Ember-land we have at least two of these (possibly more):\n\n* `adapter:main`\n* `router:main`\n\nPrior to this change you would have to add a `resolveRouter` method to the\nresolver. This instructs the resolver to update look for a module with the\n`prefix + type`, and falls back on the existing logic if it is not found.\n\n-----\n\nPlease note that this builds off of which has a test to ensure that `router:main` is found when registered as `appkit/router` (with `appkit` as the `modulePrefix`).","created_at":"2014-01-17T21:52:50Z","updated_at":"2014-01-17T21:52:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"27ec6b0aebcf8127eebfb4ab05a34309e8f22019","assignee":null,"milestone":null,"commits_url":"https://github.com/stefanpenner/ember-jj-abrams-resolver/pull/15/commits","review_comments_url":"https://github.com/stefanpenner/ember-jj-abrams-resolver/pull/15/comments","review_comment_url":"/repos/stefanpenner/ember-jj-abrams-resolver/pulls/comments/{number}","comments_url":"https://api.github.com/repos/stefanpenner/ember-jj-abrams-resolver/issues/15/comments","statuses_url":"https://api.github.com/repos/stefanpenner/ember-jj-abrams-resolver/statuses/2a7f8b8e40c0bcc7a1ae1f33dcc69b958c721b44","head":{"label":"rjackson:allow_main_modules_to_be_lookedup","ref":"allow_main_modules_to_be_lookedup","sha":"2a7f8b8e40c0bcc7a1ae1f33dcc69b958c721b44","user":{"login":"rjackson","id":12637,"avatar_url":"https://gravatar.com/avatar/0dfd10ad198ae5a87640da046a77a90a?d=https%3A%2F%2Fidenticons.github.com%2Fca0226c1b273bb50a210ba4a8db4ce8c.png&r=x","gravatar_id":"0dfd10ad198ae5a87640da046a77a90a","url":"https://api.github.com/users/rjackson","html_url":"https://github.com/rjackson","followers_url":"https://api.github.com/users/rjackson/followers","following_url":"https://api.github.com/users/rjackson/following{/other_user}","gists_url":"https://api.github.com/users/rjackson/gists{/gist_id}","starred_url":"https://api.github.com/users/rjackson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjackson/subscriptions","organizations_url":"https://api.github.com/users/rjackson/orgs","repos_url":"https://api.github.com/users/rjackson/repos","events_url":"https://api.github.com/users/rjackson/events{/privacy}","received_events_url":"https://api.github.com/users/rjackson/received_events","type":"User","site_admin":false},"repo":{"id":16006988,"name":"ember-jj-abrams-resolver","full_name":"rjackson/ember-jj-abrams-resolver","owner":{"login":"rjackson","id":12637,"avatar_url":"https://gravatar.com/avatar/0dfd10ad198ae5a87640da046a77a90a?d=https%3A%2F%2Fidenticons.github.com%2Fca0226c1b273bb50a210ba4a8db4ce8c.png&r=x","gravatar_id":"0dfd10ad198ae5a87640da046a77a90a","url":"https://api.github.com/users/rjackson","html_url":"https://github.com/rjackson","followers_url":"https://api.github.com/users/rjackson/followers","following_url":"https://api.github.com/users/rjackson/following{/other_user}","gists_url":"https://api.github.com/users/rjackson/gists{/gist_id}","starred_url":"https://api.github.com/users/rjackson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjackson/subscriptions","organizations_url":"https://api.github.com/users/rjackson/orgs","repos_url":"https://api.github.com/users/rjackson/repos","events_url":"https://api.github.com/users/rjackson/events{/privacy}","received_events_url":"https://api.github.com/users/rjackson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rjackson/ember-jj-abrams-resolver","description":"","fork":true,"url":"https://api.github.com/repos/rjackson/ember-jj-abrams-resolver","forks_url":"https://api.github.com/repos/rjackson/ember-jj-abrams-resolver/forks","keys_url":"https://api.github.com/repos/rjackson/ember-jj-abrams-resolver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rjackson/ember-jj-abrams-resolver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rjackson/ember-jj-abrams-resolver/teams","hooks_url":"https://api.github.com/repos/rjackson/ember-jj-abrams-resolver/hooks","issue_events_url":"https://api.github.com/repos/rjackson/ember-jj-abrams-resolver/issues/events{/number}","events_url":"https://api.github.com/repos/rjackson/ember-jj-abrams-resolver/events","assignees_url":"https://api.github.com/repos/rjackson/ember-jj-abrams-resolver/assignees{/user}","branches_url":"https://api.github.com/repos/rjackson/ember-jj-abrams-resolver/branches{/branch}","tags_url":"https://api.github.com/repos/rjackson/ember-jj-abrams-resolver/tags","blobs_url":"https://api.github.com/repos/rjackson/ember-jj-abrams-resolver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rjackson/ember-jj-abrams-resolver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rjackson/ember-jj-abrams-resolver/git/refs{/sha}","trees_url":"https://api.github.com/repos/rjackson/ember-jj-abrams-resolver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rjackson/ember-jj-abrams-resolver/statuses/{sha}","languages_url":"https://api.github.com/repos/rjackson/ember-jj-abrams-resolver/languages","stargazers_url":"https://api.github.com/repos/rjackson/ember-jj-abrams-resolver/stargazers","contributors_url":"https://api.github.com/repos/rjackson/ember-jj-abrams-resolver/contributors","subscribers_url":"https://api.github.com/repos/rjackson/ember-jj-abrams-resolver/subscribers","subscription_url":"https://api.github.com/repos/rjackson/ember-jj-abrams-resolver/subscription","commits_url":"https://api.github.com/repos/rjackson/ember-jj-abrams-resolver/commits{/sha}","git_commits_url":"https://api.github.com/repos/rjackson/ember-jj-abrams-resolver/git/commits{/sha}","comments_url":"https://api.github.com/repos/rjackson/ember-jj-abrams-resolver/comments{/number}","issue_comment_url":"https://api.github.com/repos/rjackson/ember-jj-abrams-resolver/issues/comments/{number}","contents_url":"https://api.github.com/repos/rjackson/ember-jj-abrams-resolver/contents/{+path}","compare_url":"https://api.github.com/repos/rjackson/ember-jj-abrams-resolver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rjackson/ember-jj-abrams-resolver/merges","archive_url":"https://api.github.com/repos/rjackson/ember-jj-abrams-resolver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rjackson/ember-jj-abrams-resolver/downloads","issues_url":"https://api.github.com/repos/rjackson/ember-jj-abrams-resolver/issues{/number}","pulls_url":"https://api.github.com/repos/rjackson/ember-jj-abrams-resolver/pulls{/number}","milestones_url":"https://api.github.com/repos/rjackson/ember-jj-abrams-resolver/milestones{/number}","notifications_url":"https://api.github.com/repos/rjackson/ember-jj-abrams-resolver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rjackson/ember-jj-abrams-resolver/labels{/name}","releases_url":"https://api.github.com/repos/rjackson/ember-jj-abrams-resolver/releases{/id}","created_at":"2014-01-17T17:45:27Z","updated_at":"2014-01-17T21:52:50Z","pushed_at":"2014-01-17T21:50:53Z","git_url":"git://github.com/rjackson/ember-jj-abrams-resolver.git","ssh_url":"git@github.com:rjackson/ember-jj-abrams-resolver.git","clone_url":"https://github.com/rjackson/ember-jj-abrams-resolver.git","svn_url":"https://github.com/rjackson/ember-jj-abrams-resolver","homepage":null,"size":311,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"stefanpenner:master","ref":"master","sha":"368a2a1aa817dc12857a40c460746cf5eb1921d2","user":{"login":"stefanpenner","id":1377,"avatar_url":"https://gravatar.com/avatar/8ccebbc3d28f903d5c214efd3447ac71?d=https%3A%2F%2Fidenticons.github.com%2Ff52378e14237225a6f6c7d802dc6abbd.png&r=x","gravatar_id":"8ccebbc3d28f903d5c214efd3447ac71","url":"https://api.github.com/users/stefanpenner","html_url":"https://github.com/stefanpenner","followers_url":"https://api.github.com/users/stefanpenner/followers","following_url":"https://api.github.com/users/stefanpenner/following{/other_user}","gists_url":"https://api.github.com/users/stefanpenner/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanpenner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanpenner/subscriptions","organizations_url":"https://api.github.com/users/stefanpenner/orgs","repos_url":"https://api.github.com/users/stefanpenner/repos","events_url":"https://api.github.com/users/stefanpenner/events{/privacy}","received_events_url":"https://api.github.com/users/stefanpenner/received_events","type":"User","site_admin":false},"repo":{"id":13989852,"name":"ember-jj-abrams-resolver","full_name":"stefanpenner/ember-jj-abrams-resolver","owner":{"login":"stefanpenner","id":1377,"avatar_url":"https://gravatar.com/avatar/8ccebbc3d28f903d5c214efd3447ac71?d=https%3A%2F%2Fidenticons.github.com%2Ff52378e14237225a6f6c7d802dc6abbd.png&r=x","gravatar_id":"8ccebbc3d28f903d5c214efd3447ac71","url":"https://api.github.com/users/stefanpenner","html_url":"https://github.com/stefanpenner","followers_url":"https://api.github.com/users/stefanpenner/followers","following_url":"https://api.github.com/users/stefanpenner/following{/other_user}","gists_url":"https://api.github.com/users/stefanpenner/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanpenner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanpenner/subscriptions","organizations_url":"https://api.github.com/users/stefanpenner/orgs","repos_url":"https://api.github.com/users/stefanpenner/repos","events_url":"https://api.github.com/users/stefanpenner/events{/privacy}","received_events_url":"https://api.github.com/users/stefanpenner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stefanpenner/ember-jj-abrams-resolver","description":"","fork":false,"url":"https://api.github.com/repos/stefanpenner/ember-jj-abrams-resolver","forks_url":"https://api.github.com/repos/stefanpenner/ember-jj-abrams-resolver/forks","keys_url":"https://api.github.com/repos/stefanpenner/ember-jj-abrams-resolver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stefanpenner/ember-jj-abrams-resolver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stefanpenner/ember-jj-abrams-resolver/teams","hooks_url":"https://api.github.com/repos/stefanpenner/ember-jj-abrams-resolver/hooks","issue_events_url":"https://api.github.com/repos/stefanpenner/ember-jj-abrams-resolver/issues/events{/number}","events_url":"https://api.github.com/repos/stefanpenner/ember-jj-abrams-resolver/events","assignees_url":"https://api.github.com/repos/stefanpenner/ember-jj-abrams-resolver/assignees{/user}","branches_url":"https://api.github.com/repos/stefanpenner/ember-jj-abrams-resolver/branches{/branch}","tags_url":"https://api.github.com/repos/stefanpenner/ember-jj-abrams-resolver/tags","blobs_url":"https://api.github.com/repos/stefanpenner/ember-jj-abrams-resolver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stefanpenner/ember-jj-abrams-resolver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stefanpenner/ember-jj-abrams-resolver/git/refs{/sha}","trees_url":"https://api.github.com/repos/stefanpenner/ember-jj-abrams-resolver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stefanpenner/ember-jj-abrams-resolver/statuses/{sha}","languages_url":"https://api.github.com/repos/stefanpenner/ember-jj-abrams-resolver/languages","stargazers_url":"https://api.github.com/repos/stefanpenner/ember-jj-abrams-resolver/stargazers","contributors_url":"https://api.github.com/repos/stefanpenner/ember-jj-abrams-resolver/contributors","subscribers_url":"https://api.github.com/repos/stefanpenner/ember-jj-abrams-resolver/subscribers","subscription_url":"https://api.github.com/repos/stefanpenner/ember-jj-abrams-resolver/subscription","commits_url":"https://api.github.com/repos/stefanpenner/ember-jj-abrams-resolver/commits{/sha}","git_commits_url":"https://api.github.com/repos/stefanpenner/ember-jj-abrams-resolver/git/commits{/sha}","comments_url":"https://api.github.com/repos/stefanpenner/ember-jj-abrams-resolver/comments{/number}","issue_comment_url":"https://api.github.com/repos/stefanpenner/ember-jj-abrams-resolver/issues/comments/{number}","contents_url":"https://api.github.com/repos/stefanpenner/ember-jj-abrams-resolver/contents/{+path}","compare_url":"https://api.github.com/repos/stefanpenner/ember-jj-abrams-resolver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stefanpenner/ember-jj-abrams-resolver/merges","archive_url":"https://api.github.com/repos/stefanpenner/ember-jj-abrams-resolver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stefanpenner/ember-jj-abrams-resolver/downloads","issues_url":"https://api.github.com/repos/stefanpenner/ember-jj-abrams-resolver/issues{/number}","pulls_url":"https://api.github.com/repos/stefanpenner/ember-jj-abrams-resolver/pulls{/number}","milestones_url":"https://api.github.com/repos/stefanpenner/ember-jj-abrams-resolver/milestones{/number}","notifications_url":"https://api.github.com/repos/stefanpenner/ember-jj-abrams-resolver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stefanpenner/ember-jj-abrams-resolver/labels{/name}","releases_url":"https://api.github.com/repos/stefanpenner/ember-jj-abrams-resolver/releases{/id}","created_at":"2013-10-30T14:57:20Z","updated_at":"2014-01-12T11:13:35Z","pushed_at":"2014-01-07T00:10:41Z","git_url":"git://github.com/stefanpenner/ember-jj-abrams-resolver.git","ssh_url":"git@github.com:stefanpenner/ember-jj-abrams-resolver.git","clone_url":"https://github.com/stefanpenner/ember-jj-abrams-resolver.git","svn_url":"https://github.com/stefanpenner/ember-jj-abrams-resolver","homepage":null,"size":311,"stargazers_count":12,"watchers_count":12,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":11,"mirror_url":null,"open_issues_count":6,"forks":11,"open_issues":6,"watchers":12,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stefanpenner/ember-jj-abrams-resolver/pulls/15"},"html":{"href":"https://github.com/stefanpenner/ember-jj-abrams-resolver/pull/15"},"issue":{"href":"https://api.github.com/repos/stefanpenner/ember-jj-abrams-resolver/issues/15"},"comments":{"href":"https://api.github.com/repos/stefanpenner/ember-jj-abrams-resolver/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/stefanpenner/ember-jj-abrams-resolver/pulls/15/comments"},"statuses":{"href":"https://api.github.com/repos/stefanpenner/ember-jj-abrams-resolver/statuses/2a7f8b8e40c0bcc7a1ae1f33dcc69b958c721b44"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":176,"deletions":103,"changed_files":9}}