GitHub PullRequestReviewCommentEvent at 2014-12-11 19:18:47
Repository: spree
Actor: houndci
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/spree/spree/pulls/comments/21700620","id":21700620,"diff_hunk":"@@ -54,33 +54,33 @@ module Spree\n \n       it 'cannot list of stock items' do\n         api_get :index, stock_location_id: stock_location.to_param\n-        json_response['stock_items'].first.should have_attributes(attributes)\n-        json_response['stock_items'].first['variant']['sku'].should include 'SKU'\n+        expect(json_response['stock_items'].first).to have_attributes(attributes)","path":"api/spec/controllers/spree/api/stock_items_controller_spec.rb","position":51,"original_position":51,"commit_id":"a53564b72ddf56c5bac0fd8a66fe470578234762","original_commit_id":"a53564b72ddf56c5bac0fd8a66fe470578234762","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Line is too long. [81/80]<br>Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.","created_at":"2014-12-11T19:18:47Z","updated_at":"2014-12-11T19:18:47Z","html_url":"https://github.com/spree/spree/pull/5760#discussion_r21700620","pull_request_url":"https://api.github.com/repos/spree/spree/pulls/5760","_links":{"self":{"href":"https://api.github.com/repos/spree/spree/pulls/comments/21700620"},"html":{"href":"https://github.com/spree/spree/pull/5760#discussion_r21700620"},"pull_request":{"href":"https://api.github.com/repos/spree/spree/pulls/5760"}}},"pull_request":{"url":"https://api.github.com/repos/spree/spree/pulls/5760","id":25924328,"html_url":"https://github.com/spree/spree/pull/5760","diff_url":"https://github.com/spree/spree/pull/5760.diff","patch_url":"https://github.com/spree/spree/pull/5760.patch","issue_url":"https://api.github.com/repos/spree/spree/issues/5760","number":5760,"state":"closed","locked":false,"title":"Exchange variant eligibility patch","user":{"login":"adaddeo","id":1143517,"avatar_url":"https://avatars.githubusercontent.com/u/1143517?v=3","gravatar_id":"","url":"https://api.github.com/users/adaddeo","html_url":"https://github.com/adaddeo","followers_url":"https://api.github.com/users/adaddeo/followers","following_url":"https://api.github.com/users/adaddeo/following{/other_user}","gists_url":"https://api.github.com/users/adaddeo/gists{/gist_id}","starred_url":"https://api.github.com/users/adaddeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adaddeo/subscriptions","organizations_url":"https://api.github.com/users/adaddeo/orgs","repos_url":"https://api.github.com/users/adaddeo/repos","events_url":"https://api.github.com/users/adaddeo/events{/privacy}","received_events_url":"https://api.github.com/users/adaddeo/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-12-11T19:16:56Z","updated_at":"2014-12-11T19:18:47Z","closed_at":"2014-12-11T19:17:23Z","merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/spree/spree/pulls/5760/commits","review_comments_url":"https://api.github.com/repos/spree/spree/pulls/5760/comments","review_comment_url":"https://api.github.com/repos/spree/spree/pulls/comments/{number}","comments_url":"https://api.github.com/repos/spree/spree/issues/5760/comments","statuses_url":"https://api.github.com/repos/spree/spree/statuses/a53564b72ddf56c5bac0fd8a66fe470578234762","head":{"label":"adaddeo:exchange_variant_elgibility_patch","ref":"exchange_variant_elgibility_patch","sha":"a53564b72ddf56c5bac0fd8a66fe470578234762","user":{"login":"adaddeo","id":1143517,"avatar_url":"https://avatars.githubusercontent.com/u/1143517?v=3","gravatar_id":"","url":"https://api.github.com/users/adaddeo","html_url":"https://github.com/adaddeo","followers_url":"https://api.github.com/users/adaddeo/followers","following_url":"https://api.github.com/users/adaddeo/following{/other_user}","gists_url":"https://api.github.com/users/adaddeo/gists{/gist_id}","starred_url":"https://api.github.com/users/adaddeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adaddeo/subscriptions","organizations_url":"https://api.github.com/users/adaddeo/orgs","repos_url":"https://api.github.com/users/adaddeo/repos","events_url":"https://api.github.com/users/adaddeo/events{/privacy}","received_events_url":"https://api.github.com/users/adaddeo/received_events","type":"User","site_admin":false},"repo":{"id":23669451,"name":"spree","full_name":"adaddeo/spree","owner":{"login":"adaddeo","id":1143517,"avatar_url":"https://avatars.githubusercontent.com/u/1143517?v=3","gravatar_id":"","url":"https://api.github.com/users/adaddeo","html_url":"https://github.com/adaddeo","followers_url":"https://api.github.com/users/adaddeo/followers","following_url":"https://api.github.com/users/adaddeo/following{/other_user}","gists_url":"https://api.github.com/users/adaddeo/gists{/gist_id}","starred_url":"https://api.github.com/users/adaddeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adaddeo/subscriptions","organizations_url":"https://api.github.com/users/adaddeo/orgs","repos_url":"https://api.github.com/users/adaddeo/repos","events_url":"https://api.github.com/users/adaddeo/events{/privacy}","received_events_url":"https://api.github.com/users/adaddeo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adaddeo/spree","description":"Spree is a complete open source e-commerce solution for Ruby on Rails.","fork":true,"url":"https://api.github.com/repos/adaddeo/spree","forks_url":"https://api.github.com/repos/adaddeo/spree/forks","keys_url":"https://api.github.com/repos/adaddeo/spree/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adaddeo/spree/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adaddeo/spree/teams","hooks_url":"https://api.github.com/repos/adaddeo/spree/hooks","issue_events_url":"https://api.github.com/repos/adaddeo/spree/issues/events{/number}","events_url":"https://api.github.com/repos/adaddeo/spree/events","assignees_url":"https://api.github.com/repos/adaddeo/spree/assignees{/user}","branches_url":"https://api.github.com/repos/adaddeo/spree/branches{/branch}","tags_url":"https://api.github.com/repos/adaddeo/spree/tags","blobs_url":"https://api.github.com/repos/adaddeo/spree/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adaddeo/spree/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adaddeo/spree/git/refs{/sha}","trees_url":"https://api.github.com/repos/adaddeo/spree/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adaddeo/spree/statuses/{sha}","languages_url":"https://api.github.com/repos/adaddeo/spree/languages","stargazers_url":"https://api.github.com/repos/adaddeo/spree/stargazers","contributors_url":"https://api.github.com/repos/adaddeo/spree/contributors","subscribers_url":"https://api.github.com/repos/adaddeo/spree/subscribers","subscription_url":"https://api.github.com/repos/adaddeo/spree/subscription","commits_url":"https://api.github.com/repos/adaddeo/spree/commits{/sha}","git_commits_url":"https://api.github.com/repos/adaddeo/spree/git/commits{/sha}","comments_url":"https://api.github.com/repos/adaddeo/spree/comments{/number}","issue_comment_url":"https://api.github.com/repos/adaddeo/spree/issues/comments/{number}","contents_url":"https://api.github.com/repos/adaddeo/spree/contents/{+path}","compare_url":"https://api.github.com/repos/adaddeo/spree/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adaddeo/spree/merges","archive_url":"https://api.github.com/repos/adaddeo/spree/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adaddeo/spree/downloads","issues_url":"https://api.github.com/repos/adaddeo/spree/issues{/number}","pulls_url":"https://api.github.com/repos/adaddeo/spree/pulls{/number}","milestones_url":"https://api.github.com/repos/adaddeo/spree/milestones{/number}","notifications_url":"https://api.github.com/repos/adaddeo/spree/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adaddeo/spree/labels{/name}","releases_url":"https://api.github.com/repos/adaddeo/spree/releases{/id}","created_at":"2014-09-04T16:04:16Z","updated_at":"2014-09-04T15:38:36Z","pushed_at":"2014-12-11T19:15:07Z","git_url":"git://github.com/adaddeo/spree.git","ssh_url":"git@github.com:adaddeo/spree.git","clone_url":"https://github.com/adaddeo/spree.git","svn_url":"https://github.com/adaddeo/spree","homepage":"http://spreecommerce.com","size":70119,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spree:master","ref":"master","sha":"2a6444e33d6593ca4cc2a0eb3980b4afb9937d92","user":{"login":"spree","id":56702,"avatar_url":"https://avatars.githubusercontent.com/u/56702?v=3","gravatar_id":"","url":"https://api.github.com/users/spree","html_url":"https://github.com/spree","followers_url":"https://api.github.com/users/spree/followers","following_url":"https://api.github.com/users/spree/following{/other_user}","gists_url":"https://api.github.com/users/spree/gists{/gist_id}","starred_url":"https://api.github.com/users/spree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spree/subscriptions","organizations_url":"https://api.github.com/users/spree/orgs","repos_url":"https://api.github.com/users/spree/repos","events_url":"https://api.github.com/users/spree/events{/privacy}","received_events_url":"https://api.github.com/users/spree/received_events","type":"Organization","site_admin":false},"repo":{"id":3314,"name":"spree","full_name":"spree/spree","owner":{"login":"spree","id":56702,"avatar_url":"https://avatars.githubusercontent.com/u/56702?v=3","gravatar_id":"","url":"https://api.github.com/users/spree","html_url":"https://github.com/spree","followers_url":"https://api.github.com/users/spree/followers","following_url":"https://api.github.com/users/spree/following{/other_user}","gists_url":"https://api.github.com/users/spree/gists{/gist_id}","starred_url":"https://api.github.com/users/spree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spree/subscriptions","organizations_url":"https://api.github.com/users/spree/orgs","repos_url":"https://api.github.com/users/spree/repos","events_url":"https://api.github.com/users/spree/events{/privacy}","received_events_url":"https://api.github.com/users/spree/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spree/spree","description":"Spree is a complete open source e-commerce solution for Ruby on Rails.","fork":false,"url":"https://api.github.com/repos/spree/spree","forks_url":"https://api.github.com/repos/spree/spree/forks","keys_url":"https://api.github.com/repos/spree/spree/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spree/spree/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spree/spree/teams","hooks_url":"https://api.github.com/repos/spree/spree/hooks","issue_events_url":"https://api.github.com/repos/spree/spree/issues/events{/number}","events_url":"https://api.github.com/repos/spree/spree/events","assignees_url":"https://api.github.com/repos/spree/spree/assignees{/user}","branches_url":"https://api.github.com/repos/spree/spree/branches{/branch}","tags_url":"https://api.github.com/repos/spree/spree/tags","blobs_url":"https://api.github.com/repos/spree/spree/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spree/spree/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spree/spree/git/refs{/sha}","trees_url":"https://api.github.com/repos/spree/spree/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spree/spree/statuses/{sha}","languages_url":"https://api.github.com/repos/spree/spree/languages","stargazers_url":"https://api.github.com/repos/spree/spree/stargazers","contributors_url":"https://api.github.com/repos/spree/spree/contributors","subscribers_url":"https://api.github.com/repos/spree/spree/subscribers","subscription_url":"https://api.github.com/repos/spree/spree/subscription","commits_url":"https://api.github.com/repos/spree/spree/commits{/sha}","git_commits_url":"https://api.github.com/repos/spree/spree/git/commits{/sha}","comments_url":"https://api.github.com/repos/spree/spree/comments{/number}","issue_comment_url":"https://api.github.com/repos/spree/spree/issues/comments/{number}","contents_url":"https://api.github.com/repos/spree/spree/contents/{+path}","compare_url":"https://api.github.com/repos/spree/spree/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spree/spree/merges","archive_url":"https://api.github.com/repos/spree/spree/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spree/spree/downloads","issues_url":"https://api.github.com/repos/spree/spree/issues{/number}","pulls_url":"https://api.github.com/repos/spree/spree/pulls{/number}","milestones_url":"https://api.github.com/repos/spree/spree/milestones{/number}","notifications_url":"https://api.github.com/repos/spree/spree/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spree/spree/labels{/name}","releases_url":"https://api.github.com/repos/spree/spree/releases{/id}","created_at":"2008-03-10T14:45:35Z","updated_at":"2014-12-11T16:01:20Z","pushed_at":"2014-12-11T14:12:32Z","git_url":"git://github.com/spree/spree.git","ssh_url":"git@github.com:spree/spree.git","clone_url":"https://github.com/spree/spree.git","svn_url":"https://github.com/spree/spree","homepage":"http://spreecommerce.com","size":126902,"stargazers_count":5746,"watchers_count":5746,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2673,"mirror_url":null,"open_issues_count":118,"forks":2673,"open_issues":118,"watchers":5746,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spree/spree/pulls/5760"},"html":{"href":"https://github.com/spree/spree/pull/5760"},"issue":{"href":"https://api.github.com/repos/spree/spree/issues/5760"},"comments":{"href":"https://api.github.com/repos/spree/spree/issues/5760/comments"},"review_comments":{"href":"https://api.github.com/repos/spree/spree/pulls/5760/comments"},"review_comment":{"href":"https://api.github.com/repos/spree/spree/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/spree/spree/pulls/5760/commits"},"statuses":{"href":"https://api.github.com/repos/spree/spree/statuses/a53564b72ddf56c5bac0fd8a66fe470578234762"}}}}