GitHub PullRequestReviewCommentEvent at 2014-10-02 20:38:58
Repository: docker
Actor: scharf
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/18366132","id":18366132,"diff_hunk":"@@ -46,6 +46,22 @@ __docker_containers_stopped()\n \tCOMPREPLY=( $( compgen -W \"$names $containers\" -- \"$cur\" ) )\n }\n \n+__docker_containers_paused()\n+{\n+\tlocal containers=\"$( __docker_q ps -q)\"\n+\tlocal names=\"$( __docker_q inspect --format='{{.State.Paused}} {{.Name}}' $containers | sed 's/^false.*//' | sed 's,^true /,,' )\"","path":"contrib/completion/bash/docker","position":7,"original_position":7,"commit_id":"11e46c169398648a121d06f83994887894f9019c","original_commit_id":"11e46c169398648a121d06f83994887894f9019c","user":{"login":"scharf","id":3731059,"avatar_url":"https://avatars.githubusercontent.com/u/3731059?v=2","gravatar_id":"","url":"https://api.github.com/users/scharf","html_url":"https://github.com/scharf","followers_url":"https://api.github.com/users/scharf/followers","following_url":"https://api.github.com/users/scharf/following{/other_user}","gists_url":"https://api.github.com/users/scharf/gists{/gist_id}","starred_url":"https://api.github.com/users/scharf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scharf/subscriptions","organizations_url":"https://api.github.com/users/scharf/orgs","repos_url":"https://api.github.com/users/scharf/repos","events_url":"https://api.github.com/users/scharf/events{/privacy}","received_events_url":"https://api.github.com/users/scharf/received_events","type":"User","site_admin":false},"body":"This looks much better, because the go template language does the work. I did not know the syntax, so I did it analogous to the other lists...","created_at":"2014-10-02T20:38:58Z","updated_at":"2014-10-02T20:38:58Z","html_url":"https://github.com/docker/docker/pull/8359#discussion_r18366132","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/8359","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/18366132"},"html":{"href":"https://github.com/docker/docker/pull/8359#discussion_r18366132"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/8359"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/8359","id":22155459,"html_url":"https://github.com/docker/docker/pull/8359","diff_url":"https://github.com/docker/docker/pull/8359.diff","patch_url":"https://github.com/docker/docker/pull/8359.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/8359","number":8359,"state":"open","locked":false,"title":"Bash command completion for pause and unpause","user":{"login":"scharf","id":3731059,"avatar_url":"https://avatars.githubusercontent.com/u/3731059?v=2","gravatar_id":"","url":"https://api.github.com/users/scharf","html_url":"https://github.com/scharf","followers_url":"https://api.github.com/users/scharf/followers","following_url":"https://api.github.com/users/scharf/following{/other_user}","gists_url":"https://api.github.com/users/scharf/gists{/gist_id}","starred_url":"https://api.github.com/users/scharf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scharf/subscriptions","organizations_url":"https://api.github.com/users/scharf/orgs","repos_url":"https://api.github.com/users/scharf/repos","events_url":"https://api.github.com/users/scharf/events{/privacy}","received_events_url":"https://api.github.com/users/scharf/received_events","type":"User","site_admin":false},"body":"The docker bash support does not complete `docker pause` and `docker unpause`. This pull request adds the completion. Helper functions to determine the *paused*and the *not paused* running candidates for the completion.","created_at":"2014-10-02T17:16:54Z","updated_at":"2014-10-02T20:38:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"392b19c7feec741d5d74d28bd482255f12384bed","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker/pulls/8359/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/8359/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments/{number}","comments_url":"https://api.github.com/repos/docker/docker/issues/8359/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/11e46c169398648a121d06f83994887894f9019c","head":{"label":"scharf:bash_comman_completion_for_pause_and_unpause","ref":"bash_comman_completion_for_pause_and_unpause","sha":"11e46c169398648a121d06f83994887894f9019c","user":{"login":"scharf","id":3731059,"avatar_url":"https://avatars.githubusercontent.com/u/3731059?v=2","gravatar_id":"","url":"https://api.github.com/users/scharf","html_url":"https://github.com/scharf","followers_url":"https://api.github.com/users/scharf/followers","following_url":"https://api.github.com/users/scharf/following{/other_user}","gists_url":"https://api.github.com/users/scharf/gists{/gist_id}","starred_url":"https://api.github.com/users/scharf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scharf/subscriptions","organizations_url":"https://api.github.com/users/scharf/orgs","repos_url":"https://api.github.com/users/scharf/repos","events_url":"https://api.github.com/users/scharf/events{/privacy}","received_events_url":"https://api.github.com/users/scharf/received_events","type":"User","site_admin":false},"repo":{"id":24725642,"name":"docker","full_name":"scharf/docker","owner":{"login":"scharf","id":3731059,"avatar_url":"https://avatars.githubusercontent.com/u/3731059?v=2","gravatar_id":"","url":"https://api.github.com/users/scharf","html_url":"https://github.com/scharf","followers_url":"https://api.github.com/users/scharf/followers","following_url":"https://api.github.com/users/scharf/following{/other_user}","gists_url":"https://api.github.com/users/scharf/gists{/gist_id}","starred_url":"https://api.github.com/users/scharf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scharf/subscriptions","organizations_url":"https://api.github.com/users/scharf/orgs","repos_url":"https://api.github.com/users/scharf/repos","events_url":"https://api.github.com/users/scharf/events{/privacy}","received_events_url":"https://api.github.com/users/scharf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/scharf/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/scharf/docker","forks_url":"https://api.github.com/repos/scharf/docker/forks","keys_url":"https://api.github.com/repos/scharf/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scharf/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scharf/docker/teams","hooks_url":"https://api.github.com/repos/scharf/docker/hooks","issue_events_url":"https://api.github.com/repos/scharf/docker/issues/events{/number}","events_url":"https://api.github.com/repos/scharf/docker/events","assignees_url":"https://api.github.com/repos/scharf/docker/assignees{/user}","branches_url":"https://api.github.com/repos/scharf/docker/branches{/branch}","tags_url":"https://api.github.com/repos/scharf/docker/tags","blobs_url":"https://api.github.com/repos/scharf/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scharf/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scharf/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/scharf/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scharf/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/scharf/docker/languages","stargazers_url":"https://api.github.com/repos/scharf/docker/stargazers","contributors_url":"https://api.github.com/repos/scharf/docker/contributors","subscribers_url":"https://api.github.com/repos/scharf/docker/subscribers","subscription_url":"https://api.github.com/repos/scharf/docker/subscription","commits_url":"https://api.github.com/repos/scharf/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/scharf/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/scharf/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/scharf/docker/issues/comments/{number}","contents_url":"https://api.github.com/repos/scharf/docker/contents/{+path}","compare_url":"https://api.github.com/repos/scharf/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scharf/docker/merges","archive_url":"https://api.github.com/repos/scharf/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scharf/docker/downloads","issues_url":"https://api.github.com/repos/scharf/docker/issues{/number}","pulls_url":"https://api.github.com/repos/scharf/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/scharf/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/scharf/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scharf/docker/labels{/name}","releases_url":"https://api.github.com/repos/scharf/docker/releases{/id}","created_at":"2014-10-02T15:54:22Z","updated_at":"2014-10-02T18:00:27Z","pushed_at":"2014-10-02T18:00:25Z","git_url":"git://github.com/scharf/docker.git","ssh_url":"git@github.com:scharf/docker.git","clone_url":"https://github.com/scharf/docker.git","svn_url":"https://github.com/scharf/docker","homepage":"http://www.docker.com","size":34534,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"f69a262464bd9d6dccb1d059b3a84c6ef9587a87","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=2","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=2","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments/{number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","created_at":"2013-01-18T18:10:57Z","updated_at":"2014-10-02T20:29:06Z","pushed_at":"2014-10-02T16:56:19Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":145444,"stargazers_count":15499,"watchers_count":15499,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2969,"mirror_url":null,"open_issues_count":788,"forks":2969,"open_issues":788,"watchers":15499,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/8359"},"html":{"href":"https://github.com/docker/docker/pull/8359"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/8359"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/8359/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/8359/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/8359/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/11e46c169398648a121d06f83994887894f9019c"}}}}