GitHub PullRequestReviewCommentEvent at 2014-09-14 12:44:27
Repository: Hilary
Actor: nicolaasmatthijs
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/oaeproject/Hilary/pulls/comments/17519260","id":17519260,"diff_hunk":"@@ -100,3 +125,187 @@ LibraryAPI.Index.registerLibraryIndex(FoldersConstants.library.CONTENT_LIBRARY_I\n         });\n     }\n });\n+\n+/*!\n+ * Configure the search endpoint that allows you to search for content in a folder\n+ */\n+LibraryAPI.Search.registerLibrarySearch('folder-content', ['content'], {\n+    'getLibraryOwner': function(folderId, callback) {\n+        FoldersDAO.getFolder(folderId, function(err, folder) {\n+            if (err) {\n+                return callback(err);\n+            }\n+\n+            // We use the *groupId* as a \"direct member\" of content in the search index\n+            var library = folder;\n+            library.indexedId = folder.groupId;\n+            return callback(null, library);\n+        });\n+    }\n+});\n+\n+/*!\n+ * Configure the search endpoint that allows you to search for folders in a principal's library\n+ */\n+LibraryAPI.Search.registerLibrarySearch('folder-library', ['folder']);\n+\n+/*!\n+ * When a folder gets deleted we remove it as an authz member of all the content items\n+ * it contained. Eventually we also purge all its content libraries\n+ */\n+FoldersAPI.on(FoldersConstants.events.DELETED_FOLDER, function(ctx, folder, memberIds) {","path":"node_modules/oae-folders/lib/library.js","position":69,"original_position":69,"commit_id":"19b2ca457ca3ee8b2356974a0e6026c822748cb3","original_commit_id":"19b2ca457ca3ee8b2356974a0e6026c822748cb3","user":{"login":"nicolaasmatthijs","id":109850,"avatar_url":"https://avatars.githubusercontent.com/u/109850?v=2","gravatar_id":"8d128e44d86f7ea45534291c2c36599a","url":"https://api.github.com/users/nicolaasmatthijs","html_url":"https://github.com/nicolaasmatthijs","followers_url":"https://api.github.com/users/nicolaasmatthijs/followers","following_url":"https://api.github.com/users/nicolaasmatthijs/following{/other_user}","gists_url":"https://api.github.com/users/nicolaasmatthijs/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolaasmatthijs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolaasmatthijs/subscriptions","organizations_url":"https://api.github.com/users/nicolaasmatthijs/orgs","repos_url":"https://api.github.com/users/nicolaasmatthijs/repos","events_url":"https://api.github.com/users/nicolaasmatthijs/events{/privacy}","received_events_url":"https://api.github.com/users/nicolaasmatthijs/received_events","type":"User","site_admin":false},"body":"Don't we also need to rebuild the folder libraries a folder is a member of when a folder's visibility/metadata is updated?","created_at":"2014-09-14T12:44:27Z","updated_at":"2014-09-14T12:44:27Z","html_url":"https://github.com/oaeproject/Hilary/pull/1027#discussion_r17519260","pull_request_url":"https://api.github.com/repos/oaeproject/Hilary/pulls/1027","_links":{"self":{"href":"https://api.github.com/repos/oaeproject/Hilary/pulls/comments/17519260"},"html":{"href":"https://github.com/oaeproject/Hilary/pull/1027#discussion_r17519260"},"pull_request":{"href":"https://api.github.com/repos/oaeproject/Hilary/pulls/1027"}}},"pull_request":{"url":"https://api.github.com/repos/oaeproject/Hilary/pulls/1027","id":20890302,"html_url":"https://github.com/oaeproject/Hilary/pull/1027","diff_url":"https://github.com/oaeproject/Hilary/pull/1027.diff","patch_url":"https://github.com/oaeproject/Hilary/pull/1027.patch","issue_url":"https://api.github.com/repos/oaeproject/Hilary/issues/1027","number":1027,"state":"open","locked":false,"title":"Folders","user":{"login":"simong","id":92180,"avatar_url":"https://avatars.githubusercontent.com/u/92180?v=2","gravatar_id":"a26ca1903e9f76a08cdc2e8c3f70ead8","url":"https://api.github.com/users/simong","html_url":"https://github.com/simong","followers_url":"https://api.github.com/users/simong/followers","following_url":"https://api.github.com/users/simong/following{/other_user}","gists_url":"https://api.github.com/users/simong/gists{/gist_id}","starred_url":"https://api.github.com/users/simong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simong/subscriptions","organizations_url":"https://api.github.com/users/simong/orgs","repos_url":"https://api.github.com/users/simong/repos","events_url":"https://api.github.com/users/simong/events{/privacy}","received_events_url":"https://api.github.com/users/simong/received_events","type":"User","site_admin":false},"body":"This PR brings in further integration for OAE in the following aspects:\r\n - Activities\r\n - Search\r\n - Previews\r\n - REST Docs\r\n - Extra functionality such as updating, deleting, ..","created_at":"2014-09-08T13:50:05Z","updated_at":"2014-09-14T12:44:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4f38ec02a190cdb6ca3cf8bf514aed63ff664802","assignee":{"login":"nicolaasmatthijs","id":109850,"avatar_url":"https://avatars.githubusercontent.com/u/109850?v=2","gravatar_id":"8d128e44d86f7ea45534291c2c36599a","url":"https://api.github.com/users/nicolaasmatthijs","html_url":"https://github.com/nicolaasmatthijs","followers_url":"https://api.github.com/users/nicolaasmatthijs/followers","following_url":"https://api.github.com/users/nicolaasmatthijs/following{/other_user}","gists_url":"https://api.github.com/users/nicolaasmatthijs/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolaasmatthijs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolaasmatthijs/subscriptions","organizations_url":"https://api.github.com/users/nicolaasmatthijs/orgs","repos_url":"https://api.github.com/users/nicolaasmatthijs/repos","events_url":"https://api.github.com/users/nicolaasmatthijs/events{/privacy}","received_events_url":"https://api.github.com/users/nicolaasmatthijs/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/oaeproject/Hilary/pulls/1027/commits","review_comments_url":"https://api.github.com/repos/oaeproject/Hilary/pulls/1027/comments","review_comment_url":"https://api.github.com/repos/oaeproject/Hilary/pulls/comments/{number}","comments_url":"https://api.github.com/repos/oaeproject/Hilary/issues/1027/comments","statuses_url":"https://api.github.com/repos/oaeproject/Hilary/statuses/19b2ca457ca3ee8b2356974a0e6026c822748cb3","head":{"label":"simong:1002-content-integration","ref":"1002-content-integration","sha":"19b2ca457ca3ee8b2356974a0e6026c822748cb3","user":{"login":"simong","id":92180,"avatar_url":"https://avatars.githubusercontent.com/u/92180?v=2","gravatar_id":"a26ca1903e9f76a08cdc2e8c3f70ead8","url":"https://api.github.com/users/simong","html_url":"https://github.com/simong","followers_url":"https://api.github.com/users/simong/followers","following_url":"https://api.github.com/users/simong/following{/other_user}","gists_url":"https://api.github.com/users/simong/gists{/gist_id}","starred_url":"https://api.github.com/users/simong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simong/subscriptions","organizations_url":"https://api.github.com/users/simong/orgs","repos_url":"https://api.github.com/users/simong/repos","events_url":"https://api.github.com/users/simong/events{/privacy}","received_events_url":"https://api.github.com/users/simong/received_events","type":"User","site_admin":false},"repo":{"id":5638617,"name":"Hilary","full_name":"simong/Hilary","owner":{"login":"simong","id":92180,"avatar_url":"https://avatars.githubusercontent.com/u/92180?v=2","gravatar_id":"a26ca1903e9f76a08cdc2e8c3f70ead8","url":"https://api.github.com/users/simong","html_url":"https://github.com/simong","followers_url":"https://api.github.com/users/simong/followers","following_url":"https://api.github.com/users/simong/following{/other_user}","gists_url":"https://api.github.com/users/simong/gists{/gist_id}","starred_url":"https://api.github.com/users/simong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simong/subscriptions","organizations_url":"https://api.github.com/users/simong/orgs","repos_url":"https://api.github.com/users/simong/repos","events_url":"https://api.github.com/users/simong/events{/privacy}","received_events_url":"https://api.github.com/users/simong/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/simong/Hilary","description":"","fork":true,"url":"https://api.github.com/repos/simong/Hilary","forks_url":"https://api.github.com/repos/simong/Hilary/forks","keys_url":"https://api.github.com/repos/simong/Hilary/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simong/Hilary/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simong/Hilary/teams","hooks_url":"https://api.github.com/repos/simong/Hilary/hooks","issue_events_url":"https://api.github.com/repos/simong/Hilary/issues/events{/number}","events_url":"https://api.github.com/repos/simong/Hilary/events","assignees_url":"https://api.github.com/repos/simong/Hilary/assignees{/user}","branches_url":"https://api.github.com/repos/simong/Hilary/branches{/branch}","tags_url":"https://api.github.com/repos/simong/Hilary/tags","blobs_url":"https://api.github.com/repos/simong/Hilary/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simong/Hilary/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simong/Hilary/git/refs{/sha}","trees_url":"https://api.github.com/repos/simong/Hilary/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simong/Hilary/statuses/{sha}","languages_url":"https://api.github.com/repos/simong/Hilary/languages","stargazers_url":"https://api.github.com/repos/simong/Hilary/stargazers","contributors_url":"https://api.github.com/repos/simong/Hilary/contributors","subscribers_url":"https://api.github.com/repos/simong/Hilary/subscribers","subscription_url":"https://api.github.com/repos/simong/Hilary/subscription","commits_url":"https://api.github.com/repos/simong/Hilary/commits{/sha}","git_commits_url":"https://api.github.com/repos/simong/Hilary/git/commits{/sha}","comments_url":"https://api.github.com/repos/simong/Hilary/comments{/number}","issue_comment_url":"https://api.github.com/repos/simong/Hilary/issues/comments/{number}","contents_url":"https://api.github.com/repos/simong/Hilary/contents/{+path}","compare_url":"https://api.github.com/repos/simong/Hilary/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simong/Hilary/merges","archive_url":"https://api.github.com/repos/simong/Hilary/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simong/Hilary/downloads","issues_url":"https://api.github.com/repos/simong/Hilary/issues{/number}","pulls_url":"https://api.github.com/repos/simong/Hilary/pulls{/number}","milestones_url":"https://api.github.com/repos/simong/Hilary/milestones{/number}","notifications_url":"https://api.github.com/repos/simong/Hilary/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simong/Hilary/labels{/name}","releases_url":"https://api.github.com/repos/simong/Hilary/releases{/id}","created_at":"2012-09-01T10:17:52Z","updated_at":"2014-07-09T17:47:42Z","pushed_at":"2014-09-12T15:33:48Z","git_url":"git://github.com/simong/Hilary.git","ssh_url":"git@github.com:simong/Hilary.git","clone_url":"https://github.com/simong/Hilary.git","svn_url":"https://github.com/simong/Hilary","homepage":null,"size":22462,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"oaeproject:master","ref":"master","sha":"e1297f9129aaacc4708b27ea66414cba7ffa074a","user":{"login":"oaeproject","id":4659912,"avatar_url":"https://avatars.githubusercontent.com/u/4659912?v=2","gravatar_id":"759cc05cff60f49168451eefcf3d51eb","url":"https://api.github.com/users/oaeproject","html_url":"https://github.com/oaeproject","followers_url":"https://api.github.com/users/oaeproject/followers","following_url":"https://api.github.com/users/oaeproject/following{/other_user}","gists_url":"https://api.github.com/users/oaeproject/gists{/gist_id}","starred_url":"https://api.github.com/users/oaeproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oaeproject/subscriptions","organizations_url":"https://api.github.com/users/oaeproject/orgs","repos_url":"https://api.github.com/users/oaeproject/repos","events_url":"https://api.github.com/users/oaeproject/events{/privacy}","received_events_url":"https://api.github.com/users/oaeproject/received_events","type":"Organization","site_admin":false},"repo":{"id":5638565,"name":"Hilary","full_name":"oaeproject/Hilary","owner":{"login":"oaeproject","id":4659912,"avatar_url":"https://avatars.githubusercontent.com/u/4659912?v=2","gravatar_id":"759cc05cff60f49168451eefcf3d51eb","url":"https://api.github.com/users/oaeproject","html_url":"https://github.com/oaeproject","followers_url":"https://api.github.com/users/oaeproject/followers","following_url":"https://api.github.com/users/oaeproject/following{/other_user}","gists_url":"https://api.github.com/users/oaeproject/gists{/gist_id}","starred_url":"https://api.github.com/users/oaeproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oaeproject/subscriptions","organizations_url":"https://api.github.com/users/oaeproject/orgs","repos_url":"https://api.github.com/users/oaeproject/repos","events_url":"https://api.github.com/users/oaeproject/events{/privacy}","received_events_url":"https://api.github.com/users/oaeproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oaeproject/Hilary","description":"Open Academic Environment (OAE) Back-End","fork":false,"url":"https://api.github.com/repos/oaeproject/Hilary","forks_url":"https://api.github.com/repos/oaeproject/Hilary/forks","keys_url":"https://api.github.com/repos/oaeproject/Hilary/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oaeproject/Hilary/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oaeproject/Hilary/teams","hooks_url":"https://api.github.com/repos/oaeproject/Hilary/hooks","issue_events_url":"https://api.github.com/repos/oaeproject/Hilary/issues/events{/number}","events_url":"https://api.github.com/repos/oaeproject/Hilary/events","assignees_url":"https://api.github.com/repos/oaeproject/Hilary/assignees{/user}","branches_url":"https://api.github.com/repos/oaeproject/Hilary/branches{/branch}","tags_url":"https://api.github.com/repos/oaeproject/Hilary/tags","blobs_url":"https://api.github.com/repos/oaeproject/Hilary/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oaeproject/Hilary/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oaeproject/Hilary/git/refs{/sha}","trees_url":"https://api.github.com/repos/oaeproject/Hilary/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oaeproject/Hilary/statuses/{sha}","languages_url":"https://api.github.com/repos/oaeproject/Hilary/languages","stargazers_url":"https://api.github.com/repos/oaeproject/Hilary/stargazers","contributors_url":"https://api.github.com/repos/oaeproject/Hilary/contributors","subscribers_url":"https://api.github.com/repos/oaeproject/Hilary/subscribers","subscription_url":"https://api.github.com/repos/oaeproject/Hilary/subscription","commits_url":"https://api.github.com/repos/oaeproject/Hilary/commits{/sha}","git_commits_url":"https://api.github.com/repos/oaeproject/Hilary/git/commits{/sha}","comments_url":"https://api.github.com/repos/oaeproject/Hilary/comments{/number}","issue_comment_url":"https://api.github.com/repos/oaeproject/Hilary/issues/comments/{number}","contents_url":"https://api.github.com/repos/oaeproject/Hilary/contents/{+path}","compare_url":"https://api.github.com/repos/oaeproject/Hilary/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oaeproject/Hilary/merges","archive_url":"https://api.github.com/repos/oaeproject/Hilary/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oaeproject/Hilary/downloads","issues_url":"https://api.github.com/repos/oaeproject/Hilary/issues{/number}","pulls_url":"https://api.github.com/repos/oaeproject/Hilary/pulls{/number}","milestones_url":"https://api.github.com/repos/oaeproject/Hilary/milestones{/number}","notifications_url":"https://api.github.com/repos/oaeproject/Hilary/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oaeproject/Hilary/labels{/name}","releases_url":"https://api.github.com/repos/oaeproject/Hilary/releases{/id}","created_at":"2012-09-01T10:05:13Z","updated_at":"2014-09-09T18:26:03Z","pushed_at":"2014-09-12T09:26:05Z","git_url":"git://github.com/oaeproject/Hilary.git","ssh_url":"git@github.com:oaeproject/Hilary.git","clone_url":"https://github.com/oaeproject/Hilary.git","svn_url":"https://github.com/oaeproject/Hilary","homepage":"http://www.oaeproject.org","size":32363,"stargazers_count":26,"watchers_count":26,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":58,"mirror_url":null,"open_issues_count":16,"forks":58,"open_issues":16,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/oaeproject/Hilary/pulls/1027"},"html":{"href":"https://github.com/oaeproject/Hilary/pull/1027"},"issue":{"href":"https://api.github.com/repos/oaeproject/Hilary/issues/1027"},"comments":{"href":"https://api.github.com/repos/oaeproject/Hilary/issues/1027/comments"},"review_comments":{"href":"https://api.github.com/repos/oaeproject/Hilary/pulls/1027/comments"},"review_comment":{"href":"https://api.github.com/repos/oaeproject/Hilary/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/oaeproject/Hilary/pulls/1027/commits"},"statuses":{"href":"https://api.github.com/repos/oaeproject/Hilary/statuses/19b2ca457ca3ee8b2356974a0e6026c822748cb3"}}}}