GitHub PullRequestReviewCommentEvent at 2014-02-07 20:01:27
Repository: scikit-learn
Actor: agramfort
Payload: {"comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/9552898","id":9552898,"diff_hunk":"@@ -197,6 +295,23 @@ def test_connectivity_fixing_non_lil():\n     assert_warns(UserWarning, w.fit, x)\n \n \n+def test_int_float_dict():\n+    rng = np.random.RandomState(0)\n+    keys = np.unique(rng.randint(100, size=10).astype(np.intp))\n+    values = rng.rand(len(keys))\n+\n+    d = IntFloatDict(keys, values)\n+    for key, value in zip(keys, values):\n+        assert d[key] == value\n+\n+    other_keys = np.arange(50).astype(np.intp)[::2]\n+    other_values = 0.5*np.ones(50)[::2]","path":"sklearn/cluster/tests/test_hierarchical.py","position":329,"original_position":329,"commit_id":"f96331717a5cf04b7b53851b70312c59e7594834","original_commit_id":"f96331717a5cf04b7b53851b70312c59e7594834","user":{"login":"agramfort","id":161052,"avatar_url":"https://gravatar.com/avatar/e9758ca665b8c3d8cb3026c114d05833?d=https%3A%2F%2Fidenticons.github.com%2F3bf21a35133be965b3b9ad779b3c510b.png&r=x","gravatar_id":"e9758ca665b8c3d8cb3026c114d05833","url":"https://api.github.com/users/agramfort","html_url":"https://github.com/agramfort","followers_url":"https://api.github.com/users/agramfort/followers","following_url":"https://api.github.com/users/agramfort/following{/other_user}","gists_url":"https://api.github.com/users/agramfort/gists{/gist_id}","starred_url":"https://api.github.com/users/agramfort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agramfort/subscriptions","organizations_url":"https://api.github.com/users/agramfort/orgs","repos_url":"https://api.github.com/users/agramfort/repos","events_url":"https://api.github.com/users/agramfort/events{/privacy}","received_events_url":"https://api.github.com/users/agramfort/received_events","type":"User","site_admin":false},"body":">\n> You are out of date!\n>\n> no space is allowed as long as it is consistent through out the statement:\n> a*b + c*d is allowed for example.\n>\nI strongly disagree even if I'm considered as out of data as @ogrisel :)","created_at":"2014-02-07T20:01:27Z","updated_at":"2014-02-07T20:01:27Z","html_url":"https://github.com/scikit-learn/scikit-learn/pull/2199#discussion_r9552898","pull_request_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/2199","_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/9552898"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/2199#discussion_r9552898"},"pull_request":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/2199"}}}}