GitHub PullRequestReviewCommentEvent at 2014-10-21 13:40:32
Repository: marketplace-tests
Actor: viorelaioia
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/marketplace-tests/pulls/comments/19147938","id":19147938,"diff_hunk":"@@ -200,3 +209,87 @@ def app_name(self):\n         @property\n         def menu(self):\n             return self.Menu(self.testsetup)\n+\n+\n+    class FooterRegion(Page):\n+\n+        _region_link_locator = (By.CSS_SELECTOR, '.region')\n+        _develop_apps_button_locator = (By.CSS_SELECTOR, '.button.devhub')\n+        _developer_hub_link_locator = (By.CSS_SELECTOR, '.group.links > a[href=\"/developers/\"]')\n+        _submit_feedback_link_locator = (By.CSS_SELECTOR, '.group.links .submit-feedback')\n+        _my_apps_link_locator = (By.CSS_SELECTOR, '.group.links > a[href*=\"purchases\"]')\n+        _my_submissions_link_locator = (By.CSS_SELECTOR, '.group.links > a[href*=\"submissions\"]')\n+        _privacy_policy_link_locator = (By.CSS_SELECTOR, '#footer a[href*=\"privacy-policy\"]')\n+        _term_of_use_link_locator = (By.CSS_SELECTOR, '#footer a[href*=\"terms-of-use\"]')\n+        _report_abuse_link_locator = (By.CSS_SELECTOR, '#footer a[href*=\"fraud-report\"]')\n+\n+        footer_links_list = [\n+            {\n+                'locator': (By.CSS_SELECTOR, '#footzilla > a'),\n+                'url_suffix': 'mozilla.org/',\n+\n+            }, {\n+                'locator': (By.CSS_SELECTOR, '#footer > .pad > p > a:nth-child(1)'),\n+                'url_suffix': '/about/legal.html#site',\n+            }, {\n+                'locator': (By.CSS_SELECTOR, '#footer > .pad > p > a:nth-child(2)'),\n+                'url_suffix': 'creativecommons.org/licenses/by-sa/3.0/',\n+            }, {\n+                'locator': (By.CSS_SELECTOR, '#footer > .pad > ul > li:nth-child(1) > a'),\n+                'url_suffix': '/privacy-policy',\n+            }, {\n+                'locator': (By.CSS_SELECTOR, '#footer > .pad > ul > li:nth-child(2) > a'),\n+                'url_suffix': '/terms-of-use',\n+            }, {\n+                'locator': (By.CSS_SELECTOR, '#footer > .pad > ul > li:nth-child(3) > a'),\n+                'url_suffix': '/legal/fraud-report/index.html',\n+            }, {\n+                'locator': (By.CSS_SELECTOR, 'div:nth-child(2).group.links > a:nth-child(1)'),\n+                'url_suffix': '/developers/',\n+            }, {\n+                'locator': (By.CSS_SELECTOR, 'div:nth-child(3).group.links > a:nth-child(1)'),","path":"pages/desktop/consumer_pages/base.py","position":65,"original_position":65,"commit_id":"1d6c18d57cc11668df2591b0cc5a4df3ff5dac66","original_commit_id":"1d6c18d57cc11668df2591b0cc5a4df3ff5dac66","user":{"login":"viorelaioia","id":5293100,"avatar_url":"https://avatars.githubusercontent.com/u/5293100?v=2","gravatar_id":"","url":"https://api.github.com/users/viorelaioia","html_url":"https://github.com/viorelaioia","followers_url":"https://api.github.com/users/viorelaioia/followers","following_url":"https://api.github.com/users/viorelaioia/following{/other_user}","gists_url":"https://api.github.com/users/viorelaioia/gists{/gist_id}","starred_url":"https://api.github.com/users/viorelaioia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viorelaioia/subscriptions","organizations_url":"https://api.github.com/users/viorelaioia/orgs","repos_url":"https://api.github.com/users/viorelaioia/repos","events_url":"https://api.github.com/users/viorelaioia/events{/privacy}","received_events_url":"https://api.github.com/users/viorelaioia/received_events","type":"User","site_admin":false},"body":"wrong locator","created_at":"2014-10-21T13:40:32Z","updated_at":"2014-10-21T13:40:32Z","html_url":"https://github.com/mozilla/marketplace-tests/pull/527#discussion_r19147938","pull_request_url":"https://api.github.com/repos/mozilla/marketplace-tests/pulls/527","_links":{"self":{"href":"https://api.github.com/repos/mozilla/marketplace-tests/pulls/comments/19147938"},"html":{"href":"https://github.com/mozilla/marketplace-tests/pull/527#discussion_r19147938"},"pull_request":{"href":"https://api.github.com/repos/mozilla/marketplace-tests/pulls/527"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/marketplace-tests/pulls/527","id":20747092,"html_url":"https://github.com/mozilla/marketplace-tests/pull/527","diff_url":"https://github.com/mozilla/marketplace-tests/pull/527.diff","patch_url":"https://github.com/mozilla/marketplace-tests/pull/527.patch","issue_url":"https://api.github.com/repos/mozilla/marketplace-tests/issues/527","number":527,"state":"open","locked":false,"title":"Sanity tests for Consumer Pages","user":{"login":"AndreiH","id":2787766,"avatar_url":"https://avatars.githubusercontent.com/u/2787766?v=2","gravatar_id":"","url":"https://api.github.com/users/AndreiH","html_url":"https://github.com/AndreiH","followers_url":"https://api.github.com/users/AndreiH/followers","following_url":"https://api.github.com/users/AndreiH/following{/other_user}","gists_url":"https://api.github.com/users/AndreiH/gists{/gist_id}","starred_url":"https://api.github.com/users/AndreiH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndreiH/subscriptions","organizations_url":"https://api.github.com/users/AndreiH/orgs","repos_url":"https://api.github.com/users/AndreiH/repos","events_url":"https://api.github.com/users/AndreiH/events{/privacy}","received_events_url":"https://api.github.com/users/AndreiH/received_events","type":"User","site_admin":false},"body":"This PR is for issue https://github.com/mozilla/marketplace-tests/issues/524\r\n\r\nTests are strengthened/modified, new tests added to address https://moztrap.mozilla.org/runtests/run/57/env/112/ list with sanity tests","created_at":"2014-09-04T14:29:27Z","updated_at":"2014-10-21T13:40:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aef961923c2a23a99a84d13f2a56f649c61d43e5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/marketplace-tests/pulls/527/commits","review_comments_url":"https://api.github.com/repos/mozilla/marketplace-tests/pulls/527/comments","review_comment_url":"https://api.github.com/repos/mozilla/marketplace-tests/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla/marketplace-tests/issues/527/comments","statuses_url":"https://api.github.com/repos/mozilla/marketplace-tests/statuses/1d6c18d57cc11668df2591b0cc5a4df3ff5dac66","head":{"label":"AndreiH:sanity_tests","ref":"sanity_tests","sha":"1d6c18d57cc11668df2591b0cc5a4df3ff5dac66","user":{"login":"AndreiH","id":2787766,"avatar_url":"https://avatars.githubusercontent.com/u/2787766?v=2","gravatar_id":"","url":"https://api.github.com/users/AndreiH","html_url":"https://github.com/AndreiH","followers_url":"https://api.github.com/users/AndreiH/followers","following_url":"https://api.github.com/users/AndreiH/following{/other_user}","gists_url":"https://api.github.com/users/AndreiH/gists{/gist_id}","starred_url":"https://api.github.com/users/AndreiH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndreiH/subscriptions","organizations_url":"https://api.github.com/users/AndreiH/orgs","repos_url":"https://api.github.com/users/AndreiH/repos","events_url":"https://api.github.com/users/AndreiH/events{/privacy}","received_events_url":"https://api.github.com/users/AndreiH/received_events","type":"User","site_admin":false},"repo":{"id":7092834,"name":"marketplace-tests","full_name":"AndreiH/marketplace-tests","owner":{"login":"AndreiH","id":2787766,"avatar_url":"https://avatars.githubusercontent.com/u/2787766?v=2","gravatar_id":"","url":"https://api.github.com/users/AndreiH","html_url":"https://github.com/AndreiH","followers_url":"https://api.github.com/users/AndreiH/followers","following_url":"https://api.github.com/users/AndreiH/following{/other_user}","gists_url":"https://api.github.com/users/AndreiH/gists{/gist_id}","starred_url":"https://api.github.com/users/AndreiH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndreiH/subscriptions","organizations_url":"https://api.github.com/users/AndreiH/orgs","repos_url":"https://api.github.com/users/AndreiH/repos","events_url":"https://api.github.com/users/AndreiH/events{/privacy}","received_events_url":"https://api.github.com/users/AndreiH/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AndreiH/marketplace-tests","description":"Selenium Tests for Market Place","fork":true,"url":"https://api.github.com/repos/AndreiH/marketplace-tests","forks_url":"https://api.github.com/repos/AndreiH/marketplace-tests/forks","keys_url":"https://api.github.com/repos/AndreiH/marketplace-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AndreiH/marketplace-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AndreiH/marketplace-tests/teams","hooks_url":"https://api.github.com/repos/AndreiH/marketplace-tests/hooks","issue_events_url":"https://api.github.com/repos/AndreiH/marketplace-tests/issues/events{/number}","events_url":"https://api.github.com/repos/AndreiH/marketplace-tests/events","assignees_url":"https://api.github.com/repos/AndreiH/marketplace-tests/assignees{/user}","branches_url":"https://api.github.com/repos/AndreiH/marketplace-tests/branches{/branch}","tags_url":"https://api.github.com/repos/AndreiH/marketplace-tests/tags","blobs_url":"https://api.github.com/repos/AndreiH/marketplace-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AndreiH/marketplace-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AndreiH/marketplace-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/AndreiH/marketplace-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AndreiH/marketplace-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/AndreiH/marketplace-tests/languages","stargazers_url":"https://api.github.com/repos/AndreiH/marketplace-tests/stargazers","contributors_url":"https://api.github.com/repos/AndreiH/marketplace-tests/contributors","subscribers_url":"https://api.github.com/repos/AndreiH/marketplace-tests/subscribers","subscription_url":"https://api.github.com/repos/AndreiH/marketplace-tests/subscription","commits_url":"https://api.github.com/repos/AndreiH/marketplace-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/AndreiH/marketplace-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/AndreiH/marketplace-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/AndreiH/marketplace-tests/issues/comments/{number}","contents_url":"https://api.github.com/repos/AndreiH/marketplace-tests/contents/{+path}","compare_url":"https://api.github.com/repos/AndreiH/marketplace-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AndreiH/marketplace-tests/merges","archive_url":"https://api.github.com/repos/AndreiH/marketplace-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AndreiH/marketplace-tests/downloads","issues_url":"https://api.github.com/repos/AndreiH/marketplace-tests/issues{/number}","pulls_url":"https://api.github.com/repos/AndreiH/marketplace-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/AndreiH/marketplace-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/AndreiH/marketplace-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AndreiH/marketplace-tests/labels{/name}","releases_url":"https://api.github.com/repos/AndreiH/marketplace-tests/releases{/id}","created_at":"2012-12-10T12:25:13Z","updated_at":"2014-10-17T12:57:55Z","pushed_at":"2014-10-21T11:20:32Z","git_url":"git://github.com/AndreiH/marketplace-tests.git","ssh_url":"git@github.com:AndreiH/marketplace-tests.git","clone_url":"https://github.com/AndreiH/marketplace-tests.git","svn_url":"https://github.com/AndreiH/marketplace-tests","homepage":"","size":3370,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"49926dd299194ac2152e465c052e206b992fcef4","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=2","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":3469023,"name":"marketplace-tests","full_name":"mozilla/marketplace-tests","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=2","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/marketplace-tests","description":"Selenium Tests for Market Place","fork":false,"url":"https://api.github.com/repos/mozilla/marketplace-tests","forks_url":"https://api.github.com/repos/mozilla/marketplace-tests/forks","keys_url":"https://api.github.com/repos/mozilla/marketplace-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/marketplace-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/marketplace-tests/teams","hooks_url":"https://api.github.com/repos/mozilla/marketplace-tests/hooks","issue_events_url":"https://api.github.com/repos/mozilla/marketplace-tests/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/marketplace-tests/events","assignees_url":"https://api.github.com/repos/mozilla/marketplace-tests/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/marketplace-tests/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/marketplace-tests/tags","blobs_url":"https://api.github.com/repos/mozilla/marketplace-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/marketplace-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/marketplace-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/marketplace-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/marketplace-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/marketplace-tests/languages","stargazers_url":"https://api.github.com/repos/mozilla/marketplace-tests/stargazers","contributors_url":"https://api.github.com/repos/mozilla/marketplace-tests/contributors","subscribers_url":"https://api.github.com/repos/mozilla/marketplace-tests/subscribers","subscription_url":"https://api.github.com/repos/mozilla/marketplace-tests/subscription","commits_url":"https://api.github.com/repos/mozilla/marketplace-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/marketplace-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/marketplace-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/marketplace-tests/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla/marketplace-tests/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/marketplace-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/marketplace-tests/merges","archive_url":"https://api.github.com/repos/mozilla/marketplace-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/marketplace-tests/downloads","issues_url":"https://api.github.com/repos/mozilla/marketplace-tests/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/marketplace-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/marketplace-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/marketplace-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/marketplace-tests/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/marketplace-tests/releases{/id}","created_at":"2012-02-17T10:32:50Z","updated_at":"2014-09-02T07:44:20Z","pushed_at":"2014-10-20T12:51:15Z","git_url":"git://github.com/mozilla/marketplace-tests.git","ssh_url":"git@github.com:mozilla/marketplace-tests.git","clone_url":"https://github.com/mozilla/marketplace-tests.git","svn_url":"https://github.com/mozilla/marketplace-tests","homepage":"","size":4341,"stargazers_count":29,"watchers_count":29,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":42,"mirror_url":null,"open_issues_count":16,"forks":42,"open_issues":16,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/marketplace-tests/pulls/527"},"html":{"href":"https://github.com/mozilla/marketplace-tests/pull/527"},"issue":{"href":"https://api.github.com/repos/mozilla/marketplace-tests/issues/527"},"comments":{"href":"https://api.github.com/repos/mozilla/marketplace-tests/issues/527/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/marketplace-tests/pulls/527/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/marketplace-tests/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla/marketplace-tests/pulls/527/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/marketplace-tests/statuses/1d6c18d57cc11668df2591b0cc5a4df3ff5dac66"}}}}