GitHub PullRequestEvent at 2014-07-25 15:30:22
Repository: paxmex
Actor: smanolloff
Payload: {"action":"opened","number":3,"pull_request":{"url":"https://api.github.com/repos/lumoslabs/paxmex/pulls/3","id":18902161,"html_url":"https://github.com/lumoslabs/paxmex/pull/3","diff_url":"https://github.com/lumoslabs/paxmex/pull/3.diff","patch_url":"https://github.com/lumoslabs/paxmex/pull/3.patch","issue_url":"https://api.github.com/repos/lumoslabs/paxmex/issues/3","number":3,"state":"open","title":"new scheme for EPA; minor refactor","user":{"login":"smanolloff","id":6965111,"avatar_url":"https://avatars.githubusercontent.com/u/6965111?","gravatar_id":"a097e574da55121706878bfa0db8139a","url":"https://api.github.com/users/smanolloff","html_url":"https://github.com/smanolloff","followers_url":"https://api.github.com/users/smanolloff/followers","following_url":"https://api.github.com/users/smanolloff/following{/other_user}","gists_url":"https://api.github.com/users/smanolloff/gists{/gist_id}","starred_url":"https://api.github.com/users/smanolloff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smanolloff/subscriptions","organizations_url":"https://api.github.com/users/smanolloff/orgs","repos_url":"https://api.github.com/users/smanolloff/repos","events_url":"https://api.github.com/users/smanolloff/events{/privacy}","received_events_url":"https://api.github.com/users/smanolloff/received_events","type":"User","site_admin":false},"body":"Hi, this gem is great! It works like a charm and helped me a lot in a time of need. I would like to make a small contribution:\r\n\r\n1. add EPA scheme dummy file, schema file\r\n2. modify Paxmex::Parser#new to accept a file path to the schema (allow other schemas)\r\n3. modify Paxmex::Parser#parse_section - separate required and optional parameters\r\n4. add to Paxmex::Schema#fiield a date(..) and time(..) type accepting a pattern (allow other time formats)\r\n5. add to Paxmex::Schema#parse_decimal a simple regexp match (helps to identify incorrect field ranges)\r\n6. remove Paxmex::Parser::SCHEMATA - it is now loaded during initialize (load only required schema)\r\n7. add corresponding rspec tests\r\n","created_at":"2014-07-25T15:30:21Z","updated_at":"2014-07-25T15:30:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lumoslabs/paxmex/pulls/3/commits","review_comments_url":"https://api.github.com/repos/lumoslabs/paxmex/pulls/3/comments","review_comment_url":"https://api.github.com/repos/lumoslabs/paxmex/pulls/comments/{number}","comments_url":"https://api.github.com/repos/lumoslabs/paxmex/issues/3/comments","statuses_url":"https://api.github.com/repos/lumoslabs/paxmex/statuses/ba9a69d0505d378f3dea00338e566b6318e1dc2e","head":{"label":"smanolloff:epa_scheme_support","ref":"epa_scheme_support","sha":"ba9a69d0505d378f3dea00338e566b6318e1dc2e","user":{"login":"smanolloff","id":6965111,"avatar_url":"https://avatars.githubusercontent.com/u/6965111?","gravatar_id":"a097e574da55121706878bfa0db8139a","url":"https://api.github.com/users/smanolloff","html_url":"https://github.com/smanolloff","followers_url":"https://api.github.com/users/smanolloff/followers","following_url":"https://api.github.com/users/smanolloff/following{/other_user}","gists_url":"https://api.github.com/users/smanolloff/gists{/gist_id}","starred_url":"https://api.github.com/users/smanolloff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smanolloff/subscriptions","organizations_url":"https://api.github.com/users/smanolloff/orgs","repos_url":"https://api.github.com/users/smanolloff/repos","events_url":"https://api.github.com/users/smanolloff/events{/privacy}","received_events_url":"https://api.github.com/users/smanolloff/received_events","type":"User","site_admin":false},"repo":{"id":22261145,"name":"paxmex","full_name":"smanolloff/paxmex","owner":{"login":"smanolloff","id":6965111,"avatar_url":"https://avatars.githubusercontent.com/u/6965111?","gravatar_id":"a097e574da55121706878bfa0db8139a","url":"https://api.github.com/users/smanolloff","html_url":"https://github.com/smanolloff","followers_url":"https://api.github.com/users/smanolloff/followers","following_url":"https://api.github.com/users/smanolloff/following{/other_user}","gists_url":"https://api.github.com/users/smanolloff/gists{/gist_id}","starred_url":"https://api.github.com/users/smanolloff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smanolloff/subscriptions","organizations_url":"https://api.github.com/users/smanolloff/orgs","repos_url":"https://api.github.com/users/smanolloff/repos","events_url":"https://api.github.com/users/smanolloff/events{/privacy}","received_events_url":"https://api.github.com/users/smanolloff/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/smanolloff/paxmex","description":"Parser for American Express transaction reconciliation files","fork":true,"url":"https://api.github.com/repos/smanolloff/paxmex","forks_url":"https://api.github.com/repos/smanolloff/paxmex/forks","keys_url":"https://api.github.com/repos/smanolloff/paxmex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smanolloff/paxmex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smanolloff/paxmex/teams","hooks_url":"https://api.github.com/repos/smanolloff/paxmex/hooks","issue_events_url":"https://api.github.com/repos/smanolloff/paxmex/issues/events{/number}","events_url":"https://api.github.com/repos/smanolloff/paxmex/events","assignees_url":"https://api.github.com/repos/smanolloff/paxmex/assignees{/user}","branches_url":"https://api.github.com/repos/smanolloff/paxmex/branches{/branch}","tags_url":"https://api.github.com/repos/smanolloff/paxmex/tags","blobs_url":"https://api.github.com/repos/smanolloff/paxmex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smanolloff/paxmex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smanolloff/paxmex/git/refs{/sha}","trees_url":"https://api.github.com/repos/smanolloff/paxmex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smanolloff/paxmex/statuses/{sha}","languages_url":"https://api.github.com/repos/smanolloff/paxmex/languages","stargazers_url":"https://api.github.com/repos/smanolloff/paxmex/stargazers","contributors_url":"https://api.github.com/repos/smanolloff/paxmex/contributors","subscribers_url":"https://api.github.com/repos/smanolloff/paxmex/subscribers","subscription_url":"https://api.github.com/repos/smanolloff/paxmex/subscription","commits_url":"https://api.github.com/repos/smanolloff/paxmex/commits{/sha}","git_commits_url":"https://api.github.com/repos/smanolloff/paxmex/git/commits{/sha}","comments_url":"https://api.github.com/repos/smanolloff/paxmex/comments{/number}","issue_comment_url":"https://api.github.com/repos/smanolloff/paxmex/issues/comments/{number}","contents_url":"https://api.github.com/repos/smanolloff/paxmex/contents/{+path}","compare_url":"https://api.github.com/repos/smanolloff/paxmex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smanolloff/paxmex/merges","archive_url":"https://api.github.com/repos/smanolloff/paxmex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smanolloff/paxmex/downloads","issues_url":"https://api.github.com/repos/smanolloff/paxmex/issues{/number}","pulls_url":"https://api.github.com/repos/smanolloff/paxmex/pulls{/number}","milestones_url":"https://api.github.com/repos/smanolloff/paxmex/milestones{/number}","notifications_url":"https://api.github.com/repos/smanolloff/paxmex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smanolloff/paxmex/labels{/name}","releases_url":"https://api.github.com/repos/smanolloff/paxmex/releases{/id}","created_at":"2014-07-25T15:14:16Z","updated_at":"2014-03-05T19:28:29Z","pushed_at":"2014-07-25T15:16:27Z","git_url":"git://github.com/smanolloff/paxmex.git","ssh_url":"git@github.com:smanolloff/paxmex.git","clone_url":"https://github.com/smanolloff/paxmex.git","svn_url":"https://github.com/smanolloff/paxmex","homepage":null,"size":145,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lumoslabs:master","ref":"master","sha":"2f170a1f256b72e3d47cf14f7b34a88c0fafc613","user":{"login":"lumoslabs","id":723646,"avatar_url":"https://avatars.githubusercontent.com/u/723646?","gravatar_id":"4eb638e4fae68d091eae039cd019f1a0","url":"https://api.github.com/users/lumoslabs","html_url":"https://github.com/lumoslabs","followers_url":"https://api.github.com/users/lumoslabs/followers","following_url":"https://api.github.com/users/lumoslabs/following{/other_user}","gists_url":"https://api.github.com/users/lumoslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/lumoslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lumoslabs/subscriptions","organizations_url":"https://api.github.com/users/lumoslabs/orgs","repos_url":"https://api.github.com/users/lumoslabs/repos","events_url":"https://api.github.com/users/lumoslabs/events{/privacy}","received_events_url":"https://api.github.com/users/lumoslabs/received_events","type":"Organization","site_admin":false},"repo":{"id":9063332,"name":"paxmex","full_name":"lumoslabs/paxmex","owner":{"login":"lumoslabs","id":723646,"avatar_url":"https://avatars.githubusercontent.com/u/723646?","gravatar_id":"4eb638e4fae68d091eae039cd019f1a0","url":"https://api.github.com/users/lumoslabs","html_url":"https://github.com/lumoslabs","followers_url":"https://api.github.com/users/lumoslabs/followers","following_url":"https://api.github.com/users/lumoslabs/following{/other_user}","gists_url":"https://api.github.com/users/lumoslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/lumoslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lumoslabs/subscriptions","organizations_url":"https://api.github.com/users/lumoslabs/orgs","repos_url":"https://api.github.com/users/lumoslabs/repos","events_url":"https://api.github.com/users/lumoslabs/events{/privacy}","received_events_url":"https://api.github.com/users/lumoslabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lumoslabs/paxmex","description":"Parser for American Express transaction reconciliation files","fork":false,"url":"https://api.github.com/repos/lumoslabs/paxmex","forks_url":"https://api.github.com/repos/lumoslabs/paxmex/forks","keys_url":"https://api.github.com/repos/lumoslabs/paxmex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lumoslabs/paxmex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lumoslabs/paxmex/teams","hooks_url":"https://api.github.com/repos/lumoslabs/paxmex/hooks","issue_events_url":"https://api.github.com/repos/lumoslabs/paxmex/issues/events{/number}","events_url":"https://api.github.com/repos/lumoslabs/paxmex/events","assignees_url":"https://api.github.com/repos/lumoslabs/paxmex/assignees{/user}","branches_url":"https://api.github.com/repos/lumoslabs/paxmex/branches{/branch}","tags_url":"https://api.github.com/repos/lumoslabs/paxmex/tags","blobs_url":"https://api.github.com/repos/lumoslabs/paxmex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lumoslabs/paxmex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lumoslabs/paxmex/git/refs{/sha}","trees_url":"https://api.github.com/repos/lumoslabs/paxmex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lumoslabs/paxmex/statuses/{sha}","languages_url":"https://api.github.com/repos/lumoslabs/paxmex/languages","stargazers_url":"https://api.github.com/repos/lumoslabs/paxmex/stargazers","contributors_url":"https://api.github.com/repos/lumoslabs/paxmex/contributors","subscribers_url":"https://api.github.com/repos/lumoslabs/paxmex/subscribers","subscription_url":"https://api.github.com/repos/lumoslabs/paxmex/subscription","commits_url":"https://api.github.com/repos/lumoslabs/paxmex/commits{/sha}","git_commits_url":"https://api.github.com/repos/lumoslabs/paxmex/git/commits{/sha}","comments_url":"https://api.github.com/repos/lumoslabs/paxmex/comments{/number}","issue_comment_url":"https://api.github.com/repos/lumoslabs/paxmex/issues/comments/{number}","contents_url":"https://api.github.com/repos/lumoslabs/paxmex/contents/{+path}","compare_url":"https://api.github.com/repos/lumoslabs/paxmex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lumoslabs/paxmex/merges","archive_url":"https://api.github.com/repos/lumoslabs/paxmex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lumoslabs/paxmex/downloads","issues_url":"https://api.github.com/repos/lumoslabs/paxmex/issues{/number}","pulls_url":"https://api.github.com/repos/lumoslabs/paxmex/pulls{/number}","milestones_url":"https://api.github.com/repos/lumoslabs/paxmex/milestones{/number}","notifications_url":"https://api.github.com/repos/lumoslabs/paxmex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lumoslabs/paxmex/labels{/name}","releases_url":"https://api.github.com/repos/lumoslabs/paxmex/releases{/id}","created_at":"2013-03-27T20:50:54Z","updated_at":"2014-03-05T19:28:29Z","pushed_at":"2014-03-05T19:28:30Z","git_url":"git://github.com/lumoslabs/paxmex.git","ssh_url":"git@github.com:lumoslabs/paxmex.git","clone_url":"https://github.com/lumoslabs/paxmex.git","svn_url":"https://github.com/lumoslabs/paxmex","homepage":null,"size":238,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lumoslabs/paxmex/pulls/3"},"html":{"href":"https://github.com/lumoslabs/paxmex/pull/3"},"issue":{"href":"https://api.github.com/repos/lumoslabs/paxmex/issues/3"},"comments":{"href":"https://api.github.com/repos/lumoslabs/paxmex/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/lumoslabs/paxmex/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/lumoslabs/paxmex/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/lumoslabs/paxmex/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/lumoslabs/paxmex/statuses/ba9a69d0505d378f3dea00338e566b6318e1dc2e"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":481,"deletions":43,"changed_files":8}}