GitHub PullRequestReviewCommentEvent at 2014-09-02 19:01:59
Repository: robottelo
Actor: omaciel
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/omaciel/robottelo/pulls/comments/17007822","id":17007822,"diff_hunk":"@@ -0,0 +1,32 @@\n+\"\"\"Unit tests for the ``api/v2/operatingsystems/:id/parameters`` paths.\n+\n+A reference for the relevant paths can be found here:\n+http://theforeman.org/api/apidoc/v2/parameters.html\n+\n+\"\"\"\n+from robottelo import entities\n+from unittest import TestCase\n+# (too many public methods) pylint: disable=R0904\n+\n+\n+class OSParameterTestCase(TestCase):\n+    \"\"\"Tests for the ``api/v2/operatingsystems/:id/parameters`` paths.\"\"\"\n+    def test_bz_1114640(self):\n+        \"\"\"@Test: Create a parameter for operating system 1.\n+\n+        @Assert: A parameter is created and can be read afterwards.\n+\n+        \"\"\"\n+        # Check whether OS 1 exists. Do not catch\n+        # requests.exceptions.HTTPError, as doing so destroys useful stack\n+        # trace information.\n+        entities.OperatingSystem(id=1).read()\n+\n+        # Create a param for OS 1 and read the param back.\n+        osp_attrs = entities.OperatingSystemParameter(1).create()\n+        osp = entities.OperatingSystemParameter(1, id=osp_attrs['id']).read()","path":"tests/foreman/api/test_operatingsystem_v2.py","position":27,"original_position":27,"commit_id":"cdbb7171c31676a75175c7ced9723adb713eadf4","original_commit_id":"cdbb7171c31676a75175c7ced9723adb713eadf4","user":{"login":"omaciel","id":53362,"avatar_url":"https://avatars.githubusercontent.com/u/53362?v=2","gravatar_id":"5be9b08cd178f87cca6de19f00a9992c","url":"https://api.github.com/users/omaciel","html_url":"https://github.com/omaciel","followers_url":"https://api.github.com/users/omaciel/followers","following_url":"https://api.github.com/users/omaciel/following{/other_user}","gists_url":"https://api.github.com/users/omaciel/gists{/gist_id}","starred_url":"https://api.github.com/users/omaciel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omaciel/subscriptions","organizations_url":"https://api.github.com/users/omaciel/orgs","repos_url":"https://api.github.com/users/omaciel/repos","events_url":"https://api.github.com/users/omaciel/events{/privacy}","received_events_url":"https://api.github.com/users/omaciel/received_events","type":"User","site_admin":false},"body":"Couldn't we use ``osp = entities.OperatingSystemParameter(OperatingSystem=1, id=osp_attrs['id']).read()`` instead?","created_at":"2014-09-02T19:01:59Z","updated_at":"2014-09-02T19:01:59Z","html_url":"https://github.com/omaciel/robottelo/pull/1269#discussion_r17007822","pull_request_url":"https://api.github.com/repos/omaciel/robottelo/pulls/1269","_links":{"self":{"href":"https://api.github.com/repos/omaciel/robottelo/pulls/comments/17007822"},"html":{"href":"https://github.com/omaciel/robottelo/pull/1269#discussion_r17007822"},"pull_request":{"href":"https://api.github.com/repos/omaciel/robottelo/pulls/1269"}}},"pull_request":{"url":"https://api.github.com/repos/omaciel/robottelo/pulls/1269","id":20523112,"html_url":"https://github.com/omaciel/robottelo/pull/1269","diff_url":"https://github.com/omaciel/robottelo/pull/1269.diff","patch_url":"https://github.com/omaciel/robottelo/pull/1269.patch","issue_url":"https://api.github.com/repos/omaciel/robottelo/issues/1269","number":1269,"state":"open","locked":false,"title":"Add a test targeting bugzilla bug #1114640","user":{"login":"Ichimonji10","id":1012989,"avatar_url":"https://avatars.githubusercontent.com/u/1012989?v=2","gravatar_id":"0d55b0822baba206e15373fbe457bf70","url":"https://api.github.com/users/Ichimonji10","html_url":"https://github.com/Ichimonji10","followers_url":"https://api.github.com/users/Ichimonji10/followers","following_url":"https://api.github.com/users/Ichimonji10/following{/other_user}","gists_url":"https://api.github.com/users/Ichimonji10/gists{/gist_id}","starred_url":"https://api.github.com/users/Ichimonji10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ichimonji10/subscriptions","organizations_url":"https://api.github.com/users/Ichimonji10/orgs","repos_url":"https://api.github.com/users/Ichimonji10/repos","events_url":"https://api.github.com/users/Ichimonji10/events{/privacy}","received_events_url":"https://api.github.com/users/Ichimonji10/received_events","type":"User","site_admin":false},"body":"To test [BZ 1114640](https://bugzilla.redhat.com/show_bug.cgi?id=1114640), write a test that creates a parameter for the operating\r\nsystem with ID 1. As part of this effort, create entity `OperatingSystemParameter`\r\nand partially test it.","created_at":"2014-08-29T21:00:14Z","updated_at":"2014-09-02T19:01:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"83fc3ff463d22208dec99a4b16cec2fc6ff1a5f0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/omaciel/robottelo/pulls/1269/commits","review_comments_url":"https://api.github.com/repos/omaciel/robottelo/pulls/1269/comments","review_comment_url":"https://api.github.com/repos/omaciel/robottelo/pulls/comments/{number}","comments_url":"https://api.github.com/repos/omaciel/robottelo/issues/1269/comments","statuses_url":"https://api.github.com/repos/omaciel/robottelo/statuses/cdbb7171c31676a75175c7ced9723adb713eadf4","head":{"label":"Ichimonji10:bz-1114640","ref":"bz-1114640","sha":"cdbb7171c31676a75175c7ced9723adb713eadf4","user":{"login":"Ichimonji10","id":1012989,"avatar_url":"https://avatars.githubusercontent.com/u/1012989?v=2","gravatar_id":"0d55b0822baba206e15373fbe457bf70","url":"https://api.github.com/users/Ichimonji10","html_url":"https://github.com/Ichimonji10","followers_url":"https://api.github.com/users/Ichimonji10/followers","following_url":"https://api.github.com/users/Ichimonji10/following{/other_user}","gists_url":"https://api.github.com/users/Ichimonji10/gists{/gist_id}","starred_url":"https://api.github.com/users/Ichimonji10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ichimonji10/subscriptions","organizations_url":"https://api.github.com/users/Ichimonji10/orgs","repos_url":"https://api.github.com/users/Ichimonji10/repos","events_url":"https://api.github.com/users/Ichimonji10/events{/privacy}","received_events_url":"https://api.github.com/users/Ichimonji10/received_events","type":"User","site_admin":false},"repo":{"id":20566902,"name":"robottelo","full_name":"Ichimonji10/robottelo","owner":{"login":"Ichimonji10","id":1012989,"avatar_url":"https://avatars.githubusercontent.com/u/1012989?v=2","gravatar_id":"0d55b0822baba206e15373fbe457bf70","url":"https://api.github.com/users/Ichimonji10","html_url":"https://github.com/Ichimonji10","followers_url":"https://api.github.com/users/Ichimonji10/followers","following_url":"https://api.github.com/users/Ichimonji10/following{/other_user}","gists_url":"https://api.github.com/users/Ichimonji10/gists{/gist_id}","starred_url":"https://api.github.com/users/Ichimonji10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ichimonji10/subscriptions","organizations_url":"https://api.github.com/users/Ichimonji10/orgs","repos_url":"https://api.github.com/users/Ichimonji10/repos","events_url":"https://api.github.com/users/Ichimonji10/events{/privacy}","received_events_url":"https://api.github.com/users/Ichimonji10/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ichimonji10/robottelo","description":"An automation testing framework for the Katello project.","fork":true,"url":"https://api.github.com/repos/Ichimonji10/robottelo","forks_url":"https://api.github.com/repos/Ichimonji10/robottelo/forks","keys_url":"https://api.github.com/repos/Ichimonji10/robottelo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ichimonji10/robottelo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ichimonji10/robottelo/teams","hooks_url":"https://api.github.com/repos/Ichimonji10/robottelo/hooks","issue_events_url":"https://api.github.com/repos/Ichimonji10/robottelo/issues/events{/number}","events_url":"https://api.github.com/repos/Ichimonji10/robottelo/events","assignees_url":"https://api.github.com/repos/Ichimonji10/robottelo/assignees{/user}","branches_url":"https://api.github.com/repos/Ichimonji10/robottelo/branches{/branch}","tags_url":"https://api.github.com/repos/Ichimonji10/robottelo/tags","blobs_url":"https://api.github.com/repos/Ichimonji10/robottelo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ichimonji10/robottelo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ichimonji10/robottelo/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ichimonji10/robottelo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ichimonji10/robottelo/statuses/{sha}","languages_url":"https://api.github.com/repos/Ichimonji10/robottelo/languages","stargazers_url":"https://api.github.com/repos/Ichimonji10/robottelo/stargazers","contributors_url":"https://api.github.com/repos/Ichimonji10/robottelo/contributors","subscribers_url":"https://api.github.com/repos/Ichimonji10/robottelo/subscribers","subscription_url":"https://api.github.com/repos/Ichimonji10/robottelo/subscription","commits_url":"https://api.github.com/repos/Ichimonji10/robottelo/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ichimonji10/robottelo/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ichimonji10/robottelo/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ichimonji10/robottelo/issues/comments/{number}","contents_url":"https://api.github.com/repos/Ichimonji10/robottelo/contents/{+path}","compare_url":"https://api.github.com/repos/Ichimonji10/robottelo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ichimonji10/robottelo/merges","archive_url":"https://api.github.com/repos/Ichimonji10/robottelo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ichimonji10/robottelo/downloads","issues_url":"https://api.github.com/repos/Ichimonji10/robottelo/issues{/number}","pulls_url":"https://api.github.com/repos/Ichimonji10/robottelo/pulls{/number}","milestones_url":"https://api.github.com/repos/Ichimonji10/robottelo/milestones{/number}","notifications_url":"https://api.github.com/repos/Ichimonji10/robottelo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ichimonji10/robottelo/labels{/name}","releases_url":"https://api.github.com/repos/Ichimonji10/robottelo/releases{/id}","created_at":"2014-06-06T14:38:05Z","updated_at":"2014-06-25T13:36:09Z","pushed_at":"2014-09-02T19:00:48Z","git_url":"git://github.com/Ichimonji10/robottelo.git","ssh_url":"git@github.com:Ichimonji10/robottelo.git","clone_url":"https://github.com/Ichimonji10/robottelo.git","svn_url":"https://github.com/Ichimonji10/robottelo","homepage":null,"size":8772,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"omaciel:master","ref":"master","sha":"b990d5e729c96d778d83fc153257050249fa8ea7","user":{"login":"omaciel","id":53362,"avatar_url":"https://avatars.githubusercontent.com/u/53362?v=2","gravatar_id":"5be9b08cd178f87cca6de19f00a9992c","url":"https://api.github.com/users/omaciel","html_url":"https://github.com/omaciel","followers_url":"https://api.github.com/users/omaciel/followers","following_url":"https://api.github.com/users/omaciel/following{/other_user}","gists_url":"https://api.github.com/users/omaciel/gists{/gist_id}","starred_url":"https://api.github.com/users/omaciel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omaciel/subscriptions","organizations_url":"https://api.github.com/users/omaciel/orgs","repos_url":"https://api.github.com/users/omaciel/repos","events_url":"https://api.github.com/users/omaciel/events{/privacy}","received_events_url":"https://api.github.com/users/omaciel/received_events","type":"User","site_admin":false},"repo":{"id":4000279,"name":"robottelo","full_name":"omaciel/robottelo","owner":{"login":"omaciel","id":53362,"avatar_url":"https://avatars.githubusercontent.com/u/53362?v=2","gravatar_id":"5be9b08cd178f87cca6de19f00a9992c","url":"https://api.github.com/users/omaciel","html_url":"https://github.com/omaciel","followers_url":"https://api.github.com/users/omaciel/followers","following_url":"https://api.github.com/users/omaciel/following{/other_user}","gists_url":"https://api.github.com/users/omaciel/gists{/gist_id}","starred_url":"https://api.github.com/users/omaciel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omaciel/subscriptions","organizations_url":"https://api.github.com/users/omaciel/orgs","repos_url":"https://api.github.com/users/omaciel/repos","events_url":"https://api.github.com/users/omaciel/events{/privacy}","received_events_url":"https://api.github.com/users/omaciel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/omaciel/robottelo","description":"An automation testing framework for the Katello project.","fork":false,"url":"https://api.github.com/repos/omaciel/robottelo","forks_url":"https://api.github.com/repos/omaciel/robottelo/forks","keys_url":"https://api.github.com/repos/omaciel/robottelo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/omaciel/robottelo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/omaciel/robottelo/teams","hooks_url":"https://api.github.com/repos/omaciel/robottelo/hooks","issue_events_url":"https://api.github.com/repos/omaciel/robottelo/issues/events{/number}","events_url":"https://api.github.com/repos/omaciel/robottelo/events","assignees_url":"https://api.github.com/repos/omaciel/robottelo/assignees{/user}","branches_url":"https://api.github.com/repos/omaciel/robottelo/branches{/branch}","tags_url":"https://api.github.com/repos/omaciel/robottelo/tags","blobs_url":"https://api.github.com/repos/omaciel/robottelo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/omaciel/robottelo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/omaciel/robottelo/git/refs{/sha}","trees_url":"https://api.github.com/repos/omaciel/robottelo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/omaciel/robottelo/statuses/{sha}","languages_url":"https://api.github.com/repos/omaciel/robottelo/languages","stargazers_url":"https://api.github.com/repos/omaciel/robottelo/stargazers","contributors_url":"https://api.github.com/repos/omaciel/robottelo/contributors","subscribers_url":"https://api.github.com/repos/omaciel/robottelo/subscribers","subscription_url":"https://api.github.com/repos/omaciel/robottelo/subscription","commits_url":"https://api.github.com/repos/omaciel/robottelo/commits{/sha}","git_commits_url":"https://api.github.com/repos/omaciel/robottelo/git/commits{/sha}","comments_url":"https://api.github.com/repos/omaciel/robottelo/comments{/number}","issue_comment_url":"https://api.github.com/repos/omaciel/robottelo/issues/comments/{number}","contents_url":"https://api.github.com/repos/omaciel/robottelo/contents/{+path}","compare_url":"https://api.github.com/repos/omaciel/robottelo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/omaciel/robottelo/merges","archive_url":"https://api.github.com/repos/omaciel/robottelo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/omaciel/robottelo/downloads","issues_url":"https://api.github.com/repos/omaciel/robottelo/issues{/number}","pulls_url":"https://api.github.com/repos/omaciel/robottelo/pulls{/number}","milestones_url":"https://api.github.com/repos/omaciel/robottelo/milestones{/number}","notifications_url":"https://api.github.com/repos/omaciel/robottelo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/omaciel/robottelo/labels{/name}","releases_url":"https://api.github.com/repos/omaciel/robottelo/releases{/id}","created_at":"2012-04-12T01:36:39Z","updated_at":"2014-08-26T01:02:24Z","pushed_at":"2014-08-29T18:11:53Z","git_url":"git://github.com/omaciel/robottelo.git","ssh_url":"git@github.com:omaciel/robottelo.git","clone_url":"https://github.com/omaciel/robottelo.git","svn_url":"https://github.com/omaciel/robottelo","homepage":null,"size":20489,"stargazers_count":16,"watchers_count":16,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":18,"mirror_url":null,"open_issues_count":99,"forks":18,"open_issues":99,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/omaciel/robottelo/pulls/1269"},"html":{"href":"https://github.com/omaciel/robottelo/pull/1269"},"issue":{"href":"https://api.github.com/repos/omaciel/robottelo/issues/1269"},"comments":{"href":"https://api.github.com/repos/omaciel/robottelo/issues/1269/comments"},"review_comments":{"href":"https://api.github.com/repos/omaciel/robottelo/pulls/1269/comments"},"review_comment":{"href":"https://api.github.com/repos/omaciel/robottelo/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/omaciel/robottelo/pulls/1269/commits"},"statuses":{"href":"https://api.github.com/repos/omaciel/robottelo/statuses/cdbb7171c31676a75175c7ced9723adb713eadf4"}}}}