GitHub PullRequestReviewCommentEvent at 2014-09-23 18:09:10
Repository: kc
Actor: gathreya
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/kuali/kc/pulls/comments/17927234","id":17927234,"diff_hunk":"@@ -217,37 +217,6 @@ private NarrativeAttachment findNarrativeAttachment(Narrative narrative){\n         narrativeAttachemntMap.put(MODULE_NUMBER, narrative.getModuleNumber()+\"\");\n         return (NarrativeAttachment)getBusinessObjectService().findByPrimaryKey(NarrativeAttachment.class, narrativeAttachemntMap);\n     }\n-    \n-    /**\n-     * This method is used to perform a bulk status change operation on all attachments\n-     * @param mapping\n-     * @param form\n-     * @param request\n-     * @param response\n-     * @return ActionForward\n-     * @throws Exception\n-     */\n-    public ActionForward markAllNarrativeStatuses(ActionMapping mapping, ActionForm form, HttpServletRequest request,\n-            HttpServletResponse response) throws Exception {\n-        \n-        ProposalDevelopmentForm developmentForm = (ProposalDevelopmentForm) form;\n-        developmentForm.getProposalDevelopmentDocument().getBudgetParent().markNarratives(developmentForm.getNarrativeStatusChange());\n-        developmentForm.clearNarrativeStatusChangeKey();\n-        return mapping.findForward(MAPPING_BASIC);\n-    }\n-    \n-    public ActionForward modifyProposalAttachmentStatus(ActionMapping mapping, ActionForm form, HttpServletRequest request,\n-            HttpServletResponse response) throws Exception {\n-        ProposalDevelopmentForm proposalDevelopmentForm = (ProposalDevelopmentForm) form;\n-        ProposalDevelopmentDocument pd = proposalDevelopmentForm.getProposalDevelopmentDocument();\n-        ActionForward forward = mapping.findForward(MAPPING_BASIC);\n-\n-        Narrative modifiedNarrative = pd.getDevelopmentProposal().getNarrative(getSelectedLine(request));\n-        \n-        pd.getDevelopmentProposal().modifyNarrativeStatus(getSelectedLine(request));\n-\n-        return forward;\n-    }","path":"coeus-impl/src/main/java/org/kuali/coeus/propdev/impl/abstrct/ProposalDevelopmentAbstractsAttachmentsAction.java","position":34,"original_position":34,"commit_id":"354c68a72f872a6f04797b09535f2b333b4fdc76","original_commit_id":"354c68a72f872a6f04797b09535f2b333b4fdc76","user":{"login":"gathreya","id":6466224,"avatar_url":"https://avatars.githubusercontent.com/u/6466224?v=2","gravatar_id":"","url":"https://api.github.com/users/gathreya","html_url":"https://github.com/gathreya","followers_url":"https://api.github.com/users/gathreya/followers","following_url":"https://api.github.com/users/gathreya/following{/other_user}","gists_url":"https://api.github.com/users/gathreya/gists{/gist_id}","starred_url":"https://api.github.com/users/gathreya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gathreya/subscriptions","organizations_url":"https://api.github.com/users/gathreya/orgs","repos_url":"https://api.github.com/users/gathreya/repos","events_url":"https://api.github.com/users/gathreya/events{/privacy}","received_events_url":"https://api.github.com/users/gathreya/received_events","type":"User","site_admin":false},"body":"Why did you remove these methods? ","created_at":"2014-09-23T18:09:10Z","updated_at":"2014-09-23T18:09:10Z","html_url":"https://github.com/kuali/kc/pull/782#discussion_r17927234","pull_request_url":"https://api.github.com/repos/kuali/kc/pulls/782","_links":{"self":{"href":"https://api.github.com/repos/kuali/kc/pulls/comments/17927234"},"html":{"href":"https://github.com/kuali/kc/pull/782#discussion_r17927234"},"pull_request":{"href":"https://api.github.com/repos/kuali/kc/pulls/782"}}},"pull_request":{"url":"https://api.github.com/repos/kuali/kc/pulls/782","id":21659552,"html_url":"https://github.com/kuali/kc/pull/782","diff_url":"https://github.com/kuali/kc/pull/782.diff","patch_url":"https://github.com/kuali/kc/pull/782.patch","issue_url":"https://api.github.com/repos/kuali/kc/issues/782","number":782,"state":"open","locked":false,"title":"KRACOEUS-7747: complete removal of task auth framework from prop dev & budget (not award budget)","user":{"login":"leoherbie","id":188602,"avatar_url":"https://avatars.githubusercontent.com/u/188602?v=2","gravatar_id":"","url":"https://api.github.com/users/leoherbie","html_url":"https://github.com/leoherbie","followers_url":"https://api.github.com/users/leoherbie/followers","following_url":"https://api.github.com/users/leoherbie/following{/other_user}","gists_url":"https://api.github.com/users/leoherbie/gists{/gist_id}","starred_url":"https://api.github.com/users/leoherbie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leoherbie/subscriptions","organizations_url":"https://api.github.com/users/leoherbie/orgs","repos_url":"https://api.github.com/users/leoherbie/repos","events_url":"https://api.github.com/users/leoherbie/events{/privacy}","received_events_url":"https://api.github.com/users/leoherbie/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-09-23T16:49:49Z","updated_at":"2014-09-23T18:09:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"acd79661a757e55fd04e12f965807fcc4dd07e2a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kuali/kc/pulls/782/commits","review_comments_url":"https://api.github.com/repos/kuali/kc/pulls/782/comments","review_comment_url":"https://api.github.com/repos/kuali/kc/pulls/comments/{number}","comments_url":"https://api.github.com/repos/kuali/kc/issues/782/comments","statuses_url":"https://api.github.com/repos/kuali/kc/statuses/354c68a72f872a6f04797b09535f2b333b4fdc76","head":{"label":"leoherbie:kill_the_task_framework_cont","ref":"kill_the_task_framework_cont","sha":"354c68a72f872a6f04797b09535f2b333b4fdc76","user":{"login":"leoherbie","id":188602,"avatar_url":"https://avatars.githubusercontent.com/u/188602?v=2","gravatar_id":"","url":"https://api.github.com/users/leoherbie","html_url":"https://github.com/leoherbie","followers_url":"https://api.github.com/users/leoherbie/followers","following_url":"https://api.github.com/users/leoherbie/following{/other_user}","gists_url":"https://api.github.com/users/leoherbie/gists{/gist_id}","starred_url":"https://api.github.com/users/leoherbie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leoherbie/subscriptions","organizations_url":"https://api.github.com/users/leoherbie/orgs","repos_url":"https://api.github.com/users/leoherbie/repos","events_url":"https://api.github.com/users/leoherbie/events{/privacy}","received_events_url":"https://api.github.com/users/leoherbie/received_events","type":"User","site_admin":false},"repo":{"id":16319639,"name":"kc","full_name":"leoherbie/kc","owner":{"login":"leoherbie","id":188602,"avatar_url":"https://avatars.githubusercontent.com/u/188602?v=2","gravatar_id":"","url":"https://api.github.com/users/leoherbie","html_url":"https://github.com/leoherbie","followers_url":"https://api.github.com/users/leoherbie/followers","following_url":"https://api.github.com/users/leoherbie/following{/other_user}","gists_url":"https://api.github.com/users/leoherbie/gists{/gist_id}","starred_url":"https://api.github.com/users/leoherbie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leoherbie/subscriptions","organizations_url":"https://api.github.com/users/leoherbie/orgs","repos_url":"https://api.github.com/users/leoherbie/repos","events_url":"https://api.github.com/users/leoherbie/events{/privacy}","received_events_url":"https://api.github.com/users/leoherbie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/leoherbie/kc","description":"Kuali Coeus","fork":true,"url":"https://api.github.com/repos/leoherbie/kc","forks_url":"https://api.github.com/repos/leoherbie/kc/forks","keys_url":"https://api.github.com/repos/leoherbie/kc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leoherbie/kc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leoherbie/kc/teams","hooks_url":"https://api.github.com/repos/leoherbie/kc/hooks","issue_events_url":"https://api.github.com/repos/leoherbie/kc/issues/events{/number}","events_url":"https://api.github.com/repos/leoherbie/kc/events","assignees_url":"https://api.github.com/repos/leoherbie/kc/assignees{/user}","branches_url":"https://api.github.com/repos/leoherbie/kc/branches{/branch}","tags_url":"https://api.github.com/repos/leoherbie/kc/tags","blobs_url":"https://api.github.com/repos/leoherbie/kc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leoherbie/kc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leoherbie/kc/git/refs{/sha}","trees_url":"https://api.github.com/repos/leoherbie/kc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leoherbie/kc/statuses/{sha}","languages_url":"https://api.github.com/repos/leoherbie/kc/languages","stargazers_url":"https://api.github.com/repos/leoherbie/kc/stargazers","contributors_url":"https://api.github.com/repos/leoherbie/kc/contributors","subscribers_url":"https://api.github.com/repos/leoherbie/kc/subscribers","subscription_url":"https://api.github.com/repos/leoherbie/kc/subscription","commits_url":"https://api.github.com/repos/leoherbie/kc/commits{/sha}","git_commits_url":"https://api.github.com/repos/leoherbie/kc/git/commits{/sha}","comments_url":"https://api.github.com/repos/leoherbie/kc/comments{/number}","issue_comment_url":"https://api.github.com/repos/leoherbie/kc/issues/comments/{number}","contents_url":"https://api.github.com/repos/leoherbie/kc/contents/{+path}","compare_url":"https://api.github.com/repos/leoherbie/kc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leoherbie/kc/merges","archive_url":"https://api.github.com/repos/leoherbie/kc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leoherbie/kc/downloads","issues_url":"https://api.github.com/repos/leoherbie/kc/issues{/number}","pulls_url":"https://api.github.com/repos/leoherbie/kc/pulls{/number}","milestones_url":"https://api.github.com/repos/leoherbie/kc/milestones{/number}","notifications_url":"https://api.github.com/repos/leoherbie/kc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leoherbie/kc/labels{/name}","releases_url":"https://api.github.com/repos/leoherbie/kc/releases{/id}","created_at":"2014-01-28T17:33:17Z","updated_at":"2014-06-25T12:32:57Z","pushed_at":"2014-09-23T16:47:00Z","git_url":"git://github.com/leoherbie/kc.git","ssh_url":"git@github.com:leoherbie/kc.git","clone_url":"https://github.com/leoherbie/kc.git","svn_url":"https://github.com/leoherbie/kc","homepage":"http://www.kuali.org/kc","size":595441,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kuali:master","ref":"master","sha":"4874f1b37fba1c34d671cfaf477b3f39ee4e9b6b","user":{"login":"kuali","id":371097,"avatar_url":"https://avatars.githubusercontent.com/u/371097?v=2","gravatar_id":"","url":"https://api.github.com/users/kuali","html_url":"https://github.com/kuali","followers_url":"https://api.github.com/users/kuali/followers","following_url":"https://api.github.com/users/kuali/following{/other_user}","gists_url":"https://api.github.com/users/kuali/gists{/gist_id}","starred_url":"https://api.github.com/users/kuali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuali/subscriptions","organizations_url":"https://api.github.com/users/kuali/orgs","repos_url":"https://api.github.com/users/kuali/repos","events_url":"https://api.github.com/users/kuali/events{/privacy}","received_events_url":"https://api.github.com/users/kuali/received_events","type":"Organization","site_admin":false},"repo":{"id":16106733,"name":"kc","full_name":"kuali/kc","owner":{"login":"kuali","id":371097,"avatar_url":"https://avatars.githubusercontent.com/u/371097?v=2","gravatar_id":"","url":"https://api.github.com/users/kuali","html_url":"https://github.com/kuali","followers_url":"https://api.github.com/users/kuali/followers","following_url":"https://api.github.com/users/kuali/following{/other_user}","gists_url":"https://api.github.com/users/kuali/gists{/gist_id}","starred_url":"https://api.github.com/users/kuali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuali/subscriptions","organizations_url":"https://api.github.com/users/kuali/orgs","repos_url":"https://api.github.com/users/kuali/repos","events_url":"https://api.github.com/users/kuali/events{/privacy}","received_events_url":"https://api.github.com/users/kuali/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kuali/kc","description":"Kuali Coeus","fork":false,"url":"https://api.github.com/repos/kuali/kc","forks_url":"https://api.github.com/repos/kuali/kc/forks","keys_url":"https://api.github.com/repos/kuali/kc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kuali/kc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kuali/kc/teams","hooks_url":"https://api.github.com/repos/kuali/kc/hooks","issue_events_url":"https://api.github.com/repos/kuali/kc/issues/events{/number}","events_url":"https://api.github.com/repos/kuali/kc/events","assignees_url":"https://api.github.com/repos/kuali/kc/assignees{/user}","branches_url":"https://api.github.com/repos/kuali/kc/branches{/branch}","tags_url":"https://api.github.com/repos/kuali/kc/tags","blobs_url":"https://api.github.com/repos/kuali/kc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kuali/kc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kuali/kc/git/refs{/sha}","trees_url":"https://api.github.com/repos/kuali/kc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kuali/kc/statuses/{sha}","languages_url":"https://api.github.com/repos/kuali/kc/languages","stargazers_url":"https://api.github.com/repos/kuali/kc/stargazers","contributors_url":"https://api.github.com/repos/kuali/kc/contributors","subscribers_url":"https://api.github.com/repos/kuali/kc/subscribers","subscription_url":"https://api.github.com/repos/kuali/kc/subscription","commits_url":"https://api.github.com/repos/kuali/kc/commits{/sha}","git_commits_url":"https://api.github.com/repos/kuali/kc/git/commits{/sha}","comments_url":"https://api.github.com/repos/kuali/kc/comments{/number}","issue_comment_url":"https://api.github.com/repos/kuali/kc/issues/comments/{number}","contents_url":"https://api.github.com/repos/kuali/kc/contents/{+path}","compare_url":"https://api.github.com/repos/kuali/kc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kuali/kc/merges","archive_url":"https://api.github.com/repos/kuali/kc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kuali/kc/downloads","issues_url":"https://api.github.com/repos/kuali/kc/issues{/number}","pulls_url":"https://api.github.com/repos/kuali/kc/pulls{/number}","milestones_url":"https://api.github.com/repos/kuali/kc/milestones{/number}","notifications_url":"https://api.github.com/repos/kuali/kc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kuali/kc/labels{/name}","releases_url":"https://api.github.com/repos/kuali/kc/releases{/id}","created_at":"2014-01-21T15:32:22Z","updated_at":"2014-09-17T19:46:00Z","pushed_at":"2014-09-23T16:31:45Z","git_url":"git://github.com/kuali/kc.git","ssh_url":"git@github.com:kuali/kc.git","clone_url":"https://github.com/kuali/kc.git","svn_url":"https://github.com/kuali/kc","homepage":"http://www.kuali.org/kc","size":697267,"stargazers_count":8,"watchers_count":8,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":20,"forks":35,"open_issues":20,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kuali/kc/pulls/782"},"html":{"href":"https://github.com/kuali/kc/pull/782"},"issue":{"href":"https://api.github.com/repos/kuali/kc/issues/782"},"comments":{"href":"https://api.github.com/repos/kuali/kc/issues/782/comments"},"review_comments":{"href":"https://api.github.com/repos/kuali/kc/pulls/782/comments"},"review_comment":{"href":"https://api.github.com/repos/kuali/kc/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/kuali/kc/pulls/782/commits"},"statuses":{"href":"https://api.github.com/repos/kuali/kc/statuses/354c68a72f872a6f04797b09535f2b333b4fdc76"}}}}