GitHub PullRequestReviewCommentEvent at 2014-06-18 01:00:17
Repository: zendesk_api_client_php
Actor: isaacsu
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/zendesk/zendesk_api_client_php/pulls/comments/13895299","id":13895299,"diff_hunk":"@@ -59,6 +59,16 @@ public function testFind() {\n         $this->assertGreaterThan(0, $user->user->id, 'Returns a non-numeric id for user');\n         $this->assertEquals($this->client->getDebug()->lastResponseCode, '200', 'Does not return HTTP code 200');\n     }\n+    \n+    /**\n+     * @depends testAuthToken\n+     */\n+    public function testFindMultiple() {\n+        $users = $this->client->user(array(454094082))->find(); // Should add an additional user id here","path":"tests/Zendesk/API/Tests/UsersTest.php","position":9,"original_position":9,"commit_id":"418ca55bac22559543caff5a265a116783fc967a","original_commit_id":"418ca55bac22559543caff5a265a116783fc967a","user":{"login":"isaacsu","id":291728,"avatar_url":"https://avatars.githubusercontent.com/u/291728?","gravatar_id":"335f56676405e0fcdcf9c69a46cf57e8","url":"https://api.github.com/users/isaacsu","html_url":"https://github.com/isaacsu","followers_url":"https://api.github.com/users/isaacsu/followers","following_url":"https://api.github.com/users/isaacsu/following{/other_user}","gists_url":"https://api.github.com/users/isaacsu/gists{/gist_id}","starred_url":"https://api.github.com/users/isaacsu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaacsu/subscriptions","organizations_url":"https://api.github.com/users/isaacsu/orgs","repos_url":"https://api.github.com/users/isaacsu/repos","events_url":"https://api.github.com/users/isaacsu/events{/privacy}","received_events_url":"https://api.github.com/users/isaacsu/received_events","type":"User","site_admin":false},"body":"Functionally it's identical, but can this be `$this->client->users(..)` instead of `user(..)` for clarity?\r\n\r\n:+1: ","created_at":"2014-06-18T01:00:17Z","updated_at":"2014-06-18T01:00:17Z","html_url":"https://github.com/zendesk/zendesk_api_client_php/pull/23#discussion_r13895299","pull_request_url":"https://api.github.com/repos/zendesk/zendesk_api_client_php/pulls/23","_links":{"self":{"href":"https://api.github.com/repos/zendesk/zendesk_api_client_php/pulls/comments/13895299"},"html":{"href":"https://github.com/zendesk/zendesk_api_client_php/pull/23#discussion_r13895299"},"pull_request":{"href":"https://api.github.com/repos/zendesk/zendesk_api_client_php/pulls/23"}}},"pull_request":{"url":"https://api.github.com/repos/zendesk/zendesk_api_client_php/pulls/23","id":16916988,"html_url":"https://github.com/zendesk/zendesk_api_client_php/pull/23","diff_url":"https://github.com/zendesk/zendesk_api_client_php/pull/23.diff","patch_url":"https://github.com/zendesk/zendesk_api_client_php/pull/23.patch","issue_url":"https://api.github.com/repos/zendesk/zendesk_api_client_php/issues/23","number":23,"state":"open","title":"Implemented show_many.json endpoint for Users. Added users test testFind...","user":{"login":"jackshakes","id":1494218,"avatar_url":"https://avatars.githubusercontent.com/u/1494218?","gravatar_id":"e67956ccd48d82374fa3f8d7fc2bf9a2","url":"https://api.github.com/users/jackshakes","html_url":"https://github.com/jackshakes","followers_url":"https://api.github.com/users/jackshakes/followers","following_url":"https://api.github.com/users/jackshakes/following{/other_user}","gists_url":"https://api.github.com/users/jackshakes/gists{/gist_id}","starred_url":"https://api.github.com/users/jackshakes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackshakes/subscriptions","organizations_url":"https://api.github.com/users/jackshakes/orgs","repos_url":"https://api.github.com/users/jackshakes/repos","events_url":"https://api.github.com/users/jackshakes/events{/privacy}","received_events_url":"https://api.github.com/users/jackshakes/received_events","type":"User","site_admin":false},"body":"Implemented 'show_many.json' for tickets endpoint in find() method when passed an array of IDs. Also added associated test. I did not have another test user ID, so I am passing an array of one user in the test. Appears to still work.","created_at":"2014-06-10T00:44:20Z","updated_at":"2014-06-18T01:00:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1dd6251eec6ab8d3a17a19c911e0760400c1de44","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zendesk/zendesk_api_client_php/pulls/23/commits","review_comments_url":"https://api.github.com/repos/zendesk/zendesk_api_client_php/pulls/23/comments","review_comment_url":"https://api.github.com/repos/zendesk/zendesk_api_client_php/pulls/comments/{number}","comments_url":"https://api.github.com/repos/zendesk/zendesk_api_client_php/issues/23/comments","statuses_url":"https://api.github.com/repos/zendesk/zendesk_api_client_php/statuses/418ca55bac22559543caff5a265a116783fc967a","head":{"label":"jackshakes:upstream","ref":"upstream","sha":"418ca55bac22559543caff5a265a116783fc967a","user":{"login":"jackshakes","id":1494218,"avatar_url":"https://avatars.githubusercontent.com/u/1494218?","gravatar_id":"e67956ccd48d82374fa3f8d7fc2bf9a2","url":"https://api.github.com/users/jackshakes","html_url":"https://github.com/jackshakes","followers_url":"https://api.github.com/users/jackshakes/followers","following_url":"https://api.github.com/users/jackshakes/following{/other_user}","gists_url":"https://api.github.com/users/jackshakes/gists{/gist_id}","starred_url":"https://api.github.com/users/jackshakes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackshakes/subscriptions","organizations_url":"https://api.github.com/users/jackshakes/orgs","repos_url":"https://api.github.com/users/jackshakes/repos","events_url":"https://api.github.com/users/jackshakes/events{/privacy}","received_events_url":"https://api.github.com/users/jackshakes/received_events","type":"User","site_admin":false},"repo":{"id":20454508,"name":"zendesk_api_client_php","full_name":"jackshakes/zendesk_api_client_php","owner":{"login":"jackshakes","id":1494218,"avatar_url":"https://avatars.githubusercontent.com/u/1494218?","gravatar_id":"e67956ccd48d82374fa3f8d7fc2bf9a2","url":"https://api.github.com/users/jackshakes","html_url":"https://github.com/jackshakes","followers_url":"https://api.github.com/users/jackshakes/followers","following_url":"https://api.github.com/users/jackshakes/following{/other_user}","gists_url":"https://api.github.com/users/jackshakes/gists{/gist_id}","starred_url":"https://api.github.com/users/jackshakes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackshakes/subscriptions","organizations_url":"https://api.github.com/users/jackshakes/orgs","repos_url":"https://api.github.com/users/jackshakes/repos","events_url":"https://api.github.com/users/jackshakes/events{/privacy}","received_events_url":"https://api.github.com/users/jackshakes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jackshakes/zendesk_api_client_php","description":"","fork":true,"url":"https://api.github.com/repos/jackshakes/zendesk_api_client_php","forks_url":"https://api.github.com/repos/jackshakes/zendesk_api_client_php/forks","keys_url":"https://api.github.com/repos/jackshakes/zendesk_api_client_php/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jackshakes/zendesk_api_client_php/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jackshakes/zendesk_api_client_php/teams","hooks_url":"https://api.github.com/repos/jackshakes/zendesk_api_client_php/hooks","issue_events_url":"https://api.github.com/repos/jackshakes/zendesk_api_client_php/issues/events{/number}","events_url":"https://api.github.com/repos/jackshakes/zendesk_api_client_php/events","assignees_url":"https://api.github.com/repos/jackshakes/zendesk_api_client_php/assignees{/user}","branches_url":"https://api.github.com/repos/jackshakes/zendesk_api_client_php/branches{/branch}","tags_url":"https://api.github.com/repos/jackshakes/zendesk_api_client_php/tags","blobs_url":"https://api.github.com/repos/jackshakes/zendesk_api_client_php/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jackshakes/zendesk_api_client_php/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jackshakes/zendesk_api_client_php/git/refs{/sha}","trees_url":"https://api.github.com/repos/jackshakes/zendesk_api_client_php/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jackshakes/zendesk_api_client_php/statuses/{sha}","languages_url":"https://api.github.com/repos/jackshakes/zendesk_api_client_php/languages","stargazers_url":"https://api.github.com/repos/jackshakes/zendesk_api_client_php/stargazers","contributors_url":"https://api.github.com/repos/jackshakes/zendesk_api_client_php/contributors","subscribers_url":"https://api.github.com/repos/jackshakes/zendesk_api_client_php/subscribers","subscription_url":"https://api.github.com/repos/jackshakes/zendesk_api_client_php/subscription","commits_url":"https://api.github.com/repos/jackshakes/zendesk_api_client_php/commits{/sha}","git_commits_url":"https://api.github.com/repos/jackshakes/zendesk_api_client_php/git/commits{/sha}","comments_url":"https://api.github.com/repos/jackshakes/zendesk_api_client_php/comments{/number}","issue_comment_url":"https://api.github.com/repos/jackshakes/zendesk_api_client_php/issues/comments/{number}","contents_url":"https://api.github.com/repos/jackshakes/zendesk_api_client_php/contents/{+path}","compare_url":"https://api.github.com/repos/jackshakes/zendesk_api_client_php/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jackshakes/zendesk_api_client_php/merges","archive_url":"https://api.github.com/repos/jackshakes/zendesk_api_client_php/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jackshakes/zendesk_api_client_php/downloads","issues_url":"https://api.github.com/repos/jackshakes/zendesk_api_client_php/issues{/number}","pulls_url":"https://api.github.com/repos/jackshakes/zendesk_api_client_php/pulls{/number}","milestones_url":"https://api.github.com/repos/jackshakes/zendesk_api_client_php/milestones{/number}","notifications_url":"https://api.github.com/repos/jackshakes/zendesk_api_client_php/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jackshakes/zendesk_api_client_php/labels{/name}","releases_url":"https://api.github.com/repos/jackshakes/zendesk_api_client_php/releases{/id}","created_at":"2014-06-03T18:32:53Z","updated_at":"2014-06-10T00:45:53Z","pushed_at":"2014-06-10T00:45:53Z","git_url":"git://github.com/jackshakes/zendesk_api_client_php.git","ssh_url":"git@github.com:jackshakes/zendesk_api_client_php.git","clone_url":"https://github.com/jackshakes/zendesk_api_client_php.git","svn_url":"https://github.com/jackshakes/zendesk_api_client_php","homepage":null,"size":331,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zendesk:master","ref":"master","sha":"856953c2220c3db941461a12ddba3eff1ac26edd","user":{"login":"zendesk","id":11525,"avatar_url":"https://avatars.githubusercontent.com/u/11525?","gravatar_id":"1e7ebb09678c1def6181efcefcfe0d59","url":"https://api.github.com/users/zendesk","html_url":"https://github.com/zendesk","followers_url":"https://api.github.com/users/zendesk/followers","following_url":"https://api.github.com/users/zendesk/following{/other_user}","gists_url":"https://api.github.com/users/zendesk/gists{/gist_id}","starred_url":"https://api.github.com/users/zendesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendesk/subscriptions","organizations_url":"https://api.github.com/users/zendesk/orgs","repos_url":"https://api.github.com/users/zendesk/repos","events_url":"https://api.github.com/users/zendesk/events{/privacy}","received_events_url":"https://api.github.com/users/zendesk/received_events","type":"Organization","site_admin":false},"repo":{"id":16820767,"name":"zendesk_api_client_php","full_name":"zendesk/zendesk_api_client_php","owner":{"login":"zendesk","id":11525,"avatar_url":"https://avatars.githubusercontent.com/u/11525?","gravatar_id":"1e7ebb09678c1def6181efcefcfe0d59","url":"https://api.github.com/users/zendesk","html_url":"https://github.com/zendesk","followers_url":"https://api.github.com/users/zendesk/followers","following_url":"https://api.github.com/users/zendesk/following{/other_user}","gists_url":"https://api.github.com/users/zendesk/gists{/gist_id}","starred_url":"https://api.github.com/users/zendesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendesk/subscriptions","organizations_url":"https://api.github.com/users/zendesk/orgs","repos_url":"https://api.github.com/users/zendesk/repos","events_url":"https://api.github.com/users/zendesk/events{/privacy}","received_events_url":"https://api.github.com/users/zendesk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zendesk/zendesk_api_client_php","description":"","fork":false,"url":"https://api.github.com/repos/zendesk/zendesk_api_client_php","forks_url":"https://api.github.com/repos/zendesk/zendesk_api_client_php/forks","keys_url":"https://api.github.com/repos/zendesk/zendesk_api_client_php/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zendesk/zendesk_api_client_php/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zendesk/zendesk_api_client_php/teams","hooks_url":"https://api.github.com/repos/zendesk/zendesk_api_client_php/hooks","issue_events_url":"https://api.github.com/repos/zendesk/zendesk_api_client_php/issues/events{/number}","events_url":"https://api.github.com/repos/zendesk/zendesk_api_client_php/events","assignees_url":"https://api.github.com/repos/zendesk/zendesk_api_client_php/assignees{/user}","branches_url":"https://api.github.com/repos/zendesk/zendesk_api_client_php/branches{/branch}","tags_url":"https://api.github.com/repos/zendesk/zendesk_api_client_php/tags","blobs_url":"https://api.github.com/repos/zendesk/zendesk_api_client_php/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zendesk/zendesk_api_client_php/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zendesk/zendesk_api_client_php/git/refs{/sha}","trees_url":"https://api.github.com/repos/zendesk/zendesk_api_client_php/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zendesk/zendesk_api_client_php/statuses/{sha}","languages_url":"https://api.github.com/repos/zendesk/zendesk_api_client_php/languages","stargazers_url":"https://api.github.com/repos/zendesk/zendesk_api_client_php/stargazers","contributors_url":"https://api.github.com/repos/zendesk/zendesk_api_client_php/contributors","subscribers_url":"https://api.github.com/repos/zendesk/zendesk_api_client_php/subscribers","subscription_url":"https://api.github.com/repos/zendesk/zendesk_api_client_php/subscription","commits_url":"https://api.github.com/repos/zendesk/zendesk_api_client_php/commits{/sha}","git_commits_url":"https://api.github.com/repos/zendesk/zendesk_api_client_php/git/commits{/sha}","comments_url":"https://api.github.com/repos/zendesk/zendesk_api_client_php/comments{/number}","issue_comment_url":"https://api.github.com/repos/zendesk/zendesk_api_client_php/issues/comments/{number}","contents_url":"https://api.github.com/repos/zendesk/zendesk_api_client_php/contents/{+path}","compare_url":"https://api.github.com/repos/zendesk/zendesk_api_client_php/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zendesk/zendesk_api_client_php/merges","archive_url":"https://api.github.com/repos/zendesk/zendesk_api_client_php/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zendesk/zendesk_api_client_php/downloads","issues_url":"https://api.github.com/repos/zendesk/zendesk_api_client_php/issues{/number}","pulls_url":"https://api.github.com/repos/zendesk/zendesk_api_client_php/pulls{/number}","milestones_url":"https://api.github.com/repos/zendesk/zendesk_api_client_php/milestones{/number}","notifications_url":"https://api.github.com/repos/zendesk/zendesk_api_client_php/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zendesk/zendesk_api_client_php/labels{/name}","releases_url":"https://api.github.com/repos/zendesk/zendesk_api_client_php/releases{/id}","created_at":"2014-02-13T23:21:28Z","updated_at":"2014-06-16T01:54:30Z","pushed_at":"2014-06-16T01:54:30Z","git_url":"git://github.com/zendesk/zendesk_api_client_php.git","ssh_url":"git@github.com:zendesk/zendesk_api_client_php.git","clone_url":"https://github.com/zendesk/zendesk_api_client_php.git","svn_url":"https://github.com/zendesk/zendesk_api_client_php","homepage":null,"size":680,"stargazers_count":22,"watchers_count":22,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":17,"mirror_url":null,"open_issues_count":12,"forks":17,"open_issues":12,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zendesk/zendesk_api_client_php/pulls/23"},"html":{"href":"https://github.com/zendesk/zendesk_api_client_php/pull/23"},"issue":{"href":"https://api.github.com/repos/zendesk/zendesk_api_client_php/issues/23"},"comments":{"href":"https://api.github.com/repos/zendesk/zendesk_api_client_php/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/zendesk/zendesk_api_client_php/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/zendesk/zendesk_api_client_php/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/zendesk/zendesk_api_client_php/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/zendesk/zendesk_api_client_php/statuses/418ca55bac22559543caff5a265a116783fc967a"}}}}