GitHub PullRequestReviewCommentEvent at 2014-07-24 12:53:12
Repository: odoo
Actor: rvalyi
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/odoo/odoo/pulls/comments/15344100","id":15344100,"diff_hunk":"@@ -587,7 +587,7 @@ def product_id_change(self, cr, uid, ids, pricelist, product, uom=False,\n             product_obj = self.pool.get('product.product').browse(cr, uid, product)\n             if partner_id:\n                 partner = self.pool.get('res.partner').browse(cr, uid, partner_id)\n-                result['tax_id'] = self.pool.get('account.fiscal.position').map_tax(cr, uid, partner.property_account_position, product_obj.taxes_id)\n+                result['tax_id'] = self.pool.get('product.product').get_taxes_ids(cr, uid, [product], partner.property_account_position)","path":"addons/mrp_repair/mrp_repair.py","position":5,"original_position":5,"commit_id":"2d08b8084e21ad8790aff5d71b4fa6f995f3bd4f","original_commit_id":"2d08b8084e21ad8790aff5d71b4fa6f995f3bd4f","user":{"login":"rvalyi","id":16926,"avatar_url":"https://avatars.githubusercontent.com/u/16926?","gravatar_id":"32d3a9b3f154ec5cf0cc9dfc407b02ca","url":"https://api.github.com/users/rvalyi","html_url":"https://github.com/rvalyi","followers_url":"https://api.github.com/users/rvalyi/followers","following_url":"https://api.github.com/users/rvalyi/following{/other_user}","gists_url":"https://api.github.com/users/rvalyi/gists{/gist_id}","starred_url":"https://api.github.com/users/rvalyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvalyi/subscriptions","organizations_url":"https://api.github.com/users/rvalyi/orgs","repos_url":"https://api.github.com/users/rvalyi/repos","events_url":"https://api.github.com/users/rvalyi/events{/privacy}","received_events_url":"https://api.github.com/users/rvalyi/received_events","type":"User","site_admin":false},"body":"in v8, it may still be time to pass the context here and in the entry point  method. But ok for v7","created_at":"2014-07-24T12:53:12Z","updated_at":"2014-07-24T12:53:12Z","html_url":"https://github.com/odoo/odoo/pull/1353#discussion_r15344100","pull_request_url":"https://api.github.com/repos/odoo/odoo/pulls/1353","_links":{"self":{"href":"https://api.github.com/repos/odoo/odoo/pulls/comments/15344100"},"html":{"href":"https://github.com/odoo/odoo/pull/1353#discussion_r15344100"},"pull_request":{"href":"https://api.github.com/repos/odoo/odoo/pulls/1353"}}},"pull_request":{"url":"https://api.github.com/repos/odoo/odoo/pulls/1353","id":18833827,"html_url":"https://github.com/odoo/odoo/pull/1353","diff_url":"https://github.com/odoo/odoo/pull/1353.diff","patch_url":"https://github.com/odoo/odoo/pull/1353.patch","issue_url":"https://api.github.com/repos/odoo/odoo/issues/1353","number":1353,"state":"open","title":"Fix the default tax bug lp:796570.","user":{"login":"anthony-muschang","id":7601513,"avatar_url":"https://avatars.githubusercontent.com/u/7601513?","gravatar_id":"7a237d1af79ef7ea63a7d750b96e90c4","url":"https://api.github.com/users/anthony-muschang","html_url":"https://github.com/anthony-muschang","followers_url":"https://api.github.com/users/anthony-muschang/followers","following_url":"https://api.github.com/users/anthony-muschang/following{/other_user}","gists_url":"https://api.github.com/users/anthony-muschang/gists{/gist_id}","starred_url":"https://api.github.com/users/anthony-muschang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthony-muschang/subscriptions","organizations_url":"https://api.github.com/users/anthony-muschang/orgs","repos_url":"https://api.github.com/users/anthony-muschang/repos","events_url":"https://api.github.com/users/anthony-muschang/events{/privacy}","received_events_url":"https://api.github.com/users/anthony-muschang/received_events","type":"User","site_admin":false},"body":"Fix the default tax bug https://code.launchpad.net/bugs/796570\r\n\r\nAs requested by Fabien (https://bugs.launchpad.net/openobject-addons/+bug/796570/comments/5) the bug have been corrected on all the modules where the default tax is ignored.\r\n\r\nSome functions have been added on the module 'product_product' (get_supplier_taxes_ids and get_taxes_ids). Those functions are now used in the corrected modules and in account, hr_expense and hr_timesheet_invoice in order to have the same logic everywhere.","created_at":"2014-07-24T12:29:21Z","updated_at":"2014-07-24T12:53:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9b9af85db01a6a873b1c093dfb306ba603daa072","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/odoo/odoo/pulls/1353/commits","review_comments_url":"https://api.github.com/repos/odoo/odoo/pulls/1353/comments","review_comment_url":"https://api.github.com/repos/odoo/odoo/pulls/comments/{number}","comments_url":"https://api.github.com/repos/odoo/odoo/issues/1353/comments","statuses_url":"https://api.github.com/repos/odoo/odoo/statuses/2d08b8084e21ad8790aff5d71b4fa6f995f3bd4f","head":{"label":"acsone:7.0-bug-lp796570-amu","ref":"7.0-bug-lp796570-amu","sha":"2d08b8084e21ad8790aff5d71b4fa6f995f3bd4f","user":{"login":"acsone","id":7601056,"avatar_url":"https://avatars.githubusercontent.com/u/7601056?","gravatar_id":null,"url":"https://api.github.com/users/acsone","html_url":"https://github.com/acsone","followers_url":"https://api.github.com/users/acsone/followers","following_url":"https://api.github.com/users/acsone/following{/other_user}","gists_url":"https://api.github.com/users/acsone/gists{/gist_id}","starred_url":"https://api.github.com/users/acsone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acsone/subscriptions","organizations_url":"https://api.github.com/users/acsone/orgs","repos_url":"https://api.github.com/users/acsone/repos","events_url":"https://api.github.com/users/acsone/events{/privacy}","received_events_url":"https://api.github.com/users/acsone/received_events","type":"Organization","site_admin":false},"repo":{"id":20557009,"name":"odoo","full_name":"acsone/odoo","owner":{"login":"acsone","id":7601056,"avatar_url":"https://avatars.githubusercontent.com/u/7601056?","gravatar_id":null,"url":"https://api.github.com/users/acsone","html_url":"https://github.com/acsone","followers_url":"https://api.github.com/users/acsone/followers","following_url":"https://api.github.com/users/acsone/following{/other_user}","gists_url":"https://api.github.com/users/acsone/gists{/gist_id}","starred_url":"https://api.github.com/users/acsone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acsone/subscriptions","organizations_url":"https://api.github.com/users/acsone/orgs","repos_url":"https://api.github.com/users/acsone/repos","events_url":"https://api.github.com/users/acsone/events{/privacy}","received_events_url":"https://api.github.com/users/acsone/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/acsone/odoo","description":"Odoo (formerly OpenERP). Open Source Business Apps.","fork":true,"url":"https://api.github.com/repos/acsone/odoo","forks_url":"https://api.github.com/repos/acsone/odoo/forks","keys_url":"https://api.github.com/repos/acsone/odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/acsone/odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/acsone/odoo/teams","hooks_url":"https://api.github.com/repos/acsone/odoo/hooks","issue_events_url":"https://api.github.com/repos/acsone/odoo/issues/events{/number}","events_url":"https://api.github.com/repos/acsone/odoo/events","assignees_url":"https://api.github.com/repos/acsone/odoo/assignees{/user}","branches_url":"https://api.github.com/repos/acsone/odoo/branches{/branch}","tags_url":"https://api.github.com/repos/acsone/odoo/tags","blobs_url":"https://api.github.com/repos/acsone/odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/acsone/odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/acsone/odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/acsone/odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/acsone/odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/acsone/odoo/languages","stargazers_url":"https://api.github.com/repos/acsone/odoo/stargazers","contributors_url":"https://api.github.com/repos/acsone/odoo/contributors","subscribers_url":"https://api.github.com/repos/acsone/odoo/subscribers","subscription_url":"https://api.github.com/repos/acsone/odoo/subscription","commits_url":"https://api.github.com/repos/acsone/odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/acsone/odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/acsone/odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/acsone/odoo/issues/comments/{number}","contents_url":"https://api.github.com/repos/acsone/odoo/contents/{+path}","compare_url":"https://api.github.com/repos/acsone/odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/acsone/odoo/merges","archive_url":"https://api.github.com/repos/acsone/odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/acsone/odoo/downloads","issues_url":"https://api.github.com/repos/acsone/odoo/issues{/number}","pulls_url":"https://api.github.com/repos/acsone/odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/acsone/odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/acsone/odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/acsone/odoo/labels{/name}","releases_url":"https://api.github.com/repos/acsone/odoo/releases{/id}","created_at":"2014-06-06T08:44:17Z","updated_at":"2014-07-01T11:42:32Z","pushed_at":"2014-07-24T12:14:26Z","git_url":"git://github.com/acsone/odoo.git","ssh_url":"git@github.com:acsone/odoo.git","clone_url":"https://github.com/acsone/odoo.git","svn_url":"https://github.com/acsone/odoo","homepage":"https://www.odoo.com","size":500778,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"odoo:7.0","ref":"7.0","sha":"1acf76bfc2b89af50ffe7f3e41c0b1c984ee418f","user":{"login":"odoo","id":6368483,"avatar_url":"https://avatars.githubusercontent.com/u/6368483?","gravatar_id":null,"url":"https://api.github.com/users/odoo","html_url":"https://github.com/odoo","followers_url":"https://api.github.com/users/odoo/followers","following_url":"https://api.github.com/users/odoo/following{/other_user}","gists_url":"https://api.github.com/users/odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo/subscriptions","organizations_url":"https://api.github.com/users/odoo/orgs","repos_url":"https://api.github.com/users/odoo/repos","events_url":"https://api.github.com/users/odoo/events{/privacy}","received_events_url":"https://api.github.com/users/odoo/received_events","type":"Organization","site_admin":false},"repo":{"id":19745004,"name":"odoo","full_name":"odoo/odoo","owner":{"login":"odoo","id":6368483,"avatar_url":"https://avatars.githubusercontent.com/u/6368483?","gravatar_id":null,"url":"https://api.github.com/users/odoo","html_url":"https://github.com/odoo","followers_url":"https://api.github.com/users/odoo/followers","following_url":"https://api.github.com/users/odoo/following{/other_user}","gists_url":"https://api.github.com/users/odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo/subscriptions","organizations_url":"https://api.github.com/users/odoo/orgs","repos_url":"https://api.github.com/users/odoo/repos","events_url":"https://api.github.com/users/odoo/events{/privacy}","received_events_url":"https://api.github.com/users/odoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/odoo/odoo","description":"Odoo (formerly OpenERP). Open Source Business Apps.","fork":false,"url":"https://api.github.com/repos/odoo/odoo","forks_url":"https://api.github.com/repos/odoo/odoo/forks","keys_url":"https://api.github.com/repos/odoo/odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/odoo/odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/odoo/odoo/teams","hooks_url":"https://api.github.com/repos/odoo/odoo/hooks","issue_events_url":"https://api.github.com/repos/odoo/odoo/issues/events{/number}","events_url":"https://api.github.com/repos/odoo/odoo/events","assignees_url":"https://api.github.com/repos/odoo/odoo/assignees{/user}","branches_url":"https://api.github.com/repos/odoo/odoo/branches{/branch}","tags_url":"https://api.github.com/repos/odoo/odoo/tags","blobs_url":"https://api.github.com/repos/odoo/odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/odoo/odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/odoo/odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/odoo/odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/odoo/odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/odoo/odoo/languages","stargazers_url":"https://api.github.com/repos/odoo/odoo/stargazers","contributors_url":"https://api.github.com/repos/odoo/odoo/contributors","subscribers_url":"https://api.github.com/repos/odoo/odoo/subscribers","subscription_url":"https://api.github.com/repos/odoo/odoo/subscription","commits_url":"https://api.github.com/repos/odoo/odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/odoo/odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/odoo/odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/odoo/odoo/issues/comments/{number}","contents_url":"https://api.github.com/repos/odoo/odoo/contents/{+path}","compare_url":"https://api.github.com/repos/odoo/odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/odoo/odoo/merges","archive_url":"https://api.github.com/repos/odoo/odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/odoo/odoo/downloads","issues_url":"https://api.github.com/repos/odoo/odoo/issues{/number}","pulls_url":"https://api.github.com/repos/odoo/odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/odoo/odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/odoo/odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/odoo/odoo/labels{/name}","releases_url":"https://api.github.com/repos/odoo/odoo/releases{/id}","created_at":"2014-05-13T15:38:58Z","updated_at":"2014-07-24T07:30:19Z","pushed_at":"2014-07-24T10:12:37Z","git_url":"git://github.com/odoo/odoo.git","ssh_url":"git@github.com:odoo/odoo.git","clone_url":"https://github.com/odoo/odoo.git","svn_url":"https://github.com/odoo/odoo","homepage":"https://www.odoo.com","size":782843,"stargazers_count":940,"watchers_count":940,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":679,"mirror_url":null,"open_issues_count":576,"forks":679,"open_issues":576,"watchers":940,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/odoo/odoo/pulls/1353"},"html":{"href":"https://github.com/odoo/odoo/pull/1353"},"issue":{"href":"https://api.github.com/repos/odoo/odoo/issues/1353"},"comments":{"href":"https://api.github.com/repos/odoo/odoo/issues/1353/comments"},"review_comments":{"href":"https://api.github.com/repos/odoo/odoo/pulls/1353/comments"},"review_comment":{"href":"https://api.github.com/repos/odoo/odoo/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/odoo/odoo/pulls/1353/commits"},"statuses":{"href":"https://api.github.com/repos/odoo/odoo/statuses/2d08b8084e21ad8790aff5d71b4fa6f995f3bd4f"}}}}