GitHub PullRequestEvent at 2014-06-07 03:31:21
Repository: monban
Actor: derekprior
Payload: {"action":"opened","number":21,"pull_request":{"url":"https://api.github.com/repos/halogenandtoast/monban/pulls/21","id":16850830,"html_url":"https://github.com/halogenandtoast/monban/pull/21","diff_url":"https://github.com/halogenandtoast/monban/pull/21.diff","patch_url":"https://github.com/halogenandtoast/monban/pull/21.patch","issue_url":"https://api.github.com/repos/halogenandtoast/monban/issues/21","number":21,"state":"open","title":"Make `require_login` redirect location configurable?","user":{"login":"derekprior","id":152152,"avatar_url":"https://avatars.githubusercontent.com/u/152152?","gravatar_id":"79b1b001d5ff186c9bd02e7487aa4142","url":"https://api.github.com/users/derekprior","html_url":"https://github.com/derekprior","followers_url":"https://api.github.com/users/derekprior/followers","following_url":"https://api.github.com/users/derekprior/following{/other_user}","gists_url":"https://api.github.com/users/derekprior/gists{/gist_id}","starred_url":"https://api.github.com/users/derekprior/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekprior/subscriptions","organizations_url":"https://api.github.com/users/derekprior/orgs","repos_url":"https://api.github.com/users/derekprior/repos","events_url":"https://api.github.com/users/derekprior/events{/privacy}","received_events_url":"https://api.github.com/users/derekprior/received_events","type":"User","site_admin":false},"body":"Currently:\r\n\r\n```ruby\r\ndef require_login\r\n  unless signed_in?\r\n    flash.notice = Monban.config.sign_in_notice\r\n    redirect_to controller: '/sessions', action: 'new'\r\n  end\r\nend\r\n```\r\n\r\nThis is an issue in \"SuperMonban\" because the controller is namespaced. Additionally, you might actually want to redirect to your sign up controller - particularly if your sessions are long-lived (it's more likely you are a new user than someone needing to sign in).\r\n\r\nPerhaps a configurable string could be used if provided, but the current behavior would be the default?","created_at":"2014-06-07T03:31:21Z","updated_at":"2014-06-07T03:31:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/halogenandtoast/monban/pulls/21/commits","review_comments_url":"https://api.github.com/repos/halogenandtoast/monban/pulls/21/comments","review_comment_url":"https://api.github.com/repos/halogenandtoast/monban/pulls/comments/{number}","comments_url":"https://api.github.com/repos/halogenandtoast/monban/issues/21/comments","statuses_url":"https://api.github.com/repos/halogenandtoast/monban/statuses/aeffbde111b9c81f10da90c42c0813370f6be05f","head":{"label":"derekprior:dp-require-login-redirect","ref":"dp-require-login-redirect","sha":"aeffbde111b9c81f10da90c42c0813370f6be05f","user":{"login":"derekprior","id":152152,"avatar_url":"https://avatars.githubusercontent.com/u/152152?","gravatar_id":"79b1b001d5ff186c9bd02e7487aa4142","url":"https://api.github.com/users/derekprior","html_url":"https://github.com/derekprior","followers_url":"https://api.github.com/users/derekprior/followers","following_url":"https://api.github.com/users/derekprior/following{/other_user}","gists_url":"https://api.github.com/users/derekprior/gists{/gist_id}","starred_url":"https://api.github.com/users/derekprior/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekprior/subscriptions","organizations_url":"https://api.github.com/users/derekprior/orgs","repos_url":"https://api.github.com/users/derekprior/repos","events_url":"https://api.github.com/users/derekprior/events{/privacy}","received_events_url":"https://api.github.com/users/derekprior/received_events","type":"User","site_admin":false},"repo":{"id":20584556,"name":"monban","full_name":"derekprior/monban","owner":{"login":"derekprior","id":152152,"avatar_url":"https://avatars.githubusercontent.com/u/152152?","gravatar_id":"79b1b001d5ff186c9bd02e7487aa4142","url":"https://api.github.com/users/derekprior","html_url":"https://github.com/derekprior","followers_url":"https://api.github.com/users/derekprior/followers","following_url":"https://api.github.com/users/derekprior/following{/other_user}","gists_url":"https://api.github.com/users/derekprior/gists{/gist_id}","starred_url":"https://api.github.com/users/derekprior/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekprior/subscriptions","organizations_url":"https://api.github.com/users/derekprior/orgs","repos_url":"https://api.github.com/users/derekprior/repos","events_url":"https://api.github.com/users/derekprior/events{/privacy}","received_events_url":"https://api.github.com/users/derekprior/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/derekprior/monban","description":"Monban is rails authentication made simple.","fork":true,"url":"https://api.github.com/repos/derekprior/monban","forks_url":"https://api.github.com/repos/derekprior/monban/forks","keys_url":"https://api.github.com/repos/derekprior/monban/keys{/key_id}","collaborators_url":"https://api.github.com/repos/derekprior/monban/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/derekprior/monban/teams","hooks_url":"https://api.github.com/repos/derekprior/monban/hooks","issue_events_url":"https://api.github.com/repos/derekprior/monban/issues/events{/number}","events_url":"https://api.github.com/repos/derekprior/monban/events","assignees_url":"https://api.github.com/repos/derekprior/monban/assignees{/user}","branches_url":"https://api.github.com/repos/derekprior/monban/branches{/branch}","tags_url":"https://api.github.com/repos/derekprior/monban/tags","blobs_url":"https://api.github.com/repos/derekprior/monban/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/derekprior/monban/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/derekprior/monban/git/refs{/sha}","trees_url":"https://api.github.com/repos/derekprior/monban/git/trees{/sha}","statuses_url":"https://api.github.com/repos/derekprior/monban/statuses/{sha}","languages_url":"https://api.github.com/repos/derekprior/monban/languages","stargazers_url":"https://api.github.com/repos/derekprior/monban/stargazers","contributors_url":"https://api.github.com/repos/derekprior/monban/contributors","subscribers_url":"https://api.github.com/repos/derekprior/monban/subscribers","subscription_url":"https://api.github.com/repos/derekprior/monban/subscription","commits_url":"https://api.github.com/repos/derekprior/monban/commits{/sha}","git_commits_url":"https://api.github.com/repos/derekprior/monban/git/commits{/sha}","comments_url":"https://api.github.com/repos/derekprior/monban/comments{/number}","issue_comment_url":"https://api.github.com/repos/derekprior/monban/issues/comments/{number}","contents_url":"https://api.github.com/repos/derekprior/monban/contents/{+path}","compare_url":"https://api.github.com/repos/derekprior/monban/compare/{base}...{head}","merges_url":"https://api.github.com/repos/derekprior/monban/merges","archive_url":"https://api.github.com/repos/derekprior/monban/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/derekprior/monban/downloads","issues_url":"https://api.github.com/repos/derekprior/monban/issues{/number}","pulls_url":"https://api.github.com/repos/derekprior/monban/pulls{/number}","milestones_url":"https://api.github.com/repos/derekprior/monban/milestones{/number}","notifications_url":"https://api.github.com/repos/derekprior/monban/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/derekprior/monban/labels{/name}","releases_url":"https://api.github.com/repos/derekprior/monban/releases{/id}","created_at":"2014-06-07T03:27:58Z","updated_at":"2014-06-07T03:28:36Z","pushed_at":"2014-06-07T03:28:36Z","git_url":"git://github.com/derekprior/monban.git","ssh_url":"git@github.com:derekprior/monban.git","clone_url":"https://github.com/derekprior/monban.git","svn_url":"https://github.com/derekprior/monban","homepage":"","size":961,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"halogenandtoast:master","ref":"master","sha":"9810b8b669a07e6f0fd278cf68e32429d2d87343","user":{"login":"halogenandtoast","id":201288,"avatar_url":"https://avatars.githubusercontent.com/u/201288?","gravatar_id":"b066cb3c505933f832faa83238489a89","url":"https://api.github.com/users/halogenandtoast","html_url":"https://github.com/halogenandtoast","followers_url":"https://api.github.com/users/halogenandtoast/followers","following_url":"https://api.github.com/users/halogenandtoast/following{/other_user}","gists_url":"https://api.github.com/users/halogenandtoast/gists{/gist_id}","starred_url":"https://api.github.com/users/halogenandtoast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halogenandtoast/subscriptions","organizations_url":"https://api.github.com/users/halogenandtoast/orgs","repos_url":"https://api.github.com/users/halogenandtoast/repos","events_url":"https://api.github.com/users/halogenandtoast/events{/privacy}","received_events_url":"https://api.github.com/users/halogenandtoast/received_events","type":"User","site_admin":false},"repo":{"id":8082482,"name":"monban","full_name":"halogenandtoast/monban","owner":{"login":"halogenandtoast","id":201288,"avatar_url":"https://avatars.githubusercontent.com/u/201288?","gravatar_id":"b066cb3c505933f832faa83238489a89","url":"https://api.github.com/users/halogenandtoast","html_url":"https://github.com/halogenandtoast","followers_url":"https://api.github.com/users/halogenandtoast/followers","following_url":"https://api.github.com/users/halogenandtoast/following{/other_user}","gists_url":"https://api.github.com/users/halogenandtoast/gists{/gist_id}","starred_url":"https://api.github.com/users/halogenandtoast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halogenandtoast/subscriptions","organizations_url":"https://api.github.com/users/halogenandtoast/orgs","repos_url":"https://api.github.com/users/halogenandtoast/repos","events_url":"https://api.github.com/users/halogenandtoast/events{/privacy}","received_events_url":"https://api.github.com/users/halogenandtoast/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/halogenandtoast/monban","description":"Monban is rails authentication made simple.","fork":false,"url":"https://api.github.com/repos/halogenandtoast/monban","forks_url":"https://api.github.com/repos/halogenandtoast/monban/forks","keys_url":"https://api.github.com/repos/halogenandtoast/monban/keys{/key_id}","collaborators_url":"https://api.github.com/repos/halogenandtoast/monban/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/halogenandtoast/monban/teams","hooks_url":"https://api.github.com/repos/halogenandtoast/monban/hooks","issue_events_url":"https://api.github.com/repos/halogenandtoast/monban/issues/events{/number}","events_url":"https://api.github.com/repos/halogenandtoast/monban/events","assignees_url":"https://api.github.com/repos/halogenandtoast/monban/assignees{/user}","branches_url":"https://api.github.com/repos/halogenandtoast/monban/branches{/branch}","tags_url":"https://api.github.com/repos/halogenandtoast/monban/tags","blobs_url":"https://api.github.com/repos/halogenandtoast/monban/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/halogenandtoast/monban/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/halogenandtoast/monban/git/refs{/sha}","trees_url":"https://api.github.com/repos/halogenandtoast/monban/git/trees{/sha}","statuses_url":"https://api.github.com/repos/halogenandtoast/monban/statuses/{sha}","languages_url":"https://api.github.com/repos/halogenandtoast/monban/languages","stargazers_url":"https://api.github.com/repos/halogenandtoast/monban/stargazers","contributors_url":"https://api.github.com/repos/halogenandtoast/monban/contributors","subscribers_url":"https://api.github.com/repos/halogenandtoast/monban/subscribers","subscription_url":"https://api.github.com/repos/halogenandtoast/monban/subscription","commits_url":"https://api.github.com/repos/halogenandtoast/monban/commits{/sha}","git_commits_url":"https://api.github.com/repos/halogenandtoast/monban/git/commits{/sha}","comments_url":"https://api.github.com/repos/halogenandtoast/monban/comments{/number}","issue_comment_url":"https://api.github.com/repos/halogenandtoast/monban/issues/comments/{number}","contents_url":"https://api.github.com/repos/halogenandtoast/monban/contents/{+path}","compare_url":"https://api.github.com/repos/halogenandtoast/monban/compare/{base}...{head}","merges_url":"https://api.github.com/repos/halogenandtoast/monban/merges","archive_url":"https://api.github.com/repos/halogenandtoast/monban/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/halogenandtoast/monban/downloads","issues_url":"https://api.github.com/repos/halogenandtoast/monban/issues{/number}","pulls_url":"https://api.github.com/repos/halogenandtoast/monban/pulls{/number}","milestones_url":"https://api.github.com/repos/halogenandtoast/monban/milestones{/number}","notifications_url":"https://api.github.com/repos/halogenandtoast/monban/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/halogenandtoast/monban/labels{/name}","releases_url":"https://api.github.com/repos/halogenandtoast/monban/releases{/id}","created_at":"2013-02-07T21:52:34Z","updated_at":"2014-06-06T14:27:58Z","pushed_at":"2014-06-06T14:27:58Z","git_url":"git://github.com/halogenandtoast/monban.git","ssh_url":"git@github.com:halogenandtoast/monban.git","clone_url":"https://github.com/halogenandtoast/monban.git","svn_url":"https://github.com/halogenandtoast/monban","homepage":"","size":961,"stargazers_count":30,"watchers_count":30,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":10,"mirror_url":null,"open_issues_count":2,"forks":10,"open_issues":2,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/halogenandtoast/monban/pulls/21"},"html":{"href":"https://github.com/halogenandtoast/monban/pull/21"},"issue":{"href":"https://api.github.com/repos/halogenandtoast/monban/issues/21"},"comments":{"href":"https://api.github.com/repos/halogenandtoast/monban/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/halogenandtoast/monban/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/halogenandtoast/monban/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/halogenandtoast/monban/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/halogenandtoast/monban/statuses/aeffbde111b9c81f10da90c42c0813370f6be05f"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":5,"deletions":3,"changed_files":2}}