GitHub PullRequestReviewCommentEvent at 2014-05-20 07:34:19
Repository: appscale-tools
Actor: obino
Payload: {"comment":{"url":"https://api.github.com/repos/AppScale/appscale-tools/pulls/comments/12830848","id":12830848,"diff_hunk":"@@ -115,32 +115,38 @@ def is_sdk_mismatch(cls, app_dir):\n       A boolean value indicating if the user may have an sdk version\n       compatibility error with AppScale.\n     \"\"\"\n-    lib_files = os.listdir(cls.get_appengine_lib_location(app_dir))\n-    target_jar = cls.JAVA_SDK_JAR_PREFIX + '-' + cls.SUPPORTED_SDK_VERSION \\\n-      + '.jar'\n     mismatch = True\n-    for jar_file in lib_files:\n-      if target_jar in jar_file:\n-        mismatch = False\n+    paths = cls.get_appengine_lib_location(app_dir)","path":"lib/appengine_helper.py","position":20,"original_position":20,"commit_id":"2e45221d0b3dac359d08522445a507d7b182af05","original_commit_id":"2e45221d0b3dac359d08522445a507d7b182af05","user":{"login":"obino","id":902275,"avatar_url":"https://avatars.githubusercontent.com/u/902275?","gravatar_id":"eddb57113ece81ce5b08eb188fe7edd4","url":"https://api.github.com/users/obino","html_url":"https://github.com/obino","followers_url":"https://api.github.com/users/obino/followers","following_url":"https://api.github.com/users/obino/following{/other_user}","gists_url":"https://api.github.com/users/obino/gists{/gist_id}","starred_url":"https://api.github.com/users/obino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obino/subscriptions","organizations_url":"https://api.github.com/users/obino/orgs","repos_url":"https://api.github.com/users/obino/repos","events_url":"https://api.github.com/users/obino/events{/privacy}","received_events_url":"https://api.github.com/users/obino/received_events","type":"User","site_admin":false},"body":"Should that be called *._lib_locations?","created_at":"2014-05-20T07:34:19Z","updated_at":"2014-05-20T07:34:19Z","html_url":"https://github.com/AppScale/appscale-tools/pull/394#discussion_r12830848","pull_request_url":"https://api.github.com/repos/AppScale/appscale-tools/pulls/394","_links":{"self":{"href":"https://api.github.com/repos/AppScale/appscale-tools/pulls/comments/12830848"},"html":{"href":"https://github.com/AppScale/appscale-tools/pull/394#discussion_r12830848"},"pull_request":{"href":"https://api.github.com/repos/AppScale/appscale-tools/pulls/394"}}}}