GitHub PullRequestReviewCommentEvent at 2014-04-17 11:07:04
Repository: yast-bootloader
Actor: jreidinger
Payload: {"comment":{"url":"https://api.github.com/repos/yast/yast-bootloader/pulls/comments/11727445","id":11727445,"diff_hunk":"@@ -103,14 +103,15 @@ def GetFunctions\n     # Constructor\n     def BootGRUB2EFI\n \n-      if Arch.i386 \n+      if Arch.i386\n         packages = [\"grub2-i386-efi\"]\n       elsif Arch.x86_64\n         packages = [\"grub2-x86_64-efi\", \"shim\", \"mokutil\"]\n       else\n-        raise \"no grub packages for EFI available for this architecture\"\n+        # do not raise exception as we call contstructor everywhere even if it doesn't make sense","path":"src/modules/BootGRUB2EFI.rb","position":11,"original_position":11,"commit_id":"42656cec139524dd3ac185c9dbf483c3e379df4c","original_commit_id":"42656cec139524dd3ac185c9dbf483c3e379df4c","user":{"login":"jreidinger","id":478871,"avatar_url":"https://avatars.githubusercontent.com/u/478871?","gravatar_id":"f9a9cf77af20d925b328ee8c95c0068c","url":"https://api.github.com/users/jreidinger","html_url":"https://github.com/jreidinger","followers_url":"https://api.github.com/users/jreidinger/followers","following_url":"https://api.github.com/users/jreidinger/following{/other_user}","gists_url":"https://api.github.com/users/jreidinger/gists{/gist_id}","starred_url":"https://api.github.com/users/jreidinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreidinger/subscriptions","organizations_url":"https://api.github.com/users/jreidinger/orgs","repos_url":"https://api.github.com/users/jreidinger/repos","events_url":"https://api.github.com/users/jreidinger/events{/privacy}","received_events_url":"https://api.github.com/users/jreidinger/received_events","type":"User","site_admin":false},"body":"will fix it in next bug fix","created_at":"2014-04-17T11:07:04Z","updated_at":"2014-04-17T11:07:04Z","html_url":"https://github.com/yast/yast-bootloader/pull/74#discussion_r11727445","pull_request_url":"https://api.github.com/repos/yast/yast-bootloader/pulls/74","_links":{"self":{"href":"https://api.github.com/repos/yast/yast-bootloader/pulls/comments/11727445"},"html":{"href":"https://github.com/yast/yast-bootloader/pull/74#discussion_r11727445"},"pull_request":{"href":"https://api.github.com/repos/yast/yast-bootloader/pulls/74"}}}}