GitHub PullRequestEvent at 2014-05-16 19:57:01
Repository: darkstar
Actor: atom0s
Payload: {"action":"closed","number":234,"pull_request":{"url":"https://api.github.com/repos/DarkstarProject/darkstar/pulls/234","id":15970076,"html_url":"https://github.com/DarkstarProject/darkstar/pull/234","diff_url":"https://github.com/DarkstarProject/darkstar/pull/234.diff","patch_url":"https://github.com/DarkstarProject/darkstar/pull/234.patch","issue_url":"https://api.github.com/repos/DarkstarProject/darkstar/issues/234","number":234,"state":"closed","title":"May Update: NPC ID Updates","user":{"login":"starlightknight","id":3959228,"avatar_url":"https://avatars.githubusercontent.com/u/3959228?","gravatar_id":"bdfd06e7474b9698717fd6775d5111fe","url":"https://api.github.com/users/starlightknight","html_url":"https://github.com/starlightknight","followers_url":"https://api.github.com/users/starlightknight/followers","following_url":"https://api.github.com/users/starlightknight/following{/other_user}","gists_url":"https://api.github.com/users/starlightknight/gists{/gist_id}","starred_url":"https://api.github.com/users/starlightknight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/starlightknight/subscriptions","organizations_url":"https://api.github.com/users/starlightknight/orgs","repos_url":"https://api.github.com/users/starlightknight/repos","events_url":"https://api.github.com/users/starlightknight/events{/privacy}","received_events_url":"https://api.github.com/users/starlightknight/received_events","type":"User","site_admin":false},"body":"Attempted batch update of NPC IDs with my batch job from #215. The new mapping file approach helped the job a lot in its verification, but it still struggles a lot with some of the more generic npc names (csnpc, blank, etc).\r\n\r\nI will need to see what I can do to improve this approach further -- but we should also start standardizing on a naming convention. The lesser used zones (WoTG, etc) are all extremely inconsistent, and these areas are the hardest for automation right now because of it.\r\n\r\nAfter the batch update I did some basic manual review of my own, but @gedads should probably eventually glance over it with his usual process. I specifically looked out for and fixed areas I knew the batch was weak at currently, and left the areas it seemed to be updating fine alone.\r\n\r\nCovered the basics of - the file still loads, the server seems to work, and I did fix the start up warnings in conquest.lua and server.lua right off the bat as well this time.\r\n\r\nOverall, there didn't seem to be nearly as many changes detected this time around as last time when the random achieve masters all over the place bumped almost all zones.\r\n\r\nHopefully that means less scripts to fix in the coming days, especially since we still haven't fixed all of them from the April update.","created_at":"2014-05-16T03:37:24Z","updated_at":"2014-05-16T19:57:01Z","closed_at":"2014-05-16T19:57:01Z","merged_at":"2014-05-16T19:57:01Z","merge_commit_sha":"12eb4c0a29444c2f2eacbccf3eadb688d9b44534","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/DarkstarProject/darkstar/pulls/234/commits","review_comments_url":"https://api.github.com/repos/DarkstarProject/darkstar/pulls/234/comments","review_comment_url":"https://api.github.com/repos/DarkstarProject/darkstar/pulls/comments/{number}","comments_url":"https://api.github.com/repos/DarkstarProject/darkstar/issues/234/comments","statuses_url":"https://api.github.com/repos/DarkstarProject/darkstar/statuses/35418ef36027e20b617788ca80467ffa841f5dff","head":{"label":"starlightknight:may14-npcid-updates","ref":"may14-npcid-updates","sha":"35418ef36027e20b617788ca80467ffa841f5dff","user":{"login":"starlightknight","id":3959228,"avatar_url":"https://avatars.githubusercontent.com/u/3959228?","gravatar_id":"bdfd06e7474b9698717fd6775d5111fe","url":"https://api.github.com/users/starlightknight","html_url":"https://github.com/starlightknight","followers_url":"https://api.github.com/users/starlightknight/followers","following_url":"https://api.github.com/users/starlightknight/following{/other_user}","gists_url":"https://api.github.com/users/starlightknight/gists{/gist_id}","starred_url":"https://api.github.com/users/starlightknight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/starlightknight/subscriptions","organizations_url":"https://api.github.com/users/starlightknight/orgs","repos_url":"https://api.github.com/users/starlightknight/repos","events_url":"https://api.github.com/users/starlightknight/events{/privacy}","received_events_url":"https://api.github.com/users/starlightknight/received_events","type":"User","site_admin":false},"repo":{"id":18386547,"name":"darkstar","full_name":"starlightknight/darkstar","owner":{"login":"starlightknight","id":3959228,"avatar_url":"https://avatars.githubusercontent.com/u/3959228?","gravatar_id":"bdfd06e7474b9698717fd6775d5111fe","url":"https://api.github.com/users/starlightknight","html_url":"https://github.com/starlightknight","followers_url":"https://api.github.com/users/starlightknight/followers","following_url":"https://api.github.com/users/starlightknight/following{/other_user}","gists_url":"https://api.github.com/users/starlightknight/gists{/gist_id}","starred_url":"https://api.github.com/users/starlightknight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/starlightknight/subscriptions","organizations_url":"https://api.github.com/users/starlightknight/orgs","repos_url":"https://api.github.com/users/starlightknight/repos","events_url":"https://api.github.com/users/starlightknight/events{/privacy}","received_events_url":"https://api.github.com/users/starlightknight/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/starlightknight/darkstar","description":"FFXI Server Emulator","fork":true,"url":"https://api.github.com/repos/starlightknight/darkstar","forks_url":"https://api.github.com/repos/starlightknight/darkstar/forks","keys_url":"https://api.github.com/repos/starlightknight/darkstar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/starlightknight/darkstar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/starlightknight/darkstar/teams","hooks_url":"https://api.github.com/repos/starlightknight/darkstar/hooks","issue_events_url":"https://api.github.com/repos/starlightknight/darkstar/issues/events{/number}","events_url":"https://api.github.com/repos/starlightknight/darkstar/events","assignees_url":"https://api.github.com/repos/starlightknight/darkstar/assignees{/user}","branches_url":"https://api.github.com/repos/starlightknight/darkstar/branches{/branch}","tags_url":"https://api.github.com/repos/starlightknight/darkstar/tags","blobs_url":"https://api.github.com/repos/starlightknight/darkstar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/starlightknight/darkstar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/starlightknight/darkstar/git/refs{/sha}","trees_url":"https://api.github.com/repos/starlightknight/darkstar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/starlightknight/darkstar/statuses/{sha}","languages_url":"https://api.github.com/repos/starlightknight/darkstar/languages","stargazers_url":"https://api.github.com/repos/starlightknight/darkstar/stargazers","contributors_url":"https://api.github.com/repos/starlightknight/darkstar/contributors","subscribers_url":"https://api.github.com/repos/starlightknight/darkstar/subscribers","subscription_url":"https://api.github.com/repos/starlightknight/darkstar/subscription","commits_url":"https://api.github.com/repos/starlightknight/darkstar/commits{/sha}","git_commits_url":"https://api.github.com/repos/starlightknight/darkstar/git/commits{/sha}","comments_url":"https://api.github.com/repos/starlightknight/darkstar/comments{/number}","issue_comment_url":"https://api.github.com/repos/starlightknight/darkstar/issues/comments/{number}","contents_url":"https://api.github.com/repos/starlightknight/darkstar/contents/{+path}","compare_url":"https://api.github.com/repos/starlightknight/darkstar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/starlightknight/darkstar/merges","archive_url":"https://api.github.com/repos/starlightknight/darkstar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/starlightknight/darkstar/downloads","issues_url":"https://api.github.com/repos/starlightknight/darkstar/issues{/number}","pulls_url":"https://api.github.com/repos/starlightknight/darkstar/pulls{/number}","milestones_url":"https://api.github.com/repos/starlightknight/darkstar/milestones{/number}","notifications_url":"https://api.github.com/repos/starlightknight/darkstar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/starlightknight/darkstar/labels{/name}","releases_url":"https://api.github.com/repos/starlightknight/darkstar/releases{/id}","created_at":"2014-04-03T00:50:01Z","updated_at":"2014-05-16T19:57:01Z","pushed_at":"2014-05-16T12:10:52Z","git_url":"git://github.com/starlightknight/darkstar.git","ssh_url":"git@github.com:starlightknight/darkstar.git","clone_url":"https://github.com/starlightknight/darkstar.git","svn_url":"https://github.com/starlightknight/darkstar","homepage":"https://forums.dspt.info/index.php","size":49661,"stargazers_count":0,"watchers_count":0,"language":"SQL","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DarkstarProject:master","ref":"master","sha":"64b5347d4b5fa031425423cda312f6ea445a06b0","user":{"login":"DarkstarProject","id":6373714,"avatar_url":"https://avatars.githubusercontent.com/u/6373714?","gravatar_id":null,"url":"https://api.github.com/users/DarkstarProject","html_url":"https://github.com/DarkstarProject","followers_url":"https://api.github.com/users/DarkstarProject/followers","following_url":"https://api.github.com/users/DarkstarProject/following{/other_user}","gists_url":"https://api.github.com/users/DarkstarProject/gists{/gist_id}","starred_url":"https://api.github.com/users/DarkstarProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DarkstarProject/subscriptions","organizations_url":"https://api.github.com/users/DarkstarProject/orgs","repos_url":"https://api.github.com/users/DarkstarProject/repos","events_url":"https://api.github.com/users/DarkstarProject/events{/privacy}","received_events_url":"https://api.github.com/users/DarkstarProject/received_events","type":"Organization","site_admin":false},"repo":{"id":15814642,"name":"darkstar","full_name":"DarkstarProject/darkstar","owner":{"login":"DarkstarProject","id":6373714,"avatar_url":"https://avatars.githubusercontent.com/u/6373714?","gravatar_id":null,"url":"https://api.github.com/users/DarkstarProject","html_url":"https://github.com/DarkstarProject","followers_url":"https://api.github.com/users/DarkstarProject/followers","following_url":"https://api.github.com/users/DarkstarProject/following{/other_user}","gists_url":"https://api.github.com/users/DarkstarProject/gists{/gist_id}","starred_url":"https://api.github.com/users/DarkstarProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DarkstarProject/subscriptions","organizations_url":"https://api.github.com/users/DarkstarProject/orgs","repos_url":"https://api.github.com/users/DarkstarProject/repos","events_url":"https://api.github.com/users/DarkstarProject/events{/privacy}","received_events_url":"https://api.github.com/users/DarkstarProject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DarkstarProject/darkstar","description":"FFXI Server Emulator","fork":false,"url":"https://api.github.com/repos/DarkstarProject/darkstar","forks_url":"https://api.github.com/repos/DarkstarProject/darkstar/forks","keys_url":"https://api.github.com/repos/DarkstarProject/darkstar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DarkstarProject/darkstar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DarkstarProject/darkstar/teams","hooks_url":"https://api.github.com/repos/DarkstarProject/darkstar/hooks","issue_events_url":"https://api.github.com/repos/DarkstarProject/darkstar/issues/events{/number}","events_url":"https://api.github.com/repos/DarkstarProject/darkstar/events","assignees_url":"https://api.github.com/repos/DarkstarProject/darkstar/assignees{/user}","branches_url":"https://api.github.com/repos/DarkstarProject/darkstar/branches{/branch}","tags_url":"https://api.github.com/repos/DarkstarProject/darkstar/tags","blobs_url":"https://api.github.com/repos/DarkstarProject/darkstar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DarkstarProject/darkstar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DarkstarProject/darkstar/git/refs{/sha}","trees_url":"https://api.github.com/repos/DarkstarProject/darkstar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DarkstarProject/darkstar/statuses/{sha}","languages_url":"https://api.github.com/repos/DarkstarProject/darkstar/languages","stargazers_url":"https://api.github.com/repos/DarkstarProject/darkstar/stargazers","contributors_url":"https://api.github.com/repos/DarkstarProject/darkstar/contributors","subscribers_url":"https://api.github.com/repos/DarkstarProject/darkstar/subscribers","subscription_url":"https://api.github.com/repos/DarkstarProject/darkstar/subscription","commits_url":"https://api.github.com/repos/DarkstarProject/darkstar/commits{/sha}","git_commits_url":"https://api.github.com/repos/DarkstarProject/darkstar/git/commits{/sha}","comments_url":"https://api.github.com/repos/DarkstarProject/darkstar/comments{/number}","issue_comment_url":"https://api.github.com/repos/DarkstarProject/darkstar/issues/comments/{number}","contents_url":"https://api.github.com/repos/DarkstarProject/darkstar/contents/{+path}","compare_url":"https://api.github.com/repos/DarkstarProject/darkstar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DarkstarProject/darkstar/merges","archive_url":"https://api.github.com/repos/DarkstarProject/darkstar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DarkstarProject/darkstar/downloads","issues_url":"https://api.github.com/repos/DarkstarProject/darkstar/issues{/number}","pulls_url":"https://api.github.com/repos/DarkstarProject/darkstar/pulls{/number}","milestones_url":"https://api.github.com/repos/DarkstarProject/darkstar/milestones{/number}","notifications_url":"https://api.github.com/repos/DarkstarProject/darkstar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DarkstarProject/darkstar/labels{/name}","releases_url":"https://api.github.com/repos/DarkstarProject/darkstar/releases{/id}","created_at":"2014-01-11T01:31:17Z","updated_at":"2014-05-16T19:57:01Z","pushed_at":"2014-05-16T19:57:01Z","git_url":"git://github.com/DarkstarProject/darkstar.git","ssh_url":"git@github.com:DarkstarProject/darkstar.git","clone_url":"https://github.com/DarkstarProject/darkstar.git","svn_url":"https://github.com/DarkstarProject/darkstar","homepage":"https://forums.dspt.info/index.php","size":59689,"stargazers_count":32,"watchers_count":32,"language":"Lua","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":48,"mirror_url":null,"open_issues_count":9,"forks":48,"open_issues":9,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DarkstarProject/darkstar/pulls/234"},"html":{"href":"https://github.com/DarkstarProject/darkstar/pull/234"},"issue":{"href":"https://api.github.com/repos/DarkstarProject/darkstar/issues/234"},"comments":{"href":"https://api.github.com/repos/DarkstarProject/darkstar/issues/234/comments"},"review_comments":{"href":"https://api.github.com/repos/DarkstarProject/darkstar/pulls/234/comments"},"review_comment":{"href":"https://api.github.com/repos/DarkstarProject/darkstar/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/DarkstarProject/darkstar/pulls/234/commits"},"statuses":{"href":"https://api.github.com/repos/DarkstarProject/darkstar/statuses/35418ef36027e20b617788ca80467ffa841f5dff"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"atom0s","id":1422090,"avatar_url":"https://avatars.githubusercontent.com/u/1422090?","gravatar_id":"d61f2c833d829f5ad1b2d4c5b784188d","url":"https://api.github.com/users/atom0s","html_url":"https://github.com/atom0s","followers_url":"https://api.github.com/users/atom0s/followers","following_url":"https://api.github.com/users/atom0s/following{/other_user}","gists_url":"https://api.github.com/users/atom0s/gists{/gist_id}","starred_url":"https://api.github.com/users/atom0s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom0s/subscriptions","organizations_url":"https://api.github.com/users/atom0s/orgs","repos_url":"https://api.github.com/users/atom0s/repos","events_url":"https://api.github.com/users/atom0s/events{/privacy}","received_events_url":"https://api.github.com/users/atom0s/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":966,"deletions":966,"changed_files":3}}