GitHub PullRequestEvent at 2014-11-12 14:02:17
Repository: bnd
Actor: gamerson
Payload: {"action":"opened","number":680,"pull_request":{"url":"https://api.github.com/repos/bndtools/bnd/pulls/680","id":24293843,"html_url":"https://github.com/bndtools/bnd/pull/680","diff_url":"https://github.com/bndtools/bnd/pull/680.diff","patch_url":"https://github.com/bndtools/bnd/pull/680.patch","issue_url":"https://api.github.com/repos/bndtools/bnd/issues/680","number":680,"state":"open","locked":false,"title":"Cleanup exact versions in case they contain snapshot-ish names","user":{"login":"gamerson","id":595221,"avatar_url":"https://avatars.githubusercontent.com/u/595221?v=3","gravatar_id":"","url":"https://api.github.com/users/gamerson","html_url":"https://github.com/gamerson","followers_url":"https://api.github.com/users/gamerson/followers","following_url":"https://api.github.com/users/gamerson/following{/other_user}","gists_url":"https://api.github.com/users/gamerson/gists{/gist_id}","starred_url":"https://api.github.com/users/gamerson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gamerson/subscriptions","organizations_url":"https://api.github.com/users/gamerson/orgs","repos_url":"https://api.github.com/users/gamerson/repos","events_url":"https://api.github.com/users/gamerson/events{/privacy}","received_events_url":"https://api.github.com/users/gamerson/received_events","type":"User","site_admin":false},"body":"In my scenario I'm trying to use some liferay portal-service 7.0.0-SNAPSHOT versions in my 2.4.0 bndtools workspace using the AetherRepository.  However, bndlib is killing off getBundle() check before it gets to AetherRepository because it doesn't like 7.0.0-SNAPSHOT version, which I understand since its not very osgi friendly version.\r\n\r\nHowever I searched the bndlib code and found a method in the Analyzer that will try to cleanup maven versions that look like that X.X.X-SNAPSHOT and make it more osgi friendly form, e.g. X.X.X.SNAPSHOT.\r\n\r\nSo I just called that same function from the Project.getBundle() method to help make my use-case possible and tested it in my local environment and it works for AetherRepository plugin.  So I'm sending the pull along.","created_at":"2014-11-12T14:02:17Z","updated_at":"2014-11-12T14:02:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bndtools/bnd/pulls/680/commits","review_comments_url":"https://api.github.com/repos/bndtools/bnd/pulls/680/comments","review_comment_url":"https://api.github.com/repos/bndtools/bnd/pulls/comments/{number}","comments_url":"https://api.github.com/repos/bndtools/bnd/issues/680/comments","statuses_url":"https://api.github.com/repos/bndtools/bnd/statuses/c2e69e34cb92c11bac962de88a1dde89167888f3","head":{"label":"gamerson:snapshotish-versions","ref":"snapshotish-versions","sha":"c2e69e34cb92c11bac962de88a1dde89167888f3","user":{"login":"gamerson","id":595221,"avatar_url":"https://avatars.githubusercontent.com/u/595221?v=3","gravatar_id":"","url":"https://api.github.com/users/gamerson","html_url":"https://github.com/gamerson","followers_url":"https://api.github.com/users/gamerson/followers","following_url":"https://api.github.com/users/gamerson/following{/other_user}","gists_url":"https://api.github.com/users/gamerson/gists{/gist_id}","starred_url":"https://api.github.com/users/gamerson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gamerson/subscriptions","organizations_url":"https://api.github.com/users/gamerson/orgs","repos_url":"https://api.github.com/users/gamerson/repos","events_url":"https://api.github.com/users/gamerson/events{/privacy}","received_events_url":"https://api.github.com/users/gamerson/received_events","type":"User","site_admin":false},"repo":{"id":22232304,"name":"bnd","full_name":"gamerson/bnd","owner":{"login":"gamerson","id":595221,"avatar_url":"https://avatars.githubusercontent.com/u/595221?v=3","gravatar_id":"","url":"https://api.github.com/users/gamerson","html_url":"https://github.com/gamerson","followers_url":"https://api.github.com/users/gamerson/followers","following_url":"https://api.github.com/users/gamerson/following{/other_user}","gists_url":"https://api.github.com/users/gamerson/gists{/gist_id}","starred_url":"https://api.github.com/users/gamerson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gamerson/subscriptions","organizations_url":"https://api.github.com/users/gamerson/orgs","repos_url":"https://api.github.com/users/gamerson/repos","events_url":"https://api.github.com/users/gamerson/events{/privacy}","received_events_url":"https://api.github.com/users/gamerson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gamerson/bnd","description":"bnd, the swiss army knife for OSGi. A tool to build bundles.","fork":true,"url":"https://api.github.com/repos/gamerson/bnd","forks_url":"https://api.github.com/repos/gamerson/bnd/forks","keys_url":"https://api.github.com/repos/gamerson/bnd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gamerson/bnd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gamerson/bnd/teams","hooks_url":"https://api.github.com/repos/gamerson/bnd/hooks","issue_events_url":"https://api.github.com/repos/gamerson/bnd/issues/events{/number}","events_url":"https://api.github.com/repos/gamerson/bnd/events","assignees_url":"https://api.github.com/repos/gamerson/bnd/assignees{/user}","branches_url":"https://api.github.com/repos/gamerson/bnd/branches{/branch}","tags_url":"https://api.github.com/repos/gamerson/bnd/tags","blobs_url":"https://api.github.com/repos/gamerson/bnd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gamerson/bnd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gamerson/bnd/git/refs{/sha}","trees_url":"https://api.github.com/repos/gamerson/bnd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gamerson/bnd/statuses/{sha}","languages_url":"https://api.github.com/repos/gamerson/bnd/languages","stargazers_url":"https://api.github.com/repos/gamerson/bnd/stargazers","contributors_url":"https://api.github.com/repos/gamerson/bnd/contributors","subscribers_url":"https://api.github.com/repos/gamerson/bnd/subscribers","subscription_url":"https://api.github.com/repos/gamerson/bnd/subscription","commits_url":"https://api.github.com/repos/gamerson/bnd/commits{/sha}","git_commits_url":"https://api.github.com/repos/gamerson/bnd/git/commits{/sha}","comments_url":"https://api.github.com/repos/gamerson/bnd/comments{/number}","issue_comment_url":"https://api.github.com/repos/gamerson/bnd/issues/comments/{number}","contents_url":"https://api.github.com/repos/gamerson/bnd/contents/{+path}","compare_url":"https://api.github.com/repos/gamerson/bnd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gamerson/bnd/merges","archive_url":"https://api.github.com/repos/gamerson/bnd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gamerson/bnd/downloads","issues_url":"https://api.github.com/repos/gamerson/bnd/issues{/number}","pulls_url":"https://api.github.com/repos/gamerson/bnd/pulls{/number}","milestones_url":"https://api.github.com/repos/gamerson/bnd/milestones{/number}","notifications_url":"https://api.github.com/repos/gamerson/bnd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gamerson/bnd/labels{/name}","releases_url":"https://api.github.com/repos/gamerson/bnd/releases{/id}","created_at":"2014-07-24T21:39:42Z","updated_at":"2014-11-12T13:56:54Z","pushed_at":"2014-11-12T13:58:16Z","git_url":"git://github.com/gamerson/bnd.git","ssh_url":"git@github.com:gamerson/bnd.git","clone_url":"https://github.com/gamerson/bnd.git","svn_url":"https://github.com/gamerson/bnd","homepage":"http://www.aQute.biz/Bnd","size":202006,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bndtools:master","ref":"master","sha":"4500320e7557ec4f4bab585daa632e4888facb30","user":{"login":"bndtools","id":1130828,"avatar_url":"https://avatars.githubusercontent.com/u/1130828?v=3","gravatar_id":"","url":"https://api.github.com/users/bndtools","html_url":"https://github.com/bndtools","followers_url":"https://api.github.com/users/bndtools/followers","following_url":"https://api.github.com/users/bndtools/following{/other_user}","gists_url":"https://api.github.com/users/bndtools/gists{/gist_id}","starred_url":"https://api.github.com/users/bndtools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bndtools/subscriptions","organizations_url":"https://api.github.com/users/bndtools/orgs","repos_url":"https://api.github.com/users/bndtools/repos","events_url":"https://api.github.com/users/bndtools/events{/privacy}","received_events_url":"https://api.github.com/users/bndtools/received_events","type":"Organization","site_admin":false},"repo":{"id":606956,"name":"bnd","full_name":"bndtools/bnd","owner":{"login":"bndtools","id":1130828,"avatar_url":"https://avatars.githubusercontent.com/u/1130828?v=3","gravatar_id":"","url":"https://api.github.com/users/bndtools","html_url":"https://github.com/bndtools","followers_url":"https://api.github.com/users/bndtools/followers","following_url":"https://api.github.com/users/bndtools/following{/other_user}","gists_url":"https://api.github.com/users/bndtools/gists{/gist_id}","starred_url":"https://api.github.com/users/bndtools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bndtools/subscriptions","organizations_url":"https://api.github.com/users/bndtools/orgs","repos_url":"https://api.github.com/users/bndtools/repos","events_url":"https://api.github.com/users/bndtools/events{/privacy}","received_events_url":"https://api.github.com/users/bndtools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bndtools/bnd","description":"bnd, the swiss army knife for OSGi. A tool to build bundles.","fork":false,"url":"https://api.github.com/repos/bndtools/bnd","forks_url":"https://api.github.com/repos/bndtools/bnd/forks","keys_url":"https://api.github.com/repos/bndtools/bnd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bndtools/bnd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bndtools/bnd/teams","hooks_url":"https://api.github.com/repos/bndtools/bnd/hooks","issue_events_url":"https://api.github.com/repos/bndtools/bnd/issues/events{/number}","events_url":"https://api.github.com/repos/bndtools/bnd/events","assignees_url":"https://api.github.com/repos/bndtools/bnd/assignees{/user}","branches_url":"https://api.github.com/repos/bndtools/bnd/branches{/branch}","tags_url":"https://api.github.com/repos/bndtools/bnd/tags","blobs_url":"https://api.github.com/repos/bndtools/bnd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bndtools/bnd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bndtools/bnd/git/refs{/sha}","trees_url":"https://api.github.com/repos/bndtools/bnd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bndtools/bnd/statuses/{sha}","languages_url":"https://api.github.com/repos/bndtools/bnd/languages","stargazers_url":"https://api.github.com/repos/bndtools/bnd/stargazers","contributors_url":"https://api.github.com/repos/bndtools/bnd/contributors","subscribers_url":"https://api.github.com/repos/bndtools/bnd/subscribers","subscription_url":"https://api.github.com/repos/bndtools/bnd/subscription","commits_url":"https://api.github.com/repos/bndtools/bnd/commits{/sha}","git_commits_url":"https://api.github.com/repos/bndtools/bnd/git/commits{/sha}","comments_url":"https://api.github.com/repos/bndtools/bnd/comments{/number}","issue_comment_url":"https://api.github.com/repos/bndtools/bnd/issues/comments/{number}","contents_url":"https://api.github.com/repos/bndtools/bnd/contents/{+path}","compare_url":"https://api.github.com/repos/bndtools/bnd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bndtools/bnd/merges","archive_url":"https://api.github.com/repos/bndtools/bnd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bndtools/bnd/downloads","issues_url":"https://api.github.com/repos/bndtools/bnd/issues{/number}","pulls_url":"https://api.github.com/repos/bndtools/bnd/pulls{/number}","milestones_url":"https://api.github.com/repos/bndtools/bnd/milestones{/number}","notifications_url":"https://api.github.com/repos/bndtools/bnd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bndtools/bnd/labels{/name}","releases_url":"https://api.github.com/repos/bndtools/bnd/releases{/id}","created_at":"2010-04-12T17:30:15Z","updated_at":"2014-10-25T09:10:48Z","pushed_at":"2014-11-11T20:23:39Z","git_url":"git://github.com/bndtools/bnd.git","ssh_url":"git@github.com:bndtools/bnd.git","clone_url":"https://github.com/bndtools/bnd.git","svn_url":"https://github.com/bndtools/bnd","homepage":"http://www.aQute.biz/Bnd","size":271534,"stargazers_count":166,"watchers_count":166,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":83,"mirror_url":null,"open_issues_count":37,"forks":83,"open_issues":37,"watchers":166,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bndtools/bnd/pulls/680"},"html":{"href":"https://github.com/bndtools/bnd/pull/680"},"issue":{"href":"https://api.github.com/repos/bndtools/bnd/issues/680"},"comments":{"href":"https://api.github.com/repos/bndtools/bnd/issues/680/comments"},"review_comments":{"href":"https://api.github.com/repos/bndtools/bnd/pulls/680/comments"},"review_comment":{"href":"https://api.github.com/repos/bndtools/bnd/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/bndtools/bnd/pulls/680/commits"},"statuses":{"href":"https://api.github.com/repos/bndtools/bnd/statuses/c2e69e34cb92c11bac962de88a1dde89167888f3"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":5,"deletions":4,"changed_files":1}}