GitHub PullRequestEvent at 2014-11-05 15:49:19
Repository: supplier-submission-portal
Actor: quis
Payload: {"action":"closed","number":211,"pull_request":{"url":"https://api.github.com/repos/alphagov/supplier-submission-portal/pulls/211","id":23911592,"html_url":"https://github.com/alphagov/supplier-submission-portal/pull/211","diff_url":"https://github.com/alphagov/supplier-submission-portal/pull/211.diff","patch_url":"https://github.com/alphagov/supplier-submission-portal/pull/211.patch","issue_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/issues/211","number":211,"state":"closed","locked":false,"title":"Fix invalid HTML","user":{"login":"quis","id":355079,"avatar_url":"https://avatars.githubusercontent.com/u/355079?v=2","gravatar_id":"","url":"https://api.github.com/users/quis","html_url":"https://github.com/quis","followers_url":"https://api.github.com/users/quis/followers","following_url":"https://api.github.com/users/quis/following{/other_user}","gists_url":"https://api.github.com/users/quis/gists{/gist_id}","starred_url":"https://api.github.com/users/quis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quis/subscriptions","organizations_url":"https://api.github.com/users/quis/orgs","repos_url":"https://api.github.com/users/quis/repos","events_url":"https://api.github.com/users/quis/events{/privacy}","received_events_url":"https://api.github.com/users/quis/received_events","type":"User","site_admin":false},"body":"According to the HTML5 spec a `legend` must be a **direct** descendent of a `fieldset`. We were wrapping the `legend` hints and `input`s with a `div` when there was a validation error.\r\n\r\nBecause of this, both Firefox and the Cucumber tests were unable to properly parse the HTML. Although this had no repercussions visually or for screenreader users it did cause the tests to fail unexpectedly.\r\n\r\nThis commit puts the `validation-wrapper` class directly on the fieldset so that the HTML is valid.\r\n\r\n![screen shot 2014-11-05 at 15 05 09](https://cloud.githubusercontent.com/assets/355079/4919794/35efd1de-64fd-11e4-8065-dcd81a5b345c.png)\r\n\r\nThis has the side effect of positioning the `legend` half way out of the `fieldset`'s top edge. This is the default appearance for legends, e.g.\r\n![x91vl](https://cloud.githubusercontent.com/assets/355079/4919772/0068c1f6-64fd-11e4-9937-0b32eabe8071.png)\r\n\r\nFixing this requires a small tweak to the CSS. I've poked around in various browsers and it doesn't seem to have had any knock-on effects visually.","created_at":"2014-11-05T15:06:15Z","updated_at":"2014-11-05T15:49:19Z","closed_at":"2014-11-05T15:49:19Z","merged_at":null,"merge_commit_sha":"64949fbe94671099515b2ffb6cfb1770b5798826","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/pulls/211/commits","review_comments_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/pulls/211/comments","review_comment_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/pulls/comments/{number}","comments_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/issues/211/comments","statuses_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/statuses/d7f6ee3073e7c4975f708c35d98d07559acbb4f5","head":{"label":"alphagov:fix-html-nesting","ref":"fix-html-nesting","sha":"d7f6ee3073e7c4975f708c35d98d07559acbb4f5","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=2","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":23871061,"name":"supplier-submission-portal","full_name":"alphagov/supplier-submission-portal","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=2","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/supplier-submission-portal","description":"Application to enable data capture around G-Cloud submissions.","fork":false,"url":"https://api.github.com/repos/alphagov/supplier-submission-portal","forks_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/forks","keys_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/teams","hooks_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/hooks","issue_events_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/events","assignees_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/tags","blobs_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/languages","stargazers_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/stargazers","contributors_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/contributors","subscribers_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/subscribers","subscription_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/subscription","commits_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/issues/comments/{number}","contents_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/merges","archive_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/downloads","issues_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/releases{/id}","created_at":"2014-09-10T10:52:12Z","updated_at":"2014-11-04T17:04:49Z","pushed_at":"2014-11-05T15:02:40Z","git_url":"git://github.com/alphagov/supplier-submission-portal.git","ssh_url":"git@github.com:alphagov/supplier-submission-portal.git","clone_url":"https://github.com/alphagov/supplier-submission-portal.git","svn_url":"https://github.com/alphagov/supplier-submission-portal","homepage":null,"size":30314,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":4,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"0d15191a3b754deb36493e33bb3364c2c2779ad7","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=2","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":23871061,"name":"supplier-submission-portal","full_name":"alphagov/supplier-submission-portal","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=2","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/supplier-submission-portal","description":"Application to enable data capture around G-Cloud submissions.","fork":false,"url":"https://api.github.com/repos/alphagov/supplier-submission-portal","forks_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/forks","keys_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/teams","hooks_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/hooks","issue_events_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/events","assignees_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/tags","blobs_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/languages","stargazers_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/stargazers","contributors_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/contributors","subscribers_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/subscribers","subscription_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/subscription","commits_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/issues/comments/{number}","contents_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/merges","archive_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/downloads","issues_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/supplier-submission-portal/releases{/id}","created_at":"2014-09-10T10:52:12Z","updated_at":"2014-11-04T17:04:49Z","pushed_at":"2014-11-05T15:02:40Z","git_url":"git://github.com/alphagov/supplier-submission-portal.git","ssh_url":"git@github.com:alphagov/supplier-submission-portal.git","clone_url":"https://github.com/alphagov/supplier-submission-portal.git","svn_url":"https://github.com/alphagov/supplier-submission-portal","homepage":null,"size":30314,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/supplier-submission-portal/pulls/211"},"html":{"href":"https://github.com/alphagov/supplier-submission-portal/pull/211"},"issue":{"href":"https://api.github.com/repos/alphagov/supplier-submission-portal/issues/211"},"comments":{"href":"https://api.github.com/repos/alphagov/supplier-submission-portal/issues/211/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/supplier-submission-portal/pulls/211/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/supplier-submission-portal/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/alphagov/supplier-submission-portal/pulls/211/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/supplier-submission-portal/statuses/d7f6ee3073e7c4975f708c35d98d07559acbb4f5"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":12,"deletions":17,"changed_files":5}}