GitHub PullRequestEvent at 2014-07-29 07:48:35
Repository: ldc
Actor: redstar
Payload: {"action":"closed","number":691,"pull_request":{"url":"https://api.github.com/repos/ldc-developers/ldc/pulls/691","id":18969451,"html_url":"https://github.com/ldc-developers/ldc/pull/691","diff_url":"https://github.com/ldc-developers/ldc/pull/691.diff","patch_url":"https://github.com/ldc-developers/ldc/pull/691.patch","issue_url":"https://api.github.com/repos/ldc-developers/ldc/issues/691","number":691,"state":"closed","title":"Fix a build issue where LLVM_LDFLAGS contains newlines.","user":{"login":"gballet","id":3272758,"avatar_url":"https://avatars.githubusercontent.com/u/3272758?","gravatar_id":"11f5d23ef74dd79ad1cca90fe6e11b6c","url":"https://api.github.com/users/gballet","html_url":"https://github.com/gballet","followers_url":"https://api.github.com/users/gballet/followers","following_url":"https://api.github.com/users/gballet/following{/other_user}","gists_url":"https://api.github.com/users/gballet/gists{/gist_id}","starred_url":"https://api.github.com/users/gballet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gballet/subscriptions","organizations_url":"https://api.github.com/users/gballet/orgs","repos_url":"https://api.github.com/users/gballet/repos","events_url":"https://api.github.com/users/gballet/events{/privacy}","received_events_url":"https://api.github.com/users/gballet/received_events","type":"User","site_admin":false},"body":"On my system. llvm_set returns a variable that contains newlines, which breaks the build. This fix makes sure that they are removed before setting LLVM_LDFLAGS for the last time.\r\n\r\nEnvironment: \r\n\r\nLinux kartofel 3.13.0-24-generic #46-Ubuntu SMP Thu Apr 10 19:11:08 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux\r\ncmake version 2.8.12.2\r\nllvm version 3.5","created_at":"2014-07-28T14:18:39Z","updated_at":"2014-07-29T07:48:34Z","closed_at":"2014-07-29T07:48:34Z","merged_at":"2014-07-29T07:48:34Z","merge_commit_sha":"ee176cab4f533ccabd6f89af23497a354e9696e6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ldc-developers/ldc/pulls/691/commits","review_comments_url":"https://api.github.com/repos/ldc-developers/ldc/pulls/691/comments","review_comment_url":"https://api.github.com/repos/ldc-developers/ldc/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ldc-developers/ldc/issues/691/comments","statuses_url":"https://api.github.com/repos/ldc-developers/ldc/statuses/eb32c672a4f9de43bd895936b85e44bffb7d6b25","head":{"label":"gballet:fix-buildissues","ref":"fix-buildissues","sha":"eb32c672a4f9de43bd895936b85e44bffb7d6b25","user":{"login":"gballet","id":3272758,"avatar_url":"https://avatars.githubusercontent.com/u/3272758?","gravatar_id":"11f5d23ef74dd79ad1cca90fe6e11b6c","url":"https://api.github.com/users/gballet","html_url":"https://github.com/gballet","followers_url":"https://api.github.com/users/gballet/followers","following_url":"https://api.github.com/users/gballet/following{/other_user}","gists_url":"https://api.github.com/users/gballet/gists{/gist_id}","starred_url":"https://api.github.com/users/gballet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gballet/subscriptions","organizations_url":"https://api.github.com/users/gballet/orgs","repos_url":"https://api.github.com/users/gballet/repos","events_url":"https://api.github.com/users/gballet/events{/privacy}","received_events_url":"https://api.github.com/users/gballet/received_events","type":"User","site_admin":false},"repo":{"id":22334674,"name":"ldc","full_name":"gballet/ldc","owner":{"login":"gballet","id":3272758,"avatar_url":"https://avatars.githubusercontent.com/u/3272758?","gravatar_id":"11f5d23ef74dd79ad1cca90fe6e11b6c","url":"https://api.github.com/users/gballet","html_url":"https://github.com/gballet","followers_url":"https://api.github.com/users/gballet/followers","following_url":"https://api.github.com/users/gballet/following{/other_user}","gists_url":"https://api.github.com/users/gballet/gists{/gist_id}","starred_url":"https://api.github.com/users/gballet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gballet/subscriptions","organizations_url":"https://api.github.com/users/gballet/orgs","repos_url":"https://api.github.com/users/gballet/repos","events_url":"https://api.github.com/users/gballet/events{/privacy}","received_events_url":"https://api.github.com/users/gballet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gballet/ldc","description":"The LLVM-based D compiler.","fork":true,"url":"https://api.github.com/repos/gballet/ldc","forks_url":"https://api.github.com/repos/gballet/ldc/forks","keys_url":"https://api.github.com/repos/gballet/ldc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gballet/ldc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gballet/ldc/teams","hooks_url":"https://api.github.com/repos/gballet/ldc/hooks","issue_events_url":"https://api.github.com/repos/gballet/ldc/issues/events{/number}","events_url":"https://api.github.com/repos/gballet/ldc/events","assignees_url":"https://api.github.com/repos/gballet/ldc/assignees{/user}","branches_url":"https://api.github.com/repos/gballet/ldc/branches{/branch}","tags_url":"https://api.github.com/repos/gballet/ldc/tags","blobs_url":"https://api.github.com/repos/gballet/ldc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gballet/ldc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gballet/ldc/git/refs{/sha}","trees_url":"https://api.github.com/repos/gballet/ldc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gballet/ldc/statuses/{sha}","languages_url":"https://api.github.com/repos/gballet/ldc/languages","stargazers_url":"https://api.github.com/repos/gballet/ldc/stargazers","contributors_url":"https://api.github.com/repos/gballet/ldc/contributors","subscribers_url":"https://api.github.com/repos/gballet/ldc/subscribers","subscription_url":"https://api.github.com/repos/gballet/ldc/subscription","commits_url":"https://api.github.com/repos/gballet/ldc/commits{/sha}","git_commits_url":"https://api.github.com/repos/gballet/ldc/git/commits{/sha}","comments_url":"https://api.github.com/repos/gballet/ldc/comments{/number}","issue_comment_url":"https://api.github.com/repos/gballet/ldc/issues/comments/{number}","contents_url":"https://api.github.com/repos/gballet/ldc/contents/{+path}","compare_url":"https://api.github.com/repos/gballet/ldc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gballet/ldc/merges","archive_url":"https://api.github.com/repos/gballet/ldc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gballet/ldc/downloads","issues_url":"https://api.github.com/repos/gballet/ldc/issues{/number}","pulls_url":"https://api.github.com/repos/gballet/ldc/pulls{/number}","milestones_url":"https://api.github.com/repos/gballet/ldc/milestones{/number}","notifications_url":"https://api.github.com/repos/gballet/ldc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gballet/ldc/labels{/name}","releases_url":"https://api.github.com/repos/gballet/ldc/releases{/id}","created_at":"2014-07-28T07:34:47Z","updated_at":"2014-07-25T01:47:00Z","pushed_at":"2014-07-28T14:14:39Z","git_url":"git://github.com/gballet/ldc.git","ssh_url":"git@github.com:gballet/ldc.git","clone_url":"https://github.com/gballet/ldc.git","svn_url":"https://github.com/gballet/ldc","homepage":"http://wiki.dlang.org/LDC","size":22455,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ldc-developers:master","ref":"master","sha":"f937750474f28f8af71f3bd642743d3ba0c0218b","user":{"login":"ldc-developers","id":960112,"avatar_url":"https://avatars.githubusercontent.com/u/960112?","gravatar_id":"0a3e8d8165007fc31b9228917a591f2a","url":"https://api.github.com/users/ldc-developers","html_url":"https://github.com/ldc-developers","followers_url":"https://api.github.com/users/ldc-developers/followers","following_url":"https://api.github.com/users/ldc-developers/following{/other_user}","gists_url":"https://api.github.com/users/ldc-developers/gists{/gist_id}","starred_url":"https://api.github.com/users/ldc-developers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldc-developers/subscriptions","organizations_url":"https://api.github.com/users/ldc-developers/orgs","repos_url":"https://api.github.com/users/ldc-developers/repos","events_url":"https://api.github.com/users/ldc-developers/events{/privacy}","received_events_url":"https://api.github.com/users/ldc-developers/received_events","type":"Organization","site_admin":false},"repo":{"id":2174666,"name":"ldc","full_name":"ldc-developers/ldc","owner":{"login":"ldc-developers","id":960112,"avatar_url":"https://avatars.githubusercontent.com/u/960112?","gravatar_id":"0a3e8d8165007fc31b9228917a591f2a","url":"https://api.github.com/users/ldc-developers","html_url":"https://github.com/ldc-developers","followers_url":"https://api.github.com/users/ldc-developers/followers","following_url":"https://api.github.com/users/ldc-developers/following{/other_user}","gists_url":"https://api.github.com/users/ldc-developers/gists{/gist_id}","starred_url":"https://api.github.com/users/ldc-developers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldc-developers/subscriptions","organizations_url":"https://api.github.com/users/ldc-developers/orgs","repos_url":"https://api.github.com/users/ldc-developers/repos","events_url":"https://api.github.com/users/ldc-developers/events{/privacy}","received_events_url":"https://api.github.com/users/ldc-developers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ldc-developers/ldc","description":"The LLVM-based D compiler.","fork":false,"url":"https://api.github.com/repos/ldc-developers/ldc","forks_url":"https://api.github.com/repos/ldc-developers/ldc/forks","keys_url":"https://api.github.com/repos/ldc-developers/ldc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ldc-developers/ldc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ldc-developers/ldc/teams","hooks_url":"https://api.github.com/repos/ldc-developers/ldc/hooks","issue_events_url":"https://api.github.com/repos/ldc-developers/ldc/issues/events{/number}","events_url":"https://api.github.com/repos/ldc-developers/ldc/events","assignees_url":"https://api.github.com/repos/ldc-developers/ldc/assignees{/user}","branches_url":"https://api.github.com/repos/ldc-developers/ldc/branches{/branch}","tags_url":"https://api.github.com/repos/ldc-developers/ldc/tags","blobs_url":"https://api.github.com/repos/ldc-developers/ldc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ldc-developers/ldc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ldc-developers/ldc/git/refs{/sha}","trees_url":"https://api.github.com/repos/ldc-developers/ldc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ldc-developers/ldc/statuses/{sha}","languages_url":"https://api.github.com/repos/ldc-developers/ldc/languages","stargazers_url":"https://api.github.com/repos/ldc-developers/ldc/stargazers","contributors_url":"https://api.github.com/repos/ldc-developers/ldc/contributors","subscribers_url":"https://api.github.com/repos/ldc-developers/ldc/subscribers","subscription_url":"https://api.github.com/repos/ldc-developers/ldc/subscription","commits_url":"https://api.github.com/repos/ldc-developers/ldc/commits{/sha}","git_commits_url":"https://api.github.com/repos/ldc-developers/ldc/git/commits{/sha}","comments_url":"https://api.github.com/repos/ldc-developers/ldc/comments{/number}","issue_comment_url":"https://api.github.com/repos/ldc-developers/ldc/issues/comments/{number}","contents_url":"https://api.github.com/repos/ldc-developers/ldc/contents/{+path}","compare_url":"https://api.github.com/repos/ldc-developers/ldc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ldc-developers/ldc/merges","archive_url":"https://api.github.com/repos/ldc-developers/ldc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ldc-developers/ldc/downloads","issues_url":"https://api.github.com/repos/ldc-developers/ldc/issues{/number}","pulls_url":"https://api.github.com/repos/ldc-developers/ldc/pulls{/number}","milestones_url":"https://api.github.com/repos/ldc-developers/ldc/milestones{/number}","notifications_url":"https://api.github.com/repos/ldc-developers/ldc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ldc-developers/ldc/labels{/name}","releases_url":"https://api.github.com/repos/ldc-developers/ldc/releases{/id}","created_at":"2011-08-08T17:10:27Z","updated_at":"2014-07-25T01:47:00Z","pushed_at":"2014-07-29T07:48:34Z","git_url":"git://github.com/ldc-developers/ldc.git","ssh_url":"git@github.com:ldc-developers/ldc.git","clone_url":"https://github.com/ldc-developers/ldc.git","svn_url":"https://github.com/ldc-developers/ldc","homepage":"http://wiki.dlang.org/LDC","size":22455,"stargazers_count":281,"watchers_count":281,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":64,"mirror_url":null,"open_issues_count":110,"forks":64,"open_issues":110,"watchers":281,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ldc-developers/ldc/pulls/691"},"html":{"href":"https://github.com/ldc-developers/ldc/pull/691"},"issue":{"href":"https://api.github.com/repos/ldc-developers/ldc/issues/691"},"comments":{"href":"https://api.github.com/repos/ldc-developers/ldc/issues/691/comments"},"review_comments":{"href":"https://api.github.com/repos/ldc-developers/ldc/pulls/691/comments"},"review_comment":{"href":"https://api.github.com/repos/ldc-developers/ldc/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ldc-developers/ldc/pulls/691/commits"},"statuses":{"href":"https://api.github.com/repos/ldc-developers/ldc/statuses/eb32c672a4f9de43bd895936b85e44bffb7d6b25"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"redstar","id":827859,"avatar_url":"https://avatars.githubusercontent.com/u/827859?","gravatar_id":"07fa101e259a81d072e61abaa4caba5a","url":"https://api.github.com/users/redstar","html_url":"https://github.com/redstar","followers_url":"https://api.github.com/users/redstar/followers","following_url":"https://api.github.com/users/redstar/following{/other_user}","gists_url":"https://api.github.com/users/redstar/gists{/gist_id}","starred_url":"https://api.github.com/users/redstar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redstar/subscriptions","organizations_url":"https://api.github.com/users/redstar/orgs","repos_url":"https://api.github.com/users/redstar/repos","events_url":"https://api.github.com/users/redstar/events{/privacy}","received_events_url":"https://api.github.com/users/redstar/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}