GitHub PullRequestEvent at 2014-08-13 21:30:04
Repository: dimgui
Actor: AndrejMitrovic
Payload: {"action":"closed","number":3,"pull_request":{"url":"https://api.github.com/repos/d-gamedev-team/dimgui/pulls/3","id":18046201,"html_url":"https://github.com/d-gamedev-team/dimgui/pull/3","diff_url":"https://github.com/d-gamedev-team/dimgui/pull/3.diff","patch_url":"https://github.com/d-gamedev-team/dimgui/pull/3.patch","issue_url":"https://api.github.com/repos/d-gamedev-team/dimgui/issues/3","number":3,"state":"closed","locked":false,"title":"Never use negative-sized scissor.","user":{"login":"kiith-sa","id":746500,"avatar_url":"https://avatars.githubusercontent.com/u/746500?v=2","gravatar_id":"e03b884e46b481552bde8e1bb00b2763","url":"https://api.github.com/users/kiith-sa","html_url":"https://github.com/kiith-sa","followers_url":"https://api.github.com/users/kiith-sa/followers","following_url":"https://api.github.com/users/kiith-sa/following{/other_user}","gists_url":"https://api.github.com/users/kiith-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/kiith-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiith-sa/subscriptions","organizations_url":"https://api.github.com/users/kiith-sa/orgs","repos_url":"https://api.github.com/users/kiith-sa/repos","events_url":"https://api.github.com/users/kiith-sa/events{/privacy}","received_events_url":"https://api.github.com/users/kiith-sa/received_events","type":"User","site_admin":false},"body":"As the size of a scissor rectangle used in ScrollArea is defined as (width - something, height - something),\r\nthe rectangle would have negative size if e.g. the scissor area size is proportional to window size and the\r\nwindow gets resized to a small size. This would result in a segfault (at least on AMD Catalyst/Linux).\r\n\r\nE.g. when a user plays around with window width/height the program (even dimgui examples) would crash.\r\n\r\nI worked around this by forcing the scissor area to be at least 1x1 pixels large.","created_at":"2014-07-07T14:14:09Z","updated_at":"2014-08-13T21:30:04Z","closed_at":"2014-08-13T21:30:04Z","merged_at":"2014-08-13T21:30:04Z","merge_commit_sha":"a294646128a4bf65017af63d0820d518844f4e84","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/d-gamedev-team/dimgui/pulls/3/commits","review_comments_url":"https://api.github.com/repos/d-gamedev-team/dimgui/pulls/3/comments","review_comment_url":"https://api.github.com/repos/d-gamedev-team/dimgui/pulls/comments/{number}","comments_url":"https://api.github.com/repos/d-gamedev-team/dimgui/issues/3/comments","statuses_url":"https://api.github.com/repos/d-gamedev-team/dimgui/statuses/8fd1701f16e36e1996fccd8cd657fab25a0724e8","head":{"label":"kiith-sa:patch-1","ref":"patch-1","sha":"8fd1701f16e36e1996fccd8cd657fab25a0724e8","user":{"login":"kiith-sa","id":746500,"avatar_url":"https://avatars.githubusercontent.com/u/746500?v=2","gravatar_id":"e03b884e46b481552bde8e1bb00b2763","url":"https://api.github.com/users/kiith-sa","html_url":"https://github.com/kiith-sa","followers_url":"https://api.github.com/users/kiith-sa/followers","following_url":"https://api.github.com/users/kiith-sa/following{/other_user}","gists_url":"https://api.github.com/users/kiith-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/kiith-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiith-sa/subscriptions","organizations_url":"https://api.github.com/users/kiith-sa/orgs","repos_url":"https://api.github.com/users/kiith-sa/repos","events_url":"https://api.github.com/users/kiith-sa/events{/privacy}","received_events_url":"https://api.github.com/users/kiith-sa/received_events","type":"User","site_admin":false},"repo":{"id":21523419,"name":"dimgui","full_name":"kiith-sa/dimgui","owner":{"login":"kiith-sa","id":746500,"avatar_url":"https://avatars.githubusercontent.com/u/746500?v=2","gravatar_id":"e03b884e46b481552bde8e1bb00b2763","url":"https://api.github.com/users/kiith-sa","html_url":"https://github.com/kiith-sa","followers_url":"https://api.github.com/users/kiith-sa/followers","following_url":"https://api.github.com/users/kiith-sa/following{/other_user}","gists_url":"https://api.github.com/users/kiith-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/kiith-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiith-sa/subscriptions","organizations_url":"https://api.github.com/users/kiith-sa/orgs","repos_url":"https://api.github.com/users/kiith-sa/repos","events_url":"https://api.github.com/users/kiith-sa/events{/privacy}","received_events_url":"https://api.github.com/users/kiith-sa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kiith-sa/dimgui","description":"dimgui is a D port of the imgui OpenGL GUI library.","fork":true,"url":"https://api.github.com/repos/kiith-sa/dimgui","forks_url":"https://api.github.com/repos/kiith-sa/dimgui/forks","keys_url":"https://api.github.com/repos/kiith-sa/dimgui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kiith-sa/dimgui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kiith-sa/dimgui/teams","hooks_url":"https://api.github.com/repos/kiith-sa/dimgui/hooks","issue_events_url":"https://api.github.com/repos/kiith-sa/dimgui/issues/events{/number}","events_url":"https://api.github.com/repos/kiith-sa/dimgui/events","assignees_url":"https://api.github.com/repos/kiith-sa/dimgui/assignees{/user}","branches_url":"https://api.github.com/repos/kiith-sa/dimgui/branches{/branch}","tags_url":"https://api.github.com/repos/kiith-sa/dimgui/tags","blobs_url":"https://api.github.com/repos/kiith-sa/dimgui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kiith-sa/dimgui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kiith-sa/dimgui/git/refs{/sha}","trees_url":"https://api.github.com/repos/kiith-sa/dimgui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kiith-sa/dimgui/statuses/{sha}","languages_url":"https://api.github.com/repos/kiith-sa/dimgui/languages","stargazers_url":"https://api.github.com/repos/kiith-sa/dimgui/stargazers","contributors_url":"https://api.github.com/repos/kiith-sa/dimgui/contributors","subscribers_url":"https://api.github.com/repos/kiith-sa/dimgui/subscribers","subscription_url":"https://api.github.com/repos/kiith-sa/dimgui/subscription","commits_url":"https://api.github.com/repos/kiith-sa/dimgui/commits{/sha}","git_commits_url":"https://api.github.com/repos/kiith-sa/dimgui/git/commits{/sha}","comments_url":"https://api.github.com/repos/kiith-sa/dimgui/comments{/number}","issue_comment_url":"https://api.github.com/repos/kiith-sa/dimgui/issues/comments/{number}","contents_url":"https://api.github.com/repos/kiith-sa/dimgui/contents/{+path}","compare_url":"https://api.github.com/repos/kiith-sa/dimgui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kiith-sa/dimgui/merges","archive_url":"https://api.github.com/repos/kiith-sa/dimgui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kiith-sa/dimgui/downloads","issues_url":"https://api.github.com/repos/kiith-sa/dimgui/issues{/number}","pulls_url":"https://api.github.com/repos/kiith-sa/dimgui/pulls{/number}","milestones_url":"https://api.github.com/repos/kiith-sa/dimgui/milestones{/number}","notifications_url":"https://api.github.com/repos/kiith-sa/dimgui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kiith-sa/dimgui/labels{/name}","releases_url":"https://api.github.com/repos/kiith-sa/dimgui/releases{/id}","created_at":"2014-07-05T16:12:21Z","updated_at":"2014-07-07T14:13:52Z","pushed_at":"2014-07-09T12:29:19Z","git_url":"git://github.com/kiith-sa/dimgui.git","ssh_url":"git@github.com:kiith-sa/dimgui.git","clone_url":"https://github.com/kiith-sa/dimgui.git","svn_url":"https://github.com/kiith-sa/dimgui","homepage":null,"size":426,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"d-gamedev-team:master","ref":"master","sha":"b1c8d6649ab503e19f388dd970760b81ffc8d45e","user":{"login":"d-gamedev-team","id":7584266,"avatar_url":"https://avatars.githubusercontent.com/u/7584266?v=2","gravatar_id":null,"url":"https://api.github.com/users/d-gamedev-team","html_url":"https://github.com/d-gamedev-team","followers_url":"https://api.github.com/users/d-gamedev-team/followers","following_url":"https://api.github.com/users/d-gamedev-team/following{/other_user}","gists_url":"https://api.github.com/users/d-gamedev-team/gists{/gist_id}","starred_url":"https://api.github.com/users/d-gamedev-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d-gamedev-team/subscriptions","organizations_url":"https://api.github.com/users/d-gamedev-team/orgs","repos_url":"https://api.github.com/users/d-gamedev-team/repos","events_url":"https://api.github.com/users/d-gamedev-team/events{/privacy}","received_events_url":"https://api.github.com/users/d-gamedev-team/received_events","type":"Organization","site_admin":false},"repo":{"id":19857941,"name":"dimgui","full_name":"d-gamedev-team/dimgui","owner":{"login":"d-gamedev-team","id":7584266,"avatar_url":"https://avatars.githubusercontent.com/u/7584266?v=2","gravatar_id":null,"url":"https://api.github.com/users/d-gamedev-team","html_url":"https://github.com/d-gamedev-team","followers_url":"https://api.github.com/users/d-gamedev-team/followers","following_url":"https://api.github.com/users/d-gamedev-team/following{/other_user}","gists_url":"https://api.github.com/users/d-gamedev-team/gists{/gist_id}","starred_url":"https://api.github.com/users/d-gamedev-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d-gamedev-team/subscriptions","organizations_url":"https://api.github.com/users/d-gamedev-team/orgs","repos_url":"https://api.github.com/users/d-gamedev-team/repos","events_url":"https://api.github.com/users/d-gamedev-team/events{/privacy}","received_events_url":"https://api.github.com/users/d-gamedev-team/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/d-gamedev-team/dimgui","description":"dimgui is a D port of the imgui OpenGL GUI library.","fork":false,"url":"https://api.github.com/repos/d-gamedev-team/dimgui","forks_url":"https://api.github.com/repos/d-gamedev-team/dimgui/forks","keys_url":"https://api.github.com/repos/d-gamedev-team/dimgui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/d-gamedev-team/dimgui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/d-gamedev-team/dimgui/teams","hooks_url":"https://api.github.com/repos/d-gamedev-team/dimgui/hooks","issue_events_url":"https://api.github.com/repos/d-gamedev-team/dimgui/issues/events{/number}","events_url":"https://api.github.com/repos/d-gamedev-team/dimgui/events","assignees_url":"https://api.github.com/repos/d-gamedev-team/dimgui/assignees{/user}","branches_url":"https://api.github.com/repos/d-gamedev-team/dimgui/branches{/branch}","tags_url":"https://api.github.com/repos/d-gamedev-team/dimgui/tags","blobs_url":"https://api.github.com/repos/d-gamedev-team/dimgui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/d-gamedev-team/dimgui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/d-gamedev-team/dimgui/git/refs{/sha}","trees_url":"https://api.github.com/repos/d-gamedev-team/dimgui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/d-gamedev-team/dimgui/statuses/{sha}","languages_url":"https://api.github.com/repos/d-gamedev-team/dimgui/languages","stargazers_url":"https://api.github.com/repos/d-gamedev-team/dimgui/stargazers","contributors_url":"https://api.github.com/repos/d-gamedev-team/dimgui/contributors","subscribers_url":"https://api.github.com/repos/d-gamedev-team/dimgui/subscribers","subscription_url":"https://api.github.com/repos/d-gamedev-team/dimgui/subscription","commits_url":"https://api.github.com/repos/d-gamedev-team/dimgui/commits{/sha}","git_commits_url":"https://api.github.com/repos/d-gamedev-team/dimgui/git/commits{/sha}","comments_url":"https://api.github.com/repos/d-gamedev-team/dimgui/comments{/number}","issue_comment_url":"https://api.github.com/repos/d-gamedev-team/dimgui/issues/comments/{number}","contents_url":"https://api.github.com/repos/d-gamedev-team/dimgui/contents/{+path}","compare_url":"https://api.github.com/repos/d-gamedev-team/dimgui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/d-gamedev-team/dimgui/merges","archive_url":"https://api.github.com/repos/d-gamedev-team/dimgui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/d-gamedev-team/dimgui/downloads","issues_url":"https://api.github.com/repos/d-gamedev-team/dimgui/issues{/number}","pulls_url":"https://api.github.com/repos/d-gamedev-team/dimgui/pulls{/number}","milestones_url":"https://api.github.com/repos/d-gamedev-team/dimgui/milestones{/number}","notifications_url":"https://api.github.com/repos/d-gamedev-team/dimgui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/d-gamedev-team/dimgui/labels{/name}","releases_url":"https://api.github.com/repos/d-gamedev-team/dimgui/releases{/id}","created_at":"2014-05-16T13:46:37Z","updated_at":"2014-08-13T21:29:40Z","pushed_at":"2014-08-13T21:30:04Z","git_url":"git://github.com/d-gamedev-team/dimgui.git","ssh_url":"git@github.com:d-gamedev-team/dimgui.git","clone_url":"https://github.com/d-gamedev-team/dimgui.git","svn_url":"https://github.com/d-gamedev-team/dimgui","homepage":null,"size":651,"stargazers_count":11,"watchers_count":11,"language":"D","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/d-gamedev-team/dimgui/pulls/3"},"html":{"href":"https://github.com/d-gamedev-team/dimgui/pull/3"},"issue":{"href":"https://api.github.com/repos/d-gamedev-team/dimgui/issues/3"},"comments":{"href":"https://api.github.com/repos/d-gamedev-team/dimgui/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/d-gamedev-team/dimgui/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/d-gamedev-team/dimgui/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/d-gamedev-team/dimgui/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/d-gamedev-team/dimgui/statuses/8fd1701f16e36e1996fccd8cd657fab25a0724e8"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"AndrejMitrovic","id":360179,"avatar_url":"https://avatars.githubusercontent.com/u/360179?v=2","gravatar_id":"6b80b27e0030320efddd03358546176a","url":"https://api.github.com/users/AndrejMitrovic","html_url":"https://github.com/AndrejMitrovic","followers_url":"https://api.github.com/users/AndrejMitrovic/followers","following_url":"https://api.github.com/users/AndrejMitrovic/following{/other_user}","gists_url":"https://api.github.com/users/AndrejMitrovic/gists{/gist_id}","starred_url":"https://api.github.com/users/AndrejMitrovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndrejMitrovic/subscriptions","organizations_url":"https://api.github.com/users/AndrejMitrovic/orgs","repos_url":"https://api.github.com/users/AndrejMitrovic/repos","events_url":"https://api.github.com/users/AndrejMitrovic/events{/privacy}","received_events_url":"https://api.github.com/users/AndrejMitrovic/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":6,"deletions":1,"changed_files":1}}