GitHub PullRequestReviewCommentEvent at 2014-12-01 18:48:21
Repository: tamagochiApp
Actor: mpaillet3821
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/ansraliant/tamagochiApp/pulls/comments/21109329","id":21109329,"diff_hunk":"@@ -0,0 +1,83 @@\n+//\n+//  MascotListViewController.m\n+//  tamagochiApp\n+//\n+//  Created by Gabriel Verdi on 11/28/14.\n+//  Copyright (c) 2014 globant. All rights reserved.\n+//\n+\n+#import \"MascotListViewController.h\"\n+#import \"AnimalServiceGetAll.h\"\n+#import \"MascotCellTableViewCell.h\"\n+#import \"Animal.h\"\n+#import \"AlertHelper.h\"\n+\n+#define customCellName @\"MascotCellTableViewCell\"\n+\n+@interface MascotListViewController()\n+\n+@property (strong, nonatomic) IBOutlet UITableView *mascotTable;\n+@property (strong,nonatomic) NSMutableArray* animals;\n+\n+@end\n+\n+@implementation MascotListViewController\n+\n+- (void)viewDidLoad {\n+    [super viewDidLoad];\n+    // Do any additional setup after loading the view from its nib.\n+\tAnimalServiceGetAll* animalService = [[AnimalServiceGetAll alloc] init];\n+\t//get all animals from server\n+\tself.animals = [[NSMutableArray alloc] init];\n+\t__weak typeof(self) weakerSelf = self;\n+\t[animalService getAllMascotsSucess:^(NSURLSessionDataTask *operation, id responseObject) {\n+\t\tfor (NSDictionary* item in responseObject) {\n+\t\t\tAnimal* animal = [[Animal alloc] initWithDictionary:item];","path":"tamagochiApp/tamagochiApp/UIViews/mascotListView/MascotListViewController.m","position":35,"original_position":35,"commit_id":"f2fdc8a91aa2724cbaf0a7052bfc18461a7d5630","original_commit_id":"f2fdc8a91aa2724cbaf0a7052bfc18461a7d5630","user":{"login":"mpaillet3821","id":3063833,"avatar_url":"https://avatars.githubusercontent.com/u/3063833?v=3","gravatar_id":"","url":"https://api.github.com/users/mpaillet3821","html_url":"https://github.com/mpaillet3821","followers_url":"https://api.github.com/users/mpaillet3821/followers","following_url":"https://api.github.com/users/mpaillet3821/following{/other_user}","gists_url":"https://api.github.com/users/mpaillet3821/gists{/gist_id}","starred_url":"https://api.github.com/users/mpaillet3821/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpaillet3821/subscriptions","organizations_url":"https://api.github.com/users/mpaillet3821/orgs","repos_url":"https://api.github.com/users/mpaillet3821/repos","events_url":"https://api.github.com/users/mpaillet3821/events{/privacy}","received_events_url":"https://api.github.com/users/mpaillet3821/received_events","type":"User","site_admin":false},"body":"Perfecto tener un constructor al que le pases el dictionary y te arme el objeto de negocio solo.! Bien laburado!\r\n\r\nTip para pensar, quizás te convenga mover todo el \"Parseo\" al servicio. Suponete que uses este servicio en 3 o 4 lugares más, al tenerlo en el completionBlock, vas a terminar codeando el aprseo en 4 lugares distintos, y si mañana cambia algo lo tienes que cambiar en los 4... ","created_at":"2014-12-01T18:48:21Z","updated_at":"2014-12-01T18:48:21Z","html_url":"https://github.com/ansraliant/tamagochiApp/pull/10#discussion_r21109329","pull_request_url":"https://api.github.com/repos/ansraliant/tamagochiApp/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/ansraliant/tamagochiApp/pulls/comments/21109329"},"html":{"href":"https://github.com/ansraliant/tamagochiApp/pull/10#discussion_r21109329"},"pull_request":{"href":"https://api.github.com/repos/ansraliant/tamagochiApp/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/ansraliant/tamagochiApp/pulls/10","id":25275595,"html_url":"https://github.com/ansraliant/tamagochiApp/pull/10","diff_url":"https://github.com/ansraliant/tamagochiApp/pull/10.diff","patch_url":"https://github.com/ansraliant/tamagochiApp/pull/10.patch","issue_url":"https://api.github.com/repos/ansraliant/tamagochiApp/issues/10","number":10,"state":"open","locked":false,"title":"Added Mascot List","user":{"login":"ansraliant","id":7121475,"avatar_url":"https://avatars.githubusercontent.com/u/7121475?v=3","gravatar_id":"","url":"https://api.github.com/users/ansraliant","html_url":"https://github.com/ansraliant","followers_url":"https://api.github.com/users/ansraliant/followers","following_url":"https://api.github.com/users/ansraliant/following{/other_user}","gists_url":"https://api.github.com/users/ansraliant/gists{/gist_id}","starred_url":"https://api.github.com/users/ansraliant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansraliant/subscriptions","organizations_url":"https://api.github.com/users/ansraliant/orgs","repos_url":"https://api.github.com/users/ansraliant/repos","events_url":"https://api.github.com/users/ansraliant/events{/privacy}","received_events_url":"https://api.github.com/users/ansraliant/received_events","type":"User","site_admin":false},"body":"Created mascot ranking list. ","created_at":"2014-12-01T15:31:41Z","updated_at":"2014-12-01T18:48:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b2f5e6aed5edca0668bcab3fd320a7af8c053816","assignee":{"login":"Matiasrf","id":3329813,"avatar_url":"https://avatars.githubusercontent.com/u/3329813?v=3","gravatar_id":"","url":"https://api.github.com/users/Matiasrf","html_url":"https://github.com/Matiasrf","followers_url":"https://api.github.com/users/Matiasrf/followers","following_url":"https://api.github.com/users/Matiasrf/following{/other_user}","gists_url":"https://api.github.com/users/Matiasrf/gists{/gist_id}","starred_url":"https://api.github.com/users/Matiasrf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Matiasrf/subscriptions","organizations_url":"https://api.github.com/users/Matiasrf/orgs","repos_url":"https://api.github.com/users/Matiasrf/repos","events_url":"https://api.github.com/users/Matiasrf/events{/privacy}","received_events_url":"https://api.github.com/users/Matiasrf/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/ansraliant/tamagochiApp/pulls/10/commits","review_comments_url":"https://api.github.com/repos/ansraliant/tamagochiApp/pulls/10/comments","review_comment_url":"https://api.github.com/repos/ansraliant/tamagochiApp/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ansraliant/tamagochiApp/issues/10/comments","statuses_url":"https://api.github.com/repos/ansraliant/tamagochiApp/statuses/f2fdc8a91aa2724cbaf0a7052bfc18461a7d5630","head":{"label":"ansraliant:weekendChallenge2","ref":"weekendChallenge2","sha":"f2fdc8a91aa2724cbaf0a7052bfc18461a7d5630","user":{"login":"ansraliant","id":7121475,"avatar_url":"https://avatars.githubusercontent.com/u/7121475?v=3","gravatar_id":"","url":"https://api.github.com/users/ansraliant","html_url":"https://github.com/ansraliant","followers_url":"https://api.github.com/users/ansraliant/followers","following_url":"https://api.github.com/users/ansraliant/following{/other_user}","gists_url":"https://api.github.com/users/ansraliant/gists{/gist_id}","starred_url":"https://api.github.com/users/ansraliant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansraliant/subscriptions","organizations_url":"https://api.github.com/users/ansraliant/orgs","repos_url":"https://api.github.com/users/ansraliant/repos","events_url":"https://api.github.com/users/ansraliant/events{/privacy}","received_events_url":"https://api.github.com/users/ansraliant/received_events","type":"User","site_admin":false},"repo":{"id":26824361,"name":"tamagochiApp","full_name":"ansraliant/tamagochiApp","owner":{"login":"ansraliant","id":7121475,"avatar_url":"https://avatars.githubusercontent.com/u/7121475?v=3","gravatar_id":"","url":"https://api.github.com/users/ansraliant","html_url":"https://github.com/ansraliant","followers_url":"https://api.github.com/users/ansraliant/followers","following_url":"https://api.github.com/users/ansraliant/following{/other_user}","gists_url":"https://api.github.com/users/ansraliant/gists{/gist_id}","starred_url":"https://api.github.com/users/ansraliant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansraliant/subscriptions","organizations_url":"https://api.github.com/users/ansraliant/orgs","repos_url":"https://api.github.com/users/ansraliant/repos","events_url":"https://api.github.com/users/ansraliant/events{/privacy}","received_events_url":"https://api.github.com/users/ansraliant/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ansraliant/tamagochiApp","description":"Test App Tamagochi","fork":false,"url":"https://api.github.com/repos/ansraliant/tamagochiApp","forks_url":"https://api.github.com/repos/ansraliant/tamagochiApp/forks","keys_url":"https://api.github.com/repos/ansraliant/tamagochiApp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ansraliant/tamagochiApp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ansraliant/tamagochiApp/teams","hooks_url":"https://api.github.com/repos/ansraliant/tamagochiApp/hooks","issue_events_url":"https://api.github.com/repos/ansraliant/tamagochiApp/issues/events{/number}","events_url":"https://api.github.com/repos/ansraliant/tamagochiApp/events","assignees_url":"https://api.github.com/repos/ansraliant/tamagochiApp/assignees{/user}","branches_url":"https://api.github.com/repos/ansraliant/tamagochiApp/branches{/branch}","tags_url":"https://api.github.com/repos/ansraliant/tamagochiApp/tags","blobs_url":"https://api.github.com/repos/ansraliant/tamagochiApp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ansraliant/tamagochiApp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ansraliant/tamagochiApp/git/refs{/sha}","trees_url":"https://api.github.com/repos/ansraliant/tamagochiApp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ansraliant/tamagochiApp/statuses/{sha}","languages_url":"https://api.github.com/repos/ansraliant/tamagochiApp/languages","stargazers_url":"https://api.github.com/repos/ansraliant/tamagochiApp/stargazers","contributors_url":"https://api.github.com/repos/ansraliant/tamagochiApp/contributors","subscribers_url":"https://api.github.com/repos/ansraliant/tamagochiApp/subscribers","subscription_url":"https://api.github.com/repos/ansraliant/tamagochiApp/subscription","commits_url":"https://api.github.com/repos/ansraliant/tamagochiApp/commits{/sha}","git_commits_url":"https://api.github.com/repos/ansraliant/tamagochiApp/git/commits{/sha}","comments_url":"https://api.github.com/repos/ansraliant/tamagochiApp/comments{/number}","issue_comment_url":"https://api.github.com/repos/ansraliant/tamagochiApp/issues/comments/{number}","contents_url":"https://api.github.com/repos/ansraliant/tamagochiApp/contents/{+path}","compare_url":"https://api.github.com/repos/ansraliant/tamagochiApp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ansraliant/tamagochiApp/merges","archive_url":"https://api.github.com/repos/ansraliant/tamagochiApp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ansraliant/tamagochiApp/downloads","issues_url":"https://api.github.com/repos/ansraliant/tamagochiApp/issues{/number}","pulls_url":"https://api.github.com/repos/ansraliant/tamagochiApp/pulls{/number}","milestones_url":"https://api.github.com/repos/ansraliant/tamagochiApp/milestones{/number}","notifications_url":"https://api.github.com/repos/ansraliant/tamagochiApp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ansraliant/tamagochiApp/labels{/name}","releases_url":"https://api.github.com/repos/ansraliant/tamagochiApp/releases{/id}","created_at":"2014-11-18T18:45:59Z","updated_at":"2014-11-28T22:07:35Z","pushed_at":"2014-12-01T15:55:22Z","git_url":"git://github.com/ansraliant/tamagochiApp.git","ssh_url":"git@github.com:ansraliant/tamagochiApp.git","clone_url":"https://github.com/ansraliant/tamagochiApp.git","svn_url":"https://github.com/ansraliant/tamagochiApp","homepage":null,"size":6268,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"base":{"label":"ansraliant:master","ref":"master","sha":"863e8cbb46a26111800508b9716d5b9605a97471","user":{"login":"ansraliant","id":7121475,"avatar_url":"https://avatars.githubusercontent.com/u/7121475?v=3","gravatar_id":"","url":"https://api.github.com/users/ansraliant","html_url":"https://github.com/ansraliant","followers_url":"https://api.github.com/users/ansraliant/followers","following_url":"https://api.github.com/users/ansraliant/following{/other_user}","gists_url":"https://api.github.com/users/ansraliant/gists{/gist_id}","starred_url":"https://api.github.com/users/ansraliant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansraliant/subscriptions","organizations_url":"https://api.github.com/users/ansraliant/orgs","repos_url":"https://api.github.com/users/ansraliant/repos","events_url":"https://api.github.com/users/ansraliant/events{/privacy}","received_events_url":"https://api.github.com/users/ansraliant/received_events","type":"User","site_admin":false},"repo":{"id":26824361,"name":"tamagochiApp","full_name":"ansraliant/tamagochiApp","owner":{"login":"ansraliant","id":7121475,"avatar_url":"https://avatars.githubusercontent.com/u/7121475?v=3","gravatar_id":"","url":"https://api.github.com/users/ansraliant","html_url":"https://github.com/ansraliant","followers_url":"https://api.github.com/users/ansraliant/followers","following_url":"https://api.github.com/users/ansraliant/following{/other_user}","gists_url":"https://api.github.com/users/ansraliant/gists{/gist_id}","starred_url":"https://api.github.com/users/ansraliant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansraliant/subscriptions","organizations_url":"https://api.github.com/users/ansraliant/orgs","repos_url":"https://api.github.com/users/ansraliant/repos","events_url":"https://api.github.com/users/ansraliant/events{/privacy}","received_events_url":"https://api.github.com/users/ansraliant/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ansraliant/tamagochiApp","description":"Test App Tamagochi","fork":false,"url":"https://api.github.com/repos/ansraliant/tamagochiApp","forks_url":"https://api.github.com/repos/ansraliant/tamagochiApp/forks","keys_url":"https://api.github.com/repos/ansraliant/tamagochiApp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ansraliant/tamagochiApp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ansraliant/tamagochiApp/teams","hooks_url":"https://api.github.com/repos/ansraliant/tamagochiApp/hooks","issue_events_url":"https://api.github.com/repos/ansraliant/tamagochiApp/issues/events{/number}","events_url":"https://api.github.com/repos/ansraliant/tamagochiApp/events","assignees_url":"https://api.github.com/repos/ansraliant/tamagochiApp/assignees{/user}","branches_url":"https://api.github.com/repos/ansraliant/tamagochiApp/branches{/branch}","tags_url":"https://api.github.com/repos/ansraliant/tamagochiApp/tags","blobs_url":"https://api.github.com/repos/ansraliant/tamagochiApp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ansraliant/tamagochiApp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ansraliant/tamagochiApp/git/refs{/sha}","trees_url":"https://api.github.com/repos/ansraliant/tamagochiApp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ansraliant/tamagochiApp/statuses/{sha}","languages_url":"https://api.github.com/repos/ansraliant/tamagochiApp/languages","stargazers_url":"https://api.github.com/repos/ansraliant/tamagochiApp/stargazers","contributors_url":"https://api.github.com/repos/ansraliant/tamagochiApp/contributors","subscribers_url":"https://api.github.com/repos/ansraliant/tamagochiApp/subscribers","subscription_url":"https://api.github.com/repos/ansraliant/tamagochiApp/subscription","commits_url":"https://api.github.com/repos/ansraliant/tamagochiApp/commits{/sha}","git_commits_url":"https://api.github.com/repos/ansraliant/tamagochiApp/git/commits{/sha}","comments_url":"https://api.github.com/repos/ansraliant/tamagochiApp/comments{/number}","issue_comment_url":"https://api.github.com/repos/ansraliant/tamagochiApp/issues/comments/{number}","contents_url":"https://api.github.com/repos/ansraliant/tamagochiApp/contents/{+path}","compare_url":"https://api.github.com/repos/ansraliant/tamagochiApp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ansraliant/tamagochiApp/merges","archive_url":"https://api.github.com/repos/ansraliant/tamagochiApp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ansraliant/tamagochiApp/downloads","issues_url":"https://api.github.com/repos/ansraliant/tamagochiApp/issues{/number}","pulls_url":"https://api.github.com/repos/ansraliant/tamagochiApp/pulls{/number}","milestones_url":"https://api.github.com/repos/ansraliant/tamagochiApp/milestones{/number}","notifications_url":"https://api.github.com/repos/ansraliant/tamagochiApp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ansraliant/tamagochiApp/labels{/name}","releases_url":"https://api.github.com/repos/ansraliant/tamagochiApp/releases{/id}","created_at":"2014-11-18T18:45:59Z","updated_at":"2014-11-28T22:07:35Z","pushed_at":"2014-12-01T15:55:22Z","git_url":"git://github.com/ansraliant/tamagochiApp.git","ssh_url":"git@github.com:ansraliant/tamagochiApp.git","clone_url":"https://github.com/ansraliant/tamagochiApp.git","svn_url":"https://github.com/ansraliant/tamagochiApp","homepage":null,"size":6268,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ansraliant/tamagochiApp/pulls/10"},"html":{"href":"https://github.com/ansraliant/tamagochiApp/pull/10"},"issue":{"href":"https://api.github.com/repos/ansraliant/tamagochiApp/issues/10"},"comments":{"href":"https://api.github.com/repos/ansraliant/tamagochiApp/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/ansraliant/tamagochiApp/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/ansraliant/tamagochiApp/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ansraliant/tamagochiApp/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/ansraliant/tamagochiApp/statuses/f2fdc8a91aa2724cbaf0a7052bfc18461a7d5630"}}}}