GitHub PullRequestEvent at 2014-06-24 10:44:37
Repository: pombola
Actor: jacksonj04
Payload: {"action":"closed","number":1408,"pull_request":{"url":"https://api.github.com/repos/mysociety/pombola/pulls/1408","id":15426385,"html_url":"https://github.com/mysociety/pombola/pull/1408","diff_url":"https://github.com/mysociety/pombola/pull/1408.diff","patch_url":"https://github.com/mysociety/pombola/pull/1408.patch","issue_url":"https://api.github.com/repos/mysociety/pombola/issues/1408","number":1408,"state":"closed","title":"ZA: Election Pages","user":{"login":"jacksonj04","id":619082,"avatar_url":"https://avatars.githubusercontent.com/u/619082?","gravatar_id":"c7f3b4756d808ef0e2548bd0965ac225","url":"https://api.github.com/users/jacksonj04","html_url":"https://github.com/jacksonj04","followers_url":"https://api.github.com/users/jacksonj04/followers","following_url":"https://api.github.com/users/jacksonj04/following{/other_user}","gists_url":"https://api.github.com/users/jacksonj04/gists{/gist_id}","starred_url":"https://api.github.com/users/jacksonj04/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacksonj04/subscriptions","organizations_url":"https://api.github.com/users/jacksonj04/orgs","repos_url":"https://api.github.com/users/jacksonj04/repos","events_url":"https://api.github.com/users/jacksonj04/events{/privacy}","received_events_url":"https://api.github.com/users/jacksonj04/received_events","type":"User","site_admin":false},"body":"Still to do (mostly from comments on #1387)\r\n\r\n- [x] current highlighting of top tabs\r\n- [x] Boilerplate text replacement\r\n- [x] List of provinces/way to change province from a province page\r\n- [x] Way to get to province+party page from party page (so list of provinces on national/party/anc/ at least?)\r\n- [x] Party page (be it national/party/anc/ or provincial/eastern-cape/party/anc/) needs styling\r\n- [x] Provincial page \"View all\" links don't link to pages that do exist\r\n- [x] Missing view for View all on national province page - e.g. national/province/eastern-cape/party/anc/ )\r\n- [x] Ordering of people by position title\r\n- [x] Links to candidate profiles\r\n- [ ] would it be possible to style links to people who have held political office in the past a different colour?\r\n- [x] Currently all parties are listed, but not all parties are contesting the elections and some are only contesting some elections (e.g. a single province), which is resulting in broken links. The code [here](https://gist.github.com/geoffkilpin/3a51fa56e0b0400d0360#file-gistfile1-py-L7) is one (not particularly clean) way of getting the correct list.\r\n- [x] Show a friendly name for provinces rather than the slug name (http://za.mzalendo.dev.mysociety.org/election/2014/national/province/eastern-cape/)\r\n- [x] Add national party list underneath regional people on province+party pages(http://za.mzalendo.dev.mysociety.org/election/2014/national/province/eastern-cape/acdp/ )\r\n- [x] Replace the current output of party name \"Azanian People's Organisation Regional KwaZulu-Natal Election List 2014 \" with just the party name \"Azanian People's Organisation\"","created_at":"2014-05-02T10:32:52Z","updated_at":"2014-06-24T10:44:37Z","closed_at":"2014-06-24T10:44:37Z","merged_at":null,"merge_commit_sha":"db0a0afac489a87075a3bcaddfc4c84f42a3e335","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mysociety/pombola/pulls/1408/commits","review_comments_url":"https://api.github.com/repos/mysociety/pombola/pulls/1408/comments","review_comment_url":"https://api.github.com/repos/mysociety/pombola/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mysociety/pombola/issues/1408/comments","statuses_url":"https://api.github.com/repos/mysociety/pombola/statuses/89f3140b180676e2298607662e6a54db2e3d28dc","head":{"label":"mysociety:za-election-pages","ref":"za-election-pages","sha":"89f3140b180676e2298607662e6a54db2e3d28dc","user":{"login":"mysociety","id":141338,"avatar_url":"https://avatars.githubusercontent.com/u/141338?","gravatar_id":"cb4e9c9ec6d33ee844baa03bd8f58cd3","url":"https://api.github.com/users/mysociety","html_url":"https://github.com/mysociety","followers_url":"https://api.github.com/users/mysociety/followers","following_url":"https://api.github.com/users/mysociety/following{/other_user}","gists_url":"https://api.github.com/users/mysociety/gists{/gist_id}","starred_url":"https://api.github.com/users/mysociety/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mysociety/subscriptions","organizations_url":"https://api.github.com/users/mysociety/orgs","repos_url":"https://api.github.com/users/mysociety/repos","events_url":"https://api.github.com/users/mysociety/events{/privacy}","received_events_url":"https://api.github.com/users/mysociety/received_events","type":"Organization","site_admin":false},"repo":{"id":1994469,"name":"pombola","full_name":"mysociety/pombola","owner":{"login":"mysociety","id":141338,"avatar_url":"https://avatars.githubusercontent.com/u/141338?","gravatar_id":"cb4e9c9ec6d33ee844baa03bd8f58cd3","url":"https://api.github.com/users/mysociety","html_url":"https://github.com/mysociety","followers_url":"https://api.github.com/users/mysociety/followers","following_url":"https://api.github.com/users/mysociety/following{/other_user}","gists_url":"https://api.github.com/users/mysociety/gists{/gist_id}","starred_url":"https://api.github.com/users/mysociety/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mysociety/subscriptions","organizations_url":"https://api.github.com/users/mysociety/orgs","repos_url":"https://api.github.com/users/mysociety/repos","events_url":"https://api.github.com/users/mysociety/events{/privacy}","received_events_url":"https://api.github.com/users/mysociety/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mysociety/pombola","description":"Pombola is a parliamentary monitoring (PMO) platform, its biggest instance is Mzalendo, a volunteer run project whose mission is to \"keep an eye on the Kenyan Parliament\".","fork":false,"url":"https://api.github.com/repos/mysociety/pombola","forks_url":"https://api.github.com/repos/mysociety/pombola/forks","keys_url":"https://api.github.com/repos/mysociety/pombola/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mysociety/pombola/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mysociety/pombola/teams","hooks_url":"https://api.github.com/repos/mysociety/pombola/hooks","issue_events_url":"https://api.github.com/repos/mysociety/pombola/issues/events{/number}","events_url":"https://api.github.com/repos/mysociety/pombola/events","assignees_url":"https://api.github.com/repos/mysociety/pombola/assignees{/user}","branches_url":"https://api.github.com/repos/mysociety/pombola/branches{/branch}","tags_url":"https://api.github.com/repos/mysociety/pombola/tags","blobs_url":"https://api.github.com/repos/mysociety/pombola/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mysociety/pombola/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mysociety/pombola/git/refs{/sha}","trees_url":"https://api.github.com/repos/mysociety/pombola/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mysociety/pombola/statuses/{sha}","languages_url":"https://api.github.com/repos/mysociety/pombola/languages","stargazers_url":"https://api.github.com/repos/mysociety/pombola/stargazers","contributors_url":"https://api.github.com/repos/mysociety/pombola/contributors","subscribers_url":"https://api.github.com/repos/mysociety/pombola/subscribers","subscription_url":"https://api.github.com/repos/mysociety/pombola/subscription","commits_url":"https://api.github.com/repos/mysociety/pombola/commits{/sha}","git_commits_url":"https://api.github.com/repos/mysociety/pombola/git/commits{/sha}","comments_url":"https://api.github.com/repos/mysociety/pombola/comments{/number}","issue_comment_url":"https://api.github.com/repos/mysociety/pombola/issues/comments/{number}","contents_url":"https://api.github.com/repos/mysociety/pombola/contents/{+path}","compare_url":"https://api.github.com/repos/mysociety/pombola/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mysociety/pombola/merges","archive_url":"https://api.github.com/repos/mysociety/pombola/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mysociety/pombola/downloads","issues_url":"https://api.github.com/repos/mysociety/pombola/issues{/number}","pulls_url":"https://api.github.com/repos/mysociety/pombola/pulls{/number}","milestones_url":"https://api.github.com/repos/mysociety/pombola/milestones{/number}","notifications_url":"https://api.github.com/repos/mysociety/pombola/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mysociety/pombola/labels{/name}","releases_url":"https://api.github.com/repos/mysociety/pombola/releases{/id}","created_at":"2011-07-04T08:46:51Z","updated_at":"2014-06-24T10:44:37Z","pushed_at":"2014-06-24T10:44:37Z","git_url":"git://github.com/mysociety/pombola.git","ssh_url":"git@github.com:mysociety/pombola.git","clone_url":"https://github.com/mysociety/pombola.git","svn_url":"https://github.com/mysociety/pombola","homepage":"http://www.mysociety.org/projects/parliamentarymonitoring/pombola/","size":23906,"stargazers_count":26,"watchers_count":26,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":19,"mirror_url":null,"open_issues_count":156,"forks":19,"open_issues":156,"watchers":26,"default_branch":"master"}},"base":{"label":"mysociety:master","ref":"master","sha":"78863627d6495f8cfba1c0b510c081fabd6fc626","user":{"login":"mysociety","id":141338,"avatar_url":"https://avatars.githubusercontent.com/u/141338?","gravatar_id":"cb4e9c9ec6d33ee844baa03bd8f58cd3","url":"https://api.github.com/users/mysociety","html_url":"https://github.com/mysociety","followers_url":"https://api.github.com/users/mysociety/followers","following_url":"https://api.github.com/users/mysociety/following{/other_user}","gists_url":"https://api.github.com/users/mysociety/gists{/gist_id}","starred_url":"https://api.github.com/users/mysociety/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mysociety/subscriptions","organizations_url":"https://api.github.com/users/mysociety/orgs","repos_url":"https://api.github.com/users/mysociety/repos","events_url":"https://api.github.com/users/mysociety/events{/privacy}","received_events_url":"https://api.github.com/users/mysociety/received_events","type":"Organization","site_admin":false},"repo":{"id":1994469,"name":"pombola","full_name":"mysociety/pombola","owner":{"login":"mysociety","id":141338,"avatar_url":"https://avatars.githubusercontent.com/u/141338?","gravatar_id":"cb4e9c9ec6d33ee844baa03bd8f58cd3","url":"https://api.github.com/users/mysociety","html_url":"https://github.com/mysociety","followers_url":"https://api.github.com/users/mysociety/followers","following_url":"https://api.github.com/users/mysociety/following{/other_user}","gists_url":"https://api.github.com/users/mysociety/gists{/gist_id}","starred_url":"https://api.github.com/users/mysociety/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mysociety/subscriptions","organizations_url":"https://api.github.com/users/mysociety/orgs","repos_url":"https://api.github.com/users/mysociety/repos","events_url":"https://api.github.com/users/mysociety/events{/privacy}","received_events_url":"https://api.github.com/users/mysociety/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mysociety/pombola","description":"Pombola is a parliamentary monitoring (PMO) platform, its biggest instance is Mzalendo, a volunteer run project whose mission is to \"keep an eye on the Kenyan Parliament\".","fork":false,"url":"https://api.github.com/repos/mysociety/pombola","forks_url":"https://api.github.com/repos/mysociety/pombola/forks","keys_url":"https://api.github.com/repos/mysociety/pombola/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mysociety/pombola/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mysociety/pombola/teams","hooks_url":"https://api.github.com/repos/mysociety/pombola/hooks","issue_events_url":"https://api.github.com/repos/mysociety/pombola/issues/events{/number}","events_url":"https://api.github.com/repos/mysociety/pombola/events","assignees_url":"https://api.github.com/repos/mysociety/pombola/assignees{/user}","branches_url":"https://api.github.com/repos/mysociety/pombola/branches{/branch}","tags_url":"https://api.github.com/repos/mysociety/pombola/tags","blobs_url":"https://api.github.com/repos/mysociety/pombola/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mysociety/pombola/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mysociety/pombola/git/refs{/sha}","trees_url":"https://api.github.com/repos/mysociety/pombola/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mysociety/pombola/statuses/{sha}","languages_url":"https://api.github.com/repos/mysociety/pombola/languages","stargazers_url":"https://api.github.com/repos/mysociety/pombola/stargazers","contributors_url":"https://api.github.com/repos/mysociety/pombola/contributors","subscribers_url":"https://api.github.com/repos/mysociety/pombola/subscribers","subscription_url":"https://api.github.com/repos/mysociety/pombola/subscription","commits_url":"https://api.github.com/repos/mysociety/pombola/commits{/sha}","git_commits_url":"https://api.github.com/repos/mysociety/pombola/git/commits{/sha}","comments_url":"https://api.github.com/repos/mysociety/pombola/comments{/number}","issue_comment_url":"https://api.github.com/repos/mysociety/pombola/issues/comments/{number}","contents_url":"https://api.github.com/repos/mysociety/pombola/contents/{+path}","compare_url":"https://api.github.com/repos/mysociety/pombola/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mysociety/pombola/merges","archive_url":"https://api.github.com/repos/mysociety/pombola/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mysociety/pombola/downloads","issues_url":"https://api.github.com/repos/mysociety/pombola/issues{/number}","pulls_url":"https://api.github.com/repos/mysociety/pombola/pulls{/number}","milestones_url":"https://api.github.com/repos/mysociety/pombola/milestones{/number}","notifications_url":"https://api.github.com/repos/mysociety/pombola/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mysociety/pombola/labels{/name}","releases_url":"https://api.github.com/repos/mysociety/pombola/releases{/id}","created_at":"2011-07-04T08:46:51Z","updated_at":"2014-06-24T10:44:37Z","pushed_at":"2014-06-24T10:44:37Z","git_url":"git://github.com/mysociety/pombola.git","ssh_url":"git@github.com:mysociety/pombola.git","clone_url":"https://github.com/mysociety/pombola.git","svn_url":"https://github.com/mysociety/pombola","homepage":"http://www.mysociety.org/projects/parliamentarymonitoring/pombola/","size":23906,"stargazers_count":26,"watchers_count":26,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":19,"mirror_url":null,"open_issues_count":156,"forks":19,"open_issues":156,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mysociety/pombola/pulls/1408"},"html":{"href":"https://github.com/mysociety/pombola/pull/1408"},"issue":{"href":"https://api.github.com/repos/mysociety/pombola/issues/1408"},"comments":{"href":"https://api.github.com/repos/mysociety/pombola/issues/1408/comments"},"review_comments":{"href":"https://api.github.com/repos/mysociety/pombola/pulls/1408/comments"},"review_comment":{"href":"https://api.github.com/repos/mysociety/pombola/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mysociety/pombola/pulls/1408/commits"},"statuses":{"href":"https://api.github.com/repos/mysociety/pombola/statuses/89f3140b180676e2298607662e6a54db2e3d28dc"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":2,"review_comments":0,"commits":102,"additions":10521,"deletions":10,"changed_files":21}}