GitHub PullRequestReviewCommentEvent at 2014-10-30 14:39:36
Repository: Theano
Actor: RoyXue
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Theano/Theano/pulls/comments/19608434","id":19608434,"diff_hunk":"@@ -797,6 +797,9 @@ def count_minimum_peak(node_list, fgraph, nodes_mem):\n             mem_bound = numpy.inf\n             # This take only the inputs/outputs dependencies.\n             dependencies = fgraph.profile.dependencies\n+            DONE_SET = set([])\n+            list_set = []","path":"theano/compile/profiling.py","position":5,"original_position":5,"commit_id":"bcedcd7c35cbe3c0929c2bbb6335e15230c4ff32","original_commit_id":"bcedcd7c35cbe3c0929c2bbb6335e15230c4ff32","user":{"login":"RoyXue","id":4725561,"avatar_url":"https://avatars.githubusercontent.com/u/4725561?v=2","gravatar_id":"","url":"https://api.github.com/users/RoyXue","html_url":"https://github.com/RoyXue","followers_url":"https://api.github.com/users/RoyXue/followers","following_url":"https://api.github.com/users/RoyXue/following{/other_user}","gists_url":"https://api.github.com/users/RoyXue/gists{/gist_id}","starred_url":"https://api.github.com/users/RoyXue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RoyXue/subscriptions","organizations_url":"https://api.github.com/users/RoyXue/orgs","repos_url":"https://api.github.com/users/RoyXue/repos","events_url":"https://api.github.com/users/RoyXue/events{/privacy}","received_events_url":"https://api.github.com/users/RoyXue/received_events","type":"User","site_admin":false},"body":"@nouiz \r\nYes, I knew the dict is faster.\r\nI will try the frozen version","created_at":"2014-10-30T14:39:36Z","updated_at":"2014-10-30T14:39:36Z","html_url":"https://github.com/Theano/Theano/pull/2226#discussion_r19608434","pull_request_url":"https://api.github.com/repos/Theano/Theano/pulls/2226","_links":{"self":{"href":"https://api.github.com/repos/Theano/Theano/pulls/comments/19608434"},"html":{"href":"https://github.com/Theano/Theano/pull/2226#discussion_r19608434"},"pull_request":{"href":"https://api.github.com/repos/Theano/Theano/pulls/2226"}}},"pull_request":{"url":"https://api.github.com/repos/Theano/Theano/pulls/2226","id":23583704,"html_url":"https://github.com/Theano/Theano/pull/2226","diff_url":"https://github.com/Theano/Theano/pull/2226.diff","patch_url":"https://github.com/Theano/Theano/pull/2226.patch","issue_url":"https://api.github.com/repos/Theano/Theano/issues/2226","number":2226,"state":"open","locked":false,"title":"Using DONE_SET method to make algorithm faster","user":{"login":"RoyXue","id":4725561,"avatar_url":"https://avatars.githubusercontent.com/u/4725561?v=2","gravatar_id":"","url":"https://api.github.com/users/RoyXue","html_url":"https://github.com/RoyXue","followers_url":"https://api.github.com/users/RoyXue/followers","following_url":"https://api.github.com/users/RoyXue/following{/other_user}","gists_url":"https://api.github.com/users/RoyXue/gists{/gist_id}","starred_url":"https://api.github.com/users/RoyXue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RoyXue/subscriptions","organizations_url":"https://api.github.com/users/RoyXue/orgs","repos_url":"https://api.github.com/users/RoyXue/repos","events_url":"https://api.github.com/users/RoyXue/events{/privacy}","received_events_url":"https://api.github.com/users/RoyXue/received_events","type":"User","site_admin":false},"body":"What we do is like to maintain a dict {DONE_SET: memory peak}, then Each time when we execute Node X, we make a check if the peak in dict and the current peak bigger than that peak. If yes(or equal), break and start a new branch. if no, update the peak in dict and continue.","created_at":"2014-10-30T05:33:06Z","updated_at":"2014-10-30T14:39:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d6b8f5673aed77291032c5742b3eb6a6f9192efc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Theano/Theano/pulls/2226/commits","review_comments_url":"https://api.github.com/repos/Theano/Theano/pulls/2226/comments","review_comment_url":"https://api.github.com/repos/Theano/Theano/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Theano/Theano/issues/2226/comments","statuses_url":"https://api.github.com/repos/Theano/Theano/statuses/bcedcd7c35cbe3c0929c2bbb6335e15230c4ff32","head":{"label":"RoyXue:faster_algo","ref":"faster_algo","sha":"bcedcd7c35cbe3c0929c2bbb6335e15230c4ff32","user":{"login":"RoyXue","id":4725561,"avatar_url":"https://avatars.githubusercontent.com/u/4725561?v=2","gravatar_id":"","url":"https://api.github.com/users/RoyXue","html_url":"https://github.com/RoyXue","followers_url":"https://api.github.com/users/RoyXue/followers","following_url":"https://api.github.com/users/RoyXue/following{/other_user}","gists_url":"https://api.github.com/users/RoyXue/gists{/gist_id}","starred_url":"https://api.github.com/users/RoyXue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RoyXue/subscriptions","organizations_url":"https://api.github.com/users/RoyXue/orgs","repos_url":"https://api.github.com/users/RoyXue/repos","events_url":"https://api.github.com/users/RoyXue/events{/privacy}","received_events_url":"https://api.github.com/users/RoyXue/received_events","type":"User","site_admin":false},"repo":{"id":19733368,"name":"Theano","full_name":"RoyXue/Theano","owner":{"login":"RoyXue","id":4725561,"avatar_url":"https://avatars.githubusercontent.com/u/4725561?v=2","gravatar_id":"","url":"https://api.github.com/users/RoyXue","html_url":"https://github.com/RoyXue","followers_url":"https://api.github.com/users/RoyXue/followers","following_url":"https://api.github.com/users/RoyXue/following{/other_user}","gists_url":"https://api.github.com/users/RoyXue/gists{/gist_id}","starred_url":"https://api.github.com/users/RoyXue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RoyXue/subscriptions","organizations_url":"https://api.github.com/users/RoyXue/orgs","repos_url":"https://api.github.com/users/RoyXue/repos","events_url":"https://api.github.com/users/RoyXue/events{/privacy}","received_events_url":"https://api.github.com/users/RoyXue/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RoyXue/Theano","description":"Optimizing GPU-meta-programming code generating array oriented optimizing math compiler in Python","fork":true,"url":"https://api.github.com/repos/RoyXue/Theano","forks_url":"https://api.github.com/repos/RoyXue/Theano/forks","keys_url":"https://api.github.com/repos/RoyXue/Theano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RoyXue/Theano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RoyXue/Theano/teams","hooks_url":"https://api.github.com/repos/RoyXue/Theano/hooks","issue_events_url":"https://api.github.com/repos/RoyXue/Theano/issues/events{/number}","events_url":"https://api.github.com/repos/RoyXue/Theano/events","assignees_url":"https://api.github.com/repos/RoyXue/Theano/assignees{/user}","branches_url":"https://api.github.com/repos/RoyXue/Theano/branches{/branch}","tags_url":"https://api.github.com/repos/RoyXue/Theano/tags","blobs_url":"https://api.github.com/repos/RoyXue/Theano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RoyXue/Theano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RoyXue/Theano/git/refs{/sha}","trees_url":"https://api.github.com/repos/RoyXue/Theano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RoyXue/Theano/statuses/{sha}","languages_url":"https://api.github.com/repos/RoyXue/Theano/languages","stargazers_url":"https://api.github.com/repos/RoyXue/Theano/stargazers","contributors_url":"https://api.github.com/repos/RoyXue/Theano/contributors","subscribers_url":"https://api.github.com/repos/RoyXue/Theano/subscribers","subscription_url":"https://api.github.com/repos/RoyXue/Theano/subscription","commits_url":"https://api.github.com/repos/RoyXue/Theano/commits{/sha}","git_commits_url":"https://api.github.com/repos/RoyXue/Theano/git/commits{/sha}","comments_url":"https://api.github.com/repos/RoyXue/Theano/comments{/number}","issue_comment_url":"https://api.github.com/repos/RoyXue/Theano/issues/comments/{number}","contents_url":"https://api.github.com/repos/RoyXue/Theano/contents/{+path}","compare_url":"https://api.github.com/repos/RoyXue/Theano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RoyXue/Theano/merges","archive_url":"https://api.github.com/repos/RoyXue/Theano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RoyXue/Theano/downloads","issues_url":"https://api.github.com/repos/RoyXue/Theano/issues{/number}","pulls_url":"https://api.github.com/repos/RoyXue/Theano/pulls{/number}","milestones_url":"https://api.github.com/repos/RoyXue/Theano/milestones{/number}","notifications_url":"https://api.github.com/repos/RoyXue/Theano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RoyXue/Theano/labels{/name}","releases_url":"https://api.github.com/repos/RoyXue/Theano/releases{/id}","created_at":"2014-05-13T09:31:54Z","updated_at":"2014-06-25T08:52:42Z","pushed_at":"2014-10-30T09:44:59Z","git_url":"git://github.com/RoyXue/Theano.git","ssh_url":"git@github.com:RoyXue/Theano.git","clone_url":"https://github.com/RoyXue/Theano.git","svn_url":"https://github.com/RoyXue/Theano","homepage":"http://www.deeplearning.net/software/theano","size":23867,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Theano:master","ref":"master","sha":"ee36aaae1053da4f14b0c32f205e24ad9a8684aa","user":{"login":"Theano","id":970517,"avatar_url":"https://avatars.githubusercontent.com/u/970517?v=2","gravatar_id":"","url":"https://api.github.com/users/Theano","html_url":"https://github.com/Theano","followers_url":"https://api.github.com/users/Theano/followers","following_url":"https://api.github.com/users/Theano/following{/other_user}","gists_url":"https://api.github.com/users/Theano/gists{/gist_id}","starred_url":"https://api.github.com/users/Theano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Theano/subscriptions","organizations_url":"https://api.github.com/users/Theano/orgs","repos_url":"https://api.github.com/users/Theano/repos","events_url":"https://api.github.com/users/Theano/events{/privacy}","received_events_url":"https://api.github.com/users/Theano/received_events","type":"Organization","site_admin":false},"repo":{"id":2183193,"name":"Theano","full_name":"Theano/Theano","owner":{"login":"Theano","id":970517,"avatar_url":"https://avatars.githubusercontent.com/u/970517?v=2","gravatar_id":"","url":"https://api.github.com/users/Theano","html_url":"https://github.com/Theano","followers_url":"https://api.github.com/users/Theano/followers","following_url":"https://api.github.com/users/Theano/following{/other_user}","gists_url":"https://api.github.com/users/Theano/gists{/gist_id}","starred_url":"https://api.github.com/users/Theano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Theano/subscriptions","organizations_url":"https://api.github.com/users/Theano/orgs","repos_url":"https://api.github.com/users/Theano/repos","events_url":"https://api.github.com/users/Theano/events{/privacy}","received_events_url":"https://api.github.com/users/Theano/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Theano/Theano","description":"Optimizing GPU-meta-programming code generating array oriented optimizing math compiler in Python","fork":false,"url":"https://api.github.com/repos/Theano/Theano","forks_url":"https://api.github.com/repos/Theano/Theano/forks","keys_url":"https://api.github.com/repos/Theano/Theano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Theano/Theano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Theano/Theano/teams","hooks_url":"https://api.github.com/repos/Theano/Theano/hooks","issue_events_url":"https://api.github.com/repos/Theano/Theano/issues/events{/number}","events_url":"https://api.github.com/repos/Theano/Theano/events","assignees_url":"https://api.github.com/repos/Theano/Theano/assignees{/user}","branches_url":"https://api.github.com/repos/Theano/Theano/branches{/branch}","tags_url":"https://api.github.com/repos/Theano/Theano/tags","blobs_url":"https://api.github.com/repos/Theano/Theano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Theano/Theano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Theano/Theano/git/refs{/sha}","trees_url":"https://api.github.com/repos/Theano/Theano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Theano/Theano/statuses/{sha}","languages_url":"https://api.github.com/repos/Theano/Theano/languages","stargazers_url":"https://api.github.com/repos/Theano/Theano/stargazers","contributors_url":"https://api.github.com/repos/Theano/Theano/contributors","subscribers_url":"https://api.github.com/repos/Theano/Theano/subscribers","subscription_url":"https://api.github.com/repos/Theano/Theano/subscription","commits_url":"https://api.github.com/repos/Theano/Theano/commits{/sha}","git_commits_url":"https://api.github.com/repos/Theano/Theano/git/commits{/sha}","comments_url":"https://api.github.com/repos/Theano/Theano/comments{/number}","issue_comment_url":"https://api.github.com/repos/Theano/Theano/issues/comments/{number}","contents_url":"https://api.github.com/repos/Theano/Theano/contents/{+path}","compare_url":"https://api.github.com/repos/Theano/Theano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Theano/Theano/merges","archive_url":"https://api.github.com/repos/Theano/Theano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Theano/Theano/downloads","issues_url":"https://api.github.com/repos/Theano/Theano/issues{/number}","pulls_url":"https://api.github.com/repos/Theano/Theano/pulls{/number}","milestones_url":"https://api.github.com/repos/Theano/Theano/milestones{/number}","notifications_url":"https://api.github.com/repos/Theano/Theano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Theano/Theano/labels{/name}","releases_url":"https://api.github.com/repos/Theano/Theano/releases{/id}","created_at":"2011-08-10T03:48:06Z","updated_at":"2014-10-30T12:29:21Z","pushed_at":"2014-10-28T16:49:27Z","git_url":"git://github.com/Theano/Theano.git","ssh_url":"git@github.com:Theano/Theano.git","clone_url":"https://github.com/Theano/Theano.git","svn_url":"https://github.com/Theano/Theano","homepage":"http://www.deeplearning.net/software/theano","size":42265,"stargazers_count":861,"watchers_count":861,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":331,"mirror_url":null,"open_issues_count":277,"forks":331,"open_issues":277,"watchers":861,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Theano/Theano/pulls/2226"},"html":{"href":"https://github.com/Theano/Theano/pull/2226"},"issue":{"href":"https://api.github.com/repos/Theano/Theano/issues/2226"},"comments":{"href":"https://api.github.com/repos/Theano/Theano/issues/2226/comments"},"review_comments":{"href":"https://api.github.com/repos/Theano/Theano/pulls/2226/comments"},"review_comment":{"href":"https://api.github.com/repos/Theano/Theano/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Theano/Theano/pulls/2226/commits"},"statuses":{"href":"https://api.github.com/repos/Theano/Theano/statuses/bcedcd7c35cbe3c0929c2bbb6335e15230c4ff32"}}}}