GitHub PullRequestEvent at 2014-08-07 04:19:06
Repository: xpython
Actor: Oniwa
Payload: {"action":"opened","number":98,"pull_request":{"url":"https://api.github.com/repos/exercism/xpython/pulls/98","id":19446492,"html_url":"https://github.com/exercism/xpython/pull/98","diff_url":"https://github.com/exercism/xpython/pull/98.diff","patch_url":"https://github.com/exercism/xpython/pull/98.patch","issue_url":"https://api.github.com/repos/exercism/xpython/issues/98","number":98,"state":"open","title":"Update nucleotide_count_test.py","user":{"login":"Oniwa","id":6988871,"avatar_url":"https://avatars.githubusercontent.com/u/6988871?v=2","gravatar_id":"b80d04f1f846219b43448b492eaeb237","url":"https://api.github.com/users/Oniwa","html_url":"https://github.com/Oniwa","followers_url":"https://api.github.com/users/Oniwa/followers","following_url":"https://api.github.com/users/Oniwa/following{/other_user}","gists_url":"https://api.github.com/users/Oniwa/gists{/gist_id}","starred_url":"https://api.github.com/users/Oniwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Oniwa/subscriptions","organizations_url":"https://api.github.com/users/Oniwa/orgs","repos_url":"https://api.github.com/users/Oniwa/repos","events_url":"https://api.github.com/users/Oniwa/events{/privacy}","received_events_url":"https://api.github.com/users/Oniwa/received_events","type":"User","site_admin":false},"body":"Removed test_dna_has_no_uracil for a couple of reasons\r\n* The module is named dna.py and in the README.md we see that DNA does not contain uracil only RNA does\r\n* If 'U' is added to the dictionary it causes test_counts_all_nucleotides, test_empty_dna_string_has_no_nucleotides, and test_repetitive_sequence_has_only_guanosine to fail.\r\n* I believe that counting for 'U' should also throw a ValueError\r\n\r\nAs of now the only solution I could think of was to add the following:\r\nif nucleotype is 'U': return 0 \r\nwhich seems inelegant to me.\r\n\r\nHope this helps,\r\n\r\nOniwa","created_at":"2014-08-07T04:19:04Z","updated_at":"2014-08-07T04:19:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"69adf799cf5c9dba2c909c9741126b2e765e859d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/exercism/xpython/pulls/98/commits","review_comments_url":"https://api.github.com/repos/exercism/xpython/pulls/98/comments","review_comment_url":"https://api.github.com/repos/exercism/xpython/pulls/comments/{number}","comments_url":"https://api.github.com/repos/exercism/xpython/issues/98/comments","statuses_url":"https://api.github.com/repos/exercism/xpython/statuses/183d7e3df5fd4020768e6b7439aede6efacda2fa","head":{"label":"Oniwa:master","ref":"master","sha":"183d7e3df5fd4020768e6b7439aede6efacda2fa","user":{"login":"Oniwa","id":6988871,"avatar_url":"https://avatars.githubusercontent.com/u/6988871?v=2","gravatar_id":"b80d04f1f846219b43448b492eaeb237","url":"https://api.github.com/users/Oniwa","html_url":"https://github.com/Oniwa","followers_url":"https://api.github.com/users/Oniwa/followers","following_url":"https://api.github.com/users/Oniwa/following{/other_user}","gists_url":"https://api.github.com/users/Oniwa/gists{/gist_id}","starred_url":"https://api.github.com/users/Oniwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Oniwa/subscriptions","organizations_url":"https://api.github.com/users/Oniwa/orgs","repos_url":"https://api.github.com/users/Oniwa/repos","events_url":"https://api.github.com/users/Oniwa/events{/privacy}","received_events_url":"https://api.github.com/users/Oniwa/received_events","type":"User","site_admin":false},"repo":{"id":22707863,"name":"xpython","full_name":"Oniwa/xpython","owner":{"login":"Oniwa","id":6988871,"avatar_url":"https://avatars.githubusercontent.com/u/6988871?v=2","gravatar_id":"b80d04f1f846219b43448b492eaeb237","url":"https://api.github.com/users/Oniwa","html_url":"https://github.com/Oniwa","followers_url":"https://api.github.com/users/Oniwa/followers","following_url":"https://api.github.com/users/Oniwa/following{/other_user}","gists_url":"https://api.github.com/users/Oniwa/gists{/gist_id}","starred_url":"https://api.github.com/users/Oniwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Oniwa/subscriptions","organizations_url":"https://api.github.com/users/Oniwa/orgs","repos_url":"https://api.github.com/users/Oniwa/repos","events_url":"https://api.github.com/users/Oniwa/events{/privacy}","received_events_url":"https://api.github.com/users/Oniwa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Oniwa/xpython","description":"Exercism Exercises in Python","fork":true,"url":"https://api.github.com/repos/Oniwa/xpython","forks_url":"https://api.github.com/repos/Oniwa/xpython/forks","keys_url":"https://api.github.com/repos/Oniwa/xpython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Oniwa/xpython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Oniwa/xpython/teams","hooks_url":"https://api.github.com/repos/Oniwa/xpython/hooks","issue_events_url":"https://api.github.com/repos/Oniwa/xpython/issues/events{/number}","events_url":"https://api.github.com/repos/Oniwa/xpython/events","assignees_url":"https://api.github.com/repos/Oniwa/xpython/assignees{/user}","branches_url":"https://api.github.com/repos/Oniwa/xpython/branches{/branch}","tags_url":"https://api.github.com/repos/Oniwa/xpython/tags","blobs_url":"https://api.github.com/repos/Oniwa/xpython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Oniwa/xpython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Oniwa/xpython/git/refs{/sha}","trees_url":"https://api.github.com/repos/Oniwa/xpython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Oniwa/xpython/statuses/{sha}","languages_url":"https://api.github.com/repos/Oniwa/xpython/languages","stargazers_url":"https://api.github.com/repos/Oniwa/xpython/stargazers","contributors_url":"https://api.github.com/repos/Oniwa/xpython/contributors","subscribers_url":"https://api.github.com/repos/Oniwa/xpython/subscribers","subscription_url":"https://api.github.com/repos/Oniwa/xpython/subscription","commits_url":"https://api.github.com/repos/Oniwa/xpython/commits{/sha}","git_commits_url":"https://api.github.com/repos/Oniwa/xpython/git/commits{/sha}","comments_url":"https://api.github.com/repos/Oniwa/xpython/comments{/number}","issue_comment_url":"https://api.github.com/repos/Oniwa/xpython/issues/comments/{number}","contents_url":"https://api.github.com/repos/Oniwa/xpython/contents/{+path}","compare_url":"https://api.github.com/repos/Oniwa/xpython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Oniwa/xpython/merges","archive_url":"https://api.github.com/repos/Oniwa/xpython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Oniwa/xpython/downloads","issues_url":"https://api.github.com/repos/Oniwa/xpython/issues{/number}","pulls_url":"https://api.github.com/repos/Oniwa/xpython/pulls{/number}","milestones_url":"https://api.github.com/repos/Oniwa/xpython/milestones{/number}","notifications_url":"https://api.github.com/repos/Oniwa/xpython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Oniwa/xpython/labels{/name}","releases_url":"https://api.github.com/repos/Oniwa/xpython/releases{/id}","created_at":"2014-08-07T04:05:14Z","updated_at":"2014-08-07T04:07:15Z","pushed_at":"2014-08-07T04:07:15Z","git_url":"git://github.com/Oniwa/xpython.git","ssh_url":"git@github.com:Oniwa/xpython.git","clone_url":"https://github.com/Oniwa/xpython.git","svn_url":"https://github.com/Oniwa/xpython","homepage":null,"size":26790,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"exercism:master","ref":"master","sha":"7b67dae6465b71bbe6e7634f17566e5a4e3940ec","user":{"login":"exercism","id":5624255,"avatar_url":"https://avatars.githubusercontent.com/u/5624255?v=2","gravatar_id":"fe98e7e6a96539f47809f36c17ee42ca","url":"https://api.github.com/users/exercism","html_url":"https://github.com/exercism","followers_url":"https://api.github.com/users/exercism/followers","following_url":"https://api.github.com/users/exercism/following{/other_user}","gists_url":"https://api.github.com/users/exercism/gists{/gist_id}","starred_url":"https://api.github.com/users/exercism/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exercism/subscriptions","organizations_url":"https://api.github.com/users/exercism/orgs","repos_url":"https://api.github.com/users/exercism/repos","events_url":"https://api.github.com/users/exercism/events{/privacy}","received_events_url":"https://api.github.com/users/exercism/received_events","type":"Organization","site_admin":false},"repo":{"id":17274389,"name":"xpython","full_name":"exercism/xpython","owner":{"login":"exercism","id":5624255,"avatar_url":"https://avatars.githubusercontent.com/u/5624255?v=2","gravatar_id":"fe98e7e6a96539f47809f36c17ee42ca","url":"https://api.github.com/users/exercism","html_url":"https://github.com/exercism","followers_url":"https://api.github.com/users/exercism/followers","following_url":"https://api.github.com/users/exercism/following{/other_user}","gists_url":"https://api.github.com/users/exercism/gists{/gist_id}","starred_url":"https://api.github.com/users/exercism/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exercism/subscriptions","organizations_url":"https://api.github.com/users/exercism/orgs","repos_url":"https://api.github.com/users/exercism/repos","events_url":"https://api.github.com/users/exercism/events{/privacy}","received_events_url":"https://api.github.com/users/exercism/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/exercism/xpython","description":"Exercism Exercises in Python","fork":false,"url":"https://api.github.com/repos/exercism/xpython","forks_url":"https://api.github.com/repos/exercism/xpython/forks","keys_url":"https://api.github.com/repos/exercism/xpython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/exercism/xpython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/exercism/xpython/teams","hooks_url":"https://api.github.com/repos/exercism/xpython/hooks","issue_events_url":"https://api.github.com/repos/exercism/xpython/issues/events{/number}","events_url":"https://api.github.com/repos/exercism/xpython/events","assignees_url":"https://api.github.com/repos/exercism/xpython/assignees{/user}","branches_url":"https://api.github.com/repos/exercism/xpython/branches{/branch}","tags_url":"https://api.github.com/repos/exercism/xpython/tags","blobs_url":"https://api.github.com/repos/exercism/xpython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/exercism/xpython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/exercism/xpython/git/refs{/sha}","trees_url":"https://api.github.com/repos/exercism/xpython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/exercism/xpython/statuses/{sha}","languages_url":"https://api.github.com/repos/exercism/xpython/languages","stargazers_url":"https://api.github.com/repos/exercism/xpython/stargazers","contributors_url":"https://api.github.com/repos/exercism/xpython/contributors","subscribers_url":"https://api.github.com/repos/exercism/xpython/subscribers","subscription_url":"https://api.github.com/repos/exercism/xpython/subscription","commits_url":"https://api.github.com/repos/exercism/xpython/commits{/sha}","git_commits_url":"https://api.github.com/repos/exercism/xpython/git/commits{/sha}","comments_url":"https://api.github.com/repos/exercism/xpython/comments{/number}","issue_comment_url":"https://api.github.com/repos/exercism/xpython/issues/comments/{number}","contents_url":"https://api.github.com/repos/exercism/xpython/contents/{+path}","compare_url":"https://api.github.com/repos/exercism/xpython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/exercism/xpython/merges","archive_url":"https://api.github.com/repos/exercism/xpython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/exercism/xpython/downloads","issues_url":"https://api.github.com/repos/exercism/xpython/issues{/number}","pulls_url":"https://api.github.com/repos/exercism/xpython/pulls{/number}","milestones_url":"https://api.github.com/repos/exercism/xpython/milestones{/number}","notifications_url":"https://api.github.com/repos/exercism/xpython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/exercism/xpython/labels{/name}","releases_url":"https://api.github.com/repos/exercism/xpython/releases{/id}","created_at":"2014-02-28T03:48:58Z","updated_at":"2014-08-01T14:36:50Z","pushed_at":"2014-08-04T13:14:03Z","git_url":"git://github.com/exercism/xpython.git","ssh_url":"git@github.com:exercism/xpython.git","clone_url":"https://github.com/exercism/xpython.git","svn_url":"https://github.com/exercism/xpython","homepage":null,"size":26790,"stargazers_count":10,"watchers_count":10,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":12,"mirror_url":null,"open_issues_count":2,"forks":12,"open_issues":2,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/exercism/xpython/pulls/98"},"html":{"href":"https://github.com/exercism/xpython/pull/98"},"issue":{"href":"https://api.github.com/repos/exercism/xpython/issues/98"},"comments":{"href":"https://api.github.com/repos/exercism/xpython/issues/98/comments"},"review_comments":{"href":"https://api.github.com/repos/exercism/xpython/pulls/98/comments"},"review_comment":{"href":"https://api.github.com/repos/exercism/xpython/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/exercism/xpython/pulls/98/commits"},"statuses":{"href":"https://api.github.com/repos/exercism/xpython/statuses/183d7e3df5fd4020768e6b7439aede6efacda2fa"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":4,"changed_files":1}}