GitHub PullRequestReviewCommentEvent at 2014-12-23 19:53:53
Repository: qml-box2d
Actor: jturcotte
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/qml-box2d/qml-box2d/pulls/comments/22231606","id":22231606,"diff_hunk":"@@ -272,6 +272,7 @@ void Box2DBody::createBody()\n     foreach (Box2DFixture *fixture, mFixtures)\n         fixture->initialize(this);\n     emit bodyCreated();\n+    connect(mWorld, SIGNAL(pixelsPerMeterChanged()), this, SLOT(onWorldPixelsPerMeterChanged()));","path":"box2dbody.cpp","position":null,"original_position":4,"commit_id":"8b9d58c149ada9b6d7b9e98254acf2dc86feaf66","original_commit_id":"bb9997065beb891a19ccb14c9a3084ddb1fb5b58","user":{"login":"jturcotte","id":839935,"avatar_url":"https://avatars.githubusercontent.com/u/839935?v=3","gravatar_id":"","url":"https://api.github.com/users/jturcotte","html_url":"https://github.com/jturcotte","followers_url":"https://api.github.com/users/jturcotte/followers","following_url":"https://api.github.com/users/jturcotte/following{/other_user}","gists_url":"https://api.github.com/users/jturcotte/gists{/gist_id}","starred_url":"https://api.github.com/users/jturcotte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jturcotte/subscriptions","organizations_url":"https://api.github.com/users/jturcotte/orgs","repos_url":"https://api.github.com/users/jturcotte/repos","events_url":"https://api.github.com/users/jturcotte/events{/privacy}","received_events_url":"https://api.github.com/users/jturcotte/received_events","type":"User","site_admin":false},"body":"Well I can't see any reason why it would be better after the emission :)\r\n\r\nI moved it back in setWorld and put it in an if (world), tell me what you think. This should keep the connect and disconnect easier to associate and made me realise that I was disconnecting from the wrong world.","created_at":"2014-12-23T19:53:53Z","updated_at":"2014-12-23T19:53:53Z","html_url":"https://github.com/qml-box2d/qml-box2d/pull/82#discussion_r22231606","pull_request_url":"https://api.github.com/repos/qml-box2d/qml-box2d/pulls/82","_links":{"self":{"href":"https://api.github.com/repos/qml-box2d/qml-box2d/pulls/comments/22231606"},"html":{"href":"https://github.com/qml-box2d/qml-box2d/pull/82#discussion_r22231606"},"pull_request":{"href":"https://api.github.com/repos/qml-box2d/qml-box2d/pulls/82"}}},"pull_request":{"url":"https://api.github.com/repos/qml-box2d/qml-box2d/pulls/82","id":26494991,"html_url":"https://github.com/qml-box2d/qml-box2d/pull/82","diff_url":"https://github.com/qml-box2d/qml-box2d/pull/82.diff","patch_url":"https://github.com/qml-box2d/qml-box2d/pull/82.patch","issue_url":"https://api.github.com/repos/qml-box2d/qml-box2d/issues/82","number":82,"state":"open","locked":false,"title":"Pixels per meter update","user":{"login":"jturcotte","id":839935,"avatar_url":"https://avatars.githubusercontent.com/u/839935?v=3","gravatar_id":"","url":"https://api.github.com/users/jturcotte","html_url":"https://github.com/jturcotte","followers_url":"https://api.github.com/users/jturcotte/followers","following_url":"https://api.github.com/users/jturcotte/following{/other_user}","gists_url":"https://api.github.com/users/jturcotte/gists{/gist_id}","starred_url":"https://api.github.com/users/jturcotte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jturcotte/subscriptions","organizations_url":"https://api.github.com/users/jturcotte/orgs","repos_url":"https://api.github.com/users/jturcotte/repos","events_url":"https://api.github.com/users/jturcotte/events{/privacy}","received_events_url":"https://api.github.com/users/jturcotte/received_events","type":"User","site_admin":false},"body":"Here are three unrelated commits I'm putting together in this pull request. The real important one is the pixelsPerMeter update.\r\n\r\nThe use-case I have is a top-down sport game where the arena's meter size is proportional to the number of players, and this requires pixelsPerMeter to behave properly when updated in the middle of a scene.","created_at":"2014-12-23T04:29:11Z","updated_at":"2014-12-23T19:53:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"08c3b79331235f59767a3f6f8cd04c11857ff308","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/qml-box2d/qml-box2d/pulls/82/commits","review_comments_url":"https://api.github.com/repos/qml-box2d/qml-box2d/pulls/82/comments","review_comment_url":"https://api.github.com/repos/qml-box2d/qml-box2d/pulls/comments/{number}","comments_url":"https://api.github.com/repos/qml-box2d/qml-box2d/issues/82/comments","statuses_url":"https://api.github.com/repos/qml-box2d/qml-box2d/statuses/8b9d58c149ada9b6d7b9e98254acf2dc86feaf66","head":{"label":"jturcotte:pixelsPerMeterUpdate","ref":"pixelsPerMeterUpdate","sha":"8b9d58c149ada9b6d7b9e98254acf2dc86feaf66","user":{"login":"jturcotte","id":839935,"avatar_url":"https://avatars.githubusercontent.com/u/839935?v=3","gravatar_id":"","url":"https://api.github.com/users/jturcotte","html_url":"https://github.com/jturcotte","followers_url":"https://api.github.com/users/jturcotte/followers","following_url":"https://api.github.com/users/jturcotte/following{/other_user}","gists_url":"https://api.github.com/users/jturcotte/gists{/gist_id}","starred_url":"https://api.github.com/users/jturcotte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jturcotte/subscriptions","organizations_url":"https://api.github.com/users/jturcotte/orgs","repos_url":"https://api.github.com/users/jturcotte/repos","events_url":"https://api.github.com/users/jturcotte/events{/privacy}","received_events_url":"https://api.github.com/users/jturcotte/received_events","type":"User","site_admin":false},"repo":{"id":28376896,"name":"qml-box2d","full_name":"jturcotte/qml-box2d","owner":{"login":"jturcotte","id":839935,"avatar_url":"https://avatars.githubusercontent.com/u/839935?v=3","gravatar_id":"","url":"https://api.github.com/users/jturcotte","html_url":"https://github.com/jturcotte","followers_url":"https://api.github.com/users/jturcotte/followers","following_url":"https://api.github.com/users/jturcotte/following{/other_user}","gists_url":"https://api.github.com/users/jturcotte/gists{/gist_id}","starred_url":"https://api.github.com/users/jturcotte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jturcotte/subscriptions","organizations_url":"https://api.github.com/users/jturcotte/orgs","repos_url":"https://api.github.com/users/jturcotte/repos","events_url":"https://api.github.com/users/jturcotte/events{/privacy}","received_events_url":"https://api.github.com/users/jturcotte/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jturcotte/qml-box2d","description":"Box2D QML plugin","fork":true,"url":"https://api.github.com/repos/jturcotte/qml-box2d","forks_url":"https://api.github.com/repos/jturcotte/qml-box2d/forks","keys_url":"https://api.github.com/repos/jturcotte/qml-box2d/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jturcotte/qml-box2d/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jturcotte/qml-box2d/teams","hooks_url":"https://api.github.com/repos/jturcotte/qml-box2d/hooks","issue_events_url":"https://api.github.com/repos/jturcotte/qml-box2d/issues/events{/number}","events_url":"https://api.github.com/repos/jturcotte/qml-box2d/events","assignees_url":"https://api.github.com/repos/jturcotte/qml-box2d/assignees{/user}","branches_url":"https://api.github.com/repos/jturcotte/qml-box2d/branches{/branch}","tags_url":"https://api.github.com/repos/jturcotte/qml-box2d/tags","blobs_url":"https://api.github.com/repos/jturcotte/qml-box2d/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jturcotte/qml-box2d/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jturcotte/qml-box2d/git/refs{/sha}","trees_url":"https://api.github.com/repos/jturcotte/qml-box2d/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jturcotte/qml-box2d/statuses/{sha}","languages_url":"https://api.github.com/repos/jturcotte/qml-box2d/languages","stargazers_url":"https://api.github.com/repos/jturcotte/qml-box2d/stargazers","contributors_url":"https://api.github.com/repos/jturcotte/qml-box2d/contributors","subscribers_url":"https://api.github.com/repos/jturcotte/qml-box2d/subscribers","subscription_url":"https://api.github.com/repos/jturcotte/qml-box2d/subscription","commits_url":"https://api.github.com/repos/jturcotte/qml-box2d/commits{/sha}","git_commits_url":"https://api.github.com/repos/jturcotte/qml-box2d/git/commits{/sha}","comments_url":"https://api.github.com/repos/jturcotte/qml-box2d/comments{/number}","issue_comment_url":"https://api.github.com/repos/jturcotte/qml-box2d/issues/comments/{number}","contents_url":"https://api.github.com/repos/jturcotte/qml-box2d/contents/{+path}","compare_url":"https://api.github.com/repos/jturcotte/qml-box2d/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jturcotte/qml-box2d/merges","archive_url":"https://api.github.com/repos/jturcotte/qml-box2d/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jturcotte/qml-box2d/downloads","issues_url":"https://api.github.com/repos/jturcotte/qml-box2d/issues{/number}","pulls_url":"https://api.github.com/repos/jturcotte/qml-box2d/pulls{/number}","milestones_url":"https://api.github.com/repos/jturcotte/qml-box2d/milestones{/number}","notifications_url":"https://api.github.com/repos/jturcotte/qml-box2d/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jturcotte/qml-box2d/labels{/name}","releases_url":"https://api.github.com/repos/jturcotte/qml-box2d/releases{/id}","created_at":"2014-12-23T04:19:49Z","updated_at":"2014-12-23T04:19:50Z","pushed_at":"2014-12-23T19:52:29Z","git_url":"git://github.com/jturcotte/qml-box2d.git","ssh_url":"git@github.com:jturcotte/qml-box2d.git","clone_url":"https://github.com/jturcotte/qml-box2d.git","svn_url":"https://github.com/jturcotte/qml-box2d","homepage":"","size":4334,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"qml-box2d:master","ref":"master","sha":"8c881e625e9921656335b09a62c1600687a8258c","user":{"login":"qml-box2d","id":6881644,"avatar_url":"https://avatars.githubusercontent.com/u/6881644?v=3","gravatar_id":"","url":"https://api.github.com/users/qml-box2d","html_url":"https://github.com/qml-box2d","followers_url":"https://api.github.com/users/qml-box2d/followers","following_url":"https://api.github.com/users/qml-box2d/following{/other_user}","gists_url":"https://api.github.com/users/qml-box2d/gists{/gist_id}","starred_url":"https://api.github.com/users/qml-box2d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qml-box2d/subscriptions","organizations_url":"https://api.github.com/users/qml-box2d/orgs","repos_url":"https://api.github.com/users/qml-box2d/repos","events_url":"https://api.github.com/users/qml-box2d/events{/privacy}","received_events_url":"https://api.github.com/users/qml-box2d/received_events","type":"Organization","site_admin":false},"repo":{"id":1518671,"name":"qml-box2d","full_name":"qml-box2d/qml-box2d","owner":{"login":"qml-box2d","id":6881644,"avatar_url":"https://avatars.githubusercontent.com/u/6881644?v=3","gravatar_id":"","url":"https://api.github.com/users/qml-box2d","html_url":"https://github.com/qml-box2d","followers_url":"https://api.github.com/users/qml-box2d/followers","following_url":"https://api.github.com/users/qml-box2d/following{/other_user}","gists_url":"https://api.github.com/users/qml-box2d/gists{/gist_id}","starred_url":"https://api.github.com/users/qml-box2d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qml-box2d/subscriptions","organizations_url":"https://api.github.com/users/qml-box2d/orgs","repos_url":"https://api.github.com/users/qml-box2d/repos","events_url":"https://api.github.com/users/qml-box2d/events{/privacy}","received_events_url":"https://api.github.com/users/qml-box2d/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/qml-box2d/qml-box2d","description":"Box2D QML plugin","fork":false,"url":"https://api.github.com/repos/qml-box2d/qml-box2d","forks_url":"https://api.github.com/repos/qml-box2d/qml-box2d/forks","keys_url":"https://api.github.com/repos/qml-box2d/qml-box2d/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qml-box2d/qml-box2d/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qml-box2d/qml-box2d/teams","hooks_url":"https://api.github.com/repos/qml-box2d/qml-box2d/hooks","issue_events_url":"https://api.github.com/repos/qml-box2d/qml-box2d/issues/events{/number}","events_url":"https://api.github.com/repos/qml-box2d/qml-box2d/events","assignees_url":"https://api.github.com/repos/qml-box2d/qml-box2d/assignees{/user}","branches_url":"https://api.github.com/repos/qml-box2d/qml-box2d/branches{/branch}","tags_url":"https://api.github.com/repos/qml-box2d/qml-box2d/tags","blobs_url":"https://api.github.com/repos/qml-box2d/qml-box2d/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qml-box2d/qml-box2d/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qml-box2d/qml-box2d/git/refs{/sha}","trees_url":"https://api.github.com/repos/qml-box2d/qml-box2d/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qml-box2d/qml-box2d/statuses/{sha}","languages_url":"https://api.github.com/repos/qml-box2d/qml-box2d/languages","stargazers_url":"https://api.github.com/repos/qml-box2d/qml-box2d/stargazers","contributors_url":"https://api.github.com/repos/qml-box2d/qml-box2d/contributors","subscribers_url":"https://api.github.com/repos/qml-box2d/qml-box2d/subscribers","subscription_url":"https://api.github.com/repos/qml-box2d/qml-box2d/subscription","commits_url":"https://api.github.com/repos/qml-box2d/qml-box2d/commits{/sha}","git_commits_url":"https://api.github.com/repos/qml-box2d/qml-box2d/git/commits{/sha}","comments_url":"https://api.github.com/repos/qml-box2d/qml-box2d/comments{/number}","issue_comment_url":"https://api.github.com/repos/qml-box2d/qml-box2d/issues/comments/{number}","contents_url":"https://api.github.com/repos/qml-box2d/qml-box2d/contents/{+path}","compare_url":"https://api.github.com/repos/qml-box2d/qml-box2d/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qml-box2d/qml-box2d/merges","archive_url":"https://api.github.com/repos/qml-box2d/qml-box2d/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qml-box2d/qml-box2d/downloads","issues_url":"https://api.github.com/repos/qml-box2d/qml-box2d/issues{/number}","pulls_url":"https://api.github.com/repos/qml-box2d/qml-box2d/pulls{/number}","milestones_url":"https://api.github.com/repos/qml-box2d/qml-box2d/milestones{/number}","notifications_url":"https://api.github.com/repos/qml-box2d/qml-box2d/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qml-box2d/qml-box2d/labels{/name}","releases_url":"https://api.github.com/repos/qml-box2d/qml-box2d/releases{/id}","created_at":"2011-03-23T23:01:17Z","updated_at":"2014-12-22T20:04:37Z","pushed_at":"2014-12-18T13:35:49Z","git_url":"git://github.com/qml-box2d/qml-box2d.git","ssh_url":"git@github.com:qml-box2d/qml-box2d.git","clone_url":"https://github.com/qml-box2d/qml-box2d.git","svn_url":"https://github.com/qml-box2d/qml-box2d","homepage":"","size":4334,"stargazers_count":49,"watchers_count":49,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":17,"mirror_url":null,"open_issues_count":11,"forks":17,"open_issues":11,"watchers":49,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qml-box2d/qml-box2d/pulls/82"},"html":{"href":"https://github.com/qml-box2d/qml-box2d/pull/82"},"issue":{"href":"https://api.github.com/repos/qml-box2d/qml-box2d/issues/82"},"comments":{"href":"https://api.github.com/repos/qml-box2d/qml-box2d/issues/82/comments"},"review_comments":{"href":"https://api.github.com/repos/qml-box2d/qml-box2d/pulls/82/comments"},"review_comment":{"href":"https://api.github.com/repos/qml-box2d/qml-box2d/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/qml-box2d/qml-box2d/pulls/82/commits"},"statuses":{"href":"https://api.github.com/repos/qml-box2d/qml-box2d/statuses/8b9d58c149ada9b6d7b9e98254acf2dc86feaf66"}}}}