GitHub PullRequestEvent at 2014-03-21 00:52:58
Repository: node-stomp-client
Actor: stuyboy
Payload: {"action":"opened","number":24,"pull_request":{"url":"https://api.github.com/repos/easternbloc/node-stomp-client/pulls/24","id":13819744,"html_url":"https://github.com/easternbloc/node-stomp-client/pull/24","diff_url":"https://github.com/easternbloc/node-stomp-client/pull/24.diff","patch_url":"https://github.com/easternbloc/node-stomp-client/pull/24.patch","issue_url":"https://api.github.com/repos/easternbloc/node-stomp-client/issues/24","number":24,"state":"open","title":"An attempt to better support ActiveMQ by suppressing content-length header for text messages.  Inclusion of the content-length ...","user":{"login":"stuyboy","id":7017269,"avatar_url":"https://avatars.githubusercontent.com/u/7017269?","gravatar_id":"e1d417fe0cfd61a694d64000b7629027","url":"https://api.github.com/users/stuyboy","html_url":"https://github.com/stuyboy","followers_url":"https://api.github.com/users/stuyboy/followers","following_url":"https://api.github.com/users/stuyboy/following{/other_user}","gists_url":"https://api.github.com/users/stuyboy/gists{/gist_id}","starred_url":"https://api.github.com/users/stuyboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stuyboy/subscriptions","organizations_url":"https://api.github.com/users/stuyboy/orgs","repos_url":"https://api.github.com/users/stuyboy/repos","events_url":"https://api.github.com/users/stuyboy/events{/privacy}","received_events_url":"https://api.github.com/users/stuyboy/received_events","type":"User","site_admin":false},"body":"...header, although correct by Stomp protocol standards, is actually a flag for ActiveMQ to consider whether the message is a JMSTextMessage, or JMSByteMessage.\r\n\r\nFor clarification, see under \"Working with JMS Text/Bytes Messages and Stomp\":\r\nhttp://activemq.apache.org/stomp.html\r\nThis proposes the inclusion of a 'suppress-content-length' header than can be passed in when creating the stomp client.\r\nDoing so allows us to send TextMessages rather than BytesMessages to ActiveMQ.\r\n\r\nAlthough this is an ActiveMQ deficiency, seems like Ruby Stomp Clients have been using a similar \"hack\" for a while.","created_at":"2014-03-21T00:52:58Z","updated_at":"2014-03-21T00:52:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/easternbloc/node-stomp-client/pulls/24/commits","review_comments_url":"https://api.github.com/repos/easternbloc/node-stomp-client/pulls/24/comments","review_comment_url":"https://api.github.com/repos/easternbloc/node-stomp-client/pulls/comments/{number}","comments_url":"https://api.github.com/repos/easternbloc/node-stomp-client/issues/24/comments","statuses_url":"https://api.github.com/repos/easternbloc/node-stomp-client/statuses/1a2e2ff00a44cf38da62213c6b51d2f46d75c38b","head":{"label":"stuyboy:master","ref":"master","sha":"1a2e2ff00a44cf38da62213c6b51d2f46d75c38b","user":{"login":"stuyboy","id":7017269,"avatar_url":"https://avatars.githubusercontent.com/u/7017269?","gravatar_id":"e1d417fe0cfd61a694d64000b7629027","url":"https://api.github.com/users/stuyboy","html_url":"https://github.com/stuyboy","followers_url":"https://api.github.com/users/stuyboy/followers","following_url":"https://api.github.com/users/stuyboy/following{/other_user}","gists_url":"https://api.github.com/users/stuyboy/gists{/gist_id}","starred_url":"https://api.github.com/users/stuyboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stuyboy/subscriptions","organizations_url":"https://api.github.com/users/stuyboy/orgs","repos_url":"https://api.github.com/users/stuyboy/repos","events_url":"https://api.github.com/users/stuyboy/events{/privacy}","received_events_url":"https://api.github.com/users/stuyboy/received_events","type":"User","site_admin":false},"repo":{"id":17963562,"name":"node-stomp-client","full_name":"stuyboy/node-stomp-client","owner":{"login":"stuyboy","id":7017269,"avatar_url":"https://avatars.githubusercontent.com/u/7017269?","gravatar_id":"e1d417fe0cfd61a694d64000b7629027","url":"https://api.github.com/users/stuyboy","html_url":"https://github.com/stuyboy","followers_url":"https://api.github.com/users/stuyboy/followers","following_url":"https://api.github.com/users/stuyboy/following{/other_user}","gists_url":"https://api.github.com/users/stuyboy/gists{/gist_id}","starred_url":"https://api.github.com/users/stuyboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stuyboy/subscriptions","organizations_url":"https://api.github.com/users/stuyboy/orgs","repos_url":"https://api.github.com/users/stuyboy/repos","events_url":"https://api.github.com/users/stuyboy/events{/privacy}","received_events_url":"https://api.github.com/users/stuyboy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stuyboy/node-stomp-client","description":"A STOMP client for Node.js","fork":true,"url":"https://api.github.com/repos/stuyboy/node-stomp-client","forks_url":"https://api.github.com/repos/stuyboy/node-stomp-client/forks","keys_url":"https://api.github.com/repos/stuyboy/node-stomp-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stuyboy/node-stomp-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stuyboy/node-stomp-client/teams","hooks_url":"https://api.github.com/repos/stuyboy/node-stomp-client/hooks","issue_events_url":"https://api.github.com/repos/stuyboy/node-stomp-client/issues/events{/number}","events_url":"https://api.github.com/repos/stuyboy/node-stomp-client/events","assignees_url":"https://api.github.com/repos/stuyboy/node-stomp-client/assignees{/user}","branches_url":"https://api.github.com/repos/stuyboy/node-stomp-client/branches{/branch}","tags_url":"https://api.github.com/repos/stuyboy/node-stomp-client/tags","blobs_url":"https://api.github.com/repos/stuyboy/node-stomp-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stuyboy/node-stomp-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stuyboy/node-stomp-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/stuyboy/node-stomp-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stuyboy/node-stomp-client/statuses/{sha}","languages_url":"https://api.github.com/repos/stuyboy/node-stomp-client/languages","stargazers_url":"https://api.github.com/repos/stuyboy/node-stomp-client/stargazers","contributors_url":"https://api.github.com/repos/stuyboy/node-stomp-client/contributors","subscribers_url":"https://api.github.com/repos/stuyboy/node-stomp-client/subscribers","subscription_url":"https://api.github.com/repos/stuyboy/node-stomp-client/subscription","commits_url":"https://api.github.com/repos/stuyboy/node-stomp-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/stuyboy/node-stomp-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/stuyboy/node-stomp-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/stuyboy/node-stomp-client/issues/comments/{number}","contents_url":"https://api.github.com/repos/stuyboy/node-stomp-client/contents/{+path}","compare_url":"https://api.github.com/repos/stuyboy/node-stomp-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stuyboy/node-stomp-client/merges","archive_url":"https://api.github.com/repos/stuyboy/node-stomp-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stuyboy/node-stomp-client/downloads","issues_url":"https://api.github.com/repos/stuyboy/node-stomp-client/issues{/number}","pulls_url":"https://api.github.com/repos/stuyboy/node-stomp-client/pulls{/number}","milestones_url":"https://api.github.com/repos/stuyboy/node-stomp-client/milestones{/number}","notifications_url":"https://api.github.com/repos/stuyboy/node-stomp-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stuyboy/node-stomp-client/labels{/name}","releases_url":"https://api.github.com/repos/stuyboy/node-stomp-client/releases{/id}","created_at":"2014-03-21T00:43:24Z","updated_at":"2014-03-21T00:52:58Z","pushed_at":"2014-03-21T00:50:55Z","git_url":"git://github.com/stuyboy/node-stomp-client.git","ssh_url":"git@github.com:stuyboy/node-stomp-client.git","clone_url":"https://github.com/stuyboy/node-stomp-client.git","svn_url":"https://github.com/stuyboy/node-stomp-client","homepage":"","size":191,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"easternbloc:master","ref":"master","sha":"1bebd553b2c8b323add272b774712ba6f6305c20","user":{"login":"easternbloc","id":92585,"avatar_url":"https://avatars.githubusercontent.com/u/92585?","gravatar_id":"cdae112d5fed33f85ba59e0540ed2061","url":"https://api.github.com/users/easternbloc","html_url":"https://github.com/easternbloc","followers_url":"https://api.github.com/users/easternbloc/followers","following_url":"https://api.github.com/users/easternbloc/following{/other_user}","gists_url":"https://api.github.com/users/easternbloc/gists{/gist_id}","starred_url":"https://api.github.com/users/easternbloc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/easternbloc/subscriptions","organizations_url":"https://api.github.com/users/easternbloc/orgs","repos_url":"https://api.github.com/users/easternbloc/repos","events_url":"https://api.github.com/users/easternbloc/events{/privacy}","received_events_url":"https://api.github.com/users/easternbloc/received_events","type":"User","site_admin":false},"repo":{"id":3033243,"name":"node-stomp-client","full_name":"easternbloc/node-stomp-client","owner":{"login":"easternbloc","id":92585,"avatar_url":"https://avatars.githubusercontent.com/u/92585?","gravatar_id":"cdae112d5fed33f85ba59e0540ed2061","url":"https://api.github.com/users/easternbloc","html_url":"https://github.com/easternbloc","followers_url":"https://api.github.com/users/easternbloc/followers","following_url":"https://api.github.com/users/easternbloc/following{/other_user}","gists_url":"https://api.github.com/users/easternbloc/gists{/gist_id}","starred_url":"https://api.github.com/users/easternbloc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/easternbloc/subscriptions","organizations_url":"https://api.github.com/users/easternbloc/orgs","repos_url":"https://api.github.com/users/easternbloc/repos","events_url":"https://api.github.com/users/easternbloc/events{/privacy}","received_events_url":"https://api.github.com/users/easternbloc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/easternbloc/node-stomp-client","description":"A STOMP client for Node.js","fork":true,"url":"https://api.github.com/repos/easternbloc/node-stomp-client","forks_url":"https://api.github.com/repos/easternbloc/node-stomp-client/forks","keys_url":"https://api.github.com/repos/easternbloc/node-stomp-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/easternbloc/node-stomp-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/easternbloc/node-stomp-client/teams","hooks_url":"https://api.github.com/repos/easternbloc/node-stomp-client/hooks","issue_events_url":"https://api.github.com/repos/easternbloc/node-stomp-client/issues/events{/number}","events_url":"https://api.github.com/repos/easternbloc/node-stomp-client/events","assignees_url":"https://api.github.com/repos/easternbloc/node-stomp-client/assignees{/user}","branches_url":"https://api.github.com/repos/easternbloc/node-stomp-client/branches{/branch}","tags_url":"https://api.github.com/repos/easternbloc/node-stomp-client/tags","blobs_url":"https://api.github.com/repos/easternbloc/node-stomp-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/easternbloc/node-stomp-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/easternbloc/node-stomp-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/easternbloc/node-stomp-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/easternbloc/node-stomp-client/statuses/{sha}","languages_url":"https://api.github.com/repos/easternbloc/node-stomp-client/languages","stargazers_url":"https://api.github.com/repos/easternbloc/node-stomp-client/stargazers","contributors_url":"https://api.github.com/repos/easternbloc/node-stomp-client/contributors","subscribers_url":"https://api.github.com/repos/easternbloc/node-stomp-client/subscribers","subscription_url":"https://api.github.com/repos/easternbloc/node-stomp-client/subscription","commits_url":"https://api.github.com/repos/easternbloc/node-stomp-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/easternbloc/node-stomp-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/easternbloc/node-stomp-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/easternbloc/node-stomp-client/issues/comments/{number}","contents_url":"https://api.github.com/repos/easternbloc/node-stomp-client/contents/{+path}","compare_url":"https://api.github.com/repos/easternbloc/node-stomp-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/easternbloc/node-stomp-client/merges","archive_url":"https://api.github.com/repos/easternbloc/node-stomp-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/easternbloc/node-stomp-client/downloads","issues_url":"https://api.github.com/repos/easternbloc/node-stomp-client/issues{/number}","pulls_url":"https://api.github.com/repos/easternbloc/node-stomp-client/pulls{/number}","milestones_url":"https://api.github.com/repos/easternbloc/node-stomp-client/milestones{/number}","notifications_url":"https://api.github.com/repos/easternbloc/node-stomp-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/easternbloc/node-stomp-client/labels{/name}","releases_url":"https://api.github.com/repos/easternbloc/node-stomp-client/releases{/id}","created_at":"2011-12-22T10:41:40Z","updated_at":"2014-02-13T13:52:33Z","pushed_at":"2014-02-13T13:52:33Z","git_url":"git://github.com/easternbloc/node-stomp-client.git","ssh_url":"git@github.com:easternbloc/node-stomp-client.git","clone_url":"https://github.com/easternbloc/node-stomp-client.git","svn_url":"https://github.com/easternbloc/node-stomp-client","homepage":"","size":346,"stargazers_count":20,"watchers_count":20,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":8,"mirror_url":null,"open_issues_count":5,"forks":8,"open_issues":5,"watchers":20,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/easternbloc/node-stomp-client/pulls/24"},"html":{"href":"https://github.com/easternbloc/node-stomp-client/pull/24"},"issue":{"href":"https://api.github.com/repos/easternbloc/node-stomp-client/issues/24"},"comments":{"href":"https://api.github.com/repos/easternbloc/node-stomp-client/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/easternbloc/node-stomp-client/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/easternbloc/node-stomp-client/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/easternbloc/node-stomp-client/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/easternbloc/node-stomp-client/statuses/1a2e2ff00a44cf38da62213c6b51d2f46d75c38b"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":5,"deletions":1,"changed_files":1}}