GitHub PullRequestReviewCommentEvent at 2014-10-25 17:02:09
Repository: jclouds
Actor: adriancole
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/jclouds/jclouds/pulls/comments/19376517","id":19376517,"diff_hunk":"@@ -177,10 +174,14 @@ protected HttpURLConnection convert(HttpRequest request) throws IOException, Int\n             connection.setChunkedStreamingMode(8196);\n             writePayloadToConnection(payload, \"streaming\", connection);\n          } else {\n-            long length = checkNotNull(md.getContentLength(), \"payload.getContentLength\");\n+            Long length = checkNotNull(md.getContentLength(), \"payload.getContentLength\");\n             if (length > 0) {\n-               connection.setRequestProperty(CONTENT_LENGTH, String.valueOf(length));\n-               connection.setFixedLengthStreamingMode(length);\n+               connection.setRequestProperty(CONTENT_LENGTH, length.toString());\n+               if (length <= Integer.MAX_VALUE) {\n+                  connection.setFixedLengthStreamingMode(length.intValue());\n+               } else {\n+                  setFixedLengthStreamingMode(connection, length);\n+               }","path":"core/src/main/java/org/jclouds/http/internal/JavaUrlHttpCommandExecutorService.java","position":50,"original_position":50,"commit_id":"059561b47bb3046196c5356c0df4f4260e4b094b","original_commit_id":"059561b47bb3046196c5356c0df4f4260e4b094b","user":{"login":"adriancole","id":64215,"avatar_url":"https://avatars.githubusercontent.com/u/64215?v=2","gravatar_id":"","url":"https://api.github.com/users/adriancole","html_url":"https://github.com/adriancole","followers_url":"https://api.github.com/users/adriancole/followers","following_url":"https://api.github.com/users/adriancole/following{/other_user}","gists_url":"https://api.github.com/users/adriancole/gists{/gist_id}","starred_url":"https://api.github.com/users/adriancole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriancole/subscriptions","organizations_url":"https://api.github.com/users/adriancole/orgs","repos_url":"https://api.github.com/users/adriancole/repos","events_url":"https://api.github.com/users/adriancole/events{/privacy}","received_events_url":"https://api.github.com/users/adriancole/received_events","type":"User","site_admin":false},"body":"I don't want to limit this fix to JRE​. It is a java api level thing.","created_at":"2014-10-25T17:02:09Z","updated_at":"2014-10-25T17:02:09Z","html_url":"https://github.com/jclouds/jclouds/pull/585#discussion_r19376517","pull_request_url":"https://api.github.com/repos/jclouds/jclouds/pulls/585","_links":{"self":{"href":"https://api.github.com/repos/jclouds/jclouds/pulls/comments/19376517"},"html":{"href":"https://github.com/jclouds/jclouds/pull/585#discussion_r19376517"},"pull_request":{"href":"https://api.github.com/repos/jclouds/jclouds/pulls/585"}}},"pull_request":{"url":"https://api.github.com/repos/jclouds/jclouds/pulls/585","id":23333063,"html_url":"https://github.com/jclouds/jclouds/pull/585","diff_url":"https://github.com/jclouds/jclouds/pull/585.diff","patch_url":"https://github.com/jclouds/jclouds/pull/585.patch","issue_url":"https://api.github.com/repos/jclouds/jclouds/issues/585","number":585,"state":"open","locked":false,"title":"Revert JCLOUDS-652 so that we don't require java 7","user":{"login":"adriancole","id":64215,"avatar_url":"https://avatars.githubusercontent.com/u/64215?v=2","gravatar_id":"","url":"https://api.github.com/users/adriancole","html_url":"https://github.com/adriancole","followers_url":"https://api.github.com/users/adriancole/followers","following_url":"https://api.github.com/users/adriancole/following{/other_user}","gists_url":"https://api.github.com/users/adriancole/gists{/gist_id}","starred_url":"https://api.github.com/users/adriancole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriancole/subscriptions","organizations_url":"https://api.github.com/users/adriancole/orgs","repos_url":"https://api.github.com/users/adriancole/repos","events_url":"https://api.github.com/users/adriancole/events{/privacy}","received_events_url":"https://api.github.com/users/adriancole/received_events","type":"User","site_admin":false},"body":"This reverts the change that required users to use java language 7.\r\nhttps://issues.apache.org/jira/browse/JCLOUDS-652\r\n\r\nThis takes care of the default http driver and single-shot 2GB fixed length posts. Basically, those using JRE7 will work. Those not, can choose a different http driver.\r\nhttps://issues.apache.org/jira/browse/JCLOUDS-264\r\n\r\nNote: this also permits special casing of modules that need Java 7. For example, the filesystem api is configured so that if the JRE is at least 7, it will build.\r\n","created_at":"2014-10-25T00:44:54Z","updated_at":"2014-10-25T17:02:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4a75705b106e5f244f729845e9cfa8f5999dc114","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jclouds/jclouds/pulls/585/commits","review_comments_url":"https://api.github.com/repos/jclouds/jclouds/pulls/585/comments","review_comment_url":"https://api.github.com/repos/jclouds/jclouds/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jclouds/jclouds/issues/585/comments","statuses_url":"https://api.github.com/repos/jclouds/jclouds/statuses/059561b47bb3046196c5356c0df4f4260e4b094b","head":{"label":"adriancole:adrian.dont-require-java-7","ref":"adrian.dont-require-java-7","sha":"059561b47bb3046196c5356c0df4f4260e4b094b","user":{"login":"adriancole","id":64215,"avatar_url":"https://avatars.githubusercontent.com/u/64215?v=2","gravatar_id":"","url":"https://api.github.com/users/adriancole","html_url":"https://github.com/adriancole","followers_url":"https://api.github.com/users/adriancole/followers","following_url":"https://api.github.com/users/adriancole/following{/other_user}","gists_url":"https://api.github.com/users/adriancole/gists{/gist_id}","starred_url":"https://api.github.com/users/adriancole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriancole/subscriptions","organizations_url":"https://api.github.com/users/adriancole/orgs","repos_url":"https://api.github.com/users/adriancole/repos","events_url":"https://api.github.com/users/adriancole/events{/privacy}","received_events_url":"https://api.github.com/users/adriancole/received_events","type":"User","site_admin":false},"repo":{"id":10064416,"name":"jclouds","full_name":"adriancole/jclouds","owner":{"login":"adriancole","id":64215,"avatar_url":"https://avatars.githubusercontent.com/u/64215?v=2","gravatar_id":"","url":"https://api.github.com/users/adriancole","html_url":"https://github.com/adriancole","followers_url":"https://api.github.com/users/adriancole/followers","following_url":"https://api.github.com/users/adriancole/following{/other_user}","gists_url":"https://api.github.com/users/adriancole/gists{/gist_id}","starred_url":"https://api.github.com/users/adriancole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriancole/subscriptions","organizations_url":"https://api.github.com/users/adriancole/orgs","repos_url":"https://api.github.com/users/adriancole/repos","events_url":"https://api.github.com/users/adriancole/events{/privacy}","received_events_url":"https://api.github.com/users/adriancole/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adriancole/jclouds","description":"Read-only mirror of ASF Git Repo for jclouds","fork":true,"url":"https://api.github.com/repos/adriancole/jclouds","forks_url":"https://api.github.com/repos/adriancole/jclouds/forks","keys_url":"https://api.github.com/repos/adriancole/jclouds/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adriancole/jclouds/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adriancole/jclouds/teams","hooks_url":"https://api.github.com/repos/adriancole/jclouds/hooks","issue_events_url":"https://api.github.com/repos/adriancole/jclouds/issues/events{/number}","events_url":"https://api.github.com/repos/adriancole/jclouds/events","assignees_url":"https://api.github.com/repos/adriancole/jclouds/assignees{/user}","branches_url":"https://api.github.com/repos/adriancole/jclouds/branches{/branch}","tags_url":"https://api.github.com/repos/adriancole/jclouds/tags","blobs_url":"https://api.github.com/repos/adriancole/jclouds/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adriancole/jclouds/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adriancole/jclouds/git/refs{/sha}","trees_url":"https://api.github.com/repos/adriancole/jclouds/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adriancole/jclouds/statuses/{sha}","languages_url":"https://api.github.com/repos/adriancole/jclouds/languages","stargazers_url":"https://api.github.com/repos/adriancole/jclouds/stargazers","contributors_url":"https://api.github.com/repos/adriancole/jclouds/contributors","subscribers_url":"https://api.github.com/repos/adriancole/jclouds/subscribers","subscription_url":"https://api.github.com/repos/adriancole/jclouds/subscription","commits_url":"https://api.github.com/repos/adriancole/jclouds/commits{/sha}","git_commits_url":"https://api.github.com/repos/adriancole/jclouds/git/commits{/sha}","comments_url":"https://api.github.com/repos/adriancole/jclouds/comments{/number}","issue_comment_url":"https://api.github.com/repos/adriancole/jclouds/issues/comments/{number}","contents_url":"https://api.github.com/repos/adriancole/jclouds/contents/{+path}","compare_url":"https://api.github.com/repos/adriancole/jclouds/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adriancole/jclouds/merges","archive_url":"https://api.github.com/repos/adriancole/jclouds/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adriancole/jclouds/downloads","issues_url":"https://api.github.com/repos/adriancole/jclouds/issues{/number}","pulls_url":"https://api.github.com/repos/adriancole/jclouds/pulls{/number}","milestones_url":"https://api.github.com/repos/adriancole/jclouds/milestones{/number}","notifications_url":"https://api.github.com/repos/adriancole/jclouds/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adriancole/jclouds/labels{/name}","releases_url":"https://api.github.com/repos/adriancole/jclouds/releases{/id}","created_at":"2013-05-14T20:39:08Z","updated_at":"2014-09-30T17:14:22Z","pushed_at":"2014-10-25T16:53:20Z","git_url":"git://github.com/adriancole/jclouds.git","ssh_url":"git@github.com:adriancole/jclouds.git","clone_url":"https://github.com/adriancole/jclouds.git","svn_url":"https://github.com/adriancole/jclouds","homepage":null,"size":68516,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jclouds:master","ref":"master","sha":"0339cd2fd07ecdcc42fa0ebc74f6c1d9014eebfd","user":{"login":"jclouds","id":108982,"avatar_url":"https://avatars.githubusercontent.com/u/108982?v=2","gravatar_id":"","url":"https://api.github.com/users/jclouds","html_url":"https://github.com/jclouds","followers_url":"https://api.github.com/users/jclouds/followers","following_url":"https://api.github.com/users/jclouds/following{/other_user}","gists_url":"https://api.github.com/users/jclouds/gists{/gist_id}","starred_url":"https://api.github.com/users/jclouds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jclouds/subscriptions","organizations_url":"https://api.github.com/users/jclouds/orgs","repos_url":"https://api.github.com/users/jclouds/repos","events_url":"https://api.github.com/users/jclouds/events{/privacy}","received_events_url":"https://api.github.com/users/jclouds/received_events","type":"Organization","site_admin":false},"repo":{"id":10040960,"name":"jclouds","full_name":"jclouds/jclouds","owner":{"login":"jclouds","id":108982,"avatar_url":"https://avatars.githubusercontent.com/u/108982?v=2","gravatar_id":"","url":"https://api.github.com/users/jclouds","html_url":"https://github.com/jclouds","followers_url":"https://api.github.com/users/jclouds/followers","following_url":"https://api.github.com/users/jclouds/following{/other_user}","gists_url":"https://api.github.com/users/jclouds/gists{/gist_id}","starred_url":"https://api.github.com/users/jclouds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jclouds/subscriptions","organizations_url":"https://api.github.com/users/jclouds/orgs","repos_url":"https://api.github.com/users/jclouds/repos","events_url":"https://api.github.com/users/jclouds/events{/privacy}","received_events_url":"https://api.github.com/users/jclouds/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jclouds/jclouds","description":"Read-only mirror of ASF Git Repo for jclouds","fork":false,"url":"https://api.github.com/repos/jclouds/jclouds","forks_url":"https://api.github.com/repos/jclouds/jclouds/forks","keys_url":"https://api.github.com/repos/jclouds/jclouds/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jclouds/jclouds/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jclouds/jclouds/teams","hooks_url":"https://api.github.com/repos/jclouds/jclouds/hooks","issue_events_url":"https://api.github.com/repos/jclouds/jclouds/issues/events{/number}","events_url":"https://api.github.com/repos/jclouds/jclouds/events","assignees_url":"https://api.github.com/repos/jclouds/jclouds/assignees{/user}","branches_url":"https://api.github.com/repos/jclouds/jclouds/branches{/branch}","tags_url":"https://api.github.com/repos/jclouds/jclouds/tags","blobs_url":"https://api.github.com/repos/jclouds/jclouds/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jclouds/jclouds/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jclouds/jclouds/git/refs{/sha}","trees_url":"https://api.github.com/repos/jclouds/jclouds/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jclouds/jclouds/statuses/{sha}","languages_url":"https://api.github.com/repos/jclouds/jclouds/languages","stargazers_url":"https://api.github.com/repos/jclouds/jclouds/stargazers","contributors_url":"https://api.github.com/repos/jclouds/jclouds/contributors","subscribers_url":"https://api.github.com/repos/jclouds/jclouds/subscribers","subscription_url":"https://api.github.com/repos/jclouds/jclouds/subscription","commits_url":"https://api.github.com/repos/jclouds/jclouds/commits{/sha}","git_commits_url":"https://api.github.com/repos/jclouds/jclouds/git/commits{/sha}","comments_url":"https://api.github.com/repos/jclouds/jclouds/comments{/number}","issue_comment_url":"https://api.github.com/repos/jclouds/jclouds/issues/comments/{number}","contents_url":"https://api.github.com/repos/jclouds/jclouds/contents/{+path}","compare_url":"https://api.github.com/repos/jclouds/jclouds/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jclouds/jclouds/merges","archive_url":"https://api.github.com/repos/jclouds/jclouds/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jclouds/jclouds/downloads","issues_url":"https://api.github.com/repos/jclouds/jclouds/issues{/number}","pulls_url":"https://api.github.com/repos/jclouds/jclouds/pulls{/number}","milestones_url":"https://api.github.com/repos/jclouds/jclouds/milestones{/number}","notifications_url":"https://api.github.com/repos/jclouds/jclouds/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jclouds/jclouds/labels{/name}","releases_url":"https://api.github.com/repos/jclouds/jclouds/releases{/id}","created_at":"2013-05-13T20:47:29Z","updated_at":"2014-10-25T14:38:47Z","pushed_at":"2014-10-24T19:17:18Z","git_url":"git://github.com/jclouds/jclouds.git","ssh_url":"git@github.com:jclouds/jclouds.git","clone_url":"https://github.com/jclouds/jclouds.git","svn_url":"https://github.com/jclouds/jclouds","homepage":"http://jclouds.apache.org/","size":175055,"stargazers_count":127,"watchers_count":127,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":198,"mirror_url":null,"open_issues_count":29,"forks":198,"open_issues":29,"watchers":127,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jclouds/jclouds/pulls/585"},"html":{"href":"https://github.com/jclouds/jclouds/pull/585"},"issue":{"href":"https://api.github.com/repos/jclouds/jclouds/issues/585"},"comments":{"href":"https://api.github.com/repos/jclouds/jclouds/issues/585/comments"},"review_comments":{"href":"https://api.github.com/repos/jclouds/jclouds/pulls/585/comments"},"review_comment":{"href":"https://api.github.com/repos/jclouds/jclouds/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jclouds/jclouds/pulls/585/commits"},"statuses":{"href":"https://api.github.com/repos/jclouds/jclouds/statuses/059561b47bb3046196c5356c0df4f4260e4b094b"}}}}