GitHub PullRequestReviewCommentEvent at 2014-08-07 21:09:14
Repository: testing
Actor: ericsnowcurrently
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/juju/testing/pulls/comments/15964286","id":15964286,"diff_hunk":"@@ -45,6 +45,65 @@ const (\n \tDefaultMongoPassword = \"conn-from-name-secret\"\n )\n \n+// MgoTestPackage should be called to register the tests for any package\n+// that requires a MongoDB server. If certs is non-nil, a secure SSL connection\n+// will be used from client to server.\n+func MgoTestPackage(t *testing.T, certs *Certs, jujuMongod string) {\n+\tif err := MgoServer.Start(certs, jujuMongod); err != nil {\n+\t\tt.Fatal(err)\n+\t}\n+\tdefer MgoServer.Destroy()\n+\tgc.TestingT(t)\n+}\n+\n+//---------------------------","path":"mgo.go","position":15,"original_position":15,"commit_id":"d88c94f080e6257252e88dc96d165bfb5ffce9ec","original_commit_id":"d88c94f080e6257252e88dc96d165bfb5ffce9ec","user":{"login":"ericsnowcurrently","id":1152074,"avatar_url":"https://avatars.githubusercontent.com/u/1152074?v=2","gravatar_id":"dd4761743695d5efd3692f2a3b35d37d","url":"https://api.github.com/users/ericsnowcurrently","html_url":"https://github.com/ericsnowcurrently","followers_url":"https://api.github.com/users/ericsnowcurrently/followers","following_url":"https://api.github.com/users/ericsnowcurrently/following{/other_user}","gists_url":"https://api.github.com/users/ericsnowcurrently/gists{/gist_id}","starred_url":"https://api.github.com/users/ericsnowcurrently/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericsnowcurrently/subscriptions","organizations_url":"https://api.github.com/users/ericsnowcurrently/orgs","repos_url":"https://api.github.com/users/ericsnowcurrently/repos","events_url":"https://api.github.com/users/ericsnowcurrently/events{/privacy}","received_events_url":"https://api.github.com/users/ericsnowcurrently/received_events","type":"User","site_admin":false},"body":"I will argue that the comment is useful; it visually separates the suite from the preceding code.  Go really doesn't offer an alternative of which I'm aware.  While that may not matter to everyone, I certainly find such comments useful.  Grouping code and demarcating those groups with comments seems like a good solution when splitting a file up isn't a practical solution.  That's the case here.","created_at":"2014-08-07T21:09:14Z","updated_at":"2014-08-07T21:09:14Z","html_url":"https://github.com/juju/testing/pull/27#discussion_r15964286","pull_request_url":"https://api.github.com/repos/juju/testing/pulls/27","_links":{"self":{"href":"https://api.github.com/repos/juju/testing/pulls/comments/15964286"},"html":{"href":"https://github.com/juju/testing/pull/27#discussion_r15964286"},"pull_request":{"href":"https://api.github.com/repos/juju/testing/pulls/27"}}},"pull_request":{"url":"https://api.github.com/repos/juju/testing/pulls/27","id":19382606,"html_url":"https://github.com/juju/testing/pull/27","diff_url":"https://github.com/juju/testing/pull/27.diff","patch_url":"https://github.com/juju/testing/pull/27.patch","issue_url":"https://api.github.com/repos/juju/testing/issues/27","number":27,"state":"open","title":"Add juju mongod","user":{"login":"ericsnowcurrently","id":1152074,"avatar_url":"https://avatars.githubusercontent.com/u/1152074?v=2","gravatar_id":"dd4761743695d5efd3692f2a3b35d37d","url":"https://api.github.com/users/ericsnowcurrently","html_url":"https://github.com/ericsnowcurrently","followers_url":"https://api.github.com/users/ericsnowcurrently/followers","following_url":"https://api.github.com/users/ericsnowcurrently/following{/other_user}","gists_url":"https://api.github.com/users/ericsnowcurrently/gists{/gist_id}","starred_url":"https://api.github.com/users/ericsnowcurrently/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericsnowcurrently/subscriptions","organizations_url":"https://api.github.com/users/ericsnowcurrently/orgs","repos_url":"https://api.github.com/users/ericsnowcurrently/repos","events_url":"https://api.github.com/users/ericsnowcurrently/events{/privacy}","received_events_url":"https://api.github.com/users/ericsnowcurrently/received_events","type":"User","site_admin":false},"body":"This is part of the fix for https://bugs.launchpad.net/juju-core/+bug/1351019.  It eliminates a hard-coded path.","created_at":"2014-08-06T03:00:30Z","updated_at":"2014-08-07T21:09:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f924b9d19ce7461a452ad4ebe15438f73257ecb5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/juju/testing/pulls/27/commits","review_comments_url":"https://api.github.com/repos/juju/testing/pulls/27/comments","review_comment_url":"https://api.github.com/repos/juju/testing/pulls/comments/{number}","comments_url":"https://api.github.com/repos/juju/testing/issues/27/comments","statuses_url":"https://api.github.com/repos/juju/testing/statuses/d88c94f080e6257252e88dc96d165bfb5ffce9ec","head":{"label":"ericsnowcurrently:add-jujuMongod","ref":"add-jujuMongod","sha":"d88c94f080e6257252e88dc96d165bfb5ffce9ec","user":{"login":"ericsnowcurrently","id":1152074,"avatar_url":"https://avatars.githubusercontent.com/u/1152074?v=2","gravatar_id":"dd4761743695d5efd3692f2a3b35d37d","url":"https://api.github.com/users/ericsnowcurrently","html_url":"https://github.com/ericsnowcurrently","followers_url":"https://api.github.com/users/ericsnowcurrently/followers","following_url":"https://api.github.com/users/ericsnowcurrently/following{/other_user}","gists_url":"https://api.github.com/users/ericsnowcurrently/gists{/gist_id}","starred_url":"https://api.github.com/users/ericsnowcurrently/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericsnowcurrently/subscriptions","organizations_url":"https://api.github.com/users/ericsnowcurrently/orgs","repos_url":"https://api.github.com/users/ericsnowcurrently/repos","events_url":"https://api.github.com/users/ericsnowcurrently/events{/privacy}","received_events_url":"https://api.github.com/users/ericsnowcurrently/received_events","type":"User","site_admin":false},"repo":{"id":21003081,"name":"juju-testing","full_name":"ericsnowcurrently/juju-testing","owner":{"login":"ericsnowcurrently","id":1152074,"avatar_url":"https://avatars.githubusercontent.com/u/1152074?v=2","gravatar_id":"dd4761743695d5efd3692f2a3b35d37d","url":"https://api.github.com/users/ericsnowcurrently","html_url":"https://github.com/ericsnowcurrently","followers_url":"https://api.github.com/users/ericsnowcurrently/followers","following_url":"https://api.github.com/users/ericsnowcurrently/following{/other_user}","gists_url":"https://api.github.com/users/ericsnowcurrently/gists{/gist_id}","starred_url":"https://api.github.com/users/ericsnowcurrently/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericsnowcurrently/subscriptions","organizations_url":"https://api.github.com/users/ericsnowcurrently/orgs","repos_url":"https://api.github.com/users/ericsnowcurrently/repos","events_url":"https://api.github.com/users/ericsnowcurrently/events{/privacy}","received_events_url":"https://api.github.com/users/ericsnowcurrently/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ericsnowcurrently/juju-testing","description":"Testing gocheck suites and checkers used across juju projects","fork":true,"url":"https://api.github.com/repos/ericsnowcurrently/juju-testing","forks_url":"https://api.github.com/repos/ericsnowcurrently/juju-testing/forks","keys_url":"https://api.github.com/repos/ericsnowcurrently/juju-testing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ericsnowcurrently/juju-testing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ericsnowcurrently/juju-testing/teams","hooks_url":"https://api.github.com/repos/ericsnowcurrently/juju-testing/hooks","issue_events_url":"https://api.github.com/repos/ericsnowcurrently/juju-testing/issues/events{/number}","events_url":"https://api.github.com/repos/ericsnowcurrently/juju-testing/events","assignees_url":"https://api.github.com/repos/ericsnowcurrently/juju-testing/assignees{/user}","branches_url":"https://api.github.com/repos/ericsnowcurrently/juju-testing/branches{/branch}","tags_url":"https://api.github.com/repos/ericsnowcurrently/juju-testing/tags","blobs_url":"https://api.github.com/repos/ericsnowcurrently/juju-testing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ericsnowcurrently/juju-testing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ericsnowcurrently/juju-testing/git/refs{/sha}","trees_url":"https://api.github.com/repos/ericsnowcurrently/juju-testing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ericsnowcurrently/juju-testing/statuses/{sha}","languages_url":"https://api.github.com/repos/ericsnowcurrently/juju-testing/languages","stargazers_url":"https://api.github.com/repos/ericsnowcurrently/juju-testing/stargazers","contributors_url":"https://api.github.com/repos/ericsnowcurrently/juju-testing/contributors","subscribers_url":"https://api.github.com/repos/ericsnowcurrently/juju-testing/subscribers","subscription_url":"https://api.github.com/repos/ericsnowcurrently/juju-testing/subscription","commits_url":"https://api.github.com/repos/ericsnowcurrently/juju-testing/commits{/sha}","git_commits_url":"https://api.github.com/repos/ericsnowcurrently/juju-testing/git/commits{/sha}","comments_url":"https://api.github.com/repos/ericsnowcurrently/juju-testing/comments{/number}","issue_comment_url":"https://api.github.com/repos/ericsnowcurrently/juju-testing/issues/comments/{number}","contents_url":"https://api.github.com/repos/ericsnowcurrently/juju-testing/contents/{+path}","compare_url":"https://api.github.com/repos/ericsnowcurrently/juju-testing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ericsnowcurrently/juju-testing/merges","archive_url":"https://api.github.com/repos/ericsnowcurrently/juju-testing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ericsnowcurrently/juju-testing/downloads","issues_url":"https://api.github.com/repos/ericsnowcurrently/juju-testing/issues{/number}","pulls_url":"https://api.github.com/repos/ericsnowcurrently/juju-testing/pulls{/number}","milestones_url":"https://api.github.com/repos/ericsnowcurrently/juju-testing/milestones{/number}","notifications_url":"https://api.github.com/repos/ericsnowcurrently/juju-testing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ericsnowcurrently/juju-testing/labels{/name}","releases_url":"https://api.github.com/repos/ericsnowcurrently/juju-testing/releases{/id}","created_at":"2014-06-19T14:23:27Z","updated_at":"2014-08-06T02:56:09Z","pushed_at":"2014-08-07T19:09:20Z","git_url":"git://github.com/ericsnowcurrently/juju-testing.git","ssh_url":"git@github.com:ericsnowcurrently/juju-testing.git","clone_url":"https://github.com/ericsnowcurrently/juju-testing.git","svn_url":"https://github.com/ericsnowcurrently/juju-testing","homepage":null,"size":202,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"juju:master","ref":"master","sha":"36a26fb0e5ce087bb34529110ac962a9f427e927","user":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=2","gravatar_id":"b095d1e26e5705abe0ad2de7d87aac2e","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"repo":{"id":16748962,"name":"testing","full_name":"juju/testing","owner":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=2","gravatar_id":"b095d1e26e5705abe0ad2de7d87aac2e","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju/testing","description":"Testing gocheck suites and checkers used across juju projects","fork":false,"url":"https://api.github.com/repos/juju/testing","forks_url":"https://api.github.com/repos/juju/testing/forks","keys_url":"https://api.github.com/repos/juju/testing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju/testing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju/testing/teams","hooks_url":"https://api.github.com/repos/juju/testing/hooks","issue_events_url":"https://api.github.com/repos/juju/testing/issues/events{/number}","events_url":"https://api.github.com/repos/juju/testing/events","assignees_url":"https://api.github.com/repos/juju/testing/assignees{/user}","branches_url":"https://api.github.com/repos/juju/testing/branches{/branch}","tags_url":"https://api.github.com/repos/juju/testing/tags","blobs_url":"https://api.github.com/repos/juju/testing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju/testing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju/testing/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju/testing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju/testing/statuses/{sha}","languages_url":"https://api.github.com/repos/juju/testing/languages","stargazers_url":"https://api.github.com/repos/juju/testing/stargazers","contributors_url":"https://api.github.com/repos/juju/testing/contributors","subscribers_url":"https://api.github.com/repos/juju/testing/subscribers","subscription_url":"https://api.github.com/repos/juju/testing/subscription","commits_url":"https://api.github.com/repos/juju/testing/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju/testing/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju/testing/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju/testing/issues/comments/{number}","contents_url":"https://api.github.com/repos/juju/testing/contents/{+path}","compare_url":"https://api.github.com/repos/juju/testing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju/testing/merges","archive_url":"https://api.github.com/repos/juju/testing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju/testing/downloads","issues_url":"https://api.github.com/repos/juju/testing/issues{/number}","pulls_url":"https://api.github.com/repos/juju/testing/pulls{/number}","milestones_url":"https://api.github.com/repos/juju/testing/milestones{/number}","notifications_url":"https://api.github.com/repos/juju/testing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju/testing/labels{/name}","releases_url":"https://api.github.com/repos/juju/testing/releases{/id}","created_at":"2014-02-11T23:08:23Z","updated_at":"2014-07-02T15:56:46Z","pushed_at":"2014-08-06T23:11:51Z","git_url":"git://github.com/juju/testing.git","ssh_url":"git@github.com:juju/testing.git","clone_url":"https://github.com/juju/testing.git","svn_url":"https://github.com/juju/testing","homepage":null,"size":786,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":11,"mirror_url":null,"open_issues_count":4,"forks":11,"open_issues":4,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/juju/testing/pulls/27"},"html":{"href":"https://github.com/juju/testing/pull/27"},"issue":{"href":"https://api.github.com/repos/juju/testing/issues/27"},"comments":{"href":"https://api.github.com/repos/juju/testing/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/juju/testing/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/juju/testing/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/juju/testing/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/juju/testing/statuses/d88c94f080e6257252e88dc96d165bfb5ffce9ec"}}}}