GitHub PullRequestEvent at 2014-04-26 21:34:54
Repository: CNET-TV.bundle
Actor: shopgirl284
Payload: {"action":"opened","number":13,"pull_request":{"url":"https://api.github.com/repos/plexinc-plugins/CNET-TV.bundle/pulls/13","id":15206467,"html_url":"https://github.com/plexinc-plugins/CNET-TV.bundle/pull/13","diff_url":"https://github.com/plexinc-plugins/CNET-TV.bundle/pull/13.diff","patch_url":"https://github.com/plexinc-plugins/CNET-TV.bundle/pull/13.patch","issue_url":"https://api.github.com/repos/plexinc-plugins/CNET-TV.bundle/issues/13","number":13,"state":"open","title":"Rewrite for new CNET video website","user":{"login":"shopgirl284","id":2567662,"avatar_url":"https://avatars.githubusercontent.com/u/2567662?","gravatar_id":"be82835800ef1ae871a14544485fa23a","url":"https://api.github.com/users/shopgirl284","html_url":"https://github.com/shopgirl284","followers_url":"https://api.github.com/users/shopgirl284/followers","following_url":"https://api.github.com/users/shopgirl284/following{/other_user}","gists_url":"https://api.github.com/users/shopgirl284/gists{/gist_id}","starred_url":"https://api.github.com/users/shopgirl284/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shopgirl284/subscriptions","organizations_url":"https://api.github.com/users/shopgirl284/orgs","repos_url":"https://api.github.com/users/shopgirl284/repos","events_url":"https://api.github.com/users/shopgirl284/events{/privacy}","received_events_url":"https://api.github.com/users/shopgirl284/received_events","type":"User","site_admin":false},"body":"Here is a rewrite of the CNET video plugin.\r\n\r\nI tried to use the existing videoID data, but was unable to get any of the video to come up. \r\n\r\nThey are using a mix of json and html to produce their videos, so the Video function checks for all types of videos on a page. It was better to combine them since many pages use more than one type of video on the same page. \r\n\r\nThe video player used on the main page is not the same as those used on some show pages. So I used the individual video json to pull those, but they left out a lot of data when it is used on the main page vs when individual json is used for videos on the show pages.But adding a try/except and a side function to handle the differences was the bet way to get those videos in the player from the main video page.\r\n\r\nI am not sure if you have finished the rewrite of the url service but the testing I did seemed to work fine on the Roku, but not on Plex/Web.","created_at":"2014-04-26T21:34:54Z","updated_at":"2014-04-26T21:34:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/plexinc-plugins/CNET-TV.bundle/pulls/13/commits","review_comments_url":"https://api.github.com/repos/plexinc-plugins/CNET-TV.bundle/pulls/13/comments","review_comment_url":"https://api.github.com/repos/plexinc-plugins/CNET-TV.bundle/pulls/comments/{number}","comments_url":"https://api.github.com/repos/plexinc-plugins/CNET-TV.bundle/issues/13/comments","statuses_url":"https://api.github.com/repos/plexinc-plugins/CNET-TV.bundle/statuses/0b8292d7d7f87278e1ff4ec42db26106a0293978","head":{"label":"shopgirl284:cnetfix","ref":"cnetfix","sha":"0b8292d7d7f87278e1ff4ec42db26106a0293978","user":{"login":"shopgirl284","id":2567662,"avatar_url":"https://avatars.githubusercontent.com/u/2567662?","gravatar_id":"be82835800ef1ae871a14544485fa23a","url":"https://api.github.com/users/shopgirl284","html_url":"https://github.com/shopgirl284","followers_url":"https://api.github.com/users/shopgirl284/followers","following_url":"https://api.github.com/users/shopgirl284/following{/other_user}","gists_url":"https://api.github.com/users/shopgirl284/gists{/gist_id}","starred_url":"https://api.github.com/users/shopgirl284/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shopgirl284/subscriptions","organizations_url":"https://api.github.com/users/shopgirl284/orgs","repos_url":"https://api.github.com/users/shopgirl284/repos","events_url":"https://api.github.com/users/shopgirl284/events{/privacy}","received_events_url":"https://api.github.com/users/shopgirl284/received_events","type":"User","site_admin":false},"repo":{"id":19188462,"name":"CNET-TV.bundle","full_name":"shopgirl284/CNET-TV.bundle","owner":{"login":"shopgirl284","id":2567662,"avatar_url":"https://avatars.githubusercontent.com/u/2567662?","gravatar_id":"be82835800ef1ae871a14544485fa23a","url":"https://api.github.com/users/shopgirl284","html_url":"https://github.com/shopgirl284","followers_url":"https://api.github.com/users/shopgirl284/followers","following_url":"https://api.github.com/users/shopgirl284/following{/other_user}","gists_url":"https://api.github.com/users/shopgirl284/gists{/gist_id}","starred_url":"https://api.github.com/users/shopgirl284/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shopgirl284/subscriptions","organizations_url":"https://api.github.com/users/shopgirl284/orgs","repos_url":"https://api.github.com/users/shopgirl284/repos","events_url":"https://api.github.com/users/shopgirl284/events{/privacy}","received_events_url":"https://api.github.com/users/shopgirl284/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shopgirl284/CNET-TV.bundle","description":null,"fork":true,"url":"https://api.github.com/repos/shopgirl284/CNET-TV.bundle","forks_url":"https://api.github.com/repos/shopgirl284/CNET-TV.bundle/forks","keys_url":"https://api.github.com/repos/shopgirl284/CNET-TV.bundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shopgirl284/CNET-TV.bundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shopgirl284/CNET-TV.bundle/teams","hooks_url":"https://api.github.com/repos/shopgirl284/CNET-TV.bundle/hooks","issue_events_url":"https://api.github.com/repos/shopgirl284/CNET-TV.bundle/issues/events{/number}","events_url":"https://api.github.com/repos/shopgirl284/CNET-TV.bundle/events","assignees_url":"https://api.github.com/repos/shopgirl284/CNET-TV.bundle/assignees{/user}","branches_url":"https://api.github.com/repos/shopgirl284/CNET-TV.bundle/branches{/branch}","tags_url":"https://api.github.com/repos/shopgirl284/CNET-TV.bundle/tags","blobs_url":"https://api.github.com/repos/shopgirl284/CNET-TV.bundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shopgirl284/CNET-TV.bundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shopgirl284/CNET-TV.bundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/shopgirl284/CNET-TV.bundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shopgirl284/CNET-TV.bundle/statuses/{sha}","languages_url":"https://api.github.com/repos/shopgirl284/CNET-TV.bundle/languages","stargazers_url":"https://api.github.com/repos/shopgirl284/CNET-TV.bundle/stargazers","contributors_url":"https://api.github.com/repos/shopgirl284/CNET-TV.bundle/contributors","subscribers_url":"https://api.github.com/repos/shopgirl284/CNET-TV.bundle/subscribers","subscription_url":"https://api.github.com/repos/shopgirl284/CNET-TV.bundle/subscription","commits_url":"https://api.github.com/repos/shopgirl284/CNET-TV.bundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/shopgirl284/CNET-TV.bundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/shopgirl284/CNET-TV.bundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/shopgirl284/CNET-TV.bundle/issues/comments/{number}","contents_url":"https://api.github.com/repos/shopgirl284/CNET-TV.bundle/contents/{+path}","compare_url":"https://api.github.com/repos/shopgirl284/CNET-TV.bundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shopgirl284/CNET-TV.bundle/merges","archive_url":"https://api.github.com/repos/shopgirl284/CNET-TV.bundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shopgirl284/CNET-TV.bundle/downloads","issues_url":"https://api.github.com/repos/shopgirl284/CNET-TV.bundle/issues{/number}","pulls_url":"https://api.github.com/repos/shopgirl284/CNET-TV.bundle/pulls{/number}","milestones_url":"https://api.github.com/repos/shopgirl284/CNET-TV.bundle/milestones{/number}","notifications_url":"https://api.github.com/repos/shopgirl284/CNET-TV.bundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shopgirl284/CNET-TV.bundle/labels{/name}","releases_url":"https://api.github.com/repos/shopgirl284/CNET-TV.bundle/releases{/id}","created_at":"2014-04-26T20:59:04Z","updated_at":"2014-04-26T21:34:54Z","pushed_at":"2014-04-26T21:17:58Z","git_url":"git://github.com/shopgirl284/CNET-TV.bundle.git","ssh_url":"git@github.com:shopgirl284/CNET-TV.bundle.git","clone_url":"https://github.com/shopgirl284/CNET-TV.bundle.git","svn_url":"https://github.com/shopgirl284/CNET-TV.bundle","homepage":null,"size":315,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"plexinc-plugins:master","ref":"master","sha":"afbf16e90acac944a8dee751ab8a27f4d1c65836","user":{"login":"plexinc-plugins","id":347847,"avatar_url":"https://avatars.githubusercontent.com/u/347847?","gravatar_id":"919f88a5c972e79998370221a1669494","url":"https://api.github.com/users/plexinc-plugins","html_url":"https://github.com/plexinc-plugins","followers_url":"https://api.github.com/users/plexinc-plugins/followers","following_url":"https://api.github.com/users/plexinc-plugins/following{/other_user}","gists_url":"https://api.github.com/users/plexinc-plugins/gists{/gist_id}","starred_url":"https://api.github.com/users/plexinc-plugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plexinc-plugins/subscriptions","organizations_url":"https://api.github.com/users/plexinc-plugins/orgs","repos_url":"https://api.github.com/users/plexinc-plugins/repos","events_url":"https://api.github.com/users/plexinc-plugins/events{/privacy}","received_events_url":"https://api.github.com/users/plexinc-plugins/received_events","type":"Organization","site_admin":false},"repo":{"id":804846,"name":"CNET-TV.bundle","full_name":"plexinc-plugins/CNET-TV.bundle","owner":{"login":"plexinc-plugins","id":347847,"avatar_url":"https://avatars.githubusercontent.com/u/347847?","gravatar_id":"919f88a5c972e79998370221a1669494","url":"https://api.github.com/users/plexinc-plugins","html_url":"https://github.com/plexinc-plugins","followers_url":"https://api.github.com/users/plexinc-plugins/followers","following_url":"https://api.github.com/users/plexinc-plugins/following{/other_user}","gists_url":"https://api.github.com/users/plexinc-plugins/gists{/gist_id}","starred_url":"https://api.github.com/users/plexinc-plugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plexinc-plugins/subscriptions","organizations_url":"https://api.github.com/users/plexinc-plugins/orgs","repos_url":"https://api.github.com/users/plexinc-plugins/repos","events_url":"https://api.github.com/users/plexinc-plugins/events{/privacy}","received_events_url":"https://api.github.com/users/plexinc-plugins/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/plexinc-plugins/CNET-TV.bundle","description":null,"fork":false,"url":"https://api.github.com/repos/plexinc-plugins/CNET-TV.bundle","forks_url":"https://api.github.com/repos/plexinc-plugins/CNET-TV.bundle/forks","keys_url":"https://api.github.com/repos/plexinc-plugins/CNET-TV.bundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plexinc-plugins/CNET-TV.bundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plexinc-plugins/CNET-TV.bundle/teams","hooks_url":"https://api.github.com/repos/plexinc-plugins/CNET-TV.bundle/hooks","issue_events_url":"https://api.github.com/repos/plexinc-plugins/CNET-TV.bundle/issues/events{/number}","events_url":"https://api.github.com/repos/plexinc-plugins/CNET-TV.bundle/events","assignees_url":"https://api.github.com/repos/plexinc-plugins/CNET-TV.bundle/assignees{/user}","branches_url":"https://api.github.com/repos/plexinc-plugins/CNET-TV.bundle/branches{/branch}","tags_url":"https://api.github.com/repos/plexinc-plugins/CNET-TV.bundle/tags","blobs_url":"https://api.github.com/repos/plexinc-plugins/CNET-TV.bundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plexinc-plugins/CNET-TV.bundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plexinc-plugins/CNET-TV.bundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/plexinc-plugins/CNET-TV.bundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plexinc-plugins/CNET-TV.bundle/statuses/{sha}","languages_url":"https://api.github.com/repos/plexinc-plugins/CNET-TV.bundle/languages","stargazers_url":"https://api.github.com/repos/plexinc-plugins/CNET-TV.bundle/stargazers","contributors_url":"https://api.github.com/repos/plexinc-plugins/CNET-TV.bundle/contributors","subscribers_url":"https://api.github.com/repos/plexinc-plugins/CNET-TV.bundle/subscribers","subscription_url":"https://api.github.com/repos/plexinc-plugins/CNET-TV.bundle/subscription","commits_url":"https://api.github.com/repos/plexinc-plugins/CNET-TV.bundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/plexinc-plugins/CNET-TV.bundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/plexinc-plugins/CNET-TV.bundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/plexinc-plugins/CNET-TV.bundle/issues/comments/{number}","contents_url":"https://api.github.com/repos/plexinc-plugins/CNET-TV.bundle/contents/{+path}","compare_url":"https://api.github.com/repos/plexinc-plugins/CNET-TV.bundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plexinc-plugins/CNET-TV.bundle/merges","archive_url":"https://api.github.com/repos/plexinc-plugins/CNET-TV.bundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plexinc-plugins/CNET-TV.bundle/downloads","issues_url":"https://api.github.com/repos/plexinc-plugins/CNET-TV.bundle/issues{/number}","pulls_url":"https://api.github.com/repos/plexinc-plugins/CNET-TV.bundle/pulls{/number}","milestones_url":"https://api.github.com/repos/plexinc-plugins/CNET-TV.bundle/milestones{/number}","notifications_url":"https://api.github.com/repos/plexinc-plugins/CNET-TV.bundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plexinc-plugins/CNET-TV.bundle/labels{/name}","releases_url":"https://api.github.com/repos/plexinc-plugins/CNET-TV.bundle/releases{/id}","created_at":"2010-07-29T08:57:47Z","updated_at":"2014-03-25T18:20:54Z","pushed_at":"2014-03-25T18:20:54Z","git_url":"git://github.com/plexinc-plugins/CNET-TV.bundle.git","ssh_url":"git@github.com:plexinc-plugins/CNET-TV.bundle.git","clone_url":"https://github.com/plexinc-plugins/CNET-TV.bundle.git","svn_url":"https://github.com/plexinc-plugins/CNET-TV.bundle","homepage":null,"size":336,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/plexinc-plugins/CNET-TV.bundle/pulls/13"},"html":{"href":"https://github.com/plexinc-plugins/CNET-TV.bundle/pull/13"},"issue":{"href":"https://api.github.com/repos/plexinc-plugins/CNET-TV.bundle/issues/13"},"comments":{"href":"https://api.github.com/repos/plexinc-plugins/CNET-TV.bundle/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/plexinc-plugins/CNET-TV.bundle/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/plexinc-plugins/CNET-TV.bundle/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/plexinc-plugins/CNET-TV.bundle/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/plexinc-plugins/CNET-TV.bundle/statuses/0b8292d7d7f87278e1ff4ec42db26106a0293978"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":127,"deletions":84,"changed_files":1}}