GitHub PullRequestReviewCommentEvent at 2014-12-02 05:09:40
Repository: spark
Actor: YanTangZhai
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/21140476","id":21140476,"diff_hunk":"@@ -238,10 +238,13 @@ class HadoopRDD[K, V](\n       val value: V = reader.createValue()\n \n       var recordsSinceMetricsUpdate = 0\n+      var startTime : Long = 0L\n \n       override def getNext() = {\n         try {\n+          startTime = System.nanoTime\n           finished = !reader.next(key, value)\n+          inputMetrics.readTime += (System.nanoTime - startTime)","path":"core/src/main/scala/org/apache/spark/rdd/HadoopRDD.scala","position":10,"original_position":10,"commit_id":"3816f8540b947809cb821bcb3af36d7be0210d9c","original_commit_id":"3816f8540b947809cb821bcb3af36d7be0210d9c","user":{"login":"YanTangZhai","id":4452846,"avatar_url":"https://avatars.githubusercontent.com/u/4452846?v=3","gravatar_id":"","url":"https://api.github.com/users/YanTangZhai","html_url":"https://github.com/YanTangZhai","followers_url":"https://api.github.com/users/YanTangZhai/followers","following_url":"https://api.github.com/users/YanTangZhai/following{/other_user}","gists_url":"https://api.github.com/users/YanTangZhai/gists{/gist_id}","starred_url":"https://api.github.com/users/YanTangZhai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YanTangZhai/subscriptions","organizations_url":"https://api.github.com/users/YanTangZhai/orgs","repos_url":"https://api.github.com/users/YanTangZhai/repos","events_url":"https://api.github.com/users/YanTangZhai/events{/privacy}","received_events_url":"https://api.github.com/users/YanTangZhai/received_events","type":"User","site_admin":false},"body":"Oh sorry. It may be expensive. Let me think about it. Thanks.","created_at":"2014-12-02T05:09:40Z","updated_at":"2014-12-02T05:09:40Z","html_url":"https://github.com/apache/spark/pull/3539#discussion_r21140476","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/3539","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/21140476"},"html":{"href":"https://github.com/apache/spark/pull/3539#discussion_r21140476"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/3539"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/3539","id":25270600,"html_url":"https://github.com/apache/spark/pull/3539","diff_url":"https://github.com/apache/spark/pull/3539.diff","patch_url":"https://github.com/apache/spark/pull/3539.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/3539","number":3539,"state":"open","locked":false,"title":"[SPARK-4677] [WEB] Add hadoop input time in task webui","user":{"login":"YanTangZhai","id":4452846,"avatar_url":"https://avatars.githubusercontent.com/u/4452846?v=3","gravatar_id":"","url":"https://api.github.com/users/YanTangZhai","html_url":"https://github.com/YanTangZhai","followers_url":"https://api.github.com/users/YanTangZhai/followers","following_url":"https://api.github.com/users/YanTangZhai/following{/other_user}","gists_url":"https://api.github.com/users/YanTangZhai/gists{/gist_id}","starred_url":"https://api.github.com/users/YanTangZhai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YanTangZhai/subscriptions","organizations_url":"https://api.github.com/users/YanTangZhai/orgs","repos_url":"https://api.github.com/users/YanTangZhai/repos","events_url":"https://api.github.com/users/YanTangZhai/events{/privacy}","received_events_url":"https://api.github.com/users/YanTangZhai/received_events","type":"User","site_admin":false},"body":"Add hadoop input time in task webui like GC Time to explicitly show the time used by task to read input data.","created_at":"2014-12-01T14:17:02Z","updated_at":"2014-12-02T05:09:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"18359a9392869c1f920fa81c74e6e7b1ce0e50ec","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/3539/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/3539/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments/{number}","comments_url":"https://api.github.com/repos/apache/spark/issues/3539/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/3816f8540b947809cb821bcb3af36d7be0210d9c","head":{"label":"YanTangZhai:WebuiInputTime","ref":"WebuiInputTime","sha":"3816f8540b947809cb821bcb3af36d7be0210d9c","user":{"login":"YanTangZhai","id":4452846,"avatar_url":"https://avatars.githubusercontent.com/u/4452846?v=3","gravatar_id":"","url":"https://api.github.com/users/YanTangZhai","html_url":"https://github.com/YanTangZhai","followers_url":"https://api.github.com/users/YanTangZhai/followers","following_url":"https://api.github.com/users/YanTangZhai/following{/other_user}","gists_url":"https://api.github.com/users/YanTangZhai/gists{/gist_id}","starred_url":"https://api.github.com/users/YanTangZhai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YanTangZhai/subscriptions","organizations_url":"https://api.github.com/users/YanTangZhai/orgs","repos_url":"https://api.github.com/users/YanTangZhai/repos","events_url":"https://api.github.com/users/YanTangZhai/events{/privacy}","received_events_url":"https://api.github.com/users/YanTangZhai/received_events","type":"User","site_admin":false},"repo":{"id":22341395,"name":"spark","full_name":"YanTangZhai/spark","owner":{"login":"YanTangZhai","id":4452846,"avatar_url":"https://avatars.githubusercontent.com/u/4452846?v=3","gravatar_id":"","url":"https://api.github.com/users/YanTangZhai","html_url":"https://github.com/YanTangZhai","followers_url":"https://api.github.com/users/YanTangZhai/followers","following_url":"https://api.github.com/users/YanTangZhai/following{/other_user}","gists_url":"https://api.github.com/users/YanTangZhai/gists{/gist_id}","starred_url":"https://api.github.com/users/YanTangZhai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YanTangZhai/subscriptions","organizations_url":"https://api.github.com/users/YanTangZhai/orgs","repos_url":"https://api.github.com/users/YanTangZhai/repos","events_url":"https://api.github.com/users/YanTangZhai/events{/privacy}","received_events_url":"https://api.github.com/users/YanTangZhai/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/YanTangZhai/spark","description":"yantangzhai_spark_mirror","fork":true,"url":"https://api.github.com/repos/YanTangZhai/spark","forks_url":"https://api.github.com/repos/YanTangZhai/spark/forks","keys_url":"https://api.github.com/repos/YanTangZhai/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/YanTangZhai/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/YanTangZhai/spark/teams","hooks_url":"https://api.github.com/repos/YanTangZhai/spark/hooks","issue_events_url":"https://api.github.com/repos/YanTangZhai/spark/issues/events{/number}","events_url":"https://api.github.com/repos/YanTangZhai/spark/events","assignees_url":"https://api.github.com/repos/YanTangZhai/spark/assignees{/user}","branches_url":"https://api.github.com/repos/YanTangZhai/spark/branches{/branch}","tags_url":"https://api.github.com/repos/YanTangZhai/spark/tags","blobs_url":"https://api.github.com/repos/YanTangZhai/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/YanTangZhai/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/YanTangZhai/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/YanTangZhai/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/YanTangZhai/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/YanTangZhai/spark/languages","stargazers_url":"https://api.github.com/repos/YanTangZhai/spark/stargazers","contributors_url":"https://api.github.com/repos/YanTangZhai/spark/contributors","subscribers_url":"https://api.github.com/repos/YanTangZhai/spark/subscribers","subscription_url":"https://api.github.com/repos/YanTangZhai/spark/subscription","commits_url":"https://api.github.com/repos/YanTangZhai/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/YanTangZhai/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/YanTangZhai/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/YanTangZhai/spark/issues/comments/{number}","contents_url":"https://api.github.com/repos/YanTangZhai/spark/contents/{+path}","compare_url":"https://api.github.com/repos/YanTangZhai/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/YanTangZhai/spark/merges","archive_url":"https://api.github.com/repos/YanTangZhai/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/YanTangZhai/spark/downloads","issues_url":"https://api.github.com/repos/YanTangZhai/spark/issues{/number}","pulls_url":"https://api.github.com/repos/YanTangZhai/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/YanTangZhai/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/YanTangZhai/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/YanTangZhai/spark/labels{/name}","releases_url":"https://api.github.com/repos/YanTangZhai/spark/releases{/id}","created_at":"2014-07-28T12:16:37Z","updated_at":"2014-12-01T11:24:07Z","pushed_at":"2014-12-02T04:07:09Z","git_url":"git://github.com/YanTangZhai/spark.git","ssh_url":"git@github.com:YanTangZhai/spark.git","clone_url":"https://github.com/YanTangZhai/spark.git","svn_url":"https://github.com/YanTangZhai/spark","homepage":"","size":83941,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"30a86acdefd5428af6d6264f59a037e0eefd74b4","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments/{number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2014-12-02T03:41:07Z","pushed_at":"2014-12-02T03:41:26Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":4191445,"stargazers_count":2187,"watchers_count":2187,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1950,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":312,"forks":1950,"open_issues":312,"watchers":2187,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/3539"},"html":{"href":"https://github.com/apache/spark/pull/3539"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/3539"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/3539/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/3539/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/3539/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/3816f8540b947809cb821bcb3af36d7be0210d9c"}}}}