GitHub PushEvent at 2014-06-27 07:24:47
Repository: git
Actor: seveas
Payload: {"shas":[["0166027e56cd743fabc93191b525647153519f15","d2635f9f6be81b9042e1c1be60d20ebe0e16c7e2@gmail.com","l10n: Init Vietnamese translation\n\nSigned-off-by: Trần Ngọc Quân <vnwildman@gmail.com>","Trần Ngọc Quân",false],["c4a0483fd5917dfa77024d5b46cb48f62dc32424","19a0ba370c443ba08d20b5061586430ab449ee8c@samba.org","gitk: Merge branch 'new' of https://github.com/vnwildman/gitk\n\nto get Vietnamese translations for gitk.\n\nSigned-off-by: Paul Mackerras <paulus@samba.org>","Paul Mackerras",false],["e0db1dd7d4bc87825f0d7d743f1a01b4461a59ff","3a81d01482cca860e4077eb409d7db78ebdc6f24@web.de","git-gui: show staged submodules regardless of ignore config\n\nCurrently setting submodule.<name>.ignore and/or diff.ignoreSubmodules to\n\"all\" suppresses all output of submodule changes for git-gui. This is\nreally confusing, as even when the user chooses to record a new commit for\nan ignored submodule by adding it manually this change won't show up under\n\"Staged Changes (Will Commit)\".\n\nFix that by using the '--ignore-submodules=dirty' option for both callers\nof \"git diff-index --cached\" when the underlying git version supports that\noption.\n\nSigned-off-by: Jens Lehmann <Jens.Lehmann@web.de>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>\nSigned-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>","Jens Lehmann",false],["3decb8e0ac5d951f0a0cf6e604790b471aef22e1","3a81d01482cca860e4077eb409d7db78ebdc6f24@web.de","git-gui: tolerate major version changes when comparing the git version\n\nSince git 2.0.0 starting git gui in a submodule using a gitfile fails with\nthe following error:\n\n   No working directory ../../../<path>\n\n   couldn't change working directory\n   to \"../../../<path>\": no such file or\n   directory\n\nThis is because \"git rev-parse --show-toplevel\" is only run when git gui\nsees a git version of at least 1.7.0 (which is the version in which the\n --show-toplevel option was introduced). But \"package vsatisfies\" returns\nfalse when the major version changes, which is not what we want here.\n\nFix that for both places where the git version is checked using vsatisfies\nby appending a '-' to the version number. This tells vsatisfies that a\nchange of the major version is not considered to be a problem, as long as\nthe new major version is larger. This is done for both the place that\ncaused the reported bug and another spot where the git version is tested\nfor another feature.\n\nReported-by: Chris Packham <judge.packham@gmail.com>\nReported-by: Yann Dirson <ydirson@free.fr>\nSigned-off-by: Jens Lehmann <Jens.Lehmann@web.de>","Jens Lehmann",false],["ada2ea1695c4200dd9deaef2034cc453c27729f7","db6c03a4ecc382e80fea1976e4cf8e5a8f985dcc@gmail.com","gitk: Replace SHA1 entry field on keyboard paste\n\nWe already replace old SHA with the clipboard content for the mouse\npaste event.  It seems reasonable to do the same when pasting from\nkeyboard.\n\nSigned-off-by: Ilya Bobyr <ilya.bobyr@gmail.com>\nSigned-off-by: Paul Mackerras <paulus@samba.org>","Ilya Bobyr",false],["4135d36b0c99329eff69686f7a17406053941b5c","0706025b2bbcec1ed8d64822f4eccd96314938d0@max630.net","gitk: Switch to patch mode when searching for line origin\n\nIf the \"Show origin of this line\" is started from tree mode,\nit still shows the result in tree mode, which I suppose not\nwhat user expects to see.\n\nSigned-off-by: Paul Mackerras <paulus@samba.org>","Max Kirillov",false],["019e1630ac16f82fa6322869c8dfc3dee029e7ae","087231934ba8fcf78bc142ce37d193b895ac03c4@MIT.EDU","gitk: Allow displaying time zones from author and commit dates timestamps\n\nNow gitk can be configured to display author and commit dates in their\noriginal timezone, by putting %z into datetimeformat in ~/.gitk.\n\nSigned-off-by: Anders Kaseorg <andersk@mit.edu>\nSigned-off-by: Paul Mackerras <paulus@samba.org>","Anders Kaseorg",false],["17f9836c8afc8d4b6d6bb91fd0658df090d75c8f","3a81d01482cca860e4077eb409d7db78ebdc6f24@web.de","gitk: Show staged submodules regardless of ignore config\n\nCurrently setting submodule.<name>.ignore and/or diff.ignoreSubmodules to\n\"all\" suppresses all output of submodule changes for gitk. This is really\nconfusing, as even when the user chooses to record a new commit for an\nignored submodule by adding it manually this change won't show up under\n\"Local changes checked in to index but not committed\".\n\nFix that by using the '--ignore-submodules=dirty' option for both callers\nof \"git diff-index --cached\" when the underlying git version supports that\noption.\n\nSigned-off-by: Jens Lehmann <Jens.Lehmann@web.de>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>\nSigned-off-by: Paul Mackerras <paulus@samba.org>","Jens Lehmann",false],["9e1a5ebe52d84c35eee18a896ad1b8bab53cadbf","696e3fbcf235d40b6ea1ebd61c87cbea79d444e7@peff.net","parse_diff_color_slot: drop ofs parameter\n\nThis function originally took a whole config variable name\n(\"var\") and an offset (\"ofs\"). It checked \"var+ofs\" against\neach color slot, but reported errors using the whole \"var\".\n\nHowever, since 8b8e862 (ignore unknown color configuration,\n2009-12-12), it returns -1 rather than printing its own\nerror, and therefore only cares about var+ofs. We can drop\nthe ofs parameter and teach its sole caller to derive the\npointer itself.\n\nSigned-off-by: Jeff King <peff@peff.net>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","Jeff King",false],["1055a890f04784d7ea7cdaca8d30479e685d8643","696e3fbcf235d40b6ea1ebd61c87cbea79d444e7@peff.net","daemon: mark some strings as const\n\nNone of these strings is modified; marking them as const\nwill help later refactoring.\n\nSigned-off-by: Jeff King <peff@peff.net>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","Jeff King",false],["c0264180d74510669bcec9bb5ff12a145c685b8e","696e3fbcf235d40b6ea1ebd61c87cbea79d444e7@peff.net","avoid using skip_prefix as a boolean\n\nThere's no point in using:\n\n  if (skip_prefix(buf, \"foo\"))\n\nover\n\n  if (starts_with(buf, \"foo\"))\n\nas the point of skip_prefix is to return a pointer to the\ndata after the prefix. Using starts_with is more readable,\nand will make refactoring skip_prefix easier.\n\nSigned-off-by: Jeff King <peff@peff.net>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","Jeff King",false],["30a0ddb705678d512185e359831479a6b3567147","696e3fbcf235d40b6ea1ebd61c87cbea79d444e7@peff.net","strbuf: add xstrfmt helper\n\nYou can use a strbuf to build up a string from parts, and\nthen detach it. In the general case, you might use multiple\nstrbuf_add* functions to do the building. However, in many\ncases, a single strbuf_addf is sufficient, and we end up\nwith:\n\n  struct strbuf buf = STRBUF_INIT;\n  ...\n  strbuf_addf(&buf, fmt, some, args);\n  str = strbuf_detach(&buf, NULL);\n\nWe can make this much more readable (and avoid introducing\nan extra variable, which can clutter the code) by\nintroducing a convenience function:\n\n  str = xstrfmt(fmt, some, args);\n\nSigned-off-by: Jeff King <peff@peff.net>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","Jeff King",false],["fa3f60b783b42e0d07c667a8f582c3df12791cec","696e3fbcf235d40b6ea1ebd61c87cbea79d444e7@peff.net","use xstrfmt in favor of manual size calculations\n\nIn many parts of the code, we do an ugly and error-prone\nmalloc like:\n\n  const char *fmt = \"something %s\";\n  buf = xmalloc(strlen(foo) + 10 + 1);\n  sprintf(buf, fmt, foo);\n\nThis makes the code brittle, and if we ever get the\nallocation wrong, is a potential heap overflow. Let's\ninstead favor xstrfmt, which handles the allocation\nautomatically, and makes the code shorter and more readable.\n\nSigned-off-by: Jeff King <peff@peff.net>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","Jeff King",false],["95244ae3dd49b3eed4dbfe09299b9d8847622218","696e3fbcf235d40b6ea1ebd61c87cbea79d444e7@peff.net","use xstrdup instead of xmalloc + strcpy\n\nThis is one line shorter, and makes sure the length in the\nmalloc and copy steps match.\n\nSigned-off-by: Jeff King <peff@peff.net>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","Jeff King",false],["283101869bea8feb5d58f6ea1b568e9b197526d3","696e3fbcf235d40b6ea1ebd61c87cbea79d444e7@peff.net","use xstrfmt to replace xmalloc + sprintf\n\nThis is one line shorter, and makes sure the length in the\nmalloc and sprintf steps match.\n\nThese conversions are very straightforward; we can drop the\nmalloc entirely, and replace the sprintf with xstrfmt.\n\nSigned-off-by: Jeff King <peff@peff.net>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","Jeff King",false],["b2724c87872aaec55dd7e5529aa029c3108b43a5","696e3fbcf235d40b6ea1ebd61c87cbea79d444e7@peff.net","use xstrfmt to replace xmalloc + strcpy/strcat\n\nIt's easy to get manual allocation calculations wrong, and\nthe use of strcpy/strcat raise red flags for people looking\nfor buffer overflows (though in this case each site was\nfine).\n\nIt's also shorter to use xstrfmt, and the printf-format\ntends to be easier for a reader to see what the final string\nwill look like.\n\nSigned-off-by: Jeff King <peff@peff.net>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","Jeff King",false],["a0279e1865c7ce7417c0134e2ab32b20531f502a","696e3fbcf235d40b6ea1ebd61c87cbea79d444e7@peff.net","setup_git_env: use git_pathdup instead of xmalloc + sprintf\n\nThis is shorter, harder to get wrong, and more clearly\ncaptures the intent.\n\nSigned-off-by: Jeff King <peff@peff.net>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","Jeff King",false],["3bdd55228b1b76a2c37143636966f333e3782888","696e3fbcf235d40b6ea1ebd61c87cbea79d444e7@peff.net","sequencer: use argv_array_pushf\n\nThis avoids a manual allocation calculation, and is shorter\nto boot.\n\nSigned-off-by: Jeff King <peff@peff.net>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","Jeff King",false],["5c1753b198a96ed6abaf6c09db4623df703005a6","696e3fbcf235d40b6ea1ebd61c87cbea79d444e7@peff.net","merge: use argv_array when spawning merge strategy\n\nThis is shorter, and avoids a rather complicated set of\nallocation and free steps.\n\nSigned-off-by: Jeff King <peff@peff.net>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","Jeff King",false],["f33206992de994424036a7d9912a968ab9829e6e","696e3fbcf235d40b6ea1ebd61c87cbea79d444e7@peff.net","walker_fetch: fix minor memory leak\n\nWe sometimes allocate \"msg\" on the heap, but will fail to\nfree it if we hit the failure code path. We can instead keep\na separate variable that is safe to be freed no matter how\nwe get to the failure code path.\n\nWhile we're here, we can also do two readability\nimprovements:\n\n  1. Use xstrfmt instead of a manual malloc/sprintf\n\n  2. Due to the \"maybe we allocate msg, maybe we don't\"\n     strategy, the logic for deciding which message to show\n     was split into two parts. Since the deallocation is now\n     pushed onto a separate variable, this is no longer a\n     concern, and we can keep all of the logic in the same\n     place.\n\nSigned-off-by: Jeff King <peff@peff.net>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","Jeff King",false]],"size":126,"ref":"refs/heads/dk/nd/multiple-work-trees","head":"1ba1cf688af44c843e83d3b94c719bcf0cc5fb9b"}