GitHub PullRequestReviewCommentEvent at 2014-08-06 06:18:48
Repository: fiware-connectors
Actor: fgalan
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/telefonicaid/fiware-connectors/pulls/comments/15857654","id":15857654,"diff_hunk":"@@ -188,10 +188,24 @@ public void configure(Context context) {\n         cosmosDefaultPassword = context.getString(\"cosmos_default_password\", \"\");\n         logger.debug(\"Reading configuration (cosmos_default_password=\" + cosmosDefaultPassword + \")\");\n         hdfsAPI = context.getString(\"hdfs_api\", \"httpfs\");\n-        logger.debug(\"Reading configuration (hdfs_api=\" + hdfsAPI + \")\");\n+        \n+        if (!hdfsAPI.equals(\"webhdfs\") && !hdfsAPI.equals(\"httpfs\")) {\n+            logger.error(\"Bad configuration (Unrecognized HDFS API. The sink can start, but the data is not \"\n+                        + \"going to be persisted!)\");","path":"flume/src/main/java/es/tid/fiware/fiwareconnectors/cygnus/sinks/OrionHDFSSink.java","position":8,"original_position":8,"commit_id":"85fbf696ab9c5a52a20474f8421812a4878539dc","original_commit_id":"85fbf696ab9c5a52a20474f8421812a4878539dc","user":{"login":"fgalan","id":1534240,"avatar_url":"https://avatars.githubusercontent.com/u/1534240?v=2","gravatar_id":"1936b0d16210811a2aa8de96295f0693","url":"https://api.github.com/users/fgalan","html_url":"https://github.com/fgalan","followers_url":"https://api.github.com/users/fgalan/followers","following_url":"https://api.github.com/users/fgalan/following{/other_user}","gists_url":"https://api.github.com/users/fgalan/gists{/gist_id}","starred_url":"https://api.github.com/users/fgalan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fgalan/subscriptions","organizations_url":"https://api.github.com/users/fgalan/orgs","repos_url":"https://api.github.com/users/fgalan/repos","events_url":"https://api.github.com/users/fgalan/events{/privacy}","received_events_url":"https://api.github.com/users/fgalan/received_events","type":"User","site_admin":false},"body":"Makes sense to start the sink in this situation (as the error message suggest)?","created_at":"2014-08-06T06:18:48Z","updated_at":"2014-08-06T06:18:48Z","html_url":"https://github.com/telefonicaid/fiware-connectors/pull/120#discussion_r15857654","pull_request_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/pulls/120","_links":{"self":{"href":"https://api.github.com/repos/telefonicaid/fiware-connectors/pulls/comments/15857654"},"html":{"href":"https://github.com/telefonicaid/fiware-connectors/pull/120#discussion_r15857654"},"pull_request":{"href":"https://api.github.com/repos/telefonicaid/fiware-connectors/pulls/120"}}},"pull_request":{"url":"https://api.github.com/repos/telefonicaid/fiware-connectors/pulls/120","id":19353440,"html_url":"https://github.com/telefonicaid/fiware-connectors/pull/120","diff_url":"https://github.com/telefonicaid/fiware-connectors/pull/120.diff","patch_url":"https://github.com/telefonicaid/fiware-connectors/pull/120.patch","issue_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/issues/120","number":120,"state":"open","title":"Check the content and the length of certain input data and MySQL database and table names","user":{"login":"frbattid","id":3865056,"avatar_url":"https://avatars.githubusercontent.com/u/3865056?v=2","gravatar_id":"388ce615be3850197791a9cf67fa5dac","url":"https://api.github.com/users/frbattid","html_url":"https://github.com/frbattid","followers_url":"https://api.github.com/users/frbattid/followers","following_url":"https://api.github.com/users/frbattid/following{/other_user}","gists_url":"https://api.github.com/users/frbattid/gists{/gist_id}","starred_url":"https://api.github.com/users/frbattid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frbattid/subscriptions","organizations_url":"https://api.github.com/users/frbattid/orgs","repos_url":"https://api.github.com/users/frbattid/repos","events_url":"https://api.github.com/users/frbattid/events{/privacy}","received_events_url":"https://api.github.com/users/frbattid/received_events","type":"User","site_admin":false},"body":"Fixes issue https://github.com/telefonicaid/fiware-connectors/issues/114","created_at":"2014-08-05T16:35:34Z","updated_at":"2014-08-06T06:18:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c87af42870f1fc91c79aab0016c40b069dfa976c","assignee":{"login":"fgalan","id":1534240,"avatar_url":"https://avatars.githubusercontent.com/u/1534240?v=2","gravatar_id":"1936b0d16210811a2aa8de96295f0693","url":"https://api.github.com/users/fgalan","html_url":"https://github.com/fgalan","followers_url":"https://api.github.com/users/fgalan/followers","following_url":"https://api.github.com/users/fgalan/following{/other_user}","gists_url":"https://api.github.com/users/fgalan/gists{/gist_id}","starred_url":"https://api.github.com/users/fgalan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fgalan/subscriptions","organizations_url":"https://api.github.com/users/fgalan/orgs","repos_url":"https://api.github.com/users/fgalan/repos","events_url":"https://api.github.com/users/fgalan/events{/privacy}","received_events_url":"https://api.github.com/users/fgalan/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/pulls/120/commits","review_comments_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/pulls/120/comments","review_comment_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/pulls/comments/{number}","comments_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/issues/120/comments","statuses_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/statuses/85fbf696ab9c5a52a20474f8421812a4878539dc","head":{"label":"telefonicaid:bug/114","ref":"bug/114","sha":"85fbf696ab9c5a52a20474f8421812a4878539dc","user":{"login":"telefonicaid","id":968363,"avatar_url":"https://avatars.githubusercontent.com/u/968363?v=2","gravatar_id":"05c84be2ce3d0a014ac4253156a1eaff","url":"https://api.github.com/users/telefonicaid","html_url":"https://github.com/telefonicaid","followers_url":"https://api.github.com/users/telefonicaid/followers","following_url":"https://api.github.com/users/telefonicaid/following{/other_user}","gists_url":"https://api.github.com/users/telefonicaid/gists{/gist_id}","starred_url":"https://api.github.com/users/telefonicaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telefonicaid/subscriptions","organizations_url":"https://api.github.com/users/telefonicaid/orgs","repos_url":"https://api.github.com/users/telefonicaid/repos","events_url":"https://api.github.com/users/telefonicaid/events{/privacy}","received_events_url":"https://api.github.com/users/telefonicaid/received_events","type":"Organization","site_admin":false},"repo":{"id":16607947,"name":"fiware-connectors","full_name":"telefonicaid/fiware-connectors","owner":{"login":"telefonicaid","id":968363,"avatar_url":"https://avatars.githubusercontent.com/u/968363?v=2","gravatar_id":"05c84be2ce3d0a014ac4253156a1eaff","url":"https://api.github.com/users/telefonicaid","html_url":"https://github.com/telefonicaid","followers_url":"https://api.github.com/users/telefonicaid/followers","following_url":"https://api.github.com/users/telefonicaid/following{/other_user}","gists_url":"https://api.github.com/users/telefonicaid/gists{/gist_id}","starred_url":"https://api.github.com/users/telefonicaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telefonicaid/subscriptions","organizations_url":"https://api.github.com/users/telefonicaid/orgs","repos_url":"https://api.github.com/users/telefonicaid/repos","events_url":"https://api.github.com/users/telefonicaid/events{/privacy}","received_events_url":"https://api.github.com/users/telefonicaid/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/telefonicaid/fiware-connectors","description":"FI-WARE connectors","fork":false,"url":"https://api.github.com/repos/telefonicaid/fiware-connectors","forks_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/forks","keys_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/keys{/key_id}","collaborators_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/teams","hooks_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/hooks","issue_events_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/issues/events{/number}","events_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/events","assignees_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/assignees{/user}","branches_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/branches{/branch}","tags_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/tags","blobs_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/git/refs{/sha}","trees_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/git/trees{/sha}","statuses_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/statuses/{sha}","languages_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/languages","stargazers_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/stargazers","contributors_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/contributors","subscribers_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/subscribers","subscription_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/subscription","commits_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/commits{/sha}","git_commits_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/git/commits{/sha}","comments_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/comments{/number}","issue_comment_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/issues/comments/{number}","contents_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/contents/{+path}","compare_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/compare/{base}...{head}","merges_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/merges","archive_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/downloads","issues_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/issues{/number}","pulls_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/pulls{/number}","milestones_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/milestones{/number}","notifications_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/labels{/name}","releases_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/releases{/id}","created_at":"2014-02-07T07:57:41Z","updated_at":"2014-07-06T03:19:35Z","pushed_at":"2014-08-05T16:34:04Z","git_url":"git://github.com/telefonicaid/fiware-connectors.git","ssh_url":"git@github.com:telefonicaid/fiware-connectors.git","clone_url":"https://github.com/telefonicaid/fiware-connectors.git","svn_url":"https://github.com/telefonicaid/fiware-connectors","homepage":"","size":61230,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":4,"mirror_url":null,"open_issues_count":27,"forks":4,"open_issues":27,"watchers":6,"default_branch":"develop"}},"base":{"label":"telefonicaid:release/iotplatform-v1","ref":"release/iotplatform-v1","sha":"2aa1c91407c8672a4a90178d41f2cd9eb65d5e1a","user":{"login":"telefonicaid","id":968363,"avatar_url":"https://avatars.githubusercontent.com/u/968363?v=2","gravatar_id":"05c84be2ce3d0a014ac4253156a1eaff","url":"https://api.github.com/users/telefonicaid","html_url":"https://github.com/telefonicaid","followers_url":"https://api.github.com/users/telefonicaid/followers","following_url":"https://api.github.com/users/telefonicaid/following{/other_user}","gists_url":"https://api.github.com/users/telefonicaid/gists{/gist_id}","starred_url":"https://api.github.com/users/telefonicaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telefonicaid/subscriptions","organizations_url":"https://api.github.com/users/telefonicaid/orgs","repos_url":"https://api.github.com/users/telefonicaid/repos","events_url":"https://api.github.com/users/telefonicaid/events{/privacy}","received_events_url":"https://api.github.com/users/telefonicaid/received_events","type":"Organization","site_admin":false},"repo":{"id":16607947,"name":"fiware-connectors","full_name":"telefonicaid/fiware-connectors","owner":{"login":"telefonicaid","id":968363,"avatar_url":"https://avatars.githubusercontent.com/u/968363?v=2","gravatar_id":"05c84be2ce3d0a014ac4253156a1eaff","url":"https://api.github.com/users/telefonicaid","html_url":"https://github.com/telefonicaid","followers_url":"https://api.github.com/users/telefonicaid/followers","following_url":"https://api.github.com/users/telefonicaid/following{/other_user}","gists_url":"https://api.github.com/users/telefonicaid/gists{/gist_id}","starred_url":"https://api.github.com/users/telefonicaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telefonicaid/subscriptions","organizations_url":"https://api.github.com/users/telefonicaid/orgs","repos_url":"https://api.github.com/users/telefonicaid/repos","events_url":"https://api.github.com/users/telefonicaid/events{/privacy}","received_events_url":"https://api.github.com/users/telefonicaid/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/telefonicaid/fiware-connectors","description":"FI-WARE connectors","fork":false,"url":"https://api.github.com/repos/telefonicaid/fiware-connectors","forks_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/forks","keys_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/keys{/key_id}","collaborators_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/teams","hooks_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/hooks","issue_events_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/issues/events{/number}","events_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/events","assignees_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/assignees{/user}","branches_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/branches{/branch}","tags_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/tags","blobs_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/git/refs{/sha}","trees_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/git/trees{/sha}","statuses_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/statuses/{sha}","languages_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/languages","stargazers_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/stargazers","contributors_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/contributors","subscribers_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/subscribers","subscription_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/subscription","commits_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/commits{/sha}","git_commits_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/git/commits{/sha}","comments_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/comments{/number}","issue_comment_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/issues/comments/{number}","contents_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/contents/{+path}","compare_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/compare/{base}...{head}","merges_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/merges","archive_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/downloads","issues_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/issues{/number}","pulls_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/pulls{/number}","milestones_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/milestones{/number}","notifications_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/labels{/name}","releases_url":"https://api.github.com/repos/telefonicaid/fiware-connectors/releases{/id}","created_at":"2014-02-07T07:57:41Z","updated_at":"2014-07-06T03:19:35Z","pushed_at":"2014-08-05T16:34:04Z","git_url":"git://github.com/telefonicaid/fiware-connectors.git","ssh_url":"git@github.com:telefonicaid/fiware-connectors.git","clone_url":"https://github.com/telefonicaid/fiware-connectors.git","svn_url":"https://github.com/telefonicaid/fiware-connectors","homepage":"","size":61230,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":4,"mirror_url":null,"open_issues_count":27,"forks":4,"open_issues":27,"watchers":6,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/telefonicaid/fiware-connectors/pulls/120"},"html":{"href":"https://github.com/telefonicaid/fiware-connectors/pull/120"},"issue":{"href":"https://api.github.com/repos/telefonicaid/fiware-connectors/issues/120"},"comments":{"href":"https://api.github.com/repos/telefonicaid/fiware-connectors/issues/120/comments"},"review_comments":{"href":"https://api.github.com/repos/telefonicaid/fiware-connectors/pulls/120/comments"},"review_comment":{"href":"https://api.github.com/repos/telefonicaid/fiware-connectors/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/telefonicaid/fiware-connectors/pulls/120/commits"},"statuses":{"href":"https://api.github.com/repos/telefonicaid/fiware-connectors/statuses/85fbf696ab9c5a52a20474f8421812a4878539dc"}}}}