GitHub PullRequestReviewCommentEvent at 2014-08-12 14:23:46
Repository: foreman-packaging
Actor: domcleal
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/theforeman/foreman-packaging/pulls/comments/16115577","id":16115577,"diff_hunk":"@@ -111,21 +111,21 @@ install -m 0644 foreman-selinux-relabel.man8 %{buildroot}%{_mandir}/man8/foreman\n %post\n if /usr/sbin/selinuxenabled; then\n     # install only\n-    [ $1 -eq 1 ] && %{_sbindir}/%{name}-enable || true\n+    [ $1 -eq 1 ] && %{_sbindir}/%{name}-enable","path":"foreman-selinux/foreman-selinux.spec","position":5,"original_position":5,"commit_id":"af7dbb6b1f58375e34fcc713c0717c442d25ffe2","original_commit_id":"af7dbb6b1f58375e34fcc713c0717c442d25ffe2","user":{"login":"domcleal","id":482089,"avatar_url":"https://avatars.githubusercontent.com/u/482089?v=2","gravatar_id":"b610ed8556fcee2b7ab876c642a4ce42","url":"https://api.github.com/users/domcleal","html_url":"https://github.com/domcleal","followers_url":"https://api.github.com/users/domcleal/followers","following_url":"https://api.github.com/users/domcleal/following{/other_user}","gists_url":"https://api.github.com/users/domcleal/gists{/gist_id}","starred_url":"https://api.github.com/users/domcleal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domcleal/subscriptions","organizations_url":"https://api.github.com/users/domcleal/orgs","repos_url":"https://api.github.com/users/domcleal/repos","events_url":"https://api.github.com/users/domcleal/events{/privacy}","received_events_url":"https://api.github.com/users/domcleal/received_events","type":"User","site_admin":false},"body":"This is the right line.  Try this:\r\n\r\n<pre>\r\n[dcleal@cobalt ~]$ if /usr/sbin/selinuxenabled; then\r\n> [ 2 -eq 1 ] && echo foreman-selinux-enable\r\n> fi\r\n[dcleal@cobalt ~]$ echo $?\r\n1\r\n</pre>\r\n\r\nFrom my earlier upgrade on a VM:\r\n\r\n<pre>\r\n[root@foreman ~]# rpm -Uvh \"http://koji.katello.org/koji/getfile?taskID=139388&name=foreman-selinux-1.7.0-0.develop.el6.noarch.rpm\" --force\r\nRetrieving http://koji.katello.org/koji/getfile?taskID=139388&name=foreman-selinux-1.7.0-0.develop.el6.noarch.rpm\r\nPreparing...                ########################################### [100%]\r\n   1:foreman-selinux        ########################################### [100%]\r\nwarning: %post(foreman-selinux-1.7.0-0.develop.el6.noarch) scriptlet failed, exit status 1\r\n</pre>","created_at":"2014-08-12T14:23:46Z","updated_at":"2014-08-12T14:23:46Z","html_url":"https://github.com/theforeman/foreman-packaging/pull/305#discussion_r16115577","pull_request_url":"https://api.github.com/repos/theforeman/foreman-packaging/pulls/305","_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman-packaging/pulls/comments/16115577"},"html":{"href":"https://github.com/theforeman/foreman-packaging/pull/305#discussion_r16115577"},"pull_request":{"href":"https://api.github.com/repos/theforeman/foreman-packaging/pulls/305"}}},"pull_request":{"url":"https://api.github.com/repos/theforeman/foreman-packaging/pulls/305","id":19459976,"html_url":"https://github.com/theforeman/foreman-packaging/pull/305","diff_url":"https://github.com/theforeman/foreman-packaging/pull/305.diff","patch_url":"https://github.com/theforeman/foreman-packaging/pull/305.patch","issue_url":"https://api.github.com/repos/theforeman/foreman-packaging/issues/305","number":305,"state":"open","title":"Refs #6979 - Fail when policy cant be (un)loaded","user":{"login":"lzap","id":49752,"avatar_url":"https://avatars.githubusercontent.com/u/49752?v=2","gravatar_id":"b6acf830dd3925cb0033b7d86c95f5da","url":"https://api.github.com/users/lzap","html_url":"https://github.com/lzap","followers_url":"https://api.github.com/users/lzap/followers","following_url":"https://api.github.com/users/lzap/following{/other_user}","gists_url":"https://api.github.com/users/lzap/gists{/gist_id}","starred_url":"https://api.github.com/users/lzap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lzap/subscriptions","organizations_url":"https://api.github.com/users/lzap/orgs","repos_url":"https://api.github.com/users/lzap/repos","events_url":"https://api.github.com/users/lzap/events{/privacy}","received_events_url":"https://api.github.com/users/lzap/received_events","type":"User","site_admin":false},"body":null,"created_at":"2014-08-07T11:03:49Z","updated_at":"2014-08-12T14:23:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1bcf19eea08a553bc62044d3562d5f5bbf696662","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/theforeman/foreman-packaging/pulls/305/commits","review_comments_url":"https://api.github.com/repos/theforeman/foreman-packaging/pulls/305/comments","review_comment_url":"https://api.github.com/repos/theforeman/foreman-packaging/pulls/comments/{number}","comments_url":"https://api.github.com/repos/theforeman/foreman-packaging/issues/305/comments","statuses_url":"https://api.github.com/repos/theforeman/foreman-packaging/statuses/af7dbb6b1f58375e34fcc713c0717c442d25ffe2","head":{"label":"lzap:silent-enable-6979","ref":"silent-enable-6979","sha":"af7dbb6b1f58375e34fcc713c0717c442d25ffe2","user":{"login":"lzap","id":49752,"avatar_url":"https://avatars.githubusercontent.com/u/49752?v=2","gravatar_id":"b6acf830dd3925cb0033b7d86c95f5da","url":"https://api.github.com/users/lzap","html_url":"https://github.com/lzap","followers_url":"https://api.github.com/users/lzap/followers","following_url":"https://api.github.com/users/lzap/following{/other_user}","gists_url":"https://api.github.com/users/lzap/gists{/gist_id}","starred_url":"https://api.github.com/users/lzap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lzap/subscriptions","organizations_url":"https://api.github.com/users/lzap/orgs","repos_url":"https://api.github.com/users/lzap/repos","events_url":"https://api.github.com/users/lzap/events{/privacy}","received_events_url":"https://api.github.com/users/lzap/received_events","type":"User","site_admin":false},"repo":{"id":11169516,"name":"foreman-packaging","full_name":"lzap/foreman-packaging","owner":{"login":"lzap","id":49752,"avatar_url":"https://avatars.githubusercontent.com/u/49752?v=2","gravatar_id":"b6acf830dd3925cb0033b7d86c95f5da","url":"https://api.github.com/users/lzap","html_url":"https://github.com/lzap","followers_url":"https://api.github.com/users/lzap/followers","following_url":"https://api.github.com/users/lzap/following{/other_user}","gists_url":"https://api.github.com/users/lzap/gists{/gist_id}","starred_url":"https://api.github.com/users/lzap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lzap/subscriptions","organizations_url":"https://api.github.com/users/lzap/orgs","repos_url":"https://api.github.com/users/lzap/repos","events_url":"https://api.github.com/users/lzap/events{/privacy}","received_events_url":"https://api.github.com/users/lzap/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lzap/foreman-packaging","description":"Packaging files (RPMs, debs) for Foreman and its dependencies","fork":true,"url":"https://api.github.com/repos/lzap/foreman-packaging","forks_url":"https://api.github.com/repos/lzap/foreman-packaging/forks","keys_url":"https://api.github.com/repos/lzap/foreman-packaging/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lzap/foreman-packaging/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lzap/foreman-packaging/teams","hooks_url":"https://api.github.com/repos/lzap/foreman-packaging/hooks","issue_events_url":"https://api.github.com/repos/lzap/foreman-packaging/issues/events{/number}","events_url":"https://api.github.com/repos/lzap/foreman-packaging/events","assignees_url":"https://api.github.com/repos/lzap/foreman-packaging/assignees{/user}","branches_url":"https://api.github.com/repos/lzap/foreman-packaging/branches{/branch}","tags_url":"https://api.github.com/repos/lzap/foreman-packaging/tags","blobs_url":"https://api.github.com/repos/lzap/foreman-packaging/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lzap/foreman-packaging/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lzap/foreman-packaging/git/refs{/sha}","trees_url":"https://api.github.com/repos/lzap/foreman-packaging/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lzap/foreman-packaging/statuses/{sha}","languages_url":"https://api.github.com/repos/lzap/foreman-packaging/languages","stargazers_url":"https://api.github.com/repos/lzap/foreman-packaging/stargazers","contributors_url":"https://api.github.com/repos/lzap/foreman-packaging/contributors","subscribers_url":"https://api.github.com/repos/lzap/foreman-packaging/subscribers","subscription_url":"https://api.github.com/repos/lzap/foreman-packaging/subscription","commits_url":"https://api.github.com/repos/lzap/foreman-packaging/commits{/sha}","git_commits_url":"https://api.github.com/repos/lzap/foreman-packaging/git/commits{/sha}","comments_url":"https://api.github.com/repos/lzap/foreman-packaging/comments{/number}","issue_comment_url":"https://api.github.com/repos/lzap/foreman-packaging/issues/comments/{number}","contents_url":"https://api.github.com/repos/lzap/foreman-packaging/contents/{+path}","compare_url":"https://api.github.com/repos/lzap/foreman-packaging/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lzap/foreman-packaging/merges","archive_url":"https://api.github.com/repos/lzap/foreman-packaging/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lzap/foreman-packaging/downloads","issues_url":"https://api.github.com/repos/lzap/foreman-packaging/issues{/number}","pulls_url":"https://api.github.com/repos/lzap/foreman-packaging/pulls{/number}","milestones_url":"https://api.github.com/repos/lzap/foreman-packaging/milestones{/number}","notifications_url":"https://api.github.com/repos/lzap/foreman-packaging/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lzap/foreman-packaging/labels{/name}","releases_url":"https://api.github.com/repos/lzap/foreman-packaging/releases{/id}","created_at":"2013-07-04T07:19:28Z","updated_at":"2014-06-09T06:59:48Z","pushed_at":"2014-08-12T09:07:40Z","git_url":"git://github.com/lzap/foreman-packaging.git","ssh_url":"git@github.com:lzap/foreman-packaging.git","clone_url":"https://github.com/lzap/foreman-packaging.git","svn_url":"https://github.com/lzap/foreman-packaging","homepage":"","size":8589,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"theforeman:rpm/develop","ref":"rpm/develop","sha":"e6a547fb0b2a15f4bab7271f4280711ea678d204","user":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=2","gravatar_id":"debaffa7d317b9ec76a588682fb1e640","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":4663237,"name":"foreman-packaging","full_name":"theforeman/foreman-packaging","owner":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=2","gravatar_id":"debaffa7d317b9ec76a588682fb1e640","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theforeman/foreman-packaging","description":"Packaging files (RPMs, debs) for Foreman and its dependencies","fork":false,"url":"https://api.github.com/repos/theforeman/foreman-packaging","forks_url":"https://api.github.com/repos/theforeman/foreman-packaging/forks","keys_url":"https://api.github.com/repos/theforeman/foreman-packaging/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/foreman-packaging/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/foreman-packaging/teams","hooks_url":"https://api.github.com/repos/theforeman/foreman-packaging/hooks","issue_events_url":"https://api.github.com/repos/theforeman/foreman-packaging/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/foreman-packaging/events","assignees_url":"https://api.github.com/repos/theforeman/foreman-packaging/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/foreman-packaging/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/foreman-packaging/tags","blobs_url":"https://api.github.com/repos/theforeman/foreman-packaging/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/foreman-packaging/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/foreman-packaging/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/foreman-packaging/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/foreman-packaging/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/foreman-packaging/languages","stargazers_url":"https://api.github.com/repos/theforeman/foreman-packaging/stargazers","contributors_url":"https://api.github.com/repos/theforeman/foreman-packaging/contributors","subscribers_url":"https://api.github.com/repos/theforeman/foreman-packaging/subscribers","subscription_url":"https://api.github.com/repos/theforeman/foreman-packaging/subscription","commits_url":"https://api.github.com/repos/theforeman/foreman-packaging/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/foreman-packaging/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/foreman-packaging/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/foreman-packaging/issues/comments/{number}","contents_url":"https://api.github.com/repos/theforeman/foreman-packaging/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/foreman-packaging/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/foreman-packaging/merges","archive_url":"https://api.github.com/repos/theforeman/foreman-packaging/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/foreman-packaging/downloads","issues_url":"https://api.github.com/repos/theforeman/foreman-packaging/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/foreman-packaging/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/foreman-packaging/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/foreman-packaging/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/foreman-packaging/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/foreman-packaging/releases{/id}","created_at":"2012-06-14T13:01:07Z","updated_at":"2014-07-30T23:26:56Z","pushed_at":"2014-08-12T14:12:29Z","git_url":"git://github.com/theforeman/foreman-packaging.git","ssh_url":"git@github.com:theforeman/foreman-packaging.git","clone_url":"https://github.com/theforeman/foreman-packaging.git","svn_url":"https://github.com/theforeman/foreman-packaging","homepage":"","size":15494,"stargazers_count":15,"watchers_count":15,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":24,"mirror_url":null,"open_issues_count":12,"forks":24,"open_issues":12,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman-packaging/pulls/305"},"html":{"href":"https://github.com/theforeman/foreman-packaging/pull/305"},"issue":{"href":"https://api.github.com/repos/theforeman/foreman-packaging/issues/305"},"comments":{"href":"https://api.github.com/repos/theforeman/foreman-packaging/issues/305/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/foreman-packaging/pulls/305/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/foreman-packaging/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/theforeman/foreman-packaging/pulls/305/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/foreman-packaging/statuses/af7dbb6b1f58375e34fcc713c0717c442d25ffe2"}}}}