GitHub PullRequestReviewCommentEvent at 2014-05-12 15:24:11
Repository: Firmware
Actor: ultrasystem
Payload: {"comment":{"url":"https://api.github.com/repos/PX4/Firmware/pulls/comments/12534940","id":12534940,"diff_hunk":"@@ -140,7 +140,7 @@ int rc_calibration_check(int mavlink_fd) {\n \t\t/* sanity checks pass, enable channel */\n \t\tif (count) {\n \t\t\tmavlink_log_critical(mavlink_fd, \"ERROR: %d config error(s) for RC channel %d.\", count, (i + 1));\n-\t\t\twarnx(mavlink_fd, \"ERROR: %d config error(s) for RC channel %d.\", count, (i + 1));\n+\t\t\twarnc(mavlink_fd, \"ERROR: %d config error(s) for RC channel %d.\", count, (i + 1));","path":"src/modules/systemlib/rc_check.c","position":null,"original_position":5,"commit_id":"ad51b4c24b624c32e31e4b3aad274d59e79f1b20","original_commit_id":"db2b85cbd42c17ef581e62c8b2363b6fc37e9617","user":{"login":"ultrasystem","id":1740915,"avatar_url":"https://avatars.githubusercontent.com/u/1740915?","gravatar_id":"42e634e024d869a57a5ff22cad5f003a","url":"https://api.github.com/users/ultrasystem","html_url":"https://github.com/ultrasystem","followers_url":"https://api.github.com/users/ultrasystem/followers","following_url":"https://api.github.com/users/ultrasystem/following{/other_user}","gists_url":"https://api.github.com/users/ultrasystem/gists{/gist_id}","starred_url":"https://api.github.com/users/ultrasystem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ultrasystem/subscriptions","organizations_url":"https://api.github.com/users/ultrasystem/orgs","repos_url":"https://api.github.com/users/ultrasystem/repos","events_url":"https://api.github.com/users/ultrasystem/events{/privacy}","received_events_url":"https://api.github.com/users/ultrasystem/received_events","type":"User","site_admin":false},"body":"OK， Thx ,  I updated this request. \r\nBtw, How to replace the CMSIS library in ARMv7-A system? Any DSP / Math library recommend? \r\nBecause I port PX4 firmware to samsung Exynos 4412 processor and running linux 3.x kernel now.\r\n\r\n\r\n\r\n\r\n\r\n\r\n------------------ 原始邮件 ------------------\r\n发件人: \"Lorenz Meier\";<notifications@github.com>;\r\n发送时间: 2014年5月12日(星期一) 晚上10:48\r\n收件人: \"PX4/Firmware\"<Firmware@noreply.github.com>; \r\n抄送: \"Assume\"<liio@qq.com>; \r\n主题: Re: [Firmware] Output a debug string is Invalid @ parameter #1 (#926)\r\n\r\n\r\n\r\n\r\nIn src/modules/systemlib/rc_check.c:\r\n > @@ -140,7 +140,7 @@ int rc_calibration_check(int mavlink_fd) { >  \t\t/* sanity checks pass, enable channel */ >  \t\tif (count) { >  \t\t\tmavlink_log_critical(mavlink_fd, \"ERROR: %d config error(s) for RC channel %d.\", count, (i + 1)); > -\t\t\twarnx(mavlink_fd, \"ERROR: %d config error(s) for RC channel %d.\", count, (i + 1)); > +\t\t\twarnc(mavlink_fd, \"ERROR: %d config error(s) for RC channel %d.\", count, (i + 1));  \r\nJust do a new commit implementing the change and push to your branch (patch-2). The pull request will automatically update, and this diff will update, too.\r\n \r\n—\r\nReply to this email directly or view it on GitHub.","created_at":"2014-05-12T15:24:11Z","updated_at":"2014-05-12T15:24:11Z","html_url":"https://github.com/PX4/Firmware/pull/926#discussion_r12534940","pull_request_url":"https://api.github.com/repos/PX4/Firmware/pulls/926","_links":{"self":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/comments/12534940"},"html":{"href":"https://github.com/PX4/Firmware/pull/926#discussion_r12534940"},"pull_request":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/926"}}}}