GitHub PullRequestReviewCommentEvent at 2014-11-04 09:41:19
Repository: nixpkgs
Actor: 7c6f434c
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/19792705","id":19792705,"diff_hunk":"@@ -3,7 +3,7 @@\n @@ -1,6 +1,6 @@\n  \n  # Where binaries are installed:\n--BINDIR := /usr/local/bin\n+-BINDIR := `dirname  \\`which ocamlc\\``","path":"pkgs/development/tools/ocaml/js_of_ocaml/Makefile.conf.diff","position":5,"original_position":5,"commit_id":"10eb4786fd6896d8b674730b45dc333931c7237f","original_commit_id":"10eb4786fd6896d8b674730b45dc333931c7237f","user":{"login":"7c6f434c","id":1891350,"avatar_url":"https://avatars.githubusercontent.com/u/1891350?v=2","gravatar_id":"","url":"https://api.github.com/users/7c6f434c","html_url":"https://github.com/7c6f434c","followers_url":"https://api.github.com/users/7c6f434c/followers","following_url":"https://api.github.com/users/7c6f434c/following{/other_user}","gists_url":"https://api.github.com/users/7c6f434c/gists{/gist_id}","starred_url":"https://api.github.com/users/7c6f434c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/7c6f434c/subscriptions","organizations_url":"https://api.github.com/users/7c6f434c/orgs","repos_url":"https://api.github.com/users/7c6f434c/repos","events_url":"https://api.github.com/users/7c6f434c/events{/privacy}","received_events_url":"https://api.github.com/users/7c6f434c/received_events","type":"User","site_admin":false},"body":"I would use ```\"$(dirname \"$(which ocamlc)\")\"``` because nesting backticks are harder to read","created_at":"2014-11-04T09:41:19Z","updated_at":"2014-11-04T09:41:19Z","html_url":"https://github.com/NixOS/nixpkgs/pull/4517#discussion_r19792705","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/4517","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/19792705"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/4517#discussion_r19792705"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/4517"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/4517","id":22704050,"html_url":"https://github.com/NixOS/nixpkgs/pull/4517","diff_url":"https://github.com/NixOS/nixpkgs/pull/4517.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/4517.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/4517","number":4517,"state":"open","locked":false,"title":"ocsigen 2014-10","user":{"login":"FlorentBecker","id":7047019,"avatar_url":"https://avatars.githubusercontent.com/u/7047019?v=2","gravatar_id":"","url":"https://api.github.com/users/FlorentBecker","html_url":"https://github.com/FlorentBecker","followers_url":"https://api.github.com/users/FlorentBecker/followers","following_url":"https://api.github.com/users/FlorentBecker/following{/other_user}","gists_url":"https://api.github.com/users/FlorentBecker/gists{/gist_id}","starred_url":"https://api.github.com/users/FlorentBecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FlorentBecker/subscriptions","organizations_url":"https://api.github.com/users/FlorentBecker/orgs","repos_url":"https://api.github.com/users/FlorentBecker/repos","events_url":"https://api.github.com/users/FlorentBecker/events{/privacy}","received_events_url":"https://api.github.com/users/FlorentBecker/received_events","type":"User","site_admin":false},"body":"Update the components of the ocsigen framework to their 2014 - 10 releaset.","created_at":"2014-10-14T11:21:02Z","updated_at":"2014-11-04T09:41:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a973a87bfa32415195a3c54ee30f9b552fe07939","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/4517/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/4517/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/{number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/4517/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/10eb4786fd6896d8b674730b45dc333931c7237f","head":{"label":"FlorentBecker:eliom","ref":"eliom","sha":"10eb4786fd6896d8b674730b45dc333931c7237f","user":{"login":"FlorentBecker","id":7047019,"avatar_url":"https://avatars.githubusercontent.com/u/7047019?v=2","gravatar_id":"","url":"https://api.github.com/users/FlorentBecker","html_url":"https://github.com/FlorentBecker","followers_url":"https://api.github.com/users/FlorentBecker/followers","following_url":"https://api.github.com/users/FlorentBecker/following{/other_user}","gists_url":"https://api.github.com/users/FlorentBecker/gists{/gist_id}","starred_url":"https://api.github.com/users/FlorentBecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FlorentBecker/subscriptions","organizations_url":"https://api.github.com/users/FlorentBecker/orgs","repos_url":"https://api.github.com/users/FlorentBecker/repos","events_url":"https://api.github.com/users/FlorentBecker/events{/privacy}","received_events_url":"https://api.github.com/users/FlorentBecker/received_events","type":"User","site_admin":false},"repo":{"id":20796483,"name":"nixpkgs","full_name":"FlorentBecker/nixpkgs","owner":{"login":"FlorentBecker","id":7047019,"avatar_url":"https://avatars.githubusercontent.com/u/7047019?v=2","gravatar_id":"","url":"https://api.github.com/users/FlorentBecker","html_url":"https://github.com/FlorentBecker","followers_url":"https://api.github.com/users/FlorentBecker/followers","following_url":"https://api.github.com/users/FlorentBecker/following{/other_user}","gists_url":"https://api.github.com/users/FlorentBecker/gists{/gist_id}","starred_url":"https://api.github.com/users/FlorentBecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FlorentBecker/subscriptions","organizations_url":"https://api.github.com/users/FlorentBecker/orgs","repos_url":"https://api.github.com/users/FlorentBecker/repos","events_url":"https://api.github.com/users/FlorentBecker/events{/privacy}","received_events_url":"https://api.github.com/users/FlorentBecker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/FlorentBecker/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/FlorentBecker/nixpkgs","forks_url":"https://api.github.com/repos/FlorentBecker/nixpkgs/forks","keys_url":"https://api.github.com/repos/FlorentBecker/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FlorentBecker/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FlorentBecker/nixpkgs/teams","hooks_url":"https://api.github.com/repos/FlorentBecker/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/FlorentBecker/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/FlorentBecker/nixpkgs/events","assignees_url":"https://api.github.com/repos/FlorentBecker/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/FlorentBecker/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/FlorentBecker/nixpkgs/tags","blobs_url":"https://api.github.com/repos/FlorentBecker/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FlorentBecker/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FlorentBecker/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/FlorentBecker/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FlorentBecker/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/FlorentBecker/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/FlorentBecker/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/FlorentBecker/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/FlorentBecker/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/FlorentBecker/nixpkgs/subscription","commits_url":"https://api.github.com/repos/FlorentBecker/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/FlorentBecker/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/FlorentBecker/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/FlorentBecker/nixpkgs/issues/comments/{number}","contents_url":"https://api.github.com/repos/FlorentBecker/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/FlorentBecker/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FlorentBecker/nixpkgs/merges","archive_url":"https://api.github.com/repos/FlorentBecker/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FlorentBecker/nixpkgs/downloads","issues_url":"https://api.github.com/repos/FlorentBecker/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/FlorentBecker/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/FlorentBecker/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/FlorentBecker/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FlorentBecker/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/FlorentBecker/nixpkgs/releases{/id}","created_at":"2014-06-13T07:52:25Z","updated_at":"2014-07-17T12:21:07Z","pushed_at":"2014-10-19T16:49:22Z","git_url":"git://github.com/FlorentBecker/nixpkgs.git","ssh_url":"git@github.com:FlorentBecker/nixpkgs.git","clone_url":"https://github.com/FlorentBecker/nixpkgs.git","svn_url":"https://github.com/FlorentBecker/nixpkgs","homepage":null,"size":149068,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"1b68c7b1345b7e41114dfac369a6283a697add59","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=2","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=2","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments/{number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","created_at":"2012-06-04T02:49:46Z","updated_at":"2014-11-03T21:20:53Z","pushed_at":"2014-11-04T09:39:09Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":283275,"stargazers_count":404,"watchers_count":404,"language":"Nix","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":493,"mirror_url":null,"open_issues_count":413,"forks":493,"open_issues":413,"watchers":404,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/4517"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/4517"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/4517"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/4517/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/4517/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/4517/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/10eb4786fd6896d8b674730b45dc333931c7237f"}}}}