GitHub PullRequestReviewCommentEvent at 2014-03-20 22:50:07
Repository: bokeh
Actor: damianavila
Payload: {"comment":{"url":"https://api.github.com/repos/ContinuumIO/bokeh/pulls/comments/10820745","id":10820745,"diff_hunk":"@@ -79,57 +79,69 @@ define [\n \n     return glyphs\n \n-  add_axes = (plot, xaxes, yaxes, xdr, ydr) ->\n-    axes = []\n-    if xaxes\n-      if xaxes == true\n-        xaxes = ['min', 'max']\n-      if not _.isArray(xaxes)\n-        xaxes = [xaxes]\n-      if xaxes[0]==\"datetime\"\n-\n-        for loc in ['min','max']\n-          axis = DatetimeAxis.Collection.create(\n-            dimension: 0\n-            axis_label: 'x'\n-            location: loc\n-            parent: plot.ref()\n-            plot: plot.ref())\n-          axes.push(axis)\n+  add_axes = (plot, xaxes_spec, yaxes_spec, xdr, ydr) ->\n+    xaxes = []\n+    if xaxes_spec\n+      if xaxes_spec == true","path":"bokehjs/src/coffee/common/plotting.coffee","position":24,"original_position":24,"commit_id":"f48040ae0b14bbc638b7840724506b9b296ab7ce","original_commit_id":"f48040ae0b14bbc638b7840724506b9b296ab7ce","user":{"login":"damianavila","id":1640669,"avatar_url":"https://avatars.githubusercontent.com/u/1640669?","gravatar_id":"4e38c658571b67282fda714dfea98843","url":"https://api.github.com/users/damianavila","html_url":"https://github.com/damianavila","followers_url":"https://api.github.com/users/damianavila/followers","following_url":"https://api.github.com/users/damianavila/following{/other_user}","gists_url":"https://api.github.com/users/damianavila/gists{/gist_id}","starred_url":"https://api.github.com/users/damianavila/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damianavila/subscriptions","organizations_url":"https://api.github.com/users/damianavila/orgs","repos_url":"https://api.github.com/users/damianavila/repos","events_url":"https://api.github.com/users/damianavila/events{/privacy}","received_events_url":"https://api.github.com/users/damianavila/received_events","type":"User","site_admin":false},"body":"I don't get why you are checking `if xaxes_spec == true` here?","created_at":"2014-03-20T22:50:07Z","updated_at":"2014-03-20T22:50:07Z","html_url":"https://github.com/ContinuumIO/bokeh/pull/441#discussion_r10820745","pull_request_url":"https://api.github.com/repos/ContinuumIO/bokeh/pulls/441","_links":{"self":{"href":"https://api.github.com/repos/ContinuumIO/bokeh/pulls/comments/10820745"},"html":{"href":"https://github.com/ContinuumIO/bokeh/pull/441#discussion_r10820745"},"pull_request":{"href":"https://api.github.com/repos/ContinuumIO/bokeh/pulls/441"}}}}