GitHub PullRequestReviewCommentEvent at 2014-09-23 01:31:18
Repository: rust
Actor: thestinger
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/17888720","id":17888720,"diff_hunk":"@@ -2,10 +2,6 @@\n \tpath = src/llvm\n \turl = https://github.com/rust-lang/llvm.git\n \tbranch = master\n-[submodule \"src/libuv\"]\n-\tpath = src/libuv\n-\turl = https://github.com/rust-lang/libuv.git\n-\tbranch = master\n [submodule \"src/gyp\"]","path":".gitmodules","position":8,"original_position":8,"commit_id":"7053bd4a341639013219ce796b878c20317ee944","original_commit_id":"7053bd4a341639013219ce796b878c20317ee944","user":{"login":"thestinger","id":1505226,"avatar_url":"https://avatars.githubusercontent.com/u/1505226?v=2","gravatar_id":"","url":"https://api.github.com/users/thestinger","html_url":"https://github.com/thestinger","followers_url":"https://api.github.com/users/thestinger/followers","following_url":"https://api.github.com/users/thestinger/following{/other_user}","gists_url":"https://api.github.com/users/thestinger/gists{/gist_id}","starred_url":"https://api.github.com/users/thestinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thestinger/subscriptions","organizations_url":"https://api.github.com/users/thestinger/orgs","repos_url":"https://api.github.com/users/thestinger/repos","events_url":"https://api.github.com/users/thestinger/events{/privacy}","received_events_url":"https://api.github.com/users/thestinger/received_events","type":"User","site_admin":false},"body":"The gyp dependency is only used to build libuv so it can also be removed too.","created_at":"2014-09-23T01:31:18Z","updated_at":"2014-09-23T01:31:18Z","html_url":"https://github.com/rust-lang/rust/pull/17465#discussion_r17888720","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/17465","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/17888720"},"html":{"href":"https://github.com/rust-lang/rust/pull/17465#discussion_r17888720"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/17465"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/17465","id":21620624,"html_url":"https://github.com/rust-lang/rust/pull/17465","diff_url":"https://github.com/rust-lang/rust/pull/17465.diff","patch_url":"https://github.com/rust-lang/rust/pull/17465.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/17465","number":17465,"state":"open","locked":false,"title":"Begin removing libgreen","user":{"login":"anchovieshat","id":6327402,"avatar_url":"https://avatars.githubusercontent.com/u/6327402?v=2","gravatar_id":"","url":"https://api.github.com/users/anchovieshat","html_url":"https://github.com/anchovieshat","followers_url":"https://api.github.com/users/anchovieshat/followers","following_url":"https://api.github.com/users/anchovieshat/following{/other_user}","gists_url":"https://api.github.com/users/anchovieshat/gists{/gist_id}","starred_url":"https://api.github.com/users/anchovieshat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anchovieshat/subscriptions","organizations_url":"https://api.github.com/users/anchovieshat/orgs","repos_url":"https://api.github.com/users/anchovieshat/repos","events_url":"https://api.github.com/users/anchovieshat/events{/privacy}","received_events_url":"https://api.github.com/users/anchovieshat/received_events","type":"User","site_admin":false},"body":"This removes the building and usage of libgreen; though this may not be (and probably isn't) the best way to go about this at the moment.","created_at":"2014-09-23T01:20:56Z","updated_at":"2014-09-23T01:31:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d0b32518b22fcc6447564bf270dd7600bdcb2495","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/17465/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/17465/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/17465/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/7053bd4a341639013219ce796b878c20317ee944","head":{"label":"anchovieshat:ginacc","ref":"ginacc","sha":"7053bd4a341639013219ce796b878c20317ee944","user":{"login":"anchovieshat","id":6327402,"avatar_url":"https://avatars.githubusercontent.com/u/6327402?v=2","gravatar_id":"","url":"https://api.github.com/users/anchovieshat","html_url":"https://github.com/anchovieshat","followers_url":"https://api.github.com/users/anchovieshat/followers","following_url":"https://api.github.com/users/anchovieshat/following{/other_user}","gists_url":"https://api.github.com/users/anchovieshat/gists{/gist_id}","starred_url":"https://api.github.com/users/anchovieshat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anchovieshat/subscriptions","organizations_url":"https://api.github.com/users/anchovieshat/orgs","repos_url":"https://api.github.com/users/anchovieshat/repos","events_url":"https://api.github.com/users/anchovieshat/events{/privacy}","received_events_url":"https://api.github.com/users/anchovieshat/received_events","type":"User","site_admin":false},"repo":{"id":24281319,"name":"rust","full_name":"anchovieshat/rust","owner":{"login":"anchovieshat","id":6327402,"avatar_url":"https://avatars.githubusercontent.com/u/6327402?v=2","gravatar_id":"","url":"https://api.github.com/users/anchovieshat","html_url":"https://github.com/anchovieshat","followers_url":"https://api.github.com/users/anchovieshat/followers","following_url":"https://api.github.com/users/anchovieshat/following{/other_user}","gists_url":"https://api.github.com/users/anchovieshat/gists{/gist_id}","starred_url":"https://api.github.com/users/anchovieshat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anchovieshat/subscriptions","organizations_url":"https://api.github.com/users/anchovieshat/orgs","repos_url":"https://api.github.com/users/anchovieshat/repos","events_url":"https://api.github.com/users/anchovieshat/events{/privacy}","received_events_url":"https://api.github.com/users/anchovieshat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/anchovieshat/rust","description":"a safe, concurrent, practical language","fork":true,"url":"https://api.github.com/repos/anchovieshat/rust","forks_url":"https://api.github.com/repos/anchovieshat/rust/forks","keys_url":"https://api.github.com/repos/anchovieshat/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anchovieshat/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anchovieshat/rust/teams","hooks_url":"https://api.github.com/repos/anchovieshat/rust/hooks","issue_events_url":"https://api.github.com/repos/anchovieshat/rust/issues/events{/number}","events_url":"https://api.github.com/repos/anchovieshat/rust/events","assignees_url":"https://api.github.com/repos/anchovieshat/rust/assignees{/user}","branches_url":"https://api.github.com/repos/anchovieshat/rust/branches{/branch}","tags_url":"https://api.github.com/repos/anchovieshat/rust/tags","blobs_url":"https://api.github.com/repos/anchovieshat/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anchovieshat/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anchovieshat/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/anchovieshat/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anchovieshat/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/anchovieshat/rust/languages","stargazers_url":"https://api.github.com/repos/anchovieshat/rust/stargazers","contributors_url":"https://api.github.com/repos/anchovieshat/rust/contributors","subscribers_url":"https://api.github.com/repos/anchovieshat/rust/subscribers","subscription_url":"https://api.github.com/repos/anchovieshat/rust/subscription","commits_url":"https://api.github.com/repos/anchovieshat/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/anchovieshat/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/anchovieshat/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/anchovieshat/rust/issues/comments/{number}","contents_url":"https://api.github.com/repos/anchovieshat/rust/contents/{+path}","compare_url":"https://api.github.com/repos/anchovieshat/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anchovieshat/rust/merges","archive_url":"https://api.github.com/repos/anchovieshat/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anchovieshat/rust/downloads","issues_url":"https://api.github.com/repos/anchovieshat/rust/issues{/number}","pulls_url":"https://api.github.com/repos/anchovieshat/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/anchovieshat/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/anchovieshat/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anchovieshat/rust/labels{/name}","releases_url":"https://api.github.com/repos/anchovieshat/rust/releases{/id}","created_at":"2014-09-21T03:46:31Z","updated_at":"2014-09-21T03:06:40Z","pushed_at":"2014-09-23T01:19:23Z","git_url":"git://github.com/anchovieshat/rust.git","ssh_url":"git@github.com:anchovieshat/rust.git","clone_url":"https://github.com/anchovieshat/rust.git","svn_url":"https://github.com/anchovieshat/rust","homepage":"http://www.rust-lang.org","size":161830,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"4b5f4563bff67e2727befdb235314726849331a7","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=2","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=2","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"a safe, concurrent, practical language","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments/{number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","created_at":"2010-06-16T20:39:03Z","updated_at":"2014-09-23T00:37:44Z","pushed_at":"2014-09-23T01:30:33Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"http://www.rust-lang.org","size":469416,"stargazers_count":6493,"watchers_count":6493,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1294,"mirror_url":null,"open_issues_count":1937,"forks":1294,"open_issues":1937,"watchers":6493,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/17465"},"html":{"href":"https://github.com/rust-lang/rust/pull/17465"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/17465"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/17465/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/17465/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/17465/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/7053bd4a341639013219ce796b878c20317ee944"}}}}