GitHub PushEvent at 2014-10-02 18:27:57
Repository: pulp
Actor: bmbouter
Payload: {"shas":[["8ca256f4c10de6dfa620f29072e727c415f6efd7","03e21a0d39faa13c55059cac4154dae3101e7499@redhat.com","1139703 - update pickled schedule on schedule updates\n\nPreviously, the pickled CelerySchedule was being set on create but not update.\n\nThis patch checks to see if `iso_schedule` is being updated, and pickles an\nupdated CelerySchedule object to match the new `iso_schedule`.","Chris Duryee",true],["7612db54715ea4b5ede5e6ab2ccdd8ed25639f3f","03e21a0d39faa13c55059cac4154dae3101e7499@redhat.com","1142304 - remove extraneous errors during unit test runs\n\nA few areas of the Pulp code used  `__del__` to ensure some cleanup tasks were\ncompleted. However, `__del__` can be called during garbage collection [while\ncPython is doing cleanup][del], which results in error messages being\nprinted to stderr. These messages are ultimately harmless since they occur\nduring instance teardown. However, we can remove these calls to `__del__` and\nrely on other mechanisms instead.\n\nIn the *UnitWriter* class, the `__exit__` method will always invoked since the\nclass is only called by a `with` statement. This is performing the same cleanup\nfunction as the `__del__` method.\n\nIn the *Certificate* class, we can do temp dir cleanup directly inside the\n`finally` block.\n\nThis patch removes the `__del__` methods in these classes and relies on the\naforementioned methods along with regular garbage collection to do cleanup.\nWhen I ran GC stats after making these changes, I didn't see any unaccounted\nreferences.\n\n[del]: https://docs.python.org/2/reference/datamodel.html#object.__del__","Chris Duryee",true],["fc36769c86ee5ef299ad30d0ca84cf6fa8da0dfb","03e21a0d39faa13c55059cac4154dae3101e7499@redhat.com","Merge pull request #1171 from beav/__del__\n\n1142304 - remove extraneous errors during unit test runs","Chris Duryee",true],["d254aa1878008bac8ad90a9987c8c20d4301d88c","03e21a0d39faa13c55059cac4154dae3101e7499@redhat.com","Merge pull request #1170 from beav/pickled-schedule\n\n1139703 - update pickled schedule on schedule updates","Chris Duryee",true],["a375d6c6bae26d55186a3c7fc804af94d41f6e9b","03e21a0d39faa13c55059cac4154dae3101e7499@redhat.com","add release note for pulp_docker","Chris Duryee",true],["e3ad4889140b5dca2ff22afc0bb1426c4400038b","03e21a0d39faa13c55059cac4154dae3101e7499@redhat.com","Merge pull request #1181 from beav/docker_relnote\n\nadd release note for pulp_docker","Chris Duryee",true],["b6543e7e1b59f5e3c3d3baa3b346af07676f223a","03e21a0d39faa13c55059cac4154dae3101e7499@redhat.com","Merge remote-tracking branch 'origin/2.5-testing' into 2.5-dev","Chris Duryee",true]],"size":7,"ref":"refs/heads/2.5-dev","head":"b6543e7e1b59f5e3c3d3baa3b346af07676f223a"}