GitHub PullRequestReviewCommentEvent at 2014-10-15 12:32:47
Repository: bla
Actor: dodev
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/baby-loris/bla/pulls/comments/18890126","id":18890126,"diff_hunk":"@@ -88,16 +88,34 @@\n         };\n \n         /**\n+         * Checks if the passed argument is an Array. This util function uses Array.isArray if present, if not\n+         * checks if the length property exists and if the Object was created using the Array.prototype.constructor.\n+         *\n+         * @param {*} arg\n+         * @returns {Boolean}\n+         */\n+        function isArray(arg) {\n+            return arg && (Array.isArray ? Array.isArray(arg) : (arg.length && arg instanceof Array));","path":"blocks/bla/bla.js","position":11,"original_position":11,"commit_id":"a02381094e1b3d323d4b610b4589c2617f0c0e85","original_commit_id":"a02381094e1b3d323d4b610b4589c2617f0c0e85","user":{"login":"dodev","id":1612196,"avatar_url":"https://avatars.githubusercontent.com/u/1612196?v=2","gravatar_id":"","url":"https://api.github.com/users/dodev","html_url":"https://github.com/dodev","followers_url":"https://api.github.com/users/dodev/followers","following_url":"https://api.github.com/users/dodev/following{/other_user}","gists_url":"https://api.github.com/users/dodev/gists{/gist_id}","starred_url":"https://api.github.com/users/dodev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dodev/subscriptions","organizations_url":"https://api.github.com/users/dodev/orgs","repos_url":"https://api.github.com/users/dodev/repos","events_url":"https://api.github.com/users/dodev/events{/privacy}","received_events_url":"https://api.github.com/users/dodev/received_events","type":"User","site_admin":false},"body":"Oh, 10x. I'll use the MDN polyfill.","created_at":"2014-10-15T12:32:47Z","updated_at":"2014-10-15T12:32:47Z","html_url":"https://github.com/baby-loris/bla/pull/52#discussion_r18890126","pull_request_url":"https://api.github.com/repos/baby-loris/bla/pulls/52","_links":{"self":{"href":"https://api.github.com/repos/baby-loris/bla/pulls/comments/18890126"},"html":{"href":"https://github.com/baby-loris/bla/pull/52#discussion_r18890126"},"pull_request":{"href":"https://api.github.com/repos/baby-loris/bla/pulls/52"}}},"pull_request":{"url":"https://api.github.com/repos/baby-loris/bla/pulls/52","id":22555455,"html_url":"https://github.com/baby-loris/bla/pull/52","diff_url":"https://github.com/baby-loris/bla/pull/52.diff","patch_url":"https://github.com/baby-loris/bla/pull/52.patch","issue_url":"https://api.github.com/repos/baby-loris/bla/issues/52","number":52,"state":"open","locked":false,"title":"Per method batch disabling","user":{"login":"dodev","id":1612196,"avatar_url":"https://avatars.githubusercontent.com/u/1612196?v=2","gravatar_id":"","url":"https://api.github.com/users/dodev","html_url":"https://github.com/dodev","followers_url":"https://api.github.com/users/dodev/followers","following_url":"https://api.github.com/users/dodev/following{/other_user}","gists_url":"https://api.github.com/users/dodev/gists{/gist_id}","starred_url":"https://api.github.com/users/dodev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dodev/subscriptions","organizations_url":"https://api.github.com/users/dodev/orgs","repos_url":"https://api.github.com/users/dodev/repos","events_url":"https://api.github.com/users/dodev/events{/privacy}","received_events_url":"https://api.github.com/users/dodev/received_events","type":"User","site_admin":false},"body":"This is only a preview. Tests and more docs are forthcoming. I just wanted to get the other maintainers opinion on this interface.\r\n\r\nThe per-method batch disabling will be configured in the frontend and it's done through the Api class constructor like so:\r\n```\r\nvar api = new Api('/api', {noBatchingForMethods: ['slow-poke']});\r\n\r\napi.exec('ordinary-method', {boringParam: 'boring value'}); // this method will be batched\r\n\r\napi.exec('slow-poke', {huh: 'uh?!'}); // this method won't be batched\r\n```","created_at":"2014-10-10T11:55:17Z","updated_at":"2014-10-15T12:32:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6a8606d6ada0249b8ab1be7882893116b6f154f9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/baby-loris/bla/pulls/52/commits","review_comments_url":"https://api.github.com/repos/baby-loris/bla/pulls/52/comments","review_comment_url":"https://api.github.com/repos/baby-loris/bla/pulls/comments/{number}","comments_url":"https://api.github.com/repos/baby-loris/bla/issues/52/comments","statuses_url":"https://api.github.com/repos/baby-loris/bla/statuses/a02381094e1b3d323d4b610b4589c2617f0c0e85","head":{"label":"baby-loris:dodev.per-method-batch-disabling","ref":"dodev.per-method-batch-disabling","sha":"a02381094e1b3d323d4b610b4589c2617f0c0e85","user":{"login":"baby-loris","id":8769889,"avatar_url":"https://avatars.githubusercontent.com/u/8769889?v=2","gravatar_id":"","url":"https://api.github.com/users/baby-loris","html_url":"https://github.com/baby-loris","followers_url":"https://api.github.com/users/baby-loris/followers","following_url":"https://api.github.com/users/baby-loris/following{/other_user}","gists_url":"https://api.github.com/users/baby-loris/gists{/gist_id}","starred_url":"https://api.github.com/users/baby-loris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baby-loris/subscriptions","organizations_url":"https://api.github.com/users/baby-loris/orgs","repos_url":"https://api.github.com/users/baby-loris/repos","events_url":"https://api.github.com/users/baby-loris/events{/privacy}","received_events_url":"https://api.github.com/users/baby-loris/received_events","type":"Organization","site_admin":false},"repo":{"id":21876007,"name":"bla","full_name":"baby-loris/bla","owner":{"login":"baby-loris","id":8769889,"avatar_url":"https://avatars.githubusercontent.com/u/8769889?v=2","gravatar_id":"","url":"https://api.github.com/users/baby-loris","html_url":"https://github.com/baby-loris","followers_url":"https://api.github.com/users/baby-loris/followers","following_url":"https://api.github.com/users/baby-loris/following{/other_user}","gists_url":"https://api.github.com/users/baby-loris/gists{/gist_id}","starred_url":"https://api.github.com/users/baby-loris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baby-loris/subscriptions","organizations_url":"https://api.github.com/users/baby-loris/orgs","repos_url":"https://api.github.com/users/baby-loris/repos","events_url":"https://api.github.com/users/baby-loris/events{/privacy}","received_events_url":"https://api.github.com/users/baby-loris/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/baby-loris/bla","description":"Easy way to create your own API methods for server and client sides","fork":false,"url":"https://api.github.com/repos/baby-loris/bla","forks_url":"https://api.github.com/repos/baby-loris/bla/forks","keys_url":"https://api.github.com/repos/baby-loris/bla/keys{/key_id}","collaborators_url":"https://api.github.com/repos/baby-loris/bla/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/baby-loris/bla/teams","hooks_url":"https://api.github.com/repos/baby-loris/bla/hooks","issue_events_url":"https://api.github.com/repos/baby-loris/bla/issues/events{/number}","events_url":"https://api.github.com/repos/baby-loris/bla/events","assignees_url":"https://api.github.com/repos/baby-loris/bla/assignees{/user}","branches_url":"https://api.github.com/repos/baby-loris/bla/branches{/branch}","tags_url":"https://api.github.com/repos/baby-loris/bla/tags","blobs_url":"https://api.github.com/repos/baby-loris/bla/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/baby-loris/bla/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/baby-loris/bla/git/refs{/sha}","trees_url":"https://api.github.com/repos/baby-loris/bla/git/trees{/sha}","statuses_url":"https://api.github.com/repos/baby-loris/bla/statuses/{sha}","languages_url":"https://api.github.com/repos/baby-loris/bla/languages","stargazers_url":"https://api.github.com/repos/baby-loris/bla/stargazers","contributors_url":"https://api.github.com/repos/baby-loris/bla/contributors","subscribers_url":"https://api.github.com/repos/baby-loris/bla/subscribers","subscription_url":"https://api.github.com/repos/baby-loris/bla/subscription","commits_url":"https://api.github.com/repos/baby-loris/bla/commits{/sha}","git_commits_url":"https://api.github.com/repos/baby-loris/bla/git/commits{/sha}","comments_url":"https://api.github.com/repos/baby-loris/bla/comments{/number}","issue_comment_url":"https://api.github.com/repos/baby-loris/bla/issues/comments/{number}","contents_url":"https://api.github.com/repos/baby-loris/bla/contents/{+path}","compare_url":"https://api.github.com/repos/baby-loris/bla/compare/{base}...{head}","merges_url":"https://api.github.com/repos/baby-loris/bla/merges","archive_url":"https://api.github.com/repos/baby-loris/bla/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/baby-loris/bla/downloads","issues_url":"https://api.github.com/repos/baby-loris/bla/issues{/number}","pulls_url":"https://api.github.com/repos/baby-loris/bla/pulls{/number}","milestones_url":"https://api.github.com/repos/baby-loris/bla/milestones{/number}","notifications_url":"https://api.github.com/repos/baby-loris/bla/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/baby-loris/bla/labels{/name}","releases_url":"https://api.github.com/repos/baby-loris/bla/releases{/id}","created_at":"2014-07-15T21:09:57Z","updated_at":"2014-10-05T16:37:36Z","pushed_at":"2014-10-14T13:14:22Z","git_url":"git://github.com/baby-loris/bla.git","ssh_url":"git@github.com:baby-loris/bla.git","clone_url":"https://github.com/baby-loris/bla.git","svn_url":"https://github.com/baby-loris/bla","homepage":null,"size":1479,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":5,"forks":2,"open_issues":5,"watchers":10,"default_branch":"master"}},"base":{"label":"baby-loris:master","ref":"master","sha":"8428f9821af74a992109cede9dbd6527e8efd0b2","user":{"login":"baby-loris","id":8769889,"avatar_url":"https://avatars.githubusercontent.com/u/8769889?v=2","gravatar_id":"","url":"https://api.github.com/users/baby-loris","html_url":"https://github.com/baby-loris","followers_url":"https://api.github.com/users/baby-loris/followers","following_url":"https://api.github.com/users/baby-loris/following{/other_user}","gists_url":"https://api.github.com/users/baby-loris/gists{/gist_id}","starred_url":"https://api.github.com/users/baby-loris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baby-loris/subscriptions","organizations_url":"https://api.github.com/users/baby-loris/orgs","repos_url":"https://api.github.com/users/baby-loris/repos","events_url":"https://api.github.com/users/baby-loris/events{/privacy}","received_events_url":"https://api.github.com/users/baby-loris/received_events","type":"Organization","site_admin":false},"repo":{"id":21876007,"name":"bla","full_name":"baby-loris/bla","owner":{"login":"baby-loris","id":8769889,"avatar_url":"https://avatars.githubusercontent.com/u/8769889?v=2","gravatar_id":"","url":"https://api.github.com/users/baby-loris","html_url":"https://github.com/baby-loris","followers_url":"https://api.github.com/users/baby-loris/followers","following_url":"https://api.github.com/users/baby-loris/following{/other_user}","gists_url":"https://api.github.com/users/baby-loris/gists{/gist_id}","starred_url":"https://api.github.com/users/baby-loris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baby-loris/subscriptions","organizations_url":"https://api.github.com/users/baby-loris/orgs","repos_url":"https://api.github.com/users/baby-loris/repos","events_url":"https://api.github.com/users/baby-loris/events{/privacy}","received_events_url":"https://api.github.com/users/baby-loris/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/baby-loris/bla","description":"Easy way to create your own API methods for server and client sides","fork":false,"url":"https://api.github.com/repos/baby-loris/bla","forks_url":"https://api.github.com/repos/baby-loris/bla/forks","keys_url":"https://api.github.com/repos/baby-loris/bla/keys{/key_id}","collaborators_url":"https://api.github.com/repos/baby-loris/bla/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/baby-loris/bla/teams","hooks_url":"https://api.github.com/repos/baby-loris/bla/hooks","issue_events_url":"https://api.github.com/repos/baby-loris/bla/issues/events{/number}","events_url":"https://api.github.com/repos/baby-loris/bla/events","assignees_url":"https://api.github.com/repos/baby-loris/bla/assignees{/user}","branches_url":"https://api.github.com/repos/baby-loris/bla/branches{/branch}","tags_url":"https://api.github.com/repos/baby-loris/bla/tags","blobs_url":"https://api.github.com/repos/baby-loris/bla/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/baby-loris/bla/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/baby-loris/bla/git/refs{/sha}","trees_url":"https://api.github.com/repos/baby-loris/bla/git/trees{/sha}","statuses_url":"https://api.github.com/repos/baby-loris/bla/statuses/{sha}","languages_url":"https://api.github.com/repos/baby-loris/bla/languages","stargazers_url":"https://api.github.com/repos/baby-loris/bla/stargazers","contributors_url":"https://api.github.com/repos/baby-loris/bla/contributors","subscribers_url":"https://api.github.com/repos/baby-loris/bla/subscribers","subscription_url":"https://api.github.com/repos/baby-loris/bla/subscription","commits_url":"https://api.github.com/repos/baby-loris/bla/commits{/sha}","git_commits_url":"https://api.github.com/repos/baby-loris/bla/git/commits{/sha}","comments_url":"https://api.github.com/repos/baby-loris/bla/comments{/number}","issue_comment_url":"https://api.github.com/repos/baby-loris/bla/issues/comments/{number}","contents_url":"https://api.github.com/repos/baby-loris/bla/contents/{+path}","compare_url":"https://api.github.com/repos/baby-loris/bla/compare/{base}...{head}","merges_url":"https://api.github.com/repos/baby-loris/bla/merges","archive_url":"https://api.github.com/repos/baby-loris/bla/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/baby-loris/bla/downloads","issues_url":"https://api.github.com/repos/baby-loris/bla/issues{/number}","pulls_url":"https://api.github.com/repos/baby-loris/bla/pulls{/number}","milestones_url":"https://api.github.com/repos/baby-loris/bla/milestones{/number}","notifications_url":"https://api.github.com/repos/baby-loris/bla/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/baby-loris/bla/labels{/name}","releases_url":"https://api.github.com/repos/baby-loris/bla/releases{/id}","created_at":"2014-07-15T21:09:57Z","updated_at":"2014-10-05T16:37:36Z","pushed_at":"2014-10-14T13:14:22Z","git_url":"git://github.com/baby-loris/bla.git","ssh_url":"git@github.com:baby-loris/bla.git","clone_url":"https://github.com/baby-loris/bla.git","svn_url":"https://github.com/baby-loris/bla","homepage":null,"size":1479,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":5,"forks":2,"open_issues":5,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/baby-loris/bla/pulls/52"},"html":{"href":"https://github.com/baby-loris/bla/pull/52"},"issue":{"href":"https://api.github.com/repos/baby-loris/bla/issues/52"},"comments":{"href":"https://api.github.com/repos/baby-loris/bla/issues/52/comments"},"review_comments":{"href":"https://api.github.com/repos/baby-loris/bla/pulls/52/comments"},"review_comment":{"href":"https://api.github.com/repos/baby-loris/bla/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/baby-loris/bla/pulls/52/commits"},"statuses":{"href":"https://api.github.com/repos/baby-loris/bla/statuses/a02381094e1b3d323d4b610b4589c2617f0c0e85"}}}}