GitHub PullRequestReviewCommentEvent at 2014-09-15 09:50:01
Repository: SuluSalesShippingBundle
Actor: michaelzangerle
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/pulls/comments/17533349","id":17533349,"diff_hunk":"@@ -130,4 +136,24 @@ public function getItem()\n     {\n         return new Item($this->entity->getItem(), $this->locale);\n     }\n+\n+    /**\n+     * @param $numShippedItems\n+     * @return $this\n+     */\n+    public function setShippedItems($numShippedItems)\n+    {\n+        $this->shippedItems = $numShippedItems;\n+\n+        return $this;\n+    }\n+\n+    /**\n+     * @return shippedItems*","path":"Api/ShippingItem.php","position":37,"original_position":37,"commit_id":"0aacc2d57a2096294e5de6773f8e2188a78c1731","original_commit_id":"0aacc2d57a2096294e5de6773f8e2188a78c1731","user":{"login":"michaelzangerle","id":1465587,"avatar_url":"https://avatars.githubusercontent.com/u/1465587?v=2","gravatar_id":"47e759d080a78b4524e9b04d56cd0f88","url":"https://api.github.com/users/michaelzangerle","html_url":"https://github.com/michaelzangerle","followers_url":"https://api.github.com/users/michaelzangerle/followers","following_url":"https://api.github.com/users/michaelzangerle/following{/other_user}","gists_url":"https://api.github.com/users/michaelzangerle/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelzangerle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelzangerle/subscriptions","organizations_url":"https://api.github.com/users/michaelzangerle/orgs","repos_url":"https://api.github.com/users/michaelzangerle/repos","events_url":"https://api.github.com/users/michaelzangerle/events{/privacy}","received_events_url":"https://api.github.com/users/michaelzangerle/received_events","type":"User","site_admin":false},"body":"@turbo-ele typo here and could be extended to \"number of shipped items\" to clarify what will be returned","created_at":"2014-09-15T09:50:01Z","updated_at":"2014-09-15T09:50:01Z","html_url":"https://github.com/sulu-cmf/SuluSalesShippingBundle/pull/2#discussion_r17533349","pull_request_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/pulls/comments/17533349"},"html":{"href":"https://github.com/sulu-cmf/SuluSalesShippingBundle/pull/2#discussion_r17533349"},"pull_request":{"href":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/pulls/2","id":21030435,"html_url":"https://github.com/sulu-cmf/SuluSalesShippingBundle/pull/2","diff_url":"https://github.com/sulu-cmf/SuluSalesShippingBundle/pull/2.diff","patch_url":"https://github.com/sulu-cmf/SuluSalesShippingBundle/pull/2.patch","issue_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/issues/2","number":2,"state":"open","locked":false,"title":"[FEATURE] UI for creating / editing a shipping","user":{"login":"turbo-ele","id":5152633,"avatar_url":"https://avatars.githubusercontent.com/u/5152633?v=2","gravatar_id":"06bed20024f7cd0b30ecaea7affbee0b","url":"https://api.github.com/users/turbo-ele","html_url":"https://github.com/turbo-ele","followers_url":"https://api.github.com/users/turbo-ele/followers","following_url":"https://api.github.com/users/turbo-ele/following{/other_user}","gists_url":"https://api.github.com/users/turbo-ele/gists{/gist_id}","starred_url":"https://api.github.com/users/turbo-ele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/turbo-ele/subscriptions","organizations_url":"https://api.github.com/users/turbo-ele/orgs","repos_url":"https://api.github.com/users/turbo-ele/repos","events_url":"https://api.github.com/users/turbo-ele/events{/privacy}","received_events_url":"https://api.github.com/users/turbo-ele/received_events","type":"User","site_admin":false},"body":"__Tasks:__\r\n- [x] ui for creating a shipping\r\n- [x] convert shipping status via toolbar\r\n- [ ] gather feedback for my changes\r\n\r\n__Informations:__\r\n\r\n| Q             | A\r\n| ------------- | ---\r\n| Tests pass?   | aye\r\n| Fixed tickets | -\r\n| BC Breaks     | -\r\n| Doc           | -\r\n\r\n__Requires:__\r\n","created_at":"2014-09-10T15:52:21Z","updated_at":"2014-09-15T09:50:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0cc5635157f6dfacce88094ff9bf1a326fdc4bd9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/pulls/2/commits","review_comments_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/pulls/2/comments","review_comment_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/pulls/comments/{number}","comments_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/issues/2/comments","statuses_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/statuses/0aacc2d57a2096294e5de6773f8e2188a78c1731","head":{"label":"sulu-cmf:feature/ui","ref":"feature/ui","sha":"0aacc2d57a2096294e5de6773f8e2188a78c1731","user":{"login":"sulu-cmf","id":5717006,"avatar_url":"https://avatars.githubusercontent.com/u/5717006?v=2","gravatar_id":"8011978d34511fd7c1722a2812997d78","url":"https://api.github.com/users/sulu-cmf","html_url":"https://github.com/sulu-cmf","followers_url":"https://api.github.com/users/sulu-cmf/followers","following_url":"https://api.github.com/users/sulu-cmf/following{/other_user}","gists_url":"https://api.github.com/users/sulu-cmf/gists{/gist_id}","starred_url":"https://api.github.com/users/sulu-cmf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sulu-cmf/subscriptions","organizations_url":"https://api.github.com/users/sulu-cmf/orgs","repos_url":"https://api.github.com/users/sulu-cmf/repos","events_url":"https://api.github.com/users/sulu-cmf/events{/privacy}","received_events_url":"https://api.github.com/users/sulu-cmf/received_events","type":"Organization","site_admin":false},"repo":{"id":23154499,"name":"SuluSalesShippingBundle","full_name":"sulu-cmf/SuluSalesShippingBundle","owner":{"login":"sulu-cmf","id":5717006,"avatar_url":"https://avatars.githubusercontent.com/u/5717006?v=2","gravatar_id":"8011978d34511fd7c1722a2812997d78","url":"https://api.github.com/users/sulu-cmf","html_url":"https://github.com/sulu-cmf","followers_url":"https://api.github.com/users/sulu-cmf/followers","following_url":"https://api.github.com/users/sulu-cmf/following{/other_user}","gists_url":"https://api.github.com/users/sulu-cmf/gists{/gist_id}","starred_url":"https://api.github.com/users/sulu-cmf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sulu-cmf/subscriptions","organizations_url":"https://api.github.com/users/sulu-cmf/orgs","repos_url":"https://api.github.com/users/sulu-cmf/repos","events_url":"https://api.github.com/users/sulu-cmf/events{/privacy}","received_events_url":"https://api.github.com/users/sulu-cmf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sulu-cmf/SuluSalesShippingBundle","description":"","fork":false,"url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle","forks_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/forks","keys_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/teams","hooks_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/hooks","issue_events_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/issues/events{/number}","events_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/events","assignees_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/assignees{/user}","branches_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/branches{/branch}","tags_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/tags","blobs_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/languages","stargazers_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/stargazers","contributors_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/contributors","subscribers_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/subscribers","subscription_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/subscription","commits_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/issues/comments/{number}","contents_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/contents/{+path}","compare_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/merges","archive_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/downloads","issues_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/issues{/number}","pulls_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/labels{/name}","releases_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/releases{/id}","created_at":"2014-08-20T15:51:35Z","updated_at":"2014-09-04T12:04:59Z","pushed_at":"2014-09-15T09:20:26Z","git_url":"git://github.com/sulu-cmf/SuluSalesShippingBundle.git","ssh_url":"git@github.com:sulu-cmf/SuluSalesShippingBundle.git","clone_url":"https://github.com/sulu-cmf/SuluSalesShippingBundle.git","svn_url":"https://github.com/sulu-cmf/SuluSalesShippingBundle","homepage":null,"size":312,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"sulu-cmf:develop","ref":"develop","sha":"63c6cd2295b82c7000deb9196fc9472f04f921c8","user":{"login":"sulu-cmf","id":5717006,"avatar_url":"https://avatars.githubusercontent.com/u/5717006?v=2","gravatar_id":"8011978d34511fd7c1722a2812997d78","url":"https://api.github.com/users/sulu-cmf","html_url":"https://github.com/sulu-cmf","followers_url":"https://api.github.com/users/sulu-cmf/followers","following_url":"https://api.github.com/users/sulu-cmf/following{/other_user}","gists_url":"https://api.github.com/users/sulu-cmf/gists{/gist_id}","starred_url":"https://api.github.com/users/sulu-cmf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sulu-cmf/subscriptions","organizations_url":"https://api.github.com/users/sulu-cmf/orgs","repos_url":"https://api.github.com/users/sulu-cmf/repos","events_url":"https://api.github.com/users/sulu-cmf/events{/privacy}","received_events_url":"https://api.github.com/users/sulu-cmf/received_events","type":"Organization","site_admin":false},"repo":{"id":23154499,"name":"SuluSalesShippingBundle","full_name":"sulu-cmf/SuluSalesShippingBundle","owner":{"login":"sulu-cmf","id":5717006,"avatar_url":"https://avatars.githubusercontent.com/u/5717006?v=2","gravatar_id":"8011978d34511fd7c1722a2812997d78","url":"https://api.github.com/users/sulu-cmf","html_url":"https://github.com/sulu-cmf","followers_url":"https://api.github.com/users/sulu-cmf/followers","following_url":"https://api.github.com/users/sulu-cmf/following{/other_user}","gists_url":"https://api.github.com/users/sulu-cmf/gists{/gist_id}","starred_url":"https://api.github.com/users/sulu-cmf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sulu-cmf/subscriptions","organizations_url":"https://api.github.com/users/sulu-cmf/orgs","repos_url":"https://api.github.com/users/sulu-cmf/repos","events_url":"https://api.github.com/users/sulu-cmf/events{/privacy}","received_events_url":"https://api.github.com/users/sulu-cmf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sulu-cmf/SuluSalesShippingBundle","description":"","fork":false,"url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle","forks_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/forks","keys_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/teams","hooks_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/hooks","issue_events_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/issues/events{/number}","events_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/events","assignees_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/assignees{/user}","branches_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/branches{/branch}","tags_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/tags","blobs_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/languages","stargazers_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/stargazers","contributors_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/contributors","subscribers_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/subscribers","subscription_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/subscription","commits_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/issues/comments/{number}","contents_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/contents/{+path}","compare_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/merges","archive_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/downloads","issues_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/issues{/number}","pulls_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/labels{/name}","releases_url":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/releases{/id}","created_at":"2014-08-20T15:51:35Z","updated_at":"2014-09-04T12:04:59Z","pushed_at":"2014-09-15T09:20:26Z","git_url":"git://github.com/sulu-cmf/SuluSalesShippingBundle.git","ssh_url":"git@github.com:sulu-cmf/SuluSalesShippingBundle.git","clone_url":"https://github.com/sulu-cmf/SuluSalesShippingBundle.git","svn_url":"https://github.com/sulu-cmf/SuluSalesShippingBundle","homepage":null,"size":312,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/pulls/2"},"html":{"href":"https://github.com/sulu-cmf/SuluSalesShippingBundle/pull/2"},"issue":{"href":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/issues/2"},"comments":{"href":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/sulu-cmf/SuluSalesShippingBundle/statuses/0aacc2d57a2096294e5de6773f8e2188a78c1731"}}}}