GitHub PullRequestEvent at 2014-09-19 16:03:35
Repository: noVNC
Actor: DirectXMan12
Payload: {"action":"closed","number":392,"pull_request":{"url":"https://api.github.com/repos/kanaka/noVNC/pulls/392","id":21412343,"html_url":"https://github.com/kanaka/noVNC/pull/392","diff_url":"https://github.com/kanaka/noVNC/pull/392.diff","patch_url":"https://github.com/kanaka/noVNC/pull/392.patch","issue_url":"https://api.github.com/repos/kanaka/noVNC/issues/392","number":392,"state":"closed","locked":false,"title":"Fixed `displayed` chai assertion in test.rfb.js","user":{"login":"mandre","id":225909,"avatar_url":"https://avatars.githubusercontent.com/u/225909?v=2","gravatar_id":"09f0eef8410775638782c6159c1c5d73","url":"https://api.github.com/users/mandre","html_url":"https://github.com/mandre","followers_url":"https://api.github.com/users/mandre/followers","following_url":"https://api.github.com/users/mandre/following{/other_user}","gists_url":"https://api.github.com/users/mandre/gists{/gist_id}","starred_url":"https://api.github.com/users/mandre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandre/subscriptions","organizations_url":"https://api.github.com/users/mandre/orgs","repos_url":"https://api.github.com/users/mandre/repos","events_url":"https://api.github.com/users/mandre/events{/privacy}","received_events_url":"https://api.github.com/users/mandre/received_events","type":"User","site_admin":false},"body":"The implementation of the `displayed` chai assertion from test.rfb.js\r\nwas overriding the one from test.display.js, which was the correct one\r\nthat took viewport location into consideration.\r\n\r\nchai assertions should probably be extracted in order to reduce code\r\nduplication and prevent similar errors in the future.\r\n\r\nCall resize() on client._display instead of setting _fb_width and\r\n_fb_height properties directly otherwise _viewportLoc width and height\r\nare not properly set, causing tests to fail with \"Disconnected (1\r\ntimes), because no message in 10000 ms\" error.","created_at":"2014-09-18T05:10:39Z","updated_at":"2014-09-19T16:03:35Z","closed_at":"2014-09-19T16:03:35Z","merged_at":null,"merge_commit_sha":"5355faf28b2dbbf42edd13cea34d605f941cd296","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kanaka/noVNC/pulls/392/commits","review_comments_url":"https://api.github.com/repos/kanaka/noVNC/pulls/392/comments","review_comment_url":"https://api.github.com/repos/kanaka/noVNC/pulls/comments/{number}","comments_url":"https://api.github.com/repos/kanaka/noVNC/issues/392/comments","statuses_url":"https://api.github.com/repos/kanaka/noVNC/statuses/5118552088bc5b2ac277793cf6339a4b4b5624f1","head":{"label":"mandre:fix_testsuite","ref":"fix_testsuite","sha":"5118552088bc5b2ac277793cf6339a4b4b5624f1","user":{"login":"mandre","id":225909,"avatar_url":"https://avatars.githubusercontent.com/u/225909?v=2","gravatar_id":"09f0eef8410775638782c6159c1c5d73","url":"https://api.github.com/users/mandre","html_url":"https://github.com/mandre","followers_url":"https://api.github.com/users/mandre/followers","following_url":"https://api.github.com/users/mandre/following{/other_user}","gists_url":"https://api.github.com/users/mandre/gists{/gist_id}","starred_url":"https://api.github.com/users/mandre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandre/subscriptions","organizations_url":"https://api.github.com/users/mandre/orgs","repos_url":"https://api.github.com/users/mandre/repos","events_url":"https://api.github.com/users/mandre/events{/privacy}","received_events_url":"https://api.github.com/users/mandre/received_events","type":"User","site_admin":false},"repo":{"id":24134335,"name":"noVNC","full_name":"mandre/noVNC","owner":{"login":"mandre","id":225909,"avatar_url":"https://avatars.githubusercontent.com/u/225909?v=2","gravatar_id":"09f0eef8410775638782c6159c1c5d73","url":"https://api.github.com/users/mandre","html_url":"https://github.com/mandre","followers_url":"https://api.github.com/users/mandre/followers","following_url":"https://api.github.com/users/mandre/following{/other_user}","gists_url":"https://api.github.com/users/mandre/gists{/gist_id}","starred_url":"https://api.github.com/users/mandre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandre/subscriptions","organizations_url":"https://api.github.com/users/mandre/orgs","repos_url":"https://api.github.com/users/mandre/repos","events_url":"https://api.github.com/users/mandre/events{/privacy}","received_events_url":"https://api.github.com/users/mandre/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mandre/noVNC","description":"VNC client using HTML5 (Web Sockets, Canvas) with encryption (wss://) support.","fork":true,"url":"https://api.github.com/repos/mandre/noVNC","forks_url":"https://api.github.com/repos/mandre/noVNC/forks","keys_url":"https://api.github.com/repos/mandre/noVNC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mandre/noVNC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mandre/noVNC/teams","hooks_url":"https://api.github.com/repos/mandre/noVNC/hooks","issue_events_url":"https://api.github.com/repos/mandre/noVNC/issues/events{/number}","events_url":"https://api.github.com/repos/mandre/noVNC/events","assignees_url":"https://api.github.com/repos/mandre/noVNC/assignees{/user}","branches_url":"https://api.github.com/repos/mandre/noVNC/branches{/branch}","tags_url":"https://api.github.com/repos/mandre/noVNC/tags","blobs_url":"https://api.github.com/repos/mandre/noVNC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mandre/noVNC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mandre/noVNC/git/refs{/sha}","trees_url":"https://api.github.com/repos/mandre/noVNC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mandre/noVNC/statuses/{sha}","languages_url":"https://api.github.com/repos/mandre/noVNC/languages","stargazers_url":"https://api.github.com/repos/mandre/noVNC/stargazers","contributors_url":"https://api.github.com/repos/mandre/noVNC/contributors","subscribers_url":"https://api.github.com/repos/mandre/noVNC/subscribers","subscription_url":"https://api.github.com/repos/mandre/noVNC/subscription","commits_url":"https://api.github.com/repos/mandre/noVNC/commits{/sha}","git_commits_url":"https://api.github.com/repos/mandre/noVNC/git/commits{/sha}","comments_url":"https://api.github.com/repos/mandre/noVNC/comments{/number}","issue_comment_url":"https://api.github.com/repos/mandre/noVNC/issues/comments/{number}","contents_url":"https://api.github.com/repos/mandre/noVNC/contents/{+path}","compare_url":"https://api.github.com/repos/mandre/noVNC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mandre/noVNC/merges","archive_url":"https://api.github.com/repos/mandre/noVNC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mandre/noVNC/downloads","issues_url":"https://api.github.com/repos/mandre/noVNC/issues{/number}","pulls_url":"https://api.github.com/repos/mandre/noVNC/pulls{/number}","milestones_url":"https://api.github.com/repos/mandre/noVNC/milestones{/number}","notifications_url":"https://api.github.com/repos/mandre/noVNC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mandre/noVNC/labels{/name}","releases_url":"https://api.github.com/repos/mandre/noVNC/releases{/id}","created_at":"2014-09-17T07:21:03Z","updated_at":"2014-09-16T14:05:05Z","pushed_at":"2014-09-18T05:09:35Z","git_url":"git://github.com/mandre/noVNC.git","ssh_url":"git@github.com:mandre/noVNC.git","clone_url":"https://github.com/mandre/noVNC.git","svn_url":"https://github.com/mandre/noVNC","homepage":"novnc.com","size":14352,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kanaka:master","ref":"master","sha":"0ca7cf4867f1dae585d254f16ad62c552648265f","user":{"login":"kanaka","id":70127,"avatar_url":"https://avatars.githubusercontent.com/u/70127?v=2","gravatar_id":"b2bd81c28bcafeea19ac72e554859ec0","url":"https://api.github.com/users/kanaka","html_url":"https://github.com/kanaka","followers_url":"https://api.github.com/users/kanaka/followers","following_url":"https://api.github.com/users/kanaka/following{/other_user}","gists_url":"https://api.github.com/users/kanaka/gists{/gist_id}","starred_url":"https://api.github.com/users/kanaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanaka/subscriptions","organizations_url":"https://api.github.com/users/kanaka/orgs","repos_url":"https://api.github.com/users/kanaka/repos","events_url":"https://api.github.com/users/kanaka/events{/privacy}","received_events_url":"https://api.github.com/users/kanaka/received_events","type":"User","site_admin":false},"repo":{"id":598164,"name":"noVNC","full_name":"kanaka/noVNC","owner":{"login":"kanaka","id":70127,"avatar_url":"https://avatars.githubusercontent.com/u/70127?v=2","gravatar_id":"b2bd81c28bcafeea19ac72e554859ec0","url":"https://api.github.com/users/kanaka","html_url":"https://github.com/kanaka","followers_url":"https://api.github.com/users/kanaka/followers","following_url":"https://api.github.com/users/kanaka/following{/other_user}","gists_url":"https://api.github.com/users/kanaka/gists{/gist_id}","starred_url":"https://api.github.com/users/kanaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanaka/subscriptions","organizations_url":"https://api.github.com/users/kanaka/orgs","repos_url":"https://api.github.com/users/kanaka/repos","events_url":"https://api.github.com/users/kanaka/events{/privacy}","received_events_url":"https://api.github.com/users/kanaka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kanaka/noVNC","description":"VNC client using HTML5 (Web Sockets, Canvas) with encryption (wss://) support.","fork":false,"url":"https://api.github.com/repos/kanaka/noVNC","forks_url":"https://api.github.com/repos/kanaka/noVNC/forks","keys_url":"https://api.github.com/repos/kanaka/noVNC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kanaka/noVNC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kanaka/noVNC/teams","hooks_url":"https://api.github.com/repos/kanaka/noVNC/hooks","issue_events_url":"https://api.github.com/repos/kanaka/noVNC/issues/events{/number}","events_url":"https://api.github.com/repos/kanaka/noVNC/events","assignees_url":"https://api.github.com/repos/kanaka/noVNC/assignees{/user}","branches_url":"https://api.github.com/repos/kanaka/noVNC/branches{/branch}","tags_url":"https://api.github.com/repos/kanaka/noVNC/tags","blobs_url":"https://api.github.com/repos/kanaka/noVNC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kanaka/noVNC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kanaka/noVNC/git/refs{/sha}","trees_url":"https://api.github.com/repos/kanaka/noVNC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kanaka/noVNC/statuses/{sha}","languages_url":"https://api.github.com/repos/kanaka/noVNC/languages","stargazers_url":"https://api.github.com/repos/kanaka/noVNC/stargazers","contributors_url":"https://api.github.com/repos/kanaka/noVNC/contributors","subscribers_url":"https://api.github.com/repos/kanaka/noVNC/subscribers","subscription_url":"https://api.github.com/repos/kanaka/noVNC/subscription","commits_url":"https://api.github.com/repos/kanaka/noVNC/commits{/sha}","git_commits_url":"https://api.github.com/repos/kanaka/noVNC/git/commits{/sha}","comments_url":"https://api.github.com/repos/kanaka/noVNC/comments{/number}","issue_comment_url":"https://api.github.com/repos/kanaka/noVNC/issues/comments/{number}","contents_url":"https://api.github.com/repos/kanaka/noVNC/contents/{+path}","compare_url":"https://api.github.com/repos/kanaka/noVNC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kanaka/noVNC/merges","archive_url":"https://api.github.com/repos/kanaka/noVNC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kanaka/noVNC/downloads","issues_url":"https://api.github.com/repos/kanaka/noVNC/issues{/number}","pulls_url":"https://api.github.com/repos/kanaka/noVNC/pulls{/number}","milestones_url":"https://api.github.com/repos/kanaka/noVNC/milestones{/number}","notifications_url":"https://api.github.com/repos/kanaka/noVNC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kanaka/noVNC/labels{/name}","releases_url":"https://api.github.com/repos/kanaka/noVNC/releases{/id}","created_at":"2010-04-07T01:55:44Z","updated_at":"2014-09-16T14:05:05Z","pushed_at":"2014-09-19T15:45:22Z","git_url":"git://github.com/kanaka/noVNC.git","ssh_url":"git@github.com:kanaka/noVNC.git","clone_url":"https://github.com/kanaka/noVNC.git","svn_url":"https://github.com/kanaka/noVNC","homepage":"novnc.com","size":14352,"stargazers_count":1701,"watchers_count":1701,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":302,"mirror_url":null,"open_issues_count":97,"forks":302,"open_issues":97,"watchers":1701,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kanaka/noVNC/pulls/392"},"html":{"href":"https://github.com/kanaka/noVNC/pull/392"},"issue":{"href":"https://api.github.com/repos/kanaka/noVNC/issues/392"},"comments":{"href":"https://api.github.com/repos/kanaka/noVNC/issues/392/comments"},"review_comments":{"href":"https://api.github.com/repos/kanaka/noVNC/pulls/392/comments"},"review_comment":{"href":"https://api.github.com/repos/kanaka/noVNC/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/kanaka/noVNC/pulls/392/commits"},"statuses":{"href":"https://api.github.com/repos/kanaka/noVNC/statuses/5118552088bc5b2ac277793cf6339a4b4b5624f1"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":3,"deletions":5,"changed_files":1}}