GitHub PullRequestReviewCommentEvent at 2014-06-09 16:20:25
Repository: spartacus
Actor: muffinresearch
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/spartacus/pulls/comments/13549183","id":13549183,"diff_hunk":"@@ -57,27 +59,86 @@ define([\n       // to deal with login success.\n       app.session.set('logged_in', true);\n     }).fail(function($xhr, textStatus) {\n+      console.log(textStatus);\n+      console.log($xhr.status);\n       if (textStatus === 'timeout') {\n         console.log('login timed out');\n         utils.trackEvent({'action': 'persona login',\n                           'label': 'Verification Timed Out'});\n-        showRetryError(assertion, 'LOGIN_TIMEOUT', gettext('That took longer than expected. Retry?'));\n+        showRetryError({\n+          assertion: assertion,\n+          errCode: 'LOGIN_TIMEOUT',\n+          msg: gettext('That took longer than expected. Retry?'),\n+        });\n       } else if ($xhr.status === 403) {\n         console.log('permission denied after auth');\n         utils.trackEvent({'action': 'persona login',\n                           'label': 'Login Permission Denied'});\n-        app.error.render({context: {errorCode: 'VERIFICATION_DENIED'}, showCta: false});\n+        app.error.render({context: {errorCode: 'VERIFY_DENIED'}, showCta: false});\n       } else {\n         console.log('login error');\n         utils.trackEvent({'action': 'persona login',\n                           'label': 'Login Failed'});\n-        showRetryError(assertion, 'LOGIN_FAILED');\n+        showRetryError({\n+          assertion: assertion,\n+          errCode: 'LOGIN_FAILED',\n+        });\n+\n       }\n     });\n \n     return req;\n   }\n \n+  function reVerifyUser(assertion) {\n+    console.log('Re-verifying assertion');\n+\n+    var reqConfig = {\n+      type: 'POST',\n+      url: utils.bodyData.reverifyUrl,\n+      data: {assertion: assertion},\n+      timeout: settings.ajax_timeout,\n+    };\n+\n+    var req = $.ajax(reqConfig);\n+\n+    req.done(function _resetLoginSuccess() {\n+    //req.done(function _resetLoginSuccess(data) {","path":"public/js/lib/auth.js","position":112,"original_position":112,"commit_id":"13dd38328c40e81e5ec9ed86630485b312480b20","original_commit_id":"13dd38328c40e81e5ec9ed86630485b312480b20","user":{"login":"muffinresearch","id":1514,"avatar_url":"https://avatars.githubusercontent.com/u/1514?","gravatar_id":"86cf2c38bd61ffc99251cbd5d6ec2dfd","url":"https://api.github.com/users/muffinresearch","html_url":"https://github.com/muffinresearch","followers_url":"https://api.github.com/users/muffinresearch/followers","following_url":"https://api.github.com/users/muffinresearch/following{/other_user}","gists_url":"https://api.github.com/users/muffinresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/muffinresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muffinresearch/subscriptions","organizations_url":"https://api.github.com/users/muffinresearch/orgs","repos_url":"https://api.github.com/users/muffinresearch/repos","events_url":"https://api.github.com/users/muffinresearch/events{/privacy}","received_events_url":"https://api.github.com/users/muffinresearch/received_events","type":"User","site_admin":false},"body":"Yeah, that's because I'm waiting on the provider api call to be able to do this with provider.prepare etc.","created_at":"2014-06-09T16:20:25Z","updated_at":"2014-06-09T16:20:25Z","html_url":"https://github.com/mozilla/spartacus/pull/57#discussion_r13549183","pull_request_url":"https://api.github.com/repos/mozilla/spartacus/pulls/57","_links":{"self":{"href":"https://api.github.com/repos/mozilla/spartacus/pulls/comments/13549183"},"html":{"href":"https://github.com/mozilla/spartacus/pull/57#discussion_r13549183"},"pull_request":{"href":"https://api.github.com/repos/mozilla/spartacus/pulls/57"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/spartacus/pulls/57","id":16842465,"html_url":"https://github.com/mozilla/spartacus/pull/57","diff_url":"https://github.com/mozilla/spartacus/pull/57.diff","patch_url":"https://github.com/mozilla/spartacus/pull/57.patch","issue_url":"https://api.github.com/repos/mozilla/spartacus/issues/57","number":57,"state":"open","title":" Hookup reset flow (bug 1003882) ","user":{"login":"muffinresearch","id":1514,"avatar_url":"https://avatars.githubusercontent.com/u/1514?","gravatar_id":"86cf2c38bd61ffc99251cbd5d6ec2dfd","url":"https://api.github.com/users/muffinresearch","html_url":"https://github.com/muffinresearch","followers_url":"https://api.github.com/users/muffinresearch/followers","following_url":"https://api.github.com/users/muffinresearch/following{/other_user}","gists_url":"https://api.github.com/users/muffinresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/muffinresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muffinresearch/subscriptions","organizations_url":"https://api.github.com/users/muffinresearch/orgs","repos_url":"https://api.github.com/users/muffinresearch/repos","events_url":"https://api.github.com/users/muffinresearch/events{/privacy}","received_events_url":"https://api.github.com/users/muffinresearch/received_events","type":"User","site_admin":false},"body":"~~TODO: Add the rest of the tests + clean-up.~~","created_at":"2014-06-06T20:59:22Z","updated_at":"2014-06-09T16:20:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"615e696ad18da1ec36c8a27ebdccb56cc1260ccf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/spartacus/pulls/57/commits","review_comments_url":"https://api.github.com/repos/mozilla/spartacus/pulls/57/comments","review_comment_url":"https://api.github.com/repos/mozilla/spartacus/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla/spartacus/issues/57/comments","statuses_url":"https://api.github.com/repos/mozilla/spartacus/statuses/13dd38328c40e81e5ec9ed86630485b312480b20","head":{"label":"muffinresearch:reset-flow","ref":"reset-flow","sha":"13dd38328c40e81e5ec9ed86630485b312480b20","user":{"login":"muffinresearch","id":1514,"avatar_url":"https://avatars.githubusercontent.com/u/1514?","gravatar_id":"86cf2c38bd61ffc99251cbd5d6ec2dfd","url":"https://api.github.com/users/muffinresearch","html_url":"https://github.com/muffinresearch","followers_url":"https://api.github.com/users/muffinresearch/followers","following_url":"https://api.github.com/users/muffinresearch/following{/other_user}","gists_url":"https://api.github.com/users/muffinresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/muffinresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muffinresearch/subscriptions","organizations_url":"https://api.github.com/users/muffinresearch/orgs","repos_url":"https://api.github.com/users/muffinresearch/repos","events_url":"https://api.github.com/users/muffinresearch/events{/privacy}","received_events_url":"https://api.github.com/users/muffinresearch/received_events","type":"User","site_admin":false},"repo":{"id":16289322,"name":"spartacus","full_name":"muffinresearch/spartacus","owner":{"login":"muffinresearch","id":1514,"avatar_url":"https://avatars.githubusercontent.com/u/1514?","gravatar_id":"86cf2c38bd61ffc99251cbd5d6ec2dfd","url":"https://api.github.com/users/muffinresearch","html_url":"https://github.com/muffinresearch","followers_url":"https://api.github.com/users/muffinresearch/followers","following_url":"https://api.github.com/users/muffinresearch/following{/other_user}","gists_url":"https://api.github.com/users/muffinresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/muffinresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muffinresearch/subscriptions","organizations_url":"https://api.github.com/users/muffinresearch/orgs","repos_url":"https://api.github.com/users/muffinresearch/repos","events_url":"https://api.github.com/users/muffinresearch/events{/privacy}","received_events_url":"https://api.github.com/users/muffinresearch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/muffinresearch/spartacus","description":"","fork":true,"url":"https://api.github.com/repos/muffinresearch/spartacus","forks_url":"https://api.github.com/repos/muffinresearch/spartacus/forks","keys_url":"https://api.github.com/repos/muffinresearch/spartacus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/muffinresearch/spartacus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/muffinresearch/spartacus/teams","hooks_url":"https://api.github.com/repos/muffinresearch/spartacus/hooks","issue_events_url":"https://api.github.com/repos/muffinresearch/spartacus/issues/events{/number}","events_url":"https://api.github.com/repos/muffinresearch/spartacus/events","assignees_url":"https://api.github.com/repos/muffinresearch/spartacus/assignees{/user}","branches_url":"https://api.github.com/repos/muffinresearch/spartacus/branches{/branch}","tags_url":"https://api.github.com/repos/muffinresearch/spartacus/tags","blobs_url":"https://api.github.com/repos/muffinresearch/spartacus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/muffinresearch/spartacus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/muffinresearch/spartacus/git/refs{/sha}","trees_url":"https://api.github.com/repos/muffinresearch/spartacus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/muffinresearch/spartacus/statuses/{sha}","languages_url":"https://api.github.com/repos/muffinresearch/spartacus/languages","stargazers_url":"https://api.github.com/repos/muffinresearch/spartacus/stargazers","contributors_url":"https://api.github.com/repos/muffinresearch/spartacus/contributors","subscribers_url":"https://api.github.com/repos/muffinresearch/spartacus/subscribers","subscription_url":"https://api.github.com/repos/muffinresearch/spartacus/subscription","commits_url":"https://api.github.com/repos/muffinresearch/spartacus/commits{/sha}","git_commits_url":"https://api.github.com/repos/muffinresearch/spartacus/git/commits{/sha}","comments_url":"https://api.github.com/repos/muffinresearch/spartacus/comments{/number}","issue_comment_url":"https://api.github.com/repos/muffinresearch/spartacus/issues/comments/{number}","contents_url":"https://api.github.com/repos/muffinresearch/spartacus/contents/{+path}","compare_url":"https://api.github.com/repos/muffinresearch/spartacus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/muffinresearch/spartacus/merges","archive_url":"https://api.github.com/repos/muffinresearch/spartacus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/muffinresearch/spartacus/downloads","issues_url":"https://api.github.com/repos/muffinresearch/spartacus/issues{/number}","pulls_url":"https://api.github.com/repos/muffinresearch/spartacus/pulls{/number}","milestones_url":"https://api.github.com/repos/muffinresearch/spartacus/milestones{/number}","notifications_url":"https://api.github.com/repos/muffinresearch/spartacus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/muffinresearch/spartacus/labels{/name}","releases_url":"https://api.github.com/repos/muffinresearch/spartacus/releases{/id}","created_at":"2014-01-27T19:08:10Z","updated_at":"2014-06-09T16:18:53Z","pushed_at":"2014-06-09T16:18:53Z","git_url":"git://github.com/muffinresearch/spartacus.git","ssh_url":"git@github.com:muffinresearch/spartacus.git","clone_url":"https://github.com/muffinresearch/spartacus.git","svn_url":"https://github.com/muffinresearch/spartacus","homepage":null,"size":3270,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"e4749d37c86497afa7c8e798f4440514d9187d21","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?","gravatar_id":"9ba739c8f3288e256b13553e4d257b5e","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":16289140,"name":"spartacus","full_name":"mozilla/spartacus","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?","gravatar_id":"9ba739c8f3288e256b13553e4d257b5e","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/spartacus","description":"Spartacus is a single page app front-end for Webpay.","fork":false,"url":"https://api.github.com/repos/mozilla/spartacus","forks_url":"https://api.github.com/repos/mozilla/spartacus/forks","keys_url":"https://api.github.com/repos/mozilla/spartacus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/spartacus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/spartacus/teams","hooks_url":"https://api.github.com/repos/mozilla/spartacus/hooks","issue_events_url":"https://api.github.com/repos/mozilla/spartacus/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/spartacus/events","assignees_url":"https://api.github.com/repos/mozilla/spartacus/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/spartacus/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/spartacus/tags","blobs_url":"https://api.github.com/repos/mozilla/spartacus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/spartacus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/spartacus/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/spartacus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/spartacus/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/spartacus/languages","stargazers_url":"https://api.github.com/repos/mozilla/spartacus/stargazers","contributors_url":"https://api.github.com/repos/mozilla/spartacus/contributors","subscribers_url":"https://api.github.com/repos/mozilla/spartacus/subscribers","subscription_url":"https://api.github.com/repos/mozilla/spartacus/subscription","commits_url":"https://api.github.com/repos/mozilla/spartacus/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/spartacus/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/spartacus/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/spartacus/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla/spartacus/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/spartacus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/spartacus/merges","archive_url":"https://api.github.com/repos/mozilla/spartacus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/spartacus/downloads","issues_url":"https://api.github.com/repos/mozilla/spartacus/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/spartacus/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/spartacus/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/spartacus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/spartacus/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/spartacus/releases{/id}","created_at":"2014-01-27T19:02:16Z","updated_at":"2014-06-06T08:13:40Z","pushed_at":"2014-06-06T08:13:40Z","git_url":"git://github.com/mozilla/spartacus.git","ssh_url":"git@github.com:mozilla/spartacus.git","clone_url":"https://github.com/mozilla/spartacus.git","svn_url":"https://github.com/mozilla/spartacus","homepage":"","size":3252,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":6,"mirror_url":null,"open_issues_count":3,"forks":6,"open_issues":3,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/spartacus/pulls/57"},"html":{"href":"https://github.com/mozilla/spartacus/pull/57"},"issue":{"href":"https://api.github.com/repos/mozilla/spartacus/issues/57"},"comments":{"href":"https://api.github.com/repos/mozilla/spartacus/issues/57/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/spartacus/pulls/57/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/spartacus/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla/spartacus/pulls/57/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/spartacus/statuses/13dd38328c40e81e5ec9ed86630485b312480b20"}}}}