GitHub PullRequestReviewCommentEvent at 2014-10-14 13:59:33
Repository: flamsteed
Actor: Ianfeather
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/lonelyplanet/flamsteed/pulls/comments/18829659","id":18829659,"diff_hunk":"@@ -82,7 +109,7 @@ components, widgets, or ads lazy-loaded after `domComplete`, but\n you're specifically interested in one of them (e.g. timeline for\n Facebook).\n \n-flamsteed lets you time custom events, relative to the \n+flamsteed lets you time custom events, relative to the","path":"README.md","position":102,"original_position":90,"commit_id":"b0c15e4832985d643e22443597229b68677b392e","original_commit_id":"f32645e6641a6d092bf01da31f51b538ff895462","user":{"login":"Ianfeather","id":814861,"avatar_url":"https://avatars.githubusercontent.com/u/814861?v=2","gravatar_id":"","url":"https://api.github.com/users/Ianfeather","html_url":"https://github.com/Ianfeather","followers_url":"https://api.github.com/users/Ianfeather/followers","following_url":"https://api.github.com/users/Ianfeather/following{/other_user}","gists_url":"https://api.github.com/users/Ianfeather/gists{/gist_id}","starred_url":"https://api.github.com/users/Ianfeather/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ianfeather/subscriptions","organizations_url":"https://api.github.com/users/Ianfeather/orgs","repos_url":"https://api.github.com/users/Ianfeather/repos","events_url":"https://api.github.com/users/Ianfeather/events{/privacy}","received_events_url":"https://api.github.com/users/Ianfeather/received_events","type":"User","site_admin":false},"body":"It's the relative part that isn't correct: https://github.com/lonelyplanet/flamsteed/pull/9/files#diff-f5b5447c2483b8e49de8b494e83da366L124 ","created_at":"2014-10-14T13:59:33Z","updated_at":"2014-10-14T13:59:33Z","html_url":"https://github.com/lonelyplanet/flamsteed/pull/9#discussion_r18829659","pull_request_url":"https://api.github.com/repos/lonelyplanet/flamsteed/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/lonelyplanet/flamsteed/pulls/comments/18829659"},"html":{"href":"https://github.com/lonelyplanet/flamsteed/pull/9#discussion_r18829659"},"pull_request":{"href":"https://api.github.com/repos/lonelyplanet/flamsteed/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/lonelyplanet/flamsteed/pulls/9","id":22704148,"html_url":"https://github.com/lonelyplanet/flamsteed/pull/9","diff_url":"https://github.com/lonelyplanet/flamsteed/pull/9.diff","patch_url":"https://github.com/lonelyplanet/flamsteed/pull/9.patch","issue_url":"https://api.github.com/repos/lonelyplanet/flamsteed/issues/9","number":9,"state":"open","locked":false,"title":"Page Impression Instance Amendments","user":{"login":"marckysharky","id":144170,"avatar_url":"https://avatars.githubusercontent.com/u/144170?v=2","gravatar_id":"","url":"https://api.github.com/users/marckysharky","html_url":"https://github.com/marckysharky","followers_url":"https://api.github.com/users/marckysharky/followers","following_url":"https://api.github.com/users/marckysharky/following{/other_user}","gists_url":"https://api.github.com/users/marckysharky/gists{/gist_id}","starred_url":"https://api.github.com/users/marckysharky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marckysharky/subscriptions","organizations_url":"https://api.github.com/users/marckysharky/orgs","repos_url":"https://api.github.com/users/marckysharky/repos","events_url":"https://api.github.com/users/marckysharky/events{/privacy}","received_events_url":"https://api.github.com/users/marckysharky/received_events","type":"User","site_admin":false},"body":"With a review of the data we have consumed, the following amendments have been implemented to increase the relevancy of the data:\r\n\r\n- [ ] Implement a `page impression id` attribute, to clearly distinguish a single page impression from another\r\n- [ ] Rename Flamsteed page impression options to clearly denote the `session id` from the `page impression id`\r\n- [ ] Enable `schema` on the Flamsteed page impression instance\r\n- [ ] Remove `RUM` calculations on client and send through only raw values\r\n- [ ] Ensure `key=value` pairs are correctly populated and sanitized","created_at":"2014-10-14T11:23:03Z","updated_at":"2014-10-14T13:59:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"36eb752b20b17d2e501435ff864a91022f9bc9b6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lonelyplanet/flamsteed/pulls/9/commits","review_comments_url":"https://api.github.com/repos/lonelyplanet/flamsteed/pulls/9/comments","review_comment_url":"https://api.github.com/repos/lonelyplanet/flamsteed/pulls/comments/{number}","comments_url":"https://api.github.com/repos/lonelyplanet/flamsteed/issues/9/comments","statuses_url":"https://api.github.com/repos/lonelyplanet/flamsteed/statuses/b0c15e4832985d643e22443597229b68677b392e","head":{"label":"marckysharky:master","ref":"master","sha":"b0c15e4832985d643e22443597229b68677b392e","user":{"login":"marckysharky","id":144170,"avatar_url":"https://avatars.githubusercontent.com/u/144170?v=2","gravatar_id":"","url":"https://api.github.com/users/marckysharky","html_url":"https://github.com/marckysharky","followers_url":"https://api.github.com/users/marckysharky/followers","following_url":"https://api.github.com/users/marckysharky/following{/other_user}","gists_url":"https://api.github.com/users/marckysharky/gists{/gist_id}","starred_url":"https://api.github.com/users/marckysharky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marckysharky/subscriptions","organizations_url":"https://api.github.com/users/marckysharky/orgs","repos_url":"https://api.github.com/users/marckysharky/repos","events_url":"https://api.github.com/users/marckysharky/events{/privacy}","received_events_url":"https://api.github.com/users/marckysharky/received_events","type":"User","site_admin":false},"repo":{"id":25160667,"name":"flamsteed","full_name":"marckysharky/flamsteed","owner":{"login":"marckysharky","id":144170,"avatar_url":"https://avatars.githubusercontent.com/u/144170?v=2","gravatar_id":"","url":"https://api.github.com/users/marckysharky","html_url":"https://github.com/marckysharky","followers_url":"https://api.github.com/users/marckysharky/followers","following_url":"https://api.github.com/users/marckysharky/following{/other_user}","gists_url":"https://api.github.com/users/marckysharky/gists{/gist_id}","starred_url":"https://api.github.com/users/marckysharky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marckysharky/subscriptions","organizations_url":"https://api.github.com/users/marckysharky/orgs","repos_url":"https://api.github.com/users/marckysharky/repos","events_url":"https://api.github.com/users/marckysharky/events{/privacy}","received_events_url":"https://api.github.com/users/marckysharky/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marckysharky/flamsteed","description":"flamsteed is a simple event-logging pipeline. Use it for RUM (real-user monitoring) and click-tracking.","fork":true,"url":"https://api.github.com/repos/marckysharky/flamsteed","forks_url":"https://api.github.com/repos/marckysharky/flamsteed/forks","keys_url":"https://api.github.com/repos/marckysharky/flamsteed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marckysharky/flamsteed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marckysharky/flamsteed/teams","hooks_url":"https://api.github.com/repos/marckysharky/flamsteed/hooks","issue_events_url":"https://api.github.com/repos/marckysharky/flamsteed/issues/events{/number}","events_url":"https://api.github.com/repos/marckysharky/flamsteed/events","assignees_url":"https://api.github.com/repos/marckysharky/flamsteed/assignees{/user}","branches_url":"https://api.github.com/repos/marckysharky/flamsteed/branches{/branch}","tags_url":"https://api.github.com/repos/marckysharky/flamsteed/tags","blobs_url":"https://api.github.com/repos/marckysharky/flamsteed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marckysharky/flamsteed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marckysharky/flamsteed/git/refs{/sha}","trees_url":"https://api.github.com/repos/marckysharky/flamsteed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marckysharky/flamsteed/statuses/{sha}","languages_url":"https://api.github.com/repos/marckysharky/flamsteed/languages","stargazers_url":"https://api.github.com/repos/marckysharky/flamsteed/stargazers","contributors_url":"https://api.github.com/repos/marckysharky/flamsteed/contributors","subscribers_url":"https://api.github.com/repos/marckysharky/flamsteed/subscribers","subscription_url":"https://api.github.com/repos/marckysharky/flamsteed/subscription","commits_url":"https://api.github.com/repos/marckysharky/flamsteed/commits{/sha}","git_commits_url":"https://api.github.com/repos/marckysharky/flamsteed/git/commits{/sha}","comments_url":"https://api.github.com/repos/marckysharky/flamsteed/comments{/number}","issue_comment_url":"https://api.github.com/repos/marckysharky/flamsteed/issues/comments/{number}","contents_url":"https://api.github.com/repos/marckysharky/flamsteed/contents/{+path}","compare_url":"https://api.github.com/repos/marckysharky/flamsteed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marckysharky/flamsteed/merges","archive_url":"https://api.github.com/repos/marckysharky/flamsteed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marckysharky/flamsteed/downloads","issues_url":"https://api.github.com/repos/marckysharky/flamsteed/issues{/number}","pulls_url":"https://api.github.com/repos/marckysharky/flamsteed/pulls{/number}","milestones_url":"https://api.github.com/repos/marckysharky/flamsteed/milestones{/number}","notifications_url":"https://api.github.com/repos/marckysharky/flamsteed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marckysharky/flamsteed/labels{/name}","releases_url":"https://api.github.com/repos/marckysharky/flamsteed/releases{/id}","created_at":"2014-10-13T13:53:38Z","updated_at":"2014-10-13T15:16:54Z","pushed_at":"2014-10-14T12:01:57Z","git_url":"git://github.com/marckysharky/flamsteed.git","ssh_url":"git@github.com:marckysharky/flamsteed.git","clone_url":"https://github.com/marckysharky/flamsteed.git","svn_url":"https://github.com/marckysharky/flamsteed","homepage":null,"size":156,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lonelyplanet:master","ref":"master","sha":"84db7549d33974666108013d21204c2db49c67eb","user":{"login":"lonelyplanet","id":114767,"avatar_url":"https://avatars.githubusercontent.com/u/114767?v=2","gravatar_id":"","url":"https://api.github.com/users/lonelyplanet","html_url":"https://github.com/lonelyplanet","followers_url":"https://api.github.com/users/lonelyplanet/followers","following_url":"https://api.github.com/users/lonelyplanet/following{/other_user}","gists_url":"https://api.github.com/users/lonelyplanet/gists{/gist_id}","starred_url":"https://api.github.com/users/lonelyplanet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lonelyplanet/subscriptions","organizations_url":"https://api.github.com/users/lonelyplanet/orgs","repos_url":"https://api.github.com/users/lonelyplanet/repos","events_url":"https://api.github.com/users/lonelyplanet/events{/privacy}","received_events_url":"https://api.github.com/users/lonelyplanet/received_events","type":"Organization","site_admin":false},"repo":{"id":6028888,"name":"flamsteed","full_name":"lonelyplanet/flamsteed","owner":{"login":"lonelyplanet","id":114767,"avatar_url":"https://avatars.githubusercontent.com/u/114767?v=2","gravatar_id":"","url":"https://api.github.com/users/lonelyplanet","html_url":"https://github.com/lonelyplanet","followers_url":"https://api.github.com/users/lonelyplanet/followers","following_url":"https://api.github.com/users/lonelyplanet/following{/other_user}","gists_url":"https://api.github.com/users/lonelyplanet/gists{/gist_id}","starred_url":"https://api.github.com/users/lonelyplanet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lonelyplanet/subscriptions","organizations_url":"https://api.github.com/users/lonelyplanet/orgs","repos_url":"https://api.github.com/users/lonelyplanet/repos","events_url":"https://api.github.com/users/lonelyplanet/events{/privacy}","received_events_url":"https://api.github.com/users/lonelyplanet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lonelyplanet/flamsteed","description":"flamsteed is a simple event-logging pipeline. Use it for RUM (real-user monitoring) and click-tracking.","fork":false,"url":"https://api.github.com/repos/lonelyplanet/flamsteed","forks_url":"https://api.github.com/repos/lonelyplanet/flamsteed/forks","keys_url":"https://api.github.com/repos/lonelyplanet/flamsteed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lonelyplanet/flamsteed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lonelyplanet/flamsteed/teams","hooks_url":"https://api.github.com/repos/lonelyplanet/flamsteed/hooks","issue_events_url":"https://api.github.com/repos/lonelyplanet/flamsteed/issues/events{/number}","events_url":"https://api.github.com/repos/lonelyplanet/flamsteed/events","assignees_url":"https://api.github.com/repos/lonelyplanet/flamsteed/assignees{/user}","branches_url":"https://api.github.com/repos/lonelyplanet/flamsteed/branches{/branch}","tags_url":"https://api.github.com/repos/lonelyplanet/flamsteed/tags","blobs_url":"https://api.github.com/repos/lonelyplanet/flamsteed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lonelyplanet/flamsteed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lonelyplanet/flamsteed/git/refs{/sha}","trees_url":"https://api.github.com/repos/lonelyplanet/flamsteed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lonelyplanet/flamsteed/statuses/{sha}","languages_url":"https://api.github.com/repos/lonelyplanet/flamsteed/languages","stargazers_url":"https://api.github.com/repos/lonelyplanet/flamsteed/stargazers","contributors_url":"https://api.github.com/repos/lonelyplanet/flamsteed/contributors","subscribers_url":"https://api.github.com/repos/lonelyplanet/flamsteed/subscribers","subscription_url":"https://api.github.com/repos/lonelyplanet/flamsteed/subscription","commits_url":"https://api.github.com/repos/lonelyplanet/flamsteed/commits{/sha}","git_commits_url":"https://api.github.com/repos/lonelyplanet/flamsteed/git/commits{/sha}","comments_url":"https://api.github.com/repos/lonelyplanet/flamsteed/comments{/number}","issue_comment_url":"https://api.github.com/repos/lonelyplanet/flamsteed/issues/comments/{number}","contents_url":"https://api.github.com/repos/lonelyplanet/flamsteed/contents/{+path}","compare_url":"https://api.github.com/repos/lonelyplanet/flamsteed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lonelyplanet/flamsteed/merges","archive_url":"https://api.github.com/repos/lonelyplanet/flamsteed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lonelyplanet/flamsteed/downloads","issues_url":"https://api.github.com/repos/lonelyplanet/flamsteed/issues{/number}","pulls_url":"https://api.github.com/repos/lonelyplanet/flamsteed/pulls{/number}","milestones_url":"https://api.github.com/repos/lonelyplanet/flamsteed/milestones{/number}","notifications_url":"https://api.github.com/repos/lonelyplanet/flamsteed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lonelyplanet/flamsteed/labels{/name}","releases_url":"https://api.github.com/repos/lonelyplanet/flamsteed/releases{/id}","created_at":"2012-10-01T11:29:56Z","updated_at":"2014-06-06T08:46:02Z","pushed_at":"2014-01-03T15:49:11Z","git_url":"git://github.com/lonelyplanet/flamsteed.git","ssh_url":"git@github.com:lonelyplanet/flamsteed.git","clone_url":"https://github.com/lonelyplanet/flamsteed.git","svn_url":"https://github.com/lonelyplanet/flamsteed","homepage":null,"size":295,"stargazers_count":5,"watchers_count":5,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lonelyplanet/flamsteed/pulls/9"},"html":{"href":"https://github.com/lonelyplanet/flamsteed/pull/9"},"issue":{"href":"https://api.github.com/repos/lonelyplanet/flamsteed/issues/9"},"comments":{"href":"https://api.github.com/repos/lonelyplanet/flamsteed/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/lonelyplanet/flamsteed/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/lonelyplanet/flamsteed/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/lonelyplanet/flamsteed/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/lonelyplanet/flamsteed/statuses/b0c15e4832985d643e22443597229b68677b392e"}}}}