GitHub PullRequestReviewCommentEvent at 2014-11-02 16:42:29
Repository: citra
Actor: neobrain
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/comments/19713045","id":19713045,"diff_hunk":"@@ -136,6 +136,42 @@ void OpenFileDirectly(Service::Interface* self) {\n     DEBUG_LOG(KERNEL, \"called\");\n }\n \n+/*\n+ * FS_User::CreateDirectory service function\n+ *  Inputs:\n+ *      2 : Archive handle lower word\n+ *      3 : Archive handle upper word\n+ *      4 : Directory path string type\n+ *      5 : Directory path string size\n+ *      8 : Directory path string data\n+ *  Outputs:\n+ *      1 : Result of function, 0 on success, otherwise error code\n+ */\n+void CreateDirectory(Service::Interface* self) {\n+    u32* cmd_buff = Service::GetCommandBuffer();\n+\n+    // TODO: cmd_buff[2], aka archive handle lower word, isn't used according to\n+    // 3dmoo's or ctrulib's implementations.  Triple check if it's really the case.\n+    Handle archive_handle = static_cast<Handle>(cmd_buff[3]);","path":"src/core/hle/service/fs_user.cpp","position":29,"original_position":29,"commit_id":"9243e3afee4349e9ced78a2434f1d122f1cb177c","original_commit_id":"9243e3afee4349e9ced78a2434f1d122f1cb177c","user":{"login":"neobrain","id":4840017,"avatar_url":"https://avatars.githubusercontent.com/u/4840017?v=2","gravatar_id":"","url":"https://api.github.com/users/neobrain","html_url":"https://github.com/neobrain","followers_url":"https://api.github.com/users/neobrain/followers","following_url":"https://api.github.com/users/neobrain/following{/other_user}","gists_url":"https://api.github.com/users/neobrain/gists{/gist_id}","starred_url":"https://api.github.com/users/neobrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neobrain/subscriptions","organizations_url":"https://api.github.com/users/neobrain/orgs","repos_url":"https://api.github.com/users/neobrain/repos","events_url":"https://api.github.com/users/neobrain/events{/privacy}","received_events_url":"https://api.github.com/users/neobrain/received_events","type":"User","site_admin":false},"body":"Probably a stupid question, but why does it say that `cmd_buff[3]` is the upper word, yet you seem to use it as the lower word? (Maybe I'm misunderstanding what \"upper\" and \"lower\" are supposed to mean in this context? Thinking along the lines of least/most significant bits here..)","created_at":"2014-11-02T16:42:29Z","updated_at":"2014-11-02T16:42:29Z","html_url":"https://github.com/citra-emu/citra/pull/163#discussion_r19713045","pull_request_url":"https://api.github.com/repos/citra-emu/citra/pulls/163","_links":{"self":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/comments/19713045"},"html":{"href":"https://github.com/citra-emu/citra/pull/163#discussion_r19713045"},"pull_request":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/163"}}},"pull_request":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/163","id":23578634,"html_url":"https://github.com/citra-emu/citra/pull/163","diff_url":"https://github.com/citra-emu/citra/pull/163.diff","patch_url":"https://github.com/citra-emu/citra/pull/163.patch","issue_url":"https://api.github.com/repos/citra-emu/citra/issues/163","number":163,"state":"open","locked":false,"title":"Added CreateDirectory function to service/fs.cpp, and in Archive.","user":{"login":"archshift","id":5377832,"avatar_url":"https://avatars.githubusercontent.com/u/5377832?v=2","gravatar_id":"","url":"https://api.github.com/users/archshift","html_url":"https://github.com/archshift","followers_url":"https://api.github.com/users/archshift/followers","following_url":"https://api.github.com/users/archshift/following{/other_user}","gists_url":"https://api.github.com/users/archshift/gists{/gist_id}","starred_url":"https://api.github.com/users/archshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/archshift/subscriptions","organizations_url":"https://api.github.com/users/archshift/orgs","repos_url":"https://api.github.com/users/archshift/repos","events_url":"https://api.github.com/users/archshift/events{/privacy}","received_events_url":"https://api.github.com/users/archshift/received_events","type":"User","site_admin":false},"body":"What I used to test: https://github.com/archshift/ctru-test","created_at":"2014-10-30T02:09:38Z","updated_at":"2014-11-02T16:42:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d8451ab2b8c805aa2485d38b9923454cadb36ccf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/citra-emu/citra/pulls/163/commits","review_comments_url":"https://api.github.com/repos/citra-emu/citra/pulls/163/comments","review_comment_url":"https://api.github.com/repos/citra-emu/citra/pulls/comments/{number}","comments_url":"https://api.github.com/repos/citra-emu/citra/issues/163/comments","statuses_url":"https://api.github.com/repos/citra-emu/citra/statuses/9243e3afee4349e9ced78a2434f1d122f1cb177c","head":{"label":"archshift:create-directory","ref":"create-directory","sha":"9243e3afee4349e9ced78a2434f1d122f1cb177c","user":{"login":"archshift","id":5377832,"avatar_url":"https://avatars.githubusercontent.com/u/5377832?v=2","gravatar_id":"","url":"https://api.github.com/users/archshift","html_url":"https://github.com/archshift","followers_url":"https://api.github.com/users/archshift/followers","following_url":"https://api.github.com/users/archshift/following{/other_user}","gists_url":"https://api.github.com/users/archshift/gists{/gist_id}","starred_url":"https://api.github.com/users/archshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/archshift/subscriptions","organizations_url":"https://api.github.com/users/archshift/orgs","repos_url":"https://api.github.com/users/archshift/repos","events_url":"https://api.github.com/users/archshift/events{/privacy}","received_events_url":"https://api.github.com/users/archshift/received_events","type":"User","site_admin":false},"repo":{"id":19927346,"name":"citra","full_name":"archshift/citra","owner":{"login":"archshift","id":5377832,"avatar_url":"https://avatars.githubusercontent.com/u/5377832?v=2","gravatar_id":"","url":"https://api.github.com/users/archshift","html_url":"https://github.com/archshift","followers_url":"https://api.github.com/users/archshift/followers","following_url":"https://api.github.com/users/archshift/following{/other_user}","gists_url":"https://api.github.com/users/archshift/gists{/gist_id}","starred_url":"https://api.github.com/users/archshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/archshift/subscriptions","organizations_url":"https://api.github.com/users/archshift/orgs","repos_url":"https://api.github.com/users/archshift/repos","events_url":"https://api.github.com/users/archshift/events{/privacy}","received_events_url":"https://api.github.com/users/archshift/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/archshift/citra","description":"Nintendo 3DS emulator/debugger","fork":true,"url":"https://api.github.com/repos/archshift/citra","forks_url":"https://api.github.com/repos/archshift/citra/forks","keys_url":"https://api.github.com/repos/archshift/citra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/archshift/citra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/archshift/citra/teams","hooks_url":"https://api.github.com/repos/archshift/citra/hooks","issue_events_url":"https://api.github.com/repos/archshift/citra/issues/events{/number}","events_url":"https://api.github.com/repos/archshift/citra/events","assignees_url":"https://api.github.com/repos/archshift/citra/assignees{/user}","branches_url":"https://api.github.com/repos/archshift/citra/branches{/branch}","tags_url":"https://api.github.com/repos/archshift/citra/tags","blobs_url":"https://api.github.com/repos/archshift/citra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/archshift/citra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/archshift/citra/git/refs{/sha}","trees_url":"https://api.github.com/repos/archshift/citra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/archshift/citra/statuses/{sha}","languages_url":"https://api.github.com/repos/archshift/citra/languages","stargazers_url":"https://api.github.com/repos/archshift/citra/stargazers","contributors_url":"https://api.github.com/repos/archshift/citra/contributors","subscribers_url":"https://api.github.com/repos/archshift/citra/subscribers","subscription_url":"https://api.github.com/repos/archshift/citra/subscription","commits_url":"https://api.github.com/repos/archshift/citra/commits{/sha}","git_commits_url":"https://api.github.com/repos/archshift/citra/git/commits{/sha}","comments_url":"https://api.github.com/repos/archshift/citra/comments{/number}","issue_comment_url":"https://api.github.com/repos/archshift/citra/issues/comments/{number}","contents_url":"https://api.github.com/repos/archshift/citra/contents/{+path}","compare_url":"https://api.github.com/repos/archshift/citra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/archshift/citra/merges","archive_url":"https://api.github.com/repos/archshift/citra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/archshift/citra/downloads","issues_url":"https://api.github.com/repos/archshift/citra/issues{/number}","pulls_url":"https://api.github.com/repos/archshift/citra/pulls{/number}","milestones_url":"https://api.github.com/repos/archshift/citra/milestones{/number}","notifications_url":"https://api.github.com/repos/archshift/citra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/archshift/citra/labels{/name}","releases_url":"https://api.github.com/repos/archshift/citra/releases{/id}","created_at":"2014-05-19T02:50:51Z","updated_at":"2014-08-22T22:45:21Z","pushed_at":"2014-11-02T07:30:12Z","git_url":"git://github.com/archshift/citra.git","ssh_url":"git@github.com:archshift/citra.git","clone_url":"https://github.com/archshift/citra.git","svn_url":"https://github.com/archshift/citra","homepage":null,"size":9686,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"citra-emu:master","ref":"master","sha":"01e37962e78abe2a39a5bd518fa3590a36912526","user":{"login":"citra-emu","id":7605670,"avatar_url":"https://avatars.githubusercontent.com/u/7605670?v=2","gravatar_id":"","url":"https://api.github.com/users/citra-emu","html_url":"https://github.com/citra-emu","followers_url":"https://api.github.com/users/citra-emu/followers","following_url":"https://api.github.com/users/citra-emu/following{/other_user}","gists_url":"https://api.github.com/users/citra-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/citra-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citra-emu/subscriptions","organizations_url":"https://api.github.com/users/citra-emu/orgs","repos_url":"https://api.github.com/users/citra-emu/repos","events_url":"https://api.github.com/users/citra-emu/events{/privacy}","received_events_url":"https://api.github.com/users/citra-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":19866730,"name":"citra","full_name":"citra-emu/citra","owner":{"login":"citra-emu","id":7605670,"avatar_url":"https://avatars.githubusercontent.com/u/7605670?v=2","gravatar_id":"","url":"https://api.github.com/users/citra-emu","html_url":"https://github.com/citra-emu","followers_url":"https://api.github.com/users/citra-emu/followers","following_url":"https://api.github.com/users/citra-emu/following{/other_user}","gists_url":"https://api.github.com/users/citra-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/citra-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citra-emu/subscriptions","organizations_url":"https://api.github.com/users/citra-emu/orgs","repos_url":"https://api.github.com/users/citra-emu/repos","events_url":"https://api.github.com/users/citra-emu/events{/privacy}","received_events_url":"https://api.github.com/users/citra-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/citra-emu/citra","description":"Nintendo 3DS emulator/debugger","fork":false,"url":"https://api.github.com/repos/citra-emu/citra","forks_url":"https://api.github.com/repos/citra-emu/citra/forks","keys_url":"https://api.github.com/repos/citra-emu/citra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/citra-emu/citra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/citra-emu/citra/teams","hooks_url":"https://api.github.com/repos/citra-emu/citra/hooks","issue_events_url":"https://api.github.com/repos/citra-emu/citra/issues/events{/number}","events_url":"https://api.github.com/repos/citra-emu/citra/events","assignees_url":"https://api.github.com/repos/citra-emu/citra/assignees{/user}","branches_url":"https://api.github.com/repos/citra-emu/citra/branches{/branch}","tags_url":"https://api.github.com/repos/citra-emu/citra/tags","blobs_url":"https://api.github.com/repos/citra-emu/citra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/citra-emu/citra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/citra-emu/citra/git/refs{/sha}","trees_url":"https://api.github.com/repos/citra-emu/citra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/citra-emu/citra/statuses/{sha}","languages_url":"https://api.github.com/repos/citra-emu/citra/languages","stargazers_url":"https://api.github.com/repos/citra-emu/citra/stargazers","contributors_url":"https://api.github.com/repos/citra-emu/citra/contributors","subscribers_url":"https://api.github.com/repos/citra-emu/citra/subscribers","subscription_url":"https://api.github.com/repos/citra-emu/citra/subscription","commits_url":"https://api.github.com/repos/citra-emu/citra/commits{/sha}","git_commits_url":"https://api.github.com/repos/citra-emu/citra/git/commits{/sha}","comments_url":"https://api.github.com/repos/citra-emu/citra/comments{/number}","issue_comment_url":"https://api.github.com/repos/citra-emu/citra/issues/comments/{number}","contents_url":"https://api.github.com/repos/citra-emu/citra/contents/{+path}","compare_url":"https://api.github.com/repos/citra-emu/citra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/citra-emu/citra/merges","archive_url":"https://api.github.com/repos/citra-emu/citra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/citra-emu/citra/downloads","issues_url":"https://api.github.com/repos/citra-emu/citra/issues{/number}","pulls_url":"https://api.github.com/repos/citra-emu/citra/pulls{/number}","milestones_url":"https://api.github.com/repos/citra-emu/citra/milestones{/number}","notifications_url":"https://api.github.com/repos/citra-emu/citra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/citra-emu/citra/labels{/name}","releases_url":"https://api.github.com/repos/citra-emu/citra/releases{/id}","created_at":"2014-05-16T18:33:15Z","updated_at":"2014-11-02T07:52:10Z","pushed_at":"2014-11-02T03:43:52Z","git_url":"git://github.com/citra-emu/citra.git","ssh_url":"git@github.com:citra-emu/citra.git","clone_url":"https://github.com/citra-emu/citra.git","svn_url":"https://github.com/citra-emu/citra","homepage":null,"size":14320,"stargazers_count":262,"watchers_count":262,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":70,"mirror_url":null,"open_issues_count":36,"forks":70,"open_issues":36,"watchers":262,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/163"},"html":{"href":"https://github.com/citra-emu/citra/pull/163"},"issue":{"href":"https://api.github.com/repos/citra-emu/citra/issues/163"},"comments":{"href":"https://api.github.com/repos/citra-emu/citra/issues/163/comments"},"review_comments":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/163/comments"},"review_comment":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/163/commits"},"statuses":{"href":"https://api.github.com/repos/citra-emu/citra/statuses/9243e3afee4349e9ced78a2434f1d122f1cb177c"}}}}