GitHub PullRequestEvent at 2014-05-20 21:51:54
Repository: puppet
Actor: relud
Payload: {"action":"opened","number":2678,"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/2678","id":16134512,"html_url":"https://github.com/puppetlabs/puppet/pull/2678","diff_url":"https://github.com/puppetlabs/puppet/pull/2678.diff","patch_url":"https://github.com/puppetlabs/puppet/pull/2678.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppet/issues/2678","number":2678,"state":"open","title":"Accept module paths in Puppet::Parser::Function.file()","user":{"login":"relud","id":433717,"avatar_url":"https://avatars.githubusercontent.com/u/433717?","gravatar_id":"d86a487bbd357d6defcb9d4b31f08c5e","url":"https://api.github.com/users/relud","html_url":"https://github.com/relud","followers_url":"https://api.github.com/users/relud/followers","following_url":"https://api.github.com/users/relud/following{/other_user}","gists_url":"https://api.github.com/users/relud/gists{/gist_id}","starred_url":"https://api.github.com/users/relud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/relud/subscriptions","organizations_url":"https://api.github.com/users/relud/orgs","repos_url":"https://api.github.com/users/relud/repos","events_url":"https://api.github.com/users/relud/events{/privacy}","received_events_url":"https://api.github.com/users/relud/received_events","type":"User","site_admin":false},"body":"Summary\r\n---\r\n\r\nThis modifies the <code>file()</code> function to accept module paths (like the <code>template()</code> function) as well as fully qualified paths.\r\n\r\nExample\r\n---\r\nwith directory structure:\r\n<pre>\r\n/etc/puppet/modules/example\r\n├── files\r\n│   └──file.ext\r\n├── manifests\r\n│   └──init.pp\r\n└── templates\r\n    └──template.erb\r\n</pre>\r\n\r\nWhen the module path for files can be used instead of the absolute path:\r\n\r\n<code>file('example/file.ext')</code> returns the same as <code>file('/etc/puppet/modules/example/files/file.ext')</code>.\r\n\r\nThis is supposed to be like how template does module paths, where: \r\n\r\n<code>template('example/template.erb')</code> returns the same as <code>template('/etc/puppet/modules/example/templates/template.erb')</code>\r\n\r\nWhy\r\n---\r\n\r\nThis would make it possible for modules that use the <code>file()</code> function to be more portable, instead of being tied to a specific puppet server configuration.","created_at":"2014-05-20T21:51:53Z","updated_at":"2014-05-20T21:51:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/2678/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/2678/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/{number}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/issues/2678/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/dea39fcf1f771675f13f88a19a7f79dcbe320a4f","head":{"label":"relud:improve_parser_file_function","ref":"improve_parser_file_function","sha":"dea39fcf1f771675f13f88a19a7f79dcbe320a4f","user":{"login":"relud","id":433717,"avatar_url":"https://avatars.githubusercontent.com/u/433717?","gravatar_id":"d86a487bbd357d6defcb9d4b31f08c5e","url":"https://api.github.com/users/relud","html_url":"https://github.com/relud","followers_url":"https://api.github.com/users/relud/followers","following_url":"https://api.github.com/users/relud/following{/other_user}","gists_url":"https://api.github.com/users/relud/gists{/gist_id}","starred_url":"https://api.github.com/users/relud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/relud/subscriptions","organizations_url":"https://api.github.com/users/relud/orgs","repos_url":"https://api.github.com/users/relud/repos","events_url":"https://api.github.com/users/relud/events{/privacy}","received_events_url":"https://api.github.com/users/relud/received_events","type":"User","site_admin":false},"repo":{"id":19997710,"name":"puppet","full_name":"relud/puppet","owner":{"login":"relud","id":433717,"avatar_url":"https://avatars.githubusercontent.com/u/433717?","gravatar_id":"d86a487bbd357d6defcb9d4b31f08c5e","url":"https://api.github.com/users/relud","html_url":"https://github.com/relud","followers_url":"https://api.github.com/users/relud/followers","following_url":"https://api.github.com/users/relud/following{/other_user}","gists_url":"https://api.github.com/users/relud/gists{/gist_id}","starred_url":"https://api.github.com/users/relud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/relud/subscriptions","organizations_url":"https://api.github.com/users/relud/orgs","repos_url":"https://api.github.com/users/relud/repos","events_url":"https://api.github.com/users/relud/events{/privacy}","received_events_url":"https://api.github.com/users/relud/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/relud/puppet","description":"Server automation framework and application","fork":true,"url":"https://api.github.com/repos/relud/puppet","forks_url":"https://api.github.com/repos/relud/puppet/forks","keys_url":"https://api.github.com/repos/relud/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/relud/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/relud/puppet/teams","hooks_url":"https://api.github.com/repos/relud/puppet/hooks","issue_events_url":"https://api.github.com/repos/relud/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/relud/puppet/events","assignees_url":"https://api.github.com/repos/relud/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/relud/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/relud/puppet/tags","blobs_url":"https://api.github.com/repos/relud/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/relud/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/relud/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/relud/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/relud/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/relud/puppet/languages","stargazers_url":"https://api.github.com/repos/relud/puppet/stargazers","contributors_url":"https://api.github.com/repos/relud/puppet/contributors","subscribers_url":"https://api.github.com/repos/relud/puppet/subscribers","subscription_url":"https://api.github.com/repos/relud/puppet/subscription","commits_url":"https://api.github.com/repos/relud/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/relud/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/relud/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/relud/puppet/issues/comments/{number}","contents_url":"https://api.github.com/repos/relud/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/relud/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/relud/puppet/merges","archive_url":"https://api.github.com/repos/relud/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/relud/puppet/downloads","issues_url":"https://api.github.com/repos/relud/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/relud/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/relud/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/relud/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/relud/puppet/labels{/name}","releases_url":"https://api.github.com/repos/relud/puppet/releases{/id}","created_at":"2014-05-20T21:10:56Z","updated_at":"2014-05-20T21:51:53Z","pushed_at":"2014-05-20T21:47:58Z","git_url":"git://github.com/relud/puppet.git","ssh_url":"git@github.com:relud/puppet.git","clone_url":"https://github.com/relud/puppet.git","svn_url":"https://github.com/relud/puppet","homepage":"http://www.puppetlabs.com/puppet/introduction/","size":95016,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"9d8afc3395ef45dd83425064f8f38913f50b50c4","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?","gravatar_id":"eb454c2139c156db7c8266a875519a1f","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":910744,"name":"puppet","full_name":"puppetlabs/puppet","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?","gravatar_id":"eb454c2139c156db7c8266a875519a1f","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppet","description":"Server automation framework and application","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppet","forks_url":"https://api.github.com/repos/puppetlabs/puppet/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppet/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppet/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppet/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppet/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppet/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppet/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppet/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppet/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppet/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppet/issues/comments/{number}","contents_url":"https://api.github.com/repos/puppetlabs/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppet/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppet/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppet/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppet/releases{/id}","created_at":"2010-09-14T19:26:44Z","updated_at":"2014-05-20T21:07:52Z","pushed_at":"2014-05-20T16:50:47Z","git_url":"git://github.com/puppetlabs/puppet.git","ssh_url":"git@github.com:puppetlabs/puppet.git","clone_url":"https://github.com/puppetlabs/puppet.git","svn_url":"https://github.com/puppetlabs/puppet","homepage":"http://www.puppetlabs.com/puppet/introduction/","size":95016,"stargazers_count":2198,"watchers_count":2198,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":982,"mirror_url":null,"open_issues_count":45,"forks":982,"open_issues":45,"watchers":2198,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/2678"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/2678"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/2678"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/2678/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/2678/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/2678/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppet/statuses/dea39fcf1f771675f13f88a19a7f79dcbe320a4f"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":109,"deletions":8,"changed_files":4}}