GitHub PullRequestReviewCommentEvent at 2014-09-12 20:59:06
Repository: pandas
Actor: jorisvandenbossche
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/pydata/pandas/pulls/comments/17502296","id":17502296,"diff_hunk":"@@ -1571,7 +1587,7 @@ def test_schema(self):\n         frame = tm.makeTimeDataFrame()\n         create_sql = sql.get_schema(frame, 'test', 'sqlite', keys=['A', 'B'],)\n         lines = create_sql.splitlines()\n-        self.assertTrue('PRIMARY KEY (A,B)' in create_sql)\n+        self.assertTrue('PRIMARY KEY ([A],[B])' in create_sql)","path":"pandas/io/tests/test_sql.py","position":53,"original_position":53,"commit_id":"0497b3f3b5e203e8585504f07cf6cf35f611dc77","original_commit_id":"0497b3f3b5e203e8585504f07cf6cf35f611dc77","user":{"login":"jorisvandenbossche","id":1020496,"avatar_url":"https://avatars.githubusercontent.com/u/1020496?v=2","gravatar_id":"7a7a675bc479a30c1389d4c64f612a95","url":"https://api.github.com/users/jorisvandenbossche","html_url":"https://github.com/jorisvandenbossche","followers_url":"https://api.github.com/users/jorisvandenbossche/followers","following_url":"https://api.github.com/users/jorisvandenbossche/following{/other_user}","gists_url":"https://api.github.com/users/jorisvandenbossche/gists{/gist_id}","starred_url":"https://api.github.com/users/jorisvandenbossche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorisvandenbossche/subscriptions","organizations_url":"https://api.github.com/users/jorisvandenbossche/orgs","repos_url":"https://api.github.com/users/jorisvandenbossche/repos","events_url":"https://api.github.com/users/jorisvandenbossche/events{/privacy}","received_events_url":"https://api.github.com/users/jorisvandenbossche/received_events","type":"User","site_admin":false},"body":"Was this not working? (I mean, the tests passed now. Is there a reason they don't pass anymore?","created_at":"2014-09-12T20:59:06Z","updated_at":"2014-09-12T20:59:06Z","html_url":"https://github.com/pydata/pandas/pull/8232#discussion_r17502296","pull_request_url":"https://api.github.com/repos/pydata/pandas/pulls/8232","_links":{"self":{"href":"https://api.github.com/repos/pydata/pandas/pulls/comments/17502296"},"html":{"href":"https://github.com/pydata/pandas/pull/8232#discussion_r17502296"},"pull_request":{"href":"https://api.github.com/repos/pydata/pandas/pulls/8232"}}},"pull_request":{"url":"https://api.github.com/repos/pydata/pandas/pulls/8232","id":20998529,"html_url":"https://github.com/pydata/pandas/pull/8232","diff_url":"https://github.com/pydata/pandas/pull/8232.diff","patch_url":"https://github.com/pydata/pandas/pull/8232.patch","issue_url":"https://api.github.com/repos/pydata/pandas/issues/8232","number":8232,"state":"open","locked":false,"title":"Fix to merge code from `_create_table_statement` and `get_schema`","user":{"login":"artemyk","id":833768,"avatar_url":"https://avatars.githubusercontent.com/u/833768?v=2","gravatar_id":"6fddb56860f309424672985416cf923b","url":"https://api.github.com/users/artemyk","html_url":"https://github.com/artemyk","followers_url":"https://api.github.com/users/artemyk/followers","following_url":"https://api.github.com/users/artemyk/following{/other_user}","gists_url":"https://api.github.com/users/artemyk/gists{/gist_id}","starred_url":"https://api.github.com/users/artemyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artemyk/subscriptions","organizations_url":"https://api.github.com/users/artemyk/orgs","repos_url":"https://api.github.com/users/artemyk/repos","events_url":"https://api.github.com/users/artemyk/events{/privacy}","received_events_url":"https://api.github.com/users/artemyk/received_events","type":"User","site_admin":false},"body":"Reorganized a lot of the SQL schema creation code.  Now database table is not dropped / create when `PandasSQLTable` object is instantiated, but instead when `insert` method is called on it.  This allow us to `get_schema` to generate `CREATE TABLE` code without actually creating the table.\r\n(Includes updates from #8083, so will have to be rebased when that is merged)","created_at":"2014-09-10T04:16:17Z","updated_at":"2014-09-12T20:59:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9b52f751ff2825a017df625ccf75d5effc1fc980","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pydata/pandas/pulls/8232/commits","review_comments_url":"https://api.github.com/repos/pydata/pandas/pulls/8232/comments","review_comment_url":"https://api.github.com/repos/pydata/pandas/pulls/comments/{number}","comments_url":"https://api.github.com/repos/pydata/pandas/issues/8232/comments","statuses_url":"https://api.github.com/repos/pydata/pandas/statuses/0497b3f3b5e203e8585504f07cf6cf35f611dc77","head":{"label":"artemyk:get_schema_fix","ref":"get_schema_fix","sha":"0497b3f3b5e203e8585504f07cf6cf35f611dc77","user":{"login":"artemyk","id":833768,"avatar_url":"https://avatars.githubusercontent.com/u/833768?v=2","gravatar_id":"6fddb56860f309424672985416cf923b","url":"https://api.github.com/users/artemyk","html_url":"https://github.com/artemyk","followers_url":"https://api.github.com/users/artemyk/followers","following_url":"https://api.github.com/users/artemyk/following{/other_user}","gists_url":"https://api.github.com/users/artemyk/gists{/gist_id}","starred_url":"https://api.github.com/users/artemyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artemyk/subscriptions","organizations_url":"https://api.github.com/users/artemyk/orgs","repos_url":"https://api.github.com/users/artemyk/repos","events_url":"https://api.github.com/users/artemyk/events{/privacy}","received_events_url":"https://api.github.com/users/artemyk/received_events","type":"User","site_admin":false},"repo":{"id":22944445,"name":"pandas","full_name":"artemyk/pandas","owner":{"login":"artemyk","id":833768,"avatar_url":"https://avatars.githubusercontent.com/u/833768?v=2","gravatar_id":"6fddb56860f309424672985416cf923b","url":"https://api.github.com/users/artemyk","html_url":"https://github.com/artemyk","followers_url":"https://api.github.com/users/artemyk/followers","following_url":"https://api.github.com/users/artemyk/following{/other_user}","gists_url":"https://api.github.com/users/artemyk/gists{/gist_id}","starred_url":"https://api.github.com/users/artemyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artemyk/subscriptions","organizations_url":"https://api.github.com/users/artemyk/orgs","repos_url":"https://api.github.com/users/artemyk/repos","events_url":"https://api.github.com/users/artemyk/events{/privacy}","received_events_url":"https://api.github.com/users/artemyk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/artemyk/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":true,"url":"https://api.github.com/repos/artemyk/pandas","forks_url":"https://api.github.com/repos/artemyk/pandas/forks","keys_url":"https://api.github.com/repos/artemyk/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artemyk/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artemyk/pandas/teams","hooks_url":"https://api.github.com/repos/artemyk/pandas/hooks","issue_events_url":"https://api.github.com/repos/artemyk/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/artemyk/pandas/events","assignees_url":"https://api.github.com/repos/artemyk/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/artemyk/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/artemyk/pandas/tags","blobs_url":"https://api.github.com/repos/artemyk/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artemyk/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artemyk/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/artemyk/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artemyk/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/artemyk/pandas/languages","stargazers_url":"https://api.github.com/repos/artemyk/pandas/stargazers","contributors_url":"https://api.github.com/repos/artemyk/pandas/contributors","subscribers_url":"https://api.github.com/repos/artemyk/pandas/subscribers","subscription_url":"https://api.github.com/repos/artemyk/pandas/subscription","commits_url":"https://api.github.com/repos/artemyk/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/artemyk/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/artemyk/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/artemyk/pandas/issues/comments/{number}","contents_url":"https://api.github.com/repos/artemyk/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/artemyk/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artemyk/pandas/merges","archive_url":"https://api.github.com/repos/artemyk/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artemyk/pandas/downloads","issues_url":"https://api.github.com/repos/artemyk/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/artemyk/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/artemyk/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/artemyk/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artemyk/pandas/labels{/name}","releases_url":"https://api.github.com/repos/artemyk/pandas/releases{/id}","created_at":"2014-08-14T07:02:03Z","updated_at":"2014-08-15T19:39:55Z","pushed_at":"2014-09-12T04:06:35Z","git_url":"git://github.com/artemyk/pandas.git","ssh_url":"git@github.com:artemyk/pandas.git","clone_url":"https://github.com/artemyk/pandas.git","svn_url":"https://github.com/artemyk/pandas","homepage":"http://pandas.pydata.org","size":37002,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pydata:master","ref":"master","sha":"54678dd9b0d86cf8b7cf2b6682c614d8a8287708","user":{"login":"pydata","id":1284191,"avatar_url":"https://avatars.githubusercontent.com/u/1284191?v=2","gravatar_id":"0b41e491d21e0e2e054d9c1b2d72ad59","url":"https://api.github.com/users/pydata","html_url":"https://github.com/pydata","followers_url":"https://api.github.com/users/pydata/followers","following_url":"https://api.github.com/users/pydata/following{/other_user}","gists_url":"https://api.github.com/users/pydata/gists{/gist_id}","starred_url":"https://api.github.com/users/pydata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pydata/subscriptions","organizations_url":"https://api.github.com/users/pydata/orgs","repos_url":"https://api.github.com/users/pydata/repos","events_url":"https://api.github.com/users/pydata/events{/privacy}","received_events_url":"https://api.github.com/users/pydata/received_events","type":"Organization","site_admin":false},"repo":{"id":858127,"name":"pandas","full_name":"pydata/pandas","owner":{"login":"pydata","id":1284191,"avatar_url":"https://avatars.githubusercontent.com/u/1284191?v=2","gravatar_id":"0b41e491d21e0e2e054d9c1b2d72ad59","url":"https://api.github.com/users/pydata","html_url":"https://github.com/pydata","followers_url":"https://api.github.com/users/pydata/followers","following_url":"https://api.github.com/users/pydata/following{/other_user}","gists_url":"https://api.github.com/users/pydata/gists{/gist_id}","starred_url":"https://api.github.com/users/pydata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pydata/subscriptions","organizations_url":"https://api.github.com/users/pydata/orgs","repos_url":"https://api.github.com/users/pydata/repos","events_url":"https://api.github.com/users/pydata/events{/privacy}","received_events_url":"https://api.github.com/users/pydata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pydata/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":false,"url":"https://api.github.com/repos/pydata/pandas","forks_url":"https://api.github.com/repos/pydata/pandas/forks","keys_url":"https://api.github.com/repos/pydata/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pydata/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pydata/pandas/teams","hooks_url":"https://api.github.com/repos/pydata/pandas/hooks","issue_events_url":"https://api.github.com/repos/pydata/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/pydata/pandas/events","assignees_url":"https://api.github.com/repos/pydata/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/pydata/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/pydata/pandas/tags","blobs_url":"https://api.github.com/repos/pydata/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pydata/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pydata/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/pydata/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pydata/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/pydata/pandas/languages","stargazers_url":"https://api.github.com/repos/pydata/pandas/stargazers","contributors_url":"https://api.github.com/repos/pydata/pandas/contributors","subscribers_url":"https://api.github.com/repos/pydata/pandas/subscribers","subscription_url":"https://api.github.com/repos/pydata/pandas/subscription","commits_url":"https://api.github.com/repos/pydata/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/pydata/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/pydata/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/pydata/pandas/issues/comments/{number}","contents_url":"https://api.github.com/repos/pydata/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/pydata/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pydata/pandas/merges","archive_url":"https://api.github.com/repos/pydata/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pydata/pandas/downloads","issues_url":"https://api.github.com/repos/pydata/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/pydata/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/pydata/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/pydata/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pydata/pandas/labels{/name}","releases_url":"https://api.github.com/repos/pydata/pandas/releases{/id}","created_at":"2010-08-24T01:37:33Z","updated_at":"2014-09-12T17:31:45Z","pushed_at":"2014-09-12T17:19:35Z","git_url":"git://github.com/pydata/pandas.git","ssh_url":"git@github.com:pydata/pandas.git","clone_url":"https://github.com/pydata/pandas.git","svn_url":"https://github.com/pydata/pandas","homepage":"http://pandas.pydata.org","size":90640,"stargazers_count":3353,"watchers_count":3353,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1109,"mirror_url":null,"open_issues_count":1034,"forks":1109,"open_issues":1034,"watchers":3353,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pydata/pandas/pulls/8232"},"html":{"href":"https://github.com/pydata/pandas/pull/8232"},"issue":{"href":"https://api.github.com/repos/pydata/pandas/issues/8232"},"comments":{"href":"https://api.github.com/repos/pydata/pandas/issues/8232/comments"},"review_comments":{"href":"https://api.github.com/repos/pydata/pandas/pulls/8232/comments"},"review_comment":{"href":"https://api.github.com/repos/pydata/pandas/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/pydata/pandas/pulls/8232/commits"},"statuses":{"href":"https://api.github.com/repos/pydata/pandas/statuses/0497b3f3b5e203e8585504f07cf6cf35f611dc77"}}}}