GitHub PullRequestEvent at 2014-08-19 07:01:28
Repository: zf1
Actor: froschdesign
Payload: {"action":"closed","number":418,"pull_request":{"url":"https://api.github.com/repos/zendframework/zf1/pulls/418","id":19925546,"html_url":"https://github.com/zendframework/zf1/pull/418","diff_url":"https://github.com/zendframework/zf1/pull/418.diff","patch_url":"https://github.com/zendframework/zf1/pull/418.patch","issue_url":"https://api.github.com/repos/zendframework/zf1/issues/418","number":418,"state":"closed","locked":false,"title":"Improved regex for SQL group, order, from","user":{"login":"ezimuel","id":475967,"avatar_url":"https://avatars.githubusercontent.com/u/475967?v=2","gravatar_id":"d3a1203bb9b132944427746ec3eae323","url":"https://api.github.com/users/ezimuel","html_url":"https://github.com/ezimuel","followers_url":"https://api.github.com/users/ezimuel/followers","following_url":"https://api.github.com/users/ezimuel/following{/other_user}","gists_url":"https://api.github.com/users/ezimuel/gists{/gist_id}","starred_url":"https://api.github.com/users/ezimuel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezimuel/subscriptions","organizations_url":"https://api.github.com/users/ezimuel/orgs","repos_url":"https://api.github.com/users/ezimuel/repos","events_url":"https://api.github.com/users/ezimuel/events{/privacy}","received_events_url":"https://api.github.com/users/ezimuel/received_events","type":"User","site_admin":false},"body":"This is an improvement of `Zend_Db_Select` regarding the SQL regular expressions used in `oder()`, `group()` and `from()` functions. This fix is based on the feedbacks received in  `zf-security ` mailing list, about [security advisory ZF2014-04](http://framework.zend.com/security/advisory/ZF2014-04).  After some discussion, the reporters have decided that this is an application issue rather than an framework issue; however, we felt we could make the functionality more robust regardless.","created_at":"2014-08-18T15:37:49Z","updated_at":"2014-08-19T07:01:28Z","closed_at":"2014-08-19T07:01:28Z","merged_at":"2014-08-19T07:01:28Z","merge_commit_sha":"004b283f322e26cbbf5da0054de2ae56d2f963e2","assignee":null,"milestone":{"url":"https://api.github.com/repos/zendframework/zf1/milestones/5","labels_url":"https://api.github.com/repos/zendframework/zf1/milestones/5/labels","id":689520,"number":5,"title":"1.12.8","description":null,"creator":{"login":"weierophinney","id":25943,"avatar_url":"https://avatars.githubusercontent.com/u/25943?v=2","gravatar_id":"bda768a042bd034f3f8090401aa77935","url":"https://api.github.com/users/weierophinney","html_url":"https://github.com/weierophinney","followers_url":"https://api.github.com/users/weierophinney/followers","following_url":"https://api.github.com/users/weierophinney/following{/other_user}","gists_url":"https://api.github.com/users/weierophinney/gists{/gist_id}","starred_url":"https://api.github.com/users/weierophinney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weierophinney/subscriptions","organizations_url":"https://api.github.com/users/weierophinney/orgs","repos_url":"https://api.github.com/users/weierophinney/repos","events_url":"https://api.github.com/users/weierophinney/events{/privacy}","received_events_url":"https://api.github.com/users/weierophinney/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":20,"state":"open","created_at":"2014-06-12T16:23:03Z","updated_at":"2014-08-19T07:01:28Z","due_on":null},"commits_url":"https://api.github.com/repos/zendframework/zf1/pulls/418/commits","review_comments_url":"https://api.github.com/repos/zendframework/zf1/pulls/418/comments","review_comment_url":"https://api.github.com/repos/zendframework/zf1/pulls/comments/{number}","comments_url":"https://api.github.com/repos/zendframework/zf1/issues/418/comments","statuses_url":"https://api.github.com/repos/zendframework/zf1/statuses/d8785057e1d4c76600f8917c56e64edca41d6abf","head":{"label":"ezimuel:fix/select-group-from","ref":"fix/select-group-from","sha":"d8785057e1d4c76600f8917c56e64edca41d6abf","user":{"login":"ezimuel","id":475967,"avatar_url":"https://avatars.githubusercontent.com/u/475967?v=2","gravatar_id":"d3a1203bb9b132944427746ec3eae323","url":"https://api.github.com/users/ezimuel","html_url":"https://github.com/ezimuel","followers_url":"https://api.github.com/users/ezimuel/followers","following_url":"https://api.github.com/users/ezimuel/following{/other_user}","gists_url":"https://api.github.com/users/ezimuel/gists{/gist_id}","starred_url":"https://api.github.com/users/ezimuel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezimuel/subscriptions","organizations_url":"https://api.github.com/users/ezimuel/orgs","repos_url":"https://api.github.com/users/ezimuel/repos","events_url":"https://api.github.com/users/ezimuel/events{/privacy}","received_events_url":"https://api.github.com/users/ezimuel/received_events","type":"User","site_admin":false},"repo":{"id":16772290,"name":"zf1","full_name":"ezimuel/zf1","owner":{"login":"ezimuel","id":475967,"avatar_url":"https://avatars.githubusercontent.com/u/475967?v=2","gravatar_id":"d3a1203bb9b132944427746ec3eae323","url":"https://api.github.com/users/ezimuel","html_url":"https://github.com/ezimuel","followers_url":"https://api.github.com/users/ezimuel/followers","following_url":"https://api.github.com/users/ezimuel/following{/other_user}","gists_url":"https://api.github.com/users/ezimuel/gists{/gist_id}","starred_url":"https://api.github.com/users/ezimuel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezimuel/subscriptions","organizations_url":"https://api.github.com/users/ezimuel/orgs","repos_url":"https://api.github.com/users/ezimuel/repos","events_url":"https://api.github.com/users/ezimuel/events{/privacy}","received_events_url":"https://api.github.com/users/ezimuel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ezimuel/zf1","description":"Conversion of ZF1 subversion repo to git, from version 15234 forward, and only containing master and release-1.12 branches and 1.12 tags.","fork":true,"url":"https://api.github.com/repos/ezimuel/zf1","forks_url":"https://api.github.com/repos/ezimuel/zf1/forks","keys_url":"https://api.github.com/repos/ezimuel/zf1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ezimuel/zf1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ezimuel/zf1/teams","hooks_url":"https://api.github.com/repos/ezimuel/zf1/hooks","issue_events_url":"https://api.github.com/repos/ezimuel/zf1/issues/events{/number}","events_url":"https://api.github.com/repos/ezimuel/zf1/events","assignees_url":"https://api.github.com/repos/ezimuel/zf1/assignees{/user}","branches_url":"https://api.github.com/repos/ezimuel/zf1/branches{/branch}","tags_url":"https://api.github.com/repos/ezimuel/zf1/tags","blobs_url":"https://api.github.com/repos/ezimuel/zf1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ezimuel/zf1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ezimuel/zf1/git/refs{/sha}","trees_url":"https://api.github.com/repos/ezimuel/zf1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ezimuel/zf1/statuses/{sha}","languages_url":"https://api.github.com/repos/ezimuel/zf1/languages","stargazers_url":"https://api.github.com/repos/ezimuel/zf1/stargazers","contributors_url":"https://api.github.com/repos/ezimuel/zf1/contributors","subscribers_url":"https://api.github.com/repos/ezimuel/zf1/subscribers","subscription_url":"https://api.github.com/repos/ezimuel/zf1/subscription","commits_url":"https://api.github.com/repos/ezimuel/zf1/commits{/sha}","git_commits_url":"https://api.github.com/repos/ezimuel/zf1/git/commits{/sha}","comments_url":"https://api.github.com/repos/ezimuel/zf1/comments{/number}","issue_comment_url":"https://api.github.com/repos/ezimuel/zf1/issues/comments/{number}","contents_url":"https://api.github.com/repos/ezimuel/zf1/contents/{+path}","compare_url":"https://api.github.com/repos/ezimuel/zf1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ezimuel/zf1/merges","archive_url":"https://api.github.com/repos/ezimuel/zf1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ezimuel/zf1/downloads","issues_url":"https://api.github.com/repos/ezimuel/zf1/issues{/number}","pulls_url":"https://api.github.com/repos/ezimuel/zf1/pulls{/number}","milestones_url":"https://api.github.com/repos/ezimuel/zf1/milestones{/number}","notifications_url":"https://api.github.com/repos/ezimuel/zf1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ezimuel/zf1/labels{/name}","releases_url":"https://api.github.com/repos/ezimuel/zf1/releases{/id}","created_at":"2014-02-12T15:49:03Z","updated_at":"2014-06-18T16:33:31Z","pushed_at":"2014-08-18T15:27:15Z","git_url":"git://github.com/ezimuel/zf1.git","ssh_url":"git@github.com:ezimuel/zf1.git","clone_url":"https://github.com/ezimuel/zf1.git","svn_url":"https://github.com/ezimuel/zf1","homepage":null,"size":76263,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zendframework:master","ref":"master","sha":"f63d1372f329aa4b1e59dfd0cce00dbb0d7bc83b","user":{"login":"zendframework","id":296074,"avatar_url":"https://avatars.githubusercontent.com/u/296074?v=2","gravatar_id":"460576a0866d93fdacb597da4b90f233","url":"https://api.github.com/users/zendframework","html_url":"https://github.com/zendframework","followers_url":"https://api.github.com/users/zendframework/followers","following_url":"https://api.github.com/users/zendframework/following{/other_user}","gists_url":"https://api.github.com/users/zendframework/gists{/gist_id}","starred_url":"https://api.github.com/users/zendframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendframework/subscriptions","organizations_url":"https://api.github.com/users/zendframework/orgs","repos_url":"https://api.github.com/users/zendframework/repos","events_url":"https://api.github.com/users/zendframework/events{/privacy}","received_events_url":"https://api.github.com/users/zendframework/received_events","type":"Organization","site_admin":false},"repo":{"id":8183154,"name":"zf1","full_name":"zendframework/zf1","owner":{"login":"zendframework","id":296074,"avatar_url":"https://avatars.githubusercontent.com/u/296074?v=2","gravatar_id":"460576a0866d93fdacb597da4b90f233","url":"https://api.github.com/users/zendframework","html_url":"https://github.com/zendframework","followers_url":"https://api.github.com/users/zendframework/followers","following_url":"https://api.github.com/users/zendframework/following{/other_user}","gists_url":"https://api.github.com/users/zendframework/gists{/gist_id}","starred_url":"https://api.github.com/users/zendframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendframework/subscriptions","organizations_url":"https://api.github.com/users/zendframework/orgs","repos_url":"https://api.github.com/users/zendframework/repos","events_url":"https://api.github.com/users/zendframework/events{/privacy}","received_events_url":"https://api.github.com/users/zendframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zendframework/zf1","description":"Conversion of ZF1 subversion repo to git, from version 15234 forward, and only containing master and release-1.12 branches and 1.12 tags.","fork":false,"url":"https://api.github.com/repos/zendframework/zf1","forks_url":"https://api.github.com/repos/zendframework/zf1/forks","keys_url":"https://api.github.com/repos/zendframework/zf1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zendframework/zf1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zendframework/zf1/teams","hooks_url":"https://api.github.com/repos/zendframework/zf1/hooks","issue_events_url":"https://api.github.com/repos/zendframework/zf1/issues/events{/number}","events_url":"https://api.github.com/repos/zendframework/zf1/events","assignees_url":"https://api.github.com/repos/zendframework/zf1/assignees{/user}","branches_url":"https://api.github.com/repos/zendframework/zf1/branches{/branch}","tags_url":"https://api.github.com/repos/zendframework/zf1/tags","blobs_url":"https://api.github.com/repos/zendframework/zf1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zendframework/zf1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zendframework/zf1/git/refs{/sha}","trees_url":"https://api.github.com/repos/zendframework/zf1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zendframework/zf1/statuses/{sha}","languages_url":"https://api.github.com/repos/zendframework/zf1/languages","stargazers_url":"https://api.github.com/repos/zendframework/zf1/stargazers","contributors_url":"https://api.github.com/repos/zendframework/zf1/contributors","subscribers_url":"https://api.github.com/repos/zendframework/zf1/subscribers","subscription_url":"https://api.github.com/repos/zendframework/zf1/subscription","commits_url":"https://api.github.com/repos/zendframework/zf1/commits{/sha}","git_commits_url":"https://api.github.com/repos/zendframework/zf1/git/commits{/sha}","comments_url":"https://api.github.com/repos/zendframework/zf1/comments{/number}","issue_comment_url":"https://api.github.com/repos/zendframework/zf1/issues/comments/{number}","contents_url":"https://api.github.com/repos/zendframework/zf1/contents/{+path}","compare_url":"https://api.github.com/repos/zendframework/zf1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zendframework/zf1/merges","archive_url":"https://api.github.com/repos/zendframework/zf1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zendframework/zf1/downloads","issues_url":"https://api.github.com/repos/zendframework/zf1/issues{/number}","pulls_url":"https://api.github.com/repos/zendframework/zf1/pulls{/number}","milestones_url":"https://api.github.com/repos/zendframework/zf1/milestones{/number}","notifications_url":"https://api.github.com/repos/zendframework/zf1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zendframework/zf1/labels{/name}","releases_url":"https://api.github.com/repos/zendframework/zf1/releases{/id}","created_at":"2013-02-13T16:48:58Z","updated_at":"2014-08-11T23:00:47Z","pushed_at":"2014-08-19T07:01:28Z","git_url":"git://github.com/zendframework/zf1.git","ssh_url":"git@github.com:zendframework/zf1.git","clone_url":"https://github.com/zendframework/zf1.git","svn_url":"https://github.com/zendframework/zf1","homepage":null,"size":88869,"stargazers_count":203,"watchers_count":203,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":245,"mirror_url":null,"open_issues_count":90,"forks":245,"open_issues":90,"watchers":203,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zendframework/zf1/pulls/418"},"html":{"href":"https://github.com/zendframework/zf1/pull/418"},"issue":{"href":"https://api.github.com/repos/zendframework/zf1/issues/418"},"comments":{"href":"https://api.github.com/repos/zendframework/zf1/issues/418/comments"},"review_comments":{"href":"https://api.github.com/repos/zendframework/zf1/pulls/418/comments"},"review_comment":{"href":"https://api.github.com/repos/zendframework/zf1/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/zendframework/zf1/pulls/418/commits"},"statuses":{"href":"https://api.github.com/repos/zendframework/zf1/statuses/d8785057e1d4c76600f8917c56e64edca41d6abf"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"froschdesign","id":103362,"avatar_url":"https://avatars.githubusercontent.com/u/103362?v=2","gravatar_id":"b7722fb71a14a919cc1289794b3fb1fc","url":"https://api.github.com/users/froschdesign","html_url":"https://github.com/froschdesign","followers_url":"https://api.github.com/users/froschdesign/followers","following_url":"https://api.github.com/users/froschdesign/following{/other_user}","gists_url":"https://api.github.com/users/froschdesign/gists{/gist_id}","starred_url":"https://api.github.com/users/froschdesign/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/froschdesign/subscriptions","organizations_url":"https://api.github.com/users/froschdesign/orgs","repos_url":"https://api.github.com/users/froschdesign/repos","events_url":"https://api.github.com/users/froschdesign/events{/privacy}","received_events_url":"https://api.github.com/users/froschdesign/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":25,"deletions":3,"changed_files":2}}