GitHub PullRequestReviewCommentEvent at 2014-11-20 16:35:14
Repository: openvault
Actor: mccalluc
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/afred/openvault/pulls/comments/20658167","id":20658167,"diff_hunk":"@@ -102,12 +127,11 @@ def ng_pbcore_desc_docs\n       @ng_pbcore_desc_docs ||= ng_xml.xpath('//pbcoreDescriptionDocument')\n     end\n \n-    def with_desc_docs &block\n-      ng_pbcore_desc_docs.each do |ng_pbcore_desc_doc|\n-        doc = PbcoreDescDoc.new.tap do |doc|\n-                doc.ng_xml = ng_pbcore_desc_doc\n-              end\n-        yield DescriptionDocumentWrapper.new(doc)\n+    def pbcore_desc_docs\n+      ng_pbcore_desc_docs.map do |ng_pbcore_desc_doc|\n+        PbcoreDescDoc.new.tap do |pbcore_desc_doc|\n+          pbcore_desc_doc.ng_xml = ng_pbcore_desc_doc\n+        end","path":"lib/openvault/pbcore/ingester.rb","position":99,"original_position":99,"commit_id":"d1f682a14fff9586a252b6dbafc3831fdaa2d8f6","original_commit_id":"d1f682a14fff9586a252b6dbafc3831fdaa2d8f6","user":{"login":"mccalluc","id":730388,"avatar_url":"https://avatars.githubusercontent.com/u/730388?v=3","gravatar_id":"","url":"https://api.github.com/users/mccalluc","html_url":"https://github.com/mccalluc","followers_url":"https://api.github.com/users/mccalluc/followers","following_url":"https://api.github.com/users/mccalluc/following{/other_user}","gists_url":"https://api.github.com/users/mccalluc/gists{/gist_id}","starred_url":"https://api.github.com/users/mccalluc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mccalluc/subscriptions","organizations_url":"https://api.github.com/users/mccalluc/orgs","repos_url":"https://api.github.com/users/mccalluc/repos","events_url":"https://api.github.com/users/mccalluc/events{/privacy}","received_events_url":"https://api.github.com/users/mccalluc/received_events","type":"User","site_admin":false},"body":"nifty: If I'm reading it right, this is equivalent to \r\n```ruby\r\npbcore_desc_doc = PbcoreDescDoc.new\r\npbcore_desc_doc.ng_xml = ng_pbcore_desc_doc\r\npbcore_desc_doc\r\n```\r\nexcept less repetitive?","created_at":"2014-11-20T16:35:14Z","updated_at":"2014-11-20T16:35:14Z","html_url":"https://github.com/afred/openvault/pull/1020#discussion_r20658167","pull_request_url":"https://api.github.com/repos/afred/openvault/pulls/1020","_links":{"self":{"href":"https://api.github.com/repos/afred/openvault/pulls/comments/20658167"},"html":{"href":"https://github.com/afred/openvault/pull/1020#discussion_r20658167"},"pull_request":{"href":"https://api.github.com/repos/afred/openvault/pulls/1020"}}},"pull_request":{"url":"https://api.github.com/repos/afred/openvault/pulls/1020","id":24719893,"html_url":"https://github.com/afred/openvault/pull/1020","diff_url":"https://github.com/afred/openvault/pull/1020.diff","patch_url":"https://github.com/afred/openvault/pull/1020.patch","issue_url":"https://api.github.com/repos/afred/openvault/issues/1020","number":1020,"state":"open","locked":false,"title":"Refactor description document wrapper","user":{"login":"afred","id":1507490,"avatar_url":"https://avatars.githubusercontent.com/u/1507490?v=3","gravatar_id":"","url":"https://api.github.com/users/afred","html_url":"https://github.com/afred","followers_url":"https://api.github.com/users/afred/followers","following_url":"https://api.github.com/users/afred/following{/other_user}","gists_url":"https://api.github.com/users/afred/gists{/gist_id}","starred_url":"https://api.github.com/users/afred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afred/subscriptions","organizations_url":"https://api.github.com/users/afred/orgs","repos_url":"https://api.github.com/users/afred/repos","events_url":"https://api.github.com/users/afred/events{/privacy}","received_events_url":"https://api.github.com/users/afred/received_events","type":"User","site_admin":false},"body":"This is a sizable PR. Here's the breakdown..\r\n\r\n* Changes behavior of `Openvault::Pbcore::Ingester#ingest` when the `:replace_if_exists` flag is set. Before, it would replace the Fedora object no matter what. Now it will only replace if the updated pbcore requires that that the object be reclassified as a different model.\r\n* Refactors `Openvault::Pbcore::DescriptionDocumentWrapper` into a new class, `Openvault::Pbcore::OpenvaultAssetUpdater`. It's a little more semantic in class/method naming, and it gets cuts out some cruft.\r\n* Gets rid of the `:ids` option for `PbcoreDescDoc` factory; use `:all_ids` instead.\r\n* Gets rid of typo directory `spec/models/datasream`.","created_at":"2014-11-19T20:49:17Z","updated_at":"2014-11-20T16:35:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ded000bf3e142f40ce82072ed1168c8712c57ba4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/afred/openvault/pulls/1020/commits","review_comments_url":"https://api.github.com/repos/afred/openvault/pulls/1020/comments","review_comment_url":"https://api.github.com/repos/afred/openvault/pulls/comments/{number}","comments_url":"https://api.github.com/repos/afred/openvault/issues/1020/comments","statuses_url":"https://api.github.com/repos/afred/openvault/statuses/d1f682a14fff9586a252b6dbafc3831fdaa2d8f6","head":{"label":"afred:refactor-description-document-wrapper","ref":"refactor-description-document-wrapper","sha":"d1f682a14fff9586a252b6dbafc3831fdaa2d8f6","user":{"login":"afred","id":1507490,"avatar_url":"https://avatars.githubusercontent.com/u/1507490?v=3","gravatar_id":"","url":"https://api.github.com/users/afred","html_url":"https://github.com/afred","followers_url":"https://api.github.com/users/afred/followers","following_url":"https://api.github.com/users/afred/following{/other_user}","gists_url":"https://api.github.com/users/afred/gists{/gist_id}","starred_url":"https://api.github.com/users/afred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afred/subscriptions","organizations_url":"https://api.github.com/users/afred/orgs","repos_url":"https://api.github.com/users/afred/repos","events_url":"https://api.github.com/users/afred/events{/privacy}","received_events_url":"https://api.github.com/users/afred/received_events","type":"User","site_admin":false},"repo":{"id":9482828,"name":"openvault","full_name":"afred/openvault","owner":{"login":"afred","id":1507490,"avatar_url":"https://avatars.githubusercontent.com/u/1507490?v=3","gravatar_id":"","url":"https://api.github.com/users/afred","html_url":"https://github.com/afred","followers_url":"https://api.github.com/users/afred/followers","following_url":"https://api.github.com/users/afred/following{/other_user}","gists_url":"https://api.github.com/users/afred/gists{/gist_id}","starred_url":"https://api.github.com/users/afred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afred/subscriptions","organizations_url":"https://api.github.com/users/afred/orgs","repos_url":"https://api.github.com/users/afred/repos","events_url":"https://api.github.com/users/afred/events{/privacy}","received_events_url":"https://api.github.com/users/afred/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/afred/openvault","description":"","fork":false,"url":"https://api.github.com/repos/afred/openvault","forks_url":"https://api.github.com/repos/afred/openvault/forks","keys_url":"https://api.github.com/repos/afred/openvault/keys{/key_id}","collaborators_url":"https://api.github.com/repos/afred/openvault/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/afred/openvault/teams","hooks_url":"https://api.github.com/repos/afred/openvault/hooks","issue_events_url":"https://api.github.com/repos/afred/openvault/issues/events{/number}","events_url":"https://api.github.com/repos/afred/openvault/events","assignees_url":"https://api.github.com/repos/afred/openvault/assignees{/user}","branches_url":"https://api.github.com/repos/afred/openvault/branches{/branch}","tags_url":"https://api.github.com/repos/afred/openvault/tags","blobs_url":"https://api.github.com/repos/afred/openvault/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/afred/openvault/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/afred/openvault/git/refs{/sha}","trees_url":"https://api.github.com/repos/afred/openvault/git/trees{/sha}","statuses_url":"https://api.github.com/repos/afred/openvault/statuses/{sha}","languages_url":"https://api.github.com/repos/afred/openvault/languages","stargazers_url":"https://api.github.com/repos/afred/openvault/stargazers","contributors_url":"https://api.github.com/repos/afred/openvault/contributors","subscribers_url":"https://api.github.com/repos/afred/openvault/subscribers","subscription_url":"https://api.github.com/repos/afred/openvault/subscription","commits_url":"https://api.github.com/repos/afred/openvault/commits{/sha}","git_commits_url":"https://api.github.com/repos/afred/openvault/git/commits{/sha}","comments_url":"https://api.github.com/repos/afred/openvault/comments{/number}","issue_comment_url":"https://api.github.com/repos/afred/openvault/issues/comments/{number}","contents_url":"https://api.github.com/repos/afred/openvault/contents/{+path}","compare_url":"https://api.github.com/repos/afred/openvault/compare/{base}...{head}","merges_url":"https://api.github.com/repos/afred/openvault/merges","archive_url":"https://api.github.com/repos/afred/openvault/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/afred/openvault/downloads","issues_url":"https://api.github.com/repos/afred/openvault/issues{/number}","pulls_url":"https://api.github.com/repos/afred/openvault/pulls{/number}","milestones_url":"https://api.github.com/repos/afred/openvault/milestones{/number}","notifications_url":"https://api.github.com/repos/afred/openvault/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/afred/openvault/labels{/name}","releases_url":"https://api.github.com/repos/afred/openvault/releases{/id}","created_at":"2013-04-16T21:16:15Z","updated_at":"2014-11-20T16:14:05Z","pushed_at":"2014-11-20T16:14:11Z","git_url":"git://github.com/afred/openvault.git","ssh_url":"git@github.com:afred/openvault.git","clone_url":"https://github.com/afred/openvault.git","svn_url":"https://github.com/afred/openvault","homepage":null,"size":131225,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":177,"forks":0,"open_issues":177,"watchers":2,"default_branch":"development"}},"base":{"label":"afred:development","ref":"development","sha":"f18357676d9578fcbe57ecdb9044821131a6daa1","user":{"login":"afred","id":1507490,"avatar_url":"https://avatars.githubusercontent.com/u/1507490?v=3","gravatar_id":"","url":"https://api.github.com/users/afred","html_url":"https://github.com/afred","followers_url":"https://api.github.com/users/afred/followers","following_url":"https://api.github.com/users/afred/following{/other_user}","gists_url":"https://api.github.com/users/afred/gists{/gist_id}","starred_url":"https://api.github.com/users/afred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afred/subscriptions","organizations_url":"https://api.github.com/users/afred/orgs","repos_url":"https://api.github.com/users/afred/repos","events_url":"https://api.github.com/users/afred/events{/privacy}","received_events_url":"https://api.github.com/users/afred/received_events","type":"User","site_admin":false},"repo":{"id":9482828,"name":"openvault","full_name":"afred/openvault","owner":{"login":"afred","id":1507490,"avatar_url":"https://avatars.githubusercontent.com/u/1507490?v=3","gravatar_id":"","url":"https://api.github.com/users/afred","html_url":"https://github.com/afred","followers_url":"https://api.github.com/users/afred/followers","following_url":"https://api.github.com/users/afred/following{/other_user}","gists_url":"https://api.github.com/users/afred/gists{/gist_id}","starred_url":"https://api.github.com/users/afred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afred/subscriptions","organizations_url":"https://api.github.com/users/afred/orgs","repos_url":"https://api.github.com/users/afred/repos","events_url":"https://api.github.com/users/afred/events{/privacy}","received_events_url":"https://api.github.com/users/afred/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/afred/openvault","description":"","fork":false,"url":"https://api.github.com/repos/afred/openvault","forks_url":"https://api.github.com/repos/afred/openvault/forks","keys_url":"https://api.github.com/repos/afred/openvault/keys{/key_id}","collaborators_url":"https://api.github.com/repos/afred/openvault/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/afred/openvault/teams","hooks_url":"https://api.github.com/repos/afred/openvault/hooks","issue_events_url":"https://api.github.com/repos/afred/openvault/issues/events{/number}","events_url":"https://api.github.com/repos/afred/openvault/events","assignees_url":"https://api.github.com/repos/afred/openvault/assignees{/user}","branches_url":"https://api.github.com/repos/afred/openvault/branches{/branch}","tags_url":"https://api.github.com/repos/afred/openvault/tags","blobs_url":"https://api.github.com/repos/afred/openvault/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/afred/openvault/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/afred/openvault/git/refs{/sha}","trees_url":"https://api.github.com/repos/afred/openvault/git/trees{/sha}","statuses_url":"https://api.github.com/repos/afred/openvault/statuses/{sha}","languages_url":"https://api.github.com/repos/afred/openvault/languages","stargazers_url":"https://api.github.com/repos/afred/openvault/stargazers","contributors_url":"https://api.github.com/repos/afred/openvault/contributors","subscribers_url":"https://api.github.com/repos/afred/openvault/subscribers","subscription_url":"https://api.github.com/repos/afred/openvault/subscription","commits_url":"https://api.github.com/repos/afred/openvault/commits{/sha}","git_commits_url":"https://api.github.com/repos/afred/openvault/git/commits{/sha}","comments_url":"https://api.github.com/repos/afred/openvault/comments{/number}","issue_comment_url":"https://api.github.com/repos/afred/openvault/issues/comments/{number}","contents_url":"https://api.github.com/repos/afred/openvault/contents/{+path}","compare_url":"https://api.github.com/repos/afred/openvault/compare/{base}...{head}","merges_url":"https://api.github.com/repos/afred/openvault/merges","archive_url":"https://api.github.com/repos/afred/openvault/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/afred/openvault/downloads","issues_url":"https://api.github.com/repos/afred/openvault/issues{/number}","pulls_url":"https://api.github.com/repos/afred/openvault/pulls{/number}","milestones_url":"https://api.github.com/repos/afred/openvault/milestones{/number}","notifications_url":"https://api.github.com/repos/afred/openvault/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/afred/openvault/labels{/name}","releases_url":"https://api.github.com/repos/afred/openvault/releases{/id}","created_at":"2013-04-16T21:16:15Z","updated_at":"2014-11-20T16:14:05Z","pushed_at":"2014-11-20T16:14:11Z","git_url":"git://github.com/afred/openvault.git","ssh_url":"git@github.com:afred/openvault.git","clone_url":"https://github.com/afred/openvault.git","svn_url":"https://github.com/afred/openvault","homepage":null,"size":131225,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":177,"forks":0,"open_issues":177,"watchers":2,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/afred/openvault/pulls/1020"},"html":{"href":"https://github.com/afred/openvault/pull/1020"},"issue":{"href":"https://api.github.com/repos/afred/openvault/issues/1020"},"comments":{"href":"https://api.github.com/repos/afred/openvault/issues/1020/comments"},"review_comments":{"href":"https://api.github.com/repos/afred/openvault/pulls/1020/comments"},"review_comment":{"href":"https://api.github.com/repos/afred/openvault/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/afred/openvault/pulls/1020/commits"},"statuses":{"href":"https://api.github.com/repos/afred/openvault/statuses/d1f682a14fff9586a252b6dbafc3831fdaa2d8f6"}}}}