GitHub PullRequestEvent at 2014-09-11 05:43:18
Repository: isort
Actor: dandavison
Payload: {"action":"opened","number":180,"pull_request":{"url":"https://api.github.com/repos/timothycrosley/isort/pulls/180","id":21067539,"html_url":"https://github.com/timothycrosley/isort/pull/180","diff_url":"https://github.com/timothycrosley/isort/pull/180.diff","patch_url":"https://github.com/timothycrosley/isort/pull/180.patch","issue_url":"https://api.github.com/repos/timothycrosley/isort/issues/180","number":180,"state":"open","locked":false,"title":"Don't set `combine_as_imports` in comment test cases.","user":{"login":"dandavison","id":52205,"avatar_url":"https://avatars.githubusercontent.com/u/52205?v=2","gravatar_id":"ba5b1b2d5cb116487addb70775ae6455","url":"https://api.github.com/users/dandavison","html_url":"https://github.com/dandavison","followers_url":"https://api.github.com/users/dandavison/followers","following_url":"https://api.github.com/users/dandavison/following{/other_user}","gists_url":"https://api.github.com/users/dandavison/gists{/gist_id}","starred_url":"https://api.github.com/users/dandavison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dandavison/subscriptions","organizations_url":"https://api.github.com/users/dandavison/orgs","repos_url":"https://api.github.com/users/dandavison/repos","events_url":"https://api.github.com/users/dandavison/events{/privacy}","received_events_url":"https://api.github.com/users/dandavison/received_events","type":"User","site_admin":false},"body":"As far as I could see, the option `combine_as_imports` is not really used currently (not exposed in the command line API). The `test_keep_comments` test cases were setting it to true, but that was neither necessary for the tests to pass, nor reflective of the common way in which the code would be executed. This PR stops those tests from setting that option.","created_at":"2014-09-11T05:43:18Z","updated_at":"2014-09-11T05:43:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fd5fac550bc75b06ee5e79fbdba78abe489bf629","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/timothycrosley/isort/pulls/180/commits","review_comments_url":"https://api.github.com/repos/timothycrosley/isort/pulls/180/comments","review_comment_url":"https://api.github.com/repos/timothycrosley/isort/pulls/comments/{number}","comments_url":"https://api.github.com/repos/timothycrosley/isort/issues/180/comments","statuses_url":"https://api.github.com/repos/timothycrosley/isort/statuses/daf790e8ab7dcd1f6a1a922f5347f35dec04641a","head":{"label":"dandavison:dont_combine_as_imports_by_default_in_tests","ref":"dont_combine_as_imports_by_default_in_tests","sha":"daf790e8ab7dcd1f6a1a922f5347f35dec04641a","user":{"login":"dandavison","id":52205,"avatar_url":"https://avatars.githubusercontent.com/u/52205?v=2","gravatar_id":"ba5b1b2d5cb116487addb70775ae6455","url":"https://api.github.com/users/dandavison","html_url":"https://github.com/dandavison","followers_url":"https://api.github.com/users/dandavison/followers","following_url":"https://api.github.com/users/dandavison/following{/other_user}","gists_url":"https://api.github.com/users/dandavison/gists{/gist_id}","starred_url":"https://api.github.com/users/dandavison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dandavison/subscriptions","organizations_url":"https://api.github.com/users/dandavison/orgs","repos_url":"https://api.github.com/users/dandavison/repos","events_url":"https://api.github.com/users/dandavison/events{/privacy}","received_events_url":"https://api.github.com/users/dandavison/received_events","type":"User","site_admin":false},"repo":{"id":23905136,"name":"isort","full_name":"dandavison/isort","owner":{"login":"dandavison","id":52205,"avatar_url":"https://avatars.githubusercontent.com/u/52205?v=2","gravatar_id":"ba5b1b2d5cb116487addb70775ae6455","url":"https://api.github.com/users/dandavison","html_url":"https://github.com/dandavison","followers_url":"https://api.github.com/users/dandavison/followers","following_url":"https://api.github.com/users/dandavison/following{/other_user}","gists_url":"https://api.github.com/users/dandavison/gists{/gist_id}","starred_url":"https://api.github.com/users/dandavison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dandavison/subscriptions","organizations_url":"https://api.github.com/users/dandavison/orgs","repos_url":"https://api.github.com/users/dandavison/repos","events_url":"https://api.github.com/users/dandavison/events{/privacy}","received_events_url":"https://api.github.com/users/dandavison/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dandavison/isort","description":"A Python utility / library to sort imports.","fork":true,"url":"https://api.github.com/repos/dandavison/isort","forks_url":"https://api.github.com/repos/dandavison/isort/forks","keys_url":"https://api.github.com/repos/dandavison/isort/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dandavison/isort/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dandavison/isort/teams","hooks_url":"https://api.github.com/repos/dandavison/isort/hooks","issue_events_url":"https://api.github.com/repos/dandavison/isort/issues/events{/number}","events_url":"https://api.github.com/repos/dandavison/isort/events","assignees_url":"https://api.github.com/repos/dandavison/isort/assignees{/user}","branches_url":"https://api.github.com/repos/dandavison/isort/branches{/branch}","tags_url":"https://api.github.com/repos/dandavison/isort/tags","blobs_url":"https://api.github.com/repos/dandavison/isort/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dandavison/isort/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dandavison/isort/git/refs{/sha}","trees_url":"https://api.github.com/repos/dandavison/isort/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dandavison/isort/statuses/{sha}","languages_url":"https://api.github.com/repos/dandavison/isort/languages","stargazers_url":"https://api.github.com/repos/dandavison/isort/stargazers","contributors_url":"https://api.github.com/repos/dandavison/isort/contributors","subscribers_url":"https://api.github.com/repos/dandavison/isort/subscribers","subscription_url":"https://api.github.com/repos/dandavison/isort/subscription","commits_url":"https://api.github.com/repos/dandavison/isort/commits{/sha}","git_commits_url":"https://api.github.com/repos/dandavison/isort/git/commits{/sha}","comments_url":"https://api.github.com/repos/dandavison/isort/comments{/number}","issue_comment_url":"https://api.github.com/repos/dandavison/isort/issues/comments/{number}","contents_url":"https://api.github.com/repos/dandavison/isort/contents/{+path}","compare_url":"https://api.github.com/repos/dandavison/isort/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dandavison/isort/merges","archive_url":"https://api.github.com/repos/dandavison/isort/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dandavison/isort/downloads","issues_url":"https://api.github.com/repos/dandavison/isort/issues{/number}","pulls_url":"https://api.github.com/repos/dandavison/isort/pulls{/number}","milestones_url":"https://api.github.com/repos/dandavison/isort/milestones{/number}","notifications_url":"https://api.github.com/repos/dandavison/isort/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dandavison/isort/labels{/name}","releases_url":"https://api.github.com/repos/dandavison/isort/releases{/id}","created_at":"2014-09-11T05:16:17Z","updated_at":"2014-09-11T04:29:27Z","pushed_at":"2014-09-11T05:41:10Z","git_url":"git://github.com/dandavison/isort.git","ssh_url":"git@github.com:dandavison/isort.git","clone_url":"https://github.com/dandavison/isort.git","svn_url":"https://github.com/dandavison/isort","homepage":null,"size":1164,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"timothycrosley:develop","ref":"develop","sha":"f04a5815171a48188b1d0a604bf6509b08a96a70","user":{"login":"timothycrosley","id":2090154,"avatar_url":"https://avatars.githubusercontent.com/u/2090154?v=2","gravatar_id":"789a20c723e22cf1bfe698636ff5a28c","url":"https://api.github.com/users/timothycrosley","html_url":"https://github.com/timothycrosley","followers_url":"https://api.github.com/users/timothycrosley/followers","following_url":"https://api.github.com/users/timothycrosley/following{/other_user}","gists_url":"https://api.github.com/users/timothycrosley/gists{/gist_id}","starred_url":"https://api.github.com/users/timothycrosley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timothycrosley/subscriptions","organizations_url":"https://api.github.com/users/timothycrosley/orgs","repos_url":"https://api.github.com/users/timothycrosley/repos","events_url":"https://api.github.com/users/timothycrosley/events{/privacy}","received_events_url":"https://api.github.com/users/timothycrosley/received_events","type":"User","site_admin":false},"repo":{"id":12550138,"name":"isort","full_name":"timothycrosley/isort","owner":{"login":"timothycrosley","id":2090154,"avatar_url":"https://avatars.githubusercontent.com/u/2090154?v=2","gravatar_id":"789a20c723e22cf1bfe698636ff5a28c","url":"https://api.github.com/users/timothycrosley","html_url":"https://github.com/timothycrosley","followers_url":"https://api.github.com/users/timothycrosley/followers","following_url":"https://api.github.com/users/timothycrosley/following{/other_user}","gists_url":"https://api.github.com/users/timothycrosley/gists{/gist_id}","starred_url":"https://api.github.com/users/timothycrosley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timothycrosley/subscriptions","organizations_url":"https://api.github.com/users/timothycrosley/orgs","repos_url":"https://api.github.com/users/timothycrosley/repos","events_url":"https://api.github.com/users/timothycrosley/events{/privacy}","received_events_url":"https://api.github.com/users/timothycrosley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/timothycrosley/isort","description":"A Python utility / library to sort imports.","fork":false,"url":"https://api.github.com/repos/timothycrosley/isort","forks_url":"https://api.github.com/repos/timothycrosley/isort/forks","keys_url":"https://api.github.com/repos/timothycrosley/isort/keys{/key_id}","collaborators_url":"https://api.github.com/repos/timothycrosley/isort/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/timothycrosley/isort/teams","hooks_url":"https://api.github.com/repos/timothycrosley/isort/hooks","issue_events_url":"https://api.github.com/repos/timothycrosley/isort/issues/events{/number}","events_url":"https://api.github.com/repos/timothycrosley/isort/events","assignees_url":"https://api.github.com/repos/timothycrosley/isort/assignees{/user}","branches_url":"https://api.github.com/repos/timothycrosley/isort/branches{/branch}","tags_url":"https://api.github.com/repos/timothycrosley/isort/tags","blobs_url":"https://api.github.com/repos/timothycrosley/isort/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/timothycrosley/isort/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/timothycrosley/isort/git/refs{/sha}","trees_url":"https://api.github.com/repos/timothycrosley/isort/git/trees{/sha}","statuses_url":"https://api.github.com/repos/timothycrosley/isort/statuses/{sha}","languages_url":"https://api.github.com/repos/timothycrosley/isort/languages","stargazers_url":"https://api.github.com/repos/timothycrosley/isort/stargazers","contributors_url":"https://api.github.com/repos/timothycrosley/isort/contributors","subscribers_url":"https://api.github.com/repos/timothycrosley/isort/subscribers","subscription_url":"https://api.github.com/repos/timothycrosley/isort/subscription","commits_url":"https://api.github.com/repos/timothycrosley/isort/commits{/sha}","git_commits_url":"https://api.github.com/repos/timothycrosley/isort/git/commits{/sha}","comments_url":"https://api.github.com/repos/timothycrosley/isort/comments{/number}","issue_comment_url":"https://api.github.com/repos/timothycrosley/isort/issues/comments/{number}","contents_url":"https://api.github.com/repos/timothycrosley/isort/contents/{+path}","compare_url":"https://api.github.com/repos/timothycrosley/isort/compare/{base}...{head}","merges_url":"https://api.github.com/repos/timothycrosley/isort/merges","archive_url":"https://api.github.com/repos/timothycrosley/isort/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/timothycrosley/isort/downloads","issues_url":"https://api.github.com/repos/timothycrosley/isort/issues{/number}","pulls_url":"https://api.github.com/repos/timothycrosley/isort/pulls{/number}","milestones_url":"https://api.github.com/repos/timothycrosley/isort/milestones{/number}","notifications_url":"https://api.github.com/repos/timothycrosley/isort/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/timothycrosley/isort/labels{/name}","releases_url":"https://api.github.com/repos/timothycrosley/isort/releases{/id}","created_at":"2013-09-02T22:22:53Z","updated_at":"2014-09-11T04:29:27Z","pushed_at":"2014-08-04T17:39:42Z","git_url":"git://github.com/timothycrosley/isort.git","ssh_url":"git@github.com:timothycrosley/isort.git","clone_url":"https://github.com/timothycrosley/isort.git","svn_url":"https://github.com/timothycrosley/isort","homepage":null,"size":4857,"stargazers_count":278,"watchers_count":278,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":43,"mirror_url":null,"open_issues_count":7,"forks":43,"open_issues":7,"watchers":278,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/timothycrosley/isort/pulls/180"},"html":{"href":"https://github.com/timothycrosley/isort/pull/180"},"issue":{"href":"https://api.github.com/repos/timothycrosley/isort/issues/180"},"comments":{"href":"https://api.github.com/repos/timothycrosley/isort/issues/180/comments"},"review_comments":{"href":"https://api.github.com/repos/timothycrosley/isort/pulls/180/comments"},"review_comment":{"href":"https://api.github.com/repos/timothycrosley/isort/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/timothycrosley/isort/pulls/180/commits"},"statuses":{"href":"https://api.github.com/repos/timothycrosley/isort/statuses/daf790e8ab7dcd1f6a1a922f5347f35dec04641a"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":7,"deletions":7,"changed_files":1}}