GitHub PullRequestEvent at 2014-04-07 22:25:31
Repository: Thruk
Actor: sni
Payload: {"action":"closed","number":338,"pull_request":{"url":"https://api.github.com/repos/sni/Thruk/pulls/338","id":14457167,"html_url":"https://github.com/sni/Thruk/pull/338","diff_url":"https://github.com/sni/Thruk/pull/338.diff","patch_url":"https://github.com/sni/Thruk/pull/338.patch","issue_url":"https://api.github.com/repos/sni/Thruk/issues/338","number":338,"state":"closed","title":"Better sorting of comments and downtimes","user":{"login":"awiddersheim","id":3237256,"avatar_url":"https://avatars.githubusercontent.com/u/3237256?","gravatar_id":"e93bcb7efa6f18d039095d0cc23d5c61","url":"https://api.github.com/users/awiddersheim","html_url":"https://github.com/awiddersheim","followers_url":"https://api.github.com/users/awiddersheim/followers","following_url":"https://api.github.com/users/awiddersheim/following{/other_user}","gists_url":"https://api.github.com/users/awiddersheim/gists{/gist_id}","starred_url":"https://api.github.com/users/awiddersheim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awiddersheim/subscriptions","organizations_url":"https://api.github.com/users/awiddersheim/orgs","repos_url":"https://api.github.com/users/awiddersheim/repos","events_url":"https://api.github.com/users/awiddersheim/events{/privacy}","received_events_url":"https://api.github.com/users/awiddersheim/received_events","type":"User","site_admin":false},"body":"This fixes a few things mainly adding the ability to sort the comments\r\nand downtimes on the host and service pages. There were also a few style\r\nchanges I made as I saw fit along the way.\r\n\r\nMostly, the style changes were just wording tweaks, capitalization and\r\nformatting. Added output to show current sorting method by default. This\r\nmay not be desired but I liked it so I kept it. Can remove it if people\r\ndo not like it.\r\n\r\nHost comment sorting with sort method displayed:\r\n![image](https://cloud.githubusercontent.com/assets/3237256/2633630/d3cec380-be70-11e3-9ef0-4080ae1906e3.png)\r\n\r\nService comments and downtime sorting with sort method displayed:\r\n\r\n![image](https://cloud.githubusercontent.com/assets/3237256/2633641/f7cad152-be70-11e3-83d6-1b190a937de0.png)\r\n![image](https://cloud.githubusercontent.com/assets/3237256/2633644/003b34b2-be71-11e3-99f1-6009a976ef25.png)\r\n\r\nDowntimes page host portion with sort order displayed, fixed \"downtime\" to \"downtimes\" and capitalized \"mark\":\r\n![image](https://cloud.githubusercontent.com/assets/3237256/2633655/2d1b1a6a-be71-11e3-952d-549f24edaa17.png)\r\n\r\nDowntimes page service portion with sort order diplayed, fixed \"downtime\" to \"downtimes\" and added the \"mark\" line:\r\n![image](https://cloud.githubusercontent.com/assets/3237256/2633664/4af04808-be71-11e3-9b72-f1b67a96a3c8.png)\r\n\r\nComments page host portion with sort order displayed:\r\n![image](https://cloud.githubusercontent.com/assets/3237256/2633671/65900d74-be71-11e3-9d30-b53a8124064f.png)\r\n\r\nComments page service portion with sort order displayed and added the \"mark\" line:\r\n![image](https://cloud.githubusercontent.com/assets/3237256/2633684/81f3fa20-be71-11e3-94fe-541d9f8163c3.png)\r\n\r\n","created_at":"2014-04-07T16:29:15Z","updated_at":"2014-04-07T22:25:31Z","closed_at":"2014-04-07T22:25:31Z","merged_at":"2014-04-07T22:25:31Z","merge_commit_sha":"46ca77e6853dbe3e9128b060ba5cdf7a988ebd5d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sni/Thruk/pulls/338/commits","review_comments_url":"https://api.github.com/repos/sni/Thruk/pulls/338/comments","review_comment_url":"https://api.github.com/repos/sni/Thruk/pulls/comments/{number}","comments_url":"https://api.github.com/repos/sni/Thruk/issues/338/comments","statuses_url":"https://api.github.com/repos/sni/Thruk/statuses/73bcac85495403687852dc5ebe2948d25551486f","head":{"label":"awiddersheim:fix_comment_downtime_sorting","ref":"fix_comment_downtime_sorting","sha":"73bcac85495403687852dc5ebe2948d25551486f","user":{"login":"awiddersheim","id":3237256,"avatar_url":"https://avatars.githubusercontent.com/u/3237256?","gravatar_id":"e93bcb7efa6f18d039095d0cc23d5c61","url":"https://api.github.com/users/awiddersheim","html_url":"https://github.com/awiddersheim","followers_url":"https://api.github.com/users/awiddersheim/followers","following_url":"https://api.github.com/users/awiddersheim/following{/other_user}","gists_url":"https://api.github.com/users/awiddersheim/gists{/gist_id}","starred_url":"https://api.github.com/users/awiddersheim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awiddersheim/subscriptions","organizations_url":"https://api.github.com/users/awiddersheim/orgs","repos_url":"https://api.github.com/users/awiddersheim/repos","events_url":"https://api.github.com/users/awiddersheim/events{/privacy}","received_events_url":"https://api.github.com/users/awiddersheim/received_events","type":"User","site_admin":false},"repo":{"id":17094794,"name":"Thruk","full_name":"awiddersheim/Thruk","owner":{"login":"awiddersheim","id":3237256,"avatar_url":"https://avatars.githubusercontent.com/u/3237256?","gravatar_id":"e93bcb7efa6f18d039095d0cc23d5c61","url":"https://api.github.com/users/awiddersheim","html_url":"https://github.com/awiddersheim","followers_url":"https://api.github.com/users/awiddersheim/followers","following_url":"https://api.github.com/users/awiddersheim/following{/other_user}","gists_url":"https://api.github.com/users/awiddersheim/gists{/gist_id}","starred_url":"https://api.github.com/users/awiddersheim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awiddersheim/subscriptions","organizations_url":"https://api.github.com/users/awiddersheim/orgs","repos_url":"https://api.github.com/users/awiddersheim/repos","events_url":"https://api.github.com/users/awiddersheim/events{/privacy}","received_events_url":"https://api.github.com/users/awiddersheim/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/awiddersheim/Thruk","description":"Thruk is a multibackend monitoring webinterface for Nagios, Icinga and Shinken using the Livestatus API.","fork":true,"url":"https://api.github.com/repos/awiddersheim/Thruk","forks_url":"https://api.github.com/repos/awiddersheim/Thruk/forks","keys_url":"https://api.github.com/repos/awiddersheim/Thruk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awiddersheim/Thruk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awiddersheim/Thruk/teams","hooks_url":"https://api.github.com/repos/awiddersheim/Thruk/hooks","issue_events_url":"https://api.github.com/repos/awiddersheim/Thruk/issues/events{/number}","events_url":"https://api.github.com/repos/awiddersheim/Thruk/events","assignees_url":"https://api.github.com/repos/awiddersheim/Thruk/assignees{/user}","branches_url":"https://api.github.com/repos/awiddersheim/Thruk/branches{/branch}","tags_url":"https://api.github.com/repos/awiddersheim/Thruk/tags","blobs_url":"https://api.github.com/repos/awiddersheim/Thruk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awiddersheim/Thruk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awiddersheim/Thruk/git/refs{/sha}","trees_url":"https://api.github.com/repos/awiddersheim/Thruk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awiddersheim/Thruk/statuses/{sha}","languages_url":"https://api.github.com/repos/awiddersheim/Thruk/languages","stargazers_url":"https://api.github.com/repos/awiddersheim/Thruk/stargazers","contributors_url":"https://api.github.com/repos/awiddersheim/Thruk/contributors","subscribers_url":"https://api.github.com/repos/awiddersheim/Thruk/subscribers","subscription_url":"https://api.github.com/repos/awiddersheim/Thruk/subscription","commits_url":"https://api.github.com/repos/awiddersheim/Thruk/commits{/sha}","git_commits_url":"https://api.github.com/repos/awiddersheim/Thruk/git/commits{/sha}","comments_url":"https://api.github.com/repos/awiddersheim/Thruk/comments{/number}","issue_comment_url":"https://api.github.com/repos/awiddersheim/Thruk/issues/comments/{number}","contents_url":"https://api.github.com/repos/awiddersheim/Thruk/contents/{+path}","compare_url":"https://api.github.com/repos/awiddersheim/Thruk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awiddersheim/Thruk/merges","archive_url":"https://api.github.com/repos/awiddersheim/Thruk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awiddersheim/Thruk/downloads","issues_url":"https://api.github.com/repos/awiddersheim/Thruk/issues{/number}","pulls_url":"https://api.github.com/repos/awiddersheim/Thruk/pulls{/number}","milestones_url":"https://api.github.com/repos/awiddersheim/Thruk/milestones{/number}","notifications_url":"https://api.github.com/repos/awiddersheim/Thruk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awiddersheim/Thruk/labels{/name}","releases_url":"https://api.github.com/repos/awiddersheim/Thruk/releases{/id}","created_at":"2014-02-22T21:11:30Z","updated_at":"2014-04-07T22:25:31Z","pushed_at":"2014-04-07T20:41:36Z","git_url":"git://github.com/awiddersheim/Thruk.git","ssh_url":"git@github.com:awiddersheim/Thruk.git","clone_url":"https://github.com/awiddersheim/Thruk.git","svn_url":"https://github.com/awiddersheim/Thruk","homepage":"http://www.thruk.org","size":31861,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"sni:master","ref":"master","sha":"96921c4c46f6b0f0a722bb38d706a55d5a95c068","user":{"login":"sni","id":150844,"avatar_url":"https://avatars.githubusercontent.com/u/150844?","gravatar_id":"0961ce11467ff2cf598801a08ac92235","url":"https://api.github.com/users/sni","html_url":"https://github.com/sni","followers_url":"https://api.github.com/users/sni/followers","following_url":"https://api.github.com/users/sni/following{/other_user}","gists_url":"https://api.github.com/users/sni/gists{/gist_id}","starred_url":"https://api.github.com/users/sni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sni/subscriptions","organizations_url":"https://api.github.com/users/sni/orgs","repos_url":"https://api.github.com/users/sni/repos","events_url":"https://api.github.com/users/sni/events{/privacy}","received_events_url":"https://api.github.com/users/sni/received_events","type":"User","site_admin":false},"repo":{"id":366441,"name":"Thruk","full_name":"sni/Thruk","owner":{"login":"sni","id":150844,"avatar_url":"https://avatars.githubusercontent.com/u/150844?","gravatar_id":"0961ce11467ff2cf598801a08ac92235","url":"https://api.github.com/users/sni","html_url":"https://github.com/sni","followers_url":"https://api.github.com/users/sni/followers","following_url":"https://api.github.com/users/sni/following{/other_user}","gists_url":"https://api.github.com/users/sni/gists{/gist_id}","starred_url":"https://api.github.com/users/sni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sni/subscriptions","organizations_url":"https://api.github.com/users/sni/orgs","repos_url":"https://api.github.com/users/sni/repos","events_url":"https://api.github.com/users/sni/events{/privacy}","received_events_url":"https://api.github.com/users/sni/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sni/Thruk","description":"Thruk is a multibackend monitoring webinterface for Naemon, Nagios, Icinga and Shinken using the Livestatus API.","fork":false,"url":"https://api.github.com/repos/sni/Thruk","forks_url":"https://api.github.com/repos/sni/Thruk/forks","keys_url":"https://api.github.com/repos/sni/Thruk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sni/Thruk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sni/Thruk/teams","hooks_url":"https://api.github.com/repos/sni/Thruk/hooks","issue_events_url":"https://api.github.com/repos/sni/Thruk/issues/events{/number}","events_url":"https://api.github.com/repos/sni/Thruk/events","assignees_url":"https://api.github.com/repos/sni/Thruk/assignees{/user}","branches_url":"https://api.github.com/repos/sni/Thruk/branches{/branch}","tags_url":"https://api.github.com/repos/sni/Thruk/tags","blobs_url":"https://api.github.com/repos/sni/Thruk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sni/Thruk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sni/Thruk/git/refs{/sha}","trees_url":"https://api.github.com/repos/sni/Thruk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sni/Thruk/statuses/{sha}","languages_url":"https://api.github.com/repos/sni/Thruk/languages","stargazers_url":"https://api.github.com/repos/sni/Thruk/stargazers","contributors_url":"https://api.github.com/repos/sni/Thruk/contributors","subscribers_url":"https://api.github.com/repos/sni/Thruk/subscribers","subscription_url":"https://api.github.com/repos/sni/Thruk/subscription","commits_url":"https://api.github.com/repos/sni/Thruk/commits{/sha}","git_commits_url":"https://api.github.com/repos/sni/Thruk/git/commits{/sha}","comments_url":"https://api.github.com/repos/sni/Thruk/comments{/number}","issue_comment_url":"https://api.github.com/repos/sni/Thruk/issues/comments/{number}","contents_url":"https://api.github.com/repos/sni/Thruk/contents/{+path}","compare_url":"https://api.github.com/repos/sni/Thruk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sni/Thruk/merges","archive_url":"https://api.github.com/repos/sni/Thruk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sni/Thruk/downloads","issues_url":"https://api.github.com/repos/sni/Thruk/issues{/number}","pulls_url":"https://api.github.com/repos/sni/Thruk/pulls{/number}","milestones_url":"https://api.github.com/repos/sni/Thruk/milestones{/number}","notifications_url":"https://api.github.com/repos/sni/Thruk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sni/Thruk/labels{/name}","releases_url":"https://api.github.com/repos/sni/Thruk/releases{/id}","created_at":"2009-11-09T16:35:33Z","updated_at":"2014-04-07T22:25:31Z","pushed_at":"2014-04-07T22:25:31Z","git_url":"git://github.com/sni/Thruk.git","ssh_url":"git@github.com:sni/Thruk.git","clone_url":"https://github.com/sni/Thruk.git","svn_url":"https://github.com/sni/Thruk","homepage":"http://www.thruk.org","size":38053,"stargazers_count":142,"watchers_count":142,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":false,"forks_count":51,"mirror_url":null,"open_issues_count":26,"forks":51,"open_issues":26,"watchers":142,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sni/Thruk/pulls/338"},"html":{"href":"https://github.com/sni/Thruk/pull/338"},"issue":{"href":"https://api.github.com/repos/sni/Thruk/issues/338"},"comments":{"href":"https://api.github.com/repos/sni/Thruk/issues/338/comments"},"review_comments":{"href":"https://api.github.com/repos/sni/Thruk/pulls/338/comments"},"review_comment":{"href":"https://api.github.com/repos/sni/Thruk/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/sni/Thruk/pulls/338/commits"},"statuses":{"href":"https://api.github.com/repos/sni/Thruk/statuses/73bcac85495403687852dc5ebe2948d25551486f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"sni","id":150844,"avatar_url":"https://avatars.githubusercontent.com/u/150844?","gravatar_id":"0961ce11467ff2cf598801a08ac92235","url":"https://api.github.com/users/sni","html_url":"https://github.com/sni","followers_url":"https://api.github.com/users/sni/followers","following_url":"https://api.github.com/users/sni/following{/other_user}","gists_url":"https://api.github.com/users/sni/gists{/gist_id}","starred_url":"https://api.github.com/users/sni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sni/subscriptions","organizations_url":"https://api.github.com/users/sni/orgs","repos_url":"https://api.github.com/users/sni/repos","events_url":"https://api.github.com/users/sni/events{/privacy}","received_events_url":"https://api.github.com/users/sni/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":2,"additions":156,"deletions":70,"changed_files":5}}