GitHub PullRequestReviewCommentEvent at 2014-10-15 16:16:39
Repository: node
Actor: bnoordhuis
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/joyent/node/pulls/comments/18904111","id":18904111,"diff_hunk":"@@ -260,13 +274,33 @@ inline void Environment::Dispose() {\n   delete this;\n }\n \n+inline uint32_t Environment::NewUniqueAsyncId() {\n+  return ++unique_async_id_;","path":"src/env-inl.h","position":44,"original_position":44,"commit_id":"7a5760894ab554aef491ac46fdb6a5a94941ecfb","original_commit_id":"7a5760894ab554aef491ac46fdb6a5a94941ecfb","user":{"login":"bnoordhuis","id":275871,"avatar_url":"https://avatars.githubusercontent.com/u/275871?v=2","gravatar_id":"","url":"https://api.github.com/users/bnoordhuis","html_url":"https://github.com/bnoordhuis","followers_url":"https://api.github.com/users/bnoordhuis/followers","following_url":"https://api.github.com/users/bnoordhuis/following{/other_user}","gists_url":"https://api.github.com/users/bnoordhuis/gists{/gist_id}","starred_url":"https://api.github.com/users/bnoordhuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnoordhuis/subscriptions","organizations_url":"https://api.github.com/users/bnoordhuis/orgs","repos_url":"https://api.github.com/users/bnoordhuis/repos","events_url":"https://api.github.com/users/bnoordhuis/events{/privacy}","received_events_url":"https://api.github.com/users/bnoordhuis/received_events","type":"User","site_admin":false},"body":"`unique_async_id_` is a double, right?  Why then is the return type `uint32_t`?","created_at":"2014-10-15T16:16:39Z","updated_at":"2014-10-15T16:16:39Z","html_url":"https://github.com/joyent/node/pull/8110#discussion_r18904111","pull_request_url":"https://api.github.com/repos/joyent/node/pulls/8110","_links":{"self":{"href":"https://api.github.com/repos/joyent/node/pulls/comments/18904111"},"html":{"href":"https://github.com/joyent/node/pull/8110#discussion_r18904111"},"pull_request":{"href":"https://api.github.com/repos/joyent/node/pulls/8110"}}},"pull_request":{"url":"https://api.github.com/repos/joyent/node/pulls/8110","id":19539190,"html_url":"https://github.com/joyent/node/pull/8110","diff_url":"https://github.com/joyent/node/pull/8110.diff","patch_url":"https://github.com/joyent/node/pull/8110.patch","issue_url":"https://api.github.com/repos/joyent/node/issues/8110","number":8110,"state":"open","locked":false,"title":"Remove all AsyncListener JS code","user":{"login":"trevnorris","id":289174,"avatar_url":"https://avatars.githubusercontent.com/u/289174?v=2","gravatar_id":"","url":"https://api.github.com/users/trevnorris","html_url":"https://github.com/trevnorris","followers_url":"https://api.github.com/users/trevnorris/followers","following_url":"https://api.github.com/users/trevnorris/following{/other_user}","gists_url":"https://api.github.com/users/trevnorris/gists{/gist_id}","starred_url":"https://api.github.com/users/trevnorris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevnorris/subscriptions","organizations_url":"https://api.github.com/users/trevnorris/orgs","repos_url":"https://api.github.com/users/trevnorris/repos","events_url":"https://api.github.com/users/trevnorris/events{/privacy}","received_events_url":"https://api.github.com/users/trevnorris/received_events","type":"User","site_admin":false},"body":"Squashed for simplicity. There are also changes in the naming of some of the native API's so what it's called actually reflects what is going on. Also added a few TODO's, etc.\r\n\r\nReview, comment, and if necessary I'll break up the commits into relevant segments.\r\n\r\nAlso, didn't add https://github.com/tjfontaine/node/commit/6a74d6c to the changes. If that conditional is hit then there's a bug in the code. I'd rather add an `ASSERT()` or the like that can be reported instead of silently ignored.\r\n\r\n/cc @tjfontaine @indutny @orangemocha","created_at":"2014-08-08T17:04:51Z","updated_at":"2014-10-15T16:16:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"be9497dfef3834436dc415b6e9f22bfce05be4b0","assignee":{"login":"trevnorris","id":289174,"avatar_url":"https://avatars.githubusercontent.com/u/289174?v=2","gravatar_id":"","url":"https://api.github.com/users/trevnorris","html_url":"https://github.com/trevnorris","followers_url":"https://api.github.com/users/trevnorris/followers","following_url":"https://api.github.com/users/trevnorris/following{/other_user}","gists_url":"https://api.github.com/users/trevnorris/gists{/gist_id}","starred_url":"https://api.github.com/users/trevnorris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevnorris/subscriptions","organizations_url":"https://api.github.com/users/trevnorris/orgs","repos_url":"https://api.github.com/users/trevnorris/repos","events_url":"https://api.github.com/users/trevnorris/events{/privacy}","received_events_url":"https://api.github.com/users/trevnorris/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/joyent/node/milestones/17","labels_url":"https://api.github.com/repos/joyent/node/milestones/17/labels","id":210311,"number":17,"title":"v0.12","description":"","creator":{"login":"isaacs","id":9287,"avatar_url":"https://avatars.githubusercontent.com/u/9287?v=2","gravatar_id":"","url":"https://api.github.com/users/isaacs","html_url":"https://github.com/isaacs","followers_url":"https://api.github.com/users/isaacs/followers","following_url":"https://api.github.com/users/isaacs/following{/other_user}","gists_url":"https://api.github.com/users/isaacs/gists{/gist_id}","starred_url":"https://api.github.com/users/isaacs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaacs/subscriptions","organizations_url":"https://api.github.com/users/isaacs/orgs","repos_url":"https://api.github.com/users/isaacs/repos","events_url":"https://api.github.com/users/isaacs/events{/privacy}","received_events_url":"https://api.github.com/users/isaacs/received_events","type":"User","site_admin":false},"open_issues":29,"closed_issues":120,"state":"open","created_at":"2012-11-09T16:59:38Z","updated_at":"2014-10-01T22:09:54Z","due_on":null},"commits_url":"https://api.github.com/repos/joyent/node/pulls/8110/commits","review_comments_url":"https://api.github.com/repos/joyent/node/pulls/8110/comments","review_comment_url":"https://api.github.com/repos/joyent/node/pulls/comments/{number}","comments_url":"https://api.github.com/repos/joyent/node/issues/8110/comments","statuses_url":"https://api.github.com/repos/joyent/node/statuses/7a5760894ab554aef491ac46fdb6a5a94941ecfb","head":{"label":"trevnorris:remove-al-js","ref":"remove-al-js","sha":"7a5760894ab554aef491ac46fdb6a5a94941ecfb","user":{"login":"trevnorris","id":289174,"avatar_url":"https://avatars.githubusercontent.com/u/289174?v=2","gravatar_id":"","url":"https://api.github.com/users/trevnorris","html_url":"https://github.com/trevnorris","followers_url":"https://api.github.com/users/trevnorris/followers","following_url":"https://api.github.com/users/trevnorris/following{/other_user}","gists_url":"https://api.github.com/users/trevnorris/gists{/gist_id}","starred_url":"https://api.github.com/users/trevnorris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevnorris/subscriptions","organizations_url":"https://api.github.com/users/trevnorris/orgs","repos_url":"https://api.github.com/users/trevnorris/repos","events_url":"https://api.github.com/users/trevnorris/events{/privacy}","received_events_url":"https://api.github.com/users/trevnorris/received_events","type":"User","site_admin":false},"repo":{"id":6449404,"name":"node","full_name":"trevnorris/node","owner":{"login":"trevnorris","id":289174,"avatar_url":"https://avatars.githubusercontent.com/u/289174?v=2","gravatar_id":"","url":"https://api.github.com/users/trevnorris","html_url":"https://github.com/trevnorris","followers_url":"https://api.github.com/users/trevnorris/followers","following_url":"https://api.github.com/users/trevnorris/following{/other_user}","gists_url":"https://api.github.com/users/trevnorris/gists{/gist_id}","starred_url":"https://api.github.com/users/trevnorris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevnorris/subscriptions","organizations_url":"https://api.github.com/users/trevnorris/orgs","repos_url":"https://api.github.com/users/trevnorris/repos","events_url":"https://api.github.com/users/trevnorris/events{/privacy}","received_events_url":"https://api.github.com/users/trevnorris/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/trevnorris/node","description":"evented I/O for v8 javascript","fork":true,"url":"https://api.github.com/repos/trevnorris/node","forks_url":"https://api.github.com/repos/trevnorris/node/forks","keys_url":"https://api.github.com/repos/trevnorris/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trevnorris/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trevnorris/node/teams","hooks_url":"https://api.github.com/repos/trevnorris/node/hooks","issue_events_url":"https://api.github.com/repos/trevnorris/node/issues/events{/number}","events_url":"https://api.github.com/repos/trevnorris/node/events","assignees_url":"https://api.github.com/repos/trevnorris/node/assignees{/user}","branches_url":"https://api.github.com/repos/trevnorris/node/branches{/branch}","tags_url":"https://api.github.com/repos/trevnorris/node/tags","blobs_url":"https://api.github.com/repos/trevnorris/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trevnorris/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trevnorris/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/trevnorris/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trevnorris/node/statuses/{sha}","languages_url":"https://api.github.com/repos/trevnorris/node/languages","stargazers_url":"https://api.github.com/repos/trevnorris/node/stargazers","contributors_url":"https://api.github.com/repos/trevnorris/node/contributors","subscribers_url":"https://api.github.com/repos/trevnorris/node/subscribers","subscription_url":"https://api.github.com/repos/trevnorris/node/subscription","commits_url":"https://api.github.com/repos/trevnorris/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/trevnorris/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/trevnorris/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/trevnorris/node/issues/comments/{number}","contents_url":"https://api.github.com/repos/trevnorris/node/contents/{+path}","compare_url":"https://api.github.com/repos/trevnorris/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trevnorris/node/merges","archive_url":"https://api.github.com/repos/trevnorris/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trevnorris/node/downloads","issues_url":"https://api.github.com/repos/trevnorris/node/issues{/number}","pulls_url":"https://api.github.com/repos/trevnorris/node/pulls{/number}","milestones_url":"https://api.github.com/repos/trevnorris/node/milestones{/number}","notifications_url":"https://api.github.com/repos/trevnorris/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trevnorris/node/labels{/name}","releases_url":"https://api.github.com/repos/trevnorris/node/releases{/id}","created_at":"2012-10-29T23:35:35Z","updated_at":"2014-09-01T10:57:59Z","pushed_at":"2014-10-15T10:44:03Z","git_url":"git://github.com/trevnorris/node.git","ssh_url":"git@github.com:trevnorris/node.git","clone_url":"https://github.com/trevnorris/node.git","svn_url":"https://github.com/trevnorris/node","homepage":"http://nodejs.org/","size":110732,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"joyent:v0.12","ref":"v0.12","sha":"874dd590cf385baa534556eadee0fa5c2f985519","user":{"login":"joyent","id":10161,"avatar_url":"https://avatars.githubusercontent.com/u/10161?v=2","gravatar_id":"","url":"https://api.github.com/users/joyent","html_url":"https://github.com/joyent","followers_url":"https://api.github.com/users/joyent/followers","following_url":"https://api.github.com/users/joyent/following{/other_user}","gists_url":"https://api.github.com/users/joyent/gists{/gist_id}","starred_url":"https://api.github.com/users/joyent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joyent/subscriptions","organizations_url":"https://api.github.com/users/joyent/orgs","repos_url":"https://api.github.com/users/joyent/repos","events_url":"https://api.github.com/users/joyent/events{/privacy}","received_events_url":"https://api.github.com/users/joyent/received_events","type":"Organization","site_admin":false},"repo":{"id":211666,"name":"node","full_name":"joyent/node","owner":{"login":"joyent","id":10161,"avatar_url":"https://avatars.githubusercontent.com/u/10161?v=2","gravatar_id":"","url":"https://api.github.com/users/joyent","html_url":"https://github.com/joyent","followers_url":"https://api.github.com/users/joyent/followers","following_url":"https://api.github.com/users/joyent/following{/other_user}","gists_url":"https://api.github.com/users/joyent/gists{/gist_id}","starred_url":"https://api.github.com/users/joyent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joyent/subscriptions","organizations_url":"https://api.github.com/users/joyent/orgs","repos_url":"https://api.github.com/users/joyent/repos","events_url":"https://api.github.com/users/joyent/events{/privacy}","received_events_url":"https://api.github.com/users/joyent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joyent/node","description":"evented I/O for v8 javascript","fork":false,"url":"https://api.github.com/repos/joyent/node","forks_url":"https://api.github.com/repos/joyent/node/forks","keys_url":"https://api.github.com/repos/joyent/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joyent/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joyent/node/teams","hooks_url":"https://api.github.com/repos/joyent/node/hooks","issue_events_url":"https://api.github.com/repos/joyent/node/issues/events{/number}","events_url":"https://api.github.com/repos/joyent/node/events","assignees_url":"https://api.github.com/repos/joyent/node/assignees{/user}","branches_url":"https://api.github.com/repos/joyent/node/branches{/branch}","tags_url":"https://api.github.com/repos/joyent/node/tags","blobs_url":"https://api.github.com/repos/joyent/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joyent/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joyent/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/joyent/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joyent/node/statuses/{sha}","languages_url":"https://api.github.com/repos/joyent/node/languages","stargazers_url":"https://api.github.com/repos/joyent/node/stargazers","contributors_url":"https://api.github.com/repos/joyent/node/contributors","subscribers_url":"https://api.github.com/repos/joyent/node/subscribers","subscription_url":"https://api.github.com/repos/joyent/node/subscription","commits_url":"https://api.github.com/repos/joyent/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/joyent/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/joyent/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/joyent/node/issues/comments/{number}","contents_url":"https://api.github.com/repos/joyent/node/contents/{+path}","compare_url":"https://api.github.com/repos/joyent/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joyent/node/merges","archive_url":"https://api.github.com/repos/joyent/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joyent/node/downloads","issues_url":"https://api.github.com/repos/joyent/node/issues{/number}","pulls_url":"https://api.github.com/repos/joyent/node/pulls{/number}","milestones_url":"https://api.github.com/repos/joyent/node/milestones{/number}","notifications_url":"https://api.github.com/repos/joyent/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joyent/node/labels{/name}","releases_url":"https://api.github.com/repos/joyent/node/releases{/id}","created_at":"2009-05-27T16:29:46Z","updated_at":"2014-10-15T15:13:56Z","pushed_at":"2014-10-15T15:40:07Z","git_url":"git://github.com/joyent/node.git","ssh_url":"git@github.com:joyent/node.git","clone_url":"https://github.com/joyent/node.git","svn_url":"https://github.com/joyent/node","homepage":"http://nodejs.org/","size":493682,"stargazers_count":32561,"watchers_count":32561,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":7253,"mirror_url":null,"open_issues_count":935,"forks":7253,"open_issues":935,"watchers":32561,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/joyent/node/pulls/8110"},"html":{"href":"https://github.com/joyent/node/pull/8110"},"issue":{"href":"https://api.github.com/repos/joyent/node/issues/8110"},"comments":{"href":"https://api.github.com/repos/joyent/node/issues/8110/comments"},"review_comments":{"href":"https://api.github.com/repos/joyent/node/pulls/8110/comments"},"review_comment":{"href":"https://api.github.com/repos/joyent/node/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/joyent/node/pulls/8110/commits"},"statuses":{"href":"https://api.github.com/repos/joyent/node/statuses/7a5760894ab554aef491ac46fdb6a5a94941ecfb"}}}}