GitHub PullRequestReviewCommentEvent at 2014-10-21 16:31:27
Repository: spring-integration
Actor: artembilan
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/spring-projects/spring-integration/pulls/comments/19160142","id":19160142,"diff_hunk":"@@ -292,6 +307,26 @@ else if (isCustomBean) {\n \t\theaders.put(headerName, valueProcessorBuilder.getBeanDefinition());\n \t}\n \n+\tprivate List<String> populateRoutingSlipValue(String value, ParserContext parserContext) {\n+\t\tString[] values = StringUtils.tokenizeToStringArray(value, \";\");\n+\t\tList<String> routingSlipPath = new ManagedList<String>(values.length);\n+\t\tfor (String s : values) {\n+\t\t\tif (s.startsWith(\"#{\")) {","path":"spring-integration-core/src/main/java/org/springframework/integration/config/xml/HeaderEnricherParserSupport.java","position":53,"original_position":53,"commit_id":"cc10429f5b3b78d331c59e2266336f036dc50442","original_commit_id":"cc10429f5b3b78d331c59e2266336f036dc50442","user":{"login":"artembilan","id":1071590,"avatar_url":"https://avatars.githubusercontent.com/u/1071590?v=2","gravatar_id":"","url":"https://api.github.com/users/artembilan","html_url":"https://github.com/artembilan","followers_url":"https://api.github.com/users/artembilan/followers","following_url":"https://api.github.com/users/artembilan/following{/other_user}","gists_url":"https://api.github.com/users/artembilan/gists{/gist_id}","starred_url":"https://api.github.com/users/artembilan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artembilan/subscriptions","organizations_url":"https://api.github.com/users/artembilan/orgs","repos_url":"https://api.github.com/users/artembilan/repos","events_url":"https://api.github.com/users/artembilan/events{/privacy}","received_events_url":"https://api.github.com/users/artembilan/received_events","type":"User","site_admin":false},"body":"Well, as you see my general premise just to have `List<String>`, which is usable in the distributed system, when each item on the background just is a `bean name` in the ctx. That's why I need some identification to sever expression to populate `ExpressionEvaluationRoutingSlipRouteStrategy` beans and use the name of the last one in the target `routingSlipPath`.\r\n\r\nAny thoughts now ?","created_at":"2014-10-21T16:31:27Z","updated_at":"2014-10-21T16:31:27Z","html_url":"https://github.com/spring-projects/spring-integration/pull/1280#discussion_r19160142","pull_request_url":"https://api.github.com/repos/spring-projects/spring-integration/pulls/1280","_links":{"self":{"href":"https://api.github.com/repos/spring-projects/spring-integration/pulls/comments/19160142"},"html":{"href":"https://github.com/spring-projects/spring-integration/pull/1280#discussion_r19160142"},"pull_request":{"href":"https://api.github.com/repos/spring-projects/spring-integration/pulls/1280"}}},"pull_request":{"url":"https://api.github.com/repos/spring-projects/spring-integration/pulls/1280","id":21295520,"html_url":"https://github.com/spring-projects/spring-integration/pull/1280","diff_url":"https://github.com/spring-projects/spring-integration/pull/1280.diff","patch_url":"https://github.com/spring-projects/spring-integration/pull/1280.patch","issue_url":"https://api.github.com/repos/spring-projects/spring-integration/issues/1280","number":1280,"state":"open","locked":false,"title":"INT-267: Implement RoutingSlip pattern","user":{"login":"artembilan","id":1071590,"avatar_url":"https://avatars.githubusercontent.com/u/1071590?v=2","gravatar_id":"","url":"https://api.github.com/users/artembilan","html_url":"https://github.com/artembilan","followers_url":"https://api.github.com/users/artembilan/followers","following_url":"https://api.github.com/users/artembilan/following{/other_user}","gists_url":"https://api.github.com/users/artembilan/gists{/gist_id}","starred_url":"https://api.github.com/users/artembilan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artembilan/subscriptions","organizations_url":"https://api.github.com/users/artembilan/orgs","repos_url":"https://api.github.com/users/artembilan/repos","events_url":"https://api.github.com/users/artembilan/events{/privacy}","received_events_url":"https://api.github.com/users/artembilan/received_events","type":"User","site_admin":false},"body":"JIRA: https://jira.spring.io/browse/INT-267\r\n\r\nThe implementation looks like:\r\n* There is the `ROUTING_SLIP` header to keep the list of bean ids;\r\n* The `ROUTING_SLIP_INDEX` header keeps track of current `index` in the `ROUTING_SLIP` header;\r\n* `ROUTING_SLIP` List can contain channel names or bean references for the `RoutingSlip` strategy implementations.\r\nThey are differentiated with `@` prefix;\r\n* The `<header-enricher>` adds `<routing-slip>` sub-element to specify the comma-delimited value for desired `ROUTING_SLIP` for the downstream flow;\r\n* The `AbstractReplyProducingMessageHandler` adds the logic to get deal with `ROUTING_SLIP` List and the algorithm is:\r\n    - If `ROUTING_SLIP` isn't `null` we build `AtomicInteger` for the current `routingSlipIndex`;\r\n    - the recursive `getReplyChannelFromRoutingSlip` should return a channel name or `null`;\r\n    - if current `ROUTING_SLIP_INDEX` if for the `RoutingSlip` strategy, we check its result for `null` and `incrementAndGet()` the current index or not;\r\n    - for the simple channel name value from `ROUTING_SLIP` list we just `incrementAndGet()` the current index and return the value;\r\n    - the new `ROUTING_SLIP_INDEX` is populated to the headers of new reply message.\r\n* Polishing for `AbstractMessageSplitter`\r\n\r\n**TODO**: Docs and applying `RoutingSlip` algorithm for the `AbstractCorrelatingMessageHandler`","created_at":"2014-09-16T12:51:26Z","updated_at":"2014-10-21T16:31:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3b60eed28d959733763afa4fba6f6626abacfd81","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/spring-projects/spring-integration/pulls/1280/commits","review_comments_url":"https://api.github.com/repos/spring-projects/spring-integration/pulls/1280/comments","review_comment_url":"https://api.github.com/repos/spring-projects/spring-integration/pulls/comments/{number}","comments_url":"https://api.github.com/repos/spring-projects/spring-integration/issues/1280/comments","statuses_url":"https://api.github.com/repos/spring-projects/spring-integration/statuses/cc10429f5b3b78d331c59e2266336f036dc50442","head":{"label":"artembilan:INT-267","ref":"INT-267","sha":"cc10429f5b3b78d331c59e2266336f036dc50442","user":{"login":"artembilan","id":1071590,"avatar_url":"https://avatars.githubusercontent.com/u/1071590?v=2","gravatar_id":"","url":"https://api.github.com/users/artembilan","html_url":"https://github.com/artembilan","followers_url":"https://api.github.com/users/artembilan/followers","following_url":"https://api.github.com/users/artembilan/following{/other_user}","gists_url":"https://api.github.com/users/artembilan/gists{/gist_id}","starred_url":"https://api.github.com/users/artembilan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artembilan/subscriptions","organizations_url":"https://api.github.com/users/artembilan/orgs","repos_url":"https://api.github.com/users/artembilan/repos","events_url":"https://api.github.com/users/artembilan/events{/privacy}","received_events_url":"https://api.github.com/users/artembilan/received_events","type":"User","site_admin":false},"repo":{"id":2686240,"name":"spring-integration","full_name":"artembilan/spring-integration","owner":{"login":"artembilan","id":1071590,"avatar_url":"https://avatars.githubusercontent.com/u/1071590?v=2","gravatar_id":"","url":"https://api.github.com/users/artembilan","html_url":"https://github.com/artembilan","followers_url":"https://api.github.com/users/artembilan/followers","following_url":"https://api.github.com/users/artembilan/following{/other_user}","gists_url":"https://api.github.com/users/artembilan/gists{/gist_id}","starred_url":"https://api.github.com/users/artembilan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artembilan/subscriptions","organizations_url":"https://api.github.com/users/artembilan/orgs","repos_url":"https://api.github.com/users/artembilan/repos","events_url":"https://api.github.com/users/artembilan/events{/privacy}","received_events_url":"https://api.github.com/users/artembilan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/artembilan/spring-integration","description":"","fork":true,"url":"https://api.github.com/repos/artembilan/spring-integration","forks_url":"https://api.github.com/repos/artembilan/spring-integration/forks","keys_url":"https://api.github.com/repos/artembilan/spring-integration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artembilan/spring-integration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artembilan/spring-integration/teams","hooks_url":"https://api.github.com/repos/artembilan/spring-integration/hooks","issue_events_url":"https://api.github.com/repos/artembilan/spring-integration/issues/events{/number}","events_url":"https://api.github.com/repos/artembilan/spring-integration/events","assignees_url":"https://api.github.com/repos/artembilan/spring-integration/assignees{/user}","branches_url":"https://api.github.com/repos/artembilan/spring-integration/branches{/branch}","tags_url":"https://api.github.com/repos/artembilan/spring-integration/tags","blobs_url":"https://api.github.com/repos/artembilan/spring-integration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artembilan/spring-integration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artembilan/spring-integration/git/refs{/sha}","trees_url":"https://api.github.com/repos/artembilan/spring-integration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artembilan/spring-integration/statuses/{sha}","languages_url":"https://api.github.com/repos/artembilan/spring-integration/languages","stargazers_url":"https://api.github.com/repos/artembilan/spring-integration/stargazers","contributors_url":"https://api.github.com/repos/artembilan/spring-integration/contributors","subscribers_url":"https://api.github.com/repos/artembilan/spring-integration/subscribers","subscription_url":"https://api.github.com/repos/artembilan/spring-integration/subscription","commits_url":"https://api.github.com/repos/artembilan/spring-integration/commits{/sha}","git_commits_url":"https://api.github.com/repos/artembilan/spring-integration/git/commits{/sha}","comments_url":"https://api.github.com/repos/artembilan/spring-integration/comments{/number}","issue_comment_url":"https://api.github.com/repos/artembilan/spring-integration/issues/comments/{number}","contents_url":"https://api.github.com/repos/artembilan/spring-integration/contents/{+path}","compare_url":"https://api.github.com/repos/artembilan/spring-integration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artembilan/spring-integration/merges","archive_url":"https://api.github.com/repos/artembilan/spring-integration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artembilan/spring-integration/downloads","issues_url":"https://api.github.com/repos/artembilan/spring-integration/issues{/number}","pulls_url":"https://api.github.com/repos/artembilan/spring-integration/pulls{/number}","milestones_url":"https://api.github.com/repos/artembilan/spring-integration/milestones{/number}","notifications_url":"https://api.github.com/repos/artembilan/spring-integration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artembilan/spring-integration/labels{/name}","releases_url":"https://api.github.com/repos/artembilan/spring-integration/releases{/id}","created_at":"2011-11-01T08:04:04Z","updated_at":"2014-08-27T10:52:48Z","pushed_at":"2014-10-21T13:48:41Z","git_url":"git://github.com/artembilan/spring-integration.git","ssh_url":"git@github.com:artembilan/spring-integration.git","clone_url":"https://github.com/artembilan/spring-integration.git","svn_url":"https://github.com/artembilan/spring-integration","homepage":"","size":37180,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"spring-projects:master","ref":"master","sha":"328bd687024d40b10897c4b82b48b30f1282a125","user":{"login":"spring-projects","id":317776,"avatar_url":"https://avatars.githubusercontent.com/u/317776?v=2","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"repo":{"id":2090979,"name":"spring-integration","full_name":"spring-projects/spring-integration","owner":{"login":"spring-projects","id":317776,"avatar_url":"https://avatars.githubusercontent.com/u/317776?v=2","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-projects/spring-integration","description":"Spring Integration provides an extension of the Spring programming model to support the well-known Enterprise Integration Patterns (EIP)","fork":false,"url":"https://api.github.com/repos/spring-projects/spring-integration","forks_url":"https://api.github.com/repos/spring-projects/spring-integration/forks","keys_url":"https://api.github.com/repos/spring-projects/spring-integration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-projects/spring-integration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-projects/spring-integration/teams","hooks_url":"https://api.github.com/repos/spring-projects/spring-integration/hooks","issue_events_url":"https://api.github.com/repos/spring-projects/spring-integration/issues/events{/number}","events_url":"https://api.github.com/repos/spring-projects/spring-integration/events","assignees_url":"https://api.github.com/repos/spring-projects/spring-integration/assignees{/user}","branches_url":"https://api.github.com/repos/spring-projects/spring-integration/branches{/branch}","tags_url":"https://api.github.com/repos/spring-projects/spring-integration/tags","blobs_url":"https://api.github.com/repos/spring-projects/spring-integration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-projects/spring-integration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-projects/spring-integration/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-projects/spring-integration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-projects/spring-integration/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-projects/spring-integration/languages","stargazers_url":"https://api.github.com/repos/spring-projects/spring-integration/stargazers","contributors_url":"https://api.github.com/repos/spring-projects/spring-integration/contributors","subscribers_url":"https://api.github.com/repos/spring-projects/spring-integration/subscribers","subscription_url":"https://api.github.com/repos/spring-projects/spring-integration/subscription","commits_url":"https://api.github.com/repos/spring-projects/spring-integration/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-projects/spring-integration/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-projects/spring-integration/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-projects/spring-integration/issues/comments/{number}","contents_url":"https://api.github.com/repos/spring-projects/spring-integration/contents/{+path}","compare_url":"https://api.github.com/repos/spring-projects/spring-integration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-projects/spring-integration/merges","archive_url":"https://api.github.com/repos/spring-projects/spring-integration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-projects/spring-integration/downloads","issues_url":"https://api.github.com/repos/spring-projects/spring-integration/issues{/number}","pulls_url":"https://api.github.com/repos/spring-projects/spring-integration/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-projects/spring-integration/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-projects/spring-integration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-projects/spring-integration/labels{/name}","releases_url":"https://api.github.com/repos/spring-projects/spring-integration/releases{/id}","created_at":"2011-07-22T21:47:27Z","updated_at":"2014-10-17T05:26:08Z","pushed_at":"2014-10-21T14:03:52Z","git_url":"git://github.com/spring-projects/spring-integration.git","ssh_url":"git@github.com:spring-projects/spring-integration.git","clone_url":"https://github.com/spring-projects/spring-integration.git","svn_url":"https://github.com/spring-projects/spring-integration","homepage":"http://projects.spring.io/spring-integration/","size":86333,"stargazers_count":289,"watchers_count":289,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":268,"mirror_url":null,"open_issues_count":8,"forks":268,"open_issues":8,"watchers":289,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-projects/spring-integration/pulls/1280"},"html":{"href":"https://github.com/spring-projects/spring-integration/pull/1280"},"issue":{"href":"https://api.github.com/repos/spring-projects/spring-integration/issues/1280"},"comments":{"href":"https://api.github.com/repos/spring-projects/spring-integration/issues/1280/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-projects/spring-integration/pulls/1280/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-projects/spring-integration/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/spring-projects/spring-integration/pulls/1280/commits"},"statuses":{"href":"https://api.github.com/repos/spring-projects/spring-integration/statuses/cc10429f5b3b78d331c59e2266336f036dc50442"}}}}