GitHub PullRequestReviewCommentEvent at 2014-04-01 09:06:02
Repository: symfony
Actor: stof
Payload: {"comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/11152439","id":11152439,"diff_hunk":"@@ -101,6 +102,31 @@ public function setFactoryMethod($factoryMethod)\n     }\n \n     /**\n+     * Sets the service that this service is decorating.\n+     *\n+     * @param string $id        The decorated service id\n+     * @param string $renamedId The new decorated service id\n+     */\n+    public function setDecoratedService($id, $renamedId = null)\n+    {\n+        if ($renamedId && $id == $renamedId) {\n+            throw new \\LogicException(sprintf('The decorated service inner name for \"%s\" must be different than the service name itself.', $id));","path":"src/Symfony/Component/DependencyInjection/Definition.php","position":20,"original_position":20,"commit_id":"fd6d338259a26978c1af3f654d3999449b3a0f2b","original_commit_id":"fd6d338259a26978c1af3f654d3999449b3a0f2b","user":{"login":"stof","id":439401,"avatar_url":"https://avatars.githubusercontent.com/u/439401?","gravatar_id":"7894bbdf1c05b18a1444ad8c76c9d583","url":"https://api.github.com/users/stof","html_url":"https://github.com/stof","followers_url":"https://api.github.com/users/stof/followers","following_url":"https://api.github.com/users/stof/following{/other_user}","gists_url":"https://api.github.com/users/stof/gists{/gist_id}","starred_url":"https://api.github.com/users/stof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stof/subscriptions","organizations_url":"https://api.github.com/users/stof/orgs","repos_url":"https://api.github.com/users/stof/repos","events_url":"https://api.github.com/users/stof/events{/privacy}","received_events_url":"https://api.github.com/users/stof/received_events","type":"User","site_admin":false},"body":"I would use ``InvalidArgumentException``","created_at":"2014-04-01T09:06:02Z","updated_at":"2014-04-01T09:06:02Z","html_url":"https://github.com/symfony/symfony/pull/10600#discussion_r11152439","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/10600","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/11152439"},"html":{"href":"https://github.com/symfony/symfony/pull/10600#discussion_r11152439"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/10600"}}}}