GitHub PullRequestReviewCommentEvent at 2014-03-25 11:08:31
Repository: PHPWord
Actor: ivanlanin
Payload: {"comment":{"url":"https://api.github.com/repos/PHPOffice/PHPWord/pulls/comments/10925176","id":10925176,"diff_hunk":"@@ -134,15 +134,13 @@ public function addTable($style = null)\n     public function addImage($src, $style = null)\n     {\n         $image = new Image($src, $style);\n-\n         if (!is_null($image->getSource())) {\n-            $rID = Media::addFooterMediaElement($this->_footerCount, $src);\n+            $rID = Media::addFooterMediaElement($this->_footerCount, $src, $image);\n             $image->setRelationId($rID);\n-\n             $this->_elementCollection[] = $image;\n             return $image;\n         } else {\n-            throw new Exception('Src does not exist or invalid image type.');\n+            throw new Exception('Source does not exist or unsupported image type.');","path":"src/PhpWord/Section/Footer.php","position":null,"original_position":14,"commit_id":"8aba90ded9a11b00c4dfda4e69432b7fcd832119","original_commit_id":"3b020f660c6aa6fc2381493b228c4742466deddc","user":{"login":"ivanlanin","id":15313,"avatar_url":"https://avatars.githubusercontent.com/u/15313?","gravatar_id":"a96f4753f95f4d48fe104f7575eaccb6","url":"https://api.github.com/users/ivanlanin","html_url":"https://github.com/ivanlanin","followers_url":"https://api.github.com/users/ivanlanin/followers","following_url":"https://api.github.com/users/ivanlanin/following{/other_user}","gists_url":"https://api.github.com/users/ivanlanin/gists{/gist_id}","starred_url":"https://api.github.com/users/ivanlanin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivanlanin/subscriptions","organizations_url":"https://api.github.com/users/ivanlanin/orgs","repos_url":"https://api.github.com/users/ivanlanin/repos","events_url":"https://api.github.com/users/ivanlanin/events{/privacy}","received_events_url":"https://api.github.com/users/ivanlanin/received_events","type":"User","site_admin":false},"body":"Ok. Thanks. I guess that's also the benefit of forcing ourself to create unit tests for our own code: remove useless parts of code.","created_at":"2014-03-25T11:08:31Z","updated_at":"2014-03-25T11:08:31Z","html_url":"https://github.com/PHPOffice/PHPWord/pull/169#discussion_r10925176","pull_request_url":"https://api.github.com/repos/PHPOffice/PHPWord/pulls/169","_links":{"self":{"href":"https://api.github.com/repos/PHPOffice/PHPWord/pulls/comments/10925176"},"html":{"href":"https://github.com/PHPOffice/PHPWord/pull/169#discussion_r10925176"},"pull_request":{"href":"https://api.github.com/repos/PHPOffice/PHPWord/pulls/169"}}}}