GitHub PullRequestReviewCommentEvent at 2014-10-23 04:05:17
Repository: sbt-remote-control
Actor: xuwei-k
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/sbt/sbt-remote-control/pulls/comments/19258700","id":19258700,"diff_hunk":"@@ -544,3 +544,21 @@ object ByteArray {\n }\n \n final case class ModuleId(organization: String, name: String, attributes: Map[String, String])\n+\n+private[sbt] object StructurallyEqual {\n+  // Exclude sourceFile from comparison\n+  def equals(lhs: xsbti.Position, rhs: xsbti.Position): Boolean =\n+    equals(lhs.line, rhs.line) &&\n+      equals(lhs.offset, rhs.offset) &&\n+      equals(lhs.pointer, rhs.pointer) &&\n+      equals(lhs.pointerSpace, rhs.pointerSpace) &&\n+      equals(lhs.sourcePath, rhs.sourcePath) &&\n+      equals(lhs.lineContent, rhs.lineContent)\n+\n+  def equals[A](lhs: xsbti.Maybe[A], rhs: xsbti.Maybe[A]): Boolean =\n+    if (lhs.isDefined != rhs.isDefined) false\n+    else if (!lhs.isDefined) true","path":"commons/protocol/src/main/scala/sbt/protocol/Protocol.scala","position":17,"original_position":17,"commit_id":"170776e7512fe7c7be51a9f357e9a55674eb8d21","original_commit_id":"170776e7512fe7c7be51a9f357e9a55674eb8d21","user":{"login":"xuwei-k","id":389787,"avatar_url":"https://avatars.githubusercontent.com/u/389787?v=2","gravatar_id":"","url":"https://api.github.com/users/xuwei-k","html_url":"https://github.com/xuwei-k","followers_url":"https://api.github.com/users/xuwei-k/followers","following_url":"https://api.github.com/users/xuwei-k/following{/other_user}","gists_url":"https://api.github.com/users/xuwei-k/gists{/gist_id}","starred_url":"https://api.github.com/users/xuwei-k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xuwei-k/subscriptions","organizations_url":"https://api.github.com/users/xuwei-k/orgs","repos_url":"https://api.github.com/users/xuwei-k/repos","events_url":"https://api.github.com/users/xuwei-k/events{/privacy}","received_events_url":"https://api.github.com/users/xuwei-k/received_events","type":"User","site_admin":false},"body":"```scala\r\n else if (!lhs.isDefined && !rhs.isDefined) true\r\n```\r\n\r\n?","created_at":"2014-10-23T04:05:17Z","updated_at":"2014-10-23T04:05:17Z","html_url":"https://github.com/sbt/sbt-remote-control/pull/223#discussion_r19258700","pull_request_url":"https://api.github.com/repos/sbt/sbt-remote-control/pulls/223","_links":{"self":{"href":"https://api.github.com/repos/sbt/sbt-remote-control/pulls/comments/19258700"},"html":{"href":"https://github.com/sbt/sbt-remote-control/pull/223#discussion_r19258700"},"pull_request":{"href":"https://api.github.com/repos/sbt/sbt-remote-control/pulls/223"}}},"pull_request":{"url":"https://api.github.com/repos/sbt/sbt-remote-control/pulls/223","id":23205464,"html_url":"https://github.com/sbt/sbt-remote-control/pull/223","diff_url":"https://github.com/sbt/sbt-remote-control/pull/223.diff","patch_url":"https://github.com/sbt/sbt-remote-control/pull/223.patch","issue_url":"https://api.github.com/repos/sbt/sbt-remote-control/issues/223","number":223,"state":"open","locked":false,"title":"starting one-way trip","user":{"login":"eed3si9n","id":184683,"avatar_url":"https://avatars.githubusercontent.com/u/184683?v=2","gravatar_id":"","url":"https://api.github.com/users/eed3si9n","html_url":"https://github.com/eed3si9n","followers_url":"https://api.github.com/users/eed3si9n/followers","following_url":"https://api.github.com/users/eed3si9n/following{/other_user}","gists_url":"https://api.github.com/users/eed3si9n/gists{/gist_id}","starred_url":"https://api.github.com/users/eed3si9n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eed3si9n/subscriptions","organizations_url":"https://api.github.com/users/eed3si9n/orgs","repos_url":"https://api.github.com/users/eed3si9n/repos","events_url":"https://api.github.com/users/eed3si9n/events{/privacy}","received_events_url":"https://api.github.com/users/eed3si9n/received_events","type":"User","site_admin":false},"body":"Added tests for the current json serialization.\r\nThe purpose of the one-way trip is to persist the output into files, so we can verify that we can deserialize them back to protocol case classes as we change the serialization format and/or the case class.\r\n\r\n/cc @jsuereth \r\n","created_at":"2014-10-23T03:53:26Z","updated_at":"2014-10-23T04:05:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sbt/sbt-remote-control/pulls/223/commits","review_comments_url":"https://api.github.com/repos/sbt/sbt-remote-control/pulls/223/comments","review_comment_url":"https://api.github.com/repos/sbt/sbt-remote-control/pulls/comments/{number}","comments_url":"https://api.github.com/repos/sbt/sbt-remote-control/issues/223/comments","statuses_url":"https://api.github.com/repos/sbt/sbt-remote-control/statuses/170776e7512fe7c7be51a9f357e9a55674eb8d21","head":{"label":"sbt:wip/one-way-trip","ref":"wip/one-way-trip","sha":"170776e7512fe7c7be51a9f357e9a55674eb8d21","user":{"login":"sbt","id":1158012,"avatar_url":"https://avatars.githubusercontent.com/u/1158012?v=2","gravatar_id":"","url":"https://api.github.com/users/sbt","html_url":"https://github.com/sbt","followers_url":"https://api.github.com/users/sbt/followers","following_url":"https://api.github.com/users/sbt/following{/other_user}","gists_url":"https://api.github.com/users/sbt/gists{/gist_id}","starred_url":"https://api.github.com/users/sbt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbt/subscriptions","organizations_url":"https://api.github.com/users/sbt/orgs","repos_url":"https://api.github.com/users/sbt/repos","events_url":"https://api.github.com/users/sbt/events{/privacy}","received_events_url":"https://api.github.com/users/sbt/received_events","type":"Organization","site_admin":false},"repo":{"id":10946429,"name":"sbt-remote-control","full_name":"sbt/sbt-remote-control","owner":{"login":"sbt","id":1158012,"avatar_url":"https://avatars.githubusercontent.com/u/1158012?v=2","gravatar_id":"","url":"https://api.github.com/users/sbt","html_url":"https://github.com/sbt","followers_url":"https://api.github.com/users/sbt/followers","following_url":"https://api.github.com/users/sbt/following{/other_user}","gists_url":"https://api.github.com/users/sbt/gists{/gist_id}","starred_url":"https://api.github.com/users/sbt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbt/subscriptions","organizations_url":"https://api.github.com/users/sbt/orgs","repos_url":"https://api.github.com/users/sbt/repos","events_url":"https://api.github.com/users/sbt/events{/privacy}","received_events_url":"https://api.github.com/users/sbt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sbt/sbt-remote-control","description":"Create and manage sbt process using unicorns and forks","fork":false,"url":"https://api.github.com/repos/sbt/sbt-remote-control","forks_url":"https://api.github.com/repos/sbt/sbt-remote-control/forks","keys_url":"https://api.github.com/repos/sbt/sbt-remote-control/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sbt/sbt-remote-control/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sbt/sbt-remote-control/teams","hooks_url":"https://api.github.com/repos/sbt/sbt-remote-control/hooks","issue_events_url":"https://api.github.com/repos/sbt/sbt-remote-control/issues/events{/number}","events_url":"https://api.github.com/repos/sbt/sbt-remote-control/events","assignees_url":"https://api.github.com/repos/sbt/sbt-remote-control/assignees{/user}","branches_url":"https://api.github.com/repos/sbt/sbt-remote-control/branches{/branch}","tags_url":"https://api.github.com/repos/sbt/sbt-remote-control/tags","blobs_url":"https://api.github.com/repos/sbt/sbt-remote-control/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sbt/sbt-remote-control/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sbt/sbt-remote-control/git/refs{/sha}","trees_url":"https://api.github.com/repos/sbt/sbt-remote-control/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sbt/sbt-remote-control/statuses/{sha}","languages_url":"https://api.github.com/repos/sbt/sbt-remote-control/languages","stargazers_url":"https://api.github.com/repos/sbt/sbt-remote-control/stargazers","contributors_url":"https://api.github.com/repos/sbt/sbt-remote-control/contributors","subscribers_url":"https://api.github.com/repos/sbt/sbt-remote-control/subscribers","subscription_url":"https://api.github.com/repos/sbt/sbt-remote-control/subscription","commits_url":"https://api.github.com/repos/sbt/sbt-remote-control/commits{/sha}","git_commits_url":"https://api.github.com/repos/sbt/sbt-remote-control/git/commits{/sha}","comments_url":"https://api.github.com/repos/sbt/sbt-remote-control/comments{/number}","issue_comment_url":"https://api.github.com/repos/sbt/sbt-remote-control/issues/comments/{number}","contents_url":"https://api.github.com/repos/sbt/sbt-remote-control/contents/{+path}","compare_url":"https://api.github.com/repos/sbt/sbt-remote-control/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sbt/sbt-remote-control/merges","archive_url":"https://api.github.com/repos/sbt/sbt-remote-control/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sbt/sbt-remote-control/downloads","issues_url":"https://api.github.com/repos/sbt/sbt-remote-control/issues{/number}","pulls_url":"https://api.github.com/repos/sbt/sbt-remote-control/pulls{/number}","milestones_url":"https://api.github.com/repos/sbt/sbt-remote-control/milestones{/number}","notifications_url":"https://api.github.com/repos/sbt/sbt-remote-control/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sbt/sbt-remote-control/labels{/name}","releases_url":"https://api.github.com/repos/sbt/sbt-remote-control/releases{/id}","created_at":"2013-06-25T18:26:36Z","updated_at":"2014-09-23T22:08:53Z","pushed_at":"2014-10-23T03:50:40Z","git_url":"git://github.com/sbt/sbt-remote-control.git","ssh_url":"git@github.com:sbt/sbt-remote-control.git","clone_url":"https://github.com/sbt/sbt-remote-control.git","svn_url":"https://github.com/sbt/sbt-remote-control","homepage":null,"size":4243,"stargazers_count":30,"watchers_count":30,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":18,"forks":8,"open_issues":18,"watchers":30,"default_branch":"master"}},"base":{"label":"sbt:master","ref":"master","sha":"df8cb32bfd7d4e98797eed58fbb84dcae312500d","user":{"login":"sbt","id":1158012,"avatar_url":"https://avatars.githubusercontent.com/u/1158012?v=2","gravatar_id":"","url":"https://api.github.com/users/sbt","html_url":"https://github.com/sbt","followers_url":"https://api.github.com/users/sbt/followers","following_url":"https://api.github.com/users/sbt/following{/other_user}","gists_url":"https://api.github.com/users/sbt/gists{/gist_id}","starred_url":"https://api.github.com/users/sbt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbt/subscriptions","organizations_url":"https://api.github.com/users/sbt/orgs","repos_url":"https://api.github.com/users/sbt/repos","events_url":"https://api.github.com/users/sbt/events{/privacy}","received_events_url":"https://api.github.com/users/sbt/received_events","type":"Organization","site_admin":false},"repo":{"id":10946429,"name":"sbt-remote-control","full_name":"sbt/sbt-remote-control","owner":{"login":"sbt","id":1158012,"avatar_url":"https://avatars.githubusercontent.com/u/1158012?v=2","gravatar_id":"","url":"https://api.github.com/users/sbt","html_url":"https://github.com/sbt","followers_url":"https://api.github.com/users/sbt/followers","following_url":"https://api.github.com/users/sbt/following{/other_user}","gists_url":"https://api.github.com/users/sbt/gists{/gist_id}","starred_url":"https://api.github.com/users/sbt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbt/subscriptions","organizations_url":"https://api.github.com/users/sbt/orgs","repos_url":"https://api.github.com/users/sbt/repos","events_url":"https://api.github.com/users/sbt/events{/privacy}","received_events_url":"https://api.github.com/users/sbt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sbt/sbt-remote-control","description":"Create and manage sbt process using unicorns and forks","fork":false,"url":"https://api.github.com/repos/sbt/sbt-remote-control","forks_url":"https://api.github.com/repos/sbt/sbt-remote-control/forks","keys_url":"https://api.github.com/repos/sbt/sbt-remote-control/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sbt/sbt-remote-control/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sbt/sbt-remote-control/teams","hooks_url":"https://api.github.com/repos/sbt/sbt-remote-control/hooks","issue_events_url":"https://api.github.com/repos/sbt/sbt-remote-control/issues/events{/number}","events_url":"https://api.github.com/repos/sbt/sbt-remote-control/events","assignees_url":"https://api.github.com/repos/sbt/sbt-remote-control/assignees{/user}","branches_url":"https://api.github.com/repos/sbt/sbt-remote-control/branches{/branch}","tags_url":"https://api.github.com/repos/sbt/sbt-remote-control/tags","blobs_url":"https://api.github.com/repos/sbt/sbt-remote-control/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sbt/sbt-remote-control/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sbt/sbt-remote-control/git/refs{/sha}","trees_url":"https://api.github.com/repos/sbt/sbt-remote-control/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sbt/sbt-remote-control/statuses/{sha}","languages_url":"https://api.github.com/repos/sbt/sbt-remote-control/languages","stargazers_url":"https://api.github.com/repos/sbt/sbt-remote-control/stargazers","contributors_url":"https://api.github.com/repos/sbt/sbt-remote-control/contributors","subscribers_url":"https://api.github.com/repos/sbt/sbt-remote-control/subscribers","subscription_url":"https://api.github.com/repos/sbt/sbt-remote-control/subscription","commits_url":"https://api.github.com/repos/sbt/sbt-remote-control/commits{/sha}","git_commits_url":"https://api.github.com/repos/sbt/sbt-remote-control/git/commits{/sha}","comments_url":"https://api.github.com/repos/sbt/sbt-remote-control/comments{/number}","issue_comment_url":"https://api.github.com/repos/sbt/sbt-remote-control/issues/comments/{number}","contents_url":"https://api.github.com/repos/sbt/sbt-remote-control/contents/{+path}","compare_url":"https://api.github.com/repos/sbt/sbt-remote-control/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sbt/sbt-remote-control/merges","archive_url":"https://api.github.com/repos/sbt/sbt-remote-control/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sbt/sbt-remote-control/downloads","issues_url":"https://api.github.com/repos/sbt/sbt-remote-control/issues{/number}","pulls_url":"https://api.github.com/repos/sbt/sbt-remote-control/pulls{/number}","milestones_url":"https://api.github.com/repos/sbt/sbt-remote-control/milestones{/number}","notifications_url":"https://api.github.com/repos/sbt/sbt-remote-control/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sbt/sbt-remote-control/labels{/name}","releases_url":"https://api.github.com/repos/sbt/sbt-remote-control/releases{/id}","created_at":"2013-06-25T18:26:36Z","updated_at":"2014-09-23T22:08:53Z","pushed_at":"2014-10-23T03:50:40Z","git_url":"git://github.com/sbt/sbt-remote-control.git","ssh_url":"git@github.com:sbt/sbt-remote-control.git","clone_url":"https://github.com/sbt/sbt-remote-control.git","svn_url":"https://github.com/sbt/sbt-remote-control","homepage":null,"size":4243,"stargazers_count":30,"watchers_count":30,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":18,"forks":8,"open_issues":18,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sbt/sbt-remote-control/pulls/223"},"html":{"href":"https://github.com/sbt/sbt-remote-control/pull/223"},"issue":{"href":"https://api.github.com/repos/sbt/sbt-remote-control/issues/223"},"comments":{"href":"https://api.github.com/repos/sbt/sbt-remote-control/issues/223/comments"},"review_comments":{"href":"https://api.github.com/repos/sbt/sbt-remote-control/pulls/223/comments"},"review_comment":{"href":"https://api.github.com/repos/sbt/sbt-remote-control/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/sbt/sbt-remote-control/pulls/223/commits"},"statuses":{"href":"https://api.github.com/repos/sbt/sbt-remote-control/statuses/170776e7512fe7c7be51a9f357e9a55674eb8d21"}}}}