GitHub PushEvent at 2014-01-16 14:01:57
Repository: naemon-core
Actor: pengi
Payload: {"shas":[["cfa9c3b7397747ac9d40c68b182a1609cb186bed","354bdf36144dff18dcd4182fbe4ae582a62fa55e@op5.com","Add -Werror, and resolve compilation warnings.\n\nUsally a warning actually is a problem (like implicit declaration).\nNaemon was full name colissions between function argument names and\nsystem functionsn (like int time; vs. time(), objectlist *accept vs.\naccept())\n\nUsing -Werror, so those can easily be found and force the developer\nto fix is generally a good idea, so add -Werror and resolve the\nwarnings.\n\nChange-Id: If309428a2dc714c29fc4b2696758de861d4730ad\nSigned-off-by: Max Sikstrom <msikstrom@op5.com>","Max Sikstrom",true],["f132dd5fe4d3fed029c48c6ce761998ea5472b5c","354bdf36144dff18dcd4182fbe4ae582a62fa55e@op5.com","Cleanup headers, each header should contain references to its .c-file\n\nTo be able to refactor, and track dependencies, it's much better to\nkeep .c and .h-files in pairs, where prototypes for each function in\na certain .c-file is put in the corresponding .h-file.\n\nHistorically, almost everything is put in one or two .h-files, making\nit almost impossible to find the methods, and track dependencies,\nbecause everything is included in all .c-files in that case.\n\nThe include-all-header-file would still be nice to have, but only for\nuse in linked libraries, where dependencies only can exist from\nlibrary to application, and not vice versa. Therefore that\ninclude-all-header shouldn't be used anywhere within the application\nitself.\n\nChange-Id: Ib90870defb1f02b0752d987e4daa747fe54045e6\nSigned-off-by: Max Sikstrom <msikstrom@op5.com>","Max Sikstrom",true],["297673cfe5da30d0f50ca6fe3f6790f153f2d596","354bdf36144dff18dcd4182fbe4ae582a62fa55e@op5.com","Refactor: don't use naemon.h internally. Finish splitting\n\nAs the previous commit, include-everything-header is a bad idea within\na project itself. That makes it impossible to track dependencies within\nthe project. The naemon.h was a header like that.\n\nSplit up naemon.h to other header files, and include those instead.\nConvert naemon.h to a header file to include everything, but only for\nuse in broker modules instead.\n\nResolve the API compatibility issue described in the preivous commit.\nConvert naemon.h to include everything again, but never use it within\nthe naemon project itself. Define nothing (except defined for\ncompatibility purposes) in naemon.h\n\nSigned-off-by: Max Sikstrom <msikstrom@op5.com>","Max Sikstrom",true],["887cd136871ee397bc8d8881ccaf6a03fa69accc","354bdf36144dff18dcd4182fbe4ae582a62fa55e@op5.com","Add NAGIOS_DECL_{START|END} to allow c++ linkage\n\nSome missing and unmatched NAGIOS_DECL_{START|END} prevented c++\nlinkage, fix that\n\nSigned-off-by: Max Sikstrom <msikstrom@op5.com>","Max Sikstrom",true]],"size":4,"ref":"refs/heads/master","head":"887cd136871ee397bc8d8881ccaf6a03fa69accc"}