GitHub PullRequestEvent at 2014-01-27 20:07:52
Repository: jenkinsapi
Actor: rocktavious
Payload: {"action":"opened","number":239,"pull_request":{"url":"https://api.github.com/repos/salimfadhley/jenkinsapi/pulls/239","id":11917698,"html_url":"https://github.com/salimfadhley/jenkinsapi/pull/239","diff_url":"https://github.com/salimfadhley/jenkinsapi/pull/239.diff","patch_url":"https://github.com/salimfadhley/jenkinsapi/pull/239.patch","issue_url":"https://api.github.com/repos/salimfadhley/jenkinsapi/issues/239","number":239,"state":"open","title":"logging fix for invalid response","user":{"login":"rocktavious","id":735015,"avatar_url":"https://gravatar.com/avatar/1261faa61ac7c42bdb481b0d65e2ade0?d=https%3A%2F%2Fidenticons.github.com%2F0f872e8d809bd517ab14f13e5e2c329d.png&r=x","gravatar_id":"1261faa61ac7c42bdb481b0d65e2ade0","url":"https://api.github.com/users/rocktavious","html_url":"https://github.com/rocktavious","followers_url":"https://api.github.com/users/rocktavious/followers","following_url":"https://api.github.com/users/rocktavious/following{/other_user}","gists_url":"https://api.github.com/users/rocktavious/gists{/gist_id}","starred_url":"https://api.github.com/users/rocktavious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rocktavious/subscriptions","organizations_url":"https://api.github.com/users/rocktavious/orgs","repos_url":"https://api.github.com/users/rocktavious/repos","events_url":"https://api.github.com/users/rocktavious/events{/privacy}","received_events_url":"https://api.github.com/users/rocktavious/received_events","type":"User","site_admin":false},"body":"If you use an authenticated jenkins and you pass in an incorrect password the response.text it returns will not be valid to parse by ast, but the current logging logic covers up the actual HTTP error.  This will fix that by checdking if the response went through \"status_code\" of 200 and if not then raise and exception for the status so the end user can see why.\r\n\r\nAlso if you use the Jenkins class you will get and error:\r\nNo handlers could be found for logger \"jenkinsapi.jenkinsbase\"\r\n\r\nTo my knowledge logging inside of a package should be done by the logging.exception methods so the package user can specify their own handlers or configuration for logging.","created_at":"2014-01-27T20:07:51Z","updated_at":"2014-01-27T20:07:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/salimfadhley/jenkinsapi/pulls/239/commits","review_comments_url":"https://api.github.com/repos/salimfadhley/jenkinsapi/pulls/239/comments","review_comment_url":"/repos/salimfadhley/jenkinsapi/pulls/comments/{number}","comments_url":"https://api.github.com/repos/salimfadhley/jenkinsapi/issues/239/comments","statuses_url":"https://api.github.com/repos/salimfadhley/jenkinsapi/statuses/244f5988056a54050129b06a03f9961af794f767","head":{"label":"rocktavious:login_fix","ref":"login_fix","sha":"244f5988056a54050129b06a03f9961af794f767","user":{"login":"rocktavious","id":735015,"avatar_url":"https://gravatar.com/avatar/1261faa61ac7c42bdb481b0d65e2ade0?d=https%3A%2F%2Fidenticons.github.com%2F0f872e8d809bd517ab14f13e5e2c329d.png&r=x","gravatar_id":"1261faa61ac7c42bdb481b0d65e2ade0","url":"https://api.github.com/users/rocktavious","html_url":"https://github.com/rocktavious","followers_url":"https://api.github.com/users/rocktavious/followers","following_url":"https://api.github.com/users/rocktavious/following{/other_user}","gists_url":"https://api.github.com/users/rocktavious/gists{/gist_id}","starred_url":"https://api.github.com/users/rocktavious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rocktavious/subscriptions","organizations_url":"https://api.github.com/users/rocktavious/orgs","repos_url":"https://api.github.com/users/rocktavious/repos","events_url":"https://api.github.com/users/rocktavious/events{/privacy}","received_events_url":"https://api.github.com/users/rocktavious/received_events","type":"User","site_admin":false},"repo":{"id":16290800,"name":"jenkinsapi","full_name":"rocktavious/jenkinsapi","owner":{"login":"rocktavious","id":735015,"avatar_url":"https://gravatar.com/avatar/1261faa61ac7c42bdb481b0d65e2ade0?d=https%3A%2F%2Fidenticons.github.com%2F0f872e8d809bd517ab14f13e5e2c329d.png&r=x","gravatar_id":"1261faa61ac7c42bdb481b0d65e2ade0","url":"https://api.github.com/users/rocktavious","html_url":"https://github.com/rocktavious","followers_url":"https://api.github.com/users/rocktavious/followers","following_url":"https://api.github.com/users/rocktavious/following{/other_user}","gists_url":"https://api.github.com/users/rocktavious/gists{/gist_id}","starred_url":"https://api.github.com/users/rocktavious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rocktavious/subscriptions","organizations_url":"https://api.github.com/users/rocktavious/orgs","repos_url":"https://api.github.com/users/rocktavious/repos","events_url":"https://api.github.com/users/rocktavious/events{/privacy}","received_events_url":"https://api.github.com/users/rocktavious/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rocktavious/jenkinsapi","description":"A Python API for accessing resources and configuring Hudson & Jenkins continuous-integration servers","fork":true,"url":"https://api.github.com/repos/rocktavious/jenkinsapi","forks_url":"https://api.github.com/repos/rocktavious/jenkinsapi/forks","keys_url":"https://api.github.com/repos/rocktavious/jenkinsapi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rocktavious/jenkinsapi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rocktavious/jenkinsapi/teams","hooks_url":"https://api.github.com/repos/rocktavious/jenkinsapi/hooks","issue_events_url":"https://api.github.com/repos/rocktavious/jenkinsapi/issues/events{/number}","events_url":"https://api.github.com/repos/rocktavious/jenkinsapi/events","assignees_url":"https://api.github.com/repos/rocktavious/jenkinsapi/assignees{/user}","branches_url":"https://api.github.com/repos/rocktavious/jenkinsapi/branches{/branch}","tags_url":"https://api.github.com/repos/rocktavious/jenkinsapi/tags","blobs_url":"https://api.github.com/repos/rocktavious/jenkinsapi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rocktavious/jenkinsapi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rocktavious/jenkinsapi/git/refs{/sha}","trees_url":"https://api.github.com/repos/rocktavious/jenkinsapi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rocktavious/jenkinsapi/statuses/{sha}","languages_url":"https://api.github.com/repos/rocktavious/jenkinsapi/languages","stargazers_url":"https://api.github.com/repos/rocktavious/jenkinsapi/stargazers","contributors_url":"https://api.github.com/repos/rocktavious/jenkinsapi/contributors","subscribers_url":"https://api.github.com/repos/rocktavious/jenkinsapi/subscribers","subscription_url":"https://api.github.com/repos/rocktavious/jenkinsapi/subscription","commits_url":"https://api.github.com/repos/rocktavious/jenkinsapi/commits{/sha}","git_commits_url":"https://api.github.com/repos/rocktavious/jenkinsapi/git/commits{/sha}","comments_url":"https://api.github.com/repos/rocktavious/jenkinsapi/comments{/number}","issue_comment_url":"https://api.github.com/repos/rocktavious/jenkinsapi/issues/comments/{number}","contents_url":"https://api.github.com/repos/rocktavious/jenkinsapi/contents/{+path}","compare_url":"https://api.github.com/repos/rocktavious/jenkinsapi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rocktavious/jenkinsapi/merges","archive_url":"https://api.github.com/repos/rocktavious/jenkinsapi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rocktavious/jenkinsapi/downloads","issues_url":"https://api.github.com/repos/rocktavious/jenkinsapi/issues{/number}","pulls_url":"https://api.github.com/repos/rocktavious/jenkinsapi/pulls{/number}","milestones_url":"https://api.github.com/repos/rocktavious/jenkinsapi/milestones{/number}","notifications_url":"https://api.github.com/repos/rocktavious/jenkinsapi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rocktavious/jenkinsapi/labels{/name}","releases_url":"https://api.github.com/repos/rocktavious/jenkinsapi/releases{/id}","created_at":"2014-01-27T19:57:36Z","updated_at":"2014-01-27T20:07:51Z","pushed_at":"2014-01-27T20:01:11Z","git_url":"git://github.com/rocktavious/jenkinsapi.git","ssh_url":"git@github.com:rocktavious/jenkinsapi.git","clone_url":"https://github.com/rocktavious/jenkinsapi.git","svn_url":"https://github.com/rocktavious/jenkinsapi","homepage":"http://pypi.python.org/pypi/jenkinsapi","size":1765,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"salimfadhley:master","ref":"master","sha":"b86b788a0c4cae121685cb4fd24b7cfaab9ecc47","user":{"login":"salimfadhley","id":783193,"avatar_url":"https://gravatar.com/avatar/e8b13be168a08d37915ad28f2a96cdb2?d=https%3A%2F%2Fidenticons.github.com%2F68aed00f154f8d09f682a00079edd45a.png&r=x","gravatar_id":"e8b13be168a08d37915ad28f2a96cdb2","url":"https://api.github.com/users/salimfadhley","html_url":"https://github.com/salimfadhley","followers_url":"https://api.github.com/users/salimfadhley/followers","following_url":"https://api.github.com/users/salimfadhley/following{/other_user}","gists_url":"https://api.github.com/users/salimfadhley/gists{/gist_id}","starred_url":"https://api.github.com/users/salimfadhley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salimfadhley/subscriptions","organizations_url":"https://api.github.com/users/salimfadhley/orgs","repos_url":"https://api.github.com/users/salimfadhley/repos","events_url":"https://api.github.com/users/salimfadhley/events{/privacy}","received_events_url":"https://api.github.com/users/salimfadhley/received_events","type":"User","site_admin":false},"repo":{"id":3111557,"name":"jenkinsapi","full_name":"salimfadhley/jenkinsapi","owner":{"login":"salimfadhley","id":783193,"avatar_url":"https://gravatar.com/avatar/e8b13be168a08d37915ad28f2a96cdb2?d=https%3A%2F%2Fidenticons.github.com%2F68aed00f154f8d09f682a00079edd45a.png&r=x","gravatar_id":"e8b13be168a08d37915ad28f2a96cdb2","url":"https://api.github.com/users/salimfadhley","html_url":"https://github.com/salimfadhley","followers_url":"https://api.github.com/users/salimfadhley/followers","following_url":"https://api.github.com/users/salimfadhley/following{/other_user}","gists_url":"https://api.github.com/users/salimfadhley/gists{/gist_id}","starred_url":"https://api.github.com/users/salimfadhley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salimfadhley/subscriptions","organizations_url":"https://api.github.com/users/salimfadhley/orgs","repos_url":"https://api.github.com/users/salimfadhley/repos","events_url":"https://api.github.com/users/salimfadhley/events{/privacy}","received_events_url":"https://api.github.com/users/salimfadhley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/salimfadhley/jenkinsapi","description":"A Python API for accessing resources and configuring Hudson & Jenkins continuous-integration servers","fork":true,"url":"https://api.github.com/repos/salimfadhley/jenkinsapi","forks_url":"https://api.github.com/repos/salimfadhley/jenkinsapi/forks","keys_url":"https://api.github.com/repos/salimfadhley/jenkinsapi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/salimfadhley/jenkinsapi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/salimfadhley/jenkinsapi/teams","hooks_url":"https://api.github.com/repos/salimfadhley/jenkinsapi/hooks","issue_events_url":"https://api.github.com/repos/salimfadhley/jenkinsapi/issues/events{/number}","events_url":"https://api.github.com/repos/salimfadhley/jenkinsapi/events","assignees_url":"https://api.github.com/repos/salimfadhley/jenkinsapi/assignees{/user}","branches_url":"https://api.github.com/repos/salimfadhley/jenkinsapi/branches{/branch}","tags_url":"https://api.github.com/repos/salimfadhley/jenkinsapi/tags","blobs_url":"https://api.github.com/repos/salimfadhley/jenkinsapi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/salimfadhley/jenkinsapi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/salimfadhley/jenkinsapi/git/refs{/sha}","trees_url":"https://api.github.com/repos/salimfadhley/jenkinsapi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/salimfadhley/jenkinsapi/statuses/{sha}","languages_url":"https://api.github.com/repos/salimfadhley/jenkinsapi/languages","stargazers_url":"https://api.github.com/repos/salimfadhley/jenkinsapi/stargazers","contributors_url":"https://api.github.com/repos/salimfadhley/jenkinsapi/contributors","subscribers_url":"https://api.github.com/repos/salimfadhley/jenkinsapi/subscribers","subscription_url":"https://api.github.com/repos/salimfadhley/jenkinsapi/subscription","commits_url":"https://api.github.com/repos/salimfadhley/jenkinsapi/commits{/sha}","git_commits_url":"https://api.github.com/repos/salimfadhley/jenkinsapi/git/commits{/sha}","comments_url":"https://api.github.com/repos/salimfadhley/jenkinsapi/comments{/number}","issue_comment_url":"https://api.github.com/repos/salimfadhley/jenkinsapi/issues/comments/{number}","contents_url":"https://api.github.com/repos/salimfadhley/jenkinsapi/contents/{+path}","compare_url":"https://api.github.com/repos/salimfadhley/jenkinsapi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/salimfadhley/jenkinsapi/merges","archive_url":"https://api.github.com/repos/salimfadhley/jenkinsapi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/salimfadhley/jenkinsapi/downloads","issues_url":"https://api.github.com/repos/salimfadhley/jenkinsapi/issues{/number}","pulls_url":"https://api.github.com/repos/salimfadhley/jenkinsapi/pulls{/number}","milestones_url":"https://api.github.com/repos/salimfadhley/jenkinsapi/milestones{/number}","notifications_url":"https://api.github.com/repos/salimfadhley/jenkinsapi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/salimfadhley/jenkinsapi/labels{/name}","releases_url":"https://api.github.com/repos/salimfadhley/jenkinsapi/releases{/id}","created_at":"2012-01-05T16:43:13Z","updated_at":"2014-01-27T16:18:44Z","pushed_at":"2014-01-27T16:18:40Z","git_url":"git://github.com/salimfadhley/jenkinsapi.git","ssh_url":"git@github.com:salimfadhley/jenkinsapi.git","clone_url":"https://github.com/salimfadhley/jenkinsapi.git","svn_url":"https://github.com/salimfadhley/jenkinsapi","homepage":"http://pypi.python.org/pypi/jenkinsapi","size":1765,"stargazers_count":111,"watchers_count":111,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":95,"mirror_url":null,"open_issues_count":26,"forks":95,"open_issues":26,"watchers":111,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/salimfadhley/jenkinsapi/pulls/239"},"html":{"href":"https://github.com/salimfadhley/jenkinsapi/pull/239"},"issue":{"href":"https://api.github.com/repos/salimfadhley/jenkinsapi/issues/239"},"comments":{"href":"https://api.github.com/repos/salimfadhley/jenkinsapi/issues/239/comments"},"review_comments":{"href":"https://api.github.com/repos/salimfadhley/jenkinsapi/pulls/239/comments"},"commits":{"href":"https://api.github.com/repos/salimfadhley/jenkinsapi/pulls/239/commits"},"statuses":{"href":"https://api.github.com/repos/salimfadhley/jenkinsapi/statuses/244f5988056a54050129b06a03f9961af794f767"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":3,"deletions":2,"changed_files":1}}