GitHub PullRequestReviewCommentEvent at 2014-11-04 00:08:33
Repository: boto3
Actor: kyleknap
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/boto/boto3/pulls/comments/19777433","id":19777433,"diff_hunk":"@@ -11,11 +11,23 @@\n # ANY KIND, either express or implied. See the License for the specific\n # language governing permissions and limitations under the License.\n \n+from boto3.exceptions import NoVersionFound\n from boto3.session import Session\n from tests import mock, BaseTestCase\n \n \n class TestSession(BaseTestCase):\n+    def test_repr(self):\n+        bc_session = self.bc_session_cls.return_value\n+        bc_session.get_credentials.return_value.access_key = 'abc123'\n+        bc_session.get_config_variable.return_value = 'us-west-2'\n+\n+        session = Session('abc123', region='us-west-2')\n+\n+        self.assertIn('Session', repr(session))","path":"tests/unit/test_session.py","position":17,"original_position":17,"commit_id":"5b8e495917f8e0034529a098cbbb96f860871296","original_commit_id":"5b8e495917f8e0034529a098cbbb96f860871296","user":{"login":"kyleknap","id":4605355,"avatar_url":"https://avatars.githubusercontent.com/u/4605355?v=2","gravatar_id":"","url":"https://api.github.com/users/kyleknap","html_url":"https://github.com/kyleknap","followers_url":"https://api.github.com/users/kyleknap/followers","following_url":"https://api.github.com/users/kyleknap/following{/other_user}","gists_url":"https://api.github.com/users/kyleknap/gists{/gist_id}","starred_url":"https://api.github.com/users/kyleknap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyleknap/subscriptions","organizations_url":"https://api.github.com/users/kyleknap/orgs","repos_url":"https://api.github.com/users/kyleknap/repos","events_url":"https://api.github.com/users/kyleknap/events{/privacy}","received_events_url":"https://api.github.com/users/kyleknap/received_events","type":"User","site_admin":false},"body":"Can't you just ``assertEqual()`` the ``repr``?","created_at":"2014-11-04T00:08:33Z","updated_at":"2014-11-04T00:08:33Z","html_url":"https://github.com/boto/boto3/pull/10#discussion_r19777433","pull_request_url":"https://api.github.com/repos/boto/boto3/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/boto/boto3/pulls/comments/19777433"},"html":{"href":"https://github.com/boto/boto3/pull/10#discussion_r19777433"},"pull_request":{"href":"https://api.github.com/repos/boto/boto3/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/boto/boto3/pulls/10","id":23571953,"html_url":"https://github.com/boto/boto3/pull/10","diff_url":"https://github.com/boto/boto3/pull/10.diff","patch_url":"https://github.com/boto/boto3/pull/10.patch","issue_url":"https://api.github.com/repos/boto/boto3/issues/10","number":10,"state":"open","locked":false,"title":"Switch to Botocore data loader.","user":{"login":"danielgtaylor","id":106826,"avatar_url":"https://avatars.githubusercontent.com/u/106826?v=2","gravatar_id":"","url":"https://api.github.com/users/danielgtaylor","html_url":"https://github.com/danielgtaylor","followers_url":"https://api.github.com/users/danielgtaylor/followers","following_url":"https://api.github.com/users/danielgtaylor/following{/other_user}","gists_url":"https://api.github.com/users/danielgtaylor/gists{/gist_id}","starred_url":"https://api.github.com/users/danielgtaylor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielgtaylor/subscriptions","organizations_url":"https://api.github.com/users/danielgtaylor/orgs","repos_url":"https://api.github.com/users/danielgtaylor/repos","events_url":"https://api.github.com/users/danielgtaylor/events{/privacy}","received_events_url":"https://api.github.com/users/danielgtaylor/received_events","type":"User","site_admin":false},"body":"This pull request changes Boto 3 to use the Botocore data loader for loading\r\nresource JSON description files instead of the custom loading logic that was\r\nin place. As a result, a couple of things have changed:\r\n\r\n* Removed all JSON loading code from Boto 3\r\n* Removed `ResourceFactory.create_class` in favor of `load_from_definition`\r\n* Added Boto 3 resource data path to Botocore's loader\r\n* Added functionality to get the latest resource version\r\n* Implemented `Session.get_available_resources`\r\n* Updated and removed some tests\r\n* Updated docs\r\n\r\nUnfortunately, Botocore requires a very specific folder structure, and at the\r\nmoment Boto 3 is not using it. Because of this I wrote custom logic to find\r\nresource JSON files and find the latest version, some of which should be\r\nmigrated into Botocore in the near future.\r\n\r\ncc @jamesls, @kyleknap ","created_at":"2014-10-29T23:03:46Z","updated_at":"2014-11-04T00:08:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e1d7ad80f194df8b607fd357743867302dc9a685","assignee":{"login":"danielgtaylor","id":106826,"avatar_url":"https://avatars.githubusercontent.com/u/106826?v=2","gravatar_id":"","url":"https://api.github.com/users/danielgtaylor","html_url":"https://github.com/danielgtaylor","followers_url":"https://api.github.com/users/danielgtaylor/followers","following_url":"https://api.github.com/users/danielgtaylor/following{/other_user}","gists_url":"https://api.github.com/users/danielgtaylor/gists{/gist_id}","starred_url":"https://api.github.com/users/danielgtaylor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielgtaylor/subscriptions","organizations_url":"https://api.github.com/users/danielgtaylor/orgs","repos_url":"https://api.github.com/users/danielgtaylor/repos","events_url":"https://api.github.com/users/danielgtaylor/events{/privacy}","received_events_url":"https://api.github.com/users/danielgtaylor/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/boto/boto3/pulls/10/commits","review_comments_url":"https://api.github.com/repos/boto/boto3/pulls/10/comments","review_comment_url":"https://api.github.com/repos/boto/boto3/pulls/comments/{number}","comments_url":"https://api.github.com/repos/boto/boto3/issues/10/comments","statuses_url":"https://api.github.com/repos/boto/boto3/statuses/5b8e495917f8e0034529a098cbbb96f860871296","head":{"label":"boto:loader","ref":"loader","sha":"5b8e495917f8e0034529a098cbbb96f860871296","user":{"login":"boto","id":327752,"avatar_url":"https://avatars.githubusercontent.com/u/327752?v=2","gravatar_id":"","url":"https://api.github.com/users/boto","html_url":"https://github.com/boto","followers_url":"https://api.github.com/users/boto/followers","following_url":"https://api.github.com/users/boto/following{/other_user}","gists_url":"https://api.github.com/users/boto/gists{/gist_id}","starred_url":"https://api.github.com/users/boto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boto/subscriptions","organizations_url":"https://api.github.com/users/boto/orgs","repos_url":"https://api.github.com/users/boto/repos","events_url":"https://api.github.com/users/boto/events{/privacy}","received_events_url":"https://api.github.com/users/boto/received_events","type":"Organization","site_admin":false},"repo":{"id":24774658,"name":"boto3","full_name":"boto/boto3","owner":{"login":"boto","id":327752,"avatar_url":"https://avatars.githubusercontent.com/u/327752?v=2","gravatar_id":"","url":"https://api.github.com/users/boto","html_url":"https://github.com/boto","followers_url":"https://api.github.com/users/boto/followers","following_url":"https://api.github.com/users/boto/following{/other_user}","gists_url":"https://api.github.com/users/boto/gists{/gist_id}","starred_url":"https://api.github.com/users/boto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boto/subscriptions","organizations_url":"https://api.github.com/users/boto/orgs","repos_url":"https://api.github.com/users/boto/repos","events_url":"https://api.github.com/users/boto/events{/privacy}","received_events_url":"https://api.github.com/users/boto/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/boto/boto3","description":"**Experimental** AWS SDK for Python","fork":false,"url":"https://api.github.com/repos/boto/boto3","forks_url":"https://api.github.com/repos/boto/boto3/forks","keys_url":"https://api.github.com/repos/boto/boto3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/boto/boto3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/boto/boto3/teams","hooks_url":"https://api.github.com/repos/boto/boto3/hooks","issue_events_url":"https://api.github.com/repos/boto/boto3/issues/events{/number}","events_url":"https://api.github.com/repos/boto/boto3/events","assignees_url":"https://api.github.com/repos/boto/boto3/assignees{/user}","branches_url":"https://api.github.com/repos/boto/boto3/branches{/branch}","tags_url":"https://api.github.com/repos/boto/boto3/tags","blobs_url":"https://api.github.com/repos/boto/boto3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/boto/boto3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/boto/boto3/git/refs{/sha}","trees_url":"https://api.github.com/repos/boto/boto3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/boto/boto3/statuses/{sha}","languages_url":"https://api.github.com/repos/boto/boto3/languages","stargazers_url":"https://api.github.com/repos/boto/boto3/stargazers","contributors_url":"https://api.github.com/repos/boto/boto3/contributors","subscribers_url":"https://api.github.com/repos/boto/boto3/subscribers","subscription_url":"https://api.github.com/repos/boto/boto3/subscription","commits_url":"https://api.github.com/repos/boto/boto3/commits{/sha}","git_commits_url":"https://api.github.com/repos/boto/boto3/git/commits{/sha}","comments_url":"https://api.github.com/repos/boto/boto3/comments{/number}","issue_comment_url":"https://api.github.com/repos/boto/boto3/issues/comments/{number}","contents_url":"https://api.github.com/repos/boto/boto3/contents/{+path}","compare_url":"https://api.github.com/repos/boto/boto3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/boto/boto3/merges","archive_url":"https://api.github.com/repos/boto/boto3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/boto/boto3/downloads","issues_url":"https://api.github.com/repos/boto/boto3/issues{/number}","pulls_url":"https://api.github.com/repos/boto/boto3/pulls{/number}","milestones_url":"https://api.github.com/repos/boto/boto3/milestones{/number}","notifications_url":"https://api.github.com/repos/boto/boto3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/boto/boto3/labels{/name}","releases_url":"https://api.github.com/repos/boto/boto3/releases{/id}","created_at":"2014-10-03T21:38:03Z","updated_at":"2014-11-02T07:11:59Z","pushed_at":"2014-10-31T23:20:22Z","git_url":"git://github.com/boto/boto3.git","ssh_url":"git@github.com:boto/boto3.git","clone_url":"https://github.com/boto/boto3.git","svn_url":"https://github.com/boto/boto3","homepage":null,"size":580,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":4,"forks":3,"open_issues":4,"watchers":6,"default_branch":"develop"}},"base":{"label":"boto:develop","ref":"develop","sha":"f0c07a858001ff38a1992d62bad589667ee49cd3","user":{"login":"boto","id":327752,"avatar_url":"https://avatars.githubusercontent.com/u/327752?v=2","gravatar_id":"","url":"https://api.github.com/users/boto","html_url":"https://github.com/boto","followers_url":"https://api.github.com/users/boto/followers","following_url":"https://api.github.com/users/boto/following{/other_user}","gists_url":"https://api.github.com/users/boto/gists{/gist_id}","starred_url":"https://api.github.com/users/boto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boto/subscriptions","organizations_url":"https://api.github.com/users/boto/orgs","repos_url":"https://api.github.com/users/boto/repos","events_url":"https://api.github.com/users/boto/events{/privacy}","received_events_url":"https://api.github.com/users/boto/received_events","type":"Organization","site_admin":false},"repo":{"id":24774658,"name":"boto3","full_name":"boto/boto3","owner":{"login":"boto","id":327752,"avatar_url":"https://avatars.githubusercontent.com/u/327752?v=2","gravatar_id":"","url":"https://api.github.com/users/boto","html_url":"https://github.com/boto","followers_url":"https://api.github.com/users/boto/followers","following_url":"https://api.github.com/users/boto/following{/other_user}","gists_url":"https://api.github.com/users/boto/gists{/gist_id}","starred_url":"https://api.github.com/users/boto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boto/subscriptions","organizations_url":"https://api.github.com/users/boto/orgs","repos_url":"https://api.github.com/users/boto/repos","events_url":"https://api.github.com/users/boto/events{/privacy}","received_events_url":"https://api.github.com/users/boto/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/boto/boto3","description":"**Experimental** AWS SDK for Python","fork":false,"url":"https://api.github.com/repos/boto/boto3","forks_url":"https://api.github.com/repos/boto/boto3/forks","keys_url":"https://api.github.com/repos/boto/boto3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/boto/boto3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/boto/boto3/teams","hooks_url":"https://api.github.com/repos/boto/boto3/hooks","issue_events_url":"https://api.github.com/repos/boto/boto3/issues/events{/number}","events_url":"https://api.github.com/repos/boto/boto3/events","assignees_url":"https://api.github.com/repos/boto/boto3/assignees{/user}","branches_url":"https://api.github.com/repos/boto/boto3/branches{/branch}","tags_url":"https://api.github.com/repos/boto/boto3/tags","blobs_url":"https://api.github.com/repos/boto/boto3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/boto/boto3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/boto/boto3/git/refs{/sha}","trees_url":"https://api.github.com/repos/boto/boto3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/boto/boto3/statuses/{sha}","languages_url":"https://api.github.com/repos/boto/boto3/languages","stargazers_url":"https://api.github.com/repos/boto/boto3/stargazers","contributors_url":"https://api.github.com/repos/boto/boto3/contributors","subscribers_url":"https://api.github.com/repos/boto/boto3/subscribers","subscription_url":"https://api.github.com/repos/boto/boto3/subscription","commits_url":"https://api.github.com/repos/boto/boto3/commits{/sha}","git_commits_url":"https://api.github.com/repos/boto/boto3/git/commits{/sha}","comments_url":"https://api.github.com/repos/boto/boto3/comments{/number}","issue_comment_url":"https://api.github.com/repos/boto/boto3/issues/comments/{number}","contents_url":"https://api.github.com/repos/boto/boto3/contents/{+path}","compare_url":"https://api.github.com/repos/boto/boto3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/boto/boto3/merges","archive_url":"https://api.github.com/repos/boto/boto3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/boto/boto3/downloads","issues_url":"https://api.github.com/repos/boto/boto3/issues{/number}","pulls_url":"https://api.github.com/repos/boto/boto3/pulls{/number}","milestones_url":"https://api.github.com/repos/boto/boto3/milestones{/number}","notifications_url":"https://api.github.com/repos/boto/boto3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/boto/boto3/labels{/name}","releases_url":"https://api.github.com/repos/boto/boto3/releases{/id}","created_at":"2014-10-03T21:38:03Z","updated_at":"2014-11-02T07:11:59Z","pushed_at":"2014-10-31T23:20:22Z","git_url":"git://github.com/boto/boto3.git","ssh_url":"git@github.com:boto/boto3.git","clone_url":"https://github.com/boto/boto3.git","svn_url":"https://github.com/boto/boto3","homepage":null,"size":580,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":4,"forks":3,"open_issues":4,"watchers":6,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/boto/boto3/pulls/10"},"html":{"href":"https://github.com/boto/boto3/pull/10"},"issue":{"href":"https://api.github.com/repos/boto/boto3/issues/10"},"comments":{"href":"https://api.github.com/repos/boto/boto3/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/boto/boto3/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/boto/boto3/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/boto/boto3/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/boto/boto3/statuses/5b8e495917f8e0034529a098cbbb96f860871296"}}}}