GitHub PullRequestReviewCommentEvent at 2014-09-01 10:28:55
Repository: fairnopoly
Actor: houndci
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/fairnopoly/fairnopoly/pulls/comments/16948827","id":16948827,"diff_hunk":"@@ -43,18 +43,39 @@\n       end\n \n       it \"should be successful\" do\n-        get :index, :user_id => @library.user\n+        get :index, user_id: @library.user\n         assert_response :success\n       end\n \n       it \"should be successful\" do\n-        get :show, :user_id => @library.user, :id => @library.id\n+        get :show, user_id: @library.user, id: @library.id\n+        assert_response :success\n+      end\n+    end\n+\n+    describe \"with parameter 'mode=myfavorite'\" do\n+      it 'should redirect to /libraries if user is not logged in' do\n+        get :index, mode: 'myfavorite'\n+        assert_redirected_to libraries_path\n+      end\n+\n+      it 'should be successful if user is logged in' do\n+        user = FactoryGirl.create(:user)\n+        @controller.stubs(:current_user).returns(user)\n+        get :index, mode: 'myfavorite'\n+        assert_response :success\n+      end\n+    end\n+\n+    describe \"with parameter 'mode=new'\" do\n+      it 'should be successful' do","path":"test/controllers/libraries_controller_test.rb","position":40,"original_position":40,"commit_id":"3b855d624ad8ce4895e23e4127f4eecfbbbfbc93","original_commit_id":"3b855d624ad8ce4895e23e4127f4eecfbbbfbc93","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=2","gravatar_id":"38d9cefd9971a05bf447f07c6cd332cc","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.","created_at":"2014-09-01T10:28:55Z","updated_at":"2014-09-01T10:28:55Z","html_url":"https://github.com/fairnopoly/fairnopoly/pull/1005#discussion_r16948827","pull_request_url":"https://api.github.com/repos/fairnopoly/fairnopoly/pulls/1005","_links":{"self":{"href":"https://api.github.com/repos/fairnopoly/fairnopoly/pulls/comments/16948827"},"html":{"href":"https://github.com/fairnopoly/fairnopoly/pull/1005#discussion_r16948827"},"pull_request":{"href":"https://api.github.com/repos/fairnopoly/fairnopoly/pulls/1005"}}},"pull_request":{"url":"https://api.github.com/repos/fairnopoly/fairnopoly/pulls/1005","id":20564858,"html_url":"https://github.com/fairnopoly/fairnopoly/pull/1005","diff_url":"https://github.com/fairnopoly/fairnopoly/pull/1005.diff","patch_url":"https://github.com/fairnopoly/fairnopoly/pull/1005.patch","issue_url":"https://api.github.com/repos/fairnopoly/fairnopoly/issues/1005","number":1005,"state":"open","locked":false,"title":"Feature libraries","user":{"login":"marcaltmann","id":2727647,"avatar_url":"https://avatars.githubusercontent.com/u/2727647?v=2","gravatar_id":"252c0d98f269eb3d7f1aa24fa4e62630","url":"https://api.github.com/users/marcaltmann","html_url":"https://github.com/marcaltmann","followers_url":"https://api.github.com/users/marcaltmann/followers","following_url":"https://api.github.com/users/marcaltmann/following{/other_user}","gists_url":"https://api.github.com/users/marcaltmann/gists{/gist_id}","starred_url":"https://api.github.com/users/marcaltmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcaltmann/subscriptions","organizations_url":"https://api.github.com/users/marcaltmann/orgs","repos_url":"https://api.github.com/users/marcaltmann/repos","events_url":"https://api.github.com/users/marcaltmann/events{/privacy}","received_events_url":"https://api.github.com/users/marcaltmann/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-09-01T10:28:46Z","updated_at":"2014-09-01T10:28:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/fairnopoly/fairnopoly/pulls/1005/commits","review_comments_url":"https://api.github.com/repos/fairnopoly/fairnopoly/pulls/1005/comments","review_comment_url":"https://api.github.com/repos/fairnopoly/fairnopoly/pulls/comments/{number}","comments_url":"https://api.github.com/repos/fairnopoly/fairnopoly/issues/1005/comments","statuses_url":"https://api.github.com/repos/fairnopoly/fairnopoly/statuses/3b855d624ad8ce4895e23e4127f4eecfbbbfbc93","head":{"label":"fairnopoly:feature-libraries","ref":"feature-libraries","sha":"3b855d624ad8ce4895e23e4127f4eecfbbbfbc93","user":{"login":"fairnopoly","id":2982509,"avatar_url":"https://avatars.githubusercontent.com/u/2982509?v=2","gravatar_id":"ab59dff8f276f6fb719438351426f5cd","url":"https://api.github.com/users/fairnopoly","html_url":"https://github.com/fairnopoly","followers_url":"https://api.github.com/users/fairnopoly/followers","following_url":"https://api.github.com/users/fairnopoly/following{/other_user}","gists_url":"https://api.github.com/users/fairnopoly/gists{/gist_id}","starred_url":"https://api.github.com/users/fairnopoly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fairnopoly/subscriptions","organizations_url":"https://api.github.com/users/fairnopoly/orgs","repos_url":"https://api.github.com/users/fairnopoly/repos","events_url":"https://api.github.com/users/fairnopoly/events{/privacy}","received_events_url":"https://api.github.com/users/fairnopoly/received_events","type":"Organization","site_admin":false},"repo":{"id":7040101,"name":"fairnopoly","full_name":"fairnopoly/fairnopoly","owner":{"login":"fairnopoly","id":2982509,"avatar_url":"https://avatars.githubusercontent.com/u/2982509?v=2","gravatar_id":"ab59dff8f276f6fb719438351426f5cd","url":"https://api.github.com/users/fairnopoly","html_url":"https://github.com/fairnopoly","followers_url":"https://api.github.com/users/fairnopoly/followers","following_url":"https://api.github.com/users/fairnopoly/following{/other_user}","gists_url":"https://api.github.com/users/fairnopoly/gists{/gist_id}","starred_url":"https://api.github.com/users/fairnopoly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fairnopoly/subscriptions","organizations_url":"https://api.github.com/users/fairnopoly/orgs","repos_url":"https://api.github.com/users/fairnopoly/repos","events_url":"https://api.github.com/users/fairnopoly/events{/privacy}","received_events_url":"https://api.github.com/users/fairnopoly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fairnopoly/fairnopoly","description":"","fork":false,"url":"https://api.github.com/repos/fairnopoly/fairnopoly","forks_url":"https://api.github.com/repos/fairnopoly/fairnopoly/forks","keys_url":"https://api.github.com/repos/fairnopoly/fairnopoly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fairnopoly/fairnopoly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fairnopoly/fairnopoly/teams","hooks_url":"https://api.github.com/repos/fairnopoly/fairnopoly/hooks","issue_events_url":"https://api.github.com/repos/fairnopoly/fairnopoly/issues/events{/number}","events_url":"https://api.github.com/repos/fairnopoly/fairnopoly/events","assignees_url":"https://api.github.com/repos/fairnopoly/fairnopoly/assignees{/user}","branches_url":"https://api.github.com/repos/fairnopoly/fairnopoly/branches{/branch}","tags_url":"https://api.github.com/repos/fairnopoly/fairnopoly/tags","blobs_url":"https://api.github.com/repos/fairnopoly/fairnopoly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fairnopoly/fairnopoly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fairnopoly/fairnopoly/git/refs{/sha}","trees_url":"https://api.github.com/repos/fairnopoly/fairnopoly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fairnopoly/fairnopoly/statuses/{sha}","languages_url":"https://api.github.com/repos/fairnopoly/fairnopoly/languages","stargazers_url":"https://api.github.com/repos/fairnopoly/fairnopoly/stargazers","contributors_url":"https://api.github.com/repos/fairnopoly/fairnopoly/contributors","subscribers_url":"https://api.github.com/repos/fairnopoly/fairnopoly/subscribers","subscription_url":"https://api.github.com/repos/fairnopoly/fairnopoly/subscription","commits_url":"https://api.github.com/repos/fairnopoly/fairnopoly/commits{/sha}","git_commits_url":"https://api.github.com/repos/fairnopoly/fairnopoly/git/commits{/sha}","comments_url":"https://api.github.com/repos/fairnopoly/fairnopoly/comments{/number}","issue_comment_url":"https://api.github.com/repos/fairnopoly/fairnopoly/issues/comments/{number}","contents_url":"https://api.github.com/repos/fairnopoly/fairnopoly/contents/{+path}","compare_url":"https://api.github.com/repos/fairnopoly/fairnopoly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fairnopoly/fairnopoly/merges","archive_url":"https://api.github.com/repos/fairnopoly/fairnopoly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fairnopoly/fairnopoly/downloads","issues_url":"https://api.github.com/repos/fairnopoly/fairnopoly/issues{/number}","pulls_url":"https://api.github.com/repos/fairnopoly/fairnopoly/pulls{/number}","milestones_url":"https://api.github.com/repos/fairnopoly/fairnopoly/milestones{/number}","notifications_url":"https://api.github.com/repos/fairnopoly/fairnopoly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fairnopoly/fairnopoly/labels{/name}","releases_url":"https://api.github.com/repos/fairnopoly/fairnopoly/releases{/id}","created_at":"2012-12-06T17:48:15Z","updated_at":"2014-08-26T09:35:24Z","pushed_at":"2014-09-01T10:17:38Z","git_url":"git://github.com/fairnopoly/fairnopoly.git","ssh_url":"git@github.com:fairnopoly/fairnopoly.git","clone_url":"https://github.com/fairnopoly/fairnopoly.git","svn_url":"https://github.com/fairnopoly/fairnopoly","homepage":null,"size":60893,"stargazers_count":41,"watchers_count":41,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":19,"mirror_url":null,"open_issues_count":79,"forks":19,"open_issues":79,"watchers":41,"default_branch":"develop"}},"base":{"label":"fairnopoly:develop","ref":"develop","sha":"67ef49590a3e68b9fc79fa82dd5932d611444f8e","user":{"login":"fairnopoly","id":2982509,"avatar_url":"https://avatars.githubusercontent.com/u/2982509?v=2","gravatar_id":"ab59dff8f276f6fb719438351426f5cd","url":"https://api.github.com/users/fairnopoly","html_url":"https://github.com/fairnopoly","followers_url":"https://api.github.com/users/fairnopoly/followers","following_url":"https://api.github.com/users/fairnopoly/following{/other_user}","gists_url":"https://api.github.com/users/fairnopoly/gists{/gist_id}","starred_url":"https://api.github.com/users/fairnopoly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fairnopoly/subscriptions","organizations_url":"https://api.github.com/users/fairnopoly/orgs","repos_url":"https://api.github.com/users/fairnopoly/repos","events_url":"https://api.github.com/users/fairnopoly/events{/privacy}","received_events_url":"https://api.github.com/users/fairnopoly/received_events","type":"Organization","site_admin":false},"repo":{"id":7040101,"name":"fairnopoly","full_name":"fairnopoly/fairnopoly","owner":{"login":"fairnopoly","id":2982509,"avatar_url":"https://avatars.githubusercontent.com/u/2982509?v=2","gravatar_id":"ab59dff8f276f6fb719438351426f5cd","url":"https://api.github.com/users/fairnopoly","html_url":"https://github.com/fairnopoly","followers_url":"https://api.github.com/users/fairnopoly/followers","following_url":"https://api.github.com/users/fairnopoly/following{/other_user}","gists_url":"https://api.github.com/users/fairnopoly/gists{/gist_id}","starred_url":"https://api.github.com/users/fairnopoly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fairnopoly/subscriptions","organizations_url":"https://api.github.com/users/fairnopoly/orgs","repos_url":"https://api.github.com/users/fairnopoly/repos","events_url":"https://api.github.com/users/fairnopoly/events{/privacy}","received_events_url":"https://api.github.com/users/fairnopoly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fairnopoly/fairnopoly","description":"","fork":false,"url":"https://api.github.com/repos/fairnopoly/fairnopoly","forks_url":"https://api.github.com/repos/fairnopoly/fairnopoly/forks","keys_url":"https://api.github.com/repos/fairnopoly/fairnopoly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fairnopoly/fairnopoly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fairnopoly/fairnopoly/teams","hooks_url":"https://api.github.com/repos/fairnopoly/fairnopoly/hooks","issue_events_url":"https://api.github.com/repos/fairnopoly/fairnopoly/issues/events{/number}","events_url":"https://api.github.com/repos/fairnopoly/fairnopoly/events","assignees_url":"https://api.github.com/repos/fairnopoly/fairnopoly/assignees{/user}","branches_url":"https://api.github.com/repos/fairnopoly/fairnopoly/branches{/branch}","tags_url":"https://api.github.com/repos/fairnopoly/fairnopoly/tags","blobs_url":"https://api.github.com/repos/fairnopoly/fairnopoly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fairnopoly/fairnopoly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fairnopoly/fairnopoly/git/refs{/sha}","trees_url":"https://api.github.com/repos/fairnopoly/fairnopoly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fairnopoly/fairnopoly/statuses/{sha}","languages_url":"https://api.github.com/repos/fairnopoly/fairnopoly/languages","stargazers_url":"https://api.github.com/repos/fairnopoly/fairnopoly/stargazers","contributors_url":"https://api.github.com/repos/fairnopoly/fairnopoly/contributors","subscribers_url":"https://api.github.com/repos/fairnopoly/fairnopoly/subscribers","subscription_url":"https://api.github.com/repos/fairnopoly/fairnopoly/subscription","commits_url":"https://api.github.com/repos/fairnopoly/fairnopoly/commits{/sha}","git_commits_url":"https://api.github.com/repos/fairnopoly/fairnopoly/git/commits{/sha}","comments_url":"https://api.github.com/repos/fairnopoly/fairnopoly/comments{/number}","issue_comment_url":"https://api.github.com/repos/fairnopoly/fairnopoly/issues/comments/{number}","contents_url":"https://api.github.com/repos/fairnopoly/fairnopoly/contents/{+path}","compare_url":"https://api.github.com/repos/fairnopoly/fairnopoly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fairnopoly/fairnopoly/merges","archive_url":"https://api.github.com/repos/fairnopoly/fairnopoly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fairnopoly/fairnopoly/downloads","issues_url":"https://api.github.com/repos/fairnopoly/fairnopoly/issues{/number}","pulls_url":"https://api.github.com/repos/fairnopoly/fairnopoly/pulls{/number}","milestones_url":"https://api.github.com/repos/fairnopoly/fairnopoly/milestones{/number}","notifications_url":"https://api.github.com/repos/fairnopoly/fairnopoly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fairnopoly/fairnopoly/labels{/name}","releases_url":"https://api.github.com/repos/fairnopoly/fairnopoly/releases{/id}","created_at":"2012-12-06T17:48:15Z","updated_at":"2014-08-26T09:35:24Z","pushed_at":"2014-09-01T10:17:38Z","git_url":"git://github.com/fairnopoly/fairnopoly.git","ssh_url":"git@github.com:fairnopoly/fairnopoly.git","clone_url":"https://github.com/fairnopoly/fairnopoly.git","svn_url":"https://github.com/fairnopoly/fairnopoly","homepage":null,"size":60893,"stargazers_count":41,"watchers_count":41,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":19,"mirror_url":null,"open_issues_count":79,"forks":19,"open_issues":79,"watchers":41,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/fairnopoly/fairnopoly/pulls/1005"},"html":{"href":"https://github.com/fairnopoly/fairnopoly/pull/1005"},"issue":{"href":"https://api.github.com/repos/fairnopoly/fairnopoly/issues/1005"},"comments":{"href":"https://api.github.com/repos/fairnopoly/fairnopoly/issues/1005/comments"},"review_comments":{"href":"https://api.github.com/repos/fairnopoly/fairnopoly/pulls/1005/comments"},"review_comment":{"href":"https://api.github.com/repos/fairnopoly/fairnopoly/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/fairnopoly/fairnopoly/pulls/1005/commits"},"statuses":{"href":"https://api.github.com/repos/fairnopoly/fairnopoly/statuses/3b855d624ad8ce4895e23e4127f4eecfbbbfbc93"}}}}