GitHub PullRequestReviewCommentEvent at 2014-10-07 14:38:57
Repository: oscommerce2
Actor: haraldpdl
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/osCommerce/oscommerce2/pulls/comments/18523150","id":18523150,"diff_hunk":"@@ -281,7 +281,7 @@\n     switch ( $_GET['action'] ) {\n       // customer wants to update the product quantity in their shopping cart\n       case 'update_product' : for ($i=0, $n=sizeof($_POST['products_id']); $i<$n; $i++) {\n-                                if (in_array($_POST['products_id'][$i], (is_array($_POST['cart_delete']) ? $_POST['cart_delete'] : array()))) {\n+                                if (in_array($_POST['products_id'][$i], (is_array(isset($_POST['cart_delete']) ? $_POST['cart_delete'] : '') ? $_POST['cart_delete'] : array()))) {","path":"catalog/includes/application_top.php","position":5,"original_position":5,"commit_id":"db13758fffadfedefeef75a47440265a566ab93f","original_commit_id":"db13758fffadfedefeef75a47440265a566ab93f","user":{"login":"haraldpdl","id":57828,"avatar_url":"https://avatars.githubusercontent.com/u/57828?v=2","gravatar_id":"","url":"https://api.github.com/users/haraldpdl","html_url":"https://github.com/haraldpdl","followers_url":"https://api.github.com/users/haraldpdl/followers","following_url":"https://api.github.com/users/haraldpdl/following{/other_user}","gists_url":"https://api.github.com/users/haraldpdl/gists{/gist_id}","starred_url":"https://api.github.com/users/haraldpdl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haraldpdl/subscriptions","organizations_url":"https://api.github.com/users/haraldpdl/orgs","repos_url":"https://api.github.com/users/haraldpdl/repos","events_url":"https://api.github.com/users/haraldpdl/events{/privacy}","received_events_url":"https://api.github.com/users/haraldpdl/received_events","type":"User","site_admin":false},"body":"Lets not get too complex in is_array() :smiley: Other variables should also be checked for existence - it would be better to rewrite the block entirely. Care to work on this further?","created_at":"2014-10-07T14:38:57Z","updated_at":"2014-10-07T14:38:57Z","html_url":"https://github.com/osCommerce/oscommerce2/pull/239#discussion_r18523150","pull_request_url":"https://api.github.com/repos/osCommerce/oscommerce2/pulls/239","_links":{"self":{"href":"https://api.github.com/repos/osCommerce/oscommerce2/pulls/comments/18523150"},"html":{"href":"https://github.com/osCommerce/oscommerce2/pull/239#discussion_r18523150"},"pull_request":{"href":"https://api.github.com/repos/osCommerce/oscommerce2/pulls/239"}}},"pull_request":{"url":"https://api.github.com/repos/osCommerce/oscommerce2/pulls/239","id":22244299,"html_url":"https://github.com/osCommerce/oscommerce2/pull/239","diff_url":"https://github.com/osCommerce/oscommerce2/pull/239.diff","patch_url":"https://github.com/osCommerce/oscommerce2/pull/239.patch","issue_url":"https://api.github.com/repos/osCommerce/oscommerce2/issues/239","number":239,"state":"open","locked":false,"title":"Resolve issue #501","user":{"login":"acidvertigo","id":809397,"avatar_url":"https://avatars.githubusercontent.com/u/809397?v=2","gravatar_id":"","url":"https://api.github.com/users/acidvertigo","html_url":"https://github.com/acidvertigo","followers_url":"https://api.github.com/users/acidvertigo/followers","following_url":"https://api.github.com/users/acidvertigo/following{/other_user}","gists_url":"https://api.github.com/users/acidvertigo/gists{/gist_id}","starred_url":"https://api.github.com/users/acidvertigo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acidvertigo/subscriptions","organizations_url":"https://api.github.com/users/acidvertigo/orgs","repos_url":"https://api.github.com/users/acidvertigo/repos","events_url":"https://api.github.com/users/acidvertigo/events{/privacy}","received_events_url":"https://api.github.com/users/acidvertigo/received_events","type":"User","site_admin":false},"body":"http://forums.oscommerce.com/tracker/issue-501-undefined-index-cart-delete/","created_at":"2014-10-04T15:02:53Z","updated_at":"2014-10-07T14:38:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"430fe8270bec1713fa937cb61abcf7bb489da401","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/osCommerce/oscommerce2/pulls/239/commits","review_comments_url":"https://api.github.com/repos/osCommerce/oscommerce2/pulls/239/comments","review_comment_url":"https://api.github.com/repos/osCommerce/oscommerce2/pulls/comments/{number}","comments_url":"https://api.github.com/repos/osCommerce/oscommerce2/issues/239/comments","statuses_url":"https://api.github.com/repos/osCommerce/oscommerce2/statuses/db13758fffadfedefeef75a47440265a566ab93f","head":{"label":"acidvertigo:patch-25","ref":"patch-25","sha":"db13758fffadfedefeef75a47440265a566ab93f","user":{"login":"acidvertigo","id":809397,"avatar_url":"https://avatars.githubusercontent.com/u/809397?v=2","gravatar_id":"","url":"https://api.github.com/users/acidvertigo","html_url":"https://github.com/acidvertigo","followers_url":"https://api.github.com/users/acidvertigo/followers","following_url":"https://api.github.com/users/acidvertigo/following{/other_user}","gists_url":"https://api.github.com/users/acidvertigo/gists{/gist_id}","starred_url":"https://api.github.com/users/acidvertigo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acidvertigo/subscriptions","organizations_url":"https://api.github.com/users/acidvertigo/orgs","repos_url":"https://api.github.com/users/acidvertigo/repos","events_url":"https://api.github.com/users/acidvertigo/events{/privacy}","received_events_url":"https://api.github.com/users/acidvertigo/received_events","type":"User","site_admin":false},"repo":{"id":8113517,"name":"oscommerce2","full_name":"acidvertigo/oscommerce2","owner":{"login":"acidvertigo","id":809397,"avatar_url":"https://avatars.githubusercontent.com/u/809397?v=2","gravatar_id":"","url":"https://api.github.com/users/acidvertigo","html_url":"https://github.com/acidvertigo","followers_url":"https://api.github.com/users/acidvertigo/followers","following_url":"https://api.github.com/users/acidvertigo/following{/other_user}","gists_url":"https://api.github.com/users/acidvertigo/gists{/gist_id}","starred_url":"https://api.github.com/users/acidvertigo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acidvertigo/subscriptions","organizations_url":"https://api.github.com/users/acidvertigo/orgs","repos_url":"https://api.github.com/users/acidvertigo/repos","events_url":"https://api.github.com/users/acidvertigo/events{/privacy}","received_events_url":"https://api.github.com/users/acidvertigo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/acidvertigo/oscommerce2","description":"osCommerce Online Merchant v2.x","fork":true,"url":"https://api.github.com/repos/acidvertigo/oscommerce2","forks_url":"https://api.github.com/repos/acidvertigo/oscommerce2/forks","keys_url":"https://api.github.com/repos/acidvertigo/oscommerce2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/acidvertigo/oscommerce2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/acidvertigo/oscommerce2/teams","hooks_url":"https://api.github.com/repos/acidvertigo/oscommerce2/hooks","issue_events_url":"https://api.github.com/repos/acidvertigo/oscommerce2/issues/events{/number}","events_url":"https://api.github.com/repos/acidvertigo/oscommerce2/events","assignees_url":"https://api.github.com/repos/acidvertigo/oscommerce2/assignees{/user}","branches_url":"https://api.github.com/repos/acidvertigo/oscommerce2/branches{/branch}","tags_url":"https://api.github.com/repos/acidvertigo/oscommerce2/tags","blobs_url":"https://api.github.com/repos/acidvertigo/oscommerce2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/acidvertigo/oscommerce2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/acidvertigo/oscommerce2/git/refs{/sha}","trees_url":"https://api.github.com/repos/acidvertigo/oscommerce2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/acidvertigo/oscommerce2/statuses/{sha}","languages_url":"https://api.github.com/repos/acidvertigo/oscommerce2/languages","stargazers_url":"https://api.github.com/repos/acidvertigo/oscommerce2/stargazers","contributors_url":"https://api.github.com/repos/acidvertigo/oscommerce2/contributors","subscribers_url":"https://api.github.com/repos/acidvertigo/oscommerce2/subscribers","subscription_url":"https://api.github.com/repos/acidvertigo/oscommerce2/subscription","commits_url":"https://api.github.com/repos/acidvertigo/oscommerce2/commits{/sha}","git_commits_url":"https://api.github.com/repos/acidvertigo/oscommerce2/git/commits{/sha}","comments_url":"https://api.github.com/repos/acidvertigo/oscommerce2/comments{/number}","issue_comment_url":"https://api.github.com/repos/acidvertigo/oscommerce2/issues/comments/{number}","contents_url":"https://api.github.com/repos/acidvertigo/oscommerce2/contents/{+path}","compare_url":"https://api.github.com/repos/acidvertigo/oscommerce2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/acidvertigo/oscommerce2/merges","archive_url":"https://api.github.com/repos/acidvertigo/oscommerce2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/acidvertigo/oscommerce2/downloads","issues_url":"https://api.github.com/repos/acidvertigo/oscommerce2/issues{/number}","pulls_url":"https://api.github.com/repos/acidvertigo/oscommerce2/pulls{/number}","milestones_url":"https://api.github.com/repos/acidvertigo/oscommerce2/milestones{/number}","notifications_url":"https://api.github.com/repos/acidvertigo/oscommerce2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/acidvertigo/oscommerce2/labels{/name}","releases_url":"https://api.github.com/repos/acidvertigo/oscommerce2/releases{/id}","created_at":"2013-02-09T19:01:11Z","updated_at":"2014-09-11T03:30:27Z","pushed_at":"2014-10-07T10:05:28Z","git_url":"git://github.com/acidvertigo/oscommerce2.git","ssh_url":"git@github.com:acidvertigo/oscommerce2.git","clone_url":"https://github.com/acidvertigo/oscommerce2.git","svn_url":"https://github.com/acidvertigo/oscommerce2","homepage":"http://www.oscommerce.com","size":22402,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"osCommerce:master","ref":"master","sha":"ae3247fd921310eba8e3fa1d02434bea719d97ff","user":{"login":"osCommerce","id":57830,"avatar_url":"https://avatars.githubusercontent.com/u/57830?v=2","gravatar_id":"","url":"https://api.github.com/users/osCommerce","html_url":"https://github.com/osCommerce","followers_url":"https://api.github.com/users/osCommerce/followers","following_url":"https://api.github.com/users/osCommerce/following{/other_user}","gists_url":"https://api.github.com/users/osCommerce/gists{/gist_id}","starred_url":"https://api.github.com/users/osCommerce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osCommerce/subscriptions","organizations_url":"https://api.github.com/users/osCommerce/orgs","repos_url":"https://api.github.com/users/osCommerce/repos","events_url":"https://api.github.com/users/osCommerce/events{/privacy}","received_events_url":"https://api.github.com/users/osCommerce/received_events","type":"Organization","site_admin":false},"repo":{"id":154803,"name":"oscommerce2","full_name":"osCommerce/oscommerce2","owner":{"login":"osCommerce","id":57830,"avatar_url":"https://avatars.githubusercontent.com/u/57830?v=2","gravatar_id":"","url":"https://api.github.com/users/osCommerce","html_url":"https://github.com/osCommerce","followers_url":"https://api.github.com/users/osCommerce/followers","following_url":"https://api.github.com/users/osCommerce/following{/other_user}","gists_url":"https://api.github.com/users/osCommerce/gists{/gist_id}","starred_url":"https://api.github.com/users/osCommerce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osCommerce/subscriptions","organizations_url":"https://api.github.com/users/osCommerce/orgs","repos_url":"https://api.github.com/users/osCommerce/repos","events_url":"https://api.github.com/users/osCommerce/events{/privacy}","received_events_url":"https://api.github.com/users/osCommerce/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/osCommerce/oscommerce2","description":"osCommerce Online Merchant v2.x","fork":false,"url":"https://api.github.com/repos/osCommerce/oscommerce2","forks_url":"https://api.github.com/repos/osCommerce/oscommerce2/forks","keys_url":"https://api.github.com/repos/osCommerce/oscommerce2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/osCommerce/oscommerce2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/osCommerce/oscommerce2/teams","hooks_url":"https://api.github.com/repos/osCommerce/oscommerce2/hooks","issue_events_url":"https://api.github.com/repos/osCommerce/oscommerce2/issues/events{/number}","events_url":"https://api.github.com/repos/osCommerce/oscommerce2/events","assignees_url":"https://api.github.com/repos/osCommerce/oscommerce2/assignees{/user}","branches_url":"https://api.github.com/repos/osCommerce/oscommerce2/branches{/branch}","tags_url":"https://api.github.com/repos/osCommerce/oscommerce2/tags","blobs_url":"https://api.github.com/repos/osCommerce/oscommerce2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/osCommerce/oscommerce2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/osCommerce/oscommerce2/git/refs{/sha}","trees_url":"https://api.github.com/repos/osCommerce/oscommerce2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/osCommerce/oscommerce2/statuses/{sha}","languages_url":"https://api.github.com/repos/osCommerce/oscommerce2/languages","stargazers_url":"https://api.github.com/repos/osCommerce/oscommerce2/stargazers","contributors_url":"https://api.github.com/repos/osCommerce/oscommerce2/contributors","subscribers_url":"https://api.github.com/repos/osCommerce/oscommerce2/subscribers","subscription_url":"https://api.github.com/repos/osCommerce/oscommerce2/subscription","commits_url":"https://api.github.com/repos/osCommerce/oscommerce2/commits{/sha}","git_commits_url":"https://api.github.com/repos/osCommerce/oscommerce2/git/commits{/sha}","comments_url":"https://api.github.com/repos/osCommerce/oscommerce2/comments{/number}","issue_comment_url":"https://api.github.com/repos/osCommerce/oscommerce2/issues/comments/{number}","contents_url":"https://api.github.com/repos/osCommerce/oscommerce2/contents/{+path}","compare_url":"https://api.github.com/repos/osCommerce/oscommerce2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/osCommerce/oscommerce2/merges","archive_url":"https://api.github.com/repos/osCommerce/oscommerce2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/osCommerce/oscommerce2/downloads","issues_url":"https://api.github.com/repos/osCommerce/oscommerce2/issues{/number}","pulls_url":"https://api.github.com/repos/osCommerce/oscommerce2/pulls{/number}","milestones_url":"https://api.github.com/repos/osCommerce/oscommerce2/milestones{/number}","notifications_url":"https://api.github.com/repos/osCommerce/oscommerce2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/osCommerce/oscommerce2/labels{/name}","releases_url":"https://api.github.com/repos/osCommerce/oscommerce2/releases{/id}","created_at":"2009-03-20T04:11:49Z","updated_at":"2014-09-29T10:57:39Z","pushed_at":"2014-10-07T07:44:53Z","git_url":"git://github.com/osCommerce/oscommerce2.git","ssh_url":"git@github.com:osCommerce/oscommerce2.git","clone_url":"https://github.com/osCommerce/oscommerce2.git","svn_url":"https://github.com/osCommerce/oscommerce2","homepage":"http://www.oscommerce.com","size":27435,"stargazers_count":194,"watchers_count":194,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":147,"mirror_url":null,"open_issues_count":41,"forks":147,"open_issues":41,"watchers":194,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/osCommerce/oscommerce2/pulls/239"},"html":{"href":"https://github.com/osCommerce/oscommerce2/pull/239"},"issue":{"href":"https://api.github.com/repos/osCommerce/oscommerce2/issues/239"},"comments":{"href":"https://api.github.com/repos/osCommerce/oscommerce2/issues/239/comments"},"review_comments":{"href":"https://api.github.com/repos/osCommerce/oscommerce2/pulls/239/comments"},"review_comment":{"href":"https://api.github.com/repos/osCommerce/oscommerce2/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/osCommerce/oscommerce2/pulls/239/commits"},"statuses":{"href":"https://api.github.com/repos/osCommerce/oscommerce2/statuses/db13758fffadfedefeef75a47440265a566ab93f"}}}}