GitHub PullRequestReviewCommentEvent at 2014-05-28 11:48:42
Repository: frontend
Actor: kaelig
Payload: {"comment":{"url":"https://api.github.com/repos/guardian/frontend/pulls/comments/13126949","id":13126949,"diff_hunk":"@@ -0,0 +1,96 @@\n+define([\n+    'qwery',\n+    'bonzo',\n+    'common/$',\n+    'common/_',\n+    'common/modules/onward/history',\n+    'common/utils/cookies'\n+], function (\n+    qwery,\n+    bonzo,\n+    $,\n+    _,\n+    History,\n+    cookies\n+    ) {\n+\n+    return function () {\n+\n+        this.id = 'HideSupportingLinks';\n+        // not starting the test just yet, in now so we can style the component correctly for this spot\n+        this.start = '2014-05-28';\n+        this.expiry = '2014-06-24';\n+        this.author = 'Raul Tudor';\n+        this.description = 'Test user retention upon hiding the article supporting links on facia fronts';\n+        this.audience = 0.08;\n+        this.audienceOffset = 0.92;\n+        this.successMeasure = 'Click through rates on front overall and clicks on news container';\n+        this.audienceCriteria = 'Audience to the fronts';\n+        this.dataLinkNames = 'Hide supporting links on mobile';\n+        this.idealOutcome = 'Ideal outcome is that click through is increased overall';\n+\n+        var appConfig;\n+\n+        function getSublinks(){\n+            return $('.linkslist-container[data-lead-story-url]');\n+        }\n+\n+        this.canRun = function (config) {\n+            appConfig = config;","path":"common/app/assets/javascripts/modules/experiments/tests/hide-supporting-links.js","position":39,"original_position":39,"commit_id":"73ebf4cf6a6922dcd19b1f344b805f5454f0f473","original_commit_id":"73ebf4cf6a6922dcd19b1f344b805f5454f0f473","user":{"login":"kaelig","id":85783,"avatar_url":"https://avatars.githubusercontent.com/u/85783?","gravatar_id":"f7e7b837bd06d6193f4ac70f17e6f44b","url":"https://api.github.com/users/kaelig","html_url":"https://github.com/kaelig","followers_url":"https://api.github.com/users/kaelig/followers","following_url":"https://api.github.com/users/kaelig/following{/other_user}","gists_url":"https://api.github.com/users/kaelig/gists{/gist_id}","starred_url":"https://api.github.com/users/kaelig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaelig/subscriptions","organizations_url":"https://api.github.com/users/kaelig/orgs","repos_url":"https://api.github.com/users/kaelig/repos","events_url":"https://api.github.com/users/kaelig/events{/privacy}","received_events_url":"https://api.github.com/users/kaelig/received_events","type":"User","site_admin":false},"body":"Should this test be restricted to fronts so that it's not executed in articles?","created_at":"2014-05-28T11:48:42Z","updated_at":"2014-05-28T11:48:42Z","html_url":"https://github.com/guardian/frontend/pull/4445#discussion_r13126949","pull_request_url":"https://api.github.com/repos/guardian/frontend/pulls/4445","_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments/13126949"},"html":{"href":"https://github.com/guardian/frontend/pull/4445#discussion_r13126949"},"pull_request":{"href":"https://api.github.com/repos/guardian/frontend/pulls/4445"}}}}