GitHub PullRequestReviewCommentEvent at 2014-09-17 19:21:49
Repository: vwf
Actor: scottnc27603
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/virtual-world-framework/vwf/pulls/comments/17687259","id":17687259,"diff_hunk":"@@ -27,12 +32,35 @@ this.toggleVisibilty = function() {\n \n this.update = function( eventData, nodeData ) {\n     if ( this.draggable && ( this.pointerIsDown || this.touching ) ) {\n-        this.position = eventData.stageRelative;\n+        var point = this.nodePoint || this[ this.dragProperty ];\n+        var diff = [\n+            eventData.stageRelative[ 0 ] - this.lastPoint[ 0 ],\n+            eventData.stageRelative[ 1 ] - this.lastPoint[ 1 ]\n+        ];\n+\n+        if ( point instanceof Array ) {\n+            point[ 0 ] += diff[ 0 ];\n+            point[ 1 ] += diff[ 1 ];\n+        } else {\n+            point.x += diff[ 0 ];\n+            point.y += diff[ 1 ];\n+        }\n+\n+        this[ this.dragProperty ] = point;\n+        \n+        this.lastPoint = eventData.stageRelative;\n     }\n }\n \n this.pointerDown = function( eventData, nodeData ) {\n     this.pointerIsDown = true;\n+\n+    this.downPoint = eventData.stageRelative;\n+    this.lastPoint = eventData.stageRelative;\n+\n+    if ( this.client === this.moniker ) {\n+        this.nodePoint = this[ this.dragProperty ];","path":"support/proxy/vwf.example.com/kinetic/node.js","position":44,"original_position":44,"commit_id":"731a1bc5accf3bda074ab5e57559590f62e5aa95","original_commit_id":"731a1bc5accf3bda074ab5e57559590f62e5aa95","user":{"login":"scottnc27603","id":1278173,"avatar_url":"https://avatars.githubusercontent.com/u/1278173?v=2","gravatar_id":"71507090c09a57144de4acf9383a9ca6","url":"https://api.github.com/users/scottnc27603","html_url":"https://github.com/scottnc27603","followers_url":"https://api.github.com/users/scottnc27603/followers","following_url":"https://api.github.com/users/scottnc27603/following{/other_user}","gists_url":"https://api.github.com/users/scottnc27603/gists{/gist_id}","starred_url":"https://api.github.com/users/scottnc27603/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottnc27603/subscriptions","organizations_url":"https://api.github.com/users/scottnc27603/orgs","repos_url":"https://api.github.com/users/scottnc27603/repos","events_url":"https://api.github.com/users/scottnc27603/events{/privacy}","received_events_url":"https://api.github.com/users/scottnc27603/received_events","type":"User","site_admin":false},"body":"We have to know which client is dragging the object.  nodePoint is just a local property and is not a shared property, so I don't know what you mean by breaking the model.  We have to know which client is actually doing the dragging.\r\n\r\nIf having a local variable is such a huge issue then we shouldn't be using kinetic's drag functionality.  This would require us do the dragging ourselves.","created_at":"2014-09-17T19:21:49Z","updated_at":"2014-09-17T19:21:49Z","html_url":"https://github.com/virtual-world-framework/vwf/pull/351#discussion_r17687259","pull_request_url":"https://api.github.com/repos/virtual-world-framework/vwf/pulls/351","_links":{"self":{"href":"https://api.github.com/repos/virtual-world-framework/vwf/pulls/comments/17687259"},"html":{"href":"https://github.com/virtual-world-framework/vwf/pull/351#discussion_r17687259"},"pull_request":{"href":"https://api.github.com/repos/virtual-world-framework/vwf/pulls/351"}}},"pull_request":{"url":"https://api.github.com/repos/virtual-world-framework/vwf/pulls/351","id":21307309,"html_url":"https://github.com/virtual-world-framework/vwf/pull/351","diff_url":"https://github.com/virtual-world-framework/vwf/pull/351.diff","patch_url":"https://github.com/virtual-world-framework/vwf/pull/351.patch","issue_url":"https://api.github.com/repos/virtual-world-framework/vwf/issues/351","number":351,"state":"open","locked":false,"title":"Branch/drawing rect","user":{"login":"scottnc27603","id":1278173,"avatar_url":"https://avatars.githubusercontent.com/u/1278173?v=2","gravatar_id":"71507090c09a57144de4acf9383a9ca6","url":"https://api.github.com/users/scottnc27603","html_url":"https://github.com/scottnc27603","followers_url":"https://api.github.com/users/scottnc27603/followers","following_url":"https://api.github.com/users/scottnc27603/following{/other_user}","gists_url":"https://api.github.com/users/scottnc27603/gists{/gist_id}","starred_url":"https://api.github.com/users/scottnc27603/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottnc27603/subscriptions","organizations_url":"https://api.github.com/users/scottnc27603/orgs","repos_url":"https://api.github.com/users/scottnc27603/repos","events_url":"https://api.github.com/users/scottnc27603/events{/privacy}","received_events_url":"https://api.github.com/users/scottnc27603/received_events","type":"User","site_admin":false},"body":"@eric79 @youngca \r\nThe text, image, and sprite drawing objects all now have a border.\r\n\r\nAlso, fixed the dragging of icons so that the dragging is relative to the last move.","created_at":"2014-09-16T15:43:33Z","updated_at":"2014-09-17T19:21:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0b3276e6e8ac6520c7831113fd948da2a7c79579","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/virtual-world-framework/vwf/pulls/351/commits","review_comments_url":"https://api.github.com/repos/virtual-world-framework/vwf/pulls/351/comments","review_comment_url":"https://api.github.com/repos/virtual-world-framework/vwf/pulls/comments/{number}","comments_url":"https://api.github.com/repos/virtual-world-framework/vwf/issues/351/comments","statuses_url":"https://api.github.com/repos/virtual-world-framework/vwf/statuses/731a1bc5accf3bda074ab5e57559590f62e5aa95","head":{"label":"virtual-world-framework:branch/drawing-rect","ref":"branch/drawing-rect","sha":"731a1bc5accf3bda074ab5e57559590f62e5aa95","user":{"login":"virtual-world-framework","id":1552130,"avatar_url":"https://avatars.githubusercontent.com/u/1552130?v=2","gravatar_id":"4030558125d47329a00e5378c95d401b","url":"https://api.github.com/users/virtual-world-framework","html_url":"https://github.com/virtual-world-framework","followers_url":"https://api.github.com/users/virtual-world-framework/followers","following_url":"https://api.github.com/users/virtual-world-framework/following{/other_user}","gists_url":"https://api.github.com/users/virtual-world-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/virtual-world-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/virtual-world-framework/subscriptions","organizations_url":"https://api.github.com/users/virtual-world-framework/orgs","repos_url":"https://api.github.com/users/virtual-world-framework/repos","events_url":"https://api.github.com/users/virtual-world-framework/events{/privacy}","received_events_url":"https://api.github.com/users/virtual-world-framework/received_events","type":"Organization","site_admin":false},"repo":{"id":3857149,"name":"vwf","full_name":"virtual-world-framework/vwf","owner":{"login":"virtual-world-framework","id":1552130,"avatar_url":"https://avatars.githubusercontent.com/u/1552130?v=2","gravatar_id":"4030558125d47329a00e5378c95d401b","url":"https://api.github.com/users/virtual-world-framework","html_url":"https://github.com/virtual-world-framework","followers_url":"https://api.github.com/users/virtual-world-framework/followers","following_url":"https://api.github.com/users/virtual-world-framework/following{/other_user}","gists_url":"https://api.github.com/users/virtual-world-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/virtual-world-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/virtual-world-framework/subscriptions","organizations_url":"https://api.github.com/users/virtual-world-framework/orgs","repos_url":"https://api.github.com/users/virtual-world-framework/repos","events_url":"https://api.github.com/users/virtual-world-framework/events{/privacy}","received_events_url":"https://api.github.com/users/virtual-world-framework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/virtual-world-framework/vwf","description":"Virtual World Framework","fork":false,"url":"https://api.github.com/repos/virtual-world-framework/vwf","forks_url":"https://api.github.com/repos/virtual-world-framework/vwf/forks","keys_url":"https://api.github.com/repos/virtual-world-framework/vwf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/virtual-world-framework/vwf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/virtual-world-framework/vwf/teams","hooks_url":"https://api.github.com/repos/virtual-world-framework/vwf/hooks","issue_events_url":"https://api.github.com/repos/virtual-world-framework/vwf/issues/events{/number}","events_url":"https://api.github.com/repos/virtual-world-framework/vwf/events","assignees_url":"https://api.github.com/repos/virtual-world-framework/vwf/assignees{/user}","branches_url":"https://api.github.com/repos/virtual-world-framework/vwf/branches{/branch}","tags_url":"https://api.github.com/repos/virtual-world-framework/vwf/tags","blobs_url":"https://api.github.com/repos/virtual-world-framework/vwf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/virtual-world-framework/vwf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/virtual-world-framework/vwf/git/refs{/sha}","trees_url":"https://api.github.com/repos/virtual-world-framework/vwf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/virtual-world-framework/vwf/statuses/{sha}","languages_url":"https://api.github.com/repos/virtual-world-framework/vwf/languages","stargazers_url":"https://api.github.com/repos/virtual-world-framework/vwf/stargazers","contributors_url":"https://api.github.com/repos/virtual-world-framework/vwf/contributors","subscribers_url":"https://api.github.com/repos/virtual-world-framework/vwf/subscribers","subscription_url":"https://api.github.com/repos/virtual-world-framework/vwf/subscription","commits_url":"https://api.github.com/repos/virtual-world-framework/vwf/commits{/sha}","git_commits_url":"https://api.github.com/repos/virtual-world-framework/vwf/git/commits{/sha}","comments_url":"https://api.github.com/repos/virtual-world-framework/vwf/comments{/number}","issue_comment_url":"https://api.github.com/repos/virtual-world-framework/vwf/issues/comments/{number}","contents_url":"https://api.github.com/repos/virtual-world-framework/vwf/contents/{+path}","compare_url":"https://api.github.com/repos/virtual-world-framework/vwf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/virtual-world-framework/vwf/merges","archive_url":"https://api.github.com/repos/virtual-world-framework/vwf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/virtual-world-framework/vwf/downloads","issues_url":"https://api.github.com/repos/virtual-world-framework/vwf/issues{/number}","pulls_url":"https://api.github.com/repos/virtual-world-framework/vwf/pulls{/number}","milestones_url":"https://api.github.com/repos/virtual-world-framework/vwf/milestones{/number}","notifications_url":"https://api.github.com/repos/virtual-world-framework/vwf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/virtual-world-framework/vwf/labels{/name}","releases_url":"https://api.github.com/repos/virtual-world-framework/vwf/releases{/id}","created_at":"2012-03-28T16:40:09Z","updated_at":"2014-08-07T10:30:17Z","pushed_at":"2014-09-17T18:57:16Z","git_url":"git://github.com/virtual-world-framework/vwf.git","ssh_url":"git@github.com:virtual-world-framework/vwf.git","clone_url":"https://github.com/virtual-world-framework/vwf.git","svn_url":"https://github.com/virtual-world-framework/vwf","homepage":"http://virtual.wf","size":803572,"stargazers_count":74,"watchers_count":74,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"open_issues_count":17,"forks":41,"open_issues":17,"watchers":74,"default_branch":"master"}},"base":{"label":"virtual-world-framework:development","ref":"development","sha":"6936b4f29c83d729ffab0af20afe0e35776b197a","user":{"login":"virtual-world-framework","id":1552130,"avatar_url":"https://avatars.githubusercontent.com/u/1552130?v=2","gravatar_id":"4030558125d47329a00e5378c95d401b","url":"https://api.github.com/users/virtual-world-framework","html_url":"https://github.com/virtual-world-framework","followers_url":"https://api.github.com/users/virtual-world-framework/followers","following_url":"https://api.github.com/users/virtual-world-framework/following{/other_user}","gists_url":"https://api.github.com/users/virtual-world-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/virtual-world-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/virtual-world-framework/subscriptions","organizations_url":"https://api.github.com/users/virtual-world-framework/orgs","repos_url":"https://api.github.com/users/virtual-world-framework/repos","events_url":"https://api.github.com/users/virtual-world-framework/events{/privacy}","received_events_url":"https://api.github.com/users/virtual-world-framework/received_events","type":"Organization","site_admin":false},"repo":{"id":3857149,"name":"vwf","full_name":"virtual-world-framework/vwf","owner":{"login":"virtual-world-framework","id":1552130,"avatar_url":"https://avatars.githubusercontent.com/u/1552130?v=2","gravatar_id":"4030558125d47329a00e5378c95d401b","url":"https://api.github.com/users/virtual-world-framework","html_url":"https://github.com/virtual-world-framework","followers_url":"https://api.github.com/users/virtual-world-framework/followers","following_url":"https://api.github.com/users/virtual-world-framework/following{/other_user}","gists_url":"https://api.github.com/users/virtual-world-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/virtual-world-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/virtual-world-framework/subscriptions","organizations_url":"https://api.github.com/users/virtual-world-framework/orgs","repos_url":"https://api.github.com/users/virtual-world-framework/repos","events_url":"https://api.github.com/users/virtual-world-framework/events{/privacy}","received_events_url":"https://api.github.com/users/virtual-world-framework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/virtual-world-framework/vwf","description":"Virtual World Framework","fork":false,"url":"https://api.github.com/repos/virtual-world-framework/vwf","forks_url":"https://api.github.com/repos/virtual-world-framework/vwf/forks","keys_url":"https://api.github.com/repos/virtual-world-framework/vwf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/virtual-world-framework/vwf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/virtual-world-framework/vwf/teams","hooks_url":"https://api.github.com/repos/virtual-world-framework/vwf/hooks","issue_events_url":"https://api.github.com/repos/virtual-world-framework/vwf/issues/events{/number}","events_url":"https://api.github.com/repos/virtual-world-framework/vwf/events","assignees_url":"https://api.github.com/repos/virtual-world-framework/vwf/assignees{/user}","branches_url":"https://api.github.com/repos/virtual-world-framework/vwf/branches{/branch}","tags_url":"https://api.github.com/repos/virtual-world-framework/vwf/tags","blobs_url":"https://api.github.com/repos/virtual-world-framework/vwf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/virtual-world-framework/vwf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/virtual-world-framework/vwf/git/refs{/sha}","trees_url":"https://api.github.com/repos/virtual-world-framework/vwf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/virtual-world-framework/vwf/statuses/{sha}","languages_url":"https://api.github.com/repos/virtual-world-framework/vwf/languages","stargazers_url":"https://api.github.com/repos/virtual-world-framework/vwf/stargazers","contributors_url":"https://api.github.com/repos/virtual-world-framework/vwf/contributors","subscribers_url":"https://api.github.com/repos/virtual-world-framework/vwf/subscribers","subscription_url":"https://api.github.com/repos/virtual-world-framework/vwf/subscription","commits_url":"https://api.github.com/repos/virtual-world-framework/vwf/commits{/sha}","git_commits_url":"https://api.github.com/repos/virtual-world-framework/vwf/git/commits{/sha}","comments_url":"https://api.github.com/repos/virtual-world-framework/vwf/comments{/number}","issue_comment_url":"https://api.github.com/repos/virtual-world-framework/vwf/issues/comments/{number}","contents_url":"https://api.github.com/repos/virtual-world-framework/vwf/contents/{+path}","compare_url":"https://api.github.com/repos/virtual-world-framework/vwf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/virtual-world-framework/vwf/merges","archive_url":"https://api.github.com/repos/virtual-world-framework/vwf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/virtual-world-framework/vwf/downloads","issues_url":"https://api.github.com/repos/virtual-world-framework/vwf/issues{/number}","pulls_url":"https://api.github.com/repos/virtual-world-framework/vwf/pulls{/number}","milestones_url":"https://api.github.com/repos/virtual-world-framework/vwf/milestones{/number}","notifications_url":"https://api.github.com/repos/virtual-world-framework/vwf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/virtual-world-framework/vwf/labels{/name}","releases_url":"https://api.github.com/repos/virtual-world-framework/vwf/releases{/id}","created_at":"2012-03-28T16:40:09Z","updated_at":"2014-08-07T10:30:17Z","pushed_at":"2014-09-17T18:57:16Z","git_url":"git://github.com/virtual-world-framework/vwf.git","ssh_url":"git@github.com:virtual-world-framework/vwf.git","clone_url":"https://github.com/virtual-world-framework/vwf.git","svn_url":"https://github.com/virtual-world-framework/vwf","homepage":"http://virtual.wf","size":803572,"stargazers_count":74,"watchers_count":74,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"open_issues_count":17,"forks":41,"open_issues":17,"watchers":74,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/virtual-world-framework/vwf/pulls/351"},"html":{"href":"https://github.com/virtual-world-framework/vwf/pull/351"},"issue":{"href":"https://api.github.com/repos/virtual-world-framework/vwf/issues/351"},"comments":{"href":"https://api.github.com/repos/virtual-world-framework/vwf/issues/351/comments"},"review_comments":{"href":"https://api.github.com/repos/virtual-world-framework/vwf/pulls/351/comments"},"review_comment":{"href":"https://api.github.com/repos/virtual-world-framework/vwf/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/virtual-world-framework/vwf/pulls/351/commits"},"statuses":{"href":"https://api.github.com/repos/virtual-world-framework/vwf/statuses/731a1bc5accf3bda074ab5e57559590f62e5aa95"}}}}