GitHub PullRequestReviewCommentEvent at 2014-12-17 23:20:56
Repository: Theano
Actor: lamblin
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Theano/Theano/pulls/comments/22013461","id":22013461,"diff_hunk":"@@ -2152,7 +2152,7 @@ def c_support_code_apply(self, node, nodename):\n                             // this is effectively:\n                             // gx[image_row][image_col][x_row][x_col]\n                             //   = (my_z == x[image_row][image_col][\n-                            //                x_row][x_col]) ? my_gz : 0.0f;\n+                            //                x_row][x  _col]) ? my_gz : 0.0f;","path":"theano/sandbox/cuda/blas.py","position":5,"original_position":5,"commit_id":"780473a3d0869b00451ff0d624891d620e44bcc5","original_commit_id":"780473a3d0869b00451ff0d624891d620e44bcc5","user":{"login":"lamblin","id":178249,"avatar_url":"https://avatars.githubusercontent.com/u/178249?v=3","gravatar_id":"","url":"https://api.github.com/users/lamblin","html_url":"https://github.com/lamblin","followers_url":"https://api.github.com/users/lamblin/followers","following_url":"https://api.github.com/users/lamblin/following{/other_user}","gists_url":"https://api.github.com/users/lamblin/gists{/gist_id}","starred_url":"https://api.github.com/users/lamblin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lamblin/subscriptions","organizations_url":"https://api.github.com/users/lamblin/orgs","repos_url":"https://api.github.com/users/lamblin/repos","events_url":"https://api.github.com/users/lamblin/events{/privacy}","received_events_url":"https://api.github.com/users/lamblin/received_events","type":"User","site_admin":false},"body":"Was that a typo?","created_at":"2014-12-17T23:20:56Z","updated_at":"2014-12-17T23:20:56Z","html_url":"https://github.com/Theano/Theano/pull/2316#discussion_r22013461","pull_request_url":"https://api.github.com/repos/Theano/Theano/pulls/2316","_links":{"self":{"href":"https://api.github.com/repos/Theano/Theano/pulls/comments/22013461"},"html":{"href":"https://github.com/Theano/Theano/pull/2316#discussion_r22013461"},"pull_request":{"href":"https://api.github.com/repos/Theano/Theano/pulls/2316"}}},"pull_request":{"url":"https://api.github.com/repos/Theano/Theano/pulls/2316","id":25373623,"html_url":"https://github.com/Theano/Theano/pull/2316","diff_url":"https://github.com/Theano/Theano/pull/2316.diff","patch_url":"https://github.com/Theano/Theano/pull/2316.patch","issue_url":"https://api.github.com/repos/Theano/Theano/issues/2316","number":2316,"state":"open","locked":false,"title":"Added GpuDownsampleFactorMaxGradGrad","user":{"login":"ynd","id":1418,"avatar_url":"https://avatars.githubusercontent.com/u/1418?v=3","gravatar_id":"","url":"https://api.github.com/users/ynd","html_url":"https://github.com/ynd","followers_url":"https://api.github.com/users/ynd/followers","following_url":"https://api.github.com/users/ynd/following{/other_user}","gists_url":"https://api.github.com/users/ynd/gists{/gist_id}","starred_url":"https://api.github.com/users/ynd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ynd/subscriptions","organizations_url":"https://api.github.com/users/ynd/orgs","repos_url":"https://api.github.com/users/ynd/repos","events_url":"https://api.github.com/users/ynd/events{/privacy}","received_events_url":"https://api.github.com/users/ynd/received_events","type":"User","site_admin":false},"body":"This PR adds the GpuDownsampleFactorMaxGradGrad GPU Op which is a fast version of downsample.DownsampleFactorMaxGradGrad, which currently performed in pure python. I've added optimization and a test.\r\n\r\nAlso I corrected  bug in the tests of test_blas. Some tests would fail because enabling cuDNN by default would prevent Ops like GpuDownsampleFactorMaxGrad from being inserted.","created_at":"2014-12-02T20:56:40Z","updated_at":"2014-12-17T23:20:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"55f366daf317cb7420a07bb0f9f7830d0637d825","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Theano/Theano/pulls/2316/commits","review_comments_url":"https://api.github.com/repos/Theano/Theano/pulls/2316/comments","review_comment_url":"https://api.github.com/repos/Theano/Theano/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Theano/Theano/issues/2316/comments","statuses_url":"https://api.github.com/repos/Theano/Theano/statuses/780473a3d0869b00451ff0d624891d620e44bcc5","head":{"label":"ynd:poolgradgrad","ref":"poolgradgrad","sha":"780473a3d0869b00451ff0d624891d620e44bcc5","user":{"login":"ynd","id":1418,"avatar_url":"https://avatars.githubusercontent.com/u/1418?v=3","gravatar_id":"","url":"https://api.github.com/users/ynd","html_url":"https://github.com/ynd","followers_url":"https://api.github.com/users/ynd/followers","following_url":"https://api.github.com/users/ynd/following{/other_user}","gists_url":"https://api.github.com/users/ynd/gists{/gist_id}","starred_url":"https://api.github.com/users/ynd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ynd/subscriptions","organizations_url":"https://api.github.com/users/ynd/orgs","repos_url":"https://api.github.com/users/ynd/repos","events_url":"https://api.github.com/users/ynd/events{/privacy}","received_events_url":"https://api.github.com/users/ynd/received_events","type":"User","site_admin":false},"repo":{"id":2615292,"name":"Theano","full_name":"ynd/Theano","owner":{"login":"ynd","id":1418,"avatar_url":"https://avatars.githubusercontent.com/u/1418?v=3","gravatar_id":"","url":"https://api.github.com/users/ynd","html_url":"https://github.com/ynd","followers_url":"https://api.github.com/users/ynd/followers","following_url":"https://api.github.com/users/ynd/following{/other_user}","gists_url":"https://api.github.com/users/ynd/gists{/gist_id}","starred_url":"https://api.github.com/users/ynd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ynd/subscriptions","organizations_url":"https://api.github.com/users/ynd/orgs","repos_url":"https://api.github.com/users/ynd/repos","events_url":"https://api.github.com/users/ynd/events{/privacy}","received_events_url":"https://api.github.com/users/ynd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ynd/Theano","description":"Optimizing GPU-meta-programming code generating array oriented optimizing math compiler in Python","fork":true,"url":"https://api.github.com/repos/ynd/Theano","forks_url":"https://api.github.com/repos/ynd/Theano/forks","keys_url":"https://api.github.com/repos/ynd/Theano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ynd/Theano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ynd/Theano/teams","hooks_url":"https://api.github.com/repos/ynd/Theano/hooks","issue_events_url":"https://api.github.com/repos/ynd/Theano/issues/events{/number}","events_url":"https://api.github.com/repos/ynd/Theano/events","assignees_url":"https://api.github.com/repos/ynd/Theano/assignees{/user}","branches_url":"https://api.github.com/repos/ynd/Theano/branches{/branch}","tags_url":"https://api.github.com/repos/ynd/Theano/tags","blobs_url":"https://api.github.com/repos/ynd/Theano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ynd/Theano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ynd/Theano/git/refs{/sha}","trees_url":"https://api.github.com/repos/ynd/Theano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ynd/Theano/statuses/{sha}","languages_url":"https://api.github.com/repos/ynd/Theano/languages","stargazers_url":"https://api.github.com/repos/ynd/Theano/stargazers","contributors_url":"https://api.github.com/repos/ynd/Theano/contributors","subscribers_url":"https://api.github.com/repos/ynd/Theano/subscribers","subscription_url":"https://api.github.com/repos/ynd/Theano/subscription","commits_url":"https://api.github.com/repos/ynd/Theano/commits{/sha}","git_commits_url":"https://api.github.com/repos/ynd/Theano/git/commits{/sha}","comments_url":"https://api.github.com/repos/ynd/Theano/comments{/number}","issue_comment_url":"https://api.github.com/repos/ynd/Theano/issues/comments/{number}","contents_url":"https://api.github.com/repos/ynd/Theano/contents/{+path}","compare_url":"https://api.github.com/repos/ynd/Theano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ynd/Theano/merges","archive_url":"https://api.github.com/repos/ynd/Theano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ynd/Theano/downloads","issues_url":"https://api.github.com/repos/ynd/Theano/issues{/number}","pulls_url":"https://api.github.com/repos/ynd/Theano/pulls{/number}","milestones_url":"https://api.github.com/repos/ynd/Theano/milestones{/number}","notifications_url":"https://api.github.com/repos/ynd/Theano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ynd/Theano/labels{/name}","releases_url":"https://api.github.com/repos/ynd/Theano/releases{/id}","created_at":"2011-10-20T18:41:55Z","updated_at":"2014-04-29T16:41:56Z","pushed_at":"2014-12-02T20:54:13Z","git_url":"git://github.com/ynd/Theano.git","ssh_url":"git@github.com:ynd/Theano.git","clone_url":"https://github.com/ynd/Theano.git","svn_url":"https://github.com/ynd/Theano","homepage":"http://www.deeplearning.net/software/theano","size":24262,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"Theano:master","ref":"master","sha":"8deed652efccb7313a09c2d4970f906a8bd38f69","user":{"login":"Theano","id":970517,"avatar_url":"https://avatars.githubusercontent.com/u/970517?v=3","gravatar_id":"","url":"https://api.github.com/users/Theano","html_url":"https://github.com/Theano","followers_url":"https://api.github.com/users/Theano/followers","following_url":"https://api.github.com/users/Theano/following{/other_user}","gists_url":"https://api.github.com/users/Theano/gists{/gist_id}","starred_url":"https://api.github.com/users/Theano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Theano/subscriptions","organizations_url":"https://api.github.com/users/Theano/orgs","repos_url":"https://api.github.com/users/Theano/repos","events_url":"https://api.github.com/users/Theano/events{/privacy}","received_events_url":"https://api.github.com/users/Theano/received_events","type":"Organization","site_admin":false},"repo":{"id":2183193,"name":"Theano","full_name":"Theano/Theano","owner":{"login":"Theano","id":970517,"avatar_url":"https://avatars.githubusercontent.com/u/970517?v=3","gravatar_id":"","url":"https://api.github.com/users/Theano","html_url":"https://github.com/Theano","followers_url":"https://api.github.com/users/Theano/followers","following_url":"https://api.github.com/users/Theano/following{/other_user}","gists_url":"https://api.github.com/users/Theano/gists{/gist_id}","starred_url":"https://api.github.com/users/Theano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Theano/subscriptions","organizations_url":"https://api.github.com/users/Theano/orgs","repos_url":"https://api.github.com/users/Theano/repos","events_url":"https://api.github.com/users/Theano/events{/privacy}","received_events_url":"https://api.github.com/users/Theano/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Theano/Theano","description":"Optimizing GPU-meta-programming code generating array oriented optimizing math compiler in Python","fork":false,"url":"https://api.github.com/repos/Theano/Theano","forks_url":"https://api.github.com/repos/Theano/Theano/forks","keys_url":"https://api.github.com/repos/Theano/Theano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Theano/Theano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Theano/Theano/teams","hooks_url":"https://api.github.com/repos/Theano/Theano/hooks","issue_events_url":"https://api.github.com/repos/Theano/Theano/issues/events{/number}","events_url":"https://api.github.com/repos/Theano/Theano/events","assignees_url":"https://api.github.com/repos/Theano/Theano/assignees{/user}","branches_url":"https://api.github.com/repos/Theano/Theano/branches{/branch}","tags_url":"https://api.github.com/repos/Theano/Theano/tags","blobs_url":"https://api.github.com/repos/Theano/Theano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Theano/Theano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Theano/Theano/git/refs{/sha}","trees_url":"https://api.github.com/repos/Theano/Theano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Theano/Theano/statuses/{sha}","languages_url":"https://api.github.com/repos/Theano/Theano/languages","stargazers_url":"https://api.github.com/repos/Theano/Theano/stargazers","contributors_url":"https://api.github.com/repos/Theano/Theano/contributors","subscribers_url":"https://api.github.com/repos/Theano/Theano/subscribers","subscription_url":"https://api.github.com/repos/Theano/Theano/subscription","commits_url":"https://api.github.com/repos/Theano/Theano/commits{/sha}","git_commits_url":"https://api.github.com/repos/Theano/Theano/git/commits{/sha}","comments_url":"https://api.github.com/repos/Theano/Theano/comments{/number}","issue_comment_url":"https://api.github.com/repos/Theano/Theano/issues/comments/{number}","contents_url":"https://api.github.com/repos/Theano/Theano/contents/{+path}","compare_url":"https://api.github.com/repos/Theano/Theano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Theano/Theano/merges","archive_url":"https://api.github.com/repos/Theano/Theano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Theano/Theano/downloads","issues_url":"https://api.github.com/repos/Theano/Theano/issues{/number}","pulls_url":"https://api.github.com/repos/Theano/Theano/pulls{/number}","milestones_url":"https://api.github.com/repos/Theano/Theano/milestones{/number}","notifications_url":"https://api.github.com/repos/Theano/Theano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Theano/Theano/labels{/name}","releases_url":"https://api.github.com/repos/Theano/Theano/releases{/id}","created_at":"2011-08-10T03:48:06Z","updated_at":"2014-12-17T21:41:57Z","pushed_at":"2014-12-17T20:59:10Z","git_url":"git://github.com/Theano/Theano.git","ssh_url":"git@github.com:Theano/Theano.git","clone_url":"https://github.com/Theano/Theano.git","svn_url":"https://github.com/Theano/Theano","homepage":"http://www.deeplearning.net/software/theano","size":40403,"stargazers_count":993,"watchers_count":993,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":367,"mirror_url":null,"open_issues_count":307,"forks":367,"open_issues":307,"watchers":993,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Theano/Theano/pulls/2316"},"html":{"href":"https://github.com/Theano/Theano/pull/2316"},"issue":{"href":"https://api.github.com/repos/Theano/Theano/issues/2316"},"comments":{"href":"https://api.github.com/repos/Theano/Theano/issues/2316/comments"},"review_comments":{"href":"https://api.github.com/repos/Theano/Theano/pulls/2316/comments"},"review_comment":{"href":"https://api.github.com/repos/Theano/Theano/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Theano/Theano/pulls/2316/commits"},"statuses":{"href":"https://api.github.com/repos/Theano/Theano/statuses/780473a3d0869b00451ff0d624891d620e44bcc5"}}}}