GitHub PullRequestEvent at 2014-09-22 15:00:35
Repository: KeeFox
Actor: zer0keefie
Payload: {"action":"opened","number":329,"pull_request":{"url":"https://api.github.com/repos/luckyrat/KeeFox/pulls/329","id":21585113,"html_url":"https://github.com/luckyrat/KeeFox/pull/329","diff_url":"https://github.com/luckyrat/KeeFox/pull/329.diff","patch_url":"https://github.com/luckyrat/KeeFox/pull/329.patch","issue_url":"https://api.github.com/repos/luckyrat/KeeFox/issues/329","number":329,"state":"open","locked":false,"title":"Fix #326 by removing redeclared variables","user":{"login":"zer0keefie","id":1559253,"avatar_url":"https://avatars.githubusercontent.com/u/1559253?v=2","gravatar_id":"","url":"https://api.github.com/users/zer0keefie","html_url":"https://github.com/zer0keefie","followers_url":"https://api.github.com/users/zer0keefie/followers","following_url":"https://api.github.com/users/zer0keefie/following{/other_user}","gists_url":"https://api.github.com/users/zer0keefie/gists{/gist_id}","starred_url":"https://api.github.com/users/zer0keefie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zer0keefie/subscriptions","organizations_url":"https://api.github.com/users/zer0keefie/orgs","repos_url":"https://api.github.com/users/zer0keefie/repos","events_url":"https://api.github.com/users/zer0keefie/events{/privacy}","received_events_url":"https://api.github.com/users/zer0keefie/received_events","type":"User","site_admin":false},"body":"'wm' and 'window' were declared earlier using let, and re-declared here with the same values. Removing the second declarations fixes the \"TypeError: redeclaration of let wm - kprpcClient.js:1073\" error.\r\n\r\nThis seems to fix things for me, and running js -c on all the js files in the addon didn't show any other errors.","created_at":"2014-09-22T15:00:34Z","updated_at":"2014-09-22T15:00:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/luckyrat/KeeFox/pulls/329/commits","review_comments_url":"https://api.github.com/repos/luckyrat/KeeFox/pulls/329/comments","review_comment_url":"https://api.github.com/repos/luckyrat/KeeFox/pulls/comments/{number}","comments_url":"https://api.github.com/repos/luckyrat/KeeFox/issues/329/comments","statuses_url":"https://api.github.com/repos/luckyrat/KeeFox/statuses/cfd86330f6fdae6a89a52ee2fe4068d6370e40fe","head":{"label":"zer0keefie:temporal-let","ref":"temporal-let","sha":"cfd86330f6fdae6a89a52ee2fe4068d6370e40fe","user":{"login":"zer0keefie","id":1559253,"avatar_url":"https://avatars.githubusercontent.com/u/1559253?v=2","gravatar_id":"","url":"https://api.github.com/users/zer0keefie","html_url":"https://github.com/zer0keefie","followers_url":"https://api.github.com/users/zer0keefie/followers","following_url":"https://api.github.com/users/zer0keefie/following{/other_user}","gists_url":"https://api.github.com/users/zer0keefie/gists{/gist_id}","starred_url":"https://api.github.com/users/zer0keefie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zer0keefie/subscriptions","organizations_url":"https://api.github.com/users/zer0keefie/orgs","repos_url":"https://api.github.com/users/zer0keefie/repos","events_url":"https://api.github.com/users/zer0keefie/events{/privacy}","received_events_url":"https://api.github.com/users/zer0keefie/received_events","type":"User","site_admin":false},"repo":{"id":24331622,"name":"KeeFox","full_name":"zer0keefie/KeeFox","owner":{"login":"zer0keefie","id":1559253,"avatar_url":"https://avatars.githubusercontent.com/u/1559253?v=2","gravatar_id":"","url":"https://api.github.com/users/zer0keefie","html_url":"https://github.com/zer0keefie","followers_url":"https://api.github.com/users/zer0keefie/followers","following_url":"https://api.github.com/users/zer0keefie/following{/other_user}","gists_url":"https://api.github.com/users/zer0keefie/gists{/gist_id}","starred_url":"https://api.github.com/users/zer0keefie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zer0keefie/subscriptions","organizations_url":"https://api.github.com/users/zer0keefie/orgs","repos_url":"https://api.github.com/users/zer0keefie/repos","events_url":"https://api.github.com/users/zer0keefie/events{/privacy}","received_events_url":"https://api.github.com/users/zer0keefie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zer0keefie/KeeFox","description":"Simple and secure password management for Firefox users with KeePass. Download at https://addons.mozilla.org/en-US/firefox/addon/keefox/ ","fork":true,"url":"https://api.github.com/repos/zer0keefie/KeeFox","forks_url":"https://api.github.com/repos/zer0keefie/KeeFox/forks","keys_url":"https://api.github.com/repos/zer0keefie/KeeFox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zer0keefie/KeeFox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zer0keefie/KeeFox/teams","hooks_url":"https://api.github.com/repos/zer0keefie/KeeFox/hooks","issue_events_url":"https://api.github.com/repos/zer0keefie/KeeFox/issues/events{/number}","events_url":"https://api.github.com/repos/zer0keefie/KeeFox/events","assignees_url":"https://api.github.com/repos/zer0keefie/KeeFox/assignees{/user}","branches_url":"https://api.github.com/repos/zer0keefie/KeeFox/branches{/branch}","tags_url":"https://api.github.com/repos/zer0keefie/KeeFox/tags","blobs_url":"https://api.github.com/repos/zer0keefie/KeeFox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zer0keefie/KeeFox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zer0keefie/KeeFox/git/refs{/sha}","trees_url":"https://api.github.com/repos/zer0keefie/KeeFox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zer0keefie/KeeFox/statuses/{sha}","languages_url":"https://api.github.com/repos/zer0keefie/KeeFox/languages","stargazers_url":"https://api.github.com/repos/zer0keefie/KeeFox/stargazers","contributors_url":"https://api.github.com/repos/zer0keefie/KeeFox/contributors","subscribers_url":"https://api.github.com/repos/zer0keefie/KeeFox/subscribers","subscription_url":"https://api.github.com/repos/zer0keefie/KeeFox/subscription","commits_url":"https://api.github.com/repos/zer0keefie/KeeFox/commits{/sha}","git_commits_url":"https://api.github.com/repos/zer0keefie/KeeFox/git/commits{/sha}","comments_url":"https://api.github.com/repos/zer0keefie/KeeFox/comments{/number}","issue_comment_url":"https://api.github.com/repos/zer0keefie/KeeFox/issues/comments/{number}","contents_url":"https://api.github.com/repos/zer0keefie/KeeFox/contents/{+path}","compare_url":"https://api.github.com/repos/zer0keefie/KeeFox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zer0keefie/KeeFox/merges","archive_url":"https://api.github.com/repos/zer0keefie/KeeFox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zer0keefie/KeeFox/downloads","issues_url":"https://api.github.com/repos/zer0keefie/KeeFox/issues{/number}","pulls_url":"https://api.github.com/repos/zer0keefie/KeeFox/pulls{/number}","milestones_url":"https://api.github.com/repos/zer0keefie/KeeFox/milestones{/number}","notifications_url":"https://api.github.com/repos/zer0keefie/KeeFox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zer0keefie/KeeFox/labels{/name}","releases_url":"https://api.github.com/repos/zer0keefie/KeeFox/releases{/id}","created_at":"2014-09-22T14:21:32Z","updated_at":"2014-09-20T09:09:06Z","pushed_at":"2014-09-22T14:59:08Z","git_url":"git://github.com/zer0keefie/KeeFox.git","ssh_url":"git@github.com:zer0keefie/KeeFox.git","clone_url":"https://github.com/zer0keefie/KeeFox.git","svn_url":"https://github.com/zer0keefie/KeeFox","homepage":"http://keefox.org","size":65325,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"luckyrat:master","ref":"master","sha":"56b896295d95ba6744c3853a44d913ba691bd9f8","user":{"login":"luckyrat","id":1211375,"avatar_url":"https://avatars.githubusercontent.com/u/1211375?v=2","gravatar_id":"","url":"https://api.github.com/users/luckyrat","html_url":"https://github.com/luckyrat","followers_url":"https://api.github.com/users/luckyrat/followers","following_url":"https://api.github.com/users/luckyrat/following{/other_user}","gists_url":"https://api.github.com/users/luckyrat/gists{/gist_id}","starred_url":"https://api.github.com/users/luckyrat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luckyrat/subscriptions","organizations_url":"https://api.github.com/users/luckyrat/orgs","repos_url":"https://api.github.com/users/luckyrat/repos","events_url":"https://api.github.com/users/luckyrat/events{/privacy}","received_events_url":"https://api.github.com/users/luckyrat/received_events","type":"User","site_admin":false},"repo":{"id":3131961,"name":"KeeFox","full_name":"luckyrat/KeeFox","owner":{"login":"luckyrat","id":1211375,"avatar_url":"https://avatars.githubusercontent.com/u/1211375?v=2","gravatar_id":"","url":"https://api.github.com/users/luckyrat","html_url":"https://github.com/luckyrat","followers_url":"https://api.github.com/users/luckyrat/followers","following_url":"https://api.github.com/users/luckyrat/following{/other_user}","gists_url":"https://api.github.com/users/luckyrat/gists{/gist_id}","starred_url":"https://api.github.com/users/luckyrat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luckyrat/subscriptions","organizations_url":"https://api.github.com/users/luckyrat/orgs","repos_url":"https://api.github.com/users/luckyrat/repos","events_url":"https://api.github.com/users/luckyrat/events{/privacy}","received_events_url":"https://api.github.com/users/luckyrat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/luckyrat/KeeFox","description":"Simple and secure password management for Firefox users with KeePass. Download at https://addons.mozilla.org/en-US/firefox/addon/keefox/ ","fork":false,"url":"https://api.github.com/repos/luckyrat/KeeFox","forks_url":"https://api.github.com/repos/luckyrat/KeeFox/forks","keys_url":"https://api.github.com/repos/luckyrat/KeeFox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/luckyrat/KeeFox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/luckyrat/KeeFox/teams","hooks_url":"https://api.github.com/repos/luckyrat/KeeFox/hooks","issue_events_url":"https://api.github.com/repos/luckyrat/KeeFox/issues/events{/number}","events_url":"https://api.github.com/repos/luckyrat/KeeFox/events","assignees_url":"https://api.github.com/repos/luckyrat/KeeFox/assignees{/user}","branches_url":"https://api.github.com/repos/luckyrat/KeeFox/branches{/branch}","tags_url":"https://api.github.com/repos/luckyrat/KeeFox/tags","blobs_url":"https://api.github.com/repos/luckyrat/KeeFox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/luckyrat/KeeFox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/luckyrat/KeeFox/git/refs{/sha}","trees_url":"https://api.github.com/repos/luckyrat/KeeFox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/luckyrat/KeeFox/statuses/{sha}","languages_url":"https://api.github.com/repos/luckyrat/KeeFox/languages","stargazers_url":"https://api.github.com/repos/luckyrat/KeeFox/stargazers","contributors_url":"https://api.github.com/repos/luckyrat/KeeFox/contributors","subscribers_url":"https://api.github.com/repos/luckyrat/KeeFox/subscribers","subscription_url":"https://api.github.com/repos/luckyrat/KeeFox/subscription","commits_url":"https://api.github.com/repos/luckyrat/KeeFox/commits{/sha}","git_commits_url":"https://api.github.com/repos/luckyrat/KeeFox/git/commits{/sha}","comments_url":"https://api.github.com/repos/luckyrat/KeeFox/comments{/number}","issue_comment_url":"https://api.github.com/repos/luckyrat/KeeFox/issues/comments/{number}","contents_url":"https://api.github.com/repos/luckyrat/KeeFox/contents/{+path}","compare_url":"https://api.github.com/repos/luckyrat/KeeFox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/luckyrat/KeeFox/merges","archive_url":"https://api.github.com/repos/luckyrat/KeeFox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/luckyrat/KeeFox/downloads","issues_url":"https://api.github.com/repos/luckyrat/KeeFox/issues{/number}","pulls_url":"https://api.github.com/repos/luckyrat/KeeFox/pulls{/number}","milestones_url":"https://api.github.com/repos/luckyrat/KeeFox/milestones{/number}","notifications_url":"https://api.github.com/repos/luckyrat/KeeFox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/luckyrat/KeeFox/labels{/name}","releases_url":"https://api.github.com/repos/luckyrat/KeeFox/releases{/id}","created_at":"2012-01-08T20:53:10Z","updated_at":"2014-09-20T09:09:06Z","pushed_at":"2014-09-02T19:29:46Z","git_url":"git://github.com/luckyrat/KeeFox.git","ssh_url":"git@github.com:luckyrat/KeeFox.git","clone_url":"https://github.com/luckyrat/KeeFox.git","svn_url":"https://github.com/luckyrat/KeeFox","homepage":"http://keefox.org","size":70775,"stargazers_count":113,"watchers_count":113,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":83,"forks":31,"open_issues":83,"watchers":113,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/luckyrat/KeeFox/pulls/329"},"html":{"href":"https://github.com/luckyrat/KeeFox/pull/329"},"issue":{"href":"https://api.github.com/repos/luckyrat/KeeFox/issues/329"},"comments":{"href":"https://api.github.com/repos/luckyrat/KeeFox/issues/329/comments"},"review_comments":{"href":"https://api.github.com/repos/luckyrat/KeeFox/pulls/329/comments"},"review_comment":{"href":"https://api.github.com/repos/luckyrat/KeeFox/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/luckyrat/KeeFox/pulls/329/commits"},"statuses":{"href":"https://api.github.com/repos/luckyrat/KeeFox/statuses/cfd86330f6fdae6a89a52ee2fe4068d6370e40fe"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":0,"deletions":4,"changed_files":1}}