GitHub PullRequestReviewCommentEvent at 2014-09-19 18:47:46
Repository: opensim-core
Actor: aseth1
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/opensim-org/opensim-core/pulls/comments/17802209","id":17802209,"diff_hunk":"@@ -0,0 +1,89 @@\n+#ifndef OPENSIM_RIGIDFRAME_H_\n+#define OPENSIM_RIGIDFRAME_H_\n+/* -------------------------------------------------------------------------- *\n+*                              OpenSim:  RigidFrame.h                             *\n+* -------------------------------------------------------------------------- *\n+* The OpenSim API is a toolkit for musculoskeletal modeling and simulation.  *\n+* See http://opensim.stanford.edu and the NOTICE file for more information.  *\n+* OpenSim is developed at Stanford University and supported by the US        *\n+* National Institutes of Health (U54 GM072970, R24 HD065690) and by DARPA    *\n+* through the Warrior Web program.                                           *\n+*                                                                            *\n+* Copyright (c) 2005-2013 Stanford University and the Authors                *\n+* Author(s): Matt DeMers, Ajay Seth, Ayman Habib                             *\n+*                                                                            *\n+* Licensed under the Apache License, Version 2.0 (the \"License\"); you may    *\n+* not use this file except in compliance with the License. You may obtain a  *\n+* copy of the License at http://www.apache.org/licenses/LICENSE-2.0.         *\n+*                                                                            *\n+* Unless required by applicable law or agreed to in writing, software        *\n+* distributed under the License is distributed on an \"AS IS\" BASIS,          *\n+* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.   *\n+* See the License for the specific language governing permissions and        *\n+* limitations under the License.                                             *\n+* -------------------------------------------------------------------------- */\n+\n+// INCLUDE\n+#include <OpenSim/Simulation/osimSimulationDLL.h>\n+#include <OpenSim/Simulation/Model/Frame.h>\n+\n+\n+\n+namespace OpenSim {\n+\n+class Model;\n+class Body;\n+//=============================================================================\n+//=============================================================================\n+/**\n+* A RigidFrame is fixed to a Body. That is, its transform to this body is\n+* constant. A RigidFrame can be a Body itself. The body to which this frame is\n+* attached can be obtained via getBody(). Thus, it is guaranteed that any\n+* objects fixed to a rigid frame are also fixed to some Body in the system.","path":"OpenSim/Simulation/Model/RigidFrame.h","position":42,"original_position":42,"commit_id":"d67163f04420798bf5d72d9c0e3c01647c92a85c","original_commit_id":"d67163f04420798bf5d72d9c0e3c01647c92a85c","user":{"login":"aseth1","id":6494122,"avatar_url":"https://avatars.githubusercontent.com/u/6494122?v=2","gravatar_id":"185adab5a909132fb01f9611308b84e3","url":"https://api.github.com/users/aseth1","html_url":"https://github.com/aseth1","followers_url":"https://api.github.com/users/aseth1/followers","following_url":"https://api.github.com/users/aseth1/following{/other_user}","gists_url":"https://api.github.com/users/aseth1/gists{/gist_id}","starred_url":"https://api.github.com/users/aseth1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aseth1/subscriptions","organizations_url":"https://api.github.com/users/aseth1/orgs","repos_url":"https://api.github.com/users/aseth1/repos","events_url":"https://api.github.com/users/aseth1/events{/privacy}","received_events_url":"https://api.github.com/users/aseth1/received_events","type":"User","site_admin":false},"body":"@ msdemers I disagree. The example frame is a RigidFrame why should I make it derive from Frame? Body is a RigidFrame so it seems awkward to say the only reason a RigidFrame exists it to bind to a Body. The RigidFrame is an abstraction for something rigidly attached to the multibody system. Concrete types can have explicit connectors to Bodies, but I don't understand the insistence  that the abstract RigidFrame class has to have a Connector to a Body. Why? Why not leave it to modelers to decide if their are other RigidFrames that are useful to them?\r\n\r\nA RigidFrame is perfect for me to visualize intermediate frames of anatomical importance but they don't happen to be attached to a Body- they are part of the complex that forms my Joint. We can discuss Monday.\r\n","created_at":"2014-09-19T18:47:46Z","updated_at":"2014-09-19T18:47:46Z","html_url":"https://github.com/opensim-org/opensim-core/pull/188#discussion_r17802209","pull_request_url":"https://api.github.com/repos/opensim-org/opensim-core/pulls/188","_links":{"self":{"href":"https://api.github.com/repos/opensim-org/opensim-core/pulls/comments/17802209"},"html":{"href":"https://github.com/opensim-org/opensim-core/pull/188#discussion_r17802209"},"pull_request":{"href":"https://api.github.com/repos/opensim-org/opensim-core/pulls/188"}}},"pull_request":{"url":"https://api.github.com/repos/opensim-org/opensim-core/pulls/188","id":21184492,"html_url":"https://github.com/opensim-org/opensim-core/pull/188","diff_url":"https://github.com/opensim-org/opensim-core/pull/188.diff","patch_url":"https://github.com/opensim-org/opensim-core/pull/188.patch","issue_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/188","number":188,"state":"open","locked":false,"title":"Matt ayman frames","user":{"login":"aymanhab","id":3972208,"avatar_url":"https://avatars.githubusercontent.com/u/3972208?v=2","gravatar_id":"f4d566a54fb5a14fba8d3d85ce7f3763","url":"https://api.github.com/users/aymanhab","html_url":"https://github.com/aymanhab","followers_url":"https://api.github.com/users/aymanhab/followers","following_url":"https://api.github.com/users/aymanhab/following{/other_user}","gists_url":"https://api.github.com/users/aymanhab/gists{/gist_id}","starred_url":"https://api.github.com/users/aymanhab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aymanhab/subscriptions","organizations_url":"https://api.github.com/users/aymanhab/orgs","repos_url":"https://api.github.com/users/aymanhab/repos","events_url":"https://api.github.com/users/aymanhab/events{/privacy}","received_events_url":"https://api.github.com/users/aymanhab/received_events","type":"User","site_admin":false},"body":"Redo of the merge of Frame, RigidFrame, FixedFrame, Station and Marker ModelComponents along with code to convert Marker to new format for serialization/deserialization and inclusion of FrameSet in model.\r\n@sherm1 @msdemers @aseth1 or @chrisdembia Please review and let us know your feedback.","created_at":"2014-09-12T23:02:52Z","updated_at":"2014-09-19T18:47:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d705efd81a47b2c9f45486e6bbcb70d2ebb03c1f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/opensim-org/opensim-core/pulls/188/commits","review_comments_url":"https://api.github.com/repos/opensim-org/opensim-core/pulls/188/comments","review_comment_url":"https://api.github.com/repos/opensim-org/opensim-core/pulls/comments/{number}","comments_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/188/comments","statuses_url":"https://api.github.com/repos/opensim-org/opensim-core/statuses/d67163f04420798bf5d72d9c0e3c01647c92a85c","head":{"label":"opensim-org:matt_ayman_frames","ref":"matt_ayman_frames","sha":"d67163f04420798bf5d72d9c0e3c01647c92a85c","user":{"login":"opensim-org","id":4370782,"avatar_url":"https://avatars.githubusercontent.com/u/4370782?v=2","gravatar_id":"708747484bf6a7a398e0c65acb842c24","url":"https://api.github.com/users/opensim-org","html_url":"https://github.com/opensim-org","followers_url":"https://api.github.com/users/opensim-org/followers","following_url":"https://api.github.com/users/opensim-org/following{/other_user}","gists_url":"https://api.github.com/users/opensim-org/gists{/gist_id}","starred_url":"https://api.github.com/users/opensim-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opensim-org/subscriptions","organizations_url":"https://api.github.com/users/opensim-org/orgs","repos_url":"https://api.github.com/users/opensim-org/repos","events_url":"https://api.github.com/users/opensim-org/events{/privacy}","received_events_url":"https://api.github.com/users/opensim-org/received_events","type":"Organization","site_admin":false},"repo":{"id":20775600,"name":"opensim-core","full_name":"opensim-org/opensim-core","owner":{"login":"opensim-org","id":4370782,"avatar_url":"https://avatars.githubusercontent.com/u/4370782?v=2","gravatar_id":"708747484bf6a7a398e0c65acb842c24","url":"https://api.github.com/users/opensim-org","html_url":"https://github.com/opensim-org","followers_url":"https://api.github.com/users/opensim-org/followers","following_url":"https://api.github.com/users/opensim-org/following{/other_user}","gists_url":"https://api.github.com/users/opensim-org/gists{/gist_id}","starred_url":"https://api.github.com/users/opensim-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opensim-org/subscriptions","organizations_url":"https://api.github.com/users/opensim-org/orgs","repos_url":"https://api.github.com/users/opensim-org/repos","events_url":"https://api.github.com/users/opensim-org/events{/privacy}","received_events_url":"https://api.github.com/users/opensim-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opensim-org/opensim-core","description":"SimTK OpenSim C++ libraries and comand-line applications and Java/Python wrapping.","fork":false,"url":"https://api.github.com/repos/opensim-org/opensim-core","forks_url":"https://api.github.com/repos/opensim-org/opensim-core/forks","keys_url":"https://api.github.com/repos/opensim-org/opensim-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opensim-org/opensim-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opensim-org/opensim-core/teams","hooks_url":"https://api.github.com/repos/opensim-org/opensim-core/hooks","issue_events_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/events{/number}","events_url":"https://api.github.com/repos/opensim-org/opensim-core/events","assignees_url":"https://api.github.com/repos/opensim-org/opensim-core/assignees{/user}","branches_url":"https://api.github.com/repos/opensim-org/opensim-core/branches{/branch}","tags_url":"https://api.github.com/repos/opensim-org/opensim-core/tags","blobs_url":"https://api.github.com/repos/opensim-org/opensim-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opensim-org/opensim-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opensim-org/opensim-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/opensim-org/opensim-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opensim-org/opensim-core/statuses/{sha}","languages_url":"https://api.github.com/repos/opensim-org/opensim-core/languages","stargazers_url":"https://api.github.com/repos/opensim-org/opensim-core/stargazers","contributors_url":"https://api.github.com/repos/opensim-org/opensim-core/contributors","subscribers_url":"https://api.github.com/repos/opensim-org/opensim-core/subscribers","subscription_url":"https://api.github.com/repos/opensim-org/opensim-core/subscription","commits_url":"https://api.github.com/repos/opensim-org/opensim-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/opensim-org/opensim-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/opensim-org/opensim-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/comments/{number}","contents_url":"https://api.github.com/repos/opensim-org/opensim-core/contents/{+path}","compare_url":"https://api.github.com/repos/opensim-org/opensim-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opensim-org/opensim-core/merges","archive_url":"https://api.github.com/repos/opensim-org/opensim-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opensim-org/opensim-core/downloads","issues_url":"https://api.github.com/repos/opensim-org/opensim-core/issues{/number}","pulls_url":"https://api.github.com/repos/opensim-org/opensim-core/pulls{/number}","milestones_url":"https://api.github.com/repos/opensim-org/opensim-core/milestones{/number}","notifications_url":"https://api.github.com/repos/opensim-org/opensim-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opensim-org/opensim-core/labels{/name}","releases_url":"https://api.github.com/repos/opensim-org/opensim-core/releases{/id}","created_at":"2014-06-12T16:57:56Z","updated_at":"2014-09-14T10:31:19Z","pushed_at":"2014-09-18T22:10:30Z","git_url":"git://github.com/opensim-org/opensim-core.git","ssh_url":"git@github.com:opensim-org/opensim-core.git","clone_url":"https://github.com/opensim-org/opensim-core.git","svn_url":"https://github.com/opensim-org/opensim-core","homepage":"opensim.stanford.edu","size":109643,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":80,"forks":3,"open_issues":80,"watchers":5,"default_branch":"master"}},"base":{"label":"opensim-org:master","ref":"master","sha":"d5b7cda3dd10717b538d24ce35a6046494554148","user":{"login":"opensim-org","id":4370782,"avatar_url":"https://avatars.githubusercontent.com/u/4370782?v=2","gravatar_id":"708747484bf6a7a398e0c65acb842c24","url":"https://api.github.com/users/opensim-org","html_url":"https://github.com/opensim-org","followers_url":"https://api.github.com/users/opensim-org/followers","following_url":"https://api.github.com/users/opensim-org/following{/other_user}","gists_url":"https://api.github.com/users/opensim-org/gists{/gist_id}","starred_url":"https://api.github.com/users/opensim-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opensim-org/subscriptions","organizations_url":"https://api.github.com/users/opensim-org/orgs","repos_url":"https://api.github.com/users/opensim-org/repos","events_url":"https://api.github.com/users/opensim-org/events{/privacy}","received_events_url":"https://api.github.com/users/opensim-org/received_events","type":"Organization","site_admin":false},"repo":{"id":20775600,"name":"opensim-core","full_name":"opensim-org/opensim-core","owner":{"login":"opensim-org","id":4370782,"avatar_url":"https://avatars.githubusercontent.com/u/4370782?v=2","gravatar_id":"708747484bf6a7a398e0c65acb842c24","url":"https://api.github.com/users/opensim-org","html_url":"https://github.com/opensim-org","followers_url":"https://api.github.com/users/opensim-org/followers","following_url":"https://api.github.com/users/opensim-org/following{/other_user}","gists_url":"https://api.github.com/users/opensim-org/gists{/gist_id}","starred_url":"https://api.github.com/users/opensim-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opensim-org/subscriptions","organizations_url":"https://api.github.com/users/opensim-org/orgs","repos_url":"https://api.github.com/users/opensim-org/repos","events_url":"https://api.github.com/users/opensim-org/events{/privacy}","received_events_url":"https://api.github.com/users/opensim-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opensim-org/opensim-core","description":"SimTK OpenSim C++ libraries and comand-line applications and Java/Python wrapping.","fork":false,"url":"https://api.github.com/repos/opensim-org/opensim-core","forks_url":"https://api.github.com/repos/opensim-org/opensim-core/forks","keys_url":"https://api.github.com/repos/opensim-org/opensim-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opensim-org/opensim-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opensim-org/opensim-core/teams","hooks_url":"https://api.github.com/repos/opensim-org/opensim-core/hooks","issue_events_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/events{/number}","events_url":"https://api.github.com/repos/opensim-org/opensim-core/events","assignees_url":"https://api.github.com/repos/opensim-org/opensim-core/assignees{/user}","branches_url":"https://api.github.com/repos/opensim-org/opensim-core/branches{/branch}","tags_url":"https://api.github.com/repos/opensim-org/opensim-core/tags","blobs_url":"https://api.github.com/repos/opensim-org/opensim-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opensim-org/opensim-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opensim-org/opensim-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/opensim-org/opensim-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opensim-org/opensim-core/statuses/{sha}","languages_url":"https://api.github.com/repos/opensim-org/opensim-core/languages","stargazers_url":"https://api.github.com/repos/opensim-org/opensim-core/stargazers","contributors_url":"https://api.github.com/repos/opensim-org/opensim-core/contributors","subscribers_url":"https://api.github.com/repos/opensim-org/opensim-core/subscribers","subscription_url":"https://api.github.com/repos/opensim-org/opensim-core/subscription","commits_url":"https://api.github.com/repos/opensim-org/opensim-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/opensim-org/opensim-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/opensim-org/opensim-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/comments/{number}","contents_url":"https://api.github.com/repos/opensim-org/opensim-core/contents/{+path}","compare_url":"https://api.github.com/repos/opensim-org/opensim-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opensim-org/opensim-core/merges","archive_url":"https://api.github.com/repos/opensim-org/opensim-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opensim-org/opensim-core/downloads","issues_url":"https://api.github.com/repos/opensim-org/opensim-core/issues{/number}","pulls_url":"https://api.github.com/repos/opensim-org/opensim-core/pulls{/number}","milestones_url":"https://api.github.com/repos/opensim-org/opensim-core/milestones{/number}","notifications_url":"https://api.github.com/repos/opensim-org/opensim-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opensim-org/opensim-core/labels{/name}","releases_url":"https://api.github.com/repos/opensim-org/opensim-core/releases{/id}","created_at":"2014-06-12T16:57:56Z","updated_at":"2014-09-14T10:31:19Z","pushed_at":"2014-09-18T22:10:30Z","git_url":"git://github.com/opensim-org/opensim-core.git","ssh_url":"git@github.com:opensim-org/opensim-core.git","clone_url":"https://github.com/opensim-org/opensim-core.git","svn_url":"https://github.com/opensim-org/opensim-core","homepage":"opensim.stanford.edu","size":109643,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":80,"forks":3,"open_issues":80,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opensim-org/opensim-core/pulls/188"},"html":{"href":"https://github.com/opensim-org/opensim-core/pull/188"},"issue":{"href":"https://api.github.com/repos/opensim-org/opensim-core/issues/188"},"comments":{"href":"https://api.github.com/repos/opensim-org/opensim-core/issues/188/comments"},"review_comments":{"href":"https://api.github.com/repos/opensim-org/opensim-core/pulls/188/comments"},"review_comment":{"href":"https://api.github.com/repos/opensim-org/opensim-core/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/opensim-org/opensim-core/pulls/188/commits"},"statuses":{"href":"https://api.github.com/repos/opensim-org/opensim-core/statuses/d67163f04420798bf5d72d9c0e3c01647c92a85c"}}}}