GitHub PullRequestReviewCommentEvent at 2014-10-03 04:37:11
Repository: pylearn2
Actor: bartvm
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/lisa-lab/pylearn2/pulls/comments/18381264","id":18381264,"diff_hunk":"@@ -70,3 +72,99 @@ def test_compute_recall():\n     recall = compute_recall(ys, tp)\n     assert np.allclose(recall.eval(),\n                        recall_py)\n+\n+\n+def test_kl():\n+    \"\"\"\n+    Test whether function kl() has properly processed the input.\n+    \"\"\"\n+    from pylearn2.models.mlp import MLP, Sigmoid\n+    import theano\n+    from theano.gof.op import get_debug_values\n+\n+    init_mode = theano.config.compute_test_value\n+    theano.config.compute_test_value = 'warn' #except for \"warn,\" which other flags has debug values assigened? Maybe we need to include all of them here for better reliablity.","path":"pylearn2/expr/tests/test_nnet.py","position":24,"original_position":24,"commit_id":"9945f9ce734fb822bb8b5f89fcecaad44f8c7e49","original_commit_id":"9945f9ce734fb822bb8b5f89fcecaad44f8c7e49","user":{"login":"bartvm","id":2299595,"avatar_url":"https://avatars.githubusercontent.com/u/2299595?v=2","gravatar_id":"","url":"https://api.github.com/users/bartvm","html_url":"https://github.com/bartvm","followers_url":"https://api.github.com/users/bartvm/followers","following_url":"https://api.github.com/users/bartvm/following{/other_user}","gists_url":"https://api.github.com/users/bartvm/gists{/gist_id}","starred_url":"https://api.github.com/users/bartvm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartvm/subscriptions","organizations_url":"https://api.github.com/users/bartvm/orgs","repos_url":"https://api.github.com/users/bartvm/repos","events_url":"https://api.github.com/users/bartvm/events{/privacy}","received_events_url":"https://api.github.com/users/bartvm/received_events","type":"User","site_admin":false},"body":"Valid options are `off`, `ignore`, `warn`, `raise` and `pdb`. Maybe setting it to `raise` would be fine here?","created_at":"2014-10-03T04:37:11Z","updated_at":"2014-10-03T04:37:11Z","html_url":"https://github.com/lisa-lab/pylearn2/pull/1166#discussion_r18381264","pull_request_url":"https://api.github.com/repos/lisa-lab/pylearn2/pulls/1166","_links":{"self":{"href":"https://api.github.com/repos/lisa-lab/pylearn2/pulls/comments/18381264"},"html":{"href":"https://github.com/lisa-lab/pylearn2/pull/1166#discussion_r18381264"},"pull_request":{"href":"https://api.github.com/repos/lisa-lab/pylearn2/pulls/1166"}}},"pull_request":{"url":"https://api.github.com/repos/lisa-lab/pylearn2/pulls/1166","id":22180282,"html_url":"https://github.com/lisa-lab/pylearn2/pull/1166","diff_url":"https://github.com/lisa-lab/pylearn2/pull/1166.diff","patch_url":"https://github.com/lisa-lab/pylearn2/pull/1166.patch","issue_url":"https://api.github.com/repos/lisa-lab/pylearn2/issues/1166","number":1166,"state":"open","locked":false,"title":"Check y","user":{"login":"hantek","id":5122190,"avatar_url":"https://avatars.githubusercontent.com/u/5122190?v=2","gravatar_id":"","url":"https://api.github.com/users/hantek","html_url":"https://github.com/hantek","followers_url":"https://api.github.com/users/hantek/followers","following_url":"https://api.github.com/users/hantek/following{/other_user}","gists_url":"https://api.github.com/users/hantek/gists{/gist_id}","starred_url":"https://api.github.com/users/hantek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hantek/subscriptions","organizations_url":"https://api.github.com/users/hantek/orgs","repos_url":"https://api.github.com/users/hantek/repos","events_url":"https://api.github.com/users/hantek/events{/privacy}","received_events_url":"https://api.github.com/users/hantek/received_events","type":"User","site_admin":false},"body":"By using the get_debug_values() function and with flag \"theano.config.compute_test_value\" turned on, we can now check the value of Y before computing kl or elemwise_kl. Note that this feature should only be expected to work in test time, not for passed values in a real function call.\r\n\r\nShould we check every mode of \"theano.config.compute_test_value\" in the unit test? Or, since it is only a unit test for kl (or elemwise_kl), just testing it on one of the mode will be OK?","created_at":"2014-10-03T00:38:03Z","updated_at":"2014-10-03T04:37:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9472db5f68089fa094a13b861c8453959bd19a75","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lisa-lab/pylearn2/pulls/1166/commits","review_comments_url":"https://api.github.com/repos/lisa-lab/pylearn2/pulls/1166/comments","review_comment_url":"https://api.github.com/repos/lisa-lab/pylearn2/pulls/comments/{number}","comments_url":"https://api.github.com/repos/lisa-lab/pylearn2/issues/1166/comments","statuses_url":"https://api.github.com/repos/lisa-lab/pylearn2/statuses/9945f9ce734fb822bb8b5f89fcecaad44f8c7e49","head":{"label":"hantek:check_y","ref":"check_y","sha":"9945f9ce734fb822bb8b5f89fcecaad44f8c7e49","user":{"login":"hantek","id":5122190,"avatar_url":"https://avatars.githubusercontent.com/u/5122190?v=2","gravatar_id":"","url":"https://api.github.com/users/hantek","html_url":"https://github.com/hantek","followers_url":"https://api.github.com/users/hantek/followers","following_url":"https://api.github.com/users/hantek/following{/other_user}","gists_url":"https://api.github.com/users/hantek/gists{/gist_id}","starred_url":"https://api.github.com/users/hantek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hantek/subscriptions","organizations_url":"https://api.github.com/users/hantek/orgs","repos_url":"https://api.github.com/users/hantek/repos","events_url":"https://api.github.com/users/hantek/events{/privacy}","received_events_url":"https://api.github.com/users/hantek/received_events","type":"User","site_admin":false},"repo":{"id":24390201,"name":"pylearn2","full_name":"hantek/pylearn2","owner":{"login":"hantek","id":5122190,"avatar_url":"https://avatars.githubusercontent.com/u/5122190?v=2","gravatar_id":"","url":"https://api.github.com/users/hantek","html_url":"https://github.com/hantek","followers_url":"https://api.github.com/users/hantek/followers","following_url":"https://api.github.com/users/hantek/following{/other_user}","gists_url":"https://api.github.com/users/hantek/gists{/gist_id}","starred_url":"https://api.github.com/users/hantek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hantek/subscriptions","organizations_url":"https://api.github.com/users/hantek/orgs","repos_url":"https://api.github.com/users/hantek/repos","events_url":"https://api.github.com/users/hantek/events{/privacy}","received_events_url":"https://api.github.com/users/hantek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hantek/pylearn2","description":"A Machine Learning library based on Theano","fork":true,"url":"https://api.github.com/repos/hantek/pylearn2","forks_url":"https://api.github.com/repos/hantek/pylearn2/forks","keys_url":"https://api.github.com/repos/hantek/pylearn2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hantek/pylearn2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hantek/pylearn2/teams","hooks_url":"https://api.github.com/repos/hantek/pylearn2/hooks","issue_events_url":"https://api.github.com/repos/hantek/pylearn2/issues/events{/number}","events_url":"https://api.github.com/repos/hantek/pylearn2/events","assignees_url":"https://api.github.com/repos/hantek/pylearn2/assignees{/user}","branches_url":"https://api.github.com/repos/hantek/pylearn2/branches{/branch}","tags_url":"https://api.github.com/repos/hantek/pylearn2/tags","blobs_url":"https://api.github.com/repos/hantek/pylearn2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hantek/pylearn2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hantek/pylearn2/git/refs{/sha}","trees_url":"https://api.github.com/repos/hantek/pylearn2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hantek/pylearn2/statuses/{sha}","languages_url":"https://api.github.com/repos/hantek/pylearn2/languages","stargazers_url":"https://api.github.com/repos/hantek/pylearn2/stargazers","contributors_url":"https://api.github.com/repos/hantek/pylearn2/contributors","subscribers_url":"https://api.github.com/repos/hantek/pylearn2/subscribers","subscription_url":"https://api.github.com/repos/hantek/pylearn2/subscription","commits_url":"https://api.github.com/repos/hantek/pylearn2/commits{/sha}","git_commits_url":"https://api.github.com/repos/hantek/pylearn2/git/commits{/sha}","comments_url":"https://api.github.com/repos/hantek/pylearn2/comments{/number}","issue_comment_url":"https://api.github.com/repos/hantek/pylearn2/issues/comments/{number}","contents_url":"https://api.github.com/repos/hantek/pylearn2/contents/{+path}","compare_url":"https://api.github.com/repos/hantek/pylearn2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hantek/pylearn2/merges","archive_url":"https://api.github.com/repos/hantek/pylearn2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hantek/pylearn2/downloads","issues_url":"https://api.github.com/repos/hantek/pylearn2/issues{/number}","pulls_url":"https://api.github.com/repos/hantek/pylearn2/pulls{/number}","milestones_url":"https://api.github.com/repos/hantek/pylearn2/milestones{/number}","notifications_url":"https://api.github.com/repos/hantek/pylearn2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hantek/pylearn2/labels{/name}","releases_url":"https://api.github.com/repos/hantek/pylearn2/releases{/id}","created_at":"2014-09-23T21:34:00Z","updated_at":"2014-09-23T19:01:43Z","pushed_at":"2014-10-03T00:31:09Z","git_url":"git://github.com/hantek/pylearn2.git","ssh_url":"git@github.com:hantek/pylearn2.git","clone_url":"https://github.com/hantek/pylearn2.git","svn_url":"https://github.com/hantek/pylearn2","homepage":"","size":9903,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lisa-lab:master","ref":"master","sha":"de671b4cbf7dc0885c4a966c2255effe7474398e","user":{"login":"lisa-lab","id":178109,"avatar_url":"https://avatars.githubusercontent.com/u/178109?v=2","gravatar_id":"","url":"https://api.github.com/users/lisa-lab","html_url":"https://github.com/lisa-lab","followers_url":"https://api.github.com/users/lisa-lab/followers","following_url":"https://api.github.com/users/lisa-lab/following{/other_user}","gists_url":"https://api.github.com/users/lisa-lab/gists{/gist_id}","starred_url":"https://api.github.com/users/lisa-lab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lisa-lab/subscriptions","organizations_url":"https://api.github.com/users/lisa-lab/orgs","repos_url":"https://api.github.com/users/lisa-lab/repos","events_url":"https://api.github.com/users/lisa-lab/events{/privacy}","received_events_url":"https://api.github.com/users/lisa-lab/received_events","type":"Organization","site_admin":false},"repo":{"id":1103054,"name":"pylearn2","full_name":"lisa-lab/pylearn2","owner":{"login":"lisa-lab","id":178109,"avatar_url":"https://avatars.githubusercontent.com/u/178109?v=2","gravatar_id":"","url":"https://api.github.com/users/lisa-lab","html_url":"https://github.com/lisa-lab","followers_url":"https://api.github.com/users/lisa-lab/followers","following_url":"https://api.github.com/users/lisa-lab/following{/other_user}","gists_url":"https://api.github.com/users/lisa-lab/gists{/gist_id}","starred_url":"https://api.github.com/users/lisa-lab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lisa-lab/subscriptions","organizations_url":"https://api.github.com/users/lisa-lab/orgs","repos_url":"https://api.github.com/users/lisa-lab/repos","events_url":"https://api.github.com/users/lisa-lab/events{/privacy}","received_events_url":"https://api.github.com/users/lisa-lab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lisa-lab/pylearn2","description":"A Machine Learning library based on Theano","fork":false,"url":"https://api.github.com/repos/lisa-lab/pylearn2","forks_url":"https://api.github.com/repos/lisa-lab/pylearn2/forks","keys_url":"https://api.github.com/repos/lisa-lab/pylearn2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lisa-lab/pylearn2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lisa-lab/pylearn2/teams","hooks_url":"https://api.github.com/repos/lisa-lab/pylearn2/hooks","issue_events_url":"https://api.github.com/repos/lisa-lab/pylearn2/issues/events{/number}","events_url":"https://api.github.com/repos/lisa-lab/pylearn2/events","assignees_url":"https://api.github.com/repos/lisa-lab/pylearn2/assignees{/user}","branches_url":"https://api.github.com/repos/lisa-lab/pylearn2/branches{/branch}","tags_url":"https://api.github.com/repos/lisa-lab/pylearn2/tags","blobs_url":"https://api.github.com/repos/lisa-lab/pylearn2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lisa-lab/pylearn2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lisa-lab/pylearn2/git/refs{/sha}","trees_url":"https://api.github.com/repos/lisa-lab/pylearn2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lisa-lab/pylearn2/statuses/{sha}","languages_url":"https://api.github.com/repos/lisa-lab/pylearn2/languages","stargazers_url":"https://api.github.com/repos/lisa-lab/pylearn2/stargazers","contributors_url":"https://api.github.com/repos/lisa-lab/pylearn2/contributors","subscribers_url":"https://api.github.com/repos/lisa-lab/pylearn2/subscribers","subscription_url":"https://api.github.com/repos/lisa-lab/pylearn2/subscription","commits_url":"https://api.github.com/repos/lisa-lab/pylearn2/commits{/sha}","git_commits_url":"https://api.github.com/repos/lisa-lab/pylearn2/git/commits{/sha}","comments_url":"https://api.github.com/repos/lisa-lab/pylearn2/comments{/number}","issue_comment_url":"https://api.github.com/repos/lisa-lab/pylearn2/issues/comments/{number}","contents_url":"https://api.github.com/repos/lisa-lab/pylearn2/contents/{+path}","compare_url":"https://api.github.com/repos/lisa-lab/pylearn2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lisa-lab/pylearn2/merges","archive_url":"https://api.github.com/repos/lisa-lab/pylearn2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lisa-lab/pylearn2/downloads","issues_url":"https://api.github.com/repos/lisa-lab/pylearn2/issues{/number}","pulls_url":"https://api.github.com/repos/lisa-lab/pylearn2/pulls{/number}","milestones_url":"https://api.github.com/repos/lisa-lab/pylearn2/milestones{/number}","notifications_url":"https://api.github.com/repos/lisa-lab/pylearn2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lisa-lab/pylearn2/labels{/name}","releases_url":"https://api.github.com/repos/lisa-lab/pylearn2/releases{/id}","created_at":"2010-11-22T18:00:50Z","updated_at":"2014-10-03T03:53:32Z","pushed_at":"2014-10-02T17:53:16Z","git_url":"git://github.com/lisa-lab/pylearn2.git","ssh_url":"git@github.com:lisa-lab/pylearn2.git","clone_url":"https://github.com/lisa-lab/pylearn2.git","svn_url":"https://github.com/lisa-lab/pylearn2","homepage":"","size":694795,"stargazers_count":1005,"watchers_count":1005,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":379,"mirror_url":null,"open_issues_count":203,"forks":379,"open_issues":203,"watchers":1005,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lisa-lab/pylearn2/pulls/1166"},"html":{"href":"https://github.com/lisa-lab/pylearn2/pull/1166"},"issue":{"href":"https://api.github.com/repos/lisa-lab/pylearn2/issues/1166"},"comments":{"href":"https://api.github.com/repos/lisa-lab/pylearn2/issues/1166/comments"},"review_comments":{"href":"https://api.github.com/repos/lisa-lab/pylearn2/pulls/1166/comments"},"review_comment":{"href":"https://api.github.com/repos/lisa-lab/pylearn2/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/lisa-lab/pylearn2/pulls/1166/commits"},"statuses":{"href":"https://api.github.com/repos/lisa-lab/pylearn2/statuses/9945f9ce734fb822bb8b5f89fcecaad44f8c7e49"}}}}