GitHub PullRequestReviewCommentEvent at 2014-06-18 06:59:33
Repository: juju
Actor: jameinel
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/juju/juju/pulls/comments/13901705","id":13901705,"diff_hunk":"@@ -318,6 +318,11 @@ func (st *State) createStateServersDoc() error {\n \treturn st.runTransaction(ops)\n }\n \n+// Info returns information for connecting to mongo\n+func (st *State) Info() *Info {","path":"state/open.go","position":5,"original_position":5,"commit_id":"59f1a1718d34bec09d59dfa2c4d0f9af3e9d4cb8","original_commit_id":"59f1a1718d34bec09d59dfa2c4d0f9af3e9d4cb8","user":{"login":"jameinel","id":202877,"avatar_url":"https://avatars.githubusercontent.com/u/202877?","gravatar_id":"7e8cd608c5279257b9eca560b543b8ad","url":"https://api.github.com/users/jameinel","html_url":"https://github.com/jameinel","followers_url":"https://api.github.com/users/jameinel/followers","following_url":"https://api.github.com/users/jameinel/following{/other_user}","gists_url":"https://api.github.com/users/jameinel/gists{/gist_id}","starred_url":"https://api.github.com/users/jameinel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jameinel/subscriptions","organizations_url":"https://api.github.com/users/jameinel/orgs","repos_url":"https://api.github.com/users/jameinel/repos","events_url":"https://api.github.com/users/jameinel/events{/privacy}","received_events_url":"https://api.github.com/users/jameinel/received_events","type":"User","site_admin":false},"body":"It is certainly the type of thing that you sort of like \"friend\" for in C++. We want to expose some private functionality, without making it open to everyone in the world.\r\nI wonder if we can find a better paradigm for us in the Go world. Maybe something like \"state.Internal()\" which returns an interface that exposes all the internal gory bits but makes it clear that this is just for helpers that want to get around the abstraction. (we need it for the update transactions stuff, and for backup, etc, but 90% of our code should never touch it.) ","created_at":"2014-06-18T06:59:33Z","updated_at":"2014-06-18T06:59:33Z","html_url":"https://github.com/juju/juju/pull/114#discussion_r13901705","pull_request_url":"https://api.github.com/repos/juju/juju/pulls/114","_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/comments/13901705"},"html":{"href":"https://github.com/juju/juju/pull/114#discussion_r13901705"},"pull_request":{"href":"https://api.github.com/repos/juju/juju/pulls/114"}}},"pull_request":{"url":"https://api.github.com/repos/juju/juju/pulls/114","id":17249830,"html_url":"https://github.com/juju/juju/pull/114","diff_url":"https://github.com/juju/juju/pull/114.diff","patch_url":"https://github.com/juju/juju/pull/114.patch","issue_url":"https://api.github.com/repos/juju/juju/issues/114","number":114,"state":"open","title":"Download backup","user":{"login":"voidspace","id":127179,"avatar_url":"https://avatars.githubusercontent.com/u/127179?","gravatar_id":"463a381eaf9c0c08bc130a1bea1874ee","url":"https://api.github.com/users/voidspace","html_url":"https://github.com/voidspace","followers_url":"https://api.github.com/users/voidspace/followers","following_url":"https://api.github.com/users/voidspace/following{/other_user}","gists_url":"https://api.github.com/users/voidspace/gists{/gist_id}","starred_url":"https://api.github.com/users/voidspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voidspace/subscriptions","organizations_url":"https://api.github.com/users/voidspace/orgs","repos_url":"https://api.github.com/users/voidspace/repos","events_url":"https://api.github.com/users/voidspace/events{/privacy}","received_events_url":"https://api.github.com/users/voidspace/received_events","type":"User","site_admin":false},"body":"apiserver/backup: api endpoint for downloading a backup","created_at":"2014-06-17T17:33:44Z","updated_at":"2014-06-18T06:59:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b4a33dc850d2b1840d7077ad970779238b97e279","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/juju/juju/pulls/114/commits","review_comments_url":"https://api.github.com/repos/juju/juju/pulls/114/comments","review_comment_url":"https://api.github.com/repos/juju/juju/pulls/comments/{number}","comments_url":"https://api.github.com/repos/juju/juju/issues/114/comments","statuses_url":"https://api.github.com/repos/juju/juju/statuses/59f1a1718d34bec09d59dfa2c4d0f9af3e9d4cb8","head":{"label":"voidspace:download-backup","ref":"download-backup","sha":"59f1a1718d34bec09d59dfa2c4d0f9af3e9d4cb8","user":{"login":"voidspace","id":127179,"avatar_url":"https://avatars.githubusercontent.com/u/127179?","gravatar_id":"463a381eaf9c0c08bc130a1bea1874ee","url":"https://api.github.com/users/voidspace","html_url":"https://github.com/voidspace","followers_url":"https://api.github.com/users/voidspace/followers","following_url":"https://api.github.com/users/voidspace/following{/other_user}","gists_url":"https://api.github.com/users/voidspace/gists{/gist_id}","starred_url":"https://api.github.com/users/voidspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voidspace/subscriptions","organizations_url":"https://api.github.com/users/voidspace/orgs","repos_url":"https://api.github.com/users/voidspace/repos","events_url":"https://api.github.com/users/voidspace/events{/privacy}","received_events_url":"https://api.github.com/users/voidspace/received_events","type":"User","site_admin":false},"repo":{"id":20479498,"name":"juju","full_name":"voidspace/juju","owner":{"login":"voidspace","id":127179,"avatar_url":"https://avatars.githubusercontent.com/u/127179?","gravatar_id":"463a381eaf9c0c08bc130a1bea1874ee","url":"https://api.github.com/users/voidspace","html_url":"https://github.com/voidspace","followers_url":"https://api.github.com/users/voidspace/followers","following_url":"https://api.github.com/users/voidspace/following{/other_user}","gists_url":"https://api.github.com/users/voidspace/gists{/gist_id}","starred_url":"https://api.github.com/users/voidspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voidspace/subscriptions","organizations_url":"https://api.github.com/users/voidspace/orgs","repos_url":"https://api.github.com/users/voidspace/repos","events_url":"https://api.github.com/users/voidspace/events{/privacy}","received_events_url":"https://api.github.com/users/voidspace/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/voidspace/juju","description":"juju is devops distilled","fork":true,"url":"https://api.github.com/repos/voidspace/juju","forks_url":"https://api.github.com/repos/voidspace/juju/forks","keys_url":"https://api.github.com/repos/voidspace/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/voidspace/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/voidspace/juju/teams","hooks_url":"https://api.github.com/repos/voidspace/juju/hooks","issue_events_url":"https://api.github.com/repos/voidspace/juju/issues/events{/number}","events_url":"https://api.github.com/repos/voidspace/juju/events","assignees_url":"https://api.github.com/repos/voidspace/juju/assignees{/user}","branches_url":"https://api.github.com/repos/voidspace/juju/branches{/branch}","tags_url":"https://api.github.com/repos/voidspace/juju/tags","blobs_url":"https://api.github.com/repos/voidspace/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/voidspace/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/voidspace/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/voidspace/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/voidspace/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/voidspace/juju/languages","stargazers_url":"https://api.github.com/repos/voidspace/juju/stargazers","contributors_url":"https://api.github.com/repos/voidspace/juju/contributors","subscribers_url":"https://api.github.com/repos/voidspace/juju/subscribers","subscription_url":"https://api.github.com/repos/voidspace/juju/subscription","commits_url":"https://api.github.com/repos/voidspace/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/voidspace/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/voidspace/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/voidspace/juju/issues/comments/{number}","contents_url":"https://api.github.com/repos/voidspace/juju/contents/{+path}","compare_url":"https://api.github.com/repos/voidspace/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/voidspace/juju/merges","archive_url":"https://api.github.com/repos/voidspace/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/voidspace/juju/downloads","issues_url":"https://api.github.com/repos/voidspace/juju/issues{/number}","pulls_url":"https://api.github.com/repos/voidspace/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/voidspace/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/voidspace/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/voidspace/juju/labels{/name}","releases_url":"https://api.github.com/repos/voidspace/juju/releases{/id}","created_at":"2014-06-04T10:41:57Z","updated_at":"2014-06-17T17:33:44Z","pushed_at":"2014-06-17T17:33:13Z","git_url":"git://github.com/voidspace/juju.git","ssh_url":"git@github.com:voidspace/juju.git","clone_url":"https://github.com/voidspace/juju.git","svn_url":"https://github.com/voidspace/juju","homepage":null,"size":23626,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"juju:master","ref":"master","sha":"348c104d4e160efa00a1640e8304237548ed7a2e","user":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?","gravatar_id":"b095d1e26e5705abe0ad2de7d87aac2e","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"repo":{"id":20445947,"name":"juju","full_name":"juju/juju","owner":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?","gravatar_id":"b095d1e26e5705abe0ad2de7d87aac2e","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju/juju","description":"juju is devops distilled","fork":false,"url":"https://api.github.com/repos/juju/juju","forks_url":"https://api.github.com/repos/juju/juju/forks","keys_url":"https://api.github.com/repos/juju/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju/juju/teams","hooks_url":"https://api.github.com/repos/juju/juju/hooks","issue_events_url":"https://api.github.com/repos/juju/juju/issues/events{/number}","events_url":"https://api.github.com/repos/juju/juju/events","assignees_url":"https://api.github.com/repos/juju/juju/assignees{/user}","branches_url":"https://api.github.com/repos/juju/juju/branches{/branch}","tags_url":"https://api.github.com/repos/juju/juju/tags","blobs_url":"https://api.github.com/repos/juju/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/juju/juju/languages","stargazers_url":"https://api.github.com/repos/juju/juju/stargazers","contributors_url":"https://api.github.com/repos/juju/juju/contributors","subscribers_url":"https://api.github.com/repos/juju/juju/subscribers","subscription_url":"https://api.github.com/repos/juju/juju/subscription","commits_url":"https://api.github.com/repos/juju/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju/juju/issues/comments/{number}","contents_url":"https://api.github.com/repos/juju/juju/contents/{+path}","compare_url":"https://api.github.com/repos/juju/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju/juju/merges","archive_url":"https://api.github.com/repos/juju/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju/juju/downloads","issues_url":"https://api.github.com/repos/juju/juju/issues{/number}","pulls_url":"https://api.github.com/repos/juju/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/juju/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/juju/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju/juju/labels{/name}","releases_url":"https://api.github.com/repos/juju/juju/releases{/id}","created_at":"2014-06-03T14:28:10Z","updated_at":"2014-06-18T06:02:01Z","pushed_at":"2014-06-18T06:02:01Z","git_url":"git://github.com/juju/juju.git","ssh_url":"git@github.com:juju/juju.git","clone_url":"https://github.com/juju/juju.git","svn_url":"https://github.com/juju/juju","homepage":"juju.ubuntu.com","size":26155,"stargazers_count":155,"watchers_count":155,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":37,"mirror_url":null,"open_issues_count":20,"forks":37,"open_issues":20,"watchers":155,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/114"},"html":{"href":"https://github.com/juju/juju/pull/114"},"issue":{"href":"https://api.github.com/repos/juju/juju/issues/114"},"comments":{"href":"https://api.github.com/repos/juju/juju/issues/114/comments"},"review_comments":{"href":"https://api.github.com/repos/juju/juju/pulls/114/comments"},"review_comment":{"href":"https://api.github.com/repos/juju/juju/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/juju/juju/pulls/114/commits"},"statuses":{"href":"https://api.github.com/repos/juju/juju/statuses/59f1a1718d34bec09d59dfa2c4d0f9af3e9d4cb8"}}}}