GitHub PullRequestReviewCommentEvent at 2014-10-21 21:03:25
Repository: HoTT
Actor: andrejbauer
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/HoTT/HoTT/pulls/comments/19179060","id":19179060,"diff_hunk":"@@ -13,91 +13,85 @@ Local Arguments compose / .\n (** ** Unit Subuniverses *)\n \n (** A UnitSubuniverse is the common underlying structure of a reflective subuniverse and a modality.  We make it a separate structure in order to use the same names for its fields and functions in the two cases. *)\n-Class UnitSubuniverse :=\n+Record UnitSubuniverse :=\n   {\n     inO_internal : Type -> Type ;\n-    O : Type -> Type ;\n-    O_inO_internal : forall T, inO_internal (O T) ;\n-    O_unit : forall T, T -> O T ;\n+    O_reflector : Type -> Type ;\n+    O_inO_internal : forall T, inO_internal (O_reflector T) ;\n+    to : forall T, T -> O_reflector T ;","path":"theories/ReflectiveSubuniverse.v","position":13,"original_position":13,"commit_id":"b9b254121ff1537876ed1ea23a64e4508df999ee","original_commit_id":"cb3bfffe8180e2e32d8d91a81222451f1f874040","user":{"login":"andrejbauer","id":646599,"avatar_url":"https://avatars.githubusercontent.com/u/646599?v=2","gravatar_id":"","url":"https://api.github.com/users/andrejbauer","html_url":"https://github.com/andrejbauer","followers_url":"https://api.github.com/users/andrejbauer/followers","following_url":"https://api.github.com/users/andrejbauer/following{/other_user}","gists_url":"https://api.github.com/users/andrejbauer/gists{/gist_id}","starred_url":"https://api.github.com/users/andrejbauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrejbauer/subscriptions","organizations_url":"https://api.github.com/users/andrejbauer/orgs","repos_url":"https://api.github.com/users/andrejbauer/repos","events_url":"https://api.github.com/users/andrejbauer/events{/privacy}","received_events_url":"https://api.github.com/users/andrejbauer/received_events","type":"User","site_admin":false},"body":"@JasonGross, I think Mike wants you to complain about every name whose length is 2 or less.","created_at":"2014-10-21T21:03:25Z","updated_at":"2014-10-21T21:03:25Z","html_url":"https://github.com/HoTT/HoTT/pull/585#discussion_r19179060","pull_request_url":"https://api.github.com/repos/HoTT/HoTT/pulls/585","_links":{"self":{"href":"https://api.github.com/repos/HoTT/HoTT/pulls/comments/19179060"},"html":{"href":"https://github.com/HoTT/HoTT/pull/585#discussion_r19179060"},"pull_request":{"href":"https://api.github.com/repos/HoTT/HoTT/pulls/585"}}},"pull_request":{"url":"https://api.github.com/repos/HoTT/HoTT/pulls/585","id":23064007,"html_url":"https://github.com/HoTT/HoTT/pull/585","diff_url":"https://github.com/HoTT/HoTT/pull/585.diff","patch_url":"https://github.com/HoTT/HoTT/pull/585.patch","issue_url":"https://api.github.com/repos/HoTT/HoTT/issues/585","number":585,"state":"open","locked":false,"title":"Use records, not typeclasses, for subuniverses and modalities","user":{"login":"mikeshulman","id":646600,"avatar_url":"https://avatars.githubusercontent.com/u/646600?v=2","gravatar_id":"","url":"https://api.github.com/users/mikeshulman","html_url":"https://github.com/mikeshulman","followers_url":"https://api.github.com/users/mikeshulman/followers","following_url":"https://api.github.com/users/mikeshulman/following{/other_user}","gists_url":"https://api.github.com/users/mikeshulman/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeshulman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeshulman/subscriptions","organizations_url":"https://api.github.com/users/mikeshulman/orgs","repos_url":"https://api.github.com/users/mikeshulman/repos","events_url":"https://api.github.com/users/mikeshulman/events{/privacy}","received_events_url":"https://api.github.com/users/mikeshulman/received_events","type":"User","site_admin":false},"body":"I have been working and thinking about these a lot and I've decided that my original idea of using typeclasses was probably not the best way: when there is more than one modality floating around then it's really better to be passing them explicitly.  This PR turns reflective subuniverses and modalities back into records.","created_at":"2014-10-21T05:56:15Z","updated_at":"2014-10-21T21:03:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3428ef40e6734db2549449cd63c548993c0b3bf3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/HoTT/HoTT/pulls/585/commits","review_comments_url":"https://api.github.com/repos/HoTT/HoTT/pulls/585/comments","review_comment_url":"https://api.github.com/repos/HoTT/HoTT/pulls/comments/{number}","comments_url":"https://api.github.com/repos/HoTT/HoTT/issues/585/comments","statuses_url":"https://api.github.com/repos/HoTT/HoTT/statuses/b9b254121ff1537876ed1ea23a64e4508df999ee","head":{"label":"mikeshulman:modalrecords","ref":"modalrecords","sha":"b9b254121ff1537876ed1ea23a64e4508df999ee","user":{"login":"mikeshulman","id":646600,"avatar_url":"https://avatars.githubusercontent.com/u/646600?v=2","gravatar_id":"","url":"https://api.github.com/users/mikeshulman","html_url":"https://github.com/mikeshulman","followers_url":"https://api.github.com/users/mikeshulman/followers","following_url":"https://api.github.com/users/mikeshulman/following{/other_user}","gists_url":"https://api.github.com/users/mikeshulman/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeshulman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeshulman/subscriptions","organizations_url":"https://api.github.com/users/mikeshulman/orgs","repos_url":"https://api.github.com/users/mikeshulman/repos","events_url":"https://api.github.com/users/mikeshulman/events{/privacy}","received_events_url":"https://api.github.com/users/mikeshulman/received_events","type":"User","site_admin":false},"repo":{"id":2769614,"name":"HoTT","full_name":"mikeshulman/HoTT","owner":{"login":"mikeshulman","id":646600,"avatar_url":"https://avatars.githubusercontent.com/u/646600?v=2","gravatar_id":"","url":"https://api.github.com/users/mikeshulman","html_url":"https://github.com/mikeshulman","followers_url":"https://api.github.com/users/mikeshulman/followers","following_url":"https://api.github.com/users/mikeshulman/following{/other_user}","gists_url":"https://api.github.com/users/mikeshulman/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeshulman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeshulman/subscriptions","organizations_url":"https://api.github.com/users/mikeshulman/orgs","repos_url":"https://api.github.com/users/mikeshulman/repos","events_url":"https://api.github.com/users/mikeshulman/events{/privacy}","received_events_url":"https://api.github.com/users/mikeshulman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mikeshulman/HoTT","description":"Homotopy type theory","fork":true,"url":"https://api.github.com/repos/mikeshulman/HoTT","forks_url":"https://api.github.com/repos/mikeshulman/HoTT/forks","keys_url":"https://api.github.com/repos/mikeshulman/HoTT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mikeshulman/HoTT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mikeshulman/HoTT/teams","hooks_url":"https://api.github.com/repos/mikeshulman/HoTT/hooks","issue_events_url":"https://api.github.com/repos/mikeshulman/HoTT/issues/events{/number}","events_url":"https://api.github.com/repos/mikeshulman/HoTT/events","assignees_url":"https://api.github.com/repos/mikeshulman/HoTT/assignees{/user}","branches_url":"https://api.github.com/repos/mikeshulman/HoTT/branches{/branch}","tags_url":"https://api.github.com/repos/mikeshulman/HoTT/tags","blobs_url":"https://api.github.com/repos/mikeshulman/HoTT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mikeshulman/HoTT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mikeshulman/HoTT/git/refs{/sha}","trees_url":"https://api.github.com/repos/mikeshulman/HoTT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mikeshulman/HoTT/statuses/{sha}","languages_url":"https://api.github.com/repos/mikeshulman/HoTT/languages","stargazers_url":"https://api.github.com/repos/mikeshulman/HoTT/stargazers","contributors_url":"https://api.github.com/repos/mikeshulman/HoTT/contributors","subscribers_url":"https://api.github.com/repos/mikeshulman/HoTT/subscribers","subscription_url":"https://api.github.com/repos/mikeshulman/HoTT/subscription","commits_url":"https://api.github.com/repos/mikeshulman/HoTT/commits{/sha}","git_commits_url":"https://api.github.com/repos/mikeshulman/HoTT/git/commits{/sha}","comments_url":"https://api.github.com/repos/mikeshulman/HoTT/comments{/number}","issue_comment_url":"https://api.github.com/repos/mikeshulman/HoTT/issues/comments/{number}","contents_url":"https://api.github.com/repos/mikeshulman/HoTT/contents/{+path}","compare_url":"https://api.github.com/repos/mikeshulman/HoTT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mikeshulman/HoTT/merges","archive_url":"https://api.github.com/repos/mikeshulman/HoTT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mikeshulman/HoTT/downloads","issues_url":"https://api.github.com/repos/mikeshulman/HoTT/issues{/number}","pulls_url":"https://api.github.com/repos/mikeshulman/HoTT/pulls{/number}","milestones_url":"https://api.github.com/repos/mikeshulman/HoTT/milestones{/number}","notifications_url":"https://api.github.com/repos/mikeshulman/HoTT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mikeshulman/HoTT/labels{/name}","releases_url":"https://api.github.com/repos/mikeshulman/HoTT/releases{/id}","created_at":"2011-11-14T02:23:07Z","updated_at":"2014-08-25T17:18:56Z","pushed_at":"2014-10-21T20:27:53Z","git_url":"git://github.com/mikeshulman/HoTT.git","ssh_url":"git@github.com:mikeshulman/HoTT.git","clone_url":"https://github.com/mikeshulman/HoTT.git","svn_url":"https://github.com/mikeshulman/HoTT","homepage":"http://homotopytypetheory.org/","size":7447,"stargazers_count":7,"watchers_count":7,"language":"Coq","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":7,"default_branch":"master"}},"base":{"label":"HoTT:master","ref":"master","sha":"89a10b9294e31504b68c7645a9e232f1c05ed2cb","user":{"login":"HoTT","id":692156,"avatar_url":"https://avatars.githubusercontent.com/u/692156?v=2","gravatar_id":"","url":"https://api.github.com/users/HoTT","html_url":"https://github.com/HoTT","followers_url":"https://api.github.com/users/HoTT/followers","following_url":"https://api.github.com/users/HoTT/following{/other_user}","gists_url":"https://api.github.com/users/HoTT/gists{/gist_id}","starred_url":"https://api.github.com/users/HoTT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HoTT/subscriptions","organizations_url":"https://api.github.com/users/HoTT/orgs","repos_url":"https://api.github.com/users/HoTT/repos","events_url":"https://api.github.com/users/HoTT/events{/privacy}","received_events_url":"https://api.github.com/users/HoTT/received_events","type":"Organization","site_admin":false},"repo":{"id":1529601,"name":"HoTT","full_name":"HoTT/HoTT","owner":{"login":"HoTT","id":692156,"avatar_url":"https://avatars.githubusercontent.com/u/692156?v=2","gravatar_id":"","url":"https://api.github.com/users/HoTT","html_url":"https://github.com/HoTT","followers_url":"https://api.github.com/users/HoTT/followers","following_url":"https://api.github.com/users/HoTT/following{/other_user}","gists_url":"https://api.github.com/users/HoTT/gists{/gist_id}","starred_url":"https://api.github.com/users/HoTT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HoTT/subscriptions","organizations_url":"https://api.github.com/users/HoTT/orgs","repos_url":"https://api.github.com/users/HoTT/repos","events_url":"https://api.github.com/users/HoTT/events{/privacy}","received_events_url":"https://api.github.com/users/HoTT/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HoTT/HoTT","description":"Homotopy type theory","fork":false,"url":"https://api.github.com/repos/HoTT/HoTT","forks_url":"https://api.github.com/repos/HoTT/HoTT/forks","keys_url":"https://api.github.com/repos/HoTT/HoTT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HoTT/HoTT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HoTT/HoTT/teams","hooks_url":"https://api.github.com/repos/HoTT/HoTT/hooks","issue_events_url":"https://api.github.com/repos/HoTT/HoTT/issues/events{/number}","events_url":"https://api.github.com/repos/HoTT/HoTT/events","assignees_url":"https://api.github.com/repos/HoTT/HoTT/assignees{/user}","branches_url":"https://api.github.com/repos/HoTT/HoTT/branches{/branch}","tags_url":"https://api.github.com/repos/HoTT/HoTT/tags","blobs_url":"https://api.github.com/repos/HoTT/HoTT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HoTT/HoTT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HoTT/HoTT/git/refs{/sha}","trees_url":"https://api.github.com/repos/HoTT/HoTT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HoTT/HoTT/statuses/{sha}","languages_url":"https://api.github.com/repos/HoTT/HoTT/languages","stargazers_url":"https://api.github.com/repos/HoTT/HoTT/stargazers","contributors_url":"https://api.github.com/repos/HoTT/HoTT/contributors","subscribers_url":"https://api.github.com/repos/HoTT/HoTT/subscribers","subscription_url":"https://api.github.com/repos/HoTT/HoTT/subscription","commits_url":"https://api.github.com/repos/HoTT/HoTT/commits{/sha}","git_commits_url":"https://api.github.com/repos/HoTT/HoTT/git/commits{/sha}","comments_url":"https://api.github.com/repos/HoTT/HoTT/comments{/number}","issue_comment_url":"https://api.github.com/repos/HoTT/HoTT/issues/comments/{number}","contents_url":"https://api.github.com/repos/HoTT/HoTT/contents/{+path}","compare_url":"https://api.github.com/repos/HoTT/HoTT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HoTT/HoTT/merges","archive_url":"https://api.github.com/repos/HoTT/HoTT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HoTT/HoTT/downloads","issues_url":"https://api.github.com/repos/HoTT/HoTT/issues{/number}","pulls_url":"https://api.github.com/repos/HoTT/HoTT/pulls{/number}","milestones_url":"https://api.github.com/repos/HoTT/HoTT/milestones{/number}","notifications_url":"https://api.github.com/repos/HoTT/HoTT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HoTT/HoTT/labels{/name}","releases_url":"https://api.github.com/repos/HoTT/HoTT/releases{/id}","created_at":"2011-03-26T15:59:20Z","updated_at":"2014-10-21T14:22:25Z","pushed_at":"2014-10-21T20:27:50Z","git_url":"git://github.com/HoTT/HoTT.git","ssh_url":"git@github.com:HoTT/HoTT.git","clone_url":"https://github.com/HoTT/HoTT.git","svn_url":"https://github.com/HoTT/HoTT","homepage":"http://homotopytypetheory.org/","size":108726,"stargazers_count":229,"watchers_count":229,"language":"Coq","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":50,"mirror_url":null,"open_issues_count":60,"forks":50,"open_issues":60,"watchers":229,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HoTT/HoTT/pulls/585"},"html":{"href":"https://github.com/HoTT/HoTT/pull/585"},"issue":{"href":"https://api.github.com/repos/HoTT/HoTT/issues/585"},"comments":{"href":"https://api.github.com/repos/HoTT/HoTT/issues/585/comments"},"review_comments":{"href":"https://api.github.com/repos/HoTT/HoTT/pulls/585/comments"},"review_comment":{"href":"https://api.github.com/repos/HoTT/HoTT/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/HoTT/HoTT/pulls/585/commits"},"statuses":{"href":"https://api.github.com/repos/HoTT/HoTT/statuses/b9b254121ff1537876ed1ea23a64e4508df999ee"}}}}