GitHub PullRequestReviewCommentEvent at 2014-06-09 21:12:23
Repository: qonos
Actor: komawar
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/rackerlabs/qonos/pulls/comments/13565169","id":13565169,"diff_hunk":"@@ -104,7 +107,9 @@ def process_job(self, job):\n \n         job_id = job['id']\n \n-        if not self._check_schedule_exists(job):\n+        schedule = self._get_schedule(job)\n+        LOG.debug(\"Schedule: %s\" % str(schedule))","path":"qonos/worker/snapshot/snapshot.py","position":16,"original_position":16,"commit_id":"9b3a84afcf0cf1e2b88d2a60781697abb205bcd0","original_commit_id":"9b3a84afcf0cf1e2b88d2a60781697abb205bcd0","user":{"login":"komawar","id":1414265,"avatar_url":"https://avatars.githubusercontent.com/u/1414265?","gravatar_id":"da2f09f5a90e624475684a126d4f2b9d","url":"https://api.github.com/users/komawar","html_url":"https://github.com/komawar","followers_url":"https://api.github.com/users/komawar/followers","following_url":"https://api.github.com/users/komawar/following{/other_user}","gists_url":"https://api.github.com/users/komawar/gists{/gist_id}","starred_url":"https://api.github.com/users/komawar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/komawar/subscriptions","organizations_url":"https://api.github.com/users/komawar/orgs","repos_url":"https://api.github.com/users/komawar/repos","events_url":"https://api.github.com/users/komawar/events{/privacy}","received_events_url":"https://api.github.com/users/komawar/received_events","type":"User","site_admin":false},"body":"Do you mind adding a bit more info about when this schedule was retrieved? Seems like if we are getting a None schedule then the LOG would print it as None however, we would have hard time figuring out at what point we got it as None. (At least for dev/ops who are not familiar with the code).","created_at":"2014-06-09T21:12:23Z","updated_at":"2014-06-09T21:12:23Z","html_url":"https://github.com/rackerlabs/qonos/pull/310#discussion_r13565169","pull_request_url":"https://api.github.com/repos/rackerlabs/qonos/pulls/310","_links":{"self":{"href":"https://api.github.com/repos/rackerlabs/qonos/pulls/comments/13565169"},"html":{"href":"https://github.com/rackerlabs/qonos/pull/310#discussion_r13565169"},"pull_request":{"href":"https://api.github.com/repos/rackerlabs/qonos/pulls/310"}}},"pull_request":{"url":"https://api.github.com/repos/rackerlabs/qonos/pulls/310","id":16294948,"html_url":"https://github.com/rackerlabs/qonos/pull/310","diff_url":"https://github.com/rackerlabs/qonos/pull/310.diff","patch_url":"https://github.com/rackerlabs/qonos/pull/310.patch","issue_url":"https://api.github.com/repos/rackerlabs/qonos/issues/310","number":310,"state":"open","title":"Name snapshots based on the type of schedule","user":{"login":"esheffield","id":897327,"avatar_url":"https://avatars.githubusercontent.com/u/897327?","gravatar_id":"62f9dd1222167af4373358f4aa36ce61","url":"https://api.github.com/users/esheffield","html_url":"https://github.com/esheffield","followers_url":"https://api.github.com/users/esheffield/followers","following_url":"https://api.github.com/users/esheffield/following{/other_user}","gists_url":"https://api.github.com/users/esheffield/gists{/gist_id}","starred_url":"https://api.github.com/users/esheffield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esheffield/subscriptions","organizations_url":"https://api.github.com/users/esheffield/orgs","repos_url":"https://api.github.com/users/esheffield/repos","events_url":"https://api.github.com/users/esheffield/events{/privacy}","received_events_url":"https://api.github.com/users/esheffield/received_events","type":"User","site_admin":false},"body":"Add support for naming imagess appropriately depending on if\r\nthe schedule is for a daily or a weekly snapshot.\r\n\r\nRemoved a couple of functional tests that weren't really functional and were redundant with similar unit tests.","created_at":"2014-05-23T21:11:21Z","updated_at":"2014-06-09T21:12:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"410521f95963bd21d9f945f43ef96ae07d7ff6e2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rackerlabs/qonos/pulls/310/commits","review_comments_url":"https://api.github.com/repos/rackerlabs/qonos/pulls/310/comments","review_comment_url":"https://api.github.com/repos/rackerlabs/qonos/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rackerlabs/qonos/issues/310/comments","statuses_url":"https://api.github.com/repos/rackerlabs/qonos/statuses/9b3a84afcf0cf1e2b88d2a60781697abb205bcd0","head":{"label":"rackerlabs:name-based-on-schedule-type","ref":"name-based-on-schedule-type","sha":"9b3a84afcf0cf1e2b88d2a60781697abb205bcd0","user":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?","gravatar_id":"cc2ad66c312c32facaf25a69bc6779cb","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":7528992,"name":"qonos","full_name":"rackerlabs/qonos","owner":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?","gravatar_id":"cc2ad66c312c32facaf25a69bc6779cb","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rackerlabs/qonos","description":"send_job_update","fork":false,"url":"https://api.github.com/repos/rackerlabs/qonos","forks_url":"https://api.github.com/repos/rackerlabs/qonos/forks","keys_url":"https://api.github.com/repos/rackerlabs/qonos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rackerlabs/qonos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rackerlabs/qonos/teams","hooks_url":"https://api.github.com/repos/rackerlabs/qonos/hooks","issue_events_url":"https://api.github.com/repos/rackerlabs/qonos/issues/events{/number}","events_url":"https://api.github.com/repos/rackerlabs/qonos/events","assignees_url":"https://api.github.com/repos/rackerlabs/qonos/assignees{/user}","branches_url":"https://api.github.com/repos/rackerlabs/qonos/branches{/branch}","tags_url":"https://api.github.com/repos/rackerlabs/qonos/tags","blobs_url":"https://api.github.com/repos/rackerlabs/qonos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rackerlabs/qonos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rackerlabs/qonos/git/refs{/sha}","trees_url":"https://api.github.com/repos/rackerlabs/qonos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rackerlabs/qonos/statuses/{sha}","languages_url":"https://api.github.com/repos/rackerlabs/qonos/languages","stargazers_url":"https://api.github.com/repos/rackerlabs/qonos/stargazers","contributors_url":"https://api.github.com/repos/rackerlabs/qonos/contributors","subscribers_url":"https://api.github.com/repos/rackerlabs/qonos/subscribers","subscription_url":"https://api.github.com/repos/rackerlabs/qonos/subscription","commits_url":"https://api.github.com/repos/rackerlabs/qonos/commits{/sha}","git_commits_url":"https://api.github.com/repos/rackerlabs/qonos/git/commits{/sha}","comments_url":"https://api.github.com/repos/rackerlabs/qonos/comments{/number}","issue_comment_url":"https://api.github.com/repos/rackerlabs/qonos/issues/comments/{number}","contents_url":"https://api.github.com/repos/rackerlabs/qonos/contents/{+path}","compare_url":"https://api.github.com/repos/rackerlabs/qonos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rackerlabs/qonos/merges","archive_url":"https://api.github.com/repos/rackerlabs/qonos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rackerlabs/qonos/downloads","issues_url":"https://api.github.com/repos/rackerlabs/qonos/issues{/number}","pulls_url":"https://api.github.com/repos/rackerlabs/qonos/pulls{/number}","milestones_url":"https://api.github.com/repos/rackerlabs/qonos/milestones{/number}","notifications_url":"https://api.github.com/repos/rackerlabs/qonos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rackerlabs/qonos/labels{/name}","releases_url":"https://api.github.com/repos/rackerlabs/qonos/releases{/id}","created_at":"2013-01-09T21:06:50Z","updated_at":"2014-06-09T18:37:46Z","pushed_at":"2014-06-09T18:37:47Z","git_url":"git://github.com/rackerlabs/qonos.git","ssh_url":"git@github.com:rackerlabs/qonos.git","clone_url":"https://github.com/rackerlabs/qonos.git","svn_url":"https://github.com/rackerlabs/qonos","homepage":"","size":3011,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":15,"mirror_url":null,"open_issues_count":48,"forks":15,"open_issues":48,"watchers":4,"default_branch":"master"}},"base":{"label":"rackerlabs:master","ref":"master","sha":"fe4331998ed388b758db72a3b1333d8db0652bcf","user":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?","gravatar_id":"cc2ad66c312c32facaf25a69bc6779cb","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":7528992,"name":"qonos","full_name":"rackerlabs/qonos","owner":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?","gravatar_id":"cc2ad66c312c32facaf25a69bc6779cb","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rackerlabs/qonos","description":"send_job_update","fork":false,"url":"https://api.github.com/repos/rackerlabs/qonos","forks_url":"https://api.github.com/repos/rackerlabs/qonos/forks","keys_url":"https://api.github.com/repos/rackerlabs/qonos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rackerlabs/qonos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rackerlabs/qonos/teams","hooks_url":"https://api.github.com/repos/rackerlabs/qonos/hooks","issue_events_url":"https://api.github.com/repos/rackerlabs/qonos/issues/events{/number}","events_url":"https://api.github.com/repos/rackerlabs/qonos/events","assignees_url":"https://api.github.com/repos/rackerlabs/qonos/assignees{/user}","branches_url":"https://api.github.com/repos/rackerlabs/qonos/branches{/branch}","tags_url":"https://api.github.com/repos/rackerlabs/qonos/tags","blobs_url":"https://api.github.com/repos/rackerlabs/qonos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rackerlabs/qonos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rackerlabs/qonos/git/refs{/sha}","trees_url":"https://api.github.com/repos/rackerlabs/qonos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rackerlabs/qonos/statuses/{sha}","languages_url":"https://api.github.com/repos/rackerlabs/qonos/languages","stargazers_url":"https://api.github.com/repos/rackerlabs/qonos/stargazers","contributors_url":"https://api.github.com/repos/rackerlabs/qonos/contributors","subscribers_url":"https://api.github.com/repos/rackerlabs/qonos/subscribers","subscription_url":"https://api.github.com/repos/rackerlabs/qonos/subscription","commits_url":"https://api.github.com/repos/rackerlabs/qonos/commits{/sha}","git_commits_url":"https://api.github.com/repos/rackerlabs/qonos/git/commits{/sha}","comments_url":"https://api.github.com/repos/rackerlabs/qonos/comments{/number}","issue_comment_url":"https://api.github.com/repos/rackerlabs/qonos/issues/comments/{number}","contents_url":"https://api.github.com/repos/rackerlabs/qonos/contents/{+path}","compare_url":"https://api.github.com/repos/rackerlabs/qonos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rackerlabs/qonos/merges","archive_url":"https://api.github.com/repos/rackerlabs/qonos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rackerlabs/qonos/downloads","issues_url":"https://api.github.com/repos/rackerlabs/qonos/issues{/number}","pulls_url":"https://api.github.com/repos/rackerlabs/qonos/pulls{/number}","milestones_url":"https://api.github.com/repos/rackerlabs/qonos/milestones{/number}","notifications_url":"https://api.github.com/repos/rackerlabs/qonos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rackerlabs/qonos/labels{/name}","releases_url":"https://api.github.com/repos/rackerlabs/qonos/releases{/id}","created_at":"2013-01-09T21:06:50Z","updated_at":"2014-06-09T18:37:46Z","pushed_at":"2014-06-09T18:37:47Z","git_url":"git://github.com/rackerlabs/qonos.git","ssh_url":"git@github.com:rackerlabs/qonos.git","clone_url":"https://github.com/rackerlabs/qonos.git","svn_url":"https://github.com/rackerlabs/qonos","homepage":"","size":3011,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":15,"mirror_url":null,"open_issues_count":48,"forks":15,"open_issues":48,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rackerlabs/qonos/pulls/310"},"html":{"href":"https://github.com/rackerlabs/qonos/pull/310"},"issue":{"href":"https://api.github.com/repos/rackerlabs/qonos/issues/310"},"comments":{"href":"https://api.github.com/repos/rackerlabs/qonos/issues/310/comments"},"review_comments":{"href":"https://api.github.com/repos/rackerlabs/qonos/pulls/310/comments"},"review_comment":{"href":"https://api.github.com/repos/rackerlabs/qonos/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rackerlabs/qonos/pulls/310/commits"},"statuses":{"href":"https://api.github.com/repos/rackerlabs/qonos/statuses/9b3a84afcf0cf1e2b88d2a60781697abb205bcd0"}}}}