GitHub PullRequestReviewCommentEvent at 2014-08-28 19:10:38
Repository: method
Actor: tsanko
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/volusion-angular-themes/method/pulls/comments/16861282","id":16861282,"diff_hunk":"@@ -402,12 +413,14 @@ angular.module('Volusion.controllers')\n \n                 Cart.saveCart($scope.cartItem)\n                     .then(function (response) {\n+\n                         $scope.cartItem.qty = 0;\n-                        displayCartMessages(response.data);\n+                        displaySuccess();\n+                        displayWarnings(response.data.warnings);","path":"app/scripts/controllers/product.js","position":63,"original_position":63,"commit_id":"09a3d57af4cdb83f84340d2ab6dba387e418682e","original_commit_id":"09a3d57af4cdb83f84340d2ab6dba387e418682e","user":{"login":"tsanko","id":2973530,"avatar_url":"https://avatars.githubusercontent.com/u/2973530?v=2","gravatar_id":"f15988de887702fd12d2cf74cdc0b86d","url":"https://api.github.com/users/tsanko","html_url":"https://github.com/tsanko","followers_url":"https://api.github.com/users/tsanko/followers","following_url":"https://api.github.com/users/tsanko/following{/other_user}","gists_url":"https://api.github.com/users/tsanko/gists{/gist_id}","starred_url":"https://api.github.com/users/tsanko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsanko/subscriptions","organizations_url":"https://api.github.com/users/tsanko/orgs","repos_url":"https://api.github.com/users/tsanko/repos","events_url":"https://api.github.com/users/tsanko/events{/privacy}","received_events_url":"https://api.github.com/users/tsanko/received_events","type":"User","site_admin":false},"body":"saveCart will return cart obj .... so \"response\" will not have \"data\" ... I will suggest rename param to \"cart\" and pass \"cart.warnings\"","created_at":"2014-08-28T19:10:38Z","updated_at":"2014-08-28T19:10:38Z","html_url":"https://github.com/volusion-angular-themes/method/pull/125#discussion_r16861282","pull_request_url":"https://api.github.com/repos/volusion-angular-themes/method/pulls/125","_links":{"self":{"href":"https://api.github.com/repos/volusion-angular-themes/method/pulls/comments/16861282"},"html":{"href":"https://github.com/volusion-angular-themes/method/pull/125#discussion_r16861282"},"pull_request":{"href":"https://api.github.com/repos/volusion-angular-themes/method/pulls/125"}}},"pull_request":{"url":"https://api.github.com/repos/volusion-angular-themes/method/pulls/125","id":20458230,"html_url":"https://github.com/volusion-angular-themes/method/pull/125","diff_url":"https://github.com/volusion-angular-themes/method/pull/125.diff","patch_url":"https://github.com/volusion-angular-themes/method/pull/125.patch","issue_url":"https://api.github.com/repos/volusion-angular-themes/method/issues/125","number":125,"state":"open","locked":false,"title":"Refactored and fixes issue with cart messaging","user":{"login":"prabinv","id":306468,"avatar_url":"https://avatars.githubusercontent.com/u/306468?v=2","gravatar_id":"73fc185bb8b196aaaa661dd7fb80fac5","url":"https://api.github.com/users/prabinv","html_url":"https://github.com/prabinv","followers_url":"https://api.github.com/users/prabinv/followers","following_url":"https://api.github.com/users/prabinv/following{/other_user}","gists_url":"https://api.github.com/users/prabinv/gists{/gist_id}","starred_url":"https://api.github.com/users/prabinv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prabinv/subscriptions","organizations_url":"https://api.github.com/users/prabinv/orgs","repos_url":"https://api.github.com/users/prabinv/repos","events_url":"https://api.github.com/users/prabinv/events{/privacy}","received_events_url":"https://api.github.com/users/prabinv/received_events","type":"User","site_admin":false},"body":"@tsanko made some refactoring changes and also fixed the issue with success message not shown. Please take a look and pull in.","created_at":"2014-08-28T18:40:29Z","updated_at":"2014-08-28T19:10:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6298684b96e8de665586e16b148521b9e556aa18","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/volusion-angular-themes/method/pulls/125/commits","review_comments_url":"https://api.github.com/repos/volusion-angular-themes/method/pulls/125/comments","review_comment_url":"https://api.github.com/repos/volusion-angular-themes/method/pulls/comments/{number}","comments_url":"https://api.github.com/repos/volusion-angular-themes/method/issues/125/comments","statuses_url":"https://api.github.com/repos/volusion-angular-themes/method/statuses/09a3d57af4cdb83f84340d2ab6dba387e418682e","head":{"label":"prabinv:CartErrorsRefactor","ref":"CartErrorsRefactor","sha":"09a3d57af4cdb83f84340d2ab6dba387e418682e","user":{"login":"prabinv","id":306468,"avatar_url":"https://avatars.githubusercontent.com/u/306468?v=2","gravatar_id":"73fc185bb8b196aaaa661dd7fb80fac5","url":"https://api.github.com/users/prabinv","html_url":"https://github.com/prabinv","followers_url":"https://api.github.com/users/prabinv/followers","following_url":"https://api.github.com/users/prabinv/following{/other_user}","gists_url":"https://api.github.com/users/prabinv/gists{/gist_id}","starred_url":"https://api.github.com/users/prabinv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prabinv/subscriptions","organizations_url":"https://api.github.com/users/prabinv/orgs","repos_url":"https://api.github.com/users/prabinv/repos","events_url":"https://api.github.com/users/prabinv/events{/privacy}","received_events_url":"https://api.github.com/users/prabinv/received_events","type":"User","site_admin":false},"repo":{"id":20808996,"name":"method","full_name":"prabinv/method","owner":{"login":"prabinv","id":306468,"avatar_url":"https://avatars.githubusercontent.com/u/306468?v=2","gravatar_id":"73fc185bb8b196aaaa661dd7fb80fac5","url":"https://api.github.com/users/prabinv","html_url":"https://github.com/prabinv","followers_url":"https://api.github.com/users/prabinv/followers","following_url":"https://api.github.com/users/prabinv/following{/other_user}","gists_url":"https://api.github.com/users/prabinv/gists{/gist_id}","starred_url":"https://api.github.com/users/prabinv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prabinv/subscriptions","organizations_url":"https://api.github.com/users/prabinv/orgs","repos_url":"https://api.github.com/users/prabinv/repos","events_url":"https://api.github.com/users/prabinv/events{/privacy}","received_events_url":"https://api.github.com/users/prabinv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/prabinv/method","description":"Volusion seed project for the AngularJS framework","fork":true,"url":"https://api.github.com/repos/prabinv/method","forks_url":"https://api.github.com/repos/prabinv/method/forks","keys_url":"https://api.github.com/repos/prabinv/method/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prabinv/method/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prabinv/method/teams","hooks_url":"https://api.github.com/repos/prabinv/method/hooks","issue_events_url":"https://api.github.com/repos/prabinv/method/issues/events{/number}","events_url":"https://api.github.com/repos/prabinv/method/events","assignees_url":"https://api.github.com/repos/prabinv/method/assignees{/user}","branches_url":"https://api.github.com/repos/prabinv/method/branches{/branch}","tags_url":"https://api.github.com/repos/prabinv/method/tags","blobs_url":"https://api.github.com/repos/prabinv/method/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prabinv/method/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prabinv/method/git/refs{/sha}","trees_url":"https://api.github.com/repos/prabinv/method/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prabinv/method/statuses/{sha}","languages_url":"https://api.github.com/repos/prabinv/method/languages","stargazers_url":"https://api.github.com/repos/prabinv/method/stargazers","contributors_url":"https://api.github.com/repos/prabinv/method/contributors","subscribers_url":"https://api.github.com/repos/prabinv/method/subscribers","subscription_url":"https://api.github.com/repos/prabinv/method/subscription","commits_url":"https://api.github.com/repos/prabinv/method/commits{/sha}","git_commits_url":"https://api.github.com/repos/prabinv/method/git/commits{/sha}","comments_url":"https://api.github.com/repos/prabinv/method/comments{/number}","issue_comment_url":"https://api.github.com/repos/prabinv/method/issues/comments/{number}","contents_url":"https://api.github.com/repos/prabinv/method/contents/{+path}","compare_url":"https://api.github.com/repos/prabinv/method/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prabinv/method/merges","archive_url":"https://api.github.com/repos/prabinv/method/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prabinv/method/downloads","issues_url":"https://api.github.com/repos/prabinv/method/issues{/number}","pulls_url":"https://api.github.com/repos/prabinv/method/pulls{/number}","milestones_url":"https://api.github.com/repos/prabinv/method/milestones{/number}","notifications_url":"https://api.github.com/repos/prabinv/method/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prabinv/method/labels{/name}","releases_url":"https://api.github.com/repos/prabinv/method/releases{/id}","created_at":"2014-06-13T15:39:11Z","updated_at":"2014-08-13T20:54:24Z","pushed_at":"2014-08-28T18:39:10Z","git_url":"git://github.com/prabinv/method.git","ssh_url":"git@github.com:prabinv/method.git","clone_url":"https://github.com/prabinv/method.git","svn_url":"https://github.com/prabinv/method","homepage":"","size":8901,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"volusion-angular-themes:master","ref":"master","sha":"73d64c45d84390289a89f474233279db8267f782","user":{"login":"volusion-angular-themes","id":7862908,"avatar_url":"https://avatars.githubusercontent.com/u/7862908?v=2","gravatar_id":null,"url":"https://api.github.com/users/volusion-angular-themes","html_url":"https://github.com/volusion-angular-themes","followers_url":"https://api.github.com/users/volusion-angular-themes/followers","following_url":"https://api.github.com/users/volusion-angular-themes/following{/other_user}","gists_url":"https://api.github.com/users/volusion-angular-themes/gists{/gist_id}","starred_url":"https://api.github.com/users/volusion-angular-themes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/volusion-angular-themes/subscriptions","organizations_url":"https://api.github.com/users/volusion-angular-themes/orgs","repos_url":"https://api.github.com/users/volusion-angular-themes/repos","events_url":"https://api.github.com/users/volusion-angular-themes/events{/privacy}","received_events_url":"https://api.github.com/users/volusion-angular-themes/received_events","type":"Organization","site_admin":false},"repo":{"id":20746401,"name":"method","full_name":"volusion-angular-themes/method","owner":{"login":"volusion-angular-themes","id":7862908,"avatar_url":"https://avatars.githubusercontent.com/u/7862908?v=2","gravatar_id":null,"url":"https://api.github.com/users/volusion-angular-themes","html_url":"https://github.com/volusion-angular-themes","followers_url":"https://api.github.com/users/volusion-angular-themes/followers","following_url":"https://api.github.com/users/volusion-angular-themes/following{/other_user}","gists_url":"https://api.github.com/users/volusion-angular-themes/gists{/gist_id}","starred_url":"https://api.github.com/users/volusion-angular-themes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/volusion-angular-themes/subscriptions","organizations_url":"https://api.github.com/users/volusion-angular-themes/orgs","repos_url":"https://api.github.com/users/volusion-angular-themes/repos","events_url":"https://api.github.com/users/volusion-angular-themes/events{/privacy}","received_events_url":"https://api.github.com/users/volusion-angular-themes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/volusion-angular-themes/method","description":"Volusion seed project for the AngularJS framework","fork":false,"url":"https://api.github.com/repos/volusion-angular-themes/method","forks_url":"https://api.github.com/repos/volusion-angular-themes/method/forks","keys_url":"https://api.github.com/repos/volusion-angular-themes/method/keys{/key_id}","collaborators_url":"https://api.github.com/repos/volusion-angular-themes/method/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/volusion-angular-themes/method/teams","hooks_url":"https://api.github.com/repos/volusion-angular-themes/method/hooks","issue_events_url":"https://api.github.com/repos/volusion-angular-themes/method/issues/events{/number}","events_url":"https://api.github.com/repos/volusion-angular-themes/method/events","assignees_url":"https://api.github.com/repos/volusion-angular-themes/method/assignees{/user}","branches_url":"https://api.github.com/repos/volusion-angular-themes/method/branches{/branch}","tags_url":"https://api.github.com/repos/volusion-angular-themes/method/tags","blobs_url":"https://api.github.com/repos/volusion-angular-themes/method/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/volusion-angular-themes/method/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/volusion-angular-themes/method/git/refs{/sha}","trees_url":"https://api.github.com/repos/volusion-angular-themes/method/git/trees{/sha}","statuses_url":"https://api.github.com/repos/volusion-angular-themes/method/statuses/{sha}","languages_url":"https://api.github.com/repos/volusion-angular-themes/method/languages","stargazers_url":"https://api.github.com/repos/volusion-angular-themes/method/stargazers","contributors_url":"https://api.github.com/repos/volusion-angular-themes/method/contributors","subscribers_url":"https://api.github.com/repos/volusion-angular-themes/method/subscribers","subscription_url":"https://api.github.com/repos/volusion-angular-themes/method/subscription","commits_url":"https://api.github.com/repos/volusion-angular-themes/method/commits{/sha}","git_commits_url":"https://api.github.com/repos/volusion-angular-themes/method/git/commits{/sha}","comments_url":"https://api.github.com/repos/volusion-angular-themes/method/comments{/number}","issue_comment_url":"https://api.github.com/repos/volusion-angular-themes/method/issues/comments/{number}","contents_url":"https://api.github.com/repos/volusion-angular-themes/method/contents/{+path}","compare_url":"https://api.github.com/repos/volusion-angular-themes/method/compare/{base}...{head}","merges_url":"https://api.github.com/repos/volusion-angular-themes/method/merges","archive_url":"https://api.github.com/repos/volusion-angular-themes/method/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/volusion-angular-themes/method/downloads","issues_url":"https://api.github.com/repos/volusion-angular-themes/method/issues{/number}","pulls_url":"https://api.github.com/repos/volusion-angular-themes/method/pulls{/number}","milestones_url":"https://api.github.com/repos/volusion-angular-themes/method/milestones{/number}","notifications_url":"https://api.github.com/repos/volusion-angular-themes/method/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/volusion-angular-themes/method/labels{/name}","releases_url":"https://api.github.com/repos/volusion-angular-themes/method/releases{/id}","created_at":"2014-06-11T22:22:47Z","updated_at":"2014-08-13T12:34:58Z","pushed_at":"2014-08-28T16:42:00Z","git_url":"git://github.com/volusion-angular-themes/method.git","ssh_url":"git@github.com:volusion-angular-themes/method.git","clone_url":"https://github.com/volusion-angular-themes/method.git","svn_url":"https://github.com/volusion-angular-themes/method","homepage":"","size":19516,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":14,"mirror_url":null,"open_issues_count":2,"forks":14,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/volusion-angular-themes/method/pulls/125"},"html":{"href":"https://github.com/volusion-angular-themes/method/pull/125"},"issue":{"href":"https://api.github.com/repos/volusion-angular-themes/method/issues/125"},"comments":{"href":"https://api.github.com/repos/volusion-angular-themes/method/issues/125/comments"},"review_comments":{"href":"https://api.github.com/repos/volusion-angular-themes/method/pulls/125/comments"},"review_comment":{"href":"https://api.github.com/repos/volusion-angular-themes/method/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/volusion-angular-themes/method/pulls/125/commits"},"statuses":{"href":"https://api.github.com/repos/volusion-angular-themes/method/statuses/09a3d57af4cdb83f84340d2ab6dba387e418682e"}}}}