GitHub PullRequestReviewCommentEvent at 2014-11-20 11:55:49
Repository: pip
Actor: dstufft
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/pypa/pip/pulls/comments/20640814","id":20640814,"diff_hunk":"@@ -6,6 +6,23 @@ set -x\n # our tests use.\n export LC_CTYPE=en_US.UTF-8\n \n+# We want to create the virtual environment here, but not actually run anything\n+tox --notest\n+\n+# If we have a VENDOR=no then we want to reinstall pip into the virtual\n+# environment without the vendor directory included as well as install the\n+# dependencies we need installed.\n+if [[ $VENDOR = \"no\" ]]; then\n+    .tox/$TOXENV/bin/pip install -r pip/_vendor/vendor.txt\n+    PIP_NO_VENDOR_FOR_DOWNSTREAM=1 .tox/$TOXENV/bin/pip install .","path":".travis/run.sh","position":12,"original_position":12,"commit_id":"01eee963c9c6bb3aa1f28e3f8bfc79ccb1703f23","original_commit_id":"01eee963c9c6bb3aa1f28e3f8bfc79ccb1703f23","user":{"login":"dstufft","id":145979,"avatar_url":"https://avatars.githubusercontent.com/u/145979?v=3","gravatar_id":"","url":"https://api.github.com/users/dstufft","html_url":"https://github.com/dstufft","followers_url":"https://api.github.com/users/dstufft/followers","following_url":"https://api.github.com/users/dstufft/following{/other_user}","gists_url":"https://api.github.com/users/dstufft/gists{/gist_id}","starred_url":"https://api.github.com/users/dstufft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dstufft/subscriptions","organizations_url":"https://api.github.com/users/dstufft/orgs","repos_url":"https://api.github.com/users/dstufft/repos","events_url":"https://api.github.com/users/dstufft/events{/privacy}","received_events_url":"https://api.github.com/users/dstufft/received_events","type":"User","site_admin":false},"body":"Yup.","created_at":"2014-11-20T11:55:49Z","updated_at":"2014-11-20T11:55:49Z","html_url":"https://github.com/pypa/pip/pull/2131#discussion_r20640814","pull_request_url":"https://api.github.com/repos/pypa/pip/pulls/2131","_links":{"self":{"href":"https://api.github.com/repos/pypa/pip/pulls/comments/20640814"},"html":{"href":"https://github.com/pypa/pip/pull/2131#discussion_r20640814"},"pull_request":{"href":"https://api.github.com/repos/pypa/pip/pulls/2131"}}},"pull_request":{"url":"https://api.github.com/repos/pypa/pip/pulls/2131","id":24743376,"html_url":"https://github.com/pypa/pip/pull/2131","diff_url":"https://github.com/pypa/pip/pull/2131.diff","patch_url":"https://github.com/pypa/pip/pull/2131.patch","issue_url":"https://api.github.com/repos/pypa/pip/issues/2131","number":2131,"state":"open","locked":false,"title":"Make debundling easier","user":{"login":"dstufft","id":145979,"avatar_url":"https://avatars.githubusercontent.com/u/145979?v=3","gravatar_id":"","url":"https://api.github.com/users/dstufft","html_url":"https://github.com/dstufft","followers_url":"https://api.github.com/users/dstufft/followers","following_url":"https://api.github.com/users/dstufft/following{/other_user}","gists_url":"https://api.github.com/users/dstufft/gists{/gist_id}","starred_url":"https://api.github.com/users/dstufft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dstufft/subscriptions","organizations_url":"https://api.github.com/users/dstufft/orgs","repos_url":"https://api.github.com/users/dstufft/repos","events_url":"https://api.github.com/users/dstufft/events{/privacy}","received_events_url":"https://api.github.com/users/dstufft/received_events","type":"User","site_admin":false},"body":"* Installs import hooks to make it possible to import things from ``pip._vendor`` if they are debundled.\r\n* Adds a flag for downstream re-distributors to use to unbundle things from ``pip._vendor``.\r\n* Debundling does *not* adjust the ``install_requires`` of pip, downstream will still need to ensure that they have the correct list of dependencies.\r\n* We do not test any versions other than what is pinned in ``pip/_vendor/vendor.txt``. \r\n* *Unrelated*: Properly handle comparison of ``Link`` objects with non ``Link`` objects.\r\n\r\nThe way this essentially works is that we install an import hook so that when you attempt to import ``pip._vendor.foo`` it first tries to import ``pip._vendor.foo`` and if that fails it falls back and will attempt to import ``foo`` and then adds it to ``sys.modules`` as ``pip._vendor.foo``.\r\n\r\nFixes: #1678\r\nFixes: #1651","created_at":"2014-11-20T05:17:32Z","updated_at":"2014-11-20T11:55:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3b1ef005328cceb41b0750cbb42b892a3b90ebeb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pypa/pip/pulls/2131/commits","review_comments_url":"https://api.github.com/repos/pypa/pip/pulls/2131/comments","review_comment_url":"https://api.github.com/repos/pypa/pip/pulls/comments/{number}","comments_url":"https://api.github.com/repos/pypa/pip/issues/2131/comments","statuses_url":"https://api.github.com/repos/pypa/pip/statuses/01eee963c9c6bb3aa1f28e3f8bfc79ccb1703f23","head":{"label":"dstufft:easier-debundle","ref":"easier-debundle","sha":"01eee963c9c6bb3aa1f28e3f8bfc79ccb1703f23","user":{"login":"dstufft","id":145979,"avatar_url":"https://avatars.githubusercontent.com/u/145979?v=3","gravatar_id":"","url":"https://api.github.com/users/dstufft","html_url":"https://github.com/dstufft","followers_url":"https://api.github.com/users/dstufft/followers","following_url":"https://api.github.com/users/dstufft/following{/other_user}","gists_url":"https://api.github.com/users/dstufft/gists{/gist_id}","starred_url":"https://api.github.com/users/dstufft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dstufft/subscriptions","organizations_url":"https://api.github.com/users/dstufft/orgs","repos_url":"https://api.github.com/users/dstufft/repos","events_url":"https://api.github.com/users/dstufft/events{/privacy}","received_events_url":"https://api.github.com/users/dstufft/received_events","type":"User","site_admin":false},"repo":{"id":3383276,"name":"pip","full_name":"dstufft/pip","owner":{"login":"dstufft","id":145979,"avatar_url":"https://avatars.githubusercontent.com/u/145979?v=3","gravatar_id":"","url":"https://api.github.com/users/dstufft","html_url":"https://github.com/dstufft","followers_url":"https://api.github.com/users/dstufft/followers","following_url":"https://api.github.com/users/dstufft/following{/other_user}","gists_url":"https://api.github.com/users/dstufft/gists{/gist_id}","starred_url":"https://api.github.com/users/dstufft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dstufft/subscriptions","organizations_url":"https://api.github.com/users/dstufft/orgs","repos_url":"https://api.github.com/users/dstufft/repos","events_url":"https://api.github.com/users/dstufft/events{/privacy}","received_events_url":"https://api.github.com/users/dstufft/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dstufft/pip","description":"pip installs packages. Python packages. An easy_install replacement","fork":true,"url":"https://api.github.com/repos/dstufft/pip","forks_url":"https://api.github.com/repos/dstufft/pip/forks","keys_url":"https://api.github.com/repos/dstufft/pip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dstufft/pip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dstufft/pip/teams","hooks_url":"https://api.github.com/repos/dstufft/pip/hooks","issue_events_url":"https://api.github.com/repos/dstufft/pip/issues/events{/number}","events_url":"https://api.github.com/repos/dstufft/pip/events","assignees_url":"https://api.github.com/repos/dstufft/pip/assignees{/user}","branches_url":"https://api.github.com/repos/dstufft/pip/branches{/branch}","tags_url":"https://api.github.com/repos/dstufft/pip/tags","blobs_url":"https://api.github.com/repos/dstufft/pip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dstufft/pip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dstufft/pip/git/refs{/sha}","trees_url":"https://api.github.com/repos/dstufft/pip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dstufft/pip/statuses/{sha}","languages_url":"https://api.github.com/repos/dstufft/pip/languages","stargazers_url":"https://api.github.com/repos/dstufft/pip/stargazers","contributors_url":"https://api.github.com/repos/dstufft/pip/contributors","subscribers_url":"https://api.github.com/repos/dstufft/pip/subscribers","subscription_url":"https://api.github.com/repos/dstufft/pip/subscription","commits_url":"https://api.github.com/repos/dstufft/pip/commits{/sha}","git_commits_url":"https://api.github.com/repos/dstufft/pip/git/commits{/sha}","comments_url":"https://api.github.com/repos/dstufft/pip/comments{/number}","issue_comment_url":"https://api.github.com/repos/dstufft/pip/issues/comments/{number}","contents_url":"https://api.github.com/repos/dstufft/pip/contents/{+path}","compare_url":"https://api.github.com/repos/dstufft/pip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dstufft/pip/merges","archive_url":"https://api.github.com/repos/dstufft/pip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dstufft/pip/downloads","issues_url":"https://api.github.com/repos/dstufft/pip/issues{/number}","pulls_url":"https://api.github.com/repos/dstufft/pip/pulls{/number}","milestones_url":"https://api.github.com/repos/dstufft/pip/milestones{/number}","notifications_url":"https://api.github.com/repos/dstufft/pip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dstufft/pip/labels{/name}","releases_url":"https://api.github.com/repos/dstufft/pip/releases{/id}","created_at":"2012-02-08T01:42:04Z","updated_at":"2014-06-28T04:54:49Z","pushed_at":"2014-11-20T06:58:49Z","git_url":"git://github.com/dstufft/pip.git","ssh_url":"git@github.com:dstufft/pip.git","clone_url":"https://github.com/dstufft/pip.git","svn_url":"https://github.com/dstufft/pip","homepage":"www.pip-installer.org","size":26471,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":4,"default_branch":"develop"}},"base":{"label":"pypa:develop","ref":"develop","sha":"043fe9f5700315d97f83609c1f59deece8f1b901","user":{"login":"pypa","id":647025,"avatar_url":"https://avatars.githubusercontent.com/u/647025?v=3","gravatar_id":"","url":"https://api.github.com/users/pypa","html_url":"https://github.com/pypa","followers_url":"https://api.github.com/users/pypa/followers","following_url":"https://api.github.com/users/pypa/following{/other_user}","gists_url":"https://api.github.com/users/pypa/gists{/gist_id}","starred_url":"https://api.github.com/users/pypa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pypa/subscriptions","organizations_url":"https://api.github.com/users/pypa/orgs","repos_url":"https://api.github.com/users/pypa/repos","events_url":"https://api.github.com/users/pypa/events{/privacy}","received_events_url":"https://api.github.com/users/pypa/received_events","type":"Organization","site_admin":false},"repo":{"id":1446467,"name":"pip","full_name":"pypa/pip","owner":{"login":"pypa","id":647025,"avatar_url":"https://avatars.githubusercontent.com/u/647025?v=3","gravatar_id":"","url":"https://api.github.com/users/pypa","html_url":"https://github.com/pypa","followers_url":"https://api.github.com/users/pypa/followers","following_url":"https://api.github.com/users/pypa/following{/other_user}","gists_url":"https://api.github.com/users/pypa/gists{/gist_id}","starred_url":"https://api.github.com/users/pypa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pypa/subscriptions","organizations_url":"https://api.github.com/users/pypa/orgs","repos_url":"https://api.github.com/users/pypa/repos","events_url":"https://api.github.com/users/pypa/events{/privacy}","received_events_url":"https://api.github.com/users/pypa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pypa/pip","description":"The PyPA recommended tool for installing Python packages","fork":false,"url":"https://api.github.com/repos/pypa/pip","forks_url":"https://api.github.com/repos/pypa/pip/forks","keys_url":"https://api.github.com/repos/pypa/pip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pypa/pip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pypa/pip/teams","hooks_url":"https://api.github.com/repos/pypa/pip/hooks","issue_events_url":"https://api.github.com/repos/pypa/pip/issues/events{/number}","events_url":"https://api.github.com/repos/pypa/pip/events","assignees_url":"https://api.github.com/repos/pypa/pip/assignees{/user}","branches_url":"https://api.github.com/repos/pypa/pip/branches{/branch}","tags_url":"https://api.github.com/repos/pypa/pip/tags","blobs_url":"https://api.github.com/repos/pypa/pip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pypa/pip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pypa/pip/git/refs{/sha}","trees_url":"https://api.github.com/repos/pypa/pip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pypa/pip/statuses/{sha}","languages_url":"https://api.github.com/repos/pypa/pip/languages","stargazers_url":"https://api.github.com/repos/pypa/pip/stargazers","contributors_url":"https://api.github.com/repos/pypa/pip/contributors","subscribers_url":"https://api.github.com/repos/pypa/pip/subscribers","subscription_url":"https://api.github.com/repos/pypa/pip/subscription","commits_url":"https://api.github.com/repos/pypa/pip/commits{/sha}","git_commits_url":"https://api.github.com/repos/pypa/pip/git/commits{/sha}","comments_url":"https://api.github.com/repos/pypa/pip/comments{/number}","issue_comment_url":"https://api.github.com/repos/pypa/pip/issues/comments/{number}","contents_url":"https://api.github.com/repos/pypa/pip/contents/{+path}","compare_url":"https://api.github.com/repos/pypa/pip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pypa/pip/merges","archive_url":"https://api.github.com/repos/pypa/pip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pypa/pip/downloads","issues_url":"https://api.github.com/repos/pypa/pip/issues{/number}","pulls_url":"https://api.github.com/repos/pypa/pip/pulls{/number}","milestones_url":"https://api.github.com/repos/pypa/pip/milestones{/number}","notifications_url":"https://api.github.com/repos/pypa/pip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pypa/pip/labels{/name}","releases_url":"https://api.github.com/repos/pypa/pip/releases{/id}","created_at":"2011-03-06T14:30:46Z","updated_at":"2014-11-20T05:59:14Z","pushed_at":"2014-11-12T01:44:06Z","git_url":"git://github.com/pypa/pip.git","ssh_url":"git@github.com:pypa/pip.git","clone_url":"https://github.com/pypa/pip.git","svn_url":"https://github.com/pypa/pip","homepage":"https://pip.pypa.io/","size":36685,"stargazers_count":1681,"watchers_count":1681,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":688,"mirror_url":null,"open_issues_count":459,"forks":688,"open_issues":459,"watchers":1681,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/pypa/pip/pulls/2131"},"html":{"href":"https://github.com/pypa/pip/pull/2131"},"issue":{"href":"https://api.github.com/repos/pypa/pip/issues/2131"},"comments":{"href":"https://api.github.com/repos/pypa/pip/issues/2131/comments"},"review_comments":{"href":"https://api.github.com/repos/pypa/pip/pulls/2131/comments"},"review_comment":{"href":"https://api.github.com/repos/pypa/pip/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/pypa/pip/pulls/2131/commits"},"statuses":{"href":"https://api.github.com/repos/pypa/pip/statuses/01eee963c9c6bb3aa1f28e3f8bfc79ccb1703f23"}}}}