GitHub PullRequestEvent at 2014-09-25 14:29:25
Repository: openbr
Actor: sklum
Payload: {"action":"closed","number":245,"pull_request":{"url":"https://api.github.com/repos/biometrics/openbr/pulls/245","id":21332148,"html_url":"https://github.com/biometrics/openbr/pull/245","diff_url":"https://github.com/biometrics/openbr/pull/245.diff","patch_url":"https://github.com/biometrics/openbr/pull/245.patch","issue_url":"https://api.github.com/repos/biometrics/openbr/issues/245","number":245,"state":"closed","locked":false,"title":"Proper stasm compilation","user":{"login":"sklum","id":3186522,"avatar_url":"https://avatars.githubusercontent.com/u/3186522?v=2","gravatar_id":"","url":"https://api.github.com/users/sklum","html_url":"https://github.com/sklum","followers_url":"https://api.github.com/users/sklum/followers","following_url":"https://api.github.com/users/sklum/following{/other_user}","gists_url":"https://api.github.com/users/sklum/gists{/gist_id}","starred_url":"https://api.github.com/users/sklum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sklum/subscriptions","organizations_url":"https://api.github.com/users/sklum/orgs","repos_url":"https://api.github.com/users/sklum/repos","events_url":"https://api.github.com/users/sklum/events{/privacy}","received_events_url":"https://api.github.com/users/sklum/received_events","type":"User","site_admin":false},"body":"This branch introduces a new method for compiling STASM into a library prior to compiling OpenBR, then links against said library.  Previously, STASM source was simply included in OpenBR and compiled as OpenBR was compiled (in fact, I think STASM code was compiled twice initially - once for STASM itself and once for OpenBR).\r\n\r\nWhile this branch doesn't introduce any new functionality, it significantly cleans up the install structure when installing OpenBR with STASM, and better compartmentalizes functionality.  Specifically:\r\n\r\n* STASM headers are now installed to ```CMAKE_INSTALL_PREFIX/include/stasm```.\r\n* STASM libraries are now installed to ```CMAKE_INSTALL_PREFIX/lib/``` (or ```CMAKE_INSTALL_PREFIX/lib/``` and ```CMAKE_INSTALL_PREFIX/bin/``` on Windows).\r\n\r\nAlso, STASM's original implementation relied on a wonky include hierarchy, where every file would include a single header that included all possible stasm headers.  I've gone through and fixed the dependencies to a more standard structure.\r\n\r\nA notable contribution of this branch is the new implementation of FindStasm4.cmake.  I believe this structure should be used moving forward when we want to link against external code (more than a few files) that is not already compiled into libraries.\r\n\r\n@jklontz @caotto ping for review\r\n\r\nEdit:\r\nThis branch now includes STASM 4.1.0 code, but training isn't implemented.  This actually will be a bit more challenging than I anticipated, as STASM expects the model files to be in headers that are compiled in to STASM itself (thus, using a uniquely trained model for STASM would require recompilation).  A few additional things were added as well:\r\n\r\n* Support for reading in [MUCT](http://www.milbo.org/muct/) galleries.  This will be beneficial when training is implemented in the future, and I think there is some development that is using MUCT data now?\r\n* Fixed a regular expression bug in file parsing.\r\n* Removed conversion to grayscale from within stasm4.cpp plugin.  This should be in the algorithm string, and I think it was responsible for some strange bugs.  This may affect you @bklare.","created_at":"2014-09-16T22:01:41Z","updated_at":"2014-09-25T14:29:24Z","closed_at":"2014-09-25T14:29:24Z","merged_at":"2014-09-25T14:29:24Z","merge_commit_sha":"46838f45a5a5abc9218fc1fa44eee53ffcfbd1ca","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/biometrics/openbr/pulls/245/commits","review_comments_url":"https://api.github.com/repos/biometrics/openbr/pulls/245/comments","review_comment_url":"https://api.github.com/repos/biometrics/openbr/pulls/comments/{number}","comments_url":"https://api.github.com/repos/biometrics/openbr/issues/245/comments","statuses_url":"https://api.github.com/repos/biometrics/openbr/statuses/fb9176c51e01e384166900826ce73cac5d52ccd4","head":{"label":"biometrics:proper_stasm_compilation","ref":"proper_stasm_compilation","sha":"fb9176c51e01e384166900826ce73cac5d52ccd4","user":{"login":"biometrics","id":94188,"avatar_url":"https://avatars.githubusercontent.com/u/94188?v=2","gravatar_id":"","url":"https://api.github.com/users/biometrics","html_url":"https://github.com/biometrics","followers_url":"https://api.github.com/users/biometrics/followers","following_url":"https://api.github.com/users/biometrics/following{/other_user}","gists_url":"https://api.github.com/users/biometrics/gists{/gist_id}","starred_url":"https://api.github.com/users/biometrics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biometrics/subscriptions","organizations_url":"https://api.github.com/users/biometrics/orgs","repos_url":"https://api.github.com/users/biometrics/repos","events_url":"https://api.github.com/users/biometrics/events{/privacy}","received_events_url":"https://api.github.com/users/biometrics/received_events","type":"Organization","site_admin":false},"repo":{"id":7251195,"name":"openbr","full_name":"biometrics/openbr","owner":{"login":"biometrics","id":94188,"avatar_url":"https://avatars.githubusercontent.com/u/94188?v=2","gravatar_id":"","url":"https://api.github.com/users/biometrics","html_url":"https://github.com/biometrics","followers_url":"https://api.github.com/users/biometrics/followers","following_url":"https://api.github.com/users/biometrics/following{/other_user}","gists_url":"https://api.github.com/users/biometrics/gists{/gist_id}","starred_url":"https://api.github.com/users/biometrics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biometrics/subscriptions","organizations_url":"https://api.github.com/users/biometrics/orgs","repos_url":"https://api.github.com/users/biometrics/repos","events_url":"https://api.github.com/users/biometrics/events{/privacy}","received_events_url":"https://api.github.com/users/biometrics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/biometrics/openbr","description":"Open Source Biometrics, Face Recognition","fork":false,"url":"https://api.github.com/repos/biometrics/openbr","forks_url":"https://api.github.com/repos/biometrics/openbr/forks","keys_url":"https://api.github.com/repos/biometrics/openbr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/biometrics/openbr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/biometrics/openbr/teams","hooks_url":"https://api.github.com/repos/biometrics/openbr/hooks","issue_events_url":"https://api.github.com/repos/biometrics/openbr/issues/events{/number}","events_url":"https://api.github.com/repos/biometrics/openbr/events","assignees_url":"https://api.github.com/repos/biometrics/openbr/assignees{/user}","branches_url":"https://api.github.com/repos/biometrics/openbr/branches{/branch}","tags_url":"https://api.github.com/repos/biometrics/openbr/tags","blobs_url":"https://api.github.com/repos/biometrics/openbr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/biometrics/openbr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/biometrics/openbr/git/refs{/sha}","trees_url":"https://api.github.com/repos/biometrics/openbr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/biometrics/openbr/statuses/{sha}","languages_url":"https://api.github.com/repos/biometrics/openbr/languages","stargazers_url":"https://api.github.com/repos/biometrics/openbr/stargazers","contributors_url":"https://api.github.com/repos/biometrics/openbr/contributors","subscribers_url":"https://api.github.com/repos/biometrics/openbr/subscribers","subscription_url":"https://api.github.com/repos/biometrics/openbr/subscription","commits_url":"https://api.github.com/repos/biometrics/openbr/commits{/sha}","git_commits_url":"https://api.github.com/repos/biometrics/openbr/git/commits{/sha}","comments_url":"https://api.github.com/repos/biometrics/openbr/comments{/number}","issue_comment_url":"https://api.github.com/repos/biometrics/openbr/issues/comments/{number}","contents_url":"https://api.github.com/repos/biometrics/openbr/contents/{+path}","compare_url":"https://api.github.com/repos/biometrics/openbr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/biometrics/openbr/merges","archive_url":"https://api.github.com/repos/biometrics/openbr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/biometrics/openbr/downloads","issues_url":"https://api.github.com/repos/biometrics/openbr/issues{/number}","pulls_url":"https://api.github.com/repos/biometrics/openbr/pulls{/number}","milestones_url":"https://api.github.com/repos/biometrics/openbr/milestones{/number}","notifications_url":"https://api.github.com/repos/biometrics/openbr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/biometrics/openbr/labels{/name}","releases_url":"https://api.github.com/repos/biometrics/openbr/releases{/id}","created_at":"2012-12-20T02:52:37Z","updated_at":"2014-09-22T01:21:15Z","pushed_at":"2014-09-25T14:29:24Z","git_url":"git://github.com/biometrics/openbr.git","ssh_url":"git@github.com:biometrics/openbr.git","clone_url":"https://github.com/biometrics/openbr.git","svn_url":"https://github.com/biometrics/openbr","homepage":"www.openbiometrics.org","size":45813,"stargazers_count":1020,"watchers_count":1020,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":160,"mirror_url":null,"open_issues_count":15,"forks":160,"open_issues":15,"watchers":1020,"default_branch":"master"}},"base":{"label":"biometrics:master","ref":"master","sha":"4f3488f0b7cf7fafddf602fdd1f452b9de071877","user":{"login":"biometrics","id":94188,"avatar_url":"https://avatars.githubusercontent.com/u/94188?v=2","gravatar_id":"","url":"https://api.github.com/users/biometrics","html_url":"https://github.com/biometrics","followers_url":"https://api.github.com/users/biometrics/followers","following_url":"https://api.github.com/users/biometrics/following{/other_user}","gists_url":"https://api.github.com/users/biometrics/gists{/gist_id}","starred_url":"https://api.github.com/users/biometrics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biometrics/subscriptions","organizations_url":"https://api.github.com/users/biometrics/orgs","repos_url":"https://api.github.com/users/biometrics/repos","events_url":"https://api.github.com/users/biometrics/events{/privacy}","received_events_url":"https://api.github.com/users/biometrics/received_events","type":"Organization","site_admin":false},"repo":{"id":7251195,"name":"openbr","full_name":"biometrics/openbr","owner":{"login":"biometrics","id":94188,"avatar_url":"https://avatars.githubusercontent.com/u/94188?v=2","gravatar_id":"","url":"https://api.github.com/users/biometrics","html_url":"https://github.com/biometrics","followers_url":"https://api.github.com/users/biometrics/followers","following_url":"https://api.github.com/users/biometrics/following{/other_user}","gists_url":"https://api.github.com/users/biometrics/gists{/gist_id}","starred_url":"https://api.github.com/users/biometrics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biometrics/subscriptions","organizations_url":"https://api.github.com/users/biometrics/orgs","repos_url":"https://api.github.com/users/biometrics/repos","events_url":"https://api.github.com/users/biometrics/events{/privacy}","received_events_url":"https://api.github.com/users/biometrics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/biometrics/openbr","description":"Open Source Biometrics, Face Recognition","fork":false,"url":"https://api.github.com/repos/biometrics/openbr","forks_url":"https://api.github.com/repos/biometrics/openbr/forks","keys_url":"https://api.github.com/repos/biometrics/openbr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/biometrics/openbr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/biometrics/openbr/teams","hooks_url":"https://api.github.com/repos/biometrics/openbr/hooks","issue_events_url":"https://api.github.com/repos/biometrics/openbr/issues/events{/number}","events_url":"https://api.github.com/repos/biometrics/openbr/events","assignees_url":"https://api.github.com/repos/biometrics/openbr/assignees{/user}","branches_url":"https://api.github.com/repos/biometrics/openbr/branches{/branch}","tags_url":"https://api.github.com/repos/biometrics/openbr/tags","blobs_url":"https://api.github.com/repos/biometrics/openbr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/biometrics/openbr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/biometrics/openbr/git/refs{/sha}","trees_url":"https://api.github.com/repos/biometrics/openbr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/biometrics/openbr/statuses/{sha}","languages_url":"https://api.github.com/repos/biometrics/openbr/languages","stargazers_url":"https://api.github.com/repos/biometrics/openbr/stargazers","contributors_url":"https://api.github.com/repos/biometrics/openbr/contributors","subscribers_url":"https://api.github.com/repos/biometrics/openbr/subscribers","subscription_url":"https://api.github.com/repos/biometrics/openbr/subscription","commits_url":"https://api.github.com/repos/biometrics/openbr/commits{/sha}","git_commits_url":"https://api.github.com/repos/biometrics/openbr/git/commits{/sha}","comments_url":"https://api.github.com/repos/biometrics/openbr/comments{/number}","issue_comment_url":"https://api.github.com/repos/biometrics/openbr/issues/comments/{number}","contents_url":"https://api.github.com/repos/biometrics/openbr/contents/{+path}","compare_url":"https://api.github.com/repos/biometrics/openbr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/biometrics/openbr/merges","archive_url":"https://api.github.com/repos/biometrics/openbr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/biometrics/openbr/downloads","issues_url":"https://api.github.com/repos/biometrics/openbr/issues{/number}","pulls_url":"https://api.github.com/repos/biometrics/openbr/pulls{/number}","milestones_url":"https://api.github.com/repos/biometrics/openbr/milestones{/number}","notifications_url":"https://api.github.com/repos/biometrics/openbr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/biometrics/openbr/labels{/name}","releases_url":"https://api.github.com/repos/biometrics/openbr/releases{/id}","created_at":"2012-12-20T02:52:37Z","updated_at":"2014-09-22T01:21:15Z","pushed_at":"2014-09-25T14:29:24Z","git_url":"git://github.com/biometrics/openbr.git","ssh_url":"git@github.com:biometrics/openbr.git","clone_url":"https://github.com/biometrics/openbr.git","svn_url":"https://github.com/biometrics/openbr","homepage":"www.openbiometrics.org","size":45813,"stargazers_count":1020,"watchers_count":1020,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":160,"mirror_url":null,"open_issues_count":15,"forks":160,"open_issues":15,"watchers":1020,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/biometrics/openbr/pulls/245"},"html":{"href":"https://github.com/biometrics/openbr/pull/245"},"issue":{"href":"https://api.github.com/repos/biometrics/openbr/issues/245"},"comments":{"href":"https://api.github.com/repos/biometrics/openbr/issues/245/comments"},"review_comments":{"href":"https://api.github.com/repos/biometrics/openbr/pulls/245/comments"},"review_comment":{"href":"https://api.github.com/repos/biometrics/openbr/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/biometrics/openbr/pulls/245/commits"},"statuses":{"href":"https://api.github.com/repos/biometrics/openbr/statuses/fb9176c51e01e384166900826ce73cac5d52ccd4"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"sklum","id":3186522,"avatar_url":"https://avatars.githubusercontent.com/u/3186522?v=2","gravatar_id":"","url":"https://api.github.com/users/sklum","html_url":"https://github.com/sklum","followers_url":"https://api.github.com/users/sklum/followers","following_url":"https://api.github.com/users/sklum/following{/other_user}","gists_url":"https://api.github.com/users/sklum/gists{/gist_id}","starred_url":"https://api.github.com/users/sklum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sklum/subscriptions","organizations_url":"https://api.github.com/users/sklum/orgs","repos_url":"https://api.github.com/users/sklum/repos","events_url":"https://api.github.com/users/sklum/events{/privacy}","received_events_url":"https://api.github.com/users/sklum/received_events","type":"User","site_admin":false},"comments":16,"review_comments":0,"commits":26,"additions":158,"deletions":33,"changed_files":447}}