GitHub PullRequestReviewCommentEvent at 2014-08-11 10:25:29
Repository: nose
Actor: jszakmeister
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/nose-devs/nose/pulls/comments/16046104","id":16046104,"diff_hunk":"@@ -166,10 +174,11 @@ def report(self, stream):\n         self.coverInstance.combine()\n         self.coverInstance.save()\n         modules = [module\n-                    for name, module in sys.modules.items()\n-                    if self.wantModuleCoverage(name, module)]\n+                   for name, module in sys.modules.items()\n+                   if self.wantModuleCoverage(name, module)]\n         log.debug(\"Coverage report will cover modules: %s\", modules)\n-        self.coverInstance.report(modules, file=stream)\n+        if not self.coverNoPrint:","path":"nose/plugins/cover.py","position":51,"original_position":51,"commit_id":"2f433dfab49271d72a6547051443349d3a6fe264","original_commit_id":"2f433dfab49271d72a6547051443349d3a6fe264","user":{"login":"jszakmeister","id":448087,"avatar_url":"https://avatars.githubusercontent.com/u/448087?v=2","gravatar_id":"69ad2af1f028b1b7e76c14f83bdf26cb","url":"https://api.github.com/users/jszakmeister","html_url":"https://github.com/jszakmeister","followers_url":"https://api.github.com/users/jszakmeister/followers","following_url":"https://api.github.com/users/jszakmeister/following{/other_user}","gists_url":"https://api.github.com/users/jszakmeister/gists{/gist_id}","starred_url":"https://api.github.com/users/jszakmeister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jszakmeister/subscriptions","organizations_url":"https://api.github.com/users/jszakmeister/orgs","repos_url":"https://api.github.com/users/jszakmeister/repos","events_url":"https://api.github.com/users/jszakmeister/events{/privacy}","received_events_url":"https://api.github.com/users/jszakmeister/received_events","type":"User","site_admin":false},"body":"...here. :-)  I know there's a desire to keep things named the same as options, but avoiding double negatives keeps the code easier to read.","created_at":"2014-08-11T10:25:29Z","updated_at":"2014-08-11T10:25:29Z","html_url":"https://github.com/nose-devs/nose/pull/830#discussion_r16046104","pull_request_url":"https://api.github.com/repos/nose-devs/nose/pulls/830","_links":{"self":{"href":"https://api.github.com/repos/nose-devs/nose/pulls/comments/16046104"},"html":{"href":"https://github.com/nose-devs/nose/pull/830#discussion_r16046104"},"pull_request":{"href":"https://api.github.com/repos/nose-devs/nose/pulls/830"}}},"pull_request":{"url":"https://api.github.com/repos/nose-devs/nose/pulls/830","id":19257369,"html_url":"https://github.com/nose-devs/nose/pull/830","diff_url":"https://github.com/nose-devs/nose/pull/830.diff","patch_url":"https://github.com/nose-devs/nose/pull/830.patch","issue_url":"https://api.github.com/repos/nose-devs/nose/issues/830","number":830,"state":"open","title":"ENH: Allow not printing coverage report","user":{"login":"Eric89GXL","id":2365790,"avatar_url":"https://avatars.githubusercontent.com/u/2365790?v=2","gravatar_id":"bfd1a4884c9621f28ee42e38f652db99","url":"https://api.github.com/users/Eric89GXL","html_url":"https://github.com/Eric89GXL","followers_url":"https://api.github.com/users/Eric89GXL/followers","following_url":"https://api.github.com/users/Eric89GXL/following{/other_user}","gists_url":"https://api.github.com/users/Eric89GXL/gists{/gist_id}","starred_url":"https://api.github.com/users/Eric89GXL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eric89GXL/subscriptions","organizations_url":"https://api.github.com/users/Eric89GXL/orgs","repos_url":"https://api.github.com/users/Eric89GXL/repos","events_url":"https://api.github.com/users/Eric89GXL/events{/privacy}","received_events_url":"https://api.github.com/users/Eric89GXL/received_events","type":"User","site_admin":false},"body":"Code changes proposed to address #829.\r\n\r\nCloses #829.","created_at":"2014-08-03T17:14:38Z","updated_at":"2014-08-11T10:25:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"15bc6802ebcbbbcd047a2a9f62c9e3fdc5e4b59f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nose-devs/nose/pulls/830/commits","review_comments_url":"https://api.github.com/repos/nose-devs/nose/pulls/830/comments","review_comment_url":"https://api.github.com/repos/nose-devs/nose/pulls/comments/{number}","comments_url":"https://api.github.com/repos/nose-devs/nose/issues/830/comments","statuses_url":"https://api.github.com/repos/nose-devs/nose/statuses/2f433dfab49271d72a6547051443349d3a6fe264","head":{"label":"Eric89GXL:no-print","ref":"no-print","sha":"2f433dfab49271d72a6547051443349d3a6fe264","user":{"login":"Eric89GXL","id":2365790,"avatar_url":"https://avatars.githubusercontent.com/u/2365790?v=2","gravatar_id":"bfd1a4884c9621f28ee42e38f652db99","url":"https://api.github.com/users/Eric89GXL","html_url":"https://github.com/Eric89GXL","followers_url":"https://api.github.com/users/Eric89GXL/followers","following_url":"https://api.github.com/users/Eric89GXL/following{/other_user}","gists_url":"https://api.github.com/users/Eric89GXL/gists{/gist_id}","starred_url":"https://api.github.com/users/Eric89GXL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eric89GXL/subscriptions","organizations_url":"https://api.github.com/users/Eric89GXL/orgs","repos_url":"https://api.github.com/users/Eric89GXL/repos","events_url":"https://api.github.com/users/Eric89GXL/events{/privacy}","received_events_url":"https://api.github.com/users/Eric89GXL/received_events","type":"User","site_admin":false},"repo":{"id":22579283,"name":"nose","full_name":"Eric89GXL/nose","owner":{"login":"Eric89GXL","id":2365790,"avatar_url":"https://avatars.githubusercontent.com/u/2365790?v=2","gravatar_id":"bfd1a4884c9621f28ee42e38f652db99","url":"https://api.github.com/users/Eric89GXL","html_url":"https://github.com/Eric89GXL","followers_url":"https://api.github.com/users/Eric89GXL/followers","following_url":"https://api.github.com/users/Eric89GXL/following{/other_user}","gists_url":"https://api.github.com/users/Eric89GXL/gists{/gist_id}","starred_url":"https://api.github.com/users/Eric89GXL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eric89GXL/subscriptions","organizations_url":"https://api.github.com/users/Eric89GXL/orgs","repos_url":"https://api.github.com/users/Eric89GXL/repos","events_url":"https://api.github.com/users/Eric89GXL/events{/privacy}","received_events_url":"https://api.github.com/users/Eric89GXL/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Eric89GXL/nose","description":"nose is nicer testing for python","fork":true,"url":"https://api.github.com/repos/Eric89GXL/nose","forks_url":"https://api.github.com/repos/Eric89GXL/nose/forks","keys_url":"https://api.github.com/repos/Eric89GXL/nose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Eric89GXL/nose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Eric89GXL/nose/teams","hooks_url":"https://api.github.com/repos/Eric89GXL/nose/hooks","issue_events_url":"https://api.github.com/repos/Eric89GXL/nose/issues/events{/number}","events_url":"https://api.github.com/repos/Eric89GXL/nose/events","assignees_url":"https://api.github.com/repos/Eric89GXL/nose/assignees{/user}","branches_url":"https://api.github.com/repos/Eric89GXL/nose/branches{/branch}","tags_url":"https://api.github.com/repos/Eric89GXL/nose/tags","blobs_url":"https://api.github.com/repos/Eric89GXL/nose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Eric89GXL/nose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Eric89GXL/nose/git/refs{/sha}","trees_url":"https://api.github.com/repos/Eric89GXL/nose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Eric89GXL/nose/statuses/{sha}","languages_url":"https://api.github.com/repos/Eric89GXL/nose/languages","stargazers_url":"https://api.github.com/repos/Eric89GXL/nose/stargazers","contributors_url":"https://api.github.com/repos/Eric89GXL/nose/contributors","subscribers_url":"https://api.github.com/repos/Eric89GXL/nose/subscribers","subscription_url":"https://api.github.com/repos/Eric89GXL/nose/subscription","commits_url":"https://api.github.com/repos/Eric89GXL/nose/commits{/sha}","git_commits_url":"https://api.github.com/repos/Eric89GXL/nose/git/commits{/sha}","comments_url":"https://api.github.com/repos/Eric89GXL/nose/comments{/number}","issue_comment_url":"https://api.github.com/repos/Eric89GXL/nose/issues/comments/{number}","contents_url":"https://api.github.com/repos/Eric89GXL/nose/contents/{+path}","compare_url":"https://api.github.com/repos/Eric89GXL/nose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Eric89GXL/nose/merges","archive_url":"https://api.github.com/repos/Eric89GXL/nose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Eric89GXL/nose/downloads","issues_url":"https://api.github.com/repos/Eric89GXL/nose/issues{/number}","pulls_url":"https://api.github.com/repos/Eric89GXL/nose/pulls{/number}","milestones_url":"https://api.github.com/repos/Eric89GXL/nose/milestones{/number}","notifications_url":"https://api.github.com/repos/Eric89GXL/nose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Eric89GXL/nose/labels{/name}","releases_url":"https://api.github.com/repos/Eric89GXL/nose/releases{/id}","created_at":"2014-08-03T17:02:40Z","updated_at":"2014-08-01T03:24:42Z","pushed_at":"2014-08-03T17:12:28Z","git_url":"git://github.com/Eric89GXL/nose.git","ssh_url":"git@github.com:Eric89GXL/nose.git","clone_url":"https://github.com/Eric89GXL/nose.git","svn_url":"https://github.com/Eric89GXL/nose","homepage":"http://readthedocs.org/docs/nose/en/latest/","size":4304,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nose-devs:master","ref":"master","sha":"5c91d2a9589a03243c2606cbbefa100606cb5345","user":{"login":"nose-devs","id":1263082,"avatar_url":"https://avatars.githubusercontent.com/u/1263082?v=2","gravatar_id":"07063639bb42ff24e30dbfec9ac6ef9a","url":"https://api.github.com/users/nose-devs","html_url":"https://github.com/nose-devs","followers_url":"https://api.github.com/users/nose-devs/followers","following_url":"https://api.github.com/users/nose-devs/following{/other_user}","gists_url":"https://api.github.com/users/nose-devs/gists{/gist_id}","starred_url":"https://api.github.com/users/nose-devs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nose-devs/subscriptions","organizations_url":"https://api.github.com/users/nose-devs/orgs","repos_url":"https://api.github.com/users/nose-devs/repos","events_url":"https://api.github.com/users/nose-devs/events{/privacy}","received_events_url":"https://api.github.com/users/nose-devs/received_events","type":"Organization","site_admin":false},"repo":{"id":2974718,"name":"nose","full_name":"nose-devs/nose","owner":{"login":"nose-devs","id":1263082,"avatar_url":"https://avatars.githubusercontent.com/u/1263082?v=2","gravatar_id":"07063639bb42ff24e30dbfec9ac6ef9a","url":"https://api.github.com/users/nose-devs","html_url":"https://github.com/nose-devs","followers_url":"https://api.github.com/users/nose-devs/followers","following_url":"https://api.github.com/users/nose-devs/following{/other_user}","gists_url":"https://api.github.com/users/nose-devs/gists{/gist_id}","starred_url":"https://api.github.com/users/nose-devs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nose-devs/subscriptions","organizations_url":"https://api.github.com/users/nose-devs/orgs","repos_url":"https://api.github.com/users/nose-devs/repos","events_url":"https://api.github.com/users/nose-devs/events{/privacy}","received_events_url":"https://api.github.com/users/nose-devs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nose-devs/nose","description":"nose is nicer testing for python","fork":false,"url":"https://api.github.com/repos/nose-devs/nose","forks_url":"https://api.github.com/repos/nose-devs/nose/forks","keys_url":"https://api.github.com/repos/nose-devs/nose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nose-devs/nose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nose-devs/nose/teams","hooks_url":"https://api.github.com/repos/nose-devs/nose/hooks","issue_events_url":"https://api.github.com/repos/nose-devs/nose/issues/events{/number}","events_url":"https://api.github.com/repos/nose-devs/nose/events","assignees_url":"https://api.github.com/repos/nose-devs/nose/assignees{/user}","branches_url":"https://api.github.com/repos/nose-devs/nose/branches{/branch}","tags_url":"https://api.github.com/repos/nose-devs/nose/tags","blobs_url":"https://api.github.com/repos/nose-devs/nose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nose-devs/nose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nose-devs/nose/git/refs{/sha}","trees_url":"https://api.github.com/repos/nose-devs/nose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nose-devs/nose/statuses/{sha}","languages_url":"https://api.github.com/repos/nose-devs/nose/languages","stargazers_url":"https://api.github.com/repos/nose-devs/nose/stargazers","contributors_url":"https://api.github.com/repos/nose-devs/nose/contributors","subscribers_url":"https://api.github.com/repos/nose-devs/nose/subscribers","subscription_url":"https://api.github.com/repos/nose-devs/nose/subscription","commits_url":"https://api.github.com/repos/nose-devs/nose/commits{/sha}","git_commits_url":"https://api.github.com/repos/nose-devs/nose/git/commits{/sha}","comments_url":"https://api.github.com/repos/nose-devs/nose/comments{/number}","issue_comment_url":"https://api.github.com/repos/nose-devs/nose/issues/comments/{number}","contents_url":"https://api.github.com/repos/nose-devs/nose/contents/{+path}","compare_url":"https://api.github.com/repos/nose-devs/nose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nose-devs/nose/merges","archive_url":"https://api.github.com/repos/nose-devs/nose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nose-devs/nose/downloads","issues_url":"https://api.github.com/repos/nose-devs/nose/issues{/number}","pulls_url":"https://api.github.com/repos/nose-devs/nose/pulls{/number}","milestones_url":"https://api.github.com/repos/nose-devs/nose/milestones{/number}","notifications_url":"https://api.github.com/repos/nose-devs/nose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nose-devs/nose/labels{/name}","releases_url":"https://api.github.com/repos/nose-devs/nose/releases{/id}","created_at":"2011-12-13T19:36:32Z","updated_at":"2014-08-11T08:38:39Z","pushed_at":"2014-08-11T10:17:13Z","git_url":"git://github.com/nose-devs/nose.git","ssh_url":"git@github.com:nose-devs/nose.git","clone_url":"https://github.com/nose-devs/nose.git","svn_url":"https://github.com/nose-devs/nose","homepage":"http://readthedocs.org/docs/nose/en/latest/","size":6595,"stargazers_count":628,"watchers_count":628,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":215,"mirror_url":null,"open_issues_count":325,"forks":215,"open_issues":325,"watchers":628,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nose-devs/nose/pulls/830"},"html":{"href":"https://github.com/nose-devs/nose/pull/830"},"issue":{"href":"https://api.github.com/repos/nose-devs/nose/issues/830"},"comments":{"href":"https://api.github.com/repos/nose-devs/nose/issues/830/comments"},"review_comments":{"href":"https://api.github.com/repos/nose-devs/nose/pulls/830/comments"},"review_comment":{"href":"https://api.github.com/repos/nose-devs/nose/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/nose-devs/nose/pulls/830/commits"},"statuses":{"href":"https://api.github.com/repos/nose-devs/nose/statuses/2f433dfab49271d72a6547051443349d3a6fe264"}}}}