GitHub PullRequestReviewCommentEvent at 2014-09-02 19:01:48
Repository: nixpkgs
Actor: lethalman
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/17007813","id":17007813,"diff_hunk":"@@ -11401,6 +11422,10 @@ let\n \n   retroarch = callPackage ../misc/emulators/retroarch { };\n \n+  retroarchWrapper = wrapRetroArch { retroarchPkg = retroarch; };","path":"pkgs/top-level/all-packages.nix","position":68,"original_position":68,"commit_id":"1dfe828baa52fcabff15901df371ea5d914f783d","original_commit_id":"1dfe828baa52fcabff15901df371ea5d914f783d","user":{"login":"lethalman","id":480920,"avatar_url":"https://avatars.githubusercontent.com/u/480920?v=2","gravatar_id":"1d72f5ad9628963de720b9e0b8df4f59","url":"https://api.github.com/users/lethalman","html_url":"https://github.com/lethalman","followers_url":"https://api.github.com/users/lethalman/followers","following_url":"https://api.github.com/users/lethalman/following{/other_user}","gists_url":"https://api.github.com/users/lethalman/gists{/gist_id}","starred_url":"https://api.github.com/users/lethalman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lethalman/subscriptions","organizations_url":"https://api.github.com/users/lethalman/orgs","repos_url":"https://api.github.com/users/lethalman/repos","events_url":"https://api.github.com/users/lethalman/events{/privacy}","received_events_url":"https://api.github.com/users/lethalman/received_events","type":"User","site_admin":false},"body":"I'm ok with the PR of course, but why do you want to lose the opportunity to drop that ugly Wrapper name for the most used package? I would rename retroarch with retroarchReal, and its derivation name with retroarch-real.\r\nThat means people can install with nix-env -i retroarch and nix-env -iA retroarch which is more user friendly.\r\n\r\nDon't know if this would be the first package to break the Wrapper name rule, but it might be a good occasion.","created_at":"2014-09-02T19:01:48Z","updated_at":"2014-09-02T19:01:48Z","html_url":"https://github.com/NixOS/nixpkgs/pull/3800#discussion_r17007813","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/3800","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/17007813"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/3800#discussion_r17007813"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/3800"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/3800","id":20324359,"html_url":"https://github.com/NixOS/nixpkgs/pull/3800","diff_url":"https://github.com/NixOS/nixpkgs/pull/3800.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/3800.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/3800","number":3800,"state":"open","locked":false,"title":"retroarchWrapper: added wrapRetroArch, libretro-cores: adding some cores","user":{"login":"edwtjo","id":54799,"avatar_url":"https://avatars.githubusercontent.com/u/54799?v=2","gravatar_id":"d1313e0d5ce9583c19f76218701a7517","url":"https://api.github.com/users/edwtjo","html_url":"https://github.com/edwtjo","followers_url":"https://api.github.com/users/edwtjo/followers","following_url":"https://api.github.com/users/edwtjo/following{/other_user}","gists_url":"https://api.github.com/users/edwtjo/gists{/gist_id}","starred_url":"https://api.github.com/users/edwtjo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edwtjo/subscriptions","organizations_url":"https://api.github.com/users/edwtjo/orgs","repos_url":"https://api.github.com/users/edwtjo/repos","events_url":"https://api.github.com/users/edwtjo/events{/privacy}","received_events_url":"https://api.github.com/users/edwtjo/received_events","type":"User","site_admin":false},"body":"Adds initial mkLibRetroCore expression as well as some simple cores with retroarch wrappers for easy invocation.","created_at":"2014-08-26T17:35:01Z","updated_at":"2014-09-02T19:01:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ca49789ef09cacc6bb97ef35e07bbec7fa9a24d0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/3800/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/3800/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/{number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/3800/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/1dfe828baa52fcabff15901df371ea5d914f783d","head":{"label":"edwtjo:libretro-cores","ref":"libretro-cores","sha":"1dfe828baa52fcabff15901df371ea5d914f783d","user":{"login":"edwtjo","id":54799,"avatar_url":"https://avatars.githubusercontent.com/u/54799?v=2","gravatar_id":"d1313e0d5ce9583c19f76218701a7517","url":"https://api.github.com/users/edwtjo","html_url":"https://github.com/edwtjo","followers_url":"https://api.github.com/users/edwtjo/followers","following_url":"https://api.github.com/users/edwtjo/following{/other_user}","gists_url":"https://api.github.com/users/edwtjo/gists{/gist_id}","starred_url":"https://api.github.com/users/edwtjo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edwtjo/subscriptions","organizations_url":"https://api.github.com/users/edwtjo/orgs","repos_url":"https://api.github.com/users/edwtjo/repos","events_url":"https://api.github.com/users/edwtjo/events{/privacy}","received_events_url":"https://api.github.com/users/edwtjo/received_events","type":"User","site_admin":false},"repo":{"id":12599335,"name":"nixpkgs","full_name":"edwtjo/nixpkgs","owner":{"login":"edwtjo","id":54799,"avatar_url":"https://avatars.githubusercontent.com/u/54799?v=2","gravatar_id":"d1313e0d5ce9583c19f76218701a7517","url":"https://api.github.com/users/edwtjo","html_url":"https://github.com/edwtjo","followers_url":"https://api.github.com/users/edwtjo/followers","following_url":"https://api.github.com/users/edwtjo/following{/other_user}","gists_url":"https://api.github.com/users/edwtjo/gists{/gist_id}","starred_url":"https://api.github.com/users/edwtjo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edwtjo/subscriptions","organizations_url":"https://api.github.com/users/edwtjo/orgs","repos_url":"https://api.github.com/users/edwtjo/repos","events_url":"https://api.github.com/users/edwtjo/events{/privacy}","received_events_url":"https://api.github.com/users/edwtjo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/edwtjo/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/edwtjo/nixpkgs","forks_url":"https://api.github.com/repos/edwtjo/nixpkgs/forks","keys_url":"https://api.github.com/repos/edwtjo/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edwtjo/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edwtjo/nixpkgs/teams","hooks_url":"https://api.github.com/repos/edwtjo/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/edwtjo/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/edwtjo/nixpkgs/events","assignees_url":"https://api.github.com/repos/edwtjo/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/edwtjo/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/edwtjo/nixpkgs/tags","blobs_url":"https://api.github.com/repos/edwtjo/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edwtjo/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edwtjo/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/edwtjo/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edwtjo/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/edwtjo/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/edwtjo/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/edwtjo/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/edwtjo/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/edwtjo/nixpkgs/subscription","commits_url":"https://api.github.com/repos/edwtjo/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/edwtjo/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/edwtjo/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/edwtjo/nixpkgs/issues/comments/{number}","contents_url":"https://api.github.com/repos/edwtjo/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/edwtjo/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edwtjo/nixpkgs/merges","archive_url":"https://api.github.com/repos/edwtjo/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edwtjo/nixpkgs/downloads","issues_url":"https://api.github.com/repos/edwtjo/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/edwtjo/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/edwtjo/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/edwtjo/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edwtjo/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/edwtjo/nixpkgs/releases{/id}","created_at":"2013-09-04T18:52:40Z","updated_at":"2014-07-12T09:59:13Z","pushed_at":"2014-09-02T18:55:40Z","git_url":"git://github.com/edwtjo/nixpkgs.git","ssh_url":"git@github.com:edwtjo/nixpkgs.git","clone_url":"https://github.com/edwtjo/nixpkgs.git","svn_url":"https://github.com/edwtjo/nixpkgs","homepage":null,"size":139856,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"7b7fd5044fd41252d3f3da156e139b08ad6cb2ad","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=2","gravatar_id":"ef3a4fb799584882e0f7a40f9aec1b09","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=2","gravatar_id":"ef3a4fb799584882e0f7a40f9aec1b09","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments/{number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","created_at":"2012-06-04T02:49:46Z","updated_at":"2014-09-02T06:58:43Z","pushed_at":"2014-09-02T18:59:27Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":240357,"stargazers_count":305,"watchers_count":305,"language":"Nix","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":400,"mirror_url":null,"open_issues_count":389,"forks":400,"open_issues":389,"watchers":305,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/3800"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/3800"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/3800"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/3800/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/3800/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/3800/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/1dfe828baa52fcabff15901df371ea5d914f783d"}}}}