GitHub PullRequestReviewCommentEvent at 2014-08-14 16:55:22
Repository: omnibus
Actor: schisamo
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/opscode/omnibus/pulls/comments/16250554","id":16250554,"diff_hunk":"@@ -31,8 +30,7 @@\n     </InstallExecuteSequence>\n \n     <Directory Id=\"TARGETDIR\" Name=\"SourceDir\">\n-      <Directory Id=\"WindowsVolume\">\n-        <!-- Service needs chef directory to be present. -->\n+      <Directory Id=\"WINDOWSVOLUME\">\n         <Directory Id=\"INSTALLLOCATION\" Name=\"opt\">\n           <Directory Id=\"PROJECTLOCATION\" Name=\"<%= name %>\">","path":"resources/msi/source.wxs.erb","position":26,"original_position":26,"commit_id":"0a9fb03e78ba8a91b96bef47b5e3f9903817dfd7","original_commit_id":"0a9fb03e78ba8a91b96bef47b5e3f9903817dfd7","user":{"login":"schisamo","id":6164,"avatar_url":"https://avatars.githubusercontent.com/u/6164?v=2","gravatar_id":"6d7e8682f24ca25a74e9a85895ee3ee1","url":"https://api.github.com/users/schisamo","html_url":"https://github.com/schisamo","followers_url":"https://api.github.com/users/schisamo/followers","following_url":"https://api.github.com/users/schisamo/following{/other_user}","gists_url":"https://api.github.com/users/schisamo/gists{/gist_id}","starred_url":"https://api.github.com/users/schisamo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schisamo/subscriptions","organizations_url":"https://api.github.com/users/schisamo/orgs","repos_url":"https://api.github.com/users/schisamo/repos","events_url":"https://api.github.com/users/schisamo/events{/privacy}","received_events_url":"https://api.github.com/users/schisamo/received_events","type":"User","site_admin":false},"body":"Are we punting on making all this match the project's install_dir?","created_at":"2014-08-14T16:55:22Z","updated_at":"2014-08-14T16:55:22Z","html_url":"https://github.com/opscode/omnibus/pull/306#discussion_r16250554","pull_request_url":"https://api.github.com/repos/opscode/omnibus/pulls/306","_links":{"self":{"href":"https://api.github.com/repos/opscode/omnibus/pulls/comments/16250554"},"html":{"href":"https://github.com/opscode/omnibus/pull/306#discussion_r16250554"},"pull_request":{"href":"https://api.github.com/repos/opscode/omnibus/pulls/306"}}},"pull_request":{"url":"https://api.github.com/repos/opscode/omnibus/pulls/306","id":19703968,"html_url":"https://github.com/opscode/omnibus/pull/306","diff_url":"https://github.com/opscode/omnibus/pull/306.diff","patch_url":"https://github.com/opscode/omnibus/pull/306.patch","issue_url":"https://api.github.com/repos/opscode/omnibus/issues/306","number":306,"state":"open","locked":false,"title":"Create packager-specific DSLs","user":{"login":"sethvargo","id":408570,"avatar_url":"https://avatars.githubusercontent.com/u/408570?v=2","gravatar_id":"87f282c6c2cdad13100dffe8c1daf77d","url":"https://api.github.com/users/sethvargo","html_url":"https://github.com/sethvargo","followers_url":"https://api.github.com/users/sethvargo/followers","following_url":"https://api.github.com/users/sethvargo/following{/other_user}","gists_url":"https://api.github.com/users/sethvargo/gists{/gist_id}","starred_url":"https://api.github.com/users/sethvargo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sethvargo/subscriptions","organizations_url":"https://api.github.com/users/sethvargo/orgs","repos_url":"https://api.github.com/users/sethvargo/repos","events_url":"https://api.github.com/users/sethvargo/events{/privacy}","received_events_url":"https://api.github.com/users/sethvargo/received_events","type":"User","site_admin":false},"body":":red_circle: :construction: :construction_worker: \r\n\r\nThis PR permits the user to define custom packagers on the project. For example:\r\n\r\n```ruby\r\nname 'chef'\r\n# ...\r\n\r\npackage :msi do\r\n  parameters upgrade_code: 'ABC-123'\r\nend\r\n\r\npackage :pkg do\r\n  identifier 'com.getchef.chef' # formerly Project#mac_pkg_identifier\r\n  signing_identity 'whatevs'\r\nend\r\n\r\npackage :rpm do\r\n  signing_passphrase ENV['SUPER_SECRET_PASSPHRASE']\r\nend\r\n```","created_at":"2014-08-13T04:01:56Z","updated_at":"2014-08-14T16:55:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6b71b996eea3ad2200f8ef74b3b80d8706849650","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/opscode/omnibus/pulls/306/commits","review_comments_url":"https://api.github.com/repos/opscode/omnibus/pulls/306/comments","review_comment_url":"https://api.github.com/repos/opscode/omnibus/pulls/comments/{number}","comments_url":"https://api.github.com/repos/opscode/omnibus/issues/306/comments","statuses_url":"https://api.github.com/repos/opscode/omnibus/statuses/0a9fb03e78ba8a91b96bef47b5e3f9903817dfd7","head":{"label":"opscode:sethvargo/packager_dsl","ref":"sethvargo/packager_dsl","sha":"0a9fb03e78ba8a91b96bef47b5e3f9903817dfd7","user":{"login":"opscode","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=2","gravatar_id":"890bf76f4dc18c12a19c55e988a1bd5e","url":"https://api.github.com/users/opscode","html_url":"https://github.com/opscode","followers_url":"https://api.github.com/users/opscode/followers","following_url":"https://api.github.com/users/opscode/following{/other_user}","gists_url":"https://api.github.com/users/opscode/gists{/gist_id}","starred_url":"https://api.github.com/users/opscode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opscode/subscriptions","organizations_url":"https://api.github.com/users/opscode/orgs","repos_url":"https://api.github.com/users/opscode/repos","events_url":"https://api.github.com/users/opscode/events{/privacy}","received_events_url":"https://api.github.com/users/opscode/received_events","type":"Organization","site_admin":false},"repo":{"id":3444030,"name":"omnibus","full_name":"opscode/omnibus","owner":{"login":"opscode","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=2","gravatar_id":"890bf76f4dc18c12a19c55e988a1bd5e","url":"https://api.github.com/users/opscode","html_url":"https://github.com/opscode","followers_url":"https://api.github.com/users/opscode/followers","following_url":"https://api.github.com/users/opscode/following{/other_user}","gists_url":"https://api.github.com/users/opscode/gists{/gist_id}","starred_url":"https://api.github.com/users/opscode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opscode/subscriptions","organizations_url":"https://api.github.com/users/opscode/orgs","repos_url":"https://api.github.com/users/opscode/repos","events_url":"https://api.github.com/users/opscode/events{/privacy}","received_events_url":"https://api.github.com/users/opscode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opscode/omnibus","description":"Easily create full-stack installers for your project across a variety of platforms.","fork":false,"url":"https://api.github.com/repos/opscode/omnibus","forks_url":"https://api.github.com/repos/opscode/omnibus/forks","keys_url":"https://api.github.com/repos/opscode/omnibus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opscode/omnibus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opscode/omnibus/teams","hooks_url":"https://api.github.com/repos/opscode/omnibus/hooks","issue_events_url":"https://api.github.com/repos/opscode/omnibus/issues/events{/number}","events_url":"https://api.github.com/repos/opscode/omnibus/events","assignees_url":"https://api.github.com/repos/opscode/omnibus/assignees{/user}","branches_url":"https://api.github.com/repos/opscode/omnibus/branches{/branch}","tags_url":"https://api.github.com/repos/opscode/omnibus/tags","blobs_url":"https://api.github.com/repos/opscode/omnibus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opscode/omnibus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opscode/omnibus/git/refs{/sha}","trees_url":"https://api.github.com/repos/opscode/omnibus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opscode/omnibus/statuses/{sha}","languages_url":"https://api.github.com/repos/opscode/omnibus/languages","stargazers_url":"https://api.github.com/repos/opscode/omnibus/stargazers","contributors_url":"https://api.github.com/repos/opscode/omnibus/contributors","subscribers_url":"https://api.github.com/repos/opscode/omnibus/subscribers","subscription_url":"https://api.github.com/repos/opscode/omnibus/subscription","commits_url":"https://api.github.com/repos/opscode/omnibus/commits{/sha}","git_commits_url":"https://api.github.com/repos/opscode/omnibus/git/commits{/sha}","comments_url":"https://api.github.com/repos/opscode/omnibus/comments{/number}","issue_comment_url":"https://api.github.com/repos/opscode/omnibus/issues/comments/{number}","contents_url":"https://api.github.com/repos/opscode/omnibus/contents/{+path}","compare_url":"https://api.github.com/repos/opscode/omnibus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opscode/omnibus/merges","archive_url":"https://api.github.com/repos/opscode/omnibus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opscode/omnibus/downloads","issues_url":"https://api.github.com/repos/opscode/omnibus/issues{/number}","pulls_url":"https://api.github.com/repos/opscode/omnibus/pulls{/number}","milestones_url":"https://api.github.com/repos/opscode/omnibus/milestones{/number}","notifications_url":"https://api.github.com/repos/opscode/omnibus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opscode/omnibus/labels{/name}","releases_url":"https://api.github.com/repos/opscode/omnibus/releases{/id}","created_at":"2012-02-14T21:15:35Z","updated_at":"2014-08-14T05:12:10Z","pushed_at":"2014-08-14T16:39:56Z","git_url":"git://github.com/opscode/omnibus.git","ssh_url":"git@github.com:opscode/omnibus.git","clone_url":"https://github.com/opscode/omnibus.git","svn_url":"https://github.com/opscode/omnibus","homepage":"","size":41628,"stargazers_count":284,"watchers_count":284,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":98,"mirror_url":null,"open_issues_count":9,"forks":98,"open_issues":9,"watchers":284,"default_branch":"master"}},"base":{"label":"opscode:master","ref":"master","sha":"215c8e9b4179dde72cf73c5bd8b5fd2e44c56cfd","user":{"login":"opscode","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=2","gravatar_id":"890bf76f4dc18c12a19c55e988a1bd5e","url":"https://api.github.com/users/opscode","html_url":"https://github.com/opscode","followers_url":"https://api.github.com/users/opscode/followers","following_url":"https://api.github.com/users/opscode/following{/other_user}","gists_url":"https://api.github.com/users/opscode/gists{/gist_id}","starred_url":"https://api.github.com/users/opscode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opscode/subscriptions","organizations_url":"https://api.github.com/users/opscode/orgs","repos_url":"https://api.github.com/users/opscode/repos","events_url":"https://api.github.com/users/opscode/events{/privacy}","received_events_url":"https://api.github.com/users/opscode/received_events","type":"Organization","site_admin":false},"repo":{"id":3444030,"name":"omnibus","full_name":"opscode/omnibus","owner":{"login":"opscode","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=2","gravatar_id":"890bf76f4dc18c12a19c55e988a1bd5e","url":"https://api.github.com/users/opscode","html_url":"https://github.com/opscode","followers_url":"https://api.github.com/users/opscode/followers","following_url":"https://api.github.com/users/opscode/following{/other_user}","gists_url":"https://api.github.com/users/opscode/gists{/gist_id}","starred_url":"https://api.github.com/users/opscode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opscode/subscriptions","organizations_url":"https://api.github.com/users/opscode/orgs","repos_url":"https://api.github.com/users/opscode/repos","events_url":"https://api.github.com/users/opscode/events{/privacy}","received_events_url":"https://api.github.com/users/opscode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opscode/omnibus","description":"Easily create full-stack installers for your project across a variety of platforms.","fork":false,"url":"https://api.github.com/repos/opscode/omnibus","forks_url":"https://api.github.com/repos/opscode/omnibus/forks","keys_url":"https://api.github.com/repos/opscode/omnibus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opscode/omnibus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opscode/omnibus/teams","hooks_url":"https://api.github.com/repos/opscode/omnibus/hooks","issue_events_url":"https://api.github.com/repos/opscode/omnibus/issues/events{/number}","events_url":"https://api.github.com/repos/opscode/omnibus/events","assignees_url":"https://api.github.com/repos/opscode/omnibus/assignees{/user}","branches_url":"https://api.github.com/repos/opscode/omnibus/branches{/branch}","tags_url":"https://api.github.com/repos/opscode/omnibus/tags","blobs_url":"https://api.github.com/repos/opscode/omnibus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opscode/omnibus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opscode/omnibus/git/refs{/sha}","trees_url":"https://api.github.com/repos/opscode/omnibus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opscode/omnibus/statuses/{sha}","languages_url":"https://api.github.com/repos/opscode/omnibus/languages","stargazers_url":"https://api.github.com/repos/opscode/omnibus/stargazers","contributors_url":"https://api.github.com/repos/opscode/omnibus/contributors","subscribers_url":"https://api.github.com/repos/opscode/omnibus/subscribers","subscription_url":"https://api.github.com/repos/opscode/omnibus/subscription","commits_url":"https://api.github.com/repos/opscode/omnibus/commits{/sha}","git_commits_url":"https://api.github.com/repos/opscode/omnibus/git/commits{/sha}","comments_url":"https://api.github.com/repos/opscode/omnibus/comments{/number}","issue_comment_url":"https://api.github.com/repos/opscode/omnibus/issues/comments/{number}","contents_url":"https://api.github.com/repos/opscode/omnibus/contents/{+path}","compare_url":"https://api.github.com/repos/opscode/omnibus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opscode/omnibus/merges","archive_url":"https://api.github.com/repos/opscode/omnibus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opscode/omnibus/downloads","issues_url":"https://api.github.com/repos/opscode/omnibus/issues{/number}","pulls_url":"https://api.github.com/repos/opscode/omnibus/pulls{/number}","milestones_url":"https://api.github.com/repos/opscode/omnibus/milestones{/number}","notifications_url":"https://api.github.com/repos/opscode/omnibus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opscode/omnibus/labels{/name}","releases_url":"https://api.github.com/repos/opscode/omnibus/releases{/id}","created_at":"2012-02-14T21:15:35Z","updated_at":"2014-08-14T05:12:10Z","pushed_at":"2014-08-14T16:39:56Z","git_url":"git://github.com/opscode/omnibus.git","ssh_url":"git@github.com:opscode/omnibus.git","clone_url":"https://github.com/opscode/omnibus.git","svn_url":"https://github.com/opscode/omnibus","homepage":"","size":41628,"stargazers_count":284,"watchers_count":284,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":98,"mirror_url":null,"open_issues_count":9,"forks":98,"open_issues":9,"watchers":284,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opscode/omnibus/pulls/306"},"html":{"href":"https://github.com/opscode/omnibus/pull/306"},"issue":{"href":"https://api.github.com/repos/opscode/omnibus/issues/306"},"comments":{"href":"https://api.github.com/repos/opscode/omnibus/issues/306/comments"},"review_comments":{"href":"https://api.github.com/repos/opscode/omnibus/pulls/306/comments"},"review_comment":{"href":"https://api.github.com/repos/opscode/omnibus/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/opscode/omnibus/pulls/306/commits"},"statuses":{"href":"https://api.github.com/repos/opscode/omnibus/statuses/0a9fb03e78ba8a91b96bef47b5e3f9903817dfd7"}}}}