GitHub PullRequestReviewCommentEvent at 2014-09-11 01:51:00
Repository: juju
Actor: davecheney
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/juju/juju/pulls/comments/17400498","id":17400498,"diff_hunk":"@@ -0,0 +1,118 @@\n+// Copyright 2014 Cloudbase Solutions SRL\n+// Copyright 2014 Canonical Ltd.\n+// Licensed under the AGPLv3, see LICENCE file for details.","path":"apiserver/reboot/rebootuniter.go","position":3,"original_position":3,"commit_id":"068926f3cfbc0462afc55d1cce07d322d68ff259","original_commit_id":"068926f3cfbc0462afc55d1cce07d322d68ff259","user":{"login":"davecheney","id":7171,"avatar_url":"https://avatars.githubusercontent.com/u/7171?v=2","gravatar_id":"fda08117336cfde6562315df04b976e8","url":"https://api.github.com/users/davecheney","html_url":"https://github.com/davecheney","followers_url":"https://api.github.com/users/davecheney/followers","following_url":"https://api.github.com/users/davecheney/following{/other_user}","gists_url":"https://api.github.com/users/davecheney/gists{/gist_id}","starred_url":"https://api.github.com/users/davecheney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davecheney/subscriptions","organizations_url":"https://api.github.com/users/davecheney/orgs","repos_url":"https://api.github.com/users/davecheney/repos","events_url":"https://api.github.com/users/davecheney/events{/privacy}","received_events_url":"https://api.github.com/users/davecheney/received_events","type":"User","site_admin":false},"body":"This logic is duplicated from above. Is it possible to consolidate it into apisever/common ?","created_at":"2014-09-11T01:51:00Z","updated_at":"2014-09-11T01:51:00Z","html_url":"https://github.com/juju/juju/pull/728#discussion_r17400498","pull_request_url":"https://api.github.com/repos/juju/juju/pulls/728","_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/comments/17400498"},"html":{"href":"https://github.com/juju/juju/pull/728#discussion_r17400498"},"pull_request":{"href":"https://api.github.com/repos/juju/juju/pulls/728"}}},"pull_request":{"url":"https://api.github.com/repos/juju/juju/pulls/728","id":21015811,"html_url":"https://github.com/juju/juju/pull/728","diff_url":"https://github.com/juju/juju/pull/728.diff","patch_url":"https://github.com/juju/juju/pull/728.patch","issue_url":"https://api.github.com/repos/juju/juju/issues/728","number":728,"state":"open","locked":false,"title":"WiP: Added apiserver endpoint for reboot","user":{"login":"gabriel-samfira","id":903160,"avatar_url":"https://avatars.githubusercontent.com/u/903160?v=2","gravatar_id":"13d9239250c467304917edc76a5af163","url":"https://api.github.com/users/gabriel-samfira","html_url":"https://github.com/gabriel-samfira","followers_url":"https://api.github.com/users/gabriel-samfira/followers","following_url":"https://api.github.com/users/gabriel-samfira/following{/other_user}","gists_url":"https://api.github.com/users/gabriel-samfira/gists{/gist_id}","starred_url":"https://api.github.com/users/gabriel-samfira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabriel-samfira/subscriptions","organizations_url":"https://api.github.com/users/gabriel-samfira/orgs","repos_url":"https://api.github.com/users/gabriel-samfira/repos","events_url":"https://api.github.com/users/gabriel-samfira/events{/privacy}","received_events_url":"https://api.github.com/users/gabriel-samfira/received_events","type":"User","site_admin":false},"body":"This is the second pull request for the reboot implementation. Please note that this is still a Work in Progress and a followup commit will be done for cleanup.\r\n\r\nThis branch depends on: https://github.com/juju/juju/pull/707","created_at":"2014-09-10T12:00:16Z","updated_at":"2014-09-11T01:51:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6d6265274b3cd6dd24738e3f560afd80be73bdec","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/juju/juju/pulls/728/commits","review_comments_url":"https://api.github.com/repos/juju/juju/pulls/728/comments","review_comment_url":"https://api.github.com/repos/juju/juju/pulls/comments/{number}","comments_url":"https://api.github.com/repos/juju/juju/issues/728/comments","statuses_url":"https://api.github.com/repos/juju/juju/statuses/068926f3cfbc0462afc55d1cce07d322d68ff259","head":{"label":"gabriel-samfira:reboot-api","ref":"reboot-api","sha":"068926f3cfbc0462afc55d1cce07d322d68ff259","user":{"login":"gabriel-samfira","id":903160,"avatar_url":"https://avatars.githubusercontent.com/u/903160?v=2","gravatar_id":"13d9239250c467304917edc76a5af163","url":"https://api.github.com/users/gabriel-samfira","html_url":"https://github.com/gabriel-samfira","followers_url":"https://api.github.com/users/gabriel-samfira/followers","following_url":"https://api.github.com/users/gabriel-samfira/following{/other_user}","gists_url":"https://api.github.com/users/gabriel-samfira/gists{/gist_id}","starred_url":"https://api.github.com/users/gabriel-samfira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabriel-samfira/subscriptions","organizations_url":"https://api.github.com/users/gabriel-samfira/orgs","repos_url":"https://api.github.com/users/gabriel-samfira/repos","events_url":"https://api.github.com/users/gabriel-samfira/events{/privacy}","received_events_url":"https://api.github.com/users/gabriel-samfira/received_events","type":"User","site_admin":false},"repo":{"id":20686648,"name":"juju","full_name":"gabriel-samfira/juju","owner":{"login":"gabriel-samfira","id":903160,"avatar_url":"https://avatars.githubusercontent.com/u/903160?v=2","gravatar_id":"13d9239250c467304917edc76a5af163","url":"https://api.github.com/users/gabriel-samfira","html_url":"https://github.com/gabriel-samfira","followers_url":"https://api.github.com/users/gabriel-samfira/followers","following_url":"https://api.github.com/users/gabriel-samfira/following{/other_user}","gists_url":"https://api.github.com/users/gabriel-samfira/gists{/gist_id}","starred_url":"https://api.github.com/users/gabriel-samfira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabriel-samfira/subscriptions","organizations_url":"https://api.github.com/users/gabriel-samfira/orgs","repos_url":"https://api.github.com/users/gabriel-samfira/repos","events_url":"https://api.github.com/users/gabriel-samfira/events{/privacy}","received_events_url":"https://api.github.com/users/gabriel-samfira/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gabriel-samfira/juju","description":"juju is devops distilled","fork":true,"url":"https://api.github.com/repos/gabriel-samfira/juju","forks_url":"https://api.github.com/repos/gabriel-samfira/juju/forks","keys_url":"https://api.github.com/repos/gabriel-samfira/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gabriel-samfira/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gabriel-samfira/juju/teams","hooks_url":"https://api.github.com/repos/gabriel-samfira/juju/hooks","issue_events_url":"https://api.github.com/repos/gabriel-samfira/juju/issues/events{/number}","events_url":"https://api.github.com/repos/gabriel-samfira/juju/events","assignees_url":"https://api.github.com/repos/gabriel-samfira/juju/assignees{/user}","branches_url":"https://api.github.com/repos/gabriel-samfira/juju/branches{/branch}","tags_url":"https://api.github.com/repos/gabriel-samfira/juju/tags","blobs_url":"https://api.github.com/repos/gabriel-samfira/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gabriel-samfira/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gabriel-samfira/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/gabriel-samfira/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gabriel-samfira/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/gabriel-samfira/juju/languages","stargazers_url":"https://api.github.com/repos/gabriel-samfira/juju/stargazers","contributors_url":"https://api.github.com/repos/gabriel-samfira/juju/contributors","subscribers_url":"https://api.github.com/repos/gabriel-samfira/juju/subscribers","subscription_url":"https://api.github.com/repos/gabriel-samfira/juju/subscription","commits_url":"https://api.github.com/repos/gabriel-samfira/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/gabriel-samfira/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/gabriel-samfira/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/gabriel-samfira/juju/issues/comments/{number}","contents_url":"https://api.github.com/repos/gabriel-samfira/juju/contents/{+path}","compare_url":"https://api.github.com/repos/gabriel-samfira/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gabriel-samfira/juju/merges","archive_url":"https://api.github.com/repos/gabriel-samfira/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gabriel-samfira/juju/downloads","issues_url":"https://api.github.com/repos/gabriel-samfira/juju/issues{/number}","pulls_url":"https://api.github.com/repos/gabriel-samfira/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/gabriel-samfira/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/gabriel-samfira/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gabriel-samfira/juju/labels{/name}","releases_url":"https://api.github.com/repos/gabriel-samfira/juju/releases{/id}","created_at":"2014-06-10T13:41:36Z","updated_at":"2014-08-01T13:48:50Z","pushed_at":"2014-09-10T17:04:37Z","git_url":"git://github.com/gabriel-samfira/juju.git","ssh_url":"git@github.com:gabriel-samfira/juju.git","clone_url":"https://github.com/gabriel-samfira/juju.git","svn_url":"https://github.com/gabriel-samfira/juju","homepage":"juju.ubuntu.com","size":30374,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"juju:master","ref":"master","sha":"5b7642200d450c1bf950fb9735b85166d922f095","user":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=2","gravatar_id":"b095d1e26e5705abe0ad2de7d87aac2e","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"repo":{"id":20445947,"name":"juju","full_name":"juju/juju","owner":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=2","gravatar_id":"b095d1e26e5705abe0ad2de7d87aac2e","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju/juju","description":"juju is devops distilled","fork":false,"url":"https://api.github.com/repos/juju/juju","forks_url":"https://api.github.com/repos/juju/juju/forks","keys_url":"https://api.github.com/repos/juju/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju/juju/teams","hooks_url":"https://api.github.com/repos/juju/juju/hooks","issue_events_url":"https://api.github.com/repos/juju/juju/issues/events{/number}","events_url":"https://api.github.com/repos/juju/juju/events","assignees_url":"https://api.github.com/repos/juju/juju/assignees{/user}","branches_url":"https://api.github.com/repos/juju/juju/branches{/branch}","tags_url":"https://api.github.com/repos/juju/juju/tags","blobs_url":"https://api.github.com/repos/juju/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/juju/juju/languages","stargazers_url":"https://api.github.com/repos/juju/juju/stargazers","contributors_url":"https://api.github.com/repos/juju/juju/contributors","subscribers_url":"https://api.github.com/repos/juju/juju/subscribers","subscription_url":"https://api.github.com/repos/juju/juju/subscription","commits_url":"https://api.github.com/repos/juju/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju/juju/issues/comments/{number}","contents_url":"https://api.github.com/repos/juju/juju/contents/{+path}","compare_url":"https://api.github.com/repos/juju/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju/juju/merges","archive_url":"https://api.github.com/repos/juju/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju/juju/downloads","issues_url":"https://api.github.com/repos/juju/juju/issues{/number}","pulls_url":"https://api.github.com/repos/juju/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/juju/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/juju/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju/juju/labels{/name}","releases_url":"https://api.github.com/repos/juju/juju/releases{/id}","created_at":"2014-06-03T14:28:10Z","updated_at":"2014-09-10T19:46:10Z","pushed_at":"2014-09-11T01:37:25Z","git_url":"git://github.com/juju/juju.git","ssh_url":"git@github.com:juju/juju.git","clone_url":"https://github.com/juju/juju.git","svn_url":"https://github.com/juju/juju","homepage":"juju.ubuntu.com","size":45016,"stargazers_count":204,"watchers_count":204,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":56,"mirror_url":null,"open_issues_count":51,"forks":56,"open_issues":51,"watchers":204,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/728"},"html":{"href":"https://github.com/juju/juju/pull/728"},"issue":{"href":"https://api.github.com/repos/juju/juju/issues/728"},"comments":{"href":"https://api.github.com/repos/juju/juju/issues/728/comments"},"review_comments":{"href":"https://api.github.com/repos/juju/juju/pulls/728/comments"},"review_comment":{"href":"https://api.github.com/repos/juju/juju/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/juju/juju/pulls/728/commits"},"statuses":{"href":"https://api.github.com/repos/juju/juju/statuses/068926f3cfbc0462afc55d1cce07d322d68ff259"}}}}