GitHub PullRequestReviewCommentEvent at 2014-03-13 16:27:29
Repository: pem
Actor: lvh
Payload: {"comment":{"url":"https://api.github.com/repos/hynek/pem/pulls/comments/10572547","id":10572547,"diff_hunk":"@@ -87,6 +87,27 @@ Therefore you can distribute your key, certificate, and chain certificates over\n A ``ValueError`` is raised if more than one key, no key, or no certificate are found.\n Any further keyword arguments will be passed to CertificateOptions_.\n \n+Ephemeral Diffie-Hellman support\n+--------------------------------\n+\n+Starting with version 14.0.0, Twisted will support ephemeral Diffie-Hellman ciphersuites; you can pass an instance of ``twisted.internet.ssl.OpenSSLDiffieHellmanParameters`` as the ``dhParams`` keyword argument to ``CertificateOptions``.\n+Since *pem* just passes keyword arguments to ``CertificateOptions`` verbatim, that will just work.\n+\n+However, *pem* is also forward compatible. Twisted 14.0.0 is not released yet, but *pem* lets you use the API described above anyway.\n+You can just use ``pem.OpenSSLDiffieHellmanParameters``. If your version of Twisted comes with that class, you just get the Twisted version. If it doesn't, you get a version from *pem*.","path":"README.rst","position":11,"original_position":11,"commit_id":"82dca2866a84558d2d6fec81b9269339db787ca2","original_commit_id":"1820bd281014cfdb7feb6c997e488eac289a926d","user":{"login":"lvh","id":97816,"avatar_url":"https://gravatar.com/avatar/415203f2727ceaf56d8f7f5e6d5d508b?d=https%3A%2F%2Fidenticons.github.com%2F1734a38adfa32f9bea1c2560f3d1ade7.png&r=x","gravatar_id":"415203f2727ceaf56d8f7f5e6d5d508b","url":"https://api.github.com/users/lvh","html_url":"https://github.com/lvh","followers_url":"https://api.github.com/users/lvh/followers","following_url":"https://api.github.com/users/lvh/following{/other_user}","gists_url":"https://api.github.com/users/lvh/gists{/gist_id}","starred_url":"https://api.github.com/users/lvh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lvh/subscriptions","organizations_url":"https://api.github.com/users/lvh/orgs","repos_url":"https://api.github.com/users/lvh/repos","events_url":"https://api.github.com/users/lvh/events{/privacy}","received_events_url":"https://api.github.com/users/lvh/received_events","type":"User","site_admin":false},"body":"Huh? Where? Thus line note appears to be in between two paragraphs. Do you mean in between the \"Ephemeral Diffie-Hellman support\" subsection and the next one?","created_at":"2014-03-13T16:27:29Z","updated_at":"2014-03-13T16:27:29Z","html_url":"https://github.com/hynek/pem/pull/2#discussion_r10572547","pull_request_url":"https://api.github.com/repos/hynek/pem/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/hynek/pem/pulls/comments/10572547"},"html":{"href":"https://github.com/hynek/pem/pull/2#discussion_r10572547"},"pull_request":{"href":"https://api.github.com/repos/hynek/pem/pulls/2"}}}}