GitHub PullRequestReviewCommentEvent at 2014-01-18 14:19:38
Repository: 3akai-ux
Actor: bp323
Payload: {"comment":{"url":"https://api.github.com/repos/oaeproject/3akai-ux/pulls/comments/8987867","id":8987867,"diff_hunk":"@@ -2,59 +2,64 @@\n <link rel=\"stylesheet\" type=\"text/css\" href=\"css/editgroup.css\" />\n \n <!-- MODAL -->\n-<div id=\"editgroup-modal\" class=\"modal hide fade\" tabindex=\"-1\" role=\"dialog\" aria-labelledby=\"editgroup-modal-title\" aria-hidden=\"true\">\n-    <div class=\"modal-header\">\n-        <button type=\"button\" class=\"close\" data-dismiss=\"modal\" aria-hidden=\"true\">&#215;</button>\n-        <h3 id=\"editgroup-modal-title\">__MSG__EDIT_DETAILS__</h3>\n-    </div>\n-    <form id=\"editgroup-form\">\n-        <div class=\"modal-body\">\n-            <div id=\"editgroup-metadata-container\"><!-- --></div>\n-            <div id=\"editgroup-joinable-container\"><!-- --></div>\n-        </div>\n-        <div class=\"modal-footer\">\n-            <button type=\"button\" class=\"btn btn-link pull-left\" data-dismiss=\"modal\">__MSG__CANCEL__</button>\n-            <button type=\"submit\" class=\"btn btn-primary pull-right\" disabled=\"true\">__MSG__SAVE__</button>\n+<div id=\"editgroup-modal\" class=\"modal fade\" tabindex=\"-1\" role=\"dialog\" aria-labelledby=\"editgroup-modal-title\" aria-hidden=\"true\">\n+    <div class=\"modal-dialog\">\n+        <div class=\"modal-content\">\n+            <div class=\"modal-header\">\n+                <button type=\"button\" class=\"close\" data-dismiss=\"modal\" aria-hidden=\"true\">&#215;</button>\n+                <h3 id=\"editgroup-modal-title\">__MSG__EDIT_DETAILS__</h3>\n+            </div>\n+            <form id=\"editgroup-form\" role=\"form\">\n+                <div class=\"modal-body\">\n+                    <div id=\"editgroup-metadata-container\"><!-- --></div>\n+                    <div id=\"editgroup-joinable-container\"><!-- --></div>\n+                </div>\n+                <div class=\"modal-footer\">\n+                    <button type=\"button\" class=\"btn btn-link pull-left\" data-dismiss=\"modal\">__MSG__CANCEL__</button>\n+                    <button type=\"submit\" class=\"btn btn-primary pull-right\" disabled=\"true\">__MSG__SAVE__</button>\n+                </div>\n+            </form>\n         </div>\n-    </form>\n+    </div>\n </div>\n \n <div id=\"editgroup-metadata-template\"><!--\n-    <div class=\"control-group\">\n-        <label for=\"editgroup-name\"><h4>__MSG__GROUP_NAME__</h4></label>\n-        <div class=\"controls\">\n-            <input type=\"text\" id=\"editgroup-name\" class=\"required maxlength-short\" placeholder=\"__MSG__WHAT_DO_YOU_WANT_TO_CALL_YOUR_GROUP__\" value=\"${group.displayName|encodeForHTMLAttribute}\"/>\n-        </div>\n+    <div class=\"form-group\">\n+        <label for=\"editgroup-name\" class=\"control-label\"><h4>__MSG__GROUP_NAME__</h4></label>\n+        <input type=\"text\" id=\"editgroup-name\" class=\"form-control required maxlength-short\" placeholder=\"__MSG__WHAT_DO_YOU_WANT_TO_CALL_YOUR_GROUP__\" value=\"${group.displayName|encodeForHTMLAttribute}\"/>\n     </div>\n-    <div class=\"control-group\">\n-        <label for=\"editgroup-description\"><h4>__MSG__GROUP_DESCRIPTION__</h4></label>\n-        <div class=\"controls\">\n-            <textarea id=\"editgroup-description\" class=\"maxlength-medium\" name=\"editgroup-description\" placeholder=\"__MSG__ENTER_A_GROUP_DESCRIPTION__\">${group.description|encodeForHTML}</textarea>\n-        </div>\n+    <div class=\"form-group\">\n+        <label for=\"editgroup-description\" class=\"control-label\"><h4>__MSG__GROUP_DESCRIPTION__</h4></label>\n+        <textarea id=\"editgroup-description\" class=\"form-control maxlength-medium\" name=\"editgroup-description\" placeholder=\"__MSG__ENTER_A_GROUP_DESCRIPTION__\" rows=\"3\">${group.description|encodeForHTML}</textarea>\n     </div>\n --></div>\n \n <div id=\"editgroup-joinable-template\"><!--\n     <h4>__MSG__JOIN_OPTIONS__</h4>\n-    <div class=\"oae-large-options-container row-fluid\">\n-        <label for=\"oae-joinable-no\" class=\"span6 text-center\">\n-            <div class=\"oae-large-options well pull-left text-center {if joinable === 'no'} checked{/if}\">\n-                <input type=\"radio\" id=\"oae-joinable-no\" value=\"no\" name=\"oae-joinable-group\" class=\"pull-left\" {if joinable === 'no'} checked=\"checked\"{/if} tabindex=\"0\"/>\n-                <i class=\"icon-ban-circle large text-center {if joinable === 'no'} selected{/if}\"></i>\n-                <span>__MSG__ONLY_MANAGERS_CAN_ADD_MEMBERS__</span>\n-            </div>\n-            <i class=\"icon-ok hide\"></i>\n-            <small>__MSG__GROUP_JOINABLE_MANAGERS_ADD_DESCRIPTION__</small>\n-        </label>\n-        <label for=\"oae-joinable-yes\" class=\"span6 text-center\">\n-            <div class=\"oae-large-options well pull-left text-center {if joinable === 'yes'} checked{/if}\">\n-                <input type=\"radio\" id=\"oae-joinable-yes\" value=\"yes\" name=\"oae-joinable-group\" class=\"pull-left\" {if joinable === 'yes'} checked=\"checked\"{/if} tabindex=\"0\"/>\n-                <i class=\"icon-star large text-center {if joinable === 'yes'} selected{/if}\"></i>\n-                <span>__MSG__ANYONE_CAN_JOIN__</span>\n-            </div>\n-            <i class=\"icon-ok hide\"></i>\n-            <small>__MSG__GROUP_JOINABLE_ANYONE_DESCRIPTION__</small>\n-        </label>\n+\n+    <div class=\"oae-large-options-container row\">\n+        <div class=\"col-md-6 text-center\">\n+            <label for=\"oae-joinable-no\" class=\"{if joinable === 'no'} checked{/if}\">\n+                <i class=\"icon-ok hide\"></i>\n+                <div class=\"oae-large-options well\">\n+                    <input type=\"radio\" id=\"oae-joinable-no\" value=\"no\" name=\"oae-joinable-group\" class=\"pull-left\" tabindex=\"0\"/>","path":"node_modules/oae-core/editgroup/editgroup.html","position":87,"original_position":87,"commit_id":"511a02367ce710d359bfc61aab83e1838af17f4f","original_commit_id":"aea71c5460101bea73b51e60cc6ac53403977530","user":{"login":"bp323","id":218391,"avatar_url":"https://gravatar.com/avatar/7937c2985aa325a2f1dd0de91432ed13?d=https%3A%2F%2Fidenticons.github.com%2Fc9018880abbbec21a7d55339467eaf52.png&r=x","gravatar_id":"7937c2985aa325a2f1dd0de91432ed13","url":"https://api.github.com/users/bp323","html_url":"https://github.com/bp323","followers_url":"https://api.github.com/users/bp323/followers","following_url":"https://api.github.com/users/bp323/following{/other_user}","gists_url":"https://api.github.com/users/bp323/gists{/gist_id}","starred_url":"https://api.github.com/users/bp323/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bp323/subscriptions","organizations_url":"https://api.github.com/users/bp323/orgs","repos_url":"https://api.github.com/users/bp323/repos","events_url":"https://api.github.com/users/bp323/events{/privacy}","received_events_url":"https://api.github.com/users/bp323/received_events","type":"User","site_admin":false},"body":"The selected class is defined in the skin and applies to this icon specifically. The designs didn't specify a color change for the creategroup selected privacy option.","created_at":"2014-01-18T14:19:38Z","updated_at":"2014-01-18T14:19:38Z","html_url":"https://github.com/oaeproject/3akai-ux/pull/3178#discussion_r8987867","pull_request_url":"https://api.github.com/repos/oaeproject/3akai-ux/pulls/3178","_links":{"self":{"href":"https://api.github.com/repos/oaeproject/3akai-ux/pulls/comments/8987867"},"html":{"href":"https://github.com/oaeproject/3akai-ux/pull/3178#discussion_r8987867"},"pull_request":{"href":"https://api.github.com/repos/oaeproject/3akai-ux/pulls/3178"}}}}