GitHub PullRequestReviewCommentEvent at 2014-10-23 08:20:49
Repository: marathon
Actor: drexin
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mesosphere/marathon/pulls/comments/19264322","id":19264322,"diff_hunk":"@@ -5,6 +5,7 @@ import javax.inject.Inject\n import java.lang.{ Integer => JInt }\n import scala.concurrent.Future\n import scala.util.{ Failure, Success }\n+import scala.collection.immutable.Seq","path":"src/main/scala/mesosphere/marathon/state/GroupManager.scala","position":4,"original_position":4,"commit_id":"f7eb61cfd5afa4ac5532d1c506afb4e7ca6ffe80","original_commit_id":"f7eb61cfd5afa4ac5532d1c506afb4e7ca6ffe80","user":{"login":"drexin","id":433020,"avatar_url":"https://avatars.githubusercontent.com/u/433020?v=2","gravatar_id":"","url":"https://api.github.com/users/drexin","html_url":"https://github.com/drexin","followers_url":"https://api.github.com/users/drexin/followers","following_url":"https://api.github.com/users/drexin/following{/other_user}","gists_url":"https://api.github.com/users/drexin/gists{/gist_id}","starred_url":"https://api.github.com/users/drexin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drexin/subscriptions","organizations_url":"https://api.github.com/users/drexin/orgs","repos_url":"https://api.github.com/users/drexin/repos","events_url":"https://api.github.com/users/drexin/events{/privacy}","received_events_url":"https://api.github.com/users/drexin/received_events","type":"User","site_admin":false},"body":":+1: ","created_at":"2014-10-23T08:20:49Z","updated_at":"2014-10-23T08:20:49Z","html_url":"https://github.com/mesosphere/marathon/pull/735#discussion_r19264322","pull_request_url":"https://api.github.com/repos/mesosphere/marathon/pulls/735","_links":{"self":{"href":"https://api.github.com/repos/mesosphere/marathon/pulls/comments/19264322"},"html":{"href":"https://github.com/mesosphere/marathon/pull/735#discussion_r19264322"},"pull_request":{"href":"https://api.github.com/repos/mesosphere/marathon/pulls/735"}}},"pull_request":{"url":"https://api.github.com/repos/mesosphere/marathon/pulls/735","id":23210934,"html_url":"https://github.com/mesosphere/marathon/pull/735","diff_url":"https://github.com/mesosphere/marathon/pull/735.diff","patch_url":"https://github.com/mesosphere/marathon/pull/735.patch","issue_url":"https://api.github.com/repos/mesosphere/marathon/issues/735","number":735,"state":"open","locked":false,"title":"Replace random service ports in docker mappings.","user":{"login":"ConnorDoyle","id":379372,"avatar_url":"https://avatars.githubusercontent.com/u/379372?v=2","gravatar_id":"","url":"https://api.github.com/users/ConnorDoyle","html_url":"https://github.com/ConnorDoyle","followers_url":"https://api.github.com/users/ConnorDoyle/followers","following_url":"https://api.github.com/users/ConnorDoyle/following{/other_user}","gists_url":"https://api.github.com/users/ConnorDoyle/gists{/gist_id}","starred_url":"https://api.github.com/users/ConnorDoyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ConnorDoyle/subscriptions","organizations_url":"https://api.github.com/users/ConnorDoyle/orgs","repos_url":"https://api.github.com/users/ConnorDoyle/repos","events_url":"https://api.github.com/users/ConnorDoyle/events{/privacy}","received_events_url":"https://api.github.com/users/ConnorDoyle/received_events","type":"User","site_admin":false},"body":"- Fixes #714\r\n\r\nAfter the fix:\r\n\r\n_application/json_\r\n\r\n```http\r\nGET /v2/tasks HTTP/1.1\r\nAccept: */*\r\nAccept-Encoding: gzip, deflate\r\nHost: mesos.vm:8080\r\nUser-Agent: HTTPie/0.8.0\r\n```\r\n\r\n```http\r\nHTTP/1.1 200 OK\r\nContent-Type: application/json\r\nServer: Jetty(8.y.z-SNAPSHOT)\r\nTransfer-Encoding: chunked\r\n\r\n{\r\n    \"tasks\": [\r\n        {\r\n            \"appId\": \"/bridged-webapp\", \r\n            \"healthCheckResults\": [\r\n                {\r\n                    \"alive\": true, \r\n                    \"consecutiveFailures\": 0, \r\n                    \"firstSuccess\": \"2014-10-23T07:00:50.753Z\", \r\n                    \"lastFailure\": null, \r\n                    \"lastSuccess\": \"2014-10-23T07:05:50.203Z\", \r\n                    \"taskId\": \"bridged-webapp.4cef0b11-5a82-11e4-9c31-ba49ee782560\"\r\n                }, \r\n                {\r\n                    \"alive\": true, \r\n                    \"consecutiveFailures\": 0, \r\n                    \"firstSuccess\": \"2014-10-23T07:00:44.010Z\", \r\n                    \"lastFailure\": null, \r\n                    \"lastSuccess\": \"2014-10-23T07:00:44.010Z\", \r\n                    \"taskId\": \"bridged-webapp.4cef0b11-5a82-11e4-9c31-ba49ee782560\"\r\n                }\r\n            ], \r\n            \"host\": \"10.141.141.10\", \r\n            \"id\": \"bridged-webapp.4cef0b11-5a82-11e4-9c31-ba49ee782560\", \r\n            \"ports\": [\r\n                31002, \r\n                31003\r\n            ], \r\n            \"servicePorts\": [\r\n                9000, \r\n                10000\r\n            ], \r\n            \"stagedAt\": \"2014-10-23T07:00:41.099Z\", \r\n            \"startedAt\": \"2014-10-23T07:05:41.494Z\", \r\n            \"version\": \"2014-10-23T07:00:29.594Z\"\r\n        }, \r\n        {\r\n            \"appId\": \"/bridged-webapp\", \r\n            \"healthCheckResults\": [\r\n                {\r\n                    \"alive\": true, \r\n                    \"consecutiveFailures\": 0, \r\n                    \"firstSuccess\": \"2014-10-23T07:00:50.750Z\", \r\n                    \"lastFailure\": null, \r\n                    \"lastSuccess\": \"2014-10-23T07:05:50.212Z\", \r\n                    \"taskId\": \"bridged-webapp.495d0aaf-5a82-11e4-9c31-ba49ee782560\"\r\n                }, \r\n                {\r\n                    \"alive\": true, \r\n                    \"consecutiveFailures\": 0, \r\n                    \"firstSuccess\": \"2014-10-23T07:00:38.009Z\", \r\n                    \"lastFailure\": null, \r\n                    \"lastSuccess\": \"2014-10-23T07:00:38.009Z\", \r\n                    \"taskId\": \"bridged-webapp.495d0aaf-5a82-11e4-9c31-ba49ee782560\"\r\n                }\r\n            ], \r\n            \"host\": \"10.141.141.10\", \r\n            \"id\": \"bridged-webapp.495d0aaf-5a82-11e4-9c31-ba49ee782560\", \r\n            \"ports\": [\r\n                31000, \r\n                31001\r\n            ], \r\n            \"servicePorts\": [\r\n                9000, \r\n                10000\r\n            ], \r\n            \"stagedAt\": \"2014-10-23T07:00:35.141Z\", \r\n            \"startedAt\": \"2014-10-23T07:05:41.503Z\", \r\n            \"version\": \"2014-10-23T07:00:29.594Z\"\r\n        }\r\n    ]\r\n}\r\n```\r\n\r\n_text/plain_\r\n\r\n```http\r\nGET /v2/tasks HTTP/1.1\r\nAccept: text/plain\r\nAccept-Encoding: gzip, deflate\r\nHost: mesos.vm:8080\r\nUser-Agent: HTTPie/0.8.0\r\n```\r\n\r\n```http\r\nHTTP/1.1 200 OK\r\nContent-Type: text/plain\r\nServer: Jetty(8.y.z-SNAPSHOT)\r\nTransfer-Encoding: chunked\r\n\r\nbridged-webapp\t9000\t10.141.141.10:31002\t10.141.141.10:31000\t\r\nbridged-webapp\t10000\t10.141.141.10:31003\t10.141.141.10:31001\r\n```","created_at":"2014-10-23T07:33:05Z","updated_at":"2014-10-23T08:20:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d1dc7f2976faa61ea27c12156cf5030b7d79d05f","assignee":{"login":"drexin","id":433020,"avatar_url":"https://avatars.githubusercontent.com/u/433020?v=2","gravatar_id":"","url":"https://api.github.com/users/drexin","html_url":"https://github.com/drexin","followers_url":"https://api.github.com/users/drexin/followers","following_url":"https://api.github.com/users/drexin/following{/other_user}","gists_url":"https://api.github.com/users/drexin/gists{/gist_id}","starred_url":"https://api.github.com/users/drexin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drexin/subscriptions","organizations_url":"https://api.github.com/users/drexin/orgs","repos_url":"https://api.github.com/users/drexin/repos","events_url":"https://api.github.com/users/drexin/events{/privacy}","received_events_url":"https://api.github.com/users/drexin/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/mesosphere/marathon/milestones/11","labels_url":"https://api.github.com/repos/mesosphere/marathon/milestones/11/labels","id":812598,"number":11,"title":"0.7.4","description":"","creator":{"login":"ConnorDoyle","id":379372,"avatar_url":"https://avatars.githubusercontent.com/u/379372?v=2","gravatar_id":"","url":"https://api.github.com/users/ConnorDoyle","html_url":"https://github.com/ConnorDoyle","followers_url":"https://api.github.com/users/ConnorDoyle/followers","following_url":"https://api.github.com/users/ConnorDoyle/following{/other_user}","gists_url":"https://api.github.com/users/ConnorDoyle/gists{/gist_id}","starred_url":"https://api.github.com/users/ConnorDoyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ConnorDoyle/subscriptions","organizations_url":"https://api.github.com/users/ConnorDoyle/orgs","repos_url":"https://api.github.com/users/ConnorDoyle/repos","events_url":"https://api.github.com/users/ConnorDoyle/events{/privacy}","received_events_url":"https://api.github.com/users/ConnorDoyle/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":17,"state":"open","created_at":"2014-10-03T13:28:49Z","updated_at":"2014-10-23T07:37:21Z","due_on":"2014-10-10T07:00:00Z"},"commits_url":"https://api.github.com/repos/mesosphere/marathon/pulls/735/commits","review_comments_url":"https://api.github.com/repos/mesosphere/marathon/pulls/735/comments","review_comment_url":"https://api.github.com/repos/mesosphere/marathon/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mesosphere/marathon/issues/735/comments","statuses_url":"https://api.github.com/repos/mesosphere/marathon/statuses/f7eb61cfd5afa4ac5532d1c506afb4e7ca6ffe80","head":{"label":"mesosphere:714-bridge-random-service-ports","ref":"714-bridge-random-service-ports","sha":"f7eb61cfd5afa4ac5532d1c506afb4e7ca6ffe80","user":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars.githubusercontent.com/u/3458585?v=2","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":10941409,"name":"marathon","full_name":"mesosphere/marathon","owner":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars.githubusercontent.com/u/3458585?v=2","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesosphere/marathon","description":"Cluster-wide init and control system (or PaaS layer) for services in cgroups or Docker containers based on Apache Mesos.","fork":false,"url":"https://api.github.com/repos/mesosphere/marathon","forks_url":"https://api.github.com/repos/mesosphere/marathon/forks","keys_url":"https://api.github.com/repos/mesosphere/marathon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesosphere/marathon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesosphere/marathon/teams","hooks_url":"https://api.github.com/repos/mesosphere/marathon/hooks","issue_events_url":"https://api.github.com/repos/mesosphere/marathon/issues/events{/number}","events_url":"https://api.github.com/repos/mesosphere/marathon/events","assignees_url":"https://api.github.com/repos/mesosphere/marathon/assignees{/user}","branches_url":"https://api.github.com/repos/mesosphere/marathon/branches{/branch}","tags_url":"https://api.github.com/repos/mesosphere/marathon/tags","blobs_url":"https://api.github.com/repos/mesosphere/marathon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesosphere/marathon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesosphere/marathon/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesosphere/marathon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesosphere/marathon/statuses/{sha}","languages_url":"https://api.github.com/repos/mesosphere/marathon/languages","stargazers_url":"https://api.github.com/repos/mesosphere/marathon/stargazers","contributors_url":"https://api.github.com/repos/mesosphere/marathon/contributors","subscribers_url":"https://api.github.com/repos/mesosphere/marathon/subscribers","subscription_url":"https://api.github.com/repos/mesosphere/marathon/subscription","commits_url":"https://api.github.com/repos/mesosphere/marathon/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesosphere/marathon/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesosphere/marathon/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesosphere/marathon/issues/comments/{number}","contents_url":"https://api.github.com/repos/mesosphere/marathon/contents/{+path}","compare_url":"https://api.github.com/repos/mesosphere/marathon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesosphere/marathon/merges","archive_url":"https://api.github.com/repos/mesosphere/marathon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesosphere/marathon/downloads","issues_url":"https://api.github.com/repos/mesosphere/marathon/issues{/number}","pulls_url":"https://api.github.com/repos/mesosphere/marathon/pulls{/number}","milestones_url":"https://api.github.com/repos/mesosphere/marathon/milestones{/number}","notifications_url":"https://api.github.com/repos/mesosphere/marathon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesosphere/marathon/labels{/name}","releases_url":"https://api.github.com/repos/mesosphere/marathon/releases{/id}","created_at":"2013-06-25T14:56:34Z","updated_at":"2014-10-23T04:23:03Z","pushed_at":"2014-10-23T07:32:48Z","git_url":"git://github.com/mesosphere/marathon.git","ssh_url":"git@github.com:mesosphere/marathon.git","clone_url":"https://github.com/mesosphere/marathon.git","svn_url":"https://github.com/mesosphere/marathon","homepage":"https://mesosphere.github.io/marathon/","size":17482,"stargazers_count":788,"watchers_count":788,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":153,"mirror_url":null,"open_issues_count":86,"forks":153,"open_issues":86,"watchers":788,"default_branch":"master"}},"base":{"label":"mesosphere:master","ref":"master","sha":"41a6bd79aaefd074523ffa85e8cf16a8c2b8418d","user":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars.githubusercontent.com/u/3458585?v=2","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":10941409,"name":"marathon","full_name":"mesosphere/marathon","owner":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars.githubusercontent.com/u/3458585?v=2","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesosphere/marathon","description":"Cluster-wide init and control system (or PaaS layer) for services in cgroups or Docker containers based on Apache Mesos.","fork":false,"url":"https://api.github.com/repos/mesosphere/marathon","forks_url":"https://api.github.com/repos/mesosphere/marathon/forks","keys_url":"https://api.github.com/repos/mesosphere/marathon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesosphere/marathon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesosphere/marathon/teams","hooks_url":"https://api.github.com/repos/mesosphere/marathon/hooks","issue_events_url":"https://api.github.com/repos/mesosphere/marathon/issues/events{/number}","events_url":"https://api.github.com/repos/mesosphere/marathon/events","assignees_url":"https://api.github.com/repos/mesosphere/marathon/assignees{/user}","branches_url":"https://api.github.com/repos/mesosphere/marathon/branches{/branch}","tags_url":"https://api.github.com/repos/mesosphere/marathon/tags","blobs_url":"https://api.github.com/repos/mesosphere/marathon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesosphere/marathon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesosphere/marathon/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesosphere/marathon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesosphere/marathon/statuses/{sha}","languages_url":"https://api.github.com/repos/mesosphere/marathon/languages","stargazers_url":"https://api.github.com/repos/mesosphere/marathon/stargazers","contributors_url":"https://api.github.com/repos/mesosphere/marathon/contributors","subscribers_url":"https://api.github.com/repos/mesosphere/marathon/subscribers","subscription_url":"https://api.github.com/repos/mesosphere/marathon/subscription","commits_url":"https://api.github.com/repos/mesosphere/marathon/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesosphere/marathon/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesosphere/marathon/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesosphere/marathon/issues/comments/{number}","contents_url":"https://api.github.com/repos/mesosphere/marathon/contents/{+path}","compare_url":"https://api.github.com/repos/mesosphere/marathon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesosphere/marathon/merges","archive_url":"https://api.github.com/repos/mesosphere/marathon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesosphere/marathon/downloads","issues_url":"https://api.github.com/repos/mesosphere/marathon/issues{/number}","pulls_url":"https://api.github.com/repos/mesosphere/marathon/pulls{/number}","milestones_url":"https://api.github.com/repos/mesosphere/marathon/milestones{/number}","notifications_url":"https://api.github.com/repos/mesosphere/marathon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesosphere/marathon/labels{/name}","releases_url":"https://api.github.com/repos/mesosphere/marathon/releases{/id}","created_at":"2013-06-25T14:56:34Z","updated_at":"2014-10-23T04:23:03Z","pushed_at":"2014-10-23T07:32:48Z","git_url":"git://github.com/mesosphere/marathon.git","ssh_url":"git@github.com:mesosphere/marathon.git","clone_url":"https://github.com/mesosphere/marathon.git","svn_url":"https://github.com/mesosphere/marathon","homepage":"https://mesosphere.github.io/marathon/","size":17482,"stargazers_count":788,"watchers_count":788,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":153,"mirror_url":null,"open_issues_count":86,"forks":153,"open_issues":86,"watchers":788,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mesosphere/marathon/pulls/735"},"html":{"href":"https://github.com/mesosphere/marathon/pull/735"},"issue":{"href":"https://api.github.com/repos/mesosphere/marathon/issues/735"},"comments":{"href":"https://api.github.com/repos/mesosphere/marathon/issues/735/comments"},"review_comments":{"href":"https://api.github.com/repos/mesosphere/marathon/pulls/735/comments"},"review_comment":{"href":"https://api.github.com/repos/mesosphere/marathon/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mesosphere/marathon/pulls/735/commits"},"statuses":{"href":"https://api.github.com/repos/mesosphere/marathon/statuses/f7eb61cfd5afa4ac5532d1c506afb4e7ca6ffe80"}}}}