GitHub PullRequestReviewCommentEvent at 2014-12-02 08:14:37
Repository: jbosstools-base
Actor: maxandersen
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/jbosstools/jbosstools-base/pulls/comments/21144696","id":21144696,"diff_hunk":"@@ -23,6 +23,24 @@\n \t\t\t</resource>\n \t\t</resources>\n \t\t<plugins>\n+      <!-- get major.minor.incremental from root pom, then use devstudio.version = ${parsedVersion.majorVersion}.${parsedVersion.minorVersion}.${parsedVersion.incrementalVersion}.${BUILD_ALIAS} -->\n+      <plugin>\n+        <groupId>org.codehaus.mojo</groupId>\n+        <artifactId>build-helper-maven-plugin</artifactId>\n+        <version>1.9.1</version>\n+        <executions>\n+          <execution>\n+            <phase>validate</phase>\n+            <id>parse-version</id>\n+            <goals>\n+              <goal>parse-version</goal>\n+            </goals>\n+            <configuration>\n+              <versionString>${project.parent.parent.parent.version}</versionString>","path":"foundation/plugins/org.jboss.tools.foundation.core/pom.xml","position":17,"original_position":17,"commit_id":"25b38fefde6108eab008f4251f3eac77d3db7a56","original_commit_id":"25b38fefde6108eab008f4251f3eac77d3db7a56","user":{"login":"maxandersen","id":54129,"avatar_url":"https://avatars.githubusercontent.com/u/54129?v=3","gravatar_id":"","url":"https://api.github.com/users/maxandersen","html_url":"https://github.com/maxandersen","followers_url":"https://api.github.com/users/maxandersen/followers","following_url":"https://api.github.com/users/maxandersen/following{/other_user}","gists_url":"https://api.github.com/users/maxandersen/gists{/gist_id}","starred_url":"https://api.github.com/users/maxandersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxandersen/subscriptions","organizations_url":"https://api.github.com/users/maxandersen/orgs","repos_url":"https://api.github.com/users/maxandersen/repos","events_url":"https://api.github.com/users/maxandersen/events{/privacy}","received_events_url":"https://api.github.com/users/maxandersen/received_events","type":"User","site_admin":false},"body":"eh - how is this then not still dependent on the parent pom version ? \r\n","created_at":"2014-12-02T08:14:37Z","updated_at":"2014-12-02T08:14:37Z","html_url":"https://github.com/jbosstools/jbosstools-base/pull/360#discussion_r21144696","pull_request_url":"https://api.github.com/repos/jbosstools/jbosstools-base/pulls/360","_links":{"self":{"href":"https://api.github.com/repos/jbosstools/jbosstools-base/pulls/comments/21144696"},"html":{"href":"https://github.com/jbosstools/jbosstools-base/pull/360#discussion_r21144696"},"pull_request":{"href":"https://api.github.com/repos/jbosstools/jbosstools-base/pulls/360"}}},"pull_request":{"url":"https://api.github.com/repos/jbosstools/jbosstools-base/pulls/360","id":25304962,"html_url":"https://github.com/jbosstools/jbosstools-base/pull/360","diff_url":"https://github.com/jbosstools/jbosstools-base/pull/360.diff","patch_url":"https://github.com/jbosstools/jbosstools-base/pull/360.patch","issue_url":"https://api.github.com/repos/jbosstools/jbosstools-base/issues/360","number":360,"state":"open","locked":false,"title":"JBIDE-18837 use Base root pom instead of parent pom so we only depend on BUILD ALIAS and not the root pom version >> master","user":{"login":"nickboldt","id":227597,"avatar_url":"https://avatars.githubusercontent.com/u/227597?v=3","gravatar_id":"","url":"https://api.github.com/users/nickboldt","html_url":"https://github.com/nickboldt","followers_url":"https://api.github.com/users/nickboldt/followers","following_url":"https://api.github.com/users/nickboldt/following{/other_user}","gists_url":"https://api.github.com/users/nickboldt/gists{/gist_id}","starred_url":"https://api.github.com/users/nickboldt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickboldt/subscriptions","organizations_url":"https://api.github.com/users/nickboldt/orgs","repos_url":"https://api.github.com/users/nickboldt/repos","events_url":"https://api.github.com/users/nickboldt/events{/privacy}","received_events_url":"https://api.github.com/users/nickboldt/received_events","type":"User","site_admin":false},"body":null,"created_at":"2014-12-01T22:41:16Z","updated_at":"2014-12-02T08:14:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f615d998504f5db5073903941562f0061da32965","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jbosstools/jbosstools-base/pulls/360/commits","review_comments_url":"https://api.github.com/repos/jbosstools/jbosstools-base/pulls/360/comments","review_comment_url":"https://api.github.com/repos/jbosstools/jbosstools-base/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jbosstools/jbosstools-base/issues/360/comments","statuses_url":"https://api.github.com/repos/jbosstools/jbosstools-base/statuses/25b38fefde6108eab008f4251f3eac77d3db7a56","head":{"label":"nickboldt:JBIDE-18837_use_root_m","ref":"JBIDE-18837_use_root_m","sha":"25b38fefde6108eab008f4251f3eac77d3db7a56","user":{"login":"nickboldt","id":227597,"avatar_url":"https://avatars.githubusercontent.com/u/227597?v=3","gravatar_id":"","url":"https://api.github.com/users/nickboldt","html_url":"https://github.com/nickboldt","followers_url":"https://api.github.com/users/nickboldt/followers","following_url":"https://api.github.com/users/nickboldt/following{/other_user}","gists_url":"https://api.github.com/users/nickboldt/gists{/gist_id}","starred_url":"https://api.github.com/users/nickboldt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickboldt/subscriptions","organizations_url":"https://api.github.com/users/nickboldt/orgs","repos_url":"https://api.github.com/users/nickboldt/repos","events_url":"https://api.github.com/users/nickboldt/events{/privacy}","received_events_url":"https://api.github.com/users/nickboldt/received_events","type":"User","site_admin":false},"repo":{"id":6358697,"name":"jbosstools-base","full_name":"nickboldt/jbosstools-base","owner":{"login":"nickboldt","id":227597,"avatar_url":"https://avatars.githubusercontent.com/u/227597?v=3","gravatar_id":"","url":"https://api.github.com/users/nickboldt","html_url":"https://github.com/nickboldt","followers_url":"https://api.github.com/users/nickboldt/followers","following_url":"https://api.github.com/users/nickboldt/following{/other_user}","gists_url":"https://api.github.com/users/nickboldt/gists{/gist_id}","starred_url":"https://api.github.com/users/nickboldt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickboldt/subscriptions","organizations_url":"https://api.github.com/users/nickboldt/orgs","repos_url":"https://api.github.com/users/nickboldt/repos","events_url":"https://api.github.com/users/nickboldt/events{/privacy}","received_events_url":"https://api.github.com/users/nickboldt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nickboldt/jbosstools-base","description":"JBoss Tools :: Base { common, runtime, tests, usage }","fork":true,"url":"https://api.github.com/repos/nickboldt/jbosstools-base","forks_url":"https://api.github.com/repos/nickboldt/jbosstools-base/forks","keys_url":"https://api.github.com/repos/nickboldt/jbosstools-base/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nickboldt/jbosstools-base/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nickboldt/jbosstools-base/teams","hooks_url":"https://api.github.com/repos/nickboldt/jbosstools-base/hooks","issue_events_url":"https://api.github.com/repos/nickboldt/jbosstools-base/issues/events{/number}","events_url":"https://api.github.com/repos/nickboldt/jbosstools-base/events","assignees_url":"https://api.github.com/repos/nickboldt/jbosstools-base/assignees{/user}","branches_url":"https://api.github.com/repos/nickboldt/jbosstools-base/branches{/branch}","tags_url":"https://api.github.com/repos/nickboldt/jbosstools-base/tags","blobs_url":"https://api.github.com/repos/nickboldt/jbosstools-base/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nickboldt/jbosstools-base/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nickboldt/jbosstools-base/git/refs{/sha}","trees_url":"https://api.github.com/repos/nickboldt/jbosstools-base/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nickboldt/jbosstools-base/statuses/{sha}","languages_url":"https://api.github.com/repos/nickboldt/jbosstools-base/languages","stargazers_url":"https://api.github.com/repos/nickboldt/jbosstools-base/stargazers","contributors_url":"https://api.github.com/repos/nickboldt/jbosstools-base/contributors","subscribers_url":"https://api.github.com/repos/nickboldt/jbosstools-base/subscribers","subscription_url":"https://api.github.com/repos/nickboldt/jbosstools-base/subscription","commits_url":"https://api.github.com/repos/nickboldt/jbosstools-base/commits{/sha}","git_commits_url":"https://api.github.com/repos/nickboldt/jbosstools-base/git/commits{/sha}","comments_url":"https://api.github.com/repos/nickboldt/jbosstools-base/comments{/number}","issue_comment_url":"https://api.github.com/repos/nickboldt/jbosstools-base/issues/comments/{number}","contents_url":"https://api.github.com/repos/nickboldt/jbosstools-base/contents/{+path}","compare_url":"https://api.github.com/repos/nickboldt/jbosstools-base/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nickboldt/jbosstools-base/merges","archive_url":"https://api.github.com/repos/nickboldt/jbosstools-base/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nickboldt/jbosstools-base/downloads","issues_url":"https://api.github.com/repos/nickboldt/jbosstools-base/issues{/number}","pulls_url":"https://api.github.com/repos/nickboldt/jbosstools-base/pulls{/number}","milestones_url":"https://api.github.com/repos/nickboldt/jbosstools-base/milestones{/number}","notifications_url":"https://api.github.com/repos/nickboldt/jbosstools-base/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nickboldt/jbosstools-base/labels{/name}","releases_url":"https://api.github.com/repos/nickboldt/jbosstools-base/releases{/id}","created_at":"2012-10-23T19:40:44Z","updated_at":"2014-08-28T16:37:23Z","pushed_at":"2014-12-01T22:41:16Z","git_url":"git://github.com/nickboldt/jbosstools-base.git","ssh_url":"git@github.com:nickboldt/jbosstools-base.git","clone_url":"https://github.com/nickboldt/jbosstools-base.git","svn_url":"https://github.com/nickboldt/jbosstools-base","homepage":"","size":64286,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jbosstools:master","ref":"master","sha":"e5e5ca8b58b57364aac56054ba090e43cbed25d7","user":{"login":"jbosstools","id":619871,"avatar_url":"https://avatars.githubusercontent.com/u/619871?v=3","gravatar_id":"","url":"https://api.github.com/users/jbosstools","html_url":"https://github.com/jbosstools","followers_url":"https://api.github.com/users/jbosstools/followers","following_url":"https://api.github.com/users/jbosstools/following{/other_user}","gists_url":"https://api.github.com/users/jbosstools/gists{/gist_id}","starred_url":"https://api.github.com/users/jbosstools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbosstools/subscriptions","organizations_url":"https://api.github.com/users/jbosstools/orgs","repos_url":"https://api.github.com/users/jbosstools/repos","events_url":"https://api.github.com/users/jbosstools/events{/privacy}","received_events_url":"https://api.github.com/users/jbosstools/received_events","type":"Organization","site_admin":false},"repo":{"id":6308266,"name":"jbosstools-base","full_name":"jbosstools/jbosstools-base","owner":{"login":"jbosstools","id":619871,"avatar_url":"https://avatars.githubusercontent.com/u/619871?v=3","gravatar_id":"","url":"https://api.github.com/users/jbosstools","html_url":"https://github.com/jbosstools","followers_url":"https://api.github.com/users/jbosstools/followers","following_url":"https://api.github.com/users/jbosstools/following{/other_user}","gists_url":"https://api.github.com/users/jbosstools/gists{/gist_id}","starred_url":"https://api.github.com/users/jbosstools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbosstools/subscriptions","organizations_url":"https://api.github.com/users/jbosstools/orgs","repos_url":"https://api.github.com/users/jbosstools/repos","events_url":"https://api.github.com/users/jbosstools/events{/privacy}","received_events_url":"https://api.github.com/users/jbosstools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jbosstools/jbosstools-base","description":"JBoss Tools :: Base { common, runtime, tests, usage }","fork":false,"url":"https://api.github.com/repos/jbosstools/jbosstools-base","forks_url":"https://api.github.com/repos/jbosstools/jbosstools-base/forks","keys_url":"https://api.github.com/repos/jbosstools/jbosstools-base/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jbosstools/jbosstools-base/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jbosstools/jbosstools-base/teams","hooks_url":"https://api.github.com/repos/jbosstools/jbosstools-base/hooks","issue_events_url":"https://api.github.com/repos/jbosstools/jbosstools-base/issues/events{/number}","events_url":"https://api.github.com/repos/jbosstools/jbosstools-base/events","assignees_url":"https://api.github.com/repos/jbosstools/jbosstools-base/assignees{/user}","branches_url":"https://api.github.com/repos/jbosstools/jbosstools-base/branches{/branch}","tags_url":"https://api.github.com/repos/jbosstools/jbosstools-base/tags","blobs_url":"https://api.github.com/repos/jbosstools/jbosstools-base/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jbosstools/jbosstools-base/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jbosstools/jbosstools-base/git/refs{/sha}","trees_url":"https://api.github.com/repos/jbosstools/jbosstools-base/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jbosstools/jbosstools-base/statuses/{sha}","languages_url":"https://api.github.com/repos/jbosstools/jbosstools-base/languages","stargazers_url":"https://api.github.com/repos/jbosstools/jbosstools-base/stargazers","contributors_url":"https://api.github.com/repos/jbosstools/jbosstools-base/contributors","subscribers_url":"https://api.github.com/repos/jbosstools/jbosstools-base/subscribers","subscription_url":"https://api.github.com/repos/jbosstools/jbosstools-base/subscription","commits_url":"https://api.github.com/repos/jbosstools/jbosstools-base/commits{/sha}","git_commits_url":"https://api.github.com/repos/jbosstools/jbosstools-base/git/commits{/sha}","comments_url":"https://api.github.com/repos/jbosstools/jbosstools-base/comments{/number}","issue_comment_url":"https://api.github.com/repos/jbosstools/jbosstools-base/issues/comments/{number}","contents_url":"https://api.github.com/repos/jbosstools/jbosstools-base/contents/{+path}","compare_url":"https://api.github.com/repos/jbosstools/jbosstools-base/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jbosstools/jbosstools-base/merges","archive_url":"https://api.github.com/repos/jbosstools/jbosstools-base/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jbosstools/jbosstools-base/downloads","issues_url":"https://api.github.com/repos/jbosstools/jbosstools-base/issues{/number}","pulls_url":"https://api.github.com/repos/jbosstools/jbosstools-base/pulls{/number}","milestones_url":"https://api.github.com/repos/jbosstools/jbosstools-base/milestones{/number}","notifications_url":"https://api.github.com/repos/jbosstools/jbosstools-base/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jbosstools/jbosstools-base/labels{/name}","releases_url":"https://api.github.com/repos/jbosstools/jbosstools-base/releases{/id}","created_at":"2012-10-20T11:22:45Z","updated_at":"2014-11-27T20:55:12Z","pushed_at":"2014-11-30T09:39:40Z","git_url":"git://github.com/jbosstools/jbosstools-base.git","ssh_url":"git@github.com:jbosstools/jbosstools-base.git","clone_url":"https://github.com/jbosstools/jbosstools-base.git","svn_url":"https://github.com/jbosstools/jbosstools-base","homepage":"","size":68989,"stargazers_count":7,"watchers_count":7,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":3,"forks":31,"open_issues":3,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jbosstools/jbosstools-base/pulls/360"},"html":{"href":"https://github.com/jbosstools/jbosstools-base/pull/360"},"issue":{"href":"https://api.github.com/repos/jbosstools/jbosstools-base/issues/360"},"comments":{"href":"https://api.github.com/repos/jbosstools/jbosstools-base/issues/360/comments"},"review_comments":{"href":"https://api.github.com/repos/jbosstools/jbosstools-base/pulls/360/comments"},"review_comment":{"href":"https://api.github.com/repos/jbosstools/jbosstools-base/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jbosstools/jbosstools-base/pulls/360/commits"},"statuses":{"href":"https://api.github.com/repos/jbosstools/jbosstools-base/statuses/25b38fefde6108eab008f4251f3eac77d3db7a56"}}}}