GitHub PullRequestReviewCommentEvent at 2014-11-25 22:31:10
Repository: httpie
Actor: jakubroztocil
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/jakubroztocil/httpie/pulls/comments/20902172","id":20902172,"diff_hunk":"@@ -0,0 +1,54 @@\n+import socket\n+\n+from requests.adapters import HTTPAdapter\n+from requests.compat import urlparse, unquote","path":"httpie/adapters.py","position":4,"original_position":4,"commit_id":"1b13eb3af97fac71276e9af29e8c5d8c883234a1","original_commit_id":"1b13eb3af97fac71276e9af29e8c5d8c883234a1","user":{"login":"jakubroztocil","id":326885,"avatar_url":"https://avatars.githubusercontent.com/u/326885?v=3","gravatar_id":"","url":"https://api.github.com/users/jakubroztocil","html_url":"https://github.com/jakubroztocil","followers_url":"https://api.github.com/users/jakubroztocil/followers","following_url":"https://api.github.com/users/jakubroztocil/following{/other_user}","gists_url":"https://api.github.com/users/jakubroztocil/gists{/gist_id}","starred_url":"https://api.github.com/users/jakubroztocil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakubroztocil/subscriptions","organizations_url":"https://api.github.com/users/jakubroztocil/orgs","repos_url":"https://api.github.com/users/jakubroztocil/repos","events_url":"https://api.github.com/users/jakubroztocil/events{/privacy}","received_events_url":"https://api.github.com/users/jakubroztocil/received_events","type":"User","site_admin":false},"body":"Btw, there is also `httpie.compat`  and it's what is used elsewhere in HTTPie. Could you use it as a proxy to import these two functions? Basically it just needs to be added here: https://github.com/msabramo/httpie/blob/1b13eb3af97fac71276e9af29e8c5d8c883234a1/httpie/compat.py#L7","created_at":"2014-11-25T22:31:10Z","updated_at":"2014-11-25T22:31:10Z","html_url":"https://github.com/jakubroztocil/httpie/pull/276#discussion_r20902172","pull_request_url":"https://api.github.com/repos/jakubroztocil/httpie/pulls/276","_links":{"self":{"href":"https://api.github.com/repos/jakubroztocil/httpie/pulls/comments/20902172"},"html":{"href":"https://github.com/jakubroztocil/httpie/pull/276#discussion_r20902172"},"pull_request":{"href":"https://api.github.com/repos/jakubroztocil/httpie/pulls/276"}}},"pull_request":{"url":"https://api.github.com/repos/jakubroztocil/httpie/pulls/276","id":24980872,"html_url":"https://github.com/jakubroztocil/httpie/pull/276","diff_url":"https://github.com/jakubroztocil/httpie/pull/276.diff","patch_url":"https://github.com/jakubroztocil/httpie/pull/276.patch","issue_url":"https://api.github.com/repos/jakubroztocil/httpie/issues/276","number":276,"state":"open","locked":false,"title":"Add support for unix domain sockets","user":{"login":"msabramo","id":305268,"avatar_url":"https://avatars.githubusercontent.com/u/305268?v=3","gravatar_id":"","url":"https://api.github.com/users/msabramo","html_url":"https://github.com/msabramo","followers_url":"https://api.github.com/users/msabramo/followers","following_url":"https://api.github.com/users/msabramo/following{/other_user}","gists_url":"https://api.github.com/users/msabramo/gists{/gist_id}","starred_url":"https://api.github.com/users/msabramo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msabramo/subscriptions","organizations_url":"https://api.github.com/users/msabramo/orgs","repos_url":"https://api.github.com/users/msabramo/repos","events_url":"https://api.github.com/users/msabramo/events{/privacy}","received_events_url":"https://api.github.com/users/msabramo/received_events","type":"User","site_admin":false},"body":"adapted from some code from [docker-py](https://github.com/docker/docker-py):\r\n\r\n* https://github.com/docker/docker-py/blob/master/docker/unixconn/unixconn.py\r\n\r\nAlso submitted this `UnixAdapter` code to `requests` as https://github.com/kennethreitz/requests/pull/2355, but this PR was [declined](https://github.com/kennethreitz/requests/pull/2355#issuecomment-64299663), as the `requests` maintainers do not want to maintain this feature.\r\n\r\n#### Screenshot\r\n\r\n![screen shot 2014-11-24 at 6 35 24 pm](https://cloud.githubusercontent.com/assets/305268/5177115/dba014c6-7408-11e4-8376-78a57a39909b.png)\r\n\r\nFixes: GH-209 (https://github.com/jakubroztocil/httpie/issues/209)\r\n\r\nCc: @shin-, @jakubroztocil, @monsanto, @np, @nuxlli, @matrixise, @remmelt","created_at":"2014-11-25T02:29:22Z","updated_at":"2014-11-25T22:31:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"94217d4340cad4c575cf2aca7429cac3b8e32877","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jakubroztocil/httpie/pulls/276/commits","review_comments_url":"https://api.github.com/repos/jakubroztocil/httpie/pulls/276/comments","review_comment_url":"https://api.github.com/repos/jakubroztocil/httpie/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jakubroztocil/httpie/issues/276/comments","statuses_url":"https://api.github.com/repos/jakubroztocil/httpie/statuses/1b13eb3af97fac71276e9af29e8c5d8c883234a1","head":{"label":"msabramo:unix_domain_sockets","ref":"unix_domain_sockets","sha":"1b13eb3af97fac71276e9af29e8c5d8c883234a1","user":{"login":"msabramo","id":305268,"avatar_url":"https://avatars.githubusercontent.com/u/305268?v=3","gravatar_id":"","url":"https://api.github.com/users/msabramo","html_url":"https://github.com/msabramo","followers_url":"https://api.github.com/users/msabramo/followers","following_url":"https://api.github.com/users/msabramo/following{/other_user}","gists_url":"https://api.github.com/users/msabramo/gists{/gist_id}","starred_url":"https://api.github.com/users/msabramo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msabramo/subscriptions","organizations_url":"https://api.github.com/users/msabramo/orgs","repos_url":"https://api.github.com/users/msabramo/repos","events_url":"https://api.github.com/users/msabramo/events{/privacy}","received_events_url":"https://api.github.com/users/msabramo/received_events","type":"User","site_admin":false},"repo":{"id":4553493,"name":"httpie","full_name":"msabramo/httpie","owner":{"login":"msabramo","id":305268,"avatar_url":"https://avatars.githubusercontent.com/u/305268?v=3","gravatar_id":"","url":"https://api.github.com/users/msabramo","html_url":"https://github.com/msabramo","followers_url":"https://api.github.com/users/msabramo/followers","following_url":"https://api.github.com/users/msabramo/following{/other_user}","gists_url":"https://api.github.com/users/msabramo/gists{/gist_id}","starred_url":"https://api.github.com/users/msabramo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msabramo/subscriptions","organizations_url":"https://api.github.com/users/msabramo/orgs","repos_url":"https://api.github.com/users/msabramo/repos","events_url":"https://api.github.com/users/msabramo/events{/privacy}","received_events_url":"https://api.github.com/users/msabramo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/msabramo/httpie","description":"HTTPie is a CLI, cURL-like tool for humans ","fork":true,"url":"https://api.github.com/repos/msabramo/httpie","forks_url":"https://api.github.com/repos/msabramo/httpie/forks","keys_url":"https://api.github.com/repos/msabramo/httpie/keys{/key_id}","collaborators_url":"https://api.github.com/repos/msabramo/httpie/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/msabramo/httpie/teams","hooks_url":"https://api.github.com/repos/msabramo/httpie/hooks","issue_events_url":"https://api.github.com/repos/msabramo/httpie/issues/events{/number}","events_url":"https://api.github.com/repos/msabramo/httpie/events","assignees_url":"https://api.github.com/repos/msabramo/httpie/assignees{/user}","branches_url":"https://api.github.com/repos/msabramo/httpie/branches{/branch}","tags_url":"https://api.github.com/repos/msabramo/httpie/tags","blobs_url":"https://api.github.com/repos/msabramo/httpie/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/msabramo/httpie/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/msabramo/httpie/git/refs{/sha}","trees_url":"https://api.github.com/repos/msabramo/httpie/git/trees{/sha}","statuses_url":"https://api.github.com/repos/msabramo/httpie/statuses/{sha}","languages_url":"https://api.github.com/repos/msabramo/httpie/languages","stargazers_url":"https://api.github.com/repos/msabramo/httpie/stargazers","contributors_url":"https://api.github.com/repos/msabramo/httpie/contributors","subscribers_url":"https://api.github.com/repos/msabramo/httpie/subscribers","subscription_url":"https://api.github.com/repos/msabramo/httpie/subscription","commits_url":"https://api.github.com/repos/msabramo/httpie/commits{/sha}","git_commits_url":"https://api.github.com/repos/msabramo/httpie/git/commits{/sha}","comments_url":"https://api.github.com/repos/msabramo/httpie/comments{/number}","issue_comment_url":"https://api.github.com/repos/msabramo/httpie/issues/comments/{number}","contents_url":"https://api.github.com/repos/msabramo/httpie/contents/{+path}","compare_url":"https://api.github.com/repos/msabramo/httpie/compare/{base}...{head}","merges_url":"https://api.github.com/repos/msabramo/httpie/merges","archive_url":"https://api.github.com/repos/msabramo/httpie/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/msabramo/httpie/downloads","issues_url":"https://api.github.com/repos/msabramo/httpie/issues{/number}","pulls_url":"https://api.github.com/repos/msabramo/httpie/pulls{/number}","milestones_url":"https://api.github.com/repos/msabramo/httpie/milestones{/number}","notifications_url":"https://api.github.com/repos/msabramo/httpie/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/msabramo/httpie/labels{/name}","releases_url":"https://api.github.com/repos/msabramo/httpie/releases{/id}","created_at":"2012-06-04T22:57:11Z","updated_at":"2013-01-09T12:35:47Z","pushed_at":"2014-11-25T07:45:35Z","git_url":"git://github.com/msabramo/httpie.git","ssh_url":"git@github.com:msabramo/httpie.git","clone_url":"https://github.com/msabramo/httpie.git","svn_url":"https://github.com/msabramo/httpie","homepage":"http://httpie.org","size":3098,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"jakubroztocil:master","ref":"master","sha":"04819577154fc1b11fc20ae7ac584d67614eca25","user":{"login":"jakubroztocil","id":326885,"avatar_url":"https://avatars.githubusercontent.com/u/326885?v=3","gravatar_id":"","url":"https://api.github.com/users/jakubroztocil","html_url":"https://github.com/jakubroztocil","followers_url":"https://api.github.com/users/jakubroztocil/followers","following_url":"https://api.github.com/users/jakubroztocil/following{/other_user}","gists_url":"https://api.github.com/users/jakubroztocil/gists{/gist_id}","starred_url":"https://api.github.com/users/jakubroztocil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakubroztocil/subscriptions","organizations_url":"https://api.github.com/users/jakubroztocil/orgs","repos_url":"https://api.github.com/users/jakubroztocil/repos","events_url":"https://api.github.com/users/jakubroztocil/events{/privacy}","received_events_url":"https://api.github.com/users/jakubroztocil/received_events","type":"User","site_admin":false},"repo":{"id":3544424,"name":"httpie","full_name":"jakubroztocil/httpie","owner":{"login":"jakubroztocil","id":326885,"avatar_url":"https://avatars.githubusercontent.com/u/326885?v=3","gravatar_id":"","url":"https://api.github.com/users/jakubroztocil","html_url":"https://github.com/jakubroztocil","followers_url":"https://api.github.com/users/jakubroztocil/followers","following_url":"https://api.github.com/users/jakubroztocil/following{/other_user}","gists_url":"https://api.github.com/users/jakubroztocil/gists{/gist_id}","starred_url":"https://api.github.com/users/jakubroztocil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakubroztocil/subscriptions","organizations_url":"https://api.github.com/users/jakubroztocil/orgs","repos_url":"https://api.github.com/users/jakubroztocil/repos","events_url":"https://api.github.com/users/jakubroztocil/events{/privacy}","received_events_url":"https://api.github.com/users/jakubroztocil/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jakubroztocil/httpie","description":"HTTPie is a command line HTTP client, a user-friendly cURL replacement.","fork":false,"url":"https://api.github.com/repos/jakubroztocil/httpie","forks_url":"https://api.github.com/repos/jakubroztocil/httpie/forks","keys_url":"https://api.github.com/repos/jakubroztocil/httpie/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jakubroztocil/httpie/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jakubroztocil/httpie/teams","hooks_url":"https://api.github.com/repos/jakubroztocil/httpie/hooks","issue_events_url":"https://api.github.com/repos/jakubroztocil/httpie/issues/events{/number}","events_url":"https://api.github.com/repos/jakubroztocil/httpie/events","assignees_url":"https://api.github.com/repos/jakubroztocil/httpie/assignees{/user}","branches_url":"https://api.github.com/repos/jakubroztocil/httpie/branches{/branch}","tags_url":"https://api.github.com/repos/jakubroztocil/httpie/tags","blobs_url":"https://api.github.com/repos/jakubroztocil/httpie/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jakubroztocil/httpie/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jakubroztocil/httpie/git/refs{/sha}","trees_url":"https://api.github.com/repos/jakubroztocil/httpie/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jakubroztocil/httpie/statuses/{sha}","languages_url":"https://api.github.com/repos/jakubroztocil/httpie/languages","stargazers_url":"https://api.github.com/repos/jakubroztocil/httpie/stargazers","contributors_url":"https://api.github.com/repos/jakubroztocil/httpie/contributors","subscribers_url":"https://api.github.com/repos/jakubroztocil/httpie/subscribers","subscription_url":"https://api.github.com/repos/jakubroztocil/httpie/subscription","commits_url":"https://api.github.com/repos/jakubroztocil/httpie/commits{/sha}","git_commits_url":"https://api.github.com/repos/jakubroztocil/httpie/git/commits{/sha}","comments_url":"https://api.github.com/repos/jakubroztocil/httpie/comments{/number}","issue_comment_url":"https://api.github.com/repos/jakubroztocil/httpie/issues/comments/{number}","contents_url":"https://api.github.com/repos/jakubroztocil/httpie/contents/{+path}","compare_url":"https://api.github.com/repos/jakubroztocil/httpie/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jakubroztocil/httpie/merges","archive_url":"https://api.github.com/repos/jakubroztocil/httpie/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jakubroztocil/httpie/downloads","issues_url":"https://api.github.com/repos/jakubroztocil/httpie/issues{/number}","pulls_url":"https://api.github.com/repos/jakubroztocil/httpie/pulls{/number}","milestones_url":"https://api.github.com/repos/jakubroztocil/httpie/milestones{/number}","notifications_url":"https://api.github.com/repos/jakubroztocil/httpie/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jakubroztocil/httpie/labels{/name}","releases_url":"https://api.github.com/repos/jakubroztocil/httpie/releases{/id}","created_at":"2012-02-25T12:39:13Z","updated_at":"2014-11-25T18:47:46Z","pushed_at":"2014-10-20T12:41:52Z","git_url":"git://github.com/jakubroztocil/httpie.git","ssh_url":"git@github.com:jakubroztocil/httpie.git","clone_url":"https://github.com/jakubroztocil/httpie.git","svn_url":"https://github.com/jakubroztocil/httpie","homepage":"httpie.org","size":5367,"stargazers_count":12367,"watchers_count":12367,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":708,"mirror_url":null,"open_issues_count":62,"forks":708,"open_issues":62,"watchers":12367,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jakubroztocil/httpie/pulls/276"},"html":{"href":"https://github.com/jakubroztocil/httpie/pull/276"},"issue":{"href":"https://api.github.com/repos/jakubroztocil/httpie/issues/276"},"comments":{"href":"https://api.github.com/repos/jakubroztocil/httpie/issues/276/comments"},"review_comments":{"href":"https://api.github.com/repos/jakubroztocil/httpie/pulls/276/comments"},"review_comment":{"href":"https://api.github.com/repos/jakubroztocil/httpie/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jakubroztocil/httpie/pulls/276/commits"},"statuses":{"href":"https://api.github.com/repos/jakubroztocil/httpie/statuses/1b13eb3af97fac71276e9af29e8c5d8c883234a1"}}}}