GitHub PullRequestReviewCommentEvent at 2014-06-10 17:46:26
Repository: JavascriptAggregator
Actor: chuckdumont
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/OpenNTF/JavascriptAggregator/pulls/comments/13608177","id":13608177,"diff_hunk":"@@ -0,0 +1,90 @@\n+/*\r\n+ * (C) Copyright 2012, IBM Corporation\r\n+ *\r\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\r\n+ * you may not use this file except in compliance with the License.\r\n+ * You may obtain a copy of the License at\r\n+ *\r\n+ *     http://www.apache.org/licenses/LICENSE-2.0\r\n+ *\r\n+ * Unless required by applicable law or agreed to in writing, software\r\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\r\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\r\n+ * See the License for the specific language governing permissions and\r\n+ * limitations under the License.\r\n+ */\r\n+\r\n+package com.ibm.jaggr.core.impl.resource;\r\n+\r\n+import java.net.URI;\r\n+import java.net.URL;\r\n+import java.util.ArrayList;\r\n+import java.util.HashMap;\r\n+import java.util.List;\r\n+import java.util.Map;\r\n+import java.util.zip.ZipEntry;\r\n+import java.util.zip.ZipInputStream;\r\n+\r\n+import com.ibm.jaggr.core.resource.IResource;\r\n+import com.ibm.jaggr.core.resource.IResourceFactory;\r\n+\r\n+/**\r\n+ * Default implementation for {@link IResourceFactory} that currently supports\r\n+ * only file resources.\r\n+ */\r\n+public class JarResourceFactory implements IResourceFactory {\r","path":"jaggr-core/src/main/java/com/ibm/jaggr/core/impl/resource/JarResourceFactory.java","position":35,"original_position":35,"commit_id":"937da24d5d86bc687dc1548025518ed1696be3d3","original_commit_id":"937da24d5d86bc687dc1548025518ed1696be3d3","user":{"login":"chuckdumont","id":273476,"avatar_url":"https://avatars.githubusercontent.com/u/273476?","gravatar_id":"8b58e7a6f6964ec6a40bb5994704bd30","url":"https://api.github.com/users/chuckdumont","html_url":"https://github.com/chuckdumont","followers_url":"https://api.github.com/users/chuckdumont/followers","following_url":"https://api.github.com/users/chuckdumont/following{/other_user}","gists_url":"https://api.github.com/users/chuckdumont/gists{/gist_id}","starred_url":"https://api.github.com/users/chuckdumont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chuckdumont/subscriptions","organizations_url":"https://api.github.com/users/chuckdumont/orgs","repos_url":"https://api.github.com/users/chuckdumont/repos","events_url":"https://api.github.com/users/chuckdumont/events{/privacy}","received_events_url":"https://api.github.com/users/chuckdumont/received_events","type":"User","site_admin":false},"body":"Same thing here.  This class needs to be combined with ClassPathResourceFactory to remove duplicate code.","created_at":"2014-06-10T17:46:26Z","updated_at":"2014-06-10T17:46:26Z","html_url":"https://github.com/OpenNTF/JavascriptAggregator/pull/182#discussion_r13608177","pull_request_url":"https://api.github.com/repos/OpenNTF/JavascriptAggregator/pulls/182","_links":{"self":{"href":"https://api.github.com/repos/OpenNTF/JavascriptAggregator/pulls/comments/13608177"},"html":{"href":"https://github.com/OpenNTF/JavascriptAggregator/pull/182#discussion_r13608177"},"pull_request":{"href":"https://api.github.com/repos/OpenNTF/JavascriptAggregator/pulls/182"}}},"pull_request":{"url":"https://api.github.com/repos/OpenNTF/JavascriptAggregator/pulls/182","id":16862230,"html_url":"https://github.com/OpenNTF/JavascriptAggregator/pull/182","diff_url":"https://github.com/OpenNTF/JavascriptAggregator/pull/182.diff","patch_url":"https://github.com/OpenNTF/JavascriptAggregator/pull/182.patch","issue_url":"https://api.github.com/repos/OpenNTF/JavascriptAggregator/issues/182","number":182,"state":"open","title":"ClassPathResource factory and JarResource Factory","user":{"login":"projsaha","id":2566417,"avatar_url":"https://avatars.githubusercontent.com/u/2566417?","gravatar_id":"5e2fa9f6bd9f0a0af1fb7b011084855c","url":"https://api.github.com/users/projsaha","html_url":"https://github.com/projsaha","followers_url":"https://api.github.com/users/projsaha/followers","following_url":"https://api.github.com/users/projsaha/following{/other_user}","gists_url":"https://api.github.com/users/projsaha/gists{/gist_id}","starred_url":"https://api.github.com/users/projsaha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projsaha/subscriptions","organizations_url":"https://api.github.com/users/projsaha/orgs","repos_url":"https://api.github.com/users/projsaha/repos","events_url":"https://api.github.com/users/projsaha/events{/privacy}","received_events_url":"https://api.github.com/users/projsaha/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-06-08T11:11:17Z","updated_at":"2014-06-10T17:46:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b92e4edfefb16b0e54f4817857d68ffba0e59167","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OpenNTF/JavascriptAggregator/pulls/182/commits","review_comments_url":"https://api.github.com/repos/OpenNTF/JavascriptAggregator/pulls/182/comments","review_comment_url":"https://api.github.com/repos/OpenNTF/JavascriptAggregator/pulls/comments/{number}","comments_url":"https://api.github.com/repos/OpenNTF/JavascriptAggregator/issues/182/comments","statuses_url":"https://api.github.com/repos/OpenNTF/JavascriptAggregator/statuses/937da24d5d86bc687dc1548025518ed1696be3d3","head":{"label":"projsaha:JAGGR_master_merge_3","ref":"JAGGR_master_merge_3","sha":"937da24d5d86bc687dc1548025518ed1696be3d3","user":{"login":"projsaha","id":2566417,"avatar_url":"https://avatars.githubusercontent.com/u/2566417?","gravatar_id":"5e2fa9f6bd9f0a0af1fb7b011084855c","url":"https://api.github.com/users/projsaha","html_url":"https://github.com/projsaha","followers_url":"https://api.github.com/users/projsaha/followers","following_url":"https://api.github.com/users/projsaha/following{/other_user}","gists_url":"https://api.github.com/users/projsaha/gists{/gist_id}","starred_url":"https://api.github.com/users/projsaha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projsaha/subscriptions","organizations_url":"https://api.github.com/users/projsaha/orgs","repos_url":"https://api.github.com/users/projsaha/repos","events_url":"https://api.github.com/users/projsaha/events{/privacy}","received_events_url":"https://api.github.com/users/projsaha/received_events","type":"User","site_admin":false},"repo":{"id":12729798,"name":"JavascriptAggregator","full_name":"projsaha/JavascriptAggregator","owner":{"login":"projsaha","id":2566417,"avatar_url":"https://avatars.githubusercontent.com/u/2566417?","gravatar_id":"5e2fa9f6bd9f0a0af1fb7b011084855c","url":"https://api.github.com/users/projsaha","html_url":"https://github.com/projsaha","followers_url":"https://api.github.com/users/projsaha/followers","following_url":"https://api.github.com/users/projsaha/following{/other_user}","gists_url":"https://api.github.com/users/projsaha/gists{/gist_id}","starred_url":"https://api.github.com/users/projsaha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projsaha/subscriptions","organizations_url":"https://api.github.com/users/projsaha/orgs","repos_url":"https://api.github.com/users/projsaha/repos","events_url":"https://api.github.com/users/projsaha/events{/privacy}","received_events_url":"https://api.github.com/users/projsaha/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/projsaha/JavascriptAggregator","description":"OpenNTF Javascript Aggregator project","fork":true,"url":"https://api.github.com/repos/projsaha/JavascriptAggregator","forks_url":"https://api.github.com/repos/projsaha/JavascriptAggregator/forks","keys_url":"https://api.github.com/repos/projsaha/JavascriptAggregator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projsaha/JavascriptAggregator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projsaha/JavascriptAggregator/teams","hooks_url":"https://api.github.com/repos/projsaha/JavascriptAggregator/hooks","issue_events_url":"https://api.github.com/repos/projsaha/JavascriptAggregator/issues/events{/number}","events_url":"https://api.github.com/repos/projsaha/JavascriptAggregator/events","assignees_url":"https://api.github.com/repos/projsaha/JavascriptAggregator/assignees{/user}","branches_url":"https://api.github.com/repos/projsaha/JavascriptAggregator/branches{/branch}","tags_url":"https://api.github.com/repos/projsaha/JavascriptAggregator/tags","blobs_url":"https://api.github.com/repos/projsaha/JavascriptAggregator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projsaha/JavascriptAggregator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projsaha/JavascriptAggregator/git/refs{/sha}","trees_url":"https://api.github.com/repos/projsaha/JavascriptAggregator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projsaha/JavascriptAggregator/statuses/{sha}","languages_url":"https://api.github.com/repos/projsaha/JavascriptAggregator/languages","stargazers_url":"https://api.github.com/repos/projsaha/JavascriptAggregator/stargazers","contributors_url":"https://api.github.com/repos/projsaha/JavascriptAggregator/contributors","subscribers_url":"https://api.github.com/repos/projsaha/JavascriptAggregator/subscribers","subscription_url":"https://api.github.com/repos/projsaha/JavascriptAggregator/subscription","commits_url":"https://api.github.com/repos/projsaha/JavascriptAggregator/commits{/sha}","git_commits_url":"https://api.github.com/repos/projsaha/JavascriptAggregator/git/commits{/sha}","comments_url":"https://api.github.com/repos/projsaha/JavascriptAggregator/comments{/number}","issue_comment_url":"https://api.github.com/repos/projsaha/JavascriptAggregator/issues/comments/{number}","contents_url":"https://api.github.com/repos/projsaha/JavascriptAggregator/contents/{+path}","compare_url":"https://api.github.com/repos/projsaha/JavascriptAggregator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projsaha/JavascriptAggregator/merges","archive_url":"https://api.github.com/repos/projsaha/JavascriptAggregator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projsaha/JavascriptAggregator/downloads","issues_url":"https://api.github.com/repos/projsaha/JavascriptAggregator/issues{/number}","pulls_url":"https://api.github.com/repos/projsaha/JavascriptAggregator/pulls{/number}","milestones_url":"https://api.github.com/repos/projsaha/JavascriptAggregator/milestones{/number}","notifications_url":"https://api.github.com/repos/projsaha/JavascriptAggregator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projsaha/JavascriptAggregator/labels{/name}","releases_url":"https://api.github.com/repos/projsaha/JavascriptAggregator/releases{/id}","created_at":"2013-09-10T13:09:21Z","updated_at":"2014-06-08T12:09:08Z","pushed_at":"2014-06-08T12:08:02Z","git_url":"git://github.com/projsaha/JavascriptAggregator.git","ssh_url":"git@github.com:projsaha/JavascriptAggregator.git","clone_url":"https://github.com/projsaha/JavascriptAggregator.git","svn_url":"https://github.com/projsaha/JavascriptAggregator","homepage":null,"size":11445,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OpenNTF:master","ref":"master","sha":"aaea655c5c6fc3b21fe2ca8755223dfa572fa706","user":{"login":"OpenNTF","id":2027329,"avatar_url":"https://avatars.githubusercontent.com/u/2027329?","gravatar_id":"6631cacfccb7c5f37981f8f0b5b5a8de","url":"https://api.github.com/users/OpenNTF","html_url":"https://github.com/OpenNTF","followers_url":"https://api.github.com/users/OpenNTF/followers","following_url":"https://api.github.com/users/OpenNTF/following{/other_user}","gists_url":"https://api.github.com/users/OpenNTF/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenNTF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenNTF/subscriptions","organizations_url":"https://api.github.com/users/OpenNTF/orgs","repos_url":"https://api.github.com/users/OpenNTF/repos","events_url":"https://api.github.com/users/OpenNTF/events{/privacy}","received_events_url":"https://api.github.com/users/OpenNTF/received_events","type":"Organization","site_admin":false},"repo":{"id":5529658,"name":"JavascriptAggregator","full_name":"OpenNTF/JavascriptAggregator","owner":{"login":"OpenNTF","id":2027329,"avatar_url":"https://avatars.githubusercontent.com/u/2027329?","gravatar_id":"6631cacfccb7c5f37981f8f0b5b5a8de","url":"https://api.github.com/users/OpenNTF","html_url":"https://github.com/OpenNTF","followers_url":"https://api.github.com/users/OpenNTF/followers","following_url":"https://api.github.com/users/OpenNTF/following{/other_user}","gists_url":"https://api.github.com/users/OpenNTF/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenNTF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenNTF/subscriptions","organizations_url":"https://api.github.com/users/OpenNTF/orgs","repos_url":"https://api.github.com/users/OpenNTF/repos","events_url":"https://api.github.com/users/OpenNTF/events{/privacy}","received_events_url":"https://api.github.com/users/OpenNTF/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenNTF/JavascriptAggregator","description":"OpenNTF Javascript Aggregator project","fork":false,"url":"https://api.github.com/repos/OpenNTF/JavascriptAggregator","forks_url":"https://api.github.com/repos/OpenNTF/JavascriptAggregator/forks","keys_url":"https://api.github.com/repos/OpenNTF/JavascriptAggregator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenNTF/JavascriptAggregator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenNTF/JavascriptAggregator/teams","hooks_url":"https://api.github.com/repos/OpenNTF/JavascriptAggregator/hooks","issue_events_url":"https://api.github.com/repos/OpenNTF/JavascriptAggregator/issues/events{/number}","events_url":"https://api.github.com/repos/OpenNTF/JavascriptAggregator/events","assignees_url":"https://api.github.com/repos/OpenNTF/JavascriptAggregator/assignees{/user}","branches_url":"https://api.github.com/repos/OpenNTF/JavascriptAggregator/branches{/branch}","tags_url":"https://api.github.com/repos/OpenNTF/JavascriptAggregator/tags","blobs_url":"https://api.github.com/repos/OpenNTF/JavascriptAggregator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenNTF/JavascriptAggregator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenNTF/JavascriptAggregator/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenNTF/JavascriptAggregator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenNTF/JavascriptAggregator/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenNTF/JavascriptAggregator/languages","stargazers_url":"https://api.github.com/repos/OpenNTF/JavascriptAggregator/stargazers","contributors_url":"https://api.github.com/repos/OpenNTF/JavascriptAggregator/contributors","subscribers_url":"https://api.github.com/repos/OpenNTF/JavascriptAggregator/subscribers","subscription_url":"https://api.github.com/repos/OpenNTF/JavascriptAggregator/subscription","commits_url":"https://api.github.com/repos/OpenNTF/JavascriptAggregator/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenNTF/JavascriptAggregator/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenNTF/JavascriptAggregator/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenNTF/JavascriptAggregator/issues/comments/{number}","contents_url":"https://api.github.com/repos/OpenNTF/JavascriptAggregator/contents/{+path}","compare_url":"https://api.github.com/repos/OpenNTF/JavascriptAggregator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenNTF/JavascriptAggregator/merges","archive_url":"https://api.github.com/repos/OpenNTF/JavascriptAggregator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenNTF/JavascriptAggregator/downloads","issues_url":"https://api.github.com/repos/OpenNTF/JavascriptAggregator/issues{/number}","pulls_url":"https://api.github.com/repos/OpenNTF/JavascriptAggregator/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenNTF/JavascriptAggregator/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenNTF/JavascriptAggregator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenNTF/JavascriptAggregator/labels{/name}","releases_url":"https://api.github.com/repos/OpenNTF/JavascriptAggregator/releases{/id}","created_at":"2012-08-23T17:12:19Z","updated_at":"2014-06-09T21:01:13Z","pushed_at":"2014-06-09T21:01:13Z","git_url":"git://github.com/OpenNTF/JavascriptAggregator.git","ssh_url":"git@github.com:OpenNTF/JavascriptAggregator.git","clone_url":"https://github.com/OpenNTF/JavascriptAggregator.git","svn_url":"https://github.com/OpenNTF/JavascriptAggregator","homepage":null,"size":21657,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":12,"mirror_url":null,"open_issues_count":3,"forks":12,"open_issues":3,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenNTF/JavascriptAggregator/pulls/182"},"html":{"href":"https://github.com/OpenNTF/JavascriptAggregator/pull/182"},"issue":{"href":"https://api.github.com/repos/OpenNTF/JavascriptAggregator/issues/182"},"comments":{"href":"https://api.github.com/repos/OpenNTF/JavascriptAggregator/issues/182/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenNTF/JavascriptAggregator/pulls/182/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenNTF/JavascriptAggregator/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/OpenNTF/JavascriptAggregator/pulls/182/commits"},"statuses":{"href":"https://api.github.com/repos/OpenNTF/JavascriptAggregator/statuses/937da24d5d86bc687dc1548025518ed1696be3d3"}}}}