GitHub PullRequestEvent at 2014-07-31 07:06:00
Repository: dolphin
Actor: lioncash
Payload: {"action":"closed","number":705,"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/705","id":19133592,"html_url":"https://github.com/dolphin-emu/dolphin/pull/705","diff_url":"https://github.com/dolphin-emu/dolphin/pull/705.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/705.patch","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/705","number":705,"state":"closed","title":"Fixes a check for what mmap returns.","user":{"login":"Sonicadvance1","id":1018829,"avatar_url":"https://avatars.githubusercontent.com/u/1018829?v=1","gravatar_id":"260346efb6171dec817a5d92c637663c","url":"https://api.github.com/users/Sonicadvance1","html_url":"https://github.com/Sonicadvance1","followers_url":"https://api.github.com/users/Sonicadvance1/followers","following_url":"https://api.github.com/users/Sonicadvance1/following{/other_user}","gists_url":"https://api.github.com/users/Sonicadvance1/gists{/gist_id}","starred_url":"https://api.github.com/users/Sonicadvance1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sonicadvance1/subscriptions","organizations_url":"https://api.github.com/users/Sonicadvance1/orgs","repos_url":"https://api.github.com/users/Sonicadvance1/repos","events_url":"https://api.github.com/users/Sonicadvance1/events{/privacy}","received_events_url":"https://api.github.com/users/Sonicadvance1/received_events","type":"User","site_admin":false},"body":"On error mmap returns MAP_FAILED(-1) not null.\r\nFreeBSD was checking the return correctly, Linux was not.\r\nThis was noticed by triad attempting to run Dolphin under valgrind and not getting a memory space under the 2GB limit(Because -1 wraps around on\r\nunsigned obviously)","created_at":"2014-07-31T05:50:09Z","updated_at":"2014-07-31T07:06:00Z","closed_at":"2014-07-31T07:06:00Z","merged_at":"2014-07-31T07:06:00Z","merge_commit_sha":"f3bf93800f9cbbb9cda9640ec1e4e057bfe940ca","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/705/commits","review_comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/705/comments","review_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/{number}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/705/comments","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/33450c80c3ca39ef1875f9c72898ba5749d06142","head":{"label":"Sonicadvance1:fix-memoryutil-check","ref":"fix-memoryutil-check","sha":"33450c80c3ca39ef1875f9c72898ba5749d06142","user":{"login":"Sonicadvance1","id":1018829,"avatar_url":"https://avatars.githubusercontent.com/u/1018829?v=1","gravatar_id":"260346efb6171dec817a5d92c637663c","url":"https://api.github.com/users/Sonicadvance1","html_url":"https://github.com/Sonicadvance1","followers_url":"https://api.github.com/users/Sonicadvance1/followers","following_url":"https://api.github.com/users/Sonicadvance1/following{/other_user}","gists_url":"https://api.github.com/users/Sonicadvance1/gists{/gist_id}","starred_url":"https://api.github.com/users/Sonicadvance1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sonicadvance1/subscriptions","organizations_url":"https://api.github.com/users/Sonicadvance1/orgs","repos_url":"https://api.github.com/users/Sonicadvance1/repos","events_url":"https://api.github.com/users/Sonicadvance1/events{/privacy}","received_events_url":"https://api.github.com/users/Sonicadvance1/received_events","type":"User","site_admin":false},"repo":{"id":16360220,"name":"dolphin","full_name":"Sonicadvance1/dolphin","owner":{"login":"Sonicadvance1","id":1018829,"avatar_url":"https://avatars.githubusercontent.com/u/1018829?v=1","gravatar_id":"260346efb6171dec817a5d92c637663c","url":"https://api.github.com/users/Sonicadvance1","html_url":"https://github.com/Sonicadvance1","followers_url":"https://api.github.com/users/Sonicadvance1/followers","following_url":"https://api.github.com/users/Sonicadvance1/following{/other_user}","gists_url":"https://api.github.com/users/Sonicadvance1/gists{/gist_id}","starred_url":"https://api.github.com/users/Sonicadvance1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sonicadvance1/subscriptions","organizations_url":"https://api.github.com/users/Sonicadvance1/orgs","repos_url":"https://api.github.com/users/Sonicadvance1/repos","events_url":"https://api.github.com/users/Sonicadvance1/events{/privacy}","received_events_url":"https://api.github.com/users/Sonicadvance1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Sonicadvance1/dolphin","description":"Dolphin is a GameCube/Wii emulator, allowing you to play games for these two platforms on PC, with improvements.","fork":true,"url":"https://api.github.com/repos/Sonicadvance1/dolphin","forks_url":"https://api.github.com/repos/Sonicadvance1/dolphin/forks","keys_url":"https://api.github.com/repos/Sonicadvance1/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sonicadvance1/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sonicadvance1/dolphin/teams","hooks_url":"https://api.github.com/repos/Sonicadvance1/dolphin/hooks","issue_events_url":"https://api.github.com/repos/Sonicadvance1/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/Sonicadvance1/dolphin/events","assignees_url":"https://api.github.com/repos/Sonicadvance1/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/Sonicadvance1/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/Sonicadvance1/dolphin/tags","blobs_url":"https://api.github.com/repos/Sonicadvance1/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sonicadvance1/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sonicadvance1/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sonicadvance1/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sonicadvance1/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/Sonicadvance1/dolphin/languages","stargazers_url":"https://api.github.com/repos/Sonicadvance1/dolphin/stargazers","contributors_url":"https://api.github.com/repos/Sonicadvance1/dolphin/contributors","subscribers_url":"https://api.github.com/repos/Sonicadvance1/dolphin/subscribers","subscription_url":"https://api.github.com/repos/Sonicadvance1/dolphin/subscription","commits_url":"https://api.github.com/repos/Sonicadvance1/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sonicadvance1/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sonicadvance1/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sonicadvance1/dolphin/issues/comments/{number}","contents_url":"https://api.github.com/repos/Sonicadvance1/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/Sonicadvance1/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sonicadvance1/dolphin/merges","archive_url":"https://api.github.com/repos/Sonicadvance1/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sonicadvance1/dolphin/downloads","issues_url":"https://api.github.com/repos/Sonicadvance1/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/Sonicadvance1/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/Sonicadvance1/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/Sonicadvance1/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sonicadvance1/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/Sonicadvance1/dolphin/releases{/id}","created_at":"2014-01-29T21:48:46Z","updated_at":"2014-06-17T03:54:40Z","pushed_at":"2014-07-31T05:53:16Z","git_url":"git://github.com/Sonicadvance1/dolphin.git","ssh_url":"git@github.com:Sonicadvance1/dolphin.git","clone_url":"https://github.com/Sonicadvance1/dolphin.git","svn_url":"https://github.com/Sonicadvance1/dolphin","homepage":null,"size":194411,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dolphin-emu:master","ref":"master","sha":"f5078273990e381a8437e945828444cefc410417","user":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=1","gravatar_id":"889eb5c76644c10900f277bef9b7b516","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":11577304,"name":"dolphin","full_name":"dolphin-emu/dolphin","owner":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=1","gravatar_id":"889eb5c76644c10900f277bef9b7b516","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dolphin-emu/dolphin","description":"Dolphin is a GameCube/Wii emulator, allowing you to play games for these two platforms on PC, with improvements.","fork":false,"url":"https://api.github.com/repos/dolphin-emu/dolphin","forks_url":"https://api.github.com/repos/dolphin-emu/dolphin/forks","keys_url":"https://api.github.com/repos/dolphin-emu/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dolphin-emu/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dolphin-emu/dolphin/teams","hooks_url":"https://api.github.com/repos/dolphin-emu/dolphin/hooks","issue_events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/events","assignees_url":"https://api.github.com/repos/dolphin-emu/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/dolphin-emu/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/tags","blobs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/dolphin-emu/dolphin/languages","stargazers_url":"https://api.github.com/repos/dolphin-emu/dolphin/stargazers","contributors_url":"https://api.github.com/repos/dolphin-emu/dolphin/contributors","subscribers_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscribers","subscription_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscription","commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments/{number}","contents_url":"https://api.github.com/repos/dolphin-emu/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/dolphin-emu/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dolphin-emu/dolphin/merges","archive_url":"https://api.github.com/repos/dolphin-emu/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dolphin-emu/dolphin/downloads","issues_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/dolphin-emu/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/dolphin-emu/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/dolphin-emu/dolphin/releases{/id}","created_at":"2013-07-22T09:07:57Z","updated_at":"2014-07-31T04:39:49Z","pushed_at":"2014-07-31T07:06:00Z","git_url":"git://github.com/dolphin-emu/dolphin.git","ssh_url":"git@github.com:dolphin-emu/dolphin.git","clone_url":"https://github.com/dolphin-emu/dolphin.git","svn_url":"https://github.com/dolphin-emu/dolphin","homepage":null,"size":232471,"stargazers_count":397,"watchers_count":397,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":142,"mirror_url":null,"open_issues_count":40,"forks":142,"open_issues":40,"watchers":397,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/705"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/705"},"issue":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/705"},"comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/705/comments"},"review_comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/705/comments"},"review_comment":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/705/commits"},"statuses":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/33450c80c3ca39ef1875f9c72898ba5749d06142"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"lioncash","id":712067,"avatar_url":"https://avatars.githubusercontent.com/u/712067?v=1","gravatar_id":"5d49a662d2758e9d5728ab17caf327e9","url":"https://api.github.com/users/lioncash","html_url":"https://github.com/lioncash","followers_url":"https://api.github.com/users/lioncash/followers","following_url":"https://api.github.com/users/lioncash/following{/other_user}","gists_url":"https://api.github.com/users/lioncash/gists{/gist_id}","starred_url":"https://api.github.com/users/lioncash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lioncash/subscriptions","organizations_url":"https://api.github.com/users/lioncash/orgs","repos_url":"https://api.github.com/users/lioncash/repos","events_url":"https://api.github.com/users/lioncash/events{/privacy}","received_events_url":"https://api.github.com/users/lioncash/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":4,"deletions":4,"changed_files":1}}