GitHub PullRequestReviewCommentEvent at 2014-03-28 08:21:05
Repository: elasticsearch
Actor: s1monw
Payload: {"comment":{"url":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/comments/11057601","id":11057601,"diff_hunk":"@@ -430,16 +432,32 @@ public int read(byte[] b, int bOffset, int len) throws IOException {\n             }\n \n             // we need to stop at the end\n-            len = Math.min(length, len);","path":"src/main/java/org/elasticsearch/common/bytes/PagedBytesReference.java","position":19,"original_position":19,"commit_id":"d6d00634cfba2399bf3ad09b00a58ad7bfbf5392","original_commit_id":"d6d00634cfba2399bf3ad09b00a58ad7bfbf5392","user":{"login":"s1monw","id":973334,"avatar_url":"https://avatars.githubusercontent.com/u/973334?","gravatar_id":"8c12b7030c2431ff54d71891a722ff9a","url":"https://api.github.com/users/s1monw","html_url":"https://github.com/s1monw","followers_url":"https://api.github.com/users/s1monw/followers","following_url":"https://api.github.com/users/s1monw/following{/other_user}","gists_url":"https://api.github.com/users/s1monw/gists{/gist_id}","starred_url":"https://api.github.com/users/s1monw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s1monw/subscriptions","organizations_url":"https://api.github.com/users/s1monw/orgs","repos_url":"https://api.github.com/users/s1monw/repos","events_url":"https://api.github.com/users/s1monw/events{/privacy}","received_events_url":"https://api.github.com/users/s1monw/received_events","type":"User","site_admin":false},"body":"just as a sidenote I think the arguments should be final to make sure we don't reassign them :)","created_at":"2014-03-28T08:21:05Z","updated_at":"2014-03-28T08:21:05Z","html_url":"https://github.com/elasticsearch/elasticsearch/pull/5589#discussion_r11057601","pull_request_url":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/5589","_links":{"self":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/comments/11057601"},"html":{"href":"https://github.com/elasticsearch/elasticsearch/pull/5589#discussion_r11057601"},"pull_request":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/5589"}}}}