GitHub PullRequestReviewCommentEvent at 2014-07-21 14:36:39
Repository: python-netsnmpagent
Actor: pief
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/pief/python-netsnmpagent/pulls/comments/15171663","id":15171663,"diff_hunk":"@@ -61,6 +61,7 @@ def __init__(self, **args):\n \t\t- PersistenceDir: The directory to use to store persistence information.\n \t\t                  Change this if you want to use a custom snmpd\n \t\t                  instance, eg. for automatic testing.\n+\t        - UseMIB        : Whether to use MIB files at all or not.","path":"netsnmpagent.py","position":4,"original_position":4,"commit_id":"0f08917fe6efb3b641d1c3d5a07a55443f758938","original_commit_id":"0f08917fe6efb3b641d1c3d5a07a55443f758938","user":{"login":"pief","id":2843983,"avatar_url":"https://avatars.githubusercontent.com/u/2843983?","gravatar_id":"93a37bec61dd875257921cea9cebad4b","url":"https://api.github.com/users/pief","html_url":"https://github.com/pief","followers_url":"https://api.github.com/users/pief/followers","following_url":"https://api.github.com/users/pief/following{/other_user}","gists_url":"https://api.github.com/users/pief/gists{/gist_id}","starred_url":"https://api.github.com/users/pief/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pief/subscriptions","organizations_url":"https://api.github.com/users/pief/orgs","repos_url":"https://api.github.com/users/pief/repos","events_url":"https://api.github.com/users/pief/events{/privacy}","received_events_url":"https://api.github.com/users/pief/received_events","type":"User","site_admin":false},"body":"Is there a particular reason why you implemented a separate flag instead of just checking for an empty \"MIBFiles\" parameter?","created_at":"2014-07-21T14:36:39Z","updated_at":"2014-07-21T14:36:39Z","html_url":"https://github.com/pief/python-netsnmpagent/pull/17#discussion_r15171663","pull_request_url":"https://api.github.com/repos/pief/python-netsnmpagent/pulls/17","_links":{"self":{"href":"https://api.github.com/repos/pief/python-netsnmpagent/pulls/comments/15171663"},"html":{"href":"https://github.com/pief/python-netsnmpagent/pull/17#discussion_r15171663"},"pull_request":{"href":"https://api.github.com/repos/pief/python-netsnmpagent/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/pief/python-netsnmpagent/pulls/17","id":18651172,"html_url":"https://github.com/pief/python-netsnmpagent/pull/17","diff_url":"https://github.com/pief/python-netsnmpagent/pull/17.diff","patch_url":"https://github.com/pief/python-netsnmpagent/pull/17.patch","issue_url":"https://api.github.com/repos/pief/python-netsnmpagent/issues/17","number":17,"state":"open","title":"Make the use of MIB files completely optional","user":{"login":"jdevera","id":73069,"avatar_url":"https://avatars.githubusercontent.com/u/73069?","gravatar_id":"17cade916a4530faa794dca0d4edc7dc","url":"https://api.github.com/users/jdevera","html_url":"https://github.com/jdevera","followers_url":"https://api.github.com/users/jdevera/followers","following_url":"https://api.github.com/users/jdevera/following{/other_user}","gists_url":"https://api.github.com/users/jdevera/gists{/gist_id}","starred_url":"https://api.github.com/users/jdevera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdevera/subscriptions","organizations_url":"https://api.github.com/users/jdevera/orgs","repos_url":"https://api.github.com/users/jdevera/repos","events_url":"https://api.github.com/users/jdevera/events{/privacy}","received_events_url":"https://api.github.com/users/jdevera/received_events","type":"User","site_admin":false},"body":"My particular use case required publishing some SNMP values by directly specifying the Oids, rather than names to extract from MIB files.\r\n\r\nThis is the change I had to implement in order to support such scenario. If you think it is useful for your users, please feel free to pull.\r\n\r\nThanks for your work on this library, by the way, It has made my project viable within the time constraints I had.","created_at":"2014-07-21T12:34:42Z","updated_at":"2014-07-21T14:36:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6680cda68a12c93cb88e5badd14cbd055e955aa0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pief/python-netsnmpagent/pulls/17/commits","review_comments_url":"https://api.github.com/repos/pief/python-netsnmpagent/pulls/17/comments","review_comment_url":"https://api.github.com/repos/pief/python-netsnmpagent/pulls/comments/{number}","comments_url":"https://api.github.com/repos/pief/python-netsnmpagent/issues/17/comments","statuses_url":"https://api.github.com/repos/pief/python-netsnmpagent/statuses/0f08917fe6efb3b641d1c3d5a07a55443f758938","head":{"label":"jdevera:mibless","ref":"mibless","sha":"0f08917fe6efb3b641d1c3d5a07a55443f758938","user":{"login":"jdevera","id":73069,"avatar_url":"https://avatars.githubusercontent.com/u/73069?","gravatar_id":"17cade916a4530faa794dca0d4edc7dc","url":"https://api.github.com/users/jdevera","html_url":"https://github.com/jdevera","followers_url":"https://api.github.com/users/jdevera/followers","following_url":"https://api.github.com/users/jdevera/following{/other_user}","gists_url":"https://api.github.com/users/jdevera/gists{/gist_id}","starred_url":"https://api.github.com/users/jdevera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdevera/subscriptions","organizations_url":"https://api.github.com/users/jdevera/orgs","repos_url":"https://api.github.com/users/jdevera/repos","events_url":"https://api.github.com/users/jdevera/events{/privacy}","received_events_url":"https://api.github.com/users/jdevera/received_events","type":"User","site_admin":false},"repo":{"id":21970158,"name":"python-netsnmpagent","full_name":"jdevera/python-netsnmpagent","owner":{"login":"jdevera","id":73069,"avatar_url":"https://avatars.githubusercontent.com/u/73069?","gravatar_id":"17cade916a4530faa794dca0d4edc7dc","url":"https://api.github.com/users/jdevera","html_url":"https://github.com/jdevera","followers_url":"https://api.github.com/users/jdevera/followers","following_url":"https://api.github.com/users/jdevera/following{/other_user}","gists_url":"https://api.github.com/users/jdevera/gists{/gist_id}","starred_url":"https://api.github.com/users/jdevera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdevera/subscriptions","organizations_url":"https://api.github.com/users/jdevera/orgs","repos_url":"https://api.github.com/users/jdevera/repos","events_url":"https://api.github.com/users/jdevera/events{/privacy}","received_events_url":"https://api.github.com/users/jdevera/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jdevera/python-netsnmpagent","description":"Allows to write net-snmp subagents in Python.","fork":true,"url":"https://api.github.com/repos/jdevera/python-netsnmpagent","forks_url":"https://api.github.com/repos/jdevera/python-netsnmpagent/forks","keys_url":"https://api.github.com/repos/jdevera/python-netsnmpagent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jdevera/python-netsnmpagent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jdevera/python-netsnmpagent/teams","hooks_url":"https://api.github.com/repos/jdevera/python-netsnmpagent/hooks","issue_events_url":"https://api.github.com/repos/jdevera/python-netsnmpagent/issues/events{/number}","events_url":"https://api.github.com/repos/jdevera/python-netsnmpagent/events","assignees_url":"https://api.github.com/repos/jdevera/python-netsnmpagent/assignees{/user}","branches_url":"https://api.github.com/repos/jdevera/python-netsnmpagent/branches{/branch}","tags_url":"https://api.github.com/repos/jdevera/python-netsnmpagent/tags","blobs_url":"https://api.github.com/repos/jdevera/python-netsnmpagent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jdevera/python-netsnmpagent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jdevera/python-netsnmpagent/git/refs{/sha}","trees_url":"https://api.github.com/repos/jdevera/python-netsnmpagent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jdevera/python-netsnmpagent/statuses/{sha}","languages_url":"https://api.github.com/repos/jdevera/python-netsnmpagent/languages","stargazers_url":"https://api.github.com/repos/jdevera/python-netsnmpagent/stargazers","contributors_url":"https://api.github.com/repos/jdevera/python-netsnmpagent/contributors","subscribers_url":"https://api.github.com/repos/jdevera/python-netsnmpagent/subscribers","subscription_url":"https://api.github.com/repos/jdevera/python-netsnmpagent/subscription","commits_url":"https://api.github.com/repos/jdevera/python-netsnmpagent/commits{/sha}","git_commits_url":"https://api.github.com/repos/jdevera/python-netsnmpagent/git/commits{/sha}","comments_url":"https://api.github.com/repos/jdevera/python-netsnmpagent/comments{/number}","issue_comment_url":"https://api.github.com/repos/jdevera/python-netsnmpagent/issues/comments/{number}","contents_url":"https://api.github.com/repos/jdevera/python-netsnmpagent/contents/{+path}","compare_url":"https://api.github.com/repos/jdevera/python-netsnmpagent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jdevera/python-netsnmpagent/merges","archive_url":"https://api.github.com/repos/jdevera/python-netsnmpagent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jdevera/python-netsnmpagent/downloads","issues_url":"https://api.github.com/repos/jdevera/python-netsnmpagent/issues{/number}","pulls_url":"https://api.github.com/repos/jdevera/python-netsnmpagent/pulls{/number}","milestones_url":"https://api.github.com/repos/jdevera/python-netsnmpagent/milestones{/number}","notifications_url":"https://api.github.com/repos/jdevera/python-netsnmpagent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jdevera/python-netsnmpagent/labels{/name}","releases_url":"https://api.github.com/repos/jdevera/python-netsnmpagent/releases{/id}","created_at":"2014-07-18T06:24:38Z","updated_at":"2014-07-21T12:30:53Z","pushed_at":"2014-07-21T12:31:21Z","git_url":"git://github.com/jdevera/python-netsnmpagent.git","ssh_url":"git@github.com:jdevera/python-netsnmpagent.git","clone_url":"https://github.com/jdevera/python-netsnmpagent.git","svn_url":"https://github.com/jdevera/python-netsnmpagent","homepage":null,"size":2322,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pief:master","ref":"master","sha":"9f9de13efffe9be0b1b9ea24a91046a96e383b40","user":{"login":"pief","id":2843983,"avatar_url":"https://avatars.githubusercontent.com/u/2843983?","gravatar_id":"93a37bec61dd875257921cea9cebad4b","url":"https://api.github.com/users/pief","html_url":"https://github.com/pief","followers_url":"https://api.github.com/users/pief/followers","following_url":"https://api.github.com/users/pief/following{/other_user}","gists_url":"https://api.github.com/users/pief/gists{/gist_id}","starred_url":"https://api.github.com/users/pief/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pief/subscriptions","organizations_url":"https://api.github.com/users/pief/orgs","repos_url":"https://api.github.com/users/pief/repos","events_url":"https://api.github.com/users/pief/events{/privacy}","received_events_url":"https://api.github.com/users/pief/received_events","type":"User","site_admin":false},"repo":{"id":6829512,"name":"python-netsnmpagent","full_name":"pief/python-netsnmpagent","owner":{"login":"pief","id":2843983,"avatar_url":"https://avatars.githubusercontent.com/u/2843983?","gravatar_id":"93a37bec61dd875257921cea9cebad4b","url":"https://api.github.com/users/pief","html_url":"https://github.com/pief","followers_url":"https://api.github.com/users/pief/followers","following_url":"https://api.github.com/users/pief/following{/other_user}","gists_url":"https://api.github.com/users/pief/gists{/gist_id}","starred_url":"https://api.github.com/users/pief/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pief/subscriptions","organizations_url":"https://api.github.com/users/pief/orgs","repos_url":"https://api.github.com/users/pief/repos","events_url":"https://api.github.com/users/pief/events{/privacy}","received_events_url":"https://api.github.com/users/pief/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pief/python-netsnmpagent","description":"Allows to write net-snmp subagents in Python.","fork":false,"url":"https://api.github.com/repos/pief/python-netsnmpagent","forks_url":"https://api.github.com/repos/pief/python-netsnmpagent/forks","keys_url":"https://api.github.com/repos/pief/python-netsnmpagent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pief/python-netsnmpagent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pief/python-netsnmpagent/teams","hooks_url":"https://api.github.com/repos/pief/python-netsnmpagent/hooks","issue_events_url":"https://api.github.com/repos/pief/python-netsnmpagent/issues/events{/number}","events_url":"https://api.github.com/repos/pief/python-netsnmpagent/events","assignees_url":"https://api.github.com/repos/pief/python-netsnmpagent/assignees{/user}","branches_url":"https://api.github.com/repos/pief/python-netsnmpagent/branches{/branch}","tags_url":"https://api.github.com/repos/pief/python-netsnmpagent/tags","blobs_url":"https://api.github.com/repos/pief/python-netsnmpagent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pief/python-netsnmpagent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pief/python-netsnmpagent/git/refs{/sha}","trees_url":"https://api.github.com/repos/pief/python-netsnmpagent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pief/python-netsnmpagent/statuses/{sha}","languages_url":"https://api.github.com/repos/pief/python-netsnmpagent/languages","stargazers_url":"https://api.github.com/repos/pief/python-netsnmpagent/stargazers","contributors_url":"https://api.github.com/repos/pief/python-netsnmpagent/contributors","subscribers_url":"https://api.github.com/repos/pief/python-netsnmpagent/subscribers","subscription_url":"https://api.github.com/repos/pief/python-netsnmpagent/subscription","commits_url":"https://api.github.com/repos/pief/python-netsnmpagent/commits{/sha}","git_commits_url":"https://api.github.com/repos/pief/python-netsnmpagent/git/commits{/sha}","comments_url":"https://api.github.com/repos/pief/python-netsnmpagent/comments{/number}","issue_comment_url":"https://api.github.com/repos/pief/python-netsnmpagent/issues/comments/{number}","contents_url":"https://api.github.com/repos/pief/python-netsnmpagent/contents/{+path}","compare_url":"https://api.github.com/repos/pief/python-netsnmpagent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pief/python-netsnmpagent/merges","archive_url":"https://api.github.com/repos/pief/python-netsnmpagent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pief/python-netsnmpagent/downloads","issues_url":"https://api.github.com/repos/pief/python-netsnmpagent/issues{/number}","pulls_url":"https://api.github.com/repos/pief/python-netsnmpagent/pulls{/number}","milestones_url":"https://api.github.com/repos/pief/python-netsnmpagent/milestones{/number}","notifications_url":"https://api.github.com/repos/pief/python-netsnmpagent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pief/python-netsnmpagent/labels{/name}","releases_url":"https://api.github.com/repos/pief/python-netsnmpagent/releases{/id}","created_at":"2012-11-23T15:42:50Z","updated_at":"2014-07-11T08:32:56Z","pushed_at":"2014-05-16T22:29:13Z","git_url":"git://github.com/pief/python-netsnmpagent.git","ssh_url":"git@github.com:pief/python-netsnmpagent.git","clone_url":"https://github.com/pief/python-netsnmpagent.git","svn_url":"https://github.com/pief/python-netsnmpagent","homepage":null,"size":2829,"stargazers_count":11,"watchers_count":11,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":8,"mirror_url":null,"open_issues_count":4,"forks":8,"open_issues":4,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pief/python-netsnmpagent/pulls/17"},"html":{"href":"https://github.com/pief/python-netsnmpagent/pull/17"},"issue":{"href":"https://api.github.com/repos/pief/python-netsnmpagent/issues/17"},"comments":{"href":"https://api.github.com/repos/pief/python-netsnmpagent/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/pief/python-netsnmpagent/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/pief/python-netsnmpagent/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/pief/python-netsnmpagent/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/pief/python-netsnmpagent/statuses/0f08917fe6efb3b641d1c3d5a07a55443f758938"}}}}