GitHub PullRequestReviewCommentEvent at 2014-08-17 19:16:39
Repository: generator-angular-fullstack
Actor: kingcody
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/pulls/comments/16331479","id":16331479,"diff_hunk":"@@ -44,10 +44,10 @@\n     <script src=\"bower_components/es5-shim/es5-shim.js\"></script>\n     <script src=\"bower_components/json3/lib/json3.min.js\"></script>\n     <![endif]-->\n-<% if(filters.socketio) { %>    <script src=\"socket.io/socket.io.js\"></script><% } %>\n-    <!-- build:js(client) app/vendor.js -->\n+    <!-- build:js({client<% if(filters.socketio) { %>,node_modules<% } %>}) app/vendor.js -->\n       <!-- bower:js -->\n       <!-- endbower -->\n+      <% if(filters.socketio) { %><script src=\"socket.io-client/socket.io.js\"></script><% } %>","path":"app/templates/client/index.html","position":9,"original_position":9,"commit_id":"06f2e46ef382b5af1691f34b6cf504f1e5640b86","original_commit_id":"06f2e46ef382b5af1691f34b6cf504f1e5640b86","user":{"login":"kingcody","id":2544108,"avatar_url":"https://avatars.githubusercontent.com/u/2544108?v=2","gravatar_id":"7b8d64df1e8e03b0d603314b9135d3fa","url":"https://api.github.com/users/kingcody","html_url":"https://github.com/kingcody","followers_url":"https://api.github.com/users/kingcody/followers","following_url":"https://api.github.com/users/kingcody/following{/other_user}","gists_url":"https://api.github.com/users/kingcody/gists{/gist_id}","starred_url":"https://api.github.com/users/kingcody/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kingcody/subscriptions","organizations_url":"https://api.github.com/users/kingcody/orgs","repos_url":"https://api.github.com/users/kingcody/repos","events_url":"https://api.github.com/users/kingcody/events{/privacy}","received_events_url":"https://api.github.com/users/kingcody/received_events","type":"User","site_admin":false},"body":"If you take a look at the server and client scripts where we setup socket.io, you should see where we've adjusted the paths to match. ","created_at":"2014-08-17T19:16:39Z","updated_at":"2014-08-17T19:16:39Z","html_url":"https://github.com/DaftMonk/generator-angular-fullstack/pull/455#discussion_r16331479","pull_request_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/pulls/455","_links":{"self":{"href":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/pulls/comments/16331479"},"html":{"href":"https://github.com/DaftMonk/generator-angular-fullstack/pull/455#discussion_r16331479"},"pull_request":{"href":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/pulls/455"}}},"pull_request":{"url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/pulls/455","id":19877698,"html_url":"https://github.com/DaftMonk/generator-angular-fullstack/pull/455","diff_url":"https://github.com/DaftMonk/generator-angular-fullstack/pull/455.diff","patch_url":"https://github.com/DaftMonk/generator-angular-fullstack/pull/455.patch","issue_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/issues/455","number":455,"state":"closed","locked":false,"title":"feat(app:socket.io): build socket.io into vendor.js","user":{"login":"kingcody","id":2544108,"avatar_url":"https://avatars.githubusercontent.com/u/2544108?v=2","gravatar_id":"7b8d64df1e8e03b0d603314b9135d3fa","url":"https://api.github.com/users/kingcody","html_url":"https://github.com/kingcody","followers_url":"https://api.github.com/users/kingcody/followers","following_url":"https://api.github.com/users/kingcody/following{/other_user}","gists_url":"https://api.github.com/users/kingcody/gists{/gist_id}","starred_url":"https://api.github.com/users/kingcody/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kingcody/subscriptions","organizations_url":"https://api.github.com/users/kingcody/orgs","repos_url":"https://api.github.com/users/kingcody/repos","events_url":"https://api.github.com/users/kingcody/events{/privacy}","received_events_url":"https://api.github.com/users/kingcody/received_events","type":"User","site_admin":false},"body":"Changes:\r\n- Move socket.io script tag inside vendor.js build\r\n- Add `node_modules/socket.io/node_modules` to vendor script locations\r\n- Change socket.io path to `/socket.io-client` in serve and client\r\n- Will not serve socket.io.js when server is ran in `production` env","created_at":"2014-08-16T07:26:41Z","updated_at":"2014-08-17T19:16:39Z","closed_at":"2014-08-17T02:29:29Z","merged_at":"2014-08-17T02:29:29Z","merge_commit_sha":"6553d5c0ab0bdf938fdbda449fe5826e577ae2a3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/pulls/455/commits","review_comments_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/pulls/455/comments","review_comment_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/pulls/comments/{number}","comments_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/issues/455/comments","statuses_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/statuses/06f2e46ef382b5af1691f34b6cf504f1e5640b86","head":{"label":"kingcody:feature/baked-in-socket.io","ref":"feature/baked-in-socket.io","sha":"06f2e46ef382b5af1691f34b6cf504f1e5640b86","user":{"login":"kingcody","id":2544108,"avatar_url":"https://avatars.githubusercontent.com/u/2544108?v=2","gravatar_id":"7b8d64df1e8e03b0d603314b9135d3fa","url":"https://api.github.com/users/kingcody","html_url":"https://github.com/kingcody","followers_url":"https://api.github.com/users/kingcody/followers","following_url":"https://api.github.com/users/kingcody/following{/other_user}","gists_url":"https://api.github.com/users/kingcody/gists{/gist_id}","starred_url":"https://api.github.com/users/kingcody/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kingcody/subscriptions","organizations_url":"https://api.github.com/users/kingcody/orgs","repos_url":"https://api.github.com/users/kingcody/repos","events_url":"https://api.github.com/users/kingcody/events{/privacy}","received_events_url":"https://api.github.com/users/kingcody/received_events","type":"User","site_admin":false},"repo":{"id":18499805,"name":"generator-angular-fullstack","full_name":"kingcody/generator-angular-fullstack","owner":{"login":"kingcody","id":2544108,"avatar_url":"https://avatars.githubusercontent.com/u/2544108?v=2","gravatar_id":"7b8d64df1e8e03b0d603314b9135d3fa","url":"https://api.github.com/users/kingcody","html_url":"https://github.com/kingcody","followers_url":"https://api.github.com/users/kingcody/followers","following_url":"https://api.github.com/users/kingcody/following{/other_user}","gists_url":"https://api.github.com/users/kingcody/gists{/gist_id}","starred_url":"https://api.github.com/users/kingcody/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kingcody/subscriptions","organizations_url":"https://api.github.com/users/kingcody/orgs","repos_url":"https://api.github.com/users/kingcody/repos","events_url":"https://api.github.com/users/kingcody/events{/privacy}","received_events_url":"https://api.github.com/users/kingcody/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kingcody/generator-angular-fullstack","description":"Yeoman generator for AngularJS with an Express server","fork":true,"url":"https://api.github.com/repos/kingcody/generator-angular-fullstack","forks_url":"https://api.github.com/repos/kingcody/generator-angular-fullstack/forks","keys_url":"https://api.github.com/repos/kingcody/generator-angular-fullstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kingcody/generator-angular-fullstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kingcody/generator-angular-fullstack/teams","hooks_url":"https://api.github.com/repos/kingcody/generator-angular-fullstack/hooks","issue_events_url":"https://api.github.com/repos/kingcody/generator-angular-fullstack/issues/events{/number}","events_url":"https://api.github.com/repos/kingcody/generator-angular-fullstack/events","assignees_url":"https://api.github.com/repos/kingcody/generator-angular-fullstack/assignees{/user}","branches_url":"https://api.github.com/repos/kingcody/generator-angular-fullstack/branches{/branch}","tags_url":"https://api.github.com/repos/kingcody/generator-angular-fullstack/tags","blobs_url":"https://api.github.com/repos/kingcody/generator-angular-fullstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kingcody/generator-angular-fullstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kingcody/generator-angular-fullstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/kingcody/generator-angular-fullstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kingcody/generator-angular-fullstack/statuses/{sha}","languages_url":"https://api.github.com/repos/kingcody/generator-angular-fullstack/languages","stargazers_url":"https://api.github.com/repos/kingcody/generator-angular-fullstack/stargazers","contributors_url":"https://api.github.com/repos/kingcody/generator-angular-fullstack/contributors","subscribers_url":"https://api.github.com/repos/kingcody/generator-angular-fullstack/subscribers","subscription_url":"https://api.github.com/repos/kingcody/generator-angular-fullstack/subscription","commits_url":"https://api.github.com/repos/kingcody/generator-angular-fullstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/kingcody/generator-angular-fullstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/kingcody/generator-angular-fullstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/kingcody/generator-angular-fullstack/issues/comments/{number}","contents_url":"https://api.github.com/repos/kingcody/generator-angular-fullstack/contents/{+path}","compare_url":"https://api.github.com/repos/kingcody/generator-angular-fullstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kingcody/generator-angular-fullstack/merges","archive_url":"https://api.github.com/repos/kingcody/generator-angular-fullstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kingcody/generator-angular-fullstack/downloads","issues_url":"https://api.github.com/repos/kingcody/generator-angular-fullstack/issues{/number}","pulls_url":"https://api.github.com/repos/kingcody/generator-angular-fullstack/pulls{/number}","milestones_url":"https://api.github.com/repos/kingcody/generator-angular-fullstack/milestones{/number}","notifications_url":"https://api.github.com/repos/kingcody/generator-angular-fullstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kingcody/generator-angular-fullstack/labels{/name}","releases_url":"https://api.github.com/repos/kingcody/generator-angular-fullstack/releases{/id}","created_at":"2014-04-06T21:31:06Z","updated_at":"2014-07-17T09:34:34Z","pushed_at":"2014-08-17T09:02:06Z","git_url":"git://github.com/kingcody/generator-angular-fullstack.git","ssh_url":"git@github.com:kingcody/generator-angular-fullstack.git","clone_url":"https://github.com/kingcody/generator-angular-fullstack.git","svn_url":"https://github.com/kingcody/generator-angular-fullstack","homepage":"http://yeoman.io","size":5752,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DaftMonk:master","ref":"master","sha":"cbf796870a9834bbe64d0a7befe0c2bca1597a44","user":{"login":"DaftMonk","id":2505273,"avatar_url":"https://avatars.githubusercontent.com/u/2505273?v=2","gravatar_id":"b80cadb42cceabbdd20fb3e615e7f50e","url":"https://api.github.com/users/DaftMonk","html_url":"https://github.com/DaftMonk","followers_url":"https://api.github.com/users/DaftMonk/followers","following_url":"https://api.github.com/users/DaftMonk/following{/other_user}","gists_url":"https://api.github.com/users/DaftMonk/gists{/gist_id}","starred_url":"https://api.github.com/users/DaftMonk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaftMonk/subscriptions","organizations_url":"https://api.github.com/users/DaftMonk/orgs","repos_url":"https://api.github.com/users/DaftMonk/repos","events_url":"https://api.github.com/users/DaftMonk/events{/privacy}","received_events_url":"https://api.github.com/users/DaftMonk/received_events","type":"User","site_admin":false},"repo":{"id":13911118,"name":"generator-angular-fullstack","full_name":"DaftMonk/generator-angular-fullstack","owner":{"login":"DaftMonk","id":2505273,"avatar_url":"https://avatars.githubusercontent.com/u/2505273?v=2","gravatar_id":"b80cadb42cceabbdd20fb3e615e7f50e","url":"https://api.github.com/users/DaftMonk","html_url":"https://github.com/DaftMonk","followers_url":"https://api.github.com/users/DaftMonk/followers","following_url":"https://api.github.com/users/DaftMonk/following{/other_user}","gists_url":"https://api.github.com/users/DaftMonk/gists{/gist_id}","starred_url":"https://api.github.com/users/DaftMonk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaftMonk/subscriptions","organizations_url":"https://api.github.com/users/DaftMonk/orgs","repos_url":"https://api.github.com/users/DaftMonk/repos","events_url":"https://api.github.com/users/DaftMonk/events{/privacy}","received_events_url":"https://api.github.com/users/DaftMonk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DaftMonk/generator-angular-fullstack","description":"Yeoman generator for AngularJS with an Express server","fork":true,"url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack","forks_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/forks","keys_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/teams","hooks_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/hooks","issue_events_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/issues/events{/number}","events_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/events","assignees_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/assignees{/user}","branches_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/branches{/branch}","tags_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/tags","blobs_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/statuses/{sha}","languages_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/languages","stargazers_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/stargazers","contributors_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/contributors","subscribers_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/subscribers","subscription_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/subscription","commits_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/issues/comments/{number}","contents_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/contents/{+path}","compare_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/merges","archive_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/downloads","issues_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/issues{/number}","pulls_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/pulls{/number}","milestones_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/milestones{/number}","notifications_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/labels{/name}","releases_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/releases{/id}","created_at":"2013-10-27T21:56:18Z","updated_at":"2014-08-17T17:15:28Z","pushed_at":"2014-08-17T03:49:54Z","git_url":"git://github.com/DaftMonk/generator-angular-fullstack.git","ssh_url":"git@github.com:DaftMonk/generator-angular-fullstack.git","clone_url":"https://github.com/DaftMonk/generator-angular-fullstack.git","svn_url":"https://github.com/DaftMonk/generator-angular-fullstack","homepage":"http://yeoman.io","size":9285,"stargazers_count":1660,"watchers_count":1660,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":276,"mirror_url":null,"open_issues_count":47,"forks":276,"open_issues":47,"watchers":1660,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/pulls/455"},"html":{"href":"https://github.com/DaftMonk/generator-angular-fullstack/pull/455"},"issue":{"href":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/issues/455"},"comments":{"href":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/issues/455/comments"},"review_comments":{"href":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/pulls/455/comments"},"review_comment":{"href":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/pulls/455/commits"},"statuses":{"href":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/statuses/06f2e46ef382b5af1691f34b6cf504f1e5640b86"}}}}