GitHub PullRequestEvent at 2014-05-29 12:08:14
Repository: friendly_id
Actor: norman
Payload: {"action":"closed","number":541,"pull_request":{"url":"https://api.github.com/repos/norman/friendly_id/pulls/541","id":13830745,"html_url":"https://github.com/norman/friendly_id/pull/541","diff_url":"https://github.com/norman/friendly_id/pull/541.diff","patch_url":"https://github.com/norman/friendly_id/pull/541.patch","issue_url":"https://api.github.com/repos/norman/friendly_id/issues/541","number":541,"state":"closed","title":"Fix regenerating slug when regeneration condition overriden (fixes #521)","user":{"login":"arnvald","id":135708,"avatar_url":"https://avatars.githubusercontent.com/u/135708?","gravatar_id":"afa6e65b91b46f3317c3d3e94e9255f2","url":"https://api.github.com/users/arnvald","html_url":"https://github.com/arnvald","followers_url":"https://api.github.com/users/arnvald/followers","following_url":"https://api.github.com/users/arnvald/following{/other_user}","gists_url":"https://api.github.com/users/arnvald/gists{/gist_id}","starred_url":"https://api.github.com/users/arnvald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arnvald/subscriptions","organizations_url":"https://api.github.com/users/arnvald/orgs","repos_url":"https://api.github.com/users/arnvald/repos","events_url":"https://api.github.com/users/arnvald/events{/privacy}","received_events_url":"https://api.github.com/users/arnvald/received_events","type":"User","site_admin":false},"body":"Currently the scope excluding updated object is applied when checking candidates\r\nonly if slug column is changed. This does not work in case when\r\nshould_generate_new_friendly_id? is overriden. This commit fixes the problem\r\nby always excluding updated object from checking candidates\r\n\r\nHere's the issue: https://github.com/norman/friendly_id/issues/521","created_at":"2014-03-21T10:59:24Z","updated_at":"2014-05-29T12:08:14Z","closed_at":"2014-05-29T12:08:14Z","merged_at":null,"merge_commit_sha":"21b1ea98563a5735124009cfc791e8dbce5d6d7d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/norman/friendly_id/pulls/541/commits","review_comments_url":"https://api.github.com/repos/norman/friendly_id/pulls/541/comments","review_comment_url":"https://api.github.com/repos/norman/friendly_id/pulls/comments/{number}","comments_url":"https://api.github.com/repos/norman/friendly_id/issues/541/comments","statuses_url":"https://api.github.com/repos/norman/friendly_id/statuses/be6cd68895ad3cd3c525b776975446a79ac3a1c0","head":{"label":"arnvald:fix-slug-regenerating","ref":"fix-slug-regenerating","sha":"be6cd68895ad3cd3c525b776975446a79ac3a1c0","user":{"login":"arnvald","id":135708,"avatar_url":"https://avatars.githubusercontent.com/u/135708?","gravatar_id":"afa6e65b91b46f3317c3d3e94e9255f2","url":"https://api.github.com/users/arnvald","html_url":"https://github.com/arnvald","followers_url":"https://api.github.com/users/arnvald/followers","following_url":"https://api.github.com/users/arnvald/following{/other_user}","gists_url":"https://api.github.com/users/arnvald/gists{/gist_id}","starred_url":"https://api.github.com/users/arnvald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arnvald/subscriptions","organizations_url":"https://api.github.com/users/arnvald/orgs","repos_url":"https://api.github.com/users/arnvald/repos","events_url":"https://api.github.com/users/arnvald/events{/privacy}","received_events_url":"https://api.github.com/users/arnvald/received_events","type":"User","site_admin":false},"repo":{"id":17976809,"name":"friendly_id","full_name":"arnvald/friendly_id","owner":{"login":"arnvald","id":135708,"avatar_url":"https://avatars.githubusercontent.com/u/135708?","gravatar_id":"afa6e65b91b46f3317c3d3e94e9255f2","url":"https://api.github.com/users/arnvald","html_url":"https://github.com/arnvald","followers_url":"https://api.github.com/users/arnvald/followers","following_url":"https://api.github.com/users/arnvald/following{/other_user}","gists_url":"https://api.github.com/users/arnvald/gists{/gist_id}","starred_url":"https://api.github.com/users/arnvald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arnvald/subscriptions","organizations_url":"https://api.github.com/users/arnvald/orgs","repos_url":"https://api.github.com/users/arnvald/repos","events_url":"https://api.github.com/users/arnvald/events{/privacy}","received_events_url":"https://api.github.com/users/arnvald/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arnvald/friendly_id","description":"FriendlyId is the “Swiss Army bulldozer” of slugging and permalink plugins for ActiveRecord. It allows you to create pretty URL’s and work with human-friendly strings as if they were numeric ids for ActiveRecord models.","fork":true,"url":"https://api.github.com/repos/arnvald/friendly_id","forks_url":"https://api.github.com/repos/arnvald/friendly_id/forks","keys_url":"https://api.github.com/repos/arnvald/friendly_id/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arnvald/friendly_id/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arnvald/friendly_id/teams","hooks_url":"https://api.github.com/repos/arnvald/friendly_id/hooks","issue_events_url":"https://api.github.com/repos/arnvald/friendly_id/issues/events{/number}","events_url":"https://api.github.com/repos/arnvald/friendly_id/events","assignees_url":"https://api.github.com/repos/arnvald/friendly_id/assignees{/user}","branches_url":"https://api.github.com/repos/arnvald/friendly_id/branches{/branch}","tags_url":"https://api.github.com/repos/arnvald/friendly_id/tags","blobs_url":"https://api.github.com/repos/arnvald/friendly_id/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arnvald/friendly_id/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arnvald/friendly_id/git/refs{/sha}","trees_url":"https://api.github.com/repos/arnvald/friendly_id/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arnvald/friendly_id/statuses/{sha}","languages_url":"https://api.github.com/repos/arnvald/friendly_id/languages","stargazers_url":"https://api.github.com/repos/arnvald/friendly_id/stargazers","contributors_url":"https://api.github.com/repos/arnvald/friendly_id/contributors","subscribers_url":"https://api.github.com/repos/arnvald/friendly_id/subscribers","subscription_url":"https://api.github.com/repos/arnvald/friendly_id/subscription","commits_url":"https://api.github.com/repos/arnvald/friendly_id/commits{/sha}","git_commits_url":"https://api.github.com/repos/arnvald/friendly_id/git/commits{/sha}","comments_url":"https://api.github.com/repos/arnvald/friendly_id/comments{/number}","issue_comment_url":"https://api.github.com/repos/arnvald/friendly_id/issues/comments/{number}","contents_url":"https://api.github.com/repos/arnvald/friendly_id/contents/{+path}","compare_url":"https://api.github.com/repos/arnvald/friendly_id/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arnvald/friendly_id/merges","archive_url":"https://api.github.com/repos/arnvald/friendly_id/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arnvald/friendly_id/downloads","issues_url":"https://api.github.com/repos/arnvald/friendly_id/issues{/number}","pulls_url":"https://api.github.com/repos/arnvald/friendly_id/pulls{/number}","milestones_url":"https://api.github.com/repos/arnvald/friendly_id/milestones{/number}","notifications_url":"https://api.github.com/repos/arnvald/friendly_id/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arnvald/friendly_id/labels{/name}","releases_url":"https://api.github.com/repos/arnvald/friendly_id/releases{/id}","created_at":"2014-03-21T10:48:31Z","updated_at":"2014-03-21T21:30:45Z","pushed_at":"2014-03-21T21:30:45Z","git_url":"git://github.com/arnvald/friendly_id.git","ssh_url":"git@github.com:arnvald/friendly_id.git","clone_url":"https://github.com/arnvald/friendly_id.git","svn_url":"https://github.com/arnvald/friendly_id","homepage":"http://norman.github.io/friendly_id/","size":4249,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"norman:master","ref":"master","sha":"fd11923c97fefb459ecd9e099ff6f318886361dc","user":{"login":"norman","id":5042,"avatar_url":"https://avatars.githubusercontent.com/u/5042?","gravatar_id":"b6621ca717b64e2e1717b2af82e3762b","url":"https://api.github.com/users/norman","html_url":"https://github.com/norman","followers_url":"https://api.github.com/users/norman/followers","following_url":"https://api.github.com/users/norman/following{/other_user}","gists_url":"https://api.github.com/users/norman/gists{/gist_id}","starred_url":"https://api.github.com/users/norman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/norman/subscriptions","organizations_url":"https://api.github.com/users/norman/orgs","repos_url":"https://api.github.com/users/norman/repos","events_url":"https://api.github.com/users/norman/events{/privacy}","received_events_url":"https://api.github.com/users/norman/received_events","type":"User","site_admin":false},"repo":{"id":10865,"name":"friendly_id","full_name":"norman/friendly_id","owner":{"login":"norman","id":5042,"avatar_url":"https://avatars.githubusercontent.com/u/5042?","gravatar_id":"b6621ca717b64e2e1717b2af82e3762b","url":"https://api.github.com/users/norman","html_url":"https://github.com/norman","followers_url":"https://api.github.com/users/norman/followers","following_url":"https://api.github.com/users/norman/following{/other_user}","gists_url":"https://api.github.com/users/norman/gists{/gist_id}","starred_url":"https://api.github.com/users/norman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/norman/subscriptions","organizations_url":"https://api.github.com/users/norman/orgs","repos_url":"https://api.github.com/users/norman/repos","events_url":"https://api.github.com/users/norman/events{/privacy}","received_events_url":"https://api.github.com/users/norman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/norman/friendly_id","description":"FriendlyId is the “Swiss Army bulldozer” of slugging and permalink plugins for ActiveRecord. It allows you to create pretty URL’s and work with human-friendly strings as if they were numeric ids for ActiveRecord models.","fork":false,"url":"https://api.github.com/repos/norman/friendly_id","forks_url":"https://api.github.com/repos/norman/friendly_id/forks","keys_url":"https://api.github.com/repos/norman/friendly_id/keys{/key_id}","collaborators_url":"https://api.github.com/repos/norman/friendly_id/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/norman/friendly_id/teams","hooks_url":"https://api.github.com/repos/norman/friendly_id/hooks","issue_events_url":"https://api.github.com/repos/norman/friendly_id/issues/events{/number}","events_url":"https://api.github.com/repos/norman/friendly_id/events","assignees_url":"https://api.github.com/repos/norman/friendly_id/assignees{/user}","branches_url":"https://api.github.com/repos/norman/friendly_id/branches{/branch}","tags_url":"https://api.github.com/repos/norman/friendly_id/tags","blobs_url":"https://api.github.com/repos/norman/friendly_id/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/norman/friendly_id/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/norman/friendly_id/git/refs{/sha}","trees_url":"https://api.github.com/repos/norman/friendly_id/git/trees{/sha}","statuses_url":"https://api.github.com/repos/norman/friendly_id/statuses/{sha}","languages_url":"https://api.github.com/repos/norman/friendly_id/languages","stargazers_url":"https://api.github.com/repos/norman/friendly_id/stargazers","contributors_url":"https://api.github.com/repos/norman/friendly_id/contributors","subscribers_url":"https://api.github.com/repos/norman/friendly_id/subscribers","subscription_url":"https://api.github.com/repos/norman/friendly_id/subscription","commits_url":"https://api.github.com/repos/norman/friendly_id/commits{/sha}","git_commits_url":"https://api.github.com/repos/norman/friendly_id/git/commits{/sha}","comments_url":"https://api.github.com/repos/norman/friendly_id/comments{/number}","issue_comment_url":"https://api.github.com/repos/norman/friendly_id/issues/comments/{number}","contents_url":"https://api.github.com/repos/norman/friendly_id/contents/{+path}","compare_url":"https://api.github.com/repos/norman/friendly_id/compare/{base}...{head}","merges_url":"https://api.github.com/repos/norman/friendly_id/merges","archive_url":"https://api.github.com/repos/norman/friendly_id/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/norman/friendly_id/downloads","issues_url":"https://api.github.com/repos/norman/friendly_id/issues{/number}","pulls_url":"https://api.github.com/repos/norman/friendly_id/pulls{/number}","milestones_url":"https://api.github.com/repos/norman/friendly_id/milestones{/number}","notifications_url":"https://api.github.com/repos/norman/friendly_id/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/norman/friendly_id/labels{/name}","releases_url":"https://api.github.com/repos/norman/friendly_id/releases{/id}","created_at":"2008-04-18T13:16:06Z","updated_at":"2014-05-29T12:06:45Z","pushed_at":"2014-05-29T12:06:45Z","git_url":"git://github.com/norman/friendly_id.git","ssh_url":"git@github.com:norman/friendly_id.git","clone_url":"https://github.com/norman/friendly_id.git","svn_url":"https://github.com/norman/friendly_id","homepage":"http://norman.github.io/friendly_id/","size":5651,"stargazers_count":2742,"watchers_count":2742,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":328,"mirror_url":null,"open_issues_count":20,"forks":328,"open_issues":20,"watchers":2742,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/norman/friendly_id/pulls/541"},"html":{"href":"https://github.com/norman/friendly_id/pull/541"},"issue":{"href":"https://api.github.com/repos/norman/friendly_id/issues/541"},"comments":{"href":"https://api.github.com/repos/norman/friendly_id/issues/541/comments"},"review_comments":{"href":"https://api.github.com/repos/norman/friendly_id/pulls/541/comments"},"review_comment":{"href":"https://api.github.com/repos/norman/friendly_id/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/norman/friendly_id/pulls/541/commits"},"statuses":{"href":"https://api.github.com/repos/norman/friendly_id/statuses/be6cd68895ad3cd3c525b776975446a79ac3a1c0"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":5,"review_comments":0,"commits":2,"additions":30,"deletions":9,"changed_files":4}}