GitHub PullRequestReviewCommentEvent at 2014-06-19 00:35:47
Repository: livefyre-auth
Actor: oncemoreification
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Livefyre/livefyre-auth/pulls/comments/13948628","id":13948628,"diff_hunk":"@@ -0,0 +1,83 @@\n+/**\n+ * @fileoverview More than just stub! Here we check if Livefyre auth is on the page. If it is, we use it.\n+ * If it isn't, then we fetch Livefyre.js and in set up a proxy/queue to the incoming Livefyre auth.\n+ */\n+\n+var getScript = require('../util/get-script');\n+var auth;\n+var hazAuth;\n+var pendingCalls;\n+\n+/**\n+ * Has auth arrived?\n+ */\n+function authHasArrived() {\n+    return typeof Livefyre !== 'undefined' && typeof Livefyre['auth'] === 'object';\n+}\n+\n+/**\n+ * Flush the pending calls now that auth has arrived\n+ */\n+function flushPendingCalls() {\n+    var methodCall;\n+    for (var i = 0; i < pendingCalls.length; i++) {\n+        methodCall = pendingCalls[i];\n+        auth[methodCall[0]].apply(auth, methodCall[1]);","path":"src/contrib/auth-later.js","position":25,"original_position":25,"commit_id":"89dc394aff9e4ddc16e139f552a5e1c625bc0f15","original_commit_id":"89dc394aff9e4ddc16e139f552a5e1c625bc0f15","user":{"login":"oncemoreification","id":1996632,"avatar_url":"https://avatars.githubusercontent.com/u/1996632?","gravatar_id":"9a57978f48846adf1344c537b46dbcfd","url":"https://api.github.com/users/oncemoreification","html_url":"https://github.com/oncemoreification","followers_url":"https://api.github.com/users/oncemoreification/followers","following_url":"https://api.github.com/users/oncemoreification/following{/other_user}","gists_url":"https://api.github.com/users/oncemoreification/gists{/gist_id}","starred_url":"https://api.github.com/users/oncemoreification/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oncemoreification/subscriptions","organizations_url":"https://api.github.com/users/oncemoreification/orgs","repos_url":"https://api.github.com/users/oncemoreification/repos","events_url":"https://api.github.com/users/oncemoreification/events{/privacy}","received_events_url":"https://api.github.com/users/oncemoreification/received_events","type":"User","site_admin":false},"body":"Indeed","created_at":"2014-06-19T00:35:47Z","updated_at":"2014-06-19T00:35:47Z","html_url":"https://github.com/Livefyre/livefyre-auth/pull/3#discussion_r13948628","pull_request_url":"https://api.github.com/repos/Livefyre/livefyre-auth/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/Livefyre/livefyre-auth/pulls/comments/13948628"},"html":{"href":"https://github.com/Livefyre/livefyre-auth/pull/3#discussion_r13948628"},"pull_request":{"href":"https://api.github.com/repos/Livefyre/livefyre-auth/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/Livefyre/livefyre-auth/pulls/3","id":17327248,"html_url":"https://github.com/Livefyre/livefyre-auth/pull/3","diff_url":"https://github.com/Livefyre/livefyre-auth/pull/3.diff","patch_url":"https://github.com/Livefyre/livefyre-auth/pull/3.patch","issue_url":"https://api.github.com/repos/Livefyre/livefyre-auth/issues/3","number":3,"state":"open","title":"Add auth-later, for using auth when it is loaded","user":{"login":"oncemoreification","id":1996632,"avatar_url":"https://avatars.githubusercontent.com/u/1996632?","gravatar_id":"9a57978f48846adf1344c537b46dbcfd","url":"https://api.github.com/users/oncemoreification","html_url":"https://github.com/oncemoreification","followers_url":"https://api.github.com/users/oncemoreification/followers","following_url":"https://api.github.com/users/oncemoreification/following{/other_user}","gists_url":"https://api.github.com/users/oncemoreification/gists{/gist_id}","starred_url":"https://api.github.com/users/oncemoreification/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oncemoreification/subscriptions","organizations_url":"https://api.github.com/users/oncemoreification/orgs","repos_url":"https://api.github.com/users/oncemoreification/repos","events_url":"https://api.github.com/users/oncemoreification/events{/privacy}","received_events_url":"https://api.github.com/users/oncemoreification/received_events","type":"User","site_admin":false},"body":"Depends on https://github.com/Livefyre/Livefyre.js/pull/6/\r\n\r\nand \r\n\r\nhttps://github.com/Livefyre/Livefyre-scout/pull/4\r\n\r\nDNM until testing with the above merges.","created_at":"2014-06-19T00:05:27Z","updated_at":"2014-06-19T00:35:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cefcdfbf86415f05b07087a9ec1ae5e560afe212","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Livefyre/livefyre-auth/pulls/3/commits","review_comments_url":"https://api.github.com/repos/Livefyre/livefyre-auth/pulls/3/comments","review_comment_url":"https://api.github.com/repos/Livefyre/livefyre-auth/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Livefyre/livefyre-auth/issues/3/comments","statuses_url":"https://api.github.com/repos/Livefyre/livefyre-auth/statuses/89dc394aff9e4ddc16e139f552a5e1c625bc0f15","head":{"label":"Livefyre:l_auth_later","ref":"l_auth_later","sha":"89dc394aff9e4ddc16e139f552a5e1c625bc0f15","user":{"login":"Livefyre","id":404382,"avatar_url":"https://avatars.githubusercontent.com/u/404382?","gravatar_id":"e23293c6dfc25b86762b045336233add","url":"https://api.github.com/users/Livefyre","html_url":"https://github.com/Livefyre","followers_url":"https://api.github.com/users/Livefyre/followers","following_url":"https://api.github.com/users/Livefyre/following{/other_user}","gists_url":"https://api.github.com/users/Livefyre/gists{/gist_id}","starred_url":"https://api.github.com/users/Livefyre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Livefyre/subscriptions","organizations_url":"https://api.github.com/users/Livefyre/orgs","repos_url":"https://api.github.com/users/Livefyre/repos","events_url":"https://api.github.com/users/Livefyre/events{/privacy}","received_events_url":"https://api.github.com/users/Livefyre/received_events","type":"Organization","site_admin":false},"repo":{"id":18896878,"name":"livefyre-auth","full_name":"Livefyre/livefyre-auth","owner":{"login":"Livefyre","id":404382,"avatar_url":"https://avatars.githubusercontent.com/u/404382?","gravatar_id":"e23293c6dfc25b86762b045336233add","url":"https://api.github.com/users/Livefyre","html_url":"https://github.com/Livefyre","followers_url":"https://api.github.com/users/Livefyre/followers","following_url":"https://api.github.com/users/Livefyre/following{/other_user}","gists_url":"https://api.github.com/users/Livefyre/gists{/gist_id}","starred_url":"https://api.github.com/users/Livefyre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Livefyre/subscriptions","organizations_url":"https://api.github.com/users/Livefyre/orgs","repos_url":"https://api.github.com/users/Livefyre/repos","events_url":"https://api.github.com/users/Livefyre/events{/privacy}","received_events_url":"https://api.github.com/users/Livefyre/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Livefyre/livefyre-auth","description":"Auth powered by Livefyre StreamHub","fork":true,"url":"https://api.github.com/repos/Livefyre/livefyre-auth","forks_url":"https://api.github.com/repos/Livefyre/livefyre-auth/forks","keys_url":"https://api.github.com/repos/Livefyre/livefyre-auth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Livefyre/livefyre-auth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Livefyre/livefyre-auth/teams","hooks_url":"https://api.github.com/repos/Livefyre/livefyre-auth/hooks","issue_events_url":"https://api.github.com/repos/Livefyre/livefyre-auth/issues/events{/number}","events_url":"https://api.github.com/repos/Livefyre/livefyre-auth/events","assignees_url":"https://api.github.com/repos/Livefyre/livefyre-auth/assignees{/user}","branches_url":"https://api.github.com/repos/Livefyre/livefyre-auth/branches{/branch}","tags_url":"https://api.github.com/repos/Livefyre/livefyre-auth/tags","blobs_url":"https://api.github.com/repos/Livefyre/livefyre-auth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Livefyre/livefyre-auth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Livefyre/livefyre-auth/git/refs{/sha}","trees_url":"https://api.github.com/repos/Livefyre/livefyre-auth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Livefyre/livefyre-auth/statuses/{sha}","languages_url":"https://api.github.com/repos/Livefyre/livefyre-auth/languages","stargazers_url":"https://api.github.com/repos/Livefyre/livefyre-auth/stargazers","contributors_url":"https://api.github.com/repos/Livefyre/livefyre-auth/contributors","subscribers_url":"https://api.github.com/repos/Livefyre/livefyre-auth/subscribers","subscription_url":"https://api.github.com/repos/Livefyre/livefyre-auth/subscription","commits_url":"https://api.github.com/repos/Livefyre/livefyre-auth/commits{/sha}","git_commits_url":"https://api.github.com/repos/Livefyre/livefyre-auth/git/commits{/sha}","comments_url":"https://api.github.com/repos/Livefyre/livefyre-auth/comments{/number}","issue_comment_url":"https://api.github.com/repos/Livefyre/livefyre-auth/issues/comments/{number}","contents_url":"https://api.github.com/repos/Livefyre/livefyre-auth/contents/{+path}","compare_url":"https://api.github.com/repos/Livefyre/livefyre-auth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Livefyre/livefyre-auth/merges","archive_url":"https://api.github.com/repos/Livefyre/livefyre-auth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Livefyre/livefyre-auth/downloads","issues_url":"https://api.github.com/repos/Livefyre/livefyre-auth/issues{/number}","pulls_url":"https://api.github.com/repos/Livefyre/livefyre-auth/pulls{/number}","milestones_url":"https://api.github.com/repos/Livefyre/livefyre-auth/milestones{/number}","notifications_url":"https://api.github.com/repos/Livefyre/livefyre-auth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Livefyre/livefyre-auth/labels{/name}","releases_url":"https://api.github.com/repos/Livefyre/livefyre-auth/releases{/id}","created_at":"2014-04-17T23:46:20Z","updated_at":"2014-06-19T00:05:27Z","pushed_at":"2014-06-19T00:03:44Z","git_url":"git://github.com/Livefyre/livefyre-auth.git","ssh_url":"git@github.com:Livefyre/livefyre-auth.git","clone_url":"https://github.com/Livefyre/livefyre-auth.git","svn_url":"https://github.com/Livefyre/livefyre-auth","homepage":"","size":444,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Livefyre:master","ref":"master","sha":"e08b80f519d8660caac6e3212d06af66595073f5","user":{"login":"Livefyre","id":404382,"avatar_url":"https://avatars.githubusercontent.com/u/404382?","gravatar_id":"e23293c6dfc25b86762b045336233add","url":"https://api.github.com/users/Livefyre","html_url":"https://github.com/Livefyre","followers_url":"https://api.github.com/users/Livefyre/followers","following_url":"https://api.github.com/users/Livefyre/following{/other_user}","gists_url":"https://api.github.com/users/Livefyre/gists{/gist_id}","starred_url":"https://api.github.com/users/Livefyre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Livefyre/subscriptions","organizations_url":"https://api.github.com/users/Livefyre/orgs","repos_url":"https://api.github.com/users/Livefyre/repos","events_url":"https://api.github.com/users/Livefyre/events{/privacy}","received_events_url":"https://api.github.com/users/Livefyre/received_events","type":"Organization","site_admin":false},"repo":{"id":18896878,"name":"livefyre-auth","full_name":"Livefyre/livefyre-auth","owner":{"login":"Livefyre","id":404382,"avatar_url":"https://avatars.githubusercontent.com/u/404382?","gravatar_id":"e23293c6dfc25b86762b045336233add","url":"https://api.github.com/users/Livefyre","html_url":"https://github.com/Livefyre","followers_url":"https://api.github.com/users/Livefyre/followers","following_url":"https://api.github.com/users/Livefyre/following{/other_user}","gists_url":"https://api.github.com/users/Livefyre/gists{/gist_id}","starred_url":"https://api.github.com/users/Livefyre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Livefyre/subscriptions","organizations_url":"https://api.github.com/users/Livefyre/orgs","repos_url":"https://api.github.com/users/Livefyre/repos","events_url":"https://api.github.com/users/Livefyre/events{/privacy}","received_events_url":"https://api.github.com/users/Livefyre/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Livefyre/livefyre-auth","description":"Auth powered by Livefyre StreamHub","fork":true,"url":"https://api.github.com/repos/Livefyre/livefyre-auth","forks_url":"https://api.github.com/repos/Livefyre/livefyre-auth/forks","keys_url":"https://api.github.com/repos/Livefyre/livefyre-auth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Livefyre/livefyre-auth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Livefyre/livefyre-auth/teams","hooks_url":"https://api.github.com/repos/Livefyre/livefyre-auth/hooks","issue_events_url":"https://api.github.com/repos/Livefyre/livefyre-auth/issues/events{/number}","events_url":"https://api.github.com/repos/Livefyre/livefyre-auth/events","assignees_url":"https://api.github.com/repos/Livefyre/livefyre-auth/assignees{/user}","branches_url":"https://api.github.com/repos/Livefyre/livefyre-auth/branches{/branch}","tags_url":"https://api.github.com/repos/Livefyre/livefyre-auth/tags","blobs_url":"https://api.github.com/repos/Livefyre/livefyre-auth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Livefyre/livefyre-auth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Livefyre/livefyre-auth/git/refs{/sha}","trees_url":"https://api.github.com/repos/Livefyre/livefyre-auth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Livefyre/livefyre-auth/statuses/{sha}","languages_url":"https://api.github.com/repos/Livefyre/livefyre-auth/languages","stargazers_url":"https://api.github.com/repos/Livefyre/livefyre-auth/stargazers","contributors_url":"https://api.github.com/repos/Livefyre/livefyre-auth/contributors","subscribers_url":"https://api.github.com/repos/Livefyre/livefyre-auth/subscribers","subscription_url":"https://api.github.com/repos/Livefyre/livefyre-auth/subscription","commits_url":"https://api.github.com/repos/Livefyre/livefyre-auth/commits{/sha}","git_commits_url":"https://api.github.com/repos/Livefyre/livefyre-auth/git/commits{/sha}","comments_url":"https://api.github.com/repos/Livefyre/livefyre-auth/comments{/number}","issue_comment_url":"https://api.github.com/repos/Livefyre/livefyre-auth/issues/comments/{number}","contents_url":"https://api.github.com/repos/Livefyre/livefyre-auth/contents/{+path}","compare_url":"https://api.github.com/repos/Livefyre/livefyre-auth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Livefyre/livefyre-auth/merges","archive_url":"https://api.github.com/repos/Livefyre/livefyre-auth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Livefyre/livefyre-auth/downloads","issues_url":"https://api.github.com/repos/Livefyre/livefyre-auth/issues{/number}","pulls_url":"https://api.github.com/repos/Livefyre/livefyre-auth/pulls{/number}","milestones_url":"https://api.github.com/repos/Livefyre/livefyre-auth/milestones{/number}","notifications_url":"https://api.github.com/repos/Livefyre/livefyre-auth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Livefyre/livefyre-auth/labels{/name}","releases_url":"https://api.github.com/repos/Livefyre/livefyre-auth/releases{/id}","created_at":"2014-04-17T23:46:20Z","updated_at":"2014-06-19T00:05:27Z","pushed_at":"2014-06-19T00:03:44Z","git_url":"git://github.com/Livefyre/livefyre-auth.git","ssh_url":"git@github.com:Livefyre/livefyre-auth.git","clone_url":"https://github.com/Livefyre/livefyre-auth.git","svn_url":"https://github.com/Livefyre/livefyre-auth","homepage":"","size":444,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Livefyre/livefyre-auth/pulls/3"},"html":{"href":"https://github.com/Livefyre/livefyre-auth/pull/3"},"issue":{"href":"https://api.github.com/repos/Livefyre/livefyre-auth/issues/3"},"comments":{"href":"https://api.github.com/repos/Livefyre/livefyre-auth/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/Livefyre/livefyre-auth/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/Livefyre/livefyre-auth/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Livefyre/livefyre-auth/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/Livefyre/livefyre-auth/statuses/89dc394aff9e4ddc16e139f552a5e1c625bc0f15"}}}}