GitHub PullRequestReviewCommentEvent at 2014-07-17 01:05:48
Repository: ServiceWorker
Actor: cvan
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/slightlyoff/ServiceWorker/pulls/comments/15037245","id":15037245,"diff_hunk":"@@ -94,8 +94,8 @@ Aside from `importScripts()`, no synchronous APIs are available to SWs. This is\n \n #### Strategies\n \n-  * __Prioritize the SW thread__. SW execution is likely to be a sensitive component of overall application performance. Ensure it isn't getting descheduled!\n-  * __Warn on long periods of SW-thread work__. Remaining responsive requires yeilding to the SW thread's event loop. DevTools can provide value by warning developers of long periods of potentially-blocking work that might reduce responsiveness to incoming events. A reasonable, mobile-friendly starting point might be to warn on any function that takes longer than 20ms to return in the fast path (e.g., `onfetch` or `onmessage`). Recommend to users that they move long-running work to sub-workers, to other turns (via new promises), or that they cache expensive work such that it can be returned via an async API (e.g. IDB).\n+  * __Prioritize the SW thread__. SW execution is likely to be a sensitive component of overall application performance. Ensure it isn't getting unscheduled!","path":"implementation_considerations.md","position":41,"original_position":41,"commit_id":"a604d7effa7ff41d75a852a2992753a4b677fef1","original_commit_id":"a604d7effa7ff41d75a852a2992753a4b677fef1","user":{"login":"cvan","id":203725,"avatar_url":"https://avatars.githubusercontent.com/u/203725?","gravatar_id":"47de0e6948b289c9b4b4be0d6d66c0f4","url":"https://api.github.com/users/cvan","html_url":"https://github.com/cvan","followers_url":"https://api.github.com/users/cvan/followers","following_url":"https://api.github.com/users/cvan/following{/other_user}","gists_url":"https://api.github.com/users/cvan/gists{/gist_id}","starred_url":"https://api.github.com/users/cvan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cvan/subscriptions","organizations_url":"https://api.github.com/users/cvan/orgs","repos_url":"https://api.github.com/users/cvan/repos","events_url":"https://api.github.com/users/cvan/events{/privacy}","received_events_url":"https://api.github.com/users/cvan/received_events","type":"User","site_admin":false},"body":"changed \"descheduled\" to \"unscheduled\"","created_at":"2014-07-17T01:05:48Z","updated_at":"2014-07-17T01:05:48Z","html_url":"https://github.com/slightlyoff/ServiceWorker/pull/370#discussion_r15037245","pull_request_url":"https://api.github.com/repos/slightlyoff/ServiceWorker/pulls/370","_links":{"self":{"href":"https://api.github.com/repos/slightlyoff/ServiceWorker/pulls/comments/15037245"},"html":{"href":"https://github.com/slightlyoff/ServiceWorker/pull/370#discussion_r15037245"},"pull_request":{"href":"https://api.github.com/repos/slightlyoff/ServiceWorker/pulls/370"}}},"pull_request":{"url":"https://api.github.com/repos/slightlyoff/ServiceWorker/pulls/370","id":18504895,"html_url":"https://github.com/slightlyoff/ServiceWorker/pull/370","diff_url":"https://github.com/slightlyoff/ServiceWorker/pull/370.diff","patch_url":"https://github.com/slightlyoff/ServiceWorker/pull/370.patch","issue_url":"https://api.github.com/repos/slightlyoff/ServiceWorker/issues/370","number":370,"state":"open","title":"fix typos in Implementation Considerations section","user":{"login":"cvan","id":203725,"avatar_url":"https://avatars.githubusercontent.com/u/203725?","gravatar_id":"47de0e6948b289c9b4b4be0d6d66c0f4","url":"https://api.github.com/users/cvan","html_url":"https://github.com/cvan","followers_url":"https://api.github.com/users/cvan/followers","following_url":"https://api.github.com/users/cvan/following{/other_user}","gists_url":"https://api.github.com/users/cvan/gists{/gist_id}","starred_url":"https://api.github.com/users/cvan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cvan/subscriptions","organizations_url":"https://api.github.com/users/cvan/orgs","repos_url":"https://api.github.com/users/cvan/repos","events_url":"https://api.github.com/users/cvan/events{/privacy}","received_events_url":"https://api.github.com/users/cvan/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-07-17T01:04:47Z","updated_at":"2014-07-17T01:05:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b47e19a22ae713b8be0f0edce1a4b7c5815e9ba2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/slightlyoff/ServiceWorker/pulls/370/commits","review_comments_url":"https://api.github.com/repos/slightlyoff/ServiceWorker/pulls/370/comments","review_comment_url":"https://api.github.com/repos/slightlyoff/ServiceWorker/pulls/comments/{number}","comments_url":"https://api.github.com/repos/slightlyoff/ServiceWorker/issues/370/comments","statuses_url":"https://api.github.com/repos/slightlyoff/ServiceWorker/statuses/a604d7effa7ff41d75a852a2992753a4b677fef1","head":{"label":"cvan:patch-4","ref":"patch-4","sha":"a604d7effa7ff41d75a852a2992753a4b677fef1","user":{"login":"cvan","id":203725,"avatar_url":"https://avatars.githubusercontent.com/u/203725?","gravatar_id":"47de0e6948b289c9b4b4be0d6d66c0f4","url":"https://api.github.com/users/cvan","html_url":"https://github.com/cvan","followers_url":"https://api.github.com/users/cvan/followers","following_url":"https://api.github.com/users/cvan/following{/other_user}","gists_url":"https://api.github.com/users/cvan/gists{/gist_id}","starred_url":"https://api.github.com/users/cvan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cvan/subscriptions","organizations_url":"https://api.github.com/users/cvan/orgs","repos_url":"https://api.github.com/users/cvan/repos","events_url":"https://api.github.com/users/cvan/events{/privacy}","received_events_url":"https://api.github.com/users/cvan/received_events","type":"User","site_admin":false},"repo":{"id":21923461,"name":"ServiceWorker","full_name":"cvan/ServiceWorker","owner":{"login":"cvan","id":203725,"avatar_url":"https://avatars.githubusercontent.com/u/203725?","gravatar_id":"47de0e6948b289c9b4b4be0d6d66c0f4","url":"https://api.github.com/users/cvan","html_url":"https://github.com/cvan","followers_url":"https://api.github.com/users/cvan/followers","following_url":"https://api.github.com/users/cvan/following{/other_user}","gists_url":"https://api.github.com/users/cvan/gists{/gist_id}","starred_url":"https://api.github.com/users/cvan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cvan/subscriptions","organizations_url":"https://api.github.com/users/cvan/orgs","repos_url":"https://api.github.com/users/cvan/repos","events_url":"https://api.github.com/users/cvan/events{/privacy}","received_events_url":"https://api.github.com/users/cvan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cvan/ServiceWorker","description":"The Service Worker Specification","fork":true,"url":"https://api.github.com/repos/cvan/ServiceWorker","forks_url":"https://api.github.com/repos/cvan/ServiceWorker/forks","keys_url":"https://api.github.com/repos/cvan/ServiceWorker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cvan/ServiceWorker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cvan/ServiceWorker/teams","hooks_url":"https://api.github.com/repos/cvan/ServiceWorker/hooks","issue_events_url":"https://api.github.com/repos/cvan/ServiceWorker/issues/events{/number}","events_url":"https://api.github.com/repos/cvan/ServiceWorker/events","assignees_url":"https://api.github.com/repos/cvan/ServiceWorker/assignees{/user}","branches_url":"https://api.github.com/repos/cvan/ServiceWorker/branches{/branch}","tags_url":"https://api.github.com/repos/cvan/ServiceWorker/tags","blobs_url":"https://api.github.com/repos/cvan/ServiceWorker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cvan/ServiceWorker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cvan/ServiceWorker/git/refs{/sha}","trees_url":"https://api.github.com/repos/cvan/ServiceWorker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cvan/ServiceWorker/statuses/{sha}","languages_url":"https://api.github.com/repos/cvan/ServiceWorker/languages","stargazers_url":"https://api.github.com/repos/cvan/ServiceWorker/stargazers","contributors_url":"https://api.github.com/repos/cvan/ServiceWorker/contributors","subscribers_url":"https://api.github.com/repos/cvan/ServiceWorker/subscribers","subscription_url":"https://api.github.com/repos/cvan/ServiceWorker/subscription","commits_url":"https://api.github.com/repos/cvan/ServiceWorker/commits{/sha}","git_commits_url":"https://api.github.com/repos/cvan/ServiceWorker/git/commits{/sha}","comments_url":"https://api.github.com/repos/cvan/ServiceWorker/comments{/number}","issue_comment_url":"https://api.github.com/repos/cvan/ServiceWorker/issues/comments/{number}","contents_url":"https://api.github.com/repos/cvan/ServiceWorker/contents/{+path}","compare_url":"https://api.github.com/repos/cvan/ServiceWorker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cvan/ServiceWorker/merges","archive_url":"https://api.github.com/repos/cvan/ServiceWorker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cvan/ServiceWorker/downloads","issues_url":"https://api.github.com/repos/cvan/ServiceWorker/issues{/number}","pulls_url":"https://api.github.com/repos/cvan/ServiceWorker/pulls{/number}","milestones_url":"https://api.github.com/repos/cvan/ServiceWorker/milestones{/number}","notifications_url":"https://api.github.com/repos/cvan/ServiceWorker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cvan/ServiceWorker/labels{/name}","releases_url":"https://api.github.com/repos/cvan/ServiceWorker/releases{/id}","created_at":"2014-07-17T00:50:52Z","updated_at":"2014-07-17T01:04:26Z","pushed_at":"2014-07-17T01:04:27Z","git_url":"git://github.com/cvan/ServiceWorker.git","ssh_url":"git@github.com:cvan/ServiceWorker.git","clone_url":"https://github.com/cvan/ServiceWorker.git","svn_url":"https://github.com/cvan/ServiceWorker","homepage":"","size":5699,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"slightlyoff:master","ref":"master","sha":"8a428b200db5fae9fd6f9f3c619069f7919c1322","user":{"login":"slightlyoff","id":97331,"avatar_url":"https://avatars.githubusercontent.com/u/97331?","gravatar_id":"fa879184c044e4bcb6997785955b003b","url":"https://api.github.com/users/slightlyoff","html_url":"https://github.com/slightlyoff","followers_url":"https://api.github.com/users/slightlyoff/followers","following_url":"https://api.github.com/users/slightlyoff/following{/other_user}","gists_url":"https://api.github.com/users/slightlyoff/gists{/gist_id}","starred_url":"https://api.github.com/users/slightlyoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slightlyoff/subscriptions","organizations_url":"https://api.github.com/users/slightlyoff/orgs","repos_url":"https://api.github.com/users/slightlyoff/repos","events_url":"https://api.github.com/users/slightlyoff/events{/privacy}","received_events_url":"https://api.github.com/users/slightlyoff/received_events","type":"User","site_admin":false},"repo":{"id":8071542,"name":"ServiceWorker","full_name":"slightlyoff/ServiceWorker","owner":{"login":"slightlyoff","id":97331,"avatar_url":"https://avatars.githubusercontent.com/u/97331?","gravatar_id":"fa879184c044e4bcb6997785955b003b","url":"https://api.github.com/users/slightlyoff","html_url":"https://github.com/slightlyoff","followers_url":"https://api.github.com/users/slightlyoff/followers","following_url":"https://api.github.com/users/slightlyoff/following{/other_user}","gists_url":"https://api.github.com/users/slightlyoff/gists{/gist_id}","starred_url":"https://api.github.com/users/slightlyoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slightlyoff/subscriptions","organizations_url":"https://api.github.com/users/slightlyoff/orgs","repos_url":"https://api.github.com/users/slightlyoff/repos","events_url":"https://api.github.com/users/slightlyoff/events{/privacy}","received_events_url":"https://api.github.com/users/slightlyoff/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/slightlyoff/ServiceWorker","description":"The Service Worker Specification","fork":false,"url":"https://api.github.com/repos/slightlyoff/ServiceWorker","forks_url":"https://api.github.com/repos/slightlyoff/ServiceWorker/forks","keys_url":"https://api.github.com/repos/slightlyoff/ServiceWorker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slightlyoff/ServiceWorker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slightlyoff/ServiceWorker/teams","hooks_url":"https://api.github.com/repos/slightlyoff/ServiceWorker/hooks","issue_events_url":"https://api.github.com/repos/slightlyoff/ServiceWorker/issues/events{/number}","events_url":"https://api.github.com/repos/slightlyoff/ServiceWorker/events","assignees_url":"https://api.github.com/repos/slightlyoff/ServiceWorker/assignees{/user}","branches_url":"https://api.github.com/repos/slightlyoff/ServiceWorker/branches{/branch}","tags_url":"https://api.github.com/repos/slightlyoff/ServiceWorker/tags","blobs_url":"https://api.github.com/repos/slightlyoff/ServiceWorker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slightlyoff/ServiceWorker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slightlyoff/ServiceWorker/git/refs{/sha}","trees_url":"https://api.github.com/repos/slightlyoff/ServiceWorker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slightlyoff/ServiceWorker/statuses/{sha}","languages_url":"https://api.github.com/repos/slightlyoff/ServiceWorker/languages","stargazers_url":"https://api.github.com/repos/slightlyoff/ServiceWorker/stargazers","contributors_url":"https://api.github.com/repos/slightlyoff/ServiceWorker/contributors","subscribers_url":"https://api.github.com/repos/slightlyoff/ServiceWorker/subscribers","subscription_url":"https://api.github.com/repos/slightlyoff/ServiceWorker/subscription","commits_url":"https://api.github.com/repos/slightlyoff/ServiceWorker/commits{/sha}","git_commits_url":"https://api.github.com/repos/slightlyoff/ServiceWorker/git/commits{/sha}","comments_url":"https://api.github.com/repos/slightlyoff/ServiceWorker/comments{/number}","issue_comment_url":"https://api.github.com/repos/slightlyoff/ServiceWorker/issues/comments/{number}","contents_url":"https://api.github.com/repos/slightlyoff/ServiceWorker/contents/{+path}","compare_url":"https://api.github.com/repos/slightlyoff/ServiceWorker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slightlyoff/ServiceWorker/merges","archive_url":"https://api.github.com/repos/slightlyoff/ServiceWorker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slightlyoff/ServiceWorker/downloads","issues_url":"https://api.github.com/repos/slightlyoff/ServiceWorker/issues{/number}","pulls_url":"https://api.github.com/repos/slightlyoff/ServiceWorker/pulls{/number}","milestones_url":"https://api.github.com/repos/slightlyoff/ServiceWorker/milestones{/number}","notifications_url":"https://api.github.com/repos/slightlyoff/ServiceWorker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slightlyoff/ServiceWorker/labels{/name}","releases_url":"https://api.github.com/repos/slightlyoff/ServiceWorker/releases{/id}","created_at":"2013-02-07T11:23:04Z","updated_at":"2014-07-16T21:52:37Z","pushed_at":"2014-07-11T15:42:41Z","git_url":"git://github.com/slightlyoff/ServiceWorker.git","ssh_url":"git@github.com:slightlyoff/ServiceWorker.git","clone_url":"https://github.com/slightlyoff/ServiceWorker.git","svn_url":"https://github.com/slightlyoff/ServiceWorker","homepage":"","size":5699,"stargazers_count":665,"watchers_count":665,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":64,"mirror_url":null,"open_issues_count":120,"forks":64,"open_issues":120,"watchers":665,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/slightlyoff/ServiceWorker/pulls/370"},"html":{"href":"https://github.com/slightlyoff/ServiceWorker/pull/370"},"issue":{"href":"https://api.github.com/repos/slightlyoff/ServiceWorker/issues/370"},"comments":{"href":"https://api.github.com/repos/slightlyoff/ServiceWorker/issues/370/comments"},"review_comments":{"href":"https://api.github.com/repos/slightlyoff/ServiceWorker/pulls/370/comments"},"review_comment":{"href":"https://api.github.com/repos/slightlyoff/ServiceWorker/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/slightlyoff/ServiceWorker/pulls/370/commits"},"statuses":{"href":"https://api.github.com/repos/slightlyoff/ServiceWorker/statuses/a604d7effa7ff41d75a852a2992753a4b677fef1"}}}}