GitHub PullRequestReviewCommentEvent at 2014-09-12 05:19:36
Repository: dmd
Actor: redstar
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/comments/17463413","id":17463413,"diff_hunk":"@@ -205,6 +219,9 @@ void builtin_init()\n \n     // @safe @nogc pure nothrow uint function(uint)\n     add_builtin(\"_D4core5bitop5bswapFNaNbNiNfkZk\", &eval_bswap);\n+\n+    // @safe @nogc pure nothrow uint function(uint)\n+    add_builtin(\"_D4core5bitop6popcntFNaNbNiNfkZi\", &eval_popcnt);","path":"src/builtin.c","position":null,"original_position":27,"commit_id":"864be89f5d3f582029c4b7ff0d67985f48450a19","original_commit_id":"897705c66ac431fb22aa9a843ed6218baa8e7873","user":{"login":"redstar","id":827859,"avatar_url":"https://avatars.githubusercontent.com/u/827859?v=2","gravatar_id":"07fa101e259a81d072e61abaa4caba5a","url":"https://api.github.com/users/redstar","html_url":"https://github.com/redstar","followers_url":"https://api.github.com/users/redstar/followers","following_url":"https://api.github.com/users/redstar/following{/other_user}","gists_url":"https://api.github.com/users/redstar/gists{/gist_id}","starred_url":"https://api.github.com/users/redstar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redstar/subscriptions","organizations_url":"https://api.github.com/users/redstar/orgs","repos_url":"https://api.github.com/users/redstar/repos","events_url":"https://api.github.com/users/redstar/events{/privacy}","received_events_url":"https://api.github.com/users/redstar/received_events","type":"User","site_admin":false},"body":"I really missed that. It is now reflected in the test, too.","created_at":"2014-09-12T05:19:36Z","updated_at":"2014-09-12T05:19:36Z","html_url":"https://github.com/D-Programming-Language/dmd/pull/3975#discussion_r17463413","pull_request_url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/3975","_links":{"self":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/comments/17463413"},"html":{"href":"https://github.com/D-Programming-Language/dmd/pull/3975#discussion_r17463413"},"pull_request":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/3975"}}},"pull_request":{"url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/3975","id":21066862,"html_url":"https://github.com/D-Programming-Language/dmd/pull/3975","diff_url":"https://github.com/D-Programming-Language/dmd/pull/3975.diff","patch_url":"https://github.com/D-Programming-Language/dmd/pull/3975.patch","issue_url":"https://api.github.com/repos/D-Programming-Language/dmd/issues/3975","number":3975,"state":"open","locked":false,"title":"Create builtin for popcnt.","user":{"login":"redstar","id":827859,"avatar_url":"https://avatars.githubusercontent.com/u/827859?v=2","gravatar_id":"07fa101e259a81d072e61abaa4caba5a","url":"https://api.github.com/users/redstar","html_url":"https://github.com/redstar","followers_url":"https://api.github.com/users/redstar/followers","following_url":"https://api.github.com/users/redstar/following{/other_user}","gists_url":"https://api.github.com/users/redstar/gists{/gist_id}","starred_url":"https://api.github.com/users/redstar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redstar/subscriptions","organizations_url":"https://api.github.com/users/redstar/orgs","repos_url":"https://api.github.com/users/redstar/repos","events_url":"https://api.github.com/users/redstar/events{/privacy}","received_events_url":"https://api.github.com/users/redstar/received_events","type":"User","site_admin":false},"body":"As suggested by @klickverbot popcnt should be a builtin as it is now an intrinsic.","created_at":"2014-09-11T05:12:54Z","updated_at":"2014-09-12T05:19:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1e740bf937a89351d2151d8ebb5d2575210e8532","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/3975/commits","review_comments_url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/3975/comments","review_comment_url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/comments/{number}","comments_url":"https://api.github.com/repos/D-Programming-Language/dmd/issues/3975/comments","statuses_url":"https://api.github.com/repos/D-Programming-Language/dmd/statuses/864be89f5d3f582029c4b7ff0d67985f48450a19","head":{"label":"redstar:popcnt","ref":"popcnt","sha":"864be89f5d3f582029c4b7ff0d67985f48450a19","user":{"login":"redstar","id":827859,"avatar_url":"https://avatars.githubusercontent.com/u/827859?v=2","gravatar_id":"07fa101e259a81d072e61abaa4caba5a","url":"https://api.github.com/users/redstar","html_url":"https://github.com/redstar","followers_url":"https://api.github.com/users/redstar/followers","following_url":"https://api.github.com/users/redstar/following{/other_user}","gists_url":"https://api.github.com/users/redstar/gists{/gist_id}","starred_url":"https://api.github.com/users/redstar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redstar/subscriptions","organizations_url":"https://api.github.com/users/redstar/orgs","repos_url":"https://api.github.com/users/redstar/repos","events_url":"https://api.github.com/users/redstar/events{/privacy}","received_events_url":"https://api.github.com/users/redstar/received_events","type":"User","site_admin":false},"repo":{"id":2292778,"name":"dmd","full_name":"redstar/dmd","owner":{"login":"redstar","id":827859,"avatar_url":"https://avatars.githubusercontent.com/u/827859?v=2","gravatar_id":"07fa101e259a81d072e61abaa4caba5a","url":"https://api.github.com/users/redstar","html_url":"https://github.com/redstar","followers_url":"https://api.github.com/users/redstar/followers","following_url":"https://api.github.com/users/redstar/following{/other_user}","gists_url":"https://api.github.com/users/redstar/gists{/gist_id}","starred_url":"https://api.github.com/users/redstar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redstar/subscriptions","organizations_url":"https://api.github.com/users/redstar/orgs","repos_url":"https://api.github.com/users/redstar/repos","events_url":"https://api.github.com/users/redstar/events{/privacy}","received_events_url":"https://api.github.com/users/redstar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/redstar/dmd","description":"dmd D Programming Language compiler","fork":true,"url":"https://api.github.com/repos/redstar/dmd","forks_url":"https://api.github.com/repos/redstar/dmd/forks","keys_url":"https://api.github.com/repos/redstar/dmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/redstar/dmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/redstar/dmd/teams","hooks_url":"https://api.github.com/repos/redstar/dmd/hooks","issue_events_url":"https://api.github.com/repos/redstar/dmd/issues/events{/number}","events_url":"https://api.github.com/repos/redstar/dmd/events","assignees_url":"https://api.github.com/repos/redstar/dmd/assignees{/user}","branches_url":"https://api.github.com/repos/redstar/dmd/branches{/branch}","tags_url":"https://api.github.com/repos/redstar/dmd/tags","blobs_url":"https://api.github.com/repos/redstar/dmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/redstar/dmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/redstar/dmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/redstar/dmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/redstar/dmd/statuses/{sha}","languages_url":"https://api.github.com/repos/redstar/dmd/languages","stargazers_url":"https://api.github.com/repos/redstar/dmd/stargazers","contributors_url":"https://api.github.com/repos/redstar/dmd/contributors","subscribers_url":"https://api.github.com/repos/redstar/dmd/subscribers","subscription_url":"https://api.github.com/repos/redstar/dmd/subscription","commits_url":"https://api.github.com/repos/redstar/dmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/redstar/dmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/redstar/dmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/redstar/dmd/issues/comments/{number}","contents_url":"https://api.github.com/repos/redstar/dmd/contents/{+path}","compare_url":"https://api.github.com/repos/redstar/dmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/redstar/dmd/merges","archive_url":"https://api.github.com/repos/redstar/dmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/redstar/dmd/downloads","issues_url":"https://api.github.com/repos/redstar/dmd/issues{/number}","pulls_url":"https://api.github.com/repos/redstar/dmd/pulls{/number}","milestones_url":"https://api.github.com/repos/redstar/dmd/milestones{/number}","notifications_url":"https://api.github.com/repos/redstar/dmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/redstar/dmd/labels{/name}","releases_url":"https://api.github.com/repos/redstar/dmd/releases{/id}","created_at":"2011-08-30T04:08:19Z","updated_at":"2014-06-28T16:33:39Z","pushed_at":"2014-09-12T05:18:09Z","git_url":"git://github.com/redstar/dmd.git","ssh_url":"git@github.com:redstar/dmd.git","clone_url":"https://github.com/redstar/dmd.git","svn_url":"https://github.com/redstar/dmd","homepage":"d-programming-language.org","size":38442,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"D-Programming-Language:master","ref":"master","sha":"60d965ee06ddb78c5a18590c01517cbf0cad892e","user":{"login":"D-Programming-Language","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=2","gravatar_id":"1fe90c0586802aee103ff9ac0b8f3fbe","url":"https://api.github.com/users/D-Programming-Language","html_url":"https://github.com/D-Programming-Language","followers_url":"https://api.github.com/users/D-Programming-Language/followers","following_url":"https://api.github.com/users/D-Programming-Language/following{/other_user}","gists_url":"https://api.github.com/users/D-Programming-Language/gists{/gist_id}","starred_url":"https://api.github.com/users/D-Programming-Language/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D-Programming-Language/subscriptions","organizations_url":"https://api.github.com/users/D-Programming-Language/orgs","repos_url":"https://api.github.com/users/D-Programming-Language/repos","events_url":"https://api.github.com/users/D-Programming-Language/events{/privacy}","received_events_url":"https://api.github.com/users/D-Programming-Language/received_events","type":"Organization","site_admin":false},"repo":{"id":1257070,"name":"dmd","full_name":"D-Programming-Language/dmd","owner":{"login":"D-Programming-Language","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=2","gravatar_id":"1fe90c0586802aee103ff9ac0b8f3fbe","url":"https://api.github.com/users/D-Programming-Language","html_url":"https://github.com/D-Programming-Language","followers_url":"https://api.github.com/users/D-Programming-Language/followers","following_url":"https://api.github.com/users/D-Programming-Language/following{/other_user}","gists_url":"https://api.github.com/users/D-Programming-Language/gists{/gist_id}","starred_url":"https://api.github.com/users/D-Programming-Language/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D-Programming-Language/subscriptions","organizations_url":"https://api.github.com/users/D-Programming-Language/orgs","repos_url":"https://api.github.com/users/D-Programming-Language/repos","events_url":"https://api.github.com/users/D-Programming-Language/events{/privacy}","received_events_url":"https://api.github.com/users/D-Programming-Language/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/D-Programming-Language/dmd","description":"dmd D Programming Language compiler","fork":false,"url":"https://api.github.com/repos/D-Programming-Language/dmd","forks_url":"https://api.github.com/repos/D-Programming-Language/dmd/forks","keys_url":"https://api.github.com/repos/D-Programming-Language/dmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/D-Programming-Language/dmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/D-Programming-Language/dmd/teams","hooks_url":"https://api.github.com/repos/D-Programming-Language/dmd/hooks","issue_events_url":"https://api.github.com/repos/D-Programming-Language/dmd/issues/events{/number}","events_url":"https://api.github.com/repos/D-Programming-Language/dmd/events","assignees_url":"https://api.github.com/repos/D-Programming-Language/dmd/assignees{/user}","branches_url":"https://api.github.com/repos/D-Programming-Language/dmd/branches{/branch}","tags_url":"https://api.github.com/repos/D-Programming-Language/dmd/tags","blobs_url":"https://api.github.com/repos/D-Programming-Language/dmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/D-Programming-Language/dmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/D-Programming-Language/dmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/D-Programming-Language/dmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/D-Programming-Language/dmd/statuses/{sha}","languages_url":"https://api.github.com/repos/D-Programming-Language/dmd/languages","stargazers_url":"https://api.github.com/repos/D-Programming-Language/dmd/stargazers","contributors_url":"https://api.github.com/repos/D-Programming-Language/dmd/contributors","subscribers_url":"https://api.github.com/repos/D-Programming-Language/dmd/subscribers","subscription_url":"https://api.github.com/repos/D-Programming-Language/dmd/subscription","commits_url":"https://api.github.com/repos/D-Programming-Language/dmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/D-Programming-Language/dmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/D-Programming-Language/dmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/D-Programming-Language/dmd/issues/comments/{number}","contents_url":"https://api.github.com/repos/D-Programming-Language/dmd/contents/{+path}","compare_url":"https://api.github.com/repos/D-Programming-Language/dmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/D-Programming-Language/dmd/merges","archive_url":"https://api.github.com/repos/D-Programming-Language/dmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/D-Programming-Language/dmd/downloads","issues_url":"https://api.github.com/repos/D-Programming-Language/dmd/issues{/number}","pulls_url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls{/number}","milestones_url":"https://api.github.com/repos/D-Programming-Language/dmd/milestones{/number}","notifications_url":"https://api.github.com/repos/D-Programming-Language/dmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/D-Programming-Language/dmd/labels{/name}","releases_url":"https://api.github.com/repos/D-Programming-Language/dmd/releases{/id}","created_at":"2011-01-15T06:53:53Z","updated_at":"2014-09-12T05:09:31Z","pushed_at":"2014-09-11T23:11:49Z","git_url":"git://github.com/D-Programming-Language/dmd.git","ssh_url":"git@github.com:D-Programming-Language/dmd.git","clone_url":"https://github.com/D-Programming-Language/dmd.git","svn_url":"https://github.com/D-Programming-Language/dmd","homepage":"dlang.org","size":84130,"stargazers_count":815,"watchers_count":815,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":258,"mirror_url":null,"open_issues_count":95,"forks":258,"open_issues":95,"watchers":815,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/3975"},"html":{"href":"https://github.com/D-Programming-Language/dmd/pull/3975"},"issue":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/issues/3975"},"comments":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/issues/3975/comments"},"review_comments":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/3975/comments"},"review_comment":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/3975/commits"},"statuses":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/statuses/864be89f5d3f582029c4b7ff0d67985f48450a19"}}}}