GitHub PushEvent at 2014-12-15 23:29:30
Repository: chapel
Actor: ronawho
Payload: {"shas":[["9c2cd541d55c031d4076f88a3a6d5a6c4c3b34a1","a0eed57aaedf007a763cbac2dd65f90f9fe7ec18@gmail.com","Change name of _build_range to be more explicit\n\nSplitting the _build_range functions into 2 functions: chpl_build_bounded_range\nand chpl_build_unbounded_range. This is for the upcoming anonymous range\niteration optimization where we want a clean way to find fully bounded ranges\nearly in compilation.\n\nAdded a chpl_ prefix instead of keeping the single underscore since that's the\ndirection we want to move with internal functions.","Elliot Ronaghan",true],["9d75aa51f636de9188a19db0a1013ec70ed3cd52","a0eed57aaedf007a763cbac2dd65f90f9fe7ec18@gmail.com","Update errors for malformed param ranges\n\nAdd the fact that param ranges must be bounded to the error messages","Elliot Ronaghan",true],["6479176d5dfc8c6c33a338faee0c1d2666ba8340","a0eed57aaedf007a763cbac2dd65f90f9fe7ec18@gmail.com","Missed adding an ==0 for strcmp","Elliot Ronaghan",true],["735cb41a965f506dd5fd4139694a01372e1468e4","a0eed57aaedf007a763cbac2dd65f90f9fe7ec18@gmail.com","Need to add an error case for invalid types on partially bounded ranges\n\nSince all the range builders used to have the same name, and the partially\nbounded ranges and fully bounded ranges took the same number of parameters, the\ngeneric error case applied to unbounded ranges as well. It no longer does since\nthe names are different so adding an error case.","Elliot Ronaghan",true],["ad51c6cc8923b48307874b77dd53ac1816bc1f9b","a0eed57aaedf007a763cbac2dd65f90f9fe7ec18@gmail.com","Split up builders for unbounded ranges\n\nInstead of having:\n - chpl_build_bounded_range\n - chpl_build_unbounded_range\n\nwe now have:\n - chpl_build_bounded_range\n - chpl_build_partially_bounded_range\n - chpl_build_unbounded_range\n\nIt seemed worthwhile to split the builders up further to be able to identify\npartially bounded vs completely unbounded ranges. It doesn't feel worthwhile to\nsplit up the partially bounded into low and high bounded (though it'd be easy\nto do in the future if we change our minds.)\n\nIf you have a range like \"1..\" it feels more natural to call it a partially\nbounded range instead of an unbounded range. I suppose it could be called a\npartially unbounded range, but that feels strange. Unbounded implies \"..\" to\nme, so it makes sense to split out the builders at the very least to avoid any\nconfusion.","Elliot Ronaghan",true],["2da8385d278d2d8ca3bc430b48426e2a2403fde7","a0eed57aaedf007a763cbac2dd65f90f9fe7ec18@gmail.com","Merge pull request #1003 from ronawho/change_build_range_signature\n\nChange name of _build_range to be more explicit\r\n\r\n[ok'd and suggested by @bradcray]\r\n\r\nSplit _build_range into:\r\n - chpl_build_bounded_range\r\n - chpl_build_partially_bounded_range\r\n - chpl_build_unbounded_range\r\n\r\nThis was motivated by the upcoming anonymous range construction elimination\r\nwork. I need a way to determine if a range is fully bounded immediately after\r\nparse time. The checks that I was doing were restrictive and ugly so this\r\nallows me to simply check for the appropriate builder based on name.\r\n\r\nAdded the chpl_ prefix to the builders since we're trying to move away from a\r\nsingle underscore to indicate a Chapel-reserved word.\r\n\r\nAlso updates error messages for malformed param for loops to indicate that\r\nparam for loops only work on bounded ranges.","Elliot Ronaghan",true]],"size":6,"ref":"refs/heads/master","head":"2da8385d278d2d8ca3bc430b48426e2a2403fde7"}