GitHub PullRequestReviewCommentEvent at 2014-12-15 20:27:39
Repository: rdflib
Actor: iherman
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/RDFLib/rdflib/pulls/comments/21853914","id":21853914,"diff_hunk":"@@ -205,11 +194,11 @@ def _get_input(self, name) :\n \t\t\t\tself.base   = url_request.location\n \t\t\t\treturn url_request.data\n \t\t\telse :\n-\t\t\t\tself.base = 'file://'+name","path":"rdflib/plugins/parsers/pyMicrodata/__init__.py","position":133,"original_position":133,"commit_id":"2b361808e42e31a6430d15ab5d10bb82d385f0c0","original_commit_id":"2b361808e42e31a6430d15ab5d10bb82d385f0c0","user":{"login":"iherman","id":520723,"avatar_url":"https://avatars.githubusercontent.com/u/520723?v=3","gravatar_id":"","url":"https://api.github.com/users/iherman","html_url":"https://github.com/iherman","followers_url":"https://api.github.com/users/iherman/followers","following_url":"https://api.github.com/users/iherman/following{/other_user}","gists_url":"https://api.github.com/users/iherman/gists{/gist_id}","starred_url":"https://api.github.com/users/iherman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iherman/subscriptions","organizations_url":"https://api.github.com/users/iherman/orgs","repos_url":"https://api.github.com/users/iherman/repos","events_url":"https://api.github.com/users/iherman/events{/privacy}","received_events_url":"https://api.github.com/users/iherman/received_events","type":"User","site_admin":false},"body":"Jörg,\r\n\r\nI have looked, only from my iPad, at these references, and the only place I saw a reference (and to file://, though I am not yet sure what it means) is only one of the three issues. The problem is that I cannot test any fedora or, for that matter, python3 version on my mac...\r\n\r\nAnyway, I will see tomorrow what I can do.\r\n\r\nIvan\r\n\r\n---\r\nIvan Herman\r\nTel:+31 641044153\r\nhttp://www.ivan-herman.net\r\n\r\n(Written on mobile, sorry for brevity and misspellings...)\r\n\r\n\r\n\r\n> On 15 Dec 2014, at 19:58, Jörn Hees <notifications@github.com> wrote:\r\n> \r\n> In rdflib/plugins/parsers/pyMicrodata/__init__.py:\r\n> \r\n> > @@ -205,11 +194,11 @@ def _get_input(self, name) :\r\n> >  \t\t\t\tself.base   = url_request.location\r\n> >  \t\t\t\treturn url_request.data\r\n> >  \t\t\telse :\r\n> > -\t\t\t\tself.base = 'file://'+name\r\n> @iherman oh and this would re-open #406 aka fix for #403\r\n> \r\n> —\r\n> Reply to this email directly or view it on GitHub.\r\n> ","created_at":"2014-12-15T20:27:39Z","updated_at":"2014-12-15T20:27:39Z","html_url":"https://github.com/RDFLib/rdflib/pull/443#discussion_r21853914","pull_request_url":"https://api.github.com/repos/RDFLib/rdflib/pulls/443","_links":{"self":{"href":"https://api.github.com/repos/RDFLib/rdflib/pulls/comments/21853914"},"html":{"href":"https://github.com/RDFLib/rdflib/pull/443#discussion_r21853914"},"pull_request":{"href":"https://api.github.com/repos/RDFLib/rdflib/pulls/443"}}},"pull_request":{"url":"https://api.github.com/repos/RDFLib/rdflib/pulls/443","id":26089373,"html_url":"https://github.com/RDFLib/rdflib/pull/443","diff_url":"https://github.com/RDFLib/rdflib/pull/443.diff","patch_url":"https://github.com/RDFLib/rdflib/pull/443.patch","issue_url":"https://api.github.com/repos/RDFLib/rdflib/issues/443","number":443,"state":"open","locked":false,"title":"Microdata parser: updated the parser to the latest version of the microdata->rdf note (published in December 2014)","user":{"login":"joernhees","id":464192,"avatar_url":"https://avatars.githubusercontent.com/u/464192?v=3","gravatar_id":"","url":"https://api.github.com/users/joernhees","html_url":"https://github.com/joernhees","followers_url":"https://api.github.com/users/joernhees/followers","following_url":"https://api.github.com/users/joernhees/following{/other_user}","gists_url":"https://api.github.com/users/joernhees/gists{/gist_id}","starred_url":"https://api.github.com/users/joernhees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joernhees/subscriptions","organizations_url":"https://api.github.com/users/joernhees/orgs","repos_url":"https://api.github.com/users/joernhees/repos","events_url":"https://api.github.com/users/joernhees/events{/privacy}","received_events_url":"https://api.github.com/users/joernhees/received_events","type":"User","site_admin":false},"body":"re-based microdata-to-rdf-second-edition from six_2to3 branch as described here: https://github.com/RDFLib/rdflib/commit/b082c4851840f4c2c83910f84331fb07fca16f4c#commitcomment-8975378\r\n\r\npull request to run the tests...","created_at":"2014-12-15T18:15:18Z","updated_at":"2014-12-15T20:27:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"70dc163096f9edbed68d3f13c34a768022dd2c07","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/RDFLib/rdflib/pulls/443/commits","review_comments_url":"https://api.github.com/repos/RDFLib/rdflib/pulls/443/comments","review_comment_url":"https://api.github.com/repos/RDFLib/rdflib/pulls/comments/{number}","comments_url":"https://api.github.com/repos/RDFLib/rdflib/issues/443/comments","statuses_url":"https://api.github.com/repos/RDFLib/rdflib/statuses/2b361808e42e31a6430d15ab5d10bb82d385f0c0","head":{"label":"RDFLib:microdata-to-rdf-second-edition","ref":"microdata-to-rdf-second-edition","sha":"2b361808e42e31a6430d15ab5d10bb82d385f0c0","user":{"login":"RDFLib","id":1401847,"avatar_url":"https://avatars.githubusercontent.com/u/1401847?v=3","gravatar_id":"","url":"https://api.github.com/users/RDFLib","html_url":"https://github.com/RDFLib","followers_url":"https://api.github.com/users/RDFLib/followers","following_url":"https://api.github.com/users/RDFLib/following{/other_user}","gists_url":"https://api.github.com/users/RDFLib/gists{/gist_id}","starred_url":"https://api.github.com/users/RDFLib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RDFLib/subscriptions","organizations_url":"https://api.github.com/users/RDFLib/orgs","repos_url":"https://api.github.com/users/RDFLib/repos","events_url":"https://api.github.com/users/RDFLib/events{/privacy}","received_events_url":"https://api.github.com/users/RDFLib/received_events","type":"Organization","site_admin":false},"repo":{"id":3342046,"name":"rdflib","full_name":"RDFLib/rdflib","owner":{"login":"RDFLib","id":1401847,"avatar_url":"https://avatars.githubusercontent.com/u/1401847?v=3","gravatar_id":"","url":"https://api.github.com/users/RDFLib","html_url":"https://github.com/RDFLib","followers_url":"https://api.github.com/users/RDFLib/followers","following_url":"https://api.github.com/users/RDFLib/following{/other_user}","gists_url":"https://api.github.com/users/RDFLib/gists{/gist_id}","starred_url":"https://api.github.com/users/RDFLib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RDFLib/subscriptions","organizations_url":"https://api.github.com/users/RDFLib/orgs","repos_url":"https://api.github.com/users/RDFLib/repos","events_url":"https://api.github.com/users/RDFLib/events{/privacy}","received_events_url":"https://api.github.com/users/RDFLib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RDFLib/rdflib","description":"RDFLib is a Python library for working with RDF, a simple yet powerful language for representing information.","fork":false,"url":"https://api.github.com/repos/RDFLib/rdflib","forks_url":"https://api.github.com/repos/RDFLib/rdflib/forks","keys_url":"https://api.github.com/repos/RDFLib/rdflib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RDFLib/rdflib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RDFLib/rdflib/teams","hooks_url":"https://api.github.com/repos/RDFLib/rdflib/hooks","issue_events_url":"https://api.github.com/repos/RDFLib/rdflib/issues/events{/number}","events_url":"https://api.github.com/repos/RDFLib/rdflib/events","assignees_url":"https://api.github.com/repos/RDFLib/rdflib/assignees{/user}","branches_url":"https://api.github.com/repos/RDFLib/rdflib/branches{/branch}","tags_url":"https://api.github.com/repos/RDFLib/rdflib/tags","blobs_url":"https://api.github.com/repos/RDFLib/rdflib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RDFLib/rdflib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RDFLib/rdflib/git/refs{/sha}","trees_url":"https://api.github.com/repos/RDFLib/rdflib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RDFLib/rdflib/statuses/{sha}","languages_url":"https://api.github.com/repos/RDFLib/rdflib/languages","stargazers_url":"https://api.github.com/repos/RDFLib/rdflib/stargazers","contributors_url":"https://api.github.com/repos/RDFLib/rdflib/contributors","subscribers_url":"https://api.github.com/repos/RDFLib/rdflib/subscribers","subscription_url":"https://api.github.com/repos/RDFLib/rdflib/subscription","commits_url":"https://api.github.com/repos/RDFLib/rdflib/commits{/sha}","git_commits_url":"https://api.github.com/repos/RDFLib/rdflib/git/commits{/sha}","comments_url":"https://api.github.com/repos/RDFLib/rdflib/comments{/number}","issue_comment_url":"https://api.github.com/repos/RDFLib/rdflib/issues/comments/{number}","contents_url":"https://api.github.com/repos/RDFLib/rdflib/contents/{+path}","compare_url":"https://api.github.com/repos/RDFLib/rdflib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RDFLib/rdflib/merges","archive_url":"https://api.github.com/repos/RDFLib/rdflib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RDFLib/rdflib/downloads","issues_url":"https://api.github.com/repos/RDFLib/rdflib/issues{/number}","pulls_url":"https://api.github.com/repos/RDFLib/rdflib/pulls{/number}","milestones_url":"https://api.github.com/repos/RDFLib/rdflib/milestones{/number}","notifications_url":"https://api.github.com/repos/RDFLib/rdflib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RDFLib/rdflib/labels{/name}","releases_url":"https://api.github.com/repos/RDFLib/rdflib/releases{/id}","created_at":"2012-02-03T05:49:13Z","updated_at":"2014-12-12T16:31:54Z","pushed_at":"2014-12-15T18:59:14Z","git_url":"git://github.com/RDFLib/rdflib.git","ssh_url":"git@github.com:RDFLib/rdflib.git","clone_url":"https://github.com/RDFLib/rdflib.git","svn_url":"https://github.com/RDFLib/rdflib","homepage":"https://rdflib.readthedocs.org/","size":17965,"stargazers_count":299,"watchers_count":299,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":98,"mirror_url":null,"open_issues_count":64,"forks":98,"open_issues":64,"watchers":299,"default_branch":"master"}},"base":{"label":"RDFLib:master","ref":"master","sha":"175c0285eea4ae6a29b05ff717f1199a03058ae3","user":{"login":"RDFLib","id":1401847,"avatar_url":"https://avatars.githubusercontent.com/u/1401847?v=3","gravatar_id":"","url":"https://api.github.com/users/RDFLib","html_url":"https://github.com/RDFLib","followers_url":"https://api.github.com/users/RDFLib/followers","following_url":"https://api.github.com/users/RDFLib/following{/other_user}","gists_url":"https://api.github.com/users/RDFLib/gists{/gist_id}","starred_url":"https://api.github.com/users/RDFLib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RDFLib/subscriptions","organizations_url":"https://api.github.com/users/RDFLib/orgs","repos_url":"https://api.github.com/users/RDFLib/repos","events_url":"https://api.github.com/users/RDFLib/events{/privacy}","received_events_url":"https://api.github.com/users/RDFLib/received_events","type":"Organization","site_admin":false},"repo":{"id":3342046,"name":"rdflib","full_name":"RDFLib/rdflib","owner":{"login":"RDFLib","id":1401847,"avatar_url":"https://avatars.githubusercontent.com/u/1401847?v=3","gravatar_id":"","url":"https://api.github.com/users/RDFLib","html_url":"https://github.com/RDFLib","followers_url":"https://api.github.com/users/RDFLib/followers","following_url":"https://api.github.com/users/RDFLib/following{/other_user}","gists_url":"https://api.github.com/users/RDFLib/gists{/gist_id}","starred_url":"https://api.github.com/users/RDFLib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RDFLib/subscriptions","organizations_url":"https://api.github.com/users/RDFLib/orgs","repos_url":"https://api.github.com/users/RDFLib/repos","events_url":"https://api.github.com/users/RDFLib/events{/privacy}","received_events_url":"https://api.github.com/users/RDFLib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RDFLib/rdflib","description":"RDFLib is a Python library for working with RDF, a simple yet powerful language for representing information.","fork":false,"url":"https://api.github.com/repos/RDFLib/rdflib","forks_url":"https://api.github.com/repos/RDFLib/rdflib/forks","keys_url":"https://api.github.com/repos/RDFLib/rdflib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RDFLib/rdflib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RDFLib/rdflib/teams","hooks_url":"https://api.github.com/repos/RDFLib/rdflib/hooks","issue_events_url":"https://api.github.com/repos/RDFLib/rdflib/issues/events{/number}","events_url":"https://api.github.com/repos/RDFLib/rdflib/events","assignees_url":"https://api.github.com/repos/RDFLib/rdflib/assignees{/user}","branches_url":"https://api.github.com/repos/RDFLib/rdflib/branches{/branch}","tags_url":"https://api.github.com/repos/RDFLib/rdflib/tags","blobs_url":"https://api.github.com/repos/RDFLib/rdflib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RDFLib/rdflib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RDFLib/rdflib/git/refs{/sha}","trees_url":"https://api.github.com/repos/RDFLib/rdflib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RDFLib/rdflib/statuses/{sha}","languages_url":"https://api.github.com/repos/RDFLib/rdflib/languages","stargazers_url":"https://api.github.com/repos/RDFLib/rdflib/stargazers","contributors_url":"https://api.github.com/repos/RDFLib/rdflib/contributors","subscribers_url":"https://api.github.com/repos/RDFLib/rdflib/subscribers","subscription_url":"https://api.github.com/repos/RDFLib/rdflib/subscription","commits_url":"https://api.github.com/repos/RDFLib/rdflib/commits{/sha}","git_commits_url":"https://api.github.com/repos/RDFLib/rdflib/git/commits{/sha}","comments_url":"https://api.github.com/repos/RDFLib/rdflib/comments{/number}","issue_comment_url":"https://api.github.com/repos/RDFLib/rdflib/issues/comments/{number}","contents_url":"https://api.github.com/repos/RDFLib/rdflib/contents/{+path}","compare_url":"https://api.github.com/repos/RDFLib/rdflib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RDFLib/rdflib/merges","archive_url":"https://api.github.com/repos/RDFLib/rdflib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RDFLib/rdflib/downloads","issues_url":"https://api.github.com/repos/RDFLib/rdflib/issues{/number}","pulls_url":"https://api.github.com/repos/RDFLib/rdflib/pulls{/number}","milestones_url":"https://api.github.com/repos/RDFLib/rdflib/milestones{/number}","notifications_url":"https://api.github.com/repos/RDFLib/rdflib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RDFLib/rdflib/labels{/name}","releases_url":"https://api.github.com/repos/RDFLib/rdflib/releases{/id}","created_at":"2012-02-03T05:49:13Z","updated_at":"2014-12-12T16:31:54Z","pushed_at":"2014-12-15T18:59:14Z","git_url":"git://github.com/RDFLib/rdflib.git","ssh_url":"git@github.com:RDFLib/rdflib.git","clone_url":"https://github.com/RDFLib/rdflib.git","svn_url":"https://github.com/RDFLib/rdflib","homepage":"https://rdflib.readthedocs.org/","size":17965,"stargazers_count":299,"watchers_count":299,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":98,"mirror_url":null,"open_issues_count":64,"forks":98,"open_issues":64,"watchers":299,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RDFLib/rdflib/pulls/443"},"html":{"href":"https://github.com/RDFLib/rdflib/pull/443"},"issue":{"href":"https://api.github.com/repos/RDFLib/rdflib/issues/443"},"comments":{"href":"https://api.github.com/repos/RDFLib/rdflib/issues/443/comments"},"review_comments":{"href":"https://api.github.com/repos/RDFLib/rdflib/pulls/443/comments"},"review_comment":{"href":"https://api.github.com/repos/RDFLib/rdflib/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/RDFLib/rdflib/pulls/443/commits"},"statuses":{"href":"https://api.github.com/repos/RDFLib/rdflib/statuses/2b361808e42e31a6430d15ab5d10bb82d385f0c0"}}}}