GitHub PullRequestReviewCommentEvent at 2014-12-04 19:35:37
Repository: underscore
Actor: jridgewell
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/jashkenas/underscore/pulls/comments/21329747","id":21329747,"diff_hunk":"@@ -122,9 +122,6 @@\n     ok(_.reduce(null, _.noop, 138) === 138, 'handles a null (with initial value) properly');\n     equal(_.reduce([], _.noop, undefined), undefined, 'undefined can be passed as a special case');\n     equal(_.reduce([_], _.noop), _, 'collection of length one with no initial value returns the first item');\n-\n-    throws(function() { _.reduce([], _.noop); }, TypeError, 'throws an error for empty arrays with no initial value');","path":"test/collections.js","position":5,"original_position":5,"commit_id":"f1428a9c768ed7c87611458e506376ef90f7e918","original_commit_id":"94b296110ff197609f963a0956ffe89d4ba41442","user":{"login":"jridgewell","id":112982,"avatar_url":"https://avatars.githubusercontent.com/u/112982?v=3","gravatar_id":"","url":"https://api.github.com/users/jridgewell","html_url":"https://github.com/jridgewell","followers_url":"https://api.github.com/users/jridgewell/followers","following_url":"https://api.github.com/users/jridgewell/following{/other_user}","gists_url":"https://api.github.com/users/jridgewell/gists{/gist_id}","starred_url":"https://api.github.com/users/jridgewell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jridgewell/subscriptions","organizations_url":"https://api.github.com/users/jridgewell/orgs","repos_url":"https://api.github.com/users/jridgewell/repos","events_url":"https://api.github.com/users/jridgewell/events{/privacy}","received_events_url":"https://api.github.com/users/jridgewell/received_events","type":"User","site_admin":false},"body":"Yup, updated.","created_at":"2014-12-04T19:35:37Z","updated_at":"2014-12-04T19:35:37Z","html_url":"https://github.com/jashkenas/underscore/pull/1961#discussion_r21329747","pull_request_url":"https://api.github.com/repos/jashkenas/underscore/pulls/1961","_links":{"self":{"href":"https://api.github.com/repos/jashkenas/underscore/pulls/comments/21329747"},"html":{"href":"https://github.com/jashkenas/underscore/pull/1961#discussion_r21329747"},"pull_request":{"href":"https://api.github.com/repos/jashkenas/underscore/pulls/1961"}}},"pull_request":{"url":"https://api.github.com/repos/jashkenas/underscore/pulls/1961","id":25521108,"html_url":"https://github.com/jashkenas/underscore/pull/1961","diff_url":"https://github.com/jashkenas/underscore/pull/1961.diff","patch_url":"https://github.com/jashkenas/underscore/pull/1961.patch","issue_url":"https://api.github.com/repos/jashkenas/underscore/issues/1961","number":1961,"state":"open","locked":false,"title":"Remove `reduce` error throwing","user":{"login":"jridgewell","id":112982,"avatar_url":"https://avatars.githubusercontent.com/u/112982?v=3","gravatar_id":"","url":"https://api.github.com/users/jridgewell","html_url":"https://github.com/jridgewell","followers_url":"https://api.github.com/users/jridgewell/followers","following_url":"https://api.github.com/users/jridgewell/following{/other_user}","gists_url":"https://api.github.com/users/jridgewell/gists{/gist_id}","starred_url":"https://api.github.com/users/jridgewell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jridgewell/subscriptions","organizations_url":"https://api.github.com/users/jridgewell/orgs","repos_url":"https://api.github.com/users/jridgewell/repos","events_url":"https://api.github.com/users/jridgewell/events{/privacy}","received_events_url":"https://api.github.com/users/jridgewell/received_events","type":"User","site_admin":false},"body":"Closes #1858.","created_at":"2014-12-04T19:23:57Z","updated_at":"2014-12-04T19:35:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b17ebbb95f15644aea5aa6da22e7853fb25d7e43","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jashkenas/underscore/pulls/1961/commits","review_comments_url":"https://api.github.com/repos/jashkenas/underscore/pulls/1961/comments","review_comment_url":"https://api.github.com/repos/jashkenas/underscore/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jashkenas/underscore/issues/1961/comments","statuses_url":"https://api.github.com/repos/jashkenas/underscore/statuses/f1428a9c768ed7c87611458e506376ef90f7e918","head":{"label":"jridgewell:remove-reduce-errors","ref":"remove-reduce-errors","sha":"f1428a9c768ed7c87611458e506376ef90f7e918","user":{"login":"jridgewell","id":112982,"avatar_url":"https://avatars.githubusercontent.com/u/112982?v=3","gravatar_id":"","url":"https://api.github.com/users/jridgewell","html_url":"https://github.com/jridgewell","followers_url":"https://api.github.com/users/jridgewell/followers","following_url":"https://api.github.com/users/jridgewell/following{/other_user}","gists_url":"https://api.github.com/users/jridgewell/gists{/gist_id}","starred_url":"https://api.github.com/users/jridgewell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jridgewell/subscriptions","organizations_url":"https://api.github.com/users/jridgewell/orgs","repos_url":"https://api.github.com/users/jridgewell/repos","events_url":"https://api.github.com/users/jridgewell/events{/privacy}","received_events_url":"https://api.github.com/users/jridgewell/received_events","type":"User","site_admin":false},"repo":{"id":25932916,"name":"underscore","full_name":"jridgewell/underscore","owner":{"login":"jridgewell","id":112982,"avatar_url":"https://avatars.githubusercontent.com/u/112982?v=3","gravatar_id":"","url":"https://api.github.com/users/jridgewell","html_url":"https://github.com/jridgewell","followers_url":"https://api.github.com/users/jridgewell/followers","following_url":"https://api.github.com/users/jridgewell/following{/other_user}","gists_url":"https://api.github.com/users/jridgewell/gists{/gist_id}","starred_url":"https://api.github.com/users/jridgewell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jridgewell/subscriptions","organizations_url":"https://api.github.com/users/jridgewell/orgs","repos_url":"https://api.github.com/users/jridgewell/repos","events_url":"https://api.github.com/users/jridgewell/events{/privacy}","received_events_url":"https://api.github.com/users/jridgewell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jridgewell/underscore","description":"JavaScript's utility _ belt","fork":true,"url":"https://api.github.com/repos/jridgewell/underscore","forks_url":"https://api.github.com/repos/jridgewell/underscore/forks","keys_url":"https://api.github.com/repos/jridgewell/underscore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jridgewell/underscore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jridgewell/underscore/teams","hooks_url":"https://api.github.com/repos/jridgewell/underscore/hooks","issue_events_url":"https://api.github.com/repos/jridgewell/underscore/issues/events{/number}","events_url":"https://api.github.com/repos/jridgewell/underscore/events","assignees_url":"https://api.github.com/repos/jridgewell/underscore/assignees{/user}","branches_url":"https://api.github.com/repos/jridgewell/underscore/branches{/branch}","tags_url":"https://api.github.com/repos/jridgewell/underscore/tags","blobs_url":"https://api.github.com/repos/jridgewell/underscore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jridgewell/underscore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jridgewell/underscore/git/refs{/sha}","trees_url":"https://api.github.com/repos/jridgewell/underscore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jridgewell/underscore/statuses/{sha}","languages_url":"https://api.github.com/repos/jridgewell/underscore/languages","stargazers_url":"https://api.github.com/repos/jridgewell/underscore/stargazers","contributors_url":"https://api.github.com/repos/jridgewell/underscore/contributors","subscribers_url":"https://api.github.com/repos/jridgewell/underscore/subscribers","subscription_url":"https://api.github.com/repos/jridgewell/underscore/subscription","commits_url":"https://api.github.com/repos/jridgewell/underscore/commits{/sha}","git_commits_url":"https://api.github.com/repos/jridgewell/underscore/git/commits{/sha}","comments_url":"https://api.github.com/repos/jridgewell/underscore/comments{/number}","issue_comment_url":"https://api.github.com/repos/jridgewell/underscore/issues/comments/{number}","contents_url":"https://api.github.com/repos/jridgewell/underscore/contents/{+path}","compare_url":"https://api.github.com/repos/jridgewell/underscore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jridgewell/underscore/merges","archive_url":"https://api.github.com/repos/jridgewell/underscore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jridgewell/underscore/downloads","issues_url":"https://api.github.com/repos/jridgewell/underscore/issues{/number}","pulls_url":"https://api.github.com/repos/jridgewell/underscore/pulls{/number}","milestones_url":"https://api.github.com/repos/jridgewell/underscore/milestones{/number}","notifications_url":"https://api.github.com/repos/jridgewell/underscore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jridgewell/underscore/labels{/name}","releases_url":"https://api.github.com/repos/jridgewell/underscore/releases{/id}","created_at":"2014-10-29T17:32:27Z","updated_at":"2014-10-29T16:16:05Z","pushed_at":"2014-12-04T19:35:08Z","git_url":"git://github.com/jridgewell/underscore.git","ssh_url":"git@github.com:jridgewell/underscore.git","clone_url":"https://github.com/jridgewell/underscore.git","svn_url":"https://github.com/jridgewell/underscore","homepage":"http://underscorejs.org","size":3963,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jashkenas:master","ref":"master","sha":"93cd25b84abe0f48194ab4e4557161c875f6aa70","user":{"login":"jashkenas","id":4732,"avatar_url":"https://avatars.githubusercontent.com/u/4732?v=3","gravatar_id":"","url":"https://api.github.com/users/jashkenas","html_url":"https://github.com/jashkenas","followers_url":"https://api.github.com/users/jashkenas/followers","following_url":"https://api.github.com/users/jashkenas/following{/other_user}","gists_url":"https://api.github.com/users/jashkenas/gists{/gist_id}","starred_url":"https://api.github.com/users/jashkenas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jashkenas/subscriptions","organizations_url":"https://api.github.com/users/jashkenas/orgs","repos_url":"https://api.github.com/users/jashkenas/repos","events_url":"https://api.github.com/users/jashkenas/events{/privacy}","received_events_url":"https://api.github.com/users/jashkenas/received_events","type":"User","site_admin":false},"repo":{"id":349241,"name":"underscore","full_name":"jashkenas/underscore","owner":{"login":"jashkenas","id":4732,"avatar_url":"https://avatars.githubusercontent.com/u/4732?v=3","gravatar_id":"","url":"https://api.github.com/users/jashkenas","html_url":"https://github.com/jashkenas","followers_url":"https://api.github.com/users/jashkenas/followers","following_url":"https://api.github.com/users/jashkenas/following{/other_user}","gists_url":"https://api.github.com/users/jashkenas/gists{/gist_id}","starred_url":"https://api.github.com/users/jashkenas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jashkenas/subscriptions","organizations_url":"https://api.github.com/users/jashkenas/orgs","repos_url":"https://api.github.com/users/jashkenas/repos","events_url":"https://api.github.com/users/jashkenas/events{/privacy}","received_events_url":"https://api.github.com/users/jashkenas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jashkenas/underscore","description":"JavaScript's utility _ belt","fork":false,"url":"https://api.github.com/repos/jashkenas/underscore","forks_url":"https://api.github.com/repos/jashkenas/underscore/forks","keys_url":"https://api.github.com/repos/jashkenas/underscore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jashkenas/underscore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jashkenas/underscore/teams","hooks_url":"https://api.github.com/repos/jashkenas/underscore/hooks","issue_events_url":"https://api.github.com/repos/jashkenas/underscore/issues/events{/number}","events_url":"https://api.github.com/repos/jashkenas/underscore/events","assignees_url":"https://api.github.com/repos/jashkenas/underscore/assignees{/user}","branches_url":"https://api.github.com/repos/jashkenas/underscore/branches{/branch}","tags_url":"https://api.github.com/repos/jashkenas/underscore/tags","blobs_url":"https://api.github.com/repos/jashkenas/underscore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jashkenas/underscore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jashkenas/underscore/git/refs{/sha}","trees_url":"https://api.github.com/repos/jashkenas/underscore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jashkenas/underscore/statuses/{sha}","languages_url":"https://api.github.com/repos/jashkenas/underscore/languages","stargazers_url":"https://api.github.com/repos/jashkenas/underscore/stargazers","contributors_url":"https://api.github.com/repos/jashkenas/underscore/contributors","subscribers_url":"https://api.github.com/repos/jashkenas/underscore/subscribers","subscription_url":"https://api.github.com/repos/jashkenas/underscore/subscription","commits_url":"https://api.github.com/repos/jashkenas/underscore/commits{/sha}","git_commits_url":"https://api.github.com/repos/jashkenas/underscore/git/commits{/sha}","comments_url":"https://api.github.com/repos/jashkenas/underscore/comments{/number}","issue_comment_url":"https://api.github.com/repos/jashkenas/underscore/issues/comments/{number}","contents_url":"https://api.github.com/repos/jashkenas/underscore/contents/{+path}","compare_url":"https://api.github.com/repos/jashkenas/underscore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jashkenas/underscore/merges","archive_url":"https://api.github.com/repos/jashkenas/underscore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jashkenas/underscore/downloads","issues_url":"https://api.github.com/repos/jashkenas/underscore/issues{/number}","pulls_url":"https://api.github.com/repos/jashkenas/underscore/pulls{/number}","milestones_url":"https://api.github.com/repos/jashkenas/underscore/milestones{/number}","notifications_url":"https://api.github.com/repos/jashkenas/underscore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jashkenas/underscore/labels{/name}","releases_url":"https://api.github.com/repos/jashkenas/underscore/releases{/id}","created_at":"2009-10-25T18:31:06Z","updated_at":"2014-12-04T19:22:58Z","pushed_at":"2014-12-02T16:41:32Z","git_url":"git://github.com/jashkenas/underscore.git","ssh_url":"git@github.com:jashkenas/underscore.git","clone_url":"https://github.com/jashkenas/underscore.git","svn_url":"https://github.com/jashkenas/underscore","homepage":"http://underscorejs.org","size":18526,"stargazers_count":12985,"watchers_count":12985,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2883,"mirror_url":null,"open_issues_count":54,"forks":2883,"open_issues":54,"watchers":12985,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jashkenas/underscore/pulls/1961"},"html":{"href":"https://github.com/jashkenas/underscore/pull/1961"},"issue":{"href":"https://api.github.com/repos/jashkenas/underscore/issues/1961"},"comments":{"href":"https://api.github.com/repos/jashkenas/underscore/issues/1961/comments"},"review_comments":{"href":"https://api.github.com/repos/jashkenas/underscore/pulls/1961/comments"},"review_comment":{"href":"https://api.github.com/repos/jashkenas/underscore/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jashkenas/underscore/pulls/1961/commits"},"statuses":{"href":"https://api.github.com/repos/jashkenas/underscore/statuses/f1428a9c768ed7c87611458e506376ef90f7e918"}}}}