GitHub PullRequestReviewCommentEvent at 2014-09-07 00:03:56
Repository: minetest
Actor: davexunit
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/minetest/minetest/pulls/comments/17212073","id":17212073,"diff_hunk":"@@ -66,6 +66,19 @@ SubgameSpec findSubgame(const std::string &id)\n \tstd::string share = porting::path_share;\n \tstd::string user = porting::path_user;\n \tstd::vector<GameFindPath> find_paths;\n+\n+        char *search_paths = getenv(\"MINETEST_SUBGAME_PATH\");\n+        char *search_path = strtok(search_paths, \":\");","path":"src/subgame.cpp","position":6,"original_position":6,"commit_id":"80a1054060006e9e6c3f87d8c0826b1f620789f1","original_commit_id":"80a1054060006e9e6c3f87d8c0826b1f620789f1","user":{"login":"davexunit","id":566416,"avatar_url":"https://avatars.githubusercontent.com/u/566416?v=2","gravatar_id":"6689bc439a40b54c70639f987857d353","url":"https://api.github.com/users/davexunit","html_url":"https://github.com/davexunit","followers_url":"https://api.github.com/users/davexunit/followers","following_url":"https://api.github.com/users/davexunit/following{/other_user}","gists_url":"https://api.github.com/users/davexunit/gists{/gist_id}","starred_url":"https://api.github.com/users/davexunit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davexunit/subscriptions","organizations_url":"https://api.github.com/users/davexunit/orgs","repos_url":"https://api.github.com/users/davexunit/repos","events_url":"https://api.github.com/users/davexunit/events{/privacy}","received_events_url":"https://api.github.com/users/davexunit/received_events","type":"User","site_admin":false},"body":"Ah, I'll fix that issue.","created_at":"2014-09-07T00:03:56Z","updated_at":"2014-09-07T00:03:56Z","html_url":"https://github.com/minetest/minetest/pull/1609#discussion_r17212073","pull_request_url":"https://api.github.com/repos/minetest/minetest/pulls/1609","_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments/17212073"},"html":{"href":"https://github.com/minetest/minetest/pull/1609#discussion_r17212073"},"pull_request":{"href":"https://api.github.com/repos/minetest/minetest/pulls/1609"}}},"pull_request":{"url":"https://api.github.com/repos/minetest/minetest/pulls/1609","id":20851140,"html_url":"https://github.com/minetest/minetest/pull/1609","diff_url":"https://github.com/minetest/minetest/pull/1609.diff","patch_url":"https://github.com/minetest/minetest/pull/1609.patch","issue_url":"https://api.github.com/repos/minetest/minetest/issues/1609","number":1609,"state":"open","locked":false,"title":"Search for subgames using $MINETEST_SUBGAME_PATH.","user":{"login":"davexunit","id":566416,"avatar_url":"https://avatars.githubusercontent.com/u/566416?v=2","gravatar_id":"6689bc439a40b54c70639f987857d353","url":"https://api.github.com/users/davexunit","html_url":"https://github.com/davexunit","followers_url":"https://api.github.com/users/davexunit/followers","following_url":"https://api.github.com/users/davexunit/following{/other_user}","gists_url":"https://api.github.com/users/davexunit/gists{/gist_id}","starred_url":"https://api.github.com/users/davexunit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davexunit/subscriptions","organizations_url":"https://api.github.com/users/davexunit/orgs","repos_url":"https://api.github.com/users/davexunit/repos","events_url":"https://api.github.com/users/davexunit/events{/privacy}","received_events_url":"https://api.github.com/users/davexunit/received_events","type":"User","site_admin":false},"body":"Using an environment variable allows the subgame search paths to be defined by the user, rather than fixed at compile time.  This patch will search the paths contained within the environment variable `MINETEST_SUBGAME_PATH` for subgames before searching the share and home directories.  When this environment variable is not set, Minetest behaves as it has prior to this patch.\r\n\r\nOne particular use-case for this patch is to allow Minetest to be played on the GNU system running the [GNU Guix](https://gnu.org/s/guix) package manager, where applications are installed on a per-user basis and packaged files are immutable.  In other words, there's no `/usr/share/minetest/games` directory to write to.  The necessary search path is dependent upon which user is running Minetest and where their \"profile\" (installed packages) is located.","created_at":"2014-09-06T17:34:44Z","updated_at":"2014-09-07T00:03:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9e2c80127fdce187588775fa0b7d05b12821b2a9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/minetest/minetest/pulls/1609/commits","review_comments_url":"https://api.github.com/repos/minetest/minetest/pulls/1609/comments","review_comment_url":"https://api.github.com/repos/minetest/minetest/pulls/comments/{number}","comments_url":"https://api.github.com/repos/minetest/minetest/issues/1609/comments","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/80a1054060006e9e6c3f87d8c0826b1f620789f1","head":{"label":"davexunit:subgame-env-var","ref":"subgame-env-var","sha":"80a1054060006e9e6c3f87d8c0826b1f620789f1","user":{"login":"davexunit","id":566416,"avatar_url":"https://avatars.githubusercontent.com/u/566416?v=2","gravatar_id":"6689bc439a40b54c70639f987857d353","url":"https://api.github.com/users/davexunit","html_url":"https://github.com/davexunit","followers_url":"https://api.github.com/users/davexunit/followers","following_url":"https://api.github.com/users/davexunit/following{/other_user}","gists_url":"https://api.github.com/users/davexunit/gists{/gist_id}","starred_url":"https://api.github.com/users/davexunit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davexunit/subscriptions","organizations_url":"https://api.github.com/users/davexunit/orgs","repos_url":"https://api.github.com/users/davexunit/repos","events_url":"https://api.github.com/users/davexunit/events{/privacy}","received_events_url":"https://api.github.com/users/davexunit/received_events","type":"User","site_admin":false},"repo":{"id":23738114,"name":"minetest","full_name":"davexunit/minetest","owner":{"login":"davexunit","id":566416,"avatar_url":"https://avatars.githubusercontent.com/u/566416?v=2","gravatar_id":"6689bc439a40b54c70639f987857d353","url":"https://api.github.com/users/davexunit","html_url":"https://github.com/davexunit","followers_url":"https://api.github.com/users/davexunit/followers","following_url":"https://api.github.com/users/davexunit/following{/other_user}","gists_url":"https://api.github.com/users/davexunit/gists{/gist_id}","starred_url":"https://api.github.com/users/davexunit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davexunit/subscriptions","organizations_url":"https://api.github.com/users/davexunit/orgs","repos_url":"https://api.github.com/users/davexunit/repos","events_url":"https://api.github.com/users/davexunit/events{/privacy}","received_events_url":"https://api.github.com/users/davexunit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davexunit/minetest","description":"Minetest, an open source infinite-world block sandbox game with survival and crafting. [also https://github.com/minetest/minetest_game]","fork":true,"url":"https://api.github.com/repos/davexunit/minetest","forks_url":"https://api.github.com/repos/davexunit/minetest/forks","keys_url":"https://api.github.com/repos/davexunit/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davexunit/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davexunit/minetest/teams","hooks_url":"https://api.github.com/repos/davexunit/minetest/hooks","issue_events_url":"https://api.github.com/repos/davexunit/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/davexunit/minetest/events","assignees_url":"https://api.github.com/repos/davexunit/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/davexunit/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/davexunit/minetest/tags","blobs_url":"https://api.github.com/repos/davexunit/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davexunit/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davexunit/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/davexunit/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davexunit/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/davexunit/minetest/languages","stargazers_url":"https://api.github.com/repos/davexunit/minetest/stargazers","contributors_url":"https://api.github.com/repos/davexunit/minetest/contributors","subscribers_url":"https://api.github.com/repos/davexunit/minetest/subscribers","subscription_url":"https://api.github.com/repos/davexunit/minetest/subscription","commits_url":"https://api.github.com/repos/davexunit/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/davexunit/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/davexunit/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/davexunit/minetest/issues/comments/{number}","contents_url":"https://api.github.com/repos/davexunit/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/davexunit/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davexunit/minetest/merges","archive_url":"https://api.github.com/repos/davexunit/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davexunit/minetest/downloads","issues_url":"https://api.github.com/repos/davexunit/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/davexunit/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/davexunit/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/davexunit/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davexunit/minetest/labels{/name}","releases_url":"https://api.github.com/repos/davexunit/minetest/releases{/id}","created_at":"2014-09-06T15:44:14Z","updated_at":"2014-09-03T22:49:01Z","pushed_at":"2014-09-06T17:24:02Z","git_url":"git://github.com/davexunit/minetest.git","ssh_url":"git@github.com:davexunit/minetest.git","clone_url":"https://github.com/davexunit/minetest.git","svn_url":"https://github.com/davexunit/minetest","homepage":"http://minetest.net/","size":24896,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minetest:master","ref":"master","sha":"62ea342ad1b725ac44a787c60388cbc8a1c383c5","user":{"login":"minetest","id":2624745,"avatar_url":"https://avatars.githubusercontent.com/u/2624745?v=2","gravatar_id":"19a073a2ee67f8deda9da3460b736edc","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"repo":{"id":2168780,"name":"minetest","full_name":"minetest/minetest","owner":{"login":"minetest","id":2624745,"avatar_url":"https://avatars.githubusercontent.com/u/2624745?v=2","gravatar_id":"19a073a2ee67f8deda9da3460b736edc","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minetest/minetest","description":"Minetest, an open source infinite-world block sandbox game with survival and crafting. [also https://github.com/minetest/minetest_game]","fork":false,"url":"https://api.github.com/repos/minetest/minetest","forks_url":"https://api.github.com/repos/minetest/minetest/forks","keys_url":"https://api.github.com/repos/minetest/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minetest/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minetest/minetest/teams","hooks_url":"https://api.github.com/repos/minetest/minetest/hooks","issue_events_url":"https://api.github.com/repos/minetest/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/minetest/minetest/events","assignees_url":"https://api.github.com/repos/minetest/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/minetest/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/minetest/minetest/tags","blobs_url":"https://api.github.com/repos/minetest/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minetest/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minetest/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/minetest/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/minetest/minetest/languages","stargazers_url":"https://api.github.com/repos/minetest/minetest/stargazers","contributors_url":"https://api.github.com/repos/minetest/minetest/contributors","subscribers_url":"https://api.github.com/repos/minetest/minetest/subscribers","subscription_url":"https://api.github.com/repos/minetest/minetest/subscription","commits_url":"https://api.github.com/repos/minetest/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/minetest/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/minetest/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/minetest/minetest/issues/comments/{number}","contents_url":"https://api.github.com/repos/minetest/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/minetest/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minetest/minetest/merges","archive_url":"https://api.github.com/repos/minetest/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minetest/minetest/downloads","issues_url":"https://api.github.com/repos/minetest/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/minetest/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/minetest/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/minetest/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minetest/minetest/labels{/name}","releases_url":"https://api.github.com/repos/minetest/minetest/releases{/id}","created_at":"2011-08-07T13:48:36Z","updated_at":"2014-09-03T22:49:01Z","pushed_at":"2014-09-06T16:23:15Z","git_url":"git://github.com/minetest/minetest.git","ssh_url":"git@github.com:minetest/minetest.git","clone_url":"https://github.com/minetest/minetest.git","svn_url":"https://github.com/minetest/minetest","homepage":"http://minetest.net/","size":70715,"stargazers_count":926,"watchers_count":926,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":343,"mirror_url":null,"open_issues_count":322,"forks":343,"open_issues":322,"watchers":926,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/1609"},"html":{"href":"https://github.com/minetest/minetest/pull/1609"},"issue":{"href":"https://api.github.com/repos/minetest/minetest/issues/1609"},"comments":{"href":"https://api.github.com/repos/minetest/minetest/issues/1609/comments"},"review_comments":{"href":"https://api.github.com/repos/minetest/minetest/pulls/1609/comments"},"review_comment":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/minetest/minetest/pulls/1609/commits"},"statuses":{"href":"https://api.github.com/repos/minetest/minetest/statuses/80a1054060006e9e6c3f87d8c0826b1f620789f1"}}}}