GitHub PullRequestReviewCommentEvent at 2014-01-26 20:38:38
Repository: scalding
Actor: ianoc
Payload: {"comment":{"url":"https://api.github.com/repos/twitter/scalding/pulls/comments/9177342","id":9177342,"diff_hunk":"@@ -8,24 +8,65 @@ import scala.collection.JavaConverters._\n \n import org.slf4j.{Logger, LoggerFactory}\n \n+import java.util.concurrent.ConcurrentHashMap\n+\n+case class Stat(name: String, group: String = Stats.ScaldingGroup)(@transient implicit val uniqueIdCont: Job#UniqueID) {\n+  @transient private lazy val logger: Logger = LoggerFactory.getLogger(this.getClass)\n+  val uniqueId = uniqueIdCont.get\n+  lazy val flowProcess: FlowProcess[_] = RuntimeStats.getFlowProcessForUniqueId(uniqueId)\n+\n+// Use this if a map or reduce phase takes a while before emitting tuples.\n+  def keepAlive: Unit =","path":"scalding-core/src/main/scala/com/twitter/scalding/Stats.scala","position":12,"original_position":12,"commit_id":"06e2cf042c67a2efcbe237ce06298e2b1a9f69af","original_commit_id":"712384781f97af2d7dd2c41bfb4a6e15063a754f","user":{"login":"ianoc","id":446652,"avatar_url":"https://gravatar.com/avatar/36ce3c50fa3c11de597342acef7d93af?d=https%3A%2F%2Fidenticons.github.com%2F50b82611bc4f275a8bd4a38d2ebaa89a.png&r=x","gravatar_id":"36ce3c50fa3c11de597342acef7d93af","url":"https://api.github.com/users/ianoc","html_url":"https://github.com/ianoc","followers_url":"https://api.github.com/users/ianoc/followers","following_url":"https://api.github.com/users/ianoc/following{/other_user}","gists_url":"https://api.github.com/users/ianoc/gists{/gist_id}","starred_url":"https://api.github.com/users/ianoc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianoc/subscriptions","organizations_url":"https://api.github.com/users/ianoc/orgs","repos_url":"https://api.github.com/users/ianoc/repos","events_url":"https://api.github.com/users/ianoc/events{/privacy}","received_events_url":"https://api.github.com/users/ianoc/received_events","type":"User","site_admin":false},"body":"I was just transferring the logic really. Having it on a global doesn't really work. If it doesn't feel natural here I guess we need to remove the function entirely?","created_at":"2014-01-26T20:38:38Z","updated_at":"2014-01-26T20:38:38Z","html_url":"https://github.com/twitter/scalding/pull/757#discussion_r9177342","pull_request_url":"https://api.github.com/repos/twitter/scalding/pulls/757","_links":{"self":{"href":"https://api.github.com/repos/twitter/scalding/pulls/comments/9177342"},"html":{"href":"https://github.com/twitter/scalding/pull/757#discussion_r9177342"},"pull_request":{"href":"https://api.github.com/repos/twitter/scalding/pulls/757"}}}}