GitHub PullRequestReviewCommentEvent at 2014-10-28 19:15:10
Repository: k
Actor: dwightguth
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/kframework/k/pulls/comments/19496110","id":19496110,"diff_hunk":"@@ -418,20 +418,18 @@ public static String getSortNameFromCons(String str) {\n         return StringUtil.unEscapeSortName(ret);\n     }\n \n-    private static int number = 0;\n-\n     /**\n      * Generate incremental numbers that doesn't contain the number 1\n      *\n      * @return an integer that doesn't contain the number 1\n      */\n-    public static int getUniqueId() {\n+    public static int getUniqueId(int[] number) {","path":"k-core/src/main/java/org/kframework/utils/StringUtil.java","position":12,"original_position":12,"commit_id":"ddadf6ac25efbebf4fd19e338e5d931841d916a7","original_commit_id":"ddadf6ac25efbebf4fd19e338e5d931841d916a7","user":{"login":"dwightguth","id":5104541,"avatar_url":"https://avatars.githubusercontent.com/u/5104541?v=2","gravatar_id":"","url":"https://api.github.com/users/dwightguth","html_url":"https://github.com/dwightguth","followers_url":"https://api.github.com/users/dwightguth/followers","following_url":"https://api.github.com/users/dwightguth/following{/other_user}","gists_url":"https://api.github.com/users/dwightguth/gists{/gist_id}","starred_url":"https://api.github.com/users/dwightguth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwightguth/subscriptions","organizations_url":"https://api.github.com/users/dwightguth/orgs","repos_url":"https://api.github.com/users/dwightguth/repos","events_url":"https://api.github.com/users/dwightguth/events{/privacy}","received_events_url":"https://api.github.com/users/dwightguth/received_events","type":"User","site_admin":false},"body":"no, I can't make it synchronized because it needs to be consistent across calls to kompile. That means in order to be truly thread safe each definition must have its own counter.","created_at":"2014-10-28T19:15:10Z","updated_at":"2014-10-28T19:15:10Z","html_url":"https://github.com/kframework/k/pull/1119#discussion_r19496110","pull_request_url":"https://api.github.com/repos/kframework/k/pulls/1119","_links":{"self":{"href":"https://api.github.com/repos/kframework/k/pulls/comments/19496110"},"html":{"href":"https://github.com/kframework/k/pull/1119#discussion_r19496110"},"pull_request":{"href":"https://api.github.com/repos/kframework/k/pulls/1119"}}},"pull_request":{"url":"https://api.github.com/repos/kframework/k/pulls/1119","id":23482295,"html_url":"https://github.com/kframework/k/pull/1119","diff_url":"https://github.com/kframework/k/pull/1119.diff","patch_url":"https://github.com/kframework/k/pull/1119.patch","issue_url":"https://api.github.com/repos/kframework/k/issues/1119","number":1119,"state":"open","locked":false,"title":"make conses thread safe","user":{"login":"dwightguth","id":5104541,"avatar_url":"https://avatars.githubusercontent.com/u/5104541?v=2","gravatar_id":"","url":"https://api.github.com/users/dwightguth","html_url":"https://github.com/dwightguth","followers_url":"https://api.github.com/users/dwightguth/followers","following_url":"https://api.github.com/users/dwightguth/following{/other_user}","gists_url":"https://api.github.com/users/dwightguth/gists{/gist_id}","starred_url":"https://api.github.com/users/dwightguth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwightguth/subscriptions","organizations_url":"https://api.github.com/users/dwightguth/orgs","repos_url":"https://api.github.com/users/dwightguth/repos","events_url":"https://api.github.com/users/dwightguth/events{/privacy}","received_events_url":"https://api.github.com/users/dwightguth/received_events","type":"User","site_admin":false},"body":"@radumereuta please review","created_at":"2014-10-28T19:10:27Z","updated_at":"2014-10-28T19:15:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6535c2fba1029c724aa7884fee3df7bea11c4110","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kframework/k/pulls/1119/commits","review_comments_url":"https://api.github.com/repos/kframework/k/pulls/1119/comments","review_comment_url":"https://api.github.com/repos/kframework/k/pulls/comments/{number}","comments_url":"https://api.github.com/repos/kframework/k/issues/1119/comments","statuses_url":"https://api.github.com/repos/kframework/k/statuses/ddadf6ac25efbebf4fd19e338e5d931841d916a7","head":{"label":"dwightguth:conses","ref":"conses","sha":"ddadf6ac25efbebf4fd19e338e5d931841d916a7","user":{"login":"dwightguth","id":5104541,"avatar_url":"https://avatars.githubusercontent.com/u/5104541?v=2","gravatar_id":"","url":"https://api.github.com/users/dwightguth","html_url":"https://github.com/dwightguth","followers_url":"https://api.github.com/users/dwightguth/followers","following_url":"https://api.github.com/users/dwightguth/following{/other_user}","gists_url":"https://api.github.com/users/dwightguth/gists{/gist_id}","starred_url":"https://api.github.com/users/dwightguth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwightguth/subscriptions","organizations_url":"https://api.github.com/users/dwightguth/orgs","repos_url":"https://api.github.com/users/dwightguth/repos","events_url":"https://api.github.com/users/dwightguth/events{/privacy}","received_events_url":"https://api.github.com/users/dwightguth/received_events","type":"User","site_admin":false},"repo":{"id":17190491,"name":"k","full_name":"dwightguth/k","owner":{"login":"dwightguth","id":5104541,"avatar_url":"https://avatars.githubusercontent.com/u/5104541?v=2","gravatar_id":"","url":"https://api.github.com/users/dwightguth","html_url":"https://github.com/dwightguth","followers_url":"https://api.github.com/users/dwightguth/followers","following_url":"https://api.github.com/users/dwightguth/following{/other_user}","gists_url":"https://api.github.com/users/dwightguth/gists{/gist_id}","starred_url":"https://api.github.com/users/dwightguth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwightguth/subscriptions","organizations_url":"https://api.github.com/users/dwightguth/orgs","repos_url":"https://api.github.com/users/dwightguth/repos","events_url":"https://api.github.com/users/dwightguth/events{/privacy}","received_events_url":"https://api.github.com/users/dwightguth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dwightguth/k","description":"The K tools","fork":true,"url":"https://api.github.com/repos/dwightguth/k","forks_url":"https://api.github.com/repos/dwightguth/k/forks","keys_url":"https://api.github.com/repos/dwightguth/k/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dwightguth/k/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dwightguth/k/teams","hooks_url":"https://api.github.com/repos/dwightguth/k/hooks","issue_events_url":"https://api.github.com/repos/dwightguth/k/issues/events{/number}","events_url":"https://api.github.com/repos/dwightguth/k/events","assignees_url":"https://api.github.com/repos/dwightguth/k/assignees{/user}","branches_url":"https://api.github.com/repos/dwightguth/k/branches{/branch}","tags_url":"https://api.github.com/repos/dwightguth/k/tags","blobs_url":"https://api.github.com/repos/dwightguth/k/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dwightguth/k/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dwightguth/k/git/refs{/sha}","trees_url":"https://api.github.com/repos/dwightguth/k/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dwightguth/k/statuses/{sha}","languages_url":"https://api.github.com/repos/dwightguth/k/languages","stargazers_url":"https://api.github.com/repos/dwightguth/k/stargazers","contributors_url":"https://api.github.com/repos/dwightguth/k/contributors","subscribers_url":"https://api.github.com/repos/dwightguth/k/subscribers","subscription_url":"https://api.github.com/repos/dwightguth/k/subscription","commits_url":"https://api.github.com/repos/dwightguth/k/commits{/sha}","git_commits_url":"https://api.github.com/repos/dwightguth/k/git/commits{/sha}","comments_url":"https://api.github.com/repos/dwightguth/k/comments{/number}","issue_comment_url":"https://api.github.com/repos/dwightguth/k/issues/comments/{number}","contents_url":"https://api.github.com/repos/dwightguth/k/contents/{+path}","compare_url":"https://api.github.com/repos/dwightguth/k/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dwightguth/k/merges","archive_url":"https://api.github.com/repos/dwightguth/k/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dwightguth/k/downloads","issues_url":"https://api.github.com/repos/dwightguth/k/issues{/number}","pulls_url":"https://api.github.com/repos/dwightguth/k/pulls{/number}","milestones_url":"https://api.github.com/repos/dwightguth/k/milestones{/number}","notifications_url":"https://api.github.com/repos/dwightguth/k/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dwightguth/k/labels{/name}","releases_url":"https://api.github.com/repos/dwightguth/k/releases{/id}","created_at":"2014-02-25T22:29:38Z","updated_at":"2014-07-11T22:02:34Z","pushed_at":"2014-10-28T19:12:35Z","git_url":"git://github.com/dwightguth/k.git","ssh_url":"git@github.com:dwightguth/k.git","clone_url":"https://github.com/dwightguth/k.git","svn_url":"https://github.com/dwightguth/k","homepage":"kframework.org","size":256352,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kframework:master","ref":"master","sha":"1f70cbd5dfce7369fe6732f2620b7413d7efe3a2","user":{"login":"kframework","id":5104335,"avatar_url":"https://avatars.githubusercontent.com/u/5104335?v=2","gravatar_id":"","url":"https://api.github.com/users/kframework","html_url":"https://github.com/kframework","followers_url":"https://api.github.com/users/kframework/followers","following_url":"https://api.github.com/users/kframework/following{/other_user}","gists_url":"https://api.github.com/users/kframework/gists{/gist_id}","starred_url":"https://api.github.com/users/kframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kframework/subscriptions","organizations_url":"https://api.github.com/users/kframework/orgs","repos_url":"https://api.github.com/users/kframework/repos","events_url":"https://api.github.com/users/kframework/events{/privacy}","received_events_url":"https://api.github.com/users/kframework/received_events","type":"Organization","site_admin":false},"repo":{"id":11711223,"name":"k","full_name":"kframework/k","owner":{"login":"kframework","id":5104335,"avatar_url":"https://avatars.githubusercontent.com/u/5104335?v=2","gravatar_id":"","url":"https://api.github.com/users/kframework","html_url":"https://github.com/kframework","followers_url":"https://api.github.com/users/kframework/followers","following_url":"https://api.github.com/users/kframework/following{/other_user}","gists_url":"https://api.github.com/users/kframework/gists{/gist_id}","starred_url":"https://api.github.com/users/kframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kframework/subscriptions","organizations_url":"https://api.github.com/users/kframework/orgs","repos_url":"https://api.github.com/users/kframework/repos","events_url":"https://api.github.com/users/kframework/events{/privacy}","received_events_url":"https://api.github.com/users/kframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kframework/k","description":"The K tools","fork":false,"url":"https://api.github.com/repos/kframework/k","forks_url":"https://api.github.com/repos/kframework/k/forks","keys_url":"https://api.github.com/repos/kframework/k/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kframework/k/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kframework/k/teams","hooks_url":"https://api.github.com/repos/kframework/k/hooks","issue_events_url":"https://api.github.com/repos/kframework/k/issues/events{/number}","events_url":"https://api.github.com/repos/kframework/k/events","assignees_url":"https://api.github.com/repos/kframework/k/assignees{/user}","branches_url":"https://api.github.com/repos/kframework/k/branches{/branch}","tags_url":"https://api.github.com/repos/kframework/k/tags","blobs_url":"https://api.github.com/repos/kframework/k/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kframework/k/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kframework/k/git/refs{/sha}","trees_url":"https://api.github.com/repos/kframework/k/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kframework/k/statuses/{sha}","languages_url":"https://api.github.com/repos/kframework/k/languages","stargazers_url":"https://api.github.com/repos/kframework/k/stargazers","contributors_url":"https://api.github.com/repos/kframework/k/contributors","subscribers_url":"https://api.github.com/repos/kframework/k/subscribers","subscription_url":"https://api.github.com/repos/kframework/k/subscription","commits_url":"https://api.github.com/repos/kframework/k/commits{/sha}","git_commits_url":"https://api.github.com/repos/kframework/k/git/commits{/sha}","comments_url":"https://api.github.com/repos/kframework/k/comments{/number}","issue_comment_url":"https://api.github.com/repos/kframework/k/issues/comments/{number}","contents_url":"https://api.github.com/repos/kframework/k/contents/{+path}","compare_url":"https://api.github.com/repos/kframework/k/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kframework/k/merges","archive_url":"https://api.github.com/repos/kframework/k/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kframework/k/downloads","issues_url":"https://api.github.com/repos/kframework/k/issues{/number}","pulls_url":"https://api.github.com/repos/kframework/k/pulls{/number}","milestones_url":"https://api.github.com/repos/kframework/k/milestones{/number}","notifications_url":"https://api.github.com/repos/kframework/k/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kframework/k/labels{/name}","releases_url":"https://api.github.com/repos/kframework/k/releases{/id}","created_at":"2013-07-27T21:22:53Z","updated_at":"2014-10-17T08:45:25Z","pushed_at":"2014-10-28T19:12:34Z","git_url":"git://github.com/kframework/k.git","ssh_url":"git@github.com:kframework/k.git","clone_url":"https://github.com/kframework/k.git","svn_url":"https://github.com/kframework/k","homepage":"kframework.org","size":352264,"stargazers_count":40,"watchers_count":40,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"open_issues_count":305,"forks":45,"open_issues":305,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kframework/k/pulls/1119"},"html":{"href":"https://github.com/kframework/k/pull/1119"},"issue":{"href":"https://api.github.com/repos/kframework/k/issues/1119"},"comments":{"href":"https://api.github.com/repos/kframework/k/issues/1119/comments"},"review_comments":{"href":"https://api.github.com/repos/kframework/k/pulls/1119/comments"},"review_comment":{"href":"https://api.github.com/repos/kframework/k/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/kframework/k/pulls/1119/commits"},"statuses":{"href":"https://api.github.com/repos/kframework/k/statuses/ddadf6ac25efbebf4fd19e338e5d931841d916a7"}}}}