GitHub PullRequestReviewCommentEvent at 2014-08-26 13:19:09
Repository: SensioDistributionBundle
Actor: fabpot
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/sensiolabs/SensioDistributionBundle/pulls/comments/16712095","id":16712095,"diff_hunk":"@@ -270,14 +270,22 @@ private static function patchAcmeDemoBundleConfiguration($appDir, Filesystem $fs\n         $fs->dumpFile($routingFile, $routingData);\n \n         $securityData = <<<EOF\n+# you can read more about security in the related section of the documentation\n+# http://symfony.com/doc/current/book/security.html\n security:\n+    # setting for encoding the user's password","path":"Composer/ScriptHandler.php","position":7,"original_position":7,"commit_id":"fd708c99ceb5df36795d294429aece2581c3dd33","original_commit_id":"fd708c99ceb5df36795d294429aece2581c3dd33","user":{"login":"fabpot","id":47313,"avatar_url":"https://avatars.githubusercontent.com/u/47313?v=2","gravatar_id":"f1a2c5905e121d09feba5ad73898ffca","url":"https://api.github.com/users/fabpot","html_url":"https://github.com/fabpot","followers_url":"https://api.github.com/users/fabpot/followers","following_url":"https://api.github.com/users/fabpot/following{/other_user}","gists_url":"https://api.github.com/users/fabpot/gists{/gist_id}","starred_url":"https://api.github.com/users/fabpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabpot/subscriptions","organizations_url":"https://api.github.com/users/fabpot/orgs","repos_url":"https://api.github.com/users/fabpot/repos","events_url":"https://api.github.com/users/fabpot/events{/privacy}","received_events_url":"https://api.github.com/users/fabpot/received_events","type":"User","site_admin":false},"body":"Not sure this comment helps here. This configuration can actually configure different encoding strategies depending on the user class. Instead of a small description, what about just keeping the link to the docs?","created_at":"2014-08-26T13:19:09Z","updated_at":"2014-08-26T13:19:09Z","html_url":"https://github.com/sensiolabs/SensioDistributionBundle/pull/161#discussion_r16712095","pull_request_url":"https://api.github.com/repos/sensiolabs/SensioDistributionBundle/pulls/161","_links":{"self":{"href":"https://api.github.com/repos/sensiolabs/SensioDistributionBundle/pulls/comments/16712095"},"html":{"href":"https://github.com/sensiolabs/SensioDistributionBundle/pull/161#discussion_r16712095"},"pull_request":{"href":"https://api.github.com/repos/sensiolabs/SensioDistributionBundle/pulls/161"}}},"pull_request":{"url":"https://api.github.com/repos/sensiolabs/SensioDistributionBundle/pulls/161","id":20232376,"html_url":"https://github.com/sensiolabs/SensioDistributionBundle/pull/161","diff_url":"https://github.com/sensiolabs/SensioDistributionBundle/pull/161.diff","patch_url":"https://github.com/sensiolabs/SensioDistributionBundle/pull/161.patch","issue_url":"https://api.github.com/repos/sensiolabs/SensioDistributionBundle/issues/161","number":161,"state":"open","locked":false,"title":"Describe different parts of the security.yml","user":{"login":"ghostika","id":2512578,"avatar_url":"https://avatars.githubusercontent.com/u/2512578?v=2","gravatar_id":"3fcd89ebc2302b050eb6c7fdbb7b07d2","url":"https://api.github.com/users/ghostika","html_url":"https://github.com/ghostika","followers_url":"https://api.github.com/users/ghostika/followers","following_url":"https://api.github.com/users/ghostika/following{/other_user}","gists_url":"https://api.github.com/users/ghostika/gists{/gist_id}","starred_url":"https://api.github.com/users/ghostika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghostika/subscriptions","organizations_url":"https://api.github.com/users/ghostika/orgs","repos_url":"https://api.github.com/users/ghostika/repos","events_url":"https://api.github.com/users/ghostika/events{/privacy}","received_events_url":"https://api.github.com/users/ghostika/received_events","type":"User","site_admin":false},"body":"Add comments for the sections of security.yml in case of the use of AcmeDemoBundle\r\nOriginal issue: https://github.com/symfony/symfony-standard/issues/676","created_at":"2014-08-25T07:15:31Z","updated_at":"2014-08-26T13:19:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f4787b17c9dd53101c239dc8532044367a07fbb6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sensiolabs/SensioDistributionBundle/pulls/161/commits","review_comments_url":"https://api.github.com/repos/sensiolabs/SensioDistributionBundle/pulls/161/comments","review_comment_url":"https://api.github.com/repos/sensiolabs/SensioDistributionBundle/pulls/comments/{number}","comments_url":"https://api.github.com/repos/sensiolabs/SensioDistributionBundle/issues/161/comments","statuses_url":"https://api.github.com/repos/sensiolabs/SensioDistributionBundle/statuses/fd708c99ceb5df36795d294429aece2581c3dd33","head":{"label":"ghostika:security_comments","ref":"security_comments","sha":"fd708c99ceb5df36795d294429aece2581c3dd33","user":{"login":"ghostika","id":2512578,"avatar_url":"https://avatars.githubusercontent.com/u/2512578?v=2","gravatar_id":"3fcd89ebc2302b050eb6c7fdbb7b07d2","url":"https://api.github.com/users/ghostika","html_url":"https://github.com/ghostika","followers_url":"https://api.github.com/users/ghostika/followers","following_url":"https://api.github.com/users/ghostika/following{/other_user}","gists_url":"https://api.github.com/users/ghostika/gists{/gist_id}","starred_url":"https://api.github.com/users/ghostika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghostika/subscriptions","organizations_url":"https://api.github.com/users/ghostika/orgs","repos_url":"https://api.github.com/users/ghostika/repos","events_url":"https://api.github.com/users/ghostika/events{/privacy}","received_events_url":"https://api.github.com/users/ghostika/received_events","type":"User","site_admin":false},"repo":{"id":23304427,"name":"SensioDistributionBundle","full_name":"ghostika/SensioDistributionBundle","owner":{"login":"ghostika","id":2512578,"avatar_url":"https://avatars.githubusercontent.com/u/2512578?v=2","gravatar_id":"3fcd89ebc2302b050eb6c7fdbb7b07d2","url":"https://api.github.com/users/ghostika","html_url":"https://github.com/ghostika","followers_url":"https://api.github.com/users/ghostika/followers","following_url":"https://api.github.com/users/ghostika/following{/other_user}","gists_url":"https://api.github.com/users/ghostika/gists{/gist_id}","starred_url":"https://api.github.com/users/ghostika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghostika/subscriptions","organizations_url":"https://api.github.com/users/ghostika/orgs","repos_url":"https://api.github.com/users/ghostika/repos","events_url":"https://api.github.com/users/ghostika/events{/privacy}","received_events_url":"https://api.github.com/users/ghostika/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ghostika/SensioDistributionBundle","description":"Base bundle for Symfony Distributions","fork":true,"url":"https://api.github.com/repos/ghostika/SensioDistributionBundle","forks_url":"https://api.github.com/repos/ghostika/SensioDistributionBundle/forks","keys_url":"https://api.github.com/repos/ghostika/SensioDistributionBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ghostika/SensioDistributionBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ghostika/SensioDistributionBundle/teams","hooks_url":"https://api.github.com/repos/ghostika/SensioDistributionBundle/hooks","issue_events_url":"https://api.github.com/repos/ghostika/SensioDistributionBundle/issues/events{/number}","events_url":"https://api.github.com/repos/ghostika/SensioDistributionBundle/events","assignees_url":"https://api.github.com/repos/ghostika/SensioDistributionBundle/assignees{/user}","branches_url":"https://api.github.com/repos/ghostika/SensioDistributionBundle/branches{/branch}","tags_url":"https://api.github.com/repos/ghostika/SensioDistributionBundle/tags","blobs_url":"https://api.github.com/repos/ghostika/SensioDistributionBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ghostika/SensioDistributionBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ghostika/SensioDistributionBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/ghostika/SensioDistributionBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ghostika/SensioDistributionBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/ghostika/SensioDistributionBundle/languages","stargazers_url":"https://api.github.com/repos/ghostika/SensioDistributionBundle/stargazers","contributors_url":"https://api.github.com/repos/ghostika/SensioDistributionBundle/contributors","subscribers_url":"https://api.github.com/repos/ghostika/SensioDistributionBundle/subscribers","subscription_url":"https://api.github.com/repos/ghostika/SensioDistributionBundle/subscription","commits_url":"https://api.github.com/repos/ghostika/SensioDistributionBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/ghostika/SensioDistributionBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/ghostika/SensioDistributionBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/ghostika/SensioDistributionBundle/issues/comments/{number}","contents_url":"https://api.github.com/repos/ghostika/SensioDistributionBundle/contents/{+path}","compare_url":"https://api.github.com/repos/ghostika/SensioDistributionBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ghostika/SensioDistributionBundle/merges","archive_url":"https://api.github.com/repos/ghostika/SensioDistributionBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ghostika/SensioDistributionBundle/downloads","issues_url":"https://api.github.com/repos/ghostika/SensioDistributionBundle/issues{/number}","pulls_url":"https://api.github.com/repos/ghostika/SensioDistributionBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/ghostika/SensioDistributionBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/ghostika/SensioDistributionBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ghostika/SensioDistributionBundle/labels{/name}","releases_url":"https://api.github.com/repos/ghostika/SensioDistributionBundle/releases{/id}","created_at":"2014-08-25T06:36:38Z","updated_at":"2014-08-04T22:48:43Z","pushed_at":"2014-08-26T06:49:26Z","git_url":"git://github.com/ghostika/SensioDistributionBundle.git","ssh_url":"git@github.com:ghostika/SensioDistributionBundle.git","clone_url":"https://github.com/ghostika/SensioDistributionBundle.git","svn_url":"https://github.com/ghostika/SensioDistributionBundle","homepage":"symfony.com","size":2058,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sensiolabs:master","ref":"master","sha":"df82b1ee2b833be97677c0b95fca27e68fd4a344","user":{"login":"sensiolabs","id":1780787,"avatar_url":"https://avatars.githubusercontent.com/u/1780787?v=2","gravatar_id":"23d7def60ec23feb6449c13988b06696","url":"https://api.github.com/users/sensiolabs","html_url":"https://github.com/sensiolabs","followers_url":"https://api.github.com/users/sensiolabs/followers","following_url":"https://api.github.com/users/sensiolabs/following{/other_user}","gists_url":"https://api.github.com/users/sensiolabs/gists{/gist_id}","starred_url":"https://api.github.com/users/sensiolabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sensiolabs/subscriptions","organizations_url":"https://api.github.com/users/sensiolabs/orgs","repos_url":"https://api.github.com/users/sensiolabs/repos","events_url":"https://api.github.com/users/sensiolabs/events{/privacy}","received_events_url":"https://api.github.com/users/sensiolabs/received_events","type":"Organization","site_admin":false},"repo":{"id":1922015,"name":"SensioDistributionBundle","full_name":"sensiolabs/SensioDistributionBundle","owner":{"login":"sensiolabs","id":1780787,"avatar_url":"https://avatars.githubusercontent.com/u/1780787?v=2","gravatar_id":"23d7def60ec23feb6449c13988b06696","url":"https://api.github.com/users/sensiolabs","html_url":"https://github.com/sensiolabs","followers_url":"https://api.github.com/users/sensiolabs/followers","following_url":"https://api.github.com/users/sensiolabs/following{/other_user}","gists_url":"https://api.github.com/users/sensiolabs/gists{/gist_id}","starred_url":"https://api.github.com/users/sensiolabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sensiolabs/subscriptions","organizations_url":"https://api.github.com/users/sensiolabs/orgs","repos_url":"https://api.github.com/users/sensiolabs/repos","events_url":"https://api.github.com/users/sensiolabs/events{/privacy}","received_events_url":"https://api.github.com/users/sensiolabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sensiolabs/SensioDistributionBundle","description":"Base bundle for Symfony Distributions","fork":false,"url":"https://api.github.com/repos/sensiolabs/SensioDistributionBundle","forks_url":"https://api.github.com/repos/sensiolabs/SensioDistributionBundle/forks","keys_url":"https://api.github.com/repos/sensiolabs/SensioDistributionBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sensiolabs/SensioDistributionBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sensiolabs/SensioDistributionBundle/teams","hooks_url":"https://api.github.com/repos/sensiolabs/SensioDistributionBundle/hooks","issue_events_url":"https://api.github.com/repos/sensiolabs/SensioDistributionBundle/issues/events{/number}","events_url":"https://api.github.com/repos/sensiolabs/SensioDistributionBundle/events","assignees_url":"https://api.github.com/repos/sensiolabs/SensioDistributionBundle/assignees{/user}","branches_url":"https://api.github.com/repos/sensiolabs/SensioDistributionBundle/branches{/branch}","tags_url":"https://api.github.com/repos/sensiolabs/SensioDistributionBundle/tags","blobs_url":"https://api.github.com/repos/sensiolabs/SensioDistributionBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sensiolabs/SensioDistributionBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sensiolabs/SensioDistributionBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/sensiolabs/SensioDistributionBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sensiolabs/SensioDistributionBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/sensiolabs/SensioDistributionBundle/languages","stargazers_url":"https://api.github.com/repos/sensiolabs/SensioDistributionBundle/stargazers","contributors_url":"https://api.github.com/repos/sensiolabs/SensioDistributionBundle/contributors","subscribers_url":"https://api.github.com/repos/sensiolabs/SensioDistributionBundle/subscribers","subscription_url":"https://api.github.com/repos/sensiolabs/SensioDistributionBundle/subscription","commits_url":"https://api.github.com/repos/sensiolabs/SensioDistributionBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/sensiolabs/SensioDistributionBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/sensiolabs/SensioDistributionBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/sensiolabs/SensioDistributionBundle/issues/comments/{number}","contents_url":"https://api.github.com/repos/sensiolabs/SensioDistributionBundle/contents/{+path}","compare_url":"https://api.github.com/repos/sensiolabs/SensioDistributionBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sensiolabs/SensioDistributionBundle/merges","archive_url":"https://api.github.com/repos/sensiolabs/SensioDistributionBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sensiolabs/SensioDistributionBundle/downloads","issues_url":"https://api.github.com/repos/sensiolabs/SensioDistributionBundle/issues{/number}","pulls_url":"https://api.github.com/repos/sensiolabs/SensioDistributionBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/sensiolabs/SensioDistributionBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/sensiolabs/SensioDistributionBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sensiolabs/SensioDistributionBundle/labels{/name}","releases_url":"https://api.github.com/repos/sensiolabs/SensioDistributionBundle/releases{/id}","created_at":"2011-06-20T05:21:32Z","updated_at":"2014-08-04T22:48:43Z","pushed_at":"2014-08-26T13:14:56Z","git_url":"git://github.com/sensiolabs/SensioDistributionBundle.git","ssh_url":"git@github.com:sensiolabs/SensioDistributionBundle.git","clone_url":"https://github.com/sensiolabs/SensioDistributionBundle.git","svn_url":"https://github.com/sensiolabs/SensioDistributionBundle","homepage":"symfony.com","size":2058,"stargazers_count":86,"watchers_count":86,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":100,"mirror_url":null,"open_issues_count":14,"forks":100,"open_issues":14,"watchers":86,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sensiolabs/SensioDistributionBundle/pulls/161"},"html":{"href":"https://github.com/sensiolabs/SensioDistributionBundle/pull/161"},"issue":{"href":"https://api.github.com/repos/sensiolabs/SensioDistributionBundle/issues/161"},"comments":{"href":"https://api.github.com/repos/sensiolabs/SensioDistributionBundle/issues/161/comments"},"review_comments":{"href":"https://api.github.com/repos/sensiolabs/SensioDistributionBundle/pulls/161/comments"},"review_comment":{"href":"https://api.github.com/repos/sensiolabs/SensioDistributionBundle/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/sensiolabs/SensioDistributionBundle/pulls/161/commits"},"statuses":{"href":"https://api.github.com/repos/sensiolabs/SensioDistributionBundle/statuses/fd708c99ceb5df36795d294429aece2581c3dd33"}}}}