GitHub PullRequestReviewCommentEvent at 2014-01-19 20:33:27
Repository: pandas
Actor: jreback
Payload: {"comment":{"url":"https://api.github.com/repos/pydata/pandas/pulls/comments/8993897","id":8993897,"diff_hunk":"@@ -431,8 +432,9 @@ def save(self):\n \n     def __init__(self, path, engine=None, **engine_kwargs):\n         # validate that this engine can handle the extnesion\n-        ext = os.path.splitext(path)[-1]\n-        self.check_extension(ext)\n+        if not isinstance(path, StringIO):","path":"pandas/io/excel.py","position":14,"original_position":14,"commit_id":"fb57b123d4355d236309596f4b4096618a2999ef","original_commit_id":"fb57b123d4355d236309596f4b4096618a2999ef","user":{"login":"jreback","id":953992,"avatar_url":"https://gravatar.com/avatar/b2833d485728ee2f603802242ebc9826?d=https%3A%2F%2Fidenticons.github.com%2F6fa0622f6d56e3cc4169418634e1732c.png&r=x","gravatar_id":"b2833d485728ee2f603802242ebc9826","url":"https://api.github.com/users/jreback","html_url":"https://github.com/jreback","followers_url":"https://api.github.com/users/jreback/followers","following_url":"https://api.github.com/users/jreback/following{/other_user}","gists_url":"https://api.github.com/users/jreback/gists{/gist_id}","starred_url":"https://api.github.com/users/jreback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreback/subscriptions","organizations_url":"https://api.github.com/users/jreback/orgs","repos_url":"https://api.github.com/users/jreback/repos","events_url":"https://api.github.com/users/jreback/events{/privacy}","received_events_url":"https://api.github.com/users/jreback/received_events","type":"User","site_admin":false},"body":"thius should be ``hasattr(path,'read')`` to check a file-like object","created_at":"2014-01-19T20:33:27Z","updated_at":"2014-01-19T20:33:27Z","html_url":"https://github.com/pydata/pandas/pull/5992#discussion_r8993897","pull_request_url":"https://api.github.com/repos/pydata/pandas/pulls/5992","_links":{"self":{"href":"https://api.github.com/repos/pydata/pandas/pulls/comments/8993897"},"html":{"href":"https://github.com/pydata/pandas/pull/5992#discussion_r8993897"},"pull_request":{"href":"https://api.github.com/repos/pydata/pandas/pulls/5992"}}}}