GitHub PullRequestEvent at 2014-11-13 18:31:38
Repository: AFNetworking
Actor: mattt
Payload: {"action":"closed","number":2411,"pull_request":{"url":"https://api.github.com/repos/AFNetworking/AFNetworking/pulls/2411","id":24012577,"html_url":"https://github.com/AFNetworking/AFNetworking/pull/2411","diff_url":"https://github.com/AFNetworking/AFNetworking/pull/2411.diff","patch_url":"https://github.com/AFNetworking/AFNetworking/pull/2411.patch","issue_url":"https://api.github.com/repos/AFNetworking/AFNetworking/issues/2411","number":2411,"state":"closed","locked":false,"title":"Replace AFURLSessionManager's crashing KVO with method swizzling","user":{"login":"tangphillip","id":463460,"avatar_url":"https://avatars.githubusercontent.com/u/463460?v=3","gravatar_id":"","url":"https://api.github.com/users/tangphillip","html_url":"https://github.com/tangphillip","followers_url":"https://api.github.com/users/tangphillip/followers","following_url":"https://api.github.com/users/tangphillip/following{/other_user}","gists_url":"https://api.github.com/users/tangphillip/gists{/gist_id}","starred_url":"https://api.github.com/users/tangphillip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tangphillip/subscriptions","organizations_url":"https://api.github.com/users/tangphillip/orgs","repos_url":"https://api.github.com/users/tangphillip/repos","events_url":"https://api.github.com/users/tangphillip/events{/privacy}","received_events_url":"https://api.github.com/users/tangphillip/received_events","type":"User","site_admin":false},"body":"For background, see #1477. The tl;dr is that AFNetworking uses KVO in `AFURLSessionManager` to watch the state of `NSURLSessionTask`s...and that the KVO is causing LOTS of unreproducible crashes in production apps. It's Apple's bug, and we've filed lots of [bugs with Apple](http://openradar.appspot.com/18419882). They're looking at the bugs, but until they fix it, we should work around their problem.\r\n\r\nI don't really expect this to be merged, since swizzling is pretty obviously bad practice. That said, this fix for #1477 has been tested in our production app, with 500,000 updates...and no more `CFDictionaryGetValue` crashes.\r\n\r\nI have not tested this with background uploads or downloads. I have suspended a network call to see the `AFNetworkActivityIndicatorManager` stop the spinner, but our production app does NOT suspend network calls. I cannot say for certain that it will not cause problems if other apps do.","created_at":"2014-11-06T21:07:13Z","updated_at":"2014-11-13T18:31:37Z","closed_at":"2014-11-13T18:31:37Z","merged_at":"2014-11-13T18:31:36Z","merge_commit_sha":"3306bba1b8b6f4cda2f483646536a6a2429fffd4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/AFNetworking/AFNetworking/pulls/2411/commits","review_comments_url":"https://api.github.com/repos/AFNetworking/AFNetworking/pulls/2411/comments","review_comment_url":"https://api.github.com/repos/AFNetworking/AFNetworking/pulls/comments/{number}","comments_url":"https://api.github.com/repos/AFNetworking/AFNetworking/issues/2411/comments","statuses_url":"https://api.github.com/repos/AFNetworking/AFNetworking/statuses/ba43f55497af92269d10dcd84701cdf79da4eaff","head":{"label":"tangphillip:master","ref":"master","sha":"ba43f55497af92269d10dcd84701cdf79da4eaff","user":{"login":"tangphillip","id":463460,"avatar_url":"https://avatars.githubusercontent.com/u/463460?v=3","gravatar_id":"","url":"https://api.github.com/users/tangphillip","html_url":"https://github.com/tangphillip","followers_url":"https://api.github.com/users/tangphillip/followers","following_url":"https://api.github.com/users/tangphillip/following{/other_user}","gists_url":"https://api.github.com/users/tangphillip/gists{/gist_id}","starred_url":"https://api.github.com/users/tangphillip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tangphillip/subscriptions","organizations_url":"https://api.github.com/users/tangphillip/orgs","repos_url":"https://api.github.com/users/tangphillip/repos","events_url":"https://api.github.com/users/tangphillip/events{/privacy}","received_events_url":"https://api.github.com/users/tangphillip/received_events","type":"User","site_admin":false},"repo":{"id":26289368,"name":"AFNetworking","full_name":"tangphillip/AFNetworking","owner":{"login":"tangphillip","id":463460,"avatar_url":"https://avatars.githubusercontent.com/u/463460?v=3","gravatar_id":"","url":"https://api.github.com/users/tangphillip","html_url":"https://github.com/tangphillip","followers_url":"https://api.github.com/users/tangphillip/followers","following_url":"https://api.github.com/users/tangphillip/following{/other_user}","gists_url":"https://api.github.com/users/tangphillip/gists{/gist_id}","starred_url":"https://api.github.com/users/tangphillip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tangphillip/subscriptions","organizations_url":"https://api.github.com/users/tangphillip/orgs","repos_url":"https://api.github.com/users/tangphillip/repos","events_url":"https://api.github.com/users/tangphillip/events{/privacy}","received_events_url":"https://api.github.com/users/tangphillip/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tangphillip/AFNetworking","description":"A delightful iOS and OS X networking framework","fork":true,"url":"https://api.github.com/repos/tangphillip/AFNetworking","forks_url":"https://api.github.com/repos/tangphillip/AFNetworking/forks","keys_url":"https://api.github.com/repos/tangphillip/AFNetworking/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tangphillip/AFNetworking/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tangphillip/AFNetworking/teams","hooks_url":"https://api.github.com/repos/tangphillip/AFNetworking/hooks","issue_events_url":"https://api.github.com/repos/tangphillip/AFNetworking/issues/events{/number}","events_url":"https://api.github.com/repos/tangphillip/AFNetworking/events","assignees_url":"https://api.github.com/repos/tangphillip/AFNetworking/assignees{/user}","branches_url":"https://api.github.com/repos/tangphillip/AFNetworking/branches{/branch}","tags_url":"https://api.github.com/repos/tangphillip/AFNetworking/tags","blobs_url":"https://api.github.com/repos/tangphillip/AFNetworking/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tangphillip/AFNetworking/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tangphillip/AFNetworking/git/refs{/sha}","trees_url":"https://api.github.com/repos/tangphillip/AFNetworking/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tangphillip/AFNetworking/statuses/{sha}","languages_url":"https://api.github.com/repos/tangphillip/AFNetworking/languages","stargazers_url":"https://api.github.com/repos/tangphillip/AFNetworking/stargazers","contributors_url":"https://api.github.com/repos/tangphillip/AFNetworking/contributors","subscribers_url":"https://api.github.com/repos/tangphillip/AFNetworking/subscribers","subscription_url":"https://api.github.com/repos/tangphillip/AFNetworking/subscription","commits_url":"https://api.github.com/repos/tangphillip/AFNetworking/commits{/sha}","git_commits_url":"https://api.github.com/repos/tangphillip/AFNetworking/git/commits{/sha}","comments_url":"https://api.github.com/repos/tangphillip/AFNetworking/comments{/number}","issue_comment_url":"https://api.github.com/repos/tangphillip/AFNetworking/issues/comments/{number}","contents_url":"https://api.github.com/repos/tangphillip/AFNetworking/contents/{+path}","compare_url":"https://api.github.com/repos/tangphillip/AFNetworking/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tangphillip/AFNetworking/merges","archive_url":"https://api.github.com/repos/tangphillip/AFNetworking/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tangphillip/AFNetworking/downloads","issues_url":"https://api.github.com/repos/tangphillip/AFNetworking/issues{/number}","pulls_url":"https://api.github.com/repos/tangphillip/AFNetworking/pulls{/number}","milestones_url":"https://api.github.com/repos/tangphillip/AFNetworking/milestones{/number}","notifications_url":"https://api.github.com/repos/tangphillip/AFNetworking/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tangphillip/AFNetworking/labels{/name}","releases_url":"https://api.github.com/repos/tangphillip/AFNetworking/releases{/id}","created_at":"2014-11-06T20:48:22Z","updated_at":"2014-11-06T20:50:54Z","pushed_at":"2014-11-06T21:28:23Z","git_url":"git://github.com/tangphillip/AFNetworking.git","ssh_url":"git@github.com:tangphillip/AFNetworking.git","clone_url":"https://github.com/tangphillip/AFNetworking.git","svn_url":"https://github.com/tangphillip/AFNetworking","homepage":"http://afnetworking.com","size":5376,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AFNetworking:master","ref":"master","sha":"225862607d3072103a3fa61524447914496755d4","user":{"login":"AFNetworking","id":1181541,"avatar_url":"https://avatars.githubusercontent.com/u/1181541?v=3","gravatar_id":"","url":"https://api.github.com/users/AFNetworking","html_url":"https://github.com/AFNetworking","followers_url":"https://api.github.com/users/AFNetworking/followers","following_url":"https://api.github.com/users/AFNetworking/following{/other_user}","gists_url":"https://api.github.com/users/AFNetworking/gists{/gist_id}","starred_url":"https://api.github.com/users/AFNetworking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AFNetworking/subscriptions","organizations_url":"https://api.github.com/users/AFNetworking/orgs","repos_url":"https://api.github.com/users/AFNetworking/repos","events_url":"https://api.github.com/users/AFNetworking/events{/privacy}","received_events_url":"https://api.github.com/users/AFNetworking/received_events","type":"Organization","site_admin":false},"repo":{"id":1828795,"name":"AFNetworking","full_name":"AFNetworking/AFNetworking","owner":{"login":"AFNetworking","id":1181541,"avatar_url":"https://avatars.githubusercontent.com/u/1181541?v=3","gravatar_id":"","url":"https://api.github.com/users/AFNetworking","html_url":"https://github.com/AFNetworking","followers_url":"https://api.github.com/users/AFNetworking/followers","following_url":"https://api.github.com/users/AFNetworking/following{/other_user}","gists_url":"https://api.github.com/users/AFNetworking/gists{/gist_id}","starred_url":"https://api.github.com/users/AFNetworking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AFNetworking/subscriptions","organizations_url":"https://api.github.com/users/AFNetworking/orgs","repos_url":"https://api.github.com/users/AFNetworking/repos","events_url":"https://api.github.com/users/AFNetworking/events{/privacy}","received_events_url":"https://api.github.com/users/AFNetworking/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AFNetworking/AFNetworking","description":"A delightful iOS and OS X networking framework","fork":false,"url":"https://api.github.com/repos/AFNetworking/AFNetworking","forks_url":"https://api.github.com/repos/AFNetworking/AFNetworking/forks","keys_url":"https://api.github.com/repos/AFNetworking/AFNetworking/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AFNetworking/AFNetworking/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AFNetworking/AFNetworking/teams","hooks_url":"https://api.github.com/repos/AFNetworking/AFNetworking/hooks","issue_events_url":"https://api.github.com/repos/AFNetworking/AFNetworking/issues/events{/number}","events_url":"https://api.github.com/repos/AFNetworking/AFNetworking/events","assignees_url":"https://api.github.com/repos/AFNetworking/AFNetworking/assignees{/user}","branches_url":"https://api.github.com/repos/AFNetworking/AFNetworking/branches{/branch}","tags_url":"https://api.github.com/repos/AFNetworking/AFNetworking/tags","blobs_url":"https://api.github.com/repos/AFNetworking/AFNetworking/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AFNetworking/AFNetworking/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AFNetworking/AFNetworking/git/refs{/sha}","trees_url":"https://api.github.com/repos/AFNetworking/AFNetworking/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AFNetworking/AFNetworking/statuses/{sha}","languages_url":"https://api.github.com/repos/AFNetworking/AFNetworking/languages","stargazers_url":"https://api.github.com/repos/AFNetworking/AFNetworking/stargazers","contributors_url":"https://api.github.com/repos/AFNetworking/AFNetworking/contributors","subscribers_url":"https://api.github.com/repos/AFNetworking/AFNetworking/subscribers","subscription_url":"https://api.github.com/repos/AFNetworking/AFNetworking/subscription","commits_url":"https://api.github.com/repos/AFNetworking/AFNetworking/commits{/sha}","git_commits_url":"https://api.github.com/repos/AFNetworking/AFNetworking/git/commits{/sha}","comments_url":"https://api.github.com/repos/AFNetworking/AFNetworking/comments{/number}","issue_comment_url":"https://api.github.com/repos/AFNetworking/AFNetworking/issues/comments/{number}","contents_url":"https://api.github.com/repos/AFNetworking/AFNetworking/contents/{+path}","compare_url":"https://api.github.com/repos/AFNetworking/AFNetworking/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AFNetworking/AFNetworking/merges","archive_url":"https://api.github.com/repos/AFNetworking/AFNetworking/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AFNetworking/AFNetworking/downloads","issues_url":"https://api.github.com/repos/AFNetworking/AFNetworking/issues{/number}","pulls_url":"https://api.github.com/repos/AFNetworking/AFNetworking/pulls{/number}","milestones_url":"https://api.github.com/repos/AFNetworking/AFNetworking/milestones{/number}","notifications_url":"https://api.github.com/repos/AFNetworking/AFNetworking/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AFNetworking/AFNetworking/labels{/name}","releases_url":"https://api.github.com/repos/AFNetworking/AFNetworking/releases{/id}","created_at":"2011-05-31T21:28:44Z","updated_at":"2014-11-13T15:28:54Z","pushed_at":"2014-11-13T18:31:37Z","git_url":"git://github.com/AFNetworking/AFNetworking.git","ssh_url":"git@github.com:AFNetworking/AFNetworking.git","clone_url":"https://github.com/AFNetworking/AFNetworking.git","svn_url":"https://github.com/AFNetworking/AFNetworking","homepage":"http://afnetworking.com","size":19708,"stargazers_count":14449,"watchers_count":14449,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4075,"mirror_url":null,"open_issues_count":28,"forks":4075,"open_issues":28,"watchers":14449,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AFNetworking/AFNetworking/pulls/2411"},"html":{"href":"https://github.com/AFNetworking/AFNetworking/pull/2411"},"issue":{"href":"https://api.github.com/repos/AFNetworking/AFNetworking/issues/2411"},"comments":{"href":"https://api.github.com/repos/AFNetworking/AFNetworking/issues/2411/comments"},"review_comments":{"href":"https://api.github.com/repos/AFNetworking/AFNetworking/pulls/2411/comments"},"review_comment":{"href":"https://api.github.com/repos/AFNetworking/AFNetworking/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/AFNetworking/AFNetworking/pulls/2411/commits"},"statuses":{"href":"https://api.github.com/repos/AFNetworking/AFNetworking/statuses/ba43f55497af92269d10dcd84701cdf79da4eaff"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"mattt","id":7659,"avatar_url":"https://avatars.githubusercontent.com/u/7659?v=3","gravatar_id":"","url":"https://api.github.com/users/mattt","html_url":"https://github.com/mattt","followers_url":"https://api.github.com/users/mattt/followers","following_url":"https://api.github.com/users/mattt/following{/other_user}","gists_url":"https://api.github.com/users/mattt/gists{/gist_id}","starred_url":"https://api.github.com/users/mattt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattt/subscriptions","organizations_url":"https://api.github.com/users/mattt/orgs","repos_url":"https://api.github.com/users/mattt/repos","events_url":"https://api.github.com/users/mattt/events{/privacy}","received_events_url":"https://api.github.com/users/mattt/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":2,"additions":91,"deletions":47,"changed_files":1}}