GitHub PullRequestReviewCommentEvent at 2014-03-05 19:22:12
Repository: wet-boew
Actor: pjackson28
Payload: {"comment":{"url":"https://api.github.com/repos/wet-boew/wet-boew/pulls/comments/10313891","id":10313891,"diff_hunk":"@@ -1868,21 +1826,33 @@ var selector = \".wb-geomap\",\n \t},\n \t\n \t// Construct a polygon and densify the latitudes to show the curvature\t\n-\tdensifyBBox = function(minx, miny, maxx, maxy) {\n+\tdensifyBBox = function( minx, miny, maxx, maxy ) {\n \t\t\n-\t\tvar left = parseFloat(minx),\n-\t\t\tbottom = parseFloat(miny),\n-\t\t\tright = parseFloat(maxx),\n-\t\t\ttop = parseFloat(maxy),\n+\t\tvar left = parseFloat( minx ),\n+\t\t\tbottom = parseFloat( miny ),\n+\t\t\tright = parseFloat( maxx ),\n+\t\t\ttop = parseFloat( maxy ),\n \t\t\tnewbounds = [ ], newPoint, j;\n \t\t\n-\t\tif (left.length === 0 || bottom.length === 0 || right.length === 0 || top.length === 0) { return false; }\n+\t\tif ( left.length === 0 || bottom.length === 0 ||\n+\t\t\tright.length === 0 || top.length === 0 ) {\n+\n+\t\t\treturn false;\n+\t\t}\n \t\n \t\t// If default BBOX, make it fit in view showing Canada and not the world.\n-\t\tif (left === -180.0) { left = -179.9; }\n-\t\tif (right === 180.0) { right = -5.0; }\n-\t\tif (top === 90.0) { top = 87.0; }\n-\t\tif (bottom === -90.0) { bottom = 35.0; }\n+\t\tif ( left === -180.0 ) {\n+\t\t\tleft = -179.9;","path":"src/plugins/geomap/geomap.js","position":683,"original_position":683,"commit_id":"581674bbbf5697d8761e36577e1e2a0e870c8172","original_commit_id":"581674bbbf5697d8761e36577e1e2a0e870c8172","user":{"login":"pjackson28","id":1326498,"avatar_url":"https://gravatar.com/avatar/5a3957f28b2b82efc7f0f1a3ff52e847?d=https%3A%2F%2Fidenticons.github.com%2F4e9e8d697bcfa822bd47213f1a6e414e.png&r=x","gravatar_id":"5a3957f28b2b82efc7f0f1a3ff52e847","url":"https://api.github.com/users/pjackson28","html_url":"https://github.com/pjackson28","followers_url":"https://api.github.com/users/pjackson28/followers","following_url":"https://api.github.com/users/pjackson28/following{/other_user}","gists_url":"https://api.github.com/users/pjackson28/gists{/gist_id}","starred_url":"https://api.github.com/users/pjackson28/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjackson28/subscriptions","organizations_url":"https://api.github.com/users/pjackson28/orgs","repos_url":"https://api.github.com/users/pjackson28/repos","events_url":"https://api.github.com/users/pjackson28/events{/privacy}","received_events_url":"https://api.github.com/users/pjackson28/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2014-03-05T19:22:12Z","updated_at":"2014-03-05T19:22:12Z","html_url":"https://github.com/wet-boew/wet-boew/pull/4686#discussion_r10313891","pull_request_url":"https://api.github.com/repos/wet-boew/wet-boew/pulls/4686","_links":{"self":{"href":"https://api.github.com/repos/wet-boew/wet-boew/pulls/comments/10313891"},"html":{"href":"https://github.com/wet-boew/wet-boew/pull/4686#discussion_r10313891"},"pull_request":{"href":"https://api.github.com/repos/wet-boew/wet-boew/pulls/4686"}}}}