GitHub PullRequestReviewCommentEvent at 2014-06-20 15:33:00
Repository: csbot
Actor: LordAro
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/HackSoc/csbot/pulls/comments/14025660","id":14025660,"diff_hunk":"@@ -290,88 +286,74 @@ def names(self, channel, names, raw_names):\n             'raw_names': raw_names,\n         })\n \n-    def userQuit(self, user, message):\n+    def on_user_quit(self, user, message):\n         self.emit_new('core.user.quit', {\n-            'user': user,\n+            'user': user.raw,\n             'message': message,\n         })\n \n-    def userRenamed(self, oldnick, newnick):\n+    def on_user_renamed(self, oldnick, newnick):\n         self.emit_new('core.user.renamed', {\n             'oldnick': oldnick,\n             'newnick': newnick,\n         })\n \n-    def irc_RPL_NAMREPLY(self, prefix, params):\n-        channel = params[2]\n-        self.names_accumulator[channel].extend(params[3].split())\n+    def irc_RPL_NAMREPLY(self, msg):\n+        channel = msg.params[2]\n+        self.names_accumulator[channel].extend(msg.params[3].split())\n \n-    def irc_RPL_ENDOFNAMES(self, prefix, params):\n+    def irc_RPL_ENDOFNAMES(self, msg):\n         # Get channel and raw names list\n-        channel = params[1]\n+        channel = msg.params[1]\n         raw_names = self.names_accumulator.pop(channel, [])\n \n+        # TODO: restore this functionality","path":"csbot/core.py","position":235,"original_position":235,"commit_id":"fddf258e88e044047c42cdf46366fb4a7272e0cf","original_commit_id":"fddf258e88e044047c42cdf46366fb4a7272e0cf","user":{"login":"LordAro","id":4007992,"avatar_url":"https://avatars.githubusercontent.com/u/4007992?","gravatar_id":"4cd28a85e5f09b256a389891abefe3cd","url":"https://api.github.com/users/LordAro","html_url":"https://github.com/LordAro","followers_url":"https://api.github.com/users/LordAro/followers","following_url":"https://api.github.com/users/LordAro/following{/other_user}","gists_url":"https://api.github.com/users/LordAro/gists{/gist_id}","starred_url":"https://api.github.com/users/LordAro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LordAro/subscriptions","organizations_url":"https://api.github.com/users/LordAro/orgs","repos_url":"https://api.github.com/users/LordAro/repos","events_url":"https://api.github.com/users/LordAro/events{/privacy}","received_events_url":"https://api.github.com/users/LordAro/received_events","type":"User","site_admin":false},"body":"Still needs doing, i guess","created_at":"2014-06-20T15:33:00Z","updated_at":"2014-06-20T15:33:00Z","html_url":"https://github.com/HackSoc/csbot/pull/62#discussion_r14025660","pull_request_url":"https://api.github.com/repos/HackSoc/csbot/pulls/62","_links":{"self":{"href":"https://api.github.com/repos/HackSoc/csbot/pulls/comments/14025660"},"html":{"href":"https://github.com/HackSoc/csbot/pull/62#discussion_r14025660"},"pull_request":{"href":"https://api.github.com/repos/HackSoc/csbot/pulls/62"}}},"pull_request":{"url":"https://api.github.com/repos/HackSoc/csbot/pulls/62","id":17405246,"html_url":"https://github.com/HackSoc/csbot/pull/62","diff_url":"https://github.com/HackSoc/csbot/pull/62.diff","patch_url":"https://github.com/HackSoc/csbot/pull/62.patch","issue_url":"https://api.github.com/repos/HackSoc/csbot/issues/62","number":62,"state":"open","title":"Port to Python 3","user":{"login":"alanbriolat","id":12193,"avatar_url":"https://avatars.githubusercontent.com/u/12193?","gravatar_id":"948c78c3dfd92506aaee317d4b762bc8","url":"https://api.github.com/users/alanbriolat","html_url":"https://github.com/alanbriolat","followers_url":"https://api.github.com/users/alanbriolat/followers","following_url":"https://api.github.com/users/alanbriolat/following{/other_user}","gists_url":"https://api.github.com/users/alanbriolat/gists{/gist_id}","starred_url":"https://api.github.com/users/alanbriolat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alanbriolat/subscriptions","organizations_url":"https://api.github.com/users/alanbriolat/orgs","repos_url":"https://api.github.com/users/alanbriolat/repos","events_url":"https://api.github.com/users/alanbriolat/events{/privacy}","received_events_url":"https://api.github.com/users/alanbriolat/received_events","type":"User","site_admin":false},"body":"Enter the future! Use Python 3!\r\n\r\nIt seems that all dependencies except for Twisted are fully ported to Python 3.  The core of Twisted is ported (as of version 14), but ``twisted.words`` is not.  This leaves us with a few options:\r\n\r\n* Stay on Python 2 - boring!\r\n* Port ``twisted.words.protocols.irc`` to Python 3 - this is a pretty big job, and people have already tried and failed (http://twistedmatrix.com/trac/ticket/6320).\r\n* Port csbot onto a different framework.\r\n\r\nThe latter seems the most viable.  With Python 3.4 and \"project Tulip\" making it into the standard library as the ``asyncio`` module, it's the logical target.  Either we should write a new client library on top of ``asyncio`` or base csbot on an existing one, e.g. https://github.com/gawel/irc3.","created_at":"2014-06-20T13:29:42Z","updated_at":"2014-06-20T15:33:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2056b64577763174da82b6d3cf074355c52cd93e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/HackSoc/csbot/pulls/62/commits","review_comments_url":"https://api.github.com/repos/HackSoc/csbot/pulls/62/comments","review_comment_url":"https://api.github.com/repos/HackSoc/csbot/pulls/comments/{number}","comments_url":"https://api.github.com/repos/HackSoc/csbot/issues/62/comments","statuses_url":"https://api.github.com/repos/HackSoc/csbot/statuses/fddf258e88e044047c42cdf46366fb4a7272e0cf","head":{"label":"alanbriolat:python3","ref":"python3","sha":"fddf258e88e044047c42cdf46366fb4a7272e0cf","user":{"login":"alanbriolat","id":12193,"avatar_url":"https://avatars.githubusercontent.com/u/12193?","gravatar_id":"948c78c3dfd92506aaee317d4b762bc8","url":"https://api.github.com/users/alanbriolat","html_url":"https://github.com/alanbriolat","followers_url":"https://api.github.com/users/alanbriolat/followers","following_url":"https://api.github.com/users/alanbriolat/following{/other_user}","gists_url":"https://api.github.com/users/alanbriolat/gists{/gist_id}","starred_url":"https://api.github.com/users/alanbriolat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alanbriolat/subscriptions","organizations_url":"https://api.github.com/users/alanbriolat/orgs","repos_url":"https://api.github.com/users/alanbriolat/repos","events_url":"https://api.github.com/users/alanbriolat/events{/privacy}","received_events_url":"https://api.github.com/users/alanbriolat/received_events","type":"User","site_admin":false},"repo":{"id":3900665,"name":"csbot","full_name":"alanbriolat/csbot","owner":{"login":"alanbriolat","id":12193,"avatar_url":"https://avatars.githubusercontent.com/u/12193?","gravatar_id":"948c78c3dfd92506aaee317d4b762bc8","url":"https://api.github.com/users/alanbriolat","html_url":"https://github.com/alanbriolat","followers_url":"https://api.github.com/users/alanbriolat/followers","following_url":"https://api.github.com/users/alanbriolat/following{/other_user}","gists_url":"https://api.github.com/users/alanbriolat/gists{/gist_id}","starred_url":"https://api.github.com/users/alanbriolat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alanbriolat/subscriptions","organizations_url":"https://api.github.com/users/alanbriolat/orgs","repos_url":"https://api.github.com/users/alanbriolat/repos","events_url":"https://api.github.com/users/alanbriolat/events{/privacy}","received_events_url":"https://api.github.com/users/alanbriolat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alanbriolat/csbot","description":"","fork":true,"url":"https://api.github.com/repos/alanbriolat/csbot","forks_url":"https://api.github.com/repos/alanbriolat/csbot/forks","keys_url":"https://api.github.com/repos/alanbriolat/csbot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alanbriolat/csbot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alanbriolat/csbot/teams","hooks_url":"https://api.github.com/repos/alanbriolat/csbot/hooks","issue_events_url":"https://api.github.com/repos/alanbriolat/csbot/issues/events{/number}","events_url":"https://api.github.com/repos/alanbriolat/csbot/events","assignees_url":"https://api.github.com/repos/alanbriolat/csbot/assignees{/user}","branches_url":"https://api.github.com/repos/alanbriolat/csbot/branches{/branch}","tags_url":"https://api.github.com/repos/alanbriolat/csbot/tags","blobs_url":"https://api.github.com/repos/alanbriolat/csbot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alanbriolat/csbot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alanbriolat/csbot/git/refs{/sha}","trees_url":"https://api.github.com/repos/alanbriolat/csbot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alanbriolat/csbot/statuses/{sha}","languages_url":"https://api.github.com/repos/alanbriolat/csbot/languages","stargazers_url":"https://api.github.com/repos/alanbriolat/csbot/stargazers","contributors_url":"https://api.github.com/repos/alanbriolat/csbot/contributors","subscribers_url":"https://api.github.com/repos/alanbriolat/csbot/subscribers","subscription_url":"https://api.github.com/repos/alanbriolat/csbot/subscription","commits_url":"https://api.github.com/repos/alanbriolat/csbot/commits{/sha}","git_commits_url":"https://api.github.com/repos/alanbriolat/csbot/git/commits{/sha}","comments_url":"https://api.github.com/repos/alanbriolat/csbot/comments{/number}","issue_comment_url":"https://api.github.com/repos/alanbriolat/csbot/issues/comments/{number}","contents_url":"https://api.github.com/repos/alanbriolat/csbot/contents/{+path}","compare_url":"https://api.github.com/repos/alanbriolat/csbot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alanbriolat/csbot/merges","archive_url":"https://api.github.com/repos/alanbriolat/csbot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alanbriolat/csbot/downloads","issues_url":"https://api.github.com/repos/alanbriolat/csbot/issues{/number}","pulls_url":"https://api.github.com/repos/alanbriolat/csbot/pulls{/number}","milestones_url":"https://api.github.com/repos/alanbriolat/csbot/milestones{/number}","notifications_url":"https://api.github.com/repos/alanbriolat/csbot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alanbriolat/csbot/labels{/name}","releases_url":"https://api.github.com/repos/alanbriolat/csbot/releases{/id}","created_at":"2012-04-02T13:05:57Z","updated_at":"2014-06-20T14:23:06Z","pushed_at":"2014-06-20T14:23:10Z","git_url":"git://github.com/alanbriolat/csbot.git","ssh_url":"git@github.com:alanbriolat/csbot.git","clone_url":"https://github.com/alanbriolat/csbot.git","svn_url":"https://github.com/alanbriolat/csbot","homepage":"","size":1050,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"HackSoc:master","ref":"master","sha":"8c62447344bf1cf5ed65c5080afb06cc7d2536b1","user":{"login":"HackSoc","id":2779397,"avatar_url":"https://avatars.githubusercontent.com/u/2779397?","gravatar_id":"c7ab429713324aa31d5cb2e8de7239bd","url":"https://api.github.com/users/HackSoc","html_url":"https://github.com/HackSoc","followers_url":"https://api.github.com/users/HackSoc/followers","following_url":"https://api.github.com/users/HackSoc/following{/other_user}","gists_url":"https://api.github.com/users/HackSoc/gists{/gist_id}","starred_url":"https://api.github.com/users/HackSoc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HackSoc/subscriptions","organizations_url":"https://api.github.com/users/HackSoc/orgs","repos_url":"https://api.github.com/users/HackSoc/repos","events_url":"https://api.github.com/users/HackSoc/events{/privacy}","received_events_url":"https://api.github.com/users/HackSoc/received_events","type":"Organization","site_admin":false},"repo":{"id":3900408,"name":"csbot","full_name":"HackSoc/csbot","owner":{"login":"HackSoc","id":2779397,"avatar_url":"https://avatars.githubusercontent.com/u/2779397?","gravatar_id":"c7ab429713324aa31d5cb2e8de7239bd","url":"https://api.github.com/users/HackSoc","html_url":"https://github.com/HackSoc","followers_url":"https://api.github.com/users/HackSoc/followers","following_url":"https://api.github.com/users/HackSoc/following{/other_user}","gists_url":"https://api.github.com/users/HackSoc/gists{/gist_id}","starred_url":"https://api.github.com/users/HackSoc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HackSoc/subscriptions","organizations_url":"https://api.github.com/users/HackSoc/orgs","repos_url":"https://api.github.com/users/HackSoc/repos","events_url":"https://api.github.com/users/HackSoc/events{/privacy}","received_events_url":"https://api.github.com/users/HackSoc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HackSoc/csbot","description":"An IRC bot and plugin system for the #cs-york channel on irc.freenode.net","fork":false,"url":"https://api.github.com/repos/HackSoc/csbot","forks_url":"https://api.github.com/repos/HackSoc/csbot/forks","keys_url":"https://api.github.com/repos/HackSoc/csbot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HackSoc/csbot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HackSoc/csbot/teams","hooks_url":"https://api.github.com/repos/HackSoc/csbot/hooks","issue_events_url":"https://api.github.com/repos/HackSoc/csbot/issues/events{/number}","events_url":"https://api.github.com/repos/HackSoc/csbot/events","assignees_url":"https://api.github.com/repos/HackSoc/csbot/assignees{/user}","branches_url":"https://api.github.com/repos/HackSoc/csbot/branches{/branch}","tags_url":"https://api.github.com/repos/HackSoc/csbot/tags","blobs_url":"https://api.github.com/repos/HackSoc/csbot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HackSoc/csbot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HackSoc/csbot/git/refs{/sha}","trees_url":"https://api.github.com/repos/HackSoc/csbot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HackSoc/csbot/statuses/{sha}","languages_url":"https://api.github.com/repos/HackSoc/csbot/languages","stargazers_url":"https://api.github.com/repos/HackSoc/csbot/stargazers","contributors_url":"https://api.github.com/repos/HackSoc/csbot/contributors","subscribers_url":"https://api.github.com/repos/HackSoc/csbot/subscribers","subscription_url":"https://api.github.com/repos/HackSoc/csbot/subscription","commits_url":"https://api.github.com/repos/HackSoc/csbot/commits{/sha}","git_commits_url":"https://api.github.com/repos/HackSoc/csbot/git/commits{/sha}","comments_url":"https://api.github.com/repos/HackSoc/csbot/comments{/number}","issue_comment_url":"https://api.github.com/repos/HackSoc/csbot/issues/comments/{number}","contents_url":"https://api.github.com/repos/HackSoc/csbot/contents/{+path}","compare_url":"https://api.github.com/repos/HackSoc/csbot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HackSoc/csbot/merges","archive_url":"https://api.github.com/repos/HackSoc/csbot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HackSoc/csbot/downloads","issues_url":"https://api.github.com/repos/HackSoc/csbot/issues{/number}","pulls_url":"https://api.github.com/repos/HackSoc/csbot/pulls{/number}","milestones_url":"https://api.github.com/repos/HackSoc/csbot/milestones{/number}","notifications_url":"https://api.github.com/repos/HackSoc/csbot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HackSoc/csbot/labels{/name}","releases_url":"https://api.github.com/repos/HackSoc/csbot/releases{/id}","created_at":"2012-04-02T12:34:14Z","updated_at":"2014-06-19T16:48:38Z","pushed_at":"2014-06-19T16:48:42Z","git_url":"git://github.com/HackSoc/csbot.git","ssh_url":"git@github.com:HackSoc/csbot.git","clone_url":"https://github.com/HackSoc/csbot.git","svn_url":"https://github.com/HackSoc/csbot","homepage":"","size":2339,"stargazers_count":13,"watchers_count":13,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":12,"mirror_url":null,"open_issues_count":7,"forks":12,"open_issues":7,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HackSoc/csbot/pulls/62"},"html":{"href":"https://github.com/HackSoc/csbot/pull/62"},"issue":{"href":"https://api.github.com/repos/HackSoc/csbot/issues/62"},"comments":{"href":"https://api.github.com/repos/HackSoc/csbot/issues/62/comments"},"review_comments":{"href":"https://api.github.com/repos/HackSoc/csbot/pulls/62/comments"},"review_comment":{"href":"https://api.github.com/repos/HackSoc/csbot/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/HackSoc/csbot/pulls/62/commits"},"statuses":{"href":"https://api.github.com/repos/HackSoc/csbot/statuses/fddf258e88e044047c42cdf46366fb4a7272e0cf"}}}}