GitHub PullRequestReviewCommentEvent at 2014-06-11 15:00:05
Repository: navitia
Actor: antoine-de
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/CanalTP/navitia/pulls/comments/13653601","id":13653601,"diff_hunk":"@@ -158,36 +177,74 @@ def key_of_id(self, object_id):\n                 flat = float(lat)\n             except:\n                 raise RegionNotFound(object_id=object_id)\n-            return self.key_of_coord(flon, flat)\n-        else:\n-            ptobject = models.PtObject.get_from_uri(object_id)\n-            if ptobject:\n-                instances = ptobject.instances()\n-                if len(instances) > 0:\n-                    return instances[0].name\n+            return self.key_of_coord(flon, flat, only_one)\n+\n+        ptobject = models.PtObject.get_from_uri(object_id)\n+        if ptobject:","path":"source/jormungandr/jormungandr/instance_manager.py","position":69,"original_position":69,"commit_id":"1b98c683495aac23c59f1e910d8fd257d2239347","original_commit_id":"1b98c683495aac23c59f1e910d8fd257d2239347","user":{"login":"antoine-de","id":3987698,"avatar_url":"https://avatars.githubusercontent.com/u/3987698?","gravatar_id":"8dd8d4a02558295ff9429c91d8423286","url":"https://api.github.com/users/antoine-de","html_url":"https://github.com/antoine-de","followers_url":"https://api.github.com/users/antoine-de/followers","following_url":"https://api.github.com/users/antoine-de/following{/other_user}","gists_url":"https://api.github.com/users/antoine-de/gists{/gist_id}","starred_url":"https://api.github.com/users/antoine-de/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antoine-de/subscriptions","organizations_url":"https://api.github.com/users/antoine-de/orgs","repos_url":"https://api.github.com/users/antoine-de/repos","events_url":"https://api.github.com/users/antoine-de/events{/privacy}","received_events_url":"https://api.github.com/users/antoine-de/received_events","type":"User","site_admin":false},"body":"ben si c'est en public=True ya pas de soucis non ?\r\n\r\ntu penses pas que c'est mieux de garder un seul truc ?","created_at":"2014-06-11T15:00:05Z","updated_at":"2014-06-11T15:00:05Z","html_url":"https://github.com/CanalTP/navitia/pull/389#discussion_r13653601","pull_request_url":"https://api.github.com/repos/CanalTP/navitia/pulls/389","_links":{"self":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/comments/13653601"},"html":{"href":"https://github.com/CanalTP/navitia/pull/389#discussion_r13653601"},"pull_request":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/389"}}},"pull_request":{"url":"https://api.github.com/repos/CanalTP/navitia/pulls/389","id":17002042,"html_url":"https://github.com/CanalTP/navitia/pull/389","diff_url":"https://github.com/CanalTP/navitia/pull/389.diff","patch_url":"https://github.com/CanalTP/navitia/pull/389.patch","issue_url":"https://api.github.com/repos/CanalTP/navitia/issues/389","number":389,"state":"open","title":"Release 0.97.2","user":{"login":"antoine-de","id":3987698,"avatar_url":"https://avatars.githubusercontent.com/u/3987698?","gravatar_id":"8dd8d4a02558295ff9429c91d8423286","url":"https://api.github.com/users/antoine-de","html_url":"https://github.com/antoine-de","followers_url":"https://api.github.com/users/antoine-de/followers","following_url":"https://api.github.com/users/antoine-de/following{/other_user}","gists_url":"https://api.github.com/users/antoine-de/gists{/gist_id}","starred_url":"https://api.github.com/users/antoine-de/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antoine-de/subscriptions","organizations_url":"https://api.github.com/users/antoine-de/orgs","repos_url":"https://api.github.com/users/antoine-de/repos","events_url":"https://api.github.com/users/antoine-de/events{/privacy}","received_events_url":"https://api.github.com/users/antoine-de/received_events","type":"User","site_admin":false},"body":"Hot fix for navitia.io release.\r\n\r\nHandle multi coverage.\r\n\r\nBig impact on authentication because journeys authentication now handle multi layer of covered regions.\r\n\r\n**DO NOT merge this PR, just for review for the moment !!**","created_at":"2014-06-11T14:46:21Z","updated_at":"2014-06-11T15:00:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dbf91fff0eb9af9d228443f1b7f6e6ba9275ecc9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CanalTP/navitia/pulls/389/commits","review_comments_url":"https://api.github.com/repos/CanalTP/navitia/pulls/389/comments","review_comment_url":"https://api.github.com/repos/CanalTP/navitia/pulls/comments/{number}","comments_url":"https://api.github.com/repos/CanalTP/navitia/issues/389/comments","statuses_url":"https://api.github.com/repos/CanalTP/navitia/statuses/1b98c683495aac23c59f1e910d8fd257d2239347","head":{"label":"antoine-de:release_0.97.2","ref":"release_0.97.2","sha":"1b98c683495aac23c59f1e910d8fd257d2239347","user":{"login":"antoine-de","id":3987698,"avatar_url":"https://avatars.githubusercontent.com/u/3987698?","gravatar_id":"8dd8d4a02558295ff9429c91d8423286","url":"https://api.github.com/users/antoine-de","html_url":"https://github.com/antoine-de","followers_url":"https://api.github.com/users/antoine-de/followers","following_url":"https://api.github.com/users/antoine-de/following{/other_user}","gists_url":"https://api.github.com/users/antoine-de/gists{/gist_id}","starred_url":"https://api.github.com/users/antoine-de/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antoine-de/subscriptions","organizations_url":"https://api.github.com/users/antoine-de/orgs","repos_url":"https://api.github.com/users/antoine-de/repos","events_url":"https://api.github.com/users/antoine-de/events{/privacy}","received_events_url":"https://api.github.com/users/antoine-de/received_events","type":"User","site_admin":false},"repo":{"id":19144843,"name":"navitia","full_name":"antoine-de/navitia","owner":{"login":"antoine-de","id":3987698,"avatar_url":"https://avatars.githubusercontent.com/u/3987698?","gravatar_id":"8dd8d4a02558295ff9429c91d8423286","url":"https://api.github.com/users/antoine-de","html_url":"https://github.com/antoine-de","followers_url":"https://api.github.com/users/antoine-de/followers","following_url":"https://api.github.com/users/antoine-de/following{/other_user}","gists_url":"https://api.github.com/users/antoine-de/gists{/gist_id}","starred_url":"https://api.github.com/users/antoine-de/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antoine-de/subscriptions","organizations_url":"https://api.github.com/users/antoine-de/orgs","repos_url":"https://api.github.com/users/antoine-de/repos","events_url":"https://api.github.com/users/antoine-de/events{/privacy}","received_events_url":"https://api.github.com/users/antoine-de/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/antoine-de/navitia","description":"","fork":true,"url":"https://api.github.com/repos/antoine-de/navitia","forks_url":"https://api.github.com/repos/antoine-de/navitia/forks","keys_url":"https://api.github.com/repos/antoine-de/navitia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/antoine-de/navitia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/antoine-de/navitia/teams","hooks_url":"https://api.github.com/repos/antoine-de/navitia/hooks","issue_events_url":"https://api.github.com/repos/antoine-de/navitia/issues/events{/number}","events_url":"https://api.github.com/repos/antoine-de/navitia/events","assignees_url":"https://api.github.com/repos/antoine-de/navitia/assignees{/user}","branches_url":"https://api.github.com/repos/antoine-de/navitia/branches{/branch}","tags_url":"https://api.github.com/repos/antoine-de/navitia/tags","blobs_url":"https://api.github.com/repos/antoine-de/navitia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/antoine-de/navitia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/antoine-de/navitia/git/refs{/sha}","trees_url":"https://api.github.com/repos/antoine-de/navitia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/antoine-de/navitia/statuses/{sha}","languages_url":"https://api.github.com/repos/antoine-de/navitia/languages","stargazers_url":"https://api.github.com/repos/antoine-de/navitia/stargazers","contributors_url":"https://api.github.com/repos/antoine-de/navitia/contributors","subscribers_url":"https://api.github.com/repos/antoine-de/navitia/subscribers","subscription_url":"https://api.github.com/repos/antoine-de/navitia/subscription","commits_url":"https://api.github.com/repos/antoine-de/navitia/commits{/sha}","git_commits_url":"https://api.github.com/repos/antoine-de/navitia/git/commits{/sha}","comments_url":"https://api.github.com/repos/antoine-de/navitia/comments{/number}","issue_comment_url":"https://api.github.com/repos/antoine-de/navitia/issues/comments/{number}","contents_url":"https://api.github.com/repos/antoine-de/navitia/contents/{+path}","compare_url":"https://api.github.com/repos/antoine-de/navitia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/antoine-de/navitia/merges","archive_url":"https://api.github.com/repos/antoine-de/navitia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/antoine-de/navitia/downloads","issues_url":"https://api.github.com/repos/antoine-de/navitia/issues{/number}","pulls_url":"https://api.github.com/repos/antoine-de/navitia/pulls{/number}","milestones_url":"https://api.github.com/repos/antoine-de/navitia/milestones{/number}","notifications_url":"https://api.github.com/repos/antoine-de/navitia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/antoine-de/navitia/labels{/name}","releases_url":"https://api.github.com/repos/antoine-de/navitia/releases{/id}","created_at":"2014-04-25T12:12:04Z","updated_at":"2014-06-11T14:46:21Z","pushed_at":"2014-06-11T14:05:04Z","git_url":"git://github.com/antoine-de/navitia.git","ssh_url":"git@github.com:antoine-de/navitia.git","clone_url":"https://github.com/antoine-de/navitia.git","svn_url":"https://github.com/antoine-de/navitia","homepage":"http://www.navitia.io/","size":18510,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"CanalTP:release","ref":"release","sha":"6b040db44ff8a4bba221448b6d10f59029f70cc5","user":{"login":"CanalTP","id":2743985,"avatar_url":"https://avatars.githubusercontent.com/u/2743985?","gravatar_id":null,"url":"https://api.github.com/users/CanalTP","html_url":"https://github.com/CanalTP","followers_url":"https://api.github.com/users/CanalTP/followers","following_url":"https://api.github.com/users/CanalTP/following{/other_user}","gists_url":"https://api.github.com/users/CanalTP/gists{/gist_id}","starred_url":"https://api.github.com/users/CanalTP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CanalTP/subscriptions","organizations_url":"https://api.github.com/users/CanalTP/orgs","repos_url":"https://api.github.com/users/CanalTP/repos","events_url":"https://api.github.com/users/CanalTP/events{/privacy}","received_events_url":"https://api.github.com/users/CanalTP/received_events","type":"Organization","site_admin":false},"repo":{"id":10797333,"name":"navitia","full_name":"CanalTP/navitia","owner":{"login":"CanalTP","id":2743985,"avatar_url":"https://avatars.githubusercontent.com/u/2743985?","gravatar_id":null,"url":"https://api.github.com/users/CanalTP","html_url":"https://github.com/CanalTP","followers_url":"https://api.github.com/users/CanalTP/followers","following_url":"https://api.github.com/users/CanalTP/following{/other_user}","gists_url":"https://api.github.com/users/CanalTP/gists{/gist_id}","starred_url":"https://api.github.com/users/CanalTP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CanalTP/subscriptions","organizations_url":"https://api.github.com/users/CanalTP/orgs","repos_url":"https://api.github.com/users/CanalTP/repos","events_url":"https://api.github.com/users/CanalTP/events{/privacy}","received_events_url":"https://api.github.com/users/CanalTP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CanalTP/navitia","description":"The REST API to build cool stuff with public transport","fork":false,"url":"https://api.github.com/repos/CanalTP/navitia","forks_url":"https://api.github.com/repos/CanalTP/navitia/forks","keys_url":"https://api.github.com/repos/CanalTP/navitia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CanalTP/navitia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CanalTP/navitia/teams","hooks_url":"https://api.github.com/repos/CanalTP/navitia/hooks","issue_events_url":"https://api.github.com/repos/CanalTP/navitia/issues/events{/number}","events_url":"https://api.github.com/repos/CanalTP/navitia/events","assignees_url":"https://api.github.com/repos/CanalTP/navitia/assignees{/user}","branches_url":"https://api.github.com/repos/CanalTP/navitia/branches{/branch}","tags_url":"https://api.github.com/repos/CanalTP/navitia/tags","blobs_url":"https://api.github.com/repos/CanalTP/navitia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CanalTP/navitia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CanalTP/navitia/git/refs{/sha}","trees_url":"https://api.github.com/repos/CanalTP/navitia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CanalTP/navitia/statuses/{sha}","languages_url":"https://api.github.com/repos/CanalTP/navitia/languages","stargazers_url":"https://api.github.com/repos/CanalTP/navitia/stargazers","contributors_url":"https://api.github.com/repos/CanalTP/navitia/contributors","subscribers_url":"https://api.github.com/repos/CanalTP/navitia/subscribers","subscription_url":"https://api.github.com/repos/CanalTP/navitia/subscription","commits_url":"https://api.github.com/repos/CanalTP/navitia/commits{/sha}","git_commits_url":"https://api.github.com/repos/CanalTP/navitia/git/commits{/sha}","comments_url":"https://api.github.com/repos/CanalTP/navitia/comments{/number}","issue_comment_url":"https://api.github.com/repos/CanalTP/navitia/issues/comments/{number}","contents_url":"https://api.github.com/repos/CanalTP/navitia/contents/{+path}","compare_url":"https://api.github.com/repos/CanalTP/navitia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CanalTP/navitia/merges","archive_url":"https://api.github.com/repos/CanalTP/navitia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CanalTP/navitia/downloads","issues_url":"https://api.github.com/repos/CanalTP/navitia/issues{/number}","pulls_url":"https://api.github.com/repos/CanalTP/navitia/pulls{/number}","milestones_url":"https://api.github.com/repos/CanalTP/navitia/milestones{/number}","notifications_url":"https://api.github.com/repos/CanalTP/navitia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CanalTP/navitia/labels{/name}","releases_url":"https://api.github.com/repos/CanalTP/navitia/releases{/id}","created_at":"2013-06-19T15:34:30Z","updated_at":"2014-06-10T11:39:08Z","pushed_at":"2014-06-10T11:39:09Z","git_url":"git://github.com/CanalTP/navitia.git","ssh_url":"git@github.com:CanalTP/navitia.git","clone_url":"https://github.com/CanalTP/navitia.git","svn_url":"https://github.com/CanalTP/navitia","homepage":"http://www.navitia.io","size":29266,"stargazers_count":46,"watchers_count":46,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":12,"mirror_url":null,"open_issues_count":19,"forks":12,"open_issues":19,"watchers":46,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/389"},"html":{"href":"https://github.com/CanalTP/navitia/pull/389"},"issue":{"href":"https://api.github.com/repos/CanalTP/navitia/issues/389"},"comments":{"href":"https://api.github.com/repos/CanalTP/navitia/issues/389/comments"},"review_comments":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/389/comments"},"review_comment":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/389/commits"},"statuses":{"href":"https://api.github.com/repos/CanalTP/navitia/statuses/1b98c683495aac23c59f1e910d8fd257d2239347"}}}}