GitHub PushEvent at 2014-10-10 23:07:37
Repository: techlist
Actor: scharrier
Payload: {"shas":[["258a600149ad148607f5a47091b5b32de2cc2b30","ed691ae6b72821e5d9a18289cd970811ca651e46@gmail.com","Merge pull request #31 from mainelabs/upgrade-rspec3\n\nUpgrade to RSpec3","Sébastien Charrier",false],["4633e9368c55217bcba3cfb96de0bc40ea7cc765","d8932fd49bb05ff0670c3545d15547cb7baaf208@craftsmen.io","Fix silently failing specs\nTwo separate problems were hidden, despite a green suite:\n\n- RSpec config problem\n`geocoder_helper.rb` was breaking RSpec due to a bad configuration.\nIt made RSpec see feature specs examples as passing, while it ignores them completely.\nAfter fixing the configuration (`before` instead of `around` for clearing `FakeGeocoder`),\nfew specs became red, due to real problems with the code, or only missing stubs for geocoding requests.\n\n- Double \"geocoding service\" leak\nThis double was created in one example but leaks into another example.\nrspec-mocks' double doesn't allow that, so we needed to introduce `spec/support/geocoder_service.rb`\nthat sets back `Place.geocoder_service` to it's original value after using a double in an example.","Mehdi Lahmam",false],["5be80185dce1130db6bef213dc235143557c35cb","ed691ae6b72821e5d9a18289cd970811ca651e46@gmail.Com","Move map to Places#index","Sébastien Charrier",false],["16d93626571cc7716dcf764547010045ff8483b9","ed691ae6b72821e5d9a18289cd970811ca651e46@gmail.com","Merge pull request #34 from mainelabs/move-map\n\nMove map to Places#index","Sébastien Charrier",false],["d255c15629a1f394d02a6a72ab97a023e77a8e92","ed691ae6b72821e5d9a18289cd970811ca651e46@gmail.Com","A user can propose a new place","Sébastien Charrier",false],["a36d31f4ffd462983f013a57301ccc67d8136a0e","ed691ae6b72821e5d9a18289cd970811ca651e46@gmail.Com","Add styles for 'Add a place' form","Sébastien Charrier",false],["d45266004cbe4682d370dca0d2bc42ad2ff4e765","ed691ae6b72821e5d9a18289cd970811ca651e46@gmail.Com","Enhance form labels, microcopies and some fields","Sébastien Charrier",false],["433ad8b310918e33f00dabf7d5be0f66efed999c","ed691ae6b72821e5d9a18289cd970811ca651e46@gmail.Com","Add a link to Add a place","Sébastien Charrier",false],["c2316c6305484eba89da788f85c90b2cacdc4be6","ed691ae6b72821e5d9a18289cd970811ca651e46@gmail.Com","Add a back button to the Add form","Sébastien Charrier",false],["0d5ff00fda14303a962521b8e198d699695037f7","ed691ae6b72821e5d9a18289cd970811ca651e46@gmail.Com","Add specs for Place creation form","Sébastien Charrier",false],["00e8f92f89fd8d787810eec24bf52ebb0b783354","ed691ae6b72821e5d9a18289cd970811ca651e46@gmail.com","Merge pull request #35 from mainelabs/add-a-place-rails\n\nAdd a place","Sébastien Charrier",false],["484f1141e5a0641c666231c5f7df9bec241c2971","ed691ae6b72821e5d9a18289cd970811ca651e46@gmail.Com","Remove the create place api endpoint : needs more work to be useful","Sébastien Charrier",false],["558331619769ae2199770db6c76cd63d3255ac20","ed691ae6b72821e5d9a18289cd970811ca651e46@gmail.com","Merge pull request #36 from mainelabs/remove-api-create-place\n\nRemove the create place api endpoint : needs more work to be useful","Sébastien Charrier",false],["1ca9bf7348581a7c6acc4d86ddaadb98dde40d0d","ed691ae6b72821e5d9a18289cd970811ca651e46@gmail.Com","Add the good validation rules","Sébastien Charrier",false],["ecd19eab7e53ff2ce17abb90d403e1e6529976d4","ed691ae6b72821e5d9a18289cd970811ca651e46@gmail.com","Merge pull request #37 from mainelabs/place-validation-rules\n\nAdd the good validation rules","Sébastien Charrier",false],["aa0e7049bb3e25f060f0ef21b2e3e9985aa2c43a","ed691ae6b72821e5d9a18289cd970811ca651e46@gmail.Com","Create PlaceUpdate model","Sébastien Charrier",false],["256be36bc7316f8d92e63caa248d00f47d38494b","ed691ae6b72821e5d9a18289cd970811ca651e46@gmail.Com","Update aasm to last version","Sébastien Charrier",false],["91fafd0bd529a86993f8fc444bb9d2f236c81715","ed691ae6b72821e5d9a18289cd970811ca651e46@gmail.Com","Apply update to Place, via aasm","Sébastien Charrier",false],["874939c654127ecb7adc400c282735b6728e0c32","ed691ae6b72821e5d9a18289cd970811ca651e46@gmail.Com","Generate a PlaceUpdate from a Place","Sébastien Charrier",false],["d07ec4ebd80d914904165bd40ff64c519e207e13","ed691ae6b72821e5d9a18289cd970811ca651e46@gmail.Com","Extract place form into a partial","Sébastien Charrier",false]],"size":36,"ref":"refs/heads/bundle-update","head":"a20c57ed8c1dac55b70a7cc919d17ca9c7349c24"}