GitHub PullRequestReviewCommentEvent at 2014-10-31 12:48:03
Repository: django-pgcrypto-fields
Actor: Ian-Foote
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/pulls/comments/19664567","id":19664567,"diff_hunk":"@@ -2,29 +2,6 @@\n from django.db import models\n \n \n-class DecryptFunctionSQL(models.sql.aggregates.Aggregate):\n-    \"\"\"Custom SQL aggregate to decrypt a field.\n-\n-    `DecryptFunctionSQL` provides a SQL template using pgcrypto to decrypt\n-    data from a field in the database.\n-\n-    `sql_function` defines `pgp_pub_decrypt` which is a pgcrypto SQL function.\n-    This function takes two arguments:\n-      - a encrypted message (bytea);\n-      - a key (bytea).\n-\n-    `%(function)s` in `sql_template` is populated by `sql_function`.\n-\n-    `%(field)s` is replaced with the field's name.\n-\n-    `dearmor` is used to unwrap the key from the PGP key.\n-    \"\"\"\n-    sql_function = 'pgp_pub_decrypt'\n-    sql_template = \"%(function)s(%(field)s, dearmor('{}'))\".format(\n-        settings.PRIVATE_PGP_KEY,\n-    )\n-\n-\n class Decrypt(models.Aggregate):","path":"pgcrypto_fields/aggregates.py","position":27,"original_position":27,"commit_id":"d8087d1c49c860a144b4ce03642f26504068dafe","original_commit_id":"d8087d1c49c860a144b4ce03642f26504068dafe","user":{"login":"Ian-Foote","id":1843202,"avatar_url":"https://avatars.githubusercontent.com/u/1843202?v=2","gravatar_id":"","url":"https://api.github.com/users/Ian-Foote","html_url":"https://github.com/Ian-Foote","followers_url":"https://api.github.com/users/Ian-Foote/followers","following_url":"https://api.github.com/users/Ian-Foote/following{/other_user}","gists_url":"https://api.github.com/users/Ian-Foote/gists{/gist_id}","starred_url":"https://api.github.com/users/Ian-Foote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ian-Foote/subscriptions","organizations_url":"https://api.github.com/users/Ian-Foote/orgs","repos_url":"https://api.github.com/users/Ian-Foote/repos","events_url":"https://api.github.com/users/Ian-Foote/events{/privacy}","received_events_url":"https://api.github.com/users/Ian-Foote/received_events","type":"User","site_admin":false},"body":"I'm not sure this is the best name for this class. Maybe `DecryptionBase`?","created_at":"2014-10-31T12:48:03Z","updated_at":"2014-10-31T12:48:03Z","html_url":"https://github.com/incuna/django-pgcrypto-fields/pull/7#discussion_r19664567","pull_request_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/incuna/django-pgcrypto-fields/pulls/comments/19664567"},"html":{"href":"https://github.com/incuna/django-pgcrypto-fields/pull/7#discussion_r19664567"},"pull_request":{"href":"https://api.github.com/repos/incuna/django-pgcrypto-fields/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/pulls/7","id":23543594,"html_url":"https://github.com/incuna/django-pgcrypto-fields/pull/7","diff_url":"https://github.com/incuna/django-pgcrypto-fields/pull/7.diff","patch_url":"https://github.com/incuna/django-pgcrypto-fields/pull/7.patch","issue_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/issues/7","number":7,"state":"open","locked":false,"title":"Add other cryptographic funtions from pgcrypto","user":{"login":"KevinEtienne","id":22735,"avatar_url":"https://avatars.githubusercontent.com/u/22735?v=2","gravatar_id":"","url":"https://api.github.com/users/KevinEtienne","html_url":"https://github.com/KevinEtienne","followers_url":"https://api.github.com/users/KevinEtienne/followers","following_url":"https://api.github.com/users/KevinEtienne/following{/other_user}","gists_url":"https://api.github.com/users/KevinEtienne/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinEtienne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinEtienne/subscriptions","organizations_url":"https://api.github.com/users/KevinEtienne/orgs","repos_url":"https://api.github.com/users/KevinEtienne/repos","events_url":"https://api.github.com/users/KevinEtienne/events{/privacy}","received_events_url":"https://api.github.com/users/KevinEtienne/received_events","type":"User","site_admin":false},"body":"see http://www.postgresql.org/docs/9.3/static/pgcrypto.html","created_at":"2014-10-29T16:24:41Z","updated_at":"2014-10-31T12:48:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"50b57002abce37c77b5f8ee251ae31ec91c84d05","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/pulls/7/commits","review_comments_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/pulls/7/comments","review_comment_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/pulls/comments/{number}","comments_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/issues/7/comments","statuses_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/statuses/d8087d1c49c860a144b4ce03642f26504068dafe","head":{"label":"incuna:add-other-encryptions","ref":"add-other-encryptions","sha":"d8087d1c49c860a144b4ce03642f26504068dafe","user":{"login":"incuna","id":55510,"avatar_url":"https://avatars.githubusercontent.com/u/55510?v=2","gravatar_id":"","url":"https://api.github.com/users/incuna","html_url":"https://github.com/incuna","followers_url":"https://api.github.com/users/incuna/followers","following_url":"https://api.github.com/users/incuna/following{/other_user}","gists_url":"https://api.github.com/users/incuna/gists{/gist_id}","starred_url":"https://api.github.com/users/incuna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/incuna/subscriptions","organizations_url":"https://api.github.com/users/incuna/orgs","repos_url":"https://api.github.com/users/incuna/repos","events_url":"https://api.github.com/users/incuna/events{/privacy}","received_events_url":"https://api.github.com/users/incuna/received_events","type":"Organization","site_admin":false},"repo":{"id":25590252,"name":"django-pgcrypto-fields","full_name":"incuna/django-pgcrypto-fields","owner":{"login":"incuna","id":55510,"avatar_url":"https://avatars.githubusercontent.com/u/55510?v=2","gravatar_id":"","url":"https://api.github.com/users/incuna","html_url":"https://github.com/incuna","followers_url":"https://api.github.com/users/incuna/followers","following_url":"https://api.github.com/users/incuna/following{/other_user}","gists_url":"https://api.github.com/users/incuna/gists{/gist_id}","starred_url":"https://api.github.com/users/incuna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/incuna/subscriptions","organizations_url":"https://api.github.com/users/incuna/orgs","repos_url":"https://api.github.com/users/incuna/repos","events_url":"https://api.github.com/users/incuna/events{/privacy}","received_events_url":"https://api.github.com/users/incuna/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/incuna/django-pgcrypto-fields","description":"Encrypted fields dealing with pgcrypto postgres extension.","fork":false,"url":"https://api.github.com/repos/incuna/django-pgcrypto-fields","forks_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/forks","keys_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/keys{/key_id}","collaborators_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/teams","hooks_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/hooks","issue_events_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/issues/events{/number}","events_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/events","assignees_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/assignees{/user}","branches_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/branches{/branch}","tags_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/tags","blobs_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/git/refs{/sha}","trees_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/git/trees{/sha}","statuses_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/statuses/{sha}","languages_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/languages","stargazers_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/stargazers","contributors_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/contributors","subscribers_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/subscribers","subscription_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/subscription","commits_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/commits{/sha}","git_commits_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/git/commits{/sha}","comments_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/comments{/number}","issue_comment_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/issues/comments/{number}","contents_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/contents/{+path}","compare_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/compare/{base}...{head}","merges_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/merges","archive_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/downloads","issues_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/issues{/number}","pulls_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/pulls{/number}","milestones_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/milestones{/number}","notifications_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/labels{/name}","releases_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/releases{/id}","created_at":"2014-10-22T15:51:55Z","updated_at":"2014-10-23T09:00:07Z","pushed_at":"2014-10-31T12:09:10Z","git_url":"git://github.com/incuna/django-pgcrypto-fields.git","ssh_url":"git@github.com:incuna/django-pgcrypto-fields.git","clone_url":"https://github.com/incuna/django-pgcrypto-fields.git","svn_url":"https://github.com/incuna/django-pgcrypto-fields","homepage":null,"size":516,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"incuna:master","ref":"master","sha":"63b14e192dac3a91fbd21c546914fd3ee856f5da","user":{"login":"incuna","id":55510,"avatar_url":"https://avatars.githubusercontent.com/u/55510?v=2","gravatar_id":"","url":"https://api.github.com/users/incuna","html_url":"https://github.com/incuna","followers_url":"https://api.github.com/users/incuna/followers","following_url":"https://api.github.com/users/incuna/following{/other_user}","gists_url":"https://api.github.com/users/incuna/gists{/gist_id}","starred_url":"https://api.github.com/users/incuna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/incuna/subscriptions","organizations_url":"https://api.github.com/users/incuna/orgs","repos_url":"https://api.github.com/users/incuna/repos","events_url":"https://api.github.com/users/incuna/events{/privacy}","received_events_url":"https://api.github.com/users/incuna/received_events","type":"Organization","site_admin":false},"repo":{"id":25590252,"name":"django-pgcrypto-fields","full_name":"incuna/django-pgcrypto-fields","owner":{"login":"incuna","id":55510,"avatar_url":"https://avatars.githubusercontent.com/u/55510?v=2","gravatar_id":"","url":"https://api.github.com/users/incuna","html_url":"https://github.com/incuna","followers_url":"https://api.github.com/users/incuna/followers","following_url":"https://api.github.com/users/incuna/following{/other_user}","gists_url":"https://api.github.com/users/incuna/gists{/gist_id}","starred_url":"https://api.github.com/users/incuna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/incuna/subscriptions","organizations_url":"https://api.github.com/users/incuna/orgs","repos_url":"https://api.github.com/users/incuna/repos","events_url":"https://api.github.com/users/incuna/events{/privacy}","received_events_url":"https://api.github.com/users/incuna/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/incuna/django-pgcrypto-fields","description":"Encrypted fields dealing with pgcrypto postgres extension.","fork":false,"url":"https://api.github.com/repos/incuna/django-pgcrypto-fields","forks_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/forks","keys_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/keys{/key_id}","collaborators_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/teams","hooks_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/hooks","issue_events_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/issues/events{/number}","events_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/events","assignees_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/assignees{/user}","branches_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/branches{/branch}","tags_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/tags","blobs_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/git/refs{/sha}","trees_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/git/trees{/sha}","statuses_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/statuses/{sha}","languages_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/languages","stargazers_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/stargazers","contributors_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/contributors","subscribers_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/subscribers","subscription_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/subscription","commits_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/commits{/sha}","git_commits_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/git/commits{/sha}","comments_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/comments{/number}","issue_comment_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/issues/comments/{number}","contents_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/contents/{+path}","compare_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/compare/{base}...{head}","merges_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/merges","archive_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/downloads","issues_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/issues{/number}","pulls_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/pulls{/number}","milestones_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/milestones{/number}","notifications_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/labels{/name}","releases_url":"https://api.github.com/repos/incuna/django-pgcrypto-fields/releases{/id}","created_at":"2014-10-22T15:51:55Z","updated_at":"2014-10-23T09:00:07Z","pushed_at":"2014-10-31T12:09:10Z","git_url":"git://github.com/incuna/django-pgcrypto-fields.git","ssh_url":"git@github.com:incuna/django-pgcrypto-fields.git","clone_url":"https://github.com/incuna/django-pgcrypto-fields.git","svn_url":"https://github.com/incuna/django-pgcrypto-fields","homepage":null,"size":516,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/incuna/django-pgcrypto-fields/pulls/7"},"html":{"href":"https://github.com/incuna/django-pgcrypto-fields/pull/7"},"issue":{"href":"https://api.github.com/repos/incuna/django-pgcrypto-fields/issues/7"},"comments":{"href":"https://api.github.com/repos/incuna/django-pgcrypto-fields/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/incuna/django-pgcrypto-fields/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/incuna/django-pgcrypto-fields/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/incuna/django-pgcrypto-fields/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/incuna/django-pgcrypto-fields/statuses/d8087d1c49c860a144b4ce03642f26504068dafe"}}}}