GitHub PullRequestReviewCommentEvent at 2014-12-16 21:47:30
Repository: influxdb
Actor: benbjohnson
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/influxdb/influxdb/pulls/comments/21934730","id":21934730,"diff_hunk":"@@ -51,6 +55,25 @@ func execCreateCluster(args []string) {\n \t\tif err := os.MkdirAll(config.Storage.Dir, 0744); err != nil {\n \t\t\tlog.Fatal(err)\n \t\t}\n+\n+\t\t// Configure the Messaging Client such that this node connects to itself.\n+\t\tvar urls []*url.URL\n+\t\tu, err := url.Parse(\"127.0.0.1:8080\")\n+\t\tif err != nil {\n+\t\t\tlog.Fatal(\"failed to create Messaging Client configuration\")\n+\t\t}\n+\t\turls = append(urls, u)\n+\n+\t\tb, err := json.Marshal(urls)\n+\t\tif err != nil {\n+\t\t\tlog.Fatal(\"failed to create JSON form of Messaging Client configuration\")\n+\t\t}\n+\n+\t\terr = ioutil.WriteFile(filepath.Join(config.Storage.Dir, messagingClientFile), b, 0644)\n+\t\tif err != nil {\n+\t\t\tlog.Fatal(\"failed to write Messaging Client configuration\")\n+\t\t}\n+\n \t}","path":"cmd/influxd/create_cluster.go","position":37,"original_position":37,"commit_id":"3bdfb39fc126fa40313159dbfb9a68add0e60387","original_commit_id":"3bdfb39fc126fa40313159dbfb9a68add0e60387","user":{"login":"benbjohnson","id":118015,"avatar_url":"https://avatars.githubusercontent.com/u/118015?v=3","gravatar_id":"","url":"https://api.github.com/users/benbjohnson","html_url":"https://github.com/benbjohnson","followers_url":"https://api.github.com/users/benbjohnson/followers","following_url":"https://api.github.com/users/benbjohnson/following{/other_user}","gists_url":"https://api.github.com/users/benbjohnson/gists{/gist_id}","starred_url":"https://api.github.com/users/benbjohnson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benbjohnson/subscriptions","organizations_url":"https://api.github.com/users/benbjohnson/orgs","repos_url":"https://api.github.com/users/benbjohnson/repos","events_url":"https://api.github.com/users/benbjohnson/events{/privacy}","received_events_url":"https://api.github.com/users/benbjohnson/received_events","type":"User","site_admin":false},"body":"It might be a good idea to create a `messaging.Client` that connects to the new broker so the client messaging file always gets written the same way.","created_at":"2014-12-16T21:47:30Z","updated_at":"2014-12-16T21:47:30Z","html_url":"https://github.com/influxdb/influxdb/pull/1240#discussion_r21934730","pull_request_url":"https://api.github.com/repos/influxdb/influxdb/pulls/1240","_links":{"self":{"href":"https://api.github.com/repos/influxdb/influxdb/pulls/comments/21934730"},"html":{"href":"https://github.com/influxdb/influxdb/pull/1240#discussion_r21934730"},"pull_request":{"href":"https://api.github.com/repos/influxdb/influxdb/pulls/1240"}}},"pull_request":{"url":"https://api.github.com/repos/influxdb/influxdb/pulls/1240","id":26180957,"html_url":"https://github.com/influxdb/influxdb/pull/1240","diff_url":"https://github.com/influxdb/influxdb/pull/1240.diff","patch_url":"https://github.com/influxdb/influxdb/pull/1240.patch","issue_url":"https://api.github.com/repos/influxdb/influxdb/issues/1240","number":1240,"state":"open","locked":false,"title":"Store Messaging Client config in file","user":{"login":"otoolep","id":536312,"avatar_url":"https://avatars.githubusercontent.com/u/536312?v=3","gravatar_id":"","url":"https://api.github.com/users/otoolep","html_url":"https://github.com/otoolep","followers_url":"https://api.github.com/users/otoolep/followers","following_url":"https://api.github.com/users/otoolep/following{/other_user}","gists_url":"https://api.github.com/users/otoolep/gists{/gist_id}","starred_url":"https://api.github.com/users/otoolep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otoolep/subscriptions","organizations_url":"https://api.github.com/users/otoolep/orgs","repos_url":"https://api.github.com/users/otoolep/repos","events_url":"https://api.github.com/users/otoolep/events{/privacy}","received_events_url":"https://api.github.com/users/otoolep/received_events","type":"User","site_admin":false},"body":"The presence of this file is also used to determine if a node should run\r\nin local client mode, or should contact a Broker.","created_at":"2014-12-16T21:25:35Z","updated_at":"2014-12-16T21:47:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b26b9a878fe3e27d48a650037c10446ea2ee80d6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/influxdb/influxdb/pulls/1240/commits","review_comments_url":"https://api.github.com/repos/influxdb/influxdb/pulls/1240/comments","review_comment_url":"https://api.github.com/repos/influxdb/influxdb/pulls/comments/{number}","comments_url":"https://api.github.com/repos/influxdb/influxdb/issues/1240/comments","statuses_url":"https://api.github.com/repos/influxdb/influxdb/statuses/3bdfb39fc126fa40313159dbfb9a68add0e60387","head":{"label":"otoolep:client_config_file","ref":"client_config_file","sha":"3bdfb39fc126fa40313159dbfb9a68add0e60387","user":{"login":"otoolep","id":536312,"avatar_url":"https://avatars.githubusercontent.com/u/536312?v=3","gravatar_id":"","url":"https://api.github.com/users/otoolep","html_url":"https://github.com/otoolep","followers_url":"https://api.github.com/users/otoolep/followers","following_url":"https://api.github.com/users/otoolep/following{/other_user}","gists_url":"https://api.github.com/users/otoolep/gists{/gist_id}","starred_url":"https://api.github.com/users/otoolep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otoolep/subscriptions","organizations_url":"https://api.github.com/users/otoolep/orgs","repos_url":"https://api.github.com/users/otoolep/repos","events_url":"https://api.github.com/users/otoolep/events{/privacy}","received_events_url":"https://api.github.com/users/otoolep/received_events","type":"User","site_admin":false},"repo":{"id":18443414,"name":"influxdb","full_name":"otoolep/influxdb","owner":{"login":"otoolep","id":536312,"avatar_url":"https://avatars.githubusercontent.com/u/536312?v=3","gravatar_id":"","url":"https://api.github.com/users/otoolep","html_url":"https://github.com/otoolep","followers_url":"https://api.github.com/users/otoolep/followers","following_url":"https://api.github.com/users/otoolep/following{/other_user}","gists_url":"https://api.github.com/users/otoolep/gists{/gist_id}","starred_url":"https://api.github.com/users/otoolep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otoolep/subscriptions","organizations_url":"https://api.github.com/users/otoolep/orgs","repos_url":"https://api.github.com/users/otoolep/repos","events_url":"https://api.github.com/users/otoolep/events{/privacy}","received_events_url":"https://api.github.com/users/otoolep/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/otoolep/influxdb","description":"Scalable datastore for metrics, events, and real-time analytics","fork":true,"url":"https://api.github.com/repos/otoolep/influxdb","forks_url":"https://api.github.com/repos/otoolep/influxdb/forks","keys_url":"https://api.github.com/repos/otoolep/influxdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/otoolep/influxdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/otoolep/influxdb/teams","hooks_url":"https://api.github.com/repos/otoolep/influxdb/hooks","issue_events_url":"https://api.github.com/repos/otoolep/influxdb/issues/events{/number}","events_url":"https://api.github.com/repos/otoolep/influxdb/events","assignees_url":"https://api.github.com/repos/otoolep/influxdb/assignees{/user}","branches_url":"https://api.github.com/repos/otoolep/influxdb/branches{/branch}","tags_url":"https://api.github.com/repos/otoolep/influxdb/tags","blobs_url":"https://api.github.com/repos/otoolep/influxdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/otoolep/influxdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/otoolep/influxdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/otoolep/influxdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/otoolep/influxdb/statuses/{sha}","languages_url":"https://api.github.com/repos/otoolep/influxdb/languages","stargazers_url":"https://api.github.com/repos/otoolep/influxdb/stargazers","contributors_url":"https://api.github.com/repos/otoolep/influxdb/contributors","subscribers_url":"https://api.github.com/repos/otoolep/influxdb/subscribers","subscription_url":"https://api.github.com/repos/otoolep/influxdb/subscription","commits_url":"https://api.github.com/repos/otoolep/influxdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/otoolep/influxdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/otoolep/influxdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/otoolep/influxdb/issues/comments/{number}","contents_url":"https://api.github.com/repos/otoolep/influxdb/contents/{+path}","compare_url":"https://api.github.com/repos/otoolep/influxdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/otoolep/influxdb/merges","archive_url":"https://api.github.com/repos/otoolep/influxdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/otoolep/influxdb/downloads","issues_url":"https://api.github.com/repos/otoolep/influxdb/issues{/number}","pulls_url":"https://api.github.com/repos/otoolep/influxdb/pulls{/number}","milestones_url":"https://api.github.com/repos/otoolep/influxdb/milestones{/number}","notifications_url":"https://api.github.com/repos/otoolep/influxdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/otoolep/influxdb/labels{/name}","releases_url":"https://api.github.com/repos/otoolep/influxdb/releases{/id}","created_at":"2014-04-04T15:30:51Z","updated_at":"2014-11-18T23:25:45Z","pushed_at":"2014-12-16T21:26:31Z","git_url":"git://github.com/otoolep/influxdb.git","ssh_url":"git@github.com:otoolep/influxdb.git","clone_url":"https://github.com/otoolep/influxdb.git","svn_url":"https://github.com/otoolep/influxdb","homepage":"http://influxdb.org","size":8323,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"influxdb:master","ref":"master","sha":"badc9e5e835986adc3857c491bc3084ae3e16698","user":{"login":"influxdb","id":5713248,"avatar_url":"https://avatars.githubusercontent.com/u/5713248?v=3","gravatar_id":"","url":"https://api.github.com/users/influxdb","html_url":"https://github.com/influxdb","followers_url":"https://api.github.com/users/influxdb/followers","following_url":"https://api.github.com/users/influxdb/following{/other_user}","gists_url":"https://api.github.com/users/influxdb/gists{/gist_id}","starred_url":"https://api.github.com/users/influxdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/influxdb/subscriptions","organizations_url":"https://api.github.com/users/influxdb/orgs","repos_url":"https://api.github.com/users/influxdb/repos","events_url":"https://api.github.com/users/influxdb/events{/privacy}","received_events_url":"https://api.github.com/users/influxdb/received_events","type":"Organization","site_admin":false},"repo":{"id":13124802,"name":"influxdb","full_name":"influxdb/influxdb","owner":{"login":"influxdb","id":5713248,"avatar_url":"https://avatars.githubusercontent.com/u/5713248?v=3","gravatar_id":"","url":"https://api.github.com/users/influxdb","html_url":"https://github.com/influxdb","followers_url":"https://api.github.com/users/influxdb/followers","following_url":"https://api.github.com/users/influxdb/following{/other_user}","gists_url":"https://api.github.com/users/influxdb/gists{/gist_id}","starred_url":"https://api.github.com/users/influxdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/influxdb/subscriptions","organizations_url":"https://api.github.com/users/influxdb/orgs","repos_url":"https://api.github.com/users/influxdb/repos","events_url":"https://api.github.com/users/influxdb/events{/privacy}","received_events_url":"https://api.github.com/users/influxdb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/influxdb/influxdb","description":"Scalable datastore for metrics, events, and real-time analytics","fork":false,"url":"https://api.github.com/repos/influxdb/influxdb","forks_url":"https://api.github.com/repos/influxdb/influxdb/forks","keys_url":"https://api.github.com/repos/influxdb/influxdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/influxdb/influxdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/influxdb/influxdb/teams","hooks_url":"https://api.github.com/repos/influxdb/influxdb/hooks","issue_events_url":"https://api.github.com/repos/influxdb/influxdb/issues/events{/number}","events_url":"https://api.github.com/repos/influxdb/influxdb/events","assignees_url":"https://api.github.com/repos/influxdb/influxdb/assignees{/user}","branches_url":"https://api.github.com/repos/influxdb/influxdb/branches{/branch}","tags_url":"https://api.github.com/repos/influxdb/influxdb/tags","blobs_url":"https://api.github.com/repos/influxdb/influxdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/influxdb/influxdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/influxdb/influxdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/influxdb/influxdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/influxdb/influxdb/statuses/{sha}","languages_url":"https://api.github.com/repos/influxdb/influxdb/languages","stargazers_url":"https://api.github.com/repos/influxdb/influxdb/stargazers","contributors_url":"https://api.github.com/repos/influxdb/influxdb/contributors","subscribers_url":"https://api.github.com/repos/influxdb/influxdb/subscribers","subscription_url":"https://api.github.com/repos/influxdb/influxdb/subscription","commits_url":"https://api.github.com/repos/influxdb/influxdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/influxdb/influxdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/influxdb/influxdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/influxdb/influxdb/issues/comments/{number}","contents_url":"https://api.github.com/repos/influxdb/influxdb/contents/{+path}","compare_url":"https://api.github.com/repos/influxdb/influxdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/influxdb/influxdb/merges","archive_url":"https://api.github.com/repos/influxdb/influxdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/influxdb/influxdb/downloads","issues_url":"https://api.github.com/repos/influxdb/influxdb/issues{/number}","pulls_url":"https://api.github.com/repos/influxdb/influxdb/pulls{/number}","milestones_url":"https://api.github.com/repos/influxdb/influxdb/milestones{/number}","notifications_url":"https://api.github.com/repos/influxdb/influxdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/influxdb/influxdb/labels{/name}","releases_url":"https://api.github.com/repos/influxdb/influxdb/releases{/id}","created_at":"2013-09-26T14:31:10Z","updated_at":"2014-12-16T20:35:36Z","pushed_at":"2014-12-16T18:45:10Z","git_url":"git://github.com/influxdb/influxdb.git","ssh_url":"git@github.com:influxdb/influxdb.git","clone_url":"https://github.com/influxdb/influxdb.git","svn_url":"https://github.com/influxdb/influxdb","homepage":"http://influxdb.com","size":16909,"stargazers_count":3892,"watchers_count":3892,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":298,"mirror_url":null,"open_issues_count":220,"forks":298,"open_issues":220,"watchers":3892,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/influxdb/influxdb/pulls/1240"},"html":{"href":"https://github.com/influxdb/influxdb/pull/1240"},"issue":{"href":"https://api.github.com/repos/influxdb/influxdb/issues/1240"},"comments":{"href":"https://api.github.com/repos/influxdb/influxdb/issues/1240/comments"},"review_comments":{"href":"https://api.github.com/repos/influxdb/influxdb/pulls/1240/comments"},"review_comment":{"href":"https://api.github.com/repos/influxdb/influxdb/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/influxdb/influxdb/pulls/1240/commits"},"statuses":{"href":"https://api.github.com/repos/influxdb/influxdb/statuses/3bdfb39fc126fa40313159dbfb9a68add0e60387"}}}}