GitHub PullRequestReviewCommentEvent at 2014-06-14 16:49:10
Repository: MCServer
Actor: madmaxoft
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mc-server/MCServer/pulls/comments/13781842","id":13781842,"diff_hunk":"@@ -27,11 +27,12 @@ template <typename T> inline bool IsAllValue(const T * a_Array, size_t a_NumElem\n \n \n \n-cChunkData::cChunkData(void)\n+cChunkData::cChunkData(cAllocationPool<cChunkData::sChunkSection, 1600>& a_Pool) :\n #if __cplusplus < 201103L\n \t// auto_ptr style interface for memory management\n-\t: m_IsOwner(true)\n+\tm_IsOwner(true)","path":"src/ChunkData.cpp","position":9,"original_position":9,"commit_id":"061102c77860e7a31b7504ca52bb99e419393fb2","original_commit_id":"061102c77860e7a31b7504ca52bb99e419393fb2","user":{"login":"madmaxoft","id":4388386,"avatar_url":"https://avatars.githubusercontent.com/u/4388386?","gravatar_id":"c43b1605321176ee0ee18b359bb1fae4","url":"https://api.github.com/users/madmaxoft","html_url":"https://github.com/madmaxoft","followers_url":"https://api.github.com/users/madmaxoft/followers","following_url":"https://api.github.com/users/madmaxoft/following{/other_user}","gists_url":"https://api.github.com/users/madmaxoft/gists{/gist_id}","starred_url":"https://api.github.com/users/madmaxoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madmaxoft/subscriptions","organizations_url":"https://api.github.com/users/madmaxoft/orgs","repos_url":"https://api.github.com/users/madmaxoft/repos","events_url":"https://api.github.com/users/madmaxoft/events{/privacy}","received_events_url":"https://api.github.com/users/madmaxoft/received_events","type":"User","site_admin":false},"body":"Comma missing here","created_at":"2014-06-14T16:49:10Z","updated_at":"2014-06-14T16:49:10Z","html_url":"https://github.com/mc-server/MCServer/pull/1024#discussion_r13781842","pull_request_url":"https://api.github.com/repos/mc-server/MCServer/pulls/1024","_links":{"self":{"href":"https://api.github.com/repos/mc-server/MCServer/pulls/comments/13781842"},"html":{"href":"https://github.com/mc-server/MCServer/pull/1024#discussion_r13781842"},"pull_request":{"href":"https://api.github.com/repos/mc-server/MCServer/pulls/1024"}}},"pull_request":{"url":"https://api.github.com/repos/mc-server/MCServer/pulls/1024","id":16282525,"html_url":"https://github.com/mc-server/MCServer/pull/1024","diff_url":"https://github.com/mc-server/MCServer/pull/1024.diff","patch_url":"https://github.com/mc-server/MCServer/pull/1024.patch","issue_url":"https://api.github.com/repos/mc-server/MCServer/issues/1024","number":1024,"state":"open","title":"First attempt at implementing an Allocation pool","user":{"login":"worktycho","id":2102806,"avatar_url":"https://avatars.githubusercontent.com/u/2102806?","gravatar_id":"b97a3ec92aed1c16e35c1bf532465d6b","url":"https://api.github.com/users/worktycho","html_url":"https://github.com/worktycho","followers_url":"https://api.github.com/users/worktycho/followers","following_url":"https://api.github.com/users/worktycho/following{/other_user}","gists_url":"https://api.github.com/users/worktycho/gists{/gist_id}","starred_url":"https://api.github.com/users/worktycho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/worktycho/subscriptions","organizations_url":"https://api.github.com/users/worktycho/orgs","repos_url":"https://api.github.com/users/worktycho/repos","events_url":"https://api.github.com/users/worktycho/events{/privacy}","received_events_url":"https://api.github.com/users/worktycho/received_events","type":"User","site_admin":false},"body":"Now we just need to work out what to do in the three callbacks\r\ndepends on #951","created_at":"2014-05-23T16:29:57Z","updated_at":"2014-06-14T16:49:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"45657252cd9a6aa96705389b5d298da6c4ebde25","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mc-server/MCServer/pulls/1024/commits","review_comments_url":"https://api.github.com/repos/mc-server/MCServer/pulls/1024/comments","review_comment_url":"https://api.github.com/repos/mc-server/MCServer/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mc-server/MCServer/issues/1024/comments","statuses_url":"https://api.github.com/repos/mc-server/MCServer/statuses/061102c77860e7a31b7504ca52bb99e419393fb2","head":{"label":"worktycho:AllocationPool","ref":"AllocationPool","sha":"061102c77860e7a31b7504ca52bb99e419393fb2","user":{"login":"worktycho","id":2102806,"avatar_url":"https://avatars.githubusercontent.com/u/2102806?","gravatar_id":"b97a3ec92aed1c16e35c1bf532465d6b","url":"https://api.github.com/users/worktycho","html_url":"https://github.com/worktycho","followers_url":"https://api.github.com/users/worktycho/followers","following_url":"https://api.github.com/users/worktycho/following{/other_user}","gists_url":"https://api.github.com/users/worktycho/gists{/gist_id}","starred_url":"https://api.github.com/users/worktycho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/worktycho/subscriptions","organizations_url":"https://api.github.com/users/worktycho/orgs","repos_url":"https://api.github.com/users/worktycho/repos","events_url":"https://api.github.com/users/worktycho/events{/privacy}","received_events_url":"https://api.github.com/users/worktycho/received_events","type":"User","site_admin":false},"repo":{"id":12731841,"name":"MCServer","full_name":"worktycho/MCServer","owner":{"login":"worktycho","id":2102806,"avatar_url":"https://avatars.githubusercontent.com/u/2102806?","gravatar_id":"b97a3ec92aed1c16e35c1bf532465d6b","url":"https://api.github.com/users/worktycho","html_url":"https://github.com/worktycho","followers_url":"https://api.github.com/users/worktycho/followers","following_url":"https://api.github.com/users/worktycho/following{/other_user}","gists_url":"https://api.github.com/users/worktycho/gists{/gist_id}","starred_url":"https://api.github.com/users/worktycho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/worktycho/subscriptions","organizations_url":"https://api.github.com/users/worktycho/orgs","repos_url":"https://api.github.com/users/worktycho/repos","events_url":"https://api.github.com/users/worktycho/events{/privacy}","received_events_url":"https://api.github.com/users/worktycho/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/worktycho/MCServer","description":"A performant C++ Minecraft Server","fork":true,"url":"https://api.github.com/repos/worktycho/MCServer","forks_url":"https://api.github.com/repos/worktycho/MCServer/forks","keys_url":"https://api.github.com/repos/worktycho/MCServer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/worktycho/MCServer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/worktycho/MCServer/teams","hooks_url":"https://api.github.com/repos/worktycho/MCServer/hooks","issue_events_url":"https://api.github.com/repos/worktycho/MCServer/issues/events{/number}","events_url":"https://api.github.com/repos/worktycho/MCServer/events","assignees_url":"https://api.github.com/repos/worktycho/MCServer/assignees{/user}","branches_url":"https://api.github.com/repos/worktycho/MCServer/branches{/branch}","tags_url":"https://api.github.com/repos/worktycho/MCServer/tags","blobs_url":"https://api.github.com/repos/worktycho/MCServer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/worktycho/MCServer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/worktycho/MCServer/git/refs{/sha}","trees_url":"https://api.github.com/repos/worktycho/MCServer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/worktycho/MCServer/statuses/{sha}","languages_url":"https://api.github.com/repos/worktycho/MCServer/languages","stargazers_url":"https://api.github.com/repos/worktycho/MCServer/stargazers","contributors_url":"https://api.github.com/repos/worktycho/MCServer/contributors","subscribers_url":"https://api.github.com/repos/worktycho/MCServer/subscribers","subscription_url":"https://api.github.com/repos/worktycho/MCServer/subscription","commits_url":"https://api.github.com/repos/worktycho/MCServer/commits{/sha}","git_commits_url":"https://api.github.com/repos/worktycho/MCServer/git/commits{/sha}","comments_url":"https://api.github.com/repos/worktycho/MCServer/comments{/number}","issue_comment_url":"https://api.github.com/repos/worktycho/MCServer/issues/comments/{number}","contents_url":"https://api.github.com/repos/worktycho/MCServer/contents/{+path}","compare_url":"https://api.github.com/repos/worktycho/MCServer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/worktycho/MCServer/merges","archive_url":"https://api.github.com/repos/worktycho/MCServer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/worktycho/MCServer/downloads","issues_url":"https://api.github.com/repos/worktycho/MCServer/issues{/number}","pulls_url":"https://api.github.com/repos/worktycho/MCServer/pulls{/number}","milestones_url":"https://api.github.com/repos/worktycho/MCServer/milestones{/number}","notifications_url":"https://api.github.com/repos/worktycho/MCServer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/worktycho/MCServer/labels{/name}","releases_url":"https://api.github.com/repos/worktycho/MCServer/releases{/id}","created_at":"2013-09-10T14:30:22Z","updated_at":"2014-06-14T16:24:09Z","pushed_at":"2014-06-14T16:24:08Z","git_url":"git://github.com/worktycho/MCServer.git","ssh_url":"git@github.com:worktycho/MCServer.git","clone_url":"https://github.com/worktycho/MCServer.git","svn_url":"https://github.com/worktycho/MCServer","homepage":"mc-server.org","size":65138,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mc-server:master","ref":"master","sha":"c0bc4a9d3a82e987ff553e07e3a127744b02819d","user":{"login":"mc-server","id":5096476,"avatar_url":"https://avatars.githubusercontent.com/u/5096476?","gravatar_id":"24d22348a9a88243556209a78e4ac2f5","url":"https://api.github.com/users/mc-server","html_url":"https://github.com/mc-server","followers_url":"https://api.github.com/users/mc-server/followers","following_url":"https://api.github.com/users/mc-server/following{/other_user}","gists_url":"https://api.github.com/users/mc-server/gists{/gist_id}","starred_url":"https://api.github.com/users/mc-server/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mc-server/subscriptions","organizations_url":"https://api.github.com/users/mc-server/orgs","repos_url":"https://api.github.com/users/mc-server/repos","events_url":"https://api.github.com/users/mc-server/events{/privacy}","received_events_url":"https://api.github.com/users/mc-server/received_events","type":"Organization","site_admin":false},"repo":{"id":11693709,"name":"MCServer","full_name":"mc-server/MCServer","owner":{"login":"mc-server","id":5096476,"avatar_url":"https://avatars.githubusercontent.com/u/5096476?","gravatar_id":"24d22348a9a88243556209a78e4ac2f5","url":"https://api.github.com/users/mc-server","html_url":"https://github.com/mc-server","followers_url":"https://api.github.com/users/mc-server/followers","following_url":"https://api.github.com/users/mc-server/following{/other_user}","gists_url":"https://api.github.com/users/mc-server/gists{/gist_id}","starred_url":"https://api.github.com/users/mc-server/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mc-server/subscriptions","organizations_url":"https://api.github.com/users/mc-server/orgs","repos_url":"https://api.github.com/users/mc-server/repos","events_url":"https://api.github.com/users/mc-server/events{/privacy}","received_events_url":"https://api.github.com/users/mc-server/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mc-server/MCServer","description":"A performant C++ Minecraft Server","fork":false,"url":"https://api.github.com/repos/mc-server/MCServer","forks_url":"https://api.github.com/repos/mc-server/MCServer/forks","keys_url":"https://api.github.com/repos/mc-server/MCServer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mc-server/MCServer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mc-server/MCServer/teams","hooks_url":"https://api.github.com/repos/mc-server/MCServer/hooks","issue_events_url":"https://api.github.com/repos/mc-server/MCServer/issues/events{/number}","events_url":"https://api.github.com/repos/mc-server/MCServer/events","assignees_url":"https://api.github.com/repos/mc-server/MCServer/assignees{/user}","branches_url":"https://api.github.com/repos/mc-server/MCServer/branches{/branch}","tags_url":"https://api.github.com/repos/mc-server/MCServer/tags","blobs_url":"https://api.github.com/repos/mc-server/MCServer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mc-server/MCServer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mc-server/MCServer/git/refs{/sha}","trees_url":"https://api.github.com/repos/mc-server/MCServer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mc-server/MCServer/statuses/{sha}","languages_url":"https://api.github.com/repos/mc-server/MCServer/languages","stargazers_url":"https://api.github.com/repos/mc-server/MCServer/stargazers","contributors_url":"https://api.github.com/repos/mc-server/MCServer/contributors","subscribers_url":"https://api.github.com/repos/mc-server/MCServer/subscribers","subscription_url":"https://api.github.com/repos/mc-server/MCServer/subscription","commits_url":"https://api.github.com/repos/mc-server/MCServer/commits{/sha}","git_commits_url":"https://api.github.com/repos/mc-server/MCServer/git/commits{/sha}","comments_url":"https://api.github.com/repos/mc-server/MCServer/comments{/number}","issue_comment_url":"https://api.github.com/repos/mc-server/MCServer/issues/comments/{number}","contents_url":"https://api.github.com/repos/mc-server/MCServer/contents/{+path}","compare_url":"https://api.github.com/repos/mc-server/MCServer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mc-server/MCServer/merges","archive_url":"https://api.github.com/repos/mc-server/MCServer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mc-server/MCServer/downloads","issues_url":"https://api.github.com/repos/mc-server/MCServer/issues{/number}","pulls_url":"https://api.github.com/repos/mc-server/MCServer/pulls{/number}","milestones_url":"https://api.github.com/repos/mc-server/MCServer/milestones{/number}","notifications_url":"https://api.github.com/repos/mc-server/MCServer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mc-server/MCServer/labels{/name}","releases_url":"https://api.github.com/repos/mc-server/MCServer/releases{/id}","created_at":"2013-07-26T19:56:59Z","updated_at":"2014-06-14T16:23:31Z","pushed_at":"2014-06-14T16:23:32Z","git_url":"git://github.com/mc-server/MCServer.git","ssh_url":"git@github.com:mc-server/MCServer.git","clone_url":"https://github.com/mc-server/MCServer.git","svn_url":"https://github.com/mc-server/MCServer","homepage":"mc-server.org","size":149491,"stargazers_count":200,"watchers_count":200,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":67,"mirror_url":null,"open_issues_count":189,"forks":67,"open_issues":189,"watchers":200,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mc-server/MCServer/pulls/1024"},"html":{"href":"https://github.com/mc-server/MCServer/pull/1024"},"issue":{"href":"https://api.github.com/repos/mc-server/MCServer/issues/1024"},"comments":{"href":"https://api.github.com/repos/mc-server/MCServer/issues/1024/comments"},"review_comments":{"href":"https://api.github.com/repos/mc-server/MCServer/pulls/1024/comments"},"review_comment":{"href":"https://api.github.com/repos/mc-server/MCServer/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mc-server/MCServer/pulls/1024/commits"},"statuses":{"href":"https://api.github.com/repos/mc-server/MCServer/statuses/061102c77860e7a31b7504ca52bb99e419393fb2"}}}}