GitHub PullRequestReviewCommentEvent at 2014-01-20 10:17:40
Repository: bem-bl
Actor: arikon
Payload: {"comment":{"url":"https://api.github.com/repos/bem/bem-bl/pulls/comments/9000600","id":9000600,"diff_hunk":"@@ -24,22 +37,60 @@ exports.getBuildResultChunk = function(relPath, path, suffix) {\n \n exports.getBuildResult = function(files, suffix, output, opts) {\n \n+    this._chunks = [];\n+    this._lastOffset = 0;\n+\n     var _this = this;\n     return this.__base(files, suffix, output, opts)\n         .then(function(sources) {\n             sources = sources.join('\\n');\n \n-            var BEMHTML = require('../../../__html/lib/bemhtml');\n \n-            return BEMHTML.translate(sources, {\n-              devMode: process.env.BEMHTML_ENV == 'development',\n-              cache: process.env.BEMHTML_CACHE == 'on'\n-            });\n+            try {\n+\n+                return BEMHTML.translate(sources, {\n+                  devMode: process.env.BEMHTML_ENV == 'development',\n+                  cache: process.env.BEMHTML_CACHE == 'on'\n+                });\n+\n+            } catch (e) {\n+                if (e.line) {\n+                    var source = _this._getSource(e.line);\n+                    throw new Error(SYS.format('Unable to parse %s. Error at %d:%d',\n+                        source.file,\n+                        source.line,\n+                        e.column));\n+                }\n+                throw e;\n+            }\n \n         });\n \n };\n \n+exports._getSource = function _getSource(line) {","path":"blocks-common/i-bem/bem/techs/v2/bemhtml.js","position":70,"original_position":70,"commit_id":"1a299d97b1fbe4753dd49763141d4f1884ac6ea4","original_commit_id":"1a299d97b1fbe4753dd49763141d4f1884ac6ea4","user":{"login":"arikon","id":75247,"avatar_url":"https://gravatar.com/avatar/6fa6da3a6927ded01bac659b5f1b4281?d=https%3A%2F%2Fidenticons.github.com%2F5204baddc6f0824345567e9778df1505.png&r=x","gravatar_id":"6fa6da3a6927ded01bac659b5f1b4281","url":"https://api.github.com/users/arikon","html_url":"https://github.com/arikon","followers_url":"https://api.github.com/users/arikon/followers","following_url":"https://api.github.com/users/arikon/following{/other_user}","gists_url":"https://api.github.com/users/arikon/gists{/gist_id}","starred_url":"https://api.github.com/users/arikon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arikon/subscriptions","organizations_url":"https://api.github.com/users/arikon/orgs","repos_url":"https://api.github.com/users/arikon/repos","events_url":"https://api.github.com/users/arikon/events{/privacy}","received_events_url":"https://api.github.com/users/arikon/received_events","type":"User","site_admin":false},"body":"А, это же mixin","created_at":"2014-01-20T10:17:40Z","updated_at":"2014-01-20T10:17:40Z","html_url":"https://github.com/bem/bem-bl/pull/439#discussion_r9000600","pull_request_url":"https://api.github.com/repos/bem/bem-bl/pulls/439","_links":{"self":{"href":"https://api.github.com/repos/bem/bem-bl/pulls/comments/9000600"},"html":{"href":"https://github.com/bem/bem-bl/pull/439#discussion_r9000600"},"pull_request":{"href":"https://api.github.com/repos/bem/bem-bl/pulls/439"}}}}