GitHub PullRequestEvent at 2014-10-13 09:21:24
Repository: test
Actor: glebv
Payload: {"action":"opened","number":7,"pull_request":{"url":"https://api.github.com/repos/IvanFarms/test/pulls/7","id":22633485,"html_url":"https://github.com/IvanFarms/test/pull/7","diff_url":"https://github.com/IvanFarms/test/pull/7.diff","patch_url":"https://github.com/IvanFarms/test/pull/7.patch","issue_url":"https://api.github.com/repos/IvanFarms/test/issues/7","number":7,"state":"open","locked":false,"title":"implementation of test task","user":{"login":"glebv","id":6583360,"avatar_url":"https://avatars.githubusercontent.com/u/6583360?v=2","gravatar_id":"","url":"https://api.github.com/users/glebv","html_url":"https://github.com/glebv","followers_url":"https://api.github.com/users/glebv/followers","following_url":"https://api.github.com/users/glebv/following{/other_user}","gists_url":"https://api.github.com/users/glebv/gists{/gist_id}","starred_url":"https://api.github.com/users/glebv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glebv/subscriptions","organizations_url":"https://api.github.com/users/glebv/orgs","repos_url":"https://api.github.com/users/glebv/repos","events_url":"https://api.github.com/users/glebv/events{/privacy}","received_events_url":"https://api.github.com/users/glebv/received_events","type":"User","site_admin":false},"body":"I've implemented all points of task.\r\nI've created: \r\n— grunt script for watching and validation html/js (to use it, make following: nom install && grunt serve);\r\n— I decided to not use bower components because ui.bootstarp requires additional build action, all necessary libs load via cdnjs; \r\n— 3 controllers, for sigin, signUp and updateUser steps;\r\n— signUp and updateUser uses the same template (views/signup.html);\r\n— directive and service alert.js for mangment allerts, successful allerts will be hidden in 5 sec;\r\n— service services/user.js contains all communication with API;\r\n— E-mail is passed between signin and updateUser via User service to avoid hacking by web dev tools;\r\n— API method PUT /use/email doesn't work properly: \r\nfirst off all its the implementation or the description don't correspond real needs. There isn't way to update data.\r\nThen any PUT request returns 500 error (here's the response\r\n```\r\nRequest URL:\thttp://api-test.ivanfarms.com/user/gv11ng@gmail.com\r\nDjango Version:\t1.7\r\nException Type:\tWarning\r\nException Value:\t\r\nColumn 'name' cannot be null\r\nException Location:\t/home/user/Envs/venv/lib/python2.7/site-packages/MySQLdb/cursors.py in _warning_check, line 117\r\nPython Executable:\t/usr/bin/python\r\nPython Version:\t2.7.6\r\nPython Path:\t\r\n['/home/user/api-test', '/home/user/Envs/venv/lib/python2.7/site-packages', '/home/user/Envs/venv/lib/python2.7/site-packages/setuptools-0.6c11-py2.7.egg-info', '/usr/lib/python2.7', '/usr/lib/python2.7/plat-x86_64-linux-gnu', '/usr/lib/python2.7/lib-tk', '/usr/lib/python2.7/lib-old', '/usr/lib/python2.7/lib-dynload', '/usr/local/lib/python2.7/dist-packages', '/usr/lib/python2.7/dist-packag\r\n)\r\n```\r\nI sure that the solution is robust and flexible.   \r\nIf you have any questions feel free to ask me. I'll be glad to discuss my implementation. \r\nIn any case I'll be happy to get feedback from you.","created_at":"2014-10-13T09:21:23Z","updated_at":"2014-10-13T09:21:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/IvanFarms/test/pulls/7/commits","review_comments_url":"https://api.github.com/repos/IvanFarms/test/pulls/7/comments","review_comment_url":"https://api.github.com/repos/IvanFarms/test/pulls/comments/{number}","comments_url":"https://api.github.com/repos/IvanFarms/test/issues/7/comments","statuses_url":"https://api.github.com/repos/IvanFarms/test/statuses/6ffcf7a6cef7e634774273c80ff5e14296386bc0","head":{"label":"glebv:master","ref":"master","sha":"6ffcf7a6cef7e634774273c80ff5e14296386bc0","user":{"login":"glebv","id":6583360,"avatar_url":"https://avatars.githubusercontent.com/u/6583360?v=2","gravatar_id":"","url":"https://api.github.com/users/glebv","html_url":"https://github.com/glebv","followers_url":"https://api.github.com/users/glebv/followers","following_url":"https://api.github.com/users/glebv/following{/other_user}","gists_url":"https://api.github.com/users/glebv/gists{/gist_id}","starred_url":"https://api.github.com/users/glebv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glebv/subscriptions","organizations_url":"https://api.github.com/users/glebv/orgs","repos_url":"https://api.github.com/users/glebv/repos","events_url":"https://api.github.com/users/glebv/events{/privacy}","received_events_url":"https://api.github.com/users/glebv/received_events","type":"User","site_admin":false},"repo":{"id":25068926,"name":"test","full_name":"glebv/test","owner":{"login":"glebv","id":6583360,"avatar_url":"https://avatars.githubusercontent.com/u/6583360?v=2","gravatar_id":"","url":"https://api.github.com/users/glebv","html_url":"https://github.com/glebv","followers_url":"https://api.github.com/users/glebv/followers","following_url":"https://api.github.com/users/glebv/following{/other_user}","gists_url":"https://api.github.com/users/glebv/gists{/gist_id}","starred_url":"https://api.github.com/users/glebv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glebv/subscriptions","organizations_url":"https://api.github.com/users/glebv/orgs","repos_url":"https://api.github.com/users/glebv/repos","events_url":"https://api.github.com/users/glebv/events{/privacy}","received_events_url":"https://api.github.com/users/glebv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/glebv/test","description":"","fork":true,"url":"https://api.github.com/repos/glebv/test","forks_url":"https://api.github.com/repos/glebv/test/forks","keys_url":"https://api.github.com/repos/glebv/test/keys{/key_id}","collaborators_url":"https://api.github.com/repos/glebv/test/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/glebv/test/teams","hooks_url":"https://api.github.com/repos/glebv/test/hooks","issue_events_url":"https://api.github.com/repos/glebv/test/issues/events{/number}","events_url":"https://api.github.com/repos/glebv/test/events","assignees_url":"https://api.github.com/repos/glebv/test/assignees{/user}","branches_url":"https://api.github.com/repos/glebv/test/branches{/branch}","tags_url":"https://api.github.com/repos/glebv/test/tags","blobs_url":"https://api.github.com/repos/glebv/test/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/glebv/test/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/glebv/test/git/refs{/sha}","trees_url":"https://api.github.com/repos/glebv/test/git/trees{/sha}","statuses_url":"https://api.github.com/repos/glebv/test/statuses/{sha}","languages_url":"https://api.github.com/repos/glebv/test/languages","stargazers_url":"https://api.github.com/repos/glebv/test/stargazers","contributors_url":"https://api.github.com/repos/glebv/test/contributors","subscribers_url":"https://api.github.com/repos/glebv/test/subscribers","subscription_url":"https://api.github.com/repos/glebv/test/subscription","commits_url":"https://api.github.com/repos/glebv/test/commits{/sha}","git_commits_url":"https://api.github.com/repos/glebv/test/git/commits{/sha}","comments_url":"https://api.github.com/repos/glebv/test/comments{/number}","issue_comment_url":"https://api.github.com/repos/glebv/test/issues/comments/{number}","contents_url":"https://api.github.com/repos/glebv/test/contents/{+path}","compare_url":"https://api.github.com/repos/glebv/test/compare/{base}...{head}","merges_url":"https://api.github.com/repos/glebv/test/merges","archive_url":"https://api.github.com/repos/glebv/test/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/glebv/test/downloads","issues_url":"https://api.github.com/repos/glebv/test/issues{/number}","pulls_url":"https://api.github.com/repos/glebv/test/pulls{/number}","milestones_url":"https://api.github.com/repos/glebv/test/milestones{/number}","notifications_url":"https://api.github.com/repos/glebv/test/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/glebv/test/labels{/name}","releases_url":"https://api.github.com/repos/glebv/test/releases{/id}","created_at":"2014-10-11T07:59:17Z","updated_at":"2014-10-13T08:50:34Z","pushed_at":"2014-10-13T08:50:33Z","git_url":"git://github.com/glebv/test.git","ssh_url":"git@github.com:glebv/test.git","clone_url":"https://github.com/glebv/test.git","svn_url":"https://github.com/glebv/test","homepage":null,"size":4320,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"IvanFarms:master","ref":"master","sha":"d6a7e5ab885a1fc11dcd114f19c74eaca009d9d9","user":{"login":"IvanFarms","id":8322441,"avatar_url":"https://avatars.githubusercontent.com/u/8322441?v=2","gravatar_id":"","url":"https://api.github.com/users/IvanFarms","html_url":"https://github.com/IvanFarms","followers_url":"https://api.github.com/users/IvanFarms/followers","following_url":"https://api.github.com/users/IvanFarms/following{/other_user}","gists_url":"https://api.github.com/users/IvanFarms/gists{/gist_id}","starred_url":"https://api.github.com/users/IvanFarms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IvanFarms/subscriptions","organizations_url":"https://api.github.com/users/IvanFarms/orgs","repos_url":"https://api.github.com/users/IvanFarms/repos","events_url":"https://api.github.com/users/IvanFarms/events{/privacy}","received_events_url":"https://api.github.com/users/IvanFarms/received_events","type":"Organization","site_admin":false},"repo":{"id":24240842,"name":"test","full_name":"IvanFarms/test","owner":{"login":"IvanFarms","id":8322441,"avatar_url":"https://avatars.githubusercontent.com/u/8322441?v=2","gravatar_id":"","url":"https://api.github.com/users/IvanFarms","html_url":"https://github.com/IvanFarms","followers_url":"https://api.github.com/users/IvanFarms/followers","following_url":"https://api.github.com/users/IvanFarms/following{/other_user}","gists_url":"https://api.github.com/users/IvanFarms/gists{/gist_id}","starred_url":"https://api.github.com/users/IvanFarms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IvanFarms/subscriptions","organizations_url":"https://api.github.com/users/IvanFarms/orgs","repos_url":"https://api.github.com/users/IvanFarms/repos","events_url":"https://api.github.com/users/IvanFarms/events{/privacy}","received_events_url":"https://api.github.com/users/IvanFarms/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/IvanFarms/test","description":"","fork":false,"url":"https://api.github.com/repos/IvanFarms/test","forks_url":"https://api.github.com/repos/IvanFarms/test/forks","keys_url":"https://api.github.com/repos/IvanFarms/test/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IvanFarms/test/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IvanFarms/test/teams","hooks_url":"https://api.github.com/repos/IvanFarms/test/hooks","issue_events_url":"https://api.github.com/repos/IvanFarms/test/issues/events{/number}","events_url":"https://api.github.com/repos/IvanFarms/test/events","assignees_url":"https://api.github.com/repos/IvanFarms/test/assignees{/user}","branches_url":"https://api.github.com/repos/IvanFarms/test/branches{/branch}","tags_url":"https://api.github.com/repos/IvanFarms/test/tags","blobs_url":"https://api.github.com/repos/IvanFarms/test/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IvanFarms/test/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IvanFarms/test/git/refs{/sha}","trees_url":"https://api.github.com/repos/IvanFarms/test/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IvanFarms/test/statuses/{sha}","languages_url":"https://api.github.com/repos/IvanFarms/test/languages","stargazers_url":"https://api.github.com/repos/IvanFarms/test/stargazers","contributors_url":"https://api.github.com/repos/IvanFarms/test/contributors","subscribers_url":"https://api.github.com/repos/IvanFarms/test/subscribers","subscription_url":"https://api.github.com/repos/IvanFarms/test/subscription","commits_url":"https://api.github.com/repos/IvanFarms/test/commits{/sha}","git_commits_url":"https://api.github.com/repos/IvanFarms/test/git/commits{/sha}","comments_url":"https://api.github.com/repos/IvanFarms/test/comments{/number}","issue_comment_url":"https://api.github.com/repos/IvanFarms/test/issues/comments/{number}","contents_url":"https://api.github.com/repos/IvanFarms/test/contents/{+path}","compare_url":"https://api.github.com/repos/IvanFarms/test/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IvanFarms/test/merges","archive_url":"https://api.github.com/repos/IvanFarms/test/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IvanFarms/test/downloads","issues_url":"https://api.github.com/repos/IvanFarms/test/issues{/number}","pulls_url":"https://api.github.com/repos/IvanFarms/test/pulls{/number}","milestones_url":"https://api.github.com/repos/IvanFarms/test/milestones{/number}","notifications_url":"https://api.github.com/repos/IvanFarms/test/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IvanFarms/test/labels{/name}","releases_url":"https://api.github.com/repos/IvanFarms/test/releases{/id}","created_at":"2014-09-19T18:30:26Z","updated_at":"2014-09-29T23:04:19Z","pushed_at":"2014-10-10T19:37:22Z","git_url":"git://github.com/IvanFarms/test.git","ssh_url":"git@github.com:IvanFarms/test.git","clone_url":"https://github.com/IvanFarms/test.git","svn_url":"https://github.com/IvanFarms/test","homepage":null,"size":7873,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":2,"forks":5,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/IvanFarms/test/pulls/7"},"html":{"href":"https://github.com/IvanFarms/test/pull/7"},"issue":{"href":"https://api.github.com/repos/IvanFarms/test/issues/7"},"comments":{"href":"https://api.github.com/repos/IvanFarms/test/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/IvanFarms/test/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/IvanFarms/test/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/IvanFarms/test/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/IvanFarms/test/statuses/6ffcf7a6cef7e634774273c80ff5e14296386bc0"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":537,"deletions":149,"changed_files":20}}