GitHub PullRequestReviewCommentEvent at 2014-09-04 09:50:17
Repository: assessment-elm-image-search
Actor: laszlopandy
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/prezi/assessment-elm-image-search/pulls/comments/17104367","id":17104367,"diff_hunk":"@@ -96,89 +114,112 @@ searchSubmits =\n             inputEnterKeyDowns.signal)\n         state\n \n+\n searchQueries : Signal SearchQuery\n searchQueries = searchQuery <~ searchSubmits\n \n+\n searchResults : Signal Config -> Signal [SearchResult]\n searchResults config = \n-    combine\n-        [ (GoogleSearchEnigne.results config searchQueries)\n-        , (TestSearchEnigne.results searchQueries)\n+    combine [\n+            (GoogleSearchEnigne.results config searchQueries),\n+            (TestSearchEnigne.results searchQueries)\n         ]\n \n {- UI -}\n \n searchWidgetElement : Config -> Labels.Labels -> State -> [SearchResult] -> Html\n searchWidgetElement config labels state results =\n-        node \"div\"\n-            [ Css.widget ]\n-            []\n-            [ headerElement labels.searchTitle\n-            , searchInputElement\n-            , submitButtonElement labels.submit\n-            , searchResultsElement config results\n-            ]\n+    node\n+        \"div\"\n+        [ Css.widget ]\n+        []\n+        [\n+            headerElement labels.searchTitle,\n+            searchInputElement,\n+            submitButtonElement labels.submit,\n+            searchResultsElement config results\n+        ]\n+\n \n submitButtonElement : String -> Html\n submitButtonElement label = \n-    eventNode \"input\"\n-        [ Css.submit\n-        , \"type\" := \"button\"\n-        , \"value\" := label\n+    eventNode\n+        \"input\"\n+        [\n+            Css.submit,\n+            \"type\" := \"button\",\n+            \"value\" := label\n         ]\n         []\n         [ onclick submitButtonClicks.handle (always ()) ]\n         []\n \n+\n headerElement : String -> Html\n headerElement label = \n-    node \"div\"\n+    node\n+        \"div\"\n         [ Css.header ]\n         []\n         [ text label ]\n \n+\n searchInputElement : Html\n searchInputElement = \n-    eventNode \"input\"\n+    eventNode\n+        \"input\"\n         [ Css.input ]\n         []\n-        [ on \"keydown\" (when (\\e -> e.keyCode == 13) getKeyboardEvent) inputEnterKeyDowns.handle (always ())\n-        , on \"keyup\" (getValue) actions.handle UpdateSearchText\n+        [\n+            on\n+                \"keydown\"\n+                (when (\\e -> e.keyCode == 13) getKeyboardEvent)\n+                inputEnterKeyDowns.handle\n+                (always ()),\n+            on\n+                \"keyup\"\n+                getValue\n+                actions.handle\n+                UpdateSearchText\n         ]\n         []\n \n+\n searchResultsElement : Config -> [SearchResult] -> Html\n searchResultsElement config results =\n-    let\n-        flatResults = concat results\n+    let flatResults = concat results\n         flatResultsWithIdx = zip [1 .. length flatResults] flatResults\n         (col1WithIdx, col2WithIdx) = partition (\\(idx, e) -> mod idx 2 == 1) flatResultsWithIdx\n         colElems colWithIdx =  map (\\(idx, e) -> searchResultEntryElement config e) colWithIdx\n         col colWithIdx = node \"div\" [ Css.resultCol ] [] (colElems colWithIdx)\n     in\n-        node \"div\"\n+        node\n+            \"div\"\n             [ Css.results ]\n             []\n-            [ col col1WithIdx\n-            , col col2WithIdx\n+            [\n+                col col1WithIdx,\n+                col col2WithIdx\n             ]\n \n+\n searchResultEntryElement : Config -> SearchResultEntry -> Html\n searchResultEntryElement config entry =\n-    let\n-        w = (toFloat (config.width - 4 * config.imagePadding)) / 2.0\n+    let w = (toFloat (config.width - 4 * config.imagePadding)) / 2.0","path":"PreziImageSearch/Widget.elm","position":213,"original_position":213,"commit_id":"0abeae3059e33d2db5b03c16889c45c5f23dc6a7","original_commit_id":"0abeae3059e33d2db5b03c16889c45c5f23dc6a7","user":{"login":"laszlopandy","id":927584,"avatar_url":"https://avatars.githubusercontent.com/u/927584?v=2","gravatar_id":"636178529a54a639c15ce1868dbf285e","url":"https://api.github.com/users/laszlopandy","html_url":"https://github.com/laszlopandy","followers_url":"https://api.github.com/users/laszlopandy/followers","following_url":"https://api.github.com/users/laszlopandy/following{/other_user}","gists_url":"https://api.github.com/users/laszlopandy/gists{/gist_id}","starred_url":"https://api.github.com/users/laszlopandy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laszlopandy/subscriptions","organizations_url":"https://api.github.com/users/laszlopandy/orgs","repos_url":"https://api.github.com/users/laszlopandy/repos","events_url":"https://api.github.com/users/laszlopandy/events{/privacy}","received_events_url":"https://api.github.com/users/laszlopandy/received_events","type":"User","site_admin":false},"body":"I don't think empty lines after `let` should be allowed. If you want to separate it from the function name and params, I would recommend putting an extra blank line above.","created_at":"2014-09-04T09:50:17Z","updated_at":"2014-09-04T09:50:17Z","html_url":"https://github.com/prezi/assessment-elm-image-search/pull/1#discussion_r17104367","pull_request_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/prezi/assessment-elm-image-search/pulls/comments/17104367"},"html":{"href":"https://github.com/prezi/assessment-elm-image-search/pull/1#discussion_r17104367"},"pull_request":{"href":"https://api.github.com/repos/prezi/assessment-elm-image-search/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/prezi/assessment-elm-image-search/pulls/1","id":20732007,"html_url":"https://github.com/prezi/assessment-elm-image-search/pull/1","diff_url":"https://github.com/prezi/assessment-elm-image-search/pull/1.diff","patch_url":"https://github.com/prezi/assessment-elm-image-search/pull/1.patch","issue_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/issues/1","number":1,"state":"open","locked":false,"title":"Formatting changes to conform to the new Elm style guide.","user":{"login":"laszlopandy","id":927584,"avatar_url":"https://avatars.githubusercontent.com/u/927584?v=2","gravatar_id":"636178529a54a639c15ce1868dbf285e","url":"https://api.github.com/users/laszlopandy","html_url":"https://github.com/laszlopandy","followers_url":"https://api.github.com/users/laszlopandy/followers","following_url":"https://api.github.com/users/laszlopandy/following{/other_user}","gists_url":"https://api.github.com/users/laszlopandy/gists{/gist_id}","starred_url":"https://api.github.com/users/laszlopandy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laszlopandy/subscriptions","organizations_url":"https://api.github.com/users/laszlopandy/orgs","repos_url":"https://api.github.com/users/laszlopandy/repos","events_url":"https://api.github.com/users/laszlopandy/events{/privacy}","received_events_url":"https://api.github.com/users/laszlopandy/received_events","type":"User","site_admin":false},"body":"The Elm style guide is a work in progress:\r\nhttps://gist.github.com/laszlopandy/c3bf56b6f87f71303c9f\r\n\r\nI am using this repository to test how it looks on real code.\r\n@evancz ","created_at":"2014-09-04T09:39:54Z","updated_at":"2014-09-04T09:50:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cfd6406e44635b2f101482d5711309632dea8bf5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/pulls/1/commits","review_comments_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/pulls/1/comments","review_comment_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/pulls/comments/{number}","comments_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/issues/1/comments","statuses_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/statuses/0abeae3059e33d2db5b03c16889c45c5f23dc6a7","head":{"label":"prezi:style-guide-fixes","ref":"style-guide-fixes","sha":"0abeae3059e33d2db5b03c16889c45c5f23dc6a7","user":{"login":"prezi","id":1989101,"avatar_url":"https://avatars.githubusercontent.com/u/1989101?v=2","gravatar_id":"854a91963b1cceab615cafda9ecdf488","url":"https://api.github.com/users/prezi","html_url":"https://github.com/prezi","followers_url":"https://api.github.com/users/prezi/followers","following_url":"https://api.github.com/users/prezi/following{/other_user}","gists_url":"https://api.github.com/users/prezi/gists{/gist_id}","starred_url":"https://api.github.com/users/prezi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prezi/subscriptions","organizations_url":"https://api.github.com/users/prezi/orgs","repos_url":"https://api.github.com/users/prezi/repos","events_url":"https://api.github.com/users/prezi/events{/privacy}","received_events_url":"https://api.github.com/users/prezi/received_events","type":"Organization","site_admin":false},"repo":{"id":23421563,"name":"assessment-elm-image-search","full_name":"prezi/assessment-elm-image-search","owner":{"login":"prezi","id":1989101,"avatar_url":"https://avatars.githubusercontent.com/u/1989101?v=2","gravatar_id":"854a91963b1cceab615cafda9ecdf488","url":"https://api.github.com/users/prezi","html_url":"https://github.com/prezi","followers_url":"https://api.github.com/users/prezi/followers","following_url":"https://api.github.com/users/prezi/following{/other_user}","gists_url":"https://api.github.com/users/prezi/gists{/gist_id}","starred_url":"https://api.github.com/users/prezi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prezi/subscriptions","organizations_url":"https://api.github.com/users/prezi/orgs","repos_url":"https://api.github.com/users/prezi/repos","events_url":"https://api.github.com/users/prezi/events{/privacy}","received_events_url":"https://api.github.com/users/prezi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prezi/assessment-elm-image-search","description":"Elm image search widget","fork":false,"url":"https://api.github.com/repos/prezi/assessment-elm-image-search","forks_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/forks","keys_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/teams","hooks_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/hooks","issue_events_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/issues/events{/number}","events_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/events","assignees_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/assignees{/user}","branches_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/branches{/branch}","tags_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/tags","blobs_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/git/refs{/sha}","trees_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/statuses/{sha}","languages_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/languages","stargazers_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/stargazers","contributors_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/contributors","subscribers_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/subscribers","subscription_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/subscription","commits_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/commits{/sha}","git_commits_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/git/commits{/sha}","comments_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/comments{/number}","issue_comment_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/issues/comments/{number}","contents_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/contents/{+path}","compare_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/merges","archive_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/downloads","issues_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/issues{/number}","pulls_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/pulls{/number}","milestones_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/milestones{/number}","notifications_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/labels{/name}","releases_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/releases{/id}","created_at":"2014-08-28T08:55:11Z","updated_at":"2014-09-04T09:03:55Z","pushed_at":"2014-09-04T09:37:05Z","git_url":"git://github.com/prezi/assessment-elm-image-search.git","ssh_url":"git@github.com:prezi/assessment-elm-image-search.git","clone_url":"https://github.com/prezi/assessment-elm-image-search.git","svn_url":"https://github.com/prezi/assessment-elm-image-search","homepage":null,"size":156,"stargazers_count":0,"watchers_count":0,"language":"Elm","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"prezi:master","ref":"master","sha":"c4fe51a6fec84ae381480a6211a30c7519000f49","user":{"login":"prezi","id":1989101,"avatar_url":"https://avatars.githubusercontent.com/u/1989101?v=2","gravatar_id":"854a91963b1cceab615cafda9ecdf488","url":"https://api.github.com/users/prezi","html_url":"https://github.com/prezi","followers_url":"https://api.github.com/users/prezi/followers","following_url":"https://api.github.com/users/prezi/following{/other_user}","gists_url":"https://api.github.com/users/prezi/gists{/gist_id}","starred_url":"https://api.github.com/users/prezi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prezi/subscriptions","organizations_url":"https://api.github.com/users/prezi/orgs","repos_url":"https://api.github.com/users/prezi/repos","events_url":"https://api.github.com/users/prezi/events{/privacy}","received_events_url":"https://api.github.com/users/prezi/received_events","type":"Organization","site_admin":false},"repo":{"id":23421563,"name":"assessment-elm-image-search","full_name":"prezi/assessment-elm-image-search","owner":{"login":"prezi","id":1989101,"avatar_url":"https://avatars.githubusercontent.com/u/1989101?v=2","gravatar_id":"854a91963b1cceab615cafda9ecdf488","url":"https://api.github.com/users/prezi","html_url":"https://github.com/prezi","followers_url":"https://api.github.com/users/prezi/followers","following_url":"https://api.github.com/users/prezi/following{/other_user}","gists_url":"https://api.github.com/users/prezi/gists{/gist_id}","starred_url":"https://api.github.com/users/prezi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prezi/subscriptions","organizations_url":"https://api.github.com/users/prezi/orgs","repos_url":"https://api.github.com/users/prezi/repos","events_url":"https://api.github.com/users/prezi/events{/privacy}","received_events_url":"https://api.github.com/users/prezi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prezi/assessment-elm-image-search","description":"Elm image search widget","fork":false,"url":"https://api.github.com/repos/prezi/assessment-elm-image-search","forks_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/forks","keys_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/teams","hooks_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/hooks","issue_events_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/issues/events{/number}","events_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/events","assignees_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/assignees{/user}","branches_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/branches{/branch}","tags_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/tags","blobs_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/git/refs{/sha}","trees_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/statuses/{sha}","languages_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/languages","stargazers_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/stargazers","contributors_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/contributors","subscribers_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/subscribers","subscription_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/subscription","commits_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/commits{/sha}","git_commits_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/git/commits{/sha}","comments_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/comments{/number}","issue_comment_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/issues/comments/{number}","contents_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/contents/{+path}","compare_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/merges","archive_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/downloads","issues_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/issues{/number}","pulls_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/pulls{/number}","milestones_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/milestones{/number}","notifications_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/labels{/name}","releases_url":"https://api.github.com/repos/prezi/assessment-elm-image-search/releases{/id}","created_at":"2014-08-28T08:55:11Z","updated_at":"2014-09-04T09:03:55Z","pushed_at":"2014-09-04T09:37:05Z","git_url":"git://github.com/prezi/assessment-elm-image-search.git","ssh_url":"git@github.com:prezi/assessment-elm-image-search.git","clone_url":"https://github.com/prezi/assessment-elm-image-search.git","svn_url":"https://github.com/prezi/assessment-elm-image-search","homepage":null,"size":156,"stargazers_count":0,"watchers_count":0,"language":"Elm","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prezi/assessment-elm-image-search/pulls/1"},"html":{"href":"https://github.com/prezi/assessment-elm-image-search/pull/1"},"issue":{"href":"https://api.github.com/repos/prezi/assessment-elm-image-search/issues/1"},"comments":{"href":"https://api.github.com/repos/prezi/assessment-elm-image-search/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/prezi/assessment-elm-image-search/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/prezi/assessment-elm-image-search/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/prezi/assessment-elm-image-search/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/prezi/assessment-elm-image-search/statuses/0abeae3059e33d2db5b03c16889c45c5f23dc6a7"}}}}