GitHub PushEvent at 2014-01-10 22:04:49
Repository: spark
Actor: umop
Payload: {"shas":[["8a12e5ff9108117ef2398f1af04f35895c4052cb","e7939a245bd8e6f1d39bfc0032ad687f50d9f565@chromium.org","Polymer UI menu: cleanups, refactorings, etc.","Sergey Shevchenko",false],["0b6b0504d899bd468ac90dbdb067f52ed068aa18","e7939a245bd8e6f1d39bfc0032ad687f50d9f565@chromium.org","Added \"change theme\" and \"change keys\" to Polymer UI menu\n\nMight be temporary, if can't make them work.","Sergey Shevchenko",false],["2bf4026d8638e1feb8f615d762962e73d634187a","e7939a245bd8e6f1d39bfc0032ad687f50d9f565@google.com","Fixed widgets and Polymer UI: menu selection is plumbed up to the UI now","Sergey Shevchenko",false],["e91fa01d38c886ec02b7fee7fdcee95688c8a508","fb7922595ad9c210c0f3ce773f00cc8b9d8e21f3@google.com","Merge branch 'fix-polymer-ui-menu' of https://github.com/ussuri/spark into sergey_menus","terrylucas",false],["ec9c93ad955be3d9e70a20b8edc78bead4927835","e7939a245bd8e6f1d39bfc0032ad687f50d9f565@chromium.org","Merge branch 'upstream/master'","Sergey Shevchenko",false],["b2c6cf0a8f62f665950cea670ac3920fe3547ff7","e7939a245bd8e6f1d39bfc0032ad687f50d9f565@chromium.org","Addressed comments","Sergey Shevchenko",false],["0ab0d2f230c5bb61ab6f71fa049a8fd37fda26ab","e7939a245bd8e6f1d39bfc0032ad687f50d9f565@chromium.org","Merge branch 'upstream/master'","Sergey Shevchenko",false],["8f87c5ff5a503d698f398c9d71b5b62660bd38ee","e7939a245bd8e6f1d39bfc0032ad687f50d9f565@chromium.org","WIP: switching to MVC paradigm in Polymer UI\n\nSparkPolymerUI receives a handle to SparkModel, which Spark and SparkPolymer implement. SparkPolymerUI uses the model to map various events in the UI to ActionManager calls, etc.\n\nThere is currently a race condition: Spark ctor wants to access various elements of the UI, and so the UI (SparkPolymerUI) gets created too early, before enteredView() fires for various components, leading to a crash in SparkSelector on a null _target.","Sergey Shevchenko",false],["b0595d90f4ed4b39a41ce2e19b88ceea3505bb2c","e7939a245bd8e6f1d39bfc0032ad687f50d9f565@google.com","Merge branch 'upstream/master'","Sergey Shevchenko",false],["db35b11fbe73ea2b1f3180766cfcbfdb4b938cb1","e7939a245bd8e6f1d39bfc0032ad687f50d9f565@google.com","Add assert","Sergey Shevchenko",false],["31fd12c2169a7d1998cdd03ecaf254a8133f0b35","e7939a245bd8e6f1d39bfc0032ad687f50d9f565@google.com","Fix unnoticed refactoring artifact","Sergey Shevchenko",false],["16d66e6bf3b8434db5124074a4cc6b481b54611f","fb7922595ad9c210c0f3ce773f00cc8b9d8e21f3@google.com","Added notion of modal dialogs","terrylucas",false],["f73bcfb65ad2bee9d602220fc121a536e158fe01","fb7922595ad9c210c0f3ce773f00cc8b9d8e21f3@google.com","Merge branch 'master' of https://github.com/dart-lang/spark into sergey_menus","terrylucas",false],["dd272cce87758064ed59734ac989ce60eb78fe24","fb7922595ad9c210c0f3ce773f00cc8b9d8e21f3@google.com","Cleanup","terrylucas",false],["390865af92219cfe5805589855ee859f4584f540","fb7922595ad9c210c0f3ce773f00cc8b9d8e21f3@google.com","cleanup","terrylucas",false],["16a4d46452673d5ea04a6b4c4bd75d6815bc464e","44c5a0e1ef77b41ab4bd98233aeeab819a04c2c6@google.com","Temporary testing setup","Eric Arnold",false],["0162ca05fff464e8bd9ab09db614dd0341de981b","e7939a245bd8e6f1d39bfc0032ad687f50d9f565@google.com","Merge branch 'upstream/master'","ussuri",false],["7e81c9cfb09f1a1db0f5d0f881e8f429c3f5aabe","e7939a245bd8e6f1d39bfc0032ad687f50d9f565@google.com","Temporarily patched the MVC scheme\n\nFailed to use a full-on MVC with programmatic creation of SparkPolymerUI from SparkPolymer ctor: that's too late, because the super-ctor (Spark) queries the still-uncreated UI via querySelector, and thus crashes. After a switchover to Polymer and getting rid of querySelector's to do things, the full MVC will be possible to implement.","ussuri",false],["f74ba88305986b8bed200ab986ef1d7313e56208","e7939a245bd8e6f1d39bfc0032ad687f50d9f565@google.com","Fixed the menu in Polymer UI\n\nCombination of 2 factors:\n1) spark-selector couldn't return spark-menu-item in the fired event: that resulted in a quited program exit; the receiver never received the event. Switched spark-selector to use the item's value when attrvalue is defined, and defined it to \"action-id\" in spark-polymer-ui. This works.\n2) The intermediate event receiver-resender in spark-menu-button for some reason crashed the app: the only menu item that worked was Open File, the rest caused even more of the DataCloneErrors (see below) and printed a stack trace.\n\nRemaining errors:\n1) There is a weird error printed to the console multiple times (on startup, on the menu open, on a menu item click): \"Uncaught DataCloneError: An object could not be cloned.\" In most cases that doesn't throw an exception or print a stack trace. But in one case it does - see above. Will file a bug.\n2) After opening the menu (even without clicking any items), the treeview misteriously breaks: a click on a file/folder collapses the toolbar. The rest of the treeview functions work and don't cause this effect. This is the same in the current main master too, so it's not this branch's doing.","ussuri",false],["8d302512b0b4359da772108e7d0db61eb6ea3429","e7939a245bd8e6f1d39bfc0032ad687f50d9f565@google.com","Synchronized the menu contents with non-Polymer UI\n\nClose and Delete got removed","ussuri",false]],"size":346,"ref":"refs/heads/master","head":"120645a3d6239878fc411ec2d720587ddcbac9f8"}