GitHub PullRequestReviewCommentEvent at 2014-12-03 18:19:46
Repository: referencesource
Actor: alexrp
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mono/referencesource/pulls/comments/21252212","id":21252212,"diff_hunk":"@@ -1146,7 +1152,11 @@ private void EnterMyLockSpin()\n         private void ExitMyLock()\n         {\n             Debug.Assert(myLock != 0, \"Exiting spin lock that is not held\");\n+#if NET_4_5\n             Volatile.Write(ref myLock, 0);\n+#else\n+            Thread.VolatileWrite(ref myLock, 0);","path":"System.Core/System/threading/ReaderWriterLockSlim/ReaderWriterLockSlim.cs","position":37,"original_position":37,"commit_id":"10aeab0df6df7cc5e5b81287c7684a845b9c9aab","original_commit_id":"10aeab0df6df7cc5e5b81287c7684a845b9c9aab","user":{"login":"alexrp","id":44076,"avatar_url":"https://avatars.githubusercontent.com/u/44076?v=3","gravatar_id":"","url":"https://api.github.com/users/alexrp","html_url":"https://github.com/alexrp","followers_url":"https://api.github.com/users/alexrp/followers","following_url":"https://api.github.com/users/alexrp/following{/other_user}","gists_url":"https://api.github.com/users/alexrp/gists{/gist_id}","starred_url":"https://api.github.com/users/alexrp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexrp/subscriptions","organizations_url":"https://api.github.com/users/alexrp/orgs","repos_url":"https://api.github.com/users/alexrp/repos","events_url":"https://api.github.com/users/alexrp/events{/privacy}","received_events_url":"https://api.github.com/users/alexrp/received_events","type":"User","site_admin":false},"body":"Why exactly do we need this? The `Volatile` class in Mono is `internal` when building in the 4.0 profile, so this code should just work.\r\n\r\nIn general, `Thread.VolatileWrite` and `Thread.VolatileRead` should be avoided. They're broken and misleading.","created_at":"2014-12-03T18:19:46Z","updated_at":"2014-12-03T18:19:46Z","html_url":"https://github.com/mono/referencesource/pull/2#discussion_r21252212","pull_request_url":"https://api.github.com/repos/mono/referencesource/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/mono/referencesource/pulls/comments/21252212"},"html":{"href":"https://github.com/mono/referencesource/pull/2#discussion_r21252212"},"pull_request":{"href":"https://api.github.com/repos/mono/referencesource/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/mono/referencesource/pulls/2","id":25359663,"html_url":"https://github.com/mono/referencesource/pull/2","diff_url":"https://github.com/mono/referencesource/pull/2.diff","patch_url":"https://github.com/mono/referencesource/pull/2.patch","issue_url":"https://api.github.com/repos/mono/referencesource/issues/2","number":2,"state":"closed","locked":false,"title":"[System.Core] ReaderWriterLockSlim.cs now builds with mono.","user":{"login":"esdrubal","id":1188095,"avatar_url":"https://avatars.githubusercontent.com/u/1188095?v=3","gravatar_id":"","url":"https://api.github.com/users/esdrubal","html_url":"https://github.com/esdrubal","followers_url":"https://api.github.com/users/esdrubal/followers","following_url":"https://api.github.com/users/esdrubal/following{/other_user}","gists_url":"https://api.github.com/users/esdrubal/gists{/gist_id}","starred_url":"https://api.github.com/users/esdrubal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esdrubal/subscriptions","organizations_url":"https://api.github.com/users/esdrubal/orgs","repos_url":"https://api.github.com/users/esdrubal/repos","events_url":"https://api.github.com/users/esdrubal/events{/privacy}","received_events_url":"https://api.github.com/users/esdrubal/received_events","type":"User","site_admin":false},"body":"* Builds without [MethodImpl(MethodImplOptions.AggressiveInlining)]\r\n  when target framework version is lower than 4.5.\r\n\r\n* Use Thread.Volatile instead of Volatile.Read when target framework\r\n  version is lower than 4.5.\r\n\r\nRequired by mono/mono#1436","created_at":"2014-12-02T17:38:53Z","updated_at":"2014-12-03T18:19:46Z","closed_at":"2014-12-03T14:46:00Z","merged_at":"2014-12-03T14:46:00Z","merge_commit_sha":"f454ce72587af884ac2352da7c53f2cd77edc080","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mono/referencesource/pulls/2/commits","review_comments_url":"https://api.github.com/repos/mono/referencesource/pulls/2/comments","review_comment_url":"https://api.github.com/repos/mono/referencesource/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mono/referencesource/issues/2/comments","statuses_url":"https://api.github.com/repos/mono/referencesource/statuses/10aeab0df6df7cc5e5b81287c7684a845b9c9aab","head":{"label":"esdrubal:readerwriterlockslim","ref":"readerwriterlockslim","sha":"10aeab0df6df7cc5e5b81287c7684a845b9c9aab","user":{"login":"esdrubal","id":1188095,"avatar_url":"https://avatars.githubusercontent.com/u/1188095?v=3","gravatar_id":"","url":"https://api.github.com/users/esdrubal","html_url":"https://github.com/esdrubal","followers_url":"https://api.github.com/users/esdrubal/followers","following_url":"https://api.github.com/users/esdrubal/following{/other_user}","gists_url":"https://api.github.com/users/esdrubal/gists{/gist_id}","starred_url":"https://api.github.com/users/esdrubal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esdrubal/subscriptions","organizations_url":"https://api.github.com/users/esdrubal/orgs","repos_url":"https://api.github.com/users/esdrubal/repos","events_url":"https://api.github.com/users/esdrubal/events{/privacy}","received_events_url":"https://api.github.com/users/esdrubal/received_events","type":"User","site_admin":false},"repo":{"id":27444657,"name":"referencesource","full_name":"esdrubal/referencesource","owner":{"login":"esdrubal","id":1188095,"avatar_url":"https://avatars.githubusercontent.com/u/1188095?v=3","gravatar_id":"","url":"https://api.github.com/users/esdrubal","html_url":"https://github.com/esdrubal","followers_url":"https://api.github.com/users/esdrubal/followers","following_url":"https://api.github.com/users/esdrubal/following{/other_user}","gists_url":"https://api.github.com/users/esdrubal/gists{/gist_id}","starred_url":"https://api.github.com/users/esdrubal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esdrubal/subscriptions","organizations_url":"https://api.github.com/users/esdrubal/orgs","repos_url":"https://api.github.com/users/esdrubal/repos","events_url":"https://api.github.com/users/esdrubal/events{/privacy}","received_events_url":"https://api.github.com/users/esdrubal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/esdrubal/referencesource","description":"Source from the Microsoft .NET Reference Source that represent a subset of the .NET Framework","fork":true,"url":"https://api.github.com/repos/esdrubal/referencesource","forks_url":"https://api.github.com/repos/esdrubal/referencesource/forks","keys_url":"https://api.github.com/repos/esdrubal/referencesource/keys{/key_id}","collaborators_url":"https://api.github.com/repos/esdrubal/referencesource/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/esdrubal/referencesource/teams","hooks_url":"https://api.github.com/repos/esdrubal/referencesource/hooks","issue_events_url":"https://api.github.com/repos/esdrubal/referencesource/issues/events{/number}","events_url":"https://api.github.com/repos/esdrubal/referencesource/events","assignees_url":"https://api.github.com/repos/esdrubal/referencesource/assignees{/user}","branches_url":"https://api.github.com/repos/esdrubal/referencesource/branches{/branch}","tags_url":"https://api.github.com/repos/esdrubal/referencesource/tags","blobs_url":"https://api.github.com/repos/esdrubal/referencesource/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/esdrubal/referencesource/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/esdrubal/referencesource/git/refs{/sha}","trees_url":"https://api.github.com/repos/esdrubal/referencesource/git/trees{/sha}","statuses_url":"https://api.github.com/repos/esdrubal/referencesource/statuses/{sha}","languages_url":"https://api.github.com/repos/esdrubal/referencesource/languages","stargazers_url":"https://api.github.com/repos/esdrubal/referencesource/stargazers","contributors_url":"https://api.github.com/repos/esdrubal/referencesource/contributors","subscribers_url":"https://api.github.com/repos/esdrubal/referencesource/subscribers","subscription_url":"https://api.github.com/repos/esdrubal/referencesource/subscription","commits_url":"https://api.github.com/repos/esdrubal/referencesource/commits{/sha}","git_commits_url":"https://api.github.com/repos/esdrubal/referencesource/git/commits{/sha}","comments_url":"https://api.github.com/repos/esdrubal/referencesource/comments{/number}","issue_comment_url":"https://api.github.com/repos/esdrubal/referencesource/issues/comments/{number}","contents_url":"https://api.github.com/repos/esdrubal/referencesource/contents/{+path}","compare_url":"https://api.github.com/repos/esdrubal/referencesource/compare/{base}...{head}","merges_url":"https://api.github.com/repos/esdrubal/referencesource/merges","archive_url":"https://api.github.com/repos/esdrubal/referencesource/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/esdrubal/referencesource/downloads","issues_url":"https://api.github.com/repos/esdrubal/referencesource/issues{/number}","pulls_url":"https://api.github.com/repos/esdrubal/referencesource/pulls{/number}","milestones_url":"https://api.github.com/repos/esdrubal/referencesource/milestones{/number}","notifications_url":"https://api.github.com/repos/esdrubal/referencesource/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/esdrubal/referencesource/labels{/name}","releases_url":"https://api.github.com/repos/esdrubal/referencesource/releases{/id}","created_at":"2014-12-02T17:36:25Z","updated_at":"2014-12-02T17:36:48Z","pushed_at":"2014-12-03T13:40:11Z","git_url":"git://github.com/esdrubal/referencesource.git","ssh_url":"git@github.com:esdrubal/referencesource.git","clone_url":"https://github.com/esdrubal/referencesource.git","svn_url":"https://github.com/esdrubal/referencesource","homepage":"http://referencesource.microsoft.com/","size":20809,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"mono"}},"base":{"label":"mono:mono","ref":"mono","sha":"b5edab1e7af2a54758bc184899d2ca24a7954cee","user":{"login":"mono","id":53395,"avatar_url":"https://avatars.githubusercontent.com/u/53395?v=3","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"repo":{"id":26882522,"name":"referencesource","full_name":"mono/referencesource","owner":{"login":"mono","id":53395,"avatar_url":"https://avatars.githubusercontent.com/u/53395?v=3","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mono/referencesource","description":"Source from the Microsoft .NET Reference Source that represent a subset of the .NET Framework","fork":true,"url":"https://api.github.com/repos/mono/referencesource","forks_url":"https://api.github.com/repos/mono/referencesource/forks","keys_url":"https://api.github.com/repos/mono/referencesource/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mono/referencesource/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mono/referencesource/teams","hooks_url":"https://api.github.com/repos/mono/referencesource/hooks","issue_events_url":"https://api.github.com/repos/mono/referencesource/issues/events{/number}","events_url":"https://api.github.com/repos/mono/referencesource/events","assignees_url":"https://api.github.com/repos/mono/referencesource/assignees{/user}","branches_url":"https://api.github.com/repos/mono/referencesource/branches{/branch}","tags_url":"https://api.github.com/repos/mono/referencesource/tags","blobs_url":"https://api.github.com/repos/mono/referencesource/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mono/referencesource/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mono/referencesource/git/refs{/sha}","trees_url":"https://api.github.com/repos/mono/referencesource/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mono/referencesource/statuses/{sha}","languages_url":"https://api.github.com/repos/mono/referencesource/languages","stargazers_url":"https://api.github.com/repos/mono/referencesource/stargazers","contributors_url":"https://api.github.com/repos/mono/referencesource/contributors","subscribers_url":"https://api.github.com/repos/mono/referencesource/subscribers","subscription_url":"https://api.github.com/repos/mono/referencesource/subscription","commits_url":"https://api.github.com/repos/mono/referencesource/commits{/sha}","git_commits_url":"https://api.github.com/repos/mono/referencesource/git/commits{/sha}","comments_url":"https://api.github.com/repos/mono/referencesource/comments{/number}","issue_comment_url":"https://api.github.com/repos/mono/referencesource/issues/comments/{number}","contents_url":"https://api.github.com/repos/mono/referencesource/contents/{+path}","compare_url":"https://api.github.com/repos/mono/referencesource/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mono/referencesource/merges","archive_url":"https://api.github.com/repos/mono/referencesource/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mono/referencesource/downloads","issues_url":"https://api.github.com/repos/mono/referencesource/issues{/number}","pulls_url":"https://api.github.com/repos/mono/referencesource/pulls{/number}","milestones_url":"https://api.github.com/repos/mono/referencesource/milestones{/number}","notifications_url":"https://api.github.com/repos/mono/referencesource/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mono/referencesource/labels{/name}","releases_url":"https://api.github.com/repos/mono/referencesource/releases{/id}","created_at":"2014-11-19T21:29:16Z","updated_at":"2014-12-03T14:46:24Z","pushed_at":"2014-12-03T14:46:00Z","git_url":"git://github.com/mono/referencesource.git","ssh_url":"git@github.com:mono/referencesource.git","clone_url":"https://github.com/mono/referencesource.git","svn_url":"https://github.com/mono/referencesource","homepage":"http://referencesource.microsoft.com/","size":20857,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":0,"default_branch":"mono"}},"_links":{"self":{"href":"https://api.github.com/repos/mono/referencesource/pulls/2"},"html":{"href":"https://github.com/mono/referencesource/pull/2"},"issue":{"href":"https://api.github.com/repos/mono/referencesource/issues/2"},"comments":{"href":"https://api.github.com/repos/mono/referencesource/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/mono/referencesource/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/mono/referencesource/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mono/referencesource/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/mono/referencesource/statuses/10aeab0df6df7cc5e5b81287c7684a845b9c9aab"}}}}