GitHub PullRequestReviewCommentEvent at 2014-06-03 21:59:56
Repository: phpbb
Actor: Nicofuma
Payload: {"comment":{"url":"https://api.github.com/repos/phpbb/phpbb/pulls/comments/13361738","id":13361738,"diff_hunk":"@@ -0,0 +1,126 @@\n+<?php\n+/**\n+*\n+* This file is part of the phpBB Forum Software package.\n+*\n+* @copyright (c) phpBB Limited <https://www.phpbb.com>\n+* @license GNU General Public License, version 2 (GPL-2.0)\n+*\n+* For full copyright and license information, please see\n+* the docs/CREDITS.txt file.\n+*\n+*/\n+\n+namespace phpbb\\console\\command\\update;\n+\n+use Symfony\\Component\\Console\\Input\\InputInterface;\n+use Symfony\\Component\\Console\\Input\\InputOption;\n+use Symfony\\Component\\Console\\Output\\OutputInterface;\n+use Symfony\\Component\\Console\\Tests\\Input\\InputTest;\n+\n+class check extends \\phpbb\\console\\command\\command\n+{\n+\t/** @var \\phpbb\\user */\n+\tprotected $user;\n+\n+\t/** @var \\phpbb\\config\\config */\n+\tprotected $config;\n+\n+\t/** @var \\Symfony\\Component\\DependencyInjection\\ContainerBuilder */\n+\tprotected $phpbb_container;\n+\n+\t/**\n+\t* Construct method\n+\t*/\n+\tpublic function __construct(\\phpbb\\user $user, \\phpbb\\config\\config $config, \\Symfony\\Component\\DependencyInjection\\ContainerInterface $phpbb_container)\n+\t{\n+\t\t$this->user = $user;\n+\t\t$this->config = $config;\n+\t\t$this->phpbb_container = $phpbb_container;","path":"phpBB/phpbb/console/command/update/check.php","position":39,"original_position":39,"commit_id":"6526f0fbb09fec9052ff70456780ddc23e9dba3c","original_commit_id":"6526f0fbb09fec9052ff70456780ddc23e9dba3c","user":{"login":"Nicofuma","id":591456,"avatar_url":"https://avatars.githubusercontent.com/u/591456?","gravatar_id":"4ca6947ea7c6c2303b6a4109cb931dd7","url":"https://api.github.com/users/Nicofuma","html_url":"https://github.com/Nicofuma","followers_url":"https://api.github.com/users/Nicofuma/followers","following_url":"https://api.github.com/users/Nicofuma/following{/other_user}","gists_url":"https://api.github.com/users/Nicofuma/gists{/gist_id}","starred_url":"https://api.github.com/users/Nicofuma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nicofuma/subscriptions","organizations_url":"https://api.github.com/users/Nicofuma/orgs","repos_url":"https://api.github.com/users/Nicofuma/repos","events_url":"https://api.github.com/users/Nicofuma/events{/privacy}","received_events_url":"https://api.github.com/users/Nicofuma/received_events","type":"User","site_admin":false},"body":"scope prototype always return a  new object yes, so we can't use have a dependency to a scoped prototype service in a scoped container service (http://symfony.com/doc/current/cookbook/service_container/scopes.html#using-a-service-from-a-narrower-scope)","created_at":"2014-06-03T21:59:56Z","updated_at":"2014-06-03T21:59:56Z","html_url":"https://github.com/phpbb/phpbb/pull/2540#discussion_r13361738","pull_request_url":"https://api.github.com/repos/phpbb/phpbb/pulls/2540","_links":{"self":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/comments/13361738"},"html":{"href":"https://github.com/phpbb/phpbb/pull/2540#discussion_r13361738"},"pull_request":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/2540"}}}}