GitHub PullRequestReviewCommentEvent at 2014-09-08 10:46:15
Repository: opentxs
Actor: murrekatt
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Open-Transactions/opentxs/pulls/comments/17231219","id":17231219,"diff_hunk":"@@ -884,12 +884,12 @@ class OTTransactionType : public OTContract\n     // with m_ID (supposedly the same number.)\n     // Also Verifies the ServerID, since this object type is all about the both\n     // of those IDs.\n-    EXPORT virtual bool VerifyContractID();\n+    EXPORT virtual bool VerifyContractID() const;","path":"include/opentxs/core/OTTransactionType.hpp","position":5,"original_position":5,"commit_id":"d88da79c2dd05532aa1efec572717d935fe368d2","original_commit_id":"d88da79c2dd05532aa1efec572717d935fe368d2","user":{"login":"murrekatt","id":7213,"avatar_url":"https://avatars.githubusercontent.com/u/7213?v=2","gravatar_id":"aa6285532343827af4b4811de7d52277","url":"https://api.github.com/users/murrekatt","html_url":"https://github.com/murrekatt","followers_url":"https://api.github.com/users/murrekatt/followers","following_url":"https://api.github.com/users/murrekatt/following{/other_user}","gists_url":"https://api.github.com/users/murrekatt/gists{/gist_id}","starred_url":"https://api.github.com/users/murrekatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/murrekatt/subscriptions","organizations_url":"https://api.github.com/users/murrekatt/orgs","repos_url":"https://api.github.com/users/murrekatt/repos","events_url":"https://api.github.com/users/murrekatt/events{/privacy}","received_events_url":"https://api.github.com/users/murrekatt/received_events","type":"User","site_admin":false},"body":"This is a problem - needs update in at least OTTransaction.","created_at":"2014-09-08T10:46:15Z","updated_at":"2014-09-08T10:46:15Z","html_url":"https://github.com/Open-Transactions/opentxs/pull/130#discussion_r17231219","pull_request_url":"https://api.github.com/repos/Open-Transactions/opentxs/pulls/130","_links":{"self":{"href":"https://api.github.com/repos/Open-Transactions/opentxs/pulls/comments/17231219"},"html":{"href":"https://github.com/Open-Transactions/opentxs/pull/130#discussion_r17231219"},"pull_request":{"href":"https://api.github.com/repos/Open-Transactions/opentxs/pulls/130"}}},"pull_request":{"url":"https://api.github.com/repos/Open-Transactions/opentxs/pulls/130","id":20868312,"html_url":"https://github.com/Open-Transactions/opentxs/pull/130","diff_url":"https://github.com/Open-Transactions/opentxs/pull/130.diff","patch_url":"https://github.com/Open-Transactions/opentxs/pull/130.patch","issue_url":"https://api.github.com/repos/Open-Transactions/opentxs/issues/130","number":130,"state":"closed","locked":false,"title":"Const correct opentxs.client","user":{"login":"BugFreeSoftware","id":2214263,"avatar_url":"https://avatars.githubusercontent.com/u/2214263?v=2","gravatar_id":"4e872d3acdc51e87376b346165cf2431","url":"https://api.github.com/users/BugFreeSoftware","html_url":"https://github.com/BugFreeSoftware","followers_url":"https://api.github.com/users/BugFreeSoftware/followers","following_url":"https://api.github.com/users/BugFreeSoftware/following{/other_user}","gists_url":"https://api.github.com/users/BugFreeSoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/BugFreeSoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BugFreeSoftware/subscriptions","organizations_url":"https://api.github.com/users/BugFreeSoftware/orgs","repos_url":"https://api.github.com/users/BugFreeSoftware/repos","events_url":"https://api.github.com/users/BugFreeSoftware/events{/privacy}","received_events_url":"https://api.github.com/users/BugFreeSoftware/received_events","type":"User","site_admin":false},"body":"Phase 2 of Rubens's const correctness pass on opentxs.client.\r\nDue to the recursive nature of fixing const correctness there is a spill over effect into opentxs.core\r\nHe will continue in phase 3 with making opentxs.core member functions const where possible.","created_at":"2014-09-08T02:43:19Z","updated_at":"2014-09-08T10:46:15Z","closed_at":"2014-09-08T07:27:44Z","merged_at":"2014-09-08T07:27:44Z","merge_commit_sha":"803ac8a959db8edf63ee95e26c9ee02d43d5a659","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Open-Transactions/opentxs/pulls/130/commits","review_comments_url":"https://api.github.com/repos/Open-Transactions/opentxs/pulls/130/comments","review_comment_url":"https://api.github.com/repos/Open-Transactions/opentxs/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Open-Transactions/opentxs/issues/130/comments","statuses_url":"https://api.github.com/repos/Open-Transactions/opentxs/statuses/d88da79c2dd05532aa1efec572717d935fe368d2","head":{"label":"BugFreeSoftware:const2","ref":"const2","sha":"d88da79c2dd05532aa1efec572717d935fe368d2","user":{"login":"BugFreeSoftware","id":2214263,"avatar_url":"https://avatars.githubusercontent.com/u/2214263?v=2","gravatar_id":"4e872d3acdc51e87376b346165cf2431","url":"https://api.github.com/users/BugFreeSoftware","html_url":"https://github.com/BugFreeSoftware","followers_url":"https://api.github.com/users/BugFreeSoftware/followers","following_url":"https://api.github.com/users/BugFreeSoftware/following{/other_user}","gists_url":"https://api.github.com/users/BugFreeSoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/BugFreeSoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BugFreeSoftware/subscriptions","organizations_url":"https://api.github.com/users/BugFreeSoftware/orgs","repos_url":"https://api.github.com/users/BugFreeSoftware/repos","events_url":"https://api.github.com/users/BugFreeSoftware/events{/privacy}","received_events_url":"https://api.github.com/users/BugFreeSoftware/received_events","type":"User","site_admin":false},"repo":{"id":22763847,"name":"opentxs","full_name":"BugFreeSoftware/opentxs","owner":{"login":"BugFreeSoftware","id":2214263,"avatar_url":"https://avatars.githubusercontent.com/u/2214263?v=2","gravatar_id":"4e872d3acdc51e87376b346165cf2431","url":"https://api.github.com/users/BugFreeSoftware","html_url":"https://github.com/BugFreeSoftware","followers_url":"https://api.github.com/users/BugFreeSoftware/followers","following_url":"https://api.github.com/users/BugFreeSoftware/following{/other_user}","gists_url":"https://api.github.com/users/BugFreeSoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/BugFreeSoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BugFreeSoftware/subscriptions","organizations_url":"https://api.github.com/users/BugFreeSoftware/orgs","repos_url":"https://api.github.com/users/BugFreeSoftware/repos","events_url":"https://api.github.com/users/BugFreeSoftware/events{/privacy}","received_events_url":"https://api.github.com/users/BugFreeSoftware/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BugFreeSoftware/opentxs","description":"Open Transactions - Libraries and CLI","fork":true,"url":"https://api.github.com/repos/BugFreeSoftware/opentxs","forks_url":"https://api.github.com/repos/BugFreeSoftware/opentxs/forks","keys_url":"https://api.github.com/repos/BugFreeSoftware/opentxs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BugFreeSoftware/opentxs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BugFreeSoftware/opentxs/teams","hooks_url":"https://api.github.com/repos/BugFreeSoftware/opentxs/hooks","issue_events_url":"https://api.github.com/repos/BugFreeSoftware/opentxs/issues/events{/number}","events_url":"https://api.github.com/repos/BugFreeSoftware/opentxs/events","assignees_url":"https://api.github.com/repos/BugFreeSoftware/opentxs/assignees{/user}","branches_url":"https://api.github.com/repos/BugFreeSoftware/opentxs/branches{/branch}","tags_url":"https://api.github.com/repos/BugFreeSoftware/opentxs/tags","blobs_url":"https://api.github.com/repos/BugFreeSoftware/opentxs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BugFreeSoftware/opentxs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BugFreeSoftware/opentxs/git/refs{/sha}","trees_url":"https://api.github.com/repos/BugFreeSoftware/opentxs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BugFreeSoftware/opentxs/statuses/{sha}","languages_url":"https://api.github.com/repos/BugFreeSoftware/opentxs/languages","stargazers_url":"https://api.github.com/repos/BugFreeSoftware/opentxs/stargazers","contributors_url":"https://api.github.com/repos/BugFreeSoftware/opentxs/contributors","subscribers_url":"https://api.github.com/repos/BugFreeSoftware/opentxs/subscribers","subscription_url":"https://api.github.com/repos/BugFreeSoftware/opentxs/subscription","commits_url":"https://api.github.com/repos/BugFreeSoftware/opentxs/commits{/sha}","git_commits_url":"https://api.github.com/repos/BugFreeSoftware/opentxs/git/commits{/sha}","comments_url":"https://api.github.com/repos/BugFreeSoftware/opentxs/comments{/number}","issue_comment_url":"https://api.github.com/repos/BugFreeSoftware/opentxs/issues/comments/{number}","contents_url":"https://api.github.com/repos/BugFreeSoftware/opentxs/contents/{+path}","compare_url":"https://api.github.com/repos/BugFreeSoftware/opentxs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BugFreeSoftware/opentxs/merges","archive_url":"https://api.github.com/repos/BugFreeSoftware/opentxs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BugFreeSoftware/opentxs/downloads","issues_url":"https://api.github.com/repos/BugFreeSoftware/opentxs/issues{/number}","pulls_url":"https://api.github.com/repos/BugFreeSoftware/opentxs/pulls{/number}","milestones_url":"https://api.github.com/repos/BugFreeSoftware/opentxs/milestones{/number}","notifications_url":"https://api.github.com/repos/BugFreeSoftware/opentxs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BugFreeSoftware/opentxs/labels{/name}","releases_url":"https://api.github.com/repos/BugFreeSoftware/opentxs/releases{/id}","created_at":"2014-08-08T16:18:13Z","updated_at":"2014-08-10T05:04:16Z","pushed_at":"2014-09-08T05:39:13Z","git_url":"git://github.com/BugFreeSoftware/opentxs.git","ssh_url":"git@github.com:BugFreeSoftware/opentxs.git","clone_url":"https://github.com/BugFreeSoftware/opentxs.git","svn_url":"https://github.com/BugFreeSoftware/opentxs","homepage":null,"size":37587,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"Open-Transactions:develop","ref":"develop","sha":"17544bfdd46cc0a4eca25276c478500e33c88318","user":{"login":"Open-Transactions","id":4221800,"avatar_url":"https://avatars.githubusercontent.com/u/4221800?v=2","gravatar_id":null,"url":"https://api.github.com/users/Open-Transactions","html_url":"https://github.com/Open-Transactions","followers_url":"https://api.github.com/users/Open-Transactions/followers","following_url":"https://api.github.com/users/Open-Transactions/following{/other_user}","gists_url":"https://api.github.com/users/Open-Transactions/gists{/gist_id}","starred_url":"https://api.github.com/users/Open-Transactions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Open-Transactions/subscriptions","organizations_url":"https://api.github.com/users/Open-Transactions/orgs","repos_url":"https://api.github.com/users/Open-Transactions/repos","events_url":"https://api.github.com/users/Open-Transactions/events{/privacy}","received_events_url":"https://api.github.com/users/Open-Transactions/received_events","type":"Organization","site_admin":false},"repo":{"id":22756749,"name":"opentxs","full_name":"Open-Transactions/opentxs","owner":{"login":"Open-Transactions","id":4221800,"avatar_url":"https://avatars.githubusercontent.com/u/4221800?v=2","gravatar_id":null,"url":"https://api.github.com/users/Open-Transactions","html_url":"https://github.com/Open-Transactions","followers_url":"https://api.github.com/users/Open-Transactions/followers","following_url":"https://api.github.com/users/Open-Transactions/following{/other_user}","gists_url":"https://api.github.com/users/Open-Transactions/gists{/gist_id}","starred_url":"https://api.github.com/users/Open-Transactions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Open-Transactions/subscriptions","organizations_url":"https://api.github.com/users/Open-Transactions/orgs","repos_url":"https://api.github.com/users/Open-Transactions/repos","events_url":"https://api.github.com/users/Open-Transactions/events{/privacy}","received_events_url":"https://api.github.com/users/Open-Transactions/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Open-Transactions/opentxs","description":"Open Transactions - Libraries and CLI","fork":false,"url":"https://api.github.com/repos/Open-Transactions/opentxs","forks_url":"https://api.github.com/repos/Open-Transactions/opentxs/forks","keys_url":"https://api.github.com/repos/Open-Transactions/opentxs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Open-Transactions/opentxs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Open-Transactions/opentxs/teams","hooks_url":"https://api.github.com/repos/Open-Transactions/opentxs/hooks","issue_events_url":"https://api.github.com/repos/Open-Transactions/opentxs/issues/events{/number}","events_url":"https://api.github.com/repos/Open-Transactions/opentxs/events","assignees_url":"https://api.github.com/repos/Open-Transactions/opentxs/assignees{/user}","branches_url":"https://api.github.com/repos/Open-Transactions/opentxs/branches{/branch}","tags_url":"https://api.github.com/repos/Open-Transactions/opentxs/tags","blobs_url":"https://api.github.com/repos/Open-Transactions/opentxs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Open-Transactions/opentxs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Open-Transactions/opentxs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Open-Transactions/opentxs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Open-Transactions/opentxs/statuses/{sha}","languages_url":"https://api.github.com/repos/Open-Transactions/opentxs/languages","stargazers_url":"https://api.github.com/repos/Open-Transactions/opentxs/stargazers","contributors_url":"https://api.github.com/repos/Open-Transactions/opentxs/contributors","subscribers_url":"https://api.github.com/repos/Open-Transactions/opentxs/subscribers","subscription_url":"https://api.github.com/repos/Open-Transactions/opentxs/subscription","commits_url":"https://api.github.com/repos/Open-Transactions/opentxs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Open-Transactions/opentxs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Open-Transactions/opentxs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Open-Transactions/opentxs/issues/comments/{number}","contents_url":"https://api.github.com/repos/Open-Transactions/opentxs/contents/{+path}","compare_url":"https://api.github.com/repos/Open-Transactions/opentxs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Open-Transactions/opentxs/merges","archive_url":"https://api.github.com/repos/Open-Transactions/opentxs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Open-Transactions/opentxs/downloads","issues_url":"https://api.github.com/repos/Open-Transactions/opentxs/issues{/number}","pulls_url":"https://api.github.com/repos/Open-Transactions/opentxs/pulls{/number}","milestones_url":"https://api.github.com/repos/Open-Transactions/opentxs/milestones{/number}","notifications_url":"https://api.github.com/repos/Open-Transactions/opentxs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Open-Transactions/opentxs/labels{/name}","releases_url":"https://api.github.com/repos/Open-Transactions/opentxs/releases{/id}","created_at":"2014-08-08T12:13:23Z","updated_at":"2014-09-05T06:18:35Z","pushed_at":"2014-09-08T09:19:00Z","git_url":"git://github.com/Open-Transactions/opentxs.git","ssh_url":"git@github.com:Open-Transactions/opentxs.git","clone_url":"https://github.com/Open-Transactions/opentxs.git","svn_url":"https://github.com/Open-Transactions/opentxs","homepage":null,"size":38332,"stargazers_count":4,"watchers_count":4,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":9,"mirror_url":null,"open_issues_count":35,"forks":9,"open_issues":35,"watchers":4,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Open-Transactions/opentxs/pulls/130"},"html":{"href":"https://github.com/Open-Transactions/opentxs/pull/130"},"issue":{"href":"https://api.github.com/repos/Open-Transactions/opentxs/issues/130"},"comments":{"href":"https://api.github.com/repos/Open-Transactions/opentxs/issues/130/comments"},"review_comments":{"href":"https://api.github.com/repos/Open-Transactions/opentxs/pulls/130/comments"},"review_comment":{"href":"https://api.github.com/repos/Open-Transactions/opentxs/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Open-Transactions/opentxs/pulls/130/commits"},"statuses":{"href":"https://api.github.com/repos/Open-Transactions/opentxs/statuses/d88da79c2dd05532aa1efec572717d935fe368d2"}}}}