GitHub PullRequestReviewCommentEvent at 2014-11-12 21:41:17
Repository: node
Actor: bminer
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/joyent/node/pulls/comments/20253893","id":20253893,"diff_hunk":"@@ -635,6 +635,8 @@ function Server(/* [options], listener */) {\n     });\n \n     socket.on('secure', function() {\n+      // enable normal socket timeout after handshake\n+      socket.setTimeout(self.timeout | 0);","path":"lib/_tls_wrap.js","position":5,"original_position":5,"commit_id":"c601b3a130d71af3e47b432bfc00309f60c4310b","original_commit_id":"c601b3a130d71af3e47b432bfc00309f60c4310b","user":{"login":"bminer","id":73755,"avatar_url":"https://avatars.githubusercontent.com/u/73755?v=3","gravatar_id":"","url":"https://api.github.com/users/bminer","html_url":"https://github.com/bminer","followers_url":"https://api.github.com/users/bminer/followers","following_url":"https://api.github.com/users/bminer/following{/other_user}","gists_url":"https://api.github.com/users/bminer/gists{/gist_id}","starred_url":"https://api.github.com/users/bminer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bminer/subscriptions","organizations_url":"https://api.github.com/users/bminer/orgs","repos_url":"https://api.github.com/users/bminer/repos","events_url":"https://api.github.com/users/bminer/events{/privacy}","received_events_url":"https://api.github.com/users/bminer/received_events","type":"User","site_admin":false},"body":"Are you suggesting this: `socket.setTimeout((self.timeout >>> 0) | 0);`\r\n\r\nOr, should I just leave it alone?","created_at":"2014-11-12T21:41:17Z","updated_at":"2014-11-12T21:41:17Z","html_url":"https://github.com/joyent/node/pull/8021#discussion_r20253893","pull_request_url":"https://api.github.com/repos/joyent/node/pulls/8021","_links":{"self":{"href":"https://api.github.com/repos/joyent/node/pulls/comments/20253893"},"html":{"href":"https://github.com/joyent/node/pull/8021#discussion_r20253893"},"pull_request":{"href":"https://api.github.com/repos/joyent/node/pulls/8021"}}},"pull_request":{"url":"https://api.github.com/repos/joyent/node/pulls/8021","id":19043911,"html_url":"https://github.com/joyent/node/pull/8021","diff_url":"https://github.com/joyent/node/pull/8021.diff","patch_url":"https://github.com/joyent/node/pull/8021.patch","issue_url":"https://api.github.com/repos/joyent/node/issues/8021","number":8021,"state":"open","locked":false,"title":"tls: Server should honor previous \"timeout\" listeners","user":{"login":"bminer","id":73755,"avatar_url":"https://avatars.githubusercontent.com/u/73755?v=3","gravatar_id":"","url":"https://api.github.com/users/bminer","html_url":"https://github.com/bminer","followers_url":"https://api.github.com/users/bminer/followers","following_url":"https://api.github.com/users/bminer/following{/other_user}","gists_url":"https://api.github.com/users/bminer/gists{/gist_id}","starred_url":"https://api.github.com/users/bminer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bminer/subscriptions","organizations_url":"https://api.github.com/users/bminer/orgs","repos_url":"https://api.github.com/users/bminer/repos","events_url":"https://api.github.com/users/bminer/events{/privacy}","received_events_url":"https://api.github.com/users/bminer/received_events","type":"User","site_admin":false},"body":"This fixes #7764 and allows HTTPS servers to follow the same socket timeout behavior as HTTP servers.","created_at":"2014-07-29T18:09:48Z","updated_at":"2014-11-12T21:41:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fd35ee71315e040a9cbe60f7a79e9e37bd3b1f13","assignee":{"login":"indutny","id":238531,"avatar_url":"https://avatars.githubusercontent.com/u/238531?v=3","gravatar_id":"","url":"https://api.github.com/users/indutny","html_url":"https://github.com/indutny","followers_url":"https://api.github.com/users/indutny/followers","following_url":"https://api.github.com/users/indutny/following{/other_user}","gists_url":"https://api.github.com/users/indutny/gists{/gist_id}","starred_url":"https://api.github.com/users/indutny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indutny/subscriptions","organizations_url":"https://api.github.com/users/indutny/orgs","repos_url":"https://api.github.com/users/indutny/repos","events_url":"https://api.github.com/users/indutny/events{/privacy}","received_events_url":"https://api.github.com/users/indutny/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/joyent/node/pulls/8021/commits","review_comments_url":"https://api.github.com/repos/joyent/node/pulls/8021/comments","review_comment_url":"https://api.github.com/repos/joyent/node/pulls/comments/{number}","comments_url":"https://api.github.com/repos/joyent/node/issues/8021/comments","statuses_url":"https://api.github.com/repos/joyent/node/statuses/c601b3a130d71af3e47b432bfc00309f60c4310b","head":{"label":"bminer:patch-1","ref":"patch-1","sha":"c601b3a130d71af3e47b432bfc00309f60c4310b","user":{"login":"bminer","id":73755,"avatar_url":"https://avatars.githubusercontent.com/u/73755?v=3","gravatar_id":"","url":"https://api.github.com/users/bminer","html_url":"https://github.com/bminer","followers_url":"https://api.github.com/users/bminer/followers","following_url":"https://api.github.com/users/bminer/following{/other_user}","gists_url":"https://api.github.com/users/bminer/gists{/gist_id}","starred_url":"https://api.github.com/users/bminer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bminer/subscriptions","organizations_url":"https://api.github.com/users/bminer/orgs","repos_url":"https://api.github.com/users/bminer/repos","events_url":"https://api.github.com/users/bminer/events{/privacy}","received_events_url":"https://api.github.com/users/bminer/received_events","type":"User","site_admin":false},"repo":{"id":22389470,"name":"node","full_name":"bminer/node","owner":{"login":"bminer","id":73755,"avatar_url":"https://avatars.githubusercontent.com/u/73755?v=3","gravatar_id":"","url":"https://api.github.com/users/bminer","html_url":"https://github.com/bminer","followers_url":"https://api.github.com/users/bminer/followers","following_url":"https://api.github.com/users/bminer/following{/other_user}","gists_url":"https://api.github.com/users/bminer/gists{/gist_id}","starred_url":"https://api.github.com/users/bminer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bminer/subscriptions","organizations_url":"https://api.github.com/users/bminer/orgs","repos_url":"https://api.github.com/users/bminer/repos","events_url":"https://api.github.com/users/bminer/events{/privacy}","received_events_url":"https://api.github.com/users/bminer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bminer/node","description":"evented I/O for v8 javascript","fork":true,"url":"https://api.github.com/repos/bminer/node","forks_url":"https://api.github.com/repos/bminer/node/forks","keys_url":"https://api.github.com/repos/bminer/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bminer/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bminer/node/teams","hooks_url":"https://api.github.com/repos/bminer/node/hooks","issue_events_url":"https://api.github.com/repos/bminer/node/issues/events{/number}","events_url":"https://api.github.com/repos/bminer/node/events","assignees_url":"https://api.github.com/repos/bminer/node/assignees{/user}","branches_url":"https://api.github.com/repos/bminer/node/branches{/branch}","tags_url":"https://api.github.com/repos/bminer/node/tags","blobs_url":"https://api.github.com/repos/bminer/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bminer/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bminer/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/bminer/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bminer/node/statuses/{sha}","languages_url":"https://api.github.com/repos/bminer/node/languages","stargazers_url":"https://api.github.com/repos/bminer/node/stargazers","contributors_url":"https://api.github.com/repos/bminer/node/contributors","subscribers_url":"https://api.github.com/repos/bminer/node/subscribers","subscription_url":"https://api.github.com/repos/bminer/node/subscription","commits_url":"https://api.github.com/repos/bminer/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/bminer/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/bminer/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/bminer/node/issues/comments/{number}","contents_url":"https://api.github.com/repos/bminer/node/contents/{+path}","compare_url":"https://api.github.com/repos/bminer/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bminer/node/merges","archive_url":"https://api.github.com/repos/bminer/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bminer/node/downloads","issues_url":"https://api.github.com/repos/bminer/node/issues{/number}","pulls_url":"https://api.github.com/repos/bminer/node/pulls{/number}","milestones_url":"https://api.github.com/repos/bminer/node/milestones{/number}","notifications_url":"https://api.github.com/repos/bminer/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bminer/node/labels{/name}","releases_url":"https://api.github.com/repos/bminer/node/releases{/id}","created_at":"2014-07-29T17:48:35Z","updated_at":"2014-07-29T18:09:39Z","pushed_at":"2014-11-11T19:13:58Z","git_url":"git://github.com/bminer/node.git","ssh_url":"git@github.com:bminer/node.git","clone_url":"https://github.com/bminer/node.git","svn_url":"https://github.com/bminer/node","homepage":"http://nodejs.org/","size":103863,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"joyent:master","ref":"master","sha":"7166b55015261de8ab69758320f3d9159b3eaadd","user":{"login":"joyent","id":10161,"avatar_url":"https://avatars.githubusercontent.com/u/10161?v=3","gravatar_id":"","url":"https://api.github.com/users/joyent","html_url":"https://github.com/joyent","followers_url":"https://api.github.com/users/joyent/followers","following_url":"https://api.github.com/users/joyent/following{/other_user}","gists_url":"https://api.github.com/users/joyent/gists{/gist_id}","starred_url":"https://api.github.com/users/joyent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joyent/subscriptions","organizations_url":"https://api.github.com/users/joyent/orgs","repos_url":"https://api.github.com/users/joyent/repos","events_url":"https://api.github.com/users/joyent/events{/privacy}","received_events_url":"https://api.github.com/users/joyent/received_events","type":"Organization","site_admin":false},"repo":{"id":211666,"name":"node","full_name":"joyent/node","owner":{"login":"joyent","id":10161,"avatar_url":"https://avatars.githubusercontent.com/u/10161?v=3","gravatar_id":"","url":"https://api.github.com/users/joyent","html_url":"https://github.com/joyent","followers_url":"https://api.github.com/users/joyent/followers","following_url":"https://api.github.com/users/joyent/following{/other_user}","gists_url":"https://api.github.com/users/joyent/gists{/gist_id}","starred_url":"https://api.github.com/users/joyent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joyent/subscriptions","organizations_url":"https://api.github.com/users/joyent/orgs","repos_url":"https://api.github.com/users/joyent/repos","events_url":"https://api.github.com/users/joyent/events{/privacy}","received_events_url":"https://api.github.com/users/joyent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joyent/node","description":"evented I/O for v8 javascript","fork":false,"url":"https://api.github.com/repos/joyent/node","forks_url":"https://api.github.com/repos/joyent/node/forks","keys_url":"https://api.github.com/repos/joyent/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joyent/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joyent/node/teams","hooks_url":"https://api.github.com/repos/joyent/node/hooks","issue_events_url":"https://api.github.com/repos/joyent/node/issues/events{/number}","events_url":"https://api.github.com/repos/joyent/node/events","assignees_url":"https://api.github.com/repos/joyent/node/assignees{/user}","branches_url":"https://api.github.com/repos/joyent/node/branches{/branch}","tags_url":"https://api.github.com/repos/joyent/node/tags","blobs_url":"https://api.github.com/repos/joyent/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joyent/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joyent/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/joyent/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joyent/node/statuses/{sha}","languages_url":"https://api.github.com/repos/joyent/node/languages","stargazers_url":"https://api.github.com/repos/joyent/node/stargazers","contributors_url":"https://api.github.com/repos/joyent/node/contributors","subscribers_url":"https://api.github.com/repos/joyent/node/subscribers","subscription_url":"https://api.github.com/repos/joyent/node/subscription","commits_url":"https://api.github.com/repos/joyent/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/joyent/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/joyent/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/joyent/node/issues/comments/{number}","contents_url":"https://api.github.com/repos/joyent/node/contents/{+path}","compare_url":"https://api.github.com/repos/joyent/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joyent/node/merges","archive_url":"https://api.github.com/repos/joyent/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joyent/node/downloads","issues_url":"https://api.github.com/repos/joyent/node/issues{/number}","pulls_url":"https://api.github.com/repos/joyent/node/pulls{/number}","milestones_url":"https://api.github.com/repos/joyent/node/milestones{/number}","notifications_url":"https://api.github.com/repos/joyent/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joyent/node/labels{/name}","releases_url":"https://api.github.com/repos/joyent/node/releases{/id}","created_at":"2009-05-27T16:29:46Z","updated_at":"2014-11-12T19:27:12Z","pushed_at":"2014-11-12T21:23:08Z","git_url":"git://github.com/joyent/node.git","ssh_url":"git@github.com:joyent/node.git","clone_url":"https://github.com/joyent/node.git","svn_url":"https://github.com/joyent/node","homepage":"http://nodejs.org/","size":500165,"stargazers_count":33095,"watchers_count":33095,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":7391,"mirror_url":null,"open_issues_count":1014,"forks":7391,"open_issues":1014,"watchers":33095,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/joyent/node/pulls/8021"},"html":{"href":"https://github.com/joyent/node/pull/8021"},"issue":{"href":"https://api.github.com/repos/joyent/node/issues/8021"},"comments":{"href":"https://api.github.com/repos/joyent/node/issues/8021/comments"},"review_comments":{"href":"https://api.github.com/repos/joyent/node/pulls/8021/comments"},"review_comment":{"href":"https://api.github.com/repos/joyent/node/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/joyent/node/pulls/8021/commits"},"statuses":{"href":"https://api.github.com/repos/joyent/node/statuses/c601b3a130d71af3e47b432bfc00309f60c4310b"}}}}