GitHub PullRequestReviewCommentEvent at 2014-05-08 16:19:50
Repository: kibana
Actor: Alex-Ikanow
Payload: {"comment":{"url":"https://api.github.com/repos/Alex-Ikanow/kibana/pulls/comments/12437694","id":12437694,"diff_hunk":"@@ -1,54 +1,139 @@\n-<!DOCTYPE html>\n-<!--[if lt IE 7]>      <html class=\"no-js lt-ie9 lt-ie8 lt-ie7\"> <![endif]-->\n-<!--[if IE 7]>         <html class=\"no-js lt-ie9 lt-ie8\"> <![endif]-->\n-<!--[if IE 8]>         <html class=\"no-js lt-ie9\"> <![endif]-->\n-<!--[if gt IE 8]><!--> <html class=\"no-js\"> <!--<![endif]-->\n-  <head>\n-    <meta charset=\"utf-8\">\n-    <meta http-equiv=\"X-UA-Compatible\" content=\"IE=edge,chrome=1\">\n-    <meta name=\"viewport\" content=\"width=device-width\">\n-\n-    <title>Kibana 3{{dashboard.current.title ? \" - \"+dashboard.current.title : \"\"}}</title>\n-    <link rel=\"stylesheet\" href=\"css/bootstrap.light.min.css\" title=\"Light\">\n-    <link rel=\"stylesheet\" href=\"css/timepicker.css\">\n-    <link rel=\"stylesheet\" href=\"css/animate.min.css\">\n-    <link rel=\"stylesheet\" href=\"css/normalize.min.css\">\n-    <!-- load the root require context -->\n-    <script src=\"vendor/require/require.js\"></script>\n-    <script src=\"app/components/require.config.js\"></script>\n-    <script>require(['app'], function () {})</script>\n-    <style>\n-    </style>\n-\n-  </head>\n-\n-  <body>\n-    <noscript>\n-      <div class=\"container\">\n-        <center><h3>You must enable javascript to use Kibana</h3></center>\n-      </div>\n-    </noscript>\n-    <!--<link rel=\"stylesheet\" ng-href=\"css/bootstrap.{{dashboard.current.style||'dark'}}.min.css\">-->\n-    <link rel=\"stylesheet\" ng-href=\"css/bootstrap.{{dashboard.current.style||'dark'}}.min.css\">\n-    <link rel=\"stylesheet\" href=\"css/bootstrap-responsive.min.css\">\n-    <link rel=\"stylesheet\" href=\"css/font-awesome.min.css\">\n-\n-    <div ng-cloak ng-repeat='alert in dashAlerts.list' class=\"alert-{{alert.severity}} dashboard-notice\" ng-show=\"$last\">\n-      <button type=\"button\" class=\"close\" ng-click=\"dashAlerts.clear(alert)\" style=\"padding-right:50px\">&times;</button>\n-      <strong>{{alert.title}}</strong> <span ng-bind-html='alert.text'></span> <div style=\"padding-right:10px\" class='pull-right small'> {{$index + 1}} alert(s) </div>\n-    </div>\n-    <div ng-cloak class=\"navbar navbar-static-top\">\n-      <div class=\"navbar-inner\">\n-        <div class=\"container-fluid\">\n-          <span class=\"brand\"><img src=\"img/small.png\" bs-tooltip=\"'Kibana '+(kbnVersion=='@REV@'?'master':kbnVersion)\" data-placement=\"bottom\"> {{dashboard.current.title}}</span>\n-\n-          <ul class=\"nav pull-right\" ng-controller='dashLoader' ng-init=\"init()\" ng-include=\"'app/partials/dashLoader.html'\">\n-          </ul>\n-        </div>\n-      </div>\n-    </div>\n-\n-    <div ng-cloak ng-view></div>\n-\n-  </body>\n-</html>\n+<!DOCTYPE html>\r\n+<!--[if lt IE 7]>      <html class=\"no-js lt-ie9 lt-ie8 lt-ie7\"> <![endif]-->\r\n+<!--[if IE 7]>         <html class=\"no-js lt-ie9 lt-ie8\"> <![endif]-->\r\n+<!--[if IE 8]>         <html class=\"no-js lt-ie9\"> <![endif]-->\r\n+<!--[if gt IE 8]><!--> <html class=\"no-js\"> <!--<![endif]-->\r\n+  <head>\r\n+    <meta charset=\"utf-8\">\r\n+    <meta http-equiv=\"X-UA-Compatible\" content=\"IE=edge,chrome=1\">\r\n+    <meta name=\"viewport\" content=\"width=device-width\">\r\n+\r\n+    <title>Kibana 3{{dashboard.current.title ? \" - \"+dashboard.current.title : \"\"}}</title>\r\n+    <link rel=\"stylesheet\" href=\"css/bootstrap.light.min.css\" title=\"Light\">\r\n+    <link rel=\"stylesheet\" href=\"css/timepicker.css\">\r\n+    <link rel=\"stylesheet\" href=\"css/animate.min.css\">\r\n+    <link rel=\"stylesheet\" href=\"css/normalize.min.css\">\r\n+    <!-- load the root require context -->\r\n+    <script src=\"vendor/require/require.js\"></script>\r\n+    <script src=\"app/components/require.config.js\"></script>\r\n+\t<script src=\"infinit.e.js\"></script>\r\n+\t<script src=\"jquery.js\"></script>\r\n+    <script>\r\n+\t\trequire(['app'], function (app) {\r\n+\t\t\tapp.config(function($httpProvider){\r\n+\t\t\t\t   $httpProvider.interceptors.push('myHttpInterceptor');\r\n+\t\t\t\t\t\t   $httpProvider.defaults.withCredentials = true;\r\n+\t\t\t})\r\n+\t\t\t.factory('myHttpInterceptor', function($q, $window){\r\n+\t\t\t   return {\r\n+\t\t\t\t\t\trequest: function(config){\r\n+\t\t\t\t\t\t//console.log('Request interception'); // LOG AT REQUEST START\r\n+\r\n+\t\t\t\t\t\ttry{\r\n+\t\t\t\t\t\t\tvar cids = infiniteJsConnector.getExtraUrlParams();\r\n+\t\t\t\t\t\t\t//console.log('cids received: ' + cids);\r\n+\t\t\t\t\t\t\tif(cids != 'error'){\r\n+\t\t\t\t\t\t\t\tconfig.url += cids;\r\n+\t\t\t\t\t\t\t}\r\n+\r\n+\t\t\t\t\t\t}catch(error){\r\n+\t\t\t\t\t\t\t/*fail here could happen if infiniteJsConnector is not ready yet*/\r\n+\t\t\t\t\t\t}\r\n+\t\t\t\t\t\treturn config || $q.when(config);\r\n+\t\t\t\t\t   }\r\n+\t\t\t   };\r\n+\t\t\t});\r\n+\r\n+\r\n+\t\t});\r\n+\t\t\r\n+\t\tinfiniteJsConnector.onNewDocumentSet = function(alreadyHaveAssocs) {\r\n+\t\t\t\t\tvar cids; \r\n+\t\t\t\t\tif (!alreadyHaveAssocs) {\r\n+\t\t\t\t\t\ttry {\r\n+\t\t\t\t\t\t\tcids = infiniteJsConnector.getCommunityIds();\r\n+\t\t\t\t\t\t}\r\n+\t\t\t\t\t\tcatch (e) {\r\n+\t\t\t\t\t\t\talert(\"error: \" + e);\r\n+\t\t\t\t\t\t}\r\n+\t\t\t\t\t}\r\n+\t\t\t\t\telse {\r\n+\t\t\t\t\t\tcids = alreadyHaveAssocs;\r\n+\t\t\t\t\t}\r\n+\t\t\t\t};\r\n+\t\tinfiniteJsConnector.setLive = function(isLive){\r\n+\t\t\t\t//console.log('setLive called');console.log(isLive);\r\n+\t\t\t\tif(isLive==true){\r\n+\t\t\t\t\tinfiniteJsConnector._mode = 'live';\r\n+\t\t\t\t}else if(isLive==false){\r\n+\t\t\t\t\tinfiniteJsConnector._mode = 'stashed';\r\n+\t\t\t\t}\r\n+\t\t\t};\r\n+\t\tinfiniteJsConnector.onWidgetLoadWithParameters = function(paramString){\r","path":"src/index.html","position":126,"original_position":126,"commit_id":"58d1d404a702eb0060787140455b86e96eedc481","original_commit_id":"58d1d404a702eb0060787140455b86e96eedc481","user":{"login":"Alex-Ikanow","id":851950,"avatar_url":"https://avatars.githubusercontent.com/u/851950?","gravatar_id":"55ef92a5049cd59cdb59e77158dfc8d2","url":"https://api.github.com/users/Alex-Ikanow","html_url":"https://github.com/Alex-Ikanow","followers_url":"https://api.github.com/users/Alex-Ikanow/followers","following_url":"https://api.github.com/users/Alex-Ikanow/following{/other_user}","gists_url":"https://api.github.com/users/Alex-Ikanow/gists{/gist_id}","starred_url":"https://api.github.com/users/Alex-Ikanow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alex-Ikanow/subscriptions","organizations_url":"https://api.github.com/users/Alex-Ikanow/orgs","repos_url":"https://api.github.com/users/Alex-Ikanow/repos","events_url":"https://api.github.com/users/Alex-Ikanow/events{/privacy}","received_events_url":"https://api.github.com/users/Alex-Ikanow/received_events","type":"User","site_admin":false},"body":"what's this fn for?","created_at":"2014-05-08T16:19:50Z","updated_at":"2014-05-08T16:19:50Z","html_url":"https://github.com/Alex-Ikanow/kibana/pull/1#discussion_r12437694","pull_request_url":"https://api.github.com/repos/Alex-Ikanow/kibana/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/Alex-Ikanow/kibana/pulls/comments/12437694"},"html":{"href":"https://github.com/Alex-Ikanow/kibana/pull/1#discussion_r12437694"},"pull_request":{"href":"https://api.github.com/repos/Alex-Ikanow/kibana/pulls/1"}}}}