Implement menu links as plugins, including static admin links and views, and custom links with menu_link_content entity, all managed via menu_ui module

This PR is just for interactive review since it's such a big changeset - please summarize comments at: https://drupal.org/node/2256521
Thanks
On 05/07/2014 1:29 am, "pwolanin" <notifications@github.com> wrote:

> In core/lib/Drupal/Core/Menu/DefaultMenuLinkTreeManipulators.php:
>
> > +
> > +  /**
> > +   * Check access for one menu link instance.
> > +   *
> > +   * @param \Drupal\Core\Menu\MenuLinkInterface $instance
> > +   *   The menu link instance.
> > +   *
> > +   * @return bool
> > +   *   TRUE if the current user can access the link, FALSE otherwise.
> > +   */
> > +  protected function menuLinkCheckAccess(MenuLinkInterface $instance) {
> > +    // Use the definition here since that's a lot faster than creating a Url
> > +    // object that we don't need.
> > +    $definition = $instance->getPluginDefinition();
> > +    // 'url' should only be populated for external links.
> > +    if (!empty($definition['url']) && empty($definition['route_name'])) {
>
> Any external URL
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/pwolanin/drupal/pull/3/files#r14563366>.
>