this might be ok
working on parameters