GitHub PullRequestReviewCommentEvent at 2014-09-23 15:40:34
Repository: ember-qunit
Actor: marcoow
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/rwjblue/ember-qunit/pulls/comments/17916739","id":17916739,"diff_hunk":"@@ -8,6 +8,9 @@ define(\n     __exports__[\"default\"] = function isolatedContainer(fullNames) {\n       var resolver = testResolver.get();\n       var container = new Ember.Container();\n+      container.normalize = function(fullName) {","path":"dist/amd/isolated-container.js","position":4,"original_position":4,"commit_id":"e698c2b004f4aa84f2d395024f68a7115e487de7","original_commit_id":"1b994fab0b64102fad96368376cbfac3d49b0dc7","user":{"login":"marcoow","id":1510,"avatar_url":"https://avatars.githubusercontent.com/u/1510?v=2","gravatar_id":"","url":"https://api.github.com/users/marcoow","html_url":"https://github.com/marcoow","followers_url":"https://api.github.com/users/marcoow/followers","following_url":"https://api.github.com/users/marcoow/following{/other_user}","gists_url":"https://api.github.com/users/marcoow/gists{/gist_id}","starred_url":"https://api.github.com/users/marcoow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcoow/subscriptions","organizations_url":"https://api.github.com/users/marcoow/orgs","repos_url":"https://api.github.com/users/marcoow/repos","events_url":"https://api.github.com/users/marcoow/events{/privacy}","received_events_url":"https://api.github.com/users/marcoow/received_events","type":"User","site_admin":false},"body":"@stefanpenner: yep, this is on 1.7.0 - I'll update this later.","created_at":"2014-09-23T15:40:34Z","updated_at":"2014-09-23T15:40:34Z","html_url":"https://github.com/rwjblue/ember-qunit/pull/94#discussion_r17916739","pull_request_url":"https://api.github.com/repos/rwjblue/ember-qunit/pulls/94","_links":{"self":{"href":"https://api.github.com/repos/rwjblue/ember-qunit/pulls/comments/17916739"},"html":{"href":"https://github.com/rwjblue/ember-qunit/pull/94#discussion_r17916739"},"pull_request":{"href":"https://api.github.com/repos/rwjblue/ember-qunit/pulls/94"}}},"pull_request":{"url":"https://api.github.com/repos/rwjblue/ember-qunit/pulls/94","id":21650689,"html_url":"https://github.com/rwjblue/ember-qunit/pull/94","diff_url":"https://github.com/rwjblue/ember-qunit/pull/94.diff","patch_url":"https://github.com/rwjblue/ember-qunit/pull/94.patch","issue_url":"https://api.github.com/repos/rwjblue/ember-qunit/issues/94","number":94,"state":"open","locked":false,"title":"Make sure container and resolver normalize the same way","user":{"login":"marcoow","id":1510,"avatar_url":"https://avatars.githubusercontent.com/u/1510?v=2","gravatar_id":"","url":"https://api.github.com/users/marcoow","html_url":"https://github.com/marcoow","followers_url":"https://api.github.com/users/marcoow/followers","following_url":"https://api.github.com/users/marcoow/following{/other_user}","gists_url":"https://api.github.com/users/marcoow/gists{/gist_id}","starred_url":"https://api.github.com/users/marcoow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcoow/subscriptions","organizations_url":"https://api.github.com/users/marcoow/orgs","repos_url":"https://api.github.com/users/marcoow/repos","events_url":"https://api.github.com/users/marcoow/events{/privacy}","received_events_url":"https://api.github.com/users/marcoow/received_events","type":"User","site_admin":false},"body":"This fixes e.g. #84","created_at":"2014-09-23T14:50:13Z","updated_at":"2014-09-23T15:40:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"19f96389bfe0d6372976dc281c0178c79defa24d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rwjblue/ember-qunit/pulls/94/commits","review_comments_url":"https://api.github.com/repos/rwjblue/ember-qunit/pulls/94/comments","review_comment_url":"https://api.github.com/repos/rwjblue/ember-qunit/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rwjblue/ember-qunit/issues/94/comments","statuses_url":"https://api.github.com/repos/rwjblue/ember-qunit/statuses/e698c2b004f4aa84f2d395024f68a7115e487de7","head":{"label":"simplabs:fix-normalization","ref":"fix-normalization","sha":"e698c2b004f4aa84f2d395024f68a7115e487de7","user":{"login":"simplabs","id":56627,"avatar_url":"https://avatars.githubusercontent.com/u/56627?v=2","gravatar_id":"","url":"https://api.github.com/users/simplabs","html_url":"https://github.com/simplabs","followers_url":"https://api.github.com/users/simplabs/followers","following_url":"https://api.github.com/users/simplabs/following{/other_user}","gists_url":"https://api.github.com/users/simplabs/gists{/gist_id}","starred_url":"https://api.github.com/users/simplabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simplabs/subscriptions","organizations_url":"https://api.github.com/users/simplabs/orgs","repos_url":"https://api.github.com/users/simplabs/repos","events_url":"https://api.github.com/users/simplabs/events{/privacy}","received_events_url":"https://api.github.com/users/simplabs/received_events","type":"Organization","site_admin":false},"repo":{"id":24373061,"name":"ember-qunit","full_name":"simplabs/ember-qunit","owner":{"login":"simplabs","id":56627,"avatar_url":"https://avatars.githubusercontent.com/u/56627?v=2","gravatar_id":"","url":"https://api.github.com/users/simplabs","html_url":"https://github.com/simplabs","followers_url":"https://api.github.com/users/simplabs/followers","following_url":"https://api.github.com/users/simplabs/following{/other_user}","gists_url":"https://api.github.com/users/simplabs/gists{/gist_id}","starred_url":"https://api.github.com/users/simplabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simplabs/subscriptions","organizations_url":"https://api.github.com/users/simplabs/orgs","repos_url":"https://api.github.com/users/simplabs/repos","events_url":"https://api.github.com/users/simplabs/events{/privacy}","received_events_url":"https://api.github.com/users/simplabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/simplabs/ember-qunit","description":"unit test helpers for ember","fork":true,"url":"https://api.github.com/repos/simplabs/ember-qunit","forks_url":"https://api.github.com/repos/simplabs/ember-qunit/forks","keys_url":"https://api.github.com/repos/simplabs/ember-qunit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simplabs/ember-qunit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simplabs/ember-qunit/teams","hooks_url":"https://api.github.com/repos/simplabs/ember-qunit/hooks","issue_events_url":"https://api.github.com/repos/simplabs/ember-qunit/issues/events{/number}","events_url":"https://api.github.com/repos/simplabs/ember-qunit/events","assignees_url":"https://api.github.com/repos/simplabs/ember-qunit/assignees{/user}","branches_url":"https://api.github.com/repos/simplabs/ember-qunit/branches{/branch}","tags_url":"https://api.github.com/repos/simplabs/ember-qunit/tags","blobs_url":"https://api.github.com/repos/simplabs/ember-qunit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simplabs/ember-qunit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simplabs/ember-qunit/git/refs{/sha}","trees_url":"https://api.github.com/repos/simplabs/ember-qunit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simplabs/ember-qunit/statuses/{sha}","languages_url":"https://api.github.com/repos/simplabs/ember-qunit/languages","stargazers_url":"https://api.github.com/repos/simplabs/ember-qunit/stargazers","contributors_url":"https://api.github.com/repos/simplabs/ember-qunit/contributors","subscribers_url":"https://api.github.com/repos/simplabs/ember-qunit/subscribers","subscription_url":"https://api.github.com/repos/simplabs/ember-qunit/subscription","commits_url":"https://api.github.com/repos/simplabs/ember-qunit/commits{/sha}","git_commits_url":"https://api.github.com/repos/simplabs/ember-qunit/git/commits{/sha}","comments_url":"https://api.github.com/repos/simplabs/ember-qunit/comments{/number}","issue_comment_url":"https://api.github.com/repos/simplabs/ember-qunit/issues/comments/{number}","contents_url":"https://api.github.com/repos/simplabs/ember-qunit/contents/{+path}","compare_url":"https://api.github.com/repos/simplabs/ember-qunit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simplabs/ember-qunit/merges","archive_url":"https://api.github.com/repos/simplabs/ember-qunit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simplabs/ember-qunit/downloads","issues_url":"https://api.github.com/repos/simplabs/ember-qunit/issues{/number}","pulls_url":"https://api.github.com/repos/simplabs/ember-qunit/pulls{/number}","milestones_url":"https://api.github.com/repos/simplabs/ember-qunit/milestones{/number}","notifications_url":"https://api.github.com/repos/simplabs/ember-qunit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simplabs/ember-qunit/labels{/name}","releases_url":"https://api.github.com/repos/simplabs/ember-qunit/releases{/id}","created_at":"2014-09-23T13:43:11Z","updated_at":"2014-09-23T13:50:07Z","pushed_at":"2014-09-23T15:38:08Z","git_url":"git://github.com/simplabs/ember-qunit.git","ssh_url":"git@github.com:simplabs/ember-qunit.git","clone_url":"https://github.com/simplabs/ember-qunit.git","svn_url":"https://github.com/simplabs/ember-qunit","homepage":"","size":1149,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rwjblue:master","ref":"master","sha":"f3f852789bc80486afae1a9ddb7810356050fe9b","user":{"login":"rwjblue","id":12637,"avatar_url":"https://avatars.githubusercontent.com/u/12637?v=2","gravatar_id":"","url":"https://api.github.com/users/rwjblue","html_url":"https://github.com/rwjblue","followers_url":"https://api.github.com/users/rwjblue/followers","following_url":"https://api.github.com/users/rwjblue/following{/other_user}","gists_url":"https://api.github.com/users/rwjblue/gists{/gist_id}","starred_url":"https://api.github.com/users/rwjblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwjblue/subscriptions","organizations_url":"https://api.github.com/users/rwjblue/orgs","repos_url":"https://api.github.com/users/rwjblue/repos","events_url":"https://api.github.com/users/rwjblue/events{/privacy}","received_events_url":"https://api.github.com/users/rwjblue/received_events","type":"User","site_admin":false},"repo":{"id":17152449,"name":"ember-qunit","full_name":"rwjblue/ember-qunit","owner":{"login":"rwjblue","id":12637,"avatar_url":"https://avatars.githubusercontent.com/u/12637?v=2","gravatar_id":"","url":"https://api.github.com/users/rwjblue","html_url":"https://github.com/rwjblue","followers_url":"https://api.github.com/users/rwjblue/followers","following_url":"https://api.github.com/users/rwjblue/following{/other_user}","gists_url":"https://api.github.com/users/rwjblue/gists{/gist_id}","starred_url":"https://api.github.com/users/rwjblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwjblue/subscriptions","organizations_url":"https://api.github.com/users/rwjblue/orgs","repos_url":"https://api.github.com/users/rwjblue/repos","events_url":"https://api.github.com/users/rwjblue/events{/privacy}","received_events_url":"https://api.github.com/users/rwjblue/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rwjblue/ember-qunit","description":"unit test helpers for ember","fork":false,"url":"https://api.github.com/repos/rwjblue/ember-qunit","forks_url":"https://api.github.com/repos/rwjblue/ember-qunit/forks","keys_url":"https://api.github.com/repos/rwjblue/ember-qunit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rwjblue/ember-qunit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rwjblue/ember-qunit/teams","hooks_url":"https://api.github.com/repos/rwjblue/ember-qunit/hooks","issue_events_url":"https://api.github.com/repos/rwjblue/ember-qunit/issues/events{/number}","events_url":"https://api.github.com/repos/rwjblue/ember-qunit/events","assignees_url":"https://api.github.com/repos/rwjblue/ember-qunit/assignees{/user}","branches_url":"https://api.github.com/repos/rwjblue/ember-qunit/branches{/branch}","tags_url":"https://api.github.com/repos/rwjblue/ember-qunit/tags","blobs_url":"https://api.github.com/repos/rwjblue/ember-qunit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rwjblue/ember-qunit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rwjblue/ember-qunit/git/refs{/sha}","trees_url":"https://api.github.com/repos/rwjblue/ember-qunit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rwjblue/ember-qunit/statuses/{sha}","languages_url":"https://api.github.com/repos/rwjblue/ember-qunit/languages","stargazers_url":"https://api.github.com/repos/rwjblue/ember-qunit/stargazers","contributors_url":"https://api.github.com/repos/rwjblue/ember-qunit/contributors","subscribers_url":"https://api.github.com/repos/rwjblue/ember-qunit/subscribers","subscription_url":"https://api.github.com/repos/rwjblue/ember-qunit/subscription","commits_url":"https://api.github.com/repos/rwjblue/ember-qunit/commits{/sha}","git_commits_url":"https://api.github.com/repos/rwjblue/ember-qunit/git/commits{/sha}","comments_url":"https://api.github.com/repos/rwjblue/ember-qunit/comments{/number}","issue_comment_url":"https://api.github.com/repos/rwjblue/ember-qunit/issues/comments/{number}","contents_url":"https://api.github.com/repos/rwjblue/ember-qunit/contents/{+path}","compare_url":"https://api.github.com/repos/rwjblue/ember-qunit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rwjblue/ember-qunit/merges","archive_url":"https://api.github.com/repos/rwjblue/ember-qunit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rwjblue/ember-qunit/downloads","issues_url":"https://api.github.com/repos/rwjblue/ember-qunit/issues{/number}","pulls_url":"https://api.github.com/repos/rwjblue/ember-qunit/pulls{/number}","milestones_url":"https://api.github.com/repos/rwjblue/ember-qunit/milestones{/number}","notifications_url":"https://api.github.com/repos/rwjblue/ember-qunit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rwjblue/ember-qunit/labels{/name}","releases_url":"https://api.github.com/repos/rwjblue/ember-qunit/releases{/id}","created_at":"2014-02-24T22:02:49Z","updated_at":"2014-09-21T11:56:16Z","pushed_at":"2014-09-23T14:35:26Z","git_url":"git://github.com/rwjblue/ember-qunit.git","ssh_url":"git@github.com:rwjblue/ember-qunit.git","clone_url":"https://github.com/rwjblue/ember-qunit.git","svn_url":"https://github.com/rwjblue/ember-qunit","homepage":"","size":1149,"stargazers_count":130,"watchers_count":130,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":46,"mirror_url":null,"open_issues_count":38,"forks":46,"open_issues":38,"watchers":130,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rwjblue/ember-qunit/pulls/94"},"html":{"href":"https://github.com/rwjblue/ember-qunit/pull/94"},"issue":{"href":"https://api.github.com/repos/rwjblue/ember-qunit/issues/94"},"comments":{"href":"https://api.github.com/repos/rwjblue/ember-qunit/issues/94/comments"},"review_comments":{"href":"https://api.github.com/repos/rwjblue/ember-qunit/pulls/94/comments"},"review_comment":{"href":"https://api.github.com/repos/rwjblue/ember-qunit/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rwjblue/ember-qunit/pulls/94/commits"},"statuses":{"href":"https://api.github.com/repos/rwjblue/ember-qunit/statuses/e698c2b004f4aa84f2d395024f68a7115e487de7"}}}}