GitHub PullRequestReviewCommentEvent at 2014-11-11 01:03:53
Repository: openchange
Actor: kamenim
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/openchange/openchange/pulls/comments/20126195","id":20126195,"diff_hunk":"@@ -969,6 +969,7 @@ static void IDSET_ranges_remove_globcnt(struct idset *idset, uint64_t eid) {\n \t\t\tnew_range->high = range->high;\n \t\t\trange->high = exchange_globcnt(work_eid - 1);\n \t\t\tnew_range->next = range->next;\n+\t\t\tnew_range->prev = range;","path":"libmapi/idset.c","position":4,"original_position":4,"commit_id":"09f71ff29f5a10a919a35ca5c506aec38b41c266","original_commit_id":"09f71ff29f5a10a919a35ca5c506aec38b41c266","user":{"login":"kamenim","id":2061547,"avatar_url":"https://avatars.githubusercontent.com/u/2061547?v=3","gravatar_id":"","url":"https://api.github.com/users/kamenim","html_url":"https://github.com/kamenim","followers_url":"https://api.github.com/users/kamenim/followers","following_url":"https://api.github.com/users/kamenim/following{/other_user}","gists_url":"https://api.github.com/users/kamenim/gists{/gist_id}","starred_url":"https://api.github.com/users/kamenim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kamenim/subscriptions","organizations_url":"https://api.github.com/users/kamenim/orgs","repos_url":"https://api.github.com/users/kamenim/repos","events_url":"https://api.github.com/users/kamenim/events{/privacy}","received_events_url":"https://api.github.com/users/kamenim/received_events","type":"User","site_admin":false},"body":"it is a list manupulation and I think we should strive to the abstraction in place\r\nas much as possible\r\nAre there other places where list operations are handled \"by hand\"?\r\n","created_at":"2014-11-11T01:03:53Z","updated_at":"2014-11-11T01:03:53Z","html_url":"https://github.com/openchange/openchange/pull/126#discussion_r20126195","pull_request_url":"https://api.github.com/repos/openchange/openchange/pulls/126","_links":{"self":{"href":"https://api.github.com/repos/openchange/openchange/pulls/comments/20126195"},"html":{"href":"https://github.com/openchange/openchange/pull/126#discussion_r20126195"},"pull_request":{"href":"https://api.github.com/repos/openchange/openchange/pulls/126"}}},"pull_request":{"url":"https://api.github.com/repos/openchange/openchange/pulls/126","id":24161751,"html_url":"https://github.com/openchange/openchange/pull/126","diff_url":"https://github.com/openchange/openchange/pull/126.diff","patch_url":"https://github.com/openchange/openchange/pull/126.patch","issue_url":"https://api.github.com/repos/openchange/openchange/issues/126","number":126,"state":"closed","locked":false,"title":"Set prev when splitting a range on deletion","user":{"login":"sixstone-qq","id":440508,"avatar_url":"https://avatars.githubusercontent.com/u/440508?v=3","gravatar_id":"","url":"https://api.github.com/users/sixstone-qq","html_url":"https://github.com/sixstone-qq","followers_url":"https://api.github.com/users/sixstone-qq/followers","following_url":"https://api.github.com/users/sixstone-qq/following{/other_user}","gists_url":"https://api.github.com/users/sixstone-qq/gists{/gist_id}","starred_url":"https://api.github.com/users/sixstone-qq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sixstone-qq/subscriptions","organizations_url":"https://api.github.com/users/sixstone-qq/orgs","repos_url":"https://api.github.com/users/sixstone-qq/repos","events_url":"https://api.github.com/users/sixstone-qq/events{/privacy}","received_events_url":"https://api.github.com/users/sixstone-qq/received_events","type":"User","site_admin":false},"body":"If it was not set, then DLIST_REMOVE was crashing\r\nas it was impossible to rebuild the proper list.","created_at":"2014-11-10T17:16:22Z","updated_at":"2014-11-11T01:03:53Z","closed_at":"2014-11-10T17:33:06Z","merged_at":"2014-11-10T17:33:06Z","merge_commit_sha":"7d36df566eb7773973ea3aa101b786b91d818456","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openchange/openchange/pulls/126/commits","review_comments_url":"https://api.github.com/repos/openchange/openchange/pulls/126/comments","review_comment_url":"https://api.github.com/repos/openchange/openchange/pulls/comments/{number}","comments_url":"https://api.github.com/repos/openchange/openchange/issues/126/comments","statuses_url":"https://api.github.com/repos/openchange/openchange/statuses/09f71ff29f5a10a919a35ca5c506aec38b41c266","head":{"label":"sixstone-qq:ejhernandez/fix-split-range-on-delete","ref":"ejhernandez/fix-split-range-on-delete","sha":"09f71ff29f5a10a919a35ca5c506aec38b41c266","user":{"login":"sixstone-qq","id":440508,"avatar_url":"https://avatars.githubusercontent.com/u/440508?v=3","gravatar_id":"","url":"https://api.github.com/users/sixstone-qq","html_url":"https://github.com/sixstone-qq","followers_url":"https://api.github.com/users/sixstone-qq/followers","following_url":"https://api.github.com/users/sixstone-qq/following{/other_user}","gists_url":"https://api.github.com/users/sixstone-qq/gists{/gist_id}","starred_url":"https://api.github.com/users/sixstone-qq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sixstone-qq/subscriptions","organizations_url":"https://api.github.com/users/sixstone-qq/orgs","repos_url":"https://api.github.com/users/sixstone-qq/repos","events_url":"https://api.github.com/users/sixstone-qq/events{/privacy}","received_events_url":"https://api.github.com/users/sixstone-qq/received_events","type":"User","site_admin":false},"repo":{"id":21441822,"name":"openchange","full_name":"sixstone-qq/openchange","owner":{"login":"sixstone-qq","id":440508,"avatar_url":"https://avatars.githubusercontent.com/u/440508?v=3","gravatar_id":"","url":"https://api.github.com/users/sixstone-qq","html_url":"https://github.com/sixstone-qq","followers_url":"https://api.github.com/users/sixstone-qq/followers","following_url":"https://api.github.com/users/sixstone-qq/following{/other_user}","gists_url":"https://api.github.com/users/sixstone-qq/gists{/gist_id}","starred_url":"https://api.github.com/users/sixstone-qq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sixstone-qq/subscriptions","organizations_url":"https://api.github.com/users/sixstone-qq/orgs","repos_url":"https://api.github.com/users/sixstone-qq/repos","events_url":"https://api.github.com/users/sixstone-qq/events{/privacy}","received_events_url":"https://api.github.com/users/sixstone-qq/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sixstone-qq/openchange","description":"OpenChange Project","fork":true,"url":"https://api.github.com/repos/sixstone-qq/openchange","forks_url":"https://api.github.com/repos/sixstone-qq/openchange/forks","keys_url":"https://api.github.com/repos/sixstone-qq/openchange/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sixstone-qq/openchange/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sixstone-qq/openchange/teams","hooks_url":"https://api.github.com/repos/sixstone-qq/openchange/hooks","issue_events_url":"https://api.github.com/repos/sixstone-qq/openchange/issues/events{/number}","events_url":"https://api.github.com/repos/sixstone-qq/openchange/events","assignees_url":"https://api.github.com/repos/sixstone-qq/openchange/assignees{/user}","branches_url":"https://api.github.com/repos/sixstone-qq/openchange/branches{/branch}","tags_url":"https://api.github.com/repos/sixstone-qq/openchange/tags","blobs_url":"https://api.github.com/repos/sixstone-qq/openchange/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sixstone-qq/openchange/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sixstone-qq/openchange/git/refs{/sha}","trees_url":"https://api.github.com/repos/sixstone-qq/openchange/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sixstone-qq/openchange/statuses/{sha}","languages_url":"https://api.github.com/repos/sixstone-qq/openchange/languages","stargazers_url":"https://api.github.com/repos/sixstone-qq/openchange/stargazers","contributors_url":"https://api.github.com/repos/sixstone-qq/openchange/contributors","subscribers_url":"https://api.github.com/repos/sixstone-qq/openchange/subscribers","subscription_url":"https://api.github.com/repos/sixstone-qq/openchange/subscription","commits_url":"https://api.github.com/repos/sixstone-qq/openchange/commits{/sha}","git_commits_url":"https://api.github.com/repos/sixstone-qq/openchange/git/commits{/sha}","comments_url":"https://api.github.com/repos/sixstone-qq/openchange/comments{/number}","issue_comment_url":"https://api.github.com/repos/sixstone-qq/openchange/issues/comments/{number}","contents_url":"https://api.github.com/repos/sixstone-qq/openchange/contents/{+path}","compare_url":"https://api.github.com/repos/sixstone-qq/openchange/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sixstone-qq/openchange/merges","archive_url":"https://api.github.com/repos/sixstone-qq/openchange/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sixstone-qq/openchange/downloads","issues_url":"https://api.github.com/repos/sixstone-qq/openchange/issues{/number}","pulls_url":"https://api.github.com/repos/sixstone-qq/openchange/pulls{/number}","milestones_url":"https://api.github.com/repos/sixstone-qq/openchange/milestones{/number}","notifications_url":"https://api.github.com/repos/sixstone-qq/openchange/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sixstone-qq/openchange/labels{/name}","releases_url":"https://api.github.com/repos/sixstone-qq/openchange/releases{/id}","created_at":"2014-07-02T22:02:45Z","updated_at":"2014-07-22T09:49:33Z","pushed_at":"2014-11-10T22:48:34Z","git_url":"git://github.com/sixstone-qq/openchange.git","ssh_url":"git@github.com:sixstone-qq/openchange.git","clone_url":"https://github.com/sixstone-qq/openchange.git","svn_url":"https://github.com/sixstone-qq/openchange","homepage":null,"size":19299,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openchange:master","ref":"master","sha":"8e0208367c74217192e76ce5cfa104a71c145640","user":{"login":"openchange","id":5413705,"avatar_url":"https://avatars.githubusercontent.com/u/5413705?v=3","gravatar_id":"","url":"https://api.github.com/users/openchange","html_url":"https://github.com/openchange","followers_url":"https://api.github.com/users/openchange/followers","following_url":"https://api.github.com/users/openchange/following{/other_user}","gists_url":"https://api.github.com/users/openchange/gists{/gist_id}","starred_url":"https://api.github.com/users/openchange/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openchange/subscriptions","organizations_url":"https://api.github.com/users/openchange/orgs","repos_url":"https://api.github.com/users/openchange/repos","events_url":"https://api.github.com/users/openchange/events{/privacy}","received_events_url":"https://api.github.com/users/openchange/received_events","type":"Organization","site_admin":false},"repo":{"id":12688822,"name":"openchange","full_name":"openchange/openchange","owner":{"login":"openchange","id":5413705,"avatar_url":"https://avatars.githubusercontent.com/u/5413705?v=3","gravatar_id":"","url":"https://api.github.com/users/openchange","html_url":"https://github.com/openchange","followers_url":"https://api.github.com/users/openchange/followers","following_url":"https://api.github.com/users/openchange/following{/other_user}","gists_url":"https://api.github.com/users/openchange/gists{/gist_id}","starred_url":"https://api.github.com/users/openchange/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openchange/subscriptions","organizations_url":"https://api.github.com/users/openchange/orgs","repos_url":"https://api.github.com/users/openchange/repos","events_url":"https://api.github.com/users/openchange/events{/privacy}","received_events_url":"https://api.github.com/users/openchange/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openchange/openchange","description":"OpenChange Project","fork":false,"url":"https://api.github.com/repos/openchange/openchange","forks_url":"https://api.github.com/repos/openchange/openchange/forks","keys_url":"https://api.github.com/repos/openchange/openchange/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openchange/openchange/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openchange/openchange/teams","hooks_url":"https://api.github.com/repos/openchange/openchange/hooks","issue_events_url":"https://api.github.com/repos/openchange/openchange/issues/events{/number}","events_url":"https://api.github.com/repos/openchange/openchange/events","assignees_url":"https://api.github.com/repos/openchange/openchange/assignees{/user}","branches_url":"https://api.github.com/repos/openchange/openchange/branches{/branch}","tags_url":"https://api.github.com/repos/openchange/openchange/tags","blobs_url":"https://api.github.com/repos/openchange/openchange/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openchange/openchange/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openchange/openchange/git/refs{/sha}","trees_url":"https://api.github.com/repos/openchange/openchange/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openchange/openchange/statuses/{sha}","languages_url":"https://api.github.com/repos/openchange/openchange/languages","stargazers_url":"https://api.github.com/repos/openchange/openchange/stargazers","contributors_url":"https://api.github.com/repos/openchange/openchange/contributors","subscribers_url":"https://api.github.com/repos/openchange/openchange/subscribers","subscription_url":"https://api.github.com/repos/openchange/openchange/subscription","commits_url":"https://api.github.com/repos/openchange/openchange/commits{/sha}","git_commits_url":"https://api.github.com/repos/openchange/openchange/git/commits{/sha}","comments_url":"https://api.github.com/repos/openchange/openchange/comments{/number}","issue_comment_url":"https://api.github.com/repos/openchange/openchange/issues/comments/{number}","contents_url":"https://api.github.com/repos/openchange/openchange/contents/{+path}","compare_url":"https://api.github.com/repos/openchange/openchange/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openchange/openchange/merges","archive_url":"https://api.github.com/repos/openchange/openchange/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openchange/openchange/downloads","issues_url":"https://api.github.com/repos/openchange/openchange/issues{/number}","pulls_url":"https://api.github.com/repos/openchange/openchange/pulls{/number}","milestones_url":"https://api.github.com/repos/openchange/openchange/milestones{/number}","notifications_url":"https://api.github.com/repos/openchange/openchange/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openchange/openchange/labels{/name}","releases_url":"https://api.github.com/repos/openchange/openchange/releases{/id}","created_at":"2013-09-08T22:39:00Z","updated_at":"2014-11-05T18:41:03Z","pushed_at":"2014-11-10T18:18:26Z","git_url":"git://github.com/openchange/openchange.git","ssh_url":"git@github.com:openchange/openchange.git","clone_url":"https://github.com/openchange/openchange.git","svn_url":"https://github.com/openchange/openchange","homepage":null,"size":24147,"stargazers_count":38,"watchers_count":38,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":13,"forks":22,"open_issues":13,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openchange/openchange/pulls/126"},"html":{"href":"https://github.com/openchange/openchange/pull/126"},"issue":{"href":"https://api.github.com/repos/openchange/openchange/issues/126"},"comments":{"href":"https://api.github.com/repos/openchange/openchange/issues/126/comments"},"review_comments":{"href":"https://api.github.com/repos/openchange/openchange/pulls/126/comments"},"review_comment":{"href":"https://api.github.com/repos/openchange/openchange/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/openchange/openchange/pulls/126/commits"},"statuses":{"href":"https://api.github.com/repos/openchange/openchange/statuses/09f71ff29f5a10a919a35ca5c506aec38b41c266"}}}}