GitHub PullRequestReviewCommentEvent at 2014-12-10 17:32:27
Repository: openmw
Actor: scrawl
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/OpenMW/openmw/pulls/comments/21620061","id":21620061,"diff_hunk":"@@ -277,6 +273,40 @@ namespace ICS\n \t\t\t}\r\n \r\n \t\t\tdelete xmlDoc;\r\n+\t\t}\n+\n+\t\t/* Joystick Init */\n+\n+\t\t//Load controller mappings\n+#if SDL_VERSION_ATLEAST(2,0,2)\n+        if(!controllerdb.empty())\n+        {\n+            int res = SDL_GameControllerAddMappingsFromFile(controllerdb.c_str());\n+            if(res == -1)\n+            {\n+                ICS_LOG(std::string(\"Error loading controller bindings: \")+SDL_GetError());\n+            }\n+            else\n+            {\n+                ICS_LOG(std::string(\"Loaded \")+boost::lexical_cast<std::string>(res)+\" Game controller bindings\");\n+            }\n+        }\n+#endif","path":"extern/oics/ICSInputControlSystem.cpp","position":144,"original_position":144,"commit_id":"61d73d186dafd98eea27d9ce1404a23b631a6f7a","original_commit_id":"61d73d186dafd98eea27d9ce1404a23b631a6f7a","user":{"login":"scrawl","id":720642,"avatar_url":"https://avatars.githubusercontent.com/u/720642?v=3","gravatar_id":"","url":"https://api.github.com/users/scrawl","html_url":"https://github.com/scrawl","followers_url":"https://api.github.com/users/scrawl/followers","following_url":"https://api.github.com/users/scrawl/following{/other_user}","gists_url":"https://api.github.com/users/scrawl/gists{/gist_id}","starred_url":"https://api.github.com/users/scrawl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrawl/subscriptions","organizations_url":"https://api.github.com/users/scrawl/orgs","repos_url":"https://api.github.com/users/scrawl/repos","events_url":"https://api.github.com/users/scrawl/events{/privacy}","received_events_url":"https://api.github.com/users/scrawl/received_events","type":"User","site_admin":false},"body":"I'd rather this was moved to InputManager. Don't think it has anything to do with binding management.","created_at":"2014-12-10T17:32:27Z","updated_at":"2014-12-10T17:32:27Z","html_url":"https://github.com/OpenMW/openmw/pull/395#discussion_r21620061","pull_request_url":"https://api.github.com/repos/OpenMW/openmw/pulls/395","_links":{"self":{"href":"https://api.github.com/repos/OpenMW/openmw/pulls/comments/21620061"},"html":{"href":"https://github.com/OpenMW/openmw/pull/395#discussion_r21620061"},"pull_request":{"href":"https://api.github.com/repos/OpenMW/openmw/pulls/395"}}},"pull_request":{"url":"https://api.github.com/repos/OpenMW/openmw/pulls/395","id":25721387,"html_url":"https://github.com/OpenMW/openmw/pull/395","diff_url":"https://github.com/OpenMW/openmw/pull/395.diff","patch_url":"https://github.com/OpenMW/openmw/pull/395.patch","issue_url":"https://api.github.com/repos/OpenMW/openmw/issues/395","number":395,"state":"open","locked":false,"title":"Joystick Support","user":{"login":"Digmaster","id":302122,"avatar_url":"https://avatars.githubusercontent.com/u/302122?v=3","gravatar_id":"","url":"https://api.github.com/users/Digmaster","html_url":"https://github.com/Digmaster","followers_url":"https://api.github.com/users/Digmaster/followers","following_url":"https://api.github.com/users/Digmaster/following{/other_user}","gists_url":"https://api.github.com/users/Digmaster/gists{/gist_id}","starred_url":"https://api.github.com/users/Digmaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Digmaster/subscriptions","organizations_url":"https://api.github.com/users/Digmaster/orgs","repos_url":"https://api.github.com/users/Digmaster/repos","events_url":"https://api.github.com/users/Digmaster/events{/privacy}","received_events_url":"https://api.github.com/users/Digmaster/received_events","type":"User","site_admin":false},"body":"Try number 2!\r\nSo I rewrote it from scratch, because I was a really bad coder when I first started.\r\nHowever, if anyone could tell me how to have the axis controls start at to .5, as opposed to 0, would be a godsend. I tried in a couple places to no effect, and it results in the camera going absolutely nuts when you first start. This is the only issue I can find presently.\r\nScrawl asked, last time I did this, to change A_MoveLeft/A_MoveRight to use increasing and decreasing controls, however as nothing else does this I did not know how to do this, nor do I see the benefit.\r\nHopefully everything works correctly! I have touched openMW nor C++ in forever so I'm rather rusty.","created_at":"2014-12-09T06:07:37Z","updated_at":"2014-12-10T17:32:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c759fa7d1afad709a85b5075f8e07ae24f9efdc3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OpenMW/openmw/pulls/395/commits","review_comments_url":"https://api.github.com/repos/OpenMW/openmw/pulls/395/comments","review_comment_url":"https://api.github.com/repos/OpenMW/openmw/pulls/comments/{number}","comments_url":"https://api.github.com/repos/OpenMW/openmw/issues/395/comments","statuses_url":"https://api.github.com/repos/OpenMW/openmw/statuses/61d73d186dafd98eea27d9ce1404a23b631a6f7a","head":{"label":"Digmaster:master","ref":"master","sha":"61d73d186dafd98eea27d9ce1404a23b631a6f7a","user":{"login":"Digmaster","id":302122,"avatar_url":"https://avatars.githubusercontent.com/u/302122?v=3","gravatar_id":"","url":"https://api.github.com/users/Digmaster","html_url":"https://github.com/Digmaster","followers_url":"https://api.github.com/users/Digmaster/followers","following_url":"https://api.github.com/users/Digmaster/following{/other_user}","gists_url":"https://api.github.com/users/Digmaster/gists{/gist_id}","starred_url":"https://api.github.com/users/Digmaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Digmaster/subscriptions","organizations_url":"https://api.github.com/users/Digmaster/orgs","repos_url":"https://api.github.com/users/Digmaster/repos","events_url":"https://api.github.com/users/Digmaster/events{/privacy}","received_events_url":"https://api.github.com/users/Digmaster/received_events","type":"User","site_admin":false},"repo":{"id":27748521,"name":"openmw","full_name":"Digmaster/openmw","owner":{"login":"Digmaster","id":302122,"avatar_url":"https://avatars.githubusercontent.com/u/302122?v=3","gravatar_id":"","url":"https://api.github.com/users/Digmaster","html_url":"https://github.com/Digmaster","followers_url":"https://api.github.com/users/Digmaster/followers","following_url":"https://api.github.com/users/Digmaster/following{/other_user}","gists_url":"https://api.github.com/users/Digmaster/gists{/gist_id}","starred_url":"https://api.github.com/users/Digmaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Digmaster/subscriptions","organizations_url":"https://api.github.com/users/Digmaster/orgs","repos_url":"https://api.github.com/users/Digmaster/repos","events_url":"https://api.github.com/users/Digmaster/events{/privacy}","received_events_url":"https://api.github.com/users/Digmaster/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Digmaster/openmw","description":"OpenMW is an unofficial open source engine reimplementation of the game Morrowind.","fork":true,"url":"https://api.github.com/repos/Digmaster/openmw","forks_url":"https://api.github.com/repos/Digmaster/openmw/forks","keys_url":"https://api.github.com/repos/Digmaster/openmw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Digmaster/openmw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Digmaster/openmw/teams","hooks_url":"https://api.github.com/repos/Digmaster/openmw/hooks","issue_events_url":"https://api.github.com/repos/Digmaster/openmw/issues/events{/number}","events_url":"https://api.github.com/repos/Digmaster/openmw/events","assignees_url":"https://api.github.com/repos/Digmaster/openmw/assignees{/user}","branches_url":"https://api.github.com/repos/Digmaster/openmw/branches{/branch}","tags_url":"https://api.github.com/repos/Digmaster/openmw/tags","blobs_url":"https://api.github.com/repos/Digmaster/openmw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Digmaster/openmw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Digmaster/openmw/git/refs{/sha}","trees_url":"https://api.github.com/repos/Digmaster/openmw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Digmaster/openmw/statuses/{sha}","languages_url":"https://api.github.com/repos/Digmaster/openmw/languages","stargazers_url":"https://api.github.com/repos/Digmaster/openmw/stargazers","contributors_url":"https://api.github.com/repos/Digmaster/openmw/contributors","subscribers_url":"https://api.github.com/repos/Digmaster/openmw/subscribers","subscription_url":"https://api.github.com/repos/Digmaster/openmw/subscription","commits_url":"https://api.github.com/repos/Digmaster/openmw/commits{/sha}","git_commits_url":"https://api.github.com/repos/Digmaster/openmw/git/commits{/sha}","comments_url":"https://api.github.com/repos/Digmaster/openmw/comments{/number}","issue_comment_url":"https://api.github.com/repos/Digmaster/openmw/issues/comments/{number}","contents_url":"https://api.github.com/repos/Digmaster/openmw/contents/{+path}","compare_url":"https://api.github.com/repos/Digmaster/openmw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Digmaster/openmw/merges","archive_url":"https://api.github.com/repos/Digmaster/openmw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Digmaster/openmw/downloads","issues_url":"https://api.github.com/repos/Digmaster/openmw/issues{/number}","pulls_url":"https://api.github.com/repos/Digmaster/openmw/pulls{/number}","milestones_url":"https://api.github.com/repos/Digmaster/openmw/milestones{/number}","notifications_url":"https://api.github.com/repos/Digmaster/openmw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Digmaster/openmw/labels{/name}","releases_url":"https://api.github.com/repos/Digmaster/openmw/releases{/id}","created_at":"2014-12-09T03:53:19Z","updated_at":"2014-12-09T20:56:48Z","pushed_at":"2014-12-09T20:56:48Z","git_url":"git://github.com/Digmaster/openmw.git","ssh_url":"git@github.com:Digmaster/openmw.git","clone_url":"https://github.com/Digmaster/openmw.git","svn_url":"https://github.com/Digmaster/openmw","homepage":"http://www.openmw.org/","size":48204,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OpenMW:master","ref":"master","sha":"6c8a662042786171d3d17a6178d69a7f7e05533d","user":{"login":"OpenMW","id":6727417,"avatar_url":"https://avatars.githubusercontent.com/u/6727417?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenMW","html_url":"https://github.com/OpenMW","followers_url":"https://api.github.com/users/OpenMW/followers","following_url":"https://api.github.com/users/OpenMW/following{/other_user}","gists_url":"https://api.github.com/users/OpenMW/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenMW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenMW/subscriptions","organizations_url":"https://api.github.com/users/OpenMW/orgs","repos_url":"https://api.github.com/users/OpenMW/repos","events_url":"https://api.github.com/users/OpenMW/events{/privacy}","received_events_url":"https://api.github.com/users/OpenMW/received_events","type":"Organization","site_admin":false},"repo":{"id":285722,"name":"openmw","full_name":"OpenMW/openmw","owner":{"login":"OpenMW","id":6727417,"avatar_url":"https://avatars.githubusercontent.com/u/6727417?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenMW","html_url":"https://github.com/OpenMW","followers_url":"https://api.github.com/users/OpenMW/followers","following_url":"https://api.github.com/users/OpenMW/following{/other_user}","gists_url":"https://api.github.com/users/OpenMW/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenMW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenMW/subscriptions","organizations_url":"https://api.github.com/users/OpenMW/orgs","repos_url":"https://api.github.com/users/OpenMW/repos","events_url":"https://api.github.com/users/OpenMW/events{/privacy}","received_events_url":"https://api.github.com/users/OpenMW/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenMW/openmw","description":"OpenMW is an unofficial open source engine reimplementation of the game Morrowind.","fork":false,"url":"https://api.github.com/repos/OpenMW/openmw","forks_url":"https://api.github.com/repos/OpenMW/openmw/forks","keys_url":"https://api.github.com/repos/OpenMW/openmw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenMW/openmw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenMW/openmw/teams","hooks_url":"https://api.github.com/repos/OpenMW/openmw/hooks","issue_events_url":"https://api.github.com/repos/OpenMW/openmw/issues/events{/number}","events_url":"https://api.github.com/repos/OpenMW/openmw/events","assignees_url":"https://api.github.com/repos/OpenMW/openmw/assignees{/user}","branches_url":"https://api.github.com/repos/OpenMW/openmw/branches{/branch}","tags_url":"https://api.github.com/repos/OpenMW/openmw/tags","blobs_url":"https://api.github.com/repos/OpenMW/openmw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenMW/openmw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenMW/openmw/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenMW/openmw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenMW/openmw/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenMW/openmw/languages","stargazers_url":"https://api.github.com/repos/OpenMW/openmw/stargazers","contributors_url":"https://api.github.com/repos/OpenMW/openmw/contributors","subscribers_url":"https://api.github.com/repos/OpenMW/openmw/subscribers","subscription_url":"https://api.github.com/repos/OpenMW/openmw/subscription","commits_url":"https://api.github.com/repos/OpenMW/openmw/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenMW/openmw/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenMW/openmw/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenMW/openmw/issues/comments/{number}","contents_url":"https://api.github.com/repos/OpenMW/openmw/contents/{+path}","compare_url":"https://api.github.com/repos/OpenMW/openmw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenMW/openmw/merges","archive_url":"https://api.github.com/repos/OpenMW/openmw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenMW/openmw/downloads","issues_url":"https://api.github.com/repos/OpenMW/openmw/issues{/number}","pulls_url":"https://api.github.com/repos/OpenMW/openmw/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenMW/openmw/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenMW/openmw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenMW/openmw/labels{/name}","releases_url":"https://api.github.com/repos/OpenMW/openmw/releases{/id}","created_at":"2009-08-23T14:46:21Z","updated_at":"2014-12-10T09:45:34Z","pushed_at":"2014-12-10T09:45:33Z","git_url":"git://github.com/OpenMW/openmw.git","ssh_url":"git@github.com:OpenMW/openmw.git","clone_url":"https://github.com/OpenMW/openmw.git","svn_url":"https://github.com/OpenMW/openmw","homepage":"http://www.openmw.org/","size":48204,"stargazers_count":484,"watchers_count":484,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":317,"mirror_url":null,"open_issues_count":5,"forks":317,"open_issues":5,"watchers":484,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenMW/openmw/pulls/395"},"html":{"href":"https://github.com/OpenMW/openmw/pull/395"},"issue":{"href":"https://api.github.com/repos/OpenMW/openmw/issues/395"},"comments":{"href":"https://api.github.com/repos/OpenMW/openmw/issues/395/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenMW/openmw/pulls/395/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenMW/openmw/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/OpenMW/openmw/pulls/395/commits"},"statuses":{"href":"https://api.github.com/repos/OpenMW/openmw/statuses/61d73d186dafd98eea27d9ce1404a23b631a6f7a"}}}}