GitHub PullRequestEvent at 2014-10-21 11:12:06
Repository: opentxs
Actor: da2ce7
Payload: {"action":"opened","number":327,"pull_request":{"url":"https://api.github.com/repos/Open-Transactions/opentxs/pulls/327","id":23077905,"html_url":"https://github.com/Open-Transactions/opentxs/pull/327","diff_url":"https://github.com/Open-Transactions/opentxs/pull/327.diff","patch_url":"https://github.com/Open-Transactions/opentxs/pull/327.patch","issue_url":"https://api.github.com/repos/Open-Transactions/opentxs/issues/327","number":327,"state":"open","locked":false,"title":"replace OTData with std::vector (and associated changes)","user":{"login":"da2ce7","id":691439,"avatar_url":"https://avatars.githubusercontent.com/u/691439?v=2","gravatar_id":"","url":"https://api.github.com/users/da2ce7","html_url":"https://github.com/da2ce7","followers_url":"https://api.github.com/users/da2ce7/followers","following_url":"https://api.github.com/users/da2ce7/following{/other_user}","gists_url":"https://api.github.com/users/da2ce7/gists{/gist_id}","starred_url":"https://api.github.com/users/da2ce7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/da2ce7/subscriptions","organizations_url":"https://api.github.com/users/da2ce7/orgs","repos_url":"https://api.github.com/users/da2ce7/repos","events_url":"https://api.github.com/users/da2ce7/events{/privacy}","received_events_url":"https://api.github.com/users/da2ce7/received_events","type":"User","site_admin":false},"body":"This is the first of a few major groundwork changes to prepare for the Bitcoin compatible crypto code.\r\n\r\nI don't care about line length, or format issues, or Warning-Errors about this review.  I want a review of the changes that may introduce security, or stability issues.\r\n\r\nIf this build doesn't work on your OS of choice please send me a pull request that fixes it.\r\nThis complies and tests on Mac (Clang), and Windows (MSVC).  I have fixed a few windows bug while at it.\r\n\r\nI want to get on with coding much harder things than this.  So anyone who is unable to code the harder things should be nice to me, and help me out with the pedantic style, format, non-stability, non-security review fails.\r\n\r\nSome review notes:\r\nThe ot_data_secure_t isn't used.  It is going to be used in the next pull request.\r\nThe custom std::allocator uses the same code as used in OTPassword.  This is not up for review, as I wish to make more changes to this part, however since it is security-sensitive code this should go into it's own pull request.\r\n\r\nUp next is the replacement of OTPassword with ot_string_secure_t / ot_data_secure_t.  This again will have wide-reaching changes.\r\n\r\nCam.","created_at":"2014-10-21T11:12:06Z","updated_at":"2014-10-21T11:12:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Open-Transactions/opentxs/pulls/327/commits","review_comments_url":"https://api.github.com/repos/Open-Transactions/opentxs/pulls/327/comments","review_comment_url":"https://api.github.com/repos/Open-Transactions/opentxs/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Open-Transactions/opentxs/issues/327/comments","statuses_url":"https://api.github.com/repos/Open-Transactions/opentxs/statuses/c8cc731a7d8ec3f6068781a16aef638cf612bc7c","head":{"label":"da2ce7:ot_data_rework","ref":"ot_data_rework","sha":"c8cc731a7d8ec3f6068781a16aef638cf612bc7c","user":{"login":"da2ce7","id":691439,"avatar_url":"https://avatars.githubusercontent.com/u/691439?v=2","gravatar_id":"","url":"https://api.github.com/users/da2ce7","html_url":"https://github.com/da2ce7","followers_url":"https://api.github.com/users/da2ce7/followers","following_url":"https://api.github.com/users/da2ce7/following{/other_user}","gists_url":"https://api.github.com/users/da2ce7/gists{/gist_id}","starred_url":"https://api.github.com/users/da2ce7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/da2ce7/subscriptions","organizations_url":"https://api.github.com/users/da2ce7/orgs","repos_url":"https://api.github.com/users/da2ce7/repos","events_url":"https://api.github.com/users/da2ce7/events{/privacy}","received_events_url":"https://api.github.com/users/da2ce7/received_events","type":"User","site_admin":false},"repo":{"id":22808547,"name":"opentxs","full_name":"da2ce7/opentxs","owner":{"login":"da2ce7","id":691439,"avatar_url":"https://avatars.githubusercontent.com/u/691439?v=2","gravatar_id":"","url":"https://api.github.com/users/da2ce7","html_url":"https://github.com/da2ce7","followers_url":"https://api.github.com/users/da2ce7/followers","following_url":"https://api.github.com/users/da2ce7/following{/other_user}","gists_url":"https://api.github.com/users/da2ce7/gists{/gist_id}","starred_url":"https://api.github.com/users/da2ce7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/da2ce7/subscriptions","organizations_url":"https://api.github.com/users/da2ce7/orgs","repos_url":"https://api.github.com/users/da2ce7/repos","events_url":"https://api.github.com/users/da2ce7/events{/privacy}","received_events_url":"https://api.github.com/users/da2ce7/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/da2ce7/opentxs","description":"Open Transactions - Libraries and CLI","fork":true,"url":"https://api.github.com/repos/da2ce7/opentxs","forks_url":"https://api.github.com/repos/da2ce7/opentxs/forks","keys_url":"https://api.github.com/repos/da2ce7/opentxs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/da2ce7/opentxs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/da2ce7/opentxs/teams","hooks_url":"https://api.github.com/repos/da2ce7/opentxs/hooks","issue_events_url":"https://api.github.com/repos/da2ce7/opentxs/issues/events{/number}","events_url":"https://api.github.com/repos/da2ce7/opentxs/events","assignees_url":"https://api.github.com/repos/da2ce7/opentxs/assignees{/user}","branches_url":"https://api.github.com/repos/da2ce7/opentxs/branches{/branch}","tags_url":"https://api.github.com/repos/da2ce7/opentxs/tags","blobs_url":"https://api.github.com/repos/da2ce7/opentxs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/da2ce7/opentxs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/da2ce7/opentxs/git/refs{/sha}","trees_url":"https://api.github.com/repos/da2ce7/opentxs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/da2ce7/opentxs/statuses/{sha}","languages_url":"https://api.github.com/repos/da2ce7/opentxs/languages","stargazers_url":"https://api.github.com/repos/da2ce7/opentxs/stargazers","contributors_url":"https://api.github.com/repos/da2ce7/opentxs/contributors","subscribers_url":"https://api.github.com/repos/da2ce7/opentxs/subscribers","subscription_url":"https://api.github.com/repos/da2ce7/opentxs/subscription","commits_url":"https://api.github.com/repos/da2ce7/opentxs/commits{/sha}","git_commits_url":"https://api.github.com/repos/da2ce7/opentxs/git/commits{/sha}","comments_url":"https://api.github.com/repos/da2ce7/opentxs/comments{/number}","issue_comment_url":"https://api.github.com/repos/da2ce7/opentxs/issues/comments/{number}","contents_url":"https://api.github.com/repos/da2ce7/opentxs/contents/{+path}","compare_url":"https://api.github.com/repos/da2ce7/opentxs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/da2ce7/opentxs/merges","archive_url":"https://api.github.com/repos/da2ce7/opentxs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/da2ce7/opentxs/downloads","issues_url":"https://api.github.com/repos/da2ce7/opentxs/issues{/number}","pulls_url":"https://api.github.com/repos/da2ce7/opentxs/pulls{/number}","milestones_url":"https://api.github.com/repos/da2ce7/opentxs/milestones{/number}","notifications_url":"https://api.github.com/repos/da2ce7/opentxs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/da2ce7/opentxs/labels{/name}","releases_url":"https://api.github.com/repos/da2ce7/opentxs/releases{/id}","created_at":"2014-08-10T12:36:55Z","updated_at":"2014-08-10T14:02:05Z","pushed_at":"2014-10-21T09:42:42Z","git_url":"git://github.com/da2ce7/opentxs.git","ssh_url":"git@github.com:da2ce7/opentxs.git","clone_url":"https://github.com/da2ce7/opentxs.git","svn_url":"https://github.com/da2ce7/opentxs","homepage":null,"size":41879,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"Open-Transactions:develop","ref":"develop","sha":"e20bfb37911d54e01e7da2da76b01de8044c6483","user":{"login":"Open-Transactions","id":4221800,"avatar_url":"https://avatars.githubusercontent.com/u/4221800?v=2","gravatar_id":"","url":"https://api.github.com/users/Open-Transactions","html_url":"https://github.com/Open-Transactions","followers_url":"https://api.github.com/users/Open-Transactions/followers","following_url":"https://api.github.com/users/Open-Transactions/following{/other_user}","gists_url":"https://api.github.com/users/Open-Transactions/gists{/gist_id}","starred_url":"https://api.github.com/users/Open-Transactions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Open-Transactions/subscriptions","organizations_url":"https://api.github.com/users/Open-Transactions/orgs","repos_url":"https://api.github.com/users/Open-Transactions/repos","events_url":"https://api.github.com/users/Open-Transactions/events{/privacy}","received_events_url":"https://api.github.com/users/Open-Transactions/received_events","type":"Organization","site_admin":false},"repo":{"id":22756749,"name":"opentxs","full_name":"Open-Transactions/opentxs","owner":{"login":"Open-Transactions","id":4221800,"avatar_url":"https://avatars.githubusercontent.com/u/4221800?v=2","gravatar_id":"","url":"https://api.github.com/users/Open-Transactions","html_url":"https://github.com/Open-Transactions","followers_url":"https://api.github.com/users/Open-Transactions/followers","following_url":"https://api.github.com/users/Open-Transactions/following{/other_user}","gists_url":"https://api.github.com/users/Open-Transactions/gists{/gist_id}","starred_url":"https://api.github.com/users/Open-Transactions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Open-Transactions/subscriptions","organizations_url":"https://api.github.com/users/Open-Transactions/orgs","repos_url":"https://api.github.com/users/Open-Transactions/repos","events_url":"https://api.github.com/users/Open-Transactions/events{/privacy}","received_events_url":"https://api.github.com/users/Open-Transactions/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Open-Transactions/opentxs","description":"Open Transactions - Libraries and CLI","fork":false,"url":"https://api.github.com/repos/Open-Transactions/opentxs","forks_url":"https://api.github.com/repos/Open-Transactions/opentxs/forks","keys_url":"https://api.github.com/repos/Open-Transactions/opentxs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Open-Transactions/opentxs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Open-Transactions/opentxs/teams","hooks_url":"https://api.github.com/repos/Open-Transactions/opentxs/hooks","issue_events_url":"https://api.github.com/repos/Open-Transactions/opentxs/issues/events{/number}","events_url":"https://api.github.com/repos/Open-Transactions/opentxs/events","assignees_url":"https://api.github.com/repos/Open-Transactions/opentxs/assignees{/user}","branches_url":"https://api.github.com/repos/Open-Transactions/opentxs/branches{/branch}","tags_url":"https://api.github.com/repos/Open-Transactions/opentxs/tags","blobs_url":"https://api.github.com/repos/Open-Transactions/opentxs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Open-Transactions/opentxs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Open-Transactions/opentxs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Open-Transactions/opentxs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Open-Transactions/opentxs/statuses/{sha}","languages_url":"https://api.github.com/repos/Open-Transactions/opentxs/languages","stargazers_url":"https://api.github.com/repos/Open-Transactions/opentxs/stargazers","contributors_url":"https://api.github.com/repos/Open-Transactions/opentxs/contributors","subscribers_url":"https://api.github.com/repos/Open-Transactions/opentxs/subscribers","subscription_url":"https://api.github.com/repos/Open-Transactions/opentxs/subscription","commits_url":"https://api.github.com/repos/Open-Transactions/opentxs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Open-Transactions/opentxs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Open-Transactions/opentxs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Open-Transactions/opentxs/issues/comments/{number}","contents_url":"https://api.github.com/repos/Open-Transactions/opentxs/contents/{+path}","compare_url":"https://api.github.com/repos/Open-Transactions/opentxs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Open-Transactions/opentxs/merges","archive_url":"https://api.github.com/repos/Open-Transactions/opentxs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Open-Transactions/opentxs/downloads","issues_url":"https://api.github.com/repos/Open-Transactions/opentxs/issues{/number}","pulls_url":"https://api.github.com/repos/Open-Transactions/opentxs/pulls{/number}","milestones_url":"https://api.github.com/repos/Open-Transactions/opentxs/milestones{/number}","notifications_url":"https://api.github.com/repos/Open-Transactions/opentxs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Open-Transactions/opentxs/labels{/name}","releases_url":"https://api.github.com/repos/Open-Transactions/opentxs/releases{/id}","created_at":"2014-08-08T12:13:23Z","updated_at":"2014-09-23T17:07:58Z","pushed_at":"2014-10-21T09:54:10Z","git_url":"git://github.com/Open-Transactions/opentxs.git","ssh_url":"git@github.com:Open-Transactions/opentxs.git","clone_url":"https://github.com/Open-Transactions/opentxs.git","svn_url":"https://github.com/Open-Transactions/opentxs","homepage":null,"size":47624,"stargazers_count":8,"watchers_count":8,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":62,"forks":22,"open_issues":62,"watchers":8,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Open-Transactions/opentxs/pulls/327"},"html":{"href":"https://github.com/Open-Transactions/opentxs/pull/327"},"issue":{"href":"https://api.github.com/repos/Open-Transactions/opentxs/issues/327"},"comments":{"href":"https://api.github.com/repos/Open-Transactions/opentxs/issues/327/comments"},"review_comments":{"href":"https://api.github.com/repos/Open-Transactions/opentxs/pulls/327/comments"},"review_comment":{"href":"https://api.github.com/repos/Open-Transactions/opentxs/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Open-Transactions/opentxs/pulls/327/commits"},"statuses":{"href":"https://api.github.com/repos/Open-Transactions/opentxs/statuses/c8cc731a7d8ec3f6068781a16aef638cf612bc7c"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":11,"additions":1454,"deletions":2443,"changed_files":52}}