GitHub PullRequestReviewCommentEvent at 2014-09-12 21:27:16
Repository: bird-man
Actor: jxa
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/neo/bird-man/pulls/comments/17503725","id":17503725,"diff_hunk":"@@ -25,16 +25,26 @@\n                   :time-period nil\n                   :taxonomy []\n                   :frequencies {}\n-                  :photo {}}))\n+                  :photo {}\n+                  :screen-size \"lg\"}))\n+\n+(defn watch-screen-size [model]","path":"src/cljs/bird_wave/client.cljs","position":17,"original_position":17,"commit_id":"ffd6eb1765f6c6d9273a41b99b35ebda4740b5b5","original_commit_id":"ffd6eb1765f6c6d9273a41b99b35ebda4740b5b5","user":{"login":"jxa","id":11772,"avatar_url":"https://avatars.githubusercontent.com/u/11772?v=2","gravatar_id":"3b50f4f9cd5231a094de54224d277cf6","url":"https://api.github.com/users/jxa","html_url":"https://github.com/jxa","followers_url":"https://api.github.com/users/jxa/followers","following_url":"https://api.github.com/users/jxa/following{/other_user}","gists_url":"https://api.github.com/users/jxa/gists{/gist_id}","starred_url":"https://api.github.com/users/jxa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jxa/subscriptions","organizations_url":"https://api.github.com/users/jxa/orgs","repos_url":"https://api.github.com/users/jxa/repos","events_url":"https://api.github.com/users/jxa/events{/privacy}","received_events_url":"https://api.github.com/users/jxa/received_events","type":"User","site_admin":false},"body":"as opposed to my comments on the blog post, here what I might do is define the fn in a local let.\r\n\r\n```clojure\r\n(defn watch-screen-size [model]\r\n  (let [set-size (fn [size] #(swap! model assoc :screen-size size))]\r\n    (-> js/enquire\r\n         (.register \"...\" (set-size \"xs\"))\r\n         ...)))\r\n```","created_at":"2014-09-12T21:27:16Z","updated_at":"2014-09-12T21:27:16Z","html_url":"https://github.com/neo/bird-man/pull/23#discussion_r17503725","pull_request_url":"https://api.github.com/repos/neo/bird-man/pulls/23","_links":{"self":{"href":"https://api.github.com/repos/neo/bird-man/pulls/comments/17503725"},"html":{"href":"https://github.com/neo/bird-man/pull/23#discussion_r17503725"},"pull_request":{"href":"https://api.github.com/repos/neo/bird-man/pulls/23"}}},"pull_request":{"url":"https://api.github.com/repos/neo/bird-man/pulls/23","id":19899258,"html_url":"https://github.com/neo/bird-man/pull/23","diff_url":"https://github.com/neo/bird-man/pull/23.diff","patch_url":"https://github.com/neo/bird-man/pull/23.patch","issue_url":"https://api.github.com/repos/neo/bird-man/issues/23","number":23,"state":"open","locked":false,"title":"Responsive","user":{"login":"tennety","id":147759,"avatar_url":"https://avatars.githubusercontent.com/u/147759?v=2","gravatar_id":"27d007e2e1a2bafac9250fcf5dcc3d5b","url":"https://api.github.com/users/tennety","html_url":"https://github.com/tennety","followers_url":"https://api.github.com/users/tennety/followers","following_url":"https://api.github.com/users/tennety/following{/other_user}","gists_url":"https://api.github.com/users/tennety/gists{/gist_id}","starred_url":"https://api.github.com/users/tennety/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tennety/subscriptions","organizations_url":"https://api.github.com/users/tennety/orgs","repos_url":"https://api.github.com/users/tennety/repos","events_url":"https://api.github.com/users/tennety/events{/privacy}","received_events_url":"https://api.github.com/users/tennety/received_events","type":"User","site_admin":false},"body":"@jxa Let's talk about this when we have a chance. Lots of code review needed :smiley_cat: ","created_at":"2014-08-18T04:49:16Z","updated_at":"2014-09-12T21:27:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4331c947a326482b6519420ff33db5ff9785e227","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/neo/bird-man/pulls/23/commits","review_comments_url":"https://api.github.com/repos/neo/bird-man/pulls/23/comments","review_comment_url":"https://api.github.com/repos/neo/bird-man/pulls/comments/{number}","comments_url":"https://api.github.com/repos/neo/bird-man/issues/23/comments","statuses_url":"https://api.github.com/repos/neo/bird-man/statuses/ffd6eb1765f6c6d9273a41b99b35ebda4740b5b5","head":{"label":"neo:responsive","ref":"responsive","sha":"ffd6eb1765f6c6d9273a41b99b35ebda4740b5b5","user":{"login":"neo","id":3138245,"avatar_url":"https://avatars.githubusercontent.com/u/3138245?v=2","gravatar_id":"c7c31e9d8d380b6ecc717966d56f604d","url":"https://api.github.com/users/neo","html_url":"https://github.com/neo","followers_url":"https://api.github.com/users/neo/followers","following_url":"https://api.github.com/users/neo/following{/other_user}","gists_url":"https://api.github.com/users/neo/gists{/gist_id}","starred_url":"https://api.github.com/users/neo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo/subscriptions","organizations_url":"https://api.github.com/users/neo/orgs","repos_url":"https://api.github.com/users/neo/repos","events_url":"https://api.github.com/users/neo/events{/privacy}","received_events_url":"https://api.github.com/users/neo/received_events","type":"Organization","site_admin":false},"repo":{"id":16217315,"name":"bird-man","full_name":"neo/bird-man","owner":{"login":"neo","id":3138245,"avatar_url":"https://avatars.githubusercontent.com/u/3138245?v=2","gravatar_id":"c7c31e9d8d380b6ecc717966d56f604d","url":"https://api.github.com/users/neo","html_url":"https://github.com/neo","followers_url":"https://api.github.com/users/neo/followers","following_url":"https://api.github.com/users/neo/following{/other_user}","gists_url":"https://api.github.com/users/neo/gists{/gist_id}","starred_url":"https://api.github.com/users/neo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo/subscriptions","organizations_url":"https://api.github.com/users/neo/orgs","repos_url":"https://api.github.com/users/neo/repos","events_url":"https://api.github.com/users/neo/events{/privacy}","received_events_url":"https://api.github.com/users/neo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neo/bird-man","description":"An api for eBird data","fork":false,"url":"https://api.github.com/repos/neo/bird-man","forks_url":"https://api.github.com/repos/neo/bird-man/forks","keys_url":"https://api.github.com/repos/neo/bird-man/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neo/bird-man/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neo/bird-man/teams","hooks_url":"https://api.github.com/repos/neo/bird-man/hooks","issue_events_url":"https://api.github.com/repos/neo/bird-man/issues/events{/number}","events_url":"https://api.github.com/repos/neo/bird-man/events","assignees_url":"https://api.github.com/repos/neo/bird-man/assignees{/user}","branches_url":"https://api.github.com/repos/neo/bird-man/branches{/branch}","tags_url":"https://api.github.com/repos/neo/bird-man/tags","blobs_url":"https://api.github.com/repos/neo/bird-man/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neo/bird-man/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neo/bird-man/git/refs{/sha}","trees_url":"https://api.github.com/repos/neo/bird-man/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neo/bird-man/statuses/{sha}","languages_url":"https://api.github.com/repos/neo/bird-man/languages","stargazers_url":"https://api.github.com/repos/neo/bird-man/stargazers","contributors_url":"https://api.github.com/repos/neo/bird-man/contributors","subscribers_url":"https://api.github.com/repos/neo/bird-man/subscribers","subscription_url":"https://api.github.com/repos/neo/bird-man/subscription","commits_url":"https://api.github.com/repos/neo/bird-man/commits{/sha}","git_commits_url":"https://api.github.com/repos/neo/bird-man/git/commits{/sha}","comments_url":"https://api.github.com/repos/neo/bird-man/comments{/number}","issue_comment_url":"https://api.github.com/repos/neo/bird-man/issues/comments/{number}","contents_url":"https://api.github.com/repos/neo/bird-man/contents/{+path}","compare_url":"https://api.github.com/repos/neo/bird-man/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neo/bird-man/merges","archive_url":"https://api.github.com/repos/neo/bird-man/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neo/bird-man/downloads","issues_url":"https://api.github.com/repos/neo/bird-man/issues{/number}","pulls_url":"https://api.github.com/repos/neo/bird-man/pulls{/number}","milestones_url":"https://api.github.com/repos/neo/bird-man/milestones{/number}","notifications_url":"https://api.github.com/repos/neo/bird-man/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neo/bird-man/labels{/name}","releases_url":"https://api.github.com/repos/neo/bird-man/releases{/id}","created_at":"2014-01-24T21:21:19Z","updated_at":"2014-06-27T18:18:21Z","pushed_at":"2014-09-12T21:06:53Z","git_url":"git://github.com/neo/bird-man.git","ssh_url":"git@github.com:neo/bird-man.git","clone_url":"https://github.com/neo/bird-man.git","svn_url":"https://github.com/neo/bird-man","homepage":null,"size":2856,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"neo:master","ref":"master","sha":"6d76c0dca36d6d4c907c6d8df2789e2375c7c42d","user":{"login":"neo","id":3138245,"avatar_url":"https://avatars.githubusercontent.com/u/3138245?v=2","gravatar_id":"c7c31e9d8d380b6ecc717966d56f604d","url":"https://api.github.com/users/neo","html_url":"https://github.com/neo","followers_url":"https://api.github.com/users/neo/followers","following_url":"https://api.github.com/users/neo/following{/other_user}","gists_url":"https://api.github.com/users/neo/gists{/gist_id}","starred_url":"https://api.github.com/users/neo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo/subscriptions","organizations_url":"https://api.github.com/users/neo/orgs","repos_url":"https://api.github.com/users/neo/repos","events_url":"https://api.github.com/users/neo/events{/privacy}","received_events_url":"https://api.github.com/users/neo/received_events","type":"Organization","site_admin":false},"repo":{"id":16217315,"name":"bird-man","full_name":"neo/bird-man","owner":{"login":"neo","id":3138245,"avatar_url":"https://avatars.githubusercontent.com/u/3138245?v=2","gravatar_id":"c7c31e9d8d380b6ecc717966d56f604d","url":"https://api.github.com/users/neo","html_url":"https://github.com/neo","followers_url":"https://api.github.com/users/neo/followers","following_url":"https://api.github.com/users/neo/following{/other_user}","gists_url":"https://api.github.com/users/neo/gists{/gist_id}","starred_url":"https://api.github.com/users/neo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo/subscriptions","organizations_url":"https://api.github.com/users/neo/orgs","repos_url":"https://api.github.com/users/neo/repos","events_url":"https://api.github.com/users/neo/events{/privacy}","received_events_url":"https://api.github.com/users/neo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neo/bird-man","description":"An api for eBird data","fork":false,"url":"https://api.github.com/repos/neo/bird-man","forks_url":"https://api.github.com/repos/neo/bird-man/forks","keys_url":"https://api.github.com/repos/neo/bird-man/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neo/bird-man/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neo/bird-man/teams","hooks_url":"https://api.github.com/repos/neo/bird-man/hooks","issue_events_url":"https://api.github.com/repos/neo/bird-man/issues/events{/number}","events_url":"https://api.github.com/repos/neo/bird-man/events","assignees_url":"https://api.github.com/repos/neo/bird-man/assignees{/user}","branches_url":"https://api.github.com/repos/neo/bird-man/branches{/branch}","tags_url":"https://api.github.com/repos/neo/bird-man/tags","blobs_url":"https://api.github.com/repos/neo/bird-man/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neo/bird-man/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neo/bird-man/git/refs{/sha}","trees_url":"https://api.github.com/repos/neo/bird-man/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neo/bird-man/statuses/{sha}","languages_url":"https://api.github.com/repos/neo/bird-man/languages","stargazers_url":"https://api.github.com/repos/neo/bird-man/stargazers","contributors_url":"https://api.github.com/repos/neo/bird-man/contributors","subscribers_url":"https://api.github.com/repos/neo/bird-man/subscribers","subscription_url":"https://api.github.com/repos/neo/bird-man/subscription","commits_url":"https://api.github.com/repos/neo/bird-man/commits{/sha}","git_commits_url":"https://api.github.com/repos/neo/bird-man/git/commits{/sha}","comments_url":"https://api.github.com/repos/neo/bird-man/comments{/number}","issue_comment_url":"https://api.github.com/repos/neo/bird-man/issues/comments/{number}","contents_url":"https://api.github.com/repos/neo/bird-man/contents/{+path}","compare_url":"https://api.github.com/repos/neo/bird-man/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neo/bird-man/merges","archive_url":"https://api.github.com/repos/neo/bird-man/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neo/bird-man/downloads","issues_url":"https://api.github.com/repos/neo/bird-man/issues{/number}","pulls_url":"https://api.github.com/repos/neo/bird-man/pulls{/number}","milestones_url":"https://api.github.com/repos/neo/bird-man/milestones{/number}","notifications_url":"https://api.github.com/repos/neo/bird-man/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neo/bird-man/labels{/name}","releases_url":"https://api.github.com/repos/neo/bird-man/releases{/id}","created_at":"2014-01-24T21:21:19Z","updated_at":"2014-06-27T18:18:21Z","pushed_at":"2014-09-12T21:06:53Z","git_url":"git://github.com/neo/bird-man.git","ssh_url":"git@github.com:neo/bird-man.git","clone_url":"https://github.com/neo/bird-man.git","svn_url":"https://github.com/neo/bird-man","homepage":null,"size":2856,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/neo/bird-man/pulls/23"},"html":{"href":"https://github.com/neo/bird-man/pull/23"},"issue":{"href":"https://api.github.com/repos/neo/bird-man/issues/23"},"comments":{"href":"https://api.github.com/repos/neo/bird-man/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/neo/bird-man/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/neo/bird-man/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/neo/bird-man/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/neo/bird-man/statuses/ffd6eb1765f6c6d9273a41b99b35ebda4740b5b5"}}}}