GitHub PullRequestReviewCommentEvent at 2014-12-11 23:47:26
Repository: orogen
Actor: doudou
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/orocos-toolchain/orogen/pulls/comments/21719543","id":21719543,"diff_hunk":"@@ -1380,18 +1383,18 @@ def resolve_full_include_path_to_relative(file, include_path)\n             def existing_orogen_include_for_type(type)\n                 if imported_types.include?(type.name)\n                     metadata = imported_types.get(type.name).metadata\n-                    if metadata.include?('orogen_include')\n+                    if not metadata.get('orogen_include').empty?","path":"lib/orogen/gen/typekit.rb","position":39,"original_position":39,"commit_id":"e7474ac25805d5ccadc55b996efa4ababfb2f308","original_commit_id":"e7474ac25805d5ccadc55b996efa4ababfb2f308","user":{"login":"doudou","id":292,"avatar_url":"https://avatars.githubusercontent.com/u/292?v=3","gravatar_id":"","url":"https://api.github.com/users/doudou","html_url":"https://github.com/doudou","followers_url":"https://api.github.com/users/doudou/followers","following_url":"https://api.github.com/users/doudou/following{/other_user}","gists_url":"https://api.github.com/users/doudou/gists{/gist_id}","starred_url":"https://api.github.com/users/doudou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doudou/subscriptions","organizations_url":"https://api.github.com/users/doudou/orgs","repos_url":"https://api.github.com/users/doudou/repos","events_url":"https://api.github.com/users/doudou/events{/privacy}","received_events_url":"https://api.github.com/users/doudou/received_events","type":"User","site_admin":false},"body":"MetaData#include? is defined, but on typelib master. I believe that you had the problem because you did not merge typelib master into your branch. The two are not equivalent. Using include? allows to set the orogen_include to an empty set, which ensures that no includes are added (critical for fundamental types).","created_at":"2014-12-11T23:47:26Z","updated_at":"2014-12-11T23:47:26Z","html_url":"https://github.com/orocos-toolchain/orogen/pull/27#discussion_r21719543","pull_request_url":"https://api.github.com/repos/orocos-toolchain/orogen/pulls/27","_links":{"self":{"href":"https://api.github.com/repos/orocos-toolchain/orogen/pulls/comments/21719543"},"html":{"href":"https://github.com/orocos-toolchain/orogen/pull/27#discussion_r21719543"},"pull_request":{"href":"https://api.github.com/repos/orocos-toolchain/orogen/pulls/27"}}},"pull_request":{"url":"https://api.github.com/repos/orocos-toolchain/orogen/pulls/27","id":25904168,"html_url":"https://github.com/orocos-toolchain/orogen/pull/27","diff_url":"https://github.com/orocos-toolchain/orogen/pull/27.diff","patch_url":"https://github.com/orocos-toolchain/orogen/pull/27.patch","issue_url":"https://api.github.com/repos/orocos-toolchain/orogen/issues/27","number":27,"state":"open","locked":false,"title":"Minor fixes","user":{"login":"marvin2k","id":226794,"avatar_url":"https://avatars.githubusercontent.com/u/226794?v=3","gravatar_id":"","url":"https://api.github.com/users/marvin2k","html_url":"https://github.com/marvin2k","followers_url":"https://api.github.com/users/marvin2k/followers","following_url":"https://api.github.com/users/marvin2k/following{/other_user}","gists_url":"https://api.github.com/users/marvin2k/gists{/gist_id}","starred_url":"https://api.github.com/users/marvin2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marvin2k/subscriptions","organizations_url":"https://api.github.com/users/marvin2k/orgs","repos_url":"https://api.github.com/users/marvin2k/repos","events_url":"https://api.github.com/users/marvin2k/events{/privacy}","received_events_url":"https://api.github.com/users/marvin2k/received_events","type":"User","site_admin":false},"body":"collected during switch to clang, but unrelated. Wanna merge them separately. Have a closer look at a304e27fa735385b5c1432dfdda66d42f734aad7\r\n\r\n","created_at":"2014-12-11T14:44:31Z","updated_at":"2014-12-11T23:47:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e30155886413c1ff15d08eee990a6d3620fcb41","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/orocos-toolchain/orogen/pulls/27/commits","review_comments_url":"https://api.github.com/repos/orocos-toolchain/orogen/pulls/27/comments","review_comment_url":"https://api.github.com/repos/orocos-toolchain/orogen/pulls/comments/{number}","comments_url":"https://api.github.com/repos/orocos-toolchain/orogen/issues/27/comments","statuses_url":"https://api.github.com/repos/orocos-toolchain/orogen/statuses/e7474ac25805d5ccadc55b996efa4ababfb2f308","head":{"label":"marvin2k:minor_fixes","ref":"minor_fixes","sha":"e7474ac25805d5ccadc55b996efa4ababfb2f308","user":{"login":"marvin2k","id":226794,"avatar_url":"https://avatars.githubusercontent.com/u/226794?v=3","gravatar_id":"","url":"https://api.github.com/users/marvin2k","html_url":"https://github.com/marvin2k","followers_url":"https://api.github.com/users/marvin2k/followers","following_url":"https://api.github.com/users/marvin2k/following{/other_user}","gists_url":"https://api.github.com/users/marvin2k/gists{/gist_id}","starred_url":"https://api.github.com/users/marvin2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marvin2k/subscriptions","organizations_url":"https://api.github.com/users/marvin2k/orgs","repos_url":"https://api.github.com/users/marvin2k/repos","events_url":"https://api.github.com/users/marvin2k/events{/privacy}","received_events_url":"https://api.github.com/users/marvin2k/received_events","type":"User","site_admin":false},"repo":{"id":23953487,"name":"orogen","full_name":"marvin2k/orogen","owner":{"login":"marvin2k","id":226794,"avatar_url":"https://avatars.githubusercontent.com/u/226794?v=3","gravatar_id":"","url":"https://api.github.com/users/marvin2k","html_url":"https://github.com/marvin2k","followers_url":"https://api.github.com/users/marvin2k/followers","following_url":"https://api.github.com/users/marvin2k/following{/other_user}","gists_url":"https://api.github.com/users/marvin2k/gists{/gist_id}","starred_url":"https://api.github.com/users/marvin2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marvin2k/subscriptions","organizations_url":"https://api.github.com/users/marvin2k/orgs","repos_url":"https://api.github.com/users/marvin2k/repos","events_url":"https://api.github.com/users/marvin2k/events{/privacy}","received_events_url":"https://api.github.com/users/marvin2k/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marvin2k/orogen","description":"Component, typekit and deployment code generator.","fork":true,"url":"https://api.github.com/repos/marvin2k/orogen","forks_url":"https://api.github.com/repos/marvin2k/orogen/forks","keys_url":"https://api.github.com/repos/marvin2k/orogen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marvin2k/orogen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marvin2k/orogen/teams","hooks_url":"https://api.github.com/repos/marvin2k/orogen/hooks","issue_events_url":"https://api.github.com/repos/marvin2k/orogen/issues/events{/number}","events_url":"https://api.github.com/repos/marvin2k/orogen/events","assignees_url":"https://api.github.com/repos/marvin2k/orogen/assignees{/user}","branches_url":"https://api.github.com/repos/marvin2k/orogen/branches{/branch}","tags_url":"https://api.github.com/repos/marvin2k/orogen/tags","blobs_url":"https://api.github.com/repos/marvin2k/orogen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marvin2k/orogen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marvin2k/orogen/git/refs{/sha}","trees_url":"https://api.github.com/repos/marvin2k/orogen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marvin2k/orogen/statuses/{sha}","languages_url":"https://api.github.com/repos/marvin2k/orogen/languages","stargazers_url":"https://api.github.com/repos/marvin2k/orogen/stargazers","contributors_url":"https://api.github.com/repos/marvin2k/orogen/contributors","subscribers_url":"https://api.github.com/repos/marvin2k/orogen/subscribers","subscription_url":"https://api.github.com/repos/marvin2k/orogen/subscription","commits_url":"https://api.github.com/repos/marvin2k/orogen/commits{/sha}","git_commits_url":"https://api.github.com/repos/marvin2k/orogen/git/commits{/sha}","comments_url":"https://api.github.com/repos/marvin2k/orogen/comments{/number}","issue_comment_url":"https://api.github.com/repos/marvin2k/orogen/issues/comments/{number}","contents_url":"https://api.github.com/repos/marvin2k/orogen/contents/{+path}","compare_url":"https://api.github.com/repos/marvin2k/orogen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marvin2k/orogen/merges","archive_url":"https://api.github.com/repos/marvin2k/orogen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marvin2k/orogen/downloads","issues_url":"https://api.github.com/repos/marvin2k/orogen/issues{/number}","pulls_url":"https://api.github.com/repos/marvin2k/orogen/pulls{/number}","milestones_url":"https://api.github.com/repos/marvin2k/orogen/milestones{/number}","notifications_url":"https://api.github.com/repos/marvin2k/orogen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marvin2k/orogen/labels{/name}","releases_url":"https://api.github.com/repos/marvin2k/orogen/releases{/id}","created_at":"2014-09-12T08:47:51Z","updated_at":"2014-09-10T13:18:55Z","pushed_at":"2014-12-11T14:44:10Z","git_url":"git://github.com/marvin2k/orogen.git","ssh_url":"git@github.com:marvin2k/orogen.git","clone_url":"https://github.com/marvin2k/orogen.git","svn_url":"https://github.com/marvin2k/orogen","homepage":null,"size":4110,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"orocos-toolchain:master","ref":"master","sha":"b0c55a10e612e7e9cdcb5e3d6b21db88374ed9e1","user":{"login":"orocos-toolchain","id":2902399,"avatar_url":"https://avatars.githubusercontent.com/u/2902399?v=3","gravatar_id":"","url":"https://api.github.com/users/orocos-toolchain","html_url":"https://github.com/orocos-toolchain","followers_url":"https://api.github.com/users/orocos-toolchain/followers","following_url":"https://api.github.com/users/orocos-toolchain/following{/other_user}","gists_url":"https://api.github.com/users/orocos-toolchain/gists{/gist_id}","starred_url":"https://api.github.com/users/orocos-toolchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orocos-toolchain/subscriptions","organizations_url":"https://api.github.com/users/orocos-toolchain/orgs","repos_url":"https://api.github.com/users/orocos-toolchain/repos","events_url":"https://api.github.com/users/orocos-toolchain/events{/privacy}","received_events_url":"https://api.github.com/users/orocos-toolchain/received_events","type":"Organization","site_admin":false},"repo":{"id":6884053,"name":"orogen","full_name":"orocos-toolchain/orogen","owner":{"login":"orocos-toolchain","id":2902399,"avatar_url":"https://avatars.githubusercontent.com/u/2902399?v=3","gravatar_id":"","url":"https://api.github.com/users/orocos-toolchain","html_url":"https://github.com/orocos-toolchain","followers_url":"https://api.github.com/users/orocos-toolchain/followers","following_url":"https://api.github.com/users/orocos-toolchain/following{/other_user}","gists_url":"https://api.github.com/users/orocos-toolchain/gists{/gist_id}","starred_url":"https://api.github.com/users/orocos-toolchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orocos-toolchain/subscriptions","organizations_url":"https://api.github.com/users/orocos-toolchain/orgs","repos_url":"https://api.github.com/users/orocos-toolchain/repos","events_url":"https://api.github.com/users/orocos-toolchain/events{/privacy}","received_events_url":"https://api.github.com/users/orocos-toolchain/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/orocos-toolchain/orogen","description":"Component, typekit and deployment code generator.","fork":false,"url":"https://api.github.com/repos/orocos-toolchain/orogen","forks_url":"https://api.github.com/repos/orocos-toolchain/orogen/forks","keys_url":"https://api.github.com/repos/orocos-toolchain/orogen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/orocos-toolchain/orogen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/orocos-toolchain/orogen/teams","hooks_url":"https://api.github.com/repos/orocos-toolchain/orogen/hooks","issue_events_url":"https://api.github.com/repos/orocos-toolchain/orogen/issues/events{/number}","events_url":"https://api.github.com/repos/orocos-toolchain/orogen/events","assignees_url":"https://api.github.com/repos/orocos-toolchain/orogen/assignees{/user}","branches_url":"https://api.github.com/repos/orocos-toolchain/orogen/branches{/branch}","tags_url":"https://api.github.com/repos/orocos-toolchain/orogen/tags","blobs_url":"https://api.github.com/repos/orocos-toolchain/orogen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/orocos-toolchain/orogen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/orocos-toolchain/orogen/git/refs{/sha}","trees_url":"https://api.github.com/repos/orocos-toolchain/orogen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/orocos-toolchain/orogen/statuses/{sha}","languages_url":"https://api.github.com/repos/orocos-toolchain/orogen/languages","stargazers_url":"https://api.github.com/repos/orocos-toolchain/orogen/stargazers","contributors_url":"https://api.github.com/repos/orocos-toolchain/orogen/contributors","subscribers_url":"https://api.github.com/repos/orocos-toolchain/orogen/subscribers","subscription_url":"https://api.github.com/repos/orocos-toolchain/orogen/subscription","commits_url":"https://api.github.com/repos/orocos-toolchain/orogen/commits{/sha}","git_commits_url":"https://api.github.com/repos/orocos-toolchain/orogen/git/commits{/sha}","comments_url":"https://api.github.com/repos/orocos-toolchain/orogen/comments{/number}","issue_comment_url":"https://api.github.com/repos/orocos-toolchain/orogen/issues/comments/{number}","contents_url":"https://api.github.com/repos/orocos-toolchain/orogen/contents/{+path}","compare_url":"https://api.github.com/repos/orocos-toolchain/orogen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/orocos-toolchain/orogen/merges","archive_url":"https://api.github.com/repos/orocos-toolchain/orogen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/orocos-toolchain/orogen/downloads","issues_url":"https://api.github.com/repos/orocos-toolchain/orogen/issues{/number}","pulls_url":"https://api.github.com/repos/orocos-toolchain/orogen/pulls{/number}","milestones_url":"https://api.github.com/repos/orocos-toolchain/orogen/milestones{/number}","notifications_url":"https://api.github.com/repos/orocos-toolchain/orogen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/orocos-toolchain/orogen/labels{/name}","releases_url":"https://api.github.com/repos/orocos-toolchain/orogen/releases{/id}","created_at":"2012-11-27T13:46:32Z","updated_at":"2014-12-03T12:06:37Z","pushed_at":"2014-12-03T14:25:01Z","git_url":"git://github.com/orocos-toolchain/orogen.git","ssh_url":"git@github.com:orocos-toolchain/orogen.git","clone_url":"https://github.com/orocos-toolchain/orogen.git","svn_url":"https://github.com/orocos-toolchain/orogen","homepage":null,"size":5122,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":8,"forks":11,"open_issues":8,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/orocos-toolchain/orogen/pulls/27"},"html":{"href":"https://github.com/orocos-toolchain/orogen/pull/27"},"issue":{"href":"https://api.github.com/repos/orocos-toolchain/orogen/issues/27"},"comments":{"href":"https://api.github.com/repos/orocos-toolchain/orogen/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/orocos-toolchain/orogen/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/orocos-toolchain/orogen/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/orocos-toolchain/orogen/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/orocos-toolchain/orogen/statuses/e7474ac25805d5ccadc55b996efa4ababfb2f308"}}}}