GitHub PullRequestReviewCommentEvent at 2014-08-14 16:15:40
Repository: kubernetes
Actor: csrwng
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/16248037","id":16248037,"diff_hunk":"@@ -57,6 +57,13 @@ var (\n \ttemplateStr   = flag.String(\"template\", \"\", \"If present, parse this string as a golang template and use it for output printing\")\n )\n \n+var parser = kubecfg.NewParser(map[string]reflect.Type{\n+\t\"pods\":                   reflect.TypeOf(api.Pod{}),","path":"cmd/kubecfg/kubecfg.go","position":null,"original_position":5,"commit_id":"481d6a6090ae30115f55fef59a4a6ea8ec2f2492","original_commit_id":"fd55ffb98ed784ef53b162b5168f542d730c91cc","user":{"login":"csrwng","id":5834976,"avatar_url":"https://avatars.githubusercontent.com/u/5834976?v=2","gravatar_id":"4727a3b6fcd14d3496674443d6fccfbe","url":"https://api.github.com/users/csrwng","html_url":"https://github.com/csrwng","followers_url":"https://api.github.com/users/csrwng/followers","following_url":"https://api.github.com/users/csrwng/following{/other_user}","gists_url":"https://api.github.com/users/csrwng/gists{/gist_id}","starred_url":"https://api.github.com/users/csrwng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csrwng/subscriptions","organizations_url":"https://api.github.com/users/csrwng/orgs","repos_url":"https://api.github.com/users/csrwng/repos","events_url":"https://api.github.com/users/csrwng/events{/privacy}","received_events_url":"https://api.github.com/users/csrwng/received_events","type":"User","site_admin":false},"body":"makes sense, updated","created_at":"2014-08-14T16:15:40Z","updated_at":"2014-08-14T16:15:40Z","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/888#discussion_r16248037","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/888","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/16248037"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/888#discussion_r16248037"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/888"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/888","id":19758344,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/888","diff_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/888.diff","patch_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/888.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/888","number":888,"state":"open","locked":false,"title":"Allow kubecfg to parse other types via register function","user":{"login":"csrwng","id":5834976,"avatar_url":"https://avatars.githubusercontent.com/u/5834976?v=2","gravatar_id":"4727a3b6fcd14d3496674443d6fccfbe","url":"https://api.github.com/users/csrwng","html_url":"https://github.com/csrwng","followers_url":"https://api.github.com/users/csrwng/followers","following_url":"https://api.github.com/users/csrwng/following{/other_user}","gists_url":"https://api.github.com/users/csrwng/gists{/gist_id}","starred_url":"https://api.github.com/users/csrwng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csrwng/subscriptions","organizations_url":"https://api.github.com/users/csrwng/orgs","repos_url":"https://api.github.com/users/csrwng/repos","events_url":"https://api.github.com/users/csrwng/events{/privacy}","received_events_url":"https://api.github.com/users/csrwng/received_events","type":"User","site_admin":false},"body":"This allows registering other types with kubecfg so they can be parsed in the command line as well.","created_at":"2014-08-13T22:43:24Z","updated_at":"2014-08-14T16:15:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3d1817dc401b6435c3a7483ce966346416e96ce8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/888/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/888/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/{number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/888/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/481d6a6090ae30115f55fef59a4a6ea8ec2f2492","head":{"label":"csrwng:pluggable_type_parsing","ref":"pluggable_type_parsing","sha":"481d6a6090ae30115f55fef59a4a6ea8ec2f2492","user":{"login":"csrwng","id":5834976,"avatar_url":"https://avatars.githubusercontent.com/u/5834976?v=2","gravatar_id":"4727a3b6fcd14d3496674443d6fccfbe","url":"https://api.github.com/users/csrwng","html_url":"https://github.com/csrwng","followers_url":"https://api.github.com/users/csrwng/followers","following_url":"https://api.github.com/users/csrwng/following{/other_user}","gists_url":"https://api.github.com/users/csrwng/gists{/gist_id}","starred_url":"https://api.github.com/users/csrwng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csrwng/subscriptions","organizations_url":"https://api.github.com/users/csrwng/orgs","repos_url":"https://api.github.com/users/csrwng/repos","events_url":"https://api.github.com/users/csrwng/events{/privacy}","received_events_url":"https://api.github.com/users/csrwng/received_events","type":"User","site_admin":false},"repo":{"id":21752113,"name":"kubernetes","full_name":"csrwng/kubernetes","owner":{"login":"csrwng","id":5834976,"avatar_url":"https://avatars.githubusercontent.com/u/5834976?v=2","gravatar_id":"4727a3b6fcd14d3496674443d6fccfbe","url":"https://api.github.com/users/csrwng","html_url":"https://github.com/csrwng","followers_url":"https://api.github.com/users/csrwng/followers","following_url":"https://api.github.com/users/csrwng/following{/other_user}","gists_url":"https://api.github.com/users/csrwng/gists{/gist_id}","starred_url":"https://api.github.com/users/csrwng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csrwng/subscriptions","organizations_url":"https://api.github.com/users/csrwng/orgs","repos_url":"https://api.github.com/users/csrwng/repos","events_url":"https://api.github.com/users/csrwng/events{/privacy}","received_events_url":"https://api.github.com/users/csrwng/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/csrwng/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/csrwng/kubernetes","forks_url":"https://api.github.com/repos/csrwng/kubernetes/forks","keys_url":"https://api.github.com/repos/csrwng/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/csrwng/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/csrwng/kubernetes/teams","hooks_url":"https://api.github.com/repos/csrwng/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/csrwng/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/csrwng/kubernetes/events","assignees_url":"https://api.github.com/repos/csrwng/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/csrwng/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/csrwng/kubernetes/tags","blobs_url":"https://api.github.com/repos/csrwng/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/csrwng/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/csrwng/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/csrwng/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/csrwng/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/csrwng/kubernetes/languages","stargazers_url":"https://api.github.com/repos/csrwng/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/csrwng/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/csrwng/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/csrwng/kubernetes/subscription","commits_url":"https://api.github.com/repos/csrwng/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/csrwng/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/csrwng/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/csrwng/kubernetes/issues/comments/{number}","contents_url":"https://api.github.com/repos/csrwng/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/csrwng/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/csrwng/kubernetes/merges","archive_url":"https://api.github.com/repos/csrwng/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/csrwng/kubernetes/downloads","issues_url":"https://api.github.com/repos/csrwng/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/csrwng/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/csrwng/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/csrwng/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/csrwng/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/csrwng/kubernetes/releases{/id}","created_at":"2014-07-11T21:33:52Z","updated_at":"2014-07-14T13:39:07Z","pushed_at":"2014-08-14T16:14:32Z","git_url":"git://github.com/csrwng/kubernetes.git","ssh_url":"git@github.com:csrwng/kubernetes.git","clone_url":"https://github.com/csrwng/kubernetes.git","svn_url":"https://github.com/csrwng/kubernetes","homepage":null,"size":8174,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"e1998e5a07e56543a60f4f4bfaac0cc9a96a1424","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=2","gravatar_id":"3db02c6238c8b1fb844871330744ec5d","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"GoogleCloudPlatform/kubernetes","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=2","gravatar_id":"3db02c6238c8b1fb844871330744ec5d","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes","description":"Container Cluster Manager","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/comments/{number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2014-08-14T16:06:22Z","pushed_at":"2014-08-13T22:59:43Z","git_url":"git://github.com/GoogleCloudPlatform/kubernetes.git","ssh_url":"git@github.com:GoogleCloudPlatform/kubernetes.git","clone_url":"https://github.com/GoogleCloudPlatform/kubernetes.git","svn_url":"https://github.com/GoogleCloudPlatform/kubernetes","homepage":null,"size":21301,"stargazers_count":3007,"watchers_count":3007,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":383,"mirror_url":null,"open_issues_count":157,"forks":383,"open_issues":157,"watchers":3007,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/888"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/888"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/888"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/888/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/888/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/888/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/481d6a6090ae30115f55fef59a4a6ea8ec2f2492"}}}}