GitHub PullRequestEvent at 2014-05-30 20:09:08
Repository: Cataclysm-DDA
Actor: BevapDin
Payload: {"action":"opened","number":7789,"pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/7789","id":16552355,"html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/7789","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/7789.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/7789.patch","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/7789","number":7789,"state":"open","title":"Add check for empty default ammo type when spawning matching ammo for guns","user":{"login":"BevapDin","id":5095435,"avatar_url":"https://avatars.githubusercontent.com/u/5095435?","gravatar_id":"e453b8ec0e85e4d9d5ce7a6c1285c4a3","url":"https://api.github.com/users/BevapDin","html_url":"https://github.com/BevapDin","followers_url":"https://api.github.com/users/BevapDin/followers","following_url":"https://api.github.com/users/BevapDin/following{/other_user}","gists_url":"https://api.github.com/users/BevapDin/gists{/gist_id}","starred_url":"https://api.github.com/users/BevapDin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BevapDin/subscriptions","organizations_url":"https://api.github.com/users/BevapDin/orgs","repos_url":"https://api.github.com/users/BevapDin/repos","events_url":"https://api.github.com/users/BevapDin/events{/privacy}","received_events_url":"https://api.github.com/users/BevapDin/received_events","type":"User","site_admin":false},"body":"The ammo type \"darts\" does not come with a default ammo item type. Because the blowgun is in an item group (\"homeguns\") which should spawn the matching ammo for guns (`guns_with_ammo:true`), this would spawn an item with an empty string as ident (\"darts\" has this as default ammo), this shows up as \"undefined-s\".\r\n\r\nThis PR adds a check to prevent this behavior. One could additionally define a default ammo item type for darts, but this kind of error might come up for other guns, too.","created_at":"2014-05-30T20:09:07Z","updated_at":"2014-05-30T20:09:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/7789/commits","review_comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/7789/comments","review_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/{number}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/7789/comments","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/72196c89f563fe76c3eaedb7cfb3ee151b082b54","head":{"label":"BevapDin:fix-item-spanwammo","ref":"fix-item-spanwammo","sha":"72196c89f563fe76c3eaedb7cfb3ee151b082b54","user":{"login":"BevapDin","id":5095435,"avatar_url":"https://avatars.githubusercontent.com/u/5095435?","gravatar_id":"e453b8ec0e85e4d9d5ce7a6c1285c4a3","url":"https://api.github.com/users/BevapDin","html_url":"https://github.com/BevapDin","followers_url":"https://api.github.com/users/BevapDin/followers","following_url":"https://api.github.com/users/BevapDin/following{/other_user}","gists_url":"https://api.github.com/users/BevapDin/gists{/gist_id}","starred_url":"https://api.github.com/users/BevapDin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BevapDin/subscriptions","organizations_url":"https://api.github.com/users/BevapDin/orgs","repos_url":"https://api.github.com/users/BevapDin/repos","events_url":"https://api.github.com/users/BevapDin/events{/privacy}","received_events_url":"https://api.github.com/users/BevapDin/received_events","type":"User","site_admin":false},"repo":{"id":11775770,"name":"Cataclysm-DDA","full_name":"BevapDin/Cataclysm-DDA","owner":{"login":"BevapDin","id":5095435,"avatar_url":"https://avatars.githubusercontent.com/u/5095435?","gravatar_id":"e453b8ec0e85e4d9d5ce7a6c1285c4a3","url":"https://api.github.com/users/BevapDin","html_url":"https://github.com/BevapDin","followers_url":"https://api.github.com/users/BevapDin/followers","following_url":"https://api.github.com/users/BevapDin/following{/other_user}","gists_url":"https://api.github.com/users/BevapDin/gists{/gist_id}","starred_url":"https://api.github.com/users/BevapDin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BevapDin/subscriptions","organizations_url":"https://api.github.com/users/BevapDin/orgs","repos_url":"https://api.github.com/users/BevapDin/repos","events_url":"https://api.github.com/users/BevapDin/events{/privacy}","received_events_url":"https://api.github.com/users/BevapDin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BevapDin/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A fork/variant of Cataclysm Roguelike by Whales.","fork":true,"url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA","forks_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/issues/comments/{number}","contents_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/releases{/id}","created_at":"2013-07-30T21:12:59Z","updated_at":"2014-05-30T20:09:07Z","pushed_at":"2014-05-30T20:06:40Z","git_url":"git://github.com/BevapDin/Cataclysm-DDA.git","ssh_url":"git@github.com:BevapDin/Cataclysm-DDA.git","clone_url":"https://github.com/BevapDin/Cataclysm-DDA.git","svn_url":"https://github.com/BevapDin/Cataclysm-DDA","homepage":"http://en.cataclysmdda.com/","size":137575,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"CleverRaven:master","ref":"master","sha":"6def3c215ad13d01949912ee80b2bfd02caea4be","user":{"login":"CleverRaven","id":4367009,"avatar_url":"https://avatars.githubusercontent.com/u/4367009?","gravatar_id":null,"url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"repo":{"id":5973855,"name":"Cataclysm-DDA","full_name":"CleverRaven/Cataclysm-DDA","owner":{"login":"CleverRaven","id":4367009,"avatar_url":"https://avatars.githubusercontent.com/u/4367009?","gravatar_id":null,"url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CleverRaven/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A fork/variant of Cataclysm Roguelike by Whales.","fork":false,"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA","forks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments/{number}","contents_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/releases{/id}","created_at":"2012-09-26T22:57:43Z","updated_at":"2014-05-30T10:21:48Z","pushed_at":"2014-05-30T07:00:34Z","git_url":"git://github.com/CleverRaven/Cataclysm-DDA.git","ssh_url":"git@github.com:CleverRaven/Cataclysm-DDA.git","clone_url":"https://github.com/CleverRaven/Cataclysm-DDA.git","svn_url":"https://github.com/CleverRaven/Cataclysm-DDA","homepage":"http://en.cataclysmdda.com/","size":207298,"stargazers_count":408,"watchers_count":408,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":475,"mirror_url":null,"open_issues_count":727,"forks":475,"open_issues":727,"watchers":408,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/7789"},"html":{"href":"https://github.com/CleverRaven/Cataclysm-DDA/pull/7789"},"issue":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/7789"},"comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/7789/comments"},"review_comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/7789/comments"},"review_comment":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/7789/commits"},"statuses":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/72196c89f563fe76c3eaedb7cfb3ee151b082b54"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":7,"deletions":4,"changed_files":1}}