GitHub PullRequestEvent at 2014-04-05 10:02:32
Repository: assetgraph
Actor: Munter
Payload: {"action":"closed","number":176,"pull_request":{"url":"https://api.github.com/repos/assetgraph/assetgraph/pulls/176","id":13346805,"html_url":"https://github.com/assetgraph/assetgraph/pull/176","diff_url":"https://github.com/assetgraph/assetgraph/pull/176.diff","patch_url":"https://github.com/assetgraph/assetgraph/pull/176.patch","issue_url":"https://api.github.com/repos/assetgraph/assetgraph/issues/176","number":176,"state":"closed","title":"assets/Html: Replace commonly known templating syntaxes that produce inv...","user":{"login":"Munter","id":331790,"avatar_url":"https://avatars.githubusercontent.com/u/331790?","gravatar_id":"01349d877b6e4b9c0ddbadf97f07fa0d","url":"https://api.github.com/users/Munter","html_url":"https://github.com/Munter","followers_url":"https://api.github.com/users/Munter/followers","following_url":"https://api.github.com/users/Munter/following{/other_user}","gists_url":"https://api.github.com/users/Munter/gists{/gist_id}","starred_url":"https://api.github.com/users/Munter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Munter/subscriptions","organizations_url":"https://api.github.com/users/Munter/orgs","repos_url":"https://api.github.com/users/Munter/repos","events_url":"https://api.github.com/users/Munter/events{/privacy}","received_events_url":"https://api.github.com/users/Munter/received_events","type":"User","site_admin":false},"body":"...alid html with internal placeholders while working with the parsetree. Inject original content back when using HTML.text getter\r\n\r\nThis adds support for underscore templates, jsp, asp, php. Any language using `<% ... %>` or `<? ... ?>` for inserting stuff inside html. Still no guarantees that the resulting html is valid. It's up to the user to avoid stupidity here.\r\n\r\nCloses https://github.com/assetgraph/assetgraph-builder/issues/44\r\n\r\n@papandreou This is a heads up. I have no tests yet to verify, other that a successful build of some todomvc apps. I'll work on tests tomorrow, but I'd like some feedback on this change since it feels a bit dirty to me.","created_at":"2014-03-09T00:12:00Z","updated_at":"2014-04-05T10:02:31Z","closed_at":"2014-04-05T10:02:31Z","merged_at":"2014-04-05T10:02:31Z","merge_commit_sha":"36a71b37e429d694c8e3969656c0890be537e80a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/assetgraph/assetgraph/pulls/176/commits","review_comments_url":"https://api.github.com/repos/assetgraph/assetgraph/pulls/176/comments","review_comment_url":"https://api.github.com/repos/assetgraph/assetgraph/pulls/comments/{number}","comments_url":"https://api.github.com/repos/assetgraph/assetgraph/issues/176/comments","statuses_url":"https://api.github.com/repos/assetgraph/assetgraph/statuses/612f56b118cb40b8fe30dc3d5fe1024c60c2920c","head":{"label":"assetgraph:templates","ref":"templates","sha":"612f56b118cb40b8fe30dc3d5fe1024c60c2920c","user":{"login":"assetgraph","id":6302962,"avatar_url":"https://avatars.githubusercontent.com/u/6302962?","gravatar_id":"62fe71a919760c3197217a2fde7e8a46","url":"https://api.github.com/users/assetgraph","html_url":"https://github.com/assetgraph","followers_url":"https://api.github.com/users/assetgraph/followers","following_url":"https://api.github.com/users/assetgraph/following{/other_user}","gists_url":"https://api.github.com/users/assetgraph/gists{/gist_id}","starred_url":"https://api.github.com/users/assetgraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/assetgraph/subscriptions","organizations_url":"https://api.github.com/users/assetgraph/orgs","repos_url":"https://api.github.com/users/assetgraph/repos","events_url":"https://api.github.com/users/assetgraph/events{/privacy}","received_events_url":"https://api.github.com/users/assetgraph/received_events","type":"Organization","site_admin":false},"repo":{"id":1324028,"name":"assetgraph","full_name":"assetgraph/assetgraph","owner":{"login":"assetgraph","id":6302962,"avatar_url":"https://avatars.githubusercontent.com/u/6302962?","gravatar_id":"62fe71a919760c3197217a2fde7e8a46","url":"https://api.github.com/users/assetgraph","html_url":"https://github.com/assetgraph","followers_url":"https://api.github.com/users/assetgraph/followers","following_url":"https://api.github.com/users/assetgraph/following{/other_user}","gists_url":"https://api.github.com/users/assetgraph/gists{/gist_id}","starred_url":"https://api.github.com/users/assetgraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/assetgraph/subscriptions","organizations_url":"https://api.github.com/users/assetgraph/orgs","repos_url":"https://api.github.com/users/assetgraph/repos","events_url":"https://api.github.com/users/assetgraph/events{/privacy}","received_events_url":"https://api.github.com/users/assetgraph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/assetgraph/assetgraph","description":"Optimization framework for web pages and applications","fork":false,"url":"https://api.github.com/repos/assetgraph/assetgraph","forks_url":"https://api.github.com/repos/assetgraph/assetgraph/forks","keys_url":"https://api.github.com/repos/assetgraph/assetgraph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/assetgraph/assetgraph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/assetgraph/assetgraph/teams","hooks_url":"https://api.github.com/repos/assetgraph/assetgraph/hooks","issue_events_url":"https://api.github.com/repos/assetgraph/assetgraph/issues/events{/number}","events_url":"https://api.github.com/repos/assetgraph/assetgraph/events","assignees_url":"https://api.github.com/repos/assetgraph/assetgraph/assignees{/user}","branches_url":"https://api.github.com/repos/assetgraph/assetgraph/branches{/branch}","tags_url":"https://api.github.com/repos/assetgraph/assetgraph/tags","blobs_url":"https://api.github.com/repos/assetgraph/assetgraph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/assetgraph/assetgraph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/assetgraph/assetgraph/git/refs{/sha}","trees_url":"https://api.github.com/repos/assetgraph/assetgraph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/assetgraph/assetgraph/statuses/{sha}","languages_url":"https://api.github.com/repos/assetgraph/assetgraph/languages","stargazers_url":"https://api.github.com/repos/assetgraph/assetgraph/stargazers","contributors_url":"https://api.github.com/repos/assetgraph/assetgraph/contributors","subscribers_url":"https://api.github.com/repos/assetgraph/assetgraph/subscribers","subscription_url":"https://api.github.com/repos/assetgraph/assetgraph/subscription","commits_url":"https://api.github.com/repos/assetgraph/assetgraph/commits{/sha}","git_commits_url":"https://api.github.com/repos/assetgraph/assetgraph/git/commits{/sha}","comments_url":"https://api.github.com/repos/assetgraph/assetgraph/comments{/number}","issue_comment_url":"https://api.github.com/repos/assetgraph/assetgraph/issues/comments/{number}","contents_url":"https://api.github.com/repos/assetgraph/assetgraph/contents/{+path}","compare_url":"https://api.github.com/repos/assetgraph/assetgraph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/assetgraph/assetgraph/merges","archive_url":"https://api.github.com/repos/assetgraph/assetgraph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/assetgraph/assetgraph/downloads","issues_url":"https://api.github.com/repos/assetgraph/assetgraph/issues{/number}","pulls_url":"https://api.github.com/repos/assetgraph/assetgraph/pulls{/number}","milestones_url":"https://api.github.com/repos/assetgraph/assetgraph/milestones{/number}","notifications_url":"https://api.github.com/repos/assetgraph/assetgraph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/assetgraph/assetgraph/labels{/name}","releases_url":"https://api.github.com/repos/assetgraph/assetgraph/releases{/id}","created_at":"2011-02-03T13:05:29Z","updated_at":"2014-04-05T10:02:31Z","pushed_at":"2014-04-05T10:02:31Z","git_url":"git://github.com/assetgraph/assetgraph.git","ssh_url":"git@github.com:assetgraph/assetgraph.git","clone_url":"https://github.com/assetgraph/assetgraph.git","svn_url":"https://github.com/assetgraph/assetgraph","homepage":"","size":16094,"stargazers_count":267,"watchers_count":267,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":16,"mirror_url":null,"open_issues_count":36,"forks":16,"open_issues":36,"watchers":267,"default_branch":"master","master_branch":"master"}},"base":{"label":"assetgraph:master","ref":"master","sha":"182261b5dfc67ed1496e0d6f6724ded6381de6f7","user":{"login":"assetgraph","id":6302962,"avatar_url":"https://avatars.githubusercontent.com/u/6302962?","gravatar_id":"62fe71a919760c3197217a2fde7e8a46","url":"https://api.github.com/users/assetgraph","html_url":"https://github.com/assetgraph","followers_url":"https://api.github.com/users/assetgraph/followers","following_url":"https://api.github.com/users/assetgraph/following{/other_user}","gists_url":"https://api.github.com/users/assetgraph/gists{/gist_id}","starred_url":"https://api.github.com/users/assetgraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/assetgraph/subscriptions","organizations_url":"https://api.github.com/users/assetgraph/orgs","repos_url":"https://api.github.com/users/assetgraph/repos","events_url":"https://api.github.com/users/assetgraph/events{/privacy}","received_events_url":"https://api.github.com/users/assetgraph/received_events","type":"Organization","site_admin":false},"repo":{"id":1324028,"name":"assetgraph","full_name":"assetgraph/assetgraph","owner":{"login":"assetgraph","id":6302962,"avatar_url":"https://avatars.githubusercontent.com/u/6302962?","gravatar_id":"62fe71a919760c3197217a2fde7e8a46","url":"https://api.github.com/users/assetgraph","html_url":"https://github.com/assetgraph","followers_url":"https://api.github.com/users/assetgraph/followers","following_url":"https://api.github.com/users/assetgraph/following{/other_user}","gists_url":"https://api.github.com/users/assetgraph/gists{/gist_id}","starred_url":"https://api.github.com/users/assetgraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/assetgraph/subscriptions","organizations_url":"https://api.github.com/users/assetgraph/orgs","repos_url":"https://api.github.com/users/assetgraph/repos","events_url":"https://api.github.com/users/assetgraph/events{/privacy}","received_events_url":"https://api.github.com/users/assetgraph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/assetgraph/assetgraph","description":"Optimization framework for web pages and applications","fork":false,"url":"https://api.github.com/repos/assetgraph/assetgraph","forks_url":"https://api.github.com/repos/assetgraph/assetgraph/forks","keys_url":"https://api.github.com/repos/assetgraph/assetgraph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/assetgraph/assetgraph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/assetgraph/assetgraph/teams","hooks_url":"https://api.github.com/repos/assetgraph/assetgraph/hooks","issue_events_url":"https://api.github.com/repos/assetgraph/assetgraph/issues/events{/number}","events_url":"https://api.github.com/repos/assetgraph/assetgraph/events","assignees_url":"https://api.github.com/repos/assetgraph/assetgraph/assignees{/user}","branches_url":"https://api.github.com/repos/assetgraph/assetgraph/branches{/branch}","tags_url":"https://api.github.com/repos/assetgraph/assetgraph/tags","blobs_url":"https://api.github.com/repos/assetgraph/assetgraph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/assetgraph/assetgraph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/assetgraph/assetgraph/git/refs{/sha}","trees_url":"https://api.github.com/repos/assetgraph/assetgraph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/assetgraph/assetgraph/statuses/{sha}","languages_url":"https://api.github.com/repos/assetgraph/assetgraph/languages","stargazers_url":"https://api.github.com/repos/assetgraph/assetgraph/stargazers","contributors_url":"https://api.github.com/repos/assetgraph/assetgraph/contributors","subscribers_url":"https://api.github.com/repos/assetgraph/assetgraph/subscribers","subscription_url":"https://api.github.com/repos/assetgraph/assetgraph/subscription","commits_url":"https://api.github.com/repos/assetgraph/assetgraph/commits{/sha}","git_commits_url":"https://api.github.com/repos/assetgraph/assetgraph/git/commits{/sha}","comments_url":"https://api.github.com/repos/assetgraph/assetgraph/comments{/number}","issue_comment_url":"https://api.github.com/repos/assetgraph/assetgraph/issues/comments/{number}","contents_url":"https://api.github.com/repos/assetgraph/assetgraph/contents/{+path}","compare_url":"https://api.github.com/repos/assetgraph/assetgraph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/assetgraph/assetgraph/merges","archive_url":"https://api.github.com/repos/assetgraph/assetgraph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/assetgraph/assetgraph/downloads","issues_url":"https://api.github.com/repos/assetgraph/assetgraph/issues{/number}","pulls_url":"https://api.github.com/repos/assetgraph/assetgraph/pulls{/number}","milestones_url":"https://api.github.com/repos/assetgraph/assetgraph/milestones{/number}","notifications_url":"https://api.github.com/repos/assetgraph/assetgraph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/assetgraph/assetgraph/labels{/name}","releases_url":"https://api.github.com/repos/assetgraph/assetgraph/releases{/id}","created_at":"2011-02-03T13:05:29Z","updated_at":"2014-04-05T10:02:31Z","pushed_at":"2014-04-05T10:02:31Z","git_url":"git://github.com/assetgraph/assetgraph.git","ssh_url":"git@github.com:assetgraph/assetgraph.git","clone_url":"https://github.com/assetgraph/assetgraph.git","svn_url":"https://github.com/assetgraph/assetgraph","homepage":"","size":16094,"stargazers_count":267,"watchers_count":267,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":16,"mirror_url":null,"open_issues_count":36,"forks":16,"open_issues":36,"watchers":267,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/assetgraph/assetgraph/pulls/176"},"html":{"href":"https://github.com/assetgraph/assetgraph/pull/176"},"issue":{"href":"https://api.github.com/repos/assetgraph/assetgraph/issues/176"},"comments":{"href":"https://api.github.com/repos/assetgraph/assetgraph/issues/176/comments"},"review_comments":{"href":"https://api.github.com/repos/assetgraph/assetgraph/pulls/176/comments"},"review_comment":{"href":"https://api.github.com/repos/assetgraph/assetgraph/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/assetgraph/assetgraph/pulls/176/commits"},"statuses":{"href":"https://api.github.com/repos/assetgraph/assetgraph/statuses/612f56b118cb40b8fe30dc3d5fe1024c60c2920c"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"Munter","id":331790,"avatar_url":"https://avatars.githubusercontent.com/u/331790?","gravatar_id":"01349d877b6e4b9c0ddbadf97f07fa0d","url":"https://api.github.com/users/Munter","html_url":"https://github.com/Munter","followers_url":"https://api.github.com/users/Munter/followers","following_url":"https://api.github.com/users/Munter/following{/other_user}","gists_url":"https://api.github.com/users/Munter/gists{/gist_id}","starred_url":"https://api.github.com/users/Munter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Munter/subscriptions","organizations_url":"https://api.github.com/users/Munter/orgs","repos_url":"https://api.github.com/users/Munter/repos","events_url":"https://api.github.com/users/Munter/events{/privacy}","received_events_url":"https://api.github.com/users/Munter/received_events","type":"User","site_admin":false},"comments":4,"review_comments":1,"commits":2,"additions":151,"deletions":5,"changed_files":2}}