GitHub PullRequestReviewCommentEvent at 2014-03-24 09:34:31
Repository: nixpkgs
Actor: iElectric
Payload: {"comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/10876669","id":10876669,"diff_hunk":"@@ -420,7 +420,7 @@ sub multiLineList {\n \n $bootLoaderConfig\n   # networking.hostName = \"nixos\"; # Define your hostname.\n-  # networking.wireless.enable = true;  # Enables wireless.\n+  # networking.networkmanager.enable = true;  # Enables wireless.","path":"nixos/modules/installer/tools/nixos-generate-config.pl","position":16,"original_position":16,"commit_id":"44340406c90102734b3516bcc2fc0feca19d28b0","original_commit_id":"44340406c90102734b3516bcc2fc0feca19d28b0","user":{"login":"iElectric","id":126339,"avatar_url":"https://avatars.githubusercontent.com/u/126339?","gravatar_id":"64798a399a79ed8d34fa83ba0e61c1ac","url":"https://api.github.com/users/iElectric","html_url":"https://github.com/iElectric","followers_url":"https://api.github.com/users/iElectric/followers","following_url":"https://api.github.com/users/iElectric/following{/other_user}","gists_url":"https://api.github.com/users/iElectric/gists{/gist_id}","starred_url":"https://api.github.com/users/iElectric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iElectric/subscriptions","organizations_url":"https://api.github.com/users/iElectric/orgs","repos_url":"https://api.github.com/users/iElectric/repos","events_url":"https://api.github.com/users/iElectric/events{/privacy}","received_events_url":"https://api.github.com/users/iElectric/received_events","type":"User","site_admin":false},"body":"We could have wireless and networkmanager in there, so people can decide. `openresolv` issue is fixed. I'll add a section to the manual and see if wpa_supplicant tests are any useful.","created_at":"2014-03-24T09:34:31Z","updated_at":"2014-03-24T09:34:31Z","html_url":"https://github.com/NixOS/nixpkgs/pull/1900#discussion_r10876669","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/1900","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/10876669"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/1900#discussion_r10876669"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/1900"}}}}