GitHub PullRequestReviewCommentEvent at 2014-04-16 21:27:08
Repository: gaia
Actor: davidflanagan
Payload: {"comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/11708314","id":11708314,"diff_hunk":"@@ -118,34 +102,49 @@\n   z-index: 100;\n }\n \n-/* TD DO common\n-.preview-controls > * {\n-  display: flex;\n-}*/\n+section[role=\"region\"].skin-dark > header:first-child > button:active,\n+section[role=\"region\"].skin-dark > header:first-child menu[type=\"toolbar\"] button:not(:disabled):active {\n+  background-color: rgba(0, 142, 171, 0.3);\n+}\n \n-.camera-back:active,\n-.preview-gallery-button:active,\n-.preview-share-button:active,\n-.preview-delete-button:active {\n-  background-color: #008EAB;\n-  opacity: 1;\n+section[role=\"region\"].skin-dark > header:first-child > button,\n+section[role=\"region\"].skin-dark > header:first-child menu[type=\"toolbar\"] button:not(:disabled) {\n+  vertical-align: middle;\n+  text-align: center;\n }\n \n-.preview-gallery-button,\n-.preview-share-button,\n-.preview-delete-button {\n-  display: flex;\n-  width: 33%;\n-  height: 100%;\n-  justify-content: center;\n-  color: white;\n+section[role=\"region\"].skin-dark > header:first-child > button {\n+  width: 3rem;\n+}\n+\n+section[role=\"region\"] > header:first-child h1 {\n+  font-weight: normal;\n+  padding: 0 1rem 0 2.8rem;\n+}\n+\n+section[role=\"region\"].skin-dark > header:first-child,\n+.skin-dark > section[role=\"region\"] > header:first-child {\n+   background: rgba(0, 0, 0, 0.75);\n+}\n+\n+.preview-menu [class^=\"icon-\"],\n+.preview-menu [class*=\" icon-\"] {","path":"apps/camera/style/preview-gallery.css","position":78,"original_position":78,"commit_id":"e437dd5075069359fa55e309321348c88f154f8a","original_commit_id":"e437dd5075069359fa55e309321348c88f154f8a","user":{"login":"davidflanagan","id":516914,"avatar_url":"https://avatars.githubusercontent.com/u/516914?","gravatar_id":"a7cc58f54d25826ac0568490237b959d","url":"https://api.github.com/users/davidflanagan","html_url":"https://github.com/davidflanagan","followers_url":"https://api.github.com/users/davidflanagan/followers","following_url":"https://api.github.com/users/davidflanagan/following{/other_user}","gists_url":"https://api.github.com/users/davidflanagan/gists{/gist_id}","starred_url":"https://api.github.com/users/davidflanagan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidflanagan/subscriptions","organizations_url":"https://api.github.com/users/davidflanagan/orgs","repos_url":"https://api.github.com/users/davidflanagan/repos","events_url":"https://api.github.com/users/davidflanagan/events{/privacy}","received_events_url":"https://api.github.com/users/davidflanagan/received_events","type":"User","site_admin":false},"body":"These seem like really inefficient selectors.  In building blocks it is normal practice to give the icons class attributes like class=\"icon icon-back\".    Then you can must match \".icon\" instead of using regexps to look for \"icon-\".  Could you do that here as well?","created_at":"2014-04-16T21:27:08Z","updated_at":"2014-04-16T21:27:08Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/18381#discussion_r11708314","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/18381","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/11708314"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/18381#discussion_r11708314"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/18381"}}}}