GitHub PullRequestReviewCommentEvent at 2014-07-10 10:03:44
Repository: zabbix
Actor: guilhem
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/laradji/zabbix/pulls/comments/14757681","id":14757681,"diff_hunk":"@@ -19,8 +19,6 @@\n # for appropriate inventory hash keys (Property name from the table)\n attribute :inventory, :kind_of => Hash, :default => {}\n \n-attribute :interfaces, :kind_of => Array, :default => []","path":"resources/host.rb","position":4,"original_position":4,"commit_id":"0c991528306afc12e51377b2e567f1803836b76d","original_commit_id":"0c991528306afc12e51377b2e567f1803836b76d","user":{"login":"guilhem","id":486876,"avatar_url":"https://avatars.githubusercontent.com/u/486876?","gravatar_id":"4325b130da2f32a0958930c43bd2cf77","url":"https://api.github.com/users/guilhem","html_url":"https://github.com/guilhem","followers_url":"https://api.github.com/users/guilhem/followers","following_url":"https://api.github.com/users/guilhem/following{/other_user}","gists_url":"https://api.github.com/users/guilhem/gists{/gist_id}","starred_url":"https://api.github.com/users/guilhem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guilhem/subscriptions","organizations_url":"https://api.github.com/users/guilhem/orgs","repos_url":"https://api.github.com/users/guilhem/repos","events_url":"https://api.github.com/users/guilhem/events{/privacy}","received_events_url":"https://api.github.com/users/guilhem/received_events","type":"User","site_admin":false},"body":"Yeah. I like to see small fix like that! :)\r\nThat mean that some people read the code.","created_at":"2014-07-10T10:03:44Z","updated_at":"2014-07-10T10:03:44Z","html_url":"https://github.com/laradji/zabbix/pull/174#discussion_r14757681","pull_request_url":"https://api.github.com/repos/laradji/zabbix/pulls/174","_links":{"self":{"href":"https://api.github.com/repos/laradji/zabbix/pulls/comments/14757681"},"html":{"href":"https://github.com/laradji/zabbix/pull/174#discussion_r14757681"},"pull_request":{"href":"https://api.github.com/repos/laradji/zabbix/pulls/174"}}},"pull_request":{"url":"https://api.github.com/repos/laradji/zabbix/pulls/174","id":18161232,"html_url":"https://github.com/laradji/zabbix/pull/174","diff_url":"https://github.com/laradji/zabbix/pull/174.diff","patch_url":"https://github.com/laradji/zabbix/pull/174.patch","issue_url":"https://api.github.com/repos/laradji/zabbix/issues/174","number":174,"state":"open","title":"Fixing host resource and provider out-of-sync","user":{"login":"nightw","id":220303,"avatar_url":"https://avatars.githubusercontent.com/u/220303?","gravatar_id":"479e9f8aa90eca3db6fb11653614fcc4","url":"https://api.github.com/users/nightw","html_url":"https://github.com/nightw","followers_url":"https://api.github.com/users/nightw/followers","following_url":"https://api.github.com/users/nightw/following{/other_user}","gists_url":"https://api.github.com/users/nightw/gists{/gist_id}","starred_url":"https://api.github.com/users/nightw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nightw/subscriptions","organizations_url":"https://api.github.com/users/nightw/orgs","repos_url":"https://api.github.com/users/nightw/repos","events_url":"https://api.github.com/users/nightw/events{/privacy}","received_events_url":"https://api.github.com/users/nightw/received_events","type":"User","site_admin":false},"body":"From #173 \r\n> The resources/host.rb file contains attributes for groups, templates and interfaces, but those are currently ignored in the providers/host.rb, since that file is only using the parameters[:groupNames], parameteres[:templates] and parameteres[:interfaces] attribute respectively for registering a host to the Zabbix server.\r\n\r\nFixing this issue while I tried to keep the backward compatibility to not brake the agent_registration recipe and other people's application cookbooks using this resource the old way. Could you please review it?","created_at":"2014-07-09T13:53:57Z","updated_at":"2014-07-10T10:03:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2a0f337f318b03daad1663827687a2c8bfa6491e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/laradji/zabbix/pulls/174/commits","review_comments_url":"https://api.github.com/repos/laradji/zabbix/pulls/174/comments","review_comment_url":"https://api.github.com/repos/laradji/zabbix/pulls/comments/{number}","comments_url":"https://api.github.com/repos/laradji/zabbix/issues/174/comments","statuses_url":"https://api.github.com/repos/laradji/zabbix/statuses/0c991528306afc12e51377b2e567f1803836b76d","head":{"label":"nightw:fix/host_resource_provider_sync","ref":"fix/host_resource_provider_sync","sha":"0c991528306afc12e51377b2e567f1803836b76d","user":{"login":"nightw","id":220303,"avatar_url":"https://avatars.githubusercontent.com/u/220303?","gravatar_id":"479e9f8aa90eca3db6fb11653614fcc4","url":"https://api.github.com/users/nightw","html_url":"https://github.com/nightw","followers_url":"https://api.github.com/users/nightw/followers","following_url":"https://api.github.com/users/nightw/following{/other_user}","gists_url":"https://api.github.com/users/nightw/gists{/gist_id}","starred_url":"https://api.github.com/users/nightw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nightw/subscriptions","organizations_url":"https://api.github.com/users/nightw/orgs","repos_url":"https://api.github.com/users/nightw/repos","events_url":"https://api.github.com/users/nightw/events{/privacy}","received_events_url":"https://api.github.com/users/nightw/received_events","type":"User","site_admin":false},"repo":{"id":21607378,"name":"zabbix","full_name":"nightw/zabbix","owner":{"login":"nightw","id":220303,"avatar_url":"https://avatars.githubusercontent.com/u/220303?","gravatar_id":"479e9f8aa90eca3db6fb11653614fcc4","url":"https://api.github.com/users/nightw","html_url":"https://github.com/nightw","followers_url":"https://api.github.com/users/nightw/followers","following_url":"https://api.github.com/users/nightw/following{/other_user}","gists_url":"https://api.github.com/users/nightw/gists{/gist_id}","starred_url":"https://api.github.com/users/nightw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nightw/subscriptions","organizations_url":"https://api.github.com/users/nightw/orgs","repos_url":"https://api.github.com/users/nightw/repos","events_url":"https://api.github.com/users/nightw/events{/privacy}","received_events_url":"https://api.github.com/users/nightw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nightw/zabbix","description":"Zabbix chef cookbook","fork":true,"url":"https://api.github.com/repos/nightw/zabbix","forks_url":"https://api.github.com/repos/nightw/zabbix/forks","keys_url":"https://api.github.com/repos/nightw/zabbix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nightw/zabbix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nightw/zabbix/teams","hooks_url":"https://api.github.com/repos/nightw/zabbix/hooks","issue_events_url":"https://api.github.com/repos/nightw/zabbix/issues/events{/number}","events_url":"https://api.github.com/repos/nightw/zabbix/events","assignees_url":"https://api.github.com/repos/nightw/zabbix/assignees{/user}","branches_url":"https://api.github.com/repos/nightw/zabbix/branches{/branch}","tags_url":"https://api.github.com/repos/nightw/zabbix/tags","blobs_url":"https://api.github.com/repos/nightw/zabbix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nightw/zabbix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nightw/zabbix/git/refs{/sha}","trees_url":"https://api.github.com/repos/nightw/zabbix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nightw/zabbix/statuses/{sha}","languages_url":"https://api.github.com/repos/nightw/zabbix/languages","stargazers_url":"https://api.github.com/repos/nightw/zabbix/stargazers","contributors_url":"https://api.github.com/repos/nightw/zabbix/contributors","subscribers_url":"https://api.github.com/repos/nightw/zabbix/subscribers","subscription_url":"https://api.github.com/repos/nightw/zabbix/subscription","commits_url":"https://api.github.com/repos/nightw/zabbix/commits{/sha}","git_commits_url":"https://api.github.com/repos/nightw/zabbix/git/commits{/sha}","comments_url":"https://api.github.com/repos/nightw/zabbix/comments{/number}","issue_comment_url":"https://api.github.com/repos/nightw/zabbix/issues/comments/{number}","contents_url":"https://api.github.com/repos/nightw/zabbix/contents/{+path}","compare_url":"https://api.github.com/repos/nightw/zabbix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nightw/zabbix/merges","archive_url":"https://api.github.com/repos/nightw/zabbix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nightw/zabbix/downloads","issues_url":"https://api.github.com/repos/nightw/zabbix/issues{/number}","pulls_url":"https://api.github.com/repos/nightw/zabbix/pulls{/number}","milestones_url":"https://api.github.com/repos/nightw/zabbix/milestones{/number}","notifications_url":"https://api.github.com/repos/nightw/zabbix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nightw/zabbix/labels{/name}","releases_url":"https://api.github.com/repos/nightw/zabbix/releases{/id}","created_at":"2014-07-08T09:43:37Z","updated_at":"2014-07-08T13:44:35Z","pushed_at":"2014-07-09T13:31:29Z","git_url":"git://github.com/nightw/zabbix.git","ssh_url":"git@github.com:nightw/zabbix.git","clone_url":"https://github.com/nightw/zabbix.git","svn_url":"https://github.com/nightw/zabbix","homepage":null,"size":1814,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"laradji:master","ref":"master","sha":"45ba889a2030d29a9d1d018826850b8122b50d46","user":{"login":"laradji","id":397239,"avatar_url":"https://avatars.githubusercontent.com/u/397239?","gravatar_id":"c2a939908d87396b3c917675699bffc1","url":"https://api.github.com/users/laradji","html_url":"https://github.com/laradji","followers_url":"https://api.github.com/users/laradji/followers","following_url":"https://api.github.com/users/laradji/following{/other_user}","gists_url":"https://api.github.com/users/laradji/gists{/gist_id}","starred_url":"https://api.github.com/users/laradji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laradji/subscriptions","organizations_url":"https://api.github.com/users/laradji/orgs","repos_url":"https://api.github.com/users/laradji/repos","events_url":"https://api.github.com/users/laradji/events{/privacy}","received_events_url":"https://api.github.com/users/laradji/received_events","type":"User","site_admin":false},"repo":{"id":4367065,"name":"zabbix","full_name":"laradji/zabbix","owner":{"login":"laradji","id":397239,"avatar_url":"https://avatars.githubusercontent.com/u/397239?","gravatar_id":"c2a939908d87396b3c917675699bffc1","url":"https://api.github.com/users/laradji","html_url":"https://github.com/laradji","followers_url":"https://api.github.com/users/laradji/followers","following_url":"https://api.github.com/users/laradji/following{/other_user}","gists_url":"https://api.github.com/users/laradji/gists{/gist_id}","starred_url":"https://api.github.com/users/laradji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laradji/subscriptions","organizations_url":"https://api.github.com/users/laradji/orgs","repos_url":"https://api.github.com/users/laradji/repos","events_url":"https://api.github.com/users/laradji/events{/privacy}","received_events_url":"https://api.github.com/users/laradji/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/laradji/zabbix","description":"Zabbix chef cookbook","fork":false,"url":"https://api.github.com/repos/laradji/zabbix","forks_url":"https://api.github.com/repos/laradji/zabbix/forks","keys_url":"https://api.github.com/repos/laradji/zabbix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laradji/zabbix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laradji/zabbix/teams","hooks_url":"https://api.github.com/repos/laradji/zabbix/hooks","issue_events_url":"https://api.github.com/repos/laradji/zabbix/issues/events{/number}","events_url":"https://api.github.com/repos/laradji/zabbix/events","assignees_url":"https://api.github.com/repos/laradji/zabbix/assignees{/user}","branches_url":"https://api.github.com/repos/laradji/zabbix/branches{/branch}","tags_url":"https://api.github.com/repos/laradji/zabbix/tags","blobs_url":"https://api.github.com/repos/laradji/zabbix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laradji/zabbix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laradji/zabbix/git/refs{/sha}","trees_url":"https://api.github.com/repos/laradji/zabbix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laradji/zabbix/statuses/{sha}","languages_url":"https://api.github.com/repos/laradji/zabbix/languages","stargazers_url":"https://api.github.com/repos/laradji/zabbix/stargazers","contributors_url":"https://api.github.com/repos/laradji/zabbix/contributors","subscribers_url":"https://api.github.com/repos/laradji/zabbix/subscribers","subscription_url":"https://api.github.com/repos/laradji/zabbix/subscription","commits_url":"https://api.github.com/repos/laradji/zabbix/commits{/sha}","git_commits_url":"https://api.github.com/repos/laradji/zabbix/git/commits{/sha}","comments_url":"https://api.github.com/repos/laradji/zabbix/comments{/number}","issue_comment_url":"https://api.github.com/repos/laradji/zabbix/issues/comments/{number}","contents_url":"https://api.github.com/repos/laradji/zabbix/contents/{+path}","compare_url":"https://api.github.com/repos/laradji/zabbix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laradji/zabbix/merges","archive_url":"https://api.github.com/repos/laradji/zabbix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laradji/zabbix/downloads","issues_url":"https://api.github.com/repos/laradji/zabbix/issues{/number}","pulls_url":"https://api.github.com/repos/laradji/zabbix/pulls{/number}","milestones_url":"https://api.github.com/repos/laradji/zabbix/milestones{/number}","notifications_url":"https://api.github.com/repos/laradji/zabbix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laradji/zabbix/labels{/name}","releases_url":"https://api.github.com/repos/laradji/zabbix/releases{/id}","created_at":"2012-05-18T08:07:09Z","updated_at":"2014-06-26T23:16:39Z","pushed_at":"2014-06-17T08:09:56Z","git_url":"git://github.com/laradji/zabbix.git","ssh_url":"git@github.com:laradji/zabbix.git","clone_url":"https://github.com/laradji/zabbix.git","svn_url":"https://github.com/laradji/zabbix","homepage":null,"size":1814,"stargazers_count":65,"watchers_count":65,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":80,"mirror_url":null,"open_issues_count":23,"forks":80,"open_issues":23,"watchers":65,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/laradji/zabbix/pulls/174"},"html":{"href":"https://github.com/laradji/zabbix/pull/174"},"issue":{"href":"https://api.github.com/repos/laradji/zabbix/issues/174"},"comments":{"href":"https://api.github.com/repos/laradji/zabbix/issues/174/comments"},"review_comments":{"href":"https://api.github.com/repos/laradji/zabbix/pulls/174/comments"},"review_comment":{"href":"https://api.github.com/repos/laradji/zabbix/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/laradji/zabbix/pulls/174/commits"},"statuses":{"href":"https://api.github.com/repos/laradji/zabbix/statuses/0c991528306afc12e51377b2e567f1803836b76d"}}}}