GitHub PullRequestReviewCommentEvent at 2014-11-18 21:44:11
Repository: RxAndroid
Actor: hamidp
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/ReactiveX/RxAndroid/pulls/comments/20540783","id":20540783,"diff_hunk":"@@ -39,18 +47,38 @@ public RetainedListFragment() {\n         }\n \n         @Override\n-        public void onCreate(Bundle savedInstanceState) {\n-            super.onCreate(savedInstanceState);\n+        public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {","path":"sample-app/src/main/java/rx/android/samples/ListFragmentActivity.java","position":38,"original_position":38,"commit_id":"4a4ccbd22ead78b2ccc9e6a3315c5c8d5c76c350","original_commit_id":"4a4ccbd22ead78b2ccc9e6a3315c5c8d5c76c350","user":{"login":"hamidp","id":308864,"avatar_url":"https://avatars.githubusercontent.com/u/308864?v=3","gravatar_id":"","url":"https://api.github.com/users/hamidp","html_url":"https://github.com/hamidp","followers_url":"https://api.github.com/users/hamidp/followers","following_url":"https://api.github.com/users/hamidp/following{/other_user}","gists_url":"https://api.github.com/users/hamidp/gists{/gist_id}","starred_url":"https://api.github.com/users/hamidp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hamidp/subscriptions","organizations_url":"https://api.github.com/users/hamidp/orgs","repos_url":"https://api.github.com/users/hamidp/repos","events_url":"https://api.github.com/users/hamidp/events{/privacy}","received_events_url":"https://api.github.com/users/hamidp/received_events","type":"User","site_admin":false},"body":"I agree completely on the theme around the sample or at least Building it\r\nout in a structured way rather than a sprawl.\r\nOn Tue, Nov 18, 2014 at 16:41 David Sobreira Marques <\r\nnotifications@github.com> wrote:\r\n\r\n> In sample-app/src/main/java/rx/android/samples/ListFragmentActivity.java:\r\n>\r\n> > @@ -39,18 +47,38 @@ public RetainedListFragment() {\r\n> >          }\r\n> >\r\n> >          @Override\r\n> > -        public void onCreate(Bundle savedInstanceState) {\r\n> > -            super.onCreate(savedInstanceState);\r\n> > +        public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {\r\n>\r\n> @mttkay <https://github.com/mttkay> should we define what kinds of things\r\n> will go into the sample so that we have a cohesive sample application? I\r\n> wonder if having some sort of \"theme\" around the sample app would be a good\r\n> idea?\r\n>\r\n> —\r\n> Reply to this email directly or view it on GitHub\r\n> <https://github.com/ReactiveX/RxAndroid/pull/57/files#r20540578>.\r\n>","created_at":"2014-11-18T21:44:11Z","updated_at":"2014-11-18T21:44:11Z","html_url":"https://github.com/ReactiveX/RxAndroid/pull/57#discussion_r20540783","pull_request_url":"https://api.github.com/repos/ReactiveX/RxAndroid/pulls/57","_links":{"self":{"href":"https://api.github.com/repos/ReactiveX/RxAndroid/pulls/comments/20540783"},"html":{"href":"https://github.com/ReactiveX/RxAndroid/pull/57#discussion_r20540783"},"pull_request":{"href":"https://api.github.com/repos/ReactiveX/RxAndroid/pulls/57"}}},"pull_request":{"url":"https://api.github.com/repos/ReactiveX/RxAndroid/pulls/57","id":24644894,"html_url":"https://github.com/ReactiveX/RxAndroid/pull/57","diff_url":"https://github.com/ReactiveX/RxAndroid/pull/57.diff","patch_url":"https://github.com/ReactiveX/RxAndroid/pull/57.patch","issue_url":"https://api.github.com/repos/ReactiveX/RxAndroid/issues/57","number":57,"state":"open","locked":false,"title":"Add ViewObservables.listViewScroll(AbsListView).","user":{"login":"hamidp","id":308864,"avatar_url":"https://avatars.githubusercontent.com/u/308864?v=3","gravatar_id":"","url":"https://api.github.com/users/hamidp","html_url":"https://github.com/hamidp","followers_url":"https://api.github.com/users/hamidp/followers","following_url":"https://api.github.com/users/hamidp/following{/other_user}","gists_url":"https://api.github.com/users/hamidp/gists{/gist_id}","starred_url":"https://api.github.com/users/hamidp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hamidp/subscriptions","organizations_url":"https://api.github.com/users/hamidp/orgs","repos_url":"https://api.github.com/users/hamidp/repos","events_url":"https://api.github.com/users/hamidp/events{/privacy}","received_events_url":"https://api.github.com/users/hamidp/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-11-18T21:18:41Z","updated_at":"2014-11-18T21:44:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff9eb8067322c207ae5dd672fa798928d8c0475d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ReactiveX/RxAndroid/pulls/57/commits","review_comments_url":"https://api.github.com/repos/ReactiveX/RxAndroid/pulls/57/comments","review_comment_url":"https://api.github.com/repos/ReactiveX/RxAndroid/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ReactiveX/RxAndroid/issues/57/comments","statuses_url":"https://api.github.com/repos/ReactiveX/RxAndroid/statuses/4a4ccbd22ead78b2ccc9e6a3315c5c8d5c76c350","head":{"label":"hamidp:list-scroll-observable","ref":"list-scroll-observable","sha":"4a4ccbd22ead78b2ccc9e6a3315c5c8d5c76c350","user":{"login":"hamidp","id":308864,"avatar_url":"https://avatars.githubusercontent.com/u/308864?v=3","gravatar_id":"","url":"https://api.github.com/users/hamidp","html_url":"https://github.com/hamidp","followers_url":"https://api.github.com/users/hamidp/followers","following_url":"https://api.github.com/users/hamidp/following{/other_user}","gists_url":"https://api.github.com/users/hamidp/gists{/gist_id}","starred_url":"https://api.github.com/users/hamidp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hamidp/subscriptions","organizations_url":"https://api.github.com/users/hamidp/orgs","repos_url":"https://api.github.com/users/hamidp/repos","events_url":"https://api.github.com/users/hamidp/events{/privacy}","received_events_url":"https://api.github.com/users/hamidp/received_events","type":"User","site_admin":false},"repo":{"id":26755863,"name":"RxAndroid","full_name":"hamidp/RxAndroid","owner":{"login":"hamidp","id":308864,"avatar_url":"https://avatars.githubusercontent.com/u/308864?v=3","gravatar_id":"","url":"https://api.github.com/users/hamidp","html_url":"https://github.com/hamidp","followers_url":"https://api.github.com/users/hamidp/followers","following_url":"https://api.github.com/users/hamidp/following{/other_user}","gists_url":"https://api.github.com/users/hamidp/gists{/gist_id}","starred_url":"https://api.github.com/users/hamidp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hamidp/subscriptions","organizations_url":"https://api.github.com/users/hamidp/orgs","repos_url":"https://api.github.com/users/hamidp/repos","events_url":"https://api.github.com/users/hamidp/events{/privacy}","received_events_url":"https://api.github.com/users/hamidp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hamidp/RxAndroid","description":"RxJava bindings for Android","fork":true,"url":"https://api.github.com/repos/hamidp/RxAndroid","forks_url":"https://api.github.com/repos/hamidp/RxAndroid/forks","keys_url":"https://api.github.com/repos/hamidp/RxAndroid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hamidp/RxAndroid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hamidp/RxAndroid/teams","hooks_url":"https://api.github.com/repos/hamidp/RxAndroid/hooks","issue_events_url":"https://api.github.com/repos/hamidp/RxAndroid/issues/events{/number}","events_url":"https://api.github.com/repos/hamidp/RxAndroid/events","assignees_url":"https://api.github.com/repos/hamidp/RxAndroid/assignees{/user}","branches_url":"https://api.github.com/repos/hamidp/RxAndroid/branches{/branch}","tags_url":"https://api.github.com/repos/hamidp/RxAndroid/tags","blobs_url":"https://api.github.com/repos/hamidp/RxAndroid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hamidp/RxAndroid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hamidp/RxAndroid/git/refs{/sha}","trees_url":"https://api.github.com/repos/hamidp/RxAndroid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hamidp/RxAndroid/statuses/{sha}","languages_url":"https://api.github.com/repos/hamidp/RxAndroid/languages","stargazers_url":"https://api.github.com/repos/hamidp/RxAndroid/stargazers","contributors_url":"https://api.github.com/repos/hamidp/RxAndroid/contributors","subscribers_url":"https://api.github.com/repos/hamidp/RxAndroid/subscribers","subscription_url":"https://api.github.com/repos/hamidp/RxAndroid/subscription","commits_url":"https://api.github.com/repos/hamidp/RxAndroid/commits{/sha}","git_commits_url":"https://api.github.com/repos/hamidp/RxAndroid/git/commits{/sha}","comments_url":"https://api.github.com/repos/hamidp/RxAndroid/comments{/number}","issue_comment_url":"https://api.github.com/repos/hamidp/RxAndroid/issues/comments/{number}","contents_url":"https://api.github.com/repos/hamidp/RxAndroid/contents/{+path}","compare_url":"https://api.github.com/repos/hamidp/RxAndroid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hamidp/RxAndroid/merges","archive_url":"https://api.github.com/repos/hamidp/RxAndroid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hamidp/RxAndroid/downloads","issues_url":"https://api.github.com/repos/hamidp/RxAndroid/issues{/number}","pulls_url":"https://api.github.com/repos/hamidp/RxAndroid/pulls{/number}","milestones_url":"https://api.github.com/repos/hamidp/RxAndroid/milestones{/number}","notifications_url":"https://api.github.com/repos/hamidp/RxAndroid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hamidp/RxAndroid/labels{/name}","releases_url":"https://api.github.com/repos/hamidp/RxAndroid/releases{/id}","created_at":"2014-11-17T12:36:30Z","updated_at":"2014-11-17T12:36:31Z","pushed_at":"2014-11-18T21:16:42Z","git_url":"git://github.com/hamidp/RxAndroid.git","ssh_url":"git@github.com:hamidp/RxAndroid.git","clone_url":"https://github.com/hamidp/RxAndroid.git","svn_url":"https://github.com/hamidp/RxAndroid","homepage":"","size":404,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"0.x"}},"base":{"label":"ReactiveX:0.x","ref":"0.x","sha":"aa1f2aa844576e01c0d9279be7bd93de94a1ff5e","user":{"login":"ReactiveX","id":6407041,"avatar_url":"https://avatars.githubusercontent.com/u/6407041?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactiveX","html_url":"https://github.com/ReactiveX","followers_url":"https://api.github.com/users/ReactiveX/followers","following_url":"https://api.github.com/users/ReactiveX/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveX/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveX/subscriptions","organizations_url":"https://api.github.com/users/ReactiveX/orgs","repos_url":"https://api.github.com/users/ReactiveX/repos","events_url":"https://api.github.com/users/ReactiveX/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveX/received_events","type":"Organization","site_admin":false},"repo":{"id":23095954,"name":"RxAndroid","full_name":"ReactiveX/RxAndroid","owner":{"login":"ReactiveX","id":6407041,"avatar_url":"https://avatars.githubusercontent.com/u/6407041?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactiveX","html_url":"https://github.com/ReactiveX","followers_url":"https://api.github.com/users/ReactiveX/followers","following_url":"https://api.github.com/users/ReactiveX/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveX/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveX/subscriptions","organizations_url":"https://api.github.com/users/ReactiveX/orgs","repos_url":"https://api.github.com/users/ReactiveX/repos","events_url":"https://api.github.com/users/ReactiveX/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveX/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ReactiveX/RxAndroid","description":"RxJava bindings for Android","fork":false,"url":"https://api.github.com/repos/ReactiveX/RxAndroid","forks_url":"https://api.github.com/repos/ReactiveX/RxAndroid/forks","keys_url":"https://api.github.com/repos/ReactiveX/RxAndroid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ReactiveX/RxAndroid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ReactiveX/RxAndroid/teams","hooks_url":"https://api.github.com/repos/ReactiveX/RxAndroid/hooks","issue_events_url":"https://api.github.com/repos/ReactiveX/RxAndroid/issues/events{/number}","events_url":"https://api.github.com/repos/ReactiveX/RxAndroid/events","assignees_url":"https://api.github.com/repos/ReactiveX/RxAndroid/assignees{/user}","branches_url":"https://api.github.com/repos/ReactiveX/RxAndroid/branches{/branch}","tags_url":"https://api.github.com/repos/ReactiveX/RxAndroid/tags","blobs_url":"https://api.github.com/repos/ReactiveX/RxAndroid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ReactiveX/RxAndroid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ReactiveX/RxAndroid/git/refs{/sha}","trees_url":"https://api.github.com/repos/ReactiveX/RxAndroid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ReactiveX/RxAndroid/statuses/{sha}","languages_url":"https://api.github.com/repos/ReactiveX/RxAndroid/languages","stargazers_url":"https://api.github.com/repos/ReactiveX/RxAndroid/stargazers","contributors_url":"https://api.github.com/repos/ReactiveX/RxAndroid/contributors","subscribers_url":"https://api.github.com/repos/ReactiveX/RxAndroid/subscribers","subscription_url":"https://api.github.com/repos/ReactiveX/RxAndroid/subscription","commits_url":"https://api.github.com/repos/ReactiveX/RxAndroid/commits{/sha}","git_commits_url":"https://api.github.com/repos/ReactiveX/RxAndroid/git/commits{/sha}","comments_url":"https://api.github.com/repos/ReactiveX/RxAndroid/comments{/number}","issue_comment_url":"https://api.github.com/repos/ReactiveX/RxAndroid/issues/comments/{number}","contents_url":"https://api.github.com/repos/ReactiveX/RxAndroid/contents/{+path}","compare_url":"https://api.github.com/repos/ReactiveX/RxAndroid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ReactiveX/RxAndroid/merges","archive_url":"https://api.github.com/repos/ReactiveX/RxAndroid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ReactiveX/RxAndroid/downloads","issues_url":"https://api.github.com/repos/ReactiveX/RxAndroid/issues{/number}","pulls_url":"https://api.github.com/repos/ReactiveX/RxAndroid/pulls{/number}","milestones_url":"https://api.github.com/repos/ReactiveX/RxAndroid/milestones{/number}","notifications_url":"https://api.github.com/repos/ReactiveX/RxAndroid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ReactiveX/RxAndroid/labels{/name}","releases_url":"https://api.github.com/repos/ReactiveX/RxAndroid/releases{/id}","created_at":"2014-08-19T03:46:38Z","updated_at":"2014-11-18T18:38:53Z","pushed_at":"2014-11-13T18:09:32Z","git_url":"git://github.com/ReactiveX/RxAndroid.git","ssh_url":"git@github.com:ReactiveX/RxAndroid.git","clone_url":"https://github.com/ReactiveX/RxAndroid.git","svn_url":"https://github.com/ReactiveX/RxAndroid","homepage":"","size":3356,"stargazers_count":276,"watchers_count":276,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":16,"forks":32,"open_issues":16,"watchers":276,"default_branch":"0.x"}},"_links":{"self":{"href":"https://api.github.com/repos/ReactiveX/RxAndroid/pulls/57"},"html":{"href":"https://github.com/ReactiveX/RxAndroid/pull/57"},"issue":{"href":"https://api.github.com/repos/ReactiveX/RxAndroid/issues/57"},"comments":{"href":"https://api.github.com/repos/ReactiveX/RxAndroid/issues/57/comments"},"review_comments":{"href":"https://api.github.com/repos/ReactiveX/RxAndroid/pulls/57/comments"},"review_comment":{"href":"https://api.github.com/repos/ReactiveX/RxAndroid/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ReactiveX/RxAndroid/pulls/57/commits"},"statuses":{"href":"https://api.github.com/repos/ReactiveX/RxAndroid/statuses/4a4ccbd22ead78b2ccc9e6a3315c5c8d5c76c350"}}}}