GitHub PullRequestReviewCommentEvent at 2014-07-31 17:16:54
Repository: droidplanner
Actor: arthurbenemann
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/DroidPlanner/droidplanner/pulls/comments/15655727","id":15655727,"diff_hunk":"@@ -34,6 +35,7 @@\n \n \t@SuppressLint(\"UseSparseArrays\")\n \tprivate HashMap<Integer, Parameter> parameters = new HashMap<Integer, Parameter>();\n+\tprivate boolean downloadInProgress = false;","path":"Core/src/org/droidplanner/core/drone/profiles/Parameters.java","position":25,"original_position":25,"commit_id":"8b904cccf685556f148fe3aa52497fa72b0db665","original_commit_id":"8b904cccf685556f148fe3aa52497fa72b0db665","user":{"login":"arthurbenemann","id":3289118,"avatar_url":"https://avatars.githubusercontent.com/u/3289118?v=1","gravatar_id":"75125f53ba4bca599fb95e6f35e91098","url":"https://api.github.com/users/arthurbenemann","html_url":"https://github.com/arthurbenemann","followers_url":"https://api.github.com/users/arthurbenemann/followers","following_url":"https://api.github.com/users/arthurbenemann/following{/other_user}","gists_url":"https://api.github.com/users/arthurbenemann/gists{/gist_id}","starred_url":"https://api.github.com/users/arthurbenemann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arthurbenemann/subscriptions","organizations_url":"https://api.github.com/users/arthurbenemann/orgs","repos_url":"https://api.github.com/users/arthurbenemann/repos","events_url":"https://api.github.com/users/arthurbenemann/events{/privacy}","received_events_url":"https://api.github.com/users/arthurbenemann/received_events","type":"User","site_admin":false},"body":"We are already making a state machine here, maybe we should make it explicitly by creating an enum with the states?","created_at":"2014-07-31T17:16:54Z","updated_at":"2014-07-31T17:16:54Z","html_url":"https://github.com/DroidPlanner/droidplanner/pull/955#discussion_r15655727","pull_request_url":"https://api.github.com/repos/DroidPlanner/droidplanner/pulls/955","_links":{"self":{"href":"https://api.github.com/repos/DroidPlanner/droidplanner/pulls/comments/15655727"},"html":{"href":"https://github.com/DroidPlanner/droidplanner/pull/955#discussion_r15655727"},"pull_request":{"href":"https://api.github.com/repos/DroidPlanner/droidplanner/pulls/955"}}},"pull_request":{"url":"https://api.github.com/repos/DroidPlanner/droidplanner/pulls/955","id":19127387,"html_url":"https://github.com/DroidPlanner/droidplanner/pull/955","diff_url":"https://github.com/DroidPlanner/droidplanner/pull/955.diff","patch_url":"https://github.com/DroidPlanner/droidplanner/pull/955.patch","issue_url":"https://api.github.com/repos/DroidPlanner/droidplanner/issues/955","number":955,"state":"open","title":"773: Auto download parameters on CONNECTED","user":{"login":"squilter","id":2956460,"avatar_url":"https://avatars.githubusercontent.com/u/2956460?v=1","gravatar_id":"1c0a353c28de41b89eca2cacbda1eda5","url":"https://api.github.com/users/squilter","html_url":"https://github.com/squilter","followers_url":"https://api.github.com/users/squilter/followers","following_url":"https://api.github.com/users/squilter/following{/other_user}","gists_url":"https://api.github.com/users/squilter/gists{/gist_id}","starred_url":"https://api.github.com/users/squilter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squilter/subscriptions","organizations_url":"https://api.github.com/users/squilter/orgs","repos_url":"https://api.github.com/users/squilter/repos","events_url":"https://api.github.com/users/squilter/events{/privacy}","received_events_url":"https://api.github.com/users/squilter/received_events","type":"User","site_admin":false},"body":"Work in Progress.  TODO:\r\n\r\n- [x] Check !is_flying before sending parameter-get request (Parameters.java:154)\r\n- [x] Start progress bar in parameters automatically\r\n- [ ] Window leaks when leaving parameters page.\r\n- [x] Make sure only one parameters download can happen at one time\r\n- [ ] fix parameters download auto-restarting","created_at":"2014-07-31T00:56:38Z","updated_at":"2014-07-31T17:16:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"37ce37ad62c3cc95edf3d1bf147a11f1b1877189","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/DroidPlanner/droidplanner/pulls/955/commits","review_comments_url":"https://api.github.com/repos/DroidPlanner/droidplanner/pulls/955/comments","review_comment_url":"https://api.github.com/repos/DroidPlanner/droidplanner/pulls/comments/{number}","comments_url":"https://api.github.com/repos/DroidPlanner/droidplanner/issues/955/comments","statuses_url":"https://api.github.com/repos/DroidPlanner/droidplanner/statuses/8b904cccf685556f148fe3aa52497fa72b0db665","head":{"label":"squilter:issue_773","ref":"issue_773","sha":"8b904cccf685556f148fe3aa52497fa72b0db665","user":{"login":"squilter","id":2956460,"avatar_url":"https://avatars.githubusercontent.com/u/2956460?v=1","gravatar_id":"1c0a353c28de41b89eca2cacbda1eda5","url":"https://api.github.com/users/squilter","html_url":"https://github.com/squilter","followers_url":"https://api.github.com/users/squilter/followers","following_url":"https://api.github.com/users/squilter/following{/other_user}","gists_url":"https://api.github.com/users/squilter/gists{/gist_id}","starred_url":"https://api.github.com/users/squilter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squilter/subscriptions","organizations_url":"https://api.github.com/users/squilter/orgs","repos_url":"https://api.github.com/users/squilter/repos","events_url":"https://api.github.com/users/squilter/events{/privacy}","received_events_url":"https://api.github.com/users/squilter/received_events","type":"User","site_admin":false},"repo":{"id":21253994,"name":"droidplanner","full_name":"squilter/droidplanner","owner":{"login":"squilter","id":2956460,"avatar_url":"https://avatars.githubusercontent.com/u/2956460?v=1","gravatar_id":"1c0a353c28de41b89eca2cacbda1eda5","url":"https://api.github.com/users/squilter","html_url":"https://github.com/squilter","followers_url":"https://api.github.com/users/squilter/followers","following_url":"https://api.github.com/users/squilter/following{/other_user}","gists_url":"https://api.github.com/users/squilter/gists{/gist_id}","starred_url":"https://api.github.com/users/squilter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squilter/subscriptions","organizations_url":"https://api.github.com/users/squilter/orgs","repos_url":"https://api.github.com/users/squilter/repos","events_url":"https://api.github.com/users/squilter/events{/privacy}","received_events_url":"https://api.github.com/users/squilter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/squilter/droidplanner","description":"Ground Control Station for Android Devices","fork":true,"url":"https://api.github.com/repos/squilter/droidplanner","forks_url":"https://api.github.com/repos/squilter/droidplanner/forks","keys_url":"https://api.github.com/repos/squilter/droidplanner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/squilter/droidplanner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/squilter/droidplanner/teams","hooks_url":"https://api.github.com/repos/squilter/droidplanner/hooks","issue_events_url":"https://api.github.com/repos/squilter/droidplanner/issues/events{/number}","events_url":"https://api.github.com/repos/squilter/droidplanner/events","assignees_url":"https://api.github.com/repos/squilter/droidplanner/assignees{/user}","branches_url":"https://api.github.com/repos/squilter/droidplanner/branches{/branch}","tags_url":"https://api.github.com/repos/squilter/droidplanner/tags","blobs_url":"https://api.github.com/repos/squilter/droidplanner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/squilter/droidplanner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/squilter/droidplanner/git/refs{/sha}","trees_url":"https://api.github.com/repos/squilter/droidplanner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/squilter/droidplanner/statuses/{sha}","languages_url":"https://api.github.com/repos/squilter/droidplanner/languages","stargazers_url":"https://api.github.com/repos/squilter/droidplanner/stargazers","contributors_url":"https://api.github.com/repos/squilter/droidplanner/contributors","subscribers_url":"https://api.github.com/repos/squilter/droidplanner/subscribers","subscription_url":"https://api.github.com/repos/squilter/droidplanner/subscription","commits_url":"https://api.github.com/repos/squilter/droidplanner/commits{/sha}","git_commits_url":"https://api.github.com/repos/squilter/droidplanner/git/commits{/sha}","comments_url":"https://api.github.com/repos/squilter/droidplanner/comments{/number}","issue_comment_url":"https://api.github.com/repos/squilter/droidplanner/issues/comments/{number}","contents_url":"https://api.github.com/repos/squilter/droidplanner/contents/{+path}","compare_url":"https://api.github.com/repos/squilter/droidplanner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/squilter/droidplanner/merges","archive_url":"https://api.github.com/repos/squilter/droidplanner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/squilter/droidplanner/downloads","issues_url":"https://api.github.com/repos/squilter/droidplanner/issues{/number}","pulls_url":"https://api.github.com/repos/squilter/droidplanner/pulls{/number}","milestones_url":"https://api.github.com/repos/squilter/droidplanner/milestones{/number}","notifications_url":"https://api.github.com/repos/squilter/droidplanner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/squilter/droidplanner/labels{/name}","releases_url":"https://api.github.com/repos/squilter/droidplanner/releases{/id}","created_at":"2014-06-26T20:28:20Z","updated_at":"2014-06-25T17:37:10Z","pushed_at":"2014-07-31T15:32:14Z","git_url":"git://github.com/squilter/droidplanner.git","ssh_url":"git@github.com:squilter/droidplanner.git","clone_url":"https://github.com/squilter/droidplanner.git","svn_url":"https://github.com/squilter/droidplanner","homepage":"https://play.google.com/store/apps/details?id=com.droidplanner","size":25600,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DroidPlanner:master","ref":"master","sha":"296d7e6fbd0182492ef9197538c1f93bc29e951d","user":{"login":"DroidPlanner","id":6230606,"avatar_url":"https://avatars.githubusercontent.com/u/6230606?v=1","gravatar_id":null,"url":"https://api.github.com/users/DroidPlanner","html_url":"https://github.com/DroidPlanner","followers_url":"https://api.github.com/users/DroidPlanner/followers","following_url":"https://api.github.com/users/DroidPlanner/following{/other_user}","gists_url":"https://api.github.com/users/DroidPlanner/gists{/gist_id}","starred_url":"https://api.github.com/users/DroidPlanner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DroidPlanner/subscriptions","organizations_url":"https://api.github.com/users/DroidPlanner/orgs","repos_url":"https://api.github.com/users/DroidPlanner/repos","events_url":"https://api.github.com/users/DroidPlanner/events{/privacy}","received_events_url":"https://api.github.com/users/DroidPlanner/received_events","type":"Organization","site_admin":false},"repo":{"id":8290123,"name":"droidplanner","full_name":"DroidPlanner/droidplanner","owner":{"login":"DroidPlanner","id":6230606,"avatar_url":"https://avatars.githubusercontent.com/u/6230606?v=1","gravatar_id":null,"url":"https://api.github.com/users/DroidPlanner","html_url":"https://github.com/DroidPlanner","followers_url":"https://api.github.com/users/DroidPlanner/followers","following_url":"https://api.github.com/users/DroidPlanner/following{/other_user}","gists_url":"https://api.github.com/users/DroidPlanner/gists{/gist_id}","starred_url":"https://api.github.com/users/DroidPlanner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DroidPlanner/subscriptions","organizations_url":"https://api.github.com/users/DroidPlanner/orgs","repos_url":"https://api.github.com/users/DroidPlanner/repos","events_url":"https://api.github.com/users/DroidPlanner/events{/privacy}","received_events_url":"https://api.github.com/users/DroidPlanner/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DroidPlanner/droidplanner","description":"Ground Control Station for Android Devices","fork":false,"url":"https://api.github.com/repos/DroidPlanner/droidplanner","forks_url":"https://api.github.com/repos/DroidPlanner/droidplanner/forks","keys_url":"https://api.github.com/repos/DroidPlanner/droidplanner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DroidPlanner/droidplanner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DroidPlanner/droidplanner/teams","hooks_url":"https://api.github.com/repos/DroidPlanner/droidplanner/hooks","issue_events_url":"https://api.github.com/repos/DroidPlanner/droidplanner/issues/events{/number}","events_url":"https://api.github.com/repos/DroidPlanner/droidplanner/events","assignees_url":"https://api.github.com/repos/DroidPlanner/droidplanner/assignees{/user}","branches_url":"https://api.github.com/repos/DroidPlanner/droidplanner/branches{/branch}","tags_url":"https://api.github.com/repos/DroidPlanner/droidplanner/tags","blobs_url":"https://api.github.com/repos/DroidPlanner/droidplanner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DroidPlanner/droidplanner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DroidPlanner/droidplanner/git/refs{/sha}","trees_url":"https://api.github.com/repos/DroidPlanner/droidplanner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DroidPlanner/droidplanner/statuses/{sha}","languages_url":"https://api.github.com/repos/DroidPlanner/droidplanner/languages","stargazers_url":"https://api.github.com/repos/DroidPlanner/droidplanner/stargazers","contributors_url":"https://api.github.com/repos/DroidPlanner/droidplanner/contributors","subscribers_url":"https://api.github.com/repos/DroidPlanner/droidplanner/subscribers","subscription_url":"https://api.github.com/repos/DroidPlanner/droidplanner/subscription","commits_url":"https://api.github.com/repos/DroidPlanner/droidplanner/commits{/sha}","git_commits_url":"https://api.github.com/repos/DroidPlanner/droidplanner/git/commits{/sha}","comments_url":"https://api.github.com/repos/DroidPlanner/droidplanner/comments{/number}","issue_comment_url":"https://api.github.com/repos/DroidPlanner/droidplanner/issues/comments/{number}","contents_url":"https://api.github.com/repos/DroidPlanner/droidplanner/contents/{+path}","compare_url":"https://api.github.com/repos/DroidPlanner/droidplanner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DroidPlanner/droidplanner/merges","archive_url":"https://api.github.com/repos/DroidPlanner/droidplanner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DroidPlanner/droidplanner/downloads","issues_url":"https://api.github.com/repos/DroidPlanner/droidplanner/issues{/number}","pulls_url":"https://api.github.com/repos/DroidPlanner/droidplanner/pulls{/number}","milestones_url":"https://api.github.com/repos/DroidPlanner/droidplanner/milestones{/number}","notifications_url":"https://api.github.com/repos/DroidPlanner/droidplanner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DroidPlanner/droidplanner/labels{/name}","releases_url":"https://api.github.com/repos/DroidPlanner/droidplanner/releases{/id}","created_at":"2013-02-19T12:51:08Z","updated_at":"2014-07-30T22:04:16Z","pushed_at":"2014-07-31T03:43:57Z","git_url":"git://github.com/DroidPlanner/droidplanner.git","ssh_url":"git@github.com:DroidPlanner/droidplanner.git","clone_url":"https://github.com/DroidPlanner/droidplanner.git","svn_url":"https://github.com/DroidPlanner/droidplanner","homepage":"https://play.google.com/store/apps/details?id=com.droidplanner","size":50262,"stargazers_count":111,"watchers_count":111,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":113,"mirror_url":null,"open_issues_count":60,"forks":113,"open_issues":60,"watchers":111,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DroidPlanner/droidplanner/pulls/955"},"html":{"href":"https://github.com/DroidPlanner/droidplanner/pull/955"},"issue":{"href":"https://api.github.com/repos/DroidPlanner/droidplanner/issues/955"},"comments":{"href":"https://api.github.com/repos/DroidPlanner/droidplanner/issues/955/comments"},"review_comments":{"href":"https://api.github.com/repos/DroidPlanner/droidplanner/pulls/955/comments"},"review_comment":{"href":"https://api.github.com/repos/DroidPlanner/droidplanner/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/DroidPlanner/droidplanner/pulls/955/commits"},"statuses":{"href":"https://api.github.com/repos/DroidPlanner/droidplanner/statuses/8b904cccf685556f148fe3aa52497fa72b0db665"}}}}