GitHub PullRequestReviewCommentEvent at 2014-09-14 16:48:09
Repository: pioneer
Actor: rob-h-w
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/pioneerspacesim/pioneer/pulls/comments/17520884","id":17520884,"diff_hunk":"@@ -106,6 +107,14 @@ function ChatForm:BuildWidget ()\n \t\t\t\t)\n \t\t\t)\n \t\t)\n+\n+\tparent.onVisibilityChanged:Connect(function (visible)\n+\t\tif (not visible) then\n+\t\t\tself:OnClosed()\n+\t\tend","path":"data/ui/StationView/ChatForm.lua","position":33,"original_position":33,"commit_id":"a2dfcd51d70fe3602f6f4ab25fd9b52dda08cdb2","original_commit_id":"a2dfcd51d70fe3602f6f4ab25fd9b52dda08cdb2","user":{"login":"rob-h-w","id":1832910,"avatar_url":"https://avatars.githubusercontent.com/u/1832910?v=2","gravatar_id":"cf0998406ff61676b400c89bbb6a7b32","url":"https://api.github.com/users/rob-h-w","html_url":"https://github.com/rob-h-w","followers_url":"https://api.github.com/users/rob-h-w/followers","following_url":"https://api.github.com/users/rob-h-w/following{/other_user}","gists_url":"https://api.github.com/users/rob-h-w/gists{/gist_id}","starred_url":"https://api.github.com/users/rob-h-w/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rob-h-w/subscriptions","organizations_url":"https://api.github.com/users/rob-h-w/orgs","repos_url":"https://api.github.com/users/rob-h-w/repos","events_url":"https://api.github.com/users/rob-h-w/events{/privacy}","received_events_url":"https://api.github.com/users/rob-h-w/received_events","type":"User","site_admin":false},"body":"I *think* this is the case. If you open another chat window (by clicking a button on the existing chat window), the underlying chat window should be closed. The UI flows that I've tried (package and passenger missions) assume that any attempt to go back will actually open another chat, and so will actually be \"forward\".","created_at":"2014-09-14T16:48:09Z","updated_at":"2014-09-14T16:48:09Z","html_url":"https://github.com/pioneerspacesim/pioneer/pull/3169#discussion_r17520884","pull_request_url":"https://api.github.com/repos/pioneerspacesim/pioneer/pulls/3169","_links":{"self":{"href":"https://api.github.com/repos/pioneerspacesim/pioneer/pulls/comments/17520884"},"html":{"href":"https://github.com/pioneerspacesim/pioneer/pull/3169#discussion_r17520884"},"pull_request":{"href":"https://api.github.com/repos/pioneerspacesim/pioneer/pulls/3169"}}},"pull_request":{"url":"https://api.github.com/repos/pioneerspacesim/pioneer/pulls/3169","id":20910570,"html_url":"https://github.com/pioneerspacesim/pioneer/pull/3169","diff_url":"https://github.com/pioneerspacesim/pioneer/pull/3169.diff","patch_url":"https://github.com/pioneerspacesim/pioneer/pull/3169.patch","issue_url":"https://api.github.com/repos/pioneerspacesim/pioneer/issues/3169","number":3169,"state":"open","locked":false,"title":"Expose game paused to Lua; disable bulletin board when paused","user":{"login":"rob-h-w","id":1832910,"avatar_url":"https://avatars.githubusercontent.com/u/1832910?v=2","gravatar_id":"cf0998406ff61676b400c89bbb6a7b32","url":"https://api.github.com/users/rob-h-w","html_url":"https://github.com/rob-h-w","followers_url":"https://api.github.com/users/rob-h-w/followers","following_url":"https://api.github.com/users/rob-h-w/following{/other_user}","gists_url":"https://api.github.com/users/rob-h-w/gists{/gist_id}","starred_url":"https://api.github.com/users/rob-h-w/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rob-h-w/subscriptions","organizations_url":"https://api.github.com/users/rob-h-w/orgs","repos_url":"https://api.github.com/users/rob-h-w/repos","events_url":"https://api.github.com/users/rob-h-w/events{/privacy}","received_events_url":"https://api.github.com/users/rob-h-w/received_events","type":"User","site_admin":false},"body":"Closes #2732.\r\n\r\nNeeded to add a signal to notify when widgets are visible/invisible. This is used to ensure we lock/unlock adverts when they're opened in chat dialogs.\r\n\r\nGame pause/resume events are sent by the Game object on construction (to provide the initial state) and on relevant changes to time accel.","created_at":"2014-09-08T19:08:48Z","updated_at":"2014-09-14T16:48:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0861f660491c23d2eb11b7b168cb31178aeda7af","assignee":{"login":"lwho","id":1851410,"avatar_url":"https://avatars.githubusercontent.com/u/1851410?v=2","gravatar_id":"74d1c5eaa88c3c3812210d92a1e64b22","url":"https://api.github.com/users/lwho","html_url":"https://github.com/lwho","followers_url":"https://api.github.com/users/lwho/followers","following_url":"https://api.github.com/users/lwho/following{/other_user}","gists_url":"https://api.github.com/users/lwho/gists{/gist_id}","starred_url":"https://api.github.com/users/lwho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lwho/subscriptions","organizations_url":"https://api.github.com/users/lwho/orgs","repos_url":"https://api.github.com/users/lwho/repos","events_url":"https://api.github.com/users/lwho/events{/privacy}","received_events_url":"https://api.github.com/users/lwho/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/pioneerspacesim/pioneer/pulls/3169/commits","review_comments_url":"https://api.github.com/repos/pioneerspacesim/pioneer/pulls/3169/comments","review_comment_url":"https://api.github.com/repos/pioneerspacesim/pioneer/pulls/comments/{number}","comments_url":"https://api.github.com/repos/pioneerspacesim/pioneer/issues/3169/comments","statuses_url":"https://api.github.com/repos/pioneerspacesim/pioneer/statuses/a2dfcd51d70fe3602f6f4ab25fd9b52dda08cdb2","head":{"label":"rob-h-w:master","ref":"master","sha":"a2dfcd51d70fe3602f6f4ab25fd9b52dda08cdb2","user":{"login":"rob-h-w","id":1832910,"avatar_url":"https://avatars.githubusercontent.com/u/1832910?v=2","gravatar_id":"cf0998406ff61676b400c89bbb6a7b32","url":"https://api.github.com/users/rob-h-w","html_url":"https://github.com/rob-h-w","followers_url":"https://api.github.com/users/rob-h-w/followers","following_url":"https://api.github.com/users/rob-h-w/following{/other_user}","gists_url":"https://api.github.com/users/rob-h-w/gists{/gist_id}","starred_url":"https://api.github.com/users/rob-h-w/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rob-h-w/subscriptions","organizations_url":"https://api.github.com/users/rob-h-w/orgs","repos_url":"https://api.github.com/users/rob-h-w/repos","events_url":"https://api.github.com/users/rob-h-w/events{/privacy}","received_events_url":"https://api.github.com/users/rob-h-w/received_events","type":"User","site_admin":false},"repo":{"id":23727697,"name":"pioneer","full_name":"rob-h-w/pioneer","owner":{"login":"rob-h-w","id":1832910,"avatar_url":"https://avatars.githubusercontent.com/u/1832910?v=2","gravatar_id":"cf0998406ff61676b400c89bbb6a7b32","url":"https://api.github.com/users/rob-h-w","html_url":"https://github.com/rob-h-w","followers_url":"https://api.github.com/users/rob-h-w/followers","following_url":"https://api.github.com/users/rob-h-w/following{/other_user}","gists_url":"https://api.github.com/users/rob-h-w/gists{/gist_id}","starred_url":"https://api.github.com/users/rob-h-w/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rob-h-w/subscriptions","organizations_url":"https://api.github.com/users/rob-h-w/orgs","repos_url":"https://api.github.com/users/rob-h-w/repos","events_url":"https://api.github.com/users/rob-h-w/events{/privacy}","received_events_url":"https://api.github.com/users/rob-h-w/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rob-h-w/pioneer","description":"A game of lonely space adventure","fork":true,"url":"https://api.github.com/repos/rob-h-w/pioneer","forks_url":"https://api.github.com/repos/rob-h-w/pioneer/forks","keys_url":"https://api.github.com/repos/rob-h-w/pioneer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rob-h-w/pioneer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rob-h-w/pioneer/teams","hooks_url":"https://api.github.com/repos/rob-h-w/pioneer/hooks","issue_events_url":"https://api.github.com/repos/rob-h-w/pioneer/issues/events{/number}","events_url":"https://api.github.com/repos/rob-h-w/pioneer/events","assignees_url":"https://api.github.com/repos/rob-h-w/pioneer/assignees{/user}","branches_url":"https://api.github.com/repos/rob-h-w/pioneer/branches{/branch}","tags_url":"https://api.github.com/repos/rob-h-w/pioneer/tags","blobs_url":"https://api.github.com/repos/rob-h-w/pioneer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rob-h-w/pioneer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rob-h-w/pioneer/git/refs{/sha}","trees_url":"https://api.github.com/repos/rob-h-w/pioneer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rob-h-w/pioneer/statuses/{sha}","languages_url":"https://api.github.com/repos/rob-h-w/pioneer/languages","stargazers_url":"https://api.github.com/repos/rob-h-w/pioneer/stargazers","contributors_url":"https://api.github.com/repos/rob-h-w/pioneer/contributors","subscribers_url":"https://api.github.com/repos/rob-h-w/pioneer/subscribers","subscription_url":"https://api.github.com/repos/rob-h-w/pioneer/subscription","commits_url":"https://api.github.com/repos/rob-h-w/pioneer/commits{/sha}","git_commits_url":"https://api.github.com/repos/rob-h-w/pioneer/git/commits{/sha}","comments_url":"https://api.github.com/repos/rob-h-w/pioneer/comments{/number}","issue_comment_url":"https://api.github.com/repos/rob-h-w/pioneer/issues/comments/{number}","contents_url":"https://api.github.com/repos/rob-h-w/pioneer/contents/{+path}","compare_url":"https://api.github.com/repos/rob-h-w/pioneer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rob-h-w/pioneer/merges","archive_url":"https://api.github.com/repos/rob-h-w/pioneer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rob-h-w/pioneer/downloads","issues_url":"https://api.github.com/repos/rob-h-w/pioneer/issues{/number}","pulls_url":"https://api.github.com/repos/rob-h-w/pioneer/pulls{/number}","milestones_url":"https://api.github.com/repos/rob-h-w/pioneer/milestones{/number}","notifications_url":"https://api.github.com/repos/rob-h-w/pioneer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rob-h-w/pioneer/labels{/name}","releases_url":"https://api.github.com/repos/rob-h-w/pioneer/releases{/id}","created_at":"2014-09-06T05:30:01Z","updated_at":"2014-09-08T19:04:38Z","pushed_at":"2014-09-13T11:58:33Z","git_url":"git://github.com/rob-h-w/pioneer.git","ssh_url":"git@github.com:rob-h-w/pioneer.git","clone_url":"https://github.com/rob-h-w/pioneer.git","svn_url":"https://github.com/rob-h-w/pioneer","homepage":"http://pioneerspacesim.net/","size":737892,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pioneerspacesim:master","ref":"master","sha":"76733f2ba2f0d8197c970735ed410786c2cf109e","user":{"login":"pioneerspacesim","id":719820,"avatar_url":"https://avatars.githubusercontent.com/u/719820?v=2","gravatar_id":"0e33109a8fba33cbf66e04a5f63428c3","url":"https://api.github.com/users/pioneerspacesim","html_url":"https://github.com/pioneerspacesim","followers_url":"https://api.github.com/users/pioneerspacesim/followers","following_url":"https://api.github.com/users/pioneerspacesim/following{/other_user}","gists_url":"https://api.github.com/users/pioneerspacesim/gists{/gist_id}","starred_url":"https://api.github.com/users/pioneerspacesim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pioneerspacesim/subscriptions","organizations_url":"https://api.github.com/users/pioneerspacesim/orgs","repos_url":"https://api.github.com/users/pioneerspacesim/repos","events_url":"https://api.github.com/users/pioneerspacesim/events{/privacy}","received_events_url":"https://api.github.com/users/pioneerspacesim/received_events","type":"Organization","site_admin":false},"repo":{"id":1593053,"name":"pioneer","full_name":"pioneerspacesim/pioneer","owner":{"login":"pioneerspacesim","id":719820,"avatar_url":"https://avatars.githubusercontent.com/u/719820?v=2","gravatar_id":"0e33109a8fba33cbf66e04a5f63428c3","url":"https://api.github.com/users/pioneerspacesim","html_url":"https://github.com/pioneerspacesim","followers_url":"https://api.github.com/users/pioneerspacesim/followers","following_url":"https://api.github.com/users/pioneerspacesim/following{/other_user}","gists_url":"https://api.github.com/users/pioneerspacesim/gists{/gist_id}","starred_url":"https://api.github.com/users/pioneerspacesim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pioneerspacesim/subscriptions","organizations_url":"https://api.github.com/users/pioneerspacesim/orgs","repos_url":"https://api.github.com/users/pioneerspacesim/repos","events_url":"https://api.github.com/users/pioneerspacesim/events{/privacy}","received_events_url":"https://api.github.com/users/pioneerspacesim/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pioneerspacesim/pioneer","description":"A game of lonely space adventure","fork":false,"url":"https://api.github.com/repos/pioneerspacesim/pioneer","forks_url":"https://api.github.com/repos/pioneerspacesim/pioneer/forks","keys_url":"https://api.github.com/repos/pioneerspacesim/pioneer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pioneerspacesim/pioneer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pioneerspacesim/pioneer/teams","hooks_url":"https://api.github.com/repos/pioneerspacesim/pioneer/hooks","issue_events_url":"https://api.github.com/repos/pioneerspacesim/pioneer/issues/events{/number}","events_url":"https://api.github.com/repos/pioneerspacesim/pioneer/events","assignees_url":"https://api.github.com/repos/pioneerspacesim/pioneer/assignees{/user}","branches_url":"https://api.github.com/repos/pioneerspacesim/pioneer/branches{/branch}","tags_url":"https://api.github.com/repos/pioneerspacesim/pioneer/tags","blobs_url":"https://api.github.com/repos/pioneerspacesim/pioneer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pioneerspacesim/pioneer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pioneerspacesim/pioneer/git/refs{/sha}","trees_url":"https://api.github.com/repos/pioneerspacesim/pioneer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pioneerspacesim/pioneer/statuses/{sha}","languages_url":"https://api.github.com/repos/pioneerspacesim/pioneer/languages","stargazers_url":"https://api.github.com/repos/pioneerspacesim/pioneer/stargazers","contributors_url":"https://api.github.com/repos/pioneerspacesim/pioneer/contributors","subscribers_url":"https://api.github.com/repos/pioneerspacesim/pioneer/subscribers","subscription_url":"https://api.github.com/repos/pioneerspacesim/pioneer/subscription","commits_url":"https://api.github.com/repos/pioneerspacesim/pioneer/commits{/sha}","git_commits_url":"https://api.github.com/repos/pioneerspacesim/pioneer/git/commits{/sha}","comments_url":"https://api.github.com/repos/pioneerspacesim/pioneer/comments{/number}","issue_comment_url":"https://api.github.com/repos/pioneerspacesim/pioneer/issues/comments/{number}","contents_url":"https://api.github.com/repos/pioneerspacesim/pioneer/contents/{+path}","compare_url":"https://api.github.com/repos/pioneerspacesim/pioneer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pioneerspacesim/pioneer/merges","archive_url":"https://api.github.com/repos/pioneerspacesim/pioneer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pioneerspacesim/pioneer/downloads","issues_url":"https://api.github.com/repos/pioneerspacesim/pioneer/issues{/number}","pulls_url":"https://api.github.com/repos/pioneerspacesim/pioneer/pulls{/number}","milestones_url":"https://api.github.com/repos/pioneerspacesim/pioneer/milestones{/number}","notifications_url":"https://api.github.com/repos/pioneerspacesim/pioneer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pioneerspacesim/pioneer/labels{/name}","releases_url":"https://api.github.com/repos/pioneerspacesim/pioneer/releases{/id}","created_at":"2011-04-09T22:17:05Z","updated_at":"2014-09-13T19:42:33Z","pushed_at":"2014-09-14T06:12:16Z","git_url":"git://github.com/pioneerspacesim/pioneer.git","ssh_url":"git@github.com:pioneerspacesim/pioneer.git","clone_url":"https://github.com/pioneerspacesim/pioneer.git","svn_url":"https://github.com/pioneerspacesim/pioneer","homepage":"http://pioneerspacesim.net/","size":1447307,"stargazers_count":398,"watchers_count":398,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":171,"mirror_url":null,"open_issues_count":306,"forks":171,"open_issues":306,"watchers":398,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pioneerspacesim/pioneer/pulls/3169"},"html":{"href":"https://github.com/pioneerspacesim/pioneer/pull/3169"},"issue":{"href":"https://api.github.com/repos/pioneerspacesim/pioneer/issues/3169"},"comments":{"href":"https://api.github.com/repos/pioneerspacesim/pioneer/issues/3169/comments"},"review_comments":{"href":"https://api.github.com/repos/pioneerspacesim/pioneer/pulls/3169/comments"},"review_comment":{"href":"https://api.github.com/repos/pioneerspacesim/pioneer/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/pioneerspacesim/pioneer/pulls/3169/commits"},"statuses":{"href":"https://api.github.com/repos/pioneerspacesim/pioneer/statuses/a2dfcd51d70fe3602f6f4ab25fd9b52dda08cdb2"}}}}