GitHub PullRequestReviewCommentEvent at 2014-08-29 19:20:03
Repository: chef-zookeeper
Actor: jeffbyrnes
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/SimpleFinance/chef-zookeeper/pulls/comments/16915940","id":16915940,"diff_hunk":"@@ -14,10 +14,14 @@\n # See the License for the specific language governing permissions and\n # limitations under the License.\n \n-node.override['build-essential']['compile_time'] = true\n+if node[:zookeeper][:use_java_cookbook] == true\n+  node.override[:'build-essential'][:compile_time] = true","path":"recipes/install.rb","position":6,"original_position":6,"commit_id":"09befcd88578ff2f1753ac210f078372607f4a71","original_commit_id":"09befcd88578ff2f1753ac210f078372607f4a71","user":{"login":"jeffbyrnes","id":260553,"avatar_url":"https://avatars.githubusercontent.com/u/260553?v=2","gravatar_id":"e9e409ecf5d0650e6a987a174444795b","url":"https://api.github.com/users/jeffbyrnes","html_url":"https://github.com/jeffbyrnes","followers_url":"https://api.github.com/users/jeffbyrnes/followers","following_url":"https://api.github.com/users/jeffbyrnes/following{/other_user}","gists_url":"https://api.github.com/users/jeffbyrnes/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffbyrnes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffbyrnes/subscriptions","organizations_url":"https://api.github.com/users/jeffbyrnes/orgs","repos_url":"https://api.github.com/users/jeffbyrnes/repos","events_url":"https://api.github.com/users/jeffbyrnes/events{/privacy}","received_events_url":"https://api.github.com/users/jeffbyrnes/received_events","type":"User","site_admin":false},"body":"Yeah, the symbols stuff is annoying sometimes. We just use strings for attributes instead of symbols, and avoid the issue entirely. There's other caveats to that, but we haven't had any issues ourselves.","created_at":"2014-08-29T19:20:03Z","updated_at":"2014-08-29T19:20:03Z","html_url":"https://github.com/SimpleFinance/chef-zookeeper/pull/100#discussion_r16915940","pull_request_url":"https://api.github.com/repos/SimpleFinance/chef-zookeeper/pulls/100","_links":{"self":{"href":"https://api.github.com/repos/SimpleFinance/chef-zookeeper/pulls/comments/16915940"},"html":{"href":"https://github.com/SimpleFinance/chef-zookeeper/pull/100#discussion_r16915940"},"pull_request":{"href":"https://api.github.com/repos/SimpleFinance/chef-zookeeper/pulls/100"}}},"pull_request":{"url":"https://api.github.com/repos/SimpleFinance/chef-zookeeper/pulls/100","id":20475494,"html_url":"https://github.com/SimpleFinance/chef-zookeeper/pull/100","diff_url":"https://github.com/SimpleFinance/chef-zookeeper/pull/100.diff","patch_url":"https://github.com/SimpleFinance/chef-zookeeper/pull/100.patch","issue_url":"https://api.github.com/repos/SimpleFinance/chef-zookeeper/issues/100","number":100,"state":"closed","locked":false,"title":"First pass at making using the java cookbook optional.","user":{"login":"solarce","id":9660,"avatar_url":"https://avatars.githubusercontent.com/u/9660?v=2","gravatar_id":"675e2b6f653233a3a4d4e04f34610e1d","url":"https://api.github.com/users/solarce","html_url":"https://github.com/solarce","followers_url":"https://api.github.com/users/solarce/followers","following_url":"https://api.github.com/users/solarce/following{/other_user}","gists_url":"https://api.github.com/users/solarce/gists{/gist_id}","starred_url":"https://api.github.com/users/solarce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solarce/subscriptions","organizations_url":"https://api.github.com/users/solarce/orgs","repos_url":"https://api.github.com/users/solarce/repos","events_url":"https://api.github.com/users/solarce/events{/privacy}","received_events_url":"https://api.github.com/users/solarce/received_events","type":"User","site_admin":false},"body":"First pass at making using the java cookbook optional.\r\n\r\nFor #84.","created_at":"2014-08-29T00:17:26Z","updated_at":"2014-08-29T19:20:03Z","closed_at":"2014-08-29T15:48:55Z","merged_at":"2014-08-29T15:48:55Z","merge_commit_sha":"d9d60672e49039c30a0914cc85c702984e7ef328","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SimpleFinance/chef-zookeeper/pulls/100/commits","review_comments_url":"https://api.github.com/repos/SimpleFinance/chef-zookeeper/pulls/100/comments","review_comment_url":"https://api.github.com/repos/SimpleFinance/chef-zookeeper/pulls/comments/{number}","comments_url":"https://api.github.com/repos/SimpleFinance/chef-zookeeper/issues/100/comments","statuses_url":"https://api.github.com/repos/SimpleFinance/chef-zookeeper/statuses/09befcd88578ff2f1753ac210f078372607f4a71","head":{"label":"solarce:84-use-java-cookbook","ref":"84-use-java-cookbook","sha":"09befcd88578ff2f1753ac210f078372607f4a71","user":{"login":"solarce","id":9660,"avatar_url":"https://avatars.githubusercontent.com/u/9660?v=2","gravatar_id":"675e2b6f653233a3a4d4e04f34610e1d","url":"https://api.github.com/users/solarce","html_url":"https://github.com/solarce","followers_url":"https://api.github.com/users/solarce/followers","following_url":"https://api.github.com/users/solarce/following{/other_user}","gists_url":"https://api.github.com/users/solarce/gists{/gist_id}","starred_url":"https://api.github.com/users/solarce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solarce/subscriptions","organizations_url":"https://api.github.com/users/solarce/orgs","repos_url":"https://api.github.com/users/solarce/repos","events_url":"https://api.github.com/users/solarce/events{/privacy}","received_events_url":"https://api.github.com/users/solarce/received_events","type":"User","site_admin":false},"repo":{"id":22960095,"name":"chef-zookeeper","full_name":"solarce/chef-zookeeper","owner":{"login":"solarce","id":9660,"avatar_url":"https://avatars.githubusercontent.com/u/9660?v=2","gravatar_id":"675e2b6f653233a3a4d4e04f34610e1d","url":"https://api.github.com/users/solarce","html_url":"https://github.com/solarce","followers_url":"https://api.github.com/users/solarce/followers","following_url":"https://api.github.com/users/solarce/following{/other_user}","gists_url":"https://api.github.com/users/solarce/gists{/gist_id}","starred_url":"https://api.github.com/users/solarce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solarce/subscriptions","organizations_url":"https://api.github.com/users/solarce/orgs","repos_url":"https://api.github.com/users/solarce/repos","events_url":"https://api.github.com/users/solarce/events{/privacy}","received_events_url":"https://api.github.com/users/solarce/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/solarce/chef-zookeeper","description":"Chef cookbook for installing and managing Zookeeper.","fork":true,"url":"https://api.github.com/repos/solarce/chef-zookeeper","forks_url":"https://api.github.com/repos/solarce/chef-zookeeper/forks","keys_url":"https://api.github.com/repos/solarce/chef-zookeeper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/solarce/chef-zookeeper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/solarce/chef-zookeeper/teams","hooks_url":"https://api.github.com/repos/solarce/chef-zookeeper/hooks","issue_events_url":"https://api.github.com/repos/solarce/chef-zookeeper/issues/events{/number}","events_url":"https://api.github.com/repos/solarce/chef-zookeeper/events","assignees_url":"https://api.github.com/repos/solarce/chef-zookeeper/assignees{/user}","branches_url":"https://api.github.com/repos/solarce/chef-zookeeper/branches{/branch}","tags_url":"https://api.github.com/repos/solarce/chef-zookeeper/tags","blobs_url":"https://api.github.com/repos/solarce/chef-zookeeper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/solarce/chef-zookeeper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/solarce/chef-zookeeper/git/refs{/sha}","trees_url":"https://api.github.com/repos/solarce/chef-zookeeper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/solarce/chef-zookeeper/statuses/{sha}","languages_url":"https://api.github.com/repos/solarce/chef-zookeeper/languages","stargazers_url":"https://api.github.com/repos/solarce/chef-zookeeper/stargazers","contributors_url":"https://api.github.com/repos/solarce/chef-zookeeper/contributors","subscribers_url":"https://api.github.com/repos/solarce/chef-zookeeper/subscribers","subscription_url":"https://api.github.com/repos/solarce/chef-zookeeper/subscription","commits_url":"https://api.github.com/repos/solarce/chef-zookeeper/commits{/sha}","git_commits_url":"https://api.github.com/repos/solarce/chef-zookeeper/git/commits{/sha}","comments_url":"https://api.github.com/repos/solarce/chef-zookeeper/comments{/number}","issue_comment_url":"https://api.github.com/repos/solarce/chef-zookeeper/issues/comments/{number}","contents_url":"https://api.github.com/repos/solarce/chef-zookeeper/contents/{+path}","compare_url":"https://api.github.com/repos/solarce/chef-zookeeper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/solarce/chef-zookeeper/merges","archive_url":"https://api.github.com/repos/solarce/chef-zookeeper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/solarce/chef-zookeeper/downloads","issues_url":"https://api.github.com/repos/solarce/chef-zookeeper/issues{/number}","pulls_url":"https://api.github.com/repos/solarce/chef-zookeeper/pulls{/number}","milestones_url":"https://api.github.com/repos/solarce/chef-zookeeper/milestones{/number}","notifications_url":"https://api.github.com/repos/solarce/chef-zookeeper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/solarce/chef-zookeeper/labels{/name}","releases_url":"https://api.github.com/repos/solarce/chef-zookeeper/releases{/id}","created_at":"2014-08-14T16:09:09Z","updated_at":"2014-08-22T17:45:23Z","pushed_at":"2014-08-29T14:37:58Z","git_url":"git://github.com/solarce/chef-zookeeper.git","ssh_url":"git@github.com:solarce/chef-zookeeper.git","clone_url":"https://github.com/solarce/chef-zookeeper.git","svn_url":"https://github.com/solarce/chef-zookeeper","homepage":"","size":345,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SimpleFinance:master","ref":"master","sha":"8b18417314fec4af6571f1b1a57fc82c0e0b133a","user":{"login":"SimpleFinance","id":366647,"avatar_url":"https://avatars.githubusercontent.com/u/366647?v=2","gravatar_id":"0fdcb19657896ac6110402bdb5d88142","url":"https://api.github.com/users/SimpleFinance","html_url":"https://github.com/SimpleFinance","followers_url":"https://api.github.com/users/SimpleFinance/followers","following_url":"https://api.github.com/users/SimpleFinance/following{/other_user}","gists_url":"https://api.github.com/users/SimpleFinance/gists{/gist_id}","starred_url":"https://api.github.com/users/SimpleFinance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimpleFinance/subscriptions","organizations_url":"https://api.github.com/users/SimpleFinance/orgs","repos_url":"https://api.github.com/users/SimpleFinance/repos","events_url":"https://api.github.com/users/SimpleFinance/events{/privacy}","received_events_url":"https://api.github.com/users/SimpleFinance/received_events","type":"Organization","site_admin":false},"repo":{"id":8036243,"name":"chef-zookeeper","full_name":"SimpleFinance/chef-zookeeper","owner":{"login":"SimpleFinance","id":366647,"avatar_url":"https://avatars.githubusercontent.com/u/366647?v=2","gravatar_id":"0fdcb19657896ac6110402bdb5d88142","url":"https://api.github.com/users/SimpleFinance","html_url":"https://github.com/SimpleFinance","followers_url":"https://api.github.com/users/SimpleFinance/followers","following_url":"https://api.github.com/users/SimpleFinance/following{/other_user}","gists_url":"https://api.github.com/users/SimpleFinance/gists{/gist_id}","starred_url":"https://api.github.com/users/SimpleFinance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimpleFinance/subscriptions","organizations_url":"https://api.github.com/users/SimpleFinance/orgs","repos_url":"https://api.github.com/users/SimpleFinance/repos","events_url":"https://api.github.com/users/SimpleFinance/events{/privacy}","received_events_url":"https://api.github.com/users/SimpleFinance/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SimpleFinance/chef-zookeeper","description":"Chef cookbook for installing and managing Zookeeper.","fork":false,"url":"https://api.github.com/repos/SimpleFinance/chef-zookeeper","forks_url":"https://api.github.com/repos/SimpleFinance/chef-zookeeper/forks","keys_url":"https://api.github.com/repos/SimpleFinance/chef-zookeeper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SimpleFinance/chef-zookeeper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SimpleFinance/chef-zookeeper/teams","hooks_url":"https://api.github.com/repos/SimpleFinance/chef-zookeeper/hooks","issue_events_url":"https://api.github.com/repos/SimpleFinance/chef-zookeeper/issues/events{/number}","events_url":"https://api.github.com/repos/SimpleFinance/chef-zookeeper/events","assignees_url":"https://api.github.com/repos/SimpleFinance/chef-zookeeper/assignees{/user}","branches_url":"https://api.github.com/repos/SimpleFinance/chef-zookeeper/branches{/branch}","tags_url":"https://api.github.com/repos/SimpleFinance/chef-zookeeper/tags","blobs_url":"https://api.github.com/repos/SimpleFinance/chef-zookeeper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SimpleFinance/chef-zookeeper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SimpleFinance/chef-zookeeper/git/refs{/sha}","trees_url":"https://api.github.com/repos/SimpleFinance/chef-zookeeper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SimpleFinance/chef-zookeeper/statuses/{sha}","languages_url":"https://api.github.com/repos/SimpleFinance/chef-zookeeper/languages","stargazers_url":"https://api.github.com/repos/SimpleFinance/chef-zookeeper/stargazers","contributors_url":"https://api.github.com/repos/SimpleFinance/chef-zookeeper/contributors","subscribers_url":"https://api.github.com/repos/SimpleFinance/chef-zookeeper/subscribers","subscription_url":"https://api.github.com/repos/SimpleFinance/chef-zookeeper/subscription","commits_url":"https://api.github.com/repos/SimpleFinance/chef-zookeeper/commits{/sha}","git_commits_url":"https://api.github.com/repos/SimpleFinance/chef-zookeeper/git/commits{/sha}","comments_url":"https://api.github.com/repos/SimpleFinance/chef-zookeeper/comments{/number}","issue_comment_url":"https://api.github.com/repos/SimpleFinance/chef-zookeeper/issues/comments/{number}","contents_url":"https://api.github.com/repos/SimpleFinance/chef-zookeeper/contents/{+path}","compare_url":"https://api.github.com/repos/SimpleFinance/chef-zookeeper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SimpleFinance/chef-zookeeper/merges","archive_url":"https://api.github.com/repos/SimpleFinance/chef-zookeeper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SimpleFinance/chef-zookeeper/downloads","issues_url":"https://api.github.com/repos/SimpleFinance/chef-zookeeper/issues{/number}","pulls_url":"https://api.github.com/repos/SimpleFinance/chef-zookeeper/pulls{/number}","milestones_url":"https://api.github.com/repos/SimpleFinance/chef-zookeeper/milestones{/number}","notifications_url":"https://api.github.com/repos/SimpleFinance/chef-zookeeper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SimpleFinance/chef-zookeeper/labels{/name}","releases_url":"https://api.github.com/repos/SimpleFinance/chef-zookeeper/releases{/id}","created_at":"2013-02-05T19:33:32Z","updated_at":"2014-08-26T19:35:16Z","pushed_at":"2014-08-29T16:44:00Z","git_url":"git://github.com/SimpleFinance/chef-zookeeper.git","ssh_url":"git@github.com:SimpleFinance/chef-zookeeper.git","clone_url":"https://github.com/SimpleFinance/chef-zookeeper.git","svn_url":"https://github.com/SimpleFinance/chef-zookeeper","homepage":"","size":1701,"stargazers_count":50,"watchers_count":50,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":45,"mirror_url":null,"open_issues_count":7,"forks":45,"open_issues":7,"watchers":50,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SimpleFinance/chef-zookeeper/pulls/100"},"html":{"href":"https://github.com/SimpleFinance/chef-zookeeper/pull/100"},"issue":{"href":"https://api.github.com/repos/SimpleFinance/chef-zookeeper/issues/100"},"comments":{"href":"https://api.github.com/repos/SimpleFinance/chef-zookeeper/issues/100/comments"},"review_comments":{"href":"https://api.github.com/repos/SimpleFinance/chef-zookeeper/pulls/100/comments"},"review_comment":{"href":"https://api.github.com/repos/SimpleFinance/chef-zookeeper/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/SimpleFinance/chef-zookeeper/pulls/100/commits"},"statuses":{"href":"https://api.github.com/repos/SimpleFinance/chef-zookeeper/statuses/09befcd88578ff2f1753ac210f078372607f4a71"}}}}