GitHub PullRequestEvent at 2014-09-10 10:27:03
Repository: ttfunk
Actor: sandal
Payload: {"action":"closed","number":21,"pull_request":{"url":"https://api.github.com/repos/prawnpdf/ttfunk/pulls/21","id":20931025,"html_url":"https://github.com/prawnpdf/ttfunk/pull/21","diff_url":"https://github.com/prawnpdf/ttfunk/pull/21.diff","patch_url":"https://github.com/prawnpdf/ttfunk/pull/21.patch","issue_url":"https://api.github.com/repos/prawnpdf/ttfunk/issues/21","number":21,"state":"closed","locked":false,"title":"Fix for issue #13 (lots of ruby warnings generated).","user":{"login":"jessedoyle","id":6474230,"avatar_url":"https://avatars.githubusercontent.com/u/6474230?v=2","gravatar_id":"1206303bebd4c6310522497b36b14a53","url":"https://api.github.com/users/jessedoyle","html_url":"https://github.com/jessedoyle","followers_url":"https://api.github.com/users/jessedoyle/followers","following_url":"https://api.github.com/users/jessedoyle/following{/other_user}","gists_url":"https://api.github.com/users/jessedoyle/gists{/gist_id}","starred_url":"https://api.github.com/users/jessedoyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessedoyle/subscriptions","organizations_url":"https://api.github.com/users/jessedoyle/orgs","repos_url":"https://api.github.com/users/jessedoyle/repos","events_url":"https://api.github.com/users/jessedoyle/events{/privacy}","received_events_url":"https://api.github.com/users/jessedoyle/received_events","type":"User","site_admin":false},"body":"Many of TTFunk's classes had unused variable assignments. The warnings were bothering me, so I changed all unused variables to underscores, but left a comment above the change outlining what the variable represents. All tests pass for me and the warnings are no longer generated.","created_at":"2014-09-09T02:43:08Z","updated_at":"2014-09-10T10:27:03Z","closed_at":"2014-09-10T10:27:03Z","merged_at":"2014-09-10T10:27:03Z","merge_commit_sha":"5e11b8eb39a6f2c2dbd45c399343f61aecfdd730","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/prawnpdf/ttfunk/pulls/21/commits","review_comments_url":"https://api.github.com/repos/prawnpdf/ttfunk/pulls/21/comments","review_comment_url":"https://api.github.com/repos/prawnpdf/ttfunk/pulls/comments/{number}","comments_url":"https://api.github.com/repos/prawnpdf/ttfunk/issues/21/comments","statuses_url":"https://api.github.com/repos/prawnpdf/ttfunk/statuses/877150f35463fe17834069fd71d657deb441d51c","head":{"label":"jessedoyle:master","ref":"master","sha":"877150f35463fe17834069fd71d657deb441d51c","user":{"login":"jessedoyle","id":6474230,"avatar_url":"https://avatars.githubusercontent.com/u/6474230?v=2","gravatar_id":"1206303bebd4c6310522497b36b14a53","url":"https://api.github.com/users/jessedoyle","html_url":"https://github.com/jessedoyle","followers_url":"https://api.github.com/users/jessedoyle/followers","following_url":"https://api.github.com/users/jessedoyle/following{/other_user}","gists_url":"https://api.github.com/users/jessedoyle/gists{/gist_id}","starred_url":"https://api.github.com/users/jessedoyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessedoyle/subscriptions","organizations_url":"https://api.github.com/users/jessedoyle/orgs","repos_url":"https://api.github.com/users/jessedoyle/repos","events_url":"https://api.github.com/users/jessedoyle/events{/privacy}","received_events_url":"https://api.github.com/users/jessedoyle/received_events","type":"User","site_admin":false},"repo":{"id":23814502,"name":"ttfunk","full_name":"jessedoyle/ttfunk","owner":{"login":"jessedoyle","id":6474230,"avatar_url":"https://avatars.githubusercontent.com/u/6474230?v=2","gravatar_id":"1206303bebd4c6310522497b36b14a53","url":"https://api.github.com/users/jessedoyle","html_url":"https://github.com/jessedoyle","followers_url":"https://api.github.com/users/jessedoyle/followers","following_url":"https://api.github.com/users/jessedoyle/following{/other_user}","gists_url":"https://api.github.com/users/jessedoyle/gists{/gist_id}","starred_url":"https://api.github.com/users/jessedoyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessedoyle/subscriptions","organizations_url":"https://api.github.com/users/jessedoyle/orgs","repos_url":"https://api.github.com/users/jessedoyle/repos","events_url":"https://api.github.com/users/jessedoyle/events{/privacy}","received_events_url":"https://api.github.com/users/jessedoyle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jessedoyle/ttfunk","description":"Font Metrics Parser for Prawn","fork":true,"url":"https://api.github.com/repos/jessedoyle/ttfunk","forks_url":"https://api.github.com/repos/jessedoyle/ttfunk/forks","keys_url":"https://api.github.com/repos/jessedoyle/ttfunk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jessedoyle/ttfunk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jessedoyle/ttfunk/teams","hooks_url":"https://api.github.com/repos/jessedoyle/ttfunk/hooks","issue_events_url":"https://api.github.com/repos/jessedoyle/ttfunk/issues/events{/number}","events_url":"https://api.github.com/repos/jessedoyle/ttfunk/events","assignees_url":"https://api.github.com/repos/jessedoyle/ttfunk/assignees{/user}","branches_url":"https://api.github.com/repos/jessedoyle/ttfunk/branches{/branch}","tags_url":"https://api.github.com/repos/jessedoyle/ttfunk/tags","blobs_url":"https://api.github.com/repos/jessedoyle/ttfunk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jessedoyle/ttfunk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jessedoyle/ttfunk/git/refs{/sha}","trees_url":"https://api.github.com/repos/jessedoyle/ttfunk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jessedoyle/ttfunk/statuses/{sha}","languages_url":"https://api.github.com/repos/jessedoyle/ttfunk/languages","stargazers_url":"https://api.github.com/repos/jessedoyle/ttfunk/stargazers","contributors_url":"https://api.github.com/repos/jessedoyle/ttfunk/contributors","subscribers_url":"https://api.github.com/repos/jessedoyle/ttfunk/subscribers","subscription_url":"https://api.github.com/repos/jessedoyle/ttfunk/subscription","commits_url":"https://api.github.com/repos/jessedoyle/ttfunk/commits{/sha}","git_commits_url":"https://api.github.com/repos/jessedoyle/ttfunk/git/commits{/sha}","comments_url":"https://api.github.com/repos/jessedoyle/ttfunk/comments{/number}","issue_comment_url":"https://api.github.com/repos/jessedoyle/ttfunk/issues/comments/{number}","contents_url":"https://api.github.com/repos/jessedoyle/ttfunk/contents/{+path}","compare_url":"https://api.github.com/repos/jessedoyle/ttfunk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jessedoyle/ttfunk/merges","archive_url":"https://api.github.com/repos/jessedoyle/ttfunk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jessedoyle/ttfunk/downloads","issues_url":"https://api.github.com/repos/jessedoyle/ttfunk/issues{/number}","pulls_url":"https://api.github.com/repos/jessedoyle/ttfunk/pulls{/number}","milestones_url":"https://api.github.com/repos/jessedoyle/ttfunk/milestones{/number}","notifications_url":"https://api.github.com/repos/jessedoyle/ttfunk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jessedoyle/ttfunk/labels{/name}","releases_url":"https://api.github.com/repos/jessedoyle/ttfunk/releases{/id}","created_at":"2014-09-09T01:07:14Z","updated_at":"2014-09-09T01:51:44Z","pushed_at":"2014-09-10T02:51:32Z","git_url":"git://github.com/jessedoyle/ttfunk.git","ssh_url":"git@github.com:jessedoyle/ttfunk.git","clone_url":"https://github.com/jessedoyle/ttfunk.git","svn_url":"https://github.com/jessedoyle/ttfunk","homepage":"http://prawn.majesticseacreature.com","size":998,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"prawnpdf:master","ref":"master","sha":"684d010e0cd18be2e6576fdc63f1b7ba3a11c570","user":{"login":"prawnpdf","id":1440292,"avatar_url":"https://avatars.githubusercontent.com/u/1440292?v=2","gravatar_id":"06e9294f227ed9cc40c67628aba514a1","url":"https://api.github.com/users/prawnpdf","html_url":"https://github.com/prawnpdf","followers_url":"https://api.github.com/users/prawnpdf/followers","following_url":"https://api.github.com/users/prawnpdf/following{/other_user}","gists_url":"https://api.github.com/users/prawnpdf/gists{/gist_id}","starred_url":"https://api.github.com/users/prawnpdf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prawnpdf/subscriptions","organizations_url":"https://api.github.com/users/prawnpdf/orgs","repos_url":"https://api.github.com/users/prawnpdf/repos","events_url":"https://api.github.com/users/prawnpdf/events{/privacy}","received_events_url":"https://api.github.com/users/prawnpdf/received_events","type":"Organization","site_admin":false},"repo":{"id":69899,"name":"ttfunk","full_name":"prawnpdf/ttfunk","owner":{"login":"prawnpdf","id":1440292,"avatar_url":"https://avatars.githubusercontent.com/u/1440292?v=2","gravatar_id":"06e9294f227ed9cc40c67628aba514a1","url":"https://api.github.com/users/prawnpdf","html_url":"https://github.com/prawnpdf","followers_url":"https://api.github.com/users/prawnpdf/followers","following_url":"https://api.github.com/users/prawnpdf/following{/other_user}","gists_url":"https://api.github.com/users/prawnpdf/gists{/gist_id}","starred_url":"https://api.github.com/users/prawnpdf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prawnpdf/subscriptions","organizations_url":"https://api.github.com/users/prawnpdf/orgs","repos_url":"https://api.github.com/users/prawnpdf/repos","events_url":"https://api.github.com/users/prawnpdf/events{/privacy}","received_events_url":"https://api.github.com/users/prawnpdf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prawnpdf/ttfunk","description":"Font Metrics Parser for Prawn","fork":false,"url":"https://api.github.com/repos/prawnpdf/ttfunk","forks_url":"https://api.github.com/repos/prawnpdf/ttfunk/forks","keys_url":"https://api.github.com/repos/prawnpdf/ttfunk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prawnpdf/ttfunk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prawnpdf/ttfunk/teams","hooks_url":"https://api.github.com/repos/prawnpdf/ttfunk/hooks","issue_events_url":"https://api.github.com/repos/prawnpdf/ttfunk/issues/events{/number}","events_url":"https://api.github.com/repos/prawnpdf/ttfunk/events","assignees_url":"https://api.github.com/repos/prawnpdf/ttfunk/assignees{/user}","branches_url":"https://api.github.com/repos/prawnpdf/ttfunk/branches{/branch}","tags_url":"https://api.github.com/repos/prawnpdf/ttfunk/tags","blobs_url":"https://api.github.com/repos/prawnpdf/ttfunk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prawnpdf/ttfunk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prawnpdf/ttfunk/git/refs{/sha}","trees_url":"https://api.github.com/repos/prawnpdf/ttfunk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prawnpdf/ttfunk/statuses/{sha}","languages_url":"https://api.github.com/repos/prawnpdf/ttfunk/languages","stargazers_url":"https://api.github.com/repos/prawnpdf/ttfunk/stargazers","contributors_url":"https://api.github.com/repos/prawnpdf/ttfunk/contributors","subscribers_url":"https://api.github.com/repos/prawnpdf/ttfunk/subscribers","subscription_url":"https://api.github.com/repos/prawnpdf/ttfunk/subscription","commits_url":"https://api.github.com/repos/prawnpdf/ttfunk/commits{/sha}","git_commits_url":"https://api.github.com/repos/prawnpdf/ttfunk/git/commits{/sha}","comments_url":"https://api.github.com/repos/prawnpdf/ttfunk/comments{/number}","issue_comment_url":"https://api.github.com/repos/prawnpdf/ttfunk/issues/comments/{number}","contents_url":"https://api.github.com/repos/prawnpdf/ttfunk/contents/{+path}","compare_url":"https://api.github.com/repos/prawnpdf/ttfunk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prawnpdf/ttfunk/merges","archive_url":"https://api.github.com/repos/prawnpdf/ttfunk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prawnpdf/ttfunk/downloads","issues_url":"https://api.github.com/repos/prawnpdf/ttfunk/issues{/number}","pulls_url":"https://api.github.com/repos/prawnpdf/ttfunk/pulls{/number}","milestones_url":"https://api.github.com/repos/prawnpdf/ttfunk/milestones{/number}","notifications_url":"https://api.github.com/repos/prawnpdf/ttfunk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prawnpdf/ttfunk/labels{/name}","releases_url":"https://api.github.com/repos/prawnpdf/ttfunk/releases{/id}","created_at":"2008-10-30T22:41:01Z","updated_at":"2014-08-28T14:40:40Z","pushed_at":"2014-09-10T10:27:03Z","git_url":"git://github.com/prawnpdf/ttfunk.git","ssh_url":"git@github.com:prawnpdf/ttfunk.git","clone_url":"https://github.com/prawnpdf/ttfunk.git","svn_url":"https://github.com/prawnpdf/ttfunk","homepage":"http://prawn.majesticseacreature.com","size":1394,"stargazers_count":82,"watchers_count":82,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":59,"mirror_url":null,"open_issues_count":4,"forks":59,"open_issues":4,"watchers":82,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prawnpdf/ttfunk/pulls/21"},"html":{"href":"https://github.com/prawnpdf/ttfunk/pull/21"},"issue":{"href":"https://api.github.com/repos/prawnpdf/ttfunk/issues/21"},"comments":{"href":"https://api.github.com/repos/prawnpdf/ttfunk/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/prawnpdf/ttfunk/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/prawnpdf/ttfunk/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/prawnpdf/ttfunk/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/prawnpdf/ttfunk/statuses/877150f35463fe17834069fd71d657deb441d51c"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"sandal","id":4893,"avatar_url":"https://avatars.githubusercontent.com/u/4893?v=2","gravatar_id":"31e038e4e9330f6c75ccfd1fca8010ee","url":"https://api.github.com/users/sandal","html_url":"https://github.com/sandal","followers_url":"https://api.github.com/users/sandal/followers","following_url":"https://api.github.com/users/sandal/following{/other_user}","gists_url":"https://api.github.com/users/sandal/gists{/gist_id}","starred_url":"https://api.github.com/users/sandal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandal/subscriptions","organizations_url":"https://api.github.com/users/sandal/orgs","repos_url":"https://api.github.com/users/sandal/repos","events_url":"https://api.github.com/users/sandal/events{/privacy}","received_events_url":"https://api.github.com/users/sandal/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":3,"additions":22,"deletions":26,"changed_files":11}}