GitHub PullRequestEvent at 2014-07-28 14:57:17
Repository: princely
Actor: modsognir
Payload: {"action":"reopened","number":39,"pull_request":{"url":"https://api.github.com/repos/mbleigh/princely/pulls/39","id":18941555,"html_url":"https://github.com/mbleigh/princely/pull/39","diff_url":"https://github.com/mbleigh/princely/pull/39.diff","patch_url":"https://github.com/mbleigh/princely/pull/39.patch","issue_url":"https://api.github.com/repos/mbleigh/princely/issues/39","number":39,"state":"open","title":"Force the html_string become String, because it is possible like SafeBut...","user":{"login":"ilake","id":14666,"avatar_url":"https://avatars.githubusercontent.com/u/14666?","gravatar_id":"afccf26f44899a9f9ccf061c5e1a695e","url":"https://api.github.com/users/ilake","html_url":"https://github.com/ilake","followers_url":"https://api.github.com/users/ilake/followers","following_url":"https://api.github.com/users/ilake/following{/other_user}","gists_url":"https://api.github.com/users/ilake/gists{/gist_id}","starred_url":"https://api.github.com/users/ilake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilake/subscriptions","organizations_url":"https://api.github.com/users/ilake/orgs","repos_url":"https://api.github.com/users/ilake/repos","events_url":"https://api.github.com/users/ilake/events{/privacy}","received_events_url":"https://api.github.com/users/ilake/received_events","type":"User","site_admin":false},"body":"...ter that would cause $1 would not unavailable in the block.\r\n\r\nThe issue we meet is we try to generate the html_string in the presenter and the html_string is a SafeBuffer class,  then you could not get the $1 in the block.\r\n\r\nreference: https://github.com/rails/rails/issues/1555","created_at":"2014-07-27T15:15:18Z","updated_at":"2014-07-28T14:57:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"278d34fbb7f842663177349bfe3b2e2d92a1d55b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mbleigh/princely/pulls/39/commits","review_comments_url":"https://api.github.com/repos/mbleigh/princely/pulls/39/comments","review_comment_url":"https://api.github.com/repos/mbleigh/princely/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mbleigh/princely/issues/39/comments","statuses_url":"https://api.github.com/repos/mbleigh/princely/statuses/3556e251fd4ae4c16dbb5a718f2d4a6b408682c0","head":{"label":"ilake:master","ref":"master","sha":"3556e251fd4ae4c16dbb5a718f2d4a6b408682c0","user":{"login":"ilake","id":14666,"avatar_url":"https://avatars.githubusercontent.com/u/14666?","gravatar_id":"afccf26f44899a9f9ccf061c5e1a695e","url":"https://api.github.com/users/ilake","html_url":"https://github.com/ilake","followers_url":"https://api.github.com/users/ilake/followers","following_url":"https://api.github.com/users/ilake/following{/other_user}","gists_url":"https://api.github.com/users/ilake/gists{/gist_id}","starred_url":"https://api.github.com/users/ilake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilake/subscriptions","organizations_url":"https://api.github.com/users/ilake/orgs","repos_url":"https://api.github.com/users/ilake/repos","events_url":"https://api.github.com/users/ilake/events{/privacy}","received_events_url":"https://api.github.com/users/ilake/received_events","type":"User","site_admin":false},"repo":{"id":22313552,"name":"princely","full_name":"ilake/princely","owner":{"login":"ilake","id":14666,"avatar_url":"https://avatars.githubusercontent.com/u/14666?","gravatar_id":"afccf26f44899a9f9ccf061c5e1a695e","url":"https://api.github.com/users/ilake","html_url":"https://github.com/ilake","followers_url":"https://api.github.com/users/ilake/followers","following_url":"https://api.github.com/users/ilake/following{/other_user}","gists_url":"https://api.github.com/users/ilake/gists{/gist_id}","starred_url":"https://api.github.com/users/ilake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilake/subscriptions","organizations_url":"https://api.github.com/users/ilake/orgs","repos_url":"https://api.github.com/users/ilake/repos","events_url":"https://api.github.com/users/ilake/events{/privacy}","received_events_url":"https://api.github.com/users/ilake/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ilake/princely","description":"A simple Rails wrapper for the PrinceXML PDF generation library.","fork":true,"url":"https://api.github.com/repos/ilake/princely","forks_url":"https://api.github.com/repos/ilake/princely/forks","keys_url":"https://api.github.com/repos/ilake/princely/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ilake/princely/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ilake/princely/teams","hooks_url":"https://api.github.com/repos/ilake/princely/hooks","issue_events_url":"https://api.github.com/repos/ilake/princely/issues/events{/number}","events_url":"https://api.github.com/repos/ilake/princely/events","assignees_url":"https://api.github.com/repos/ilake/princely/assignees{/user}","branches_url":"https://api.github.com/repos/ilake/princely/branches{/branch}","tags_url":"https://api.github.com/repos/ilake/princely/tags","blobs_url":"https://api.github.com/repos/ilake/princely/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ilake/princely/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ilake/princely/git/refs{/sha}","trees_url":"https://api.github.com/repos/ilake/princely/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ilake/princely/statuses/{sha}","languages_url":"https://api.github.com/repos/ilake/princely/languages","stargazers_url":"https://api.github.com/repos/ilake/princely/stargazers","contributors_url":"https://api.github.com/repos/ilake/princely/contributors","subscribers_url":"https://api.github.com/repos/ilake/princely/subscribers","subscription_url":"https://api.github.com/repos/ilake/princely/subscription","commits_url":"https://api.github.com/repos/ilake/princely/commits{/sha}","git_commits_url":"https://api.github.com/repos/ilake/princely/git/commits{/sha}","comments_url":"https://api.github.com/repos/ilake/princely/comments{/number}","issue_comment_url":"https://api.github.com/repos/ilake/princely/issues/comments/{number}","contents_url":"https://api.github.com/repos/ilake/princely/contents/{+path}","compare_url":"https://api.github.com/repos/ilake/princely/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ilake/princely/merges","archive_url":"https://api.github.com/repos/ilake/princely/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ilake/princely/downloads","issues_url":"https://api.github.com/repos/ilake/princely/issues{/number}","pulls_url":"https://api.github.com/repos/ilake/princely/pulls{/number}","milestones_url":"https://api.github.com/repos/ilake/princely/milestones{/number}","notifications_url":"https://api.github.com/repos/ilake/princely/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ilake/princely/labels{/name}","releases_url":"https://api.github.com/repos/ilake/princely/releases{/id}","created_at":"2014-07-27T15:04:42Z","updated_at":"2014-07-27T15:12:09Z","pushed_at":"2014-07-27T15:12:09Z","git_url":"git://github.com/ilake/princely.git","ssh_url":"git@github.com:ilake/princely.git","clone_url":"https://github.com/ilake/princely.git","svn_url":"https://github.com/ilake/princely","homepage":"http://www.mbleigh.com/plugins/princely-rails-prince-xml-wrapper","size":562,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mbleigh:master","ref":"master","sha":"516fe451ed517f2dc1432ae979321783aa02ca1b","user":{"login":"mbleigh","id":1022,"avatar_url":"https://avatars.githubusercontent.com/u/1022?","gravatar_id":"69dc78b59ef008c58e6e842f9f3e0624","url":"https://api.github.com/users/mbleigh","html_url":"https://github.com/mbleigh","followers_url":"https://api.github.com/users/mbleigh/followers","following_url":"https://api.github.com/users/mbleigh/following{/other_user}","gists_url":"https://api.github.com/users/mbleigh/gists{/gist_id}","starred_url":"https://api.github.com/users/mbleigh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbleigh/subscriptions","organizations_url":"https://api.github.com/users/mbleigh/orgs","repos_url":"https://api.github.com/users/mbleigh/repos","events_url":"https://api.github.com/users/mbleigh/events{/privacy}","received_events_url":"https://api.github.com/users/mbleigh/received_events","type":"User","site_admin":false},"repo":{"id":5066,"name":"princely","full_name":"mbleigh/princely","owner":{"login":"mbleigh","id":1022,"avatar_url":"https://avatars.githubusercontent.com/u/1022?","gravatar_id":"69dc78b59ef008c58e6e842f9f3e0624","url":"https://api.github.com/users/mbleigh","html_url":"https://github.com/mbleigh","followers_url":"https://api.github.com/users/mbleigh/followers","following_url":"https://api.github.com/users/mbleigh/following{/other_user}","gists_url":"https://api.github.com/users/mbleigh/gists{/gist_id}","starred_url":"https://api.github.com/users/mbleigh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbleigh/subscriptions","organizations_url":"https://api.github.com/users/mbleigh/orgs","repos_url":"https://api.github.com/users/mbleigh/repos","events_url":"https://api.github.com/users/mbleigh/events{/privacy}","received_events_url":"https://api.github.com/users/mbleigh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mbleigh/princely","description":"A simple Rails wrapper for the PrinceXML PDF generation library.","fork":false,"url":"https://api.github.com/repos/mbleigh/princely","forks_url":"https://api.github.com/repos/mbleigh/princely/forks","keys_url":"https://api.github.com/repos/mbleigh/princely/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mbleigh/princely/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mbleigh/princely/teams","hooks_url":"https://api.github.com/repos/mbleigh/princely/hooks","issue_events_url":"https://api.github.com/repos/mbleigh/princely/issues/events{/number}","events_url":"https://api.github.com/repos/mbleigh/princely/events","assignees_url":"https://api.github.com/repos/mbleigh/princely/assignees{/user}","branches_url":"https://api.github.com/repos/mbleigh/princely/branches{/branch}","tags_url":"https://api.github.com/repos/mbleigh/princely/tags","blobs_url":"https://api.github.com/repos/mbleigh/princely/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mbleigh/princely/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mbleigh/princely/git/refs{/sha}","trees_url":"https://api.github.com/repos/mbleigh/princely/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mbleigh/princely/statuses/{sha}","languages_url":"https://api.github.com/repos/mbleigh/princely/languages","stargazers_url":"https://api.github.com/repos/mbleigh/princely/stargazers","contributors_url":"https://api.github.com/repos/mbleigh/princely/contributors","subscribers_url":"https://api.github.com/repos/mbleigh/princely/subscribers","subscription_url":"https://api.github.com/repos/mbleigh/princely/subscription","commits_url":"https://api.github.com/repos/mbleigh/princely/commits{/sha}","git_commits_url":"https://api.github.com/repos/mbleigh/princely/git/commits{/sha}","comments_url":"https://api.github.com/repos/mbleigh/princely/comments{/number}","issue_comment_url":"https://api.github.com/repos/mbleigh/princely/issues/comments/{number}","contents_url":"https://api.github.com/repos/mbleigh/princely/contents/{+path}","compare_url":"https://api.github.com/repos/mbleigh/princely/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mbleigh/princely/merges","archive_url":"https://api.github.com/repos/mbleigh/princely/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mbleigh/princely/downloads","issues_url":"https://api.github.com/repos/mbleigh/princely/issues{/number}","pulls_url":"https://api.github.com/repos/mbleigh/princely/pulls{/number}","milestones_url":"https://api.github.com/repos/mbleigh/princely/milestones{/number}","notifications_url":"https://api.github.com/repos/mbleigh/princely/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mbleigh/princely/labels{/name}","releases_url":"https://api.github.com/repos/mbleigh/princely/releases{/id}","created_at":"2008-03-23T14:47:53Z","updated_at":"2014-06-11T10:05:02Z","pushed_at":"2014-06-11T10:05:01Z","git_url":"git://github.com/mbleigh/princely.git","ssh_url":"git@github.com:mbleigh/princely.git","clone_url":"https://github.com/mbleigh/princely.git","svn_url":"https://github.com/mbleigh/princely","homepage":"http://www.mbleigh.com/plugins/princely-rails-prince-xml-wrapper","size":562,"stargazers_count":196,"watchers_count":196,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":73,"mirror_url":null,"open_issues_count":4,"forks":73,"open_issues":4,"watchers":196,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mbleigh/princely/pulls/39"},"html":{"href":"https://github.com/mbleigh/princely/pull/39"},"issue":{"href":"https://api.github.com/repos/mbleigh/princely/issues/39"},"comments":{"href":"https://api.github.com/repos/mbleigh/princely/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/mbleigh/princely/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/mbleigh/princely/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mbleigh/princely/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/mbleigh/princely/statuses/3556e251fd4ae4c16dbb5a718f2d4a6b408682c0"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}