GitHub PullRequestReviewCommentEvent at 2014-03-13 08:58:23
Repository: ProjetVaR
Actor: pchaigno
Payload: {"comment":{"url":"https://api.github.com/repos/pchaigno/ProjetVaR/pulls/comments/10556536","id":10556536,"diff_hunk":"@@ -0,0 +1,80 @@\n+#include \"ImportNewData.h\"\n+#include <QMessageBox>\n+#include \"SessionSaver.h\"\n+\n+/**\n+* @brief Import method for Yahoo files\n+* @param name The name of the stock\n+* @param file The file where are located the values.\n+* @param origin The origin of the file with the values.\n+* @param startDate The date of the first value defined.\n+* @param endDate The date of the last value defined.\n+* @throw BadFile The file is not handled\n+*/\n+void ImportNewData::import(const QString &name, const QString &file, const QString &origin, const QDateTime &startDate, const QDateTime &endDate) const{\n+\t\tQString data;\n+\t\tQFile importedCSV(file);\n+\t\tQStringList rowOfData;\n+\t\tQStringList rowData;\n+\t\tdata.clear();\n+\t\trowOfData.clear();\n+        rowData.clear();\n+        // column_of_values_to_import =6;\n+        //if (origin == Yahoo)\n+        //  column_of_values_to_import = 6\n+        //else if(origin == ProjetVaR)\n+        //  column_of_values_to_import = 2\n+        //==> no strategy, no duplicated code ....\n+\n+\t\tif (importedCSV.open(QFile::ReadOnly))\n+\t\t\t{\n+\t\t\t\tdata = importedCSV.readAll();\n+                rowOfData = data.split(\"\\n\");","path":"ProjetVaR_Software/ModelVaR/ImportNewData.cpp","position":32,"original_position":32,"commit_id":"16fa6c44f818c4114cb5f15c2a9efc1e1a5bc793","original_commit_id":"16fa6c44f818c4114cb5f15c2a9efc1e1a5bc793","user":{"login":"pchaigno","id":1764210,"avatar_url":"https://gravatar.com/avatar/3b0b52ad2211a26c4e1cefb472e09cbe?d=https%3A%2F%2Fidenticons.github.com%2F43145f89b744f66ed00979dc18a637a0.png&r=x","gravatar_id":"3b0b52ad2211a26c4e1cefb472e09cbe","url":"https://api.github.com/users/pchaigno","html_url":"https://github.com/pchaigno","followers_url":"https://api.github.com/users/pchaigno/followers","following_url":"https://api.github.com/users/pchaigno/following{/other_user}","gists_url":"https://api.github.com/users/pchaigno/gists{/gist_id}","starred_url":"https://api.github.com/users/pchaigno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pchaigno/subscriptions","organizations_url":"https://api.github.com/users/pchaigno/orgs","repos_url":"https://api.github.com/users/pchaigno/repos","events_url":"https://api.github.com/users/pchaigno/events{/privacy}","received_events_url":"https://api.github.com/users/pchaigno/received_events","type":"User","site_admin":false},"body":"Il faudrait remplacer cette ligne par :\r\n```rowOfData = data.split(QRegExp(\"[\\r\\n]\"), QString::SkipEmptyParts);```\r\npour résoudre le problème d'Ulysse.","created_at":"2014-03-13T08:58:23Z","updated_at":"2014-03-13T08:58:23Z","html_url":"https://github.com/pchaigno/ProjetVaR/pull/6#discussion_r10556536","pull_request_url":"https://api.github.com/repos/pchaigno/ProjetVaR/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/pchaigno/ProjetVaR/pulls/comments/10556536"},"html":{"href":"https://github.com/pchaigno/ProjetVaR/pull/6#discussion_r10556536"},"pull_request":{"href":"https://api.github.com/repos/pchaigno/ProjetVaR/pulls/6"}}}}