GitHub PullRequestReviewCommentEvent at 2014-08-06 11:08:15
Repository: rizzo
Actor: Ianfeather
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/lonelyplanet/rizzo/pulls/comments/15867413","id":15867413,"diff_hunk":"@@ -3,30 +3,6 @@\n \n describe GlobalResourcesHelper do\n \n-  context \"legacy global resources\" do \n-\n-    before do\n-      class << helper\n-        include Haml, Haml::Helpers\n-      end\n-      helper.init_haml_helpers\n-    end\n-\n-    it \"gets a list of navigation items\" do","path":"spec/helpers/global_resources_helper_spec.rb","position":13,"original_position":13,"commit_id":"41b50dad0d1b6ab136aa6215f2343c77c6ad4710","original_commit_id":"41b50dad0d1b6ab136aa6215f2343c77c6ad4710","user":{"login":"Ianfeather","id":814861,"avatar_url":"https://avatars.githubusercontent.com/u/814861?v=2","gravatar_id":"649e3d33ce29a5e6bb4ff3025c6aaffa","url":"https://api.github.com/users/Ianfeather","html_url":"https://github.com/Ianfeather","followers_url":"https://api.github.com/users/Ianfeather/followers","following_url":"https://api.github.com/users/Ianfeather/following{/other_user}","gists_url":"https://api.github.com/users/Ianfeather/gists{/gist_id}","starred_url":"https://api.github.com/users/Ianfeather/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ianfeather/subscriptions","organizations_url":"https://api.github.com/users/Ianfeather/orgs","repos_url":"https://api.github.com/users/Ianfeather/repos","events_url":"https://api.github.com/users/Ianfeather/events{/privacy}","received_events_url":"https://api.github.com/users/Ianfeather/received_events","type":"User","site_admin":false},"body":"These were never used","created_at":"2014-08-06T11:08:15Z","updated_at":"2014-08-06T11:08:15Z","html_url":"https://github.com/lonelyplanet/rizzo/pull/868#discussion_r15867413","pull_request_url":"https://api.github.com/repos/lonelyplanet/rizzo/pulls/868","_links":{"self":{"href":"https://api.github.com/repos/lonelyplanet/rizzo/pulls/comments/15867413"},"html":{"href":"https://github.com/lonelyplanet/rizzo/pull/868#discussion_r15867413"},"pull_request":{"href":"https://api.github.com/repos/lonelyplanet/rizzo/pulls/868"}}},"pull_request":{"url":"https://api.github.com/repos/lonelyplanet/rizzo/pulls/868","id":19397270,"html_url":"https://github.com/lonelyplanet/rizzo/pull/868","diff_url":"https://github.com/lonelyplanet/rizzo/pull/868.diff","patch_url":"https://github.com/lonelyplanet/rizzo/pull/868.patch","issue_url":"https://api.github.com/repos/lonelyplanet/rizzo/issues/868","number":868,"state":"open","title":"If secondary nav","user":{"login":"Ianfeather","id":814861,"avatar_url":"https://avatars.githubusercontent.com/u/814861?v=2","gravatar_id":"649e3d33ce29a5e6bb4ff3025c6aaffa","url":"https://api.github.com/users/Ianfeather","html_url":"https://github.com/Ianfeather","followers_url":"https://api.github.com/users/Ianfeather/followers","following_url":"https://api.github.com/users/Ianfeather/following{/other_user}","gists_url":"https://api.github.com/users/Ianfeather/gists{/gist_id}","starred_url":"https://api.github.com/users/Ianfeather/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ianfeather/subscriptions","organizations_url":"https://api.github.com/users/Ianfeather/orgs","repos_url":"https://api.github.com/users/Ianfeather/repos","events_url":"https://api.github.com/users/Ianfeather/events{/privacy}","received_events_url":"https://api.github.com/users/Ianfeather/received_events","type":"User","site_admin":false},"body":"This was originally a design change, which became a refactor, which was then aborted due to the complexity of the `.responsive &` selectors. It didn't make sense to continue as we will have to do this again once we remove those flags and then we could create a much cleaner solution anyway.\r\n\r\nI started by refactoring the haml so that the primary and secondary nav use the same components for navigation items and flyouts. This work will still stand (although improved) but the css is debatably no better. There is a trello card here where I have listed the steps to be taken after we move to purely responsive layouts: https://trello.com/c/PMMsJya3/212-clean-up-lp-navigation-post-responsive\r\n\r\nDesign before:\r\n\r\n![image](https://cloud.githubusercontent.com/assets/814861/3825726/96b5e26c-1d57-11e4-85bb-205afec288ab.png)\r\n\r\nDesign after:\r\n\r\n![image](https://cloud.githubusercontent.com/assets/814861/3825715/85116b8a-1d57-11e4-9730-778645dcc512.png)\r\n\r\n![image](https://cloud.githubusercontent.com/assets/814861/3825704/62f0264a-1d57-11e4-8b76-be9312ebe9b8.png)","created_at":"2014-08-06T11:03:35Z","updated_at":"2014-08-06T11:08:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c0f88a73c98426a37cf06847af681277ee44fdb4","assignee":{"login":"remybach","id":708296,"avatar_url":"https://avatars.githubusercontent.com/u/708296?v=2","gravatar_id":"05a5dfd9e66b566bbb32091bb87ad202","url":"https://api.github.com/users/remybach","html_url":"https://github.com/remybach","followers_url":"https://api.github.com/users/remybach/followers","following_url":"https://api.github.com/users/remybach/following{/other_user}","gists_url":"https://api.github.com/users/remybach/gists{/gist_id}","starred_url":"https://api.github.com/users/remybach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/remybach/subscriptions","organizations_url":"https://api.github.com/users/remybach/orgs","repos_url":"https://api.github.com/users/remybach/repos","events_url":"https://api.github.com/users/remybach/events{/privacy}","received_events_url":"https://api.github.com/users/remybach/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/lonelyplanet/rizzo/pulls/868/commits","review_comments_url":"https://api.github.com/repos/lonelyplanet/rizzo/pulls/868/comments","review_comment_url":"https://api.github.com/repos/lonelyplanet/rizzo/pulls/comments/{number}","comments_url":"https://api.github.com/repos/lonelyplanet/rizzo/issues/868/comments","statuses_url":"https://api.github.com/repos/lonelyplanet/rizzo/statuses/41b50dad0d1b6ab136aa6215f2343c77c6ad4710","head":{"label":"lonelyplanet:if-secondary-nav","ref":"if-secondary-nav","sha":"41b50dad0d1b6ab136aa6215f2343c77c6ad4710","user":{"login":"lonelyplanet","id":114767,"avatar_url":"https://avatars.githubusercontent.com/u/114767?v=2","gravatar_id":"e6e810d955e496fb006447e94fbafd5b","url":"https://api.github.com/users/lonelyplanet","html_url":"https://github.com/lonelyplanet","followers_url":"https://api.github.com/users/lonelyplanet/followers","following_url":"https://api.github.com/users/lonelyplanet/following{/other_user}","gists_url":"https://api.github.com/users/lonelyplanet/gists{/gist_id}","starred_url":"https://api.github.com/users/lonelyplanet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lonelyplanet/subscriptions","organizations_url":"https://api.github.com/users/lonelyplanet/orgs","repos_url":"https://api.github.com/users/lonelyplanet/repos","events_url":"https://api.github.com/users/lonelyplanet/events{/privacy}","received_events_url":"https://api.github.com/users/lonelyplanet/received_events","type":"Organization","site_admin":false},"repo":{"id":4184894,"name":"rizzo","full_name":"lonelyplanet/rizzo","owner":{"login":"lonelyplanet","id":114767,"avatar_url":"https://avatars.githubusercontent.com/u/114767?v=2","gravatar_id":"e6e810d955e496fb006447e94fbafd5b","url":"https://api.github.com/users/lonelyplanet","html_url":"https://github.com/lonelyplanet","followers_url":"https://api.github.com/users/lonelyplanet/followers","following_url":"https://api.github.com/users/lonelyplanet/following{/other_user}","gists_url":"https://api.github.com/users/lonelyplanet/gists{/gist_id}","starred_url":"https://api.github.com/users/lonelyplanet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lonelyplanet/subscriptions","organizations_url":"https://api.github.com/users/lonelyplanet/orgs","repos_url":"https://api.github.com/users/lonelyplanet/repos","events_url":"https://api.github.com/users/lonelyplanet/events{/privacy}","received_events_url":"https://api.github.com/users/lonelyplanet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lonelyplanet/rizzo","description":"UI Layer for lonelyplanet.com","fork":false,"url":"https://api.github.com/repos/lonelyplanet/rizzo","forks_url":"https://api.github.com/repos/lonelyplanet/rizzo/forks","keys_url":"https://api.github.com/repos/lonelyplanet/rizzo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lonelyplanet/rizzo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lonelyplanet/rizzo/teams","hooks_url":"https://api.github.com/repos/lonelyplanet/rizzo/hooks","issue_events_url":"https://api.github.com/repos/lonelyplanet/rizzo/issues/events{/number}","events_url":"https://api.github.com/repos/lonelyplanet/rizzo/events","assignees_url":"https://api.github.com/repos/lonelyplanet/rizzo/assignees{/user}","branches_url":"https://api.github.com/repos/lonelyplanet/rizzo/branches{/branch}","tags_url":"https://api.github.com/repos/lonelyplanet/rizzo/tags","blobs_url":"https://api.github.com/repos/lonelyplanet/rizzo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lonelyplanet/rizzo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lonelyplanet/rizzo/git/refs{/sha}","trees_url":"https://api.github.com/repos/lonelyplanet/rizzo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lonelyplanet/rizzo/statuses/{sha}","languages_url":"https://api.github.com/repos/lonelyplanet/rizzo/languages","stargazers_url":"https://api.github.com/repos/lonelyplanet/rizzo/stargazers","contributors_url":"https://api.github.com/repos/lonelyplanet/rizzo/contributors","subscribers_url":"https://api.github.com/repos/lonelyplanet/rizzo/subscribers","subscription_url":"https://api.github.com/repos/lonelyplanet/rizzo/subscription","commits_url":"https://api.github.com/repos/lonelyplanet/rizzo/commits{/sha}","git_commits_url":"https://api.github.com/repos/lonelyplanet/rizzo/git/commits{/sha}","comments_url":"https://api.github.com/repos/lonelyplanet/rizzo/comments{/number}","issue_comment_url":"https://api.github.com/repos/lonelyplanet/rizzo/issues/comments/{number}","contents_url":"https://api.github.com/repos/lonelyplanet/rizzo/contents/{+path}","compare_url":"https://api.github.com/repos/lonelyplanet/rizzo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lonelyplanet/rizzo/merges","archive_url":"https://api.github.com/repos/lonelyplanet/rizzo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lonelyplanet/rizzo/downloads","issues_url":"https://api.github.com/repos/lonelyplanet/rizzo/issues{/number}","pulls_url":"https://api.github.com/repos/lonelyplanet/rizzo/pulls{/number}","milestones_url":"https://api.github.com/repos/lonelyplanet/rizzo/milestones{/number}","notifications_url":"https://api.github.com/repos/lonelyplanet/rizzo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lonelyplanet/rizzo/labels{/name}","releases_url":"https://api.github.com/repos/lonelyplanet/rizzo/releases{/id}","created_at":"2012-04-30T17:06:06Z","updated_at":"2014-08-05T07:54:51Z","pushed_at":"2014-08-06T11:04:10Z","git_url":"git://github.com/lonelyplanet/rizzo.git","ssh_url":"git@github.com:lonelyplanet/rizzo.git","clone_url":"https://github.com/lonelyplanet/rizzo.git","svn_url":"https://github.com/lonelyplanet/rizzo","homepage":"","size":121699,"stargazers_count":188,"watchers_count":188,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":15,"mirror_url":null,"open_issues_count":13,"forks":15,"open_issues":13,"watchers":188,"default_branch":"master"}},"base":{"label":"lonelyplanet:master","ref":"master","sha":"59c39f4f3fb6f4cbac7a36fdeae6b65d3bc07d14","user":{"login":"lonelyplanet","id":114767,"avatar_url":"https://avatars.githubusercontent.com/u/114767?v=2","gravatar_id":"e6e810d955e496fb006447e94fbafd5b","url":"https://api.github.com/users/lonelyplanet","html_url":"https://github.com/lonelyplanet","followers_url":"https://api.github.com/users/lonelyplanet/followers","following_url":"https://api.github.com/users/lonelyplanet/following{/other_user}","gists_url":"https://api.github.com/users/lonelyplanet/gists{/gist_id}","starred_url":"https://api.github.com/users/lonelyplanet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lonelyplanet/subscriptions","organizations_url":"https://api.github.com/users/lonelyplanet/orgs","repos_url":"https://api.github.com/users/lonelyplanet/repos","events_url":"https://api.github.com/users/lonelyplanet/events{/privacy}","received_events_url":"https://api.github.com/users/lonelyplanet/received_events","type":"Organization","site_admin":false},"repo":{"id":4184894,"name":"rizzo","full_name":"lonelyplanet/rizzo","owner":{"login":"lonelyplanet","id":114767,"avatar_url":"https://avatars.githubusercontent.com/u/114767?v=2","gravatar_id":"e6e810d955e496fb006447e94fbafd5b","url":"https://api.github.com/users/lonelyplanet","html_url":"https://github.com/lonelyplanet","followers_url":"https://api.github.com/users/lonelyplanet/followers","following_url":"https://api.github.com/users/lonelyplanet/following{/other_user}","gists_url":"https://api.github.com/users/lonelyplanet/gists{/gist_id}","starred_url":"https://api.github.com/users/lonelyplanet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lonelyplanet/subscriptions","organizations_url":"https://api.github.com/users/lonelyplanet/orgs","repos_url":"https://api.github.com/users/lonelyplanet/repos","events_url":"https://api.github.com/users/lonelyplanet/events{/privacy}","received_events_url":"https://api.github.com/users/lonelyplanet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lonelyplanet/rizzo","description":"UI Layer for lonelyplanet.com","fork":false,"url":"https://api.github.com/repos/lonelyplanet/rizzo","forks_url":"https://api.github.com/repos/lonelyplanet/rizzo/forks","keys_url":"https://api.github.com/repos/lonelyplanet/rizzo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lonelyplanet/rizzo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lonelyplanet/rizzo/teams","hooks_url":"https://api.github.com/repos/lonelyplanet/rizzo/hooks","issue_events_url":"https://api.github.com/repos/lonelyplanet/rizzo/issues/events{/number}","events_url":"https://api.github.com/repos/lonelyplanet/rizzo/events","assignees_url":"https://api.github.com/repos/lonelyplanet/rizzo/assignees{/user}","branches_url":"https://api.github.com/repos/lonelyplanet/rizzo/branches{/branch}","tags_url":"https://api.github.com/repos/lonelyplanet/rizzo/tags","blobs_url":"https://api.github.com/repos/lonelyplanet/rizzo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lonelyplanet/rizzo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lonelyplanet/rizzo/git/refs{/sha}","trees_url":"https://api.github.com/repos/lonelyplanet/rizzo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lonelyplanet/rizzo/statuses/{sha}","languages_url":"https://api.github.com/repos/lonelyplanet/rizzo/languages","stargazers_url":"https://api.github.com/repos/lonelyplanet/rizzo/stargazers","contributors_url":"https://api.github.com/repos/lonelyplanet/rizzo/contributors","subscribers_url":"https://api.github.com/repos/lonelyplanet/rizzo/subscribers","subscription_url":"https://api.github.com/repos/lonelyplanet/rizzo/subscription","commits_url":"https://api.github.com/repos/lonelyplanet/rizzo/commits{/sha}","git_commits_url":"https://api.github.com/repos/lonelyplanet/rizzo/git/commits{/sha}","comments_url":"https://api.github.com/repos/lonelyplanet/rizzo/comments{/number}","issue_comment_url":"https://api.github.com/repos/lonelyplanet/rizzo/issues/comments/{number}","contents_url":"https://api.github.com/repos/lonelyplanet/rizzo/contents/{+path}","compare_url":"https://api.github.com/repos/lonelyplanet/rizzo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lonelyplanet/rizzo/merges","archive_url":"https://api.github.com/repos/lonelyplanet/rizzo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lonelyplanet/rizzo/downloads","issues_url":"https://api.github.com/repos/lonelyplanet/rizzo/issues{/number}","pulls_url":"https://api.github.com/repos/lonelyplanet/rizzo/pulls{/number}","milestones_url":"https://api.github.com/repos/lonelyplanet/rizzo/milestones{/number}","notifications_url":"https://api.github.com/repos/lonelyplanet/rizzo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lonelyplanet/rizzo/labels{/name}","releases_url":"https://api.github.com/repos/lonelyplanet/rizzo/releases{/id}","created_at":"2012-04-30T17:06:06Z","updated_at":"2014-08-05T07:54:51Z","pushed_at":"2014-08-06T11:04:10Z","git_url":"git://github.com/lonelyplanet/rizzo.git","ssh_url":"git@github.com:lonelyplanet/rizzo.git","clone_url":"https://github.com/lonelyplanet/rizzo.git","svn_url":"https://github.com/lonelyplanet/rizzo","homepage":"","size":121699,"stargazers_count":188,"watchers_count":188,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":15,"mirror_url":null,"open_issues_count":13,"forks":15,"open_issues":13,"watchers":188,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lonelyplanet/rizzo/pulls/868"},"html":{"href":"https://github.com/lonelyplanet/rizzo/pull/868"},"issue":{"href":"https://api.github.com/repos/lonelyplanet/rizzo/issues/868"},"comments":{"href":"https://api.github.com/repos/lonelyplanet/rizzo/issues/868/comments"},"review_comments":{"href":"https://api.github.com/repos/lonelyplanet/rizzo/pulls/868/comments"},"review_comment":{"href":"https://api.github.com/repos/lonelyplanet/rizzo/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/lonelyplanet/rizzo/pulls/868/commits"},"statuses":{"href":"https://api.github.com/repos/lonelyplanet/rizzo/statuses/41b50dad0d1b6ab136aa6215f2343c77c6ad4710"}}}}