GitHub PullRequestReviewCommentEvent at 2014-06-27 17:47:13
Repository: spark
Actor: andrewor14
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/14305330","id":14305330,"diff_hunk":"@@ -87,6 +93,29 @@ private[spark] object TaskMetrics {\n   def empty: TaskMetrics = new TaskMetrics\n }\n \n+/**\n+ * :: DeveloperApi ::\n+ * Method by which input data was read.  Network means that the data was read over the network\n+ * from a remote block manager (which may have stored the data on-disk or in-memory).\n+ */\n+@DeveloperApi\n+private[spark] object DataReadMethod extends Enumeration with Serializable {","path":"core/src/main/scala/org/apache/spark/executor/TaskMetrics.scala","position":23,"original_position":23,"commit_id":"bb6ec625671465401628e4d5d3714e192404ebde","original_commit_id":"bb6ec625671465401628e4d5d3714e192404ebde","user":{"login":"andrewor14","id":2133137,"avatar_url":"https://avatars.githubusercontent.com/u/2133137?","gravatar_id":"a05e843641a8e04d55eca499e2d04997","url":"https://api.github.com/users/andrewor14","html_url":"https://github.com/andrewor14","followers_url":"https://api.github.com/users/andrewor14/followers","following_url":"https://api.github.com/users/andrewor14/following{/other_user}","gists_url":"https://api.github.com/users/andrewor14/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewor14/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewor14/subscriptions","organizations_url":"https://api.github.com/users/andrewor14/orgs","repos_url":"https://api.github.com/users/andrewor14/repos","events_url":"https://api.github.com/users/andrewor14/events{/privacy}","received_events_url":"https://api.github.com/users/andrewor14/received_events","type":"User","site_admin":false},"body":"If it's private spark it doesn't have to be developer api","created_at":"2014-06-27T17:47:13Z","updated_at":"2014-06-27T17:47:13Z","html_url":"https://github.com/apache/spark/pull/962#discussion_r14305330","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/962","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/14305330"},"html":{"href":"https://github.com/apache/spark/pull/962#discussion_r14305330"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/962"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/962","id":16684647,"html_url":"https://github.com/apache/spark/pull/962","diff_url":"https://github.com/apache/spark/pull/962.diff","patch_url":"https://github.com/apache/spark/pull/962.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/962","number":962,"state":"open","title":"[SPARK-1683] Track task read metrics.","user":{"login":"kayousterhout","id":1108612,"avatar_url":"https://avatars.githubusercontent.com/u/1108612?","gravatar_id":"e71380daeb1a48ef94312fc7ad9b7fe0","url":"https://api.github.com/users/kayousterhout","html_url":"https://github.com/kayousterhout","followers_url":"https://api.github.com/users/kayousterhout/followers","following_url":"https://api.github.com/users/kayousterhout/following{/other_user}","gists_url":"https://api.github.com/users/kayousterhout/gists{/gist_id}","starred_url":"https://api.github.com/users/kayousterhout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kayousterhout/subscriptions","organizations_url":"https://api.github.com/users/kayousterhout/orgs","repos_url":"https://api.github.com/users/kayousterhout/repos","events_url":"https://api.github.com/users/kayousterhout/events{/privacy}","received_events_url":"https://api.github.com/users/kayousterhout/received_events","type":"User","site_admin":false},"body":"This commit adds a new metric in TaskMetrics to record\r\nthe input data size and displays this information in the UI.\r\n\r\nAn earlier version of this commit also added the read time,\r\nwhich can be useful for diagnosing straggler problems,\r\nbut unfortunately that change introduced a significant performance\r\nregression for jobs that don't do much computation. In order to\r\ntrack read time, we'll need to do sampling.\r\n\r\nThe screenshots below show the UI with the new \"Input\" field,\r\nwhich I added to the stage summary page, the executor summary page,\r\nand the per-stage page.\r\n\r\n![image](https://cloud.githubusercontent.com/assets/1108612/3167930/2627f92a-eb77-11e3-861c-98ea5bb7a1a2.png)\r\n\r\n![image](https://cloud.githubusercontent.com/assets/1108612/3167936/475a889c-eb77-11e3-9706-f11c48751f17.png)\r\n\r\n![image](https://cloud.githubusercontent.com/assets/1108612/3167948/80ebcf12-eb77-11e3-87ed-349fce6a770c.png)","created_at":"2014-06-03T23:37:36Z","updated_at":"2014-06-27T17:47:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6c3d855736ce9924b507483e5173d7684cca129e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/962/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/962/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments/{number}","comments_url":"https://api.github.com/repos/apache/spark/issues/962/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/bb6ec625671465401628e4d5d3714e192404ebde","head":{"label":"kayousterhout:read_metrics","ref":"read_metrics","sha":"bb6ec625671465401628e4d5d3714e192404ebde","user":{"login":"kayousterhout","id":1108612,"avatar_url":"https://avatars.githubusercontent.com/u/1108612?","gravatar_id":"e71380daeb1a48ef94312fc7ad9b7fe0","url":"https://api.github.com/users/kayousterhout","html_url":"https://github.com/kayousterhout","followers_url":"https://api.github.com/users/kayousterhout/followers","following_url":"https://api.github.com/users/kayousterhout/following{/other_user}","gists_url":"https://api.github.com/users/kayousterhout/gists{/gist_id}","starred_url":"https://api.github.com/users/kayousterhout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kayousterhout/subscriptions","organizations_url":"https://api.github.com/users/kayousterhout/orgs","repos_url":"https://api.github.com/users/kayousterhout/repos","events_url":"https://api.github.com/users/kayousterhout/events{/privacy}","received_events_url":"https://api.github.com/users/kayousterhout/received_events","type":"User","site_admin":false},"repo":{"id":17229881,"name":"spark-1","full_name":"kayousterhout/spark-1","owner":{"login":"kayousterhout","id":1108612,"avatar_url":"https://avatars.githubusercontent.com/u/1108612?","gravatar_id":"e71380daeb1a48ef94312fc7ad9b7fe0","url":"https://api.github.com/users/kayousterhout","html_url":"https://github.com/kayousterhout","followers_url":"https://api.github.com/users/kayousterhout/followers","following_url":"https://api.github.com/users/kayousterhout/following{/other_user}","gists_url":"https://api.github.com/users/kayousterhout/gists{/gist_id}","starred_url":"https://api.github.com/users/kayousterhout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kayousterhout/subscriptions","organizations_url":"https://api.github.com/users/kayousterhout/orgs","repos_url":"https://api.github.com/users/kayousterhout/repos","events_url":"https://api.github.com/users/kayousterhout/events{/privacy}","received_events_url":"https://api.github.com/users/kayousterhout/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kayousterhout/spark-1","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/kayousterhout/spark-1","forks_url":"https://api.github.com/repos/kayousterhout/spark-1/forks","keys_url":"https://api.github.com/repos/kayousterhout/spark-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kayousterhout/spark-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kayousterhout/spark-1/teams","hooks_url":"https://api.github.com/repos/kayousterhout/spark-1/hooks","issue_events_url":"https://api.github.com/repos/kayousterhout/spark-1/issues/events{/number}","events_url":"https://api.github.com/repos/kayousterhout/spark-1/events","assignees_url":"https://api.github.com/repos/kayousterhout/spark-1/assignees{/user}","branches_url":"https://api.github.com/repos/kayousterhout/spark-1/branches{/branch}","tags_url":"https://api.github.com/repos/kayousterhout/spark-1/tags","blobs_url":"https://api.github.com/repos/kayousterhout/spark-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kayousterhout/spark-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kayousterhout/spark-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/kayousterhout/spark-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kayousterhout/spark-1/statuses/{sha}","languages_url":"https://api.github.com/repos/kayousterhout/spark-1/languages","stargazers_url":"https://api.github.com/repos/kayousterhout/spark-1/stargazers","contributors_url":"https://api.github.com/repos/kayousterhout/spark-1/contributors","subscribers_url":"https://api.github.com/repos/kayousterhout/spark-1/subscribers","subscription_url":"https://api.github.com/repos/kayousterhout/spark-1/subscription","commits_url":"https://api.github.com/repos/kayousterhout/spark-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/kayousterhout/spark-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/kayousterhout/spark-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/kayousterhout/spark-1/issues/comments/{number}","contents_url":"https://api.github.com/repos/kayousterhout/spark-1/contents/{+path}","compare_url":"https://api.github.com/repos/kayousterhout/spark-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kayousterhout/spark-1/merges","archive_url":"https://api.github.com/repos/kayousterhout/spark-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kayousterhout/spark-1/downloads","issues_url":"https://api.github.com/repos/kayousterhout/spark-1/issues{/number}","pulls_url":"https://api.github.com/repos/kayousterhout/spark-1/pulls{/number}","milestones_url":"https://api.github.com/repos/kayousterhout/spark-1/milestones{/number}","notifications_url":"https://api.github.com/repos/kayousterhout/spark-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kayousterhout/spark-1/labels{/name}","releases_url":"https://api.github.com/repos/kayousterhout/spark-1/releases{/id}","created_at":"2014-02-26T23:42:03Z","updated_at":"2014-06-26T18:10:59Z","pushed_at":"2014-06-27T16:52:29Z","git_url":"git://github.com/kayousterhout/spark-1.git","ssh_url":"git@github.com:kayousterhout/spark-1.git","clone_url":"https://github.com/kayousterhout/spark-1.git","svn_url":"https://github.com/kayousterhout/spark-1","homepage":null,"size":71275,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"18f29b96c7e0948f5f504e522e5aa8a8d1ab163e","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?","gravatar_id":"a676c0bf448fcd49f588249ead719b4c","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?","gravatar_id":"a676c0bf448fcd49f588249ead719b4c","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments/{number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2014-06-27T16:45:18Z","pushed_at":"2014-06-27T05:00:12Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":1876870,"stargazers_count":700,"watchers_count":700,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":713,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":208,"forks":713,"open_issues":208,"watchers":700,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/962"},"html":{"href":"https://github.com/apache/spark/pull/962"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/962"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/962/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/962/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/962/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/bb6ec625671465401628e4d5d3714e192404ebde"}}}}