GitHub PullRequestReviewCommentEvent at 2014-02-22 18:58:51
Repository: ola
Actor: peternewman
Payload: {"comment":{"url":"https://api.github.com/repos/peternewman/ola/pulls/comments/9972446","id":9972446,"diff_hunk":"@@ -150,13 +150,18 @@\n \n /**\n  * Get the default route.\n- * @param[out] default_route a pointer to the default route\n- * @return true on success, false otherwise\n- * @note if it manages to fetch the route information and there isn't a route,\n- * it will return the special wildcard address, which can be tested for with\n- * IsWildcard().\n- */\n-bool DefaultRoute(ola::network::IPV4Address *default_route);\n+ * @param[out] if_index a pointer to an int32 which is updated\n+ *   with the interface to use for the default route.\n+ * @param[out] default_gateway a pointer to an IPV4Address which is updated\n+ *   with the default gateway.\n+ * @return true if a default route was found, false if there was an error\n+ *   fetching the routing table.\n+ * @note if the routing table was read correctly but there was no default\n+ * route, if_index will be 0 and default_gateway will be the wildcard address.","path":"include/ola/network/NetworkUtils.h","position":18,"original_position":18,"commit_id":"47b42cd69dd0586b05f2123240fbf2c7273195af","original_commit_id":"efa433c090f961387b2b869142a5729618bb107c","user":{"login":"peternewman","id":6216436,"avatar_url":"https://gravatar.com/avatar/b2b54ae239edf61b5f27b853cfb7c6d5?d=https%3A%2F%2Fidenticons.github.com%2F3b328d328be65c1f5a93a685627bc771.png&r=x","gravatar_id":"b2b54ae239edf61b5f27b853cfb7c6d5","url":"https://api.github.com/users/peternewman","html_url":"https://github.com/peternewman","followers_url":"https://api.github.com/users/peternewman/followers","following_url":"https://api.github.com/users/peternewman/following{/other_user}","gists_url":"https://api.github.com/users/peternewman/gists{/gist_id}","starred_url":"https://api.github.com/users/peternewman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peternewman/subscriptions","organizations_url":"https://api.github.com/users/peternewman/orgs","repos_url":"https://api.github.com/users/peternewman/repos","events_url":"https://api.github.com/users/peternewman/events{/privacy}","received_events_url":"https://api.github.com/users/peternewman/received_events","type":"User","site_admin":false},"body":"Do these two lines want space indenting like the ones above?","created_at":"2014-02-22T18:58:51Z","updated_at":"2014-02-22T18:58:51Z","html_url":"https://github.com/peternewman/ola/pull/2#discussion_r9972446","pull_request_url":"https://api.github.com/repos/peternewman/ola/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/peternewman/ola/pulls/comments/9972446"},"html":{"href":"https://github.com/peternewman/ola/pull/2#discussion_r9972446"},"pull_request":{"href":"https://api.github.com/repos/peternewman/ola/pulls/2"}}}}