GitHub PullRequestReviewCommentEvent at 2014-12-18 00:47:43
Repository: pushgo
Actor: jrconlin
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-services/pushgo/pulls/comments/22017286","id":22017286,"diff_hunk":"@@ -56,14 +56,24 @@ func (t CaseTestType) String() string {\n \n func decodePing(c *client.Conn, fields client.Fields, statusCode int, errorText string) (client.Packet, error) {\n \tif len(errorText) > 0 {\n-\t\treturn nil, &client.ServerError{\"ping\", c.Origin(), errorText, statusCode}\n+\t\treturn nil, &client.ServerError{\n+\t\t\tMessageType: \"ping\",\n+\t\t\tOrigin:      c.Origin(),\n+\t\t\tMessage:     errorText,\n+\t\t\tStatusCode:  statusCode,\n+\t\t}","path":"src/github.com/mozilla-services/pushgo/simplepush/packet_test.go","position":19,"original_position":19,"commit_id":"5ad1c77cfba39c17615c9701cf4eb29515a105d6","original_commit_id":"5ad1c77cfba39c17615c9701cf4eb29515a105d6","user":{"login":"jrconlin","id":35755,"avatar_url":"https://avatars.githubusercontent.com/u/35755?v=3","gravatar_id":"","url":"https://api.github.com/users/jrconlin","html_url":"https://github.com/jrconlin","followers_url":"https://api.github.com/users/jrconlin/followers","following_url":"https://api.github.com/users/jrconlin/following{/other_user}","gists_url":"https://api.github.com/users/jrconlin/gists{/gist_id}","starred_url":"https://api.github.com/users/jrconlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrconlin/subscriptions","organizations_url":"https://api.github.com/users/jrconlin/orgs","repos_url":"https://api.github.com/users/jrconlin/repos","events_url":"https://api.github.com/users/jrconlin/events{/privacy}","received_events_url":"https://api.github.com/users/jrconlin/received_events","type":"User","site_admin":false},"body":"Vet complains about passing raw values on inits, thus adding the labels. ","created_at":"2014-12-18T00:47:43Z","updated_at":"2014-12-18T00:47:43Z","html_url":"https://github.com/mozilla-services/pushgo/pull/162#discussion_r22017286","pull_request_url":"https://api.github.com/repos/mozilla-services/pushgo/pulls/162","_links":{"self":{"href":"https://api.github.com/repos/mozilla-services/pushgo/pulls/comments/22017286"},"html":{"href":"https://github.com/mozilla-services/pushgo/pull/162#discussion_r22017286"},"pull_request":{"href":"https://api.github.com/repos/mozilla-services/pushgo/pulls/162"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-services/pushgo/pulls/162","id":26268571,"html_url":"https://github.com/mozilla-services/pushgo/pull/162","diff_url":"https://github.com/mozilla-services/pushgo/pull/162.diff","patch_url":"https://github.com/mozilla-services/pushgo/pull/162.patch","issue_url":"https://api.github.com/repos/mozilla-services/pushgo/issues/162","number":162,"state":"open","locked":false,"title":"Added more tests and some vet cleanups","user":{"login":"jrconlin","id":35755,"avatar_url":"https://avatars.githubusercontent.com/u/35755?v=3","gravatar_id":"","url":"https://api.github.com/users/jrconlin","html_url":"https://github.com/jrconlin","followers_url":"https://api.github.com/users/jrconlin/followers","following_url":"https://api.github.com/users/jrconlin/following{/other_user}","gists_url":"https://api.github.com/users/jrconlin/gists{/gist_id}","starred_url":"https://api.github.com/users/jrconlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrconlin/subscriptions","organizations_url":"https://api.github.com/users/jrconlin/orgs","repos_url":"https://api.github.com/users/jrconlin/repos","events_url":"https://api.github.com/users/jrconlin/events{/privacy}","received_events_url":"https://api.github.com/users/jrconlin/received_events","type":"User","site_admin":false},"body":"Increasing test coverage and address some go vet complaints.\r\n\r\n* Note: the gomemc tests require a local memcached instance, otherwise tests are skipped. We may want to adjust this later to use a test memcached instance or mock those.","created_at":"2014-12-18T00:19:38Z","updated_at":"2014-12-18T00:47:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aa89d4c808a4fa5aa29bd19a86774d0f84cc8d06","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-services/pushgo/pulls/162/commits","review_comments_url":"https://api.github.com/repos/mozilla-services/pushgo/pulls/162/comments","review_comment_url":"https://api.github.com/repos/mozilla-services/pushgo/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla-services/pushgo/issues/162/comments","statuses_url":"https://api.github.com/repos/mozilla-services/pushgo/statuses/5ad1c77cfba39c17615c9701cf4eb29515a105d6","head":{"label":"mozilla-services:vet","ref":"vet","sha":"5ad1c77cfba39c17615c9701cf4eb29515a105d6","user":{"login":"mozilla-services","id":1066228,"avatar_url":"https://avatars.githubusercontent.com/u/1066228?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-services","html_url":"https://github.com/mozilla-services","followers_url":"https://api.github.com/users/mozilla-services/followers","following_url":"https://api.github.com/users/mozilla-services/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-services/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-services/subscriptions","organizations_url":"https://api.github.com/users/mozilla-services/orgs","repos_url":"https://api.github.com/users/mozilla-services/repos","events_url":"https://api.github.com/users/mozilla-services/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-services/received_events","type":"Organization","site_admin":false},"repo":{"id":11289838,"name":"pushgo","full_name":"mozilla-services/pushgo","owner":{"login":"mozilla-services","id":1066228,"avatar_url":"https://avatars.githubusercontent.com/u/1066228?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-services","html_url":"https://github.com/mozilla-services","followers_url":"https://api.github.com/users/mozilla-services/followers","following_url":"https://api.github.com/users/mozilla-services/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-services/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-services/subscriptions","organizations_url":"https://api.github.com/users/mozilla-services/orgs","repos_url":"https://api.github.com/users/mozilla-services/repos","events_url":"https://api.github.com/users/mozilla-services/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-services/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-services/pushgo","description":"Go based SimplePush server","fork":true,"url":"https://api.github.com/repos/mozilla-services/pushgo","forks_url":"https://api.github.com/repos/mozilla-services/pushgo/forks","keys_url":"https://api.github.com/repos/mozilla-services/pushgo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-services/pushgo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-services/pushgo/teams","hooks_url":"https://api.github.com/repos/mozilla-services/pushgo/hooks","issue_events_url":"https://api.github.com/repos/mozilla-services/pushgo/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-services/pushgo/events","assignees_url":"https://api.github.com/repos/mozilla-services/pushgo/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-services/pushgo/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-services/pushgo/tags","blobs_url":"https://api.github.com/repos/mozilla-services/pushgo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-services/pushgo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-services/pushgo/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-services/pushgo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-services/pushgo/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-services/pushgo/languages","stargazers_url":"https://api.github.com/repos/mozilla-services/pushgo/stargazers","contributors_url":"https://api.github.com/repos/mozilla-services/pushgo/contributors","subscribers_url":"https://api.github.com/repos/mozilla-services/pushgo/subscribers","subscription_url":"https://api.github.com/repos/mozilla-services/pushgo/subscription","commits_url":"https://api.github.com/repos/mozilla-services/pushgo/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-services/pushgo/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-services/pushgo/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-services/pushgo/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla-services/pushgo/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-services/pushgo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-services/pushgo/merges","archive_url":"https://api.github.com/repos/mozilla-services/pushgo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-services/pushgo/downloads","issues_url":"https://api.github.com/repos/mozilla-services/pushgo/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-services/pushgo/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-services/pushgo/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-services/pushgo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-services/pushgo/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-services/pushgo/releases{/id}","created_at":"2013-07-09T18:06:52Z","updated_at":"2014-12-17T21:58:52Z","pushed_at":"2014-12-18T00:18:47Z","git_url":"git://github.com/mozilla-services/pushgo.git","ssh_url":"git@github.com:mozilla-services/pushgo.git","clone_url":"https://github.com/mozilla-services/pushgo.git","svn_url":"https://github.com/mozilla-services/pushgo","homepage":null,"size":3931,"stargazers_count":15,"watchers_count":15,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":25,"forks":4,"open_issues":25,"watchers":15,"default_branch":"dev"}},"base":{"label":"mozilla-services:dev","ref":"dev","sha":"be2acc268224ac496dae8126c2681017f4165f84","user":{"login":"mozilla-services","id":1066228,"avatar_url":"https://avatars.githubusercontent.com/u/1066228?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-services","html_url":"https://github.com/mozilla-services","followers_url":"https://api.github.com/users/mozilla-services/followers","following_url":"https://api.github.com/users/mozilla-services/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-services/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-services/subscriptions","organizations_url":"https://api.github.com/users/mozilla-services/orgs","repos_url":"https://api.github.com/users/mozilla-services/repos","events_url":"https://api.github.com/users/mozilla-services/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-services/received_events","type":"Organization","site_admin":false},"repo":{"id":11289838,"name":"pushgo","full_name":"mozilla-services/pushgo","owner":{"login":"mozilla-services","id":1066228,"avatar_url":"https://avatars.githubusercontent.com/u/1066228?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-services","html_url":"https://github.com/mozilla-services","followers_url":"https://api.github.com/users/mozilla-services/followers","following_url":"https://api.github.com/users/mozilla-services/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-services/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-services/subscriptions","organizations_url":"https://api.github.com/users/mozilla-services/orgs","repos_url":"https://api.github.com/users/mozilla-services/repos","events_url":"https://api.github.com/users/mozilla-services/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-services/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-services/pushgo","description":"Go based SimplePush server","fork":true,"url":"https://api.github.com/repos/mozilla-services/pushgo","forks_url":"https://api.github.com/repos/mozilla-services/pushgo/forks","keys_url":"https://api.github.com/repos/mozilla-services/pushgo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-services/pushgo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-services/pushgo/teams","hooks_url":"https://api.github.com/repos/mozilla-services/pushgo/hooks","issue_events_url":"https://api.github.com/repos/mozilla-services/pushgo/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-services/pushgo/events","assignees_url":"https://api.github.com/repos/mozilla-services/pushgo/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-services/pushgo/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-services/pushgo/tags","blobs_url":"https://api.github.com/repos/mozilla-services/pushgo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-services/pushgo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-services/pushgo/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-services/pushgo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-services/pushgo/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-services/pushgo/languages","stargazers_url":"https://api.github.com/repos/mozilla-services/pushgo/stargazers","contributors_url":"https://api.github.com/repos/mozilla-services/pushgo/contributors","subscribers_url":"https://api.github.com/repos/mozilla-services/pushgo/subscribers","subscription_url":"https://api.github.com/repos/mozilla-services/pushgo/subscription","commits_url":"https://api.github.com/repos/mozilla-services/pushgo/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-services/pushgo/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-services/pushgo/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-services/pushgo/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla-services/pushgo/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-services/pushgo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-services/pushgo/merges","archive_url":"https://api.github.com/repos/mozilla-services/pushgo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-services/pushgo/downloads","issues_url":"https://api.github.com/repos/mozilla-services/pushgo/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-services/pushgo/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-services/pushgo/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-services/pushgo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-services/pushgo/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-services/pushgo/releases{/id}","created_at":"2013-07-09T18:06:52Z","updated_at":"2014-12-17T21:58:52Z","pushed_at":"2014-12-18T00:18:47Z","git_url":"git://github.com/mozilla-services/pushgo.git","ssh_url":"git@github.com:mozilla-services/pushgo.git","clone_url":"https://github.com/mozilla-services/pushgo.git","svn_url":"https://github.com/mozilla-services/pushgo","homepage":null,"size":3931,"stargazers_count":15,"watchers_count":15,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":25,"forks":4,"open_issues":25,"watchers":15,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-services/pushgo/pulls/162"},"html":{"href":"https://github.com/mozilla-services/pushgo/pull/162"},"issue":{"href":"https://api.github.com/repos/mozilla-services/pushgo/issues/162"},"comments":{"href":"https://api.github.com/repos/mozilla-services/pushgo/issues/162/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-services/pushgo/pulls/162/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-services/pushgo/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla-services/pushgo/pulls/162/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-services/pushgo/statuses/5ad1c77cfba39c17615c9701cf4eb29515a105d6"}}}}