GitHub PullRequestEvent at 2014-04-02 15:07:34
Repository: cedar
Actor: idoru
Payload: {"action":"closed","number":198,"pull_request":{"url":"https://api.github.com/repos/pivotal/cedar/pulls/198","id":14058973,"html_url":"https://github.com/pivotal/cedar/pull/198","diff_url":"https://github.com/pivotal/cedar/pull/198.diff","patch_url":"https://github.com/pivotal/cedar/pull/198.patch","issue_url":"https://api.github.com/repos/pivotal/cedar/issues/198","number":198,"state":"closed","title":"Spies forward -isEqual and -hash to the original object","user":{"login":"pivotal-brian-croom","id":1062518,"avatar_url":"https://avatars.githubusercontent.com/u/1062518?","gravatar_id":"92d36bd6d9b53539fcec282452872710","url":"https://api.github.com/users/pivotal-brian-croom","html_url":"https://github.com/pivotal-brian-croom","followers_url":"https://api.github.com/users/pivotal-brian-croom/followers","following_url":"https://api.github.com/users/pivotal-brian-croom/following{/other_user}","gists_url":"https://api.github.com/users/pivotal-brian-croom/gists{/gist_id}","starred_url":"https://api.github.com/users/pivotal-brian-croom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pivotal-brian-croom/subscriptions","organizations_url":"https://api.github.com/users/pivotal-brian-croom/orgs","repos_url":"https://api.github.com/users/pivotal-brian-croom/repos","events_url":"https://api.github.com/users/pivotal-brian-croom/events{/privacy}","received_events_url":"https://api.github.com/users/pivotal-brian-croom/received_events","type":"User","site_admin":false},"body":"NSProxy overrides `-isEqual` and `-hash`, leading to these methods behaving differently once an object has been spied upon. This code forwards those calls on to the actual object, just as is done for other methods such as `-description`.\r\n\r\nThis fixes #67247100.\r\n\r\nNOTE: Another potential approach to this issue could be to stop using NSProxy as the CDRSpy's base class. E.g. see [here](https://github.com/mikeash/MAFuture/blob/master/MAProxy.m) and discussion [here](https://www.mikeash.com/pyblog/friday-qa-2010-02-26-futures.html)","created_at":"2014-03-27T14:00:42Z","updated_at":"2014-04-02T15:07:33Z","closed_at":"2014-04-02T15:07:33Z","merged_at":"2014-04-02T15:07:33Z","merge_commit_sha":"abbc8bbb736ad966f6aed70f2f80db53b51a0763","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pivotal/cedar/pulls/198/commits","review_comments_url":"https://api.github.com/repos/pivotal/cedar/pulls/198/comments","review_comment_url":"https://api.github.com/repos/pivotal/cedar/pulls/comments/{number}","comments_url":"https://api.github.com/repos/pivotal/cedar/issues/198/comments","statuses_url":"https://api.github.com/repos/pivotal/cedar/statuses/4cb3848ded59cf001dc1e69a96f4b514370fca66","head":{"label":"pivotal-brian-croom:spies-value-equality","ref":"spies-value-equality","sha":"4cb3848ded59cf001dc1e69a96f4b514370fca66","user":{"login":"pivotal-brian-croom","id":1062518,"avatar_url":"https://avatars.githubusercontent.com/u/1062518?","gravatar_id":"92d36bd6d9b53539fcec282452872710","url":"https://api.github.com/users/pivotal-brian-croom","html_url":"https://github.com/pivotal-brian-croom","followers_url":"https://api.github.com/users/pivotal-brian-croom/followers","following_url":"https://api.github.com/users/pivotal-brian-croom/following{/other_user}","gists_url":"https://api.github.com/users/pivotal-brian-croom/gists{/gist_id}","starred_url":"https://api.github.com/users/pivotal-brian-croom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pivotal-brian-croom/subscriptions","organizations_url":"https://api.github.com/users/pivotal-brian-croom/orgs","repos_url":"https://api.github.com/users/pivotal-brian-croom/repos","events_url":"https://api.github.com/users/pivotal-brian-croom/events{/privacy}","received_events_url":"https://api.github.com/users/pivotal-brian-croom/received_events","type":"User","site_admin":false},"repo":{"id":18118188,"name":"cedar","full_name":"pivotal-brian-croom/cedar","owner":{"login":"pivotal-brian-croom","id":1062518,"avatar_url":"https://avatars.githubusercontent.com/u/1062518?","gravatar_id":"92d36bd6d9b53539fcec282452872710","url":"https://api.github.com/users/pivotal-brian-croom","html_url":"https://github.com/pivotal-brian-croom","followers_url":"https://api.github.com/users/pivotal-brian-croom/followers","following_url":"https://api.github.com/users/pivotal-brian-croom/following{/other_user}","gists_url":"https://api.github.com/users/pivotal-brian-croom/gists{/gist_id}","starred_url":"https://api.github.com/users/pivotal-brian-croom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pivotal-brian-croom/subscriptions","organizations_url":"https://api.github.com/users/pivotal-brian-croom/orgs","repos_url":"https://api.github.com/users/pivotal-brian-croom/repos","events_url":"https://api.github.com/users/pivotal-brian-croom/events{/privacy}","received_events_url":"https://api.github.com/users/pivotal-brian-croom/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pivotal-brian-croom/cedar","description":"BDD-style testing using Objective-C","fork":true,"url":"https://api.github.com/repos/pivotal-brian-croom/cedar","forks_url":"https://api.github.com/repos/pivotal-brian-croom/cedar/forks","keys_url":"https://api.github.com/repos/pivotal-brian-croom/cedar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pivotal-brian-croom/cedar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pivotal-brian-croom/cedar/teams","hooks_url":"https://api.github.com/repos/pivotal-brian-croom/cedar/hooks","issue_events_url":"https://api.github.com/repos/pivotal-brian-croom/cedar/issues/events{/number}","events_url":"https://api.github.com/repos/pivotal-brian-croom/cedar/events","assignees_url":"https://api.github.com/repos/pivotal-brian-croom/cedar/assignees{/user}","branches_url":"https://api.github.com/repos/pivotal-brian-croom/cedar/branches{/branch}","tags_url":"https://api.github.com/repos/pivotal-brian-croom/cedar/tags","blobs_url":"https://api.github.com/repos/pivotal-brian-croom/cedar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pivotal-brian-croom/cedar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pivotal-brian-croom/cedar/git/refs{/sha}","trees_url":"https://api.github.com/repos/pivotal-brian-croom/cedar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pivotal-brian-croom/cedar/statuses/{sha}","languages_url":"https://api.github.com/repos/pivotal-brian-croom/cedar/languages","stargazers_url":"https://api.github.com/repos/pivotal-brian-croom/cedar/stargazers","contributors_url":"https://api.github.com/repos/pivotal-brian-croom/cedar/contributors","subscribers_url":"https://api.github.com/repos/pivotal-brian-croom/cedar/subscribers","subscription_url":"https://api.github.com/repos/pivotal-brian-croom/cedar/subscription","commits_url":"https://api.github.com/repos/pivotal-brian-croom/cedar/commits{/sha}","git_commits_url":"https://api.github.com/repos/pivotal-brian-croom/cedar/git/commits{/sha}","comments_url":"https://api.github.com/repos/pivotal-brian-croom/cedar/comments{/number}","issue_comment_url":"https://api.github.com/repos/pivotal-brian-croom/cedar/issues/comments/{number}","contents_url":"https://api.github.com/repos/pivotal-brian-croom/cedar/contents/{+path}","compare_url":"https://api.github.com/repos/pivotal-brian-croom/cedar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pivotal-brian-croom/cedar/merges","archive_url":"https://api.github.com/repos/pivotal-brian-croom/cedar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pivotal-brian-croom/cedar/downloads","issues_url":"https://api.github.com/repos/pivotal-brian-croom/cedar/issues{/number}","pulls_url":"https://api.github.com/repos/pivotal-brian-croom/cedar/pulls{/number}","milestones_url":"https://api.github.com/repos/pivotal-brian-croom/cedar/milestones{/number}","notifications_url":"https://api.github.com/repos/pivotal-brian-croom/cedar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pivotal-brian-croom/cedar/labels{/name}","releases_url":"https://api.github.com/repos/pivotal-brian-croom/cedar/releases{/id}","created_at":"2014-03-25T22:03:41Z","updated_at":"2014-04-02T15:07:33Z","pushed_at":"2014-03-25T23:49:42Z","git_url":"git://github.com/pivotal-brian-croom/cedar.git","ssh_url":"git@github.com:pivotal-brian-croom/cedar.git","clone_url":"https://github.com/pivotal-brian-croom/cedar.git","svn_url":"https://github.com/pivotal-brian-croom/cedar","homepage":"http://groups.google.com/group/cedar-discuss","size":2326,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"pivotal:master","ref":"master","sha":"cdd574e20bb67a95323ed28c86bd68b3c4750009","user":{"login":"pivotal","id":9148,"avatar_url":"https://avatars.githubusercontent.com/u/9148?","gravatar_id":"9f7ca4684008e71a26ff490caa985d8b","url":"https://api.github.com/users/pivotal","html_url":"https://github.com/pivotal","followers_url":"https://api.github.com/users/pivotal/followers","following_url":"https://api.github.com/users/pivotal/following{/other_user}","gists_url":"https://api.github.com/users/pivotal/gists{/gist_id}","starred_url":"https://api.github.com/users/pivotal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pivotal/subscriptions","organizations_url":"https://api.github.com/users/pivotal/orgs","repos_url":"https://api.github.com/users/pivotal/repos","events_url":"https://api.github.com/users/pivotal/events{/privacy}","received_events_url":"https://api.github.com/users/pivotal/received_events","type":"Organization","site_admin":false},"repo":{"id":708684,"name":"cedar","full_name":"pivotal/cedar","owner":{"login":"pivotal","id":9148,"avatar_url":"https://avatars.githubusercontent.com/u/9148?","gravatar_id":"9f7ca4684008e71a26ff490caa985d8b","url":"https://api.github.com/users/pivotal","html_url":"https://github.com/pivotal","followers_url":"https://api.github.com/users/pivotal/followers","following_url":"https://api.github.com/users/pivotal/following{/other_user}","gists_url":"https://api.github.com/users/pivotal/gists{/gist_id}","starred_url":"https://api.github.com/users/pivotal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pivotal/subscriptions","organizations_url":"https://api.github.com/users/pivotal/orgs","repos_url":"https://api.github.com/users/pivotal/repos","events_url":"https://api.github.com/users/pivotal/events{/privacy}","received_events_url":"https://api.github.com/users/pivotal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pivotal/cedar","description":"BDD-style testing using Objective-C","fork":false,"url":"https://api.github.com/repos/pivotal/cedar","forks_url":"https://api.github.com/repos/pivotal/cedar/forks","keys_url":"https://api.github.com/repos/pivotal/cedar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pivotal/cedar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pivotal/cedar/teams","hooks_url":"https://api.github.com/repos/pivotal/cedar/hooks","issue_events_url":"https://api.github.com/repos/pivotal/cedar/issues/events{/number}","events_url":"https://api.github.com/repos/pivotal/cedar/events","assignees_url":"https://api.github.com/repos/pivotal/cedar/assignees{/user}","branches_url":"https://api.github.com/repos/pivotal/cedar/branches{/branch}","tags_url":"https://api.github.com/repos/pivotal/cedar/tags","blobs_url":"https://api.github.com/repos/pivotal/cedar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pivotal/cedar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pivotal/cedar/git/refs{/sha}","trees_url":"https://api.github.com/repos/pivotal/cedar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pivotal/cedar/statuses/{sha}","languages_url":"https://api.github.com/repos/pivotal/cedar/languages","stargazers_url":"https://api.github.com/repos/pivotal/cedar/stargazers","contributors_url":"https://api.github.com/repos/pivotal/cedar/contributors","subscribers_url":"https://api.github.com/repos/pivotal/cedar/subscribers","subscription_url":"https://api.github.com/repos/pivotal/cedar/subscription","commits_url":"https://api.github.com/repos/pivotal/cedar/commits{/sha}","git_commits_url":"https://api.github.com/repos/pivotal/cedar/git/commits{/sha}","comments_url":"https://api.github.com/repos/pivotal/cedar/comments{/number}","issue_comment_url":"https://api.github.com/repos/pivotal/cedar/issues/comments/{number}","contents_url":"https://api.github.com/repos/pivotal/cedar/contents/{+path}","compare_url":"https://api.github.com/repos/pivotal/cedar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pivotal/cedar/merges","archive_url":"https://api.github.com/repos/pivotal/cedar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pivotal/cedar/downloads","issues_url":"https://api.github.com/repos/pivotal/cedar/issues{/number}","pulls_url":"https://api.github.com/repos/pivotal/cedar/pulls{/number}","milestones_url":"https://api.github.com/repos/pivotal/cedar/milestones{/number}","notifications_url":"https://api.github.com/repos/pivotal/cedar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pivotal/cedar/labels{/name}","releases_url":"https://api.github.com/repos/pivotal/cedar/releases{/id}","created_at":"2010-06-08T01:34:14Z","updated_at":"2014-04-02T15:07:33Z","pushed_at":"2014-04-02T15:07:34Z","git_url":"git://github.com/pivotal/cedar.git","ssh_url":"git@github.com:pivotal/cedar.git","clone_url":"https://github.com/pivotal/cedar.git","svn_url":"https://github.com/pivotal/cedar","homepage":"http://groups.google.com/group/cedar-discuss","size":5790,"stargazers_count":756,"watchers_count":756,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":106,"mirror_url":null,"open_issues_count":5,"forks":106,"open_issues":5,"watchers":756,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pivotal/cedar/pulls/198"},"html":{"href":"https://github.com/pivotal/cedar/pull/198"},"issue":{"href":"https://api.github.com/repos/pivotal/cedar/issues/198"},"comments":{"href":"https://api.github.com/repos/pivotal/cedar/issues/198/comments"},"review_comments":{"href":"https://api.github.com/repos/pivotal/cedar/pulls/198/comments"},"review_comment":{"href":"https://api.github.com/repos/pivotal/cedar/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/pivotal/cedar/pulls/198/commits"},"statuses":{"href":"https://api.github.com/repos/pivotal/cedar/statuses/4cb3848ded59cf001dc1e69a96f4b514370fca66"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"idoru","id":237596,"avatar_url":"https://avatars.githubusercontent.com/u/237596?","gravatar_id":"0f15349e478cd6e8688ddcf53ced3ea4","url":"https://api.github.com/users/idoru","html_url":"https://github.com/idoru","followers_url":"https://api.github.com/users/idoru/followers","following_url":"https://api.github.com/users/idoru/following{/other_user}","gists_url":"https://api.github.com/users/idoru/gists{/gist_id}","starred_url":"https://api.github.com/users/idoru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idoru/subscriptions","organizations_url":"https://api.github.com/users/idoru/orgs","repos_url":"https://api.github.com/users/idoru/repos","events_url":"https://api.github.com/users/idoru/events{/privacy}","received_events_url":"https://api.github.com/users/idoru/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":80,"deletions":0,"changed_files":5}}