GitHub PullRequestReviewCommentEvent at 2014-12-01 09:48:15
Repository: firefoxos-loop-client
Actor: mcjimenez
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/pulls/comments/21078699","id":21078699,"diff_hunk":"@@ -54,6 +58,113 @@\n   const MEAN_ELEMENTS = 16;\n   const TIME_INTERVAL_SECONDS = 3;\n   const POLLING_INTERVAL_MILISECONDS = 100;\n+  function dumpRtpStats(stat) {\n+    if (stat.type === 'inboundrtp') {\n+      _rtpInbound.ssrc = stat.ssrc;\n+      if (stat.packetsReceived !== undefined) {\n+        _rtpInbound.packetsReceived = stat.packetsReceived;\n+        if (stat.bytesReceived !== undefined) {\n+          _rtpInbound.bytesReceived = stat.bytesReceived/1024;\n+        }\n+        _rtpInbound.packetsLost = stat.packetsLost;\n+        _rtpInbound.jitter = stat.jitter;\n+        if (stat.mozRtt !== undefined) {\n+          _rtpInbound.mozRtt = stat.mozRtt;\n+        }\n+      } else if (stat.packetsSent !== undefined) {","path":"app/call_screen/js/call_manager.js","position":28,"original_position":28,"commit_id":"c1bdd78805c43837bb9ecc3616e7120f92a2f34a","original_commit_id":"c1bdd78805c43837bb9ecc3616e7120f92a2f34a","user":{"login":"mcjimenez","id":2324031,"avatar_url":"https://avatars.githubusercontent.com/u/2324031?v=3","gravatar_id":"","url":"https://api.github.com/users/mcjimenez","html_url":"https://github.com/mcjimenez","followers_url":"https://api.github.com/users/mcjimenez/followers","following_url":"https://api.github.com/users/mcjimenez/following{/other_user}","gists_url":"https://api.github.com/users/mcjimenez/gists{/gist_id}","starred_url":"https://api.github.com/users/mcjimenez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcjimenez/subscriptions","organizations_url":"https://api.github.com/users/mcjimenez/orgs","repos_url":"https://api.github.com/users/mcjimenez/repos","events_url":"https://api.github.com/users/mcjimenez/events{/privacy}","received_events_url":"https://api.github.com/users/mcjimenez/received_events","type":"User","site_admin":false},"body":"Do we only have sent or received packages? Can't we have both?","created_at":"2014-12-01T09:48:15Z","updated_at":"2014-12-01T09:48:15Z","html_url":"https://github.com/mozilla-b2g/firefoxos-loop-client/pull/340#discussion_r21078699","pull_request_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/pulls/340","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/pulls/comments/21078699"},"html":{"href":"https://github.com/mozilla-b2g/firefoxos-loop-client/pull/340#discussion_r21078699"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/pulls/340"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/pulls/340","id":25192915,"html_url":"https://github.com/mozilla-b2g/firefoxos-loop-client/pull/340","diff_url":"https://github.com/mozilla-b2g/firefoxos-loop-client/pull/340.diff","patch_url":"https://github.com/mozilla-b2g/firefoxos-loop-client/pull/340.patch","issue_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/issues/340","number":340,"state":"open","locked":false,"title":"Bug 1071009 - [Loop] Expose bitrate, frames dropped and frame delay to a...","user":{"login":"opatinowebrtc","id":9033045,"avatar_url":"https://avatars.githubusercontent.com/u/9033045?v=3","gravatar_id":"","url":"https://api.github.com/users/opatinowebrtc","html_url":"https://github.com/opatinowebrtc","followers_url":"https://api.github.com/users/opatinowebrtc/followers","following_url":"https://api.github.com/users/opatinowebrtc/following{/other_user}","gists_url":"https://api.github.com/users/opatinowebrtc/gists{/gist_id}","starred_url":"https://api.github.com/users/opatinowebrtc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opatinowebrtc/subscriptions","organizations_url":"https://api.github.com/users/opatinowebrtc/orgs","repos_url":"https://api.github.com/users/opatinowebrtc/repos","events_url":"https://api.github.com/users/opatinowebrtc/events{/privacy}","received_events_url":"https://api.github.com/users/opatinowebrtc/received_events","type":"User","site_admin":false},"body":"...pplications via TB library.\r\nAdded all information given by tokbox including framerate on encoder/decoder side, frames dropped and bitrate. RTP information also available.\r\nTokbox doesn't provide framedelay information. That info must be retrieved from gecko.","created_at":"2014-11-28T12:08:53Z","updated_at":"2014-12-01T09:48:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6a8d1070409a97c141e3e8938c5bfee92a8a6239","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/pulls/340/commits","review_comments_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/pulls/340/comments","review_comment_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/issues/340/comments","statuses_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/statuses/c1bdd78805c43837bb9ecc3616e7120f92a2f34a","head":{"label":"opatinowebrtc:expose_opentok_stats","ref":"expose_opentok_stats","sha":"c1bdd78805c43837bb9ecc3616e7120f92a2f34a","user":{"login":"opatinowebrtc","id":9033045,"avatar_url":"https://avatars.githubusercontent.com/u/9033045?v=3","gravatar_id":"","url":"https://api.github.com/users/opatinowebrtc","html_url":"https://github.com/opatinowebrtc","followers_url":"https://api.github.com/users/opatinowebrtc/followers","following_url":"https://api.github.com/users/opatinowebrtc/following{/other_user}","gists_url":"https://api.github.com/users/opatinowebrtc/gists{/gist_id}","starred_url":"https://api.github.com/users/opatinowebrtc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opatinowebrtc/subscriptions","organizations_url":"https://api.github.com/users/opatinowebrtc/orgs","repos_url":"https://api.github.com/users/opatinowebrtc/repos","events_url":"https://api.github.com/users/opatinowebrtc/events{/privacy}","received_events_url":"https://api.github.com/users/opatinowebrtc/received_events","type":"User","site_admin":false},"repo":{"id":24837956,"name":"firefoxos-loop-client","full_name":"opatinowebrtc/firefoxos-loop-client","owner":{"login":"opatinowebrtc","id":9033045,"avatar_url":"https://avatars.githubusercontent.com/u/9033045?v=3","gravatar_id":"","url":"https://api.github.com/users/opatinowebrtc","html_url":"https://github.com/opatinowebrtc","followers_url":"https://api.github.com/users/opatinowebrtc/followers","following_url":"https://api.github.com/users/opatinowebrtc/following{/other_user}","gists_url":"https://api.github.com/users/opatinowebrtc/gists{/gist_id}","starred_url":"https://api.github.com/users/opatinowebrtc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opatinowebrtc/subscriptions","organizations_url":"https://api.github.com/users/opatinowebrtc/orgs","repos_url":"https://api.github.com/users/opatinowebrtc/repos","events_url":"https://api.github.com/users/opatinowebrtc/events{/privacy}","received_events_url":"https://api.github.com/users/opatinowebrtc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/opatinowebrtc/firefoxos-loop-client","description":"Firefox OS client for the Loop service","fork":true,"url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client","forks_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/forks","keys_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/teams","hooks_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/hooks","issue_events_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/issues/events{/number}","events_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/events","assignees_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/assignees{/user}","branches_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/branches{/branch}","tags_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/tags","blobs_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/statuses/{sha}","languages_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/languages","stargazers_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/stargazers","contributors_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/contributors","subscribers_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/subscribers","subscription_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/subscription","commits_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/issues/comments/{number}","contents_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/contents/{+path}","compare_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/merges","archive_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/downloads","issues_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/issues{/number}","pulls_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/pulls{/number}","milestones_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/milestones{/number}","notifications_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/labels{/name}","releases_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/releases{/id}","created_at":"2014-10-06T07:59:02Z","updated_at":"2014-11-21T11:05:59Z","pushed_at":"2014-11-28T12:06:24Z","git_url":"git://github.com/opatinowebrtc/firefoxos-loop-client.git","ssh_url":"git@github.com:opatinowebrtc/firefoxos-loop-client.git","clone_url":"https://github.com/opatinowebrtc/firefoxos-loop-client.git","svn_url":"https://github.com/opatinowebrtc/firefoxos-loop-client","homepage":null,"size":10005,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-b2g:master","ref":"master","sha":"fe0b50f39e6d0680ec7a705c5a93bebc1e0ba8ff","user":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"repo":{"id":18225071,"name":"firefoxos-loop-client","full_name":"mozilla-b2g/firefoxos-loop-client","owner":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-b2g/firefoxos-loop-client","description":"Firefox OS client for the Loop service","fork":false,"url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client","forks_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/forks","keys_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/teams","hooks_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/hooks","issue_events_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/events","assignees_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/tags","blobs_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/languages","stargazers_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/stargazers","contributors_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/contributors","subscribers_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/subscribers","subscription_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/subscription","commits_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/merges","archive_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/downloads","issues_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/releases{/id}","created_at":"2014-03-28T20:10:24Z","updated_at":"2014-12-01T09:23:57Z","pushed_at":"2014-12-01T09:23:57Z","git_url":"git://github.com/mozilla-b2g/firefoxos-loop-client.git","ssh_url":"git@github.com:mozilla-b2g/firefoxos-loop-client.git","clone_url":"https://github.com/mozilla-b2g/firefoxos-loop-client.git","svn_url":"https://github.com/mozilla-b2g/firefoxos-loop-client","homepage":null,"size":15540,"stargazers_count":14,"watchers_count":14,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"open_issues_count":27,"forks":37,"open_issues":27,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/pulls/340"},"html":{"href":"https://github.com/mozilla-b2g/firefoxos-loop-client/pull/340"},"issue":{"href":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/issues/340"},"comments":{"href":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/issues/340/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/pulls/340/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/pulls/340/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/statuses/c1bdd78805c43837bb9ecc3616e7120f92a2f34a"}}}}