GitHub PullRequestEvent at 2014-01-27 04:03:01
Repository: OpenCPN
Actor: bdbcat
Payload: {"action":"closed","number":88,"pull_request":{"url":"https://api.github.com/repos/OpenCPN/OpenCPN/pulls/88","id":11447757,"html_url":"https://github.com/OpenCPN/OpenCPN/pull/88","diff_url":"https://github.com/OpenCPN/OpenCPN/pull/88.diff","patch_url":"https://github.com/OpenCPN/OpenCPN/pull/88.patch","issue_url":"https://api.github.com/repos/OpenCPN/OpenCPN/issues/88","number":88,"state":"closed","title":"Disable Nagle Algorithm on outgoing TCP connections","user":{"login":"stripydog","id":6302110,"avatar_url":"https://gravatar.com/avatar/8df148f4c8017aa1735dbfce114ded4a?d=https%3A%2F%2Fidenticons.github.com%2F5d98d9a9d4295225a0f75fe866c69eaa.png&r=x","gravatar_id":"8df148f4c8017aa1735dbfce114ded4a","url":"https://api.github.com/users/stripydog","html_url":"https://github.com/stripydog","followers_url":"https://api.github.com/users/stripydog/followers","following_url":"https://api.github.com/users/stripydog/following{/other_user}","gists_url":"https://api.github.com/users/stripydog/gists{/gist_id}","starred_url":"https://api.github.com/users/stripydog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stripydog/subscriptions","organizations_url":"https://api.github.com/users/stripydog/orgs","repos_url":"https://api.github.com/users/stripydog/repos","events_url":"https://api.github.com/users/stripydog/events{/privacy}","received_events_url":"https://api.github.com/users/stripydog/received_events","type":"User","site_admin":false},"body":"The Nagle algorithm is a method of conserving bandwidth for small network writes by buffering them while there is unacknowledged data and not enough that the algorithm thinks is worth sending yet.  Unfortunately receivers also try to conserve bandwidth by not acknowledging every packet but with small packets only sending one every N ms.  How much this buffering delays transmission can depend on the size of N. Traditionally this was half a second.  Some investigation shows a default of 200ms for windows and freebsd (the latter I can confirm), 50ms for MacOs, 40ms for linux. \r\n\r\nFor an application such as writing out NMEA-0183 over tcp, we want to disable this buffering. That's what this patch does. Testing has shown that where the receiving systems delayed ack timer is less than or equal to the inter-sentence period, there is no observable difference.  Where sentences were available every 50ms, a freebsd (and presumably windows) application was seeing sentences transmitted from opencpn \"bunched up\" into groups of 3 or 4 (the first in the group  being delayed ~200ms).  The patch smoothed out transmission.\r\n\r\nThis has no impact on anything other than OUTBOUND tcp connections.  Do not worry about negative network impact from disabling nagle: Additional overhead is insignificant in this application.\r\n\r\nNOTE!! As with my previous submission I have not been able to compile against windows.  The code should work but a different header file may be needed (WinSock2.h?).\r\n\r\nNote also: I've sacrificed some portability for minimal code addition.  Traditionally you would set the TCP_NODELAY option on the accept()-ed socket.  All modern OSes (incl windows, linux and macos) seem to support inheritance of this option from the listening socket.  I've set it on the listening socket rather than doing it each time we get a connect.\r\n\r\nHappy to answer any questions on this","created_at":"2014-01-13T11:29:50Z","updated_at":"2014-01-27T04:03:00Z","closed_at":"2014-01-27T04:03:00Z","merged_at":"2014-01-27T04:03:00Z","merge_commit_sha":"f82f1928e7bd3136b28cd6d041ac347511561f2d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OpenCPN/OpenCPN/pulls/88/commits","review_comments_url":"https://api.github.com/repos/OpenCPN/OpenCPN/pulls/88/comments","review_comment_url":"/repos/OpenCPN/OpenCPN/pulls/comments/{number}","comments_url":"https://api.github.com/repos/OpenCPN/OpenCPN/issues/88/comments","statuses_url":"https://api.github.com/repos/OpenCPN/OpenCPN/statuses/81fdbac536335ed9d642c3bcf6fc9ffb76a3f616","head":{"label":"stripydog:master","ref":"master","sha":"81fdbac536335ed9d642c3bcf6fc9ffb76a3f616","user":{"login":"stripydog","id":6302110,"avatar_url":"https://gravatar.com/avatar/8df148f4c8017aa1735dbfce114ded4a?d=https%3A%2F%2Fidenticons.github.com%2F5d98d9a9d4295225a0f75fe866c69eaa.png&r=x","gravatar_id":"8df148f4c8017aa1735dbfce114ded4a","url":"https://api.github.com/users/stripydog","html_url":"https://github.com/stripydog","followers_url":"https://api.github.com/users/stripydog/followers","following_url":"https://api.github.com/users/stripydog/following{/other_user}","gists_url":"https://api.github.com/users/stripydog/gists{/gist_id}","starred_url":"https://api.github.com/users/stripydog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stripydog/subscriptions","organizations_url":"https://api.github.com/users/stripydog/orgs","repos_url":"https://api.github.com/users/stripydog/repos","events_url":"https://api.github.com/users/stripydog/events{/privacy}","received_events_url":"https://api.github.com/users/stripydog/received_events","type":"User","site_admin":false},"repo":{"id":15580925,"name":"OpenCPN","full_name":"stripydog/OpenCPN","owner":{"login":"stripydog","id":6302110,"avatar_url":"https://gravatar.com/avatar/8df148f4c8017aa1735dbfce114ded4a?d=https%3A%2F%2Fidenticons.github.com%2F5d98d9a9d4295225a0f75fe866c69eaa.png&r=x","gravatar_id":"8df148f4c8017aa1735dbfce114ded4a","url":"https://api.github.com/users/stripydog","html_url":"https://github.com/stripydog","followers_url":"https://api.github.com/users/stripydog/followers","following_url":"https://api.github.com/users/stripydog/following{/other_user}","gists_url":"https://api.github.com/users/stripydog/gists{/gist_id}","starred_url":"https://api.github.com/users/stripydog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stripydog/subscriptions","organizations_url":"https://api.github.com/users/stripydog/orgs","repos_url":"https://api.github.com/users/stripydog/repos","events_url":"https://api.github.com/users/stripydog/events{/privacy}","received_events_url":"https://api.github.com/users/stripydog/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stripydog/OpenCPN","description":"A concise ChartPlotter/Navigator. A cross-platform ship-borne GUI application supporting * GPS/GPDS Postition Input * BSB Raster Chart Display * S57 Vector ENChart Display * AIS Input Decoding * Waypoint Autopilot Navigation","fork":true,"url":"https://api.github.com/repos/stripydog/OpenCPN","forks_url":"https://api.github.com/repos/stripydog/OpenCPN/forks","keys_url":"https://api.github.com/repos/stripydog/OpenCPN/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stripydog/OpenCPN/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stripydog/OpenCPN/teams","hooks_url":"https://api.github.com/repos/stripydog/OpenCPN/hooks","issue_events_url":"https://api.github.com/repos/stripydog/OpenCPN/issues/events{/number}","events_url":"https://api.github.com/repos/stripydog/OpenCPN/events","assignees_url":"https://api.github.com/repos/stripydog/OpenCPN/assignees{/user}","branches_url":"https://api.github.com/repos/stripydog/OpenCPN/branches{/branch}","tags_url":"https://api.github.com/repos/stripydog/OpenCPN/tags","blobs_url":"https://api.github.com/repos/stripydog/OpenCPN/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stripydog/OpenCPN/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stripydog/OpenCPN/git/refs{/sha}","trees_url":"https://api.github.com/repos/stripydog/OpenCPN/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stripydog/OpenCPN/statuses/{sha}","languages_url":"https://api.github.com/repos/stripydog/OpenCPN/languages","stargazers_url":"https://api.github.com/repos/stripydog/OpenCPN/stargazers","contributors_url":"https://api.github.com/repos/stripydog/OpenCPN/contributors","subscribers_url":"https://api.github.com/repos/stripydog/OpenCPN/subscribers","subscription_url":"https://api.github.com/repos/stripydog/OpenCPN/subscription","commits_url":"https://api.github.com/repos/stripydog/OpenCPN/commits{/sha}","git_commits_url":"https://api.github.com/repos/stripydog/OpenCPN/git/commits{/sha}","comments_url":"https://api.github.com/repos/stripydog/OpenCPN/comments{/number}","issue_comment_url":"https://api.github.com/repos/stripydog/OpenCPN/issues/comments/{number}","contents_url":"https://api.github.com/repos/stripydog/OpenCPN/contents/{+path}","compare_url":"https://api.github.com/repos/stripydog/OpenCPN/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stripydog/OpenCPN/merges","archive_url":"https://api.github.com/repos/stripydog/OpenCPN/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stripydog/OpenCPN/downloads","issues_url":"https://api.github.com/repos/stripydog/OpenCPN/issues{/number}","pulls_url":"https://api.github.com/repos/stripydog/OpenCPN/pulls{/number}","milestones_url":"https://api.github.com/repos/stripydog/OpenCPN/milestones{/number}","notifications_url":"https://api.github.com/repos/stripydog/OpenCPN/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stripydog/OpenCPN/labels{/name}","releases_url":"https://api.github.com/repos/stripydog/OpenCPN/releases{/id}","created_at":"2014-01-02T10:11:01Z","updated_at":"2014-01-27T04:03:00Z","pushed_at":"2014-01-13T10:59:40Z","git_url":"git://github.com/stripydog/OpenCPN.git","ssh_url":"git@github.com:stripydog/OpenCPN.git","clone_url":"https://github.com/stripydog/OpenCPN.git","svn_url":"https://github.com/stripydog/OpenCPN","homepage":"http://sourceforge.net/projects/opencpn/","size":118357,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"OpenCPN:master","ref":"master","sha":"83d5f7dd960d23f34089f505a0dbcd5dd70840a3","user":{"login":"OpenCPN","id":194497,"avatar_url":"https://gravatar.com/avatar/c2c15ee02bbf4a6474bc88c0cbe384c3?d=https%3A%2F%2Fidenticons.github.com%2Fd200f9a76cf225174143c0493344cc21.png&r=x","gravatar_id":"c2c15ee02bbf4a6474bc88c0cbe384c3","url":"https://api.github.com/users/OpenCPN","html_url":"https://github.com/OpenCPN","followers_url":"https://api.github.com/users/OpenCPN/followers","following_url":"https://api.github.com/users/OpenCPN/following{/other_user}","gists_url":"https://api.github.com/users/OpenCPN/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenCPN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenCPN/subscriptions","organizations_url":"https://api.github.com/users/OpenCPN/orgs","repos_url":"https://api.github.com/users/OpenCPN/repos","events_url":"https://api.github.com/users/OpenCPN/events{/privacy}","received_events_url":"https://api.github.com/users/OpenCPN/received_events","type":"User","site_admin":false},"repo":{"id":498850,"name":"OpenCPN","full_name":"OpenCPN/OpenCPN","owner":{"login":"OpenCPN","id":194497,"avatar_url":"https://gravatar.com/avatar/c2c15ee02bbf4a6474bc88c0cbe384c3?d=https%3A%2F%2Fidenticons.github.com%2Fd200f9a76cf225174143c0493344cc21.png&r=x","gravatar_id":"c2c15ee02bbf4a6474bc88c0cbe384c3","url":"https://api.github.com/users/OpenCPN","html_url":"https://github.com/OpenCPN","followers_url":"https://api.github.com/users/OpenCPN/followers","following_url":"https://api.github.com/users/OpenCPN/following{/other_user}","gists_url":"https://api.github.com/users/OpenCPN/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenCPN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenCPN/subscriptions","organizations_url":"https://api.github.com/users/OpenCPN/orgs","repos_url":"https://api.github.com/users/OpenCPN/repos","events_url":"https://api.github.com/users/OpenCPN/events{/privacy}","received_events_url":"https://api.github.com/users/OpenCPN/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/OpenCPN/OpenCPN","description":"A concise ChartPlotter/Navigator. A cross-platform ship-borne GUI application supporting * GPS/GPDS Postition Input * BSB Raster Chart Display * S57 Vector ENChart Display * AIS Input Decoding * Waypoint Autopilot Navigation","fork":false,"url":"https://api.github.com/repos/OpenCPN/OpenCPN","forks_url":"https://api.github.com/repos/OpenCPN/OpenCPN/forks","keys_url":"https://api.github.com/repos/OpenCPN/OpenCPN/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenCPN/OpenCPN/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenCPN/OpenCPN/teams","hooks_url":"https://api.github.com/repos/OpenCPN/OpenCPN/hooks","issue_events_url":"https://api.github.com/repos/OpenCPN/OpenCPN/issues/events{/number}","events_url":"https://api.github.com/repos/OpenCPN/OpenCPN/events","assignees_url":"https://api.github.com/repos/OpenCPN/OpenCPN/assignees{/user}","branches_url":"https://api.github.com/repos/OpenCPN/OpenCPN/branches{/branch}","tags_url":"https://api.github.com/repos/OpenCPN/OpenCPN/tags","blobs_url":"https://api.github.com/repos/OpenCPN/OpenCPN/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenCPN/OpenCPN/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenCPN/OpenCPN/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenCPN/OpenCPN/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenCPN/OpenCPN/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenCPN/OpenCPN/languages","stargazers_url":"https://api.github.com/repos/OpenCPN/OpenCPN/stargazers","contributors_url":"https://api.github.com/repos/OpenCPN/OpenCPN/contributors","subscribers_url":"https://api.github.com/repos/OpenCPN/OpenCPN/subscribers","subscription_url":"https://api.github.com/repos/OpenCPN/OpenCPN/subscription","commits_url":"https://api.github.com/repos/OpenCPN/OpenCPN/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenCPN/OpenCPN/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenCPN/OpenCPN/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenCPN/OpenCPN/issues/comments/{number}","contents_url":"https://api.github.com/repos/OpenCPN/OpenCPN/contents/{+path}","compare_url":"https://api.github.com/repos/OpenCPN/OpenCPN/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenCPN/OpenCPN/merges","archive_url":"https://api.github.com/repos/OpenCPN/OpenCPN/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenCPN/OpenCPN/downloads","issues_url":"https://api.github.com/repos/OpenCPN/OpenCPN/issues{/number}","pulls_url":"https://api.github.com/repos/OpenCPN/OpenCPN/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenCPN/OpenCPN/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenCPN/OpenCPN/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenCPN/OpenCPN/labels{/name}","releases_url":"https://api.github.com/repos/OpenCPN/OpenCPN/releases{/id}","created_at":"2010-02-02T11:55:06Z","updated_at":"2014-01-27T04:03:00Z","pushed_at":"2014-01-27T04:03:00Z","git_url":"git://github.com/OpenCPN/OpenCPN.git","ssh_url":"git@github.com:OpenCPN/OpenCPN.git","clone_url":"https://github.com/OpenCPN/OpenCPN.git","svn_url":"https://github.com/OpenCPN/OpenCPN","homepage":"http://sourceforge.net/projects/opencpn/","size":121218,"stargazers_count":70,"watchers_count":70,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":56,"mirror_url":null,"open_issues_count":4,"forks":56,"open_issues":4,"watchers":70,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenCPN/OpenCPN/pulls/88"},"html":{"href":"https://github.com/OpenCPN/OpenCPN/pull/88"},"issue":{"href":"https://api.github.com/repos/OpenCPN/OpenCPN/issues/88"},"comments":{"href":"https://api.github.com/repos/OpenCPN/OpenCPN/issues/88/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenCPN/OpenCPN/pulls/88/comments"},"commits":{"href":"https://api.github.com/repos/OpenCPN/OpenCPN/pulls/88/commits"},"statuses":{"href":"https://api.github.com/repos/OpenCPN/OpenCPN/statuses/81fdbac536335ed9d642c3bcf6fc9ffb76a3f616"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"bdbcat","id":1015682,"avatar_url":"https://gravatar.com/avatar/7dfd15380265e668d017b3c249d460a4?d=https%3A%2F%2Fidenticons.github.com%2F7be591feaa18d39ed2b37cdc21faf54d.png&r=x","gravatar_id":"7dfd15380265e668d017b3c249d460a4","url":"https://api.github.com/users/bdbcat","html_url":"https://github.com/bdbcat","followers_url":"https://api.github.com/users/bdbcat/followers","following_url":"https://api.github.com/users/bdbcat/following{/other_user}","gists_url":"https://api.github.com/users/bdbcat/gists{/gist_id}","starred_url":"https://api.github.com/users/bdbcat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdbcat/subscriptions","organizations_url":"https://api.github.com/users/bdbcat/orgs","repos_url":"https://api.github.com/users/bdbcat/repos","events_url":"https://api.github.com/users/bdbcat/events{/privacy}","received_events_url":"https://api.github.com/users/bdbcat/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":9,"deletions":0,"changed_files":1}}