GitHub PullRequestReviewCommentEvent at 2014-12-22 21:22:06
Repository: sympy
Actor: skirpichev
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/sympy/sympy/pulls/comments/22191050","id":22191050,"diff_hunk":"@@ -419,6 +419,49 @@ def evalf(self, prec=None, **options):\n     def is_real(self):\n         return fuzzy_and(arg.is_real for arg in self.args)\n \n+    def _eval_is_algebraic(self):\n+        if all(arg.is_algebraic for arg in self.args):\n+            return True\n+        if all(arg.is_algebraic is False for arg in self.args):\n+            return False\n+\n+    def _eval_is_even(self):\n+        if all(arg.is_even for arg in self.args):","path":"sympy/functions/elementary/miscellaneous.py","position":11,"original_position":11,"commit_id":"d80588b651763c00259d098720f4b92dedd00c70","original_commit_id":"d80588b651763c00259d098720f4b92dedd00c70","user":{"login":"skirpichev","id":2155800,"avatar_url":"https://avatars.githubusercontent.com/u/2155800?v=3","gravatar_id":"","url":"https://api.github.com/users/skirpichev","html_url":"https://github.com/skirpichev","followers_url":"https://api.github.com/users/skirpichev/followers","following_url":"https://api.github.com/users/skirpichev/following{/other_user}","gists_url":"https://api.github.com/users/skirpichev/gists{/gist_id}","starred_url":"https://api.github.com/users/skirpichev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skirpichev/subscriptions","organizations_url":"https://api.github.com/users/skirpichev/orgs","repos_url":"https://api.github.com/users/skirpichev/repos","events_url":"https://api.github.com/users/skirpichev/events{/privacy}","received_events_url":"https://api.github.com/users/skirpichev/received_events","type":"User","site_admin":false},"body":"Hmm.  Too many boilerplate code.  You may want to add a private method and\r\ncall this function from assumption helpers.\r\n","created_at":"2014-12-22T21:22:06Z","updated_at":"2014-12-22T21:22:06Z","html_url":"https://github.com/sympy/sympy/pull/8652#discussion_r22191050","pull_request_url":"https://api.github.com/repos/sympy/sympy/pulls/8652","_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments/22191050"},"html":{"href":"https://github.com/sympy/sympy/pull/8652#discussion_r22191050"},"pull_request":{"href":"https://api.github.com/repos/sympy/sympy/pulls/8652"}}},"pull_request":{"url":"https://api.github.com/repos/sympy/sympy/pulls/8652","id":26364805,"html_url":"https://github.com/sympy/sympy/pull/8652","diff_url":"https://github.com/sympy/sympy/pull/8652.diff","patch_url":"https://github.com/sympy/sympy/pull/8652.patch","issue_url":"https://api.github.com/repos/sympy/sympy/issues/8652","number":8652,"state":"open","locked":false,"title":"Settling minmax assumptions + tests","user":{"login":"pelegm","id":3422626,"avatar_url":"https://avatars.githubusercontent.com/u/3422626?v=3","gravatar_id":"","url":"https://api.github.com/users/pelegm","html_url":"https://github.com/pelegm","followers_url":"https://api.github.com/users/pelegm/followers","following_url":"https://api.github.com/users/pelegm/following{/other_user}","gists_url":"https://api.github.com/users/pelegm/gists{/gist_id}","starred_url":"https://api.github.com/users/pelegm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pelegm/subscriptions","organizations_url":"https://api.github.com/users/pelegm/orgs","repos_url":"https://api.github.com/users/pelegm/repos","events_url":"https://api.github.com/users/pelegm/events{/privacy}","received_events_url":"https://api.github.com/users/pelegm/received_events","type":"User","site_admin":false},"body":"I've added some relevant assumption methods for minmax, including tests. It was weird, but I had to add the method `_eval_is_irrational` and `_eval_is_noninteger` - for some reason, there's no proper mixin here, and even if the max was evaluated to be `real=True` and `rational=False`, it didn't conclude that it is `irrational=True` - so I've added it manually.","created_at":"2014-12-19T11:10:33Z","updated_at":"2014-12-22T21:22:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bc3ebd31f22ec784d6ec736c80918f72b9bf923c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sympy/sympy/pulls/8652/commits","review_comments_url":"https://api.github.com/repos/sympy/sympy/pulls/8652/comments","review_comment_url":"https://api.github.com/repos/sympy/sympy/pulls/comments/{number}","comments_url":"https://api.github.com/repos/sympy/sympy/issues/8652/comments","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/d80588b651763c00259d098720f4b92dedd00c70","head":{"label":"pelegm:minmax_assumptions","ref":"minmax_assumptions","sha":"d80588b651763c00259d098720f4b92dedd00c70","user":{"login":"pelegm","id":3422626,"avatar_url":"https://avatars.githubusercontent.com/u/3422626?v=3","gravatar_id":"","url":"https://api.github.com/users/pelegm","html_url":"https://github.com/pelegm","followers_url":"https://api.github.com/users/pelegm/followers","following_url":"https://api.github.com/users/pelegm/following{/other_user}","gists_url":"https://api.github.com/users/pelegm/gists{/gist_id}","starred_url":"https://api.github.com/users/pelegm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pelegm/subscriptions","organizations_url":"https://api.github.com/users/pelegm/orgs","repos_url":"https://api.github.com/users/pelegm/repos","events_url":"https://api.github.com/users/pelegm/events{/privacy}","received_events_url":"https://api.github.com/users/pelegm/received_events","type":"User","site_admin":false},"repo":{"id":24494061,"name":"sympy","full_name":"pelegm/sympy","owner":{"login":"pelegm","id":3422626,"avatar_url":"https://avatars.githubusercontent.com/u/3422626?v=3","gravatar_id":"","url":"https://api.github.com/users/pelegm","html_url":"https://github.com/pelegm","followers_url":"https://api.github.com/users/pelegm/followers","following_url":"https://api.github.com/users/pelegm/following{/other_user}","gists_url":"https://api.github.com/users/pelegm/gists{/gist_id}","starred_url":"https://api.github.com/users/pelegm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pelegm/subscriptions","organizations_url":"https://api.github.com/users/pelegm/orgs","repos_url":"https://api.github.com/users/pelegm/repos","events_url":"https://api.github.com/users/pelegm/events{/privacy}","received_events_url":"https://api.github.com/users/pelegm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pelegm/sympy","description":"A computer algebra system written in pure Python","fork":true,"url":"https://api.github.com/repos/pelegm/sympy","forks_url":"https://api.github.com/repos/pelegm/sympy/forks","keys_url":"https://api.github.com/repos/pelegm/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pelegm/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pelegm/sympy/teams","hooks_url":"https://api.github.com/repos/pelegm/sympy/hooks","issue_events_url":"https://api.github.com/repos/pelegm/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/pelegm/sympy/events","assignees_url":"https://api.github.com/repos/pelegm/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/pelegm/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/pelegm/sympy/tags","blobs_url":"https://api.github.com/repos/pelegm/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pelegm/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pelegm/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/pelegm/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pelegm/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/pelegm/sympy/languages","stargazers_url":"https://api.github.com/repos/pelegm/sympy/stargazers","contributors_url":"https://api.github.com/repos/pelegm/sympy/contributors","subscribers_url":"https://api.github.com/repos/pelegm/sympy/subscribers","subscription_url":"https://api.github.com/repos/pelegm/sympy/subscription","commits_url":"https://api.github.com/repos/pelegm/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/pelegm/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/pelegm/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/pelegm/sympy/issues/comments/{number}","contents_url":"https://api.github.com/repos/pelegm/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/pelegm/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pelegm/sympy/merges","archive_url":"https://api.github.com/repos/pelegm/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pelegm/sympy/downloads","issues_url":"https://api.github.com/repos/pelegm/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/pelegm/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/pelegm/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/pelegm/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pelegm/sympy/labels{/name}","releases_url":"https://api.github.com/repos/pelegm/sympy/releases{/id}","created_at":"2014-09-26T09:31:57Z","updated_at":"2014-12-21T08:31:25Z","pushed_at":"2014-12-21T08:31:21Z","git_url":"git://github.com/pelegm/sympy.git","ssh_url":"git@github.com:pelegm/sympy.git","clone_url":"https://github.com/pelegm/sympy.git","svn_url":"https://github.com/pelegm/sympy","homepage":"http://sympy.org/","size":65305,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sympy:master","ref":"master","sha":"2e4e90b1b0243c85949eb1633f0546466b00829f","user":{"login":"sympy","id":260832,"avatar_url":"https://avatars.githubusercontent.com/u/260832?v=3","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"repo":{"id":640534,"name":"sympy","full_name":"sympy/sympy","owner":{"login":"sympy","id":260832,"avatar_url":"https://avatars.githubusercontent.com/u/260832?v=3","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sympy/sympy","description":"A computer algebra system written in pure Python","fork":false,"url":"https://api.github.com/repos/sympy/sympy","forks_url":"https://api.github.com/repos/sympy/sympy/forks","keys_url":"https://api.github.com/repos/sympy/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sympy/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sympy/sympy/teams","hooks_url":"https://api.github.com/repos/sympy/sympy/hooks","issue_events_url":"https://api.github.com/repos/sympy/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/sympy/sympy/events","assignees_url":"https://api.github.com/repos/sympy/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/sympy/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/sympy/sympy/tags","blobs_url":"https://api.github.com/repos/sympy/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sympy/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sympy/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/sympy/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/sympy/sympy/languages","stargazers_url":"https://api.github.com/repos/sympy/sympy/stargazers","contributors_url":"https://api.github.com/repos/sympy/sympy/contributors","subscribers_url":"https://api.github.com/repos/sympy/sympy/subscribers","subscription_url":"https://api.github.com/repos/sympy/sympy/subscription","commits_url":"https://api.github.com/repos/sympy/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/sympy/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/sympy/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/sympy/sympy/issues/comments/{number}","contents_url":"https://api.github.com/repos/sympy/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/sympy/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sympy/sympy/merges","archive_url":"https://api.github.com/repos/sympy/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sympy/sympy/downloads","issues_url":"https://api.github.com/repos/sympy/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/sympy/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/sympy/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/sympy/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sympy/sympy/labels{/name}","releases_url":"https://api.github.com/repos/sympy/sympy/releases{/id}","created_at":"2010-04-30T20:37:14Z","updated_at":"2014-12-22T16:48:19Z","pushed_at":"2014-12-22T12:55:41Z","git_url":"git://github.com/sympy/sympy.git","ssh_url":"git@github.com:sympy/sympy.git","clone_url":"https://github.com/sympy/sympy.git","svn_url":"https://github.com/sympy/sympy","homepage":"http://sympy.org/","size":134071,"stargazers_count":1833,"watchers_count":1833,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":865,"mirror_url":null,"open_issues_count":1747,"forks":865,"open_issues":1747,"watchers":1833,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/8652"},"html":{"href":"https://github.com/sympy/sympy/pull/8652"},"issue":{"href":"https://api.github.com/repos/sympy/sympy/issues/8652"},"comments":{"href":"https://api.github.com/repos/sympy/sympy/issues/8652/comments"},"review_comments":{"href":"https://api.github.com/repos/sympy/sympy/pulls/8652/comments"},"review_comment":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/sympy/sympy/pulls/8652/commits"},"statuses":{"href":"https://api.github.com/repos/sympy/sympy/statuses/d80588b651763c00259d098720f4b92dedd00c70"}}}}