GitHub PullRequestReviewCommentEvent at 2014-10-22 14:29:30
Repository: wildfly
Actor: bstansberry
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/wildfly/wildfly/pulls/comments/19216730","id":19216730,"diff_hunk":"@@ -42,6 +43,8 @@\n     static final SimpleOperationDefinition JNDI_VIEW = new SimpleOperationDefinitionBuilder(JndiViewOperation.OPERATION_NAME, NamingExtension.getResourceDescriptionResolver(NamingExtension.SUBSYSTEM_NAME))\n             .addAccessConstraint(NamingExtension.JNDI_VIEW_CONSTRAINT)\n             .withFlag(OperationEntry.Flag.RUNTIME_ONLY)\n+            .setReplyType(ModelType.LIST)\n+            .setReplyValueType(ModelType.STRING)","path":"naming/src/main/java/org/jboss/as/naming/subsystem/NamingSubsystemRootResourceDefinition.java","position":13,"original_position":13,"commit_id":"73e0cdcd3566406a5fc845aab2f4fdd57af0ff6a","original_commit_id":"73e0cdcd3566406a5fc845aab2f4fdd57af0ff6a","user":{"login":"bstansberry","id":299242,"avatar_url":"https://avatars.githubusercontent.com/u/299242?v=2","gravatar_id":"","url":"https://api.github.com/users/bstansberry","html_url":"https://github.com/bstansberry","followers_url":"https://api.github.com/users/bstansberry/followers","following_url":"https://api.github.com/users/bstansberry/following{/other_user}","gists_url":"https://api.github.com/users/bstansberry/gists{/gist_id}","starred_url":"https://api.github.com/users/bstansberry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bstansberry/subscriptions","organizations_url":"https://api.github.com/users/bstansberry/orgs","repos_url":"https://api.github.com/users/bstansberry/repos","events_url":"https://api.github.com/users/bstansberry/events{/privacy}","received_events_url":"https://api.github.com/users/bstansberry/received_events","type":"User","site_admin":false},"body":"This isn't an accurate description, but it is, IMO, good enough. It allows reasonable output from the jconsole invocation of this op, which is the immediate goal.\r\n\r\nThe true description would be considerably more complex, and in the end not possible given the current way the management model works. The reply can include a tree of unknown depth (for describing child contexts) and our model description structure will not support such a thing. It's possible we could try to improve what we have here, e.g. to describe one or two levels of the tree more accurately, but I'm fine with just making the improvement Eduardo has done here and spending our energies elsewhere.","created_at":"2014-10-22T14:29:30Z","updated_at":"2014-10-22T14:29:30Z","html_url":"https://github.com/wildfly/wildfly/pull/6857#discussion_r19216730","pull_request_url":"https://api.github.com/repos/wildfly/wildfly/pulls/6857","_links":{"self":{"href":"https://api.github.com/repos/wildfly/wildfly/pulls/comments/19216730"},"html":{"href":"https://github.com/wildfly/wildfly/pull/6857#discussion_r19216730"},"pull_request":{"href":"https://api.github.com/repos/wildfly/wildfly/pulls/6857"}}},"pull_request":{"url":"https://api.github.com/repos/wildfly/wildfly/pulls/6857","id":23160572,"html_url":"https://github.com/wildfly/wildfly/pull/6857","diff_url":"https://github.com/wildfly/wildfly/pull/6857.diff","patch_url":"https://github.com/wildfly/wildfly/pull/6857.patch","issue_url":"https://api.github.com/repos/wildfly/wildfly/issues/6857","number":6857,"state":"open","locked":false,"title":"WFLY-3939: defines jndi view op definition's reply type","user":{"login":"emmartins","id":539768,"avatar_url":"https://avatars.githubusercontent.com/u/539768?v=2","gravatar_id":"","url":"https://api.github.com/users/emmartins","html_url":"https://github.com/emmartins","followers_url":"https://api.github.com/users/emmartins/followers","following_url":"https://api.github.com/users/emmartins/following{/other_user}","gists_url":"https://api.github.com/users/emmartins/gists{/gist_id}","starred_url":"https://api.github.com/users/emmartins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emmartins/subscriptions","organizations_url":"https://api.github.com/users/emmartins/orgs","repos_url":"https://api.github.com/users/emmartins/repos","events_url":"https://api.github.com/users/emmartins/events{/privacy}","received_events_url":"https://api.github.com/users/emmartins/received_events","type":"User","site_admin":false},"body":"Master PR: wildfly/wildfly#6856","created_at":"2014-10-22T14:20:21Z","updated_at":"2014-10-22T14:29:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49e2387ee65b9c30ec9db82ddf8f4778381e0308","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wildfly/wildfly/pulls/6857/commits","review_comments_url":"https://api.github.com/repos/wildfly/wildfly/pulls/6857/comments","review_comment_url":"https://api.github.com/repos/wildfly/wildfly/pulls/comments/{number}","comments_url":"https://api.github.com/repos/wildfly/wildfly/issues/6857/comments","statuses_url":"https://api.github.com/repos/wildfly/wildfly/statuses/73e0cdcd3566406a5fc845aab2f4fdd57af0ff6a","head":{"label":"emmartins:WFLY-3939-8.x","ref":"WFLY-3939-8.x","sha":"73e0cdcd3566406a5fc845aab2f4fdd57af0ff6a","user":{"login":"emmartins","id":539768,"avatar_url":"https://avatars.githubusercontent.com/u/539768?v=2","gravatar_id":"","url":"https://api.github.com/users/emmartins","html_url":"https://github.com/emmartins","followers_url":"https://api.github.com/users/emmartins/followers","following_url":"https://api.github.com/users/emmartins/following{/other_user}","gists_url":"https://api.github.com/users/emmartins/gists{/gist_id}","starred_url":"https://api.github.com/users/emmartins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emmartins/subscriptions","organizations_url":"https://api.github.com/users/emmartins/orgs","repos_url":"https://api.github.com/users/emmartins/repos","events_url":"https://api.github.com/users/emmartins/events{/privacy}","received_events_url":"https://api.github.com/users/emmartins/received_events","type":"User","site_admin":false},"repo":{"id":4619196,"name":"wildfly","full_name":"emmartins/wildfly","owner":{"login":"emmartins","id":539768,"avatar_url":"https://avatars.githubusercontent.com/u/539768?v=2","gravatar_id":"","url":"https://api.github.com/users/emmartins","html_url":"https://github.com/emmartins","followers_url":"https://api.github.com/users/emmartins/followers","following_url":"https://api.github.com/users/emmartins/following{/other_user}","gists_url":"https://api.github.com/users/emmartins/gists{/gist_id}","starred_url":"https://api.github.com/users/emmartins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emmartins/subscriptions","organizations_url":"https://api.github.com/users/emmartins/orgs","repos_url":"https://api.github.com/users/emmartins/repos","events_url":"https://api.github.com/users/emmartins/events{/privacy}","received_events_url":"https://api.github.com/users/emmartins/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/emmartins/wildfly","description":"JBoss Application Server","fork":true,"url":"https://api.github.com/repos/emmartins/wildfly","forks_url":"https://api.github.com/repos/emmartins/wildfly/forks","keys_url":"https://api.github.com/repos/emmartins/wildfly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emmartins/wildfly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emmartins/wildfly/teams","hooks_url":"https://api.github.com/repos/emmartins/wildfly/hooks","issue_events_url":"https://api.github.com/repos/emmartins/wildfly/issues/events{/number}","events_url":"https://api.github.com/repos/emmartins/wildfly/events","assignees_url":"https://api.github.com/repos/emmartins/wildfly/assignees{/user}","branches_url":"https://api.github.com/repos/emmartins/wildfly/branches{/branch}","tags_url":"https://api.github.com/repos/emmartins/wildfly/tags","blobs_url":"https://api.github.com/repos/emmartins/wildfly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emmartins/wildfly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emmartins/wildfly/git/refs{/sha}","trees_url":"https://api.github.com/repos/emmartins/wildfly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emmartins/wildfly/statuses/{sha}","languages_url":"https://api.github.com/repos/emmartins/wildfly/languages","stargazers_url":"https://api.github.com/repos/emmartins/wildfly/stargazers","contributors_url":"https://api.github.com/repos/emmartins/wildfly/contributors","subscribers_url":"https://api.github.com/repos/emmartins/wildfly/subscribers","subscription_url":"https://api.github.com/repos/emmartins/wildfly/subscription","commits_url":"https://api.github.com/repos/emmartins/wildfly/commits{/sha}","git_commits_url":"https://api.github.com/repos/emmartins/wildfly/git/commits{/sha}","comments_url":"https://api.github.com/repos/emmartins/wildfly/comments{/number}","issue_comment_url":"https://api.github.com/repos/emmartins/wildfly/issues/comments/{number}","contents_url":"https://api.github.com/repos/emmartins/wildfly/contents/{+path}","compare_url":"https://api.github.com/repos/emmartins/wildfly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emmartins/wildfly/merges","archive_url":"https://api.github.com/repos/emmartins/wildfly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emmartins/wildfly/downloads","issues_url":"https://api.github.com/repos/emmartins/wildfly/issues{/number}","pulls_url":"https://api.github.com/repos/emmartins/wildfly/pulls{/number}","milestones_url":"https://api.github.com/repos/emmartins/wildfly/milestones{/number}","notifications_url":"https://api.github.com/repos/emmartins/wildfly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emmartins/wildfly/labels{/name}","releases_url":"https://api.github.com/repos/emmartins/wildfly/releases{/id}","created_at":"2012-06-10T23:07:44Z","updated_at":"2014-06-24T21:15:49Z","pushed_at":"2014-10-22T14:18:56Z","git_url":"git://github.com/emmartins/wildfly.git","ssh_url":"git@github.com:emmartins/wildfly.git","clone_url":"https://github.com/emmartins/wildfly.git","svn_url":"https://github.com/emmartins/wildfly","homepage":"","size":131482,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"wildfly:8.x","ref":"8.x","sha":"e12cb01821d3f0727e6e79ad1b10547cef6ec402","user":{"login":"wildfly","id":3066274,"avatar_url":"https://avatars.githubusercontent.com/u/3066274?v=2","gravatar_id":"","url":"https://api.github.com/users/wildfly","html_url":"https://github.com/wildfly","followers_url":"https://api.github.com/users/wildfly/followers","following_url":"https://api.github.com/users/wildfly/following{/other_user}","gists_url":"https://api.github.com/users/wildfly/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly/subscriptions","organizations_url":"https://api.github.com/users/wildfly/orgs","repos_url":"https://api.github.com/users/wildfly/repos","events_url":"https://api.github.com/users/wildfly/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly/received_events","type":"Organization","site_admin":false},"repo":{"id":764708,"name":"wildfly","full_name":"wildfly/wildfly","owner":{"login":"wildfly","id":3066274,"avatar_url":"https://avatars.githubusercontent.com/u/3066274?v=2","gravatar_id":"","url":"https://api.github.com/users/wildfly","html_url":"https://github.com/wildfly","followers_url":"https://api.github.com/users/wildfly/followers","following_url":"https://api.github.com/users/wildfly/following{/other_user}","gists_url":"https://api.github.com/users/wildfly/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly/subscriptions","organizations_url":"https://api.github.com/users/wildfly/orgs","repos_url":"https://api.github.com/users/wildfly/repos","events_url":"https://api.github.com/users/wildfly/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wildfly/wildfly","description":"WildFly Application Server","fork":false,"url":"https://api.github.com/repos/wildfly/wildfly","forks_url":"https://api.github.com/repos/wildfly/wildfly/forks","keys_url":"https://api.github.com/repos/wildfly/wildfly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wildfly/wildfly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wildfly/wildfly/teams","hooks_url":"https://api.github.com/repos/wildfly/wildfly/hooks","issue_events_url":"https://api.github.com/repos/wildfly/wildfly/issues/events{/number}","events_url":"https://api.github.com/repos/wildfly/wildfly/events","assignees_url":"https://api.github.com/repos/wildfly/wildfly/assignees{/user}","branches_url":"https://api.github.com/repos/wildfly/wildfly/branches{/branch}","tags_url":"https://api.github.com/repos/wildfly/wildfly/tags","blobs_url":"https://api.github.com/repos/wildfly/wildfly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wildfly/wildfly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wildfly/wildfly/git/refs{/sha}","trees_url":"https://api.github.com/repos/wildfly/wildfly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wildfly/wildfly/statuses/{sha}","languages_url":"https://api.github.com/repos/wildfly/wildfly/languages","stargazers_url":"https://api.github.com/repos/wildfly/wildfly/stargazers","contributors_url":"https://api.github.com/repos/wildfly/wildfly/contributors","subscribers_url":"https://api.github.com/repos/wildfly/wildfly/subscribers","subscription_url":"https://api.github.com/repos/wildfly/wildfly/subscription","commits_url":"https://api.github.com/repos/wildfly/wildfly/commits{/sha}","git_commits_url":"https://api.github.com/repos/wildfly/wildfly/git/commits{/sha}","comments_url":"https://api.github.com/repos/wildfly/wildfly/comments{/number}","issue_comment_url":"https://api.github.com/repos/wildfly/wildfly/issues/comments/{number}","contents_url":"https://api.github.com/repos/wildfly/wildfly/contents/{+path}","compare_url":"https://api.github.com/repos/wildfly/wildfly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wildfly/wildfly/merges","archive_url":"https://api.github.com/repos/wildfly/wildfly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wildfly/wildfly/downloads","issues_url":"https://api.github.com/repos/wildfly/wildfly/issues{/number}","pulls_url":"https://api.github.com/repos/wildfly/wildfly/pulls{/number}","milestones_url":"https://api.github.com/repos/wildfly/wildfly/milestones{/number}","notifications_url":"https://api.github.com/repos/wildfly/wildfly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wildfly/wildfly/labels{/name}","releases_url":"https://api.github.com/repos/wildfly/wildfly/releases{/id}","created_at":"2010-07-08T20:46:07Z","updated_at":"2014-10-21T18:48:29Z","pushed_at":"2014-10-22T02:31:51Z","git_url":"git://github.com/wildfly/wildfly.git","ssh_url":"git@github.com:wildfly/wildfly.git","clone_url":"https://github.com/wildfly/wildfly.git","svn_url":"https://github.com/wildfly/wildfly","homepage":"http://wildfly.org","size":282385,"stargazers_count":1226,"watchers_count":1226,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1213,"mirror_url":null,"open_issues_count":41,"forks":1213,"open_issues":41,"watchers":1226,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wildfly/wildfly/pulls/6857"},"html":{"href":"https://github.com/wildfly/wildfly/pull/6857"},"issue":{"href":"https://api.github.com/repos/wildfly/wildfly/issues/6857"},"comments":{"href":"https://api.github.com/repos/wildfly/wildfly/issues/6857/comments"},"review_comments":{"href":"https://api.github.com/repos/wildfly/wildfly/pulls/6857/comments"},"review_comment":{"href":"https://api.github.com/repos/wildfly/wildfly/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/wildfly/wildfly/pulls/6857/commits"},"statuses":{"href":"https://api.github.com/repos/wildfly/wildfly/statuses/73e0cdcd3566406a5fc845aab2f4fdd57af0ff6a"}}}}