GitHub PullRequestReviewCommentEvent at 2014-11-25 17:14:42
Repository: Node-SDK
Actor: sh3nan1gans
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/ClearBlade/Node-SDK/pulls/comments/20877969","id":20877969,"diff_hunk":"@@ -1,32 +1,37 @@\n-var ClearBlade = require('../ClearBlade').ClearBlade;\n+var ClearBlade = require('../ClearBlade');\n \n-beforeEach(function(done) {\n-  // Make a spy that returns some fake shit when it gets the anon request here\n-  spyOn(ClearBlade, 'request').and.callFake(function(options, callback) {\n-    callback(null, {user_token: 'fake'});\n-  });\n-  var doneCallback = function() { done(); };\n-  var initOptions = {\n-    URI: 'http://127.0.0.1',\n-    callback: doneCallback,\n-    systemKey: 'fakeSystemKey',\n-    systemSecret: 'fakeSystemSecret'\n-  };\n-  ClearBlade.init(initOptions);\n-});\n+// beforeEach(function(done) {\n+//   // Make a spy that returns some fake shit when it gets the anon request here\n+//   spyOn(ClearBlade, 'request').and.callFake(function(options, callback) {\n+//     callback(null, {user_token: 'fake'});\n+//   });\n+//   var doneCallback = function() { done(); };\n+//   var initOptions = {\n+//     callback: doneCallback,\n+//     systemKey: 'fakeSystemKey',\n+//     systemSecret: 'fakeSystemSecret'\n+//   };\n+//   ClearBlade.init(initOptions);\n+// });\n \n describe('A ClearBlade User request', function() {\n   it('should make a valid request with a valid query using allUsers', function(done) {\n     // TODO: This should be a ClearBlade.parseQuery test more than an allUsers test but\n     // the bug was reported here so I'm doing it here for now.\n-    var userQuery = new ClearBlade.Query({collection: 'fake'});\n+    var userQuery = ClearBlade.Query({collection: 'fake'});","path":"spec/userSpec.js","position":37,"original_position":37,"commit_id":"c2fcd27b25247ddc2fa6e49bd5b5772b51a6fecb","original_commit_id":"c2fcd27b25247ddc2fa6e49bd5b5772b51a6fecb","user":{"login":"sh3nan1gans","id":4808898,"avatar_url":"https://avatars.githubusercontent.com/u/4808898?v=3","gravatar_id":"","url":"https://api.github.com/users/sh3nan1gans","html_url":"https://github.com/sh3nan1gans","followers_url":"https://api.github.com/users/sh3nan1gans/followers","following_url":"https://api.github.com/users/sh3nan1gans/following{/other_user}","gists_url":"https://api.github.com/users/sh3nan1gans/gists{/gist_id}","starred_url":"https://api.github.com/users/sh3nan1gans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sh3nan1gans/subscriptions","organizations_url":"https://api.github.com/users/sh3nan1gans/orgs","repos_url":"https://api.github.com/users/sh3nan1gans/repos","events_url":"https://api.github.com/users/sh3nan1gans/events{/privacy}","received_events_url":"https://api.github.com/users/sh3nan1gans/received_events","type":"User","site_admin":false},"body":"I don't think you need to supply an object for a user query object.","created_at":"2014-11-25T17:14:42Z","updated_at":"2014-11-25T17:14:42Z","html_url":"https://github.com/ClearBlade/Node-SDK/pull/1#discussion_r20877969","pull_request_url":"https://api.github.com/repos/ClearBlade/Node-SDK/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/ClearBlade/Node-SDK/pulls/comments/20877969"},"html":{"href":"https://github.com/ClearBlade/Node-SDK/pull/1#discussion_r20877969"},"pull_request":{"href":"https://api.github.com/repos/ClearBlade/Node-SDK/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/ClearBlade/Node-SDK/pulls/1","id":24727945,"html_url":"https://github.com/ClearBlade/Node-SDK/pull/1","diff_url":"https://github.com/ClearBlade/Node-SDK/pull/1.diff","patch_url":"https://github.com/ClearBlade/Node-SDK/pull/1.patch","issue_url":"https://api.github.com/repos/ClearBlade/Node-SDK/issues/1","number":1,"state":"open","locked":false,"title":"Refactor 11 14","user":{"login":"cwandrews","id":1382553,"avatar_url":"https://avatars.githubusercontent.com/u/1382553?v=3","gravatar_id":"","url":"https://api.github.com/users/cwandrews","html_url":"https://github.com/cwandrews","followers_url":"https://api.github.com/users/cwandrews/followers","following_url":"https://api.github.com/users/cwandrews/following{/other_user}","gists_url":"https://api.github.com/users/cwandrews/gists{/gist_id}","starred_url":"https://api.github.com/users/cwandrews/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwandrews/subscriptions","organizations_url":"https://api.github.com/users/cwandrews/orgs","repos_url":"https://api.github.com/users/cwandrews/repos","events_url":"https://api.github.com/users/cwandrews/events{/privacy}","received_events_url":"https://api.github.com/users/cwandrews/received_events","type":"User","site_admin":false},"body":"This refactor brings regex queries, collection by name and tests that actually test things.","created_at":"2014-11-19T22:43:27Z","updated_at":"2014-11-25T17:14:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4be9eaca86b16be95064214fe227aa7cebf4a12b","assignee":{"login":"sh3nan1gans","id":4808898,"avatar_url":"https://avatars.githubusercontent.com/u/4808898?v=3","gravatar_id":"","url":"https://api.github.com/users/sh3nan1gans","html_url":"https://github.com/sh3nan1gans","followers_url":"https://api.github.com/users/sh3nan1gans/followers","following_url":"https://api.github.com/users/sh3nan1gans/following{/other_user}","gists_url":"https://api.github.com/users/sh3nan1gans/gists{/gist_id}","starred_url":"https://api.github.com/users/sh3nan1gans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sh3nan1gans/subscriptions","organizations_url":"https://api.github.com/users/sh3nan1gans/orgs","repos_url":"https://api.github.com/users/sh3nan1gans/repos","events_url":"https://api.github.com/users/sh3nan1gans/events{/privacy}","received_events_url":"https://api.github.com/users/sh3nan1gans/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/ClearBlade/Node-SDK/pulls/1/commits","review_comments_url":"https://api.github.com/repos/ClearBlade/Node-SDK/pulls/1/comments","review_comment_url":"https://api.github.com/repos/ClearBlade/Node-SDK/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ClearBlade/Node-SDK/issues/1/comments","statuses_url":"https://api.github.com/repos/ClearBlade/Node-SDK/statuses/c2fcd27b25247ddc2fa6e49bd5b5772b51a6fecb","head":{"label":"ClearBlade:refactor-11-14","ref":"refactor-11-14","sha":"c2fcd27b25247ddc2fa6e49bd5b5772b51a6fecb","user":{"login":"ClearBlade","id":2822779,"avatar_url":"https://avatars.githubusercontent.com/u/2822779?v=3","gravatar_id":"","url":"https://api.github.com/users/ClearBlade","html_url":"https://github.com/ClearBlade","followers_url":"https://api.github.com/users/ClearBlade/followers","following_url":"https://api.github.com/users/ClearBlade/following{/other_user}","gists_url":"https://api.github.com/users/ClearBlade/gists{/gist_id}","starred_url":"https://api.github.com/users/ClearBlade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ClearBlade/subscriptions","organizations_url":"https://api.github.com/users/ClearBlade/orgs","repos_url":"https://api.github.com/users/ClearBlade/repos","events_url":"https://api.github.com/users/ClearBlade/events{/privacy}","received_events_url":"https://api.github.com/users/ClearBlade/received_events","type":"Organization","site_admin":false},"repo":{"id":20220607,"name":"Node-SDK","full_name":"ClearBlade/Node-SDK","owner":{"login":"ClearBlade","id":2822779,"avatar_url":"https://avatars.githubusercontent.com/u/2822779?v=3","gravatar_id":"","url":"https://api.github.com/users/ClearBlade","html_url":"https://github.com/ClearBlade","followers_url":"https://api.github.com/users/ClearBlade/followers","following_url":"https://api.github.com/users/ClearBlade/following{/other_user}","gists_url":"https://api.github.com/users/ClearBlade/gists{/gist_id}","starred_url":"https://api.github.com/users/ClearBlade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ClearBlade/subscriptions","organizations_url":"https://api.github.com/users/ClearBlade/orgs","repos_url":"https://api.github.com/users/ClearBlade/repos","events_url":"https://api.github.com/users/ClearBlade/events{/privacy}","received_events_url":"https://api.github.com/users/ClearBlade/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ClearBlade/Node-SDK","description":"Node.JS SDK for ClearBlade","fork":false,"url":"https://api.github.com/repos/ClearBlade/Node-SDK","forks_url":"https://api.github.com/repos/ClearBlade/Node-SDK/forks","keys_url":"https://api.github.com/repos/ClearBlade/Node-SDK/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ClearBlade/Node-SDK/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ClearBlade/Node-SDK/teams","hooks_url":"https://api.github.com/repos/ClearBlade/Node-SDK/hooks","issue_events_url":"https://api.github.com/repos/ClearBlade/Node-SDK/issues/events{/number}","events_url":"https://api.github.com/repos/ClearBlade/Node-SDK/events","assignees_url":"https://api.github.com/repos/ClearBlade/Node-SDK/assignees{/user}","branches_url":"https://api.github.com/repos/ClearBlade/Node-SDK/branches{/branch}","tags_url":"https://api.github.com/repos/ClearBlade/Node-SDK/tags","blobs_url":"https://api.github.com/repos/ClearBlade/Node-SDK/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ClearBlade/Node-SDK/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ClearBlade/Node-SDK/git/refs{/sha}","trees_url":"https://api.github.com/repos/ClearBlade/Node-SDK/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ClearBlade/Node-SDK/statuses/{sha}","languages_url":"https://api.github.com/repos/ClearBlade/Node-SDK/languages","stargazers_url":"https://api.github.com/repos/ClearBlade/Node-SDK/stargazers","contributors_url":"https://api.github.com/repos/ClearBlade/Node-SDK/contributors","subscribers_url":"https://api.github.com/repos/ClearBlade/Node-SDK/subscribers","subscription_url":"https://api.github.com/repos/ClearBlade/Node-SDK/subscription","commits_url":"https://api.github.com/repos/ClearBlade/Node-SDK/commits{/sha}","git_commits_url":"https://api.github.com/repos/ClearBlade/Node-SDK/git/commits{/sha}","comments_url":"https://api.github.com/repos/ClearBlade/Node-SDK/comments{/number}","issue_comment_url":"https://api.github.com/repos/ClearBlade/Node-SDK/issues/comments/{number}","contents_url":"https://api.github.com/repos/ClearBlade/Node-SDK/contents/{+path}","compare_url":"https://api.github.com/repos/ClearBlade/Node-SDK/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ClearBlade/Node-SDK/merges","archive_url":"https://api.github.com/repos/ClearBlade/Node-SDK/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ClearBlade/Node-SDK/downloads","issues_url":"https://api.github.com/repos/ClearBlade/Node-SDK/issues{/number}","pulls_url":"https://api.github.com/repos/ClearBlade/Node-SDK/pulls{/number}","milestones_url":"https://api.github.com/repos/ClearBlade/Node-SDK/milestones{/number}","notifications_url":"https://api.github.com/repos/ClearBlade/Node-SDK/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ClearBlade/Node-SDK/labels{/name}","releases_url":"https://api.github.com/repos/ClearBlade/Node-SDK/releases{/id}","created_at":"2014-05-27T13:18:20Z","updated_at":"2014-08-12T17:00:29Z","pushed_at":"2014-11-19T22:45:54Z","git_url":"git://github.com/ClearBlade/Node-SDK.git","ssh_url":"git@github.com:ClearBlade/Node-SDK.git","clone_url":"https://github.com/ClearBlade/Node-SDK.git","svn_url":"https://github.com/ClearBlade/Node-SDK","homepage":null,"size":340,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"ClearBlade:develop","ref":"develop","sha":"afde2dd0713562d1eaeb62a14cee8e8468e4a5bc","user":{"login":"ClearBlade","id":2822779,"avatar_url":"https://avatars.githubusercontent.com/u/2822779?v=3","gravatar_id":"","url":"https://api.github.com/users/ClearBlade","html_url":"https://github.com/ClearBlade","followers_url":"https://api.github.com/users/ClearBlade/followers","following_url":"https://api.github.com/users/ClearBlade/following{/other_user}","gists_url":"https://api.github.com/users/ClearBlade/gists{/gist_id}","starred_url":"https://api.github.com/users/ClearBlade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ClearBlade/subscriptions","organizations_url":"https://api.github.com/users/ClearBlade/orgs","repos_url":"https://api.github.com/users/ClearBlade/repos","events_url":"https://api.github.com/users/ClearBlade/events{/privacy}","received_events_url":"https://api.github.com/users/ClearBlade/received_events","type":"Organization","site_admin":false},"repo":{"id":20220607,"name":"Node-SDK","full_name":"ClearBlade/Node-SDK","owner":{"login":"ClearBlade","id":2822779,"avatar_url":"https://avatars.githubusercontent.com/u/2822779?v=3","gravatar_id":"","url":"https://api.github.com/users/ClearBlade","html_url":"https://github.com/ClearBlade","followers_url":"https://api.github.com/users/ClearBlade/followers","following_url":"https://api.github.com/users/ClearBlade/following{/other_user}","gists_url":"https://api.github.com/users/ClearBlade/gists{/gist_id}","starred_url":"https://api.github.com/users/ClearBlade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ClearBlade/subscriptions","organizations_url":"https://api.github.com/users/ClearBlade/orgs","repos_url":"https://api.github.com/users/ClearBlade/repos","events_url":"https://api.github.com/users/ClearBlade/events{/privacy}","received_events_url":"https://api.github.com/users/ClearBlade/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ClearBlade/Node-SDK","description":"Node.JS SDK for ClearBlade","fork":false,"url":"https://api.github.com/repos/ClearBlade/Node-SDK","forks_url":"https://api.github.com/repos/ClearBlade/Node-SDK/forks","keys_url":"https://api.github.com/repos/ClearBlade/Node-SDK/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ClearBlade/Node-SDK/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ClearBlade/Node-SDK/teams","hooks_url":"https://api.github.com/repos/ClearBlade/Node-SDK/hooks","issue_events_url":"https://api.github.com/repos/ClearBlade/Node-SDK/issues/events{/number}","events_url":"https://api.github.com/repos/ClearBlade/Node-SDK/events","assignees_url":"https://api.github.com/repos/ClearBlade/Node-SDK/assignees{/user}","branches_url":"https://api.github.com/repos/ClearBlade/Node-SDK/branches{/branch}","tags_url":"https://api.github.com/repos/ClearBlade/Node-SDK/tags","blobs_url":"https://api.github.com/repos/ClearBlade/Node-SDK/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ClearBlade/Node-SDK/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ClearBlade/Node-SDK/git/refs{/sha}","trees_url":"https://api.github.com/repos/ClearBlade/Node-SDK/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ClearBlade/Node-SDK/statuses/{sha}","languages_url":"https://api.github.com/repos/ClearBlade/Node-SDK/languages","stargazers_url":"https://api.github.com/repos/ClearBlade/Node-SDK/stargazers","contributors_url":"https://api.github.com/repos/ClearBlade/Node-SDK/contributors","subscribers_url":"https://api.github.com/repos/ClearBlade/Node-SDK/subscribers","subscription_url":"https://api.github.com/repos/ClearBlade/Node-SDK/subscription","commits_url":"https://api.github.com/repos/ClearBlade/Node-SDK/commits{/sha}","git_commits_url":"https://api.github.com/repos/ClearBlade/Node-SDK/git/commits{/sha}","comments_url":"https://api.github.com/repos/ClearBlade/Node-SDK/comments{/number}","issue_comment_url":"https://api.github.com/repos/ClearBlade/Node-SDK/issues/comments/{number}","contents_url":"https://api.github.com/repos/ClearBlade/Node-SDK/contents/{+path}","compare_url":"https://api.github.com/repos/ClearBlade/Node-SDK/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ClearBlade/Node-SDK/merges","archive_url":"https://api.github.com/repos/ClearBlade/Node-SDK/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ClearBlade/Node-SDK/downloads","issues_url":"https://api.github.com/repos/ClearBlade/Node-SDK/issues{/number}","pulls_url":"https://api.github.com/repos/ClearBlade/Node-SDK/pulls{/number}","milestones_url":"https://api.github.com/repos/ClearBlade/Node-SDK/milestones{/number}","notifications_url":"https://api.github.com/repos/ClearBlade/Node-SDK/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ClearBlade/Node-SDK/labels{/name}","releases_url":"https://api.github.com/repos/ClearBlade/Node-SDK/releases{/id}","created_at":"2014-05-27T13:18:20Z","updated_at":"2014-08-12T17:00:29Z","pushed_at":"2014-11-19T22:45:54Z","git_url":"git://github.com/ClearBlade/Node-SDK.git","ssh_url":"git@github.com:ClearBlade/Node-SDK.git","clone_url":"https://github.com/ClearBlade/Node-SDK.git","svn_url":"https://github.com/ClearBlade/Node-SDK","homepage":null,"size":340,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ClearBlade/Node-SDK/pulls/1"},"html":{"href":"https://github.com/ClearBlade/Node-SDK/pull/1"},"issue":{"href":"https://api.github.com/repos/ClearBlade/Node-SDK/issues/1"},"comments":{"href":"https://api.github.com/repos/ClearBlade/Node-SDK/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/ClearBlade/Node-SDK/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/ClearBlade/Node-SDK/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ClearBlade/Node-SDK/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/ClearBlade/Node-SDK/statuses/c2fcd27b25247ddc2fa6e49bd5b5772b51a6fecb"}}}}