GitHub PullRequestReviewCommentEvent at 2014-07-09 13:07:26
Repository: connect
Actor: jreidinger
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/SUSE/connect/pulls/comments/14708027","id":14708027,"diff_hunk":"@@ -171,13 +171,20 @@ ln -s SUSEConnect.8.gz %{buildroot}%_mandir/man8/SUSEConnect-<%= spec.version %>\n     %{_sbindir}/<%= executable %> <%= executable %> %{_sbindir}/<%= executable %>%{mod_branch} %{mod_weight}\n <% end -%>\n \n-if [ -s /etc/zypp/credentials.d/NCCcredentials ]; then\n-    # setting this to be able to run the script from within a zypper transaction\n-    export ZYPP_READONLY_HACK=true\n-    # TODO implement migration scenario in SUSEConnect and SCC API\n-    # TODO the idea is to call product activate with token=auto\n-    #echo \"Migrating system from NCC to SCC\"\n-    #SUSEConnect --ncc\n+# setting this to be able to run the script from within a zypper transaction\n+# export ZYPP_READONLY_HACK=true\n+if [ -s /etc/zypp/credentials.d/NCCcredentials ] && [ ! -e /etc/zypp/credentials.d/SCCcredentials ]; then\n+    echo \"Imported NCC system credentials to /etc/zypp/credentials.d/SCCcredentials\"\n+    cp /etc/zypp/credentials.d/NCCcredentials /etc/zypp/credentials.d/SCCcredentials\n+fi\n+\n+if [ -s /etc/suseRegister.conf ]; then\n+    reg_server=$(sed -n \"s/^url[ ]*=[ ]\\(.*\\)/\\1/p\" /etc/suseRegister.conf)","path":"package/SUSEConnect.spec.erb","position":19,"original_position":19,"commit_id":"404dfeb9bd8db86fed5e4c6988bb5dee3d01f811","original_commit_id":"404dfeb9bd8db86fed5e4c6988bb5dee3d01f811","user":{"login":"jreidinger","id":478871,"avatar_url":"https://avatars.githubusercontent.com/u/478871?","gravatar_id":"f9a9cf77af20d925b328ee8c95c0068c","url":"https://api.github.com/users/jreidinger","html_url":"https://github.com/jreidinger","followers_url":"https://api.github.com/users/jreidinger/followers","following_url":"https://api.github.com/users/jreidinger/following{/other_user}","gists_url":"https://api.github.com/users/jreidinger/gists{/gist_id}","starred_url":"https://api.github.com/users/jreidinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreidinger/subscriptions","organizations_url":"https://api.github.com/users/jreidinger/orgs","repos_url":"https://api.github.com/users/jreidinger/repos","events_url":"https://api.github.com/users/jreidinger/events{/privacy}","received_events_url":"https://api.github.com/users/jreidinger/received_events","type":"User","site_admin":false},"body":"in fact there can be whitespace before `url`. I also think that it should use `[[:space:]]` to match all possible spaces","created_at":"2014-07-09T13:07:26Z","updated_at":"2014-07-09T13:07:26Z","html_url":"https://github.com/SUSE/connect/pull/134#discussion_r14708027","pull_request_url":"https://api.github.com/repos/SUSE/connect/pulls/134","_links":{"self":{"href":"https://api.github.com/repos/SUSE/connect/pulls/comments/14708027"},"html":{"href":"https://github.com/SUSE/connect/pull/134#discussion_r14708027"},"pull_request":{"href":"https://api.github.com/repos/SUSE/connect/pulls/134"}}},"pull_request":{"url":"https://api.github.com/repos/SUSE/connect/pulls/134","id":18158619,"html_url":"https://github.com/SUSE/connect/pull/134","diff_url":"https://github.com/SUSE/connect/pull/134.diff","patch_url":"https://github.com/SUSE/connect/pull/134.patch","issue_url":"https://api.github.com/repos/SUSE/connect/issues/134","number":134,"state":"open","title":"[Review] Request from 'digitaltom' @ 'SUSE/connect/review_140709_add_migration_of_suseregister_config_in_package_post'","user":{"login":"digitaltom","id":582520,"avatar_url":"https://avatars.githubusercontent.com/u/582520?","gravatar_id":"f3464e559a3ebc79f7d0485889ff6ef6","url":"https://api.github.com/users/digitaltom","html_url":"https://github.com/digitaltom","followers_url":"https://api.github.com/users/digitaltom/followers","following_url":"https://api.github.com/users/digitaltom/following{/other_user}","gists_url":"https://api.github.com/users/digitaltom/gists{/gist_id}","starred_url":"https://api.github.com/users/digitaltom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digitaltom/subscriptions","organizations_url":"https://api.github.com/users/digitaltom/orgs","repos_url":"https://api.github.com/users/digitaltom/repos","events_url":"https://api.github.com/users/digitaltom/events{/privacy}","received_events_url":"https://api.github.com/users/digitaltom/received_events","type":"User","site_admin":false},"body":"Please review the following changes:\n  * 404dfeb Merge branch 'master' of github.com:SUSE/connect\n  * 484fc28 add upgrade of suseregister config on package upgrade","created_at":"2014-07-09T13:00:50Z","updated_at":"2014-07-09T13:07:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"137d6830cc729753cfeca4f2ccb946f3cb180578","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SUSE/connect/pulls/134/commits","review_comments_url":"https://api.github.com/repos/SUSE/connect/pulls/134/comments","review_comment_url":"https://api.github.com/repos/SUSE/connect/pulls/comments/{number}","comments_url":"https://api.github.com/repos/SUSE/connect/issues/134/comments","statuses_url":"https://api.github.com/repos/SUSE/connect/statuses/404dfeb9bd8db86fed5e4c6988bb5dee3d01f811","head":{"label":"SUSE:review_140709_add_migration_of_suseregister_config_in_package_post","ref":"review_140709_add_migration_of_suseregister_config_in_package_post","sha":"404dfeb9bd8db86fed5e4c6988bb5dee3d01f811","user":{"login":"SUSE","id":1067733,"avatar_url":"https://avatars.githubusercontent.com/u/1067733?","gravatar_id":"5a3b77ef77146dde2115a5b03ab61201","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"repo":{"id":16274443,"name":"connect","full_name":"SUSE/connect","owner":{"login":"SUSE","id":1067733,"avatar_url":"https://avatars.githubusercontent.com/u/1067733?","gravatar_id":"5a3b77ef77146dde2115a5b03ab61201","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SUSE/connect","description":"SUSEConnect Client","fork":false,"url":"https://api.github.com/repos/SUSE/connect","forks_url":"https://api.github.com/repos/SUSE/connect/forks","keys_url":"https://api.github.com/repos/SUSE/connect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SUSE/connect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SUSE/connect/teams","hooks_url":"https://api.github.com/repos/SUSE/connect/hooks","issue_events_url":"https://api.github.com/repos/SUSE/connect/issues/events{/number}","events_url":"https://api.github.com/repos/SUSE/connect/events","assignees_url":"https://api.github.com/repos/SUSE/connect/assignees{/user}","branches_url":"https://api.github.com/repos/SUSE/connect/branches{/branch}","tags_url":"https://api.github.com/repos/SUSE/connect/tags","blobs_url":"https://api.github.com/repos/SUSE/connect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SUSE/connect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SUSE/connect/git/refs{/sha}","trees_url":"https://api.github.com/repos/SUSE/connect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SUSE/connect/statuses/{sha}","languages_url":"https://api.github.com/repos/SUSE/connect/languages","stargazers_url":"https://api.github.com/repos/SUSE/connect/stargazers","contributors_url":"https://api.github.com/repos/SUSE/connect/contributors","subscribers_url":"https://api.github.com/repos/SUSE/connect/subscribers","subscription_url":"https://api.github.com/repos/SUSE/connect/subscription","commits_url":"https://api.github.com/repos/SUSE/connect/commits{/sha}","git_commits_url":"https://api.github.com/repos/SUSE/connect/git/commits{/sha}","comments_url":"https://api.github.com/repos/SUSE/connect/comments{/number}","issue_comment_url":"https://api.github.com/repos/SUSE/connect/issues/comments/{number}","contents_url":"https://api.github.com/repos/SUSE/connect/contents/{+path}","compare_url":"https://api.github.com/repos/SUSE/connect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SUSE/connect/merges","archive_url":"https://api.github.com/repos/SUSE/connect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SUSE/connect/downloads","issues_url":"https://api.github.com/repos/SUSE/connect/issues{/number}","pulls_url":"https://api.github.com/repos/SUSE/connect/pulls{/number}","milestones_url":"https://api.github.com/repos/SUSE/connect/milestones{/number}","notifications_url":"https://api.github.com/repos/SUSE/connect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SUSE/connect/labels{/name}","releases_url":"https://api.github.com/repos/SUSE/connect/releases{/id}","created_at":"2014-01-27T09:21:26Z","updated_at":"2014-06-26T11:03:24Z","pushed_at":"2014-07-09T13:00:49Z","git_url":"git://github.com/SUSE/connect.git","ssh_url":"git@github.com:SUSE/connect.git","clone_url":"https://github.com/SUSE/connect.git","svn_url":"https://github.com/SUSE/connect","homepage":"https://scc.suse.com","size":8371,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":4,"mirror_url":null,"open_issues_count":6,"forks":4,"open_issues":6,"watchers":3,"default_branch":"master"}},"base":{"label":"SUSE:master","ref":"master","sha":"32f2e38e3af1832f310395025f4f682efd1c1c6a","user":{"login":"SUSE","id":1067733,"avatar_url":"https://avatars.githubusercontent.com/u/1067733?","gravatar_id":"5a3b77ef77146dde2115a5b03ab61201","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"repo":{"id":16274443,"name":"connect","full_name":"SUSE/connect","owner":{"login":"SUSE","id":1067733,"avatar_url":"https://avatars.githubusercontent.com/u/1067733?","gravatar_id":"5a3b77ef77146dde2115a5b03ab61201","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SUSE/connect","description":"SUSEConnect Client","fork":false,"url":"https://api.github.com/repos/SUSE/connect","forks_url":"https://api.github.com/repos/SUSE/connect/forks","keys_url":"https://api.github.com/repos/SUSE/connect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SUSE/connect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SUSE/connect/teams","hooks_url":"https://api.github.com/repos/SUSE/connect/hooks","issue_events_url":"https://api.github.com/repos/SUSE/connect/issues/events{/number}","events_url":"https://api.github.com/repos/SUSE/connect/events","assignees_url":"https://api.github.com/repos/SUSE/connect/assignees{/user}","branches_url":"https://api.github.com/repos/SUSE/connect/branches{/branch}","tags_url":"https://api.github.com/repos/SUSE/connect/tags","blobs_url":"https://api.github.com/repos/SUSE/connect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SUSE/connect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SUSE/connect/git/refs{/sha}","trees_url":"https://api.github.com/repos/SUSE/connect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SUSE/connect/statuses/{sha}","languages_url":"https://api.github.com/repos/SUSE/connect/languages","stargazers_url":"https://api.github.com/repos/SUSE/connect/stargazers","contributors_url":"https://api.github.com/repos/SUSE/connect/contributors","subscribers_url":"https://api.github.com/repos/SUSE/connect/subscribers","subscription_url":"https://api.github.com/repos/SUSE/connect/subscription","commits_url":"https://api.github.com/repos/SUSE/connect/commits{/sha}","git_commits_url":"https://api.github.com/repos/SUSE/connect/git/commits{/sha}","comments_url":"https://api.github.com/repos/SUSE/connect/comments{/number}","issue_comment_url":"https://api.github.com/repos/SUSE/connect/issues/comments/{number}","contents_url":"https://api.github.com/repos/SUSE/connect/contents/{+path}","compare_url":"https://api.github.com/repos/SUSE/connect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SUSE/connect/merges","archive_url":"https://api.github.com/repos/SUSE/connect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SUSE/connect/downloads","issues_url":"https://api.github.com/repos/SUSE/connect/issues{/number}","pulls_url":"https://api.github.com/repos/SUSE/connect/pulls{/number}","milestones_url":"https://api.github.com/repos/SUSE/connect/milestones{/number}","notifications_url":"https://api.github.com/repos/SUSE/connect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SUSE/connect/labels{/name}","releases_url":"https://api.github.com/repos/SUSE/connect/releases{/id}","created_at":"2014-01-27T09:21:26Z","updated_at":"2014-06-26T11:03:24Z","pushed_at":"2014-07-09T13:00:49Z","git_url":"git://github.com/SUSE/connect.git","ssh_url":"git@github.com:SUSE/connect.git","clone_url":"https://github.com/SUSE/connect.git","svn_url":"https://github.com/SUSE/connect","homepage":"https://scc.suse.com","size":8371,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":4,"mirror_url":null,"open_issues_count":6,"forks":4,"open_issues":6,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SUSE/connect/pulls/134"},"html":{"href":"https://github.com/SUSE/connect/pull/134"},"issue":{"href":"https://api.github.com/repos/SUSE/connect/issues/134"},"comments":{"href":"https://api.github.com/repos/SUSE/connect/issues/134/comments"},"review_comments":{"href":"https://api.github.com/repos/SUSE/connect/pulls/134/comments"},"review_comment":{"href":"https://api.github.com/repos/SUSE/connect/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/SUSE/connect/pulls/134/commits"},"statuses":{"href":"https://api.github.com/repos/SUSE/connect/statuses/404dfeb9bd8db86fed5e4c6988bb5dee3d01f811"}}}}