GitHub PullRequestReviewCommentEvent at 2014-07-03 18:07:32
Repository: juju-gui
Actor: jaycee
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/juju/juju-gui/pulls/comments/14529038","id":14529038,"diff_hunk":"@@ -548,32 +568,6 @@ YUI.add('subapp-browser', function(Y) {\n     },\n \n     /**\n-      Renders the inspector into the sidebar container.\n-      Route callback.\n-\n-      @method inspector\n-    */\n-    inspector: function(req, res, next) {\n-      // We need the sidebar rendered so that we can show the inspector in it.\n-      this.sidebar(req, null, function() {});\n-      var clientId = req.params.id,\n-          model;\n-      this.get('db').services.some(function(service) {\n-        if (service.get('clientId') === clientId) {\n-          model = service;\n-          return true;\n-        }\n-      });\n-      // If there is no config set then it's a ghost service model and not\n-      // a deployed service yet.\n-      if (!model.get('config')) {\n-        this.createGhostInspector(model);\n-      } else {\n-        this.createServiceInspector(model);\n-      }\n-    },\n-\n-    /**","path":"app/subapps/browser/browser.js","position":86,"original_position":86,"commit_id":"17cd77c564e6b3e1cbfe50379fac3e9275e9c23f","original_commit_id":"17cd77c564e6b3e1cbfe50379fac3e9275e9c23f","user":{"login":"jaycee","id":26728,"avatar_url":"https://avatars.githubusercontent.com/u/26728?","gravatar_id":"556f338e5fb1bbf6a502cce979609942","url":"https://api.github.com/users/jaycee","html_url":"https://github.com/jaycee","followers_url":"https://api.github.com/users/jaycee/followers","following_url":"https://api.github.com/users/jaycee/following{/other_user}","gists_url":"https://api.github.com/users/jaycee/gists{/gist_id}","starred_url":"https://api.github.com/users/jaycee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaycee/subscriptions","organizations_url":"https://api.github.com/users/jaycee/orgs","repos_url":"https://api.github.com/users/jaycee/repos","events_url":"https://api.github.com/users/jaycee/events{/privacy}","received_events_url":"https://api.github.com/users/jaycee/received_events","type":"User","site_admin":false},"body":"This was just driveby.","created_at":"2014-07-03T18:07:32Z","updated_at":"2014-07-03T18:07:32Z","html_url":"https://github.com/juju/juju-gui/pull/422#discussion_r14529038","pull_request_url":"https://api.github.com/repos/juju/juju-gui/pulls/422","_links":{"self":{"href":"https://api.github.com/repos/juju/juju-gui/pulls/comments/14529038"},"html":{"href":"https://github.com/juju/juju-gui/pull/422#discussion_r14529038"},"pull_request":{"href":"https://api.github.com/repos/juju/juju-gui/pulls/422"}}},"pull_request":{"url":"https://api.github.com/repos/juju/juju-gui/pulls/422","id":17959392,"html_url":"https://github.com/juju/juju-gui/pull/422","diff_url":"https://github.com/juju/juju-gui/pull/422.diff","patch_url":"https://github.com/juju/juju-gui/pull/422.patch","issue_url":"https://api.github.com/repos/juju/juju-gui/issues/422","number":422,"state":"open","title":"Charm details breakout panel is a dispatched view.","user":{"login":"jaycee","id":26728,"avatar_url":"https://avatars.githubusercontent.com/u/26728?","gravatar_id":"556f338e5fb1bbf6a502cce979609942","url":"https://api.github.com/users/jaycee","html_url":"https://github.com/jaycee","followers_url":"https://api.github.com/users/jaycee/followers","following_url":"https://api.github.com/users/jaycee/following{/other_user}","gists_url":"https://api.github.com/users/jaycee/gists{/gist_id}","starred_url":"https://api.github.com/users/jaycee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaycee/subscriptions","organizations_url":"https://api.github.com/users/jaycee/orgs","repos_url":"https://api.github.com/users/jaycee/repos","events_url":"https://api.github.com/users/jaycee/events{/privacy}","received_events_url":"https://api.github.com/users/jaycee/received_events","type":"User","site_admin":false},"body":"* renderUI can open the charmDetails viewlet.\n* metadata.charm is used by state to signify if the details should be open.\n* the service inspector can be dispatched to without creating a new inspector,\n  so details can be viewed without resetting the inspector's state.","created_at":"2014-07-03T18:04:46Z","updated_at":"2014-07-03T18:07:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7bcce5a690b9766130d7acc10c8be98af7ab8c07","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/juju/juju-gui/pulls/422/commits","review_comments_url":"https://api.github.com/repos/juju/juju-gui/pulls/422/comments","review_comment_url":"https://api.github.com/repos/juju/juju-gui/pulls/comments/{number}","comments_url":"https://api.github.com/repos/juju/juju-gui/issues/422/comments","statuses_url":"https://api.github.com/repos/juju/juju-gui/statuses/17cd77c564e6b3e1cbfe50379fac3e9275e9c23f","head":{"label":"jaycee:dispatch-details","ref":"dispatch-details","sha":"17cd77c564e6b3e1cbfe50379fac3e9275e9c23f","user":{"login":"jaycee","id":26728,"avatar_url":"https://avatars.githubusercontent.com/u/26728?","gravatar_id":"556f338e5fb1bbf6a502cce979609942","url":"https://api.github.com/users/jaycee","html_url":"https://github.com/jaycee","followers_url":"https://api.github.com/users/jaycee/followers","following_url":"https://api.github.com/users/jaycee/following{/other_user}","gists_url":"https://api.github.com/users/jaycee/gists{/gist_id}","starred_url":"https://api.github.com/users/jaycee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaycee/subscriptions","organizations_url":"https://api.github.com/users/jaycee/orgs","repos_url":"https://api.github.com/users/jaycee/repos","events_url":"https://api.github.com/users/jaycee/events{/privacy}","received_events_url":"https://api.github.com/users/jaycee/received_events","type":"User","site_admin":false},"repo":{"id":20962584,"name":"juju-gui","full_name":"jaycee/juju-gui","owner":{"login":"jaycee","id":26728,"avatar_url":"https://avatars.githubusercontent.com/u/26728?","gravatar_id":"556f338e5fb1bbf6a502cce979609942","url":"https://api.github.com/users/jaycee","html_url":"https://github.com/jaycee","followers_url":"https://api.github.com/users/jaycee/followers","following_url":"https://api.github.com/users/jaycee/following{/other_user}","gists_url":"https://api.github.com/users/jaycee/gists{/gist_id}","starred_url":"https://api.github.com/users/jaycee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaycee/subscriptions","organizations_url":"https://api.github.com/users/jaycee/orgs","repos_url":"https://api.github.com/users/jaycee/repos","events_url":"https://api.github.com/users/jaycee/events{/privacy}","received_events_url":"https://api.github.com/users/jaycee/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jaycee/juju-gui","description":"Juju-GUI is a web-based GUI for Juju <https://juju.ubuntu.com/>.","fork":true,"url":"https://api.github.com/repos/jaycee/juju-gui","forks_url":"https://api.github.com/repos/jaycee/juju-gui/forks","keys_url":"https://api.github.com/repos/jaycee/juju-gui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jaycee/juju-gui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jaycee/juju-gui/teams","hooks_url":"https://api.github.com/repos/jaycee/juju-gui/hooks","issue_events_url":"https://api.github.com/repos/jaycee/juju-gui/issues/events{/number}","events_url":"https://api.github.com/repos/jaycee/juju-gui/events","assignees_url":"https://api.github.com/repos/jaycee/juju-gui/assignees{/user}","branches_url":"https://api.github.com/repos/jaycee/juju-gui/branches{/branch}","tags_url":"https://api.github.com/repos/jaycee/juju-gui/tags","blobs_url":"https://api.github.com/repos/jaycee/juju-gui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jaycee/juju-gui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jaycee/juju-gui/git/refs{/sha}","trees_url":"https://api.github.com/repos/jaycee/juju-gui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jaycee/juju-gui/statuses/{sha}","languages_url":"https://api.github.com/repos/jaycee/juju-gui/languages","stargazers_url":"https://api.github.com/repos/jaycee/juju-gui/stargazers","contributors_url":"https://api.github.com/repos/jaycee/juju-gui/contributors","subscribers_url":"https://api.github.com/repos/jaycee/juju-gui/subscribers","subscription_url":"https://api.github.com/repos/jaycee/juju-gui/subscription","commits_url":"https://api.github.com/repos/jaycee/juju-gui/commits{/sha}","git_commits_url":"https://api.github.com/repos/jaycee/juju-gui/git/commits{/sha}","comments_url":"https://api.github.com/repos/jaycee/juju-gui/comments{/number}","issue_comment_url":"https://api.github.com/repos/jaycee/juju-gui/issues/comments/{number}","contents_url":"https://api.github.com/repos/jaycee/juju-gui/contents/{+path}","compare_url":"https://api.github.com/repos/jaycee/juju-gui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jaycee/juju-gui/merges","archive_url":"https://api.github.com/repos/jaycee/juju-gui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jaycee/juju-gui/downloads","issues_url":"https://api.github.com/repos/jaycee/juju-gui/issues{/number}","pulls_url":"https://api.github.com/repos/jaycee/juju-gui/pulls{/number}","milestones_url":"https://api.github.com/repos/jaycee/juju-gui/milestones{/number}","notifications_url":"https://api.github.com/repos/jaycee/juju-gui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jaycee/juju-gui/labels{/name}","releases_url":"https://api.github.com/repos/jaycee/juju-gui/releases{/id}","created_at":"2014-06-18T13:16:17Z","updated_at":"2014-06-25T15:54:41Z","pushed_at":"2014-07-03T18:03:15Z","git_url":"git://github.com/jaycee/juju-gui.git","ssh_url":"git@github.com:jaycee/juju-gui.git","clone_url":"https://github.com/jaycee/juju-gui.git","svn_url":"https://github.com/jaycee/juju-gui","homepage":null,"size":97806,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"juju:develop","ref":"develop","sha":"2c4161ec7a9f86b6b30390d6de682b402fb678ab","user":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?","gravatar_id":"b095d1e26e5705abe0ad2de7d87aac2e","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"repo":{"id":14960387,"name":"juju-gui","full_name":"juju/juju-gui","owner":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?","gravatar_id":"b095d1e26e5705abe0ad2de7d87aac2e","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju/juju-gui","description":"Juju-GUI is a web-based GUI for Juju <https://juju.ubuntu.com/>.","fork":false,"url":"https://api.github.com/repos/juju/juju-gui","forks_url":"https://api.github.com/repos/juju/juju-gui/forks","keys_url":"https://api.github.com/repos/juju/juju-gui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju/juju-gui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju/juju-gui/teams","hooks_url":"https://api.github.com/repos/juju/juju-gui/hooks","issue_events_url":"https://api.github.com/repos/juju/juju-gui/issues/events{/number}","events_url":"https://api.github.com/repos/juju/juju-gui/events","assignees_url":"https://api.github.com/repos/juju/juju-gui/assignees{/user}","branches_url":"https://api.github.com/repos/juju/juju-gui/branches{/branch}","tags_url":"https://api.github.com/repos/juju/juju-gui/tags","blobs_url":"https://api.github.com/repos/juju/juju-gui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju/juju-gui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju/juju-gui/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju/juju-gui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju/juju-gui/statuses/{sha}","languages_url":"https://api.github.com/repos/juju/juju-gui/languages","stargazers_url":"https://api.github.com/repos/juju/juju-gui/stargazers","contributors_url":"https://api.github.com/repos/juju/juju-gui/contributors","subscribers_url":"https://api.github.com/repos/juju/juju-gui/subscribers","subscription_url":"https://api.github.com/repos/juju/juju-gui/subscription","commits_url":"https://api.github.com/repos/juju/juju-gui/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju/juju-gui/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju/juju-gui/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju/juju-gui/issues/comments/{number}","contents_url":"https://api.github.com/repos/juju/juju-gui/contents/{+path}","compare_url":"https://api.github.com/repos/juju/juju-gui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju/juju-gui/merges","archive_url":"https://api.github.com/repos/juju/juju-gui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju/juju-gui/downloads","issues_url":"https://api.github.com/repos/juju/juju-gui/issues{/number}","pulls_url":"https://api.github.com/repos/juju/juju-gui/pulls{/number}","milestones_url":"https://api.github.com/repos/juju/juju-gui/milestones{/number}","notifications_url":"https://api.github.com/repos/juju/juju-gui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju/juju-gui/labels{/name}","releases_url":"https://api.github.com/repos/juju/juju-gui/releases{/id}","created_at":"2013-12-05T17:15:48Z","updated_at":"2014-06-25T16:04:13Z","pushed_at":"2014-07-03T15:51:09Z","git_url":"git://github.com/juju/juju-gui.git","ssh_url":"git@github.com:juju/juju-gui.git","clone_url":"https://github.com/juju/juju-gui.git","svn_url":"https://github.com/juju/juju-gui","homepage":null,"size":107174,"stargazers_count":29,"watchers_count":29,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":30,"mirror_url":null,"open_issues_count":2,"forks":30,"open_issues":2,"watchers":29,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/juju/juju-gui/pulls/422"},"html":{"href":"https://github.com/juju/juju-gui/pull/422"},"issue":{"href":"https://api.github.com/repos/juju/juju-gui/issues/422"},"comments":{"href":"https://api.github.com/repos/juju/juju-gui/issues/422/comments"},"review_comments":{"href":"https://api.github.com/repos/juju/juju-gui/pulls/422/comments"},"review_comment":{"href":"https://api.github.com/repos/juju/juju-gui/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/juju/juju-gui/pulls/422/commits"},"statuses":{"href":"https://api.github.com/repos/juju/juju-gui/statuses/17cd77c564e6b3e1cbfe50379fac3e9275e9c23f"}}}}