GitHub PullRequestEvent at 2014-07-03 08:25:02
Repository: jenkins
Actor: cupcicm
Payload: {"action":"opened","number":244,"pull_request":{"url":"https://api.github.com/repos/opscode-cookbooks/jenkins/pulls/244","id":17931271,"html_url":"https://github.com/opscode-cookbooks/jenkins/pull/244","diff_url":"https://github.com/opscode-cookbooks/jenkins/pull/244.diff","patch_url":"https://github.com/opscode-cookbooks/jenkins/pull/244.patch","issue_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/issues/244","number":244,"state":"open","title":"Bug on windows slaves when slave.jar changes.","user":{"login":"cupcicm","id":352889,"avatar_url":"https://avatars.githubusercontent.com/u/352889?","gravatar_id":"9a0bee6b4e941fa1f9931b7ba288b06d","url":"https://api.github.com/users/cupcicm","html_url":"https://github.com/cupcicm","followers_url":"https://api.github.com/users/cupcicm/followers","following_url":"https://api.github.com/users/cupcicm/following{/other_user}","gists_url":"https://api.github.com/users/cupcicm/gists{/gist_id}","starred_url":"https://api.github.com/users/cupcicm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cupcicm/subscriptions","organizations_url":"https://api.github.com/users/cupcicm/orgs","repos_url":"https://api.github.com/users/cupcicm/repos","events_url":"https://api.github.com/users/cupcicm/events{/privacy}","received_events_url":"https://api.github.com/users/cupcicm/received_events","type":"User","site_admin":false},"body":"On Windows, when slave.jar changes on the master, the\r\n'slave_jar_resource' remote_file will try to replace the file.\r\nUsually, the file is already in use (since the jenkins slave is running).\r\nThat means we need to be careful about how we try to update this file.\r\nI didn't investigate exactly why, but the atomic_update strategy seems to do something that the open file is not happy with (and I get a `Errno::EACCES: remote_file[C:\\chef\\cache/slave.jar]\r\n(dynamically defined) had an error: Errno::EACCES: Permission denied` error).\r\nThis is why I am proposing to use the non atomic update strategy, which uses a simple cp and does not have this problem.\r\n","created_at":"2014-07-03T08:25:01Z","updated_at":"2014-07-03T08:25:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/pulls/244/commits","review_comments_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/pulls/244/comments","review_comment_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/pulls/comments/{number}","comments_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/issues/244/comments","statuses_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/statuses/0f5319cbf74bf90eb39d53de3dbefe0b881cd97a","head":{"label":"criteo-cookbooks:fix_windows_jnlp_slaves","ref":"fix_windows_jnlp_slaves","sha":"0f5319cbf74bf90eb39d53de3dbefe0b881cd97a","user":{"login":"criteo-cookbooks","id":4266429,"avatar_url":"https://avatars.githubusercontent.com/u/4266429?","gravatar_id":"ff4b914611c701228b68338bfb516798","url":"https://api.github.com/users/criteo-cookbooks","html_url":"https://github.com/criteo-cookbooks","followers_url":"https://api.github.com/users/criteo-cookbooks/followers","following_url":"https://api.github.com/users/criteo-cookbooks/following{/other_user}","gists_url":"https://api.github.com/users/criteo-cookbooks/gists{/gist_id}","starred_url":"https://api.github.com/users/criteo-cookbooks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/criteo-cookbooks/subscriptions","organizations_url":"https://api.github.com/users/criteo-cookbooks/orgs","repos_url":"https://api.github.com/users/criteo-cookbooks/repos","events_url":"https://api.github.com/users/criteo-cookbooks/events{/privacy}","received_events_url":"https://api.github.com/users/criteo-cookbooks/received_events","type":"Organization","site_admin":false},"repo":{"id":19503849,"name":"jenkins","full_name":"criteo-cookbooks/jenkins","owner":{"login":"criteo-cookbooks","id":4266429,"avatar_url":"https://avatars.githubusercontent.com/u/4266429?","gravatar_id":"ff4b914611c701228b68338bfb516798","url":"https://api.github.com/users/criteo-cookbooks","html_url":"https://github.com/criteo-cookbooks","followers_url":"https://api.github.com/users/criteo-cookbooks/followers","following_url":"https://api.github.com/users/criteo-cookbooks/following{/other_user}","gists_url":"https://api.github.com/users/criteo-cookbooks/gists{/gist_id}","starred_url":"https://api.github.com/users/criteo-cookbooks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/criteo-cookbooks/subscriptions","organizations_url":"https://api.github.com/users/criteo-cookbooks/orgs","repos_url":"https://api.github.com/users/criteo-cookbooks/repos","events_url":"https://api.github.com/users/criteo-cookbooks/events{/privacy}","received_events_url":"https://api.github.com/users/criteo-cookbooks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/criteo-cookbooks/jenkins","description":"Development repository for Opscode Cookbook jenkins","fork":true,"url":"https://api.github.com/repos/criteo-cookbooks/jenkins","forks_url":"https://api.github.com/repos/criteo-cookbooks/jenkins/forks","keys_url":"https://api.github.com/repos/criteo-cookbooks/jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/criteo-cookbooks/jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/criteo-cookbooks/jenkins/teams","hooks_url":"https://api.github.com/repos/criteo-cookbooks/jenkins/hooks","issue_events_url":"https://api.github.com/repos/criteo-cookbooks/jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/criteo-cookbooks/jenkins/events","assignees_url":"https://api.github.com/repos/criteo-cookbooks/jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/criteo-cookbooks/jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/criteo-cookbooks/jenkins/tags","blobs_url":"https://api.github.com/repos/criteo-cookbooks/jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/criteo-cookbooks/jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/criteo-cookbooks/jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/criteo-cookbooks/jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/criteo-cookbooks/jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/criteo-cookbooks/jenkins/languages","stargazers_url":"https://api.github.com/repos/criteo-cookbooks/jenkins/stargazers","contributors_url":"https://api.github.com/repos/criteo-cookbooks/jenkins/contributors","subscribers_url":"https://api.github.com/repos/criteo-cookbooks/jenkins/subscribers","subscription_url":"https://api.github.com/repos/criteo-cookbooks/jenkins/subscription","commits_url":"https://api.github.com/repos/criteo-cookbooks/jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/criteo-cookbooks/jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/criteo-cookbooks/jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/criteo-cookbooks/jenkins/issues/comments/{number}","contents_url":"https://api.github.com/repos/criteo-cookbooks/jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/criteo-cookbooks/jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/criteo-cookbooks/jenkins/merges","archive_url":"https://api.github.com/repos/criteo-cookbooks/jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/criteo-cookbooks/jenkins/downloads","issues_url":"https://api.github.com/repos/criteo-cookbooks/jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/criteo-cookbooks/jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/criteo-cookbooks/jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/criteo-cookbooks/jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/criteo-cookbooks/jenkins/labels{/name}","releases_url":"https://api.github.com/repos/criteo-cookbooks/jenkins/releases{/id}","created_at":"2014-05-06T17:32:35Z","updated_at":"2014-07-02T09:39:57Z","pushed_at":"2014-07-03T08:22:53Z","git_url":"git://github.com/criteo-cookbooks/jenkins.git","ssh_url":"git@github.com:criteo-cookbooks/jenkins.git","clone_url":"https://github.com/criteo-cookbooks/jenkins.git","svn_url":"https://github.com/criteo-cookbooks/jenkins","homepage":null,"size":758,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"opscode-cookbooks:master","ref":"master","sha":"345726aef38502411ba4c756eedef1947f679a1f","user":{"login":"opscode-cookbooks","id":1537126,"avatar_url":"https://avatars.githubusercontent.com/u/1537126?","gravatar_id":"d325d33d2ed66c370c0d031e45cf608d","url":"https://api.github.com/users/opscode-cookbooks","html_url":"https://github.com/opscode-cookbooks","followers_url":"https://api.github.com/users/opscode-cookbooks/followers","following_url":"https://api.github.com/users/opscode-cookbooks/following{/other_user}","gists_url":"https://api.github.com/users/opscode-cookbooks/gists{/gist_id}","starred_url":"https://api.github.com/users/opscode-cookbooks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opscode-cookbooks/subscriptions","organizations_url":"https://api.github.com/users/opscode-cookbooks/orgs","repos_url":"https://api.github.com/users/opscode-cookbooks/repos","events_url":"https://api.github.com/users/opscode-cookbooks/events{/privacy}","received_events_url":"https://api.github.com/users/opscode-cookbooks/received_events","type":"Organization","site_admin":false},"repo":{"id":7950974,"name":"jenkins","full_name":"opscode-cookbooks/jenkins","owner":{"login":"opscode-cookbooks","id":1537126,"avatar_url":"https://avatars.githubusercontent.com/u/1537126?","gravatar_id":"d325d33d2ed66c370c0d031e45cf608d","url":"https://api.github.com/users/opscode-cookbooks","html_url":"https://github.com/opscode-cookbooks","followers_url":"https://api.github.com/users/opscode-cookbooks/followers","following_url":"https://api.github.com/users/opscode-cookbooks/following{/other_user}","gists_url":"https://api.github.com/users/opscode-cookbooks/gists{/gist_id}","starred_url":"https://api.github.com/users/opscode-cookbooks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opscode-cookbooks/subscriptions","organizations_url":"https://api.github.com/users/opscode-cookbooks/orgs","repos_url":"https://api.github.com/users/opscode-cookbooks/repos","events_url":"https://api.github.com/users/opscode-cookbooks/events{/privacy}","received_events_url":"https://api.github.com/users/opscode-cookbooks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opscode-cookbooks/jenkins","description":"Development repository for Opscode Cookbook jenkins","fork":false,"url":"https://api.github.com/repos/opscode-cookbooks/jenkins","forks_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/forks","keys_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/teams","hooks_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/hooks","issue_events_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/events","assignees_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/tags","blobs_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/languages","stargazers_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/stargazers","contributors_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/contributors","subscribers_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/subscribers","subscription_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/subscription","commits_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/issues/comments/{number}","contents_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/merges","archive_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/downloads","issues_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/labels{/name}","releases_url":"https://api.github.com/repos/opscode-cookbooks/jenkins/releases{/id}","created_at":"2013-02-01T03:23:46Z","updated_at":"2014-07-02T17:54:30Z","pushed_at":"2014-07-02T15:55:05Z","git_url":"git://github.com/opscode-cookbooks/jenkins.git","ssh_url":"git@github.com:opscode-cookbooks/jenkins.git","clone_url":"https://github.com/opscode-cookbooks/jenkins.git","svn_url":"https://github.com/opscode-cookbooks/jenkins","homepage":null,"size":3922,"stargazers_count":110,"watchers_count":110,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":217,"mirror_url":null,"open_issues_count":2,"forks":217,"open_issues":2,"watchers":110,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opscode-cookbooks/jenkins/pulls/244"},"html":{"href":"https://github.com/opscode-cookbooks/jenkins/pull/244"},"issue":{"href":"https://api.github.com/repos/opscode-cookbooks/jenkins/issues/244"},"comments":{"href":"https://api.github.com/repos/opscode-cookbooks/jenkins/issues/244/comments"},"review_comments":{"href":"https://api.github.com/repos/opscode-cookbooks/jenkins/pulls/244/comments"},"review_comment":{"href":"https://api.github.com/repos/opscode-cookbooks/jenkins/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/opscode-cookbooks/jenkins/pulls/244/commits"},"statuses":{"href":"https://api.github.com/repos/opscode-cookbooks/jenkins/statuses/0f5319cbf74bf90eb39d53de3dbefe0b881cd97a"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":0,"changed_files":1}}