GitHub PullRequestEvent at 2014-04-14 15:42:32
Repository: frenetic
Actor: seliopou
Payload: {"action":"closed","number":287,"pull_request":{"url":"https://api.github.com/repos/frenetic-lang/frenetic/pulls/287","id":14700964,"html_url":"https://github.com/frenetic-lang/frenetic/pull/287","diff_url":"https://github.com/frenetic-lang/frenetic/pull/287.diff","patch_url":"https://github.com/frenetic-lang/frenetic/pull/287.patch","issue_url":"https://api.github.com/repos/frenetic-lang/frenetic/issues/287","number":287,"state":"closed","title":"shadow: fix and expand comment, simplify implementation","user":{"login":"seliopou","id":25269,"avatar_url":"https://avatars.githubusercontent.com/u/25269?","gravatar_id":"031d6837d420d53904006785c707cb05","url":"https://api.github.com/users/seliopou","html_url":"https://github.com/seliopou","followers_url":"https://api.github.com/users/seliopou/followers","following_url":"https://api.github.com/users/seliopou/following{/other_user}","gists_url":"https://api.github.com/users/seliopou/gists{/gist_id}","starred_url":"https://api.github.com/users/seliopou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seliopou/subscriptions","organizations_url":"https://api.github.com/users/seliopou/orgs","repos_url":"https://api.github.com/users/seliopou/repos","events_url":"https://api.github.com/users/seliopou/events{/privacy}","received_events_url":"https://api.github.com/users/seliopou/received_events","type":"User","site_admin":false},"body":"The previous shadow implementation was technically correct but performed redundant checks. The comment was also not clearly describing the behavior of the function. The comment has been rewritten in terms of the general concept of shadowing on patterns, as well as a more concrete description given the data structures in use today.","created_at":"2014-04-14T02:23:55Z","updated_at":"2014-04-14T15:42:32Z","closed_at":"2014-04-14T15:42:32Z","merged_at":"2014-04-14T15:42:32Z","merge_commit_sha":"5a558f5ff464ea9e0a546f8dd46d5415c6ee103c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/frenetic-lang/frenetic/pulls/287/commits","review_comments_url":"https://api.github.com/repos/frenetic-lang/frenetic/pulls/287/comments","review_comment_url":"https://api.github.com/repos/frenetic-lang/frenetic/pulls/comments/{number}","comments_url":"https://api.github.com/repos/frenetic-lang/frenetic/issues/287/comments","statuses_url":"https://api.github.com/repos/frenetic-lang/frenetic/statuses/88ee314c7e27d503bdd21f4799118f8f9e2b26c7","head":{"label":"frenetic-lang:shadow","ref":"shadow","sha":"88ee314c7e27d503bdd21f4799118f8f9e2b26c7","user":{"login":"frenetic-lang","id":1843920,"avatar_url":"https://avatars.githubusercontent.com/u/1843920?","gravatar_id":"a506b113f3c40ce83cb53e6e6cdfcfc9","url":"https://api.github.com/users/frenetic-lang","html_url":"https://github.com/frenetic-lang","followers_url":"https://api.github.com/users/frenetic-lang/followers","following_url":"https://api.github.com/users/frenetic-lang/following{/other_user}","gists_url":"https://api.github.com/users/frenetic-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/frenetic-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frenetic-lang/subscriptions","organizations_url":"https://api.github.com/users/frenetic-lang/orgs","repos_url":"https://api.github.com/users/frenetic-lang/repos","events_url":"https://api.github.com/users/frenetic-lang/events{/privacy}","received_events_url":"https://api.github.com/users/frenetic-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":7257740,"name":"frenetic","full_name":"frenetic-lang/frenetic","owner":{"login":"frenetic-lang","id":1843920,"avatar_url":"https://avatars.githubusercontent.com/u/1843920?","gravatar_id":"a506b113f3c40ce83cb53e6e6cdfcfc9","url":"https://api.github.com/users/frenetic-lang","html_url":"https://github.com/frenetic-lang","followers_url":"https://api.github.com/users/frenetic-lang/followers","following_url":"https://api.github.com/users/frenetic-lang/following{/other_user}","gists_url":"https://api.github.com/users/frenetic-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/frenetic-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frenetic-lang/subscriptions","organizations_url":"https://api.github.com/users/frenetic-lang/orgs","repos_url":"https://api.github.com/users/frenetic-lang/repos","events_url":"https://api.github.com/users/frenetic-lang/events{/privacy}","received_events_url":"https://api.github.com/users/frenetic-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/frenetic-lang/frenetic","description":"The Frenetic Programming Language and Runtime System","fork":false,"url":"https://api.github.com/repos/frenetic-lang/frenetic","forks_url":"https://api.github.com/repos/frenetic-lang/frenetic/forks","keys_url":"https://api.github.com/repos/frenetic-lang/frenetic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/frenetic-lang/frenetic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/frenetic-lang/frenetic/teams","hooks_url":"https://api.github.com/repos/frenetic-lang/frenetic/hooks","issue_events_url":"https://api.github.com/repos/frenetic-lang/frenetic/issues/events{/number}","events_url":"https://api.github.com/repos/frenetic-lang/frenetic/events","assignees_url":"https://api.github.com/repos/frenetic-lang/frenetic/assignees{/user}","branches_url":"https://api.github.com/repos/frenetic-lang/frenetic/branches{/branch}","tags_url":"https://api.github.com/repos/frenetic-lang/frenetic/tags","blobs_url":"https://api.github.com/repos/frenetic-lang/frenetic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/frenetic-lang/frenetic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/frenetic-lang/frenetic/git/refs{/sha}","trees_url":"https://api.github.com/repos/frenetic-lang/frenetic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/frenetic-lang/frenetic/statuses/{sha}","languages_url":"https://api.github.com/repos/frenetic-lang/frenetic/languages","stargazers_url":"https://api.github.com/repos/frenetic-lang/frenetic/stargazers","contributors_url":"https://api.github.com/repos/frenetic-lang/frenetic/contributors","subscribers_url":"https://api.github.com/repos/frenetic-lang/frenetic/subscribers","subscription_url":"https://api.github.com/repos/frenetic-lang/frenetic/subscription","commits_url":"https://api.github.com/repos/frenetic-lang/frenetic/commits{/sha}","git_commits_url":"https://api.github.com/repos/frenetic-lang/frenetic/git/commits{/sha}","comments_url":"https://api.github.com/repos/frenetic-lang/frenetic/comments{/number}","issue_comment_url":"https://api.github.com/repos/frenetic-lang/frenetic/issues/comments/{number}","contents_url":"https://api.github.com/repos/frenetic-lang/frenetic/contents/{+path}","compare_url":"https://api.github.com/repos/frenetic-lang/frenetic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/frenetic-lang/frenetic/merges","archive_url":"https://api.github.com/repos/frenetic-lang/frenetic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/frenetic-lang/frenetic/downloads","issues_url":"https://api.github.com/repos/frenetic-lang/frenetic/issues{/number}","pulls_url":"https://api.github.com/repos/frenetic-lang/frenetic/pulls{/number}","milestones_url":"https://api.github.com/repos/frenetic-lang/frenetic/milestones{/number}","notifications_url":"https://api.github.com/repos/frenetic-lang/frenetic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/frenetic-lang/frenetic/labels{/name}","releases_url":"https://api.github.com/repos/frenetic-lang/frenetic/releases{/id}","created_at":"2012-12-20T12:59:47Z","updated_at":"2014-04-14T15:42:32Z","pushed_at":"2014-04-14T15:42:31Z","git_url":"git://github.com/frenetic-lang/frenetic.git","ssh_url":"git@github.com:frenetic-lang/frenetic.git","clone_url":"https://github.com/frenetic-lang/frenetic.git","svn_url":"https://github.com/frenetic-lang/frenetic","homepage":"http://www.frenetic-lang.org/","size":17444,"stargazers_count":45,"watchers_count":45,"language":"OCaml","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":17,"mirror_url":null,"open_issues_count":64,"forks":17,"open_issues":64,"watchers":45,"default_branch":"master","master_branch":"master"}},"base":{"label":"frenetic-lang:master","ref":"master","sha":"1acaae0ee09257d0f7987c0863a829d2386c7163","user":{"login":"frenetic-lang","id":1843920,"avatar_url":"https://avatars.githubusercontent.com/u/1843920?","gravatar_id":"a506b113f3c40ce83cb53e6e6cdfcfc9","url":"https://api.github.com/users/frenetic-lang","html_url":"https://github.com/frenetic-lang","followers_url":"https://api.github.com/users/frenetic-lang/followers","following_url":"https://api.github.com/users/frenetic-lang/following{/other_user}","gists_url":"https://api.github.com/users/frenetic-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/frenetic-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frenetic-lang/subscriptions","organizations_url":"https://api.github.com/users/frenetic-lang/orgs","repos_url":"https://api.github.com/users/frenetic-lang/repos","events_url":"https://api.github.com/users/frenetic-lang/events{/privacy}","received_events_url":"https://api.github.com/users/frenetic-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":7257740,"name":"frenetic","full_name":"frenetic-lang/frenetic","owner":{"login":"frenetic-lang","id":1843920,"avatar_url":"https://avatars.githubusercontent.com/u/1843920?","gravatar_id":"a506b113f3c40ce83cb53e6e6cdfcfc9","url":"https://api.github.com/users/frenetic-lang","html_url":"https://github.com/frenetic-lang","followers_url":"https://api.github.com/users/frenetic-lang/followers","following_url":"https://api.github.com/users/frenetic-lang/following{/other_user}","gists_url":"https://api.github.com/users/frenetic-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/frenetic-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frenetic-lang/subscriptions","organizations_url":"https://api.github.com/users/frenetic-lang/orgs","repos_url":"https://api.github.com/users/frenetic-lang/repos","events_url":"https://api.github.com/users/frenetic-lang/events{/privacy}","received_events_url":"https://api.github.com/users/frenetic-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/frenetic-lang/frenetic","description":"The Frenetic Programming Language and Runtime System","fork":false,"url":"https://api.github.com/repos/frenetic-lang/frenetic","forks_url":"https://api.github.com/repos/frenetic-lang/frenetic/forks","keys_url":"https://api.github.com/repos/frenetic-lang/frenetic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/frenetic-lang/frenetic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/frenetic-lang/frenetic/teams","hooks_url":"https://api.github.com/repos/frenetic-lang/frenetic/hooks","issue_events_url":"https://api.github.com/repos/frenetic-lang/frenetic/issues/events{/number}","events_url":"https://api.github.com/repos/frenetic-lang/frenetic/events","assignees_url":"https://api.github.com/repos/frenetic-lang/frenetic/assignees{/user}","branches_url":"https://api.github.com/repos/frenetic-lang/frenetic/branches{/branch}","tags_url":"https://api.github.com/repos/frenetic-lang/frenetic/tags","blobs_url":"https://api.github.com/repos/frenetic-lang/frenetic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/frenetic-lang/frenetic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/frenetic-lang/frenetic/git/refs{/sha}","trees_url":"https://api.github.com/repos/frenetic-lang/frenetic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/frenetic-lang/frenetic/statuses/{sha}","languages_url":"https://api.github.com/repos/frenetic-lang/frenetic/languages","stargazers_url":"https://api.github.com/repos/frenetic-lang/frenetic/stargazers","contributors_url":"https://api.github.com/repos/frenetic-lang/frenetic/contributors","subscribers_url":"https://api.github.com/repos/frenetic-lang/frenetic/subscribers","subscription_url":"https://api.github.com/repos/frenetic-lang/frenetic/subscription","commits_url":"https://api.github.com/repos/frenetic-lang/frenetic/commits{/sha}","git_commits_url":"https://api.github.com/repos/frenetic-lang/frenetic/git/commits{/sha}","comments_url":"https://api.github.com/repos/frenetic-lang/frenetic/comments{/number}","issue_comment_url":"https://api.github.com/repos/frenetic-lang/frenetic/issues/comments/{number}","contents_url":"https://api.github.com/repos/frenetic-lang/frenetic/contents/{+path}","compare_url":"https://api.github.com/repos/frenetic-lang/frenetic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/frenetic-lang/frenetic/merges","archive_url":"https://api.github.com/repos/frenetic-lang/frenetic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/frenetic-lang/frenetic/downloads","issues_url":"https://api.github.com/repos/frenetic-lang/frenetic/issues{/number}","pulls_url":"https://api.github.com/repos/frenetic-lang/frenetic/pulls{/number}","milestones_url":"https://api.github.com/repos/frenetic-lang/frenetic/milestones{/number}","notifications_url":"https://api.github.com/repos/frenetic-lang/frenetic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/frenetic-lang/frenetic/labels{/name}","releases_url":"https://api.github.com/repos/frenetic-lang/frenetic/releases{/id}","created_at":"2012-12-20T12:59:47Z","updated_at":"2014-04-14T15:42:32Z","pushed_at":"2014-04-14T15:42:31Z","git_url":"git://github.com/frenetic-lang/frenetic.git","ssh_url":"git@github.com:frenetic-lang/frenetic.git","clone_url":"https://github.com/frenetic-lang/frenetic.git","svn_url":"https://github.com/frenetic-lang/frenetic","homepage":"http://www.frenetic-lang.org/","size":17444,"stargazers_count":45,"watchers_count":45,"language":"OCaml","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":17,"mirror_url":null,"open_issues_count":64,"forks":17,"open_issues":64,"watchers":45,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/frenetic-lang/frenetic/pulls/287"},"html":{"href":"https://github.com/frenetic-lang/frenetic/pull/287"},"issue":{"href":"https://api.github.com/repos/frenetic-lang/frenetic/issues/287"},"comments":{"href":"https://api.github.com/repos/frenetic-lang/frenetic/issues/287/comments"},"review_comments":{"href":"https://api.github.com/repos/frenetic-lang/frenetic/pulls/287/comments"},"review_comment":{"href":"https://api.github.com/repos/frenetic-lang/frenetic/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/frenetic-lang/frenetic/pulls/287/commits"},"statuses":{"href":"https://api.github.com/repos/frenetic-lang/frenetic/statuses/88ee314c7e27d503bdd21f4799118f8f9e2b26c7"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"seliopou","id":25269,"avatar_url":"https://avatars.githubusercontent.com/u/25269?","gravatar_id":"031d6837d420d53904006785c707cb05","url":"https://api.github.com/users/seliopou","html_url":"https://github.com/seliopou","followers_url":"https://api.github.com/users/seliopou/followers","following_url":"https://api.github.com/users/seliopou/following{/other_user}","gists_url":"https://api.github.com/users/seliopou/gists{/gist_id}","starred_url":"https://api.github.com/users/seliopou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seliopou/subscriptions","organizations_url":"https://api.github.com/users/seliopou/orgs","repos_url":"https://api.github.com/users/seliopou/repos","events_url":"https://api.github.com/users/seliopou/events{/privacy}","received_events_url":"https://api.github.com/users/seliopou/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":18,"deletions":9,"changed_files":1}}