GitHub PullRequestReviewCommentEvent at 2014-12-04 09:23:15
Repository: grasshopper-ui
Actor: bp323
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/pulls/comments/21293042","id":21293042,"diff_hunk":"@@ -156,11 +166,15 @@ define(['exports'], function(exports) {\n      * @param  {Object}      callback.response    The requested event series calendar in RSS format\n      */\n     var getUserCalendarRss = exports.getUserCalendarRss = function(userId, signature, callback) {\n-        if (!callback || (callback && !_.isFunction(callback))) {\n+        if (!_.isFunction(callback)) {\n             throw new Error('A callback function should be provided');\n-        } else if (!userId || (userId && !_.isNumber(userId))) {\n+        } else if (!_.isNumber(userId)) {\n             return callback({'code': 400, 'msg': 'A valid user id should be provided'});\n+        } else if (!_.isEmpty(signature) && !_.isString(signature)) {","path":"shared/gh/api/gh.api.user.js","position":99,"original_position":99,"commit_id":"806211341b5abef0f5b2f3f52e3af5cb4e17895d","original_commit_id":"806211341b5abef0f5b2f3f52e3af5cb4e17895d","user":{"login":"bp323","id":218391,"avatar_url":"https://avatars.githubusercontent.com/u/218391?v=3","gravatar_id":"","url":"https://api.github.com/users/bp323","html_url":"https://github.com/bp323","followers_url":"https://api.github.com/users/bp323/followers","following_url":"https://api.github.com/users/bp323/following{/other_user}","gists_url":"https://api.github.com/users/bp323/gists{/gist_id}","starred_url":"https://api.github.com/users/bp323/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bp323/subscriptions","organizations_url":"https://api.github.com/users/bp323/orgs","repos_url":"https://api.github.com/users/bp323/repos","events_url":"https://api.github.com/users/bp323/events{/privacy}","received_events_url":"https://api.github.com/users/bp323/received_events","type":"User","site_admin":false},"body":"`signature` is an optional parameter.","created_at":"2014-12-04T09:23:15Z","updated_at":"2014-12-04T09:23:15Z","html_url":"https://github.com/CUL-DigitalServices/grasshopper-ui/pull/40#discussion_r21293042","pull_request_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/pulls/40","_links":{"self":{"href":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/pulls/comments/21293042"},"html":{"href":"https://github.com/CUL-DigitalServices/grasshopper-ui/pull/40#discussion_r21293042"},"pull_request":{"href":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/pulls/40"}}},"pull_request":{"url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/pulls/40","id":25426004,"html_url":"https://github.com/CUL-DigitalServices/grasshopper-ui/pull/40","diff_url":"https://github.com/CUL-DigitalServices/grasshopper-ui/pull/40.diff","patch_url":"https://github.com/CUL-DigitalServices/grasshopper-ui/pull/40.patch","issue_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/issues/40","number":40,"state":"open","locked":false,"title":"Increase code coverage in existing modules","user":{"login":"Coenego","id":2194396,"avatar_url":"https://avatars.githubusercontent.com/u/2194396?v=3","gravatar_id":"","url":"https://api.github.com/users/Coenego","html_url":"https://github.com/Coenego","followers_url":"https://api.github.com/users/Coenego/followers","following_url":"https://api.github.com/users/Coenego/following{/other_user}","gists_url":"https://api.github.com/users/Coenego/gists{/gist_id}","starred_url":"https://api.github.com/users/Coenego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Coenego/subscriptions","organizations_url":"https://api.github.com/users/Coenego/orgs","repos_url":"https://api.github.com/users/Coenego/repos","events_url":"https://api.github.com/users/Coenego/events{/privacy}","received_events_url":"https://api.github.com/users/Coenego/received_events","type":"User","site_admin":false},"body":"Not all the existing modules have a 100% code coverage. This is mostly due to callback functions that aren't executed while running the unit tests.","created_at":"2014-12-03T15:22:02Z","updated_at":"2014-12-04T09:23:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ce01fb193a8de81a2c197f5fa2e7cba582c3346a","assignee":{"login":"bp323","id":218391,"avatar_url":"https://avatars.githubusercontent.com/u/218391?v=3","gravatar_id":"","url":"https://api.github.com/users/bp323","html_url":"https://github.com/bp323","followers_url":"https://api.github.com/users/bp323/followers","following_url":"https://api.github.com/users/bp323/following{/other_user}","gists_url":"https://api.github.com/users/bp323/gists{/gist_id}","starred_url":"https://api.github.com/users/bp323/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bp323/subscriptions","organizations_url":"https://api.github.com/users/bp323/orgs","repos_url":"https://api.github.com/users/bp323/repos","events_url":"https://api.github.com/users/bp323/events{/privacy}","received_events_url":"https://api.github.com/users/bp323/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/pulls/40/commits","review_comments_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/pulls/40/comments","review_comment_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/pulls/comments/{number}","comments_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/issues/40/comments","statuses_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/statuses/806211341b5abef0f5b2f3f52e3af5cb4e17895d","head":{"label":"Coenego:issue-40-coverage","ref":"issue-40-coverage","sha":"806211341b5abef0f5b2f3f52e3af5cb4e17895d","user":{"login":"Coenego","id":2194396,"avatar_url":"https://avatars.githubusercontent.com/u/2194396?v=3","gravatar_id":"","url":"https://api.github.com/users/Coenego","html_url":"https://github.com/Coenego","followers_url":"https://api.github.com/users/Coenego/followers","following_url":"https://api.github.com/users/Coenego/following{/other_user}","gists_url":"https://api.github.com/users/Coenego/gists{/gist_id}","starred_url":"https://api.github.com/users/Coenego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Coenego/subscriptions","organizations_url":"https://api.github.com/users/Coenego/orgs","repos_url":"https://api.github.com/users/Coenego/repos","events_url":"https://api.github.com/users/Coenego/events{/privacy}","received_events_url":"https://api.github.com/users/Coenego/received_events","type":"User","site_admin":false},"repo":{"id":26270317,"name":"grasshopper-ui","full_name":"Coenego/grasshopper-ui","owner":{"login":"Coenego","id":2194396,"avatar_url":"https://avatars.githubusercontent.com/u/2194396?v=3","gravatar_id":"","url":"https://api.github.com/users/Coenego","html_url":"https://github.com/Coenego","followers_url":"https://api.github.com/users/Coenego/followers","following_url":"https://api.github.com/users/Coenego/following{/other_user}","gists_url":"https://api.github.com/users/Coenego/gists{/gist_id}","starred_url":"https://api.github.com/users/Coenego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Coenego/subscriptions","organizations_url":"https://api.github.com/users/Coenego/orgs","repos_url":"https://api.github.com/users/Coenego/repos","events_url":"https://api.github.com/users/Coenego/events{/privacy}","received_events_url":"https://api.github.com/users/Coenego/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Coenego/grasshopper-ui","description":"Grasshopper UI","fork":true,"url":"https://api.github.com/repos/Coenego/grasshopper-ui","forks_url":"https://api.github.com/repos/Coenego/grasshopper-ui/forks","keys_url":"https://api.github.com/repos/Coenego/grasshopper-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Coenego/grasshopper-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Coenego/grasshopper-ui/teams","hooks_url":"https://api.github.com/repos/Coenego/grasshopper-ui/hooks","issue_events_url":"https://api.github.com/repos/Coenego/grasshopper-ui/issues/events{/number}","events_url":"https://api.github.com/repos/Coenego/grasshopper-ui/events","assignees_url":"https://api.github.com/repos/Coenego/grasshopper-ui/assignees{/user}","branches_url":"https://api.github.com/repos/Coenego/grasshopper-ui/branches{/branch}","tags_url":"https://api.github.com/repos/Coenego/grasshopper-ui/tags","blobs_url":"https://api.github.com/repos/Coenego/grasshopper-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Coenego/grasshopper-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Coenego/grasshopper-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/Coenego/grasshopper-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Coenego/grasshopper-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/Coenego/grasshopper-ui/languages","stargazers_url":"https://api.github.com/repos/Coenego/grasshopper-ui/stargazers","contributors_url":"https://api.github.com/repos/Coenego/grasshopper-ui/contributors","subscribers_url":"https://api.github.com/repos/Coenego/grasshopper-ui/subscribers","subscription_url":"https://api.github.com/repos/Coenego/grasshopper-ui/subscription","commits_url":"https://api.github.com/repos/Coenego/grasshopper-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/Coenego/grasshopper-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/Coenego/grasshopper-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/Coenego/grasshopper-ui/issues/comments/{number}","contents_url":"https://api.github.com/repos/Coenego/grasshopper-ui/contents/{+path}","compare_url":"https://api.github.com/repos/Coenego/grasshopper-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Coenego/grasshopper-ui/merges","archive_url":"https://api.github.com/repos/Coenego/grasshopper-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Coenego/grasshopper-ui/downloads","issues_url":"https://api.github.com/repos/Coenego/grasshopper-ui/issues{/number}","pulls_url":"https://api.github.com/repos/Coenego/grasshopper-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/Coenego/grasshopper-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/Coenego/grasshopper-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Coenego/grasshopper-ui/labels{/name}","releases_url":"https://api.github.com/repos/Coenego/grasshopper-ui/releases{/id}","created_at":"2014-11-06T13:08:06Z","updated_at":"2014-12-02T11:45:52Z","pushed_at":"2014-12-03T16:26:04Z","git_url":"git://github.com/Coenego/grasshopper-ui.git","ssh_url":"git@github.com:Coenego/grasshopper-ui.git","clone_url":"https://github.com/Coenego/grasshopper-ui.git","svn_url":"https://github.com/Coenego/grasshopper-ui","homepage":null,"size":1981,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CUL-DigitalServices:master","ref":"master","sha":"31b2eb40d2ae1ea4ae0e0d9401812cb1b3b17dd5","user":{"login":"CUL-DigitalServices","id":5594563,"avatar_url":"https://avatars.githubusercontent.com/u/5594563?v=3","gravatar_id":"","url":"https://api.github.com/users/CUL-DigitalServices","html_url":"https://github.com/CUL-DigitalServices","followers_url":"https://api.github.com/users/CUL-DigitalServices/followers","following_url":"https://api.github.com/users/CUL-DigitalServices/following{/other_user}","gists_url":"https://api.github.com/users/CUL-DigitalServices/gists{/gist_id}","starred_url":"https://api.github.com/users/CUL-DigitalServices/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CUL-DigitalServices/subscriptions","organizations_url":"https://api.github.com/users/CUL-DigitalServices/orgs","repos_url":"https://api.github.com/users/CUL-DigitalServices/repos","events_url":"https://api.github.com/users/CUL-DigitalServices/events{/privacy}","received_events_url":"https://api.github.com/users/CUL-DigitalServices/received_events","type":"Organization","site_admin":false},"repo":{"id":26270238,"name":"grasshopper-ui","full_name":"CUL-DigitalServices/grasshopper-ui","owner":{"login":"CUL-DigitalServices","id":5594563,"avatar_url":"https://avatars.githubusercontent.com/u/5594563?v=3","gravatar_id":"","url":"https://api.github.com/users/CUL-DigitalServices","html_url":"https://github.com/CUL-DigitalServices","followers_url":"https://api.github.com/users/CUL-DigitalServices/followers","following_url":"https://api.github.com/users/CUL-DigitalServices/following{/other_user}","gists_url":"https://api.github.com/users/CUL-DigitalServices/gists{/gist_id}","starred_url":"https://api.github.com/users/CUL-DigitalServices/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CUL-DigitalServices/subscriptions","organizations_url":"https://api.github.com/users/CUL-DigitalServices/orgs","repos_url":"https://api.github.com/users/CUL-DigitalServices/repos","events_url":"https://api.github.com/users/CUL-DigitalServices/events{/privacy}","received_events_url":"https://api.github.com/users/CUL-DigitalServices/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CUL-DigitalServices/grasshopper-ui","description":"Grasshopper UI","fork":true,"url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui","forks_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/forks","keys_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/teams","hooks_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/hooks","issue_events_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/issues/events{/number}","events_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/events","assignees_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/assignees{/user}","branches_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/branches{/branch}","tags_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/tags","blobs_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/languages","stargazers_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/stargazers","contributors_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/contributors","subscribers_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/subscribers","subscription_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/subscription","commits_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/issues/comments/{number}","contents_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/contents/{+path}","compare_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/merges","archive_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/downloads","issues_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/issues{/number}","pulls_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/labels{/name}","releases_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/releases{/id}","created_at":"2014-11-06T13:06:00Z","updated_at":"2014-12-02T16:46:08Z","pushed_at":"2014-12-02T16:46:08Z","git_url":"git://github.com/CUL-DigitalServices/grasshopper-ui.git","ssh_url":"git@github.com:CUL-DigitalServices/grasshopper-ui.git","clone_url":"https://github.com/CUL-DigitalServices/grasshopper-ui.git","svn_url":"https://github.com/CUL-DigitalServices/grasshopper-ui","homepage":null,"size":1699,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":9,"forks":3,"open_issues":9,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/pulls/40"},"html":{"href":"https://github.com/CUL-DigitalServices/grasshopper-ui/pull/40"},"issue":{"href":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/issues/40"},"comments":{"href":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/statuses/806211341b5abef0f5b2f3f52e3af5cb4e17895d"}}}}