GitHub PullRequestReviewCommentEvent at 2014-07-01 01:44:31
Repository: rfcs
Actor: TheHydroImpulse
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rfcs/pulls/comments/14385779","id":14385779,"diff_hunk":"@@ -0,0 +1,66 @@\n+- Start Date: 2014-06-30\n+- RFC PR #: (leave this empty)\n+- Rust Issue #: (leave this empty)\n+\n+# Summary\n+\n+Switching (back) the current type parameter syntax from `<>` to `[]`.\n+\n+# Motivation\n+\n+Recently there has been a lot of talks on simplifying the syntax. Starting from removing the sigils `@` and `~` and making lifetimes less syntax heavy (through various proposals). I think changing the current generic syntax to `[]` will make it that much better and clearer (`[]` is much easier to read).\n+\n+1. We would remove the current ambiguities surround the current syntax `<>`. That means, we could be able to have:\n+\n+```rust\n+struct Vec[T] {\n+    // ...\n+}\n+\n+fn foo[T]() -> Vec[T] {\n+    // ...\n+}\n+\n+fn main() {\n+    let something = foo[int]();\n+}\n+```\n+\n+2. `[]` composes **much** better than the more cryptic `<>` form. This is a common readability issue when working with any nested types (such as encoders and decoders).\n+\n+```rust\n+fn parse['a, T: Encodable[Encoder['a], IoError]](value: T) {\n+    // ...\n+}","path":"active/0000-square-brackets.md","position":28,"original_position":34,"commit_id":"ddabf81652351791d807acb71a6ed5bcefe2bbe6","original_commit_id":"69620ab6b7eb7a840263bbf9705ce088bd6689d3","user":{"login":"TheHydroImpulse","id":565790,"avatar_url":"https://avatars.githubusercontent.com/u/565790?","gravatar_id":"e58dfef0ae4af7a5f672bb89fa299ba8","url":"https://api.github.com/users/TheHydroImpulse","html_url":"https://github.com/TheHydroImpulse","followers_url":"https://api.github.com/users/TheHydroImpulse/followers","following_url":"https://api.github.com/users/TheHydroImpulse/following{/other_user}","gists_url":"https://api.github.com/users/TheHydroImpulse/gists{/gist_id}","starred_url":"https://api.github.com/users/TheHydroImpulse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheHydroImpulse/subscriptions","organizations_url":"https://api.github.com/users/TheHydroImpulse/orgs","repos_url":"https://api.github.com/users/TheHydroImpulse/repos","events_url":"https://api.github.com/users/TheHydroImpulse/events{/privacy}","received_events_url":"https://api.github.com/users/TheHydroImpulse/received_events","type":"User","site_admin":false},"body":"@chris-morgan Already in the latest commit.","created_at":"2014-07-01T01:44:31Z","updated_at":"2014-07-01T01:44:31Z","html_url":"https://github.com/rust-lang/rfcs/pull/148#discussion_r14385779","pull_request_url":"https://api.github.com/repos/rust-lang/rfcs/pulls/148","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rfcs/pulls/comments/14385779"},"html":{"href":"https://github.com/rust-lang/rfcs/pull/148#discussion_r14385779"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rfcs/pulls/148"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rfcs/pulls/148","id":17807020,"html_url":"https://github.com/rust-lang/rfcs/pull/148","diff_url":"https://github.com/rust-lang/rfcs/pull/148.diff","patch_url":"https://github.com/rust-lang/rfcs/pull/148.patch","issue_url":"https://api.github.com/repos/rust-lang/rfcs/issues/148","number":148,"state":"open","title":"Switch `<>` back to `[]`","user":{"login":"TheHydroImpulse","id":565790,"avatar_url":"https://avatars.githubusercontent.com/u/565790?","gravatar_id":"e58dfef0ae4af7a5f672bb89fa299ba8","url":"https://api.github.com/users/TheHydroImpulse","html_url":"https://github.com/TheHydroImpulse","followers_url":"https://api.github.com/users/TheHydroImpulse/followers","following_url":"https://api.github.com/users/TheHydroImpulse/following{/other_user}","gists_url":"https://api.github.com/users/TheHydroImpulse/gists{/gist_id}","starred_url":"https://api.github.com/users/TheHydroImpulse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheHydroImpulse/subscriptions","organizations_url":"https://api.github.com/users/TheHydroImpulse/orgs","repos_url":"https://api.github.com/users/TheHydroImpulse/repos","events_url":"https://api.github.com/users/TheHydroImpulse/events{/privacy}","received_events_url":"https://api.github.com/users/TheHydroImpulse/received_events","type":"User","site_admin":false},"body":"Here we go.\r\n\r\nThoughts?","created_at":"2014-07-01T00:50:44Z","updated_at":"2014-07-01T01:44:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"31c8cd5f8bb71ef74bbbd3f8537e17f2b37a1001","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rfcs/pulls/148/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rfcs/pulls/148/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rfcs/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rust-lang/rfcs/issues/148/comments","statuses_url":"https://api.github.com/repos/rust-lang/rfcs/statuses/ddabf81652351791d807acb71a6ed5bcefe2bbe6","head":{"label":"TheHydroImpulse:type","ref":"type","sha":"ddabf81652351791d807acb71a6ed5bcefe2bbe6","user":{"login":"TheHydroImpulse","id":565790,"avatar_url":"https://avatars.githubusercontent.com/u/565790?","gravatar_id":"e58dfef0ae4af7a5f672bb89fa299ba8","url":"https://api.github.com/users/TheHydroImpulse","html_url":"https://github.com/TheHydroImpulse","followers_url":"https://api.github.com/users/TheHydroImpulse/followers","following_url":"https://api.github.com/users/TheHydroImpulse/following{/other_user}","gists_url":"https://api.github.com/users/TheHydroImpulse/gists{/gist_id}","starred_url":"https://api.github.com/users/TheHydroImpulse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheHydroImpulse/subscriptions","organizations_url":"https://api.github.com/users/TheHydroImpulse/orgs","repos_url":"https://api.github.com/users/TheHydroImpulse/repos","events_url":"https://api.github.com/users/TheHydroImpulse/events{/privacy}","received_events_url":"https://api.github.com/users/TheHydroImpulse/received_events","type":"User","site_admin":false},"repo":{"id":18214757,"name":"rfcs","full_name":"TheHydroImpulse/rfcs","owner":{"login":"TheHydroImpulse","id":565790,"avatar_url":"https://avatars.githubusercontent.com/u/565790?","gravatar_id":"e58dfef0ae4af7a5f672bb89fa299ba8","url":"https://api.github.com/users/TheHydroImpulse","html_url":"https://github.com/TheHydroImpulse","followers_url":"https://api.github.com/users/TheHydroImpulse/followers","following_url":"https://api.github.com/users/TheHydroImpulse/following{/other_user}","gists_url":"https://api.github.com/users/TheHydroImpulse/gists{/gist_id}","starred_url":"https://api.github.com/users/TheHydroImpulse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheHydroImpulse/subscriptions","organizations_url":"https://api.github.com/users/TheHydroImpulse/orgs","repos_url":"https://api.github.com/users/TheHydroImpulse/repos","events_url":"https://api.github.com/users/TheHydroImpulse/events{/privacy}","received_events_url":"https://api.github.com/users/TheHydroImpulse/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TheHydroImpulse/rfcs","description":"RFCs for changes to Rust","fork":true,"url":"https://api.github.com/repos/TheHydroImpulse/rfcs","forks_url":"https://api.github.com/repos/TheHydroImpulse/rfcs/forks","keys_url":"https://api.github.com/repos/TheHydroImpulse/rfcs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TheHydroImpulse/rfcs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TheHydroImpulse/rfcs/teams","hooks_url":"https://api.github.com/repos/TheHydroImpulse/rfcs/hooks","issue_events_url":"https://api.github.com/repos/TheHydroImpulse/rfcs/issues/events{/number}","events_url":"https://api.github.com/repos/TheHydroImpulse/rfcs/events","assignees_url":"https://api.github.com/repos/TheHydroImpulse/rfcs/assignees{/user}","branches_url":"https://api.github.com/repos/TheHydroImpulse/rfcs/branches{/branch}","tags_url":"https://api.github.com/repos/TheHydroImpulse/rfcs/tags","blobs_url":"https://api.github.com/repos/TheHydroImpulse/rfcs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TheHydroImpulse/rfcs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TheHydroImpulse/rfcs/git/refs{/sha}","trees_url":"https://api.github.com/repos/TheHydroImpulse/rfcs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TheHydroImpulse/rfcs/statuses/{sha}","languages_url":"https://api.github.com/repos/TheHydroImpulse/rfcs/languages","stargazers_url":"https://api.github.com/repos/TheHydroImpulse/rfcs/stargazers","contributors_url":"https://api.github.com/repos/TheHydroImpulse/rfcs/contributors","subscribers_url":"https://api.github.com/repos/TheHydroImpulse/rfcs/subscribers","subscription_url":"https://api.github.com/repos/TheHydroImpulse/rfcs/subscription","commits_url":"https://api.github.com/repos/TheHydroImpulse/rfcs/commits{/sha}","git_commits_url":"https://api.github.com/repos/TheHydroImpulse/rfcs/git/commits{/sha}","comments_url":"https://api.github.com/repos/TheHydroImpulse/rfcs/comments{/number}","issue_comment_url":"https://api.github.com/repos/TheHydroImpulse/rfcs/issues/comments/{number}","contents_url":"https://api.github.com/repos/TheHydroImpulse/rfcs/contents/{+path}","compare_url":"https://api.github.com/repos/TheHydroImpulse/rfcs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TheHydroImpulse/rfcs/merges","archive_url":"https://api.github.com/repos/TheHydroImpulse/rfcs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TheHydroImpulse/rfcs/downloads","issues_url":"https://api.github.com/repos/TheHydroImpulse/rfcs/issues{/number}","pulls_url":"https://api.github.com/repos/TheHydroImpulse/rfcs/pulls{/number}","milestones_url":"https://api.github.com/repos/TheHydroImpulse/rfcs/milestones{/number}","notifications_url":"https://api.github.com/repos/TheHydroImpulse/rfcs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TheHydroImpulse/rfcs/labels{/name}","releases_url":"https://api.github.com/repos/TheHydroImpulse/rfcs/releases{/id}","created_at":"2014-03-28T14:26:53Z","updated_at":"2014-05-10T21:55:35Z","pushed_at":"2014-07-01T01:39:28Z","git_url":"git://github.com/TheHydroImpulse/rfcs.git","ssh_url":"git@github.com:TheHydroImpulse/rfcs.git","clone_url":"https://github.com/TheHydroImpulse/rfcs.git","svn_url":"https://github.com/TheHydroImpulse/rfcs","homepage":"","size":178,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"c60c3317869c065893f1df103b5629b4a12eb577","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?","gravatar_id":"a4268b59e433144466a0f67cbcfd8cdc","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":17527989,"name":"rfcs","full_name":"rust-lang/rfcs","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?","gravatar_id":"a4268b59e433144466a0f67cbcfd8cdc","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rfcs","description":"RFCs for changes to Rust","fork":false,"url":"https://api.github.com/repos/rust-lang/rfcs","forks_url":"https://api.github.com/repos/rust-lang/rfcs/forks","keys_url":"https://api.github.com/repos/rust-lang/rfcs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rfcs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rfcs/teams","hooks_url":"https://api.github.com/repos/rust-lang/rfcs/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rfcs/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rfcs/events","assignees_url":"https://api.github.com/repos/rust-lang/rfcs/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rfcs/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rfcs/tags","blobs_url":"https://api.github.com/repos/rust-lang/rfcs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rfcs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rfcs/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rfcs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rfcs/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rfcs/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rfcs/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rfcs/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rfcs/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rfcs/subscription","commits_url":"https://api.github.com/repos/rust-lang/rfcs/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rfcs/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rfcs/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rfcs/issues/comments/{number}","contents_url":"https://api.github.com/repos/rust-lang/rfcs/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rfcs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rfcs/merges","archive_url":"https://api.github.com/repos/rust-lang/rfcs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rfcs/downloads","issues_url":"https://api.github.com/repos/rust-lang/rfcs/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rfcs/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rfcs/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rfcs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rfcs/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rfcs/releases{/id}","created_at":"2014-03-07T21:29:00Z","updated_at":"2014-06-27T14:29:50Z","pushed_at":"2014-06-30T22:38:40Z","git_url":"git://github.com/rust-lang/rfcs.git","ssh_url":"git@github.com:rust-lang/rfcs.git","clone_url":"https://github.com/rust-lang/rfcs.git","svn_url":"https://github.com/rust-lang/rfcs","homepage":"","size":3685,"stargazers_count":69,"watchers_count":69,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":68,"mirror_url":null,"open_issues_count":50,"forks":68,"open_issues":50,"watchers":69,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rfcs/pulls/148"},"html":{"href":"https://github.com/rust-lang/rfcs/pull/148"},"issue":{"href":"https://api.github.com/repos/rust-lang/rfcs/issues/148"},"comments":{"href":"https://api.github.com/repos/rust-lang/rfcs/issues/148/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rfcs/pulls/148/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rfcs/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rfcs/pulls/148/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rfcs/statuses/ddabf81652351791d807acb71a6ed5bcefe2bbe6"}}}}