GitHub PullRequestReviewCommentEvent at 2014-01-15 07:37:11
Repository: shark
Actor: rxin
Payload: {"comment":{"url":"https://api.github.com/repos/amplab/shark/pulls/comments/8888339","id":8888339,"diff_hunk":"@@ -178,4 +180,17 @@ object MapSplitPruning {\n       true\n     }\n   }\n+\n+  private def getIDStructField(field: StructField): IDStructField = {\n+    field match {\n+      case myField: MyField => {\n+        MapSplitPruningHelper.getStructFieldFromUnionOIField(myField)\n+          .asInstanceOf[IDStructField]\n+      }\n+      case idStructField: IDStructField => idStructField\n+      case otherFieldType: Any => {\n+        throw new Exception(\"Unrecognized StructField: \" + otherFieldType)","path":"src/main/scala/shark/execution/MapSplitPruning.scala","position":49,"original_position":49,"commit_id":"fcf5289bbee420e1885bcb04f9937bd1f4851705","original_commit_id":"fcf5289bbee420e1885bcb04f9937bd1f4851705","user":{"login":"rxin","id":323388,"avatar_url":"https://gravatar.com/avatar/73bfac91877fce35c6d20e16e9e53677?d=https%3A%2F%2Fidenticons.github.com%2F017ef876ba320362d11baf01bb584eee.png&r=x","gravatar_id":"73bfac91877fce35c6d20e16e9e53677","url":"https://api.github.com/users/rxin","html_url":"https://github.com/rxin","followers_url":"https://api.github.com/users/rxin/followers","following_url":"https://api.github.com/users/rxin/following{/other_user}","gists_url":"https://api.github.com/users/rxin/gists{/gist_id}","starred_url":"https://api.github.com/users/rxin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rxin/subscriptions","organizations_url":"https://api.github.com/users/rxin/orgs","repos_url":"https://api.github.com/users/rxin/repos","events_url":"https://api.github.com/users/rxin/events{/privacy}","received_events_url":"https://api.github.com/users/rxin/received_events","type":"User","site_admin":false},"body":"We should probably just let the test pass if there is an exception.","created_at":"2014-01-15T07:37:11Z","updated_at":"2014-01-15T07:37:11Z","html_url":"https://github.com/amplab/shark/pull/235#discussion_r8888339","pull_request_url":"https://api.github.com/repos/amplab/shark/pulls/235","_links":{"self":{"href":"https://api.github.com/repos/amplab/shark/pulls/comments/8888339"},"html":{"href":"https://github.com/amplab/shark/pull/235#discussion_r8888339"},"pull_request":{"href":"https://api.github.com/repos/amplab/shark/pulls/235"}}}}