GitHub PullRequestReviewCommentEvent at 2014-01-21 16:00:38
Repository: kuma
Actor: jezdez
Payload: {"comment":{"url":"https://api.github.com/repos/mozilla/kuma/pulls/comments/9041541","id":9041541,"diff_hunk":"@@ -2351,6 +2351,8 @@ def test_raw_editor_safety_filter(self):\n     def test_raw_with_editing_links_source(self):\n         \"\"\"The raw source for a document can be requested, with section editing\n         links\"\"\"\n+        raise SkipTest(\"Section editing is disabled & broken for now\")","path":"apps/wiki/tests/test_views.py","position":13,"original_position":13,"commit_id":"3aec0518ad87427bd9b11afc57c6b77bbf45c363","original_commit_id":"3aec0518ad87427bd9b11afc57c6b77bbf45c363","user":{"login":"jezdez","id":1610,"avatar_url":"https://gravatar.com/avatar/cf3595fa166bfb4106211e1697f39f94?d=https%3A%2F%2Fidenticons.github.com%2Fa14ac55a4f27472c5d894ec1c3c743d2.png&r=x","gravatar_id":"cf3595fa166bfb4106211e1697f39f94","url":"https://api.github.com/users/jezdez","html_url":"https://github.com/jezdez","followers_url":"https://api.github.com/users/jezdez/followers","following_url":"https://api.github.com/users/jezdez/following{/other_user}","gists_url":"https://api.github.com/users/jezdez/gists{/gist_id}","starred_url":"https://api.github.com/users/jezdez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jezdez/subscriptions","organizations_url":"https://api.github.com/users/jezdez/orgs","repos_url":"https://api.github.com/users/jezdez/repos","events_url":"https://api.github.com/users/jezdez/events{/privacy}","received_events_url":"https://api.github.com/users/jezdez/received_events","type":"User","site_admin":false},"body":"Hm, but this is the thing, if the tests are just skipped they don't make any sense in the first place. I've seen tons of those SkipTest tests, this is *really* bad testing practice. I don't know why all the other tests are being skipped, this time I actually see it happening and want to make sure to state the obvious. This is where our technical debt comes from. No offense to the past development intended, mind you.","created_at":"2014-01-21T16:00:38Z","updated_at":"2014-01-21T16:00:38Z","html_url":"https://github.com/mozilla/kuma/pull/1863#discussion_r9041541","pull_request_url":"https://api.github.com/repos/mozilla/kuma/pulls/1863","_links":{"self":{"href":"https://api.github.com/repos/mozilla/kuma/pulls/comments/9041541"},"html":{"href":"https://github.com/mozilla/kuma/pull/1863#discussion_r9041541"},"pull_request":{"href":"https://api.github.com/repos/mozilla/kuma/pulls/1863"}}}}