GitHub PullRequestReviewCommentEvent at 2014-08-08 22:48:58
Repository: kazoo
Actor: k-anderson
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/2600hz/kazoo/pulls/comments/16020578","id":16020578,"diff_hunk":"@@ -719,6 +719,45 @@ publish_leg_addition(Props) ->\n                                               ,ecallmgr_call_events:swap_call_legs(Props)),\n     ecallmgr_call_events:publish_event(Event).\n \n+-spec maybe_add_cleg(wh_proplist(), api_binary(), api_binary(), state()) -> state().\n+maybe_add_cleg(Props, OtherLeg, LegId, #state{other_legs=Legs}=State) ->\n+    case lists:member(OtherLeg, Legs) of\n+        'true' -> add_cleg(Props, OtherLeg, LegId, State);\n+        'false' -> State\n+    end.\n+\n+-spec add_cleg(wh_proplist(), api_binary(), api_binary(), state()) -> state().\n+add_cleg(Props, OtherLeg, LegId, #state{other_legs=Legs\n+                             ,callid=CallId\n+                            }=State) ->\n+    case is_atom(LegId) orelse lists:member(LegId, Legs) of\n+        'true' -> State;\n+        'false' ->\n+            lager:debug(\"added cleg ~s to call\", [LegId]),\n+            ConsumerPid = wh_amqp_channel:consumer_pid(),\n+            _ = spawn(fun() ->","path":"applications/ecallmgr/src/ecallmgr_call_control.erl","position":33,"original_position":33,"commit_id":"df95775812d3f0cc98f1e94192f7bcb3730c5866","original_commit_id":"df95775812d3f0cc98f1e94192f7bcb3730c5866","user":{"login":"k-anderson","id":742778,"avatar_url":"https://avatars.githubusercontent.com/u/742778?v=2","gravatar_id":"228a956ee83a3d914051cb0f7be08efa","url":"https://api.github.com/users/k-anderson","html_url":"https://github.com/k-anderson","followers_url":"https://api.github.com/users/k-anderson/followers","following_url":"https://api.github.com/users/k-anderson/following{/other_user}","gists_url":"https://api.github.com/users/k-anderson/gists{/gist_id}","starred_url":"https://api.github.com/users/k-anderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k-anderson/subscriptions","organizations_url":"https://api.github.com/users/k-anderson/orgs","repos_url":"https://api.github.com/users/k-anderson/repos","events_url":"https://api.github.com/users/k-anderson/events{/privacy}","received_events_url":"https://api.github.com/users/k-anderson/received_events","type":"User","site_admin":false},"body":"Why not use the AMQP worker to publish?","created_at":"2014-08-08T22:48:58Z","updated_at":"2014-08-08T22:48:58Z","html_url":"https://github.com/2600hz/kazoo/pull/444#discussion_r16020578","pull_request_url":"https://api.github.com/repos/2600hz/kazoo/pulls/444","_links":{"self":{"href":"https://api.github.com/repos/2600hz/kazoo/pulls/comments/16020578"},"html":{"href":"https://github.com/2600hz/kazoo/pull/444#discussion_r16020578"},"pull_request":{"href":"https://api.github.com/repos/2600hz/kazoo/pulls/444"}}},"pull_request":{"url":"https://api.github.com/repos/2600hz/kazoo/pulls/444","id":19246668,"html_url":"https://github.com/2600hz/kazoo/pull/444","diff_url":"https://github.com/2600hz/kazoo/pull/444.diff","patch_url":"https://github.com/2600hz/kazoo/pull/444.patch","issue_url":"https://api.github.com/repos/2600hz/kazoo/issues/444","number":444,"state":"open","title":"Kazoo 806","user":{"login":"lazedo","id":770988,"avatar_url":"https://avatars.githubusercontent.com/u/770988?v=2","gravatar_id":"de4acd189e0aca77abbc2595ec156b64","url":"https://api.github.com/users/lazedo","html_url":"https://github.com/lazedo","followers_url":"https://api.github.com/users/lazedo/followers","following_url":"https://api.github.com/users/lazedo/following{/other_user}","gists_url":"https://api.github.com/users/lazedo/gists{/gist_id}","starred_url":"https://api.github.com/users/lazedo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lazedo/subscriptions","organizations_url":"https://api.github.com/users/lazedo/orgs","repos_url":"https://api.github.com/users/lazedo/repos","events_url":"https://api.github.com/users/lazedo/events{/privacy}","received_events_url":"https://api.github.com/users/lazedo/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-08-02T14:57:57Z","updated_at":"2014-08-08T22:48:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"66dac49a7189904a10756c7cb134ce88138823db","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/2600hz/kazoo/pulls/444/commits","review_comments_url":"https://api.github.com/repos/2600hz/kazoo/pulls/444/comments","review_comment_url":"https://api.github.com/repos/2600hz/kazoo/pulls/comments/{number}","comments_url":"https://api.github.com/repos/2600hz/kazoo/issues/444/comments","statuses_url":"https://api.github.com/repos/2600hz/kazoo/statuses/df95775812d3f0cc98f1e94192f7bcb3730c5866","head":{"label":"2600hz:KAZOO-806","ref":"KAZOO-806","sha":"df95775812d3f0cc98f1e94192f7bcb3730c5866","user":{"login":"2600hz","id":408801,"avatar_url":"https://avatars.githubusercontent.com/u/408801?v=2","gravatar_id":"09d0417930218eb0a86974e55ccdc498","url":"https://api.github.com/users/2600hz","html_url":"https://github.com/2600hz","followers_url":"https://api.github.com/users/2600hz/followers","following_url":"https://api.github.com/users/2600hz/following{/other_user}","gists_url":"https://api.github.com/users/2600hz/gists{/gist_id}","starred_url":"https://api.github.com/users/2600hz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/2600hz/subscriptions","organizations_url":"https://api.github.com/users/2600hz/orgs","repos_url":"https://api.github.com/users/2600hz/repos","events_url":"https://api.github.com/users/2600hz/events{/privacy}","received_events_url":"https://api.github.com/users/2600hz/received_events","type":"Organization","site_admin":false},"repo":{"id":2966241,"name":"kazoo","full_name":"2600hz/kazoo","owner":{"login":"2600hz","id":408801,"avatar_url":"https://avatars.githubusercontent.com/u/408801?v=2","gravatar_id":"09d0417930218eb0a86974e55ccdc498","url":"https://api.github.com/users/2600hz","html_url":"https://github.com/2600hz","followers_url":"https://api.github.com/users/2600hz/followers","following_url":"https://api.github.com/users/2600hz/following{/other_user}","gists_url":"https://api.github.com/users/2600hz/gists{/gist_id}","starred_url":"https://api.github.com/users/2600hz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/2600hz/subscriptions","organizations_url":"https://api.github.com/users/2600hz/orgs","repos_url":"https://api.github.com/users/2600hz/repos","events_url":"https://api.github.com/users/2600hz/events{/privacy}","received_events_url":"https://api.github.com/users/2600hz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/2600hz/kazoo","description":"","fork":false,"url":"https://api.github.com/repos/2600hz/kazoo","forks_url":"https://api.github.com/repos/2600hz/kazoo/forks","keys_url":"https://api.github.com/repos/2600hz/kazoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/2600hz/kazoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/2600hz/kazoo/teams","hooks_url":"https://api.github.com/repos/2600hz/kazoo/hooks","issue_events_url":"https://api.github.com/repos/2600hz/kazoo/issues/events{/number}","events_url":"https://api.github.com/repos/2600hz/kazoo/events","assignees_url":"https://api.github.com/repos/2600hz/kazoo/assignees{/user}","branches_url":"https://api.github.com/repos/2600hz/kazoo/branches{/branch}","tags_url":"https://api.github.com/repos/2600hz/kazoo/tags","blobs_url":"https://api.github.com/repos/2600hz/kazoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/2600hz/kazoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/2600hz/kazoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/2600hz/kazoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/2600hz/kazoo/statuses/{sha}","languages_url":"https://api.github.com/repos/2600hz/kazoo/languages","stargazers_url":"https://api.github.com/repos/2600hz/kazoo/stargazers","contributors_url":"https://api.github.com/repos/2600hz/kazoo/contributors","subscribers_url":"https://api.github.com/repos/2600hz/kazoo/subscribers","subscription_url":"https://api.github.com/repos/2600hz/kazoo/subscription","commits_url":"https://api.github.com/repos/2600hz/kazoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/2600hz/kazoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/2600hz/kazoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/2600hz/kazoo/issues/comments/{number}","contents_url":"https://api.github.com/repos/2600hz/kazoo/contents/{+path}","compare_url":"https://api.github.com/repos/2600hz/kazoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/2600hz/kazoo/merges","archive_url":"https://api.github.com/repos/2600hz/kazoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/2600hz/kazoo/downloads","issues_url":"https://api.github.com/repos/2600hz/kazoo/issues{/number}","pulls_url":"https://api.github.com/repos/2600hz/kazoo/pulls{/number}","milestones_url":"https://api.github.com/repos/2600hz/kazoo/milestones{/number}","notifications_url":"https://api.github.com/repos/2600hz/kazoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/2600hz/kazoo/labels{/name}","releases_url":"https://api.github.com/repos/2600hz/kazoo/releases{/id}","created_at":"2011-12-12T18:08:02Z","updated_at":"2014-08-08T06:57:01Z","pushed_at":"2014-08-08T22:47:22Z","git_url":"git://github.com/2600hz/kazoo.git","ssh_url":"git@github.com:2600hz/kazoo.git","clone_url":"https://github.com/2600hz/kazoo.git","svn_url":"https://github.com/2600hz/kazoo","homepage":"","size":431569,"stargazers_count":177,"watchers_count":177,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":87,"mirror_url":null,"open_issues_count":8,"forks":87,"open_issues":8,"watchers":177,"default_branch":"master"}},"base":{"label":"2600hz:master","ref":"master","sha":"985550cc4c5091668f5e1ef1c6c1b2a0607bfaf0","user":{"login":"2600hz","id":408801,"avatar_url":"https://avatars.githubusercontent.com/u/408801?v=2","gravatar_id":"09d0417930218eb0a86974e55ccdc498","url":"https://api.github.com/users/2600hz","html_url":"https://github.com/2600hz","followers_url":"https://api.github.com/users/2600hz/followers","following_url":"https://api.github.com/users/2600hz/following{/other_user}","gists_url":"https://api.github.com/users/2600hz/gists{/gist_id}","starred_url":"https://api.github.com/users/2600hz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/2600hz/subscriptions","organizations_url":"https://api.github.com/users/2600hz/orgs","repos_url":"https://api.github.com/users/2600hz/repos","events_url":"https://api.github.com/users/2600hz/events{/privacy}","received_events_url":"https://api.github.com/users/2600hz/received_events","type":"Organization","site_admin":false},"repo":{"id":2966241,"name":"kazoo","full_name":"2600hz/kazoo","owner":{"login":"2600hz","id":408801,"avatar_url":"https://avatars.githubusercontent.com/u/408801?v=2","gravatar_id":"09d0417930218eb0a86974e55ccdc498","url":"https://api.github.com/users/2600hz","html_url":"https://github.com/2600hz","followers_url":"https://api.github.com/users/2600hz/followers","following_url":"https://api.github.com/users/2600hz/following{/other_user}","gists_url":"https://api.github.com/users/2600hz/gists{/gist_id}","starred_url":"https://api.github.com/users/2600hz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/2600hz/subscriptions","organizations_url":"https://api.github.com/users/2600hz/orgs","repos_url":"https://api.github.com/users/2600hz/repos","events_url":"https://api.github.com/users/2600hz/events{/privacy}","received_events_url":"https://api.github.com/users/2600hz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/2600hz/kazoo","description":"","fork":false,"url":"https://api.github.com/repos/2600hz/kazoo","forks_url":"https://api.github.com/repos/2600hz/kazoo/forks","keys_url":"https://api.github.com/repos/2600hz/kazoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/2600hz/kazoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/2600hz/kazoo/teams","hooks_url":"https://api.github.com/repos/2600hz/kazoo/hooks","issue_events_url":"https://api.github.com/repos/2600hz/kazoo/issues/events{/number}","events_url":"https://api.github.com/repos/2600hz/kazoo/events","assignees_url":"https://api.github.com/repos/2600hz/kazoo/assignees{/user}","branches_url":"https://api.github.com/repos/2600hz/kazoo/branches{/branch}","tags_url":"https://api.github.com/repos/2600hz/kazoo/tags","blobs_url":"https://api.github.com/repos/2600hz/kazoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/2600hz/kazoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/2600hz/kazoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/2600hz/kazoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/2600hz/kazoo/statuses/{sha}","languages_url":"https://api.github.com/repos/2600hz/kazoo/languages","stargazers_url":"https://api.github.com/repos/2600hz/kazoo/stargazers","contributors_url":"https://api.github.com/repos/2600hz/kazoo/contributors","subscribers_url":"https://api.github.com/repos/2600hz/kazoo/subscribers","subscription_url":"https://api.github.com/repos/2600hz/kazoo/subscription","commits_url":"https://api.github.com/repos/2600hz/kazoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/2600hz/kazoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/2600hz/kazoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/2600hz/kazoo/issues/comments/{number}","contents_url":"https://api.github.com/repos/2600hz/kazoo/contents/{+path}","compare_url":"https://api.github.com/repos/2600hz/kazoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/2600hz/kazoo/merges","archive_url":"https://api.github.com/repos/2600hz/kazoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/2600hz/kazoo/downloads","issues_url":"https://api.github.com/repos/2600hz/kazoo/issues{/number}","pulls_url":"https://api.github.com/repos/2600hz/kazoo/pulls{/number}","milestones_url":"https://api.github.com/repos/2600hz/kazoo/milestones{/number}","notifications_url":"https://api.github.com/repos/2600hz/kazoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/2600hz/kazoo/labels{/name}","releases_url":"https://api.github.com/repos/2600hz/kazoo/releases{/id}","created_at":"2011-12-12T18:08:02Z","updated_at":"2014-08-08T06:57:01Z","pushed_at":"2014-08-08T22:47:22Z","git_url":"git://github.com/2600hz/kazoo.git","ssh_url":"git@github.com:2600hz/kazoo.git","clone_url":"https://github.com/2600hz/kazoo.git","svn_url":"https://github.com/2600hz/kazoo","homepage":"","size":431569,"stargazers_count":177,"watchers_count":177,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":87,"mirror_url":null,"open_issues_count":8,"forks":87,"open_issues":8,"watchers":177,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/2600hz/kazoo/pulls/444"},"html":{"href":"https://github.com/2600hz/kazoo/pull/444"},"issue":{"href":"https://api.github.com/repos/2600hz/kazoo/issues/444"},"comments":{"href":"https://api.github.com/repos/2600hz/kazoo/issues/444/comments"},"review_comments":{"href":"https://api.github.com/repos/2600hz/kazoo/pulls/444/comments"},"review_comment":{"href":"https://api.github.com/repos/2600hz/kazoo/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/2600hz/kazoo/pulls/444/commits"},"statuses":{"href":"https://api.github.com/repos/2600hz/kazoo/statuses/df95775812d3f0cc98f1e94192f7bcb3730c5866"}}}}