GitHub PullRequestReviewCommentEvent at 2014-06-18 14:42:48
Repository: mars-game
Actor: ajiraffe
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/virtual-world-framework/mars-game/pulls/comments/13918399","id":13918399,"diff_hunk":"@@ -338,6 +395,30 @@ this.clauseSet.onScenarioStart = function( params, context, callback ) {\n     };\n }\n \n+this.clauseSet.onIntroScreensComplete = function( params, context, callback ) {\n+    if ( params ) {\n+        self.logger.warnx( \"doOnce\", \"This clause doesn't take any arguments.\" );","path":"source/triggers/booleanFunctionFactory.js","position":101,"original_position":101,"commit_id":"1ee284b6825f77b43426c6ccf08e6c3221ccac7b","original_commit_id":"1ee284b6825f77b43426c6ccf08e6c3221ccac7b","user":{"login":"ajiraffe","id":3487395,"avatar_url":"https://avatars.githubusercontent.com/u/3487395?","gravatar_id":"e54a26bfc5193bc4591586adc205b4b1","url":"https://api.github.com/users/ajiraffe","html_url":"https://github.com/ajiraffe","followers_url":"https://api.github.com/users/ajiraffe/followers","following_url":"https://api.github.com/users/ajiraffe/following{/other_user}","gists_url":"https://api.github.com/users/ajiraffe/gists{/gist_id}","starred_url":"https://api.github.com/users/ajiraffe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajiraffe/subscriptions","organizations_url":"https://api.github.com/users/ajiraffe/orgs","repos_url":"https://api.github.com/users/ajiraffe/repos","events_url":"https://api.github.com/users/ajiraffe/events{/privacy}","received_events_url":"https://api.github.com/users/ajiraffe/received_events","type":"User","site_admin":false},"body":"This is minor, but from `doOnce` to `onIntroScreensComplete` here.","created_at":"2014-06-18T14:42:48Z","updated_at":"2014-06-18T14:42:48Z","html_url":"https://github.com/virtual-world-framework/mars-game/pull/129#discussion_r13918399","pull_request_url":"https://api.github.com/repos/virtual-world-framework/mars-game/pulls/129","_links":{"self":{"href":"https://api.github.com/repos/virtual-world-framework/mars-game/pulls/comments/13918399"},"html":{"href":"https://github.com/virtual-world-framework/mars-game/pull/129#discussion_r13918399"},"pull_request":{"href":"https://api.github.com/repos/virtual-world-framework/mars-game/pulls/129"}}},"pull_request":{"url":"https://api.github.com/repos/virtual-world-framework/mars-game/pulls/129","id":17271830,"html_url":"https://github.com/virtual-world-framework/mars-game/pull/129","diff_url":"https://github.com/virtual-world-framework/mars-game/pull/129.diff","patch_url":"https://github.com/virtual-world-framework/mars-game/pull/129.patch","issue_url":"https://api.github.com/repos/virtual-world-framework/mars-game/issues/129","number":129,"state":"open","title":"Intro screen scenario","user":{"login":"kadst43","id":7387431,"avatar_url":"https://avatars.githubusercontent.com/u/7387431?","gravatar_id":"526adb01dea815536bb7e4b61ee9bb28","url":"https://api.github.com/users/kadst43","html_url":"https://github.com/kadst43","followers_url":"https://api.github.com/users/kadst43/followers","following_url":"https://api.github.com/users/kadst43/following{/other_user}","gists_url":"https://api.github.com/users/kadst43/gists{/gist_id}","starred_url":"https://api.github.com/users/kadst43/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kadst43/subscriptions","organizations_url":"https://api.github.com/users/kadst43/orgs","repos_url":"https://api.github.com/users/kadst43/repos","events_url":"https://api.github.com/users/kadst43/events{/privacy}","received_events_url":"https://api.github.com/users/kadst43/received_events","type":"User","site_admin":false},"body":"@AmbientOSX, @ajiraffe, @BrettASwift, @scottnc27603 \r\n\r\nI added the intro screen scenario, made it so that success doesn't have to have a popup, made it so that the scenario still advances when it doesn't, mucked around with the sounds that get played (and the names of the sounds that get played), hooked up a trigger that fires a VO when you add the first forward block in scenario 1, ... I think that's about it.\r\n\r\nThere's probably bits and pieces in there for all 4 of you to check out.","created_at":"2014-06-18T01:50:18Z","updated_at":"2014-06-18T14:42:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9b4a0e0ba1daa9f0995cd0d27a38331031c3ea92","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/virtual-world-framework/mars-game/pulls/129/commits","review_comments_url":"https://api.github.com/repos/virtual-world-framework/mars-game/pulls/129/comments","review_comment_url":"https://api.github.com/repos/virtual-world-framework/mars-game/pulls/comments/{number}","comments_url":"https://api.github.com/repos/virtual-world-framework/mars-game/issues/129/comments","statuses_url":"https://api.github.com/repos/virtual-world-framework/mars-game/statuses/1ee284b6825f77b43426c6ccf08e6c3221ccac7b","head":{"label":"virtual-world-framework:master","ref":"master","sha":"1ee284b6825f77b43426c6ccf08e6c3221ccac7b","user":{"login":"virtual-world-framework","id":1552130,"avatar_url":"https://avatars.githubusercontent.com/u/1552130?","gravatar_id":"4030558125d47329a00e5378c95d401b","url":"https://api.github.com/users/virtual-world-framework","html_url":"https://github.com/virtual-world-framework","followers_url":"https://api.github.com/users/virtual-world-framework/followers","following_url":"https://api.github.com/users/virtual-world-framework/following{/other_user}","gists_url":"https://api.github.com/users/virtual-world-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/virtual-world-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/virtual-world-framework/subscriptions","organizations_url":"https://api.github.com/users/virtual-world-framework/orgs","repos_url":"https://api.github.com/users/virtual-world-framework/repos","events_url":"https://api.github.com/users/virtual-world-framework/events{/privacy}","received_events_url":"https://api.github.com/users/virtual-world-framework/received_events","type":"Organization","site_admin":false},"repo":{"id":17410926,"name":"mars-game","full_name":"virtual-world-framework/mars-game","owner":{"login":"virtual-world-framework","id":1552130,"avatar_url":"https://avatars.githubusercontent.com/u/1552130?","gravatar_id":"4030558125d47329a00e5378c95d401b","url":"https://api.github.com/users/virtual-world-framework","html_url":"https://github.com/virtual-world-framework","followers_url":"https://api.github.com/users/virtual-world-framework/followers","following_url":"https://api.github.com/users/virtual-world-framework/following{/other_user}","gists_url":"https://api.github.com/users/virtual-world-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/virtual-world-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/virtual-world-framework/subscriptions","organizations_url":"https://api.github.com/users/virtual-world-framework/orgs","repos_url":"https://api.github.com/users/virtual-world-framework/repos","events_url":"https://api.github.com/users/virtual-world-framework/events{/privacy}","received_events_url":"https://api.github.com/users/virtual-world-framework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/virtual-world-framework/mars-game","description":"A game designed to teach STEM concepts to high school students under the ADL True Game-based Learning project.","fork":false,"url":"https://api.github.com/repos/virtual-world-framework/mars-game","forks_url":"https://api.github.com/repos/virtual-world-framework/mars-game/forks","keys_url":"https://api.github.com/repos/virtual-world-framework/mars-game/keys{/key_id}","collaborators_url":"https://api.github.com/repos/virtual-world-framework/mars-game/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/virtual-world-framework/mars-game/teams","hooks_url":"https://api.github.com/repos/virtual-world-framework/mars-game/hooks","issue_events_url":"https://api.github.com/repos/virtual-world-framework/mars-game/issues/events{/number}","events_url":"https://api.github.com/repos/virtual-world-framework/mars-game/events","assignees_url":"https://api.github.com/repos/virtual-world-framework/mars-game/assignees{/user}","branches_url":"https://api.github.com/repos/virtual-world-framework/mars-game/branches{/branch}","tags_url":"https://api.github.com/repos/virtual-world-framework/mars-game/tags","blobs_url":"https://api.github.com/repos/virtual-world-framework/mars-game/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/virtual-world-framework/mars-game/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/virtual-world-framework/mars-game/git/refs{/sha}","trees_url":"https://api.github.com/repos/virtual-world-framework/mars-game/git/trees{/sha}","statuses_url":"https://api.github.com/repos/virtual-world-framework/mars-game/statuses/{sha}","languages_url":"https://api.github.com/repos/virtual-world-framework/mars-game/languages","stargazers_url":"https://api.github.com/repos/virtual-world-framework/mars-game/stargazers","contributors_url":"https://api.github.com/repos/virtual-world-framework/mars-game/contributors","subscribers_url":"https://api.github.com/repos/virtual-world-framework/mars-game/subscribers","subscription_url":"https://api.github.com/repos/virtual-world-framework/mars-game/subscription","commits_url":"https://api.github.com/repos/virtual-world-framework/mars-game/commits{/sha}","git_commits_url":"https://api.github.com/repos/virtual-world-framework/mars-game/git/commits{/sha}","comments_url":"https://api.github.com/repos/virtual-world-framework/mars-game/comments{/number}","issue_comment_url":"https://api.github.com/repos/virtual-world-framework/mars-game/issues/comments/{number}","contents_url":"https://api.github.com/repos/virtual-world-framework/mars-game/contents/{+path}","compare_url":"https://api.github.com/repos/virtual-world-framework/mars-game/compare/{base}...{head}","merges_url":"https://api.github.com/repos/virtual-world-framework/mars-game/merges","archive_url":"https://api.github.com/repos/virtual-world-framework/mars-game/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/virtual-world-framework/mars-game/downloads","issues_url":"https://api.github.com/repos/virtual-world-framework/mars-game/issues{/number}","pulls_url":"https://api.github.com/repos/virtual-world-framework/mars-game/pulls{/number}","milestones_url":"https://api.github.com/repos/virtual-world-framework/mars-game/milestones{/number}","notifications_url":"https://api.github.com/repos/virtual-world-framework/mars-game/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/virtual-world-framework/mars-game/labels{/name}","releases_url":"https://api.github.com/repos/virtual-world-framework/mars-game/releases{/id}","created_at":"2014-03-04T17:43:02Z","updated_at":"2014-06-18T14:08:43Z","pushed_at":"2014-06-18T14:06:08Z","git_url":"git://github.com/virtual-world-framework/mars-game.git","ssh_url":"git@github.com:virtual-world-framework/mars-game.git","clone_url":"https://github.com/virtual-world-framework/mars-game.git","svn_url":"https://github.com/virtual-world-framework/mars-game","homepage":"","size":662084,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"virtual-world-framework:introScenario","ref":"introScenario","sha":"998d38b362dd2c41be637a977ac75abd622faef2","user":{"login":"virtual-world-framework","id":1552130,"avatar_url":"https://avatars.githubusercontent.com/u/1552130?","gravatar_id":"4030558125d47329a00e5378c95d401b","url":"https://api.github.com/users/virtual-world-framework","html_url":"https://github.com/virtual-world-framework","followers_url":"https://api.github.com/users/virtual-world-framework/followers","following_url":"https://api.github.com/users/virtual-world-framework/following{/other_user}","gists_url":"https://api.github.com/users/virtual-world-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/virtual-world-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/virtual-world-framework/subscriptions","organizations_url":"https://api.github.com/users/virtual-world-framework/orgs","repos_url":"https://api.github.com/users/virtual-world-framework/repos","events_url":"https://api.github.com/users/virtual-world-framework/events{/privacy}","received_events_url":"https://api.github.com/users/virtual-world-framework/received_events","type":"Organization","site_admin":false},"repo":{"id":17410926,"name":"mars-game","full_name":"virtual-world-framework/mars-game","owner":{"login":"virtual-world-framework","id":1552130,"avatar_url":"https://avatars.githubusercontent.com/u/1552130?","gravatar_id":"4030558125d47329a00e5378c95d401b","url":"https://api.github.com/users/virtual-world-framework","html_url":"https://github.com/virtual-world-framework","followers_url":"https://api.github.com/users/virtual-world-framework/followers","following_url":"https://api.github.com/users/virtual-world-framework/following{/other_user}","gists_url":"https://api.github.com/users/virtual-world-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/virtual-world-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/virtual-world-framework/subscriptions","organizations_url":"https://api.github.com/users/virtual-world-framework/orgs","repos_url":"https://api.github.com/users/virtual-world-framework/repos","events_url":"https://api.github.com/users/virtual-world-framework/events{/privacy}","received_events_url":"https://api.github.com/users/virtual-world-framework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/virtual-world-framework/mars-game","description":"A game designed to teach STEM concepts to high school students under the ADL True Game-based Learning project.","fork":false,"url":"https://api.github.com/repos/virtual-world-framework/mars-game","forks_url":"https://api.github.com/repos/virtual-world-framework/mars-game/forks","keys_url":"https://api.github.com/repos/virtual-world-framework/mars-game/keys{/key_id}","collaborators_url":"https://api.github.com/repos/virtual-world-framework/mars-game/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/virtual-world-framework/mars-game/teams","hooks_url":"https://api.github.com/repos/virtual-world-framework/mars-game/hooks","issue_events_url":"https://api.github.com/repos/virtual-world-framework/mars-game/issues/events{/number}","events_url":"https://api.github.com/repos/virtual-world-framework/mars-game/events","assignees_url":"https://api.github.com/repos/virtual-world-framework/mars-game/assignees{/user}","branches_url":"https://api.github.com/repos/virtual-world-framework/mars-game/branches{/branch}","tags_url":"https://api.github.com/repos/virtual-world-framework/mars-game/tags","blobs_url":"https://api.github.com/repos/virtual-world-framework/mars-game/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/virtual-world-framework/mars-game/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/virtual-world-framework/mars-game/git/refs{/sha}","trees_url":"https://api.github.com/repos/virtual-world-framework/mars-game/git/trees{/sha}","statuses_url":"https://api.github.com/repos/virtual-world-framework/mars-game/statuses/{sha}","languages_url":"https://api.github.com/repos/virtual-world-framework/mars-game/languages","stargazers_url":"https://api.github.com/repos/virtual-world-framework/mars-game/stargazers","contributors_url":"https://api.github.com/repos/virtual-world-framework/mars-game/contributors","subscribers_url":"https://api.github.com/repos/virtual-world-framework/mars-game/subscribers","subscription_url":"https://api.github.com/repos/virtual-world-framework/mars-game/subscription","commits_url":"https://api.github.com/repos/virtual-world-framework/mars-game/commits{/sha}","git_commits_url":"https://api.github.com/repos/virtual-world-framework/mars-game/git/commits{/sha}","comments_url":"https://api.github.com/repos/virtual-world-framework/mars-game/comments{/number}","issue_comment_url":"https://api.github.com/repos/virtual-world-framework/mars-game/issues/comments/{number}","contents_url":"https://api.github.com/repos/virtual-world-framework/mars-game/contents/{+path}","compare_url":"https://api.github.com/repos/virtual-world-framework/mars-game/compare/{base}...{head}","merges_url":"https://api.github.com/repos/virtual-world-framework/mars-game/merges","archive_url":"https://api.github.com/repos/virtual-world-framework/mars-game/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/virtual-world-framework/mars-game/downloads","issues_url":"https://api.github.com/repos/virtual-world-framework/mars-game/issues{/number}","pulls_url":"https://api.github.com/repos/virtual-world-framework/mars-game/pulls{/number}","milestones_url":"https://api.github.com/repos/virtual-world-framework/mars-game/milestones{/number}","notifications_url":"https://api.github.com/repos/virtual-world-framework/mars-game/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/virtual-world-framework/mars-game/labels{/name}","releases_url":"https://api.github.com/repos/virtual-world-framework/mars-game/releases{/id}","created_at":"2014-03-04T17:43:02Z","updated_at":"2014-06-18T14:08:43Z","pushed_at":"2014-06-18T14:06:08Z","git_url":"git://github.com/virtual-world-framework/mars-game.git","ssh_url":"git@github.com:virtual-world-framework/mars-game.git","clone_url":"https://github.com/virtual-world-framework/mars-game.git","svn_url":"https://github.com/virtual-world-framework/mars-game","homepage":"","size":662084,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/virtual-world-framework/mars-game/pulls/129"},"html":{"href":"https://github.com/virtual-world-framework/mars-game/pull/129"},"issue":{"href":"https://api.github.com/repos/virtual-world-framework/mars-game/issues/129"},"comments":{"href":"https://api.github.com/repos/virtual-world-framework/mars-game/issues/129/comments"},"review_comments":{"href":"https://api.github.com/repos/virtual-world-framework/mars-game/pulls/129/comments"},"review_comment":{"href":"https://api.github.com/repos/virtual-world-framework/mars-game/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/virtual-world-framework/mars-game/pulls/129/commits"},"statuses":{"href":"https://api.github.com/repos/virtual-world-framework/mars-game/statuses/1ee284b6825f77b43426c6ccf08e6c3221ccac7b"}}}}