GitHub PullRequestReviewCommentEvent at 2014-09-26 22:37:47
Repository: portfolio
Actor: houndci
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/jereln/portfolio/pulls/comments/18117760","id":18117760,"diff_hunk":"@@ -1,41 +1,41 @@\n require 'test_helper'\n \n-feature 'As an author, I want create articles so that the editor can publish them' do\n-\tscenario 'creating a post' do\n-\t\tsign_in\n-\t\tvisit new_article_path\n-\t\tmake_new_article\n+feature 'As an author, I want create articles' do\n+  scenario 'creating a post' do\n+    sign_in\n+    visit new_article_path\n+    make_new_article\n \n-\t\tpage.must_have_content articles(:first).title\n-\t\tpage.must_have_content articles(:first).body\n-\t\tpage.must_have_content 'Editor'\n-\t\tpage.must_have_content 'successfully'\n-\t\tpage.has_css? '#author'\n-\t\tpage.must_have_content 'unpublished'\n-\tend\n+    page.must_have_content articles(:first).title\n+    page.must_have_content articles(:first).body\n+    page.must_have_content 'Editor'\n+    page.must_have_content 'successfully'\n+    page.has_css? '#author'\n+    page.must_have_content 'unpublished'\n+  end\n \n-\tscenario 'unauthenticated user cannot visit new_article_path' do\n-\t\tvisit new_article_path\n-\t\tpage.must_have_content \"You need to sign in or sign up before continuing\"\n-\tend\n+  scenario 'unauthenticated user cannot visit new_article_path' do\n+    visit new_article_path\n+    page.must_have_content 'You need to sign in or sign up before continuing'","path":"test/features/articles/create_an_article_test.rb","position":35,"original_position":35,"commit_id":"fae034ebddc728f241d52d59663187f9ca3a5a39","original_commit_id":"fae034ebddc728f241d52d59663187f9ca3a5a39","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=2","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.","created_at":"2014-09-26T22:37:47Z","updated_at":"2014-09-26T22:37:47Z","html_url":"https://github.com/jereln/portfolio/pull/31#discussion_r18117760","pull_request_url":"https://api.github.com/repos/jereln/portfolio/pulls/31","_links":{"self":{"href":"https://api.github.com/repos/jereln/portfolio/pulls/comments/18117760"},"html":{"href":"https://github.com/jereln/portfolio/pull/31#discussion_r18117760"},"pull_request":{"href":"https://api.github.com/repos/jereln/portfolio/pulls/31"}}},"pull_request":{"url":"https://api.github.com/repos/jereln/portfolio/pulls/31","id":21879881,"html_url":"https://github.com/jereln/portfolio/pull/31","diff_url":"https://github.com/jereln/portfolio/pull/31.diff","patch_url":"https://github.com/jereln/portfolio/pull/31.patch","issue_url":"https://api.github.com/repos/jereln/portfolio/issues/31","number":31,"state":"open","locked":false,"title":"fixing ch2 tests and rubocop errors","user":{"login":"jereln","id":7024948,"avatar_url":"https://avatars.githubusercontent.com/u/7024948?v=2","gravatar_id":"","url":"https://api.github.com/users/jereln","html_url":"https://github.com/jereln","followers_url":"https://api.github.com/users/jereln/followers","following_url":"https://api.github.com/users/jereln/following{/other_user}","gists_url":"https://api.github.com/users/jereln/gists{/gist_id}","starred_url":"https://api.github.com/users/jereln/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jereln/subscriptions","organizations_url":"https://api.github.com/users/jereln/orgs","repos_url":"https://api.github.com/users/jereln/repos","events_url":"https://api.github.com/users/jereln/events{/privacy}","received_events_url":"https://api.github.com/users/jereln/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-09-26T22:37:40Z","updated_at":"2014-09-26T22:37:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"859e1846007097f0dac44f04cd3c856124172f80","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jereln/portfolio/pulls/31/commits","review_comments_url":"https://api.github.com/repos/jereln/portfolio/pulls/31/comments","review_comment_url":"https://api.github.com/repos/jereln/portfolio/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jereln/portfolio/issues/31/comments","statuses_url":"https://api.github.com/repos/jereln/portfolio/statuses/fae034ebddc728f241d52d59663187f9ca3a5a39","head":{"label":"jereln:chapter-2-fix","ref":"chapter-2-fix","sha":"fae034ebddc728f241d52d59663187f9ca3a5a39","user":{"login":"jereln","id":7024948,"avatar_url":"https://avatars.githubusercontent.com/u/7024948?v=2","gravatar_id":"","url":"https://api.github.com/users/jereln","html_url":"https://github.com/jereln","followers_url":"https://api.github.com/users/jereln/followers","following_url":"https://api.github.com/users/jereln/following{/other_user}","gists_url":"https://api.github.com/users/jereln/gists{/gist_id}","starred_url":"https://api.github.com/users/jereln/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jereln/subscriptions","organizations_url":"https://api.github.com/users/jereln/orgs","repos_url":"https://api.github.com/users/jereln/repos","events_url":"https://api.github.com/users/jereln/events{/privacy}","received_events_url":"https://api.github.com/users/jereln/received_events","type":"User","site_admin":false},"repo":{"id":24131230,"name":"portfolio","full_name":"jereln/portfolio","owner":{"login":"jereln","id":7024948,"avatar_url":"https://avatars.githubusercontent.com/u/7024948?v=2","gravatar_id":"","url":"https://api.github.com/users/jereln","html_url":"https://github.com/jereln","followers_url":"https://api.github.com/users/jereln/followers","following_url":"https://api.github.com/users/jereln/following{/other_user}","gists_url":"https://api.github.com/users/jereln/gists{/gist_id}","starred_url":"https://api.github.com/users/jereln/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jereln/subscriptions","organizations_url":"https://api.github.com/users/jereln/orgs","repos_url":"https://api.github.com/users/jereln/repos","events_url":"https://api.github.com/users/jereln/events{/privacy}","received_events_url":"https://api.github.com/users/jereln/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jereln/portfolio","description":"","fork":false,"url":"https://api.github.com/repos/jereln/portfolio","forks_url":"https://api.github.com/repos/jereln/portfolio/forks","keys_url":"https://api.github.com/repos/jereln/portfolio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jereln/portfolio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jereln/portfolio/teams","hooks_url":"https://api.github.com/repos/jereln/portfolio/hooks","issue_events_url":"https://api.github.com/repos/jereln/portfolio/issues/events{/number}","events_url":"https://api.github.com/repos/jereln/portfolio/events","assignees_url":"https://api.github.com/repos/jereln/portfolio/assignees{/user}","branches_url":"https://api.github.com/repos/jereln/portfolio/branches{/branch}","tags_url":"https://api.github.com/repos/jereln/portfolio/tags","blobs_url":"https://api.github.com/repos/jereln/portfolio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jereln/portfolio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jereln/portfolio/git/refs{/sha}","trees_url":"https://api.github.com/repos/jereln/portfolio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jereln/portfolio/statuses/{sha}","languages_url":"https://api.github.com/repos/jereln/portfolio/languages","stargazers_url":"https://api.github.com/repos/jereln/portfolio/stargazers","contributors_url":"https://api.github.com/repos/jereln/portfolio/contributors","subscribers_url":"https://api.github.com/repos/jereln/portfolio/subscribers","subscription_url":"https://api.github.com/repos/jereln/portfolio/subscription","commits_url":"https://api.github.com/repos/jereln/portfolio/commits{/sha}","git_commits_url":"https://api.github.com/repos/jereln/portfolio/git/commits{/sha}","comments_url":"https://api.github.com/repos/jereln/portfolio/comments{/number}","issue_comment_url":"https://api.github.com/repos/jereln/portfolio/issues/comments/{number}","contents_url":"https://api.github.com/repos/jereln/portfolio/contents/{+path}","compare_url":"https://api.github.com/repos/jereln/portfolio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jereln/portfolio/merges","archive_url":"https://api.github.com/repos/jereln/portfolio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jereln/portfolio/downloads","issues_url":"https://api.github.com/repos/jereln/portfolio/issues{/number}","pulls_url":"https://api.github.com/repos/jereln/portfolio/pulls{/number}","milestones_url":"https://api.github.com/repos/jereln/portfolio/milestones{/number}","notifications_url":"https://api.github.com/repos/jereln/portfolio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jereln/portfolio/labels{/name}","releases_url":"https://api.github.com/repos/jereln/portfolio/releases{/id}","created_at":"2014-09-17T05:31:39Z","updated_at":"2014-09-19T05:08:17Z","pushed_at":"2014-09-26T22:37:03Z","git_url":"git://github.com/jereln/portfolio.git","ssh_url":"git@github.com:jereln/portfolio.git","clone_url":"https://github.com/jereln/portfolio.git","svn_url":"https://github.com/jereln/portfolio","homepage":null,"size":1232,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":10,"forks":0,"open_issues":10,"watchers":0,"default_branch":"master"}},"base":{"label":"jereln:master","ref":"master","sha":"1350f875374f19430deb470768336fd6226147ae","user":{"login":"jereln","id":7024948,"avatar_url":"https://avatars.githubusercontent.com/u/7024948?v=2","gravatar_id":"","url":"https://api.github.com/users/jereln","html_url":"https://github.com/jereln","followers_url":"https://api.github.com/users/jereln/followers","following_url":"https://api.github.com/users/jereln/following{/other_user}","gists_url":"https://api.github.com/users/jereln/gists{/gist_id}","starred_url":"https://api.github.com/users/jereln/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jereln/subscriptions","organizations_url":"https://api.github.com/users/jereln/orgs","repos_url":"https://api.github.com/users/jereln/repos","events_url":"https://api.github.com/users/jereln/events{/privacy}","received_events_url":"https://api.github.com/users/jereln/received_events","type":"User","site_admin":false},"repo":{"id":24131230,"name":"portfolio","full_name":"jereln/portfolio","owner":{"login":"jereln","id":7024948,"avatar_url":"https://avatars.githubusercontent.com/u/7024948?v=2","gravatar_id":"","url":"https://api.github.com/users/jereln","html_url":"https://github.com/jereln","followers_url":"https://api.github.com/users/jereln/followers","following_url":"https://api.github.com/users/jereln/following{/other_user}","gists_url":"https://api.github.com/users/jereln/gists{/gist_id}","starred_url":"https://api.github.com/users/jereln/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jereln/subscriptions","organizations_url":"https://api.github.com/users/jereln/orgs","repos_url":"https://api.github.com/users/jereln/repos","events_url":"https://api.github.com/users/jereln/events{/privacy}","received_events_url":"https://api.github.com/users/jereln/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jereln/portfolio","description":"","fork":false,"url":"https://api.github.com/repos/jereln/portfolio","forks_url":"https://api.github.com/repos/jereln/portfolio/forks","keys_url":"https://api.github.com/repos/jereln/portfolio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jereln/portfolio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jereln/portfolio/teams","hooks_url":"https://api.github.com/repos/jereln/portfolio/hooks","issue_events_url":"https://api.github.com/repos/jereln/portfolio/issues/events{/number}","events_url":"https://api.github.com/repos/jereln/portfolio/events","assignees_url":"https://api.github.com/repos/jereln/portfolio/assignees{/user}","branches_url":"https://api.github.com/repos/jereln/portfolio/branches{/branch}","tags_url":"https://api.github.com/repos/jereln/portfolio/tags","blobs_url":"https://api.github.com/repos/jereln/portfolio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jereln/portfolio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jereln/portfolio/git/refs{/sha}","trees_url":"https://api.github.com/repos/jereln/portfolio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jereln/portfolio/statuses/{sha}","languages_url":"https://api.github.com/repos/jereln/portfolio/languages","stargazers_url":"https://api.github.com/repos/jereln/portfolio/stargazers","contributors_url":"https://api.github.com/repos/jereln/portfolio/contributors","subscribers_url":"https://api.github.com/repos/jereln/portfolio/subscribers","subscription_url":"https://api.github.com/repos/jereln/portfolio/subscription","commits_url":"https://api.github.com/repos/jereln/portfolio/commits{/sha}","git_commits_url":"https://api.github.com/repos/jereln/portfolio/git/commits{/sha}","comments_url":"https://api.github.com/repos/jereln/portfolio/comments{/number}","issue_comment_url":"https://api.github.com/repos/jereln/portfolio/issues/comments/{number}","contents_url":"https://api.github.com/repos/jereln/portfolio/contents/{+path}","compare_url":"https://api.github.com/repos/jereln/portfolio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jereln/portfolio/merges","archive_url":"https://api.github.com/repos/jereln/portfolio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jereln/portfolio/downloads","issues_url":"https://api.github.com/repos/jereln/portfolio/issues{/number}","pulls_url":"https://api.github.com/repos/jereln/portfolio/pulls{/number}","milestones_url":"https://api.github.com/repos/jereln/portfolio/milestones{/number}","notifications_url":"https://api.github.com/repos/jereln/portfolio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jereln/portfolio/labels{/name}","releases_url":"https://api.github.com/repos/jereln/portfolio/releases{/id}","created_at":"2014-09-17T05:31:39Z","updated_at":"2014-09-19T05:08:17Z","pushed_at":"2014-09-26T22:37:03Z","git_url":"git://github.com/jereln/portfolio.git","ssh_url":"git@github.com:jereln/portfolio.git","clone_url":"https://github.com/jereln/portfolio.git","svn_url":"https://github.com/jereln/portfolio","homepage":null,"size":1232,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":10,"forks":0,"open_issues":10,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jereln/portfolio/pulls/31"},"html":{"href":"https://github.com/jereln/portfolio/pull/31"},"issue":{"href":"https://api.github.com/repos/jereln/portfolio/issues/31"},"comments":{"href":"https://api.github.com/repos/jereln/portfolio/issues/31/comments"},"review_comments":{"href":"https://api.github.com/repos/jereln/portfolio/pulls/31/comments"},"review_comment":{"href":"https://api.github.com/repos/jereln/portfolio/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jereln/portfolio/pulls/31/commits"},"statuses":{"href":"https://api.github.com/repos/jereln/portfolio/statuses/fae034ebddc728f241d52d59663187f9ca3a5a39"}}}}