GitHub PullRequestEvent at 2014-01-14 09:48:27
Repository: ralph_pricing
Actor: kula1922
Payload: {"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/kula1922/ralph_pricing/pulls/1","id":11401625,"html_url":"https://github.com/kula1922/ralph_pricing/pull/1","diff_url":"https://github.com/kula1922/ralph_pricing/pull/1.diff","patch_url":"https://github.com/kula1922/ralph_pricing/pull/1.patch","issue_url":"https://github.com/kula1922/ralph_pricing/pull/1","number":1,"state":"closed","title":"fix unit tests; remove power consumption and warehouse from dailydevice;...","user":{"login":"mkurek","id":107437,"avatar_url":"https://gravatar.com/avatar/392533ae1380db7827abba93ea5a31ae?d=https%3A%2F%2Fidenticons.github.com%2F23658d66d50b963e5060a1f7b124847c.png&r=x","gravatar_id":"392533ae1380db7827abba93ea5a31ae","url":"https://api.github.com/users/mkurek","html_url":"https://github.com/mkurek","followers_url":"https://api.github.com/users/mkurek/followers","following_url":"https://api.github.com/users/mkurek/following{/other_user}","gists_url":"https://api.github.com/users/mkurek/gists{/gist_id}","starred_url":"https://api.github.com/users/mkurek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkurek/subscriptions","organizations_url":"https://api.github.com/users/mkurek/orgs","repos_url":"https://api.github.com/users/mkurek/repos","events_url":"https://api.github.com/users/mkurek/events{/privacy}","received_events_url":"https://api.github.com/users/mkurek/received_events","type":"User","site_admin":false},"body":"... fix reports generating; remove power consumption plugin\r\n\r\nFirst of all I've removed power consumption plugin - all power consumption data all obtained using assets plugin, so we can create DailyUsage while updating assets (just like we're now creating cores count DailyUsage). Your power consumption plugin just rewrites data from one table to another.\r\n\r\nSecond of all - I've removed memoize decorator from get_price_at and _get_price_from_cost in models - caching results of this function causes wrong unit tests results - it's totally ok to use this in \"normal\" application, but whe should consider a solution which will not break unit tests.\r\n\r\nI've also removed warehouse reference from UsageType - there is no need to keep it here - and changed select list in report form - it's using ModelChoiceField now (simple ChoiceField with filling items from Warehouse model \"by hand\" breaks unit tests (missing db table)).\r\n\r\nLast but not least - i've improved some unit tests - mainly especially assets and report by ventures - now every test works.\r\n\r\nConsider merging it into your branch, then check if everything is ok (pep8 etc), then update your pull request to ralph_pricing.\r\n\r\nTODO: add unit test to reports generating with different warehouse choice and test if forecast report is working.","created_at":"2014-01-10T14:21:28Z","updated_at":"2014-01-14T09:48:25Z","closed_at":"2014-01-14T09:48:25Z","merged_at":"2014-01-14T09:48:25Z","merge_commit_sha":"adb1d09a516626a05dfaa36ad9e60a06ba7576bd","assignee":null,"milestone":null,"commits_url":"https://github.com/kula1922/ralph_pricing/pull/1/commits","review_comments_url":"https://github.com/kula1922/ralph_pricing/pull/1/comments","review_comment_url":"/repos/kula1922/ralph_pricing/pulls/comments/{number}","comments_url":"https://api.github.com/repos/kula1922/ralph_pricing/issues/1/comments","statuses_url":"https://api.github.com/repos/kula1922/ralph_pricing/statuses/e43bf3d6acaa1a89bdb8cdab83c45c045debdb78","head":{"label":"mkurek:feature/kula-create-plugin-to-custom-fields-assets","ref":"feature/kula-create-plugin-to-custom-fields-assets","sha":"e43bf3d6acaa1a89bdb8cdab83c45c045debdb78","user":{"login":"mkurek","id":107437,"avatar_url":"https://gravatar.com/avatar/392533ae1380db7827abba93ea5a31ae?d=https%3A%2F%2Fidenticons.github.com%2F23658d66d50b963e5060a1f7b124847c.png&r=x","gravatar_id":"392533ae1380db7827abba93ea5a31ae","url":"https://api.github.com/users/mkurek","html_url":"https://github.com/mkurek","followers_url":"https://api.github.com/users/mkurek/followers","following_url":"https://api.github.com/users/mkurek/following{/other_user}","gists_url":"https://api.github.com/users/mkurek/gists{/gist_id}","starred_url":"https://api.github.com/users/mkurek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkurek/subscriptions","organizations_url":"https://api.github.com/users/mkurek/orgs","repos_url":"https://api.github.com/users/mkurek/repos","events_url":"https://api.github.com/users/mkurek/events{/privacy}","received_events_url":"https://api.github.com/users/mkurek/received_events","type":"User","site_admin":false},"repo":{"id":15102127,"name":"ralph_pricing","full_name":"mkurek/ralph_pricing","owner":{"login":"mkurek","id":107437,"avatar_url":"https://gravatar.com/avatar/392533ae1380db7827abba93ea5a31ae?d=https%3A%2F%2Fidenticons.github.com%2F23658d66d50b963e5060a1f7b124847c.png&r=x","gravatar_id":"392533ae1380db7827abba93ea5a31ae","url":"https://api.github.com/users/mkurek","html_url":"https://github.com/mkurek","followers_url":"https://api.github.com/users/mkurek/followers","following_url":"https://api.github.com/users/mkurek/following{/other_user}","gists_url":"https://api.github.com/users/mkurek/gists{/gist_id}","starred_url":"https://api.github.com/users/mkurek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkurek/subscriptions","organizations_url":"https://api.github.com/users/mkurek/orgs","repos_url":"https://api.github.com/users/mkurek/repos","events_url":"https://api.github.com/users/mkurek/events{/privacy}","received_events_url":"https://api.github.com/users/mkurek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mkurek/ralph_pricing","description":"A pricing module for Ralph","fork":true,"url":"https://api.github.com/repos/mkurek/ralph_pricing","forks_url":"https://api.github.com/repos/mkurek/ralph_pricing/forks","keys_url":"https://api.github.com/repos/mkurek/ralph_pricing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mkurek/ralph_pricing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mkurek/ralph_pricing/teams","hooks_url":"https://api.github.com/repos/mkurek/ralph_pricing/hooks","issue_events_url":"https://api.github.com/repos/mkurek/ralph_pricing/issues/events{/number}","events_url":"https://api.github.com/repos/mkurek/ralph_pricing/events","assignees_url":"https://api.github.com/repos/mkurek/ralph_pricing/assignees{/user}","branches_url":"https://api.github.com/repos/mkurek/ralph_pricing/branches{/branch}","tags_url":"https://api.github.com/repos/mkurek/ralph_pricing/tags","blobs_url":"https://api.github.com/repos/mkurek/ralph_pricing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mkurek/ralph_pricing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mkurek/ralph_pricing/git/refs{/sha}","trees_url":"https://api.github.com/repos/mkurek/ralph_pricing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mkurek/ralph_pricing/statuses/{sha}","languages_url":"https://api.github.com/repos/mkurek/ralph_pricing/languages","stargazers_url":"https://api.github.com/repos/mkurek/ralph_pricing/stargazers","contributors_url":"https://api.github.com/repos/mkurek/ralph_pricing/contributors","subscribers_url":"https://api.github.com/repos/mkurek/ralph_pricing/subscribers","subscription_url":"https://api.github.com/repos/mkurek/ralph_pricing/subscription","commits_url":"https://api.github.com/repos/mkurek/ralph_pricing/commits{/sha}","git_commits_url":"https://api.github.com/repos/mkurek/ralph_pricing/git/commits{/sha}","comments_url":"https://api.github.com/repos/mkurek/ralph_pricing/comments{/number}","issue_comment_url":"https://api.github.com/repos/mkurek/ralph_pricing/issues/comments/{number}","contents_url":"https://api.github.com/repos/mkurek/ralph_pricing/contents/{+path}","compare_url":"https://api.github.com/repos/mkurek/ralph_pricing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mkurek/ralph_pricing/merges","archive_url":"https://api.github.com/repos/mkurek/ralph_pricing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mkurek/ralph_pricing/downloads","issues_url":"https://api.github.com/repos/mkurek/ralph_pricing/issues{/number}","pulls_url":"https://api.github.com/repos/mkurek/ralph_pricing/pulls{/number}","milestones_url":"https://api.github.com/repos/mkurek/ralph_pricing/milestones{/number}","notifications_url":"https://api.github.com/repos/mkurek/ralph_pricing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mkurek/ralph_pricing/labels{/name}","releases_url":"https://api.github.com/repos/mkurek/ralph_pricing/releases{/id}","created_at":"2013-12-11T08:37:57Z","updated_at":"2014-01-14T09:48:25Z","pushed_at":"2014-01-14T08:39:43Z","git_url":"git://github.com/mkurek/ralph_pricing.git","ssh_url":"git@github.com:mkurek/ralph_pricing.git","clone_url":"https://github.com/mkurek/ralph_pricing.git","svn_url":"https://github.com/mkurek/ralph_pricing","homepage":null,"size":592,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"kula1922:feature/create-plugin-to-custom-fields-assets","ref":"feature/create-plugin-to-custom-fields-assets","sha":"3f82b877c032bed4974aa02535a4747d2d74ba62","user":{"login":"kula1922","id":2130852,"avatar_url":"https://gravatar.com/avatar/4e9db77cc232a4b6fcd7b73308e00a38?d=https%3A%2F%2Fidenticons.github.com%2F0fd21bd03659b93f45796c70dc7988e4.png&r=x","gravatar_id":"4e9db77cc232a4b6fcd7b73308e00a38","url":"https://api.github.com/users/kula1922","html_url":"https://github.com/kula1922","followers_url":"https://api.github.com/users/kula1922/followers","following_url":"https://api.github.com/users/kula1922/following{/other_user}","gists_url":"https://api.github.com/users/kula1922/gists{/gist_id}","starred_url":"https://api.github.com/users/kula1922/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kula1922/subscriptions","organizations_url":"https://api.github.com/users/kula1922/orgs","repos_url":"https://api.github.com/users/kula1922/repos","events_url":"https://api.github.com/users/kula1922/events{/privacy}","received_events_url":"https://api.github.com/users/kula1922/received_events","type":"User","site_admin":false},"repo":{"id":15075699,"name":"ralph_pricing","full_name":"kula1922/ralph_pricing","owner":{"login":"kula1922","id":2130852,"avatar_url":"https://gravatar.com/avatar/4e9db77cc232a4b6fcd7b73308e00a38?d=https%3A%2F%2Fidenticons.github.com%2F0fd21bd03659b93f45796c70dc7988e4.png&r=x","gravatar_id":"4e9db77cc232a4b6fcd7b73308e00a38","url":"https://api.github.com/users/kula1922","html_url":"https://github.com/kula1922","followers_url":"https://api.github.com/users/kula1922/followers","following_url":"https://api.github.com/users/kula1922/following{/other_user}","gists_url":"https://api.github.com/users/kula1922/gists{/gist_id}","starred_url":"https://api.github.com/users/kula1922/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kula1922/subscriptions","organizations_url":"https://api.github.com/users/kula1922/orgs","repos_url":"https://api.github.com/users/kula1922/repos","events_url":"https://api.github.com/users/kula1922/events{/privacy}","received_events_url":"https://api.github.com/users/kula1922/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kula1922/ralph_pricing","description":"A pricing module for Ralph","fork":true,"url":"https://api.github.com/repos/kula1922/ralph_pricing","forks_url":"https://api.github.com/repos/kula1922/ralph_pricing/forks","keys_url":"https://api.github.com/repos/kula1922/ralph_pricing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kula1922/ralph_pricing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kula1922/ralph_pricing/teams","hooks_url":"https://api.github.com/repos/kula1922/ralph_pricing/hooks","issue_events_url":"https://api.github.com/repos/kula1922/ralph_pricing/issues/events{/number}","events_url":"https://api.github.com/repos/kula1922/ralph_pricing/events","assignees_url":"https://api.github.com/repos/kula1922/ralph_pricing/assignees{/user}","branches_url":"https://api.github.com/repos/kula1922/ralph_pricing/branches{/branch}","tags_url":"https://api.github.com/repos/kula1922/ralph_pricing/tags","blobs_url":"https://api.github.com/repos/kula1922/ralph_pricing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kula1922/ralph_pricing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kula1922/ralph_pricing/git/refs{/sha}","trees_url":"https://api.github.com/repos/kula1922/ralph_pricing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kula1922/ralph_pricing/statuses/{sha}","languages_url":"https://api.github.com/repos/kula1922/ralph_pricing/languages","stargazers_url":"https://api.github.com/repos/kula1922/ralph_pricing/stargazers","contributors_url":"https://api.github.com/repos/kula1922/ralph_pricing/contributors","subscribers_url":"https://api.github.com/repos/kula1922/ralph_pricing/subscribers","subscription_url":"https://api.github.com/repos/kula1922/ralph_pricing/subscription","commits_url":"https://api.github.com/repos/kula1922/ralph_pricing/commits{/sha}","git_commits_url":"https://api.github.com/repos/kula1922/ralph_pricing/git/commits{/sha}","comments_url":"https://api.github.com/repos/kula1922/ralph_pricing/comments{/number}","issue_comment_url":"https://api.github.com/repos/kula1922/ralph_pricing/issues/comments/{number}","contents_url":"https://api.github.com/repos/kula1922/ralph_pricing/contents/{+path}","compare_url":"https://api.github.com/repos/kula1922/ralph_pricing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kula1922/ralph_pricing/merges","archive_url":"https://api.github.com/repos/kula1922/ralph_pricing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kula1922/ralph_pricing/downloads","issues_url":"https://api.github.com/repos/kula1922/ralph_pricing/issues{/number}","pulls_url":"https://api.github.com/repos/kula1922/ralph_pricing/pulls{/number}","milestones_url":"https://api.github.com/repos/kula1922/ralph_pricing/milestones{/number}","notifications_url":"https://api.github.com/repos/kula1922/ralph_pricing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kula1922/ralph_pricing/labels{/name}","releases_url":"https://api.github.com/repos/kula1922/ralph_pricing/releases{/id}","created_at":"2013-12-10T11:47:32Z","updated_at":"2014-01-14T09:48:25Z","pushed_at":"2014-01-14T09:48:25Z","git_url":"git://github.com/kula1922/ralph_pricing.git","ssh_url":"git@github.com:kula1922/ralph_pricing.git","clone_url":"https://github.com/kula1922/ralph_pricing.git","svn_url":"https://github.com/kula1922/ralph_pricing","homepage":null,"size":617,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kula1922/ralph_pricing/pulls/1"},"html":{"href":"https://github.com/kula1922/ralph_pricing/pull/1"},"issue":{"href":"https://api.github.com/repos/kula1922/ralph_pricing/issues/1"},"comments":{"href":"https://api.github.com/repos/kula1922/ralph_pricing/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/kula1922/ralph_pricing/pulls/1/comments"},"statuses":{"href":"https://api.github.com/repos/kula1922/ralph_pricing/statuses/e43bf3d6acaa1a89bdb8cdab83c45c045debdb78"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"kula1922","id":2130852,"avatar_url":"https://gravatar.com/avatar/4e9db77cc232a4b6fcd7b73308e00a38?d=https%3A%2F%2Fidenticons.github.com%2F0fd21bd03659b93f45796c70dc7988e4.png&r=x","gravatar_id":"4e9db77cc232a4b6fcd7b73308e00a38","url":"https://api.github.com/users/kula1922","html_url":"https://github.com/kula1922","followers_url":"https://api.github.com/users/kula1922/followers","following_url":"https://api.github.com/users/kula1922/following{/other_user}","gists_url":"https://api.github.com/users/kula1922/gists{/gist_id}","starred_url":"https://api.github.com/users/kula1922/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kula1922/subscriptions","organizations_url":"https://api.github.com/users/kula1922/orgs","repos_url":"https://api.github.com/users/kula1922/repos","events_url":"https://api.github.com/users/kula1922/events{/privacy}","received_events_url":"https://api.github.com/users/kula1922/received_events","type":"User","site_admin":false},"comments":0,"review_comments":43,"commits":3,"additions":416,"deletions":251,"changed_files":10}}