GitHub PullRequestEvent at 2014-02-11 17:03:24
Repository: scikit-learn
Actor: mattilyra
Payload: {"action":"opened","number":2849,"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/2849","id":12424009,"html_url":"https://github.com/scikit-learn/scikit-learn/pull/2849","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/2849.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/2849.patch","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/2849","number":2849,"state":"open","title":"Added support for sparse matrices in manhattan_distances","user":{"login":"mattilyra","id":1055719,"avatar_url":"https://gravatar.com/avatar/f3ed7b121a0b3b314f6dc7f00a8977fa?d=https%3A%2F%2Fidenticons.github.com%2Fe99b9cbaf47df129c4222619ea4c925b.png&r=x","gravatar_id":"f3ed7b121a0b3b314f6dc7f00a8977fa","url":"https://api.github.com/users/mattilyra","html_url":"https://github.com/mattilyra","followers_url":"https://api.github.com/users/mattilyra/followers","following_url":"https://api.github.com/users/mattilyra/following{/other_user}","gists_url":"https://api.github.com/users/mattilyra/gists{/gist_id}","starred_url":"https://api.github.com/users/mattilyra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattilyra/subscriptions","organizations_url":"https://api.github.com/users/mattilyra/orgs","repos_url":"https://api.github.com/users/mattilyra/repos","events_url":"https://api.github.com/users/mattilyra/events{/privacy}","received_events_url":"https://api.github.com/users/mattilyra/received_events","type":"User","site_admin":false},"body":"I wasn't sure if in the case where the size of the broadcasted dense array would exceed the memory limit the sparse method should be used too. It seems like the correct thing to do, but I didn't want to change the implementation of that before asking.\r\n\r\n```python\r\n    ...\r\n    if temporary_size > size_threshold and sum_over_features:\r\n        # Broadcasting the full thing would be too big: it's on the order\r\n        # of magnitude of the gigabyte\r\n        # should this also use the sparse method?\r\n    ...\r\n```","created_at":"2014-02-11T17:03:24Z","updated_at":"2014-02-11T17:03:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/2849/commits","review_comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/2849/comments","review_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/{number}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/2849/comments","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/f2f61347a50de3a86bd819d10b35592c1a6756ff","head":{"label":"mattilyra:manhattan_sparse","ref":"manhattan_sparse","sha":"f2f61347a50de3a86bd819d10b35592c1a6756ff","user":{"login":"mattilyra","id":1055719,"avatar_url":"https://gravatar.com/avatar/f3ed7b121a0b3b314f6dc7f00a8977fa?d=https%3A%2F%2Fidenticons.github.com%2Fe99b9cbaf47df129c4222619ea4c925b.png&r=x","gravatar_id":"f3ed7b121a0b3b314f6dc7f00a8977fa","url":"https://api.github.com/users/mattilyra","html_url":"https://github.com/mattilyra","followers_url":"https://api.github.com/users/mattilyra/followers","following_url":"https://api.github.com/users/mattilyra/following{/other_user}","gists_url":"https://api.github.com/users/mattilyra/gists{/gist_id}","starred_url":"https://api.github.com/users/mattilyra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattilyra/subscriptions","organizations_url":"https://api.github.com/users/mattilyra/orgs","repos_url":"https://api.github.com/users/mattilyra/repos","events_url":"https://api.github.com/users/mattilyra/events{/privacy}","received_events_url":"https://api.github.com/users/mattilyra/received_events","type":"User","site_admin":false},"repo":{"id":6593727,"name":"scikit-learn","full_name":"mattilyra/scikit-learn","owner":{"login":"mattilyra","id":1055719,"avatar_url":"https://gravatar.com/avatar/f3ed7b121a0b3b314f6dc7f00a8977fa?d=https%3A%2F%2Fidenticons.github.com%2Fe99b9cbaf47df129c4222619ea4c925b.png&r=x","gravatar_id":"f3ed7b121a0b3b314f6dc7f00a8977fa","url":"https://api.github.com/users/mattilyra","html_url":"https://github.com/mattilyra","followers_url":"https://api.github.com/users/mattilyra/followers","following_url":"https://api.github.com/users/mattilyra/following{/other_user}","gists_url":"https://api.github.com/users/mattilyra/gists{/gist_id}","starred_url":"https://api.github.com/users/mattilyra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattilyra/subscriptions","organizations_url":"https://api.github.com/users/mattilyra/orgs","repos_url":"https://api.github.com/users/mattilyra/repos","events_url":"https://api.github.com/users/mattilyra/events{/privacy}","received_events_url":"https://api.github.com/users/mattilyra/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mattilyra/scikit-learn","description":"scikit-learn: machine learning in Python","fork":true,"url":"https://api.github.com/repos/mattilyra/scikit-learn","forks_url":"https://api.github.com/repos/mattilyra/scikit-learn/forks","keys_url":"https://api.github.com/repos/mattilyra/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattilyra/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattilyra/scikit-learn/teams","hooks_url":"https://api.github.com/repos/mattilyra/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/mattilyra/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/mattilyra/scikit-learn/events","assignees_url":"https://api.github.com/repos/mattilyra/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/mattilyra/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/mattilyra/scikit-learn/tags","blobs_url":"https://api.github.com/repos/mattilyra/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattilyra/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattilyra/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattilyra/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattilyra/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/mattilyra/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/mattilyra/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/mattilyra/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/mattilyra/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/mattilyra/scikit-learn/subscription","commits_url":"https://api.github.com/repos/mattilyra/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattilyra/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattilyra/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattilyra/scikit-learn/issues/comments/{number}","contents_url":"https://api.github.com/repos/mattilyra/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/mattilyra/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattilyra/scikit-learn/merges","archive_url":"https://api.github.com/repos/mattilyra/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattilyra/scikit-learn/downloads","issues_url":"https://api.github.com/repos/mattilyra/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/mattilyra/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/mattilyra/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/mattilyra/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattilyra/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/mattilyra/scikit-learn/releases{/id}","created_at":"2012-11-08T09:06:57Z","updated_at":"2014-02-11T17:03:24Z","pushed_at":"2014-02-11T16:39:08Z","git_url":"git://github.com/mattilyra/scikit-learn.git","ssh_url":"git@github.com:mattilyra/scikit-learn.git","clone_url":"https://github.com/mattilyra/scikit-learn.git","svn_url":"https://github.com/mattilyra/scikit-learn","homepage":"http://scikit-learn.org","size":45725,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"scikit-learn:master","ref":"master","sha":"74861d023efb27ec2147ef1cc0b51ec44b487093","user":{"login":"scikit-learn","id":365630,"avatar_url":"https://gravatar.com/avatar/8a6ecb57b119c5a5b3d882d08a909278?d=https%3A%2F%2Fidenticons.github.com%2F8be45a80f70477ac0cf0834a1365d316.png&r=x","gravatar_id":"8a6ecb57b119c5a5b3d882d08a909278","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"repo":{"id":843222,"name":"scikit-learn","full_name":"scikit-learn/scikit-learn","owner":{"login":"scikit-learn","id":365630,"avatar_url":"https://gravatar.com/avatar/8a6ecb57b119c5a5b3d882d08a909278?d=https%3A%2F%2Fidenticons.github.com%2F8be45a80f70477ac0cf0834a1365d316.png&r=x","gravatar_id":"8a6ecb57b119c5a5b3d882d08a909278","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scikit-learn/scikit-learn","description":"scikit-learn: machine learning in Python","fork":false,"url":"https://api.github.com/repos/scikit-learn/scikit-learn","forks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/forks","keys_url":"https://api.github.com/repos/scikit-learn/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-learn/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-learn/scikit-learn/teams","hooks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/events","assignees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-learn/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/tags","blobs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-learn/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscription","commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments/{number}","contents_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-learn/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-learn/scikit-learn/merges","archive_url":"https://api.github.com/repos/scikit-learn/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-learn/scikit-learn/downloads","issues_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-learn/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/scikit-learn/scikit-learn/releases{/id}","created_at":"2010-08-17T09:43:38Z","updated_at":"2014-02-11T16:08:26Z","pushed_at":"2014-02-11T16:08:26Z","git_url":"git://github.com/scikit-learn/scikit-learn.git","ssh_url":"git@github.com:scikit-learn/scikit-learn.git","clone_url":"https://github.com/scikit-learn/scikit-learn.git","svn_url":"https://github.com/scikit-learn/scikit-learn","homepage":"http://scikit-learn.org","size":82648,"stargazers_count":2403,"watchers_count":2403,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1259,"mirror_url":null,"open_issues_count":441,"forks":1259,"open_issues":441,"watchers":2403,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/2849"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/2849"},"issue":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/2849"},"comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/2849/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/2849/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/2849/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/f2f61347a50de3a86bd819d10b35592c1a6756ff"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":5696,"deletions":3767,"changed_files":4}}