GitHub PullRequestReviewCommentEvent at 2014-09-08 19:41:06
Repository: conf-registration-api
Actor: ryancarlson
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/CruGlobal/conf-registration-api/pulls/comments/17261558","id":17261558,"diff_hunk":"@@ -78,13 +77,8 @@ public void performDeepUpdate(Registration registration, CrsApplicationUser user\n \t\t\t\tfor(Answer answer : registrant.getAnswers())\n \t\t\t\t{\n \t\t\t\t\tanswer.setRegistrantId(registrant.getId());\n-\n-\t\t\t\t\tif(!addNewAnswer(answer, originalAnswerEntitySet))\n-\t\t\t\t\t{\n-\t\t\t\t\t\tanswerService.updateAnswer(answer.toDbAnswerEntity());\n-\t\t\t\t\t}\n+\t\t\t\t\taddNewAnswer(answer, originalAnswerEntitySet);","path":"src/main/java/org/cru/crs/api/process/UpdateRegistrationProcess.java","position":17,"original_position":17,"commit_id":"2977730de396913b6d0a25739572c55fe77c5c54","original_commit_id":"2977730de396913b6d0a25739572c55fe77c5c54","user":{"login":"ryancarlson","id":3768029,"avatar_url":"https://avatars.githubusercontent.com/u/3768029?v=2","gravatar_id":"e08062f49f466891c09609353478cfbe","url":"https://api.github.com/users/ryancarlson","html_url":"https://github.com/ryancarlson","followers_url":"https://api.github.com/users/ryancarlson/followers","following_url":"https://api.github.com/users/ryancarlson/following{/other_user}","gists_url":"https://api.github.com/users/ryancarlson/gists{/gist_id}","starred_url":"https://api.github.com/users/ryancarlson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryancarlson/subscriptions","organizations_url":"https://api.github.com/users/ryancarlson/orgs","repos_url":"https://api.github.com/users/ryancarlson/repos","events_url":"https://api.github.com/users/ryancarlson/events{/privacy}","received_events_url":"https://api.github.com/users/ryancarlson/received_events","type":"User","site_admin":false},"body":"Not sure I follow... ","created_at":"2014-09-08T19:41:06Z","updated_at":"2014-09-08T19:41:06Z","html_url":"https://github.com/CruGlobal/conf-registration-api/pull/239#discussion_r17261558","pull_request_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/pulls/239","_links":{"self":{"href":"https://api.github.com/repos/CruGlobal/conf-registration-api/pulls/comments/17261558"},"html":{"href":"https://github.com/CruGlobal/conf-registration-api/pull/239#discussion_r17261558"},"pull_request":{"href":"https://api.github.com/repos/CruGlobal/conf-registration-api/pulls/239"}}},"pull_request":{"url":"https://api.github.com/repos/CruGlobal/conf-registration-api/pulls/239","id":20911577,"html_url":"https://github.com/CruGlobal/conf-registration-api/pull/239","diff_url":"https://github.com/CruGlobal/conf-registration-api/pull/239.diff","patch_url":"https://github.com/CruGlobal/conf-registration-api/pull/239.patch","issue_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/issues/239","number":239,"state":"open","locked":false,"title":"Minor Glitches Fix","user":{"login":"mattfred","id":8041146,"avatar_url":"https://avatars.githubusercontent.com/u/8041146?v=2","gravatar_id":"01bc543966b1ba27aa5dc3cf83a30db3","url":"https://api.github.com/users/mattfred","html_url":"https://github.com/mattfred","followers_url":"https://api.github.com/users/mattfred/followers","following_url":"https://api.github.com/users/mattfred/following{/other_user}","gists_url":"https://api.github.com/users/mattfred/gists{/gist_id}","starred_url":"https://api.github.com/users/mattfred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattfred/subscriptions","organizations_url":"https://api.github.com/users/mattfred/orgs","repos_url":"https://api.github.com/users/mattfred/repos","events_url":"https://api.github.com/users/mattfred/events{/privacy}","received_events_url":"https://api.github.com/users/mattfred/received_events","type":"User","site_admin":false},"body":"ProfileProcess\r\n- only logged in user's profile was being populated.\r\n\r\nRetrieveRegistrationProcess\r\n- totalDue was being pulled from database before registration was complete.\r\n\r\nUpdateRegistrationProcess\r\n- PeopleID was not being set in registrants (even though the registrantID and peopleID has always been the same value)\r\n- Answers are not updated or deleted through the registration endpoint. However, previous registrant's answers were being set to null with each new registrant that was added. Answers should only be updated or deleted through the answers endpoint (this is currently how the front end is set up).\r\n\r\nRegistrantService\r\n- CreatedTimeStamp was not always being saved","created_at":"2014-09-08T19:25:00Z","updated_at":"2014-09-08T19:41:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f9f5b358e93c4f072ef42bf6c2bd633fe13a8aee","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/pulls/239/commits","review_comments_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/pulls/239/comments","review_comment_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/pulls/comments/{number}","comments_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/issues/239/comments","statuses_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/statuses/2977730de396913b6d0a25739572c55fe77c5c54","head":{"label":"CruGlobal:EVENT-58","ref":"EVENT-58","sha":"2977730de396913b6d0a25739572c55fe77c5c54","user":{"login":"CruGlobal","id":1785912,"avatar_url":"https://avatars.githubusercontent.com/u/1785912?v=2","gravatar_id":"fff0e4838db6e8e33d895977195fa2ce","url":"https://api.github.com/users/CruGlobal","html_url":"https://github.com/CruGlobal","followers_url":"https://api.github.com/users/CruGlobal/followers","following_url":"https://api.github.com/users/CruGlobal/following{/other_user}","gists_url":"https://api.github.com/users/CruGlobal/gists{/gist_id}","starred_url":"https://api.github.com/users/CruGlobal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CruGlobal/subscriptions","organizations_url":"https://api.github.com/users/CruGlobal/orgs","repos_url":"https://api.github.com/users/CruGlobal/repos","events_url":"https://api.github.com/users/CruGlobal/events{/privacy}","received_events_url":"https://api.github.com/users/CruGlobal/received_events","type":"Organization","site_admin":false},"repo":{"id":10947678,"name":"conf-registration-api","full_name":"CruGlobal/conf-registration-api","owner":{"login":"CruGlobal","id":1785912,"avatar_url":"https://avatars.githubusercontent.com/u/1785912?v=2","gravatar_id":"fff0e4838db6e8e33d895977195fa2ce","url":"https://api.github.com/users/CruGlobal","html_url":"https://github.com/CruGlobal","followers_url":"https://api.github.com/users/CruGlobal/followers","following_url":"https://api.github.com/users/CruGlobal/following{/other_user}","gists_url":"https://api.github.com/users/CruGlobal/gists{/gist_id}","starred_url":"https://api.github.com/users/CruGlobal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CruGlobal/subscriptions","organizations_url":"https://api.github.com/users/CruGlobal/orgs","repos_url":"https://api.github.com/users/CruGlobal/repos","events_url":"https://api.github.com/users/CruGlobal/events{/privacy}","received_events_url":"https://api.github.com/users/CruGlobal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CruGlobal/conf-registration-api","description":"eventregistrationtool api","fork":false,"url":"https://api.github.com/repos/CruGlobal/conf-registration-api","forks_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/forks","keys_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/teams","hooks_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/hooks","issue_events_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/issues/events{/number}","events_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/events","assignees_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/assignees{/user}","branches_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/branches{/branch}","tags_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/tags","blobs_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/statuses/{sha}","languages_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/languages","stargazers_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/stargazers","contributors_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/contributors","subscribers_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/subscribers","subscription_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/subscription","commits_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/issues/comments/{number}","contents_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/contents/{+path}","compare_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/merges","archive_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/downloads","issues_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/issues{/number}","pulls_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/pulls{/number}","milestones_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/milestones{/number}","notifications_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/labels{/name}","releases_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/releases{/id}","created_at":"2013-06-25T19:21:35Z","updated_at":"2014-09-02T15:51:41Z","pushed_at":"2014-09-08T19:26:11Z","git_url":"git://github.com/CruGlobal/conf-registration-api.git","ssh_url":"git@github.com:CruGlobal/conf-registration-api.git","clone_url":"https://github.com/CruGlobal/conf-registration-api.git","svn_url":"https://github.com/CruGlobal/conf-registration-api","homepage":"","size":49156,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":3,"default_branch":"master"}},"base":{"label":"CruGlobal:EVENT-24","ref":"EVENT-24","sha":"9ef9986a65bfd2e91db827defa1ab98ab5ae8d3d","user":{"login":"CruGlobal","id":1785912,"avatar_url":"https://avatars.githubusercontent.com/u/1785912?v=2","gravatar_id":"fff0e4838db6e8e33d895977195fa2ce","url":"https://api.github.com/users/CruGlobal","html_url":"https://github.com/CruGlobal","followers_url":"https://api.github.com/users/CruGlobal/followers","following_url":"https://api.github.com/users/CruGlobal/following{/other_user}","gists_url":"https://api.github.com/users/CruGlobal/gists{/gist_id}","starred_url":"https://api.github.com/users/CruGlobal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CruGlobal/subscriptions","organizations_url":"https://api.github.com/users/CruGlobal/orgs","repos_url":"https://api.github.com/users/CruGlobal/repos","events_url":"https://api.github.com/users/CruGlobal/events{/privacy}","received_events_url":"https://api.github.com/users/CruGlobal/received_events","type":"Organization","site_admin":false},"repo":{"id":10947678,"name":"conf-registration-api","full_name":"CruGlobal/conf-registration-api","owner":{"login":"CruGlobal","id":1785912,"avatar_url":"https://avatars.githubusercontent.com/u/1785912?v=2","gravatar_id":"fff0e4838db6e8e33d895977195fa2ce","url":"https://api.github.com/users/CruGlobal","html_url":"https://github.com/CruGlobal","followers_url":"https://api.github.com/users/CruGlobal/followers","following_url":"https://api.github.com/users/CruGlobal/following{/other_user}","gists_url":"https://api.github.com/users/CruGlobal/gists{/gist_id}","starred_url":"https://api.github.com/users/CruGlobal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CruGlobal/subscriptions","organizations_url":"https://api.github.com/users/CruGlobal/orgs","repos_url":"https://api.github.com/users/CruGlobal/repos","events_url":"https://api.github.com/users/CruGlobal/events{/privacy}","received_events_url":"https://api.github.com/users/CruGlobal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CruGlobal/conf-registration-api","description":"eventregistrationtool api","fork":false,"url":"https://api.github.com/repos/CruGlobal/conf-registration-api","forks_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/forks","keys_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/teams","hooks_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/hooks","issue_events_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/issues/events{/number}","events_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/events","assignees_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/assignees{/user}","branches_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/branches{/branch}","tags_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/tags","blobs_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/statuses/{sha}","languages_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/languages","stargazers_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/stargazers","contributors_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/contributors","subscribers_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/subscribers","subscription_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/subscription","commits_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/issues/comments/{number}","contents_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/contents/{+path}","compare_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/merges","archive_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/downloads","issues_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/issues{/number}","pulls_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/pulls{/number}","milestones_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/milestones{/number}","notifications_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/labels{/name}","releases_url":"https://api.github.com/repos/CruGlobal/conf-registration-api/releases{/id}","created_at":"2013-06-25T19:21:35Z","updated_at":"2014-09-02T15:51:41Z","pushed_at":"2014-09-08T19:26:11Z","git_url":"git://github.com/CruGlobal/conf-registration-api.git","ssh_url":"git@github.com:CruGlobal/conf-registration-api.git","clone_url":"https://github.com/CruGlobal/conf-registration-api.git","svn_url":"https://github.com/CruGlobal/conf-registration-api","homepage":"","size":49156,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CruGlobal/conf-registration-api/pulls/239"},"html":{"href":"https://github.com/CruGlobal/conf-registration-api/pull/239"},"issue":{"href":"https://api.github.com/repos/CruGlobal/conf-registration-api/issues/239"},"comments":{"href":"https://api.github.com/repos/CruGlobal/conf-registration-api/issues/239/comments"},"review_comments":{"href":"https://api.github.com/repos/CruGlobal/conf-registration-api/pulls/239/comments"},"review_comment":{"href":"https://api.github.com/repos/CruGlobal/conf-registration-api/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/CruGlobal/conf-registration-api/pulls/239/commits"},"statuses":{"href":"https://api.github.com/repos/CruGlobal/conf-registration-api/statuses/2977730de396913b6d0a25739572c55fe77c5c54"}}}}