GitHub PullRequestEvent at 2014-08-27 09:23:02
Repository: spotlight
Actor: lennym
Payload: {"action":"opened","number":768,"pull_request":{"url":"https://api.github.com/repos/alphagov/spotlight/pulls/768","id":20361442,"html_url":"https://github.com/alphagov/spotlight/pull/768","diff_url":"https://github.com/alphagov/spotlight/pull/768.diff","patch_url":"https://github.com/alphagov/spotlight/pull/768.patch","issue_url":"https://api.github.com/repos/alphagov/spotlight/issues/768","number":768,"state":"open","locked":false,"title":"Fix table sorting for date range columns","user":{"login":"lennym","id":117398,"avatar_url":"https://avatars.githubusercontent.com/u/117398?v=2","gravatar_id":"40de52a01e73819462ef8fdc924a4d3c","url":"https://api.github.com/users/lennym","html_url":"https://github.com/lennym","followers_url":"https://api.github.com/users/lennym/followers","following_url":"https://api.github.com/users/lennym/following{/other_user}","gists_url":"https://api.github.com/users/lennym/gists{/gist_id}","starred_url":"https://api.github.com/users/lennym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lennym/subscriptions","organizations_url":"https://api.github.com/users/lennym/orgs","repos_url":"https://api.github.com/users/lennym/repos","events_url":"https://api.github.com/users/lennym/events{/privacy}","received_events_url":"https://api.github.com/users/lennym/received_events","type":"User","site_admin":false},"body":"Because column key is an array, adding the key as a data attr added a comma separated list, which then can't be used to lookup. Just use the start point of the range for sorting in this case.\r\n\r\nFixes https://www.pivotaltracker.com/story/show/77623752","created_at":"2014-08-27T09:23:01Z","updated_at":"2014-08-27T09:23:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/spotlight/pulls/768/commits","review_comments_url":"https://api.github.com/repos/alphagov/spotlight/pulls/768/comments","review_comment_url":"https://api.github.com/repos/alphagov/spotlight/pulls/comments/{number}","comments_url":"https://api.github.com/repos/alphagov/spotlight/issues/768/comments","statuses_url":"https://api.github.com/repos/alphagov/spotlight/statuses/a58e94ac5b31f9b49b7c59b64a99607e30783395","head":{"label":"alphagov:bugfix/table-date-range-sorting","ref":"bugfix/table-date-range-sorting","sha":"a58e94ac5b31f9b49b7c59b64a99607e30783395","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=2","gravatar_id":"5618b843830194a2475a6e48823f7455","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":13439661,"name":"spotlight","full_name":"alphagov/spotlight","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=2","gravatar_id":"5618b843830194a2475a6e48823f7455","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/spotlight","description":"Hybrid rendering application for the Performance Platform using Backbone and D3","fork":false,"url":"https://api.github.com/repos/alphagov/spotlight","forks_url":"https://api.github.com/repos/alphagov/spotlight/forks","keys_url":"https://api.github.com/repos/alphagov/spotlight/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/spotlight/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/spotlight/teams","hooks_url":"https://api.github.com/repos/alphagov/spotlight/hooks","issue_events_url":"https://api.github.com/repos/alphagov/spotlight/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/spotlight/events","assignees_url":"https://api.github.com/repos/alphagov/spotlight/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/spotlight/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/spotlight/tags","blobs_url":"https://api.github.com/repos/alphagov/spotlight/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/spotlight/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/spotlight/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/spotlight/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/spotlight/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/spotlight/languages","stargazers_url":"https://api.github.com/repos/alphagov/spotlight/stargazers","contributors_url":"https://api.github.com/repos/alphagov/spotlight/contributors","subscribers_url":"https://api.github.com/repos/alphagov/spotlight/subscribers","subscription_url":"https://api.github.com/repos/alphagov/spotlight/subscription","commits_url":"https://api.github.com/repos/alphagov/spotlight/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/spotlight/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/spotlight/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/spotlight/issues/comments/{number}","contents_url":"https://api.github.com/repos/alphagov/spotlight/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/spotlight/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/spotlight/merges","archive_url":"https://api.github.com/repos/alphagov/spotlight/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/spotlight/downloads","issues_url":"https://api.github.com/repos/alphagov/spotlight/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/spotlight/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/spotlight/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/spotlight/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/spotlight/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/spotlight/releases{/id}","created_at":"2013-10-09T10:40:22Z","updated_at":"2014-08-26T17:09:35Z","pushed_at":"2014-08-27T09:22:30Z","git_url":"git://github.com/alphagov/spotlight.git","ssh_url":"git@github.com:alphagov/spotlight.git","clone_url":"https://github.com/alphagov/spotlight.git","svn_url":"https://github.com/alphagov/spotlight","homepage":"","size":55999,"stargazers_count":11,"watchers_count":11,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":14,"mirror_url":null,"open_issues_count":6,"forks":14,"open_issues":6,"watchers":11,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"149065dfb209c273937ed426e937d4b7907d7745","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=2","gravatar_id":"5618b843830194a2475a6e48823f7455","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":13439661,"name":"spotlight","full_name":"alphagov/spotlight","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=2","gravatar_id":"5618b843830194a2475a6e48823f7455","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/spotlight","description":"Hybrid rendering application for the Performance Platform using Backbone and D3","fork":false,"url":"https://api.github.com/repos/alphagov/spotlight","forks_url":"https://api.github.com/repos/alphagov/spotlight/forks","keys_url":"https://api.github.com/repos/alphagov/spotlight/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/spotlight/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/spotlight/teams","hooks_url":"https://api.github.com/repos/alphagov/spotlight/hooks","issue_events_url":"https://api.github.com/repos/alphagov/spotlight/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/spotlight/events","assignees_url":"https://api.github.com/repos/alphagov/spotlight/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/spotlight/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/spotlight/tags","blobs_url":"https://api.github.com/repos/alphagov/spotlight/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/spotlight/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/spotlight/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/spotlight/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/spotlight/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/spotlight/languages","stargazers_url":"https://api.github.com/repos/alphagov/spotlight/stargazers","contributors_url":"https://api.github.com/repos/alphagov/spotlight/contributors","subscribers_url":"https://api.github.com/repos/alphagov/spotlight/subscribers","subscription_url":"https://api.github.com/repos/alphagov/spotlight/subscription","commits_url":"https://api.github.com/repos/alphagov/spotlight/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/spotlight/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/spotlight/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/spotlight/issues/comments/{number}","contents_url":"https://api.github.com/repos/alphagov/spotlight/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/spotlight/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/spotlight/merges","archive_url":"https://api.github.com/repos/alphagov/spotlight/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/spotlight/downloads","issues_url":"https://api.github.com/repos/alphagov/spotlight/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/spotlight/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/spotlight/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/spotlight/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/spotlight/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/spotlight/releases{/id}","created_at":"2013-10-09T10:40:22Z","updated_at":"2014-08-26T17:09:35Z","pushed_at":"2014-08-27T09:22:30Z","git_url":"git://github.com/alphagov/spotlight.git","ssh_url":"git@github.com:alphagov/spotlight.git","clone_url":"https://github.com/alphagov/spotlight.git","svn_url":"https://github.com/alphagov/spotlight","homepage":"","size":55999,"stargazers_count":11,"watchers_count":11,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":14,"mirror_url":null,"open_issues_count":6,"forks":14,"open_issues":6,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/spotlight/pulls/768"},"html":{"href":"https://github.com/alphagov/spotlight/pull/768"},"issue":{"href":"https://api.github.com/repos/alphagov/spotlight/issues/768"},"comments":{"href":"https://api.github.com/repos/alphagov/spotlight/issues/768/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/spotlight/pulls/768/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/spotlight/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/alphagov/spotlight/pulls/768/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/spotlight/statuses/a58e94ac5b31f9b49b7c59b64a99607e30783395"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":19,"deletions":1,"changed_files":2}}