GitHub PullRequestReviewCommentEvent at 2014-05-22 17:25:37
Repository: presto
Actor: martint
Payload: {"comment":{"url":"https://api.github.com/repos/facebook/presto/pulls/comments/12962245","id":12962245,"diff_hunk":"@@ -414,6 +416,7 @@ public static void evaluate(BlockBuilder out, Type parameterType, QuantileDigest\n         }\n         else {\n             checkState(percentile != -1.0, \"Percentile is missing\");\n+            checkCondition(0 <= percentile && percentile <= 1, INVALID_FUNCTION_ARGUMENT, \"Percentile must be between 0 and 1, got %f\", percentile);","path":"presto-main/src/main/java/com/facebook/presto/operator/aggregation/ApproximatePercentileAggregation.java","position":35,"original_position":35,"commit_id":"3b3b6263810600a34d77821ea71ae6b38a562b55","original_commit_id":"3b3b6263810600a34d77821ea71ae6b38a562b55","user":{"login":"martint","id":14387,"avatar_url":"https://avatars.githubusercontent.com/u/14387?","gravatar_id":"3cca33f9fc2e317da7e2b69c7a05c4ab","url":"https://api.github.com/users/martint","html_url":"https://github.com/martint","followers_url":"https://api.github.com/users/martint/followers","following_url":"https://api.github.com/users/martint/following{/other_user}","gists_url":"https://api.github.com/users/martint/gists{/gist_id}","starred_url":"https://api.github.com/users/martint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martint/subscriptions","organizations_url":"https://api.github.com/users/martint/orgs","repos_url":"https://api.github.com/users/martint/repos","events_url":"https://api.github.com/users/martint/events{/privacy}","received_events_url":"https://api.github.com/users/martint/received_events","type":"User","site_admin":false},"body":"The signature for checkCondition is (boolean, StandardErrorCode, String, Object...). This call will likely result in the `percentile` argument being boxed and it may affect performance.","created_at":"2014-05-22T17:25:37Z","updated_at":"2014-05-22T17:25:37Z","html_url":"https://github.com/facebook/presto/pull/1322#discussion_r12962245","pull_request_url":"https://api.github.com/repos/facebook/presto/pulls/1322","_links":{"self":{"href":"https://api.github.com/repos/facebook/presto/pulls/comments/12962245"},"html":{"href":"https://github.com/facebook/presto/pull/1322#discussion_r12962245"},"pull_request":{"href":"https://api.github.com/repos/facebook/presto/pulls/1322"}}}}