GitHub PullRequestEvent at 2014-09-04 02:43:55
Repository: scaldi-play
Actor: mauhiz
Payload: {"action":"opened","number":7,"pull_request":{"url":"https://api.github.com/repos/scaldi/scaldi-play/pulls/7","id":20719206,"html_url":"https://github.com/scaldi/scaldi-play/pull/7","diff_url":"https://github.com/scaldi/scaldi-play/pull/7.diff","patch_url":"https://github.com/scaldi/scaldi-play/pull/7.patch","issue_url":"https://api.github.com/repos/scaldi/scaldi-play/issues/7","number":7,"state":"open","locked":false,"title":"added a cache for controllers","user":{"login":"mauhiz","id":1818187,"avatar_url":"https://avatars.githubusercontent.com/u/1818187?v=2","gravatar_id":"594e4fb2b1c056db119f250630599c60","url":"https://api.github.com/users/mauhiz","html_url":"https://github.com/mauhiz","followers_url":"https://api.github.com/users/mauhiz/followers","following_url":"https://api.github.com/users/mauhiz/following{/other_user}","gists_url":"https://api.github.com/users/mauhiz/gists{/gist_id}","starred_url":"https://api.github.com/users/mauhiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mauhiz/subscriptions","organizations_url":"https://api.github.com/users/mauhiz/orgs","repos_url":"https://api.github.com/users/mauhiz/repos","events_url":"https://api.github.com/users/mauhiz/events{/privacy}","received_events_url":"https://api.github.com/users/mauhiz/received_events","type":"User","site_admin":false},"body":"When load-testing our play app (which uses Scaldi-play) we noticed a significant bottleneck caused by reflection.\r\n\r\nThis PR addresses it by caching generated controller instances. This assumes that :\r\n- controllers can be reused (they should, really!)\r\n- Scaldi bindings don't change at runtime","created_at":"2014-09-04T02:43:54Z","updated_at":"2014-09-04T02:43:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/scaldi/scaldi-play/pulls/7/commits","review_comments_url":"https://api.github.com/repos/scaldi/scaldi-play/pulls/7/comments","review_comment_url":"https://api.github.com/repos/scaldi/scaldi-play/pulls/comments/{number}","comments_url":"https://api.github.com/repos/scaldi/scaldi-play/issues/7/comments","statuses_url":"https://api.github.com/repos/scaldi/scaldi-play/statuses/e130670d4d99f0abd314a12ee58f0a146d259be2","head":{"label":"mauhiz:feature/cache-controllers","ref":"feature/cache-controllers","sha":"e130670d4d99f0abd314a12ee58f0a146d259be2","user":{"login":"mauhiz","id":1818187,"avatar_url":"https://avatars.githubusercontent.com/u/1818187?v=2","gravatar_id":"594e4fb2b1c056db119f250630599c60","url":"https://api.github.com/users/mauhiz","html_url":"https://github.com/mauhiz","followers_url":"https://api.github.com/users/mauhiz/followers","following_url":"https://api.github.com/users/mauhiz/following{/other_user}","gists_url":"https://api.github.com/users/mauhiz/gists{/gist_id}","starred_url":"https://api.github.com/users/mauhiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mauhiz/subscriptions","organizations_url":"https://api.github.com/users/mauhiz/orgs","repos_url":"https://api.github.com/users/mauhiz/repos","events_url":"https://api.github.com/users/mauhiz/events{/privacy}","received_events_url":"https://api.github.com/users/mauhiz/received_events","type":"User","site_admin":false},"repo":{"id":23645318,"name":"scaldi-play","full_name":"mauhiz/scaldi-play","owner":{"login":"mauhiz","id":1818187,"avatar_url":"https://avatars.githubusercontent.com/u/1818187?v=2","gravatar_id":"594e4fb2b1c056db119f250630599c60","url":"https://api.github.com/users/mauhiz","html_url":"https://github.com/mauhiz","followers_url":"https://api.github.com/users/mauhiz/followers","following_url":"https://api.github.com/users/mauhiz/following{/other_user}","gists_url":"https://api.github.com/users/mauhiz/gists{/gist_id}","starred_url":"https://api.github.com/users/mauhiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mauhiz/subscriptions","organizations_url":"https://api.github.com/users/mauhiz/orgs","repos_url":"https://api.github.com/users/mauhiz/repos","events_url":"https://api.github.com/users/mauhiz/events{/privacy}","received_events_url":"https://api.github.com/users/mauhiz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mauhiz/scaldi-play","description":"Scaldi integration for Play framework","fork":true,"url":"https://api.github.com/repos/mauhiz/scaldi-play","forks_url":"https://api.github.com/repos/mauhiz/scaldi-play/forks","keys_url":"https://api.github.com/repos/mauhiz/scaldi-play/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mauhiz/scaldi-play/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mauhiz/scaldi-play/teams","hooks_url":"https://api.github.com/repos/mauhiz/scaldi-play/hooks","issue_events_url":"https://api.github.com/repos/mauhiz/scaldi-play/issues/events{/number}","events_url":"https://api.github.com/repos/mauhiz/scaldi-play/events","assignees_url":"https://api.github.com/repos/mauhiz/scaldi-play/assignees{/user}","branches_url":"https://api.github.com/repos/mauhiz/scaldi-play/branches{/branch}","tags_url":"https://api.github.com/repos/mauhiz/scaldi-play/tags","blobs_url":"https://api.github.com/repos/mauhiz/scaldi-play/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mauhiz/scaldi-play/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mauhiz/scaldi-play/git/refs{/sha}","trees_url":"https://api.github.com/repos/mauhiz/scaldi-play/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mauhiz/scaldi-play/statuses/{sha}","languages_url":"https://api.github.com/repos/mauhiz/scaldi-play/languages","stargazers_url":"https://api.github.com/repos/mauhiz/scaldi-play/stargazers","contributors_url":"https://api.github.com/repos/mauhiz/scaldi-play/contributors","subscribers_url":"https://api.github.com/repos/mauhiz/scaldi-play/subscribers","subscription_url":"https://api.github.com/repos/mauhiz/scaldi-play/subscription","commits_url":"https://api.github.com/repos/mauhiz/scaldi-play/commits{/sha}","git_commits_url":"https://api.github.com/repos/mauhiz/scaldi-play/git/commits{/sha}","comments_url":"https://api.github.com/repos/mauhiz/scaldi-play/comments{/number}","issue_comment_url":"https://api.github.com/repos/mauhiz/scaldi-play/issues/comments/{number}","contents_url":"https://api.github.com/repos/mauhiz/scaldi-play/contents/{+path}","compare_url":"https://api.github.com/repos/mauhiz/scaldi-play/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mauhiz/scaldi-play/merges","archive_url":"https://api.github.com/repos/mauhiz/scaldi-play/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mauhiz/scaldi-play/downloads","issues_url":"https://api.github.com/repos/mauhiz/scaldi-play/issues{/number}","pulls_url":"https://api.github.com/repos/mauhiz/scaldi-play/pulls{/number}","milestones_url":"https://api.github.com/repos/mauhiz/scaldi-play/milestones{/number}","notifications_url":"https://api.github.com/repos/mauhiz/scaldi-play/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mauhiz/scaldi-play/labels{/name}","releases_url":"https://api.github.com/repos/mauhiz/scaldi-play/releases{/id}","created_at":"2014-09-04T02:16:37Z","updated_at":"2014-07-29T17:47:58Z","pushed_at":"2014-09-04T02:41:21Z","git_url":"git://github.com/mauhiz/scaldi-play.git","ssh_url":"git@github.com:mauhiz/scaldi-play.git","clone_url":"https://github.com/mauhiz/scaldi-play.git","svn_url":"https://github.com/mauhiz/scaldi-play","homepage":"http://scaldi.org","size":429,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scaldi:master","ref":"master","sha":"39695181f524c7db43530128a3d1785b179ec6d9","user":{"login":"scaldi","id":4552403,"avatar_url":"https://avatars.githubusercontent.com/u/4552403?v=2","gravatar_id":"7d2d853f9ede6c3358bdb14a83a77dc9","url":"https://api.github.com/users/scaldi","html_url":"https://github.com/scaldi","followers_url":"https://api.github.com/users/scaldi/followers","following_url":"https://api.github.com/users/scaldi/following{/other_user}","gists_url":"https://api.github.com/users/scaldi/gists{/gist_id}","starred_url":"https://api.github.com/users/scaldi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scaldi/subscriptions","organizations_url":"https://api.github.com/users/scaldi/orgs","repos_url":"https://api.github.com/users/scaldi/repos","events_url":"https://api.github.com/users/scaldi/events{/privacy}","received_events_url":"https://api.github.com/users/scaldi/received_events","type":"Organization","site_admin":false},"repo":{"id":10287317,"name":"scaldi-play","full_name":"scaldi/scaldi-play","owner":{"login":"scaldi","id":4552403,"avatar_url":"https://avatars.githubusercontent.com/u/4552403?v=2","gravatar_id":"7d2d853f9ede6c3358bdb14a83a77dc9","url":"https://api.github.com/users/scaldi","html_url":"https://github.com/scaldi","followers_url":"https://api.github.com/users/scaldi/followers","following_url":"https://api.github.com/users/scaldi/following{/other_user}","gists_url":"https://api.github.com/users/scaldi/gists{/gist_id}","starred_url":"https://api.github.com/users/scaldi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scaldi/subscriptions","organizations_url":"https://api.github.com/users/scaldi/orgs","repos_url":"https://api.github.com/users/scaldi/repos","events_url":"https://api.github.com/users/scaldi/events{/privacy}","received_events_url":"https://api.github.com/users/scaldi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scaldi/scaldi-play","description":"Scaldi integration for Play framework","fork":false,"url":"https://api.github.com/repos/scaldi/scaldi-play","forks_url":"https://api.github.com/repos/scaldi/scaldi-play/forks","keys_url":"https://api.github.com/repos/scaldi/scaldi-play/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scaldi/scaldi-play/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scaldi/scaldi-play/teams","hooks_url":"https://api.github.com/repos/scaldi/scaldi-play/hooks","issue_events_url":"https://api.github.com/repos/scaldi/scaldi-play/issues/events{/number}","events_url":"https://api.github.com/repos/scaldi/scaldi-play/events","assignees_url":"https://api.github.com/repos/scaldi/scaldi-play/assignees{/user}","branches_url":"https://api.github.com/repos/scaldi/scaldi-play/branches{/branch}","tags_url":"https://api.github.com/repos/scaldi/scaldi-play/tags","blobs_url":"https://api.github.com/repos/scaldi/scaldi-play/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scaldi/scaldi-play/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scaldi/scaldi-play/git/refs{/sha}","trees_url":"https://api.github.com/repos/scaldi/scaldi-play/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scaldi/scaldi-play/statuses/{sha}","languages_url":"https://api.github.com/repos/scaldi/scaldi-play/languages","stargazers_url":"https://api.github.com/repos/scaldi/scaldi-play/stargazers","contributors_url":"https://api.github.com/repos/scaldi/scaldi-play/contributors","subscribers_url":"https://api.github.com/repos/scaldi/scaldi-play/subscribers","subscription_url":"https://api.github.com/repos/scaldi/scaldi-play/subscription","commits_url":"https://api.github.com/repos/scaldi/scaldi-play/commits{/sha}","git_commits_url":"https://api.github.com/repos/scaldi/scaldi-play/git/commits{/sha}","comments_url":"https://api.github.com/repos/scaldi/scaldi-play/comments{/number}","issue_comment_url":"https://api.github.com/repos/scaldi/scaldi-play/issues/comments/{number}","contents_url":"https://api.github.com/repos/scaldi/scaldi-play/contents/{+path}","compare_url":"https://api.github.com/repos/scaldi/scaldi-play/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scaldi/scaldi-play/merges","archive_url":"https://api.github.com/repos/scaldi/scaldi-play/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scaldi/scaldi-play/downloads","issues_url":"https://api.github.com/repos/scaldi/scaldi-play/issues{/number}","pulls_url":"https://api.github.com/repos/scaldi/scaldi-play/pulls{/number}","milestones_url":"https://api.github.com/repos/scaldi/scaldi-play/milestones{/number}","notifications_url":"https://api.github.com/repos/scaldi/scaldi-play/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scaldi/scaldi-play/labels{/name}","releases_url":"https://api.github.com/repos/scaldi/scaldi-play/releases{/id}","created_at":"2013-05-25T17:23:28Z","updated_at":"2014-07-29T17:47:58Z","pushed_at":"2014-07-06T00:07:56Z","git_url":"git://github.com/scaldi/scaldi-play.git","ssh_url":"git@github.com:scaldi/scaldi-play.git","clone_url":"https://github.com/scaldi/scaldi-play.git","svn_url":"https://github.com/scaldi/scaldi-play","homepage":"http://scaldi.org","size":873,"stargazers_count":10,"watchers_count":10,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scaldi/scaldi-play/pulls/7"},"html":{"href":"https://github.com/scaldi/scaldi-play/pull/7"},"issue":{"href":"https://api.github.com/repos/scaldi/scaldi-play/issues/7"},"comments":{"href":"https://api.github.com/repos/scaldi/scaldi-play/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/scaldi/scaldi-play/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/scaldi/scaldi-play/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/scaldi/scaldi-play/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/scaldi/scaldi-play/statuses/e130670d4d99f0abd314a12ee58f0a146d259be2"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":26,"deletions":8,"changed_files":1}}