GitHub PullRequestReviewCommentEvent at 2014-10-17 22:02:13
Repository: phobos
Actor: monarchdodra
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/comments/19046167","id":19046167,"diff_hunk":"@@ -1114,7 +1114,7 @@ auto n = rnd.front;\n ----\n */\n \n-@property uint unpredictableSeed()\n+@property uint unpredictableSeed() @trusted","path":"std/random.d","position":5,"original_position":5,"commit_id":"f70e1e41e453eec3a879770035128b5f3f9be89c","original_commit_id":"f70e1e41e453eec3a879770035128b5f3f9be89c","user":{"login":"monarchdodra","id":1911406,"avatar_url":"https://avatars.githubusercontent.com/u/1911406?v=2","gravatar_id":"","url":"https://api.github.com/users/monarchdodra","html_url":"https://github.com/monarchdodra","followers_url":"https://api.github.com/users/monarchdodra/followers","following_url":"https://api.github.com/users/monarchdodra/following{/other_user}","gists_url":"https://api.github.com/users/monarchdodra/gists{/gist_id}","starred_url":"https://api.github.com/users/monarchdodra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monarchdodra/subscriptions","organizations_url":"https://api.github.com/users/monarchdodra/orgs","repos_url":"https://api.github.com/users/monarchdodra/repos","events_url":"https://api.github.com/users/monarchdodra/events{/privacy}","received_events_url":"https://api.github.com/users/monarchdodra/received_events","type":"User","site_admin":false},"body":"Last time this came up, we left it as system. For reference:\r\nhttps://github.com/D-Programming-Language/phobos/pull/2051#issuecomment-39024131","created_at":"2014-10-17T22:02:13Z","updated_at":"2014-10-17T22:02:13Z","html_url":"https://github.com/D-Programming-Language/phobos/pull/2609#discussion_r19046167","pull_request_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2609","_links":{"self":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/comments/19046167"},"html":{"href":"https://github.com/D-Programming-Language/phobos/pull/2609#discussion_r19046167"},"pull_request":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2609"}}},"pull_request":{"url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2609","id":22626013,"html_url":"https://github.com/D-Programming-Language/phobos/pull/2609","diff_url":"https://github.com/D-Programming-Language/phobos/pull/2609.diff","patch_url":"https://github.com/D-Programming-Language/phobos/pull/2609.patch","issue_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/2609","number":2609,"state":"open","locked":false,"title":"@safe'ty of find and canFind","user":{"login":"braddr","id":40242,"avatar_url":"https://avatars.githubusercontent.com/u/40242?v=2","gravatar_id":"","url":"https://api.github.com/users/braddr","html_url":"https://github.com/braddr","followers_url":"https://api.github.com/users/braddr/followers","following_url":"https://api.github.com/users/braddr/following{/other_user}","gists_url":"https://api.github.com/users/braddr/gists{/gist_id}","starred_url":"https://api.github.com/users/braddr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/braddr/subscriptions","organizations_url":"https://api.github.com/users/braddr/orgs","repos_url":"https://api.github.com/users/braddr/repos","events_url":"https://api.github.com/users/braddr/events{/privacy}","received_events_url":"https://api.github.com/users/braddr/received_events","type":"User","site_admin":false},"body":"Change find's tests to validate usability of @safe.\r\nEliminate the trustedFindRR case by pushing it down a layer in the find stack of functions.\r\nMark unpredictableSeed as @trusted (@safe is a stretch due to all the casting) so that it can be used in @safe contexts.\r\nMark canFind's tests to validate usability of @safe (which lead to the unpredictableSeed change)","created_at":"2014-10-13T04:53:04Z","updated_at":"2014-10-17T22:02:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f9f80520e9fcbbe8155fe401ba55b202a8f9a34d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2609/commits","review_comments_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2609/comments","review_comment_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/comments/{number}","comments_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/2609/comments","statuses_url":"https://api.github.com/repos/D-Programming-Language/phobos/statuses/f70e1e41e453eec3a879770035128b5f3f9be89c","head":{"label":"braddr:safe_find","ref":"safe_find","sha":"f70e1e41e453eec3a879770035128b5f3f9be89c","user":{"login":"braddr","id":40242,"avatar_url":"https://avatars.githubusercontent.com/u/40242?v=2","gravatar_id":"","url":"https://api.github.com/users/braddr","html_url":"https://github.com/braddr","followers_url":"https://api.github.com/users/braddr/followers","following_url":"https://api.github.com/users/braddr/following{/other_user}","gists_url":"https://api.github.com/users/braddr/gists{/gist_id}","starred_url":"https://api.github.com/users/braddr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/braddr/subscriptions","organizations_url":"https://api.github.com/users/braddr/orgs","repos_url":"https://api.github.com/users/braddr/repos","events_url":"https://api.github.com/users/braddr/events{/privacy}","received_events_url":"https://api.github.com/users/braddr/received_events","type":"User","site_admin":false},"repo":{"id":1286490,"name":"phobos","full_name":"braddr/phobos","owner":{"login":"braddr","id":40242,"avatar_url":"https://avatars.githubusercontent.com/u/40242?v=2","gravatar_id":"","url":"https://api.github.com/users/braddr","html_url":"https://github.com/braddr","followers_url":"https://api.github.com/users/braddr/followers","following_url":"https://api.github.com/users/braddr/following{/other_user}","gists_url":"https://api.github.com/users/braddr/gists{/gist_id}","starred_url":"https://api.github.com/users/braddr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/braddr/subscriptions","organizations_url":"https://api.github.com/users/braddr/orgs","repos_url":"https://api.github.com/users/braddr/repos","events_url":"https://api.github.com/users/braddr/events{/privacy}","received_events_url":"https://api.github.com/users/braddr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/braddr/phobos","description":"Runtime library for the D programming language","fork":true,"url":"https://api.github.com/repos/braddr/phobos","forks_url":"https://api.github.com/repos/braddr/phobos/forks","keys_url":"https://api.github.com/repos/braddr/phobos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/braddr/phobos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/braddr/phobos/teams","hooks_url":"https://api.github.com/repos/braddr/phobos/hooks","issue_events_url":"https://api.github.com/repos/braddr/phobos/issues/events{/number}","events_url":"https://api.github.com/repos/braddr/phobos/events","assignees_url":"https://api.github.com/repos/braddr/phobos/assignees{/user}","branches_url":"https://api.github.com/repos/braddr/phobos/branches{/branch}","tags_url":"https://api.github.com/repos/braddr/phobos/tags","blobs_url":"https://api.github.com/repos/braddr/phobos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/braddr/phobos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/braddr/phobos/git/refs{/sha}","trees_url":"https://api.github.com/repos/braddr/phobos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/braddr/phobos/statuses/{sha}","languages_url":"https://api.github.com/repos/braddr/phobos/languages","stargazers_url":"https://api.github.com/repos/braddr/phobos/stargazers","contributors_url":"https://api.github.com/repos/braddr/phobos/contributors","subscribers_url":"https://api.github.com/repos/braddr/phobos/subscribers","subscription_url":"https://api.github.com/repos/braddr/phobos/subscription","commits_url":"https://api.github.com/repos/braddr/phobos/commits{/sha}","git_commits_url":"https://api.github.com/repos/braddr/phobos/git/commits{/sha}","comments_url":"https://api.github.com/repos/braddr/phobos/comments{/number}","issue_comment_url":"https://api.github.com/repos/braddr/phobos/issues/comments/{number}","contents_url":"https://api.github.com/repos/braddr/phobos/contents/{+path}","compare_url":"https://api.github.com/repos/braddr/phobos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/braddr/phobos/merges","archive_url":"https://api.github.com/repos/braddr/phobos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/braddr/phobos/downloads","issues_url":"https://api.github.com/repos/braddr/phobos/issues{/number}","pulls_url":"https://api.github.com/repos/braddr/phobos/pulls{/number}","milestones_url":"https://api.github.com/repos/braddr/phobos/milestones{/number}","notifications_url":"https://api.github.com/repos/braddr/phobos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/braddr/phobos/labels{/name}","releases_url":"https://api.github.com/repos/braddr/phobos/releases{/id}","created_at":"2011-01-24T03:29:42Z","updated_at":"2013-09-21T19:00:45Z","pushed_at":"2014-10-15T09:54:11Z","git_url":"git://github.com/braddr/phobos.git","ssh_url":"git@github.com:braddr/phobos.git","clone_url":"https://github.com/braddr/phobos.git","svn_url":"https://github.com/braddr/phobos","homepage":"d-programming-language.org","size":28762,"stargazers_count":1,"watchers_count":1,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"D-Programming-Language:master","ref":"master","sha":"a5cd0d85ffb33a4db43ec5875e9d1126defd91e7","user":{"login":"D-Programming-Language","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=2","gravatar_id":"","url":"https://api.github.com/users/D-Programming-Language","html_url":"https://github.com/D-Programming-Language","followers_url":"https://api.github.com/users/D-Programming-Language/followers","following_url":"https://api.github.com/users/D-Programming-Language/following{/other_user}","gists_url":"https://api.github.com/users/D-Programming-Language/gists{/gist_id}","starred_url":"https://api.github.com/users/D-Programming-Language/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D-Programming-Language/subscriptions","organizations_url":"https://api.github.com/users/D-Programming-Language/orgs","repos_url":"https://api.github.com/users/D-Programming-Language/repos","events_url":"https://api.github.com/users/D-Programming-Language/events{/privacy}","received_events_url":"https://api.github.com/users/D-Programming-Language/received_events","type":"Organization","site_admin":false},"repo":{"id":1257084,"name":"phobos","full_name":"D-Programming-Language/phobos","owner":{"login":"D-Programming-Language","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=2","gravatar_id":"","url":"https://api.github.com/users/D-Programming-Language","html_url":"https://github.com/D-Programming-Language","followers_url":"https://api.github.com/users/D-Programming-Language/followers","following_url":"https://api.github.com/users/D-Programming-Language/following{/other_user}","gists_url":"https://api.github.com/users/D-Programming-Language/gists{/gist_id}","starred_url":"https://api.github.com/users/D-Programming-Language/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D-Programming-Language/subscriptions","organizations_url":"https://api.github.com/users/D-Programming-Language/orgs","repos_url":"https://api.github.com/users/D-Programming-Language/repos","events_url":"https://api.github.com/users/D-Programming-Language/events{/privacy}","received_events_url":"https://api.github.com/users/D-Programming-Language/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/D-Programming-Language/phobos","description":"The standard library of the D programming language","fork":false,"url":"https://api.github.com/repos/D-Programming-Language/phobos","forks_url":"https://api.github.com/repos/D-Programming-Language/phobos/forks","keys_url":"https://api.github.com/repos/D-Programming-Language/phobos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/D-Programming-Language/phobos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/D-Programming-Language/phobos/teams","hooks_url":"https://api.github.com/repos/D-Programming-Language/phobos/hooks","issue_events_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/events{/number}","events_url":"https://api.github.com/repos/D-Programming-Language/phobos/events","assignees_url":"https://api.github.com/repos/D-Programming-Language/phobos/assignees{/user}","branches_url":"https://api.github.com/repos/D-Programming-Language/phobos/branches{/branch}","tags_url":"https://api.github.com/repos/D-Programming-Language/phobos/tags","blobs_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/refs{/sha}","trees_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/D-Programming-Language/phobos/statuses/{sha}","languages_url":"https://api.github.com/repos/D-Programming-Language/phobos/languages","stargazers_url":"https://api.github.com/repos/D-Programming-Language/phobos/stargazers","contributors_url":"https://api.github.com/repos/D-Programming-Language/phobos/contributors","subscribers_url":"https://api.github.com/repos/D-Programming-Language/phobos/subscribers","subscription_url":"https://api.github.com/repos/D-Programming-Language/phobos/subscription","commits_url":"https://api.github.com/repos/D-Programming-Language/phobos/commits{/sha}","git_commits_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/commits{/sha}","comments_url":"https://api.github.com/repos/D-Programming-Language/phobos/comments{/number}","issue_comment_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/comments/{number}","contents_url":"https://api.github.com/repos/D-Programming-Language/phobos/contents/{+path}","compare_url":"https://api.github.com/repos/D-Programming-Language/phobos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/D-Programming-Language/phobos/merges","archive_url":"https://api.github.com/repos/D-Programming-Language/phobos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/D-Programming-Language/phobos/downloads","issues_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues{/number}","pulls_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls{/number}","milestones_url":"https://api.github.com/repos/D-Programming-Language/phobos/milestones{/number}","notifications_url":"https://api.github.com/repos/D-Programming-Language/phobos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/D-Programming-Language/phobos/labels{/name}","releases_url":"https://api.github.com/repos/D-Programming-Language/phobos/releases{/id}","created_at":"2011-01-15T07:00:06Z","updated_at":"2014-10-17T14:57:26Z","pushed_at":"2014-10-17T16:40:18Z","git_url":"git://github.com/D-Programming-Language/phobos.git","ssh_url":"git@github.com:D-Programming-Language/phobos.git","clone_url":"https://github.com/D-Programming-Language/phobos.git","svn_url":"https://github.com/D-Programming-Language/phobos","homepage":"dlang.org/phobos","size":65787,"stargazers_count":525,"watchers_count":525,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":352,"mirror_url":null,"open_issues_count":43,"forks":352,"open_issues":43,"watchers":525,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2609"},"html":{"href":"https://github.com/D-Programming-Language/phobos/pull/2609"},"issue":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/issues/2609"},"comments":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/issues/2609/comments"},"review_comments":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2609/comments"},"review_comment":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2609/commits"},"statuses":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/statuses/f70e1e41e453eec3a879770035128b5f3f9be89c"}}}}