GitHub PullRequestReviewCommentEvent at 2014-08-19 00:08:40
Repository: rspec-rails
Actor: cupakromer
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/rspec/rspec-rails/pulls/comments/16390347","id":16390347,"diff_hunk":"@@ -1,42 +1,15 @@\n #!/bin/bash\n \n set -ex\n+source script/functions.sh\n \n-function check_documentation_coverage {\n-  bin/yard stats --list-undoc | ruby -e \"\n-    while line = gets\n-      coverage ||= line[/([\\d\\.]+)% documented/, 1]\n-      puts line\n-    end\n-\n-    unless Float(coverage) == 100\n-      puts \\\"\\n\\nMissing documentation coverage (currently at #{coverage}%)\\\"\n-      exit(1)\n-    end\n-  \"\n-}\n-\n-function documentation_enforced {\n-  if [ -x ./bin/yard ]; then\n-    return 0\n-  else\n-    return 1\n-  fi\n-}\n-\n-function style_and_lint_enforced {\n- if [ -x ./bin/rubocop ]; then\n-   return 0\n- else\n-   return 1\n- fi\n-}\n-\n-function check_style_and_lint {\n-  bin/rubocop lib\n-}\n+# Allow repos to override the default functions and add their own\n+if [ -f script/custom_functions.sh ]; then\n+  source script/custom_functions.sh","path":"script/run_build","position":41,"original_position":41,"commit_id":"8d426f21c711f4eaf4d35450865c931b9c058795","original_commit_id":"8d426f21c711f4eaf4d35450865c931b9c058795","user":{"login":"cupakromer","id":1524496,"avatar_url":"https://avatars.githubusercontent.com/u/1524496?v=2","gravatar_id":"27a7b65804bca13793acd4b67fa32d83","url":"https://api.github.com/users/cupakromer","html_url":"https://github.com/cupakromer","followers_url":"https://api.github.com/users/cupakromer/followers","following_url":"https://api.github.com/users/cupakromer/following{/other_user}","gists_url":"https://api.github.com/users/cupakromer/gists{/gist_id}","starred_url":"https://api.github.com/users/cupakromer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cupakromer/subscriptions","organizations_url":"https://api.github.com/users/cupakromer/orgs","repos_url":"https://api.github.com/users/cupakromer/repos","events_url":"https://api.github.com/users/cupakromer/events{/privacy}","received_events_url":"https://api.github.com/users/cupakromer/received_events","type":"User","site_admin":false},"body":"Sure, I didn't give too much though to the original name beyond it being customizable.","created_at":"2014-08-19T00:08:40Z","updated_at":"2014-08-19T00:08:40Z","html_url":"https://github.com/rspec/rspec-rails/pull/1144#discussion_r16390347","pull_request_url":"https://api.github.com/repos/rspec/rspec-rails/pulls/1144","_links":{"self":{"href":"https://api.github.com/repos/rspec/rspec-rails/pulls/comments/16390347"},"html":{"href":"https://github.com/rspec/rspec-rails/pull/1144#discussion_r16390347"},"pull_request":{"href":"https://api.github.com/repos/rspec/rspec-rails/pulls/1144"}}},"pull_request":{"url":"https://api.github.com/repos/rspec/rspec-rails/pulls/1144","id":19881895,"html_url":"https://github.com/rspec/rspec-rails/pull/1144","diff_url":"https://github.com/rspec/rspec-rails/pull/1144.diff","patch_url":"https://github.com/rspec/rspec-rails/pull/1144.patch","issue_url":"https://api.github.com/repos/rspec/rspec-rails/issues/1144","number":1144,"state":"open","locked":false,"title":"Port some of the rspec dev scripts","user":{"login":"cupakromer","id":1524496,"avatar_url":"https://avatars.githubusercontent.com/u/1524496?v=2","gravatar_id":"27a7b65804bca13793acd4b67fa32d83","url":"https://api.github.com/users/cupakromer","html_url":"https://github.com/cupakromer","followers_url":"https://api.github.com/users/cupakromer/followers","following_url":"https://api.github.com/users/cupakromer/following{/other_user}","gists_url":"https://api.github.com/users/cupakromer/gists{/gist_id}","starred_url":"https://api.github.com/users/cupakromer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cupakromer/subscriptions","organizations_url":"https://api.github.com/users/cupakromer/orgs","repos_url":"https://api.github.com/users/cupakromer/repos","events_url":"https://api.github.com/users/cupakromer/events{/privacy}","received_events_url":"https://api.github.com/users/cupakromer/received_events","type":"User","site_admin":false},"body":"Initial steps towards  #1140. Several of the [rspec/rspec-dev](https://github.com/rspec/rspec-dev) scripts were able to be copied directly. Others needed some slight tweaks.\r\n\r\nAddress missing travis retry scripts (ref rspec/rspec-dev#66 and rspec/rspec-dev#76). Getting the `travis_retry` function into the rake build process is more complicated than expected. Using rake's `sh` command with a `source` and a `travis_retry eval` CLI chain works locally, but fails on Travis CI. I quickly peeked at the internals of rake's `sh` and did not see a reason for the failures.\r\n\r\nTo get around this problem, add an actual bash script to `templates/`. On generating the example app, copy this script, update the proper paths, and make the script executable.","created_at":"2014-08-16T17:55:15Z","updated_at":"2014-08-19T00:08:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f9f319ae632ca9e5f0e54f37166e4424a472f89","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rspec/rspec-rails/pulls/1144/commits","review_comments_url":"https://api.github.com/repos/rspec/rspec-rails/pulls/1144/comments","review_comment_url":"https://api.github.com/repos/rspec/rspec-rails/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rspec/rspec-rails/issues/1144/comments","statuses_url":"https://api.github.com/repos/rspec/rspec-rails/statuses/8d426f21c711f4eaf4d35450865c931b9c058795","head":{"label":"rspec:port-rspec-support-scripts","ref":"port-rspec-support-scripts","sha":"8d426f21c711f4eaf4d35450865c931b9c058795","user":{"login":"rspec","id":22388,"avatar_url":"https://avatars.githubusercontent.com/u/22388?v=2","gravatar_id":"e482036908235889a3439104bdbc3eb9","url":"https://api.github.com/users/rspec","html_url":"https://github.com/rspec","followers_url":"https://api.github.com/users/rspec/followers","following_url":"https://api.github.com/users/rspec/following{/other_user}","gists_url":"https://api.github.com/users/rspec/gists{/gist_id}","starred_url":"https://api.github.com/users/rspec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rspec/subscriptions","organizations_url":"https://api.github.com/users/rspec/orgs","repos_url":"https://api.github.com/users/rspec/repos","events_url":"https://api.github.com/users/rspec/events{/privacy}","received_events_url":"https://api.github.com/users/rspec/received_events","type":"Organization","site_admin":false},"repo":{"id":447184,"name":"rspec-rails","full_name":"rspec/rspec-rails","owner":{"login":"rspec","id":22388,"avatar_url":"https://avatars.githubusercontent.com/u/22388?v=2","gravatar_id":"e482036908235889a3439104bdbc3eb9","url":"https://api.github.com/users/rspec","html_url":"https://github.com/rspec","followers_url":"https://api.github.com/users/rspec/followers","following_url":"https://api.github.com/users/rspec/following{/other_user}","gists_url":"https://api.github.com/users/rspec/gists{/gist_id}","starred_url":"https://api.github.com/users/rspec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rspec/subscriptions","organizations_url":"https://api.github.com/users/rspec/orgs","repos_url":"https://api.github.com/users/rspec/repos","events_url":"https://api.github.com/users/rspec/events{/privacy}","received_events_url":"https://api.github.com/users/rspec/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rspec/rspec-rails","description":"RSpec for Rails-3+","fork":false,"url":"https://api.github.com/repos/rspec/rspec-rails","forks_url":"https://api.github.com/repos/rspec/rspec-rails/forks","keys_url":"https://api.github.com/repos/rspec/rspec-rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rspec/rspec-rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rspec/rspec-rails/teams","hooks_url":"https://api.github.com/repos/rspec/rspec-rails/hooks","issue_events_url":"https://api.github.com/repos/rspec/rspec-rails/issues/events{/number}","events_url":"https://api.github.com/repos/rspec/rspec-rails/events","assignees_url":"https://api.github.com/repos/rspec/rspec-rails/assignees{/user}","branches_url":"https://api.github.com/repos/rspec/rspec-rails/branches{/branch}","tags_url":"https://api.github.com/repos/rspec/rspec-rails/tags","blobs_url":"https://api.github.com/repos/rspec/rspec-rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rspec/rspec-rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rspec/rspec-rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/rspec/rspec-rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rspec/rspec-rails/statuses/{sha}","languages_url":"https://api.github.com/repos/rspec/rspec-rails/languages","stargazers_url":"https://api.github.com/repos/rspec/rspec-rails/stargazers","contributors_url":"https://api.github.com/repos/rspec/rspec-rails/contributors","subscribers_url":"https://api.github.com/repos/rspec/rspec-rails/subscribers","subscription_url":"https://api.github.com/repos/rspec/rspec-rails/subscription","commits_url":"https://api.github.com/repos/rspec/rspec-rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/rspec/rspec-rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/rspec/rspec-rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/rspec/rspec-rails/issues/comments/{number}","contents_url":"https://api.github.com/repos/rspec/rspec-rails/contents/{+path}","compare_url":"https://api.github.com/repos/rspec/rspec-rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rspec/rspec-rails/merges","archive_url":"https://api.github.com/repos/rspec/rspec-rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rspec/rspec-rails/downloads","issues_url":"https://api.github.com/repos/rspec/rspec-rails/issues{/number}","pulls_url":"https://api.github.com/repos/rspec/rspec-rails/pulls{/number}","milestones_url":"https://api.github.com/repos/rspec/rspec-rails/milestones{/number}","notifications_url":"https://api.github.com/repos/rspec/rspec-rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rspec/rspec-rails/labels{/name}","releases_url":"https://api.github.com/repos/rspec/rspec-rails/releases{/id}","created_at":"2009-12-23T16:40:53Z","updated_at":"2014-08-17T18:11:42Z","pushed_at":"2014-08-17T22:46:04Z","git_url":"git://github.com/rspec/rspec-rails.git","ssh_url":"git@github.com:rspec/rspec-rails.git","clone_url":"https://github.com/rspec/rspec-rails.git","svn_url":"https://github.com/rspec/rspec-rails","homepage":"http://relishapp.com/rspec/rspec-rails","size":9159,"stargazers_count":2040,"watchers_count":2040,"language":"Ruby","has_issues":true,"has_downloads":false,"has_wiki":false,"forks_count":399,"mirror_url":null,"open_issues_count":15,"forks":399,"open_issues":15,"watchers":2040,"default_branch":"master"}},"base":{"label":"rspec:master","ref":"master","sha":"ddc80b24f614937483fb0920ecb2c5723833506e","user":{"login":"rspec","id":22388,"avatar_url":"https://avatars.githubusercontent.com/u/22388?v=2","gravatar_id":"e482036908235889a3439104bdbc3eb9","url":"https://api.github.com/users/rspec","html_url":"https://github.com/rspec","followers_url":"https://api.github.com/users/rspec/followers","following_url":"https://api.github.com/users/rspec/following{/other_user}","gists_url":"https://api.github.com/users/rspec/gists{/gist_id}","starred_url":"https://api.github.com/users/rspec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rspec/subscriptions","organizations_url":"https://api.github.com/users/rspec/orgs","repos_url":"https://api.github.com/users/rspec/repos","events_url":"https://api.github.com/users/rspec/events{/privacy}","received_events_url":"https://api.github.com/users/rspec/received_events","type":"Organization","site_admin":false},"repo":{"id":447184,"name":"rspec-rails","full_name":"rspec/rspec-rails","owner":{"login":"rspec","id":22388,"avatar_url":"https://avatars.githubusercontent.com/u/22388?v=2","gravatar_id":"e482036908235889a3439104bdbc3eb9","url":"https://api.github.com/users/rspec","html_url":"https://github.com/rspec","followers_url":"https://api.github.com/users/rspec/followers","following_url":"https://api.github.com/users/rspec/following{/other_user}","gists_url":"https://api.github.com/users/rspec/gists{/gist_id}","starred_url":"https://api.github.com/users/rspec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rspec/subscriptions","organizations_url":"https://api.github.com/users/rspec/orgs","repos_url":"https://api.github.com/users/rspec/repos","events_url":"https://api.github.com/users/rspec/events{/privacy}","received_events_url":"https://api.github.com/users/rspec/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rspec/rspec-rails","description":"RSpec for Rails-3+","fork":false,"url":"https://api.github.com/repos/rspec/rspec-rails","forks_url":"https://api.github.com/repos/rspec/rspec-rails/forks","keys_url":"https://api.github.com/repos/rspec/rspec-rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rspec/rspec-rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rspec/rspec-rails/teams","hooks_url":"https://api.github.com/repos/rspec/rspec-rails/hooks","issue_events_url":"https://api.github.com/repos/rspec/rspec-rails/issues/events{/number}","events_url":"https://api.github.com/repos/rspec/rspec-rails/events","assignees_url":"https://api.github.com/repos/rspec/rspec-rails/assignees{/user}","branches_url":"https://api.github.com/repos/rspec/rspec-rails/branches{/branch}","tags_url":"https://api.github.com/repos/rspec/rspec-rails/tags","blobs_url":"https://api.github.com/repos/rspec/rspec-rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rspec/rspec-rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rspec/rspec-rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/rspec/rspec-rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rspec/rspec-rails/statuses/{sha}","languages_url":"https://api.github.com/repos/rspec/rspec-rails/languages","stargazers_url":"https://api.github.com/repos/rspec/rspec-rails/stargazers","contributors_url":"https://api.github.com/repos/rspec/rspec-rails/contributors","subscribers_url":"https://api.github.com/repos/rspec/rspec-rails/subscribers","subscription_url":"https://api.github.com/repos/rspec/rspec-rails/subscription","commits_url":"https://api.github.com/repos/rspec/rspec-rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/rspec/rspec-rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/rspec/rspec-rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/rspec/rspec-rails/issues/comments/{number}","contents_url":"https://api.github.com/repos/rspec/rspec-rails/contents/{+path}","compare_url":"https://api.github.com/repos/rspec/rspec-rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rspec/rspec-rails/merges","archive_url":"https://api.github.com/repos/rspec/rspec-rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rspec/rspec-rails/downloads","issues_url":"https://api.github.com/repos/rspec/rspec-rails/issues{/number}","pulls_url":"https://api.github.com/repos/rspec/rspec-rails/pulls{/number}","milestones_url":"https://api.github.com/repos/rspec/rspec-rails/milestones{/number}","notifications_url":"https://api.github.com/repos/rspec/rspec-rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rspec/rspec-rails/labels{/name}","releases_url":"https://api.github.com/repos/rspec/rspec-rails/releases{/id}","created_at":"2009-12-23T16:40:53Z","updated_at":"2014-08-17T18:11:42Z","pushed_at":"2014-08-17T22:46:04Z","git_url":"git://github.com/rspec/rspec-rails.git","ssh_url":"git@github.com:rspec/rspec-rails.git","clone_url":"https://github.com/rspec/rspec-rails.git","svn_url":"https://github.com/rspec/rspec-rails","homepage":"http://relishapp.com/rspec/rspec-rails","size":9159,"stargazers_count":2040,"watchers_count":2040,"language":"Ruby","has_issues":true,"has_downloads":false,"has_wiki":false,"forks_count":399,"mirror_url":null,"open_issues_count":15,"forks":399,"open_issues":15,"watchers":2040,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rspec/rspec-rails/pulls/1144"},"html":{"href":"https://github.com/rspec/rspec-rails/pull/1144"},"issue":{"href":"https://api.github.com/repos/rspec/rspec-rails/issues/1144"},"comments":{"href":"https://api.github.com/repos/rspec/rspec-rails/issues/1144/comments"},"review_comments":{"href":"https://api.github.com/repos/rspec/rspec-rails/pulls/1144/comments"},"review_comment":{"href":"https://api.github.com/repos/rspec/rspec-rails/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rspec/rspec-rails/pulls/1144/commits"},"statuses":{"href":"https://api.github.com/repos/rspec/rspec-rails/statuses/8d426f21c711f4eaf4d35450865c931b9c058795"}}}}