GitHub PullRequestReviewCommentEvent at 2014-04-02 12:15:20
Repository: brooklyn
Actor: alasdairhodge
Payload: {"comment":{"url":"https://api.github.com/repos/brooklyncentral/brooklyn/pulls/comments/11202139","id":11202139,"diff_hunk":"@@ -61,19 +62,17 @@ protected String getTemplateConfigurationUrl() {\n     @Override\n     public void customize() {\n         Networking.checkPortsValid(ImmutableMap.of(\"jmxPort\", getJmxPort(), \"openWirePort\", getOpenWirePort()));\n-        newScript(CUSTOMIZING).\n-                body.append(\n-                String.format(\"cp -R %s/{bin,conf,data,lib,webapps} .\", getExpandedInstallDir()),\n-                \n-                // Required in version 5.5.1 (at least), but not in version 5.7.0\n-                \"sed -i.bk 's/\\\\[-z \\\"$JAVA_HOME\\\"]/\\\\[ -z \\\"$JAVA_HOME\\\" ]/g' bin/activemq\",\n-                // Stop it writing to dev null on start\n-                \"sed -i.bk \\\"s/\\\\(ACTIVEMQ_HOME..bin.run.jar.*\\\\)>.dev.null/\\\\1/\\\" bin/activemq\",\n-                \n-                // Required if launching multiple AMQ's, prevent jetty port conflicts\n-                \"sed -i.bk 's/8161/\"+getEntity().getAttribute(ActiveMQBroker.AMQ_JETTY_PORT)+\"/g' conf/jetty.xml\"\n-                \n-                ).execute();\n+        newScript(CUSTOMIZING)\n+                .body.append(\n+                        String.format(\"cp -R %s/{bin,conf,data,lib,webapps} .\", getExpandedInstallDir()),","path":"software/messaging/src/main/java/brooklyn/entity/messaging/activemq/ActiveMQSshDriver.java","position":33,"original_position":33,"commit_id":"0bb499315e89ccff0949cd10f55455a2e026c047","original_commit_id":"0bb499315e89ccff0949cd10f55455a2e026c047","user":{"login":"alasdairhodge","id":837473,"avatar_url":"https://avatars.githubusercontent.com/u/837473?","gravatar_id":"fb00fcfe9c49ae139697278d066d4279","url":"https://api.github.com/users/alasdairhodge","html_url":"https://github.com/alasdairhodge","followers_url":"https://api.github.com/users/alasdairhodge/followers","following_url":"https://api.github.com/users/alasdairhodge/following{/other_user}","gists_url":"https://api.github.com/users/alasdairhodge/gists{/gist_id}","starred_url":"https://api.github.com/users/alasdairhodge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alasdairhodge/subscriptions","organizations_url":"https://api.github.com/users/alasdairhodge/orgs","repos_url":"https://api.github.com/users/alasdairhodge/repos","events_url":"https://api.github.com/users/alasdairhodge/events{/privacy}","received_events_url":"https://api.github.com/users/alasdairhodge/received_events","type":"User","site_admin":false},"body":"Bonus points if you statically import `String.format`, as done elsewhere.","created_at":"2014-04-02T12:15:20Z","updated_at":"2014-04-02T12:15:20Z","html_url":"https://github.com/brooklyncentral/brooklyn/pull/1299#discussion_r11202139","pull_request_url":"https://api.github.com/repos/brooklyncentral/brooklyn/pulls/1299","_links":{"self":{"href":"https://api.github.com/repos/brooklyncentral/brooklyn/pulls/comments/11202139"},"html":{"href":"https://github.com/brooklyncentral/brooklyn/pull/1299#discussion_r11202139"},"pull_request":{"href":"https://api.github.com/repos/brooklyncentral/brooklyn/pulls/1299"}}}}