GitHub PullRequestReviewCommentEvent at 2014-07-01 00:14:36
Repository: jclouds
Actor: demobox
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/jclouds/jclouds/pulls/comments/14383320","id":14383320,"diff_hunk":"@@ -77,8 +77,13 @@ public AllocateAndAddFloatingIpToNode(@Named(TIMEOUT_NODE_RUNNING) Predicate<Ato\n \n       FloatingIP ip = null;\n       try {\n-         logger.debug(\">> allocating or reassigning floating ip for node(%s)\", node.getId());\n+         \n+    \t  logger.debug(\">> allocating or reassigning floating ip for node(%s)\", node.getId());\n+         ","path":"apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/compute/functions/AllocateAndAddFloatingIpToNode.java","position":7,"original_position":7,"commit_id":"5a04f26054256ab100aa3a587d7d7c76094caeda","original_commit_id":"5a04f26054256ab100aa3a587d7d7c76094caeda","user":{"login":"demobox","id":223702,"avatar_url":"https://avatars.githubusercontent.com/u/223702?","gravatar_id":"e2561ae503aae3d6fac85f8fe228d5ce","url":"https://api.github.com/users/demobox","html_url":"https://github.com/demobox","followers_url":"https://api.github.com/users/demobox/followers","following_url":"https://api.github.com/users/demobox/following{/other_user}","gists_url":"https://api.github.com/users/demobox/gists{/gist_id}","starred_url":"https://api.github.com/users/demobox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/demobox/subscriptions","organizations_url":"https://api.github.com/users/demobox/orgs","repos_url":"https://api.github.com/users/demobox/repos","events_url":"https://api.github.com/users/demobox/events{/privacy}","received_events_url":"https://api.github.com/users/demobox/received_events","type":"User","site_admin":false},"body":"[minor] remove new blank lines here?","created_at":"2014-07-01T00:14:36Z","updated_at":"2014-07-01T00:14:36Z","html_url":"https://github.com/jclouds/jclouds/pull/425#discussion_r14383320","pull_request_url":"https://api.github.com/repos/jclouds/jclouds/pulls/425","_links":{"self":{"href":"https://api.github.com/repos/jclouds/jclouds/pulls/comments/14383320"},"html":{"href":"https://github.com/jclouds/jclouds/pull/425#discussion_r14383320"},"pull_request":{"href":"https://api.github.com/repos/jclouds/jclouds/pulls/425"}}},"pull_request":{"url":"https://api.github.com/repos/jclouds/jclouds/pulls/425","id":17794900,"html_url":"https://github.com/jclouds/jclouds/pull/425","diff_url":"https://github.com/jclouds/jclouds/pull/425.diff","patch_url":"https://github.com/jclouds/jclouds/pull/425.patch","issue_url":"https://api.github.com/repos/jclouds/jclouds/issues/425","number":425,"state":"open","title":"JCLOUDS-607: ComputeService.createNodesInGroup throws NPE on FloatingIPA...","user":{"login":"cdancy","id":7871459,"avatar_url":"https://avatars.githubusercontent.com/u/7871459?","gravatar_id":"a0ee78d14d453f8a2ec9f9675fcf7a10","url":"https://api.github.com/users/cdancy","html_url":"https://github.com/cdancy","followers_url":"https://api.github.com/users/cdancy/followers","following_url":"https://api.github.com/users/cdancy/following{/other_user}","gists_url":"https://api.github.com/users/cdancy/gists{/gist_id}","starred_url":"https://api.github.com/users/cdancy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdancy/subscriptions","organizations_url":"https://api.github.com/users/cdancy/orgs","repos_url":"https://api.github.com/users/cdancy/repos","events_url":"https://api.github.com/users/cdancy/events{/privacy}","received_events_url":"https://api.github.com/users/cdancy/received_events","type":"User","site_admin":false},"body":"Addresses possible returned null value from 'FloatingIPApi.create()'. If upon check we find null then throw InsufficientResourcesException. This in turn will make a second check at IP allocation by iterating through 'FloatingIPApi.list()' and grabbing an available IP. If this subsequent call fails then re-throw InsufficientResourcesException.","created_at":"2014-06-30T20:08:29Z","updated_at":"2014-07-01T00:14:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"71a2130eeeb94235dfd5195dd0faafa231040967","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jclouds/jclouds/pulls/425/commits","review_comments_url":"https://api.github.com/repos/jclouds/jclouds/pulls/425/comments","review_comment_url":"https://api.github.com/repos/jclouds/jclouds/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jclouds/jclouds/issues/425/comments","statuses_url":"https://api.github.com/repos/jclouds/jclouds/statuses/5a04f26054256ab100aa3a587d7d7c76094caeda","head":{"label":"cdancy:JCLOUDS-607","ref":"JCLOUDS-607","sha":"5a04f26054256ab100aa3a587d7d7c76094caeda","user":{"login":"cdancy","id":7871459,"avatar_url":"https://avatars.githubusercontent.com/u/7871459?","gravatar_id":"a0ee78d14d453f8a2ec9f9675fcf7a10","url":"https://api.github.com/users/cdancy","html_url":"https://github.com/cdancy","followers_url":"https://api.github.com/users/cdancy/followers","following_url":"https://api.github.com/users/cdancy/following{/other_user}","gists_url":"https://api.github.com/users/cdancy/gists{/gist_id}","starred_url":"https://api.github.com/users/cdancy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdancy/subscriptions","organizations_url":"https://api.github.com/users/cdancy/orgs","repos_url":"https://api.github.com/users/cdancy/repos","events_url":"https://api.github.com/users/cdancy/events{/privacy}","received_events_url":"https://api.github.com/users/cdancy/received_events","type":"User","site_admin":false},"repo":{"id":20771050,"name":"jclouds","full_name":"cdancy/jclouds","owner":{"login":"cdancy","id":7871459,"avatar_url":"https://avatars.githubusercontent.com/u/7871459?","gravatar_id":"a0ee78d14d453f8a2ec9f9675fcf7a10","url":"https://api.github.com/users/cdancy","html_url":"https://github.com/cdancy","followers_url":"https://api.github.com/users/cdancy/followers","following_url":"https://api.github.com/users/cdancy/following{/other_user}","gists_url":"https://api.github.com/users/cdancy/gists{/gist_id}","starred_url":"https://api.github.com/users/cdancy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdancy/subscriptions","organizations_url":"https://api.github.com/users/cdancy/orgs","repos_url":"https://api.github.com/users/cdancy/repos","events_url":"https://api.github.com/users/cdancy/events{/privacy}","received_events_url":"https://api.github.com/users/cdancy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cdancy/jclouds","description":"Read-only mirror of ASF Git Repo for jclouds","fork":true,"url":"https://api.github.com/repos/cdancy/jclouds","forks_url":"https://api.github.com/repos/cdancy/jclouds/forks","keys_url":"https://api.github.com/repos/cdancy/jclouds/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cdancy/jclouds/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cdancy/jclouds/teams","hooks_url":"https://api.github.com/repos/cdancy/jclouds/hooks","issue_events_url":"https://api.github.com/repos/cdancy/jclouds/issues/events{/number}","events_url":"https://api.github.com/repos/cdancy/jclouds/events","assignees_url":"https://api.github.com/repos/cdancy/jclouds/assignees{/user}","branches_url":"https://api.github.com/repos/cdancy/jclouds/branches{/branch}","tags_url":"https://api.github.com/repos/cdancy/jclouds/tags","blobs_url":"https://api.github.com/repos/cdancy/jclouds/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cdancy/jclouds/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cdancy/jclouds/git/refs{/sha}","trees_url":"https://api.github.com/repos/cdancy/jclouds/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cdancy/jclouds/statuses/{sha}","languages_url":"https://api.github.com/repos/cdancy/jclouds/languages","stargazers_url":"https://api.github.com/repos/cdancy/jclouds/stargazers","contributors_url":"https://api.github.com/repos/cdancy/jclouds/contributors","subscribers_url":"https://api.github.com/repos/cdancy/jclouds/subscribers","subscription_url":"https://api.github.com/repos/cdancy/jclouds/subscription","commits_url":"https://api.github.com/repos/cdancy/jclouds/commits{/sha}","git_commits_url":"https://api.github.com/repos/cdancy/jclouds/git/commits{/sha}","comments_url":"https://api.github.com/repos/cdancy/jclouds/comments{/number}","issue_comment_url":"https://api.github.com/repos/cdancy/jclouds/issues/comments/{number}","contents_url":"https://api.github.com/repos/cdancy/jclouds/contents/{+path}","compare_url":"https://api.github.com/repos/cdancy/jclouds/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cdancy/jclouds/merges","archive_url":"https://api.github.com/repos/cdancy/jclouds/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cdancy/jclouds/downloads","issues_url":"https://api.github.com/repos/cdancy/jclouds/issues{/number}","pulls_url":"https://api.github.com/repos/cdancy/jclouds/pulls{/number}","milestones_url":"https://api.github.com/repos/cdancy/jclouds/milestones{/number}","notifications_url":"https://api.github.com/repos/cdancy/jclouds/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cdancy/jclouds/labels{/name}","releases_url":"https://api.github.com/repos/cdancy/jclouds/releases{/id}","created_at":"2014-06-12T14:45:54Z","updated_at":"2014-06-30T18:12:19Z","pushed_at":"2014-06-30T20:04:15Z","git_url":"git://github.com/cdancy/jclouds.git","ssh_url":"git@github.com:cdancy/jclouds.git","clone_url":"https://github.com/cdancy/jclouds.git","svn_url":"https://github.com/cdancy/jclouds","homepage":null,"size":69907,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jclouds:master","ref":"master","sha":"eb884e7c09be3d86195a997188a014f96ad14e73","user":{"login":"jclouds","id":108982,"avatar_url":"https://avatars.githubusercontent.com/u/108982?","gravatar_id":"08fdc408ec6d07b292b8fdf46b1e3e1e","url":"https://api.github.com/users/jclouds","html_url":"https://github.com/jclouds","followers_url":"https://api.github.com/users/jclouds/followers","following_url":"https://api.github.com/users/jclouds/following{/other_user}","gists_url":"https://api.github.com/users/jclouds/gists{/gist_id}","starred_url":"https://api.github.com/users/jclouds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jclouds/subscriptions","organizations_url":"https://api.github.com/users/jclouds/orgs","repos_url":"https://api.github.com/users/jclouds/repos","events_url":"https://api.github.com/users/jclouds/events{/privacy}","received_events_url":"https://api.github.com/users/jclouds/received_events","type":"Organization","site_admin":false},"repo":{"id":10040960,"name":"jclouds","full_name":"jclouds/jclouds","owner":{"login":"jclouds","id":108982,"avatar_url":"https://avatars.githubusercontent.com/u/108982?","gravatar_id":"08fdc408ec6d07b292b8fdf46b1e3e1e","url":"https://api.github.com/users/jclouds","html_url":"https://github.com/jclouds","followers_url":"https://api.github.com/users/jclouds/followers","following_url":"https://api.github.com/users/jclouds/following{/other_user}","gists_url":"https://api.github.com/users/jclouds/gists{/gist_id}","starred_url":"https://api.github.com/users/jclouds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jclouds/subscriptions","organizations_url":"https://api.github.com/users/jclouds/orgs","repos_url":"https://api.github.com/users/jclouds/repos","events_url":"https://api.github.com/users/jclouds/events{/privacy}","received_events_url":"https://api.github.com/users/jclouds/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jclouds/jclouds","description":"Read-only mirror of ASF Git Repo for jclouds","fork":false,"url":"https://api.github.com/repos/jclouds/jclouds","forks_url":"https://api.github.com/repos/jclouds/jclouds/forks","keys_url":"https://api.github.com/repos/jclouds/jclouds/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jclouds/jclouds/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jclouds/jclouds/teams","hooks_url":"https://api.github.com/repos/jclouds/jclouds/hooks","issue_events_url":"https://api.github.com/repos/jclouds/jclouds/issues/events{/number}","events_url":"https://api.github.com/repos/jclouds/jclouds/events","assignees_url":"https://api.github.com/repos/jclouds/jclouds/assignees{/user}","branches_url":"https://api.github.com/repos/jclouds/jclouds/branches{/branch}","tags_url":"https://api.github.com/repos/jclouds/jclouds/tags","blobs_url":"https://api.github.com/repos/jclouds/jclouds/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jclouds/jclouds/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jclouds/jclouds/git/refs{/sha}","trees_url":"https://api.github.com/repos/jclouds/jclouds/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jclouds/jclouds/statuses/{sha}","languages_url":"https://api.github.com/repos/jclouds/jclouds/languages","stargazers_url":"https://api.github.com/repos/jclouds/jclouds/stargazers","contributors_url":"https://api.github.com/repos/jclouds/jclouds/contributors","subscribers_url":"https://api.github.com/repos/jclouds/jclouds/subscribers","subscription_url":"https://api.github.com/repos/jclouds/jclouds/subscription","commits_url":"https://api.github.com/repos/jclouds/jclouds/commits{/sha}","git_commits_url":"https://api.github.com/repos/jclouds/jclouds/git/commits{/sha}","comments_url":"https://api.github.com/repos/jclouds/jclouds/comments{/number}","issue_comment_url":"https://api.github.com/repos/jclouds/jclouds/issues/comments/{number}","contents_url":"https://api.github.com/repos/jclouds/jclouds/contents/{+path}","compare_url":"https://api.github.com/repos/jclouds/jclouds/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jclouds/jclouds/merges","archive_url":"https://api.github.com/repos/jclouds/jclouds/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jclouds/jclouds/downloads","issues_url":"https://api.github.com/repos/jclouds/jclouds/issues{/number}","pulls_url":"https://api.github.com/repos/jclouds/jclouds/pulls{/number}","milestones_url":"https://api.github.com/repos/jclouds/jclouds/milestones{/number}","notifications_url":"https://api.github.com/repos/jclouds/jclouds/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jclouds/jclouds/labels{/name}","releases_url":"https://api.github.com/repos/jclouds/jclouds/releases{/id}","created_at":"2013-05-13T20:47:29Z","updated_at":"2014-06-28T15:28:32Z","pushed_at":"2014-06-27T18:02:54Z","git_url":"git://github.com/jclouds/jclouds.git","ssh_url":"git@github.com:jclouds/jclouds.git","clone_url":"https://github.com/jclouds/jclouds.git","svn_url":"https://github.com/jclouds/jclouds","homepage":null,"size":160090,"stargazers_count":101,"watchers_count":101,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":169,"mirror_url":null,"open_issues_count":33,"forks":169,"open_issues":33,"watchers":101,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jclouds/jclouds/pulls/425"},"html":{"href":"https://github.com/jclouds/jclouds/pull/425"},"issue":{"href":"https://api.github.com/repos/jclouds/jclouds/issues/425"},"comments":{"href":"https://api.github.com/repos/jclouds/jclouds/issues/425/comments"},"review_comments":{"href":"https://api.github.com/repos/jclouds/jclouds/pulls/425/comments"},"review_comment":{"href":"https://api.github.com/repos/jclouds/jclouds/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jclouds/jclouds/pulls/425/commits"},"statuses":{"href":"https://api.github.com/repos/jclouds/jclouds/statuses/5a04f26054256ab100aa3a587d7d7c76094caeda"}}}}