GitHub PullRequestReviewCommentEvent at 2014-05-28 06:37:30
Repository: opencog
Actor: AmeBel
Payload: {"comment":{"url":"https://api.github.com/repos/opencog/opencog/pulls/comments/13117546","id":13117546,"diff_hunk":"@@ -0,0 +1,402 @@\n+; Facts taken from SimpleWikipedia:\n+\n+\n+; A scientist is a person who works in science.\n+\n+; It would be good if there would be a way to only display the atoms\n+; produced by RelEx2Logic in the AtomSpace and be able to hide all\n+; the WordInstanceNodes, DefinedLinguisticRelationshipNodes, etc.\n+; This would not only be valuable for inspecting the output, but also for\n+; checking without distractions if PLN performs the right deductions.\n+\n+; Desired output (with some refinements):\n+\n+(InheritanceLink (stv 1.0 1.0)\n+    (ConceptNode \"scientist\")\n+    (AndLink\n+        (InheritanceLink\n+            (VariableNode \"$x\")\n+            (ConceptNode \"person\"))\n+        (EvaluationLink\n+            (PredicadeNode \"work_in\") ; how would 'in' be handled?\n+            (ListLink\n+                (VariableNode \"$x\")\n+                (ConceptNode \"science\")))))\n+\n+; Current RelEx2Logic output:\n+\n+; be-inheritance-rule\n+(InheritanceLink (stv 1.000000 1.000000)\n+  (ConceptNode \"scientist@5d709cad-32b0-4d4c-93fc-0fee959d6a94\") ; [365]\n+  (ConceptNode \"scientist\") ; [366]\n+) ; [367]\n+\n+(InheritanceLink (stv 1.000000 1.000000)\n+  (ConceptNode \"person@faa54fae-15dc-4bbc-a714-8449221e1768\") ; [368]\n+  (ConceptNode \"person\") ; [369]\n+) ; [370]\n+\n+(InheritanceLink (stv 1.000000 1.000000)\n+  (ConceptNode \"scientist@5d709cad-32b0-4d4c-93fc-0fee959d6a94\") ; [365]\n+  (ConceptNode \"person@faa54fae-15dc-4bbc-a714-8449221e1768\") ; [368]\n+) ; [371]\n+\n+; tense-rule\n+(InheritanceLink (stv 1.000000 0.000000)\n+  (PredicateNode \"is@fb91bdf4-a47a-4d67-8732-af8f2a73f294\") ; [372]\n+  (PredicateNode \"be\") ; [373]\n+) ; [374]\n+\n+; The SVO-rule isn't applied for the subordinate clause because,\n+; currently, a RelEx2Logic rule can only be applied once per sentence.\n+; As be-inheritance is already applied, this currently prevents SVO from being\n+; applied to the subordinate clause because they are disjoint.\n+; This is discussed here: https://github.com/opencog/relex/issues/39 and\n+; should be fixed to deal with this sentence.","path":"tests/python/test_pln/scm/relex2logic_pln_examples/simple-wikipedia-facts.scm","position":55,"original_position":55,"commit_id":"5ac803df2d76b95f3498b789d0cda9f467028618","original_commit_id":"5ac803df2d76b95f3498b789d0cda9f467028618","user":{"login":"AmeBel","id":2135577,"avatar_url":"https://avatars.githubusercontent.com/u/2135577?","gravatar_id":"681763f12948f568f90f10380bd0afa6","url":"https://api.github.com/users/AmeBel","html_url":"https://github.com/AmeBel","followers_url":"https://api.github.com/users/AmeBel/followers","following_url":"https://api.github.com/users/AmeBel/following{/other_user}","gists_url":"https://api.github.com/users/AmeBel/gists{/gist_id}","starred_url":"https://api.github.com/users/AmeBel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AmeBel/subscriptions","organizations_url":"https://api.github.com/users/AmeBel/orgs","repos_url":"https://api.github.com/users/AmeBel/repos","events_url":"https://api.github.com/users/AmeBel/events{/privacy}","received_events_url":"https://api.github.com/users/AmeBel/received_events","type":"User","site_admin":false},"body":"Woow that was confusing :-) opencog/relex#47","created_at":"2014-05-28T06:37:30Z","updated_at":"2014-05-28T06:37:30Z","html_url":"https://github.com/opencog/opencog/pull/778#discussion_r13117546","pull_request_url":"https://api.github.com/repos/opencog/opencog/pulls/778","_links":{"self":{"href":"https://api.github.com/repos/opencog/opencog/pulls/comments/13117546"},"html":{"href":"https://github.com/opencog/opencog/pull/778#discussion_r13117546"},"pull_request":{"href":"https://api.github.com/repos/opencog/opencog/pulls/778"}}}}