GitHub PushEvent at 2014-06-25 19:35:46
Repository: Dynamite-2010
Actor: taoneill
Payload: {"shas":[["3a7f1b8b15e8d62c41d41e49037eea377430d1a8","ded0ad817a1891c4049218dcb58779570f6dac59@gmail.com","[Cache]\n- Cache key group discriminator couldn't support AD groups assigned to SharePoint groups (i.e. we could only obtain a list of a user's group if that user was directly assigned to a SharePoint group)\n- Now the SimpleCacheKey maintains a static dictionary of all user's cache prefix that allows them to share the same cache as others in the same group\n- So now AD users have a proper group discriminator as part of the cache keys they use (no more \"NoGroup\" discriminator for everyone, which was causing bad permission and GetById issues)","Thomas-Antoine O'Neill",false],["dda80fea5f692668b368064c85f9ce8fad34f366","ded0ad817a1891c4049218dcb58779570f6dac59@gmail.com","[Cache]\n- SimpleCacheKey constructor lead ot horrible bugs. Group discriminator was being calculated once only at application startup.\n- Now the group discriminator is properly handled every time the cache key is used, as it should have been all along. My bad.\n- This is still really ugly with the \"French and English-only\" support. Not having a proper CacheKeyFactory abstraction is a major pain point as well (e.g. we can't use ILogger while calculating our group discriminator - we'd be better off with this logic in the CacheHelper or somesuch).","Thomas-Antoine O'Neill",false],["34116000059cd155d23285f06820b316f6e16b32","ded0ad817a1891c4049218dcb58779570f6dac59@gmail.com","[Master Page Extra CSS classes, SecurityHelper]\n- Renamed and reworked and few permissions-discovery utility methods in SecurityHelper\n- Checking for FullControl looks for FullMask on current web\n- Checking for Approver checks for Approve perms on root of Pages lib OR on current list item OR on current folder\n- Checking for Contribute perms checks in the same way as Approver checks\n- Checking for IsCurrentUserVisitor looks for read permissions on current item, and that user isn't FullControl, Approver or Contributor.\n- All this logic isn't very re-usable, but it's handy if you want to hide the ribbon with some CSS (but keep it visible for anyone who might want to contribute)","Thomas-Antoine O'Neill",false],["ce860b6d8954d23a12992c3c329e31acaf7995b0","ded0ad817a1891c4049218dcb58779570f6dac59@gmail.com","[Placeholder shim]\n- The placeholder shim was getting misaligned whenever the windows got resized.\n- Hooking up to SharePoint's resize event to handle ribbon expand/collapse correctly as well.","Thomas-Antoine O'Neill",false],["1214e0cf3ccbe05fb2e619878239d81ab918bcab","ded0ad817a1891c4049218dcb58779570f6dac59@gmail.com","Merge branch 'release/v1.0_SP2010'","Thomas-Antoine O'Neill",true]],"size":5,"ref":"refs/heads/master","head":"1214e0cf3ccbe05fb2e619878239d81ab918bcab"}