GitHub PullRequestReviewCommentEvent at 2014-07-28 09:03:47
Repository: charmstore
Actor: rogpeppe
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/juju/charmstore/pulls/comments/15452508","id":15452508,"diff_hunk":"@@ -137,7 +136,8 @@ func (r *Router) serveIds(w http.ResponseWriter, req *http.Request) error {\n \t\treturn ErrNotFound\n \t}\n \treq.URL.Path = path\n-\tresp, err := r.serveMeta(url, w, req)\n+\t// TODO remove ResponseWriter argument from function passed to JSONHandler","path":"internal/router/router.go","position":24,"original_position":24,"commit_id":"57b105d07eb4b3dd5ef5d02d6200aa2012297f4b","original_commit_id":"57b105d07eb4b3dd5ef5d02d6200aa2012297f4b","user":{"login":"rogpeppe","id":66491,"avatar_url":"https://avatars.githubusercontent.com/u/66491?","gravatar_id":"e0dedec2ffb08c81d5eb0d3d8fb966d7","url":"https://api.github.com/users/rogpeppe","html_url":"https://github.com/rogpeppe","followers_url":"https://api.github.com/users/rogpeppe/followers","following_url":"https://api.github.com/users/rogpeppe/following{/other_user}","gists_url":"https://api.github.com/users/rogpeppe/gists{/gist_id}","starred_url":"https://api.github.com/users/rogpeppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rogpeppe/subscriptions","organizations_url":"https://api.github.com/users/rogpeppe/orgs","repos_url":"https://api.github.com/users/rogpeppe/repos","events_url":"https://api.github.com/users/rogpeppe/events{/privacy}","received_events_url":"https://api.github.com/users/rogpeppe/received_events","type":"User","site_admin":false},"body":"The comment is redundant - I actually made this change. I'll delete the comment.","created_at":"2014-07-28T09:03:47Z","updated_at":"2014-07-28T09:03:47Z","html_url":"https://github.com/juju/charmstore/pull/34#discussion_r15452508","pull_request_url":"https://api.github.com/repos/juju/charmstore/pulls/34","_links":{"self":{"href":"https://api.github.com/repos/juju/charmstore/pulls/comments/15452508"},"html":{"href":"https://github.com/juju/charmstore/pull/34#discussion_r15452508"},"pull_request":{"href":"https://api.github.com/repos/juju/charmstore/pulls/34"}}},"pull_request":{"url":"https://api.github.com/repos/juju/charmstore/pulls/34","id":18953364,"html_url":"https://github.com/juju/charmstore/pull/34","diff_url":"https://github.com/juju/charmstore/pull/34.diff","patch_url":"https://github.com/juju/charmstore/pull/34.patch","issue_url":"https://api.github.com/repos/juju/charmstore/issues/34","number":34,"state":"open","title":"internal/router: bulk metadata API implemention","user":{"login":"rogpeppe","id":66491,"avatar_url":"https://avatars.githubusercontent.com/u/66491?","gravatar_id":"e0dedec2ffb08c81d5eb0d3d8fb966d7","url":"https://api.github.com/users/rogpeppe","html_url":"https://github.com/rogpeppe","followers_url":"https://api.github.com/users/rogpeppe/followers","following_url":"https://api.github.com/users/rogpeppe/following{/other_user}","gists_url":"https://api.github.com/users/rogpeppe/gists{/gist_id}","starred_url":"https://api.github.com/users/rogpeppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rogpeppe/subscriptions","organizations_url":"https://api.github.com/users/rogpeppe/orgs","repos_url":"https://api.github.com/users/rogpeppe/repos","events_url":"https://api.github.com/users/rogpeppe/events{/privacy}","received_events_url":"https://api.github.com/users/rogpeppe/received_events","type":"User","site_admin":false},"body":"We also fix all paths so that they start with / after splitting. This makes them compatible with the usual way that paths are specified in URLs.","created_at":"2014-07-28T07:44:23Z","updated_at":"2014-07-28T09:03:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/juju/charmstore/pulls/34/commits","review_comments_url":"https://api.github.com/repos/juju/charmstore/pulls/34/comments","review_comment_url":"https://api.github.com/repos/juju/charmstore/pulls/comments/{number}","comments_url":"https://api.github.com/repos/juju/charmstore/issues/34/comments","statuses_url":"https://api.github.com/repos/juju/charmstore/statuses/57b105d07eb4b3dd5ef5d02d6200aa2012297f4b","head":{"label":"rogpeppe:013-bulkmeta","ref":"013-bulkmeta","sha":"57b105d07eb4b3dd5ef5d02d6200aa2012297f4b","user":{"login":"rogpeppe","id":66491,"avatar_url":"https://avatars.githubusercontent.com/u/66491?","gravatar_id":"e0dedec2ffb08c81d5eb0d3d8fb966d7","url":"https://api.github.com/users/rogpeppe","html_url":"https://github.com/rogpeppe","followers_url":"https://api.github.com/users/rogpeppe/followers","following_url":"https://api.github.com/users/rogpeppe/following{/other_user}","gists_url":"https://api.github.com/users/rogpeppe/gists{/gist_id}","starred_url":"https://api.github.com/users/rogpeppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rogpeppe/subscriptions","organizations_url":"https://api.github.com/users/rogpeppe/orgs","repos_url":"https://api.github.com/users/rogpeppe/repos","events_url":"https://api.github.com/users/rogpeppe/events{/privacy}","received_events_url":"https://api.github.com/users/rogpeppe/received_events","type":"User","site_admin":false},"repo":{"id":21278168,"name":"charmstore","full_name":"rogpeppe/charmstore","owner":{"login":"rogpeppe","id":66491,"avatar_url":"https://avatars.githubusercontent.com/u/66491?","gravatar_id":"e0dedec2ffb08c81d5eb0d3d8fb966d7","url":"https://api.github.com/users/rogpeppe","html_url":"https://github.com/rogpeppe","followers_url":"https://api.github.com/users/rogpeppe/followers","following_url":"https://api.github.com/users/rogpeppe/following{/other_user}","gists_url":"https://api.github.com/users/rogpeppe/gists{/gist_id}","starred_url":"https://api.github.com/users/rogpeppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rogpeppe/subscriptions","organizations_url":"https://api.github.com/users/rogpeppe/orgs","repos_url":"https://api.github.com/users/rogpeppe/repos","events_url":"https://api.github.com/users/rogpeppe/events{/privacy}","received_events_url":"https://api.github.com/users/rogpeppe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rogpeppe/charmstore","description":"The charm store server.","fork":true,"url":"https://api.github.com/repos/rogpeppe/charmstore","forks_url":"https://api.github.com/repos/rogpeppe/charmstore/forks","keys_url":"https://api.github.com/repos/rogpeppe/charmstore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rogpeppe/charmstore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rogpeppe/charmstore/teams","hooks_url":"https://api.github.com/repos/rogpeppe/charmstore/hooks","issue_events_url":"https://api.github.com/repos/rogpeppe/charmstore/issues/events{/number}","events_url":"https://api.github.com/repos/rogpeppe/charmstore/events","assignees_url":"https://api.github.com/repos/rogpeppe/charmstore/assignees{/user}","branches_url":"https://api.github.com/repos/rogpeppe/charmstore/branches{/branch}","tags_url":"https://api.github.com/repos/rogpeppe/charmstore/tags","blobs_url":"https://api.github.com/repos/rogpeppe/charmstore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rogpeppe/charmstore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rogpeppe/charmstore/git/refs{/sha}","trees_url":"https://api.github.com/repos/rogpeppe/charmstore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rogpeppe/charmstore/statuses/{sha}","languages_url":"https://api.github.com/repos/rogpeppe/charmstore/languages","stargazers_url":"https://api.github.com/repos/rogpeppe/charmstore/stargazers","contributors_url":"https://api.github.com/repos/rogpeppe/charmstore/contributors","subscribers_url":"https://api.github.com/repos/rogpeppe/charmstore/subscribers","subscription_url":"https://api.github.com/repos/rogpeppe/charmstore/subscription","commits_url":"https://api.github.com/repos/rogpeppe/charmstore/commits{/sha}","git_commits_url":"https://api.github.com/repos/rogpeppe/charmstore/git/commits{/sha}","comments_url":"https://api.github.com/repos/rogpeppe/charmstore/comments{/number}","issue_comment_url":"https://api.github.com/repos/rogpeppe/charmstore/issues/comments/{number}","contents_url":"https://api.github.com/repos/rogpeppe/charmstore/contents/{+path}","compare_url":"https://api.github.com/repos/rogpeppe/charmstore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rogpeppe/charmstore/merges","archive_url":"https://api.github.com/repos/rogpeppe/charmstore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rogpeppe/charmstore/downloads","issues_url":"https://api.github.com/repos/rogpeppe/charmstore/issues{/number}","pulls_url":"https://api.github.com/repos/rogpeppe/charmstore/pulls{/number}","milestones_url":"https://api.github.com/repos/rogpeppe/charmstore/milestones{/number}","notifications_url":"https://api.github.com/repos/rogpeppe/charmstore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rogpeppe/charmstore/labels{/name}","releases_url":"https://api.github.com/repos/rogpeppe/charmstore/releases{/id}","created_at":"2014-06-27T14:18:37Z","updated_at":"2014-06-27T13:23:16Z","pushed_at":"2014-07-28T07:42:24Z","git_url":"git://github.com/rogpeppe/charmstore.git","ssh_url":"git@github.com:rogpeppe/charmstore.git","clone_url":"https://github.com/rogpeppe/charmstore.git","svn_url":"https://github.com/rogpeppe/charmstore","homepage":null,"size":690,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"juju:v4","ref":"v4","sha":"b9400059575d66f295d09701afd6a55b7f88f838","user":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?","gravatar_id":"b095d1e26e5705abe0ad2de7d87aac2e","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"repo":{"id":20720417,"name":"charmstore","full_name":"juju/charmstore","owner":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?","gravatar_id":"b095d1e26e5705abe0ad2de7d87aac2e","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju/charmstore","description":"The charm store server.","fork":false,"url":"https://api.github.com/repos/juju/charmstore","forks_url":"https://api.github.com/repos/juju/charmstore/forks","keys_url":"https://api.github.com/repos/juju/charmstore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju/charmstore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju/charmstore/teams","hooks_url":"https://api.github.com/repos/juju/charmstore/hooks","issue_events_url":"https://api.github.com/repos/juju/charmstore/issues/events{/number}","events_url":"https://api.github.com/repos/juju/charmstore/events","assignees_url":"https://api.github.com/repos/juju/charmstore/assignees{/user}","branches_url":"https://api.github.com/repos/juju/charmstore/branches{/branch}","tags_url":"https://api.github.com/repos/juju/charmstore/tags","blobs_url":"https://api.github.com/repos/juju/charmstore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju/charmstore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju/charmstore/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju/charmstore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju/charmstore/statuses/{sha}","languages_url":"https://api.github.com/repos/juju/charmstore/languages","stargazers_url":"https://api.github.com/repos/juju/charmstore/stargazers","contributors_url":"https://api.github.com/repos/juju/charmstore/contributors","subscribers_url":"https://api.github.com/repos/juju/charmstore/subscribers","subscription_url":"https://api.github.com/repos/juju/charmstore/subscription","commits_url":"https://api.github.com/repos/juju/charmstore/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju/charmstore/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju/charmstore/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju/charmstore/issues/comments/{number}","contents_url":"https://api.github.com/repos/juju/charmstore/contents/{+path}","compare_url":"https://api.github.com/repos/juju/charmstore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju/charmstore/merges","archive_url":"https://api.github.com/repos/juju/charmstore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju/charmstore/downloads","issues_url":"https://api.github.com/repos/juju/charmstore/issues{/number}","pulls_url":"https://api.github.com/repos/juju/charmstore/pulls{/number}","milestones_url":"https://api.github.com/repos/juju/charmstore/milestones{/number}","notifications_url":"https://api.github.com/repos/juju/charmstore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju/charmstore/labels{/name}","releases_url":"https://api.github.com/repos/juju/charmstore/releases{/id}","created_at":"2014-06-11T09:53:37Z","updated_at":"2014-07-14T22:45:58Z","pushed_at":"2014-07-28T04:04:38Z","git_url":"git://github.com/juju/charmstore.git","ssh_url":"git@github.com:juju/charmstore.git","clone_url":"https://github.com/juju/charmstore.git","svn_url":"https://github.com/juju/charmstore","homepage":null,"size":758,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":6,"mirror_url":null,"open_issues_count":7,"forks":6,"open_issues":7,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/juju/charmstore/pulls/34"},"html":{"href":"https://github.com/juju/charmstore/pull/34"},"issue":{"href":"https://api.github.com/repos/juju/charmstore/issues/34"},"comments":{"href":"https://api.github.com/repos/juju/charmstore/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/juju/charmstore/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/juju/charmstore/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/juju/charmstore/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/juju/charmstore/statuses/57b105d07eb4b3dd5ef5d02d6200aa2012297f4b"}}}}