GitHub PullRequestReviewCommentEvent at 2014-03-05 11:33:41
Repository: brackets
Actor: zaggino
Payload: {"comment":{"url":"https://api.github.com/repos/adobe/brackets/pulls/comments/10296085","id":10296085,"diff_hunk":"@@ -344,16 +344,21 @@ define(function (require, exports, module) {\n          * \n          * @param {string} id key to set or delete\n          * @param {*} value value for this key (undefined to delete)\n-         * @return {boolean} always returns true\n+         * @return {boolean} true if the value was set.\n          */\n         _performSet: function (id, value) {\n-            this._dirty = true;\n             if (value === undefined) {\n-                delete this.data[id];\n-            } else {\n+                if (this.data[id]) {","path":"src/preferences/PreferencesBase.js","position":12,"original_position":12,"commit_id":"a09000d1964d923d1d31b2a7bcb4d6b5ae1df9b7","original_commit_id":"a09000d1964d923d1d31b2a7bcb4d6b5ae1df9b7","user":{"login":"zaggino","id":1067319,"avatar_url":"https://gravatar.com/avatar/5230f685a53e98a04b02b3ee03e5860d?d=https%3A%2F%2Fidenticons.github.com%2Fe2baec4cd4a9c728cb79c7bc490842ef.png&r=x","gravatar_id":"5230f685a53e98a04b02b3ee03e5860d","url":"https://api.github.com/users/zaggino","html_url":"https://github.com/zaggino","followers_url":"https://api.github.com/users/zaggino/followers","following_url":"https://api.github.com/users/zaggino/following{/other_user}","gists_url":"https://api.github.com/users/zaggino/gists{/gist_id}","starred_url":"https://api.github.com/users/zaggino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zaggino/subscriptions","organizations_url":"https://api.github.com/users/zaggino/orgs","repos_url":"https://api.github.com/users/zaggino/repos","events_url":"https://api.github.com/users/zaggino/events{/privacy}","received_events_url":"https://api.github.com/users/zaggino/received_events","type":"User","site_admin":false},"body":"with this you're not able to delete ```0```, ```false```, ```\"\"``` and ```null```","created_at":"2014-03-05T11:33:41Z","updated_at":"2014-03-05T11:33:41Z","html_url":"https://github.com/adobe/brackets/pull/7064#discussion_r10296085","pull_request_url":"https://api.github.com/repos/adobe/brackets/pulls/7064","_links":{"self":{"href":"https://api.github.com/repos/adobe/brackets/pulls/comments/10296085"},"html":{"href":"https://github.com/adobe/brackets/pull/7064#discussion_r10296085"},"pull_request":{"href":"https://api.github.com/repos/adobe/brackets/pulls/7064"}}}}