GitHub PullRequestEvent at 2014-03-08 00:13:23
Repository: magento2
Actor: verklov
Payload: {"action":"closed","number":284,"pull_request":{"url":"https://api.github.com/repos/magento/magento2/pulls/284","id":5297277,"html_url":"https://github.com/magento/magento2/pull/284","diff_url":"https://github.com/magento/magento2/pull/284.diff","patch_url":"https://github.com/magento/magento2/pull/284.patch","issue_url":"https://api.github.com/repos/magento/magento2/issues/284","number":284,"state":"closed","title":"Fix for Issue #278 (Import -> Stores with large amount of Configurable Products)","user":{"login":"s-hoffman","id":4163166,"avatar_url":"https://gravatar.com/avatar/da5e2b3530e7767d6df048293d516c50?d=https%3A%2F%2Fidenticons.github.com%2Fde83f1649903cb98597bbe74dd7ccf71.png&r=x","gravatar_id":"da5e2b3530e7767d6df048293d516c50","url":"https://api.github.com/users/s-hoffman","html_url":"https://github.com/s-hoffman","followers_url":"https://api.github.com/users/s-hoffman/followers","following_url":"https://api.github.com/users/s-hoffman/following{/other_user}","gists_url":"https://api.github.com/users/s-hoffman/gists{/gist_id}","starred_url":"https://api.github.com/users/s-hoffman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s-hoffman/subscriptions","organizations_url":"https://api.github.com/users/s-hoffman/orgs","repos_url":"https://api.github.com/users/s-hoffman/repos","events_url":"https://api.github.com/users/s-hoffman/events{/privacy}","received_events_url":"https://api.github.com/users/s-hoffman/received_events","type":"User","site_admin":false},"body":"This fix is for Stores with large amounts of Products and Configurable Attributes.\r\n\r\n_loadSkuSuperAttributeValues() is given parameters and a foreach loop creates the productIds needed for the current bunch.\r\n\r\nThe conversion From Sku to Id is duplicated later in save(), but I felt it is best to do the conversion here then let the DB do the work. (Cheap Hash Lookups.)\r\n\r\nThis fix is based off of a module rewrite for EE 1.12 and has not been tested on Mage2. It should work though, That Module successfully imported 700,000 Simple Products and many (80K~ish) Configurable Products. Most of the Configurable Products having 3 super_attributes.\r\n\r\nIt has also been tested by @barbazul on CE 1.7.0.2. And it worked.\r\n\r\nThe changes could be slightly cleaner. To do so I would have to had made a bigger change to the structure of the Module. This version of the fix is conceptually cleaner.\r\n\r\nWhatever tests you currently have for testing Import -> Products will work to cover this Fix also.\r\n\r\nSigned-off-by: Steven Hoffman <s.hoffman@harapartners.com>","created_at":"2013-04-22T17:26:41Z","updated_at":"2014-03-08T00:13:22Z","closed_at":"2014-03-08T00:13:22Z","merged_at":null,"merge_commit_sha":"044324df33351b52bca33d0e28a83607e10d6ffd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/magento/magento2/pulls/284/commits","review_comments_url":"https://api.github.com/repos/magento/magento2/pulls/284/comments","review_comment_url":"https://api.github.com/repos/magento/magento2/pulls/comments/{number}","comments_url":"https://api.github.com/repos/magento/magento2/issues/284/comments","statuses_url":"https://api.github.com/repos/magento/magento2/statuses/ab023bffeeacb0fdd0bd0365f366d6f840035a0d","head":{"label":"s-hoffman:master","ref":"master","sha":"ab023bffeeacb0fdd0bd0365f366d6f840035a0d","user":{"login":"s-hoffman","id":4163166,"avatar_url":"https://gravatar.com/avatar/da5e2b3530e7767d6df048293d516c50?d=https%3A%2F%2Fidenticons.github.com%2Fde83f1649903cb98597bbe74dd7ccf71.png&r=x","gravatar_id":"da5e2b3530e7767d6df048293d516c50","url":"https://api.github.com/users/s-hoffman","html_url":"https://github.com/s-hoffman","followers_url":"https://api.github.com/users/s-hoffman/followers","following_url":"https://api.github.com/users/s-hoffman/following{/other_user}","gists_url":"https://api.github.com/users/s-hoffman/gists{/gist_id}","starred_url":"https://api.github.com/users/s-hoffman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s-hoffman/subscriptions","organizations_url":"https://api.github.com/users/s-hoffman/orgs","repos_url":"https://api.github.com/users/s-hoffman/repos","events_url":"https://api.github.com/users/s-hoffman/events{/privacy}","received_events_url":"https://api.github.com/users/s-hoffman/received_events","type":"User","site_admin":false},"repo":{"id":9531184,"name":"magento2","full_name":"s-hoffman/magento2","owner":{"login":"s-hoffman","id":4163166,"avatar_url":"https://gravatar.com/avatar/da5e2b3530e7767d6df048293d516c50?d=https%3A%2F%2Fidenticons.github.com%2Fde83f1649903cb98597bbe74dd7ccf71.png&r=x","gravatar_id":"da5e2b3530e7767d6df048293d516c50","url":"https://api.github.com/users/s-hoffman","html_url":"https://github.com/s-hoffman","followers_url":"https://api.github.com/users/s-hoffman/followers","following_url":"https://api.github.com/users/s-hoffman/following{/other_user}","gists_url":"https://api.github.com/users/s-hoffman/gists{/gist_id}","starred_url":"https://api.github.com/users/s-hoffman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s-hoffman/subscriptions","organizations_url":"https://api.github.com/users/s-hoffman/orgs","repos_url":"https://api.github.com/users/s-hoffman/repos","events_url":"https://api.github.com/users/s-hoffman/events{/privacy}","received_events_url":"https://api.github.com/users/s-hoffman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/s-hoffman/magento2","description":"All Submissions you make to Magento, a division of X.commerce, Inc. (“Magento”) through GitHub are subject to the following terms and conditions: (1)\tYou grant Magento a perpetual, worldwide, non-exclusive, no charge, royalty free, irrevocable      license under your applicable copyrights and patents to reproduce, prepare derivative works of, display, publically perform, sublicense and distribute any feedback, ideas, code, or other information (“Submission”) you submit through GitHub. (2)\tYour Submission is an original work of authorship and you are the owner or are legally entitled to grant the license stated above. (3)\tYou agree to the X.commerce Agreement found here:  https://www.x.com/developers/x.commerce/x.commerce-user-agreement","fork":true,"url":"https://api.github.com/repos/s-hoffman/magento2","forks_url":"https://api.github.com/repos/s-hoffman/magento2/forks","keys_url":"https://api.github.com/repos/s-hoffman/magento2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/s-hoffman/magento2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/s-hoffman/magento2/teams","hooks_url":"https://api.github.com/repos/s-hoffman/magento2/hooks","issue_events_url":"https://api.github.com/repos/s-hoffman/magento2/issues/events{/number}","events_url":"https://api.github.com/repos/s-hoffman/magento2/events","assignees_url":"https://api.github.com/repos/s-hoffman/magento2/assignees{/user}","branches_url":"https://api.github.com/repos/s-hoffman/magento2/branches{/branch}","tags_url":"https://api.github.com/repos/s-hoffman/magento2/tags","blobs_url":"https://api.github.com/repos/s-hoffman/magento2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/s-hoffman/magento2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/s-hoffman/magento2/git/refs{/sha}","trees_url":"https://api.github.com/repos/s-hoffman/magento2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/s-hoffman/magento2/statuses/{sha}","languages_url":"https://api.github.com/repos/s-hoffman/magento2/languages","stargazers_url":"https://api.github.com/repos/s-hoffman/magento2/stargazers","contributors_url":"https://api.github.com/repos/s-hoffman/magento2/contributors","subscribers_url":"https://api.github.com/repos/s-hoffman/magento2/subscribers","subscription_url":"https://api.github.com/repos/s-hoffman/magento2/subscription","commits_url":"https://api.github.com/repos/s-hoffman/magento2/commits{/sha}","git_commits_url":"https://api.github.com/repos/s-hoffman/magento2/git/commits{/sha}","comments_url":"https://api.github.com/repos/s-hoffman/magento2/comments{/number}","issue_comment_url":"https://api.github.com/repos/s-hoffman/magento2/issues/comments/{number}","contents_url":"https://api.github.com/repos/s-hoffman/magento2/contents/{+path}","compare_url":"https://api.github.com/repos/s-hoffman/magento2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/s-hoffman/magento2/merges","archive_url":"https://api.github.com/repos/s-hoffman/magento2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/s-hoffman/magento2/downloads","issues_url":"https://api.github.com/repos/s-hoffman/magento2/issues{/number}","pulls_url":"https://api.github.com/repos/s-hoffman/magento2/pulls{/number}","milestones_url":"https://api.github.com/repos/s-hoffman/magento2/milestones{/number}","notifications_url":"https://api.github.com/repos/s-hoffman/magento2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/s-hoffman/magento2/labels{/name}","releases_url":"https://api.github.com/repos/s-hoffman/magento2/releases{/id}","created_at":"2013-04-18T20:32:48Z","updated_at":"2013-11-07T13:55:35Z","pushed_at":"2013-04-18T20:41:58Z","git_url":"git://github.com/s-hoffman/magento2.git","ssh_url":"git@github.com:s-hoffman/magento2.git","clone_url":"https://github.com/s-hoffman/magento2.git","svn_url":"https://github.com/s-hoffman/magento2","homepage":"http://www.magento.com","size":45982,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"magento:master","ref":"master","sha":"a15ecb31976feb4ecb62f85257ff6b606fbdbc00","user":{"login":"magento","id":168457,"avatar_url":"https://gravatar.com/avatar/0526749698f79a698d6c839045d3d715?d=https%3A%2F%2Fidenticons.github.com%2F2386e75403c73780ee9f7237178a0ecc.png&r=x","gravatar_id":"0526749698f79a698d6c839045d3d715","url":"https://api.github.com/users/magento","html_url":"https://github.com/magento","followers_url":"https://api.github.com/users/magento/followers","following_url":"https://api.github.com/users/magento/following{/other_user}","gists_url":"https://api.github.com/users/magento/gists{/gist_id}","starred_url":"https://api.github.com/users/magento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento/subscriptions","organizations_url":"https://api.github.com/users/magento/orgs","repos_url":"https://api.github.com/users/magento/repos","events_url":"https://api.github.com/users/magento/events{/privacy}","received_events_url":"https://api.github.com/users/magento/received_events","type":"Organization","site_admin":false},"repo":{"id":2884111,"name":"magento2","full_name":"magento/magento2","owner":{"login":"magento","id":168457,"avatar_url":"https://gravatar.com/avatar/0526749698f79a698d6c839045d3d715?d=https%3A%2F%2Fidenticons.github.com%2F2386e75403c73780ee9f7237178a0ecc.png&r=x","gravatar_id":"0526749698f79a698d6c839045d3d715","url":"https://api.github.com/users/magento","html_url":"https://github.com/magento","followers_url":"https://api.github.com/users/magento/followers","following_url":"https://api.github.com/users/magento/following{/other_user}","gists_url":"https://api.github.com/users/magento/gists{/gist_id}","starred_url":"https://api.github.com/users/magento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento/subscriptions","organizations_url":"https://api.github.com/users/magento/orgs","repos_url":"https://api.github.com/users/magento/repos","events_url":"https://api.github.com/users/magento/events{/privacy}","received_events_url":"https://api.github.com/users/magento/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/magento/magento2","description":"All Submissions you make to Magento, an eBay Inc. company (“Magento”) through GitHub are subject to the following terms and conditions: (1)\tYou grant Magento a perpetual, worldwide, non-exclusive, no charge, royalty free, irrevocable      license under your applicable copyrights and patents to reproduce, prepare derivative works of, display, publically perform, sublicense and distribute any feedback, ideas, code, or other information (“Submission”) you submit through GitHub. (2)\tYour Submission is an original work of authorship and you are the owner or are legally entitled to grant the license stated above. (3)\tYou agree to the X.commerce Agreement found here:  https://www.x.com/developers/x.commerce/x.commerce-user-agreement","fork":false,"url":"https://api.github.com/repos/magento/magento2","forks_url":"https://api.github.com/repos/magento/magento2/forks","keys_url":"https://api.github.com/repos/magento/magento2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magento/magento2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magento/magento2/teams","hooks_url":"https://api.github.com/repos/magento/magento2/hooks","issue_events_url":"https://api.github.com/repos/magento/magento2/issues/events{/number}","events_url":"https://api.github.com/repos/magento/magento2/events","assignees_url":"https://api.github.com/repos/magento/magento2/assignees{/user}","branches_url":"https://api.github.com/repos/magento/magento2/branches{/branch}","tags_url":"https://api.github.com/repos/magento/magento2/tags","blobs_url":"https://api.github.com/repos/magento/magento2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magento/magento2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magento/magento2/git/refs{/sha}","trees_url":"https://api.github.com/repos/magento/magento2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magento/magento2/statuses/{sha}","languages_url":"https://api.github.com/repos/magento/magento2/languages","stargazers_url":"https://api.github.com/repos/magento/magento2/stargazers","contributors_url":"https://api.github.com/repos/magento/magento2/contributors","subscribers_url":"https://api.github.com/repos/magento/magento2/subscribers","subscription_url":"https://api.github.com/repos/magento/magento2/subscription","commits_url":"https://api.github.com/repos/magento/magento2/commits{/sha}","git_commits_url":"https://api.github.com/repos/magento/magento2/git/commits{/sha}","comments_url":"https://api.github.com/repos/magento/magento2/comments{/number}","issue_comment_url":"https://api.github.com/repos/magento/magento2/issues/comments/{number}","contents_url":"https://api.github.com/repos/magento/magento2/contents/{+path}","compare_url":"https://api.github.com/repos/magento/magento2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magento/magento2/merges","archive_url":"https://api.github.com/repos/magento/magento2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magento/magento2/downloads","issues_url":"https://api.github.com/repos/magento/magento2/issues{/number}","pulls_url":"https://api.github.com/repos/magento/magento2/pulls{/number}","milestones_url":"https://api.github.com/repos/magento/magento2/milestones{/number}","notifications_url":"https://api.github.com/repos/magento/magento2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magento/magento2/labels{/name}","releases_url":"https://api.github.com/repos/magento/magento2/releases{/id}","created_at":"2011-11-30T15:30:13Z","updated_at":"2014-03-07T18:55:16Z","pushed_at":"2014-03-07T18:55:15Z","git_url":"git://github.com/magento/magento2.git","ssh_url":"git@github.com:magento/magento2.git","clone_url":"https://github.com/magento/magento2.git","svn_url":"https://github.com/magento/magento2","homepage":"http://www.magento.com","size":105230,"stargazers_count":1353,"watchers_count":1353,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":694,"mirror_url":null,"open_issues_count":130,"forks":694,"open_issues":130,"watchers":1353,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/magento/magento2/pulls/284"},"html":{"href":"https://github.com/magento/magento2/pull/284"},"issue":{"href":"https://api.github.com/repos/magento/magento2/issues/284"},"comments":{"href":"https://api.github.com/repos/magento/magento2/issues/284/comments"},"review_comments":{"href":"https://api.github.com/repos/magento/magento2/pulls/284/comments"},"review_comment":{"href":"https://api.github.com/repos/magento/magento2/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/magento/magento2/pulls/284/commits"},"statuses":{"href":"https://api.github.com/repos/magento/magento2/statuses/ab023bffeeacb0fdd0bd0365f366d6f840035a0d"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":2,"review_comments":0,"commits":1,"additions":13,"deletions":3,"changed_files":1}}