GitHub PullRequestReviewCommentEvent at 2014-10-24 21:14:15
Repository: origin
Actor: smarterclayton
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/19364904","id":19364904,"diff_hunk":"@@ -18,10 +18,16 @@\n       \"from\": \"[a-zA-Z0-9]{8}\"\n     },\n     {\n-      \"name\": \"DB_PASSWORD\",\n+      \"name\": \"MYSQL_ROOT_PASSWORD\",\n       \"description\": \"database password\",\n       \"generate\": \"expression\",\n       \"from\": \"[a-zA-Z0-9]{8}\"\n+    },\n+    {\n+      \"name\": \"MYSQL_DATABASE\",\n+      \"description\": \"database name\",\n+      \"generate\": \"expression\",","path":"examples/sample-app/template/template.json","position":13,"original_position":13,"commit_id":"ed5eb7b899dbb0b8750921a373e0595c815ed83f","original_commit_id":"ed5eb7b899dbb0b8750921a373e0595c815ed83f","user":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=2","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"body":"You and your mathematics.\r\n\r\n\r\n> On Oct 24, 2014, at 4:59 PM, Ben Parees <notifications@github.com> wrote:\r\n> \r\n> In examples/sample-app/template/template.json:\r\n> \r\n> >        \"description\": \"database password\",\r\n> >        \"generate\": \"expression\",\r\n> >        \"from\": \"[a-zA-Z0-9]{8}\"\r\n> > +    },\r\n> > +    {\r\n> > +      \"name\": \"MYSQL_DATABASE\",\r\n> > +      \"description\": \"database name\",\r\n> > +      \"generate\": \"expression\",\r\n> eh, it looks like I misremembered the syntax.\r\n> \r\n> If you just leave off the generate field, but specify the value field, that's how you define a set value.\r\n> \r\n> However I would not have a philosophical or usability problem with the idea of a generator which took an input and returned an output, where in this case the output happened to exactly match the output. It fits the semantics of the other generators. (take input, produce output after some transformation).\r\n> \r\n> —\r\n> Reply to this email directly or view it on GitHub.\r\n","created_at":"2014-10-24T21:14:15Z","updated_at":"2014-10-24T21:14:15Z","html_url":"https://github.com/openshift/origin/pull/201#discussion_r19364904","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/201","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/19364904"},"html":{"href":"https://github.com/openshift/origin/pull/201#discussion_r19364904"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/201"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/201","id":22552403,"html_url":"https://github.com/openshift/origin/pull/201","diff_url":"https://github.com/openshift/origin/pull/201.diff","patch_url":"https://github.com/openshift/origin/pull/201.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/201","number":201,"state":"open","locked":false,"title":"Add database pod and service for ruby sample app demo","user":{"login":"marianitadn","id":1681405,"avatar_url":"https://avatars.githubusercontent.com/u/1681405?v=2","gravatar_id":"","url":"https://api.github.com/users/marianitadn","html_url":"https://github.com/marianitadn","followers_url":"https://api.github.com/users/marianitadn/followers","following_url":"https://api.github.com/users/marianitadn/following{/other_user}","gists_url":"https://api.github.com/users/marianitadn/gists{/gist_id}","starred_url":"https://api.github.com/users/marianitadn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marianitadn/subscriptions","organizations_url":"https://api.github.com/users/marianitadn/orgs","repos_url":"https://api.github.com/users/marianitadn/repos","events_url":"https://api.github.com/users/marianitadn/events{/privacy}","received_events_url":"https://api.github.com/users/marianitadn/received_events","type":"User","site_admin":false},"body":"- [x] update ruby-sample-app image with MySQL connection for Sinatra app \r\n- [x] change docker image URL with OpenShift official image for ruby-sample-app - https://github.com/openshift/ruby-hello-world/pull/5","created_at":"2014-10-10T10:43:43Z","updated_at":"2014-10-24T21:14:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dba5b36afdf97ae98c183ff59519d0a35077814f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/201/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/201/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments/{number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/201/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/ed5eb7b899dbb0b8750921a373e0595c815ed83f","head":{"label":"marianitadn:db-container-ruby-sample-app","ref":"db-container-ruby-sample-app","sha":"ed5eb7b899dbb0b8750921a373e0595c815ed83f","user":{"login":"marianitadn","id":1681405,"avatar_url":"https://avatars.githubusercontent.com/u/1681405?v=2","gravatar_id":"","url":"https://api.github.com/users/marianitadn","html_url":"https://github.com/marianitadn","followers_url":"https://api.github.com/users/marianitadn/followers","following_url":"https://api.github.com/users/marianitadn/following{/other_user}","gists_url":"https://api.github.com/users/marianitadn/gists{/gist_id}","starred_url":"https://api.github.com/users/marianitadn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marianitadn/subscriptions","organizations_url":"https://api.github.com/users/marianitadn/orgs","repos_url":"https://api.github.com/users/marianitadn/repos","events_url":"https://api.github.com/users/marianitadn/events{/privacy}","received_events_url":"https://api.github.com/users/marianitadn/received_events","type":"User","site_admin":false},"repo":{"id":24882630,"name":"origin","full_name":"marianitadn/origin","owner":{"login":"marianitadn","id":1681405,"avatar_url":"https://avatars.githubusercontent.com/u/1681405?v=2","gravatar_id":"","url":"https://api.github.com/users/marianitadn","html_url":"https://github.com/marianitadn","followers_url":"https://api.github.com/users/marianitadn/followers","following_url":"https://api.github.com/users/marianitadn/following{/other_user}","gists_url":"https://api.github.com/users/marianitadn/gists{/gist_id}","starred_url":"https://api.github.com/users/marianitadn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marianitadn/subscriptions","organizations_url":"https://api.github.com/users/marianitadn/orgs","repos_url":"https://api.github.com/users/marianitadn/repos","events_url":"https://api.github.com/users/marianitadn/events{/privacy}","received_events_url":"https://api.github.com/users/marianitadn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marianitadn/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/marianitadn/origin","forks_url":"https://api.github.com/repos/marianitadn/origin/forks","keys_url":"https://api.github.com/repos/marianitadn/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marianitadn/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marianitadn/origin/teams","hooks_url":"https://api.github.com/repos/marianitadn/origin/hooks","issue_events_url":"https://api.github.com/repos/marianitadn/origin/issues/events{/number}","events_url":"https://api.github.com/repos/marianitadn/origin/events","assignees_url":"https://api.github.com/repos/marianitadn/origin/assignees{/user}","branches_url":"https://api.github.com/repos/marianitadn/origin/branches{/branch}","tags_url":"https://api.github.com/repos/marianitadn/origin/tags","blobs_url":"https://api.github.com/repos/marianitadn/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marianitadn/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marianitadn/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/marianitadn/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marianitadn/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/marianitadn/origin/languages","stargazers_url":"https://api.github.com/repos/marianitadn/origin/stargazers","contributors_url":"https://api.github.com/repos/marianitadn/origin/contributors","subscribers_url":"https://api.github.com/repos/marianitadn/origin/subscribers","subscription_url":"https://api.github.com/repos/marianitadn/origin/subscription","commits_url":"https://api.github.com/repos/marianitadn/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/marianitadn/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/marianitadn/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/marianitadn/origin/issues/comments/{number}","contents_url":"https://api.github.com/repos/marianitadn/origin/contents/{+path}","compare_url":"https://api.github.com/repos/marianitadn/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marianitadn/origin/merges","archive_url":"https://api.github.com/repos/marianitadn/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marianitadn/origin/downloads","issues_url":"https://api.github.com/repos/marianitadn/origin/issues{/number}","pulls_url":"https://api.github.com/repos/marianitadn/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/marianitadn/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/marianitadn/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marianitadn/origin/labels{/name}","releases_url":"https://api.github.com/repos/marianitadn/origin/releases{/id}","created_at":"2014-10-07T08:33:37Z","updated_at":"2014-10-06T21:05:01Z","pushed_at":"2014-10-22T12:04:15Z","git_url":"git://github.com/marianitadn/origin.git","ssh_url":"git@github.com:marianitadn/origin.git","clone_url":"https://github.com/marianitadn/origin.git","svn_url":"https://github.com/marianitadn/origin","homepage":"https://openshift.github.io","size":9250,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"92b5b47211f39d936cc528cf728fb516af022807","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=2","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=2","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments/{number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","created_at":"2014-07-30T20:04:05Z","updated_at":"2014-10-24T19:21:38Z","pushed_at":"2014-10-24T19:17:08Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"https://openshift.github.io","size":17403,"stargazers_count":128,"watchers_count":128,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":65,"mirror_url":null,"open_issues_count":40,"forks":65,"open_issues":40,"watchers":128,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/201"},"html":{"href":"https://github.com/openshift/origin/pull/201"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/201"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/201/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/201/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/201/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/ed5eb7b899dbb0b8750921a373e0595c815ed83f"}}}}