GitHub PullRequestReviewCommentEvent at 2014-08-29 17:09:31
Repository: level_up_exercises
Actor: houndci
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments/16908978","id":16908978,"diff_hunk":"@@ -3,26 +3,29 @@ class NameCollisionError < RuntimeError; end;\n class Robot\n   attr_accessor :name\n \n-  @@registry\n-\n-  def initialize(args = {})\n+  def initialize(args = nil)\n     @@registry ||= []\n-    @name_generator = args[:name_generator]\n+    generate_name(args)\n+  end\n \n+  def generate_name(params)\n+    params = nil ? @name = name_generator : @name = name","path":"short_methods/robot_name.rb","position":14,"original_position":14,"commit_id":"2941a1e8960320506fe2ceb99ff8f342eee25c80","original_commit_id":"2941a1e8960320506fe2ceb99ff8f342eee25c80","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=2","gravatar_id":"38d9cefd9971a05bf447f07c6cd332cc","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Useless assignment to variable - `params`.","created_at":"2014-08-29T17:09:31Z","updated_at":"2014-08-29T17:09:31Z","html_url":"https://github.com/jmmastey/level_up_exercises/pull/16#discussion_r16908978","pull_request_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/16","_links":{"self":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments/16908978"},"html":{"href":"https://github.com/jmmastey/level_up_exercises/pull/16#discussion_r16908978"},"pull_request":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/16"}}},"pull_request":{"url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/16","id":20509889,"html_url":"https://github.com/jmmastey/level_up_exercises/pull/16","diff_url":"https://github.com/jmmastey/level_up_exercises/pull/16.diff","patch_url":"https://github.com/jmmastey/level_up_exercises/pull/16.patch","issue_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/16","number":16,"state":"open","locked":false,"title":"CJ's latest pull request for triangle facts style","user":{"login":"chibondking","id":396488,"avatar_url":"https://avatars.githubusercontent.com/u/396488?v=2","gravatar_id":"e04cbde19ea0a7b4a8299d9621ca597a","url":"https://api.github.com/users/chibondking","html_url":"https://github.com/chibondking","followers_url":"https://api.github.com/users/chibondking/followers","following_url":"https://api.github.com/users/chibondking/following{/other_user}","gists_url":"https://api.github.com/users/chibondking/gists{/gist_id}","starred_url":"https://api.github.com/users/chibondking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chibondking/subscriptions","organizations_url":"https://api.github.com/users/chibondking/orgs","repos_url":"https://api.github.com/users/chibondking/repos","events_url":"https://api.github.com/users/chibondking/events{/privacy}","received_events_url":"https://api.github.com/users/chibondking/received_events","type":"User","site_admin":false},"body":"Finally? fixed tabs to spaces and stuff.. yay","created_at":"2014-08-29T16:35:25Z","updated_at":"2014-08-29T17:09:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"15334a8b438a7f60af80f37deea7b4e8b5f9250b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/16/commits","review_comments_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/16/comments","review_comment_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/16/comments","statuses_url":"https://api.github.com/repos/jmmastey/level_up_exercises/statuses/2941a1e8960320506fe2ceb99ff8f342eee25c80","head":{"label":"chibondking:master","ref":"master","sha":"2941a1e8960320506fe2ceb99ff8f342eee25c80","user":{"login":"chibondking","id":396488,"avatar_url":"https://avatars.githubusercontent.com/u/396488?v=2","gravatar_id":"e04cbde19ea0a7b4a8299d9621ca597a","url":"https://api.github.com/users/chibondking","html_url":"https://github.com/chibondking","followers_url":"https://api.github.com/users/chibondking/followers","following_url":"https://api.github.com/users/chibondking/following{/other_user}","gists_url":"https://api.github.com/users/chibondking/gists{/gist_id}","starred_url":"https://api.github.com/users/chibondking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chibondking/subscriptions","organizations_url":"https://api.github.com/users/chibondking/orgs","repos_url":"https://api.github.com/users/chibondking/repos","events_url":"https://api.github.com/users/chibondking/events{/privacy}","received_events_url":"https://api.github.com/users/chibondking/received_events","type":"User","site_admin":false},"repo":{"id":22891278,"name":"level_up_exercises","full_name":"chibondking/level_up_exercises","owner":{"login":"chibondking","id":396488,"avatar_url":"https://avatars.githubusercontent.com/u/396488?v=2","gravatar_id":"e04cbde19ea0a7b4a8299d9621ca597a","url":"https://api.github.com/users/chibondking","html_url":"https://github.com/chibondking","followers_url":"https://api.github.com/users/chibondking/followers","following_url":"https://api.github.com/users/chibondking/following{/other_user}","gists_url":"https://api.github.com/users/chibondking/gists{/gist_id}","starred_url":"https://api.github.com/users/chibondking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chibondking/subscriptions","organizations_url":"https://api.github.com/users/chibondking/orgs","repos_url":"https://api.github.com/users/chibondking/repos","events_url":"https://api.github.com/users/chibondking/events{/privacy}","received_events_url":"https://api.github.com/users/chibondking/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chibondking/level_up_exercises","description":"A long series of code-related assignments to challenge starting engineers","fork":true,"url":"https://api.github.com/repos/chibondking/level_up_exercises","forks_url":"https://api.github.com/repos/chibondking/level_up_exercises/forks","keys_url":"https://api.github.com/repos/chibondking/level_up_exercises/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chibondking/level_up_exercises/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chibondking/level_up_exercises/teams","hooks_url":"https://api.github.com/repos/chibondking/level_up_exercises/hooks","issue_events_url":"https://api.github.com/repos/chibondking/level_up_exercises/issues/events{/number}","events_url":"https://api.github.com/repos/chibondking/level_up_exercises/events","assignees_url":"https://api.github.com/repos/chibondking/level_up_exercises/assignees{/user}","branches_url":"https://api.github.com/repos/chibondking/level_up_exercises/branches{/branch}","tags_url":"https://api.github.com/repos/chibondking/level_up_exercises/tags","blobs_url":"https://api.github.com/repos/chibondking/level_up_exercises/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chibondking/level_up_exercises/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chibondking/level_up_exercises/git/refs{/sha}","trees_url":"https://api.github.com/repos/chibondking/level_up_exercises/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chibondking/level_up_exercises/statuses/{sha}","languages_url":"https://api.github.com/repos/chibondking/level_up_exercises/languages","stargazers_url":"https://api.github.com/repos/chibondking/level_up_exercises/stargazers","contributors_url":"https://api.github.com/repos/chibondking/level_up_exercises/contributors","subscribers_url":"https://api.github.com/repos/chibondking/level_up_exercises/subscribers","subscription_url":"https://api.github.com/repos/chibondking/level_up_exercises/subscription","commits_url":"https://api.github.com/repos/chibondking/level_up_exercises/commits{/sha}","git_commits_url":"https://api.github.com/repos/chibondking/level_up_exercises/git/commits{/sha}","comments_url":"https://api.github.com/repos/chibondking/level_up_exercises/comments{/number}","issue_comment_url":"https://api.github.com/repos/chibondking/level_up_exercises/issues/comments/{number}","contents_url":"https://api.github.com/repos/chibondking/level_up_exercises/contents/{+path}","compare_url":"https://api.github.com/repos/chibondking/level_up_exercises/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chibondking/level_up_exercises/merges","archive_url":"https://api.github.com/repos/chibondking/level_up_exercises/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chibondking/level_up_exercises/downloads","issues_url":"https://api.github.com/repos/chibondking/level_up_exercises/issues{/number}","pulls_url":"https://api.github.com/repos/chibondking/level_up_exercises/pulls{/number}","milestones_url":"https://api.github.com/repos/chibondking/level_up_exercises/milestones{/number}","notifications_url":"https://api.github.com/repos/chibondking/level_up_exercises/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chibondking/level_up_exercises/labels{/name}","releases_url":"https://api.github.com/repos/chibondking/level_up_exercises/releases{/id}","created_at":"2014-08-12T20:23:52Z","updated_at":"2014-08-19T22:47:40Z","pushed_at":"2014-08-29T17:09:27Z","git_url":"git://github.com/chibondking/level_up_exercises.git","ssh_url":"git@github.com:chibondking/level_up_exercises.git","clone_url":"https://github.com/chibondking/level_up_exercises.git","svn_url":"https://github.com/chibondking/level_up_exercises","homepage":null,"size":316,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jmmastey:master","ref":"master","sha":"25920545ba3817737476c713fd9995fc3741a3b7","user":{"login":"jmmastey","id":302011,"avatar_url":"https://avatars.githubusercontent.com/u/302011?v=2","gravatar_id":"a9704266587836f7e784235e5073b93e","url":"https://api.github.com/users/jmmastey","html_url":"https://github.com/jmmastey","followers_url":"https://api.github.com/users/jmmastey/followers","following_url":"https://api.github.com/users/jmmastey/following{/other_user}","gists_url":"https://api.github.com/users/jmmastey/gists{/gist_id}","starred_url":"https://api.github.com/users/jmmastey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmmastey/subscriptions","organizations_url":"https://api.github.com/users/jmmastey/orgs","repos_url":"https://api.github.com/users/jmmastey/repos","events_url":"https://api.github.com/users/jmmastey/events{/privacy}","received_events_url":"https://api.github.com/users/jmmastey/received_events","type":"User","site_admin":false},"repo":{"id":20705648,"name":"level_up_exercises","full_name":"jmmastey/level_up_exercises","owner":{"login":"jmmastey","id":302011,"avatar_url":"https://avatars.githubusercontent.com/u/302011?v=2","gravatar_id":"a9704266587836f7e784235e5073b93e","url":"https://api.github.com/users/jmmastey","html_url":"https://github.com/jmmastey","followers_url":"https://api.github.com/users/jmmastey/followers","following_url":"https://api.github.com/users/jmmastey/following{/other_user}","gists_url":"https://api.github.com/users/jmmastey/gists{/gist_id}","starred_url":"https://api.github.com/users/jmmastey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmmastey/subscriptions","organizations_url":"https://api.github.com/users/jmmastey/orgs","repos_url":"https://api.github.com/users/jmmastey/repos","events_url":"https://api.github.com/users/jmmastey/events{/privacy}","received_events_url":"https://api.github.com/users/jmmastey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmmastey/level_up_exercises","description":"A long series of code-related assignments to challenge starting engineers","fork":false,"url":"https://api.github.com/repos/jmmastey/level_up_exercises","forks_url":"https://api.github.com/repos/jmmastey/level_up_exercises/forks","keys_url":"https://api.github.com/repos/jmmastey/level_up_exercises/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmmastey/level_up_exercises/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmmastey/level_up_exercises/teams","hooks_url":"https://api.github.com/repos/jmmastey/level_up_exercises/hooks","issue_events_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/events{/number}","events_url":"https://api.github.com/repos/jmmastey/level_up_exercises/events","assignees_url":"https://api.github.com/repos/jmmastey/level_up_exercises/assignees{/user}","branches_url":"https://api.github.com/repos/jmmastey/level_up_exercises/branches{/branch}","tags_url":"https://api.github.com/repos/jmmastey/level_up_exercises/tags","blobs_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmmastey/level_up_exercises/statuses/{sha}","languages_url":"https://api.github.com/repos/jmmastey/level_up_exercises/languages","stargazers_url":"https://api.github.com/repos/jmmastey/level_up_exercises/stargazers","contributors_url":"https://api.github.com/repos/jmmastey/level_up_exercises/contributors","subscribers_url":"https://api.github.com/repos/jmmastey/level_up_exercises/subscribers","subscription_url":"https://api.github.com/repos/jmmastey/level_up_exercises/subscription","commits_url":"https://api.github.com/repos/jmmastey/level_up_exercises/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmmastey/level_up_exercises/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/comments/{number}","contents_url":"https://api.github.com/repos/jmmastey/level_up_exercises/contents/{+path}","compare_url":"https://api.github.com/repos/jmmastey/level_up_exercises/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmmastey/level_up_exercises/merges","archive_url":"https://api.github.com/repos/jmmastey/level_up_exercises/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmmastey/level_up_exercises/downloads","issues_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues{/number}","pulls_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls{/number}","milestones_url":"https://api.github.com/repos/jmmastey/level_up_exercises/milestones{/number}","notifications_url":"https://api.github.com/repos/jmmastey/level_up_exercises/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmmastey/level_up_exercises/labels{/name}","releases_url":"https://api.github.com/repos/jmmastey/level_up_exercises/releases{/id}","created_at":"2014-06-10T23:42:24Z","updated_at":"2014-08-28T08:28:34Z","pushed_at":"2014-08-28T19:10:13Z","git_url":"git://github.com/jmmastey/level_up_exercises.git","ssh_url":"git@github.com:jmmastey/level_up_exercises.git","clone_url":"https://github.com/jmmastey/level_up_exercises.git","svn_url":"https://github.com/jmmastey/level_up_exercises","homepage":null,"size":3141,"stargazers_count":7,"watchers_count":7,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":20,"mirror_url":null,"open_issues_count":6,"forks":20,"open_issues":6,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/16"},"html":{"href":"https://github.com/jmmastey/level_up_exercises/pull/16"},"issue":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/16"},"comments":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/statuses/2941a1e8960320506fe2ceb99ff8f342eee25c80"}}}}