GitHub PullRequestReviewCommentEvent at 2014-09-23 17:05:53
Repository: docker
Actor: tiborvass
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/17922179","id":17922179,"diff_hunk":"@@ -218,6 +218,17 @@ func TestRunStdinPipe(t *testing.T) {\n \tlogDone(\"run - pipe in with -i -a stdin\")\n }\n \n+func TestRmDetachedError(t *testing.T) {\n+\trunCmd := exec.Command(dockerBinary, \"run\", \"--rm\", \"-d\", \"busybox\", \"true\")\n+\tout, _, _, err := runCommandWithStdoutStderr(runCmd)\n+\tif err == nil {","path":"integration-cli/docker_cli_run_test.go","position":7,"original_position":7,"commit_id":"968ab8e762647e6c99a05e4942b1e52796f3c537","original_commit_id":"968ab8e762647e6c99a05e4942b1e52796f3c537","user":{"login":"tiborvass","id":827131,"avatar_url":"https://avatars.githubusercontent.com/u/827131?v=2","gravatar_id":"","url":"https://api.github.com/users/tiborvass","html_url":"https://github.com/tiborvass","followers_url":"https://api.github.com/users/tiborvass/followers","following_url":"https://api.github.com/users/tiborvass/following{/other_user}","gists_url":"https://api.github.com/users/tiborvass/gists{/gist_id}","starred_url":"https://api.github.com/users/tiborvass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiborvass/subscriptions","organizations_url":"https://api.github.com/users/tiborvass/orgs","repos_url":"https://api.github.com/users/tiborvass/repos","events_url":"https://api.github.com/users/tiborvass/events{/privacy}","received_events_url":"https://api.github.com/users/tiborvass/received_events","type":"User","site_admin":false},"body":"I vote for a simple: `strings.Contains(out, \"Conflicting options\")`\r\n\r\nAlso, the Test has to start with `TestRun`.","created_at":"2014-09-23T17:05:53Z","updated_at":"2014-09-23T17:05:53Z","html_url":"https://github.com/docker/docker/pull/8158#discussion_r17922179","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/8158","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/17922179"},"html":{"href":"https://github.com/docker/docker/pull/8158#discussion_r17922179"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/8158"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/8158","id":21562307,"html_url":"https://github.com/docker/docker/pull/8158","diff_url":"https://github.com/docker/docker/pull/8158.diff","patch_url":"https://github.com/docker/docker/pull/8158.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/8158","number":8158,"state":"open","locked":false,"title":"Cleanup: simplify flag parsing and merge into mflag (rebase ++)","user":{"login":"SvenDowideit","id":28492,"avatar_url":"https://avatars.githubusercontent.com/u/28492?v=2","gravatar_id":"","url":"https://api.github.com/users/SvenDowideit","html_url":"https://github.com/SvenDowideit","followers_url":"https://api.github.com/users/SvenDowideit/followers","following_url":"https://api.github.com/users/SvenDowideit/following{/other_user}","gists_url":"https://api.github.com/users/SvenDowideit/gists{/gist_id}","starred_url":"https://api.github.com/users/SvenDowideit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SvenDowideit/subscriptions","organizations_url":"https://api.github.com/users/SvenDowideit/orgs","repos_url":"https://api.github.com/users/SvenDowideit/repos","events_url":"https://api.github.com/users/SvenDowideit/events{/privacy}","received_events_url":"https://api.github.com/users/SvenDowideit/received_events","type":"User","site_admin":false},"body":"this is to get #7551 updated for merge.\r\n\r\nI've added the missing non-global validation functions, and rebased ","created_at":"2014-09-22T07:17:45Z","updated_at":"2014-09-23T17:05:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"39f611d935e77a2e312cbd20e70db8123ede82e7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker/pulls/8158/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/8158/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments/{number}","comments_url":"https://api.github.com/repos/docker/docker/issues/8158/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/968ab8e762647e6c99a05e4942b1e52796f3c537","head":{"label":"SvenDowideit:cleanup-flags-sven","ref":"cleanup-flags-sven","sha":"968ab8e762647e6c99a05e4942b1e52796f3c537","user":{"login":"SvenDowideit","id":28492,"avatar_url":"https://avatars.githubusercontent.com/u/28492?v=2","gravatar_id":"","url":"https://api.github.com/users/SvenDowideit","html_url":"https://github.com/SvenDowideit","followers_url":"https://api.github.com/users/SvenDowideit/followers","following_url":"https://api.github.com/users/SvenDowideit/following{/other_user}","gists_url":"https://api.github.com/users/SvenDowideit/gists{/gist_id}","starred_url":"https://api.github.com/users/SvenDowideit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SvenDowideit/subscriptions","organizations_url":"https://api.github.com/users/SvenDowideit/orgs","repos_url":"https://api.github.com/users/SvenDowideit/repos","events_url":"https://api.github.com/users/SvenDowideit/events{/privacy}","received_events_url":"https://api.github.com/users/SvenDowideit/received_events","type":"User","site_admin":false},"repo":{"id":13399967,"name":"docker","full_name":"SvenDowideit/docker","owner":{"login":"SvenDowideit","id":28492,"avatar_url":"https://avatars.githubusercontent.com/u/28492?v=2","gravatar_id":"","url":"https://api.github.com/users/SvenDowideit","html_url":"https://github.com/SvenDowideit","followers_url":"https://api.github.com/users/SvenDowideit/followers","following_url":"https://api.github.com/users/SvenDowideit/following{/other_user}","gists_url":"https://api.github.com/users/SvenDowideit/gists{/gist_id}","starred_url":"https://api.github.com/users/SvenDowideit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SvenDowideit/subscriptions","organizations_url":"https://api.github.com/users/SvenDowideit/orgs","repos_url":"https://api.github.com/users/SvenDowideit/repos","events_url":"https://api.github.com/users/SvenDowideit/events{/privacy}","received_events_url":"https://api.github.com/users/SvenDowideit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SvenDowideit/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/SvenDowideit/docker","forks_url":"https://api.github.com/repos/SvenDowideit/docker/forks","keys_url":"https://api.github.com/repos/SvenDowideit/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SvenDowideit/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SvenDowideit/docker/teams","hooks_url":"https://api.github.com/repos/SvenDowideit/docker/hooks","issue_events_url":"https://api.github.com/repos/SvenDowideit/docker/issues/events{/number}","events_url":"https://api.github.com/repos/SvenDowideit/docker/events","assignees_url":"https://api.github.com/repos/SvenDowideit/docker/assignees{/user}","branches_url":"https://api.github.com/repos/SvenDowideit/docker/branches{/branch}","tags_url":"https://api.github.com/repos/SvenDowideit/docker/tags","blobs_url":"https://api.github.com/repos/SvenDowideit/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SvenDowideit/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SvenDowideit/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/SvenDowideit/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SvenDowideit/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/SvenDowideit/docker/languages","stargazers_url":"https://api.github.com/repos/SvenDowideit/docker/stargazers","contributors_url":"https://api.github.com/repos/SvenDowideit/docker/contributors","subscribers_url":"https://api.github.com/repos/SvenDowideit/docker/subscribers","subscription_url":"https://api.github.com/repos/SvenDowideit/docker/subscription","commits_url":"https://api.github.com/repos/SvenDowideit/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/SvenDowideit/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/SvenDowideit/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/SvenDowideit/docker/issues/comments/{number}","contents_url":"https://api.github.com/repos/SvenDowideit/docker/contents/{+path}","compare_url":"https://api.github.com/repos/SvenDowideit/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SvenDowideit/docker/merges","archive_url":"https://api.github.com/repos/SvenDowideit/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SvenDowideit/docker/downloads","issues_url":"https://api.github.com/repos/SvenDowideit/docker/issues{/number}","pulls_url":"https://api.github.com/repos/SvenDowideit/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/SvenDowideit/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/SvenDowideit/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SvenDowideit/docker/labels{/name}","releases_url":"https://api.github.com/repos/SvenDowideit/docker/releases{/id}","created_at":"2013-10-08T00:56:36Z","updated_at":"2014-08-06T13:41:04Z","pushed_at":"2014-09-23T12:21:08Z","git_url":"git://github.com/SvenDowideit/docker.git","ssh_url":"git@github.com:SvenDowideit/docker.git","clone_url":"https://github.com/SvenDowideit/docker.git","svn_url":"https://github.com/SvenDowideit/docker","homepage":"http://www.docker.io","size":43577,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":4,"forks":1,"open_issues":4,"watchers":1,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"3ea5a20776ce6024752cc2c5964b08aeb8ce6c7d","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=2","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=2","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments/{number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","created_at":"2013-01-18T18:10:57Z","updated_at":"2014-09-23T15:44:53Z","pushed_at":"2014-09-23T17:02:59Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":142089,"stargazers_count":15262,"watchers_count":15262,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2896,"mirror_url":null,"open_issues_count":781,"forks":2896,"open_issues":781,"watchers":15262,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/8158"},"html":{"href":"https://github.com/docker/docker/pull/8158"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/8158"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/8158/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/8158/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/8158/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/968ab8e762647e6c99a05e4942b1e52796f3c537"}}}}