GitHub PullRequestEvent at 2014-10-09 19:07:53
Repository: foundation
Actor: gakimball
Payload: {"action":"closed","number":5864,"pull_request":{"url":"https://api.github.com/repos/zurb/foundation/pulls/5864","id":21846362,"html_url":"https://github.com/zurb/foundation/pull/5864","diff_url":"https://github.com/zurb/foundation/pull/5864.diff","patch_url":"https://github.com/zurb/foundation/pull/5864.patch","issue_url":"https://api.github.com/repos/zurb/foundation/issues/5864","number":5864,"state":"closed","locked":false,"title":"Tabs heavy-handed tabindex setting fix","user":{"login":"jopotts","id":26507,"avatar_url":"https://avatars.githubusercontent.com/u/26507?v=2","gravatar_id":"","url":"https://api.github.com/users/jopotts","html_url":"https://github.com/jopotts","followers_url":"https://api.github.com/users/jopotts/followers","following_url":"https://api.github.com/users/jopotts/following{/other_user}","gists_url":"https://api.github.com/users/jopotts/gists{/gist_id}","starred_url":"https://api.github.com/users/jopotts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jopotts/subscriptions","organizations_url":"https://api.github.com/users/jopotts/orgs","repos_url":"https://api.github.com/users/jopotts/repos","events_url":"https://api.github.com/users/jopotts/events{/privacy}","received_events_url":"https://api.github.com/users/jopotts/received_events","type":"User","site_admin":false},"body":"This change is to remove the tabindex attrs instead of setting them to zero on change of tab.\r\n\r\nThe problem with having a zero tabindex (on a div for example) is that Chrome highlights the area on click and includes it in the tabbable items, so removing the tabindex is a better option as it reverts the tab section to its default tab behaviour.","created_at":"2014-09-26T12:52:35Z","updated_at":"2014-10-09T19:07:52Z","closed_at":"2014-10-09T19:07:52Z","merged_at":"2014-10-09T19:07:52Z","merge_commit_sha":"1335502d4f01f82ee8ff15ebd58b1e509a5c468e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zurb/foundation/pulls/5864/commits","review_comments_url":"https://api.github.com/repos/zurb/foundation/pulls/5864/comments","review_comment_url":"https://api.github.com/repos/zurb/foundation/pulls/comments/{number}","comments_url":"https://api.github.com/repos/zurb/foundation/issues/5864/comments","statuses_url":"https://api.github.com/repos/zurb/foundation/statuses/d505719fba5a666eb395999324146b77bc3d35ab","head":{"label":"jopotts:master","ref":"master","sha":"d505719fba5a666eb395999324146b77bc3d35ab","user":{"login":"jopotts","id":26507,"avatar_url":"https://avatars.githubusercontent.com/u/26507?v=2","gravatar_id":"","url":"https://api.github.com/users/jopotts","html_url":"https://github.com/jopotts","followers_url":"https://api.github.com/users/jopotts/followers","following_url":"https://api.github.com/users/jopotts/following{/other_user}","gists_url":"https://api.github.com/users/jopotts/gists{/gist_id}","starred_url":"https://api.github.com/users/jopotts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jopotts/subscriptions","organizations_url":"https://api.github.com/users/jopotts/orgs","repos_url":"https://api.github.com/users/jopotts/repos","events_url":"https://api.github.com/users/jopotts/events{/privacy}","received_events_url":"https://api.github.com/users/jopotts/received_events","type":"User","site_admin":false},"repo":{"id":24498469,"name":"foundation","full_name":"jopotts/foundation","owner":{"login":"jopotts","id":26507,"avatar_url":"https://avatars.githubusercontent.com/u/26507?v=2","gravatar_id":"","url":"https://api.github.com/users/jopotts","html_url":"https://github.com/jopotts","followers_url":"https://api.github.com/users/jopotts/followers","following_url":"https://api.github.com/users/jopotts/following{/other_user}","gists_url":"https://api.github.com/users/jopotts/gists{/gist_id}","starred_url":"https://api.github.com/users/jopotts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jopotts/subscriptions","organizations_url":"https://api.github.com/users/jopotts/orgs","repos_url":"https://api.github.com/users/jopotts/repos","events_url":"https://api.github.com/users/jopotts/events{/privacy}","received_events_url":"https://api.github.com/users/jopotts/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jopotts/foundation","description":"The most advanced responsive front-end framework in the world. Quickly create prototypes and production code for sites and apps that work on any kind of device.","fork":true,"url":"https://api.github.com/repos/jopotts/foundation","forks_url":"https://api.github.com/repos/jopotts/foundation/forks","keys_url":"https://api.github.com/repos/jopotts/foundation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jopotts/foundation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jopotts/foundation/teams","hooks_url":"https://api.github.com/repos/jopotts/foundation/hooks","issue_events_url":"https://api.github.com/repos/jopotts/foundation/issues/events{/number}","events_url":"https://api.github.com/repos/jopotts/foundation/events","assignees_url":"https://api.github.com/repos/jopotts/foundation/assignees{/user}","branches_url":"https://api.github.com/repos/jopotts/foundation/branches{/branch}","tags_url":"https://api.github.com/repos/jopotts/foundation/tags","blobs_url":"https://api.github.com/repos/jopotts/foundation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jopotts/foundation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jopotts/foundation/git/refs{/sha}","trees_url":"https://api.github.com/repos/jopotts/foundation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jopotts/foundation/statuses/{sha}","languages_url":"https://api.github.com/repos/jopotts/foundation/languages","stargazers_url":"https://api.github.com/repos/jopotts/foundation/stargazers","contributors_url":"https://api.github.com/repos/jopotts/foundation/contributors","subscribers_url":"https://api.github.com/repos/jopotts/foundation/subscribers","subscription_url":"https://api.github.com/repos/jopotts/foundation/subscription","commits_url":"https://api.github.com/repos/jopotts/foundation/commits{/sha}","git_commits_url":"https://api.github.com/repos/jopotts/foundation/git/commits{/sha}","comments_url":"https://api.github.com/repos/jopotts/foundation/comments{/number}","issue_comment_url":"https://api.github.com/repos/jopotts/foundation/issues/comments/{number}","contents_url":"https://api.github.com/repos/jopotts/foundation/contents/{+path}","compare_url":"https://api.github.com/repos/jopotts/foundation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jopotts/foundation/merges","archive_url":"https://api.github.com/repos/jopotts/foundation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jopotts/foundation/downloads","issues_url":"https://api.github.com/repos/jopotts/foundation/issues{/number}","pulls_url":"https://api.github.com/repos/jopotts/foundation/pulls{/number}","milestones_url":"https://api.github.com/repos/jopotts/foundation/milestones{/number}","notifications_url":"https://api.github.com/repos/jopotts/foundation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jopotts/foundation/labels{/name}","releases_url":"https://api.github.com/repos/jopotts/foundation/releases{/id}","created_at":"2014-09-26T12:23:31Z","updated_at":"2014-09-26T12:50:08Z","pushed_at":"2014-10-01T13:49:12Z","git_url":"git://github.com/jopotts/foundation.git","ssh_url":"git@github.com:jopotts/foundation.git","clone_url":"https://github.com/jopotts/foundation.git","svn_url":"https://github.com/jopotts/foundation","homepage":"http://foundation.zurb.com","size":107272,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zurb:master","ref":"master","sha":"08d32e49852e09356fad216d2c57ade4b652b896","user":{"login":"zurb","id":156122,"avatar_url":"https://avatars.githubusercontent.com/u/156122?v=2","gravatar_id":"","url":"https://api.github.com/users/zurb","html_url":"https://github.com/zurb","followers_url":"https://api.github.com/users/zurb/followers","following_url":"https://api.github.com/users/zurb/following{/other_user}","gists_url":"https://api.github.com/users/zurb/gists{/gist_id}","starred_url":"https://api.github.com/users/zurb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zurb/subscriptions","organizations_url":"https://api.github.com/users/zurb/orgs","repos_url":"https://api.github.com/users/zurb/repos","events_url":"https://api.github.com/users/zurb/events{/privacy}","received_events_url":"https://api.github.com/users/zurb/received_events","type":"Organization","site_admin":false},"repo":{"id":2573058,"name":"foundation","full_name":"zurb/foundation","owner":{"login":"zurb","id":156122,"avatar_url":"https://avatars.githubusercontent.com/u/156122?v=2","gravatar_id":"","url":"https://api.github.com/users/zurb","html_url":"https://github.com/zurb","followers_url":"https://api.github.com/users/zurb/followers","following_url":"https://api.github.com/users/zurb/following{/other_user}","gists_url":"https://api.github.com/users/zurb/gists{/gist_id}","starred_url":"https://api.github.com/users/zurb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zurb/subscriptions","organizations_url":"https://api.github.com/users/zurb/orgs","repos_url":"https://api.github.com/users/zurb/repos","events_url":"https://api.github.com/users/zurb/events{/privacy}","received_events_url":"https://api.github.com/users/zurb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zurb/foundation","description":"The most advanced responsive front-end framework in the world. Quickly create prototypes and production code for sites and apps that work on any kind of device.","fork":false,"url":"https://api.github.com/repos/zurb/foundation","forks_url":"https://api.github.com/repos/zurb/foundation/forks","keys_url":"https://api.github.com/repos/zurb/foundation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zurb/foundation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zurb/foundation/teams","hooks_url":"https://api.github.com/repos/zurb/foundation/hooks","issue_events_url":"https://api.github.com/repos/zurb/foundation/issues/events{/number}","events_url":"https://api.github.com/repos/zurb/foundation/events","assignees_url":"https://api.github.com/repos/zurb/foundation/assignees{/user}","branches_url":"https://api.github.com/repos/zurb/foundation/branches{/branch}","tags_url":"https://api.github.com/repos/zurb/foundation/tags","blobs_url":"https://api.github.com/repos/zurb/foundation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zurb/foundation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zurb/foundation/git/refs{/sha}","trees_url":"https://api.github.com/repos/zurb/foundation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zurb/foundation/statuses/{sha}","languages_url":"https://api.github.com/repos/zurb/foundation/languages","stargazers_url":"https://api.github.com/repos/zurb/foundation/stargazers","contributors_url":"https://api.github.com/repos/zurb/foundation/contributors","subscribers_url":"https://api.github.com/repos/zurb/foundation/subscribers","subscription_url":"https://api.github.com/repos/zurb/foundation/subscription","commits_url":"https://api.github.com/repos/zurb/foundation/commits{/sha}","git_commits_url":"https://api.github.com/repos/zurb/foundation/git/commits{/sha}","comments_url":"https://api.github.com/repos/zurb/foundation/comments{/number}","issue_comment_url":"https://api.github.com/repos/zurb/foundation/issues/comments/{number}","contents_url":"https://api.github.com/repos/zurb/foundation/contents/{+path}","compare_url":"https://api.github.com/repos/zurb/foundation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zurb/foundation/merges","archive_url":"https://api.github.com/repos/zurb/foundation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zurb/foundation/downloads","issues_url":"https://api.github.com/repos/zurb/foundation/issues{/number}","pulls_url":"https://api.github.com/repos/zurb/foundation/pulls{/number}","milestones_url":"https://api.github.com/repos/zurb/foundation/milestones{/number}","notifications_url":"https://api.github.com/repos/zurb/foundation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zurb/foundation/labels{/name}","releases_url":"https://api.github.com/repos/zurb/foundation/releases{/id}","created_at":"2011-10-13T23:05:42Z","updated_at":"2014-10-09T18:51:54Z","pushed_at":"2014-10-09T19:07:46Z","git_url":"git://github.com/zurb/foundation.git","ssh_url":"git@github.com:zurb/foundation.git","clone_url":"https://github.com/zurb/foundation.git","svn_url":"https://github.com/zurb/foundation","homepage":"http://foundation.zurb.com","size":141922,"stargazers_count":18200,"watchers_count":18200,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":3964,"mirror_url":null,"open_issues_count":267,"forks":3964,"open_issues":267,"watchers":18200,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zurb/foundation/pulls/5864"},"html":{"href":"https://github.com/zurb/foundation/pull/5864"},"issue":{"href":"https://api.github.com/repos/zurb/foundation/issues/5864"},"comments":{"href":"https://api.github.com/repos/zurb/foundation/issues/5864/comments"},"review_comments":{"href":"https://api.github.com/repos/zurb/foundation/pulls/5864/comments"},"review_comment":{"href":"https://api.github.com/repos/zurb/foundation/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/zurb/foundation/pulls/5864/commits"},"statuses":{"href":"https://api.github.com/repos/zurb/foundation/statuses/d505719fba5a666eb395999324146b77bc3d35ab"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"gakimball","id":1142001,"avatar_url":"https://avatars.githubusercontent.com/u/1142001?v=2","gravatar_id":"","url":"https://api.github.com/users/gakimball","html_url":"https://github.com/gakimball","followers_url":"https://api.github.com/users/gakimball/followers","following_url":"https://api.github.com/users/gakimball/following{/other_user}","gists_url":"https://api.github.com/users/gakimball/gists{/gist_id}","starred_url":"https://api.github.com/users/gakimball/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gakimball/subscriptions","organizations_url":"https://api.github.com/users/gakimball/orgs","repos_url":"https://api.github.com/users/gakimball/repos","events_url":"https://api.github.com/users/gakimball/events{/privacy}","received_events_url":"https://api.github.com/users/gakimball/received_events","type":"User","site_admin":false},"comments":13,"review_comments":0,"commits":2,"additions":2,"deletions":2,"changed_files":1}}