GitHub PushEvent at 2014-10-10 20:49:56
Repository: openvpn
Actor: fknittel
Payload: {"shas":[["ba79c71d1255651bfcb8570519b4033c763d47d3","01cb9b8efa4473b5e546004e8acabd838106bf01@gentoo.org","Add configure check for the path to systemd-ask-password\n\nGentoo Linux installs this in /usr/bin by default. Also, the user may\nhave installed it in /usr/local/bin if building from source.\n\nAcked-by: David Sommerseth <davids@redhat.com>\nMessage-Id: 1404419045-14728-1-git-send-email-floppym@gentoo.org\nURL: http://article.gmane.org/gmane.network.openvpn.devel/8825\n\nSigned-off-by: David Sommerseth <davids@redhat.com>","Mike Gilbert",false],["d886d468849051af525bb8ff1b9080f6c934e3ab","b600cea3d30fad4b349f75afbfb92cf939026c42@redhat.com","Don't let openvpn_popen() keep zombies around\n\nCommit 9449e6a9eba30c9ed054f57d630a88c9f087080f introduced the\nopenvpn_popen() function to support retrieving passwords via systemd.\n\nIt was discovered that the child processes openvpn fork()ed would\nbe lingering around until openvpn stopped.  This was due to the lack\nof a wait() call.\n\nThis patch also cleans up a few minor white-space issues in the same\ncode segment.\n\n [v2 proper initialisation of status variable]\n\nSigned-off-by: David Sommerseth <davids@redhat.com>\nAcked-by: Gert Doering <gert@greenie.muc.de>\nMessage-Id: 1409930731-15263-2-git-send-email-davids@redhat.com\nURL: http://article.gmane.org/gmane.network.openvpn.devel/9021","David Sommerseth",false],["55480682b9bfa5894402954f4c740954d8c5c556","b600cea3d30fad4b349f75afbfb92cf939026c42@redhat.com","Don't try to use systemd-ask-password if it is not available\n\nIf the SYSTEMD_ASK_PASSWORD_PATH executable cannot be found, we\ndon't consider systemd as running.\n\n[v2 - Don't clean up white-space]\n\nSigned-off-by: David Sommerseth <davids@redhat.com>\nAcked-by: Gert Doering <gert@greenie.muc.de>\nMessage-Id: 20140909202044.GJ1118@greenie.muc.de\nURL: http://article.gmane.org/gmane.network.openvpn.devel/9035","David Sommerseth",false],["df8ebb21ad1957ec013ab832a0f6c18e9d6744f6","b600cea3d30fad4b349f75afbfb92cf939026c42@redhat.com","Clean up the pipe closing in openvpn_popen()\n\nDo the proper closing of the pipe ends which is not being used,\nalso in error situations.  Moved the closing of the parent side\nbefore the waitpid(), to be consistent with the child side (as\nearly as possible).\n\nAlso improved the error messages with more details.\n\n[v2 - Don't call close() if execve() fails]\n\nSigned-off-by: David Sommerseth <davids@redhat.com>\nAcked-by: Gert Doering <gert@greenie.muc.de>\nMessage-Id: 20140909202408.GK1118@greenie.muc.de\nURL: http://article.gmane.org/gmane.network.openvpn.devel/9036","David Sommerseth",false],["25e1ec71dd150e803c0a25308c193fea124c7b7a","1ff1d5ceb421971f93e6626b02a9591b29d7600e@thejh.net","Remove quadratic complexity from openvpn_base64_decode()\n\nEvery four input characters, openvpn_base64_decode called token_decode,\nwhich in turn called strlen() on the remaining input. This means that\nbase64 decoding in openvpn had quadratic complexity.\n\nAll we really need to know is whether the token is complete, so replace\nthe check to check just that, and make the complexity linear wrt the\ninput length.\n\nSigned-off-by: Steffan Karger <steffan.karger@fox-it.com>\nAcked-by: Gert Doering <gert@greenie.muc.de>\nMessage-Id: <5408494D.7050407@fox-it.com>\nURL: http://article.gmane.org/gmane.network.openvpn.devel/9016\nSigned-off-by: Gert Doering <gert@greenie.muc.de>","Jann Horn",false],["5ead2ae0f32e8e6d879ac0de352214a66a7bb351","f89149f9f59d3c1dc8ccdd1c738efc3af884d875@karger.me","Fix some unintialized variable warnings\n\nDoes not actually change behaviour, but fixes compiler warnings\nand properly initializing is good habit anyway.\n\nSigned-off-by: Steffan Karger <steffan@karger.me>\nAcked-by: David Sommerseth <dazo@users.sourceforge.net>\nMessage-Id: <1408568426-19601-1-git-send-email-steffan@karger.me>\nURL: http://article.gmane.org/gmane.network.openvpn.devel/9003\nSigned-off-by: Gert Doering <gert@greenie.muc.de>","Steffan Karger",false],["555b54cc0f0d6495ff427b9f02ecc3bc8ab73141","f89149f9f59d3c1dc8ccdd1c738efc3af884d875@karger.me","Fix clang warning in options.c\n\nfixed warning: expression which evaluates to zero treated as a\nnull pointer constant of type 'struct addrinfo *'\n\nSeems to be innocent, but clang is correct that this is strange.\ninit_tun() expects two pointers, but options_string() tried to\nfeed it two uint32_t values.\n\nSigned-off-by: Steffan Karger <steffan@karger.me>\nAcked-by: David Sommerseth <dazo@users.sourceforge.net>\nMessage-Id: <1408568426-19601-2-git-send-email-steffan@karger.me>\nURL: http://article.gmane.org/gmane.network.openvpn.devel/9004\nSigned-off-by: Gert Doering <gert@greenie.muc.de>","Steffan Karger",false],["9048d50b0a27a724ad088dc4904eb4888b0bca87","f89149f9f59d3c1dc8ccdd1c738efc3af884d875@karger.me","Fix compiler warnings in ssl_polarssl.c.\n\nNo functional changes, just add missing includes and make casts explicit.\n\nSigned-off-by: Steffan Karger <steffan@karger.me>\nAcked-by: Gert Doering <gert@greenie.muc.de>\nMessage-Id: <1408396155-9017-1-git-send-email-steffan@karger.me>\nURL: http://article.gmane.org/gmane.network.openvpn.devel/8991\nSigned-off-by: Gert Doering <gert@greenie.muc.de>","Steffan Karger",false],["8a4566ce4f01a434ac9ea841eae74330368398a0","b600cea3d30fad4b349f75afbfb92cf939026c42@redhat.com","Add systemd unit file for OpenVPN\n\nThis is to encourage all Linux distributions to use a unified systemd\nunit file.\n\nThis unit file also tries to reduce the capabilities of the running\nopenvpn process.\n\nSigned-off-by: David Sommerseth <davids@redhat.com>\nAcked-by: Gert Doering <gert@greenie.muc.de>\nMessage-Id: 1411030936-16309-1-git-send-email-openvpn.list@topphemmelig.net\nURL: http://article.gmane.org/gmane.network.openvpn.devel/9043","David Sommerseth",false],["e0c9e8452932a964b556daaeacdf7d9eab133e36","37ff487e37c386650e85cbda6009bd91b2eac8ca@redhat.com","ocsp_check - signature verification and cert staus results are separate\n\nwhen openssl returns result of parsing and verification of the\nOCSP response, the signature verification is separate from the certificate\nstatus, as such it's necessary to check both of them.\n\nOtherwise results like:\n\nResponse Verify Failure\n140170966779776:error:27069076:OCSP routines:OCSP_basic_verify:signer\ncertificate not found:ocsp_vfy.c:85:\nca/cert.pem: good\n        This Update: Sep 23 12:12:28 2014 GMT\n\nwill be accepted as being trustworthy.\n\nNote that \"Response verify OK\" is printed on stderr, so it can't\nbe discarded.\n\nSigned-off-by: Hubert Kario <hkario@redhat.com>\nAcked-by: Steffan Karger <steffan.karger@fox-it.com>\nMessage-Id: <1411727041-11884-1-git-send-email-hkario@redhat.com>\nURL: http://article.gmane.org/gmane.network.openvpn.devel/9054\nSigned-off-by: Gert Doering <gert@greenie.muc.de>","Hubert Kario",false],["51390f4de4f02edf377d55a7ef108798d2d8dc88","37ff487e37c386650e85cbda6009bd91b2eac8ca@redhat.com","ocsp_check - double check if ocsp didn't report any errors in execution\n\nin case the reposnses are too old, ocsp tool can return text like this:\n\nResponse verify OK\nca/cert.pem: WARNING: Status times invalid.\n139990703290240:error:2707307D:OCSP routines:OCSP_check_validity:status\nexpired:ocsp_cl.c:358:\ngood\n        This Update: Sep 21 12:12:48 2014 GMT\n        Next Update: Sep 22 12:12:48 2014 GMT\n\nlight change in buffering can cause \"verify OK\" and \"ca/cert.pem: good\"\nto be placed in a way that matching will be valid\nAcked-by: Steffan Karger <steffan.karger@fox-it.com>\nMessage-Id: <1411727041-11884-2-git-send-email-hkario@redhat.com>\nURL: http://article.gmane.org/gmane.network.openvpn.devel/9055\n\nSigned-off-by: Gert Doering <gert@greenie.muc.de>","Hubert Kario",false],["f33ee6bcb12fdc3869b17b7c528a209f16581e2e","b600cea3d30fad4b349f75afbfb92cf939026c42@redhat.com","systemd: Use systemd functions to consider systemd availability\n\nThis is another systemd implementation clean-up.  It was found that\nSELinux will block OpenVPN from checking /sys/fs/cgroups.  As OpenVPN\nonly checked /sys/fs/cgroups and /sys/fs/cgroups/systemd to see if\nsystemd was available or not, it was considered better to query\nsystemd directly to see whether or not to query for usernames and\npasswords via systemd.\n\nThis patch has been compile tested on Fedora 19 and Fedora 21 alpha and\nfunction tested on Fedora 19.\n\n  v2 - Use PKG_CHECK_MODULES() + check for libsystemd before\n       libystemd-daemon.  systemd >= 209 use a unified library\n\nSigned-off-by: David Sommerseth <davids@redhat.com>\nAcked-by: Gert Doering <gert@greenie.muc.de>\nMessage-Id: <1412356567-27125-1-git-send-email-openvpn.list@topphemmelig.net>\nURL: http://article.gmane.org/gmane.network.openvpn.devel/9072\nSigned-off-by: Gert Doering <gert@greenie.muc.de>","David Sommerseth",false],["5ca1d70fa030d4344e4b64a28811a6aab091e0d2","dab03e449f14e75765945578a2efe6f319276af7@rfc2549.org","Add documentation for PERSIST_TUN_ACTION (Android specific)\n\nAcked-by: Gert Doering <gert@greenie.muc.de>\nMessage-Id: <1412712650-5173-1-git-send-email-arne@rfc2549.org>\nURL: http://article.gmane.org/gmane.network.openvpn.devel/9090\n\nSigned-off-by: Gert Doering <gert@greenie.muc.de>","Arne Schwabe",false],["973ffb3cd07257a9be425ba175ac1ae89c8470e5","4b56af5ae892d60698d02db5913af96ca4a4e6d7@lettink.de","client-connect: Split multi_connection_established into separate functions\n\nThis patch splits up the multi_connection_established() function.  Each new\nhelper function does a specific job.  Functions that do a similar job receive a\nsimilar calling interface.\n\nThe patch tries not to reindent code, so that the real changes are as clearly\nvisible as possible.  (A follow-up patch will only do indentation changes.)\n\nSigned-off-by: Fabian Knittel <fabian.knittel@lettink.de>","Fabian Knittel",true],["212a171b05c892044c10eebf46adc6c5fe8d52fa","4b56af5ae892d60698d02db5913af96ca4a4e6d7@lettink.de","client-connect: Properly indent all functions\n\nThis patch adds proper indentation to all new helper functions.  No functional\nchanges are performed.  Nothing is moved around.\n\nSigned-off-by: Fabian Knittel <fabian.knittel@lettink.de>","Fabian Knittel",true],["bd3eefca579d60ecb1c0422441bd5083d4f95210","4b56af5ae892d60698d02db5913af96ca4a4e6d7@lettink.de","client-connect: Refactor multi_client_connect_source_ccd\n\nRefactor multi_client_connect_source_ccd(), so that options_server_import() (or\nthe success path in general) is only entered in one place within the function.\n\nSigned-off-by: Fabian Knittel <fabian.knittel@lettink.de>","Fabian Knittel",true],["6eeac976ab2dee7f4523121a50d16f358160f28a","4b56af5ae892d60698d02db5913af96ca4a4e6d7@lettink.de","client-connect: Move multi_client_connect_setenv into early_setup\n\nThis patch moves multi_client_connect_setenv into\nmulti_client_connect_early_setup and makes sure that every client-connect\nhandling function updates the virtual address selection.\n\nBackground: This unifies how the client-connect handling functions work.\n\nSigned-off-by: Fabian Knittel <fabian.knittel@lettink.de>","Fabian Knittel",true],["d3c0de10949de7091c9ec74c17445ad5ba789d99","4b56af5ae892d60698d02db5913af96ca4a4e6d7@lettink.de","client-connect: Refactor to use return values instead of modifying a passed-in flag\n\nThis patch changes the way the client-connect helper functions communicate with\nthe main function.  Instead of updating cc_succeeded and cc_succeeded_count,\nthey now return either CC_RET_SUCCEEDED, CC_RET_FAILED or CC_RET_SKIPPED.\n\nIn addition, the client-connect helpers are now called in completely identical\nways.  This is in preparation of handling the helpers as simple call-backs.\n\nSigned-off-by: Fabian Knittel <fabian.knittel@lettink.de>","Fabian Knittel",true],["76aebcd8db52f40a23b3433939406a0acb1dbb59","4b56af5ae892d60698d02db5913af96ca4a4e6d7@lettink.de","client-connect: Refactor client-connect handling to calling a bunch of hooks in a loop\n\nThis patch changes the calling of the client-connect functions into an array\nof hooks and a block of code that calls them in a loop.\n\nSigned-off-by: Fabian Knittel <fabian.knittel@lettink.de>","Fabian Knittel",true],["f303cbdf1051ab98999e2bae008fe114983cfd57","4b56af5ae892d60698d02db5913af96ca4a4e6d7@lettink.de","client-connect: Add CC_RET_DEFERRED and cope with deferred client-connect\n\nThis patch moves the state, that was previously tracked within the\nmulti_connection_established() function, into struct client_connect_state.  The\nmulti_connection_established() function can now be exited and re-entered as\nmany times as necessary - without losing the client-connect handling state.\n\nThe patch also adds the new return value CC_RET_DEFERRED which indicates that\nthe handler couldn't complete immediately, and needs to be called later.  At\nthat point multi_connection_established() will exit without indicating\ncompletion.\n\nEach client-connect handler now has an (optional) additional call-back:  The\ncall-back for handling the deferred case.  If the main call-back returns\nCC_RET_DEFERRED, the next call to the handler will be through the deferred\ncall-back.\n\nSigned-off-by: Fabian Knittel <fabian.knittel@lettink.de>","Fabian Knittel",true]],"size":22,"ref":"refs/heads/feat_deferred_client-connect","head":"ea413d666bd6e4817e293ffffdb9acaa1f1e98f4"}