GitHub PullRequestReviewCommentEvent at 2014-06-11 20:07:01
Repository: brooklyn
Actor: ahgittin
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/brooklyncentral/brooklyn/pulls/comments/13670834","id":13670834,"diff_hunk":"@@ -37,7 +38,7 @@\n     \n     @BeforeMethod(alwaysRun=true)\n     public void setUp() throws Exception {\n-        managementContext = Entities.newManagementContext();\n+        managementContext = new LocalManagementContextForTests();","path":"core/src/test/java/brooklyn/entity/EntityPreManagementTest.java","position":13,"original_position":13,"commit_id":"7dfb2339c447cf6f2c8a757db13b15b99a05ddf7","original_commit_id":"94ede0862e5f18ed997787f249f7c00bc5184185","user":{"login":"ahgittin","id":496540,"avatar_url":"https://avatars.githubusercontent.com/u/496540?","gravatar_id":"b2cc5103505bf11a36c99c961929db5b","url":"https://api.github.com/users/ahgittin","html_url":"https://github.com/ahgittin","followers_url":"https://api.github.com/users/ahgittin/followers","following_url":"https://api.github.com/users/ahgittin/following{/other_user}","gists_url":"https://api.github.com/users/ahgittin/gists{/gist_id}","starred_url":"https://api.github.com/users/ahgittin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahgittin/subscriptions","organizations_url":"https://api.github.com/users/ahgittin/orgs","repos_url":"https://api.github.com/users/ahgittin/repos","events_url":"https://api.github.com/users/ahgittin/events{/privacy}","received_events_url":"https://api.github.com/users/ahgittin/received_events","type":"User","site_admin":false},"body":"good idea.  not that i want to refactor it all but easier to do it now :)","created_at":"2014-06-11T20:07:01Z","updated_at":"2014-06-11T20:07:01Z","html_url":"https://github.com/brooklyncentral/brooklyn/pull/1466#discussion_r13670834","pull_request_url":"https://api.github.com/repos/brooklyncentral/brooklyn/pulls/1466","_links":{"self":{"href":"https://api.github.com/repos/brooklyncentral/brooklyn/pulls/comments/13670834"},"html":{"href":"https://github.com/brooklyncentral/brooklyn/pull/1466#discussion_r13670834"},"pull_request":{"href":"https://api.github.com/repos/brooklyncentral/brooklyn/pulls/1466"}}},"pull_request":{"url":"https://api.github.com/repos/brooklyncentral/brooklyn/pulls/1466","id":16979875,"html_url":"https://github.com/brooklyncentral/brooklyn/pull/1466","diff_url":"https://github.com/brooklyncentral/brooklyn/pull/1466.diff","patch_url":"https://github.com/brooklyncentral/brooklyn/pull/1466.patch","issue_url":"https://api.github.com/repos/brooklyncentral/brooklyn/issues/1466","number":1466,"state":"open","title":"Keystore can be specified from brooklyn.properties, and tidies to use of temp dir and tidies in tests","user":{"login":"ahgittin","id":496540,"avatar_url":"https://avatars.githubusercontent.com/u/496540?","gravatar_id":"b2cc5103505bf11a36c99c961929db5b","url":"https://api.github.com/users/ahgittin","html_url":"https://github.com/ahgittin","followers_url":"https://api.github.com/users/ahgittin/followers","following_url":"https://api.github.com/users/ahgittin/following{/other_user}","gists_url":"https://api.github.com/users/ahgittin/gists{/gist_id}","starred_url":"https://api.github.com/users/ahgittin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahgittin/subscriptions","organizations_url":"https://api.github.com/users/ahgittin/orgs","repos_url":"https://api.github.com/users/ahgittin/repos","events_url":"https://api.github.com/users/ahgittin/events{/privacy}","received_events_url":"https://api.github.com/users/ahgittin/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-06-11T05:19:17Z","updated_at":"2014-06-11T20:07:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9bc99a159af698ba22dc92d23cabc440d5b3d395","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/brooklyncentral/brooklyn/pulls/1466/commits","review_comments_url":"https://api.github.com/repos/brooklyncentral/brooklyn/pulls/1466/comments","review_comment_url":"https://api.github.com/repos/brooklyncentral/brooklyn/pulls/comments/{number}","comments_url":"https://api.github.com/repos/brooklyncentral/brooklyn/issues/1466/comments","statuses_url":"https://api.github.com/repos/brooklyncentral/brooklyn/statuses/7dfb2339c447cf6f2c8a757db13b15b99a05ddf7","head":{"label":"ahgittin:certs-and-temp","ref":"certs-and-temp","sha":"7dfb2339c447cf6f2c8a757db13b15b99a05ddf7","user":{"login":"ahgittin","id":496540,"avatar_url":"https://avatars.githubusercontent.com/u/496540?","gravatar_id":"b2cc5103505bf11a36c99c961929db5b","url":"https://api.github.com/users/ahgittin","html_url":"https://github.com/ahgittin","followers_url":"https://api.github.com/users/ahgittin/followers","following_url":"https://api.github.com/users/ahgittin/following{/other_user}","gists_url":"https://api.github.com/users/ahgittin/gists{/gist_id}","starred_url":"https://api.github.com/users/ahgittin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahgittin/subscriptions","organizations_url":"https://api.github.com/users/ahgittin/orgs","repos_url":"https://api.github.com/users/ahgittin/repos","events_url":"https://api.github.com/users/ahgittin/events{/privacy}","received_events_url":"https://api.github.com/users/ahgittin/received_events","type":"User","site_admin":false},"repo":{"id":3919431,"name":"brooklyn","full_name":"ahgittin/brooklyn","owner":{"login":"ahgittin","id":496540,"avatar_url":"https://avatars.githubusercontent.com/u/496540?","gravatar_id":"b2cc5103505bf11a36c99c961929db5b","url":"https://api.github.com/users/ahgittin","html_url":"https://github.com/ahgittin","followers_url":"https://api.github.com/users/ahgittin/followers","following_url":"https://api.github.com/users/ahgittin/following{/other_user}","gists_url":"https://api.github.com/users/ahgittin/gists{/gist_id}","starred_url":"https://api.github.com/users/ahgittin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahgittin/subscriptions","organizations_url":"https://api.github.com/users/ahgittin/orgs","repos_url":"https://api.github.com/users/ahgittin/repos","events_url":"https://api.github.com/users/ahgittin/events{/privacy}","received_events_url":"https://api.github.com/users/ahgittin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ahgittin/brooklyn","description":"Brooklyn","fork":true,"url":"https://api.github.com/repos/ahgittin/brooklyn","forks_url":"https://api.github.com/repos/ahgittin/brooklyn/forks","keys_url":"https://api.github.com/repos/ahgittin/brooklyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ahgittin/brooklyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ahgittin/brooklyn/teams","hooks_url":"https://api.github.com/repos/ahgittin/brooklyn/hooks","issue_events_url":"https://api.github.com/repos/ahgittin/brooklyn/issues/events{/number}","events_url":"https://api.github.com/repos/ahgittin/brooklyn/events","assignees_url":"https://api.github.com/repos/ahgittin/brooklyn/assignees{/user}","branches_url":"https://api.github.com/repos/ahgittin/brooklyn/branches{/branch}","tags_url":"https://api.github.com/repos/ahgittin/brooklyn/tags","blobs_url":"https://api.github.com/repos/ahgittin/brooklyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ahgittin/brooklyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ahgittin/brooklyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/ahgittin/brooklyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ahgittin/brooklyn/statuses/{sha}","languages_url":"https://api.github.com/repos/ahgittin/brooklyn/languages","stargazers_url":"https://api.github.com/repos/ahgittin/brooklyn/stargazers","contributors_url":"https://api.github.com/repos/ahgittin/brooklyn/contributors","subscribers_url":"https://api.github.com/repos/ahgittin/brooklyn/subscribers","subscription_url":"https://api.github.com/repos/ahgittin/brooklyn/subscription","commits_url":"https://api.github.com/repos/ahgittin/brooklyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/ahgittin/brooklyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/ahgittin/brooklyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/ahgittin/brooklyn/issues/comments/{number}","contents_url":"https://api.github.com/repos/ahgittin/brooklyn/contents/{+path}","compare_url":"https://api.github.com/repos/ahgittin/brooklyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ahgittin/brooklyn/merges","archive_url":"https://api.github.com/repos/ahgittin/brooklyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ahgittin/brooklyn/downloads","issues_url":"https://api.github.com/repos/ahgittin/brooklyn/issues{/number}","pulls_url":"https://api.github.com/repos/ahgittin/brooklyn/pulls{/number}","milestones_url":"https://api.github.com/repos/ahgittin/brooklyn/milestones{/number}","notifications_url":"https://api.github.com/repos/ahgittin/brooklyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ahgittin/brooklyn/labels{/name}","releases_url":"https://api.github.com/repos/ahgittin/brooklyn/releases{/id}","created_at":"2012-04-03T15:31:40Z","updated_at":"2014-06-11T18:13:30Z","pushed_at":"2014-06-11T18:13:34Z","git_url":"git://github.com/ahgittin/brooklyn.git","ssh_url":"git@github.com:ahgittin/brooklyn.git","clone_url":"https://github.com/ahgittin/brooklyn.git","svn_url":"https://github.com/ahgittin/brooklyn","homepage":"http://brooklyncentral.github.com","size":228143,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"brooklyncentral:master","ref":"master","sha":"0389553f650ac2b74e9355c87364162f972836e7","user":{"login":"brooklyncentral","id":1587357,"avatar_url":"https://avatars.githubusercontent.com/u/1587357?","gravatar_id":"6ef2c620a556fa4325791bb9082039b3","url":"https://api.github.com/users/brooklyncentral","html_url":"https://github.com/brooklyncentral","followers_url":"https://api.github.com/users/brooklyncentral/followers","following_url":"https://api.github.com/users/brooklyncentral/following{/other_user}","gists_url":"https://api.github.com/users/brooklyncentral/gists{/gist_id}","starred_url":"https://api.github.com/users/brooklyncentral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brooklyncentral/subscriptions","organizations_url":"https://api.github.com/users/brooklyncentral/orgs","repos_url":"https://api.github.com/users/brooklyncentral/repos","events_url":"https://api.github.com/users/brooklyncentral/events{/privacy}","received_events_url":"https://api.github.com/users/brooklyncentral/received_events","type":"Organization","site_admin":false},"repo":{"id":3876814,"name":"brooklyn","full_name":"brooklyncentral/brooklyn","owner":{"login":"brooklyncentral","id":1587357,"avatar_url":"https://avatars.githubusercontent.com/u/1587357?","gravatar_id":"6ef2c620a556fa4325791bb9082039b3","url":"https://api.github.com/users/brooklyncentral","html_url":"https://github.com/brooklyncentral","followers_url":"https://api.github.com/users/brooklyncentral/followers","following_url":"https://api.github.com/users/brooklyncentral/following{/other_user}","gists_url":"https://api.github.com/users/brooklyncentral/gists{/gist_id}","starred_url":"https://api.github.com/users/brooklyncentral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brooklyncentral/subscriptions","organizations_url":"https://api.github.com/users/brooklyncentral/orgs","repos_url":"https://api.github.com/users/brooklyncentral/repos","events_url":"https://api.github.com/users/brooklyncentral/events{/privacy}","received_events_url":"https://api.github.com/users/brooklyncentral/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/brooklyncentral/brooklyn","description":"Brooklyn Multi-Cloud Application Management Project","fork":false,"url":"https://api.github.com/repos/brooklyncentral/brooklyn","forks_url":"https://api.github.com/repos/brooklyncentral/brooklyn/forks","keys_url":"https://api.github.com/repos/brooklyncentral/brooklyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brooklyncentral/brooklyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brooklyncentral/brooklyn/teams","hooks_url":"https://api.github.com/repos/brooklyncentral/brooklyn/hooks","issue_events_url":"https://api.github.com/repos/brooklyncentral/brooklyn/issues/events{/number}","events_url":"https://api.github.com/repos/brooklyncentral/brooklyn/events","assignees_url":"https://api.github.com/repos/brooklyncentral/brooklyn/assignees{/user}","branches_url":"https://api.github.com/repos/brooklyncentral/brooklyn/branches{/branch}","tags_url":"https://api.github.com/repos/brooklyncentral/brooklyn/tags","blobs_url":"https://api.github.com/repos/brooklyncentral/brooklyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brooklyncentral/brooklyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brooklyncentral/brooklyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/brooklyncentral/brooklyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brooklyncentral/brooklyn/statuses/{sha}","languages_url":"https://api.github.com/repos/brooklyncentral/brooklyn/languages","stargazers_url":"https://api.github.com/repos/brooklyncentral/brooklyn/stargazers","contributors_url":"https://api.github.com/repos/brooklyncentral/brooklyn/contributors","subscribers_url":"https://api.github.com/repos/brooklyncentral/brooklyn/subscribers","subscription_url":"https://api.github.com/repos/brooklyncentral/brooklyn/subscription","commits_url":"https://api.github.com/repos/brooklyncentral/brooklyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/brooklyncentral/brooklyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/brooklyncentral/brooklyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/brooklyncentral/brooklyn/issues/comments/{number}","contents_url":"https://api.github.com/repos/brooklyncentral/brooklyn/contents/{+path}","compare_url":"https://api.github.com/repos/brooklyncentral/brooklyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brooklyncentral/brooklyn/merges","archive_url":"https://api.github.com/repos/brooklyncentral/brooklyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brooklyncentral/brooklyn/downloads","issues_url":"https://api.github.com/repos/brooklyncentral/brooklyn/issues{/number}","pulls_url":"https://api.github.com/repos/brooklyncentral/brooklyn/pulls{/number}","milestones_url":"https://api.github.com/repos/brooklyncentral/brooklyn/milestones{/number}","notifications_url":"https://api.github.com/repos/brooklyncentral/brooklyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brooklyncentral/brooklyn/labels{/name}","releases_url":"https://api.github.com/repos/brooklyncentral/brooklyn/releases{/id}","created_at":"2012-03-30T13:23:26Z","updated_at":"2014-06-10T14:48:59Z","pushed_at":"2014-06-10T14:48:59Z","git_url":"git://github.com/brooklyncentral/brooklyn.git","ssh_url":"git@github.com:brooklyncentral/brooklyn.git","clone_url":"https://github.com/brooklyncentral/brooklyn.git","svn_url":"https://github.com/brooklyncentral/brooklyn","homepage":"http://brooklyn.io","size":241294,"stargazers_count":65,"watchers_count":65,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":32,"mirror_url":null,"open_issues_count":131,"forks":32,"open_issues":131,"watchers":65,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brooklyncentral/brooklyn/pulls/1466"},"html":{"href":"https://github.com/brooklyncentral/brooklyn/pull/1466"},"issue":{"href":"https://api.github.com/repos/brooklyncentral/brooklyn/issues/1466"},"comments":{"href":"https://api.github.com/repos/brooklyncentral/brooklyn/issues/1466/comments"},"review_comments":{"href":"https://api.github.com/repos/brooklyncentral/brooklyn/pulls/1466/comments"},"review_comment":{"href":"https://api.github.com/repos/brooklyncentral/brooklyn/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/brooklyncentral/brooklyn/pulls/1466/commits"},"statuses":{"href":"https://api.github.com/repos/brooklyncentral/brooklyn/statuses/7dfb2339c447cf6f2c8a757db13b15b99a05ddf7"}}}}