GitHub PullRequestReviewCommentEvent at 2014-08-04 06:19:02
Repository: Bukkit
Actor: turt2live
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Bukkit/Bukkit/pulls/comments/15741762","id":15741762,"diff_hunk":"@@ -62,6 +63,13 @@ public InventoryClickEvent(InventoryView view, SlotType type, int slot, ClickTyp\n         super(view);\n         this.slot_type = type;\n         this.rawSlot = slot;\n+        if (slot < 0) {","path":"src/main/java/org/bukkit/event/inventory/InventoryClickEvent.java","position":12,"original_position":12,"commit_id":"a5f2aff6217b4320fa6d7928674c31a205b4ed0e","original_commit_id":"a5f2aff6217b4320fa6d7928674c31a205b4ed0e","user":{"login":"turt2live","id":1190097,"avatar_url":"https://avatars.githubusercontent.com/u/1190097?v=1","gravatar_id":"1ff897313ab7ed45a24871913d0968e6","url":"https://api.github.com/users/turt2live","html_url":"https://github.com/turt2live","followers_url":"https://api.github.com/users/turt2live/followers","following_url":"https://api.github.com/users/turt2live/following{/other_user}","gists_url":"https://api.github.com/users/turt2live/gists{/gist_id}","starred_url":"https://api.github.com/users/turt2live/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/turt2live/subscriptions","organizations_url":"https://api.github.com/users/turt2live/orgs","repos_url":"https://api.github.com/users/turt2live/repos","events_url":"https://api.github.com/users/turt2live/events{/privacy}","received_events_url":"https://api.github.com/users/turt2live/received_events","type":"User","site_admin":false},"body":"For cleanliness, this should really be moved below the variable declarations","created_at":"2014-08-04T06:19:02Z","updated_at":"2014-08-04T06:19:02Z","html_url":"https://github.com/Bukkit/Bukkit/pull/896#discussion_r15741762","pull_request_url":"https://api.github.com/repos/Bukkit/Bukkit/pulls/896","_links":{"self":{"href":"https://api.github.com/repos/Bukkit/Bukkit/pulls/comments/15741762"},"html":{"href":"https://github.com/Bukkit/Bukkit/pull/896#discussion_r15741762"},"pull_request":{"href":"https://api.github.com/repos/Bukkit/Bukkit/pulls/896"}}},"pull_request":{"url":"https://api.github.com/repos/Bukkit/Bukkit/pulls/896","id":6765684,"html_url":"https://github.com/Bukkit/Bukkit/pull/896","diff_url":"https://github.com/Bukkit/Bukkit/pull/896.diff","patch_url":"https://github.com/Bukkit/Bukkit/pull/896.patch","issue_url":"https://api.github.com/repos/Bukkit/Bukkit/issues/896","number":896,"state":"open","title":"[B] Add InventoryClickEvent.getClickedInventory. Adds BUKKIT-4495","user":{"login":"aikar","id":58008,"avatar_url":"https://avatars.githubusercontent.com/u/58008?v=1","gravatar_id":"c6abf37c059c2eb548319c49bf5125ea","url":"https://api.github.com/users/aikar","html_url":"https://github.com/aikar","followers_url":"https://api.github.com/users/aikar/followers","following_url":"https://api.github.com/users/aikar/following{/other_user}","gists_url":"https://api.github.com/users/aikar/gists{/gist_id}","starred_url":"https://api.github.com/users/aikar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aikar/subscriptions","organizations_url":"https://api.github.com/users/aikar/orgs","repos_url":"https://api.github.com/users/aikar/repos","events_url":"https://api.github.com/users/aikar/events{/privacy}","received_events_url":"https://api.github.com/users/aikar/received_events","type":"User","site_admin":false},"body":"**The Issue:**\r\nPlugins currently have to do the logic themselves on the raw slot ID in order to determine the inventory clicked. \r\n\r\n**Justification**\r\nAn API that simply returns which inventory was clicked will simplify plugin development. If the internals change in the future where the raw slot method is not accurate or not needed, then the getClickedInventory calculation can be updated and plugins will not break.\r\n\r\nCurrently plugins require checking an implementation detail to figure this out, and that is not recommended.\r\n\r\n**Breakdown**\r\nThis change uses the current method of determining the clicked inventory and exposes it by getClickedInventory()","created_at":"2013-07-07T14:42:33Z","updated_at":"2014-08-04T06:19:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c158c5b77dc1b4c419dbd5d4919868919b0f4e11","assignee":{"login":"turt2live","id":1190097,"avatar_url":"https://avatars.githubusercontent.com/u/1190097?v=1","gravatar_id":"1ff897313ab7ed45a24871913d0968e6","url":"https://api.github.com/users/turt2live","html_url":"https://github.com/turt2live","followers_url":"https://api.github.com/users/turt2live/followers","following_url":"https://api.github.com/users/turt2live/following{/other_user}","gists_url":"https://api.github.com/users/turt2live/gists{/gist_id}","starred_url":"https://api.github.com/users/turt2live/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/turt2live/subscriptions","organizations_url":"https://api.github.com/users/turt2live/orgs","repos_url":"https://api.github.com/users/turt2live/repos","events_url":"https://api.github.com/users/turt2live/events{/privacy}","received_events_url":"https://api.github.com/users/turt2live/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/Bukkit/Bukkit/pulls/896/commits","review_comments_url":"https://api.github.com/repos/Bukkit/Bukkit/pulls/896/comments","review_comment_url":"https://api.github.com/repos/Bukkit/Bukkit/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Bukkit/Bukkit/issues/896/comments","statuses_url":"https://api.github.com/repos/Bukkit/Bukkit/statuses/a5f2aff6217b4320fa6d7928674c31a205b4ed0e","head":{"label":"aikar:BUKKIT-4495","ref":"BUKKIT-4495","sha":"a5f2aff6217b4320fa6d7928674c31a205b4ed0e","user":{"login":"aikar","id":58008,"avatar_url":"https://avatars.githubusercontent.com/u/58008?v=1","gravatar_id":"c6abf37c059c2eb548319c49bf5125ea","url":"https://api.github.com/users/aikar","html_url":"https://github.com/aikar","followers_url":"https://api.github.com/users/aikar/followers","following_url":"https://api.github.com/users/aikar/following{/other_user}","gists_url":"https://api.github.com/users/aikar/gists{/gist_id}","starred_url":"https://api.github.com/users/aikar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aikar/subscriptions","organizations_url":"https://api.github.com/users/aikar/orgs","repos_url":"https://api.github.com/users/aikar/repos","events_url":"https://api.github.com/users/aikar/events{/privacy}","received_events_url":"https://api.github.com/users/aikar/received_events","type":"User","site_admin":false},"repo":{"id":7627843,"name":"EMC-Bukkit","full_name":"aikar/EMC-Bukkit","owner":{"login":"aikar","id":58008,"avatar_url":"https://avatars.githubusercontent.com/u/58008?v=1","gravatar_id":"c6abf37c059c2eb548319c49bf5125ea","url":"https://api.github.com/users/aikar","html_url":"https://github.com/aikar","followers_url":"https://api.github.com/users/aikar/followers","following_url":"https://api.github.com/users/aikar/following{/other_user}","gists_url":"https://api.github.com/users/aikar/gists{/gist_id}","starred_url":"https://api.github.com/users/aikar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aikar/subscriptions","organizations_url":"https://api.github.com/users/aikar/orgs","repos_url":"https://api.github.com/users/aikar/repos","events_url":"https://api.github.com/users/aikar/events{/privacy}","received_events_url":"https://api.github.com/users/aikar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aikar/EMC-Bukkit","description":"Empire Minecrafts Bukkit Fork.","fork":true,"url":"https://api.github.com/repos/aikar/EMC-Bukkit","forks_url":"https://api.github.com/repos/aikar/EMC-Bukkit/forks","keys_url":"https://api.github.com/repos/aikar/EMC-Bukkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aikar/EMC-Bukkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aikar/EMC-Bukkit/teams","hooks_url":"https://api.github.com/repos/aikar/EMC-Bukkit/hooks","issue_events_url":"https://api.github.com/repos/aikar/EMC-Bukkit/issues/events{/number}","events_url":"https://api.github.com/repos/aikar/EMC-Bukkit/events","assignees_url":"https://api.github.com/repos/aikar/EMC-Bukkit/assignees{/user}","branches_url":"https://api.github.com/repos/aikar/EMC-Bukkit/branches{/branch}","tags_url":"https://api.github.com/repos/aikar/EMC-Bukkit/tags","blobs_url":"https://api.github.com/repos/aikar/EMC-Bukkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aikar/EMC-Bukkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aikar/EMC-Bukkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/aikar/EMC-Bukkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aikar/EMC-Bukkit/statuses/{sha}","languages_url":"https://api.github.com/repos/aikar/EMC-Bukkit/languages","stargazers_url":"https://api.github.com/repos/aikar/EMC-Bukkit/stargazers","contributors_url":"https://api.github.com/repos/aikar/EMC-Bukkit/contributors","subscribers_url":"https://api.github.com/repos/aikar/EMC-Bukkit/subscribers","subscription_url":"https://api.github.com/repos/aikar/EMC-Bukkit/subscription","commits_url":"https://api.github.com/repos/aikar/EMC-Bukkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/aikar/EMC-Bukkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/aikar/EMC-Bukkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/aikar/EMC-Bukkit/issues/comments/{number}","contents_url":"https://api.github.com/repos/aikar/EMC-Bukkit/contents/{+path}","compare_url":"https://api.github.com/repos/aikar/EMC-Bukkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aikar/EMC-Bukkit/merges","archive_url":"https://api.github.com/repos/aikar/EMC-Bukkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aikar/EMC-Bukkit/downloads","issues_url":"https://api.github.com/repos/aikar/EMC-Bukkit/issues{/number}","pulls_url":"https://api.github.com/repos/aikar/EMC-Bukkit/pulls{/number}","milestones_url":"https://api.github.com/repos/aikar/EMC-Bukkit/milestones{/number}","notifications_url":"https://api.github.com/repos/aikar/EMC-Bukkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aikar/EMC-Bukkit/labels{/name}","releases_url":"https://api.github.com/repos/aikar/EMC-Bukkit/releases{/id}","created_at":"2013-01-15T15:53:25Z","updated_at":"2014-03-12T03:46:41Z","pushed_at":"2014-03-12T03:46:41Z","git_url":"git://github.com/aikar/EMC-Bukkit.git","ssh_url":"git@github.com:aikar/EMC-Bukkit.git","clone_url":"https://github.com/aikar/EMC-Bukkit.git","svn_url":"https://github.com/aikar/EMC-Bukkit","homepage":"http://aikar.emcurl.com/?gas=github","size":2819,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"Bukkit:master","ref":"master","sha":"ccc56c8f7ed6d0b8ce097193090e1f470a2a0f25","user":{"login":"Bukkit","id":544609,"avatar_url":"https://avatars.githubusercontent.com/u/544609?v=1","gravatar_id":"cafe4b8d296dd981f519b7789b9159de","url":"https://api.github.com/users/Bukkit","html_url":"https://github.com/Bukkit","followers_url":"https://api.github.com/users/Bukkit/followers","following_url":"https://api.github.com/users/Bukkit/following{/other_user}","gists_url":"https://api.github.com/users/Bukkit/gists{/gist_id}","starred_url":"https://api.github.com/users/Bukkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bukkit/subscriptions","organizations_url":"https://api.github.com/users/Bukkit/orgs","repos_url":"https://api.github.com/users/Bukkit/repos","events_url":"https://api.github.com/users/Bukkit/events{/privacy}","received_events_url":"https://api.github.com/users/Bukkit/received_events","type":"Organization","site_admin":false},"repo":{"id":1215215,"name":"Bukkit","full_name":"Bukkit/Bukkit","owner":{"login":"Bukkit","id":544609,"avatar_url":"https://avatars.githubusercontent.com/u/544609?v=1","gravatar_id":"cafe4b8d296dd981f519b7789b9159de","url":"https://api.github.com/users/Bukkit","html_url":"https://github.com/Bukkit","followers_url":"https://api.github.com/users/Bukkit/followers","following_url":"https://api.github.com/users/Bukkit/following{/other_user}","gists_url":"https://api.github.com/users/Bukkit/gists{/gist_id}","starred_url":"https://api.github.com/users/Bukkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bukkit/subscriptions","organizations_url":"https://api.github.com/users/Bukkit/orgs","repos_url":"https://api.github.com/users/Bukkit/repos","events_url":"https://api.github.com/users/Bukkit/events{/privacy}","received_events_url":"https://api.github.com/users/Bukkit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Bukkit/Bukkit","description":"The Minecraft Mod API","fork":false,"url":"https://api.github.com/repos/Bukkit/Bukkit","forks_url":"https://api.github.com/repos/Bukkit/Bukkit/forks","keys_url":"https://api.github.com/repos/Bukkit/Bukkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Bukkit/Bukkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Bukkit/Bukkit/teams","hooks_url":"https://api.github.com/repos/Bukkit/Bukkit/hooks","issue_events_url":"https://api.github.com/repos/Bukkit/Bukkit/issues/events{/number}","events_url":"https://api.github.com/repos/Bukkit/Bukkit/events","assignees_url":"https://api.github.com/repos/Bukkit/Bukkit/assignees{/user}","branches_url":"https://api.github.com/repos/Bukkit/Bukkit/branches{/branch}","tags_url":"https://api.github.com/repos/Bukkit/Bukkit/tags","blobs_url":"https://api.github.com/repos/Bukkit/Bukkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Bukkit/Bukkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Bukkit/Bukkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/Bukkit/Bukkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Bukkit/Bukkit/statuses/{sha}","languages_url":"https://api.github.com/repos/Bukkit/Bukkit/languages","stargazers_url":"https://api.github.com/repos/Bukkit/Bukkit/stargazers","contributors_url":"https://api.github.com/repos/Bukkit/Bukkit/contributors","subscribers_url":"https://api.github.com/repos/Bukkit/Bukkit/subscribers","subscription_url":"https://api.github.com/repos/Bukkit/Bukkit/subscription","commits_url":"https://api.github.com/repos/Bukkit/Bukkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/Bukkit/Bukkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/Bukkit/Bukkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/Bukkit/Bukkit/issues/comments/{number}","contents_url":"https://api.github.com/repos/Bukkit/Bukkit/contents/{+path}","compare_url":"https://api.github.com/repos/Bukkit/Bukkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Bukkit/Bukkit/merges","archive_url":"https://api.github.com/repos/Bukkit/Bukkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Bukkit/Bukkit/downloads","issues_url":"https://api.github.com/repos/Bukkit/Bukkit/issues{/number}","pulls_url":"https://api.github.com/repos/Bukkit/Bukkit/pulls{/number}","milestones_url":"https://api.github.com/repos/Bukkit/Bukkit/milestones{/number}","notifications_url":"https://api.github.com/repos/Bukkit/Bukkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Bukkit/Bukkit/labels{/name}","releases_url":"https://api.github.com/repos/Bukkit/Bukkit/releases{/id}","created_at":"2011-01-02T23:47:25Z","updated_at":"2014-08-02T04:17:50Z","pushed_at":"2014-07-10T00:01:09Z","git_url":"git://github.com/Bukkit/Bukkit.git","ssh_url":"git@github.com:Bukkit/Bukkit.git","clone_url":"https://github.com/Bukkit/Bukkit.git","svn_url":"https://github.com/Bukkit/Bukkit","homepage":"http://bukkit.org","size":19691,"stargazers_count":1520,"watchers_count":1520,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":971,"mirror_url":null,"open_issues_count":77,"forks":971,"open_issues":77,"watchers":1520,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Bukkit/Bukkit/pulls/896"},"html":{"href":"https://github.com/Bukkit/Bukkit/pull/896"},"issue":{"href":"https://api.github.com/repos/Bukkit/Bukkit/issues/896"},"comments":{"href":"https://api.github.com/repos/Bukkit/Bukkit/issues/896/comments"},"review_comments":{"href":"https://api.github.com/repos/Bukkit/Bukkit/pulls/896/comments"},"review_comment":{"href":"https://api.github.com/repos/Bukkit/Bukkit/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Bukkit/Bukkit/pulls/896/commits"},"statuses":{"href":"https://api.github.com/repos/Bukkit/Bukkit/statuses/a5f2aff6217b4320fa6d7928674c31a205b4ed0e"}}}}