GitHub PullRequestReviewCommentEvent at 2014-03-03 04:54:20
Repository: crosswalk
Actor: wang16
Payload: {"comment":{"url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/comments/10200802","id":10200802,"diff_hunk":"@@ -143,9 +143,9 @@ public void updateNotificationIcon(int notificationId, Bitmap icon) {\n             }\n             builder.setLargeIcon(\n                     Bitmap.createScaledBitmap(icon, targetWidth, targetHeight, true));\n-            Notification notification = builder.getNotification();\n+            Notification notification = builder.build();","path":"runtime/android/java/src/org/xwalk/core/client/XWalkDefaultNotificationService.java","position":5,"original_position":5,"commit_id":"a7545525aaf387a06b4b48bba65426c2b2cd2417","original_commit_id":"a7545525aaf387a06b4b48bba65426c2b2cd2417","user":{"login":"wang16","id":1150478,"avatar_url":"https://avatars.githubusercontent.com/u/1150478","gravatar_id":"4ab8cb99a5f29451d7ef06d59380ecbb","url":"https://api.github.com/users/wang16","html_url":"https://github.com/wang16","followers_url":"https://api.github.com/users/wang16/followers","following_url":"https://api.github.com/users/wang16/following{/other_user}","gists_url":"https://api.github.com/users/wang16/gists{/gist_id}","starred_url":"https://api.github.com/users/wang16/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wang16/subscriptions","organizations_url":"https://api.github.com/users/wang16/orgs","repos_url":"https://api.github.com/users/wang16/repos","events_url":"https://api.github.com/users/wang16/events{/privacy}","received_events_url":"https://api.github.com/users/wang16/received_events","type":"User","site_admin":false},"body":"Notification.Builder.build() is introduced in API lvl 16, which is 4.1, http://developer.android.com/reference/android/app/Notification.Builder.html#build().\r\nWe need to support 4.0, so I suppose we need to change this back. @ShDavidliu @yongsheng ","created_at":"2014-03-03T04:54:20Z","updated_at":"2014-03-03T04:54:20Z","html_url":"https://github.com/crosswalk-project/crosswalk/pull/1648#discussion_r10200802","pull_request_url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/1648","_links":{"self":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/comments/10200802"},"html":{"href":"https://github.com/crosswalk-project/crosswalk/pull/1648#discussion_r10200802"},"pull_request":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/1648"}}}}