GitHub PullRequestReviewCommentEvent at 2014-09-14 12:31:01
Repository: libreset
Actor: matthiasbeyer
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/matthiasbeyer/libreset/pulls/comments/17519196","id":17519196,"diff_hunk":"@@ -0,0 +1,15 @@\n+#include \"ht.h\"\n+#include \"util/macros.h\"\n+\n+struct ht_bucket*\n+ht_find(\n+    struct ht* ht,\n+    rs_hash hash\n+) {\n+    if (!ht) {\n+        return NULL;\n+    }\n+\n+    return &ht->buckets[hash % (CONSTPOW_TWO(BITCOUNT(hash)) / ht->nbuckets)];","path":"src/libreset/ht.c","position":22,"original_position":13,"commit_id":"824892929dc1dd27ca6be0c2cbf1cfbc159e68a6","original_commit_id":"99e3aa0bf516fad8880973a66267cfda98fb99d0","user":{"login":"matthiasbeyer","id":427866,"avatar_url":"https://avatars.githubusercontent.com/u/427866?v=2","gravatar_id":"f98e6ad8c8b579b09886981b1e402c15","url":"https://api.github.com/users/matthiasbeyer","html_url":"https://github.com/matthiasbeyer","followers_url":"https://api.github.com/users/matthiasbeyer/followers","following_url":"https://api.github.com/users/matthiasbeyer/following{/other_user}","gists_url":"https://api.github.com/users/matthiasbeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/matthiasbeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthiasbeyer/subscriptions","organizations_url":"https://api.github.com/users/matthiasbeyer/orgs","repos_url":"https://api.github.com/users/matthiasbeyer/repos","events_url":"https://api.github.com/users/matthiasbeyer/events{/privacy}","received_events_url":"https://api.github.com/users/matthiasbeyer/received_events","type":"User","site_admin":false},"body":"OMFG. This was a reading error. The character for division is the same as for modulo, in some way.\r\n\r\nWe should definitely fix this in the paper and use a colon there!","created_at":"2014-09-14T12:31:01Z","updated_at":"2014-09-14T12:31:01Z","html_url":"https://github.com/matthiasbeyer/libreset/pull/82#discussion_r17519196","pull_request_url":"https://api.github.com/repos/matthiasbeyer/libreset/pulls/82","_links":{"self":{"href":"https://api.github.com/repos/matthiasbeyer/libreset/pulls/comments/17519196"},"html":{"href":"https://github.com/matthiasbeyer/libreset/pull/82#discussion_r17519196"},"pull_request":{"href":"https://api.github.com/repos/matthiasbeyer/libreset/pulls/82"}}},"pull_request":{"url":"https://api.github.com/repos/matthiasbeyer/libreset/pulls/82","id":21195047,"html_url":"https://github.com/matthiasbeyer/libreset/pull/82","diff_url":"https://github.com/matthiasbeyer/libreset/pull/82.diff","patch_url":"https://github.com/matthiasbeyer/libreset/pull/82.patch","issue_url":"https://api.github.com/repos/matthiasbeyer/libreset/issues/82","number":82,"state":"open","locked":false,"title":"Implement ht find","user":{"login":"matthiasbeyer","id":427866,"avatar_url":"https://avatars.githubusercontent.com/u/427866?v=2","gravatar_id":"f98e6ad8c8b579b09886981b1e402c15","url":"https://api.github.com/users/matthiasbeyer","html_url":"https://github.com/matthiasbeyer","followers_url":"https://api.github.com/users/matthiasbeyer/followers","following_url":"https://api.github.com/users/matthiasbeyer/following{/other_user}","gists_url":"https://api.github.com/users/matthiasbeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/matthiasbeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthiasbeyer/subscriptions","organizations_url":"https://api.github.com/users/matthiasbeyer/orgs","repos_url":"https://api.github.com/users/matthiasbeyer/repos","events_url":"https://api.github.com/users/matthiasbeyer/events{/privacy}","received_events_url":"https://api.github.com/users/matthiasbeyer/received_events","type":"User","site_admin":false},"body":"Solves #61 \r\n\r\nNote: I assume `s` from the paper being the size (number of buckets) of the hashtable.","created_at":"2014-09-13T17:08:39Z","updated_at":"2014-09-14T12:31:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"77210856d2d9d5b726f96bd887366d80f4401d74","assignee":null,"milestone":{"url":"https://api.github.com/repos/matthiasbeyer/libreset/milestones/3","labels_url":"https://api.github.com/repos/matthiasbeyer/libreset/milestones/3/labels","id":779819,"number":3,"title":"v0.0.0-internals","description":"On this milestone, the implementation of the library covers all internal aspects. These are:\r\n\r\n- An internal library for Linked Lists\r\n- An internal library for AVL Trees\r\n- An internal library for Hashtables\r\n\r\nThe implementations of these aspects (or sub-libraries) are by then thread safe, documented and ready for production usage on their own.\r\n\r\nThe implementation of the set capabilities of the library is not included in this milestone.","creator":{"login":"matthiasbeyer","id":427866,"avatar_url":"https://avatars.githubusercontent.com/u/427866?v=2","gravatar_id":"f98e6ad8c8b579b09886981b1e402c15","url":"https://api.github.com/users/matthiasbeyer","html_url":"https://github.com/matthiasbeyer","followers_url":"https://api.github.com/users/matthiasbeyer/followers","following_url":"https://api.github.com/users/matthiasbeyer/following{/other_user}","gists_url":"https://api.github.com/users/matthiasbeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/matthiasbeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthiasbeyer/subscriptions","organizations_url":"https://api.github.com/users/matthiasbeyer/orgs","repos_url":"https://api.github.com/users/matthiasbeyer/repos","events_url":"https://api.github.com/users/matthiasbeyer/events{/privacy}","received_events_url":"https://api.github.com/users/matthiasbeyer/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":17,"state":"open","created_at":"2014-09-05T14:18:03Z","updated_at":"2014-09-14T11:29:34Z","due_on":"2014-09-23T07:00:00Z"},"commits_url":"https://api.github.com/repos/matthiasbeyer/libreset/pulls/82/commits","review_comments_url":"https://api.github.com/repos/matthiasbeyer/libreset/pulls/82/comments","review_comment_url":"https://api.github.com/repos/matthiasbeyer/libreset/pulls/comments/{number}","comments_url":"https://api.github.com/repos/matthiasbeyer/libreset/issues/82/comments","statuses_url":"https://api.github.com/repos/matthiasbeyer/libreset/statuses/824892929dc1dd27ca6be0c2cbf1cfbc159e68a6","head":{"label":"matthiasbeyer:implement-ht_find","ref":"implement-ht_find","sha":"824892929dc1dd27ca6be0c2cbf1cfbc159e68a6","user":{"login":"matthiasbeyer","id":427866,"avatar_url":"https://avatars.githubusercontent.com/u/427866?v=2","gravatar_id":"f98e6ad8c8b579b09886981b1e402c15","url":"https://api.github.com/users/matthiasbeyer","html_url":"https://github.com/matthiasbeyer","followers_url":"https://api.github.com/users/matthiasbeyer/followers","following_url":"https://api.github.com/users/matthiasbeyer/following{/other_user}","gists_url":"https://api.github.com/users/matthiasbeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/matthiasbeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthiasbeyer/subscriptions","organizations_url":"https://api.github.com/users/matthiasbeyer/orgs","repos_url":"https://api.github.com/users/matthiasbeyer/repos","events_url":"https://api.github.com/users/matthiasbeyer/events{/privacy}","received_events_url":"https://api.github.com/users/matthiasbeyer/received_events","type":"User","site_admin":false},"repo":{"id":20565980,"name":"libreset","full_name":"matthiasbeyer/libreset","owner":{"login":"matthiasbeyer","id":427866,"avatar_url":"https://avatars.githubusercontent.com/u/427866?v=2","gravatar_id":"f98e6ad8c8b579b09886981b1e402c15","url":"https://api.github.com/users/matthiasbeyer","html_url":"https://github.com/matthiasbeyer","followers_url":"https://api.github.com/users/matthiasbeyer/followers","following_url":"https://api.github.com/users/matthiasbeyer/following{/other_user}","gists_url":"https://api.github.com/users/matthiasbeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/matthiasbeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthiasbeyer/subscriptions","organizations_url":"https://api.github.com/users/matthiasbeyer/orgs","repos_url":"https://api.github.com/users/matthiasbeyer/repos","events_url":"https://api.github.com/users/matthiasbeyer/events{/privacy}","received_events_url":"https://api.github.com/users/matthiasbeyer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matthiasbeyer/libreset","description":"Reentrant set lib based on threadsafe hashtable","fork":false,"url":"https://api.github.com/repos/matthiasbeyer/libreset","forks_url":"https://api.github.com/repos/matthiasbeyer/libreset/forks","keys_url":"https://api.github.com/repos/matthiasbeyer/libreset/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matthiasbeyer/libreset/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matthiasbeyer/libreset/teams","hooks_url":"https://api.github.com/repos/matthiasbeyer/libreset/hooks","issue_events_url":"https://api.github.com/repos/matthiasbeyer/libreset/issues/events{/number}","events_url":"https://api.github.com/repos/matthiasbeyer/libreset/events","assignees_url":"https://api.github.com/repos/matthiasbeyer/libreset/assignees{/user}","branches_url":"https://api.github.com/repos/matthiasbeyer/libreset/branches{/branch}","tags_url":"https://api.github.com/repos/matthiasbeyer/libreset/tags","blobs_url":"https://api.github.com/repos/matthiasbeyer/libreset/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matthiasbeyer/libreset/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matthiasbeyer/libreset/git/refs{/sha}","trees_url":"https://api.github.com/repos/matthiasbeyer/libreset/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matthiasbeyer/libreset/statuses/{sha}","languages_url":"https://api.github.com/repos/matthiasbeyer/libreset/languages","stargazers_url":"https://api.github.com/repos/matthiasbeyer/libreset/stargazers","contributors_url":"https://api.github.com/repos/matthiasbeyer/libreset/contributors","subscribers_url":"https://api.github.com/repos/matthiasbeyer/libreset/subscribers","subscription_url":"https://api.github.com/repos/matthiasbeyer/libreset/subscription","commits_url":"https://api.github.com/repos/matthiasbeyer/libreset/commits{/sha}","git_commits_url":"https://api.github.com/repos/matthiasbeyer/libreset/git/commits{/sha}","comments_url":"https://api.github.com/repos/matthiasbeyer/libreset/comments{/number}","issue_comment_url":"https://api.github.com/repos/matthiasbeyer/libreset/issues/comments/{number}","contents_url":"https://api.github.com/repos/matthiasbeyer/libreset/contents/{+path}","compare_url":"https://api.github.com/repos/matthiasbeyer/libreset/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matthiasbeyer/libreset/merges","archive_url":"https://api.github.com/repos/matthiasbeyer/libreset/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matthiasbeyer/libreset/downloads","issues_url":"https://api.github.com/repos/matthiasbeyer/libreset/issues{/number}","pulls_url":"https://api.github.com/repos/matthiasbeyer/libreset/pulls{/number}","milestones_url":"https://api.github.com/repos/matthiasbeyer/libreset/milestones{/number}","notifications_url":"https://api.github.com/repos/matthiasbeyer/libreset/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matthiasbeyer/libreset/labels{/name}","releases_url":"https://api.github.com/repos/matthiasbeyer/libreset/releases{/id}","created_at":"2014-06-06T14:08:42Z","updated_at":"2014-09-13T15:16:58Z","pushed_at":"2014-09-14T09:43:49Z","git_url":"git://github.com/matthiasbeyer/libreset.git","ssh_url":"git@github.com:matthiasbeyer/libreset.git","clone_url":"https://github.com/matthiasbeyer/libreset.git","svn_url":"https://github.com/matthiasbeyer/libreset","homepage":null,"size":2119,"stargazers_count":1,"watchers_count":1,"language":"TeX","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":3,"mirror_url":null,"open_issues_count":17,"forks":3,"open_issues":17,"watchers":1,"default_branch":"master"}},"base":{"label":"matthiasbeyer:master","ref":"master","sha":"dba01897eb2c04b4bf58f793f67b2aef8eb7f5f7","user":{"login":"matthiasbeyer","id":427866,"avatar_url":"https://avatars.githubusercontent.com/u/427866?v=2","gravatar_id":"f98e6ad8c8b579b09886981b1e402c15","url":"https://api.github.com/users/matthiasbeyer","html_url":"https://github.com/matthiasbeyer","followers_url":"https://api.github.com/users/matthiasbeyer/followers","following_url":"https://api.github.com/users/matthiasbeyer/following{/other_user}","gists_url":"https://api.github.com/users/matthiasbeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/matthiasbeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthiasbeyer/subscriptions","organizations_url":"https://api.github.com/users/matthiasbeyer/orgs","repos_url":"https://api.github.com/users/matthiasbeyer/repos","events_url":"https://api.github.com/users/matthiasbeyer/events{/privacy}","received_events_url":"https://api.github.com/users/matthiasbeyer/received_events","type":"User","site_admin":false},"repo":{"id":20565980,"name":"libreset","full_name":"matthiasbeyer/libreset","owner":{"login":"matthiasbeyer","id":427866,"avatar_url":"https://avatars.githubusercontent.com/u/427866?v=2","gravatar_id":"f98e6ad8c8b579b09886981b1e402c15","url":"https://api.github.com/users/matthiasbeyer","html_url":"https://github.com/matthiasbeyer","followers_url":"https://api.github.com/users/matthiasbeyer/followers","following_url":"https://api.github.com/users/matthiasbeyer/following{/other_user}","gists_url":"https://api.github.com/users/matthiasbeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/matthiasbeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthiasbeyer/subscriptions","organizations_url":"https://api.github.com/users/matthiasbeyer/orgs","repos_url":"https://api.github.com/users/matthiasbeyer/repos","events_url":"https://api.github.com/users/matthiasbeyer/events{/privacy}","received_events_url":"https://api.github.com/users/matthiasbeyer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matthiasbeyer/libreset","description":"Reentrant set lib based on threadsafe hashtable","fork":false,"url":"https://api.github.com/repos/matthiasbeyer/libreset","forks_url":"https://api.github.com/repos/matthiasbeyer/libreset/forks","keys_url":"https://api.github.com/repos/matthiasbeyer/libreset/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matthiasbeyer/libreset/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matthiasbeyer/libreset/teams","hooks_url":"https://api.github.com/repos/matthiasbeyer/libreset/hooks","issue_events_url":"https://api.github.com/repos/matthiasbeyer/libreset/issues/events{/number}","events_url":"https://api.github.com/repos/matthiasbeyer/libreset/events","assignees_url":"https://api.github.com/repos/matthiasbeyer/libreset/assignees{/user}","branches_url":"https://api.github.com/repos/matthiasbeyer/libreset/branches{/branch}","tags_url":"https://api.github.com/repos/matthiasbeyer/libreset/tags","blobs_url":"https://api.github.com/repos/matthiasbeyer/libreset/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matthiasbeyer/libreset/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matthiasbeyer/libreset/git/refs{/sha}","trees_url":"https://api.github.com/repos/matthiasbeyer/libreset/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matthiasbeyer/libreset/statuses/{sha}","languages_url":"https://api.github.com/repos/matthiasbeyer/libreset/languages","stargazers_url":"https://api.github.com/repos/matthiasbeyer/libreset/stargazers","contributors_url":"https://api.github.com/repos/matthiasbeyer/libreset/contributors","subscribers_url":"https://api.github.com/repos/matthiasbeyer/libreset/subscribers","subscription_url":"https://api.github.com/repos/matthiasbeyer/libreset/subscription","commits_url":"https://api.github.com/repos/matthiasbeyer/libreset/commits{/sha}","git_commits_url":"https://api.github.com/repos/matthiasbeyer/libreset/git/commits{/sha}","comments_url":"https://api.github.com/repos/matthiasbeyer/libreset/comments{/number}","issue_comment_url":"https://api.github.com/repos/matthiasbeyer/libreset/issues/comments/{number}","contents_url":"https://api.github.com/repos/matthiasbeyer/libreset/contents/{+path}","compare_url":"https://api.github.com/repos/matthiasbeyer/libreset/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matthiasbeyer/libreset/merges","archive_url":"https://api.github.com/repos/matthiasbeyer/libreset/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matthiasbeyer/libreset/downloads","issues_url":"https://api.github.com/repos/matthiasbeyer/libreset/issues{/number}","pulls_url":"https://api.github.com/repos/matthiasbeyer/libreset/pulls{/number}","milestones_url":"https://api.github.com/repos/matthiasbeyer/libreset/milestones{/number}","notifications_url":"https://api.github.com/repos/matthiasbeyer/libreset/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matthiasbeyer/libreset/labels{/name}","releases_url":"https://api.github.com/repos/matthiasbeyer/libreset/releases{/id}","created_at":"2014-06-06T14:08:42Z","updated_at":"2014-09-13T15:16:58Z","pushed_at":"2014-09-14T09:43:49Z","git_url":"git://github.com/matthiasbeyer/libreset.git","ssh_url":"git@github.com:matthiasbeyer/libreset.git","clone_url":"https://github.com/matthiasbeyer/libreset.git","svn_url":"https://github.com/matthiasbeyer/libreset","homepage":null,"size":2119,"stargazers_count":1,"watchers_count":1,"language":"TeX","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":3,"mirror_url":null,"open_issues_count":17,"forks":3,"open_issues":17,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/matthiasbeyer/libreset/pulls/82"},"html":{"href":"https://github.com/matthiasbeyer/libreset/pull/82"},"issue":{"href":"https://api.github.com/repos/matthiasbeyer/libreset/issues/82"},"comments":{"href":"https://api.github.com/repos/matthiasbeyer/libreset/issues/82/comments"},"review_comments":{"href":"https://api.github.com/repos/matthiasbeyer/libreset/pulls/82/comments"},"review_comment":{"href":"https://api.github.com/repos/matthiasbeyer/libreset/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/matthiasbeyer/libreset/pulls/82/commits"},"statuses":{"href":"https://api.github.com/repos/matthiasbeyer/libreset/statuses/824892929dc1dd27ca6be0c2cbf1cfbc159e68a6"}}}}