GitHub PullRequestEvent at 2014-01-07 17:49:40
Repository: habitrpg
Actor: lefnire
Payload: {"action":"closed","number":2288,"pull_request":{"url":"https://api.github.com/repos/HabitRPG/habitrpg/pulls/2288","id":11285624,"html_url":"https://github.com/HabitRPG/habitrpg/pull/2288","diff_url":"https://github.com/HabitRPG/habitrpg/pull/2288.diff","patch_url":"https://github.com/HabitRPG/habitrpg/pull/2288.patch","issue_url":"https://github.com/HabitRPG/habitrpg/pull/2288","number":2288,"state":"closed","title":"Client side of Rebirth-related fix: don't remove Wolf Eggs upon unlock","user":{"login":"SabreCat","id":4501321,"avatar_url":"https://gravatar.com/avatar/7d9085d63e2cfc2bfc42489fd7d02652?d=https%3A%2F%2Fidenticons.github.com%2Fce2e433d40bcaf25288ddf6128ebc136.png&r=x","gravatar_id":"7d9085d63e2cfc2bfc42489fd7d02652","url":"https://api.github.com/users/SabreCat","html_url":"https://github.com/SabreCat","followers_url":"https://api.github.com/users/SabreCat/followers","following_url":"https://api.github.com/users/SabreCat/following{/other_user}","gists_url":"https://api.github.com/users/SabreCat/gists{/gist_id}","starred_url":"https://api.github.com/users/SabreCat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SabreCat/subscriptions","organizations_url":"https://api.github.com/users/SabreCat/orgs","repos_url":"https://api.github.com/users/SabreCat/repos","events_url":"https://api.github.com/users/SabreCat/events{/privacy}","received_events_url":"https://api.github.com/users/SabreCat/received_events","type":"User","site_admin":false},"body":"Previously, if user had >1 Wolf Egg, performed a Rebirth, then unlocked drops again, they would be reset to 1 Wolf Egg. Now Habit checks to see if they have some Wolf Eggs already, and if so, gives them one instead of setting the quantity to one.\r\n\r\nServer op from the `$watch` happens first, so guideservices.js just skips if there are already eggs around. I tried doing a `eggs['Wolf']++` here as well, but that caused doubling-up (looked like the user received two eggs, until refresh). That may mean this bit isn't needed at all, in practice.","created_at":"2014-01-07T14:18:10Z","updated_at":"2014-01-07T17:49:40Z","closed_at":"2014-01-07T17:49:40Z","merged_at":"2014-01-07T17:49:40Z","merge_commit_sha":"070a6ac93e87cb73d5949be6c724d305a9340822","assignee":null,"milestone":null,"commits_url":"https://github.com/HabitRPG/habitrpg/pull/2288/commits","review_comments_url":"https://github.com/HabitRPG/habitrpg/pull/2288/comments","review_comment_url":"/repos/HabitRPG/habitrpg/pulls/comments/{number}","comments_url":"https://api.github.com/repos/HabitRPG/habitrpg/issues/2288/comments","statuses_url":"https://api.github.com/repos/HabitRPG/habitrpg/statuses/bbbc9bfe5011fea3fcdcdd825b8231f9a4fc7920","head":{"label":"HabitRPG:sabe/fix","ref":"sabe/fix","sha":"bbbc9bfe5011fea3fcdcdd825b8231f9a4fc7920","user":{"login":"HabitRPG","id":3834775,"avatar_url":"https://gravatar.com/avatar/0f648e946d7886f5c9988ac2086ae74a?d=https%3A%2F%2Fidenticons.github.com%2Faeed44360751329feabd28fec9b8d7b5.png&r=x","gravatar_id":"0f648e946d7886f5c9988ac2086ae74a","url":"https://api.github.com/users/HabitRPG","html_url":"https://github.com/HabitRPG","followers_url":"https://api.github.com/users/HabitRPG/followers","following_url":"https://api.github.com/users/HabitRPG/following{/other_user}","gists_url":"https://api.github.com/users/HabitRPG/gists{/gist_id}","starred_url":"https://api.github.com/users/HabitRPG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HabitRPG/subscriptions","organizations_url":"https://api.github.com/users/HabitRPG/orgs","repos_url":"https://api.github.com/users/HabitRPG/repos","events_url":"https://api.github.com/users/HabitRPG/events{/privacy}","received_events_url":"https://api.github.com/users/HabitRPG/received_events","type":"Organization","site_admin":false},"repo":{"id":4578898,"name":"habitrpg","full_name":"HabitRPG/habitrpg","owner":{"login":"HabitRPG","id":3834775,"avatar_url":"https://gravatar.com/avatar/0f648e946d7886f5c9988ac2086ae74a?d=https%3A%2F%2Fidenticons.github.com%2Faeed44360751329feabd28fec9b8d7b5.png&r=x","gravatar_id":"0f648e946d7886f5c9988ac2086ae74a","url":"https://api.github.com/users/HabitRPG","html_url":"https://github.com/HabitRPG","followers_url":"https://api.github.com/users/HabitRPG/followers","following_url":"https://api.github.com/users/HabitRPG/following{/other_user}","gists_url":"https://api.github.com/users/HabitRPG/gists{/gist_id}","starred_url":"https://api.github.com/users/HabitRPG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HabitRPG/subscriptions","organizations_url":"https://api.github.com/users/HabitRPG/orgs","repos_url":"https://api.github.com/users/HabitRPG/repos","events_url":"https://api.github.com/users/HabitRPG/events{/privacy}","received_events_url":"https://api.github.com/users/HabitRPG/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HabitRPG/habitrpg","description":"A habit tracker app which treats your goals like a Role Playing Game.","fork":false,"url":"https://api.github.com/repos/HabitRPG/habitrpg","forks_url":"https://api.github.com/repos/HabitRPG/habitrpg/forks","keys_url":"https://api.github.com/repos/HabitRPG/habitrpg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HabitRPG/habitrpg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HabitRPG/habitrpg/teams","hooks_url":"https://api.github.com/repos/HabitRPG/habitrpg/hooks","issue_events_url":"https://api.github.com/repos/HabitRPG/habitrpg/issues/events{/number}","events_url":"https://api.github.com/repos/HabitRPG/habitrpg/events","assignees_url":"https://api.github.com/repos/HabitRPG/habitrpg/assignees{/user}","branches_url":"https://api.github.com/repos/HabitRPG/habitrpg/branches{/branch}","tags_url":"https://api.github.com/repos/HabitRPG/habitrpg/tags","blobs_url":"https://api.github.com/repos/HabitRPG/habitrpg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HabitRPG/habitrpg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HabitRPG/habitrpg/git/refs{/sha}","trees_url":"https://api.github.com/repos/HabitRPG/habitrpg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HabitRPG/habitrpg/statuses/{sha}","languages_url":"https://api.github.com/repos/HabitRPG/habitrpg/languages","stargazers_url":"https://api.github.com/repos/HabitRPG/habitrpg/stargazers","contributors_url":"https://api.github.com/repos/HabitRPG/habitrpg/contributors","subscribers_url":"https://api.github.com/repos/HabitRPG/habitrpg/subscribers","subscription_url":"https://api.github.com/repos/HabitRPG/habitrpg/subscription","commits_url":"https://api.github.com/repos/HabitRPG/habitrpg/commits{/sha}","git_commits_url":"https://api.github.com/repos/HabitRPG/habitrpg/git/commits{/sha}","comments_url":"https://api.github.com/repos/HabitRPG/habitrpg/comments{/number}","issue_comment_url":"https://api.github.com/repos/HabitRPG/habitrpg/issues/comments/{number}","contents_url":"https://api.github.com/repos/HabitRPG/habitrpg/contents/{+path}","compare_url":"https://api.github.com/repos/HabitRPG/habitrpg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HabitRPG/habitrpg/merges","archive_url":"https://api.github.com/repos/HabitRPG/habitrpg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HabitRPG/habitrpg/downloads","issues_url":"https://api.github.com/repos/HabitRPG/habitrpg/issues{/number}","pulls_url":"https://api.github.com/repos/HabitRPG/habitrpg/pulls{/number}","milestones_url":"https://api.github.com/repos/HabitRPG/habitrpg/milestones{/number}","notifications_url":"https://api.github.com/repos/HabitRPG/habitrpg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HabitRPG/habitrpg/labels{/name}","releases_url":"https://api.github.com/repos/HabitRPG/habitrpg/releases{/id}","created_at":"2012-06-06T22:49:48Z","updated_at":"2014-01-07T17:49:40Z","pushed_at":"2014-01-07T17:49:40Z","git_url":"git://github.com/HabitRPG/habitrpg.git","ssh_url":"git@github.com:HabitRPG/habitrpg.git","clone_url":"https://github.com/HabitRPG/habitrpg.git","svn_url":"https://github.com/HabitRPG/habitrpg","homepage":"habitrpg.com","size":28905,"stargazers_count":1236,"watchers_count":1236,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":388,"mirror_url":null,"open_issues_count":299,"forks":388,"open_issues":299,"watchers":1236,"default_branch":"develop","master_branch":"develop"}},"base":{"label":"HabitRPG:develop","ref":"develop","sha":"5becae6170afdfcb8f523c06ab9c86950d111313","user":{"login":"HabitRPG","id":3834775,"avatar_url":"https://gravatar.com/avatar/0f648e946d7886f5c9988ac2086ae74a?d=https%3A%2F%2Fidenticons.github.com%2Faeed44360751329feabd28fec9b8d7b5.png&r=x","gravatar_id":"0f648e946d7886f5c9988ac2086ae74a","url":"https://api.github.com/users/HabitRPG","html_url":"https://github.com/HabitRPG","followers_url":"https://api.github.com/users/HabitRPG/followers","following_url":"https://api.github.com/users/HabitRPG/following{/other_user}","gists_url":"https://api.github.com/users/HabitRPG/gists{/gist_id}","starred_url":"https://api.github.com/users/HabitRPG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HabitRPG/subscriptions","organizations_url":"https://api.github.com/users/HabitRPG/orgs","repos_url":"https://api.github.com/users/HabitRPG/repos","events_url":"https://api.github.com/users/HabitRPG/events{/privacy}","received_events_url":"https://api.github.com/users/HabitRPG/received_events","type":"Organization","site_admin":false},"repo":{"id":4578898,"name":"habitrpg","full_name":"HabitRPG/habitrpg","owner":{"login":"HabitRPG","id":3834775,"avatar_url":"https://gravatar.com/avatar/0f648e946d7886f5c9988ac2086ae74a?d=https%3A%2F%2Fidenticons.github.com%2Faeed44360751329feabd28fec9b8d7b5.png&r=x","gravatar_id":"0f648e946d7886f5c9988ac2086ae74a","url":"https://api.github.com/users/HabitRPG","html_url":"https://github.com/HabitRPG","followers_url":"https://api.github.com/users/HabitRPG/followers","following_url":"https://api.github.com/users/HabitRPG/following{/other_user}","gists_url":"https://api.github.com/users/HabitRPG/gists{/gist_id}","starred_url":"https://api.github.com/users/HabitRPG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HabitRPG/subscriptions","organizations_url":"https://api.github.com/users/HabitRPG/orgs","repos_url":"https://api.github.com/users/HabitRPG/repos","events_url":"https://api.github.com/users/HabitRPG/events{/privacy}","received_events_url":"https://api.github.com/users/HabitRPG/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HabitRPG/habitrpg","description":"A habit tracker app which treats your goals like a Role Playing Game.","fork":false,"url":"https://api.github.com/repos/HabitRPG/habitrpg","forks_url":"https://api.github.com/repos/HabitRPG/habitrpg/forks","keys_url":"https://api.github.com/repos/HabitRPG/habitrpg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HabitRPG/habitrpg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HabitRPG/habitrpg/teams","hooks_url":"https://api.github.com/repos/HabitRPG/habitrpg/hooks","issue_events_url":"https://api.github.com/repos/HabitRPG/habitrpg/issues/events{/number}","events_url":"https://api.github.com/repos/HabitRPG/habitrpg/events","assignees_url":"https://api.github.com/repos/HabitRPG/habitrpg/assignees{/user}","branches_url":"https://api.github.com/repos/HabitRPG/habitrpg/branches{/branch}","tags_url":"https://api.github.com/repos/HabitRPG/habitrpg/tags","blobs_url":"https://api.github.com/repos/HabitRPG/habitrpg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HabitRPG/habitrpg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HabitRPG/habitrpg/git/refs{/sha}","trees_url":"https://api.github.com/repos/HabitRPG/habitrpg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HabitRPG/habitrpg/statuses/{sha}","languages_url":"https://api.github.com/repos/HabitRPG/habitrpg/languages","stargazers_url":"https://api.github.com/repos/HabitRPG/habitrpg/stargazers","contributors_url":"https://api.github.com/repos/HabitRPG/habitrpg/contributors","subscribers_url":"https://api.github.com/repos/HabitRPG/habitrpg/subscribers","subscription_url":"https://api.github.com/repos/HabitRPG/habitrpg/subscription","commits_url":"https://api.github.com/repos/HabitRPG/habitrpg/commits{/sha}","git_commits_url":"https://api.github.com/repos/HabitRPG/habitrpg/git/commits{/sha}","comments_url":"https://api.github.com/repos/HabitRPG/habitrpg/comments{/number}","issue_comment_url":"https://api.github.com/repos/HabitRPG/habitrpg/issues/comments/{number}","contents_url":"https://api.github.com/repos/HabitRPG/habitrpg/contents/{+path}","compare_url":"https://api.github.com/repos/HabitRPG/habitrpg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HabitRPG/habitrpg/merges","archive_url":"https://api.github.com/repos/HabitRPG/habitrpg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HabitRPG/habitrpg/downloads","issues_url":"https://api.github.com/repos/HabitRPG/habitrpg/issues{/number}","pulls_url":"https://api.github.com/repos/HabitRPG/habitrpg/pulls{/number}","milestones_url":"https://api.github.com/repos/HabitRPG/habitrpg/milestones{/number}","notifications_url":"https://api.github.com/repos/HabitRPG/habitrpg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HabitRPG/habitrpg/labels{/name}","releases_url":"https://api.github.com/repos/HabitRPG/habitrpg/releases{/id}","created_at":"2012-06-06T22:49:48Z","updated_at":"2014-01-07T17:49:40Z","pushed_at":"2014-01-07T17:49:40Z","git_url":"git://github.com/HabitRPG/habitrpg.git","ssh_url":"git@github.com:HabitRPG/habitrpg.git","clone_url":"https://github.com/HabitRPG/habitrpg.git","svn_url":"https://github.com/HabitRPG/habitrpg","homepage":"habitrpg.com","size":28905,"stargazers_count":1236,"watchers_count":1236,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":388,"mirror_url":null,"open_issues_count":299,"forks":388,"open_issues":299,"watchers":1236,"default_branch":"develop","master_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/HabitRPG/habitrpg/pulls/2288"},"html":{"href":"https://github.com/HabitRPG/habitrpg/pull/2288"},"issue":{"href":"https://api.github.com/repos/HabitRPG/habitrpg/issues/2288"},"comments":{"href":"https://api.github.com/repos/HabitRPG/habitrpg/issues/2288/comments"},"review_comments":{"href":"https://api.github.com/repos/HabitRPG/habitrpg/pulls/2288/comments"},"statuses":{"href":"https://api.github.com/repos/HabitRPG/habitrpg/statuses/bbbc9bfe5011fea3fcdcdd825b8231f9a4fc7920"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"lefnire","id":195202,"avatar_url":"https://gravatar.com/avatar/ff2dd194f7faa850a0410f93735280b8?d=https%3A%2F%2Fidenticons.github.com%2F5ba1301fdce9736a01ee3cf02dc8a9e9.png&r=x","gravatar_id":"ff2dd194f7faa850a0410f93735280b8","url":"https://api.github.com/users/lefnire","html_url":"https://github.com/lefnire","followers_url":"https://api.github.com/users/lefnire/followers","following_url":"https://api.github.com/users/lefnire/following{/other_user}","gists_url":"https://api.github.com/users/lefnire/gists{/gist_id}","starred_url":"https://api.github.com/users/lefnire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lefnire/subscriptions","organizations_url":"https://api.github.com/users/lefnire/orgs","repos_url":"https://api.github.com/users/lefnire/repos","events_url":"https://api.github.com/users/lefnire/events{/privacy}","received_events_url":"https://api.github.com/users/lefnire/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":3,"deletions":1,"changed_files":1}}