GitHub PullRequestEvent at 2014-09-17 04:38:11
Repository: falltergeist
Actor: alexeevdv
Payload: {"action":"closed","number":82,"pull_request":{"url":"https://api.github.com/repos/alexeevdv/falltergeist/pulls/82","id":21343096,"html_url":"https://github.com/alexeevdv/falltergeist/pull/82","diff_url":"https://github.com/alexeevdv/falltergeist/pull/82.diff","patch_url":"https://github.com/alexeevdv/falltergeist/pull/82.patch","issue_url":"https://api.github.com/repos/alexeevdv/falltergeist/issues/82","number":82,"state":"closed","locked":false,"title":"Change API for `OpcodeHandler`","user":{"login":"smaximov","id":1370047,"avatar_url":"https://avatars.githubusercontent.com/u/1370047?v=2","gravatar_id":"4a1ba62971e109fc38bd3c7961d41d04","url":"https://api.github.com/users/smaximov","html_url":"https://github.com/smaximov","followers_url":"https://api.github.com/users/smaximov/followers","following_url":"https://api.github.com/users/smaximov/following{/other_user}","gists_url":"https://api.github.com/users/smaximov/gists{/gist_id}","starred_url":"https://api.github.com/users/smaximov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smaximov/subscriptions","organizations_url":"https://api.github.com/users/smaximov/orgs","repos_url":"https://api.github.com/users/smaximov/repos","events_url":"https://api.github.com/users/smaximov/events{/privacy}","received_events_url":"https://api.github.com/users/smaximov/received_events","type":"User","site_admin":false},"body":"Make `OpcodeHandler::run` call pure virtual method `OpcodeHandler::_run` (must be implemented in derived classes), so there is no need to invoke `OpcodeHandler::run` from instances of derived classes.\r\n\r\nIn short:\r\n\r\n1. derived handlers should implement `OpcodeHandler::_run` instead of `OpcodeHandler::run`;\r\n\r\n2. `OpcodeHandler::run` must not be invoked manually from derived classes anymore.\r\n\r\nSee [changed files](https://github.com/alexeevdv/falltergeist/pull/82/files) for more info.\r\n\r\nRelated to #77 ","created_at":"2014-09-17T03:28:52Z","updated_at":"2014-09-17T04:38:11Z","closed_at":"2014-09-17T04:38:11Z","merged_at":"2014-09-17T04:38:11Z","merge_commit_sha":"7a6dc1a0fecf1d27abfea96897ddba5d5d4249b9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alexeevdv/falltergeist/pulls/82/commits","review_comments_url":"https://api.github.com/repos/alexeevdv/falltergeist/pulls/82/comments","review_comment_url":"https://api.github.com/repos/alexeevdv/falltergeist/pulls/comments/{number}","comments_url":"https://api.github.com/repos/alexeevdv/falltergeist/issues/82/comments","statuses_url":"https://api.github.com/repos/alexeevdv/falltergeist/statuses/11214896d7c81d1dd7133c7acdc9b9a8b2ce8d31","head":{"label":"smaximov:propose-new-api-for-opcode-handler","ref":"propose-new-api-for-opcode-handler","sha":"11214896d7c81d1dd7133c7acdc9b9a8b2ce8d31","user":{"login":"smaximov","id":1370047,"avatar_url":"https://avatars.githubusercontent.com/u/1370047?v=2","gravatar_id":"4a1ba62971e109fc38bd3c7961d41d04","url":"https://api.github.com/users/smaximov","html_url":"https://github.com/smaximov","followers_url":"https://api.github.com/users/smaximov/followers","following_url":"https://api.github.com/users/smaximov/following{/other_user}","gists_url":"https://api.github.com/users/smaximov/gists{/gist_id}","starred_url":"https://api.github.com/users/smaximov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smaximov/subscriptions","organizations_url":"https://api.github.com/users/smaximov/orgs","repos_url":"https://api.github.com/users/smaximov/repos","events_url":"https://api.github.com/users/smaximov/events{/privacy}","received_events_url":"https://api.github.com/users/smaximov/received_events","type":"User","site_admin":false},"repo":{"id":24048539,"name":"falltergeist","full_name":"smaximov/falltergeist","owner":{"login":"smaximov","id":1370047,"avatar_url":"https://avatars.githubusercontent.com/u/1370047?v=2","gravatar_id":"4a1ba62971e109fc38bd3c7961d41d04","url":"https://api.github.com/users/smaximov","html_url":"https://github.com/smaximov","followers_url":"https://api.github.com/users/smaximov/followers","following_url":"https://api.github.com/users/smaximov/following{/other_user}","gists_url":"https://api.github.com/users/smaximov/gists{/gist_id}","starred_url":"https://api.github.com/users/smaximov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smaximov/subscriptions","organizations_url":"https://api.github.com/users/smaximov/orgs","repos_url":"https://api.github.com/users/smaximov/repos","events_url":"https://api.github.com/users/smaximov/events{/privacy}","received_events_url":"https://api.github.com/users/smaximov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/smaximov/falltergeist","description":"Opensource crossplatform Fallout 2™ game engine writen in C++ and SDL. Current version: 0.1.3","fork":true,"url":"https://api.github.com/repos/smaximov/falltergeist","forks_url":"https://api.github.com/repos/smaximov/falltergeist/forks","keys_url":"https://api.github.com/repos/smaximov/falltergeist/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smaximov/falltergeist/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smaximov/falltergeist/teams","hooks_url":"https://api.github.com/repos/smaximov/falltergeist/hooks","issue_events_url":"https://api.github.com/repos/smaximov/falltergeist/issues/events{/number}","events_url":"https://api.github.com/repos/smaximov/falltergeist/events","assignees_url":"https://api.github.com/repos/smaximov/falltergeist/assignees{/user}","branches_url":"https://api.github.com/repos/smaximov/falltergeist/branches{/branch}","tags_url":"https://api.github.com/repos/smaximov/falltergeist/tags","blobs_url":"https://api.github.com/repos/smaximov/falltergeist/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smaximov/falltergeist/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smaximov/falltergeist/git/refs{/sha}","trees_url":"https://api.github.com/repos/smaximov/falltergeist/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smaximov/falltergeist/statuses/{sha}","languages_url":"https://api.github.com/repos/smaximov/falltergeist/languages","stargazers_url":"https://api.github.com/repos/smaximov/falltergeist/stargazers","contributors_url":"https://api.github.com/repos/smaximov/falltergeist/contributors","subscribers_url":"https://api.github.com/repos/smaximov/falltergeist/subscribers","subscription_url":"https://api.github.com/repos/smaximov/falltergeist/subscription","commits_url":"https://api.github.com/repos/smaximov/falltergeist/commits{/sha}","git_commits_url":"https://api.github.com/repos/smaximov/falltergeist/git/commits{/sha}","comments_url":"https://api.github.com/repos/smaximov/falltergeist/comments{/number}","issue_comment_url":"https://api.github.com/repos/smaximov/falltergeist/issues/comments/{number}","contents_url":"https://api.github.com/repos/smaximov/falltergeist/contents/{+path}","compare_url":"https://api.github.com/repos/smaximov/falltergeist/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smaximov/falltergeist/merges","archive_url":"https://api.github.com/repos/smaximov/falltergeist/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smaximov/falltergeist/downloads","issues_url":"https://api.github.com/repos/smaximov/falltergeist/issues{/number}","pulls_url":"https://api.github.com/repos/smaximov/falltergeist/pulls{/number}","milestones_url":"https://api.github.com/repos/smaximov/falltergeist/milestones{/number}","notifications_url":"https://api.github.com/repos/smaximov/falltergeist/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smaximov/falltergeist/labels{/name}","releases_url":"https://api.github.com/repos/smaximov/falltergeist/releases{/id}","created_at":"2014-09-15T08:21:33Z","updated_at":"2014-09-15T10:25:34Z","pushed_at":"2014-09-17T03:19:26Z","git_url":"git://github.com/smaximov/falltergeist.git","ssh_url":"git@github.com:smaximov/falltergeist.git","clone_url":"https://github.com/smaximov/falltergeist.git","svn_url":"https://github.com/smaximov/falltergeist","homepage":"http://falltergeist.org/","size":1856,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"alexeevdv:master","ref":"master","sha":"9cd5fab424dae9d807fc02401c36b05ae8ba2621","user":{"login":"alexeevdv","id":597839,"avatar_url":"https://avatars.githubusercontent.com/u/597839?v=2","gravatar_id":"0612fec8402c4e01e414a4f4dbe1bb0d","url":"https://api.github.com/users/alexeevdv","html_url":"https://github.com/alexeevdv","followers_url":"https://api.github.com/users/alexeevdv/followers","following_url":"https://api.github.com/users/alexeevdv/following{/other_user}","gists_url":"https://api.github.com/users/alexeevdv/gists{/gist_id}","starred_url":"https://api.github.com/users/alexeevdv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexeevdv/subscriptions","organizations_url":"https://api.github.com/users/alexeevdv/orgs","repos_url":"https://api.github.com/users/alexeevdv/repos","events_url":"https://api.github.com/users/alexeevdv/events{/privacy}","received_events_url":"https://api.github.com/users/alexeevdv/received_events","type":"User","site_admin":false},"repo":{"id":6838493,"name":"falltergeist","full_name":"alexeevdv/falltergeist","owner":{"login":"alexeevdv","id":597839,"avatar_url":"https://avatars.githubusercontent.com/u/597839?v=2","gravatar_id":"0612fec8402c4e01e414a4f4dbe1bb0d","url":"https://api.github.com/users/alexeevdv","html_url":"https://github.com/alexeevdv","followers_url":"https://api.github.com/users/alexeevdv/followers","following_url":"https://api.github.com/users/alexeevdv/following{/other_user}","gists_url":"https://api.github.com/users/alexeevdv/gists{/gist_id}","starred_url":"https://api.github.com/users/alexeevdv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexeevdv/subscriptions","organizations_url":"https://api.github.com/users/alexeevdv/orgs","repos_url":"https://api.github.com/users/alexeevdv/repos","events_url":"https://api.github.com/users/alexeevdv/events{/privacy}","received_events_url":"https://api.github.com/users/alexeevdv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexeevdv/falltergeist","description":"Opensource crossplatform Fallout 2™ game engine writen in C++ and SDL. Current version: 0.1.3","fork":false,"url":"https://api.github.com/repos/alexeevdv/falltergeist","forks_url":"https://api.github.com/repos/alexeevdv/falltergeist/forks","keys_url":"https://api.github.com/repos/alexeevdv/falltergeist/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexeevdv/falltergeist/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexeevdv/falltergeist/teams","hooks_url":"https://api.github.com/repos/alexeevdv/falltergeist/hooks","issue_events_url":"https://api.github.com/repos/alexeevdv/falltergeist/issues/events{/number}","events_url":"https://api.github.com/repos/alexeevdv/falltergeist/events","assignees_url":"https://api.github.com/repos/alexeevdv/falltergeist/assignees{/user}","branches_url":"https://api.github.com/repos/alexeevdv/falltergeist/branches{/branch}","tags_url":"https://api.github.com/repos/alexeevdv/falltergeist/tags","blobs_url":"https://api.github.com/repos/alexeevdv/falltergeist/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexeevdv/falltergeist/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexeevdv/falltergeist/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexeevdv/falltergeist/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexeevdv/falltergeist/statuses/{sha}","languages_url":"https://api.github.com/repos/alexeevdv/falltergeist/languages","stargazers_url":"https://api.github.com/repos/alexeevdv/falltergeist/stargazers","contributors_url":"https://api.github.com/repos/alexeevdv/falltergeist/contributors","subscribers_url":"https://api.github.com/repos/alexeevdv/falltergeist/subscribers","subscription_url":"https://api.github.com/repos/alexeevdv/falltergeist/subscription","commits_url":"https://api.github.com/repos/alexeevdv/falltergeist/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexeevdv/falltergeist/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexeevdv/falltergeist/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexeevdv/falltergeist/issues/comments/{number}","contents_url":"https://api.github.com/repos/alexeevdv/falltergeist/contents/{+path}","compare_url":"https://api.github.com/repos/alexeevdv/falltergeist/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexeevdv/falltergeist/merges","archive_url":"https://api.github.com/repos/alexeevdv/falltergeist/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexeevdv/falltergeist/downloads","issues_url":"https://api.github.com/repos/alexeevdv/falltergeist/issues{/number}","pulls_url":"https://api.github.com/repos/alexeevdv/falltergeist/pulls{/number}","milestones_url":"https://api.github.com/repos/alexeevdv/falltergeist/milestones{/number}","notifications_url":"https://api.github.com/repos/alexeevdv/falltergeist/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexeevdv/falltergeist/labels{/name}","releases_url":"https://api.github.com/repos/alexeevdv/falltergeist/releases{/id}","created_at":"2012-11-24T10:08:12Z","updated_at":"2014-09-15T07:14:39Z","pushed_at":"2014-09-17T04:38:11Z","git_url":"git://github.com/alexeevdv/falltergeist.git","ssh_url":"git@github.com:alexeevdv/falltergeist.git","clone_url":"https://github.com/alexeevdv/falltergeist.git","svn_url":"https://github.com/alexeevdv/falltergeist","homepage":"http://falltergeist.org/","size":4093,"stargazers_count":16,"watchers_count":16,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":14,"forks":4,"open_issues":14,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alexeevdv/falltergeist/pulls/82"},"html":{"href":"https://github.com/alexeevdv/falltergeist/pull/82"},"issue":{"href":"https://api.github.com/repos/alexeevdv/falltergeist/issues/82"},"comments":{"href":"https://api.github.com/repos/alexeevdv/falltergeist/issues/82/comments"},"review_comments":{"href":"https://api.github.com/repos/alexeevdv/falltergeist/pulls/82/comments"},"review_comment":{"href":"https://api.github.com/repos/alexeevdv/falltergeist/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/alexeevdv/falltergeist/pulls/82/commits"},"statuses":{"href":"https://api.github.com/repos/alexeevdv/falltergeist/statuses/11214896d7c81d1dd7133c7acdc9b9a8b2ce8d31"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"alexeevdv","id":597839,"avatar_url":"https://avatars.githubusercontent.com/u/597839?v=2","gravatar_id":"0612fec8402c4e01e414a4f4dbe1bb0d","url":"https://api.github.com/users/alexeevdv","html_url":"https://github.com/alexeevdv","followers_url":"https://api.github.com/users/alexeevdv/followers","following_url":"https://api.github.com/users/alexeevdv/following{/other_user}","gists_url":"https://api.github.com/users/alexeevdv/gists{/gist_id}","starred_url":"https://api.github.com/users/alexeevdv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexeevdv/subscriptions","organizations_url":"https://api.github.com/users/alexeevdv/orgs","repos_url":"https://api.github.com/users/alexeevdv/repos","events_url":"https://api.github.com/users/alexeevdv/events{/privacy}","received_events_url":"https://api.github.com/users/alexeevdv/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":30,"deletions":37,"changed_files":20}}