GitHub PullRequestReviewCommentEvent at 2014-10-27 17:17:55
Repository: buddycloud-server-java
Actor: abmargb
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/buddycloud/buddycloud-server-java/pulls/comments/19420368","id":19420368,"diff_hunk":"@@ -44,20 +45,17 @@ public void process(IQ reqIQ) throws Exception {\n         requestIq = reqIQ;\n         result = IQ.createResultIQ(reqIQ);\n         Element elm = reqIQ.getChildElement();\n-        node = elm.attributeValue(\"node\");\n-        query = result.setChildElement(ELEMENT_NAME,\n-                JabberDiscoInfo.NAMESPACE_URI);\n+        node = elm.attributeValue(XMLConstants.NODE_ATTR);\n+        query = result.setChildElement(ELEMENT_NAME, JabberDiscoInfo.NAMESPACE_URI);\n         if (false == Configuration.getInstance().isLocalJID(requestIq.getFrom())) {\n-            result.getElement().addAttribute(\"remote-server-discover\", \"false\");\n+            result.getElement().addAttribute(XMLConstants.REMOTE_SERVER_DISCOVER_ATTR, Boolean.FALSE.toString());\n         }\n-        if ((node == null) || (true == node.equals(\"\"))) {\n+        if ((node == null) || (\"\".equals(node))) {","path":"src/main/java/org/buddycloud/channelserver/packetprocessor/iq/namespace/discoinfo/DiscoInfoGet.java","position":22,"original_position":22,"commit_id":"f0962f9f1ad4b289867856f372d52bec258ecf5d","original_commit_id":"f0962f9f1ad4b289867856f372d52bec258ecf5d","user":{"login":"abmargb","id":308261,"avatar_url":"https://avatars.githubusercontent.com/u/308261?v=2","gravatar_id":"","url":"https://api.github.com/users/abmargb","html_url":"https://github.com/abmargb","followers_url":"https://api.github.com/users/abmargb/followers","following_url":"https://api.github.com/users/abmargb/following{/other_user}","gists_url":"https://api.github.com/users/abmargb/gists{/gist_id}","starred_url":"https://api.github.com/users/abmargb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abmargb/subscriptions","organizations_url":"https://api.github.com/users/abmargb/orgs","repos_url":"https://api.github.com/users/abmargb/repos","events_url":"https://api.github.com/users/abmargb/events{/privacy}","received_events_url":"https://api.github.com/users/abmargb/received_events","type":"User","site_admin":false},"body":"String.isEmpty() ?","created_at":"2014-10-27T17:17:55Z","updated_at":"2014-10-27T17:17:55Z","html_url":"https://github.com/buddycloud/buddycloud-server-java/pull/259#discussion_r19420368","pull_request_url":"https://api.github.com/repos/buddycloud/buddycloud-server-java/pulls/259","_links":{"self":{"href":"https://api.github.com/repos/buddycloud/buddycloud-server-java/pulls/comments/19420368"},"html":{"href":"https://github.com/buddycloud/buddycloud-server-java/pull/259#discussion_r19420368"},"pull_request":{"href":"https://api.github.com/repos/buddycloud/buddycloud-server-java/pulls/259"}}},"pull_request":{"url":"https://api.github.com/repos/buddycloud/buddycloud-server-java/pulls/259","id":23390912,"html_url":"https://github.com/buddycloud/buddycloud-server-java/pull/259","diff_url":"https://github.com/buddycloud/buddycloud-server-java/pull/259.diff","patch_url":"https://github.com/buddycloud/buddycloud-server-java/pull/259.patch","issue_url":"https://api.github.com/repos/buddycloud/buddycloud-server-java/issues/259","number":259,"state":"open","locked":false,"title":"Dedupe pubsubprocessor","user":{"login":"garethf","id":703501,"avatar_url":"https://avatars.githubusercontent.com/u/703501?v=2","gravatar_id":"","url":"https://api.github.com/users/garethf","html_url":"https://github.com/garethf","followers_url":"https://api.github.com/users/garethf/followers","following_url":"https://api.github.com/users/garethf/following{/other_user}","gists_url":"https://api.github.com/users/garethf/gists{/gist_id}","starred_url":"https://api.github.com/users/garethf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garethf/subscriptions","organizations_url":"https://api.github.com/users/garethf/orgs","repos_url":"https://api.github.com/users/garethf/repos","events_url":"https://api.github.com/users/garethf/events{/privacy}","received_events_url":"https://api.github.com/users/garethf/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-10-27T15:25:55Z","updated_at":"2014-10-27T17:17:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2422b45cf41a1658d6e036f79fd2843aab052ca1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/buddycloud/buddycloud-server-java/pulls/259/commits","review_comments_url":"https://api.github.com/repos/buddycloud/buddycloud-server-java/pulls/259/comments","review_comment_url":"https://api.github.com/repos/buddycloud/buddycloud-server-java/pulls/comments/{number}","comments_url":"https://api.github.com/repos/buddycloud/buddycloud-server-java/issues/259/comments","statuses_url":"https://api.github.com/repos/buddycloud/buddycloud-server-java/statuses/f0962f9f1ad4b289867856f372d52bec258ecf5d","head":{"label":"garethf:dedupe_pubsubprocessor","ref":"dedupe_pubsubprocessor","sha":"f0962f9f1ad4b289867856f372d52bec258ecf5d","user":{"login":"garethf","id":703501,"avatar_url":"https://avatars.githubusercontent.com/u/703501?v=2","gravatar_id":"","url":"https://api.github.com/users/garethf","html_url":"https://github.com/garethf","followers_url":"https://api.github.com/users/garethf/followers","following_url":"https://api.github.com/users/garethf/following{/other_user}","gists_url":"https://api.github.com/users/garethf/gists{/gist_id}","starred_url":"https://api.github.com/users/garethf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garethf/subscriptions","organizations_url":"https://api.github.com/users/garethf/orgs","repos_url":"https://api.github.com/users/garethf/repos","events_url":"https://api.github.com/users/garethf/events{/privacy}","received_events_url":"https://api.github.com/users/garethf/received_events","type":"User","site_admin":false},"repo":{"id":24757743,"name":"buddycloud-server-java","full_name":"garethf/buddycloud-server-java","owner":{"login":"garethf","id":703501,"avatar_url":"https://avatars.githubusercontent.com/u/703501?v=2","gravatar_id":"","url":"https://api.github.com/users/garethf","html_url":"https://github.com/garethf","followers_url":"https://api.github.com/users/garethf/followers","following_url":"https://api.github.com/users/garethf/following{/other_user}","gists_url":"https://api.github.com/users/garethf/gists{/gist_id}","starred_url":"https://api.github.com/users/garethf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garethf/subscriptions","organizations_url":"https://api.github.com/users/garethf/orgs","repos_url":"https://api.github.com/users/garethf/repos","events_url":"https://api.github.com/users/garethf/events{/privacy}","received_events_url":"https://api.github.com/users/garethf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/garethf/buddycloud-server-java","description":"The buddycloud server written in Java.","fork":true,"url":"https://api.github.com/repos/garethf/buddycloud-server-java","forks_url":"https://api.github.com/repos/garethf/buddycloud-server-java/forks","keys_url":"https://api.github.com/repos/garethf/buddycloud-server-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/garethf/buddycloud-server-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/garethf/buddycloud-server-java/teams","hooks_url":"https://api.github.com/repos/garethf/buddycloud-server-java/hooks","issue_events_url":"https://api.github.com/repos/garethf/buddycloud-server-java/issues/events{/number}","events_url":"https://api.github.com/repos/garethf/buddycloud-server-java/events","assignees_url":"https://api.github.com/repos/garethf/buddycloud-server-java/assignees{/user}","branches_url":"https://api.github.com/repos/garethf/buddycloud-server-java/branches{/branch}","tags_url":"https://api.github.com/repos/garethf/buddycloud-server-java/tags","blobs_url":"https://api.github.com/repos/garethf/buddycloud-server-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/garethf/buddycloud-server-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/garethf/buddycloud-server-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/garethf/buddycloud-server-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/garethf/buddycloud-server-java/statuses/{sha}","languages_url":"https://api.github.com/repos/garethf/buddycloud-server-java/languages","stargazers_url":"https://api.github.com/repos/garethf/buddycloud-server-java/stargazers","contributors_url":"https://api.github.com/repos/garethf/buddycloud-server-java/contributors","subscribers_url":"https://api.github.com/repos/garethf/buddycloud-server-java/subscribers","subscription_url":"https://api.github.com/repos/garethf/buddycloud-server-java/subscription","commits_url":"https://api.github.com/repos/garethf/buddycloud-server-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/garethf/buddycloud-server-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/garethf/buddycloud-server-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/garethf/buddycloud-server-java/issues/comments/{number}","contents_url":"https://api.github.com/repos/garethf/buddycloud-server-java/contents/{+path}","compare_url":"https://api.github.com/repos/garethf/buddycloud-server-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/garethf/buddycloud-server-java/merges","archive_url":"https://api.github.com/repos/garethf/buddycloud-server-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/garethf/buddycloud-server-java/downloads","issues_url":"https://api.github.com/repos/garethf/buddycloud-server-java/issues{/number}","pulls_url":"https://api.github.com/repos/garethf/buddycloud-server-java/pulls{/number}","milestones_url":"https://api.github.com/repos/garethf/buddycloud-server-java/milestones{/number}","notifications_url":"https://api.github.com/repos/garethf/buddycloud-server-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/garethf/buddycloud-server-java/labels{/name}","releases_url":"https://api.github.com/repos/garethf/buddycloud-server-java/releases{/id}","created_at":"2014-10-03T12:34:33Z","updated_at":"2014-10-08T08:38:58Z","pushed_at":"2014-10-27T15:17:44Z","git_url":"git://github.com/garethf/buddycloud-server-java.git","ssh_url":"git@github.com:garethf/buddycloud-server-java.git","clone_url":"https://github.com/garethf/buddycloud-server-java.git","svn_url":"https://github.com/garethf/buddycloud-server-java","homepage":"http://buddycloud.com","size":8194,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"buddycloud:master","ref":"master","sha":"df6bc0b750cbbca9ded14e5e1112fb1fc4170442","user":{"login":"buddycloud","id":469576,"avatar_url":"https://avatars.githubusercontent.com/u/469576?v=2","gravatar_id":"","url":"https://api.github.com/users/buddycloud","html_url":"https://github.com/buddycloud","followers_url":"https://api.github.com/users/buddycloud/followers","following_url":"https://api.github.com/users/buddycloud/following{/other_user}","gists_url":"https://api.github.com/users/buddycloud/gists{/gist_id}","starred_url":"https://api.github.com/users/buddycloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buddycloud/subscriptions","organizations_url":"https://api.github.com/users/buddycloud/orgs","repos_url":"https://api.github.com/users/buddycloud/repos","events_url":"https://api.github.com/users/buddycloud/events{/privacy}","received_events_url":"https://api.github.com/users/buddycloud/received_events","type":"Organization","site_admin":false},"repo":{"id":1862149,"name":"buddycloud-server-java","full_name":"buddycloud/buddycloud-server-java","owner":{"login":"buddycloud","id":469576,"avatar_url":"https://avatars.githubusercontent.com/u/469576?v=2","gravatar_id":"","url":"https://api.github.com/users/buddycloud","html_url":"https://github.com/buddycloud","followers_url":"https://api.github.com/users/buddycloud/followers","following_url":"https://api.github.com/users/buddycloud/following{/other_user}","gists_url":"https://api.github.com/users/buddycloud/gists{/gist_id}","starred_url":"https://api.github.com/users/buddycloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buddycloud/subscriptions","organizations_url":"https://api.github.com/users/buddycloud/orgs","repos_url":"https://api.github.com/users/buddycloud/repos","events_url":"https://api.github.com/users/buddycloud/events{/privacy}","received_events_url":"https://api.github.com/users/buddycloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/buddycloud/buddycloud-server-java","description":"The buddycloud server written in Java.","fork":false,"url":"https://api.github.com/repos/buddycloud/buddycloud-server-java","forks_url":"https://api.github.com/repos/buddycloud/buddycloud-server-java/forks","keys_url":"https://api.github.com/repos/buddycloud/buddycloud-server-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/buddycloud/buddycloud-server-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/buddycloud/buddycloud-server-java/teams","hooks_url":"https://api.github.com/repos/buddycloud/buddycloud-server-java/hooks","issue_events_url":"https://api.github.com/repos/buddycloud/buddycloud-server-java/issues/events{/number}","events_url":"https://api.github.com/repos/buddycloud/buddycloud-server-java/events","assignees_url":"https://api.github.com/repos/buddycloud/buddycloud-server-java/assignees{/user}","branches_url":"https://api.github.com/repos/buddycloud/buddycloud-server-java/branches{/branch}","tags_url":"https://api.github.com/repos/buddycloud/buddycloud-server-java/tags","blobs_url":"https://api.github.com/repos/buddycloud/buddycloud-server-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/buddycloud/buddycloud-server-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/buddycloud/buddycloud-server-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/buddycloud/buddycloud-server-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/buddycloud/buddycloud-server-java/statuses/{sha}","languages_url":"https://api.github.com/repos/buddycloud/buddycloud-server-java/languages","stargazers_url":"https://api.github.com/repos/buddycloud/buddycloud-server-java/stargazers","contributors_url":"https://api.github.com/repos/buddycloud/buddycloud-server-java/contributors","subscribers_url":"https://api.github.com/repos/buddycloud/buddycloud-server-java/subscribers","subscription_url":"https://api.github.com/repos/buddycloud/buddycloud-server-java/subscription","commits_url":"https://api.github.com/repos/buddycloud/buddycloud-server-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/buddycloud/buddycloud-server-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/buddycloud/buddycloud-server-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/buddycloud/buddycloud-server-java/issues/comments/{number}","contents_url":"https://api.github.com/repos/buddycloud/buddycloud-server-java/contents/{+path}","compare_url":"https://api.github.com/repos/buddycloud/buddycloud-server-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/buddycloud/buddycloud-server-java/merges","archive_url":"https://api.github.com/repos/buddycloud/buddycloud-server-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/buddycloud/buddycloud-server-java/downloads","issues_url":"https://api.github.com/repos/buddycloud/buddycloud-server-java/issues{/number}","pulls_url":"https://api.github.com/repos/buddycloud/buddycloud-server-java/pulls{/number}","milestones_url":"https://api.github.com/repos/buddycloud/buddycloud-server-java/milestones{/number}","notifications_url":"https://api.github.com/repos/buddycloud/buddycloud-server-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/buddycloud/buddycloud-server-java/labels{/name}","releases_url":"https://api.github.com/repos/buddycloud/buddycloud-server-java/releases{/id}","created_at":"2011-06-07T21:08:21Z","updated_at":"2014-10-23T14:43:26Z","pushed_at":"2014-10-27T15:22:27Z","git_url":"git://github.com/buddycloud/buddycloud-server-java.git","ssh_url":"git@github.com:buddycloud/buddycloud-server-java.git","clone_url":"https://github.com/buddycloud/buddycloud-server-java.git","svn_url":"https://github.com/buddycloud/buddycloud-server-java","homepage":"http://buddycloud.com","size":12114,"stargazers_count":38,"watchers_count":38,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":36,"forks":25,"open_issues":36,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/buddycloud/buddycloud-server-java/pulls/259"},"html":{"href":"https://github.com/buddycloud/buddycloud-server-java/pull/259"},"issue":{"href":"https://api.github.com/repos/buddycloud/buddycloud-server-java/issues/259"},"comments":{"href":"https://api.github.com/repos/buddycloud/buddycloud-server-java/issues/259/comments"},"review_comments":{"href":"https://api.github.com/repos/buddycloud/buddycloud-server-java/pulls/259/comments"},"review_comment":{"href":"https://api.github.com/repos/buddycloud/buddycloud-server-java/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/buddycloud/buddycloud-server-java/pulls/259/commits"},"statuses":{"href":"https://api.github.com/repos/buddycloud/buddycloud-server-java/statuses/f0962f9f1ad4b289867856f372d52bec258ecf5d"}}}}