GitHub PullRequestEvent at 2014-10-14 14:32:31
Repository: goobi-production
Actor: henning-gerhardt
Payload: {"action":"closed","number":212,"pull_request":{"url":"https://api.github.com/repos/goobi/goobi-production/pulls/212","id":21938823,"html_url":"https://github.com/goobi/goobi-production/pull/212","diff_url":"https://github.com/goobi/goobi-production/pull/212.diff","patch_url":"https://github.com/goobi/goobi-production/pull/212.patch","issue_url":"https://api.github.com/repos/goobi/goobi-production/issues/212","number":212,"state":"closed","locked":false,"title":"Merge:  [ZM] Finalising a step throws a NullPointerException (#211)","user":{"login":"matthias-ronge","id":3040657,"avatar_url":"https://avatars.githubusercontent.com/u/3040657?v=2","gravatar_id":"","url":"https://api.github.com/users/matthias-ronge","html_url":"https://github.com/matthias-ronge","followers_url":"https://api.github.com/users/matthias-ronge/followers","following_url":"https://api.github.com/users/matthias-ronge/following{/other_user}","gists_url":"https://api.github.com/users/matthias-ronge/gists{/gist_id}","starred_url":"https://api.github.com/users/matthias-ronge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthias-ronge/subscriptions","organizations_url":"https://api.github.com/users/matthias-ronge/orgs","repos_url":"https://api.github.com/users/matthias-ronge/repos","events_url":"https://api.github.com/users/matthias-ronge/events{/privacy}","received_events_url":"https://api.github.com/users/matthias-ronge/received_events","type":"User","site_admin":false},"body":"Null pointer exception arised because a method trying to access the database without Hibernate tried to query the column “BatchID” which ceased to exist long time ago, then silently failed and returned null instead. The value it was trying to retrieve was never used anymore. While testing the change other issues arised, so this change now provides a redesign of the batch feature which imposed more and more by the development of export features being based on batches, since assignments of processes to several batches led to no more working batch steps. Along with the change, some Hibernate caching issues have been removed.\r\n\r\nBatches are now distinguished by a type, which can be one of logistics, newspaper, or serial publication. Batch steps will operate on logistics batches only, while newspaper and serial publication batches will provide DMS export for the complete edition of newspapers and serial publication, respectively, providing the feature to create cross-links to the other issues in the anchor files while exporting. A process can now belong to export batches as well as a logistics batch without that the assignment to export batches blocks the use of batch steps any more.\r\n\r\nThe database needs to be updated:\r\n``` sql\r\nALTER TABLE `batches` ADD `type` varchar(9) DEFAULT NULL;\r\nUPDATE `batches` SET `type` = 'LOGISTIC';\r\n```\r\n\r\nPrerequisite: Development of this bug-fix needs to be based on  #173 *Extend batch export to DMS for multi-volume works*","created_at":"2014-09-29T14:41:11Z","updated_at":"2014-10-14T14:32:31Z","closed_at":"2014-10-14T14:32:31Z","merged_at":"2014-10-14T14:32:31Z","merge_commit_sha":"52cbf631e55e50e9a3d201e95305086d4a8e1c3f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/goobi/goobi-production/pulls/212/commits","review_comments_url":"https://api.github.com/repos/goobi/goobi-production/pulls/212/comments","review_comment_url":"https://api.github.com/repos/goobi/goobi-production/pulls/comments/{number}","comments_url":"https://api.github.com/repos/goobi/goobi-production/issues/212/comments","statuses_url":"https://api.github.com/repos/goobi/goobi-production/statuses/558bdf24839f6df8e8ceb379be265949ad80a689","head":{"label":"matthias-ronge:issue_211","ref":"issue_211","sha":"558bdf24839f6df8e8ceb379be265949ad80a689","user":{"login":"matthias-ronge","id":3040657,"avatar_url":"https://avatars.githubusercontent.com/u/3040657?v=2","gravatar_id":"","url":"https://api.github.com/users/matthias-ronge","html_url":"https://github.com/matthias-ronge","followers_url":"https://api.github.com/users/matthias-ronge/followers","following_url":"https://api.github.com/users/matthias-ronge/following{/other_user}","gists_url":"https://api.github.com/users/matthias-ronge/gists{/gist_id}","starred_url":"https://api.github.com/users/matthias-ronge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthias-ronge/subscriptions","organizations_url":"https://api.github.com/users/matthias-ronge/orgs","repos_url":"https://api.github.com/users/matthias-ronge/repos","events_url":"https://api.github.com/users/matthias-ronge/events{/privacy}","received_events_url":"https://api.github.com/users/matthias-ronge/received_events","type":"User","site_admin":false},"repo":{"id":8181005,"name":"goobi-production","full_name":"matthias-ronge/goobi-production","owner":{"login":"matthias-ronge","id":3040657,"avatar_url":"https://avatars.githubusercontent.com/u/3040657?v=2","gravatar_id":"","url":"https://api.github.com/users/matthias-ronge","html_url":"https://github.com/matthias-ronge","followers_url":"https://api.github.com/users/matthias-ronge/followers","following_url":"https://api.github.com/users/matthias-ronge/following{/other_user}","gists_url":"https://api.github.com/users/matthias-ronge/gists{/gist_id}","starred_url":"https://api.github.com/users/matthias-ronge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthias-ronge/subscriptions","organizations_url":"https://api.github.com/users/matthias-ronge/orgs","repos_url":"https://api.github.com/users/matthias-ronge/repos","events_url":"https://api.github.com/users/matthias-ronge/events{/privacy}","received_events_url":"https://api.github.com/users/matthias-ronge/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matthias-ronge/goobi-production","description":"Goobi.Production CE","fork":true,"url":"https://api.github.com/repos/matthias-ronge/goobi-production","forks_url":"https://api.github.com/repos/matthias-ronge/goobi-production/forks","keys_url":"https://api.github.com/repos/matthias-ronge/goobi-production/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matthias-ronge/goobi-production/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matthias-ronge/goobi-production/teams","hooks_url":"https://api.github.com/repos/matthias-ronge/goobi-production/hooks","issue_events_url":"https://api.github.com/repos/matthias-ronge/goobi-production/issues/events{/number}","events_url":"https://api.github.com/repos/matthias-ronge/goobi-production/events","assignees_url":"https://api.github.com/repos/matthias-ronge/goobi-production/assignees{/user}","branches_url":"https://api.github.com/repos/matthias-ronge/goobi-production/branches{/branch}","tags_url":"https://api.github.com/repos/matthias-ronge/goobi-production/tags","blobs_url":"https://api.github.com/repos/matthias-ronge/goobi-production/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matthias-ronge/goobi-production/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matthias-ronge/goobi-production/git/refs{/sha}","trees_url":"https://api.github.com/repos/matthias-ronge/goobi-production/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matthias-ronge/goobi-production/statuses/{sha}","languages_url":"https://api.github.com/repos/matthias-ronge/goobi-production/languages","stargazers_url":"https://api.github.com/repos/matthias-ronge/goobi-production/stargazers","contributors_url":"https://api.github.com/repos/matthias-ronge/goobi-production/contributors","subscribers_url":"https://api.github.com/repos/matthias-ronge/goobi-production/subscribers","subscription_url":"https://api.github.com/repos/matthias-ronge/goobi-production/subscription","commits_url":"https://api.github.com/repos/matthias-ronge/goobi-production/commits{/sha}","git_commits_url":"https://api.github.com/repos/matthias-ronge/goobi-production/git/commits{/sha}","comments_url":"https://api.github.com/repos/matthias-ronge/goobi-production/comments{/number}","issue_comment_url":"https://api.github.com/repos/matthias-ronge/goobi-production/issues/comments/{number}","contents_url":"https://api.github.com/repos/matthias-ronge/goobi-production/contents/{+path}","compare_url":"https://api.github.com/repos/matthias-ronge/goobi-production/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matthias-ronge/goobi-production/merges","archive_url":"https://api.github.com/repos/matthias-ronge/goobi-production/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matthias-ronge/goobi-production/downloads","issues_url":"https://api.github.com/repos/matthias-ronge/goobi-production/issues{/number}","pulls_url":"https://api.github.com/repos/matthias-ronge/goobi-production/pulls{/number}","milestones_url":"https://api.github.com/repos/matthias-ronge/goobi-production/milestones{/number}","notifications_url":"https://api.github.com/repos/matthias-ronge/goobi-production/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matthias-ronge/goobi-production/labels{/name}","releases_url":"https://api.github.com/repos/matthias-ronge/goobi-production/releases{/id}","created_at":"2013-02-13T14:51:42Z","updated_at":"2014-06-25T09:46:26Z","pushed_at":"2014-10-14T06:21:53Z","git_url":"git://github.com/matthias-ronge/goobi-production.git","ssh_url":"git@github.com:matthias-ronge/goobi-production.git","clone_url":"https://github.com/matthias-ronge/goobi-production.git","svn_url":"https://github.com/matthias-ronge/goobi-production","homepage":null,"size":111024,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"goobi:feature-zm","ref":"feature-zm","sha":"1ff4b2df666de875e4de2cf350eca6b93a3622cf","user":{"login":"goobi","id":1798485,"avatar_url":"https://avatars.githubusercontent.com/u/1798485?v=2","gravatar_id":"","url":"https://api.github.com/users/goobi","html_url":"https://github.com/goobi","followers_url":"https://api.github.com/users/goobi/followers","following_url":"https://api.github.com/users/goobi/following{/other_user}","gists_url":"https://api.github.com/users/goobi/gists{/gist_id}","starred_url":"https://api.github.com/users/goobi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goobi/subscriptions","organizations_url":"https://api.github.com/users/goobi/orgs","repos_url":"https://api.github.com/users/goobi/repos","events_url":"https://api.github.com/users/goobi/events{/privacy}","received_events_url":"https://api.github.com/users/goobi/received_events","type":"Organization","site_admin":false},"repo":{"id":4506938,"name":"goobi-production","full_name":"goobi/goobi-production","owner":{"login":"goobi","id":1798485,"avatar_url":"https://avatars.githubusercontent.com/u/1798485?v=2","gravatar_id":"","url":"https://api.github.com/users/goobi","html_url":"https://github.com/goobi","followers_url":"https://api.github.com/users/goobi/followers","following_url":"https://api.github.com/users/goobi/following{/other_user}","gists_url":"https://api.github.com/users/goobi/gists{/gist_id}","starred_url":"https://api.github.com/users/goobi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goobi/subscriptions","organizations_url":"https://api.github.com/users/goobi/orgs","repos_url":"https://api.github.com/users/goobi/repos","events_url":"https://api.github.com/users/goobi/events{/privacy}","received_events_url":"https://api.github.com/users/goobi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/goobi/goobi-production","description":"Goobi.Production Community Edition","fork":false,"url":"https://api.github.com/repos/goobi/goobi-production","forks_url":"https://api.github.com/repos/goobi/goobi-production/forks","keys_url":"https://api.github.com/repos/goobi/goobi-production/keys{/key_id}","collaborators_url":"https://api.github.com/repos/goobi/goobi-production/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/goobi/goobi-production/teams","hooks_url":"https://api.github.com/repos/goobi/goobi-production/hooks","issue_events_url":"https://api.github.com/repos/goobi/goobi-production/issues/events{/number}","events_url":"https://api.github.com/repos/goobi/goobi-production/events","assignees_url":"https://api.github.com/repos/goobi/goobi-production/assignees{/user}","branches_url":"https://api.github.com/repos/goobi/goobi-production/branches{/branch}","tags_url":"https://api.github.com/repos/goobi/goobi-production/tags","blobs_url":"https://api.github.com/repos/goobi/goobi-production/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/goobi/goobi-production/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/goobi/goobi-production/git/refs{/sha}","trees_url":"https://api.github.com/repos/goobi/goobi-production/git/trees{/sha}","statuses_url":"https://api.github.com/repos/goobi/goobi-production/statuses/{sha}","languages_url":"https://api.github.com/repos/goobi/goobi-production/languages","stargazers_url":"https://api.github.com/repos/goobi/goobi-production/stargazers","contributors_url":"https://api.github.com/repos/goobi/goobi-production/contributors","subscribers_url":"https://api.github.com/repos/goobi/goobi-production/subscribers","subscription_url":"https://api.github.com/repos/goobi/goobi-production/subscription","commits_url":"https://api.github.com/repos/goobi/goobi-production/commits{/sha}","git_commits_url":"https://api.github.com/repos/goobi/goobi-production/git/commits{/sha}","comments_url":"https://api.github.com/repos/goobi/goobi-production/comments{/number}","issue_comment_url":"https://api.github.com/repos/goobi/goobi-production/issues/comments/{number}","contents_url":"https://api.github.com/repos/goobi/goobi-production/contents/{+path}","compare_url":"https://api.github.com/repos/goobi/goobi-production/compare/{base}...{head}","merges_url":"https://api.github.com/repos/goobi/goobi-production/merges","archive_url":"https://api.github.com/repos/goobi/goobi-production/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/goobi/goobi-production/downloads","issues_url":"https://api.github.com/repos/goobi/goobi-production/issues{/number}","pulls_url":"https://api.github.com/repos/goobi/goobi-production/pulls{/number}","milestones_url":"https://api.github.com/repos/goobi/goobi-production/milestones{/number}","notifications_url":"https://api.github.com/repos/goobi/goobi-production/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/goobi/goobi-production/labels{/name}","releases_url":"https://api.github.com/repos/goobi/goobi-production/releases{/id}","created_at":"2012-05-31T11:36:27Z","updated_at":"2014-09-08T11:35:59Z","pushed_at":"2014-10-14T14:32:31Z","git_url":"git://github.com/goobi/goobi-production.git","ssh_url":"git@github.com:goobi/goobi-production.git","clone_url":"https://github.com/goobi/goobi-production.git","svn_url":"https://github.com/goobi/goobi-production","homepage":"","size":110676,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":53,"forks":9,"open_issues":53,"watchers":6,"default_branch":"1.10.x"}},"_links":{"self":{"href":"https://api.github.com/repos/goobi/goobi-production/pulls/212"},"html":{"href":"https://github.com/goobi/goobi-production/pull/212"},"issue":{"href":"https://api.github.com/repos/goobi/goobi-production/issues/212"},"comments":{"href":"https://api.github.com/repos/goobi/goobi-production/issues/212/comments"},"review_comments":{"href":"https://api.github.com/repos/goobi/goobi-production/pulls/212/comments"},"review_comment":{"href":"https://api.github.com/repos/goobi/goobi-production/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/goobi/goobi-production/pulls/212/commits"},"statuses":{"href":"https://api.github.com/repos/goobi/goobi-production/statuses/558bdf24839f6df8e8ceb379be265949ad80a689"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"henning-gerhardt","id":2129672,"avatar_url":"https://avatars.githubusercontent.com/u/2129672?v=2","gravatar_id":"","url":"https://api.github.com/users/henning-gerhardt","html_url":"https://github.com/henning-gerhardt","followers_url":"https://api.github.com/users/henning-gerhardt/followers","following_url":"https://api.github.com/users/henning-gerhardt/following{/other_user}","gists_url":"https://api.github.com/users/henning-gerhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/henning-gerhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henning-gerhardt/subscriptions","organizations_url":"https://api.github.com/users/henning-gerhardt/orgs","repos_url":"https://api.github.com/users/henning-gerhardt/repos","events_url":"https://api.github.com/users/henning-gerhardt/events{/privacy}","received_events_url":"https://api.github.com/users/henning-gerhardt/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":51,"additions":3030,"deletions":942,"changed_files":47}}