GitHub PullRequestEvent at 2014-09-04 13:24:35
Repository: bitcoinj
Actor: troggy
Payload: {"action":"opened","number":207,"pull_request":{"url":"https://api.github.com/repos/bitcoinj/bitcoinj/pulls/207","id":20742812,"html_url":"https://github.com/bitcoinj/bitcoinj/pull/207","diff_url":"https://github.com/bitcoinj/bitcoinj/pull/207.diff","patch_url":"https://github.com/bitcoinj/bitcoinj/pull/207.patch","issue_url":"https://api.github.com/repos/bitcoinj/bitcoinj/issues/207","number":207,"state":"open","locked":false,"title":"Insert sigs in scriptSig in order of the signers","user":{"login":"troggy","id":163447,"avatar_url":"https://avatars.githubusercontent.com/u/163447?v=2","gravatar_id":"652a10285822faeb762f92dcc0fac2f3","url":"https://api.github.com/users/troggy","html_url":"https://github.com/troggy","followers_url":"https://api.github.com/users/troggy/followers","following_url":"https://api.github.com/users/troggy/following{/other_user}","gists_url":"https://api.github.com/users/troggy/gists{/gist_id}","starred_url":"https://api.github.com/users/troggy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/troggy/subscriptions","organizations_url":"https://api.github.com/users/troggy/orgs","repos_url":"https://api.github.com/users/troggy/repos","events_url":"https://api.github.com/users/troggy/events{/privacy}","received_events_url":"https://api.github.com/users/troggy/received_events","type":"User","site_admin":false},"body":"This way the first sig will be the one from LocalTransactionSigner, the\r\nsecond sig will be the one from the next signer added to the wallet and so\r\non.\r\nTo achieve this, following keys should be added to the wallet in the same\r\norder as signers. Pubkeys aren't sorted anymore when creating redeem\r\nscript, so now the order of the keys matter. The first pubkey in redeem script\r\nwill always be the pubkey from the local (followed) keychain, the rest are\r\nin the same order as following keys passed to the Wallet.addFollowingAccountKeys.\r\n\r\nI've tried to describe all the above in javadocs, although explaining\r\nthings in English is not my best skill. Let me know if you feel it's not enough\r\nor simply wrong.","created_at":"2014-09-04T13:24:32Z","updated_at":"2014-09-04T13:24:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7e4b4421c49c33f4239ae4335d098eb195615b09","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bitcoinj/bitcoinj/pulls/207/commits","review_comments_url":"https://api.github.com/repos/bitcoinj/bitcoinj/pulls/207/comments","review_comment_url":"https://api.github.com/repos/bitcoinj/bitcoinj/pulls/comments/{number}","comments_url":"https://api.github.com/repos/bitcoinj/bitcoinj/issues/207/comments","statuses_url":"https://api.github.com/repos/bitcoinj/bitcoinj/statuses/12000b5a15d631c38c7b781693a6b7598400d64c","head":{"label":"troggy:mw-fix-sigindex","ref":"mw-fix-sigindex","sha":"12000b5a15d631c38c7b781693a6b7598400d64c","user":{"login":"troggy","id":163447,"avatar_url":"https://avatars.githubusercontent.com/u/163447?v=2","gravatar_id":"652a10285822faeb762f92dcc0fac2f3","url":"https://api.github.com/users/troggy","html_url":"https://github.com/troggy","followers_url":"https://api.github.com/users/troggy/followers","following_url":"https://api.github.com/users/troggy/following{/other_user}","gists_url":"https://api.github.com/users/troggy/gists{/gist_id}","starred_url":"https://api.github.com/users/troggy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/troggy/subscriptions","organizations_url":"https://api.github.com/users/troggy/orgs","repos_url":"https://api.github.com/users/troggy/repos","events_url":"https://api.github.com/users/troggy/events{/privacy}","received_events_url":"https://api.github.com/users/troggy/received_events","type":"User","site_admin":false},"repo":{"id":20183147,"name":"bitcoinj","full_name":"troggy/bitcoinj","owner":{"login":"troggy","id":163447,"avatar_url":"https://avatars.githubusercontent.com/u/163447?v=2","gravatar_id":"652a10285822faeb762f92dcc0fac2f3","url":"https://api.github.com/users/troggy","html_url":"https://github.com/troggy","followers_url":"https://api.github.com/users/troggy/followers","following_url":"https://api.github.com/users/troggy/following{/other_user}","gists_url":"https://api.github.com/users/troggy/gists{/gist_id}","starred_url":"https://api.github.com/users/troggy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/troggy/subscriptions","organizations_url":"https://api.github.com/users/troggy/orgs","repos_url":"https://api.github.com/users/troggy/repos","events_url":"https://api.github.com/users/troggy/events{/privacy}","received_events_url":"https://api.github.com/users/troggy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/troggy/bitcoinj","description":"A library for working with Bitcoin","fork":true,"url":"https://api.github.com/repos/troggy/bitcoinj","forks_url":"https://api.github.com/repos/troggy/bitcoinj/forks","keys_url":"https://api.github.com/repos/troggy/bitcoinj/keys{/key_id}","collaborators_url":"https://api.github.com/repos/troggy/bitcoinj/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/troggy/bitcoinj/teams","hooks_url":"https://api.github.com/repos/troggy/bitcoinj/hooks","issue_events_url":"https://api.github.com/repos/troggy/bitcoinj/issues/events{/number}","events_url":"https://api.github.com/repos/troggy/bitcoinj/events","assignees_url":"https://api.github.com/repos/troggy/bitcoinj/assignees{/user}","branches_url":"https://api.github.com/repos/troggy/bitcoinj/branches{/branch}","tags_url":"https://api.github.com/repos/troggy/bitcoinj/tags","blobs_url":"https://api.github.com/repos/troggy/bitcoinj/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/troggy/bitcoinj/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/troggy/bitcoinj/git/refs{/sha}","trees_url":"https://api.github.com/repos/troggy/bitcoinj/git/trees{/sha}","statuses_url":"https://api.github.com/repos/troggy/bitcoinj/statuses/{sha}","languages_url":"https://api.github.com/repos/troggy/bitcoinj/languages","stargazers_url":"https://api.github.com/repos/troggy/bitcoinj/stargazers","contributors_url":"https://api.github.com/repos/troggy/bitcoinj/contributors","subscribers_url":"https://api.github.com/repos/troggy/bitcoinj/subscribers","subscription_url":"https://api.github.com/repos/troggy/bitcoinj/subscription","commits_url":"https://api.github.com/repos/troggy/bitcoinj/commits{/sha}","git_commits_url":"https://api.github.com/repos/troggy/bitcoinj/git/commits{/sha}","comments_url":"https://api.github.com/repos/troggy/bitcoinj/comments{/number}","issue_comment_url":"https://api.github.com/repos/troggy/bitcoinj/issues/comments/{number}","contents_url":"https://api.github.com/repos/troggy/bitcoinj/contents/{+path}","compare_url":"https://api.github.com/repos/troggy/bitcoinj/compare/{base}...{head}","merges_url":"https://api.github.com/repos/troggy/bitcoinj/merges","archive_url":"https://api.github.com/repos/troggy/bitcoinj/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/troggy/bitcoinj/downloads","issues_url":"https://api.github.com/repos/troggy/bitcoinj/issues{/number}","pulls_url":"https://api.github.com/repos/troggy/bitcoinj/pulls{/number}","milestones_url":"https://api.github.com/repos/troggy/bitcoinj/milestones{/number}","notifications_url":"https://api.github.com/repos/troggy/bitcoinj/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/troggy/bitcoinj/labels{/name}","releases_url":"https://api.github.com/repos/troggy/bitcoinj/releases{/id}","created_at":"2014-05-26T10:51:15Z","updated_at":"2014-06-26T11:28:20Z","pushed_at":"2014-09-04T13:16:21Z","git_url":"git://github.com/troggy/bitcoinj.git","ssh_url":"git@github.com:troggy/bitcoinj.git","clone_url":"https://github.com/troggy/bitcoinj.git","svn_url":"https://github.com/troggy/bitcoinj","homepage":"http://www.bitcoinj.org","size":14282,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bitcoinj:master","ref":"master","sha":"ae24da4f9c9f408598675ce4ccfab849157f90bd","user":{"login":"bitcoinj","id":5951625,"avatar_url":"https://avatars.githubusercontent.com/u/5951625?v=2","gravatar_id":null,"url":"https://api.github.com/users/bitcoinj","html_url":"https://github.com/bitcoinj","followers_url":"https://api.github.com/users/bitcoinj/followers","following_url":"https://api.github.com/users/bitcoinj/following{/other_user}","gists_url":"https://api.github.com/users/bitcoinj/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoinj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoinj/subscriptions","organizations_url":"https://api.github.com/users/bitcoinj/orgs","repos_url":"https://api.github.com/users/bitcoinj/repos","events_url":"https://api.github.com/users/bitcoinj/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoinj/received_events","type":"Organization","site_admin":false},"repo":{"id":14514251,"name":"bitcoinj","full_name":"bitcoinj/bitcoinj","owner":{"login":"bitcoinj","id":5951625,"avatar_url":"https://avatars.githubusercontent.com/u/5951625?v=2","gravatar_id":null,"url":"https://api.github.com/users/bitcoinj","html_url":"https://github.com/bitcoinj","followers_url":"https://api.github.com/users/bitcoinj/followers","following_url":"https://api.github.com/users/bitcoinj/following{/other_user}","gists_url":"https://api.github.com/users/bitcoinj/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoinj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoinj/subscriptions","organizations_url":"https://api.github.com/users/bitcoinj/orgs","repos_url":"https://api.github.com/users/bitcoinj/repos","events_url":"https://api.github.com/users/bitcoinj/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoinj/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoinj/bitcoinj","description":"A library for working with Bitcoin","fork":false,"url":"https://api.github.com/repos/bitcoinj/bitcoinj","forks_url":"https://api.github.com/repos/bitcoinj/bitcoinj/forks","keys_url":"https://api.github.com/repos/bitcoinj/bitcoinj/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoinj/bitcoinj/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoinj/bitcoinj/teams","hooks_url":"https://api.github.com/repos/bitcoinj/bitcoinj/hooks","issue_events_url":"https://api.github.com/repos/bitcoinj/bitcoinj/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoinj/bitcoinj/events","assignees_url":"https://api.github.com/repos/bitcoinj/bitcoinj/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoinj/bitcoinj/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoinj/bitcoinj/tags","blobs_url":"https://api.github.com/repos/bitcoinj/bitcoinj/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoinj/bitcoinj/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoinj/bitcoinj/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoinj/bitcoinj/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoinj/bitcoinj/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoinj/bitcoinj/languages","stargazers_url":"https://api.github.com/repos/bitcoinj/bitcoinj/stargazers","contributors_url":"https://api.github.com/repos/bitcoinj/bitcoinj/contributors","subscribers_url":"https://api.github.com/repos/bitcoinj/bitcoinj/subscribers","subscription_url":"https://api.github.com/repos/bitcoinj/bitcoinj/subscription","commits_url":"https://api.github.com/repos/bitcoinj/bitcoinj/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoinj/bitcoinj/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoinj/bitcoinj/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoinj/bitcoinj/issues/comments/{number}","contents_url":"https://api.github.com/repos/bitcoinj/bitcoinj/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoinj/bitcoinj/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoinj/bitcoinj/merges","archive_url":"https://api.github.com/repos/bitcoinj/bitcoinj/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoinj/bitcoinj/downloads","issues_url":"https://api.github.com/repos/bitcoinj/bitcoinj/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoinj/bitcoinj/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoinj/bitcoinj/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoinj/bitcoinj/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoinj/bitcoinj/labels{/name}","releases_url":"https://api.github.com/repos/bitcoinj/bitcoinj/releases{/id}","created_at":"2013-11-19T04:33:23Z","updated_at":"2014-09-02T18:56:55Z","pushed_at":"2014-09-04T12:17:37Z","git_url":"git://github.com/bitcoinj/bitcoinj.git","ssh_url":"git@github.com:bitcoinj/bitcoinj.git","clone_url":"https://github.com/bitcoinj/bitcoinj.git","svn_url":"https://github.com/bitcoinj/bitcoinj","homepage":"http://www.bitcoinj.org","size":25613,"stargazers_count":189,"watchers_count":189,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":210,"mirror_url":null,"open_issues_count":8,"forks":210,"open_issues":8,"watchers":189,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoinj/bitcoinj/pulls/207"},"html":{"href":"https://github.com/bitcoinj/bitcoinj/pull/207"},"issue":{"href":"https://api.github.com/repos/bitcoinj/bitcoinj/issues/207"},"comments":{"href":"https://api.github.com/repos/bitcoinj/bitcoinj/issues/207/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoinj/bitcoinj/pulls/207/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoinj/bitcoinj/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/bitcoinj/bitcoinj/pulls/207/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoinj/bitcoinj/statuses/12000b5a15d631c38c7b781693a6b7598400d64c"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":103,"deletions":83,"changed_files":11}}