GitHub PullRequestReviewCommentEvent at 2014-08-15 16:10:43
Repository: cas-server-security-filter
Actor: apetro
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Jasig/cas-server-security-filter/pulls/comments/16300307","id":16300307,"diff_hunk":"@@ -57,7 +58,8 @@ public void doFilter(final ServletRequest request, final ServletResponse respons\n             throws IOException, ServletException {\n \n         final HttpServletRequest httpRequest = (HttpServletRequest) request;\n-        logger.debug(\"Call security filter for: {}\", httpRequest.getRequestURI());\n+\n+        context.log(\"SecurityFilter is filtering \" + httpRequest.getRequestURI());","path":"src/main/java/org/jasig/cas/security/SecurityFilter.java","position":35,"original_position":35,"commit_id":"cc36e102e498b2417bec2fbe786fb7e6de86f637","original_commit_id":"cc36e102e498b2417bec2fbe786fb7e6de86f637","user":{"login":"apetro","id":952283,"avatar_url":"https://avatars.githubusercontent.com/u/952283?v=2","gravatar_id":"6b678c1cc265b5b91863a16cc48b2287","url":"https://api.github.com/users/apetro","html_url":"https://github.com/apetro","followers_url":"https://api.github.com/users/apetro/followers","following_url":"https://api.github.com/users/apetro/following{/other_user}","gists_url":"https://api.github.com/users/apetro/gists{/gist_id}","starred_url":"https://api.github.com/users/apetro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apetro/subscriptions","organizations_url":"https://api.github.com/users/apetro/orgs","repos_url":"https://api.github.com/users/apetro/repos","events_url":"https://api.github.com/users/apetro/events{/privacy}","received_events_url":"https://api.github.com/users/apetro/received_events","type":"User","site_admin":false},"body":"The existing unit test for `SecurityFilter` would need to be updated to provide a richer mock environment for this logging call not to `NullPointerException` out.","created_at":"2014-08-15T16:10:43Z","updated_at":"2014-08-15T16:10:43Z","html_url":"https://github.com/Jasig/cas-server-security-filter/pull/2#discussion_r16300307","pull_request_url":"https://api.github.com/repos/Jasig/cas-server-security-filter/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/Jasig/cas-server-security-filter/pulls/comments/16300307"},"html":{"href":"https://github.com/Jasig/cas-server-security-filter/pull/2#discussion_r16300307"},"pull_request":{"href":"https://api.github.com/repos/Jasig/cas-server-security-filter/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/Jasig/cas-server-security-filter/pulls/2","id":19737737,"html_url":"https://github.com/Jasig/cas-server-security-filter/pull/2","diff_url":"https://github.com/Jasig/cas-server-security-filter/pull/2.diff","patch_url":"https://github.com/Jasig/cas-server-security-filter/pull/2.patch","issue_url":"https://api.github.com/repos/Jasig/cas-server-security-filter/issues/2","number":2,"state":"open","locked":false,"title":"Eliminate slf4j dependency.","user":{"login":"apetro","id":952283,"avatar_url":"https://avatars.githubusercontent.com/u/952283?v=2","gravatar_id":"6b678c1cc265b5b91863a16cc48b2287","url":"https://api.github.com/users/apetro","html_url":"https://github.com/apetro","followers_url":"https://api.github.com/users/apetro/followers","following_url":"https://api.github.com/users/apetro/following{/other_user}","gists_url":"https://api.github.com/users/apetro/gists{/gist_id}","starred_url":"https://api.github.com/users/apetro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apetro/subscriptions","organizations_url":"https://api.github.com/users/apetro/orgs","repos_url":"https://api.github.com/users/apetro/repos","events_url":"https://api.github.com/users/apetro/events{/privacy}","received_events_url":"https://api.github.com/users/apetro/received_events","type":"User","site_admin":false},"body":"Eliminate dependency on `slf4j` in favor of using the mediocre logging capability afforded by the Servlet 2.5 API.\r\n\r\nThis results in logging that is less awesome but less complexity in getting this Filter to work in more environments, i.e. environments not currently providing `slf4j` implementation.\r\n\r\nIn the case where the Filter actually blocks a request, it throws an Exception, and that Exception will typically be logged by upstream code in a way noticeable to the administrator regardless of this Filter having only logged the blocking message to the ServletContext log.","created_at":"2014-08-13T17:02:24Z","updated_at":"2014-08-15T16:10:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86cbe6bb6ffbd2e90443473510f65797d3f463bd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Jasig/cas-server-security-filter/pulls/2/commits","review_comments_url":"https://api.github.com/repos/Jasig/cas-server-security-filter/pulls/2/comments","review_comment_url":"https://api.github.com/repos/Jasig/cas-server-security-filter/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Jasig/cas-server-security-filter/issues/2/comments","statuses_url":"https://api.github.com/repos/Jasig/cas-server-security-filter/statuses/cc36e102e498b2417bec2fbe786fb7e6de86f637","head":{"label":"apetro:drop_slf4j_dependency","ref":"drop_slf4j_dependency","sha":"cc36e102e498b2417bec2fbe786fb7e6de86f637","user":{"login":"apetro","id":952283,"avatar_url":"https://avatars.githubusercontent.com/u/952283?v=2","gravatar_id":"6b678c1cc265b5b91863a16cc48b2287","url":"https://api.github.com/users/apetro","html_url":"https://github.com/apetro","followers_url":"https://api.github.com/users/apetro/followers","following_url":"https://api.github.com/users/apetro/following{/other_user}","gists_url":"https://api.github.com/users/apetro/gists{/gist_id}","starred_url":"https://api.github.com/users/apetro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apetro/subscriptions","organizations_url":"https://api.github.com/users/apetro/orgs","repos_url":"https://api.github.com/users/apetro/repos","events_url":"https://api.github.com/users/apetro/events{/privacy}","received_events_url":"https://api.github.com/users/apetro/received_events","type":"User","site_admin":false},"repo":{"id":22922042,"name":"cas-server-security-filter","full_name":"apetro/cas-server-security-filter","owner":{"login":"apetro","id":952283,"avatar_url":"https://avatars.githubusercontent.com/u/952283?v=2","gravatar_id":"6b678c1cc265b5b91863a16cc48b2287","url":"https://api.github.com/users/apetro","html_url":"https://github.com/apetro","followers_url":"https://api.github.com/users/apetro/followers","following_url":"https://api.github.com/users/apetro/following{/other_user}","gists_url":"https://api.github.com/users/apetro/gists{/gist_id}","starred_url":"https://api.github.com/users/apetro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apetro/subscriptions","organizations_url":"https://api.github.com/users/apetro/orgs","repos_url":"https://api.github.com/users/apetro/repos","events_url":"https://api.github.com/users/apetro/events{/privacy}","received_events_url":"https://api.github.com/users/apetro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/apetro/cas-server-security-filter","description":"A security filter to protect the CAS server against HTTP attacks","fork":true,"url":"https://api.github.com/repos/apetro/cas-server-security-filter","forks_url":"https://api.github.com/repos/apetro/cas-server-security-filter/forks","keys_url":"https://api.github.com/repos/apetro/cas-server-security-filter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apetro/cas-server-security-filter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apetro/cas-server-security-filter/teams","hooks_url":"https://api.github.com/repos/apetro/cas-server-security-filter/hooks","issue_events_url":"https://api.github.com/repos/apetro/cas-server-security-filter/issues/events{/number}","events_url":"https://api.github.com/repos/apetro/cas-server-security-filter/events","assignees_url":"https://api.github.com/repos/apetro/cas-server-security-filter/assignees{/user}","branches_url":"https://api.github.com/repos/apetro/cas-server-security-filter/branches{/branch}","tags_url":"https://api.github.com/repos/apetro/cas-server-security-filter/tags","blobs_url":"https://api.github.com/repos/apetro/cas-server-security-filter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apetro/cas-server-security-filter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apetro/cas-server-security-filter/git/refs{/sha}","trees_url":"https://api.github.com/repos/apetro/cas-server-security-filter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apetro/cas-server-security-filter/statuses/{sha}","languages_url":"https://api.github.com/repos/apetro/cas-server-security-filter/languages","stargazers_url":"https://api.github.com/repos/apetro/cas-server-security-filter/stargazers","contributors_url":"https://api.github.com/repos/apetro/cas-server-security-filter/contributors","subscribers_url":"https://api.github.com/repos/apetro/cas-server-security-filter/subscribers","subscription_url":"https://api.github.com/repos/apetro/cas-server-security-filter/subscription","commits_url":"https://api.github.com/repos/apetro/cas-server-security-filter/commits{/sha}","git_commits_url":"https://api.github.com/repos/apetro/cas-server-security-filter/git/commits{/sha}","comments_url":"https://api.github.com/repos/apetro/cas-server-security-filter/comments{/number}","issue_comment_url":"https://api.github.com/repos/apetro/cas-server-security-filter/issues/comments/{number}","contents_url":"https://api.github.com/repos/apetro/cas-server-security-filter/contents/{+path}","compare_url":"https://api.github.com/repos/apetro/cas-server-security-filter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apetro/cas-server-security-filter/merges","archive_url":"https://api.github.com/repos/apetro/cas-server-security-filter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apetro/cas-server-security-filter/downloads","issues_url":"https://api.github.com/repos/apetro/cas-server-security-filter/issues{/number}","pulls_url":"https://api.github.com/repos/apetro/cas-server-security-filter/pulls{/number}","milestones_url":"https://api.github.com/repos/apetro/cas-server-security-filter/milestones{/number}","notifications_url":"https://api.github.com/repos/apetro/cas-server-security-filter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apetro/cas-server-security-filter/labels{/name}","releases_url":"https://api.github.com/repos/apetro/cas-server-security-filter/releases{/id}","created_at":"2014-08-13T16:09:21Z","updated_at":"2014-08-06T15:26:53Z","pushed_at":"2014-08-15T16:04:56Z","git_url":"git://github.com/apetro/cas-server-security-filter.git","ssh_url":"git@github.com:apetro/cas-server-security-filter.git","clone_url":"https://github.com/apetro/cas-server-security-filter.git","svn_url":"https://github.com/apetro/cas-server-security-filter","homepage":null,"size":209,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Jasig:master","ref":"master","sha":"83fdf1c0a2af7ace1e62a497df10e472888379e4","user":{"login":"Jasig","id":884285,"avatar_url":"https://avatars.githubusercontent.com/u/884285?v=2","gravatar_id":"f7c60710c8fb063302878546e4b7a3b5","url":"https://api.github.com/users/Jasig","html_url":"https://github.com/Jasig","followers_url":"https://api.github.com/users/Jasig/followers","following_url":"https://api.github.com/users/Jasig/following{/other_user}","gists_url":"https://api.github.com/users/Jasig/gists{/gist_id}","starred_url":"https://api.github.com/users/Jasig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jasig/subscriptions","organizations_url":"https://api.github.com/users/Jasig/orgs","repos_url":"https://api.github.com/users/Jasig/repos","events_url":"https://api.github.com/users/Jasig/events{/privacy}","received_events_url":"https://api.github.com/users/Jasig/received_events","type":"Organization","site_admin":false},"repo":{"id":22676825,"name":"cas-server-security-filter","full_name":"Jasig/cas-server-security-filter","owner":{"login":"Jasig","id":884285,"avatar_url":"https://avatars.githubusercontent.com/u/884285?v=2","gravatar_id":"f7c60710c8fb063302878546e4b7a3b5","url":"https://api.github.com/users/Jasig","html_url":"https://github.com/Jasig","followers_url":"https://api.github.com/users/Jasig/followers","following_url":"https://api.github.com/users/Jasig/following{/other_user}","gists_url":"https://api.github.com/users/Jasig/gists{/gist_id}","starred_url":"https://api.github.com/users/Jasig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jasig/subscriptions","organizations_url":"https://api.github.com/users/Jasig/orgs","repos_url":"https://api.github.com/users/Jasig/repos","events_url":"https://api.github.com/users/Jasig/events{/privacy}","received_events_url":"https://api.github.com/users/Jasig/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Jasig/cas-server-security-filter","description":"A security filter to protect the CAS server against HTTP attacks","fork":false,"url":"https://api.github.com/repos/Jasig/cas-server-security-filter","forks_url":"https://api.github.com/repos/Jasig/cas-server-security-filter/forks","keys_url":"https://api.github.com/repos/Jasig/cas-server-security-filter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Jasig/cas-server-security-filter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Jasig/cas-server-security-filter/teams","hooks_url":"https://api.github.com/repos/Jasig/cas-server-security-filter/hooks","issue_events_url":"https://api.github.com/repos/Jasig/cas-server-security-filter/issues/events{/number}","events_url":"https://api.github.com/repos/Jasig/cas-server-security-filter/events","assignees_url":"https://api.github.com/repos/Jasig/cas-server-security-filter/assignees{/user}","branches_url":"https://api.github.com/repos/Jasig/cas-server-security-filter/branches{/branch}","tags_url":"https://api.github.com/repos/Jasig/cas-server-security-filter/tags","blobs_url":"https://api.github.com/repos/Jasig/cas-server-security-filter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Jasig/cas-server-security-filter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Jasig/cas-server-security-filter/git/refs{/sha}","trees_url":"https://api.github.com/repos/Jasig/cas-server-security-filter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Jasig/cas-server-security-filter/statuses/{sha}","languages_url":"https://api.github.com/repos/Jasig/cas-server-security-filter/languages","stargazers_url":"https://api.github.com/repos/Jasig/cas-server-security-filter/stargazers","contributors_url":"https://api.github.com/repos/Jasig/cas-server-security-filter/contributors","subscribers_url":"https://api.github.com/repos/Jasig/cas-server-security-filter/subscribers","subscription_url":"https://api.github.com/repos/Jasig/cas-server-security-filter/subscription","commits_url":"https://api.github.com/repos/Jasig/cas-server-security-filter/commits{/sha}","git_commits_url":"https://api.github.com/repos/Jasig/cas-server-security-filter/git/commits{/sha}","comments_url":"https://api.github.com/repos/Jasig/cas-server-security-filter/comments{/number}","issue_comment_url":"https://api.github.com/repos/Jasig/cas-server-security-filter/issues/comments/{number}","contents_url":"https://api.github.com/repos/Jasig/cas-server-security-filter/contents/{+path}","compare_url":"https://api.github.com/repos/Jasig/cas-server-security-filter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Jasig/cas-server-security-filter/merges","archive_url":"https://api.github.com/repos/Jasig/cas-server-security-filter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Jasig/cas-server-security-filter/downloads","issues_url":"https://api.github.com/repos/Jasig/cas-server-security-filter/issues{/number}","pulls_url":"https://api.github.com/repos/Jasig/cas-server-security-filter/pulls{/number}","milestones_url":"https://api.github.com/repos/Jasig/cas-server-security-filter/milestones{/number}","notifications_url":"https://api.github.com/repos/Jasig/cas-server-security-filter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Jasig/cas-server-security-filter/labels{/name}","releases_url":"https://api.github.com/repos/Jasig/cas-server-security-filter/releases{/id}","created_at":"2014-08-06T09:15:53Z","updated_at":"2014-08-06T15:26:53Z","pushed_at":"2014-08-11T07:55:51Z","git_url":"git://github.com/Jasig/cas-server-security-filter.git","ssh_url":"git@github.com:Jasig/cas-server-security-filter.git","clone_url":"https://github.com/Jasig/cas-server-security-filter.git","svn_url":"https://github.com/Jasig/cas-server-security-filter","homepage":null,"size":209,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":2,"mirror_url":null,"open_issues_count":4,"forks":2,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Jasig/cas-server-security-filter/pulls/2"},"html":{"href":"https://github.com/Jasig/cas-server-security-filter/pull/2"},"issue":{"href":"https://api.github.com/repos/Jasig/cas-server-security-filter/issues/2"},"comments":{"href":"https://api.github.com/repos/Jasig/cas-server-security-filter/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/Jasig/cas-server-security-filter/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/Jasig/cas-server-security-filter/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Jasig/cas-server-security-filter/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/Jasig/cas-server-security-filter/statuses/cc36e102e498b2417bec2fbe786fb7e6de86f637"}}}}