GitHub PushEvent at 2014-05-17 01:35:04
Repository: haml-lint
Actor: causes-gerrit
Payload: {"shas":[["dd9b7ea55f940f5c96d0746d7b25000a33f5a124","6f6e68d1df92f30cb4b3ce35260ddf94a402f33d@causes.com","Fix source mapping for multi-line interpolation\n\nIf the code extracted from interpolation in a filter spanned multiple\nlines, the resulting source map would be incorrect due to it not taking\ninto consideration the additional lines (the code assumed only one line\ncould be added at a time).\n\nFix this by counting the number of newlines in the code and updating the\nsource map for each additional line to point to the original line that\ngenerated it.\n\nThis has a problem of not pointing to the original line in the HAML\nfile, e.g. for the following code:\n\n    :filter\n      Something\n      #{interpolation}\n\n...any lints reported in the interpolated code will be mapped to the\ncontaining `:filter`. To fix this comprehensively requires a fair amount\nof work and tests to ensure correctness, which I'm not interested in\npursuing at this time.\n\nChange-Id: I5037b6755fcdaae7b390641e91d8bf40fae8c191\nReviewed-on: http://gerrit.causes.com/38006\nTested-by: jenkins <jenkins@causes.com>\nReviewed-by: Shane da Silva <shane@causes.com>","Shane da Silva",true]],"size":1,"ref":"refs/heads/master","head":"dd9b7ea55f940f5c96d0746d7b25000a33f5a124"}