GitHub PullRequestReviewCommentEvent at 2014-09-17 21:21:14
Repository: ament_cmake
Actor: dirk-thomas
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/ament/ament_cmake/pulls/comments/17695149","id":17695149,"diff_hunk":"@@ -6,7 +6,7 @@ option(AMENT_CMAKE_ENVIRONMENT_PARENT_PREFIX_PATH_GENERATION\n   \"Generate marker file containing the parent prefix path\" ON)\n \n # set supported extensions based on platform\n-set(_non_windows_extensions \"bash\" \"sh\")\n+set(_non_windows_extensions \"zsh\" \"bash\" \"sh\")","path":"ament_cmake_environment/ament_cmake_environment-extras.cmake","position":5,"original_position":5,"commit_id":"46cf87c5448882f8ebcc3b7a292c60303c9960e8","original_commit_id":"46cf87c5448882f8ebcc3b7a292c60303c9960e8","user":{"login":"dirk-thomas","id":1335366,"avatar_url":"https://avatars.githubusercontent.com/u/1335366?v=2","gravatar_id":"00f79f6be5722ab3a1b3ece2cd32bb35","url":"https://api.github.com/users/dirk-thomas","html_url":"https://github.com/dirk-thomas","followers_url":"https://api.github.com/users/dirk-thomas/followers","following_url":"https://api.github.com/users/dirk-thomas/following{/other_user}","gists_url":"https://api.github.com/users/dirk-thomas/gists{/gist_id}","starred_url":"https://api.github.com/users/dirk-thomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirk-thomas/subscriptions","organizations_url":"https://api.github.com/users/dirk-thomas/orgs","repos_url":"https://api.github.com/users/dirk-thomas/repos","events_url":"https://api.github.com/users/dirk-thomas/events{/privacy}","received_events_url":"https://api.github.com/users/dirk-thomas/received_events","type":"User","site_admin":false},"body":"Can you please move `zsh` to the end for alphabetical order.","created_at":"2014-09-17T21:21:14Z","updated_at":"2014-09-17T21:21:14Z","html_url":"https://github.com/ament/ament_cmake/pull/1#discussion_r17695149","pull_request_url":"https://api.github.com/repos/ament/ament_cmake/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/ament/ament_cmake/pulls/comments/17695149"},"html":{"href":"https://github.com/ament/ament_cmake/pull/1#discussion_r17695149"},"pull_request":{"href":"https://api.github.com/repos/ament/ament_cmake/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/ament/ament_cmake/pulls/1","id":20928741,"html_url":"https://github.com/ament/ament_cmake/pull/1","diff_url":"https://github.com/ament/ament_cmake/pull/1.diff","patch_url":"https://github.com/ament/ament_cmake/pull/1.patch","issue_url":"https://api.github.com/repos/ament/ament_cmake/issues/1","number":1,"state":"open","locked":false,"title":"Fix for OS X, which does not support -printf in find","user":{"login":"wjwwood","id":100427,"avatar_url":"https://avatars.githubusercontent.com/u/100427?v=2","gravatar_id":"e9b7130c915ff71c0812d99ff927e929","url":"https://api.github.com/users/wjwwood","html_url":"https://github.com/wjwwood","followers_url":"https://api.github.com/users/wjwwood/followers","following_url":"https://api.github.com/users/wjwwood/following{/other_user}","gists_url":"https://api.github.com/users/wjwwood/gists{/gist_id}","starred_url":"https://api.github.com/users/wjwwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjwwood/subscriptions","organizations_url":"https://api.github.com/users/wjwwood/orgs","repos_url":"https://api.github.com/users/wjwwood/repos","events_url":"https://api.github.com/users/wjwwood/events{/privacy}","received_events_url":"https://api.github.com/users/wjwwood/received_events","type":"User","site_admin":false},"body":"OS X does not have `-printf` for the `find` command, so instead pipe through `xargs` and `basename` before sorting with `sort`.","created_at":"2014-09-09T01:12:29Z","updated_at":"2014-09-17T21:21:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d0ef9b6696555196827f84aca6ed24aaa8207790","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ament/ament_cmake/pulls/1/commits","review_comments_url":"https://api.github.com/repos/ament/ament_cmake/pulls/1/comments","review_comment_url":"https://api.github.com/repos/ament/ament_cmake/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ament/ament_cmake/issues/1/comments","statuses_url":"https://api.github.com/repos/ament/ament_cmake/statuses/46cf87c5448882f8ebcc3b7a292c60303c9960e8","head":{"label":"ament:fix_osx","ref":"fix_osx","sha":"46cf87c5448882f8ebcc3b7a292c60303c9960e8","user":{"login":"ament","id":7365061,"avatar_url":"https://avatars.githubusercontent.com/u/7365061?v=2","gravatar_id":null,"url":"https://api.github.com/users/ament","html_url":"https://github.com/ament","followers_url":"https://api.github.com/users/ament/followers","following_url":"https://api.github.com/users/ament/following{/other_user}","gists_url":"https://api.github.com/users/ament/gists{/gist_id}","starred_url":"https://api.github.com/users/ament/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ament/subscriptions","organizations_url":"https://api.github.com/users/ament/orgs","repos_url":"https://api.github.com/users/ament/repos","events_url":"https://api.github.com/users/ament/events{/privacy}","received_events_url":"https://api.github.com/users/ament/received_events","type":"Organization","site_admin":false},"repo":{"id":19872267,"name":"ament_cmake","full_name":"ament/ament_cmake","owner":{"login":"ament","id":7365061,"avatar_url":"https://avatars.githubusercontent.com/u/7365061?v=2","gravatar_id":null,"url":"https://api.github.com/users/ament","html_url":"https://github.com/ament","followers_url":"https://api.github.com/users/ament/followers","following_url":"https://api.github.com/users/ament/following{/other_user}","gists_url":"https://api.github.com/users/ament/gists{/gist_id}","starred_url":"https://api.github.com/users/ament/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ament/subscriptions","organizations_url":"https://api.github.com/users/ament/orgs","repos_url":"https://api.github.com/users/ament/repos","events_url":"https://api.github.com/users/ament/events{/privacy}","received_events_url":"https://api.github.com/users/ament/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ament/ament_cmake","description":"Supporting CMake packages for working with ament","fork":false,"url":"https://api.github.com/repos/ament/ament_cmake","forks_url":"https://api.github.com/repos/ament/ament_cmake/forks","keys_url":"https://api.github.com/repos/ament/ament_cmake/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ament/ament_cmake/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ament/ament_cmake/teams","hooks_url":"https://api.github.com/repos/ament/ament_cmake/hooks","issue_events_url":"https://api.github.com/repos/ament/ament_cmake/issues/events{/number}","events_url":"https://api.github.com/repos/ament/ament_cmake/events","assignees_url":"https://api.github.com/repos/ament/ament_cmake/assignees{/user}","branches_url":"https://api.github.com/repos/ament/ament_cmake/branches{/branch}","tags_url":"https://api.github.com/repos/ament/ament_cmake/tags","blobs_url":"https://api.github.com/repos/ament/ament_cmake/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ament/ament_cmake/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ament/ament_cmake/git/refs{/sha}","trees_url":"https://api.github.com/repos/ament/ament_cmake/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ament/ament_cmake/statuses/{sha}","languages_url":"https://api.github.com/repos/ament/ament_cmake/languages","stargazers_url":"https://api.github.com/repos/ament/ament_cmake/stargazers","contributors_url":"https://api.github.com/repos/ament/ament_cmake/contributors","subscribers_url":"https://api.github.com/repos/ament/ament_cmake/subscribers","subscription_url":"https://api.github.com/repos/ament/ament_cmake/subscription","commits_url":"https://api.github.com/repos/ament/ament_cmake/commits{/sha}","git_commits_url":"https://api.github.com/repos/ament/ament_cmake/git/commits{/sha}","comments_url":"https://api.github.com/repos/ament/ament_cmake/comments{/number}","issue_comment_url":"https://api.github.com/repos/ament/ament_cmake/issues/comments/{number}","contents_url":"https://api.github.com/repos/ament/ament_cmake/contents/{+path}","compare_url":"https://api.github.com/repos/ament/ament_cmake/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ament/ament_cmake/merges","archive_url":"https://api.github.com/repos/ament/ament_cmake/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ament/ament_cmake/downloads","issues_url":"https://api.github.com/repos/ament/ament_cmake/issues{/number}","pulls_url":"https://api.github.com/repos/ament/ament_cmake/pulls{/number}","milestones_url":"https://api.github.com/repos/ament/ament_cmake/milestones{/number}","notifications_url":"https://api.github.com/repos/ament/ament_cmake/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ament/ament_cmake/labels{/name}","releases_url":"https://api.github.com/repos/ament/ament_cmake/releases{/id}","created_at":"2014-05-16T22:13:54Z","updated_at":"2014-09-13T17:20:28Z","pushed_at":"2014-09-17T06:56:11Z","git_url":"git://github.com/ament/ament_cmake.git","ssh_url":"git@github.com:ament/ament_cmake.git","clone_url":"https://github.com/ament/ament_cmake.git","svn_url":"https://github.com/ament/ament_cmake","homepage":"","size":524,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"ament:master","ref":"master","sha":"52fb83c15e8f884e97e8945adbc1a0841204ce31","user":{"login":"ament","id":7365061,"avatar_url":"https://avatars.githubusercontent.com/u/7365061?v=2","gravatar_id":null,"url":"https://api.github.com/users/ament","html_url":"https://github.com/ament","followers_url":"https://api.github.com/users/ament/followers","following_url":"https://api.github.com/users/ament/following{/other_user}","gists_url":"https://api.github.com/users/ament/gists{/gist_id}","starred_url":"https://api.github.com/users/ament/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ament/subscriptions","organizations_url":"https://api.github.com/users/ament/orgs","repos_url":"https://api.github.com/users/ament/repos","events_url":"https://api.github.com/users/ament/events{/privacy}","received_events_url":"https://api.github.com/users/ament/received_events","type":"Organization","site_admin":false},"repo":{"id":19872267,"name":"ament_cmake","full_name":"ament/ament_cmake","owner":{"login":"ament","id":7365061,"avatar_url":"https://avatars.githubusercontent.com/u/7365061?v=2","gravatar_id":null,"url":"https://api.github.com/users/ament","html_url":"https://github.com/ament","followers_url":"https://api.github.com/users/ament/followers","following_url":"https://api.github.com/users/ament/following{/other_user}","gists_url":"https://api.github.com/users/ament/gists{/gist_id}","starred_url":"https://api.github.com/users/ament/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ament/subscriptions","organizations_url":"https://api.github.com/users/ament/orgs","repos_url":"https://api.github.com/users/ament/repos","events_url":"https://api.github.com/users/ament/events{/privacy}","received_events_url":"https://api.github.com/users/ament/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ament/ament_cmake","description":"Supporting CMake packages for working with ament","fork":false,"url":"https://api.github.com/repos/ament/ament_cmake","forks_url":"https://api.github.com/repos/ament/ament_cmake/forks","keys_url":"https://api.github.com/repos/ament/ament_cmake/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ament/ament_cmake/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ament/ament_cmake/teams","hooks_url":"https://api.github.com/repos/ament/ament_cmake/hooks","issue_events_url":"https://api.github.com/repos/ament/ament_cmake/issues/events{/number}","events_url":"https://api.github.com/repos/ament/ament_cmake/events","assignees_url":"https://api.github.com/repos/ament/ament_cmake/assignees{/user}","branches_url":"https://api.github.com/repos/ament/ament_cmake/branches{/branch}","tags_url":"https://api.github.com/repos/ament/ament_cmake/tags","blobs_url":"https://api.github.com/repos/ament/ament_cmake/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ament/ament_cmake/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ament/ament_cmake/git/refs{/sha}","trees_url":"https://api.github.com/repos/ament/ament_cmake/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ament/ament_cmake/statuses/{sha}","languages_url":"https://api.github.com/repos/ament/ament_cmake/languages","stargazers_url":"https://api.github.com/repos/ament/ament_cmake/stargazers","contributors_url":"https://api.github.com/repos/ament/ament_cmake/contributors","subscribers_url":"https://api.github.com/repos/ament/ament_cmake/subscribers","subscription_url":"https://api.github.com/repos/ament/ament_cmake/subscription","commits_url":"https://api.github.com/repos/ament/ament_cmake/commits{/sha}","git_commits_url":"https://api.github.com/repos/ament/ament_cmake/git/commits{/sha}","comments_url":"https://api.github.com/repos/ament/ament_cmake/comments{/number}","issue_comment_url":"https://api.github.com/repos/ament/ament_cmake/issues/comments/{number}","contents_url":"https://api.github.com/repos/ament/ament_cmake/contents/{+path}","compare_url":"https://api.github.com/repos/ament/ament_cmake/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ament/ament_cmake/merges","archive_url":"https://api.github.com/repos/ament/ament_cmake/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ament/ament_cmake/downloads","issues_url":"https://api.github.com/repos/ament/ament_cmake/issues{/number}","pulls_url":"https://api.github.com/repos/ament/ament_cmake/pulls{/number}","milestones_url":"https://api.github.com/repos/ament/ament_cmake/milestones{/number}","notifications_url":"https://api.github.com/repos/ament/ament_cmake/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ament/ament_cmake/labels{/name}","releases_url":"https://api.github.com/repos/ament/ament_cmake/releases{/id}","created_at":"2014-05-16T22:13:54Z","updated_at":"2014-09-13T17:20:28Z","pushed_at":"2014-09-17T06:56:11Z","git_url":"git://github.com/ament/ament_cmake.git","ssh_url":"git@github.com:ament/ament_cmake.git","clone_url":"https://github.com/ament/ament_cmake.git","svn_url":"https://github.com/ament/ament_cmake","homepage":"","size":524,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ament/ament_cmake/pulls/1"},"html":{"href":"https://github.com/ament/ament_cmake/pull/1"},"issue":{"href":"https://api.github.com/repos/ament/ament_cmake/issues/1"},"comments":{"href":"https://api.github.com/repos/ament/ament_cmake/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/ament/ament_cmake/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/ament/ament_cmake/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ament/ament_cmake/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/ament/ament_cmake/statuses/46cf87c5448882f8ebcc3b7a292c60303c9960e8"}}}}