GitHub PullRequestReviewCommentEvent at 2014-11-22 14:57:49
Repository: redis-py-cluster
Actor: Grokzen
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Grokzen/redis-py-cluster/pulls/comments/20757569","id":20757569,"diff_hunk":"@@ -318,3 +312,19 @@ def inner(*args, **kwargs):\n StrictClusterPipeline.sunion = block_pipeline_command(StrictRedis.sunion)\n StrictClusterPipeline.sunionstore = block_pipeline_command(StrictRedis.sunionstore)\n StrictClusterPipeline.pfmerge = block_pipeline_command(StrictRedis.pfmerge)\n+\n+\n+class Worker(threading.Thread):","path":"rediscluster/pipeline.py","position":81,"original_position":81,"commit_id":"e7ef237c2135581b57ef52b2ee13e83abfb20a28","original_commit_id":"e7ef237c2135581b57ef52b2ee13e83abfb20a28","user":{"login":"Grokzen","id":892309,"avatar_url":"https://avatars.githubusercontent.com/u/892309?v=3","gravatar_id":"","url":"https://api.github.com/users/Grokzen","html_url":"https://github.com/Grokzen","followers_url":"https://api.github.com/users/Grokzen/followers","following_url":"https://api.github.com/users/Grokzen/following{/other_user}","gists_url":"https://api.github.com/users/Grokzen/gists{/gist_id}","starred_url":"https://api.github.com/users/Grokzen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Grokzen/subscriptions","organizations_url":"https://api.github.com/users/Grokzen/orgs","repos_url":"https://api.github.com/users/Grokzen/repos","events_url":"https://api.github.com/users/Grokzen/events{/privacy}","received_events_url":"https://api.github.com/users/Grokzen/received_events","type":"User","site_admin":false},"body":"Please add some docstring here what the purpose of this worker class is.","created_at":"2014-11-22T14:57:49Z","updated_at":"2014-11-22T14:57:49Z","html_url":"https://github.com/Grokzen/redis-py-cluster/pull/51#discussion_r20757569","pull_request_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/pulls/51","_links":{"self":{"href":"https://api.github.com/repos/Grokzen/redis-py-cluster/pulls/comments/20757569"},"html":{"href":"https://github.com/Grokzen/redis-py-cluster/pull/51#discussion_r20757569"},"pull_request":{"href":"https://api.github.com/repos/Grokzen/redis-py-cluster/pulls/51"}}},"pull_request":{"url":"https://api.github.com/repos/Grokzen/redis-py-cluster/pulls/51","id":24885511,"html_url":"https://github.com/Grokzen/redis-py-cluster/pull/51","diff_url":"https://github.com/Grokzen/redis-py-cluster/pull/51.diff","patch_url":"https://github.com/Grokzen/redis-py-cluster/pull/51.patch","issue_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/issues/51","number":51,"state":"open","locked":false,"title":"threaded pipeline","user":{"login":"72squared","id":12319,"avatar_url":"https://avatars.githubusercontent.com/u/12319?v=3","gravatar_id":"","url":"https://api.github.com/users/72squared","html_url":"https://github.com/72squared","followers_url":"https://api.github.com/users/72squared/followers","following_url":"https://api.github.com/users/72squared/following{/other_user}","gists_url":"https://api.github.com/users/72squared/gists{/gist_id}","starred_url":"https://api.github.com/users/72squared/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/72squared/subscriptions","organizations_url":"https://api.github.com/users/72squared/orgs","repos_url":"https://api.github.com/users/72squared/repos","events_url":"https://api.github.com/users/72squared/events{/privacy}","received_events_url":"https://api.github.com/users/72squared/received_events","type":"User","site_admin":false},"body":"I was sloppy and committed this based on the assumption that you'll merge in unstable-eval. I can rebase and clean this up as needed but figured you'd want to get this asap so you can leave feedback.","created_at":"2014-11-22T07:29:07Z","updated_at":"2014-11-22T14:57:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dd3b7c8476fe973746f423052ba92c75c3899913","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/pulls/51/commits","review_comments_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/pulls/51/comments","review_comment_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/issues/51/comments","statuses_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/statuses/e7ef237c2135581b57ef52b2ee13e83abfb20a28","head":{"label":"happybits:unstable-pipe-thread","ref":"unstable-pipe-thread","sha":"e7ef237c2135581b57ef52b2ee13e83abfb20a28","user":{"login":"happybits","id":1930994,"avatar_url":"https://avatars.githubusercontent.com/u/1930994?v=3","gravatar_id":"","url":"https://api.github.com/users/happybits","html_url":"https://github.com/happybits","followers_url":"https://api.github.com/users/happybits/followers","following_url":"https://api.github.com/users/happybits/following{/other_user}","gists_url":"https://api.github.com/users/happybits/gists{/gist_id}","starred_url":"https://api.github.com/users/happybits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/happybits/subscriptions","organizations_url":"https://api.github.com/users/happybits/orgs","repos_url":"https://api.github.com/users/happybits/repos","events_url":"https://api.github.com/users/happybits/events{/privacy}","received_events_url":"https://api.github.com/users/happybits/received_events","type":"Organization","site_admin":false},"repo":{"id":21942860,"name":"redis-py-cluster","full_name":"happybits/redis-py-cluster","owner":{"login":"happybits","id":1930994,"avatar_url":"https://avatars.githubusercontent.com/u/1930994?v=3","gravatar_id":"","url":"https://api.github.com/users/happybits","html_url":"https://github.com/happybits","followers_url":"https://api.github.com/users/happybits/followers","following_url":"https://api.github.com/users/happybits/following{/other_user}","gists_url":"https://api.github.com/users/happybits/gists{/gist_id}","starred_url":"https://api.github.com/users/happybits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/happybits/subscriptions","organizations_url":"https://api.github.com/users/happybits/orgs","repos_url":"https://api.github.com/users/happybits/repos","events_url":"https://api.github.com/users/happybits/events{/privacy}","received_events_url":"https://api.github.com/users/happybits/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/happybits/redis-py-cluster","description":"Python cluster client for the official cluster support targeted for redis 3.0","fork":true,"url":"https://api.github.com/repos/happybits/redis-py-cluster","forks_url":"https://api.github.com/repos/happybits/redis-py-cluster/forks","keys_url":"https://api.github.com/repos/happybits/redis-py-cluster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/happybits/redis-py-cluster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/happybits/redis-py-cluster/teams","hooks_url":"https://api.github.com/repos/happybits/redis-py-cluster/hooks","issue_events_url":"https://api.github.com/repos/happybits/redis-py-cluster/issues/events{/number}","events_url":"https://api.github.com/repos/happybits/redis-py-cluster/events","assignees_url":"https://api.github.com/repos/happybits/redis-py-cluster/assignees{/user}","branches_url":"https://api.github.com/repos/happybits/redis-py-cluster/branches{/branch}","tags_url":"https://api.github.com/repos/happybits/redis-py-cluster/tags","blobs_url":"https://api.github.com/repos/happybits/redis-py-cluster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/happybits/redis-py-cluster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/happybits/redis-py-cluster/git/refs{/sha}","trees_url":"https://api.github.com/repos/happybits/redis-py-cluster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/happybits/redis-py-cluster/statuses/{sha}","languages_url":"https://api.github.com/repos/happybits/redis-py-cluster/languages","stargazers_url":"https://api.github.com/repos/happybits/redis-py-cluster/stargazers","contributors_url":"https://api.github.com/repos/happybits/redis-py-cluster/contributors","subscribers_url":"https://api.github.com/repos/happybits/redis-py-cluster/subscribers","subscription_url":"https://api.github.com/repos/happybits/redis-py-cluster/subscription","commits_url":"https://api.github.com/repos/happybits/redis-py-cluster/commits{/sha}","git_commits_url":"https://api.github.com/repos/happybits/redis-py-cluster/git/commits{/sha}","comments_url":"https://api.github.com/repos/happybits/redis-py-cluster/comments{/number}","issue_comment_url":"https://api.github.com/repos/happybits/redis-py-cluster/issues/comments/{number}","contents_url":"https://api.github.com/repos/happybits/redis-py-cluster/contents/{+path}","compare_url":"https://api.github.com/repos/happybits/redis-py-cluster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/happybits/redis-py-cluster/merges","archive_url":"https://api.github.com/repos/happybits/redis-py-cluster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/happybits/redis-py-cluster/downloads","issues_url":"https://api.github.com/repos/happybits/redis-py-cluster/issues{/number}","pulls_url":"https://api.github.com/repos/happybits/redis-py-cluster/pulls{/number}","milestones_url":"https://api.github.com/repos/happybits/redis-py-cluster/milestones{/number}","notifications_url":"https://api.github.com/repos/happybits/redis-py-cluster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/happybits/redis-py-cluster/labels{/name}","releases_url":"https://api.github.com/repos/happybits/redis-py-cluster/releases{/id}","created_at":"2014-07-17T13:27:42Z","updated_at":"2014-11-17T21:22:05Z","pushed_at":"2014-11-22T07:27:18Z","git_url":"git://github.com/happybits/redis-py-cluster.git","ssh_url":"git@github.com:happybits/redis-py-cluster.git","clone_url":"https://github.com/happybits/redis-py-cluster.git","svn_url":"https://github.com/happybits/redis-py-cluster","homepage":null,"size":906,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Grokzen:unstable","ref":"unstable","sha":"27f7ec5ef417c0665752a2ea9df2e8c9e1d3dd06","user":{"login":"Grokzen","id":892309,"avatar_url":"https://avatars.githubusercontent.com/u/892309?v=3","gravatar_id":"","url":"https://api.github.com/users/Grokzen","html_url":"https://github.com/Grokzen","followers_url":"https://api.github.com/users/Grokzen/followers","following_url":"https://api.github.com/users/Grokzen/following{/other_user}","gists_url":"https://api.github.com/users/Grokzen/gists{/gist_id}","starred_url":"https://api.github.com/users/Grokzen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Grokzen/subscriptions","organizations_url":"https://api.github.com/users/Grokzen/orgs","repos_url":"https://api.github.com/users/Grokzen/repos","events_url":"https://api.github.com/users/Grokzen/events{/privacy}","received_events_url":"https://api.github.com/users/Grokzen/received_events","type":"User","site_admin":false},"repo":{"id":10189555,"name":"redis-py-cluster","full_name":"Grokzen/redis-py-cluster","owner":{"login":"Grokzen","id":892309,"avatar_url":"https://avatars.githubusercontent.com/u/892309?v=3","gravatar_id":"","url":"https://api.github.com/users/Grokzen","html_url":"https://github.com/Grokzen","followers_url":"https://api.github.com/users/Grokzen/followers","following_url":"https://api.github.com/users/Grokzen/following{/other_user}","gists_url":"https://api.github.com/users/Grokzen/gists{/gist_id}","starred_url":"https://api.github.com/users/Grokzen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Grokzen/subscriptions","organizations_url":"https://api.github.com/users/Grokzen/orgs","repos_url":"https://api.github.com/users/Grokzen/repos","events_url":"https://api.github.com/users/Grokzen/events{/privacy}","received_events_url":"https://api.github.com/users/Grokzen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Grokzen/redis-py-cluster","description":"Python cluster client for the official cluster support targeted for redis 3.0","fork":false,"url":"https://api.github.com/repos/Grokzen/redis-py-cluster","forks_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/forks","keys_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/teams","hooks_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/hooks","issue_events_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/issues/events{/number}","events_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/events","assignees_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/assignees{/user}","branches_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/branches{/branch}","tags_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/tags","blobs_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/git/refs{/sha}","trees_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/statuses/{sha}","languages_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/languages","stargazers_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/stargazers","contributors_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/contributors","subscribers_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/subscribers","subscription_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/subscription","commits_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/commits{/sha}","git_commits_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/git/commits{/sha}","comments_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/comments{/number}","issue_comment_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/issues/comments/{number}","contents_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/contents/{+path}","compare_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/merges","archive_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/downloads","issues_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/issues{/number}","pulls_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/pulls{/number}","milestones_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/milestones{/number}","notifications_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/labels{/name}","releases_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/releases{/id}","created_at":"2013-05-21T06:41:34Z","updated_at":"2014-11-18T23:37:15Z","pushed_at":"2014-11-18T23:37:15Z","git_url":"git://github.com/Grokzen/redis-py-cluster.git","ssh_url":"git@github.com:Grokzen/redis-py-cluster.git","clone_url":"https://github.com/Grokzen/redis-py-cluster.git","svn_url":"https://github.com/Grokzen/redis-py-cluster","homepage":null,"size":1699,"stargazers_count":62,"watchers_count":62,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":10,"forks":17,"open_issues":10,"watchers":62,"default_branch":"unstable"}},"_links":{"self":{"href":"https://api.github.com/repos/Grokzen/redis-py-cluster/pulls/51"},"html":{"href":"https://github.com/Grokzen/redis-py-cluster/pull/51"},"issue":{"href":"https://api.github.com/repos/Grokzen/redis-py-cluster/issues/51"},"comments":{"href":"https://api.github.com/repos/Grokzen/redis-py-cluster/issues/51/comments"},"review_comments":{"href":"https://api.github.com/repos/Grokzen/redis-py-cluster/pulls/51/comments"},"review_comment":{"href":"https://api.github.com/repos/Grokzen/redis-py-cluster/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Grokzen/redis-py-cluster/pulls/51/commits"},"statuses":{"href":"https://api.github.com/repos/Grokzen/redis-py-cluster/statuses/e7ef237c2135581b57ef52b2ee13e83abfb20a28"}}}}