GitHub PullRequestEvent at 2014-11-06 17:03:07
Repository: PHP-ActiveRecord-Components
Actor: jstruzik
Payload: {"action":"opened","number":12,"pull_request":{"url":"https://api.github.com/repos/onemightyroar/PHP-ActiveRecord-Components/pulls/12","id":23995508,"html_url":"https://github.com/onemightyroar/PHP-ActiveRecord-Components/pull/12","diff_url":"https://github.com/onemightyroar/PHP-ActiveRecord-Components/pull/12.diff","patch_url":"https://github.com/onemightyroar/PHP-ActiveRecord-Components/pull/12.patch","issue_url":"https://api.github.com/repos/onemightyroar/PHP-ActiveRecord-Components/issues/12","number":12,"state":"open","locked":false,"title":"Bugfix - Updating the magical model isset method to check defined relationships","user":{"login":"jstruzik","id":3697804,"avatar_url":"https://avatars.githubusercontent.com/u/3697804?v=2","gravatar_id":"","url":"https://api.github.com/users/jstruzik","html_url":"https://github.com/jstruzik","followers_url":"https://api.github.com/users/jstruzik/followers","following_url":"https://api.github.com/users/jstruzik/following{/other_user}","gists_url":"https://api.github.com/users/jstruzik/gists{/gist_id}","starred_url":"https://api.github.com/users/jstruzik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jstruzik/subscriptions","organizations_url":"https://api.github.com/users/jstruzik/orgs","repos_url":"https://api.github.com/users/jstruzik/repos","events_url":"https://api.github.com/users/jstruzik/events{/privacy}","received_events_url":"https://api.github.com/users/jstruzik/received_events","type":"User","site_admin":false},"body":"I'm not sure if this is intended behavior, but it doesn't make sense to me to have a magical getter that will pickup a defined model relationship and not have the magical isset reflect that behavior.\r\n\r\nThis PR now makes the Model's `__isset()` function check for defined relationships as well.","created_at":"2014-11-06T17:03:06Z","updated_at":"2014-11-06T17:03:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/onemightyroar/PHP-ActiveRecord-Components/pulls/12/commits","review_comments_url":"https://api.github.com/repos/onemightyroar/PHP-ActiveRecord-Components/pulls/12/comments","review_comment_url":"https://api.github.com/repos/onemightyroar/PHP-ActiveRecord-Components/pulls/comments/{number}","comments_url":"https://api.github.com/repos/onemightyroar/PHP-ActiveRecord-Components/issues/12/comments","statuses_url":"https://api.github.com/repos/onemightyroar/PHP-ActiveRecord-Components/statuses/135b76b326da51e0c2daf73e323994eb7707accf","head":{"label":"jstruzik:bugfix/__isset-fix","ref":"bugfix/__isset-fix","sha":"135b76b326da51e0c2daf73e323994eb7707accf","user":{"login":"jstruzik","id":3697804,"avatar_url":"https://avatars.githubusercontent.com/u/3697804?v=2","gravatar_id":"","url":"https://api.github.com/users/jstruzik","html_url":"https://github.com/jstruzik","followers_url":"https://api.github.com/users/jstruzik/followers","following_url":"https://api.github.com/users/jstruzik/following{/other_user}","gists_url":"https://api.github.com/users/jstruzik/gists{/gist_id}","starred_url":"https://api.github.com/users/jstruzik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jstruzik/subscriptions","organizations_url":"https://api.github.com/users/jstruzik/orgs","repos_url":"https://api.github.com/users/jstruzik/repos","events_url":"https://api.github.com/users/jstruzik/events{/privacy}","received_events_url":"https://api.github.com/users/jstruzik/received_events","type":"User","site_admin":false},"repo":{"id":13930932,"name":"PHP-ActiveRecord-Components","full_name":"jstruzik/PHP-ActiveRecord-Components","owner":{"login":"jstruzik","id":3697804,"avatar_url":"https://avatars.githubusercontent.com/u/3697804?v=2","gravatar_id":"","url":"https://api.github.com/users/jstruzik","html_url":"https://github.com/jstruzik","followers_url":"https://api.github.com/users/jstruzik/followers","following_url":"https://api.github.com/users/jstruzik/following{/other_user}","gists_url":"https://api.github.com/users/jstruzik/gists{/gist_id}","starred_url":"https://api.github.com/users/jstruzik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jstruzik/subscriptions","organizations_url":"https://api.github.com/users/jstruzik/orgs","repos_url":"https://api.github.com/users/jstruzik/repos","events_url":"https://api.github.com/users/jstruzik/events{/privacy}","received_events_url":"https://api.github.com/users/jstruzik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jstruzik/PHP-ActiveRecord-Components","description":"","fork":true,"url":"https://api.github.com/repos/jstruzik/PHP-ActiveRecord-Components","forks_url":"https://api.github.com/repos/jstruzik/PHP-ActiveRecord-Components/forks","keys_url":"https://api.github.com/repos/jstruzik/PHP-ActiveRecord-Components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jstruzik/PHP-ActiveRecord-Components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jstruzik/PHP-ActiveRecord-Components/teams","hooks_url":"https://api.github.com/repos/jstruzik/PHP-ActiveRecord-Components/hooks","issue_events_url":"https://api.github.com/repos/jstruzik/PHP-ActiveRecord-Components/issues/events{/number}","events_url":"https://api.github.com/repos/jstruzik/PHP-ActiveRecord-Components/events","assignees_url":"https://api.github.com/repos/jstruzik/PHP-ActiveRecord-Components/assignees{/user}","branches_url":"https://api.github.com/repos/jstruzik/PHP-ActiveRecord-Components/branches{/branch}","tags_url":"https://api.github.com/repos/jstruzik/PHP-ActiveRecord-Components/tags","blobs_url":"https://api.github.com/repos/jstruzik/PHP-ActiveRecord-Components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jstruzik/PHP-ActiveRecord-Components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jstruzik/PHP-ActiveRecord-Components/git/refs{/sha}","trees_url":"https://api.github.com/repos/jstruzik/PHP-ActiveRecord-Components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jstruzik/PHP-ActiveRecord-Components/statuses/{sha}","languages_url":"https://api.github.com/repos/jstruzik/PHP-ActiveRecord-Components/languages","stargazers_url":"https://api.github.com/repos/jstruzik/PHP-ActiveRecord-Components/stargazers","contributors_url":"https://api.github.com/repos/jstruzik/PHP-ActiveRecord-Components/contributors","subscribers_url":"https://api.github.com/repos/jstruzik/PHP-ActiveRecord-Components/subscribers","subscription_url":"https://api.github.com/repos/jstruzik/PHP-ActiveRecord-Components/subscription","commits_url":"https://api.github.com/repos/jstruzik/PHP-ActiveRecord-Components/commits{/sha}","git_commits_url":"https://api.github.com/repos/jstruzik/PHP-ActiveRecord-Components/git/commits{/sha}","comments_url":"https://api.github.com/repos/jstruzik/PHP-ActiveRecord-Components/comments{/number}","issue_comment_url":"https://api.github.com/repos/jstruzik/PHP-ActiveRecord-Components/issues/comments/{number}","contents_url":"https://api.github.com/repos/jstruzik/PHP-ActiveRecord-Components/contents/{+path}","compare_url":"https://api.github.com/repos/jstruzik/PHP-ActiveRecord-Components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jstruzik/PHP-ActiveRecord-Components/merges","archive_url":"https://api.github.com/repos/jstruzik/PHP-ActiveRecord-Components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jstruzik/PHP-ActiveRecord-Components/downloads","issues_url":"https://api.github.com/repos/jstruzik/PHP-ActiveRecord-Components/issues{/number}","pulls_url":"https://api.github.com/repos/jstruzik/PHP-ActiveRecord-Components/pulls{/number}","milestones_url":"https://api.github.com/repos/jstruzik/PHP-ActiveRecord-Components/milestones{/number}","notifications_url":"https://api.github.com/repos/jstruzik/PHP-ActiveRecord-Components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jstruzik/PHP-ActiveRecord-Components/labels{/name}","releases_url":"https://api.github.com/repos/jstruzik/PHP-ActiveRecord-Components/releases{/id}","created_at":"2013-10-28T16:08:26Z","updated_at":"2013-10-28T19:36:44Z","pushed_at":"2014-11-06T17:01:17Z","git_url":"git://github.com/jstruzik/PHP-ActiveRecord-Components.git","ssh_url":"git@github.com:jstruzik/PHP-ActiveRecord-Components.git","clone_url":"https://github.com/jstruzik/PHP-ActiveRecord-Components.git","svn_url":"https://github.com/jstruzik/PHP-ActiveRecord-Components","homepage":null,"size":118,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"onemightyroar:master","ref":"master","sha":"55be667e026a473d2df4169c0ebf0632fb8ce3a0","user":{"login":"onemightyroar","id":445001,"avatar_url":"https://avatars.githubusercontent.com/u/445001?v=2","gravatar_id":"","url":"https://api.github.com/users/onemightyroar","html_url":"https://github.com/onemightyroar","followers_url":"https://api.github.com/users/onemightyroar/followers","following_url":"https://api.github.com/users/onemightyroar/following{/other_user}","gists_url":"https://api.github.com/users/onemightyroar/gists{/gist_id}","starred_url":"https://api.github.com/users/onemightyroar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onemightyroar/subscriptions","organizations_url":"https://api.github.com/users/onemightyroar/orgs","repos_url":"https://api.github.com/users/onemightyroar/repos","events_url":"https://api.github.com/users/onemightyroar/events{/privacy}","received_events_url":"https://api.github.com/users/onemightyroar/received_events","type":"Organization","site_admin":false},"repo":{"id":9220784,"name":"PHP-ActiveRecord-Components","full_name":"onemightyroar/PHP-ActiveRecord-Components","owner":{"login":"onemightyroar","id":445001,"avatar_url":"https://avatars.githubusercontent.com/u/445001?v=2","gravatar_id":"","url":"https://api.github.com/users/onemightyroar","html_url":"https://github.com/onemightyroar","followers_url":"https://api.github.com/users/onemightyroar/followers","following_url":"https://api.github.com/users/onemightyroar/following{/other_user}","gists_url":"https://api.github.com/users/onemightyroar/gists{/gist_id}","starred_url":"https://api.github.com/users/onemightyroar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onemightyroar/subscriptions","organizations_url":"https://api.github.com/users/onemightyroar/orgs","repos_url":"https://api.github.com/users/onemightyroar/repos","events_url":"https://api.github.com/users/onemightyroar/events{/privacy}","received_events_url":"https://api.github.com/users/onemightyroar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/onemightyroar/PHP-ActiveRecord-Components","description":"","fork":false,"url":"https://api.github.com/repos/onemightyroar/PHP-ActiveRecord-Components","forks_url":"https://api.github.com/repos/onemightyroar/PHP-ActiveRecord-Components/forks","keys_url":"https://api.github.com/repos/onemightyroar/PHP-ActiveRecord-Components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/onemightyroar/PHP-ActiveRecord-Components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/onemightyroar/PHP-ActiveRecord-Components/teams","hooks_url":"https://api.github.com/repos/onemightyroar/PHP-ActiveRecord-Components/hooks","issue_events_url":"https://api.github.com/repos/onemightyroar/PHP-ActiveRecord-Components/issues/events{/number}","events_url":"https://api.github.com/repos/onemightyroar/PHP-ActiveRecord-Components/events","assignees_url":"https://api.github.com/repos/onemightyroar/PHP-ActiveRecord-Components/assignees{/user}","branches_url":"https://api.github.com/repos/onemightyroar/PHP-ActiveRecord-Components/branches{/branch}","tags_url":"https://api.github.com/repos/onemightyroar/PHP-ActiveRecord-Components/tags","blobs_url":"https://api.github.com/repos/onemightyroar/PHP-ActiveRecord-Components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/onemightyroar/PHP-ActiveRecord-Components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/onemightyroar/PHP-ActiveRecord-Components/git/refs{/sha}","trees_url":"https://api.github.com/repos/onemightyroar/PHP-ActiveRecord-Components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/onemightyroar/PHP-ActiveRecord-Components/statuses/{sha}","languages_url":"https://api.github.com/repos/onemightyroar/PHP-ActiveRecord-Components/languages","stargazers_url":"https://api.github.com/repos/onemightyroar/PHP-ActiveRecord-Components/stargazers","contributors_url":"https://api.github.com/repos/onemightyroar/PHP-ActiveRecord-Components/contributors","subscribers_url":"https://api.github.com/repos/onemightyroar/PHP-ActiveRecord-Components/subscribers","subscription_url":"https://api.github.com/repos/onemightyroar/PHP-ActiveRecord-Components/subscription","commits_url":"https://api.github.com/repos/onemightyroar/PHP-ActiveRecord-Components/commits{/sha}","git_commits_url":"https://api.github.com/repos/onemightyroar/PHP-ActiveRecord-Components/git/commits{/sha}","comments_url":"https://api.github.com/repos/onemightyroar/PHP-ActiveRecord-Components/comments{/number}","issue_comment_url":"https://api.github.com/repos/onemightyroar/PHP-ActiveRecord-Components/issues/comments/{number}","contents_url":"https://api.github.com/repos/onemightyroar/PHP-ActiveRecord-Components/contents/{+path}","compare_url":"https://api.github.com/repos/onemightyroar/PHP-ActiveRecord-Components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/onemightyroar/PHP-ActiveRecord-Components/merges","archive_url":"https://api.github.com/repos/onemightyroar/PHP-ActiveRecord-Components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/onemightyroar/PHP-ActiveRecord-Components/downloads","issues_url":"https://api.github.com/repos/onemightyroar/PHP-ActiveRecord-Components/issues{/number}","pulls_url":"https://api.github.com/repos/onemightyroar/PHP-ActiveRecord-Components/pulls{/number}","milestones_url":"https://api.github.com/repos/onemightyroar/PHP-ActiveRecord-Components/milestones{/number}","notifications_url":"https://api.github.com/repos/onemightyroar/PHP-ActiveRecord-Components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/onemightyroar/PHP-ActiveRecord-Components/labels{/name}","releases_url":"https://api.github.com/repos/onemightyroar/PHP-ActiveRecord-Components/releases{/id}","created_at":"2013-04-04T15:02:40Z","updated_at":"2014-10-08T17:14:58Z","pushed_at":"2014-10-15T16:33:35Z","git_url":"git://github.com/onemightyroar/PHP-ActiveRecord-Components.git","ssh_url":"git@github.com:onemightyroar/PHP-ActiveRecord-Components.git","clone_url":"https://github.com/onemightyroar/PHP-ActiveRecord-Components.git","svn_url":"https://github.com/onemightyroar/PHP-ActiveRecord-Components","homepage":null,"size":420,"stargazers_count":8,"watchers_count":8,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/onemightyroar/PHP-ActiveRecord-Components/pulls/12"},"html":{"href":"https://github.com/onemightyroar/PHP-ActiveRecord-Components/pull/12"},"issue":{"href":"https://api.github.com/repos/onemightyroar/PHP-ActiveRecord-Components/issues/12"},"comments":{"href":"https://api.github.com/repos/onemightyroar/PHP-ActiveRecord-Components/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/onemightyroar/PHP-ActiveRecord-Components/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/onemightyroar/PHP-ActiveRecord-Components/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/onemightyroar/PHP-ActiveRecord-Components/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/onemightyroar/PHP-ActiveRecord-Components/statuses/135b76b326da51e0c2daf73e323994eb7707accf"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":18,"deletions":0,"changed_files":1}}