GitHub PullRequestReviewCommentEvent at 2014-06-09 15:10:39
Repository: akka
Actor: jboner
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/spray/akka/pulls/comments/13545212","id":13545212,"diff_hunk":"@@ -0,0 +1,34 @@\n+/**\n+ * Copyright (C) 2009-2014 Typesafe Inc. <http://www.typesafe.com>\n+ */\n+\n+package akka.http.model.japi;\n+\n+import akka.util.ByteString;\n+\n+/**\n+ * Represents part of a stream of incoming data for `Transfer-Encoding: chunked` messages.\n+ */\n+public abstract class ChunkStreamPart {\n+    /**\n+     * Returns the byte data of this chunk. Will be non-empty for every regular\n+     * chunk. Will be empty for the last chunk.\n+     */\n+    public abstract ByteString data();","path":"akka-http-core/src/main/java/akka/http/model/japi/ChunkStreamPart.java","position":17,"original_position":17,"commit_id":"685fa37abe5cfd8ca6451803384580319d56ef59","original_commit_id":"685fa37abe5cfd8ca6451803384580319d56ef59","user":{"login":"jboner","id":10701,"avatar_url":"https://avatars.githubusercontent.com/u/10701?","gravatar_id":"e0b5787d1a1935a2800e0bbffc81c196","url":"https://api.github.com/users/jboner","html_url":"https://github.com/jboner","followers_url":"https://api.github.com/users/jboner/followers","following_url":"https://api.github.com/users/jboner/following{/other_user}","gists_url":"https://api.github.com/users/jboner/gists{/gist_id}","starred_url":"https://api.github.com/users/jboner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jboner/subscriptions","organizations_url":"https://api.github.com/users/jboner/orgs","repos_url":"https://api.github.com/users/jboner/repos","events_url":"https://api.github.com/users/jboner/events{/privacy}","received_events_url":"https://api.github.com/users/jboner/received_events","type":"User","site_admin":false},"body":"Why reuse Scala identifiers? To make it easier for us or for the user?","created_at":"2014-06-09T15:10:39Z","updated_at":"2014-06-09T15:10:39Z","html_url":"https://github.com/spray/akka/pull/1#discussion_r13545212","pull_request_url":"https://api.github.com/repos/spray/akka/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/spray/akka/pulls/comments/13545212"},"html":{"href":"https://github.com/spray/akka/pull/1#discussion_r13545212"},"pull_request":{"href":"https://api.github.com/repos/spray/akka/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/spray/akka/pulls/1","id":16268378,"html_url":"https://github.com/spray/akka/pull/1","diff_url":"https://github.com/spray/akka/pull/1.diff","patch_url":"https://github.com/spray/akka/pull/1.patch","issue_url":"https://api.github.com/repos/spray/akka/issues/1","number":1,"state":"open","title":"Java Http Model","user":{"login":"jrudolph","id":9868,"avatar_url":"https://avatars.githubusercontent.com/u/9868?","gravatar_id":"64f6e19203e7846687b256f2ae4b6b0d","url":"https://api.github.com/users/jrudolph","html_url":"https://github.com/jrudolph","followers_url":"https://api.github.com/users/jrudolph/followers","following_url":"https://api.github.com/users/jrudolph/following{/other_user}","gists_url":"https://api.github.com/users/jrudolph/gists{/gist_id}","starred_url":"https://api.github.com/users/jrudolph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrudolph/subscriptions","organizations_url":"https://api.github.com/users/jrudolph/orgs","repos_url":"https://api.github.com/users/jrudolph/repos","events_url":"https://api.github.com/users/jrudolph/events{/privacy}","received_events_url":"https://api.github.com/users/jrudolph/received_events","type":"User","site_admin":false},"body":"Follow-up to typesafehub/akka-streams#66 based on Mathias' latest version. Alone because of the sheer amount of classes I'm pretty sure there are some rough edges left. So, please be rigorous. \r\n\r\n(It seems this PR has to live in the spray/akka repository as long as its base is also living there.)","created_at":"2014-05-23T11:21:29Z","updated_at":"2014-06-09T15:10:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"153316d805a0a847652be194b0d141c125f618c2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/spray/akka/pulls/1/commits","review_comments_url":"https://api.github.com/repos/spray/akka/pulls/1/comments","review_comment_url":"https://api.github.com/repos/spray/akka/pulls/comments/{number}","comments_url":"https://api.github.com/repos/spray/akka/issues/1/comments","statuses_url":"https://api.github.com/repos/spray/akka/statuses/685fa37abe5cfd8ca6451803384580319d56ef59","head":{"label":"spray:w/http-model-java-3.2-dev-squashed","ref":"w/http-model-java-3.2-dev-squashed","sha":"685fa37abe5cfd8ca6451803384580319d56ef59","user":{"login":"spray","id":688516,"avatar_url":"https://avatars.githubusercontent.com/u/688516?","gravatar_id":"569910d257f4dca232c1c7fb29c100f0","url":"https://api.github.com/users/spray","html_url":"https://github.com/spray","followers_url":"https://api.github.com/users/spray/followers","following_url":"https://api.github.com/users/spray/following{/other_user}","gists_url":"https://api.github.com/users/spray/gists{/gist_id}","starred_url":"https://api.github.com/users/spray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spray/subscriptions","organizations_url":"https://api.github.com/users/spray/orgs","repos_url":"https://api.github.com/users/spray/repos","events_url":"https://api.github.com/users/spray/events{/privacy}","received_events_url":"https://api.github.com/users/spray/received_events","type":"Organization","site_admin":false},"repo":{"id":3809985,"name":"akka","full_name":"spray/akka","owner":{"login":"spray","id":688516,"avatar_url":"https://avatars.githubusercontent.com/u/688516?","gravatar_id":"569910d257f4dca232c1c7fb29c100f0","url":"https://api.github.com/users/spray","html_url":"https://github.com/spray","followers_url":"https://api.github.com/users/spray/followers","following_url":"https://api.github.com/users/spray/following{/other_user}","gists_url":"https://api.github.com/users/spray/gists{/gist_id}","starred_url":"https://api.github.com/users/spray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spray/subscriptions","organizations_url":"https://api.github.com/users/spray/orgs","repos_url":"https://api.github.com/users/spray/repos","events_url":"https://api.github.com/users/spray/events{/privacy}","received_events_url":"https://api.github.com/users/spray/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spray/akka","description":"Akka Project","fork":true,"url":"https://api.github.com/repos/spray/akka","forks_url":"https://api.github.com/repos/spray/akka/forks","keys_url":"https://api.github.com/repos/spray/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spray/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spray/akka/teams","hooks_url":"https://api.github.com/repos/spray/akka/hooks","issue_events_url":"https://api.github.com/repos/spray/akka/issues/events{/number}","events_url":"https://api.github.com/repos/spray/akka/events","assignees_url":"https://api.github.com/repos/spray/akka/assignees{/user}","branches_url":"https://api.github.com/repos/spray/akka/branches{/branch}","tags_url":"https://api.github.com/repos/spray/akka/tags","blobs_url":"https://api.github.com/repos/spray/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spray/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spray/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/spray/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spray/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/spray/akka/languages","stargazers_url":"https://api.github.com/repos/spray/akka/stargazers","contributors_url":"https://api.github.com/repos/spray/akka/contributors","subscribers_url":"https://api.github.com/repos/spray/akka/subscribers","subscription_url":"https://api.github.com/repos/spray/akka/subscription","commits_url":"https://api.github.com/repos/spray/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/spray/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/spray/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/spray/akka/issues/comments/{number}","contents_url":"https://api.github.com/repos/spray/akka/contents/{+path}","compare_url":"https://api.github.com/repos/spray/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spray/akka/merges","archive_url":"https://api.github.com/repos/spray/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spray/akka/downloads","issues_url":"https://api.github.com/repos/spray/akka/issues{/number}","pulls_url":"https://api.github.com/repos/spray/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/spray/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/spray/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spray/akka/labels{/name}","releases_url":"https://api.github.com/repos/spray/akka/releases{/id}","created_at":"2012-03-23T15:57:31Z","updated_at":"2014-06-09T13:51:53Z","pushed_at":"2014-06-05T14:51:35Z","git_url":"git://github.com/spray/akka.git","ssh_url":"git@github.com:spray/akka.git","clone_url":"https://github.com/spray/akka.git","svn_url":"https://github.com/spray/akka","homepage":"http://akka.io","size":151117,"stargazers_count":3,"watchers_count":3,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":3,"default_branch":"master"}},"base":{"label":"spray:waves/release-2.3-dev","ref":"waves/release-2.3-dev","sha":"53d43846c15969f9e5d36e94570f1fdb6e5bca7d","user":{"login":"spray","id":688516,"avatar_url":"https://avatars.githubusercontent.com/u/688516?","gravatar_id":"569910d257f4dca232c1c7fb29c100f0","url":"https://api.github.com/users/spray","html_url":"https://github.com/spray","followers_url":"https://api.github.com/users/spray/followers","following_url":"https://api.github.com/users/spray/following{/other_user}","gists_url":"https://api.github.com/users/spray/gists{/gist_id}","starred_url":"https://api.github.com/users/spray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spray/subscriptions","organizations_url":"https://api.github.com/users/spray/orgs","repos_url":"https://api.github.com/users/spray/repos","events_url":"https://api.github.com/users/spray/events{/privacy}","received_events_url":"https://api.github.com/users/spray/received_events","type":"Organization","site_admin":false},"repo":{"id":3809985,"name":"akka","full_name":"spray/akka","owner":{"login":"spray","id":688516,"avatar_url":"https://avatars.githubusercontent.com/u/688516?","gravatar_id":"569910d257f4dca232c1c7fb29c100f0","url":"https://api.github.com/users/spray","html_url":"https://github.com/spray","followers_url":"https://api.github.com/users/spray/followers","following_url":"https://api.github.com/users/spray/following{/other_user}","gists_url":"https://api.github.com/users/spray/gists{/gist_id}","starred_url":"https://api.github.com/users/spray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spray/subscriptions","organizations_url":"https://api.github.com/users/spray/orgs","repos_url":"https://api.github.com/users/spray/repos","events_url":"https://api.github.com/users/spray/events{/privacy}","received_events_url":"https://api.github.com/users/spray/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spray/akka","description":"Akka Project","fork":true,"url":"https://api.github.com/repos/spray/akka","forks_url":"https://api.github.com/repos/spray/akka/forks","keys_url":"https://api.github.com/repos/spray/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spray/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spray/akka/teams","hooks_url":"https://api.github.com/repos/spray/akka/hooks","issue_events_url":"https://api.github.com/repos/spray/akka/issues/events{/number}","events_url":"https://api.github.com/repos/spray/akka/events","assignees_url":"https://api.github.com/repos/spray/akka/assignees{/user}","branches_url":"https://api.github.com/repos/spray/akka/branches{/branch}","tags_url":"https://api.github.com/repos/spray/akka/tags","blobs_url":"https://api.github.com/repos/spray/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spray/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spray/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/spray/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spray/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/spray/akka/languages","stargazers_url":"https://api.github.com/repos/spray/akka/stargazers","contributors_url":"https://api.github.com/repos/spray/akka/contributors","subscribers_url":"https://api.github.com/repos/spray/akka/subscribers","subscription_url":"https://api.github.com/repos/spray/akka/subscription","commits_url":"https://api.github.com/repos/spray/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/spray/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/spray/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/spray/akka/issues/comments/{number}","contents_url":"https://api.github.com/repos/spray/akka/contents/{+path}","compare_url":"https://api.github.com/repos/spray/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spray/akka/merges","archive_url":"https://api.github.com/repos/spray/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spray/akka/downloads","issues_url":"https://api.github.com/repos/spray/akka/issues{/number}","pulls_url":"https://api.github.com/repos/spray/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/spray/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/spray/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spray/akka/labels{/name}","releases_url":"https://api.github.com/repos/spray/akka/releases{/id}","created_at":"2012-03-23T15:57:31Z","updated_at":"2014-06-09T13:51:53Z","pushed_at":"2014-06-05T14:51:35Z","git_url":"git://github.com/spray/akka.git","ssh_url":"git@github.com:spray/akka.git","clone_url":"https://github.com/spray/akka.git","svn_url":"https://github.com/spray/akka","homepage":"http://akka.io","size":151117,"stargazers_count":3,"watchers_count":3,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spray/akka/pulls/1"},"html":{"href":"https://github.com/spray/akka/pull/1"},"issue":{"href":"https://api.github.com/repos/spray/akka/issues/1"},"comments":{"href":"https://api.github.com/repos/spray/akka/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/spray/akka/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/spray/akka/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/spray/akka/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/spray/akka/statuses/685fa37abe5cfd8ca6451803384580319d56ef59"}}}}