GitHub PullRequestReviewCommentEvent at 2014-12-16 19:36:58
Repository: puppetdb
Actor: senior
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/comments/21925234","id":21925234,"diff_hunk":"@@ -164,15 +163,11 @@\n     (assoc config :read-database db-config)))\n \n (defn default-node-ttl\n-  \"Assoc into `db-config` a :node-ttl when not already present. Default to node-ttl-days, if that's not there,\n-   use 0 seconds\"\n+  \"If `db-config` has no node-ttl value, add one with a value of 0 seconds.\"\n   [db-config]\n-  (dissoc (if (:node-ttl db-config)\n-            db-config\n-            (-> db-config\n-                (assoc :node-ttl (or (maybe-days (:node-ttl-days db-config))\n-                                     (pl-time/parse-period \"0s\")))))\n-          :node-ttl-days))\n+  (if (:node-ttl db-config)","path":"src/puppetlabs/puppetdb/config.clj","position":24,"original_position":24,"commit_id":"3f90bd2f54ad7b6dce0b8abc968f585fad0b599c","original_commit_id":"3f90bd2f54ad7b6dce0b8abc968f585fad0b599c","user":{"login":"senior","id":215910,"avatar_url":"https://avatars.githubusercontent.com/u/215910?v=3","gravatar_id":"","url":"https://api.github.com/users/senior","html_url":"https://github.com/senior","followers_url":"https://api.github.com/users/senior/followers","following_url":"https://api.github.com/users/senior/following{/other_user}","gists_url":"https://api.github.com/users/senior/gists{/gist_id}","starred_url":"https://api.github.com/users/senior/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/senior/subscriptions","organizations_url":"https://api.github.com/users/senior/orgs","repos_url":"https://api.github.com/users/senior/repos","events_url":"https://api.github.com/users/senior/events{/privacy}","received_events_url":"https://api.github.com/users/senior/received_events","type":"User","site_admin":false},"body":"I think you can remove this function completely if you change node-ttl to be a (pls/defaulted-maybe \"0s\"). That previously wasn't possible with node-ttl-days as possibly providing a value.","created_at":"2014-12-16T19:36:58Z","updated_at":"2014-12-16T19:36:58Z","html_url":"https://github.com/puppetlabs/puppetdb/pull/1173#discussion_r21925234","pull_request_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1173","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/comments/21925234"},"html":{"href":"https://github.com/puppetlabs/puppetdb/pull/1173#discussion_r21925234"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1173"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1173","id":25706298,"html_url":"https://github.com/puppetlabs/puppetdb/pull/1173","diff_url":"https://github.com/puppetlabs/puppetdb/pull/1173.diff","patch_url":"https://github.com/puppetlabs/puppetdb/pull/1173.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/1173","number":1173,"state":"open","locked":false,"title":"(PDB-644) Retire node-ttl-days","user":{"login":"rbrw","id":10120698,"avatar_url":"https://avatars.githubusercontent.com/u/10120698?v=3","gravatar_id":"","url":"https://api.github.com/users/rbrw","html_url":"https://github.com/rbrw","followers_url":"https://api.github.com/users/rbrw/followers","following_url":"https://api.github.com/users/rbrw/following{/other_user}","gists_url":"https://api.github.com/users/rbrw/gists{/gist_id}","starred_url":"https://api.github.com/users/rbrw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbrw/subscriptions","organizations_url":"https://api.github.com/users/rbrw/orgs","repos_url":"https://api.github.com/users/rbrw/repos","events_url":"https://api.github.com/users/rbrw/events{/privacy}","received_events_url":"https://api.github.com/users/rbrw/received_events","type":"User","site_admin":false},"body":"Throw an IllegalArgumentException if the DB config contains a\r\n:node-ttl-days option.\r\n\r\nRemove all of the other code/tests affiliated with :node-ttl-days.","created_at":"2014-12-08T23:17:57Z","updated_at":"2014-12-16T19:36:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2b10c9140cba899560ecddc27f9694b3071fa630","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1173/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1173/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/comments/{number}","comments_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/1173/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppetdb/statuses/3f90bd2f54ad7b6dce0b8abc968f585fad0b599c","head":{"label":"rbrw:ticket/master/pdb-644-retire-node-ttl-days","ref":"ticket/master/pdb-644-retire-node-ttl-days","sha":"3f90bd2f54ad7b6dce0b8abc968f585fad0b599c","user":{"login":"rbrw","id":10120698,"avatar_url":"https://avatars.githubusercontent.com/u/10120698?v=3","gravatar_id":"","url":"https://api.github.com/users/rbrw","html_url":"https://github.com/rbrw","followers_url":"https://api.github.com/users/rbrw/followers","following_url":"https://api.github.com/users/rbrw/following{/other_user}","gists_url":"https://api.github.com/users/rbrw/gists{/gist_id}","starred_url":"https://api.github.com/users/rbrw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbrw/subscriptions","organizations_url":"https://api.github.com/users/rbrw/orgs","repos_url":"https://api.github.com/users/rbrw/repos","events_url":"https://api.github.com/users/rbrw/events{/privacy}","received_events_url":"https://api.github.com/users/rbrw/received_events","type":"User","site_admin":false},"repo":{"id":27739513,"name":"puppetdb","full_name":"rbrw/puppetdb","owner":{"login":"rbrw","id":10120698,"avatar_url":"https://avatars.githubusercontent.com/u/10120698?v=3","gravatar_id":"","url":"https://api.github.com/users/rbrw","html_url":"https://github.com/rbrw","followers_url":"https://api.github.com/users/rbrw/followers","following_url":"https://api.github.com/users/rbrw/following{/other_user}","gists_url":"https://api.github.com/users/rbrw/gists{/gist_id}","starred_url":"https://api.github.com/users/rbrw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbrw/subscriptions","organizations_url":"https://api.github.com/users/rbrw/orgs","repos_url":"https://api.github.com/users/rbrw/repos","events_url":"https://api.github.com/users/rbrw/events{/privacy}","received_events_url":"https://api.github.com/users/rbrw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rbrw/puppetdb","description":"Centralized Puppet Storage","fork":true,"url":"https://api.github.com/repos/rbrw/puppetdb","forks_url":"https://api.github.com/repos/rbrw/puppetdb/forks","keys_url":"https://api.github.com/repos/rbrw/puppetdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rbrw/puppetdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rbrw/puppetdb/teams","hooks_url":"https://api.github.com/repos/rbrw/puppetdb/hooks","issue_events_url":"https://api.github.com/repos/rbrw/puppetdb/issues/events{/number}","events_url":"https://api.github.com/repos/rbrw/puppetdb/events","assignees_url":"https://api.github.com/repos/rbrw/puppetdb/assignees{/user}","branches_url":"https://api.github.com/repos/rbrw/puppetdb/branches{/branch}","tags_url":"https://api.github.com/repos/rbrw/puppetdb/tags","blobs_url":"https://api.github.com/repos/rbrw/puppetdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rbrw/puppetdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rbrw/puppetdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/rbrw/puppetdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rbrw/puppetdb/statuses/{sha}","languages_url":"https://api.github.com/repos/rbrw/puppetdb/languages","stargazers_url":"https://api.github.com/repos/rbrw/puppetdb/stargazers","contributors_url":"https://api.github.com/repos/rbrw/puppetdb/contributors","subscribers_url":"https://api.github.com/repos/rbrw/puppetdb/subscribers","subscription_url":"https://api.github.com/repos/rbrw/puppetdb/subscription","commits_url":"https://api.github.com/repos/rbrw/puppetdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/rbrw/puppetdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/rbrw/puppetdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/rbrw/puppetdb/issues/comments/{number}","contents_url":"https://api.github.com/repos/rbrw/puppetdb/contents/{+path}","compare_url":"https://api.github.com/repos/rbrw/puppetdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rbrw/puppetdb/merges","archive_url":"https://api.github.com/repos/rbrw/puppetdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rbrw/puppetdb/downloads","issues_url":"https://api.github.com/repos/rbrw/puppetdb/issues{/number}","pulls_url":"https://api.github.com/repos/rbrw/puppetdb/pulls{/number}","milestones_url":"https://api.github.com/repos/rbrw/puppetdb/milestones{/number}","notifications_url":"https://api.github.com/repos/rbrw/puppetdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rbrw/puppetdb/labels{/name}","releases_url":"https://api.github.com/repos/rbrw/puppetdb/releases{/id}","created_at":"2014-12-08T23:03:46Z","updated_at":"2014-12-08T23:03:47Z","pushed_at":"2014-12-16T15:38:38Z","git_url":"git://github.com/rbrw/puppetdb.git","ssh_url":"git@github.com:rbrw/puppetdb.git","clone_url":"https://github.com/rbrw/puppetdb.git","svn_url":"https://github.com/rbrw/puppetdb","homepage":"http://docs.puppetlabs.com/puppetdb","size":10475,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"026a68a6524d124e32a189a2e79d453688ee17ea","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":2193032,"name":"puppetdb","full_name":"puppetlabs/puppetdb","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppetdb","description":"Centralized Puppet Storage","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppetdb","forks_url":"https://api.github.com/repos/puppetlabs/puppetdb/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppetdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppetdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppetdb/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppetdb/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppetdb/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppetdb/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppetdb/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppetdb/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppetdb/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppetdb/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppetdb/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppetdb/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppetdb/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppetdb/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppetdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppetdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/comments/{number}","contents_url":"https://api.github.com/repos/puppetlabs/puppetdb/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppetdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppetdb/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppetdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppetdb/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppetdb/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppetdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppetdb/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppetdb/releases{/id}","created_at":"2011-08-11T18:54:46Z","updated_at":"2014-12-15T15:29:13Z","pushed_at":"2014-12-12T18:51:05Z","git_url":"git://github.com/puppetlabs/puppetdb.git","ssh_url":"git@github.com:puppetlabs/puppetdb.git","clone_url":"https://github.com/puppetlabs/puppetdb.git","svn_url":"https://github.com/puppetlabs/puppetdb","homepage":"http://docs.puppetlabs.com/puppetdb","size":15403,"stargazers_count":152,"watchers_count":152,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":120,"mirror_url":null,"open_issues_count":9,"forks":120,"open_issues":9,"watchers":152,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1173"},"html":{"href":"https://github.com/puppetlabs/puppetdb/pull/1173"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/issues/1173"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/issues/1173/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1173/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1173/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/statuses/3f90bd2f54ad7b6dce0b8abc968f585fad0b599c"}}}}