GitHub PushEvent at 2014-10-23 21:36:22
Repository: ovs-reviews
Actor: blp
Payload: {"shas":[["cb85b49c4b7e610ccea2b03b9d62184f6247f4ba","6f50513b21952446fbc8c95a8f361b7aa434b7c7@nicira.com","tunnel: Add to nw_tos bits instead of replacing them in tnl_port_send().\n\nWe normally only add 1-bits to wc->masks for datapath flow matching\npurposes, never removing them.  In this case, the bits that get set to\nzero will be set back to 1 later on in the function, so this does not fix\nany actual bug, but the principle of only setting to 1, not to 0, seems\nsound to me.\n\nSigned-off-by: Ben Pfaff <blp@nicira.com>\nAcked-by: Justin Pettit <jpettit@nicira.com>","Ben Pfaff",true],["a9447331a639832a1c75b3f797757ed4139ec1d2","6f50513b21952446fbc8c95a8f361b7aa434b7c7@nicira.com","stream-tcp, stream-ssl: Remove unneeded getsockname() calls.\n\nCommit a8d819675f3 (Remove stream, vconn, and rconn functions to get\nlocal/remote IPs/ports.) removed the code that used the local socket\naddress but neglected to remove the code to fetch that address.  This\ncommit removes the latter code also.\n\nReported-by: Eitan Eliahu <eliahue@vmware.com>\nSigned-off-by: Ben Pfaff <blp@nicira.com>\nAcked-by: Eitan Eliahu <eliahue@vmware.com>","Ben Pfaff",true],["75752ef5e7e3ce70706074cae3ccf06c6871ed7e","4654159ed9054620d53953ba03993b13ec4c9504@vmware.com","datapath-windows: pid-instance hash table data structure.\n\nThis patch introduces data structure for holding instances hashed by pid.\n\nSigned-off-by: Ankur Sharma <ankursharma@vmware.com>\nAcked-by: Sorin Vinturis <svinturis@cloudbasesolutions.com>\ncked-by: Nithin Raju <nithin@vmware.com>\nSigned-off-by: Ben Pfaff <blp@nicira.com>","Ankur Sharma",true],["10023cb51bdfce031b33c1cec3953fefb0befb40","4654159ed9054620d53953ba03993b13ec4c9504@vmware.com","datapath-windows: Calling OvsAddPidInstance and OvsDelPidInstance\n\nSigned-off-by: Ankur Sharma <ankursharma@vmware.com>\nAcked-by: Sorin Vinturis <svinturis@cloudbasesolutions.com>\nAcked-by: Nithin Raju <nithin@vmware.com>\nSigned-off-by: Ben Pfaff <blp@nicira.com>","Ankur Sharma",true],["0e55eddc30506f269412becae7254647630c4140","4654159ed9054620d53953ba03993b13ec4c9504@vmware.com","datapath-windows: Fixes during integration testing.\n\nSigned-off-by: Ankur Sharma <ankursharma@vmware.com>\nAcked-by: Sorin Vinturis <svinturis@cloudbasesolutions.com>\nAcked-by: Nithin Raju <nithin@vmware.com>\nSigned-off-by: Ben Pfaff <blp@nicira.com>","Ankur Sharma",true],["b7cefbf7e52eb0262adb8447409d6ee52eb68a59","c4089df073b4e0e1342dd7f47682381cc38caa5c@nicira.com","stream-tcp: Call setsockopt TCP_NODELAY after TCP is connected.\n\nOn Windows platform, TCP_NODELAY can only be set when TCP is established.\n(This is an observed behavior and not written in any MSDN documentation.)\nThe current code does not create any problems while running unit tests\n(because connections get established immediately) but is reportedly\nobserved while connecting to a different machine.\n\ncommit 8b76839(Move setsockopt TCP_NODELAY to when TCP is connected.)\nmade changes to call setsockopt with TCP_NODELAY after TCP is connected\nonly in lib/stream-ssl.c. We need the same change for stream-tcp too and\nthis commit does that.\n\nCurrently, a failure of setting TCP_NODELAY results in reporting\nthe error and then closing the socket. This commit changes that\nbehavior such that an error is reported if setting TCP_NODELAY\nfails, but the connection itself is not torn down.\n\nSigned-off-by: Gurucharan Shetty <gshetty@nicira.com>\nAcked-by: Ben Pfaff <blp@nicira.com>","Gurucharan Shetty",true],["36791e21782536ab2ecc4aee9956d5333a8450c0","8e017de300aa8a1b37b30790baf6083b1587a4e9@vmware.com","netlink-socket: Add packet subscribe functionality on Windows.\n\nIn this patch, we add support in userspace for packet subscribe API\nsimilar to the join/leave MC group API that is used for port events.\nThe kernel code has already been commited.\n\nSigned-off-by: Nithin Raju <nithin@vmware.com>\nAcked-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com>\nSigned-off-by: Ben Pfaff <blp@nicira.com>","Nithin Raju",true],["09cac43f740b0aef1ef1cb656d952f56bedd7fec","8e017de300aa8a1b37b30790baf6083b1587a4e9@vmware.com","dpif-netlink: Add support for packet receive on Windows.\n\nIn this patch, we add support in dpif-netlink.c to receive packets on\nWindows. Windows does not natively support epoll(). Even though there\nare mechanisms/interfaces that provide functionality similar to epoll(),\nwe take a simple approach of using a pool of sockets.\n\nHere are some details of the implementaion to aid review:\n1. There's pool of sockets per upcall handler.\n2. The pool of sockets is initialized while setting up the handler in\ndpif_netlink_refresh_channels() primarily.\n3. When sockets are to be allocated for a vport, we walk through the\npool of sockets for all handlers and pick one of the sockets in each of\nthe pool. Within a handler's pool, sockets are picked in a round-robin\nfashion.\n4. We currently support only 1 handler, since there are some kernel\nchanges needed for support more than 1 handler per vport.\n5. The pool size is also set to 1 currently.\n\nThe restructions imposed by #4 and #5 can be removed in the future\nwithout much code churn.\n\nValidation:\n1. With a hacked up kernel which figures out the netlink socket that is\ndesignated to receive packets, we are cable to perform pings between 2\nVMs on the same Hyper-V host.\n2. Compiled the code in Linux as well.\n3. Tested with pool size == 2 as well, though in this patch we set the\npool size = 1.\n\nSigned-off-by: Nithin Raju <nithin@vmware.com>\nAcked-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com>\nSigned-off-by: Ben Pfaff <blp@nicira.com>","Nithin Raju",true],["b153b9903272f858ee1bbaaba0768f5f2d6506e7","6f50513b21952446fbc8c95a8f361b7aa434b7c7@nicira.com","ofp-actions: Properly check for action that exceeds buffer length.\n\nCommit c2d936a44fa (ofp-actions: Centralize all OpenFlow action code for\nmaintainability.) rewrote OpenFlow action parsing but failed to check that\nactions don't overflow their buffers.  This commit fixes the problem and\nadds negative tests so that this bug doesn't recur.\n\nReported-by: Tomer Pearl <Tomer.Pearl@Contextream.com>\nSigned-off-by: Ben Pfaff <blp@nicira.com>\nAcked-by: Justin Pettit <jpettit@nicira.com>","Ben Pfaff",true]],"size":9,"ref":"refs/heads/master","head":"b153b9903272f858ee1bbaaba0768f5f2d6506e7"}