GitHub PullRequestEvent at 2014-07-24 22:17:24
Repository: wice_grid
Actor: dontfidget
Payload: {"action":"opened","number":161,"pull_request":{"url":"https://api.github.com/repos/leikind/wice_grid/pulls/161","id":18867913,"html_url":"https://github.com/leikind/wice_grid/pull/161","diff_url":"https://github.com/leikind/wice_grid/pull/161.diff","patch_url":"https://github.com/leikind/wice_grid/pull/161.patch","issue_url":"https://api.github.com/repos/leikind/wice_grid/issues/161","number":161,"state":"open","title":"allow user to set the kaminari page method","user":{"login":"dontfidget","id":1858046,"avatar_url":"https://avatars.githubusercontent.com/u/1858046?","gravatar_id":"fb17d21da3a79cab3791bf3f2fac3cb6","url":"https://api.github.com/users/dontfidget","html_url":"https://github.com/dontfidget","followers_url":"https://api.github.com/users/dontfidget/followers","following_url":"https://api.github.com/users/dontfidget/following{/other_user}","gists_url":"https://api.github.com/users/dontfidget/gists{/gist_id}","starred_url":"https://api.github.com/users/dontfidget/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dontfidget/subscriptions","organizations_url":"https://api.github.com/users/dontfidget/orgs","repos_url":"https://api.github.com/users/dontfidget/repos","events_url":"https://api.github.com/users/dontfidget/events{/privacy}","received_events_url":"https://api.github.com/users/dontfidget/received_events","type":"User","site_admin":false},"body":"So I'm trying to put wice_grid into an app that uses will_paginate.  Rather than changing everything over to kaminari (which might not be a bad idea), I'm trying to use both simultaneously.  Kaminari supports `config.page_method_name = <method_symbol>` that allows you to use a method other than `page` to do your paginatation.  I've set this up, but wice_grid expects the kaminari page method to be called `page`.  I suppose we could get the method from kamanari itself but I thought it might be simplest just to add an option to set the name of the `page` method, both in the defaults so it can be set at config time, as well as when setting up the grid (just because, really).  I can add tests if you like but I was not sure how to handle that since tests are in a different repo.  Thanks for your consideration and so far your gem is looking great.  I look forward to using it more.","created_at":"2014-07-24T22:17:24Z","updated_at":"2014-07-24T22:17:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/leikind/wice_grid/pulls/161/commits","review_comments_url":"https://api.github.com/repos/leikind/wice_grid/pulls/161/comments","review_comment_url":"https://api.github.com/repos/leikind/wice_grid/pulls/comments/{number}","comments_url":"https://api.github.com/repos/leikind/wice_grid/issues/161/comments","statuses_url":"https://api.github.com/repos/leikind/wice_grid/statuses/2bb028c0518a85e392f75baa4a08212e51c59baf","head":{"label":"dontfidget:kaminari_page_method","ref":"kaminari_page_method","sha":"2bb028c0518a85e392f75baa4a08212e51c59baf","user":{"login":"dontfidget","id":1858046,"avatar_url":"https://avatars.githubusercontent.com/u/1858046?","gravatar_id":"fb17d21da3a79cab3791bf3f2fac3cb6","url":"https://api.github.com/users/dontfidget","html_url":"https://github.com/dontfidget","followers_url":"https://api.github.com/users/dontfidget/followers","following_url":"https://api.github.com/users/dontfidget/following{/other_user}","gists_url":"https://api.github.com/users/dontfidget/gists{/gist_id}","starred_url":"https://api.github.com/users/dontfidget/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dontfidget/subscriptions","organizations_url":"https://api.github.com/users/dontfidget/orgs","repos_url":"https://api.github.com/users/dontfidget/repos","events_url":"https://api.github.com/users/dontfidget/events{/privacy}","received_events_url":"https://api.github.com/users/dontfidget/received_events","type":"User","site_admin":false},"repo":{"id":22228088,"name":"wice_grid","full_name":"dontfidget/wice_grid","owner":{"login":"dontfidget","id":1858046,"avatar_url":"https://avatars.githubusercontent.com/u/1858046?","gravatar_id":"fb17d21da3a79cab3791bf3f2fac3cb6","url":"https://api.github.com/users/dontfidget","html_url":"https://github.com/dontfidget","followers_url":"https://api.github.com/users/dontfidget/followers","following_url":"https://api.github.com/users/dontfidget/following{/other_user}","gists_url":"https://api.github.com/users/dontfidget/gists{/gist_id}","starred_url":"https://api.github.com/users/dontfidget/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dontfidget/subscriptions","organizations_url":"https://api.github.com/users/dontfidget/orgs","repos_url":"https://api.github.com/users/dontfidget/repos","events_url":"https://api.github.com/users/dontfidget/events{/privacy}","received_events_url":"https://api.github.com/users/dontfidget/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dontfidget/wice_grid","description":"A Rails grid plugin to create  grids with sorting, pagination, and (automatically generated) filters","fork":true,"url":"https://api.github.com/repos/dontfidget/wice_grid","forks_url":"https://api.github.com/repos/dontfidget/wice_grid/forks","keys_url":"https://api.github.com/repos/dontfidget/wice_grid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dontfidget/wice_grid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dontfidget/wice_grid/teams","hooks_url":"https://api.github.com/repos/dontfidget/wice_grid/hooks","issue_events_url":"https://api.github.com/repos/dontfidget/wice_grid/issues/events{/number}","events_url":"https://api.github.com/repos/dontfidget/wice_grid/events","assignees_url":"https://api.github.com/repos/dontfidget/wice_grid/assignees{/user}","branches_url":"https://api.github.com/repos/dontfidget/wice_grid/branches{/branch}","tags_url":"https://api.github.com/repos/dontfidget/wice_grid/tags","blobs_url":"https://api.github.com/repos/dontfidget/wice_grid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dontfidget/wice_grid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dontfidget/wice_grid/git/refs{/sha}","trees_url":"https://api.github.com/repos/dontfidget/wice_grid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dontfidget/wice_grid/statuses/{sha}","languages_url":"https://api.github.com/repos/dontfidget/wice_grid/languages","stargazers_url":"https://api.github.com/repos/dontfidget/wice_grid/stargazers","contributors_url":"https://api.github.com/repos/dontfidget/wice_grid/contributors","subscribers_url":"https://api.github.com/repos/dontfidget/wice_grid/subscribers","subscription_url":"https://api.github.com/repos/dontfidget/wice_grid/subscription","commits_url":"https://api.github.com/repos/dontfidget/wice_grid/commits{/sha}","git_commits_url":"https://api.github.com/repos/dontfidget/wice_grid/git/commits{/sha}","comments_url":"https://api.github.com/repos/dontfidget/wice_grid/comments{/number}","issue_comment_url":"https://api.github.com/repos/dontfidget/wice_grid/issues/comments/{number}","contents_url":"https://api.github.com/repos/dontfidget/wice_grid/contents/{+path}","compare_url":"https://api.github.com/repos/dontfidget/wice_grid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dontfidget/wice_grid/merges","archive_url":"https://api.github.com/repos/dontfidget/wice_grid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dontfidget/wice_grid/downloads","issues_url":"https://api.github.com/repos/dontfidget/wice_grid/issues{/number}","pulls_url":"https://api.github.com/repos/dontfidget/wice_grid/pulls{/number}","milestones_url":"https://api.github.com/repos/dontfidget/wice_grid/milestones{/number}","notifications_url":"https://api.github.com/repos/dontfidget/wice_grid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dontfidget/wice_grid/labels{/name}","releases_url":"https://api.github.com/repos/dontfidget/wice_grid/releases{/id}","created_at":"2014-07-24T19:40:51Z","updated_at":"2014-07-22T13:21:06Z","pushed_at":"2014-07-24T20:20:30Z","git_url":"git://github.com/dontfidget/wice_grid.git","ssh_url":"git@github.com:dontfidget/wice_grid.git","clone_url":"https://github.com/dontfidget/wice_grid.git","svn_url":"https://github.com/dontfidget/wice_grid","homepage":"http://wicegrid.herokuapp.com/","size":1529,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"rails3"}},"base":{"label":"leikind:rails3","ref":"rails3","sha":"5cc80480dd392b3d3f167a50e72546bced61357b","user":{"login":"leikind","id":99266,"avatar_url":"https://avatars.githubusercontent.com/u/99266?","gravatar_id":"8d1e089fd6a6703f5f13dbee271aa77c","url":"https://api.github.com/users/leikind","html_url":"https://github.com/leikind","followers_url":"https://api.github.com/users/leikind/followers","following_url":"https://api.github.com/users/leikind/following{/other_user}","gists_url":"https://api.github.com/users/leikind/gists{/gist_id}","starred_url":"https://api.github.com/users/leikind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leikind/subscriptions","organizations_url":"https://api.github.com/users/leikind/orgs","repos_url":"https://api.github.com/users/leikind/repos","events_url":"https://api.github.com/users/leikind/events{/privacy}","received_events_url":"https://api.github.com/users/leikind/received_events","type":"User","site_admin":false},"repo":{"id":239898,"name":"wice_grid","full_name":"leikind/wice_grid","owner":{"login":"leikind","id":99266,"avatar_url":"https://avatars.githubusercontent.com/u/99266?","gravatar_id":"8d1e089fd6a6703f5f13dbee271aa77c","url":"https://api.github.com/users/leikind","html_url":"https://github.com/leikind","followers_url":"https://api.github.com/users/leikind/followers","following_url":"https://api.github.com/users/leikind/following{/other_user}","gists_url":"https://api.github.com/users/leikind/gists{/gist_id}","starred_url":"https://api.github.com/users/leikind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leikind/subscriptions","organizations_url":"https://api.github.com/users/leikind/orgs","repos_url":"https://api.github.com/users/leikind/repos","events_url":"https://api.github.com/users/leikind/events{/privacy}","received_events_url":"https://api.github.com/users/leikind/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/leikind/wice_grid","description":"A Rails grid plugin to create  grids with sorting, pagination, and (automatically generated) filters","fork":false,"url":"https://api.github.com/repos/leikind/wice_grid","forks_url":"https://api.github.com/repos/leikind/wice_grid/forks","keys_url":"https://api.github.com/repos/leikind/wice_grid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leikind/wice_grid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leikind/wice_grid/teams","hooks_url":"https://api.github.com/repos/leikind/wice_grid/hooks","issue_events_url":"https://api.github.com/repos/leikind/wice_grid/issues/events{/number}","events_url":"https://api.github.com/repos/leikind/wice_grid/events","assignees_url":"https://api.github.com/repos/leikind/wice_grid/assignees{/user}","branches_url":"https://api.github.com/repos/leikind/wice_grid/branches{/branch}","tags_url":"https://api.github.com/repos/leikind/wice_grid/tags","blobs_url":"https://api.github.com/repos/leikind/wice_grid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leikind/wice_grid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leikind/wice_grid/git/refs{/sha}","trees_url":"https://api.github.com/repos/leikind/wice_grid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leikind/wice_grid/statuses/{sha}","languages_url":"https://api.github.com/repos/leikind/wice_grid/languages","stargazers_url":"https://api.github.com/repos/leikind/wice_grid/stargazers","contributors_url":"https://api.github.com/repos/leikind/wice_grid/contributors","subscribers_url":"https://api.github.com/repos/leikind/wice_grid/subscribers","subscription_url":"https://api.github.com/repos/leikind/wice_grid/subscription","commits_url":"https://api.github.com/repos/leikind/wice_grid/commits{/sha}","git_commits_url":"https://api.github.com/repos/leikind/wice_grid/git/commits{/sha}","comments_url":"https://api.github.com/repos/leikind/wice_grid/comments{/number}","issue_comment_url":"https://api.github.com/repos/leikind/wice_grid/issues/comments/{number}","contents_url":"https://api.github.com/repos/leikind/wice_grid/contents/{+path}","compare_url":"https://api.github.com/repos/leikind/wice_grid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leikind/wice_grid/merges","archive_url":"https://api.github.com/repos/leikind/wice_grid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leikind/wice_grid/downloads","issues_url":"https://api.github.com/repos/leikind/wice_grid/issues{/number}","pulls_url":"https://api.github.com/repos/leikind/wice_grid/pulls{/number}","milestones_url":"https://api.github.com/repos/leikind/wice_grid/milestones{/number}","notifications_url":"https://api.github.com/repos/leikind/wice_grid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leikind/wice_grid/labels{/name}","releases_url":"https://api.github.com/repos/leikind/wice_grid/releases{/id}","created_at":"2009-06-30T16:59:51Z","updated_at":"2014-07-22T13:21:06Z","pushed_at":"2014-07-23T12:40:30Z","git_url":"git://github.com/leikind/wice_grid.git","ssh_url":"git@github.com:leikind/wice_grid.git","clone_url":"https://github.com/leikind/wice_grid.git","svn_url":"https://github.com/leikind/wice_grid","homepage":"http://wicegrid.herokuapp.com/","size":1529,"stargazers_count":279,"watchers_count":279,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":70,"mirror_url":null,"open_issues_count":19,"forks":70,"open_issues":19,"watchers":279,"default_branch":"rails3"}},"_links":{"self":{"href":"https://api.github.com/repos/leikind/wice_grid/pulls/161"},"html":{"href":"https://github.com/leikind/wice_grid/pull/161"},"issue":{"href":"https://api.github.com/repos/leikind/wice_grid/issues/161"},"comments":{"href":"https://api.github.com/repos/leikind/wice_grid/issues/161/comments"},"review_comments":{"href":"https://api.github.com/repos/leikind/wice_grid/pulls/161/comments"},"review_comment":{"href":"https://api.github.com/repos/leikind/wice_grid/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/leikind/wice_grid/pulls/161/commits"},"statuses":{"href":"https://api.github.com/repos/leikind/wice_grid/statuses/2bb028c0518a85e392f75baa4a08212e51c59baf"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":5,"deletions":2,"changed_files":2}}