GitHub PullRequestEvent at 2014-06-15 16:05:05
Repository: pungi
Actor: wyuenho
Payload: {"action":"opened","number":8,"pull_request":{"url":"https://api.github.com/repos/mgrbyte/pungi/pulls/8","id":17153810,"html_url":"https://github.com/mgrbyte/pungi/pull/8","diff_url":"https://github.com/mgrbyte/pungi/pull/8.diff","patch_url":"https://github.com/mgrbyte/pungi/pull/8.patch","issue_url":"https://api.github.com/repos/mgrbyte/pungi/issues/8","number":8,"state":"open","title":"Fix hook order","user":{"login":"wyuenho","id":160028,"avatar_url":"https://avatars.githubusercontent.com/u/160028?","gravatar_id":"8c68a839282f699145cb8bc314287555","url":"https://api.github.com/users/wyuenho","html_url":"https://github.com/wyuenho","followers_url":"https://api.github.com/users/wyuenho/followers","following_url":"https://api.github.com/users/wyuenho/following{/other_user}","gists_url":"https://api.github.com/users/wyuenho/gists{/gist_id}","starred_url":"https://api.github.com/users/wyuenho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wyuenho/subscriptions","organizations_url":"https://api.github.com/users/wyuenho/orgs","repos_url":"https://api.github.com/users/wyuenho/repos","events_url":"https://api.github.com/users/wyuenho/events{/privacy}","received_events_url":"https://api.github.com/users/wyuenho/received_events","type":"User","site_admin":false},"body":"This PR fixes a number of bugs related to the order of hook executions.\r\n\r\n1. `jedi:server-args` is not set up before `jedi:setup` because the mode local hook is run after `jedi:setup`.\r\n2. Fixes the bug where the second call to `jedi:setup` from inside the hack local vars hook has no effect because `jedi` pools the epc processes for the same command. Since `jedi:setup` has already setup the process when `python-mode-hook` is called, the second call will have no effect unless you stop the process and make a new one, but that will leave a lingering epc process handle in the jedi server pool table. This PR makes sure only one jedi server process is created per virtualenv.\r\n\r\nThis PR also renames `pungi-local-variables-hook` to `pungi-setup-jedi` and refactored the code and docs a bit.","created_at":"2014-06-15T16:05:02Z","updated_at":"2014-06-15T16:05:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mgrbyte/pungi/pulls/8/commits","review_comments_url":"https://api.github.com/repos/mgrbyte/pungi/pulls/8/comments","review_comment_url":"https://api.github.com/repos/mgrbyte/pungi/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mgrbyte/pungi/issues/8/comments","statuses_url":"https://api.github.com/repos/mgrbyte/pungi/statuses/5cfd3d5334e3e88960e260a8c62639e75093f94a","head":{"label":"wyuenho:fix-hook-order","ref":"fix-hook-order","sha":"5cfd3d5334e3e88960e260a8c62639e75093f94a","user":{"login":"wyuenho","id":160028,"avatar_url":"https://avatars.githubusercontent.com/u/160028?","gravatar_id":"8c68a839282f699145cb8bc314287555","url":"https://api.github.com/users/wyuenho","html_url":"https://github.com/wyuenho","followers_url":"https://api.github.com/users/wyuenho/followers","following_url":"https://api.github.com/users/wyuenho/following{/other_user}","gists_url":"https://api.github.com/users/wyuenho/gists{/gist_id}","starred_url":"https://api.github.com/users/wyuenho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wyuenho/subscriptions","organizations_url":"https://api.github.com/users/wyuenho/orgs","repos_url":"https://api.github.com/users/wyuenho/repos","events_url":"https://api.github.com/users/wyuenho/events{/privacy}","received_events_url":"https://api.github.com/users/wyuenho/received_events","type":"User","site_admin":false},"repo":{"id":20812505,"name":"pungi","full_name":"wyuenho/pungi","owner":{"login":"wyuenho","id":160028,"avatar_url":"https://avatars.githubusercontent.com/u/160028?","gravatar_id":"8c68a839282f699145cb8bc314287555","url":"https://api.github.com/users/wyuenho","html_url":"https://github.com/wyuenho","followers_url":"https://api.github.com/users/wyuenho/followers","following_url":"https://api.github.com/users/wyuenho/following{/other_user}","gists_url":"https://api.github.com/users/wyuenho/gists{/gist_id}","starred_url":"https://api.github.com/users/wyuenho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wyuenho/subscriptions","organizations_url":"https://api.github.com/users/wyuenho/orgs","repos_url":"https://api.github.com/users/wyuenho/repos","events_url":"https://api.github.com/users/wyuenho/events{/privacy}","received_events_url":"https://api.github.com/users/wyuenho/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wyuenho/pungi","description":"An emacs library integrating python-mode, jedi, buildout and virtualenv","fork":true,"url":"https://api.github.com/repos/wyuenho/pungi","forks_url":"https://api.github.com/repos/wyuenho/pungi/forks","keys_url":"https://api.github.com/repos/wyuenho/pungi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wyuenho/pungi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wyuenho/pungi/teams","hooks_url":"https://api.github.com/repos/wyuenho/pungi/hooks","issue_events_url":"https://api.github.com/repos/wyuenho/pungi/issues/events{/number}","events_url":"https://api.github.com/repos/wyuenho/pungi/events","assignees_url":"https://api.github.com/repos/wyuenho/pungi/assignees{/user}","branches_url":"https://api.github.com/repos/wyuenho/pungi/branches{/branch}","tags_url":"https://api.github.com/repos/wyuenho/pungi/tags","blobs_url":"https://api.github.com/repos/wyuenho/pungi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wyuenho/pungi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wyuenho/pungi/git/refs{/sha}","trees_url":"https://api.github.com/repos/wyuenho/pungi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wyuenho/pungi/statuses/{sha}","languages_url":"https://api.github.com/repos/wyuenho/pungi/languages","stargazers_url":"https://api.github.com/repos/wyuenho/pungi/stargazers","contributors_url":"https://api.github.com/repos/wyuenho/pungi/contributors","subscribers_url":"https://api.github.com/repos/wyuenho/pungi/subscribers","subscription_url":"https://api.github.com/repos/wyuenho/pungi/subscription","commits_url":"https://api.github.com/repos/wyuenho/pungi/commits{/sha}","git_commits_url":"https://api.github.com/repos/wyuenho/pungi/git/commits{/sha}","comments_url":"https://api.github.com/repos/wyuenho/pungi/comments{/number}","issue_comment_url":"https://api.github.com/repos/wyuenho/pungi/issues/comments/{number}","contents_url":"https://api.github.com/repos/wyuenho/pungi/contents/{+path}","compare_url":"https://api.github.com/repos/wyuenho/pungi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wyuenho/pungi/merges","archive_url":"https://api.github.com/repos/wyuenho/pungi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wyuenho/pungi/downloads","issues_url":"https://api.github.com/repos/wyuenho/pungi/issues{/number}","pulls_url":"https://api.github.com/repos/wyuenho/pungi/pulls{/number}","milestones_url":"https://api.github.com/repos/wyuenho/pungi/milestones{/number}","notifications_url":"https://api.github.com/repos/wyuenho/pungi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wyuenho/pungi/labels{/name}","releases_url":"https://api.github.com/repos/wyuenho/pungi/releases{/id}","created_at":"2014-06-13T17:43:40Z","updated_at":"2014-06-15T16:05:02Z","pushed_at":"2014-06-15T15:45:41Z","git_url":"git://github.com/wyuenho/pungi.git","ssh_url":"git@github.com:wyuenho/pungi.git","clone_url":"https://github.com/wyuenho/pungi.git","svn_url":"https://github.com/wyuenho/pungi","homepage":null,"size":357,"stargazers_count":0,"watchers_count":0,"language":"Emacs Lisp","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mgrbyte:master","ref":"master","sha":"9bf48327546277105fbd49153fed0b3871e412d9","user":{"login":"mgrbyte","id":3185091,"avatar_url":"https://avatars.githubusercontent.com/u/3185091?","gravatar_id":"6d867b049e22836b9b12dd478b6c94d3","url":"https://api.github.com/users/mgrbyte","html_url":"https://github.com/mgrbyte","followers_url":"https://api.github.com/users/mgrbyte/followers","following_url":"https://api.github.com/users/mgrbyte/following{/other_user}","gists_url":"https://api.github.com/users/mgrbyte/gists{/gist_id}","starred_url":"https://api.github.com/users/mgrbyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgrbyte/subscriptions","organizations_url":"https://api.github.com/users/mgrbyte/orgs","repos_url":"https://api.github.com/users/mgrbyte/repos","events_url":"https://api.github.com/users/mgrbyte/events{/privacy}","received_events_url":"https://api.github.com/users/mgrbyte/received_events","type":"User","site_admin":false},"repo":{"id":17664769,"name":"pungi","full_name":"mgrbyte/pungi","owner":{"login":"mgrbyte","id":3185091,"avatar_url":"https://avatars.githubusercontent.com/u/3185091?","gravatar_id":"6d867b049e22836b9b12dd478b6c94d3","url":"https://api.github.com/users/mgrbyte","html_url":"https://github.com/mgrbyte","followers_url":"https://api.github.com/users/mgrbyte/followers","following_url":"https://api.github.com/users/mgrbyte/following{/other_user}","gists_url":"https://api.github.com/users/mgrbyte/gists{/gist_id}","starred_url":"https://api.github.com/users/mgrbyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgrbyte/subscriptions","organizations_url":"https://api.github.com/users/mgrbyte/orgs","repos_url":"https://api.github.com/users/mgrbyte/repos","events_url":"https://api.github.com/users/mgrbyte/events{/privacy}","received_events_url":"https://api.github.com/users/mgrbyte/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mgrbyte/pungi","description":"An emacs library integrating python-mode, jedi, buildout and virtualenv","fork":false,"url":"https://api.github.com/repos/mgrbyte/pungi","forks_url":"https://api.github.com/repos/mgrbyte/pungi/forks","keys_url":"https://api.github.com/repos/mgrbyte/pungi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mgrbyte/pungi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mgrbyte/pungi/teams","hooks_url":"https://api.github.com/repos/mgrbyte/pungi/hooks","issue_events_url":"https://api.github.com/repos/mgrbyte/pungi/issues/events{/number}","events_url":"https://api.github.com/repos/mgrbyte/pungi/events","assignees_url":"https://api.github.com/repos/mgrbyte/pungi/assignees{/user}","branches_url":"https://api.github.com/repos/mgrbyte/pungi/branches{/branch}","tags_url":"https://api.github.com/repos/mgrbyte/pungi/tags","blobs_url":"https://api.github.com/repos/mgrbyte/pungi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mgrbyte/pungi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mgrbyte/pungi/git/refs{/sha}","trees_url":"https://api.github.com/repos/mgrbyte/pungi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mgrbyte/pungi/statuses/{sha}","languages_url":"https://api.github.com/repos/mgrbyte/pungi/languages","stargazers_url":"https://api.github.com/repos/mgrbyte/pungi/stargazers","contributors_url":"https://api.github.com/repos/mgrbyte/pungi/contributors","subscribers_url":"https://api.github.com/repos/mgrbyte/pungi/subscribers","subscription_url":"https://api.github.com/repos/mgrbyte/pungi/subscription","commits_url":"https://api.github.com/repos/mgrbyte/pungi/commits{/sha}","git_commits_url":"https://api.github.com/repos/mgrbyte/pungi/git/commits{/sha}","comments_url":"https://api.github.com/repos/mgrbyte/pungi/comments{/number}","issue_comment_url":"https://api.github.com/repos/mgrbyte/pungi/issues/comments/{number}","contents_url":"https://api.github.com/repos/mgrbyte/pungi/contents/{+path}","compare_url":"https://api.github.com/repos/mgrbyte/pungi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mgrbyte/pungi/merges","archive_url":"https://api.github.com/repos/mgrbyte/pungi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mgrbyte/pungi/downloads","issues_url":"https://api.github.com/repos/mgrbyte/pungi/issues{/number}","pulls_url":"https://api.github.com/repos/mgrbyte/pungi/pulls{/number}","milestones_url":"https://api.github.com/repos/mgrbyte/pungi/milestones{/number}","notifications_url":"https://api.github.com/repos/mgrbyte/pungi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mgrbyte/pungi/labels{/name}","releases_url":"https://api.github.com/repos/mgrbyte/pungi/releases{/id}","created_at":"2014-03-12T11:30:18Z","updated_at":"2014-06-14T04:18:46Z","pushed_at":"2014-06-14T04:18:47Z","git_url":"git://github.com/mgrbyte/pungi.git","ssh_url":"git@github.com:mgrbyte/pungi.git","clone_url":"https://github.com/mgrbyte/pungi.git","svn_url":"https://github.com/mgrbyte/pungi","homepage":null,"size":357,"stargazers_count":2,"watchers_count":2,"language":"Emacs Lisp","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mgrbyte/pungi/pulls/8"},"html":{"href":"https://github.com/mgrbyte/pungi/pull/8"},"issue":{"href":"https://api.github.com/repos/mgrbyte/pungi/issues/8"},"comments":{"href":"https://api.github.com/repos/mgrbyte/pungi/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/mgrbyte/pungi/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/mgrbyte/pungi/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mgrbyte/pungi/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/mgrbyte/pungi/statuses/5cfd3d5334e3e88960e260a8c62639e75093f94a"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":24,"deletions":30,"changed_files":1}}