GitHub PullRequestReviewCommentEvent at 2014-10-24 22:43:04
Repository: cadvisor
Actor: vmarmol
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/google/cadvisor/pulls/comments/19368964","id":19368964,"diff_hunk":"@@ -240,6 +240,60 @@ type FsStats struct {\n \n \t// Number of bytes that is consumed by the container on this filesystem.\n \tUsage uint64 `json:\"usage\"`\n+\n+\t// # of reads completed\n+\t// This is the total number of reads completed successfully.\n+\tReadsCompleted uint64 `json:\"reads_completed\"`\n+\n+\t// # of reads merged\n+\t// Reads and writes which are adjacent to each other may be merged for\n+\t// efficiency.  Thus two 4K reads may become one 8K read before it is\n+\t// ultimately handed to the disk, and so it will be counted (and queued)\n+\t// as only one I/O.  This field lets you know how often this was done.\n+\tReadsMerged uint64 `json:\"reads_merged\"`\n+\n+\t// # of sectors read\n+\t// This is the total number of sectors read successfully.\n+\tSectorsRead uint64 `json:\"sectors_read\"`\n+\n+\t// # of milliseconds spent reading\n+\t// This is the total number of milliseconds spent by all reads (as\n+\t// measured from __make_request() to end_that_request_last()).\n+\tReadTime uint64 `json:\"read_time\"`\n+\n+\t// # of writes completed\n+\t// This is the total number of writes completed successfully.\n+\tWritesCompleted uint64 `json:\"writes_completed\"`\n+\n+\t// # of writes merged\n+\t// See the description of reads merged.\n+\tWritesMerged uint64 `json:\"writes_merged\"`\n+\n+\t// # of sectors written\n+\t// This is the total number of sectors written successfully.\n+\tSectorsWritten uint64 `json:\"sectors_written\"`\n+\n+\t// # of milliseconds spent writing\n+\t// This is the total number of milliseconds spent by all writes (as\n+\t// measured from __make_request() to end_that_request_last()).\n+\tWriteTime uint64 `json:\"write_time\"`\n+\n+\t// # of I/Os currently in progress\n+\t// The only field that should go to zero. Incremented as requests are\n+\t// given to appropriate struct request_queue and decremented as they finish.\n+\tIOInProgress uint64 `json:\"io_in_progress\"`","path":"info/container.go","position":45,"original_position":45,"commit_id":"e8ea485a0db8e550f05d6ed08515974ace41adf2","original_commit_id":"e8ea485a0db8e550f05d6ed08515974ace41adf2","user":{"login":"vmarmol","id":985208,"avatar_url":"https://avatars.githubusercontent.com/u/985208?v=2","gravatar_id":"","url":"https://api.github.com/users/vmarmol","html_url":"https://github.com/vmarmol","followers_url":"https://api.github.com/users/vmarmol/followers","following_url":"https://api.github.com/users/vmarmol/following{/other_user}","gists_url":"https://api.github.com/users/vmarmol/gists{/gist_id}","starred_url":"https://api.github.com/users/vmarmol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmarmol/subscriptions","organizations_url":"https://api.github.com/users/vmarmol/orgs","repos_url":"https://api.github.com/users/vmarmol/repos","events_url":"https://api.github.com/users/vmarmol/events{/privacy}","received_events_url":"https://api.github.com/users/vmarmol/received_events","type":"User","site_admin":false},"body":"nit: s/IO/Io/\r\n\r\nI believe it is the Go convention.","created_at":"2014-10-24T22:43:04Z","updated_at":"2014-10-24T22:43:04Z","html_url":"https://github.com/google/cadvisor/pull/279#discussion_r19368964","pull_request_url":"https://api.github.com/repos/google/cadvisor/pulls/279","_links":{"self":{"href":"https://api.github.com/repos/google/cadvisor/pulls/comments/19368964"},"html":{"href":"https://github.com/google/cadvisor/pull/279#discussion_r19368964"},"pull_request":{"href":"https://api.github.com/repos/google/cadvisor/pulls/279"}}},"pull_request":{"url":"https://api.github.com/repos/google/cadvisor/pulls/279","id":23207307,"html_url":"https://github.com/google/cadvisor/pull/279","diff_url":"https://github.com/google/cadvisor/pull/279.diff","patch_url":"https://github.com/google/cadvisor/pull/279.patch","issue_url":"https://api.github.com/repos/google/cadvisor/issues/279","number":279,"state":"open","locked":false,"title":"Added /proc/diskstats","user":{"login":"ashahab-altiscale","id":5115017,"avatar_url":"https://avatars.githubusercontent.com/u/5115017?v=2","gravatar_id":"","url":"https://api.github.com/users/ashahab-altiscale","html_url":"https://github.com/ashahab-altiscale","followers_url":"https://api.github.com/users/ashahab-altiscale/followers","following_url":"https://api.github.com/users/ashahab-altiscale/following{/other_user}","gists_url":"https://api.github.com/users/ashahab-altiscale/gists{/gist_id}","starred_url":"https://api.github.com/users/ashahab-altiscale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashahab-altiscale/subscriptions","organizations_url":"https://api.github.com/users/ashahab-altiscale/orgs","repos_url":"https://api.github.com/users/ashahab-altiscale/repos","events_url":"https://api.github.com/users/ashahab-altiscale/events{/privacy}","received_events_url":"https://api.github.com/users/ashahab-altiscale/received_events","type":"User","site_admin":false},"body":"Read disk io information from /proc/diskstats.\r\nThis will allow the user who provides partition container hints to get partition-specific io (blkio provides io for the container, but at the disk device level).","created_at":"2014-10-23T05:20:52Z","updated_at":"2014-10-24T22:43:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a52de48bb460835297f6cc249815668d445896b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/google/cadvisor/pulls/279/commits","review_comments_url":"https://api.github.com/repos/google/cadvisor/pulls/279/comments","review_comment_url":"https://api.github.com/repos/google/cadvisor/pulls/comments/{number}","comments_url":"https://api.github.com/repos/google/cadvisor/issues/279/comments","statuses_url":"https://api.github.com/repos/google/cadvisor/statuses/e8ea485a0db8e550f05d6ed08515974ace41adf2","head":{"label":"ashahab-altiscale:additional-disk-stats","ref":"additional-disk-stats","sha":"e8ea485a0db8e550f05d6ed08515974ace41adf2","user":{"login":"ashahab-altiscale","id":5115017,"avatar_url":"https://avatars.githubusercontent.com/u/5115017?v=2","gravatar_id":"","url":"https://api.github.com/users/ashahab-altiscale","html_url":"https://github.com/ashahab-altiscale","followers_url":"https://api.github.com/users/ashahab-altiscale/followers","following_url":"https://api.github.com/users/ashahab-altiscale/following{/other_user}","gists_url":"https://api.github.com/users/ashahab-altiscale/gists{/gist_id}","starred_url":"https://api.github.com/users/ashahab-altiscale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashahab-altiscale/subscriptions","organizations_url":"https://api.github.com/users/ashahab-altiscale/orgs","repos_url":"https://api.github.com/users/ashahab-altiscale/repos","events_url":"https://api.github.com/users/ashahab-altiscale/events{/privacy}","received_events_url":"https://api.github.com/users/ashahab-altiscale/received_events","type":"User","site_admin":false},"repo":{"id":25047487,"name":"cadvisor","full_name":"ashahab-altiscale/cadvisor","owner":{"login":"ashahab-altiscale","id":5115017,"avatar_url":"https://avatars.githubusercontent.com/u/5115017?v=2","gravatar_id":"","url":"https://api.github.com/users/ashahab-altiscale","html_url":"https://github.com/ashahab-altiscale","followers_url":"https://api.github.com/users/ashahab-altiscale/followers","following_url":"https://api.github.com/users/ashahab-altiscale/following{/other_user}","gists_url":"https://api.github.com/users/ashahab-altiscale/gists{/gist_id}","starred_url":"https://api.github.com/users/ashahab-altiscale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashahab-altiscale/subscriptions","organizations_url":"https://api.github.com/users/ashahab-altiscale/orgs","repos_url":"https://api.github.com/users/ashahab-altiscale/repos","events_url":"https://api.github.com/users/ashahab-altiscale/events{/privacy}","received_events_url":"https://api.github.com/users/ashahab-altiscale/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ashahab-altiscale/cadvisor","description":"Analyzes resource usage and performance characteristics of running containers.","fork":true,"url":"https://api.github.com/repos/ashahab-altiscale/cadvisor","forks_url":"https://api.github.com/repos/ashahab-altiscale/cadvisor/forks","keys_url":"https://api.github.com/repos/ashahab-altiscale/cadvisor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ashahab-altiscale/cadvisor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ashahab-altiscale/cadvisor/teams","hooks_url":"https://api.github.com/repos/ashahab-altiscale/cadvisor/hooks","issue_events_url":"https://api.github.com/repos/ashahab-altiscale/cadvisor/issues/events{/number}","events_url":"https://api.github.com/repos/ashahab-altiscale/cadvisor/events","assignees_url":"https://api.github.com/repos/ashahab-altiscale/cadvisor/assignees{/user}","branches_url":"https://api.github.com/repos/ashahab-altiscale/cadvisor/branches{/branch}","tags_url":"https://api.github.com/repos/ashahab-altiscale/cadvisor/tags","blobs_url":"https://api.github.com/repos/ashahab-altiscale/cadvisor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ashahab-altiscale/cadvisor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ashahab-altiscale/cadvisor/git/refs{/sha}","trees_url":"https://api.github.com/repos/ashahab-altiscale/cadvisor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ashahab-altiscale/cadvisor/statuses/{sha}","languages_url":"https://api.github.com/repos/ashahab-altiscale/cadvisor/languages","stargazers_url":"https://api.github.com/repos/ashahab-altiscale/cadvisor/stargazers","contributors_url":"https://api.github.com/repos/ashahab-altiscale/cadvisor/contributors","subscribers_url":"https://api.github.com/repos/ashahab-altiscale/cadvisor/subscribers","subscription_url":"https://api.github.com/repos/ashahab-altiscale/cadvisor/subscription","commits_url":"https://api.github.com/repos/ashahab-altiscale/cadvisor/commits{/sha}","git_commits_url":"https://api.github.com/repos/ashahab-altiscale/cadvisor/git/commits{/sha}","comments_url":"https://api.github.com/repos/ashahab-altiscale/cadvisor/comments{/number}","issue_comment_url":"https://api.github.com/repos/ashahab-altiscale/cadvisor/issues/comments/{number}","contents_url":"https://api.github.com/repos/ashahab-altiscale/cadvisor/contents/{+path}","compare_url":"https://api.github.com/repos/ashahab-altiscale/cadvisor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ashahab-altiscale/cadvisor/merges","archive_url":"https://api.github.com/repos/ashahab-altiscale/cadvisor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ashahab-altiscale/cadvisor/downloads","issues_url":"https://api.github.com/repos/ashahab-altiscale/cadvisor/issues{/number}","pulls_url":"https://api.github.com/repos/ashahab-altiscale/cadvisor/pulls{/number}","milestones_url":"https://api.github.com/repos/ashahab-altiscale/cadvisor/milestones{/number}","notifications_url":"https://api.github.com/repos/ashahab-altiscale/cadvisor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ashahab-altiscale/cadvisor/labels{/name}","releases_url":"https://api.github.com/repos/ashahab-altiscale/cadvisor/releases{/id}","created_at":"2014-10-10T18:15:41Z","updated_at":"2014-10-21T16:30:35Z","pushed_at":"2014-10-24T22:08:52Z","git_url":"git://github.com/ashahab-altiscale/cadvisor.git","ssh_url":"git@github.com:ashahab-altiscale/cadvisor.git","clone_url":"https://github.com/ashahab-altiscale/cadvisor.git","svn_url":"https://github.com/ashahab-altiscale/cadvisor","homepage":"","size":16136,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"b1796da27088dcd1dae7020d5281841bb074fb8c","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=2","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":20653934,"name":"cadvisor","full_name":"google/cadvisor","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=2","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/cadvisor","description":"Analyzes resource usage and performance characteristics of running containers.","fork":false,"url":"https://api.github.com/repos/google/cadvisor","forks_url":"https://api.github.com/repos/google/cadvisor/forks","keys_url":"https://api.github.com/repos/google/cadvisor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/cadvisor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/cadvisor/teams","hooks_url":"https://api.github.com/repos/google/cadvisor/hooks","issue_events_url":"https://api.github.com/repos/google/cadvisor/issues/events{/number}","events_url":"https://api.github.com/repos/google/cadvisor/events","assignees_url":"https://api.github.com/repos/google/cadvisor/assignees{/user}","branches_url":"https://api.github.com/repos/google/cadvisor/branches{/branch}","tags_url":"https://api.github.com/repos/google/cadvisor/tags","blobs_url":"https://api.github.com/repos/google/cadvisor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/cadvisor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/cadvisor/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/cadvisor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/cadvisor/statuses/{sha}","languages_url":"https://api.github.com/repos/google/cadvisor/languages","stargazers_url":"https://api.github.com/repos/google/cadvisor/stargazers","contributors_url":"https://api.github.com/repos/google/cadvisor/contributors","subscribers_url":"https://api.github.com/repos/google/cadvisor/subscribers","subscription_url":"https://api.github.com/repos/google/cadvisor/subscription","commits_url":"https://api.github.com/repos/google/cadvisor/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/cadvisor/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/cadvisor/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/cadvisor/issues/comments/{number}","contents_url":"https://api.github.com/repos/google/cadvisor/contents/{+path}","compare_url":"https://api.github.com/repos/google/cadvisor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/cadvisor/merges","archive_url":"https://api.github.com/repos/google/cadvisor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/cadvisor/downloads","issues_url":"https://api.github.com/repos/google/cadvisor/issues{/number}","pulls_url":"https://api.github.com/repos/google/cadvisor/pulls{/number}","milestones_url":"https://api.github.com/repos/google/cadvisor/milestones{/number}","notifications_url":"https://api.github.com/repos/google/cadvisor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/cadvisor/labels{/name}","releases_url":"https://api.github.com/repos/google/cadvisor/releases{/id}","created_at":"2014-06-09T16:36:33Z","updated_at":"2014-10-24T18:16:20Z","pushed_at":"2014-10-21T16:58:32Z","git_url":"git://github.com/google/cadvisor.git","ssh_url":"git@github.com:google/cadvisor.git","clone_url":"https://github.com/google/cadvisor.git","svn_url":"https://github.com/google/cadvisor","homepage":"","size":19860,"stargazers_count":1336,"watchers_count":1336,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":100,"mirror_url":null,"open_issues_count":22,"forks":100,"open_issues":22,"watchers":1336,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/cadvisor/pulls/279"},"html":{"href":"https://github.com/google/cadvisor/pull/279"},"issue":{"href":"https://api.github.com/repos/google/cadvisor/issues/279"},"comments":{"href":"https://api.github.com/repos/google/cadvisor/issues/279/comments"},"review_comments":{"href":"https://api.github.com/repos/google/cadvisor/pulls/279/comments"},"review_comment":{"href":"https://api.github.com/repos/google/cadvisor/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/google/cadvisor/pulls/279/commits"},"statuses":{"href":"https://api.github.com/repos/google/cadvisor/statuses/e8ea485a0db8e550f05d6ed08515974ace41adf2"}}}}