GitHub PullRequestReviewCommentEvent at 2014-06-07 06:55:33
Repository: dolphin
Actor: degasus
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/13518383","id":13518383,"diff_hunk":"@@ -63,7 +63,7 @@ void SHADER::SetProgramVariables()\n \t// glsl shader must be bind to set samplers\n \tBind();","path":"Source/Core/VideoBackends/OGL/ProgramShaderCache.cpp","position":2,"original_position":2,"commit_id":"d2addbb4d49d31820edb317013c0d1b78c8e67d8","original_commit_id":"d2addbb4d49d31820edb317013c0d1b78c8e67d8","user":{"login":"degasus","id":2787141,"avatar_url":"https://avatars.githubusercontent.com/u/2787141?","gravatar_id":"2a6aaa713b73414f2b78d0645fd67690","url":"https://api.github.com/users/degasus","html_url":"https://github.com/degasus","followers_url":"https://api.github.com/users/degasus/followers","following_url":"https://api.github.com/users/degasus/following{/other_user}","gists_url":"https://api.github.com/users/degasus/gists{/gist_id}","starred_url":"https://api.github.com/users/degasus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/degasus/subscriptions","organizations_url":"https://api.github.com/users/degasus/orgs","repos_url":"https://api.github.com/users/degasus/repos","events_url":"https://api.github.com/users/degasus/events{/privacy}","received_events_url":"https://api.github.com/users/degasus/received_events","type":"User","site_admin":false},"body":"We don't have to call bind here any more. But please be careful, maybe we require it later ...","created_at":"2014-06-07T06:55:33Z","updated_at":"2014-06-07T06:55:33Z","html_url":"https://github.com/dolphin-emu/dolphin/pull/471#discussion_r13518383","pull_request_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/471","_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/13518383"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/471#discussion_r13518383"},"pull_request":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/471"}}},"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/471","id":16851581,"html_url":"https://github.com/dolphin-emu/dolphin/pull/471","diff_url":"https://github.com/dolphin-emu/dolphin/pull/471.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/471.patch","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/471","number":471,"state":"open","title":"Support Sampler binding in the shader.","user":{"login":"Sonicadvance1","id":1018829,"avatar_url":"https://avatars.githubusercontent.com/u/1018829?","gravatar_id":"260346efb6171dec817a5d92c637663c","url":"https://api.github.com/users/Sonicadvance1","html_url":"https://github.com/Sonicadvance1","followers_url":"https://api.github.com/users/Sonicadvance1/followers","following_url":"https://api.github.com/users/Sonicadvance1/following{/other_user}","gists_url":"https://api.github.com/users/Sonicadvance1/gists{/gist_id}","starred_url":"https://api.github.com/users/Sonicadvance1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sonicadvance1/subscriptions","organizations_url":"https://api.github.com/users/Sonicadvance1/orgs","repos_url":"https://api.github.com/users/Sonicadvance1/repos","events_url":"https://api.github.com/users/Sonicadvance1/events{/privacy}","received_events_url":"https://api.github.com/users/Sonicadvance1/received_events","type":"User","site_admin":false},"body":"In the cases where we support the binding layout keyword, use it for more than binding UBO location.\r\nThis changes it so it is supported for samplers as well.\r\n\r\nInstances when this is enabled is if a device supports GL_ARB_shading_language_420pack, or if it supports GLES 3.10.","created_at":"2014-06-07T05:32:41Z","updated_at":"2014-06-07T06:55:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c5e15c0dd7da35963bb1255ba4b34381e5f6eaab","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/471/commits","review_comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/471/comments","review_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/{number}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/471/comments","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/d2addbb4d49d31820edb317013c0d1b78c8e67d8","head":{"label":"Sonicadvance1:sampler_binding","ref":"sampler_binding","sha":"d2addbb4d49d31820edb317013c0d1b78c8e67d8","user":{"login":"Sonicadvance1","id":1018829,"avatar_url":"https://avatars.githubusercontent.com/u/1018829?","gravatar_id":"260346efb6171dec817a5d92c637663c","url":"https://api.github.com/users/Sonicadvance1","html_url":"https://github.com/Sonicadvance1","followers_url":"https://api.github.com/users/Sonicadvance1/followers","following_url":"https://api.github.com/users/Sonicadvance1/following{/other_user}","gists_url":"https://api.github.com/users/Sonicadvance1/gists{/gist_id}","starred_url":"https://api.github.com/users/Sonicadvance1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sonicadvance1/subscriptions","organizations_url":"https://api.github.com/users/Sonicadvance1/orgs","repos_url":"https://api.github.com/users/Sonicadvance1/repos","events_url":"https://api.github.com/users/Sonicadvance1/events{/privacy}","received_events_url":"https://api.github.com/users/Sonicadvance1/received_events","type":"User","site_admin":false},"repo":{"id":16360220,"name":"dolphin","full_name":"Sonicadvance1/dolphin","owner":{"login":"Sonicadvance1","id":1018829,"avatar_url":"https://avatars.githubusercontent.com/u/1018829?","gravatar_id":"260346efb6171dec817a5d92c637663c","url":"https://api.github.com/users/Sonicadvance1","html_url":"https://github.com/Sonicadvance1","followers_url":"https://api.github.com/users/Sonicadvance1/followers","following_url":"https://api.github.com/users/Sonicadvance1/following{/other_user}","gists_url":"https://api.github.com/users/Sonicadvance1/gists{/gist_id}","starred_url":"https://api.github.com/users/Sonicadvance1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sonicadvance1/subscriptions","organizations_url":"https://api.github.com/users/Sonicadvance1/orgs","repos_url":"https://api.github.com/users/Sonicadvance1/repos","events_url":"https://api.github.com/users/Sonicadvance1/events{/privacy}","received_events_url":"https://api.github.com/users/Sonicadvance1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Sonicadvance1/dolphin","description":"Dolphin is a GameCube/Wii emulator, allowing you to play games for these two platforms on PC, with improvements.","fork":true,"url":"https://api.github.com/repos/Sonicadvance1/dolphin","forks_url":"https://api.github.com/repos/Sonicadvance1/dolphin/forks","keys_url":"https://api.github.com/repos/Sonicadvance1/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sonicadvance1/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sonicadvance1/dolphin/teams","hooks_url":"https://api.github.com/repos/Sonicadvance1/dolphin/hooks","issue_events_url":"https://api.github.com/repos/Sonicadvance1/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/Sonicadvance1/dolphin/events","assignees_url":"https://api.github.com/repos/Sonicadvance1/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/Sonicadvance1/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/Sonicadvance1/dolphin/tags","blobs_url":"https://api.github.com/repos/Sonicadvance1/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sonicadvance1/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sonicadvance1/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sonicadvance1/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sonicadvance1/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/Sonicadvance1/dolphin/languages","stargazers_url":"https://api.github.com/repos/Sonicadvance1/dolphin/stargazers","contributors_url":"https://api.github.com/repos/Sonicadvance1/dolphin/contributors","subscribers_url":"https://api.github.com/repos/Sonicadvance1/dolphin/subscribers","subscription_url":"https://api.github.com/repos/Sonicadvance1/dolphin/subscription","commits_url":"https://api.github.com/repos/Sonicadvance1/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sonicadvance1/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sonicadvance1/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sonicadvance1/dolphin/issues/comments/{number}","contents_url":"https://api.github.com/repos/Sonicadvance1/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/Sonicadvance1/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sonicadvance1/dolphin/merges","archive_url":"https://api.github.com/repos/Sonicadvance1/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sonicadvance1/dolphin/downloads","issues_url":"https://api.github.com/repos/Sonicadvance1/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/Sonicadvance1/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/Sonicadvance1/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/Sonicadvance1/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sonicadvance1/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/Sonicadvance1/dolphin/releases{/id}","created_at":"2014-01-29T21:48:46Z","updated_at":"2014-06-07T05:32:41Z","pushed_at":"2014-06-07T05:32:22Z","git_url":"git://github.com/Sonicadvance1/dolphin.git","ssh_url":"git@github.com:Sonicadvance1/dolphin.git","clone_url":"https://github.com/Sonicadvance1/dolphin.git","svn_url":"https://github.com/Sonicadvance1/dolphin","homepage":null,"size":191143,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dolphin-emu:master","ref":"master","sha":"28c880251503521c4e046e7ccd2b957920eff1d4","user":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?","gravatar_id":"889eb5c76644c10900f277bef9b7b516","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":11577304,"name":"dolphin","full_name":"dolphin-emu/dolphin","owner":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?","gravatar_id":"889eb5c76644c10900f277bef9b7b516","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dolphin-emu/dolphin","description":"Dolphin is a GameCube/Wii emulator, allowing you to play games for these two platforms on PC, with improvements.","fork":false,"url":"https://api.github.com/repos/dolphin-emu/dolphin","forks_url":"https://api.github.com/repos/dolphin-emu/dolphin/forks","keys_url":"https://api.github.com/repos/dolphin-emu/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dolphin-emu/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dolphin-emu/dolphin/teams","hooks_url":"https://api.github.com/repos/dolphin-emu/dolphin/hooks","issue_events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/events","assignees_url":"https://api.github.com/repos/dolphin-emu/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/dolphin-emu/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/tags","blobs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/dolphin-emu/dolphin/languages","stargazers_url":"https://api.github.com/repos/dolphin-emu/dolphin/stargazers","contributors_url":"https://api.github.com/repos/dolphin-emu/dolphin/contributors","subscribers_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscribers","subscription_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscription","commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments/{number}","contents_url":"https://api.github.com/repos/dolphin-emu/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/dolphin-emu/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dolphin-emu/dolphin/merges","archive_url":"https://api.github.com/repos/dolphin-emu/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dolphin-emu/dolphin/downloads","issues_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/dolphin-emu/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/dolphin-emu/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/dolphin-emu/dolphin/releases{/id}","created_at":"2013-07-22T09:07:57Z","updated_at":"2014-06-07T06:49:08Z","pushed_at":"2014-06-07T06:49:07Z","git_url":"git://github.com/dolphin-emu/dolphin.git","ssh_url":"git@github.com:dolphin-emu/dolphin.git","clone_url":"https://github.com/dolphin-emu/dolphin.git","svn_url":"https://github.com/dolphin-emu/dolphin","homepage":null,"size":222742,"stargazers_count":314,"watchers_count":314,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":106,"mirror_url":null,"open_issues_count":49,"forks":106,"open_issues":49,"watchers":314,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/471"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/471"},"issue":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/471"},"comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/471/comments"},"review_comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/471/comments"},"review_comment":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/471/commits"},"statuses":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/d2addbb4d49d31820edb317013c0d1b78c8e67d8"}}}}