GitHub PullRequestEvent at 2014-08-29 14:44:47
Repository: openmicroscopy
Actor: jburel
Payload: {"action":"closed","number":2964,"pull_request":{"url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/pulls/2964","id":20195717,"html_url":"https://github.com/openmicroscopy/openmicroscopy/pull/2964","diff_url":"https://github.com/openmicroscopy/openmicroscopy/pull/2964.diff","patch_url":"https://github.com/openmicroscopy/openmicroscopy/pull/2964.patch","issue_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/2964","number":2964,"state":"closed","locked":false,"title":"OmeroCpp: Correct ice globbing","user":{"login":"rleigh-dundee","id":1528953,"avatar_url":"https://avatars.githubusercontent.com/u/1528953?v=2","gravatar_id":"e893a2912e39b821d2e51230f328bd75","url":"https://api.github.com/users/rleigh-dundee","html_url":"https://github.com/rleigh-dundee","followers_url":"https://api.github.com/users/rleigh-dundee/followers","following_url":"https://api.github.com/users/rleigh-dundee/following{/other_user}","gists_url":"https://api.github.com/users/rleigh-dundee/gists{/gist_id}","starred_url":"https://api.github.com/users/rleigh-dundee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rleigh-dundee/subscriptions","organizations_url":"https://api.github.com/users/rleigh-dundee/orgs","repos_url":"https://api.github.com/users/rleigh-dundee/repos","events_url":"https://api.github.com/users/rleigh-dundee/events{/privacy}","received_events_url":"https://api.github.com/users/rleigh-dundee/received_events","type":"User","site_admin":false},"body":"- Correctly glob model sources; some static model sources were excluded\r\n- Add ModelF to model; previously included implicitly\r\n- Add ServicesF to api\r\n\r\nThe main purpose is to correct a bug (missing static model sources) and to move ModelF and ServicesF to the correct component, snapping two circular deps between model/api and common (more are still present and still need fixing).  Since this is all still compiled as a single library, the link snapping has no functional effect at present; it's just one step on the way to fixing things.\r\n\r\n--------\r\n\r\nTesting: Run\r\n\r\n```\r\ncmake -Ddebug-ice-generation=ON /path/to/openmicroscopy\r\n```\r\n\r\nbefore and after this PR is merged.  Start with a clean openmicroscopy.git the first time.  Compare the output to verify that additional files are included:\r\n\r\n- `components/blitz/resources/omero/model/Details.ice`, `components/blitz/resources/omero/model/IObject.ice` and `components/blitz/resources/omero/model/Permissions.ice` in \"Static slice definitions (model)\"\r\n- `components/blitz/resources/omero/ServicesF.ice` in \"Static slice definitions (api)\", moved from \"(common)\"","created_at":"2014-08-22T20:37:48Z","updated_at":"2014-08-29T14:44:46Z","closed_at":"2014-08-29T14:44:46Z","merged_at":"2014-08-29T14:44:46Z","merge_commit_sha":"47751208021e9c2ffb80ce788fe14c405ebe0411","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/pulls/2964/commits","review_comments_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/pulls/2964/comments","review_comment_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/pulls/comments/{number}","comments_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/2964/comments","statuses_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/statuses/301f2a014b86b11c4fb64f9e313fff370b84de81","head":{"label":"rleigh-dundee:cmake-ice-fixes","ref":"cmake-ice-fixes","sha":"301f2a014b86b11c4fb64f9e313fff370b84de81","user":{"login":"rleigh-dundee","id":1528953,"avatar_url":"https://avatars.githubusercontent.com/u/1528953?v=2","gravatar_id":"e893a2912e39b821d2e51230f328bd75","url":"https://api.github.com/users/rleigh-dundee","html_url":"https://github.com/rleigh-dundee","followers_url":"https://api.github.com/users/rleigh-dundee/followers","following_url":"https://api.github.com/users/rleigh-dundee/following{/other_user}","gists_url":"https://api.github.com/users/rleigh-dundee/gists{/gist_id}","starred_url":"https://api.github.com/users/rleigh-dundee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rleigh-dundee/subscriptions","organizations_url":"https://api.github.com/users/rleigh-dundee/orgs","repos_url":"https://api.github.com/users/rleigh-dundee/repos","events_url":"https://api.github.com/users/rleigh-dundee/events{/privacy}","received_events_url":"https://api.github.com/users/rleigh-dundee/received_events","type":"User","site_admin":false},"repo":{"id":4574304,"name":"openmicroscopy","full_name":"rleigh-dundee/openmicroscopy","owner":{"login":"rleigh-dundee","id":1528953,"avatar_url":"https://avatars.githubusercontent.com/u/1528953?v=2","gravatar_id":"e893a2912e39b821d2e51230f328bd75","url":"https://api.github.com/users/rleigh-dundee","html_url":"https://github.com/rleigh-dundee","followers_url":"https://api.github.com/users/rleigh-dundee/followers","following_url":"https://api.github.com/users/rleigh-dundee/following{/other_user}","gists_url":"https://api.github.com/users/rleigh-dundee/gists{/gist_id}","starred_url":"https://api.github.com/users/rleigh-dundee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rleigh-dundee/subscriptions","organizations_url":"https://api.github.com/users/rleigh-dundee/orgs","repos_url":"https://api.github.com/users/rleigh-dundee/repos","events_url":"https://api.github.com/users/rleigh-dundee/events{/privacy}","received_events_url":"https://api.github.com/users/rleigh-dundee/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rleigh-dundee/openmicroscopy","description":"OME (Open Microscopy Environment) develops open-source software and data format standards for the storage and manipulation of biological light microscopy data. A joint project between universities, research establishments and industry in Europe and the USA, OME has over 20 active researchers with strong links to the microscopy community. Funded by private and public research grants, OME has been a major force on the international microscopy stage since 2000.","fork":true,"url":"https://api.github.com/repos/rleigh-dundee/openmicroscopy","forks_url":"https://api.github.com/repos/rleigh-dundee/openmicroscopy/forks","keys_url":"https://api.github.com/repos/rleigh-dundee/openmicroscopy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rleigh-dundee/openmicroscopy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rleigh-dundee/openmicroscopy/teams","hooks_url":"https://api.github.com/repos/rleigh-dundee/openmicroscopy/hooks","issue_events_url":"https://api.github.com/repos/rleigh-dundee/openmicroscopy/issues/events{/number}","events_url":"https://api.github.com/repos/rleigh-dundee/openmicroscopy/events","assignees_url":"https://api.github.com/repos/rleigh-dundee/openmicroscopy/assignees{/user}","branches_url":"https://api.github.com/repos/rleigh-dundee/openmicroscopy/branches{/branch}","tags_url":"https://api.github.com/repos/rleigh-dundee/openmicroscopy/tags","blobs_url":"https://api.github.com/repos/rleigh-dundee/openmicroscopy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rleigh-dundee/openmicroscopy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rleigh-dundee/openmicroscopy/git/refs{/sha}","trees_url":"https://api.github.com/repos/rleigh-dundee/openmicroscopy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rleigh-dundee/openmicroscopy/statuses/{sha}","languages_url":"https://api.github.com/repos/rleigh-dundee/openmicroscopy/languages","stargazers_url":"https://api.github.com/repos/rleigh-dundee/openmicroscopy/stargazers","contributors_url":"https://api.github.com/repos/rleigh-dundee/openmicroscopy/contributors","subscribers_url":"https://api.github.com/repos/rleigh-dundee/openmicroscopy/subscribers","subscription_url":"https://api.github.com/repos/rleigh-dundee/openmicroscopy/subscription","commits_url":"https://api.github.com/repos/rleigh-dundee/openmicroscopy/commits{/sha}","git_commits_url":"https://api.github.com/repos/rleigh-dundee/openmicroscopy/git/commits{/sha}","comments_url":"https://api.github.com/repos/rleigh-dundee/openmicroscopy/comments{/number}","issue_comment_url":"https://api.github.com/repos/rleigh-dundee/openmicroscopy/issues/comments/{number}","contents_url":"https://api.github.com/repos/rleigh-dundee/openmicroscopy/contents/{+path}","compare_url":"https://api.github.com/repos/rleigh-dundee/openmicroscopy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rleigh-dundee/openmicroscopy/merges","archive_url":"https://api.github.com/repos/rleigh-dundee/openmicroscopy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rleigh-dundee/openmicroscopy/downloads","issues_url":"https://api.github.com/repos/rleigh-dundee/openmicroscopy/issues{/number}","pulls_url":"https://api.github.com/repos/rleigh-dundee/openmicroscopy/pulls{/number}","milestones_url":"https://api.github.com/repos/rleigh-dundee/openmicroscopy/milestones{/number}","notifications_url":"https://api.github.com/repos/rleigh-dundee/openmicroscopy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rleigh-dundee/openmicroscopy/labels{/name}","releases_url":"https://api.github.com/repos/rleigh-dundee/openmicroscopy/releases{/id}","created_at":"2012-06-06T15:27:41Z","updated_at":"2014-06-11T09:28:48Z","pushed_at":"2014-08-29T14:44:11Z","git_url":"git://github.com/rleigh-dundee/openmicroscopy.git","ssh_url":"git@github.com:rleigh-dundee/openmicroscopy.git","clone_url":"https://github.com/rleigh-dundee/openmicroscopy.git","svn_url":"https://github.com/rleigh-dundee/openmicroscopy","homepage":"http://www.openmicroscopy.org","size":1951327,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"develop"}},"base":{"label":"openmicroscopy:develop","ref":"develop","sha":"1491e0969dd1bb551151126057bd6c19c27e368b","user":{"login":"openmicroscopy","id":975861,"avatar_url":"https://avatars.githubusercontent.com/u/975861?v=2","gravatar_id":"7424190904f55023bd16416af0fd799b","url":"https://api.github.com/users/openmicroscopy","html_url":"https://github.com/openmicroscopy","followers_url":"https://api.github.com/users/openmicroscopy/followers","following_url":"https://api.github.com/users/openmicroscopy/following{/other_user}","gists_url":"https://api.github.com/users/openmicroscopy/gists{/gist_id}","starred_url":"https://api.github.com/users/openmicroscopy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openmicroscopy/subscriptions","organizations_url":"https://api.github.com/users/openmicroscopy/orgs","repos_url":"https://api.github.com/users/openmicroscopy/repos","events_url":"https://api.github.com/users/openmicroscopy/events{/privacy}","received_events_url":"https://api.github.com/users/openmicroscopy/received_events","type":"Organization","site_admin":false},"repo":{"id":2228226,"name":"openmicroscopy","full_name":"openmicroscopy/openmicroscopy","owner":{"login":"openmicroscopy","id":975861,"avatar_url":"https://avatars.githubusercontent.com/u/975861?v=2","gravatar_id":"7424190904f55023bd16416af0fd799b","url":"https://api.github.com/users/openmicroscopy","html_url":"https://github.com/openmicroscopy","followers_url":"https://api.github.com/users/openmicroscopy/followers","following_url":"https://api.github.com/users/openmicroscopy/following{/other_user}","gists_url":"https://api.github.com/users/openmicroscopy/gists{/gist_id}","starred_url":"https://api.github.com/users/openmicroscopy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openmicroscopy/subscriptions","organizations_url":"https://api.github.com/users/openmicroscopy/orgs","repos_url":"https://api.github.com/users/openmicroscopy/repos","events_url":"https://api.github.com/users/openmicroscopy/events{/privacy}","received_events_url":"https://api.github.com/users/openmicroscopy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openmicroscopy/openmicroscopy","description":"OME (Open Microscopy Environment) develops open-source software and data format standards for the storage and manipulation of biological light microscopy data. A joint project between universities, research establishments and industry in Europe and the USA, OME has over 20 active researchers with strong links to the microscopy community. Funded by private and public research grants, OME has been a major force on the international microscopy stage since 2000.","fork":false,"url":"https://api.github.com/repos/openmicroscopy/openmicroscopy","forks_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/forks","keys_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/teams","hooks_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/hooks","issue_events_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/events{/number}","events_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/events","assignees_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/assignees{/user}","branches_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/branches{/branch}","tags_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/tags","blobs_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/git/refs{/sha}","trees_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/statuses/{sha}","languages_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/languages","stargazers_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/stargazers","contributors_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/contributors","subscribers_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/subscribers","subscription_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/subscription","commits_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/commits{/sha}","git_commits_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/git/commits{/sha}","comments_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/comments{/number}","issue_comment_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/comments/{number}","contents_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/contents/{+path}","compare_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/merges","archive_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/downloads","issues_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues{/number}","pulls_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/pulls{/number}","milestones_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/milestones{/number}","notifications_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/labels{/name}","releases_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/releases{/id}","created_at":"2011-08-18T14:26:02Z","updated_at":"2014-08-26T08:26:33Z","pushed_at":"2014-08-29T14:44:46Z","git_url":"git://github.com/openmicroscopy/openmicroscopy.git","ssh_url":"git@github.com:openmicroscopy/openmicroscopy.git","clone_url":"https://github.com/openmicroscopy/openmicroscopy.git","svn_url":"https://github.com/openmicroscopy/openmicroscopy","homepage":"http://www.openmicroscopy.org","size":2135848,"stargazers_count":59,"watchers_count":59,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":52,"mirror_url":null,"open_issues_count":40,"forks":52,"open_issues":40,"watchers":59,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/openmicroscopy/openmicroscopy/pulls/2964"},"html":{"href":"https://github.com/openmicroscopy/openmicroscopy/pull/2964"},"issue":{"href":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/2964"},"comments":{"href":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/2964/comments"},"review_comments":{"href":"https://api.github.com/repos/openmicroscopy/openmicroscopy/pulls/2964/comments"},"review_comment":{"href":"https://api.github.com/repos/openmicroscopy/openmicroscopy/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/openmicroscopy/openmicroscopy/pulls/2964/commits"},"statuses":{"href":"https://api.github.com/repos/openmicroscopy/openmicroscopy/statuses/301f2a014b86b11c4fb64f9e313fff370b84de81"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jburel","id":1022396,"avatar_url":"https://avatars.githubusercontent.com/u/1022396?v=2","gravatar_id":"e1f7a610652e5e71eda0b0b8381c3f98","url":"https://api.github.com/users/jburel","html_url":"https://github.com/jburel","followers_url":"https://api.github.com/users/jburel/followers","following_url":"https://api.github.com/users/jburel/following{/other_user}","gists_url":"https://api.github.com/users/jburel/gists{/gist_id}","starred_url":"https://api.github.com/users/jburel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jburel/subscriptions","organizations_url":"https://api.github.com/users/jburel/orgs","repos_url":"https://api.github.com/users/jburel/repos","events_url":"https://api.github.com/users/jburel/events{/privacy}","received_events_url":"https://api.github.com/users/jburel/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"commits":1,"additions":10,"deletions":5,"changed_files":1}}