GitHub PullRequestReviewCommentEvent at 2014-01-28 23:41:05
Repository: azure-activedirectory-library-for-android
Actor: borisvidolov
Payload: {"comment":{"url":"https://api.github.com/repos/MSOpenTech/azure-activedirectory-library-for-android/pulls/comments/9251097","id":9251097,"diff_hunk":"@@ -534,7 +551,22 @@ private AuthenticationResult processTokenResponse(HttpWebResponse webResponse) {\n             }\n             Logger.v(TAG, \"Server error message:\" + errMessage);\n             result = new AuthenticationResult(String.valueOf(webResponse.getStatusCode()),\n-                    errMessage, null);\n+                    errMessage);\n+        }\n+\n+        // Set correlationId in the result\n+        if (correlationIdInHeader != null && !correlationIdInHeader.isEmpty()) {\n+            try {\n+                UUID correlation = UUID.fromString(correlationIdInHeader);\n+                if (correlation != mRequest.getCorrelationId()) {\n+                    Logger.w(TAG, \"CorrelationId is not matching\", \"\",\n+                            ADALError.CORRELATION_ID_NOT_MATCHING_REQUEST_RESPONSE);\n+                }\n+\n+                Logger.v(TAG, \"Response correlationId:\" + correlationIdInHeader);\n+            } catch (Exception ex) {\n+                Logger.e(TAG, \"Correlation is not parsed\", \"\", ADALError.CORRELATION_ID_FORMAT, ex);","path":"adal/src/com/microsoft/adal/Oauth2.java","position":78,"original_position":78,"commit_id":"915b2f7a3b321e2c734982442ee7a413450ece71","original_commit_id":"915b2f7a3b321e2c734982442ee7a413450ece71","user":{"login":"borisvidolov","id":5383972,"avatar_url":"https://gravatar.com/avatar/914cc7bebd4a29a27b52130ad717e7d9?d=https%3A%2F%2Fidenticons.github.com%2Fd608faad6ac2d54d7fd91741ceab73a0.png&r=x","gravatar_id":"914cc7bebd4a29a27b52130ad717e7d9","url":"https://api.github.com/users/borisvidolov","html_url":"https://github.com/borisvidolov","followers_url":"https://api.github.com/users/borisvidolov/followers","following_url":"https://api.github.com/users/borisvidolov/following{/other_user}","gists_url":"https://api.github.com/users/borisvidolov/gists{/gist_id}","starred_url":"https://api.github.com/users/borisvidolov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/borisvidolov/subscriptions","organizations_url":"https://api.github.com/users/borisvidolov/orgs","repos_url":"https://api.github.com/users/borisvidolov/repos","events_url":"https://api.github.com/users/borisvidolov/events{/privacy}","received_events_url":"https://api.github.com/users/borisvidolov/received_events","type":"User","site_admin":false},"body":"\"Correlation Id cannot be parsed\" or \"Wrong format of the correlation ID\". You should also log the actual value that the server returned, so that we can see it in the logs.","created_at":"2014-01-28T23:41:05Z","updated_at":"2014-01-28T23:41:05Z","html_url":"https://github.com/MSOpenTech/azure-activedirectory-library-for-android/pull/39#discussion_r9251097","pull_request_url":"https://api.github.com/repos/MSOpenTech/azure-activedirectory-library-for-android/pulls/39","_links":{"self":{"href":"https://api.github.com/repos/MSOpenTech/azure-activedirectory-library-for-android/pulls/comments/9251097"},"html":{"href":"https://github.com/MSOpenTech/azure-activedirectory-library-for-android/pull/39#discussion_r9251097"},"pull_request":{"href":"https://api.github.com/repos/MSOpenTech/azure-activedirectory-library-for-android/pulls/39"}}}}