GitHub PullRequestReviewCommentEvent at 2014-08-25 15:13:46
Repository: robottelo
Actor: Ichimonji10
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/omaciel/robottelo/pulls/comments/16660515","id":16660515,"diff_hunk":"@@ -361,21 +366,16 @@ def test_cv_promote_badenvironment_negative(self):\n \n     # Content Views: publish\n     # katello content definition publish --label=MyView\n-    @data(*ContentViewDefinition.enumerate(label=\"\", description=\"\"))\n+    @stubbed","path":"tests/foreman/api/test_contentviews.py","position":22,"original_position":22,"commit_id":"7979376888bad0027e18d890cc69318f49488a48","original_commit_id":"7979376888bad0027e18d890cc69318f49488a48","user":{"login":"Ichimonji10","id":1012989,"avatar_url":"https://avatars.githubusercontent.com/u/1012989?v=2","gravatar_id":"0d55b0822baba206e15373fbe457bf70","url":"https://api.github.com/users/Ichimonji10","html_url":"https://github.com/Ichimonji10","followers_url":"https://api.github.com/users/Ichimonji10/followers","following_url":"https://api.github.com/users/Ichimonji10/following{/other_user}","gists_url":"https://api.github.com/users/Ichimonji10/gists{/gist_id}","starred_url":"https://api.github.com/users/Ichimonji10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ichimonji10/subscriptions","organizations_url":"https://api.github.com/users/Ichimonji10/orgs","repos_url":"https://api.github.com/users/Ichimonji10/repos","events_url":"https://api.github.com/users/Ichimonji10/events{/privacy}","received_events_url":"https://api.github.com/users/Ichimonji10/received_events","type":"User","site_admin":false},"body":"Same. Can these changes be made in a separate PR? I don't know if this code is related to the test being added or what.","created_at":"2014-08-25T15:13:46Z","updated_at":"2014-08-25T15:13:46Z","html_url":"https://github.com/omaciel/robottelo/pull/1225#discussion_r16660515","pull_request_url":"https://api.github.com/repos/omaciel/robottelo/pulls/1225","_links":{"self":{"href":"https://api.github.com/repos/omaciel/robottelo/pulls/comments/16660515"},"html":{"href":"https://github.com/omaciel/robottelo/pull/1225#discussion_r16660515"},"pull_request":{"href":"https://api.github.com/repos/omaciel/robottelo/pulls/1225"}}},"pull_request":{"url":"https://api.github.com/repos/omaciel/robottelo/pulls/1225","id":20186997,"html_url":"https://github.com/omaciel/robottelo/pull/1225","diff_url":"https://github.com/omaciel/robottelo/pull/1225.diff","patch_url":"https://github.com/omaciel/robottelo/pull/1225.patch","issue_url":"https://api.github.com/repos/omaciel/robottelo/issues/1225","number":1225,"state":"open","locked":false,"title":"test_cv_subscribe_system","user":{"login":"AdamSaleh","id":1478202,"avatar_url":"https://avatars.githubusercontent.com/u/1478202?v=2","gravatar_id":"2ddbe290ad47be36548ae5b472ceaf2b","url":"https://api.github.com/users/AdamSaleh","html_url":"https://github.com/AdamSaleh","followers_url":"https://api.github.com/users/AdamSaleh/followers","following_url":"https://api.github.com/users/AdamSaleh/following{/other_user}","gists_url":"https://api.github.com/users/AdamSaleh/gists{/gist_id}","starred_url":"https://api.github.com/users/AdamSaleh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdamSaleh/subscriptions","organizations_url":"https://api.github.com/users/AdamSaleh/orgs","repos_url":"https://api.github.com/users/AdamSaleh/repos","events_url":"https://api.github.com/users/AdamSaleh/events{/privacy}","received_events_url":"https://api.github.com/users/AdamSaleh/received_events","type":"User","site_admin":false},"body":"Lets have another round and hopefuly prevent another bazzillion comments :-) :\r\n\r\n1) if you thing that test_cv_subscribe_system attempts to test too much at once and I should first port the old promote/publish api tests before this one, tell me as well.\r\n\r\nBut I'd like to have this thing merged and then to move on to the rest of content-view stuff :-)","created_at":"2014-08-22T18:00:06Z","updated_at":"2014-08-25T15:13:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2aee1b356d19623ddb7b43f4871bc980de339a7f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/omaciel/robottelo/pulls/1225/commits","review_comments_url":"https://api.github.com/repos/omaciel/robottelo/pulls/1225/comments","review_comment_url":"https://api.github.com/repos/omaciel/robottelo/pulls/comments/{number}","comments_url":"https://api.github.com/repos/omaciel/robottelo/issues/1225/comments","statuses_url":"https://api.github.com/repos/omaciel/robottelo/statuses/7979376888bad0027e18d890cc69318f49488a48","head":{"label":"AdamSaleh:test-content-view-register","ref":"test-content-view-register","sha":"7979376888bad0027e18d890cc69318f49488a48","user":{"login":"AdamSaleh","id":1478202,"avatar_url":"https://avatars.githubusercontent.com/u/1478202?v=2","gravatar_id":"2ddbe290ad47be36548ae5b472ceaf2b","url":"https://api.github.com/users/AdamSaleh","html_url":"https://github.com/AdamSaleh","followers_url":"https://api.github.com/users/AdamSaleh/followers","following_url":"https://api.github.com/users/AdamSaleh/following{/other_user}","gists_url":"https://api.github.com/users/AdamSaleh/gists{/gist_id}","starred_url":"https://api.github.com/users/AdamSaleh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdamSaleh/subscriptions","organizations_url":"https://api.github.com/users/AdamSaleh/orgs","repos_url":"https://api.github.com/users/AdamSaleh/repos","events_url":"https://api.github.com/users/AdamSaleh/events{/privacy}","received_events_url":"https://api.github.com/users/AdamSaleh/received_events","type":"User","site_admin":false},"repo":{"id":15047222,"name":"robottelo","full_name":"AdamSaleh/robottelo","owner":{"login":"AdamSaleh","id":1478202,"avatar_url":"https://avatars.githubusercontent.com/u/1478202?v=2","gravatar_id":"2ddbe290ad47be36548ae5b472ceaf2b","url":"https://api.github.com/users/AdamSaleh","html_url":"https://github.com/AdamSaleh","followers_url":"https://api.github.com/users/AdamSaleh/followers","following_url":"https://api.github.com/users/AdamSaleh/following{/other_user}","gists_url":"https://api.github.com/users/AdamSaleh/gists{/gist_id}","starred_url":"https://api.github.com/users/AdamSaleh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdamSaleh/subscriptions","organizations_url":"https://api.github.com/users/AdamSaleh/orgs","repos_url":"https://api.github.com/users/AdamSaleh/repos","events_url":"https://api.github.com/users/AdamSaleh/events{/privacy}","received_events_url":"https://api.github.com/users/AdamSaleh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AdamSaleh/robottelo","description":"An automation testing framework for the Katello project.","fork":true,"url":"https://api.github.com/repos/AdamSaleh/robottelo","forks_url":"https://api.github.com/repos/AdamSaleh/robottelo/forks","keys_url":"https://api.github.com/repos/AdamSaleh/robottelo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AdamSaleh/robottelo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AdamSaleh/robottelo/teams","hooks_url":"https://api.github.com/repos/AdamSaleh/robottelo/hooks","issue_events_url":"https://api.github.com/repos/AdamSaleh/robottelo/issues/events{/number}","events_url":"https://api.github.com/repos/AdamSaleh/robottelo/events","assignees_url":"https://api.github.com/repos/AdamSaleh/robottelo/assignees{/user}","branches_url":"https://api.github.com/repos/AdamSaleh/robottelo/branches{/branch}","tags_url":"https://api.github.com/repos/AdamSaleh/robottelo/tags","blobs_url":"https://api.github.com/repos/AdamSaleh/robottelo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AdamSaleh/robottelo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AdamSaleh/robottelo/git/refs{/sha}","trees_url":"https://api.github.com/repos/AdamSaleh/robottelo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AdamSaleh/robottelo/statuses/{sha}","languages_url":"https://api.github.com/repos/AdamSaleh/robottelo/languages","stargazers_url":"https://api.github.com/repos/AdamSaleh/robottelo/stargazers","contributors_url":"https://api.github.com/repos/AdamSaleh/robottelo/contributors","subscribers_url":"https://api.github.com/repos/AdamSaleh/robottelo/subscribers","subscription_url":"https://api.github.com/repos/AdamSaleh/robottelo/subscription","commits_url":"https://api.github.com/repos/AdamSaleh/robottelo/commits{/sha}","git_commits_url":"https://api.github.com/repos/AdamSaleh/robottelo/git/commits{/sha}","comments_url":"https://api.github.com/repos/AdamSaleh/robottelo/comments{/number}","issue_comment_url":"https://api.github.com/repos/AdamSaleh/robottelo/issues/comments/{number}","contents_url":"https://api.github.com/repos/AdamSaleh/robottelo/contents/{+path}","compare_url":"https://api.github.com/repos/AdamSaleh/robottelo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AdamSaleh/robottelo/merges","archive_url":"https://api.github.com/repos/AdamSaleh/robottelo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AdamSaleh/robottelo/downloads","issues_url":"https://api.github.com/repos/AdamSaleh/robottelo/issues{/number}","pulls_url":"https://api.github.com/repos/AdamSaleh/robottelo/pulls{/number}","milestones_url":"https://api.github.com/repos/AdamSaleh/robottelo/milestones{/number}","notifications_url":"https://api.github.com/repos/AdamSaleh/robottelo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AdamSaleh/robottelo/labels{/name}","releases_url":"https://api.github.com/repos/AdamSaleh/robottelo/releases{/id}","created_at":"2013-12-09T12:55:15Z","updated_at":"2014-05-08T12:12:24Z","pushed_at":"2014-08-25T09:37:20Z","git_url":"git://github.com/AdamSaleh/robottelo.git","ssh_url":"git@github.com:AdamSaleh/robottelo.git","clone_url":"https://github.com/AdamSaleh/robottelo.git","svn_url":"https://github.com/AdamSaleh/robottelo","homepage":null,"size":5783,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"omaciel:master","ref":"master","sha":"4465e7a8df78dba0bad18dd4d6e595647313c52c","user":{"login":"omaciel","id":53362,"avatar_url":"https://avatars.githubusercontent.com/u/53362?v=2","gravatar_id":"5be9b08cd178f87cca6de19f00a9992c","url":"https://api.github.com/users/omaciel","html_url":"https://github.com/omaciel","followers_url":"https://api.github.com/users/omaciel/followers","following_url":"https://api.github.com/users/omaciel/following{/other_user}","gists_url":"https://api.github.com/users/omaciel/gists{/gist_id}","starred_url":"https://api.github.com/users/omaciel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omaciel/subscriptions","organizations_url":"https://api.github.com/users/omaciel/orgs","repos_url":"https://api.github.com/users/omaciel/repos","events_url":"https://api.github.com/users/omaciel/events{/privacy}","received_events_url":"https://api.github.com/users/omaciel/received_events","type":"User","site_admin":false},"repo":{"id":4000279,"name":"robottelo","full_name":"omaciel/robottelo","owner":{"login":"omaciel","id":53362,"avatar_url":"https://avatars.githubusercontent.com/u/53362?v=2","gravatar_id":"5be9b08cd178f87cca6de19f00a9992c","url":"https://api.github.com/users/omaciel","html_url":"https://github.com/omaciel","followers_url":"https://api.github.com/users/omaciel/followers","following_url":"https://api.github.com/users/omaciel/following{/other_user}","gists_url":"https://api.github.com/users/omaciel/gists{/gist_id}","starred_url":"https://api.github.com/users/omaciel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omaciel/subscriptions","organizations_url":"https://api.github.com/users/omaciel/orgs","repos_url":"https://api.github.com/users/omaciel/repos","events_url":"https://api.github.com/users/omaciel/events{/privacy}","received_events_url":"https://api.github.com/users/omaciel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/omaciel/robottelo","description":"An automation testing framework for the Katello project.","fork":false,"url":"https://api.github.com/repos/omaciel/robottelo","forks_url":"https://api.github.com/repos/omaciel/robottelo/forks","keys_url":"https://api.github.com/repos/omaciel/robottelo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/omaciel/robottelo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/omaciel/robottelo/teams","hooks_url":"https://api.github.com/repos/omaciel/robottelo/hooks","issue_events_url":"https://api.github.com/repos/omaciel/robottelo/issues/events{/number}","events_url":"https://api.github.com/repos/omaciel/robottelo/events","assignees_url":"https://api.github.com/repos/omaciel/robottelo/assignees{/user}","branches_url":"https://api.github.com/repos/omaciel/robottelo/branches{/branch}","tags_url":"https://api.github.com/repos/omaciel/robottelo/tags","blobs_url":"https://api.github.com/repos/omaciel/robottelo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/omaciel/robottelo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/omaciel/robottelo/git/refs{/sha}","trees_url":"https://api.github.com/repos/omaciel/robottelo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/omaciel/robottelo/statuses/{sha}","languages_url":"https://api.github.com/repos/omaciel/robottelo/languages","stargazers_url":"https://api.github.com/repos/omaciel/robottelo/stargazers","contributors_url":"https://api.github.com/repos/omaciel/robottelo/contributors","subscribers_url":"https://api.github.com/repos/omaciel/robottelo/subscribers","subscription_url":"https://api.github.com/repos/omaciel/robottelo/subscription","commits_url":"https://api.github.com/repos/omaciel/robottelo/commits{/sha}","git_commits_url":"https://api.github.com/repos/omaciel/robottelo/git/commits{/sha}","comments_url":"https://api.github.com/repos/omaciel/robottelo/comments{/number}","issue_comment_url":"https://api.github.com/repos/omaciel/robottelo/issues/comments/{number}","contents_url":"https://api.github.com/repos/omaciel/robottelo/contents/{+path}","compare_url":"https://api.github.com/repos/omaciel/robottelo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/omaciel/robottelo/merges","archive_url":"https://api.github.com/repos/omaciel/robottelo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/omaciel/robottelo/downloads","issues_url":"https://api.github.com/repos/omaciel/robottelo/issues{/number}","pulls_url":"https://api.github.com/repos/omaciel/robottelo/pulls{/number}","milestones_url":"https://api.github.com/repos/omaciel/robottelo/milestones{/number}","notifications_url":"https://api.github.com/repos/omaciel/robottelo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/omaciel/robottelo/labels{/name}","releases_url":"https://api.github.com/repos/omaciel/robottelo/releases{/id}","created_at":"2012-04-12T01:36:39Z","updated_at":"2014-06-27T23:03:18Z","pushed_at":"2014-08-25T12:57:24Z","git_url":"git://github.com/omaciel/robottelo.git","ssh_url":"git@github.com:omaciel/robottelo.git","clone_url":"https://github.com/omaciel/robottelo.git","svn_url":"https://github.com/omaciel/robottelo","homepage":null,"size":20056,"stargazers_count":16,"watchers_count":16,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":18,"mirror_url":null,"open_issues_count":101,"forks":18,"open_issues":101,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/omaciel/robottelo/pulls/1225"},"html":{"href":"https://github.com/omaciel/robottelo/pull/1225"},"issue":{"href":"https://api.github.com/repos/omaciel/robottelo/issues/1225"},"comments":{"href":"https://api.github.com/repos/omaciel/robottelo/issues/1225/comments"},"review_comments":{"href":"https://api.github.com/repos/omaciel/robottelo/pulls/1225/comments"},"review_comment":{"href":"https://api.github.com/repos/omaciel/robottelo/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/omaciel/robottelo/pulls/1225/commits"},"statuses":{"href":"https://api.github.com/repos/omaciel/robottelo/statuses/7979376888bad0027e18d890cc69318f49488a48"}}}}