GitHub PullRequestReviewCommentEvent at 2014-09-29 08:45:16
Repository: OpenRA
Actor: pchote
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments/18142743","id":18142743,"diff_hunk":"@@ -124,9 +127,10 @@ public Bridge GetNeighbor(int[] offset, BridgeLayer bridges)\n \n \t\tIRenderable[] TemplateRenderables(WorldRenderer wr, PaletteReference palette, ushort template)\n \t\t{\n+\t\t\tvar offset = FootprintUtils.CenterOffset(self.World, building.Info).Y + WRange.FromCells(1, 511).Range;","path":"OpenRA.Mods.RA/Bridge.cs","position":68,"original_position":68,"commit_id":"2437b8c354e9b91cca59b78db7504d1fb1c84506","original_commit_id":"2437b8c354e9b91cca59b78db7504d1fb1c84506","user":{"login":"pchote","id":167819,"avatar_url":"https://avatars.githubusercontent.com/u/167819?v=2","gravatar_id":"","url":"https://api.github.com/users/pchote","html_url":"https://github.com/pchote","followers_url":"https://api.github.com/users/pchote/followers","following_url":"https://api.github.com/users/pchote/following{/other_user}","gists_url":"https://api.github.com/users/pchote/gists{/gist_id}","starred_url":"https://api.github.com/users/pchote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pchote/subscriptions","organizations_url":"https://api.github.com/users/pchote/orgs","repos_url":"https://api.github.com/users/pchote/repos","events_url":"https://api.github.com/users/pchote/events{/privacy}","received_events_url":"https://api.github.com/users/pchote/received_events","type":"User","site_admin":false},"body":"This should be `footprint + 1024` to remain consistent with the old code (`footprint + 512` from `BelowUnits` plus an extra 512 from below).","created_at":"2014-09-29T08:45:16Z","updated_at":"2014-09-29T08:45:16Z","html_url":"https://github.com/OpenRA/OpenRA/pull/6456#discussion_r18142743","pull_request_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/6456","_links":{"self":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments/18142743"},"html":{"href":"https://github.com/OpenRA/OpenRA/pull/6456#discussion_r18142743"},"pull_request":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/6456"}}},"pull_request":{"url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/6456","id":21201962,"html_url":"https://github.com/OpenRA/OpenRA/pull/6456","diff_url":"https://github.com/OpenRA/OpenRA/pull/6456.diff","patch_url":"https://github.com/OpenRA/OpenRA/pull/6456.patch","issue_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/6456","number":6456,"state":"open","locked":false,"title":"Removed the BelowUnits trait","user":{"login":"Mailaender","id":756669,"avatar_url":"https://avatars.githubusercontent.com/u/756669?v=2","gravatar_id":"","url":"https://api.github.com/users/Mailaender","html_url":"https://github.com/Mailaender","followers_url":"https://api.github.com/users/Mailaender/followers","following_url":"https://api.github.com/users/Mailaender/following{/other_user}","gists_url":"https://api.github.com/users/Mailaender/gists{/gist_id}","starred_url":"https://api.github.com/users/Mailaender/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mailaender/subscriptions","organizations_url":"https://api.github.com/users/Mailaender/orgs","repos_url":"https://api.github.com/users/Mailaender/repos","events_url":"https://api.github.com/users/Mailaender/events{/privacy}","received_events_url":"https://api.github.com/users/Mailaender/received_events","type":"User","site_admin":false},"body":"as discussed in #3670. It is replaced by per sequence ZOffsets and won't conflict with it anymore.","created_at":"2014-09-14T08:43:22Z","updated_at":"2014-09-29T08:45:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f8312df9c54bfa22b784a293d5aba2565e780f84","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/6456/commits","review_comments_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/6456/comments","review_comment_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments/{number}","comments_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/6456/comments","statuses_url":"https://api.github.com/repos/OpenRA/OpenRA/statuses/2437b8c354e9b91cca59b78db7504d1fb1c84506","head":{"label":"Mailaender:remove-belowunits","ref":"remove-belowunits","sha":"2437b8c354e9b91cca59b78db7504d1fb1c84506","user":{"login":"Mailaender","id":756669,"avatar_url":"https://avatars.githubusercontent.com/u/756669?v=2","gravatar_id":"","url":"https://api.github.com/users/Mailaender","html_url":"https://github.com/Mailaender","followers_url":"https://api.github.com/users/Mailaender/followers","following_url":"https://api.github.com/users/Mailaender/following{/other_user}","gists_url":"https://api.github.com/users/Mailaender/gists{/gist_id}","starred_url":"https://api.github.com/users/Mailaender/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mailaender/subscriptions","organizations_url":"https://api.github.com/users/Mailaender/orgs","repos_url":"https://api.github.com/users/Mailaender/repos","events_url":"https://api.github.com/users/Mailaender/events{/privacy}","received_events_url":"https://api.github.com/users/Mailaender/received_events","type":"User","site_admin":false},"repo":{"id":3886414,"name":"OpenRA","full_name":"Mailaender/OpenRA","owner":{"login":"Mailaender","id":756669,"avatar_url":"https://avatars.githubusercontent.com/u/756669?v=2","gravatar_id":"","url":"https://api.github.com/users/Mailaender","html_url":"https://github.com/Mailaender","followers_url":"https://api.github.com/users/Mailaender/followers","following_url":"https://api.github.com/users/Mailaender/following{/other_user}","gists_url":"https://api.github.com/users/Mailaender/gists{/gist_id}","starred_url":"https://api.github.com/users/Mailaender/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mailaender/subscriptions","organizations_url":"https://api.github.com/users/Mailaender/orgs","repos_url":"https://api.github.com/users/Mailaender/repos","events_url":"https://api.github.com/users/Mailaender/events{/privacy}","received_events_url":"https://api.github.com/users/Mailaender/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Mailaender/OpenRA","description":"An open-source implementation of the Red Alert engine using .NET/mono and OpenGL. Runs on Windows, Linux and OSX.","fork":true,"url":"https://api.github.com/repos/Mailaender/OpenRA","forks_url":"https://api.github.com/repos/Mailaender/OpenRA/forks","keys_url":"https://api.github.com/repos/Mailaender/OpenRA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mailaender/OpenRA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mailaender/OpenRA/teams","hooks_url":"https://api.github.com/repos/Mailaender/OpenRA/hooks","issue_events_url":"https://api.github.com/repos/Mailaender/OpenRA/issues/events{/number}","events_url":"https://api.github.com/repos/Mailaender/OpenRA/events","assignees_url":"https://api.github.com/repos/Mailaender/OpenRA/assignees{/user}","branches_url":"https://api.github.com/repos/Mailaender/OpenRA/branches{/branch}","tags_url":"https://api.github.com/repos/Mailaender/OpenRA/tags","blobs_url":"https://api.github.com/repos/Mailaender/OpenRA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mailaender/OpenRA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mailaender/OpenRA/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mailaender/OpenRA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mailaender/OpenRA/statuses/{sha}","languages_url":"https://api.github.com/repos/Mailaender/OpenRA/languages","stargazers_url":"https://api.github.com/repos/Mailaender/OpenRA/stargazers","contributors_url":"https://api.github.com/repos/Mailaender/OpenRA/contributors","subscribers_url":"https://api.github.com/repos/Mailaender/OpenRA/subscribers","subscription_url":"https://api.github.com/repos/Mailaender/OpenRA/subscription","commits_url":"https://api.github.com/repos/Mailaender/OpenRA/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mailaender/OpenRA/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mailaender/OpenRA/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mailaender/OpenRA/issues/comments/{number}","contents_url":"https://api.github.com/repos/Mailaender/OpenRA/contents/{+path}","compare_url":"https://api.github.com/repos/Mailaender/OpenRA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mailaender/OpenRA/merges","archive_url":"https://api.github.com/repos/Mailaender/OpenRA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mailaender/OpenRA/downloads","issues_url":"https://api.github.com/repos/Mailaender/OpenRA/issues{/number}","pulls_url":"https://api.github.com/repos/Mailaender/OpenRA/pulls{/number}","milestones_url":"https://api.github.com/repos/Mailaender/OpenRA/milestones{/number}","notifications_url":"https://api.github.com/repos/Mailaender/OpenRA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mailaender/OpenRA/labels{/name}","releases_url":"https://api.github.com/repos/Mailaender/OpenRA/releases{/id}","created_at":"2012-03-31T15:36:43Z","updated_at":"2014-09-06T16:25:57Z","pushed_at":"2014-09-28T18:44:48Z","git_url":"git://github.com/Mailaender/OpenRA.git","ssh_url":"git@github.com:Mailaender/OpenRA.git","clone_url":"https://github.com/Mailaender/OpenRA.git","svn_url":"https://github.com/Mailaender/OpenRA","homepage":"http://www.openra.net","size":109895,"stargazers_count":7,"watchers_count":7,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":0,"forks":3,"open_issues":0,"watchers":7,"default_branch":"bleed"}},"base":{"label":"OpenRA:bleed","ref":"bleed","sha":"04b5c74a150166b5072c372cc220c9f0a2daa0c7","user":{"login":"OpenRA","id":409046,"avatar_url":"https://avatars.githubusercontent.com/u/409046?v=2","gravatar_id":"","url":"https://api.github.com/users/OpenRA","html_url":"https://github.com/OpenRA","followers_url":"https://api.github.com/users/OpenRA/followers","following_url":"https://api.github.com/users/OpenRA/following{/other_user}","gists_url":"https://api.github.com/users/OpenRA/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRA/subscriptions","organizations_url":"https://api.github.com/users/OpenRA/orgs","repos_url":"https://api.github.com/users/OpenRA/repos","events_url":"https://api.github.com/users/OpenRA/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRA/received_events","type":"Organization","site_admin":false},"repo":{"id":959908,"name":"OpenRA","full_name":"OpenRA/OpenRA","owner":{"login":"OpenRA","id":409046,"avatar_url":"https://avatars.githubusercontent.com/u/409046?v=2","gravatar_id":"","url":"https://api.github.com/users/OpenRA","html_url":"https://github.com/OpenRA","followers_url":"https://api.github.com/users/OpenRA/followers","following_url":"https://api.github.com/users/OpenRA/following{/other_user}","gists_url":"https://api.github.com/users/OpenRA/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRA/subscriptions","organizations_url":"https://api.github.com/users/OpenRA/orgs","repos_url":"https://api.github.com/users/OpenRA/repos","events_url":"https://api.github.com/users/OpenRA/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenRA/OpenRA","description":"An open-source implementation of the Command & Conquer: Red Alert engine using .NET/Mono and OpenGL. Runs on Windows, Linux and Mac OS X.","fork":false,"url":"https://api.github.com/repos/OpenRA/OpenRA","forks_url":"https://api.github.com/repos/OpenRA/OpenRA/forks","keys_url":"https://api.github.com/repos/OpenRA/OpenRA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenRA/OpenRA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenRA/OpenRA/teams","hooks_url":"https://api.github.com/repos/OpenRA/OpenRA/hooks","issue_events_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/events{/number}","events_url":"https://api.github.com/repos/OpenRA/OpenRA/events","assignees_url":"https://api.github.com/repos/OpenRA/OpenRA/assignees{/user}","branches_url":"https://api.github.com/repos/OpenRA/OpenRA/branches{/branch}","tags_url":"https://api.github.com/repos/OpenRA/OpenRA/tags","blobs_url":"https://api.github.com/repos/OpenRA/OpenRA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenRA/OpenRA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenRA/OpenRA/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenRA/OpenRA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenRA/OpenRA/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenRA/OpenRA/languages","stargazers_url":"https://api.github.com/repos/OpenRA/OpenRA/stargazers","contributors_url":"https://api.github.com/repos/OpenRA/OpenRA/contributors","subscribers_url":"https://api.github.com/repos/OpenRA/OpenRA/subscribers","subscription_url":"https://api.github.com/repos/OpenRA/OpenRA/subscription","commits_url":"https://api.github.com/repos/OpenRA/OpenRA/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenRA/OpenRA/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenRA/OpenRA/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/comments/{number}","contents_url":"https://api.github.com/repos/OpenRA/OpenRA/contents/{+path}","compare_url":"https://api.github.com/repos/OpenRA/OpenRA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenRA/OpenRA/merges","archive_url":"https://api.github.com/repos/OpenRA/OpenRA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenRA/OpenRA/downloads","issues_url":"https://api.github.com/repos/OpenRA/OpenRA/issues{/number}","pulls_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenRA/OpenRA/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenRA/OpenRA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenRA/OpenRA/labels{/name}","releases_url":"https://api.github.com/repos/OpenRA/OpenRA/releases{/id}","created_at":"2010-10-04T07:38:05Z","updated_at":"2014-09-29T07:39:46Z","pushed_at":"2014-09-29T08:17:21Z","git_url":"git://github.com/OpenRA/OpenRA.git","ssh_url":"git@github.com:OpenRA/OpenRA.git","clone_url":"https://github.com/OpenRA/OpenRA.git","svn_url":"https://github.com/OpenRA/OpenRA","homepage":"http://www.openra.net","size":171571,"stargazers_count":1363,"watchers_count":1363,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":452,"mirror_url":null,"open_issues_count":754,"forks":452,"open_issues":754,"watchers":1363,"default_branch":"bleed"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/6456"},"html":{"href":"https://github.com/OpenRA/OpenRA/pull/6456"},"issue":{"href":"https://api.github.com/repos/OpenRA/OpenRA/issues/6456"},"comments":{"href":"https://api.github.com/repos/OpenRA/OpenRA/issues/6456/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/6456/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/6456/commits"},"statuses":{"href":"https://api.github.com/repos/OpenRA/OpenRA/statuses/2437b8c354e9b91cca59b78db7504d1fb1c84506"}}}}