GitHub PullRequestReviewCommentEvent at 2014-08-31 15:10:21
Repository: phpunit
Actor: sun
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/sebastianbergmann/phpunit/pulls/comments/16935419","id":16935419,"diff_hunk":"@@ -184,8 +184,12 @@ protected static function restoreSuperGlobalArray($superGlobalArray)\n \n     public static function getIncludedFilesAsString()\n     {\n+        return static::processIncludedFilesAsString(get_included_files());\n+    }\n+\n+    public static function processIncludedFilesAsString(array $files)","path":"src/Util/GlobalState.php","position":7,"original_position":7,"commit_id":"d4387d6e24665324b733938c6756518437abb56b","original_commit_id":"d4387d6e24665324b733938c6756518437abb56b","user":{"login":"sun","id":41992,"avatar_url":"https://avatars.githubusercontent.com/u/41992?v=2","gravatar_id":"e6e589e42701b287671255b24f976286","url":"https://api.github.com/users/sun","html_url":"https://github.com/sun","followers_url":"https://api.github.com/users/sun/followers","following_url":"https://api.github.com/users/sun/following{/other_user}","gists_url":"https://api.github.com/users/sun/gists{/gist_id}","starred_url":"https://api.github.com/users/sun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sun/subscriptions","organizations_url":"https://api.github.com/users/sun/orgs","repos_url":"https://api.github.com/users/sun/repos","events_url":"https://api.github.com/users/sun/events{/privacy}","received_events_url":"https://api.github.com/users/sun/received_events","type":"User","site_admin":false},"body":"Hm.  Wondering whether it was a good idea to make this helper method publicly accessible?","created_at":"2014-08-31T15:10:21Z","updated_at":"2014-08-31T15:10:21Z","html_url":"https://github.com/sebastianbergmann/phpunit/pull/1382#discussion_r16935419","pull_request_url":"https://api.github.com/repos/sebastianbergmann/phpunit/pulls/1382","_links":{"self":{"href":"https://api.github.com/repos/sebastianbergmann/phpunit/pulls/comments/16935419"},"html":{"href":"https://github.com/sebastianbergmann/phpunit/pull/1382#discussion_r16935419"},"pull_request":{"href":"https://api.github.com/repos/sebastianbergmann/phpunit/pulls/1382"}}},"pull_request":{"url":"https://api.github.com/repos/sebastianbergmann/phpunit/pulls/1382","id":19510837,"html_url":"https://github.com/sebastianbergmann/phpunit/pull/1382","diff_url":"https://github.com/sebastianbergmann/phpunit/pull/1382.diff","patch_url":"https://github.com/sebastianbergmann/phpunit/pull/1382.patch","issue_url":"https://api.github.com/repos/sebastianbergmann/phpunit/issues/1382","number":1382,"state":"closed","locked":false,"title":"Fix stream includes throwing errors during global state preservation","user":{"login":"milesj","id":143744,"avatar_url":"https://avatars.githubusercontent.com/u/143744?v=2","gravatar_id":"2bebf4cb2fc99965264410111a0d2239","url":"https://api.github.com/users/milesj","html_url":"https://github.com/milesj","followers_url":"https://api.github.com/users/milesj/followers","following_url":"https://api.github.com/users/milesj/following{/other_user}","gists_url":"https://api.github.com/users/milesj/gists{/gist_id}","starred_url":"https://api.github.com/users/milesj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milesj/subscriptions","organizations_url":"https://api.github.com/users/milesj/orgs","repos_url":"https://api.github.com/users/milesj/repos","events_url":"https://api.github.com/users/milesj/events{/privacy}","received_events_url":"https://api.github.com/users/milesj/received_events","type":"User","site_admin":false},"body":"Related to issue #1308.\r\n\r\nI wasn't sure exactly where to write tests for this. Any guidance would be appreciated!","created_at":"2014-08-08T06:16:37Z","updated_at":"2014-08-31T15:10:21Z","closed_at":"2014-08-30T17:55:18Z","merged_at":"2014-08-30T17:55:18Z","merge_commit_sha":"d2e8bc119de5f85ced537230c98ba1dd3f43754a","assignee":null,"milestone":{"url":"https://api.github.com/repos/sebastianbergmann/phpunit/milestones/3","labels_url":"https://api.github.com/repos/sebastianbergmann/phpunit/milestones/3/labels","id":741673,"number":3,"title":"PHPUnit 4.4","description":"Alpha: August 8, 2014 - October 3, 2014\r\nBeta: October 3, 2014 - December 5, 2014","creator":{"login":"sebastianbergmann","id":25218,"avatar_url":"https://avatars.githubusercontent.com/u/25218?v=2","gravatar_id":"1f01f6b92d3be09868d1b65fca2d2fc1","url":"https://api.github.com/users/sebastianbergmann","html_url":"https://github.com/sebastianbergmann","followers_url":"https://api.github.com/users/sebastianbergmann/followers","following_url":"https://api.github.com/users/sebastianbergmann/following{/other_user}","gists_url":"https://api.github.com/users/sebastianbergmann/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastianbergmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastianbergmann/subscriptions","organizations_url":"https://api.github.com/users/sebastianbergmann/orgs","repos_url":"https://api.github.com/users/sebastianbergmann/repos","events_url":"https://api.github.com/users/sebastianbergmann/events{/privacy}","received_events_url":"https://api.github.com/users/sebastianbergmann/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":3,"state":"open","created_at":"2014-08-04T06:52:05Z","updated_at":"2014-08-30T17:55:18Z","due_on":"2014-12-05T08:00:00Z"},"commits_url":"https://api.github.com/repos/sebastianbergmann/phpunit/pulls/1382/commits","review_comments_url":"https://api.github.com/repos/sebastianbergmann/phpunit/pulls/1382/comments","review_comment_url":"https://api.github.com/repos/sebastianbergmann/phpunit/pulls/comments/{number}","comments_url":"https://api.github.com/repos/sebastianbergmann/phpunit/issues/1382/comments","statuses_url":"https://api.github.com/repos/sebastianbergmann/phpunit/statuses/d4387d6e24665324b733938c6756518437abb56b","head":{"label":"milesj:issue-1308","ref":"issue-1308","sha":"d4387d6e24665324b733938c6756518437abb56b","user":{"login":"milesj","id":143744,"avatar_url":"https://avatars.githubusercontent.com/u/143744?v=2","gravatar_id":"2bebf4cb2fc99965264410111a0d2239","url":"https://api.github.com/users/milesj","html_url":"https://github.com/milesj","followers_url":"https://api.github.com/users/milesj/followers","following_url":"https://api.github.com/users/milesj/following{/other_user}","gists_url":"https://api.github.com/users/milesj/gists{/gist_id}","starred_url":"https://api.github.com/users/milesj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milesj/subscriptions","organizations_url":"https://api.github.com/users/milesj/orgs","repos_url":"https://api.github.com/users/milesj/repos","events_url":"https://api.github.com/users/milesj/events{/privacy}","received_events_url":"https://api.github.com/users/milesj/received_events","type":"User","site_admin":false},"repo":{"id":22747736,"name":"phpunit","full_name":"milesj/phpunit","owner":{"login":"milesj","id":143744,"avatar_url":"https://avatars.githubusercontent.com/u/143744?v=2","gravatar_id":"2bebf4cb2fc99965264410111a0d2239","url":"https://api.github.com/users/milesj","html_url":"https://github.com/milesj","followers_url":"https://api.github.com/users/milesj/followers","following_url":"https://api.github.com/users/milesj/following{/other_user}","gists_url":"https://api.github.com/users/milesj/gists{/gist_id}","starred_url":"https://api.github.com/users/milesj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milesj/subscriptions","organizations_url":"https://api.github.com/users/milesj/orgs","repos_url":"https://api.github.com/users/milesj/repos","events_url":"https://api.github.com/users/milesj/events{/privacy}","received_events_url":"https://api.github.com/users/milesj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/milesj/phpunit","description":"The PHP Unit Testing framework.","fork":true,"url":"https://api.github.com/repos/milesj/phpunit","forks_url":"https://api.github.com/repos/milesj/phpunit/forks","keys_url":"https://api.github.com/repos/milesj/phpunit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/milesj/phpunit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/milesj/phpunit/teams","hooks_url":"https://api.github.com/repos/milesj/phpunit/hooks","issue_events_url":"https://api.github.com/repos/milesj/phpunit/issues/events{/number}","events_url":"https://api.github.com/repos/milesj/phpunit/events","assignees_url":"https://api.github.com/repos/milesj/phpunit/assignees{/user}","branches_url":"https://api.github.com/repos/milesj/phpunit/branches{/branch}","tags_url":"https://api.github.com/repos/milesj/phpunit/tags","blobs_url":"https://api.github.com/repos/milesj/phpunit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/milesj/phpunit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/milesj/phpunit/git/refs{/sha}","trees_url":"https://api.github.com/repos/milesj/phpunit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/milesj/phpunit/statuses/{sha}","languages_url":"https://api.github.com/repos/milesj/phpunit/languages","stargazers_url":"https://api.github.com/repos/milesj/phpunit/stargazers","contributors_url":"https://api.github.com/repos/milesj/phpunit/contributors","subscribers_url":"https://api.github.com/repos/milesj/phpunit/subscribers","subscription_url":"https://api.github.com/repos/milesj/phpunit/subscription","commits_url":"https://api.github.com/repos/milesj/phpunit/commits{/sha}","git_commits_url":"https://api.github.com/repos/milesj/phpunit/git/commits{/sha}","comments_url":"https://api.github.com/repos/milesj/phpunit/comments{/number}","issue_comment_url":"https://api.github.com/repos/milesj/phpunit/issues/comments/{number}","contents_url":"https://api.github.com/repos/milesj/phpunit/contents/{+path}","compare_url":"https://api.github.com/repos/milesj/phpunit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/milesj/phpunit/merges","archive_url":"https://api.github.com/repos/milesj/phpunit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/milesj/phpunit/downloads","issues_url":"https://api.github.com/repos/milesj/phpunit/issues{/number}","pulls_url":"https://api.github.com/repos/milesj/phpunit/pulls{/number}","milestones_url":"https://api.github.com/repos/milesj/phpunit/milestones{/number}","notifications_url":"https://api.github.com/repos/milesj/phpunit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/milesj/phpunit/labels{/name}","releases_url":"https://api.github.com/repos/milesj/phpunit/releases{/id}","created_at":"2014-08-08T06:06:15Z","updated_at":"2014-08-07T21:54:54Z","pushed_at":"2014-08-26T03:59:51Z","git_url":"git://github.com/milesj/phpunit.git","ssh_url":"git@github.com:milesj/phpunit.git","clone_url":"https://github.com/milesj/phpunit.git","svn_url":"https://github.com/milesj/phpunit","homepage":"http://phpunit.de/","size":17743,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":false,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sebastianbergmann:master","ref":"master","sha":"03b19771b3a77ee4318fba3816ca75d07746176f","user":{"login":"sebastianbergmann","id":25218,"avatar_url":"https://avatars.githubusercontent.com/u/25218?v=2","gravatar_id":"1f01f6b92d3be09868d1b65fca2d2fc1","url":"https://api.github.com/users/sebastianbergmann","html_url":"https://github.com/sebastianbergmann","followers_url":"https://api.github.com/users/sebastianbergmann/followers","following_url":"https://api.github.com/users/sebastianbergmann/following{/other_user}","gists_url":"https://api.github.com/users/sebastianbergmann/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastianbergmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastianbergmann/subscriptions","organizations_url":"https://api.github.com/users/sebastianbergmann/orgs","repos_url":"https://api.github.com/users/sebastianbergmann/repos","events_url":"https://api.github.com/users/sebastianbergmann/events{/privacy}","received_events_url":"https://api.github.com/users/sebastianbergmann/received_events","type":"User","site_admin":false},"repo":{"id":448045,"name":"phpunit","full_name":"sebastianbergmann/phpunit","owner":{"login":"sebastianbergmann","id":25218,"avatar_url":"https://avatars.githubusercontent.com/u/25218?v=2","gravatar_id":"1f01f6b92d3be09868d1b65fca2d2fc1","url":"https://api.github.com/users/sebastianbergmann","html_url":"https://github.com/sebastianbergmann","followers_url":"https://api.github.com/users/sebastianbergmann/followers","following_url":"https://api.github.com/users/sebastianbergmann/following{/other_user}","gists_url":"https://api.github.com/users/sebastianbergmann/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastianbergmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastianbergmann/subscriptions","organizations_url":"https://api.github.com/users/sebastianbergmann/orgs","repos_url":"https://api.github.com/users/sebastianbergmann/repos","events_url":"https://api.github.com/users/sebastianbergmann/events{/privacy}","received_events_url":"https://api.github.com/users/sebastianbergmann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sebastianbergmann/phpunit","description":"The PHP Unit Testing framework.","fork":false,"url":"https://api.github.com/repos/sebastianbergmann/phpunit","forks_url":"https://api.github.com/repos/sebastianbergmann/phpunit/forks","keys_url":"https://api.github.com/repos/sebastianbergmann/phpunit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sebastianbergmann/phpunit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sebastianbergmann/phpunit/teams","hooks_url":"https://api.github.com/repos/sebastianbergmann/phpunit/hooks","issue_events_url":"https://api.github.com/repos/sebastianbergmann/phpunit/issues/events{/number}","events_url":"https://api.github.com/repos/sebastianbergmann/phpunit/events","assignees_url":"https://api.github.com/repos/sebastianbergmann/phpunit/assignees{/user}","branches_url":"https://api.github.com/repos/sebastianbergmann/phpunit/branches{/branch}","tags_url":"https://api.github.com/repos/sebastianbergmann/phpunit/tags","blobs_url":"https://api.github.com/repos/sebastianbergmann/phpunit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sebastianbergmann/phpunit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sebastianbergmann/phpunit/git/refs{/sha}","trees_url":"https://api.github.com/repos/sebastianbergmann/phpunit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sebastianbergmann/phpunit/statuses/{sha}","languages_url":"https://api.github.com/repos/sebastianbergmann/phpunit/languages","stargazers_url":"https://api.github.com/repos/sebastianbergmann/phpunit/stargazers","contributors_url":"https://api.github.com/repos/sebastianbergmann/phpunit/contributors","subscribers_url":"https://api.github.com/repos/sebastianbergmann/phpunit/subscribers","subscription_url":"https://api.github.com/repos/sebastianbergmann/phpunit/subscription","commits_url":"https://api.github.com/repos/sebastianbergmann/phpunit/commits{/sha}","git_commits_url":"https://api.github.com/repos/sebastianbergmann/phpunit/git/commits{/sha}","comments_url":"https://api.github.com/repos/sebastianbergmann/phpunit/comments{/number}","issue_comment_url":"https://api.github.com/repos/sebastianbergmann/phpunit/issues/comments/{number}","contents_url":"https://api.github.com/repos/sebastianbergmann/phpunit/contents/{+path}","compare_url":"https://api.github.com/repos/sebastianbergmann/phpunit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sebastianbergmann/phpunit/merges","archive_url":"https://api.github.com/repos/sebastianbergmann/phpunit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sebastianbergmann/phpunit/downloads","issues_url":"https://api.github.com/repos/sebastianbergmann/phpunit/issues{/number}","pulls_url":"https://api.github.com/repos/sebastianbergmann/phpunit/pulls{/number}","milestones_url":"https://api.github.com/repos/sebastianbergmann/phpunit/milestones{/number}","notifications_url":"https://api.github.com/repos/sebastianbergmann/phpunit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sebastianbergmann/phpunit/labels{/name}","releases_url":"https://api.github.com/repos/sebastianbergmann/phpunit/releases{/id}","created_at":"2009-12-24T13:16:23Z","updated_at":"2014-08-31T14:05:59Z","pushed_at":"2014-08-31T07:03:55Z","git_url":"git://github.com/sebastianbergmann/phpunit.git","ssh_url":"git@github.com:sebastianbergmann/phpunit.git","clone_url":"https://github.com/sebastianbergmann/phpunit.git","svn_url":"https://github.com/sebastianbergmann/phpunit","homepage":"http://phpunit.de/","size":39450,"stargazers_count":3875,"watchers_count":3875,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":true,"forks_count":872,"mirror_url":null,"open_issues_count":110,"forks":872,"open_issues":110,"watchers":3875,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sebastianbergmann/phpunit/pulls/1382"},"html":{"href":"https://github.com/sebastianbergmann/phpunit/pull/1382"},"issue":{"href":"https://api.github.com/repos/sebastianbergmann/phpunit/issues/1382"},"comments":{"href":"https://api.github.com/repos/sebastianbergmann/phpunit/issues/1382/comments"},"review_comments":{"href":"https://api.github.com/repos/sebastianbergmann/phpunit/pulls/1382/comments"},"review_comment":{"href":"https://api.github.com/repos/sebastianbergmann/phpunit/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/sebastianbergmann/phpunit/pulls/1382/commits"},"statuses":{"href":"https://api.github.com/repos/sebastianbergmann/phpunit/statuses/d4387d6e24665324b733938c6756518437abb56b"}}}}