GitHub PullRequestReviewCommentEvent at 2014-12-15 11:07:51
Repository: akka
Actor: patriknw
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/akka/akka/pulls/comments/21817447","id":21817447,"diff_hunk":"@@ -0,0 +1,174 @@\n+/**\n+ * Copyright (C) 2014 Typesafe Inc. <http://www.typesafe.com>\n+ */\n+package docs.stream\n+\n+//#imports\n+\n+import java.util.Date\n+\n+import akka.actor.ActorSystem\n+import akka.stream.FlowMaterializer\n+import akka.stream.OverflowStrategy\n+import akka.stream.scaladsl.Broadcast\n+import akka.stream.scaladsl.Flow\n+import akka.stream.scaladsl.FlowGraph\n+import akka.stream.scaladsl.FlowGraphImplicits\n+import akka.stream.scaladsl.MaterializedMap\n+import akka.stream.scaladsl.RunnableFlow\n+import akka.stream.scaladsl.Sink\n+import akka.stream.scaladsl.Source\n+\n+import concurrent.Await\n+import concurrent.Future\n+\n+//#imports\n+\n+import akka.stream.testkit.AkkaSpec\n+\n+// TODO replace ⇒ with => and disable this intellij setting\n+class TwitterStreamQuickstartDocSpec extends AkkaSpec {\n+\n+  implicit val executionContext = system.dispatcher\n+\n+  //#model\n+  final case class Author(handle: String)\n+  val AkkaTeam = Author(\"akkateam\")\n+\n+  final case class Hashtag(name: String)\n+\n+  final case class Tweet(author: Author, timestamp: Long, body: String) {\n+    def hashtags: List[Hashtag] =\n+      body.split(\" \").toList.collect { case t if t.startsWith(\"#\") ⇒ Hashtag(t) }\n+  }\n+  //#model\n+\n+  trait Example0 {\n+    //#tweet-source\n+    val tweets: Source[Tweet]\n+    //#tweet-source\n+  }\n+\n+  trait Example1 {\n+    trait X {\n+      //#materializer-setup\n+      implicit val syste = ActorSystem(\"reactive-tweets\")","path":"akka-docs-dev/rst/scala/code/docs/stream/TwitterStreamQuickstartDocSpec.scala","position":55,"original_position":55,"commit_id":"b1e953c7965db6fa17bdb8ce87ee2f3f03497b82","original_commit_id":"b1e953c7965db6fa17bdb8ce87ee2f3f03497b82","user":{"login":"patriknw","id":336161,"avatar_url":"https://avatars.githubusercontent.com/u/336161?v=3","gravatar_id":"","url":"https://api.github.com/users/patriknw","html_url":"https://github.com/patriknw","followers_url":"https://api.github.com/users/patriknw/followers","following_url":"https://api.github.com/users/patriknw/following{/other_user}","gists_url":"https://api.github.com/users/patriknw/gists{/gist_id}","starred_url":"https://api.github.com/users/patriknw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patriknw/subscriptions","organizations_url":"https://api.github.com/users/patriknw/orgs","repos_url":"https://api.github.com/users/patriknw/repos","events_url":"https://api.github.com/users/patriknw/events{/privacy}","received_events_url":"https://api.github.com/users/patriknw/received_events","type":"User","site_admin":false},"body":"system","created_at":"2014-12-15T11:07:51Z","updated_at":"2014-12-15T11:07:51Z","html_url":"https://github.com/akka/akka/pull/16526#discussion_r21817447","pull_request_url":"https://api.github.com/repos/akka/akka/pulls/16526","_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/comments/21817447"},"html":{"href":"https://github.com/akka/akka/pull/16526#discussion_r21817447"},"pull_request":{"href":"https://api.github.com/repos/akka/akka/pulls/16526"}}},"pull_request":{"url":"https://api.github.com/repos/akka/akka/pulls/16526","id":25915889,"html_url":"https://github.com/akka/akka/pull/16526","diff_url":"https://github.com/akka/akka/pull/16526.diff","patch_url":"https://github.com/akka/akka/pull/16526.patch","issue_url":"https://api.github.com/repos/akka/akka/issues/16526","number":16526,"state":"open","locked":false,"title":"WIP Initial draft of akka-streams QuickStart and docs","user":{"login":"ktoso","id":120979,"avatar_url":"https://avatars.githubusercontent.com/u/120979?v=3","gravatar_id":"","url":"https://api.github.com/users/ktoso","html_url":"https://github.com/ktoso","followers_url":"https://api.github.com/users/ktoso/followers","following_url":"https://api.github.com/users/ktoso/following{/other_user}","gists_url":"https://api.github.com/users/ktoso/gists{/gist_id}","starred_url":"https://api.github.com/users/ktoso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktoso/subscriptions","organizations_url":"https://api.github.com/users/ktoso/orgs","repos_url":"https://api.github.com/users/ktoso/repos","events_url":"https://api.github.com/users/ktoso/events{/privacy}","received_events_url":"https://api.github.com/users/ktoso/received_events","type":"User","site_admin":false},"body":"Loads of things to do still, but first wanted some feedback on the quickstart. If this is the right style we should be aiming for. \r\n\r\nMost likely needs more links into the in depth parts of the docs, but as they don't exist yet that was though ;-)\r\n\r\nAnd important note - these docs still use the old layout, we need to fix that as well.\r\n\r\nrefs https://github.com/akka/akka/issues/16483","created_at":"2014-12-11T17:11:33Z","updated_at":"2014-12-15T11:07:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9287175a0765f7f80c1d58312bf2f266b202a66e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/akka/akka/pulls/16526/commits","review_comments_url":"https://api.github.com/repos/akka/akka/pulls/16526/comments","review_comment_url":"https://api.github.com/repos/akka/akka/pulls/comments/{number}","comments_url":"https://api.github.com/repos/akka/akka/issues/16526/comments","statuses_url":"https://api.github.com/repos/akka/akka/statuses/b1e953c7965db6fa17bdb8ce87ee2f3f03497b82","head":{"label":"ktoso:docs-streams-quickstart-ktoso","ref":"docs-streams-quickstart-ktoso","sha":"b1e953c7965db6fa17bdb8ce87ee2f3f03497b82","user":{"login":"ktoso","id":120979,"avatar_url":"https://avatars.githubusercontent.com/u/120979?v=3","gravatar_id":"","url":"https://api.github.com/users/ktoso","html_url":"https://github.com/ktoso","followers_url":"https://api.github.com/users/ktoso/followers","following_url":"https://api.github.com/users/ktoso/following{/other_user}","gists_url":"https://api.github.com/users/ktoso/gists{/gist_id}","starred_url":"https://api.github.com/users/ktoso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktoso/subscriptions","organizations_url":"https://api.github.com/users/ktoso/orgs","repos_url":"https://api.github.com/users/ktoso/repos","events_url":"https://api.github.com/users/ktoso/events{/privacy}","received_events_url":"https://api.github.com/users/ktoso/received_events","type":"User","site_admin":false},"repo":{"id":4462204,"name":"akka","full_name":"ktoso/akka","owner":{"login":"ktoso","id":120979,"avatar_url":"https://avatars.githubusercontent.com/u/120979?v=3","gravatar_id":"","url":"https://api.github.com/users/ktoso","html_url":"https://github.com/ktoso","followers_url":"https://api.github.com/users/ktoso/followers","following_url":"https://api.github.com/users/ktoso/following{/other_user}","gists_url":"https://api.github.com/users/ktoso/gists{/gist_id}","starred_url":"https://api.github.com/users/ktoso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktoso/subscriptions","organizations_url":"https://api.github.com/users/ktoso/orgs","repos_url":"https://api.github.com/users/ktoso/repos","events_url":"https://api.github.com/users/ktoso/events{/privacy}","received_events_url":"https://api.github.com/users/ktoso/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ktoso/akka","description":"Akka Project","fork":true,"url":"https://api.github.com/repos/ktoso/akka","forks_url":"https://api.github.com/repos/ktoso/akka/forks","keys_url":"https://api.github.com/repos/ktoso/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ktoso/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ktoso/akka/teams","hooks_url":"https://api.github.com/repos/ktoso/akka/hooks","issue_events_url":"https://api.github.com/repos/ktoso/akka/issues/events{/number}","events_url":"https://api.github.com/repos/ktoso/akka/events","assignees_url":"https://api.github.com/repos/ktoso/akka/assignees{/user}","branches_url":"https://api.github.com/repos/ktoso/akka/branches{/branch}","tags_url":"https://api.github.com/repos/ktoso/akka/tags","blobs_url":"https://api.github.com/repos/ktoso/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ktoso/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ktoso/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/ktoso/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ktoso/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/ktoso/akka/languages","stargazers_url":"https://api.github.com/repos/ktoso/akka/stargazers","contributors_url":"https://api.github.com/repos/ktoso/akka/contributors","subscribers_url":"https://api.github.com/repos/ktoso/akka/subscribers","subscription_url":"https://api.github.com/repos/ktoso/akka/subscription","commits_url":"https://api.github.com/repos/ktoso/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/ktoso/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/ktoso/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/ktoso/akka/issues/comments/{number}","contents_url":"https://api.github.com/repos/ktoso/akka/contents/{+path}","compare_url":"https://api.github.com/repos/ktoso/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ktoso/akka/merges","archive_url":"https://api.github.com/repos/ktoso/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ktoso/akka/downloads","issues_url":"https://api.github.com/repos/ktoso/akka/issues{/number}","pulls_url":"https://api.github.com/repos/ktoso/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/ktoso/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/ktoso/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ktoso/akka/labels{/name}","releases_url":"https://api.github.com/repos/ktoso/akka/releases{/id}","created_at":"2012-05-27T14:05:17Z","updated_at":"2014-12-03T15:22:34Z","pushed_at":"2014-12-15T09:51:55Z","git_url":"git://github.com/ktoso/akka.git","ssh_url":"git@github.com:ktoso/akka.git","clone_url":"https://github.com/ktoso/akka.git","svn_url":"https://github.com/ktoso/akka","homepage":"http://akka.io","size":156407,"stargazers_count":1,"watchers_count":1,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"akka:release-2.3-dev","ref":"release-2.3-dev","sha":"d79f2ef22b7e337ac1638647f11bc7d6511056b1","user":{"login":"akka","id":1496237,"avatar_url":"https://avatars.githubusercontent.com/u/1496237?v=3","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"repo":{"id":130013,"name":"akka","full_name":"akka/akka","owner":{"login":"akka","id":1496237,"avatar_url":"https://avatars.githubusercontent.com/u/1496237?v=3","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akka/akka","description":"Akka Project","fork":false,"url":"https://api.github.com/repos/akka/akka","forks_url":"https://api.github.com/repos/akka/akka/forks","keys_url":"https://api.github.com/repos/akka/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akka/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akka/akka/teams","hooks_url":"https://api.github.com/repos/akka/akka/hooks","issue_events_url":"https://api.github.com/repos/akka/akka/issues/events{/number}","events_url":"https://api.github.com/repos/akka/akka/events","assignees_url":"https://api.github.com/repos/akka/akka/assignees{/user}","branches_url":"https://api.github.com/repos/akka/akka/branches{/branch}","tags_url":"https://api.github.com/repos/akka/akka/tags","blobs_url":"https://api.github.com/repos/akka/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akka/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akka/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/akka/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akka/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/akka/akka/languages","stargazers_url":"https://api.github.com/repos/akka/akka/stargazers","contributors_url":"https://api.github.com/repos/akka/akka/contributors","subscribers_url":"https://api.github.com/repos/akka/akka/subscribers","subscription_url":"https://api.github.com/repos/akka/akka/subscription","commits_url":"https://api.github.com/repos/akka/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/akka/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/akka/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/akka/akka/issues/comments/{number}","contents_url":"https://api.github.com/repos/akka/akka/contents/{+path}","compare_url":"https://api.github.com/repos/akka/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akka/akka/merges","archive_url":"https://api.github.com/repos/akka/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akka/akka/downloads","issues_url":"https://api.github.com/repos/akka/akka/issues{/number}","pulls_url":"https://api.github.com/repos/akka/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/akka/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/akka/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akka/akka/labels{/name}","releases_url":"https://api.github.com/repos/akka/akka/releases{/id}","created_at":"2009-02-16T12:51:54Z","updated_at":"2014-12-15T11:01:37Z","pushed_at":"2014-12-15T10:25:29Z","git_url":"git://github.com/akka/akka.git","ssh_url":"git@github.com:akka/akka.git","clone_url":"https://github.com/akka/akka.git","svn_url":"https://github.com/akka/akka","homepage":"http://akka.io","size":231913,"stargazers_count":3303,"watchers_count":3303,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":927,"mirror_url":null,"open_issues_count":544,"forks":927,"open_issues":544,"watchers":3303,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/16526"},"html":{"href":"https://github.com/akka/akka/pull/16526"},"issue":{"href":"https://api.github.com/repos/akka/akka/issues/16526"},"comments":{"href":"https://api.github.com/repos/akka/akka/issues/16526/comments"},"review_comments":{"href":"https://api.github.com/repos/akka/akka/pulls/16526/comments"},"review_comment":{"href":"https://api.github.com/repos/akka/akka/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/akka/akka/pulls/16526/commits"},"statuses":{"href":"https://api.github.com/repos/akka/akka/statuses/b1e953c7965db6fa17bdb8ce87ee2f3f03497b82"}}}}