GitHub PullRequestReviewCommentEvent at 2014-08-25 00:57:40
Repository: Cataclysm-DDA
Actor: KA101
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/16639626","id":16639626,"diff_hunk":"@@ -517,6 +517,7 @@ bool map::process_fields_in_submap( submap *const current_submap,\n                         bool destroyed = false; //Is the item destroyed?\n                         // Volume, Smoke generation probability, consumed items count\n                         int vol = 0, smoke = 0, consumed = 0;\n+                        // Needs to consume at least cur->getFieldDensity() * 2\n                         for (auto it = items_here.begin(); it != items_here.end() &&\n                                  consumed < cur->getFieldDensity() * 2;) {\n                             // Stop when we hit the end of the item buffer OR we consumed","path":"src/field.cpp","position":7,"original_position":7,"commit_id":"92c00e8ba4794fbd3b64dc621403b790aa694af3","original_commit_id":"92c00e8ba4794fbd3b64dc621403b790aa694af3","user":{"login":"KA101","id":4195632,"avatar_url":"https://avatars.githubusercontent.com/u/4195632?v=2","gravatar_id":"c0aaba5414c665bf7320bed5ee919a3c","url":"https://api.github.com/users/KA101","html_url":"https://github.com/KA101","followers_url":"https://api.github.com/users/KA101/followers","following_url":"https://api.github.com/users/KA101/following{/other_user}","gists_url":"https://api.github.com/users/KA101/gists{/gist_id}","starred_url":"https://api.github.com/users/KA101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KA101/subscriptions","organizations_url":"https://api.github.com/users/KA101/orgs","repos_url":"https://api.github.com/users/KA101/repos","events_url":"https://api.github.com/users/KA101/events{/privacy}","received_events_url":"https://api.github.com/users/KA101/received_events","type":"User","site_admin":false},"body":"I hate it when I read things wrong.  np.  ;-)","created_at":"2014-08-25T00:57:40Z","updated_at":"2014-08-25T00:57:40Z","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/8680#discussion_r16639626","pull_request_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/8680","_links":{"self":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/16639626"},"html":{"href":"https://github.com/CleverRaven/Cataclysm-DDA/pull/8680#discussion_r16639626"},"pull_request":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/8680"}}},"pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/8680","id":20225140,"html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/8680","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/8680.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/8680.patch","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/8680","number":8680,"state":"open","locked":false,"title":"Fix for #8602","user":{"login":"EpicOrange","id":6273197,"avatar_url":"https://avatars.githubusercontent.com/u/6273197?v=2","gravatar_id":"5472e10609b158b62af6a503aea4c073","url":"https://api.github.com/users/EpicOrange","html_url":"https://github.com/EpicOrange","followers_url":"https://api.github.com/users/EpicOrange/followers","following_url":"https://api.github.com/users/EpicOrange/following{/other_user}","gists_url":"https://api.github.com/users/EpicOrange/gists{/gist_id}","starred_url":"https://api.github.com/users/EpicOrange/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EpicOrange/subscriptions","organizations_url":"https://api.github.com/users/EpicOrange/orgs","repos_url":"https://api.github.com/users/EpicOrange/repos","events_url":"https://api.github.com/users/EpicOrange/events{/privacy}","received_events_url":"https://api.github.com/users/EpicOrange/received_events","type":"User","site_admin":false},"body":"Something about fires not consuming ammo type items. #8602 ","created_at":"2014-08-24T23:43:34Z","updated_at":"2014-08-25T00:57:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b0620b8ef07acc6c944baaaa4c48e25433d4dada","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/8680/commits","review_comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/8680/comments","review_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/{number}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/8680/comments","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/92c00e8ba4794fbd3b64dc621403b790aa694af3","head":{"label":"EpicOrange:burning-stackables-fix","ref":"burning-stackables-fix","sha":"92c00e8ba4794fbd3b64dc621403b790aa694af3","user":{"login":"EpicOrange","id":6273197,"avatar_url":"https://avatars.githubusercontent.com/u/6273197?v=2","gravatar_id":"5472e10609b158b62af6a503aea4c073","url":"https://api.github.com/users/EpicOrange","html_url":"https://github.com/EpicOrange","followers_url":"https://api.github.com/users/EpicOrange/followers","following_url":"https://api.github.com/users/EpicOrange/following{/other_user}","gists_url":"https://api.github.com/users/EpicOrange/gists{/gist_id}","starred_url":"https://api.github.com/users/EpicOrange/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EpicOrange/subscriptions","organizations_url":"https://api.github.com/users/EpicOrange/orgs","repos_url":"https://api.github.com/users/EpicOrange/repos","events_url":"https://api.github.com/users/EpicOrange/events{/privacy}","received_events_url":"https://api.github.com/users/EpicOrange/received_events","type":"User","site_admin":false},"repo":{"id":22412258,"name":"Cataclysm-DDA","full_name":"EpicOrange/Cataclysm-DDA","owner":{"login":"EpicOrange","id":6273197,"avatar_url":"https://avatars.githubusercontent.com/u/6273197?v=2","gravatar_id":"5472e10609b158b62af6a503aea4c073","url":"https://api.github.com/users/EpicOrange","html_url":"https://github.com/EpicOrange","followers_url":"https://api.github.com/users/EpicOrange/followers","following_url":"https://api.github.com/users/EpicOrange/following{/other_user}","gists_url":"https://api.github.com/users/EpicOrange/gists{/gist_id}","starred_url":"https://api.github.com/users/EpicOrange/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EpicOrange/subscriptions","organizations_url":"https://api.github.com/users/EpicOrange/orgs","repos_url":"https://api.github.com/users/EpicOrange/repos","events_url":"https://api.github.com/users/EpicOrange/events{/privacy}","received_events_url":"https://api.github.com/users/EpicOrange/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/EpicOrange/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A fork/variant of Cataclysm Roguelike by Whales.","fork":true,"url":"https://api.github.com/repos/EpicOrange/Cataclysm-DDA","forks_url":"https://api.github.com/repos/EpicOrange/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/EpicOrange/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EpicOrange/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EpicOrange/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/EpicOrange/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/EpicOrange/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/EpicOrange/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/EpicOrange/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/EpicOrange/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/EpicOrange/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/EpicOrange/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EpicOrange/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EpicOrange/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/EpicOrange/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EpicOrange/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/EpicOrange/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/EpicOrange/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/EpicOrange/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/EpicOrange/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/EpicOrange/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/EpicOrange/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/EpicOrange/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/EpicOrange/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/EpicOrange/Cataclysm-DDA/issues/comments/{number}","contents_url":"https://api.github.com/repos/EpicOrange/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/EpicOrange/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EpicOrange/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/EpicOrange/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EpicOrange/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/EpicOrange/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/EpicOrange/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/EpicOrange/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/EpicOrange/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EpicOrange/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/EpicOrange/Cataclysm-DDA/releases{/id}","created_at":"2014-07-30T06:30:57Z","updated_at":"2014-08-02T20:54:43Z","pushed_at":"2014-08-24T23:39:49Z","git_url":"git://github.com/EpicOrange/Cataclysm-DDA.git","ssh_url":"git@github.com:EpicOrange/Cataclysm-DDA.git","clone_url":"https://github.com/EpicOrange/Cataclysm-DDA.git","svn_url":"https://github.com/EpicOrange/Cataclysm-DDA","homepage":"http://en.cataclysmdda.com/","size":175480,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CleverRaven:master","ref":"master","sha":"c8ff4a7227d0d15f8487ac2c97c4b00566720cba","user":{"login":"CleverRaven","id":4367009,"avatar_url":"https://avatars.githubusercontent.com/u/4367009?v=2","gravatar_id":null,"url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"repo":{"id":5973855,"name":"Cataclysm-DDA","full_name":"CleverRaven/Cataclysm-DDA","owner":{"login":"CleverRaven","id":4367009,"avatar_url":"https://avatars.githubusercontent.com/u/4367009?v=2","gravatar_id":null,"url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CleverRaven/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A fork/variant of Cataclysm Roguelike by Whales.","fork":false,"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA","forks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments/{number}","contents_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/releases{/id}","created_at":"2012-09-26T22:57:43Z","updated_at":"2014-08-24T06:54:04Z","pushed_at":"2014-08-24T23:35:23Z","git_url":"git://github.com/CleverRaven/Cataclysm-DDA.git","ssh_url":"git@github.com:CleverRaven/Cataclysm-DDA.git","clone_url":"https://github.com/CleverRaven/Cataclysm-DDA.git","svn_url":"https://github.com/CleverRaven/Cataclysm-DDA","homepage":"http://en.cataclysmdda.com/","size":263154,"stargazers_count":456,"watchers_count":456,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":524,"mirror_url":null,"open_issues_count":692,"forks":524,"open_issues":692,"watchers":456,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/8680"},"html":{"href":"https://github.com/CleverRaven/Cataclysm-DDA/pull/8680"},"issue":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/8680"},"comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/8680/comments"},"review_comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/8680/comments"},"review_comment":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/8680/commits"},"statuses":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/92c00e8ba4794fbd3b64dc621403b790aa694af3"}}}}