GitHub PullRequestEvent at 2014-08-06 13:56:08
Repository: bitcore
Actor: maraoz
Payload: {"action":"closed","number":459,"pull_request":{"url":"https://api.github.com/repos/bitpay/bitcore/pulls/459","id":18919356,"html_url":"https://github.com/bitpay/bitcore/pull/459","diff_url":"https://github.com/bitpay/bitcore/pull/459.diff","patch_url":"https://github.com/bitpay/bitcore/pull/459.patch","issue_url":"https://api.github.com/repos/bitpay/bitcore/issues/459","number":459,"state":"closed","title":"add support for signing messages in compressed format","user":{"login":"ryanxcharles","id":63740,"avatar_url":"https://avatars.githubusercontent.com/u/63740?v=2","gravatar_id":"17e6619ba42a009b25f1883641e64e1c","url":"https://api.github.com/users/ryanxcharles","html_url":"https://github.com/ryanxcharles","followers_url":"https://api.github.com/users/ryanxcharles/followers","following_url":"https://api.github.com/users/ryanxcharles/following{/other_user}","gists_url":"https://api.github.com/users/ryanxcharles/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanxcharles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanxcharles/subscriptions","organizations_url":"https://api.github.com/users/ryanxcharles/orgs","repos_url":"https://api.github.com/users/ryanxcharles/repos","events_url":"https://api.github.com/users/ryanxcharles/events{/privacy}","received_events_url":"https://api.github.com/users/ryanxcharles/received_events","type":"User","site_admin":false},"body":"...this is the standard way to sign messages in bitcoin-qt. Note that the\r\nformat of a compressed signature, for messages, is quite distinct from DER\r\nformat, which is used in transactions. This commit also adds support for\r\nrecovering the public key from a signature, which is necessary for this. The\r\ncode for public key recover is taken from bitcoinjs-lib.","created_at":"2014-07-25T21:09:02Z","updated_at":"2014-08-06T13:56:07Z","closed_at":"2014-08-06T13:56:07Z","merged_at":"2014-08-06T13:56:07Z","merge_commit_sha":"404b4160702695e700315ae317ec5d203506a598","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bitpay/bitcore/pulls/459/commits","review_comments_url":"https://api.github.com/repos/bitpay/bitcore/pulls/459/comments","review_comment_url":"https://api.github.com/repos/bitpay/bitcore/pulls/comments/{number}","comments_url":"https://api.github.com/repos/bitpay/bitcore/issues/459/comments","statuses_url":"https://api.github.com/repos/bitpay/bitcore/statuses/f87da3b5baeb38c70086639c6b8f257bebbde4c2","head":{"label":"ryanxcharles:feature/message-signing","ref":"feature/message-signing","sha":"f87da3b5baeb38c70086639c6b8f257bebbde4c2","user":{"login":"ryanxcharles","id":63740,"avatar_url":"https://avatars.githubusercontent.com/u/63740?v=2","gravatar_id":"17e6619ba42a009b25f1883641e64e1c","url":"https://api.github.com/users/ryanxcharles","html_url":"https://github.com/ryanxcharles","followers_url":"https://api.github.com/users/ryanxcharles/followers","following_url":"https://api.github.com/users/ryanxcharles/following{/other_user}","gists_url":"https://api.github.com/users/ryanxcharles/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanxcharles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanxcharles/subscriptions","organizations_url":"https://api.github.com/users/ryanxcharles/orgs","repos_url":"https://api.github.com/users/ryanxcharles/repos","events_url":"https://api.github.com/users/ryanxcharles/events{/privacy}","received_events_url":"https://api.github.com/users/ryanxcharles/received_events","type":"User","site_admin":false},"repo":{"id":17028332,"name":"bitcore","full_name":"ryanxcharles/bitcore","owner":{"login":"ryanxcharles","id":63740,"avatar_url":"https://avatars.githubusercontent.com/u/63740?v=2","gravatar_id":"17e6619ba42a009b25f1883641e64e1c","url":"https://api.github.com/users/ryanxcharles","html_url":"https://github.com/ryanxcharles","followers_url":"https://api.github.com/users/ryanxcharles/followers","following_url":"https://api.github.com/users/ryanxcharles/following{/other_user}","gists_url":"https://api.github.com/users/ryanxcharles/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanxcharles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanxcharles/subscriptions","organizations_url":"https://api.github.com/users/ryanxcharles/orgs","repos_url":"https://api.github.com/users/ryanxcharles/repos","events_url":"https://api.github.com/users/ryanxcharles/events{/privacy}","received_events_url":"https://api.github.com/users/ryanxcharles/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ryanxcharles/bitcore","description":"A bitcoin library for your javascript.","fork":true,"url":"https://api.github.com/repos/ryanxcharles/bitcore","forks_url":"https://api.github.com/repos/ryanxcharles/bitcore/forks","keys_url":"https://api.github.com/repos/ryanxcharles/bitcore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ryanxcharles/bitcore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ryanxcharles/bitcore/teams","hooks_url":"https://api.github.com/repos/ryanxcharles/bitcore/hooks","issue_events_url":"https://api.github.com/repos/ryanxcharles/bitcore/issues/events{/number}","events_url":"https://api.github.com/repos/ryanxcharles/bitcore/events","assignees_url":"https://api.github.com/repos/ryanxcharles/bitcore/assignees{/user}","branches_url":"https://api.github.com/repos/ryanxcharles/bitcore/branches{/branch}","tags_url":"https://api.github.com/repos/ryanxcharles/bitcore/tags","blobs_url":"https://api.github.com/repos/ryanxcharles/bitcore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ryanxcharles/bitcore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ryanxcharles/bitcore/git/refs{/sha}","trees_url":"https://api.github.com/repos/ryanxcharles/bitcore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ryanxcharles/bitcore/statuses/{sha}","languages_url":"https://api.github.com/repos/ryanxcharles/bitcore/languages","stargazers_url":"https://api.github.com/repos/ryanxcharles/bitcore/stargazers","contributors_url":"https://api.github.com/repos/ryanxcharles/bitcore/contributors","subscribers_url":"https://api.github.com/repos/ryanxcharles/bitcore/subscribers","subscription_url":"https://api.github.com/repos/ryanxcharles/bitcore/subscription","commits_url":"https://api.github.com/repos/ryanxcharles/bitcore/commits{/sha}","git_commits_url":"https://api.github.com/repos/ryanxcharles/bitcore/git/commits{/sha}","comments_url":"https://api.github.com/repos/ryanxcharles/bitcore/comments{/number}","issue_comment_url":"https://api.github.com/repos/ryanxcharles/bitcore/issues/comments/{number}","contents_url":"https://api.github.com/repos/ryanxcharles/bitcore/contents/{+path}","compare_url":"https://api.github.com/repos/ryanxcharles/bitcore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ryanxcharles/bitcore/merges","archive_url":"https://api.github.com/repos/ryanxcharles/bitcore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ryanxcharles/bitcore/downloads","issues_url":"https://api.github.com/repos/ryanxcharles/bitcore/issues{/number}","pulls_url":"https://api.github.com/repos/ryanxcharles/bitcore/pulls{/number}","milestones_url":"https://api.github.com/repos/ryanxcharles/bitcore/milestones{/number}","notifications_url":"https://api.github.com/repos/ryanxcharles/bitcore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ryanxcharles/bitcore/labels{/name}","releases_url":"https://api.github.com/repos/ryanxcharles/bitcore/releases{/id}","created_at":"2014-02-20T17:08:28Z","updated_at":"2014-07-04T05:38:17Z","pushed_at":"2014-07-25T23:38:28Z","git_url":"git://github.com/ryanxcharles/bitcore.git","ssh_url":"git@github.com:ryanxcharles/bitcore.git","clone_url":"https://github.com/ryanxcharles/bitcore.git","svn_url":"https://github.com/ryanxcharles/bitcore","homepage":"http://bitcore.io","size":9091,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bitpay:master","ref":"master","sha":"9937ec6312622d3981c4d644f1dd8f4ec451d7a5","user":{"login":"bitpay","id":2554930,"avatar_url":"https://avatars.githubusercontent.com/u/2554930?v=2","gravatar_id":"25ea89d58931785dfe8e9e1aa5b0f117","url":"https://api.github.com/users/bitpay","html_url":"https://github.com/bitpay","followers_url":"https://api.github.com/users/bitpay/followers","following_url":"https://api.github.com/users/bitpay/following{/other_user}","gists_url":"https://api.github.com/users/bitpay/gists{/gist_id}","starred_url":"https://api.github.com/users/bitpay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitpay/subscriptions","organizations_url":"https://api.github.com/users/bitpay/orgs","repos_url":"https://api.github.com/users/bitpay/repos","events_url":"https://api.github.com/users/bitpay/events{/privacy}","received_events_url":"https://api.github.com/users/bitpay/received_events","type":"Organization","site_admin":false},"repo":{"id":15259244,"name":"bitcore","full_name":"bitpay/bitcore","owner":{"login":"bitpay","id":2554930,"avatar_url":"https://avatars.githubusercontent.com/u/2554930?v=2","gravatar_id":"25ea89d58931785dfe8e9e1aa5b0f117","url":"https://api.github.com/users/bitpay","html_url":"https://github.com/bitpay","followers_url":"https://api.github.com/users/bitpay/followers","following_url":"https://api.github.com/users/bitpay/following{/other_user}","gists_url":"https://api.github.com/users/bitpay/gists{/gist_id}","starred_url":"https://api.github.com/users/bitpay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitpay/subscriptions","organizations_url":"https://api.github.com/users/bitpay/orgs","repos_url":"https://api.github.com/users/bitpay/repos","events_url":"https://api.github.com/users/bitpay/events{/privacy}","received_events_url":"https://api.github.com/users/bitpay/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitpay/bitcore","description":"A bitcoin library for your javascript.","fork":true,"url":"https://api.github.com/repos/bitpay/bitcore","forks_url":"https://api.github.com/repos/bitpay/bitcore/forks","keys_url":"https://api.github.com/repos/bitpay/bitcore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitpay/bitcore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitpay/bitcore/teams","hooks_url":"https://api.github.com/repos/bitpay/bitcore/hooks","issue_events_url":"https://api.github.com/repos/bitpay/bitcore/issues/events{/number}","events_url":"https://api.github.com/repos/bitpay/bitcore/events","assignees_url":"https://api.github.com/repos/bitpay/bitcore/assignees{/user}","branches_url":"https://api.github.com/repos/bitpay/bitcore/branches{/branch}","tags_url":"https://api.github.com/repos/bitpay/bitcore/tags","blobs_url":"https://api.github.com/repos/bitpay/bitcore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitpay/bitcore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitpay/bitcore/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitpay/bitcore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitpay/bitcore/statuses/{sha}","languages_url":"https://api.github.com/repos/bitpay/bitcore/languages","stargazers_url":"https://api.github.com/repos/bitpay/bitcore/stargazers","contributors_url":"https://api.github.com/repos/bitpay/bitcore/contributors","subscribers_url":"https://api.github.com/repos/bitpay/bitcore/subscribers","subscription_url":"https://api.github.com/repos/bitpay/bitcore/subscription","commits_url":"https://api.github.com/repos/bitpay/bitcore/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitpay/bitcore/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitpay/bitcore/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitpay/bitcore/issues/comments/{number}","contents_url":"https://api.github.com/repos/bitpay/bitcore/contents/{+path}","compare_url":"https://api.github.com/repos/bitpay/bitcore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitpay/bitcore/merges","archive_url":"https://api.github.com/repos/bitpay/bitcore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitpay/bitcore/downloads","issues_url":"https://api.github.com/repos/bitpay/bitcore/issues{/number}","pulls_url":"https://api.github.com/repos/bitpay/bitcore/pulls{/number}","milestones_url":"https://api.github.com/repos/bitpay/bitcore/milestones{/number}","notifications_url":"https://api.github.com/repos/bitpay/bitcore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitpay/bitcore/labels{/name}","releases_url":"https://api.github.com/repos/bitpay/bitcore/releases{/id}","created_at":"2013-12-17T16:10:28Z","updated_at":"2014-08-05T21:11:32Z","pushed_at":"2014-08-06T13:56:08Z","git_url":"git://github.com/bitpay/bitcore.git","ssh_url":"git@github.com:bitpay/bitcore.git","clone_url":"https://github.com/bitpay/bitcore.git","svn_url":"https://github.com/bitpay/bitcore","homepage":"http://bitcore.io","size":16470,"stargazers_count":1008,"watchers_count":1008,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":196,"mirror_url":null,"open_issues_count":53,"forks":196,"open_issues":53,"watchers":1008,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitpay/bitcore/pulls/459"},"html":{"href":"https://github.com/bitpay/bitcore/pull/459"},"issue":{"href":"https://api.github.com/repos/bitpay/bitcore/issues/459"},"comments":{"href":"https://api.github.com/repos/bitpay/bitcore/issues/459/comments"},"review_comments":{"href":"https://api.github.com/repos/bitpay/bitcore/pulls/459/comments"},"review_comment":{"href":"https://api.github.com/repos/bitpay/bitcore/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/bitpay/bitcore/pulls/459/commits"},"statuses":{"href":"https://api.github.com/repos/bitpay/bitcore/statuses/f87da3b5baeb38c70086639c6b8f257bebbde4c2"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"maraoz","id":287189,"avatar_url":"https://avatars.githubusercontent.com/u/287189?v=2","gravatar_id":"3cb6f4d191e4e6e833e0119806243682","url":"https://api.github.com/users/maraoz","html_url":"https://github.com/maraoz","followers_url":"https://api.github.com/users/maraoz/followers","following_url":"https://api.github.com/users/maraoz/following{/other_user}","gists_url":"https://api.github.com/users/maraoz/gists{/gist_id}","starred_url":"https://api.github.com/users/maraoz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maraoz/subscriptions","organizations_url":"https://api.github.com/users/maraoz/orgs","repos_url":"https://api.github.com/users/maraoz/repos","events_url":"https://api.github.com/users/maraoz/events{/privacy}","received_events_url":"https://api.github.com/users/maraoz/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":311,"deletions":17,"changed_files":6}}