GitHub PullRequestReviewCommentEvent at 2014-02-09 17:54:14
Repository: storm-metrics-statsd
Actor: jt6211
Payload: {"comment":{"url":"https://api.github.com/repos/endgameinc/storm-metrics-statsd/pulls/comments/9569766","id":9569766,"diff_hunk":"@@ -139,7 +139,8 @@ public String toString() {\n \t\tStringBuilder sb = new StringBuilder()\n \t\t\t\t.append(clean(taskInfo.srcWorkerHost)).append(\".\")\n \t\t\t\t.append(taskInfo.srcWorkerPort).append(\".\")\n-\t\t\t\t.append(clean(taskInfo.srcComponentId)).append(\".\");\n+\t\t\t\t.append(clean(taskInfo.srcComponentId)).append(\".\")\n+\t\t\t\t.append(taskInfo.srcTaskId).append(\".\");","path":"src/main/java/com/endgame/storm/metrics/statsd/StatsdMetricConsumer.java","position":15,"original_position":15,"commit_id":"f014217243d986f6d35b402ee6b5140a8fc19361","original_commit_id":"f014217243d986f6d35b402ee6b5140a8fc19361","user":{"login":"jt6211","id":820464,"avatar_url":"https://gravatar.com/avatar/881091b27cc75786cf4dc106785399eb?d=https%3A%2F%2Fidenticons.github.com%2F46e4525fb2d0ee8f7fea67460e297cb7.png&r=x","gravatar_id":"881091b27cc75786cf4dc106785399eb","url":"https://api.github.com/users/jt6211","html_url":"https://github.com/jt6211","followers_url":"https://api.github.com/users/jt6211/followers","following_url":"https://api.github.com/users/jt6211/following{/other_user}","gists_url":"https://api.github.com/users/jt6211/gists{/gist_id}","starred_url":"https://api.github.com/users/jt6211/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jt6211/subscriptions","organizations_url":"https://api.github.com/users/jt6211/orgs","repos_url":"https://api.github.com/users/jt6211/repos","events_url":"https://api.github.com/users/jt6211/events{/privacy}","received_events_url":"https://api.github.com/users/jt6211/received_events","type":"User","site_admin":false},"body":"I originally did not include the taskID on purpose.  It is because the task ID assignment seems arbitrary (i.e. the same taskID is not assigned to the same worker/port) across topology restarts.  So, to view this data in any sensible view in graphite, you would have to use sumSeries() and a wildcard on the taskID.  To simplify things I just didn't include it.\r\n\r\nI would probably be more open to making this a configurable option (e.g. `metrics.statsd.includeTaskID`) so it can be turned on/off, with the default being off.","created_at":"2014-02-09T17:54:14Z","updated_at":"2014-02-09T17:54:14Z","html_url":"https://github.com/endgameinc/storm-metrics-statsd/pull/1#discussion_r9569766","pull_request_url":"https://api.github.com/repos/endgameinc/storm-metrics-statsd/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/endgameinc/storm-metrics-statsd/pulls/comments/9569766"},"html":{"href":"https://github.com/endgameinc/storm-metrics-statsd/pull/1#discussion_r9569766"},"pull_request":{"href":"https://api.github.com/repos/endgameinc/storm-metrics-statsd/pulls/1"}}}}