GitHub PullRequestReviewCommentEvent at 2014-06-26 09:12:59
Repository: edx-platform
Actor: auraz
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/14231443","id":14231443,"diff_hunk":"@@ -327,8 +328,30 @@ def test_successful_verify_oauth_body_sign(self):\n         \"\"\"\n         try:\n             self.xmodule.verify_oauth_body_sign(self.get_signed_grade_mock_request())\n-        except LTIError:\n-            self.fail(\"verify_oauth_body_sign() raised LTIError unexpectedly!\")\n+        except LTIError as err:\n+            self.fail(\"verify_oauth_body_sign() raised LTIError: \" + err.message)\n+\n+    def test_wrong_xml_namespace(self):\n+        \"\"\"\n+        Test wrong XML Namespace.\n+\n+        Tests that tool provider returned grade back with wrong XML Namespace.\n+        \"\"\"\n+        with self.assertRaises(IndexError):\n+            mocked_request = self.get_signed_grade_mock_request(namespace_v1p0=False)\n+            self.xmodule.parse_grade_xml_body(mocked_request.body)\n+\n+    def test_good_xml_namespace(self):\n+        \"\"\"\n+        Test good XML Namespace.\n+\n+        Tests that xml body was parsed successfully.\n+        \"\"\"\n+        mocked_request = self.get_signed_grade_mock_request()\n+        try:\n+            imsx_messageIdentifier, sourcedId, score, action = self.xmodule.parse_grade_xml_body(mocked_request.body)\n+        except IndexError as err:\n+            self.fail(\"parse_grade_xml_body() raised IndexError: \" + err.message)","path":"common/lib/xmodule/xmodule/tests/test_lti_unit.py","position":46,"original_position":46,"commit_id":"c63ba473b8b68c1cac9df619478d7428bc55231e","original_commit_id":"c63ba473b8b68c1cac9df619478d7428bc55231e","user":{"login":"auraz","id":67241,"avatar_url":"https://avatars.githubusercontent.com/u/67241?","gravatar_id":"9acee8355c23cc3cd1c89f32ce277099","url":"https://api.github.com/users/auraz","html_url":"https://github.com/auraz","followers_url":"https://api.github.com/users/auraz/followers","following_url":"https://api.github.com/users/auraz/following{/other_user}","gists_url":"https://api.github.com/users/auraz/gists{/gist_id}","starred_url":"https://api.github.com/users/auraz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/auraz/subscriptions","organizations_url":"https://api.github.com/users/auraz/orgs","repos_url":"https://api.github.com/users/auraz/repos","events_url":"https://api.github.com/users/auraz/events{/privacy}","received_events_url":"https://api.github.com/users/auraz/received_events","type":"User","site_admin":false},"body":"what is tested in this PR","created_at":"2014-06-26T09:12:59Z","updated_at":"2014-06-26T09:12:59Z","html_url":"https://github.com/edx/edx-platform/pull/4206#discussion_r14231443","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/4206","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/14231443"},"html":{"href":"https://github.com/edx/edx-platform/pull/4206#discussion_r14231443"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/4206"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/4206","id":17597091,"html_url":"https://github.com/edx/edx-platform/pull/4206","diff_url":"https://github.com/edx/edx-platform/pull/4206.diff","patch_url":"https://github.com/edx/edx-platform/pull/4206.patch","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/4206","number":4206,"state":"open","title":"Add test that xml body was parsed successfully.","user":{"login":"olmar","id":3625483,"avatar_url":"https://avatars.githubusercontent.com/u/3625483?","gravatar_id":"543e5cc11f8b81fb803ccbfb7a5d39b4","url":"https://api.github.com/users/olmar","html_url":"https://github.com/olmar","followers_url":"https://api.github.com/users/olmar/followers","following_url":"https://api.github.com/users/olmar/following{/other_user}","gists_url":"https://api.github.com/users/olmar/gists{/gist_id}","starred_url":"https://api.github.com/users/olmar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olmar/subscriptions","organizations_url":"https://api.github.com/users/olmar/orgs","repos_url":"https://api.github.com/users/olmar/repos","events_url":"https://api.github.com/users/olmar/events{/privacy}","received_events_url":"https://api.github.com/users/olmar/received_events","type":"User","site_admin":false},"body":"Add tests for issue with xml namespaces in Tool Provider request XML.\r\n\r\n@auraz please review.","created_at":"2014-06-25T15:22:30Z","updated_at":"2014-06-26T09:12:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8d87783a3f9257bc6f1cf7fed662aea41387b629","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-platform/pulls/4206/commits","review_comments_url":"https://api.github.com/repos/edx/edx-platform/pulls/4206/comments","review_comment_url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/{number}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/4206/comments","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/c63ba473b8b68c1cac9df619478d7428bc55231e","head":{"label":"edx:oleg/lti-xmlns-test","ref":"oleg/lti-xmlns-test","sha":"c63ba473b8b68c1cac9df619478d7428bc55231e","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?","gravatar_id":"e1f6c6dc8772c47c0261cd5df2ed2814","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?","gravatar_id":"e1f6c6dc8772c47c0261cd5df2ed2814","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"Open edX, the edX platform that powers http://www.edx.org","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments/{number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","created_at":"2013-05-30T20:20:38Z","updated_at":"2014-06-26T00:38:55Z","pushed_at":"2014-06-26T08:55:26Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://code.edx.org/","size":1134727,"stargazers_count":1275,"watchers_count":1275,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":672,"mirror_url":null,"open_issues_count":124,"forks":672,"open_issues":124,"watchers":1275,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"04d27a83f97ac8f9e37ba6b230c1f28238ade5c2","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?","gravatar_id":"e1f6c6dc8772c47c0261cd5df2ed2814","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?","gravatar_id":"e1f6c6dc8772c47c0261cd5df2ed2814","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"Open edX, the edX platform that powers http://www.edx.org","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments/{number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","created_at":"2013-05-30T20:20:38Z","updated_at":"2014-06-26T00:38:55Z","pushed_at":"2014-06-26T08:55:26Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://code.edx.org/","size":1134727,"stargazers_count":1275,"watchers_count":1275,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":672,"mirror_url":null,"open_issues_count":124,"forks":672,"open_issues":124,"watchers":1275,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/4206"},"html":{"href":"https://github.com/edx/edx-platform/pull/4206"},"issue":{"href":"https://api.github.com/repos/edx/edx-platform/issues/4206"},"comments":{"href":"https://api.github.com/repos/edx/edx-platform/issues/4206/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/4206/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/4206/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-platform/statuses/c63ba473b8b68c1cac9df619478d7428bc55231e"}}}}