GitHub PullRequestReviewCommentEvent at 2014-11-23 23:45:32
Repository: Spirit
Actor: nitely
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/nitely/Spirit/pulls/comments/20769334","id":20769334,"diff_hunk":"@@ -133,10 +134,3 @@\n         },\n     }\n }\n-\n-try:\n-    # devs must create this file to override settings\n-    # local_settings_sample.py is provided\n-    from .local_settings import *\n-except ImportError:\n-    pass","path":"example/settings.py","position":55,"original_position":55,"commit_id":"b1fdb34dd580c22a1ddfb1fefc95011deff57c08","original_commit_id":"b1fdb34dd580c22a1ddfb1fefc95011deff57c08","user":{"login":"nitely","id":1697267,"avatar_url":"https://avatars.githubusercontent.com/u/1697267?v=3","gravatar_id":"","url":"https://api.github.com/users/nitely","html_url":"https://github.com/nitely","followers_url":"https://api.github.com/users/nitely/followers","following_url":"https://api.github.com/users/nitely/following{/other_user}","gists_url":"https://api.github.com/users/nitely/gists{/gist_id}","starred_url":"https://api.github.com/users/nitely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nitely/subscriptions","organizations_url":"https://api.github.com/users/nitely/orgs","repos_url":"https://api.github.com/users/nitely/repos","events_url":"https://api.github.com/users/nitely/events{/privacy}","received_events_url":"https://api.github.com/users/nitely/received_events","type":"User","site_admin":false},"body":"I think we should not remove this try...except block. Also, move the settings_sample_prod.py to the example dir, so people can rename it to local_settings.py and use it, this approach makes it easy to pull changes from the repo and not having to worry about settings being overwritten. That's what I do anyway.","created_at":"2014-11-23T23:45:32Z","updated_at":"2014-11-23T23:45:32Z","html_url":"https://github.com/nitely/Spirit/pull/31#discussion_r20769334","pull_request_url":"https://api.github.com/repos/nitely/Spirit/pulls/31","_links":{"self":{"href":"https://api.github.com/repos/nitely/Spirit/pulls/comments/20769334"},"html":{"href":"https://github.com/nitely/Spirit/pull/31#discussion_r20769334"},"pull_request":{"href":"https://api.github.com/repos/nitely/Spirit/pulls/31"}}},"pull_request":{"url":"https://api.github.com/repos/nitely/Spirit/pulls/31","id":24891551,"html_url":"https://github.com/nitely/Spirit/pull/31","diff_url":"https://github.com/nitely/Spirit/pull/31.diff","patch_url":"https://github.com/nitely/Spirit/pull/31.patch","issue_url":"https://api.github.com/repos/nitely/Spirit/issues/31","number":31,"state":"open","locked":false,"title":"Tests use their own settings","user":{"login":"benjaminabel","id":1004282,"avatar_url":"https://avatars.githubusercontent.com/u/1004282?v=3","gravatar_id":"","url":"https://api.github.com/users/benjaminabel","html_url":"https://github.com/benjaminabel","followers_url":"https://api.github.com/users/benjaminabel/followers","following_url":"https://api.github.com/users/benjaminabel/following{/other_user}","gists_url":"https://api.github.com/users/benjaminabel/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminabel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminabel/subscriptions","organizations_url":"https://api.github.com/users/benjaminabel/orgs","repos_url":"https://api.github.com/users/benjaminabel/repos","events_url":"https://api.github.com/users/benjaminabel/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminabel/received_events","type":"User","site_admin":false},"body":"This way example and tests are independents.\r\n\r\nI also used memory for the sqlite3 database and added two directories to\r\nthe `.gitignore` file: `.settings`(added automatically by by eclipse) and `whoosh_index`(I don't think it's necessary to distribute spirit?)","created_at":"2014-11-22T18:18:19Z","updated_at":"2014-11-23T23:45:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"95ad239d04b9db4ee3876ef5aad05403c73ce0fd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nitely/Spirit/pulls/31/commits","review_comments_url":"https://api.github.com/repos/nitely/Spirit/pulls/31/comments","review_comment_url":"https://api.github.com/repos/nitely/Spirit/pulls/comments/{number}","comments_url":"https://api.github.com/repos/nitely/Spirit/issues/31/comments","statuses_url":"https://api.github.com/repos/nitely/Spirit/statuses/b1fdb34dd580c22a1ddfb1fefc95011deff57c08","head":{"label":"benjaminabel:tests-reorganisation","ref":"tests-reorganisation","sha":"b1fdb34dd580c22a1ddfb1fefc95011deff57c08","user":{"login":"benjaminabel","id":1004282,"avatar_url":"https://avatars.githubusercontent.com/u/1004282?v=3","gravatar_id":"","url":"https://api.github.com/users/benjaminabel","html_url":"https://github.com/benjaminabel","followers_url":"https://api.github.com/users/benjaminabel/followers","following_url":"https://api.github.com/users/benjaminabel/following{/other_user}","gists_url":"https://api.github.com/users/benjaminabel/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminabel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminabel/subscriptions","organizations_url":"https://api.github.com/users/benjaminabel/orgs","repos_url":"https://api.github.com/users/benjaminabel/repos","events_url":"https://api.github.com/users/benjaminabel/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminabel/received_events","type":"User","site_admin":false},"repo":{"id":26121220,"name":"Spirit","full_name":"benjaminabel/Spirit","owner":{"login":"benjaminabel","id":1004282,"avatar_url":"https://avatars.githubusercontent.com/u/1004282?v=3","gravatar_id":"","url":"https://api.github.com/users/benjaminabel","html_url":"https://github.com/benjaminabel","followers_url":"https://api.github.com/users/benjaminabel/followers","following_url":"https://api.github.com/users/benjaminabel/following{/other_user}","gists_url":"https://api.github.com/users/benjaminabel/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminabel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminabel/subscriptions","organizations_url":"https://api.github.com/users/benjaminabel/orgs","repos_url":"https://api.github.com/users/benjaminabel/repos","events_url":"https://api.github.com/users/benjaminabel/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminabel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benjaminabel/Spirit","description":"Spirit is a modern Python based forum built using the Django framework","fork":true,"url":"https://api.github.com/repos/benjaminabel/Spirit","forks_url":"https://api.github.com/repos/benjaminabel/Spirit/forks","keys_url":"https://api.github.com/repos/benjaminabel/Spirit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benjaminabel/Spirit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benjaminabel/Spirit/teams","hooks_url":"https://api.github.com/repos/benjaminabel/Spirit/hooks","issue_events_url":"https://api.github.com/repos/benjaminabel/Spirit/issues/events{/number}","events_url":"https://api.github.com/repos/benjaminabel/Spirit/events","assignees_url":"https://api.github.com/repos/benjaminabel/Spirit/assignees{/user}","branches_url":"https://api.github.com/repos/benjaminabel/Spirit/branches{/branch}","tags_url":"https://api.github.com/repos/benjaminabel/Spirit/tags","blobs_url":"https://api.github.com/repos/benjaminabel/Spirit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benjaminabel/Spirit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benjaminabel/Spirit/git/refs{/sha}","trees_url":"https://api.github.com/repos/benjaminabel/Spirit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benjaminabel/Spirit/statuses/{sha}","languages_url":"https://api.github.com/repos/benjaminabel/Spirit/languages","stargazers_url":"https://api.github.com/repos/benjaminabel/Spirit/stargazers","contributors_url":"https://api.github.com/repos/benjaminabel/Spirit/contributors","subscribers_url":"https://api.github.com/repos/benjaminabel/Spirit/subscribers","subscription_url":"https://api.github.com/repos/benjaminabel/Spirit/subscription","commits_url":"https://api.github.com/repos/benjaminabel/Spirit/commits{/sha}","git_commits_url":"https://api.github.com/repos/benjaminabel/Spirit/git/commits{/sha}","comments_url":"https://api.github.com/repos/benjaminabel/Spirit/comments{/number}","issue_comment_url":"https://api.github.com/repos/benjaminabel/Spirit/issues/comments/{number}","contents_url":"https://api.github.com/repos/benjaminabel/Spirit/contents/{+path}","compare_url":"https://api.github.com/repos/benjaminabel/Spirit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benjaminabel/Spirit/merges","archive_url":"https://api.github.com/repos/benjaminabel/Spirit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benjaminabel/Spirit/downloads","issues_url":"https://api.github.com/repos/benjaminabel/Spirit/issues{/number}","pulls_url":"https://api.github.com/repos/benjaminabel/Spirit/pulls{/number}","milestones_url":"https://api.github.com/repos/benjaminabel/Spirit/milestones{/number}","notifications_url":"https://api.github.com/repos/benjaminabel/Spirit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benjaminabel/Spirit/labels{/name}","releases_url":"https://api.github.com/repos/benjaminabel/Spirit/releases{/id}","created_at":"2014-11-03T14:08:46Z","updated_at":"2014-11-18T12:58:35Z","pushed_at":"2014-11-23T19:42:04Z","git_url":"git://github.com/benjaminabel/Spirit.git","ssh_url":"git@github.com:benjaminabel/Spirit.git","clone_url":"https://github.com/benjaminabel/Spirit.git","svn_url":"https://github.com/benjaminabel/Spirit","homepage":"http://spirit-project.com/","size":2728,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nitely:future","ref":"future","sha":"2a1e593f01b9836a94b508c31751cc07dfd3f331","user":{"login":"nitely","id":1697267,"avatar_url":"https://avatars.githubusercontent.com/u/1697267?v=3","gravatar_id":"","url":"https://api.github.com/users/nitely","html_url":"https://github.com/nitely","followers_url":"https://api.github.com/users/nitely/followers","following_url":"https://api.github.com/users/nitely/following{/other_user}","gists_url":"https://api.github.com/users/nitely/gists{/gist_id}","starred_url":"https://api.github.com/users/nitely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nitely/subscriptions","organizations_url":"https://api.github.com/users/nitely/orgs","repos_url":"https://api.github.com/users/nitely/repos","events_url":"https://api.github.com/users/nitely/events{/privacy}","received_events_url":"https://api.github.com/users/nitely/received_events","type":"User","site_admin":false},"repo":{"id":19626318,"name":"Spirit","full_name":"nitely/Spirit","owner":{"login":"nitely","id":1697267,"avatar_url":"https://avatars.githubusercontent.com/u/1697267?v=3","gravatar_id":"","url":"https://api.github.com/users/nitely","html_url":"https://github.com/nitely","followers_url":"https://api.github.com/users/nitely/followers","following_url":"https://api.github.com/users/nitely/following{/other_user}","gists_url":"https://api.github.com/users/nitely/gists{/gist_id}","starred_url":"https://api.github.com/users/nitely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nitely/subscriptions","organizations_url":"https://api.github.com/users/nitely/orgs","repos_url":"https://api.github.com/users/nitely/repos","events_url":"https://api.github.com/users/nitely/events{/privacy}","received_events_url":"https://api.github.com/users/nitely/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nitely/Spirit","description":"Spirit is a modern Python based forum built using the Django framework","fork":false,"url":"https://api.github.com/repos/nitely/Spirit","forks_url":"https://api.github.com/repos/nitely/Spirit/forks","keys_url":"https://api.github.com/repos/nitely/Spirit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nitely/Spirit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nitely/Spirit/teams","hooks_url":"https://api.github.com/repos/nitely/Spirit/hooks","issue_events_url":"https://api.github.com/repos/nitely/Spirit/issues/events{/number}","events_url":"https://api.github.com/repos/nitely/Spirit/events","assignees_url":"https://api.github.com/repos/nitely/Spirit/assignees{/user}","branches_url":"https://api.github.com/repos/nitely/Spirit/branches{/branch}","tags_url":"https://api.github.com/repos/nitely/Spirit/tags","blobs_url":"https://api.github.com/repos/nitely/Spirit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nitely/Spirit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nitely/Spirit/git/refs{/sha}","trees_url":"https://api.github.com/repos/nitely/Spirit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nitely/Spirit/statuses/{sha}","languages_url":"https://api.github.com/repos/nitely/Spirit/languages","stargazers_url":"https://api.github.com/repos/nitely/Spirit/stargazers","contributors_url":"https://api.github.com/repos/nitely/Spirit/contributors","subscribers_url":"https://api.github.com/repos/nitely/Spirit/subscribers","subscription_url":"https://api.github.com/repos/nitely/Spirit/subscription","commits_url":"https://api.github.com/repos/nitely/Spirit/commits{/sha}","git_commits_url":"https://api.github.com/repos/nitely/Spirit/git/commits{/sha}","comments_url":"https://api.github.com/repos/nitely/Spirit/comments{/number}","issue_comment_url":"https://api.github.com/repos/nitely/Spirit/issues/comments/{number}","contents_url":"https://api.github.com/repos/nitely/Spirit/contents/{+path}","compare_url":"https://api.github.com/repos/nitely/Spirit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nitely/Spirit/merges","archive_url":"https://api.github.com/repos/nitely/Spirit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nitely/Spirit/downloads","issues_url":"https://api.github.com/repos/nitely/Spirit/issues{/number}","pulls_url":"https://api.github.com/repos/nitely/Spirit/pulls{/number}","milestones_url":"https://api.github.com/repos/nitely/Spirit/milestones{/number}","notifications_url":"https://api.github.com/repos/nitely/Spirit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nitely/Spirit/labels{/name}","releases_url":"https://api.github.com/repos/nitely/Spirit/releases{/id}","created_at":"2014-05-09T21:31:33Z","updated_at":"2014-11-18T00:19:04Z","pushed_at":"2014-11-20T22:43:55Z","git_url":"git://github.com/nitely/Spirit.git","ssh_url":"git@github.com:nitely/Spirit.git","clone_url":"https://github.com/nitely/Spirit.git","svn_url":"https://github.com/nitely/Spirit","homepage":"http://spirit-project.com/","size":3782,"stargazers_count":288,"watchers_count":288,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":57,"mirror_url":null,"open_issues_count":6,"forks":57,"open_issues":6,"watchers":288,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nitely/Spirit/pulls/31"},"html":{"href":"https://github.com/nitely/Spirit/pull/31"},"issue":{"href":"https://api.github.com/repos/nitely/Spirit/issues/31"},"comments":{"href":"https://api.github.com/repos/nitely/Spirit/issues/31/comments"},"review_comments":{"href":"https://api.github.com/repos/nitely/Spirit/pulls/31/comments"},"review_comment":{"href":"https://api.github.com/repos/nitely/Spirit/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/nitely/Spirit/pulls/31/commits"},"statuses":{"href":"https://api.github.com/repos/nitely/Spirit/statuses/b1fdb34dd580c22a1ddfb1fefc95011deff57c08"}}}}