GitHub PullRequestReviewCommentEvent at 2014-11-20 20:42:59
Repository: appium-adb
Actor: jlipps
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/appium/appium-adb/pulls/comments/20675849","id":20675849,"diff_hunk":"@@ -145,3 +146,39 @@ exports.getActivityRelativeName = function (pkgName, activityRelativeName) {\n \n   return relativeName;\n };\n+\n+var wrapForExec = function (s) {\n+  // not a string\n+  if (typeof s !== 'string') return s;\n+  // already wraped","path":"lib/helpers.js","position":18,"original_position":18,"commit_id":"54913841a406e6a538c0232a5810d60224442854","original_commit_id":"54913841a406e6a538c0232a5810d60224442854","user":{"login":"jlipps","id":605053,"avatar_url":"https://avatars.githubusercontent.com/u/605053?v=3","gravatar_id":"","url":"https://api.github.com/users/jlipps","html_url":"https://github.com/jlipps","followers_url":"https://api.github.com/users/jlipps/followers","following_url":"https://api.github.com/users/jlipps/following{/other_user}","gists_url":"https://api.github.com/users/jlipps/gists{/gist_id}","starred_url":"https://api.github.com/users/jlipps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlipps/subscriptions","organizations_url":"https://api.github.com/users/jlipps/orgs","repos_url":"https://api.github.com/users/jlipps/repos","events_url":"https://api.github.com/users/jlipps/events{/privacy}","received_events_url":"https://api.github.com/users/jlipps/received_events","type":"User","site_admin":false},"body":"wrapped","created_at":"2014-11-20T20:42:59Z","updated_at":"2014-11-20T20:42:59Z","html_url":"https://github.com/appium/appium-adb/pull/63#discussion_r20675849","pull_request_url":"https://api.github.com/repos/appium/appium-adb/pulls/63","_links":{"self":{"href":"https://api.github.com/repos/appium/appium-adb/pulls/comments/20675849"},"html":{"href":"https://github.com/appium/appium-adb/pull/63#discussion_r20675849"},"pull_request":{"href":"https://api.github.com/repos/appium/appium-adb/pulls/63"}}},"pull_request":{"url":"https://api.github.com/repos/appium/appium-adb/pulls/63","id":24759985,"html_url":"https://github.com/appium/appium-adb/pull/63","diff_url":"https://github.com/appium/appium-adb/pull/63.diff","patch_url":"https://github.com/appium/appium-adb/pull/63.patch","issue_url":"https://api.github.com/repos/appium/appium-adb/issues/63","number":63,"state":"open","locked":false,"title":"Exec refactoring","user":{"login":"sebv","id":418288,"avatar_url":"https://avatars.githubusercontent.com/u/418288?v=3","gravatar_id":"","url":"https://api.github.com/users/sebv","html_url":"https://github.com/sebv","followers_url":"https://api.github.com/users/sebv/followers","following_url":"https://api.github.com/users/sebv/following{/other_user}","gists_url":"https://api.github.com/users/sebv/gists{/gist_id}","starred_url":"https://api.github.com/users/sebv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebv/subscriptions","organizations_url":"https://api.github.com/users/sebv/orgs","repos_url":"https://api.github.com/users/sebv/repos","events_url":"https://api.github.com/users/sebv/events{/privacy}","received_events_url":"https://api.github.com/users/sebv/received_events","type":"User","site_admin":false},"body":"Remember to merge https://github.com/appium/appium/pull/4103 after this.","created_at":"2014-11-20T11:57:40Z","updated_at":"2014-11-20T20:42:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bdeeea296466efa5d5de2c4b68fe97c302886af8","assignee":{"login":"sebv","id":418288,"avatar_url":"https://avatars.githubusercontent.com/u/418288?v=3","gravatar_id":"","url":"https://api.github.com/users/sebv","html_url":"https://github.com/sebv","followers_url":"https://api.github.com/users/sebv/followers","following_url":"https://api.github.com/users/sebv/following{/other_user}","gists_url":"https://api.github.com/users/sebv/gists{/gist_id}","starred_url":"https://api.github.com/users/sebv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebv/subscriptions","organizations_url":"https://api.github.com/users/sebv/orgs","repos_url":"https://api.github.com/users/sebv/repos","events_url":"https://api.github.com/users/sebv/events{/privacy}","received_events_url":"https://api.github.com/users/sebv/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/appium/appium-adb/pulls/63/commits","review_comments_url":"https://api.github.com/repos/appium/appium-adb/pulls/63/comments","review_comment_url":"https://api.github.com/repos/appium/appium-adb/pulls/comments/{number}","comments_url":"https://api.github.com/repos/appium/appium-adb/issues/63/comments","statuses_url":"https://api.github.com/repos/appium/appium-adb/statuses/54913841a406e6a538c0232a5810d60224442854","head":{"label":"sebv:exec-refactoring","ref":"exec-refactoring","sha":"54913841a406e6a538c0232a5810d60224442854","user":{"login":"sebv","id":418288,"avatar_url":"https://avatars.githubusercontent.com/u/418288?v=3","gravatar_id":"","url":"https://api.github.com/users/sebv","html_url":"https://github.com/sebv","followers_url":"https://api.github.com/users/sebv/followers","following_url":"https://api.github.com/users/sebv/following{/other_user}","gists_url":"https://api.github.com/users/sebv/gists{/gist_id}","starred_url":"https://api.github.com/users/sebv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebv/subscriptions","organizations_url":"https://api.github.com/users/sebv/orgs","repos_url":"https://api.github.com/users/sebv/repos","events_url":"https://api.github.com/users/sebv/events{/privacy}","received_events_url":"https://api.github.com/users/sebv/received_events","type":"User","site_admin":false},"repo":{"id":21169398,"name":"appium-adb","full_name":"sebv/appium-adb","owner":{"login":"sebv","id":418288,"avatar_url":"https://avatars.githubusercontent.com/u/418288?v=3","gravatar_id":"","url":"https://api.github.com/users/sebv","html_url":"https://github.com/sebv","followers_url":"https://api.github.com/users/sebv/followers","following_url":"https://api.github.com/users/sebv/following{/other_user}","gists_url":"https://api.github.com/users/sebv/gists{/gist_id}","starred_url":"https://api.github.com/users/sebv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebv/subscriptions","organizations_url":"https://api.github.com/users/sebv/orgs","repos_url":"https://api.github.com/users/sebv/repos","events_url":"https://api.github.com/users/sebv/events{/privacy}","received_events_url":"https://api.github.com/users/sebv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sebv/appium-adb","description":"Wrapper around adb used by appium + helper libs","fork":true,"url":"https://api.github.com/repos/sebv/appium-adb","forks_url":"https://api.github.com/repos/sebv/appium-adb/forks","keys_url":"https://api.github.com/repos/sebv/appium-adb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sebv/appium-adb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sebv/appium-adb/teams","hooks_url":"https://api.github.com/repos/sebv/appium-adb/hooks","issue_events_url":"https://api.github.com/repos/sebv/appium-adb/issues/events{/number}","events_url":"https://api.github.com/repos/sebv/appium-adb/events","assignees_url":"https://api.github.com/repos/sebv/appium-adb/assignees{/user}","branches_url":"https://api.github.com/repos/sebv/appium-adb/branches{/branch}","tags_url":"https://api.github.com/repos/sebv/appium-adb/tags","blobs_url":"https://api.github.com/repos/sebv/appium-adb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sebv/appium-adb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sebv/appium-adb/git/refs{/sha}","trees_url":"https://api.github.com/repos/sebv/appium-adb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sebv/appium-adb/statuses/{sha}","languages_url":"https://api.github.com/repos/sebv/appium-adb/languages","stargazers_url":"https://api.github.com/repos/sebv/appium-adb/stargazers","contributors_url":"https://api.github.com/repos/sebv/appium-adb/contributors","subscribers_url":"https://api.github.com/repos/sebv/appium-adb/subscribers","subscription_url":"https://api.github.com/repos/sebv/appium-adb/subscription","commits_url":"https://api.github.com/repos/sebv/appium-adb/commits{/sha}","git_commits_url":"https://api.github.com/repos/sebv/appium-adb/git/commits{/sha}","comments_url":"https://api.github.com/repos/sebv/appium-adb/comments{/number}","issue_comment_url":"https://api.github.com/repos/sebv/appium-adb/issues/comments/{number}","contents_url":"https://api.github.com/repos/sebv/appium-adb/contents/{+path}","compare_url":"https://api.github.com/repos/sebv/appium-adb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sebv/appium-adb/merges","archive_url":"https://api.github.com/repos/sebv/appium-adb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sebv/appium-adb/downloads","issues_url":"https://api.github.com/repos/sebv/appium-adb/issues{/number}","pulls_url":"https://api.github.com/repos/sebv/appium-adb/pulls{/number}","milestones_url":"https://api.github.com/repos/sebv/appium-adb/milestones{/number}","notifications_url":"https://api.github.com/repos/sebv/appium-adb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sebv/appium-adb/labels{/name}","releases_url":"https://api.github.com/repos/sebv/appium-adb/releases{/id}","created_at":"2014-06-24T15:12:02Z","updated_at":"2014-06-24T16:19:06Z","pushed_at":"2014-11-20T15:23:48Z","git_url":"git://github.com/sebv/appium-adb.git","ssh_url":"git@github.com:sebv/appium-adb.git","clone_url":"https://github.com/sebv/appium-adb.git","svn_url":"https://github.com/sebv/appium-adb","homepage":null,"size":6410,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"appium:master","ref":"master","sha":"eaa1cf1cab0f0912eca4fca4b8bcc48537aed752","user":{"login":"appium","id":3221291,"avatar_url":"https://avatars.githubusercontent.com/u/3221291?v=3","gravatar_id":"","url":"https://api.github.com/users/appium","html_url":"https://github.com/appium","followers_url":"https://api.github.com/users/appium/followers","following_url":"https://api.github.com/users/appium/following{/other_user}","gists_url":"https://api.github.com/users/appium/gists{/gist_id}","starred_url":"https://api.github.com/users/appium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appium/subscriptions","organizations_url":"https://api.github.com/users/appium/orgs","repos_url":"https://api.github.com/users/appium/repos","events_url":"https://api.github.com/users/appium/events{/privacy}","received_events_url":"https://api.github.com/users/appium/received_events","type":"Organization","site_admin":false},"repo":{"id":17339088,"name":"appium-adb","full_name":"appium/appium-adb","owner":{"login":"appium","id":3221291,"avatar_url":"https://avatars.githubusercontent.com/u/3221291?v=3","gravatar_id":"","url":"https://api.github.com/users/appium","html_url":"https://github.com/appium","followers_url":"https://api.github.com/users/appium/followers","following_url":"https://api.github.com/users/appium/following{/other_user}","gists_url":"https://api.github.com/users/appium/gists{/gist_id}","starred_url":"https://api.github.com/users/appium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appium/subscriptions","organizations_url":"https://api.github.com/users/appium/orgs","repos_url":"https://api.github.com/users/appium/repos","events_url":"https://api.github.com/users/appium/events{/privacy}","received_events_url":"https://api.github.com/users/appium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appium/appium-adb","description":"Wrapper around adb used by appium + helper libs","fork":false,"url":"https://api.github.com/repos/appium/appium-adb","forks_url":"https://api.github.com/repos/appium/appium-adb/forks","keys_url":"https://api.github.com/repos/appium/appium-adb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appium/appium-adb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appium/appium-adb/teams","hooks_url":"https://api.github.com/repos/appium/appium-adb/hooks","issue_events_url":"https://api.github.com/repos/appium/appium-adb/issues/events{/number}","events_url":"https://api.github.com/repos/appium/appium-adb/events","assignees_url":"https://api.github.com/repos/appium/appium-adb/assignees{/user}","branches_url":"https://api.github.com/repos/appium/appium-adb/branches{/branch}","tags_url":"https://api.github.com/repos/appium/appium-adb/tags","blobs_url":"https://api.github.com/repos/appium/appium-adb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appium/appium-adb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appium/appium-adb/git/refs{/sha}","trees_url":"https://api.github.com/repos/appium/appium-adb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appium/appium-adb/statuses/{sha}","languages_url":"https://api.github.com/repos/appium/appium-adb/languages","stargazers_url":"https://api.github.com/repos/appium/appium-adb/stargazers","contributors_url":"https://api.github.com/repos/appium/appium-adb/contributors","subscribers_url":"https://api.github.com/repos/appium/appium-adb/subscribers","subscription_url":"https://api.github.com/repos/appium/appium-adb/subscription","commits_url":"https://api.github.com/repos/appium/appium-adb/commits{/sha}","git_commits_url":"https://api.github.com/repos/appium/appium-adb/git/commits{/sha}","comments_url":"https://api.github.com/repos/appium/appium-adb/comments{/number}","issue_comment_url":"https://api.github.com/repos/appium/appium-adb/issues/comments/{number}","contents_url":"https://api.github.com/repos/appium/appium-adb/contents/{+path}","compare_url":"https://api.github.com/repos/appium/appium-adb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appium/appium-adb/merges","archive_url":"https://api.github.com/repos/appium/appium-adb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appium/appium-adb/downloads","issues_url":"https://api.github.com/repos/appium/appium-adb/issues{/number}","pulls_url":"https://api.github.com/repos/appium/appium-adb/pulls{/number}","milestones_url":"https://api.github.com/repos/appium/appium-adb/milestones{/number}","notifications_url":"https://api.github.com/repos/appium/appium-adb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appium/appium-adb/labels{/name}","releases_url":"https://api.github.com/repos/appium/appium-adb/releases{/id}","created_at":"2014-03-02T14:20:10Z","updated_at":"2014-11-18T18:09:31Z","pushed_at":"2014-11-18T18:09:39Z","git_url":"git://github.com/appium/appium-adb.git","ssh_url":"git@github.com:appium/appium-adb.git","clone_url":"https://github.com/appium/appium-adb.git","svn_url":"https://github.com/appium/appium-adb","homepage":null,"size":14273,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":13,"forks":20,"open_issues":13,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/appium/appium-adb/pulls/63"},"html":{"href":"https://github.com/appium/appium-adb/pull/63"},"issue":{"href":"https://api.github.com/repos/appium/appium-adb/issues/63"},"comments":{"href":"https://api.github.com/repos/appium/appium-adb/issues/63/comments"},"review_comments":{"href":"https://api.github.com/repos/appium/appium-adb/pulls/63/comments"},"review_comment":{"href":"https://api.github.com/repos/appium/appium-adb/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/appium/appium-adb/pulls/63/commits"},"statuses":{"href":"https://api.github.com/repos/appium/appium-adb/statuses/54913841a406e6a538c0232a5810d60224442854"}}}}