GitHub PullRequestReviewCommentEvent at 2014-10-13 20:49:44
Repository: zamboni
Actor: cvan
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/zamboni/pulls/comments/18793998","id":18793998,"diff_hunk":"@@ -1012,6 +1014,45 @@ def test_create_with_multiple_images(self, download_mock, crush_mock):\n         eq_(crush_mock.call_args_list[1][0][0], obj.image_path('_landing'))\n \n \n+class TestFeedShelfViewSetMine(FeedTestMixin, RestOAuth):\n+    fixtures = (FeedTestMixin.fixtures + RestOAuth.fixtures +\n+                fixture('user_999'))\n+\n+    def setUp(self):\n+        super(TestFeedShelfViewSetMine, self).setUp()\n+        self.user2 = UserProfile.objects.get(id=999)\n+        self.url = reverse('api-v2:feedshelves-mine')\n+        self.feed_shelf_factory(\n+            carrier=mkt.carriers.TELEFONICA.id, region=mkt.regions.BR.id)\n+        self.feed_shelf_factory(\n+            carrier=mkt.carriers.AMERICA_MOVIL.id, region=mkt.regions.FR.id)\n+\n+    def list(self, client):\n+        res = client.get(self.url)\n+        data = json.loads(res.content)\n+        eq_(res.status_code, 200)\n+        return res, data\n+\n+    def test_anon(self):\n+        res, data = self.list(self.anon)","path":"mkt/feed/tests/test_views.py","position":33,"original_position":33,"commit_id":"85d12701188253b607a35ce1f4951490acc76415","original_commit_id":"7a11932ea48457f4fcfc041dc52b9b2cf2899234","user":{"login":"cvan","id":203725,"avatar_url":"https://avatars.githubusercontent.com/u/203725?v=2","gravatar_id":"","url":"https://api.github.com/users/cvan","html_url":"https://github.com/cvan","followers_url":"https://api.github.com/users/cvan/followers","following_url":"https://api.github.com/users/cvan/following{/other_user}","gists_url":"https://api.github.com/users/cvan/gists{/gist_id}","starred_url":"https://api.github.com/users/cvan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cvan/subscriptions","organizations_url":"https://api.github.com/users/cvan/orgs","repos_url":"https://api.github.com/users/cvan/repos","events_url":"https://api.github.com/users/cvan/events{/privacy}","received_events_url":"https://api.github.com/users/cvan/received_events","type":"User","site_admin":false},"body":"yeah, that makes sense to me. I would add a comment here though.","created_at":"2014-10-13T20:49:44Z","updated_at":"2014-10-13T20:49:44Z","html_url":"https://github.com/mozilla/zamboni/pull/2641#discussion_r18793998","pull_request_url":"https://api.github.com/repos/mozilla/zamboni/pulls/2641","_links":{"self":{"href":"https://api.github.com/repos/mozilla/zamboni/pulls/comments/18793998"},"html":{"href":"https://github.com/mozilla/zamboni/pull/2641#discussion_r18793998"},"pull_request":{"href":"https://api.github.com/repos/mozilla/zamboni/pulls/2641"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/zamboni/pulls/2641","id":22447019,"html_url":"https://github.com/mozilla/zamboni/pull/2641","diff_url":"https://github.com/mozilla/zamboni/pull/2641.diff","patch_url":"https://github.com/mozilla/zamboni/pull/2641.patch","issue_url":"https://api.github.com/repos/mozilla/zamboni/issues/2641","number":2641,"state":"open","locked":false,"title":"Adds API endpoint listing all operator shelves upon which the current user has permission to operate (bug 1074368).","user":{"login":"chuckharmston","id":23885,"avatar_url":"https://avatars.githubusercontent.com/u/23885?v=2","gravatar_id":"","url":"https://api.github.com/users/chuckharmston","html_url":"https://github.com/chuckharmston","followers_url":"https://api.github.com/users/chuckharmston/followers","following_url":"https://api.github.com/users/chuckharmston/following{/other_user}","gists_url":"https://api.github.com/users/chuckharmston/gists{/gist_id}","starred_url":"https://api.github.com/users/chuckharmston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chuckharmston/subscriptions","organizations_url":"https://api.github.com/users/chuckharmston/orgs","repos_url":"https://api.github.com/users/chuckharmston/repos","events_url":"https://api.github.com/users/chuckharmston/events{/privacy}","received_events_url":"https://api.github.com/users/chuckharmston/received_events","type":"User","site_admin":false},"body":"![Mine.](https://cloud.githubusercontent.com/assets/23885/4565352/25abe82e-4f1f-11e4-866f-e56ec9b14b8a.gif)\r\n\r\nr? @ngokevin @robhudson @diox ","created_at":"2014-10-08T19:14:45Z","updated_at":"2014-10-13T20:49:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a48618f67b5053a77546086b77cbdad6137cdced","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/zamboni/pulls/2641/commits","review_comments_url":"https://api.github.com/repos/mozilla/zamboni/pulls/2641/comments","review_comment_url":"https://api.github.com/repos/mozilla/zamboni/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla/zamboni/issues/2641/comments","statuses_url":"https://api.github.com/repos/mozilla/zamboni/statuses/85d12701188253b607a35ce1f4951490acc76415","head":{"label":"chuckharmston:1074368","ref":"1074368","sha":"85d12701188253b607a35ce1f4951490acc76415","user":{"login":"chuckharmston","id":23885,"avatar_url":"https://avatars.githubusercontent.com/u/23885?v=2","gravatar_id":"","url":"https://api.github.com/users/chuckharmston","html_url":"https://github.com/chuckharmston","followers_url":"https://api.github.com/users/chuckharmston/followers","following_url":"https://api.github.com/users/chuckharmston/following{/other_user}","gists_url":"https://api.github.com/users/chuckharmston/gists{/gist_id}","starred_url":"https://api.github.com/users/chuckharmston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chuckharmston/subscriptions","organizations_url":"https://api.github.com/users/chuckharmston/orgs","repos_url":"https://api.github.com/users/chuckharmston/repos","events_url":"https://api.github.com/users/chuckharmston/events{/privacy}","received_events_url":"https://api.github.com/users/chuckharmston/received_events","type":"User","site_admin":false},"repo":{"id":17600281,"name":"zamboni","full_name":"chuckharmston/zamboni","owner":{"login":"chuckharmston","id":23885,"avatar_url":"https://avatars.githubusercontent.com/u/23885?v=2","gravatar_id":"","url":"https://api.github.com/users/chuckharmston","html_url":"https://github.com/chuckharmston","followers_url":"https://api.github.com/users/chuckharmston/followers","following_url":"https://api.github.com/users/chuckharmston/following{/other_user}","gists_url":"https://api.github.com/users/chuckharmston/gists{/gist_id}","starred_url":"https://api.github.com/users/chuckharmston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chuckharmston/subscriptions","organizations_url":"https://api.github.com/users/chuckharmston/orgs","repos_url":"https://api.github.com/users/chuckharmston/repos","events_url":"https://api.github.com/users/chuckharmston/events{/privacy}","received_events_url":"https://api.github.com/users/chuckharmston/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chuckharmston/zamboni","description":"The Firefox Marketplace and addons.mozilla.org","fork":true,"url":"https://api.github.com/repos/chuckharmston/zamboni","forks_url":"https://api.github.com/repos/chuckharmston/zamboni/forks","keys_url":"https://api.github.com/repos/chuckharmston/zamboni/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chuckharmston/zamboni/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chuckharmston/zamboni/teams","hooks_url":"https://api.github.com/repos/chuckharmston/zamboni/hooks","issue_events_url":"https://api.github.com/repos/chuckharmston/zamboni/issues/events{/number}","events_url":"https://api.github.com/repos/chuckharmston/zamboni/events","assignees_url":"https://api.github.com/repos/chuckharmston/zamboni/assignees{/user}","branches_url":"https://api.github.com/repos/chuckharmston/zamboni/branches{/branch}","tags_url":"https://api.github.com/repos/chuckharmston/zamboni/tags","blobs_url":"https://api.github.com/repos/chuckharmston/zamboni/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chuckharmston/zamboni/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chuckharmston/zamboni/git/refs{/sha}","trees_url":"https://api.github.com/repos/chuckharmston/zamboni/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chuckharmston/zamboni/statuses/{sha}","languages_url":"https://api.github.com/repos/chuckharmston/zamboni/languages","stargazers_url":"https://api.github.com/repos/chuckharmston/zamboni/stargazers","contributors_url":"https://api.github.com/repos/chuckharmston/zamboni/contributors","subscribers_url":"https://api.github.com/repos/chuckharmston/zamboni/subscribers","subscription_url":"https://api.github.com/repos/chuckharmston/zamboni/subscription","commits_url":"https://api.github.com/repos/chuckharmston/zamboni/commits{/sha}","git_commits_url":"https://api.github.com/repos/chuckharmston/zamboni/git/commits{/sha}","comments_url":"https://api.github.com/repos/chuckharmston/zamboni/comments{/number}","issue_comment_url":"https://api.github.com/repos/chuckharmston/zamboni/issues/comments/{number}","contents_url":"https://api.github.com/repos/chuckharmston/zamboni/contents/{+path}","compare_url":"https://api.github.com/repos/chuckharmston/zamboni/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chuckharmston/zamboni/merges","archive_url":"https://api.github.com/repos/chuckharmston/zamboni/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chuckharmston/zamboni/downloads","issues_url":"https://api.github.com/repos/chuckharmston/zamboni/issues{/number}","pulls_url":"https://api.github.com/repos/chuckharmston/zamboni/pulls{/number}","milestones_url":"https://api.github.com/repos/chuckharmston/zamboni/milestones{/number}","notifications_url":"https://api.github.com/repos/chuckharmston/zamboni/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chuckharmston/zamboni/labels{/name}","releases_url":"https://api.github.com/repos/chuckharmston/zamboni/releases{/id}","created_at":"2014-03-10T16:49:52Z","updated_at":"2014-06-23T15:13:55Z","pushed_at":"2014-10-13T17:16:34Z","git_url":"git://github.com/chuckharmston/zamboni.git","ssh_url":"git@github.com:chuckharmston/zamboni.git","clone_url":"https://github.com/chuckharmston/zamboni.git","svn_url":"https://github.com/chuckharmston/zamboni","homepage":"http://zamboni.readthedocs.org","size":298073,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"9cac9f9d3bbfcc31978b1aeab1b34e35baf1052b","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=2","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":347655,"name":"zamboni","full_name":"mozilla/zamboni","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=2","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/zamboni","description":"The backend of the Firefox Marketplace","fork":false,"url":"https://api.github.com/repos/mozilla/zamboni","forks_url":"https://api.github.com/repos/mozilla/zamboni/forks","keys_url":"https://api.github.com/repos/mozilla/zamboni/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/zamboni/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/zamboni/teams","hooks_url":"https://api.github.com/repos/mozilla/zamboni/hooks","issue_events_url":"https://api.github.com/repos/mozilla/zamboni/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/zamboni/events","assignees_url":"https://api.github.com/repos/mozilla/zamboni/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/zamboni/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/zamboni/tags","blobs_url":"https://api.github.com/repos/mozilla/zamboni/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/zamboni/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/zamboni/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/zamboni/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/zamboni/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/zamboni/languages","stargazers_url":"https://api.github.com/repos/mozilla/zamboni/stargazers","contributors_url":"https://api.github.com/repos/mozilla/zamboni/contributors","subscribers_url":"https://api.github.com/repos/mozilla/zamboni/subscribers","subscription_url":"https://api.github.com/repos/mozilla/zamboni/subscription","commits_url":"https://api.github.com/repos/mozilla/zamboni/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/zamboni/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/zamboni/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/zamboni/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla/zamboni/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/zamboni/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/zamboni/merges","archive_url":"https://api.github.com/repos/mozilla/zamboni/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/zamboni/downloads","issues_url":"https://api.github.com/repos/mozilla/zamboni/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/zamboni/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/zamboni/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/zamboni/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/zamboni/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/zamboni/releases{/id}","created_at":"2009-10-23T19:35:34Z","updated_at":"2014-10-02T08:21:48Z","pushed_at":"2014-10-13T15:59:25Z","git_url":"git://github.com/mozilla/zamboni.git","ssh_url":"git@github.com:mozilla/zamboni.git","clone_url":"https://github.com/mozilla/zamboni.git","svn_url":"https://github.com/mozilla/zamboni","homepage":"http://zamboni.readthedocs.org","size":382063,"stargazers_count":434,"watchers_count":434,"language":"Python","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":235,"mirror_url":null,"open_issues_count":14,"forks":235,"open_issues":14,"watchers":434,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/zamboni/pulls/2641"},"html":{"href":"https://github.com/mozilla/zamboni/pull/2641"},"issue":{"href":"https://api.github.com/repos/mozilla/zamboni/issues/2641"},"comments":{"href":"https://api.github.com/repos/mozilla/zamboni/issues/2641/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/zamboni/pulls/2641/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/zamboni/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla/zamboni/pulls/2641/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/zamboni/statuses/85d12701188253b607a35ce1f4951490acc76415"}}}}