GitHub PullRequestReviewCommentEvent at 2014-05-28 18:06:52
Repository: crichton-representors
Actor: fosdev
Payload: {"comment":{"url":"https://api.github.com/repos/mdsol/crichton-representors/pulls/comments/13146085","id":13146085,"diff_hunk":"@@ -0,0 +1,45 @@\n+require 'representors/serializers/hal'\n+require 'representors/serializers/hale'\n+\n+module Representors\n+  module Serialization\n+\n+    TOP_LEVEL_MEDIA = %w(application text)\n+\n+    def known_serializers\n+      @known_serializers ||= begin\n+        serializers = Serialization.constants.select {|c| Serialization.const_get(c).is_a? Class}","path":"lib/representors/serialization.rb","position":11,"original_position":11,"commit_id":"abc266c078ff57d65c99c4d857ae66b3318c01d0","original_commit_id":"abc266c078ff57d65c99c4d857ae66b3318c01d0","user":{"login":"fosdev","id":1307116,"avatar_url":"https://avatars.githubusercontent.com/u/1307116?","gravatar_id":"a971447916d8e6d0e234cb0280a452e7","url":"https://api.github.com/users/fosdev","html_url":"https://github.com/fosdev","followers_url":"https://api.github.com/users/fosdev/followers","following_url":"https://api.github.com/users/fosdev/following{/other_user}","gists_url":"https://api.github.com/users/fosdev/gists{/gist_id}","starred_url":"https://api.github.com/users/fosdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fosdev/subscriptions","organizations_url":"https://api.github.com/users/fosdev/orgs","repos_url":"https://api.github.com/users/fosdev/repos","events_url":"https://api.github.com/users/fosdev/events{/privacy}","received_events_url":"https://api.github.com/users/fosdev/received_events","type":"User","site_admin":false},"body":"seems some SRP could be applied here to break this into some more abstract methods.","created_at":"2014-05-28T18:06:52Z","updated_at":"2014-05-28T18:06:52Z","html_url":"https://github.com/mdsol/crichton-representors/pull/5#discussion_r13146085","pull_request_url":"https://api.github.com/repos/mdsol/crichton-representors/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/mdsol/crichton-representors/pulls/comments/13146085"},"html":{"href":"https://github.com/mdsol/crichton-representors/pull/5#discussion_r13146085"},"pull_request":{"href":"https://api.github.com/repos/mdsol/crichton-representors/pulls/5"}}}}