GitHub PullRequestReviewCommentEvent at 2014-09-18 04:52:12
Repository: HttpAbstractions
Actor: Eilon
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/HttpAbstractions/pulls/comments/17709054","id":17709054,"diff_hunk":"@@ -90,5 +91,21 @@ internal static string[] GetUnmodifiedValues(IDictionary<string, string[]> store\n             string[] values;\n             return store.TryGetValue(key, out values) ? values : null;\n         }\n+\n+        private static readonly char[] AmpersandAndSemicolon = new[] { '&', ';' };","path":"src/Microsoft.AspNet.WebUtilities/ParsingHelpers.cs","position":13,"original_position":13,"commit_id":"086ea4f2036d73bc29afa6376d1d9e792d87af16","original_commit_id":"086ea4f2036d73bc29afa6376d1d9e792d87af16","user":{"login":"Eilon","id":202643,"avatar_url":"https://avatars.githubusercontent.com/u/202643?v=2","gravatar_id":"7455ceb519e4df79962adeb4e0bb7f60","url":"https://api.github.com/users/Eilon","html_url":"https://github.com/Eilon","followers_url":"https://api.github.com/users/Eilon/followers","following_url":"https://api.github.com/users/Eilon/following{/other_user}","gists_url":"https://api.github.com/users/Eilon/gists{/gist_id}","starred_url":"https://api.github.com/users/Eilon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eilon/subscriptions","organizations_url":"https://api.github.com/users/Eilon/orgs","repos_url":"https://api.github.com/users/Eilon/repos","events_url":"https://api.github.com/users/Eilon/events{/privacy}","received_events_url":"https://api.github.com/users/Eilon/received_events","type":"User","site_admin":false},"body":"Why does this parse on semicolons? Is that to support matrix parameters? What if I have random semicolons in my query string?","created_at":"2014-09-18T04:52:12Z","updated_at":"2014-09-18T04:52:12Z","html_url":"https://github.com/aspnet/HttpAbstractions/pull/128#discussion_r17709054","pull_request_url":"https://api.github.com/repos/aspnet/HttpAbstractions/pulls/128","_links":{"self":{"href":"https://api.github.com/repos/aspnet/HttpAbstractions/pulls/comments/17709054"},"html":{"href":"https://github.com/aspnet/HttpAbstractions/pull/128#discussion_r17709054"},"pull_request":{"href":"https://api.github.com/repos/aspnet/HttpAbstractions/pulls/128"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/HttpAbstractions/pulls/128","id":21315236,"html_url":"https://github.com/aspnet/HttpAbstractions/pull/128","diff_url":"https://github.com/aspnet/HttpAbstractions/pull/128.diff","patch_url":"https://github.com/aspnet/HttpAbstractions/pull/128.patch","issue_url":"https://api.github.com/repos/aspnet/HttpAbstractions/issues/128","number":128,"state":"open","locked":false,"title":"Make the query parsing API public.","user":{"login":"Tratcher","id":1821173,"avatar_url":"https://avatars.githubusercontent.com/u/1821173?v=2","gravatar_id":"2482ce29c6c8d55f4dfcdd66cde2a44e","url":"https://api.github.com/users/Tratcher","html_url":"https://github.com/Tratcher","followers_url":"https://api.github.com/users/Tratcher/followers","following_url":"https://api.github.com/users/Tratcher/following{/other_user}","gists_url":"https://api.github.com/users/Tratcher/gists{/gist_id}","starred_url":"https://api.github.com/users/Tratcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tratcher/subscriptions","organizations_url":"https://api.github.com/users/Tratcher/orgs","repos_url":"https://api.github.com/users/Tratcher/repos","events_url":"https://api.github.com/users/Tratcher/events{/privacy}","received_events_url":"https://api.github.com/users/Tratcher/received_events","type":"User","site_admin":false},"body":"#121","created_at":"2014-09-16T17:43:18Z","updated_at":"2014-09-18T04:52:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3d5aec760e4be0ab09c256122075138f66df6e2a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/HttpAbstractions/pulls/128/commits","review_comments_url":"https://api.github.com/repos/aspnet/HttpAbstractions/pulls/128/comments","review_comment_url":"https://api.github.com/repos/aspnet/HttpAbstractions/pulls/comments/{number}","comments_url":"https://api.github.com/repos/aspnet/HttpAbstractions/issues/128/comments","statuses_url":"https://api.github.com/repos/aspnet/HttpAbstractions/statuses/086ea4f2036d73bc29afa6376d1d9e792d87af16","head":{"label":"Tratcher:query","ref":"query","sha":"086ea4f2036d73bc29afa6376d1d9e792d87af16","user":{"login":"Tratcher","id":1821173,"avatar_url":"https://avatars.githubusercontent.com/u/1821173?v=2","gravatar_id":"2482ce29c6c8d55f4dfcdd66cde2a44e","url":"https://api.github.com/users/Tratcher","html_url":"https://github.com/Tratcher","followers_url":"https://api.github.com/users/Tratcher/followers","following_url":"https://api.github.com/users/Tratcher/following{/other_user}","gists_url":"https://api.github.com/users/Tratcher/gists{/gist_id}","starred_url":"https://api.github.com/users/Tratcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tratcher/subscriptions","organizations_url":"https://api.github.com/users/Tratcher/orgs","repos_url":"https://api.github.com/users/Tratcher/repos","events_url":"https://api.github.com/users/Tratcher/events{/privacy}","received_events_url":"https://api.github.com/users/Tratcher/received_events","type":"User","site_admin":false},"repo":{"id":20783177,"name":"HttpAbstractions","full_name":"Tratcher/HttpAbstractions","owner":{"login":"Tratcher","id":1821173,"avatar_url":"https://avatars.githubusercontent.com/u/1821173?v=2","gravatar_id":"2482ce29c6c8d55f4dfcdd66cde2a44e","url":"https://api.github.com/users/Tratcher","html_url":"https://github.com/Tratcher","followers_url":"https://api.github.com/users/Tratcher/followers","following_url":"https://api.github.com/users/Tratcher/following{/other_user}","gists_url":"https://api.github.com/users/Tratcher/gists{/gist_id}","starred_url":"https://api.github.com/users/Tratcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tratcher/subscriptions","organizations_url":"https://api.github.com/users/Tratcher/orgs","repos_url":"https://api.github.com/users/Tratcher/repos","events_url":"https://api.github.com/users/Tratcher/events{/privacy}","received_events_url":"https://api.github.com/users/Tratcher/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Tratcher/HttpAbstractions","description":"Abstractions for ASP.NET","fork":true,"url":"https://api.github.com/repos/Tratcher/HttpAbstractions","forks_url":"https://api.github.com/repos/Tratcher/HttpAbstractions/forks","keys_url":"https://api.github.com/repos/Tratcher/HttpAbstractions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Tratcher/HttpAbstractions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Tratcher/HttpAbstractions/teams","hooks_url":"https://api.github.com/repos/Tratcher/HttpAbstractions/hooks","issue_events_url":"https://api.github.com/repos/Tratcher/HttpAbstractions/issues/events{/number}","events_url":"https://api.github.com/repos/Tratcher/HttpAbstractions/events","assignees_url":"https://api.github.com/repos/Tratcher/HttpAbstractions/assignees{/user}","branches_url":"https://api.github.com/repos/Tratcher/HttpAbstractions/branches{/branch}","tags_url":"https://api.github.com/repos/Tratcher/HttpAbstractions/tags","blobs_url":"https://api.github.com/repos/Tratcher/HttpAbstractions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Tratcher/HttpAbstractions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Tratcher/HttpAbstractions/git/refs{/sha}","trees_url":"https://api.github.com/repos/Tratcher/HttpAbstractions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Tratcher/HttpAbstractions/statuses/{sha}","languages_url":"https://api.github.com/repos/Tratcher/HttpAbstractions/languages","stargazers_url":"https://api.github.com/repos/Tratcher/HttpAbstractions/stargazers","contributors_url":"https://api.github.com/repos/Tratcher/HttpAbstractions/contributors","subscribers_url":"https://api.github.com/repos/Tratcher/HttpAbstractions/subscribers","subscription_url":"https://api.github.com/repos/Tratcher/HttpAbstractions/subscription","commits_url":"https://api.github.com/repos/Tratcher/HttpAbstractions/commits{/sha}","git_commits_url":"https://api.github.com/repos/Tratcher/HttpAbstractions/git/commits{/sha}","comments_url":"https://api.github.com/repos/Tratcher/HttpAbstractions/comments{/number}","issue_comment_url":"https://api.github.com/repos/Tratcher/HttpAbstractions/issues/comments/{number}","contents_url":"https://api.github.com/repos/Tratcher/HttpAbstractions/contents/{+path}","compare_url":"https://api.github.com/repos/Tratcher/HttpAbstractions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Tratcher/HttpAbstractions/merges","archive_url":"https://api.github.com/repos/Tratcher/HttpAbstractions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Tratcher/HttpAbstractions/downloads","issues_url":"https://api.github.com/repos/Tratcher/HttpAbstractions/issues{/number}","pulls_url":"https://api.github.com/repos/Tratcher/HttpAbstractions/pulls{/number}","milestones_url":"https://api.github.com/repos/Tratcher/HttpAbstractions/milestones{/number}","notifications_url":"https://api.github.com/repos/Tratcher/HttpAbstractions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Tratcher/HttpAbstractions/labels{/name}","releases_url":"https://api.github.com/repos/Tratcher/HttpAbstractions/releases{/id}","created_at":"2014-06-12T21:16:13Z","updated_at":"2014-06-27T22:23:25Z","pushed_at":"2014-09-16T17:42:48Z","git_url":"git://github.com/Tratcher/HttpAbstractions.git","ssh_url":"git@github.com:Tratcher/HttpAbstractions.git","clone_url":"https://github.com/Tratcher/HttpAbstractions.git","svn_url":"https://github.com/Tratcher/HttpAbstractions","homepage":null,"size":1119,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"3811f47b23f05fd85ef4693d13381e285e79d647","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=2","gravatar_id":null,"url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":15320915,"name":"HttpAbstractions","full_name":"aspnet/HttpAbstractions","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=2","gravatar_id":null,"url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/HttpAbstractions","description":"Abstractions for ASP.NET","fork":false,"url":"https://api.github.com/repos/aspnet/HttpAbstractions","forks_url":"https://api.github.com/repos/aspnet/HttpAbstractions/forks","keys_url":"https://api.github.com/repos/aspnet/HttpAbstractions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/HttpAbstractions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/HttpAbstractions/teams","hooks_url":"https://api.github.com/repos/aspnet/HttpAbstractions/hooks","issue_events_url":"https://api.github.com/repos/aspnet/HttpAbstractions/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/HttpAbstractions/events","assignees_url":"https://api.github.com/repos/aspnet/HttpAbstractions/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/HttpAbstractions/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/HttpAbstractions/tags","blobs_url":"https://api.github.com/repos/aspnet/HttpAbstractions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/HttpAbstractions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/HttpAbstractions/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/HttpAbstractions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/HttpAbstractions/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/HttpAbstractions/languages","stargazers_url":"https://api.github.com/repos/aspnet/HttpAbstractions/stargazers","contributors_url":"https://api.github.com/repos/aspnet/HttpAbstractions/contributors","subscribers_url":"https://api.github.com/repos/aspnet/HttpAbstractions/subscribers","subscription_url":"https://api.github.com/repos/aspnet/HttpAbstractions/subscription","commits_url":"https://api.github.com/repos/aspnet/HttpAbstractions/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/HttpAbstractions/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/HttpAbstractions/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/HttpAbstractions/issues/comments/{number}","contents_url":"https://api.github.com/repos/aspnet/HttpAbstractions/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/HttpAbstractions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/HttpAbstractions/merges","archive_url":"https://api.github.com/repos/aspnet/HttpAbstractions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/HttpAbstractions/downloads","issues_url":"https://api.github.com/repos/aspnet/HttpAbstractions/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/HttpAbstractions/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/HttpAbstractions/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/HttpAbstractions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/HttpAbstractions/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/HttpAbstractions/releases{/id}","created_at":"2013-12-19T19:38:45Z","updated_at":"2014-09-16T20:11:34Z","pushed_at":"2014-09-17T16:57:48Z","git_url":"git://github.com/aspnet/HttpAbstractions.git","ssh_url":"git@github.com:aspnet/HttpAbstractions.git","clone_url":"https://github.com/aspnet/HttpAbstractions.git","svn_url":"https://github.com/aspnet/HttpAbstractions","homepage":null,"size":3047,"stargazers_count":31,"watchers_count":31,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":30,"forks":18,"open_issues":30,"watchers":31,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/HttpAbstractions/pulls/128"},"html":{"href":"https://github.com/aspnet/HttpAbstractions/pull/128"},"issue":{"href":"https://api.github.com/repos/aspnet/HttpAbstractions/issues/128"},"comments":{"href":"https://api.github.com/repos/aspnet/HttpAbstractions/issues/128/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/HttpAbstractions/pulls/128/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/HttpAbstractions/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/aspnet/HttpAbstractions/pulls/128/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/HttpAbstractions/statuses/086ea4f2036d73bc29afa6376d1d9e792d87af16"}}}}