GitHub PullRequestReviewCommentEvent at 2014-08-20 19:01:48
Repository: manageiq
Actor: jrafanie
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/16497089","id":16497089,"diff_hunk":"@@ -127,7 +127,12 @@ def []=( name, value )\n         bracket_equal_old(name.to_s, value)\n       rescue => err\n         if err.class == ::Encoding::CompatibilityError\n-          bracket_equal_old(name.to_s, value.dup.force_encoding('UTF-8'))\n+          nv = value.dup.force_encoding(\"utf-8\")\n+          unless nv.valid_encoding?\n+            nv.force_encoding(\"utf-16\")","path":"lib/util/xml/miq_rexml.rb","position":7,"original_position":7,"commit_id":"fb3e5832ffc8d45c359f08046153b119facb3003","original_commit_id":"fb3e5832ffc8d45c359f08046153b119facb3003","user":{"login":"jrafanie","id":19339,"avatar_url":"https://avatars.githubusercontent.com/u/19339?v=2","gravatar_id":"9968b786345739e77c49dc09c4f6514c","url":"https://api.github.com/users/jrafanie","html_url":"https://github.com/jrafanie","followers_url":"https://api.github.com/users/jrafanie/followers","following_url":"https://api.github.com/users/jrafanie/following{/other_user}","gists_url":"https://api.github.com/users/jrafanie/gists{/gist_id}","starred_url":"https://api.github.com/users/jrafanie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrafanie/subscriptions","organizations_url":"https://api.github.com/users/jrafanie/orgs","repos_url":"https://api.github.com/users/jrafanie/repos","events_url":"https://api.github.com/users/jrafanie/events{/privacy}","received_events_url":"https://api.github.com/users/jrafanie/received_events","type":"User","site_admin":false},"body":"Totally naive question, is forcing UTF-8 and then UTF-16 equivalent to going straight to UTF-16 for strings that are not valid UTF-8?","created_at":"2014-08-20T19:01:48Z","updated_at":"2014-08-20T19:01:48Z","html_url":"https://github.com/ManageIQ/manageiq/pull/425#discussion_r16497089","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/425","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/16497089"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/425#discussion_r16497089"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/425"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/425","id":20056450,"html_url":"https://github.com/ManageIQ/manageiq/pull/425","diff_url":"https://github.com/ManageIQ/manageiq/pull/425.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/425.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/425","number":425,"state":"open","locked":false,"title":"Fix SmartState Analysis failures on non-English VMs.","user":{"login":"roliveri","id":2810177,"avatar_url":"https://avatars.githubusercontent.com/u/2810177?v=2","gravatar_id":"b078dc607e0d67b31f21807514065a3b","url":"https://api.github.com/users/roliveri","html_url":"https://github.com/roliveri","followers_url":"https://api.github.com/users/roliveri/followers","following_url":"https://api.github.com/users/roliveri/following{/other_user}","gists_url":"https://api.github.com/users/roliveri/gists{/gist_id}","starred_url":"https://api.github.com/users/roliveri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roliveri/subscriptions","organizations_url":"https://api.github.com/users/roliveri/orgs","repos_url":"https://api.github.com/users/roliveri/repos","events_url":"https://api.github.com/users/roliveri/events{/privacy}","received_events_url":"https://api.github.com/users/roliveri/received_events","type":"User","site_admin":false},"body":"@chessbyte please review.\r\n\r\nText retrieved from non-English Windows VMs may be encoded in\r\nUTF-16. This text may contain byte sequences that are not valid\r\nin UTF-8. Check the text for valid encoding, and convert to UTF-8\r\nas needed.\r\n\r\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1126476\r\nIssue: #293\r\nIssue: #332","created_at":"2014-08-20T16:27:10Z","updated_at":"2014-08-20T19:01:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"279fe950cf5b81aeef6f4397d6b91c1f05d07d1a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/425/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/425/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/425/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/fb3e5832ffc8d45c359f08046153b119facb3003","head":{"label":"roliveri:german_vm","ref":"german_vm","sha":"fb3e5832ffc8d45c359f08046153b119facb3003","user":{"login":"roliveri","id":2810177,"avatar_url":"https://avatars.githubusercontent.com/u/2810177?v=2","gravatar_id":"b078dc607e0d67b31f21807514065a3b","url":"https://api.github.com/users/roliveri","html_url":"https://github.com/roliveri","followers_url":"https://api.github.com/users/roliveri/followers","following_url":"https://api.github.com/users/roliveri/following{/other_user}","gists_url":"https://api.github.com/users/roliveri/gists{/gist_id}","starred_url":"https://api.github.com/users/roliveri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roliveri/subscriptions","organizations_url":"https://api.github.com/users/roliveri/orgs","repos_url":"https://api.github.com/users/roliveri/repos","events_url":"https://api.github.com/users/roliveri/events{/privacy}","received_events_url":"https://api.github.com/users/roliveri/received_events","type":"User","site_admin":false},"repo":{"id":20816264,"name":"manageiq","full_name":"roliveri/manageiq","owner":{"login":"roliveri","id":2810177,"avatar_url":"https://avatars.githubusercontent.com/u/2810177?v=2","gravatar_id":"b078dc607e0d67b31f21807514065a3b","url":"https://api.github.com/users/roliveri","html_url":"https://github.com/roliveri","followers_url":"https://api.github.com/users/roliveri/followers","following_url":"https://api.github.com/users/roliveri/following{/other_user}","gists_url":"https://api.github.com/users/roliveri/gists{/gist_id}","starred_url":"https://api.github.com/users/roliveri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roliveri/subscriptions","organizations_url":"https://api.github.com/users/roliveri/orgs","repos_url":"https://api.github.com/users/roliveri/repos","events_url":"https://api.github.com/users/roliveri/events{/privacy}","received_events_url":"https://api.github.com/users/roliveri/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/roliveri/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/roliveri/manageiq","forks_url":"https://api.github.com/repos/roliveri/manageiq/forks","keys_url":"https://api.github.com/repos/roliveri/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/roliveri/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/roliveri/manageiq/teams","hooks_url":"https://api.github.com/repos/roliveri/manageiq/hooks","issue_events_url":"https://api.github.com/repos/roliveri/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/roliveri/manageiq/events","assignees_url":"https://api.github.com/repos/roliveri/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/roliveri/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/roliveri/manageiq/tags","blobs_url":"https://api.github.com/repos/roliveri/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/roliveri/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/roliveri/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/roliveri/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/roliveri/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/roliveri/manageiq/languages","stargazers_url":"https://api.github.com/repos/roliveri/manageiq/stargazers","contributors_url":"https://api.github.com/repos/roliveri/manageiq/contributors","subscribers_url":"https://api.github.com/repos/roliveri/manageiq/subscribers","subscription_url":"https://api.github.com/repos/roliveri/manageiq/subscription","commits_url":"https://api.github.com/repos/roliveri/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/roliveri/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/roliveri/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/roliveri/manageiq/issues/comments/{number}","contents_url":"https://api.github.com/repos/roliveri/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/roliveri/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/roliveri/manageiq/merges","archive_url":"https://api.github.com/repos/roliveri/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/roliveri/manageiq/downloads","issues_url":"https://api.github.com/repos/roliveri/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/roliveri/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/roliveri/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/roliveri/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/roliveri/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/roliveri/manageiq/releases{/id}","created_at":"2014-06-13T20:03:38Z","updated_at":"2014-06-19T17:26:25Z","pushed_at":"2014-08-20T16:22:44Z","git_url":"git://github.com/roliveri/manageiq.git","ssh_url":"git@github.com:roliveri/manageiq.git","clone_url":"https://github.com/roliveri/manageiq.git","svn_url":"https://github.com/roliveri/manageiq","homepage":null,"size":55896,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"c8b6f24dacca4be7481c4e1ddfbe2ae9a7d05b6c","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=2","gravatar_id":"6e2fbc6e71ee5df101885996971f41e0","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=2","gravatar_id":"6e2fbc6e71ee5df101885996971f41e0","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Cloud Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/{number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","created_at":"2014-06-13T02:31:26Z","updated_at":"2014-08-18T16:16:23Z","pushed_at":"2014-08-20T18:49:02Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":65004,"stargazers_count":42,"watchers_count":42,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":50,"mirror_url":null,"open_issues_count":72,"forks":50,"open_issues":72,"watchers":42,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/425"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/425"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/425"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/425/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/425/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/425/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/fb3e5832ffc8d45c359f08046153b119facb3003"}}}}