GitHub PullRequestReviewCommentEvent at 2014-12-26 21:51:50
Repository: thumbor-versionable
Actor: houndci
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/vjustov/thumbor-versionable/pulls/comments/22288960","id":22288960,"diff_hunk":"@@ -1,28 +1,43 @@\n require 'spec_helper'\n \n describe Versionable::Version do\n-  let(:version) do\n+  let(:version_full) do\n     described_class.new OpenStruct.new(\n       url: 'https://s3.amazonaws.com/ksr/assets/moo.png'\n     ), width: 100, height: 150 do\n       crop from: { x: 10, y: 35 }, to: { x: 34, y: 50 }\n+      horizontal_align :center\n+      vertical_align :top\n     end\n   end\n \n+  let(:version_empty) do\n+    described_class.new OpenStruct.new(\n+      url: 'https://s3.amazonaws.com/ksr/assets/moo.png'\n+    ), {}\n+  end\n+\n   it 'respond to :url' do\n-    expect(version).to respond_to(:url)\n+    expect(version_full).to respond_to(:url)\n+    expect(version_empty).to respond_to(:url)\n   end\n \n   it 'constructs the url' do\n-    expect(version.url).to eq(\n-      'http://thumbor_server.net/FxHmUkBMExDwP5U6Ik00YrKMlKA=/10x35:' \\\n-      '34x50/100x150/https://s3.amazonaws.com/ksr/assets/moo.png'\n+    expect(version_empty.url).to eq('http://thumbor_server.net/' \\\n+      'rJFxkUxO6j6rXB3HpjAQN2nNS0g=/0x0/https://s3.amazonaws.co' \\\n+      'm/ksr/assets/moo.png'\n+      )\n+\n+    expect(version_full.url).to eq(\n+      'http://thumbor_server.net/2k_eIg_cVtazzmoB3o_8q4hUlx0=/10x35:' \\","path":"spec/version_spec.rb","position":37,"original_position":37,"commit_id":"d1c525f0d7028927487c8890133eec24a4f58677","original_commit_id":"d1c525f0d7028927487c8890133eec24a4f58677","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.","created_at":"2014-12-26T21:51:50Z","updated_at":"2014-12-26T21:51:50Z","html_url":"https://github.com/vjustov/thumbor-versionable/pull/15#discussion_r22288960","pull_request_url":"https://api.github.com/repos/vjustov/thumbor-versionable/pulls/15","_links":{"self":{"href":"https://api.github.com/repos/vjustov/thumbor-versionable/pulls/comments/22288960"},"html":{"href":"https://github.com/vjustov/thumbor-versionable/pull/15#discussion_r22288960"},"pull_request":{"href":"https://api.github.com/repos/vjustov/thumbor-versionable/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/vjustov/thumbor-versionable/pulls/15","id":26607484,"html_url":"https://github.com/vjustov/thumbor-versionable/pull/15","diff_url":"https://github.com/vjustov/thumbor-versionable/pull/15.diff","patch_url":"https://github.com/vjustov/thumbor-versionable/pull/15.patch","issue_url":"https://api.github.com/repos/vjustov/thumbor-versionable/issues/15","number":15,"state":"open","locked":false,"title":"Axis alignement","user":{"login":"vjustov","id":4332586,"avatar_url":"https://avatars.githubusercontent.com/u/4332586?v=3","gravatar_id":"","url":"https://api.github.com/users/vjustov","html_url":"https://github.com/vjustov","followers_url":"https://api.github.com/users/vjustov/followers","following_url":"https://api.github.com/users/vjustov/following{/other_user}","gists_url":"https://api.github.com/users/vjustov/gists{/gist_id}","starred_url":"https://api.github.com/users/vjustov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vjustov/subscriptions","organizations_url":"https://api.github.com/users/vjustov/orgs","repos_url":"https://api.github.com/users/vjustov/repos","events_url":"https://api.github.com/users/vjustov/events{/privacy}","received_events_url":"https://api.github.com/users/vjustov/received_events","type":"User","site_admin":false},"body":"Fixes #11\r\n\r\nAdds support for vertical ans horizontal alignements for crops. ","created_at":"2014-12-26T21:51:43Z","updated_at":"2014-12-26T21:51:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4d589a369e84d02d2193136f59430803ed9e13f3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/vjustov/thumbor-versionable/pulls/15/commits","review_comments_url":"https://api.github.com/repos/vjustov/thumbor-versionable/pulls/15/comments","review_comment_url":"https://api.github.com/repos/vjustov/thumbor-versionable/pulls/comments/{number}","comments_url":"https://api.github.com/repos/vjustov/thumbor-versionable/issues/15/comments","statuses_url":"https://api.github.com/repos/vjustov/thumbor-versionable/statuses/d1c525f0d7028927487c8890133eec24a4f58677","head":{"label":"vjustov:axis-alignement","ref":"axis-alignement","sha":"d1c525f0d7028927487c8890133eec24a4f58677","user":{"login":"vjustov","id":4332586,"avatar_url":"https://avatars.githubusercontent.com/u/4332586?v=3","gravatar_id":"","url":"https://api.github.com/users/vjustov","html_url":"https://github.com/vjustov","followers_url":"https://api.github.com/users/vjustov/followers","following_url":"https://api.github.com/users/vjustov/following{/other_user}","gists_url":"https://api.github.com/users/vjustov/gists{/gist_id}","starred_url":"https://api.github.com/users/vjustov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vjustov/subscriptions","organizations_url":"https://api.github.com/users/vjustov/orgs","repos_url":"https://api.github.com/users/vjustov/repos","events_url":"https://api.github.com/users/vjustov/events{/privacy}","received_events_url":"https://api.github.com/users/vjustov/received_events","type":"User","site_admin":false},"repo":{"id":27977817,"name":"thumbor-versionable","full_name":"vjustov/thumbor-versionable","owner":{"login":"vjustov","id":4332586,"avatar_url":"https://avatars.githubusercontent.com/u/4332586?v=3","gravatar_id":"","url":"https://api.github.com/users/vjustov","html_url":"https://github.com/vjustov","followers_url":"https://api.github.com/users/vjustov/followers","following_url":"https://api.github.com/users/vjustov/following{/other_user}","gists_url":"https://api.github.com/users/vjustov/gists{/gist_id}","starred_url":"https://api.github.com/users/vjustov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vjustov/subscriptions","organizations_url":"https://api.github.com/users/vjustov/orgs","repos_url":"https://api.github.com/users/vjustov/repos","events_url":"https://api.github.com/users/vjustov/events{/privacy}","received_events_url":"https://api.github.com/users/vjustov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vjustov/thumbor-versionable","description":"A Thumbor client that lets you specify versions of given image.","fork":false,"url":"https://api.github.com/repos/vjustov/thumbor-versionable","forks_url":"https://api.github.com/repos/vjustov/thumbor-versionable/forks","keys_url":"https://api.github.com/repos/vjustov/thumbor-versionable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vjustov/thumbor-versionable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vjustov/thumbor-versionable/teams","hooks_url":"https://api.github.com/repos/vjustov/thumbor-versionable/hooks","issue_events_url":"https://api.github.com/repos/vjustov/thumbor-versionable/issues/events{/number}","events_url":"https://api.github.com/repos/vjustov/thumbor-versionable/events","assignees_url":"https://api.github.com/repos/vjustov/thumbor-versionable/assignees{/user}","branches_url":"https://api.github.com/repos/vjustov/thumbor-versionable/branches{/branch}","tags_url":"https://api.github.com/repos/vjustov/thumbor-versionable/tags","blobs_url":"https://api.github.com/repos/vjustov/thumbor-versionable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vjustov/thumbor-versionable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vjustov/thumbor-versionable/git/refs{/sha}","trees_url":"https://api.github.com/repos/vjustov/thumbor-versionable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vjustov/thumbor-versionable/statuses/{sha}","languages_url":"https://api.github.com/repos/vjustov/thumbor-versionable/languages","stargazers_url":"https://api.github.com/repos/vjustov/thumbor-versionable/stargazers","contributors_url":"https://api.github.com/repos/vjustov/thumbor-versionable/contributors","subscribers_url":"https://api.github.com/repos/vjustov/thumbor-versionable/subscribers","subscription_url":"https://api.github.com/repos/vjustov/thumbor-versionable/subscription","commits_url":"https://api.github.com/repos/vjustov/thumbor-versionable/commits{/sha}","git_commits_url":"https://api.github.com/repos/vjustov/thumbor-versionable/git/commits{/sha}","comments_url":"https://api.github.com/repos/vjustov/thumbor-versionable/comments{/number}","issue_comment_url":"https://api.github.com/repos/vjustov/thumbor-versionable/issues/comments/{number}","contents_url":"https://api.github.com/repos/vjustov/thumbor-versionable/contents/{+path}","compare_url":"https://api.github.com/repos/vjustov/thumbor-versionable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vjustov/thumbor-versionable/merges","archive_url":"https://api.github.com/repos/vjustov/thumbor-versionable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vjustov/thumbor-versionable/downloads","issues_url":"https://api.github.com/repos/vjustov/thumbor-versionable/issues{/number}","pulls_url":"https://api.github.com/repos/vjustov/thumbor-versionable/pulls{/number}","milestones_url":"https://api.github.com/repos/vjustov/thumbor-versionable/milestones{/number}","notifications_url":"https://api.github.com/repos/vjustov/thumbor-versionable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vjustov/thumbor-versionable/labels{/name}","releases_url":"https://api.github.com/repos/vjustov/thumbor-versionable/releases{/id}","created_at":"2014-12-14T00:00:32Z","updated_at":"2014-12-21T22:53:25Z","pushed_at":"2014-12-26T21:47:17Z","git_url":"git://github.com/vjustov/thumbor-versionable.git","ssh_url":"git@github.com:vjustov/thumbor-versionable.git","clone_url":"https://github.com/vjustov/thumbor-versionable.git","svn_url":"https://github.com/vjustov/thumbor-versionable","homepage":null,"size":181,"stargazers_count":9,"watchers_count":9,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":5,"forks":2,"open_issues":5,"watchers":9,"default_branch":"master"}},"base":{"label":"vjustov:development","ref":"development","sha":"759860ffe70ac1ef22e17d9d0e5bc9d314ee8adc","user":{"login":"vjustov","id":4332586,"avatar_url":"https://avatars.githubusercontent.com/u/4332586?v=3","gravatar_id":"","url":"https://api.github.com/users/vjustov","html_url":"https://github.com/vjustov","followers_url":"https://api.github.com/users/vjustov/followers","following_url":"https://api.github.com/users/vjustov/following{/other_user}","gists_url":"https://api.github.com/users/vjustov/gists{/gist_id}","starred_url":"https://api.github.com/users/vjustov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vjustov/subscriptions","organizations_url":"https://api.github.com/users/vjustov/orgs","repos_url":"https://api.github.com/users/vjustov/repos","events_url":"https://api.github.com/users/vjustov/events{/privacy}","received_events_url":"https://api.github.com/users/vjustov/received_events","type":"User","site_admin":false},"repo":{"id":27977817,"name":"thumbor-versionable","full_name":"vjustov/thumbor-versionable","owner":{"login":"vjustov","id":4332586,"avatar_url":"https://avatars.githubusercontent.com/u/4332586?v=3","gravatar_id":"","url":"https://api.github.com/users/vjustov","html_url":"https://github.com/vjustov","followers_url":"https://api.github.com/users/vjustov/followers","following_url":"https://api.github.com/users/vjustov/following{/other_user}","gists_url":"https://api.github.com/users/vjustov/gists{/gist_id}","starred_url":"https://api.github.com/users/vjustov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vjustov/subscriptions","organizations_url":"https://api.github.com/users/vjustov/orgs","repos_url":"https://api.github.com/users/vjustov/repos","events_url":"https://api.github.com/users/vjustov/events{/privacy}","received_events_url":"https://api.github.com/users/vjustov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vjustov/thumbor-versionable","description":"A Thumbor client that lets you specify versions of given image.","fork":false,"url":"https://api.github.com/repos/vjustov/thumbor-versionable","forks_url":"https://api.github.com/repos/vjustov/thumbor-versionable/forks","keys_url":"https://api.github.com/repos/vjustov/thumbor-versionable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vjustov/thumbor-versionable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vjustov/thumbor-versionable/teams","hooks_url":"https://api.github.com/repos/vjustov/thumbor-versionable/hooks","issue_events_url":"https://api.github.com/repos/vjustov/thumbor-versionable/issues/events{/number}","events_url":"https://api.github.com/repos/vjustov/thumbor-versionable/events","assignees_url":"https://api.github.com/repos/vjustov/thumbor-versionable/assignees{/user}","branches_url":"https://api.github.com/repos/vjustov/thumbor-versionable/branches{/branch}","tags_url":"https://api.github.com/repos/vjustov/thumbor-versionable/tags","blobs_url":"https://api.github.com/repos/vjustov/thumbor-versionable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vjustov/thumbor-versionable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vjustov/thumbor-versionable/git/refs{/sha}","trees_url":"https://api.github.com/repos/vjustov/thumbor-versionable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vjustov/thumbor-versionable/statuses/{sha}","languages_url":"https://api.github.com/repos/vjustov/thumbor-versionable/languages","stargazers_url":"https://api.github.com/repos/vjustov/thumbor-versionable/stargazers","contributors_url":"https://api.github.com/repos/vjustov/thumbor-versionable/contributors","subscribers_url":"https://api.github.com/repos/vjustov/thumbor-versionable/subscribers","subscription_url":"https://api.github.com/repos/vjustov/thumbor-versionable/subscription","commits_url":"https://api.github.com/repos/vjustov/thumbor-versionable/commits{/sha}","git_commits_url":"https://api.github.com/repos/vjustov/thumbor-versionable/git/commits{/sha}","comments_url":"https://api.github.com/repos/vjustov/thumbor-versionable/comments{/number}","issue_comment_url":"https://api.github.com/repos/vjustov/thumbor-versionable/issues/comments/{number}","contents_url":"https://api.github.com/repos/vjustov/thumbor-versionable/contents/{+path}","compare_url":"https://api.github.com/repos/vjustov/thumbor-versionable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vjustov/thumbor-versionable/merges","archive_url":"https://api.github.com/repos/vjustov/thumbor-versionable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vjustov/thumbor-versionable/downloads","issues_url":"https://api.github.com/repos/vjustov/thumbor-versionable/issues{/number}","pulls_url":"https://api.github.com/repos/vjustov/thumbor-versionable/pulls{/number}","milestones_url":"https://api.github.com/repos/vjustov/thumbor-versionable/milestones{/number}","notifications_url":"https://api.github.com/repos/vjustov/thumbor-versionable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vjustov/thumbor-versionable/labels{/name}","releases_url":"https://api.github.com/repos/vjustov/thumbor-versionable/releases{/id}","created_at":"2014-12-14T00:00:32Z","updated_at":"2014-12-21T22:53:25Z","pushed_at":"2014-12-26T21:47:17Z","git_url":"git://github.com/vjustov/thumbor-versionable.git","ssh_url":"git@github.com:vjustov/thumbor-versionable.git","clone_url":"https://github.com/vjustov/thumbor-versionable.git","svn_url":"https://github.com/vjustov/thumbor-versionable","homepage":null,"size":181,"stargazers_count":9,"watchers_count":9,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":5,"forks":2,"open_issues":5,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vjustov/thumbor-versionable/pulls/15"},"html":{"href":"https://github.com/vjustov/thumbor-versionable/pull/15"},"issue":{"href":"https://api.github.com/repos/vjustov/thumbor-versionable/issues/15"},"comments":{"href":"https://api.github.com/repos/vjustov/thumbor-versionable/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/vjustov/thumbor-versionable/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/vjustov/thumbor-versionable/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/vjustov/thumbor-versionable/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/vjustov/thumbor-versionable/statuses/d1c525f0d7028927487c8890133eec24a4f58677"}}}}