GitHub PushEvent at 2014-09-25 19:26:42
Repository: juju
Actor: binary132
Payload: {"shas":[["8237e4d2f93080bd3b10aef024213667fce6b956","1041179cbdda366fd7b0347f09255f775170e103@mattyw.net","added benchmarks for metrics","mattyw",true],["e3cfd8cee1c86f97ac7409dd18eb1b96e702daf9","1041179cbdda366fd7b0347f09255f775170e103@mattyw.net","more addmetric benchmarks","mattyw",true],["4bd4749d8ff5219cbcf01f73c7f63e56e8644ca3","28c2b79e213f53c52a14677e00898d5b855059a0@users.noreply.github.com","Merge pull request #830 from mattyw/benchmark-metrics\n\nadded benchmarks for metrics\n\nhttp://reviews.vapour.ws/r/98/","Juju bot",true],["3dec0ded71766bf013fa91a68684d72464a0dfc4","399d12ef73a469bc9df9f06fc232809935be90fb@gmail.com","ActionComplete / ActionFailed called after Action completion\n\nThe worker now calls ActionComplete or ActionFailed on state, depending\non the success state of the Action and any errors.\n\nThe hook is set to an error state if the Action hook is missing, or if\nother errors take place during hook execution.  If the Action hook sets\na fail state, the Hook will not error, rather the Action will fail.","Bodie Solomon",true],["c9170ded84b35481003b452e18861ba5cad58d37","399d12ef73a469bc9df9f06fc232809935be90fb@gmail.com","ActionComplete / ActionFailed called after Action completion\n\nActionTags are now properly initialized on worker uniter.HookContext at the\ntime it is created.","Bodie Solomon",true],["97c455713d86143c24346b24a66d7af0a054c79c","399d12ef73a469bc9df9f06fc232809935be90fb@gmail.com","ActionComplete / ActionFailed called after Action completion\n\nFinal bits and pieces to complete PR 617 put in place; tests fleshed out\nand passing.","Bodie Solomon",true],["13407f86ece0c4bdd5459f9aad40926fab5a51f8","399d12ef73a469bc9df9f06fc232809935be90fb@gmail.com","ActionComplete / ActionFailed called after Action completion\n\nAddressed davecheney's points in PR 617.","Bodie Solomon",true],["22c2b285afc8d88f00933291407b96a0ab6d6cbd","399d12ef73a469bc9df9f06fc232809935be90fb@gmail.com","ActionComplete / ActionFailed called after Action completion\n\nAddressed further points in PR 617:\n - Action results no longer a pointer, thus no nil checks needed\n - ActionFail call-home now sends a sane message to the user, without\n   discarding error context\n - Minor tweaks to relation write-out logic\n - Removed pointless actionStatus type\n - Checks for nil state handle for ActionComplete / ActionFail","Bodie Solomon",true],["8694983c82752b9b686e6ac5931427a8a769b4e9","399d12ef73a469bc9df9f06fc232809935be90fb@gmail.com","worker/uniter finalizeContext refactor for ActionFinish","Bodie Solomon",true],["40bea8e37e264ba36c1b4f3a308ac6e826341cde","399d12ef73a469bc9df9f06fc232809935be90fb@gmail.com","ActionComplete / ActionFailed called after Action completion\n\nAddressed remarks in PR #617:\n - Action-related HookContext types bundled into a single type.\n - Comment added to State handle in HookContext.\n - actionData constructor called from outside the HookContext, in the\n   case of Actions only.","Bodie Solomon",true],["373c84ef28f116e0a4a2b552d5c6a26c00ea0a84","399d12ef73a469bc9df9f06fc232809935be90fb@gmail.com","ActionFinish called after Action completion\n\nRemoved actionFailed() helper function, made naming tweak.","Bodie Solomon",true],["f93e4005bdf932d57920587413fdd1775b8118bc","399d12ef73a469bc9df9f06fc232809935be90fb@gmail.com","ActionFinish on the worker after Action hook run\n\nThis commit splits the logic of Uniter.runHook into Uniter.runAction and\nUniter.runHook.  It also uses the new `Action` Hook Kind, improves error\nhandling, improves tests, and addresses other comments from PR #617.\n\nDepends on github.com/juju/charm/ PR #43.  This commit will be\namended to include the dependency once the changes to juju/charm have\nbeen finalized.","Bodie Solomon",true],["fe6382f9d752a3e84a0ac63df07ce0dfba380d00","399d12ef73a469bc9df9f06fc232809935be90fb@gmail.com","ActionFinish on the worker after Action hook run\n\nBugfixes to several worker uniter tests; addressed @fwereade's comments\non PR 617.","Bodie Solomon",true],["3854923c16ed890dc3987e72b7d28e4caefaa759","399d12ef73a469bc9df9f06fc232809935be90fb@gmail.com","ActionFinish on the worker after Action hook run\n\nThis commit addresses requested changes to PR 617, including smarter\nhandling of error states in Actions, and cleaner runAction handling\nof action param validation errors.","Bodie Solomon",true],["ec6cceac0c720d2455b0f8559e9b5eeae5189781","399d12ef73a469bc9df9f06fc232809935be90fb@gmail.com","ActionFinish on the worker after Action hook run\n\nThis commit addresses @TheMue's comments on PR 617, renaming errors to\nsomething more sensible in worker/context finalizeContext.","Bodie Solomon",true]],"size":15,"ref":"refs/heads/action-uniter-response","head":"ec6cceac0c720d2455b0f8559e9b5eeae5189781"}