GitHub PullRequestEvent at 2014-07-30 08:55:58
Repository: pcl
Actor: taketwo
Payload: {"action":"closed","number":815,"pull_request":{"url":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/815","id":19073608,"html_url":"https://github.com/PointCloudLibrary/pcl/pull/815","diff_url":"https://github.com/PointCloudLibrary/pcl/pull/815.diff","patch_url":"https://github.com/PointCloudLibrary/pcl/pull/815.patch","issue_url":"https://api.github.com/repos/PointCloudLibrary/pcl/issues/815","number":815,"state":"closed","title":"Avoid the use of undefined typedefs","user":{"login":"andersgb1","id":3854029,"avatar_url":"https://avatars.githubusercontent.com/u/3854029?v=1","gravatar_id":"11ca14b5e947204ddfcffab36e19f43f","url":"https://api.github.com/users/andersgb1","html_url":"https://github.com/andersgb1","followers_url":"https://api.github.com/users/andersgb1/followers","following_url":"https://api.github.com/users/andersgb1/following{/other_user}","gists_url":"https://api.github.com/users/andersgb1/gists{/gist_id}","starred_url":"https://api.github.com/users/andersgb1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andersgb1/subscriptions","organizations_url":"https://api.github.com/users/andersgb1/orgs","repos_url":"https://api.github.com/users/andersgb1/repos","events_url":"https://api.github.com/users/andersgb1/events{/privacy}","received_events_url":"https://api.github.com/users/andersgb1/received_events","type":"User","site_admin":false},"body":"When using the macro **PCL_ADD_RGB** outside of **pcl::**, I get a compiler error because that macro uses typedefs (**Vector3c, Vector3cMap, Vector3cMapConst, Vector4c, Vector4cMap** and **Vector4cMapConst**) which are so far undefined. All this occurs inside **point_types.hpp**. A possible solution is to just move the typedefs above the definition of **PCL_ADD_RGB**, but this still doesn't allow users to use the macro outside of **pcl::**.\r\n\r\nFor instance, creating a new external project (http://pointclouds.org/documentation/tutorials/using_pcl_pcl_config.php) with an executable with the following code would produce an error.\r\n\r\n```c++\r\n#include <pcl/point_types.h>\r\n\r\nstruct MyRGBType\r\n{\r\n  PCL_ADD_RGB;\r\n};\r\n\r\nint main (int argc, char** argv)\r\n{\r\n  return (0);\r\n}\r\n```\r\n\r\nThis PR only changes the **PCL_ADD_EIGEN_MAPS_RGB** to not use the typedefs. Then the above works.","created_at":"2014-07-30T07:42:01Z","updated_at":"2014-07-30T08:55:58Z","closed_at":"2014-07-30T08:55:58Z","merged_at":"2014-07-30T08:55:58Z","merge_commit_sha":"6e75b326da97b3f90f9616d5014e30145924f38e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/815/commits","review_comments_url":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/815/comments","review_comment_url":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/comments/{number}","comments_url":"https://api.github.com/repos/PointCloudLibrary/pcl/issues/815/comments","statuses_url":"https://api.github.com/repos/PointCloudLibrary/pcl/statuses/3bb5df5762196d2dc6227e06abdee86290f87a20","head":{"label":"andersgb1:point_types_fix","ref":"point_types_fix","sha":"3bb5df5762196d2dc6227e06abdee86290f87a20","user":{"login":"andersgb1","id":3854029,"avatar_url":"https://avatars.githubusercontent.com/u/3854029?v=1","gravatar_id":"11ca14b5e947204ddfcffab36e19f43f","url":"https://api.github.com/users/andersgb1","html_url":"https://github.com/andersgb1","followers_url":"https://api.github.com/users/andersgb1/followers","following_url":"https://api.github.com/users/andersgb1/following{/other_user}","gists_url":"https://api.github.com/users/andersgb1/gists{/gist_id}","starred_url":"https://api.github.com/users/andersgb1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andersgb1/subscriptions","organizations_url":"https://api.github.com/users/andersgb1/orgs","repos_url":"https://api.github.com/users/andersgb1/repos","events_url":"https://api.github.com/users/andersgb1/events{/privacy}","received_events_url":"https://api.github.com/users/andersgb1/received_events","type":"User","site_admin":false},"repo":{"id":22381190,"name":"pcl","full_name":"andersgb1/pcl","owner":{"login":"andersgb1","id":3854029,"avatar_url":"https://avatars.githubusercontent.com/u/3854029?v=1","gravatar_id":"11ca14b5e947204ddfcffab36e19f43f","url":"https://api.github.com/users/andersgb1","html_url":"https://github.com/andersgb1","followers_url":"https://api.github.com/users/andersgb1/followers","following_url":"https://api.github.com/users/andersgb1/following{/other_user}","gists_url":"https://api.github.com/users/andersgb1/gists{/gist_id}","starred_url":"https://api.github.com/users/andersgb1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andersgb1/subscriptions","organizations_url":"https://api.github.com/users/andersgb1/orgs","repos_url":"https://api.github.com/users/andersgb1/repos","events_url":"https://api.github.com/users/andersgb1/events{/privacy}","received_events_url":"https://api.github.com/users/andersgb1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andersgb1/pcl","description":"Point Cloud Library (PCL)","fork":true,"url":"https://api.github.com/repos/andersgb1/pcl","forks_url":"https://api.github.com/repos/andersgb1/pcl/forks","keys_url":"https://api.github.com/repos/andersgb1/pcl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andersgb1/pcl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andersgb1/pcl/teams","hooks_url":"https://api.github.com/repos/andersgb1/pcl/hooks","issue_events_url":"https://api.github.com/repos/andersgb1/pcl/issues/events{/number}","events_url":"https://api.github.com/repos/andersgb1/pcl/events","assignees_url":"https://api.github.com/repos/andersgb1/pcl/assignees{/user}","branches_url":"https://api.github.com/repos/andersgb1/pcl/branches{/branch}","tags_url":"https://api.github.com/repos/andersgb1/pcl/tags","blobs_url":"https://api.github.com/repos/andersgb1/pcl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andersgb1/pcl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andersgb1/pcl/git/refs{/sha}","trees_url":"https://api.github.com/repos/andersgb1/pcl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andersgb1/pcl/statuses/{sha}","languages_url":"https://api.github.com/repos/andersgb1/pcl/languages","stargazers_url":"https://api.github.com/repos/andersgb1/pcl/stargazers","contributors_url":"https://api.github.com/repos/andersgb1/pcl/contributors","subscribers_url":"https://api.github.com/repos/andersgb1/pcl/subscribers","subscription_url":"https://api.github.com/repos/andersgb1/pcl/subscription","commits_url":"https://api.github.com/repos/andersgb1/pcl/commits{/sha}","git_commits_url":"https://api.github.com/repos/andersgb1/pcl/git/commits{/sha}","comments_url":"https://api.github.com/repos/andersgb1/pcl/comments{/number}","issue_comment_url":"https://api.github.com/repos/andersgb1/pcl/issues/comments/{number}","contents_url":"https://api.github.com/repos/andersgb1/pcl/contents/{+path}","compare_url":"https://api.github.com/repos/andersgb1/pcl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andersgb1/pcl/merges","archive_url":"https://api.github.com/repos/andersgb1/pcl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andersgb1/pcl/downloads","issues_url":"https://api.github.com/repos/andersgb1/pcl/issues{/number}","pulls_url":"https://api.github.com/repos/andersgb1/pcl/pulls{/number}","milestones_url":"https://api.github.com/repos/andersgb1/pcl/milestones{/number}","notifications_url":"https://api.github.com/repos/andersgb1/pcl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andersgb1/pcl/labels{/name}","releases_url":"https://api.github.com/repos/andersgb1/pcl/releases{/id}","created_at":"2014-07-29T13:42:22Z","updated_at":"2014-07-29T07:57:54Z","pushed_at":"2014-07-30T08:51:16Z","git_url":"git://github.com/andersgb1/pcl.git","ssh_url":"git@github.com:andersgb1/pcl.git","clone_url":"https://github.com/andersgb1/pcl.git","svn_url":"https://github.com/andersgb1/pcl","homepage":"http://www.pointclouds.org","size":216566,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PointCloudLibrary:master","ref":"master","sha":"4215f593ea0d39e9e2d1483f92ae50f2129b3195","user":{"login":"PointCloudLibrary","id":2059451,"avatar_url":"https://avatars.githubusercontent.com/u/2059451?v=1","gravatar_id":"c7f0f676323e7707f3602fde74a4bec2","url":"https://api.github.com/users/PointCloudLibrary","html_url":"https://github.com/PointCloudLibrary","followers_url":"https://api.github.com/users/PointCloudLibrary/followers","following_url":"https://api.github.com/users/PointCloudLibrary/following{/other_user}","gists_url":"https://api.github.com/users/PointCloudLibrary/gists{/gist_id}","starred_url":"https://api.github.com/users/PointCloudLibrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PointCloudLibrary/subscriptions","organizations_url":"https://api.github.com/users/PointCloudLibrary/orgs","repos_url":"https://api.github.com/users/PointCloudLibrary/repos","events_url":"https://api.github.com/users/PointCloudLibrary/events{/privacy}","received_events_url":"https://api.github.com/users/PointCloudLibrary/received_events","type":"Organization","site_admin":false},"repo":{"id":8162615,"name":"pcl","full_name":"PointCloudLibrary/pcl","owner":{"login":"PointCloudLibrary","id":2059451,"avatar_url":"https://avatars.githubusercontent.com/u/2059451?v=1","gravatar_id":"c7f0f676323e7707f3602fde74a4bec2","url":"https://api.github.com/users/PointCloudLibrary","html_url":"https://github.com/PointCloudLibrary","followers_url":"https://api.github.com/users/PointCloudLibrary/followers","following_url":"https://api.github.com/users/PointCloudLibrary/following{/other_user}","gists_url":"https://api.github.com/users/PointCloudLibrary/gists{/gist_id}","starred_url":"https://api.github.com/users/PointCloudLibrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PointCloudLibrary/subscriptions","organizations_url":"https://api.github.com/users/PointCloudLibrary/orgs","repos_url":"https://api.github.com/users/PointCloudLibrary/repos","events_url":"https://api.github.com/users/PointCloudLibrary/events{/privacy}","received_events_url":"https://api.github.com/users/PointCloudLibrary/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PointCloudLibrary/pcl","description":"Point Cloud Library (PCL)","fork":false,"url":"https://api.github.com/repos/PointCloudLibrary/pcl","forks_url":"https://api.github.com/repos/PointCloudLibrary/pcl/forks","keys_url":"https://api.github.com/repos/PointCloudLibrary/pcl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PointCloudLibrary/pcl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PointCloudLibrary/pcl/teams","hooks_url":"https://api.github.com/repos/PointCloudLibrary/pcl/hooks","issue_events_url":"https://api.github.com/repos/PointCloudLibrary/pcl/issues/events{/number}","events_url":"https://api.github.com/repos/PointCloudLibrary/pcl/events","assignees_url":"https://api.github.com/repos/PointCloudLibrary/pcl/assignees{/user}","branches_url":"https://api.github.com/repos/PointCloudLibrary/pcl/branches{/branch}","tags_url":"https://api.github.com/repos/PointCloudLibrary/pcl/tags","blobs_url":"https://api.github.com/repos/PointCloudLibrary/pcl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PointCloudLibrary/pcl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PointCloudLibrary/pcl/git/refs{/sha}","trees_url":"https://api.github.com/repos/PointCloudLibrary/pcl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PointCloudLibrary/pcl/statuses/{sha}","languages_url":"https://api.github.com/repos/PointCloudLibrary/pcl/languages","stargazers_url":"https://api.github.com/repos/PointCloudLibrary/pcl/stargazers","contributors_url":"https://api.github.com/repos/PointCloudLibrary/pcl/contributors","subscribers_url":"https://api.github.com/repos/PointCloudLibrary/pcl/subscribers","subscription_url":"https://api.github.com/repos/PointCloudLibrary/pcl/subscription","commits_url":"https://api.github.com/repos/PointCloudLibrary/pcl/commits{/sha}","git_commits_url":"https://api.github.com/repos/PointCloudLibrary/pcl/git/commits{/sha}","comments_url":"https://api.github.com/repos/PointCloudLibrary/pcl/comments{/number}","issue_comment_url":"https://api.github.com/repos/PointCloudLibrary/pcl/issues/comments/{number}","contents_url":"https://api.github.com/repos/PointCloudLibrary/pcl/contents/{+path}","compare_url":"https://api.github.com/repos/PointCloudLibrary/pcl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PointCloudLibrary/pcl/merges","archive_url":"https://api.github.com/repos/PointCloudLibrary/pcl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PointCloudLibrary/pcl/downloads","issues_url":"https://api.github.com/repos/PointCloudLibrary/pcl/issues{/number}","pulls_url":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls{/number}","milestones_url":"https://api.github.com/repos/PointCloudLibrary/pcl/milestones{/number}","notifications_url":"https://api.github.com/repos/PointCloudLibrary/pcl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PointCloudLibrary/pcl/labels{/name}","releases_url":"https://api.github.com/repos/PointCloudLibrary/pcl/releases{/id}","created_at":"2013-02-12T16:40:25Z","updated_at":"2014-07-29T13:50:02Z","pushed_at":"2014-07-30T08:55:58Z","git_url":"git://github.com/PointCloudLibrary/pcl.git","ssh_url":"git@github.com:PointCloudLibrary/pcl.git","clone_url":"https://github.com/PointCloudLibrary/pcl.git","svn_url":"https://github.com/PointCloudLibrary/pcl","homepage":"http://www.pointclouds.org","size":261010,"stargazers_count":405,"watchers_count":405,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":501,"mirror_url":null,"open_issues_count":92,"forks":501,"open_issues":92,"watchers":405,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/815"},"html":{"href":"https://github.com/PointCloudLibrary/pcl/pull/815"},"issue":{"href":"https://api.github.com/repos/PointCloudLibrary/pcl/issues/815"},"comments":{"href":"https://api.github.com/repos/PointCloudLibrary/pcl/issues/815/comments"},"review_comments":{"href":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/815/comments"},"review_comment":{"href":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/815/commits"},"statuses":{"href":"https://api.github.com/repos/PointCloudLibrary/pcl/statuses/3bb5df5762196d2dc6227e06abdee86290f87a20"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"taketwo","id":1241736,"avatar_url":"https://avatars.githubusercontent.com/u/1241736?v=1","gravatar_id":"71694cac93edcd9f6757139a9af32939","url":"https://api.github.com/users/taketwo","html_url":"https://github.com/taketwo","followers_url":"https://api.github.com/users/taketwo/followers","following_url":"https://api.github.com/users/taketwo/following{/other_user}","gists_url":"https://api.github.com/users/taketwo/gists{/gist_id}","starred_url":"https://api.github.com/users/taketwo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taketwo/subscriptions","organizations_url":"https://api.github.com/users/taketwo/orgs","repos_url":"https://api.github.com/users/taketwo/repos","events_url":"https://api.github.com/users/taketwo/events{/privacy}","received_events_url":"https://api.github.com/users/taketwo/received_events","type":"User","site_admin":false},"comments":8,"review_comments":0,"commits":1,"additions":32,"deletions":32,"changed_files":1}}