GitHub PullRequestReviewCommentEvent at 2014-07-10 17:11:24
Repository: genie
Actor: tgianos
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Netflix/genie/pulls/comments/14779061","id":14779061,"diff_hunk":"@@ -321,6 +265,25 @@ protected void setCommands(final Set<Command> commands) {\n     }\n \n     /**\n+     * Gets the tags allocated to this application.\n+     *\n+     * @return the tags as an unmodifiable list\n+     */\n+    public Set<String> getTags() {\n+        return this.tags;\n+    }\n+\n+    /**\n+     * Sets the tags allocated to this application.\n+     *\n+     * @param tags the tags to set. Not Null.\n+     * @throws CloudServiceException\n+     */\n+    public void setTags(final Set<String> tags) throws CloudServiceException {","path":"genie-common/src/main/java/com/netflix/genie/common/model/Application.java","position":196,"original_position":196,"commit_id":"0aeab10499d2dd8e915c3708eff6ac821a618b97","original_commit_id":"0aeab10499d2dd8e915c3708eff6ac821a618b97","user":{"login":"tgianos","id":7377597,"avatar_url":"https://avatars.githubusercontent.com/u/7377597?","gravatar_id":"af345af63a21b3b4b4124c454393225e","url":"https://api.github.com/users/tgianos","html_url":"https://github.com/tgianos","followers_url":"https://api.github.com/users/tgianos/followers","following_url":"https://api.github.com/users/tgianos/following{/other_user}","gists_url":"https://api.github.com/users/tgianos/gists{/gist_id}","starred_url":"https://api.github.com/users/tgianos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgianos/subscriptions","organizations_url":"https://api.github.com/users/tgianos/orgs","repos_url":"https://api.github.com/users/tgianos/repos","events_url":"https://api.github.com/users/tgianos/events{/privacy}","received_events_url":"https://api.github.com/users/tgianos/received_events","type":"User","site_admin":false},"body":"You say not null in the comments for the method and have it marked to throw an exception but you don't actually check for that or throw an exception. Should we just allow null which would set it to not have any foreign keys?","created_at":"2014-07-10T17:11:24Z","updated_at":"2014-07-10T17:11:24Z","html_url":"https://github.com/Netflix/genie/pull/75#discussion_r14779061","pull_request_url":"https://api.github.com/repos/Netflix/genie/pulls/75","_links":{"self":{"href":"https://api.github.com/repos/Netflix/genie/pulls/comments/14779061"},"html":{"href":"https://github.com/Netflix/genie/pull/75#discussion_r14779061"},"pull_request":{"href":"https://api.github.com/repos/Netflix/genie/pulls/75"}}},"pull_request":{"url":"https://api.github.com/repos/Netflix/genie/pulls/75","id":18193872,"html_url":"https://github.com/Netflix/genie/pull/75","diff_url":"https://github.com/Netflix/genie/pull/75.diff","patch_url":"https://github.com/Netflix/genie/pull/75.patch","issue_url":"https://api.github.com/repos/Netflix/genie/issues/75","number":75,"state":"open","title":"Tags and ui","user":{"login":"amitsharma1981","id":1613174,"avatar_url":"https://avatars.githubusercontent.com/u/1613174?","gravatar_id":"d3acbf00d2f5bfe084188079722f603a","url":"https://api.github.com/users/amitsharma1981","html_url":"https://github.com/amitsharma1981","followers_url":"https://api.github.com/users/amitsharma1981/followers","following_url":"https://api.github.com/users/amitsharma1981/following{/other_user}","gists_url":"https://api.github.com/users/amitsharma1981/gists{/gist_id}","starred_url":"https://api.github.com/users/amitsharma1981/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amitsharma1981/subscriptions","organizations_url":"https://api.github.com/users/amitsharma1981/orgs","repos_url":"https://api.github.com/users/amitsharma1981/repos","events_url":"https://api.github.com/users/amitsharma1981/events{/privacy}","received_events_url":"https://api.github.com/users/amitsharma1981/received_events","type":"User","site_admin":false},"body":"* Added Tags in all resources\r\n* New Api to submit jobs will use tags for commands\r\n* Fixed UI to get correct information for Clusters.","created_at":"2014-07-09T23:48:32Z","updated_at":"2014-07-10T17:11:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"85561418504fa378cf8a98bcb4b63a88313596d7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Netflix/genie/pulls/75/commits","review_comments_url":"https://api.github.com/repos/Netflix/genie/pulls/75/comments","review_comment_url":"https://api.github.com/repos/Netflix/genie/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Netflix/genie/issues/75/comments","statuses_url":"https://api.github.com/repos/Netflix/genie/statuses/0aeab10499d2dd8e915c3708eff6ac821a618b97","head":{"label":"Netflix:tags_and_ui","ref":"tags_and_ui","sha":"0aeab10499d2dd8e915c3708eff6ac821a618b97","user":{"login":"Netflix","id":913567,"avatar_url":"https://avatars.githubusercontent.com/u/913567?","gravatar_id":"9452a86b2d066c6e6e35fe2ea83d16a5","url":"https://api.github.com/users/Netflix","html_url":"https://github.com/Netflix","followers_url":"https://api.github.com/users/Netflix/followers","following_url":"https://api.github.com/users/Netflix/following{/other_user}","gists_url":"https://api.github.com/users/Netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/Netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Netflix/subscriptions","organizations_url":"https://api.github.com/users/Netflix/orgs","repos_url":"https://api.github.com/users/Netflix/repos","events_url":"https://api.github.com/users/Netflix/events{/privacy}","received_events_url":"https://api.github.com/users/Netflix/received_events","type":"Organization","site_admin":false},"repo":{"id":10828921,"name":"genie","full_name":"Netflix/genie","owner":{"login":"Netflix","id":913567,"avatar_url":"https://avatars.githubusercontent.com/u/913567?","gravatar_id":"9452a86b2d066c6e6e35fe2ea83d16a5","url":"https://api.github.com/users/Netflix","html_url":"https://github.com/Netflix","followers_url":"https://api.github.com/users/Netflix/followers","following_url":"https://api.github.com/users/Netflix/following{/other_user}","gists_url":"https://api.github.com/users/Netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/Netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Netflix/subscriptions","organizations_url":"https://api.github.com/users/Netflix/orgs","repos_url":"https://api.github.com/users/Netflix/repos","events_url":"https://api.github.com/users/Netflix/events{/privacy}","received_events_url":"https://api.github.com/users/Netflix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Netflix/genie","description":"Hadoop Platform as a Service","fork":false,"url":"https://api.github.com/repos/Netflix/genie","forks_url":"https://api.github.com/repos/Netflix/genie/forks","keys_url":"https://api.github.com/repos/Netflix/genie/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Netflix/genie/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Netflix/genie/teams","hooks_url":"https://api.github.com/repos/Netflix/genie/hooks","issue_events_url":"https://api.github.com/repos/Netflix/genie/issues/events{/number}","events_url":"https://api.github.com/repos/Netflix/genie/events","assignees_url":"https://api.github.com/repos/Netflix/genie/assignees{/user}","branches_url":"https://api.github.com/repos/Netflix/genie/branches{/branch}","tags_url":"https://api.github.com/repos/Netflix/genie/tags","blobs_url":"https://api.github.com/repos/Netflix/genie/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Netflix/genie/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Netflix/genie/git/refs{/sha}","trees_url":"https://api.github.com/repos/Netflix/genie/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Netflix/genie/statuses/{sha}","languages_url":"https://api.github.com/repos/Netflix/genie/languages","stargazers_url":"https://api.github.com/repos/Netflix/genie/stargazers","contributors_url":"https://api.github.com/repos/Netflix/genie/contributors","subscribers_url":"https://api.github.com/repos/Netflix/genie/subscribers","subscription_url":"https://api.github.com/repos/Netflix/genie/subscription","commits_url":"https://api.github.com/repos/Netflix/genie/commits{/sha}","git_commits_url":"https://api.github.com/repos/Netflix/genie/git/commits{/sha}","comments_url":"https://api.github.com/repos/Netflix/genie/comments{/number}","issue_comment_url":"https://api.github.com/repos/Netflix/genie/issues/comments/{number}","contents_url":"https://api.github.com/repos/Netflix/genie/contents/{+path}","compare_url":"https://api.github.com/repos/Netflix/genie/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Netflix/genie/merges","archive_url":"https://api.github.com/repos/Netflix/genie/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Netflix/genie/downloads","issues_url":"https://api.github.com/repos/Netflix/genie/issues{/number}","pulls_url":"https://api.github.com/repos/Netflix/genie/pulls{/number}","milestones_url":"https://api.github.com/repos/Netflix/genie/milestones{/number}","notifications_url":"https://api.github.com/repos/Netflix/genie/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Netflix/genie/labels{/name}","releases_url":"https://api.github.com/repos/Netflix/genie/releases{/id}","created_at":"2013-06-20T20:35:56Z","updated_at":"2014-07-09T14:50:47Z","pushed_at":"2014-07-09T23:46:46Z","git_url":"git://github.com/Netflix/genie.git","ssh_url":"git@github.com:Netflix/genie.git","clone_url":"https://github.com/Netflix/genie.git","svn_url":"https://github.com/Netflix/genie","homepage":"","size":7137,"stargazers_count":210,"watchers_count":210,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":69,"mirror_url":null,"open_issues_count":10,"forks":69,"open_issues":10,"watchers":210,"default_branch":"master"}},"base":{"label":"Netflix:di","ref":"di","sha":"5e442335beff06870d6285dce140c055f24c5a48","user":{"login":"Netflix","id":913567,"avatar_url":"https://avatars.githubusercontent.com/u/913567?","gravatar_id":"9452a86b2d066c6e6e35fe2ea83d16a5","url":"https://api.github.com/users/Netflix","html_url":"https://github.com/Netflix","followers_url":"https://api.github.com/users/Netflix/followers","following_url":"https://api.github.com/users/Netflix/following{/other_user}","gists_url":"https://api.github.com/users/Netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/Netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Netflix/subscriptions","organizations_url":"https://api.github.com/users/Netflix/orgs","repos_url":"https://api.github.com/users/Netflix/repos","events_url":"https://api.github.com/users/Netflix/events{/privacy}","received_events_url":"https://api.github.com/users/Netflix/received_events","type":"Organization","site_admin":false},"repo":{"id":10828921,"name":"genie","full_name":"Netflix/genie","owner":{"login":"Netflix","id":913567,"avatar_url":"https://avatars.githubusercontent.com/u/913567?","gravatar_id":"9452a86b2d066c6e6e35fe2ea83d16a5","url":"https://api.github.com/users/Netflix","html_url":"https://github.com/Netflix","followers_url":"https://api.github.com/users/Netflix/followers","following_url":"https://api.github.com/users/Netflix/following{/other_user}","gists_url":"https://api.github.com/users/Netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/Netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Netflix/subscriptions","organizations_url":"https://api.github.com/users/Netflix/orgs","repos_url":"https://api.github.com/users/Netflix/repos","events_url":"https://api.github.com/users/Netflix/events{/privacy}","received_events_url":"https://api.github.com/users/Netflix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Netflix/genie","description":"Hadoop Platform as a Service","fork":false,"url":"https://api.github.com/repos/Netflix/genie","forks_url":"https://api.github.com/repos/Netflix/genie/forks","keys_url":"https://api.github.com/repos/Netflix/genie/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Netflix/genie/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Netflix/genie/teams","hooks_url":"https://api.github.com/repos/Netflix/genie/hooks","issue_events_url":"https://api.github.com/repos/Netflix/genie/issues/events{/number}","events_url":"https://api.github.com/repos/Netflix/genie/events","assignees_url":"https://api.github.com/repos/Netflix/genie/assignees{/user}","branches_url":"https://api.github.com/repos/Netflix/genie/branches{/branch}","tags_url":"https://api.github.com/repos/Netflix/genie/tags","blobs_url":"https://api.github.com/repos/Netflix/genie/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Netflix/genie/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Netflix/genie/git/refs{/sha}","trees_url":"https://api.github.com/repos/Netflix/genie/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Netflix/genie/statuses/{sha}","languages_url":"https://api.github.com/repos/Netflix/genie/languages","stargazers_url":"https://api.github.com/repos/Netflix/genie/stargazers","contributors_url":"https://api.github.com/repos/Netflix/genie/contributors","subscribers_url":"https://api.github.com/repos/Netflix/genie/subscribers","subscription_url":"https://api.github.com/repos/Netflix/genie/subscription","commits_url":"https://api.github.com/repos/Netflix/genie/commits{/sha}","git_commits_url":"https://api.github.com/repos/Netflix/genie/git/commits{/sha}","comments_url":"https://api.github.com/repos/Netflix/genie/comments{/number}","issue_comment_url":"https://api.github.com/repos/Netflix/genie/issues/comments/{number}","contents_url":"https://api.github.com/repos/Netflix/genie/contents/{+path}","compare_url":"https://api.github.com/repos/Netflix/genie/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Netflix/genie/merges","archive_url":"https://api.github.com/repos/Netflix/genie/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Netflix/genie/downloads","issues_url":"https://api.github.com/repos/Netflix/genie/issues{/number}","pulls_url":"https://api.github.com/repos/Netflix/genie/pulls{/number}","milestones_url":"https://api.github.com/repos/Netflix/genie/milestones{/number}","notifications_url":"https://api.github.com/repos/Netflix/genie/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Netflix/genie/labels{/name}","releases_url":"https://api.github.com/repos/Netflix/genie/releases{/id}","created_at":"2013-06-20T20:35:56Z","updated_at":"2014-07-09T14:50:47Z","pushed_at":"2014-07-09T23:46:46Z","git_url":"git://github.com/Netflix/genie.git","ssh_url":"git@github.com:Netflix/genie.git","clone_url":"https://github.com/Netflix/genie.git","svn_url":"https://github.com/Netflix/genie","homepage":"","size":7137,"stargazers_count":210,"watchers_count":210,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":69,"mirror_url":null,"open_issues_count":10,"forks":69,"open_issues":10,"watchers":210,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Netflix/genie/pulls/75"},"html":{"href":"https://github.com/Netflix/genie/pull/75"},"issue":{"href":"https://api.github.com/repos/Netflix/genie/issues/75"},"comments":{"href":"https://api.github.com/repos/Netflix/genie/issues/75/comments"},"review_comments":{"href":"https://api.github.com/repos/Netflix/genie/pulls/75/comments"},"review_comment":{"href":"https://api.github.com/repos/Netflix/genie/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Netflix/genie/pulls/75/commits"},"statuses":{"href":"https://api.github.com/repos/Netflix/genie/statuses/0aeab10499d2dd8e915c3708eff6ac821a618b97"}}}}