GitHub PullRequestReviewCommentEvent at 2014-11-28 06:37:07
Repository: meritop
Actor: fengjingchao
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/go-distributed/meritop/pulls/comments/21018138","id":21018138,"diff_hunk":"@@ -237,7 +233,7 @@ func (tc simpleTaskBuilder) GetTask(taskID uint64) Task {\n func drive(t *testing.T, jobName string, etcds []string, config Config, ntask uint64, taskBuilder TaskBuilder) {\n \tbootstrap := NewBootStrap(jobName, etcds, config, createListener(t), nil)\n \tbootstrap.SetTaskBuilder(taskBuilder)\n-\tbootstrap.SetTopology(NewTreeTopology(2, ntask-1))\n+\tbootstrap.SetTopology(NewTreeTopology(2, ntask))","path":"framework_regression_test.go","position":126,"original_position":126,"commit_id":"ad5dd39921eb552e4af76bd3d508e43f713c9f59","original_commit_id":"ad5dd39921eb552e4af76bd3d508e43f713c9f59","user":{"login":"fengjingchao","id":920884,"avatar_url":"https://avatars.githubusercontent.com/u/920884?v=3","gravatar_id":"","url":"https://api.github.com/users/fengjingchao","html_url":"https://github.com/fengjingchao","followers_url":"https://api.github.com/users/fengjingchao/followers","following_url":"https://api.github.com/users/fengjingchao/following{/other_user}","gists_url":"https://api.github.com/users/fengjingchao/gists{/gist_id}","starred_url":"https://api.github.com/users/fengjingchao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fengjingchao/subscriptions","organizations_url":"https://api.github.com/users/fengjingchao/orgs","repos_url":"https://api.github.com/users/fengjingchao/repos","events_url":"https://api.github.com/users/fengjingchao/events{/privacy}","received_events_url":"https://api.github.com/users/fengjingchao/received_events","type":"User","site_admin":false},"body":"Same here. It should be ntask - 1.","created_at":"2014-11-28T06:37:07Z","updated_at":"2014-11-28T06:37:07Z","html_url":"https://github.com/go-distributed/meritop/pull/69#discussion_r21018138","pull_request_url":"https://api.github.com/repos/go-distributed/meritop/pulls/69","_links":{"self":{"href":"https://api.github.com/repos/go-distributed/meritop/pulls/comments/21018138"},"html":{"href":"https://github.com/go-distributed/meritop/pull/69#discussion_r21018138"},"pull_request":{"href":"https://api.github.com/repos/go-distributed/meritop/pulls/69"}}},"pull_request":{"url":"https://api.github.com/repos/go-distributed/meritop/pulls/69","id":25174845,"html_url":"https://github.com/go-distributed/meritop/pull/69","diff_url":"https://github.com/go-distributed/meritop/pull/69.diff","patch_url":"https://github.com/go-distributed/meritop/pull/69.patch","issue_url":"https://api.github.com/repos/go-distributed/meritop/issues/69","number":69,"state":"open","locked":false,"title":"regression test is running, but these is a epoch mismatch fatal","user":{"login":"xiaoyunwu","id":5473617,"avatar_url":"https://avatars.githubusercontent.com/u/5473617?v=3","gravatar_id":"","url":"https://api.github.com/users/xiaoyunwu","html_url":"https://github.com/xiaoyunwu","followers_url":"https://api.github.com/users/xiaoyunwu/followers","following_url":"https://api.github.com/users/xiaoyunwu/following{/other_user}","gists_url":"https://api.github.com/users/xiaoyunwu/gists{/gist_id}","starred_url":"https://api.github.com/users/xiaoyunwu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiaoyunwu/subscriptions","organizations_url":"https://api.github.com/users/xiaoyunwu/orgs","repos_url":"https://api.github.com/users/xiaoyunwu/repos","events_url":"https://api.github.com/users/xiaoyunwu/events{/privacy}","received_events_url":"https://api.github.com/users/xiaoyunwu/received_events","type":"User","site_admin":false},"body":"@hongchao, can you check the why there is epoch mismatch error? the regression test seems to be working with each iteration comes back right value.","created_at":"2014-11-28T02:27:40Z","updated_at":"2014-11-28T06:37:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b24fc77d11f807e62b7793a7e7ba0dc754a6cd7d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/go-distributed/meritop/pulls/69/commits","review_comments_url":"https://api.github.com/repos/go-distributed/meritop/pulls/69/comments","review_comment_url":"https://api.github.com/repos/go-distributed/meritop/pulls/comments/{number}","comments_url":"https://api.github.com/repos/go-distributed/meritop/issues/69/comments","statuses_url":"https://api.github.com/repos/go-distributed/meritop/statuses/ad5dd39921eb552e4af76bd3d508e43f713c9f59","head":{"label":"xiaoyunwu:master","ref":"master","sha":"ad5dd39921eb552e4af76bd3d508e43f713c9f59","user":{"login":"xiaoyunwu","id":5473617,"avatar_url":"https://avatars.githubusercontent.com/u/5473617?v=3","gravatar_id":"","url":"https://api.github.com/users/xiaoyunwu","html_url":"https://github.com/xiaoyunwu","followers_url":"https://api.github.com/users/xiaoyunwu/followers","following_url":"https://api.github.com/users/xiaoyunwu/following{/other_user}","gists_url":"https://api.github.com/users/xiaoyunwu/gists{/gist_id}","starred_url":"https://api.github.com/users/xiaoyunwu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiaoyunwu/subscriptions","organizations_url":"https://api.github.com/users/xiaoyunwu/orgs","repos_url":"https://api.github.com/users/xiaoyunwu/repos","events_url":"https://api.github.com/users/xiaoyunwu/events{/privacy}","received_events_url":"https://api.github.com/users/xiaoyunwu/received_events","type":"User","site_admin":false},"repo":{"id":27245227,"name":"meritop","full_name":"xiaoyunwu/meritop","owner":{"login":"xiaoyunwu","id":5473617,"avatar_url":"https://avatars.githubusercontent.com/u/5473617?v=3","gravatar_id":"","url":"https://api.github.com/users/xiaoyunwu","html_url":"https://github.com/xiaoyunwu","followers_url":"https://api.github.com/users/xiaoyunwu/followers","following_url":"https://api.github.com/users/xiaoyunwu/following{/other_user}","gists_url":"https://api.github.com/users/xiaoyunwu/gists{/gist_id}","starred_url":"https://api.github.com/users/xiaoyunwu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiaoyunwu/subscriptions","organizations_url":"https://api.github.com/users/xiaoyunwu/orgs","repos_url":"https://api.github.com/users/xiaoyunwu/repos","events_url":"https://api.github.com/users/xiaoyunwu/events{/privacy}","received_events_url":"https://api.github.com/users/xiaoyunwu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xiaoyunwu/meritop","description":"","fork":true,"url":"https://api.github.com/repos/xiaoyunwu/meritop","forks_url":"https://api.github.com/repos/xiaoyunwu/meritop/forks","keys_url":"https://api.github.com/repos/xiaoyunwu/meritop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xiaoyunwu/meritop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xiaoyunwu/meritop/teams","hooks_url":"https://api.github.com/repos/xiaoyunwu/meritop/hooks","issue_events_url":"https://api.github.com/repos/xiaoyunwu/meritop/issues/events{/number}","events_url":"https://api.github.com/repos/xiaoyunwu/meritop/events","assignees_url":"https://api.github.com/repos/xiaoyunwu/meritop/assignees{/user}","branches_url":"https://api.github.com/repos/xiaoyunwu/meritop/branches{/branch}","tags_url":"https://api.github.com/repos/xiaoyunwu/meritop/tags","blobs_url":"https://api.github.com/repos/xiaoyunwu/meritop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xiaoyunwu/meritop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xiaoyunwu/meritop/git/refs{/sha}","trees_url":"https://api.github.com/repos/xiaoyunwu/meritop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xiaoyunwu/meritop/statuses/{sha}","languages_url":"https://api.github.com/repos/xiaoyunwu/meritop/languages","stargazers_url":"https://api.github.com/repos/xiaoyunwu/meritop/stargazers","contributors_url":"https://api.github.com/repos/xiaoyunwu/meritop/contributors","subscribers_url":"https://api.github.com/repos/xiaoyunwu/meritop/subscribers","subscription_url":"https://api.github.com/repos/xiaoyunwu/meritop/subscription","commits_url":"https://api.github.com/repos/xiaoyunwu/meritop/commits{/sha}","git_commits_url":"https://api.github.com/repos/xiaoyunwu/meritop/git/commits{/sha}","comments_url":"https://api.github.com/repos/xiaoyunwu/meritop/comments{/number}","issue_comment_url":"https://api.github.com/repos/xiaoyunwu/meritop/issues/comments/{number}","contents_url":"https://api.github.com/repos/xiaoyunwu/meritop/contents/{+path}","compare_url":"https://api.github.com/repos/xiaoyunwu/meritop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xiaoyunwu/meritop/merges","archive_url":"https://api.github.com/repos/xiaoyunwu/meritop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xiaoyunwu/meritop/downloads","issues_url":"https://api.github.com/repos/xiaoyunwu/meritop/issues{/number}","pulls_url":"https://api.github.com/repos/xiaoyunwu/meritop/pulls{/number}","milestones_url":"https://api.github.com/repos/xiaoyunwu/meritop/milestones{/number}","notifications_url":"https://api.github.com/repos/xiaoyunwu/meritop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xiaoyunwu/meritop/labels{/name}","releases_url":"https://api.github.com/repos/xiaoyunwu/meritop/releases{/id}","created_at":"2014-11-27T23:52:27Z","updated_at":"2014-11-28T06:26:47Z","pushed_at":"2014-11-28T06:26:47Z","git_url":"git://github.com/xiaoyunwu/meritop.git","ssh_url":"git@github.com:xiaoyunwu/meritop.git","clone_url":"https://github.com/xiaoyunwu/meritop.git","svn_url":"https://github.com/xiaoyunwu/meritop","homepage":null,"size":1258,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"go-distributed:master","ref":"master","sha":"b88a56deef6f302c097e0f270df0582d12dd335a","user":{"login":"go-distributed","id":6145847,"avatar_url":"https://avatars.githubusercontent.com/u/6145847?v=3","gravatar_id":"","url":"https://api.github.com/users/go-distributed","html_url":"https://github.com/go-distributed","followers_url":"https://api.github.com/users/go-distributed/followers","following_url":"https://api.github.com/users/go-distributed/following{/other_user}","gists_url":"https://api.github.com/users/go-distributed/gists{/gist_id}","starred_url":"https://api.github.com/users/go-distributed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go-distributed/subscriptions","organizations_url":"https://api.github.com/users/go-distributed/orgs","repos_url":"https://api.github.com/users/go-distributed/repos","events_url":"https://api.github.com/users/go-distributed/events{/privacy}","received_events_url":"https://api.github.com/users/go-distributed/received_events","type":"Organization","site_admin":false},"repo":{"id":24970635,"name":"meritop","full_name":"go-distributed/meritop","owner":{"login":"go-distributed","id":6145847,"avatar_url":"https://avatars.githubusercontent.com/u/6145847?v=3","gravatar_id":"","url":"https://api.github.com/users/go-distributed","html_url":"https://github.com/go-distributed","followers_url":"https://api.github.com/users/go-distributed/followers","following_url":"https://api.github.com/users/go-distributed/following{/other_user}","gists_url":"https://api.github.com/users/go-distributed/gists{/gist_id}","starred_url":"https://api.github.com/users/go-distributed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go-distributed/subscriptions","organizations_url":"https://api.github.com/users/go-distributed/orgs","repos_url":"https://api.github.com/users/go-distributed/repos","events_url":"https://api.github.com/users/go-distributed/events{/privacy}","received_events_url":"https://api.github.com/users/go-distributed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/go-distributed/meritop","description":"","fork":false,"url":"https://api.github.com/repos/go-distributed/meritop","forks_url":"https://api.github.com/repos/go-distributed/meritop/forks","keys_url":"https://api.github.com/repos/go-distributed/meritop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/go-distributed/meritop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/go-distributed/meritop/teams","hooks_url":"https://api.github.com/repos/go-distributed/meritop/hooks","issue_events_url":"https://api.github.com/repos/go-distributed/meritop/issues/events{/number}","events_url":"https://api.github.com/repos/go-distributed/meritop/events","assignees_url":"https://api.github.com/repos/go-distributed/meritop/assignees{/user}","branches_url":"https://api.github.com/repos/go-distributed/meritop/branches{/branch}","tags_url":"https://api.github.com/repos/go-distributed/meritop/tags","blobs_url":"https://api.github.com/repos/go-distributed/meritop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/go-distributed/meritop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/go-distributed/meritop/git/refs{/sha}","trees_url":"https://api.github.com/repos/go-distributed/meritop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/go-distributed/meritop/statuses/{sha}","languages_url":"https://api.github.com/repos/go-distributed/meritop/languages","stargazers_url":"https://api.github.com/repos/go-distributed/meritop/stargazers","contributors_url":"https://api.github.com/repos/go-distributed/meritop/contributors","subscribers_url":"https://api.github.com/repos/go-distributed/meritop/subscribers","subscription_url":"https://api.github.com/repos/go-distributed/meritop/subscription","commits_url":"https://api.github.com/repos/go-distributed/meritop/commits{/sha}","git_commits_url":"https://api.github.com/repos/go-distributed/meritop/git/commits{/sha}","comments_url":"https://api.github.com/repos/go-distributed/meritop/comments{/number}","issue_comment_url":"https://api.github.com/repos/go-distributed/meritop/issues/comments/{number}","contents_url":"https://api.github.com/repos/go-distributed/meritop/contents/{+path}","compare_url":"https://api.github.com/repos/go-distributed/meritop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/go-distributed/meritop/merges","archive_url":"https://api.github.com/repos/go-distributed/meritop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/go-distributed/meritop/downloads","issues_url":"https://api.github.com/repos/go-distributed/meritop/issues{/number}","pulls_url":"https://api.github.com/repos/go-distributed/meritop/pulls{/number}","milestones_url":"https://api.github.com/repos/go-distributed/meritop/milestones{/number}","notifications_url":"https://api.github.com/repos/go-distributed/meritop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/go-distributed/meritop/labels{/name}","releases_url":"https://api.github.com/repos/go-distributed/meritop/releases{/id}","created_at":"2014-10-09T02:41:20Z","updated_at":"2014-11-28T02:00:05Z","pushed_at":"2014-11-28T02:00:05Z","git_url":"git://github.com/go-distributed/meritop.git","ssh_url":"git@github.com:go-distributed/meritop.git","clone_url":"https://github.com/go-distributed/meritop.git","svn_url":"https://github.com/go-distributed/meritop","homepage":null,"size":1258,"stargazers_count":4,"watchers_count":4,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":10,"forks":4,"open_issues":10,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/go-distributed/meritop/pulls/69"},"html":{"href":"https://github.com/go-distributed/meritop/pull/69"},"issue":{"href":"https://api.github.com/repos/go-distributed/meritop/issues/69"},"comments":{"href":"https://api.github.com/repos/go-distributed/meritop/issues/69/comments"},"review_comments":{"href":"https://api.github.com/repos/go-distributed/meritop/pulls/69/comments"},"review_comment":{"href":"https://api.github.com/repos/go-distributed/meritop/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/go-distributed/meritop/pulls/69/commits"},"statuses":{"href":"https://api.github.com/repos/go-distributed/meritop/statuses/ad5dd39921eb552e4af76bd3d508e43f713c9f59"}}}}