GitHub PullRequestReviewCommentEvent at 2014-10-29 19:24:33
Repository: docker-builder
Actor: rafecolton
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/rafecolton/docker-builder/pulls/comments/19564952","id":19564952,"diff_hunk":"@@ -25,19 +28,31 @@ func NewDockerClient(logger *logrus.Logger, shouldBeReal bool) (DockerClient, er\n \t\t}, nil\n \t}\n \n-\tvar endpoint string\n+\tendpoint, err := getEndpoint()\n+\tif err != nil {\n+\t\treturn nil, err\n+\t}\n+\ttlsVerify := os.Getenv(\"DOCKER_TLS_VERIFY\") != \"\"\n+\tcertPath := os.Getenv(\"DOCKER_CERT_PATH\")","path":"dclient/dclient.go","position":21,"original_position":21,"commit_id":"522da1d4320ee8669546a3ec73bb4fed623ba244","original_commit_id":"522da1d4320ee8669546a3ec73bb4fed623ba244","user":{"login":"rafecolton","id":1058475,"avatar_url":"https://avatars.githubusercontent.com/u/1058475?v=2","gravatar_id":"","url":"https://api.github.com/users/rafecolton","html_url":"https://github.com/rafecolton","followers_url":"https://api.github.com/users/rafecolton/followers","following_url":"https://api.github.com/users/rafecolton/following{/other_user}","gists_url":"https://api.github.com/users/rafecolton/gists{/gist_id}","starred_url":"https://api.github.com/users/rafecolton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafecolton/subscriptions","organizations_url":"https://api.github.com/users/rafecolton/orgs","repos_url":"https://api.github.com/users/rafecolton/repos","events_url":"https://api.github.com/users/rafecolton/events{/privacy}","received_events_url":"https://api.github.com/users/rafecolton/received_events","type":"User","site_admin":false},"body":"Could you please add some documentation for these env vars?  It would be good to add it both to the server documentation (and corresponding help text) and the README.  The documentation added to the README should probably describe how to get it working with `boot2docker` since I suspect that will be a sticking point for most people (afaik it is the motivation for this PR)","created_at":"2014-10-29T19:24:33Z","updated_at":"2014-10-29T19:24:33Z","html_url":"https://github.com/rafecolton/docker-builder/pull/144#discussion_r19564952","pull_request_url":"https://api.github.com/repos/rafecolton/docker-builder/pulls/144","_links":{"self":{"href":"https://api.github.com/repos/rafecolton/docker-builder/pulls/comments/19564952"},"html":{"href":"https://github.com/rafecolton/docker-builder/pull/144#discussion_r19564952"},"pull_request":{"href":"https://api.github.com/repos/rafecolton/docker-builder/pulls/144"}}},"pull_request":{"url":"https://api.github.com/repos/rafecolton/docker-builder/pulls/144","id":23543708,"html_url":"https://github.com/rafecolton/docker-builder/pull/144","diff_url":"https://github.com/rafecolton/docker-builder/pull/144.diff","patch_url":"https://github.com/rafecolton/docker-builder/pull/144.patch","issue_url":"https://api.github.com/repos/rafecolton/docker-builder/issues/144","number":144,"state":"open","locked":false,"title":"Adding support for TLS DOCKER_HOST","user":{"login":"jszwedko","id":316880,"avatar_url":"https://avatars.githubusercontent.com/u/316880?v=2","gravatar_id":"","url":"https://api.github.com/users/jszwedko","html_url":"https://github.com/jszwedko","followers_url":"https://api.github.com/users/jszwedko/followers","following_url":"https://api.github.com/users/jszwedko/following{/other_user}","gists_url":"https://api.github.com/users/jszwedko/gists{/gist_id}","starred_url":"https://api.github.com/users/jszwedko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jszwedko/subscriptions","organizations_url":"https://api.github.com/users/jszwedko/orgs","repos_url":"https://api.github.com/users/jszwedko/repos","events_url":"https://api.github.com/users/jszwedko/events{/privacy}","received_events_url":"https://api.github.com/users/jszwedko/received_events","type":"User","site_admin":false},"body":"Workarounds courtesy of\r\nhttps://github.com/fsouza/go-dockerclient/issues/173. They can likely be\r\nremoved after better support for TLS docker connections is added to\r\ngo-dockerclient.","created_at":"2014-10-29T16:26:11Z","updated_at":"2014-10-29T19:24:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4bea93859d40cd45f50211e2b0c64e3dca228e3d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rafecolton/docker-builder/pulls/144/commits","review_comments_url":"https://api.github.com/repos/rafecolton/docker-builder/pulls/144/comments","review_comment_url":"https://api.github.com/repos/rafecolton/docker-builder/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rafecolton/docker-builder/issues/144/comments","statuses_url":"https://api.github.com/repos/rafecolton/docker-builder/statuses/522da1d4320ee8669546a3ec73bb4fed623ba244","head":{"label":"jszwedko:add-tls-support","ref":"add-tls-support","sha":"522da1d4320ee8669546a3ec73bb4fed623ba244","user":{"login":"jszwedko","id":316880,"avatar_url":"https://avatars.githubusercontent.com/u/316880?v=2","gravatar_id":"","url":"https://api.github.com/users/jszwedko","html_url":"https://github.com/jszwedko","followers_url":"https://api.github.com/users/jszwedko/followers","following_url":"https://api.github.com/users/jszwedko/following{/other_user}","gists_url":"https://api.github.com/users/jszwedko/gists{/gist_id}","starred_url":"https://api.github.com/users/jszwedko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jszwedko/subscriptions","organizations_url":"https://api.github.com/users/jszwedko/orgs","repos_url":"https://api.github.com/users/jszwedko/repos","events_url":"https://api.github.com/users/jszwedko/events{/privacy}","received_events_url":"https://api.github.com/users/jszwedko/received_events","type":"User","site_admin":false},"repo":{"id":25929939,"name":"docker-builder","full_name":"jszwedko/docker-builder","owner":{"login":"jszwedko","id":316880,"avatar_url":"https://avatars.githubusercontent.com/u/316880?v=2","gravatar_id":"","url":"https://api.github.com/users/jszwedko","html_url":"https://github.com/jszwedko","followers_url":"https://api.github.com/users/jszwedko/followers","following_url":"https://api.github.com/users/jszwedko/following{/other_user}","gists_url":"https://api.github.com/users/jszwedko/gists{/gist_id}","starred_url":"https://api.github.com/users/jszwedko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jszwedko/subscriptions","organizations_url":"https://api.github.com/users/jszwedko/orgs","repos_url":"https://api.github.com/users/jszwedko/repos","events_url":"https://api.github.com/users/jszwedko/events{/privacy}","received_events_url":"https://api.github.com/users/jszwedko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jszwedko/docker-builder","description":"Docker builder (a.k.a. \"Bob\") builds Docker images from a friendly config file.","fork":true,"url":"https://api.github.com/repos/jszwedko/docker-builder","forks_url":"https://api.github.com/repos/jszwedko/docker-builder/forks","keys_url":"https://api.github.com/repos/jszwedko/docker-builder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jszwedko/docker-builder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jszwedko/docker-builder/teams","hooks_url":"https://api.github.com/repos/jszwedko/docker-builder/hooks","issue_events_url":"https://api.github.com/repos/jszwedko/docker-builder/issues/events{/number}","events_url":"https://api.github.com/repos/jszwedko/docker-builder/events","assignees_url":"https://api.github.com/repos/jszwedko/docker-builder/assignees{/user}","branches_url":"https://api.github.com/repos/jszwedko/docker-builder/branches{/branch}","tags_url":"https://api.github.com/repos/jszwedko/docker-builder/tags","blobs_url":"https://api.github.com/repos/jszwedko/docker-builder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jszwedko/docker-builder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jszwedko/docker-builder/git/refs{/sha}","trees_url":"https://api.github.com/repos/jszwedko/docker-builder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jszwedko/docker-builder/statuses/{sha}","languages_url":"https://api.github.com/repos/jszwedko/docker-builder/languages","stargazers_url":"https://api.github.com/repos/jszwedko/docker-builder/stargazers","contributors_url":"https://api.github.com/repos/jszwedko/docker-builder/contributors","subscribers_url":"https://api.github.com/repos/jszwedko/docker-builder/subscribers","subscription_url":"https://api.github.com/repos/jszwedko/docker-builder/subscription","commits_url":"https://api.github.com/repos/jszwedko/docker-builder/commits{/sha}","git_commits_url":"https://api.github.com/repos/jszwedko/docker-builder/git/commits{/sha}","comments_url":"https://api.github.com/repos/jszwedko/docker-builder/comments{/number}","issue_comment_url":"https://api.github.com/repos/jszwedko/docker-builder/issues/comments/{number}","contents_url":"https://api.github.com/repos/jszwedko/docker-builder/contents/{+path}","compare_url":"https://api.github.com/repos/jszwedko/docker-builder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jszwedko/docker-builder/merges","archive_url":"https://api.github.com/repos/jszwedko/docker-builder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jszwedko/docker-builder/downloads","issues_url":"https://api.github.com/repos/jszwedko/docker-builder/issues{/number}","pulls_url":"https://api.github.com/repos/jszwedko/docker-builder/pulls{/number}","milestones_url":"https://api.github.com/repos/jszwedko/docker-builder/milestones{/number}","notifications_url":"https://api.github.com/repos/jszwedko/docker-builder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jszwedko/docker-builder/labels{/name}","releases_url":"https://api.github.com/repos/jszwedko/docker-builder/releases{/id}","created_at":"2014-10-29T16:22:21Z","updated_at":"2014-10-28T21:56:45Z","pushed_at":"2014-10-29T18:04:46Z","git_url":"git://github.com/jszwedko/docker-builder.git","ssh_url":"git@github.com:jszwedko/docker-builder.git","clone_url":"https://github.com/jszwedko/docker-builder.git","svn_url":"https://github.com/jszwedko/docker-builder","homepage":"","size":6071,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rafecolton:master","ref":"master","sha":"2e0c375345422398c7bf1d58c66760e9eb041e36","user":{"login":"rafecolton","id":1058475,"avatar_url":"https://avatars.githubusercontent.com/u/1058475?v=2","gravatar_id":"","url":"https://api.github.com/users/rafecolton","html_url":"https://github.com/rafecolton","followers_url":"https://api.github.com/users/rafecolton/followers","following_url":"https://api.github.com/users/rafecolton/following{/other_user}","gists_url":"https://api.github.com/users/rafecolton/gists{/gist_id}","starred_url":"https://api.github.com/users/rafecolton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafecolton/subscriptions","organizations_url":"https://api.github.com/users/rafecolton/orgs","repos_url":"https://api.github.com/users/rafecolton/repos","events_url":"https://api.github.com/users/rafecolton/events{/privacy}","received_events_url":"https://api.github.com/users/rafecolton/received_events","type":"User","site_admin":false},"repo":{"id":18696489,"name":"docker-builder","full_name":"rafecolton/docker-builder","owner":{"login":"rafecolton","id":1058475,"avatar_url":"https://avatars.githubusercontent.com/u/1058475?v=2","gravatar_id":"","url":"https://api.github.com/users/rafecolton","html_url":"https://github.com/rafecolton","followers_url":"https://api.github.com/users/rafecolton/followers","following_url":"https://api.github.com/users/rafecolton/following{/other_user}","gists_url":"https://api.github.com/users/rafecolton/gists{/gist_id}","starred_url":"https://api.github.com/users/rafecolton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafecolton/subscriptions","organizations_url":"https://api.github.com/users/rafecolton/orgs","repos_url":"https://api.github.com/users/rafecolton/repos","events_url":"https://api.github.com/users/rafecolton/events{/privacy}","received_events_url":"https://api.github.com/users/rafecolton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rafecolton/docker-builder","description":"Docker builder (a.k.a. \"Bob\") builds Docker images from a friendly config file.","fork":false,"url":"https://api.github.com/repos/rafecolton/docker-builder","forks_url":"https://api.github.com/repos/rafecolton/docker-builder/forks","keys_url":"https://api.github.com/repos/rafecolton/docker-builder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rafecolton/docker-builder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rafecolton/docker-builder/teams","hooks_url":"https://api.github.com/repos/rafecolton/docker-builder/hooks","issue_events_url":"https://api.github.com/repos/rafecolton/docker-builder/issues/events{/number}","events_url":"https://api.github.com/repos/rafecolton/docker-builder/events","assignees_url":"https://api.github.com/repos/rafecolton/docker-builder/assignees{/user}","branches_url":"https://api.github.com/repos/rafecolton/docker-builder/branches{/branch}","tags_url":"https://api.github.com/repos/rafecolton/docker-builder/tags","blobs_url":"https://api.github.com/repos/rafecolton/docker-builder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rafecolton/docker-builder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rafecolton/docker-builder/git/refs{/sha}","trees_url":"https://api.github.com/repos/rafecolton/docker-builder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rafecolton/docker-builder/statuses/{sha}","languages_url":"https://api.github.com/repos/rafecolton/docker-builder/languages","stargazers_url":"https://api.github.com/repos/rafecolton/docker-builder/stargazers","contributors_url":"https://api.github.com/repos/rafecolton/docker-builder/contributors","subscribers_url":"https://api.github.com/repos/rafecolton/docker-builder/subscribers","subscription_url":"https://api.github.com/repos/rafecolton/docker-builder/subscription","commits_url":"https://api.github.com/repos/rafecolton/docker-builder/commits{/sha}","git_commits_url":"https://api.github.com/repos/rafecolton/docker-builder/git/commits{/sha}","comments_url":"https://api.github.com/repos/rafecolton/docker-builder/comments{/number}","issue_comment_url":"https://api.github.com/repos/rafecolton/docker-builder/issues/comments/{number}","contents_url":"https://api.github.com/repos/rafecolton/docker-builder/contents/{+path}","compare_url":"https://api.github.com/repos/rafecolton/docker-builder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rafecolton/docker-builder/merges","archive_url":"https://api.github.com/repos/rafecolton/docker-builder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rafecolton/docker-builder/downloads","issues_url":"https://api.github.com/repos/rafecolton/docker-builder/issues{/number}","pulls_url":"https://api.github.com/repos/rafecolton/docker-builder/pulls{/number}","milestones_url":"https://api.github.com/repos/rafecolton/docker-builder/milestones{/number}","notifications_url":"https://api.github.com/repos/rafecolton/docker-builder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rafecolton/docker-builder/labels{/name}","releases_url":"https://api.github.com/repos/rafecolton/docker-builder/releases{/id}","created_at":"2014-04-12T04:45:36Z","updated_at":"2014-10-28T21:56:45Z","pushed_at":"2014-10-29T19:06:35Z","git_url":"git://github.com/rafecolton/docker-builder.git","ssh_url":"git@github.com:rafecolton/docker-builder.git","clone_url":"https://github.com/rafecolton/docker-builder.git","svn_url":"https://github.com/rafecolton/docker-builder","homepage":"","size":6071,"stargazers_count":32,"watchers_count":32,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":29,"forks":8,"open_issues":29,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rafecolton/docker-builder/pulls/144"},"html":{"href":"https://github.com/rafecolton/docker-builder/pull/144"},"issue":{"href":"https://api.github.com/repos/rafecolton/docker-builder/issues/144"},"comments":{"href":"https://api.github.com/repos/rafecolton/docker-builder/issues/144/comments"},"review_comments":{"href":"https://api.github.com/repos/rafecolton/docker-builder/pulls/144/comments"},"review_comment":{"href":"https://api.github.com/repos/rafecolton/docker-builder/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rafecolton/docker-builder/pulls/144/commits"},"statuses":{"href":"https://api.github.com/repos/rafecolton/docker-builder/statuses/522da1d4320ee8669546a3ec73bb4fed623ba244"}}}}