GitHub PullRequestReviewCommentEvent at 2014-10-16 20:17:28
Repository: versal-gadget-launchers
Actor: dmcguinness
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Versal/versal-gadget-launchers/pulls/comments/18983327","id":18983327,"diff_hunk":"@@ -5,7 +5,8 @@ var Semver = function(ver) {\n \n var patch = function(to, from) {\n   Object.keys(from).forEach(function(key){\n-    to[key] = from[key];\n+    var val = from[key] === null ? undefined : from[key];","path":"iframe-launcher/iframe-launcher.js","position":5,"original_position":5,"commit_id":"e69919aa5181e8e6b0e88127a176be9df70ed09e","original_commit_id":"e69919aa5181e8e6b0e88127a176be9df70ed09e","user":{"login":"dmcguinness","id":2213644,"avatar_url":"https://avatars.githubusercontent.com/u/2213644?v=2","gravatar_id":"","url":"https://api.github.com/users/dmcguinness","html_url":"https://github.com/dmcguinness","followers_url":"https://api.github.com/users/dmcguinness/followers","following_url":"https://api.github.com/users/dmcguinness/following{/other_user}","gists_url":"https://api.github.com/users/dmcguinness/gists{/gist_id}","starred_url":"https://api.github.com/users/dmcguinness/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmcguinness/subscriptions","organizations_url":"https://api.github.com/users/dmcguinness/orgs","repos_url":"https://api.github.com/users/dmcguinness/repos","events_url":"https://api.github.com/users/dmcguinness/events{/privacy}","received_events_url":"https://api.github.com/users/dmcguinness/received_events","type":"User","site_admin":false},"body":"@mereskin this does rely on implicit behavior to remove key from object:\r\nI was trying to avoid using `delete to[key] ` and @janpaul123 mentioned that setting to undefined removed the attribute when used in a webComponent.\r\n\r\nIn this case, maybe a `delete` would be more appropriate, if nothing other than to make it more self-explanatory.","created_at":"2014-10-16T20:17:28Z","updated_at":"2014-10-16T20:17:28Z","html_url":"https://github.com/Versal/versal-gadget-launchers/pull/59#discussion_r18983327","pull_request_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/pulls/59","_links":{"self":{"href":"https://api.github.com/repos/Versal/versal-gadget-launchers/pulls/comments/18983327"},"html":{"href":"https://github.com/Versal/versal-gadget-launchers/pull/59#discussion_r18983327"},"pull_request":{"href":"https://api.github.com/repos/Versal/versal-gadget-launchers/pulls/59"}}},"pull_request":{"url":"https://api.github.com/repos/Versal/versal-gadget-launchers/pulls/59","id":22825415,"html_url":"https://github.com/Versal/versal-gadget-launchers/pull/59","diff_url":"https://github.com/Versal/versal-gadget-launchers/pull/59.diff","patch_url":"https://github.com/Versal/versal-gadget-launchers/pull/59.patch","issue_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/issues/59","number":59,"state":"open","locked":false,"title":"Feature/unset attributes when set to null","user":{"login":"dmcguinness","id":2213644,"avatar_url":"https://avatars.githubusercontent.com/u/2213644?v=2","gravatar_id":"","url":"https://api.github.com/users/dmcguinness","html_url":"https://github.com/dmcguinness","followers_url":"https://api.github.com/users/dmcguinness/followers","following_url":"https://api.github.com/users/dmcguinness/following{/other_user}","gists_url":"https://api.github.com/users/dmcguinness/gists{/gist_id}","starred_url":"https://api.github.com/users/dmcguinness/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmcguinness/subscriptions","organizations_url":"https://api.github.com/users/dmcguinness/orgs","repos_url":"https://api.github.com/users/dmcguinness/repos","events_url":"https://api.github.com/users/dmcguinness/events{/privacy}","received_events_url":"https://api.github.com/users/dmcguinness/received_events","type":"User","site_admin":false},"body":"https://versal.atlassian.net/browse/GAD-23\r\nhttps://github.com/Versal/versal-gadget-api/issues/27\r\n\r\nunset `temp` attribute by doing `setAttributes({temp: null})`","created_at":"2014-10-16T00:24:20Z","updated_at":"2014-10-16T20:17:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"593b1e8b6e70967820f1eddb01e7a32f25e6493e","assignee":{"login":"janpaul123","id":177461,"avatar_url":"https://avatars.githubusercontent.com/u/177461?v=2","gravatar_id":"","url":"https://api.github.com/users/janpaul123","html_url":"https://github.com/janpaul123","followers_url":"https://api.github.com/users/janpaul123/followers","following_url":"https://api.github.com/users/janpaul123/following{/other_user}","gists_url":"https://api.github.com/users/janpaul123/gists{/gist_id}","starred_url":"https://api.github.com/users/janpaul123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janpaul123/subscriptions","organizations_url":"https://api.github.com/users/janpaul123/orgs","repos_url":"https://api.github.com/users/janpaul123/repos","events_url":"https://api.github.com/users/janpaul123/events{/privacy}","received_events_url":"https://api.github.com/users/janpaul123/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/pulls/59/commits","review_comments_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/pulls/59/comments","review_comment_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/issues/59/comments","statuses_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/statuses/e69919aa5181e8e6b0e88127a176be9df70ed09e","head":{"label":"Versal:feature/unset-attributes-when-set-to-null","ref":"feature/unset-attributes-when-set-to-null","sha":"e69919aa5181e8e6b0e88127a176be9df70ed09e","user":{"login":"Versal","id":1964245,"avatar_url":"https://avatars.githubusercontent.com/u/1964245?v=2","gravatar_id":"","url":"https://api.github.com/users/Versal","html_url":"https://github.com/Versal","followers_url":"https://api.github.com/users/Versal/followers","following_url":"https://api.github.com/users/Versal/following{/other_user}","gists_url":"https://api.github.com/users/Versal/gists{/gist_id}","starred_url":"https://api.github.com/users/Versal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Versal/subscriptions","organizations_url":"https://api.github.com/users/Versal/orgs","repos_url":"https://api.github.com/users/Versal/repos","events_url":"https://api.github.com/users/Versal/events{/privacy}","received_events_url":"https://api.github.com/users/Versal/received_events","type":"Organization","site_admin":false},"repo":{"id":19143479,"name":"versal-gadget-launchers","full_name":"Versal/versal-gadget-launchers","owner":{"login":"Versal","id":1964245,"avatar_url":"https://avatars.githubusercontent.com/u/1964245?v=2","gravatar_id":"","url":"https://api.github.com/users/Versal","html_url":"https://github.com/Versal","followers_url":"https://api.github.com/users/Versal/followers","following_url":"https://api.github.com/users/Versal/following{/other_user}","gists_url":"https://api.github.com/users/Versal/gists{/gist_id}","starred_url":"https://api.github.com/users/Versal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Versal/subscriptions","organizations_url":"https://api.github.com/users/Versal/orgs","repos_url":"https://api.github.com/users/Versal/repos","events_url":"https://api.github.com/users/Versal/events{/privacy}","received_events_url":"https://api.github.com/users/Versal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Versal/versal-gadget-launchers","description":"Launchers for Versal gadgets","fork":false,"url":"https://api.github.com/repos/Versal/versal-gadget-launchers","forks_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/forks","keys_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/teams","hooks_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/hooks","issue_events_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/issues/events{/number}","events_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/events","assignees_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/assignees{/user}","branches_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/branches{/branch}","tags_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/tags","blobs_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/git/refs{/sha}","trees_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/statuses/{sha}","languages_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/languages","stargazers_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/stargazers","contributors_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/contributors","subscribers_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/subscribers","subscription_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/subscription","commits_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/commits{/sha}","git_commits_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/git/commits{/sha}","comments_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/comments{/number}","issue_comment_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/issues/comments/{number}","contents_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/contents/{+path}","compare_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/merges","archive_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/downloads","issues_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/issues{/number}","pulls_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/pulls{/number}","milestones_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/milestones{/number}","notifications_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/labels{/name}","releases_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/releases{/id}","created_at":"2014-04-25T11:13:38Z","updated_at":"2014-09-03T00:37:40Z","pushed_at":"2014-10-16T17:45:44Z","git_url":"git://github.com/Versal/versal-gadget-launchers.git","ssh_url":"git@github.com:Versal/versal-gadget-launchers.git","clone_url":"https://github.com/Versal/versal-gadget-launchers.git","svn_url":"https://github.com/Versal/versal-gadget-launchers","homepage":"","size":2224,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":9,"forks":0,"open_issues":9,"watchers":1,"default_branch":"master"}},"base":{"label":"Versal:master","ref":"master","sha":"3e350639e850d6625c989f55e605902b5194b2b6","user":{"login":"Versal","id":1964245,"avatar_url":"https://avatars.githubusercontent.com/u/1964245?v=2","gravatar_id":"","url":"https://api.github.com/users/Versal","html_url":"https://github.com/Versal","followers_url":"https://api.github.com/users/Versal/followers","following_url":"https://api.github.com/users/Versal/following{/other_user}","gists_url":"https://api.github.com/users/Versal/gists{/gist_id}","starred_url":"https://api.github.com/users/Versal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Versal/subscriptions","organizations_url":"https://api.github.com/users/Versal/orgs","repos_url":"https://api.github.com/users/Versal/repos","events_url":"https://api.github.com/users/Versal/events{/privacy}","received_events_url":"https://api.github.com/users/Versal/received_events","type":"Organization","site_admin":false},"repo":{"id":19143479,"name":"versal-gadget-launchers","full_name":"Versal/versal-gadget-launchers","owner":{"login":"Versal","id":1964245,"avatar_url":"https://avatars.githubusercontent.com/u/1964245?v=2","gravatar_id":"","url":"https://api.github.com/users/Versal","html_url":"https://github.com/Versal","followers_url":"https://api.github.com/users/Versal/followers","following_url":"https://api.github.com/users/Versal/following{/other_user}","gists_url":"https://api.github.com/users/Versal/gists{/gist_id}","starred_url":"https://api.github.com/users/Versal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Versal/subscriptions","organizations_url":"https://api.github.com/users/Versal/orgs","repos_url":"https://api.github.com/users/Versal/repos","events_url":"https://api.github.com/users/Versal/events{/privacy}","received_events_url":"https://api.github.com/users/Versal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Versal/versal-gadget-launchers","description":"Launchers for Versal gadgets","fork":false,"url":"https://api.github.com/repos/Versal/versal-gadget-launchers","forks_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/forks","keys_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/teams","hooks_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/hooks","issue_events_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/issues/events{/number}","events_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/events","assignees_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/assignees{/user}","branches_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/branches{/branch}","tags_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/tags","blobs_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/git/refs{/sha}","trees_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/statuses/{sha}","languages_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/languages","stargazers_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/stargazers","contributors_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/contributors","subscribers_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/subscribers","subscription_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/subscription","commits_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/commits{/sha}","git_commits_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/git/commits{/sha}","comments_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/comments{/number}","issue_comment_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/issues/comments/{number}","contents_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/contents/{+path}","compare_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/merges","archive_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/downloads","issues_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/issues{/number}","pulls_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/pulls{/number}","milestones_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/milestones{/number}","notifications_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/labels{/name}","releases_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/releases{/id}","created_at":"2014-04-25T11:13:38Z","updated_at":"2014-09-03T00:37:40Z","pushed_at":"2014-10-16T17:45:44Z","git_url":"git://github.com/Versal/versal-gadget-launchers.git","ssh_url":"git@github.com:Versal/versal-gadget-launchers.git","clone_url":"https://github.com/Versal/versal-gadget-launchers.git","svn_url":"https://github.com/Versal/versal-gadget-launchers","homepage":"","size":2224,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":9,"forks":0,"open_issues":9,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Versal/versal-gadget-launchers/pulls/59"},"html":{"href":"https://github.com/Versal/versal-gadget-launchers/pull/59"},"issue":{"href":"https://api.github.com/repos/Versal/versal-gadget-launchers/issues/59"},"comments":{"href":"https://api.github.com/repos/Versal/versal-gadget-launchers/issues/59/comments"},"review_comments":{"href":"https://api.github.com/repos/Versal/versal-gadget-launchers/pulls/59/comments"},"review_comment":{"href":"https://api.github.com/repos/Versal/versal-gadget-launchers/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Versal/versal-gadget-launchers/pulls/59/commits"},"statuses":{"href":"https://api.github.com/repos/Versal/versal-gadget-launchers/statuses/e69919aa5181e8e6b0e88127a176be9df70ed09e"}}}}