GitHub PullRequestReviewCommentEvent at 2014-12-01 19:02:43
Repository: Payara
Actor: jerrinot
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/payara/Payara/pulls/comments/21110982","id":21110982,"diff_hunk":"@@ -77,11 +76,41 @@\n import java.util.logging.Logger;\n import java.util.regex.Pattern;\n \n+import javax.inject.Inject;\n+\n+import org.jvnet.hk2.config.ConfigBean;\n+\n \n-public class FileUtils {\n+\n+public class FileUtils  {\n     final static Logger _utillogger = CULoggerInfo.getLogger();\n     private final static LocalStringsImpl messages = new LocalStringsImpl(FileUtils.class);\n \n+\n+    public static void setFileProperties()\n+    {\n+    \tif(System.getProperty(\"com.sun.appserv.winFileLockRetryLimit\")!=null || System.getProperty(\"com.sun.appserv.winFileLockRetryLimit\")!=\"\" )","path":"nucleus/common/common-util/src/main/java/com/sun/enterprise/util/io/FileUtils.java","position":26,"original_position":26,"commit_id":"65eae50f728066283249b048723e0bcd4df6bac3","original_commit_id":"65eae50f728066283249b048723e0bcd4df6bac3","user":{"login":"jerrinot","id":158619,"avatar_url":"https://avatars.githubusercontent.com/u/158619?v=3","gravatar_id":"","url":"https://api.github.com/users/jerrinot","html_url":"https://github.com/jerrinot","followers_url":"https://api.github.com/users/jerrinot/followers","following_url":"https://api.github.com/users/jerrinot/following{/other_user}","gists_url":"https://api.github.com/users/jerrinot/gists{/gist_id}","starred_url":"https://api.github.com/users/jerrinot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerrinot/subscriptions","organizations_url":"https://api.github.com/users/jerrinot/orgs","repos_url":"https://api.github.com/users/jerrinot/repos","events_url":"https://api.github.com/users/jerrinot/events{/privacy}","received_events_url":"https://api.github.com/users/jerrinot/received_events","type":"User","site_admin":false},"body":"that's a very strange condition. perhaps it should be && instead of || ?","created_at":"2014-12-01T19:02:43Z","updated_at":"2014-12-01T19:02:43Z","html_url":"https://github.com/payara/Payara/pull/92#discussion_r21110982","pull_request_url":"https://api.github.com/repos/payara/Payara/pulls/92","_links":{"self":{"href":"https://api.github.com/repos/payara/Payara/pulls/comments/21110982"},"html":{"href":"https://github.com/payara/Payara/pull/92#discussion_r21110982"},"pull_request":{"href":"https://api.github.com/repos/payara/Payara/pulls/92"}}},"pull_request":{"url":"https://api.github.com/repos/payara/Payara/pulls/92","id":25289949,"html_url":"https://github.com/payara/Payara/pull/92","diff_url":"https://github.com/payara/Payara/pull/92.diff","patch_url":"https://github.com/payara/Payara/pull/92.patch","issue_url":"https://api.github.com/repos/payara/Payara/issues/92","number":92,"state":"closed","locked":false,"title":"GLASSFISH-21261","user":{"login":"davewinters","id":1631103,"avatar_url":"https://avatars.githubusercontent.com/u/1631103?v=3","gravatar_id":"","url":"https://api.github.com/users/davewinters","html_url":"https://github.com/davewinters","followers_url":"https://api.github.com/users/davewinters/followers","following_url":"https://api.github.com/users/davewinters/following{/other_user}","gists_url":"https://api.github.com/users/davewinters/gists{/gist_id}","starred_url":"https://api.github.com/users/davewinters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davewinters/subscriptions","organizations_url":"https://api.github.com/users/davewinters/orgs","repos_url":"https://api.github.com/users/davewinters/repos","events_url":"https://api.github.com/users/davewinters/events{/privacy}","received_events_url":"https://api.github.com/users/davewinters/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-12-01T18:53:15Z","updated_at":"2014-12-01T19:02:43Z","closed_at":"2014-12-01T18:53:23Z","merged_at":"2014-12-01T18:53:23Z","merge_commit_sha":"49a042e9ccdfef7ddcd3efd4bcda5843a0f857f2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/payara/Payara/pulls/92/commits","review_comments_url":"https://api.github.com/repos/payara/Payara/pulls/92/comments","review_comment_url":"https://api.github.com/repos/payara/Payara/pulls/comments/{number}","comments_url":"https://api.github.com/repos/payara/Payara/issues/92/comments","statuses_url":"https://api.github.com/repos/payara/Payara/statuses/65eae50f728066283249b048723e0bcd4df6bac3","head":{"label":"davewinters:master","ref":"master","sha":"65eae50f728066283249b048723e0bcd4df6bac3","user":{"login":"davewinters","id":1631103,"avatar_url":"https://avatars.githubusercontent.com/u/1631103?v=3","gravatar_id":"","url":"https://api.github.com/users/davewinters","html_url":"https://github.com/davewinters","followers_url":"https://api.github.com/users/davewinters/followers","following_url":"https://api.github.com/users/davewinters/following{/other_user}","gists_url":"https://api.github.com/users/davewinters/gists{/gist_id}","starred_url":"https://api.github.com/users/davewinters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davewinters/subscriptions","organizations_url":"https://api.github.com/users/davewinters/orgs","repos_url":"https://api.github.com/users/davewinters/repos","events_url":"https://api.github.com/users/davewinters/events{/privacy}","received_events_url":"https://api.github.com/users/davewinters/received_events","type":"User","site_admin":false},"repo":{"id":27345968,"name":"Payara","full_name":"davewinters/Payara","owner":{"login":"davewinters","id":1631103,"avatar_url":"https://avatars.githubusercontent.com/u/1631103?v=3","gravatar_id":"","url":"https://api.github.com/users/davewinters","html_url":"https://github.com/davewinters","followers_url":"https://api.github.com/users/davewinters/followers","following_url":"https://api.github.com/users/davewinters/following{/other_user}","gists_url":"https://api.github.com/users/davewinters/gists{/gist_id}","starred_url":"https://api.github.com/users/davewinters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davewinters/subscriptions","organizations_url":"https://api.github.com/users/davewinters/orgs","repos_url":"https://api.github.com/users/davewinters/repos","events_url":"https://api.github.com/users/davewinters/events{/privacy}","received_events_url":"https://api.github.com/users/davewinters/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davewinters/Payara","description":"Payara Server support for GlassFish Server Open Source Edition","fork":true,"url":"https://api.github.com/repos/davewinters/Payara","forks_url":"https://api.github.com/repos/davewinters/Payara/forks","keys_url":"https://api.github.com/repos/davewinters/Payara/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davewinters/Payara/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davewinters/Payara/teams","hooks_url":"https://api.github.com/repos/davewinters/Payara/hooks","issue_events_url":"https://api.github.com/repos/davewinters/Payara/issues/events{/number}","events_url":"https://api.github.com/repos/davewinters/Payara/events","assignees_url":"https://api.github.com/repos/davewinters/Payara/assignees{/user}","branches_url":"https://api.github.com/repos/davewinters/Payara/branches{/branch}","tags_url":"https://api.github.com/repos/davewinters/Payara/tags","blobs_url":"https://api.github.com/repos/davewinters/Payara/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davewinters/Payara/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davewinters/Payara/git/refs{/sha}","trees_url":"https://api.github.com/repos/davewinters/Payara/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davewinters/Payara/statuses/{sha}","languages_url":"https://api.github.com/repos/davewinters/Payara/languages","stargazers_url":"https://api.github.com/repos/davewinters/Payara/stargazers","contributors_url":"https://api.github.com/repos/davewinters/Payara/contributors","subscribers_url":"https://api.github.com/repos/davewinters/Payara/subscribers","subscription_url":"https://api.github.com/repos/davewinters/Payara/subscription","commits_url":"https://api.github.com/repos/davewinters/Payara/commits{/sha}","git_commits_url":"https://api.github.com/repos/davewinters/Payara/git/commits{/sha}","comments_url":"https://api.github.com/repos/davewinters/Payara/comments{/number}","issue_comment_url":"https://api.github.com/repos/davewinters/Payara/issues/comments/{number}","contents_url":"https://api.github.com/repos/davewinters/Payara/contents/{+path}","compare_url":"https://api.github.com/repos/davewinters/Payara/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davewinters/Payara/merges","archive_url":"https://api.github.com/repos/davewinters/Payara/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davewinters/Payara/downloads","issues_url":"https://api.github.com/repos/davewinters/Payara/issues{/number}","pulls_url":"https://api.github.com/repos/davewinters/Payara/pulls{/number}","milestones_url":"https://api.github.com/repos/davewinters/Payara/milestones{/number}","notifications_url":"https://api.github.com/repos/davewinters/Payara/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davewinters/Payara/labels{/name}","releases_url":"https://api.github.com/repos/davewinters/Payara/releases{/id}","created_at":"2014-11-30T18:43:17Z","updated_at":"2014-12-01T18:52:28Z","pushed_at":"2014-12-01T18:52:27Z","git_url":"git://github.com/davewinters/Payara.git","ssh_url":"git@github.com:davewinters/Payara.git","clone_url":"https://github.com/davewinters/Payara.git","svn_url":"https://github.com/davewinters/Payara","homepage":"http://www.payara.co","size":53799,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"payara:master","ref":"master","sha":"4b0951d503e416813cc4fba82edd2d60e8a77a53","user":{"login":"payara","id":7817189,"avatar_url":"https://avatars.githubusercontent.com/u/7817189?v=3","gravatar_id":"","url":"https://api.github.com/users/payara","html_url":"https://github.com/payara","followers_url":"https://api.github.com/users/payara/followers","following_url":"https://api.github.com/users/payara/following{/other_user}","gists_url":"https://api.github.com/users/payara/gists{/gist_id}","starred_url":"https://api.github.com/users/payara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/payara/subscriptions","organizations_url":"https://api.github.com/users/payara/orgs","repos_url":"https://api.github.com/users/payara/repos","events_url":"https://api.github.com/users/payara/events{/privacy}","received_events_url":"https://api.github.com/users/payara/received_events","type":"Organization","site_admin":false},"repo":{"id":23930639,"name":"Payara","full_name":"payara/Payara","owner":{"login":"payara","id":7817189,"avatar_url":"https://avatars.githubusercontent.com/u/7817189?v=3","gravatar_id":"","url":"https://api.github.com/users/payara","html_url":"https://github.com/payara","followers_url":"https://api.github.com/users/payara/followers","following_url":"https://api.github.com/users/payara/following{/other_user}","gists_url":"https://api.github.com/users/payara/gists{/gist_id}","starred_url":"https://api.github.com/users/payara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/payara/subscriptions","organizations_url":"https://api.github.com/users/payara/orgs","repos_url":"https://api.github.com/users/payara/repos","events_url":"https://api.github.com/users/payara/events{/privacy}","received_events_url":"https://api.github.com/users/payara/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/payara/Payara","description":"Payara Server support for GlassFish Server Open Source Edition","fork":false,"url":"https://api.github.com/repos/payara/Payara","forks_url":"https://api.github.com/repos/payara/Payara/forks","keys_url":"https://api.github.com/repos/payara/Payara/keys{/key_id}","collaborators_url":"https://api.github.com/repos/payara/Payara/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/payara/Payara/teams","hooks_url":"https://api.github.com/repos/payara/Payara/hooks","issue_events_url":"https://api.github.com/repos/payara/Payara/issues/events{/number}","events_url":"https://api.github.com/repos/payara/Payara/events","assignees_url":"https://api.github.com/repos/payara/Payara/assignees{/user}","branches_url":"https://api.github.com/repos/payara/Payara/branches{/branch}","tags_url":"https://api.github.com/repos/payara/Payara/tags","blobs_url":"https://api.github.com/repos/payara/Payara/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/payara/Payara/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/payara/Payara/git/refs{/sha}","trees_url":"https://api.github.com/repos/payara/Payara/git/trees{/sha}","statuses_url":"https://api.github.com/repos/payara/Payara/statuses/{sha}","languages_url":"https://api.github.com/repos/payara/Payara/languages","stargazers_url":"https://api.github.com/repos/payara/Payara/stargazers","contributors_url":"https://api.github.com/repos/payara/Payara/contributors","subscribers_url":"https://api.github.com/repos/payara/Payara/subscribers","subscription_url":"https://api.github.com/repos/payara/Payara/subscription","commits_url":"https://api.github.com/repos/payara/Payara/commits{/sha}","git_commits_url":"https://api.github.com/repos/payara/Payara/git/commits{/sha}","comments_url":"https://api.github.com/repos/payara/Payara/comments{/number}","issue_comment_url":"https://api.github.com/repos/payara/Payara/issues/comments/{number}","contents_url":"https://api.github.com/repos/payara/Payara/contents/{+path}","compare_url":"https://api.github.com/repos/payara/Payara/compare/{base}...{head}","merges_url":"https://api.github.com/repos/payara/Payara/merges","archive_url":"https://api.github.com/repos/payara/Payara/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/payara/Payara/downloads","issues_url":"https://api.github.com/repos/payara/Payara/issues{/number}","pulls_url":"https://api.github.com/repos/payara/Payara/pulls{/number}","milestones_url":"https://api.github.com/repos/payara/Payara/milestones{/number}","notifications_url":"https://api.github.com/repos/payara/Payara/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/payara/Payara/labels{/name}","releases_url":"https://api.github.com/repos/payara/Payara/releases{/id}","created_at":"2014-09-11T18:32:40Z","updated_at":"2014-12-01T18:53:24Z","pushed_at":"2014-12-01T18:53:24Z","git_url":"git://github.com/payara/Payara.git","ssh_url":"git@github.com:payara/Payara.git","clone_url":"https://github.com/payara/Payara.git","svn_url":"https://github.com/payara/Payara","homepage":"http://www.payara.co","size":53799,"stargazers_count":14,"watchers_count":14,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":21,"forks":10,"open_issues":21,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/payara/Payara/pulls/92"},"html":{"href":"https://github.com/payara/Payara/pull/92"},"issue":{"href":"https://api.github.com/repos/payara/Payara/issues/92"},"comments":{"href":"https://api.github.com/repos/payara/Payara/issues/92/comments"},"review_comments":{"href":"https://api.github.com/repos/payara/Payara/pulls/92/comments"},"review_comment":{"href":"https://api.github.com/repos/payara/Payara/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/payara/Payara/pulls/92/commits"},"statuses":{"href":"https://api.github.com/repos/payara/Payara/statuses/65eae50f728066283249b048723e0bcd4df6bac3"}}}}