GitHub PullRequestReviewCommentEvent at 2014-11-13 03:10:23
Repository: hyper
Actor: reem
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/hyperium/hyper/pulls/comments/20270315","id":20270315,"diff_hunk":"@@ -18,17 +18,14 @@ macro_rules! try_continue(\n     ($e:expr) => {{\n         match $e {\n             Ok(v) => v,\n-            Err(..) => continue\n+            Err(..) => return","path":"benches/client.rs","position":14,"original_position":14,"commit_id":"5c78a28d34a0ef352cfb40f1d037827684b4a610","original_commit_id":"5c78a28d34a0ef352cfb40f1d037827684b4a610","user":{"login":"reem","id":4745181,"avatar_url":"https://avatars.githubusercontent.com/u/4745181?v=3","gravatar_id":"","url":"https://api.github.com/users/reem","html_url":"https://github.com/reem","followers_url":"https://api.github.com/users/reem/followers","following_url":"https://api.github.com/users/reem/following{/other_user}","gists_url":"https://api.github.com/users/reem/gists{/gist_id}","starred_url":"https://api.github.com/users/reem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reem/subscriptions","organizations_url":"https://api.github.com/users/reem/orgs","repos_url":"https://api.github.com/users/reem/repos","events_url":"https://api.github.com/users/reem/events{/privacy}","received_events_url":"https://api.github.com/users/reem/received_events","type":"User","site_admin":false},"body":"This macro should be renamed, since it no longer does `continue`.","created_at":"2014-11-13T03:10:23Z","updated_at":"2014-11-13T03:10:23Z","html_url":"https://github.com/hyperium/hyper/pull/116#discussion_r20270315","pull_request_url":"https://api.github.com/repos/hyperium/hyper/pulls/116","_links":{"self":{"href":"https://api.github.com/repos/hyperium/hyper/pulls/comments/20270315"},"html":{"href":"https://github.com/hyperium/hyper/pull/116#discussion_r20270315"},"pull_request":{"href":"https://api.github.com/repos/hyperium/hyper/pulls/116"}}},"pull_request":{"url":"https://api.github.com/repos/hyperium/hyper/pulls/116","id":24333958,"html_url":"https://github.com/hyperium/hyper/pull/116","diff_url":"https://github.com/hyperium/hyper/pull/116.diff","patch_url":"https://github.com/hyperium/hyper/pull/116.patch","issue_url":"https://api.github.com/repos/hyperium/hyper/issues/116","number":116,"state":"open","locked":false,"title":"feat(server): keep-alive! [WIP]","user":{"login":"seanmonstar","id":51479,"avatar_url":"https://avatars.githubusercontent.com/u/51479?v=3","gravatar_id":"","url":"https://api.github.com/users/seanmonstar","html_url":"https://github.com/seanmonstar","followers_url":"https://api.github.com/users/seanmonstar/followers","following_url":"https://api.github.com/users/seanmonstar/following{/other_user}","gists_url":"https://api.github.com/users/seanmonstar/gists{/gist_id}","starred_url":"https://api.github.com/users/seanmonstar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanmonstar/subscriptions","organizations_url":"https://api.github.com/users/seanmonstar/orgs","repos_url":"https://api.github.com/users/seanmonstar/repos","events_url":"https://api.github.com/users/seanmonstar/events{/privacy}","received_events_url":"https://api.github.com/users/seanmonstar/received_events","type":"User","site_admin":false},"body":"Internals have been shuffled around such that Request and Reponse are\r\nnow given only a mutable reference to the stream, instead of being\r\nallowed to consume it. This allows the server to re-use the streams if\r\nkeep-alive is true.\r\n\r\nA task pool is used, and the number of the threads can currently be\r\nadjusted by a method on the Handler trait.\r\n\r\nBREAKING CHANGE\r\n\r\n@reem I see a big jump in reqs/sec with this. On my machine, around 55k. I can't get Iron to compile today (cargo bug) to compare, but it may be faster on your machine.","created_at":"2014-11-12T23:21:05Z","updated_at":"2014-11-13T03:10:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"501939f25748b81652685f21a3d0f142a3a0447f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hyperium/hyper/pulls/116/commits","review_comments_url":"https://api.github.com/repos/hyperium/hyper/pulls/116/comments","review_comment_url":"https://api.github.com/repos/hyperium/hyper/pulls/comments/{number}","comments_url":"https://api.github.com/repos/hyperium/hyper/issues/116/comments","statuses_url":"https://api.github.com/repos/hyperium/hyper/statuses/5c78a28d34a0ef352cfb40f1d037827684b4a610","head":{"label":"hyperium:server-keep-alive","ref":"server-keep-alive","sha":"5c78a28d34a0ef352cfb40f1d037827684b4a610","user":{"login":"hyperium","id":8730506,"avatar_url":"https://avatars.githubusercontent.com/u/8730506?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperium","html_url":"https://github.com/hyperium","followers_url":"https://api.github.com/users/hyperium/followers","following_url":"https://api.github.com/users/hyperium/following{/other_user}","gists_url":"https://api.github.com/users/hyperium/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperium/subscriptions","organizations_url":"https://api.github.com/users/hyperium/orgs","repos_url":"https://api.github.com/users/hyperium/repos","events_url":"https://api.github.com/users/hyperium/events{/privacy}","received_events_url":"https://api.github.com/users/hyperium/received_events","type":"Organization","site_admin":false},"repo":{"id":23500865,"name":"hyper","full_name":"hyperium/hyper","owner":{"login":"hyperium","id":8730506,"avatar_url":"https://avatars.githubusercontent.com/u/8730506?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperium","html_url":"https://github.com/hyperium","followers_url":"https://api.github.com/users/hyperium/followers","following_url":"https://api.github.com/users/hyperium/following{/other_user}","gists_url":"https://api.github.com/users/hyperium/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperium/subscriptions","organizations_url":"https://api.github.com/users/hyperium/orgs","repos_url":"https://api.github.com/users/hyperium/repos","events_url":"https://api.github.com/users/hyperium/events{/privacy}","received_events_url":"https://api.github.com/users/hyperium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperium/hyper","description":"An HTTP library for Rust","fork":false,"url":"https://api.github.com/repos/hyperium/hyper","forks_url":"https://api.github.com/repos/hyperium/hyper/forks","keys_url":"https://api.github.com/repos/hyperium/hyper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperium/hyper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperium/hyper/teams","hooks_url":"https://api.github.com/repos/hyperium/hyper/hooks","issue_events_url":"https://api.github.com/repos/hyperium/hyper/issues/events{/number}","events_url":"https://api.github.com/repos/hyperium/hyper/events","assignees_url":"https://api.github.com/repos/hyperium/hyper/assignees{/user}","branches_url":"https://api.github.com/repos/hyperium/hyper/branches{/branch}","tags_url":"https://api.github.com/repos/hyperium/hyper/tags","blobs_url":"https://api.github.com/repos/hyperium/hyper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperium/hyper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperium/hyper/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperium/hyper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperium/hyper/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperium/hyper/languages","stargazers_url":"https://api.github.com/repos/hyperium/hyper/stargazers","contributors_url":"https://api.github.com/repos/hyperium/hyper/contributors","subscribers_url":"https://api.github.com/repos/hyperium/hyper/subscribers","subscription_url":"https://api.github.com/repos/hyperium/hyper/subscription","commits_url":"https://api.github.com/repos/hyperium/hyper/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperium/hyper/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperium/hyper/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperium/hyper/issues/comments/{number}","contents_url":"https://api.github.com/repos/hyperium/hyper/contents/{+path}","compare_url":"https://api.github.com/repos/hyperium/hyper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperium/hyper/merges","archive_url":"https://api.github.com/repos/hyperium/hyper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperium/hyper/downloads","issues_url":"https://api.github.com/repos/hyperium/hyper/issues{/number}","pulls_url":"https://api.github.com/repos/hyperium/hyper/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperium/hyper/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperium/hyper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperium/hyper/labels{/name}","releases_url":"https://api.github.com/repos/hyperium/hyper/releases{/id}","created_at":"2014-08-30T21:14:33Z","updated_at":"2014-11-12T14:15:02Z","pushed_at":"2014-11-12T23:19:39Z","git_url":"git://github.com/hyperium/hyper.git","ssh_url":"git@github.com:hyperium/hyper.git","clone_url":"https://github.com/hyperium/hyper.git","svn_url":"https://github.com/hyperium/hyper","homepage":"http://hyperium.github.io/hyper","size":4363,"stargazers_count":139,"watchers_count":139,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":14,"mirror_url":null,"open_issues_count":18,"forks":14,"open_issues":18,"watchers":139,"default_branch":"master"}},"base":{"label":"hyperium:master","ref":"master","sha":"374da358ef7a8df4506c00df6852e99013395d38","user":{"login":"hyperium","id":8730506,"avatar_url":"https://avatars.githubusercontent.com/u/8730506?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperium","html_url":"https://github.com/hyperium","followers_url":"https://api.github.com/users/hyperium/followers","following_url":"https://api.github.com/users/hyperium/following{/other_user}","gists_url":"https://api.github.com/users/hyperium/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperium/subscriptions","organizations_url":"https://api.github.com/users/hyperium/orgs","repos_url":"https://api.github.com/users/hyperium/repos","events_url":"https://api.github.com/users/hyperium/events{/privacy}","received_events_url":"https://api.github.com/users/hyperium/received_events","type":"Organization","site_admin":false},"repo":{"id":23500865,"name":"hyper","full_name":"hyperium/hyper","owner":{"login":"hyperium","id":8730506,"avatar_url":"https://avatars.githubusercontent.com/u/8730506?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperium","html_url":"https://github.com/hyperium","followers_url":"https://api.github.com/users/hyperium/followers","following_url":"https://api.github.com/users/hyperium/following{/other_user}","gists_url":"https://api.github.com/users/hyperium/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperium/subscriptions","organizations_url":"https://api.github.com/users/hyperium/orgs","repos_url":"https://api.github.com/users/hyperium/repos","events_url":"https://api.github.com/users/hyperium/events{/privacy}","received_events_url":"https://api.github.com/users/hyperium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperium/hyper","description":"An HTTP library for Rust","fork":false,"url":"https://api.github.com/repos/hyperium/hyper","forks_url":"https://api.github.com/repos/hyperium/hyper/forks","keys_url":"https://api.github.com/repos/hyperium/hyper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperium/hyper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperium/hyper/teams","hooks_url":"https://api.github.com/repos/hyperium/hyper/hooks","issue_events_url":"https://api.github.com/repos/hyperium/hyper/issues/events{/number}","events_url":"https://api.github.com/repos/hyperium/hyper/events","assignees_url":"https://api.github.com/repos/hyperium/hyper/assignees{/user}","branches_url":"https://api.github.com/repos/hyperium/hyper/branches{/branch}","tags_url":"https://api.github.com/repos/hyperium/hyper/tags","blobs_url":"https://api.github.com/repos/hyperium/hyper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperium/hyper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperium/hyper/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperium/hyper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperium/hyper/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperium/hyper/languages","stargazers_url":"https://api.github.com/repos/hyperium/hyper/stargazers","contributors_url":"https://api.github.com/repos/hyperium/hyper/contributors","subscribers_url":"https://api.github.com/repos/hyperium/hyper/subscribers","subscription_url":"https://api.github.com/repos/hyperium/hyper/subscription","commits_url":"https://api.github.com/repos/hyperium/hyper/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperium/hyper/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperium/hyper/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperium/hyper/issues/comments/{number}","contents_url":"https://api.github.com/repos/hyperium/hyper/contents/{+path}","compare_url":"https://api.github.com/repos/hyperium/hyper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperium/hyper/merges","archive_url":"https://api.github.com/repos/hyperium/hyper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperium/hyper/downloads","issues_url":"https://api.github.com/repos/hyperium/hyper/issues{/number}","pulls_url":"https://api.github.com/repos/hyperium/hyper/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperium/hyper/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperium/hyper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperium/hyper/labels{/name}","releases_url":"https://api.github.com/repos/hyperium/hyper/releases{/id}","created_at":"2014-08-30T21:14:33Z","updated_at":"2014-11-12T14:15:02Z","pushed_at":"2014-11-12T23:19:39Z","git_url":"git://github.com/hyperium/hyper.git","ssh_url":"git@github.com:hyperium/hyper.git","clone_url":"https://github.com/hyperium/hyper.git","svn_url":"https://github.com/hyperium/hyper","homepage":"http://hyperium.github.io/hyper","size":4363,"stargazers_count":139,"watchers_count":139,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":14,"mirror_url":null,"open_issues_count":18,"forks":14,"open_issues":18,"watchers":139,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hyperium/hyper/pulls/116"},"html":{"href":"https://github.com/hyperium/hyper/pull/116"},"issue":{"href":"https://api.github.com/repos/hyperium/hyper/issues/116"},"comments":{"href":"https://api.github.com/repos/hyperium/hyper/issues/116/comments"},"review_comments":{"href":"https://api.github.com/repos/hyperium/hyper/pulls/116/comments"},"review_comment":{"href":"https://api.github.com/repos/hyperium/hyper/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/hyperium/hyper/pulls/116/commits"},"statuses":{"href":"https://api.github.com/repos/hyperium/hyper/statuses/5c78a28d34a0ef352cfb40f1d037827684b4a610"}}}}