GitHub PullRequestReviewCommentEvent at 2014-08-11 08:15:59
Repository: geometry
Actor: barendgehrels
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/boostorg/geometry/pulls/comments/16041611","id":16041611,"diff_hunk":"@@ -107,46 +79,58 @@ namespace dispatch\n template\n <\n     typename Geometry,\n-    typename Tag = typename tag_cast<typename tag<Geometry>::type, multi_tag>::type\n+    typename Tag = typename tag_cast\n+        <\n+            typename tag<Geometry>::type, multi_tag\n+        >::type\n >\n struct num_points: not_implemented<Tag>\n {};\n \n template <typename Geometry>\n struct num_points<Geometry, point_tag>\n-        : detail::num_points::other_count<1>\n+    : detail::counting::other_count<1>\n {};\n \n template <typename Geometry>\n struct num_points<Geometry, box_tag>\n-        : detail::num_points::other_count<4>\n+    : detail::counting::other_count<(1 << geometry::dimension<Geometry>::value)>\n {};","path":"include/boost/geometry/algorithms/num_points.hpp","position":127,"original_position":127,"commit_id":"01043518b3707d4a36add678f2d67d7023e2b644","original_commit_id":"01043518b3707d4a36add678f2d67d7023e2b644","user":{"login":"barendgehrels","id":334849,"avatar_url":"https://avatars.githubusercontent.com/u/334849?v=2","gravatar_id":"cdf0a01023090505d0b38d0890748acb","url":"https://api.github.com/users/barendgehrels","html_url":"https://github.com/barendgehrels","followers_url":"https://api.github.com/users/barendgehrels/followers","following_url":"https://api.github.com/users/barendgehrels/following{/other_user}","gists_url":"https://api.github.com/users/barendgehrels/gists{/gist_id}","starred_url":"https://api.github.com/users/barendgehrels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barendgehrels/subscriptions","organizations_url":"https://api.github.com/users/barendgehrels/orgs","repos_url":"https://api.github.com/users/barendgehrels/repos","events_url":"https://api.github.com/users/barendgehrels/events{/privacy}","received_events_url":"https://api.github.com/users/barendgehrels/received_events","type":"User","site_admin":false},"body":"Looks perfect ;-)","created_at":"2014-08-11T08:15:59Z","updated_at":"2014-08-11T08:15:59Z","html_url":"https://github.com/boostorg/geometry/pull/128#discussion_r16041611","pull_request_url":"https://api.github.com/repos/boostorg/geometry/pulls/128","_links":{"self":{"href":"https://api.github.com/repos/boostorg/geometry/pulls/comments/16041611"},"html":{"href":"https://github.com/boostorg/geometry/pull/128#discussion_r16041611"},"pull_request":{"href":"https://api.github.com/repos/boostorg/geometry/pulls/128"}}},"pull_request":{"url":"https://api.github.com/repos/boostorg/geometry/pulls/128","id":19523091,"html_url":"https://github.com/boostorg/geometry/pull/128","diff_url":"https://github.com/boostorg/geometry/pull/128.diff","patch_url":"https://github.com/boostorg/geometry/pull/128.patch","issue_url":"https://api.github.com/repos/boostorg/geometry/issues/128","number":128,"state":"open","title":"Feature/counting algorithms","user":{"login":"mkaravel","id":6397014,"avatar_url":"https://avatars.githubusercontent.com/u/6397014?v=2","gravatar_id":"23b0888d7291238e96ace3640ba37026","url":"https://api.github.com/users/mkaravel","html_url":"https://github.com/mkaravel","followers_url":"https://api.github.com/users/mkaravel/followers","following_url":"https://api.github.com/users/mkaravel/following{/other_user}","gists_url":"https://api.github.com/users/mkaravel/gists{/gist_id}","starred_url":"https://api.github.com/users/mkaravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkaravel/subscriptions","organizations_url":"https://api.github.com/users/mkaravel/orgs","repos_url":"https://api.github.com/users/mkaravel/repos","events_url":"https://api.github.com/users/mkaravel/events{/privacy}","received_events_url":"https://api.github.com/users/mkaravel/received_events","type":"User","site_admin":false},"body":"This feature contains the following modifications:\r\n* Re-factor counting algorithms: `num_points`, `num_segments`, `num_geometries` and `num_interior_rings`: this refactoring involves moving common code to a separate file `algorithms\\detail\\counting.hpp` and a new namespace that I called `bg::detail::counting`. As part of the re-factoring, the `num_points` code in the `multi/algorithms` directory was also moved in the `algorithms` directory.\r\n* Add variant support for `num_interior_rings` and `num_geometries`.\r\n* Add unit tests for `num_interior_rings` and `num_geometries`.\r\n* Implement `num_points` and `num_segments` for boxes of any dimension: to do this I implemented the Boost.MPL-based metafunction `ipower` in the `bg::util` namespace that computes the power of an integral constant at compile time (there is also a unit test for this metafunction). As part of this change, the unit tests for `num_points` and `num_segments` now test for boxes of dimensions 3, 4 and 5.","created_at":"2014-08-08T11:57:49Z","updated_at":"2014-08-11T08:15:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"df59b1e0dcf836312e92246d5df4b12f83171181","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/boostorg/geometry/pulls/128/commits","review_comments_url":"https://api.github.com/repos/boostorg/geometry/pulls/128/comments","review_comment_url":"https://api.github.com/repos/boostorg/geometry/pulls/comments/{number}","comments_url":"https://api.github.com/repos/boostorg/geometry/issues/128/comments","statuses_url":"https://api.github.com/repos/boostorg/geometry/statuses/01043518b3707d4a36add678f2d67d7023e2b644","head":{"label":"mkaravel:feature/counting-algorithms","ref":"feature/counting-algorithms","sha":"01043518b3707d4a36add678f2d67d7023e2b644","user":{"login":"mkaravel","id":6397014,"avatar_url":"https://avatars.githubusercontent.com/u/6397014?v=2","gravatar_id":"23b0888d7291238e96ace3640ba37026","url":"https://api.github.com/users/mkaravel","html_url":"https://github.com/mkaravel","followers_url":"https://api.github.com/users/mkaravel/followers","following_url":"https://api.github.com/users/mkaravel/following{/other_user}","gists_url":"https://api.github.com/users/mkaravel/gists{/gist_id}","starred_url":"https://api.github.com/users/mkaravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkaravel/subscriptions","organizations_url":"https://api.github.com/users/mkaravel/orgs","repos_url":"https://api.github.com/users/mkaravel/repos","events_url":"https://api.github.com/users/mkaravel/events{/privacy}","received_events_url":"https://api.github.com/users/mkaravel/received_events","type":"User","site_admin":false},"repo":{"id":15894753,"name":"geometry","full_name":"mkaravel/geometry","owner":{"login":"mkaravel","id":6397014,"avatar_url":"https://avatars.githubusercontent.com/u/6397014?v=2","gravatar_id":"23b0888d7291238e96ace3640ba37026","url":"https://api.github.com/users/mkaravel","html_url":"https://github.com/mkaravel","followers_url":"https://api.github.com/users/mkaravel/followers","following_url":"https://api.github.com/users/mkaravel/following{/other_user}","gists_url":"https://api.github.com/users/mkaravel/gists{/gist_id}","starred_url":"https://api.github.com/users/mkaravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkaravel/subscriptions","organizations_url":"https://api.github.com/users/mkaravel/orgs","repos_url":"https://api.github.com/users/mkaravel/repos","events_url":"https://api.github.com/users/mkaravel/events{/privacy}","received_events_url":"https://api.github.com/users/mkaravel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mkaravel/geometry","description":"Boost.org geometry module","fork":true,"url":"https://api.github.com/repos/mkaravel/geometry","forks_url":"https://api.github.com/repos/mkaravel/geometry/forks","keys_url":"https://api.github.com/repos/mkaravel/geometry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mkaravel/geometry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mkaravel/geometry/teams","hooks_url":"https://api.github.com/repos/mkaravel/geometry/hooks","issue_events_url":"https://api.github.com/repos/mkaravel/geometry/issues/events{/number}","events_url":"https://api.github.com/repos/mkaravel/geometry/events","assignees_url":"https://api.github.com/repos/mkaravel/geometry/assignees{/user}","branches_url":"https://api.github.com/repos/mkaravel/geometry/branches{/branch}","tags_url":"https://api.github.com/repos/mkaravel/geometry/tags","blobs_url":"https://api.github.com/repos/mkaravel/geometry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mkaravel/geometry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mkaravel/geometry/git/refs{/sha}","trees_url":"https://api.github.com/repos/mkaravel/geometry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mkaravel/geometry/statuses/{sha}","languages_url":"https://api.github.com/repos/mkaravel/geometry/languages","stargazers_url":"https://api.github.com/repos/mkaravel/geometry/stargazers","contributors_url":"https://api.github.com/repos/mkaravel/geometry/contributors","subscribers_url":"https://api.github.com/repos/mkaravel/geometry/subscribers","subscription_url":"https://api.github.com/repos/mkaravel/geometry/subscription","commits_url":"https://api.github.com/repos/mkaravel/geometry/commits{/sha}","git_commits_url":"https://api.github.com/repos/mkaravel/geometry/git/commits{/sha}","comments_url":"https://api.github.com/repos/mkaravel/geometry/comments{/number}","issue_comment_url":"https://api.github.com/repos/mkaravel/geometry/issues/comments/{number}","contents_url":"https://api.github.com/repos/mkaravel/geometry/contents/{+path}","compare_url":"https://api.github.com/repos/mkaravel/geometry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mkaravel/geometry/merges","archive_url":"https://api.github.com/repos/mkaravel/geometry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mkaravel/geometry/downloads","issues_url":"https://api.github.com/repos/mkaravel/geometry/issues{/number}","pulls_url":"https://api.github.com/repos/mkaravel/geometry/pulls{/number}","milestones_url":"https://api.github.com/repos/mkaravel/geometry/milestones{/number}","notifications_url":"https://api.github.com/repos/mkaravel/geometry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mkaravel/geometry/labels{/name}","releases_url":"https://api.github.com/repos/mkaravel/geometry/releases{/id}","created_at":"2014-01-14T07:16:18Z","updated_at":"2014-07-01T23:25:44Z","pushed_at":"2014-08-10T22:46:16Z","git_url":"git://github.com/mkaravel/geometry.git","ssh_url":"git@github.com:mkaravel/geometry.git","clone_url":"https://github.com/mkaravel/geometry.git","svn_url":"https://github.com/mkaravel/geometry","homepage":"http://boost.org/libs/geometry","size":36177,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"boostorg:develop","ref":"develop","sha":"8d7b70c3e01626758f2d92b159d7d3da0d81f405","user":{"login":"boostorg","id":3170529,"avatar_url":"https://avatars.githubusercontent.com/u/3170529?v=2","gravatar_id":"4cd3bf7ce3e8288d97ef87420804a285","url":"https://api.github.com/users/boostorg","html_url":"https://github.com/boostorg","followers_url":"https://api.github.com/users/boostorg/followers","following_url":"https://api.github.com/users/boostorg/following{/other_user}","gists_url":"https://api.github.com/users/boostorg/gists{/gist_id}","starred_url":"https://api.github.com/users/boostorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boostorg/subscriptions","organizations_url":"https://api.github.com/users/boostorg/orgs","repos_url":"https://api.github.com/users/boostorg/repos","events_url":"https://api.github.com/users/boostorg/events{/privacy}","received_events_url":"https://api.github.com/users/boostorg/received_events","type":"Organization","site_admin":false},"repo":{"id":7590021,"name":"geometry","full_name":"boostorg/geometry","owner":{"login":"boostorg","id":3170529,"avatar_url":"https://avatars.githubusercontent.com/u/3170529?v=2","gravatar_id":"4cd3bf7ce3e8288d97ef87420804a285","url":"https://api.github.com/users/boostorg","html_url":"https://github.com/boostorg","followers_url":"https://api.github.com/users/boostorg/followers","following_url":"https://api.github.com/users/boostorg/following{/other_user}","gists_url":"https://api.github.com/users/boostorg/gists{/gist_id}","starred_url":"https://api.github.com/users/boostorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boostorg/subscriptions","organizations_url":"https://api.github.com/users/boostorg/orgs","repos_url":"https://api.github.com/users/boostorg/repos","events_url":"https://api.github.com/users/boostorg/events{/privacy}","received_events_url":"https://api.github.com/users/boostorg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/boostorg/geometry","description":"Boost.org geometry module","fork":false,"url":"https://api.github.com/repos/boostorg/geometry","forks_url":"https://api.github.com/repos/boostorg/geometry/forks","keys_url":"https://api.github.com/repos/boostorg/geometry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/boostorg/geometry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/boostorg/geometry/teams","hooks_url":"https://api.github.com/repos/boostorg/geometry/hooks","issue_events_url":"https://api.github.com/repos/boostorg/geometry/issues/events{/number}","events_url":"https://api.github.com/repos/boostorg/geometry/events","assignees_url":"https://api.github.com/repos/boostorg/geometry/assignees{/user}","branches_url":"https://api.github.com/repos/boostorg/geometry/branches{/branch}","tags_url":"https://api.github.com/repos/boostorg/geometry/tags","blobs_url":"https://api.github.com/repos/boostorg/geometry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/boostorg/geometry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/boostorg/geometry/git/refs{/sha}","trees_url":"https://api.github.com/repos/boostorg/geometry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/boostorg/geometry/statuses/{sha}","languages_url":"https://api.github.com/repos/boostorg/geometry/languages","stargazers_url":"https://api.github.com/repos/boostorg/geometry/stargazers","contributors_url":"https://api.github.com/repos/boostorg/geometry/contributors","subscribers_url":"https://api.github.com/repos/boostorg/geometry/subscribers","subscription_url":"https://api.github.com/repos/boostorg/geometry/subscription","commits_url":"https://api.github.com/repos/boostorg/geometry/commits{/sha}","git_commits_url":"https://api.github.com/repos/boostorg/geometry/git/commits{/sha}","comments_url":"https://api.github.com/repos/boostorg/geometry/comments{/number}","issue_comment_url":"https://api.github.com/repos/boostorg/geometry/issues/comments/{number}","contents_url":"https://api.github.com/repos/boostorg/geometry/contents/{+path}","compare_url":"https://api.github.com/repos/boostorg/geometry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/boostorg/geometry/merges","archive_url":"https://api.github.com/repos/boostorg/geometry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/boostorg/geometry/downloads","issues_url":"https://api.github.com/repos/boostorg/geometry/issues{/number}","pulls_url":"https://api.github.com/repos/boostorg/geometry/pulls{/number}","milestones_url":"https://api.github.com/repos/boostorg/geometry/milestones{/number}","notifications_url":"https://api.github.com/repos/boostorg/geometry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/boostorg/geometry/labels{/name}","releases_url":"https://api.github.com/repos/boostorg/geometry/releases{/id}","created_at":"2013-01-13T15:59:29Z","updated_at":"2014-08-06T10:34:21Z","pushed_at":"2014-08-10T21:52:34Z","git_url":"git://github.com/boostorg/geometry.git","ssh_url":"git@github.com:boostorg/geometry.git","clone_url":"https://github.com/boostorg/geometry.git","svn_url":"https://github.com/boostorg/geometry","homepage":"http://boost.org/libs/geometry","size":46216,"stargazers_count":29,"watchers_count":29,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":19,"mirror_url":null,"open_issues_count":4,"forks":19,"open_issues":4,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/boostorg/geometry/pulls/128"},"html":{"href":"https://github.com/boostorg/geometry/pull/128"},"issue":{"href":"https://api.github.com/repos/boostorg/geometry/issues/128"},"comments":{"href":"https://api.github.com/repos/boostorg/geometry/issues/128/comments"},"review_comments":{"href":"https://api.github.com/repos/boostorg/geometry/pulls/128/comments"},"review_comment":{"href":"https://api.github.com/repos/boostorg/geometry/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/boostorg/geometry/pulls/128/commits"},"statuses":{"href":"https://api.github.com/repos/boostorg/geometry/statuses/01043518b3707d4a36add678f2d67d7023e2b644"}}}}