GitHub PullRequestReviewCommentEvent at 2014-11-05 13:00:09
Repository: buttonmen
Actor: cgolubi1
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/buttonmen-dev/buttonmen/pulls/comments/19871145","id":19871145,"diff_hunk":"@@ -24,7 +25,9 @@\n  * @property      string $inactive              Why may this die not attack?\n  * @property      bool   $unavailable           Is the die a warrior die that has not yet joined?\n  * @property-read array  $flagList              Array designed to contain various BMFlags\n- */\n+ *\n+ * @SuppressWarnings(PMD.TooManyFields)","path":"src/engine/BMDie.php","position":14,"original_position":14,"commit_id":"f1d0285cb5dda8eee3a699bf956cd266e39da486","original_commit_id":"f1d0285cb5dda8eee3a699bf956cd266e39da486","user":{"login":"cgolubi1","id":2898207,"avatar_url":"https://avatars.githubusercontent.com/u/2898207?v=2","gravatar_id":"","url":"https://api.github.com/users/cgolubi1","html_url":"https://github.com/cgolubi1","followers_url":"https://api.github.com/users/cgolubi1/followers","following_url":"https://api.github.com/users/cgolubi1/following{/other_user}","gists_url":"https://api.github.com/users/cgolubi1/gists{/gist_id}","starred_url":"https://api.github.com/users/cgolubi1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgolubi1/subscriptions","organizations_url":"https://api.github.com/users/cgolubi1/orgs","repos_url":"https://api.github.com/users/cgolubi1/repos","events_url":"https://api.github.com/users/cgolubi1/events{/privacy}","received_events_url":"https://api.github.com/users/cgolubi1/received_events","type":"User","site_admin":false},"body":"Sounds good; i opened #1393.","created_at":"2014-11-05T13:00:09Z","updated_at":"2014-11-05T13:00:09Z","html_url":"https://github.com/buttonmen-dev/buttonmen/pull/1365#discussion_r19871145","pull_request_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/pulls/1365","_links":{"self":{"href":"https://api.github.com/repos/buttonmen-dev/buttonmen/pulls/comments/19871145"},"html":{"href":"https://github.com/buttonmen-dev/buttonmen/pull/1365#discussion_r19871145"},"pull_request":{"href":"https://api.github.com/repos/buttonmen-dev/buttonmen/pulls/1365"}}},"pull_request":{"url":"https://api.github.com/repos/buttonmen-dev/buttonmen/pulls/1365","id":23225819,"html_url":"https://github.com/buttonmen-dev/buttonmen/pull/1365","diff_url":"https://github.com/buttonmen-dev/buttonmen/pull/1365.diff","patch_url":"https://github.com/buttonmen-dev/buttonmen/pull/1365.patch","issue_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/issues/1365","number":1365,"state":"open","locked":false,"title":"Added radioactive skill","user":{"login":"blackshadowshade","id":2898401,"avatar_url":"https://avatars.githubusercontent.com/u/2898401?v=2","gravatar_id":"","url":"https://api.github.com/users/blackshadowshade","html_url":"https://github.com/blackshadowshade","followers_url":"https://api.github.com/users/blackshadowshade/followers","following_url":"https://api.github.com/users/blackshadowshade/following{/other_user}","gists_url":"https://api.github.com/users/blackshadowshade/gists{/gist_id}","starred_url":"https://api.github.com/users/blackshadowshade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blackshadowshade/subscriptions","organizations_url":"https://api.github.com/users/blackshadowshade/orgs","repos_url":"https://api.github.com/users/blackshadowshade/repos","events_url":"https://api.github.com/users/blackshadowshade/events{/privacy}","received_events_url":"https://api.github.com/users/blackshadowshade/received_events","type":"User","site_admin":false},"body":"This implementation of radioactive splits one-sided dice into a one-sider and a zero-sider. However, it is trivial to change this back to splitting into two one-siders if this is decided.\r\n\r\nThere is currently no game-level or interface-level test for radioactive, and this might be a *good thing* to have.  ;)\r\n\r\nAlso, I'd appreciate feedback on the action logging that I've included for attacker die splitting.\r\n\r\nhttp://jenkins.buttonweavers.com:8080/job/buttonmen-blackshadowshade/491/\r\n(and I'll fix the PMD warnings once I work out how to do so)","created_at":"2014-10-23T12:54:37Z","updated_at":"2014-11-05T13:00:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9ccd930ec5f82030b6644b7efa703f2f1608cb60","assignee":{"login":"cgolubi1","id":2898207,"avatar_url":"https://avatars.githubusercontent.com/u/2898207?v=2","gravatar_id":"","url":"https://api.github.com/users/cgolubi1","html_url":"https://github.com/cgolubi1","followers_url":"https://api.github.com/users/cgolubi1/followers","following_url":"https://api.github.com/users/cgolubi1/following{/other_user}","gists_url":"https://api.github.com/users/cgolubi1/gists{/gist_id}","starred_url":"https://api.github.com/users/cgolubi1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgolubi1/subscriptions","organizations_url":"https://api.github.com/users/cgolubi1/orgs","repos_url":"https://api.github.com/users/cgolubi1/repos","events_url":"https://api.github.com/users/cgolubi1/events{/privacy}","received_events_url":"https://api.github.com/users/cgolubi1/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/pulls/1365/commits","review_comments_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/pulls/1365/comments","review_comment_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/pulls/comments/{number}","comments_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/issues/1365/comments","statuses_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/statuses/f1d0285cb5dda8eee3a699bf956cd266e39da486","head":{"label":"blackshadowshade:95_radioactive","ref":"95_radioactive","sha":"f1d0285cb5dda8eee3a699bf956cd266e39da486","user":{"login":"blackshadowshade","id":2898401,"avatar_url":"https://avatars.githubusercontent.com/u/2898401?v=2","gravatar_id":"","url":"https://api.github.com/users/blackshadowshade","html_url":"https://github.com/blackshadowshade","followers_url":"https://api.github.com/users/blackshadowshade/followers","following_url":"https://api.github.com/users/blackshadowshade/following{/other_user}","gists_url":"https://api.github.com/users/blackshadowshade/gists{/gist_id}","starred_url":"https://api.github.com/users/blackshadowshade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blackshadowshade/subscriptions","organizations_url":"https://api.github.com/users/blackshadowshade/orgs","repos_url":"https://api.github.com/users/blackshadowshade/repos","events_url":"https://api.github.com/users/blackshadowshade/events{/privacy}","received_events_url":"https://api.github.com/users/blackshadowshade/received_events","type":"User","site_admin":false},"repo":{"id":6902326,"name":"buttonmen","full_name":"blackshadowshade/buttonmen","owner":{"login":"blackshadowshade","id":2898401,"avatar_url":"https://avatars.githubusercontent.com/u/2898401?v=2","gravatar_id":"","url":"https://api.github.com/users/blackshadowshade","html_url":"https://github.com/blackshadowshade","followers_url":"https://api.github.com/users/blackshadowshade/followers","following_url":"https://api.github.com/users/blackshadowshade/following{/other_user}","gists_url":"https://api.github.com/users/blackshadowshade/gists{/gist_id}","starred_url":"https://api.github.com/users/blackshadowshade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blackshadowshade/subscriptions","organizations_url":"https://api.github.com/users/blackshadowshade/orgs","repos_url":"https://api.github.com/users/blackshadowshade/repos","events_url":"https://api.github.com/users/blackshadowshade/events{/privacy}","received_events_url":"https://api.github.com/users/blackshadowshade/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/blackshadowshade/buttonmen","description":"Buttonmen - an online dice game","fork":true,"url":"https://api.github.com/repos/blackshadowshade/buttonmen","forks_url":"https://api.github.com/repos/blackshadowshade/buttonmen/forks","keys_url":"https://api.github.com/repos/blackshadowshade/buttonmen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blackshadowshade/buttonmen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blackshadowshade/buttonmen/teams","hooks_url":"https://api.github.com/repos/blackshadowshade/buttonmen/hooks","issue_events_url":"https://api.github.com/repos/blackshadowshade/buttonmen/issues/events{/number}","events_url":"https://api.github.com/repos/blackshadowshade/buttonmen/events","assignees_url":"https://api.github.com/repos/blackshadowshade/buttonmen/assignees{/user}","branches_url":"https://api.github.com/repos/blackshadowshade/buttonmen/branches{/branch}","tags_url":"https://api.github.com/repos/blackshadowshade/buttonmen/tags","blobs_url":"https://api.github.com/repos/blackshadowshade/buttonmen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blackshadowshade/buttonmen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blackshadowshade/buttonmen/git/refs{/sha}","trees_url":"https://api.github.com/repos/blackshadowshade/buttonmen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blackshadowshade/buttonmen/statuses/{sha}","languages_url":"https://api.github.com/repos/blackshadowshade/buttonmen/languages","stargazers_url":"https://api.github.com/repos/blackshadowshade/buttonmen/stargazers","contributors_url":"https://api.github.com/repos/blackshadowshade/buttonmen/contributors","subscribers_url":"https://api.github.com/repos/blackshadowshade/buttonmen/subscribers","subscription_url":"https://api.github.com/repos/blackshadowshade/buttonmen/subscription","commits_url":"https://api.github.com/repos/blackshadowshade/buttonmen/commits{/sha}","git_commits_url":"https://api.github.com/repos/blackshadowshade/buttonmen/git/commits{/sha}","comments_url":"https://api.github.com/repos/blackshadowshade/buttonmen/comments{/number}","issue_comment_url":"https://api.github.com/repos/blackshadowshade/buttonmen/issues/comments/{number}","contents_url":"https://api.github.com/repos/blackshadowshade/buttonmen/contents/{+path}","compare_url":"https://api.github.com/repos/blackshadowshade/buttonmen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blackshadowshade/buttonmen/merges","archive_url":"https://api.github.com/repos/blackshadowshade/buttonmen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blackshadowshade/buttonmen/downloads","issues_url":"https://api.github.com/repos/blackshadowshade/buttonmen/issues{/number}","pulls_url":"https://api.github.com/repos/blackshadowshade/buttonmen/pulls{/number}","milestones_url":"https://api.github.com/repos/blackshadowshade/buttonmen/milestones{/number}","notifications_url":"https://api.github.com/repos/blackshadowshade/buttonmen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blackshadowshade/buttonmen/labels{/name}","releases_url":"https://api.github.com/repos/blackshadowshade/buttonmen/releases{/id}","created_at":"2012-11-28T13:25:42Z","updated_at":"2014-08-26T00:23:44Z","pushed_at":"2014-11-05T11:52:45Z","git_url":"git://github.com/blackshadowshade/buttonmen.git","ssh_url":"git@github.com:blackshadowshade/buttonmen.git","clone_url":"https://github.com/blackshadowshade/buttonmen.git","svn_url":"https://github.com/blackshadowshade/buttonmen","homepage":null,"size":40162,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"buttonmen-dev:master","ref":"master","sha":"42950bdbabf77900fdcbef30fa5be64164f0482a","user":{"login":"buttonmen-dev","id":2898279,"avatar_url":"https://avatars.githubusercontent.com/u/2898279?v=2","gravatar_id":"","url":"https://api.github.com/users/buttonmen-dev","html_url":"https://github.com/buttonmen-dev","followers_url":"https://api.github.com/users/buttonmen-dev/followers","following_url":"https://api.github.com/users/buttonmen-dev/following{/other_user}","gists_url":"https://api.github.com/users/buttonmen-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/buttonmen-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buttonmen-dev/subscriptions","organizations_url":"https://api.github.com/users/buttonmen-dev/orgs","repos_url":"https://api.github.com/users/buttonmen-dev/repos","events_url":"https://api.github.com/users/buttonmen-dev/events{/privacy}","received_events_url":"https://api.github.com/users/buttonmen-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":6877175,"name":"buttonmen","full_name":"buttonmen-dev/buttonmen","owner":{"login":"buttonmen-dev","id":2898279,"avatar_url":"https://avatars.githubusercontent.com/u/2898279?v=2","gravatar_id":"","url":"https://api.github.com/users/buttonmen-dev","html_url":"https://github.com/buttonmen-dev","followers_url":"https://api.github.com/users/buttonmen-dev/followers","following_url":"https://api.github.com/users/buttonmen-dev/following{/other_user}","gists_url":"https://api.github.com/users/buttonmen-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/buttonmen-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buttonmen-dev/subscriptions","organizations_url":"https://api.github.com/users/buttonmen-dev/orgs","repos_url":"https://api.github.com/users/buttonmen-dev/repos","events_url":"https://api.github.com/users/buttonmen-dev/events{/privacy}","received_events_url":"https://api.github.com/users/buttonmen-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/buttonmen-dev/buttonmen","description":"Buttonmen - an online dice game","fork":false,"url":"https://api.github.com/repos/buttonmen-dev/buttonmen","forks_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/forks","keys_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/teams","hooks_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/hooks","issue_events_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/issues/events{/number}","events_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/events","assignees_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/assignees{/user}","branches_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/branches{/branch}","tags_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/tags","blobs_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/git/refs{/sha}","trees_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/statuses/{sha}","languages_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/languages","stargazers_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/stargazers","contributors_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/contributors","subscribers_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/subscribers","subscription_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/subscription","commits_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/commits{/sha}","git_commits_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/git/commits{/sha}","comments_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/comments{/number}","issue_comment_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/issues/comments/{number}","contents_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/contents/{+path}","compare_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/merges","archive_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/downloads","issues_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/issues{/number}","pulls_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/pulls{/number}","milestones_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/milestones{/number}","notifications_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/labels{/name}","releases_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/releases{/id}","created_at":"2012-11-27T03:55:05Z","updated_at":"2014-09-22T23:51:44Z","pushed_at":"2014-11-02T13:27:02Z","git_url":"git://github.com/buttonmen-dev/buttonmen.git","ssh_url":"git@github.com:buttonmen-dev/buttonmen.git","clone_url":"https://github.com/buttonmen-dev/buttonmen.git","svn_url":"https://github.com/buttonmen-dev/buttonmen","homepage":null,"size":46141,"stargazers_count":4,"watchers_count":4,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":257,"forks":11,"open_issues":257,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/buttonmen-dev/buttonmen/pulls/1365"},"html":{"href":"https://github.com/buttonmen-dev/buttonmen/pull/1365"},"issue":{"href":"https://api.github.com/repos/buttonmen-dev/buttonmen/issues/1365"},"comments":{"href":"https://api.github.com/repos/buttonmen-dev/buttonmen/issues/1365/comments"},"review_comments":{"href":"https://api.github.com/repos/buttonmen-dev/buttonmen/pulls/1365/comments"},"review_comment":{"href":"https://api.github.com/repos/buttonmen-dev/buttonmen/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/buttonmen-dev/buttonmen/pulls/1365/commits"},"statuses":{"href":"https://api.github.com/repos/buttonmen-dev/buttonmen/statuses/f1d0285cb5dda8eee3a699bf956cd266e39da486"}}}}