GitHub PullRequestReviewCommentEvent at 2014-09-26 13:01:38
Repository: homebrew-versions
Actor: vitorgalvao
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/caskroom/homebrew-versions/pulls/comments/18087299","id":18087299,"diff_hunk":"@@ -2,10 +2,10 @@ class QuicktimePlayer7 < Cask\n   version '7.6.6'\n   sha256 '704b5eee2ad953f301a652033db317e6997b9e5910db4b1f8d511b04ab62f2bc'\n \n-  url 'http://support.apple.com/downloads/DL923/en_US/QuickTimePlayer7.6.6_SnowLeopard.dmg'\n+  url \"http://support.apple.com/downloads/DL923/en_US/QuickTimePlayer#{version}_SnowLeopard.dmg\"\n   homepage 'http://support.apple.com/kb/dl923'\n \n-  pkg 'QuickTimePlayer7.6.6_SnowLeopard.pkg'\n-  uninstall :pkgutil => 'com.apple.pkg.QuickTimePlayer7.6.6_SnowLeopard',\n+  pkg \"QuickTimePlayer#{version}_SnowLeopard.pkg\"\n+  uninstall :pkgutil => \"com.apple.pkg.QuickTimePlayer#{version}_SnowLeopard\",","path":"Casks/quicktime-player7.rb","position":11,"original_position":11,"commit_id":"c0673455c1096dd37b3b61c28ecb635fca5fb4e0","original_commit_id":"c0673455c1096dd37b3b61c28ecb635fca5fb4e0","user":{"login":"vitorgalvao","id":1699443,"avatar_url":"https://avatars.githubusercontent.com/u/1699443?v=2","gravatar_id":"","url":"https://api.github.com/users/vitorgalvao","html_url":"https://github.com/vitorgalvao","followers_url":"https://api.github.com/users/vitorgalvao/followers","following_url":"https://api.github.com/users/vitorgalvao/following{/other_user}","gists_url":"https://api.github.com/users/vitorgalvao/gists{/gist_id}","starred_url":"https://api.github.com/users/vitorgalvao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitorgalvao/subscriptions","organizations_url":"https://api.github.com/users/vitorgalvao/orgs","repos_url":"https://api.github.com/users/vitorgalvao/repos","events_url":"https://api.github.com/users/vitorgalvao/events{/privacy}","received_events_url":"https://api.github.com/users/vitorgalvao/received_events","type":"User","site_admin":false},"body":"No need; it’s fine with me either way. I remember you once preferring `*` in a similar case in the main repo, which is why I pointed it out, as it might’ve gone unnoticed. I very much agree with your conclusion of being more specific in this repo, though; makes sense, so lets leave it (this particular cask shouldn’t get any future updates, anyway, which makes it an easier call).","created_at":"2014-09-26T13:01:38Z","updated_at":"2014-09-26T13:01:38Z","html_url":"https://github.com/caskroom/homebrew-versions/pull/439#discussion_r18087299","pull_request_url":"https://api.github.com/repos/caskroom/homebrew-versions/pulls/439","_links":{"self":{"href":"https://api.github.com/repos/caskroom/homebrew-versions/pulls/comments/18087299"},"html":{"href":"https://github.com/caskroom/homebrew-versions/pull/439#discussion_r18087299"},"pull_request":{"href":"https://api.github.com/repos/caskroom/homebrew-versions/pulls/439"}}},"pull_request":{"url":"https://api.github.com/repos/caskroom/homebrew-versions/pulls/439","id":21844916,"html_url":"https://github.com/caskroom/homebrew-versions/pull/439","diff_url":"https://github.com/caskroom/homebrew-versions/pull/439.diff","patch_url":"https://github.com/caskroom/homebrew-versions/pull/439.patch","issue_url":"https://api.github.com/repos/caskroom/homebrew-versions/issues/439","number":439,"state":"closed","locked":false,"title":"Change 53 Casks to use dynamic version","user":{"login":"rolandwalker","id":727482,"avatar_url":"https://avatars.githubusercontent.com/u/727482?v=2","gravatar_id":"","url":"https://api.github.com/users/rolandwalker","html_url":"https://github.com/rolandwalker","followers_url":"https://api.github.com/users/rolandwalker/followers","following_url":"https://api.github.com/users/rolandwalker/following{/other_user}","gists_url":"https://api.github.com/users/rolandwalker/gists{/gist_id}","starred_url":"https://api.github.com/users/rolandwalker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rolandwalker/subscriptions","organizations_url":"https://api.github.com/users/rolandwalker/orgs","repos_url":"https://api.github.com/users/rolandwalker/repos","events_url":"https://api.github.com/users/rolandwalker/events{/privacy}","received_events_url":"https://api.github.com/users/rolandwalker/received_events","type":"User","site_admin":false},"body":"This doesn't cover all cases, only exact matches to the version string.\r\n\r\ncc @vitorgalvao","created_at":"2014-09-26T12:21:24Z","updated_at":"2014-09-26T13:01:38Z","closed_at":"2014-09-26T12:46:22Z","merged_at":"2014-09-26T12:46:22Z","merge_commit_sha":"1154aa0f79f7ab2f1a906e7239f9baa27930e754","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/caskroom/homebrew-versions/pulls/439/commits","review_comments_url":"https://api.github.com/repos/caskroom/homebrew-versions/pulls/439/comments","review_comment_url":"https://api.github.com/repos/caskroom/homebrew-versions/pulls/comments/{number}","comments_url":"https://api.github.com/repos/caskroom/homebrew-versions/issues/439/comments","statuses_url":"https://api.github.com/repos/caskroom/homebrew-versions/statuses/c0673455c1096dd37b3b61c28ecb635fca5fb4e0","head":{"label":"rolandwalker:mass_change_dynamic_version","ref":"mass_change_dynamic_version","sha":"c0673455c1096dd37b3b61c28ecb635fca5fb4e0","user":{"login":"rolandwalker","id":727482,"avatar_url":"https://avatars.githubusercontent.com/u/727482?v=2","gravatar_id":"","url":"https://api.github.com/users/rolandwalker","html_url":"https://github.com/rolandwalker","followers_url":"https://api.github.com/users/rolandwalker/followers","following_url":"https://api.github.com/users/rolandwalker/following{/other_user}","gists_url":"https://api.github.com/users/rolandwalker/gists{/gist_id}","starred_url":"https://api.github.com/users/rolandwalker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rolandwalker/subscriptions","organizations_url":"https://api.github.com/users/rolandwalker/orgs","repos_url":"https://api.github.com/users/rolandwalker/repos","events_url":"https://api.github.com/users/rolandwalker/events{/privacy}","received_events_url":"https://api.github.com/users/rolandwalker/received_events","type":"User","site_admin":false},"repo":{"id":14527216,"name":"homebrew-versions","full_name":"rolandwalker/homebrew-versions","owner":{"login":"rolandwalker","id":727482,"avatar_url":"https://avatars.githubusercontent.com/u/727482?v=2","gravatar_id":"","url":"https://api.github.com/users/rolandwalker","html_url":"https://github.com/rolandwalker","followers_url":"https://api.github.com/users/rolandwalker/followers","following_url":"https://api.github.com/users/rolandwalker/following{/other_user}","gists_url":"https://api.github.com/users/rolandwalker/gists{/gist_id}","starred_url":"https://api.github.com/users/rolandwalker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rolandwalker/subscriptions","organizations_url":"https://api.github.com/users/rolandwalker/orgs","repos_url":"https://api.github.com/users/rolandwalker/repos","events_url":"https://api.github.com/users/rolandwalker/events{/privacy}","received_events_url":"https://api.github.com/users/rolandwalker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rolandwalker/homebrew-versions","description":"alternate versions of Casks for homebrew-cask","fork":true,"url":"https://api.github.com/repos/rolandwalker/homebrew-versions","forks_url":"https://api.github.com/repos/rolandwalker/homebrew-versions/forks","keys_url":"https://api.github.com/repos/rolandwalker/homebrew-versions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rolandwalker/homebrew-versions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rolandwalker/homebrew-versions/teams","hooks_url":"https://api.github.com/repos/rolandwalker/homebrew-versions/hooks","issue_events_url":"https://api.github.com/repos/rolandwalker/homebrew-versions/issues/events{/number}","events_url":"https://api.github.com/repos/rolandwalker/homebrew-versions/events","assignees_url":"https://api.github.com/repos/rolandwalker/homebrew-versions/assignees{/user}","branches_url":"https://api.github.com/repos/rolandwalker/homebrew-versions/branches{/branch}","tags_url":"https://api.github.com/repos/rolandwalker/homebrew-versions/tags","blobs_url":"https://api.github.com/repos/rolandwalker/homebrew-versions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rolandwalker/homebrew-versions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rolandwalker/homebrew-versions/git/refs{/sha}","trees_url":"https://api.github.com/repos/rolandwalker/homebrew-versions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rolandwalker/homebrew-versions/statuses/{sha}","languages_url":"https://api.github.com/repos/rolandwalker/homebrew-versions/languages","stargazers_url":"https://api.github.com/repos/rolandwalker/homebrew-versions/stargazers","contributors_url":"https://api.github.com/repos/rolandwalker/homebrew-versions/contributors","subscribers_url":"https://api.github.com/repos/rolandwalker/homebrew-versions/subscribers","subscription_url":"https://api.github.com/repos/rolandwalker/homebrew-versions/subscription","commits_url":"https://api.github.com/repos/rolandwalker/homebrew-versions/commits{/sha}","git_commits_url":"https://api.github.com/repos/rolandwalker/homebrew-versions/git/commits{/sha}","comments_url":"https://api.github.com/repos/rolandwalker/homebrew-versions/comments{/number}","issue_comment_url":"https://api.github.com/repos/rolandwalker/homebrew-versions/issues/comments/{number}","contents_url":"https://api.github.com/repos/rolandwalker/homebrew-versions/contents/{+path}","compare_url":"https://api.github.com/repos/rolandwalker/homebrew-versions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rolandwalker/homebrew-versions/merges","archive_url":"https://api.github.com/repos/rolandwalker/homebrew-versions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rolandwalker/homebrew-versions/downloads","issues_url":"https://api.github.com/repos/rolandwalker/homebrew-versions/issues{/number}","pulls_url":"https://api.github.com/repos/rolandwalker/homebrew-versions/pulls{/number}","milestones_url":"https://api.github.com/repos/rolandwalker/homebrew-versions/milestones{/number}","notifications_url":"https://api.github.com/repos/rolandwalker/homebrew-versions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rolandwalker/homebrew-versions/labels{/name}","releases_url":"https://api.github.com/repos/rolandwalker/homebrew-versions/releases{/id}","created_at":"2013-11-19T14:40:31Z","updated_at":"2014-08-02T15:20:31Z","pushed_at":"2014-09-26T12:46:23Z","git_url":"git://github.com/rolandwalker/homebrew-versions.git","ssh_url":"git@github.com:rolandwalker/homebrew-versions.git","clone_url":"https://github.com/rolandwalker/homebrew-versions.git","svn_url":"https://github.com/rolandwalker/homebrew-versions","homepage":"","size":1249,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"caskroom:master","ref":"master","sha":"550dfee7b0eed4f41c6fef3f95d75334e33169fb","user":{"login":"caskroom","id":5647711,"avatar_url":"https://avatars.githubusercontent.com/u/5647711?v=2","gravatar_id":"","url":"https://api.github.com/users/caskroom","html_url":"https://github.com/caskroom","followers_url":"https://api.github.com/users/caskroom/followers","following_url":"https://api.github.com/users/caskroom/following{/other_user}","gists_url":"https://api.github.com/users/caskroom/gists{/gist_id}","starred_url":"https://api.github.com/users/caskroom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskroom/subscriptions","organizations_url":"https://api.github.com/users/caskroom/orgs","repos_url":"https://api.github.com/users/caskroom/repos","events_url":"https://api.github.com/users/caskroom/events{/privacy}","received_events_url":"https://api.github.com/users/caskroom/received_events","type":"Organization","site_admin":false},"repo":{"id":14159669,"name":"homebrew-versions","full_name":"caskroom/homebrew-versions","owner":{"login":"caskroom","id":5647711,"avatar_url":"https://avatars.githubusercontent.com/u/5647711?v=2","gravatar_id":"","url":"https://api.github.com/users/caskroom","html_url":"https://github.com/caskroom","followers_url":"https://api.github.com/users/caskroom/followers","following_url":"https://api.github.com/users/caskroom/following{/other_user}","gists_url":"https://api.github.com/users/caskroom/gists{/gist_id}","starred_url":"https://api.github.com/users/caskroom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskroom/subscriptions","organizations_url":"https://api.github.com/users/caskroom/orgs","repos_url":"https://api.github.com/users/caskroom/repos","events_url":"https://api.github.com/users/caskroom/events{/privacy}","received_events_url":"https://api.github.com/users/caskroom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caskroom/homebrew-versions","description":"Alternate versions of Casks for homebrew-cask","fork":false,"url":"https://api.github.com/repos/caskroom/homebrew-versions","forks_url":"https://api.github.com/repos/caskroom/homebrew-versions/forks","keys_url":"https://api.github.com/repos/caskroom/homebrew-versions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caskroom/homebrew-versions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caskroom/homebrew-versions/teams","hooks_url":"https://api.github.com/repos/caskroom/homebrew-versions/hooks","issue_events_url":"https://api.github.com/repos/caskroom/homebrew-versions/issues/events{/number}","events_url":"https://api.github.com/repos/caskroom/homebrew-versions/events","assignees_url":"https://api.github.com/repos/caskroom/homebrew-versions/assignees{/user}","branches_url":"https://api.github.com/repos/caskroom/homebrew-versions/branches{/branch}","tags_url":"https://api.github.com/repos/caskroom/homebrew-versions/tags","blobs_url":"https://api.github.com/repos/caskroom/homebrew-versions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caskroom/homebrew-versions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caskroom/homebrew-versions/git/refs{/sha}","trees_url":"https://api.github.com/repos/caskroom/homebrew-versions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caskroom/homebrew-versions/statuses/{sha}","languages_url":"https://api.github.com/repos/caskroom/homebrew-versions/languages","stargazers_url":"https://api.github.com/repos/caskroom/homebrew-versions/stargazers","contributors_url":"https://api.github.com/repos/caskroom/homebrew-versions/contributors","subscribers_url":"https://api.github.com/repos/caskroom/homebrew-versions/subscribers","subscription_url":"https://api.github.com/repos/caskroom/homebrew-versions/subscription","commits_url":"https://api.github.com/repos/caskroom/homebrew-versions/commits{/sha}","git_commits_url":"https://api.github.com/repos/caskroom/homebrew-versions/git/commits{/sha}","comments_url":"https://api.github.com/repos/caskroom/homebrew-versions/comments{/number}","issue_comment_url":"https://api.github.com/repos/caskroom/homebrew-versions/issues/comments/{number}","contents_url":"https://api.github.com/repos/caskroom/homebrew-versions/contents/{+path}","compare_url":"https://api.github.com/repos/caskroom/homebrew-versions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caskroom/homebrew-versions/merges","archive_url":"https://api.github.com/repos/caskroom/homebrew-versions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caskroom/homebrew-versions/downloads","issues_url":"https://api.github.com/repos/caskroom/homebrew-versions/issues{/number}","pulls_url":"https://api.github.com/repos/caskroom/homebrew-versions/pulls{/number}","milestones_url":"https://api.github.com/repos/caskroom/homebrew-versions/milestones{/number}","notifications_url":"https://api.github.com/repos/caskroom/homebrew-versions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caskroom/homebrew-versions/labels{/name}","releases_url":"https://api.github.com/repos/caskroom/homebrew-versions/releases{/id}","created_at":"2013-11-06T01:27:56Z","updated_at":"2014-09-25T08:00:42Z","pushed_at":"2014-09-26T12:46:22Z","git_url":"git://github.com/caskroom/homebrew-versions.git","ssh_url":"git@github.com:caskroom/homebrew-versions.git","clone_url":"https://github.com/caskroom/homebrew-versions.git","svn_url":"https://github.com/caskroom/homebrew-versions","homepage":"http://caskroom.io","size":5944,"stargazers_count":85,"watchers_count":85,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":122,"mirror_url":null,"open_issues_count":12,"forks":122,"open_issues":12,"watchers":85,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/caskroom/homebrew-versions/pulls/439"},"html":{"href":"https://github.com/caskroom/homebrew-versions/pull/439"},"issue":{"href":"https://api.github.com/repos/caskroom/homebrew-versions/issues/439"},"comments":{"href":"https://api.github.com/repos/caskroom/homebrew-versions/issues/439/comments"},"review_comments":{"href":"https://api.github.com/repos/caskroom/homebrew-versions/pulls/439/comments"},"review_comment":{"href":"https://api.github.com/repos/caskroom/homebrew-versions/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/caskroom/homebrew-versions/pulls/439/commits"},"statuses":{"href":"https://api.github.com/repos/caskroom/homebrew-versions/statuses/c0673455c1096dd37b3b61c28ecb635fca5fb4e0"}}}}