GitHub PullRequestReviewCommentEvent at 2014-07-30 15:01:58
Repository: pandas
Actor: cpcloud
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/pydata/pandas/pulls/comments/15588997","id":15588997,"diff_hunk":"@@ -2976,8 +2964,11 @@ def add_indices():\n                 if res:\n                     add_indices()\n             else:\n-                if getattr(res, 'ndim', None) == 1:\n-                    val = res.ravel()[0]\n+                if np.isscalar(res) or len(res) == 1:\n+                    try:\n+                        val = res.item()","path":"pandas/core/groupby.py","position":38,"original_position":38,"commit_id":"e5c6e82731c7774167d8d49e3d85bc76f0df479b","original_commit_id":"e5c6e82731c7774167d8d49e3d85bc76f0df479b","user":{"login":"cpcloud","id":417981,"avatar_url":"https://avatars.githubusercontent.com/u/417981?v=1","gravatar_id":"4f4c10a585c476957ab989299ec4dcb9","url":"https://api.github.com/users/cpcloud","html_url":"https://github.com/cpcloud","followers_url":"https://api.github.com/users/cpcloud/followers","following_url":"https://api.github.com/users/cpcloud/following{/other_user}","gists_url":"https://api.github.com/users/cpcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/cpcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpcloud/subscriptions","organizations_url":"https://api.github.com/users/cpcloud/orgs","repos_url":"https://api.github.com/users/cpcloud/repos","events_url":"https://api.github.com/users/cpcloud/events{/privacy}","received_events_url":"https://api.github.com/users/cpcloud/received_events","type":"User","site_admin":false},"body":"i'm using `squeeze` because then i don't have to catch the `ValueError`, but yep that's what i'm talking about","created_at":"2014-07-30T15:01:58Z","updated_at":"2014-07-30T15:01:58Z","html_url":"https://github.com/pydata/pandas/pull/7871#discussion_r15588997","pull_request_url":"https://api.github.com/repos/pydata/pandas/pulls/7871","_links":{"self":{"href":"https://api.github.com/repos/pydata/pandas/pulls/comments/15588997"},"html":{"href":"https://github.com/pydata/pandas/pull/7871#discussion_r15588997"},"pull_request":{"href":"https://api.github.com/repos/pydata/pandas/pulls/7871"}}},"pull_request":{"url":"https://api.github.com/repos/pydata/pandas/pulls/7871","id":19042325,"html_url":"https://github.com/pydata/pandas/pull/7871","diff_url":"https://github.com/pydata/pandas/pull/7871.diff","patch_url":"https://github.com/pydata/pandas/pull/7871.patch","issue_url":"https://api.github.com/repos/pydata/pandas/issues/7871","number":7871,"state":"open","title":"BUG/FIX: groupby should raise on multi-valued filter","user":{"login":"cpcloud","id":417981,"avatar_url":"https://avatars.githubusercontent.com/u/417981?v=1","gravatar_id":"4f4c10a585c476957ab989299ec4dcb9","url":"https://api.github.com/users/cpcloud","html_url":"https://github.com/cpcloud","followers_url":"https://api.github.com/users/cpcloud/followers","following_url":"https://api.github.com/users/cpcloud/following{/other_user}","gists_url":"https://api.github.com/users/cpcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/cpcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpcloud/subscriptions","organizations_url":"https://api.github.com/users/cpcloud/orgs","repos_url":"https://api.github.com/users/cpcloud/repos","events_url":"https://api.github.com/users/cpcloud/events{/privacy}","received_events_url":"https://api.github.com/users/cpcloud/received_events","type":"User","site_admin":false},"body":"closes #7870","created_at":"2014-07-29T17:43:20Z","updated_at":"2014-07-30T15:01:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7d23417437a69207d7d9f9b4d2cd96df3ed46ba0","assignee":{"login":"cpcloud","id":417981,"avatar_url":"https://avatars.githubusercontent.com/u/417981?v=1","gravatar_id":"4f4c10a585c476957ab989299ec4dcb9","url":"https://api.github.com/users/cpcloud","html_url":"https://github.com/cpcloud","followers_url":"https://api.github.com/users/cpcloud/followers","following_url":"https://api.github.com/users/cpcloud/following{/other_user}","gists_url":"https://api.github.com/users/cpcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/cpcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpcloud/subscriptions","organizations_url":"https://api.github.com/users/cpcloud/orgs","repos_url":"https://api.github.com/users/cpcloud/repos","events_url":"https://api.github.com/users/cpcloud/events{/privacy}","received_events_url":"https://api.github.com/users/cpcloud/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/pydata/pandas/milestones/28","labels_url":"https://api.github.com/repos/pydata/pandas/milestones/28/labels","id":711567,"number":28,"title":"0.15.0","description":"after 0.14.1 of course!","creator":{"login":"jreback","id":953992,"avatar_url":"https://avatars.githubusercontent.com/u/953992?v=1","gravatar_id":"b2833d485728ee2f603802242ebc9826","url":"https://api.github.com/users/jreback","html_url":"https://github.com/jreback","followers_url":"https://api.github.com/users/jreback/followers","following_url":"https://api.github.com/users/jreback/following{/other_user}","gists_url":"https://api.github.com/users/jreback/gists{/gist_id}","starred_url":"https://api.github.com/users/jreback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreback/subscriptions","organizations_url":"https://api.github.com/users/jreback/orgs","repos_url":"https://api.github.com/users/jreback/repos","events_url":"https://api.github.com/users/jreback/events{/privacy}","received_events_url":"https://api.github.com/users/jreback/received_events","type":"User","site_admin":false},"open_issues":144,"closed_issues":79,"state":"open","created_at":"2014-07-06T18:44:54Z","updated_at":"2014-07-30T12:33:56Z","due_on":"2014-09-30T07:00:00Z"},"commits_url":"https://api.github.com/repos/pydata/pandas/pulls/7871/commits","review_comments_url":"https://api.github.com/repos/pydata/pandas/pulls/7871/comments","review_comment_url":"https://api.github.com/repos/pydata/pandas/pulls/comments/{number}","comments_url":"https://api.github.com/repos/pydata/pandas/issues/7871/comments","statuses_url":"https://api.github.com/repos/pydata/pandas/statuses/e5c6e82731c7774167d8d49e3d85bc76f0df479b","head":{"label":"cpcloud:groupby-filter-fix","ref":"groupby-filter-fix","sha":"e5c6e82731c7774167d8d49e3d85bc76f0df479b","user":{"login":"cpcloud","id":417981,"avatar_url":"https://avatars.githubusercontent.com/u/417981?v=1","gravatar_id":"4f4c10a585c476957ab989299ec4dcb9","url":"https://api.github.com/users/cpcloud","html_url":"https://github.com/cpcloud","followers_url":"https://api.github.com/users/cpcloud/followers","following_url":"https://api.github.com/users/cpcloud/following{/other_user}","gists_url":"https://api.github.com/users/cpcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/cpcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpcloud/subscriptions","organizations_url":"https://api.github.com/users/cpcloud/orgs","repos_url":"https://api.github.com/users/cpcloud/repos","events_url":"https://api.github.com/users/cpcloud/events{/privacy}","received_events_url":"https://api.github.com/users/cpcloud/received_events","type":"User","site_admin":false},"repo":{"id":7511697,"name":"pandas","full_name":"cpcloud/pandas","owner":{"login":"cpcloud","id":417981,"avatar_url":"https://avatars.githubusercontent.com/u/417981?v=1","gravatar_id":"4f4c10a585c476957ab989299ec4dcb9","url":"https://api.github.com/users/cpcloud","html_url":"https://github.com/cpcloud","followers_url":"https://api.github.com/users/cpcloud/followers","following_url":"https://api.github.com/users/cpcloud/following{/other_user}","gists_url":"https://api.github.com/users/cpcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/cpcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpcloud/subscriptions","organizations_url":"https://api.github.com/users/cpcloud/orgs","repos_url":"https://api.github.com/users/cpcloud/repos","events_url":"https://api.github.com/users/cpcloud/events{/privacy}","received_events_url":"https://api.github.com/users/cpcloud/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cpcloud/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":true,"url":"https://api.github.com/repos/cpcloud/pandas","forks_url":"https://api.github.com/repos/cpcloud/pandas/forks","keys_url":"https://api.github.com/repos/cpcloud/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cpcloud/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cpcloud/pandas/teams","hooks_url":"https://api.github.com/repos/cpcloud/pandas/hooks","issue_events_url":"https://api.github.com/repos/cpcloud/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/cpcloud/pandas/events","assignees_url":"https://api.github.com/repos/cpcloud/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/cpcloud/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/cpcloud/pandas/tags","blobs_url":"https://api.github.com/repos/cpcloud/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cpcloud/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cpcloud/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/cpcloud/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cpcloud/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/cpcloud/pandas/languages","stargazers_url":"https://api.github.com/repos/cpcloud/pandas/stargazers","contributors_url":"https://api.github.com/repos/cpcloud/pandas/contributors","subscribers_url":"https://api.github.com/repos/cpcloud/pandas/subscribers","subscription_url":"https://api.github.com/repos/cpcloud/pandas/subscription","commits_url":"https://api.github.com/repos/cpcloud/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/cpcloud/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/cpcloud/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/cpcloud/pandas/issues/comments/{number}","contents_url":"https://api.github.com/repos/cpcloud/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/cpcloud/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cpcloud/pandas/merges","archive_url":"https://api.github.com/repos/cpcloud/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cpcloud/pandas/downloads","issues_url":"https://api.github.com/repos/cpcloud/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/cpcloud/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/cpcloud/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/cpcloud/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cpcloud/pandas/labels{/name}","releases_url":"https://api.github.com/repos/cpcloud/pandas/releases{/id}","created_at":"2013-01-08T23:55:03Z","updated_at":"2014-06-26T12:52:07Z","pushed_at":"2014-07-29T17:42:53Z","git_url":"git://github.com/cpcloud/pandas.git","ssh_url":"git@github.com:cpcloud/pandas.git","clone_url":"https://github.com/cpcloud/pandas.git","svn_url":"https://github.com/cpcloud/pandas","homepage":"http://pandas.pydata.org","size":41296,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pydata:master","ref":"master","sha":"381a2896e44e546c3a77d13a911e1ad41c168ee7","user":{"login":"pydata","id":1284191,"avatar_url":"https://avatars.githubusercontent.com/u/1284191?v=1","gravatar_id":"0b41e491d21e0e2e054d9c1b2d72ad59","url":"https://api.github.com/users/pydata","html_url":"https://github.com/pydata","followers_url":"https://api.github.com/users/pydata/followers","following_url":"https://api.github.com/users/pydata/following{/other_user}","gists_url":"https://api.github.com/users/pydata/gists{/gist_id}","starred_url":"https://api.github.com/users/pydata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pydata/subscriptions","organizations_url":"https://api.github.com/users/pydata/orgs","repos_url":"https://api.github.com/users/pydata/repos","events_url":"https://api.github.com/users/pydata/events{/privacy}","received_events_url":"https://api.github.com/users/pydata/received_events","type":"Organization","site_admin":false},"repo":{"id":858127,"name":"pandas","full_name":"pydata/pandas","owner":{"login":"pydata","id":1284191,"avatar_url":"https://avatars.githubusercontent.com/u/1284191?v=1","gravatar_id":"0b41e491d21e0e2e054d9c1b2d72ad59","url":"https://api.github.com/users/pydata","html_url":"https://github.com/pydata","followers_url":"https://api.github.com/users/pydata/followers","following_url":"https://api.github.com/users/pydata/following{/other_user}","gists_url":"https://api.github.com/users/pydata/gists{/gist_id}","starred_url":"https://api.github.com/users/pydata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pydata/subscriptions","organizations_url":"https://api.github.com/users/pydata/orgs","repos_url":"https://api.github.com/users/pydata/repos","events_url":"https://api.github.com/users/pydata/events{/privacy}","received_events_url":"https://api.github.com/users/pydata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pydata/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":false,"url":"https://api.github.com/repos/pydata/pandas","forks_url":"https://api.github.com/repos/pydata/pandas/forks","keys_url":"https://api.github.com/repos/pydata/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pydata/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pydata/pandas/teams","hooks_url":"https://api.github.com/repos/pydata/pandas/hooks","issue_events_url":"https://api.github.com/repos/pydata/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/pydata/pandas/events","assignees_url":"https://api.github.com/repos/pydata/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/pydata/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/pydata/pandas/tags","blobs_url":"https://api.github.com/repos/pydata/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pydata/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pydata/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/pydata/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pydata/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/pydata/pandas/languages","stargazers_url":"https://api.github.com/repos/pydata/pandas/stargazers","contributors_url":"https://api.github.com/repos/pydata/pandas/contributors","subscribers_url":"https://api.github.com/repos/pydata/pandas/subscribers","subscription_url":"https://api.github.com/repos/pydata/pandas/subscription","commits_url":"https://api.github.com/repos/pydata/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/pydata/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/pydata/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/pydata/pandas/issues/comments/{number}","contents_url":"https://api.github.com/repos/pydata/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/pydata/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pydata/pandas/merges","archive_url":"https://api.github.com/repos/pydata/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pydata/pandas/downloads","issues_url":"https://api.github.com/repos/pydata/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/pydata/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/pydata/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/pydata/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pydata/pandas/labels{/name}","releases_url":"https://api.github.com/repos/pydata/pandas/releases{/id}","created_at":"2010-08-24T01:37:33Z","updated_at":"2014-07-30T11:39:01Z","pushed_at":"2014-07-29T22:44:36Z","git_url":"git://github.com/pydata/pandas.git","ssh_url":"git@github.com:pydata/pandas.git","clone_url":"https://github.com/pydata/pandas.git","svn_url":"https://github.com/pydata/pandas","homepage":"http://pandas.pydata.org","size":81512,"stargazers_count":3235,"watchers_count":3235,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1043,"mirror_url":null,"open_issues_count":961,"forks":1043,"open_issues":961,"watchers":3235,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pydata/pandas/pulls/7871"},"html":{"href":"https://github.com/pydata/pandas/pull/7871"},"issue":{"href":"https://api.github.com/repos/pydata/pandas/issues/7871"},"comments":{"href":"https://api.github.com/repos/pydata/pandas/issues/7871/comments"},"review_comments":{"href":"https://api.github.com/repos/pydata/pandas/pulls/7871/comments"},"review_comment":{"href":"https://api.github.com/repos/pydata/pandas/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/pydata/pandas/pulls/7871/commits"},"statuses":{"href":"https://api.github.com/repos/pydata/pandas/statuses/e5c6e82731c7774167d8d49e3d85bc76f0df479b"}}}}