GitHub PullRequestReviewCommentEvent at 2014-05-29 16:32:55
Repository: voltdb
Actor: nshi
Payload: {"comment":{"url":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments/13189802","id":13189802,"diff_hunk":"@@ -151,25 +158,30 @@ public void run() {\n \n             });\n         }\n-    };\n \n-    private void rollToNextGeneration() throws Exception {\n+    }\n+\n+    private void rollToNextGeneration(ExportGeneration drainedGeneration) throws Exception {\n         ExportDataProcessor newProcessor = null;\n         ExportDataProcessor oldProcessor = null;\n-        ExportGeneration oldGeneration = null;\n-        synchronized (ExportManager.this) {\n-             oldGeneration = m_generations.firstEntry().getValue();\n-\n-            m_generationGhosts.add(m_generations.remove(m_generations.firstEntry().getKey()).m_timestamp);\n-            exportLog.info(\"Finished draining generation \" + oldGeneration.m_timestamp);\n+        synchronized (ExportManager.class) {","path":"src/frontend/org/voltdb/export/ExportManager.java","position":43,"original_position":43,"commit_id":"f51f7d2722284c8e9bd6cc86a817643801368a88","original_commit_id":"f51f7d2722284c8e9bd6cc86a817643801368a88","user":{"login":"nshi","id":10992,"avatar_url":"https://avatars.githubusercontent.com/u/10992?","gravatar_id":"31d6c9f1b851446a43faf4afe5bbc8af","url":"https://api.github.com/users/nshi","html_url":"https://github.com/nshi","followers_url":"https://api.github.com/users/nshi/followers","following_url":"https://api.github.com/users/nshi/following{/other_user}","gists_url":"https://api.github.com/users/nshi/gists{/gist_id}","starred_url":"https://api.github.com/users/nshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nshi/subscriptions","organizations_url":"https://api.github.com/users/nshi/orgs","repos_url":"https://api.github.com/users/nshi/repos","events_url":"https://api.github.com/users/nshi/events{/privacy}","received_events_url":"https://api.github.com/users/nshi/received_events","type":"User","site_admin":false},"body":"The synchronization here looks weird. It was synchronizing on the ExportManager instance before, but now it's synchronizing on the class. Typo?","created_at":"2014-05-29T16:32:55Z","updated_at":"2014-05-29T16:32:55Z","html_url":"https://github.com/VoltDB/voltdb/pull/1393#discussion_r13189802","pull_request_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/1393","_links":{"self":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments/13189802"},"html":{"href":"https://github.com/VoltDB/voltdb/pull/1393#discussion_r13189802"},"pull_request":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/1393"}}}}