GitHub PullRequestEvent at 2014-04-26 19:58:11
Repository: end-dash
Actor: devmanhinton
Payload: {"action":"opened","number":197,"pull_request":{"url":"https://api.github.com/repos/Amicus/end-dash/pulls/197","id":15205694,"html_url":"https://github.com/Amicus/end-dash/pull/197","diff_url":"https://github.com/Amicus/end-dash/pull/197.diff","patch_url":"https://github.com/Amicus/end-dash/pull/197.patch","issue_url":"https://api.github.com/repos/Amicus/end-dash/issues/197","number":197,"state":"open","title":"Fix trigger dom issue","user":{"login":"devmanhinton","id":1439051,"avatar_url":"https://avatars.githubusercontent.com/u/1439051?","gravatar_id":"acfe338143ba76bd52d16e99e36a682e","url":"https://api.github.com/users/devmanhinton","html_url":"https://github.com/devmanhinton","followers_url":"https://api.github.com/users/devmanhinton/followers","following_url":"https://api.github.com/users/devmanhinton/following{/other_user}","gists_url":"https://api.github.com/users/devmanhinton/gists{/gist_id}","starred_url":"https://api.github.com/users/devmanhinton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devmanhinton/subscriptions","organizations_url":"https://api.github.com/users/devmanhinton/orgs","repos_url":"https://api.github.com/users/devmanhinton/repos","events_url":"https://api.github.com/users/devmanhinton/events{/privacy}","received_events_url":"https://api.github.com/users/devmanhinton/received_events","type":"User","site_admin":false},"body":"@tobowers @pbadger @xcoderzach \r\n\r\nThis stops a `model.set` on the first setting of the DOM when binding the dome\r\n\r\na) Its not necessary (we are circularly setting in most cases or else setting `undefined` to `\"\"`). This is because we have the model listen to the DOM and then we call `this.setFrom(variableName)`. This sets the `el` equal to the model value of the variable. This then triggers a DOM `change` (sometimes, if it doesn't that case is handled by setting `firstSetHappening` to false) which sets the property of the `el` back on the model d'oh! If the attribute on the model is `undefined`, we set that on the `el` but calling `el.val()` on a non-value input returns \"\". Thus we change `undefined` to `\"\"`. \r\n\r\nIn both cases, the listener for DOM changes does `model.set(key, that.el.val(), {validate: true})` Yikes! This calls Backbone.Model.validate (thus are validators, like on the registration page, when we don't want to). Solution is, use a boolean to know when its the first set and when its not. There are probably edge cases here, so please look for those.\r\n\r\nCHA-:ear:s","created_at":"2014-04-26T19:58:11Z","updated_at":"2014-04-26T19:58:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Amicus/end-dash/pulls/197/commits","review_comments_url":"https://api.github.com/repos/Amicus/end-dash/pulls/197/comments","review_comment_url":"https://api.github.com/repos/Amicus/end-dash/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Amicus/end-dash/issues/197/comments","statuses_url":"https://api.github.com/repos/Amicus/end-dash/statuses/c4ef63192cdbe6481048dd65367575fc8eafa835","head":{"label":"Amicus:fix-trigger-dom-issue","ref":"fix-trigger-dom-issue","sha":"c4ef63192cdbe6481048dd65367575fc8eafa835","user":{"login":"Amicus","id":1295648,"avatar_url":"https://avatars.githubusercontent.com/u/1295648?","gravatar_id":"4e56bbc05f6c26a1e42b5ef191f89cb4","url":"https://api.github.com/users/Amicus","html_url":"https://github.com/Amicus","followers_url":"https://api.github.com/users/Amicus/followers","following_url":"https://api.github.com/users/Amicus/following{/other_user}","gists_url":"https://api.github.com/users/Amicus/gists{/gist_id}","starred_url":"https://api.github.com/users/Amicus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Amicus/subscriptions","organizations_url":"https://api.github.com/users/Amicus/orgs","repos_url":"https://api.github.com/users/Amicus/repos","events_url":"https://api.github.com/users/Amicus/events{/privacy}","received_events_url":"https://api.github.com/users/Amicus/received_events","type":"Organization","site_admin":false},"repo":{"id":6148695,"name":"end-dash","full_name":"Amicus/end-dash","owner":{"login":"Amicus","id":1295648,"avatar_url":"https://avatars.githubusercontent.com/u/1295648?","gravatar_id":"4e56bbc05f6c26a1e42b5ef191f89cb4","url":"https://api.github.com/users/Amicus","html_url":"https://github.com/Amicus","followers_url":"https://api.github.com/users/Amicus/followers","following_url":"https://api.github.com/users/Amicus/following{/other_user}","gists_url":"https://api.github.com/users/Amicus/gists{/gist_id}","starred_url":"https://api.github.com/users/Amicus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Amicus/subscriptions","organizations_url":"https://api.github.com/users/Amicus/orgs","repos_url":"https://api.github.com/users/Amicus/repos","events_url":"https://api.github.com/users/Amicus/events{/privacy}","received_events_url":"https://api.github.com/users/Amicus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Amicus/end-dash","description":"templates with a dash at the end","fork":false,"url":"https://api.github.com/repos/Amicus/end-dash","forks_url":"https://api.github.com/repos/Amicus/end-dash/forks","keys_url":"https://api.github.com/repos/Amicus/end-dash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Amicus/end-dash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Amicus/end-dash/teams","hooks_url":"https://api.github.com/repos/Amicus/end-dash/hooks","issue_events_url":"https://api.github.com/repos/Amicus/end-dash/issues/events{/number}","events_url":"https://api.github.com/repos/Amicus/end-dash/events","assignees_url":"https://api.github.com/repos/Amicus/end-dash/assignees{/user}","branches_url":"https://api.github.com/repos/Amicus/end-dash/branches{/branch}","tags_url":"https://api.github.com/repos/Amicus/end-dash/tags","blobs_url":"https://api.github.com/repos/Amicus/end-dash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Amicus/end-dash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Amicus/end-dash/git/refs{/sha}","trees_url":"https://api.github.com/repos/Amicus/end-dash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Amicus/end-dash/statuses/{sha}","languages_url":"https://api.github.com/repos/Amicus/end-dash/languages","stargazers_url":"https://api.github.com/repos/Amicus/end-dash/stargazers","contributors_url":"https://api.github.com/repos/Amicus/end-dash/contributors","subscribers_url":"https://api.github.com/repos/Amicus/end-dash/subscribers","subscription_url":"https://api.github.com/repos/Amicus/end-dash/subscription","commits_url":"https://api.github.com/repos/Amicus/end-dash/commits{/sha}","git_commits_url":"https://api.github.com/repos/Amicus/end-dash/git/commits{/sha}","comments_url":"https://api.github.com/repos/Amicus/end-dash/comments{/number}","issue_comment_url":"https://api.github.com/repos/Amicus/end-dash/issues/comments/{number}","contents_url":"https://api.github.com/repos/Amicus/end-dash/contents/{+path}","compare_url":"https://api.github.com/repos/Amicus/end-dash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Amicus/end-dash/merges","archive_url":"https://api.github.com/repos/Amicus/end-dash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Amicus/end-dash/downloads","issues_url":"https://api.github.com/repos/Amicus/end-dash/issues{/number}","pulls_url":"https://api.github.com/repos/Amicus/end-dash/pulls{/number}","milestones_url":"https://api.github.com/repos/Amicus/end-dash/milestones{/number}","notifications_url":"https://api.github.com/repos/Amicus/end-dash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Amicus/end-dash/labels{/name}","releases_url":"https://api.github.com/repos/Amicus/end-dash/releases{/id}","created_at":"2012-10-09T22:11:42Z","updated_at":"2014-04-26T19:58:11Z","pushed_at":"2014-04-26T19:52:52Z","git_url":"git://github.com/Amicus/end-dash.git","ssh_url":"git@github.com:Amicus/end-dash.git","clone_url":"https://github.com/Amicus/end-dash.git","svn_url":"https://github.com/Amicus/end-dash","homepage":"www.enddash.com","size":7193,"stargazers_count":271,"watchers_count":271,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":16,"mirror_url":null,"open_issues_count":37,"forks":16,"open_issues":37,"watchers":271,"default_branch":"master"}},"base":{"label":"Amicus:master","ref":"master","sha":"36b09370e2b33ae1023d57e064c8295143ee260f","user":{"login":"Amicus","id":1295648,"avatar_url":"https://avatars.githubusercontent.com/u/1295648?","gravatar_id":"4e56bbc05f6c26a1e42b5ef191f89cb4","url":"https://api.github.com/users/Amicus","html_url":"https://github.com/Amicus","followers_url":"https://api.github.com/users/Amicus/followers","following_url":"https://api.github.com/users/Amicus/following{/other_user}","gists_url":"https://api.github.com/users/Amicus/gists{/gist_id}","starred_url":"https://api.github.com/users/Amicus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Amicus/subscriptions","organizations_url":"https://api.github.com/users/Amicus/orgs","repos_url":"https://api.github.com/users/Amicus/repos","events_url":"https://api.github.com/users/Amicus/events{/privacy}","received_events_url":"https://api.github.com/users/Amicus/received_events","type":"Organization","site_admin":false},"repo":{"id":6148695,"name":"end-dash","full_name":"Amicus/end-dash","owner":{"login":"Amicus","id":1295648,"avatar_url":"https://avatars.githubusercontent.com/u/1295648?","gravatar_id":"4e56bbc05f6c26a1e42b5ef191f89cb4","url":"https://api.github.com/users/Amicus","html_url":"https://github.com/Amicus","followers_url":"https://api.github.com/users/Amicus/followers","following_url":"https://api.github.com/users/Amicus/following{/other_user}","gists_url":"https://api.github.com/users/Amicus/gists{/gist_id}","starred_url":"https://api.github.com/users/Amicus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Amicus/subscriptions","organizations_url":"https://api.github.com/users/Amicus/orgs","repos_url":"https://api.github.com/users/Amicus/repos","events_url":"https://api.github.com/users/Amicus/events{/privacy}","received_events_url":"https://api.github.com/users/Amicus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Amicus/end-dash","description":"templates with a dash at the end","fork":false,"url":"https://api.github.com/repos/Amicus/end-dash","forks_url":"https://api.github.com/repos/Amicus/end-dash/forks","keys_url":"https://api.github.com/repos/Amicus/end-dash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Amicus/end-dash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Amicus/end-dash/teams","hooks_url":"https://api.github.com/repos/Amicus/end-dash/hooks","issue_events_url":"https://api.github.com/repos/Amicus/end-dash/issues/events{/number}","events_url":"https://api.github.com/repos/Amicus/end-dash/events","assignees_url":"https://api.github.com/repos/Amicus/end-dash/assignees{/user}","branches_url":"https://api.github.com/repos/Amicus/end-dash/branches{/branch}","tags_url":"https://api.github.com/repos/Amicus/end-dash/tags","blobs_url":"https://api.github.com/repos/Amicus/end-dash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Amicus/end-dash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Amicus/end-dash/git/refs{/sha}","trees_url":"https://api.github.com/repos/Amicus/end-dash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Amicus/end-dash/statuses/{sha}","languages_url":"https://api.github.com/repos/Amicus/end-dash/languages","stargazers_url":"https://api.github.com/repos/Amicus/end-dash/stargazers","contributors_url":"https://api.github.com/repos/Amicus/end-dash/contributors","subscribers_url":"https://api.github.com/repos/Amicus/end-dash/subscribers","subscription_url":"https://api.github.com/repos/Amicus/end-dash/subscription","commits_url":"https://api.github.com/repos/Amicus/end-dash/commits{/sha}","git_commits_url":"https://api.github.com/repos/Amicus/end-dash/git/commits{/sha}","comments_url":"https://api.github.com/repos/Amicus/end-dash/comments{/number}","issue_comment_url":"https://api.github.com/repos/Amicus/end-dash/issues/comments/{number}","contents_url":"https://api.github.com/repos/Amicus/end-dash/contents/{+path}","compare_url":"https://api.github.com/repos/Amicus/end-dash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Amicus/end-dash/merges","archive_url":"https://api.github.com/repos/Amicus/end-dash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Amicus/end-dash/downloads","issues_url":"https://api.github.com/repos/Amicus/end-dash/issues{/number}","pulls_url":"https://api.github.com/repos/Amicus/end-dash/pulls{/number}","milestones_url":"https://api.github.com/repos/Amicus/end-dash/milestones{/number}","notifications_url":"https://api.github.com/repos/Amicus/end-dash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Amicus/end-dash/labels{/name}","releases_url":"https://api.github.com/repos/Amicus/end-dash/releases{/id}","created_at":"2012-10-09T22:11:42Z","updated_at":"2014-04-26T19:58:11Z","pushed_at":"2014-04-26T19:52:52Z","git_url":"git://github.com/Amicus/end-dash.git","ssh_url":"git@github.com:Amicus/end-dash.git","clone_url":"https://github.com/Amicus/end-dash.git","svn_url":"https://github.com/Amicus/end-dash","homepage":"www.enddash.com","size":7193,"stargazers_count":271,"watchers_count":271,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":16,"mirror_url":null,"open_issues_count":37,"forks":16,"open_issues":37,"watchers":271,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Amicus/end-dash/pulls/197"},"html":{"href":"https://github.com/Amicus/end-dash/pull/197"},"issue":{"href":"https://api.github.com/repos/Amicus/end-dash/issues/197"},"comments":{"href":"https://api.github.com/repos/Amicus/end-dash/issues/197/comments"},"review_comments":{"href":"https://api.github.com/repos/Amicus/end-dash/pulls/197/comments"},"review_comment":{"href":"https://api.github.com/repos/Amicus/end-dash/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Amicus/end-dash/pulls/197/commits"},"statuses":{"href":"https://api.github.com/repos/Amicus/end-dash/statuses/c4ef63192cdbe6481048dd65367575fc8eafa835"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":8,"deletions":0,"changed_files":1}}