GitHub PullRequestReviewCommentEvent at 2014-09-29 13:40:14
Repository: snowcrash
Actor: zdne
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/apiaryio/snowcrash/pulls/comments/18153716","id":18153716,"diff_hunk":"@@ -65,50 +76,104 @@ namespace snowcrash {\n         static MarkdownNodeIterator processNestedSection(const MarkdownNodeIterator& node,\n                                                          const MarkdownNodes& siblings,\n                                                          SectionParserData& pd,\n-                                                         Report& report,\n-                                                         Action& out) {\n+                                                         ParseResult<Action>& out) {\n \n             SectionType sectionType = pd.sectionContext();\n             MarkdownNodeIterator cur = node;\n-            Payload payload;\n             std::stringstream ss;\n \n             mdp::CharactersRangeSet sourceMap = mdp::BytesRangeSetToCharactersRangeSet(node->sourceMap, pd.sourceData);\n \n             switch (sectionType) {\n                 case ParametersSectionType:\n-                    return ParametersParser::parse(node, siblings, pd, report, out.parameters);\n+                {\n+                    ParseResult<Parameters> parameters;\n+                    parameters.node = out.node.parameters;\n+                    parameters.sourceMap = out.sourceMap.parameters;","path":"src/ActionParser.h","position":68,"original_position":68,"commit_id":"296f787e1480c0678fe0a5302900df00d75ca952","original_commit_id":"861df504a117a2d436b0beffa33f30190a934c25","user":{"login":"zdne","id":613617,"avatar_url":"https://avatars.githubusercontent.com/u/613617?v=2","gravatar_id":"","url":"https://api.github.com/users/zdne","html_url":"https://github.com/zdne","followers_url":"https://api.github.com/users/zdne/followers","following_url":"https://api.github.com/users/zdne/following{/other_user}","gists_url":"https://api.github.com/users/zdne/gists{/gist_id}","starred_url":"https://api.github.com/users/zdne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zdne/subscriptions","organizations_url":"https://api.github.com/users/zdne/orgs","repos_url":"https://api.github.com/users/zdne/repos","events_url":"https://api.github.com/users/zdne/events{/privacy}","received_events_url":"https://api.github.com/users/zdne/received_events","type":"User","site_admin":false},"body":"> Ofcourse I can make them initialize with empty sub-variables, but it is the same as this. Extra unnecessary code\r\n\r\nThe question is why it is sometimes needed and sometimes not.  Adding an initializer (see the rule of three) is never a bad idea and definitely never an unnecessary code. \r\n\r\n","created_at":"2014-09-29T13:40:14Z","updated_at":"2014-09-29T13:40:14Z","html_url":"https://github.com/apiaryio/snowcrash/pull/211#discussion_r18153716","pull_request_url":"https://api.github.com/repos/apiaryio/snowcrash/pulls/211","_links":{"self":{"href":"https://api.github.com/repos/apiaryio/snowcrash/pulls/comments/18153716"},"html":{"href":"https://github.com/apiaryio/snowcrash/pull/211#discussion_r18153716"},"pull_request":{"href":"https://api.github.com/repos/apiaryio/snowcrash/pulls/211"}}},"pull_request":{"url":"https://api.github.com/repos/apiaryio/snowcrash/pulls/211","id":21642993,"html_url":"https://github.com/apiaryio/snowcrash/pull/211","diff_url":"https://github.com/apiaryio/snowcrash/pull/211.diff","patch_url":"https://github.com/apiaryio/snowcrash/pull/211.patch","issue_url":"https://api.github.com/repos/apiaryio/snowcrash/issues/211","number":211,"state":"open","locked":false,"title":"Exporting sourcemaps","user":{"login":"pksunkara","id":174703,"avatar_url":"https://avatars.githubusercontent.com/u/174703?v=2","gravatar_id":"","url":"https://api.github.com/users/pksunkara","html_url":"https://github.com/pksunkara","followers_url":"https://api.github.com/users/pksunkara/followers","following_url":"https://api.github.com/users/pksunkara/following{/other_user}","gists_url":"https://api.github.com/users/pksunkara/gists{/gist_id}","starred_url":"https://api.github.com/users/pksunkara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pksunkara/subscriptions","organizations_url":"https://api.github.com/users/pksunkara/orgs","repos_url":"https://api.github.com/users/pksunkara/repos","events_url":"https://api.github.com/users/pksunkara/events{/privacy}","received_events_url":"https://api.github.com/users/pksunkara/received_events","type":"User","site_admin":false},"body":"Fixes #30","created_at":"2014-09-23T12:53:39Z","updated_at":"2014-09-29T13:40:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6e3a1e6bc1ba21f675f9a1e57b178ed87e23f0e1","assignee":{"login":"zdne","id":613617,"avatar_url":"https://avatars.githubusercontent.com/u/613617?v=2","gravatar_id":"","url":"https://api.github.com/users/zdne","html_url":"https://github.com/zdne","followers_url":"https://api.github.com/users/zdne/followers","following_url":"https://api.github.com/users/zdne/following{/other_user}","gists_url":"https://api.github.com/users/zdne/gists{/gist_id}","starred_url":"https://api.github.com/users/zdne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zdne/subscriptions","organizations_url":"https://api.github.com/users/zdne/orgs","repos_url":"https://api.github.com/users/zdne/repos","events_url":"https://api.github.com/users/zdne/events{/privacy}","received_events_url":"https://api.github.com/users/zdne/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/apiaryio/snowcrash/pulls/211/commits","review_comments_url":"https://api.github.com/repos/apiaryio/snowcrash/pulls/211/comments","review_comment_url":"https://api.github.com/repos/apiaryio/snowcrash/pulls/comments/{number}","comments_url":"https://api.github.com/repos/apiaryio/snowcrash/issues/211/comments","statuses_url":"https://api.github.com/repos/apiaryio/snowcrash/statuses/296f787e1480c0678fe0a5302900df00d75ca952","head":{"label":"apiaryio:pksunkara/sourcemap","ref":"pksunkara/sourcemap","sha":"296f787e1480c0678fe0a5302900df00d75ca952","user":{"login":"apiaryio","id":765943,"avatar_url":"https://avatars.githubusercontent.com/u/765943?v=2","gravatar_id":"","url":"https://api.github.com/users/apiaryio","html_url":"https://github.com/apiaryio","followers_url":"https://api.github.com/users/apiaryio/followers","following_url":"https://api.github.com/users/apiaryio/following{/other_user}","gists_url":"https://api.github.com/users/apiaryio/gists{/gist_id}","starred_url":"https://api.github.com/users/apiaryio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apiaryio/subscriptions","organizations_url":"https://api.github.com/users/apiaryio/orgs","repos_url":"https://api.github.com/users/apiaryio/repos","events_url":"https://api.github.com/users/apiaryio/events{/privacy}","received_events_url":"https://api.github.com/users/apiaryio/received_events","type":"Organization","site_admin":false},"repo":{"id":9173280,"name":"snowcrash","full_name":"apiaryio/snowcrash","owner":{"login":"apiaryio","id":765943,"avatar_url":"https://avatars.githubusercontent.com/u/765943?v=2","gravatar_id":"","url":"https://api.github.com/users/apiaryio","html_url":"https://github.com/apiaryio","followers_url":"https://api.github.com/users/apiaryio/followers","following_url":"https://api.github.com/users/apiaryio/following{/other_user}","gists_url":"https://api.github.com/users/apiaryio/gists{/gist_id}","starred_url":"https://api.github.com/users/apiaryio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apiaryio/subscriptions","organizations_url":"https://api.github.com/users/apiaryio/orgs","repos_url":"https://api.github.com/users/apiaryio/repos","events_url":"https://api.github.com/users/apiaryio/events{/privacy}","received_events_url":"https://api.github.com/users/apiaryio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apiaryio/snowcrash","description":"API Blueprint Parser","fork":false,"url":"https://api.github.com/repos/apiaryio/snowcrash","forks_url":"https://api.github.com/repos/apiaryio/snowcrash/forks","keys_url":"https://api.github.com/repos/apiaryio/snowcrash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apiaryio/snowcrash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apiaryio/snowcrash/teams","hooks_url":"https://api.github.com/repos/apiaryio/snowcrash/hooks","issue_events_url":"https://api.github.com/repos/apiaryio/snowcrash/issues/events{/number}","events_url":"https://api.github.com/repos/apiaryio/snowcrash/events","assignees_url":"https://api.github.com/repos/apiaryio/snowcrash/assignees{/user}","branches_url":"https://api.github.com/repos/apiaryio/snowcrash/branches{/branch}","tags_url":"https://api.github.com/repos/apiaryio/snowcrash/tags","blobs_url":"https://api.github.com/repos/apiaryio/snowcrash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apiaryio/snowcrash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apiaryio/snowcrash/git/refs{/sha}","trees_url":"https://api.github.com/repos/apiaryio/snowcrash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apiaryio/snowcrash/statuses/{sha}","languages_url":"https://api.github.com/repos/apiaryio/snowcrash/languages","stargazers_url":"https://api.github.com/repos/apiaryio/snowcrash/stargazers","contributors_url":"https://api.github.com/repos/apiaryio/snowcrash/contributors","subscribers_url":"https://api.github.com/repos/apiaryio/snowcrash/subscribers","subscription_url":"https://api.github.com/repos/apiaryio/snowcrash/subscription","commits_url":"https://api.github.com/repos/apiaryio/snowcrash/commits{/sha}","git_commits_url":"https://api.github.com/repos/apiaryio/snowcrash/git/commits{/sha}","comments_url":"https://api.github.com/repos/apiaryio/snowcrash/comments{/number}","issue_comment_url":"https://api.github.com/repos/apiaryio/snowcrash/issues/comments/{number}","contents_url":"https://api.github.com/repos/apiaryio/snowcrash/contents/{+path}","compare_url":"https://api.github.com/repos/apiaryio/snowcrash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apiaryio/snowcrash/merges","archive_url":"https://api.github.com/repos/apiaryio/snowcrash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apiaryio/snowcrash/downloads","issues_url":"https://api.github.com/repos/apiaryio/snowcrash/issues{/number}","pulls_url":"https://api.github.com/repos/apiaryio/snowcrash/pulls{/number}","milestones_url":"https://api.github.com/repos/apiaryio/snowcrash/milestones{/number}","notifications_url":"https://api.github.com/repos/apiaryio/snowcrash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apiaryio/snowcrash/labels{/name}","releases_url":"https://api.github.com/repos/apiaryio/snowcrash/releases{/id}","created_at":"2013-04-02T15:23:04Z","updated_at":"2014-09-26T13:02:13Z","pushed_at":"2014-09-29T13:26:36Z","git_url":"git://github.com/apiaryio/snowcrash.git","ssh_url":"git@github.com:apiaryio/snowcrash.git","clone_url":"https://github.com/apiaryio/snowcrash.git","svn_url":"https://github.com/apiaryio/snowcrash","homepage":null,"size":9400,"stargazers_count":175,"watchers_count":175,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":27,"forks":27,"open_issues":27,"watchers":175,"default_branch":"master"}},"base":{"label":"apiaryio:master","ref":"master","sha":"8f9a6ce017291a51eb44fd3d4f4c84aedac05161","user":{"login":"apiaryio","id":765943,"avatar_url":"https://avatars.githubusercontent.com/u/765943?v=2","gravatar_id":"","url":"https://api.github.com/users/apiaryio","html_url":"https://github.com/apiaryio","followers_url":"https://api.github.com/users/apiaryio/followers","following_url":"https://api.github.com/users/apiaryio/following{/other_user}","gists_url":"https://api.github.com/users/apiaryio/gists{/gist_id}","starred_url":"https://api.github.com/users/apiaryio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apiaryio/subscriptions","organizations_url":"https://api.github.com/users/apiaryio/orgs","repos_url":"https://api.github.com/users/apiaryio/repos","events_url":"https://api.github.com/users/apiaryio/events{/privacy}","received_events_url":"https://api.github.com/users/apiaryio/received_events","type":"Organization","site_admin":false},"repo":{"id":9173280,"name":"snowcrash","full_name":"apiaryio/snowcrash","owner":{"login":"apiaryio","id":765943,"avatar_url":"https://avatars.githubusercontent.com/u/765943?v=2","gravatar_id":"","url":"https://api.github.com/users/apiaryio","html_url":"https://github.com/apiaryio","followers_url":"https://api.github.com/users/apiaryio/followers","following_url":"https://api.github.com/users/apiaryio/following{/other_user}","gists_url":"https://api.github.com/users/apiaryio/gists{/gist_id}","starred_url":"https://api.github.com/users/apiaryio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apiaryio/subscriptions","organizations_url":"https://api.github.com/users/apiaryio/orgs","repos_url":"https://api.github.com/users/apiaryio/repos","events_url":"https://api.github.com/users/apiaryio/events{/privacy}","received_events_url":"https://api.github.com/users/apiaryio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apiaryio/snowcrash","description":"API Blueprint Parser","fork":false,"url":"https://api.github.com/repos/apiaryio/snowcrash","forks_url":"https://api.github.com/repos/apiaryio/snowcrash/forks","keys_url":"https://api.github.com/repos/apiaryio/snowcrash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apiaryio/snowcrash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apiaryio/snowcrash/teams","hooks_url":"https://api.github.com/repos/apiaryio/snowcrash/hooks","issue_events_url":"https://api.github.com/repos/apiaryio/snowcrash/issues/events{/number}","events_url":"https://api.github.com/repos/apiaryio/snowcrash/events","assignees_url":"https://api.github.com/repos/apiaryio/snowcrash/assignees{/user}","branches_url":"https://api.github.com/repos/apiaryio/snowcrash/branches{/branch}","tags_url":"https://api.github.com/repos/apiaryio/snowcrash/tags","blobs_url":"https://api.github.com/repos/apiaryio/snowcrash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apiaryio/snowcrash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apiaryio/snowcrash/git/refs{/sha}","trees_url":"https://api.github.com/repos/apiaryio/snowcrash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apiaryio/snowcrash/statuses/{sha}","languages_url":"https://api.github.com/repos/apiaryio/snowcrash/languages","stargazers_url":"https://api.github.com/repos/apiaryio/snowcrash/stargazers","contributors_url":"https://api.github.com/repos/apiaryio/snowcrash/contributors","subscribers_url":"https://api.github.com/repos/apiaryio/snowcrash/subscribers","subscription_url":"https://api.github.com/repos/apiaryio/snowcrash/subscription","commits_url":"https://api.github.com/repos/apiaryio/snowcrash/commits{/sha}","git_commits_url":"https://api.github.com/repos/apiaryio/snowcrash/git/commits{/sha}","comments_url":"https://api.github.com/repos/apiaryio/snowcrash/comments{/number}","issue_comment_url":"https://api.github.com/repos/apiaryio/snowcrash/issues/comments/{number}","contents_url":"https://api.github.com/repos/apiaryio/snowcrash/contents/{+path}","compare_url":"https://api.github.com/repos/apiaryio/snowcrash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apiaryio/snowcrash/merges","archive_url":"https://api.github.com/repos/apiaryio/snowcrash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apiaryio/snowcrash/downloads","issues_url":"https://api.github.com/repos/apiaryio/snowcrash/issues{/number}","pulls_url":"https://api.github.com/repos/apiaryio/snowcrash/pulls{/number}","milestones_url":"https://api.github.com/repos/apiaryio/snowcrash/milestones{/number}","notifications_url":"https://api.github.com/repos/apiaryio/snowcrash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apiaryio/snowcrash/labels{/name}","releases_url":"https://api.github.com/repos/apiaryio/snowcrash/releases{/id}","created_at":"2013-04-02T15:23:04Z","updated_at":"2014-09-26T13:02:13Z","pushed_at":"2014-09-29T13:26:36Z","git_url":"git://github.com/apiaryio/snowcrash.git","ssh_url":"git@github.com:apiaryio/snowcrash.git","clone_url":"https://github.com/apiaryio/snowcrash.git","svn_url":"https://github.com/apiaryio/snowcrash","homepage":null,"size":9400,"stargazers_count":175,"watchers_count":175,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":27,"forks":27,"open_issues":27,"watchers":175,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apiaryio/snowcrash/pulls/211"},"html":{"href":"https://github.com/apiaryio/snowcrash/pull/211"},"issue":{"href":"https://api.github.com/repos/apiaryio/snowcrash/issues/211"},"comments":{"href":"https://api.github.com/repos/apiaryio/snowcrash/issues/211/comments"},"review_comments":{"href":"https://api.github.com/repos/apiaryio/snowcrash/pulls/211/comments"},"review_comment":{"href":"https://api.github.com/repos/apiaryio/snowcrash/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/apiaryio/snowcrash/pulls/211/commits"},"statuses":{"href":"https://api.github.com/repos/apiaryio/snowcrash/statuses/296f787e1480c0678fe0a5302900df00d75ca952"}}}}