GitHub PullRequestReviewCommentEvent at 2014-11-04 21:37:02
Repository: servo
Actor: cgaebel
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/servo/servo/pulls/comments/19837986","id":19837986,"diff_hunk":"@@ -259,7 +252,7 @@ impl LayoutTask {\n         let local_image_cache =\n             Arc::new(Mutex::new(LocalImageCache::new(image_cache_task.clone())));\n         let screen_size = Size2D(Au(0), Au(0));\n-        let device = Device::new(Screen, opts::get().initial_window_size.as_f32());\n+        let device = Device::new(Screen, opts::get().initial_window_size.as_f32() * ScaleFactor(1.0));","path":"components/layout/layout_task.rs","position":35,"original_position":35,"commit_id":"11cf538ff46914f4db50aad908e5246335af9ba1","original_commit_id":"11cf538ff46914f4db50aad908e5246335af9ba1","user":{"login":"cgaebel","id":128969,"avatar_url":"https://avatars.githubusercontent.com/u/128969?v=2","gravatar_id":"","url":"https://api.github.com/users/cgaebel","html_url":"https://github.com/cgaebel","followers_url":"https://api.github.com/users/cgaebel/followers","following_url":"https://api.github.com/users/cgaebel/following{/other_user}","gists_url":"https://api.github.com/users/cgaebel/gists{/gist_id}","starred_url":"https://api.github.com/users/cgaebel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgaebel/subscriptions","organizations_url":"https://api.github.com/users/cgaebel/orgs","repos_url":"https://api.github.com/users/cgaebel/repos","events_url":"https://api.github.com/users/cgaebel/events{/privacy}","received_events_url":"https://api.github.com/users/cgaebel/received_events","type":"User","site_admin":false},"body":"Why are we scaling by 1.0?","created_at":"2014-11-04T21:37:02Z","updated_at":"2014-11-04T21:37:02Z","html_url":"https://github.com/servo/servo/pull/3886#discussion_r19837986","pull_request_url":"https://api.github.com/repos/servo/servo/pulls/3886","_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/comments/19837986"},"html":{"href":"https://github.com/servo/servo/pull/3886#discussion_r19837986"},"pull_request":{"href":"https://api.github.com/repos/servo/servo/pulls/3886"}}},"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/3886","id":23864871,"html_url":"https://github.com/servo/servo/pull/3886","diff_url":"https://github.com/servo/servo/pull/3886.diff","patch_url":"https://github.com/servo/servo/pull/3886.patch","issue_url":"https://api.github.com/repos/servo/servo/issues/3886","number":3886,"state":"open","locked":false,"title":"Make media queries work with resize and page zoom.","user":{"login":"glennw","id":2350882,"avatar_url":"https://avatars.githubusercontent.com/u/2350882?v=2","gravatar_id":"","url":"https://api.github.com/users/glennw","html_url":"https://github.com/glennw","followers_url":"https://api.github.com/users/glennw/followers","following_url":"https://api.github.com/users/glennw/following{/other_user}","gists_url":"https://api.github.com/users/glennw/gists{/gist_id}","starred_url":"https://api.github.com/users/glennw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glennw/subscriptions","organizations_url":"https://api.github.com/users/glennw/orgs","repos_url":"https://api.github.com/users/glennw/repos","events_url":"https://api.github.com/users/glennw/events{/privacy}","received_events_url":"https://api.github.com/users/glennw/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-11-04T21:28:30Z","updated_at":"2014-11-04T21:37:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e7ddecb404fac4c2f6298d02ccd9f1085d066b72","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/servo/servo/pulls/3886/commits","review_comments_url":"https://api.github.com/repos/servo/servo/pulls/3886/comments","review_comment_url":"https://api.github.com/repos/servo/servo/pulls/comments/{number}","comments_url":"https://api.github.com/repos/servo/servo/issues/3886/comments","statuses_url":"https://api.github.com/repos/servo/servo/statuses/11cf538ff46914f4db50aad908e5246335af9ba1","head":{"label":"glennw:mq","ref":"mq","sha":"11cf538ff46914f4db50aad908e5246335af9ba1","user":{"login":"glennw","id":2350882,"avatar_url":"https://avatars.githubusercontent.com/u/2350882?v=2","gravatar_id":"","url":"https://api.github.com/users/glennw","html_url":"https://github.com/glennw","followers_url":"https://api.github.com/users/glennw/followers","following_url":"https://api.github.com/users/glennw/following{/other_user}","gists_url":"https://api.github.com/users/glennw/gists{/gist_id}","starred_url":"https://api.github.com/users/glennw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glennw/subscriptions","organizations_url":"https://api.github.com/users/glennw/orgs","repos_url":"https://api.github.com/users/glennw/repos","events_url":"https://api.github.com/users/glennw/events{/privacy}","received_events_url":"https://api.github.com/users/glennw/received_events","type":"User","site_admin":false},"repo":{"id":19436483,"name":"servo","full_name":"glennw/servo","owner":{"login":"glennw","id":2350882,"avatar_url":"https://avatars.githubusercontent.com/u/2350882?v=2","gravatar_id":"","url":"https://api.github.com/users/glennw","html_url":"https://github.com/glennw","followers_url":"https://api.github.com/users/glennw/followers","following_url":"https://api.github.com/users/glennw/following{/other_user}","gists_url":"https://api.github.com/users/glennw/gists{/gist_id}","starred_url":"https://api.github.com/users/glennw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glennw/subscriptions","organizations_url":"https://api.github.com/users/glennw/orgs","repos_url":"https://api.github.com/users/glennw/repos","events_url":"https://api.github.com/users/glennw/events{/privacy}","received_events_url":"https://api.github.com/users/glennw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/glennw/servo","description":"The Servo Browser Engine","fork":true,"url":"https://api.github.com/repos/glennw/servo","forks_url":"https://api.github.com/repos/glennw/servo/forks","keys_url":"https://api.github.com/repos/glennw/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/glennw/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/glennw/servo/teams","hooks_url":"https://api.github.com/repos/glennw/servo/hooks","issue_events_url":"https://api.github.com/repos/glennw/servo/issues/events{/number}","events_url":"https://api.github.com/repos/glennw/servo/events","assignees_url":"https://api.github.com/repos/glennw/servo/assignees{/user}","branches_url":"https://api.github.com/repos/glennw/servo/branches{/branch}","tags_url":"https://api.github.com/repos/glennw/servo/tags","blobs_url":"https://api.github.com/repos/glennw/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/glennw/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/glennw/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/glennw/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/glennw/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/glennw/servo/languages","stargazers_url":"https://api.github.com/repos/glennw/servo/stargazers","contributors_url":"https://api.github.com/repos/glennw/servo/contributors","subscribers_url":"https://api.github.com/repos/glennw/servo/subscribers","subscription_url":"https://api.github.com/repos/glennw/servo/subscription","commits_url":"https://api.github.com/repos/glennw/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/glennw/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/glennw/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/glennw/servo/issues/comments/{number}","contents_url":"https://api.github.com/repos/glennw/servo/contents/{+path}","compare_url":"https://api.github.com/repos/glennw/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/glennw/servo/merges","archive_url":"https://api.github.com/repos/glennw/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/glennw/servo/downloads","issues_url":"https://api.github.com/repos/glennw/servo/issues{/number}","pulls_url":"https://api.github.com/repos/glennw/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/glennw/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/glennw/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/glennw/servo/labels{/name}","releases_url":"https://api.github.com/repos/glennw/servo/releases{/id}","created_at":"2014-05-04T21:25:17Z","updated_at":"2014-06-26T04:11:22Z","pushed_at":"2014-11-04T21:26:52Z","git_url":"git://github.com/glennw/servo.git","ssh_url":"git@github.com:glennw/servo.git","clone_url":"https://github.com/glennw/servo.git","svn_url":"https://github.com/glennw/servo","homepage":"","size":33122,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"servo:master","ref":"master","sha":"e483a189a3c24d0fe475cf2a8dedb11821f7ee21","user":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=2","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"repo":{"id":3390243,"name":"servo","full_name":"servo/servo","owner":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=2","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/servo/servo","description":"The Servo Browser Engine","fork":false,"url":"https://api.github.com/repos/servo/servo","forks_url":"https://api.github.com/repos/servo/servo/forks","keys_url":"https://api.github.com/repos/servo/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/servo/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/servo/servo/teams","hooks_url":"https://api.github.com/repos/servo/servo/hooks","issue_events_url":"https://api.github.com/repos/servo/servo/issues/events{/number}","events_url":"https://api.github.com/repos/servo/servo/events","assignees_url":"https://api.github.com/repos/servo/servo/assignees{/user}","branches_url":"https://api.github.com/repos/servo/servo/branches{/branch}","tags_url":"https://api.github.com/repos/servo/servo/tags","blobs_url":"https://api.github.com/repos/servo/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/servo/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/servo/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/servo/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/servo/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/servo/servo/languages","stargazers_url":"https://api.github.com/repos/servo/servo/stargazers","contributors_url":"https://api.github.com/repos/servo/servo/contributors","subscribers_url":"https://api.github.com/repos/servo/servo/subscribers","subscription_url":"https://api.github.com/repos/servo/servo/subscription","commits_url":"https://api.github.com/repos/servo/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/servo/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/servo/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/servo/servo/issues/comments/{number}","contents_url":"https://api.github.com/repos/servo/servo/contents/{+path}","compare_url":"https://api.github.com/repos/servo/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/servo/servo/merges","archive_url":"https://api.github.com/repos/servo/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/servo/servo/downloads","issues_url":"https://api.github.com/repos/servo/servo/issues{/number}","pulls_url":"https://api.github.com/repos/servo/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/servo/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/servo/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/servo/servo/labels{/name}","releases_url":"https://api.github.com/repos/servo/servo/releases{/id}","created_at":"2012-02-08T19:07:25Z","updated_at":"2014-11-04T19:19:26Z","pushed_at":"2014-11-04T19:06:38Z","git_url":"git://github.com/servo/servo.git","ssh_url":"git@github.com:servo/servo.git","clone_url":"https://github.com/servo/servo.git","svn_url":"https://github.com/servo/servo","homepage":"","size":93446,"stargazers_count":2415,"watchers_count":2415,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":378,"mirror_url":null,"open_issues_count":636,"forks":378,"open_issues":636,"watchers":2415,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/3886"},"html":{"href":"https://github.com/servo/servo/pull/3886"},"issue":{"href":"https://api.github.com/repos/servo/servo/issues/3886"},"comments":{"href":"https://api.github.com/repos/servo/servo/issues/3886/comments"},"review_comments":{"href":"https://api.github.com/repos/servo/servo/pulls/3886/comments"},"review_comment":{"href":"https://api.github.com/repos/servo/servo/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/servo/servo/pulls/3886/commits"},"statuses":{"href":"https://api.github.com/repos/servo/servo/statuses/11cf538ff46914f4db50aad908e5246335af9ba1"}}}}