GitHub PullRequestReviewCommentEvent at 2014-03-12 10:26:40
Repository: gaia
Actor: etiennesegonzac
Payload: {"comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/10511738","id":10511738,"diff_hunk":"@@ -1397,4 +1434,31 @@ suite('system/Statusbar', function() {\n       });\n     });\n   });\n+\n+  suite('not fullscreen mode >', function() {\n+    var app;\n+    setup(function() {\n+      app = {\n+        isFullScreen: function() {\n+          return true;\n+        },\n+        iframe: document.createElement('iframe')\n+      };\n+\n+      this.sinon.stub(MockAppWindowManager, 'getActiveApp').returns(app);\n+      StatusBar.screen = document.createElement('div');\n+    });\n+\n+    test('the status bar should not be hidden when attentionscreen is hidden,' +\n+         ' and the current app in not fullscreen',","path":"apps/system/test/unit/statusbar_test.js","position":74,"original_position":74,"commit_id":"9d058329659db6553014fda02bcff93b0eef66a3","original_commit_id":"9d058329659db6553014fda02bcff93b0eef66a3","user":{"login":"etiennesegonzac","id":105194,"avatar_url":"https://gravatar.com/avatar/f9e117ac2991e479799540d8a3711b4c?d=https%3A%2F%2Fidenticons.github.com%2Fed132ddd1b26b9627ddb89940776e011.png&r=x","gravatar_id":"f9e117ac2991e479799540d8a3711b4c","url":"https://api.github.com/users/etiennesegonzac","html_url":"https://github.com/etiennesegonzac","followers_url":"https://api.github.com/users/etiennesegonzac/followers","following_url":"https://api.github.com/users/etiennesegonzac/following{/other_user}","gists_url":"https://api.github.com/users/etiennesegonzac/gists{/gist_id}","starred_url":"https://api.github.com/users/etiennesegonzac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etiennesegonzac/subscriptions","organizations_url":"https://api.github.com/users/etiennesegonzac/orgs","repos_url":"https://api.github.com/users/etiennesegonzac/repos","events_url":"https://api.github.com/users/etiennesegonzac/events{/privacy}","received_events_url":"https://api.github.com/users/etiennesegonzac/received_events","type":"User","site_admin":false},"body":"you don't need to specify `' and the current app in not fullscreen'` since you're in the `not fullscreen mode` suite.\r\nBonus, it will fit in one line :)","created_at":"2014-03-12T10:26:40Z","updated_at":"2014-03-12T10:26:40Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/17060#discussion_r10511738","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/17060","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/10511738"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/17060#discussion_r10511738"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/17060"}}}}