GitHub PullRequestReviewCommentEvent at 2014-11-25 09:47:57
Repository: atmosphere
Actor: houndci
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/dice-cyfronet/atmosphere/pulls/comments/20852136","id":20852136,"diff_hunk":"@@ -55,15 +48,15 @@\n            { 'cpu' => 1, 'mem' => 512, 'compute_site_ids' => [1] },\n            { 'cpu' => 2, 'mem' => 1024, 'compute_site_ids' => [1] }\n           ]\n-    created_appl_params = ActionController::Parameters.new(\n-        {\n-          appliance_set_id: as.id,\n-          configuration_template_id: cfg_tmpl.id,\n-          vms: vms\n-        }\n-      )\n-      creator = Atmosphere::ApplianceCreator.new(created_appl_params, 'dummy-token')\n-      appl = creator.create!\n+    created_appl_params = ActionController::Parameters\n+                            .new(appliance_set_id: as.id,","path":"spec/services/atmosphere/appliance_creator_spec.rb","position":67,"original_position":67,"commit_id":"188126651108326bcfb5180a1640b72f9a26d352","original_commit_id":"188126651108326bcfb5180a1640b72f9a26d352","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Place the . on the previous line, together with the method call receiver.","created_at":"2014-11-25T09:47:57Z","updated_at":"2014-11-25T09:47:57Z","html_url":"https://github.com/dice-cyfronet/atmosphere/pull/9#discussion_r20852136","pull_request_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/dice-cyfronet/atmosphere/pulls/comments/20852136"},"html":{"href":"https://github.com/dice-cyfronet/atmosphere/pull/9#discussion_r20852136"},"pull_request":{"href":"https://api.github.com/repos/dice-cyfronet/atmosphere/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/dice-cyfronet/atmosphere/pulls/9","id":24995205,"html_url":"https://github.com/dice-cyfronet/atmosphere/pull/9","diff_url":"https://github.com/dice-cyfronet/atmosphere/pull/9.diff","patch_url":"https://github.com/dice-cyfronet/atmosphere/pull/9.patch","issue_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/issues/9","number":9,"state":"open","locked":false,"title":"Authorization logic moved from ApplianceCreator into cancan","user":{"login":"mkasztelnik","id":1265430,"avatar_url":"https://avatars.githubusercontent.com/u/1265430?v=3","gravatar_id":"","url":"https://api.github.com/users/mkasztelnik","html_url":"https://github.com/mkasztelnik","followers_url":"https://api.github.com/users/mkasztelnik/followers","following_url":"https://api.github.com/users/mkasztelnik/following{/other_user}","gists_url":"https://api.github.com/users/mkasztelnik/gists{/gist_id}","starred_url":"https://api.github.com/users/mkasztelnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkasztelnik/subscriptions","organizations_url":"https://api.github.com/users/mkasztelnik/orgs","repos_url":"https://api.github.com/users/mkasztelnik/repos","events_url":"https://api.github.com/users/mkasztelnik/events{/privacy}","received_events_url":"https://api.github.com/users/mkasztelnik/received_events","type":"User","site_admin":false},"body":"Inside `Atmosphere::ApplianceCreator` logic responsible for create authorization occurs. It was moved into cancan ability. \r\n\r\nFixes redmine 3207 issue.\r\n\r\n/cc @nowakowski, @djchrap, @Nuanda - please take a look","created_at":"2014-11-25T09:47:51Z","updated_at":"2014-11-25T09:47:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0c8689a5f3f8c21b25094139c3091583488ee985","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/pulls/9/commits","review_comments_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/pulls/9/comments","review_comment_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/pulls/comments/{number}","comments_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/issues/9/comments","statuses_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/statuses/188126651108326bcfb5180a1640b72f9a26d352","head":{"label":"dice-cyfronet:create_appl_pdp","ref":"create_appl_pdp","sha":"188126651108326bcfb5180a1640b72f9a26d352","user":{"login":"dice-cyfronet","id":1628782,"avatar_url":"https://avatars.githubusercontent.com/u/1628782?v=3","gravatar_id":"","url":"https://api.github.com/users/dice-cyfronet","html_url":"https://github.com/dice-cyfronet","followers_url":"https://api.github.com/users/dice-cyfronet/followers","following_url":"https://api.github.com/users/dice-cyfronet/following{/other_user}","gists_url":"https://api.github.com/users/dice-cyfronet/gists{/gist_id}","starred_url":"https://api.github.com/users/dice-cyfronet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dice-cyfronet/subscriptions","organizations_url":"https://api.github.com/users/dice-cyfronet/orgs","repos_url":"https://api.github.com/users/dice-cyfronet/repos","events_url":"https://api.github.com/users/dice-cyfronet/events{/privacy}","received_events_url":"https://api.github.com/users/dice-cyfronet/received_events","type":"Organization","site_admin":false},"repo":{"id":25483417,"name":"atmosphere","full_name":"dice-cyfronet/atmosphere","owner":{"login":"dice-cyfronet","id":1628782,"avatar_url":"https://avatars.githubusercontent.com/u/1628782?v=3","gravatar_id":"","url":"https://api.github.com/users/dice-cyfronet","html_url":"https://github.com/dice-cyfronet","followers_url":"https://api.github.com/users/dice-cyfronet/followers","following_url":"https://api.github.com/users/dice-cyfronet/following{/other_user}","gists_url":"https://api.github.com/users/dice-cyfronet/gists{/gist_id}","starred_url":"https://api.github.com/users/dice-cyfronet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dice-cyfronet/subscriptions","organizations_url":"https://api.github.com/users/dice-cyfronet/orgs","repos_url":"https://api.github.com/users/dice-cyfronet/repos","events_url":"https://api.github.com/users/dice-cyfronet/events{/privacy}","received_events_url":"https://api.github.com/users/dice-cyfronet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dice-cyfronet/atmosphere","description":"Atmosphere cloud platform","fork":false,"url":"https://api.github.com/repos/dice-cyfronet/atmosphere","forks_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/forks","keys_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/teams","hooks_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/hooks","issue_events_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/issues/events{/number}","events_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/events","assignees_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/assignees{/user}","branches_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/branches{/branch}","tags_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/tags","blobs_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/git/refs{/sha}","trees_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/statuses/{sha}","languages_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/languages","stargazers_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/stargazers","contributors_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/contributors","subscribers_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/subscribers","subscription_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/subscription","commits_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/commits{/sha}","git_commits_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/git/commits{/sha}","comments_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/comments{/number}","issue_comment_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/issues/comments/{number}","contents_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/contents/{+path}","compare_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/merges","archive_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/downloads","issues_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/issues{/number}","pulls_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/pulls{/number}","milestones_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/milestones{/number}","notifications_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/labels{/name}","releases_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/releases{/id}","created_at":"2014-10-20T19:40:11Z","updated_at":"2014-11-24T12:46:32Z","pushed_at":"2014-11-25T09:21:59Z","git_url":"git://github.com/dice-cyfronet/atmosphere.git","ssh_url":"git@github.com:dice-cyfronet/atmosphere.git","clone_url":"https://github.com/dice-cyfronet/atmosphere.git","svn_url":"https://github.com/dice-cyfronet/atmosphere","homepage":null,"size":4320,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":1,"default_branch":"master"}},"base":{"label":"dice-cyfronet:master","ref":"master","sha":"99e2c73709ee4fb605b53671803656e66637ef0a","user":{"login":"dice-cyfronet","id":1628782,"avatar_url":"https://avatars.githubusercontent.com/u/1628782?v=3","gravatar_id":"","url":"https://api.github.com/users/dice-cyfronet","html_url":"https://github.com/dice-cyfronet","followers_url":"https://api.github.com/users/dice-cyfronet/followers","following_url":"https://api.github.com/users/dice-cyfronet/following{/other_user}","gists_url":"https://api.github.com/users/dice-cyfronet/gists{/gist_id}","starred_url":"https://api.github.com/users/dice-cyfronet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dice-cyfronet/subscriptions","organizations_url":"https://api.github.com/users/dice-cyfronet/orgs","repos_url":"https://api.github.com/users/dice-cyfronet/repos","events_url":"https://api.github.com/users/dice-cyfronet/events{/privacy}","received_events_url":"https://api.github.com/users/dice-cyfronet/received_events","type":"Organization","site_admin":false},"repo":{"id":25483417,"name":"atmosphere","full_name":"dice-cyfronet/atmosphere","owner":{"login":"dice-cyfronet","id":1628782,"avatar_url":"https://avatars.githubusercontent.com/u/1628782?v=3","gravatar_id":"","url":"https://api.github.com/users/dice-cyfronet","html_url":"https://github.com/dice-cyfronet","followers_url":"https://api.github.com/users/dice-cyfronet/followers","following_url":"https://api.github.com/users/dice-cyfronet/following{/other_user}","gists_url":"https://api.github.com/users/dice-cyfronet/gists{/gist_id}","starred_url":"https://api.github.com/users/dice-cyfronet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dice-cyfronet/subscriptions","organizations_url":"https://api.github.com/users/dice-cyfronet/orgs","repos_url":"https://api.github.com/users/dice-cyfronet/repos","events_url":"https://api.github.com/users/dice-cyfronet/events{/privacy}","received_events_url":"https://api.github.com/users/dice-cyfronet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dice-cyfronet/atmosphere","description":"Atmosphere cloud platform","fork":false,"url":"https://api.github.com/repos/dice-cyfronet/atmosphere","forks_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/forks","keys_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/teams","hooks_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/hooks","issue_events_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/issues/events{/number}","events_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/events","assignees_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/assignees{/user}","branches_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/branches{/branch}","tags_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/tags","blobs_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/git/refs{/sha}","trees_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/statuses/{sha}","languages_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/languages","stargazers_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/stargazers","contributors_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/contributors","subscribers_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/subscribers","subscription_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/subscription","commits_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/commits{/sha}","git_commits_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/git/commits{/sha}","comments_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/comments{/number}","issue_comment_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/issues/comments/{number}","contents_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/contents/{+path}","compare_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/merges","archive_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/downloads","issues_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/issues{/number}","pulls_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/pulls{/number}","milestones_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/milestones{/number}","notifications_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/labels{/name}","releases_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/releases{/id}","created_at":"2014-10-20T19:40:11Z","updated_at":"2014-11-24T12:46:32Z","pushed_at":"2014-11-25T09:21:59Z","git_url":"git://github.com/dice-cyfronet/atmosphere.git","ssh_url":"git@github.com:dice-cyfronet/atmosphere.git","clone_url":"https://github.com/dice-cyfronet/atmosphere.git","svn_url":"https://github.com/dice-cyfronet/atmosphere","homepage":null,"size":4320,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dice-cyfronet/atmosphere/pulls/9"},"html":{"href":"https://github.com/dice-cyfronet/atmosphere/pull/9"},"issue":{"href":"https://api.github.com/repos/dice-cyfronet/atmosphere/issues/9"},"comments":{"href":"https://api.github.com/repos/dice-cyfronet/atmosphere/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/dice-cyfronet/atmosphere/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/dice-cyfronet/atmosphere/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/dice-cyfronet/atmosphere/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/dice-cyfronet/atmosphere/statuses/188126651108326bcfb5180a1640b72f9a26d352"}}}}