GitHub PullRequestReviewCommentEvent at 2014-10-29 18:20:08
Repository: osquery
Actor: mtmcgrew
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/facebook/osquery/pulls/comments/19560317","id":19560317,"diff_hunk":"@@ -0,0 +1,49 @@\n+// Copyright 2004-present Facebook. All Rights Reserved.\n+\n+#include <stdio.h>\n+#include <string.h>\n+\n+#include \"osquery/database.h\"\n+\n+namespace osquery {\n+namespace tables {\n+\n+QueryData genArp() {\n+  Row r;\n+  QueryData results;\n+  FILE *proc_arp_fd;\n+  char *line = NULL;\n+  size_t length;\n+  int ret;\n+\n+  char ip[32];\n+  char arp[64];\n+  char iface[32];\n+  char foo[128];","path":"osquery/tables/networking/linux/arp.cpp","position":22,"original_position":22,"commit_id":"a94b0bf6fd58d386cdb0f5c06e938c2b5c596450","original_commit_id":"a94b0bf6fd58d386cdb0f5c06e938c2b5c596450","user":{"login":"mtmcgrew","id":2164097,"avatar_url":"https://avatars.githubusercontent.com/u/2164097?v=2","gravatar_id":"","url":"https://api.github.com/users/mtmcgrew","html_url":"https://github.com/mtmcgrew","followers_url":"https://api.github.com/users/mtmcgrew/followers","following_url":"https://api.github.com/users/mtmcgrew/following{/other_user}","gists_url":"https://api.github.com/users/mtmcgrew/gists{/gist_id}","starred_url":"https://api.github.com/users/mtmcgrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtmcgrew/subscriptions","organizations_url":"https://api.github.com/users/mtmcgrew/orgs","repos_url":"https://api.github.com/users/mtmcgrew/repos","events_url":"https://api.github.com/users/mtmcgrew/events{/privacy}","received_events_url":"https://api.github.com/users/mtmcgrew/received_events","type":"User","site_admin":false},"body":"What is \"foo\", could a more descriptive variable be used?","created_at":"2014-10-29T18:20:08Z","updated_at":"2014-10-29T18:20:08Z","html_url":"https://github.com/facebook/osquery/pull/271#discussion_r19560317","pull_request_url":"https://api.github.com/repos/facebook/osquery/pulls/271","_links":{"self":{"href":"https://api.github.com/repos/facebook/osquery/pulls/comments/19560317"},"html":{"href":"https://github.com/facebook/osquery/pull/271#discussion_r19560317"},"pull_request":{"href":"https://api.github.com/repos/facebook/osquery/pulls/271"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/osquery/pulls/271","id":23548536,"html_url":"https://github.com/facebook/osquery/pull/271","diff_url":"https://github.com/facebook/osquery/pull/271.diff","patch_url":"https://github.com/facebook/osquery/pull/271.patch","issue_url":"https://api.github.com/repos/facebook/osquery/issues/271","number":271,"state":"open","locked":false,"title":"Arp","user":{"login":"pstorralba","id":257327,"avatar_url":"https://avatars.githubusercontent.com/u/257327?v=2","gravatar_id":"","url":"https://api.github.com/users/pstorralba","html_url":"https://github.com/pstorralba","followers_url":"https://api.github.com/users/pstorralba/followers","following_url":"https://api.github.com/users/pstorralba/following{/other_user}","gists_url":"https://api.github.com/users/pstorralba/gists{/gist_id}","starred_url":"https://api.github.com/users/pstorralba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pstorralba/subscriptions","organizations_url":"https://api.github.com/users/pstorralba/orgs","repos_url":"https://api.github.com/users/pstorralba/repos","events_url":"https://api.github.com/users/pstorralba/events{/privacy}","received_events_url":"https://api.github.com/users/pstorralba/received_events","type":"User","site_admin":false},"body":"Implemented #118 with 'system' call in osX (not found other way so far) and reading from /proc/net/arp in linux.\r\n\r\nInfo shown in vtable is: ip, arp, iface\r\nwhere arp is the mac address, and iface is the interface this entry was added from.","created_at":"2014-10-29T17:27:08Z","updated_at":"2014-10-29T18:20:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5edbff2e726f7b489f2d41a269d37aeb4b319e83","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facebook/osquery/pulls/271/commits","review_comments_url":"https://api.github.com/repos/facebook/osquery/pulls/271/comments","review_comment_url":"https://api.github.com/repos/facebook/osquery/pulls/comments/{number}","comments_url":"https://api.github.com/repos/facebook/osquery/issues/271/comments","statuses_url":"https://api.github.com/repos/facebook/osquery/statuses/a94b0bf6fd58d386cdb0f5c06e938c2b5c596450","head":{"label":"facebook:arp","ref":"arp","sha":"a94b0bf6fd58d386cdb0f5c06e938c2b5c596450","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=2","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":22394357,"name":"osquery","full_name":"facebook/osquery","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=2","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/osquery","description":"Operating system instrumentation and monitoring","fork":false,"url":"https://api.github.com/repos/facebook/osquery","forks_url":"https://api.github.com/repos/facebook/osquery/forks","keys_url":"https://api.github.com/repos/facebook/osquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/osquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/osquery/teams","hooks_url":"https://api.github.com/repos/facebook/osquery/hooks","issue_events_url":"https://api.github.com/repos/facebook/osquery/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/osquery/events","assignees_url":"https://api.github.com/repos/facebook/osquery/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/osquery/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/osquery/tags","blobs_url":"https://api.github.com/repos/facebook/osquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/osquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/osquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/osquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/osquery/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/osquery/languages","stargazers_url":"https://api.github.com/repos/facebook/osquery/stargazers","contributors_url":"https://api.github.com/repos/facebook/osquery/contributors","subscribers_url":"https://api.github.com/repos/facebook/osquery/subscribers","subscription_url":"https://api.github.com/repos/facebook/osquery/subscription","commits_url":"https://api.github.com/repos/facebook/osquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/osquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/osquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/osquery/issues/comments/{number}","contents_url":"https://api.github.com/repos/facebook/osquery/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/osquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/osquery/merges","archive_url":"https://api.github.com/repos/facebook/osquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/osquery/downloads","issues_url":"https://api.github.com/repos/facebook/osquery/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/osquery/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/osquery/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/osquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/osquery/labels{/name}","releases_url":"https://api.github.com/repos/facebook/osquery/releases{/id}","created_at":"2014-07-29T20:27:33Z","updated_at":"2014-10-29T18:19:35Z","pushed_at":"2014-10-29T18:18:35Z","git_url":"git://github.com/facebook/osquery.git","ssh_url":"git@github.com:facebook/osquery.git","clone_url":"https://github.com/facebook/osquery.git","svn_url":"https://github.com/facebook/osquery","homepage":"http://osquery.io","size":10400,"stargazers_count":77,"watchers_count":77,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":62,"forks":2,"open_issues":62,"watchers":77,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"6dee18c29c989b0810a9bc9fa953dc7540f634a5","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=2","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":22394357,"name":"osquery","full_name":"facebook/osquery","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=2","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/osquery","description":"Operating system instrumentation and monitoring","fork":false,"url":"https://api.github.com/repos/facebook/osquery","forks_url":"https://api.github.com/repos/facebook/osquery/forks","keys_url":"https://api.github.com/repos/facebook/osquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/osquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/osquery/teams","hooks_url":"https://api.github.com/repos/facebook/osquery/hooks","issue_events_url":"https://api.github.com/repos/facebook/osquery/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/osquery/events","assignees_url":"https://api.github.com/repos/facebook/osquery/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/osquery/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/osquery/tags","blobs_url":"https://api.github.com/repos/facebook/osquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/osquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/osquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/osquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/osquery/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/osquery/languages","stargazers_url":"https://api.github.com/repos/facebook/osquery/stargazers","contributors_url":"https://api.github.com/repos/facebook/osquery/contributors","subscribers_url":"https://api.github.com/repos/facebook/osquery/subscribers","subscription_url":"https://api.github.com/repos/facebook/osquery/subscription","commits_url":"https://api.github.com/repos/facebook/osquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/osquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/osquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/osquery/issues/comments/{number}","contents_url":"https://api.github.com/repos/facebook/osquery/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/osquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/osquery/merges","archive_url":"https://api.github.com/repos/facebook/osquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/osquery/downloads","issues_url":"https://api.github.com/repos/facebook/osquery/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/osquery/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/osquery/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/osquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/osquery/labels{/name}","releases_url":"https://api.github.com/repos/facebook/osquery/releases{/id}","created_at":"2014-07-29T20:27:33Z","updated_at":"2014-10-29T18:19:35Z","pushed_at":"2014-10-29T18:18:35Z","git_url":"git://github.com/facebook/osquery.git","ssh_url":"git@github.com:facebook/osquery.git","clone_url":"https://github.com/facebook/osquery.git","svn_url":"https://github.com/facebook/osquery","homepage":"http://osquery.io","size":10400,"stargazers_count":77,"watchers_count":77,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":62,"forks":2,"open_issues":62,"watchers":77,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/osquery/pulls/271"},"html":{"href":"https://github.com/facebook/osquery/pull/271"},"issue":{"href":"https://api.github.com/repos/facebook/osquery/issues/271"},"comments":{"href":"https://api.github.com/repos/facebook/osquery/issues/271/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/osquery/pulls/271/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/osquery/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/facebook/osquery/pulls/271/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/osquery/statuses/a94b0bf6fd58d386cdb0f5c06e938c2b5c596450"}}}}