GitHub PullRequestEvent at 2014-05-14 12:20:28
Repository: noscript
Actor: doochik
Payload: {"action":"closed","number":268,"pull_request":{"url":"https://api.github.com/repos/yandex-ui/noscript/pulls/268","id":15548581,"html_url":"https://github.com/yandex-ui/noscript/pull/268","diff_url":"https://github.com/yandex-ui/noscript/pull/268.diff","patch_url":"https://github.com/yandex-ui/noscript/pull/268.patch","issue_url":"https://api.github.com/repos/yandex-ui/noscript/issues/268","number":268,"state":"closed","title":"[ns.Update] Метрики производительности","user":{"login":"doochik","id":31961,"avatar_url":"https://avatars.githubusercontent.com/u/31961?","gravatar_id":"c6614b77fb5f3104068bb1a84038f2b7","url":"https://api.github.com/users/doochik","html_url":"https://github.com/doochik","followers_url":"https://api.github.com/users/doochik/followers","following_url":"https://api.github.com/users/doochik/following{/other_user}","gists_url":"https://api.github.com/users/doochik/gists{/gist_id}","starred_url":"https://api.github.com/users/doochik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doochik/subscriptions","organizations_url":"https://api.github.com/users/doochik/orgs","repos_url":"https://api.github.com/users/doochik/repos","events_url":"https://api.github.com/users/doochik/events{/privacy}","received_events_url":"https://api.github.com/users/doochik/received_events","type":"User","site_admin":false},"body":"У нас сейчас есть метрики производительности апдейтера. Чтобы их сделать приходится лезть в кишки, поэтому хочу предложить принести их сюда. Нам это надо, чтобы мерить каждый релиз на изменение скорости интерфейса.\r\n\r\nЧто мы мерим:\r\n 1. время подготовки дерева\r\n 2. время запроса на сервер\r\n 3. время создания дерева\r\n 4. время наложения шаблона\r\n 5. время отработки callback'ов\r\n\r\n+ плюс ко всему, эти метрики отправляются в виды, чтобы они могли логировать производительность критичных мест.\r\n\r\nСейчас мы логируем, когда чистое время выполнения в браузере (без учета запроса на сервер) превышает определенный порог, т.е. интерфейс фактически не работает в это время.\r\n\r\nЯ могу сделать pr и показать как это будет. Метрику надо отправлять в какой-то отдельный метод, чтобы приложение могло решить что с ней делать дальше.","created_at":"2014-05-06T15:54:22Z","updated_at":"2014-05-14T12:20:28Z","closed_at":"2014-05-14T12:20:27Z","merged_at":"2014-05-14T12:20:27Z","merge_commit_sha":"65b1556dfb6140467a39a94339f9df227db5c326","assignee":{"login":"doochik","id":31961,"avatar_url":"https://avatars.githubusercontent.com/u/31961?","gravatar_id":"c6614b77fb5f3104068bb1a84038f2b7","url":"https://api.github.com/users/doochik","html_url":"https://github.com/doochik","followers_url":"https://api.github.com/users/doochik/followers","following_url":"https://api.github.com/users/doochik/following{/other_user}","gists_url":"https://api.github.com/users/doochik/gists{/gist_id}","starred_url":"https://api.github.com/users/doochik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doochik/subscriptions","organizations_url":"https://api.github.com/users/doochik/orgs","repos_url":"https://api.github.com/users/doochik/repos","events_url":"https://api.github.com/users/doochik/events{/privacy}","received_events_url":"https://api.github.com/users/doochik/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/yandex-ui/noscript/pulls/268/commits","review_comments_url":"https://api.github.com/repos/yandex-ui/noscript/pulls/268/comments","review_comment_url":"https://api.github.com/repos/yandex-ui/noscript/pulls/comments/{number}","comments_url":"https://api.github.com/repos/yandex-ui/noscript/issues/268/comments","statuses_url":"https://api.github.com/repos/yandex-ui/noscript/statuses/452d22905be6a87031d6d6ebb506f712af4b1221","head":{"label":"yandex-ui:issue-268","ref":"issue-268","sha":"452d22905be6a87031d6d6ebb506f712af4b1221","user":{"login":"yandex-ui","id":914728,"avatar_url":"https://avatars.githubusercontent.com/u/914728?","gravatar_id":"ca4cee9af0bbfae9ce0c86f9e3a59953","url":"https://api.github.com/users/yandex-ui","html_url":"https://github.com/yandex-ui","followers_url":"https://api.github.com/users/yandex-ui/followers","following_url":"https://api.github.com/users/yandex-ui/following{/other_user}","gists_url":"https://api.github.com/users/yandex-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/yandex-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yandex-ui/subscriptions","organizations_url":"https://api.github.com/users/yandex-ui/orgs","repos_url":"https://api.github.com/users/yandex-ui/repos","events_url":"https://api.github.com/users/yandex-ui/events{/privacy}","received_events_url":"https://api.github.com/users/yandex-ui/received_events","type":"Organization","site_admin":false},"repo":{"id":2283674,"name":"noscript","full_name":"yandex-ui/noscript","owner":{"login":"yandex-ui","id":914728,"avatar_url":"https://avatars.githubusercontent.com/u/914728?","gravatar_id":"ca4cee9af0bbfae9ce0c86f9e3a59953","url":"https://api.github.com/users/yandex-ui","html_url":"https://github.com/yandex-ui","followers_url":"https://api.github.com/users/yandex-ui/followers","following_url":"https://api.github.com/users/yandex-ui/following{/other_user}","gists_url":"https://api.github.com/users/yandex-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/yandex-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yandex-ui/subscriptions","organizations_url":"https://api.github.com/users/yandex-ui/orgs","repos_url":"https://api.github.com/users/yandex-ui/repos","events_url":"https://api.github.com/users/yandex-ui/events{/privacy}","received_events_url":"https://api.github.com/users/yandex-ui/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yandex-ui/noscript","description":"noscript","fork":false,"url":"https://api.github.com/repos/yandex-ui/noscript","forks_url":"https://api.github.com/repos/yandex-ui/noscript/forks","keys_url":"https://api.github.com/repos/yandex-ui/noscript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yandex-ui/noscript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yandex-ui/noscript/teams","hooks_url":"https://api.github.com/repos/yandex-ui/noscript/hooks","issue_events_url":"https://api.github.com/repos/yandex-ui/noscript/issues/events{/number}","events_url":"https://api.github.com/repos/yandex-ui/noscript/events","assignees_url":"https://api.github.com/repos/yandex-ui/noscript/assignees{/user}","branches_url":"https://api.github.com/repos/yandex-ui/noscript/branches{/branch}","tags_url":"https://api.github.com/repos/yandex-ui/noscript/tags","blobs_url":"https://api.github.com/repos/yandex-ui/noscript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yandex-ui/noscript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yandex-ui/noscript/git/refs{/sha}","trees_url":"https://api.github.com/repos/yandex-ui/noscript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yandex-ui/noscript/statuses/{sha}","languages_url":"https://api.github.com/repos/yandex-ui/noscript/languages","stargazers_url":"https://api.github.com/repos/yandex-ui/noscript/stargazers","contributors_url":"https://api.github.com/repos/yandex-ui/noscript/contributors","subscribers_url":"https://api.github.com/repos/yandex-ui/noscript/subscribers","subscription_url":"https://api.github.com/repos/yandex-ui/noscript/subscription","commits_url":"https://api.github.com/repos/yandex-ui/noscript/commits{/sha}","git_commits_url":"https://api.github.com/repos/yandex-ui/noscript/git/commits{/sha}","comments_url":"https://api.github.com/repos/yandex-ui/noscript/comments{/number}","issue_comment_url":"https://api.github.com/repos/yandex-ui/noscript/issues/comments/{number}","contents_url":"https://api.github.com/repos/yandex-ui/noscript/contents/{+path}","compare_url":"https://api.github.com/repos/yandex-ui/noscript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yandex-ui/noscript/merges","archive_url":"https://api.github.com/repos/yandex-ui/noscript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yandex-ui/noscript/downloads","issues_url":"https://api.github.com/repos/yandex-ui/noscript/issues{/number}","pulls_url":"https://api.github.com/repos/yandex-ui/noscript/pulls{/number}","milestones_url":"https://api.github.com/repos/yandex-ui/noscript/milestones{/number}","notifications_url":"https://api.github.com/repos/yandex-ui/noscript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yandex-ui/noscript/labels{/name}","releases_url":"https://api.github.com/repos/yandex-ui/noscript/releases{/id}","created_at":"2011-08-28T14:55:35Z","updated_at":"2014-05-14T12:20:27Z","pushed_at":"2014-05-14T12:20:27Z","git_url":"git://github.com/yandex-ui/noscript.git","ssh_url":"git@github.com:yandex-ui/noscript.git","clone_url":"https://github.com/yandex-ui/noscript.git","svn_url":"https://github.com/yandex-ui/noscript","homepage":"","size":8200,"stargazers_count":22,"watchers_count":22,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":9,"mirror_url":null,"open_issues_count":86,"forks":9,"open_issues":86,"watchers":22,"default_branch":"master"}},"base":{"label":"yandex-ui:master","ref":"master","sha":"86abb8cdbfdf4a0b362e73aa0f82459102fad684","user":{"login":"yandex-ui","id":914728,"avatar_url":"https://avatars.githubusercontent.com/u/914728?","gravatar_id":"ca4cee9af0bbfae9ce0c86f9e3a59953","url":"https://api.github.com/users/yandex-ui","html_url":"https://github.com/yandex-ui","followers_url":"https://api.github.com/users/yandex-ui/followers","following_url":"https://api.github.com/users/yandex-ui/following{/other_user}","gists_url":"https://api.github.com/users/yandex-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/yandex-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yandex-ui/subscriptions","organizations_url":"https://api.github.com/users/yandex-ui/orgs","repos_url":"https://api.github.com/users/yandex-ui/repos","events_url":"https://api.github.com/users/yandex-ui/events{/privacy}","received_events_url":"https://api.github.com/users/yandex-ui/received_events","type":"Organization","site_admin":false},"repo":{"id":2283674,"name":"noscript","full_name":"yandex-ui/noscript","owner":{"login":"yandex-ui","id":914728,"avatar_url":"https://avatars.githubusercontent.com/u/914728?","gravatar_id":"ca4cee9af0bbfae9ce0c86f9e3a59953","url":"https://api.github.com/users/yandex-ui","html_url":"https://github.com/yandex-ui","followers_url":"https://api.github.com/users/yandex-ui/followers","following_url":"https://api.github.com/users/yandex-ui/following{/other_user}","gists_url":"https://api.github.com/users/yandex-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/yandex-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yandex-ui/subscriptions","organizations_url":"https://api.github.com/users/yandex-ui/orgs","repos_url":"https://api.github.com/users/yandex-ui/repos","events_url":"https://api.github.com/users/yandex-ui/events{/privacy}","received_events_url":"https://api.github.com/users/yandex-ui/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yandex-ui/noscript","description":"noscript","fork":false,"url":"https://api.github.com/repos/yandex-ui/noscript","forks_url":"https://api.github.com/repos/yandex-ui/noscript/forks","keys_url":"https://api.github.com/repos/yandex-ui/noscript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yandex-ui/noscript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yandex-ui/noscript/teams","hooks_url":"https://api.github.com/repos/yandex-ui/noscript/hooks","issue_events_url":"https://api.github.com/repos/yandex-ui/noscript/issues/events{/number}","events_url":"https://api.github.com/repos/yandex-ui/noscript/events","assignees_url":"https://api.github.com/repos/yandex-ui/noscript/assignees{/user}","branches_url":"https://api.github.com/repos/yandex-ui/noscript/branches{/branch}","tags_url":"https://api.github.com/repos/yandex-ui/noscript/tags","blobs_url":"https://api.github.com/repos/yandex-ui/noscript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yandex-ui/noscript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yandex-ui/noscript/git/refs{/sha}","trees_url":"https://api.github.com/repos/yandex-ui/noscript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yandex-ui/noscript/statuses/{sha}","languages_url":"https://api.github.com/repos/yandex-ui/noscript/languages","stargazers_url":"https://api.github.com/repos/yandex-ui/noscript/stargazers","contributors_url":"https://api.github.com/repos/yandex-ui/noscript/contributors","subscribers_url":"https://api.github.com/repos/yandex-ui/noscript/subscribers","subscription_url":"https://api.github.com/repos/yandex-ui/noscript/subscription","commits_url":"https://api.github.com/repos/yandex-ui/noscript/commits{/sha}","git_commits_url":"https://api.github.com/repos/yandex-ui/noscript/git/commits{/sha}","comments_url":"https://api.github.com/repos/yandex-ui/noscript/comments{/number}","issue_comment_url":"https://api.github.com/repos/yandex-ui/noscript/issues/comments/{number}","contents_url":"https://api.github.com/repos/yandex-ui/noscript/contents/{+path}","compare_url":"https://api.github.com/repos/yandex-ui/noscript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yandex-ui/noscript/merges","archive_url":"https://api.github.com/repos/yandex-ui/noscript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yandex-ui/noscript/downloads","issues_url":"https://api.github.com/repos/yandex-ui/noscript/issues{/number}","pulls_url":"https://api.github.com/repos/yandex-ui/noscript/pulls{/number}","milestones_url":"https://api.github.com/repos/yandex-ui/noscript/milestones{/number}","notifications_url":"https://api.github.com/repos/yandex-ui/noscript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yandex-ui/noscript/labels{/name}","releases_url":"https://api.github.com/repos/yandex-ui/noscript/releases{/id}","created_at":"2011-08-28T14:55:35Z","updated_at":"2014-05-14T12:20:27Z","pushed_at":"2014-05-14T12:20:27Z","git_url":"git://github.com/yandex-ui/noscript.git","ssh_url":"git@github.com:yandex-ui/noscript.git","clone_url":"https://github.com/yandex-ui/noscript.git","svn_url":"https://github.com/yandex-ui/noscript","homepage":"","size":8200,"stargazers_count":22,"watchers_count":22,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":9,"mirror_url":null,"open_issues_count":86,"forks":9,"open_issues":86,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yandex-ui/noscript/pulls/268"},"html":{"href":"https://github.com/yandex-ui/noscript/pull/268"},"issue":{"href":"https://api.github.com/repos/yandex-ui/noscript/issues/268"},"comments":{"href":"https://api.github.com/repos/yandex-ui/noscript/issues/268/comments"},"review_comments":{"href":"https://api.github.com/repos/yandex-ui/noscript/pulls/268/comments"},"review_comment":{"href":"https://api.github.com/repos/yandex-ui/noscript/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/yandex-ui/noscript/pulls/268/commits"},"statuses":{"href":"https://api.github.com/repos/yandex-ui/noscript/statuses/452d22905be6a87031d6d6ebb506f712af4b1221"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"doochik","id":31961,"avatar_url":"https://avatars.githubusercontent.com/u/31961?","gravatar_id":"c6614b77fb5f3104068bb1a84038f2b7","url":"https://api.github.com/users/doochik","html_url":"https://github.com/doochik","followers_url":"https://api.github.com/users/doochik/followers","following_url":"https://api.github.com/users/doochik/following{/other_user}","gists_url":"https://api.github.com/users/doochik/gists{/gist_id}","starred_url":"https://api.github.com/users/doochik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doochik/subscriptions","organizations_url":"https://api.github.com/users/doochik/orgs","repos_url":"https://api.github.com/users/doochik/repos","events_url":"https://api.github.com/users/doochik/events{/privacy}","received_events_url":"https://api.github.com/users/doochik/received_events","type":"User","site_admin":false},"comments":26,"review_comments":2,"commits":2,"additions":157,"deletions":2,"changed_files":5}}