GitHub PullRequestEvent at 2014-04-17 23:08:00
Repository: ansible
Actor: joshuaconner
Payload: {"action":"closed","number":7046,"pull_request":{"url":"https://api.github.com/repos/ansible/ansible/pulls/7046","id":14901698,"html_url":"https://github.com/ansible/ansible/pull/7046","diff_url":"https://github.com/ansible/ansible/pull/7046.diff","patch_url":"https://github.com/ansible/ansible/pull/7046.patch","issue_url":"https://api.github.com/repos/ansible/ansible/issues/7046","number":7046,"state":"closed","title":"docker: correctly compare 'command' param against existing container command'","user":{"login":"joshuaconner","id":1056986,"avatar_url":"https://avatars.githubusercontent.com/u/1056986?","gravatar_id":"77f6f0c66d30b29b6ef402a63132495e","url":"https://api.github.com/users/joshuaconner","html_url":"https://github.com/joshuaconner","followers_url":"https://api.github.com/users/joshuaconner/followers","following_url":"https://api.github.com/users/joshuaconner/following{/other_user}","gists_url":"https://api.github.com/users/joshuaconner/gists{/gist_id}","starred_url":"https://api.github.com/users/joshuaconner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshuaconner/subscriptions","organizations_url":"https://api.github.com/users/joshuaconner/orgs","repos_url":"https://api.github.com/users/joshuaconner/repos","events_url":"https://api.github.com/users/joshuaconner/events{/privacy}","received_events_url":"https://api.github.com/users/joshuaconner/received_events","type":"User","site_admin":false},"body":"If a container has an \"entrypoint\" in addition to a \"command\", the Docker API will return \"{} {}\".format(entrypoint, command) for the value of 'Command' in the container summary JSON. This checks if a container's 'Command' value **ends with** module.params('command') instead of equals it so that containers with entrypoints are correctly classified as match the module's argument spec. (I think this is what caused #6395, and should fix it)","created_at":"2014-04-17T23:00:44Z","updated_at":"2014-04-17T23:07:59Z","closed_at":"2014-04-17T23:07:59Z","merged_at":null,"merge_commit_sha":"06f2bdfa4d4738422f11bfd390a43b08f9337ada","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ansible/ansible/pulls/7046/commits","review_comments_url":"https://api.github.com/repos/ansible/ansible/pulls/7046/comments","review_comment_url":"https://api.github.com/repos/ansible/ansible/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ansible/ansible/issues/7046/comments","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/7a639a8eac6d01cc05f747cbd75ce455b2ee5383","head":{"label":"joshuaconner:docker_exclude_entrypoint_from_command_check","ref":"docker_exclude_entrypoint_from_command_check","sha":"7a639a8eac6d01cc05f747cbd75ce455b2ee5383","user":{"login":"joshuaconner","id":1056986,"avatar_url":"https://avatars.githubusercontent.com/u/1056986?","gravatar_id":"77f6f0c66d30b29b6ef402a63132495e","url":"https://api.github.com/users/joshuaconner","html_url":"https://github.com/joshuaconner","followers_url":"https://api.github.com/users/joshuaconner/followers","following_url":"https://api.github.com/users/joshuaconner/following{/other_user}","gists_url":"https://api.github.com/users/joshuaconner/gists{/gist_id}","starred_url":"https://api.github.com/users/joshuaconner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshuaconner/subscriptions","organizations_url":"https://api.github.com/users/joshuaconner/orgs","repos_url":"https://api.github.com/users/joshuaconner/repos","events_url":"https://api.github.com/users/joshuaconner/events{/privacy}","received_events_url":"https://api.github.com/users/joshuaconner/received_events","type":"User","site_admin":false},"repo":{"id":14633823,"name":"ansible","full_name":"joshuaconner/ansible","owner":{"login":"joshuaconner","id":1056986,"avatar_url":"https://avatars.githubusercontent.com/u/1056986?","gravatar_id":"77f6f0c66d30b29b6ef402a63132495e","url":"https://api.github.com/users/joshuaconner","html_url":"https://github.com/joshuaconner","followers_url":"https://api.github.com/users/joshuaconner/followers","following_url":"https://api.github.com/users/joshuaconner/following{/other_user}","gists_url":"https://api.github.com/users/joshuaconner/gists{/gist_id}","starred_url":"https://api.github.com/users/joshuaconner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshuaconner/subscriptions","organizations_url":"https://api.github.com/users/joshuaconner/orgs","repos_url":"https://api.github.com/users/joshuaconner/repos","events_url":"https://api.github.com/users/joshuaconner/events{/privacy}","received_events_url":"https://api.github.com/users/joshuaconner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joshuaconner/ansible","description":"Ansible is a radically simple IT orchestration engine that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications— automate in a language that approaches plain English, using SSH, with no agents to install on remote systems.","fork":true,"url":"https://api.github.com/repos/joshuaconner/ansible","forks_url":"https://api.github.com/repos/joshuaconner/ansible/forks","keys_url":"https://api.github.com/repos/joshuaconner/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joshuaconner/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joshuaconner/ansible/teams","hooks_url":"https://api.github.com/repos/joshuaconner/ansible/hooks","issue_events_url":"https://api.github.com/repos/joshuaconner/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/joshuaconner/ansible/events","assignees_url":"https://api.github.com/repos/joshuaconner/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/joshuaconner/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/joshuaconner/ansible/tags","blobs_url":"https://api.github.com/repos/joshuaconner/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joshuaconner/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joshuaconner/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/joshuaconner/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joshuaconner/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/joshuaconner/ansible/languages","stargazers_url":"https://api.github.com/repos/joshuaconner/ansible/stargazers","contributors_url":"https://api.github.com/repos/joshuaconner/ansible/contributors","subscribers_url":"https://api.github.com/repos/joshuaconner/ansible/subscribers","subscription_url":"https://api.github.com/repos/joshuaconner/ansible/subscription","commits_url":"https://api.github.com/repos/joshuaconner/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/joshuaconner/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/joshuaconner/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/joshuaconner/ansible/issues/comments/{number}","contents_url":"https://api.github.com/repos/joshuaconner/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/joshuaconner/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joshuaconner/ansible/merges","archive_url":"https://api.github.com/repos/joshuaconner/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joshuaconner/ansible/downloads","issues_url":"https://api.github.com/repos/joshuaconner/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/joshuaconner/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/joshuaconner/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/joshuaconner/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joshuaconner/ansible/labels{/name}","releases_url":"https://api.github.com/repos/joshuaconner/ansible/releases{/id}","created_at":"2013-11-23T01:09:40Z","updated_at":"2014-04-17T23:05:59Z","pushed_at":"2014-04-17T23:05:59Z","git_url":"git://github.com/joshuaconner/ansible.git","ssh_url":"git@github.com:joshuaconner/ansible.git","clone_url":"https://github.com/joshuaconner/ansible.git","svn_url":"https://github.com/joshuaconner/ansible","homepage":"http://ansibleworks.com/","size":18819,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"ansible:devel","ref":"devel","sha":"632eb18333f5da96375655d71897e33b3c0e9c1a","user":{"login":"ansible","id":1507452,"avatar_url":"https://avatars.githubusercontent.com/u/1507452?","gravatar_id":"f9759b728f6026571043dc66cd36edf2","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"repo":{"id":3638964,"name":"ansible","full_name":"ansible/ansible","owner":{"login":"ansible","id":1507452,"avatar_url":"https://avatars.githubusercontent.com/u/1507452?","gravatar_id":"f9759b728f6026571043dc66cd36edf2","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ansible/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications— automate in a language that approaches plain English, using SSH, with no agents to install on remote systems.","fork":false,"url":"https://api.github.com/repos/ansible/ansible","forks_url":"https://api.github.com/repos/ansible/ansible/forks","keys_url":"https://api.github.com/repos/ansible/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ansible/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ansible/ansible/teams","hooks_url":"https://api.github.com/repos/ansible/ansible/hooks","issue_events_url":"https://api.github.com/repos/ansible/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ansible/ansible/events","assignees_url":"https://api.github.com/repos/ansible/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ansible/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ansible/ansible/tags","blobs_url":"https://api.github.com/repos/ansible/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ansible/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ansible/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ansible/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ansible/ansible/languages","stargazers_url":"https://api.github.com/repos/ansible/ansible/stargazers","contributors_url":"https://api.github.com/repos/ansible/ansible/contributors","subscribers_url":"https://api.github.com/repos/ansible/ansible/subscribers","subscription_url":"https://api.github.com/repos/ansible/ansible/subscription","commits_url":"https://api.github.com/repos/ansible/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ansible/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ansible/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ansible/ansible/issues/comments/{number}","contents_url":"https://api.github.com/repos/ansible/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ansible/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ansible/ansible/merges","archive_url":"https://api.github.com/repos/ansible/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ansible/ansible/downloads","issues_url":"https://api.github.com/repos/ansible/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ansible/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ansible/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ansible/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ansible/ansible/labels{/name}","releases_url":"https://api.github.com/repos/ansible/ansible/releases{/id}","created_at":"2012-03-06T14:58:02Z","updated_at":"2014-04-17T22:34:36Z","pushed_at":"2014-04-17T22:34:39Z","git_url":"git://github.com/ansible/ansible.git","ssh_url":"git@github.com:ansible/ansible.git","clone_url":"https://github.com/ansible/ansible.git","svn_url":"https://github.com/ansible/ansible","homepage":"http://ansible.com/","size":109600,"stargazers_count":5607,"watchers_count":5607,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":1660,"mirror_url":null,"open_issues_count":389,"forks":1660,"open_issues":389,"watchers":5607,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/7046"},"html":{"href":"https://github.com/ansible/ansible/pull/7046"},"issue":{"href":"https://api.github.com/repos/ansible/ansible/issues/7046"},"comments":{"href":"https://api.github.com/repos/ansible/ansible/issues/7046/comments"},"review_comments":{"href":"https://api.github.com/repos/ansible/ansible/pulls/7046/comments"},"review_comment":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ansible/ansible/pulls/7046/commits"},"statuses":{"href":"https://api.github.com/repos/ansible/ansible/statuses/7a639a8eac6d01cc05f747cbd75ce455b2ee5383"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":16,"deletions":12,"changed_files":1}}