GitHub PullRequestReviewCommentEvent at 2014-06-06 18:22:24
Repository: firefly
Actor: prat0318
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Yelp/firefly/pulls/comments/13503592","id":13503592,"diff_hunk":"@@ -72,7 +72,9 @@ class GraphBaseHandler(tornado.web.RequestHandler):\n     \"\"\"Base class implementing common ops\"\"\"\n \n     def get_params(self):\n-        sources = json.loads(self.get_argument('sources'))\n+        sources = self.get_argument('sources', '')\n+        if sources != '':","path":"firefly/data_server.py","position":6,"original_position":6,"commit_id":"202ce80bf97659639882cf405aa03d9224752dc4","original_commit_id":"202ce80bf97659639882cf405aa03d9224752dc4","user":{"login":"prat0318","id":1528697,"avatar_url":"https://avatars.githubusercontent.com/u/1528697?","gravatar_id":"c347f19cf8175355f6d2433a53ba15a5","url":"https://api.github.com/users/prat0318","html_url":"https://github.com/prat0318","followers_url":"https://api.github.com/users/prat0318/followers","following_url":"https://api.github.com/users/prat0318/following{/other_user}","gists_url":"https://api.github.com/users/prat0318/gists{/gist_id}","starred_url":"https://api.github.com/users/prat0318/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prat0318/subscriptions","organizations_url":"https://api.github.com/users/prat0318/orgs","repos_url":"https://api.github.com/users/prat0318/repos","events_url":"https://api.github.com/users/prat0318/events{/privacy}","received_events_url":"https://api.github.com/users/prat0318/received_events","type":"User","site_admin":false},"body":"could just be `if sources:`","created_at":"2014-06-06T18:22:24Z","updated_at":"2014-06-06T18:22:24Z","html_url":"https://github.com/Yelp/firefly/pull/84#discussion_r13503592","pull_request_url":"https://api.github.com/repos/Yelp/firefly/pulls/84","_links":{"self":{"href":"https://api.github.com/repos/Yelp/firefly/pulls/comments/13503592"},"html":{"href":"https://github.com/Yelp/firefly/pull/84#discussion_r13503592"},"pull_request":{"href":"https://api.github.com/repos/Yelp/firefly/pulls/84"}}},"pull_request":{"url":"https://api.github.com/repos/Yelp/firefly/pulls/84","id":16834553,"html_url":"https://github.com/Yelp/firefly/pull/84","diff_url":"https://github.com/Yelp/firefly/pull/84.diff","patch_url":"https://github.com/Yelp/firefly/pull/84.patch","issue_url":"https://api.github.com/repos/Yelp/firefly/issues/84","number":84,"state":"open","title":"Fixed 404 error that occurs when sources in not in GET params","user":{"login":"akhil-m","id":2562130,"avatar_url":"https://avatars.githubusercontent.com/u/2562130?","gravatar_id":"ba87a1e469b8eef518a1eeeed3ffbdc2","url":"https://api.github.com/users/akhil-m","html_url":"https://github.com/akhil-m","followers_url":"https://api.github.com/users/akhil-m/followers","following_url":"https://api.github.com/users/akhil-m/following{/other_user}","gists_url":"https://api.github.com/users/akhil-m/gists{/gist_id}","starred_url":"https://api.github.com/users/akhil-m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akhil-m/subscriptions","organizations_url":"https://api.github.com/users/akhil-m/orgs","repos_url":"https://api.github.com/users/akhil-m/repos","events_url":"https://api.github.com/users/akhil-m/events{/privacy}","received_events_url":"https://api.github.com/users/akhil-m/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-06-06T18:14:33Z","updated_at":"2014-06-06T18:22:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"498d7256827bb04fbad524a125c957bb67a5589d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Yelp/firefly/pulls/84/commits","review_comments_url":"https://api.github.com/repos/Yelp/firefly/pulls/84/comments","review_comment_url":"https://api.github.com/repos/Yelp/firefly/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Yelp/firefly/issues/84/comments","statuses_url":"https://api.github.com/repos/Yelp/firefly/statuses/202ce80bf97659639882cf405aa03d9224752dc4","head":{"label":"akhil-m:fix_404_missing_argument_sources","ref":"fix_404_missing_argument_sources","sha":"202ce80bf97659639882cf405aa03d9224752dc4","user":{"login":"akhil-m","id":2562130,"avatar_url":"https://avatars.githubusercontent.com/u/2562130?","gravatar_id":"ba87a1e469b8eef518a1eeeed3ffbdc2","url":"https://api.github.com/users/akhil-m","html_url":"https://github.com/akhil-m","followers_url":"https://api.github.com/users/akhil-m/followers","following_url":"https://api.github.com/users/akhil-m/following{/other_user}","gists_url":"https://api.github.com/users/akhil-m/gists{/gist_id}","starred_url":"https://api.github.com/users/akhil-m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akhil-m/subscriptions","organizations_url":"https://api.github.com/users/akhil-m/orgs","repos_url":"https://api.github.com/users/akhil-m/repos","events_url":"https://api.github.com/users/akhil-m/events{/privacy}","received_events_url":"https://api.github.com/users/akhil-m/received_events","type":"User","site_admin":false},"repo":{"id":20421365,"name":"firefly","full_name":"akhil-m/firefly","owner":{"login":"akhil-m","id":2562130,"avatar_url":"https://avatars.githubusercontent.com/u/2562130?","gravatar_id":"ba87a1e469b8eef518a1eeeed3ffbdc2","url":"https://api.github.com/users/akhil-m","html_url":"https://github.com/akhil-m","followers_url":"https://api.github.com/users/akhil-m/followers","following_url":"https://api.github.com/users/akhil-m/following{/other_user}","gists_url":"https://api.github.com/users/akhil-m/gists{/gist_id}","starred_url":"https://api.github.com/users/akhil-m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akhil-m/subscriptions","organizations_url":"https://api.github.com/users/akhil-m/orgs","repos_url":"https://api.github.com/users/akhil-m/repos","events_url":"https://api.github.com/users/akhil-m/events{/privacy}","received_events_url":"https://api.github.com/users/akhil-m/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/akhil-m/firefly","description":"Firefly is a web application aimed at powerful, flexible time series graphing for web developers.","fork":true,"url":"https://api.github.com/repos/akhil-m/firefly","forks_url":"https://api.github.com/repos/akhil-m/firefly/forks","keys_url":"https://api.github.com/repos/akhil-m/firefly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akhil-m/firefly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akhil-m/firefly/teams","hooks_url":"https://api.github.com/repos/akhil-m/firefly/hooks","issue_events_url":"https://api.github.com/repos/akhil-m/firefly/issues/events{/number}","events_url":"https://api.github.com/repos/akhil-m/firefly/events","assignees_url":"https://api.github.com/repos/akhil-m/firefly/assignees{/user}","branches_url":"https://api.github.com/repos/akhil-m/firefly/branches{/branch}","tags_url":"https://api.github.com/repos/akhil-m/firefly/tags","blobs_url":"https://api.github.com/repos/akhil-m/firefly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akhil-m/firefly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akhil-m/firefly/git/refs{/sha}","trees_url":"https://api.github.com/repos/akhil-m/firefly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akhil-m/firefly/statuses/{sha}","languages_url":"https://api.github.com/repos/akhil-m/firefly/languages","stargazers_url":"https://api.github.com/repos/akhil-m/firefly/stargazers","contributors_url":"https://api.github.com/repos/akhil-m/firefly/contributors","subscribers_url":"https://api.github.com/repos/akhil-m/firefly/subscribers","subscription_url":"https://api.github.com/repos/akhil-m/firefly/subscription","commits_url":"https://api.github.com/repos/akhil-m/firefly/commits{/sha}","git_commits_url":"https://api.github.com/repos/akhil-m/firefly/git/commits{/sha}","comments_url":"https://api.github.com/repos/akhil-m/firefly/comments{/number}","issue_comment_url":"https://api.github.com/repos/akhil-m/firefly/issues/comments/{number}","contents_url":"https://api.github.com/repos/akhil-m/firefly/contents/{+path}","compare_url":"https://api.github.com/repos/akhil-m/firefly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akhil-m/firefly/merges","archive_url":"https://api.github.com/repos/akhil-m/firefly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akhil-m/firefly/downloads","issues_url":"https://api.github.com/repos/akhil-m/firefly/issues{/number}","pulls_url":"https://api.github.com/repos/akhil-m/firefly/pulls{/number}","milestones_url":"https://api.github.com/repos/akhil-m/firefly/milestones{/number}","notifications_url":"https://api.github.com/repos/akhil-m/firefly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akhil-m/firefly/labels{/name}","releases_url":"https://api.github.com/repos/akhil-m/firefly/releases{/id}","created_at":"2014-06-02T22:05:36Z","updated_at":"2014-06-06T18:14:33Z","pushed_at":"2014-06-06T18:13:11Z","git_url":"git://github.com/akhil-m/firefly.git","ssh_url":"git@github.com:akhil-m/firefly.git","clone_url":"https://github.com/akhil-m/firefly.git","svn_url":"https://github.com/akhil-m/firefly","homepage":"","size":526,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Yelp:master","ref":"master","sha":"f22c6d4fbb725d4f5ed8cda37b439016b1402506","user":{"login":"Yelp","id":49071,"avatar_url":"https://avatars.githubusercontent.com/u/49071?","gravatar_id":"cedaa6f42505b701ae74f53ea1783c0b","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"repo":{"id":5347666,"name":"firefly","full_name":"Yelp/firefly","owner":{"login":"Yelp","id":49071,"avatar_url":"https://avatars.githubusercontent.com/u/49071?","gravatar_id":"cedaa6f42505b701ae74f53ea1783c0b","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Yelp/firefly","description":"Firefly is a web application aimed at powerful, flexible time series graphing for web developers.","fork":false,"url":"https://api.github.com/repos/Yelp/firefly","forks_url":"https://api.github.com/repos/Yelp/firefly/forks","keys_url":"https://api.github.com/repos/Yelp/firefly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yelp/firefly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yelp/firefly/teams","hooks_url":"https://api.github.com/repos/Yelp/firefly/hooks","issue_events_url":"https://api.github.com/repos/Yelp/firefly/issues/events{/number}","events_url":"https://api.github.com/repos/Yelp/firefly/events","assignees_url":"https://api.github.com/repos/Yelp/firefly/assignees{/user}","branches_url":"https://api.github.com/repos/Yelp/firefly/branches{/branch}","tags_url":"https://api.github.com/repos/Yelp/firefly/tags","blobs_url":"https://api.github.com/repos/Yelp/firefly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yelp/firefly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yelp/firefly/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yelp/firefly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yelp/firefly/statuses/{sha}","languages_url":"https://api.github.com/repos/Yelp/firefly/languages","stargazers_url":"https://api.github.com/repos/Yelp/firefly/stargazers","contributors_url":"https://api.github.com/repos/Yelp/firefly/contributors","subscribers_url":"https://api.github.com/repos/Yelp/firefly/subscribers","subscription_url":"https://api.github.com/repos/Yelp/firefly/subscription","commits_url":"https://api.github.com/repos/Yelp/firefly/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yelp/firefly/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yelp/firefly/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yelp/firefly/issues/comments/{number}","contents_url":"https://api.github.com/repos/Yelp/firefly/contents/{+path}","compare_url":"https://api.github.com/repos/Yelp/firefly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yelp/firefly/merges","archive_url":"https://api.github.com/repos/Yelp/firefly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yelp/firefly/downloads","issues_url":"https://api.github.com/repos/Yelp/firefly/issues{/number}","pulls_url":"https://api.github.com/repos/Yelp/firefly/pulls{/number}","milestones_url":"https://api.github.com/repos/Yelp/firefly/milestones{/number}","notifications_url":"https://api.github.com/repos/Yelp/firefly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yelp/firefly/labels{/name}","releases_url":"https://api.github.com/repos/Yelp/firefly/releases{/id}","created_at":"2012-08-08T21:10:21Z","updated_at":"2014-06-05T19:48:09Z","pushed_at":"2014-06-03T22:08:47Z","git_url":"git://github.com/Yelp/firefly.git","ssh_url":"git@github.com:Yelp/firefly.git","clone_url":"https://github.com/Yelp/firefly.git","svn_url":"https://github.com/Yelp/firefly","homepage":"","size":873,"stargazers_count":102,"watchers_count":102,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":33,"mirror_url":null,"open_issues_count":28,"forks":33,"open_issues":28,"watchers":102,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Yelp/firefly/pulls/84"},"html":{"href":"https://github.com/Yelp/firefly/pull/84"},"issue":{"href":"https://api.github.com/repos/Yelp/firefly/issues/84"},"comments":{"href":"https://api.github.com/repos/Yelp/firefly/issues/84/comments"},"review_comments":{"href":"https://api.github.com/repos/Yelp/firefly/pulls/84/comments"},"review_comment":{"href":"https://api.github.com/repos/Yelp/firefly/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Yelp/firefly/pulls/84/commits"},"statuses":{"href":"https://api.github.com/repos/Yelp/firefly/statuses/202ce80bf97659639882cf405aa03d9224752dc4"}}}}