GitHub PullRequestEvent at 2014-05-01 23:45:24
Repository: salt
Actor: thatch45
Payload: {"action":"closed","number":12475,"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/12475","id":15412401,"html_url":"https://github.com/saltstack/salt/pull/12475","diff_url":"https://github.com/saltstack/salt/pull/12475.diff","patch_url":"https://github.com/saltstack/salt/pull/12475.patch","issue_url":"https://api.github.com/repos/saltstack/salt/issues/12475","number":12475,"state":"closed","title":"salt-ssh should use argv rather than using join/split/join on command","user":{"login":"plastikos","id":3281727,"avatar_url":"https://avatars.githubusercontent.com/u/3281727?","gravatar_id":"357a2668ed6a7ddb6fce3d6fb25af08a","url":"https://api.github.com/users/plastikos","html_url":"https://github.com/plastikos","followers_url":"https://api.github.com/users/plastikos/followers","following_url":"https://api.github.com/users/plastikos/following{/other_user}","gists_url":"https://api.github.com/users/plastikos/gists{/gist_id}","starred_url":"https://api.github.com/users/plastikos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plastikos/subscriptions","organizations_url":"https://api.github.com/users/plastikos/orgs","repos_url":"https://api.github.com/users/plastikos/repos","events_url":"https://api.github.com/users/plastikos/events{/privacy}","received_events_url":"https://api.github.com/users/plastikos/received_events","type":"User","site_admin":false},"body":"strings.  The latter can be quite dangerous for detecting appropriate\r\nword boundaries and may not be identical to shell arg parsing.\r\n\r\nThe argv use should be carried into ssh.Single, but that is a future exercise.","created_at":"2014-05-01T23:02:27Z","updated_at":"2014-05-01T23:45:23Z","closed_at":"2014-05-01T23:45:23Z","merged_at":"2014-05-01T23:45:23Z","merge_commit_sha":"9aedcbd9be374e3cde67cca015dfc4595c3eb569","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/saltstack/salt/pulls/12475/commits","review_comments_url":"https://api.github.com/repos/saltstack/salt/pulls/12475/comments","review_comment_url":"https://api.github.com/repos/saltstack/salt/pulls/comments/{number}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/12475/comments","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/1306fc3efa61e2fab55c47a7201c27cfdaa51574","head":{"label":"plastikos:improvement-use_argv_rather_than_arg_str","ref":"improvement-use_argv_rather_than_arg_str","sha":"1306fc3efa61e2fab55c47a7201c27cfdaa51574","user":{"login":"plastikos","id":3281727,"avatar_url":"https://avatars.githubusercontent.com/u/3281727?","gravatar_id":"357a2668ed6a7ddb6fce3d6fb25af08a","url":"https://api.github.com/users/plastikos","html_url":"https://github.com/plastikos","followers_url":"https://api.github.com/users/plastikos/followers","following_url":"https://api.github.com/users/plastikos/following{/other_user}","gists_url":"https://api.github.com/users/plastikos/gists{/gist_id}","starred_url":"https://api.github.com/users/plastikos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plastikos/subscriptions","organizations_url":"https://api.github.com/users/plastikos/orgs","repos_url":"https://api.github.com/users/plastikos/repos","events_url":"https://api.github.com/users/plastikos/events{/privacy}","received_events_url":"https://api.github.com/users/plastikos/received_events","type":"User","site_admin":false},"repo":{"id":16357700,"name":"salt","full_name":"plastikos/salt","owner":{"login":"plastikos","id":3281727,"avatar_url":"https://avatars.githubusercontent.com/u/3281727?","gravatar_id":"357a2668ed6a7ddb6fce3d6fb25af08a","url":"https://api.github.com/users/plastikos","html_url":"https://github.com/plastikos","followers_url":"https://api.github.com/users/plastikos/followers","following_url":"https://api.github.com/users/plastikos/following{/other_user}","gists_url":"https://api.github.com/users/plastikos/gists{/gist_id}","starred_url":"https://api.github.com/users/plastikos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plastikos/subscriptions","organizations_url":"https://api.github.com/users/plastikos/orgs","repos_url":"https://api.github.com/users/plastikos/repos","events_url":"https://api.github.com/users/plastikos/events{/privacy}","received_events_url":"https://api.github.com/users/plastikos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/plastikos/salt","description":"Central system and configuration manager ","fork":true,"url":"https://api.github.com/repos/plastikos/salt","forks_url":"https://api.github.com/repos/plastikos/salt/forks","keys_url":"https://api.github.com/repos/plastikos/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plastikos/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plastikos/salt/teams","hooks_url":"https://api.github.com/repos/plastikos/salt/hooks","issue_events_url":"https://api.github.com/repos/plastikos/salt/issues/events{/number}","events_url":"https://api.github.com/repos/plastikos/salt/events","assignees_url":"https://api.github.com/repos/plastikos/salt/assignees{/user}","branches_url":"https://api.github.com/repos/plastikos/salt/branches{/branch}","tags_url":"https://api.github.com/repos/plastikos/salt/tags","blobs_url":"https://api.github.com/repos/plastikos/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plastikos/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plastikos/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/plastikos/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plastikos/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/plastikos/salt/languages","stargazers_url":"https://api.github.com/repos/plastikos/salt/stargazers","contributors_url":"https://api.github.com/repos/plastikos/salt/contributors","subscribers_url":"https://api.github.com/repos/plastikos/salt/subscribers","subscription_url":"https://api.github.com/repos/plastikos/salt/subscription","commits_url":"https://api.github.com/repos/plastikos/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/plastikos/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/plastikos/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/plastikos/salt/issues/comments/{number}","contents_url":"https://api.github.com/repos/plastikos/salt/contents/{+path}","compare_url":"https://api.github.com/repos/plastikos/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plastikos/salt/merges","archive_url":"https://api.github.com/repos/plastikos/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plastikos/salt/downloads","issues_url":"https://api.github.com/repos/plastikos/salt/issues{/number}","pulls_url":"https://api.github.com/repos/plastikos/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/plastikos/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/plastikos/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plastikos/salt/labels{/name}","releases_url":"https://api.github.com/repos/plastikos/salt/releases{/id}","created_at":"2014-01-29T20:25:32Z","updated_at":"2014-05-01T23:45:23Z","pushed_at":"2014-05-01T23:00:17Z","git_url":"git://github.com/plastikos/salt.git","ssh_url":"git@github.com:plastikos/salt.git","clone_url":"https://github.com/plastikos/salt.git","svn_url":"https://github.com/plastikos/salt","homepage":"saltstack.org","size":46598,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"saltstack:develop","ref":"develop","sha":"2886ee5888d49729a9e96f00c888ecdc8316ce23","user":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars.githubusercontent.com/u/1147473?","gravatar_id":"8e25be5fcc652c85b518a5755986615f","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"repo":{"id":1390248,"name":"salt","full_name":"saltstack/salt","owner":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars.githubusercontent.com/u/1147473?","gravatar_id":"8e25be5fcc652c85b518a5755986615f","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/saltstack/salt","description":"Infrastructure automation and management system","fork":false,"url":"https://api.github.com/repos/saltstack/salt","forks_url":"https://api.github.com/repos/saltstack/salt/forks","keys_url":"https://api.github.com/repos/saltstack/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saltstack/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saltstack/salt/teams","hooks_url":"https://api.github.com/repos/saltstack/salt/hooks","issue_events_url":"https://api.github.com/repos/saltstack/salt/issues/events{/number}","events_url":"https://api.github.com/repos/saltstack/salt/events","assignees_url":"https://api.github.com/repos/saltstack/salt/assignees{/user}","branches_url":"https://api.github.com/repos/saltstack/salt/branches{/branch}","tags_url":"https://api.github.com/repos/saltstack/salt/tags","blobs_url":"https://api.github.com/repos/saltstack/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saltstack/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saltstack/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/saltstack/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/saltstack/salt/languages","stargazers_url":"https://api.github.com/repos/saltstack/salt/stargazers","contributors_url":"https://api.github.com/repos/saltstack/salt/contributors","subscribers_url":"https://api.github.com/repos/saltstack/salt/subscribers","subscription_url":"https://api.github.com/repos/saltstack/salt/subscription","commits_url":"https://api.github.com/repos/saltstack/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/saltstack/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/saltstack/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/saltstack/salt/issues/comments/{number}","contents_url":"https://api.github.com/repos/saltstack/salt/contents/{+path}","compare_url":"https://api.github.com/repos/saltstack/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saltstack/salt/merges","archive_url":"https://api.github.com/repos/saltstack/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saltstack/salt/downloads","issues_url":"https://api.github.com/repos/saltstack/salt/issues{/number}","pulls_url":"https://api.github.com/repos/saltstack/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/saltstack/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/saltstack/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saltstack/salt/labels{/name}","releases_url":"https://api.github.com/repos/saltstack/salt/releases{/id}","created_at":"2011-02-20T20:16:56Z","updated_at":"2014-05-01T23:45:23Z","pushed_at":"2014-05-01T23:45:23Z","git_url":"git://github.com/saltstack/salt.git","ssh_url":"git@github.com:saltstack/salt.git","clone_url":"https://github.com/saltstack/salt.git","svn_url":"https://github.com/saltstack/salt","homepage":"saltstack.com","size":120067,"stargazers_count":3379,"watchers_count":3379,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1323,"mirror_url":null,"open_issues_count":1233,"forks":1323,"open_issues":1233,"watchers":3379,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/12475"},"html":{"href":"https://github.com/saltstack/salt/pull/12475"},"issue":{"href":"https://api.github.com/repos/saltstack/salt/issues/12475"},"comments":{"href":"https://api.github.com/repos/saltstack/salt/issues/12475/comments"},"review_comments":{"href":"https://api.github.com/repos/saltstack/salt/pulls/12475/comments"},"review_comment":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/saltstack/salt/pulls/12475/commits"},"statuses":{"href":"https://api.github.com/repos/saltstack/salt/statuses/1306fc3efa61e2fab55c47a7201c27cfdaa51574"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"thatch45","id":507599,"avatar_url":"https://avatars.githubusercontent.com/u/507599?","gravatar_id":"ff7bc69b52eecf808141c470543db4f3","url":"https://api.github.com/users/thatch45","html_url":"https://github.com/thatch45","followers_url":"https://api.github.com/users/thatch45/followers","following_url":"https://api.github.com/users/thatch45/following{/other_user}","gists_url":"https://api.github.com/users/thatch45/gists{/gist_id}","starred_url":"https://api.github.com/users/thatch45/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thatch45/subscriptions","organizations_url":"https://api.github.com/users/thatch45/orgs","repos_url":"https://api.github.com/users/thatch45/repos","events_url":"https://api.github.com/users/thatch45/events{/privacy}","received_events_url":"https://api.github.com/users/thatch45/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":65,"deletions":52,"changed_files":4}}