GitHub PullRequestEvent at 2014-12-23 17:11:47
Repository: Conversations
Actor: iNPUTmice
Payload: {"action":"closed","number":803,"pull_request":{"url":"https://api.github.com/repos/siacs/Conversations/pulls/803","id":26470856,"html_url":"https://github.com/siacs/Conversations/pull/803","diff_url":"https://github.com/siacs/Conversations/pull/803.diff","patch_url":"https://github.com/siacs/Conversations/pull/803.patch","issue_url":"https://api.github.com/repos/siacs/Conversations/issues/803","number":803,"state":"closed","locked":false,"title":"Refactor roster handling / IqParser code","user":{"login":"SamWhited","id":512573,"avatar_url":"https://avatars.githubusercontent.com/u/512573?v=3","gravatar_id":"","url":"https://api.github.com/users/SamWhited","html_url":"https://github.com/SamWhited","followers_url":"https://api.github.com/users/SamWhited/followers","following_url":"https://api.github.com/users/SamWhited/following{/other_user}","gists_url":"https://api.github.com/users/SamWhited/gists{/gist_id}","starred_url":"https://api.github.com/users/SamWhited/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamWhited/subscriptions","organizations_url":"https://api.github.com/users/SamWhited/orgs","repos_url":"https://api.github.com/users/SamWhited/repos","events_url":"https://api.github.com/users/SamWhited/events{/privacy}","received_events_url":"https://api.github.com/users/SamWhited/received_events","type":"User","site_admin":false},"body":"During a discussion with @iNPUTmice a few days ago we talked about doing a small refactor of the `Iqparser` code. I've added that here, and also added a fix for #20. The logic is slightly different than it was before, but I couldn't see why stanzas should check if the from is null or not (null from = sent from server, which means the to will be null which means the response will go to the server). Correct me if I'm wrong.\r\n\r\nFixes #20","created_at":"2014-12-22T17:57:40Z","updated_at":"2014-12-23T17:11:46Z","closed_at":"2014-12-23T17:11:46Z","merged_at":"2014-12-23T17:11:46Z","merge_commit_sha":"306fa00f86228d6164e9d7093018eb9ed99f0cc2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/siacs/Conversations/pulls/803/commits","review_comments_url":"https://api.github.com/repos/siacs/Conversations/pulls/803/comments","review_comment_url":"https://api.github.com/repos/siacs/Conversations/pulls/comments/{number}","comments_url":"https://api.github.com/repos/siacs/Conversations/issues/803/comments","statuses_url":"https://api.github.com/repos/siacs/Conversations/statuses/e152ed1e0735b9502f724d6a6a1e477022c3a40d","head":{"label":"SamWhited:verifyServerIqs","ref":"verifyServerIqs","sha":"e152ed1e0735b9502f724d6a6a1e477022c3a40d","user":{"login":"SamWhited","id":512573,"avatar_url":"https://avatars.githubusercontent.com/u/512573?v=3","gravatar_id":"","url":"https://api.github.com/users/SamWhited","html_url":"https://github.com/SamWhited","followers_url":"https://api.github.com/users/SamWhited/followers","following_url":"https://api.github.com/users/SamWhited/following{/other_user}","gists_url":"https://api.github.com/users/SamWhited/gists{/gist_id}","starred_url":"https://api.github.com/users/SamWhited/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamWhited/subscriptions","organizations_url":"https://api.github.com/users/SamWhited/orgs","repos_url":"https://api.github.com/users/SamWhited/repos","events_url":"https://api.github.com/users/SamWhited/events{/privacy}","received_events_url":"https://api.github.com/users/SamWhited/received_events","type":"User","site_admin":false},"repo":{"id":24530476,"name":"Conversations","full_name":"SamWhited/Conversations","owner":{"login":"SamWhited","id":512573,"avatar_url":"https://avatars.githubusercontent.com/u/512573?v=3","gravatar_id":"","url":"https://api.github.com/users/SamWhited","html_url":"https://github.com/SamWhited","followers_url":"https://api.github.com/users/SamWhited/followers","following_url":"https://api.github.com/users/SamWhited/following{/other_user}","gists_url":"https://api.github.com/users/SamWhited/gists{/gist_id}","starred_url":"https://api.github.com/users/SamWhited/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamWhited/subscriptions","organizations_url":"https://api.github.com/users/SamWhited/orgs","repos_url":"https://api.github.com/users/SamWhited/repos","events_url":"https://api.github.com/users/SamWhited/events{/privacy}","received_events_url":"https://api.github.com/users/SamWhited/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SamWhited/Conversations","description":"Conversations is an open source XMPP (formally known as Jabber) client for Android 4.0+ smart phones. ","fork":true,"url":"https://api.github.com/repos/SamWhited/Conversations","forks_url":"https://api.github.com/repos/SamWhited/Conversations/forks","keys_url":"https://api.github.com/repos/SamWhited/Conversations/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SamWhited/Conversations/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SamWhited/Conversations/teams","hooks_url":"https://api.github.com/repos/SamWhited/Conversations/hooks","issue_events_url":"https://api.github.com/repos/SamWhited/Conversations/issues/events{/number}","events_url":"https://api.github.com/repos/SamWhited/Conversations/events","assignees_url":"https://api.github.com/repos/SamWhited/Conversations/assignees{/user}","branches_url":"https://api.github.com/repos/SamWhited/Conversations/branches{/branch}","tags_url":"https://api.github.com/repos/SamWhited/Conversations/tags","blobs_url":"https://api.github.com/repos/SamWhited/Conversations/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SamWhited/Conversations/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SamWhited/Conversations/git/refs{/sha}","trees_url":"https://api.github.com/repos/SamWhited/Conversations/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SamWhited/Conversations/statuses/{sha}","languages_url":"https://api.github.com/repos/SamWhited/Conversations/languages","stargazers_url":"https://api.github.com/repos/SamWhited/Conversations/stargazers","contributors_url":"https://api.github.com/repos/SamWhited/Conversations/contributors","subscribers_url":"https://api.github.com/repos/SamWhited/Conversations/subscribers","subscription_url":"https://api.github.com/repos/SamWhited/Conversations/subscription","commits_url":"https://api.github.com/repos/SamWhited/Conversations/commits{/sha}","git_commits_url":"https://api.github.com/repos/SamWhited/Conversations/git/commits{/sha}","comments_url":"https://api.github.com/repos/SamWhited/Conversations/comments{/number}","issue_comment_url":"https://api.github.com/repos/SamWhited/Conversations/issues/comments/{number}","contents_url":"https://api.github.com/repos/SamWhited/Conversations/contents/{+path}","compare_url":"https://api.github.com/repos/SamWhited/Conversations/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SamWhited/Conversations/merges","archive_url":"https://api.github.com/repos/SamWhited/Conversations/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SamWhited/Conversations/downloads","issues_url":"https://api.github.com/repos/SamWhited/Conversations/issues{/number}","pulls_url":"https://api.github.com/repos/SamWhited/Conversations/pulls{/number}","milestones_url":"https://api.github.com/repos/SamWhited/Conversations/milestones{/number}","notifications_url":"https://api.github.com/repos/SamWhited/Conversations/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SamWhited/Conversations/labels{/name}","releases_url":"https://api.github.com/repos/SamWhited/Conversations/releases{/id}","created_at":"2014-09-27T11:48:32Z","updated_at":"2014-12-22T16:29:39Z","pushed_at":"2014-12-23T01:25:29Z","git_url":"git://github.com/SamWhited/Conversations.git","ssh_url":"git@github.com:SamWhited/Conversations.git","clone_url":"https://github.com/SamWhited/Conversations.git","svn_url":"https://github.com/SamWhited/Conversations","homepage":"","size":12110,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"development"}},"base":{"label":"siacs:development","ref":"development","sha":"36f1b816a8ff33363b6754fb855d0f1e1cfb0611","user":{"login":"siacs","id":6818654,"avatar_url":"https://avatars.githubusercontent.com/u/6818654?v=3","gravatar_id":"","url":"https://api.github.com/users/siacs","html_url":"https://github.com/siacs","followers_url":"https://api.github.com/users/siacs/followers","following_url":"https://api.github.com/users/siacs/following{/other_user}","gists_url":"https://api.github.com/users/siacs/gists{/gist_id}","starred_url":"https://api.github.com/users/siacs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siacs/subscriptions","organizations_url":"https://api.github.com/users/siacs/orgs","repos_url":"https://api.github.com/users/siacs/repos","events_url":"https://api.github.com/users/siacs/events{/privacy}","received_events_url":"https://api.github.com/users/siacs/received_events","type":"Organization","site_admin":false},"repo":{"id":16191201,"name":"Conversations","full_name":"siacs/Conversations","owner":{"login":"siacs","id":6818654,"avatar_url":"https://avatars.githubusercontent.com/u/6818654?v=3","gravatar_id":"","url":"https://api.github.com/users/siacs","html_url":"https://github.com/siacs","followers_url":"https://api.github.com/users/siacs/followers","following_url":"https://api.github.com/users/siacs/following{/other_user}","gists_url":"https://api.github.com/users/siacs/gists{/gist_id}","starred_url":"https://api.github.com/users/siacs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siacs/subscriptions","organizations_url":"https://api.github.com/users/siacs/orgs","repos_url":"https://api.github.com/users/siacs/repos","events_url":"https://api.github.com/users/siacs/events{/privacy}","received_events_url":"https://api.github.com/users/siacs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/siacs/Conversations","description":"Conversations is an open source XMPP/Jabber client for Android 4.0+ smart phones. ","fork":false,"url":"https://api.github.com/repos/siacs/Conversations","forks_url":"https://api.github.com/repos/siacs/Conversations/forks","keys_url":"https://api.github.com/repos/siacs/Conversations/keys{/key_id}","collaborators_url":"https://api.github.com/repos/siacs/Conversations/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/siacs/Conversations/teams","hooks_url":"https://api.github.com/repos/siacs/Conversations/hooks","issue_events_url":"https://api.github.com/repos/siacs/Conversations/issues/events{/number}","events_url":"https://api.github.com/repos/siacs/Conversations/events","assignees_url":"https://api.github.com/repos/siacs/Conversations/assignees{/user}","branches_url":"https://api.github.com/repos/siacs/Conversations/branches{/branch}","tags_url":"https://api.github.com/repos/siacs/Conversations/tags","blobs_url":"https://api.github.com/repos/siacs/Conversations/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/siacs/Conversations/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/siacs/Conversations/git/refs{/sha}","trees_url":"https://api.github.com/repos/siacs/Conversations/git/trees{/sha}","statuses_url":"https://api.github.com/repos/siacs/Conversations/statuses/{sha}","languages_url":"https://api.github.com/repos/siacs/Conversations/languages","stargazers_url":"https://api.github.com/repos/siacs/Conversations/stargazers","contributors_url":"https://api.github.com/repos/siacs/Conversations/contributors","subscribers_url":"https://api.github.com/repos/siacs/Conversations/subscribers","subscription_url":"https://api.github.com/repos/siacs/Conversations/subscription","commits_url":"https://api.github.com/repos/siacs/Conversations/commits{/sha}","git_commits_url":"https://api.github.com/repos/siacs/Conversations/git/commits{/sha}","comments_url":"https://api.github.com/repos/siacs/Conversations/comments{/number}","issue_comment_url":"https://api.github.com/repos/siacs/Conversations/issues/comments/{number}","contents_url":"https://api.github.com/repos/siacs/Conversations/contents/{+path}","compare_url":"https://api.github.com/repos/siacs/Conversations/compare/{base}...{head}","merges_url":"https://api.github.com/repos/siacs/Conversations/merges","archive_url":"https://api.github.com/repos/siacs/Conversations/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/siacs/Conversations/downloads","issues_url":"https://api.github.com/repos/siacs/Conversations/issues{/number}","pulls_url":"https://api.github.com/repos/siacs/Conversations/pulls{/number}","milestones_url":"https://api.github.com/repos/siacs/Conversations/milestones{/number}","notifications_url":"https://api.github.com/repos/siacs/Conversations/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/siacs/Conversations/labels{/name}","releases_url":"https://api.github.com/repos/siacs/Conversations/releases{/id}","created_at":"2014-01-24T01:07:34Z","updated_at":"2014-12-23T17:11:46Z","pushed_at":"2014-12-23T17:11:46Z","git_url":"git://github.com/siacs/Conversations.git","ssh_url":"git@github.com:siacs/Conversations.git","clone_url":"https://github.com/siacs/Conversations.git","svn_url":"https://github.com/siacs/Conversations","homepage":"","size":18175,"stargazers_count":725,"watchers_count":725,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":248,"mirror_url":null,"open_issues_count":72,"forks":248,"open_issues":72,"watchers":725,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/siacs/Conversations/pulls/803"},"html":{"href":"https://github.com/siacs/Conversations/pull/803"},"issue":{"href":"https://api.github.com/repos/siacs/Conversations/issues/803"},"comments":{"href":"https://api.github.com/repos/siacs/Conversations/issues/803/comments"},"review_comments":{"href":"https://api.github.com/repos/siacs/Conversations/pulls/803/comments"},"review_comment":{"href":"https://api.github.com/repos/siacs/Conversations/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/siacs/Conversations/pulls/803/commits"},"statuses":{"href":"https://api.github.com/repos/siacs/Conversations/statuses/e152ed1e0735b9502f724d6a6a1e477022c3a40d"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"iNPUTmice","id":192229,"avatar_url":"https://avatars.githubusercontent.com/u/192229?v=3","gravatar_id":"","url":"https://api.github.com/users/iNPUTmice","html_url":"https://github.com/iNPUTmice","followers_url":"https://api.github.com/users/iNPUTmice/followers","following_url":"https://api.github.com/users/iNPUTmice/following{/other_user}","gists_url":"https://api.github.com/users/iNPUTmice/gists{/gist_id}","starred_url":"https://api.github.com/users/iNPUTmice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iNPUTmice/subscriptions","organizations_url":"https://api.github.com/users/iNPUTmice/orgs","repos_url":"https://api.github.com/users/iNPUTmice/repos","events_url":"https://api.github.com/users/iNPUTmice/events{/privacy}","received_events_url":"https://api.github.com/users/iNPUTmice/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":97,"deletions":121,"changed_files":3}}