GitHub PullRequestReviewCommentEvent at 2014-07-03 06:43:23
Repository: cfme_tests
Actor: apagac
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls/comments/14499007","id":14499007,"diff_hunk":"@@ -43,18 +43,54 @@ def parse_cmd_line():\n     return args\n \n \n-def template_name(image_name):\n-    # MIQ\n-    pattern = re.compile(r'[^\\d]*?manageiq[^\\d]*(\\d*).\\w*')\n-    result = pattern.findall(image_name)\n-    if result:\n-        # for now, actual version for MIQ is manually defined.\n-        return \"miq-%s-%s\" % (MIQ_ACTUAL_VERSION, result[0])\n-    else:\n-        # CFME\n-        pattern = re.compile(r'[.-]\\d+(?:-\\d+)?')\n+def template_name(image_name, version=None):\n+    # nightly builds\n+    if \"nightly\" in image_name:\n+        pattern = re.compile(r'[^\\d]*-(\\d*).\\w*')\n         result = pattern.findall(image_name)\n-        return \"cfme-%s%s\" % (MIQ_ACTUAL_VERSION, ''.join(result))\n+        # downstream\n+        if \"cloudforms\" in image_name:\n+            # use version file\n+            if version:\n+                return \"cfme-nightly-%s-%s\" % (version, result[0][4:8])","path":"scripts/template_upload_all.py","position":24,"original_position":24,"commit_id":"f64a0d2c181fbd2b299cd380872f58137b550e77","original_commit_id":"f64a0d2c181fbd2b299cd380872f58137b550e77","user":{"login":"apagac","id":3381283,"avatar_url":"https://avatars.githubusercontent.com/u/3381283?","gravatar_id":"f4a43be9b21c1c56149295056c19bbbb","url":"https://api.github.com/users/apagac","html_url":"https://github.com/apagac","followers_url":"https://api.github.com/users/apagac/followers","following_url":"https://api.github.com/users/apagac/following{/other_user}","gists_url":"https://api.github.com/users/apagac/gists{/gist_id}","starred_url":"https://api.github.com/users/apagac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apagac/subscriptions","organizations_url":"https://api.github.com/users/apagac/orgs","repos_url":"https://api.github.com/users/apagac/repos","events_url":"https://api.github.com/users/apagac/events{/privacy}","received_events_url":"https://api.github.com/users/apagac/received_events","type":"User","site_admin":false},"body":"good point, will do.","created_at":"2014-07-03T06:43:23Z","updated_at":"2014-07-03T06:43:23Z","html_url":"https://github.com/RedHatQE/cfme_tests/pull/911#discussion_r14499007","pull_request_url":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls/911","_links":{"self":{"href":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls/comments/14499007"},"html":{"href":"https://github.com/RedHatQE/cfme_tests/pull/911#discussion_r14499007"},"pull_request":{"href":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls/911"}}},"pull_request":{"url":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls/911","id":17588129,"html_url":"https://github.com/RedHatQE/cfme_tests/pull/911","diff_url":"https://github.com/RedHatQE/cfme_tests/pull/911.diff","patch_url":"https://github.com/RedHatQE/cfme_tests/pull/911.patch","issue_url":"https://api.github.com/repos/RedHatQE/cfme_tests/issues/911","number":911,"state":"open","title":"Template upload: revamp template name, use version file","user":{"login":"apagac","id":3381283,"avatar_url":"https://avatars.githubusercontent.com/u/3381283?","gravatar_id":"f4a43be9b21c1c56149295056c19bbbb","url":"https://api.github.com/users/apagac","html_url":"https://github.com/apagac","followers_url":"https://api.github.com/users/apagac/followers","following_url":"https://api.github.com/users/apagac/following{/other_user}","gists_url":"https://api.github.com/users/apagac/gists{/gist_id}","starred_url":"https://api.github.com/users/apagac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apagac/subscriptions","organizations_url":"https://api.github.com/users/apagac/orgs","repos_url":"https://api.github.com/users/apagac/repos","events_url":"https://api.github.com/users/apagac/events{/privacy}","received_events_url":"https://api.github.com/users/apagac/received_events","type":"User","site_admin":false},"body":"If version file exists, it will be used. Now it'll look like this:\r\n\r\ncfme-5.2.4.2-0624\r\ncfme-nightly-5.3.0.0-15.el6cf.alpha7-0623\r\nmiq-nightly-201406242000","created_at":"2014-06-25T12:53:27Z","updated_at":"2014-07-03T06:43:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7eb8d68a547a37d66760cd616cb087e735c01c2b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls/911/commits","review_comments_url":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls/911/comments","review_comment_url":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls/comments/{number}","comments_url":"https://api.github.com/repos/RedHatQE/cfme_tests/issues/911/comments","statuses_url":"https://api.github.com/repos/RedHatQE/cfme_tests/statuses/f64a0d2c181fbd2b299cd380872f58137b550e77","head":{"label":"apagac:template_upload_name_fix","ref":"template_upload_name_fix","sha":"f64a0d2c181fbd2b299cd380872f58137b550e77","user":{"login":"apagac","id":3381283,"avatar_url":"https://avatars.githubusercontent.com/u/3381283?","gravatar_id":"f4a43be9b21c1c56149295056c19bbbb","url":"https://api.github.com/users/apagac","html_url":"https://github.com/apagac","followers_url":"https://api.github.com/users/apagac/followers","following_url":"https://api.github.com/users/apagac/following{/other_user}","gists_url":"https://api.github.com/users/apagac/gists{/gist_id}","starred_url":"https://api.github.com/users/apagac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apagac/subscriptions","organizations_url":"https://api.github.com/users/apagac/orgs","repos_url":"https://api.github.com/users/apagac/repos","events_url":"https://api.github.com/users/apagac/events{/privacy}","received_events_url":"https://api.github.com/users/apagac/received_events","type":"User","site_admin":false},"repo":{"id":8854367,"name":"cfme_tests","full_name":"apagac/cfme_tests","owner":{"login":"apagac","id":3381283,"avatar_url":"https://avatars.githubusercontent.com/u/3381283?","gravatar_id":"f4a43be9b21c1c56149295056c19bbbb","url":"https://api.github.com/users/apagac","html_url":"https://github.com/apagac","followers_url":"https://api.github.com/users/apagac/followers","following_url":"https://api.github.com/users/apagac/following{/other_user}","gists_url":"https://api.github.com/users/apagac/gists{/gist_id}","starred_url":"https://api.github.com/users/apagac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apagac/subscriptions","organizations_url":"https://api.github.com/users/apagac/orgs","repos_url":"https://api.github.com/users/apagac/repos","events_url":"https://api.github.com/users/apagac/events{/privacy}","received_events_url":"https://api.github.com/users/apagac/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/apagac/cfme_tests","description":"ManageIQ Tests","fork":true,"url":"https://api.github.com/repos/apagac/cfme_tests","forks_url":"https://api.github.com/repos/apagac/cfme_tests/forks","keys_url":"https://api.github.com/repos/apagac/cfme_tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apagac/cfme_tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apagac/cfme_tests/teams","hooks_url":"https://api.github.com/repos/apagac/cfme_tests/hooks","issue_events_url":"https://api.github.com/repos/apagac/cfme_tests/issues/events{/number}","events_url":"https://api.github.com/repos/apagac/cfme_tests/events","assignees_url":"https://api.github.com/repos/apagac/cfme_tests/assignees{/user}","branches_url":"https://api.github.com/repos/apagac/cfme_tests/branches{/branch}","tags_url":"https://api.github.com/repos/apagac/cfme_tests/tags","blobs_url":"https://api.github.com/repos/apagac/cfme_tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apagac/cfme_tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apagac/cfme_tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/apagac/cfme_tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apagac/cfme_tests/statuses/{sha}","languages_url":"https://api.github.com/repos/apagac/cfme_tests/languages","stargazers_url":"https://api.github.com/repos/apagac/cfme_tests/stargazers","contributors_url":"https://api.github.com/repos/apagac/cfme_tests/contributors","subscribers_url":"https://api.github.com/repos/apagac/cfme_tests/subscribers","subscription_url":"https://api.github.com/repos/apagac/cfme_tests/subscription","commits_url":"https://api.github.com/repos/apagac/cfme_tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/apagac/cfme_tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/apagac/cfme_tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/apagac/cfme_tests/issues/comments/{number}","contents_url":"https://api.github.com/repos/apagac/cfme_tests/contents/{+path}","compare_url":"https://api.github.com/repos/apagac/cfme_tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apagac/cfme_tests/merges","archive_url":"https://api.github.com/repos/apagac/cfme_tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apagac/cfme_tests/downloads","issues_url":"https://api.github.com/repos/apagac/cfme_tests/issues{/number}","pulls_url":"https://api.github.com/repos/apagac/cfme_tests/pulls{/number}","milestones_url":"https://api.github.com/repos/apagac/cfme_tests/milestones{/number}","notifications_url":"https://api.github.com/repos/apagac/cfme_tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apagac/cfme_tests/labels{/name}","releases_url":"https://api.github.com/repos/apagac/cfme_tests/releases{/id}","created_at":"2013-03-18T13:09:45Z","updated_at":"2014-06-30T07:01:29Z","pushed_at":"2014-07-02T14:04:12Z","git_url":"git://github.com/apagac/cfme_tests.git","ssh_url":"git@github.com:apagac/cfme_tests.git","clone_url":"https://github.com/apagac/cfme_tests.git","svn_url":"https://github.com/apagac/cfme_tests","homepage":null,"size":5345,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RedHatQE:master","ref":"master","sha":"1fd73606c8b60a472f5234e98f7b129151b83586","user":{"login":"RedHatQE","id":534870,"avatar_url":"https://avatars.githubusercontent.com/u/534870?","gravatar_id":"04c4cbef1bcd53fa66281682b9284123","url":"https://api.github.com/users/RedHatQE","html_url":"https://github.com/RedHatQE","followers_url":"https://api.github.com/users/RedHatQE/followers","following_url":"https://api.github.com/users/RedHatQE/following{/other_user}","gists_url":"https://api.github.com/users/RedHatQE/gists{/gist_id}","starred_url":"https://api.github.com/users/RedHatQE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RedHatQE/subscriptions","organizations_url":"https://api.github.com/users/RedHatQE/orgs","repos_url":"https://api.github.com/users/RedHatQE/repos","events_url":"https://api.github.com/users/RedHatQE/events{/privacy}","received_events_url":"https://api.github.com/users/RedHatQE/received_events","type":"Organization","site_admin":false},"repo":{"id":8061086,"name":"cfme_tests","full_name":"RedHatQE/cfme_tests","owner":{"login":"RedHatQE","id":534870,"avatar_url":"https://avatars.githubusercontent.com/u/534870?","gravatar_id":"04c4cbef1bcd53fa66281682b9284123","url":"https://api.github.com/users/RedHatQE","html_url":"https://github.com/RedHatQE","followers_url":"https://api.github.com/users/RedHatQE/followers","following_url":"https://api.github.com/users/RedHatQE/following{/other_user}","gists_url":"https://api.github.com/users/RedHatQE/gists{/gist_id}","starred_url":"https://api.github.com/users/RedHatQE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RedHatQE/subscriptions","organizations_url":"https://api.github.com/users/RedHatQE/orgs","repos_url":"https://api.github.com/users/RedHatQE/repos","events_url":"https://api.github.com/users/RedHatQE/events{/privacy}","received_events_url":"https://api.github.com/users/RedHatQE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RedHatQE/cfme_tests","description":"CloudForms Management Engine - Functional tests","fork":false,"url":"https://api.github.com/repos/RedHatQE/cfme_tests","forks_url":"https://api.github.com/repos/RedHatQE/cfme_tests/forks","keys_url":"https://api.github.com/repos/RedHatQE/cfme_tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RedHatQE/cfme_tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RedHatQE/cfme_tests/teams","hooks_url":"https://api.github.com/repos/RedHatQE/cfme_tests/hooks","issue_events_url":"https://api.github.com/repos/RedHatQE/cfme_tests/issues/events{/number}","events_url":"https://api.github.com/repos/RedHatQE/cfme_tests/events","assignees_url":"https://api.github.com/repos/RedHatQE/cfme_tests/assignees{/user}","branches_url":"https://api.github.com/repos/RedHatQE/cfme_tests/branches{/branch}","tags_url":"https://api.github.com/repos/RedHatQE/cfme_tests/tags","blobs_url":"https://api.github.com/repos/RedHatQE/cfme_tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RedHatQE/cfme_tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RedHatQE/cfme_tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/RedHatQE/cfme_tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RedHatQE/cfme_tests/statuses/{sha}","languages_url":"https://api.github.com/repos/RedHatQE/cfme_tests/languages","stargazers_url":"https://api.github.com/repos/RedHatQE/cfme_tests/stargazers","contributors_url":"https://api.github.com/repos/RedHatQE/cfme_tests/contributors","subscribers_url":"https://api.github.com/repos/RedHatQE/cfme_tests/subscribers","subscription_url":"https://api.github.com/repos/RedHatQE/cfme_tests/subscription","commits_url":"https://api.github.com/repos/RedHatQE/cfme_tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/RedHatQE/cfme_tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/RedHatQE/cfme_tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/RedHatQE/cfme_tests/issues/comments/{number}","contents_url":"https://api.github.com/repos/RedHatQE/cfme_tests/contents/{+path}","compare_url":"https://api.github.com/repos/RedHatQE/cfme_tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RedHatQE/cfme_tests/merges","archive_url":"https://api.github.com/repos/RedHatQE/cfme_tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RedHatQE/cfme_tests/downloads","issues_url":"https://api.github.com/repos/RedHatQE/cfme_tests/issues{/number}","pulls_url":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls{/number}","milestones_url":"https://api.github.com/repos/RedHatQE/cfme_tests/milestones{/number}","notifications_url":"https://api.github.com/repos/RedHatQE/cfme_tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RedHatQE/cfme_tests/labels{/name}","releases_url":"https://api.github.com/repos/RedHatQE/cfme_tests/releases{/id}","created_at":"2013-02-06T21:59:17Z","updated_at":"2014-06-25T18:37:55Z","pushed_at":"2014-07-02T19:28:53Z","git_url":"git://github.com/RedHatQE/cfme_tests.git","ssh_url":"git@github.com:RedHatQE/cfme_tests.git","clone_url":"https://github.com/RedHatQE/cfme_tests.git","svn_url":"https://github.com/RedHatQE/cfme_tests","homepage":"","size":21071,"stargazers_count":10,"watchers_count":10,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":22,"mirror_url":null,"open_issues_count":51,"forks":22,"open_issues":51,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls/911"},"html":{"href":"https://github.com/RedHatQE/cfme_tests/pull/911"},"issue":{"href":"https://api.github.com/repos/RedHatQE/cfme_tests/issues/911"},"comments":{"href":"https://api.github.com/repos/RedHatQE/cfme_tests/issues/911/comments"},"review_comments":{"href":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls/911/comments"},"review_comment":{"href":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls/911/commits"},"statuses":{"href":"https://api.github.com/repos/RedHatQE/cfme_tests/statuses/f64a0d2c181fbd2b299cd380872f58137b550e77"}}}}