GitHub PullRequestReviewCommentEvent at 2014-12-09 21:48:13
Repository: j2me.js
Actor: marco-c
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/andreasgal/j2me.js/pulls/comments/21565397","id":21565397,"diff_hunk":"@@ -421,3 +421,48 @@ DumbPipe.registerOpener(\"camera\", function(message, sender) {\n     }\n   };\n });\n+\n+function load(file, responseType) {\n+  return new Promise(function(resolve, reject) {\n+    var xhr = new XMLHttpRequest({ mozSystem: true });\n+    xhr.open(\"GET\", file, true);\n+    xhr.responseType = responseType;\n+    xhr.onload = function () {\n+      resolve(xhr.response);\n+    };\n+    xhr.onerror = function() {\n+      reject();\n+    };\n+    xhr.send(null);\n+  });\n+}\n+\n+DumbPipe.registerOpener(\"JARDownloader\", function(message, sender) {\n+  load(urlParams.downloadJAD, \"text\").then(function(data) {\n+    var manifest = {};\n+\n+    data\n+    .replace(/\\r\\n|\\r/g, \"\\n\")\n+    .replace(/\\n /g, \"\")","path":"index.js","position":26,"original_position":26,"commit_id":"cc7902abfb70e7a778bbb85a7c46810bd6dfe689","original_commit_id":"cc7902abfb70e7a778bbb85a7c46810bd6dfe689","user":{"login":"marco-c","id":1616846,"avatar_url":"https://avatars.githubusercontent.com/u/1616846?v=3","gravatar_id":"","url":"https://api.github.com/users/marco-c","html_url":"https://github.com/marco-c","followers_url":"https://api.github.com/users/marco-c/followers","following_url":"https://api.github.com/users/marco-c/following{/other_user}","gists_url":"https://api.github.com/users/marco-c/gists{/gist_id}","starred_url":"https://api.github.com/users/marco-c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marco-c/subscriptions","organizations_url":"https://api.github.com/users/marco-c/orgs","repos_url":"https://api.github.com/users/marco-c/repos","events_url":"https://api.github.com/users/marco-c/events{/privacy}","received_events_url":"https://api.github.com/users/marco-c/received_events","type":"User","site_admin":false},"body":"This was added because a sequence of \"\\n \" in a property value makes the value continue to the following line.\r\n\r\nAn example to make this clearer:\r\n```\r\nManifest-Version: 1.0\r\nMIDlet-2: MIDlet2,,tests.alarm.MIDlet2\r\nMIDlet-1: MIDlet1,,tests.alarm.MIDlet1\r\nMIDlet-Permissions: javax.microedition.io.Connector.socket, javax.micr\r\n oedition.io.Connector.file.read, javax.microedition.io.Connector.file\r\n .write, com.nokia.mid.s40.io.Connector.localmsg, com.nokia.mid.s40.io\r\n .Connector.localstream, javax.wireless.messaging.sms.send, javax.wire\r\n less.messaging.sms.receive, javax.microedition.io.Connector.sms, java\r\n x.microedition.io.Connector.ssl, javax.microedition.media.control.Rec\r\n ordControl, javax.microedition.media.control.VideoControl.getSnapshot\r\n , javax.microedition.io.PushRegistry, javax.microedition.io.Connector\r\n .http, javax.microedition.pim.ContactList.read, javax.microedition.pi\r\n m.ContactList.write, javax.microedition.io.Connector.https\r\nMIDlet-Vendor: Mozilla\r\nNokia-MIDlet-bg-memory-size: 350\r\nNokia-MIDlet-Background-Exit-Confirm-en: DO NOT EXIT!\r\nNokia-MIDlet-Save-Location: Root\r\nNokia-MIDlet-bg-server: 2\r\nMIDlet-Name: AlarmMIDlet\r\nNokia-MIDlet-Dual-SIM-Compliant: true\r\nMIDlet-Version: 2.12.25\r\nMicroEdition-Configuration: CLDC-1.1\r\nMicroEdition-Profile: MIDP-2.1\r\n```","created_at":"2014-12-09T21:48:13Z","updated_at":"2014-12-09T21:48:13Z","html_url":"https://github.com/andreasgal/j2me.js/pull/695#discussion_r21565397","pull_request_url":"https://api.github.com/repos/andreasgal/j2me.js/pulls/695","_links":{"self":{"href":"https://api.github.com/repos/andreasgal/j2me.js/pulls/comments/21565397"},"html":{"href":"https://github.com/andreasgal/j2me.js/pull/695#discussion_r21565397"},"pull_request":{"href":"https://api.github.com/repos/andreasgal/j2me.js/pulls/695"}}},"pull_request":{"url":"https://api.github.com/repos/andreasgal/j2me.js/pulls/695","id":25707506,"html_url":"https://github.com/andreasgal/j2me.js/pull/695","diff_url":"https://github.com/andreasgal/j2me.js/pull/695.diff","patch_url":"https://github.com/andreasgal/j2me.js/pull/695.patch","issue_url":"https://api.github.com/repos/andreasgal/j2me.js/issues/695","number":695,"state":"open","locked":false,"title":"Download JAR on first run given an URL to a JAD manifest","user":{"login":"marco-c","id":1616846,"avatar_url":"https://avatars.githubusercontent.com/u/1616846?v=3","gravatar_id":"","url":"https://api.github.com/users/marco-c","html_url":"https://github.com/marco-c","followers_url":"https://api.github.com/users/marco-c/followers","following_url":"https://api.github.com/users/marco-c/following{/other_user}","gists_url":"https://api.github.com/users/marco-c/gists{/gist_id}","starred_url":"https://api.github.com/users/marco-c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marco-c/subscriptions","organizations_url":"https://api.github.com/users/marco-c/orgs","repos_url":"https://api.github.com/users/marco-c/repos","events_url":"https://api.github.com/users/marco-c/events{/privacy}","received_events_url":"https://api.github.com/users/marco-c/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-12-08T23:38:46Z","updated_at":"2014-12-09T21:48:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fd5e43b3b13825a98907003f67b74ae6480c83e1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/andreasgal/j2me.js/pulls/695/commits","review_comments_url":"https://api.github.com/repos/andreasgal/j2me.js/pulls/695/comments","review_comment_url":"https://api.github.com/repos/andreasgal/j2me.js/pulls/comments/{number}","comments_url":"https://api.github.com/repos/andreasgal/j2me.js/issues/695/comments","statuses_url":"https://api.github.com/repos/andreasgal/j2me.js/statuses/cc7902abfb70e7a778bbb85a7c46810bd6dfe689","head":{"label":"marco-c:download_jad","ref":"download_jad","sha":"cc7902abfb70e7a778bbb85a7c46810bd6dfe689","user":{"login":"marco-c","id":1616846,"avatar_url":"https://avatars.githubusercontent.com/u/1616846?v=3","gravatar_id":"","url":"https://api.github.com/users/marco-c","html_url":"https://github.com/marco-c","followers_url":"https://api.github.com/users/marco-c/followers","following_url":"https://api.github.com/users/marco-c/following{/other_user}","gists_url":"https://api.github.com/users/marco-c/gists{/gist_id}","starred_url":"https://api.github.com/users/marco-c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marco-c/subscriptions","organizations_url":"https://api.github.com/users/marco-c/orgs","repos_url":"https://api.github.com/users/marco-c/repos","events_url":"https://api.github.com/users/marco-c/events{/privacy}","received_events_url":"https://api.github.com/users/marco-c/received_events","type":"User","site_admin":false},"repo":{"id":22527203,"name":"j2me.js","full_name":"marco-c/j2me.js","owner":{"login":"marco-c","id":1616846,"avatar_url":"https://avatars.githubusercontent.com/u/1616846?v=3","gravatar_id":"","url":"https://api.github.com/users/marco-c","html_url":"https://github.com/marco-c","followers_url":"https://api.github.com/users/marco-c/followers","following_url":"https://api.github.com/users/marco-c/following{/other_user}","gists_url":"https://api.github.com/users/marco-c/gists{/gist_id}","starred_url":"https://api.github.com/users/marco-c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marco-c/subscriptions","organizations_url":"https://api.github.com/users/marco-c/orgs","repos_url":"https://api.github.com/users/marco-c/repos","events_url":"https://api.github.com/users/marco-c/events{/privacy}","received_events_url":"https://api.github.com/users/marco-c/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marco-c/j2me.js","description":"J2ME VM in JavaScript","fork":true,"url":"https://api.github.com/repos/marco-c/j2me.js","forks_url":"https://api.github.com/repos/marco-c/j2me.js/forks","keys_url":"https://api.github.com/repos/marco-c/j2me.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marco-c/j2me.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marco-c/j2me.js/teams","hooks_url":"https://api.github.com/repos/marco-c/j2me.js/hooks","issue_events_url":"https://api.github.com/repos/marco-c/j2me.js/issues/events{/number}","events_url":"https://api.github.com/repos/marco-c/j2me.js/events","assignees_url":"https://api.github.com/repos/marco-c/j2me.js/assignees{/user}","branches_url":"https://api.github.com/repos/marco-c/j2me.js/branches{/branch}","tags_url":"https://api.github.com/repos/marco-c/j2me.js/tags","blobs_url":"https://api.github.com/repos/marco-c/j2me.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marco-c/j2me.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marco-c/j2me.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/marco-c/j2me.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marco-c/j2me.js/statuses/{sha}","languages_url":"https://api.github.com/repos/marco-c/j2me.js/languages","stargazers_url":"https://api.github.com/repos/marco-c/j2me.js/stargazers","contributors_url":"https://api.github.com/repos/marco-c/j2me.js/contributors","subscribers_url":"https://api.github.com/repos/marco-c/j2me.js/subscribers","subscription_url":"https://api.github.com/repos/marco-c/j2me.js/subscription","commits_url":"https://api.github.com/repos/marco-c/j2me.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/marco-c/j2me.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/marco-c/j2me.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/marco-c/j2me.js/issues/comments/{number}","contents_url":"https://api.github.com/repos/marco-c/j2me.js/contents/{+path}","compare_url":"https://api.github.com/repos/marco-c/j2me.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marco-c/j2me.js/merges","archive_url":"https://api.github.com/repos/marco-c/j2me.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marco-c/j2me.js/downloads","issues_url":"https://api.github.com/repos/marco-c/j2me.js/issues{/number}","pulls_url":"https://api.github.com/repos/marco-c/j2me.js/pulls{/number}","milestones_url":"https://api.github.com/repos/marco-c/j2me.js/milestones{/number}","notifications_url":"https://api.github.com/repos/marco-c/j2me.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marco-c/j2me.js/labels{/name}","releases_url":"https://api.github.com/repos/marco-c/j2me.js/releases{/id}","created_at":"2014-08-01T20:30:33Z","updated_at":"2014-12-08T21:16:08Z","pushed_at":"2014-12-09T14:14:11Z","git_url":"git://github.com/marco-c/j2me.js.git","ssh_url":"git@github.com:marco-c/j2me.js.git","clone_url":"https://github.com/marco-c/j2me.js.git","svn_url":"https://github.com/marco-c/j2me.js","homepage":null,"size":8478,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"andreasgal:master","ref":"master","sha":"ffa6844fa5f114615be06dab8ac99d4a6322a249","user":{"login":"andreasgal","id":313748,"avatar_url":"https://avatars.githubusercontent.com/u/313748?v=3","gravatar_id":"","url":"https://api.github.com/users/andreasgal","html_url":"https://github.com/andreasgal","followers_url":"https://api.github.com/users/andreasgal/followers","following_url":"https://api.github.com/users/andreasgal/following{/other_user}","gists_url":"https://api.github.com/users/andreasgal/gists{/gist_id}","starred_url":"https://api.github.com/users/andreasgal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreasgal/subscriptions","organizations_url":"https://api.github.com/users/andreasgal/orgs","repos_url":"https://api.github.com/users/andreasgal/repos","events_url":"https://api.github.com/users/andreasgal/events{/privacy}","received_events_url":"https://api.github.com/users/andreasgal/received_events","type":"User","site_admin":false},"repo":{"id":21724513,"name":"j2me.js","full_name":"andreasgal/j2me.js","owner":{"login":"andreasgal","id":313748,"avatar_url":"https://avatars.githubusercontent.com/u/313748?v=3","gravatar_id":"","url":"https://api.github.com/users/andreasgal","html_url":"https://github.com/andreasgal","followers_url":"https://api.github.com/users/andreasgal/followers","following_url":"https://api.github.com/users/andreasgal/following{/other_user}","gists_url":"https://api.github.com/users/andreasgal/gists{/gist_id}","starred_url":"https://api.github.com/users/andreasgal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreasgal/subscriptions","organizations_url":"https://api.github.com/users/andreasgal/orgs","repos_url":"https://api.github.com/users/andreasgal/repos","events_url":"https://api.github.com/users/andreasgal/events{/privacy}","received_events_url":"https://api.github.com/users/andreasgal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andreasgal/j2me.js","description":"J2ME VM in JavaScript","fork":false,"url":"https://api.github.com/repos/andreasgal/j2me.js","forks_url":"https://api.github.com/repos/andreasgal/j2me.js/forks","keys_url":"https://api.github.com/repos/andreasgal/j2me.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andreasgal/j2me.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andreasgal/j2me.js/teams","hooks_url":"https://api.github.com/repos/andreasgal/j2me.js/hooks","issue_events_url":"https://api.github.com/repos/andreasgal/j2me.js/issues/events{/number}","events_url":"https://api.github.com/repos/andreasgal/j2me.js/events","assignees_url":"https://api.github.com/repos/andreasgal/j2me.js/assignees{/user}","branches_url":"https://api.github.com/repos/andreasgal/j2me.js/branches{/branch}","tags_url":"https://api.github.com/repos/andreasgal/j2me.js/tags","blobs_url":"https://api.github.com/repos/andreasgal/j2me.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andreasgal/j2me.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andreasgal/j2me.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/andreasgal/j2me.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andreasgal/j2me.js/statuses/{sha}","languages_url":"https://api.github.com/repos/andreasgal/j2me.js/languages","stargazers_url":"https://api.github.com/repos/andreasgal/j2me.js/stargazers","contributors_url":"https://api.github.com/repos/andreasgal/j2me.js/contributors","subscribers_url":"https://api.github.com/repos/andreasgal/j2me.js/subscribers","subscription_url":"https://api.github.com/repos/andreasgal/j2me.js/subscription","commits_url":"https://api.github.com/repos/andreasgal/j2me.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/andreasgal/j2me.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/andreasgal/j2me.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/andreasgal/j2me.js/issues/comments/{number}","contents_url":"https://api.github.com/repos/andreasgal/j2me.js/contents/{+path}","compare_url":"https://api.github.com/repos/andreasgal/j2me.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andreasgal/j2me.js/merges","archive_url":"https://api.github.com/repos/andreasgal/j2me.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andreasgal/j2me.js/downloads","issues_url":"https://api.github.com/repos/andreasgal/j2me.js/issues{/number}","pulls_url":"https://api.github.com/repos/andreasgal/j2me.js/pulls{/number}","milestones_url":"https://api.github.com/repos/andreasgal/j2me.js/milestones{/number}","notifications_url":"https://api.github.com/repos/andreasgal/j2me.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andreasgal/j2me.js/labels{/name}","releases_url":"https://api.github.com/repos/andreasgal/j2me.js/releases{/id}","created_at":"2014-07-11T06:23:27Z","updated_at":"2014-12-09T21:22:05Z","pushed_at":"2014-12-09T21:22:05Z","git_url":"git://github.com/andreasgal/j2me.js.git","ssh_url":"git@github.com:andreasgal/j2me.js.git","clone_url":"https://github.com/andreasgal/j2me.js.git","svn_url":"https://github.com/andreasgal/j2me.js","homepage":null,"size":11427,"stargazers_count":39,"watchers_count":39,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":100,"forks":11,"open_issues":100,"watchers":39,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/andreasgal/j2me.js/pulls/695"},"html":{"href":"https://github.com/andreasgal/j2me.js/pull/695"},"issue":{"href":"https://api.github.com/repos/andreasgal/j2me.js/issues/695"},"comments":{"href":"https://api.github.com/repos/andreasgal/j2me.js/issues/695/comments"},"review_comments":{"href":"https://api.github.com/repos/andreasgal/j2me.js/pulls/695/comments"},"review_comment":{"href":"https://api.github.com/repos/andreasgal/j2me.js/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/andreasgal/j2me.js/pulls/695/commits"},"statuses":{"href":"https://api.github.com/repos/andreasgal/j2me.js/statuses/cc7902abfb70e7a778bbb85a7c46810bd6dfe689"}}}}