GitHub PullRequestReviewCommentEvent at 2014-04-14 07:57:50
Repository: Collage
Actor: tribal-tec
Payload: {"comment":{"url":"https://api.github.com/repos/Eyescale/Collage/pulls/comments/11573813","id":11573813,"diff_hunk":"@@ -115,26 +115,42 @@ int main( int argc, char **argv )\n     TEST( client->listen( ));\n     TEST( client->connect( serverProxy ));\n \n-    lunchbox::Request< void > request = client->registerRequest< void >();\n-    serverProxy->send( CMD_ASYNC );\n-    serverProxy->send( CMD_SYNC ) << request.getID();\n-    request.wait();\n-\n     lunchbox::Clock clock;\n     for( size_t i = 0; i < NCOMMANDS; ++i )\n+        serverProxy->send( CMD_ASYNC );\n+    uint32_t request = client->registerRequest();","path":"tests/command.cpp","position":85,"original_position":85,"commit_id":"0c5f8b67af8359874770256779d7287b4fc3742d","original_commit_id":"0c5f8b67af8359874770256779d7287b4fc3742d","user":{"login":"tribal-tec","id":701401,"avatar_url":"https://avatars.githubusercontent.com/u/701401?","gravatar_id":"9fb745a2e6a7d6d9850cb08af16ae8f2","url":"https://api.github.com/users/tribal-tec","html_url":"https://github.com/tribal-tec","followers_url":"https://api.github.com/users/tribal-tec/followers","following_url":"https://api.github.com/users/tribal-tec/following{/other_user}","gists_url":"https://api.github.com/users/tribal-tec/gists{/gist_id}","starred_url":"https://api.github.com/users/tribal-tec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tribal-tec/subscriptions","organizations_url":"https://api.github.com/users/tribal-tec/orgs","repos_url":"https://api.github.com/users/tribal-tec/repos","events_url":"https://api.github.com/users/tribal-tec/events{/privacy}","received_events_url":"https://api.github.com/users/tribal-tec/received_events","type":"User","site_admin":false},"body":"If deprecation warnings are enabled, this won't compile then. Is there a way to #ifdef it?","created_at":"2014-04-14T07:57:50Z","updated_at":"2014-04-14T07:57:50Z","html_url":"https://github.com/Eyescale/Collage/pull/100#discussion_r11573813","pull_request_url":"https://api.github.com/repos/Eyescale/Collage/pulls/100","_links":{"self":{"href":"https://api.github.com/repos/Eyescale/Collage/pulls/comments/11573813"},"html":{"href":"https://github.com/Eyescale/Collage/pull/100#discussion_r11573813"},"pull_request":{"href":"https://api.github.com/repos/Eyescale/Collage/pulls/100"}}}}