GitHub PullRequestReviewCommentEvent at 2014-12-13 00:43:55
Repository: simbody
Actor: chrisdembia
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/simbody/simbody/pulls/comments/21783298","id":21783298,"diff_hunk":"@@ -290,6 +294,7 @@ Simbody is installed into the `usr/` directory.\n * `usr/lib/` shared libraries (.so's), used at runtime.\n     * `cmake/simbody/` CMake files that are useful for projects that use Simbody.\n     * `pkgconfig/` pkg-config files useful for projects that use Simbody.\n+    * `simbody/examples/` the examples, compiled into executables; run them! (Not for Debug builds.)","path":"README.md","position":112,"original_position":112,"commit_id":"e545aea9c5d6c2c9795da9c8bbd7663f99b04ab8","original_commit_id":"e545aea9c5d6c2c9795da9c8bbd7663f99b04ab8","user":{"login":"chrisdembia","id":846001,"avatar_url":"https://avatars.githubusercontent.com/u/846001?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisdembia","html_url":"https://github.com/chrisdembia","followers_url":"https://api.github.com/users/chrisdembia/followers","following_url":"https://api.github.com/users/chrisdembia/following{/other_user}","gists_url":"https://api.github.com/users/chrisdembia/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisdembia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisdembia/subscriptions","organizations_url":"https://api.github.com/users/chrisdembia/orgs","repos_url":"https://api.github.com/users/chrisdembia/repos","events_url":"https://api.github.com/users/chrisdembia/events{/privacy}","received_events_url":"https://api.github.com/users/chrisdembia/received_events","type":"User","site_admin":false},"body":"Same comment as before.","created_at":"2014-12-13T00:43:55Z","updated_at":"2014-12-13T00:43:55Z","html_url":"https://github.com/simbody/simbody/pull/291#discussion_r21783298","pull_request_url":"https://api.github.com/repos/simbody/simbody/pulls/291","_links":{"self":{"href":"https://api.github.com/repos/simbody/simbody/pulls/comments/21783298"},"html":{"href":"https://github.com/simbody/simbody/pull/291#discussion_r21783298"},"pull_request":{"href":"https://api.github.com/repos/simbody/simbody/pulls/291"}}},"pull_request":{"url":"https://api.github.com/repos/simbody/simbody/pulls/291","id":26008107,"html_url":"https://github.com/simbody/simbody/pull/291","diff_url":"https://github.com/simbody/simbody/pull/291.diff","patch_url":"https://github.com/simbody/simbody/pull/291.patch","issue_url":"https://api.github.com/repos/simbody/simbody/issues/291","number":291,"state":"open","locked":false,"title":"Update readme and examples","user":{"login":"sherm1","id":4088016,"avatar_url":"https://avatars.githubusercontent.com/u/4088016?v=3","gravatar_id":"","url":"https://api.github.com/users/sherm1","html_url":"https://github.com/sherm1","followers_url":"https://api.github.com/users/sherm1/followers","following_url":"https://api.github.com/users/sherm1/following{/other_user}","gists_url":"https://api.github.com/users/sherm1/gists{/gist_id}","starred_url":"https://api.github.com/users/sherm1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sherm1/subscriptions","organizations_url":"https://api.github.com/users/sherm1/orgs","repos_url":"https://api.github.com/users/sherm1/repos","events_url":"https://api.github.com/users/sherm1/events{/privacy}","received_events_url":"https://api.github.com/users/sherm1/received_events","type":"User","site_admin":false},"body":"Addresses issue #290 by updating `README.md` and also by moving the Windows examples installation to where the `README.md` said they were (at the top level rather than under doc).\r\n\r\nThis also fixes #259 by preventing example binaries from being installed from a Debug build.\r\n\r\nAnd I updated the version number examples in `README.md` to 3.5.\r\n\r\n@mjhmilla and @chrisdembia, please review. Chris, I didn't try the installation on Linux to make sure I didn't mess up anything with the example installation (they should still go to the same place, but not for Debug builds). Also, it would be worth a quick check of the instructions for different platforms to see if they still match reality.","created_at":"2014-12-12T22:34:53Z","updated_at":"2014-12-13T00:43:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3736617e0880ba021bf2571728ab180c7b6ceffa","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/simbody/simbody/pulls/291/commits","review_comments_url":"https://api.github.com/repos/simbody/simbody/pulls/291/comments","review_comment_url":"https://api.github.com/repos/simbody/simbody/pulls/comments/{number}","comments_url":"https://api.github.com/repos/simbody/simbody/issues/291/comments","statuses_url":"https://api.github.com/repos/simbody/simbody/statuses/e545aea9c5d6c2c9795da9c8bbd7663f99b04ab8","head":{"label":"simbody:update-readme-and-examples","ref":"update-readme-and-examples","sha":"e545aea9c5d6c2c9795da9c8bbd7663f99b04ab8","user":{"login":"simbody","id":5199961,"avatar_url":"https://avatars.githubusercontent.com/u/5199961?v=3","gravatar_id":"","url":"https://api.github.com/users/simbody","html_url":"https://github.com/simbody","followers_url":"https://api.github.com/users/simbody/followers","following_url":"https://api.github.com/users/simbody/following{/other_user}","gists_url":"https://api.github.com/users/simbody/gists{/gist_id}","starred_url":"https://api.github.com/users/simbody/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simbody/subscriptions","organizations_url":"https://api.github.com/users/simbody/orgs","repos_url":"https://api.github.com/users/simbody/repos","events_url":"https://api.github.com/users/simbody/events{/privacy}","received_events_url":"https://api.github.com/users/simbody/received_events","type":"Organization","site_admin":false},"repo":{"id":12146969,"name":"simbody","full_name":"simbody/simbody","owner":{"login":"simbody","id":5199961,"avatar_url":"https://avatars.githubusercontent.com/u/5199961?v=3","gravatar_id":"","url":"https://api.github.com/users/simbody","html_url":"https://github.com/simbody","followers_url":"https://api.github.com/users/simbody/followers","following_url":"https://api.github.com/users/simbody/following{/other_user}","gists_url":"https://api.github.com/users/simbody/gists{/gist_id}","starred_url":"https://api.github.com/users/simbody/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simbody/subscriptions","organizations_url":"https://api.github.com/users/simbody/orgs","repos_url":"https://api.github.com/users/simbody/repos","events_url":"https://api.github.com/users/simbody/events{/privacy}","received_events_url":"https://api.github.com/users/simbody/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/simbody/simbody","description":"High-performance C++ multibody dynamics/physics library for simulating articulated biomechanical and mechanical systems like vehicles, robots, and the human skeleton.","fork":false,"url":"https://api.github.com/repos/simbody/simbody","forks_url":"https://api.github.com/repos/simbody/simbody/forks","keys_url":"https://api.github.com/repos/simbody/simbody/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simbody/simbody/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simbody/simbody/teams","hooks_url":"https://api.github.com/repos/simbody/simbody/hooks","issue_events_url":"https://api.github.com/repos/simbody/simbody/issues/events{/number}","events_url":"https://api.github.com/repos/simbody/simbody/events","assignees_url":"https://api.github.com/repos/simbody/simbody/assignees{/user}","branches_url":"https://api.github.com/repos/simbody/simbody/branches{/branch}","tags_url":"https://api.github.com/repos/simbody/simbody/tags","blobs_url":"https://api.github.com/repos/simbody/simbody/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simbody/simbody/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simbody/simbody/git/refs{/sha}","trees_url":"https://api.github.com/repos/simbody/simbody/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simbody/simbody/statuses/{sha}","languages_url":"https://api.github.com/repos/simbody/simbody/languages","stargazers_url":"https://api.github.com/repos/simbody/simbody/stargazers","contributors_url":"https://api.github.com/repos/simbody/simbody/contributors","subscribers_url":"https://api.github.com/repos/simbody/simbody/subscribers","subscription_url":"https://api.github.com/repos/simbody/simbody/subscription","commits_url":"https://api.github.com/repos/simbody/simbody/commits{/sha}","git_commits_url":"https://api.github.com/repos/simbody/simbody/git/commits{/sha}","comments_url":"https://api.github.com/repos/simbody/simbody/comments{/number}","issue_comment_url":"https://api.github.com/repos/simbody/simbody/issues/comments/{number}","contents_url":"https://api.github.com/repos/simbody/simbody/contents/{+path}","compare_url":"https://api.github.com/repos/simbody/simbody/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simbody/simbody/merges","archive_url":"https://api.github.com/repos/simbody/simbody/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simbody/simbody/downloads","issues_url":"https://api.github.com/repos/simbody/simbody/issues{/number}","pulls_url":"https://api.github.com/repos/simbody/simbody/pulls{/number}","milestones_url":"https://api.github.com/repos/simbody/simbody/milestones{/number}","notifications_url":"https://api.github.com/repos/simbody/simbody/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simbody/simbody/labels{/name}","releases_url":"https://api.github.com/repos/simbody/simbody/releases{/id}","created_at":"2013-08-16T00:21:53Z","updated_at":"2014-12-11T00:35:29Z","pushed_at":"2014-12-13T00:42:56Z","git_url":"git://github.com/simbody/simbody.git","ssh_url":"git@github.com:simbody/simbody.git","clone_url":"https://github.com/simbody/simbody.git","svn_url":"https://github.com/simbody/simbody","homepage":"https://simtk.org/home/simbody","size":186828,"stargazers_count":207,"watchers_count":207,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":86,"mirror_url":null,"open_issues_count":56,"forks":86,"open_issues":56,"watchers":207,"default_branch":"master"}},"base":{"label":"simbody:master","ref":"master","sha":"e9d2d04ebad3b5ce2f87a5e4a0b65320eb96eec1","user":{"login":"simbody","id":5199961,"avatar_url":"https://avatars.githubusercontent.com/u/5199961?v=3","gravatar_id":"","url":"https://api.github.com/users/simbody","html_url":"https://github.com/simbody","followers_url":"https://api.github.com/users/simbody/followers","following_url":"https://api.github.com/users/simbody/following{/other_user}","gists_url":"https://api.github.com/users/simbody/gists{/gist_id}","starred_url":"https://api.github.com/users/simbody/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simbody/subscriptions","organizations_url":"https://api.github.com/users/simbody/orgs","repos_url":"https://api.github.com/users/simbody/repos","events_url":"https://api.github.com/users/simbody/events{/privacy}","received_events_url":"https://api.github.com/users/simbody/received_events","type":"Organization","site_admin":false},"repo":{"id":12146969,"name":"simbody","full_name":"simbody/simbody","owner":{"login":"simbody","id":5199961,"avatar_url":"https://avatars.githubusercontent.com/u/5199961?v=3","gravatar_id":"","url":"https://api.github.com/users/simbody","html_url":"https://github.com/simbody","followers_url":"https://api.github.com/users/simbody/followers","following_url":"https://api.github.com/users/simbody/following{/other_user}","gists_url":"https://api.github.com/users/simbody/gists{/gist_id}","starred_url":"https://api.github.com/users/simbody/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simbody/subscriptions","organizations_url":"https://api.github.com/users/simbody/orgs","repos_url":"https://api.github.com/users/simbody/repos","events_url":"https://api.github.com/users/simbody/events{/privacy}","received_events_url":"https://api.github.com/users/simbody/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/simbody/simbody","description":"High-performance C++ multibody dynamics/physics library for simulating articulated biomechanical and mechanical systems like vehicles, robots, and the human skeleton.","fork":false,"url":"https://api.github.com/repos/simbody/simbody","forks_url":"https://api.github.com/repos/simbody/simbody/forks","keys_url":"https://api.github.com/repos/simbody/simbody/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simbody/simbody/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simbody/simbody/teams","hooks_url":"https://api.github.com/repos/simbody/simbody/hooks","issue_events_url":"https://api.github.com/repos/simbody/simbody/issues/events{/number}","events_url":"https://api.github.com/repos/simbody/simbody/events","assignees_url":"https://api.github.com/repos/simbody/simbody/assignees{/user}","branches_url":"https://api.github.com/repos/simbody/simbody/branches{/branch}","tags_url":"https://api.github.com/repos/simbody/simbody/tags","blobs_url":"https://api.github.com/repos/simbody/simbody/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simbody/simbody/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simbody/simbody/git/refs{/sha}","trees_url":"https://api.github.com/repos/simbody/simbody/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simbody/simbody/statuses/{sha}","languages_url":"https://api.github.com/repos/simbody/simbody/languages","stargazers_url":"https://api.github.com/repos/simbody/simbody/stargazers","contributors_url":"https://api.github.com/repos/simbody/simbody/contributors","subscribers_url":"https://api.github.com/repos/simbody/simbody/subscribers","subscription_url":"https://api.github.com/repos/simbody/simbody/subscription","commits_url":"https://api.github.com/repos/simbody/simbody/commits{/sha}","git_commits_url":"https://api.github.com/repos/simbody/simbody/git/commits{/sha}","comments_url":"https://api.github.com/repos/simbody/simbody/comments{/number}","issue_comment_url":"https://api.github.com/repos/simbody/simbody/issues/comments/{number}","contents_url":"https://api.github.com/repos/simbody/simbody/contents/{+path}","compare_url":"https://api.github.com/repos/simbody/simbody/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simbody/simbody/merges","archive_url":"https://api.github.com/repos/simbody/simbody/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simbody/simbody/downloads","issues_url":"https://api.github.com/repos/simbody/simbody/issues{/number}","pulls_url":"https://api.github.com/repos/simbody/simbody/pulls{/number}","milestones_url":"https://api.github.com/repos/simbody/simbody/milestones{/number}","notifications_url":"https://api.github.com/repos/simbody/simbody/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simbody/simbody/labels{/name}","releases_url":"https://api.github.com/repos/simbody/simbody/releases{/id}","created_at":"2013-08-16T00:21:53Z","updated_at":"2014-12-11T00:35:29Z","pushed_at":"2014-12-13T00:42:56Z","git_url":"git://github.com/simbody/simbody.git","ssh_url":"git@github.com:simbody/simbody.git","clone_url":"https://github.com/simbody/simbody.git","svn_url":"https://github.com/simbody/simbody","homepage":"https://simtk.org/home/simbody","size":186828,"stargazers_count":207,"watchers_count":207,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":86,"mirror_url":null,"open_issues_count":56,"forks":86,"open_issues":56,"watchers":207,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/simbody/simbody/pulls/291"},"html":{"href":"https://github.com/simbody/simbody/pull/291"},"issue":{"href":"https://api.github.com/repos/simbody/simbody/issues/291"},"comments":{"href":"https://api.github.com/repos/simbody/simbody/issues/291/comments"},"review_comments":{"href":"https://api.github.com/repos/simbody/simbody/pulls/291/comments"},"review_comment":{"href":"https://api.github.com/repos/simbody/simbody/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/simbody/simbody/pulls/291/commits"},"statuses":{"href":"https://api.github.com/repos/simbody/simbody/statuses/e545aea9c5d6c2c9795da9c8bbd7663f99b04ab8"}}}}