GitHub PullRequestEvent at 2014-10-08 11:31:07
Repository: FakeItEasy
Actor: blairconrad
Payload: {"action":"closed","number":352,"pull_request":{"url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/pulls/352","id":20430241,"html_url":"https://github.com/FakeItEasy/FakeItEasy/pull/352","diff_url":"https://github.com/FakeItEasy/FakeItEasy/pull/352.diff","patch_url":"https://github.com/FakeItEasy/FakeItEasy/pull/352.patch","issue_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/issues/352","number":352,"state":"closed","locked":false,"title":"For discussion - removing Now from event raising syntax","user":{"login":"blairconrad","id":3275797,"avatar_url":"https://avatars.githubusercontent.com/u/3275797?v=2","gravatar_id":"","url":"https://api.github.com/users/blairconrad","html_url":"https://github.com/blairconrad","followers_url":"https://api.github.com/users/blairconrad/followers","following_url":"https://api.github.com/users/blairconrad/following{/other_user}","gists_url":"https://api.github.com/users/blairconrad/gists{/gist_id}","starred_url":"https://api.github.com/users/blairconrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blairconrad/subscriptions","organizations_url":"https://api.github.com/users/blairconrad/orgs","repos_url":"https://api.github.com/users/blairconrad/repos","events_url":"https://api.github.com/users/blairconrad/events{/privacy}","received_events_url":"https://api.github.com/users/blairconrad/received_events","type":"User","site_admin":false},"body":"## Do not merge this\r\n\r\nFor #30.\r\n\r\n@philippdolder, I had intended to \r\n\r\n1. try to understand how event-raising works now\r\n2. see how to close the gap in your approach\r\n\r\nI never got to point 2.\r\n\r\nInstead, I just\r\n\r\n1. added an implicit converter from `Raise<TEventArgs>` to  `EventHandler` and to `EventHandler<TEventArgs>`, and \r\n2. made `FakeManager.EventRule.EventCall.IsEventRaiser` pay attention to the new `NowNonGeneric` method that I needed for the `EventHandler` conversion\r\n\r\nIt's not particularly elegant, but it does allow us to preserver the arguments passed to the raiser, since we're never actually calling `Now` (or `NowGeneric`), so we have access to the original `Raise<TEvents>` object when we need to fire the event.\r\n\r\nAnyhow, I thought you might enjoy looking at it.","created_at":"2014-08-28T10:36:35Z","updated_at":"2014-10-08T11:31:05Z","closed_at":"2014-10-08T11:31:05Z","merged_at":null,"merge_commit_sha":"05cb6166d8bedf8c22c6528fa34e6d7bba7be87e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/pulls/352/commits","review_comments_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/pulls/352/comments","review_comment_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/pulls/comments/{number}","comments_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/issues/352/comments","statuses_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/statuses/f47608f1f9c0957fd3e15a4aeded1bbd1ada5ca6","head":{"label":"blairconrad:30-a-naive-approach-to-eliminating-now","ref":"30-a-naive-approach-to-eliminating-now","sha":"f47608f1f9c0957fd3e15a4aeded1bbd1ada5ca6","user":{"login":"blairconrad","id":3275797,"avatar_url":"https://avatars.githubusercontent.com/u/3275797?v=2","gravatar_id":"","url":"https://api.github.com/users/blairconrad","html_url":"https://github.com/blairconrad","followers_url":"https://api.github.com/users/blairconrad/followers","following_url":"https://api.github.com/users/blairconrad/following{/other_user}","gists_url":"https://api.github.com/users/blairconrad/gists{/gist_id}","starred_url":"https://api.github.com/users/blairconrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blairconrad/subscriptions","organizations_url":"https://api.github.com/users/blairconrad/orgs","repos_url":"https://api.github.com/users/blairconrad/repos","events_url":"https://api.github.com/users/blairconrad/events{/privacy}","received_events_url":"https://api.github.com/users/blairconrad/received_events","type":"User","site_admin":false},"repo":{"id":7626243,"name":"FakeItEasy","full_name":"blairconrad/FakeItEasy","owner":{"login":"blairconrad","id":3275797,"avatar_url":"https://avatars.githubusercontent.com/u/3275797?v=2","gravatar_id":"","url":"https://api.github.com/users/blairconrad","html_url":"https://github.com/blairconrad","followers_url":"https://api.github.com/users/blairconrad/followers","following_url":"https://api.github.com/users/blairconrad/following{/other_user}","gists_url":"https://api.github.com/users/blairconrad/gists{/gist_id}","starred_url":"https://api.github.com/users/blairconrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blairconrad/subscriptions","organizations_url":"https://api.github.com/users/blairconrad/orgs","repos_url":"https://api.github.com/users/blairconrad/repos","events_url":"https://api.github.com/users/blairconrad/events{/privacy}","received_events_url":"https://api.github.com/users/blairconrad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/blairconrad/FakeItEasy","description":"The easy mocking library for .Net","fork":true,"url":"https://api.github.com/repos/blairconrad/FakeItEasy","forks_url":"https://api.github.com/repos/blairconrad/FakeItEasy/forks","keys_url":"https://api.github.com/repos/blairconrad/FakeItEasy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blairconrad/FakeItEasy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blairconrad/FakeItEasy/teams","hooks_url":"https://api.github.com/repos/blairconrad/FakeItEasy/hooks","issue_events_url":"https://api.github.com/repos/blairconrad/FakeItEasy/issues/events{/number}","events_url":"https://api.github.com/repos/blairconrad/FakeItEasy/events","assignees_url":"https://api.github.com/repos/blairconrad/FakeItEasy/assignees{/user}","branches_url":"https://api.github.com/repos/blairconrad/FakeItEasy/branches{/branch}","tags_url":"https://api.github.com/repos/blairconrad/FakeItEasy/tags","blobs_url":"https://api.github.com/repos/blairconrad/FakeItEasy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blairconrad/FakeItEasy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blairconrad/FakeItEasy/git/refs{/sha}","trees_url":"https://api.github.com/repos/blairconrad/FakeItEasy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blairconrad/FakeItEasy/statuses/{sha}","languages_url":"https://api.github.com/repos/blairconrad/FakeItEasy/languages","stargazers_url":"https://api.github.com/repos/blairconrad/FakeItEasy/stargazers","contributors_url":"https://api.github.com/repos/blairconrad/FakeItEasy/contributors","subscribers_url":"https://api.github.com/repos/blairconrad/FakeItEasy/subscribers","subscription_url":"https://api.github.com/repos/blairconrad/FakeItEasy/subscription","commits_url":"https://api.github.com/repos/blairconrad/FakeItEasy/commits{/sha}","git_commits_url":"https://api.github.com/repos/blairconrad/FakeItEasy/git/commits{/sha}","comments_url":"https://api.github.com/repos/blairconrad/FakeItEasy/comments{/number}","issue_comment_url":"https://api.github.com/repos/blairconrad/FakeItEasy/issues/comments/{number}","contents_url":"https://api.github.com/repos/blairconrad/FakeItEasy/contents/{+path}","compare_url":"https://api.github.com/repos/blairconrad/FakeItEasy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blairconrad/FakeItEasy/merges","archive_url":"https://api.github.com/repos/blairconrad/FakeItEasy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blairconrad/FakeItEasy/downloads","issues_url":"https://api.github.com/repos/blairconrad/FakeItEasy/issues{/number}","pulls_url":"https://api.github.com/repos/blairconrad/FakeItEasy/pulls{/number}","milestones_url":"https://api.github.com/repos/blairconrad/FakeItEasy/milestones{/number}","notifications_url":"https://api.github.com/repos/blairconrad/FakeItEasy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blairconrad/FakeItEasy/labels{/name}","releases_url":"https://api.github.com/repos/blairconrad/FakeItEasy/releases{/id}","created_at":"2013-01-15T14:25:28Z","updated_at":"2014-08-26T10:40:30Z","pushed_at":"2014-09-12T11:31:41Z","git_url":"git://github.com/blairconrad/FakeItEasy.git","ssh_url":"git@github.com:blairconrad/FakeItEasy.git","clone_url":"https://github.com/blairconrad/FakeItEasy.git","svn_url":"https://github.com/blairconrad/FakeItEasy","homepage":"","size":21463,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"FakeItEasy:master","ref":"master","sha":"8f81b03d356ef4c578ed3041ca26b1267c92e5f5","user":{"login":"FakeItEasy","id":1713521,"avatar_url":"https://avatars.githubusercontent.com/u/1713521?v=2","gravatar_id":"","url":"https://api.github.com/users/FakeItEasy","html_url":"https://github.com/FakeItEasy","followers_url":"https://api.github.com/users/FakeItEasy/followers","following_url":"https://api.github.com/users/FakeItEasy/following{/other_user}","gists_url":"https://api.github.com/users/FakeItEasy/gists{/gist_id}","starred_url":"https://api.github.com/users/FakeItEasy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FakeItEasy/subscriptions","organizations_url":"https://api.github.com/users/FakeItEasy/orgs","repos_url":"https://api.github.com/users/FakeItEasy/repos","events_url":"https://api.github.com/users/FakeItEasy/events{/privacy}","received_events_url":"https://api.github.com/users/FakeItEasy/received_events","type":"Organization","site_admin":false},"repo":{"id":1920133,"name":"FakeItEasy","full_name":"FakeItEasy/FakeItEasy","owner":{"login":"FakeItEasy","id":1713521,"avatar_url":"https://avatars.githubusercontent.com/u/1713521?v=2","gravatar_id":"","url":"https://api.github.com/users/FakeItEasy","html_url":"https://github.com/FakeItEasy","followers_url":"https://api.github.com/users/FakeItEasy/followers","following_url":"https://api.github.com/users/FakeItEasy/following{/other_user}","gists_url":"https://api.github.com/users/FakeItEasy/gists{/gist_id}","starred_url":"https://api.github.com/users/FakeItEasy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FakeItEasy/subscriptions","organizations_url":"https://api.github.com/users/FakeItEasy/orgs","repos_url":"https://api.github.com/users/FakeItEasy/repos","events_url":"https://api.github.com/users/FakeItEasy/events{/privacy}","received_events_url":"https://api.github.com/users/FakeItEasy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FakeItEasy/FakeItEasy","description":"The easy mocking library for .NET","fork":false,"url":"https://api.github.com/repos/FakeItEasy/FakeItEasy","forks_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/forks","keys_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/teams","hooks_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/hooks","issue_events_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/issues/events{/number}","events_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/events","assignees_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/assignees{/user}","branches_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/branches{/branch}","tags_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/tags","blobs_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/git/refs{/sha}","trees_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/statuses/{sha}","languages_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/languages","stargazers_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/stargazers","contributors_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/contributors","subscribers_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/subscribers","subscription_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/subscription","commits_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/commits{/sha}","git_commits_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/git/commits{/sha}","comments_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/comments{/number}","issue_comment_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/issues/comments/{number}","contents_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/contents/{+path}","compare_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/merges","archive_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/downloads","issues_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/issues{/number}","pulls_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/pulls{/number}","milestones_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/milestones{/number}","notifications_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/labels{/name}","releases_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/releases{/id}","created_at":"2011-06-19T17:56:01Z","updated_at":"2014-10-03T18:44:55Z","pushed_at":"2014-08-25T10:41:32Z","git_url":"git://github.com/FakeItEasy/FakeItEasy.git","ssh_url":"git@github.com:FakeItEasy/FakeItEasy.git","clone_url":"https://github.com/FakeItEasy/FakeItEasy.git","svn_url":"https://github.com/FakeItEasy/FakeItEasy","homepage":"fakeiteasy.github.io","size":25773,"stargazers_count":292,"watchers_count":292,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":56,"mirror_url":null,"open_issues_count":48,"forks":56,"open_issues":48,"watchers":292,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FakeItEasy/FakeItEasy/pulls/352"},"html":{"href":"https://github.com/FakeItEasy/FakeItEasy/pull/352"},"issue":{"href":"https://api.github.com/repos/FakeItEasy/FakeItEasy/issues/352"},"comments":{"href":"https://api.github.com/repos/FakeItEasy/FakeItEasy/issues/352/comments"},"review_comments":{"href":"https://api.github.com/repos/FakeItEasy/FakeItEasy/pulls/352/comments"},"review_comment":{"href":"https://api.github.com/repos/FakeItEasy/FakeItEasy/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/FakeItEasy/FakeItEasy/pulls/352/commits"},"statuses":{"href":"https://api.github.com/repos/FakeItEasy/FakeItEasy/statuses/f47608f1f9c0957fd3e15a4aeded1bbd1ada5ca6"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":6,"review_comments":0,"commits":7,"additions":704,"deletions":54,"changed_files":17}}