GitHub PullRequestReviewCommentEvent at 2014-07-18 13:42:22
Repository: symfony
Actor: stof
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/15111074","id":15111074,"diff_hunk":"@@ -95,7 +95,20 @@ public function setCallback($callback = null)\n      */\n     public function setData($data = array())\n     {\n-        $this->data = @json_encode($data, $this->encodingOptions);\n+        $errorHandler = null;\n+        $errorHandler = set_error_handler(function () use (&$errorHandler) {\n+            if (JSON_ERROR_NONE !== json_last_error()) {","path":"src/Symfony/Component/HttpFoundation/JsonResponse.php","position":7,"original_position":7,"commit_id":"6543bffa17ee95af3337366cf8b3963d783afb32","original_commit_id":"6543bffa17ee95af3337366cf8b3963d783afb32","user":{"login":"stof","id":439401,"avatar_url":"https://avatars.githubusercontent.com/u/439401?","gravatar_id":"7894bbdf1c05b18a1444ad8c76c9d583","url":"https://api.github.com/users/stof","html_url":"https://github.com/stof","followers_url":"https://api.github.com/users/stof/followers","following_url":"https://api.github.com/users/stof/following{/other_user}","gists_url":"https://api.github.com/users/stof/gists{/gist_id}","starred_url":"https://api.github.com/users/stof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stof/subscriptions","organizations_url":"https://api.github.com/users/stof/orgs","repos_url":"https://api.github.com/users/stof/repos","events_url":"https://api.github.com/users/stof/events{/privacy}","received_events_url":"https://api.github.com/users/stof/received_events","type":"User","site_admin":false},"body":"are you sure this will cover the case properly ? If the error happens early in the error handling, the ``json_last_error`` might be related to a previous json operation.","created_at":"2014-07-18T13:42:22Z","updated_at":"2014-07-18T13:42:22Z","html_url":"https://github.com/symfony/symfony/pull/11418#discussion_r15111074","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/11418","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/15111074"},"html":{"href":"https://github.com/symfony/symfony/pull/11418#discussion_r15111074"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/11418"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/11418","id":18585855,"html_url":"https://github.com/symfony/symfony/pull/11418","diff_url":"https://github.com/symfony/symfony/pull/11418.diff","patch_url":"https://github.com/symfony/symfony/pull/11418.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/11418","number":11418,"state":"open","title":"[JsonResponse] Silent only JSON errors","user":{"login":"GromNaN","id":400034,"avatar_url":"https://avatars.githubusercontent.com/u/400034?","gravatar_id":"5a3c823a1badc6b0815aeea42cc93b72","url":"https://api.github.com/users/GromNaN","html_url":"https://github.com/GromNaN","followers_url":"https://api.github.com/users/GromNaN/followers","following_url":"https://api.github.com/users/GromNaN/following{/other_user}","gists_url":"https://api.github.com/users/GromNaN/gists{/gist_id}","starred_url":"https://api.github.com/users/GromNaN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GromNaN/subscriptions","organizations_url":"https://api.github.com/users/GromNaN/orgs","repos_url":"https://api.github.com/users/GromNaN/repos","events_url":"https://api.github.com/users/GromNaN/events{/privacy}","received_events_url":"https://api.github.com/users/GromNaN/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | yes\r\n| New feature?  | no\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | maybe\r\n| Fixed tickets | #11415\r\n| License       | MIT\r\n| Doc PR        | n/a","created_at":"2014-07-18T13:38:55Z","updated_at":"2014-07-18T13:42:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"829874745bf5fe362e7e171cc73b1c0e69f43335","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/11418/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/11418/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments/{number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/11418/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/6543bffa17ee95af3337366cf8b3963d783afb32","head":{"label":"GromNaN:jsonserializable-error","ref":"jsonserializable-error","sha":"6543bffa17ee95af3337366cf8b3963d783afb32","user":{"login":"GromNaN","id":400034,"avatar_url":"https://avatars.githubusercontent.com/u/400034?","gravatar_id":"5a3c823a1badc6b0815aeea42cc93b72","url":"https://api.github.com/users/GromNaN","html_url":"https://github.com/GromNaN","followers_url":"https://api.github.com/users/GromNaN/followers","following_url":"https://api.github.com/users/GromNaN/following{/other_user}","gists_url":"https://api.github.com/users/GromNaN/gists{/gist_id}","starred_url":"https://api.github.com/users/GromNaN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GromNaN/subscriptions","organizations_url":"https://api.github.com/users/GromNaN/orgs","repos_url":"https://api.github.com/users/GromNaN/repos","events_url":"https://api.github.com/users/GromNaN/events{/privacy}","received_events_url":"https://api.github.com/users/GromNaN/received_events","type":"User","site_admin":false},"repo":{"id":10675228,"name":"symfony","full_name":"GromNaN/symfony","owner":{"login":"GromNaN","id":400034,"avatar_url":"https://avatars.githubusercontent.com/u/400034?","gravatar_id":"5a3c823a1badc6b0815aeea42cc93b72","url":"https://api.github.com/users/GromNaN","html_url":"https://github.com/GromNaN","followers_url":"https://api.github.com/users/GromNaN/followers","following_url":"https://api.github.com/users/GromNaN/following{/other_user}","gists_url":"https://api.github.com/users/GromNaN/gists{/gist_id}","starred_url":"https://api.github.com/users/GromNaN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GromNaN/subscriptions","organizations_url":"https://api.github.com/users/GromNaN/orgs","repos_url":"https://api.github.com/users/GromNaN/repos","events_url":"https://api.github.com/users/GromNaN/events{/privacy}","received_events_url":"https://api.github.com/users/GromNaN/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GromNaN/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/GromNaN/symfony","forks_url":"https://api.github.com/repos/GromNaN/symfony/forks","keys_url":"https://api.github.com/repos/GromNaN/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GromNaN/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GromNaN/symfony/teams","hooks_url":"https://api.github.com/repos/GromNaN/symfony/hooks","issue_events_url":"https://api.github.com/repos/GromNaN/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/GromNaN/symfony/events","assignees_url":"https://api.github.com/repos/GromNaN/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/GromNaN/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/GromNaN/symfony/tags","blobs_url":"https://api.github.com/repos/GromNaN/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GromNaN/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GromNaN/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/GromNaN/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GromNaN/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/GromNaN/symfony/languages","stargazers_url":"https://api.github.com/repos/GromNaN/symfony/stargazers","contributors_url":"https://api.github.com/repos/GromNaN/symfony/contributors","subscribers_url":"https://api.github.com/repos/GromNaN/symfony/subscribers","subscription_url":"https://api.github.com/repos/GromNaN/symfony/subscription","commits_url":"https://api.github.com/repos/GromNaN/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/GromNaN/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/GromNaN/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/GromNaN/symfony/issues/comments/{number}","contents_url":"https://api.github.com/repos/GromNaN/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/GromNaN/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GromNaN/symfony/merges","archive_url":"https://api.github.com/repos/GromNaN/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GromNaN/symfony/downloads","issues_url":"https://api.github.com/repos/GromNaN/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/GromNaN/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/GromNaN/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/GromNaN/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GromNaN/symfony/labels{/name}","releases_url":"https://api.github.com/repos/GromNaN/symfony/releases{/id}","created_at":"2013-06-13T20:29:27Z","updated_at":"2014-04-11T12:08:00Z","pushed_at":"2014-07-18T13:26:30Z","git_url":"git://github.com/GromNaN/symfony.git","ssh_url":"git@github.com:GromNaN/symfony.git","clone_url":"https://github.com/GromNaN/symfony.git","svn_url":"https://github.com/GromNaN/symfony","homepage":"symfony.com","size":35475,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:master","ref":"master","sha":"397687f345f4ea83f344a54275f4bc328ac2d4b4","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?","gravatar_id":"bc6312a5b583c4258c9fad11122c6e31","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?","gravatar_id":"bc6312a5b583c4258c9fad11122c6e31","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments/{number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","created_at":"2010-01-04T14:21:21Z","updated_at":"2014-07-18T13:24:07Z","pushed_at":"2014-07-18T09:07:27Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":159270,"stargazers_count":8626,"watchers_count":8626,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"forks_count":3312,"mirror_url":null,"open_issues_count":807,"forks":3312,"open_issues":807,"watchers":8626,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/11418"},"html":{"href":"https://github.com/symfony/symfony/pull/11418"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/11418"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/11418/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/11418/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/11418/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/6543bffa17ee95af3337366cf8b3963d783afb32"}}}}