GitHub PullRequestReviewCommentEvent at 2014-10-06 14:35:46
Repository: docker
Actor: vbatts
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/18459756","id":18459756,"diff_hunk":"@@ -0,0 +1,7 @@\n+// +build dockerstatic\n+\n+package dockerversion\n+\n+func init() {\n+\tIAMSTATIC = true\n+}","path":"dockerversion/static.go","position":7,"original_position":7,"commit_id":"b3ac49ead57b446a662c74ad67b210a9248d3010","original_commit_id":"b3ac49ead57b446a662c74ad67b210a9248d3010","user":{"login":"vbatts","id":67049,"avatar_url":"https://avatars.githubusercontent.com/u/67049?v=2","gravatar_id":"","url":"https://api.github.com/users/vbatts","html_url":"https://github.com/vbatts","followers_url":"https://api.github.com/users/vbatts/followers","following_url":"https://api.github.com/users/vbatts/following{/other_user}","gists_url":"https://api.github.com/users/vbatts/gists{/gist_id}","starred_url":"https://api.github.com/users/vbatts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vbatts/subscriptions","organizations_url":"https://api.github.com/users/vbatts/orgs","repos_url":"https://api.github.com/users/vbatts/repos","events_url":"https://api.github.com/users/vbatts/events{/privacy}","received_events_url":"https://api.github.com/users/vbatts/received_events","type":"User","site_admin":false},"body":"I think this file ought to be created like the `details.go` as well, and corresponding to whether the `binary` or `dynbinary` target is made.","created_at":"2014-10-06T14:35:46Z","updated_at":"2014-10-06T14:35:46Z","html_url":"https://github.com/docker/docker/pull/8325#discussion_r18459756","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/8325","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/18459756"},"html":{"href":"https://github.com/docker/docker/pull/8325#discussion_r18459756"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/8325"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/8325","id":22049188,"html_url":"https://github.com/docker/docker/pull/8325","diff_url":"https://github.com/docker/docker/pull/8325.diff","patch_url":"https://github.com/docker/docker/pull/8325.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/8325","number":8325,"state":"open","locked":false,"title":"Stop using -X flag to set global variables","user":{"login":"mwhudson","id":672022,"avatar_url":"https://avatars.githubusercontent.com/u/672022?v=2","gravatar_id":"","url":"https://api.github.com/users/mwhudson","html_url":"https://github.com/mwhudson","followers_url":"https://api.github.com/users/mwhudson/followers","following_url":"https://api.github.com/users/mwhudson/following{/other_user}","gists_url":"https://api.github.com/users/mwhudson/gists{/gist_id}","starred_url":"https://api.github.com/users/mwhudson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwhudson/subscriptions","organizations_url":"https://api.github.com/users/mwhudson/orgs","repos_url":"https://api.github.com/users/mwhudson/repos","events_url":"https://api.github.com/users/mwhudson/events{/privacy}","received_events_url":"https://api.github.com/users/mwhudson/received_events","type":"User","site_admin":false},"body":"I'd like to build docker with gccgo, which does not have any version of go tool 6l's -X flag.  So this replaces the use of this flag with either code generation or build tags as appropriate.\r\n\r\nI find make.sh and the bundles all fairly confusing, but I **think** this is correct.  \"make test\" passes at least!","created_at":"2014-10-01T02:52:30Z","updated_at":"2014-10-06T14:35:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"93977928ae3e4db26ff710546a3e14d2a02b2b02","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker/pulls/8325/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/8325/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments/{number}","comments_url":"https://api.github.com/repos/docker/docker/issues/8325/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/b3ac49ead57b446a662c74ad67b210a9248d3010","head":{"label":"mwhudson:do-not-use-X","ref":"do-not-use-X","sha":"b3ac49ead57b446a662c74ad67b210a9248d3010","user":{"login":"mwhudson","id":672022,"avatar_url":"https://avatars.githubusercontent.com/u/672022?v=2","gravatar_id":"","url":"https://api.github.com/users/mwhudson","html_url":"https://github.com/mwhudson","followers_url":"https://api.github.com/users/mwhudson/followers","following_url":"https://api.github.com/users/mwhudson/following{/other_user}","gists_url":"https://api.github.com/users/mwhudson/gists{/gist_id}","starred_url":"https://api.github.com/users/mwhudson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwhudson/subscriptions","organizations_url":"https://api.github.com/users/mwhudson/orgs","repos_url":"https://api.github.com/users/mwhudson/repos","events_url":"https://api.github.com/users/mwhudson/events{/privacy}","received_events_url":"https://api.github.com/users/mwhudson/received_events","type":"User","site_admin":false},"repo":{"id":23573097,"name":"docker","full_name":"mwhudson/docker","owner":{"login":"mwhudson","id":672022,"avatar_url":"https://avatars.githubusercontent.com/u/672022?v=2","gravatar_id":"","url":"https://api.github.com/users/mwhudson","html_url":"https://github.com/mwhudson","followers_url":"https://api.github.com/users/mwhudson/followers","following_url":"https://api.github.com/users/mwhudson/following{/other_user}","gists_url":"https://api.github.com/users/mwhudson/gists{/gist_id}","starred_url":"https://api.github.com/users/mwhudson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwhudson/subscriptions","organizations_url":"https://api.github.com/users/mwhudson/orgs","repos_url":"https://api.github.com/users/mwhudson/repos","events_url":"https://api.github.com/users/mwhudson/events{/privacy}","received_events_url":"https://api.github.com/users/mwhudson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mwhudson/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/mwhudson/docker","forks_url":"https://api.github.com/repos/mwhudson/docker/forks","keys_url":"https://api.github.com/repos/mwhudson/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mwhudson/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mwhudson/docker/teams","hooks_url":"https://api.github.com/repos/mwhudson/docker/hooks","issue_events_url":"https://api.github.com/repos/mwhudson/docker/issues/events{/number}","events_url":"https://api.github.com/repos/mwhudson/docker/events","assignees_url":"https://api.github.com/repos/mwhudson/docker/assignees{/user}","branches_url":"https://api.github.com/repos/mwhudson/docker/branches{/branch}","tags_url":"https://api.github.com/repos/mwhudson/docker/tags","blobs_url":"https://api.github.com/repos/mwhudson/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mwhudson/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mwhudson/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/mwhudson/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mwhudson/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/mwhudson/docker/languages","stargazers_url":"https://api.github.com/repos/mwhudson/docker/stargazers","contributors_url":"https://api.github.com/repos/mwhudson/docker/contributors","subscribers_url":"https://api.github.com/repos/mwhudson/docker/subscribers","subscription_url":"https://api.github.com/repos/mwhudson/docker/subscription","commits_url":"https://api.github.com/repos/mwhudson/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/mwhudson/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/mwhudson/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/mwhudson/docker/issues/comments/{number}","contents_url":"https://api.github.com/repos/mwhudson/docker/contents/{+path}","compare_url":"https://api.github.com/repos/mwhudson/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mwhudson/docker/merges","archive_url":"https://api.github.com/repos/mwhudson/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mwhudson/docker/downloads","issues_url":"https://api.github.com/repos/mwhudson/docker/issues{/number}","pulls_url":"https://api.github.com/repos/mwhudson/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/mwhudson/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/mwhudson/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mwhudson/docker/labels{/name}","releases_url":"https://api.github.com/repos/mwhudson/docker/releases{/id}","created_at":"2014-09-02T09:40:36Z","updated_at":"2014-09-02T09:36:58Z","pushed_at":"2014-10-02T01:44:17Z","git_url":"git://github.com/mwhudson/docker.git","ssh_url":"git@github.com:mwhudson/docker.git","clone_url":"https://github.com/mwhudson/docker.git","svn_url":"https://github.com/mwhudson/docker","homepage":"http://www.docker.com","size":34402,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"04251b3e544d82db2dfc140bd27172a7f1876e5e","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=2","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=2","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments/{number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","created_at":"2013-01-18T18:10:57Z","updated_at":"2014-10-06T14:35:05Z","pushed_at":"2014-10-04T02:03:50Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":146242,"stargazers_count":15546,"watchers_count":15546,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2978,"mirror_url":null,"open_issues_count":787,"forks":2978,"open_issues":787,"watchers":15546,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/8325"},"html":{"href":"https://github.com/docker/docker/pull/8325"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/8325"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/8325/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/8325/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/8325/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/b3ac49ead57b446a662c74ad67b210a9248d3010"}}}}