GitHub PushEvent at 2014-06-11 00:48:22
Repository: canvas-lms
Actor: instructure-gerrit
Payload: {"shas":[["53920a96ce575e494bb14da5a3f059998f700a53","bfb4987b134a00f73d881fff5113b1d5fa1876bc@instructure.com","add explicit poll choice ordering and poll_session deletion\n\nfixes CNVS-13521,CNVS-13489\nThis commit adds 3 things.  One is a fix for deleting a poll_session when\nthere are poll_submissions created already for the poll_session. The\nsecond is the addition of a new attribute on poll_choices called\n'position'.\nThe 'position' attribute specifies the order a poll choice should be\nreturned in. The third is the visibility of poll sessions to students:\nas long as a student is enrolled in the course (and course section, if\nit exists on the poll session) associated with the poll session, they\ncan access it, whether or not it's open or closed.\n\nTest plans\n1. Deleting a poll session\nAs a teacher\n- Create a poll and related poll session\n- Open the poll session for submissions\nAs a student\n- Create a submission for the newly created poll session\nAs a teacher\n- You should be able to delete the poll session\n\n2. Position ordering attribute\nAs a teacher\n- Create a poll\n- Create poll choices, passing along the 'position' attribute to specify\n  ordering (try to mix these up, e.g. create a poll choice with a\n  position\n  of 2, then a poll choice with an position of 4, then a poll choice with\n  an position of 3, then a poll choice with an position of 1)\n- Retrieve the poll choices for the poll with the poll choices index\n  endpoint\n- The poll should be returned in the order they were specified using the\n  'position' attribute\n\n3. Poll session visibility to students\nAs a teacher\n- Create a poll\n- Create an associated poll session with a valid course\nAs a student enrolled in the given course\n- You should be able to view the poll session whether or not it's open\n  or closed.\nAs a student not enrolled in the given course\n- You should not be able to view the poll session, whether or not it's\n  open or closed.\n\nChange-Id: Ifabd64540d843c83f3a22fb6668c4fcac8f728b0\nReviewed-on: https://gerrit.instructure.com/36087\nReviewed-by: Derek DeVries <ddevries@instructure.com>\nQA-Review: Trevor deHaan <tdehaan@instructure.com>\nProduct-Review: Bryan Madsen <bryan@instructure.com>\nTested-by: Jenkins <jenkins@instructure.com>\nProduct-Review: Josh Simpson <jsimpson@instructure.com>","Josh Simpson",true]],"size":1,"ref":"refs/heads/master","head":"53920a96ce575e494bb14da5a3f059998f700a53"}