GitHub PullRequestReviewCommentEvent at 2014-07-19 15:50:36
Repository: vispy
Actor: Eric89GXL
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/vispy/vispy/pulls/comments/15144318","id":15144318,"diff_hunk":"@@ -0,0 +1,155 @@\n+# -*- coding: utf-8 -*-\n+\n+\"\"\"\n+Tests for EllipseVisual\n+All images are of size (100,100) to keep a small file size\n+\"\"\"\n+\n+import numpy as np\n+from numpy.testing import assert_array_equal\n+from vispy.app import Canvas\n+from vispy import gloo\n+from vispy.gloo.util import _screenshot\n+from vispy.scene import visuals, transforms\n+from vispy.testing import requires_application\n+from vispy.util.dataio import imread, _check_img_lib\n+from vispy.util import get_test_file\n+\n+has_img_lib = not all(c is None for c in _check_img_lib())\n+requires_img_lib = np.testing.dec.skipif(not has_img_lib, 'imageio or PIL '\n+                                         'required')\n+\n+\n+@requires_application()\n+@requires_img_lib\n+def test_circle_draw1():\n+    \"\"\"Test drawing a simple borderless circle using EllipseVisual\"\"\"\n+    with Canvas(size=(100, 100)) as c:\n+        c.ellipse = visuals.Ellipse(pos=(0.5, 0.3, 0), radius=0.4,\n+                                    color=(1, 0, 0, 1))\n+        gloo.set_clear_color((0, 0, 0, 1))\n+        gloo.clear()\n+        gloo.set_viewport(0, 0, *c.size)\n+        c.ellipse.draw()\n+        ss = _screenshot(alpha=False)\n+        im = imread(get_test_file('visuals/circle1.png'))\n+        assert_array_equal(im, ss)","path":"vispy/scene/visuals/tests/test_ellipse.py","position":36,"original_position":36,"commit_id":"f35b867ac2940e651b64b02a50cf77e5f4337a49","original_commit_id":"f35b867ac2940e651b64b02a50cf77e5f4337a49","user":{"login":"Eric89GXL","id":2365790,"avatar_url":"https://avatars.githubusercontent.com/u/2365790?","gravatar_id":"bfd1a4884c9621f28ee42e38f652db99","url":"https://api.github.com/users/Eric89GXL","html_url":"https://github.com/Eric89GXL","followers_url":"https://api.github.com/users/Eric89GXL/followers","following_url":"https://api.github.com/users/Eric89GXL/following{/other_user}","gists_url":"https://api.github.com/users/Eric89GXL/gists{/gist_id}","starred_url":"https://api.github.com/users/Eric89GXL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eric89GXL/subscriptions","organizations_url":"https://api.github.com/users/Eric89GXL/orgs","repos_url":"https://api.github.com/users/Eric89GXL/repos","events_url":"https://api.github.com/users/Eric89GXL/events{/privacy}","received_events_url":"https://api.github.com/users/Eric89GXL/received_events","type":"User","site_admin":false},"body":"Or better than `None`, if the user passes the string `'screenshot'` (it's more explicit)","created_at":"2014-07-19T15:50:36Z","updated_at":"2014-07-19T15:50:36Z","html_url":"https://github.com/vispy/vispy/pull/327#discussion_r15144318","pull_request_url":"https://api.github.com/repos/vispy/vispy/pulls/327","_links":{"self":{"href":"https://api.github.com/repos/vispy/vispy/pulls/comments/15144318"},"html":{"href":"https://github.com/vispy/vispy/pull/327#discussion_r15144318"},"pull_request":{"href":"https://api.github.com/repos/vispy/vispy/pulls/327"}}},"pull_request":{"url":"https://api.github.com/repos/vispy/vispy/pulls/327","id":18541242,"html_url":"https://github.com/vispy/vispy/pull/327","diff_url":"https://github.com/vispy/vispy/pull/327.diff","patch_url":"https://github.com/vispy/vispy/pull/327.patch","issue_url":"https://api.github.com/repos/vispy/vispy/issues/327","number":327,"state":"open","title":"WIP: Visuals tests","user":{"login":"mssurajkaiga","id":1672294,"avatar_url":"https://avatars.githubusercontent.com/u/1672294?","gravatar_id":"099d0de5f43974b734dbb9157ee653d7","url":"https://api.github.com/users/mssurajkaiga","html_url":"https://github.com/mssurajkaiga","followers_url":"https://api.github.com/users/mssurajkaiga/followers","following_url":"https://api.github.com/users/mssurajkaiga/following{/other_user}","gists_url":"https://api.github.com/users/mssurajkaiga/gists{/gist_id}","starred_url":"https://api.github.com/users/mssurajkaiga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mssurajkaiga/subscriptions","organizations_url":"https://api.github.com/users/mssurajkaiga/orgs","repos_url":"https://api.github.com/users/mssurajkaiga/repos","events_url":"https://api.github.com/users/mssurajkaiga/events{/privacy}","received_events_url":"https://api.github.com/users/mssurajkaiga/received_events","type":"User","site_admin":false},"body":"Currently basic tests for different types of polygons, ellipses and arcs have been added.","created_at":"2014-07-17T17:09:57Z","updated_at":"2014-07-19T15:50:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bb694e06a76968cb1d3493184e42296da43527c4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/vispy/vispy/pulls/327/commits","review_comments_url":"https://api.github.com/repos/vispy/vispy/pulls/327/comments","review_comment_url":"https://api.github.com/repos/vispy/vispy/pulls/comments/{number}","comments_url":"https://api.github.com/repos/vispy/vispy/issues/327/comments","statuses_url":"https://api.github.com/repos/vispy/vispy/statuses/f35b867ac2940e651b64b02a50cf77e5f4337a49","head":{"label":"mssurajkaiga:visual-testing","ref":"visual-testing","sha":"f35b867ac2940e651b64b02a50cf77e5f4337a49","user":{"login":"mssurajkaiga","id":1672294,"avatar_url":"https://avatars.githubusercontent.com/u/1672294?","gravatar_id":"099d0de5f43974b734dbb9157ee653d7","url":"https://api.github.com/users/mssurajkaiga","html_url":"https://github.com/mssurajkaiga","followers_url":"https://api.github.com/users/mssurajkaiga/followers","following_url":"https://api.github.com/users/mssurajkaiga/following{/other_user}","gists_url":"https://api.github.com/users/mssurajkaiga/gists{/gist_id}","starred_url":"https://api.github.com/users/mssurajkaiga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mssurajkaiga/subscriptions","organizations_url":"https://api.github.com/users/mssurajkaiga/orgs","repos_url":"https://api.github.com/users/mssurajkaiga/repos","events_url":"https://api.github.com/users/mssurajkaiga/events{/privacy}","received_events_url":"https://api.github.com/users/mssurajkaiga/received_events","type":"User","site_admin":false},"repo":{"id":16875032,"name":"vispy","full_name":"mssurajkaiga/vispy","owner":{"login":"mssurajkaiga","id":1672294,"avatar_url":"https://avatars.githubusercontent.com/u/1672294?","gravatar_id":"099d0de5f43974b734dbb9157ee653d7","url":"https://api.github.com/users/mssurajkaiga","html_url":"https://github.com/mssurajkaiga","followers_url":"https://api.github.com/users/mssurajkaiga/followers","following_url":"https://api.github.com/users/mssurajkaiga/following{/other_user}","gists_url":"https://api.github.com/users/mssurajkaiga/gists{/gist_id}","starred_url":"https://api.github.com/users/mssurajkaiga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mssurajkaiga/subscriptions","organizations_url":"https://api.github.com/users/mssurajkaiga/orgs","repos_url":"https://api.github.com/users/mssurajkaiga/repos","events_url":"https://api.github.com/users/mssurajkaiga/events{/privacy}","received_events_url":"https://api.github.com/users/mssurajkaiga/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mssurajkaiga/vispy","description":"Main repository for Vispy","fork":true,"url":"https://api.github.com/repos/mssurajkaiga/vispy","forks_url":"https://api.github.com/repos/mssurajkaiga/vispy/forks","keys_url":"https://api.github.com/repos/mssurajkaiga/vispy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mssurajkaiga/vispy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mssurajkaiga/vispy/teams","hooks_url":"https://api.github.com/repos/mssurajkaiga/vispy/hooks","issue_events_url":"https://api.github.com/repos/mssurajkaiga/vispy/issues/events{/number}","events_url":"https://api.github.com/repos/mssurajkaiga/vispy/events","assignees_url":"https://api.github.com/repos/mssurajkaiga/vispy/assignees{/user}","branches_url":"https://api.github.com/repos/mssurajkaiga/vispy/branches{/branch}","tags_url":"https://api.github.com/repos/mssurajkaiga/vispy/tags","blobs_url":"https://api.github.com/repos/mssurajkaiga/vispy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mssurajkaiga/vispy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mssurajkaiga/vispy/git/refs{/sha}","trees_url":"https://api.github.com/repos/mssurajkaiga/vispy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mssurajkaiga/vispy/statuses/{sha}","languages_url":"https://api.github.com/repos/mssurajkaiga/vispy/languages","stargazers_url":"https://api.github.com/repos/mssurajkaiga/vispy/stargazers","contributors_url":"https://api.github.com/repos/mssurajkaiga/vispy/contributors","subscribers_url":"https://api.github.com/repos/mssurajkaiga/vispy/subscribers","subscription_url":"https://api.github.com/repos/mssurajkaiga/vispy/subscription","commits_url":"https://api.github.com/repos/mssurajkaiga/vispy/commits{/sha}","git_commits_url":"https://api.github.com/repos/mssurajkaiga/vispy/git/commits{/sha}","comments_url":"https://api.github.com/repos/mssurajkaiga/vispy/comments{/number}","issue_comment_url":"https://api.github.com/repos/mssurajkaiga/vispy/issues/comments/{number}","contents_url":"https://api.github.com/repos/mssurajkaiga/vispy/contents/{+path}","compare_url":"https://api.github.com/repos/mssurajkaiga/vispy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mssurajkaiga/vispy/merges","archive_url":"https://api.github.com/repos/mssurajkaiga/vispy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mssurajkaiga/vispy/downloads","issues_url":"https://api.github.com/repos/mssurajkaiga/vispy/issues{/number}","pulls_url":"https://api.github.com/repos/mssurajkaiga/vispy/pulls{/number}","milestones_url":"https://api.github.com/repos/mssurajkaiga/vispy/milestones{/number}","notifications_url":"https://api.github.com/repos/mssurajkaiga/vispy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mssurajkaiga/vispy/labels{/name}","releases_url":"https://api.github.com/repos/mssurajkaiga/vispy/releases{/id}","created_at":"2014-02-16T00:25:15Z","updated_at":"2014-07-09T14:00:39Z","pushed_at":"2014-07-19T13:14:36Z","git_url":"git://github.com/mssurajkaiga/vispy.git","ssh_url":"git@github.com:mssurajkaiga/vispy.git","clone_url":"https://github.com/mssurajkaiga/vispy.git","svn_url":"https://github.com/mssurajkaiga/vispy","homepage":"","size":4678,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vispy:master","ref":"master","sha":"d87ee8c35eed6060c13dc3942b8a5db7072be8ca","user":{"login":"vispy","id":3934254,"avatar_url":"https://avatars.githubusercontent.com/u/3934254?","gravatar_id":"47bf7b9218948408c9b197107b484b1f","url":"https://api.github.com/users/vispy","html_url":"https://github.com/vispy","followers_url":"https://api.github.com/users/vispy/followers","following_url":"https://api.github.com/users/vispy/following{/other_user}","gists_url":"https://api.github.com/users/vispy/gists{/gist_id}","starred_url":"https://api.github.com/users/vispy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vispy/subscriptions","organizations_url":"https://api.github.com/users/vispy/orgs","repos_url":"https://api.github.com/users/vispy/repos","events_url":"https://api.github.com/users/vispy/events{/privacy}","received_events_url":"https://api.github.com/users/vispy/received_events","type":"Organization","site_admin":false},"repo":{"id":8935948,"name":"vispy","full_name":"vispy/vispy","owner":{"login":"vispy","id":3934254,"avatar_url":"https://avatars.githubusercontent.com/u/3934254?","gravatar_id":"47bf7b9218948408c9b197107b484b1f","url":"https://api.github.com/users/vispy","html_url":"https://github.com/vispy","followers_url":"https://api.github.com/users/vispy/followers","following_url":"https://api.github.com/users/vispy/following{/other_user}","gists_url":"https://api.github.com/users/vispy/gists{/gist_id}","starred_url":"https://api.github.com/users/vispy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vispy/subscriptions","organizations_url":"https://api.github.com/users/vispy/orgs","repos_url":"https://api.github.com/users/vispy/repos","events_url":"https://api.github.com/users/vispy/events{/privacy}","received_events_url":"https://api.github.com/users/vispy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vispy/vispy","description":"Main repository for Vispy","fork":false,"url":"https://api.github.com/repos/vispy/vispy","forks_url":"https://api.github.com/repos/vispy/vispy/forks","keys_url":"https://api.github.com/repos/vispy/vispy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vispy/vispy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vispy/vispy/teams","hooks_url":"https://api.github.com/repos/vispy/vispy/hooks","issue_events_url":"https://api.github.com/repos/vispy/vispy/issues/events{/number}","events_url":"https://api.github.com/repos/vispy/vispy/events","assignees_url":"https://api.github.com/repos/vispy/vispy/assignees{/user}","branches_url":"https://api.github.com/repos/vispy/vispy/branches{/branch}","tags_url":"https://api.github.com/repos/vispy/vispy/tags","blobs_url":"https://api.github.com/repos/vispy/vispy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vispy/vispy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vispy/vispy/git/refs{/sha}","trees_url":"https://api.github.com/repos/vispy/vispy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vispy/vispy/statuses/{sha}","languages_url":"https://api.github.com/repos/vispy/vispy/languages","stargazers_url":"https://api.github.com/repos/vispy/vispy/stargazers","contributors_url":"https://api.github.com/repos/vispy/vispy/contributors","subscribers_url":"https://api.github.com/repos/vispy/vispy/subscribers","subscription_url":"https://api.github.com/repos/vispy/vispy/subscription","commits_url":"https://api.github.com/repos/vispy/vispy/commits{/sha}","git_commits_url":"https://api.github.com/repos/vispy/vispy/git/commits{/sha}","comments_url":"https://api.github.com/repos/vispy/vispy/comments{/number}","issue_comment_url":"https://api.github.com/repos/vispy/vispy/issues/comments/{number}","contents_url":"https://api.github.com/repos/vispy/vispy/contents/{+path}","compare_url":"https://api.github.com/repos/vispy/vispy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vispy/vispy/merges","archive_url":"https://api.github.com/repos/vispy/vispy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vispy/vispy/downloads","issues_url":"https://api.github.com/repos/vispy/vispy/issues{/number}","pulls_url":"https://api.github.com/repos/vispy/vispy/pulls{/number}","milestones_url":"https://api.github.com/repos/vispy/vispy/milestones{/number}","notifications_url":"https://api.github.com/repos/vispy/vispy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vispy/vispy/labels{/name}","releases_url":"https://api.github.com/repos/vispy/vispy/releases{/id}","created_at":"2013-03-21T18:43:22Z","updated_at":"2014-07-18T23:57:27Z","pushed_at":"2014-07-16T01:37:01Z","git_url":"git://github.com/vispy/vispy.git","ssh_url":"git@github.com:vispy/vispy.git","clone_url":"https://github.com/vispy/vispy.git","svn_url":"https://github.com/vispy/vispy","homepage":"","size":18053,"stargazers_count":176,"watchers_count":176,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":32,"mirror_url":null,"open_issues_count":89,"forks":32,"open_issues":89,"watchers":176,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vispy/vispy/pulls/327"},"html":{"href":"https://github.com/vispy/vispy/pull/327"},"issue":{"href":"https://api.github.com/repos/vispy/vispy/issues/327"},"comments":{"href":"https://api.github.com/repos/vispy/vispy/issues/327/comments"},"review_comments":{"href":"https://api.github.com/repos/vispy/vispy/pulls/327/comments"},"review_comment":{"href":"https://api.github.com/repos/vispy/vispy/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/vispy/vispy/pulls/327/commits"},"statuses":{"href":"https://api.github.com/repos/vispy/vispy/statuses/f35b867ac2940e651b64b02a50cf77e5f4337a49"}}}}