GitHub PullRequestEvent at 2014-08-06 21:36:52
Repository: PyCMake
Actor: msarahan
Payload: {"action":"closed","number":16,"pull_request":{"url":"https://api.github.com/repos/PyCMake/PyCMake/pulls/16","id":18626359,"html_url":"https://github.com/PyCMake/PyCMake/pull/16","diff_url":"https://github.com/PyCMake/PyCMake/pull/16.diff","patch_url":"https://github.com/PyCMake/PyCMake/pull/16.patch","issue_url":"https://api.github.com/repos/PyCMake/PyCMake/issues/16","number":16,"state":"closed","title":"How to test python module","user":{"login":"msarahan","id":38393,"avatar_url":"https://avatars.githubusercontent.com/u/38393?v=2","gravatar_id":"3f1a7ea70c61f7db7b0e9d6ba912f23c","url":"https://api.github.com/users/msarahan","html_url":"https://github.com/msarahan","followers_url":"https://api.github.com/users/msarahan/followers","following_url":"https://api.github.com/users/msarahan/following{/other_user}","gists_url":"https://api.github.com/users/msarahan/gists{/gist_id}","starred_url":"https://api.github.com/users/msarahan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msarahan/subscriptions","organizations_url":"https://api.github.com/users/msarahan/orgs","repos_url":"https://api.github.com/users/msarahan/repos","events_url":"https://api.github.com/users/msarahan/events{/privacy}","received_events_url":"https://api.github.com/users/msarahan/received_events","type":"User","site_admin":false},"body":"Hi guys,\r\n\r\nThis is a revision on Brad's PR that now calls pip to install the test package.  I'm hung up on an issue here: the data_files keyword.  From the Python docs (https://docs.python.org/2/distutils/setupscript.html), data_files looks like it is potentially dangerously platform specific.  I have Ondrej and Anthony's use cases in mind, where they may want to install things to /usr/lib or whatever.  I don't see a great way of making that kind of thing cross-platform.\r\n\r\nI'm thinking that maybe the output of the CMake-generated manifest belong in package_data, rather than data_files?  This means libraries generated by the CMake build would not be system-wide, but rather contained within the package.  This thus does not really meet Ondrej and Anthony's use case.\r\n\r\nIf we don't do this, then the alternative might be to not alter the CMAKE_INSTALL_PREFIX, so that CMake figures out the best cross-platform place to put things.  It would work on the system building the package, but it is essentially just leaving the installation part totally to CMake and then would not involve distutils in copying CMake's output.\r\n\r\nAny opinions or enlightenment for me here?\r\n\r\nPS: the manifest parser (CMaker._parse_manifest) currently does things wrong.  The python docs above show that the directory is where you want the files to go, not where they are (this was my original interpretation).  I have left it broken until we decide what the best way to do this is, because that decision determines the output folders we would use.","created_at":"2014-07-20T03:25:29Z","updated_at":"2014-08-06T21:36:51Z","closed_at":"2014-08-06T21:36:51Z","merged_at":null,"merge_commit_sha":"d3438fdb0d789cab6edf6b20c0db33ed6df20003","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/PyCMake/PyCMake/pulls/16/commits","review_comments_url":"https://api.github.com/repos/PyCMake/PyCMake/pulls/16/comments","review_comment_url":"https://api.github.com/repos/PyCMake/PyCMake/pulls/comments/{number}","comments_url":"https://api.github.com/repos/PyCMake/PyCMake/issues/16/comments","statuses_url":"https://api.github.com/repos/PyCMake/PyCMake/statuses/32b3fb81aba9e10741a9a7734c3704d30be9f861","head":{"label":"msarahan:HowToTestPythonModule","ref":"HowToTestPythonModule","sha":"32b3fb81aba9e10741a9a7734c3704d30be9f861","user":{"login":"msarahan","id":38393,"avatar_url":"https://avatars.githubusercontent.com/u/38393?v=2","gravatar_id":"3f1a7ea70c61f7db7b0e9d6ba912f23c","url":"https://api.github.com/users/msarahan","html_url":"https://github.com/msarahan","followers_url":"https://api.github.com/users/msarahan/followers","following_url":"https://api.github.com/users/msarahan/following{/other_user}","gists_url":"https://api.github.com/users/msarahan/gists{/gist_id}","starred_url":"https://api.github.com/users/msarahan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msarahan/subscriptions","organizations_url":"https://api.github.com/users/msarahan/orgs","repos_url":"https://api.github.com/users/msarahan/repos","events_url":"https://api.github.com/users/msarahan/events{/privacy}","received_events_url":"https://api.github.com/users/msarahan/received_events","type":"User","site_admin":false},"repo":{"id":21772308,"name":"PyCMake","full_name":"msarahan/PyCMake","owner":{"login":"msarahan","id":38393,"avatar_url":"https://avatars.githubusercontent.com/u/38393?v=2","gravatar_id":"3f1a7ea70c61f7db7b0e9d6ba912f23c","url":"https://api.github.com/users/msarahan","html_url":"https://github.com/msarahan","followers_url":"https://api.github.com/users/msarahan/followers","following_url":"https://api.github.com/users/msarahan/following{/other_user}","gists_url":"https://api.github.com/users/msarahan/gists{/gist_id}","starred_url":"https://api.github.com/users/msarahan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msarahan/subscriptions","organizations_url":"https://api.github.com/users/msarahan/orgs","repos_url":"https://api.github.com/users/msarahan/repos","events_url":"https://api.github.com/users/msarahan/events{/privacy}","received_events_url":"https://api.github.com/users/msarahan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/msarahan/PyCMake","description":"Simplify building Python extensions with CMake","fork":true,"url":"https://api.github.com/repos/msarahan/PyCMake","forks_url":"https://api.github.com/repos/msarahan/PyCMake/forks","keys_url":"https://api.github.com/repos/msarahan/PyCMake/keys{/key_id}","collaborators_url":"https://api.github.com/repos/msarahan/PyCMake/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/msarahan/PyCMake/teams","hooks_url":"https://api.github.com/repos/msarahan/PyCMake/hooks","issue_events_url":"https://api.github.com/repos/msarahan/PyCMake/issues/events{/number}","events_url":"https://api.github.com/repos/msarahan/PyCMake/events","assignees_url":"https://api.github.com/repos/msarahan/PyCMake/assignees{/user}","branches_url":"https://api.github.com/repos/msarahan/PyCMake/branches{/branch}","tags_url":"https://api.github.com/repos/msarahan/PyCMake/tags","blobs_url":"https://api.github.com/repos/msarahan/PyCMake/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/msarahan/PyCMake/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/msarahan/PyCMake/git/refs{/sha}","trees_url":"https://api.github.com/repos/msarahan/PyCMake/git/trees{/sha}","statuses_url":"https://api.github.com/repos/msarahan/PyCMake/statuses/{sha}","languages_url":"https://api.github.com/repos/msarahan/PyCMake/languages","stargazers_url":"https://api.github.com/repos/msarahan/PyCMake/stargazers","contributors_url":"https://api.github.com/repos/msarahan/PyCMake/contributors","subscribers_url":"https://api.github.com/repos/msarahan/PyCMake/subscribers","subscription_url":"https://api.github.com/repos/msarahan/PyCMake/subscription","commits_url":"https://api.github.com/repos/msarahan/PyCMake/commits{/sha}","git_commits_url":"https://api.github.com/repos/msarahan/PyCMake/git/commits{/sha}","comments_url":"https://api.github.com/repos/msarahan/PyCMake/comments{/number}","issue_comment_url":"https://api.github.com/repos/msarahan/PyCMake/issues/comments/{number}","contents_url":"https://api.github.com/repos/msarahan/PyCMake/contents/{+path}","compare_url":"https://api.github.com/repos/msarahan/PyCMake/compare/{base}...{head}","merges_url":"https://api.github.com/repos/msarahan/PyCMake/merges","archive_url":"https://api.github.com/repos/msarahan/PyCMake/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/msarahan/PyCMake/downloads","issues_url":"https://api.github.com/repos/msarahan/PyCMake/issues{/number}","pulls_url":"https://api.github.com/repos/msarahan/PyCMake/pulls{/number}","milestones_url":"https://api.github.com/repos/msarahan/PyCMake/milestones{/number}","notifications_url":"https://api.github.com/repos/msarahan/PyCMake/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/msarahan/PyCMake/labels{/name}","releases_url":"https://api.github.com/repos/msarahan/PyCMake/releases{/id}","created_at":"2014-07-12T17:22:02Z","updated_at":"2014-07-12T17:44:43Z","pushed_at":"2014-07-24T03:26:49Z","git_url":"git://github.com/msarahan/PyCMake.git","ssh_url":"git@github.com:msarahan/PyCMake.git","clone_url":"https://github.com/msarahan/PyCMake.git","svn_url":"https://github.com/msarahan/PyCMake","homepage":null,"size":480,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PyCMake:master","ref":"master","sha":"5ce37ca2f95c14a77f9d52a9c60d6970e5d46d72","user":{"login":"PyCMake","id":8144855,"avatar_url":"https://avatars.githubusercontent.com/u/8144855?v=2","gravatar_id":null,"url":"https://api.github.com/users/PyCMake","html_url":"https://github.com/PyCMake","followers_url":"https://api.github.com/users/PyCMake/followers","following_url":"https://api.github.com/users/PyCMake/following{/other_user}","gists_url":"https://api.github.com/users/PyCMake/gists{/gist_id}","starred_url":"https://api.github.com/users/PyCMake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PyCMake/subscriptions","organizations_url":"https://api.github.com/users/PyCMake/orgs","repos_url":"https://api.github.com/users/PyCMake/repos","events_url":"https://api.github.com/users/PyCMake/events{/privacy}","received_events_url":"https://api.github.com/users/PyCMake/received_events","type":"Organization","site_admin":false},"repo":{"id":21749516,"name":"PyCMake","full_name":"PyCMake/PyCMake","owner":{"login":"PyCMake","id":8144855,"avatar_url":"https://avatars.githubusercontent.com/u/8144855?v=2","gravatar_id":null,"url":"https://api.github.com/users/PyCMake","html_url":"https://github.com/PyCMake","followers_url":"https://api.github.com/users/PyCMake/followers","following_url":"https://api.github.com/users/PyCMake/following{/other_user}","gists_url":"https://api.github.com/users/PyCMake/gists{/gist_id}","starred_url":"https://api.github.com/users/PyCMake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PyCMake/subscriptions","organizations_url":"https://api.github.com/users/PyCMake/orgs","repos_url":"https://api.github.com/users/PyCMake/repos","events_url":"https://api.github.com/users/PyCMake/events{/privacy}","received_events_url":"https://api.github.com/users/PyCMake/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PyCMake/PyCMake","description":"Simplify building Python extensions with CMake","fork":false,"url":"https://api.github.com/repos/PyCMake/PyCMake","forks_url":"https://api.github.com/repos/PyCMake/PyCMake/forks","keys_url":"https://api.github.com/repos/PyCMake/PyCMake/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PyCMake/PyCMake/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PyCMake/PyCMake/teams","hooks_url":"https://api.github.com/repos/PyCMake/PyCMake/hooks","issue_events_url":"https://api.github.com/repos/PyCMake/PyCMake/issues/events{/number}","events_url":"https://api.github.com/repos/PyCMake/PyCMake/events","assignees_url":"https://api.github.com/repos/PyCMake/PyCMake/assignees{/user}","branches_url":"https://api.github.com/repos/PyCMake/PyCMake/branches{/branch}","tags_url":"https://api.github.com/repos/PyCMake/PyCMake/tags","blobs_url":"https://api.github.com/repos/PyCMake/PyCMake/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PyCMake/PyCMake/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PyCMake/PyCMake/git/refs{/sha}","trees_url":"https://api.github.com/repos/PyCMake/PyCMake/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PyCMake/PyCMake/statuses/{sha}","languages_url":"https://api.github.com/repos/PyCMake/PyCMake/languages","stargazers_url":"https://api.github.com/repos/PyCMake/PyCMake/stargazers","contributors_url":"https://api.github.com/repos/PyCMake/PyCMake/contributors","subscribers_url":"https://api.github.com/repos/PyCMake/PyCMake/subscribers","subscription_url":"https://api.github.com/repos/PyCMake/PyCMake/subscription","commits_url":"https://api.github.com/repos/PyCMake/PyCMake/commits{/sha}","git_commits_url":"https://api.github.com/repos/PyCMake/PyCMake/git/commits{/sha}","comments_url":"https://api.github.com/repos/PyCMake/PyCMake/comments{/number}","issue_comment_url":"https://api.github.com/repos/PyCMake/PyCMake/issues/comments/{number}","contents_url":"https://api.github.com/repos/PyCMake/PyCMake/contents/{+path}","compare_url":"https://api.github.com/repos/PyCMake/PyCMake/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PyCMake/PyCMake/merges","archive_url":"https://api.github.com/repos/PyCMake/PyCMake/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PyCMake/PyCMake/downloads","issues_url":"https://api.github.com/repos/PyCMake/PyCMake/issues{/number}","pulls_url":"https://api.github.com/repos/PyCMake/PyCMake/pulls{/number}","milestones_url":"https://api.github.com/repos/PyCMake/PyCMake/milestones{/number}","notifications_url":"https://api.github.com/repos/PyCMake/PyCMake/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PyCMake/PyCMake/labels{/name}","releases_url":"https://api.github.com/repos/PyCMake/PyCMake/releases{/id}","created_at":"2014-07-11T20:00:17Z","updated_at":"2014-07-15T17:16:59Z","pushed_at":"2014-07-19T03:10:41Z","git_url":"git://github.com/PyCMake/PyCMake.git","ssh_url":"git@github.com:PyCMake/PyCMake.git","clone_url":"https://github.com/PyCMake/PyCMake.git","svn_url":"https://github.com/PyCMake/PyCMake","homepage":"http://pycmake.readthedocs.org/en/latest/","size":578,"stargazers_count":10,"watchers_count":10,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":5,"mirror_url":null,"open_issues_count":2,"forks":5,"open_issues":2,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PyCMake/PyCMake/pulls/16"},"html":{"href":"https://github.com/PyCMake/PyCMake/pull/16"},"issue":{"href":"https://api.github.com/repos/PyCMake/PyCMake/issues/16"},"comments":{"href":"https://api.github.com/repos/PyCMake/PyCMake/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/PyCMake/PyCMake/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/PyCMake/PyCMake/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/PyCMake/PyCMake/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/PyCMake/PyCMake/statuses/32b3fb81aba9e10741a9a7734c3704d30be9f861"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":16,"review_comments":19,"commits":18,"additions":270,"deletions":28,"changed_files":14}}