GitHub PullRequestReviewCommentEvent at 2014-11-26 14:30:30
Repository: o-ft-buttons
Actor: AlbertoElias
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/pulls/comments/20937376","id":20937376,"diff_hunk":"@@ -2,8 +2,8 @@\n \t\"name\": \"o-ft-buttons\",\n \t\"main\": [\"main.scss\"],\n \t\"dependencies\": {\n-\t\t\"o-fonts\": \"^1.3.0\",\n-\t\t\"o-colors\": \"^2.4.0\",\n+\t\t\"o-fonts\": \"^1.4.2\",","path":"bower.json","position":6,"original_position":6,"commit_id":"df736f59a1839e2a5d7f92387b022f7eaaabf4b2","original_commit_id":"df736f59a1839e2a5d7f92387b022f7eaaabf4b2","user":{"login":"AlbertoElias","id":913117,"avatar_url":"https://avatars.githubusercontent.com/u/913117?v=3","gravatar_id":"","url":"https://api.github.com/users/AlbertoElias","html_url":"https://github.com/AlbertoElias","followers_url":"https://api.github.com/users/AlbertoElias/followers","following_url":"https://api.github.com/users/AlbertoElias/following{/other_user}","gists_url":"https://api.github.com/users/AlbertoElias/gists{/gist_id}","starred_url":"https://api.github.com/users/AlbertoElias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlbertoElias/subscriptions","organizations_url":"https://api.github.com/users/AlbertoElias/orgs","repos_url":"https://api.github.com/users/AlbertoElias/repos","events_url":"https://api.github.com/users/AlbertoElias/events{/privacy}","received_events_url":"https://api.github.com/users/AlbertoElias/received_events","type":"User","site_admin":false},"body":"It's just that semver ranges should be as wide as possible.","created_at":"2014-11-26T14:30:30Z","updated_at":"2014-11-26T14:30:30Z","html_url":"https://github.com/Financial-Times/o-ft-buttons/pull/39#discussion_r20937376","pull_request_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/pulls/39","_links":{"self":{"href":"https://api.github.com/repos/Financial-Times/o-ft-buttons/pulls/comments/20937376"},"html":{"href":"https://github.com/Financial-Times/o-ft-buttons/pull/39#discussion_r20937376"},"pull_request":{"href":"https://api.github.com/repos/Financial-Times/o-ft-buttons/pulls/39"}}},"pull_request":{"url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/pulls/39","id":25041829,"html_url":"https://github.com/Financial-Times/o-ft-buttons/pull/39","diff_url":"https://github.com/Financial-Times/o-ft-buttons/pull/39.diff","patch_url":"https://github.com/Financial-Times/o-ft-buttons/pull/39.patch","issue_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/issues/39","number":39,"state":"open","locked":false,"title":"V2 theme refactor","user":{"login":"kaelig","id":85783,"avatar_url":"https://avatars.githubusercontent.com/u/85783?v=3","gravatar_id":"","url":"https://api.github.com/users/kaelig","html_url":"https://github.com/kaelig","followers_url":"https://api.github.com/users/kaelig/followers","following_url":"https://api.github.com/users/kaelig/following{/other_user}","gists_url":"https://api.github.com/users/kaelig/gists{/gist_id}","starred_url":"https://api.github.com/users/kaelig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaelig/subscriptions","organizations_url":"https://api.github.com/users/kaelig/orgs","repos_url":"https://api.github.com/users/kaelig/repos","events_url":"https://api.github.com/users/kaelig/events{/privacy}","received_events_url":"https://api.github.com/users/kaelig/received_events","type":"User","site_admin":false},"body":"Most notable changes:\r\n\r\n- Deprecate color use cases\r\n- Add anchors to demos for better testing\r\n- Rewrite button generation pattern /cc @AlbertoElias there's less magic happening in there. Let me know what you think!\r\n\r\nThis PR also fixes many visual regressions introduced in the previous merge.\r\n\r\nIdea for a next step: improve demos to cover more cases (elements, [backgrounds](http://jsbin.com/gezize/1/edit?html,output))","created_at":"2014-11-25T21:28:15Z","updated_at":"2014-11-26T14:30:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f7b49da9ef62742ee2dc940c4b2f92ea07b6f432","assignee":{"login":"AlbertoElias","id":913117,"avatar_url":"https://avatars.githubusercontent.com/u/913117?v=3","gravatar_id":"","url":"https://api.github.com/users/AlbertoElias","html_url":"https://github.com/AlbertoElias","followers_url":"https://api.github.com/users/AlbertoElias/followers","following_url":"https://api.github.com/users/AlbertoElias/following{/other_user}","gists_url":"https://api.github.com/users/AlbertoElias/gists{/gist_id}","starred_url":"https://api.github.com/users/AlbertoElias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlbertoElias/subscriptions","organizations_url":"https://api.github.com/users/AlbertoElias/orgs","repos_url":"https://api.github.com/users/AlbertoElias/repos","events_url":"https://api.github.com/users/AlbertoElias/events{/privacy}","received_events_url":"https://api.github.com/users/AlbertoElias/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/pulls/39/commits","review_comments_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/pulls/39/comments","review_comment_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/issues/39/comments","statuses_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/statuses/df736f59a1839e2a5d7f92387b022f7eaaabf4b2","head":{"label":"Financial-Times:v2-theme-refactor","ref":"v2-theme-refactor","sha":"df736f59a1839e2a5d7f92387b022f7eaaabf4b2","user":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars.githubusercontent.com/u/3502508?v=3","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"repo":{"id":16411823,"name":"o-ft-buttons","full_name":"Financial-Times/o-ft-buttons","owner":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars.githubusercontent.com/u/3502508?v=3","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Financial-Times/o-ft-buttons","description":"Standard FT-branded buttons","fork":false,"url":"https://api.github.com/repos/Financial-Times/o-ft-buttons","forks_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/forks","keys_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/teams","hooks_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/hooks","issue_events_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/issues/events{/number}","events_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/events","assignees_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/assignees{/user}","branches_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/branches{/branch}","tags_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/tags","blobs_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/git/refs{/sha}","trees_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/statuses/{sha}","languages_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/languages","stargazers_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/stargazers","contributors_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/contributors","subscribers_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/subscribers","subscription_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/subscription","commits_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/commits{/sha}","git_commits_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/git/commits{/sha}","comments_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/comments{/number}","issue_comment_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/issues/comments/{number}","contents_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/contents/{+path}","compare_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/merges","archive_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/downloads","issues_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/issues{/number}","pulls_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/pulls{/number}","milestones_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/milestones{/number}","notifications_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/labels{/name}","releases_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/releases{/id}","created_at":"2014-01-31T15:30:19Z","updated_at":"2014-10-14T16:31:11Z","pushed_at":"2014-11-25T21:22:08Z","git_url":"git://github.com/Financial-Times/o-ft-buttons.git","ssh_url":"git@github.com:Financial-Times/o-ft-buttons.git","clone_url":"https://github.com/Financial-Times/o-ft-buttons.git","svn_url":"https://github.com/Financial-Times/o-ft-buttons","homepage":"http://registry.origami.ft.com/components/o-ft-buttons","size":899,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":17,"forks":1,"open_issues":17,"watchers":0,"default_branch":"master"}},"base":{"label":"Financial-Times:v2","ref":"v2","sha":"8ea5e7072430407c9557b7774ad1b43334b60fc4","user":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars.githubusercontent.com/u/3502508?v=3","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"repo":{"id":16411823,"name":"o-ft-buttons","full_name":"Financial-Times/o-ft-buttons","owner":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars.githubusercontent.com/u/3502508?v=3","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Financial-Times/o-ft-buttons","description":"Standard FT-branded buttons","fork":false,"url":"https://api.github.com/repos/Financial-Times/o-ft-buttons","forks_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/forks","keys_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/teams","hooks_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/hooks","issue_events_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/issues/events{/number}","events_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/events","assignees_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/assignees{/user}","branches_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/branches{/branch}","tags_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/tags","blobs_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/git/refs{/sha}","trees_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/statuses/{sha}","languages_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/languages","stargazers_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/stargazers","contributors_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/contributors","subscribers_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/subscribers","subscription_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/subscription","commits_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/commits{/sha}","git_commits_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/git/commits{/sha}","comments_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/comments{/number}","issue_comment_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/issues/comments/{number}","contents_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/contents/{+path}","compare_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/merges","archive_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/downloads","issues_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/issues{/number}","pulls_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/pulls{/number}","milestones_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/milestones{/number}","notifications_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/labels{/name}","releases_url":"https://api.github.com/repos/Financial-Times/o-ft-buttons/releases{/id}","created_at":"2014-01-31T15:30:19Z","updated_at":"2014-10-14T16:31:11Z","pushed_at":"2014-11-25T21:22:08Z","git_url":"git://github.com/Financial-Times/o-ft-buttons.git","ssh_url":"git@github.com:Financial-Times/o-ft-buttons.git","clone_url":"https://github.com/Financial-Times/o-ft-buttons.git","svn_url":"https://github.com/Financial-Times/o-ft-buttons","homepage":"http://registry.origami.ft.com/components/o-ft-buttons","size":899,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":17,"forks":1,"open_issues":17,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Financial-Times/o-ft-buttons/pulls/39"},"html":{"href":"https://github.com/Financial-Times/o-ft-buttons/pull/39"},"issue":{"href":"https://api.github.com/repos/Financial-Times/o-ft-buttons/issues/39"},"comments":{"href":"https://api.github.com/repos/Financial-Times/o-ft-buttons/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/Financial-Times/o-ft-buttons/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/Financial-Times/o-ft-buttons/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Financial-Times/o-ft-buttons/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/Financial-Times/o-ft-buttons/statuses/df736f59a1839e2a5d7f92387b022f7eaaabf4b2"}}}}