GitHub PullRequestReviewCommentEvent at 2014-11-14 01:59:11
Repository: http2-spec
Actor: martinthomson
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/http2/http2-spec/pulls/comments/20338833","id":20338833,"diff_hunk":"@@ -3687,32 +3692,34 @@ HTTP2-Settings    = token68\n             error</xref> of type <x:ref>HTTP_1_1_REQUIRED</x:ref> to request the client\r\n             use a protocol which supports renegotiation.\r\n           </t>\r\n+          <t>\r\n+            Implementations MUST support ephemeral key exchange sizes of at least 2048 bits for DHE\r\n+            cipher suites and 224 bits for ECDHE cipher suites.  Clients MUST accept DHE sizes of up\r\n+            to 4096 bits.\r","path":"draft-ietf-httpbis-http2.xml","position":57,"original_position":57,"commit_id":"8840d40812775e2219722a775ac967c0a1c17a92","original_commit_id":"8840d40812775e2219722a775ac967c0a1c17a92","user":{"login":"martinthomson","id":67641,"avatar_url":"https://avatars.githubusercontent.com/u/67641?v=3","gravatar_id":"","url":"https://api.github.com/users/martinthomson","html_url":"https://github.com/martinthomson","followers_url":"https://api.github.com/users/martinthomson/followers","following_url":"https://api.github.com/users/martinthomson/following{/other_user}","gists_url":"https://api.github.com/users/martinthomson/gists{/gist_id}","starred_url":"https://api.github.com/users/martinthomson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinthomson/subscriptions","organizations_url":"https://api.github.com/users/martinthomson/orgs","repos_url":"https://api.github.com/users/martinthomson/repos","events_url":"https://api.github.com/users/martinthomson/events{/privacy}","received_events_url":"https://api.github.com/users/martinthomson/received_events","type":"User","site_admin":false},"body":"Please make this sort of comment on the mailing list.","created_at":"2014-11-14T01:59:11Z","updated_at":"2014-11-14T01:59:11Z","html_url":"https://github.com/http2/http2-spec/pull/644#discussion_r20338833","pull_request_url":"https://api.github.com/repos/http2/http2-spec/pulls/644","_links":{"self":{"href":"https://api.github.com/repos/http2/http2-spec/pulls/comments/20338833"},"html":{"href":"https://github.com/http2/http2-spec/pull/644#discussion_r20338833"},"pull_request":{"href":"https://api.github.com/repos/http2/http2-spec/pulls/644"}}},"pull_request":{"url":"https://api.github.com/repos/http2/http2-spec/pulls/644","id":24408357,"html_url":"https://github.com/http2/http2-spec/pull/644","diff_url":"https://github.com/http2/http2-spec/pull/644.diff","patch_url":"https://github.com/http2/http2-spec/pull/644.patch","issue_url":"https://api.github.com/repos/http2/http2-spec/issues/644","number":644,"state":"open","locked":false,"title":"Move to a cipher suite blacklist (WIP)","user":{"login":"martinthomson","id":67641,"avatar_url":"https://avatars.githubusercontent.com/u/67641?v=3","gravatar_id":"","url":"https://api.github.com/users/martinthomson","html_url":"https://github.com/martinthomson","followers_url":"https://api.github.com/users/martinthomson/followers","following_url":"https://api.github.com/users/martinthomson/following{/other_user}","gists_url":"https://api.github.com/users/martinthomson/gists{/gist_id}","starred_url":"https://api.github.com/users/martinthomson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinthomson/subscriptions","organizations_url":"https://api.github.com/users/martinthomson/orgs","repos_url":"https://api.github.com/users/martinthomson/repos","events_url":"https://api.github.com/users/martinthomson/events{/privacy}","received_events_url":"https://api.github.com/users/martinthomson/received_events","type":"User","site_admin":false},"body":"This is based on the long set of negotiated changes added to #615.  This adds the blacklist as Sam Hartman proposed at IETF 91.\r\n\r\nCloses #612.","created_at":"2014-11-13T23:04:17Z","updated_at":"2014-11-14T01:59:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"95bcb153212bcb45d9ea54b137642927476dc44e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/http2/http2-spec/pulls/644/commits","review_comments_url":"https://api.github.com/repos/http2/http2-spec/pulls/644/comments","review_comment_url":"https://api.github.com/repos/http2/http2-spec/pulls/comments/{number}","comments_url":"https://api.github.com/repos/http2/http2-spec/issues/644/comments","statuses_url":"https://api.github.com/repos/http2/http2-spec/statuses/8840d40812775e2219722a775ac967c0a1c17a92","head":{"label":"http2:922sh","ref":"922sh","sha":"8840d40812775e2219722a775ac967c0a1c17a92","user":{"login":"http2","id":2078837,"avatar_url":"https://avatars.githubusercontent.com/u/2078837?v=3","gravatar_id":"","url":"https://api.github.com/users/http2","html_url":"https://github.com/http2","followers_url":"https://api.github.com/users/http2/followers","following_url":"https://api.github.com/users/http2/following{/other_user}","gists_url":"https://api.github.com/users/http2/gists{/gist_id}","starred_url":"https://api.github.com/users/http2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/http2/subscriptions","organizations_url":"https://api.github.com/users/http2/orgs","repos_url":"https://api.github.com/users/http2/repos","events_url":"https://api.github.com/users/http2/events{/privacy}","received_events_url":"https://api.github.com/users/http2/received_events","type":"Organization","site_admin":false},"repo":{"id":8062859,"name":"http2-spec","full_name":"http2/http2-spec","owner":{"login":"http2","id":2078837,"avatar_url":"https://avatars.githubusercontent.com/u/2078837?v=3","gravatar_id":"","url":"https://api.github.com/users/http2","html_url":"https://github.com/http2","followers_url":"https://api.github.com/users/http2/followers","following_url":"https://api.github.com/users/http2/following{/other_user}","gists_url":"https://api.github.com/users/http2/gists{/gist_id}","starred_url":"https://api.github.com/users/http2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/http2/subscriptions","organizations_url":"https://api.github.com/users/http2/orgs","repos_url":"https://api.github.com/users/http2/repos","events_url":"https://api.github.com/users/http2/events{/privacy}","received_events_url":"https://api.github.com/users/http2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/http2/http2-spec","description":"Working copy of the HTTP/2 Specification","fork":false,"url":"https://api.github.com/repos/http2/http2-spec","forks_url":"https://api.github.com/repos/http2/http2-spec/forks","keys_url":"https://api.github.com/repos/http2/http2-spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/http2/http2-spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/http2/http2-spec/teams","hooks_url":"https://api.github.com/repos/http2/http2-spec/hooks","issue_events_url":"https://api.github.com/repos/http2/http2-spec/issues/events{/number}","events_url":"https://api.github.com/repos/http2/http2-spec/events","assignees_url":"https://api.github.com/repos/http2/http2-spec/assignees{/user}","branches_url":"https://api.github.com/repos/http2/http2-spec/branches{/branch}","tags_url":"https://api.github.com/repos/http2/http2-spec/tags","blobs_url":"https://api.github.com/repos/http2/http2-spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/http2/http2-spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/http2/http2-spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/http2/http2-spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/http2/http2-spec/statuses/{sha}","languages_url":"https://api.github.com/repos/http2/http2-spec/languages","stargazers_url":"https://api.github.com/repos/http2/http2-spec/stargazers","contributors_url":"https://api.github.com/repos/http2/http2-spec/contributors","subscribers_url":"https://api.github.com/repos/http2/http2-spec/subscribers","subscription_url":"https://api.github.com/repos/http2/http2-spec/subscription","commits_url":"https://api.github.com/repos/http2/http2-spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/http2/http2-spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/http2/http2-spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/http2/http2-spec/issues/comments/{number}","contents_url":"https://api.github.com/repos/http2/http2-spec/contents/{+path}","compare_url":"https://api.github.com/repos/http2/http2-spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/http2/http2-spec/merges","archive_url":"https://api.github.com/repos/http2/http2-spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/http2/http2-spec/downloads","issues_url":"https://api.github.com/repos/http2/http2-spec/issues{/number}","pulls_url":"https://api.github.com/repos/http2/http2-spec/pulls{/number}","milestones_url":"https://api.github.com/repos/http2/http2-spec/milestones{/number}","notifications_url":"https://api.github.com/repos/http2/http2-spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/http2/http2-spec/labels{/name}","releases_url":"https://api.github.com/repos/http2/http2-spec/releases{/id}","created_at":"2013-02-06T23:48:45Z","updated_at":"2014-11-13T14:19:40Z","pushed_at":"2014-11-13T23:59:42Z","git_url":"git://github.com/http2/http2-spec.git","ssh_url":"git@github.com:http2/http2-spec.git","clone_url":"https://github.com/http2/http2-spec.git","svn_url":"https://github.com/http2/http2-spec","homepage":"http://http2.github.io/","size":29885,"stargazers_count":913,"watchers_count":913,"language":"XSLT","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":234,"mirror_url":null,"open_issues_count":10,"forks":234,"open_issues":10,"watchers":913,"default_branch":"master"}},"base":{"label":"http2:master","ref":"master","sha":"93b00cd12f6109579c31eab1f0212f98660a35a8","user":{"login":"http2","id":2078837,"avatar_url":"https://avatars.githubusercontent.com/u/2078837?v=3","gravatar_id":"","url":"https://api.github.com/users/http2","html_url":"https://github.com/http2","followers_url":"https://api.github.com/users/http2/followers","following_url":"https://api.github.com/users/http2/following{/other_user}","gists_url":"https://api.github.com/users/http2/gists{/gist_id}","starred_url":"https://api.github.com/users/http2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/http2/subscriptions","organizations_url":"https://api.github.com/users/http2/orgs","repos_url":"https://api.github.com/users/http2/repos","events_url":"https://api.github.com/users/http2/events{/privacy}","received_events_url":"https://api.github.com/users/http2/received_events","type":"Organization","site_admin":false},"repo":{"id":8062859,"name":"http2-spec","full_name":"http2/http2-spec","owner":{"login":"http2","id":2078837,"avatar_url":"https://avatars.githubusercontent.com/u/2078837?v=3","gravatar_id":"","url":"https://api.github.com/users/http2","html_url":"https://github.com/http2","followers_url":"https://api.github.com/users/http2/followers","following_url":"https://api.github.com/users/http2/following{/other_user}","gists_url":"https://api.github.com/users/http2/gists{/gist_id}","starred_url":"https://api.github.com/users/http2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/http2/subscriptions","organizations_url":"https://api.github.com/users/http2/orgs","repos_url":"https://api.github.com/users/http2/repos","events_url":"https://api.github.com/users/http2/events{/privacy}","received_events_url":"https://api.github.com/users/http2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/http2/http2-spec","description":"Working copy of the HTTP/2 Specification","fork":false,"url":"https://api.github.com/repos/http2/http2-spec","forks_url":"https://api.github.com/repos/http2/http2-spec/forks","keys_url":"https://api.github.com/repos/http2/http2-spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/http2/http2-spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/http2/http2-spec/teams","hooks_url":"https://api.github.com/repos/http2/http2-spec/hooks","issue_events_url":"https://api.github.com/repos/http2/http2-spec/issues/events{/number}","events_url":"https://api.github.com/repos/http2/http2-spec/events","assignees_url":"https://api.github.com/repos/http2/http2-spec/assignees{/user}","branches_url":"https://api.github.com/repos/http2/http2-spec/branches{/branch}","tags_url":"https://api.github.com/repos/http2/http2-spec/tags","blobs_url":"https://api.github.com/repos/http2/http2-spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/http2/http2-spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/http2/http2-spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/http2/http2-spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/http2/http2-spec/statuses/{sha}","languages_url":"https://api.github.com/repos/http2/http2-spec/languages","stargazers_url":"https://api.github.com/repos/http2/http2-spec/stargazers","contributors_url":"https://api.github.com/repos/http2/http2-spec/contributors","subscribers_url":"https://api.github.com/repos/http2/http2-spec/subscribers","subscription_url":"https://api.github.com/repos/http2/http2-spec/subscription","commits_url":"https://api.github.com/repos/http2/http2-spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/http2/http2-spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/http2/http2-spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/http2/http2-spec/issues/comments/{number}","contents_url":"https://api.github.com/repos/http2/http2-spec/contents/{+path}","compare_url":"https://api.github.com/repos/http2/http2-spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/http2/http2-spec/merges","archive_url":"https://api.github.com/repos/http2/http2-spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/http2/http2-spec/downloads","issues_url":"https://api.github.com/repos/http2/http2-spec/issues{/number}","pulls_url":"https://api.github.com/repos/http2/http2-spec/pulls{/number}","milestones_url":"https://api.github.com/repos/http2/http2-spec/milestones{/number}","notifications_url":"https://api.github.com/repos/http2/http2-spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/http2/http2-spec/labels{/name}","releases_url":"https://api.github.com/repos/http2/http2-spec/releases{/id}","created_at":"2013-02-06T23:48:45Z","updated_at":"2014-11-13T14:19:40Z","pushed_at":"2014-11-13T23:59:42Z","git_url":"git://github.com/http2/http2-spec.git","ssh_url":"git@github.com:http2/http2-spec.git","clone_url":"https://github.com/http2/http2-spec.git","svn_url":"https://github.com/http2/http2-spec","homepage":"http://http2.github.io/","size":29885,"stargazers_count":913,"watchers_count":913,"language":"XSLT","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":234,"mirror_url":null,"open_issues_count":10,"forks":234,"open_issues":10,"watchers":913,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/http2/http2-spec/pulls/644"},"html":{"href":"https://github.com/http2/http2-spec/pull/644"},"issue":{"href":"https://api.github.com/repos/http2/http2-spec/issues/644"},"comments":{"href":"https://api.github.com/repos/http2/http2-spec/issues/644/comments"},"review_comments":{"href":"https://api.github.com/repos/http2/http2-spec/pulls/644/comments"},"review_comment":{"href":"https://api.github.com/repos/http2/http2-spec/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/http2/http2-spec/pulls/644/commits"},"statuses":{"href":"https://api.github.com/repos/http2/http2-spec/statuses/8840d40812775e2219722a775ac967c0a1c17a92"}}}}