GitHub PullRequestReviewCommentEvent at 2014-08-16 20:13:44
Repository: tabs
Actor: johntyree
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/enthought/tabs/pulls/comments/16326498","id":16326498,"diff_hunk":"@@ -134,10 +137,29 @@ function getDataSnapshot(points, velocityVectors) {\n         var dlat = velocityVectors.v[i] * scale;\n         var dlon = velocityVectors.u[i] * scale;\n         var endpoint = [points[i][0] + dlat, points[i][1] + dlon];\n-        var tail = make_tail(points[i], endpoint);\n-        // This draws the arrow shaft twice but felt noticeably faster than\n-        // drawing the shaft and tail separately\n-        var arrow = [tail[0], points[i], endpoint, points[i], tail[1]];\n+        switch (barbLocation) {","path":"frontend/js/vector.js","position":18,"original_position":18,"commit_id":"2be5e014ab17c086f29546797113774a2a5b77fb","original_commit_id":"2be5e014ab17c086f29546797113774a2a5b77fb","user":{"login":"johntyree","id":108972,"avatar_url":"https://avatars.githubusercontent.com/u/108972?v=2","gravatar_id":"38b2c9583c4c21e1c1cd5c887cf04c18","url":"https://api.github.com/users/johntyree","html_url":"https://github.com/johntyree","followers_url":"https://api.github.com/users/johntyree/followers","following_url":"https://api.github.com/users/johntyree/following{/other_user}","gists_url":"https://api.github.com/users/johntyree/gists{/gist_id}","starred_url":"https://api.github.com/users/johntyree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johntyree/subscriptions","organizations_url":"https://api.github.com/users/johntyree/orgs","repos_url":"https://api.github.com/users/johntyree/repos","events_url":"https://api.github.com/users/johntyree/events{/privacy}","received_events_url":"https://api.github.com/users/johntyree/received_events","type":"User","site_admin":false},"body":"Yeah I'll go ahead and do that.","created_at":"2014-08-16T20:13:44Z","updated_at":"2014-08-16T20:13:44Z","html_url":"https://github.com/enthought/tabs/pull/24#discussion_r16326498","pull_request_url":"https://api.github.com/repos/enthought/tabs/pulls/24","_links":{"self":{"href":"https://api.github.com/repos/enthought/tabs/pulls/comments/16326498"},"html":{"href":"https://github.com/enthought/tabs/pull/24#discussion_r16326498"},"pull_request":{"href":"https://api.github.com/repos/enthought/tabs/pulls/24"}}},"pull_request":{"url":"https://api.github.com/repos/enthought/tabs/pulls/24","id":19875028,"html_url":"https://github.com/enthought/tabs/pull/24","diff_url":"https://github.com/enthought/tabs/pull/24.diff","patch_url":"https://github.com/enthought/tabs/pull/24.patch","issue_url":"https://api.github.com/repos/enthought/tabs/issues/24","number":24,"state":"open","locked":false,"title":"Add adjustable arrow barb location","user":{"login":"johntyree","id":108972,"avatar_url":"https://avatars.githubusercontent.com/u/108972?v=2","gravatar_id":"38b2c9583c4c21e1c1cd5c887cf04c18","url":"https://api.github.com/users/johntyree","html_url":"https://github.com/johntyree","followers_url":"https://api.github.com/users/johntyree/followers","following_url":"https://api.github.com/users/johntyree/following{/other_user}","gists_url":"https://api.github.com/users/johntyree/gists{/gist_id}","starred_url":"https://api.github.com/users/johntyree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johntyree/subscriptions","organizations_url":"https://api.github.com/users/johntyree/orgs","repos_url":"https://api.github.com/users/johntyree/repos","events_url":"https://api.github.com/users/johntyree/events{/privacy}","received_events_url":"https://api.github.com/users/johntyree/received_events","type":"User","site_admin":false},"body":"We are dancing right on the edge of \"noticeably slower.\" We have to be careful about the barb is actually drawn. This way seemed to perform the best and look the least ridiculous.","created_at":"2014-08-16T01:04:22Z","updated_at":"2014-08-16T20:13:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9f976c27f1738fec81e48b54e9ac759023d62a8e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/enthought/tabs/pulls/24/commits","review_comments_url":"https://api.github.com/repos/enthought/tabs/pulls/24/comments","review_comment_url":"https://api.github.com/repos/enthought/tabs/pulls/comments/{number}","comments_url":"https://api.github.com/repos/enthought/tabs/issues/24/comments","statuses_url":"https://api.github.com/repos/enthought/tabs/statuses/2be5e014ab17c086f29546797113774a2a5b77fb","head":{"label":"enthought:enh/barb-location","ref":"enh/barb-location","sha":"2be5e014ab17c086f29546797113774a2a5b77fb","user":{"login":"enthought","id":539651,"avatar_url":"https://avatars.githubusercontent.com/u/539651?v=2","gravatar_id":"75fa7fb6cbe4892834aa36de4720282a","url":"https://api.github.com/users/enthought","html_url":"https://github.com/enthought","followers_url":"https://api.github.com/users/enthought/followers","following_url":"https://api.github.com/users/enthought/following{/other_user}","gists_url":"https://api.github.com/users/enthought/gists{/gist_id}","starred_url":"https://api.github.com/users/enthought/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enthought/subscriptions","organizations_url":"https://api.github.com/users/enthought/orgs","repos_url":"https://api.github.com/users/enthought/repos","events_url":"https://api.github.com/users/enthought/events{/privacy}","received_events_url":"https://api.github.com/users/enthought/received_events","type":"Organization","site_admin":false},"repo":{"id":22770204,"name":"tabs","full_name":"enthought/tabs","owner":{"login":"enthought","id":539651,"avatar_url":"https://avatars.githubusercontent.com/u/539651?v=2","gravatar_id":"75fa7fb6cbe4892834aa36de4720282a","url":"https://api.github.com/users/enthought","html_url":"https://github.com/enthought","followers_url":"https://api.github.com/users/enthought/followers","following_url":"https://api.github.com/users/enthought/following{/other_user}","gists_url":"https://api.github.com/users/enthought/gists{/gist_id}","starred_url":"https://api.github.com/users/enthought/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enthought/subscriptions","organizations_url":"https://api.github.com/users/enthought/orgs","repos_url":"https://api.github.com/users/enthought/repos","events_url":"https://api.github.com/users/enthought/events{/privacy}","received_events_url":"https://api.github.com/users/enthought/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/enthought/tabs","description":"TAMU TABS project","fork":false,"url":"https://api.github.com/repos/enthought/tabs","forks_url":"https://api.github.com/repos/enthought/tabs/forks","keys_url":"https://api.github.com/repos/enthought/tabs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enthought/tabs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enthought/tabs/teams","hooks_url":"https://api.github.com/repos/enthought/tabs/hooks","issue_events_url":"https://api.github.com/repos/enthought/tabs/issues/events{/number}","events_url":"https://api.github.com/repos/enthought/tabs/events","assignees_url":"https://api.github.com/repos/enthought/tabs/assignees{/user}","branches_url":"https://api.github.com/repos/enthought/tabs/branches{/branch}","tags_url":"https://api.github.com/repos/enthought/tabs/tags","blobs_url":"https://api.github.com/repos/enthought/tabs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enthought/tabs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enthought/tabs/git/refs{/sha}","trees_url":"https://api.github.com/repos/enthought/tabs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enthought/tabs/statuses/{sha}","languages_url":"https://api.github.com/repos/enthought/tabs/languages","stargazers_url":"https://api.github.com/repos/enthought/tabs/stargazers","contributors_url":"https://api.github.com/repos/enthought/tabs/contributors","subscribers_url":"https://api.github.com/repos/enthought/tabs/subscribers","subscription_url":"https://api.github.com/repos/enthought/tabs/subscription","commits_url":"https://api.github.com/repos/enthought/tabs/commits{/sha}","git_commits_url":"https://api.github.com/repos/enthought/tabs/git/commits{/sha}","comments_url":"https://api.github.com/repos/enthought/tabs/comments{/number}","issue_comment_url":"https://api.github.com/repos/enthought/tabs/issues/comments/{number}","contents_url":"https://api.github.com/repos/enthought/tabs/contents/{+path}","compare_url":"https://api.github.com/repos/enthought/tabs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enthought/tabs/merges","archive_url":"https://api.github.com/repos/enthought/tabs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enthought/tabs/downloads","issues_url":"https://api.github.com/repos/enthought/tabs/issues{/number}","pulls_url":"https://api.github.com/repos/enthought/tabs/pulls{/number}","milestones_url":"https://api.github.com/repos/enthought/tabs/milestones{/number}","notifications_url":"https://api.github.com/repos/enthought/tabs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enthought/tabs/labels{/name}","releases_url":"https://api.github.com/repos/enthought/tabs/releases{/id}","created_at":"2014-08-08T20:12:50Z","updated_at":"2014-08-08T20:24:04Z","pushed_at":"2014-08-16T20:10:55Z","git_url":"git://github.com/enthought/tabs.git","ssh_url":"git@github.com:enthought/tabs.git","clone_url":"https://github.com/enthought/tabs.git","svn_url":"https://github.com/enthought/tabs","homepage":null,"size":4048,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"base":{"label":"enthought:master","ref":"master","sha":"817508532212141288a43ffbab453cc1e6be32a2","user":{"login":"enthought","id":539651,"avatar_url":"https://avatars.githubusercontent.com/u/539651?v=2","gravatar_id":"75fa7fb6cbe4892834aa36de4720282a","url":"https://api.github.com/users/enthought","html_url":"https://github.com/enthought","followers_url":"https://api.github.com/users/enthought/followers","following_url":"https://api.github.com/users/enthought/following{/other_user}","gists_url":"https://api.github.com/users/enthought/gists{/gist_id}","starred_url":"https://api.github.com/users/enthought/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enthought/subscriptions","organizations_url":"https://api.github.com/users/enthought/orgs","repos_url":"https://api.github.com/users/enthought/repos","events_url":"https://api.github.com/users/enthought/events{/privacy}","received_events_url":"https://api.github.com/users/enthought/received_events","type":"Organization","site_admin":false},"repo":{"id":22770204,"name":"tabs","full_name":"enthought/tabs","owner":{"login":"enthought","id":539651,"avatar_url":"https://avatars.githubusercontent.com/u/539651?v=2","gravatar_id":"75fa7fb6cbe4892834aa36de4720282a","url":"https://api.github.com/users/enthought","html_url":"https://github.com/enthought","followers_url":"https://api.github.com/users/enthought/followers","following_url":"https://api.github.com/users/enthought/following{/other_user}","gists_url":"https://api.github.com/users/enthought/gists{/gist_id}","starred_url":"https://api.github.com/users/enthought/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enthought/subscriptions","organizations_url":"https://api.github.com/users/enthought/orgs","repos_url":"https://api.github.com/users/enthought/repos","events_url":"https://api.github.com/users/enthought/events{/privacy}","received_events_url":"https://api.github.com/users/enthought/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/enthought/tabs","description":"TAMU TABS project","fork":false,"url":"https://api.github.com/repos/enthought/tabs","forks_url":"https://api.github.com/repos/enthought/tabs/forks","keys_url":"https://api.github.com/repos/enthought/tabs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enthought/tabs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enthought/tabs/teams","hooks_url":"https://api.github.com/repos/enthought/tabs/hooks","issue_events_url":"https://api.github.com/repos/enthought/tabs/issues/events{/number}","events_url":"https://api.github.com/repos/enthought/tabs/events","assignees_url":"https://api.github.com/repos/enthought/tabs/assignees{/user}","branches_url":"https://api.github.com/repos/enthought/tabs/branches{/branch}","tags_url":"https://api.github.com/repos/enthought/tabs/tags","blobs_url":"https://api.github.com/repos/enthought/tabs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enthought/tabs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enthought/tabs/git/refs{/sha}","trees_url":"https://api.github.com/repos/enthought/tabs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enthought/tabs/statuses/{sha}","languages_url":"https://api.github.com/repos/enthought/tabs/languages","stargazers_url":"https://api.github.com/repos/enthought/tabs/stargazers","contributors_url":"https://api.github.com/repos/enthought/tabs/contributors","subscribers_url":"https://api.github.com/repos/enthought/tabs/subscribers","subscription_url":"https://api.github.com/repos/enthought/tabs/subscription","commits_url":"https://api.github.com/repos/enthought/tabs/commits{/sha}","git_commits_url":"https://api.github.com/repos/enthought/tabs/git/commits{/sha}","comments_url":"https://api.github.com/repos/enthought/tabs/comments{/number}","issue_comment_url":"https://api.github.com/repos/enthought/tabs/issues/comments/{number}","contents_url":"https://api.github.com/repos/enthought/tabs/contents/{+path}","compare_url":"https://api.github.com/repos/enthought/tabs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enthought/tabs/merges","archive_url":"https://api.github.com/repos/enthought/tabs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enthought/tabs/downloads","issues_url":"https://api.github.com/repos/enthought/tabs/issues{/number}","pulls_url":"https://api.github.com/repos/enthought/tabs/pulls{/number}","milestones_url":"https://api.github.com/repos/enthought/tabs/milestones{/number}","notifications_url":"https://api.github.com/repos/enthought/tabs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enthought/tabs/labels{/name}","releases_url":"https://api.github.com/repos/enthought/tabs/releases{/id}","created_at":"2014-08-08T20:12:50Z","updated_at":"2014-08-08T20:24:04Z","pushed_at":"2014-08-16T20:10:55Z","git_url":"git://github.com/enthought/tabs.git","ssh_url":"git@github.com:enthought/tabs.git","clone_url":"https://github.com/enthought/tabs.git","svn_url":"https://github.com/enthought/tabs","homepage":null,"size":4048,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/enthought/tabs/pulls/24"},"html":{"href":"https://github.com/enthought/tabs/pull/24"},"issue":{"href":"https://api.github.com/repos/enthought/tabs/issues/24"},"comments":{"href":"https://api.github.com/repos/enthought/tabs/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/enthought/tabs/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/enthought/tabs/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/enthought/tabs/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/enthought/tabs/statuses/2be5e014ab17c086f29546797113774a2a5b77fb"}}}}