GitHub PullRequestEvent at 2014-07-26 04:58:02
Repository: smil-in-javascript
Actor: ewilligers
Payload: {"action":"closed","number":23,"pull_request":{"url":"https://api.github.com/repos/smil-in-javascript/smil-in-javascript/pulls/23","id":18928629,"html_url":"https://github.com/smil-in-javascript/smil-in-javascript/pull/23","diff_url":"https://github.com/smil-in-javascript/smil-in-javascript/pull/23.diff","patch_url":"https://github.com/smil-in-javascript/smil-in-javascript/pull/23.patch","issue_url":"https://api.github.com/repos/smil-in-javascript/smil-in-javascript/issues/23","number":23,"state":"closed","title":"Automated test for lists of begin, end times","user":{"login":"ewilligers","id":929206,"avatar_url":"https://avatars.githubusercontent.com/u/929206?","gravatar_id":"b3a2c389ef8422f5599f7c7da8401748","url":"https://api.github.com/users/ewilligers","html_url":"https://github.com/ewilligers","followers_url":"https://api.github.com/users/ewilligers/followers","following_url":"https://api.github.com/users/ewilligers/following{/other_user}","gists_url":"https://api.github.com/users/ewilligers/gists{/gist_id}","starred_url":"https://api.github.com/users/ewilligers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewilligers/subscriptions","organizations_url":"https://api.github.com/users/ewilligers/orgs","repos_url":"https://api.github.com/users/ewilligers/repos","events_url":"https://api.github.com/users/ewilligers/events{/privacy}","received_events_url":"https://api.github.com/users/ewilligers/received_events","type":"User","site_admin":false},"body":"We were calling _pauseAnimationsForTesting but that changes the players - in particular, it changes their start time. We now fix the animation clock at a particular time, without modifying the players.\r\n\r\nWhen an animations ends, we were not handling the 'freeze' attribute correctly - we were letting every animation freeze at the values from the time the animation ended.","created_at":"2014-07-26T04:57:56Z","updated_at":"2014-07-26T04:58:01Z","closed_at":"2014-07-26T04:58:01Z","merged_at":"2014-07-26T04:58:01Z","merge_commit_sha":"c3265cd17766806cf6f2025b5ccbf300e12b0ae5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/smil-in-javascript/smil-in-javascript/pulls/23/commits","review_comments_url":"https://api.github.com/repos/smil-in-javascript/smil-in-javascript/pulls/23/comments","review_comment_url":"https://api.github.com/repos/smil-in-javascript/smil-in-javascript/pulls/comments/{number}","comments_url":"https://api.github.com/repos/smil-in-javascript/smil-in-javascript/issues/23/comments","statuses_url":"https://api.github.com/repos/smil-in-javascript/smil-in-javascript/statuses/e7594da962d1b99ed2cde32e8250f8135ff51a6f","head":{"label":"ewilligers:test-begin-end-list","ref":"test-begin-end-list","sha":"e7594da962d1b99ed2cde32e8250f8135ff51a6f","user":{"login":"ewilligers","id":929206,"avatar_url":"https://avatars.githubusercontent.com/u/929206?","gravatar_id":"b3a2c389ef8422f5599f7c7da8401748","url":"https://api.github.com/users/ewilligers","html_url":"https://github.com/ewilligers","followers_url":"https://api.github.com/users/ewilligers/followers","following_url":"https://api.github.com/users/ewilligers/following{/other_user}","gists_url":"https://api.github.com/users/ewilligers/gists{/gist_id}","starred_url":"https://api.github.com/users/ewilligers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewilligers/subscriptions","organizations_url":"https://api.github.com/users/ewilligers/orgs","repos_url":"https://api.github.com/users/ewilligers/repos","events_url":"https://api.github.com/users/ewilligers/events{/privacy}","received_events_url":"https://api.github.com/users/ewilligers/received_events","type":"User","site_admin":false},"repo":{"id":21556784,"name":"smil-in-javascript","full_name":"ewilligers/smil-in-javascript","owner":{"login":"ewilligers","id":929206,"avatar_url":"https://avatars.githubusercontent.com/u/929206?","gravatar_id":"b3a2c389ef8422f5599f7c7da8401748","url":"https://api.github.com/users/ewilligers","html_url":"https://github.com/ewilligers","followers_url":"https://api.github.com/users/ewilligers/followers","following_url":"https://api.github.com/users/ewilligers/following{/other_user}","gists_url":"https://api.github.com/users/ewilligers/gists{/gist_id}","starred_url":"https://api.github.com/users/ewilligers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewilligers/subscriptions","organizations_url":"https://api.github.com/users/ewilligers/orgs","repos_url":"https://api.github.com/users/ewilligers/repos","events_url":"https://api.github.com/users/ewilligers/events{/privacy}","received_events_url":"https://api.github.com/users/ewilligers/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ewilligers/smil-in-javascript","description":"Implement SVG SMIL animations using JavaScript","fork":true,"url":"https://api.github.com/repos/ewilligers/smil-in-javascript","forks_url":"https://api.github.com/repos/ewilligers/smil-in-javascript/forks","keys_url":"https://api.github.com/repos/ewilligers/smil-in-javascript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ewilligers/smil-in-javascript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ewilligers/smil-in-javascript/teams","hooks_url":"https://api.github.com/repos/ewilligers/smil-in-javascript/hooks","issue_events_url":"https://api.github.com/repos/ewilligers/smil-in-javascript/issues/events{/number}","events_url":"https://api.github.com/repos/ewilligers/smil-in-javascript/events","assignees_url":"https://api.github.com/repos/ewilligers/smil-in-javascript/assignees{/user}","branches_url":"https://api.github.com/repos/ewilligers/smil-in-javascript/branches{/branch}","tags_url":"https://api.github.com/repos/ewilligers/smil-in-javascript/tags","blobs_url":"https://api.github.com/repos/ewilligers/smil-in-javascript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ewilligers/smil-in-javascript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ewilligers/smil-in-javascript/git/refs{/sha}","trees_url":"https://api.github.com/repos/ewilligers/smil-in-javascript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ewilligers/smil-in-javascript/statuses/{sha}","languages_url":"https://api.github.com/repos/ewilligers/smil-in-javascript/languages","stargazers_url":"https://api.github.com/repos/ewilligers/smil-in-javascript/stargazers","contributors_url":"https://api.github.com/repos/ewilligers/smil-in-javascript/contributors","subscribers_url":"https://api.github.com/repos/ewilligers/smil-in-javascript/subscribers","subscription_url":"https://api.github.com/repos/ewilligers/smil-in-javascript/subscription","commits_url":"https://api.github.com/repos/ewilligers/smil-in-javascript/commits{/sha}","git_commits_url":"https://api.github.com/repos/ewilligers/smil-in-javascript/git/commits{/sha}","comments_url":"https://api.github.com/repos/ewilligers/smil-in-javascript/comments{/number}","issue_comment_url":"https://api.github.com/repos/ewilligers/smil-in-javascript/issues/comments/{number}","contents_url":"https://api.github.com/repos/ewilligers/smil-in-javascript/contents/{+path}","compare_url":"https://api.github.com/repos/ewilligers/smil-in-javascript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ewilligers/smil-in-javascript/merges","archive_url":"https://api.github.com/repos/ewilligers/smil-in-javascript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ewilligers/smil-in-javascript/downloads","issues_url":"https://api.github.com/repos/ewilligers/smil-in-javascript/issues{/number}","pulls_url":"https://api.github.com/repos/ewilligers/smil-in-javascript/pulls{/number}","milestones_url":"https://api.github.com/repos/ewilligers/smil-in-javascript/milestones{/number}","notifications_url":"https://api.github.com/repos/ewilligers/smil-in-javascript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ewilligers/smil-in-javascript/labels{/name}","releases_url":"https://api.github.com/repos/ewilligers/smil-in-javascript/releases{/id}","created_at":"2014-07-07T04:33:34Z","updated_at":"2014-07-16T01:08:31Z","pushed_at":"2014-07-26T04:56:32Z","git_url":"git://github.com/ewilligers/smil-in-javascript.git","ssh_url":"git@github.com:ewilligers/smil-in-javascript.git","clone_url":"https://github.com/ewilligers/smil-in-javascript.git","svn_url":"https://github.com/ewilligers/smil-in-javascript","homepage":null,"size":433,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"smil-in-javascript:master","ref":"master","sha":"941d3306175a483396393de9eb0e101664f97290","user":{"login":"smil-in-javascript","id":7981210,"avatar_url":"https://avatars.githubusercontent.com/u/7981210?","gravatar_id":"7cb7bba8eb6ef7185c52a8ebbe731ced","url":"https://api.github.com/users/smil-in-javascript","html_url":"https://github.com/smil-in-javascript","followers_url":"https://api.github.com/users/smil-in-javascript/followers","following_url":"https://api.github.com/users/smil-in-javascript/following{/other_user}","gists_url":"https://api.github.com/users/smil-in-javascript/gists{/gist_id}","starred_url":"https://api.github.com/users/smil-in-javascript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smil-in-javascript/subscriptions","organizations_url":"https://api.github.com/users/smil-in-javascript/orgs","repos_url":"https://api.github.com/users/smil-in-javascript/repos","events_url":"https://api.github.com/users/smil-in-javascript/events{/privacy}","received_events_url":"https://api.github.com/users/smil-in-javascript/received_events","type":"User","site_admin":false},"repo":{"id":21556639,"name":"smil-in-javascript","full_name":"smil-in-javascript/smil-in-javascript","owner":{"login":"smil-in-javascript","id":7981210,"avatar_url":"https://avatars.githubusercontent.com/u/7981210?","gravatar_id":"7cb7bba8eb6ef7185c52a8ebbe731ced","url":"https://api.github.com/users/smil-in-javascript","html_url":"https://github.com/smil-in-javascript","followers_url":"https://api.github.com/users/smil-in-javascript/followers","following_url":"https://api.github.com/users/smil-in-javascript/following{/other_user}","gists_url":"https://api.github.com/users/smil-in-javascript/gists{/gist_id}","starred_url":"https://api.github.com/users/smil-in-javascript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smil-in-javascript/subscriptions","organizations_url":"https://api.github.com/users/smil-in-javascript/orgs","repos_url":"https://api.github.com/users/smil-in-javascript/repos","events_url":"https://api.github.com/users/smil-in-javascript/events{/privacy}","received_events_url":"https://api.github.com/users/smil-in-javascript/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/smil-in-javascript/smil-in-javascript","description":"Implement SVG SMIL animations using JavaScript","fork":false,"url":"https://api.github.com/repos/smil-in-javascript/smil-in-javascript","forks_url":"https://api.github.com/repos/smil-in-javascript/smil-in-javascript/forks","keys_url":"https://api.github.com/repos/smil-in-javascript/smil-in-javascript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smil-in-javascript/smil-in-javascript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smil-in-javascript/smil-in-javascript/teams","hooks_url":"https://api.github.com/repos/smil-in-javascript/smil-in-javascript/hooks","issue_events_url":"https://api.github.com/repos/smil-in-javascript/smil-in-javascript/issues/events{/number}","events_url":"https://api.github.com/repos/smil-in-javascript/smil-in-javascript/events","assignees_url":"https://api.github.com/repos/smil-in-javascript/smil-in-javascript/assignees{/user}","branches_url":"https://api.github.com/repos/smil-in-javascript/smil-in-javascript/branches{/branch}","tags_url":"https://api.github.com/repos/smil-in-javascript/smil-in-javascript/tags","blobs_url":"https://api.github.com/repos/smil-in-javascript/smil-in-javascript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smil-in-javascript/smil-in-javascript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smil-in-javascript/smil-in-javascript/git/refs{/sha}","trees_url":"https://api.github.com/repos/smil-in-javascript/smil-in-javascript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smil-in-javascript/smil-in-javascript/statuses/{sha}","languages_url":"https://api.github.com/repos/smil-in-javascript/smil-in-javascript/languages","stargazers_url":"https://api.github.com/repos/smil-in-javascript/smil-in-javascript/stargazers","contributors_url":"https://api.github.com/repos/smil-in-javascript/smil-in-javascript/contributors","subscribers_url":"https://api.github.com/repos/smil-in-javascript/smil-in-javascript/subscribers","subscription_url":"https://api.github.com/repos/smil-in-javascript/smil-in-javascript/subscription","commits_url":"https://api.github.com/repos/smil-in-javascript/smil-in-javascript/commits{/sha}","git_commits_url":"https://api.github.com/repos/smil-in-javascript/smil-in-javascript/git/commits{/sha}","comments_url":"https://api.github.com/repos/smil-in-javascript/smil-in-javascript/comments{/number}","issue_comment_url":"https://api.github.com/repos/smil-in-javascript/smil-in-javascript/issues/comments/{number}","contents_url":"https://api.github.com/repos/smil-in-javascript/smil-in-javascript/contents/{+path}","compare_url":"https://api.github.com/repos/smil-in-javascript/smil-in-javascript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smil-in-javascript/smil-in-javascript/merges","archive_url":"https://api.github.com/repos/smil-in-javascript/smil-in-javascript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smil-in-javascript/smil-in-javascript/downloads","issues_url":"https://api.github.com/repos/smil-in-javascript/smil-in-javascript/issues{/number}","pulls_url":"https://api.github.com/repos/smil-in-javascript/smil-in-javascript/pulls{/number}","milestones_url":"https://api.github.com/repos/smil-in-javascript/smil-in-javascript/milestones{/number}","notifications_url":"https://api.github.com/repos/smil-in-javascript/smil-in-javascript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smil-in-javascript/smil-in-javascript/labels{/name}","releases_url":"https://api.github.com/repos/smil-in-javascript/smil-in-javascript/releases{/id}","created_at":"2014-07-07T04:23:45Z","updated_at":"2014-07-07T05:04:54Z","pushed_at":"2014-07-26T04:58:01Z","git_url":"git://github.com/smil-in-javascript/smil-in-javascript.git","ssh_url":"git@github.com:smil-in-javascript/smil-in-javascript.git","clone_url":"https://github.com/smil-in-javascript/smil-in-javascript.git","svn_url":"https://github.com/smil-in-javascript/smil-in-javascript","homepage":null,"size":572,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/smil-in-javascript/smil-in-javascript/pulls/23"},"html":{"href":"https://github.com/smil-in-javascript/smil-in-javascript/pull/23"},"issue":{"href":"https://api.github.com/repos/smil-in-javascript/smil-in-javascript/issues/23"},"comments":{"href":"https://api.github.com/repos/smil-in-javascript/smil-in-javascript/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/smil-in-javascript/smil-in-javascript/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/smil-in-javascript/smil-in-javascript/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/smil-in-javascript/smil-in-javascript/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/smil-in-javascript/smil-in-javascript/statuses/e7594da962d1b99ed2cde32e8250f8135ff51a6f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"ewilligers","id":929206,"avatar_url":"https://avatars.githubusercontent.com/u/929206?","gravatar_id":"b3a2c389ef8422f5599f7c7da8401748","url":"https://api.github.com/users/ewilligers","html_url":"https://github.com/ewilligers","followers_url":"https://api.github.com/users/ewilligers/followers","following_url":"https://api.github.com/users/ewilligers/following{/other_user}","gists_url":"https://api.github.com/users/ewilligers/gists{/gist_id}","starred_url":"https://api.github.com/users/ewilligers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewilligers/subscriptions","organizations_url":"https://api.github.com/users/ewilligers/orgs","repos_url":"https://api.github.com/users/ewilligers/repos","events_url":"https://api.github.com/users/ewilligers/events{/privacy}","received_events_url":"https://api.github.com/users/ewilligers/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":64,"deletions":23,"changed_files":5}}