GitHub PullRequestReviewCommentEvent at 2014-05-09 18:12:10
Repository: catarse
Actor: diogob
Payload: {"comment":{"url":"https://api.github.com/repos/catarse/catarse/pulls/comments/12488562","id":12488562,"diff_hunk":"@@ -41,6 +46,27 @@ App.addChild('MixPanel', {\n     }\n   },\n \n+  trackFacebookShare: function(event) {\n+    if(window.mixpanel) {\n+      target = event.currentTarget;\n+      self.track('FB Share for project', { ref: $(target).data('title') })\n+    }\n+  },\n+\n+  trackOnFacebookLike: function() {\n+    FB.Event.subscribe('edge.create', function(url, html_element){\n+      self.trackLike('FB Like for project', html_element)","path":"app/assets/javascripts/app/mix_panel.js","position":56,"original_position":56,"commit_id":"c9728507997bb8a62d2837725672f6f66e4921a5","original_commit_id":"c9728507997bb8a62d2837725672f6f66e4921a5","user":{"login":"diogob","id":20662,"avatar_url":"https://avatars.githubusercontent.com/u/20662?","gravatar_id":"5e2a237dafbc45f79428fdda9c5024b1","url":"https://api.github.com/users/diogob","html_url":"https://github.com/diogob","followers_url":"https://api.github.com/users/diogob/followers","following_url":"https://api.github.com/users/diogob/following{/other_user}","gists_url":"https://api.github.com/users/diogob/gists{/gist_id}","starred_url":"https://api.github.com/users/diogob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diogob/subscriptions","organizations_url":"https://api.github.com/users/diogob/orgs","repos_url":"https://api.github.com/users/diogob/repos","events_url":"https://api.github.com/users/diogob/events{/privacy}","received_events_url":"https://api.github.com/users/diogob/received_events","type":"User","site_admin":false},"body":"If the tests are passing and this code is being execute is because self is global. It should not be.","created_at":"2014-05-09T18:12:10Z","updated_at":"2014-05-09T18:12:10Z","html_url":"https://github.com/catarse/catarse/pull/658#discussion_r12488562","pull_request_url":"https://api.github.com/repos/catarse/catarse/pulls/658","_links":{"self":{"href":"https://api.github.com/repos/catarse/catarse/pulls/comments/12488562"},"html":{"href":"https://github.com/catarse/catarse/pull/658#discussion_r12488562"},"pull_request":{"href":"https://api.github.com/repos/catarse/catarse/pulls/658"}}}}