GitHub PullRequestReviewCommentEvent at 2014-02-12 17:46:59
Repository: vcloud-core
Actor: annashipman
Payload: {"comment":{"url":"https://api.github.com/repos/alphagov/vcloud-core/pulls/comments/9677503","id":9677503,"diff_hunk":"@@ -55,6 +55,21 @@ def name\n         vcloud_attributes[:name]\n       end\n \n+      def interfaces\n+        gateway_config = vcloud_attributes\n+        return [] unless gateway_config[:Configuration][:GatewayInterfaces]\n+        return [] unless vcloud_interfaces = gateway_config[:Configuration][:GatewayInterfaces][:GatewayInterface]\n+        vcloud_interfaces.map do |vcloud_interface|\n+          our_interface = {}","path":"lib/vcloud/core/edge_gateway.rb","position":9,"original_position":9,"commit_id":"a3c12e0792652a547a6d343afec1cb494ee14b6b","original_commit_id":"a3c12e0792652a547a6d343afec1cb494ee14b6b","user":{"login":"annashipman","id":719118,"avatar_url":"https://gravatar.com/avatar/02ee13bc758d7c64e177bcc4099c2976?d=https%3A%2F%2Fidenticons.github.com%2F7f31227c01698250c2055b05a9f31d10.png&r=x","gravatar_id":"02ee13bc758d7c64e177bcc4099c2976","url":"https://api.github.com/users/annashipman","html_url":"https://github.com/annashipman","followers_url":"https://api.github.com/users/annashipman/followers","following_url":"https://api.github.com/users/annashipman/following{/other_user}","gists_url":"https://api.github.com/users/annashipman/gists{/gist_id}","starred_url":"https://api.github.com/users/annashipman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/annashipman/subscriptions","organizations_url":"https://api.github.com/users/annashipman/orgs","repos_url":"https://api.github.com/users/annashipman/repos","events_url":"https://api.github.com/users/annashipman/events{/privacy}","received_events_url":"https://api.github.com/users/annashipman/received_events","type":"User","site_admin":false},"body":"Ah OK - that wasn't clear to me. Thanks for the explanation. Ideally that would be clear from the code, too. Let's look at this tomorrow.","created_at":"2014-02-12T17:46:59Z","updated_at":"2014-02-12T17:46:59Z","html_url":"https://github.com/alphagov/vcloud-core/pull/7#discussion_r9677503","pull_request_url":"https://api.github.com/repos/alphagov/vcloud-core/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/alphagov/vcloud-core/pulls/comments/9677503"},"html":{"href":"https://github.com/alphagov/vcloud-core/pull/7#discussion_r9677503"},"pull_request":{"href":"https://api.github.com/repos/alphagov/vcloud-core/pulls/7"}}}}