GitHub PullRequestReviewCommentEvent at 2014-01-20 15:22:05
Repository: angular.js
Actor: GlobalDomestic
Payload: {"comment":{"url":"https://api.github.com/repos/angular/angular.js/pulls/comments/9007759","id":9007759,"diff_hunk":"@@ -128,8 +128,8 @@ var ngOptionsMinErr = minErr('ngOptions');\n var ngOptionsDirective = valueFn({ terminal: true });\n // jshint maxlen: false\n var selectDirective = ['$compile', '$parse', function($compile,   $parse) {\n-                         //000011111111110000000000022222222220000000000000000000003333333333000000000000004444444444444440000000005555555555555550000000666666666666666000000000000000777777777700000000000000000008888888888\n-  var NG_OPTIONS_REGEXP = /^\\s*([\\s\\S]+?)(?:\\s+as\\s+([\\s\\S]+?))?(?:\\s+group\\s+by\\s+([\\s\\S]+?))?\\s+for\\s+(?:([\\$\\w][\\$\\w]*)|(?:\\(\\s*([\\$\\w][\\$\\w]*)\\s*,\\s*([\\$\\w][\\$\\w]*)\\s*\\)))\\s+in\\s+([\\s\\S]+?)(?:\\s+track\\s+by\\s+([\\s\\S]+?))?$/,\n+                         //000011111000000000002222200000000000000000000033333000000000000004444444444440000005555555555550000000666666666666000000000000007777777777000000000000000000088888000000/\n+  var NG_OPTIONS_REGEXP = /^\\s*(\\S+)(?:\\s+as\\s+(\\S+)|)(?:\\s+group\\s+by\\s+(\\S+)|)\\s+for\\s+(?:(\\${0,2}\\w*)|\\(\\s*(\\${0,2}\\w*)\\s*,\\s*(\\${0,2}\\w*)\\s*\\))\\s+in\\s+([\\s\\S]+?)(?:\\s+track\\s+by\\s+(\\S+)|)\\s*$/,","path":"src/ng/directive/select.js","position":7,"original_position":7,"commit_id":"3b3c79ed2fb5aecc9fd6a3dddafc58b35f668841","original_commit_id":"3b3c79ed2fb5aecc9fd6a3dddafc58b35f668841","user":{"login":"GlobalDomestic","id":587847,"avatar_url":"https://gravatar.com/avatar/97dca981406a95d92e88136412dd8853?d=https%3A%2F%2Fidenticons.github.com%2Fc0c0081d2f022437764721d1e7899c0f.png&r=x","gravatar_id":"97dca981406a95d92e88136412dd8853","url":"https://api.github.com/users/GlobalDomestic","html_url":"https://github.com/GlobalDomestic","followers_url":"https://api.github.com/users/GlobalDomestic/followers","following_url":"https://api.github.com/users/GlobalDomestic/following{/other_user}","gists_url":"https://api.github.com/users/GlobalDomestic/gists{/gist_id}","starred_url":"https://api.github.com/users/GlobalDomestic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GlobalDomestic/subscriptions","organizations_url":"https://api.github.com/users/GlobalDomestic/orgs","repos_url":"https://api.github.com/users/GlobalDomestic/repos","events_url":"https://api.github.com/users/GlobalDomestic/events{/privacy}","received_events_url":"https://api.github.com/users/GlobalDomestic/received_events","type":"User","site_admin":false},"body":"Based on the previous discussion about the track-by expression allowing whitespace this one needs to have the track-by capture group here allow for it as well. This line change should **NOT** be committed as is till then.","created_at":"2014-01-20T15:22:05Z","updated_at":"2014-01-20T15:22:05Z","html_url":"https://github.com/angular/angular.js/pull/5891#discussion_r9007759","pull_request_url":"https://api.github.com/repos/angular/angular.js/pulls/5891","_links":{"self":{"href":"https://api.github.com/repos/angular/angular.js/pulls/comments/9007759"},"html":{"href":"https://github.com/angular/angular.js/pull/5891#discussion_r9007759"},"pull_request":{"href":"https://api.github.com/repos/angular/angular.js/pulls/5891"}}}}