GitHub PullRequestReviewCommentEvent at 2014-04-10 21:39:37
Repository: crontabber
Actor: peterbe
Payload: {"comment":{"url":"https://api.github.com/repos/mozilla/crontabber/pulls/comments/11507923","id":11507923,"diff_hunk":"@@ -724,11 +724,13 @@ class CronTabber(App):\n \n     def __init__(self, config):\n         super(CronTabber, self).__init__(config)\n-        self.database_connection_source = \\\n+        self.database_connection_factory = \\","path":"crontabber/app.py","position":100,"original_position":100,"commit_id":"9c60a1012ad38346e89f3ac53a453bd844e9157a","original_commit_id":"9c60a1012ad38346e89f3ac53a453bd844e9157a","user":{"login":"peterbe","id":26739,"avatar_url":"https://avatars.githubusercontent.com/u/26739?","gravatar_id":"37d081c393f95a14e2704af38ecc4c8d","url":"https://api.github.com/users/peterbe","html_url":"https://github.com/peterbe","followers_url":"https://api.github.com/users/peterbe/followers","following_url":"https://api.github.com/users/peterbe/following{/other_user}","gists_url":"https://api.github.com/users/peterbe/gists{/gist_id}","starred_url":"https://api.github.com/users/peterbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterbe/subscriptions","organizations_url":"https://api.github.com/users/peterbe/orgs","repos_url":"https://api.github.com/users/peterbe/repos","events_url":"https://api.github.com/users/peterbe/events{/privacy}","received_events_url":"https://api.github.com/users/peterbe/received_events","type":"User","site_admin":false},"body":"Can it not be `connection_factory` only? Because clearly it's about connecting to a db. ","created_at":"2014-04-10T21:39:37Z","updated_at":"2014-04-10T21:39:37Z","html_url":"https://github.com/mozilla/crontabber/pull/7#discussion_r11507923","pull_request_url":"https://api.github.com/repos/mozilla/crontabber/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/mozilla/crontabber/pulls/comments/11507923"},"html":{"href":"https://github.com/mozilla/crontabber/pull/7#discussion_r11507923"},"pull_request":{"href":"https://api.github.com/repos/mozilla/crontabber/pulls/7"}}}}