GitHub PullRequestReviewCommentEvent at 2014-11-06 22:41:32
Repository: pollster
Actor: sarenji
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/kickstarter/pollster/pulls/comments/19981962","id":19981962,"diff_hunk":"@@ -58,12 +58,15 @@\n       }\n     }\n \n+    var url = this.url + (this.url.indexOf('?') > 0 ? '&' : '?') + 'pollster_timestamp=' + new Date().getTime();","path":"src/pollster.js","position":4,"original_position":4,"commit_id":"a35c94b0ec4a85e6b3f46a7c1ab19001123f14ed","original_commit_id":"a35c94b0ec4a85e6b3f46a7c1ab19001123f14ed","user":{"login":"sarenji","id":167743,"avatar_url":"https://avatars.githubusercontent.com/u/167743?v=2","gravatar_id":"","url":"https://api.github.com/users/sarenji","html_url":"https://github.com/sarenji","followers_url":"https://api.github.com/users/sarenji/followers","following_url":"https://api.github.com/users/sarenji/following{/other_user}","gists_url":"https://api.github.com/users/sarenji/gists{/gist_id}","starred_url":"https://api.github.com/users/sarenji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarenji/subscriptions","organizations_url":"https://api.github.com/users/sarenji/orgs","repos_url":"https://api.github.com/users/sarenji/repos","events_url":"https://api.github.com/users/sarenji/events{/privacy}","received_events_url":"https://api.github.com/users/sarenji/received_events","type":"User","site_admin":false},"body":"should this be `>= 0`?","created_at":"2014-11-06T22:41:32Z","updated_at":"2014-11-06T22:41:32Z","html_url":"https://github.com/kickstarter/pollster/pull/1#discussion_r19981962","pull_request_url":"https://api.github.com/repos/kickstarter/pollster/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/kickstarter/pollster/pulls/comments/19981962"},"html":{"href":"https://github.com/kickstarter/pollster/pull/1#discussion_r19981962"},"pull_request":{"href":"https://api.github.com/repos/kickstarter/pollster/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/kickstarter/pollster/pulls/1","id":24018530,"html_url":"https://github.com/kickstarter/pollster/pull/1","diff_url":"https://github.com/kickstarter/pollster/pull/1.diff","patch_url":"https://github.com/kickstarter/pollster/pull/1.patch","issue_url":"https://api.github.com/repos/kickstarter/pollster/issues/1","number":1,"state":"open","locked":false,"title":"Do not cache results from initial query","user":{"login":"rynclsnr","id":100588,"avatar_url":"https://avatars.githubusercontent.com/u/100588?v=2","gravatar_id":"","url":"https://api.github.com/users/rynclsnr","html_url":"https://github.com/rynclsnr","followers_url":"https://api.github.com/users/rynclsnr/followers","following_url":"https://api.github.com/users/rynclsnr/following{/other_user}","gists_url":"https://api.github.com/users/rynclsnr/gists{/gist_id}","starred_url":"https://api.github.com/users/rynclsnr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rynclsnr/subscriptions","organizations_url":"https://api.github.com/users/rynclsnr/orgs","repos_url":"https://api.github.com/users/rynclsnr/repos","events_url":"https://api.github.com/users/rynclsnr/events{/privacy}","received_events_url":"https://api.github.com/users/rynclsnr/received_events","type":"User","site_admin":false},"body":"Trying to bust any caching that might be happening on iOS devices pre-iOS7. Employing two strategies here: altering the URL to include a timestamp parameter and passing ``{ cache: false }`` as an additional option to ``$.ajax``.","created_at":"2014-11-06T22:31:17Z","updated_at":"2014-11-06T22:41:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"881b1447bcac1981c8ce3123bd13a78a78c3f7c0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kickstarter/pollster/pulls/1/commits","review_comments_url":"https://api.github.com/repos/kickstarter/pollster/pulls/1/comments","review_comment_url":"https://api.github.com/repos/kickstarter/pollster/pulls/comments/{number}","comments_url":"https://api.github.com/repos/kickstarter/pollster/issues/1/comments","statuses_url":"https://api.github.com/repos/kickstarter/pollster/statuses/a35c94b0ec4a85e6b3f46a7c1ab19001123f14ed","head":{"label":"kickstarter:no-caching","ref":"no-caching","sha":"a35c94b0ec4a85e6b3f46a7c1ab19001123f14ed","user":{"login":"kickstarter","id":120676,"avatar_url":"https://avatars.githubusercontent.com/u/120676?v=2","gravatar_id":"","url":"https://api.github.com/users/kickstarter","html_url":"https://github.com/kickstarter","followers_url":"https://api.github.com/users/kickstarter/followers","following_url":"https://api.github.com/users/kickstarter/following{/other_user}","gists_url":"https://api.github.com/users/kickstarter/gists{/gist_id}","starred_url":"https://api.github.com/users/kickstarter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kickstarter/subscriptions","organizations_url":"https://api.github.com/users/kickstarter/orgs","repos_url":"https://api.github.com/users/kickstarter/repos","events_url":"https://api.github.com/users/kickstarter/events{/privacy}","received_events_url":"https://api.github.com/users/kickstarter/received_events","type":"Organization","site_admin":false},"repo":{"id":15556496,"name":"pollster","full_name":"kickstarter/pollster","owner":{"login":"kickstarter","id":120676,"avatar_url":"https://avatars.githubusercontent.com/u/120676?v=2","gravatar_id":"","url":"https://api.github.com/users/kickstarter","html_url":"https://github.com/kickstarter","followers_url":"https://api.github.com/users/kickstarter/followers","following_url":"https://api.github.com/users/kickstarter/following{/other_user}","gists_url":"https://api.github.com/users/kickstarter/gists{/gist_id}","starred_url":"https://api.github.com/users/kickstarter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kickstarter/subscriptions","organizations_url":"https://api.github.com/users/kickstarter/orgs","repos_url":"https://api.github.com/users/kickstarter/repos","events_url":"https://api.github.com/users/kickstarter/events{/privacy}","received_events_url":"https://api.github.com/users/kickstarter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kickstarter/pollster","description":"","fork":true,"url":"https://api.github.com/repos/kickstarter/pollster","forks_url":"https://api.github.com/repos/kickstarter/pollster/forks","keys_url":"https://api.github.com/repos/kickstarter/pollster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kickstarter/pollster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kickstarter/pollster/teams","hooks_url":"https://api.github.com/repos/kickstarter/pollster/hooks","issue_events_url":"https://api.github.com/repos/kickstarter/pollster/issues/events{/number}","events_url":"https://api.github.com/repos/kickstarter/pollster/events","assignees_url":"https://api.github.com/repos/kickstarter/pollster/assignees{/user}","branches_url":"https://api.github.com/repos/kickstarter/pollster/branches{/branch}","tags_url":"https://api.github.com/repos/kickstarter/pollster/tags","blobs_url":"https://api.github.com/repos/kickstarter/pollster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kickstarter/pollster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kickstarter/pollster/git/refs{/sha}","trees_url":"https://api.github.com/repos/kickstarter/pollster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kickstarter/pollster/statuses/{sha}","languages_url":"https://api.github.com/repos/kickstarter/pollster/languages","stargazers_url":"https://api.github.com/repos/kickstarter/pollster/stargazers","contributors_url":"https://api.github.com/repos/kickstarter/pollster/contributors","subscribers_url":"https://api.github.com/repos/kickstarter/pollster/subscribers","subscription_url":"https://api.github.com/repos/kickstarter/pollster/subscription","commits_url":"https://api.github.com/repos/kickstarter/pollster/commits{/sha}","git_commits_url":"https://api.github.com/repos/kickstarter/pollster/git/commits{/sha}","comments_url":"https://api.github.com/repos/kickstarter/pollster/comments{/number}","issue_comment_url":"https://api.github.com/repos/kickstarter/pollster/issues/comments/{number}","contents_url":"https://api.github.com/repos/kickstarter/pollster/contents/{+path}","compare_url":"https://api.github.com/repos/kickstarter/pollster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kickstarter/pollster/merges","archive_url":"https://api.github.com/repos/kickstarter/pollster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kickstarter/pollster/downloads","issues_url":"https://api.github.com/repos/kickstarter/pollster/issues{/number}","pulls_url":"https://api.github.com/repos/kickstarter/pollster/pulls{/number}","milestones_url":"https://api.github.com/repos/kickstarter/pollster/milestones{/number}","notifications_url":"https://api.github.com/repos/kickstarter/pollster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kickstarter/pollster/labels{/name}","releases_url":"https://api.github.com/repos/kickstarter/pollster/releases{/id}","created_at":"2013-12-31T20:39:45Z","updated_at":"2014-01-03T16:19:52Z","pushed_at":"2014-11-06T21:15:29Z","git_url":"git://github.com/kickstarter/pollster.git","ssh_url":"git@github.com:kickstarter/pollster.git","clone_url":"https://github.com/kickstarter/pollster.git","svn_url":"https://github.com/kickstarter/pollster","homepage":null,"size":290,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"kickstarter:master","ref":"master","sha":"c92642fb92600c03b436d02e9d505c89daf13d0c","user":{"login":"kickstarter","id":120676,"avatar_url":"https://avatars.githubusercontent.com/u/120676?v=2","gravatar_id":"","url":"https://api.github.com/users/kickstarter","html_url":"https://github.com/kickstarter","followers_url":"https://api.github.com/users/kickstarter/followers","following_url":"https://api.github.com/users/kickstarter/following{/other_user}","gists_url":"https://api.github.com/users/kickstarter/gists{/gist_id}","starred_url":"https://api.github.com/users/kickstarter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kickstarter/subscriptions","organizations_url":"https://api.github.com/users/kickstarter/orgs","repos_url":"https://api.github.com/users/kickstarter/repos","events_url":"https://api.github.com/users/kickstarter/events{/privacy}","received_events_url":"https://api.github.com/users/kickstarter/received_events","type":"Organization","site_admin":false},"repo":{"id":15556496,"name":"pollster","full_name":"kickstarter/pollster","owner":{"login":"kickstarter","id":120676,"avatar_url":"https://avatars.githubusercontent.com/u/120676?v=2","gravatar_id":"","url":"https://api.github.com/users/kickstarter","html_url":"https://github.com/kickstarter","followers_url":"https://api.github.com/users/kickstarter/followers","following_url":"https://api.github.com/users/kickstarter/following{/other_user}","gists_url":"https://api.github.com/users/kickstarter/gists{/gist_id}","starred_url":"https://api.github.com/users/kickstarter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kickstarter/subscriptions","organizations_url":"https://api.github.com/users/kickstarter/orgs","repos_url":"https://api.github.com/users/kickstarter/repos","events_url":"https://api.github.com/users/kickstarter/events{/privacy}","received_events_url":"https://api.github.com/users/kickstarter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kickstarter/pollster","description":"","fork":true,"url":"https://api.github.com/repos/kickstarter/pollster","forks_url":"https://api.github.com/repos/kickstarter/pollster/forks","keys_url":"https://api.github.com/repos/kickstarter/pollster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kickstarter/pollster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kickstarter/pollster/teams","hooks_url":"https://api.github.com/repos/kickstarter/pollster/hooks","issue_events_url":"https://api.github.com/repos/kickstarter/pollster/issues/events{/number}","events_url":"https://api.github.com/repos/kickstarter/pollster/events","assignees_url":"https://api.github.com/repos/kickstarter/pollster/assignees{/user}","branches_url":"https://api.github.com/repos/kickstarter/pollster/branches{/branch}","tags_url":"https://api.github.com/repos/kickstarter/pollster/tags","blobs_url":"https://api.github.com/repos/kickstarter/pollster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kickstarter/pollster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kickstarter/pollster/git/refs{/sha}","trees_url":"https://api.github.com/repos/kickstarter/pollster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kickstarter/pollster/statuses/{sha}","languages_url":"https://api.github.com/repos/kickstarter/pollster/languages","stargazers_url":"https://api.github.com/repos/kickstarter/pollster/stargazers","contributors_url":"https://api.github.com/repos/kickstarter/pollster/contributors","subscribers_url":"https://api.github.com/repos/kickstarter/pollster/subscribers","subscription_url":"https://api.github.com/repos/kickstarter/pollster/subscription","commits_url":"https://api.github.com/repos/kickstarter/pollster/commits{/sha}","git_commits_url":"https://api.github.com/repos/kickstarter/pollster/git/commits{/sha}","comments_url":"https://api.github.com/repos/kickstarter/pollster/comments{/number}","issue_comment_url":"https://api.github.com/repos/kickstarter/pollster/issues/comments/{number}","contents_url":"https://api.github.com/repos/kickstarter/pollster/contents/{+path}","compare_url":"https://api.github.com/repos/kickstarter/pollster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kickstarter/pollster/merges","archive_url":"https://api.github.com/repos/kickstarter/pollster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kickstarter/pollster/downloads","issues_url":"https://api.github.com/repos/kickstarter/pollster/issues{/number}","pulls_url":"https://api.github.com/repos/kickstarter/pollster/pulls{/number}","milestones_url":"https://api.github.com/repos/kickstarter/pollster/milestones{/number}","notifications_url":"https://api.github.com/repos/kickstarter/pollster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kickstarter/pollster/labels{/name}","releases_url":"https://api.github.com/repos/kickstarter/pollster/releases{/id}","created_at":"2013-12-31T20:39:45Z","updated_at":"2014-01-03T16:19:52Z","pushed_at":"2014-11-06T21:15:29Z","git_url":"git://github.com/kickstarter/pollster.git","ssh_url":"git@github.com:kickstarter/pollster.git","clone_url":"https://github.com/kickstarter/pollster.git","svn_url":"https://github.com/kickstarter/pollster","homepage":null,"size":290,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kickstarter/pollster/pulls/1"},"html":{"href":"https://github.com/kickstarter/pollster/pull/1"},"issue":{"href":"https://api.github.com/repos/kickstarter/pollster/issues/1"},"comments":{"href":"https://api.github.com/repos/kickstarter/pollster/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/kickstarter/pollster/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/kickstarter/pollster/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/kickstarter/pollster/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/kickstarter/pollster/statuses/a35c94b0ec4a85e6b3f46a7c1ab19001123f14ed"}}}}