GitHub PullRequestReviewCommentEvent at 2014-09-19 01:00:12
Repository: gecko-dev
Actor: adamroach
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/unicorn-wg/gecko-dev/pulls/comments/17764913","id":17764913,"diff_hunk":"@@ -254,9 +255,53 @@ inline std::ostream& operator <<(std::ostream& os,\n   return os;\n }\n \n+\n+// RFC 4566\n+//      a=sendrecv / a=sendonly / a=recvonly / a=inactive\n+class SdpDirectionAttribute : public SdpAttribute\n+{\n+ public:\n+  enum Direction {\n+    kSendrecv,\n+    kSendonly,\n+    kRecvonly,\n+    kInactive\n+  };\n+\n+  SdpDirectionAttribute(Direction value)\n+      : SdpAttribute(kDirectionAttribute, GetString(value)),\n+        mValue(value) {}\n+\n+  Direction mValue;\n+\n+  virtual void Serialize(std::ostream& os) const MOZ_OVERRIDE {\n+    os << \"a=\" << GetTypeName() << \":\" << mValue << CRLF;\n+  }\n+\n+  static std::string GetString(Direction v) {\n+    std::ostringstream ss;\n+    ss << v;\n+    return ss.str();\n+  }\n+};\n+\n+inline std::ostream& operator <<(std::ostream& os,\n+                                 SdpDirectionAttribute::Direction d)\n+{\n+  switch (d) {\n+    case SdpDirectionAttribute::kSendonly: os << \"sendonly\"; break;\n+    case SdpDirectionAttribute::kRecvonly: os << \"recvonly\"; break;\n+    case SdpDirectionAttribute::kSendrecv: os << \"sendrecv\"; break;\n+    case SdpDirectionAttribute::kInactive: os << \"inactive\"; break;\n+    default: MOZ_ASSERT(false); os << \"?\";\n+  }\n+  return os;\n+}\n+\n ///////////////////////////////////////////////////////////////////////////\n // a=extmap, RFC5285\n //-------------------------------------------------------------------------\n+// RFC5285","path":"media/webrtc/signaling/src/sdp/SdpAttribute.h","position":92,"original_position":92,"commit_id":"c83ea758a97c4a5675fabbe632fa28680c29d1a4","original_commit_id":"c83ea758a97c4a5675fabbe632fa28680c29d1a4","user":{"login":"adamroach","id":2974852,"avatar_url":"https://avatars.githubusercontent.com/u/2974852?v=2","gravatar_id":"e8bebce30304eb8c33c1f8b26fd4326a","url":"https://api.github.com/users/adamroach","html_url":"https://github.com/adamroach","followers_url":"https://api.github.com/users/adamroach/followers","following_url":"https://api.github.com/users/adamroach/following{/other_user}","gists_url":"https://api.github.com/users/adamroach/gists{/gist_id}","starred_url":"https://api.github.com/users/adamroach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamroach/subscriptions","organizations_url":"https://api.github.com/users/adamroach/orgs","repos_url":"https://api.github.com/users/adamroach/repos","events_url":"https://api.github.com/users/adamroach/events{/privacy}","received_events_url":"https://api.github.com/users/adamroach/received_events","type":"User","site_admin":false},"body":"Merge damage (innocuous, but untidy)","created_at":"2014-09-19T01:00:12Z","updated_at":"2014-09-19T01:00:12Z","html_url":"https://github.com/unicorn-wg/gecko-dev/pull/47#discussion_r17764913","pull_request_url":"https://api.github.com/repos/unicorn-wg/gecko-dev/pulls/47","_links":{"self":{"href":"https://api.github.com/repos/unicorn-wg/gecko-dev/pulls/comments/17764913"},"html":{"href":"https://github.com/unicorn-wg/gecko-dev/pull/47#discussion_r17764913"},"pull_request":{"href":"https://api.github.com/repos/unicorn-wg/gecko-dev/pulls/47"}}},"pull_request":{"url":"https://api.github.com/repos/unicorn-wg/gecko-dev/pulls/47","id":21468151,"html_url":"https://github.com/unicorn-wg/gecko-dev/pull/47","diff_url":"https://github.com/unicorn-wg/gecko-dev/pull/47.diff","patch_url":"https://github.com/unicorn-wg/gecko-dev/pull/47.patch","issue_url":"https://api.github.com/repos/unicorn-wg/gecko-dev/issues/47","number":47,"state":"open","locked":false,"title":"Adding error passing stuff","user":{"login":"martinthomson","id":67641,"avatar_url":"https://avatars.githubusercontent.com/u/67641?v=2","gravatar_id":"3fa6569f8aa70b9a0a7df4ad7bebc0df","url":"https://api.github.com/users/martinthomson","html_url":"https://github.com/martinthomson","followers_url":"https://api.github.com/users/martinthomson/followers","following_url":"https://api.github.com/users/martinthomson/following{/other_user}","gists_url":"https://api.github.com/users/martinthomson/gists{/gist_id}","starred_url":"https://api.github.com/users/martinthomson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinthomson/subscriptions","organizations_url":"https://api.github.com/users/martinthomson/orgs","repos_url":"https://api.github.com/users/martinthomson/repos","events_url":"https://api.github.com/users/martinthomson/events{/privacy}","received_events_url":"https://api.github.com/users/martinthomson/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-09-18T22:48:34Z","updated_at":"2014-09-19T01:00:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"88319a2c8d740c906ff5a6cd01c903be56ef8b98","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/unicorn-wg/gecko-dev/pulls/47/commits","review_comments_url":"https://api.github.com/repos/unicorn-wg/gecko-dev/pulls/47/comments","review_comment_url":"https://api.github.com/repos/unicorn-wg/gecko-dev/pulls/comments/{number}","comments_url":"https://api.github.com/repos/unicorn-wg/gecko-dev/issues/47/comments","statuses_url":"https://api.github.com/repos/unicorn-wg/gecko-dev/statuses/c83ea758a97c4a5675fabbe632fa28680c29d1a4","head":{"label":"martinthomson:sdpwrap","ref":"sdpwrap","sha":"c83ea758a97c4a5675fabbe632fa28680c29d1a4","user":{"login":"martinthomson","id":67641,"avatar_url":"https://avatars.githubusercontent.com/u/67641?v=2","gravatar_id":"3fa6569f8aa70b9a0a7df4ad7bebc0df","url":"https://api.github.com/users/martinthomson","html_url":"https://github.com/martinthomson","followers_url":"https://api.github.com/users/martinthomson/followers","following_url":"https://api.github.com/users/martinthomson/following{/other_user}","gists_url":"https://api.github.com/users/martinthomson/gists{/gist_id}","starred_url":"https://api.github.com/users/martinthomson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinthomson/subscriptions","organizations_url":"https://api.github.com/users/martinthomson/orgs","repos_url":"https://api.github.com/users/martinthomson/repos","events_url":"https://api.github.com/users/martinthomson/events{/privacy}","received_events_url":"https://api.github.com/users/martinthomson/received_events","type":"User","site_admin":false},"repo":{"id":15984451,"name":"gecko-dev","full_name":"martinthomson/gecko-dev","owner":{"login":"martinthomson","id":67641,"avatar_url":"https://avatars.githubusercontent.com/u/67641?v=2","gravatar_id":"3fa6569f8aa70b9a0a7df4ad7bebc0df","url":"https://api.github.com/users/martinthomson","html_url":"https://github.com/martinthomson","followers_url":"https://api.github.com/users/martinthomson/followers","following_url":"https://api.github.com/users/martinthomson/following{/other_user}","gists_url":"https://api.github.com/users/martinthomson/gists{/gist_id}","starred_url":"https://api.github.com/users/martinthomson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinthomson/subscriptions","organizations_url":"https://api.github.com/users/martinthomson/orgs","repos_url":"https://api.github.com/users/martinthomson/repos","events_url":"https://api.github.com/users/martinthomson/events{/privacy}","received_events_url":"https://api.github.com/users/martinthomson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/martinthomson/gecko-dev","description":"","fork":true,"url":"https://api.github.com/repos/martinthomson/gecko-dev","forks_url":"https://api.github.com/repos/martinthomson/gecko-dev/forks","keys_url":"https://api.github.com/repos/martinthomson/gecko-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/martinthomson/gecko-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/martinthomson/gecko-dev/teams","hooks_url":"https://api.github.com/repos/martinthomson/gecko-dev/hooks","issue_events_url":"https://api.github.com/repos/martinthomson/gecko-dev/issues/events{/number}","events_url":"https://api.github.com/repos/martinthomson/gecko-dev/events","assignees_url":"https://api.github.com/repos/martinthomson/gecko-dev/assignees{/user}","branches_url":"https://api.github.com/repos/martinthomson/gecko-dev/branches{/branch}","tags_url":"https://api.github.com/repos/martinthomson/gecko-dev/tags","blobs_url":"https://api.github.com/repos/martinthomson/gecko-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/martinthomson/gecko-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/martinthomson/gecko-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/martinthomson/gecko-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/martinthomson/gecko-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/martinthomson/gecko-dev/languages","stargazers_url":"https://api.github.com/repos/martinthomson/gecko-dev/stargazers","contributors_url":"https://api.github.com/repos/martinthomson/gecko-dev/contributors","subscribers_url":"https://api.github.com/repos/martinthomson/gecko-dev/subscribers","subscription_url":"https://api.github.com/repos/martinthomson/gecko-dev/subscription","commits_url":"https://api.github.com/repos/martinthomson/gecko-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/martinthomson/gecko-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/martinthomson/gecko-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/martinthomson/gecko-dev/issues/comments/{number}","contents_url":"https://api.github.com/repos/martinthomson/gecko-dev/contents/{+path}","compare_url":"https://api.github.com/repos/martinthomson/gecko-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/martinthomson/gecko-dev/merges","archive_url":"https://api.github.com/repos/martinthomson/gecko-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/martinthomson/gecko-dev/downloads","issues_url":"https://api.github.com/repos/martinthomson/gecko-dev/issues{/number}","pulls_url":"https://api.github.com/repos/martinthomson/gecko-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/martinthomson/gecko-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/martinthomson/gecko-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/martinthomson/gecko-dev/labels{/name}","releases_url":"https://api.github.com/repos/martinthomson/gecko-dev/releases{/id}","created_at":"2014-01-16T23:30:22Z","updated_at":"2014-07-18T21:18:16Z","pushed_at":"2014-09-19T00:47:34Z","git_url":"git://github.com/martinthomson/gecko-dev.git","ssh_url":"git@github.com:martinthomson/gecko-dev.git","clone_url":"https://github.com/martinthomson/gecko-dev.git","svn_url":"https://github.com/martinthomson/gecko-dev","homepage":null,"size":1713170,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"unicorn-wg:multistream","ref":"multistream","sha":"24c3526941f855458e7a3725b7817cf08fe6c3ef","user":{"login":"unicorn-wg","id":7967548,"avatar_url":"https://avatars.githubusercontent.com/u/7967548?v=2","gravatar_id":null,"url":"https://api.github.com/users/unicorn-wg","html_url":"https://github.com/unicorn-wg","followers_url":"https://api.github.com/users/unicorn-wg/followers","following_url":"https://api.github.com/users/unicorn-wg/following{/other_user}","gists_url":"https://api.github.com/users/unicorn-wg/gists{/gist_id}","starred_url":"https://api.github.com/users/unicorn-wg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unicorn-wg/subscriptions","organizations_url":"https://api.github.com/users/unicorn-wg/orgs","repos_url":"https://api.github.com/users/unicorn-wg/repos","events_url":"https://api.github.com/users/unicorn-wg/events{/privacy}","received_events_url":"https://api.github.com/users/unicorn-wg/received_events","type":"Organization","site_admin":false},"repo":{"id":24074557,"name":"gecko-dev","full_name":"unicorn-wg/gecko-dev","owner":{"login":"unicorn-wg","id":7967548,"avatar_url":"https://avatars.githubusercontent.com/u/7967548?v=2","gravatar_id":null,"url":"https://api.github.com/users/unicorn-wg","html_url":"https://github.com/unicorn-wg","followers_url":"https://api.github.com/users/unicorn-wg/followers","following_url":"https://api.github.com/users/unicorn-wg/following{/other_user}","gists_url":"https://api.github.com/users/unicorn-wg/gists{/gist_id}","starred_url":"https://api.github.com/users/unicorn-wg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unicorn-wg/subscriptions","organizations_url":"https://api.github.com/users/unicorn-wg/orgs","repos_url":"https://api.github.com/users/unicorn-wg/repos","events_url":"https://api.github.com/users/unicorn-wg/events{/privacy}","received_events_url":"https://api.github.com/users/unicorn-wg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/unicorn-wg/gecko-dev","description":"Read-only Git mirror of the Mercurial gecko repositories at https://hg.mozilla.org. Please don't submit PRs, see: https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#I%27m_all_used_to_git.2C_but_how_can_I_provide_Mercurial-ready_patches_.3F","fork":true,"url":"https://api.github.com/repos/unicorn-wg/gecko-dev","forks_url":"https://api.github.com/repos/unicorn-wg/gecko-dev/forks","keys_url":"https://api.github.com/repos/unicorn-wg/gecko-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/unicorn-wg/gecko-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/unicorn-wg/gecko-dev/teams","hooks_url":"https://api.github.com/repos/unicorn-wg/gecko-dev/hooks","issue_events_url":"https://api.github.com/repos/unicorn-wg/gecko-dev/issues/events{/number}","events_url":"https://api.github.com/repos/unicorn-wg/gecko-dev/events","assignees_url":"https://api.github.com/repos/unicorn-wg/gecko-dev/assignees{/user}","branches_url":"https://api.github.com/repos/unicorn-wg/gecko-dev/branches{/branch}","tags_url":"https://api.github.com/repos/unicorn-wg/gecko-dev/tags","blobs_url":"https://api.github.com/repos/unicorn-wg/gecko-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/unicorn-wg/gecko-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/unicorn-wg/gecko-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/unicorn-wg/gecko-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/unicorn-wg/gecko-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/unicorn-wg/gecko-dev/languages","stargazers_url":"https://api.github.com/repos/unicorn-wg/gecko-dev/stargazers","contributors_url":"https://api.github.com/repos/unicorn-wg/gecko-dev/contributors","subscribers_url":"https://api.github.com/repos/unicorn-wg/gecko-dev/subscribers","subscription_url":"https://api.github.com/repos/unicorn-wg/gecko-dev/subscription","commits_url":"https://api.github.com/repos/unicorn-wg/gecko-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/unicorn-wg/gecko-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/unicorn-wg/gecko-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/unicorn-wg/gecko-dev/issues/comments/{number}","contents_url":"https://api.github.com/repos/unicorn-wg/gecko-dev/contents/{+path}","compare_url":"https://api.github.com/repos/unicorn-wg/gecko-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/unicorn-wg/gecko-dev/merges","archive_url":"https://api.github.com/repos/unicorn-wg/gecko-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/unicorn-wg/gecko-dev/downloads","issues_url":"https://api.github.com/repos/unicorn-wg/gecko-dev/issues{/number}","pulls_url":"https://api.github.com/repos/unicorn-wg/gecko-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/unicorn-wg/gecko-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/unicorn-wg/gecko-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/unicorn-wg/gecko-dev/labels{/name}","releases_url":"https://api.github.com/repos/unicorn-wg/gecko-dev/releases{/id}","created_at":"2014-09-15T21:25:18Z","updated_at":"2014-09-15T22:07:36Z","pushed_at":"2014-09-19T00:01:34Z","git_url":"git://github.com/unicorn-wg/gecko-dev.git","ssh_url":"git@github.com:unicorn-wg/gecko-dev.git","clone_url":"https://github.com/unicorn-wg/gecko-dev.git","svn_url":"https://github.com/unicorn-wg/gecko-dev","homepage":"https://developer.mozilla.org/docs/Introduction","size":1758201,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":0,"default_branch":"multistream"}},"_links":{"self":{"href":"https://api.github.com/repos/unicorn-wg/gecko-dev/pulls/47"},"html":{"href":"https://github.com/unicorn-wg/gecko-dev/pull/47"},"issue":{"href":"https://api.github.com/repos/unicorn-wg/gecko-dev/issues/47"},"comments":{"href":"https://api.github.com/repos/unicorn-wg/gecko-dev/issues/47/comments"},"review_comments":{"href":"https://api.github.com/repos/unicorn-wg/gecko-dev/pulls/47/comments"},"review_comment":{"href":"https://api.github.com/repos/unicorn-wg/gecko-dev/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/unicorn-wg/gecko-dev/pulls/47/commits"},"statuses":{"href":"https://api.github.com/repos/unicorn-wg/gecko-dev/statuses/c83ea758a97c4a5675fabbe632fa28680c29d1a4"}}}}