GitHub PullRequestReviewCommentEvent at 2014-09-22 23:21:57
Repository: puppet-monitoring_check
Actor: bobtfish
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/pulls/comments/17884829","id":17884829,"diff_hunk":"@@ -153,6 +153,9 @@\n   validate_string($runbook)\n   validate_re($runbook, '^(https?://|y/)')\n   validate_string($team)\n+  if size(keys($team_data)) == 0 {\n+    fail(\"No sensu_handlers::teams data could be loaded - need at least 1 team\")","path":"manifests/init.pp","position":13,"original_position":5,"commit_id":"2b29f41a886a77a0e0e14d552a6215b99c1c2906","original_commit_id":"c89c4090bf59b0bbeef5fa642017e5054bbe109f","user":{"login":"bobtfish","id":42338,"avatar_url":"https://avatars.githubusercontent.com/u/42338?v=2","gravatar_id":"","url":"https://api.github.com/users/bobtfish","html_url":"https://github.com/bobtfish","followers_url":"https://api.github.com/users/bobtfish/followers","following_url":"https://api.github.com/users/bobtfish/following{/other_user}","gists_url":"https://api.github.com/users/bobtfish/gists{/gist_id}","starred_url":"https://api.github.com/users/bobtfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobtfish/subscriptions","organizations_url":"https://api.github.com/users/bobtfish/orgs","repos_url":"https://api.github.com/users/bobtfish/repos","events_url":"https://api.github.com/users/bobtfish/events{/privacy}","received_events_url":"https://api.github.com/users/bobtfish/received_events","type":"User","site_admin":false},"body":"Done!","created_at":"2014-09-22T23:21:57Z","updated_at":"2014-09-22T23:21:57Z","html_url":"https://github.com/Yelp/puppet-monitoring_check/pull/4#discussion_r17884829","pull_request_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/Yelp/puppet-monitoring_check/pulls/comments/17884829"},"html":{"href":"https://github.com/Yelp/puppet-monitoring_check/pull/4#discussion_r17884829"},"pull_request":{"href":"https://api.github.com/repos/Yelp/puppet-monitoring_check/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/pulls/4","id":21608571,"html_url":"https://github.com/Yelp/puppet-monitoring_check/pull/4","diff_url":"https://github.com/Yelp/puppet-monitoring_check/pull/4.diff","patch_url":"https://github.com/Yelp/puppet-monitoring_check/pull/4.patch","issue_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/issues/4","number":4,"state":"open","locked":false,"title":"Better error if we have no teams data","user":{"login":"bobtfish","id":42338,"avatar_url":"https://avatars.githubusercontent.com/u/42338?v=2","gravatar_id":"","url":"https://api.github.com/users/bobtfish","html_url":"https://github.com/bobtfish","followers_url":"https://api.github.com/users/bobtfish/followers","following_url":"https://api.github.com/users/bobtfish/following{/other_user}","gists_url":"https://api.github.com/users/bobtfish/gists{/gist_id}","starred_url":"https://api.github.com/users/bobtfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobtfish/subscriptions","organizations_url":"https://api.github.com/users/bobtfish/orgs","repos_url":"https://api.github.com/users/bobtfish/repos","events_url":"https://api.github.com/users/bobtfish/events{/privacy}","received_events_url":"https://api.github.com/users/bobtfish/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-09-22T20:59:20Z","updated_at":"2014-09-22T23:21:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"21d40b09632246fdf95a04de8d8246575b7dfbcf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/pulls/4/commits","review_comments_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/pulls/4/comments","review_comment_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/issues/4/comments","statuses_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/statuses/2b29f41a886a77a0e0e14d552a6215b99c1c2906","head":{"label":"Yelp:error_if_no_teams","ref":"error_if_no_teams","sha":"2b29f41a886a77a0e0e14d552a6215b99c1c2906","user":{"login":"Yelp","id":49071,"avatar_url":"https://avatars.githubusercontent.com/u/49071?v=2","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"repo":{"id":22772104,"name":"puppet-monitoring_check","full_name":"Yelp/puppet-monitoring_check","owner":{"login":"Yelp","id":49071,"avatar_url":"https://avatars.githubusercontent.com/u/49071?v=2","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Yelp/puppet-monitoring_check","description":"A Puppet module to create Sensu checks that use the Yelp Sensu Handlers for a multi-tenant environment","fork":false,"url":"https://api.github.com/repos/Yelp/puppet-monitoring_check","forks_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/forks","keys_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/teams","hooks_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/hooks","issue_events_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/issues/events{/number}","events_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/events","assignees_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/assignees{/user}","branches_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/branches{/branch}","tags_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/tags","blobs_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/statuses/{sha}","languages_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/languages","stargazers_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/stargazers","contributors_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/contributors","subscribers_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/subscribers","subscription_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/subscription","commits_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/issues/comments/{number}","contents_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/contents/{+path}","compare_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/merges","archive_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/downloads","issues_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/issues{/number}","pulls_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/pulls{/number}","milestones_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/milestones{/number}","notifications_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/labels{/name}","releases_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/releases{/id}","created_at":"2014-08-08T21:29:32Z","updated_at":"2014-09-13T19:35:02Z","pushed_at":"2014-09-22T23:21:36Z","git_url":"git://github.com/Yelp/puppet-monitoring_check.git","ssh_url":"git@github.com:Yelp/puppet-monitoring_check.git","clone_url":"https://github.com/Yelp/puppet-monitoring_check.git","svn_url":"https://github.com/Yelp/puppet-monitoring_check","homepage":null,"size":441,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Yelp:master","ref":"master","sha":"a6b37f45fe331969abcf98754e196fef47f3ce7e","user":{"login":"Yelp","id":49071,"avatar_url":"https://avatars.githubusercontent.com/u/49071?v=2","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"repo":{"id":22772104,"name":"puppet-monitoring_check","full_name":"Yelp/puppet-monitoring_check","owner":{"login":"Yelp","id":49071,"avatar_url":"https://avatars.githubusercontent.com/u/49071?v=2","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Yelp/puppet-monitoring_check","description":"A Puppet module to create Sensu checks that use the Yelp Sensu Handlers for a multi-tenant environment","fork":false,"url":"https://api.github.com/repos/Yelp/puppet-monitoring_check","forks_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/forks","keys_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/teams","hooks_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/hooks","issue_events_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/issues/events{/number}","events_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/events","assignees_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/assignees{/user}","branches_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/branches{/branch}","tags_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/tags","blobs_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/statuses/{sha}","languages_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/languages","stargazers_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/stargazers","contributors_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/contributors","subscribers_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/subscribers","subscription_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/subscription","commits_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/issues/comments/{number}","contents_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/contents/{+path}","compare_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/merges","archive_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/downloads","issues_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/issues{/number}","pulls_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/pulls{/number}","milestones_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/milestones{/number}","notifications_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/labels{/name}","releases_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/releases{/id}","created_at":"2014-08-08T21:29:32Z","updated_at":"2014-09-13T19:35:02Z","pushed_at":"2014-09-22T23:21:36Z","git_url":"git://github.com/Yelp/puppet-monitoring_check.git","ssh_url":"git@github.com:Yelp/puppet-monitoring_check.git","clone_url":"https://github.com/Yelp/puppet-monitoring_check.git","svn_url":"https://github.com/Yelp/puppet-monitoring_check","homepage":null,"size":441,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Yelp/puppet-monitoring_check/pulls/4"},"html":{"href":"https://github.com/Yelp/puppet-monitoring_check/pull/4"},"issue":{"href":"https://api.github.com/repos/Yelp/puppet-monitoring_check/issues/4"},"comments":{"href":"https://api.github.com/repos/Yelp/puppet-monitoring_check/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/Yelp/puppet-monitoring_check/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/Yelp/puppet-monitoring_check/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Yelp/puppet-monitoring_check/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/Yelp/puppet-monitoring_check/statuses/2b29f41a886a77a0e0e14d552a6215b99c1c2906"}}}}