GitHub PullRequestReviewCommentEvent at 2014-03-05 00:57:04
Repository: spark
Actor: CodingCat
Payload: {"comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/10283513","id":10283513,"diff_hunk":"@@ -847,6 +847,8 @@ class SparkContext(\n       partitions: Seq[Int],\n       allowLocal: Boolean,\n       resultHandler: (Int, U) => Unit) {\n+    require(partitions.toSet.diff(rdd.partitions.map(_.index).toSet).isEmpty,","path":"core/src/main/scala/org/apache/spark/SparkContext.scala","position":4,"original_position":4,"commit_id":"ac006a347dec32f7a92bd2117f2647c9e223c0ea","original_commit_id":"ac006a347dec32f7a92bd2117f2647c9e223c0ea","user":{"login":"CodingCat","id":678008,"avatar_url":"https://gravatar.com/avatar/c910df68df57e64403f80f5de7de3356?d=https%3A%2F%2Fidenticons.github.com%2F48ec299fc0c431ce75477afe4326631e.png&r=x","gravatar_id":"c910df68df57e64403f80f5de7de3356","url":"https://api.github.com/users/CodingCat","html_url":"https://github.com/CodingCat","followers_url":"https://api.github.com/users/CodingCat/followers","following_url":"https://api.github.com/users/CodingCat/following{/other_user}","gists_url":"https://api.github.com/users/CodingCat/gists{/gist_id}","starred_url":"https://api.github.com/users/CodingCat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodingCat/subscriptions","organizations_url":"https://api.github.com/users/CodingCat/orgs","repos_url":"https://api.github.com/users/CodingCat/repos","events_url":"https://api.github.com/users/CodingCat/events{/privacy}","received_events_url":"https://api.github.com/users/CodingCat/received_events","type":"User","site_admin":false},"body":"....still want to ask, why we have to do diff here, instead of just partitions.forall(rdd.partitions.map(_.index).contains), since we can ensure that the index space in RDD (at least for now) is always continuous.....","created_at":"2014-03-05T00:57:04Z","updated_at":"2014-03-05T00:57:04Z","html_url":"https://github.com/apache/spark/pull/44#discussion_r10283513","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/44","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/10283513"},"html":{"href":"https://github.com/apache/spark/pull/44#discussion_r10283513"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/44"}}}}