GitHub PullRequestReviewCommentEvent at 2014-06-06 19:39:24
Repository: akobi
Actor: jbrick
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/jivid/akobi/pulls/comments/13506880","id":13506880,"diff_hunk":"@@ -33,30 +33,32 @@ def open(self, interview_id):\n \n         self.write_message(utils.create_message(\"open_response\",\n                            self.client_id, self.interview_id))\n-        InterviewHandler.ongoing_interviews[interview_id].add(self)\n+        ongoing_interviews[interview_id].add(self)\n \n     def on_message(self, message):\n         message = json.loads(message)\n         log.debug(\"Received message from web socket. InterviewID %s\" %\n                   message['interviewID'])\n-        '''\n-        TODO (Divij): If message type is init add application to interview\n-        '''\n-\n-        '''\n-        TODO (Divij): Remove next two lines of code. Hack to make develop\n-        stable.\n-        '''\n-        registry.register_to_interview(message['interviewID'],\n-                                       utils.message_type_to_application_name(\n-                                       message[\"type\"]))\n-        registry.init_interview(message['interviewID'])\n+\n+        if message['type'] == \"init_interview\":\n+            log.debug(\"Initializing interview for client %s on interview %s\"\n+                      % (self.client_id, self.interview_id))\n+            Initializer.initialize(message['interviewID'], self)\n+\n+            '''\n+            TODO: Register application to interview on selection screen.\n+            '''\n+            registry.register_to_interview(self.interview_id, \"Heartbeat\")\n+            registry.register_to_interview(self.interview_id, \"Notes\")\n+\n+            registry.init_interview(message['interviewID'])","path":"handlers/interview.py","position":64,"original_position":64,"commit_id":"24f1c07aebc6c3284f58b60246829876a59e101d","original_commit_id":"24f1c07aebc6c3284f58b60246829876a59e101d","user":{"login":"jbrick","id":4588865,"avatar_url":"https://avatars.githubusercontent.com/u/4588865?","gravatar_id":"0289edee55e8ca122cdbfbf9fe7be38f","url":"https://api.github.com/users/jbrick","html_url":"https://github.com/jbrick","followers_url":"https://api.github.com/users/jbrick/followers","following_url":"https://api.github.com/users/jbrick/following{/other_user}","gists_url":"https://api.github.com/users/jbrick/gists{/gist_id}","starred_url":"https://api.github.com/users/jbrick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbrick/subscriptions","organizations_url":"https://api.github.com/users/jbrick/orgs","repos_url":"https://api.github.com/users/jbrick/repos","events_url":"https://api.github.com/users/jbrick/events{/privacy}","received_events_url":"https://api.github.com/users/jbrick/received_events","type":"User","site_admin":false},"body":"This gets run in the initialize I believe.","created_at":"2014-06-06T19:39:24Z","updated_at":"2014-06-06T19:39:24Z","html_url":"https://github.com/jivid/akobi/pull/51#discussion_r13506880","pull_request_url":"https://api.github.com/repos/jivid/akobi/pulls/51","_links":{"self":{"href":"https://api.github.com/repos/jivid/akobi/pulls/comments/13506880"},"html":{"href":"https://github.com/jivid/akobi/pull/51#discussion_r13506880"},"pull_request":{"href":"https://api.github.com/repos/jivid/akobi/pulls/51"}}},"pull_request":{"url":"https://api.github.com/repos/jivid/akobi/pulls/51","id":16837809,"html_url":"https://github.com/jivid/akobi/pull/51","diff_url":"https://github.com/jivid/akobi/pull/51.diff","patch_url":"https://github.com/jivid/akobi/pull/51.patch","issue_url":"https://api.github.com/repos/jivid/akobi/issues/51","number":51,"state":"open","title":"Divij/client message flow","user":{"login":"naturalwarren","id":1113225,"avatar_url":"https://avatars.githubusercontent.com/u/1113225?","gravatar_id":"d06820c1cba9ea557c69c705f70dbad7","url":"https://api.github.com/users/naturalwarren","html_url":"https://github.com/naturalwarren","followers_url":"https://api.github.com/users/naturalwarren/followers","following_url":"https://api.github.com/users/naturalwarren/following{/other_user}","gists_url":"https://api.github.com/users/naturalwarren/gists{/gist_id}","starred_url":"https://api.github.com/users/naturalwarren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naturalwarren/subscriptions","organizations_url":"https://api.github.com/users/naturalwarren/orgs","repos_url":"https://api.github.com/users/naturalwarren/repos","events_url":"https://api.github.com/users/naturalwarren/events{/privacy}","received_events_url":"https://api.github.com/users/naturalwarren/received_events","type":"User","site_admin":false},"body":"Wiring up application registration with client \"init_interview\" message.\r\n\r\nFor the time being we are hardcoding registered applications see line 52, 53 on interview.py. Registration via selection screen to follow.\r\n\r\nPEP8 Compliant. Tested notes and heartbeat application.","created_at":"2014-06-06T19:21:12Z","updated_at":"2014-06-06T19:39:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a61dba45d10dae0c343401821c96af4be587db1e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jivid/akobi/pulls/51/commits","review_comments_url":"https://api.github.com/repos/jivid/akobi/pulls/51/comments","review_comment_url":"https://api.github.com/repos/jivid/akobi/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jivid/akobi/issues/51/comments","statuses_url":"https://api.github.com/repos/jivid/akobi/statuses/24f1c07aebc6c3284f58b60246829876a59e101d","head":{"label":"jivid:divij/client_message_flow","ref":"divij/client_message_flow","sha":"24f1c07aebc6c3284f58b60246829876a59e101d","user":{"login":"jivid","id":2600370,"avatar_url":"https://avatars.githubusercontent.com/u/2600370?","gravatar_id":"145ec616115d230123ec35918f88d40f","url":"https://api.github.com/users/jivid","html_url":"https://github.com/jivid","followers_url":"https://api.github.com/users/jivid/followers","following_url":"https://api.github.com/users/jivid/following{/other_user}","gists_url":"https://api.github.com/users/jivid/gists{/gist_id}","starred_url":"https://api.github.com/users/jivid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jivid/subscriptions","organizations_url":"https://api.github.com/users/jivid/orgs","repos_url":"https://api.github.com/users/jivid/repos","events_url":"https://api.github.com/users/jivid/events{/privacy}","received_events_url":"https://api.github.com/users/jivid/received_events","type":"User","site_admin":false},"repo":{"id":19532383,"name":"akobi","full_name":"jivid/akobi","owner":{"login":"jivid","id":2600370,"avatar_url":"https://avatars.githubusercontent.com/u/2600370?","gravatar_id":"145ec616115d230123ec35918f88d40f","url":"https://api.github.com/users/jivid","html_url":"https://github.com/jivid","followers_url":"https://api.github.com/users/jivid/followers","following_url":"https://api.github.com/users/jivid/following{/other_user}","gists_url":"https://api.github.com/users/jivid/gists{/gist_id}","starred_url":"https://api.github.com/users/jivid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jivid/subscriptions","organizations_url":"https://api.github.com/users/jivid/orgs","repos_url":"https://api.github.com/users/jivid/repos","events_url":"https://api.github.com/users/jivid/events{/privacy}","received_events_url":"https://api.github.com/users/jivid/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jivid/akobi","description":"Akobi is a customizable interview application","fork":false,"url":"https://api.github.com/repos/jivid/akobi","forks_url":"https://api.github.com/repos/jivid/akobi/forks","keys_url":"https://api.github.com/repos/jivid/akobi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jivid/akobi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jivid/akobi/teams","hooks_url":"https://api.github.com/repos/jivid/akobi/hooks","issue_events_url":"https://api.github.com/repos/jivid/akobi/issues/events{/number}","events_url":"https://api.github.com/repos/jivid/akobi/events","assignees_url":"https://api.github.com/repos/jivid/akobi/assignees{/user}","branches_url":"https://api.github.com/repos/jivid/akobi/branches{/branch}","tags_url":"https://api.github.com/repos/jivid/akobi/tags","blobs_url":"https://api.github.com/repos/jivid/akobi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jivid/akobi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jivid/akobi/git/refs{/sha}","trees_url":"https://api.github.com/repos/jivid/akobi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jivid/akobi/statuses/{sha}","languages_url":"https://api.github.com/repos/jivid/akobi/languages","stargazers_url":"https://api.github.com/repos/jivid/akobi/stargazers","contributors_url":"https://api.github.com/repos/jivid/akobi/contributors","subscribers_url":"https://api.github.com/repos/jivid/akobi/subscribers","subscription_url":"https://api.github.com/repos/jivid/akobi/subscription","commits_url":"https://api.github.com/repos/jivid/akobi/commits{/sha}","git_commits_url":"https://api.github.com/repos/jivid/akobi/git/commits{/sha}","comments_url":"https://api.github.com/repos/jivid/akobi/comments{/number}","issue_comment_url":"https://api.github.com/repos/jivid/akobi/issues/comments/{number}","contents_url":"https://api.github.com/repos/jivid/akobi/contents/{+path}","compare_url":"https://api.github.com/repos/jivid/akobi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jivid/akobi/merges","archive_url":"https://api.github.com/repos/jivid/akobi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jivid/akobi/downloads","issues_url":"https://api.github.com/repos/jivid/akobi/issues{/number}","pulls_url":"https://api.github.com/repos/jivid/akobi/pulls{/number}","milestones_url":"https://api.github.com/repos/jivid/akobi/milestones{/number}","notifications_url":"https://api.github.com/repos/jivid/akobi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jivid/akobi/labels{/name}","releases_url":"https://api.github.com/repos/jivid/akobi/releases{/id}","created_at":"2014-05-07T11:44:48Z","updated_at":"2014-06-06T19:21:12Z","pushed_at":"2014-06-06T19:18:35Z","git_url":"git://github.com/jivid/akobi.git","ssh_url":"git@github.com:jivid/akobi.git","clone_url":"https://github.com/jivid/akobi.git","svn_url":"https://github.com/jivid/akobi","homepage":"","size":10297,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":15,"forks":0,"open_issues":15,"watchers":5,"default_branch":"develop"}},"base":{"label":"jivid:develop","ref":"develop","sha":"b983fa9f373fd08232bafe8ff80180be0cf04785","user":{"login":"jivid","id":2600370,"avatar_url":"https://avatars.githubusercontent.com/u/2600370?","gravatar_id":"145ec616115d230123ec35918f88d40f","url":"https://api.github.com/users/jivid","html_url":"https://github.com/jivid","followers_url":"https://api.github.com/users/jivid/followers","following_url":"https://api.github.com/users/jivid/following{/other_user}","gists_url":"https://api.github.com/users/jivid/gists{/gist_id}","starred_url":"https://api.github.com/users/jivid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jivid/subscriptions","organizations_url":"https://api.github.com/users/jivid/orgs","repos_url":"https://api.github.com/users/jivid/repos","events_url":"https://api.github.com/users/jivid/events{/privacy}","received_events_url":"https://api.github.com/users/jivid/received_events","type":"User","site_admin":false},"repo":{"id":19532383,"name":"akobi","full_name":"jivid/akobi","owner":{"login":"jivid","id":2600370,"avatar_url":"https://avatars.githubusercontent.com/u/2600370?","gravatar_id":"145ec616115d230123ec35918f88d40f","url":"https://api.github.com/users/jivid","html_url":"https://github.com/jivid","followers_url":"https://api.github.com/users/jivid/followers","following_url":"https://api.github.com/users/jivid/following{/other_user}","gists_url":"https://api.github.com/users/jivid/gists{/gist_id}","starred_url":"https://api.github.com/users/jivid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jivid/subscriptions","organizations_url":"https://api.github.com/users/jivid/orgs","repos_url":"https://api.github.com/users/jivid/repos","events_url":"https://api.github.com/users/jivid/events{/privacy}","received_events_url":"https://api.github.com/users/jivid/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jivid/akobi","description":"Akobi is a customizable interview application","fork":false,"url":"https://api.github.com/repos/jivid/akobi","forks_url":"https://api.github.com/repos/jivid/akobi/forks","keys_url":"https://api.github.com/repos/jivid/akobi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jivid/akobi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jivid/akobi/teams","hooks_url":"https://api.github.com/repos/jivid/akobi/hooks","issue_events_url":"https://api.github.com/repos/jivid/akobi/issues/events{/number}","events_url":"https://api.github.com/repos/jivid/akobi/events","assignees_url":"https://api.github.com/repos/jivid/akobi/assignees{/user}","branches_url":"https://api.github.com/repos/jivid/akobi/branches{/branch}","tags_url":"https://api.github.com/repos/jivid/akobi/tags","blobs_url":"https://api.github.com/repos/jivid/akobi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jivid/akobi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jivid/akobi/git/refs{/sha}","trees_url":"https://api.github.com/repos/jivid/akobi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jivid/akobi/statuses/{sha}","languages_url":"https://api.github.com/repos/jivid/akobi/languages","stargazers_url":"https://api.github.com/repos/jivid/akobi/stargazers","contributors_url":"https://api.github.com/repos/jivid/akobi/contributors","subscribers_url":"https://api.github.com/repos/jivid/akobi/subscribers","subscription_url":"https://api.github.com/repos/jivid/akobi/subscription","commits_url":"https://api.github.com/repos/jivid/akobi/commits{/sha}","git_commits_url":"https://api.github.com/repos/jivid/akobi/git/commits{/sha}","comments_url":"https://api.github.com/repos/jivid/akobi/comments{/number}","issue_comment_url":"https://api.github.com/repos/jivid/akobi/issues/comments/{number}","contents_url":"https://api.github.com/repos/jivid/akobi/contents/{+path}","compare_url":"https://api.github.com/repos/jivid/akobi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jivid/akobi/merges","archive_url":"https://api.github.com/repos/jivid/akobi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jivid/akobi/downloads","issues_url":"https://api.github.com/repos/jivid/akobi/issues{/number}","pulls_url":"https://api.github.com/repos/jivid/akobi/pulls{/number}","milestones_url":"https://api.github.com/repos/jivid/akobi/milestones{/number}","notifications_url":"https://api.github.com/repos/jivid/akobi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jivid/akobi/labels{/name}","releases_url":"https://api.github.com/repos/jivid/akobi/releases{/id}","created_at":"2014-05-07T11:44:48Z","updated_at":"2014-06-06T19:21:12Z","pushed_at":"2014-06-06T19:18:35Z","git_url":"git://github.com/jivid/akobi.git","ssh_url":"git@github.com:jivid/akobi.git","clone_url":"https://github.com/jivid/akobi.git","svn_url":"https://github.com/jivid/akobi","homepage":"","size":10297,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":15,"forks":0,"open_issues":15,"watchers":5,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/jivid/akobi/pulls/51"},"html":{"href":"https://github.com/jivid/akobi/pull/51"},"issue":{"href":"https://api.github.com/repos/jivid/akobi/issues/51"},"comments":{"href":"https://api.github.com/repos/jivid/akobi/issues/51/comments"},"review_comments":{"href":"https://api.github.com/repos/jivid/akobi/pulls/51/comments"},"review_comment":{"href":"https://api.github.com/repos/jivid/akobi/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jivid/akobi/pulls/51/commits"},"statuses":{"href":"https://api.github.com/repos/jivid/akobi/statuses/24f1c07aebc6c3284f58b60246829876a59e101d"}}}}