GitHub PullRequestReviewCommentEvent at 2014-06-29 02:16:19
Repository: ember-cli
Actor: rjackson
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/stefanpenner/ember-cli/pulls/comments/14327177","id":14327177,"diff_hunk":"@@ -16,6 +17,11 @@ module.exports = Command.extend({\n       // Display usage for all commands.\n       this.ui.write('Available commands in ember-cli:\\n');\n \n+      if(this.project.initializeAddons && this.project.addonCommands) {","path":"lib/commands/help.js","position":12,"original_position":12,"commit_id":"f09bba231dabc255ffb23d12f7e1098834e97084","original_commit_id":"ab64aaea7947635d2ad71b67e67a5e661e5d72d3","user":{"login":"rjackson","id":12637,"avatar_url":"https://avatars.githubusercontent.com/u/12637?","gravatar_id":"0dfd10ad198ae5a87640da046a77a90a","url":"https://api.github.com/users/rjackson","html_url":"https://github.com/rjackson","followers_url":"https://api.github.com/users/rjackson/followers","following_url":"https://api.github.com/users/rjackson/following{/other_user}","gists_url":"https://api.github.com/users/rjackson/gists{/gist_id}","starred_url":"https://api.github.com/users/rjackson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjackson/subscriptions","organizations_url":"https://api.github.com/users/rjackson/orgs","repos_url":"https://api.github.com/users/rjackson/repos","events_url":"https://api.github.com/users/rjackson/events{/privacy}","received_events_url":"https://api.github.com/users/rjackson/received_events","type":"User","site_admin":false},"body":"OK, gotcha.  This is OK with me then.  I would generally like to fix those other tests so we can avoid this check, but that is probably the subject for another PR.","created_at":"2014-06-29T02:16:19Z","updated_at":"2014-06-29T02:16:19Z","html_url":"https://github.com/stefanpenner/ember-cli/pull/1196#discussion_r14327177","pull_request_url":"https://api.github.com/repos/stefanpenner/ember-cli/pulls/1196","_links":{"self":{"href":"https://api.github.com/repos/stefanpenner/ember-cli/pulls/comments/14327177"},"html":{"href":"https://github.com/stefanpenner/ember-cli/pull/1196#discussion_r14327177"},"pull_request":{"href":"https://api.github.com/repos/stefanpenner/ember-cli/pulls/1196"}}},"pull_request":{"url":"https://api.github.com/repos/stefanpenner/ember-cli/pulls/1196","id":17743463,"html_url":"https://github.com/stefanpenner/ember-cli/pull/1196","diff_url":"https://github.com/stefanpenner/ember-cli/pull/1196.diff","patch_url":"https://github.com/stefanpenner/ember-cli/pull/1196.patch","issue_url":"https://api.github.com/repos/stefanpenner/ember-cli/issues/1196","number":1196,"state":"open","title":"Feature: Addons add commands to the CLI","user":{"login":"jakecraige","id":3799709,"avatar_url":"https://avatars.githubusercontent.com/u/3799709?","gravatar_id":"3936556ea5500c2edf892b80ad8e834e","url":"https://api.github.com/users/jakecraige","html_url":"https://github.com/jakecraige","followers_url":"https://api.github.com/users/jakecraige/followers","following_url":"https://api.github.com/users/jakecraige/following{/other_user}","gists_url":"https://api.github.com/users/jakecraige/gists{/gist_id}","starred_url":"https://api.github.com/users/jakecraige/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakecraige/subscriptions","organizations_url":"https://api.github.com/users/jakecraige/orgs","repos_url":"https://api.github.com/users/jakecraige/repos","events_url":"https://api.github.com/users/jakecraige/events{/privacy}","received_events_url":"https://api.github.com/users/jakecraige/received_events","type":"User","site_admin":false},"body":"You can now have your addon implement a `includedCommands` hook which returns an object that will be merged with ember-cli's default commands and passed into the Command.extend method for you.","created_at":"2014-06-29T02:07:06Z","updated_at":"2014-06-29T02:16:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d3db1596a4cd99b433b98264d2fa41f63d30264","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/stefanpenner/ember-cli/pulls/1196/commits","review_comments_url":"https://api.github.com/repos/stefanpenner/ember-cli/pulls/1196/comments","review_comment_url":"https://api.github.com/repos/stefanpenner/ember-cli/pulls/comments/{number}","comments_url":"https://api.github.com/repos/stefanpenner/ember-cli/issues/1196/comments","statuses_url":"https://api.github.com/repos/stefanpenner/ember-cli/statuses/f09bba231dabc255ffb23d12f7e1098834e97084","head":{"label":"jakecraige:feature/addon_commands","ref":"feature/addon_commands","sha":"f09bba231dabc255ffb23d12f7e1098834e97084","user":{"login":"jakecraige","id":3799709,"avatar_url":"https://avatars.githubusercontent.com/u/3799709?","gravatar_id":"3936556ea5500c2edf892b80ad8e834e","url":"https://api.github.com/users/jakecraige","html_url":"https://github.com/jakecraige","followers_url":"https://api.github.com/users/jakecraige/followers","following_url":"https://api.github.com/users/jakecraige/following{/other_user}","gists_url":"https://api.github.com/users/jakecraige/gists{/gist_id}","starred_url":"https://api.github.com/users/jakecraige/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakecraige/subscriptions","organizations_url":"https://api.github.com/users/jakecraige/orgs","repos_url":"https://api.github.com/users/jakecraige/repos","events_url":"https://api.github.com/users/jakecraige/events{/privacy}","received_events_url":"https://api.github.com/users/jakecraige/received_events","type":"User","site_admin":false},"repo":{"id":19720998,"name":"ember-cli","full_name":"jakecraige/ember-cli","owner":{"login":"jakecraige","id":3799709,"avatar_url":"https://avatars.githubusercontent.com/u/3799709?","gravatar_id":"3936556ea5500c2edf892b80ad8e834e","url":"https://api.github.com/users/jakecraige","html_url":"https://github.com/jakecraige","followers_url":"https://api.github.com/users/jakecraige/followers","following_url":"https://api.github.com/users/jakecraige/following{/other_user}","gists_url":"https://api.github.com/users/jakecraige/gists{/gist_id}","starred_url":"https://api.github.com/users/jakecraige/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakecraige/subscriptions","organizations_url":"https://api.github.com/users/jakecraige/orgs","repos_url":"https://api.github.com/users/jakecraige/repos","events_url":"https://api.github.com/users/jakecraige/events{/privacy}","received_events_url":"https://api.github.com/users/jakecraige/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jakecraige/ember-cli","description":"","fork":true,"url":"https://api.github.com/repos/jakecraige/ember-cli","forks_url":"https://api.github.com/repos/jakecraige/ember-cli/forks","keys_url":"https://api.github.com/repos/jakecraige/ember-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jakecraige/ember-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jakecraige/ember-cli/teams","hooks_url":"https://api.github.com/repos/jakecraige/ember-cli/hooks","issue_events_url":"https://api.github.com/repos/jakecraige/ember-cli/issues/events{/number}","events_url":"https://api.github.com/repos/jakecraige/ember-cli/events","assignees_url":"https://api.github.com/repos/jakecraige/ember-cli/assignees{/user}","branches_url":"https://api.github.com/repos/jakecraige/ember-cli/branches{/branch}","tags_url":"https://api.github.com/repos/jakecraige/ember-cli/tags","blobs_url":"https://api.github.com/repos/jakecraige/ember-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jakecraige/ember-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jakecraige/ember-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/jakecraige/ember-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jakecraige/ember-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/jakecraige/ember-cli/languages","stargazers_url":"https://api.github.com/repos/jakecraige/ember-cli/stargazers","contributors_url":"https://api.github.com/repos/jakecraige/ember-cli/contributors","subscribers_url":"https://api.github.com/repos/jakecraige/ember-cli/subscribers","subscription_url":"https://api.github.com/repos/jakecraige/ember-cli/subscription","commits_url":"https://api.github.com/repos/jakecraige/ember-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/jakecraige/ember-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/jakecraige/ember-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/jakecraige/ember-cli/issues/comments/{number}","contents_url":"https://api.github.com/repos/jakecraige/ember-cli/contents/{+path}","compare_url":"https://api.github.com/repos/jakecraige/ember-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jakecraige/ember-cli/merges","archive_url":"https://api.github.com/repos/jakecraige/ember-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jakecraige/ember-cli/downloads","issues_url":"https://api.github.com/repos/jakecraige/ember-cli/issues{/number}","pulls_url":"https://api.github.com/repos/jakecraige/ember-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/jakecraige/ember-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/jakecraige/ember-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jakecraige/ember-cli/labels{/name}","releases_url":"https://api.github.com/repos/jakecraige/ember-cli/releases{/id}","created_at":"2014-05-13T01:00:54Z","updated_at":"2014-05-29T01:39:14Z","pushed_at":"2014-06-29T02:08:27Z","git_url":"git://github.com/jakecraige/ember-cli.git","ssh_url":"git@github.com:jakecraige/ember-cli.git","clone_url":"https://github.com/jakecraige/ember-cli.git","svn_url":"https://github.com/jakecraige/ember-cli","homepage":null,"size":1314,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"stefanpenner:master","ref":"master","sha":"876be99dc3d8f0150c0bd1aadd9b781e83453da9","user":{"login":"stefanpenner","id":1377,"avatar_url":"https://avatars.githubusercontent.com/u/1377?","gravatar_id":"8ccebbc3d28f903d5c214efd3447ac71","url":"https://api.github.com/users/stefanpenner","html_url":"https://github.com/stefanpenner","followers_url":"https://api.github.com/users/stefanpenner/followers","following_url":"https://api.github.com/users/stefanpenner/following{/other_user}","gists_url":"https://api.github.com/users/stefanpenner/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanpenner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanpenner/subscriptions","organizations_url":"https://api.github.com/users/stefanpenner/orgs","repos_url":"https://api.github.com/users/stefanpenner/repos","events_url":"https://api.github.com/users/stefanpenner/events{/privacy}","received_events_url":"https://api.github.com/users/stefanpenner/received_events","type":"User","site_admin":false},"repo":{"id":14089735,"name":"ember-cli","full_name":"stefanpenner/ember-cli","owner":{"login":"stefanpenner","id":1377,"avatar_url":"https://avatars.githubusercontent.com/u/1377?","gravatar_id":"8ccebbc3d28f903d5c214efd3447ac71","url":"https://api.github.com/users/stefanpenner","html_url":"https://github.com/stefanpenner","followers_url":"https://api.github.com/users/stefanpenner/followers","following_url":"https://api.github.com/users/stefanpenner/following{/other_user}","gists_url":"https://api.github.com/users/stefanpenner/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanpenner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanpenner/subscriptions","organizations_url":"https://api.github.com/users/stefanpenner/orgs","repos_url":"https://api.github.com/users/stefanpenner/repos","events_url":"https://api.github.com/users/stefanpenner/events{/privacy}","received_events_url":"https://api.github.com/users/stefanpenner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stefanpenner/ember-cli","description":"","fork":false,"url":"https://api.github.com/repos/stefanpenner/ember-cli","forks_url":"https://api.github.com/repos/stefanpenner/ember-cli/forks","keys_url":"https://api.github.com/repos/stefanpenner/ember-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stefanpenner/ember-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stefanpenner/ember-cli/teams","hooks_url":"https://api.github.com/repos/stefanpenner/ember-cli/hooks","issue_events_url":"https://api.github.com/repos/stefanpenner/ember-cli/issues/events{/number}","events_url":"https://api.github.com/repos/stefanpenner/ember-cli/events","assignees_url":"https://api.github.com/repos/stefanpenner/ember-cli/assignees{/user}","branches_url":"https://api.github.com/repos/stefanpenner/ember-cli/branches{/branch}","tags_url":"https://api.github.com/repos/stefanpenner/ember-cli/tags","blobs_url":"https://api.github.com/repos/stefanpenner/ember-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stefanpenner/ember-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stefanpenner/ember-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/stefanpenner/ember-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stefanpenner/ember-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/stefanpenner/ember-cli/languages","stargazers_url":"https://api.github.com/repos/stefanpenner/ember-cli/stargazers","contributors_url":"https://api.github.com/repos/stefanpenner/ember-cli/contributors","subscribers_url":"https://api.github.com/repos/stefanpenner/ember-cli/subscribers","subscription_url":"https://api.github.com/repos/stefanpenner/ember-cli/subscription","commits_url":"https://api.github.com/repos/stefanpenner/ember-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/stefanpenner/ember-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/stefanpenner/ember-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/stefanpenner/ember-cli/issues/comments/{number}","contents_url":"https://api.github.com/repos/stefanpenner/ember-cli/contents/{+path}","compare_url":"https://api.github.com/repos/stefanpenner/ember-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stefanpenner/ember-cli/merges","archive_url":"https://api.github.com/repos/stefanpenner/ember-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stefanpenner/ember-cli/downloads","issues_url":"https://api.github.com/repos/stefanpenner/ember-cli/issues{/number}","pulls_url":"https://api.github.com/repos/stefanpenner/ember-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/stefanpenner/ember-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/stefanpenner/ember-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stefanpenner/ember-cli/labels{/name}","releases_url":"https://api.github.com/repos/stefanpenner/ember-cli/releases{/id}","created_at":"2013-11-03T17:34:43Z","updated_at":"2014-06-28T19:34:28Z","pushed_at":"2014-06-29T01:00:09Z","git_url":"git://github.com/stefanpenner/ember-cli.git","ssh_url":"git@github.com:stefanpenner/ember-cli.git","clone_url":"https://github.com/stefanpenner/ember-cli.git","svn_url":"https://github.com/stefanpenner/ember-cli","homepage":null,"size":18604,"stargazers_count":701,"watchers_count":701,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":208,"mirror_url":null,"open_issues_count":85,"forks":208,"open_issues":85,"watchers":701,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stefanpenner/ember-cli/pulls/1196"},"html":{"href":"https://github.com/stefanpenner/ember-cli/pull/1196"},"issue":{"href":"https://api.github.com/repos/stefanpenner/ember-cli/issues/1196"},"comments":{"href":"https://api.github.com/repos/stefanpenner/ember-cli/issues/1196/comments"},"review_comments":{"href":"https://api.github.com/repos/stefanpenner/ember-cli/pulls/1196/comments"},"review_comment":{"href":"https://api.github.com/repos/stefanpenner/ember-cli/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/stefanpenner/ember-cli/pulls/1196/commits"},"statuses":{"href":"https://api.github.com/repos/stefanpenner/ember-cli/statuses/f09bba231dabc255ffb23d12f7e1098834e97084"}}}}