GitHub PushEvent at 2014-01-03 18:48:31
Repository: puppet
Actor: kylog
Payload: {"shas":[["f879dbc935f8cfe4dcd32d7e31974c178b69b9d1","e3579b1e47f273529f0f929453e939a68ede9fd1@puppetlabs.com","(Maint) Remove duplicate test\n\nThere are other tests that use the module tool to search for modules.\nThis kind of check is better done in one of those where the system just\n\"has to work\" as part of some larger narrative arc.","Andrew Parker",true],["f5b2a41df41f3536b62a301a6ccdf7db73fb7ef7","e3579b1e47f273529f0f929453e939a68ede9fd1@puppetlabs.com","(PUP-672) Add acceptance test for trusted data\n\nThis adds a check that the certificate extensions show up as trusted\ndata. Does not yet pass as the feature isn't implemented yet.","Andrew Parker",true],["d0c6e41323d522ee9540a19f55e2a512cb066e09","e3579b1e47f273529f0f929453e939a68ede9fd1@puppetlabs.com","(Maint) Remove use of mocking\n\nUsing the mocks is not absolutely necessary in this case. It is easy to\nconstruct the certificate and using it makes it a little clearer what\nkind of object we are dealing with.","Andrew Parker",true],["46f330073399cb4887acd739244399be6806c160","e3579b1e47f273529f0f929453e939a68ede9fd1@puppetlabs.com","(PUP-672) Add nested context capabilities\n\nA major problem in puppet is keeping track of contextual information.\nThe Puppet::Indirector::Request attempts to do this, but it isn't able\nto pass that information between indirector requests. This adds a\nglobal context system, where once a value is set it cannot be changed,\nbut a subcontext can be created.","Andrew Parker",true],["8841654187b0101316264a10273ce3af812fbbd6","e3579b1e47f273529f0f929453e939a68ede9fd1@puppetlabs.com","(maint) Log exception using log_exception\n\nThe master application was not using Puppet.log_exception to log out any\nerrors that might occur during --compile. This meant that there was no\nbacktrace information available to diagnose the problem.","Andrew Parker",true],["33839964794557886310a675b4b9393c6d6328bd","e3579b1e47f273529f0f929453e939a68ede9fd1@puppetlabs.com","(PUP-672) Add defaults for context lookups\n\nBefore it wasn't possible to get a value from the context that might not\nhave the requested binding. This adds the ability to provide a default\nin the case where there is no finding for the name.","Andrew Parker",true],["a80015acf74b067760f9cbafc8cd23bc5b54306f","e3579b1e47f273529f0f929453e939a68ede9fd1@puppetlabs.com","(PUP-672) Track trusted information using the context\n\nThis pulls apart the indirector request and the trusted information. The\ntrusted information is stored in the Puppet::Context and overridden by\nthe remote request handler to allow the injection of various elements of\ntrusted information. The reason to separate it from the indirector\nrequest is because the indirector requests are hard to control, as they\nare contstructed from hashes of information passed around and\nmanipulated. This should provide a more straightforward mechanism for\nmanaging this kind of \"contextual\" information.","Andrew Parker",true],["a706fa30ae6be5dd5fcc3f539f31aa26cbccf42b","e3579b1e47f273529f0f929453e939a68ede9fd1@puppetlabs.com","(PUP-672) Provide certificate extensions as trusted data\n\nThis extends the trusted information that is exposed to the system and\nmanifests to include the certificate extensions that are part of the\ncertificate provided by the agent. Only the custom extensions that are\npart of the puppet extension arc are included.","Andrew Parker",true],["5f7fc89e7cc411f5e41f8692e3c2e3b922c6288f","e3579b1e47f273529f0f929453e939a68ede9fd1@puppetlabs.com","(PUP-672) Updated test to match trusted data structure\n\nDuring implementation of the trusted extensions the layout of the\ntrusted hash changed a little bit. This updates the acceptance test to\nreflect that and also changes it to be much more straightforward to\nread for the expected structure.","Andrew Parker",true],["7a1a025b380bad1fa6e9ad64b4909aa989f196dc","df6f0b2a1cc132c8326ed6a4a2fe90ec1147a191@puppetlabs.com","(PUP-672) Puppet::Context is immutable.\n\nPrevious implementation exposed a bind method allowing you to add\nbindings to the current context. This method has been removed. Now\nevery context is generated only once, either from an initial push or\noverride, both of which require a hash of bindings which are merged into\nthe parent's binding state.","Josh Partlow",true],["d288d689514c9355ad5dff4800973b1eb8c5a4ef","df6f0b2a1cc132c8326ed6a4a2fe90ec1147a191@puppetlabs.com","(PUP-672) Move TrustedInformation into Puppet::Context\n\nThis is just a refactor putting Puppet::Indirector::TrustedInformation\ninto the Puppet::Context module instead.","Josh Partlow",true],["3b4e5cba35668893ee7edd333c5e6e8fcedd3385","c028c213ed5efcf30c3f4fc7361dbde0c893c5b7@puppetlabs.com","(PUP-1255) Don't be sensitive to pseudo-inherited ACEs\n\nPreviously, the test would fail on Windows 2012, as the access control\nentries in the Temp directory's DACL are missing the INHERITED_ACE bit:\n\n    > setacl -on  temp -ot file -actn list  -lst \"f:tab;w:d,s,o,g;i:y\"\n    temp\n\n    Owner: WIN-61G7FSKJ7JI\\josh\n    Group: WIN-61G7FSKJ7JI\\None\n    DACL(not_protected):\n    NT AUTHORITY\\SYSTEM    full   allow container_inherit+object_inherit\n    BUILTIN\\Administrators full   allow container_inherit+object_inherit\n    WIN-61G7FSKJ7JI\\josh   full   allow container_inherit+object_inherit\n\nNote how none of the entries granting 'full' access are \"inherited\".\n\nThe test creates two empty temp files (the source is generated in the\ncall to Puppet::Util.replace_file) each with permissions:\n\n    WIN-61G7FSKJ7JI\\josh\n    WIN-61G7FSKJ7JI\\None\n      NT AUTHORITY\\SYSTEM:(I)                       0x1f01ff\n      BUILTIN\\Administrators:(I)                    0x1f01ff\n      WIN-61G7FSKJ7JI\\josh:(I)                      0x1f01ff\n\nEach ACE is inherited and grants full access as expected. But when the Win32\nAPI `ReplaceFile` is called, it prepends non-inherited ACEs to the destination\nfile:\n\n    WIN-61G7FSKJ7JI\\josh\n    WIN-61G7FSKJ7JI\\None\n      NT AUTHORITY\\SYSTEM:                          0x1f01ff\n      BUILTIN\\Administrators:                       0x1f01ff\n      WIN-61G7FSKJ7JI\\josh:                         0x1f01ff\n      NT AUTHORITY\\SYSTEM:(I)                       0x1f01ff\n      BUILTIN\\Administrators:(I)                    0x1f01ff\n      WIN-61G7FSKJ7JI\\josh:(I)                      0x1f01ff\n\nWhile the merging behavior is unexpected, it doesn't alter the effective\nsecurity of the file.\n\nThis commit marks the directory as protected, which breaks inheritance\nat that point. As a result, ReplaceFile behaves as expected.\n\nAlso note that if the Temp ACLs are reset recursively:\n\n    icacls Temp /reset /t\n\nThen the merging behavior does not occur and the test passes (without\nthis commit).\n\nSee also pseudo-inherited ACEs:\nhttp://helgeklein.com/setacl/faq/#what-are-pseudo-protected-acls-and-pseudo-inherited-aces-setacl-2-1","Josh Cooper",false],["d58c7f04bb47b8cfce7731e3dc9286a57ee8d352","7cdd076e25adef0e25d3fedc5490d7fb59f5b1c0@puppetlabs.com","(maint) Add temp workaround for travis\n\nRubygems broke travis builds on ruby 1.8.7:\n\nhttps://github.com/travis-ci/travis-ci/issues/1793\nhttps://github.com/rubygems/rubygems/pull/763\n\nThis patch is a temporary workaround until rubygems is\nupdated.","Kylo Ginsberg",false],["a4af858e8e39f874b77a780f93558f7e89c25ff3","2517f7f46b9b5171a848d2bcbaa230e88b7ea36a@gmail.com","Merge remote-tracking branch 'joshcooper/issue/stable/pup-1255-windows-2012' into stable","Rob Reynolds",false],["59b13da45717ca55321cc70a68125d549421c516","df6f0b2a1cc132c8326ed6a4a2fe90ec1147a191@puppetlabs.com","(PUP-672) Fail fast if pop root of Context stack\n\nRather than silently accept a root pop and return the root binding, fail\nfast with a StackUnderflow exception if attempt to pop the root of\nPuppet::Context.","Josh Partlow",true],["d42c1e61b06f716bd0c4b252ec59a496af6f8f98","2517f7f46b9b5171a848d2bcbaa230e88b7ea36a@gmail.com","Merge branch 'stable'","Rob Reynolds",true],["e5c31dea07e7628de75102ecafe630498713a1fd","8b9a6d929adb31c4396b7c3190a692c2499625ce@glatisant.org","Merge pull request #2210 from jpartlow/feature/master/pup-672-csr-extensions-as-trusted\n\nFeature/master/pup 672 csr extensions as trusted","Josh Partlow",true],["1004eaea5cd5fcadcd94709c5a4d314e3f297cef","df6f0b2a1cc132c8326ed6a4a2fe90ec1147a191@puppetlabs.com","(PUP-724,#21922) Autoload compares only integer secs\n\nAlthough the ultimate reasons have not been tracked down, there have\nbeen occasions where the Puppet::Util::Autoload.changed? method will\nerroneously report that a file has changed based on an mtime having\nseemed to change nsecs, despite no evidence of this being seen in the\nfile system.\n\nThe previous implementation was comparing mtime (Ruby Time instances)\nand the nsecs seem to be volatile under unknown conditions. When it does\nbreak, this was manifesting as a failure to autoload\npuppet/util/instrumentation/listeners/log.rb (the instrumentation code\nis relying on Puppet::Util::Autoload for initial loading but does not\nexpect its listeners to be reloaded, and they are not written in such a\nway as to be reloadable...) (see PUP-724 and its associated tickets for\ndetails).\n\nThe work around is to instead just compare integer secs.","Josh Partlow",true],["917cc40943441c7737036d84646c1a449efff2ee","a79ee7b20049521431fe879d8553375a09812d76@puppetlabs.com","Merge pull request #2214 from jpartlow/issue/master/pup-724-autoload-mtime-test\n\n(PUP-724,#21922) Autoload compares only integer secs","Josh Cooper",true],["98e9219a4d4d9c2a70e36a9700c9701cd1049f20","df6f0b2a1cc132c8326ed6a4a2fe90ec1147a191@puppetlabs.com","(PUP-724,#21922) Autoload compares only integer secs\n\nAlthough the ultimate reasons have not been tracked down, there have\nbeen occasions where the Puppet::Util::Autoload.changed? method will\nerroneously report that a file has changed based on an mtime having\nseemed to change nsecs, despite no evidence of this being seen in the\nfile system.\n\nThe previous implementation was comparing mtime (Ruby Time instances)\nand the nsecs seem to be volatile under unknown conditions. When it does\nbreak, this was manifesting as a failure to autoload\npuppet/util/instrumentation/listeners/log.rb (the instrumentation code\nis relying on Puppet::Util::Autoload for initial loading but does not\nexpect its listeners to be reloaded, and they are not written in such a\nway as to be reloadable...) (see PUP-724 and its associated tickets for\ndetails).\n\nThe work around is to instead just compare integer secs.","Josh Partlow",false]],"size":21,"ref":"refs/heads/master","head":"f4cd4f21a3563325f3cea437b0e7979144698ab1"}