GitHub PullRequestEvent at 2014-05-29 07:25:59
Repository: cocos2d-x
Actor: minggo
Payload: {"action":"closed","number":6657,"pull_request":{"url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/6657","id":15729222,"html_url":"https://github.com/cocos2d/cocos2d-x/pull/6657","diff_url":"https://github.com/cocos2d/cocos2d-x/pull/6657.diff","patch_url":"https://github.com/cocos2d/cocos2d-x/pull/6657.patch","issue_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/6657","number":6657,"state":"closed","title":"Fixing cmake project for win32","user":{"login":"asmodehn","id":221256,"avatar_url":"https://avatars.githubusercontent.com/u/221256?","gravatar_id":"4760982bce87813e29fbac9630499ca9","url":"https://api.github.com/users/asmodehn","html_url":"https://github.com/asmodehn","followers_url":"https://api.github.com/users/asmodehn/followers","following_url":"https://api.github.com/users/asmodehn/following{/other_user}","gists_url":"https://api.github.com/users/asmodehn/gists{/gist_id}","starred_url":"https://api.github.com/users/asmodehn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asmodehn/subscriptions","organizations_url":"https://api.github.com/users/asmodehn/orgs","repos_url":"https://api.github.com/users/asmodehn/repos","events_url":"https://api.github.com/users/asmodehn/events{/privacy}","received_events_url":"https://api.github.com/users/asmodehn/received_events","type":"User","site_admin":false},"body":"The cmakelists that I tested worked on linux but not on win32.\r\nI made small fixes to get it to work on win32 platform.\r\n\r\nThis probably needs more thorough testing, to make sure nothing is broken on other platforms where it is supposed to work but that I couldnt test on.","created_at":"2014-05-10T01:22:06Z","updated_at":"2014-05-29T07:25:58Z","closed_at":"2014-05-29T07:25:58Z","merged_at":"2014-05-29T07:25:58Z","merge_commit_sha":"431657146199c7a3c1633b04eb482be0443bf481","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/6657/commits","review_comments_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/6657/comments","review_comment_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/comments/{number}","comments_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/6657/comments","statuses_url":"https://api.github.com/repos/cocos2d/cocos2d-x/statuses/234c902630ae5a6a674c9c4babef7fabbbc38422","head":{"label":"asmodehn:asmo_newv3_cmake_win32","ref":"asmo_newv3_cmake_win32","sha":"234c902630ae5a6a674c9c4babef7fabbbc38422","user":{"login":"asmodehn","id":221256,"avatar_url":"https://avatars.githubusercontent.com/u/221256?","gravatar_id":"4760982bce87813e29fbac9630499ca9","url":"https://api.github.com/users/asmodehn","html_url":"https://github.com/asmodehn","followers_url":"https://api.github.com/users/asmodehn/followers","following_url":"https://api.github.com/users/asmodehn/following{/other_user}","gists_url":"https://api.github.com/users/asmodehn/gists{/gist_id}","starred_url":"https://api.github.com/users/asmodehn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asmodehn/subscriptions","organizations_url":"https://api.github.com/users/asmodehn/orgs","repos_url":"https://api.github.com/users/asmodehn/repos","events_url":"https://api.github.com/users/asmodehn/events{/privacy}","received_events_url":"https://api.github.com/users/asmodehn/received_events","type":"User","site_admin":false},"repo":{"id":15574850,"name":"cocos2d-x","full_name":"asmodehn/cocos2d-x","owner":{"login":"asmodehn","id":221256,"avatar_url":"https://avatars.githubusercontent.com/u/221256?","gravatar_id":"4760982bce87813e29fbac9630499ca9","url":"https://api.github.com/users/asmodehn","html_url":"https://github.com/asmodehn","followers_url":"https://api.github.com/users/asmodehn/followers","following_url":"https://api.github.com/users/asmodehn/following{/other_user}","gists_url":"https://api.github.com/users/asmodehn/gists{/gist_id}","starred_url":"https://api.github.com/users/asmodehn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asmodehn/subscriptions","organizations_url":"https://api.github.com/users/asmodehn/orgs","repos_url":"https://api.github.com/users/asmodehn/repos","events_url":"https://api.github.com/users/asmodehn/events{/privacy}","received_events_url":"https://api.github.com/users/asmodehn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/asmodehn/cocos2d-x","description":"cocos2d for iOS, Android, Win32 and OS X. Built using C++","fork":true,"url":"https://api.github.com/repos/asmodehn/cocos2d-x","forks_url":"https://api.github.com/repos/asmodehn/cocos2d-x/forks","keys_url":"https://api.github.com/repos/asmodehn/cocos2d-x/keys{/key_id}","collaborators_url":"https://api.github.com/repos/asmodehn/cocos2d-x/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/asmodehn/cocos2d-x/teams","hooks_url":"https://api.github.com/repos/asmodehn/cocos2d-x/hooks","issue_events_url":"https://api.github.com/repos/asmodehn/cocos2d-x/issues/events{/number}","events_url":"https://api.github.com/repos/asmodehn/cocos2d-x/events","assignees_url":"https://api.github.com/repos/asmodehn/cocos2d-x/assignees{/user}","branches_url":"https://api.github.com/repos/asmodehn/cocos2d-x/branches{/branch}","tags_url":"https://api.github.com/repos/asmodehn/cocos2d-x/tags","blobs_url":"https://api.github.com/repos/asmodehn/cocos2d-x/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/asmodehn/cocos2d-x/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/asmodehn/cocos2d-x/git/refs{/sha}","trees_url":"https://api.github.com/repos/asmodehn/cocos2d-x/git/trees{/sha}","statuses_url":"https://api.github.com/repos/asmodehn/cocos2d-x/statuses/{sha}","languages_url":"https://api.github.com/repos/asmodehn/cocos2d-x/languages","stargazers_url":"https://api.github.com/repos/asmodehn/cocos2d-x/stargazers","contributors_url":"https://api.github.com/repos/asmodehn/cocos2d-x/contributors","subscribers_url":"https://api.github.com/repos/asmodehn/cocos2d-x/subscribers","subscription_url":"https://api.github.com/repos/asmodehn/cocos2d-x/subscription","commits_url":"https://api.github.com/repos/asmodehn/cocos2d-x/commits{/sha}","git_commits_url":"https://api.github.com/repos/asmodehn/cocos2d-x/git/commits{/sha}","comments_url":"https://api.github.com/repos/asmodehn/cocos2d-x/comments{/number}","issue_comment_url":"https://api.github.com/repos/asmodehn/cocos2d-x/issues/comments/{number}","contents_url":"https://api.github.com/repos/asmodehn/cocos2d-x/contents/{+path}","compare_url":"https://api.github.com/repos/asmodehn/cocos2d-x/compare/{base}...{head}","merges_url":"https://api.github.com/repos/asmodehn/cocos2d-x/merges","archive_url":"https://api.github.com/repos/asmodehn/cocos2d-x/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/asmodehn/cocos2d-x/downloads","issues_url":"https://api.github.com/repos/asmodehn/cocos2d-x/issues{/number}","pulls_url":"https://api.github.com/repos/asmodehn/cocos2d-x/pulls{/number}","milestones_url":"https://api.github.com/repos/asmodehn/cocos2d-x/milestones{/number}","notifications_url":"https://api.github.com/repos/asmodehn/cocos2d-x/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/asmodehn/cocos2d-x/labels{/name}","releases_url":"https://api.github.com/repos/asmodehn/cocos2d-x/releases{/id}","created_at":"2014-01-02T03:21:20Z","updated_at":"2014-05-29T07:25:58Z","pushed_at":"2014-05-27T09:12:50Z","git_url":"git://github.com/asmodehn/cocos2d-x.git","ssh_url":"git@github.com:asmodehn/cocos2d-x.git","clone_url":"https://github.com/asmodehn/cocos2d-x.git","svn_url":"https://github.com/asmodehn/cocos2d-x","homepage":"http://www.cocos2d-x.org","size":810619,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"asmo_v3"}},"base":{"label":"cocos2d:v3","ref":"v3","sha":"f36f224d46b15a09af3fb1640e3f06fc5add69f7","user":{"login":"cocos2d","id":234324,"avatar_url":"https://avatars.githubusercontent.com/u/234324?","gravatar_id":"2c474191a9930625c01a6752b40ebf72","url":"https://api.github.com/users/cocos2d","html_url":"https://github.com/cocos2d","followers_url":"https://api.github.com/users/cocos2d/followers","following_url":"https://api.github.com/users/cocos2d/following{/other_user}","gists_url":"https://api.github.com/users/cocos2d/gists{/gist_id}","starred_url":"https://api.github.com/users/cocos2d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocos2d/subscriptions","organizations_url":"https://api.github.com/users/cocos2d/orgs","repos_url":"https://api.github.com/users/cocos2d/repos","events_url":"https://api.github.com/users/cocos2d/events{/privacy}","received_events_url":"https://api.github.com/users/cocos2d/received_events","type":"Organization","site_admin":false},"repo":{"id":1093228,"name":"cocos2d-x","full_name":"cocos2d/cocos2d-x","owner":{"login":"cocos2d","id":234324,"avatar_url":"https://avatars.githubusercontent.com/u/234324?","gravatar_id":"2c474191a9930625c01a6752b40ebf72","url":"https://api.github.com/users/cocos2d","html_url":"https://github.com/cocos2d","followers_url":"https://api.github.com/users/cocos2d/followers","following_url":"https://api.github.com/users/cocos2d/following{/other_user}","gists_url":"https://api.github.com/users/cocos2d/gists{/gist_id}","starred_url":"https://api.github.com/users/cocos2d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocos2d/subscriptions","organizations_url":"https://api.github.com/users/cocos2d/orgs","repos_url":"https://api.github.com/users/cocos2d/repos","events_url":"https://api.github.com/users/cocos2d/events{/privacy}","received_events_url":"https://api.github.com/users/cocos2d/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cocos2d/cocos2d-x","description":"cocos2d-x for C++","fork":false,"url":"https://api.github.com/repos/cocos2d/cocos2d-x","forks_url":"https://api.github.com/repos/cocos2d/cocos2d-x/forks","keys_url":"https://api.github.com/repos/cocos2d/cocos2d-x/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cocos2d/cocos2d-x/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cocos2d/cocos2d-x/teams","hooks_url":"https://api.github.com/repos/cocos2d/cocos2d-x/hooks","issue_events_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/events{/number}","events_url":"https://api.github.com/repos/cocos2d/cocos2d-x/events","assignees_url":"https://api.github.com/repos/cocos2d/cocos2d-x/assignees{/user}","branches_url":"https://api.github.com/repos/cocos2d/cocos2d-x/branches{/branch}","tags_url":"https://api.github.com/repos/cocos2d/cocos2d-x/tags","blobs_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/refs{/sha}","trees_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cocos2d/cocos2d-x/statuses/{sha}","languages_url":"https://api.github.com/repos/cocos2d/cocos2d-x/languages","stargazers_url":"https://api.github.com/repos/cocos2d/cocos2d-x/stargazers","contributors_url":"https://api.github.com/repos/cocos2d/cocos2d-x/contributors","subscribers_url":"https://api.github.com/repos/cocos2d/cocos2d-x/subscribers","subscription_url":"https://api.github.com/repos/cocos2d/cocos2d-x/subscription","commits_url":"https://api.github.com/repos/cocos2d/cocos2d-x/commits{/sha}","git_commits_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/commits{/sha}","comments_url":"https://api.github.com/repos/cocos2d/cocos2d-x/comments{/number}","issue_comment_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/comments/{number}","contents_url":"https://api.github.com/repos/cocos2d/cocos2d-x/contents/{+path}","compare_url":"https://api.github.com/repos/cocos2d/cocos2d-x/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cocos2d/cocos2d-x/merges","archive_url":"https://api.github.com/repos/cocos2d/cocos2d-x/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cocos2d/cocos2d-x/downloads","issues_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues{/number}","pulls_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls{/number}","milestones_url":"https://api.github.com/repos/cocos2d/cocos2d-x/milestones{/number}","notifications_url":"https://api.github.com/repos/cocos2d/cocos2d-x/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cocos2d/cocos2d-x/labels{/name}","releases_url":"https://api.github.com/repos/cocos2d/cocos2d-x/releases{/id}","created_at":"2010-11-18T23:17:00Z","updated_at":"2014-05-29T07:25:58Z","pushed_at":"2014-05-29T07:25:58Z","git_url":"git://github.com/cocos2d/cocos2d-x.git","ssh_url":"git@github.com:cocos2d/cocos2d-x.git","clone_url":"https://github.com/cocos2d/cocos2d-x.git","svn_url":"https://github.com/cocos2d/cocos2d-x","homepage":"http://www.cocos2d-x.org","size":1111690,"stargazers_count":3617,"watchers_count":3617,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":2631,"mirror_url":null,"open_issues_count":126,"forks":2631,"open_issues":126,"watchers":3617,"default_branch":"v3"}},"_links":{"self":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/6657"},"html":{"href":"https://github.com/cocos2d/cocos2d-x/pull/6657"},"issue":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/6657"},"comments":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/6657/comments"},"review_comments":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/6657/comments"},"review_comment":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/6657/commits"},"statuses":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/statuses/234c902630ae5a6a674c9c4babef7fabbbc38422"}},"merged":true,"mergeable":true,"mergeable_state":"clean","merged_by":{"login":"minggo","id":488203,"avatar_url":"https://avatars.githubusercontent.com/u/488203?","gravatar_id":"69efdc94ffdebdd556c3826b6f1afe8f","url":"https://api.github.com/users/minggo","html_url":"https://github.com/minggo","followers_url":"https://api.github.com/users/minggo/followers","following_url":"https://api.github.com/users/minggo/following{/other_user}","gists_url":"https://api.github.com/users/minggo/gists{/gist_id}","starred_url":"https://api.github.com/users/minggo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minggo/subscriptions","organizations_url":"https://api.github.com/users/minggo/orgs","repos_url":"https://api.github.com/users/minggo/repos","events_url":"https://api.github.com/users/minggo/events{/privacy}","received_events_url":"https://api.github.com/users/minggo/received_events","type":"User","site_admin":false},"comments":2,"review_comments":3,"commits":5,"additions":134,"deletions":20,"changed_files":3}}