GitHub PullRequestReviewCommentEvent at 2014-06-18 07:01:25
Repository: rspec-expectations
Actor: AgentAntelope
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/rspec/rspec-expectations/pulls/comments/13901747","id":13901747,"diff_hunk":"@@ -298,6 +298,9 @@ class ChangeDetails\n         attr_reader :message, :actual_before, :actual_after\n \n         def initialize(receiver=nil, message=nil, &block)\n+          if receiver && !message\n+            raise ArgumentError, 'expected result to have changed, but was not given a message for the receiver'","path":"lib/rspec/matchers/built_in/change.rb","position":5,"original_position":5,"commit_id":"d388e92d3d98a194b9ed002a4386954ce17b6c04","original_commit_id":"d388e92d3d98a194b9ed002a4386954ce17b6c04","user":{"login":"AgentAntelope","id":1962412,"avatar_url":"https://avatars.githubusercontent.com/u/1962412?","gravatar_id":"c01b8452d19e666df77fad5d346e0aa7","url":"https://api.github.com/users/AgentAntelope","html_url":"https://github.com/AgentAntelope","followers_url":"https://api.github.com/users/AgentAntelope/followers","following_url":"https://api.github.com/users/AgentAntelope/following{/other_user}","gists_url":"https://api.github.com/users/AgentAntelope/gists{/gist_id}","starred_url":"https://api.github.com/users/AgentAntelope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AgentAntelope/subscriptions","organizations_url":"https://api.github.com/users/AgentAntelope/orgs","repos_url":"https://api.github.com/users/AgentAntelope/repos","events_url":"https://api.github.com/users/AgentAntelope/events{/privacy}","received_events_url":"https://api.github.com/users/AgentAntelope/received_events","type":"User","site_admin":false},"body":"Sounds good, I'll update that now.","created_at":"2014-06-18T07:01:25Z","updated_at":"2014-06-18T07:01:25Z","html_url":"https://github.com/rspec/rspec-expectations/pull/585#discussion_r13901747","pull_request_url":"https://api.github.com/repos/rspec/rspec-expectations/pulls/585","_links":{"self":{"href":"https://api.github.com/repos/rspec/rspec-expectations/pulls/comments/13901747"},"html":{"href":"https://github.com/rspec/rspec-expectations/pull/585#discussion_r13901747"},"pull_request":{"href":"https://api.github.com/repos/rspec/rspec-expectations/pulls/585"}}},"pull_request":{"url":"https://api.github.com/repos/rspec/rspec-expectations/pulls/585","id":17262156,"html_url":"https://github.com/rspec/rspec-expectations/pull/585","diff_url":"https://github.com/rspec/rspec-expectations/pull/585.diff","patch_url":"https://github.com/rspec/rspec-expectations/pull/585.patch","issue_url":"https://api.github.com/repos/rspec/rspec-expectations/issues/585","number":585,"state":"open","title":"Add more helpful error message for `change`.","user":{"login":"AgentAntelope","id":1962412,"avatar_url":"https://avatars.githubusercontent.com/u/1962412?","gravatar_id":"c01b8452d19e666df77fad5d346e0aa7","url":"https://api.github.com/users/AgentAntelope","html_url":"https://github.com/AgentAntelope","followers_url":"https://api.github.com/users/AgentAntelope/followers","following_url":"https://api.github.com/users/AgentAntelope/following{/other_user}","gists_url":"https://api.github.com/users/AgentAntelope/gists{/gist_id}","starred_url":"https://api.github.com/users/AgentAntelope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AgentAntelope/subscriptions","organizations_url":"https://api.github.com/users/AgentAntelope/orgs","repos_url":"https://api.github.com/users/AgentAntelope/repos","events_url":"https://api.github.com/users/AgentAntelope/events{/privacy}","received_events_url":"https://api.github.com/users/AgentAntelope/received_events","type":"User","site_admin":false},"body":"When change was called with a single argument and no block, the\r\nmessage to be sent to the receiver defaulted to nil, causing an\r\nunclear failure message.\r\n\r\nFixes #584.","created_at":"2014-06-17T21:19:38Z","updated_at":"2014-06-18T07:01:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7a8939d9df3a3c50c0da7f8812438852ebbbbdfb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rspec/rspec-expectations/pulls/585/commits","review_comments_url":"https://api.github.com/repos/rspec/rspec-expectations/pulls/585/comments","review_comment_url":"https://api.github.com/repos/rspec/rspec-expectations/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rspec/rspec-expectations/issues/585/comments","statuses_url":"https://api.github.com/repos/rspec/rspec-expectations/statuses/d388e92d3d98a194b9ed002a4386954ce17b6c04","head":{"label":"AgentAntelope:master","ref":"master","sha":"d388e92d3d98a194b9ed002a4386954ce17b6c04","user":{"login":"AgentAntelope","id":1962412,"avatar_url":"https://avatars.githubusercontent.com/u/1962412?","gravatar_id":"c01b8452d19e666df77fad5d346e0aa7","url":"https://api.github.com/users/AgentAntelope","html_url":"https://github.com/AgentAntelope","followers_url":"https://api.github.com/users/AgentAntelope/followers","following_url":"https://api.github.com/users/AgentAntelope/following{/other_user}","gists_url":"https://api.github.com/users/AgentAntelope/gists{/gist_id}","starred_url":"https://api.github.com/users/AgentAntelope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AgentAntelope/subscriptions","organizations_url":"https://api.github.com/users/AgentAntelope/orgs","repos_url":"https://api.github.com/users/AgentAntelope/repos","events_url":"https://api.github.com/users/AgentAntelope/events{/privacy}","received_events_url":"https://api.github.com/users/AgentAntelope/received_events","type":"User","site_admin":false},"repo":{"id":20939634,"name":"rspec-expectations","full_name":"AgentAntelope/rspec-expectations","owner":{"login":"AgentAntelope","id":1962412,"avatar_url":"https://avatars.githubusercontent.com/u/1962412?","gravatar_id":"c01b8452d19e666df77fad5d346e0aa7","url":"https://api.github.com/users/AgentAntelope","html_url":"https://github.com/AgentAntelope","followers_url":"https://api.github.com/users/AgentAntelope/followers","following_url":"https://api.github.com/users/AgentAntelope/following{/other_user}","gists_url":"https://api.github.com/users/AgentAntelope/gists{/gist_id}","starred_url":"https://api.github.com/users/AgentAntelope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AgentAntelope/subscriptions","organizations_url":"https://api.github.com/users/AgentAntelope/orgs","repos_url":"https://api.github.com/users/AgentAntelope/repos","events_url":"https://api.github.com/users/AgentAntelope/events{/privacy}","received_events_url":"https://api.github.com/users/AgentAntelope/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AgentAntelope/rspec-expectations","description":"Provides a simple, readable API to express expected outcomes of a code example","fork":true,"url":"https://api.github.com/repos/AgentAntelope/rspec-expectations","forks_url":"https://api.github.com/repos/AgentAntelope/rspec-expectations/forks","keys_url":"https://api.github.com/repos/AgentAntelope/rspec-expectations/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AgentAntelope/rspec-expectations/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AgentAntelope/rspec-expectations/teams","hooks_url":"https://api.github.com/repos/AgentAntelope/rspec-expectations/hooks","issue_events_url":"https://api.github.com/repos/AgentAntelope/rspec-expectations/issues/events{/number}","events_url":"https://api.github.com/repos/AgentAntelope/rspec-expectations/events","assignees_url":"https://api.github.com/repos/AgentAntelope/rspec-expectations/assignees{/user}","branches_url":"https://api.github.com/repos/AgentAntelope/rspec-expectations/branches{/branch}","tags_url":"https://api.github.com/repos/AgentAntelope/rspec-expectations/tags","blobs_url":"https://api.github.com/repos/AgentAntelope/rspec-expectations/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AgentAntelope/rspec-expectations/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AgentAntelope/rspec-expectations/git/refs{/sha}","trees_url":"https://api.github.com/repos/AgentAntelope/rspec-expectations/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AgentAntelope/rspec-expectations/statuses/{sha}","languages_url":"https://api.github.com/repos/AgentAntelope/rspec-expectations/languages","stargazers_url":"https://api.github.com/repos/AgentAntelope/rspec-expectations/stargazers","contributors_url":"https://api.github.com/repos/AgentAntelope/rspec-expectations/contributors","subscribers_url":"https://api.github.com/repos/AgentAntelope/rspec-expectations/subscribers","subscription_url":"https://api.github.com/repos/AgentAntelope/rspec-expectations/subscription","commits_url":"https://api.github.com/repos/AgentAntelope/rspec-expectations/commits{/sha}","git_commits_url":"https://api.github.com/repos/AgentAntelope/rspec-expectations/git/commits{/sha}","comments_url":"https://api.github.com/repos/AgentAntelope/rspec-expectations/comments{/number}","issue_comment_url":"https://api.github.com/repos/AgentAntelope/rspec-expectations/issues/comments/{number}","contents_url":"https://api.github.com/repos/AgentAntelope/rspec-expectations/contents/{+path}","compare_url":"https://api.github.com/repos/AgentAntelope/rspec-expectations/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AgentAntelope/rspec-expectations/merges","archive_url":"https://api.github.com/repos/AgentAntelope/rspec-expectations/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AgentAntelope/rspec-expectations/downloads","issues_url":"https://api.github.com/repos/AgentAntelope/rspec-expectations/issues{/number}","pulls_url":"https://api.github.com/repos/AgentAntelope/rspec-expectations/pulls{/number}","milestones_url":"https://api.github.com/repos/AgentAntelope/rspec-expectations/milestones{/number}","notifications_url":"https://api.github.com/repos/AgentAntelope/rspec-expectations/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AgentAntelope/rspec-expectations/labels{/name}","releases_url":"https://api.github.com/repos/AgentAntelope/rspec-expectations/releases{/id}","created_at":"2014-06-17T21:07:40Z","updated_at":"2014-06-17T21:51:01Z","pushed_at":"2014-06-17T21:51:02Z","git_url":"git://github.com/AgentAntelope/rspec-expectations.git","ssh_url":"git@github.com:AgentAntelope/rspec-expectations.git","clone_url":"https://github.com/AgentAntelope/rspec-expectations.git","svn_url":"https://github.com/AgentAntelope/rspec-expectations","homepage":"http://relishapp.com/rspec/rspec-expectations","size":10749,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rspec:master","ref":"master","sha":"03c9c2d66d8494696df68120319bad270fa9be7c","user":{"login":"rspec","id":22388,"avatar_url":"https://avatars.githubusercontent.com/u/22388?","gravatar_id":"e482036908235889a3439104bdbc3eb9","url":"https://api.github.com/users/rspec","html_url":"https://github.com/rspec","followers_url":"https://api.github.com/users/rspec/followers","following_url":"https://api.github.com/users/rspec/following{/other_user}","gists_url":"https://api.github.com/users/rspec/gists{/gist_id}","starred_url":"https://api.github.com/users/rspec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rspec/subscriptions","organizations_url":"https://api.github.com/users/rspec/orgs","repos_url":"https://api.github.com/users/rspec/repos","events_url":"https://api.github.com/users/rspec/events{/privacy}","received_events_url":"https://api.github.com/users/rspec/received_events","type":"Organization","site_admin":false},"repo":{"id":238986,"name":"rspec-expectations","full_name":"rspec/rspec-expectations","owner":{"login":"rspec","id":22388,"avatar_url":"https://avatars.githubusercontent.com/u/22388?","gravatar_id":"e482036908235889a3439104bdbc3eb9","url":"https://api.github.com/users/rspec","html_url":"https://github.com/rspec","followers_url":"https://api.github.com/users/rspec/followers","following_url":"https://api.github.com/users/rspec/following{/other_user}","gists_url":"https://api.github.com/users/rspec/gists{/gist_id}","starred_url":"https://api.github.com/users/rspec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rspec/subscriptions","organizations_url":"https://api.github.com/users/rspec/orgs","repos_url":"https://api.github.com/users/rspec/repos","events_url":"https://api.github.com/users/rspec/events{/privacy}","received_events_url":"https://api.github.com/users/rspec/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rspec/rspec-expectations","description":"Provides a simple, readable API to express expected outcomes of a code example","fork":false,"url":"https://api.github.com/repos/rspec/rspec-expectations","forks_url":"https://api.github.com/repos/rspec/rspec-expectations/forks","keys_url":"https://api.github.com/repos/rspec/rspec-expectations/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rspec/rspec-expectations/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rspec/rspec-expectations/teams","hooks_url":"https://api.github.com/repos/rspec/rspec-expectations/hooks","issue_events_url":"https://api.github.com/repos/rspec/rspec-expectations/issues/events{/number}","events_url":"https://api.github.com/repos/rspec/rspec-expectations/events","assignees_url":"https://api.github.com/repos/rspec/rspec-expectations/assignees{/user}","branches_url":"https://api.github.com/repos/rspec/rspec-expectations/branches{/branch}","tags_url":"https://api.github.com/repos/rspec/rspec-expectations/tags","blobs_url":"https://api.github.com/repos/rspec/rspec-expectations/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rspec/rspec-expectations/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rspec/rspec-expectations/git/refs{/sha}","trees_url":"https://api.github.com/repos/rspec/rspec-expectations/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rspec/rspec-expectations/statuses/{sha}","languages_url":"https://api.github.com/repos/rspec/rspec-expectations/languages","stargazers_url":"https://api.github.com/repos/rspec/rspec-expectations/stargazers","contributors_url":"https://api.github.com/repos/rspec/rspec-expectations/contributors","subscribers_url":"https://api.github.com/repos/rspec/rspec-expectations/subscribers","subscription_url":"https://api.github.com/repos/rspec/rspec-expectations/subscription","commits_url":"https://api.github.com/repos/rspec/rspec-expectations/commits{/sha}","git_commits_url":"https://api.github.com/repos/rspec/rspec-expectations/git/commits{/sha}","comments_url":"https://api.github.com/repos/rspec/rspec-expectations/comments{/number}","issue_comment_url":"https://api.github.com/repos/rspec/rspec-expectations/issues/comments/{number}","contents_url":"https://api.github.com/repos/rspec/rspec-expectations/contents/{+path}","compare_url":"https://api.github.com/repos/rspec/rspec-expectations/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rspec/rspec-expectations/merges","archive_url":"https://api.github.com/repos/rspec/rspec-expectations/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rspec/rspec-expectations/downloads","issues_url":"https://api.github.com/repos/rspec/rspec-expectations/issues{/number}","pulls_url":"https://api.github.com/repos/rspec/rspec-expectations/pulls{/number}","milestones_url":"https://api.github.com/repos/rspec/rspec-expectations/milestones{/number}","notifications_url":"https://api.github.com/repos/rspec/rspec-expectations/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rspec/rspec-expectations/labels{/name}","releases_url":"https://api.github.com/repos/rspec/rspec-expectations/releases{/id}","created_at":"2009-06-29T15:58:17Z","updated_at":"2014-06-18T05:07:15Z","pushed_at":"2014-06-18T05:07:15Z","git_url":"git://github.com/rspec/rspec-expectations.git","ssh_url":"git@github.com:rspec/rspec-expectations.git","clone_url":"https://github.com/rspec/rspec-expectations.git","svn_url":"https://github.com/rspec/rspec-expectations","homepage":"http://relishapp.com/rspec/rspec-expectations","size":10749,"stargazers_count":467,"watchers_count":467,"language":"Ruby","has_issues":true,"has_downloads":false,"has_wiki":false,"forks_count":164,"mirror_url":null,"open_issues_count":26,"forks":164,"open_issues":26,"watchers":467,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rspec/rspec-expectations/pulls/585"},"html":{"href":"https://github.com/rspec/rspec-expectations/pull/585"},"issue":{"href":"https://api.github.com/repos/rspec/rspec-expectations/issues/585"},"comments":{"href":"https://api.github.com/repos/rspec/rspec-expectations/issues/585/comments"},"review_comments":{"href":"https://api.github.com/repos/rspec/rspec-expectations/pulls/585/comments"},"review_comment":{"href":"https://api.github.com/repos/rspec/rspec-expectations/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rspec/rspec-expectations/pulls/585/commits"},"statuses":{"href":"https://api.github.com/repos/rspec/rspec-expectations/statuses/d388e92d3d98a194b9ed002a4386954ce17b6c04"}}}}