GitHub PullRequestEvent at 2014-08-05 20:30:31
Repository: SMC
Actor: Quintus
Payload: {"action":"closed","number":106,"pull_request":{"url":"https://api.github.com/repos/Secretchronicles/SMC/pulls/106","id":17665240,"html_url":"https://github.com/Secretchronicles/SMC/pull/106","diff_url":"https://github.com/Secretchronicles/SMC/pull/106.diff","patch_url":"https://github.com/Secretchronicles/SMC/pull/106.patch","issue_url":"https://api.github.com/repos/Secretchronicles/SMC/issues/106","number":106,"state":"closed","title":"Basic packages implementatin WIP","user":{"login":"brianvanderburg2","id":2142408,"avatar_url":"https://avatars.githubusercontent.com/u/2142408?v=2","gravatar_id":null,"url":"https://api.github.com/users/brianvanderburg2","html_url":"https://github.com/brianvanderburg2","followers_url":"https://api.github.com/users/brianvanderburg2/followers","following_url":"https://api.github.com/users/brianvanderburg2/following{/other_user}","gists_url":"https://api.github.com/users/brianvanderburg2/gists{/gist_id}","starred_url":"https://api.github.com/users/brianvanderburg2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianvanderburg2/subscriptions","organizations_url":"https://api.github.com/users/brianvanderburg2/orgs","repos_url":"https://api.github.com/users/brianvanderburg2/repos","events_url":"https://api.github.com/users/brianvanderburg2/events{/privacy}","received_events_url":"https://api.github.com/users/brianvanderburg2/received_events","type":"User","site_admin":false},"body":"I'm currently messing around with a very simple packages implementation that is a major work in progress/planning status. Currently I have the following implemented.\r\n\r\nA cPackage_Manager class along side cResource_Manager.  The idea is that cPackage_Manager would be used for things that could be from packages while cResource_Manager is for things that are global/not from packages, such as GUI elements, etc.\r\n\r\nThe package manager works by implementing a search path.  Any package can (in the future) define other packages that it uses, and a search path is built from that package all the way up to the core data when setting the active active package.\r\n\r\nCurrently, methods are provided for asking where something is.  For reading, this searches the search path until it finds something that exists.  For writing, this is always the user directory of the current package, or core.\r\n\r\nThe only thing that currently uses this is level loading. If a change is made to package_manager.cpp to force set the package during construction, then when a level is loaded, it will use the paths to that package first, then the core if that does not exist.\r\n\r\nRight now this is entirely file/directory based.  In the future, I could imaging replacing the Get_...._Path methods with Open_..._Path methods. Such a method would determine if the package is a directory or archive, and return a base stream that can read regardless of if the package is a directory or an archive file, perhaps using something like PhysicFS.  However, this would require any used libraries to support loading from some input stream and not just a file name.  SDL_image, SDL_mixer, libxml++, and so on.","created_at":"2014-06-26T18:45:21Z","updated_at":"2014-08-05T20:30:31Z","closed_at":"2014-08-05T20:30:31Z","merged_at":"2014-08-05T20:30:31Z","merge_commit_sha":"2ae83fa06cb937f4927e2dc336ef157ff1908fe7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Secretchronicles/SMC/pulls/106/commits","review_comments_url":"https://api.github.com/repos/Secretchronicles/SMC/pulls/106/comments","review_comment_url":"https://api.github.com/repos/Secretchronicles/SMC/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Secretchronicles/SMC/issues/106/comments","statuses_url":"https://api.github.com/repos/Secretchronicles/SMC/statuses/55024188a359d5e203cf12ac25dd99cd6724505f","head":{"label":"brianvanderburg2:feature-packages","ref":"feature-packages","sha":"55024188a359d5e203cf12ac25dd99cd6724505f","user":{"login":"brianvanderburg2","id":2142408,"avatar_url":"https://avatars.githubusercontent.com/u/2142408?v=2","gravatar_id":null,"url":"https://api.github.com/users/brianvanderburg2","html_url":"https://github.com/brianvanderburg2","followers_url":"https://api.github.com/users/brianvanderburg2/followers","following_url":"https://api.github.com/users/brianvanderburg2/following{/other_user}","gists_url":"https://api.github.com/users/brianvanderburg2/gists{/gist_id}","starred_url":"https://api.github.com/users/brianvanderburg2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianvanderburg2/subscriptions","organizations_url":"https://api.github.com/users/brianvanderburg2/orgs","repos_url":"https://api.github.com/users/brianvanderburg2/repos","events_url":"https://api.github.com/users/brianvanderburg2/events{/privacy}","received_events_url":"https://api.github.com/users/brianvanderburg2/received_events","type":"User","site_admin":false},"repo":{"id":20873307,"name":"SMC","full_name":"brianvanderburg2/SMC","owner":{"login":"brianvanderburg2","id":2142408,"avatar_url":"https://avatars.githubusercontent.com/u/2142408?v=2","gravatar_id":null,"url":"https://api.github.com/users/brianvanderburg2","html_url":"https://github.com/brianvanderburg2","followers_url":"https://api.github.com/users/brianvanderburg2/followers","following_url":"https://api.github.com/users/brianvanderburg2/following{/other_user}","gists_url":"https://api.github.com/users/brianvanderburg2/gists{/gist_id}","starred_url":"https://api.github.com/users/brianvanderburg2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianvanderburg2/subscriptions","organizations_url":"https://api.github.com/users/brianvanderburg2/orgs","repos_url":"https://api.github.com/users/brianvanderburg2/repos","events_url":"https://api.github.com/users/brianvanderburg2/events{/privacy}","received_events_url":"https://api.github.com/users/brianvanderburg2/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brianvanderburg2/SMC","description":"An open source two-dimensional platform game.","fork":true,"url":"https://api.github.com/repos/brianvanderburg2/SMC","forks_url":"https://api.github.com/repos/brianvanderburg2/SMC/forks","keys_url":"https://api.github.com/repos/brianvanderburg2/SMC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brianvanderburg2/SMC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brianvanderburg2/SMC/teams","hooks_url":"https://api.github.com/repos/brianvanderburg2/SMC/hooks","issue_events_url":"https://api.github.com/repos/brianvanderburg2/SMC/issues/events{/number}","events_url":"https://api.github.com/repos/brianvanderburg2/SMC/events","assignees_url":"https://api.github.com/repos/brianvanderburg2/SMC/assignees{/user}","branches_url":"https://api.github.com/repos/brianvanderburg2/SMC/branches{/branch}","tags_url":"https://api.github.com/repos/brianvanderburg2/SMC/tags","blobs_url":"https://api.github.com/repos/brianvanderburg2/SMC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brianvanderburg2/SMC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brianvanderburg2/SMC/git/refs{/sha}","trees_url":"https://api.github.com/repos/brianvanderburg2/SMC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brianvanderburg2/SMC/statuses/{sha}","languages_url":"https://api.github.com/repos/brianvanderburg2/SMC/languages","stargazers_url":"https://api.github.com/repos/brianvanderburg2/SMC/stargazers","contributors_url":"https://api.github.com/repos/brianvanderburg2/SMC/contributors","subscribers_url":"https://api.github.com/repos/brianvanderburg2/SMC/subscribers","subscription_url":"https://api.github.com/repos/brianvanderburg2/SMC/subscription","commits_url":"https://api.github.com/repos/brianvanderburg2/SMC/commits{/sha}","git_commits_url":"https://api.github.com/repos/brianvanderburg2/SMC/git/commits{/sha}","comments_url":"https://api.github.com/repos/brianvanderburg2/SMC/comments{/number}","issue_comment_url":"https://api.github.com/repos/brianvanderburg2/SMC/issues/comments/{number}","contents_url":"https://api.github.com/repos/brianvanderburg2/SMC/contents/{+path}","compare_url":"https://api.github.com/repos/brianvanderburg2/SMC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brianvanderburg2/SMC/merges","archive_url":"https://api.github.com/repos/brianvanderburg2/SMC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brianvanderburg2/SMC/downloads","issues_url":"https://api.github.com/repos/brianvanderburg2/SMC/issues{/number}","pulls_url":"https://api.github.com/repos/brianvanderburg2/SMC/pulls{/number}","milestones_url":"https://api.github.com/repos/brianvanderburg2/SMC/milestones{/number}","notifications_url":"https://api.github.com/repos/brianvanderburg2/SMC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brianvanderburg2/SMC/labels{/name}","releases_url":"https://api.github.com/repos/brianvanderburg2/SMC/releases{/id}","created_at":"2014-06-16T05:02:22Z","updated_at":"2014-06-26T14:55:08Z","pushed_at":"2014-08-05T19:48:08Z","git_url":"git://github.com/brianvanderburg2/SMC.git","ssh_url":"git@github.com:brianvanderburg2/SMC.git","clone_url":"https://github.com/brianvanderburg2/SMC.git","svn_url":"https://github.com/brianvanderburg2/SMC","homepage":"http://www.secretmaryo.org/","size":192483,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"Secretchronicles:devel","ref":"devel","sha":"25efd39675bb3548f4ba64866aef883dfdf657b1","user":{"login":"Secretchronicles","id":8327376,"avatar_url":"https://avatars.githubusercontent.com/u/8327376?v=2","gravatar_id":null,"url":"https://api.github.com/users/Secretchronicles","html_url":"https://github.com/Secretchronicles","followers_url":"https://api.github.com/users/Secretchronicles/followers","following_url":"https://api.github.com/users/Secretchronicles/following{/other_user}","gists_url":"https://api.github.com/users/Secretchronicles/gists{/gist_id}","starred_url":"https://api.github.com/users/Secretchronicles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Secretchronicles/subscriptions","organizations_url":"https://api.github.com/users/Secretchronicles/orgs","repos_url":"https://api.github.com/users/Secretchronicles/repos","events_url":"https://api.github.com/users/Secretchronicles/events{/privacy}","received_events_url":"https://api.github.com/users/Secretchronicles/received_events","type":"Organization","site_admin":false},"repo":{"id":3620226,"name":"SMC","full_name":"Secretchronicles/SMC","owner":{"login":"Secretchronicles","id":8327376,"avatar_url":"https://avatars.githubusercontent.com/u/8327376?v=2","gravatar_id":null,"url":"https://api.github.com/users/Secretchronicles","html_url":"https://github.com/Secretchronicles","followers_url":"https://api.github.com/users/Secretchronicles/followers","following_url":"https://api.github.com/users/Secretchronicles/following{/other_user}","gists_url":"https://api.github.com/users/Secretchronicles/gists{/gist_id}","starred_url":"https://api.github.com/users/Secretchronicles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Secretchronicles/subscriptions","organizations_url":"https://api.github.com/users/Secretchronicles/orgs","repos_url":"https://api.github.com/users/Secretchronicles/repos","events_url":"https://api.github.com/users/Secretchronicles/events{/privacy}","received_events_url":"https://api.github.com/users/Secretchronicles/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Secretchronicles/SMC","description":"An open source two-dimensional platform game.","fork":true,"url":"https://api.github.com/repos/Secretchronicles/SMC","forks_url":"https://api.github.com/repos/Secretchronicles/SMC/forks","keys_url":"https://api.github.com/repos/Secretchronicles/SMC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Secretchronicles/SMC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Secretchronicles/SMC/teams","hooks_url":"https://api.github.com/repos/Secretchronicles/SMC/hooks","issue_events_url":"https://api.github.com/repos/Secretchronicles/SMC/issues/events{/number}","events_url":"https://api.github.com/repos/Secretchronicles/SMC/events","assignees_url":"https://api.github.com/repos/Secretchronicles/SMC/assignees{/user}","branches_url":"https://api.github.com/repos/Secretchronicles/SMC/branches{/branch}","tags_url":"https://api.github.com/repos/Secretchronicles/SMC/tags","blobs_url":"https://api.github.com/repos/Secretchronicles/SMC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Secretchronicles/SMC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Secretchronicles/SMC/git/refs{/sha}","trees_url":"https://api.github.com/repos/Secretchronicles/SMC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Secretchronicles/SMC/statuses/{sha}","languages_url":"https://api.github.com/repos/Secretchronicles/SMC/languages","stargazers_url":"https://api.github.com/repos/Secretchronicles/SMC/stargazers","contributors_url":"https://api.github.com/repos/Secretchronicles/SMC/contributors","subscribers_url":"https://api.github.com/repos/Secretchronicles/SMC/subscribers","subscription_url":"https://api.github.com/repos/Secretchronicles/SMC/subscription","commits_url":"https://api.github.com/repos/Secretchronicles/SMC/commits{/sha}","git_commits_url":"https://api.github.com/repos/Secretchronicles/SMC/git/commits{/sha}","comments_url":"https://api.github.com/repos/Secretchronicles/SMC/comments{/number}","issue_comment_url":"https://api.github.com/repos/Secretchronicles/SMC/issues/comments/{number}","contents_url":"https://api.github.com/repos/Secretchronicles/SMC/contents/{+path}","compare_url":"https://api.github.com/repos/Secretchronicles/SMC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Secretchronicles/SMC/merges","archive_url":"https://api.github.com/repos/Secretchronicles/SMC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Secretchronicles/SMC/downloads","issues_url":"https://api.github.com/repos/Secretchronicles/SMC/issues{/number}","pulls_url":"https://api.github.com/repos/Secretchronicles/SMC/pulls{/number}","milestones_url":"https://api.github.com/repos/Secretchronicles/SMC/milestones{/number}","notifications_url":"https://api.github.com/repos/Secretchronicles/SMC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Secretchronicles/SMC/labels{/name}","releases_url":"https://api.github.com/repos/Secretchronicles/SMC/releases{/id}","created_at":"2012-03-04T18:47:27Z","updated_at":"2014-08-01T07:07:37Z","pushed_at":"2014-08-05T20:30:31Z","git_url":"git://github.com/Secretchronicles/SMC.git","ssh_url":"git@github.com:Secretchronicles/SMC.git","clone_url":"https://github.com/Secretchronicles/SMC.git","svn_url":"https://github.com/Secretchronicles/SMC","homepage":"http://www.secretmaryo.org/","size":195628,"stargazers_count":7,"watchers_count":7,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":5,"mirror_url":null,"open_issues_count":95,"forks":5,"open_issues":95,"watchers":7,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/Secretchronicles/SMC/pulls/106"},"html":{"href":"https://github.com/Secretchronicles/SMC/pull/106"},"issue":{"href":"https://api.github.com/repos/Secretchronicles/SMC/issues/106"},"comments":{"href":"https://api.github.com/repos/Secretchronicles/SMC/issues/106/comments"},"review_comments":{"href":"https://api.github.com/repos/Secretchronicles/SMC/pulls/106/comments"},"review_comment":{"href":"https://api.github.com/repos/Secretchronicles/SMC/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Secretchronicles/SMC/pulls/106/commits"},"statuses":{"href":"https://api.github.com/repos/Secretchronicles/SMC/statuses/55024188a359d5e203cf12ac25dd99cd6724505f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"Quintus","id":156358,"avatar_url":"https://avatars.githubusercontent.com/u/156358?v=2","gravatar_id":"85991f138ede6236f35eb98da22b7b01","url":"https://api.github.com/users/Quintus","html_url":"https://github.com/Quintus","followers_url":"https://api.github.com/users/Quintus/followers","following_url":"https://api.github.com/users/Quintus/following{/other_user}","gists_url":"https://api.github.com/users/Quintus/gists{/gist_id}","starred_url":"https://api.github.com/users/Quintus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Quintus/subscriptions","organizations_url":"https://api.github.com/users/Quintus/orgs","repos_url":"https://api.github.com/users/Quintus/repos","events_url":"https://api.github.com/users/Quintus/events{/privacy}","received_events_url":"https://api.github.com/users/Quintus/received_events","type":"User","site_admin":false},"comments":21,"review_comments":6,"commits":35,"additions":1623,"deletions":590,"changed_files":59}}