GitHub PullRequestReviewCommentEvent at 2014-12-20 01:23:48
Repository: SMF2.1
Actor: live627
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/SimpleMachines/SMF2.1/pulls/comments/22138467","id":22138467,"diff_hunk":"@@ -1710,13 +1710,17 @@ WHERE variable='enableOpenID' OR variable='dh_keys';\n ---#\n \n /******************************************************************************/\n---- Fixing the url column in the log_spider_hits table\n+--- Fixing the url column in the log_spider_hits and log_online tables\n /******************************************************************************/\n----# Changing url column size from 255 to 1024\n+---# Changing url column size in log_spider_hits from 255 to 1024\n ALTER TABLE {$db_prefix}log_spider_hits\n CHANGE `url` `url` varchar(1024) NOT NULL DEFAULT '';\n ---#\n \n+---# Changing url column in log_online from text to varchar(1024)\n+ALTER TABLE {$db_prefix}log_online\n+CHANGE `url` `url` varchar(1024) NOT NULL DEFAULT '';\n+","path":"other/upgrade_2-1_mysql.sql","position":16,"original_position":16,"commit_id":"01c2b7f53b5eb45a18ad098c9474c9849fd800df","original_commit_id":"01c2b7f53b5eb45a18ad098c9474c9849fd800df","user":{"login":"live627","id":431799,"avatar_url":"https://avatars.githubusercontent.com/u/431799?v=3","gravatar_id":"","url":"https://api.github.com/users/live627","html_url":"https://github.com/live627","followers_url":"https://api.github.com/users/live627/followers","following_url":"https://api.github.com/users/live627/following{/other_user}","gists_url":"https://api.github.com/users/live627/gists{/gist_id}","starred_url":"https://api.github.com/users/live627/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/live627/subscriptions","organizations_url":"https://api.github.com/users/live627/orgs","repos_url":"https://api.github.com/users/live627/repos","events_url":"https://api.github.com/users/live627/events{/privacy}","received_events_url":"https://api.github.com/users/live627/received_events","type":"User","site_admin":false},"body":"Why not kill all sessions? It's no big deal... at best, user won't notice, and at worst, they need to log in again.","created_at":"2014-12-20T01:23:48Z","updated_at":"2014-12-20T01:23:48Z","html_url":"https://github.com/SimpleMachines/SMF2.1/pull/2608#discussion_r22138467","pull_request_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/pulls/2608","_links":{"self":{"href":"https://api.github.com/repos/SimpleMachines/SMF2.1/pulls/comments/22138467"},"html":{"href":"https://github.com/SimpleMachines/SMF2.1/pull/2608#discussion_r22138467"},"pull_request":{"href":"https://api.github.com/repos/SimpleMachines/SMF2.1/pulls/2608"}}},"pull_request":{"url":"https://api.github.com/repos/SimpleMachines/SMF2.1/pulls/2608","id":26254901,"html_url":"https://github.com/SimpleMachines/SMF2.1/pull/2608","diff_url":"https://github.com/SimpleMachines/SMF2.1/pull/2608.diff","patch_url":"https://github.com/SimpleMachines/SMF2.1/pull/2608.patch","issue_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/issues/2608","number":2608,"state":"open","locked":false,"title":"MySQL Storage Engine support","user":{"login":"Oldiesmann","id":89023,"avatar_url":"https://avatars.githubusercontent.com/u/89023?v=3","gravatar_id":"","url":"https://api.github.com/users/Oldiesmann","html_url":"https://github.com/Oldiesmann","followers_url":"https://api.github.com/users/Oldiesmann/followers","following_url":"https://api.github.com/users/Oldiesmann/following{/other_user}","gists_url":"https://api.github.com/users/Oldiesmann/gists{/gist_id}","starred_url":"https://api.github.com/users/Oldiesmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Oldiesmann/subscriptions","organizations_url":"https://api.github.com/users/Oldiesmann/orgs","repos_url":"https://api.github.com/users/Oldiesmann/repos","events_url":"https://api.github.com/users/Oldiesmann/events{/privacy}","received_events_url":"https://api.github.com/users/Oldiesmann/received_events","type":"User","site_admin":false},"body":"This big collection of changes does the following:\r\n- Use InnoDB (or, for log_floodcontrol and log_online, MEMORY) by default for new installs (if InnoDB is available - otherwise falls back to MyISAM)\r\n- Add support for specifying a storage engine with $smcFunc['db_create_table']\r\n- Add support for Fulltext indexes for InnoDB tables when running MySQL 5.6.4 or newer\r\n- Add storage engine to array returned by smf_db_table_structure (currently not used in SMF, but some may find it useful)\r\n- Minor code cleanup here and there\r\n\r\nNote: In order to allow log_online to be MEMORY, the \"url\" column in this table was changed from text to varchar(1024). For consistency, I also made this change in PostgreSQL even though there is no benefit for doing so.","created_at":"2014-12-17T20:42:38Z","updated_at":"2014-12-20T01:23:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9bc91d5a8ed1b8ac43614e440ed35ec93def5ceb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/pulls/2608/commits","review_comments_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/pulls/2608/comments","review_comment_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/pulls/comments/{number}","comments_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/issues/2608/comments","statuses_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/statuses/01c2b7f53b5eb45a18ad098c9474c9849fd800df","head":{"label":"Oldiesmann:release-2.1","ref":"release-2.1","sha":"01c2b7f53b5eb45a18ad098c9474c9849fd800df","user":{"login":"Oldiesmann","id":89023,"avatar_url":"https://avatars.githubusercontent.com/u/89023?v=3","gravatar_id":"","url":"https://api.github.com/users/Oldiesmann","html_url":"https://github.com/Oldiesmann","followers_url":"https://api.github.com/users/Oldiesmann/followers","following_url":"https://api.github.com/users/Oldiesmann/following{/other_user}","gists_url":"https://api.github.com/users/Oldiesmann/gists{/gist_id}","starred_url":"https://api.github.com/users/Oldiesmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Oldiesmann/subscriptions","organizations_url":"https://api.github.com/users/Oldiesmann/orgs","repos_url":"https://api.github.com/users/Oldiesmann/repos","events_url":"https://api.github.com/users/Oldiesmann/events{/privacy}","received_events_url":"https://api.github.com/users/Oldiesmann/received_events","type":"User","site_admin":false},"repo":{"id":25737693,"name":"SMF21","full_name":"Oldiesmann/SMF21","owner":{"login":"Oldiesmann","id":89023,"avatar_url":"https://avatars.githubusercontent.com/u/89023?v=3","gravatar_id":"","url":"https://api.github.com/users/Oldiesmann","html_url":"https://github.com/Oldiesmann","followers_url":"https://api.github.com/users/Oldiesmann/followers","following_url":"https://api.github.com/users/Oldiesmann/following{/other_user}","gists_url":"https://api.github.com/users/Oldiesmann/gists{/gist_id}","starred_url":"https://api.github.com/users/Oldiesmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Oldiesmann/subscriptions","organizations_url":"https://api.github.com/users/Oldiesmann/orgs","repos_url":"https://api.github.com/users/Oldiesmann/repos","events_url":"https://api.github.com/users/Oldiesmann/events{/privacy}","received_events_url":"https://api.github.com/users/Oldiesmann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Oldiesmann/SMF21","description":"Thoughts, Ideas and bits of code for SMF (2.1)","fork":true,"url":"https://api.github.com/repos/Oldiesmann/SMF21","forks_url":"https://api.github.com/repos/Oldiesmann/SMF21/forks","keys_url":"https://api.github.com/repos/Oldiesmann/SMF21/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Oldiesmann/SMF21/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Oldiesmann/SMF21/teams","hooks_url":"https://api.github.com/repos/Oldiesmann/SMF21/hooks","issue_events_url":"https://api.github.com/repos/Oldiesmann/SMF21/issues/events{/number}","events_url":"https://api.github.com/repos/Oldiesmann/SMF21/events","assignees_url":"https://api.github.com/repos/Oldiesmann/SMF21/assignees{/user}","branches_url":"https://api.github.com/repos/Oldiesmann/SMF21/branches{/branch}","tags_url":"https://api.github.com/repos/Oldiesmann/SMF21/tags","blobs_url":"https://api.github.com/repos/Oldiesmann/SMF21/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Oldiesmann/SMF21/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Oldiesmann/SMF21/git/refs{/sha}","trees_url":"https://api.github.com/repos/Oldiesmann/SMF21/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Oldiesmann/SMF21/statuses/{sha}","languages_url":"https://api.github.com/repos/Oldiesmann/SMF21/languages","stargazers_url":"https://api.github.com/repos/Oldiesmann/SMF21/stargazers","contributors_url":"https://api.github.com/repos/Oldiesmann/SMF21/contributors","subscribers_url":"https://api.github.com/repos/Oldiesmann/SMF21/subscribers","subscription_url":"https://api.github.com/repos/Oldiesmann/SMF21/subscription","commits_url":"https://api.github.com/repos/Oldiesmann/SMF21/commits{/sha}","git_commits_url":"https://api.github.com/repos/Oldiesmann/SMF21/git/commits{/sha}","comments_url":"https://api.github.com/repos/Oldiesmann/SMF21/comments{/number}","issue_comment_url":"https://api.github.com/repos/Oldiesmann/SMF21/issues/comments/{number}","contents_url":"https://api.github.com/repos/Oldiesmann/SMF21/contents/{+path}","compare_url":"https://api.github.com/repos/Oldiesmann/SMF21/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Oldiesmann/SMF21/merges","archive_url":"https://api.github.com/repos/Oldiesmann/SMF21/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Oldiesmann/SMF21/downloads","issues_url":"https://api.github.com/repos/Oldiesmann/SMF21/issues{/number}","pulls_url":"https://api.github.com/repos/Oldiesmann/SMF21/pulls{/number}","milestones_url":"https://api.github.com/repos/Oldiesmann/SMF21/milestones{/number}","notifications_url":"https://api.github.com/repos/Oldiesmann/SMF21/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Oldiesmann/SMF21/labels{/name}","releases_url":"https://api.github.com/repos/Oldiesmann/SMF21/releases{/id}","created_at":"2014-10-25T16:18:41Z","updated_at":"2014-12-17T20:26:30Z","pushed_at":"2014-12-17T20:26:29Z","git_url":"git://github.com/Oldiesmann/SMF21.git","ssh_url":"git@github.com:Oldiesmann/SMF21.git","clone_url":"https://github.com/Oldiesmann/SMF21.git","svn_url":"https://github.com/Oldiesmann/SMF21","homepage":"","size":27663,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"release-2.1"}},"base":{"label":"SimpleMachines:release-2.1","ref":"release-2.1","sha":"f65ccec3439635f898baf3f27ad1f6546e89fb20","user":{"login":"SimpleMachines","id":1085746,"avatar_url":"https://avatars.githubusercontent.com/u/1085746?v=3","gravatar_id":"","url":"https://api.github.com/users/SimpleMachines","html_url":"https://github.com/SimpleMachines","followers_url":"https://api.github.com/users/SimpleMachines/followers","following_url":"https://api.github.com/users/SimpleMachines/following{/other_user}","gists_url":"https://api.github.com/users/SimpleMachines/gists{/gist_id}","starred_url":"https://api.github.com/users/SimpleMachines/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimpleMachines/subscriptions","organizations_url":"https://api.github.com/users/SimpleMachines/orgs","repos_url":"https://api.github.com/users/SimpleMachines/repos","events_url":"https://api.github.com/users/SimpleMachines/events{/privacy}","received_events_url":"https://api.github.com/users/SimpleMachines/received_events","type":"Organization","site_admin":false},"repo":{"id":3257475,"name":"SMF2.1","full_name":"SimpleMachines/SMF2.1","owner":{"login":"SimpleMachines","id":1085746,"avatar_url":"https://avatars.githubusercontent.com/u/1085746?v=3","gravatar_id":"","url":"https://api.github.com/users/SimpleMachines","html_url":"https://github.com/SimpleMachines","followers_url":"https://api.github.com/users/SimpleMachines/followers","following_url":"https://api.github.com/users/SimpleMachines/following{/other_user}","gists_url":"https://api.github.com/users/SimpleMachines/gists{/gist_id}","starred_url":"https://api.github.com/users/SimpleMachines/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimpleMachines/subscriptions","organizations_url":"https://api.github.com/users/SimpleMachines/orgs","repos_url":"https://api.github.com/users/SimpleMachines/repos","events_url":"https://api.github.com/users/SimpleMachines/events{/privacy}","received_events_url":"https://api.github.com/users/SimpleMachines/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SimpleMachines/SMF2.1","description":"Thoughts, Ideas and bits of code for SMF (2.1)","fork":false,"url":"https://api.github.com/repos/SimpleMachines/SMF2.1","forks_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/forks","keys_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/teams","hooks_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/hooks","issue_events_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/issues/events{/number}","events_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/events","assignees_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/assignees{/user}","branches_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/branches{/branch}","tags_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/tags","blobs_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/git/refs{/sha}","trees_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/statuses/{sha}","languages_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/languages","stargazers_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/stargazers","contributors_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/contributors","subscribers_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/subscribers","subscription_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/subscription","commits_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/commits{/sha}","git_commits_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/git/commits{/sha}","comments_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/comments{/number}","issue_comment_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/issues/comments/{number}","contents_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/contents/{+path}","compare_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/merges","archive_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/downloads","issues_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/issues{/number}","pulls_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/pulls{/number}","milestones_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/milestones{/number}","notifications_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/labels{/name}","releases_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/releases{/id}","created_at":"2012-01-24T16:36:19Z","updated_at":"2014-12-15T06:57:22Z","pushed_at":"2014-12-15T06:57:21Z","git_url":"git://github.com/SimpleMachines/SMF2.1.git","ssh_url":"git@github.com:SimpleMachines/SMF2.1.git","clone_url":"https://github.com/SimpleMachines/SMF2.1.git","svn_url":"https://github.com/SimpleMachines/SMF2.1","homepage":"","size":35737,"stargazers_count":138,"watchers_count":138,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":120,"mirror_url":null,"open_issues_count":131,"forks":120,"open_issues":131,"watchers":138,"default_branch":"release-2.1"}},"_links":{"self":{"href":"https://api.github.com/repos/SimpleMachines/SMF2.1/pulls/2608"},"html":{"href":"https://github.com/SimpleMachines/SMF2.1/pull/2608"},"issue":{"href":"https://api.github.com/repos/SimpleMachines/SMF2.1/issues/2608"},"comments":{"href":"https://api.github.com/repos/SimpleMachines/SMF2.1/issues/2608/comments"},"review_comments":{"href":"https://api.github.com/repos/SimpleMachines/SMF2.1/pulls/2608/comments"},"review_comment":{"href":"https://api.github.com/repos/SimpleMachines/SMF2.1/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/SimpleMachines/SMF2.1/pulls/2608/commits"},"statuses":{"href":"https://api.github.com/repos/SimpleMachines/SMF2.1/statuses/01c2b7f53b5eb45a18ad098c9474c9849fd800df"}}}}