GitHub PullRequestReviewCommentEvent at 2014-09-17 16:06:32
Repository: bitmask_client
Actor: kalikaneko
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/leapcode/bitmask_client/pulls/comments/17673863","id":17673863,"diff_hunk":"@@ -92,20 +82,80 @@ def __init__(self, settings, parent=None):\n         self.ui.lnUser.textEdited.connect(self.ui.clblErrorMsg.hide)\n         self.ui.lnPassword.textEdited.connect(self.ui.clblErrorMsg.hide)\n \n+        self._settings = LeapSettings()\n+        self._backend = backend\n+        self._leap_signaler = signaler\n+\n+        # the selected provider that we'll use to login\n+        self._provider = None\n+\n+        self._backend_connected_signals = []\n+\n+        # This defines whether we should wait to start the login sequence or we\n+        # should start right away.\n+        # This is used, for instance, to hold on until EIP is started since the\n+        # firewall could block the login attempt.","path":"src/leap/bitmask/gui/login.py","position":95,"original_position":95,"commit_id":"11148a0b5363e017f75ac14af3d2cf999ab87d7f","original_commit_id":"11148a0b5363e017f75ac14af3d2cf999ab87d7f","user":{"login":"kalikaneko","id":3072993,"avatar_url":"https://avatars.githubusercontent.com/u/3072993?v=2","gravatar_id":"f1093184bda6bc1ce1ef3131a219c448","url":"https://api.github.com/users/kalikaneko","html_url":"https://github.com/kalikaneko","followers_url":"https://api.github.com/users/kalikaneko/followers","following_url":"https://api.github.com/users/kalikaneko/following{/other_user}","gists_url":"https://api.github.com/users/kalikaneko/gists{/gist_id}","starred_url":"https://api.github.com/users/kalikaneko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalikaneko/subscriptions","organizations_url":"https://api.github.com/users/kalikaneko/orgs","repos_url":"https://api.github.com/users/kalikaneko/repos","events_url":"https://api.github.com/users/kalikaneko/events{/privacy}","received_events_url":"https://api.github.com/users/kalikaneko/received_events","type":"User","site_admin":false},"body":"I would suggest encapsulating all these state flags together inside an object.\r\nThat way it's going to be much easier to change that to the backend (and substitute the reading and writing here by a class that proxies the calls through zmq)","created_at":"2014-09-17T16:06:32Z","updated_at":"2014-09-17T16:06:32Z","html_url":"https://github.com/leapcode/bitmask_client/pull/757#discussion_r17673863","pull_request_url":"https://api.github.com/repos/leapcode/bitmask_client/pulls/757","_links":{"self":{"href":"https://api.github.com/repos/leapcode/bitmask_client/pulls/comments/17673863"},"html":{"href":"https://github.com/leapcode/bitmask_client/pull/757#discussion_r17673863"},"pull_request":{"href":"https://api.github.com/repos/leapcode/bitmask_client/pulls/757"}}},"pull_request":{"url":"https://api.github.com/repos/leapcode/bitmask_client/pulls/757","id":21327093,"html_url":"https://github.com/leapcode/bitmask_client/pull/757","diff_url":"https://github.com/leapcode/bitmask_client/pull/757.diff","patch_url":"https://github.com/leapcode/bitmask_client/pull/757.patch","issue_url":"https://api.github.com/repos/leapcode/bitmask_client/issues/757","number":757,"state":"open","locked":false,"title":"Refactor login logic to the login widget.","user":{"login":"ivanalejandro0","id":806502,"avatar_url":"https://avatars.githubusercontent.com/u/806502?v=2","gravatar_id":"1649a5e9f614b7131595182b8af1ad18","url":"https://api.github.com/users/ivanalejandro0","html_url":"https://github.com/ivanalejandro0","followers_url":"https://api.github.com/users/ivanalejandro0/followers","following_url":"https://api.github.com/users/ivanalejandro0/following{/other_user}","gists_url":"https://api.github.com/users/ivanalejandro0/gists{/gist_id}","starred_url":"https://api.github.com/users/ivanalejandro0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivanalejandro0/subscriptions","organizations_url":"https://api.github.com/users/ivanalejandro0/orgs","repos_url":"https://api.github.com/users/ivanalejandro0/repos","events_url":"https://api.github.com/users/ivanalejandro0/events{/privacy}","received_events_url":"https://api.github.com/users/ivanalejandro0/received_events","type":"User","site_admin":false},"body":"**DO NOT MERGE**\r\n\r\nA little work needs to be done yet.","created_at":"2014-09-16T20:44:08Z","updated_at":"2014-09-17T16:06:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"047e7c661ee8a96e8b110405289a851105a995de","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/leapcode/bitmask_client/pulls/757/commits","review_comments_url":"https://api.github.com/repos/leapcode/bitmask_client/pulls/757/comments","review_comment_url":"https://api.github.com/repos/leapcode/bitmask_client/pulls/comments/{number}","comments_url":"https://api.github.com/repos/leapcode/bitmask_client/issues/757/comments","statuses_url":"https://api.github.com/repos/leapcode/bitmask_client/statuses/11148a0b5363e017f75ac14af3d2cf999ab87d7f","head":{"label":"ivanalejandro0:feature/cleanup-login","ref":"feature/cleanup-login","sha":"11148a0b5363e017f75ac14af3d2cf999ab87d7f","user":{"login":"ivanalejandro0","id":806502,"avatar_url":"https://avatars.githubusercontent.com/u/806502?v=2","gravatar_id":"1649a5e9f614b7131595182b8af1ad18","url":"https://api.github.com/users/ivanalejandro0","html_url":"https://github.com/ivanalejandro0","followers_url":"https://api.github.com/users/ivanalejandro0/followers","following_url":"https://api.github.com/users/ivanalejandro0/following{/other_user}","gists_url":"https://api.github.com/users/ivanalejandro0/gists{/gist_id}","starred_url":"https://api.github.com/users/ivanalejandro0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivanalejandro0/subscriptions","organizations_url":"https://api.github.com/users/ivanalejandro0/orgs","repos_url":"https://api.github.com/users/ivanalejandro0/repos","events_url":"https://api.github.com/users/ivanalejandro0/events{/privacy}","received_events_url":"https://api.github.com/users/ivanalejandro0/received_events","type":"User","site_admin":false},"repo":{"id":10178258,"name":"bitmask_client","full_name":"ivanalejandro0/bitmask_client","owner":{"login":"ivanalejandro0","id":806502,"avatar_url":"https://avatars.githubusercontent.com/u/806502?v=2","gravatar_id":"1649a5e9f614b7131595182b8af1ad18","url":"https://api.github.com/users/ivanalejandro0","html_url":"https://github.com/ivanalejandro0","followers_url":"https://api.github.com/users/ivanalejandro0/followers","following_url":"https://api.github.com/users/ivanalejandro0/following{/other_user}","gists_url":"https://api.github.com/users/ivanalejandro0/gists{/gist_id}","starred_url":"https://api.github.com/users/ivanalejandro0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivanalejandro0/subscriptions","organizations_url":"https://api.github.com/users/ivanalejandro0/orgs","repos_url":"https://api.github.com/users/ivanalejandro0/repos","events_url":"https://api.github.com/users/ivanalejandro0/events{/privacy}","received_events_url":"https://api.github.com/users/ivanalejandro0/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ivanalejandro0/bitmask_client","description":"","fork":true,"url":"https://api.github.com/repos/ivanalejandro0/bitmask_client","forks_url":"https://api.github.com/repos/ivanalejandro0/bitmask_client/forks","keys_url":"https://api.github.com/repos/ivanalejandro0/bitmask_client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ivanalejandro0/bitmask_client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ivanalejandro0/bitmask_client/teams","hooks_url":"https://api.github.com/repos/ivanalejandro0/bitmask_client/hooks","issue_events_url":"https://api.github.com/repos/ivanalejandro0/bitmask_client/issues/events{/number}","events_url":"https://api.github.com/repos/ivanalejandro0/bitmask_client/events","assignees_url":"https://api.github.com/repos/ivanalejandro0/bitmask_client/assignees{/user}","branches_url":"https://api.github.com/repos/ivanalejandro0/bitmask_client/branches{/branch}","tags_url":"https://api.github.com/repos/ivanalejandro0/bitmask_client/tags","blobs_url":"https://api.github.com/repos/ivanalejandro0/bitmask_client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ivanalejandro0/bitmask_client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ivanalejandro0/bitmask_client/git/refs{/sha}","trees_url":"https://api.github.com/repos/ivanalejandro0/bitmask_client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ivanalejandro0/bitmask_client/statuses/{sha}","languages_url":"https://api.github.com/repos/ivanalejandro0/bitmask_client/languages","stargazers_url":"https://api.github.com/repos/ivanalejandro0/bitmask_client/stargazers","contributors_url":"https://api.github.com/repos/ivanalejandro0/bitmask_client/contributors","subscribers_url":"https://api.github.com/repos/ivanalejandro0/bitmask_client/subscribers","subscription_url":"https://api.github.com/repos/ivanalejandro0/bitmask_client/subscription","commits_url":"https://api.github.com/repos/ivanalejandro0/bitmask_client/commits{/sha}","git_commits_url":"https://api.github.com/repos/ivanalejandro0/bitmask_client/git/commits{/sha}","comments_url":"https://api.github.com/repos/ivanalejandro0/bitmask_client/comments{/number}","issue_comment_url":"https://api.github.com/repos/ivanalejandro0/bitmask_client/issues/comments/{number}","contents_url":"https://api.github.com/repos/ivanalejandro0/bitmask_client/contents/{+path}","compare_url":"https://api.github.com/repos/ivanalejandro0/bitmask_client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ivanalejandro0/bitmask_client/merges","archive_url":"https://api.github.com/repos/ivanalejandro0/bitmask_client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ivanalejandro0/bitmask_client/downloads","issues_url":"https://api.github.com/repos/ivanalejandro0/bitmask_client/issues{/number}","pulls_url":"https://api.github.com/repos/ivanalejandro0/bitmask_client/pulls{/number}","milestones_url":"https://api.github.com/repos/ivanalejandro0/bitmask_client/milestones{/number}","notifications_url":"https://api.github.com/repos/ivanalejandro0/bitmask_client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ivanalejandro0/bitmask_client/labels{/name}","releases_url":"https://api.github.com/repos/ivanalejandro0/bitmask_client/releases{/id}","created_at":"2013-05-20T17:46:35Z","updated_at":"2014-07-16T19:48:05Z","pushed_at":"2014-09-17T15:06:25Z","git_url":"git://github.com/ivanalejandro0/bitmask_client.git","ssh_url":"git@github.com:ivanalejandro0/bitmask_client.git","clone_url":"https://github.com/ivanalejandro0/bitmask_client.git","svn_url":"https://github.com/ivanalejandro0/bitmask_client","homepage":null,"size":15061,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"leapcode:develop","ref":"develop","sha":"c3b2345dcc715f02fdfe4ffc04446236e17105a8","user":{"login":"leapcode","id":1700464,"avatar_url":"https://avatars.githubusercontent.com/u/1700464?v=2","gravatar_id":"640f3983191ab72c52189a90a9d1c17e","url":"https://api.github.com/users/leapcode","html_url":"https://github.com/leapcode","followers_url":"https://api.github.com/users/leapcode/followers","following_url":"https://api.github.com/users/leapcode/following{/other_user}","gists_url":"https://api.github.com/users/leapcode/gists{/gist_id}","starred_url":"https://api.github.com/users/leapcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leapcode/subscriptions","organizations_url":"https://api.github.com/users/leapcode/orgs","repos_url":"https://api.github.com/users/leapcode/repos","events_url":"https://api.github.com/users/leapcode/events{/privacy}","received_events_url":"https://api.github.com/users/leapcode/received_events","type":"Organization","site_admin":false},"repo":{"id":5621403,"name":"bitmask_client","full_name":"leapcode/bitmask_client","owner":{"login":"leapcode","id":1700464,"avatar_url":"https://avatars.githubusercontent.com/u/1700464?v=2","gravatar_id":"640f3983191ab72c52189a90a9d1c17e","url":"https://api.github.com/users/leapcode","html_url":"https://github.com/leapcode","followers_url":"https://api.github.com/users/leapcode/followers","following_url":"https://api.github.com/users/leapcode/following{/other_user}","gists_url":"https://api.github.com/users/leapcode/gists{/gist_id}","starred_url":"https://api.github.com/users/leapcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leapcode/subscriptions","organizations_url":"https://api.github.com/users/leapcode/orgs","repos_url":"https://api.github.com/users/leapcode/repos","events_url":"https://api.github.com/users/leapcode/events{/privacy}","received_events_url":"https://api.github.com/users/leapcode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/leapcode/bitmask_client","description":"Desktop client application for the LEAP platform, supporting encrypted internet proxy, secure email, and secure chat (coming soon). The client is written in Python, runs on Linux, Mac, and Windows, and is licensed under the GPLv3.","fork":false,"url":"https://api.github.com/repos/leapcode/bitmask_client","forks_url":"https://api.github.com/repos/leapcode/bitmask_client/forks","keys_url":"https://api.github.com/repos/leapcode/bitmask_client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leapcode/bitmask_client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leapcode/bitmask_client/teams","hooks_url":"https://api.github.com/repos/leapcode/bitmask_client/hooks","issue_events_url":"https://api.github.com/repos/leapcode/bitmask_client/issues/events{/number}","events_url":"https://api.github.com/repos/leapcode/bitmask_client/events","assignees_url":"https://api.github.com/repos/leapcode/bitmask_client/assignees{/user}","branches_url":"https://api.github.com/repos/leapcode/bitmask_client/branches{/branch}","tags_url":"https://api.github.com/repos/leapcode/bitmask_client/tags","blobs_url":"https://api.github.com/repos/leapcode/bitmask_client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leapcode/bitmask_client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leapcode/bitmask_client/git/refs{/sha}","trees_url":"https://api.github.com/repos/leapcode/bitmask_client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leapcode/bitmask_client/statuses/{sha}","languages_url":"https://api.github.com/repos/leapcode/bitmask_client/languages","stargazers_url":"https://api.github.com/repos/leapcode/bitmask_client/stargazers","contributors_url":"https://api.github.com/repos/leapcode/bitmask_client/contributors","subscribers_url":"https://api.github.com/repos/leapcode/bitmask_client/subscribers","subscription_url":"https://api.github.com/repos/leapcode/bitmask_client/subscription","commits_url":"https://api.github.com/repos/leapcode/bitmask_client/commits{/sha}","git_commits_url":"https://api.github.com/repos/leapcode/bitmask_client/git/commits{/sha}","comments_url":"https://api.github.com/repos/leapcode/bitmask_client/comments{/number}","issue_comment_url":"https://api.github.com/repos/leapcode/bitmask_client/issues/comments/{number}","contents_url":"https://api.github.com/repos/leapcode/bitmask_client/contents/{+path}","compare_url":"https://api.github.com/repos/leapcode/bitmask_client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leapcode/bitmask_client/merges","archive_url":"https://api.github.com/repos/leapcode/bitmask_client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leapcode/bitmask_client/downloads","issues_url":"https://api.github.com/repos/leapcode/bitmask_client/issues{/number}","pulls_url":"https://api.github.com/repos/leapcode/bitmask_client/pulls{/number}","milestones_url":"https://api.github.com/repos/leapcode/bitmask_client/milestones{/number}","notifications_url":"https://api.github.com/repos/leapcode/bitmask_client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leapcode/bitmask_client/labels{/name}","releases_url":"https://api.github.com/repos/leapcode/bitmask_client/releases{/id}","created_at":"2012-08-30T21:48:22Z","updated_at":"2014-09-13T01:29:32Z","pushed_at":"2014-09-17T14:54:55Z","git_url":"git://github.com/leapcode/bitmask_client.git","ssh_url":"git@github.com:leapcode/bitmask_client.git","clone_url":"https://github.com/leapcode/bitmask_client.git","svn_url":"https://github.com/leapcode/bitmask_client","homepage":"","size":15228,"stargazers_count":53,"watchers_count":53,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":"https://leap.se/git/bitmask_client.git","open_issues_count":8,"forks":23,"open_issues":8,"watchers":53,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/leapcode/bitmask_client/pulls/757"},"html":{"href":"https://github.com/leapcode/bitmask_client/pull/757"},"issue":{"href":"https://api.github.com/repos/leapcode/bitmask_client/issues/757"},"comments":{"href":"https://api.github.com/repos/leapcode/bitmask_client/issues/757/comments"},"review_comments":{"href":"https://api.github.com/repos/leapcode/bitmask_client/pulls/757/comments"},"review_comment":{"href":"https://api.github.com/repos/leapcode/bitmask_client/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/leapcode/bitmask_client/pulls/757/commits"},"statuses":{"href":"https://api.github.com/repos/leapcode/bitmask_client/statuses/11148a0b5363e017f75ac14af3d2cf999ab87d7f"}}}}