GitHub PullRequestEvent at 2014-11-01 02:03:23
Repository: wildfly-core
Actor: bstansberry
Payload: {"action":"closed","number":268,"pull_request":{"url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/268","id":23333261,"html_url":"https://github.com/wildfly/wildfly-core/pull/268","diff_url":"https://github.com/wildfly/wildfly-core/pull/268.diff","patch_url":"https://github.com/wildfly/wildfly-core/pull/268.patch","issue_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/268","number":268,"state":"closed","locked":false,"title":"[WFCORE-148] Input stream response attachments","user":{"login":"bstansberry","id":299242,"avatar_url":"https://avatars.githubusercontent.com/u/299242?v=2","gravatar_id":"","url":"https://api.github.com/users/bstansberry","html_url":"https://github.com/bstansberry","followers_url":"https://api.github.com/users/bstansberry/followers","following_url":"https://api.github.com/users/bstansberry/following{/other_user}","gists_url":"https://api.github.com/users/bstansberry/gists{/gist_id}","starred_url":"https://api.github.com/users/bstansberry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bstansberry/subscriptions","organizations_url":"https://api.github.com/users/bstansberry/orgs","repos_url":"https://api.github.com/users/bstansberry/repos","events_url":"https://api.github.com/users/bstansberry/events{/privacy}","received_events_url":"https://api.github.com/users/bstansberry/received_events","type":"User","site_admin":false},"body":"Support for attachment of input streams to management responses with:\r\n\r\n1) Propagation to a remote ModelControllerClient over the management protocol\r\n2) Propagation throughout the domain (e.g. server to HC to DC)\r\n3) Ability of HTTP clients to use a query parameter (?useStreamAsResponse=0) or HTTP header (\"org.wildfly.useStreamAsResponse : 0\") to request the stream as the response instead of the normal JSON. In the examples above the '0' is not necessary, as it is the default.\r\n\r\nSee http://lists.jboss.org/pipermail/wildfly-dev/2014-October/003070.html\r\n\r\nThe first commit here is basically what's described above.\r\n\r\nThe second commit is concerned with cleaning up streams that the client never reads. A background task executes every 10 seconds and closes any streams associated with a particular operation if no such stream has been accessed in the past 30 seconds. This is relevant to native API requests; the HTTP handler will close all streams after responding to the client. But a native client needs to read or close the streams themselves, so a cleanup method is needed in case they fail to do so.\r\n\r\nIf a stream is read by a native client, the server-side stream is automatically closed once all bytes are sent to the client. The client does not need to close it.","created_at":"2014-10-25T00:56:30Z","updated_at":"2014-11-01T02:03:22Z","closed_at":"2014-11-01T02:03:22Z","merged_at":"2014-11-01T02:03:22Z","merge_commit_sha":"2c367e4efea6d9caf3c3c43a11c68595ef9bf5bd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/268/commits","review_comments_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/268/comments","review_comment_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments/{number}","comments_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/268/comments","statuses_url":"https://api.github.com/repos/wildfly/wildfly-core/statuses/5aeae9a25fe62ea439a25c6eb7e12b957343c066","head":{"label":"bstansberry:resp-stream","ref":"resp-stream","sha":"5aeae9a25fe62ea439a25c6eb7e12b957343c066","user":{"login":"bstansberry","id":299242,"avatar_url":"https://avatars.githubusercontent.com/u/299242?v=2","gravatar_id":"","url":"https://api.github.com/users/bstansberry","html_url":"https://github.com/bstansberry","followers_url":"https://api.github.com/users/bstansberry/followers","following_url":"https://api.github.com/users/bstansberry/following{/other_user}","gists_url":"https://api.github.com/users/bstansberry/gists{/gist_id}","starred_url":"https://api.github.com/users/bstansberry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bstansberry/subscriptions","organizations_url":"https://api.github.com/users/bstansberry/orgs","repos_url":"https://api.github.com/users/bstansberry/repos","events_url":"https://api.github.com/users/bstansberry/events{/privacy}","received_events_url":"https://api.github.com/users/bstansberry/received_events","type":"User","site_admin":false},"repo":{"id":21433119,"name":"wildfly-core","full_name":"bstansberry/wildfly-core","owner":{"login":"bstansberry","id":299242,"avatar_url":"https://avatars.githubusercontent.com/u/299242?v=2","gravatar_id":"","url":"https://api.github.com/users/bstansberry","html_url":"https://github.com/bstansberry","followers_url":"https://api.github.com/users/bstansberry/followers","following_url":"https://api.github.com/users/bstansberry/following{/other_user}","gists_url":"https://api.github.com/users/bstansberry/gists{/gist_id}","starred_url":"https://api.github.com/users/bstansberry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bstansberry/subscriptions","organizations_url":"https://api.github.com/users/bstansberry/orgs","repos_url":"https://api.github.com/users/bstansberry/repos","events_url":"https://api.github.com/users/bstansberry/events{/privacy}","received_events_url":"https://api.github.com/users/bstansberry/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bstansberry/wildfly-core","description":"The core runtime that is used by the Wildfly application server","fork":true,"url":"https://api.github.com/repos/bstansberry/wildfly-core","forks_url":"https://api.github.com/repos/bstansberry/wildfly-core/forks","keys_url":"https://api.github.com/repos/bstansberry/wildfly-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bstansberry/wildfly-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bstansberry/wildfly-core/teams","hooks_url":"https://api.github.com/repos/bstansberry/wildfly-core/hooks","issue_events_url":"https://api.github.com/repos/bstansberry/wildfly-core/issues/events{/number}","events_url":"https://api.github.com/repos/bstansberry/wildfly-core/events","assignees_url":"https://api.github.com/repos/bstansberry/wildfly-core/assignees{/user}","branches_url":"https://api.github.com/repos/bstansberry/wildfly-core/branches{/branch}","tags_url":"https://api.github.com/repos/bstansberry/wildfly-core/tags","blobs_url":"https://api.github.com/repos/bstansberry/wildfly-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bstansberry/wildfly-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bstansberry/wildfly-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/bstansberry/wildfly-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bstansberry/wildfly-core/statuses/{sha}","languages_url":"https://api.github.com/repos/bstansberry/wildfly-core/languages","stargazers_url":"https://api.github.com/repos/bstansberry/wildfly-core/stargazers","contributors_url":"https://api.github.com/repos/bstansberry/wildfly-core/contributors","subscribers_url":"https://api.github.com/repos/bstansberry/wildfly-core/subscribers","subscription_url":"https://api.github.com/repos/bstansberry/wildfly-core/subscription","commits_url":"https://api.github.com/repos/bstansberry/wildfly-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/bstansberry/wildfly-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/bstansberry/wildfly-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/bstansberry/wildfly-core/issues/comments/{number}","contents_url":"https://api.github.com/repos/bstansberry/wildfly-core/contents/{+path}","compare_url":"https://api.github.com/repos/bstansberry/wildfly-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bstansberry/wildfly-core/merges","archive_url":"https://api.github.com/repos/bstansberry/wildfly-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bstansberry/wildfly-core/downloads","issues_url":"https://api.github.com/repos/bstansberry/wildfly-core/issues{/number}","pulls_url":"https://api.github.com/repos/bstansberry/wildfly-core/pulls{/number}","milestones_url":"https://api.github.com/repos/bstansberry/wildfly-core/milestones{/number}","notifications_url":"https://api.github.com/repos/bstansberry/wildfly-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bstansberry/wildfly-core/labels{/name}","releases_url":"https://api.github.com/repos/bstansberry/wildfly-core/releases{/id}","created_at":"2014-07-02T17:20:55Z","updated_at":"2014-07-08T16:21:31Z","pushed_at":"2014-10-31T22:15:23Z","git_url":"git://github.com/bstansberry/wildfly-core.git","ssh_url":"git@github.com:bstansberry/wildfly-core.git","clone_url":"https://github.com/bstansberry/wildfly-core.git","svn_url":"https://github.com/bstansberry/wildfly-core","homepage":null,"size":36169,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wildfly:master","ref":"master","sha":"affc9e91e460abf0ccad7132f3b66030e6bcf15c","user":{"login":"wildfly","id":3066274,"avatar_url":"https://avatars.githubusercontent.com/u/3066274?v=2","gravatar_id":"","url":"https://api.github.com/users/wildfly","html_url":"https://github.com/wildfly","followers_url":"https://api.github.com/users/wildfly/followers","following_url":"https://api.github.com/users/wildfly/following{/other_user}","gists_url":"https://api.github.com/users/wildfly/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly/subscriptions","organizations_url":"https://api.github.com/users/wildfly/orgs","repos_url":"https://api.github.com/users/wildfly/repos","events_url":"https://api.github.com/users/wildfly/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly/received_events","type":"Organization","site_admin":false},"repo":{"id":21394954,"name":"wildfly-core","full_name":"wildfly/wildfly-core","owner":{"login":"wildfly","id":3066274,"avatar_url":"https://avatars.githubusercontent.com/u/3066274?v=2","gravatar_id":"","url":"https://api.github.com/users/wildfly","html_url":"https://github.com/wildfly","followers_url":"https://api.github.com/users/wildfly/followers","following_url":"https://api.github.com/users/wildfly/following{/other_user}","gists_url":"https://api.github.com/users/wildfly/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly/subscriptions","organizations_url":"https://api.github.com/users/wildfly/orgs","repos_url":"https://api.github.com/users/wildfly/repos","events_url":"https://api.github.com/users/wildfly/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wildfly/wildfly-core","description":"The core runtime that is used by the Wildfly application server","fork":false,"url":"https://api.github.com/repos/wildfly/wildfly-core","forks_url":"https://api.github.com/repos/wildfly/wildfly-core/forks","keys_url":"https://api.github.com/repos/wildfly/wildfly-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wildfly/wildfly-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wildfly/wildfly-core/teams","hooks_url":"https://api.github.com/repos/wildfly/wildfly-core/hooks","issue_events_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/events{/number}","events_url":"https://api.github.com/repos/wildfly/wildfly-core/events","assignees_url":"https://api.github.com/repos/wildfly/wildfly-core/assignees{/user}","branches_url":"https://api.github.com/repos/wildfly/wildfly-core/branches{/branch}","tags_url":"https://api.github.com/repos/wildfly/wildfly-core/tags","blobs_url":"https://api.github.com/repos/wildfly/wildfly-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wildfly/wildfly-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wildfly/wildfly-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/wildfly/wildfly-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wildfly/wildfly-core/statuses/{sha}","languages_url":"https://api.github.com/repos/wildfly/wildfly-core/languages","stargazers_url":"https://api.github.com/repos/wildfly/wildfly-core/stargazers","contributors_url":"https://api.github.com/repos/wildfly/wildfly-core/contributors","subscribers_url":"https://api.github.com/repos/wildfly/wildfly-core/subscribers","subscription_url":"https://api.github.com/repos/wildfly/wildfly-core/subscription","commits_url":"https://api.github.com/repos/wildfly/wildfly-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/wildfly/wildfly-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/wildfly/wildfly-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/comments/{number}","contents_url":"https://api.github.com/repos/wildfly/wildfly-core/contents/{+path}","compare_url":"https://api.github.com/repos/wildfly/wildfly-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wildfly/wildfly-core/merges","archive_url":"https://api.github.com/repos/wildfly/wildfly-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wildfly/wildfly-core/downloads","issues_url":"https://api.github.com/repos/wildfly/wildfly-core/issues{/number}","pulls_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls{/number}","milestones_url":"https://api.github.com/repos/wildfly/wildfly-core/milestones{/number}","notifications_url":"https://api.github.com/repos/wildfly/wildfly-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wildfly/wildfly-core/labels{/name}","releases_url":"https://api.github.com/repos/wildfly/wildfly-core/releases{/id}","created_at":"2014-07-01T16:33:34Z","updated_at":"2014-10-23T21:05:45Z","pushed_at":"2014-11-01T02:03:22Z","git_url":"git://github.com/wildfly/wildfly-core.git","ssh_url":"git@github.com:wildfly/wildfly-core.git","clone_url":"https://github.com/wildfly/wildfly-core.git","svn_url":"https://github.com/wildfly/wildfly-core","homepage":null,"size":39781,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":74,"mirror_url":null,"open_issues_count":15,"forks":74,"open_issues":15,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/268"},"html":{"href":"https://github.com/wildfly/wildfly-core/pull/268"},"issue":{"href":"https://api.github.com/repos/wildfly/wildfly-core/issues/268"},"comments":{"href":"https://api.github.com/repos/wildfly/wildfly-core/issues/268/comments"},"review_comments":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/268/comments"},"review_comment":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/268/commits"},"statuses":{"href":"https://api.github.com/repos/wildfly/wildfly-core/statuses/5aeae9a25fe62ea439a25c6eb7e12b957343c066"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"bstansberry","id":299242,"avatar_url":"https://avatars.githubusercontent.com/u/299242?v=2","gravatar_id":"","url":"https://api.github.com/users/bstansberry","html_url":"https://github.com/bstansberry","followers_url":"https://api.github.com/users/bstansberry/followers","following_url":"https://api.github.com/users/bstansberry/following{/other_user}","gists_url":"https://api.github.com/users/bstansberry/gists{/gist_id}","starred_url":"https://api.github.com/users/bstansberry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bstansberry/subscriptions","organizations_url":"https://api.github.com/users/bstansberry/orgs","repos_url":"https://api.github.com/users/bstansberry/repos","events_url":"https://api.github.com/users/bstansberry/events{/privacy}","received_events_url":"https://api.github.com/users/bstansberry/received_events","type":"User","site_admin":false},"comments":26,"review_comments":11,"commits":3,"additions":3866,"deletions":594,"changed_files":88}}