GitHub PullRequestReviewCommentEvent at 2014-06-17 07:16:49
Repository: crouton
Actor: drinkcat
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/dnschneid/crouton/pulls/comments/13845755","id":13845755,"diff_hunk":"@@ -15,6 +15,16 @@ CHROOTETC='xbindkeysrc.scm xserverrc-x11 xserverrc-local.example'\n ### Append to prepare.sh:\n XMETHOD=\"${XMETHOD:-x11}\"\n \n+# Check for Haswell PCI id\n+if grep -q 0x8086 /sys/class/graphics/fb0/device/vendor 2>/dev/null && \\\n+        grep -q 0x0a /sys/class/graphics/fb0/device/device 2>/dev/null && \\","path":"targets/xorg","position":6,"original_position":6,"commit_id":"7e9863ef91f9f7accddc0d96539012820874b03a","original_commit_id":"7e9863ef91f9f7accddc0d96539012820874b03a","user":{"login":"drinkcat","id":3467596,"avatar_url":"https://avatars.githubusercontent.com/u/3467596?","gravatar_id":"71b56e9efaad060f167ad772c9b713cb","url":"https://api.github.com/users/drinkcat","html_url":"https://github.com/drinkcat","followers_url":"https://api.github.com/users/drinkcat/followers","following_url":"https://api.github.com/users/drinkcat/following{/other_user}","gists_url":"https://api.github.com/users/drinkcat/gists{/gist_id}","starred_url":"https://api.github.com/users/drinkcat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drinkcat/subscriptions","organizations_url":"https://api.github.com/users/drinkcat/orgs","repos_url":"https://api.github.com/users/drinkcat/repos","events_url":"https://api.github.com/users/drinkcat/events{/privacy}","received_events_url":"https://api.github.com/users/drinkcat/received_events","type":"User","site_admin":false},"body":"> How will this change for Bay Trail \r\n\r\nWe probably need to add it indeed.\r\n\r\n> and future Intel chips? Would some inequality suffice?\r\n\r\nNot really, IDs are not contiguous at all: http://pci-ids.ucw.cz/read/PC/8086. We can't even be sure that `0x0a*` is correct (but that'll probably include future models).\r\n\r\n> Or wouldn't checking the current kernel version be a better test? That's really the source of the incompatibility.\r\n\r\nEven if `x86-mario` got upgraded to 3.8, it probably wouldn't need the fix (old `i915` dri module). Also, `pixel` (Sandybridge) does not require the fix AFAIK (eventhough it's running 3.8).\r\n\r\nNow, we could actually reverse the logic, and install `lts-saucy` in all cases, _except_ where it breaks (i.e. on kernel 3.4).","created_at":"2014-06-17T07:16:49Z","updated_at":"2014-06-17T07:16:49Z","html_url":"https://github.com/dnschneid/crouton/pull/890#discussion_r13845755","pull_request_url":"https://api.github.com/repos/dnschneid/crouton/pulls/890","_links":{"self":{"href":"https://api.github.com/repos/dnschneid/crouton/pulls/comments/13845755"},"html":{"href":"https://github.com/dnschneid/crouton/pull/890#discussion_r13845755"},"pull_request":{"href":"https://api.github.com/repos/dnschneid/crouton/pulls/890"}}},"pull_request":{"url":"https://api.github.com/repos/dnschneid/crouton/pulls/890","id":17214785,"html_url":"https://github.com/dnschneid/crouton/pull/890","diff_url":"https://github.com/dnschneid/crouton/pull/890.diff","patch_url":"https://github.com/dnschneid/crouton/pull/890.patch","issue_url":"https://api.github.com/repos/dnschneid/crouton/issues/890","number":890,"state":"open","title":"targets/xorg: Install lts-saucy drivers on precise for Haswell support","user":{"login":"drinkcat","id":3467596,"avatar_url":"https://avatars.githubusercontent.com/u/3467596?","gravatar_id":"71b56e9efaad060f167ad772c9b713cb","url":"https://api.github.com/users/drinkcat","html_url":"https://github.com/drinkcat","followers_url":"https://api.github.com/users/drinkcat/followers","following_url":"https://api.github.com/users/drinkcat/following{/other_user}","gists_url":"https://api.github.com/users/drinkcat/gists{/gist_id}","starred_url":"https://api.github.com/users/drinkcat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drinkcat/subscriptions","organizations_url":"https://api.github.com/users/drinkcat/orgs","repos_url":"https://api.github.com/users/drinkcat/repos","events_url":"https://api.github.com/users/drinkcat/events{/privacy}","received_events_url":"https://api.github.com/users/drinkcat/received_events","type":"User","site_admin":false},"body":"We first pull in `lts-saucy` replacement drivers, then `xorg`:\r\n- Doing it in that order still pulls in `xorg` dependencies like\r\n  `xterm` and `xinit`, and avoids the need to specify them manually.\r\n- Removing ``--minimal`` from the `lts-saucy` line also works, but\r\n  also pulls in stuff like an updated kernel, which we don't want.\r\n- Installing `xorg` after `lts-saucy` does not install old drivers\r\n  (so there is no useless download).\r\n- On existing chroots, installing `lts-saucy` uninstalls old drivers,\r\n  and marks a number of packages as not required, like `xterm` and\r\n  `xinit` (which would be cleaned later by autoclean). Reinstalling\r\n  `xorg` does not install new packages, but makes sure these packages\r\n  are not autocleaned.\r\n\r\nTested:\r\n - Current HEAD installer, `-t xorg`, then update with this branch: no important package is added or removed.\r\n - Fresh install with this branch: installed packages are same as case above.\r\n - On `peppy`, direct switching between Chrome OS and crouton works with `lts-saucy` drivers (fixes #754, #870, #884 and a few others).\r\n\r\nAlso tested with the (not yet mature) x11 test infrastructure, formatted output here: http://drinkcat.github.io/chroagh/2014-06-17_01-22-27_drinkcat_chroagh_x11test.tmp-add-saucy-lts_35.html . The important bit here is that we have OpenGL acceleration in `precise` on all x86 platforms (fixes #639).","created_at":"2014-06-17T03:23:22Z","updated_at":"2014-06-17T07:16:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4a0d0bf3e9c730ba9087ca46296cf17e9a7d47b9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dnschneid/crouton/pulls/890/commits","review_comments_url":"https://api.github.com/repos/dnschneid/crouton/pulls/890/comments","review_comment_url":"https://api.github.com/repos/dnschneid/crouton/pulls/comments/{number}","comments_url":"https://api.github.com/repos/dnschneid/crouton/issues/890/comments","statuses_url":"https://api.github.com/repos/dnschneid/crouton/statuses/7e9863ef91f9f7accddc0d96539012820874b03a","head":{"label":"drinkcat:precise-haswell-xorg-lts-saucy","ref":"precise-haswell-xorg-lts-saucy","sha":"7e9863ef91f9f7accddc0d96539012820874b03a","user":{"login":"drinkcat","id":3467596,"avatar_url":"https://avatars.githubusercontent.com/u/3467596?","gravatar_id":"71b56e9efaad060f167ad772c9b713cb","url":"https://api.github.com/users/drinkcat","html_url":"https://github.com/drinkcat","followers_url":"https://api.github.com/users/drinkcat/followers","following_url":"https://api.github.com/users/drinkcat/following{/other_user}","gists_url":"https://api.github.com/users/drinkcat/gists{/gist_id}","starred_url":"https://api.github.com/users/drinkcat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drinkcat/subscriptions","organizations_url":"https://api.github.com/users/drinkcat/orgs","repos_url":"https://api.github.com/users/drinkcat/repos","events_url":"https://api.github.com/users/drinkcat/events{/privacy}","received_events_url":"https://api.github.com/users/drinkcat/received_events","type":"User","site_admin":false},"repo":{"id":9856262,"name":"chroagh","full_name":"drinkcat/chroagh","owner":{"login":"drinkcat","id":3467596,"avatar_url":"https://avatars.githubusercontent.com/u/3467596?","gravatar_id":"71b56e9efaad060f167ad772c9b713cb","url":"https://api.github.com/users/drinkcat","html_url":"https://github.com/drinkcat","followers_url":"https://api.github.com/users/drinkcat/followers","following_url":"https://api.github.com/users/drinkcat/following{/other_user}","gists_url":"https://api.github.com/users/drinkcat/gists{/gist_id}","starred_url":"https://api.github.com/users/drinkcat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drinkcat/subscriptions","organizations_url":"https://api.github.com/users/drinkcat/orgs","repos_url":"https://api.github.com/users/drinkcat/repos","events_url":"https://api.github.com/users/drinkcat/events{/privacy}","received_events_url":"https://api.github.com/users/drinkcat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/drinkcat/chroagh","description":"Chromium OS Archlinux Chroot Environment","fork":true,"url":"https://api.github.com/repos/drinkcat/chroagh","forks_url":"https://api.github.com/repos/drinkcat/chroagh/forks","keys_url":"https://api.github.com/repos/drinkcat/chroagh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drinkcat/chroagh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drinkcat/chroagh/teams","hooks_url":"https://api.github.com/repos/drinkcat/chroagh/hooks","issue_events_url":"https://api.github.com/repos/drinkcat/chroagh/issues/events{/number}","events_url":"https://api.github.com/repos/drinkcat/chroagh/events","assignees_url":"https://api.github.com/repos/drinkcat/chroagh/assignees{/user}","branches_url":"https://api.github.com/repos/drinkcat/chroagh/branches{/branch}","tags_url":"https://api.github.com/repos/drinkcat/chroagh/tags","blobs_url":"https://api.github.com/repos/drinkcat/chroagh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drinkcat/chroagh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drinkcat/chroagh/git/refs{/sha}","trees_url":"https://api.github.com/repos/drinkcat/chroagh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drinkcat/chroagh/statuses/{sha}","languages_url":"https://api.github.com/repos/drinkcat/chroagh/languages","stargazers_url":"https://api.github.com/repos/drinkcat/chroagh/stargazers","contributors_url":"https://api.github.com/repos/drinkcat/chroagh/contributors","subscribers_url":"https://api.github.com/repos/drinkcat/chroagh/subscribers","subscription_url":"https://api.github.com/repos/drinkcat/chroagh/subscription","commits_url":"https://api.github.com/repos/drinkcat/chroagh/commits{/sha}","git_commits_url":"https://api.github.com/repos/drinkcat/chroagh/git/commits{/sha}","comments_url":"https://api.github.com/repos/drinkcat/chroagh/comments{/number}","issue_comment_url":"https://api.github.com/repos/drinkcat/chroagh/issues/comments/{number}","contents_url":"https://api.github.com/repos/drinkcat/chroagh/contents/{+path}","compare_url":"https://api.github.com/repos/drinkcat/chroagh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drinkcat/chroagh/merges","archive_url":"https://api.github.com/repos/drinkcat/chroagh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drinkcat/chroagh/downloads","issues_url":"https://api.github.com/repos/drinkcat/chroagh/issues{/number}","pulls_url":"https://api.github.com/repos/drinkcat/chroagh/pulls{/number}","milestones_url":"https://api.github.com/repos/drinkcat/chroagh/milestones{/number}","notifications_url":"https://api.github.com/repos/drinkcat/chroagh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drinkcat/chroagh/labels{/name}","releases_url":"https://api.github.com/repos/drinkcat/chroagh/releases{/id}","created_at":"2013-05-04T15:50:52Z","updated_at":"2014-06-17T03:29:01Z","pushed_at":"2014-06-17T03:15:06Z","git_url":"git://github.com/drinkcat/chroagh.git","ssh_url":"git@github.com:drinkcat/chroagh.git","clone_url":"https://github.com/drinkcat/chroagh.git","svn_url":"https://github.com/drinkcat/chroagh","homepage":"","size":6298,"stargazers_count":52,"watchers_count":52,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":8,"mirror_url":null,"open_issues_count":5,"forks":8,"open_issues":5,"watchers":52,"default_branch":"master"}},"base":{"label":"dnschneid:master","ref":"master","sha":"3c241c94e454a5cfb3823f93b82b89130f532729","user":{"login":"dnschneid","id":522200,"avatar_url":"https://avatars.githubusercontent.com/u/522200?","gravatar_id":"db60821feace7407a3b9bd773998076b","url":"https://api.github.com/users/dnschneid","html_url":"https://github.com/dnschneid","followers_url":"https://api.github.com/users/dnschneid/followers","following_url":"https://api.github.com/users/dnschneid/following{/other_user}","gists_url":"https://api.github.com/users/dnschneid/gists{/gist_id}","starred_url":"https://api.github.com/users/dnschneid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnschneid/subscriptions","organizations_url":"https://api.github.com/users/dnschneid/orgs","repos_url":"https://api.github.com/users/dnschneid/repos","events_url":"https://api.github.com/users/dnschneid/events{/privacy}","received_events_url":"https://api.github.com/users/dnschneid/received_events","type":"User","site_admin":false},"repo":{"id":7229063,"name":"crouton","full_name":"dnschneid/crouton","owner":{"login":"dnschneid","id":522200,"avatar_url":"https://avatars.githubusercontent.com/u/522200?","gravatar_id":"db60821feace7407a3b9bd773998076b","url":"https://api.github.com/users/dnschneid","html_url":"https://github.com/dnschneid","followers_url":"https://api.github.com/users/dnschneid/followers","following_url":"https://api.github.com/users/dnschneid/following{/other_user}","gists_url":"https://api.github.com/users/dnschneid/gists{/gist_id}","starred_url":"https://api.github.com/users/dnschneid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnschneid/subscriptions","organizations_url":"https://api.github.com/users/dnschneid/orgs","repos_url":"https://api.github.com/users/dnschneid/repos","events_url":"https://api.github.com/users/dnschneid/events{/privacy}","received_events_url":"https://api.github.com/users/dnschneid/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dnschneid/crouton","description":"Chromium OS Universal Chroot Environment","fork":false,"url":"https://api.github.com/repos/dnschneid/crouton","forks_url":"https://api.github.com/repos/dnschneid/crouton/forks","keys_url":"https://api.github.com/repos/dnschneid/crouton/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dnschneid/crouton/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dnschneid/crouton/teams","hooks_url":"https://api.github.com/repos/dnschneid/crouton/hooks","issue_events_url":"https://api.github.com/repos/dnschneid/crouton/issues/events{/number}","events_url":"https://api.github.com/repos/dnschneid/crouton/events","assignees_url":"https://api.github.com/repos/dnschneid/crouton/assignees{/user}","branches_url":"https://api.github.com/repos/dnschneid/crouton/branches{/branch}","tags_url":"https://api.github.com/repos/dnschneid/crouton/tags","blobs_url":"https://api.github.com/repos/dnschneid/crouton/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dnschneid/crouton/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dnschneid/crouton/git/refs{/sha}","trees_url":"https://api.github.com/repos/dnschneid/crouton/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dnschneid/crouton/statuses/{sha}","languages_url":"https://api.github.com/repos/dnschneid/crouton/languages","stargazers_url":"https://api.github.com/repos/dnschneid/crouton/stargazers","contributors_url":"https://api.github.com/repos/dnschneid/crouton/contributors","subscribers_url":"https://api.github.com/repos/dnschneid/crouton/subscribers","subscription_url":"https://api.github.com/repos/dnschneid/crouton/subscription","commits_url":"https://api.github.com/repos/dnschneid/crouton/commits{/sha}","git_commits_url":"https://api.github.com/repos/dnschneid/crouton/git/commits{/sha}","comments_url":"https://api.github.com/repos/dnschneid/crouton/comments{/number}","issue_comment_url":"https://api.github.com/repos/dnschneid/crouton/issues/comments/{number}","contents_url":"https://api.github.com/repos/dnschneid/crouton/contents/{+path}","compare_url":"https://api.github.com/repos/dnschneid/crouton/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dnschneid/crouton/merges","archive_url":"https://api.github.com/repos/dnschneid/crouton/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dnschneid/crouton/downloads","issues_url":"https://api.github.com/repos/dnschneid/crouton/issues{/number}","pulls_url":"https://api.github.com/repos/dnschneid/crouton/pulls{/number}","milestones_url":"https://api.github.com/repos/dnschneid/crouton/milestones{/number}","notifications_url":"https://api.github.com/repos/dnschneid/crouton/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dnschneid/crouton/labels{/name}","releases_url":"https://api.github.com/repos/dnschneid/crouton/releases{/id}","created_at":"2012-12-18T19:31:14Z","updated_at":"2014-06-17T03:05:48Z","pushed_at":"2014-06-10T03:26:23Z","git_url":"git://github.com/dnschneid/crouton.git","ssh_url":"git@github.com:dnschneid/crouton.git","clone_url":"https://github.com/dnschneid/crouton.git","svn_url":"https://github.com/dnschneid/crouton","homepage":"http://goo.gl/fd3zc","size":9927,"stargazers_count":1708,"watchers_count":1708,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":168,"mirror_url":null,"open_issues_count":166,"forks":168,"open_issues":166,"watchers":1708,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dnschneid/crouton/pulls/890"},"html":{"href":"https://github.com/dnschneid/crouton/pull/890"},"issue":{"href":"https://api.github.com/repos/dnschneid/crouton/issues/890"},"comments":{"href":"https://api.github.com/repos/dnschneid/crouton/issues/890/comments"},"review_comments":{"href":"https://api.github.com/repos/dnschneid/crouton/pulls/890/comments"},"review_comment":{"href":"https://api.github.com/repos/dnschneid/crouton/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/dnschneid/crouton/pulls/890/commits"},"statuses":{"href":"https://api.github.com/repos/dnschneid/crouton/statuses/7e9863ef91f9f7accddc0d96539012820874b03a"}}}}