GitHub PullRequestReviewCommentEvent at 2014-05-15 22:28:42
Repository: elasticsearch
Actor: kimchy
Payload: {"comment":{"url":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/comments/12717268","id":12717268,"diff_hunk":"@@ -243,165 +243,6 @@ private static long optionalSum(long left, long right) {\n         return lastEmittedDocPerShard;\n     }\n \n-    public ScoreDoc[] sortDocs(AtomicArray<? extends QuerySearchResultProvider> resultsArr) {\n-        List<? extends AtomicArray.Entry<? extends QuerySearchResultProvider>> results = resultsArr.asList();\n-        if (results.isEmpty()) {\n-            return EMPTY_DOCS;\n-        }\n-\n-        if (optimizeSingleShard) {","path":"src/main/java/org/elasticsearch/search/controller/SearchPhaseController.java","position":66,"original_position":66,"commit_id":"1e06b7e67e80588c40a483637d059bc07509a875","original_commit_id":"1e06b7e67e80588c40a483637d059bc07509a875","user":{"login":"kimchy","id":41300,"avatar_url":"https://avatars.githubusercontent.com/u/41300?","gravatar_id":"fd44bb3c96e34e000c5453a0078900d6","url":"https://api.github.com/users/kimchy","html_url":"https://github.com/kimchy","followers_url":"https://api.github.com/users/kimchy/followers","following_url":"https://api.github.com/users/kimchy/following{/other_user}","gists_url":"https://api.github.com/users/kimchy/gists{/gist_id}","starred_url":"https://api.github.com/users/kimchy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kimchy/subscriptions","organizations_url":"https://api.github.com/users/kimchy/orgs","repos_url":"https://api.github.com/users/kimchy/repos","events_url":"https://api.github.com/users/kimchy/events{/privacy}","received_events_url":"https://api.github.com/users/kimchy/received_events","type":"User","site_admin":false},"body":"is this field still being used? I don't think so, we can remove it from the class?","created_at":"2014-05-15T22:28:42Z","updated_at":"2014-05-15T22:28:42Z","html_url":"https://github.com/elasticsearch/elasticsearch/pull/6197#discussion_r12717268","pull_request_url":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/6197","_links":{"self":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/comments/12717268"},"html":{"href":"https://github.com/elasticsearch/elasticsearch/pull/6197#discussion_r12717268"},"pull_request":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/6197"}}}}