GitHub PullRequestEvent at 2014-09-28 14:23:04
Repository: CacheStack
Actor: jgeurts
Payload: {"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/jgeurts/CacheStack/pulls/1","id":21894534,"html_url":"https://github.com/jgeurts/CacheStack/pull/1","diff_url":"https://github.com/jgeurts/CacheStack/pull/1.diff","patch_url":"https://github.com/jgeurts/CacheStack/pull/1.patch","issue_url":"https://api.github.com/repos/jgeurts/CacheStack/issues/1","number":1,"state":"closed","locked":false,"title":"Prevent duplicate triggers from being added","user":{"login":"jwynveen","id":540448,"avatar_url":"https://avatars.githubusercontent.com/u/540448?v=2","gravatar_id":"","url":"https://api.github.com/users/jwynveen","html_url":"https://github.com/jwynveen","followers_url":"https://api.github.com/users/jwynveen/followers","following_url":"https://api.github.com/users/jwynveen/following{/other_user}","gists_url":"https://api.github.com/users/jwynveen/gists{/gist_id}","starred_url":"https://api.github.com/users/jwynveen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwynveen/subscriptions","organizations_url":"https://api.github.com/users/jwynveen/orgs","repos_url":"https://api.github.com/users/jwynveen/repos","events_url":"https://api.github.com/users/jwynveen/events{/privacy}","received_events_url":"https://api.github.com/users/jwynveen/received_events","type":"User","site_admin":false},"body":"Triggers were indeed being added more than once. You already had a function to handle that so I utilized it. Also added a FlushTriggers() extensions since you could do a cache.FlushAll() but leave all of your triggers orphaned. Not sure if that is really a problem, but can't hurt much to add. It would be good to hook it into the MemoryCacheClient.FlushAll() method so that you don't even have to think about it. Can't do that until this is merged though.","created_at":"2014-09-27T21:45:38Z","updated_at":"2014-09-28T14:23:04Z","closed_at":"2014-09-28T14:23:04Z","merged_at":"2014-09-28T14:23:04Z","merge_commit_sha":"fccde52f70440374a7cf66fb27974ad461b423e3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jgeurts/CacheStack/pulls/1/commits","review_comments_url":"https://api.github.com/repos/jgeurts/CacheStack/pulls/1/comments","review_comment_url":"https://api.github.com/repos/jgeurts/CacheStack/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jgeurts/CacheStack/issues/1/comments","statuses_url":"https://api.github.com/repos/jgeurts/CacheStack/statuses/9705fa1c67f5da3181374abbe1c65cfbbbd9c447","head":{"label":"jwynveen:master","ref":"master","sha":"9705fa1c67f5da3181374abbe1c65cfbbbd9c447","user":{"login":"jwynveen","id":540448,"avatar_url":"https://avatars.githubusercontent.com/u/540448?v=2","gravatar_id":"","url":"https://api.github.com/users/jwynveen","html_url":"https://github.com/jwynveen","followers_url":"https://api.github.com/users/jwynveen/followers","following_url":"https://api.github.com/users/jwynveen/following{/other_user}","gists_url":"https://api.github.com/users/jwynveen/gists{/gist_id}","starred_url":"https://api.github.com/users/jwynveen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwynveen/subscriptions","organizations_url":"https://api.github.com/users/jwynveen/orgs","repos_url":"https://api.github.com/users/jwynveen/repos","events_url":"https://api.github.com/users/jwynveen/events{/privacy}","received_events_url":"https://api.github.com/users/jwynveen/received_events","type":"User","site_admin":false},"repo":{"id":24538312,"name":"CacheStack","full_name":"jwynveen/CacheStack","owner":{"login":"jwynveen","id":540448,"avatar_url":"https://avatars.githubusercontent.com/u/540448?v=2","gravatar_id":"","url":"https://api.github.com/users/jwynveen","html_url":"https://github.com/jwynveen","followers_url":"https://api.github.com/users/jwynveen/followers","following_url":"https://api.github.com/users/jwynveen/following{/other_user}","gists_url":"https://api.github.com/users/jwynveen/gists{/gist_id}","starred_url":"https://api.github.com/users/jwynveen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwynveen/subscriptions","organizations_url":"https://api.github.com/users/jwynveen/orgs","repos_url":"https://api.github.com/users/jwynveen/repos","events_url":"https://api.github.com/users/jwynveen/events{/privacy}","received_events_url":"https://api.github.com/users/jwynveen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jwynveen/CacheStack","description":"Cache context and donut caching built on top of ServiceStack's ICacheClient","fork":true,"url":"https://api.github.com/repos/jwynveen/CacheStack","forks_url":"https://api.github.com/repos/jwynveen/CacheStack/forks","keys_url":"https://api.github.com/repos/jwynveen/CacheStack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jwynveen/CacheStack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jwynveen/CacheStack/teams","hooks_url":"https://api.github.com/repos/jwynveen/CacheStack/hooks","issue_events_url":"https://api.github.com/repos/jwynveen/CacheStack/issues/events{/number}","events_url":"https://api.github.com/repos/jwynveen/CacheStack/events","assignees_url":"https://api.github.com/repos/jwynveen/CacheStack/assignees{/user}","branches_url":"https://api.github.com/repos/jwynveen/CacheStack/branches{/branch}","tags_url":"https://api.github.com/repos/jwynveen/CacheStack/tags","blobs_url":"https://api.github.com/repos/jwynveen/CacheStack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jwynveen/CacheStack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jwynveen/CacheStack/git/refs{/sha}","trees_url":"https://api.github.com/repos/jwynveen/CacheStack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jwynveen/CacheStack/statuses/{sha}","languages_url":"https://api.github.com/repos/jwynveen/CacheStack/languages","stargazers_url":"https://api.github.com/repos/jwynveen/CacheStack/stargazers","contributors_url":"https://api.github.com/repos/jwynveen/CacheStack/contributors","subscribers_url":"https://api.github.com/repos/jwynveen/CacheStack/subscribers","subscription_url":"https://api.github.com/repos/jwynveen/CacheStack/subscription","commits_url":"https://api.github.com/repos/jwynveen/CacheStack/commits{/sha}","git_commits_url":"https://api.github.com/repos/jwynveen/CacheStack/git/commits{/sha}","comments_url":"https://api.github.com/repos/jwynveen/CacheStack/comments{/number}","issue_comment_url":"https://api.github.com/repos/jwynveen/CacheStack/issues/comments/{number}","contents_url":"https://api.github.com/repos/jwynveen/CacheStack/contents/{+path}","compare_url":"https://api.github.com/repos/jwynveen/CacheStack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jwynveen/CacheStack/merges","archive_url":"https://api.github.com/repos/jwynveen/CacheStack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jwynveen/CacheStack/downloads","issues_url":"https://api.github.com/repos/jwynveen/CacheStack/issues{/number}","pulls_url":"https://api.github.com/repos/jwynveen/CacheStack/pulls{/number}","milestones_url":"https://api.github.com/repos/jwynveen/CacheStack/milestones{/number}","notifications_url":"https://api.github.com/repos/jwynveen/CacheStack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jwynveen/CacheStack/labels{/name}","releases_url":"https://api.github.com/repos/jwynveen/CacheStack/releases{/id}","created_at":"2014-09-27T17:38:12Z","updated_at":"2014-09-27T21:36:27Z","pushed_at":"2014-09-27T21:36:27Z","git_url":"git://github.com/jwynveen/CacheStack.git","ssh_url":"git@github.com:jwynveen/CacheStack.git","clone_url":"https://github.com/jwynveen/CacheStack.git","svn_url":"https://github.com/jwynveen/CacheStack","homepage":null,"size":367,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jgeurts:master","ref":"master","sha":"19ef19d65900343b3022b281d6710dead6d7632f","user":{"login":"jgeurts","id":158937,"avatar_url":"https://avatars.githubusercontent.com/u/158937?v=2","gravatar_id":"","url":"https://api.github.com/users/jgeurts","html_url":"https://github.com/jgeurts","followers_url":"https://api.github.com/users/jgeurts/followers","following_url":"https://api.github.com/users/jgeurts/following{/other_user}","gists_url":"https://api.github.com/users/jgeurts/gists{/gist_id}","starred_url":"https://api.github.com/users/jgeurts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgeurts/subscriptions","organizations_url":"https://api.github.com/users/jgeurts/orgs","repos_url":"https://api.github.com/users/jgeurts/repos","events_url":"https://api.github.com/users/jgeurts/events{/privacy}","received_events_url":"https://api.github.com/users/jgeurts/received_events","type":"User","site_admin":false},"repo":{"id":10004792,"name":"CacheStack","full_name":"jgeurts/CacheStack","owner":{"login":"jgeurts","id":158937,"avatar_url":"https://avatars.githubusercontent.com/u/158937?v=2","gravatar_id":"","url":"https://api.github.com/users/jgeurts","html_url":"https://github.com/jgeurts","followers_url":"https://api.github.com/users/jgeurts/followers","following_url":"https://api.github.com/users/jgeurts/following{/other_user}","gists_url":"https://api.github.com/users/jgeurts/gists{/gist_id}","starred_url":"https://api.github.com/users/jgeurts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgeurts/subscriptions","organizations_url":"https://api.github.com/users/jgeurts/orgs","repos_url":"https://api.github.com/users/jgeurts/repos","events_url":"https://api.github.com/users/jgeurts/events{/privacy}","received_events_url":"https://api.github.com/users/jgeurts/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jgeurts/CacheStack","description":"Cache context and donut caching built on top of ServiceStack's ICacheClient","fork":false,"url":"https://api.github.com/repos/jgeurts/CacheStack","forks_url":"https://api.github.com/repos/jgeurts/CacheStack/forks","keys_url":"https://api.github.com/repos/jgeurts/CacheStack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jgeurts/CacheStack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jgeurts/CacheStack/teams","hooks_url":"https://api.github.com/repos/jgeurts/CacheStack/hooks","issue_events_url":"https://api.github.com/repos/jgeurts/CacheStack/issues/events{/number}","events_url":"https://api.github.com/repos/jgeurts/CacheStack/events","assignees_url":"https://api.github.com/repos/jgeurts/CacheStack/assignees{/user}","branches_url":"https://api.github.com/repos/jgeurts/CacheStack/branches{/branch}","tags_url":"https://api.github.com/repos/jgeurts/CacheStack/tags","blobs_url":"https://api.github.com/repos/jgeurts/CacheStack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jgeurts/CacheStack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jgeurts/CacheStack/git/refs{/sha}","trees_url":"https://api.github.com/repos/jgeurts/CacheStack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jgeurts/CacheStack/statuses/{sha}","languages_url":"https://api.github.com/repos/jgeurts/CacheStack/languages","stargazers_url":"https://api.github.com/repos/jgeurts/CacheStack/stargazers","contributors_url":"https://api.github.com/repos/jgeurts/CacheStack/contributors","subscribers_url":"https://api.github.com/repos/jgeurts/CacheStack/subscribers","subscription_url":"https://api.github.com/repos/jgeurts/CacheStack/subscription","commits_url":"https://api.github.com/repos/jgeurts/CacheStack/commits{/sha}","git_commits_url":"https://api.github.com/repos/jgeurts/CacheStack/git/commits{/sha}","comments_url":"https://api.github.com/repos/jgeurts/CacheStack/comments{/number}","issue_comment_url":"https://api.github.com/repos/jgeurts/CacheStack/issues/comments/{number}","contents_url":"https://api.github.com/repos/jgeurts/CacheStack/contents/{+path}","compare_url":"https://api.github.com/repos/jgeurts/CacheStack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jgeurts/CacheStack/merges","archive_url":"https://api.github.com/repos/jgeurts/CacheStack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jgeurts/CacheStack/downloads","issues_url":"https://api.github.com/repos/jgeurts/CacheStack/issues{/number}","pulls_url":"https://api.github.com/repos/jgeurts/CacheStack/pulls{/number}","milestones_url":"https://api.github.com/repos/jgeurts/CacheStack/milestones{/number}","notifications_url":"https://api.github.com/repos/jgeurts/CacheStack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jgeurts/CacheStack/labels{/name}","releases_url":"https://api.github.com/repos/jgeurts/CacheStack/releases{/id}","created_at":"2013-05-11T20:22:59Z","updated_at":"2014-08-15T01:58:28Z","pushed_at":"2014-09-28T14:23:04Z","git_url":"git://github.com/jgeurts/CacheStack.git","ssh_url":"git@github.com:jgeurts/CacheStack.git","clone_url":"https://github.com/jgeurts/CacheStack.git","svn_url":"https://github.com/jgeurts/CacheStack","homepage":null,"size":428,"stargazers_count":2,"watchers_count":2,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jgeurts/CacheStack/pulls/1"},"html":{"href":"https://github.com/jgeurts/CacheStack/pull/1"},"issue":{"href":"https://api.github.com/repos/jgeurts/CacheStack/issues/1"},"comments":{"href":"https://api.github.com/repos/jgeurts/CacheStack/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/jgeurts/CacheStack/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/jgeurts/CacheStack/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jgeurts/CacheStack/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/jgeurts/CacheStack/statuses/9705fa1c67f5da3181374abbe1c65cfbbbd9c447"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jgeurts","id":158937,"avatar_url":"https://avatars.githubusercontent.com/u/158937?v=2","gravatar_id":"","url":"https://api.github.com/users/jgeurts","html_url":"https://github.com/jgeurts","followers_url":"https://api.github.com/users/jgeurts/followers","following_url":"https://api.github.com/users/jgeurts/following{/other_user}","gists_url":"https://api.github.com/users/jgeurts/gists{/gist_id}","starred_url":"https://api.github.com/users/jgeurts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgeurts/subscriptions","organizations_url":"https://api.github.com/users/jgeurts/orgs","repos_url":"https://api.github.com/users/jgeurts/repos","events_url":"https://api.github.com/users/jgeurts/events{/privacy}","received_events_url":"https://api.github.com/users/jgeurts/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":11,"deletions":2,"changed_files":1}}