GitHub PullRequestEvent at 2014-12-17 18:42:38
Repository: waffle
Actor: dcbaker
Payload: {"action":"opened","number":28,"pull_request":{"url":"https://api.github.com/repos/waffle-gl/waffle/pulls/28","id":26246355,"html_url":"https://github.com/waffle-gl/waffle/pull/28","diff_url":"https://github.com/waffle-gl/waffle/pull/28.diff","patch_url":"https://github.com/waffle-gl/waffle/pull/28.patch","issue_url":"https://api.github.com/repos/waffle-gl/waffle/issues/28","number":28,"state":"open","locked":false,"title":"cmake: fix version search","user":{"login":"dcbaker","id":1779595,"avatar_url":"https://avatars.githubusercontent.com/u/1779595?v=3","gravatar_id":"","url":"https://api.github.com/users/dcbaker","html_url":"https://github.com/dcbaker","followers_url":"https://api.github.com/users/dcbaker/followers","following_url":"https://api.github.com/users/dcbaker/following{/other_user}","gists_url":"https://api.github.com/users/dcbaker/gists{/gist_id}","starred_url":"https://api.github.com/users/dcbaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcbaker/subscriptions","organizations_url":"https://api.github.com/users/dcbaker/orgs","repos_url":"https://api.github.com/users/dcbaker/repos","events_url":"https://api.github.com/users/dcbaker/events{/privacy}","received_events_url":"https://api.github.com/users/dcbaker/received_events","type":"User","site_admin":false},"body":"Currently the cmake file uses both WAFFLE_INCLUDE_DIR and\r\nWAFFLE_INCLUDE_DIRS, but only the DIRS version is actually defined.\r\ncmake doesn't complain about the undefined variable, instead it treats\r\nit as a blank string. This leads to the version never being checked.\r\n\r\nThis patch replaces DIR with DIRS, which corrects the problem.\r\n\r\nFixes: https://github.com/waffle-gl/waffle/issues/27\r\nSigned-off-by: Dylan Baker <dylanx.c.baker@intel.com>\r\n\r\nI agree with emil that the right solution in the long term is to replace this file with package config and version files is a better idea than providing a find file, but this is here and very easy to get fixed and working.","created_at":"2014-12-17T18:42:38Z","updated_at":"2014-12-17T18:42:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/waffle-gl/waffle/pulls/28/commits","review_comments_url":"https://api.github.com/repos/waffle-gl/waffle/pulls/28/comments","review_comment_url":"https://api.github.com/repos/waffle-gl/waffle/pulls/comments/{number}","comments_url":"https://api.github.com/repos/waffle-gl/waffle/issues/28/comments","statuses_url":"https://api.github.com/repos/waffle-gl/waffle/statuses/a30d55bdfb22855a8f9240fe8f635018720b22bd","head":{"label":"dcbaker:wip/fix-cmake","ref":"wip/fix-cmake","sha":"a30d55bdfb22855a8f9240fe8f635018720b22bd","user":{"login":"dcbaker","id":1779595,"avatar_url":"https://avatars.githubusercontent.com/u/1779595?v=3","gravatar_id":"","url":"https://api.github.com/users/dcbaker","html_url":"https://github.com/dcbaker","followers_url":"https://api.github.com/users/dcbaker/followers","following_url":"https://api.github.com/users/dcbaker/following{/other_user}","gists_url":"https://api.github.com/users/dcbaker/gists{/gist_id}","starred_url":"https://api.github.com/users/dcbaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcbaker/subscriptions","organizations_url":"https://api.github.com/users/dcbaker/orgs","repos_url":"https://api.github.com/users/dcbaker/repos","events_url":"https://api.github.com/users/dcbaker/events{/privacy}","received_events_url":"https://api.github.com/users/dcbaker/received_events","type":"User","site_admin":false},"repo":{"id":26778860,"name":"waffle","full_name":"dcbaker/waffle","owner":{"login":"dcbaker","id":1779595,"avatar_url":"https://avatars.githubusercontent.com/u/1779595?v=3","gravatar_id":"","url":"https://api.github.com/users/dcbaker","html_url":"https://github.com/dcbaker","followers_url":"https://api.github.com/users/dcbaker/followers","following_url":"https://api.github.com/users/dcbaker/following{/other_user}","gists_url":"https://api.github.com/users/dcbaker/gists{/gist_id}","starred_url":"https://api.github.com/users/dcbaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcbaker/subscriptions","organizations_url":"https://api.github.com/users/dcbaker/orgs","repos_url":"https://api.github.com/users/dcbaker/repos","events_url":"https://api.github.com/users/dcbaker/events{/privacy}","received_events_url":"https://api.github.com/users/dcbaker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dcbaker/waffle","description":"A C library for selecting an OpenGL API and window system at runtime","fork":true,"url":"https://api.github.com/repos/dcbaker/waffle","forks_url":"https://api.github.com/repos/dcbaker/waffle/forks","keys_url":"https://api.github.com/repos/dcbaker/waffle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcbaker/waffle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcbaker/waffle/teams","hooks_url":"https://api.github.com/repos/dcbaker/waffle/hooks","issue_events_url":"https://api.github.com/repos/dcbaker/waffle/issues/events{/number}","events_url":"https://api.github.com/repos/dcbaker/waffle/events","assignees_url":"https://api.github.com/repos/dcbaker/waffle/assignees{/user}","branches_url":"https://api.github.com/repos/dcbaker/waffle/branches{/branch}","tags_url":"https://api.github.com/repos/dcbaker/waffle/tags","blobs_url":"https://api.github.com/repos/dcbaker/waffle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcbaker/waffle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcbaker/waffle/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcbaker/waffle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcbaker/waffle/statuses/{sha}","languages_url":"https://api.github.com/repos/dcbaker/waffle/languages","stargazers_url":"https://api.github.com/repos/dcbaker/waffle/stargazers","contributors_url":"https://api.github.com/repos/dcbaker/waffle/contributors","subscribers_url":"https://api.github.com/repos/dcbaker/waffle/subscribers","subscription_url":"https://api.github.com/repos/dcbaker/waffle/subscription","commits_url":"https://api.github.com/repos/dcbaker/waffle/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcbaker/waffle/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcbaker/waffle/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcbaker/waffle/issues/comments/{number}","contents_url":"https://api.github.com/repos/dcbaker/waffle/contents/{+path}","compare_url":"https://api.github.com/repos/dcbaker/waffle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcbaker/waffle/merges","archive_url":"https://api.github.com/repos/dcbaker/waffle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcbaker/waffle/downloads","issues_url":"https://api.github.com/repos/dcbaker/waffle/issues{/number}","pulls_url":"https://api.github.com/repos/dcbaker/waffle/pulls{/number}","milestones_url":"https://api.github.com/repos/dcbaker/waffle/milestones{/number}","notifications_url":"https://api.github.com/repos/dcbaker/waffle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcbaker/waffle/labels{/name}","releases_url":"https://api.github.com/repos/dcbaker/waffle/releases{/id}","created_at":"2014-11-17T21:47:14Z","updated_at":"2014-11-17T21:47:15Z","pushed_at":"2014-12-17T18:41:20Z","git_url":"git://github.com/dcbaker/waffle.git","ssh_url":"git@github.com:dcbaker/waffle.git","clone_url":"https://github.com/dcbaker/waffle.git","svn_url":"https://github.com/dcbaker/waffle","homepage":"http://waffle-gl.org","size":1616,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"waffle-gl:master","ref":"master","sha":"b8195f9b1a3a667a3106750dd68c8e2430f3dd84","user":{"login":"waffle-gl","id":6892448,"avatar_url":"https://avatars.githubusercontent.com/u/6892448?v=3","gravatar_id":"","url":"https://api.github.com/users/waffle-gl","html_url":"https://github.com/waffle-gl","followers_url":"https://api.github.com/users/waffle-gl/followers","following_url":"https://api.github.com/users/waffle-gl/following{/other_user}","gists_url":"https://api.github.com/users/waffle-gl/gists{/gist_id}","starred_url":"https://api.github.com/users/waffle-gl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waffle-gl/subscriptions","organizations_url":"https://api.github.com/users/waffle-gl/orgs","repos_url":"https://api.github.com/users/waffle-gl/repos","events_url":"https://api.github.com/users/waffle-gl/events{/privacy}","received_events_url":"https://api.github.com/users/waffle-gl/received_events","type":"Organization","site_admin":false},"repo":{"id":6061842,"name":"waffle","full_name":"waffle-gl/waffle","owner":{"login":"waffle-gl","id":6892448,"avatar_url":"https://avatars.githubusercontent.com/u/6892448?v=3","gravatar_id":"","url":"https://api.github.com/users/waffle-gl","html_url":"https://github.com/waffle-gl","followers_url":"https://api.github.com/users/waffle-gl/followers","following_url":"https://api.github.com/users/waffle-gl/following{/other_user}","gists_url":"https://api.github.com/users/waffle-gl/gists{/gist_id}","starred_url":"https://api.github.com/users/waffle-gl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waffle-gl/subscriptions","organizations_url":"https://api.github.com/users/waffle-gl/orgs","repos_url":"https://api.github.com/users/waffle-gl/repos","events_url":"https://api.github.com/users/waffle-gl/events{/privacy}","received_events_url":"https://api.github.com/users/waffle-gl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/waffle-gl/waffle","description":"A C library for selecting an OpenGL API and window system at runtime","fork":false,"url":"https://api.github.com/repos/waffle-gl/waffle","forks_url":"https://api.github.com/repos/waffle-gl/waffle/forks","keys_url":"https://api.github.com/repos/waffle-gl/waffle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/waffle-gl/waffle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/waffle-gl/waffle/teams","hooks_url":"https://api.github.com/repos/waffle-gl/waffle/hooks","issue_events_url":"https://api.github.com/repos/waffle-gl/waffle/issues/events{/number}","events_url":"https://api.github.com/repos/waffle-gl/waffle/events","assignees_url":"https://api.github.com/repos/waffle-gl/waffle/assignees{/user}","branches_url":"https://api.github.com/repos/waffle-gl/waffle/branches{/branch}","tags_url":"https://api.github.com/repos/waffle-gl/waffle/tags","blobs_url":"https://api.github.com/repos/waffle-gl/waffle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/waffle-gl/waffle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/waffle-gl/waffle/git/refs{/sha}","trees_url":"https://api.github.com/repos/waffle-gl/waffle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/waffle-gl/waffle/statuses/{sha}","languages_url":"https://api.github.com/repos/waffle-gl/waffle/languages","stargazers_url":"https://api.github.com/repos/waffle-gl/waffle/stargazers","contributors_url":"https://api.github.com/repos/waffle-gl/waffle/contributors","subscribers_url":"https://api.github.com/repos/waffle-gl/waffle/subscribers","subscription_url":"https://api.github.com/repos/waffle-gl/waffle/subscription","commits_url":"https://api.github.com/repos/waffle-gl/waffle/commits{/sha}","git_commits_url":"https://api.github.com/repos/waffle-gl/waffle/git/commits{/sha}","comments_url":"https://api.github.com/repos/waffle-gl/waffle/comments{/number}","issue_comment_url":"https://api.github.com/repos/waffle-gl/waffle/issues/comments/{number}","contents_url":"https://api.github.com/repos/waffle-gl/waffle/contents/{+path}","compare_url":"https://api.github.com/repos/waffle-gl/waffle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/waffle-gl/waffle/merges","archive_url":"https://api.github.com/repos/waffle-gl/waffle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/waffle-gl/waffle/downloads","issues_url":"https://api.github.com/repos/waffle-gl/waffle/issues{/number}","pulls_url":"https://api.github.com/repos/waffle-gl/waffle/pulls{/number}","milestones_url":"https://api.github.com/repos/waffle-gl/waffle/milestones{/number}","notifications_url":"https://api.github.com/repos/waffle-gl/waffle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/waffle-gl/waffle/labels{/name}","releases_url":"https://api.github.com/repos/waffle-gl/waffle/releases{/id}","created_at":"2012-10-03T15:08:07Z","updated_at":"2014-12-16T20:09:27Z","pushed_at":"2014-12-16T20:09:27Z","git_url":"git://github.com/waffle-gl/waffle.git","ssh_url":"git@github.com:waffle-gl/waffle.git","clone_url":"https://github.com/waffle-gl/waffle.git","svn_url":"https://github.com/waffle-gl/waffle","homepage":"http://waffle-gl.org","size":2841,"stargazers_count":8,"watchers_count":8,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":7,"forks":8,"open_issues":7,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/waffle-gl/waffle/pulls/28"},"html":{"href":"https://github.com/waffle-gl/waffle/pull/28"},"issue":{"href":"https://api.github.com/repos/waffle-gl/waffle/issues/28"},"comments":{"href":"https://api.github.com/repos/waffle-gl/waffle/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/waffle-gl/waffle/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/waffle-gl/waffle/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/waffle-gl/waffle/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/waffle-gl/waffle/statuses/a30d55bdfb22855a8f9240fe8f635018720b22bd"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":4,"changed_files":1}}