GitHub PullRequestReviewCommentEvent at 2014-10-28 21:52:10
Repository: wildfly-elytron
Actor: dmlloyd
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/pulls/comments/19506805","id":19506805,"diff_hunk":"@@ -49,6 +50,11 @@\n         this.hash = hash.clone();\n     }\n \n+    UnixDESCryptPasswordImpl(final ClearPasswordSpec spec) throws InvalidKeySpecException {\n+        this.salt = (short) (ThreadLocalRandom.current().nextInt() & 0xff);","path":"src/main/java/org/wildfly/security/password/impl/UnixDESCryptPasswordImpl.java","position":13,"original_position":13,"commit_id":"58315ed2024d12a86f01e1d0a369e1d5af06bb1e","original_commit_id":"58315ed2024d12a86f01e1d0a369e1d5af06bb1e","user":{"login":"dmlloyd","id":124581,"avatar_url":"https://avatars.githubusercontent.com/u/124581?v=2","gravatar_id":"","url":"https://api.github.com/users/dmlloyd","html_url":"https://github.com/dmlloyd","followers_url":"https://api.github.com/users/dmlloyd/followers","following_url":"https://api.github.com/users/dmlloyd/following{/other_user}","gists_url":"https://api.github.com/users/dmlloyd/gists{/gist_id}","starred_url":"https://api.github.com/users/dmlloyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmlloyd/subscriptions","organizations_url":"https://api.github.com/users/dmlloyd/orgs","repos_url":"https://api.github.com/users/dmlloyd/repos","events_url":"https://api.github.com/users/dmlloyd/events{/privacy}","received_events_url":"https://api.github.com/users/dmlloyd/received_events","type":"User","site_admin":false},"body":"Shouldn't this be:\r\n```\r\n        this.salt = (short) (ThreadLocalRandom.current().nextInt() & 0xfff);\r\n```\r\n\r\ni.e. 12 bits instead of 8?","created_at":"2014-10-28T21:52:10Z","updated_at":"2014-10-28T21:52:10Z","html_url":"https://github.com/wildfly-security/wildfly-elytron/pull/72#discussion_r19506805","pull_request_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/pulls/72","_links":{"self":{"href":"https://api.github.com/repos/wildfly-security/wildfly-elytron/pulls/comments/19506805"},"html":{"href":"https://github.com/wildfly-security/wildfly-elytron/pull/72#discussion_r19506805"},"pull_request":{"href":"https://api.github.com/repos/wildfly-security/wildfly-elytron/pulls/72"}}},"pull_request":{"url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/pulls/72","id":23490500,"html_url":"https://github.com/wildfly-security/wildfly-elytron/pull/72","diff_url":"https://github.com/wildfly-security/wildfly-elytron/pull/72.diff","patch_url":"https://github.com/wildfly-security/wildfly-elytron/pull/72.patch","issue_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/issues/72","number":72,"state":"open","locked":false,"title":"[ELY-95] Allow usage of ClearPasswordSpec to hash passwords using random...","user":{"login":"sguilhen","id":355702,"avatar_url":"https://avatars.githubusercontent.com/u/355702?v=2","gravatar_id":"","url":"https://api.github.com/users/sguilhen","html_url":"https://github.com/sguilhen","followers_url":"https://api.github.com/users/sguilhen/followers","following_url":"https://api.github.com/users/sguilhen/following{/other_user}","gists_url":"https://api.github.com/users/sguilhen/gists{/gist_id}","starred_url":"https://api.github.com/users/sguilhen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sguilhen/subscriptions","organizations_url":"https://api.github.com/users/sguilhen/orgs","repos_url":"https://api.github.com/users/sguilhen/repos","events_url":"https://api.github.com/users/sguilhen/events{/privacy}","received_events_url":"https://api.github.com/users/sguilhen/received_events","type":"User","site_admin":false},"body":"... salt and default iteration count","created_at":"2014-10-28T21:07:37Z","updated_at":"2014-10-28T21:52:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a0eee2fb6396e08b4f251c21214452d37c02a217","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/pulls/72/commits","review_comments_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/pulls/72/comments","review_comment_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/pulls/comments/{number}","comments_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/issues/72/comments","statuses_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/statuses/58315ed2024d12a86f01e1d0a369e1d5af06bb1e","head":{"label":"sguilhen:ely95","ref":"ely95","sha":"58315ed2024d12a86f01e1d0a369e1d5af06bb1e","user":{"login":"sguilhen","id":355702,"avatar_url":"https://avatars.githubusercontent.com/u/355702?v=2","gravatar_id":"","url":"https://api.github.com/users/sguilhen","html_url":"https://github.com/sguilhen","followers_url":"https://api.github.com/users/sguilhen/followers","following_url":"https://api.github.com/users/sguilhen/following{/other_user}","gists_url":"https://api.github.com/users/sguilhen/gists{/gist_id}","starred_url":"https://api.github.com/users/sguilhen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sguilhen/subscriptions","organizations_url":"https://api.github.com/users/sguilhen/orgs","repos_url":"https://api.github.com/users/sguilhen/repos","events_url":"https://api.github.com/users/sguilhen/events{/privacy}","received_events_url":"https://api.github.com/users/sguilhen/received_events","type":"User","site_admin":false},"repo":{"id":19499629,"name":"wildfly-elytron","full_name":"sguilhen/wildfly-elytron","owner":{"login":"sguilhen","id":355702,"avatar_url":"https://avatars.githubusercontent.com/u/355702?v=2","gravatar_id":"","url":"https://api.github.com/users/sguilhen","html_url":"https://github.com/sguilhen","followers_url":"https://api.github.com/users/sguilhen/followers","following_url":"https://api.github.com/users/sguilhen/following{/other_user}","gists_url":"https://api.github.com/users/sguilhen/gists{/gist_id}","starred_url":"https://api.github.com/users/sguilhen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sguilhen/subscriptions","organizations_url":"https://api.github.com/users/sguilhen/orgs","repos_url":"https://api.github.com/users/sguilhen/repos","events_url":"https://api.github.com/users/sguilhen/events{/privacy}","received_events_url":"https://api.github.com/users/sguilhen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sguilhen/wildfly-elytron","description":"The WildFly Remoting-based authentication protocol implementation.","fork":true,"url":"https://api.github.com/repos/sguilhen/wildfly-elytron","forks_url":"https://api.github.com/repos/sguilhen/wildfly-elytron/forks","keys_url":"https://api.github.com/repos/sguilhen/wildfly-elytron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sguilhen/wildfly-elytron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sguilhen/wildfly-elytron/teams","hooks_url":"https://api.github.com/repos/sguilhen/wildfly-elytron/hooks","issue_events_url":"https://api.github.com/repos/sguilhen/wildfly-elytron/issues/events{/number}","events_url":"https://api.github.com/repos/sguilhen/wildfly-elytron/events","assignees_url":"https://api.github.com/repos/sguilhen/wildfly-elytron/assignees{/user}","branches_url":"https://api.github.com/repos/sguilhen/wildfly-elytron/branches{/branch}","tags_url":"https://api.github.com/repos/sguilhen/wildfly-elytron/tags","blobs_url":"https://api.github.com/repos/sguilhen/wildfly-elytron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sguilhen/wildfly-elytron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sguilhen/wildfly-elytron/git/refs{/sha}","trees_url":"https://api.github.com/repos/sguilhen/wildfly-elytron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sguilhen/wildfly-elytron/statuses/{sha}","languages_url":"https://api.github.com/repos/sguilhen/wildfly-elytron/languages","stargazers_url":"https://api.github.com/repos/sguilhen/wildfly-elytron/stargazers","contributors_url":"https://api.github.com/repos/sguilhen/wildfly-elytron/contributors","subscribers_url":"https://api.github.com/repos/sguilhen/wildfly-elytron/subscribers","subscription_url":"https://api.github.com/repos/sguilhen/wildfly-elytron/subscription","commits_url":"https://api.github.com/repos/sguilhen/wildfly-elytron/commits{/sha}","git_commits_url":"https://api.github.com/repos/sguilhen/wildfly-elytron/git/commits{/sha}","comments_url":"https://api.github.com/repos/sguilhen/wildfly-elytron/comments{/number}","issue_comment_url":"https://api.github.com/repos/sguilhen/wildfly-elytron/issues/comments/{number}","contents_url":"https://api.github.com/repos/sguilhen/wildfly-elytron/contents/{+path}","compare_url":"https://api.github.com/repos/sguilhen/wildfly-elytron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sguilhen/wildfly-elytron/merges","archive_url":"https://api.github.com/repos/sguilhen/wildfly-elytron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sguilhen/wildfly-elytron/downloads","issues_url":"https://api.github.com/repos/sguilhen/wildfly-elytron/issues{/number}","pulls_url":"https://api.github.com/repos/sguilhen/wildfly-elytron/pulls{/number}","milestones_url":"https://api.github.com/repos/sguilhen/wildfly-elytron/milestones{/number}","notifications_url":"https://api.github.com/repos/sguilhen/wildfly-elytron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sguilhen/wildfly-elytron/labels{/name}","releases_url":"https://api.github.com/repos/sguilhen/wildfly-elytron/releases{/id}","created_at":"2014-05-06T15:28:54Z","updated_at":"2014-07-16T03:20:11Z","pushed_at":"2014-10-28T18:43:19Z","git_url":"git://github.com/sguilhen/wildfly-elytron.git","ssh_url":"git@github.com:sguilhen/wildfly-elytron.git","clone_url":"https://github.com/sguilhen/wildfly-elytron.git","svn_url":"https://github.com/sguilhen/wildfly-elytron","homepage":null,"size":1065,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wildfly-security:master","ref":"master","sha":"6e7ba328860063fdcbdf0c01680cb65600a08074","user":{"login":"wildfly-security","id":7501379,"avatar_url":"https://avatars.githubusercontent.com/u/7501379?v=2","gravatar_id":"","url":"https://api.github.com/users/wildfly-security","html_url":"https://github.com/wildfly-security","followers_url":"https://api.github.com/users/wildfly-security/followers","following_url":"https://api.github.com/users/wildfly-security/following{/other_user}","gists_url":"https://api.github.com/users/wildfly-security/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly-security/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly-security/subscriptions","organizations_url":"https://api.github.com/users/wildfly-security/orgs","repos_url":"https://api.github.com/users/wildfly-security/repos","events_url":"https://api.github.com/users/wildfly-security/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly-security/received_events","type":"Organization","site_admin":false},"repo":{"id":13660977,"name":"wildfly-elytron","full_name":"wildfly-security/wildfly-elytron","owner":{"login":"wildfly-security","id":7501379,"avatar_url":"https://avatars.githubusercontent.com/u/7501379?v=2","gravatar_id":"","url":"https://api.github.com/users/wildfly-security","html_url":"https://github.com/wildfly-security","followers_url":"https://api.github.com/users/wildfly-security/followers","following_url":"https://api.github.com/users/wildfly-security/following{/other_user}","gists_url":"https://api.github.com/users/wildfly-security/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly-security/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly-security/subscriptions","organizations_url":"https://api.github.com/users/wildfly-security/orgs","repos_url":"https://api.github.com/users/wildfly-security/repos","events_url":"https://api.github.com/users/wildfly-security/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly-security/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wildfly-security/wildfly-elytron","description":"WildFly Elytron: Security, Authentication, and Authorization SPIs for the WildFly project","fork":false,"url":"https://api.github.com/repos/wildfly-security/wildfly-elytron","forks_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/forks","keys_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/teams","hooks_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/hooks","issue_events_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/issues/events{/number}","events_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/events","assignees_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/assignees{/user}","branches_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/branches{/branch}","tags_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/tags","blobs_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/git/refs{/sha}","trees_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/statuses/{sha}","languages_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/languages","stargazers_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/stargazers","contributors_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/contributors","subscribers_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/subscribers","subscription_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/subscription","commits_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/commits{/sha}","git_commits_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/git/commits{/sha}","comments_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/comments{/number}","issue_comment_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/issues/comments/{number}","contents_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/contents/{+path}","compare_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/merges","archive_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/downloads","issues_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/issues{/number}","pulls_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/pulls{/number}","milestones_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/milestones{/number}","notifications_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/labels{/name}","releases_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/releases{/id}","created_at":"2013-10-17T20:57:07Z","updated_at":"2014-10-23T15:08:17Z","pushed_at":"2014-10-28T15:02:32Z","git_url":"git://github.com/wildfly-security/wildfly-elytron.git","ssh_url":"git@github.com:wildfly-security/wildfly-elytron.git","clone_url":"https://github.com/wildfly-security/wildfly-elytron.git","svn_url":"https://github.com/wildfly-security/wildfly-elytron","homepage":"http://wildfly.org/","size":4975,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":13,"mirror_url":null,"open_issues_count":5,"forks":13,"open_issues":5,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wildfly-security/wildfly-elytron/pulls/72"},"html":{"href":"https://github.com/wildfly-security/wildfly-elytron/pull/72"},"issue":{"href":"https://api.github.com/repos/wildfly-security/wildfly-elytron/issues/72"},"comments":{"href":"https://api.github.com/repos/wildfly-security/wildfly-elytron/issues/72/comments"},"review_comments":{"href":"https://api.github.com/repos/wildfly-security/wildfly-elytron/pulls/72/comments"},"review_comment":{"href":"https://api.github.com/repos/wildfly-security/wildfly-elytron/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/wildfly-security/wildfly-elytron/pulls/72/commits"},"statuses":{"href":"https://api.github.com/repos/wildfly-security/wildfly-elytron/statuses/58315ed2024d12a86f01e1d0a369e1d5af06bb1e"}}}}