GitHub PullRequestReviewCommentEvent at 2014-11-20 09:36:12
Repository: timonin
Actor: renius
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/renius/timonin/pulls/comments/20635130","id":20635130,"diff_hunk":"@@ -0,0 +1,50 @@\n+class PostsController < ApplicationController\n+  \n+  def index\n+    @posts = Post.all\n+  end\n+  \n+  def new\n+    @post = Post.new\n+  end\n+\n+  def create\n+    @post = Post.new(post_params)\n+      if @post.save","path":"app/controllers/posts_controller.rb","position":13,"original_position":13,"commit_id":"7e741d7f00c4fc9c4829aad7a543904f131846ec","original_commit_id":"7e741d7f00c4fc9c4829aad7a543904f131846ec","user":{"login":"renius","id":348887,"avatar_url":"https://avatars.githubusercontent.com/u/348887?v=3","gravatar_id":"","url":"https://api.github.com/users/renius","html_url":"https://github.com/renius","followers_url":"https://api.github.com/users/renius/followers","following_url":"https://api.github.com/users/renius/following{/other_user}","gists_url":"https://api.github.com/users/renius/gists{/gist_id}","starred_url":"https://api.github.com/users/renius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renius/subscriptions","organizations_url":"https://api.github.com/users/renius/orgs","repos_url":"https://api.github.com/users/renius/repos","events_url":"https://api.github.com/users/renius/events{/privacy}","received_events_url":"https://api.github.com/users/renius/received_events","type":"User","site_admin":false},"body":"лишний отсутп","created_at":"2014-11-20T09:36:12Z","updated_at":"2014-11-20T09:36:12Z","html_url":"https://github.com/renius/timonin/pull/12#discussion_r20635130","pull_request_url":"https://api.github.com/repos/renius/timonin/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/renius/timonin/pulls/comments/20635130"},"html":{"href":"https://github.com/renius/timonin/pull/12#discussion_r20635130"},"pull_request":{"href":"https://api.github.com/repos/renius/timonin/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/renius/timonin/pulls/12","id":24645762,"html_url":"https://github.com/renius/timonin/pull/12","diff_url":"https://github.com/renius/timonin/pull/12.diff","patch_url":"https://github.com/renius/timonin/pull/12.patch","issue_url":"https://api.github.com/repos/renius/timonin/issues/12","number":12,"state":"open","locked":false,"title":"Admin posts","user":{"login":"we138","id":8439842,"avatar_url":"https://avatars.githubusercontent.com/u/8439842?v=3","gravatar_id":"","url":"https://api.github.com/users/we138","html_url":"https://github.com/we138","followers_url":"https://api.github.com/users/we138/followers","following_url":"https://api.github.com/users/we138/following{/other_user}","gists_url":"https://api.github.com/users/we138/gists{/gist_id}","starred_url":"https://api.github.com/users/we138/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/we138/subscriptions","organizations_url":"https://api.github.com/users/we138/orgs","repos_url":"https://api.github.com/users/we138/repos","events_url":"https://api.github.com/users/we138/events{/privacy}","received_events_url":"https://api.github.com/users/we138/received_events","type":"User","site_admin":false},"body":"модель post - пустая без валидаций (нужно решить какие валидации и как их будем обрабатывать ошибки валидации)\r\nконтроллер posts - только crud экшены\r\nмиграция create_posts - 3 столбца id, title, body\r\n\r\nerb во всех вьюхах исправлен на haml, кроме паршиала хедер (не успел разобраться почему не рендерится в эппликйшн)\r\nкод в контроллере поправил\r\n","created_at":"2014-11-18T21:30:16Z","updated_at":"2014-11-20T09:36:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a9c49bc1d4ab3887f5e9d2ba92a58e0b9e6c4539","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/renius/timonin/pulls/12/commits","review_comments_url":"https://api.github.com/repos/renius/timonin/pulls/12/comments","review_comment_url":"https://api.github.com/repos/renius/timonin/pulls/comments/{number}","comments_url":"https://api.github.com/repos/renius/timonin/issues/12/comments","statuses_url":"https://api.github.com/repos/renius/timonin/statuses/7e741d7f00c4fc9c4829aad7a543904f131846ec","head":{"label":"renius:admin-posts","ref":"admin-posts","sha":"7e741d7f00c4fc9c4829aad7a543904f131846ec","user":{"login":"renius","id":348887,"avatar_url":"https://avatars.githubusercontent.com/u/348887?v=3","gravatar_id":"","url":"https://api.github.com/users/renius","html_url":"https://github.com/renius","followers_url":"https://api.github.com/users/renius/followers","following_url":"https://api.github.com/users/renius/following{/other_user}","gists_url":"https://api.github.com/users/renius/gists{/gist_id}","starred_url":"https://api.github.com/users/renius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renius/subscriptions","organizations_url":"https://api.github.com/users/renius/orgs","repos_url":"https://api.github.com/users/renius/repos","events_url":"https://api.github.com/users/renius/events{/privacy}","received_events_url":"https://api.github.com/users/renius/received_events","type":"User","site_admin":false},"repo":{"id":26391182,"name":"timonin","full_name":"renius/timonin","owner":{"login":"renius","id":348887,"avatar_url":"https://avatars.githubusercontent.com/u/348887?v=3","gravatar_id":"","url":"https://api.github.com/users/renius","html_url":"https://github.com/renius","followers_url":"https://api.github.com/users/renius/followers","following_url":"https://api.github.com/users/renius/following{/other_user}","gists_url":"https://api.github.com/users/renius/gists{/gist_id}","starred_url":"https://api.github.com/users/renius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renius/subscriptions","organizations_url":"https://api.github.com/users/renius/orgs","repos_url":"https://api.github.com/users/renius/repos","events_url":"https://api.github.com/users/renius/events{/privacy}","received_events_url":"https://api.github.com/users/renius/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/renius/timonin","description":"timonin","fork":false,"url":"https://api.github.com/repos/renius/timonin","forks_url":"https://api.github.com/repos/renius/timonin/forks","keys_url":"https://api.github.com/repos/renius/timonin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/renius/timonin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/renius/timonin/teams","hooks_url":"https://api.github.com/repos/renius/timonin/hooks","issue_events_url":"https://api.github.com/repos/renius/timonin/issues/events{/number}","events_url":"https://api.github.com/repos/renius/timonin/events","assignees_url":"https://api.github.com/repos/renius/timonin/assignees{/user}","branches_url":"https://api.github.com/repos/renius/timonin/branches{/branch}","tags_url":"https://api.github.com/repos/renius/timonin/tags","blobs_url":"https://api.github.com/repos/renius/timonin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/renius/timonin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/renius/timonin/git/refs{/sha}","trees_url":"https://api.github.com/repos/renius/timonin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/renius/timonin/statuses/{sha}","languages_url":"https://api.github.com/repos/renius/timonin/languages","stargazers_url":"https://api.github.com/repos/renius/timonin/stargazers","contributors_url":"https://api.github.com/repos/renius/timonin/contributors","subscribers_url":"https://api.github.com/repos/renius/timonin/subscribers","subscription_url":"https://api.github.com/repos/renius/timonin/subscription","commits_url":"https://api.github.com/repos/renius/timonin/commits{/sha}","git_commits_url":"https://api.github.com/repos/renius/timonin/git/commits{/sha}","comments_url":"https://api.github.com/repos/renius/timonin/comments{/number}","issue_comment_url":"https://api.github.com/repos/renius/timonin/issues/comments/{number}","contents_url":"https://api.github.com/repos/renius/timonin/contents/{+path}","compare_url":"https://api.github.com/repos/renius/timonin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/renius/timonin/merges","archive_url":"https://api.github.com/repos/renius/timonin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/renius/timonin/downloads","issues_url":"https://api.github.com/repos/renius/timonin/issues{/number}","pulls_url":"https://api.github.com/repos/renius/timonin/pulls{/number}","milestones_url":"https://api.github.com/repos/renius/timonin/milestones{/number}","notifications_url":"https://api.github.com/repos/renius/timonin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/renius/timonin/labels{/name}","releases_url":"https://api.github.com/repos/renius/timonin/releases{/id}","created_at":"2014-11-09T09:28:35Z","updated_at":"2014-11-09T09:29:19Z","pushed_at":"2014-11-20T09:35:09Z","git_url":"git://github.com/renius/timonin.git","ssh_url":"git@github.com:renius/timonin.git","clone_url":"https://github.com/renius/timonin.git","svn_url":"https://github.com/renius/timonin","homepage":null,"size":503,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":8,"forks":0,"open_issues":8,"watchers":0,"default_branch":"develop"}},"base":{"label":"renius:develop","ref":"develop","sha":"d80f2b37235916ec1abf8dba515d2d18edc8a7ce","user":{"login":"renius","id":348887,"avatar_url":"https://avatars.githubusercontent.com/u/348887?v=3","gravatar_id":"","url":"https://api.github.com/users/renius","html_url":"https://github.com/renius","followers_url":"https://api.github.com/users/renius/followers","following_url":"https://api.github.com/users/renius/following{/other_user}","gists_url":"https://api.github.com/users/renius/gists{/gist_id}","starred_url":"https://api.github.com/users/renius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renius/subscriptions","organizations_url":"https://api.github.com/users/renius/orgs","repos_url":"https://api.github.com/users/renius/repos","events_url":"https://api.github.com/users/renius/events{/privacy}","received_events_url":"https://api.github.com/users/renius/received_events","type":"User","site_admin":false},"repo":{"id":26391182,"name":"timonin","full_name":"renius/timonin","owner":{"login":"renius","id":348887,"avatar_url":"https://avatars.githubusercontent.com/u/348887?v=3","gravatar_id":"","url":"https://api.github.com/users/renius","html_url":"https://github.com/renius","followers_url":"https://api.github.com/users/renius/followers","following_url":"https://api.github.com/users/renius/following{/other_user}","gists_url":"https://api.github.com/users/renius/gists{/gist_id}","starred_url":"https://api.github.com/users/renius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renius/subscriptions","organizations_url":"https://api.github.com/users/renius/orgs","repos_url":"https://api.github.com/users/renius/repos","events_url":"https://api.github.com/users/renius/events{/privacy}","received_events_url":"https://api.github.com/users/renius/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/renius/timonin","description":"timonin","fork":false,"url":"https://api.github.com/repos/renius/timonin","forks_url":"https://api.github.com/repos/renius/timonin/forks","keys_url":"https://api.github.com/repos/renius/timonin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/renius/timonin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/renius/timonin/teams","hooks_url":"https://api.github.com/repos/renius/timonin/hooks","issue_events_url":"https://api.github.com/repos/renius/timonin/issues/events{/number}","events_url":"https://api.github.com/repos/renius/timonin/events","assignees_url":"https://api.github.com/repos/renius/timonin/assignees{/user}","branches_url":"https://api.github.com/repos/renius/timonin/branches{/branch}","tags_url":"https://api.github.com/repos/renius/timonin/tags","blobs_url":"https://api.github.com/repos/renius/timonin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/renius/timonin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/renius/timonin/git/refs{/sha}","trees_url":"https://api.github.com/repos/renius/timonin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/renius/timonin/statuses/{sha}","languages_url":"https://api.github.com/repos/renius/timonin/languages","stargazers_url":"https://api.github.com/repos/renius/timonin/stargazers","contributors_url":"https://api.github.com/repos/renius/timonin/contributors","subscribers_url":"https://api.github.com/repos/renius/timonin/subscribers","subscription_url":"https://api.github.com/repos/renius/timonin/subscription","commits_url":"https://api.github.com/repos/renius/timonin/commits{/sha}","git_commits_url":"https://api.github.com/repos/renius/timonin/git/commits{/sha}","comments_url":"https://api.github.com/repos/renius/timonin/comments{/number}","issue_comment_url":"https://api.github.com/repos/renius/timonin/issues/comments/{number}","contents_url":"https://api.github.com/repos/renius/timonin/contents/{+path}","compare_url":"https://api.github.com/repos/renius/timonin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/renius/timonin/merges","archive_url":"https://api.github.com/repos/renius/timonin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/renius/timonin/downloads","issues_url":"https://api.github.com/repos/renius/timonin/issues{/number}","pulls_url":"https://api.github.com/repos/renius/timonin/pulls{/number}","milestones_url":"https://api.github.com/repos/renius/timonin/milestones{/number}","notifications_url":"https://api.github.com/repos/renius/timonin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/renius/timonin/labels{/name}","releases_url":"https://api.github.com/repos/renius/timonin/releases{/id}","created_at":"2014-11-09T09:28:35Z","updated_at":"2014-11-09T09:29:19Z","pushed_at":"2014-11-20T09:35:09Z","git_url":"git://github.com/renius/timonin.git","ssh_url":"git@github.com:renius/timonin.git","clone_url":"https://github.com/renius/timonin.git","svn_url":"https://github.com/renius/timonin","homepage":null,"size":503,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":8,"forks":0,"open_issues":8,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/renius/timonin/pulls/12"},"html":{"href":"https://github.com/renius/timonin/pull/12"},"issue":{"href":"https://api.github.com/repos/renius/timonin/issues/12"},"comments":{"href":"https://api.github.com/repos/renius/timonin/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/renius/timonin/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/renius/timonin/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/renius/timonin/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/renius/timonin/statuses/7e741d7f00c4fc9c4829aad7a543904f131846ec"}}}}