GitHub PullRequestEvent at 2014-05-07 10:17:33
Repository: kivy
Actor: tito
Payload: {"action":"closed","number":2158,"pull_request":{"url":"https://api.github.com/repos/kivy/kivy/pulls/2158","id":15526365,"html_url":"https://github.com/kivy/kivy/pull/2158","diff_url":"https://github.com/kivy/kivy/pull/2158.diff","patch_url":"https://github.com/kivy/kivy/pull/2158.patch","issue_url":"https://api.github.com/repos/kivy/kivy/issues/2158","number":2158,"state":"closed","title":"Multi-line CompositeListItem","user":{"login":"cropleyb","id":6285895,"avatar_url":"https://avatars.githubusercontent.com/u/6285895?","gravatar_id":"0044f11143d890c1bb63fffc25db9c27","url":"https://api.github.com/users/cropleyb","html_url":"https://github.com/cropleyb","followers_url":"https://api.github.com/users/cropleyb/followers","following_url":"https://api.github.com/users/cropleyb/following{/other_user}","gists_url":"https://api.github.com/users/cropleyb/gists{/gist_id}","starred_url":"https://api.github.com/users/cropleyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cropleyb/subscriptions","organizations_url":"https://api.github.com/users/cropleyb/orgs","repos_url":"https://api.github.com/users/cropleyb/repos","events_url":"https://api.github.com/users/cropleyb/events{/privacy}","received_events_url":"https://api.github.com/users/cropleyb/received_events","type":"User","site_admin":false},"body":"At the moment, CompositeListItem derives from BoxLayout, which only allows a 1D line of children. I have a fairly large number of fields that I want to display per item, and to do that I have derived from GridLayout instead of BoxLayout and defaulted to rows=1. This will break user code that is currently depending on it deriving from BoxLayout. I'm not sure how severe that would be. Alternative suggestions welcome :)","created_at":"2014-05-06T05:40:23Z","updated_at":"2014-05-07T10:17:32Z","closed_at":"2014-05-07T10:17:32Z","merged_at":null,"merge_commit_sha":"348d21c0c1e76910f209b900cbed7df824ae81b4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kivy/kivy/pulls/2158/commits","review_comments_url":"https://api.github.com/repos/kivy/kivy/pulls/2158/comments","review_comment_url":"https://api.github.com/repos/kivy/kivy/pulls/comments/{number}","comments_url":"https://api.github.com/repos/kivy/kivy/issues/2158/comments","statuses_url":"https://api.github.com/repos/kivy/kivy/statuses/4dfc45a31437a8c37001309040a0140abe0a54bb","head":{"label":"cropleyb:compositelistitem_gridlayout","ref":"compositelistitem_gridlayout","sha":"4dfc45a31437a8c37001309040a0140abe0a54bb","user":{"login":"cropleyb","id":6285895,"avatar_url":"https://avatars.githubusercontent.com/u/6285895?","gravatar_id":"0044f11143d890c1bb63fffc25db9c27","url":"https://api.github.com/users/cropleyb","html_url":"https://github.com/cropleyb","followers_url":"https://api.github.com/users/cropleyb/followers","following_url":"https://api.github.com/users/cropleyb/following{/other_user}","gists_url":"https://api.github.com/users/cropleyb/gists{/gist_id}","starred_url":"https://api.github.com/users/cropleyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cropleyb/subscriptions","organizations_url":"https://api.github.com/users/cropleyb/orgs","repos_url":"https://api.github.com/users/cropleyb/repos","events_url":"https://api.github.com/users/cropleyb/events{/privacy}","received_events_url":"https://api.github.com/users/cropleyb/received_events","type":"User","site_admin":false},"repo":{"id":19481005,"name":"kivy","full_name":"cropleyb/kivy","owner":{"login":"cropleyb","id":6285895,"avatar_url":"https://avatars.githubusercontent.com/u/6285895?","gravatar_id":"0044f11143d890c1bb63fffc25db9c27","url":"https://api.github.com/users/cropleyb","html_url":"https://github.com/cropleyb","followers_url":"https://api.github.com/users/cropleyb/followers","following_url":"https://api.github.com/users/cropleyb/following{/other_user}","gists_url":"https://api.github.com/users/cropleyb/gists{/gist_id}","starred_url":"https://api.github.com/users/cropleyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cropleyb/subscriptions","organizations_url":"https://api.github.com/users/cropleyb/orgs","repos_url":"https://api.github.com/users/cropleyb/repos","events_url":"https://api.github.com/users/cropleyb/events{/privacy}","received_events_url":"https://api.github.com/users/cropleyb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cropleyb/kivy","description":"Open source software library for creating NUI applications, running on Windows, Linux, MacOSX, Android and iOS","fork":true,"url":"https://api.github.com/repos/cropleyb/kivy","forks_url":"https://api.github.com/repos/cropleyb/kivy/forks","keys_url":"https://api.github.com/repos/cropleyb/kivy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cropleyb/kivy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cropleyb/kivy/teams","hooks_url":"https://api.github.com/repos/cropleyb/kivy/hooks","issue_events_url":"https://api.github.com/repos/cropleyb/kivy/issues/events{/number}","events_url":"https://api.github.com/repos/cropleyb/kivy/events","assignees_url":"https://api.github.com/repos/cropleyb/kivy/assignees{/user}","branches_url":"https://api.github.com/repos/cropleyb/kivy/branches{/branch}","tags_url":"https://api.github.com/repos/cropleyb/kivy/tags","blobs_url":"https://api.github.com/repos/cropleyb/kivy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cropleyb/kivy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cropleyb/kivy/git/refs{/sha}","trees_url":"https://api.github.com/repos/cropleyb/kivy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cropleyb/kivy/statuses/{sha}","languages_url":"https://api.github.com/repos/cropleyb/kivy/languages","stargazers_url":"https://api.github.com/repos/cropleyb/kivy/stargazers","contributors_url":"https://api.github.com/repos/cropleyb/kivy/contributors","subscribers_url":"https://api.github.com/repos/cropleyb/kivy/subscribers","subscription_url":"https://api.github.com/repos/cropleyb/kivy/subscription","commits_url":"https://api.github.com/repos/cropleyb/kivy/commits{/sha}","git_commits_url":"https://api.github.com/repos/cropleyb/kivy/git/commits{/sha}","comments_url":"https://api.github.com/repos/cropleyb/kivy/comments{/number}","issue_comment_url":"https://api.github.com/repos/cropleyb/kivy/issues/comments/{number}","contents_url":"https://api.github.com/repos/cropleyb/kivy/contents/{+path}","compare_url":"https://api.github.com/repos/cropleyb/kivy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cropleyb/kivy/merges","archive_url":"https://api.github.com/repos/cropleyb/kivy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cropleyb/kivy/downloads","issues_url":"https://api.github.com/repos/cropleyb/kivy/issues{/number}","pulls_url":"https://api.github.com/repos/cropleyb/kivy/pulls{/number}","milestones_url":"https://api.github.com/repos/cropleyb/kivy/milestones{/number}","notifications_url":"https://api.github.com/repos/cropleyb/kivy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cropleyb/kivy/labels{/name}","releases_url":"https://api.github.com/repos/cropleyb/kivy/releases{/id}","created_at":"2014-05-06T04:27:11Z","updated_at":"2014-05-06T05:40:23Z","pushed_at":"2014-05-06T05:27:56Z","git_url":"git://github.com/cropleyb/kivy.git","ssh_url":"git@github.com:cropleyb/kivy.git","clone_url":"https://github.com/cropleyb/kivy.git","svn_url":"https://github.com/cropleyb/kivy","homepage":"http://kivy.org/","size":35328,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kivy:master","ref":"master","sha":"75e75a86cf91c3af4138861afff19d31885d0512","user":{"login":"kivy","id":1266152,"avatar_url":"https://avatars.githubusercontent.com/u/1266152?","gravatar_id":"4c77a368d7f9077c9a9c206dbe52398d","url":"https://api.github.com/users/kivy","html_url":"https://github.com/kivy","followers_url":"https://api.github.com/users/kivy/followers","following_url":"https://api.github.com/users/kivy/following{/other_user}","gists_url":"https://api.github.com/users/kivy/gists{/gist_id}","starred_url":"https://api.github.com/users/kivy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kivy/subscriptions","organizations_url":"https://api.github.com/users/kivy/orgs","repos_url":"https://api.github.com/users/kivy/repos","events_url":"https://api.github.com/users/kivy/events{/privacy}","received_events_url":"https://api.github.com/users/kivy/received_events","type":"Organization","site_admin":false},"repo":{"id":1049095,"name":"kivy","full_name":"kivy/kivy","owner":{"login":"kivy","id":1266152,"avatar_url":"https://avatars.githubusercontent.com/u/1266152?","gravatar_id":"4c77a368d7f9077c9a9c206dbe52398d","url":"https://api.github.com/users/kivy","html_url":"https://github.com/kivy","followers_url":"https://api.github.com/users/kivy/followers","following_url":"https://api.github.com/users/kivy/following{/other_user}","gists_url":"https://api.github.com/users/kivy/gists{/gist_id}","starred_url":"https://api.github.com/users/kivy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kivy/subscriptions","organizations_url":"https://api.github.com/users/kivy/orgs","repos_url":"https://api.github.com/users/kivy/repos","events_url":"https://api.github.com/users/kivy/events{/privacy}","received_events_url":"https://api.github.com/users/kivy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kivy/kivy","description":"Open source software library for creating NUI applications, running on Windows, Linux, MacOSX, Android and iOS","fork":false,"url":"https://api.github.com/repos/kivy/kivy","forks_url":"https://api.github.com/repos/kivy/kivy/forks","keys_url":"https://api.github.com/repos/kivy/kivy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kivy/kivy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kivy/kivy/teams","hooks_url":"https://api.github.com/repos/kivy/kivy/hooks","issue_events_url":"https://api.github.com/repos/kivy/kivy/issues/events{/number}","events_url":"https://api.github.com/repos/kivy/kivy/events","assignees_url":"https://api.github.com/repos/kivy/kivy/assignees{/user}","branches_url":"https://api.github.com/repos/kivy/kivy/branches{/branch}","tags_url":"https://api.github.com/repos/kivy/kivy/tags","blobs_url":"https://api.github.com/repos/kivy/kivy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kivy/kivy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kivy/kivy/git/refs{/sha}","trees_url":"https://api.github.com/repos/kivy/kivy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kivy/kivy/statuses/{sha}","languages_url":"https://api.github.com/repos/kivy/kivy/languages","stargazers_url":"https://api.github.com/repos/kivy/kivy/stargazers","contributors_url":"https://api.github.com/repos/kivy/kivy/contributors","subscribers_url":"https://api.github.com/repos/kivy/kivy/subscribers","subscription_url":"https://api.github.com/repos/kivy/kivy/subscription","commits_url":"https://api.github.com/repos/kivy/kivy/commits{/sha}","git_commits_url":"https://api.github.com/repos/kivy/kivy/git/commits{/sha}","comments_url":"https://api.github.com/repos/kivy/kivy/comments{/number}","issue_comment_url":"https://api.github.com/repos/kivy/kivy/issues/comments/{number}","contents_url":"https://api.github.com/repos/kivy/kivy/contents/{+path}","compare_url":"https://api.github.com/repos/kivy/kivy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kivy/kivy/merges","archive_url":"https://api.github.com/repos/kivy/kivy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kivy/kivy/downloads","issues_url":"https://api.github.com/repos/kivy/kivy/issues{/number}","pulls_url":"https://api.github.com/repos/kivy/kivy/pulls{/number}","milestones_url":"https://api.github.com/repos/kivy/kivy/milestones{/number}","notifications_url":"https://api.github.com/repos/kivy/kivy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kivy/kivy/labels{/name}","releases_url":"https://api.github.com/repos/kivy/kivy/releases{/id}","created_at":"2010-11-03T20:27:32Z","updated_at":"2014-05-07T10:12:31Z","pushed_at":"2014-05-07T10:12:31Z","git_url":"git://github.com/kivy/kivy.git","ssh_url":"git@github.com:kivy/kivy.git","clone_url":"https://github.com/kivy/kivy.git","svn_url":"https://github.com/kivy/kivy","homepage":"http://kivy.org/","size":57772,"stargazers_count":1799,"watchers_count":1799,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":455,"mirror_url":null,"open_issues_count":242,"forks":455,"open_issues":242,"watchers":1799,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kivy/kivy/pulls/2158"},"html":{"href":"https://github.com/kivy/kivy/pull/2158"},"issue":{"href":"https://api.github.com/repos/kivy/kivy/issues/2158"},"comments":{"href":"https://api.github.com/repos/kivy/kivy/issues/2158/comments"},"review_comments":{"href":"https://api.github.com/repos/kivy/kivy/pulls/2158/comments"},"review_comment":{"href":"https://api.github.com/repos/kivy/kivy/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/kivy/kivy/pulls/2158/commits"},"statuses":{"href":"https://api.github.com/repos/kivy/kivy/statuses/4dfc45a31437a8c37001309040a0140abe0a54bb"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":2,"additions":4,"deletions":4,"changed_files":2}}