GitHub PullRequestReviewCommentEvent at 2014-03-02 07:18:43
Repository: editorconfig-emacs
Actor: johan
Payload: {"comment":{"url":"https://api.github.com/repos/editorconfig/editorconfig-emacs/pulls/comments/10194412","id":10194412,"diff_hunk":"@@ -46,39 +46,92 @@\n \n (defvar edconf-exec-path \"editorconfig\")\n \n+(defcustom edconf-indentation-alist\n+  '((emacs-lisp-mode lisp-indent-offset)\n+    (lisp-mode lisp-indent-offset)\n+    (c-mode c-basic-offset)\n+    (c++-mode c-basic-offset)\n+    (objc-mode c-basic-offset)\n+    (java-mode c-basic-offset)\n+    (idl-mode c-basic-offset)\n+    (pike-mode c-basic-offset)\n+    (awk-mode c-basic-offset)\n+    (cperl-mode cperl-indent-level)\n+    (js-mode js-indent-level)\n+    (json-mode js-indent-level)\n+    (js2-mode js2-basic-offset)\n+    (perl-mode perl-indent-level)\n+    (python-mode python-indent-offset)\n+    (ruby-mode ruby-indent-level)\n+    (sh-mode sh-basic-offset)\n+    (nxml-mode nxml-child-indent (nxml-attribute-indent . 2))\n+    (coffee-mode coffee-tab-width)\n+    (livescript-mode livescript-tab-width)\n+    (mustache-mode mustache-basic-offset)\n+    (css-mode css-indent-offset)\n+    (scala-mode scala-indent:step)\n+    (groovy-mode c-basic-offset))\n+  \"Alist of indentation setting methods by modes.\n+\n+Each element looks like (MODE . FUNCTION) or (MODE . INDENT-SPEC-LIST).\n+\n+If FUNCTION is provided, it will be called when setting the indentation.  The\n+indent size will be passed.\n+\n+If INDENT-SPEC-LIST is provided, each element of it must have one of the\n+following forms:\n+\n+ 1. VARIABLE\n+\n+    It means (VARIABLE . 1).\n+\n+ 2. (VARIABLE . SPEC)\n+\n+    Setting VARIABLE according to the type of SPEC:\n+\n+      - Integer\n+\n+        The value is (* SPEC INDENT-SIZE);\n+\n+      - Function\n+\n+        The value is (funcall SPEC INDENT-SIZE);\n+\n+      - Any other type.\n+\n+        The value is SPEC.\n+\n+NOTE: Only the **buffer local** value of VARIABLE will be set.\"\n+  :type '(alist :key-type symbol :value-type sexp)\n+  :risky t\n+  :group 'editorconfig)\n+\n (defun edconf-set-indentation (style &optional size tab_width)\n-  (setq web-mode-indent-style 2)","path":"editorconfig.el","position":65,"original_position":65,"commit_id":"a1bb2a99078298a5061feb353a994317700057a2","original_commit_id":"a1bb2a99078298a5061feb353a994317700057a2","user":{"login":"johan","id":2459,"avatar_url":"https://avatars.githubusercontent.com/u/2459","gravatar_id":"580e00312773d30472c21660f69eb0da","url":"https://api.github.com/users/johan","html_url":"https://github.com/johan","followers_url":"https://api.github.com/users/johan/followers","following_url":"https://api.github.com/users/johan/following{/other_user}","gists_url":"https://api.github.com/users/johan/gists{/gist_id}","starred_url":"https://api.github.com/users/johan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johan/subscriptions","organizations_url":"https://api.github.com/users/johan/orgs","repos_url":"https://api.github.com/users/johan/repos","events_url":"https://api.github.com/users/johan/events{/privacy}","received_events_url":"https://api.github.com/users/johan/received_events","type":"User","site_admin":false},"body":"While I'm not intimately familiar with this mode or the support we may have offered for it in the past, it looks like whatever there was got nuked here.\r\n\r\n(Asking because I didn't see any explicit mention of its removal or reasoning around same, not from knowing that the old code was good, effective, and worked.)","created_at":"2014-03-02T07:18:43Z","updated_at":"2014-03-02T07:18:43Z","html_url":"https://github.com/editorconfig/editorconfig-emacs/pull/13#discussion_r10194412","pull_request_url":"https://api.github.com/repos/editorconfig/editorconfig-emacs/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/editorconfig/editorconfig-emacs/pulls/comments/10194412"},"html":{"href":"https://github.com/editorconfig/editorconfig-emacs/pull/13#discussion_r10194412"},"pull_request":{"href":"https://api.github.com/repos/editorconfig/editorconfig-emacs/pulls/13"}}}}