GitHub PullRequestReviewCommentEvent at 2014-03-25 19:07:41
Repository: juju-gui
Actor: hatched
Payload: {"comment":{"url":"https://api.github.com/repos/juju/juju-gui/pulls/comments/10947733","id":10947733,"diff_hunk":"@@ -203,7 +203,14 @@ YUI.add('ghost-service-inspector', function(Y) {\n       topo.service_boxes[serviceName] = boxModel;\n \n       // Set to initial UI state.\n-      environmentView.createServiceInspector(ghostService);\n+      if (window.flags.isb) {\n+        this.fire(\n+            'viewNavigate', {\n+              url: '/inspector/' + ghostService.get('displayName') + '/'","path":"app/views/inspectors/ghost-service-inspector.js","position":8,"original_position":8,"commit_id":"7107546772da732a655142cde1fef4ca7cac7735","original_commit_id":"7107546772da732a655142cde1fef4ca7cac7735","user":{"login":"hatched","id":532033,"avatar_url":"https://avatars.githubusercontent.com/u/532033?","gravatar_id":"e95b5dccab0d75eadaccfe04bfd7ad59","url":"https://api.github.com/users/hatched","html_url":"https://github.com/hatched","followers_url":"https://api.github.com/users/hatched/followers","following_url":"https://api.github.com/users/hatched/following{/other_user}","gists_url":"https://api.github.com/users/hatched/gists{/gist_id}","starred_url":"https://api.github.com/users/hatched/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hatched/subscriptions","organizations_url":"https://api.github.com/users/hatched/orgs","repos_url":"https://api.github.com/users/hatched/repos","events_url":"https://api.github.com/users/hatched/events{/privacy}","received_events_url":"https://api.github.com/users/hatched/received_events","type":"User","site_admin":false},"body":"So change the view mode, set the id and then dispatch? Doesn't this set the viewmode etc after it passes through the router? The url needs to be updated to match the new supported url list. ","created_at":"2014-03-25T19:07:41Z","updated_at":"2014-03-25T19:07:41Z","html_url":"https://github.com/juju/juju-gui/pull/197#discussion_r10947733","pull_request_url":"https://api.github.com/repos/juju/juju-gui/pulls/197","_links":{"self":{"href":"https://api.github.com/repos/juju/juju-gui/pulls/comments/10947733"},"html":{"href":"https://github.com/juju/juju-gui/pull/197#discussion_r10947733"},"pull_request":{"href":"https://api.github.com/repos/juju/juju-gui/pulls/197"}}}}