GitHub PullRequestEvent at 2014-12-09 21:52:02
Repository: rust
Actor: bors
Payload: {"action":"closed","number":19594,"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/19594","id":25617657,"html_url":"https://github.com/rust-lang/rust/pull/19594","diff_url":"https://github.com/rust-lang/rust/pull/19594.diff","patch_url":"https://github.com/rust-lang/rust/pull/19594.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/19594","number":19594,"state":"closed","locked":false,"title":"serialize: base64: allow LF in addition to CRLF and optimize slightly","user":{"login":"Arcterus","id":829813,"avatar_url":"https://avatars.githubusercontent.com/u/829813?v=3","gravatar_id":"","url":"https://api.github.com/users/Arcterus","html_url":"https://github.com/Arcterus","followers_url":"https://api.github.com/users/Arcterus/followers","following_url":"https://api.github.com/users/Arcterus/following{/other_user}","gists_url":"https://api.github.com/users/Arcterus/gists{/gist_id}","starred_url":"https://api.github.com/users/Arcterus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Arcterus/subscriptions","organizations_url":"https://api.github.com/users/Arcterus/orgs","repos_url":"https://api.github.com/users/Arcterus/repos","events_url":"https://api.github.com/users/Arcterus/events{/privacy}","received_events_url":"https://api.github.com/users/Arcterus/received_events","type":"User","site_admin":false},"body":"It is useful to have configurable newlines in base64 as the standard\r\nleaves that for the implementation to decide.  GNU `base64` apparently\r\nuses LF, which meant in `uutils` we had to manually convert the CRLF to\r\nLF.  This made the program very slow for large inputs.\r\n\r\n[breaking-change]","created_at":"2014-12-06T10:53:36Z","updated_at":"2014-12-09T21:52:01Z","closed_at":"2014-12-09T21:52:01Z","merged_at":"2014-12-09T21:52:01Z","merge_commit_sha":"e3b6f9efc4203960711c459769d931470db1582e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/19594/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/19594/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/19594/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/a119ad83c73c7e1c99c7e21fb2ab21bd9521077a","head":{"label":"Arcterus:master","ref":"master","sha":"a119ad83c73c7e1c99c7e21fb2ab21bd9521077a","user":{"login":"Arcterus","id":829813,"avatar_url":"https://avatars.githubusercontent.com/u/829813?v=3","gravatar_id":"","url":"https://api.github.com/users/Arcterus","html_url":"https://github.com/Arcterus","followers_url":"https://api.github.com/users/Arcterus/followers","following_url":"https://api.github.com/users/Arcterus/following{/other_user}","gists_url":"https://api.github.com/users/Arcterus/gists{/gist_id}","starred_url":"https://api.github.com/users/Arcterus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Arcterus/subscriptions","organizations_url":"https://api.github.com/users/Arcterus/orgs","repos_url":"https://api.github.com/users/Arcterus/repos","events_url":"https://api.github.com/users/Arcterus/events{/privacy}","received_events_url":"https://api.github.com/users/Arcterus/received_events","type":"User","site_admin":false},"repo":{"id":27626517,"name":"rust","full_name":"Arcterus/rust","owner":{"login":"Arcterus","id":829813,"avatar_url":"https://avatars.githubusercontent.com/u/829813?v=3","gravatar_id":"","url":"https://api.github.com/users/Arcterus","html_url":"https://github.com/Arcterus","followers_url":"https://api.github.com/users/Arcterus/followers","following_url":"https://api.github.com/users/Arcterus/following{/other_user}","gists_url":"https://api.github.com/users/Arcterus/gists{/gist_id}","starred_url":"https://api.github.com/users/Arcterus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Arcterus/subscriptions","organizations_url":"https://api.github.com/users/Arcterus/orgs","repos_url":"https://api.github.com/users/Arcterus/repos","events_url":"https://api.github.com/users/Arcterus/events{/privacy}","received_events_url":"https://api.github.com/users/Arcterus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Arcterus/rust","description":"a safe, concurrent, practical language","fork":true,"url":"https://api.github.com/repos/Arcterus/rust","forks_url":"https://api.github.com/repos/Arcterus/rust/forks","keys_url":"https://api.github.com/repos/Arcterus/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Arcterus/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Arcterus/rust/teams","hooks_url":"https://api.github.com/repos/Arcterus/rust/hooks","issue_events_url":"https://api.github.com/repos/Arcterus/rust/issues/events{/number}","events_url":"https://api.github.com/repos/Arcterus/rust/events","assignees_url":"https://api.github.com/repos/Arcterus/rust/assignees{/user}","branches_url":"https://api.github.com/repos/Arcterus/rust/branches{/branch}","tags_url":"https://api.github.com/repos/Arcterus/rust/tags","blobs_url":"https://api.github.com/repos/Arcterus/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Arcterus/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Arcterus/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/Arcterus/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Arcterus/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/Arcterus/rust/languages","stargazers_url":"https://api.github.com/repos/Arcterus/rust/stargazers","contributors_url":"https://api.github.com/repos/Arcterus/rust/contributors","subscribers_url":"https://api.github.com/repos/Arcterus/rust/subscribers","subscription_url":"https://api.github.com/repos/Arcterus/rust/subscription","commits_url":"https://api.github.com/repos/Arcterus/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/Arcterus/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/Arcterus/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/Arcterus/rust/issues/comments/{number}","contents_url":"https://api.github.com/repos/Arcterus/rust/contents/{+path}","compare_url":"https://api.github.com/repos/Arcterus/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Arcterus/rust/merges","archive_url":"https://api.github.com/repos/Arcterus/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Arcterus/rust/downloads","issues_url":"https://api.github.com/repos/Arcterus/rust/issues{/number}","pulls_url":"https://api.github.com/repos/Arcterus/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/Arcterus/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/Arcterus/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Arcterus/rust/labels{/name}","releases_url":"https://api.github.com/repos/Arcterus/rust/releases{/id}","created_at":"2014-12-06T07:42:18Z","updated_at":"2014-12-09T15:40:43Z","pushed_at":"2014-12-09T15:40:42Z","git_url":"git://github.com/Arcterus/rust.git","ssh_url":"git@github.com:Arcterus/rust.git","clone_url":"https://github.com/Arcterus/rust.git","svn_url":"https://github.com/Arcterus/rust","homepage":"http://www.rust-lang.org","size":190296,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"cafe2966770ff377aad6dd9fd808e68055587c58","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"a safe, concurrent, practical language","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments/{number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","created_at":"2010-06-16T20:39:03Z","updated_at":"2014-12-09T21:51:56Z","pushed_at":"2014-12-09T21:51:56Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"http://www.rust-lang.org","size":440471,"stargazers_count":7719,"watchers_count":7719,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1500,"mirror_url":null,"open_issues_count":2237,"forks":1500,"open_issues":2237,"watchers":7719,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/19594"},"html":{"href":"https://github.com/rust-lang/rust/pull/19594"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/19594"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/19594/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/19594/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/19594/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/a119ad83c73c7e1c99c7e21fb2ab21bd9521077a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"bors","id":3372342,"avatar_url":"https://avatars.githubusercontent.com/u/3372342?v=3","gravatar_id":"","url":"https://api.github.com/users/bors","html_url":"https://github.com/bors","followers_url":"https://api.github.com/users/bors/followers","following_url":"https://api.github.com/users/bors/following{/other_user}","gists_url":"https://api.github.com/users/bors/gists{/gist_id}","starred_url":"https://api.github.com/users/bors/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bors/subscriptions","organizations_url":"https://api.github.com/users/bors/orgs","repos_url":"https://api.github.com/users/bors/repos","events_url":"https://api.github.com/users/bors/events{/privacy}","received_events_url":"https://api.github.com/users/bors/received_events","type":"User","site_admin":false},"comments":5,"review_comments":1,"commits":3,"additions":64,"deletions":32,"changed_files":2}}