GitHub PullRequestReviewCommentEvent at 2014-06-16 03:36:06
Repository: laravel_training
Actor: fr-sato
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/fr-matsuo/laravel_training/pulls/comments/13791226","id":13791226,"diff_hunk":"@@ -28,21 +30,22 @@ public function postForm() {\n     }\n \n     public function postFormcheck() {\n-        return $this->confirm();\n+        return $this->_confirm();\n     }\n \n     public function postFinish() {\n+        $this->_addRecord();","path":"app/controllers/FormController.php","position":26,"original_position":26,"commit_id":"6199ef1b5fef4502ab82cd534fb6c16e6aa57733","original_commit_id":"6199ef1b5fef4502ab82cd534fb6c16e6aa57733","user":{"login":"fr-sato","id":1913106,"avatar_url":"https://avatars.githubusercontent.com/u/1913106?","gravatar_id":"b52dec646134b77fe457fd6632697f29","url":"https://api.github.com/users/fr-sato","html_url":"https://github.com/fr-sato","followers_url":"https://api.github.com/users/fr-sato/followers","following_url":"https://api.github.com/users/fr-sato/following{/other_user}","gists_url":"https://api.github.com/users/fr-sato/gists{/gist_id}","starred_url":"https://api.github.com/users/fr-sato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fr-sato/subscriptions","organizations_url":"https://api.github.com/users/fr-sato/orgs","repos_url":"https://api.github.com/users/fr-sato/repos","events_url":"https://api.github.com/users/fr-sato/events{/privacy}","received_events_url":"https://api.github.com/users/fr-sato/received_events","type":"User","site_admin":false},"body":"登録が失敗した場合の例外処理も書いておくと尚良いかなと思います。失敗したらそれっぽいエラー文言を表示してフォーム画面へ戻すなど。","created_at":"2014-06-16T03:36:06Z","updated_at":"2014-06-16T03:36:06Z","html_url":"https://github.com/fr-matsuo/laravel_training/pull/6#discussion_r13791226","pull_request_url":"https://api.github.com/repos/fr-matsuo/laravel_training/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/fr-matsuo/laravel_training/pulls/comments/13791226"},"html":{"href":"https://github.com/fr-matsuo/laravel_training/pull/6#discussion_r13791226"},"pull_request":{"href":"https://api.github.com/repos/fr-matsuo/laravel_training/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/fr-matsuo/laravel_training/pulls/6","id":17035820,"html_url":"https://github.com/fr-matsuo/laravel_training/pull/6","diff_url":"https://github.com/fr-matsuo/laravel_training/pull/6.diff","patch_url":"https://github.com/fr-matsuo/laravel_training/pull/6.patch","issue_url":"https://api.github.com/repos/fr-matsuo/laravel_training/issues/6","number":6,"state":"open","title":"LaravelでのDB利用 #43","user":{"login":"fr-matsuo","id":7111595,"avatar_url":"https://avatars.githubusercontent.com/u/7111595?","gravatar_id":"2aeac9a4a468285e7885f72e2e040926","url":"https://api.github.com/users/fr-matsuo","html_url":"https://github.com/fr-matsuo","followers_url":"https://api.github.com/users/fr-matsuo/followers","following_url":"https://api.github.com/users/fr-matsuo/following{/other_user}","gists_url":"https://api.github.com/users/fr-matsuo/gists{/gist_id}","starred_url":"https://api.github.com/users/fr-matsuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fr-matsuo/subscriptions","organizations_url":"https://api.github.com/users/fr-matsuo/orgs","repos_url":"https://api.github.com/users/fr-matsuo/repos","events_url":"https://api.github.com/users/fr-matsuo/events{/privacy}","received_events_url":"https://api.github.com/users/fr-matsuo/received_events","type":"User","site_admin":false},"body":"- [x] DBへの接続を実装\r\n- [x] DBからデータを取得・表示(接続確認用)\r\n- [x] DBへデータを追加","created_at":"2014-06-12T03:17:12Z","updated_at":"2014-06-16T03:36:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bf28dc9d27cb6bb3b6faae360a6f0915f2590ee8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/fr-matsuo/laravel_training/pulls/6/commits","review_comments_url":"https://api.github.com/repos/fr-matsuo/laravel_training/pulls/6/comments","review_comment_url":"https://api.github.com/repos/fr-matsuo/laravel_training/pulls/comments/{number}","comments_url":"https://api.github.com/repos/fr-matsuo/laravel_training/issues/6/comments","statuses_url":"https://api.github.com/repos/fr-matsuo/laravel_training/statuses/6199ef1b5fef4502ab82cd534fb6c16e6aa57733","head":{"label":"fr-matsuo:feature/43_connectDB","ref":"feature/43_connectDB","sha":"6199ef1b5fef4502ab82cd534fb6c16e6aa57733","user":{"login":"fr-matsuo","id":7111595,"avatar_url":"https://avatars.githubusercontent.com/u/7111595?","gravatar_id":"2aeac9a4a468285e7885f72e2e040926","url":"https://api.github.com/users/fr-matsuo","html_url":"https://github.com/fr-matsuo","followers_url":"https://api.github.com/users/fr-matsuo/followers","following_url":"https://api.github.com/users/fr-matsuo/following{/other_user}","gists_url":"https://api.github.com/users/fr-matsuo/gists{/gist_id}","starred_url":"https://api.github.com/users/fr-matsuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fr-matsuo/subscriptions","organizations_url":"https://api.github.com/users/fr-matsuo/orgs","repos_url":"https://api.github.com/users/fr-matsuo/repos","events_url":"https://api.github.com/users/fr-matsuo/events{/privacy}","received_events_url":"https://api.github.com/users/fr-matsuo/received_events","type":"User","site_admin":false},"repo":{"id":20470994,"name":"laravel_training","full_name":"fr-matsuo/laravel_training","owner":{"login":"fr-matsuo","id":7111595,"avatar_url":"https://avatars.githubusercontent.com/u/7111595?","gravatar_id":"2aeac9a4a468285e7885f72e2e040926","url":"https://api.github.com/users/fr-matsuo","html_url":"https://github.com/fr-matsuo","followers_url":"https://api.github.com/users/fr-matsuo/followers","following_url":"https://api.github.com/users/fr-matsuo/following{/other_user}","gists_url":"https://api.github.com/users/fr-matsuo/gists{/gist_id}","starred_url":"https://api.github.com/users/fr-matsuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fr-matsuo/subscriptions","organizations_url":"https://api.github.com/users/fr-matsuo/orgs","repos_url":"https://api.github.com/users/fr-matsuo/repos","events_url":"https://api.github.com/users/fr-matsuo/events{/privacy}","received_events_url":"https://api.github.com/users/fr-matsuo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fr-matsuo/laravel_training","description":"","fork":false,"url":"https://api.github.com/repos/fr-matsuo/laravel_training","forks_url":"https://api.github.com/repos/fr-matsuo/laravel_training/forks","keys_url":"https://api.github.com/repos/fr-matsuo/laravel_training/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fr-matsuo/laravel_training/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fr-matsuo/laravel_training/teams","hooks_url":"https://api.github.com/repos/fr-matsuo/laravel_training/hooks","issue_events_url":"https://api.github.com/repos/fr-matsuo/laravel_training/issues/events{/number}","events_url":"https://api.github.com/repos/fr-matsuo/laravel_training/events","assignees_url":"https://api.github.com/repos/fr-matsuo/laravel_training/assignees{/user}","branches_url":"https://api.github.com/repos/fr-matsuo/laravel_training/branches{/branch}","tags_url":"https://api.github.com/repos/fr-matsuo/laravel_training/tags","blobs_url":"https://api.github.com/repos/fr-matsuo/laravel_training/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fr-matsuo/laravel_training/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fr-matsuo/laravel_training/git/refs{/sha}","trees_url":"https://api.github.com/repos/fr-matsuo/laravel_training/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fr-matsuo/laravel_training/statuses/{sha}","languages_url":"https://api.github.com/repos/fr-matsuo/laravel_training/languages","stargazers_url":"https://api.github.com/repos/fr-matsuo/laravel_training/stargazers","contributors_url":"https://api.github.com/repos/fr-matsuo/laravel_training/contributors","subscribers_url":"https://api.github.com/repos/fr-matsuo/laravel_training/subscribers","subscription_url":"https://api.github.com/repos/fr-matsuo/laravel_training/subscription","commits_url":"https://api.github.com/repos/fr-matsuo/laravel_training/commits{/sha}","git_commits_url":"https://api.github.com/repos/fr-matsuo/laravel_training/git/commits{/sha}","comments_url":"https://api.github.com/repos/fr-matsuo/laravel_training/comments{/number}","issue_comment_url":"https://api.github.com/repos/fr-matsuo/laravel_training/issues/comments/{number}","contents_url":"https://api.github.com/repos/fr-matsuo/laravel_training/contents/{+path}","compare_url":"https://api.github.com/repos/fr-matsuo/laravel_training/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fr-matsuo/laravel_training/merges","archive_url":"https://api.github.com/repos/fr-matsuo/laravel_training/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fr-matsuo/laravel_training/downloads","issues_url":"https://api.github.com/repos/fr-matsuo/laravel_training/issues{/number}","pulls_url":"https://api.github.com/repos/fr-matsuo/laravel_training/pulls{/number}","milestones_url":"https://api.github.com/repos/fr-matsuo/laravel_training/milestones{/number}","notifications_url":"https://api.github.com/repos/fr-matsuo/laravel_training/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fr-matsuo/laravel_training/labels{/name}","releases_url":"https://api.github.com/repos/fr-matsuo/laravel_training/releases{/id}","created_at":"2014-06-04T05:12:40Z","updated_at":"2014-06-16T03:19:53Z","pushed_at":"2014-06-16T03:19:53Z","git_url":"git://github.com/fr-matsuo/laravel_training.git","ssh_url":"git@github.com:fr-matsuo/laravel_training.git","clone_url":"https://github.com/fr-matsuo/laravel_training.git","svn_url":"https://github.com/fr-matsuo/laravel_training","homepage":null,"size":468,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"fr-matsuo:master","ref":"master","sha":"92ba22b7c8c1a0a695546ac6c23be8553cd3caec","user":{"login":"fr-matsuo","id":7111595,"avatar_url":"https://avatars.githubusercontent.com/u/7111595?","gravatar_id":"2aeac9a4a468285e7885f72e2e040926","url":"https://api.github.com/users/fr-matsuo","html_url":"https://github.com/fr-matsuo","followers_url":"https://api.github.com/users/fr-matsuo/followers","following_url":"https://api.github.com/users/fr-matsuo/following{/other_user}","gists_url":"https://api.github.com/users/fr-matsuo/gists{/gist_id}","starred_url":"https://api.github.com/users/fr-matsuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fr-matsuo/subscriptions","organizations_url":"https://api.github.com/users/fr-matsuo/orgs","repos_url":"https://api.github.com/users/fr-matsuo/repos","events_url":"https://api.github.com/users/fr-matsuo/events{/privacy}","received_events_url":"https://api.github.com/users/fr-matsuo/received_events","type":"User","site_admin":false},"repo":{"id":20470994,"name":"laravel_training","full_name":"fr-matsuo/laravel_training","owner":{"login":"fr-matsuo","id":7111595,"avatar_url":"https://avatars.githubusercontent.com/u/7111595?","gravatar_id":"2aeac9a4a468285e7885f72e2e040926","url":"https://api.github.com/users/fr-matsuo","html_url":"https://github.com/fr-matsuo","followers_url":"https://api.github.com/users/fr-matsuo/followers","following_url":"https://api.github.com/users/fr-matsuo/following{/other_user}","gists_url":"https://api.github.com/users/fr-matsuo/gists{/gist_id}","starred_url":"https://api.github.com/users/fr-matsuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fr-matsuo/subscriptions","organizations_url":"https://api.github.com/users/fr-matsuo/orgs","repos_url":"https://api.github.com/users/fr-matsuo/repos","events_url":"https://api.github.com/users/fr-matsuo/events{/privacy}","received_events_url":"https://api.github.com/users/fr-matsuo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fr-matsuo/laravel_training","description":"","fork":false,"url":"https://api.github.com/repos/fr-matsuo/laravel_training","forks_url":"https://api.github.com/repos/fr-matsuo/laravel_training/forks","keys_url":"https://api.github.com/repos/fr-matsuo/laravel_training/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fr-matsuo/laravel_training/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fr-matsuo/laravel_training/teams","hooks_url":"https://api.github.com/repos/fr-matsuo/laravel_training/hooks","issue_events_url":"https://api.github.com/repos/fr-matsuo/laravel_training/issues/events{/number}","events_url":"https://api.github.com/repos/fr-matsuo/laravel_training/events","assignees_url":"https://api.github.com/repos/fr-matsuo/laravel_training/assignees{/user}","branches_url":"https://api.github.com/repos/fr-matsuo/laravel_training/branches{/branch}","tags_url":"https://api.github.com/repos/fr-matsuo/laravel_training/tags","blobs_url":"https://api.github.com/repos/fr-matsuo/laravel_training/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fr-matsuo/laravel_training/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fr-matsuo/laravel_training/git/refs{/sha}","trees_url":"https://api.github.com/repos/fr-matsuo/laravel_training/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fr-matsuo/laravel_training/statuses/{sha}","languages_url":"https://api.github.com/repos/fr-matsuo/laravel_training/languages","stargazers_url":"https://api.github.com/repos/fr-matsuo/laravel_training/stargazers","contributors_url":"https://api.github.com/repos/fr-matsuo/laravel_training/contributors","subscribers_url":"https://api.github.com/repos/fr-matsuo/laravel_training/subscribers","subscription_url":"https://api.github.com/repos/fr-matsuo/laravel_training/subscription","commits_url":"https://api.github.com/repos/fr-matsuo/laravel_training/commits{/sha}","git_commits_url":"https://api.github.com/repos/fr-matsuo/laravel_training/git/commits{/sha}","comments_url":"https://api.github.com/repos/fr-matsuo/laravel_training/comments{/number}","issue_comment_url":"https://api.github.com/repos/fr-matsuo/laravel_training/issues/comments/{number}","contents_url":"https://api.github.com/repos/fr-matsuo/laravel_training/contents/{+path}","compare_url":"https://api.github.com/repos/fr-matsuo/laravel_training/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fr-matsuo/laravel_training/merges","archive_url":"https://api.github.com/repos/fr-matsuo/laravel_training/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fr-matsuo/laravel_training/downloads","issues_url":"https://api.github.com/repos/fr-matsuo/laravel_training/issues{/number}","pulls_url":"https://api.github.com/repos/fr-matsuo/laravel_training/pulls{/number}","milestones_url":"https://api.github.com/repos/fr-matsuo/laravel_training/milestones{/number}","notifications_url":"https://api.github.com/repos/fr-matsuo/laravel_training/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fr-matsuo/laravel_training/labels{/name}","releases_url":"https://api.github.com/repos/fr-matsuo/laravel_training/releases{/id}","created_at":"2014-06-04T05:12:40Z","updated_at":"2014-06-16T03:19:53Z","pushed_at":"2014-06-16T03:19:53Z","git_url":"git://github.com/fr-matsuo/laravel_training.git","ssh_url":"git@github.com:fr-matsuo/laravel_training.git","clone_url":"https://github.com/fr-matsuo/laravel_training.git","svn_url":"https://github.com/fr-matsuo/laravel_training","homepage":null,"size":468,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fr-matsuo/laravel_training/pulls/6"},"html":{"href":"https://github.com/fr-matsuo/laravel_training/pull/6"},"issue":{"href":"https://api.github.com/repos/fr-matsuo/laravel_training/issues/6"},"comments":{"href":"https://api.github.com/repos/fr-matsuo/laravel_training/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/fr-matsuo/laravel_training/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/fr-matsuo/laravel_training/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/fr-matsuo/laravel_training/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/fr-matsuo/laravel_training/statuses/6199ef1b5fef4502ab82cd534fb6c16e6aa57733"}}}}