GitHub PullRequestReviewCommentEvent at 2014-06-23 16:55:44
Repository: otp
Actor: lrascao
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/erlang/otp/pulls/comments/14085977","id":14085977,"diff_hunk":"@@ -19,7 +19,7 @@\n #\n \n # Expected autoconf version\n-EXPECTED_AUTOCONF_VERSION=2.59\n+EXPECTED_AUTOCONF_VERSION=2.68","path":"otp_build","position":null,"original_position":5,"commit_id":"51e6dceb0641122d0a43e403455ca48eaa25b924","original_commit_id":"5046c721c0e08aad84a877f03e710c7cf4b6aa30","user":{"login":"lrascao","id":639415,"avatar_url":"https://avatars.githubusercontent.com/u/639415?","gravatar_id":"509f8f3a2cfbfc96129089ede13f3546","url":"https://api.github.com/users/lrascao","html_url":"https://github.com/lrascao","followers_url":"https://api.github.com/users/lrascao/followers","following_url":"https://api.github.com/users/lrascao/following{/other_user}","gists_url":"https://api.github.com/users/lrascao/gists{/gist_id}","starred_url":"https://api.github.com/users/lrascao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lrascao/subscriptions","organizations_url":"https://api.github.com/users/lrascao/orgs","repos_url":"https://api.github.com/users/lrascao/repos","events_url":"https://api.github.com/users/lrascao/events{/privacy}","received_events_url":"https://api.github.com/users/lrascao/received_events","type":"User","site_admin":false},"body":"thanks for the input! i've simply reverted the change","created_at":"2014-06-23T16:55:44Z","updated_at":"2014-06-23T16:55:44Z","html_url":"https://github.com/erlang/otp/pull/403#discussion_r14085977","pull_request_url":"https://api.github.com/repos/erlang/otp/pulls/403","_links":{"self":{"href":"https://api.github.com/repos/erlang/otp/pulls/comments/14085977"},"html":{"href":"https://github.com/erlang/otp/pull/403#discussion_r14085977"},"pull_request":{"href":"https://api.github.com/repos/erlang/otp/pulls/403"}}},"pull_request":{"url":"https://api.github.com/repos/erlang/otp/pulls/403","id":17481795,"html_url":"https://github.com/erlang/otp/pull/403","diff_url":"https://github.com/erlang/otp/pull/403.diff","patch_url":"https://github.com/erlang/otp/pull/403.patch","issue_url":"https://api.github.com/repos/erlang/otp/issues/403","number":403,"state":"open","title":"Friendlier windows build","user":{"login":"lrascao","id":639415,"avatar_url":"https://avatars.githubusercontent.com/u/639415?","gravatar_id":"509f8f3a2cfbfc96129089ede13f3546","url":"https://api.github.com/users/lrascao","html_url":"https://github.com/lrascao","followers_url":"https://api.github.com/users/lrascao/followers","following_url":"https://api.github.com/users/lrascao/following{/other_user}","gists_url":"https://api.github.com/users/lrascao/gists{/gist_id}","starred_url":"https://api.github.com/users/lrascao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lrascao/subscriptions","organizations_url":"https://api.github.com/users/lrascao/orgs","repos_url":"https://api.github.com/users/lrascao/repos","events_url":"https://api.github.com/users/lrascao/events{/privacy}","received_events_url":"https://api.github.com/users/lrascao/received_events","type":"User","site_admin":false},"body":"only three env variables should already be defined before invoking eval `./otp_build env_win64`, the script takes care setting the rest of the variables\r\n  MSDEV_PATH  (eg. C:\\Program Files (x86)\\Microsoft Visual Studio 10.0)\r\n  PLATFORMSDK_PATH (eg. C:\\Program Files (x86)\\Microsoft SDKs\\Windows\\v7.0A)\r\n  JDK_HOME (eg. /cygdrive/c/Program Files/Java/jdk1.7.0_03)\r\n\r\n","created_at":"2014-06-23T15:46:57Z","updated_at":"2014-06-23T16:55:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2db9b2894ae8a1d676b98cb4fc47f1da261d35ca","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/erlang/otp/pulls/403/commits","review_comments_url":"https://api.github.com/repos/erlang/otp/pulls/403/comments","review_comment_url":"https://api.github.com/repos/erlang/otp/pulls/comments/{number}","comments_url":"https://api.github.com/repos/erlang/otp/issues/403/comments","statuses_url":"https://api.github.com/repos/erlang/otp/statuses/51e6dceb0641122d0a43e403455ca48eaa25b924","head":{"label":"lrascao:friendlier_windows_build","ref":"friendlier_windows_build","sha":"51e6dceb0641122d0a43e403455ca48eaa25b924","user":{"login":"lrascao","id":639415,"avatar_url":"https://avatars.githubusercontent.com/u/639415?","gravatar_id":"509f8f3a2cfbfc96129089ede13f3546","url":"https://api.github.com/users/lrascao","html_url":"https://github.com/lrascao","followers_url":"https://api.github.com/users/lrascao/followers","following_url":"https://api.github.com/users/lrascao/following{/other_user}","gists_url":"https://api.github.com/users/lrascao/gists{/gist_id}","starred_url":"https://api.github.com/users/lrascao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lrascao/subscriptions","organizations_url":"https://api.github.com/users/lrascao/orgs","repos_url":"https://api.github.com/users/lrascao/repos","events_url":"https://api.github.com/users/lrascao/events{/privacy}","received_events_url":"https://api.github.com/users/lrascao/received_events","type":"User","site_admin":false},"repo":{"id":20764012,"name":"otp","full_name":"lrascao/otp","owner":{"login":"lrascao","id":639415,"avatar_url":"https://avatars.githubusercontent.com/u/639415?","gravatar_id":"509f8f3a2cfbfc96129089ede13f3546","url":"https://api.github.com/users/lrascao","html_url":"https://github.com/lrascao","followers_url":"https://api.github.com/users/lrascao/followers","following_url":"https://api.github.com/users/lrascao/following{/other_user}","gists_url":"https://api.github.com/users/lrascao/gists{/gist_id}","starred_url":"https://api.github.com/users/lrascao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lrascao/subscriptions","organizations_url":"https://api.github.com/users/lrascao/orgs","repos_url":"https://api.github.com/users/lrascao/repos","events_url":"https://api.github.com/users/lrascao/events{/privacy}","received_events_url":"https://api.github.com/users/lrascao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lrascao/otp","description":"Erlang/OTP","fork":true,"url":"https://api.github.com/repos/lrascao/otp","forks_url":"https://api.github.com/repos/lrascao/otp/forks","keys_url":"https://api.github.com/repos/lrascao/otp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lrascao/otp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lrascao/otp/teams","hooks_url":"https://api.github.com/repos/lrascao/otp/hooks","issue_events_url":"https://api.github.com/repos/lrascao/otp/issues/events{/number}","events_url":"https://api.github.com/repos/lrascao/otp/events","assignees_url":"https://api.github.com/repos/lrascao/otp/assignees{/user}","branches_url":"https://api.github.com/repos/lrascao/otp/branches{/branch}","tags_url":"https://api.github.com/repos/lrascao/otp/tags","blobs_url":"https://api.github.com/repos/lrascao/otp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lrascao/otp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lrascao/otp/git/refs{/sha}","trees_url":"https://api.github.com/repos/lrascao/otp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lrascao/otp/statuses/{sha}","languages_url":"https://api.github.com/repos/lrascao/otp/languages","stargazers_url":"https://api.github.com/repos/lrascao/otp/stargazers","contributors_url":"https://api.github.com/repos/lrascao/otp/contributors","subscribers_url":"https://api.github.com/repos/lrascao/otp/subscribers","subscription_url":"https://api.github.com/repos/lrascao/otp/subscription","commits_url":"https://api.github.com/repos/lrascao/otp/commits{/sha}","git_commits_url":"https://api.github.com/repos/lrascao/otp/git/commits{/sha}","comments_url":"https://api.github.com/repos/lrascao/otp/comments{/number}","issue_comment_url":"https://api.github.com/repos/lrascao/otp/issues/comments/{number}","contents_url":"https://api.github.com/repos/lrascao/otp/contents/{+path}","compare_url":"https://api.github.com/repos/lrascao/otp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lrascao/otp/merges","archive_url":"https://api.github.com/repos/lrascao/otp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lrascao/otp/downloads","issues_url":"https://api.github.com/repos/lrascao/otp/issues{/number}","pulls_url":"https://api.github.com/repos/lrascao/otp/pulls{/number}","milestones_url":"https://api.github.com/repos/lrascao/otp/milestones{/number}","notifications_url":"https://api.github.com/repos/lrascao/otp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lrascao/otp/labels{/name}","releases_url":"https://api.github.com/repos/lrascao/otp/releases{/id}","created_at":"2014-06-12T10:43:28Z","updated_at":"2014-06-23T16:54:57Z","pushed_at":"2014-06-23T16:54:56Z","git_url":"git://github.com/lrascao/otp.git","ssh_url":"git@github.com:lrascao/otp.git","clone_url":"https://github.com/lrascao/otp.git","svn_url":"https://github.com/lrascao/otp","homepage":"http://erlang.org","size":172894,"stargazers_count":0,"watchers_count":0,"language":"Erlang","has_issues":true,"has_downloads":false,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"maint"}},"base":{"label":"erlang:maint","ref":"maint","sha":"c9e36ab16034bb7fe71f772df6bba22070976bbf","user":{"login":"erlang","id":153393,"avatar_url":"https://avatars.githubusercontent.com/u/153393?","gravatar_id":"ad362b896bde685c30da5569549cf531","url":"https://api.github.com/users/erlang","html_url":"https://github.com/erlang","followers_url":"https://api.github.com/users/erlang/followers","following_url":"https://api.github.com/users/erlang/following{/other_user}","gists_url":"https://api.github.com/users/erlang/gists{/gist_id}","starred_url":"https://api.github.com/users/erlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erlang/subscriptions","organizations_url":"https://api.github.com/users/erlang/orgs","repos_url":"https://api.github.com/users/erlang/repos","events_url":"https://api.github.com/users/erlang/events{/privacy}","received_events_url":"https://api.github.com/users/erlang/received_events","type":"Organization","site_admin":false},"repo":{"id":374927,"name":"otp","full_name":"erlang/otp","owner":{"login":"erlang","id":153393,"avatar_url":"https://avatars.githubusercontent.com/u/153393?","gravatar_id":"ad362b896bde685c30da5569549cf531","url":"https://api.github.com/users/erlang","html_url":"https://github.com/erlang","followers_url":"https://api.github.com/users/erlang/followers","following_url":"https://api.github.com/users/erlang/following{/other_user}","gists_url":"https://api.github.com/users/erlang/gists{/gist_id}","starred_url":"https://api.github.com/users/erlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erlang/subscriptions","organizations_url":"https://api.github.com/users/erlang/orgs","repos_url":"https://api.github.com/users/erlang/repos","events_url":"https://api.github.com/users/erlang/events{/privacy}","received_events_url":"https://api.github.com/users/erlang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/erlang/otp","description":"Erlang/OTP","fork":false,"url":"https://api.github.com/repos/erlang/otp","forks_url":"https://api.github.com/repos/erlang/otp/forks","keys_url":"https://api.github.com/repos/erlang/otp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/erlang/otp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/erlang/otp/teams","hooks_url":"https://api.github.com/repos/erlang/otp/hooks","issue_events_url":"https://api.github.com/repos/erlang/otp/issues/events{/number}","events_url":"https://api.github.com/repos/erlang/otp/events","assignees_url":"https://api.github.com/repos/erlang/otp/assignees{/user}","branches_url":"https://api.github.com/repos/erlang/otp/branches{/branch}","tags_url":"https://api.github.com/repos/erlang/otp/tags","blobs_url":"https://api.github.com/repos/erlang/otp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/erlang/otp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/erlang/otp/git/refs{/sha}","trees_url":"https://api.github.com/repos/erlang/otp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/erlang/otp/statuses/{sha}","languages_url":"https://api.github.com/repos/erlang/otp/languages","stargazers_url":"https://api.github.com/repos/erlang/otp/stargazers","contributors_url":"https://api.github.com/repos/erlang/otp/contributors","subscribers_url":"https://api.github.com/repos/erlang/otp/subscribers","subscription_url":"https://api.github.com/repos/erlang/otp/subscription","commits_url":"https://api.github.com/repos/erlang/otp/commits{/sha}","git_commits_url":"https://api.github.com/repos/erlang/otp/git/commits{/sha}","comments_url":"https://api.github.com/repos/erlang/otp/comments{/number}","issue_comment_url":"https://api.github.com/repos/erlang/otp/issues/comments/{number}","contents_url":"https://api.github.com/repos/erlang/otp/contents/{+path}","compare_url":"https://api.github.com/repos/erlang/otp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/erlang/otp/merges","archive_url":"https://api.github.com/repos/erlang/otp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/erlang/otp/downloads","issues_url":"https://api.github.com/repos/erlang/otp/issues{/number}","pulls_url":"https://api.github.com/repos/erlang/otp/pulls{/number}","milestones_url":"https://api.github.com/repos/erlang/otp/milestones{/number}","notifications_url":"https://api.github.com/repos/erlang/otp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/erlang/otp/labels{/name}","releases_url":"https://api.github.com/repos/erlang/otp/releases{/id}","created_at":"2009-11-16T17:17:57Z","updated_at":"2014-06-23T13:59:31Z","pushed_at":"2014-06-04T14:37:42Z","git_url":"git://github.com/erlang/otp.git","ssh_url":"git@github.com:erlang/otp.git","clone_url":"https://github.com/erlang/otp.git","svn_url":"https://github.com/erlang/otp","homepage":"http://erlang.org","size":172894,"stargazers_count":2615,"watchers_count":2615,"language":"Erlang","has_issues":false,"has_downloads":false,"has_wiki":true,"forks_count":825,"mirror_url":null,"open_issues_count":71,"forks":825,"open_issues":71,"watchers":2615,"default_branch":"maint"}},"_links":{"self":{"href":"https://api.github.com/repos/erlang/otp/pulls/403"},"html":{"href":"https://github.com/erlang/otp/pull/403"},"issue":{"href":"https://api.github.com/repos/erlang/otp/issues/403"},"comments":{"href":"https://api.github.com/repos/erlang/otp/issues/403/comments"},"review_comments":{"href":"https://api.github.com/repos/erlang/otp/pulls/403/comments"},"review_comment":{"href":"https://api.github.com/repos/erlang/otp/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/erlang/otp/pulls/403/commits"},"statuses":{"href":"https://api.github.com/repos/erlang/otp/statuses/51e6dceb0641122d0a43e403455ca48eaa25b924"}}}}