GitHub PullRequestReviewCommentEvent at 2014-07-05 16:59:51
Repository: Markus
Actor: zhangsu
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/comments/14571868","id":14571868,"diff_hunk":"@@ -360,22 +339,21 @@ def add_members(student_ids, grouping_id, assignment)\n     group_name = grouping.group.group_name\n     if assignment.student_form_groups\n       if students_in_group > assignment.group_max\n-        @warning_group_size = I18n.t('assignment.group.assign_over_limit',\n-          group: group_name)\n-\n+        return render text: I18n.t('assignment.group.assign_over_limit', group: group_name),","path":"app/controllers/groups_controller.rb","position":232,"original_position":214,"commit_id":"b09ffc2e864cb936e95808c974c78f7cf98508a9","original_commit_id":"7a9b51d97ea1efae77b1d6303331f449220c2d86","user":{"login":"zhangsu","id":743034,"avatar_url":"https://avatars.githubusercontent.com/u/743034?","gravatar_id":"b668cd93f5eadfa3a7b39ea479f3c532","url":"https://api.github.com/users/zhangsu","html_url":"https://github.com/zhangsu","followers_url":"https://api.github.com/users/zhangsu/followers","following_url":"https://api.github.com/users/zhangsu/following{/other_user}","gists_url":"https://api.github.com/users/zhangsu/gists{/gist_id}","starred_url":"https://api.github.com/users/zhangsu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhangsu/subscriptions","organizations_url":"https://api.github.com/users/zhangsu/orgs","repos_url":"https://api.github.com/users/zhangsu/repos","events_url":"https://api.github.com/users/zhangsu/events{/privacy}","received_events_url":"https://api.github.com/users/zhangsu/received_events","type":"User","site_admin":false},"body":"Maybe use a local variable for the text to fix the long line?","created_at":"2014-07-05T16:59:51Z","updated_at":"2014-07-05T16:59:51Z","html_url":"https://github.com/MarkUsProject/Markus/pull/1539#discussion_r14571868","pull_request_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/1539","_links":{"self":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/comments/14571868"},"html":{"href":"https://github.com/MarkUsProject/Markus/pull/1539#discussion_r14571868"},"pull_request":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/1539"}}},"pull_request":{"url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/1539","id":17316149,"html_url":"https://github.com/MarkUsProject/Markus/pull/1539","diff_url":"https://github.com/MarkUsProject/Markus/pull/1539.diff","patch_url":"https://github.com/MarkUsProject/Markus/pull/1539.patch","issue_url":"https://api.github.com/repos/MarkUsProject/Markus/issues/1539","number":1539,"state":"open","title":"React tables","user":{"login":"oneohtrix","id":963922,"avatar_url":"https://avatars.githubusercontent.com/u/963922?","gravatar_id":"0b4c9712cae2a50775fa0a3c1a41aab1","url":"https://api.github.com/users/oneohtrix","html_url":"https://github.com/oneohtrix","followers_url":"https://api.github.com/users/oneohtrix/followers","following_url":"https://api.github.com/users/oneohtrix/following{/other_user}","gists_url":"https://api.github.com/users/oneohtrix/gists{/gist_id}","starred_url":"https://api.github.com/users/oneohtrix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oneohtrix/subscriptions","organizations_url":"https://api.github.com/users/oneohtrix/orgs","repos_url":"https://api.github.com/users/oneohtrix/repos","events_url":"https://api.github.com/users/oneohtrix/events{/privacy}","received_events_url":"https://api.github.com/users/oneohtrix/received_events","type":"User","site_admin":false},"body":"This is a redo of #1502. I have done some architectural restructuring so that the base Table React component is more generalizable, and I've changed the way components get mounted onto the view (originally was using the react-rails gem, but now going a more native route). Also deleted unnecessary .rjs files (for the original tables) and partials, as well as the students' populate route in route.rb (we now populate by sending an AJAX request to the same url, just requesting it in JSON).","created_at":"2014-06-18T20:08:42Z","updated_at":"2014-07-05T16:59:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"313a066d34ca9b5bfa8d73fd51425dc468364ca9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/1539/commits","review_comments_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/1539/comments","review_comment_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/comments/{number}","comments_url":"https://api.github.com/repos/MarkUsProject/Markus/issues/1539/comments","statuses_url":"https://api.github.com/repos/MarkUsProject/Markus/statuses/b09ffc2e864cb936e95808c974c78f7cf98508a9","head":{"label":"oneohtrix:react_tables","ref":"react_tables","sha":"b09ffc2e864cb936e95808c974c78f7cf98508a9","user":{"login":"oneohtrix","id":963922,"avatar_url":"https://avatars.githubusercontent.com/u/963922?","gravatar_id":"0b4c9712cae2a50775fa0a3c1a41aab1","url":"https://api.github.com/users/oneohtrix","html_url":"https://github.com/oneohtrix","followers_url":"https://api.github.com/users/oneohtrix/followers","following_url":"https://api.github.com/users/oneohtrix/following{/other_user}","gists_url":"https://api.github.com/users/oneohtrix/gists{/gist_id}","starred_url":"https://api.github.com/users/oneohtrix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oneohtrix/subscriptions","organizations_url":"https://api.github.com/users/oneohtrix/orgs","repos_url":"https://api.github.com/users/oneohtrix/repos","events_url":"https://api.github.com/users/oneohtrix/events{/privacy}","received_events_url":"https://api.github.com/users/oneohtrix/received_events","type":"User","site_admin":false},"repo":{"id":19577180,"name":"Markus","full_name":"oneohtrix/Markus","owner":{"login":"oneohtrix","id":963922,"avatar_url":"https://avatars.githubusercontent.com/u/963922?","gravatar_id":"0b4c9712cae2a50775fa0a3c1a41aab1","url":"https://api.github.com/users/oneohtrix","html_url":"https://github.com/oneohtrix","followers_url":"https://api.github.com/users/oneohtrix/followers","following_url":"https://api.github.com/users/oneohtrix/following{/other_user}","gists_url":"https://api.github.com/users/oneohtrix/gists{/gist_id}","starred_url":"https://api.github.com/users/oneohtrix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oneohtrix/subscriptions","organizations_url":"https://api.github.com/users/oneohtrix/orgs","repos_url":"https://api.github.com/users/oneohtrix/repos","events_url":"https://api.github.com/users/oneohtrix/events{/privacy}","received_events_url":"https://api.github.com/users/oneohtrix/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/oneohtrix/Markus","description":"Git repository of MarkUs","fork":true,"url":"https://api.github.com/repos/oneohtrix/Markus","forks_url":"https://api.github.com/repos/oneohtrix/Markus/forks","keys_url":"https://api.github.com/repos/oneohtrix/Markus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oneohtrix/Markus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oneohtrix/Markus/teams","hooks_url":"https://api.github.com/repos/oneohtrix/Markus/hooks","issue_events_url":"https://api.github.com/repos/oneohtrix/Markus/issues/events{/number}","events_url":"https://api.github.com/repos/oneohtrix/Markus/events","assignees_url":"https://api.github.com/repos/oneohtrix/Markus/assignees{/user}","branches_url":"https://api.github.com/repos/oneohtrix/Markus/branches{/branch}","tags_url":"https://api.github.com/repos/oneohtrix/Markus/tags","blobs_url":"https://api.github.com/repos/oneohtrix/Markus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oneohtrix/Markus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oneohtrix/Markus/git/refs{/sha}","trees_url":"https://api.github.com/repos/oneohtrix/Markus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oneohtrix/Markus/statuses/{sha}","languages_url":"https://api.github.com/repos/oneohtrix/Markus/languages","stargazers_url":"https://api.github.com/repos/oneohtrix/Markus/stargazers","contributors_url":"https://api.github.com/repos/oneohtrix/Markus/contributors","subscribers_url":"https://api.github.com/repos/oneohtrix/Markus/subscribers","subscription_url":"https://api.github.com/repos/oneohtrix/Markus/subscription","commits_url":"https://api.github.com/repos/oneohtrix/Markus/commits{/sha}","git_commits_url":"https://api.github.com/repos/oneohtrix/Markus/git/commits{/sha}","comments_url":"https://api.github.com/repos/oneohtrix/Markus/comments{/number}","issue_comment_url":"https://api.github.com/repos/oneohtrix/Markus/issues/comments/{number}","contents_url":"https://api.github.com/repos/oneohtrix/Markus/contents/{+path}","compare_url":"https://api.github.com/repos/oneohtrix/Markus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oneohtrix/Markus/merges","archive_url":"https://api.github.com/repos/oneohtrix/Markus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oneohtrix/Markus/downloads","issues_url":"https://api.github.com/repos/oneohtrix/Markus/issues{/number}","pulls_url":"https://api.github.com/repos/oneohtrix/Markus/pulls{/number}","milestones_url":"https://api.github.com/repos/oneohtrix/Markus/milestones{/number}","notifications_url":"https://api.github.com/repos/oneohtrix/Markus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oneohtrix/Markus/labels{/name}","releases_url":"https://api.github.com/repos/oneohtrix/Markus/releases{/id}","created_at":"2014-05-08T14:49:32Z","updated_at":"2014-06-24T18:40:20Z","pushed_at":"2014-07-05T15:50:19Z","git_url":"git://github.com/oneohtrix/Markus.git","ssh_url":"git@github.com:oneohtrix/Markus.git","clone_url":"https://github.com/oneohtrix/Markus.git","svn_url":"https://github.com/oneohtrix/Markus","homepage":"http://www.markusproject.org","size":16215,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MarkUsProject:master","ref":"master","sha":"126327ba07f1cdbc02656a29883e37b212c542dd","user":{"login":"MarkUsProject","id":415874,"avatar_url":"https://avatars.githubusercontent.com/u/415874?","gravatar_id":"7fd5c1f7357ff6089fd2ea12640529ab","url":"https://api.github.com/users/MarkUsProject","html_url":"https://github.com/MarkUsProject","followers_url":"https://api.github.com/users/MarkUsProject/followers","following_url":"https://api.github.com/users/MarkUsProject/following{/other_user}","gists_url":"https://api.github.com/users/MarkUsProject/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkUsProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkUsProject/subscriptions","organizations_url":"https://api.github.com/users/MarkUsProject/orgs","repos_url":"https://api.github.com/users/MarkUsProject/repos","events_url":"https://api.github.com/users/MarkUsProject/events{/privacy}","received_events_url":"https://api.github.com/users/MarkUsProject/received_events","type":"Organization","site_admin":false},"repo":{"id":940538,"name":"Markus","full_name":"MarkUsProject/Markus","owner":{"login":"MarkUsProject","id":415874,"avatar_url":"https://avatars.githubusercontent.com/u/415874?","gravatar_id":"7fd5c1f7357ff6089fd2ea12640529ab","url":"https://api.github.com/users/MarkUsProject","html_url":"https://github.com/MarkUsProject","followers_url":"https://api.github.com/users/MarkUsProject/followers","following_url":"https://api.github.com/users/MarkUsProject/following{/other_user}","gists_url":"https://api.github.com/users/MarkUsProject/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkUsProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkUsProject/subscriptions","organizations_url":"https://api.github.com/users/MarkUsProject/orgs","repos_url":"https://api.github.com/users/MarkUsProject/repos","events_url":"https://api.github.com/users/MarkUsProject/events{/privacy}","received_events_url":"https://api.github.com/users/MarkUsProject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MarkUsProject/Markus","description":"Git repository of MarkUs","fork":false,"url":"https://api.github.com/repos/MarkUsProject/Markus","forks_url":"https://api.github.com/repos/MarkUsProject/Markus/forks","keys_url":"https://api.github.com/repos/MarkUsProject/Markus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MarkUsProject/Markus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MarkUsProject/Markus/teams","hooks_url":"https://api.github.com/repos/MarkUsProject/Markus/hooks","issue_events_url":"https://api.github.com/repos/MarkUsProject/Markus/issues/events{/number}","events_url":"https://api.github.com/repos/MarkUsProject/Markus/events","assignees_url":"https://api.github.com/repos/MarkUsProject/Markus/assignees{/user}","branches_url":"https://api.github.com/repos/MarkUsProject/Markus/branches{/branch}","tags_url":"https://api.github.com/repos/MarkUsProject/Markus/tags","blobs_url":"https://api.github.com/repos/MarkUsProject/Markus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MarkUsProject/Markus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MarkUsProject/Markus/git/refs{/sha}","trees_url":"https://api.github.com/repos/MarkUsProject/Markus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MarkUsProject/Markus/statuses/{sha}","languages_url":"https://api.github.com/repos/MarkUsProject/Markus/languages","stargazers_url":"https://api.github.com/repos/MarkUsProject/Markus/stargazers","contributors_url":"https://api.github.com/repos/MarkUsProject/Markus/contributors","subscribers_url":"https://api.github.com/repos/MarkUsProject/Markus/subscribers","subscription_url":"https://api.github.com/repos/MarkUsProject/Markus/subscription","commits_url":"https://api.github.com/repos/MarkUsProject/Markus/commits{/sha}","git_commits_url":"https://api.github.com/repos/MarkUsProject/Markus/git/commits{/sha}","comments_url":"https://api.github.com/repos/MarkUsProject/Markus/comments{/number}","issue_comment_url":"https://api.github.com/repos/MarkUsProject/Markus/issues/comments/{number}","contents_url":"https://api.github.com/repos/MarkUsProject/Markus/contents/{+path}","compare_url":"https://api.github.com/repos/MarkUsProject/Markus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MarkUsProject/Markus/merges","archive_url":"https://api.github.com/repos/MarkUsProject/Markus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MarkUsProject/Markus/downloads","issues_url":"https://api.github.com/repos/MarkUsProject/Markus/issues{/number}","pulls_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls{/number}","milestones_url":"https://api.github.com/repos/MarkUsProject/Markus/milestones{/number}","notifications_url":"https://api.github.com/repos/MarkUsProject/Markus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MarkUsProject/Markus/labels{/name}","releases_url":"https://api.github.com/repos/MarkUsProject/Markus/releases{/id}","created_at":"2010-09-26T16:18:08Z","updated_at":"2014-07-02T05:14:34Z","pushed_at":"2014-07-04T22:41:31Z","git_url":"git://github.com/MarkUsProject/Markus.git","ssh_url":"git@github.com:MarkUsProject/Markus.git","clone_url":"https://github.com/MarkUsProject/Markus.git","svn_url":"https://github.com/MarkUsProject/Markus","homepage":"http://www.markusproject.org","size":41965,"stargazers_count":103,"watchers_count":103,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":124,"mirror_url":null,"open_issues_count":107,"forks":124,"open_issues":107,"watchers":103,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/1539"},"html":{"href":"https://github.com/MarkUsProject/Markus/pull/1539"},"issue":{"href":"https://api.github.com/repos/MarkUsProject/Markus/issues/1539"},"comments":{"href":"https://api.github.com/repos/MarkUsProject/Markus/issues/1539/comments"},"review_comments":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/1539/comments"},"review_comment":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/1539/commits"},"statuses":{"href":"https://api.github.com/repos/MarkUsProject/Markus/statuses/b09ffc2e864cb936e95808c974c78f7cf98508a9"}}}}