GitHub PullRequestReviewCommentEvent at 2014-09-24 22:10:03
Repository: libuv
Actor: trevnorris
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/joyent/libuv/pulls/comments/18003994","id":18003994,"diff_hunk":"@@ -1742,6 +1779,11 @@ void uv_process_pipe_connect_req(uv_loop_t* loop, uv_pipe_t* handle,\n     req->cb(req, uv_translate_sys_error(err));\n   }\n \n+  if (!err)\n+    uv__write_callbacks((uv_stream_t*) handle);\n+  else\n+    uv__stream_flush_write_queue((uv_stream_t*) handle, UV_ECANCELED);","path":"src/win/pipe.c","position":141,"original_position":141,"commit_id":"e7b3e71c862025f15eb72ec2cd483531b589c1e3","original_commit_id":"e7b3e71c862025f15eb72ec2cd483531b589c1e3","user":{"login":"trevnorris","id":289174,"avatar_url":"https://avatars.githubusercontent.com/u/289174?v=2","gravatar_id":"","url":"https://api.github.com/users/trevnorris","html_url":"https://github.com/trevnorris","followers_url":"https://api.github.com/users/trevnorris/followers","following_url":"https://api.github.com/users/trevnorris/following{/other_user}","gists_url":"https://api.github.com/users/trevnorris/gists{/gist_id}","starred_url":"https://api.github.com/users/trevnorris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevnorris/subscriptions","organizations_url":"https://api.github.com/users/trevnorris/orgs","repos_url":"https://api.github.com/users/trevnorris/repos","events_url":"https://api.github.com/users/trevnorris/events{/privacy}","received_events_url":"https://api.github.com/users/trevnorris/received_events","type":"User","site_admin":false},"body":"According to @piscisaureus the data should be written before `req->cb()` is called:\r\n> \\<piscisaureus\\> what you should do is start flushing the write queue in uv_tcp_process_connect_req\r\n> \\<piscisaureus\\> just insert the logic here -> https://github.com/joyent/libuv/blob/master/src/win/tcp.c#L1112\r\n> \\<piscisaureus\\> [Y]ou have to consider the case that the user writes more in the callback, and you want to keep the writes ordered\r\n","created_at":"2014-09-24T22:10:03Z","updated_at":"2014-09-24T22:10:03Z","html_url":"https://github.com/joyent/libuv/pull/1487#discussion_r18003994","pull_request_url":"https://api.github.com/repos/joyent/libuv/pulls/1487","_links":{"self":{"href":"https://api.github.com/repos/joyent/libuv/pulls/comments/18003994"},"html":{"href":"https://github.com/joyent/libuv/pull/1487#discussion_r18003994"},"pull_request":{"href":"https://api.github.com/repos/joyent/libuv/pulls/1487"}}},"pull_request":{"url":"https://api.github.com/repos/joyent/libuv/pulls/1487","id":21573118,"html_url":"https://github.com/joyent/libuv/pull/1487","diff_url":"https://github.com/joyent/libuv/pull/1487.diff","patch_url":"https://github.com/joyent/libuv/pull/1487.patch","issue_url":"https://api.github.com/repos/joyent/libuv/issues/1487","number":1487,"state":"open","locked":false,"title":"Write queue after connect windows","user":{"login":"txdv","id":116642,"avatar_url":"https://avatars.githubusercontent.com/u/116642?v=2","gravatar_id":"","url":"https://api.github.com/users/txdv","html_url":"https://github.com/txdv","followers_url":"https://api.github.com/users/txdv/followers","following_url":"https://api.github.com/users/txdv/following{/other_user}","gists_url":"https://api.github.com/users/txdv/gists{/gist_id}","starred_url":"https://api.github.com/users/txdv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/txdv/subscriptions","organizations_url":"https://api.github.com/users/txdv/orgs","repos_url":"https://api.github.com/users/txdv/repos","events_url":"https://api.github.com/users/txdv/events{/privacy}","received_events_url":"https://api.github.com/users/txdv/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-09-22T11:29:23Z","updated_at":"2014-09-24T22:10:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"45cd1e8e962fd22d3baaffbdc2bfccfef6468f73","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/joyent/libuv/pulls/1487/commits","review_comments_url":"https://api.github.com/repos/joyent/libuv/pulls/1487/comments","review_comment_url":"https://api.github.com/repos/joyent/libuv/pulls/comments/{number}","comments_url":"https://api.github.com/repos/joyent/libuv/issues/1487/comments","statuses_url":"https://api.github.com/repos/joyent/libuv/statuses/e7b3e71c862025f15eb72ec2cd483531b589c1e3","head":{"label":"txdv:write_queue","ref":"write_queue","sha":"e7b3e71c862025f15eb72ec2cd483531b589c1e3","user":{"login":"txdv","id":116642,"avatar_url":"https://avatars.githubusercontent.com/u/116642?v=2","gravatar_id":"","url":"https://api.github.com/users/txdv","html_url":"https://github.com/txdv","followers_url":"https://api.github.com/users/txdv/followers","following_url":"https://api.github.com/users/txdv/following{/other_user}","gists_url":"https://api.github.com/users/txdv/gists{/gist_id}","starred_url":"https://api.github.com/users/txdv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/txdv/subscriptions","organizations_url":"https://api.github.com/users/txdv/orgs","repos_url":"https://api.github.com/users/txdv/repos","events_url":"https://api.github.com/users/txdv/events{/privacy}","received_events_url":"https://api.github.com/users/txdv/received_events","type":"User","site_admin":false},"repo":{"id":3019200,"name":"libuv","full_name":"txdv/libuv","owner":{"login":"txdv","id":116642,"avatar_url":"https://avatars.githubusercontent.com/u/116642?v=2","gravatar_id":"","url":"https://api.github.com/users/txdv","html_url":"https://github.com/txdv","followers_url":"https://api.github.com/users/txdv/followers","following_url":"https://api.github.com/users/txdv/following{/other_user}","gists_url":"https://api.github.com/users/txdv/gists{/gist_id}","starred_url":"https://api.github.com/users/txdv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/txdv/subscriptions","organizations_url":"https://api.github.com/users/txdv/orgs","repos_url":"https://api.github.com/users/txdv/repos","events_url":"https://api.github.com/users/txdv/events{/privacy}","received_events_url":"https://api.github.com/users/txdv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/txdv/libuv","description":"platform layer for node.js","fork":true,"url":"https://api.github.com/repos/txdv/libuv","forks_url":"https://api.github.com/repos/txdv/libuv/forks","keys_url":"https://api.github.com/repos/txdv/libuv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/txdv/libuv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/txdv/libuv/teams","hooks_url":"https://api.github.com/repos/txdv/libuv/hooks","issue_events_url":"https://api.github.com/repos/txdv/libuv/issues/events{/number}","events_url":"https://api.github.com/repos/txdv/libuv/events","assignees_url":"https://api.github.com/repos/txdv/libuv/assignees{/user}","branches_url":"https://api.github.com/repos/txdv/libuv/branches{/branch}","tags_url":"https://api.github.com/repos/txdv/libuv/tags","blobs_url":"https://api.github.com/repos/txdv/libuv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/txdv/libuv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/txdv/libuv/git/refs{/sha}","trees_url":"https://api.github.com/repos/txdv/libuv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/txdv/libuv/statuses/{sha}","languages_url":"https://api.github.com/repos/txdv/libuv/languages","stargazers_url":"https://api.github.com/repos/txdv/libuv/stargazers","contributors_url":"https://api.github.com/repos/txdv/libuv/contributors","subscribers_url":"https://api.github.com/repos/txdv/libuv/subscribers","subscription_url":"https://api.github.com/repos/txdv/libuv/subscription","commits_url":"https://api.github.com/repos/txdv/libuv/commits{/sha}","git_commits_url":"https://api.github.com/repos/txdv/libuv/git/commits{/sha}","comments_url":"https://api.github.com/repos/txdv/libuv/comments{/number}","issue_comment_url":"https://api.github.com/repos/txdv/libuv/issues/comments/{number}","contents_url":"https://api.github.com/repos/txdv/libuv/contents/{+path}","compare_url":"https://api.github.com/repos/txdv/libuv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/txdv/libuv/merges","archive_url":"https://api.github.com/repos/txdv/libuv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/txdv/libuv/downloads","issues_url":"https://api.github.com/repos/txdv/libuv/issues{/number}","pulls_url":"https://api.github.com/repos/txdv/libuv/pulls{/number}","milestones_url":"https://api.github.com/repos/txdv/libuv/milestones{/number}","notifications_url":"https://api.github.com/repos/txdv/libuv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/txdv/libuv/labels{/name}","releases_url":"https://api.github.com/repos/txdv/libuv/releases{/id}","created_at":"2011-12-20T12:01:05Z","updated_at":"2014-06-29T15:41:11Z","pushed_at":"2014-09-24T12:20:01Z","git_url":"git://github.com/txdv/libuv.git","ssh_url":"git@github.com:txdv/libuv.git","clone_url":"https://github.com/txdv/libuv.git","svn_url":"https://github.com/txdv/libuv","homepage":"http://nodejs.org/","size":14617,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"joyent:v1.x","ref":"v1.x","sha":"2f54947b72170bc0bd19c8b4fafa3131bc8fb316","user":{"login":"joyent","id":10161,"avatar_url":"https://avatars.githubusercontent.com/u/10161?v=2","gravatar_id":"","url":"https://api.github.com/users/joyent","html_url":"https://github.com/joyent","followers_url":"https://api.github.com/users/joyent/followers","following_url":"https://api.github.com/users/joyent/following{/other_user}","gists_url":"https://api.github.com/users/joyent/gists{/gist_id}","starred_url":"https://api.github.com/users/joyent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joyent/subscriptions","organizations_url":"https://api.github.com/users/joyent/orgs","repos_url":"https://api.github.com/users/joyent/repos","events_url":"https://api.github.com/users/joyent/events{/privacy}","received_events_url":"https://api.github.com/users/joyent/received_events","type":"Organization","site_admin":false},"repo":{"id":1543431,"name":"libuv","full_name":"joyent/libuv","owner":{"login":"joyent","id":10161,"avatar_url":"https://avatars.githubusercontent.com/u/10161?v=2","gravatar_id":"","url":"https://api.github.com/users/joyent","html_url":"https://github.com/joyent","followers_url":"https://api.github.com/users/joyent/followers","following_url":"https://api.github.com/users/joyent/following{/other_user}","gists_url":"https://api.github.com/users/joyent/gists{/gist_id}","starred_url":"https://api.github.com/users/joyent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joyent/subscriptions","organizations_url":"https://api.github.com/users/joyent/orgs","repos_url":"https://api.github.com/users/joyent/repos","events_url":"https://api.github.com/users/joyent/events{/privacy}","received_events_url":"https://api.github.com/users/joyent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joyent/libuv","description":"Cross-platform asychronous I/O","fork":false,"url":"https://api.github.com/repos/joyent/libuv","forks_url":"https://api.github.com/repos/joyent/libuv/forks","keys_url":"https://api.github.com/repos/joyent/libuv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joyent/libuv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joyent/libuv/teams","hooks_url":"https://api.github.com/repos/joyent/libuv/hooks","issue_events_url":"https://api.github.com/repos/joyent/libuv/issues/events{/number}","events_url":"https://api.github.com/repos/joyent/libuv/events","assignees_url":"https://api.github.com/repos/joyent/libuv/assignees{/user}","branches_url":"https://api.github.com/repos/joyent/libuv/branches{/branch}","tags_url":"https://api.github.com/repos/joyent/libuv/tags","blobs_url":"https://api.github.com/repos/joyent/libuv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joyent/libuv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joyent/libuv/git/refs{/sha}","trees_url":"https://api.github.com/repos/joyent/libuv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joyent/libuv/statuses/{sha}","languages_url":"https://api.github.com/repos/joyent/libuv/languages","stargazers_url":"https://api.github.com/repos/joyent/libuv/stargazers","contributors_url":"https://api.github.com/repos/joyent/libuv/contributors","subscribers_url":"https://api.github.com/repos/joyent/libuv/subscribers","subscription_url":"https://api.github.com/repos/joyent/libuv/subscription","commits_url":"https://api.github.com/repos/joyent/libuv/commits{/sha}","git_commits_url":"https://api.github.com/repos/joyent/libuv/git/commits{/sha}","comments_url":"https://api.github.com/repos/joyent/libuv/comments{/number}","issue_comment_url":"https://api.github.com/repos/joyent/libuv/issues/comments/{number}","contents_url":"https://api.github.com/repos/joyent/libuv/contents/{+path}","compare_url":"https://api.github.com/repos/joyent/libuv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joyent/libuv/merges","archive_url":"https://api.github.com/repos/joyent/libuv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joyent/libuv/downloads","issues_url":"https://api.github.com/repos/joyent/libuv/issues{/number}","pulls_url":"https://api.github.com/repos/joyent/libuv/pulls{/number}","milestones_url":"https://api.github.com/repos/joyent/libuv/milestones{/number}","notifications_url":"https://api.github.com/repos/joyent/libuv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joyent/libuv/labels{/name}","releases_url":"https://api.github.com/repos/joyent/libuv/releases{/id}","created_at":"2011-03-29T21:10:45Z","updated_at":"2014-09-24T19:36:09Z","pushed_at":"2014-09-23T17:53:19Z","git_url":"git://github.com/joyent/libuv.git","ssh_url":"git@github.com:joyent/libuv.git","clone_url":"https://github.com/joyent/libuv.git","svn_url":"https://github.com/joyent/libuv","homepage":"http://libuv.org/","size":30230,"stargazers_count":3238,"watchers_count":3238,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":706,"mirror_url":null,"open_issues_count":125,"forks":706,"open_issues":125,"watchers":3238,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/joyent/libuv/pulls/1487"},"html":{"href":"https://github.com/joyent/libuv/pull/1487"},"issue":{"href":"https://api.github.com/repos/joyent/libuv/issues/1487"},"comments":{"href":"https://api.github.com/repos/joyent/libuv/issues/1487/comments"},"review_comments":{"href":"https://api.github.com/repos/joyent/libuv/pulls/1487/comments"},"review_comment":{"href":"https://api.github.com/repos/joyent/libuv/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/joyent/libuv/pulls/1487/commits"},"statuses":{"href":"https://api.github.com/repos/joyent/libuv/statuses/e7b3e71c862025f15eb72ec2cd483531b589c1e3"}}}}