GitHub PullRequestReviewCommentEvent at 2014-11-26 17:25:54
Repository: gaia
Actor: bebef1987
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/20949750","id":20949750,"diff_hunk":"@@ -0,0 +1,40 @@\n+# This Source Code Form is subject to the terms of the Mozilla Public\n+# License, v. 2.0. If a copy of the MPL was not distributed with this\n+# file, You can obtain one at http://mozilla.org/MPL/2.0/.\n+\n+from gaiatest import GaiaTestCase\n+from gaiatest.apps.gallery.app import Gallery\n+from marionette import Wait\n+\n+class TestGalleryHandleValidPhoto(GaiaTestCase):\n+\n+    def setUp(self):\n+        GaiaTestCase.setUp(self)\n+\n+        # the test files are copied from https://github.com/mozilla-b2g/gaia/tree/master/apps/gallery/test/images\n+        # below images will display in the gallery app\n+\n+        self.push_resource('image_formats/02.png') #png image\n+\n+    def test_gallery_open_png(self):\n+        gallery = Gallery(self.marionette)\n+        gallery.launch()\n+        gallery.wait_for_files_to_load(1)  # all and only valid files are showing previews\n+        self.assertTrue(gallery.gallery_items_number == 1)\n+\n+        # make sure the file opens\n+        image = gallery.tap_first_gallery_item()\n+\n+        # collect the initial image view dimension for comparison later\n+        initial_width = image.current_image_size_width\n+        initial_height = image.current_image_size_height\n+\n+        # check the blob exists\n+        self.assertTrue(\"blob:app://gallery.gaiamobile.org/\" in image.current_image_source)\n+        image.double_tap_image()  # double tapping zooms the image to its original resolution, or doubles the size\n+\n+        # verify the dimension of the displayed view is matching the original image size\n+        # this image size is 800 * 1200, and for these big images, the gallery app only doubles the view size,\n+        # it does not render the entire image fully\n+        Wait(self.marionette).until(lambda m: image.current_image_size_width == 2 * initial_width)\n+        self.assertTrue(image.current_image_size_height == 2 * initial_height)","path":"tests/python/gaia-ui-tests/gaiatest/tests/functional/gallery/test_gallery_handle_valid_file_png.py","position":40,"original_position":40,"commit_id":"7113a9ab3b0e1da2712d6e727a6b3c0429677816","original_commit_id":"7113a9ab3b0e1da2712d6e727a6b3c0429677816","user":{"login":"bebef1987","id":703611,"avatar_url":"https://avatars.githubusercontent.com/u/703611?v=3","gravatar_id":"","url":"https://api.github.com/users/bebef1987","html_url":"https://github.com/bebef1987","followers_url":"https://api.github.com/users/bebef1987/followers","following_url":"https://api.github.com/users/bebef1987/following{/other_user}","gists_url":"https://api.github.com/users/bebef1987/gists{/gist_id}","starred_url":"https://api.github.com/users/bebef1987/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bebef1987/subscriptions","organizations_url":"https://api.github.com/users/bebef1987/orgs","repos_url":"https://api.github.com/users/bebef1987/repos","events_url":"https://api.github.com/users/bebef1987/events{/privacy}","received_events_url":"https://api.github.com/users/bebef1987/received_events","type":"User","site_admin":false},"body":"new line","created_at":"2014-11-26T17:25:54Z","updated_at":"2014-11-26T17:25:54Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/25861#discussion_r20949750","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/25861","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/20949750"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/25861#discussion_r20949750"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/25861"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/25861","id":23952612,"html_url":"https://github.com/mozilla-b2g/gaia/pull/25861","diff_url":"https://github.com/mozilla-b2g/gaia/pull/25861.diff","patch_url":"https://github.com/mozilla-b2g/gaia/pull/25861.patch","issue_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/25861","number":25861,"state":"open","locked":false,"title":"1093874 2nd attempt","user":{"login":"npark-mozilla","id":6930774,"avatar_url":"https://avatars.githubusercontent.com/u/6930774?v=3","gravatar_id":"","url":"https://api.github.com/users/npark-mozilla","html_url":"https://github.com/npark-mozilla","followers_url":"https://api.github.com/users/npark-mozilla/followers","following_url":"https://api.github.com/users/npark-mozilla/following{/other_user}","gists_url":"https://api.github.com/users/npark-mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/npark-mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/npark-mozilla/subscriptions","organizations_url":"https://api.github.com/users/npark-mozilla/orgs","repos_url":"https://api.github.com/users/npark-mozilla/repos","events_url":"https://api.github.com/users/npark-mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/npark-mozilla/received_events","type":"User","site_admin":false},"body":"New pull request created for Bug 1093874, reverting dummy filechange commit","created_at":"2014-11-06T01:19:51Z","updated_at":"2014-11-26T17:25:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f1f3030f8c0126a300561d8cea3e86a56564f1ce","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/25861/commits","review_comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/25861/comments","review_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/25861/comments","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/7113a9ab3b0e1da2712d6e727a6b3c0429677816","head":{"label":"npark-mozilla:1093874_2ndAttempt","ref":"1093874_2ndAttempt","sha":"7113a9ab3b0e1da2712d6e727a6b3c0429677816","user":{"login":"npark-mozilla","id":6930774,"avatar_url":"https://avatars.githubusercontent.com/u/6930774?v=3","gravatar_id":"","url":"https://api.github.com/users/npark-mozilla","html_url":"https://github.com/npark-mozilla","followers_url":"https://api.github.com/users/npark-mozilla/followers","following_url":"https://api.github.com/users/npark-mozilla/following{/other_user}","gists_url":"https://api.github.com/users/npark-mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/npark-mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/npark-mozilla/subscriptions","organizations_url":"https://api.github.com/users/npark-mozilla/orgs","repos_url":"https://api.github.com/users/npark-mozilla/repos","events_url":"https://api.github.com/users/npark-mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/npark-mozilla/received_events","type":"User","site_admin":false},"repo":{"id":18301296,"name":"gaia","full_name":"npark-mozilla/gaia","owner":{"login":"npark-mozilla","id":6930774,"avatar_url":"https://avatars.githubusercontent.com/u/6930774?v=3","gravatar_id":"","url":"https://api.github.com/users/npark-mozilla","html_url":"https://github.com/npark-mozilla","followers_url":"https://api.github.com/users/npark-mozilla/followers","following_url":"https://api.github.com/users/npark-mozilla/following{/other_user}","gists_url":"https://api.github.com/users/npark-mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/npark-mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/npark-mozilla/subscriptions","organizations_url":"https://api.github.com/users/npark-mozilla/orgs","repos_url":"https://api.github.com/users/npark-mozilla/repos","events_url":"https://api.github.com/users/npark-mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/npark-mozilla/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/npark-mozilla/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see https://wiki.mozilla.org/Release_Management/B2G_Landing","fork":true,"url":"https://api.github.com/repos/npark-mozilla/gaia","forks_url":"https://api.github.com/repos/npark-mozilla/gaia/forks","keys_url":"https://api.github.com/repos/npark-mozilla/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/npark-mozilla/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/npark-mozilla/gaia/teams","hooks_url":"https://api.github.com/repos/npark-mozilla/gaia/hooks","issue_events_url":"https://api.github.com/repos/npark-mozilla/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/npark-mozilla/gaia/events","assignees_url":"https://api.github.com/repos/npark-mozilla/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/npark-mozilla/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/npark-mozilla/gaia/tags","blobs_url":"https://api.github.com/repos/npark-mozilla/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/npark-mozilla/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/npark-mozilla/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/npark-mozilla/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/npark-mozilla/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/npark-mozilla/gaia/languages","stargazers_url":"https://api.github.com/repos/npark-mozilla/gaia/stargazers","contributors_url":"https://api.github.com/repos/npark-mozilla/gaia/contributors","subscribers_url":"https://api.github.com/repos/npark-mozilla/gaia/subscribers","subscription_url":"https://api.github.com/repos/npark-mozilla/gaia/subscription","commits_url":"https://api.github.com/repos/npark-mozilla/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/npark-mozilla/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/npark-mozilla/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/npark-mozilla/gaia/issues/comments/{number}","contents_url":"https://api.github.com/repos/npark-mozilla/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/npark-mozilla/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/npark-mozilla/gaia/merges","archive_url":"https://api.github.com/repos/npark-mozilla/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/npark-mozilla/gaia/downloads","issues_url":"https://api.github.com/repos/npark-mozilla/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/npark-mozilla/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/npark-mozilla/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/npark-mozilla/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/npark-mozilla/gaia/labels{/name}","releases_url":"https://api.github.com/repos/npark-mozilla/gaia/releases{/id}","created_at":"2014-03-31T17:15:03Z","updated_at":"2014-11-18T18:39:58Z","pushed_at":"2014-11-18T20:09:30Z","git_url":"git://github.com/npark-mozilla/gaia.git","ssh_url":"git@github.com:npark-mozilla/gaia.git","clone_url":"https://github.com/npark-mozilla/gaia.git","svn_url":"https://github.com/npark-mozilla/gaia","homepage":"https://wiki.mozilla.org/B2G","size":862886,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-b2g:master","ref":"master","sha":"e92c982c75cfb9800e26f8a6672678b5b35f097e","user":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"repo":{"id":2317369,"name":"gaia","full_name":"mozilla-b2g/gaia","owner":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-b2g/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see","fork":false,"url":"https://api.github.com/repos/mozilla-b2g/gaia","forks_url":"https://api.github.com/repos/mozilla-b2g/gaia/forks","keys_url":"https://api.github.com/repos/mozilla-b2g/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-b2g/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-b2g/gaia/teams","hooks_url":"https://api.github.com/repos/mozilla-b2g/gaia/hooks","issue_events_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-b2g/gaia/events","assignees_url":"https://api.github.com/repos/mozilla-b2g/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-b2g/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/tags","blobs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-b2g/gaia/languages","stargazers_url":"https://api.github.com/repos/mozilla-b2g/gaia/stargazers","contributors_url":"https://api.github.com/repos/mozilla-b2g/gaia/contributors","subscribers_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscribers","subscription_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscription","commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla-b2g/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-b2g/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-b2g/gaia/merges","archive_url":"https://api.github.com/repos/mozilla-b2g/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-b2g/gaia/downloads","issues_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-b2g/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-b2g/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-b2g/gaia/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-b2g/gaia/releases{/id}","created_at":"2011-09-03T01:38:46Z","updated_at":"2014-11-26T15:35:57Z","pushed_at":"2014-11-26T15:35:57Z","git_url":"git://github.com/mozilla-b2g/gaia.git","ssh_url":"git@github.com:mozilla-b2g/gaia.git","clone_url":"https://github.com/mozilla-b2g/gaia.git","svn_url":"https://github.com/mozilla-b2g/gaia","homepage":"https://wiki.mozilla.org/B2G","size":1550940,"stargazers_count":1814,"watchers_count":1814,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2078,"mirror_url":null,"open_issues_count":704,"forks":2078,"open_issues":704,"watchers":1814,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/25861"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/25861"},"issue":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/25861"},"comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/25861/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/25861/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/25861/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/7113a9ab3b0e1da2712d6e727a6b3c0429677816"}}}}