GitHub PullRequestReviewCommentEvent at 2014-08-12 14:00:23
Repository: harbinger
Actor: houndci
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/ndlib/harbinger/pulls/comments/16114175","id":16114175,"diff_hunk":"@@ -0,0 +1,25 @@\n+require 'spec_view_helper'\n+\n+# As of 3.0.x :type tags are no longer inferred.\n+# This means, without the `type: :view` tag, the render method does not exist\n+# in the example context\n+describe 'harbinger/messages/index.html.erb', type: :view do\n+  let(:created_at) { Time.now }\n+  let(:messages) do\n+    double(\n+      'Message',\n+      contexts: ['Hello','World'],\n+      state: 'new',\n+      created_at: created_at\n+    )\n+  end\n+  it 'renders the object and fieldsets' do\n+    render template: \"harbinger/messages/index.html.erb\", locals: { messages: [messages] }\n+    expect(rendered).to have_tag('.message') do\n+      with_tag('.detail.message-contexts-detail', text: 'Hello')","path":"spec/views/harbinger/messages/index.html.erb_spec.rb","position":19,"original_position":19,"commit_id":"73ec8cc1506efc2c6b6e969ca8e1d936c5ad4367","original_commit_id":"73ec8cc1506efc2c6b6e969ca8e1d936c5ad4367","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=2","gravatar_id":"38d9cefd9971a05bf447f07c6cd332cc","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.","created_at":"2014-08-12T14:00:23Z","updated_at":"2014-08-12T14:00:23Z","html_url":"https://github.com/ndlib/harbinger/pull/1#discussion_r16114175","pull_request_url":"https://api.github.com/repos/ndlib/harbinger/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/ndlib/harbinger/pulls/comments/16114175"},"html":{"href":"https://github.com/ndlib/harbinger/pull/1#discussion_r16114175"},"pull_request":{"href":"https://api.github.com/repos/ndlib/harbinger/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/ndlib/harbinger/pulls/1","id":19662995,"html_url":"https://github.com/ndlib/harbinger/pull/1","diff_url":"https://github.com/ndlib/harbinger/pull/1.diff","patch_url":"https://github.com/ndlib/harbinger/pull/1.patch","issue_url":"https://api.github.com/repos/ndlib/harbinger/issues/1","number":1,"state":"open","title":"Adding end to end exception handling","user":{"login":"jeremyf","id":2130,"avatar_url":"https://avatars.githubusercontent.com/u/2130?v=2","gravatar_id":"a9b7461edb06ce10e12f865220e43948","url":"https://api.github.com/users/jeremyf","html_url":"https://github.com/jeremyf","followers_url":"https://api.github.com/users/jeremyf/followers","following_url":"https://api.github.com/users/jeremyf/following{/other_user}","gists_url":"https://api.github.com/users/jeremyf/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremyf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremyf/subscriptions","organizations_url":"https://api.github.com/users/jeremyf/orgs","repos_url":"https://api.github.com/users/jeremyf/repos","events_url":"https://api.github.com/users/jeremyf/events{/privacy}","received_events_url":"https://api.github.com/users/jeremyf/received_events","type":"User","site_admin":false},"body":"This is a major step towards improving CurateND's exception handling.\r\n\r\nIt is comprised of many commits because this was my work towards a verifying feature test.\r\n\r\nDLTP-123","created_at":"2014-08-12T14:00:02Z","updated_at":"2014-08-12T14:00:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3d1a14bd2423cdeeced14a743781517112d0b456","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ndlib/harbinger/pulls/1/commits","review_comments_url":"https://api.github.com/repos/ndlib/harbinger/pulls/1/comments","review_comment_url":"https://api.github.com/repos/ndlib/harbinger/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ndlib/harbinger/issues/1/comments","statuses_url":"https://api.github.com/repos/ndlib/harbinger/statuses/73ec8cc1506efc2c6b6e969ca8e1d936c5ad4367","head":{"label":"jeremyf:dltp-123-exception-handling","ref":"dltp-123-exception-handling","sha":"73ec8cc1506efc2c6b6e969ca8e1d936c5ad4367","user":{"login":"jeremyf","id":2130,"avatar_url":"https://avatars.githubusercontent.com/u/2130?v=2","gravatar_id":"a9b7461edb06ce10e12f865220e43948","url":"https://api.github.com/users/jeremyf","html_url":"https://github.com/jeremyf","followers_url":"https://api.github.com/users/jeremyf/followers","following_url":"https://api.github.com/users/jeremyf/following{/other_user}","gists_url":"https://api.github.com/users/jeremyf/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremyf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremyf/subscriptions","organizations_url":"https://api.github.com/users/jeremyf/orgs","repos_url":"https://api.github.com/users/jeremyf/repos","events_url":"https://api.github.com/users/jeremyf/events{/privacy}","received_events_url":"https://api.github.com/users/jeremyf/received_events","type":"User","site_admin":false},"repo":{"id":19614325,"name":"harbinger","full_name":"jeremyf/harbinger","owner":{"login":"jeremyf","id":2130,"avatar_url":"https://avatars.githubusercontent.com/u/2130?v=2","gravatar_id":"a9b7461edb06ce10e12f865220e43948","url":"https://api.github.com/users/jeremyf","html_url":"https://github.com/jeremyf","followers_url":"https://api.github.com/users/jeremyf/followers","following_url":"https://api.github.com/users/jeremyf/following{/other_user}","gists_url":"https://api.github.com/users/jeremyf/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremyf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremyf/subscriptions","organizations_url":"https://api.github.com/users/jeremyf/orgs","repos_url":"https://api.github.com/users/jeremyf/repos","events_url":"https://api.github.com/users/jeremyf/events{/privacy}","received_events_url":"https://api.github.com/users/jeremyf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jeremyf/harbinger","description":"A Rails engine for arbitrary message creation and delivery.","fork":true,"url":"https://api.github.com/repos/jeremyf/harbinger","forks_url":"https://api.github.com/repos/jeremyf/harbinger/forks","keys_url":"https://api.github.com/repos/jeremyf/harbinger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeremyf/harbinger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeremyf/harbinger/teams","hooks_url":"https://api.github.com/repos/jeremyf/harbinger/hooks","issue_events_url":"https://api.github.com/repos/jeremyf/harbinger/issues/events{/number}","events_url":"https://api.github.com/repos/jeremyf/harbinger/events","assignees_url":"https://api.github.com/repos/jeremyf/harbinger/assignees{/user}","branches_url":"https://api.github.com/repos/jeremyf/harbinger/branches{/branch}","tags_url":"https://api.github.com/repos/jeremyf/harbinger/tags","blobs_url":"https://api.github.com/repos/jeremyf/harbinger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeremyf/harbinger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeremyf/harbinger/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeremyf/harbinger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeremyf/harbinger/statuses/{sha}","languages_url":"https://api.github.com/repos/jeremyf/harbinger/languages","stargazers_url":"https://api.github.com/repos/jeremyf/harbinger/stargazers","contributors_url":"https://api.github.com/repos/jeremyf/harbinger/contributors","subscribers_url":"https://api.github.com/repos/jeremyf/harbinger/subscribers","subscription_url":"https://api.github.com/repos/jeremyf/harbinger/subscription","commits_url":"https://api.github.com/repos/jeremyf/harbinger/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeremyf/harbinger/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeremyf/harbinger/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeremyf/harbinger/issues/comments/{number}","contents_url":"https://api.github.com/repos/jeremyf/harbinger/contents/{+path}","compare_url":"https://api.github.com/repos/jeremyf/harbinger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeremyf/harbinger/merges","archive_url":"https://api.github.com/repos/jeremyf/harbinger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeremyf/harbinger/downloads","issues_url":"https://api.github.com/repos/jeremyf/harbinger/issues{/number}","pulls_url":"https://api.github.com/repos/jeremyf/harbinger/pulls{/number}","milestones_url":"https://api.github.com/repos/jeremyf/harbinger/milestones{/number}","notifications_url":"https://api.github.com/repos/jeremyf/harbinger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeremyf/harbinger/labels{/name}","releases_url":"https://api.github.com/repos/jeremyf/harbinger/releases{/id}","created_at":"2014-05-09T14:41:13Z","updated_at":"2014-07-17T14:09:44Z","pushed_at":"2014-08-12T13:58:20Z","git_url":"git://github.com/jeremyf/harbinger.git","ssh_url":"git@github.com:jeremyf/harbinger.git","clone_url":"https://github.com/jeremyf/harbinger.git","svn_url":"https://github.com/jeremyf/harbinger","homepage":"https://github.com/jeremyf/harbinger","size":216,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ndlib:master","ref":"master","sha":"aad2413b5db320691db0af2af65eceaa84c8fd69","user":{"login":"ndlib","id":160943,"avatar_url":"https://avatars.githubusercontent.com/u/160943?v=2","gravatar_id":"7e34c7b4e592ba6e5f4dd3fd7e754b64","url":"https://api.github.com/users/ndlib","html_url":"https://github.com/ndlib","followers_url":"https://api.github.com/users/ndlib/followers","following_url":"https://api.github.com/users/ndlib/following{/other_user}","gists_url":"https://api.github.com/users/ndlib/gists{/gist_id}","starred_url":"https://api.github.com/users/ndlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndlib/subscriptions","organizations_url":"https://api.github.com/users/ndlib/orgs","repos_url":"https://api.github.com/users/ndlib/repos","events_url":"https://api.github.com/users/ndlib/events{/privacy}","received_events_url":"https://api.github.com/users/ndlib/received_events","type":"Organization","site_admin":false},"repo":{"id":17233367,"name":"harbinger","full_name":"ndlib/harbinger","owner":{"login":"ndlib","id":160943,"avatar_url":"https://avatars.githubusercontent.com/u/160943?v=2","gravatar_id":"7e34c7b4e592ba6e5f4dd3fd7e754b64","url":"https://api.github.com/users/ndlib","html_url":"https://github.com/ndlib","followers_url":"https://api.github.com/users/ndlib/followers","following_url":"https://api.github.com/users/ndlib/following{/other_user}","gists_url":"https://api.github.com/users/ndlib/gists{/gist_id}","starred_url":"https://api.github.com/users/ndlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndlib/subscriptions","organizations_url":"https://api.github.com/users/ndlib/orgs","repos_url":"https://api.github.com/users/ndlib/repos","events_url":"https://api.github.com/users/ndlib/events{/privacy}","received_events_url":"https://api.github.com/users/ndlib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ndlib/harbinger","description":"A Rails engine for arbitrary message creation and delivery.","fork":false,"url":"https://api.github.com/repos/ndlib/harbinger","forks_url":"https://api.github.com/repos/ndlib/harbinger/forks","keys_url":"https://api.github.com/repos/ndlib/harbinger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ndlib/harbinger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ndlib/harbinger/teams","hooks_url":"https://api.github.com/repos/ndlib/harbinger/hooks","issue_events_url":"https://api.github.com/repos/ndlib/harbinger/issues/events{/number}","events_url":"https://api.github.com/repos/ndlib/harbinger/events","assignees_url":"https://api.github.com/repos/ndlib/harbinger/assignees{/user}","branches_url":"https://api.github.com/repos/ndlib/harbinger/branches{/branch}","tags_url":"https://api.github.com/repos/ndlib/harbinger/tags","blobs_url":"https://api.github.com/repos/ndlib/harbinger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ndlib/harbinger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ndlib/harbinger/git/refs{/sha}","trees_url":"https://api.github.com/repos/ndlib/harbinger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ndlib/harbinger/statuses/{sha}","languages_url":"https://api.github.com/repos/ndlib/harbinger/languages","stargazers_url":"https://api.github.com/repos/ndlib/harbinger/stargazers","contributors_url":"https://api.github.com/repos/ndlib/harbinger/contributors","subscribers_url":"https://api.github.com/repos/ndlib/harbinger/subscribers","subscription_url":"https://api.github.com/repos/ndlib/harbinger/subscription","commits_url":"https://api.github.com/repos/ndlib/harbinger/commits{/sha}","git_commits_url":"https://api.github.com/repos/ndlib/harbinger/git/commits{/sha}","comments_url":"https://api.github.com/repos/ndlib/harbinger/comments{/number}","issue_comment_url":"https://api.github.com/repos/ndlib/harbinger/issues/comments/{number}","contents_url":"https://api.github.com/repos/ndlib/harbinger/contents/{+path}","compare_url":"https://api.github.com/repos/ndlib/harbinger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ndlib/harbinger/merges","archive_url":"https://api.github.com/repos/ndlib/harbinger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ndlib/harbinger/downloads","issues_url":"https://api.github.com/repos/ndlib/harbinger/issues{/number}","pulls_url":"https://api.github.com/repos/ndlib/harbinger/pulls{/number}","milestones_url":"https://api.github.com/repos/ndlib/harbinger/milestones{/number}","notifications_url":"https://api.github.com/repos/ndlib/harbinger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ndlib/harbinger/labels{/name}","releases_url":"https://api.github.com/repos/ndlib/harbinger/releases{/id}","created_at":"2014-02-27T02:15:12Z","updated_at":"2014-07-17T12:50:56Z","pushed_at":"2014-08-04T18:09:54Z","git_url":"git://github.com/ndlib/harbinger.git","ssh_url":"git@github.com:ndlib/harbinger.git","clone_url":"https://github.com/ndlib/harbinger.git","svn_url":"https://github.com/ndlib/harbinger","homepage":"https://github.com/ndlib/harbinger","size":302,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ndlib/harbinger/pulls/1"},"html":{"href":"https://github.com/ndlib/harbinger/pull/1"},"issue":{"href":"https://api.github.com/repos/ndlib/harbinger/issues/1"},"comments":{"href":"https://api.github.com/repos/ndlib/harbinger/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/ndlib/harbinger/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/ndlib/harbinger/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ndlib/harbinger/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/ndlib/harbinger/statuses/73ec8cc1506efc2c6b6e969ca8e1d936c5ad4367"}}}}