GitHub PullRequestReviewCommentEvent at 2014-07-23 01:58:01
Repository: zotero
Actor: aurimasv
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/zotero/zotero/pulls/comments/15268074","id":15268074,"diff_hunk":"@@ -3032,20 +3032,9 @@ var ZoteroPane = new function()\n \t\t\tthis.displayCannotEditLibraryMessage();\n \t\t\treturn;\n \t\t}\n-\t\tvar ps = Components.classes[\"@mozilla.org/embedcomp/prompt-service;1\"]\n-\t\t\t\t\t.getService(Components.interfaces.nsIPromptService);\n-\t\t\n-\t\tvar input = {};\n-\t\tvar check = {value : false};\n-\t\t\n-\t\t// TODO: Allow title to be specified?\n-\t\tvar result = ps.prompt(null, Zotero.getString('pane.items.attach.link.uri.title'),\n-\t\t\tZotero.getString('pane.items.attach.link.uri'), input, \"\", {});\n-\t\tif (!result || !input.value) return false;\n-\t\t\n-\t\t// Create a new attachment\n-\t\tZotero.Attachments.linkFromURL(input.value, itemID);\n-\t}\n+\t\tvar io = { itemID: itemID };\n+\t\twindow.openDialog('chrome://zotero/content/attachLink.xul', 'zotero-attach-uri-dialog', 'centerscreen, resizable', io);","path":"chrome/content/zotero/zoteroPane.js","position":19,"original_position":19,"commit_id":"c6d234af0965d2032127d07262e2172cff724d5a","original_commit_id":"c6d234af0965d2032127d07262e2172cff724d5a","user":{"login":"aurimasv","id":1381759,"avatar_url":"https://avatars.githubusercontent.com/u/1381759?","gravatar_id":"c570d2ae788556be8837f9a858f5f887","url":"https://api.github.com/users/aurimasv","html_url":"https://github.com/aurimasv","followers_url":"https://api.github.com/users/aurimasv/followers","following_url":"https://api.github.com/users/aurimasv/following{/other_user}","gists_url":"https://api.github.com/users/aurimasv/gists{/gist_id}","starred_url":"https://api.github.com/users/aurimasv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aurimasv/subscriptions","organizations_url":"https://api.github.com/users/aurimasv/orgs","repos_url":"https://api.github.com/users/aurimasv/repos","events_url":"https://api.github.com/users/aurimasv/events{/privacy}","received_events_url":"https://api.github.com/users/aurimasv/received_events","type":"User","site_admin":false},"body":"Also not sure if it needs to be resizable.","created_at":"2014-07-23T01:58:01Z","updated_at":"2014-07-23T01:58:01Z","html_url":"https://github.com/zotero/zotero/pull/510#discussion_r15268074","pull_request_url":"https://api.github.com/repos/zotero/zotero/pulls/510","_links":{"self":{"href":"https://api.github.com/repos/zotero/zotero/pulls/comments/15268074"},"html":{"href":"https://github.com/zotero/zotero/pull/510#discussion_r15268074"},"pull_request":{"href":"https://api.github.com/repos/zotero/zotero/pulls/510"}}},"pull_request":{"url":"https://api.github.com/repos/zotero/zotero/pulls/510","id":18234525,"html_url":"https://github.com/zotero/zotero/pull/510","diff_url":"https://github.com/zotero/zotero/pull/510.diff","patch_url":"https://github.com/zotero/zotero/pull/510.patch","issue_url":"https://api.github.com/repos/zotero/zotero/issues/510","number":510,"state":"open","title":"Link URI re: issue 486","user":{"login":"mtd91429","id":3360192,"avatar_url":"https://avatars.githubusercontent.com/u/3360192?","gravatar_id":"220cbac98c7a3172fca4e24a24141397","url":"https://api.github.com/users/mtd91429","html_url":"https://github.com/mtd91429","followers_url":"https://api.github.com/users/mtd91429/followers","following_url":"https://api.github.com/users/mtd91429/following{/other_user}","gists_url":"https://api.github.com/users/mtd91429/gists{/gist_id}","starred_url":"https://api.github.com/users/mtd91429/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtd91429/subscriptions","organizations_url":"https://api.github.com/users/mtd91429/orgs","repos_url":"https://api.github.com/users/mtd91429/repos","events_url":"https://api.github.com/users/mtd91429/events{/privacy}","received_events_url":"https://api.github.com/users/mtd91429/received_events","type":"User","site_admin":false},"body":"The proposed changes address the silent failing of adding a link to an unrecognized URI. They allow the user to correct any potential mistakes made to the initial address through a prompt dialogue. ","created_at":"2014-07-10T17:40:16Z","updated_at":"2014-07-23T01:58:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7cfbaa8342fa8d5345839ab388f1010b9561f30c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zotero/zotero/pulls/510/commits","review_comments_url":"https://api.github.com/repos/zotero/zotero/pulls/510/comments","review_comment_url":"https://api.github.com/repos/zotero/zotero/pulls/comments/{number}","comments_url":"https://api.github.com/repos/zotero/zotero/issues/510/comments","statuses_url":"https://api.github.com/repos/zotero/zotero/statuses/c6d234af0965d2032127d07262e2172cff724d5a","head":{"label":"mtd91429:linkURI","ref":"linkURI","sha":"c6d234af0965d2032127d07262e2172cff724d5a","user":{"login":"mtd91429","id":3360192,"avatar_url":"https://avatars.githubusercontent.com/u/3360192?","gravatar_id":"220cbac98c7a3172fca4e24a24141397","url":"https://api.github.com/users/mtd91429","html_url":"https://github.com/mtd91429","followers_url":"https://api.github.com/users/mtd91429/followers","following_url":"https://api.github.com/users/mtd91429/following{/other_user}","gists_url":"https://api.github.com/users/mtd91429/gists{/gist_id}","starred_url":"https://api.github.com/users/mtd91429/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtd91429/subscriptions","organizations_url":"https://api.github.com/users/mtd91429/orgs","repos_url":"https://api.github.com/users/mtd91429/repos","events_url":"https://api.github.com/users/mtd91429/events{/privacy}","received_events_url":"https://api.github.com/users/mtd91429/received_events","type":"User","site_admin":false},"repo":{"id":21615136,"name":"zotero","full_name":"mtd91429/zotero","owner":{"login":"mtd91429","id":3360192,"avatar_url":"https://avatars.githubusercontent.com/u/3360192?","gravatar_id":"220cbac98c7a3172fca4e24a24141397","url":"https://api.github.com/users/mtd91429","html_url":"https://github.com/mtd91429","followers_url":"https://api.github.com/users/mtd91429/followers","following_url":"https://api.github.com/users/mtd91429/following{/other_user}","gists_url":"https://api.github.com/users/mtd91429/gists{/gist_id}","starred_url":"https://api.github.com/users/mtd91429/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtd91429/subscriptions","organizations_url":"https://api.github.com/users/mtd91429/orgs","repos_url":"https://api.github.com/users/mtd91429/repos","events_url":"https://api.github.com/users/mtd91429/events{/privacy}","received_events_url":"https://api.github.com/users/mtd91429/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mtd91429/zotero","description":"Zotero is a free, easy-to-use tool to help you collect, organize, cite, and share your research sources.","fork":true,"url":"https://api.github.com/repos/mtd91429/zotero","forks_url":"https://api.github.com/repos/mtd91429/zotero/forks","keys_url":"https://api.github.com/repos/mtd91429/zotero/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mtd91429/zotero/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mtd91429/zotero/teams","hooks_url":"https://api.github.com/repos/mtd91429/zotero/hooks","issue_events_url":"https://api.github.com/repos/mtd91429/zotero/issues/events{/number}","events_url":"https://api.github.com/repos/mtd91429/zotero/events","assignees_url":"https://api.github.com/repos/mtd91429/zotero/assignees{/user}","branches_url":"https://api.github.com/repos/mtd91429/zotero/branches{/branch}","tags_url":"https://api.github.com/repos/mtd91429/zotero/tags","blobs_url":"https://api.github.com/repos/mtd91429/zotero/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mtd91429/zotero/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mtd91429/zotero/git/refs{/sha}","trees_url":"https://api.github.com/repos/mtd91429/zotero/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mtd91429/zotero/statuses/{sha}","languages_url":"https://api.github.com/repos/mtd91429/zotero/languages","stargazers_url":"https://api.github.com/repos/mtd91429/zotero/stargazers","contributors_url":"https://api.github.com/repos/mtd91429/zotero/contributors","subscribers_url":"https://api.github.com/repos/mtd91429/zotero/subscribers","subscription_url":"https://api.github.com/repos/mtd91429/zotero/subscription","commits_url":"https://api.github.com/repos/mtd91429/zotero/commits{/sha}","git_commits_url":"https://api.github.com/repos/mtd91429/zotero/git/commits{/sha}","comments_url":"https://api.github.com/repos/mtd91429/zotero/comments{/number}","issue_comment_url":"https://api.github.com/repos/mtd91429/zotero/issues/comments/{number}","contents_url":"https://api.github.com/repos/mtd91429/zotero/contents/{+path}","compare_url":"https://api.github.com/repos/mtd91429/zotero/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mtd91429/zotero/merges","archive_url":"https://api.github.com/repos/mtd91429/zotero/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mtd91429/zotero/downloads","issues_url":"https://api.github.com/repos/mtd91429/zotero/issues{/number}","pulls_url":"https://api.github.com/repos/mtd91429/zotero/pulls{/number}","milestones_url":"https://api.github.com/repos/mtd91429/zotero/milestones{/number}","notifications_url":"https://api.github.com/repos/mtd91429/zotero/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mtd91429/zotero/labels{/name}","releases_url":"https://api.github.com/repos/mtd91429/zotero/releases{/id}","created_at":"2014-07-08T14:10:54Z","updated_at":"2014-07-06T13:28:18Z","pushed_at":"2014-07-22T16:32:24Z","git_url":"git://github.com/mtd91429/zotero.git","ssh_url":"git@github.com:mtd91429/zotero.git","clone_url":"https://github.com/mtd91429/zotero.git","svn_url":"https://github.com/mtd91429/zotero","homepage":"https://www.zotero.org","size":44280,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"4.0"}},"base":{"label":"zotero:4.0","ref":"4.0","sha":"813f55d0244d06fb62b1808b3eae60f2332f732d","user":{"login":"zotero","id":891917,"avatar_url":"https://avatars.githubusercontent.com/u/891917?","gravatar_id":"2a81b0b0876b140003e66c6eb9b88ba9","url":"https://api.github.com/users/zotero","html_url":"https://github.com/zotero","followers_url":"https://api.github.com/users/zotero/followers","following_url":"https://api.github.com/users/zotero/following{/other_user}","gists_url":"https://api.github.com/users/zotero/gists{/gist_id}","starred_url":"https://api.github.com/users/zotero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zotero/subscriptions","organizations_url":"https://api.github.com/users/zotero/orgs","repos_url":"https://api.github.com/users/zotero/repos","events_url":"https://api.github.com/users/zotero/events{/privacy}","received_events_url":"https://api.github.com/users/zotero/received_events","type":"Organization","site_admin":false},"repo":{"id":2656556,"name":"zotero","full_name":"zotero/zotero","owner":{"login":"zotero","id":891917,"avatar_url":"https://avatars.githubusercontent.com/u/891917?","gravatar_id":"2a81b0b0876b140003e66c6eb9b88ba9","url":"https://api.github.com/users/zotero","html_url":"https://github.com/zotero","followers_url":"https://api.github.com/users/zotero/followers","following_url":"https://api.github.com/users/zotero/following{/other_user}","gists_url":"https://api.github.com/users/zotero/gists{/gist_id}","starred_url":"https://api.github.com/users/zotero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zotero/subscriptions","organizations_url":"https://api.github.com/users/zotero/orgs","repos_url":"https://api.github.com/users/zotero/repos","events_url":"https://api.github.com/users/zotero/events{/privacy}","received_events_url":"https://api.github.com/users/zotero/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zotero/zotero","description":"Zotero is a free, easy-to-use tool to help you collect, organize, cite, and share your research sources.","fork":false,"url":"https://api.github.com/repos/zotero/zotero","forks_url":"https://api.github.com/repos/zotero/zotero/forks","keys_url":"https://api.github.com/repos/zotero/zotero/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zotero/zotero/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zotero/zotero/teams","hooks_url":"https://api.github.com/repos/zotero/zotero/hooks","issue_events_url":"https://api.github.com/repos/zotero/zotero/issues/events{/number}","events_url":"https://api.github.com/repos/zotero/zotero/events","assignees_url":"https://api.github.com/repos/zotero/zotero/assignees{/user}","branches_url":"https://api.github.com/repos/zotero/zotero/branches{/branch}","tags_url":"https://api.github.com/repos/zotero/zotero/tags","blobs_url":"https://api.github.com/repos/zotero/zotero/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zotero/zotero/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zotero/zotero/git/refs{/sha}","trees_url":"https://api.github.com/repos/zotero/zotero/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zotero/zotero/statuses/{sha}","languages_url":"https://api.github.com/repos/zotero/zotero/languages","stargazers_url":"https://api.github.com/repos/zotero/zotero/stargazers","contributors_url":"https://api.github.com/repos/zotero/zotero/contributors","subscribers_url":"https://api.github.com/repos/zotero/zotero/subscribers","subscription_url":"https://api.github.com/repos/zotero/zotero/subscription","commits_url":"https://api.github.com/repos/zotero/zotero/commits{/sha}","git_commits_url":"https://api.github.com/repos/zotero/zotero/git/commits{/sha}","comments_url":"https://api.github.com/repos/zotero/zotero/comments{/number}","issue_comment_url":"https://api.github.com/repos/zotero/zotero/issues/comments/{number}","contents_url":"https://api.github.com/repos/zotero/zotero/contents/{+path}","compare_url":"https://api.github.com/repos/zotero/zotero/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zotero/zotero/merges","archive_url":"https://api.github.com/repos/zotero/zotero/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zotero/zotero/downloads","issues_url":"https://api.github.com/repos/zotero/zotero/issues{/number}","pulls_url":"https://api.github.com/repos/zotero/zotero/pulls{/number}","milestones_url":"https://api.github.com/repos/zotero/zotero/milestones{/number}","notifications_url":"https://api.github.com/repos/zotero/zotero/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zotero/zotero/labels{/name}","releases_url":"https://api.github.com/repos/zotero/zotero/releases{/id}","created_at":"2011-10-27T07:46:48Z","updated_at":"2014-07-22T08:29:42Z","pushed_at":"2014-07-20T19:58:56Z","git_url":"git://github.com/zotero/zotero.git","ssh_url":"git@github.com:zotero/zotero.git","clone_url":"https://github.com/zotero/zotero.git","svn_url":"https://github.com/zotero/zotero","homepage":"https://www.zotero.org","size":66837,"stargazers_count":198,"watchers_count":198,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":80,"mirror_url":null,"open_issues_count":203,"forks":80,"open_issues":203,"watchers":198,"default_branch":"4.0"}},"_links":{"self":{"href":"https://api.github.com/repos/zotero/zotero/pulls/510"},"html":{"href":"https://github.com/zotero/zotero/pull/510"},"issue":{"href":"https://api.github.com/repos/zotero/zotero/issues/510"},"comments":{"href":"https://api.github.com/repos/zotero/zotero/issues/510/comments"},"review_comments":{"href":"https://api.github.com/repos/zotero/zotero/pulls/510/comments"},"review_comment":{"href":"https://api.github.com/repos/zotero/zotero/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/zotero/zotero/pulls/510/commits"},"statuses":{"href":"https://api.github.com/repos/zotero/zotero/statuses/c6d234af0965d2032127d07262e2172cff724d5a"}}}}