GitHub PullRequestReviewCommentEvent at 2014-04-02 21:44:33
Repository: TextSecure
Actor: moxie0
Payload: {"comment":{"url":"https://api.github.com/repos/WhisperSystems/TextSecure/pulls/comments/11229586","id":11229586,"diff_hunk":"@@ -285,8 +285,13 @@ public void markAsForcedSms(long id) {\n     updateMailboxBitmask(id, 0, Types.MESSAGE_FORCE_SMS_BIT);\n   }\n \n-  public void markAsPendingApproval(long messageId) {\n-    updateMailboxBitmask(messageId, Types.BASE_TYPE_MASK, Types.BASE_PENDING_FALLBACK_APPROVAL);\n+  public void markAsPendingSecureFallback(long messageId) {\n+    updateMailboxBitmask(messageId, Types.BASE_TYPE_MASK, Types.BASE_PENDING_SECURE_FALLBACK);\n+    notifyConversationListeners(getThreadIdForMessage(messageId));\n+  }\n+\n+  public void markAsPendingDowngradeFallback(long messageId) {\n+    updateMailboxBitmask(messageId, Types.BASE_TYPE_MASK, Types.BASE_PENDING_DOWNGRADE_FALLBACK);\n     notifyConversationListeners(getThreadIdForMessage(messageId));\n   }","path":"src/org/thoughtcrime/securesms/database/MmsDatabase.java","position":14,"original_position":14,"commit_id":"da43c4bc9700546128cd5ad52a6731db374b1f95","original_commit_id":"ff0c47c072c5563f6b1f0476287f50c4f9381d8f","user":{"login":"moxie0","id":512439,"avatar_url":"https://avatars.githubusercontent.com/u/512439?","gravatar_id":"3039ee38b82701f3d0dd0fbb901a754f","url":"https://api.github.com/users/moxie0","html_url":"https://github.com/moxie0","followers_url":"https://api.github.com/users/moxie0/followers","following_url":"https://api.github.com/users/moxie0/following{/other_user}","gists_url":"https://api.github.com/users/moxie0/gists{/gist_id}","starred_url":"https://api.github.com/users/moxie0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moxie0/subscriptions","organizations_url":"https://api.github.com/users/moxie0/orgs","repos_url":"https://api.github.com/users/moxie0/repos","events_url":"https://api.github.com/users/moxie0/events{/privacy}","received_events_url":"https://api.github.com/users/moxie0/received_events","type":"User","site_admin":false},"body":"I'd also prefer it if 'downgrade' was replaced with 'insecure' in the equivalent higher level functions as well.  That way we have symmetry between secure and insecure everywhere.","created_at":"2014-04-02T21:44:33Z","updated_at":"2014-04-02T21:44:33Z","html_url":"https://github.com/WhisperSystems/TextSecure/pull/1282#discussion_r11229586","pull_request_url":"https://api.github.com/repos/WhisperSystems/TextSecure/pulls/1282","_links":{"self":{"href":"https://api.github.com/repos/WhisperSystems/TextSecure/pulls/comments/11229586"},"html":{"href":"https://github.com/WhisperSystems/TextSecure/pull/1282#discussion_r11229586"},"pull_request":{"href":"https://api.github.com/repos/WhisperSystems/TextSecure/pulls/1282"}}}}