GitHub PullRequestReviewCommentEvent at 2014-08-07 23:41:27
Repository: analytics.js-integrations
Actor: reinpk
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/segmentio/analytics.js-integrations/pulls/comments/15971342","id":15971342,"diff_hunk":"@@ -16,7 +16,7 @@ var Customerio = module.exports = integration('Customer.io')\n   .assumesPageview()\n   .global('_cio')\n   .option('siteId', '')\n-  .tag('<script id=\"cio-tracker\" src=\"https://assets.customer.io/assets/track.js\" data-site-id=\"{{ siteId }}\">');\n+  .tag('<script id=\"cio-tracker\" src=\"//assets.customer.io/assets/track.js\" data-site-id=\"{{ siteId }}\">');","path":"lib/customerio/index.js","position":5,"original_position":5,"commit_id":"6ea7ebb3dcbfcd89bf428024ab28e117c978b3cc","original_commit_id":"6ea7ebb3dcbfcd89bf428024ab28e117c978b3cc","user":{"login":"reinpk","id":658545,"avatar_url":"https://avatars.githubusercontent.com/u/658545?v=2","gravatar_id":"faf2aa0ab731e188c143e908ffdeaa8f","url":"https://api.github.com/users/reinpk","html_url":"https://github.com/reinpk","followers_url":"https://api.github.com/users/reinpk/followers","following_url":"https://api.github.com/users/reinpk/following{/other_user}","gists_url":"https://api.github.com/users/reinpk/gists{/gist_id}","starred_url":"https://api.github.com/users/reinpk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reinpk/subscriptions","organizations_url":"https://api.github.com/users/reinpk/orgs","repos_url":"https://api.github.com/users/reinpk/repos","events_url":"https://api.github.com/users/reinpk/events{/privacy}","received_events_url":"https://api.github.com/users/reinpk/received_events","type":"User","site_admin":false},"body":"it seems to be a change we made in a lot of other places:\r\n+ https://github.com/segmentio/analytics.js-integrations/blob/master/lib/chartbeat/index.js#L21\r\n+ https://github.com/segmentio/analytics.js-integrations/blob/master/lib/churnbee/index.js#L38\r\n+ https://github.com/segmentio/analytics.js-integrations/blob/master/lib/clicky/index.js#L21\r\n\r\nbut then now just noticed that we still have different behavior elsewhere:\r\nhttps://github.com/segmentio/analytics.js-integrations/blob/master/lib/comscore/index.js#L19\r\n\r\nso i'm not sure what's right","created_at":"2014-08-07T23:41:27Z","updated_at":"2014-08-07T23:41:27Z","html_url":"https://github.com/segmentio/analytics.js-integrations/pull/375#discussion_r15971342","pull_request_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/pulls/375","_links":{"self":{"href":"https://api.github.com/repos/segmentio/analytics.js-integrations/pulls/comments/15971342"},"html":{"href":"https://github.com/segmentio/analytics.js-integrations/pull/375#discussion_r15971342"},"pull_request":{"href":"https://api.github.com/repos/segmentio/analytics.js-integrations/pulls/375"}}},"pull_request":{"url":"https://api.github.com/repos/segmentio/analytics.js-integrations/pulls/375","id":19499197,"html_url":"https://github.com/segmentio/analytics.js-integrations/pull/375","diff_url":"https://github.com/segmentio/analytics.js-integrations/pull/375.diff","patch_url":"https://github.com/segmentio/analytics.js-integrations/pull/375.patch","issue_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/issues/375","number":375,"state":"open","title":"udpated version of #208","user":{"login":"reinpk","id":658545,"avatar_url":"https://avatars.githubusercontent.com/u/658545?v=2","gravatar_id":"faf2aa0ab731e188c143e908ffdeaa8f","url":"https://api.github.com/users/reinpk","html_url":"https://github.com/reinpk","followers_url":"https://api.github.com/users/reinpk/followers","following_url":"https://api.github.com/users/reinpk/following{/other_user}","gists_url":"https://api.github.com/users/reinpk/gists{/gist_id}","starred_url":"https://api.github.com/users/reinpk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reinpk/subscriptions","organizations_url":"https://api.github.com/users/reinpk/orgs","repos_url":"https://api.github.com/users/reinpk/repos","events_url":"https://api.github.com/users/reinpk/events{/privacy}","received_events_url":"https://api.github.com/users/reinpk/received_events","type":"User","site_admin":false},"body":"cc @lancejpollard, @calvinfo updated version of #208 \r\n\r\ni'm not able to test locally\r\n","created_at":"2014-08-07T22:33:29Z","updated_at":"2014-08-07T23:41:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a0754136049420deee45034c7eda18d32b43f07f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/pulls/375/commits","review_comments_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/pulls/375/comments","review_comment_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/pulls/comments/{number}","comments_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/issues/375/comments","statuses_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/statuses/6ea7ebb3dcbfcd89bf428024ab28e117c978b3cc","head":{"label":"segmentio:fix/customerio-loading","ref":"fix/customerio-loading","sha":"6ea7ebb3dcbfcd89bf428024ab28e117c978b3cc","user":{"login":"segmentio","id":819518,"avatar_url":"https://avatars.githubusercontent.com/u/819518?v=2","gravatar_id":"420370b79b6adb3a513c24935907539f","url":"https://api.github.com/users/segmentio","html_url":"https://github.com/segmentio","followers_url":"https://api.github.com/users/segmentio/followers","following_url":"https://api.github.com/users/segmentio/following{/other_user}","gists_url":"https://api.github.com/users/segmentio/gists{/gist_id}","starred_url":"https://api.github.com/users/segmentio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/segmentio/subscriptions","organizations_url":"https://api.github.com/users/segmentio/orgs","repos_url":"https://api.github.com/users/segmentio/repos","events_url":"https://api.github.com/users/segmentio/events{/privacy}","received_events_url":"https://api.github.com/users/segmentio/received_events","type":"Organization","site_admin":false},"repo":{"id":14219761,"name":"analytics.js-integrations","full_name":"segmentio/analytics.js-integrations","owner":{"login":"segmentio","id":819518,"avatar_url":"https://avatars.githubusercontent.com/u/819518?v=2","gravatar_id":"420370b79b6adb3a513c24935907539f","url":"https://api.github.com/users/segmentio","html_url":"https://github.com/segmentio","followers_url":"https://api.github.com/users/segmentio/followers","following_url":"https://api.github.com/users/segmentio/following{/other_user}","gists_url":"https://api.github.com/users/segmentio/gists{/gist_id}","starred_url":"https://api.github.com/users/segmentio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/segmentio/subscriptions","organizations_url":"https://api.github.com/users/segmentio/orgs","repos_url":"https://api.github.com/users/segmentio/repos","events_url":"https://api.github.com/users/segmentio/events{/privacy}","received_events_url":"https://api.github.com/users/segmentio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/segmentio/analytics.js-integrations","description":"All of the third-party analytics.js integrations.","fork":false,"url":"https://api.github.com/repos/segmentio/analytics.js-integrations","forks_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/forks","keys_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/keys{/key_id}","collaborators_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/teams","hooks_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/hooks","issue_events_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/issues/events{/number}","events_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/events","assignees_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/assignees{/user}","branches_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/branches{/branch}","tags_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/tags","blobs_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/git/refs{/sha}","trees_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/git/trees{/sha}","statuses_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/statuses/{sha}","languages_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/languages","stargazers_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/stargazers","contributors_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/contributors","subscribers_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/subscribers","subscription_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/subscription","commits_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/commits{/sha}","git_commits_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/git/commits{/sha}","comments_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/comments{/number}","issue_comment_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/issues/comments/{number}","contents_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/contents/{+path}","compare_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/compare/{base}...{head}","merges_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/merges","archive_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/downloads","issues_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/issues{/number}","pulls_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/pulls{/number}","milestones_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/milestones{/number}","notifications_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/labels{/name}","releases_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/releases{/id}","created_at":"2013-11-08T00:09:00Z","updated_at":"2014-08-07T01:55:18Z","pushed_at":"2014-08-07T23:39:21Z","git_url":"git://github.com/segmentio/analytics.js-integrations.git","ssh_url":"git@github.com:segmentio/analytics.js-integrations.git","clone_url":"https://github.com/segmentio/analytics.js-integrations.git","svn_url":"https://github.com/segmentio/analytics.js-integrations","homepage":null,"size":12032,"stargazers_count":36,"watchers_count":36,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":69,"mirror_url":null,"open_issues_count":50,"forks":69,"open_issues":50,"watchers":36,"default_branch":"master"}},"base":{"label":"segmentio:master","ref":"master","sha":"9a5989444933409d7517c0a993cca80f8d72856f","user":{"login":"segmentio","id":819518,"avatar_url":"https://avatars.githubusercontent.com/u/819518?v=2","gravatar_id":"420370b79b6adb3a513c24935907539f","url":"https://api.github.com/users/segmentio","html_url":"https://github.com/segmentio","followers_url":"https://api.github.com/users/segmentio/followers","following_url":"https://api.github.com/users/segmentio/following{/other_user}","gists_url":"https://api.github.com/users/segmentio/gists{/gist_id}","starred_url":"https://api.github.com/users/segmentio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/segmentio/subscriptions","organizations_url":"https://api.github.com/users/segmentio/orgs","repos_url":"https://api.github.com/users/segmentio/repos","events_url":"https://api.github.com/users/segmentio/events{/privacy}","received_events_url":"https://api.github.com/users/segmentio/received_events","type":"Organization","site_admin":false},"repo":{"id":14219761,"name":"analytics.js-integrations","full_name":"segmentio/analytics.js-integrations","owner":{"login":"segmentio","id":819518,"avatar_url":"https://avatars.githubusercontent.com/u/819518?v=2","gravatar_id":"420370b79b6adb3a513c24935907539f","url":"https://api.github.com/users/segmentio","html_url":"https://github.com/segmentio","followers_url":"https://api.github.com/users/segmentio/followers","following_url":"https://api.github.com/users/segmentio/following{/other_user}","gists_url":"https://api.github.com/users/segmentio/gists{/gist_id}","starred_url":"https://api.github.com/users/segmentio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/segmentio/subscriptions","organizations_url":"https://api.github.com/users/segmentio/orgs","repos_url":"https://api.github.com/users/segmentio/repos","events_url":"https://api.github.com/users/segmentio/events{/privacy}","received_events_url":"https://api.github.com/users/segmentio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/segmentio/analytics.js-integrations","description":"All of the third-party analytics.js integrations.","fork":false,"url":"https://api.github.com/repos/segmentio/analytics.js-integrations","forks_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/forks","keys_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/keys{/key_id}","collaborators_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/teams","hooks_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/hooks","issue_events_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/issues/events{/number}","events_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/events","assignees_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/assignees{/user}","branches_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/branches{/branch}","tags_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/tags","blobs_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/git/refs{/sha}","trees_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/git/trees{/sha}","statuses_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/statuses/{sha}","languages_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/languages","stargazers_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/stargazers","contributors_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/contributors","subscribers_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/subscribers","subscription_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/subscription","commits_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/commits{/sha}","git_commits_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/git/commits{/sha}","comments_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/comments{/number}","issue_comment_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/issues/comments/{number}","contents_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/contents/{+path}","compare_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/compare/{base}...{head}","merges_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/merges","archive_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/downloads","issues_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/issues{/number}","pulls_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/pulls{/number}","milestones_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/milestones{/number}","notifications_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/labels{/name}","releases_url":"https://api.github.com/repos/segmentio/analytics.js-integrations/releases{/id}","created_at":"2013-11-08T00:09:00Z","updated_at":"2014-08-07T01:55:18Z","pushed_at":"2014-08-07T23:39:21Z","git_url":"git://github.com/segmentio/analytics.js-integrations.git","ssh_url":"git@github.com:segmentio/analytics.js-integrations.git","clone_url":"https://github.com/segmentio/analytics.js-integrations.git","svn_url":"https://github.com/segmentio/analytics.js-integrations","homepage":null,"size":12032,"stargazers_count":36,"watchers_count":36,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":69,"mirror_url":null,"open_issues_count":50,"forks":69,"open_issues":50,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/segmentio/analytics.js-integrations/pulls/375"},"html":{"href":"https://github.com/segmentio/analytics.js-integrations/pull/375"},"issue":{"href":"https://api.github.com/repos/segmentio/analytics.js-integrations/issues/375"},"comments":{"href":"https://api.github.com/repos/segmentio/analytics.js-integrations/issues/375/comments"},"review_comments":{"href":"https://api.github.com/repos/segmentio/analytics.js-integrations/pulls/375/comments"},"review_comment":{"href":"https://api.github.com/repos/segmentio/analytics.js-integrations/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/segmentio/analytics.js-integrations/pulls/375/commits"},"statuses":{"href":"https://api.github.com/repos/segmentio/analytics.js-integrations/statuses/6ea7ebb3dcbfcd89bf428024ab28e117c978b3cc"}}}}