GitHub PullRequestReviewCommentEvent at 2014-08-14 18:26:43
Repository: trapperkeeper-webserver-jetty9
Actor: KevinCorcoran
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/pulls/comments/16256469","id":16256469,"diff_hunk":"@@ -38,24 +38,35 @@\n    (schema/optional-key :host)                       schema/Str\n    (schema/optional-key :max-threads)                schema/Int\n    (schema/optional-key :request-header-max-size)    schema/Int\n-   (schema/optional-key :ssl-port)        schema/Int\n-   (schema/optional-key :ssl-host)        schema/Str\n-   (schema/optional-key :ssl-key)         schema/Str\n-   (schema/optional-key :ssl-cert)        schema/Str\n-   (schema/optional-key :ssl-ca-cert)     schema/Str\n-   (schema/optional-key :keystore)        schema/Str\n-   (schema/optional-key :truststore)      schema/Str\n-   (schema/optional-key :key-password)    schema/Str\n-   (schema/optional-key :trust-password)  schema/Str\n-   (schema/optional-key :cipher-suites)   [schema/Str]\n-   (schema/optional-key :ssl-protocols)   [schema/Str]\n-   (schema/optional-key :client-auth)     schema/Str\n-   (schema/optional-key :ssl-crl-path)    schema/Str\n-   (schema/optional-key :jmx-enable)      schema/Str})\n+   (schema/optional-key :ssl-port)                   schema/Int\n+   (schema/optional-key :ssl-host)                   schema/Str\n+   (schema/optional-key :ssl-key)                    schema/Str\n+   (schema/optional-key :ssl-cert)                   schema/Str\n+   (schema/optional-key :ssl-ca-cert)                schema/Str\n+   (schema/optional-key :keystore)                   schema/Str\n+   (schema/optional-key :truststore)                 schema/Str\n+   (schema/optional-key :key-password)               schema/Str\n+   (schema/optional-key :trust-password)             schema/Str\n+   (schema/optional-key :cipher-suites)              [schema/Str]\n+   (schema/optional-key :ssl-protocols)              [schema/Str]\n+   (schema/optional-key :client-auth)                schema/Str\n+   (schema/optional-key :ssl-crl-path)               schema/Str\n+   (schema/optional-key :jmx-enable)                 schema/Str\n+   (schema/optional-key :default-server)             schema/Bool})\n+\n+(def MultiWebserverRawConfigUnvalidated\n+  {schema/Keyword  WebserverRawConfig})\n+\n+(defn one-default?\n+  [config]\n+  (->> config\n+       vals\n+       (filter :default-server)\n+       count\n+       (>= 1)))","path":"src/puppetlabs/trapperkeeper/services/webserver/jetty9_config.clj","position":43,"original_position":43,"commit_id":"9949a9bffb953d0c91389ed79845157b8dad630a","original_commit_id":"9949a9bffb953d0c91389ed79845157b8dad630a","user":{"login":"KevinCorcoran","id":2945462,"avatar_url":"https://avatars.githubusercontent.com/u/2945462?v=2","gravatar_id":"dfc2c8771d3a9c5607e45783e3efeabc","url":"https://api.github.com/users/KevinCorcoran","html_url":"https://github.com/KevinCorcoran","followers_url":"https://api.github.com/users/KevinCorcoran/followers","following_url":"https://api.github.com/users/KevinCorcoran/following{/other_user}","gists_url":"https://api.github.com/users/KevinCorcoran/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinCorcoran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinCorcoran/subscriptions","organizations_url":"https://api.github.com/users/KevinCorcoran/orgs","repos_url":"https://api.github.com/users/KevinCorcoran/repos","events_url":"https://api.github.com/users/KevinCorcoran/events{/privacy}","received_events_url":"https://api.github.com/users/KevinCorcoran/received_events","type":"User","site_admin":false},"body":"I won the sweepstakes!","created_at":"2014-08-14T18:26:43Z","updated_at":"2014-08-14T18:26:43Z","html_url":"https://github.com/puppetlabs/trapperkeeper-webserver-jetty9/pull/52#discussion_r16256469","pull_request_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/pulls/52","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/pulls/comments/16256469"},"html":{"href":"https://github.com/puppetlabs/trapperkeeper-webserver-jetty9/pull/52#discussion_r16256469"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/pulls/52"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/pulls/52","id":19697586,"html_url":"https://github.com/puppetlabs/trapperkeeper-webserver-jetty9/pull/52","diff_url":"https://github.com/puppetlabs/trapperkeeper-webserver-jetty9/pull/52.diff","patch_url":"https://github.com/puppetlabs/trapperkeeper-webserver-jetty9/pull/52.patch","issue_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/issues/52","number":52,"state":"open","locked":false,"title":"(TK-50) Require user to specify default server","user":{"login":"fpringvaldsen","id":5620801,"avatar_url":"https://avatars.githubusercontent.com/u/5620801?v=2","gravatar_id":"77b10a2642d624ec94b7e2c51f6b916f","url":"https://api.github.com/users/fpringvaldsen","html_url":"https://github.com/fpringvaldsen","followers_url":"https://api.github.com/users/fpringvaldsen/followers","following_url":"https://api.github.com/users/fpringvaldsen/following{/other_user}","gists_url":"https://api.github.com/users/fpringvaldsen/gists{/gist_id}","starred_url":"https://api.github.com/users/fpringvaldsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fpringvaldsen/subscriptions","organizations_url":"https://api.github.com/users/fpringvaldsen/orgs","repos_url":"https://api.github.com/users/fpringvaldsen/repos","events_url":"https://api.github.com/users/fpringvaldsen/events{/privacy}","received_events_url":"https://api.github.com/users/fpringvaldsen/received_events","type":"User","site_admin":false},"body":"This PR adds support for the user specifying a default server. The user will now be required to specify a default server under the `:default-server` key in the webserver section of their trapperkeeper configuration when using a multi-server configuration. Having a server with id `:default` is no longer required.","created_at":"2014-08-12T23:47:23Z","updated_at":"2014-08-14T18:26:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"79ff77ff53598ffa80f4e4626272eeecd3c2a435","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/pulls/52/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/pulls/52/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/pulls/comments/{number}","comments_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/issues/52/comments","statuses_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/statuses/9949a9bffb953d0c91389ed79845157b8dad630a","head":{"label":"fpringvaldsen:TK-50-specify-default","ref":"TK-50-specify-default","sha":"9949a9bffb953d0c91389ed79845157b8dad630a","user":{"login":"fpringvaldsen","id":5620801,"avatar_url":"https://avatars.githubusercontent.com/u/5620801?v=2","gravatar_id":"77b10a2642d624ec94b7e2c51f6b916f","url":"https://api.github.com/users/fpringvaldsen","html_url":"https://github.com/fpringvaldsen","followers_url":"https://api.github.com/users/fpringvaldsen/followers","following_url":"https://api.github.com/users/fpringvaldsen/following{/other_user}","gists_url":"https://api.github.com/users/fpringvaldsen/gists{/gist_id}","starred_url":"https://api.github.com/users/fpringvaldsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fpringvaldsen/subscriptions","organizations_url":"https://api.github.com/users/fpringvaldsen/orgs","repos_url":"https://api.github.com/users/fpringvaldsen/repos","events_url":"https://api.github.com/users/fpringvaldsen/events{/privacy}","received_events_url":"https://api.github.com/users/fpringvaldsen/received_events","type":"User","site_admin":false},"repo":{"id":21249713,"name":"trapperkeeper-webserver-jetty9","full_name":"fpringvaldsen/trapperkeeper-webserver-jetty9","owner":{"login":"fpringvaldsen","id":5620801,"avatar_url":"https://avatars.githubusercontent.com/u/5620801?v=2","gravatar_id":"77b10a2642d624ec94b7e2c51f6b916f","url":"https://api.github.com/users/fpringvaldsen","html_url":"https://github.com/fpringvaldsen","followers_url":"https://api.github.com/users/fpringvaldsen/followers","following_url":"https://api.github.com/users/fpringvaldsen/following{/other_user}","gists_url":"https://api.github.com/users/fpringvaldsen/gists{/gist_id}","starred_url":"https://api.github.com/users/fpringvaldsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fpringvaldsen/subscriptions","organizations_url":"https://api.github.com/users/fpringvaldsen/orgs","repos_url":"https://api.github.com/users/fpringvaldsen/repos","events_url":"https://api.github.com/users/fpringvaldsen/events{/privacy}","received_events_url":"https://api.github.com/users/fpringvaldsen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fpringvaldsen/trapperkeeper-webserver-jetty9","description":"Trapperkeeper webservice service (jetty9 implementation).","fork":true,"url":"https://api.github.com/repos/fpringvaldsen/trapperkeeper-webserver-jetty9","forks_url":"https://api.github.com/repos/fpringvaldsen/trapperkeeper-webserver-jetty9/forks","keys_url":"https://api.github.com/repos/fpringvaldsen/trapperkeeper-webserver-jetty9/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fpringvaldsen/trapperkeeper-webserver-jetty9/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fpringvaldsen/trapperkeeper-webserver-jetty9/teams","hooks_url":"https://api.github.com/repos/fpringvaldsen/trapperkeeper-webserver-jetty9/hooks","issue_events_url":"https://api.github.com/repos/fpringvaldsen/trapperkeeper-webserver-jetty9/issues/events{/number}","events_url":"https://api.github.com/repos/fpringvaldsen/trapperkeeper-webserver-jetty9/events","assignees_url":"https://api.github.com/repos/fpringvaldsen/trapperkeeper-webserver-jetty9/assignees{/user}","branches_url":"https://api.github.com/repos/fpringvaldsen/trapperkeeper-webserver-jetty9/branches{/branch}","tags_url":"https://api.github.com/repos/fpringvaldsen/trapperkeeper-webserver-jetty9/tags","blobs_url":"https://api.github.com/repos/fpringvaldsen/trapperkeeper-webserver-jetty9/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fpringvaldsen/trapperkeeper-webserver-jetty9/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fpringvaldsen/trapperkeeper-webserver-jetty9/git/refs{/sha}","trees_url":"https://api.github.com/repos/fpringvaldsen/trapperkeeper-webserver-jetty9/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fpringvaldsen/trapperkeeper-webserver-jetty9/statuses/{sha}","languages_url":"https://api.github.com/repos/fpringvaldsen/trapperkeeper-webserver-jetty9/languages","stargazers_url":"https://api.github.com/repos/fpringvaldsen/trapperkeeper-webserver-jetty9/stargazers","contributors_url":"https://api.github.com/repos/fpringvaldsen/trapperkeeper-webserver-jetty9/contributors","subscribers_url":"https://api.github.com/repos/fpringvaldsen/trapperkeeper-webserver-jetty9/subscribers","subscription_url":"https://api.github.com/repos/fpringvaldsen/trapperkeeper-webserver-jetty9/subscription","commits_url":"https://api.github.com/repos/fpringvaldsen/trapperkeeper-webserver-jetty9/commits{/sha}","git_commits_url":"https://api.github.com/repos/fpringvaldsen/trapperkeeper-webserver-jetty9/git/commits{/sha}","comments_url":"https://api.github.com/repos/fpringvaldsen/trapperkeeper-webserver-jetty9/comments{/number}","issue_comment_url":"https://api.github.com/repos/fpringvaldsen/trapperkeeper-webserver-jetty9/issues/comments/{number}","contents_url":"https://api.github.com/repos/fpringvaldsen/trapperkeeper-webserver-jetty9/contents/{+path}","compare_url":"https://api.github.com/repos/fpringvaldsen/trapperkeeper-webserver-jetty9/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fpringvaldsen/trapperkeeper-webserver-jetty9/merges","archive_url":"https://api.github.com/repos/fpringvaldsen/trapperkeeper-webserver-jetty9/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fpringvaldsen/trapperkeeper-webserver-jetty9/downloads","issues_url":"https://api.github.com/repos/fpringvaldsen/trapperkeeper-webserver-jetty9/issues{/number}","pulls_url":"https://api.github.com/repos/fpringvaldsen/trapperkeeper-webserver-jetty9/pulls{/number}","milestones_url":"https://api.github.com/repos/fpringvaldsen/trapperkeeper-webserver-jetty9/milestones{/number}","notifications_url":"https://api.github.com/repos/fpringvaldsen/trapperkeeper-webserver-jetty9/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fpringvaldsen/trapperkeeper-webserver-jetty9/labels{/name}","releases_url":"https://api.github.com/repos/fpringvaldsen/trapperkeeper-webserver-jetty9/releases{/id}","created_at":"2014-06-26T17:56:26Z","updated_at":"2014-06-10T22:08:49Z","pushed_at":"2014-08-14T18:19:56Z","git_url":"git://github.com/fpringvaldsen/trapperkeeper-webserver-jetty9.git","ssh_url":"git@github.com:fpringvaldsen/trapperkeeper-webserver-jetty9.git","clone_url":"https://github.com/fpringvaldsen/trapperkeeper-webserver-jetty9.git","svn_url":"https://github.com/fpringvaldsen/trapperkeeper-webserver-jetty9","homepage":"https://tickets.puppetlabs.com/browse/TK","size":1395,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"39df483c57c6c2b11d346961bd0f7397c31f0c52","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=2","gravatar_id":"eb454c2139c156db7c8266a875519a1f","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":15646171,"name":"trapperkeeper-webserver-jetty9","full_name":"puppetlabs/trapperkeeper-webserver-jetty9","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=2","gravatar_id":"eb454c2139c156db7c8266a875519a1f","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/trapperkeeper-webserver-jetty9","description":"Trapperkeeper webservice service (jetty9 implementation).","fork":false,"url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9","forks_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/forks","keys_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/teams","hooks_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/events","assignees_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/tags","blobs_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/subscription","commits_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/issues/comments/{number}","contents_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/merges","archive_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/downloads","issues_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/releases{/id}","created_at":"2014-01-05T05:40:45Z","updated_at":"2014-07-03T20:43:06Z","pushed_at":"2014-08-14T17:30:49Z","git_url":"git://github.com/puppetlabs/trapperkeeper-webserver-jetty9.git","ssh_url":"git@github.com:puppetlabs/trapperkeeper-webserver-jetty9.git","clone_url":"https://github.com/puppetlabs/trapperkeeper-webserver-jetty9.git","svn_url":"https://github.com/puppetlabs/trapperkeeper-webserver-jetty9","homepage":"https://tickets.puppetlabs.com/browse/TK","size":2124,"stargazers_count":11,"watchers_count":11,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":17,"mirror_url":null,"open_issues_count":3,"forks":17,"open_issues":3,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/pulls/52"},"html":{"href":"https://github.com/puppetlabs/trapperkeeper-webserver-jetty9/pull/52"},"issue":{"href":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/issues/52"},"comments":{"href":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/issues/52/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/pulls/52/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/pulls/52/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/statuses/9949a9bffb953d0c91389ed79845157b8dad630a"}}}}