GitHub PullRequestReviewCommentEvent at 2014-12-10 21:28:11
Repository: kubernetes
Actor: filbranden
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/21638904","id":21638904,"diff_hunk":"@@ -56,15 +66,27 @@ for (( i=0; i<${#MINION_NAMES[@]}; i++)); do\n       NAME=$(grep \"${MINION_NAMES[i]}\" ${MINIONS_FILE})\n     fi\n \n-    # Make sure the kubelet is healthy\n-    curl_output=$(curl -s --insecure --user \"${KUBE_USER}:${KUBE_PASSWORD}\" \\\n-        \"https://${KUBE_MASTER_IP}/api/v1beta1/proxy/minions/${NAME}/healthz\")\n-    if [[ \"${curl_output}\" != \"ok\" ]]; then\n-        echo \"Kubelet failed to install on ${MINION_NAMES[$i]}. Your cluster is unlikely to work correctly.\"\n-        echo \"Please run ./cluster/kube-down.sh and re-create the cluster. (sorry!)\"\n-        exit 1\n-    else\n-        echo \"Kubelet is successfully installed on ${MINION_NAMES[$i]}\"\n-    fi\n+    # Make sure the kubelet is healthy.\n+    # Make several attempts to deal with slow cluster birth.\n+    attempt=0\n+    while true; do\n+      echo -n Attempt \"$[$attempt+1]\" at checking Kublet installation on node \"${MINION_NAMES[$i]}\" ...\n+      curl_output=$(curl -s --insecure --user \"${KUBE_USER}:${KUBE_PASSWORD}\" \\","path":"cluster/validate-cluster.sh","position":46,"original_position":46,"commit_id":"43f28ca4945c5d604f24899769af52335ed50552","original_commit_id":"43f28ca4945c5d604f24899769af52335ed50552","user":{"login":"filbranden","id":106037,"avatar_url":"https://avatars.githubusercontent.com/u/106037?v=3","gravatar_id":"","url":"https://api.github.com/users/filbranden","html_url":"https://github.com/filbranden","followers_url":"https://api.github.com/users/filbranden/followers","following_url":"https://api.github.com/users/filbranden/following{/other_user}","gists_url":"https://api.github.com/users/filbranden/gists{/gist_id}","starred_url":"https://api.github.com/users/filbranden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filbranden/subscriptions","organizations_url":"https://api.github.com/users/filbranden/orgs","repos_url":"https://api.github.com/users/filbranden/repos","events_url":"https://api.github.com/users/filbranden/events{/privacy}","received_events_url":"https://api.github.com/users/filbranden/received_events","type":"User","site_admin":false},"body":"curl_output should be local. local declaration should be in a separate line to prevent it from blocking a failure of curl.","created_at":"2014-12-10T21:28:11Z","updated_at":"2014-12-10T21:28:11Z","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/2816#discussion_r21638904","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/2816","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/21638904"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/2816#discussion_r21638904"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/2816"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/2816","id":25787364,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/2816","diff_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/2816.diff","patch_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/2816.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/2816","number":2816,"state":"open","locked":false,"title":"Make multiple attempts to sanity check (GCE) and validate (ALL) cluster","user":{"login":"satnam6502","id":6164339,"avatar_url":"https://avatars.githubusercontent.com/u/6164339?v=3","gravatar_id":"","url":"https://api.github.com/users/satnam6502","html_url":"https://github.com/satnam6502","followers_url":"https://api.github.com/users/satnam6502/followers","following_url":"https://api.github.com/users/satnam6502/following{/other_user}","gists_url":"https://api.github.com/users/satnam6502/gists{/gist_id}","starred_url":"https://api.github.com/users/satnam6502/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/satnam6502/subscriptions","organizations_url":"https://api.github.com/users/satnam6502/orgs","repos_url":"https://api.github.com/users/satnam6502/repos","events_url":"https://api.github.com/users/satnam6502/events{/privacy}","received_events_url":"https://api.github.com/users/satnam6502/received_events","type":"User","site_admin":false},"body":"This PR changed the sanity check for GCE cluster creation to make multiple attempts to deal with slow cluster birth. It also performs a more detailed check of the Docker installation (by ensuring kubernetes/pause can be found). It also adjusts validate-cluster.sh (for all providers) to make multiple attempts to validate a cluster.\r\n\r\nBefore, even when creating a modest sized cluster (say, 12 nodes), these steps failed not because there was anything wrong with the cluster but just because these steps can be slow and we don't retry.","created_at":"2014-12-09T23:39:57Z","updated_at":"2014-12-10T21:28:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"65a45fab30d5a66ebb2ddc8c2a8ea13a877eab58","assignee":{"login":"filbranden","id":106037,"avatar_url":"https://avatars.githubusercontent.com/u/106037?v=3","gravatar_id":"","url":"https://api.github.com/users/filbranden","html_url":"https://github.com/filbranden","followers_url":"https://api.github.com/users/filbranden/followers","following_url":"https://api.github.com/users/filbranden/following{/other_user}","gists_url":"https://api.github.com/users/filbranden/gists{/gist_id}","starred_url":"https://api.github.com/users/filbranden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filbranden/subscriptions","organizations_url":"https://api.github.com/users/filbranden/orgs","repos_url":"https://api.github.com/users/filbranden/repos","events_url":"https://api.github.com/users/filbranden/events{/privacy}","received_events_url":"https://api.github.com/users/filbranden/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/2816/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/2816/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/{number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/2816/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/43f28ca4945c5d604f24899769af52335ed50552","head":{"label":"satnam6502:robust","ref":"robust","sha":"43f28ca4945c5d604f24899769af52335ed50552","user":{"login":"satnam6502","id":6164339,"avatar_url":"https://avatars.githubusercontent.com/u/6164339?v=3","gravatar_id":"","url":"https://api.github.com/users/satnam6502","html_url":"https://github.com/satnam6502","followers_url":"https://api.github.com/users/satnam6502/followers","following_url":"https://api.github.com/users/satnam6502/following{/other_user}","gists_url":"https://api.github.com/users/satnam6502/gists{/gist_id}","starred_url":"https://api.github.com/users/satnam6502/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/satnam6502/subscriptions","organizations_url":"https://api.github.com/users/satnam6502/orgs","repos_url":"https://api.github.com/users/satnam6502/repos","events_url":"https://api.github.com/users/satnam6502/events{/privacy}","received_events_url":"https://api.github.com/users/satnam6502/received_events","type":"User","site_admin":false},"repo":{"id":23904068,"name":"kubernetes","full_name":"satnam6502/kubernetes","owner":{"login":"satnam6502","id":6164339,"avatar_url":"https://avatars.githubusercontent.com/u/6164339?v=3","gravatar_id":"","url":"https://api.github.com/users/satnam6502","html_url":"https://github.com/satnam6502","followers_url":"https://api.github.com/users/satnam6502/followers","following_url":"https://api.github.com/users/satnam6502/following{/other_user}","gists_url":"https://api.github.com/users/satnam6502/gists{/gist_id}","starred_url":"https://api.github.com/users/satnam6502/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/satnam6502/subscriptions","organizations_url":"https://api.github.com/users/satnam6502/orgs","repos_url":"https://api.github.com/users/satnam6502/repos","events_url":"https://api.github.com/users/satnam6502/events{/privacy}","received_events_url":"https://api.github.com/users/satnam6502/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/satnam6502/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/satnam6502/kubernetes","forks_url":"https://api.github.com/repos/satnam6502/kubernetes/forks","keys_url":"https://api.github.com/repos/satnam6502/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/satnam6502/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/satnam6502/kubernetes/teams","hooks_url":"https://api.github.com/repos/satnam6502/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/satnam6502/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/satnam6502/kubernetes/events","assignees_url":"https://api.github.com/repos/satnam6502/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/satnam6502/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/satnam6502/kubernetes/tags","blobs_url":"https://api.github.com/repos/satnam6502/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/satnam6502/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/satnam6502/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/satnam6502/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/satnam6502/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/satnam6502/kubernetes/languages","stargazers_url":"https://api.github.com/repos/satnam6502/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/satnam6502/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/satnam6502/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/satnam6502/kubernetes/subscription","commits_url":"https://api.github.com/repos/satnam6502/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/satnam6502/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/satnam6502/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/satnam6502/kubernetes/issues/comments/{number}","contents_url":"https://api.github.com/repos/satnam6502/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/satnam6502/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/satnam6502/kubernetes/merges","archive_url":"https://api.github.com/repos/satnam6502/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/satnam6502/kubernetes/downloads","issues_url":"https://api.github.com/repos/satnam6502/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/satnam6502/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/satnam6502/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/satnam6502/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/satnam6502/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/satnam6502/kubernetes/releases{/id}","created_at":"2014-09-11T04:27:10Z","updated_at":"2014-12-09T23:33:55Z","pushed_at":"2014-12-10T19:41:26Z","git_url":"git://github.com/satnam6502/kubernetes.git","ssh_url":"git@github.com:satnam6502/kubernetes.git","clone_url":"https://github.com/satnam6502/kubernetes.git","svn_url":"https://github.com/satnam6502/kubernetes","homepage":null,"size":20147,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"3a7dd589d5031860d8c9fbdc1f36cde5ab8a425a","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"GoogleCloudPlatform/kubernetes","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes","description":"Container Cluster Manager","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/comments/{number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2014-12-10T21:15:29Z","pushed_at":"2014-12-10T21:15:29Z","git_url":"git://github.com/GoogleCloudPlatform/kubernetes.git","ssh_url":"git@github.com:GoogleCloudPlatform/kubernetes.git","clone_url":"https://github.com/GoogleCloudPlatform/kubernetes.git","svn_url":"https://github.com/GoogleCloudPlatform/kubernetes","homepage":null,"size":42924,"stargazers_count":5328,"watchers_count":5328,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":824,"mirror_url":null,"open_issues_count":470,"forks":824,"open_issues":470,"watchers":5328,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/2816"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/2816"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/2816"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/2816/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/2816/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/2816/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/43f28ca4945c5d604f24899769af52335ed50552"}}}}