GitHub PullRequestEvent at 2014-08-25 17:51:38
Repository: metasploit-framework
Actor: todb-r7
Payload: {"action":"opened","number":3697,"pull_request":{"url":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/3697","id":20260451,"html_url":"https://github.com/rapid7/metasploit-framework/pull/3697","diff_url":"https://github.com/rapid7/metasploit-framework/pull/3697.diff","patch_url":"https://github.com/rapid7/metasploit-framework/pull/3697.patch","issue_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/3697","number":3697,"state":"open","locked":false,"title":"Use peer when writing scanner modules","user":{"login":"todb-r7","id":1170909,"avatar_url":"https://avatars.githubusercontent.com/u/1170909?v=2","gravatar_id":"777bcd9397ea40f75ccd1023c8779257","url":"https://api.github.com/users/todb-r7","html_url":"https://github.com/todb-r7","followers_url":"https://api.github.com/users/todb-r7/followers","following_url":"https://api.github.com/users/todb-r7/following{/other_user}","gists_url":"https://api.github.com/users/todb-r7/gists{/gist_id}","starred_url":"https://api.github.com/users/todb-r7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/todb-r7/subscriptions","organizations_url":"https://api.github.com/users/todb-r7/orgs","repos_url":"https://api.github.com/users/todb-r7/repos","events_url":"https://api.github.com/users/todb-r7/events{/privacy}","received_events_url":"https://api.github.com/users/todb-r7/received_events","type":"User","site_admin":false},"body":"This fixes the module seen in PR rapid7#3684 to use the peer method at the beginning of print_* messages, rather than the vhost method at the end. Doing this tends to make reading the output much easier since it's more consistent.\r\n\r\nIncidentally, this module has an msftidy complaint:\r\n\r\n````\r\n--- Checking new and changed module syntax with tools/msftidy.rb ---\r\nmodules/auxiliary/scanner/http/ipboard_login.rb - [INFO] Please use vars_get in send_request_cgi: send_request_cgi({ 'uri' => normalize_uri(target_uri.path, \"index.php?app=core&module=global&section=login&do=process\"\r\n````\r\n\r\nThis should be fixed as well, or explained why it's not being honored.\r\n\r\n/cc @OJ @ChrisTruncer","created_at":"2014-08-25T17:51:37Z","updated_at":"2014-08-25T17:51:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/3697/commits","review_comments_url":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/3697/comments","review_comment_url":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/3697/comments","statuses_url":"https://api.github.com/repos/rapid7/metasploit-framework/statuses/c3213a73e5093ea5ba0e417174ec6ff962f70eaf","head":{"label":"todb-r7:fix-pr3684-use-peer","ref":"fix-pr3684-use-peer","sha":"c3213a73e5093ea5ba0e417174ec6ff962f70eaf","user":{"login":"todb-r7","id":1170909,"avatar_url":"https://avatars.githubusercontent.com/u/1170909?v=2","gravatar_id":"777bcd9397ea40f75ccd1023c8779257","url":"https://api.github.com/users/todb-r7","html_url":"https://github.com/todb-r7","followers_url":"https://api.github.com/users/todb-r7/followers","following_url":"https://api.github.com/users/todb-r7/following{/other_user}","gists_url":"https://api.github.com/users/todb-r7/gists{/gist_id}","starred_url":"https://api.github.com/users/todb-r7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/todb-r7/subscriptions","organizations_url":"https://api.github.com/users/todb-r7/orgs","repos_url":"https://api.github.com/users/todb-r7/repos","events_url":"https://api.github.com/users/todb-r7/events{/privacy}","received_events_url":"https://api.github.com/users/todb-r7/received_events","type":"User","site_admin":false},"repo":{"id":17723719,"name":"metasploit-framework","full_name":"todb-r7/metasploit-framework","owner":{"login":"todb-r7","id":1170909,"avatar_url":"https://avatars.githubusercontent.com/u/1170909?v=2","gravatar_id":"777bcd9397ea40f75ccd1023c8779257","url":"https://api.github.com/users/todb-r7","html_url":"https://github.com/todb-r7","followers_url":"https://api.github.com/users/todb-r7/followers","following_url":"https://api.github.com/users/todb-r7/following{/other_user}","gists_url":"https://api.github.com/users/todb-r7/gists{/gist_id}","starred_url":"https://api.github.com/users/todb-r7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/todb-r7/subscriptions","organizations_url":"https://api.github.com/users/todb-r7/orgs","repos_url":"https://api.github.com/users/todb-r7/repos","events_url":"https://api.github.com/users/todb-r7/events{/privacy}","received_events_url":"https://api.github.com/users/todb-r7/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/todb-r7/metasploit-framework","description":"Metasploit Framework","fork":true,"url":"https://api.github.com/repos/todb-r7/metasploit-framework","forks_url":"https://api.github.com/repos/todb-r7/metasploit-framework/forks","keys_url":"https://api.github.com/repos/todb-r7/metasploit-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/todb-r7/metasploit-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/todb-r7/metasploit-framework/teams","hooks_url":"https://api.github.com/repos/todb-r7/metasploit-framework/hooks","issue_events_url":"https://api.github.com/repos/todb-r7/metasploit-framework/issues/events{/number}","events_url":"https://api.github.com/repos/todb-r7/metasploit-framework/events","assignees_url":"https://api.github.com/repos/todb-r7/metasploit-framework/assignees{/user}","branches_url":"https://api.github.com/repos/todb-r7/metasploit-framework/branches{/branch}","tags_url":"https://api.github.com/repos/todb-r7/metasploit-framework/tags","blobs_url":"https://api.github.com/repos/todb-r7/metasploit-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/todb-r7/metasploit-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/todb-r7/metasploit-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/todb-r7/metasploit-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/todb-r7/metasploit-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/todb-r7/metasploit-framework/languages","stargazers_url":"https://api.github.com/repos/todb-r7/metasploit-framework/stargazers","contributors_url":"https://api.github.com/repos/todb-r7/metasploit-framework/contributors","subscribers_url":"https://api.github.com/repos/todb-r7/metasploit-framework/subscribers","subscription_url":"https://api.github.com/repos/todb-r7/metasploit-framework/subscription","commits_url":"https://api.github.com/repos/todb-r7/metasploit-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/todb-r7/metasploit-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/todb-r7/metasploit-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/todb-r7/metasploit-framework/issues/comments/{number}","contents_url":"https://api.github.com/repos/todb-r7/metasploit-framework/contents/{+path}","compare_url":"https://api.github.com/repos/todb-r7/metasploit-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/todb-r7/metasploit-framework/merges","archive_url":"https://api.github.com/repos/todb-r7/metasploit-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/todb-r7/metasploit-framework/downloads","issues_url":"https://api.github.com/repos/todb-r7/metasploit-framework/issues{/number}","pulls_url":"https://api.github.com/repos/todb-r7/metasploit-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/todb-r7/metasploit-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/todb-r7/metasploit-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/todb-r7/metasploit-framework/labels{/name}","releases_url":"https://api.github.com/repos/todb-r7/metasploit-framework/releases{/id}","created_at":"2014-03-13T19:45:10Z","updated_at":"2014-07-24T19:48:32Z","pushed_at":"2014-08-25T17:50:49Z","git_url":"git://github.com/todb-r7/metasploit-framework.git","ssh_url":"git@github.com:todb-r7/metasploit-framework.git","clone_url":"https://github.com/todb-r7/metasploit-framework.git","svn_url":"https://github.com/todb-r7/metasploit-framework","homepage":"http://www.metasploit.com/","size":245670,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"rapid7:master","ref":"master","sha":"1ee83ff57ef91e8563a5c9eb67e4cd1d26feace2","user":{"login":"rapid7","id":1013671,"avatar_url":"https://avatars.githubusercontent.com/u/1013671?v=2","gravatar_id":"5d198df57a51ac06525bfa48c3ff9f6c","url":"https://api.github.com/users/rapid7","html_url":"https://github.com/rapid7","followers_url":"https://api.github.com/users/rapid7/followers","following_url":"https://api.github.com/users/rapid7/following{/other_user}","gists_url":"https://api.github.com/users/rapid7/gists{/gist_id}","starred_url":"https://api.github.com/users/rapid7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapid7/subscriptions","organizations_url":"https://api.github.com/users/rapid7/orgs","repos_url":"https://api.github.com/users/rapid7/repos","events_url":"https://api.github.com/users/rapid7/events{/privacy}","received_events_url":"https://api.github.com/users/rapid7/received_events","type":"Organization","site_admin":false},"repo":{"id":2293158,"name":"metasploit-framework","full_name":"rapid7/metasploit-framework","owner":{"login":"rapid7","id":1013671,"avatar_url":"https://avatars.githubusercontent.com/u/1013671?v=2","gravatar_id":"5d198df57a51ac06525bfa48c3ff9f6c","url":"https://api.github.com/users/rapid7","html_url":"https://github.com/rapid7","followers_url":"https://api.github.com/users/rapid7/followers","following_url":"https://api.github.com/users/rapid7/following{/other_user}","gists_url":"https://api.github.com/users/rapid7/gists{/gist_id}","starred_url":"https://api.github.com/users/rapid7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapid7/subscriptions","organizations_url":"https://api.github.com/users/rapid7/orgs","repos_url":"https://api.github.com/users/rapid7/repos","events_url":"https://api.github.com/users/rapid7/events{/privacy}","received_events_url":"https://api.github.com/users/rapid7/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rapid7/metasploit-framework","description":"Metasploit Framework","fork":false,"url":"https://api.github.com/repos/rapid7/metasploit-framework","forks_url":"https://api.github.com/repos/rapid7/metasploit-framework/forks","keys_url":"https://api.github.com/repos/rapid7/metasploit-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rapid7/metasploit-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rapid7/metasploit-framework/teams","hooks_url":"https://api.github.com/repos/rapid7/metasploit-framework/hooks","issue_events_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/events{/number}","events_url":"https://api.github.com/repos/rapid7/metasploit-framework/events","assignees_url":"https://api.github.com/repos/rapid7/metasploit-framework/assignees{/user}","branches_url":"https://api.github.com/repos/rapid7/metasploit-framework/branches{/branch}","tags_url":"https://api.github.com/repos/rapid7/metasploit-framework/tags","blobs_url":"https://api.github.com/repos/rapid7/metasploit-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rapid7/metasploit-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rapid7/metasploit-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/rapid7/metasploit-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rapid7/metasploit-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/rapid7/metasploit-framework/languages","stargazers_url":"https://api.github.com/repos/rapid7/metasploit-framework/stargazers","contributors_url":"https://api.github.com/repos/rapid7/metasploit-framework/contributors","subscribers_url":"https://api.github.com/repos/rapid7/metasploit-framework/subscribers","subscription_url":"https://api.github.com/repos/rapid7/metasploit-framework/subscription","commits_url":"https://api.github.com/repos/rapid7/metasploit-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/rapid7/metasploit-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/rapid7/metasploit-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/comments/{number}","contents_url":"https://api.github.com/repos/rapid7/metasploit-framework/contents/{+path}","compare_url":"https://api.github.com/repos/rapid7/metasploit-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rapid7/metasploit-framework/merges","archive_url":"https://api.github.com/repos/rapid7/metasploit-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rapid7/metasploit-framework/downloads","issues_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues{/number}","pulls_url":"https://api.github.com/repos/rapid7/metasploit-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/rapid7/metasploit-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/rapid7/metasploit-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rapid7/metasploit-framework/labels{/name}","releases_url":"https://api.github.com/repos/rapid7/metasploit-framework/releases{/id}","created_at":"2011-08-30T06:13:20Z","updated_at":"2014-08-25T13:00:55Z","pushed_at":"2014-08-25T16:50:44Z","git_url":"git://github.com/rapid7/metasploit-framework.git","ssh_url":"git@github.com:rapid7/metasploit-framework.git","clone_url":"https://github.com/rapid7/metasploit-framework.git","svn_url":"https://github.com/rapid7/metasploit-framework","homepage":"http://www.metasploit.com/","size":959671,"stargazers_count":2433,"watchers_count":2433,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":2219,"mirror_url":null,"open_issues_count":81,"forks":2219,"open_issues":81,"watchers":2433,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/3697"},"html":{"href":"https://github.com/rapid7/metasploit-framework/pull/3697"},"issue":{"href":"https://api.github.com/repos/rapid7/metasploit-framework/issues/3697"},"comments":{"href":"https://api.github.com/repos/rapid7/metasploit-framework/issues/3697/comments"},"review_comments":{"href":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/3697/comments"},"review_comment":{"href":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/3697/commits"},"statuses":{"href":"https://api.github.com/repos/rapid7/metasploit-framework/statuses/c3213a73e5093ea5ba0e417174ec6ff962f70eaf"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":9,"deletions":9,"changed_files":1}}