GitHub PullRequestReviewCommentEvent at 2014-05-19 22:57:59
Repository: elephant-bird
Actor: jcoveney
Payload: {"comment":{"url":"https://api.github.com/repos/kevinweil/elephant-bird/pulls/comments/12820835","id":12820835,"diff_hunk":"@@ -0,0 +1,359 @@\n+package com.twitter.elephantbird.util;\n+\n+import com.twitter.elephantbird.mapreduce.input.combined.CompositeInputSplit;\n+import org.apache.hadoop.conf.Configuration;\n+import org.apache.hadoop.fs.FileSystem;\n+import org.apache.hadoop.fs.Path;\n+import org.apache.hadoop.mapreduce.InputSplit;\n+\n+import java.io.IOException;\n+import java.util.*;\n+\n+import org.slf4j.Logger;\n+import org.slf4j.LoggerFactory;\n+\n+/**\n+ * This code facilitates combining InputSplits, managing the locality vs\n+ * input size skew tradeoff. This code is adapted and cleaned up from\n+ * Apache Pig. It was copied to avoid having to depend on all of Pig for\n+ * this utility.\n+ *\n+ * @author Jonathan Coveney\n+ */\n+public class SplitUtil {\n+  private static final Logger LOG = LoggerFactory.getLogger(SplitUtil.class);\n+\n+  public static final  String COMBINE_SPLIT_SIZE = \"elephantbird.combine.split.size\";","path":"core/src/main/java/com/twitter/elephantbird/util/SplitUtil.java","position":26,"original_position":26,"commit_id":"14b5039f954250b0674ae2687019240114f0b8bf","original_commit_id":"14b5039f954250b0674ae2687019240114f0b8bf","user":{"login":"jcoveney","id":830087,"avatar_url":"https://avatars.githubusercontent.com/u/830087?","gravatar_id":"c31517bb2497ca20710a294d3f8d1144","url":"https://api.github.com/users/jcoveney","html_url":"https://github.com/jcoveney","followers_url":"https://api.github.com/users/jcoveney/followers","following_url":"https://api.github.com/users/jcoveney/following{/other_user}","gists_url":"https://api.github.com/users/jcoveney/gists{/gist_id}","starred_url":"https://api.github.com/users/jcoveney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcoveney/subscriptions","organizations_url":"https://api.github.com/users/jcoveney/orgs","repos_url":"https://api.github.com/users/jcoveney/repos","events_url":"https://api.github.com/users/jcoveney/events{/privacy}","received_events_url":"https://api.github.com/users/jcoveney/received_events","type":"User","site_admin":false},"body":"that's a different setting that serves a different purpose, no? That would affect the underlying split, not the combining of them.","created_at":"2014-05-19T22:57:59Z","updated_at":"2014-05-19T22:57:59Z","html_url":"https://github.com/kevinweil/elephant-bird/pull/398#discussion_r12820835","pull_request_url":"https://api.github.com/repos/kevinweil/elephant-bird/pulls/398","_links":{"self":{"href":"https://api.github.com/repos/kevinweil/elephant-bird/pulls/comments/12820835"},"html":{"href":"https://github.com/kevinweil/elephant-bird/pull/398#discussion_r12820835"},"pull_request":{"href":"https://api.github.com/repos/kevinweil/elephant-bird/pulls/398"}}}}