GitHub PullRequestReviewCommentEvent at 2014-08-29 14:59:14
Repository: tachyon
Actor: pfxuan
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/amplab/tachyon/pulls/comments/16902098","id":16902098,"diff_hunk":"@@ -48,14 +49,14 @@ public HdfsFileInputStream(TachyonFS tfs, int fileId, Path hdfsPath, Configurati\n     mHadoopConf = conf;\n     mHadoopBufferSize = bufferSize;\n \n-    TachyonFile tachyonFile = mTFS.getFile(mFileId);\n-    if (tachyonFile == null) {\n+    TachyonFile mTachyonFile = mTFS.getFile(mFileId);","path":"core/src/main/java/tachyon/hadoop/HdfsFileInputStream.java","position":14,"original_position":14,"commit_id":"30676c37b712a24b9e0dc089ac14c977727fedc4","original_commit_id":"30676c37b712a24b9e0dc089ac14c977727fedc4","user":{"login":"pfxuan","id":2773827,"avatar_url":"https://avatars.githubusercontent.com/u/2773827?v=2","gravatar_id":"c20b61195f6e2f14a7c1887791c8adf4","url":"https://api.github.com/users/pfxuan","html_url":"https://github.com/pfxuan","followers_url":"https://api.github.com/users/pfxuan/followers","following_url":"https://api.github.com/users/pfxuan/following{/other_user}","gists_url":"https://api.github.com/users/pfxuan/gists{/gist_id}","starred_url":"https://api.github.com/users/pfxuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfxuan/subscriptions","organizations_url":"https://api.github.com/users/pfxuan/orgs","repos_url":"https://api.github.com/users/pfxuan/repos","events_url":"https://api.github.com/users/pfxuan/events{/privacy}","received_events_url":"https://api.github.com/users/pfxuan/received_events","type":"User","site_admin":false},"body":"What's the best way to retrieve file length with minor overhead to HdfsFileInputStream? \r\nI need to get the file length in method read(long position, byte[] buffer, int offset, int length). ","created_at":"2014-08-29T14:59:14Z","updated_at":"2014-08-29T14:59:14Z","html_url":"https://github.com/amplab/tachyon/pull/391#discussion_r16902098","pull_request_url":"https://api.github.com/repos/amplab/tachyon/pulls/391","_links":{"self":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/comments/16902098"},"html":{"href":"https://github.com/amplab/tachyon/pull/391#discussion_r16902098"},"pull_request":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/391"}}},"pull_request":{"url":"https://api.github.com/repos/amplab/tachyon/pulls/391","id":20292649,"html_url":"https://github.com/amplab/tachyon/pull/391","diff_url":"https://github.com/amplab/tachyon/pull/391.diff","patch_url":"https://github.com/amplab/tachyon/pull/391.patch","issue_url":"https://api.github.com/repos/amplab/tachyon/issues/391","number":391,"state":"open","locked":false,"title":"Fixed TACHYON-97","user":{"login":"pfxuan","id":2773827,"avatar_url":"https://avatars.githubusercontent.com/u/2773827?v=2","gravatar_id":"c20b61195f6e2f14a7c1887791c8adf4","url":"https://api.github.com/users/pfxuan","html_url":"https://github.com/pfxuan","followers_url":"https://api.github.com/users/pfxuan/followers","following_url":"https://api.github.com/users/pfxuan/following{/other_user}","gists_url":"https://api.github.com/users/pfxuan/gists{/gist_id}","starred_url":"https://api.github.com/users/pfxuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfxuan/subscriptions","organizations_url":"https://api.github.com/users/pfxuan/orgs","repos_url":"https://api.github.com/users/pfxuan/repos","events_url":"https://api.github.com/users/pfxuan/events{/privacy}","received_events_url":"https://api.github.com/users/pfxuan/received_events","type":"User","site_admin":false},"body":"Current implementation of read(long position, byte[] buffer, int offset, int length) in HdfsFileInputStream is incomplete: \r\n1. It does not consider the boundary of file length, which could lead to an out of range issue when seeking the requested position in bytebuffer. \r\n2. It does not recover the original offset after function call.","created_at":"2014-08-26T07:49:03Z","updated_at":"2014-08-29T14:59:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1d10c2429af161b3d4b4889edc5357b87fffdef2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/amplab/tachyon/pulls/391/commits","review_comments_url":"https://api.github.com/repos/amplab/tachyon/pulls/391/comments","review_comment_url":"https://api.github.com/repos/amplab/tachyon/pulls/comments/{number}","comments_url":"https://api.github.com/repos/amplab/tachyon/issues/391/comments","statuses_url":"https://api.github.com/repos/amplab/tachyon/statuses/30676c37b712a24b9e0dc089ac14c977727fedc4","head":{"label":"pfxuan:tachyon-97","ref":"tachyon-97","sha":"30676c37b712a24b9e0dc089ac14c977727fedc4","user":{"login":"pfxuan","id":2773827,"avatar_url":"https://avatars.githubusercontent.com/u/2773827?v=2","gravatar_id":"c20b61195f6e2f14a7c1887791c8adf4","url":"https://api.github.com/users/pfxuan","html_url":"https://github.com/pfxuan","followers_url":"https://api.github.com/users/pfxuan/followers","following_url":"https://api.github.com/users/pfxuan/following{/other_user}","gists_url":"https://api.github.com/users/pfxuan/gists{/gist_id}","starred_url":"https://api.github.com/users/pfxuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfxuan/subscriptions","organizations_url":"https://api.github.com/users/pfxuan/orgs","repos_url":"https://api.github.com/users/pfxuan/repos","events_url":"https://api.github.com/users/pfxuan/events{/privacy}","received_events_url":"https://api.github.com/users/pfxuan/received_events","type":"User","site_admin":false},"repo":{"id":18997047,"name":"tachyon","full_name":"pfxuan/tachyon","owner":{"login":"pfxuan","id":2773827,"avatar_url":"https://avatars.githubusercontent.com/u/2773827?v=2","gravatar_id":"c20b61195f6e2f14a7c1887791c8adf4","url":"https://api.github.com/users/pfxuan","html_url":"https://github.com/pfxuan","followers_url":"https://api.github.com/users/pfxuan/followers","following_url":"https://api.github.com/users/pfxuan/following{/other_user}","gists_url":"https://api.github.com/users/pfxuan/gists{/gist_id}","starred_url":"https://api.github.com/users/pfxuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfxuan/subscriptions","organizations_url":"https://api.github.com/users/pfxuan/orgs","repos_url":"https://api.github.com/users/pfxuan/repos","events_url":"https://api.github.com/users/pfxuan/events{/privacy}","received_events_url":"https://api.github.com/users/pfxuan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pfxuan/tachyon","description":"Reliable File Sharing at Memory Speed Across Cluster Frameworks","fork":true,"url":"https://api.github.com/repos/pfxuan/tachyon","forks_url":"https://api.github.com/repos/pfxuan/tachyon/forks","keys_url":"https://api.github.com/repos/pfxuan/tachyon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pfxuan/tachyon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pfxuan/tachyon/teams","hooks_url":"https://api.github.com/repos/pfxuan/tachyon/hooks","issue_events_url":"https://api.github.com/repos/pfxuan/tachyon/issues/events{/number}","events_url":"https://api.github.com/repos/pfxuan/tachyon/events","assignees_url":"https://api.github.com/repos/pfxuan/tachyon/assignees{/user}","branches_url":"https://api.github.com/repos/pfxuan/tachyon/branches{/branch}","tags_url":"https://api.github.com/repos/pfxuan/tachyon/tags","blobs_url":"https://api.github.com/repos/pfxuan/tachyon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pfxuan/tachyon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pfxuan/tachyon/git/refs{/sha}","trees_url":"https://api.github.com/repos/pfxuan/tachyon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pfxuan/tachyon/statuses/{sha}","languages_url":"https://api.github.com/repos/pfxuan/tachyon/languages","stargazers_url":"https://api.github.com/repos/pfxuan/tachyon/stargazers","contributors_url":"https://api.github.com/repos/pfxuan/tachyon/contributors","subscribers_url":"https://api.github.com/repos/pfxuan/tachyon/subscribers","subscription_url":"https://api.github.com/repos/pfxuan/tachyon/subscription","commits_url":"https://api.github.com/repos/pfxuan/tachyon/commits{/sha}","git_commits_url":"https://api.github.com/repos/pfxuan/tachyon/git/commits{/sha}","comments_url":"https://api.github.com/repos/pfxuan/tachyon/comments{/number}","issue_comment_url":"https://api.github.com/repos/pfxuan/tachyon/issues/comments/{number}","contents_url":"https://api.github.com/repos/pfxuan/tachyon/contents/{+path}","compare_url":"https://api.github.com/repos/pfxuan/tachyon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pfxuan/tachyon/merges","archive_url":"https://api.github.com/repos/pfxuan/tachyon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pfxuan/tachyon/downloads","issues_url":"https://api.github.com/repos/pfxuan/tachyon/issues{/number}","pulls_url":"https://api.github.com/repos/pfxuan/tachyon/pulls{/number}","milestones_url":"https://api.github.com/repos/pfxuan/tachyon/milestones{/number}","notifications_url":"https://api.github.com/repos/pfxuan/tachyon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pfxuan/tachyon/labels{/name}","releases_url":"https://api.github.com/repos/pfxuan/tachyon/releases{/id}","created_at":"2014-04-21T15:41:12Z","updated_at":"2014-07-15T15:38:21Z","pushed_at":"2014-08-29T14:34:42Z","git_url":"git://github.com/pfxuan/tachyon.git","ssh_url":"git@github.com:pfxuan/tachyon.git","clone_url":"https://github.com/pfxuan/tachyon.git","svn_url":"https://github.com/pfxuan/tachyon","homepage":"http://tachyon-project.org","size":6851,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"amplab:master","ref":"master","sha":"b4cbe17fa85c09dd711e1a1e099acd7ab0bd43f1","user":{"login":"amplab","id":1438454,"avatar_url":"https://avatars.githubusercontent.com/u/1438454?v=2","gravatar_id":"c0783723b006eb46526c04fa47ba2cd7","url":"https://api.github.com/users/amplab","html_url":"https://github.com/amplab","followers_url":"https://api.github.com/users/amplab/followers","following_url":"https://api.github.com/users/amplab/following{/other_user}","gists_url":"https://api.github.com/users/amplab/gists{/gist_id}","starred_url":"https://api.github.com/users/amplab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amplab/subscriptions","organizations_url":"https://api.github.com/users/amplab/orgs","repos_url":"https://api.github.com/users/amplab/repos","events_url":"https://api.github.com/users/amplab/events{/privacy}","received_events_url":"https://api.github.com/users/amplab/received_events","type":"Organization","site_admin":false},"repo":{"id":7276954,"name":"tachyon","full_name":"amplab/tachyon","owner":{"login":"amplab","id":1438454,"avatar_url":"https://avatars.githubusercontent.com/u/1438454?v=2","gravatar_id":"c0783723b006eb46526c04fa47ba2cd7","url":"https://api.github.com/users/amplab","html_url":"https://github.com/amplab","followers_url":"https://api.github.com/users/amplab/followers","following_url":"https://api.github.com/users/amplab/following{/other_user}","gists_url":"https://api.github.com/users/amplab/gists{/gist_id}","starred_url":"https://api.github.com/users/amplab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amplab/subscriptions","organizations_url":"https://api.github.com/users/amplab/orgs","repos_url":"https://api.github.com/users/amplab/repos","events_url":"https://api.github.com/users/amplab/events{/privacy}","received_events_url":"https://api.github.com/users/amplab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/amplab/tachyon","description":" A Reliable Memory Centric Distributed Storage System","fork":false,"url":"https://api.github.com/repos/amplab/tachyon","forks_url":"https://api.github.com/repos/amplab/tachyon/forks","keys_url":"https://api.github.com/repos/amplab/tachyon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amplab/tachyon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amplab/tachyon/teams","hooks_url":"https://api.github.com/repos/amplab/tachyon/hooks","issue_events_url":"https://api.github.com/repos/amplab/tachyon/issues/events{/number}","events_url":"https://api.github.com/repos/amplab/tachyon/events","assignees_url":"https://api.github.com/repos/amplab/tachyon/assignees{/user}","branches_url":"https://api.github.com/repos/amplab/tachyon/branches{/branch}","tags_url":"https://api.github.com/repos/amplab/tachyon/tags","blobs_url":"https://api.github.com/repos/amplab/tachyon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amplab/tachyon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amplab/tachyon/git/refs{/sha}","trees_url":"https://api.github.com/repos/amplab/tachyon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amplab/tachyon/statuses/{sha}","languages_url":"https://api.github.com/repos/amplab/tachyon/languages","stargazers_url":"https://api.github.com/repos/amplab/tachyon/stargazers","contributors_url":"https://api.github.com/repos/amplab/tachyon/contributors","subscribers_url":"https://api.github.com/repos/amplab/tachyon/subscribers","subscription_url":"https://api.github.com/repos/amplab/tachyon/subscription","commits_url":"https://api.github.com/repos/amplab/tachyon/commits{/sha}","git_commits_url":"https://api.github.com/repos/amplab/tachyon/git/commits{/sha}","comments_url":"https://api.github.com/repos/amplab/tachyon/comments{/number}","issue_comment_url":"https://api.github.com/repos/amplab/tachyon/issues/comments/{number}","contents_url":"https://api.github.com/repos/amplab/tachyon/contents/{+path}","compare_url":"https://api.github.com/repos/amplab/tachyon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amplab/tachyon/merges","archive_url":"https://api.github.com/repos/amplab/tachyon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amplab/tachyon/downloads","issues_url":"https://api.github.com/repos/amplab/tachyon/issues{/number}","pulls_url":"https://api.github.com/repos/amplab/tachyon/pulls{/number}","milestones_url":"https://api.github.com/repos/amplab/tachyon/milestones{/number}","notifications_url":"https://api.github.com/repos/amplab/tachyon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amplab/tachyon/labels{/name}","releases_url":"https://api.github.com/repos/amplab/tachyon/releases{/id}","created_at":"2012-12-21T17:43:46Z","updated_at":"2014-08-28T12:57:46Z","pushed_at":"2014-08-29T06:04:01Z","git_url":"git://github.com/amplab/tachyon.git","ssh_url":"git@github.com:amplab/tachyon.git","clone_url":"https://github.com/amplab/tachyon.git","svn_url":"https://github.com/amplab/tachyon","homepage":"http://tachyon-project.org","size":27912,"stargazers_count":914,"watchers_count":914,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":261,"mirror_url":null,"open_issues_count":16,"forks":261,"open_issues":16,"watchers":914,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/391"},"html":{"href":"https://github.com/amplab/tachyon/pull/391"},"issue":{"href":"https://api.github.com/repos/amplab/tachyon/issues/391"},"comments":{"href":"https://api.github.com/repos/amplab/tachyon/issues/391/comments"},"review_comments":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/391/comments"},"review_comment":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/391/commits"},"statuses":{"href":"https://api.github.com/repos/amplab/tachyon/statuses/30676c37b712a24b9e0dc089ac14c977727fedc4"}}}}