GitHub PullRequestReviewCommentEvent at 2014-04-08 15:08:44
Repository: Propel2
Actor: marcj
Payload: {"comment":{"url":"https://api.github.com/repos/propelorm/Propel2/pulls/comments/11394001","id":11394001,"diff_hunk":"@@ -276,19 +168,27 @@ public function unserialize($data)\n         throw new PropelException('The On Demand Collection cannot be serialized');\n     }\n \n-    // ArrayObject methods\n+    // Countable Interface\n \n-    public function append($value)\n+    /**\n+     * Returns the number of rows in the resultset\n+     * Warning: this number is inaccurate for most databases. Do not rely on it for a portable application.","path":"src/Propel/Runtime/Collection/OnDemandCollection.php","position":193,"original_position":193,"commit_id":"5a13bdc16dc602fc37b3ff25575098482ad9b11e","original_commit_id":"d0ea87721b2c855027afb6b1e905097a7c10114f","user":{"login":"marcj","id":450980,"avatar_url":"https://avatars.githubusercontent.com/u/450980?","gravatar_id":"4cf03620f0f00793f5d034480654bd3c","url":"https://api.github.com/users/marcj","html_url":"https://github.com/marcj","followers_url":"https://api.github.com/users/marcj/followers","following_url":"https://api.github.com/users/marcj/following{/other_user}","gists_url":"https://api.github.com/users/marcj/gists{/gist_id}","starred_url":"https://api.github.com/users/marcj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcj/subscriptions","organizations_url":"https://api.github.com/users/marcj/orgs","repos_url":"https://api.github.com/users/marcj/repos","events_url":"https://api.github.com/users/marcj/events{/privacy}","received_events_url":"https://api.github.com/users/marcj/received_events","type":"User","site_admin":false},"body":"Ok, then please remove this warning again since `count` of the `dataFetcher` instance returns actual always the correct value.","created_at":"2014-04-08T15:08:44Z","updated_at":"2014-04-08T15:08:44Z","html_url":"https://github.com/propelorm/Propel2/pull/595#discussion_r11394001","pull_request_url":"https://api.github.com/repos/propelorm/Propel2/pulls/595","_links":{"self":{"href":"https://api.github.com/repos/propelorm/Propel2/pulls/comments/11394001"},"html":{"href":"https://github.com/propelorm/Propel2/pull/595#discussion_r11394001"},"pull_request":{"href":"https://api.github.com/repos/propelorm/Propel2/pulls/595"}}}}