GitHub PushEvent at 2014-10-14 02:19:24
Repository: devstack
Actor: citrix-openstack-build
Payload: {"shas":[["9a706107d6603c9a13c8ec128b6f0ca397492f02","941760a5d79f418fbb85781c6e644b268f4c9136@redhat.com","Set Glance default_store to rbd in [glance_store]\n\nGlance is moving from [DEFAULT] to [glance_store] for this option.\nSince lib/glance sets both, let's also set it in both places for now.\n\nFailing to do this causes g-api to fail to start with error:\n\"Store for scheme swift not found\"\n\nChange-Id: I9e33ababf7c51f5c750f90b8b366b9892bb4c8cd","Eric Harney",true],["cc87c2871dc436b2134f60e9fa4663723a094ebd","2e29fdac69a2c4ead0c3572787471996847537ac@hp.com","local.conf processing doesn't handle '=' in values\n\nWhen attempting to add a libvirt section with a volume_drivers entry\nto $NOVA_CONF, via a post-config block in the local.conf file, I\nencountered problems; the value for this attribute takes the form\n\n    driver=python.import.path.to.driver\n\nbut the value actually populated in the $NOVA_CONF was truncated at the\nequals.\n\nTaking the iscsi driver setting specified in the official nova.conf\ndocumentation as an example, if I have the following in my local.conf\nfile:\n\n[[post-config|$NOVA_CONF]]\n[libvirt]\nvolume_drivers = iscsi=nova.virt.libvirt.volume.LibvirtISCSIVolumeDriver\n\nI will see that the generated $NOVA_CONF has the following:\n\n[libvirt]\nvolume_driver = iscsi\n\nThis occurs because the existing handling for a post-config setion, as\nimplemented in merge_config_file(), splits the line on the equals sign,\nand then uses the first and seconds elements of the resulting array as\nattribute name and value respectively.\n\nHowever when an equals occurs as part of the value this results in the\nvalue being truncated at the first equals in the value.\n\nThe fix I've implemented, based upon review feedback, extracts the\ncontents of $0 before the first equals as the attr name, and extracts\nthe remainder after the equals as the value. Then it strips the leading\nand trailing whitespaces from both as appropriate.\n\nI've also added test5 to tests/test_config.sh to test for, and verify,\ncorrect operation when this scenario is encountered.  Similarly I've\nadded test6 to ensure that trailing spaces in values are stripped\ncorrectly.\n\nChange-Id: Id0cb1e6e1cece21bc5dbf427c4d756af86fbd927\nCloses-Bug: #1374482","Fergal Mc Carthy",true],["50381a46e8e09c8743bae8d002499aa846fc671f","d95b56ce41a2e1ac4cecdd398defd7414407cc08@review.openstack.org","Merge \"Set Glance default_store to rbd in [glance_store]\"","Jenkins",true],["e6f4ad7c3e6b8336672e042ac46dc73635774c1a","d95b56ce41a2e1ac4cecdd398defd7414407cc08@review.openstack.org","Merge \"local.conf processing doesn't handle '=' in values\"","Jenkins",true],["2b09ac5c038acb50e85dda0c1eacebab5cccd636","d95b56ce41a2e1ac4cecdd398defd7414407cc08@silicon.eng.hq.xensource.com","Merge commit 'refs/changes/03/127603/1' of git://gold.eng.hq.xensource.com/git/github/openstack-dev/devstack into tmpbranch","jenkins@silicon.eng.hq.xensource.com",true]],"size":5,"ref":"refs/heads/ctx-nova-network-smoke-latest","head":"2b09ac5c038acb50e85dda0c1eacebab5cccd636"}