GitHub PullRequestEvent at 2014-07-04 16:40:56
Repository: squeel
Actor: bigxiang
Payload: {"action":"opened","number":317,"pull_request":{"url":"https://api.github.com/repos/activerecord-hackery/squeel/pulls/317","id":18000953,"html_url":"https://github.com/activerecord-hackery/squeel/pull/317","diff_url":"https://github.com/activerecord-hackery/squeel/pull/317.diff","patch_url":"https://github.com/activerecord-hackery/squeel/pull/317.patch","issue_url":"https://api.github.com/repos/activerecord-hackery/squeel/issues/317","number":317,"state":"open","title":"Make Squeel compatible with Rails 4.1 and Rails 4.2.0.alpha","user":{"login":"bigxiang","id":289683,"avatar_url":"https://avatars.githubusercontent.com/u/289683?","gravatar_id":"1e192c011bd59b40d0ce6494cab40c9a","url":"https://api.github.com/users/bigxiang","html_url":"https://github.com/bigxiang","followers_url":"https://api.github.com/users/bigxiang/followers","following_url":"https://api.github.com/users/bigxiang/following{/other_user}","gists_url":"https://api.github.com/users/bigxiang/gists{/gist_id}","starred_url":"https://api.github.com/users/bigxiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigxiang/subscriptions","organizations_url":"https://api.github.com/users/bigxiang/orgs","repos_url":"https://api.github.com/users/bigxiang/repos","events_url":"https://api.github.com/users/bigxiang/events{/privacy}","received_events_url":"https://api.github.com/users/bigxiang/received_events","type":"User","site_admin":false},"body":"Hi @ernie, @radar, @jonatack\r\n\r\nI had made a lot of changes and managed to pass all tests on all versions of Ruby 1.9.3+ and Rails 3+. But I think I indeed need your help because I really pushed a large commit, I don't want to mess anything. Would you please take a check, if you have any questions, we can discuss here.\r\n\r\nIt should solve #301, #305, #307 one time. \r\n\r\nMajor Changes:\r\n- Remove machinist, make model generation more robust and simpler\r\n- Use polyamorous master because it was just updated\r\n- Brand new Context class, because JoinAssociation changed a lot\r\n- Add 4.1 and 4.2 folders under adapters\r\n- Add some ! methods to visitors, so that we can throw some unexpected behaviors from them\r\n- Split specs into 3.x-4.0, 4.1, 4.2 folders in order to make tests easier\r\n- Make all specs green from Rails 3.0\r\n- Pend few specs because of unnecessary behaviors on Rails 4.1 & 4.2 I think\r\n\r\nThank you very much.","created_at":"2014-07-04T16:40:56Z","updated_at":"2014-07-04T16:40:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/activerecord-hackery/squeel/pulls/317/commits","review_comments_url":"https://api.github.com/repos/activerecord-hackery/squeel/pulls/317/comments","review_comment_url":"https://api.github.com/repos/activerecord-hackery/squeel/pulls/comments/{number}","comments_url":"https://api.github.com/repos/activerecord-hackery/squeel/issues/317/comments","statuses_url":"https://api.github.com/repos/activerecord-hackery/squeel/statuses/d4cba872ca8b31234de18faf8465d695beeeee5e","head":{"label":"bigxiang:ruby-2-rails-edge","ref":"ruby-2-rails-edge","sha":"d4cba872ca8b31234de18faf8465d695beeeee5e","user":{"login":"bigxiang","id":289683,"avatar_url":"https://avatars.githubusercontent.com/u/289683?","gravatar_id":"1e192c011bd59b40d0ce6494cab40c9a","url":"https://api.github.com/users/bigxiang","html_url":"https://github.com/bigxiang","followers_url":"https://api.github.com/users/bigxiang/followers","following_url":"https://api.github.com/users/bigxiang/following{/other_user}","gists_url":"https://api.github.com/users/bigxiang/gists{/gist_id}","starred_url":"https://api.github.com/users/bigxiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigxiang/subscriptions","organizations_url":"https://api.github.com/users/bigxiang/orgs","repos_url":"https://api.github.com/users/bigxiang/repos","events_url":"https://api.github.com/users/bigxiang/events{/privacy}","received_events_url":"https://api.github.com/users/bigxiang/received_events","type":"User","site_admin":false},"repo":{"id":21203929,"name":"squeel","full_name":"bigxiang/squeel","owner":{"login":"bigxiang","id":289683,"avatar_url":"https://avatars.githubusercontent.com/u/289683?","gravatar_id":"1e192c011bd59b40d0ce6494cab40c9a","url":"https://api.github.com/users/bigxiang","html_url":"https://github.com/bigxiang","followers_url":"https://api.github.com/users/bigxiang/followers","following_url":"https://api.github.com/users/bigxiang/following{/other_user}","gists_url":"https://api.github.com/users/bigxiang/gists{/gist_id}","starred_url":"https://api.github.com/users/bigxiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigxiang/subscriptions","organizations_url":"https://api.github.com/users/bigxiang/orgs","repos_url":"https://api.github.com/users/bigxiang/repos","events_url":"https://api.github.com/users/bigxiang/events{/privacy}","received_events_url":"https://api.github.com/users/bigxiang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bigxiang/squeel","description":"Active Record, improved. Not currently maintained.","fork":true,"url":"https://api.github.com/repos/bigxiang/squeel","forks_url":"https://api.github.com/repos/bigxiang/squeel/forks","keys_url":"https://api.github.com/repos/bigxiang/squeel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bigxiang/squeel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bigxiang/squeel/teams","hooks_url":"https://api.github.com/repos/bigxiang/squeel/hooks","issue_events_url":"https://api.github.com/repos/bigxiang/squeel/issues/events{/number}","events_url":"https://api.github.com/repos/bigxiang/squeel/events","assignees_url":"https://api.github.com/repos/bigxiang/squeel/assignees{/user}","branches_url":"https://api.github.com/repos/bigxiang/squeel/branches{/branch}","tags_url":"https://api.github.com/repos/bigxiang/squeel/tags","blobs_url":"https://api.github.com/repos/bigxiang/squeel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bigxiang/squeel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bigxiang/squeel/git/refs{/sha}","trees_url":"https://api.github.com/repos/bigxiang/squeel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bigxiang/squeel/statuses/{sha}","languages_url":"https://api.github.com/repos/bigxiang/squeel/languages","stargazers_url":"https://api.github.com/repos/bigxiang/squeel/stargazers","contributors_url":"https://api.github.com/repos/bigxiang/squeel/contributors","subscribers_url":"https://api.github.com/repos/bigxiang/squeel/subscribers","subscription_url":"https://api.github.com/repos/bigxiang/squeel/subscription","commits_url":"https://api.github.com/repos/bigxiang/squeel/commits{/sha}","git_commits_url":"https://api.github.com/repos/bigxiang/squeel/git/commits{/sha}","comments_url":"https://api.github.com/repos/bigxiang/squeel/comments{/number}","issue_comment_url":"https://api.github.com/repos/bigxiang/squeel/issues/comments/{number}","contents_url":"https://api.github.com/repos/bigxiang/squeel/contents/{+path}","compare_url":"https://api.github.com/repos/bigxiang/squeel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bigxiang/squeel/merges","archive_url":"https://api.github.com/repos/bigxiang/squeel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bigxiang/squeel/downloads","issues_url":"https://api.github.com/repos/bigxiang/squeel/issues{/number}","pulls_url":"https://api.github.com/repos/bigxiang/squeel/pulls{/number}","milestones_url":"https://api.github.com/repos/bigxiang/squeel/milestones{/number}","notifications_url":"https://api.github.com/repos/bigxiang/squeel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bigxiang/squeel/labels{/name}","releases_url":"https://api.github.com/repos/bigxiang/squeel/releases{/id}","created_at":"2014-06-25T13:21:14Z","updated_at":"2014-06-23T01:40:21Z","pushed_at":"2014-07-04T16:26:07Z","git_url":"git://github.com/bigxiang/squeel.git","ssh_url":"git@github.com:bigxiang/squeel.git","clone_url":"https://github.com/bigxiang/squeel.git","svn_url":"https://github.com/bigxiang/squeel","homepage":"http://erniemiller.org/2013/11/17/anyone-interested-in-activerecord-hackery/","size":1478,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"activerecord-hackery:master","ref":"master","sha":"1357f76597d6f97e9f0b6513343a44f27c04a1ee","user":{"login":"activerecord-hackery","id":5951504,"avatar_url":"https://avatars.githubusercontent.com/u/5951504?","gravatar_id":null,"url":"https://api.github.com/users/activerecord-hackery","html_url":"https://github.com/activerecord-hackery","followers_url":"https://api.github.com/users/activerecord-hackery/followers","following_url":"https://api.github.com/users/activerecord-hackery/following{/other_user}","gists_url":"https://api.github.com/users/activerecord-hackery/gists{/gist_id}","starred_url":"https://api.github.com/users/activerecord-hackery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/activerecord-hackery/subscriptions","organizations_url":"https://api.github.com/users/activerecord-hackery/orgs","repos_url":"https://api.github.com/users/activerecord-hackery/repos","events_url":"https://api.github.com/users/activerecord-hackery/events{/privacy}","received_events_url":"https://api.github.com/users/activerecord-hackery/received_events","type":"Organization","site_admin":false},"repo":{"id":1591828,"name":"squeel","full_name":"activerecord-hackery/squeel","owner":{"login":"activerecord-hackery","id":5951504,"avatar_url":"https://avatars.githubusercontent.com/u/5951504?","gravatar_id":null,"url":"https://api.github.com/users/activerecord-hackery","html_url":"https://github.com/activerecord-hackery","followers_url":"https://api.github.com/users/activerecord-hackery/followers","following_url":"https://api.github.com/users/activerecord-hackery/following{/other_user}","gists_url":"https://api.github.com/users/activerecord-hackery/gists{/gist_id}","starred_url":"https://api.github.com/users/activerecord-hackery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/activerecord-hackery/subscriptions","organizations_url":"https://api.github.com/users/activerecord-hackery/orgs","repos_url":"https://api.github.com/users/activerecord-hackery/repos","events_url":"https://api.github.com/users/activerecord-hackery/events{/privacy}","received_events_url":"https://api.github.com/users/activerecord-hackery/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/activerecord-hackery/squeel","description":"Active Record, improved. Not currently maintained.","fork":false,"url":"https://api.github.com/repos/activerecord-hackery/squeel","forks_url":"https://api.github.com/repos/activerecord-hackery/squeel/forks","keys_url":"https://api.github.com/repos/activerecord-hackery/squeel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/activerecord-hackery/squeel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/activerecord-hackery/squeel/teams","hooks_url":"https://api.github.com/repos/activerecord-hackery/squeel/hooks","issue_events_url":"https://api.github.com/repos/activerecord-hackery/squeel/issues/events{/number}","events_url":"https://api.github.com/repos/activerecord-hackery/squeel/events","assignees_url":"https://api.github.com/repos/activerecord-hackery/squeel/assignees{/user}","branches_url":"https://api.github.com/repos/activerecord-hackery/squeel/branches{/branch}","tags_url":"https://api.github.com/repos/activerecord-hackery/squeel/tags","blobs_url":"https://api.github.com/repos/activerecord-hackery/squeel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/activerecord-hackery/squeel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/activerecord-hackery/squeel/git/refs{/sha}","trees_url":"https://api.github.com/repos/activerecord-hackery/squeel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/activerecord-hackery/squeel/statuses/{sha}","languages_url":"https://api.github.com/repos/activerecord-hackery/squeel/languages","stargazers_url":"https://api.github.com/repos/activerecord-hackery/squeel/stargazers","contributors_url":"https://api.github.com/repos/activerecord-hackery/squeel/contributors","subscribers_url":"https://api.github.com/repos/activerecord-hackery/squeel/subscribers","subscription_url":"https://api.github.com/repos/activerecord-hackery/squeel/subscription","commits_url":"https://api.github.com/repos/activerecord-hackery/squeel/commits{/sha}","git_commits_url":"https://api.github.com/repos/activerecord-hackery/squeel/git/commits{/sha}","comments_url":"https://api.github.com/repos/activerecord-hackery/squeel/comments{/number}","issue_comment_url":"https://api.github.com/repos/activerecord-hackery/squeel/issues/comments/{number}","contents_url":"https://api.github.com/repos/activerecord-hackery/squeel/contents/{+path}","compare_url":"https://api.github.com/repos/activerecord-hackery/squeel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/activerecord-hackery/squeel/merges","archive_url":"https://api.github.com/repos/activerecord-hackery/squeel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/activerecord-hackery/squeel/downloads","issues_url":"https://api.github.com/repos/activerecord-hackery/squeel/issues{/number}","pulls_url":"https://api.github.com/repos/activerecord-hackery/squeel/pulls{/number}","milestones_url":"https://api.github.com/repos/activerecord-hackery/squeel/milestones{/number}","notifications_url":"https://api.github.com/repos/activerecord-hackery/squeel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/activerecord-hackery/squeel/labels{/name}","releases_url":"https://api.github.com/repos/activerecord-hackery/squeel/releases{/id}","created_at":"2011-04-09T15:41:39Z","updated_at":"2014-07-01T13:56:11Z","pushed_at":"2014-07-03T03:13:28Z","git_url":"git://github.com/activerecord-hackery/squeel.git","ssh_url":"git@github.com:activerecord-hackery/squeel.git","clone_url":"https://github.com/activerecord-hackery/squeel.git","svn_url":"https://github.com/activerecord-hackery/squeel","homepage":"http://erniemiller.org/2013/11/17/anyone-interested-in-activerecord-hackery/","size":1478,"stargazers_count":1663,"watchers_count":1663,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":130,"mirror_url":null,"open_issues_count":31,"forks":130,"open_issues":31,"watchers":1663,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/activerecord-hackery/squeel/pulls/317"},"html":{"href":"https://github.com/activerecord-hackery/squeel/pull/317"},"issue":{"href":"https://api.github.com/repos/activerecord-hackery/squeel/issues/317"},"comments":{"href":"https://api.github.com/repos/activerecord-hackery/squeel/issues/317/comments"},"review_comments":{"href":"https://api.github.com/repos/activerecord-hackery/squeel/pulls/317/comments"},"review_comment":{"href":"https://api.github.com/repos/activerecord-hackery/squeel/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/activerecord-hackery/squeel/pulls/317/commits"},"statuses":{"href":"https://api.github.com/repos/activerecord-hackery/squeel/statuses/d4cba872ca8b31234de18faf8465d695beeeee5e"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":4164,"deletions":1135,"changed_files":63}}