GitHub PullRequestReviewCommentEvent at 2014-08-20 07:09:01
Repository: Dynamo
Actor: Benglin
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments/16461443","id":16461443,"diff_hunk":"@@ -108,8 +112,86 @@ public BrowserInternalElement(string name, BrowserItem parent)\n             this.OldParent = null;\n         }\n \n-\n         public string FullCategoryName { get; set; }\n     }\n-}\n \n+    public class ClassInformation : BrowserItem\n+    {\n+        #region BrowserItem abstract members implementation \n+\n+        public override ObservableCollection<BrowserItem> Items\n+        {\n+            get\n+            {\n+                throw new System.NotImplementedException();\n+            }\n+            set\n+            {\n+                throw new System.NotImplementedException();\n+            }\n+        }\n+\n+        public override string Name\n+        {\n+            get { throw new System.NotImplementedException(); }\n+        }\n+\n+        #endregion\n+\n+        /// <summary>\n+        /// Specifies whether or not instance should be shown as StandardPanel.\n+        /// </summary>\n+        public bool ClassDetailsVisibility { get; set; }\n+","path":"src/DynamoCore/Search/BrowserInternalElement.cs","position":68,"original_position":68,"commit_id":"e941a34796857c8ac83b2d94446daf90942d1769","original_commit_id":"e941a34796857c8ac83b2d94446daf90942d1769","user":{"login":"Benglin","id":5086849,"avatar_url":"https://avatars.githubusercontent.com/u/5086849?v=2","gravatar_id":"9b45bac5e0d757c447728c9343c0cd08","url":"https://api.github.com/users/Benglin","html_url":"https://github.com/Benglin","followers_url":"https://api.github.com/users/Benglin/followers","following_url":"https://api.github.com/users/Benglin/following{/other_user}","gists_url":"https://api.github.com/users/Benglin/gists{/gist_id}","starred_url":"https://api.github.com/users/Benglin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Benglin/subscriptions","organizations_url":"https://api.github.com/users/Benglin/orgs","repos_url":"https://api.github.com/users/Benglin/repos","events_url":"https://api.github.com/users/Benglin/events{/privacy}","received_events_url":"https://api.github.com/users/Benglin/received_events","type":"User","site_admin":false},"body":"Since ```CreateMembers```, ```ActionMembers``` and ```QueryMembers``` are not going to be changed during runtime (for a given time it is bound to the view), can you try to update these properties to return ```IEnumerable<BrowserInternalElement>```? If that is working, please change the internal data members ```ObservableCollection<BrowserInternalElement>``` to just ```List<BrowserInternalElement>```.","created_at":"2014-08-20T07:09:01Z","updated_at":"2014-08-20T07:09:01Z","html_url":"https://github.com/DynamoDS/Dynamo/pull/2139#discussion_r16461443","pull_request_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/2139","_links":{"self":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments/16461443"},"html":{"href":"https://github.com/DynamoDS/Dynamo/pull/2139#discussion_r16461443"},"pull_request":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/2139"}}},"pull_request":{"url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/2139","id":19636016,"html_url":"https://github.com/DynamoDS/Dynamo/pull/2139","diff_url":"https://github.com/DynamoDS/Dynamo/pull/2139.diff","patch_url":"https://github.com/DynamoDS/Dynamo/pull/2139.patch","issue_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/2139","number":2139,"state":"open","locked":false,"title":"New design is bound to BrowserRootCategories collection","user":{"login":"vmoyseenko","id":8158551,"avatar_url":"https://avatars.githubusercontent.com/u/8158551?v=2","gravatar_id":"36a52d5cac7b87be43c5675faa07cf2f","url":"https://api.github.com/users/vmoyseenko","html_url":"https://github.com/vmoyseenko","followers_url":"https://api.github.com/users/vmoyseenko/followers","following_url":"https://api.github.com/users/vmoyseenko/following{/other_user}","gists_url":"https://api.github.com/users/vmoyseenko/gists{/gist_id}","starred_url":"https://api.github.com/users/vmoyseenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmoyseenko/subscriptions","organizations_url":"https://api.github.com/users/vmoyseenko/orgs","repos_url":"https://api.github.com/users/vmoyseenko/repos","events_url":"https://api.github.com/users/vmoyseenko/events{/privacy}","received_events_url":"https://api.github.com/users/vmoyseenko/received_events","type":"User","site_admin":false},"body":"New design is bound to BrowserRootCategories collection. There are some bugs but we have something to show. Works correctly for Geometry category. Possible too long names of some functions. For example: `Geometry.Cuboid`.\r\n\r\n@Benglin, please review.","created_at":"2014-08-12T00:09:01Z","updated_at":"2014-08-20T07:09:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"00bab22656929a253eba94e1cde4f165df7b0e55","assignee":{"login":"Benglin","id":5086849,"avatar_url":"https://avatars.githubusercontent.com/u/5086849?v=2","gravatar_id":"9b45bac5e0d757c447728c9343c0cd08","url":"https://api.github.com/users/Benglin","html_url":"https://github.com/Benglin","followers_url":"https://api.github.com/users/Benglin/followers","following_url":"https://api.github.com/users/Benglin/following{/other_user}","gists_url":"https://api.github.com/users/Benglin/gists{/gist_id}","starred_url":"https://api.github.com/users/Benglin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Benglin/subscriptions","organizations_url":"https://api.github.com/users/Benglin/orgs","repos_url":"https://api.github.com/users/Benglin/repos","events_url":"https://api.github.com/users/Benglin/events{/privacy}","received_events_url":"https://api.github.com/users/Benglin/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/2139/commits","review_comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/2139/comments","review_comment_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments/{number}","comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/2139/comments","statuses_url":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/e941a34796857c8ac83b2d94446daf90942d1769","head":{"label":"vmoyseenko:BrowserRootCategoriesBinding","ref":"BrowserRootCategoriesBinding","sha":"e941a34796857c8ac83b2d94446daf90942d1769","user":{"login":"vmoyseenko","id":8158551,"avatar_url":"https://avatars.githubusercontent.com/u/8158551?v=2","gravatar_id":"36a52d5cac7b87be43c5675faa07cf2f","url":"https://api.github.com/users/vmoyseenko","html_url":"https://github.com/vmoyseenko","followers_url":"https://api.github.com/users/vmoyseenko/followers","following_url":"https://api.github.com/users/vmoyseenko/following{/other_user}","gists_url":"https://api.github.com/users/vmoyseenko/gists{/gist_id}","starred_url":"https://api.github.com/users/vmoyseenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmoyseenko/subscriptions","organizations_url":"https://api.github.com/users/vmoyseenko/orgs","repos_url":"https://api.github.com/users/vmoyseenko/repos","events_url":"https://api.github.com/users/vmoyseenko/events{/privacy}","received_events_url":"https://api.github.com/users/vmoyseenko/received_events","type":"User","site_admin":false},"repo":{"id":21822485,"name":"Dynamo","full_name":"vmoyseenko/Dynamo","owner":{"login":"vmoyseenko","id":8158551,"avatar_url":"https://avatars.githubusercontent.com/u/8158551?v=2","gravatar_id":"36a52d5cac7b87be43c5675faa07cf2f","url":"https://api.github.com/users/vmoyseenko","html_url":"https://github.com/vmoyseenko","followers_url":"https://api.github.com/users/vmoyseenko/followers","following_url":"https://api.github.com/users/vmoyseenko/following{/other_user}","gists_url":"https://api.github.com/users/vmoyseenko/gists{/gist_id}","starred_url":"https://api.github.com/users/vmoyseenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmoyseenko/subscriptions","organizations_url":"https://api.github.com/users/vmoyseenko/orgs","repos_url":"https://api.github.com/users/vmoyseenko/repos","events_url":"https://api.github.com/users/vmoyseenko/events{/privacy}","received_events_url":"https://api.github.com/users/vmoyseenko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vmoyseenko/Dynamo","description":"Visual Programming For Revit","fork":true,"url":"https://api.github.com/repos/vmoyseenko/Dynamo","forks_url":"https://api.github.com/repos/vmoyseenko/Dynamo/forks","keys_url":"https://api.github.com/repos/vmoyseenko/Dynamo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vmoyseenko/Dynamo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vmoyseenko/Dynamo/teams","hooks_url":"https://api.github.com/repos/vmoyseenko/Dynamo/hooks","issue_events_url":"https://api.github.com/repos/vmoyseenko/Dynamo/issues/events{/number}","events_url":"https://api.github.com/repos/vmoyseenko/Dynamo/events","assignees_url":"https://api.github.com/repos/vmoyseenko/Dynamo/assignees{/user}","branches_url":"https://api.github.com/repos/vmoyseenko/Dynamo/branches{/branch}","tags_url":"https://api.github.com/repos/vmoyseenko/Dynamo/tags","blobs_url":"https://api.github.com/repos/vmoyseenko/Dynamo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vmoyseenko/Dynamo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vmoyseenko/Dynamo/git/refs{/sha}","trees_url":"https://api.github.com/repos/vmoyseenko/Dynamo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vmoyseenko/Dynamo/statuses/{sha}","languages_url":"https://api.github.com/repos/vmoyseenko/Dynamo/languages","stargazers_url":"https://api.github.com/repos/vmoyseenko/Dynamo/stargazers","contributors_url":"https://api.github.com/repos/vmoyseenko/Dynamo/contributors","subscribers_url":"https://api.github.com/repos/vmoyseenko/Dynamo/subscribers","subscription_url":"https://api.github.com/repos/vmoyseenko/Dynamo/subscription","commits_url":"https://api.github.com/repos/vmoyseenko/Dynamo/commits{/sha}","git_commits_url":"https://api.github.com/repos/vmoyseenko/Dynamo/git/commits{/sha}","comments_url":"https://api.github.com/repos/vmoyseenko/Dynamo/comments{/number}","issue_comment_url":"https://api.github.com/repos/vmoyseenko/Dynamo/issues/comments/{number}","contents_url":"https://api.github.com/repos/vmoyseenko/Dynamo/contents/{+path}","compare_url":"https://api.github.com/repos/vmoyseenko/Dynamo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vmoyseenko/Dynamo/merges","archive_url":"https://api.github.com/repos/vmoyseenko/Dynamo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vmoyseenko/Dynamo/downloads","issues_url":"https://api.github.com/repos/vmoyseenko/Dynamo/issues{/number}","pulls_url":"https://api.github.com/repos/vmoyseenko/Dynamo/pulls{/number}","milestones_url":"https://api.github.com/repos/vmoyseenko/Dynamo/milestones{/number}","notifications_url":"https://api.github.com/repos/vmoyseenko/Dynamo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vmoyseenko/Dynamo/labels{/name}","releases_url":"https://api.github.com/repos/vmoyseenko/Dynamo/releases{/id}","created_at":"2014-07-14T14:27:39Z","updated_at":"2014-07-29T14:57:09Z","pushed_at":"2014-08-19T14:34:00Z","git_url":"git://github.com/vmoyseenko/Dynamo.git","ssh_url":"git@github.com:vmoyseenko/Dynamo.git","clone_url":"https://github.com/vmoyseenko/Dynamo.git","svn_url":"https://github.com/vmoyseenko/Dynamo","homepage":"http://dynamobim.org","size":556451,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DynamoDS:Sitrus","ref":"Sitrus","sha":"92d887b20f41d5e984622395b050ac9785a151ff","user":{"login":"DynamoDS","id":6528209,"avatar_url":"https://avatars.githubusercontent.com/u/6528209?v=2","gravatar_id":null,"url":"https://api.github.com/users/DynamoDS","html_url":"https://github.com/DynamoDS","followers_url":"https://api.github.com/users/DynamoDS/followers","following_url":"https://api.github.com/users/DynamoDS/following{/other_user}","gists_url":"https://api.github.com/users/DynamoDS/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoDS/subscriptions","organizations_url":"https://api.github.com/users/DynamoDS/orgs","repos_url":"https://api.github.com/users/DynamoDS/repos","events_url":"https://api.github.com/users/DynamoDS/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoDS/received_events","type":"Organization","site_admin":false},"repo":{"id":3395179,"name":"Dynamo","full_name":"DynamoDS/Dynamo","owner":{"login":"DynamoDS","id":6528209,"avatar_url":"https://avatars.githubusercontent.com/u/6528209?v=2","gravatar_id":null,"url":"https://api.github.com/users/DynamoDS","html_url":"https://github.com/DynamoDS","followers_url":"https://api.github.com/users/DynamoDS/followers","following_url":"https://api.github.com/users/DynamoDS/following{/other_user}","gists_url":"https://api.github.com/users/DynamoDS/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoDS/subscriptions","organizations_url":"https://api.github.com/users/DynamoDS/orgs","repos_url":"https://api.github.com/users/DynamoDS/repos","events_url":"https://api.github.com/users/DynamoDS/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoDS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DynamoDS/Dynamo","description":"Visual Programming For Revit","fork":false,"url":"https://api.github.com/repos/DynamoDS/Dynamo","forks_url":"https://api.github.com/repos/DynamoDS/Dynamo/forks","keys_url":"https://api.github.com/repos/DynamoDS/Dynamo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DynamoDS/Dynamo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DynamoDS/Dynamo/teams","hooks_url":"https://api.github.com/repos/DynamoDS/Dynamo/hooks","issue_events_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/events{/number}","events_url":"https://api.github.com/repos/DynamoDS/Dynamo/events","assignees_url":"https://api.github.com/repos/DynamoDS/Dynamo/assignees{/user}","branches_url":"https://api.github.com/repos/DynamoDS/Dynamo/branches{/branch}","tags_url":"https://api.github.com/repos/DynamoDS/Dynamo/tags","blobs_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/refs{/sha}","trees_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/{sha}","languages_url":"https://api.github.com/repos/DynamoDS/Dynamo/languages","stargazers_url":"https://api.github.com/repos/DynamoDS/Dynamo/stargazers","contributors_url":"https://api.github.com/repos/DynamoDS/Dynamo/contributors","subscribers_url":"https://api.github.com/repos/DynamoDS/Dynamo/subscribers","subscription_url":"https://api.github.com/repos/DynamoDS/Dynamo/subscription","commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/commits{/sha}","git_commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/commits{/sha}","comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/comments{/number}","issue_comment_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/comments/{number}","contents_url":"https://api.github.com/repos/DynamoDS/Dynamo/contents/{+path}","compare_url":"https://api.github.com/repos/DynamoDS/Dynamo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DynamoDS/Dynamo/merges","archive_url":"https://api.github.com/repos/DynamoDS/Dynamo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DynamoDS/Dynamo/downloads","issues_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues{/number}","pulls_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls{/number}","milestones_url":"https://api.github.com/repos/DynamoDS/Dynamo/milestones{/number}","notifications_url":"https://api.github.com/repos/DynamoDS/Dynamo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DynamoDS/Dynamo/labels{/name}","releases_url":"https://api.github.com/repos/DynamoDS/Dynamo/releases{/id}","created_at":"2012-02-09T07:35:33Z","updated_at":"2014-08-12T01:58:43Z","pushed_at":"2014-08-20T05:40:21Z","git_url":"git://github.com/DynamoDS/Dynamo.git","ssh_url":"git@github.com:DynamoDS/Dynamo.git","clone_url":"https://github.com/DynamoDS/Dynamo.git","svn_url":"https://github.com/DynamoDS/Dynamo","homepage":"http://dynamobim.org","size":709082,"stargazers_count":129,"watchers_count":129,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":100,"mirror_url":null,"open_issues_count":366,"forks":100,"open_issues":366,"watchers":129,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/2139"},"html":{"href":"https://github.com/DynamoDS/Dynamo/pull/2139"},"issue":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/issues/2139"},"comments":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/issues/2139/comments"},"review_comments":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/2139/comments"},"review_comment":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/2139/commits"},"statuses":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/e941a34796857c8ac83b2d94446daf90942d1769"}}}}