GitHub PullRequestReviewCommentEvent at 2014-11-12 20:40:56
Repository: spring-integration-extensions
Actor: ilayaperumalg
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/spring-projects/spring-integration-extensions/pulls/comments/20248948","id":20248948,"diff_hunk":"@@ -0,0 +1,47 @@\n+/*\n+ * Copyright 2002-2014 the original author or authors.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *      http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package org.springframework.integration.kafka.serializer.common;\n+\n+import java.util.Properties;\n+\n+import kafka.serializer.Decoder;\n+import kafka.utils.VerifiableProperties;\n+\n+\n+/**\n+ * String Decoder for Kafka message key/value decoding.\n+ * The Default decoder returns the same byte array it takes in.\n+ *\n+ * @author Soby Chacko\n+ */\n+public class StringDecoder implements Decoder<String> {\n+\n+\tprivate String encoding = \"UTF8\";\n+\n+\tpublic void setEncoding(final String encoding) {\n+\t\tthis.encoding = encoding;\n+\t}\n+\n+\t@Override\n+\tpublic String fromBytes(byte[] bytes) {\n+\t\tfinal Properties props = new Properties();\n+\t\tprops.put(\"serializer.encoding\", encoding);\n+\n+\t\tfinal VerifiableProperties verifiableProperties = new VerifiableProperties(props);\n+\t\treturn new kafka.serializer.StringDecoder(verifiableProperties).fromBytes(bytes);","path":"spring-integration-kafka/src/main/java/org/springframework/integration/kafka/serializer/common/StringDecoder.java","position":44,"original_position":44,"commit_id":"3b6baa7684153492a6df25779976e55b34a80645","original_commit_id":"3b6baa7684153492a6df25779976e55b34a80645","user":{"login":"ilayaperumalg","id":151690,"avatar_url":"https://avatars.githubusercontent.com/u/151690?v=3","gravatar_id":"","url":"https://api.github.com/users/ilayaperumalg","html_url":"https://github.com/ilayaperumalg","followers_url":"https://api.github.com/users/ilayaperumalg/followers","following_url":"https://api.github.com/users/ilayaperumalg/following{/other_user}","gists_url":"https://api.github.com/users/ilayaperumalg/gists{/gist_id}","starred_url":"https://api.github.com/users/ilayaperumalg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilayaperumalg/subscriptions","organizations_url":"https://api.github.com/users/ilayaperumalg/orgs","repos_url":"https://api.github.com/users/ilayaperumalg/repos","events_url":"https://api.github.com/users/ilayaperumalg/events{/privacy}","received_events_url":"https://api.github.com/users/ilayaperumalg/received_events","type":"User","site_admin":false},"body":"I see your point, will fix it shortly.","created_at":"2014-11-12T20:40:56Z","updated_at":"2014-11-12T20:40:56Z","html_url":"https://github.com/spring-projects/spring-integration-extensions/pull/131#discussion_r20248948","pull_request_url":"https://api.github.com/repos/spring-projects/spring-integration-extensions/pulls/131","_links":{"self":{"href":"https://api.github.com/repos/spring-projects/spring-integration-extensions/pulls/comments/20248948"},"html":{"href":"https://github.com/spring-projects/spring-integration-extensions/pull/131#discussion_r20248948"},"pull_request":{"href":"https://api.github.com/repos/spring-projects/spring-integration-extensions/pulls/131"}}},"pull_request":{"url":"https://api.github.com/repos/spring-projects/spring-integration-extensions/pulls/131","id":24321924,"html_url":"https://github.com/spring-projects/spring-integration-extensions/pull/131","diff_url":"https://github.com/spring-projects/spring-integration-extensions/pull/131.diff","patch_url":"https://github.com/spring-projects/spring-integration-extensions/pull/131.patch","issue_url":"https://api.github.com/repos/spring-projects/spring-integration-extensions/issues/131","number":131,"state":"open","locked":false,"title":"Add StringDecoder for kafka messages","user":{"login":"ilayaperumalg","id":151690,"avatar_url":"https://avatars.githubusercontent.com/u/151690?v=3","gravatar_id":"","url":"https://api.github.com/users/ilayaperumalg","html_url":"https://github.com/ilayaperumalg","followers_url":"https://api.github.com/users/ilayaperumalg/followers","following_url":"https://api.github.com/users/ilayaperumalg/following{/other_user}","gists_url":"https://api.github.com/users/ilayaperumalg/gists{/gist_id}","starred_url":"https://api.github.com/users/ilayaperumalg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilayaperumalg/subscriptions","organizations_url":"https://api.github.com/users/ilayaperumalg/orgs","repos_url":"https://api.github.com/users/ilayaperumalg/repos","events_url":"https://api.github.com/users/ilayaperumalg/events{/privacy}","received_events_url":"https://api.github.com/users/ilayaperumalg/received_events","type":"User","site_admin":false},"body":" - Add StringDecoder for decoding kafka key/value messages","created_at":"2014-11-12T20:24:26Z","updated_at":"2014-11-12T20:40:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"74ee96c469629367c0218c9a68c91b109126f33c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/spring-projects/spring-integration-extensions/pulls/131/commits","review_comments_url":"https://api.github.com/repos/spring-projects/spring-integration-extensions/pulls/131/comments","review_comment_url":"https://api.github.com/repos/spring-projects/spring-integration-extensions/pulls/comments/{number}","comments_url":"https://api.github.com/repos/spring-projects/spring-integration-extensions/issues/131/comments","statuses_url":"https://api.github.com/repos/spring-projects/spring-integration-extensions/statuses/3b6baa7684153492a6df25779976e55b34a80645","head":{"label":"ilayaperumalg:add-string-decoder","ref":"add-string-decoder","sha":"3b6baa7684153492a6df25779976e55b34a80645","user":{"login":"ilayaperumalg","id":151690,"avatar_url":"https://avatars.githubusercontent.com/u/151690?v=3","gravatar_id":"","url":"https://api.github.com/users/ilayaperumalg","html_url":"https://github.com/ilayaperumalg","followers_url":"https://api.github.com/users/ilayaperumalg/followers","following_url":"https://api.github.com/users/ilayaperumalg/following{/other_user}","gists_url":"https://api.github.com/users/ilayaperumalg/gists{/gist_id}","starred_url":"https://api.github.com/users/ilayaperumalg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilayaperumalg/subscriptions","organizations_url":"https://api.github.com/users/ilayaperumalg/orgs","repos_url":"https://api.github.com/users/ilayaperumalg/repos","events_url":"https://api.github.com/users/ilayaperumalg/events{/privacy}","received_events_url":"https://api.github.com/users/ilayaperumalg/received_events","type":"User","site_admin":false},"repo":{"id":16557568,"name":"spring-integration-extensions","full_name":"ilayaperumalg/spring-integration-extensions","owner":{"login":"ilayaperumalg","id":151690,"avatar_url":"https://avatars.githubusercontent.com/u/151690?v=3","gravatar_id":"","url":"https://api.github.com/users/ilayaperumalg","html_url":"https://github.com/ilayaperumalg","followers_url":"https://api.github.com/users/ilayaperumalg/followers","following_url":"https://api.github.com/users/ilayaperumalg/following{/other_user}","gists_url":"https://api.github.com/users/ilayaperumalg/gists{/gist_id}","starred_url":"https://api.github.com/users/ilayaperumalg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilayaperumalg/subscriptions","organizations_url":"https://api.github.com/users/ilayaperumalg/orgs","repos_url":"https://api.github.com/users/ilayaperumalg/repos","events_url":"https://api.github.com/users/ilayaperumalg/events{/privacy}","received_events_url":"https://api.github.com/users/ilayaperumalg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ilayaperumalg/spring-integration-extensions","description":"The Spring Integration Extensions project provides extension components for Spring Integration","fork":true,"url":"https://api.github.com/repos/ilayaperumalg/spring-integration-extensions","forks_url":"https://api.github.com/repos/ilayaperumalg/spring-integration-extensions/forks","keys_url":"https://api.github.com/repos/ilayaperumalg/spring-integration-extensions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ilayaperumalg/spring-integration-extensions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ilayaperumalg/spring-integration-extensions/teams","hooks_url":"https://api.github.com/repos/ilayaperumalg/spring-integration-extensions/hooks","issue_events_url":"https://api.github.com/repos/ilayaperumalg/spring-integration-extensions/issues/events{/number}","events_url":"https://api.github.com/repos/ilayaperumalg/spring-integration-extensions/events","assignees_url":"https://api.github.com/repos/ilayaperumalg/spring-integration-extensions/assignees{/user}","branches_url":"https://api.github.com/repos/ilayaperumalg/spring-integration-extensions/branches{/branch}","tags_url":"https://api.github.com/repos/ilayaperumalg/spring-integration-extensions/tags","blobs_url":"https://api.github.com/repos/ilayaperumalg/spring-integration-extensions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ilayaperumalg/spring-integration-extensions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ilayaperumalg/spring-integration-extensions/git/refs{/sha}","trees_url":"https://api.github.com/repos/ilayaperumalg/spring-integration-extensions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ilayaperumalg/spring-integration-extensions/statuses/{sha}","languages_url":"https://api.github.com/repos/ilayaperumalg/spring-integration-extensions/languages","stargazers_url":"https://api.github.com/repos/ilayaperumalg/spring-integration-extensions/stargazers","contributors_url":"https://api.github.com/repos/ilayaperumalg/spring-integration-extensions/contributors","subscribers_url":"https://api.github.com/repos/ilayaperumalg/spring-integration-extensions/subscribers","subscription_url":"https://api.github.com/repos/ilayaperumalg/spring-integration-extensions/subscription","commits_url":"https://api.github.com/repos/ilayaperumalg/spring-integration-extensions/commits{/sha}","git_commits_url":"https://api.github.com/repos/ilayaperumalg/spring-integration-extensions/git/commits{/sha}","comments_url":"https://api.github.com/repos/ilayaperumalg/spring-integration-extensions/comments{/number}","issue_comment_url":"https://api.github.com/repos/ilayaperumalg/spring-integration-extensions/issues/comments/{number}","contents_url":"https://api.github.com/repos/ilayaperumalg/spring-integration-extensions/contents/{+path}","compare_url":"https://api.github.com/repos/ilayaperumalg/spring-integration-extensions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ilayaperumalg/spring-integration-extensions/merges","archive_url":"https://api.github.com/repos/ilayaperumalg/spring-integration-extensions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ilayaperumalg/spring-integration-extensions/downloads","issues_url":"https://api.github.com/repos/ilayaperumalg/spring-integration-extensions/issues{/number}","pulls_url":"https://api.github.com/repos/ilayaperumalg/spring-integration-extensions/pulls{/number}","milestones_url":"https://api.github.com/repos/ilayaperumalg/spring-integration-extensions/milestones{/number}","notifications_url":"https://api.github.com/repos/ilayaperumalg/spring-integration-extensions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ilayaperumalg/spring-integration-extensions/labels{/name}","releases_url":"https://api.github.com/repos/ilayaperumalg/spring-integration-extensions/releases{/id}","created_at":"2014-02-05T20:40:05Z","updated_at":"2014-08-20T18:39:13Z","pushed_at":"2014-11-12T20:18:29Z","git_url":"git://github.com/ilayaperumalg/spring-integration-extensions.git","ssh_url":"git@github.com:ilayaperumalg/spring-integration-extensions.git","clone_url":"https://github.com/ilayaperumalg/spring-integration-extensions.git","svn_url":"https://github.com/ilayaperumalg/spring-integration-extensions","homepage":"http://www.springintegration.org/","size":1836,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-projects:master","ref":"master","sha":"bfdcd7ad1d86abb532274f6076f7285c541e11df","user":{"login":"spring-projects","id":317776,"avatar_url":"https://avatars.githubusercontent.com/u/317776?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"repo":{"id":4653065,"name":"spring-integration-extensions","full_name":"spring-projects/spring-integration-extensions","owner":{"login":"spring-projects","id":317776,"avatar_url":"https://avatars.githubusercontent.com/u/317776?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-projects/spring-integration-extensions","description":"The Spring Integration Extensions project provides extension components for Spring Integration","fork":false,"url":"https://api.github.com/repos/spring-projects/spring-integration-extensions","forks_url":"https://api.github.com/repos/spring-projects/spring-integration-extensions/forks","keys_url":"https://api.github.com/repos/spring-projects/spring-integration-extensions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-projects/spring-integration-extensions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-projects/spring-integration-extensions/teams","hooks_url":"https://api.github.com/repos/spring-projects/spring-integration-extensions/hooks","issue_events_url":"https://api.github.com/repos/spring-projects/spring-integration-extensions/issues/events{/number}","events_url":"https://api.github.com/repos/spring-projects/spring-integration-extensions/events","assignees_url":"https://api.github.com/repos/spring-projects/spring-integration-extensions/assignees{/user}","branches_url":"https://api.github.com/repos/spring-projects/spring-integration-extensions/branches{/branch}","tags_url":"https://api.github.com/repos/spring-projects/spring-integration-extensions/tags","blobs_url":"https://api.github.com/repos/spring-projects/spring-integration-extensions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-projects/spring-integration-extensions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-projects/spring-integration-extensions/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-projects/spring-integration-extensions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-projects/spring-integration-extensions/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-projects/spring-integration-extensions/languages","stargazers_url":"https://api.github.com/repos/spring-projects/spring-integration-extensions/stargazers","contributors_url":"https://api.github.com/repos/spring-projects/spring-integration-extensions/contributors","subscribers_url":"https://api.github.com/repos/spring-projects/spring-integration-extensions/subscribers","subscription_url":"https://api.github.com/repos/spring-projects/spring-integration-extensions/subscription","commits_url":"https://api.github.com/repos/spring-projects/spring-integration-extensions/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-projects/spring-integration-extensions/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-projects/spring-integration-extensions/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-projects/spring-integration-extensions/issues/comments/{number}","contents_url":"https://api.github.com/repos/spring-projects/spring-integration-extensions/contents/{+path}","compare_url":"https://api.github.com/repos/spring-projects/spring-integration-extensions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-projects/spring-integration-extensions/merges","archive_url":"https://api.github.com/repos/spring-projects/spring-integration-extensions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-projects/spring-integration-extensions/downloads","issues_url":"https://api.github.com/repos/spring-projects/spring-integration-extensions/issues{/number}","pulls_url":"https://api.github.com/repos/spring-projects/spring-integration-extensions/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-projects/spring-integration-extensions/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-projects/spring-integration-extensions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-projects/spring-integration-extensions/labels{/name}","releases_url":"https://api.github.com/repos/spring-projects/spring-integration-extensions/releases{/id}","created_at":"2012-06-13T16:05:52Z","updated_at":"2014-11-06T15:29:47Z","pushed_at":"2014-11-12T17:23:21Z","git_url":"git://github.com/spring-projects/spring-integration-extensions.git","ssh_url":"git@github.com:spring-projects/spring-integration-extensions.git","clone_url":"https://github.com/spring-projects/spring-integration-extensions.git","svn_url":"https://github.com/spring-projects/spring-integration-extensions","homepage":"http://www.springintegration.org/","size":19985,"stargazers_count":84,"watchers_count":84,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":121,"mirror_url":null,"open_issues_count":10,"forks":121,"open_issues":10,"watchers":84,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-projects/spring-integration-extensions/pulls/131"},"html":{"href":"https://github.com/spring-projects/spring-integration-extensions/pull/131"},"issue":{"href":"https://api.github.com/repos/spring-projects/spring-integration-extensions/issues/131"},"comments":{"href":"https://api.github.com/repos/spring-projects/spring-integration-extensions/issues/131/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-projects/spring-integration-extensions/pulls/131/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-projects/spring-integration-extensions/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/spring-projects/spring-integration-extensions/pulls/131/commits"},"statuses":{"href":"https://api.github.com/repos/spring-projects/spring-integration-extensions/statuses/3b6baa7684153492a6df25779976e55b34a80645"}}}}