GitHub PullRequestReviewCommentEvent at 2014-07-09 08:16:00
Repository: mne-python
Actor: agramfort
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/14697965","id":14697965,"diff_hunk":"@@ -0,0 +1,80 @@\n+# Author: Mainak Jas <mainak@neuro.hut.fi>\n+#\n+# License: BSD (3-clause)\n+\n+import os.path as op\n+import glob\n+\n+from nose.tools import assert_true, assert_equal\n+\n+from mne import read_evokeds\n+from mne.report import Report\n+from mne.io import Raw\n+from mne.utils import _TempDir\n+\n+base_dir = op.join(op.dirname(__file__), '..', 'io', 'tests', 'data')\n+raw_fname = op.join(base_dir, 'test_raw.fif')\n+event_name = op.join(base_dir, 'test-eve.fif')\n+evoked_nf_name = op.join(base_dir, 'test-nf-ave.fif')\n+\n+tempdir = _TempDir()\n+\n+\n+def test_parse_folder():","path":"mne/tests/test_report.py","position":23,"original_position":23,"commit_id":"415344cbe17bd64849a6b9fbc24e1899eddb7101","original_commit_id":"415344cbe17bd64849a6b9fbc24e1899eddb7101","user":{"login":"agramfort","id":161052,"avatar_url":"https://avatars.githubusercontent.com/u/161052?","gravatar_id":"e9758ca665b8c3d8cb3026c114d05833","url":"https://api.github.com/users/agramfort","html_url":"https://github.com/agramfort","followers_url":"https://api.github.com/users/agramfort/followers","following_url":"https://api.github.com/users/agramfort/following{/other_user}","gists_url":"https://api.github.com/users/agramfort/gists{/gist_id}","starred_url":"https://api.github.com/users/agramfort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agramfort/subscriptions","organizations_url":"https://api.github.com/users/agramfort/orgs","repos_url":"https://api.github.com/users/agramfort/repos","events_url":"https://api.github.com/users/agramfort/events{/privacy}","received_events_url":"https://api.github.com/users/agramfort/received_events","type":"User","site_admin":false},"body":"what coverage do you have with these test?\r\n\r\nYou should hit more than 85% coverage for report.py","created_at":"2014-07-09T08:16:00Z","updated_at":"2014-07-09T08:16:00Z","html_url":"https://github.com/mne-tools/mne-python/pull/1261#discussion_r14697965","pull_request_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/1261","_links":{"self":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/14697965"},"html":{"href":"https://github.com/mne-tools/mne-python/pull/1261#discussion_r14697965"},"pull_request":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/1261"}}},"pull_request":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/1261","id":15493078,"html_url":"https://github.com/mne-tools/mne-python/pull/1261","diff_url":"https://github.com/mne-tools/mne-python/pull/1261.diff","patch_url":"https://github.com/mne-tools/mne-python/pull/1261.patch","issue_url":"https://api.github.com/repos/mne-tools/mne-python/issues/1261","number":1261,"state":"open","title":"ENH: draft of mne report command","user":{"login":"mainakjas","id":3817535,"avatar_url":"https://avatars.githubusercontent.com/u/3817535?","gravatar_id":"789f16302409623bf4c8f6e1833eabd7","url":"https://api.github.com/users/mainakjas","html_url":"https://github.com/mainakjas","followers_url":"https://api.github.com/users/mainakjas/followers","following_url":"https://api.github.com/users/mainakjas/following{/other_user}","gists_url":"https://api.github.com/users/mainakjas/gists{/gist_id}","starred_url":"https://api.github.com/users/mainakjas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mainakjas/subscriptions","organizations_url":"https://api.github.com/users/mainakjas/orgs","repos_url":"https://api.github.com/users/mainakjas/repos","events_url":"https://api.github.com/users/mainakjas/events{/privacy}","received_events_url":"https://api.github.com/users/mainakjas/received_events","type":"User","site_admin":false},"body":"Closes https://github.com/mne-tools/mne-python/issues/1056 \r\n\r\nTry\r\n```sh\r\n mne report -p MNE-sample-data/ -i MNE-sample-data/MEG/sample/sample_audvis-ave.fif -d MNE-sample-data/subjects/ -s sample -x -v\r\n```\r\nand it should generate ``report.html`` in ``MNE-sample-data/``\r\n\r\nSample output here: https://dl.dropboxusercontent.com/u/3915954/report.html\r\n\r\nTODOS\r\n----------\r\n- [x] recursive exploration\r\n- [x] rebase and use read_evokeds\r\n- [ ]  extend the support to as many fif files types \r\n       - [x] cov\r\n       - [x] fwd \r\n       - [ ] inv\r\n       - [x] raw\r\n       - [x] trans (display head in helmet to check coregistration quality in ``mne.viz.plot_trans()``)\r\n       - [x] epo : plot_drop_log\r\n- [ ] check dpi settings\r\n- [x] Slicer coordinates\r\n- [x] Table of contents linking to different parts of html?\r\n- [x] the bootstrap/JS theme should allow to select which type of fif file to display. See jquery toggle\r\n- [x] also bad fif files should appear in red for example if the fif fname is not standard (evoked should end with -ave.fif, cov with -cov.fif, raw with raw.fif or sss.fiff etc....)\r\n- [x] banner + footer\r\n- [x] open the report in a browser when generated","created_at":"2014-05-05T13:57:41Z","updated_at":"2014-07-09T08:16:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"91bc5807b3566e144b1ed36fc5b1c7593e4befcd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/1261/commits","review_comments_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/1261/comments","review_comment_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/issues/1261/comments","statuses_url":"https://api.github.com/repos/mne-tools/mne-python/statuses/415344cbe17bd64849a6b9fbc24e1899eddb7101","head":{"label":"mainakjas:mne-report","ref":"mne-report","sha":"415344cbe17bd64849a6b9fbc24e1899eddb7101","user":{"login":"mainakjas","id":3817535,"avatar_url":"https://avatars.githubusercontent.com/u/3817535?","gravatar_id":"789f16302409623bf4c8f6e1833eabd7","url":"https://api.github.com/users/mainakjas","html_url":"https://github.com/mainakjas","followers_url":"https://api.github.com/users/mainakjas/followers","following_url":"https://api.github.com/users/mainakjas/following{/other_user}","gists_url":"https://api.github.com/users/mainakjas/gists{/gist_id}","starred_url":"https://api.github.com/users/mainakjas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mainakjas/subscriptions","organizations_url":"https://api.github.com/users/mainakjas/orgs","repos_url":"https://api.github.com/users/mainakjas/repos","events_url":"https://api.github.com/users/mainakjas/events{/privacy}","received_events_url":"https://api.github.com/users/mainakjas/received_events","type":"User","site_admin":false},"repo":{"id":8892606,"name":"mne-python","full_name":"mainakjas/mne-python","owner":{"login":"mainakjas","id":3817535,"avatar_url":"https://avatars.githubusercontent.com/u/3817535?","gravatar_id":"789f16302409623bf4c8f6e1833eabd7","url":"https://api.github.com/users/mainakjas","html_url":"https://github.com/mainakjas","followers_url":"https://api.github.com/users/mainakjas/followers","following_url":"https://api.github.com/users/mainakjas/following{/other_user}","gists_url":"https://api.github.com/users/mainakjas/gists{/gist_id}","starred_url":"https://api.github.com/users/mainakjas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mainakjas/subscriptions","organizations_url":"https://api.github.com/users/mainakjas/orgs","repos_url":"https://api.github.com/users/mainakjas/repos","events_url":"https://api.github.com/users/mainakjas/events{/privacy}","received_events_url":"https://api.github.com/users/mainakjas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mainakjas/mne-python","description":"MNE : Magnetoencephalography (MEG) and Electroencephalography (EEG) in Python","fork":true,"url":"https://api.github.com/repos/mainakjas/mne-python","forks_url":"https://api.github.com/repos/mainakjas/mne-python/forks","keys_url":"https://api.github.com/repos/mainakjas/mne-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mainakjas/mne-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mainakjas/mne-python/teams","hooks_url":"https://api.github.com/repos/mainakjas/mne-python/hooks","issue_events_url":"https://api.github.com/repos/mainakjas/mne-python/issues/events{/number}","events_url":"https://api.github.com/repos/mainakjas/mne-python/events","assignees_url":"https://api.github.com/repos/mainakjas/mne-python/assignees{/user}","branches_url":"https://api.github.com/repos/mainakjas/mne-python/branches{/branch}","tags_url":"https://api.github.com/repos/mainakjas/mne-python/tags","blobs_url":"https://api.github.com/repos/mainakjas/mne-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mainakjas/mne-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mainakjas/mne-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/mainakjas/mne-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mainakjas/mne-python/statuses/{sha}","languages_url":"https://api.github.com/repos/mainakjas/mne-python/languages","stargazers_url":"https://api.github.com/repos/mainakjas/mne-python/stargazers","contributors_url":"https://api.github.com/repos/mainakjas/mne-python/contributors","subscribers_url":"https://api.github.com/repos/mainakjas/mne-python/subscribers","subscription_url":"https://api.github.com/repos/mainakjas/mne-python/subscription","commits_url":"https://api.github.com/repos/mainakjas/mne-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/mainakjas/mne-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/mainakjas/mne-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/mainakjas/mne-python/issues/comments/{number}","contents_url":"https://api.github.com/repos/mainakjas/mne-python/contents/{+path}","compare_url":"https://api.github.com/repos/mainakjas/mne-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mainakjas/mne-python/merges","archive_url":"https://api.github.com/repos/mainakjas/mne-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mainakjas/mne-python/downloads","issues_url":"https://api.github.com/repos/mainakjas/mne-python/issues{/number}","pulls_url":"https://api.github.com/repos/mainakjas/mne-python/pulls{/number}","milestones_url":"https://api.github.com/repos/mainakjas/mne-python/milestones{/number}","notifications_url":"https://api.github.com/repos/mainakjas/mne-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mainakjas/mne-python/labels{/name}","releases_url":"https://api.github.com/repos/mainakjas/mne-python/releases{/id}","created_at":"2013-03-20T00:17:33Z","updated_at":"2014-06-24T14:23:57Z","pushed_at":"2014-07-08T22:54:42Z","git_url":"git://github.com/mainakjas/mne-python.git","ssh_url":"git@github.com:mainakjas/mne-python.git","clone_url":"https://github.com/mainakjas/mne-python.git","svn_url":"https://github.com/mainakjas/mne-python","homepage":"http://martinos.org/mne/","size":72032,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mne-tools:master","ref":"master","sha":"1ed2eb6bb75cca150156791fdba7d0283ddd7bcb","user":{"login":"mne-tools","id":583875,"avatar_url":"https://avatars.githubusercontent.com/u/583875?","gravatar_id":"416606f0d9a5013c6a985610c6ff56c8","url":"https://api.github.com/users/mne-tools","html_url":"https://github.com/mne-tools","followers_url":"https://api.github.com/users/mne-tools/followers","following_url":"https://api.github.com/users/mne-tools/following{/other_user}","gists_url":"https://api.github.com/users/mne-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/mne-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mne-tools/subscriptions","organizations_url":"https://api.github.com/users/mne-tools/orgs","repos_url":"https://api.github.com/users/mne-tools/repos","events_url":"https://api.github.com/users/mne-tools/events{/privacy}","received_events_url":"https://api.github.com/users/mne-tools/received_events","type":"Organization","site_admin":false},"repo":{"id":1301584,"name":"mne-python","full_name":"mne-tools/mne-python","owner":{"login":"mne-tools","id":583875,"avatar_url":"https://avatars.githubusercontent.com/u/583875?","gravatar_id":"416606f0d9a5013c6a985610c6ff56c8","url":"https://api.github.com/users/mne-tools","html_url":"https://github.com/mne-tools","followers_url":"https://api.github.com/users/mne-tools/followers","following_url":"https://api.github.com/users/mne-tools/following{/other_user}","gists_url":"https://api.github.com/users/mne-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/mne-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mne-tools/subscriptions","organizations_url":"https://api.github.com/users/mne-tools/orgs","repos_url":"https://api.github.com/users/mne-tools/repos","events_url":"https://api.github.com/users/mne-tools/events{/privacy}","received_events_url":"https://api.github.com/users/mne-tools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mne-tools/mne-python","description":"MNE : Magnetoencephalography (MEG) and Electroencephalography (EEG) in Python","fork":false,"url":"https://api.github.com/repos/mne-tools/mne-python","forks_url":"https://api.github.com/repos/mne-tools/mne-python/forks","keys_url":"https://api.github.com/repos/mne-tools/mne-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mne-tools/mne-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mne-tools/mne-python/teams","hooks_url":"https://api.github.com/repos/mne-tools/mne-python/hooks","issue_events_url":"https://api.github.com/repos/mne-tools/mne-python/issues/events{/number}","events_url":"https://api.github.com/repos/mne-tools/mne-python/events","assignees_url":"https://api.github.com/repos/mne-tools/mne-python/assignees{/user}","branches_url":"https://api.github.com/repos/mne-tools/mne-python/branches{/branch}","tags_url":"https://api.github.com/repos/mne-tools/mne-python/tags","blobs_url":"https://api.github.com/repos/mne-tools/mne-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mne-tools/mne-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mne-tools/mne-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/mne-tools/mne-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mne-tools/mne-python/statuses/{sha}","languages_url":"https://api.github.com/repos/mne-tools/mne-python/languages","stargazers_url":"https://api.github.com/repos/mne-tools/mne-python/stargazers","contributors_url":"https://api.github.com/repos/mne-tools/mne-python/contributors","subscribers_url":"https://api.github.com/repos/mne-tools/mne-python/subscribers","subscription_url":"https://api.github.com/repos/mne-tools/mne-python/subscription","commits_url":"https://api.github.com/repos/mne-tools/mne-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/mne-tools/mne-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/mne-tools/mne-python/issues/comments/{number}","contents_url":"https://api.github.com/repos/mne-tools/mne-python/contents/{+path}","compare_url":"https://api.github.com/repos/mne-tools/mne-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mne-tools/mne-python/merges","archive_url":"https://api.github.com/repos/mne-tools/mne-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mne-tools/mne-python/downloads","issues_url":"https://api.github.com/repos/mne-tools/mne-python/issues{/number}","pulls_url":"https://api.github.com/repos/mne-tools/mne-python/pulls{/number}","milestones_url":"https://api.github.com/repos/mne-tools/mne-python/milestones{/number}","notifications_url":"https://api.github.com/repos/mne-tools/mne-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mne-tools/mne-python/labels{/name}","releases_url":"https://api.github.com/repos/mne-tools/mne-python/releases{/id}","created_at":"2011-01-28T03:31:13Z","updated_at":"2014-07-08T08:04:26Z","pushed_at":"2014-07-08T20:17:57Z","git_url":"git://github.com/mne-tools/mne-python.git","ssh_url":"git@github.com:mne-tools/mne-python.git","clone_url":"https://github.com/mne-tools/mne-python.git","svn_url":"https://github.com/mne-tools/mne-python","homepage":"http://martinos.org/mne/","size":160546,"stargazers_count":89,"watchers_count":89,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":81,"mirror_url":null,"open_issues_count":129,"forks":81,"open_issues":129,"watchers":89,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/1261"},"html":{"href":"https://github.com/mne-tools/mne-python/pull/1261"},"issue":{"href":"https://api.github.com/repos/mne-tools/mne-python/issues/1261"},"comments":{"href":"https://api.github.com/repos/mne-tools/mne-python/issues/1261/comments"},"review_comments":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/1261/comments"},"review_comment":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/1261/commits"},"statuses":{"href":"https://api.github.com/repos/mne-tools/mne-python/statuses/415344cbe17bd64849a6b9fbc24e1899eddb7101"}}}}