GitHub PullRequestReviewCommentEvent at 2014-07-02 08:05:04
Repository: Markus
Actor: houndci
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/comments/14444702","id":14444702,"diff_hunk":"@@ -337,7 +337,17 @@ def csv_upload\n         end\n       end\n     end\n-  redirect_to action: 'grades', id: @grade_entry_form.id\n+    redirect_to action: 'grades', id: @grade_entry_form.id","path":"app/controllers/grade_entry_forms_controller.rb","position":23,"original_position":23,"commit_id":"c1d639987052a1a04aca66a605346e792204d814","original_commit_id":"c1d639987052a1a04aca66a605346e792204d814","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?","gravatar_id":"38d9cefd9971a05bf447f07c6cd332cc","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.","created_at":"2014-07-02T08:05:04Z","updated_at":"2014-07-02T08:05:04Z","html_url":"https://github.com/MarkUsProject/Markus/pull/1554#discussion_r14444702","pull_request_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/1554","_links":{"self":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/comments/14444702"},"html":{"href":"https://github.com/MarkUsProject/Markus/pull/1554#discussion_r14444702"},"pull_request":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/1554"}}},"pull_request":{"url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/1554","id":17872411,"html_url":"https://github.com/MarkUsProject/Markus/pull/1554","diff_url":"https://github.com/MarkUsProject/Markus/pull/1554.diff","patch_url":"https://github.com/MarkUsProject/Markus/pull/1554.patch","issue_url":"https://api.github.com/repos/MarkUsProject/Markus/issues/1554","number":1554,"state":"open","title":"Migrate mass-assignment security to strong_parameters","user":{"login":"ferrous26","id":38430,"avatar_url":"https://avatars.githubusercontent.com/u/38430?","gravatar_id":"3932daa02b43b3036b9340f7d8ec824d","url":"https://api.github.com/users/ferrous26","html_url":"https://github.com/ferrous26","followers_url":"https://api.github.com/users/ferrous26/followers","following_url":"https://api.github.com/users/ferrous26/following{/other_user}","gists_url":"https://api.github.com/users/ferrous26/gists{/gist_id}","starred_url":"https://api.github.com/users/ferrous26/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferrous26/subscriptions","organizations_url":"https://api.github.com/users/ferrous26/orgs","repos_url":"https://api.github.com/users/ferrous26/repos","events_url":"https://api.github.com/users/ferrous26/events{/privacy}","received_events_url":"https://api.github.com/users/ferrous26/received_events","type":"User","site_admin":false},"body":"Ahead of the upgrade to Rails 4, this change removes the use of\r\nattr_accessible and attr_protected as mass assignment protection\r\nmechanisms in favour of whitelisting input attributes at the\r\ncontroller level.\r\n\r\nSee http://blog.markusproject.org/?p=5588 for more details.\r\n\r\nAll tests are passing, and limited playing around with a local server seemed to work correctly. However, I am not confident that I have get the assignments controller completely working and there may be cases that the tests do not cover. So, I am opening this PR for review only at this time.","created_at":"2014-07-02T08:04:53Z","updated_at":"2014-07-02T08:05:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b1024844407afbc5ddfeca846ff7b19e3378027d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/1554/commits","review_comments_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/1554/comments","review_comment_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/comments/{number}","comments_url":"https://api.github.com/repos/MarkUsProject/Markus/issues/1554/comments","statuses_url":"https://api.github.com/repos/MarkUsProject/Markus/statuses/c1d639987052a1a04aca66a605346e792204d814","head":{"label":"ferrous26:strong_params","ref":"strong_params","sha":"c1d639987052a1a04aca66a605346e792204d814","user":{"login":"ferrous26","id":38430,"avatar_url":"https://avatars.githubusercontent.com/u/38430?","gravatar_id":"3932daa02b43b3036b9340f7d8ec824d","url":"https://api.github.com/users/ferrous26","html_url":"https://github.com/ferrous26","followers_url":"https://api.github.com/users/ferrous26/followers","following_url":"https://api.github.com/users/ferrous26/following{/other_user}","gists_url":"https://api.github.com/users/ferrous26/gists{/gist_id}","starred_url":"https://api.github.com/users/ferrous26/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferrous26/subscriptions","organizations_url":"https://api.github.com/users/ferrous26/orgs","repos_url":"https://api.github.com/users/ferrous26/repos","events_url":"https://api.github.com/users/ferrous26/events{/privacy}","received_events_url":"https://api.github.com/users/ferrous26/received_events","type":"User","site_admin":false},"repo":{"id":19295908,"name":"Markus","full_name":"ferrous26/Markus","owner":{"login":"ferrous26","id":38430,"avatar_url":"https://avatars.githubusercontent.com/u/38430?","gravatar_id":"3932daa02b43b3036b9340f7d8ec824d","url":"https://api.github.com/users/ferrous26","html_url":"https://github.com/ferrous26","followers_url":"https://api.github.com/users/ferrous26/followers","following_url":"https://api.github.com/users/ferrous26/following{/other_user}","gists_url":"https://api.github.com/users/ferrous26/gists{/gist_id}","starred_url":"https://api.github.com/users/ferrous26/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferrous26/subscriptions","organizations_url":"https://api.github.com/users/ferrous26/orgs","repos_url":"https://api.github.com/users/ferrous26/repos","events_url":"https://api.github.com/users/ferrous26/events{/privacy}","received_events_url":"https://api.github.com/users/ferrous26/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ferrous26/Markus","description":"Git repository of MarkUs","fork":true,"url":"https://api.github.com/repos/ferrous26/Markus","forks_url":"https://api.github.com/repos/ferrous26/Markus/forks","keys_url":"https://api.github.com/repos/ferrous26/Markus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ferrous26/Markus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ferrous26/Markus/teams","hooks_url":"https://api.github.com/repos/ferrous26/Markus/hooks","issue_events_url":"https://api.github.com/repos/ferrous26/Markus/issues/events{/number}","events_url":"https://api.github.com/repos/ferrous26/Markus/events","assignees_url":"https://api.github.com/repos/ferrous26/Markus/assignees{/user}","branches_url":"https://api.github.com/repos/ferrous26/Markus/branches{/branch}","tags_url":"https://api.github.com/repos/ferrous26/Markus/tags","blobs_url":"https://api.github.com/repos/ferrous26/Markus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ferrous26/Markus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ferrous26/Markus/git/refs{/sha}","trees_url":"https://api.github.com/repos/ferrous26/Markus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ferrous26/Markus/statuses/{sha}","languages_url":"https://api.github.com/repos/ferrous26/Markus/languages","stargazers_url":"https://api.github.com/repos/ferrous26/Markus/stargazers","contributors_url":"https://api.github.com/repos/ferrous26/Markus/contributors","subscribers_url":"https://api.github.com/repos/ferrous26/Markus/subscribers","subscription_url":"https://api.github.com/repos/ferrous26/Markus/subscription","commits_url":"https://api.github.com/repos/ferrous26/Markus/commits{/sha}","git_commits_url":"https://api.github.com/repos/ferrous26/Markus/git/commits{/sha}","comments_url":"https://api.github.com/repos/ferrous26/Markus/comments{/number}","issue_comment_url":"https://api.github.com/repos/ferrous26/Markus/issues/comments/{number}","contents_url":"https://api.github.com/repos/ferrous26/Markus/contents/{+path}","compare_url":"https://api.github.com/repos/ferrous26/Markus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ferrous26/Markus/merges","archive_url":"https://api.github.com/repos/ferrous26/Markus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ferrous26/Markus/downloads","issues_url":"https://api.github.com/repos/ferrous26/Markus/issues{/number}","pulls_url":"https://api.github.com/repos/ferrous26/Markus/pulls{/number}","milestones_url":"https://api.github.com/repos/ferrous26/Markus/milestones{/number}","notifications_url":"https://api.github.com/repos/ferrous26/Markus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ferrous26/Markus/labels{/name}","releases_url":"https://api.github.com/repos/ferrous26/Markus/releases{/id}","created_at":"2014-04-30T00:26:17Z","updated_at":"2014-07-02T02:01:07Z","pushed_at":"2014-07-02T08:02:28Z","git_url":"git://github.com/ferrous26/Markus.git","ssh_url":"git@github.com:ferrous26/Markus.git","clone_url":"https://github.com/ferrous26/Markus.git","svn_url":"https://github.com/ferrous26/Markus","homepage":"http://www.markusproject.org","size":16196,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MarkUsProject:master","ref":"master","sha":"cb88585cba16f3c6b99e06b2fb800976aaf0e0b9","user":{"login":"MarkUsProject","id":415874,"avatar_url":"https://avatars.githubusercontent.com/u/415874?","gravatar_id":"7fd5c1f7357ff6089fd2ea12640529ab","url":"https://api.github.com/users/MarkUsProject","html_url":"https://github.com/MarkUsProject","followers_url":"https://api.github.com/users/MarkUsProject/followers","following_url":"https://api.github.com/users/MarkUsProject/following{/other_user}","gists_url":"https://api.github.com/users/MarkUsProject/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkUsProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkUsProject/subscriptions","organizations_url":"https://api.github.com/users/MarkUsProject/orgs","repos_url":"https://api.github.com/users/MarkUsProject/repos","events_url":"https://api.github.com/users/MarkUsProject/events{/privacy}","received_events_url":"https://api.github.com/users/MarkUsProject/received_events","type":"Organization","site_admin":false},"repo":{"id":940538,"name":"Markus","full_name":"MarkUsProject/Markus","owner":{"login":"MarkUsProject","id":415874,"avatar_url":"https://avatars.githubusercontent.com/u/415874?","gravatar_id":"7fd5c1f7357ff6089fd2ea12640529ab","url":"https://api.github.com/users/MarkUsProject","html_url":"https://github.com/MarkUsProject","followers_url":"https://api.github.com/users/MarkUsProject/followers","following_url":"https://api.github.com/users/MarkUsProject/following{/other_user}","gists_url":"https://api.github.com/users/MarkUsProject/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkUsProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkUsProject/subscriptions","organizations_url":"https://api.github.com/users/MarkUsProject/orgs","repos_url":"https://api.github.com/users/MarkUsProject/repos","events_url":"https://api.github.com/users/MarkUsProject/events{/privacy}","received_events_url":"https://api.github.com/users/MarkUsProject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MarkUsProject/Markus","description":"Git repository of MarkUs","fork":false,"url":"https://api.github.com/repos/MarkUsProject/Markus","forks_url":"https://api.github.com/repos/MarkUsProject/Markus/forks","keys_url":"https://api.github.com/repos/MarkUsProject/Markus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MarkUsProject/Markus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MarkUsProject/Markus/teams","hooks_url":"https://api.github.com/repos/MarkUsProject/Markus/hooks","issue_events_url":"https://api.github.com/repos/MarkUsProject/Markus/issues/events{/number}","events_url":"https://api.github.com/repos/MarkUsProject/Markus/events","assignees_url":"https://api.github.com/repos/MarkUsProject/Markus/assignees{/user}","branches_url":"https://api.github.com/repos/MarkUsProject/Markus/branches{/branch}","tags_url":"https://api.github.com/repos/MarkUsProject/Markus/tags","blobs_url":"https://api.github.com/repos/MarkUsProject/Markus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MarkUsProject/Markus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MarkUsProject/Markus/git/refs{/sha}","trees_url":"https://api.github.com/repos/MarkUsProject/Markus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MarkUsProject/Markus/statuses/{sha}","languages_url":"https://api.github.com/repos/MarkUsProject/Markus/languages","stargazers_url":"https://api.github.com/repos/MarkUsProject/Markus/stargazers","contributors_url":"https://api.github.com/repos/MarkUsProject/Markus/contributors","subscribers_url":"https://api.github.com/repos/MarkUsProject/Markus/subscribers","subscription_url":"https://api.github.com/repos/MarkUsProject/Markus/subscription","commits_url":"https://api.github.com/repos/MarkUsProject/Markus/commits{/sha}","git_commits_url":"https://api.github.com/repos/MarkUsProject/Markus/git/commits{/sha}","comments_url":"https://api.github.com/repos/MarkUsProject/Markus/comments{/number}","issue_comment_url":"https://api.github.com/repos/MarkUsProject/Markus/issues/comments/{number}","contents_url":"https://api.github.com/repos/MarkUsProject/Markus/contents/{+path}","compare_url":"https://api.github.com/repos/MarkUsProject/Markus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MarkUsProject/Markus/merges","archive_url":"https://api.github.com/repos/MarkUsProject/Markus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MarkUsProject/Markus/downloads","issues_url":"https://api.github.com/repos/MarkUsProject/Markus/issues{/number}","pulls_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls{/number}","milestones_url":"https://api.github.com/repos/MarkUsProject/Markus/milestones{/number}","notifications_url":"https://api.github.com/repos/MarkUsProject/Markus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MarkUsProject/Markus/labels{/name}","releases_url":"https://api.github.com/repos/MarkUsProject/Markus/releases{/id}","created_at":"2010-09-26T16:18:08Z","updated_at":"2014-07-02T05:14:34Z","pushed_at":"2014-06-27T21:45:12Z","git_url":"git://github.com/MarkUsProject/Markus.git","ssh_url":"git@github.com:MarkUsProject/Markus.git","clone_url":"https://github.com/MarkUsProject/Markus.git","svn_url":"https://github.com/MarkUsProject/Markus","homepage":"http://www.markusproject.org","size":41925,"stargazers_count":103,"watchers_count":103,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":124,"mirror_url":null,"open_issues_count":107,"forks":124,"open_issues":107,"watchers":103,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/1554"},"html":{"href":"https://github.com/MarkUsProject/Markus/pull/1554"},"issue":{"href":"https://api.github.com/repos/MarkUsProject/Markus/issues/1554"},"comments":{"href":"https://api.github.com/repos/MarkUsProject/Markus/issues/1554/comments"},"review_comments":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/1554/comments"},"review_comment":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/1554/commits"},"statuses":{"href":"https://api.github.com/repos/MarkUsProject/Markus/statuses/c1d639987052a1a04aca66a605346e792204d814"}}}}