GitHub PullRequestEvent at 2014-03-12 14:12:41
Repository: aerogear-simplepush-server
Actor: matzew
Payload: {"action":"closed","number":72,"pull_request":{"url":"https://api.github.com/repos/aerogear/aerogear-simplepush-server/pulls/72","id":13461403,"html_url":"https://github.com/aerogear/aerogear-simplepush-server/pull/72","diff_url":"https://github.com/aerogear/aerogear-simplepush-server/pull/72.diff","patch_url":"https://github.com/aerogear/aerogear-simplepush-server/pull/72.patch","issue_url":"https://api.github.com/repos/aerogear/aerogear-simplepush-server/issues/72","number":72,"state":"closed","title":"Fixing SockJS session handling for xhr/jsonp polling.","user":{"login":"danbev","id":432351,"avatar_url":"https://gravatar.com/avatar/1be2cab21d939dc1abb2ed47b46877c6?d=https%3A%2F%2Fidenticons.github.com%2F4c3ae282e367d87eba4dd8491427c2dd.png&r=x","gravatar_id":"1be2cab21d939dc1abb2ed47b46877c6","url":"https://api.github.com/users/danbev","html_url":"https://github.com/danbev","followers_url":"https://api.github.com/users/danbev/followers","following_url":"https://api.github.com/users/danbev/following{/other_user}","gists_url":"https://api.github.com/users/danbev/gists{/gist_id}","starred_url":"https://api.github.com/users/danbev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danbev/subscriptions","organizations_url":"https://api.github.com/users/danbev/orgs","repos_url":"https://api.github.com/users/danbev/repos","events_url":"https://api.github.com/users/danbev/events{/privacy}","received_events_url":"https://api.github.com/users/danbev/received_events","type":"User","site_admin":false},"body":"The is a re-opening of AGSMPLPUSH-42 which intended to fix this issue\r\nbut the fix was just plain wrong.\r\n\r\nThe original issue was that the polling transports did to reply with any\r\ndata when messages had been sent to them. The fix then was to add an\r\nexplicit empty reply to trigger SockJS to repoll and it was then able\r\nto retrieve data.\r\nBut the polling transports are \"long polling\" in that they will remain\r\nuntil either data is made available by the server side or the session\r\ntimes out.\r\n\r\nThis commit fixes the session handling by introducing a field in the\r\nSockJSSession class which is the ChannelHandlerContext used for an\r\nopen connection. This 'openContext' is then available to be used\r\nby SessionState implementations, for example the PollingSessionState.\r\nPollingSessionState sometimes needs to use the ChannelHandlerContext\r\nused to connect which is needed to send the SockJS OpenFrame, but\r\nsuccessive calls needs to use the ChannelHandlerContext for the\r\nopen session.\r\n\r\nAdditional changes:\r\n- SockJS test server can now be started with mvn exec:java\r\n- sockjs-client.html contains examples of specifying transports types\r\n\r\n[https://issues.jboss.org/browse/AGSMPLPUSH-42]","created_at":"2014-03-12T09:24:10Z","updated_at":"2014-03-12T14:12:41Z","closed_at":"2014-03-12T14:12:41Z","merged_at":"2014-03-12T14:12:40Z","merge_commit_sha":"45440f8bee95a143656619869f856f7d2e428fd8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aerogear/aerogear-simplepush-server/pulls/72/commits","review_comments_url":"https://api.github.com/repos/aerogear/aerogear-simplepush-server/pulls/72/comments","review_comment_url":"https://api.github.com/repos/aerogear/aerogear-simplepush-server/pulls/comments/{number}","comments_url":"https://api.github.com/repos/aerogear/aerogear-simplepush-server/issues/72/comments","statuses_url":"https://api.github.com/repos/aerogear/aerogear-simplepush-server/statuses/6b9bf8cfe8b35ae54fc24f7ff6ee144787fa405a","head":{"label":"danbev:AGSMPLPUSH-42-session-fix","ref":"AGSMPLPUSH-42-session-fix","sha":"6b9bf8cfe8b35ae54fc24f7ff6ee144787fa405a","user":{"login":"danbev","id":432351,"avatar_url":"https://gravatar.com/avatar/1be2cab21d939dc1abb2ed47b46877c6?d=https%3A%2F%2Fidenticons.github.com%2F4c3ae282e367d87eba4dd8491427c2dd.png&r=x","gravatar_id":"1be2cab21d939dc1abb2ed47b46877c6","url":"https://api.github.com/users/danbev","html_url":"https://github.com/danbev","followers_url":"https://api.github.com/users/danbev/followers","following_url":"https://api.github.com/users/danbev/following{/other_user}","gists_url":"https://api.github.com/users/danbev/gists{/gist_id}","starred_url":"https://api.github.com/users/danbev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danbev/subscriptions","organizations_url":"https://api.github.com/users/danbev/orgs","repos_url":"https://api.github.com/users/danbev/repos","events_url":"https://api.github.com/users/danbev/events{/privacy}","received_events_url":"https://api.github.com/users/danbev/received_events","type":"User","site_admin":false},"repo":{"id":10915715,"name":"aerogear-simplepush-server","full_name":"danbev/aerogear-simplepush-server","owner":{"login":"danbev","id":432351,"avatar_url":"https://gravatar.com/avatar/1be2cab21d939dc1abb2ed47b46877c6?d=https%3A%2F%2Fidenticons.github.com%2F4c3ae282e367d87eba4dd8491427c2dd.png&r=x","gravatar_id":"1be2cab21d939dc1abb2ed47b46877c6","url":"https://api.github.com/users/danbev","html_url":"https://github.com/danbev","followers_url":"https://api.github.com/users/danbev/followers","following_url":"https://api.github.com/users/danbev/following{/other_user}","gists_url":"https://api.github.com/users/danbev/gists{/gist_id}","starred_url":"https://api.github.com/users/danbev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danbev/subscriptions","organizations_url":"https://api.github.com/users/danbev/orgs","repos_url":"https://api.github.com/users/danbev/repos","events_url":"https://api.github.com/users/danbev/events{/privacy}","received_events_url":"https://api.github.com/users/danbev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danbev/aerogear-simplepush-server","description":"","fork":true,"url":"https://api.github.com/repos/danbev/aerogear-simplepush-server","forks_url":"https://api.github.com/repos/danbev/aerogear-simplepush-server/forks","keys_url":"https://api.github.com/repos/danbev/aerogear-simplepush-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danbev/aerogear-simplepush-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danbev/aerogear-simplepush-server/teams","hooks_url":"https://api.github.com/repos/danbev/aerogear-simplepush-server/hooks","issue_events_url":"https://api.github.com/repos/danbev/aerogear-simplepush-server/issues/events{/number}","events_url":"https://api.github.com/repos/danbev/aerogear-simplepush-server/events","assignees_url":"https://api.github.com/repos/danbev/aerogear-simplepush-server/assignees{/user}","branches_url":"https://api.github.com/repos/danbev/aerogear-simplepush-server/branches{/branch}","tags_url":"https://api.github.com/repos/danbev/aerogear-simplepush-server/tags","blobs_url":"https://api.github.com/repos/danbev/aerogear-simplepush-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danbev/aerogear-simplepush-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danbev/aerogear-simplepush-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/danbev/aerogear-simplepush-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danbev/aerogear-simplepush-server/statuses/{sha}","languages_url":"https://api.github.com/repos/danbev/aerogear-simplepush-server/languages","stargazers_url":"https://api.github.com/repos/danbev/aerogear-simplepush-server/stargazers","contributors_url":"https://api.github.com/repos/danbev/aerogear-simplepush-server/contributors","subscribers_url":"https://api.github.com/repos/danbev/aerogear-simplepush-server/subscribers","subscription_url":"https://api.github.com/repos/danbev/aerogear-simplepush-server/subscription","commits_url":"https://api.github.com/repos/danbev/aerogear-simplepush-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/danbev/aerogear-simplepush-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/danbev/aerogear-simplepush-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/danbev/aerogear-simplepush-server/issues/comments/{number}","contents_url":"https://api.github.com/repos/danbev/aerogear-simplepush-server/contents/{+path}","compare_url":"https://api.github.com/repos/danbev/aerogear-simplepush-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danbev/aerogear-simplepush-server/merges","archive_url":"https://api.github.com/repos/danbev/aerogear-simplepush-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danbev/aerogear-simplepush-server/downloads","issues_url":"https://api.github.com/repos/danbev/aerogear-simplepush-server/issues{/number}","pulls_url":"https://api.github.com/repos/danbev/aerogear-simplepush-server/pulls{/number}","milestones_url":"https://api.github.com/repos/danbev/aerogear-simplepush-server/milestones{/number}","notifications_url":"https://api.github.com/repos/danbev/aerogear-simplepush-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danbev/aerogear-simplepush-server/labels{/name}","releases_url":"https://api.github.com/repos/danbev/aerogear-simplepush-server/releases{/id}","created_at":"2013-06-24T17:58:05Z","updated_at":"2014-03-12T14:12:41Z","pushed_at":"2014-03-12T11:15:54Z","git_url":"git://github.com/danbev/aerogear-simplepush-server.git","ssh_url":"git@github.com:danbev/aerogear-simplepush-server.git","clone_url":"https://github.com/danbev/aerogear-simplepush-server.git","svn_url":"https://github.com/danbev/aerogear-simplepush-server","homepage":null,"size":3770,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aerogear:master","ref":"master","sha":"32a2136b6203db1e92fd5c354efb43643f6c231a","user":{"login":"aerogear","id":954205,"avatar_url":"https://gravatar.com/avatar/3390eb8d824c7c8654852b4c22591016?d=https%3A%2F%2Fidenticons.github.com%2Fdaaff4e3adcf9d8cfd65c418e38049d3.png&r=x","gravatar_id":"3390eb8d824c7c8654852b4c22591016","url":"https://api.github.com/users/aerogear","html_url":"https://github.com/aerogear","followers_url":"https://api.github.com/users/aerogear/followers","following_url":"https://api.github.com/users/aerogear/following{/other_user}","gists_url":"https://api.github.com/users/aerogear/gists{/gist_id}","starred_url":"https://api.github.com/users/aerogear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aerogear/subscriptions","organizations_url":"https://api.github.com/users/aerogear/orgs","repos_url":"https://api.github.com/users/aerogear/repos","events_url":"https://api.github.com/users/aerogear/events{/privacy}","received_events_url":"https://api.github.com/users/aerogear/received_events","type":"Organization","site_admin":false},"repo":{"id":10646587,"name":"aerogear-simplepush-server","full_name":"aerogear/aerogear-simplepush-server","owner":{"login":"aerogear","id":954205,"avatar_url":"https://gravatar.com/avatar/3390eb8d824c7c8654852b4c22591016?d=https%3A%2F%2Fidenticons.github.com%2Fdaaff4e3adcf9d8cfd65c418e38049d3.png&r=x","gravatar_id":"3390eb8d824c7c8654852b4c22591016","url":"https://api.github.com/users/aerogear","html_url":"https://github.com/aerogear","followers_url":"https://api.github.com/users/aerogear/followers","following_url":"https://api.github.com/users/aerogear/following{/other_user}","gists_url":"https://api.github.com/users/aerogear/gists{/gist_id}","starred_url":"https://api.github.com/users/aerogear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aerogear/subscriptions","organizations_url":"https://api.github.com/users/aerogear/orgs","repos_url":"https://api.github.com/users/aerogear/repos","events_url":"https://api.github.com/users/aerogear/events{/privacy}","received_events_url":"https://api.github.com/users/aerogear/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aerogear/aerogear-simplepush-server","description":"","fork":false,"url":"https://api.github.com/repos/aerogear/aerogear-simplepush-server","forks_url":"https://api.github.com/repos/aerogear/aerogear-simplepush-server/forks","keys_url":"https://api.github.com/repos/aerogear/aerogear-simplepush-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aerogear/aerogear-simplepush-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aerogear/aerogear-simplepush-server/teams","hooks_url":"https://api.github.com/repos/aerogear/aerogear-simplepush-server/hooks","issue_events_url":"https://api.github.com/repos/aerogear/aerogear-simplepush-server/issues/events{/number}","events_url":"https://api.github.com/repos/aerogear/aerogear-simplepush-server/events","assignees_url":"https://api.github.com/repos/aerogear/aerogear-simplepush-server/assignees{/user}","branches_url":"https://api.github.com/repos/aerogear/aerogear-simplepush-server/branches{/branch}","tags_url":"https://api.github.com/repos/aerogear/aerogear-simplepush-server/tags","blobs_url":"https://api.github.com/repos/aerogear/aerogear-simplepush-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aerogear/aerogear-simplepush-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aerogear/aerogear-simplepush-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/aerogear/aerogear-simplepush-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aerogear/aerogear-simplepush-server/statuses/{sha}","languages_url":"https://api.github.com/repos/aerogear/aerogear-simplepush-server/languages","stargazers_url":"https://api.github.com/repos/aerogear/aerogear-simplepush-server/stargazers","contributors_url":"https://api.github.com/repos/aerogear/aerogear-simplepush-server/contributors","subscribers_url":"https://api.github.com/repos/aerogear/aerogear-simplepush-server/subscribers","subscription_url":"https://api.github.com/repos/aerogear/aerogear-simplepush-server/subscription","commits_url":"https://api.github.com/repos/aerogear/aerogear-simplepush-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/aerogear/aerogear-simplepush-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/aerogear/aerogear-simplepush-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/aerogear/aerogear-simplepush-server/issues/comments/{number}","contents_url":"https://api.github.com/repos/aerogear/aerogear-simplepush-server/contents/{+path}","compare_url":"https://api.github.com/repos/aerogear/aerogear-simplepush-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aerogear/aerogear-simplepush-server/merges","archive_url":"https://api.github.com/repos/aerogear/aerogear-simplepush-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aerogear/aerogear-simplepush-server/downloads","issues_url":"https://api.github.com/repos/aerogear/aerogear-simplepush-server/issues{/number}","pulls_url":"https://api.github.com/repos/aerogear/aerogear-simplepush-server/pulls{/number}","milestones_url":"https://api.github.com/repos/aerogear/aerogear-simplepush-server/milestones{/number}","notifications_url":"https://api.github.com/repos/aerogear/aerogear-simplepush-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aerogear/aerogear-simplepush-server/labels{/name}","releases_url":"https://api.github.com/repos/aerogear/aerogear-simplepush-server/releases{/id}","created_at":"2013-06-12T16:07:55Z","updated_at":"2014-03-12T11:16:36Z","pushed_at":"2014-03-12T14:12:40Z","git_url":"git://github.com/aerogear/aerogear-simplepush-server.git","ssh_url":"git@github.com:aerogear/aerogear-simplepush-server.git","clone_url":"https://github.com/aerogear/aerogear-simplepush-server.git","svn_url":"https://github.com/aerogear/aerogear-simplepush-server","homepage":null,"size":3608,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":12,"mirror_url":null,"open_issues_count":0,"forks":12,"open_issues":0,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aerogear/aerogear-simplepush-server/pulls/72"},"html":{"href":"https://github.com/aerogear/aerogear-simplepush-server/pull/72"},"issue":{"href":"https://api.github.com/repos/aerogear/aerogear-simplepush-server/issues/72"},"comments":{"href":"https://api.github.com/repos/aerogear/aerogear-simplepush-server/issues/72/comments"},"review_comments":{"href":"https://api.github.com/repos/aerogear/aerogear-simplepush-server/pulls/72/comments"},"review_comment":{"href":"https://api.github.com/repos/aerogear/aerogear-simplepush-server/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/aerogear/aerogear-simplepush-server/pulls/72/commits"},"statuses":{"href":"https://api.github.com/repos/aerogear/aerogear-simplepush-server/statuses/6b9bf8cfe8b35ae54fc24f7ff6ee144787fa405a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"matzew","id":157646,"avatar_url":"https://gravatar.com/avatar/df135e9a2604ec2ce5d12ad049a8c99b?d=https%3A%2F%2Fidenticons.github.com%2Fcb833d2aebc200c9e298ce9b4fe0b0cf.png&r=x","gravatar_id":"df135e9a2604ec2ce5d12ad049a8c99b","url":"https://api.github.com/users/matzew","html_url":"https://github.com/matzew","followers_url":"https://api.github.com/users/matzew/followers","following_url":"https://api.github.com/users/matzew/following{/other_user}","gists_url":"https://api.github.com/users/matzew/gists{/gist_id}","starred_url":"https://api.github.com/users/matzew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matzew/subscriptions","organizations_url":"https://api.github.com/users/matzew/orgs","repos_url":"https://api.github.com/users/matzew/repos","events_url":"https://api.github.com/users/matzew/events{/privacy}","received_events_url":"https://api.github.com/users/matzew/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":76,"deletions":192,"changed_files":14}}