GitHub PullRequestReviewCommentEvent at 2014-06-26 12:08:14
Repository: EzPriceBundle
Actor: crevillo
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/ezsystems/EzPriceBundle/pulls/comments/14236585","id":14236585,"diff_hunk":"@@ -158,6 +176,6 @@ private function getVatPercentage( $vat_type )\n             return $vatPercentage;\n         }\n \n-        return 0;\n+        throw new NotImplementedException( 'Automatic VAT Handling is not implemented yet' );","path":"eZ/Publish/Core/FieldType/Price/PriceStorage/Gateway/LegacyStorage.php","position":93,"original_position":91,"commit_id":"43c6e5c5984462329fba8cdcf3a6a9ede1c42ecf","original_commit_id":"6d1777d3648fff6f21241dc8e733e05144764c68","user":{"login":"crevillo","id":306215,"avatar_url":"https://avatars.githubusercontent.com/u/306215?","gravatar_id":"7f54eba26bec8c9e8e65b4c54e860fc9","url":"https://api.github.com/users/crevillo","html_url":"https://github.com/crevillo","followers_url":"https://api.github.com/users/crevillo/followers","following_url":"https://api.github.com/users/crevillo/following{/other_user}","gists_url":"https://api.github.com/users/crevillo/gists{/gist_id}","starred_url":"https://api.github.com/users/crevillo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crevillo/subscriptions","organizations_url":"https://api.github.com/users/crevillo/orgs","repos_url":"https://api.github.com/users/crevillo/repos","events_url":"https://api.github.com/users/crevillo/events{/privacy}","received_events_url":"https://api.github.com/users/crevillo/received_events","type":"User","site_admin":false},"body":"i understand. gonna change it. ","created_at":"2014-06-26T12:08:14Z","updated_at":"2014-06-26T12:08:14Z","html_url":"https://github.com/ezsystems/EzPriceBundle/pull/13#discussion_r14236585","pull_request_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/ezsystems/EzPriceBundle/pulls/comments/14236585"},"html":{"href":"https://github.com/ezsystems/EzPriceBundle/pull/13#discussion_r14236585"},"pull_request":{"href":"https://api.github.com/repos/ezsystems/EzPriceBundle/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/ezsystems/EzPriceBundle/pulls/13","id":17641247,"html_url":"https://github.com/ezsystems/EzPriceBundle/pull/13","diff_url":"https://github.com/ezsystems/EzPriceBundle/pull/13.diff","patch_url":"https://github.com/ezsystems/EzPriceBundle/pull/13.patch","issue_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/issues/13","number":13,"state":"open","title":"Throws NotImplementedException when Automatic VAT handling is used","user":{"login":"crevillo","id":306215,"avatar_url":"https://avatars.githubusercontent.com/u/306215?","gravatar_id":"7f54eba26bec8c9e8e65b4c54e860fc9","url":"https://api.github.com/users/crevillo","html_url":"https://github.com/crevillo","followers_url":"https://api.github.com/users/crevillo/followers","following_url":"https://api.github.com/users/crevillo/following{/other_user}","gists_url":"https://api.github.com/users/crevillo/gists{/gist_id}","starred_url":"https://api.github.com/users/crevillo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crevillo/subscriptions","organizations_url":"https://api.github.com/users/crevillo/orgs","repos_url":"https://api.github.com/users/crevillo/repos","events_url":"https://api.github.com/users/crevillo/events{/privacy}","received_events_url":"https://api.github.com/users/crevillo/received_events","type":"User","site_admin":false},"body":"Exception in case Automatic VAT handled is used in the price. ","created_at":"2014-06-26T10:53:46Z","updated_at":"2014-06-26T12:08:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3732e48d346005e7cad9bf495f74ee2d8d714097","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/pulls/13/commits","review_comments_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/pulls/13/comments","review_comment_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/issues/13/comments","statuses_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/statuses/43c6e5c5984462329fba8cdcf3a6a9ede1c42ecf","head":{"label":"crevillo:manual-vat","ref":"manual-vat","sha":"43c6e5c5984462329fba8cdcf3a6a9ede1c42ecf","user":{"login":"crevillo","id":306215,"avatar_url":"https://avatars.githubusercontent.com/u/306215?","gravatar_id":"7f54eba26bec8c9e8e65b4c54e860fc9","url":"https://api.github.com/users/crevillo","html_url":"https://github.com/crevillo","followers_url":"https://api.github.com/users/crevillo/followers","following_url":"https://api.github.com/users/crevillo/following{/other_user}","gists_url":"https://api.github.com/users/crevillo/gists{/gist_id}","starred_url":"https://api.github.com/users/crevillo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crevillo/subscriptions","organizations_url":"https://api.github.com/users/crevillo/orgs","repos_url":"https://api.github.com/users/crevillo/repos","events_url":"https://api.github.com/users/crevillo/events{/privacy}","received_events_url":"https://api.github.com/users/crevillo/received_events","type":"User","site_admin":false},"repo":{"id":21032992,"name":"EzPriceBundle","full_name":"crevillo/EzPriceBundle","owner":{"login":"crevillo","id":306215,"avatar_url":"https://avatars.githubusercontent.com/u/306215?","gravatar_id":"7f54eba26bec8c9e8e65b4c54e860fc9","url":"https://api.github.com/users/crevillo","html_url":"https://github.com/crevillo","followers_url":"https://api.github.com/users/crevillo/followers","following_url":"https://api.github.com/users/crevillo/following{/other_user}","gists_url":"https://api.github.com/users/crevillo/gists{/gist_id}","starred_url":"https://api.github.com/users/crevillo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crevillo/subscriptions","organizations_url":"https://api.github.com/users/crevillo/orgs","repos_url":"https://api.github.com/users/crevillo/repos","events_url":"https://api.github.com/users/crevillo/events{/privacy}","received_events_url":"https://api.github.com/users/crevillo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/crevillo/EzPriceBundle","description":"Support for products price in eZ Publish 5.x","fork":true,"url":"https://api.github.com/repos/crevillo/EzPriceBundle","forks_url":"https://api.github.com/repos/crevillo/EzPriceBundle/forks","keys_url":"https://api.github.com/repos/crevillo/EzPriceBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crevillo/EzPriceBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crevillo/EzPriceBundle/teams","hooks_url":"https://api.github.com/repos/crevillo/EzPriceBundle/hooks","issue_events_url":"https://api.github.com/repos/crevillo/EzPriceBundle/issues/events{/number}","events_url":"https://api.github.com/repos/crevillo/EzPriceBundle/events","assignees_url":"https://api.github.com/repos/crevillo/EzPriceBundle/assignees{/user}","branches_url":"https://api.github.com/repos/crevillo/EzPriceBundle/branches{/branch}","tags_url":"https://api.github.com/repos/crevillo/EzPriceBundle/tags","blobs_url":"https://api.github.com/repos/crevillo/EzPriceBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crevillo/EzPriceBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crevillo/EzPriceBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/crevillo/EzPriceBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crevillo/EzPriceBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/crevillo/EzPriceBundle/languages","stargazers_url":"https://api.github.com/repos/crevillo/EzPriceBundle/stargazers","contributors_url":"https://api.github.com/repos/crevillo/EzPriceBundle/contributors","subscribers_url":"https://api.github.com/repos/crevillo/EzPriceBundle/subscribers","subscription_url":"https://api.github.com/repos/crevillo/EzPriceBundle/subscription","commits_url":"https://api.github.com/repos/crevillo/EzPriceBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/crevillo/EzPriceBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/crevillo/EzPriceBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/crevillo/EzPriceBundle/issues/comments/{number}","contents_url":"https://api.github.com/repos/crevillo/EzPriceBundle/contents/{+path}","compare_url":"https://api.github.com/repos/crevillo/EzPriceBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crevillo/EzPriceBundle/merges","archive_url":"https://api.github.com/repos/crevillo/EzPriceBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crevillo/EzPriceBundle/downloads","issues_url":"https://api.github.com/repos/crevillo/EzPriceBundle/issues{/number}","pulls_url":"https://api.github.com/repos/crevillo/EzPriceBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/crevillo/EzPriceBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/crevillo/EzPriceBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crevillo/EzPriceBundle/labels{/name}","releases_url":"https://api.github.com/repos/crevillo/EzPriceBundle/releases{/id}","created_at":"2014-06-20T09:42:48Z","updated_at":"2014-06-25T08:01:58Z","pushed_at":"2014-06-26T12:07:06Z","git_url":"git://github.com/crevillo/EzPriceBundle.git","ssh_url":"git@github.com:crevillo/EzPriceBundle.git","clone_url":"https://github.com/crevillo/EzPriceBundle.git","svn_url":"https://github.com/crevillo/EzPriceBundle","homepage":null,"size":274,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ezsystems:EZP-23049-manual_vat","ref":"EZP-23049-manual_vat","sha":"891bc9e2393246a44bb81622fad40f068c5ec5bc","user":{"login":"ezsystems","id":295311,"avatar_url":"https://avatars.githubusercontent.com/u/295311?","gravatar_id":"dbbdb060113a80091749fe80be36cff7","url":"https://api.github.com/users/ezsystems","html_url":"https://github.com/ezsystems","followers_url":"https://api.github.com/users/ezsystems/followers","following_url":"https://api.github.com/users/ezsystems/following{/other_user}","gists_url":"https://api.github.com/users/ezsystems/gists{/gist_id}","starred_url":"https://api.github.com/users/ezsystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezsystems/subscriptions","organizations_url":"https://api.github.com/users/ezsystems/orgs","repos_url":"https://api.github.com/users/ezsystems/repos","events_url":"https://api.github.com/users/ezsystems/events{/privacy}","received_events_url":"https://api.github.com/users/ezsystems/received_events","type":"Organization","site_admin":false},"repo":{"id":21032922,"name":"EzPriceBundle","full_name":"ezsystems/EzPriceBundle","owner":{"login":"ezsystems","id":295311,"avatar_url":"https://avatars.githubusercontent.com/u/295311?","gravatar_id":"dbbdb060113a80091749fe80be36cff7","url":"https://api.github.com/users/ezsystems","html_url":"https://github.com/ezsystems","followers_url":"https://api.github.com/users/ezsystems/followers","following_url":"https://api.github.com/users/ezsystems/following{/other_user}","gists_url":"https://api.github.com/users/ezsystems/gists{/gist_id}","starred_url":"https://api.github.com/users/ezsystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezsystems/subscriptions","organizations_url":"https://api.github.com/users/ezsystems/orgs","repos_url":"https://api.github.com/users/ezsystems/repos","events_url":"https://api.github.com/users/ezsystems/events{/privacy}","received_events_url":"https://api.github.com/users/ezsystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ezsystems/EzPriceBundle","description":"Support for products price in eZ Publish 5.x","fork":false,"url":"https://api.github.com/repos/ezsystems/EzPriceBundle","forks_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/forks","keys_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/teams","hooks_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/hooks","issue_events_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/issues/events{/number}","events_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/events","assignees_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/assignees{/user}","branches_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/branches{/branch}","tags_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/tags","blobs_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/languages","stargazers_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/stargazers","contributors_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/contributors","subscribers_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/subscribers","subscription_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/subscription","commits_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/issues/comments/{number}","contents_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/contents/{+path}","compare_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/merges","archive_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/downloads","issues_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/issues{/number}","pulls_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/labels{/name}","releases_url":"https://api.github.com/repos/ezsystems/EzPriceBundle/releases{/id}","created_at":"2014-06-20T09:40:22Z","updated_at":"2014-06-24T18:41:02Z","pushed_at":"2014-06-26T09:09:37Z","git_url":"git://github.com/ezsystems/EzPriceBundle.git","ssh_url":"git@github.com:ezsystems/EzPriceBundle.git","clone_url":"https://github.com/ezsystems/EzPriceBundle.git","svn_url":"https://github.com/ezsystems/EzPriceBundle","homepage":null,"size":525,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ezsystems/EzPriceBundle/pulls/13"},"html":{"href":"https://github.com/ezsystems/EzPriceBundle/pull/13"},"issue":{"href":"https://api.github.com/repos/ezsystems/EzPriceBundle/issues/13"},"comments":{"href":"https://api.github.com/repos/ezsystems/EzPriceBundle/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/ezsystems/EzPriceBundle/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/ezsystems/EzPriceBundle/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ezsystems/EzPriceBundle/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/ezsystems/EzPriceBundle/statuses/43c6e5c5984462329fba8cdcf3a6a9ede1c42ecf"}}}}