GitHub PullRequestReviewCommentEvent at 2014-09-26 05:35:16
Repository: pandas
Actor: jreback
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/pydata/pandas/pulls/comments/18074310","id":18074310,"diff_hunk":"@@ -2270,15 +2268,6 @@ def fillna(self, value=None, method=None, axis=0, inplace=False,\n         if value is None:\n             if method is None:\n                 raise ValueError('must specify a fill method or value')\n-            if self._is_mixed_type and axis == 1:\n-                if inplace:\n-                    raise NotImplementedError()\n-                result = self.T.fillna(method=method, limit=limit).T\n-\n-                # need to downcast here because of all of the transposes\n-                result._data = result._data.downcast()\n-\n-                return result\n ","path":"pandas/core/generic.py","position":37,"original_position":37,"commit_id":"cbde34c128d61e36c0edc63510996636616752da","original_commit_id":"cbde34c128d61e36c0edc63510996636616752da","user":{"login":"jreback","id":953992,"avatar_url":"https://avatars.githubusercontent.com/u/953992?v=2","gravatar_id":"","url":"https://api.github.com/users/jreback","html_url":"https://github.com/jreback","followers_url":"https://api.github.com/users/jreback/followers","following_url":"https://api.github.com/users/jreback/following{/other_user}","gists_url":"https://api.github.com/users/jreback/gists{/gist_id}","starred_url":"https://api.github.com/users/jreback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreback/subscriptions","organizations_url":"https://api.github.com/users/jreback/orgs","repos_url":"https://api.github.com/users/jreback/repos","events_url":"https://api.github.com/users/jreback/events{/privacy}","received_events_url":"https://api.github.com/users/jreback/received_events","type":"User","site_admin":false},"body":"why are you taking this out?","created_at":"2014-09-26T05:35:16Z","updated_at":"2014-09-26T05:35:16Z","html_url":"https://github.com/pydata/pandas/pull/8395#discussion_r18074310","pull_request_url":"https://api.github.com/repos/pydata/pandas/pulls/8395","_links":{"self":{"href":"https://api.github.com/repos/pydata/pandas/pulls/comments/18074310"},"html":{"href":"https://github.com/pydata/pandas/pull/8395#discussion_r18074310"},"pull_request":{"href":"https://api.github.com/repos/pydata/pandas/pulls/8395"}}},"pull_request":{"url":"https://api.github.com/repos/pydata/pandas/pulls/8395","id":21829245,"html_url":"https://github.com/pydata/pandas/pull/8395","diff_url":"https://github.com/pydata/pandas/pull/8395.diff","patch_url":"https://github.com/pydata/pandas/pull/8395.patch","issue_url":"https://api.github.com/repos/pydata/pandas/issues/8395","number":8395,"state":"open","locked":false,"title":"BUG: fix Panel.fillna() ignoring axis parameter","user":{"login":"stahlous","id":7545449,"avatar_url":"https://avatars.githubusercontent.com/u/7545449?v=2","gravatar_id":"","url":"https://api.github.com/users/stahlous","html_url":"https://github.com/stahlous","followers_url":"https://api.github.com/users/stahlous/followers","following_url":"https://api.github.com/users/stahlous/following{/other_user}","gists_url":"https://api.github.com/users/stahlous/gists{/gist_id}","starred_url":"https://api.github.com/users/stahlous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stahlous/subscriptions","organizations_url":"https://api.github.com/users/stahlous/orgs","repos_url":"https://api.github.com/users/stahlous/repos","events_url":"https://api.github.com/users/stahlous/events{/privacy}","received_events_url":"https://api.github.com/users/stahlous/received_events","type":"User","site_admin":false},"body":"This fixes #8251. It may need some more comprehensive tests but before I go too much farther I want to make sure the axis numbering scheme makes sense . The default behavior of `fillna` is to fill along `axis=0`. In the case of a DataFrame this fills along the columns. However, in the case of a Panel, filling along `axis=0` means you're filling along items. I'm not sure if that's the behavior that most users would think is the default. You might note that I also removed the references to what the behavior of each axis value is in the docstring since it gets a bit arbitrary when you consider both DataFrames and Panels.","created_at":"2014-09-26T05:26:38Z","updated_at":"2014-09-26T05:35:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"76f798e5b6026772b954e2e0c67a53c096aabfe0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pydata/pandas/pulls/8395/commits","review_comments_url":"https://api.github.com/repos/pydata/pandas/pulls/8395/comments","review_comment_url":"https://api.github.com/repos/pydata/pandas/pulls/comments/{number}","comments_url":"https://api.github.com/repos/pydata/pandas/issues/8395/comments","statuses_url":"https://api.github.com/repos/pydata/pandas/statuses/cbde34c128d61e36c0edc63510996636616752da","head":{"label":"stahlous:fillna_bug","ref":"fillna_bug","sha":"cbde34c128d61e36c0edc63510996636616752da","user":{"login":"stahlous","id":7545449,"avatar_url":"https://avatars.githubusercontent.com/u/7545449?v=2","gravatar_id":"","url":"https://api.github.com/users/stahlous","html_url":"https://github.com/stahlous","followers_url":"https://api.github.com/users/stahlous/followers","following_url":"https://api.github.com/users/stahlous/following{/other_user}","gists_url":"https://api.github.com/users/stahlous/gists{/gist_id}","starred_url":"https://api.github.com/users/stahlous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stahlous/subscriptions","organizations_url":"https://api.github.com/users/stahlous/orgs","repos_url":"https://api.github.com/users/stahlous/repos","events_url":"https://api.github.com/users/stahlous/events{/privacy}","received_events_url":"https://api.github.com/users/stahlous/received_events","type":"User","site_admin":false},"repo":{"id":23768960,"name":"pandas","full_name":"stahlous/pandas","owner":{"login":"stahlous","id":7545449,"avatar_url":"https://avatars.githubusercontent.com/u/7545449?v=2","gravatar_id":"","url":"https://api.github.com/users/stahlous","html_url":"https://github.com/stahlous","followers_url":"https://api.github.com/users/stahlous/followers","following_url":"https://api.github.com/users/stahlous/following{/other_user}","gists_url":"https://api.github.com/users/stahlous/gists{/gist_id}","starred_url":"https://api.github.com/users/stahlous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stahlous/subscriptions","organizations_url":"https://api.github.com/users/stahlous/orgs","repos_url":"https://api.github.com/users/stahlous/repos","events_url":"https://api.github.com/users/stahlous/events{/privacy}","received_events_url":"https://api.github.com/users/stahlous/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stahlous/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":true,"url":"https://api.github.com/repos/stahlous/pandas","forks_url":"https://api.github.com/repos/stahlous/pandas/forks","keys_url":"https://api.github.com/repos/stahlous/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stahlous/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stahlous/pandas/teams","hooks_url":"https://api.github.com/repos/stahlous/pandas/hooks","issue_events_url":"https://api.github.com/repos/stahlous/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/stahlous/pandas/events","assignees_url":"https://api.github.com/repos/stahlous/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/stahlous/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/stahlous/pandas/tags","blobs_url":"https://api.github.com/repos/stahlous/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stahlous/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stahlous/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/stahlous/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stahlous/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/stahlous/pandas/languages","stargazers_url":"https://api.github.com/repos/stahlous/pandas/stargazers","contributors_url":"https://api.github.com/repos/stahlous/pandas/contributors","subscribers_url":"https://api.github.com/repos/stahlous/pandas/subscribers","subscription_url":"https://api.github.com/repos/stahlous/pandas/subscription","commits_url":"https://api.github.com/repos/stahlous/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/stahlous/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/stahlous/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/stahlous/pandas/issues/comments/{number}","contents_url":"https://api.github.com/repos/stahlous/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/stahlous/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stahlous/pandas/merges","archive_url":"https://api.github.com/repos/stahlous/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stahlous/pandas/downloads","issues_url":"https://api.github.com/repos/stahlous/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/stahlous/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/stahlous/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/stahlous/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stahlous/pandas/labels{/name}","releases_url":"https://api.github.com/repos/stahlous/pandas/releases{/id}","created_at":"2014-09-07T19:36:18Z","updated_at":"2014-09-13T18:21:06Z","pushed_at":"2014-09-26T05:15:14Z","git_url":"git://github.com/stahlous/pandas.git","ssh_url":"git@github.com:stahlous/pandas.git","clone_url":"https://github.com/stahlous/pandas.git","svn_url":"https://github.com/stahlous/pandas","homepage":"http://pandas.pydata.org","size":37389,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pydata:master","ref":"master","sha":"0ffef1dd5aad5efd7a2b734fc21c3d8284d946fc","user":{"login":"pydata","id":1284191,"avatar_url":"https://avatars.githubusercontent.com/u/1284191?v=2","gravatar_id":"","url":"https://api.github.com/users/pydata","html_url":"https://github.com/pydata","followers_url":"https://api.github.com/users/pydata/followers","following_url":"https://api.github.com/users/pydata/following{/other_user}","gists_url":"https://api.github.com/users/pydata/gists{/gist_id}","starred_url":"https://api.github.com/users/pydata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pydata/subscriptions","organizations_url":"https://api.github.com/users/pydata/orgs","repos_url":"https://api.github.com/users/pydata/repos","events_url":"https://api.github.com/users/pydata/events{/privacy}","received_events_url":"https://api.github.com/users/pydata/received_events","type":"Organization","site_admin":false},"repo":{"id":858127,"name":"pandas","full_name":"pydata/pandas","owner":{"login":"pydata","id":1284191,"avatar_url":"https://avatars.githubusercontent.com/u/1284191?v=2","gravatar_id":"","url":"https://api.github.com/users/pydata","html_url":"https://github.com/pydata","followers_url":"https://api.github.com/users/pydata/followers","following_url":"https://api.github.com/users/pydata/following{/other_user}","gists_url":"https://api.github.com/users/pydata/gists{/gist_id}","starred_url":"https://api.github.com/users/pydata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pydata/subscriptions","organizations_url":"https://api.github.com/users/pydata/orgs","repos_url":"https://api.github.com/users/pydata/repos","events_url":"https://api.github.com/users/pydata/events{/privacy}","received_events_url":"https://api.github.com/users/pydata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pydata/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":false,"url":"https://api.github.com/repos/pydata/pandas","forks_url":"https://api.github.com/repos/pydata/pandas/forks","keys_url":"https://api.github.com/repos/pydata/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pydata/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pydata/pandas/teams","hooks_url":"https://api.github.com/repos/pydata/pandas/hooks","issue_events_url":"https://api.github.com/repos/pydata/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/pydata/pandas/events","assignees_url":"https://api.github.com/repos/pydata/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/pydata/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/pydata/pandas/tags","blobs_url":"https://api.github.com/repos/pydata/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pydata/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pydata/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/pydata/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pydata/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/pydata/pandas/languages","stargazers_url":"https://api.github.com/repos/pydata/pandas/stargazers","contributors_url":"https://api.github.com/repos/pydata/pandas/contributors","subscribers_url":"https://api.github.com/repos/pydata/pandas/subscribers","subscription_url":"https://api.github.com/repos/pydata/pandas/subscription","commits_url":"https://api.github.com/repos/pydata/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/pydata/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/pydata/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/pydata/pandas/issues/comments/{number}","contents_url":"https://api.github.com/repos/pydata/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/pydata/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pydata/pandas/merges","archive_url":"https://api.github.com/repos/pydata/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pydata/pandas/downloads","issues_url":"https://api.github.com/repos/pydata/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/pydata/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/pydata/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/pydata/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pydata/pandas/labels{/name}","releases_url":"https://api.github.com/repos/pydata/pandas/releases{/id}","created_at":"2010-08-24T01:37:33Z","updated_at":"2014-09-26T04:39:27Z","pushed_at":"2014-09-25T22:14:34Z","git_url":"git://github.com/pydata/pandas.git","ssh_url":"git@github.com:pydata/pandas.git","clone_url":"https://github.com/pydata/pandas.git","svn_url":"https://github.com/pydata/pandas","homepage":"http://pandas.pydata.org","size":93354,"stargazers_count":3401,"watchers_count":3401,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1138,"mirror_url":null,"open_issues_count":1053,"forks":1138,"open_issues":1053,"watchers":3401,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pydata/pandas/pulls/8395"},"html":{"href":"https://github.com/pydata/pandas/pull/8395"},"issue":{"href":"https://api.github.com/repos/pydata/pandas/issues/8395"},"comments":{"href":"https://api.github.com/repos/pydata/pandas/issues/8395/comments"},"review_comments":{"href":"https://api.github.com/repos/pydata/pandas/pulls/8395/comments"},"review_comment":{"href":"https://api.github.com/repos/pydata/pandas/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/pydata/pandas/pulls/8395/commits"},"statuses":{"href":"https://api.github.com/repos/pydata/pandas/statuses/cbde34c128d61e36c0edc63510996636616752da"}}}}