GitHub PullRequestReviewCommentEvent at 2014-08-07 00:53:00
Repository: zamboni
Actor: cvan
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/zamboni/pulls/comments/15913430","id":15913430,"diff_hunk":"@@ -1400,3 +1401,63 @@ def test_update_rating_still_complete(self, complete_errs):\n         eq_(_ratings_success_msg(self.app, amo.STATUS_PENDING,\n                                  self.days_ago(5).isoformat()),\n             _submission_msgs()['content_ratings_saved'])\n+\n+\n+class TestMotd(amo.tests.TestCase):\n+    fixtures = fixture('user_editor', 'user_999')\n+\n+    def setUp(self):\n+        self.login('editor')\n+        self.url = reverse('mkt.developers.motd')\n+        self.key = u'mkt_developers_motd'\n+        set_config(self.key, u'original value')\n+\n+    def test_not_logged_in(self):\n+        self.client.logout()\n+        req = self.client.get(self.url, follow=True)\n+        self.assertLoginRedirects(req, self.url)\n+\n+    def test_perms_not_editor(self):\n+        self.client.logout()\n+        self.login('regular')\n+        eq_(self.client.get(self.url).status_code, 403)\n+\n+    def test_perms_not_motd(self):\n+\n+        # You can't see the edit page if you can't edit it.\n+        req = self.client.get(self.url)\n+        eq_(req.status_code, 403)\n+\n+    def test_motd_get_form(self):","path":"mkt/developers/tests/test_views.py","position":48,"original_position":48,"commit_id":"13b618dcaa1a1521c034e27aec379b5ddaa2e729","original_commit_id":"13b618dcaa1a1521c034e27aec379b5ddaa2e729","user":{"login":"cvan","id":203725,"avatar_url":"https://avatars.githubusercontent.com/u/203725?v=2","gravatar_id":"47de0e6948b289c9b4b4be0d6d66c0f4","url":"https://api.github.com/users/cvan","html_url":"https://github.com/cvan","followers_url":"https://api.github.com/users/cvan/followers","following_url":"https://api.github.com/users/cvan/following{/other_user}","gists_url":"https://api.github.com/users/cvan/gists{/gist_id}","starred_url":"https://api.github.com/users/cvan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cvan/subscriptions","organizations_url":"https://api.github.com/users/cvan/orgs","repos_url":"https://api.github.com/users/cvan/repos","events_url":"https://api.github.com/users/cvan/events{/privacy}","received_events_url":"https://api.github.com/users/cvan/received_events","type":"User","site_admin":false},"body":"maybe call it `test_motd_form_initial`?","created_at":"2014-08-07T00:53:00Z","updated_at":"2014-08-07T00:53:00Z","html_url":"https://github.com/mozilla/zamboni/pull/2376#discussion_r15913430","pull_request_url":"https://api.github.com/repos/mozilla/zamboni/pulls/2376","_links":{"self":{"href":"https://api.github.com/repos/mozilla/zamboni/pulls/comments/15913430"},"html":{"href":"https://github.com/mozilla/zamboni/pull/2376#discussion_r15913430"},"pull_request":{"href":"https://api.github.com/repos/mozilla/zamboni/pulls/2376"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/zamboni/pulls/2376","id":19376765,"html_url":"https://github.com/mozilla/zamboni/pull/2376","diff_url":"https://github.com/mozilla/zamboni/pull/2376.diff","patch_url":"https://github.com/mozilla/zamboni/pull/2376.patch","issue_url":"https://api.github.com/repos/mozilla/zamboni/issues/2376","number":2376,"state":"open","title":"Add developer MOTD (bug 945956)","user":{"login":"dethe","id":16825,"avatar_url":"https://avatars.githubusercontent.com/u/16825?v=2","gravatar_id":"52ff1ad7a3502128d76194241e1a7465","url":"https://api.github.com/users/dethe","html_url":"https://github.com/dethe","followers_url":"https://api.github.com/users/dethe/followers","following_url":"https://api.github.com/users/dethe/following{/other_user}","gists_url":"https://api.github.com/users/dethe/gists{/gist_id}","starred_url":"https://api.github.com/users/dethe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dethe/subscriptions","organizations_url":"https://api.github.com/users/dethe/orgs","repos_url":"https://api.github.com/users/dethe/repos","events_url":"https://api.github.com/users/dethe/events{/privacy}","received_events_url":"https://api.github.com/users/dethe/received_events","type":"User","site_admin":false},"body":"Added MOTD to My Submissions page, along with page for editing it, permission for editing. Moved some CSS and JavaScript around to make existing MOTD code more general.\r\n\r\nSquashed commit messages:\r\nneeds ACL\r\nimplemented motd for My Submissions page\r\nadded menu to set developer motd\r\nadded migration","created_at":"2014-08-05T23:28:32Z","updated_at":"2014-08-07T00:53:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"39f8e0abfc925ec13577053d9ca4b394f9b57924","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/zamboni/pulls/2376/commits","review_comments_url":"https://api.github.com/repos/mozilla/zamboni/pulls/2376/comments","review_comment_url":"https://api.github.com/repos/mozilla/zamboni/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla/zamboni/issues/2376/comments","statuses_url":"https://api.github.com/repos/mozilla/zamboni/statuses/13b618dcaa1a1521c034e27aec379b5ddaa2e729","head":{"label":"dethe:developer_motd","ref":"developer_motd","sha":"13b618dcaa1a1521c034e27aec379b5ddaa2e729","user":{"login":"dethe","id":16825,"avatar_url":"https://avatars.githubusercontent.com/u/16825?v=2","gravatar_id":"52ff1ad7a3502128d76194241e1a7465","url":"https://api.github.com/users/dethe","html_url":"https://github.com/dethe","followers_url":"https://api.github.com/users/dethe/followers","following_url":"https://api.github.com/users/dethe/following{/other_user}","gists_url":"https://api.github.com/users/dethe/gists{/gist_id}","starred_url":"https://api.github.com/users/dethe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dethe/subscriptions","organizations_url":"https://api.github.com/users/dethe/orgs","repos_url":"https://api.github.com/users/dethe/repos","events_url":"https://api.github.com/users/dethe/events{/privacy}","received_events_url":"https://api.github.com/users/dethe/received_events","type":"User","site_admin":false},"repo":{"id":16929109,"name":"zamboni","full_name":"dethe/zamboni","owner":{"login":"dethe","id":16825,"avatar_url":"https://avatars.githubusercontent.com/u/16825?v=2","gravatar_id":"52ff1ad7a3502128d76194241e1a7465","url":"https://api.github.com/users/dethe","html_url":"https://github.com/dethe","followers_url":"https://api.github.com/users/dethe/followers","following_url":"https://api.github.com/users/dethe/following{/other_user}","gists_url":"https://api.github.com/users/dethe/gists{/gist_id}","starred_url":"https://api.github.com/users/dethe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dethe/subscriptions","organizations_url":"https://api.github.com/users/dethe/orgs","repos_url":"https://api.github.com/users/dethe/repos","events_url":"https://api.github.com/users/dethe/events{/privacy}","received_events_url":"https://api.github.com/users/dethe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dethe/zamboni","description":"The Firefox Marketplace and addons.mozilla.org","fork":true,"url":"https://api.github.com/repos/dethe/zamboni","forks_url":"https://api.github.com/repos/dethe/zamboni/forks","keys_url":"https://api.github.com/repos/dethe/zamboni/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dethe/zamboni/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dethe/zamboni/teams","hooks_url":"https://api.github.com/repos/dethe/zamboni/hooks","issue_events_url":"https://api.github.com/repos/dethe/zamboni/issues/events{/number}","events_url":"https://api.github.com/repos/dethe/zamboni/events","assignees_url":"https://api.github.com/repos/dethe/zamboni/assignees{/user}","branches_url":"https://api.github.com/repos/dethe/zamboni/branches{/branch}","tags_url":"https://api.github.com/repos/dethe/zamboni/tags","blobs_url":"https://api.github.com/repos/dethe/zamboni/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dethe/zamboni/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dethe/zamboni/git/refs{/sha}","trees_url":"https://api.github.com/repos/dethe/zamboni/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dethe/zamboni/statuses/{sha}","languages_url":"https://api.github.com/repos/dethe/zamboni/languages","stargazers_url":"https://api.github.com/repos/dethe/zamboni/stargazers","contributors_url":"https://api.github.com/repos/dethe/zamboni/contributors","subscribers_url":"https://api.github.com/repos/dethe/zamboni/subscribers","subscription_url":"https://api.github.com/repos/dethe/zamboni/subscription","commits_url":"https://api.github.com/repos/dethe/zamboni/commits{/sha}","git_commits_url":"https://api.github.com/repos/dethe/zamboni/git/commits{/sha}","comments_url":"https://api.github.com/repos/dethe/zamboni/comments{/number}","issue_comment_url":"https://api.github.com/repos/dethe/zamboni/issues/comments/{number}","contents_url":"https://api.github.com/repos/dethe/zamboni/contents/{+path}","compare_url":"https://api.github.com/repos/dethe/zamboni/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dethe/zamboni/merges","archive_url":"https://api.github.com/repos/dethe/zamboni/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dethe/zamboni/downloads","issues_url":"https://api.github.com/repos/dethe/zamboni/issues{/number}","pulls_url":"https://api.github.com/repos/dethe/zamboni/pulls{/number}","milestones_url":"https://api.github.com/repos/dethe/zamboni/milestones{/number}","notifications_url":"https://api.github.com/repos/dethe/zamboni/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dethe/zamboni/labels{/name}","releases_url":"https://api.github.com/repos/dethe/zamboni/releases{/id}","created_at":"2014-02-17T22:42:11Z","updated_at":"2014-06-11T00:15:33Z","pushed_at":"2014-08-07T00:29:40Z","git_url":"git://github.com/dethe/zamboni.git","ssh_url":"git@github.com:dethe/zamboni.git","clone_url":"https://github.com/dethe/zamboni.git","svn_url":"https://github.com/dethe/zamboni","homepage":"http://zamboni.readthedocs.org","size":275499,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":false,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"64e946592fbde35a4f8b20e057ed8af920f7c575","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=2","gravatar_id":"9ba739c8f3288e256b13553e4d257b5e","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":347655,"name":"zamboni","full_name":"mozilla/zamboni","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=2","gravatar_id":"9ba739c8f3288e256b13553e4d257b5e","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/zamboni","description":"The backend of the Firefox Marketplace","fork":false,"url":"https://api.github.com/repos/mozilla/zamboni","forks_url":"https://api.github.com/repos/mozilla/zamboni/forks","keys_url":"https://api.github.com/repos/mozilla/zamboni/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/zamboni/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/zamboni/teams","hooks_url":"https://api.github.com/repos/mozilla/zamboni/hooks","issue_events_url":"https://api.github.com/repos/mozilla/zamboni/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/zamboni/events","assignees_url":"https://api.github.com/repos/mozilla/zamboni/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/zamboni/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/zamboni/tags","blobs_url":"https://api.github.com/repos/mozilla/zamboni/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/zamboni/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/zamboni/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/zamboni/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/zamboni/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/zamboni/languages","stargazers_url":"https://api.github.com/repos/mozilla/zamboni/stargazers","contributors_url":"https://api.github.com/repos/mozilla/zamboni/contributors","subscribers_url":"https://api.github.com/repos/mozilla/zamboni/subscribers","subscription_url":"https://api.github.com/repos/mozilla/zamboni/subscription","commits_url":"https://api.github.com/repos/mozilla/zamboni/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/zamboni/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/zamboni/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/zamboni/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla/zamboni/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/zamboni/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/zamboni/merges","archive_url":"https://api.github.com/repos/mozilla/zamboni/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/zamboni/downloads","issues_url":"https://api.github.com/repos/mozilla/zamboni/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/zamboni/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/zamboni/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/zamboni/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/zamboni/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/zamboni/releases{/id}","created_at":"2009-10-23T19:35:34Z","updated_at":"2014-08-04T13:57:31Z","pushed_at":"2014-08-06T21:43:28Z","git_url":"git://github.com/mozilla/zamboni.git","ssh_url":"git@github.com:mozilla/zamboni.git","clone_url":"https://github.com/mozilla/zamboni.git","svn_url":"https://github.com/mozilla/zamboni","homepage":"http://zamboni.readthedocs.org","size":353178,"stargazers_count":424,"watchers_count":424,"language":"Python","has_issues":true,"has_downloads":false,"has_wiki":false,"forks_count":229,"mirror_url":null,"open_issues_count":17,"forks":229,"open_issues":17,"watchers":424,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/zamboni/pulls/2376"},"html":{"href":"https://github.com/mozilla/zamboni/pull/2376"},"issue":{"href":"https://api.github.com/repos/mozilla/zamboni/issues/2376"},"comments":{"href":"https://api.github.com/repos/mozilla/zamboni/issues/2376/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/zamboni/pulls/2376/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/zamboni/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla/zamboni/pulls/2376/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/zamboni/statuses/13b618dcaa1a1521c034e27aec379b5ddaa2e729"}}}}