GitHub PullRequestReviewCommentEvent at 2014-10-22 19:14:56
Repository: Panoptes
Actor: camallen
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/zooniverse/Panoptes/pulls/comments/19237330","id":19237330,"diff_hunk":"@@ -0,0 +1,18 @@\n+require 'multi_kafka_producer'\n+\n+def kafka_config\n+  return @config if @config\n+  @config = YAML.load(ERB.new(File.read(Rails.root.join('config/kafka.yml'))).result)\n+  @config[Rails.env].symbolize_keys\n+rescue Errno::ENOENT\n+  @config = {  }\n+end\n+\n+unless kafka_config.empty?\n+  MultiKafkaProducer.adapter = nil","path":"config/initializers/kafka.rb","position":12,"original_position":12,"commit_id":"a91ff297b5561de982e30780b9096dc570e057bd","original_commit_id":"a91ff297b5561de982e30780b9096dc570e057bd","user":{"login":"camallen","id":295329,"avatar_url":"https://avatars.githubusercontent.com/u/295329?v=2","gravatar_id":"","url":"https://api.github.com/users/camallen","html_url":"https://github.com/camallen","followers_url":"https://api.github.com/users/camallen/followers","following_url":"https://api.github.com/users/camallen/following{/other_user}","gists_url":"https://api.github.com/users/camallen/gists{/gist_id}","starred_url":"https://api.github.com/users/camallen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/camallen/subscriptions","organizations_url":"https://api.github.com/users/camallen/orgs","repos_url":"https://api.github.com/users/camallen/repos","events_url":"https://api.github.com/users/camallen/events{/privacy}","received_events_url":"https://api.github.com/users/camallen/received_events","type":"User","site_admin":false},"body":"No biggie but perhaps extract the common setup calls and use the conditional to setup the params to DRY it up.","created_at":"2014-10-22T19:14:56Z","updated_at":"2014-10-22T19:14:56Z","html_url":"https://github.com/zooniverse/Panoptes/pull/210#discussion_r19237330","pull_request_url":"https://api.github.com/repos/zooniverse/Panoptes/pulls/210","_links":{"self":{"href":"https://api.github.com/repos/zooniverse/Panoptes/pulls/comments/19237330"},"html":{"href":"https://github.com/zooniverse/Panoptes/pull/210#discussion_r19237330"},"pull_request":{"href":"https://api.github.com/repos/zooniverse/Panoptes/pulls/210"}}},"pull_request":{"url":"https://api.github.com/repos/zooniverse/Panoptes/pulls/210","id":22890329,"html_url":"https://github.com/zooniverse/Panoptes/pull/210","diff_url":"https://github.com/zooniverse/Panoptes/pull/210.diff","patch_url":"https://github.com/zooniverse/Panoptes/pull/210.patch","issue_url":"https://api.github.com/repos/zooniverse/Panoptes/issues/210","number":210,"state":"open","locked":false,"title":"Add Sidekiq and Kafka. ","user":{"login":"edpaget","id":108177,"avatar_url":"https://avatars.githubusercontent.com/u/108177?v=2","gravatar_id":"","url":"https://api.github.com/users/edpaget","html_url":"https://github.com/edpaget","followers_url":"https://api.github.com/users/edpaget/followers","following_url":"https://api.github.com/users/edpaget/following{/other_user}","gists_url":"https://api.github.com/users/edpaget/gists{/gist_id}","starred_url":"https://api.github.com/users/edpaget/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edpaget/subscriptions","organizations_url":"https://api.github.com/users/edpaget/orgs","repos_url":"https://api.github.com/users/edpaget/repos","events_url":"https://api.github.com/users/edpaget/events{/privacy}","received_events_url":"https://api.github.com/users/edpaget/received_events","type":"User","site_admin":false},"body":"Also:\r\n+ KafkaEvent to publish arbitrary info about models, still kind of a work in progress\r\n+ ClassificationLifecycle management moved to a sidekiq worker\r\n+ MultiKafkaProducer Module to abstract between jruby-kafka and poseidon. \r\n\r\nWhen running jruby you'll also need to use jbundler to manage Kafka libraries. ","created_at":"2014-10-16T22:01:58Z","updated_at":"2014-10-22T19:14:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4523ac7f5f3a73eb3d6d0b091ca8dc42d73c689c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zooniverse/Panoptes/pulls/210/commits","review_comments_url":"https://api.github.com/repos/zooniverse/Panoptes/pulls/210/comments","review_comment_url":"https://api.github.com/repos/zooniverse/Panoptes/pulls/comments/{number}","comments_url":"https://api.github.com/repos/zooniverse/Panoptes/issues/210/comments","statuses_url":"https://api.github.com/repos/zooniverse/Panoptes/statuses/a91ff297b5561de982e30780b9096dc570e057bd","head":{"label":"edpaget:sidekiq-kafka","ref":"sidekiq-kafka","sha":"a91ff297b5561de982e30780b9096dc570e057bd","user":{"login":"edpaget","id":108177,"avatar_url":"https://avatars.githubusercontent.com/u/108177?v=2","gravatar_id":"","url":"https://api.github.com/users/edpaget","html_url":"https://github.com/edpaget","followers_url":"https://api.github.com/users/edpaget/followers","following_url":"https://api.github.com/users/edpaget/following{/other_user}","gists_url":"https://api.github.com/users/edpaget/gists{/gist_id}","starred_url":"https://api.github.com/users/edpaget/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edpaget/subscriptions","organizations_url":"https://api.github.com/users/edpaget/orgs","repos_url":"https://api.github.com/users/edpaget/repos","events_url":"https://api.github.com/users/edpaget/events{/privacy}","received_events_url":"https://api.github.com/users/edpaget/received_events","type":"User","site_admin":false},"repo":{"id":20313194,"name":"Panoptes","full_name":"edpaget/Panoptes","owner":{"login":"edpaget","id":108177,"avatar_url":"https://avatars.githubusercontent.com/u/108177?v=2","gravatar_id":"","url":"https://api.github.com/users/edpaget","html_url":"https://github.com/edpaget","followers_url":"https://api.github.com/users/edpaget/followers","following_url":"https://api.github.com/users/edpaget/following{/other_user}","gists_url":"https://api.github.com/users/edpaget/gists{/gist_id}","starred_url":"https://api.github.com/users/edpaget/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edpaget/subscriptions","organizations_url":"https://api.github.com/users/edpaget/orgs","repos_url":"https://api.github.com/users/edpaget/repos","events_url":"https://api.github.com/users/edpaget/events{/privacy}","received_events_url":"https://api.github.com/users/edpaget/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/edpaget/Panoptes","description":"It sees everything","fork":true,"url":"https://api.github.com/repos/edpaget/Panoptes","forks_url":"https://api.github.com/repos/edpaget/Panoptes/forks","keys_url":"https://api.github.com/repos/edpaget/Panoptes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edpaget/Panoptes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edpaget/Panoptes/teams","hooks_url":"https://api.github.com/repos/edpaget/Panoptes/hooks","issue_events_url":"https://api.github.com/repos/edpaget/Panoptes/issues/events{/number}","events_url":"https://api.github.com/repos/edpaget/Panoptes/events","assignees_url":"https://api.github.com/repos/edpaget/Panoptes/assignees{/user}","branches_url":"https://api.github.com/repos/edpaget/Panoptes/branches{/branch}","tags_url":"https://api.github.com/repos/edpaget/Panoptes/tags","blobs_url":"https://api.github.com/repos/edpaget/Panoptes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edpaget/Panoptes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edpaget/Panoptes/git/refs{/sha}","trees_url":"https://api.github.com/repos/edpaget/Panoptes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edpaget/Panoptes/statuses/{sha}","languages_url":"https://api.github.com/repos/edpaget/Panoptes/languages","stargazers_url":"https://api.github.com/repos/edpaget/Panoptes/stargazers","contributors_url":"https://api.github.com/repos/edpaget/Panoptes/contributors","subscribers_url":"https://api.github.com/repos/edpaget/Panoptes/subscribers","subscription_url":"https://api.github.com/repos/edpaget/Panoptes/subscription","commits_url":"https://api.github.com/repos/edpaget/Panoptes/commits{/sha}","git_commits_url":"https://api.github.com/repos/edpaget/Panoptes/git/commits{/sha}","comments_url":"https://api.github.com/repos/edpaget/Panoptes/comments{/number}","issue_comment_url":"https://api.github.com/repos/edpaget/Panoptes/issues/comments/{number}","contents_url":"https://api.github.com/repos/edpaget/Panoptes/contents/{+path}","compare_url":"https://api.github.com/repos/edpaget/Panoptes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edpaget/Panoptes/merges","archive_url":"https://api.github.com/repos/edpaget/Panoptes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edpaget/Panoptes/downloads","issues_url":"https://api.github.com/repos/edpaget/Panoptes/issues{/number}","pulls_url":"https://api.github.com/repos/edpaget/Panoptes/pulls{/number}","milestones_url":"https://api.github.com/repos/edpaget/Panoptes/milestones{/number}","notifications_url":"https://api.github.com/repos/edpaget/Panoptes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edpaget/Panoptes/labels{/name}","releases_url":"https://api.github.com/repos/edpaget/Panoptes/releases{/id}","created_at":"2014-05-30T01:09:54Z","updated_at":"2014-06-25T16:11:06Z","pushed_at":"2014-10-22T16:23:39Z","git_url":"git://github.com/edpaget/Panoptes.git","ssh_url":"git@github.com:edpaget/Panoptes.git","clone_url":"https://github.com/edpaget/Panoptes.git","svn_url":"https://github.com/edpaget/Panoptes","homepage":"","size":4347,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zooniverse:master","ref":"master","sha":"cf032a0c3f95a5b7ab1a0035b26a117c1b240a72","user":{"login":"zooniverse","id":106856,"avatar_url":"https://avatars.githubusercontent.com/u/106856?v=2","gravatar_id":"","url":"https://api.github.com/users/zooniverse","html_url":"https://github.com/zooniverse","followers_url":"https://api.github.com/users/zooniverse/followers","following_url":"https://api.github.com/users/zooniverse/following{/other_user}","gists_url":"https://api.github.com/users/zooniverse/gists{/gist_id}","starred_url":"https://api.github.com/users/zooniverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zooniverse/subscriptions","organizations_url":"https://api.github.com/users/zooniverse/orgs","repos_url":"https://api.github.com/users/zooniverse/repos","events_url":"https://api.github.com/users/zooniverse/events{/privacy}","received_events_url":"https://api.github.com/users/zooniverse/received_events","type":"Organization","site_admin":false},"repo":{"id":19036577,"name":"Panoptes","full_name":"zooniverse/Panoptes","owner":{"login":"zooniverse","id":106856,"avatar_url":"https://avatars.githubusercontent.com/u/106856?v=2","gravatar_id":"","url":"https://api.github.com/users/zooniverse","html_url":"https://github.com/zooniverse","followers_url":"https://api.github.com/users/zooniverse/followers","following_url":"https://api.github.com/users/zooniverse/following{/other_user}","gists_url":"https://api.github.com/users/zooniverse/gists{/gist_id}","starred_url":"https://api.github.com/users/zooniverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zooniverse/subscriptions","organizations_url":"https://api.github.com/users/zooniverse/orgs","repos_url":"https://api.github.com/users/zooniverse/repos","events_url":"https://api.github.com/users/zooniverse/events{/privacy}","received_events_url":"https://api.github.com/users/zooniverse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zooniverse/Panoptes","description":"It sees everything","fork":false,"url":"https://api.github.com/repos/zooniverse/Panoptes","forks_url":"https://api.github.com/repos/zooniverse/Panoptes/forks","keys_url":"https://api.github.com/repos/zooniverse/Panoptes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zooniverse/Panoptes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zooniverse/Panoptes/teams","hooks_url":"https://api.github.com/repos/zooniverse/Panoptes/hooks","issue_events_url":"https://api.github.com/repos/zooniverse/Panoptes/issues/events{/number}","events_url":"https://api.github.com/repos/zooniverse/Panoptes/events","assignees_url":"https://api.github.com/repos/zooniverse/Panoptes/assignees{/user}","branches_url":"https://api.github.com/repos/zooniverse/Panoptes/branches{/branch}","tags_url":"https://api.github.com/repos/zooniverse/Panoptes/tags","blobs_url":"https://api.github.com/repos/zooniverse/Panoptes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zooniverse/Panoptes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zooniverse/Panoptes/git/refs{/sha}","trees_url":"https://api.github.com/repos/zooniverse/Panoptes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zooniverse/Panoptes/statuses/{sha}","languages_url":"https://api.github.com/repos/zooniverse/Panoptes/languages","stargazers_url":"https://api.github.com/repos/zooniverse/Panoptes/stargazers","contributors_url":"https://api.github.com/repos/zooniverse/Panoptes/contributors","subscribers_url":"https://api.github.com/repos/zooniverse/Panoptes/subscribers","subscription_url":"https://api.github.com/repos/zooniverse/Panoptes/subscription","commits_url":"https://api.github.com/repos/zooniverse/Panoptes/commits{/sha}","git_commits_url":"https://api.github.com/repos/zooniverse/Panoptes/git/commits{/sha}","comments_url":"https://api.github.com/repos/zooniverse/Panoptes/comments{/number}","issue_comment_url":"https://api.github.com/repos/zooniverse/Panoptes/issues/comments/{number}","contents_url":"https://api.github.com/repos/zooniverse/Panoptes/contents/{+path}","compare_url":"https://api.github.com/repos/zooniverse/Panoptes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zooniverse/Panoptes/merges","archive_url":"https://api.github.com/repos/zooniverse/Panoptes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zooniverse/Panoptes/downloads","issues_url":"https://api.github.com/repos/zooniverse/Panoptes/issues{/number}","pulls_url":"https://api.github.com/repos/zooniverse/Panoptes/pulls{/number}","milestones_url":"https://api.github.com/repos/zooniverse/Panoptes/milestones{/number}","notifications_url":"https://api.github.com/repos/zooniverse/Panoptes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zooniverse/Panoptes/labels{/name}","releases_url":"https://api.github.com/repos/zooniverse/Panoptes/releases{/id}","created_at":"2014-04-22T16:16:02Z","updated_at":"2014-10-09T17:44:42Z","pushed_at":"2014-10-22T14:17:42Z","git_url":"git://github.com/zooniverse/Panoptes.git","ssh_url":"git@github.com:zooniverse/Panoptes.git","clone_url":"https://github.com/zooniverse/Panoptes.git","svn_url":"https://github.com/zooniverse/Panoptes","homepage":"","size":6035,"stargazers_count":4,"watchers_count":4,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":15,"forks":5,"open_issues":15,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zooniverse/Panoptes/pulls/210"},"html":{"href":"https://github.com/zooniverse/Panoptes/pull/210"},"issue":{"href":"https://api.github.com/repos/zooniverse/Panoptes/issues/210"},"comments":{"href":"https://api.github.com/repos/zooniverse/Panoptes/issues/210/comments"},"review_comments":{"href":"https://api.github.com/repos/zooniverse/Panoptes/pulls/210/comments"},"review_comment":{"href":"https://api.github.com/repos/zooniverse/Panoptes/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/zooniverse/Panoptes/pulls/210/commits"},"statuses":{"href":"https://api.github.com/repos/zooniverse/Panoptes/statuses/a91ff297b5561de982e30780b9096dc570e057bd"}}}}