GitHub PullRequestEvent at 2014-04-25 02:00:46
Repository: grunt-ftpscript
Actor: netwjx
Payload: {"action":"closed","number":2,"pull_request":{"url":"https://api.github.com/repos/netwjx/grunt-ftpscript/pulls/2","id":15031929,"html_url":"https://github.com/netwjx/grunt-ftpscript/pull/2","diff_url":"https://github.com/netwjx/grunt-ftpscript/pull/2.diff","patch_url":"https://github.com/netwjx/grunt-ftpscript/pull/2.patch","issue_url":"https://api.github.com/repos/netwjx/grunt-ftpscript/issues/2","number":2,"state":"closed","title":"Allow auth explicit configuration in task options.","user":{"login":"honi","id":130202,"avatar_url":"https://avatars.githubusercontent.com/u/130202?","gravatar_id":"a63fd082b12cc633c0ffd218a7f1fe89","url":"https://api.github.com/users/honi","html_url":"https://github.com/honi","followers_url":"https://api.github.com/users/honi/followers","following_url":"https://api.github.com/users/honi/following{/other_user}","gists_url":"https://api.github.com/users/honi/gists{/gist_id}","starred_url":"https://api.github.com/users/honi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/honi/subscriptions","organizations_url":"https://api.github.com/users/honi/orgs","repos_url":"https://api.github.com/users/honi/repos","events_url":"https://api.github.com/users/honi/events{/privacy}","received_events_url":"https://api.github.com/users/honi/received_events","type":"User","site_admin":false},"body":"I know this could lead to a security risk if committed into source control. That's why I've added to the documentation a warning about it.\r\n\r\nThe reason I needed this is because I have some other sensitive information I don't want to put into source control, and I didn't want to have 2 separate files (.ftppass and my other file). Now I can put all my auth configs in one file, and then pass the ftp user/pass via the task options.","created_at":"2014-04-22T19:43:10Z","updated_at":"2014-04-25T02:00:46Z","closed_at":"2014-04-25T02:00:46Z","merged_at":"2014-04-25T02:00:46Z","merge_commit_sha":"d07a0c57983122418cc9aaff0e563a5986039ede","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/netwjx/grunt-ftpscript/pulls/2/commits","review_comments_url":"https://api.github.com/repos/netwjx/grunt-ftpscript/pulls/2/comments","review_comment_url":"https://api.github.com/repos/netwjx/grunt-ftpscript/pulls/comments/{number}","comments_url":"https://api.github.com/repos/netwjx/grunt-ftpscript/issues/2/comments","statuses_url":"https://api.github.com/repos/netwjx/grunt-ftpscript/statuses/2e58697f293e07c4c1a6b7257c062f25fb518707","head":{"label":"honi:master","ref":"master","sha":"2e58697f293e07c4c1a6b7257c062f25fb518707","user":{"login":"honi","id":130202,"avatar_url":"https://avatars.githubusercontent.com/u/130202?","gravatar_id":"a63fd082b12cc633c0ffd218a7f1fe89","url":"https://api.github.com/users/honi","html_url":"https://github.com/honi","followers_url":"https://api.github.com/users/honi/followers","following_url":"https://api.github.com/users/honi/following{/other_user}","gists_url":"https://api.github.com/users/honi/gists{/gist_id}","starred_url":"https://api.github.com/users/honi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/honi/subscriptions","organizations_url":"https://api.github.com/users/honi/orgs","repos_url":"https://api.github.com/users/honi/repos","events_url":"https://api.github.com/users/honi/events{/privacy}","received_events_url":"https://api.github.com/users/honi/received_events","type":"User","site_admin":false},"repo":{"id":19043020,"name":"grunt-ftpscript","full_name":"honi/grunt-ftpscript","owner":{"login":"honi","id":130202,"avatar_url":"https://avatars.githubusercontent.com/u/130202?","gravatar_id":"a63fd082b12cc633c0ffd218a7f1fe89","url":"https://api.github.com/users/honi","html_url":"https://github.com/honi","followers_url":"https://api.github.com/users/honi/followers","following_url":"https://api.github.com/users/honi/following{/other_user}","gists_url":"https://api.github.com/users/honi/gists{/gist_id}","starred_url":"https://api.github.com/users/honi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/honi/subscriptions","organizations_url":"https://api.github.com/users/honi/orgs","repos_url":"https://api.github.com/users/honi/repos","events_url":"https://api.github.com/users/honi/events{/privacy}","received_events_url":"https://api.github.com/users/honi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/honi/grunt-ftpscript","description":"Upload files to FTP Server, Active or Passive mode, base ftp command.","fork":true,"url":"https://api.github.com/repos/honi/grunt-ftpscript","forks_url":"https://api.github.com/repos/honi/grunt-ftpscript/forks","keys_url":"https://api.github.com/repos/honi/grunt-ftpscript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/honi/grunt-ftpscript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/honi/grunt-ftpscript/teams","hooks_url":"https://api.github.com/repos/honi/grunt-ftpscript/hooks","issue_events_url":"https://api.github.com/repos/honi/grunt-ftpscript/issues/events{/number}","events_url":"https://api.github.com/repos/honi/grunt-ftpscript/events","assignees_url":"https://api.github.com/repos/honi/grunt-ftpscript/assignees{/user}","branches_url":"https://api.github.com/repos/honi/grunt-ftpscript/branches{/branch}","tags_url":"https://api.github.com/repos/honi/grunt-ftpscript/tags","blobs_url":"https://api.github.com/repos/honi/grunt-ftpscript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/honi/grunt-ftpscript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/honi/grunt-ftpscript/git/refs{/sha}","trees_url":"https://api.github.com/repos/honi/grunt-ftpscript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/honi/grunt-ftpscript/statuses/{sha}","languages_url":"https://api.github.com/repos/honi/grunt-ftpscript/languages","stargazers_url":"https://api.github.com/repos/honi/grunt-ftpscript/stargazers","contributors_url":"https://api.github.com/repos/honi/grunt-ftpscript/contributors","subscribers_url":"https://api.github.com/repos/honi/grunt-ftpscript/subscribers","subscription_url":"https://api.github.com/repos/honi/grunt-ftpscript/subscription","commits_url":"https://api.github.com/repos/honi/grunt-ftpscript/commits{/sha}","git_commits_url":"https://api.github.com/repos/honi/grunt-ftpscript/git/commits{/sha}","comments_url":"https://api.github.com/repos/honi/grunt-ftpscript/comments{/number}","issue_comment_url":"https://api.github.com/repos/honi/grunt-ftpscript/issues/comments/{number}","contents_url":"https://api.github.com/repos/honi/grunt-ftpscript/contents/{+path}","compare_url":"https://api.github.com/repos/honi/grunt-ftpscript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/honi/grunt-ftpscript/merges","archive_url":"https://api.github.com/repos/honi/grunt-ftpscript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/honi/grunt-ftpscript/downloads","issues_url":"https://api.github.com/repos/honi/grunt-ftpscript/issues{/number}","pulls_url":"https://api.github.com/repos/honi/grunt-ftpscript/pulls{/number}","milestones_url":"https://api.github.com/repos/honi/grunt-ftpscript/milestones{/number}","notifications_url":"https://api.github.com/repos/honi/grunt-ftpscript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/honi/grunt-ftpscript/labels{/name}","releases_url":"https://api.github.com/repos/honi/grunt-ftpscript/releases{/id}","created_at":"2014-04-22T19:24:05Z","updated_at":"2014-04-25T02:00:46Z","pushed_at":"2014-04-22T19:33:56Z","git_url":"git://github.com/honi/grunt-ftpscript.git","ssh_url":"git@github.com:honi/grunt-ftpscript.git","clone_url":"https://github.com/honi/grunt-ftpscript.git","svn_url":"https://github.com/honi/grunt-ftpscript","homepage":"http://netwjx.github.io/grunt-ftpscript","size":231,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"netwjx:master","ref":"master","sha":"4aeb305577a0958949653f0dbf50953935003dd5","user":{"login":"netwjx","id":197517,"avatar_url":"https://avatars.githubusercontent.com/u/197517?","gravatar_id":"da0eb44f8a8eddd16b521f6571759a1a","url":"https://api.github.com/users/netwjx","html_url":"https://github.com/netwjx","followers_url":"https://api.github.com/users/netwjx/followers","following_url":"https://api.github.com/users/netwjx/following{/other_user}","gists_url":"https://api.github.com/users/netwjx/gists{/gist_id}","starred_url":"https://api.github.com/users/netwjx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netwjx/subscriptions","organizations_url":"https://api.github.com/users/netwjx/orgs","repos_url":"https://api.github.com/users/netwjx/repos","events_url":"https://api.github.com/users/netwjx/events{/privacy}","received_events_url":"https://api.github.com/users/netwjx/received_events","type":"User","site_admin":false},"repo":{"id":11521630,"name":"grunt-ftpscript","full_name":"netwjx/grunt-ftpscript","owner":{"login":"netwjx","id":197517,"avatar_url":"https://avatars.githubusercontent.com/u/197517?","gravatar_id":"da0eb44f8a8eddd16b521f6571759a1a","url":"https://api.github.com/users/netwjx","html_url":"https://github.com/netwjx","followers_url":"https://api.github.com/users/netwjx/followers","following_url":"https://api.github.com/users/netwjx/following{/other_user}","gists_url":"https://api.github.com/users/netwjx/gists{/gist_id}","starred_url":"https://api.github.com/users/netwjx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netwjx/subscriptions","organizations_url":"https://api.github.com/users/netwjx/orgs","repos_url":"https://api.github.com/users/netwjx/repos","events_url":"https://api.github.com/users/netwjx/events{/privacy}","received_events_url":"https://api.github.com/users/netwjx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/netwjx/grunt-ftpscript","description":"Upload files to FTP Server, Active or Passive mode, base ftp command.","fork":false,"url":"https://api.github.com/repos/netwjx/grunt-ftpscript","forks_url":"https://api.github.com/repos/netwjx/grunt-ftpscript/forks","keys_url":"https://api.github.com/repos/netwjx/grunt-ftpscript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/netwjx/grunt-ftpscript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/netwjx/grunt-ftpscript/teams","hooks_url":"https://api.github.com/repos/netwjx/grunt-ftpscript/hooks","issue_events_url":"https://api.github.com/repos/netwjx/grunt-ftpscript/issues/events{/number}","events_url":"https://api.github.com/repos/netwjx/grunt-ftpscript/events","assignees_url":"https://api.github.com/repos/netwjx/grunt-ftpscript/assignees{/user}","branches_url":"https://api.github.com/repos/netwjx/grunt-ftpscript/branches{/branch}","tags_url":"https://api.github.com/repos/netwjx/grunt-ftpscript/tags","blobs_url":"https://api.github.com/repos/netwjx/grunt-ftpscript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/netwjx/grunt-ftpscript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/netwjx/grunt-ftpscript/git/refs{/sha}","trees_url":"https://api.github.com/repos/netwjx/grunt-ftpscript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/netwjx/grunt-ftpscript/statuses/{sha}","languages_url":"https://api.github.com/repos/netwjx/grunt-ftpscript/languages","stargazers_url":"https://api.github.com/repos/netwjx/grunt-ftpscript/stargazers","contributors_url":"https://api.github.com/repos/netwjx/grunt-ftpscript/contributors","subscribers_url":"https://api.github.com/repos/netwjx/grunt-ftpscript/subscribers","subscription_url":"https://api.github.com/repos/netwjx/grunt-ftpscript/subscription","commits_url":"https://api.github.com/repos/netwjx/grunt-ftpscript/commits{/sha}","git_commits_url":"https://api.github.com/repos/netwjx/grunt-ftpscript/git/commits{/sha}","comments_url":"https://api.github.com/repos/netwjx/grunt-ftpscript/comments{/number}","issue_comment_url":"https://api.github.com/repos/netwjx/grunt-ftpscript/issues/comments/{number}","contents_url":"https://api.github.com/repos/netwjx/grunt-ftpscript/contents/{+path}","compare_url":"https://api.github.com/repos/netwjx/grunt-ftpscript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/netwjx/grunt-ftpscript/merges","archive_url":"https://api.github.com/repos/netwjx/grunt-ftpscript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/netwjx/grunt-ftpscript/downloads","issues_url":"https://api.github.com/repos/netwjx/grunt-ftpscript/issues{/number}","pulls_url":"https://api.github.com/repos/netwjx/grunt-ftpscript/pulls{/number}","milestones_url":"https://api.github.com/repos/netwjx/grunt-ftpscript/milestones{/number}","notifications_url":"https://api.github.com/repos/netwjx/grunt-ftpscript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/netwjx/grunt-ftpscript/labels{/name}","releases_url":"https://api.github.com/repos/netwjx/grunt-ftpscript/releases{/id}","created_at":"2013-07-19T06:26:40Z","updated_at":"2014-04-25T02:00:46Z","pushed_at":"2014-04-25T02:00:46Z","git_url":"git://github.com/netwjx/grunt-ftpscript.git","ssh_url":"git@github.com:netwjx/grunt-ftpscript.git","clone_url":"https://github.com/netwjx/grunt-ftpscript.git","svn_url":"https://github.com/netwjx/grunt-ftpscript","homepage":"http://netwjx.github.io/grunt-ftpscript","size":388,"stargazers_count":3,"watchers_count":3,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/netwjx/grunt-ftpscript/pulls/2"},"html":{"href":"https://github.com/netwjx/grunt-ftpscript/pull/2"},"issue":{"href":"https://api.github.com/repos/netwjx/grunt-ftpscript/issues/2"},"comments":{"href":"https://api.github.com/repos/netwjx/grunt-ftpscript/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/netwjx/grunt-ftpscript/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/netwjx/grunt-ftpscript/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/netwjx/grunt-ftpscript/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/netwjx/grunt-ftpscript/statuses/2e58697f293e07c4c1a6b7257c062f25fb518707"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"netwjx","id":197517,"avatar_url":"https://avatars.githubusercontent.com/u/197517?","gravatar_id":"da0eb44f8a8eddd16b521f6571759a1a","url":"https://api.github.com/users/netwjx","html_url":"https://github.com/netwjx","followers_url":"https://api.github.com/users/netwjx/followers","following_url":"https://api.github.com/users/netwjx/following{/other_user}","gists_url":"https://api.github.com/users/netwjx/gists{/gist_id}","starred_url":"https://api.github.com/users/netwjx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netwjx/subscriptions","organizations_url":"https://api.github.com/users/netwjx/orgs","repos_url":"https://api.github.com/users/netwjx/repos","events_url":"https://api.github.com/users/netwjx/events{/privacy}","received_events_url":"https://api.github.com/users/netwjx/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":22,"deletions":4,"changed_files":2}}