GitHub PullRequestReviewCommentEvent at 2014-12-18 15:44:55
Repository: angularjs-portal
Actor: apetro
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/pulls/comments/22049230","id":22049230,"diff_hunk":"@@ -1,10 +1,19 @@\n-<nav id=\"portlet_u1311l1n19\" class=\"side-bar-menu\">\n+<div>\n+<nav id=\"portlet_u1311l1n19\" class=\"side-bar-nav\">\n+  <span class=\"fa fa-remove hide-sidebar\" ng-click=\"$parent.showSidebar = false\"></span>\n   <ul class=\"list-group sidebar\">\n     <li class=\"list-group-item\"><a href=\"#/\" ng-click=\"navbarCollapsed = true\"><span class=\"fa fa-home fa-fw\"></span> Home</a></li>\n-    <li class=\"list-group-item\"><a href='#/apps' ng-click=\"navbarCollapsed = true\"><span class=\"fa fa-cog fa-fw\"></span> Apps</a></li>\n+    <li class=\"list-group-item\"><a href='#/apps' ng-click=\"navbarCollapsed = true\"><span class=\"fa fa-star fa-fw\"></span> Apps</a></li>\n     <!-- <li class=\"list-group-item\"><a href='#' ng-click=\"navbarCollapsed = true\"><span class=\"fa fa-user fa-fw\"></span> My Profile</a></li>\n     <li class=\"list-group-item\"><a href='#' ng-click=\"navbarCollapsed = true\"><span class=\"fa fa-eye fa-fw\"></span> Settings</a></li>-->\n     <li class=\"list-group-item\"><a href='/portal/p/myuw-help' ng-click=\"navbarCollapsed = true\"><span class=\"fa fa-question fa-fw\"></span> Help</a></li> \n     <li class=\"list-group-item\"><a href=\"/portal/Logout\" ng-click=\"navbarCollapsed = true\"><span class=\"fa fa-sign-out fa-fw\"></span> Log out</a></li>\n+    <div class=\"quicklinks\">\n+      <p class=\"section-divider\">Quicklinks</p>\n+      <li class=\"list-group-item\"><a href=\"https://finaid.wisc.edu/student-center.htm\" ng-click=\"navbarCollapsed = true\">Student Center</a></li>\n+      <li class=\"list-group-item\"><a href=\"https://learnuw.wisc.edu/\" ng-click=\"navbarCollapsed = true\">Learn@UW</a></li>\n+      <li class=\"list-group-item\"><a href=\"https://uwmadison.app.box.com/login\" ng-click=\"navbarCollapsed = true\">Box</a></li>\n+    </div>","path":"src/main/webapp/partials/sidebar-left.html","position":18,"original_position":18,"commit_id":"069f0336edf7a425736c63eaab0635cab3b5c4e2","original_commit_id":"e75bccc0e5c954279055fdea7c71062dae43c969","user":{"login":"apetro","id":952283,"avatar_url":"https://avatars.githubusercontent.com/u/952283?v=3","gravatar_id":"","url":"https://api.github.com/users/apetro","html_url":"https://github.com/apetro","followers_url":"https://api.github.com/users/apetro/followers","following_url":"https://api.github.com/users/apetro/following{/other_user}","gists_url":"https://api.github.com/users/apetro/gists{/gist_id}","starred_url":"https://api.github.com/users/apetro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apetro/subscriptions","organizations_url":"https://api.github.com/users/apetro/orgs","repos_url":"https://api.github.com/users/apetro/repos","events_url":"https://api.github.com/users/apetro/events{/privacy}","received_events_url":"https://api.github.com/users/apetro/received_events","type":"User","site_admin":false},"body":"Agree this needs to be dynamic.  Not all users need to bother with Student Center quick link, e.g.\r\n\r\nHow troubling would it be if we moved that dynamism client-side though?  As in, instead of grabbing a named tab, embrace having Quicklinks as a client-side concept, having some kind of JSON modeling quicklinks to potentially include and what groups(?) should trigger their inclusion, and doing this filtering / quicklinks generation client-side?  A step towards doing even more interesting things client side?\r\n\r\nDisplaying the right links to the user, arguably, can be a client-side view-layer consideration rather than something the server needs to be so worried about.\r\n\r\nIn the short term it might mean modeling this redundantly in two places ( :( ) to get to the same experience in `/portal` , but it'd also be a way to stat playing with what can we do with knowledge about user groups client-side.","created_at":"2014-12-18T15:44:55Z","updated_at":"2014-12-18T15:44:55Z","html_url":"https://github.com/UW-Madison-DoIT/angularjs-portal/pull/70#discussion_r22049230","pull_request_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/pulls/70","_links":{"self":{"href":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/pulls/comments/22049230"},"html":{"href":"https://github.com/UW-Madison-DoIT/angularjs-portal/pull/70#discussion_r22049230"},"pull_request":{"href":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/pulls/70"}}},"pull_request":{"url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/pulls/70","id":26269026,"html_url":"https://github.com/UW-Madison-DoIT/angularjs-portal/pull/70","diff_url":"https://github.com/UW-Madison-DoIT/angularjs-portal/pull/70.diff","patch_url":"https://github.com/UW-Madison-DoIT/angularjs-portal/pull/70.patch","issue_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/issues/70","number":70,"state":"open","locked":false,"title":"MUMUP-1402: Collapsible Sidebar","user":{"login":"jhanstra","id":1919535,"avatar_url":"https://avatars.githubusercontent.com/u/1919535?v=3","gravatar_id":"","url":"https://api.github.com/users/jhanstra","html_url":"https://github.com/jhanstra","followers_url":"https://api.github.com/users/jhanstra/followers","following_url":"https://api.github.com/users/jhanstra/following{/other_user}","gists_url":"https://api.github.com/users/jhanstra/gists{/gist_id}","starred_url":"https://api.github.com/users/jhanstra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhanstra/subscriptions","organizations_url":"https://api.github.com/users/jhanstra/orgs","repos_url":"https://api.github.com/users/jhanstra/repos","events_url":"https://api.github.com/users/jhanstra/events{/privacy}","received_events_url":"https://api.github.com/users/jhanstra/received_events","type":"User","site_admin":false},"body":"Youtube-esque collapsible sidebar. The sidebar is shown by default, since it I don't think it would be smart to relegate the navigation for the site to a small menu icon by default. \r\n\r\nStill need to add the ability to remember whether sidebar is open or closed per user. I believe that's on the uPortal side though?\r\n\r\n### Notable tweaks:\r\n- Mobile menu now has this black and white image of campus instead of the crest\r\n- Quick links added to the sidebar as a concept for how this could look. I am personally a huge fan of this approach, but I know Phyllis had reservations about it.\r\n- Marketplace icon is a star. Cog icon didn't really make sense to me.\r\n- When sidebar is minimized, the width of the main content is col-sm-11, rather than col-sm-10. Hurray for more real estate!\r\n\r\nI took some liberties with the style, let me know if you have any thoughts/concerns/suggestions for them.\r\n\r\n### Screenshots:\r\n![image](https://cloud.githubusercontent.com/assets/1919535/5480671/03ac913a-860e-11e4-92f6-13a6fb0ac515.png)\r\n\r\n![image](https://cloud.githubusercontent.com/assets/1919535/5480683/1c93eafe-860e-11e4-8f2d-69a83bcdab8b.png)\r\n\r\n![image](https://cloud.githubusercontent.com/assets/1919535/5480687/2cb2b1cc-860e-11e4-876b-b592e03189fe.png)\r\n\r\n![image](https://cloud.githubusercontent.com/assets/1919535/5481366/c90f2e40-8615-11e4-9a44-7b5ac6f96e54.png)\r\n\r\n","created_at":"2014-12-18T00:29:21Z","updated_at":"2014-12-18T15:44:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0bea4c5b362e52eb464aa06240bbae4d8abc3513","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/pulls/70/commits","review_comments_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/pulls/70/comments","review_comment_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/pulls/comments/{number}","comments_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/issues/70/comments","statuses_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/statuses/069f0336edf7a425736c63eaab0635cab3b5c4e2","head":{"label":"UW-Madison-DoIT:collapse","ref":"collapse","sha":"069f0336edf7a425736c63eaab0635cab3b5c4e2","user":{"login":"UW-Madison-DoIT","id":1629635,"avatar_url":"https://avatars.githubusercontent.com/u/1629635?v=3","gravatar_id":"","url":"https://api.github.com/users/UW-Madison-DoIT","html_url":"https://github.com/UW-Madison-DoIT","followers_url":"https://api.github.com/users/UW-Madison-DoIT/followers","following_url":"https://api.github.com/users/UW-Madison-DoIT/following{/other_user}","gists_url":"https://api.github.com/users/UW-Madison-DoIT/gists{/gist_id}","starred_url":"https://api.github.com/users/UW-Madison-DoIT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UW-Madison-DoIT/subscriptions","organizations_url":"https://api.github.com/users/UW-Madison-DoIT/orgs","repos_url":"https://api.github.com/users/UW-Madison-DoIT/repos","events_url":"https://api.github.com/users/UW-Madison-DoIT/events{/privacy}","received_events_url":"https://api.github.com/users/UW-Madison-DoIT/received_events","type":"Organization","site_admin":false},"repo":{"id":24428594,"name":"angularjs-portal","full_name":"UW-Madison-DoIT/angularjs-portal","owner":{"login":"UW-Madison-DoIT","id":1629635,"avatar_url":"https://avatars.githubusercontent.com/u/1629635?v=3","gravatar_id":"","url":"https://api.github.com/users/UW-Madison-DoIT","html_url":"https://github.com/UW-Madison-DoIT","followers_url":"https://api.github.com/users/UW-Madison-DoIT/followers","following_url":"https://api.github.com/users/UW-Madison-DoIT/following{/other_user}","gists_url":"https://api.github.com/users/UW-Madison-DoIT/gists{/gist_id}","starred_url":"https://api.github.com/users/UW-Madison-DoIT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UW-Madison-DoIT/subscriptions","organizations_url":"https://api.github.com/users/UW-Madison-DoIT/orgs","repos_url":"https://api.github.com/users/UW-Madison-DoIT/repos","events_url":"https://api.github.com/users/UW-Madison-DoIT/events{/privacy}","received_events_url":"https://api.github.com/users/UW-Madison-DoIT/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UW-Madison-DoIT/angularjs-portal","description":"AngularJS alternative UI for MyUW portal (built for uPortal).","fork":false,"url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal","forks_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/forks","keys_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/teams","hooks_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/hooks","issue_events_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/issues/events{/number}","events_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/events","assignees_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/assignees{/user}","branches_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/branches{/branch}","tags_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/tags","blobs_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/languages","stargazers_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/stargazers","contributors_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/contributors","subscribers_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/subscribers","subscription_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/subscription","commits_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/issues/comments/{number}","contents_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/contents/{+path}","compare_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/merges","archive_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/downloads","issues_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/issues{/number}","pulls_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/labels{/name}","releases_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/releases{/id}","created_at":"2014-09-24T19:04:44Z","updated_at":"2014-12-17T15:08:08Z","pushed_at":"2014-12-18T14:54:33Z","git_url":"git://github.com/UW-Madison-DoIT/angularjs-portal.git","ssh_url":"git@github.com:UW-Madison-DoIT/angularjs-portal.git","clone_url":"https://github.com/UW-Madison-DoIT/angularjs-portal.git","svn_url":"https://github.com/UW-Madison-DoIT/angularjs-portal","homepage":"","size":5107,"stargazers_count":2,"watchers_count":2,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":1,"forks":5,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"UW-Madison-DoIT:master","ref":"master","sha":"661a21b3c4e710c6ff34faca7e498a3e1de9c9bd","user":{"login":"UW-Madison-DoIT","id":1629635,"avatar_url":"https://avatars.githubusercontent.com/u/1629635?v=3","gravatar_id":"","url":"https://api.github.com/users/UW-Madison-DoIT","html_url":"https://github.com/UW-Madison-DoIT","followers_url":"https://api.github.com/users/UW-Madison-DoIT/followers","following_url":"https://api.github.com/users/UW-Madison-DoIT/following{/other_user}","gists_url":"https://api.github.com/users/UW-Madison-DoIT/gists{/gist_id}","starred_url":"https://api.github.com/users/UW-Madison-DoIT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UW-Madison-DoIT/subscriptions","organizations_url":"https://api.github.com/users/UW-Madison-DoIT/orgs","repos_url":"https://api.github.com/users/UW-Madison-DoIT/repos","events_url":"https://api.github.com/users/UW-Madison-DoIT/events{/privacy}","received_events_url":"https://api.github.com/users/UW-Madison-DoIT/received_events","type":"Organization","site_admin":false},"repo":{"id":24428594,"name":"angularjs-portal","full_name":"UW-Madison-DoIT/angularjs-portal","owner":{"login":"UW-Madison-DoIT","id":1629635,"avatar_url":"https://avatars.githubusercontent.com/u/1629635?v=3","gravatar_id":"","url":"https://api.github.com/users/UW-Madison-DoIT","html_url":"https://github.com/UW-Madison-DoIT","followers_url":"https://api.github.com/users/UW-Madison-DoIT/followers","following_url":"https://api.github.com/users/UW-Madison-DoIT/following{/other_user}","gists_url":"https://api.github.com/users/UW-Madison-DoIT/gists{/gist_id}","starred_url":"https://api.github.com/users/UW-Madison-DoIT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UW-Madison-DoIT/subscriptions","organizations_url":"https://api.github.com/users/UW-Madison-DoIT/orgs","repos_url":"https://api.github.com/users/UW-Madison-DoIT/repos","events_url":"https://api.github.com/users/UW-Madison-DoIT/events{/privacy}","received_events_url":"https://api.github.com/users/UW-Madison-DoIT/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UW-Madison-DoIT/angularjs-portal","description":"AngularJS alternative UI for MyUW portal (built for uPortal).","fork":false,"url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal","forks_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/forks","keys_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/teams","hooks_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/hooks","issue_events_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/issues/events{/number}","events_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/events","assignees_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/assignees{/user}","branches_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/branches{/branch}","tags_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/tags","blobs_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/languages","stargazers_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/stargazers","contributors_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/contributors","subscribers_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/subscribers","subscription_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/subscription","commits_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/issues/comments/{number}","contents_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/contents/{+path}","compare_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/merges","archive_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/downloads","issues_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/issues{/number}","pulls_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/labels{/name}","releases_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/releases{/id}","created_at":"2014-09-24T19:04:44Z","updated_at":"2014-12-17T15:08:08Z","pushed_at":"2014-12-18T14:54:33Z","git_url":"git://github.com/UW-Madison-DoIT/angularjs-portal.git","ssh_url":"git@github.com:UW-Madison-DoIT/angularjs-portal.git","clone_url":"https://github.com/UW-Madison-DoIT/angularjs-portal.git","svn_url":"https://github.com/UW-Madison-DoIT/angularjs-portal","homepage":"","size":5107,"stargazers_count":2,"watchers_count":2,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":1,"forks":5,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/pulls/70"},"html":{"href":"https://github.com/UW-Madison-DoIT/angularjs-portal/pull/70"},"issue":{"href":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/issues/70"},"comments":{"href":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/issues/70/comments"},"review_comments":{"href":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/pulls/70/comments"},"review_comment":{"href":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/pulls/70/commits"},"statuses":{"href":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/statuses/069f0336edf7a425736c63eaab0635cab3b5c4e2"}}}}