GitHub PullRequestReviewCommentEvent at 2014-10-13 22:21:56
Repository: nibabel
Actor: matthew-brett
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/nipy/nibabel/pulls/comments/18798817","id":18798817,"diff_hunk":"@@ -139,16 +144,17 @@ def test_log_checks(self):\n         # datatype not recognized\n         hdr = HC()\n         hdr['datatype'] = -1 # severity 40\n-        fhdr, message, raiser = self.log_chk(hdr, 40)\n+        with warnings.catch_warnings(record=True):\n+            fhdr, message, raiser = self.log_chk(hdr, 40)\n         assert_equal(message, 'data code -1 not recognized; '\n                            'not attempting fix')\n         assert_raises(*raiser)\n         # datatype not supported\n         hdr['datatype'] = 255 # severity 40\n         fhdr, message, raiser = self.log_chk(hdr, 40)\n-        assert_equal(message, 'data code 255 not supported; '\n-                           'not attempting fix')\n-        assert_raises(*raiser)\n+        #assert_equal(message, 'data code 255 not supported; '","path":"nibabel/tests/test_analyze.py","position":66,"original_position":66,"commit_id":"80683ea491f3f1eb3da564b186959c3c9f924ec0","original_commit_id":"80683ea491f3f1eb3da564b186959c3c9f924ec0","user":{"login":"matthew-brett","id":67612,"avatar_url":"https://avatars.githubusercontent.com/u/67612?v=2","gravatar_id":"","url":"https://api.github.com/users/matthew-brett","html_url":"https://github.com/matthew-brett","followers_url":"https://api.github.com/users/matthew-brett/followers","following_url":"https://api.github.com/users/matthew-brett/following{/other_user}","gists_url":"https://api.github.com/users/matthew-brett/gists{/gist_id}","starred_url":"https://api.github.com/users/matthew-brett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthew-brett/subscriptions","organizations_url":"https://api.github.com/users/matthew-brett/orgs","repos_url":"https://api.github.com/users/matthew-brett/repos","events_url":"https://api.github.com/users/matthew-brett/events{/privacy}","received_events_url":"https://api.github.com/users/matthew-brett/received_events","type":"User","site_admin":false},"body":"Please do if you have time - it would be sad to lose the tests.","created_at":"2014-10-13T22:21:56Z","updated_at":"2014-10-13T22:21:56Z","html_url":"https://github.com/nipy/nibabel/pull/254#discussion_r18798817","pull_request_url":"https://api.github.com/repos/nipy/nibabel/pulls/254","_links":{"self":{"href":"https://api.github.com/repos/nipy/nibabel/pulls/comments/18798817"},"html":{"href":"https://github.com/nipy/nibabel/pull/254#discussion_r18798817"},"pull_request":{"href":"https://api.github.com/repos/nipy/nibabel/pulls/254"}}},"pull_request":{"url":"https://api.github.com/repos/nipy/nibabel/pulls/254","id":20408268,"html_url":"https://github.com/nipy/nibabel/pull/254","diff_url":"https://github.com/nipy/nibabel/pull/254.diff","patch_url":"https://github.com/nipy/nibabel/pull/254.patch","issue_url":"https://api.github.com/repos/nipy/nibabel/issues/254","number":254,"state":"open","locked":false,"title":"MRG: Cleaner tests","user":{"login":"Eric89GXL","id":2365790,"avatar_url":"https://avatars.githubusercontent.com/u/2365790?v=2","gravatar_id":"","url":"https://api.github.com/users/Eric89GXL","html_url":"https://github.com/Eric89GXL","followers_url":"https://api.github.com/users/Eric89GXL/followers","following_url":"https://api.github.com/users/Eric89GXL/following{/other_user}","gists_url":"https://api.github.com/users/Eric89GXL/gists{/gist_id}","starred_url":"https://api.github.com/users/Eric89GXL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eric89GXL/subscriptions","organizations_url":"https://api.github.com/users/Eric89GXL/orgs","repos_url":"https://api.github.com/users/Eric89GXL/repos","events_url":"https://api.github.com/users/Eric89GXL/events{/privacy}","received_events_url":"https://api.github.com/users/Eric89GXL/received_events","type":"User","site_admin":false},"body":"In the process of working on #253 I was a little bit surprised by the number of warnings during testing. This cleans that up, and fixes a couple minor errors along the way.\r\n\r\nReady for review/merge.","created_at":"2014-08-27T23:03:11Z","updated_at":"2014-10-13T22:21:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9277df5a32aa16c293dcf80378e80900659f980b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nipy/nibabel/pulls/254/commits","review_comments_url":"https://api.github.com/repos/nipy/nibabel/pulls/254/comments","review_comment_url":"https://api.github.com/repos/nipy/nibabel/pulls/comments/{number}","comments_url":"https://api.github.com/repos/nipy/nibabel/issues/254/comments","statuses_url":"https://api.github.com/repos/nipy/nibabel/statuses/80683ea491f3f1eb3da564b186959c3c9f924ec0","head":{"label":"Eric89GXL:clean-tests","ref":"clean-tests","sha":"80683ea491f3f1eb3da564b186959c3c9f924ec0","user":{"login":"Eric89GXL","id":2365790,"avatar_url":"https://avatars.githubusercontent.com/u/2365790?v=2","gravatar_id":"","url":"https://api.github.com/users/Eric89GXL","html_url":"https://github.com/Eric89GXL","followers_url":"https://api.github.com/users/Eric89GXL/followers","following_url":"https://api.github.com/users/Eric89GXL/following{/other_user}","gists_url":"https://api.github.com/users/Eric89GXL/gists{/gist_id}","starred_url":"https://api.github.com/users/Eric89GXL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eric89GXL/subscriptions","organizations_url":"https://api.github.com/users/Eric89GXL/orgs","repos_url":"https://api.github.com/users/Eric89GXL/repos","events_url":"https://api.github.com/users/Eric89GXL/events{/privacy}","received_events_url":"https://api.github.com/users/Eric89GXL/received_events","type":"User","site_admin":false},"repo":{"id":8961566,"name":"nibabel","full_name":"Eric89GXL/nibabel","owner":{"login":"Eric89GXL","id":2365790,"avatar_url":"https://avatars.githubusercontent.com/u/2365790?v=2","gravatar_id":"","url":"https://api.github.com/users/Eric89GXL","html_url":"https://github.com/Eric89GXL","followers_url":"https://api.github.com/users/Eric89GXL/followers","following_url":"https://api.github.com/users/Eric89GXL/following{/other_user}","gists_url":"https://api.github.com/users/Eric89GXL/gists{/gist_id}","starred_url":"https://api.github.com/users/Eric89GXL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eric89GXL/subscriptions","organizations_url":"https://api.github.com/users/Eric89GXL/orgs","repos_url":"https://api.github.com/users/Eric89GXL/repos","events_url":"https://api.github.com/users/Eric89GXL/events{/privacy}","received_events_url":"https://api.github.com/users/Eric89GXL/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Eric89GXL/nibabel","description":"Python package to access a cacophony of neuro-imaging file formats","fork":true,"url":"https://api.github.com/repos/Eric89GXL/nibabel","forks_url":"https://api.github.com/repos/Eric89GXL/nibabel/forks","keys_url":"https://api.github.com/repos/Eric89GXL/nibabel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Eric89GXL/nibabel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Eric89GXL/nibabel/teams","hooks_url":"https://api.github.com/repos/Eric89GXL/nibabel/hooks","issue_events_url":"https://api.github.com/repos/Eric89GXL/nibabel/issues/events{/number}","events_url":"https://api.github.com/repos/Eric89GXL/nibabel/events","assignees_url":"https://api.github.com/repos/Eric89GXL/nibabel/assignees{/user}","branches_url":"https://api.github.com/repos/Eric89GXL/nibabel/branches{/branch}","tags_url":"https://api.github.com/repos/Eric89GXL/nibabel/tags","blobs_url":"https://api.github.com/repos/Eric89GXL/nibabel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Eric89GXL/nibabel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Eric89GXL/nibabel/git/refs{/sha}","trees_url":"https://api.github.com/repos/Eric89GXL/nibabel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Eric89GXL/nibabel/statuses/{sha}","languages_url":"https://api.github.com/repos/Eric89GXL/nibabel/languages","stargazers_url":"https://api.github.com/repos/Eric89GXL/nibabel/stargazers","contributors_url":"https://api.github.com/repos/Eric89GXL/nibabel/contributors","subscribers_url":"https://api.github.com/repos/Eric89GXL/nibabel/subscribers","subscription_url":"https://api.github.com/repos/Eric89GXL/nibabel/subscription","commits_url":"https://api.github.com/repos/Eric89GXL/nibabel/commits{/sha}","git_commits_url":"https://api.github.com/repos/Eric89GXL/nibabel/git/commits{/sha}","comments_url":"https://api.github.com/repos/Eric89GXL/nibabel/comments{/number}","issue_comment_url":"https://api.github.com/repos/Eric89GXL/nibabel/issues/comments/{number}","contents_url":"https://api.github.com/repos/Eric89GXL/nibabel/contents/{+path}","compare_url":"https://api.github.com/repos/Eric89GXL/nibabel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Eric89GXL/nibabel/merges","archive_url":"https://api.github.com/repos/Eric89GXL/nibabel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Eric89GXL/nibabel/downloads","issues_url":"https://api.github.com/repos/Eric89GXL/nibabel/issues{/number}","pulls_url":"https://api.github.com/repos/Eric89GXL/nibabel/pulls{/number}","milestones_url":"https://api.github.com/repos/Eric89GXL/nibabel/milestones{/number}","notifications_url":"https://api.github.com/repos/Eric89GXL/nibabel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Eric89GXL/nibabel/labels{/name}","releases_url":"https://api.github.com/repos/Eric89GXL/nibabel/releases{/id}","created_at":"2013-03-22T21:44:58Z","updated_at":"2014-08-27T23:02:20Z","pushed_at":"2014-10-13T22:17:43Z","git_url":"git://github.com/Eric89GXL/nibabel.git","ssh_url":"git@github.com:Eric89GXL/nibabel.git","clone_url":"https://github.com/Eric89GXL/nibabel.git","svn_url":"https://github.com/Eric89GXL/nibabel","homepage":"http://nipy.org/nibabel/","size":7360,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nipy:master","ref":"master","sha":"66b8d385d920ebf82742585d4cd22abde0dd8b96","user":{"login":"nipy","id":233707,"avatar_url":"https://avatars.githubusercontent.com/u/233707?v=2","gravatar_id":"","url":"https://api.github.com/users/nipy","html_url":"https://github.com/nipy","followers_url":"https://api.github.com/users/nipy/followers","following_url":"https://api.github.com/users/nipy/following{/other_user}","gists_url":"https://api.github.com/users/nipy/gists{/gist_id}","starred_url":"https://api.github.com/users/nipy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nipy/subscriptions","organizations_url":"https://api.github.com/users/nipy/orgs","repos_url":"https://api.github.com/users/nipy/repos","events_url":"https://api.github.com/users/nipy/events{/privacy}","received_events_url":"https://api.github.com/users/nipy/received_events","type":"Organization","site_admin":false},"repo":{"id":791352,"name":"nibabel","full_name":"nipy/nibabel","owner":{"login":"nipy","id":233707,"avatar_url":"https://avatars.githubusercontent.com/u/233707?v=2","gravatar_id":"","url":"https://api.github.com/users/nipy","html_url":"https://github.com/nipy","followers_url":"https://api.github.com/users/nipy/followers","following_url":"https://api.github.com/users/nipy/following{/other_user}","gists_url":"https://api.github.com/users/nipy/gists{/gist_id}","starred_url":"https://api.github.com/users/nipy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nipy/subscriptions","organizations_url":"https://api.github.com/users/nipy/orgs","repos_url":"https://api.github.com/users/nipy/repos","events_url":"https://api.github.com/users/nipy/events{/privacy}","received_events_url":"https://api.github.com/users/nipy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nipy/nibabel","description":"Python package to access a cacophony of neuro-imaging file formats","fork":false,"url":"https://api.github.com/repos/nipy/nibabel","forks_url":"https://api.github.com/repos/nipy/nibabel/forks","keys_url":"https://api.github.com/repos/nipy/nibabel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nipy/nibabel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nipy/nibabel/teams","hooks_url":"https://api.github.com/repos/nipy/nibabel/hooks","issue_events_url":"https://api.github.com/repos/nipy/nibabel/issues/events{/number}","events_url":"https://api.github.com/repos/nipy/nibabel/events","assignees_url":"https://api.github.com/repos/nipy/nibabel/assignees{/user}","branches_url":"https://api.github.com/repos/nipy/nibabel/branches{/branch}","tags_url":"https://api.github.com/repos/nipy/nibabel/tags","blobs_url":"https://api.github.com/repos/nipy/nibabel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nipy/nibabel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nipy/nibabel/git/refs{/sha}","trees_url":"https://api.github.com/repos/nipy/nibabel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nipy/nibabel/statuses/{sha}","languages_url":"https://api.github.com/repos/nipy/nibabel/languages","stargazers_url":"https://api.github.com/repos/nipy/nibabel/stargazers","contributors_url":"https://api.github.com/repos/nipy/nibabel/contributors","subscribers_url":"https://api.github.com/repos/nipy/nibabel/subscribers","subscription_url":"https://api.github.com/repos/nipy/nibabel/subscription","commits_url":"https://api.github.com/repos/nipy/nibabel/commits{/sha}","git_commits_url":"https://api.github.com/repos/nipy/nibabel/git/commits{/sha}","comments_url":"https://api.github.com/repos/nipy/nibabel/comments{/number}","issue_comment_url":"https://api.github.com/repos/nipy/nibabel/issues/comments/{number}","contents_url":"https://api.github.com/repos/nipy/nibabel/contents/{+path}","compare_url":"https://api.github.com/repos/nipy/nibabel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nipy/nibabel/merges","archive_url":"https://api.github.com/repos/nipy/nibabel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nipy/nibabel/downloads","issues_url":"https://api.github.com/repos/nipy/nibabel/issues{/number}","pulls_url":"https://api.github.com/repos/nipy/nibabel/pulls{/number}","milestones_url":"https://api.github.com/repos/nipy/nibabel/milestones{/number}","notifications_url":"https://api.github.com/repos/nipy/nibabel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nipy/nibabel/labels{/name}","releases_url":"https://api.github.com/repos/nipy/nibabel/releases{/id}","created_at":"2010-07-22T16:28:30Z","updated_at":"2014-10-08T01:35:55Z","pushed_at":"2014-10-13T20:05:51Z","git_url":"git://github.com/nipy/nibabel.git","ssh_url":"git@github.com:nipy/nibabel.git","clone_url":"https://github.com/nipy/nibabel.git","svn_url":"https://github.com/nipy/nibabel","homepage":"http://nipy.org/nibabel/","size":15726,"stargazers_count":73,"watchers_count":73,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":70,"mirror_url":null,"open_issues_count":40,"forks":70,"open_issues":40,"watchers":73,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nipy/nibabel/pulls/254"},"html":{"href":"https://github.com/nipy/nibabel/pull/254"},"issue":{"href":"https://api.github.com/repos/nipy/nibabel/issues/254"},"comments":{"href":"https://api.github.com/repos/nipy/nibabel/issues/254/comments"},"review_comments":{"href":"https://api.github.com/repos/nipy/nibabel/pulls/254/comments"},"review_comment":{"href":"https://api.github.com/repos/nipy/nibabel/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/nipy/nibabel/pulls/254/commits"},"statuses":{"href":"https://api.github.com/repos/nipy/nibabel/statuses/80683ea491f3f1eb3da564b186959c3c9f924ec0"}}}}