GitHub PullRequestReviewCommentEvent at 2014-12-08 14:00:45
Repository: sphere-sunrise
Actor: lauraluiz
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/sphereio/sphere-sunrise/pulls/comments/21453479","id":21453479,"diff_hunk":"@@ -26,7 +26,7 @@ public ProductionModule(Application app) {\n     @Override\n     protected void configure() {\n         final PlayJavaClient client = new PlayJavaClientImpl(app.configuration());\n-        final PagedQueryResult<Category> queryResult = client.execute(new CategoryQuery()).get(2000, TimeUnit.MILLISECONDS);//TODO this will be most likely moved to a plugin\n+        final PagedQueryResult<Category> queryResult = client.execute(CategoryQuery.of()).get(2000, TimeUnit.MILLISECONDS);//TODO this will be most likely moved to a plugin","path":"app/plugins/ProductionModule.java","position":5,"original_position":5,"commit_id":"fcd4ee43513f28521892c97fe7d1d3552b4a3d8a","original_commit_id":"fcd4ee43513f28521892c97fe7d1d3552b4a3d8a","user":{"login":"lauraluiz","id":1917621,"avatar_url":"https://avatars.githubusercontent.com/u/1917621?v=3","gravatar_id":"","url":"https://api.github.com/users/lauraluiz","html_url":"https://github.com/lauraluiz","followers_url":"https://api.github.com/users/lauraluiz/followers","following_url":"https://api.github.com/users/lauraluiz/following{/other_user}","gists_url":"https://api.github.com/users/lauraluiz/gists{/gist_id}","starred_url":"https://api.github.com/users/lauraluiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lauraluiz/subscriptions","organizations_url":"https://api.github.com/users/lauraluiz/orgs","repos_url":"https://api.github.com/users/lauraluiz/repos","events_url":"https://api.github.com/users/lauraluiz/events{/privacy}","received_events_url":"https://api.github.com/users/lauraluiz/received_events","type":"User","site_admin":false},"body":"I agree with @schleichardt , using another constructor name would confuse developers. So far, once you understand that in the SDK you should always use static constructors, you can work mechanically without thinking what the name would be this time. I think `of()` is a good pattern to use always.\r\n\r\n`getInstance()` sounds too dangerously like singletons, and `empty()` may sound good for certain cases, but then we have the problem I mentioned before.","created_at":"2014-12-08T14:00:45Z","updated_at":"2014-12-08T14:00:45Z","html_url":"https://github.com/sphereio/sphere-sunrise/pull/65#discussion_r21453479","pull_request_url":"https://api.github.com/repos/sphereio/sphere-sunrise/pulls/65","_links":{"self":{"href":"https://api.github.com/repos/sphereio/sphere-sunrise/pulls/comments/21453479"},"html":{"href":"https://github.com/sphereio/sphere-sunrise/pull/65#discussion_r21453479"},"pull_request":{"href":"https://api.github.com/repos/sphereio/sphere-sunrise/pulls/65"}}},"pull_request":{"url":"https://api.github.com/repos/sphereio/sphere-sunrise/pulls/65","id":25503535,"html_url":"https://github.com/sphereio/sphere-sunrise/pull/65","diff_url":"https://github.com/sphereio/sphere-sunrise/pull/65.diff","patch_url":"https://github.com/sphereio/sphere-sunrise/pull/65.patch","issue_url":"https://api.github.com/repos/sphereio/sphere-sunrise/issues/65","number":65,"state":"open","locked":false,"title":"Update to SDK 1.0.0-M8.","user":{"login":"schleichardt","id":1320833,"avatar_url":"https://avatars.githubusercontent.com/u/1320833?v=3","gravatar_id":"","url":"https://api.github.com/users/schleichardt","html_url":"https://github.com/schleichardt","followers_url":"https://api.github.com/users/schleichardt/followers","following_url":"https://api.github.com/users/schleichardt/following{/other_user}","gists_url":"https://api.github.com/users/schleichardt/gists{/gist_id}","starred_url":"https://api.github.com/users/schleichardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schleichardt/subscriptions","organizations_url":"https://api.github.com/users/schleichardt/orgs","repos_url":"https://api.github.com/users/schleichardt/repos","events_url":"https://api.github.com/users/schleichardt/events{/privacy}","received_events_url":"https://api.github.com/users/schleichardt/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-12-04T15:27:15Z","updated_at":"2014-12-08T14:00:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c7074ab3c40d2718c0d1c66231d9b90a7a0cfe74","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sphereio/sphere-sunrise/pulls/65/commits","review_comments_url":"https://api.github.com/repos/sphereio/sphere-sunrise/pulls/65/comments","review_comment_url":"https://api.github.com/repos/sphereio/sphere-sunrise/pulls/comments/{number}","comments_url":"https://api.github.com/repos/sphereio/sphere-sunrise/issues/65/comments","statuses_url":"https://api.github.com/repos/sphereio/sphere-sunrise/statuses/fcd4ee43513f28521892c97fe7d1d3552b4a3d8a","head":{"label":"sphereio:sdk-1.0.0-M8","ref":"sdk-1.0.0-M8","sha":"fcd4ee43513f28521892c97fe7d1d3552b4a3d8a","user":{"login":"sphereio","id":4119130,"avatar_url":"https://avatars.githubusercontent.com/u/4119130?v=3","gravatar_id":"","url":"https://api.github.com/users/sphereio","html_url":"https://github.com/sphereio","followers_url":"https://api.github.com/users/sphereio/followers","following_url":"https://api.github.com/users/sphereio/following{/other_user}","gists_url":"https://api.github.com/users/sphereio/gists{/gist_id}","starred_url":"https://api.github.com/users/sphereio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sphereio/subscriptions","organizations_url":"https://api.github.com/users/sphereio/orgs","repos_url":"https://api.github.com/users/sphereio/repos","events_url":"https://api.github.com/users/sphereio/events{/privacy}","received_events_url":"https://api.github.com/users/sphereio/received_events","type":"Organization","site_admin":false},"repo":{"id":20036001,"name":"sphere-sunrise","full_name":"sphereio/sphere-sunrise","owner":{"login":"sphereio","id":4119130,"avatar_url":"https://avatars.githubusercontent.com/u/4119130?v=3","gravatar_id":"","url":"https://api.github.com/users/sphereio","html_url":"https://github.com/sphereio","followers_url":"https://api.github.com/users/sphereio/followers","following_url":"https://api.github.com/users/sphereio/following{/other_user}","gists_url":"https://api.github.com/users/sphereio/gists{/gist_id}","starred_url":"https://api.github.com/users/sphereio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sphereio/subscriptions","organizations_url":"https://api.github.com/users/sphereio/orgs","repos_url":"https://api.github.com/users/sphereio/repos","events_url":"https://api.github.com/users/sphereio/events{/privacy}","received_events_url":"https://api.github.com/users/sphereio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sphereio/sphere-sunrise","description":"The next generation SPHERE.IO demo shop template","fork":false,"url":"https://api.github.com/repos/sphereio/sphere-sunrise","forks_url":"https://api.github.com/repos/sphereio/sphere-sunrise/forks","keys_url":"https://api.github.com/repos/sphereio/sphere-sunrise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sphereio/sphere-sunrise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sphereio/sphere-sunrise/teams","hooks_url":"https://api.github.com/repos/sphereio/sphere-sunrise/hooks","issue_events_url":"https://api.github.com/repos/sphereio/sphere-sunrise/issues/events{/number}","events_url":"https://api.github.com/repos/sphereio/sphere-sunrise/events","assignees_url":"https://api.github.com/repos/sphereio/sphere-sunrise/assignees{/user}","branches_url":"https://api.github.com/repos/sphereio/sphere-sunrise/branches{/branch}","tags_url":"https://api.github.com/repos/sphereio/sphere-sunrise/tags","blobs_url":"https://api.github.com/repos/sphereio/sphere-sunrise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sphereio/sphere-sunrise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sphereio/sphere-sunrise/git/refs{/sha}","trees_url":"https://api.github.com/repos/sphereio/sphere-sunrise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sphereio/sphere-sunrise/statuses/{sha}","languages_url":"https://api.github.com/repos/sphereio/sphere-sunrise/languages","stargazers_url":"https://api.github.com/repos/sphereio/sphere-sunrise/stargazers","contributors_url":"https://api.github.com/repos/sphereio/sphere-sunrise/contributors","subscribers_url":"https://api.github.com/repos/sphereio/sphere-sunrise/subscribers","subscription_url":"https://api.github.com/repos/sphereio/sphere-sunrise/subscription","commits_url":"https://api.github.com/repos/sphereio/sphere-sunrise/commits{/sha}","git_commits_url":"https://api.github.com/repos/sphereio/sphere-sunrise/git/commits{/sha}","comments_url":"https://api.github.com/repos/sphereio/sphere-sunrise/comments{/number}","issue_comment_url":"https://api.github.com/repos/sphereio/sphere-sunrise/issues/comments/{number}","contents_url":"https://api.github.com/repos/sphereio/sphere-sunrise/contents/{+path}","compare_url":"https://api.github.com/repos/sphereio/sphere-sunrise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sphereio/sphere-sunrise/merges","archive_url":"https://api.github.com/repos/sphereio/sphere-sunrise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sphereio/sphere-sunrise/downloads","issues_url":"https://api.github.com/repos/sphereio/sphere-sunrise/issues{/number}","pulls_url":"https://api.github.com/repos/sphereio/sphere-sunrise/pulls{/number}","milestones_url":"https://api.github.com/repos/sphereio/sphere-sunrise/milestones{/number}","notifications_url":"https://api.github.com/repos/sphereio/sphere-sunrise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sphereio/sphere-sunrise/labels{/name}","releases_url":"https://api.github.com/repos/sphereio/sphere-sunrise/releases{/id}","created_at":"2014-05-21T20:20:52Z","updated_at":"2014-11-19T19:16:07Z","pushed_at":"2014-12-05T15:02:14Z","git_url":"git://github.com/sphereio/sphere-sunrise.git","ssh_url":"git@github.com:sphereio/sphere-sunrise.git","clone_url":"https://github.com/sphereio/sphere-sunrise.git","svn_url":"https://github.com/sphereio/sphere-sunrise","homepage":"https://sunrise.sphere.io","size":718,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":46,"forks":1,"open_issues":46,"watchers":3,"default_branch":"master"}},"base":{"label":"sphereio:master","ref":"master","sha":"d6eba3b6adebd310a0badb6e820376b47c62e90e","user":{"login":"sphereio","id":4119130,"avatar_url":"https://avatars.githubusercontent.com/u/4119130?v=3","gravatar_id":"","url":"https://api.github.com/users/sphereio","html_url":"https://github.com/sphereio","followers_url":"https://api.github.com/users/sphereio/followers","following_url":"https://api.github.com/users/sphereio/following{/other_user}","gists_url":"https://api.github.com/users/sphereio/gists{/gist_id}","starred_url":"https://api.github.com/users/sphereio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sphereio/subscriptions","organizations_url":"https://api.github.com/users/sphereio/orgs","repos_url":"https://api.github.com/users/sphereio/repos","events_url":"https://api.github.com/users/sphereio/events{/privacy}","received_events_url":"https://api.github.com/users/sphereio/received_events","type":"Organization","site_admin":false},"repo":{"id":20036001,"name":"sphere-sunrise","full_name":"sphereio/sphere-sunrise","owner":{"login":"sphereio","id":4119130,"avatar_url":"https://avatars.githubusercontent.com/u/4119130?v=3","gravatar_id":"","url":"https://api.github.com/users/sphereio","html_url":"https://github.com/sphereio","followers_url":"https://api.github.com/users/sphereio/followers","following_url":"https://api.github.com/users/sphereio/following{/other_user}","gists_url":"https://api.github.com/users/sphereio/gists{/gist_id}","starred_url":"https://api.github.com/users/sphereio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sphereio/subscriptions","organizations_url":"https://api.github.com/users/sphereio/orgs","repos_url":"https://api.github.com/users/sphereio/repos","events_url":"https://api.github.com/users/sphereio/events{/privacy}","received_events_url":"https://api.github.com/users/sphereio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sphereio/sphere-sunrise","description":"The next generation SPHERE.IO demo shop template","fork":false,"url":"https://api.github.com/repos/sphereio/sphere-sunrise","forks_url":"https://api.github.com/repos/sphereio/sphere-sunrise/forks","keys_url":"https://api.github.com/repos/sphereio/sphere-sunrise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sphereio/sphere-sunrise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sphereio/sphere-sunrise/teams","hooks_url":"https://api.github.com/repos/sphereio/sphere-sunrise/hooks","issue_events_url":"https://api.github.com/repos/sphereio/sphere-sunrise/issues/events{/number}","events_url":"https://api.github.com/repos/sphereio/sphere-sunrise/events","assignees_url":"https://api.github.com/repos/sphereio/sphere-sunrise/assignees{/user}","branches_url":"https://api.github.com/repos/sphereio/sphere-sunrise/branches{/branch}","tags_url":"https://api.github.com/repos/sphereio/sphere-sunrise/tags","blobs_url":"https://api.github.com/repos/sphereio/sphere-sunrise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sphereio/sphere-sunrise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sphereio/sphere-sunrise/git/refs{/sha}","trees_url":"https://api.github.com/repos/sphereio/sphere-sunrise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sphereio/sphere-sunrise/statuses/{sha}","languages_url":"https://api.github.com/repos/sphereio/sphere-sunrise/languages","stargazers_url":"https://api.github.com/repos/sphereio/sphere-sunrise/stargazers","contributors_url":"https://api.github.com/repos/sphereio/sphere-sunrise/contributors","subscribers_url":"https://api.github.com/repos/sphereio/sphere-sunrise/subscribers","subscription_url":"https://api.github.com/repos/sphereio/sphere-sunrise/subscription","commits_url":"https://api.github.com/repos/sphereio/sphere-sunrise/commits{/sha}","git_commits_url":"https://api.github.com/repos/sphereio/sphere-sunrise/git/commits{/sha}","comments_url":"https://api.github.com/repos/sphereio/sphere-sunrise/comments{/number}","issue_comment_url":"https://api.github.com/repos/sphereio/sphere-sunrise/issues/comments/{number}","contents_url":"https://api.github.com/repos/sphereio/sphere-sunrise/contents/{+path}","compare_url":"https://api.github.com/repos/sphereio/sphere-sunrise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sphereio/sphere-sunrise/merges","archive_url":"https://api.github.com/repos/sphereio/sphere-sunrise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sphereio/sphere-sunrise/downloads","issues_url":"https://api.github.com/repos/sphereio/sphere-sunrise/issues{/number}","pulls_url":"https://api.github.com/repos/sphereio/sphere-sunrise/pulls{/number}","milestones_url":"https://api.github.com/repos/sphereio/sphere-sunrise/milestones{/number}","notifications_url":"https://api.github.com/repos/sphereio/sphere-sunrise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sphereio/sphere-sunrise/labels{/name}","releases_url":"https://api.github.com/repos/sphereio/sphere-sunrise/releases{/id}","created_at":"2014-05-21T20:20:52Z","updated_at":"2014-11-19T19:16:07Z","pushed_at":"2014-12-05T15:02:14Z","git_url":"git://github.com/sphereio/sphere-sunrise.git","ssh_url":"git@github.com:sphereio/sphere-sunrise.git","clone_url":"https://github.com/sphereio/sphere-sunrise.git","svn_url":"https://github.com/sphereio/sphere-sunrise","homepage":"https://sunrise.sphere.io","size":718,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":46,"forks":1,"open_issues":46,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sphereio/sphere-sunrise/pulls/65"},"html":{"href":"https://github.com/sphereio/sphere-sunrise/pull/65"},"issue":{"href":"https://api.github.com/repos/sphereio/sphere-sunrise/issues/65"},"comments":{"href":"https://api.github.com/repos/sphereio/sphere-sunrise/issues/65/comments"},"review_comments":{"href":"https://api.github.com/repos/sphereio/sphere-sunrise/pulls/65/comments"},"review_comment":{"href":"https://api.github.com/repos/sphereio/sphere-sunrise/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/sphereio/sphere-sunrise/pulls/65/commits"},"statuses":{"href":"https://api.github.com/repos/sphereio/sphere-sunrise/statuses/fcd4ee43513f28521892c97fe7d1d3552b4a3d8a"}}}}