GitHub PullRequestReviewCommentEvent at 2014-10-29 17:48:32
Repository: opensim-core
Actor: msdemers
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/opensim-org/opensim-core/pulls/comments/19557369","id":19557369,"diff_hunk":"@@ -175,7 +175,7 @@ void FixedFrame::initFixedFrameCache() const\n \t\t\tparentFixedFrame->initFixedFrameCache();\n \t\t}\n \t\t// all variables pointing to the parents root MobilizedBody should be valid\n-        _mbTransform = getTransform()*parentFixedFrame->getTransformInMobilizedBody();\n+        _mbTransform = parentFixedFrame->getTransformInMobilizedBody()*getTransform();","path":"OpenSim/Simulation/Model/FixedFrame.cpp","position":5,"original_position":5,"commit_id":"c72b61aa38f0aa2101a4c31611359f4496497695","original_commit_id":"c72b61aa38f0aa2101a4c31611359f4496497695","user":{"login":"msdemers","id":4503414,"avatar_url":"https://avatars.githubusercontent.com/u/4503414?v=2","gravatar_id":"","url":"https://api.github.com/users/msdemers","html_url":"https://github.com/msdemers","followers_url":"https://api.github.com/users/msdemers/followers","following_url":"https://api.github.com/users/msdemers/following{/other_user}","gists_url":"https://api.github.com/users/msdemers/gists{/gist_id}","starred_url":"https://api.github.com/users/msdemers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msdemers/subscriptions","organizations_url":"https://api.github.com/users/msdemers/orgs","repos_url":"https://api.github.com/users/msdemers/repos","events_url":"https://api.github.com/users/msdemers/events{/privacy}","received_events_url":"https://api.github.com/users/msdemers/received_events","type":"User","site_admin":false},"body":"@sherm1  I see them too.  tabs everywhere, which is really scary.  I'm looking at my settings, which say tab size = 4, indent size = 4, insert spaces.  So regardless of my settings, VS is still adding tabs instead of spaces. potentially everything I've written using 2013 could have tabs when I thought they had spaces.  What the heck?!?!","created_at":"2014-10-29T17:48:32Z","updated_at":"2014-10-29T17:48:32Z","html_url":"https://github.com/opensim-org/opensim-core/pull/226#discussion_r19557369","pull_request_url":"https://api.github.com/repos/opensim-org/opensim-core/pulls/226","_links":{"self":{"href":"https://api.github.com/repos/opensim-org/opensim-core/pulls/comments/19557369"},"html":{"href":"https://github.com/opensim-org/opensim-core/pull/226#discussion_r19557369"},"pull_request":{"href":"https://api.github.com/repos/opensim-org/opensim-core/pulls/226"}}},"pull_request":{"url":"https://api.github.com/repos/opensim-org/opensim-core/pulls/226","id":23510444,"html_url":"https://github.com/opensim-org/opensim-core/pull/226","diff_url":"https://github.com/opensim-org/opensim-core/pull/226.diff","patch_url":"https://github.com/opensim-org/opensim-core/pull/226.patch","issue_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/226","number":226,"state":"open","locked":false,"title":"Test frames remove anchor body","user":{"login":"msdemers","id":4503414,"avatar_url":"https://avatars.githubusercontent.com/u/4503414?v=2","gravatar_id":"","url":"https://api.github.com/users/msdemers","html_url":"https://github.com/msdemers","followers_url":"https://api.github.com/users/msdemers/followers","following_url":"https://api.github.com/users/msdemers/following{/other_user}","gists_url":"https://api.github.com/users/msdemers/gists{/gist_id}","starred_url":"https://api.github.com/users/msdemers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msdemers/subscriptions","organizations_url":"https://api.github.com/users/msdemers/orgs","repos_url":"https://api.github.com/users/msdemers/repos","events_url":"https://api.github.com/users/msdemers/events{/privacy}","received_events_url":"https://api.github.com/users/msdemers/received_events","type":"User","site_admin":false},"body":"This pull request fixes #220 . Deprecated use of \"anchorBody\" interfaces were causing compilation errors in the debug build.  Release builds compiled because these errors were contained in assert expression that were only compiled in debug builds. This PR specifically:\r\n\r\n1. Removes all outdated usage of getAnchorBody() and isAnchoredToBody() in testFrames\r\n2. Removes all usage of assert, using ASSERT instead throughout testFrames.\r\n3. Fixes a transposition bug in FixedFrames transform calculations.","created_at":"2014-10-29T06:20:12Z","updated_at":"2014-10-29T17:48:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f2f7aeffe5c2b1f619b1aeba187925867ef871a7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/opensim-org/opensim-core/pulls/226/commits","review_comments_url":"https://api.github.com/repos/opensim-org/opensim-core/pulls/226/comments","review_comment_url":"https://api.github.com/repos/opensim-org/opensim-core/pulls/comments/{number}","comments_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/226/comments","statuses_url":"https://api.github.com/repos/opensim-org/opensim-core/statuses/c72b61aa38f0aa2101a4c31611359f4496497695","head":{"label":"opensim-org:testFrames_remove_anchorBody","ref":"testFrames_remove_anchorBody","sha":"c72b61aa38f0aa2101a4c31611359f4496497695","user":{"login":"opensim-org","id":4370782,"avatar_url":"https://avatars.githubusercontent.com/u/4370782?v=2","gravatar_id":"","url":"https://api.github.com/users/opensim-org","html_url":"https://github.com/opensim-org","followers_url":"https://api.github.com/users/opensim-org/followers","following_url":"https://api.github.com/users/opensim-org/following{/other_user}","gists_url":"https://api.github.com/users/opensim-org/gists{/gist_id}","starred_url":"https://api.github.com/users/opensim-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opensim-org/subscriptions","organizations_url":"https://api.github.com/users/opensim-org/orgs","repos_url":"https://api.github.com/users/opensim-org/repos","events_url":"https://api.github.com/users/opensim-org/events{/privacy}","received_events_url":"https://api.github.com/users/opensim-org/received_events","type":"Organization","site_admin":false},"repo":{"id":20775600,"name":"opensim-core","full_name":"opensim-org/opensim-core","owner":{"login":"opensim-org","id":4370782,"avatar_url":"https://avatars.githubusercontent.com/u/4370782?v=2","gravatar_id":"","url":"https://api.github.com/users/opensim-org","html_url":"https://github.com/opensim-org","followers_url":"https://api.github.com/users/opensim-org/followers","following_url":"https://api.github.com/users/opensim-org/following{/other_user}","gists_url":"https://api.github.com/users/opensim-org/gists{/gist_id}","starred_url":"https://api.github.com/users/opensim-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opensim-org/subscriptions","organizations_url":"https://api.github.com/users/opensim-org/orgs","repos_url":"https://api.github.com/users/opensim-org/repos","events_url":"https://api.github.com/users/opensim-org/events{/privacy}","received_events_url":"https://api.github.com/users/opensim-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opensim-org/opensim-core","description":"SimTK OpenSim C++ libraries and comand-line applications and Java/Python wrapping.","fork":false,"url":"https://api.github.com/repos/opensim-org/opensim-core","forks_url":"https://api.github.com/repos/opensim-org/opensim-core/forks","keys_url":"https://api.github.com/repos/opensim-org/opensim-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opensim-org/opensim-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opensim-org/opensim-core/teams","hooks_url":"https://api.github.com/repos/opensim-org/opensim-core/hooks","issue_events_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/events{/number}","events_url":"https://api.github.com/repos/opensim-org/opensim-core/events","assignees_url":"https://api.github.com/repos/opensim-org/opensim-core/assignees{/user}","branches_url":"https://api.github.com/repos/opensim-org/opensim-core/branches{/branch}","tags_url":"https://api.github.com/repos/opensim-org/opensim-core/tags","blobs_url":"https://api.github.com/repos/opensim-org/opensim-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opensim-org/opensim-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opensim-org/opensim-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/opensim-org/opensim-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opensim-org/opensim-core/statuses/{sha}","languages_url":"https://api.github.com/repos/opensim-org/opensim-core/languages","stargazers_url":"https://api.github.com/repos/opensim-org/opensim-core/stargazers","contributors_url":"https://api.github.com/repos/opensim-org/opensim-core/contributors","subscribers_url":"https://api.github.com/repos/opensim-org/opensim-core/subscribers","subscription_url":"https://api.github.com/repos/opensim-org/opensim-core/subscription","commits_url":"https://api.github.com/repos/opensim-org/opensim-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/opensim-org/opensim-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/opensim-org/opensim-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/comments/{number}","contents_url":"https://api.github.com/repos/opensim-org/opensim-core/contents/{+path}","compare_url":"https://api.github.com/repos/opensim-org/opensim-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opensim-org/opensim-core/merges","archive_url":"https://api.github.com/repos/opensim-org/opensim-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opensim-org/opensim-core/downloads","issues_url":"https://api.github.com/repos/opensim-org/opensim-core/issues{/number}","pulls_url":"https://api.github.com/repos/opensim-org/opensim-core/pulls{/number}","milestones_url":"https://api.github.com/repos/opensim-org/opensim-core/milestones{/number}","notifications_url":"https://api.github.com/repos/opensim-org/opensim-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opensim-org/opensim-core/labels{/name}","releases_url":"https://api.github.com/repos/opensim-org/opensim-core/releases{/id}","created_at":"2014-06-12T16:57:56Z","updated_at":"2014-10-20T01:00:48Z","pushed_at":"2014-10-29T04:25:00Z","git_url":"git://github.com/opensim-org/opensim-core.git","ssh_url":"git@github.com:opensim-org/opensim-core.git","clone_url":"https://github.com/opensim-org/opensim-core.git","svn_url":"https://github.com/opensim-org/opensim-core","homepage":"opensim.stanford.edu","size":111243,"stargazers_count":6,"watchers_count":6,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":90,"forks":4,"open_issues":90,"watchers":6,"default_branch":"master"}},"base":{"label":"opensim-org:master","ref":"master","sha":"50cb035b70074d892290282dff6cd4bc51231df9","user":{"login":"opensim-org","id":4370782,"avatar_url":"https://avatars.githubusercontent.com/u/4370782?v=2","gravatar_id":"","url":"https://api.github.com/users/opensim-org","html_url":"https://github.com/opensim-org","followers_url":"https://api.github.com/users/opensim-org/followers","following_url":"https://api.github.com/users/opensim-org/following{/other_user}","gists_url":"https://api.github.com/users/opensim-org/gists{/gist_id}","starred_url":"https://api.github.com/users/opensim-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opensim-org/subscriptions","organizations_url":"https://api.github.com/users/opensim-org/orgs","repos_url":"https://api.github.com/users/opensim-org/repos","events_url":"https://api.github.com/users/opensim-org/events{/privacy}","received_events_url":"https://api.github.com/users/opensim-org/received_events","type":"Organization","site_admin":false},"repo":{"id":20775600,"name":"opensim-core","full_name":"opensim-org/opensim-core","owner":{"login":"opensim-org","id":4370782,"avatar_url":"https://avatars.githubusercontent.com/u/4370782?v=2","gravatar_id":"","url":"https://api.github.com/users/opensim-org","html_url":"https://github.com/opensim-org","followers_url":"https://api.github.com/users/opensim-org/followers","following_url":"https://api.github.com/users/opensim-org/following{/other_user}","gists_url":"https://api.github.com/users/opensim-org/gists{/gist_id}","starred_url":"https://api.github.com/users/opensim-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opensim-org/subscriptions","organizations_url":"https://api.github.com/users/opensim-org/orgs","repos_url":"https://api.github.com/users/opensim-org/repos","events_url":"https://api.github.com/users/opensim-org/events{/privacy}","received_events_url":"https://api.github.com/users/opensim-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opensim-org/opensim-core","description":"SimTK OpenSim C++ libraries and comand-line applications and Java/Python wrapping.","fork":false,"url":"https://api.github.com/repos/opensim-org/opensim-core","forks_url":"https://api.github.com/repos/opensim-org/opensim-core/forks","keys_url":"https://api.github.com/repos/opensim-org/opensim-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opensim-org/opensim-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opensim-org/opensim-core/teams","hooks_url":"https://api.github.com/repos/opensim-org/opensim-core/hooks","issue_events_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/events{/number}","events_url":"https://api.github.com/repos/opensim-org/opensim-core/events","assignees_url":"https://api.github.com/repos/opensim-org/opensim-core/assignees{/user}","branches_url":"https://api.github.com/repos/opensim-org/opensim-core/branches{/branch}","tags_url":"https://api.github.com/repos/opensim-org/opensim-core/tags","blobs_url":"https://api.github.com/repos/opensim-org/opensim-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opensim-org/opensim-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opensim-org/opensim-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/opensim-org/opensim-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opensim-org/opensim-core/statuses/{sha}","languages_url":"https://api.github.com/repos/opensim-org/opensim-core/languages","stargazers_url":"https://api.github.com/repos/opensim-org/opensim-core/stargazers","contributors_url":"https://api.github.com/repos/opensim-org/opensim-core/contributors","subscribers_url":"https://api.github.com/repos/opensim-org/opensim-core/subscribers","subscription_url":"https://api.github.com/repos/opensim-org/opensim-core/subscription","commits_url":"https://api.github.com/repos/opensim-org/opensim-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/opensim-org/opensim-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/opensim-org/opensim-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/comments/{number}","contents_url":"https://api.github.com/repos/opensim-org/opensim-core/contents/{+path}","compare_url":"https://api.github.com/repos/opensim-org/opensim-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opensim-org/opensim-core/merges","archive_url":"https://api.github.com/repos/opensim-org/opensim-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opensim-org/opensim-core/downloads","issues_url":"https://api.github.com/repos/opensim-org/opensim-core/issues{/number}","pulls_url":"https://api.github.com/repos/opensim-org/opensim-core/pulls{/number}","milestones_url":"https://api.github.com/repos/opensim-org/opensim-core/milestones{/number}","notifications_url":"https://api.github.com/repos/opensim-org/opensim-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opensim-org/opensim-core/labels{/name}","releases_url":"https://api.github.com/repos/opensim-org/opensim-core/releases{/id}","created_at":"2014-06-12T16:57:56Z","updated_at":"2014-10-20T01:00:48Z","pushed_at":"2014-10-29T04:25:00Z","git_url":"git://github.com/opensim-org/opensim-core.git","ssh_url":"git@github.com:opensim-org/opensim-core.git","clone_url":"https://github.com/opensim-org/opensim-core.git","svn_url":"https://github.com/opensim-org/opensim-core","homepage":"opensim.stanford.edu","size":111243,"stargazers_count":6,"watchers_count":6,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":90,"forks":4,"open_issues":90,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opensim-org/opensim-core/pulls/226"},"html":{"href":"https://github.com/opensim-org/opensim-core/pull/226"},"issue":{"href":"https://api.github.com/repos/opensim-org/opensim-core/issues/226"},"comments":{"href":"https://api.github.com/repos/opensim-org/opensim-core/issues/226/comments"},"review_comments":{"href":"https://api.github.com/repos/opensim-org/opensim-core/pulls/226/comments"},"review_comment":{"href":"https://api.github.com/repos/opensim-org/opensim-core/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/opensim-org/opensim-core/pulls/226/commits"},"statuses":{"href":"https://api.github.com/repos/opensim-org/opensim-core/statuses/c72b61aa38f0aa2101a4c31611359f4496497695"}}}}