GitHub PullRequestReviewCommentEvent at 2014-10-18 20:51:39
Repository: julia
Actor: staticfloat
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/19056259","id":19056259,"diff_hunk":"@@ -23,10 +23,20 @@ default: release\n endif\n \n # sort is used to remove potential duplicates\n-DIRS = $(sort $(build_bindir) $(build_libdir) $(build_private_libdir) $(build_libexecdir) $(build_sysconfdir)/julia $(build_datarootdir)/julia $(build_datarootdir)/man/man1)\n+DIRS = $(sort $(build_bindir) $(build_libdir) $(build_private_libdir) $(build_libexecdir) $(build_sysconfdir)/julia $(build_datarootdir)/julia $(build_man1dir))\n \n $(foreach dir,$(DIRS),$(eval $(call dir_target,$(dir))))\n-$(foreach link,base test doc examples,$(eval $(call symlink_target,$(link),$(build_datarootdir)/julia)))\n+$(foreach link,base test,$(eval $(call symlink_target,$(link),$(build_datarootdir)/julia)))\n+\n+# doc needs to live under $(build_docdir), not under $(build_datarootdir)/julia/\n+CLEAN_TARGETS += clean-$(build_docdir)\n+clean-$(build_docdir):\n+\t@-rm -fr $(abspath $(build_docdir))\n+$(subst $(abspath $(JULIAHOME))/,,$(abspath $(build_docdir))): $(build_docdir)\n+$(build_docdir): | doc","path":"Makefile","position":16,"original_position":16,"commit_id":"3113bfd0aa54c47917b2b99d6d477361d47a8597","original_commit_id":"3113bfd0aa54c47917b2b99d6d477361d47a8597","user":{"login":"staticfloat","id":130920,"avatar_url":"https://avatars.githubusercontent.com/u/130920?v=2","gravatar_id":"","url":"https://api.github.com/users/staticfloat","html_url":"https://github.com/staticfloat","followers_url":"https://api.github.com/users/staticfloat/followers","following_url":"https://api.github.com/users/staticfloat/following{/other_user}","gists_url":"https://api.github.com/users/staticfloat/gists{/gist_id}","starred_url":"https://api.github.com/users/staticfloat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/staticfloat/subscriptions","organizations_url":"https://api.github.com/users/staticfloat/orgs","repos_url":"https://api.github.com/users/staticfloat/repos","events_url":"https://api.github.com/users/staticfloat/events{/privacy}","received_events_url":"https://api.github.com/users/staticfloat/received_events","type":"User","site_admin":false},"body":"Do we actually have a `doc` target?  If not, that `| doc` isn't doing anything, I don't think.","created_at":"2014-10-18T20:51:39Z","updated_at":"2014-10-18T20:51:39Z","html_url":"https://github.com/JuliaLang/julia/pull/8428#discussion_r19056259","pull_request_url":"https://api.github.com/repos/JuliaLang/julia/pulls/8428","_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/19056259"},"html":{"href":"https://github.com/JuliaLang/julia/pull/8428#discussion_r19056259"},"pull_request":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/8428"}}},"pull_request":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/8428","id":21539043,"html_url":"https://github.com/JuliaLang/julia/pull/8428","diff_url":"https://github.com/JuliaLang/julia/pull/8428.diff","patch_url":"https://github.com/JuliaLang/julia/pull/8428.patch","issue_url":"https://api.github.com/repos/JuliaLang/julia/issues/8428","number":8428,"state":"open","locked":false,"title":"Make install cleaning and improvements","user":{"login":"nalimilan","id":1120448,"avatar_url":"https://avatars.githubusercontent.com/u/1120448?v=2","gravatar_id":"","url":"https://api.github.com/users/nalimilan","html_url":"https://github.com/nalimilan","followers_url":"https://api.github.com/users/nalimilan/followers","following_url":"https://api.github.com/users/nalimilan/following{/other_user}","gists_url":"https://api.github.com/users/nalimilan/gists{/gist_id}","starred_url":"https://api.github.com/users/nalimilan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nalimilan/subscriptions","organizations_url":"https://api.github.com/users/nalimilan/orgs","repos_url":"https://api.github.com/users/nalimilan/repos","events_url":"https://api.github.com/users/nalimilan/events{/privacy}","received_events_url":"https://api.github.com/users/nalimilan/received_events","type":"User","site_admin":false},"body":"The first commit makes the tree resulting from `make install` cleaner.\r\n\r\nThe second one is an attempt at fixing https://github.com/JuliaLang/julia/issues/8367, but it currently doesn't work. I'd appreciate some help from the genius who wrote Makefile:27. It should be adapted so that the symlink to `doc/` is no longer created at `$(build_datarootdir)/julia/doc`, but at `$(build_docdir)` -- Make.inc:102 should then also be made consistent with Make.inc:89.","created_at":"2014-09-20T16:41:07Z","updated_at":"2014-10-18T20:51:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"35b2126ffaed9d745d128649b6a217a9d6eac1aa","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/JuliaLang/julia/pulls/8428/commits","review_comments_url":"https://api.github.com/repos/JuliaLang/julia/pulls/8428/comments","review_comment_url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/{number}","comments_url":"https://api.github.com/repos/JuliaLang/julia/issues/8428/comments","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/3113bfd0aa54c47917b2b99d6d477361d47a8597","head":{"label":"nalimilan:makeinstall","ref":"makeinstall","sha":"3113bfd0aa54c47917b2b99d6d477361d47a8597","user":{"login":"nalimilan","id":1120448,"avatar_url":"https://avatars.githubusercontent.com/u/1120448?v=2","gravatar_id":"","url":"https://api.github.com/users/nalimilan","html_url":"https://github.com/nalimilan","followers_url":"https://api.github.com/users/nalimilan/followers","following_url":"https://api.github.com/users/nalimilan/following{/other_user}","gists_url":"https://api.github.com/users/nalimilan/gists{/gist_id}","starred_url":"https://api.github.com/users/nalimilan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nalimilan/subscriptions","organizations_url":"https://api.github.com/users/nalimilan/orgs","repos_url":"https://api.github.com/users/nalimilan/repos","events_url":"https://api.github.com/users/nalimilan/events{/privacy}","received_events_url":"https://api.github.com/users/nalimilan/received_events","type":"User","site_admin":false},"repo":{"id":14256051,"name":"julia","full_name":"nalimilan/julia","owner":{"login":"nalimilan","id":1120448,"avatar_url":"https://avatars.githubusercontent.com/u/1120448?v=2","gravatar_id":"","url":"https://api.github.com/users/nalimilan","html_url":"https://github.com/nalimilan","followers_url":"https://api.github.com/users/nalimilan/followers","following_url":"https://api.github.com/users/nalimilan/following{/other_user}","gists_url":"https://api.github.com/users/nalimilan/gists{/gist_id}","starred_url":"https://api.github.com/users/nalimilan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nalimilan/subscriptions","organizations_url":"https://api.github.com/users/nalimilan/orgs","repos_url":"https://api.github.com/users/nalimilan/repos","events_url":"https://api.github.com/users/nalimilan/events{/privacy}","received_events_url":"https://api.github.com/users/nalimilan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nalimilan/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":true,"url":"https://api.github.com/repos/nalimilan/julia","forks_url":"https://api.github.com/repos/nalimilan/julia/forks","keys_url":"https://api.github.com/repos/nalimilan/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nalimilan/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nalimilan/julia/teams","hooks_url":"https://api.github.com/repos/nalimilan/julia/hooks","issue_events_url":"https://api.github.com/repos/nalimilan/julia/issues/events{/number}","events_url":"https://api.github.com/repos/nalimilan/julia/events","assignees_url":"https://api.github.com/repos/nalimilan/julia/assignees{/user}","branches_url":"https://api.github.com/repos/nalimilan/julia/branches{/branch}","tags_url":"https://api.github.com/repos/nalimilan/julia/tags","blobs_url":"https://api.github.com/repos/nalimilan/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nalimilan/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nalimilan/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/nalimilan/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nalimilan/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/nalimilan/julia/languages","stargazers_url":"https://api.github.com/repos/nalimilan/julia/stargazers","contributors_url":"https://api.github.com/repos/nalimilan/julia/contributors","subscribers_url":"https://api.github.com/repos/nalimilan/julia/subscribers","subscription_url":"https://api.github.com/repos/nalimilan/julia/subscription","commits_url":"https://api.github.com/repos/nalimilan/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/nalimilan/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/nalimilan/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/nalimilan/julia/issues/comments/{number}","contents_url":"https://api.github.com/repos/nalimilan/julia/contents/{+path}","compare_url":"https://api.github.com/repos/nalimilan/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nalimilan/julia/merges","archive_url":"https://api.github.com/repos/nalimilan/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nalimilan/julia/downloads","issues_url":"https://api.github.com/repos/nalimilan/julia/issues{/number}","pulls_url":"https://api.github.com/repos/nalimilan/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/nalimilan/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/nalimilan/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nalimilan/julia/labels{/name}","releases_url":"https://api.github.com/repos/nalimilan/julia/releases{/id}","created_at":"2013-11-09T11:26:36Z","updated_at":"2014-06-20T16:34:33Z","pushed_at":"2014-10-18T19:05:54Z","git_url":"git://github.com/nalimilan/julia.git","ssh_url":"git@github.com:nalimilan/julia.git","clone_url":"https://github.com/nalimilan/julia.git","svn_url":"https://github.com/nalimilan/julia","homepage":"http://julialang.org/","size":44611,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaLang:master","ref":"master","sha":"f4cc46f84b0e38daef3e96e51e166d84d90cfe73","user":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=2","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"repo":{"id":1644196,"name":"julia","full_name":"JuliaLang/julia","owner":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=2","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaLang/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":false,"url":"https://api.github.com/repos/JuliaLang/julia","forks_url":"https://api.github.com/repos/JuliaLang/julia/forks","keys_url":"https://api.github.com/repos/JuliaLang/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaLang/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaLang/julia/teams","hooks_url":"https://api.github.com/repos/JuliaLang/julia/hooks","issue_events_url":"https://api.github.com/repos/JuliaLang/julia/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaLang/julia/events","assignees_url":"https://api.github.com/repos/JuliaLang/julia/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaLang/julia/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaLang/julia/tags","blobs_url":"https://api.github.com/repos/JuliaLang/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaLang/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaLang/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaLang/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaLang/julia/languages","stargazers_url":"https://api.github.com/repos/JuliaLang/julia/stargazers","contributors_url":"https://api.github.com/repos/JuliaLang/julia/contributors","subscribers_url":"https://api.github.com/repos/JuliaLang/julia/subscribers","subscription_url":"https://api.github.com/repos/JuliaLang/julia/subscription","commits_url":"https://api.github.com/repos/JuliaLang/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaLang/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaLang/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaLang/julia/issues/comments/{number}","contents_url":"https://api.github.com/repos/JuliaLang/julia/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaLang/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaLang/julia/merges","archive_url":"https://api.github.com/repos/JuliaLang/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaLang/julia/downloads","issues_url":"https://api.github.com/repos/JuliaLang/julia/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaLang/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaLang/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaLang/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaLang/julia/labels{/name}","releases_url":"https://api.github.com/repos/JuliaLang/julia/releases{/id}","created_at":"2011-04-21T07:01:50Z","updated_at":"2014-10-18T20:39:32Z","pushed_at":"2014-10-18T20:43:36Z","git_url":"git://github.com/JuliaLang/julia.git","ssh_url":"git@github.com:JuliaLang/julia.git","clone_url":"https://github.com/JuliaLang/julia.git","svn_url":"https://github.com/JuliaLang/julia","homepage":"http://julialang.org/","size":179473,"stargazers_count":4488,"watchers_count":4488,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":909,"mirror_url":null,"open_issues_count":980,"forks":909,"open_issues":980,"watchers":4488,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/8428"},"html":{"href":"https://github.com/JuliaLang/julia/pull/8428"},"issue":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/8428"},"comments":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/8428/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/8428/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/8428/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaLang/julia/statuses/3113bfd0aa54c47917b2b99d6d477361d47a8597"}}}}