GitHub PullRequestEvent at 2014-07-09 19:38:25
Repository: cortex
Actor: johnhaddon
Payload: {"action":"opened","number":308,"pull_request":{"url":"https://api.github.com/repos/ImageEngine/cortex/pulls/308","id":18181859,"html_url":"https://github.com/ImageEngine/cortex/pull/308","diff_url":"https://github.com/ImageEngine/cortex/pull/308.diff","patch_url":"https://github.com/ImageEngine/cortex/pull/308.patch","issue_url":"https://api.github.com/repos/ImageEngine/cortex/issues/308","number":308,"state":"open","title":"Boost intrusive pointer","user":{"login":"johnhaddon","id":1133871,"avatar_url":"https://avatars.githubusercontent.com/u/1133871?","gravatar_id":"1479dd3e029e9b4e0dd6e834fc40b776","url":"https://api.github.com/users/johnhaddon","html_url":"https://github.com/johnhaddon","followers_url":"https://api.github.com/users/johnhaddon/followers","following_url":"https://api.github.com/users/johnhaddon/following{/other_user}","gists_url":"https://api.github.com/users/johnhaddon/gists{/gist_id}","starred_url":"https://api.github.com/users/johnhaddon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnhaddon/subscriptions","organizations_url":"https://api.github.com/users/johnhaddon/orgs","repos_url":"https://api.github.com/users/johnhaddon/repos","events_url":"https://api.github.com/users/johnhaddon/events{/privacy}","received_events_url":"https://api.github.com/users/johnhaddon/received_events","type":"User","site_admin":false},"body":"This replaces `IECore::IntrusivePtr` with the standard `boost::intrusive_ptr`, with the rationale explained in the first commit message. It also updates some APIs to return raw pointers where they used to return smart pointers, following the conventions laid out in RefCounted.h.\r\n\r\nThis does affect client code, with the following changes being necessary :\r\n\r\n- Replace references to `IECore::IntrusivePtr` with `boost::intrusive_ptr`. There should be few (if any) of these since we use typedefs.\r\n- Replace calls to `IECore::staticPointerCast` with `boost::static_pointer_cast`, `IECore::constPointerCast` with `boost::const_pointer_cast` and `IECore::dynamicPointerCast` with `boost::dynamic_pointer_cast`.\r\n- Use `intrusive_ptr::get()` to cast to a raw pointer.\r\n\r\nI'm about to make an equivalent pull request for Gaffer - the two will need to be merged together.","created_at":"2014-07-09T19:38:25Z","updated_at":"2014-07-09T19:38:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ImageEngine/cortex/pulls/308/commits","review_comments_url":"https://api.github.com/repos/ImageEngine/cortex/pulls/308/comments","review_comment_url":"https://api.github.com/repos/ImageEngine/cortex/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ImageEngine/cortex/issues/308/comments","statuses_url":"https://api.github.com/repos/ImageEngine/cortex/statuses/66d37340f6b6d580d1634bec465207489cf5def7","head":{"label":"johnhaddon:boostIntrusivePointer","ref":"boostIntrusivePointer","sha":"66d37340f6b6d580d1634bec465207489cf5def7","user":{"login":"johnhaddon","id":1133871,"avatar_url":"https://avatars.githubusercontent.com/u/1133871?","gravatar_id":"1479dd3e029e9b4e0dd6e834fc40b776","url":"https://api.github.com/users/johnhaddon","html_url":"https://github.com/johnhaddon","followers_url":"https://api.github.com/users/johnhaddon/followers","following_url":"https://api.github.com/users/johnhaddon/following{/other_user}","gists_url":"https://api.github.com/users/johnhaddon/gists{/gist_id}","starred_url":"https://api.github.com/users/johnhaddon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnhaddon/subscriptions","organizations_url":"https://api.github.com/users/johnhaddon/orgs","repos_url":"https://api.github.com/users/johnhaddon/repos","events_url":"https://api.github.com/users/johnhaddon/events{/privacy}","received_events_url":"https://api.github.com/users/johnhaddon/received_events","type":"User","site_admin":false},"repo":{"id":10675715,"name":"cortex","full_name":"johnhaddon/cortex","owner":{"login":"johnhaddon","id":1133871,"avatar_url":"https://avatars.githubusercontent.com/u/1133871?","gravatar_id":"1479dd3e029e9b4e0dd6e834fc40b776","url":"https://api.github.com/users/johnhaddon","html_url":"https://github.com/johnhaddon","followers_url":"https://api.github.com/users/johnhaddon/followers","following_url":"https://api.github.com/users/johnhaddon/following{/other_user}","gists_url":"https://api.github.com/users/johnhaddon/gists{/gist_id}","starred_url":"https://api.github.com/users/johnhaddon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnhaddon/subscriptions","organizations_url":"https://api.github.com/users/johnhaddon/orgs","repos_url":"https://api.github.com/users/johnhaddon/repos","events_url":"https://api.github.com/users/johnhaddon/events{/privacy}","received_events_url":"https://api.github.com/users/johnhaddon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/johnhaddon/cortex","description":"My day-to-day development","fork":true,"url":"https://api.github.com/repos/johnhaddon/cortex","forks_url":"https://api.github.com/repos/johnhaddon/cortex/forks","keys_url":"https://api.github.com/repos/johnhaddon/cortex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johnhaddon/cortex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johnhaddon/cortex/teams","hooks_url":"https://api.github.com/repos/johnhaddon/cortex/hooks","issue_events_url":"https://api.github.com/repos/johnhaddon/cortex/issues/events{/number}","events_url":"https://api.github.com/repos/johnhaddon/cortex/events","assignees_url":"https://api.github.com/repos/johnhaddon/cortex/assignees{/user}","branches_url":"https://api.github.com/repos/johnhaddon/cortex/branches{/branch}","tags_url":"https://api.github.com/repos/johnhaddon/cortex/tags","blobs_url":"https://api.github.com/repos/johnhaddon/cortex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johnhaddon/cortex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johnhaddon/cortex/git/refs{/sha}","trees_url":"https://api.github.com/repos/johnhaddon/cortex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johnhaddon/cortex/statuses/{sha}","languages_url":"https://api.github.com/repos/johnhaddon/cortex/languages","stargazers_url":"https://api.github.com/repos/johnhaddon/cortex/stargazers","contributors_url":"https://api.github.com/repos/johnhaddon/cortex/contributors","subscribers_url":"https://api.github.com/repos/johnhaddon/cortex/subscribers","subscription_url":"https://api.github.com/repos/johnhaddon/cortex/subscription","commits_url":"https://api.github.com/repos/johnhaddon/cortex/commits{/sha}","git_commits_url":"https://api.github.com/repos/johnhaddon/cortex/git/commits{/sha}","comments_url":"https://api.github.com/repos/johnhaddon/cortex/comments{/number}","issue_comment_url":"https://api.github.com/repos/johnhaddon/cortex/issues/comments/{number}","contents_url":"https://api.github.com/repos/johnhaddon/cortex/contents/{+path}","compare_url":"https://api.github.com/repos/johnhaddon/cortex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johnhaddon/cortex/merges","archive_url":"https://api.github.com/repos/johnhaddon/cortex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johnhaddon/cortex/downloads","issues_url":"https://api.github.com/repos/johnhaddon/cortex/issues{/number}","pulls_url":"https://api.github.com/repos/johnhaddon/cortex/pulls{/number}","milestones_url":"https://api.github.com/repos/johnhaddon/cortex/milestones{/number}","notifications_url":"https://api.github.com/repos/johnhaddon/cortex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johnhaddon/cortex/labels{/name}","releases_url":"https://api.github.com/repos/johnhaddon/cortex/releases{/id}","created_at":"2013-06-13T20:54:11Z","updated_at":"2014-06-26T09:48:47Z","pushed_at":"2014-07-09T18:21:47Z","git_url":"git://github.com/johnhaddon/cortex.git","ssh_url":"git@github.com:johnhaddon/cortex.git","clone_url":"https://github.com/johnhaddon/cortex.git","svn_url":"https://github.com/johnhaddon/cortex","homepage":"","size":95359,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ImageEngine:master","ref":"master","sha":"6b8e34038301880b7d84f00a5cd726671fb72e1d","user":{"login":"ImageEngine","id":3976662,"avatar_url":"https://avatars.githubusercontent.com/u/3976662?","gravatar_id":"e46de9a3ed1fcfdb98587371f3161b0a","url":"https://api.github.com/users/ImageEngine","html_url":"https://github.com/ImageEngine","followers_url":"https://api.github.com/users/ImageEngine/followers","following_url":"https://api.github.com/users/ImageEngine/following{/other_user}","gists_url":"https://api.github.com/users/ImageEngine/gists{/gist_id}","starred_url":"https://api.github.com/users/ImageEngine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ImageEngine/subscriptions","organizations_url":"https://api.github.com/users/ImageEngine/orgs","repos_url":"https://api.github.com/users/ImageEngine/repos","events_url":"https://api.github.com/users/ImageEngine/events{/privacy}","received_events_url":"https://api.github.com/users/ImageEngine/received_events","type":"Organization","site_admin":false},"repo":{"id":10654465,"name":"cortex","full_name":"ImageEngine/cortex","owner":{"login":"ImageEngine","id":3976662,"avatar_url":"https://avatars.githubusercontent.com/u/3976662?","gravatar_id":"e46de9a3ed1fcfdb98587371f3161b0a","url":"https://api.github.com/users/ImageEngine","html_url":"https://github.com/ImageEngine","followers_url":"https://api.github.com/users/ImageEngine/followers","following_url":"https://api.github.com/users/ImageEngine/following{/other_user}","gists_url":"https://api.github.com/users/ImageEngine/gists{/gist_id}","starred_url":"https://api.github.com/users/ImageEngine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ImageEngine/subscriptions","organizations_url":"https://api.github.com/users/ImageEngine/orgs","repos_url":"https://api.github.com/users/ImageEngine/repos","events_url":"https://api.github.com/users/ImageEngine/events{/privacy}","received_events_url":"https://api.github.com/users/ImageEngine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ImageEngine/cortex","description":"Libraries for visual effects software development","fork":false,"url":"https://api.github.com/repos/ImageEngine/cortex","forks_url":"https://api.github.com/repos/ImageEngine/cortex/forks","keys_url":"https://api.github.com/repos/ImageEngine/cortex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ImageEngine/cortex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ImageEngine/cortex/teams","hooks_url":"https://api.github.com/repos/ImageEngine/cortex/hooks","issue_events_url":"https://api.github.com/repos/ImageEngine/cortex/issues/events{/number}","events_url":"https://api.github.com/repos/ImageEngine/cortex/events","assignees_url":"https://api.github.com/repos/ImageEngine/cortex/assignees{/user}","branches_url":"https://api.github.com/repos/ImageEngine/cortex/branches{/branch}","tags_url":"https://api.github.com/repos/ImageEngine/cortex/tags","blobs_url":"https://api.github.com/repos/ImageEngine/cortex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ImageEngine/cortex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ImageEngine/cortex/git/refs{/sha}","trees_url":"https://api.github.com/repos/ImageEngine/cortex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ImageEngine/cortex/statuses/{sha}","languages_url":"https://api.github.com/repos/ImageEngine/cortex/languages","stargazers_url":"https://api.github.com/repos/ImageEngine/cortex/stargazers","contributors_url":"https://api.github.com/repos/ImageEngine/cortex/contributors","subscribers_url":"https://api.github.com/repos/ImageEngine/cortex/subscribers","subscription_url":"https://api.github.com/repos/ImageEngine/cortex/subscription","commits_url":"https://api.github.com/repos/ImageEngine/cortex/commits{/sha}","git_commits_url":"https://api.github.com/repos/ImageEngine/cortex/git/commits{/sha}","comments_url":"https://api.github.com/repos/ImageEngine/cortex/comments{/number}","issue_comment_url":"https://api.github.com/repos/ImageEngine/cortex/issues/comments/{number}","contents_url":"https://api.github.com/repos/ImageEngine/cortex/contents/{+path}","compare_url":"https://api.github.com/repos/ImageEngine/cortex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ImageEngine/cortex/merges","archive_url":"https://api.github.com/repos/ImageEngine/cortex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ImageEngine/cortex/downloads","issues_url":"https://api.github.com/repos/ImageEngine/cortex/issues{/number}","pulls_url":"https://api.github.com/repos/ImageEngine/cortex/pulls{/number}","milestones_url":"https://api.github.com/repos/ImageEngine/cortex/milestones{/number}","notifications_url":"https://api.github.com/repos/ImageEngine/cortex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ImageEngine/cortex/labels{/name}","releases_url":"https://api.github.com/repos/ImageEngine/cortex/releases{/id}","created_at":"2013-06-12T23:12:28Z","updated_at":"2014-07-03T08:39:54Z","pushed_at":"2014-07-08T17:03:54Z","git_url":"git://github.com/ImageEngine/cortex.git","ssh_url":"git@github.com:ImageEngine/cortex.git","clone_url":"https://github.com/ImageEngine/cortex.git","svn_url":"https://github.com/ImageEngine/cortex","homepage":null,"size":139150,"stargazers_count":81,"watchers_count":81,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":33,"mirror_url":null,"open_issues_count":26,"forks":33,"open_issues":26,"watchers":81,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ImageEngine/cortex/pulls/308"},"html":{"href":"https://github.com/ImageEngine/cortex/pull/308"},"issue":{"href":"https://api.github.com/repos/ImageEngine/cortex/issues/308"},"comments":{"href":"https://api.github.com/repos/ImageEngine/cortex/issues/308/comments"},"review_comments":{"href":"https://api.github.com/repos/ImageEngine/cortex/pulls/308/comments"},"review_comment":{"href":"https://api.github.com/repos/ImageEngine/cortex/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ImageEngine/cortex/pulls/308/commits"},"statuses":{"href":"https://api.github.com/repos/ImageEngine/cortex/statuses/66d37340f6b6d580d1634bec465207489cf5def7"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":18,"additions":1519,"deletions":1886,"changed_files":295}}