GitHub PullRequestReviewCommentEvent at 2014-11-03 22:32:32
Repository: ZenGarden
Actor: mhroth
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mhroth/ZenGarden/pulls/comments/19772291","id":19772291,"diff_hunk":"@@ -23,49 +23,49 @@\n #include \"ArrayArithmetic.h\"\n #include \"DspDac.h\"\n #include \"PdGraph.h\"\n+#include \"PdContext.h\"\n \n MessageObject *DspDac::newObject(PdMessage *initMessage, PdGraph *graph) {\n-  return new DspDac(graph);\n+  return new DspDac(initMessage, graph);\n }\n \n-DspDac::DspDac(PdGraph *graph) : DspObject(0, graph->getNumOutputChannels(), 0, 0, graph) {\n-  // cache pointers to global output buffers in dspBufferAtOutlet\n-  int numInlets = graph->getNumOutputChannels();\n-  if (numInlets > 2) dspBufferAtOutlet[2] = (float *) calloc(numInlets-2, sizeof(float *));\n-  \n-  for (int i = 0; i < numInlets; i++) {\n-    setDspBufferAtOutlet(graph->getGlobalDspBufferAtOutlet(i), i);\n+DspDac::DspDac(PdMessage *initMessage, PdGraph *graph)\n+  : DspObject(0, 1, 0, 0, graph) {\n+\n+  // empty init message will always contains a bang (cf. PdMessage::initWithString)\n+  if (initMessage->getNumElements() == 1 && initMessage->isBang(0)) {\n+    outputBuffers.reserve(graph->getNumOutputChannels());","path":"src/DspDac.cpp","position":23,"original_position":23,"commit_id":"5bca1f9b668d4bcb8afc7a3b4c6401af69f4f722","original_commit_id":"5bca1f9b668d4bcb8afc7a3b4c6401af69f4f722","user":{"login":"mhroth","id":25988,"avatar_url":"https://avatars.githubusercontent.com/u/25988?v=2","gravatar_id":"","url":"https://api.github.com/users/mhroth","html_url":"https://github.com/mhroth","followers_url":"https://api.github.com/users/mhroth/followers","following_url":"https://api.github.com/users/mhroth/following{/other_user}","gists_url":"https://api.github.com/users/mhroth/gists{/gist_id}","starred_url":"https://api.github.com/users/mhroth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhroth/subscriptions","organizations_url":"https://api.github.com/users/mhroth/orgs","repos_url":"https://api.github.com/users/mhroth/repos","events_url":"https://api.github.com/users/mhroth/events{/privacy}","received_events_url":"https://api.github.com/users/mhroth/received_events","type":"User","site_admin":false},"body":"But why would you ever get an initialisation message with a bang? Wouldn't the message just be a list of floats?","created_at":"2014-11-03T22:32:32Z","updated_at":"2014-11-03T22:32:32Z","html_url":"https://github.com/mhroth/ZenGarden/pull/53#discussion_r19772291","pull_request_url":"https://api.github.com/repos/mhroth/ZenGarden/pulls/53","_links":{"self":{"href":"https://api.github.com/repos/mhroth/ZenGarden/pulls/comments/19772291"},"html":{"href":"https://github.com/mhroth/ZenGarden/pull/53#discussion_r19772291"},"pull_request":{"href":"https://api.github.com/repos/mhroth/ZenGarden/pulls/53"}}},"pull_request":{"url":"https://api.github.com/repos/mhroth/ZenGarden/pulls/53","id":23530471,"html_url":"https://github.com/mhroth/ZenGarden/pull/53","diff_url":"https://github.com/mhroth/ZenGarden/pull/53.diff","patch_url":"https://github.com/mhroth/ZenGarden/pull/53.patch","issue_url":"https://api.github.com/repos/mhroth/ZenGarden/issues/53","number":53,"state":"open","locked":false,"title":"Fixed DspDac not working like the pd dac~","user":{"login":"Kyew","id":3237676,"avatar_url":"https://avatars.githubusercontent.com/u/3237676?v=2","gravatar_id":"","url":"https://api.github.com/users/Kyew","html_url":"https://github.com/Kyew","followers_url":"https://api.github.com/users/Kyew/followers","following_url":"https://api.github.com/users/Kyew/following{/other_user}","gists_url":"https://api.github.com/users/Kyew/gists{/gist_id}","starred_url":"https://api.github.com/users/Kyew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kyew/subscriptions","organizations_url":"https://api.github.com/users/Kyew/orgs","repos_url":"https://api.github.com/users/Kyew/repos","events_url":"https://api.github.com/users/Kyew/events{/privacy}","received_events_url":"https://api.github.com/users/Kyew/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-10-29T13:39:47Z","updated_at":"2014-11-03T22:32:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"44bf5ff025284f8ee655e81df106b39e5dca9e96","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mhroth/ZenGarden/pulls/53/commits","review_comments_url":"https://api.github.com/repos/mhroth/ZenGarden/pulls/53/comments","review_comment_url":"https://api.github.com/repos/mhroth/ZenGarden/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mhroth/ZenGarden/issues/53/comments","statuses_url":"https://api.github.com/repos/mhroth/ZenGarden/statuses/5bca1f9b668d4bcb8afc7a3b4c6401af69f4f722","head":{"label":"Kyew:dac","ref":"dac","sha":"5bca1f9b668d4bcb8afc7a3b4c6401af69f4f722","user":{"login":"Kyew","id":3237676,"avatar_url":"https://avatars.githubusercontent.com/u/3237676?v=2","gravatar_id":"","url":"https://api.github.com/users/Kyew","html_url":"https://github.com/Kyew","followers_url":"https://api.github.com/users/Kyew/followers","following_url":"https://api.github.com/users/Kyew/following{/other_user}","gists_url":"https://api.github.com/users/Kyew/gists{/gist_id}","starred_url":"https://api.github.com/users/Kyew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kyew/subscriptions","organizations_url":"https://api.github.com/users/Kyew/orgs","repos_url":"https://api.github.com/users/Kyew/repos","events_url":"https://api.github.com/users/Kyew/events{/privacy}","received_events_url":"https://api.github.com/users/Kyew/received_events","type":"User","site_admin":false},"repo":{"id":23072248,"name":"ZenGarden","full_name":"Kyew/ZenGarden","owner":{"login":"Kyew","id":3237676,"avatar_url":"https://avatars.githubusercontent.com/u/3237676?v=2","gravatar_id":"","url":"https://api.github.com/users/Kyew","html_url":"https://github.com/Kyew","followers_url":"https://api.github.com/users/Kyew/followers","following_url":"https://api.github.com/users/Kyew/following{/other_user}","gists_url":"https://api.github.com/users/Kyew/gists{/gist_id}","starred_url":"https://api.github.com/users/Kyew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kyew/subscriptions","organizations_url":"https://api.github.com/users/Kyew/orgs","repos_url":"https://api.github.com/users/Kyew/repos","events_url":"https://api.github.com/users/Kyew/events{/privacy}","received_events_url":"https://api.github.com/users/Kyew/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Kyew/ZenGarden","description":"ZenGarden is a stand-alone library for running Pure Data patches.","fork":true,"url":"https://api.github.com/repos/Kyew/ZenGarden","forks_url":"https://api.github.com/repos/Kyew/ZenGarden/forks","keys_url":"https://api.github.com/repos/Kyew/ZenGarden/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kyew/ZenGarden/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kyew/ZenGarden/teams","hooks_url":"https://api.github.com/repos/Kyew/ZenGarden/hooks","issue_events_url":"https://api.github.com/repos/Kyew/ZenGarden/issues/events{/number}","events_url":"https://api.github.com/repos/Kyew/ZenGarden/events","assignees_url":"https://api.github.com/repos/Kyew/ZenGarden/assignees{/user}","branches_url":"https://api.github.com/repos/Kyew/ZenGarden/branches{/branch}","tags_url":"https://api.github.com/repos/Kyew/ZenGarden/tags","blobs_url":"https://api.github.com/repos/Kyew/ZenGarden/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kyew/ZenGarden/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kyew/ZenGarden/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kyew/ZenGarden/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kyew/ZenGarden/statuses/{sha}","languages_url":"https://api.github.com/repos/Kyew/ZenGarden/languages","stargazers_url":"https://api.github.com/repos/Kyew/ZenGarden/stargazers","contributors_url":"https://api.github.com/repos/Kyew/ZenGarden/contributors","subscribers_url":"https://api.github.com/repos/Kyew/ZenGarden/subscribers","subscription_url":"https://api.github.com/repos/Kyew/ZenGarden/subscription","commits_url":"https://api.github.com/repos/Kyew/ZenGarden/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kyew/ZenGarden/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kyew/ZenGarden/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kyew/ZenGarden/issues/comments/{number}","contents_url":"https://api.github.com/repos/Kyew/ZenGarden/contents/{+path}","compare_url":"https://api.github.com/repos/Kyew/ZenGarden/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kyew/ZenGarden/merges","archive_url":"https://api.github.com/repos/Kyew/ZenGarden/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kyew/ZenGarden/downloads","issues_url":"https://api.github.com/repos/Kyew/ZenGarden/issues{/number}","pulls_url":"https://api.github.com/repos/Kyew/ZenGarden/pulls{/number}","milestones_url":"https://api.github.com/repos/Kyew/ZenGarden/milestones{/number}","notifications_url":"https://api.github.com/repos/Kyew/ZenGarden/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kyew/ZenGarden/labels{/name}","releases_url":"https://api.github.com/repos/Kyew/ZenGarden/releases{/id}","created_at":"2014-08-18T13:30:57Z","updated_at":"2014-08-18T13:37:15Z","pushed_at":"2014-11-03T17:25:58Z","git_url":"git://github.com/Kyew/ZenGarden.git","ssh_url":"git@github.com:Kyew/ZenGarden.git","clone_url":"https://github.com/Kyew/ZenGarden.git","svn_url":"https://github.com/Kyew/ZenGarden","homepage":"http://rjdj.me/","size":9480,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mhroth:master","ref":"master","sha":"f7cb126eaadf93860121b0ac1616ec9ea2371b08","user":{"login":"mhroth","id":25988,"avatar_url":"https://avatars.githubusercontent.com/u/25988?v=2","gravatar_id":"","url":"https://api.github.com/users/mhroth","html_url":"https://github.com/mhroth","followers_url":"https://api.github.com/users/mhroth/followers","following_url":"https://api.github.com/users/mhroth/following{/other_user}","gists_url":"https://api.github.com/users/mhroth/gists{/gist_id}","starred_url":"https://api.github.com/users/mhroth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhroth/subscriptions","organizations_url":"https://api.github.com/users/mhroth/orgs","repos_url":"https://api.github.com/users/mhroth/repos","events_url":"https://api.github.com/users/mhroth/events{/privacy}","received_events_url":"https://api.github.com/users/mhroth/received_events","type":"User","site_admin":false},"repo":{"id":329981,"name":"ZenGarden","full_name":"mhroth/ZenGarden","owner":{"login":"mhroth","id":25988,"avatar_url":"https://avatars.githubusercontent.com/u/25988?v=2","gravatar_id":"","url":"https://api.github.com/users/mhroth","html_url":"https://github.com/mhroth","followers_url":"https://api.github.com/users/mhroth/followers","following_url":"https://api.github.com/users/mhroth/following{/other_user}","gists_url":"https://api.github.com/users/mhroth/gists{/gist_id}","starred_url":"https://api.github.com/users/mhroth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhroth/subscriptions","organizations_url":"https://api.github.com/users/mhroth/orgs","repos_url":"https://api.github.com/users/mhroth/repos","events_url":"https://api.github.com/users/mhroth/events{/privacy}","received_events_url":"https://api.github.com/users/mhroth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mhroth/ZenGarden","description":"ZenGarden is a stand-alone library for running Pure Data patches.","fork":false,"url":"https://api.github.com/repos/mhroth/ZenGarden","forks_url":"https://api.github.com/repos/mhroth/ZenGarden/forks","keys_url":"https://api.github.com/repos/mhroth/ZenGarden/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mhroth/ZenGarden/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mhroth/ZenGarden/teams","hooks_url":"https://api.github.com/repos/mhroth/ZenGarden/hooks","issue_events_url":"https://api.github.com/repos/mhroth/ZenGarden/issues/events{/number}","events_url":"https://api.github.com/repos/mhroth/ZenGarden/events","assignees_url":"https://api.github.com/repos/mhroth/ZenGarden/assignees{/user}","branches_url":"https://api.github.com/repos/mhroth/ZenGarden/branches{/branch}","tags_url":"https://api.github.com/repos/mhroth/ZenGarden/tags","blobs_url":"https://api.github.com/repos/mhroth/ZenGarden/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mhroth/ZenGarden/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mhroth/ZenGarden/git/refs{/sha}","trees_url":"https://api.github.com/repos/mhroth/ZenGarden/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mhroth/ZenGarden/statuses/{sha}","languages_url":"https://api.github.com/repos/mhroth/ZenGarden/languages","stargazers_url":"https://api.github.com/repos/mhroth/ZenGarden/stargazers","contributors_url":"https://api.github.com/repos/mhroth/ZenGarden/contributors","subscribers_url":"https://api.github.com/repos/mhroth/ZenGarden/subscribers","subscription_url":"https://api.github.com/repos/mhroth/ZenGarden/subscription","commits_url":"https://api.github.com/repos/mhroth/ZenGarden/commits{/sha}","git_commits_url":"https://api.github.com/repos/mhroth/ZenGarden/git/commits{/sha}","comments_url":"https://api.github.com/repos/mhroth/ZenGarden/comments{/number}","issue_comment_url":"https://api.github.com/repos/mhroth/ZenGarden/issues/comments/{number}","contents_url":"https://api.github.com/repos/mhroth/ZenGarden/contents/{+path}","compare_url":"https://api.github.com/repos/mhroth/ZenGarden/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mhroth/ZenGarden/merges","archive_url":"https://api.github.com/repos/mhroth/ZenGarden/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mhroth/ZenGarden/downloads","issues_url":"https://api.github.com/repos/mhroth/ZenGarden/issues{/number}","pulls_url":"https://api.github.com/repos/mhroth/ZenGarden/pulls{/number}","milestones_url":"https://api.github.com/repos/mhroth/ZenGarden/milestones{/number}","notifications_url":"https://api.github.com/repos/mhroth/ZenGarden/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mhroth/ZenGarden/labels{/name}","releases_url":"https://api.github.com/repos/mhroth/ZenGarden/releases{/id}","created_at":"2009-10-07T17:45:26Z","updated_at":"2014-10-29T19:51:25Z","pushed_at":"2014-11-03T22:23:41Z","git_url":"git://github.com/mhroth/ZenGarden.git","ssh_url":"git@github.com:mhroth/ZenGarden.git","clone_url":"https://github.com/mhroth/ZenGarden.git","svn_url":"https://github.com/mhroth/ZenGarden","homepage":"http://rjdj.me/","size":13470,"stargazers_count":79,"watchers_count":79,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":2,"forks":10,"open_issues":2,"watchers":79,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mhroth/ZenGarden/pulls/53"},"html":{"href":"https://github.com/mhroth/ZenGarden/pull/53"},"issue":{"href":"https://api.github.com/repos/mhroth/ZenGarden/issues/53"},"comments":{"href":"https://api.github.com/repos/mhroth/ZenGarden/issues/53/comments"},"review_comments":{"href":"https://api.github.com/repos/mhroth/ZenGarden/pulls/53/comments"},"review_comment":{"href":"https://api.github.com/repos/mhroth/ZenGarden/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mhroth/ZenGarden/pulls/53/commits"},"statuses":{"href":"https://api.github.com/repos/mhroth/ZenGarden/statuses/5bca1f9b668d4bcb8afc7a3b4c6401af69f4f722"}}}}