GitHub PullRequestReviewCommentEvent at 2014-09-10 15:10:22
Repository: blaze
Actor: talumbau
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/ContinuumIO/blaze/pulls/comments/17366671","id":17366671,"diff_hunk":"@@ -401,7 +402,7 @@ def retrieve_kwarg(term):\n     #only works on OSX/Unix\n     elif dbtype == 'sqlite':\n         import subprocess\n-        if sys.platform == 'win32':\n+        if sys.platform == 'win32' or db == \":memory:\":","path":"blaze/data/sql.py","position":13,"original_position":13,"commit_id":"f2bafe2c24fbc2c5ad868316b75f18731141367a","original_commit_id":"f2bafe2c24fbc2c5ad868316b75f18731141367a","user":{"login":"talumbau","id":1891418,"avatar_url":"https://avatars.githubusercontent.com/u/1891418?v=2","gravatar_id":"c6965c047e58671e72641f7402ab6985","url":"https://api.github.com/users/talumbau","html_url":"https://github.com/talumbau","followers_url":"https://api.github.com/users/talumbau/followers","following_url":"https://api.github.com/users/talumbau/following{/other_user}","gists_url":"https://api.github.com/users/talumbau/gists{/gist_id}","starred_url":"https://api.github.com/users/talumbau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talumbau/subscriptions","organizations_url":"https://api.github.com/users/talumbau/orgs","repos_url":"https://api.github.com/users/talumbau/repos","events_url":"https://api.github.com/users/talumbau/events{/privacy}","received_events_url":"https://api.github.com/users/talumbau/received_events","type":"User","site_admin":false},"body":"Would like @quasiben to chime in here. In my testing, I found that shelling out with subprocess didn't work for in memory sqlite databases ","created_at":"2014-09-10T15:10:22Z","updated_at":"2014-09-10T15:10:22Z","html_url":"https://github.com/ContinuumIO/blaze/pull/616#discussion_r17366671","pull_request_url":"https://api.github.com/repos/ContinuumIO/blaze/pulls/616","_links":{"self":{"href":"https://api.github.com/repos/ContinuumIO/blaze/pulls/comments/17366671"},"html":{"href":"https://github.com/ContinuumIO/blaze/pull/616#discussion_r17366671"},"pull_request":{"href":"https://api.github.com/repos/ContinuumIO/blaze/pulls/616"}}},"pull_request":{"url":"https://api.github.com/repos/ContinuumIO/blaze/pulls/616","id":21026202,"html_url":"https://github.com/ContinuumIO/blaze/pull/616","diff_url":"https://github.com/ContinuumIO/blaze/pull/616.diff","patch_url":"https://github.com/ContinuumIO/blaze/pull/616.patch","issue_url":"https://api.github.com/repos/ContinuumIO/blaze/issues/616","number":616,"state":"open","locked":false,"title":"into(sql, *) with better datetime support","user":{"login":"talumbau","id":1891418,"avatar_url":"https://avatars.githubusercontent.com/u/1891418?v=2","gravatar_id":"c6965c047e58671e72641f7402ab6985","url":"https://api.github.com/users/talumbau","html_url":"https://github.com/talumbau","followers_url":"https://api.github.com/users/talumbau/followers","following_url":"https://api.github.com/users/talumbau/following{/other_user}","gists_url":"https://api.github.com/users/talumbau/gists{/gist_id}","starred_url":"https://api.github.com/users/talumbau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talumbau/subscriptions","organizations_url":"https://api.github.com/users/talumbau/orgs","repos_url":"https://api.github.com/users/talumbau/repos","events_url":"https://api.github.com/users/talumbau/events{/privacy}","received_events_url":"https://api.github.com/users/talumbau/received_events","type":"User","site_admin":false},"body":"changes and tests to support into(sql, *) where the source is\r\na pd.DataFrame, numpy array or dynd array, bcolz.ctable, or csv\r\n\r\nIf the source has a datetime with a timezone, make use of\r\nsqlalchemy DateTime with timezone support\r\n\r\nThis also helps with operations of the form into(*, sql) where\r\nthe sql table has datetimes with time zone","created_at":"2014-09-10T14:55:05Z","updated_at":"2014-09-10T15:10:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"51a29bfe00cd7db1e5f8bea6bf6813088fe02257","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ContinuumIO/blaze/pulls/616/commits","review_comments_url":"https://api.github.com/repos/ContinuumIO/blaze/pulls/616/comments","review_comment_url":"https://api.github.com/repos/ContinuumIO/blaze/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ContinuumIO/blaze/issues/616/comments","statuses_url":"https://api.github.com/repos/ContinuumIO/blaze/statuses/f2bafe2c24fbc2c5ad868316b75f18731141367a","head":{"label":"talumbau:into_sql","ref":"into_sql","sha":"f2bafe2c24fbc2c5ad868316b75f18731141367a","user":{"login":"talumbau","id":1891418,"avatar_url":"https://avatars.githubusercontent.com/u/1891418?v=2","gravatar_id":"c6965c047e58671e72641f7402ab6985","url":"https://api.github.com/users/talumbau","html_url":"https://github.com/talumbau","followers_url":"https://api.github.com/users/talumbau/followers","following_url":"https://api.github.com/users/talumbau/following{/other_user}","gists_url":"https://api.github.com/users/talumbau/gists{/gist_id}","starred_url":"https://api.github.com/users/talumbau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talumbau/subscriptions","organizations_url":"https://api.github.com/users/talumbau/orgs","repos_url":"https://api.github.com/users/talumbau/repos","events_url":"https://api.github.com/users/talumbau/events{/privacy}","received_events_url":"https://api.github.com/users/talumbau/received_events","type":"User","site_admin":false},"repo":{"id":18573923,"name":"blaze","full_name":"talumbau/blaze","owner":{"login":"talumbau","id":1891418,"avatar_url":"https://avatars.githubusercontent.com/u/1891418?v=2","gravatar_id":"c6965c047e58671e72641f7402ab6985","url":"https://api.github.com/users/talumbau","html_url":"https://github.com/talumbau","followers_url":"https://api.github.com/users/talumbau/followers","following_url":"https://api.github.com/users/talumbau/following{/other_user}","gists_url":"https://api.github.com/users/talumbau/gists{/gist_id}","starred_url":"https://api.github.com/users/talumbau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talumbau/subscriptions","organizations_url":"https://api.github.com/users/talumbau/orgs","repos_url":"https://api.github.com/users/talumbau/repos","events_url":"https://api.github.com/users/talumbau/events{/privacy}","received_events_url":"https://api.github.com/users/talumbau/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/talumbau/blaze","description":"Blaze is NumPy and Pandas for Big Data","fork":true,"url":"https://api.github.com/repos/talumbau/blaze","forks_url":"https://api.github.com/repos/talumbau/blaze/forks","keys_url":"https://api.github.com/repos/talumbau/blaze/keys{/key_id}","collaborators_url":"https://api.github.com/repos/talumbau/blaze/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/talumbau/blaze/teams","hooks_url":"https://api.github.com/repos/talumbau/blaze/hooks","issue_events_url":"https://api.github.com/repos/talumbau/blaze/issues/events{/number}","events_url":"https://api.github.com/repos/talumbau/blaze/events","assignees_url":"https://api.github.com/repos/talumbau/blaze/assignees{/user}","branches_url":"https://api.github.com/repos/talumbau/blaze/branches{/branch}","tags_url":"https://api.github.com/repos/talumbau/blaze/tags","blobs_url":"https://api.github.com/repos/talumbau/blaze/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/talumbau/blaze/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/talumbau/blaze/git/refs{/sha}","trees_url":"https://api.github.com/repos/talumbau/blaze/git/trees{/sha}","statuses_url":"https://api.github.com/repos/talumbau/blaze/statuses/{sha}","languages_url":"https://api.github.com/repos/talumbau/blaze/languages","stargazers_url":"https://api.github.com/repos/talumbau/blaze/stargazers","contributors_url":"https://api.github.com/repos/talumbau/blaze/contributors","subscribers_url":"https://api.github.com/repos/talumbau/blaze/subscribers","subscription_url":"https://api.github.com/repos/talumbau/blaze/subscription","commits_url":"https://api.github.com/repos/talumbau/blaze/commits{/sha}","git_commits_url":"https://api.github.com/repos/talumbau/blaze/git/commits{/sha}","comments_url":"https://api.github.com/repos/talumbau/blaze/comments{/number}","issue_comment_url":"https://api.github.com/repos/talumbau/blaze/issues/comments/{number}","contents_url":"https://api.github.com/repos/talumbau/blaze/contents/{+path}","compare_url":"https://api.github.com/repos/talumbau/blaze/compare/{base}...{head}","merges_url":"https://api.github.com/repos/talumbau/blaze/merges","archive_url":"https://api.github.com/repos/talumbau/blaze/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/talumbau/blaze/downloads","issues_url":"https://api.github.com/repos/talumbau/blaze/issues{/number}","pulls_url":"https://api.github.com/repos/talumbau/blaze/pulls{/number}","milestones_url":"https://api.github.com/repos/talumbau/blaze/milestones{/number}","notifications_url":"https://api.github.com/repos/talumbau/blaze/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/talumbau/blaze/labels{/name}","releases_url":"https://api.github.com/repos/talumbau/blaze/releases{/id}","created_at":"2014-04-08T20:29:15Z","updated_at":"2014-06-23T15:47:25Z","pushed_at":"2014-09-10T14:52:48Z","git_url":"git://github.com/talumbau/blaze.git","ssh_url":"git@github.com:talumbau/blaze.git","clone_url":"https://github.com/talumbau/blaze.git","svn_url":"https://github.com/talumbau/blaze","homepage":"blaze.pydata.org","size":8339,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"ContinuumIO:master","ref":"master","sha":"f22e920a5f8dc1b3dbd4cd55986f37b057f99265","user":{"login":"ContinuumIO","id":1158637,"avatar_url":"https://avatars.githubusercontent.com/u/1158637?v=2","gravatar_id":"d3e1fbcfffa00b955ee75f4e4324d6e6","url":"https://api.github.com/users/ContinuumIO","html_url":"https://github.com/ContinuumIO","followers_url":"https://api.github.com/users/ContinuumIO/followers","following_url":"https://api.github.com/users/ContinuumIO/following{/other_user}","gists_url":"https://api.github.com/users/ContinuumIO/gists{/gist_id}","starred_url":"https://api.github.com/users/ContinuumIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ContinuumIO/subscriptions","organizations_url":"https://api.github.com/users/ContinuumIO/orgs","repos_url":"https://api.github.com/users/ContinuumIO/repos","events_url":"https://api.github.com/users/ContinuumIO/events{/privacy}","received_events_url":"https://api.github.com/users/ContinuumIO/received_events","type":"Organization","site_admin":false},"repo":{"id":6404963,"name":"blaze","full_name":"ContinuumIO/blaze","owner":{"login":"ContinuumIO","id":1158637,"avatar_url":"https://avatars.githubusercontent.com/u/1158637?v=2","gravatar_id":"d3e1fbcfffa00b955ee75f4e4324d6e6","url":"https://api.github.com/users/ContinuumIO","html_url":"https://github.com/ContinuumIO","followers_url":"https://api.github.com/users/ContinuumIO/followers","following_url":"https://api.github.com/users/ContinuumIO/following{/other_user}","gists_url":"https://api.github.com/users/ContinuumIO/gists{/gist_id}","starred_url":"https://api.github.com/users/ContinuumIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ContinuumIO/subscriptions","organizations_url":"https://api.github.com/users/ContinuumIO/orgs","repos_url":"https://api.github.com/users/ContinuumIO/repos","events_url":"https://api.github.com/users/ContinuumIO/events{/privacy}","received_events_url":"https://api.github.com/users/ContinuumIO/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ContinuumIO/blaze","description":"NumPy and Pandas interface to Big Data","fork":false,"url":"https://api.github.com/repos/ContinuumIO/blaze","forks_url":"https://api.github.com/repos/ContinuumIO/blaze/forks","keys_url":"https://api.github.com/repos/ContinuumIO/blaze/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ContinuumIO/blaze/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ContinuumIO/blaze/teams","hooks_url":"https://api.github.com/repos/ContinuumIO/blaze/hooks","issue_events_url":"https://api.github.com/repos/ContinuumIO/blaze/issues/events{/number}","events_url":"https://api.github.com/repos/ContinuumIO/blaze/events","assignees_url":"https://api.github.com/repos/ContinuumIO/blaze/assignees{/user}","branches_url":"https://api.github.com/repos/ContinuumIO/blaze/branches{/branch}","tags_url":"https://api.github.com/repos/ContinuumIO/blaze/tags","blobs_url":"https://api.github.com/repos/ContinuumIO/blaze/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ContinuumIO/blaze/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ContinuumIO/blaze/git/refs{/sha}","trees_url":"https://api.github.com/repos/ContinuumIO/blaze/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ContinuumIO/blaze/statuses/{sha}","languages_url":"https://api.github.com/repos/ContinuumIO/blaze/languages","stargazers_url":"https://api.github.com/repos/ContinuumIO/blaze/stargazers","contributors_url":"https://api.github.com/repos/ContinuumIO/blaze/contributors","subscribers_url":"https://api.github.com/repos/ContinuumIO/blaze/subscribers","subscription_url":"https://api.github.com/repos/ContinuumIO/blaze/subscription","commits_url":"https://api.github.com/repos/ContinuumIO/blaze/commits{/sha}","git_commits_url":"https://api.github.com/repos/ContinuumIO/blaze/git/commits{/sha}","comments_url":"https://api.github.com/repos/ContinuumIO/blaze/comments{/number}","issue_comment_url":"https://api.github.com/repos/ContinuumIO/blaze/issues/comments/{number}","contents_url":"https://api.github.com/repos/ContinuumIO/blaze/contents/{+path}","compare_url":"https://api.github.com/repos/ContinuumIO/blaze/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ContinuumIO/blaze/merges","archive_url":"https://api.github.com/repos/ContinuumIO/blaze/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ContinuumIO/blaze/downloads","issues_url":"https://api.github.com/repos/ContinuumIO/blaze/issues{/number}","pulls_url":"https://api.github.com/repos/ContinuumIO/blaze/pulls{/number}","milestones_url":"https://api.github.com/repos/ContinuumIO/blaze/milestones{/number}","notifications_url":"https://api.github.com/repos/ContinuumIO/blaze/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ContinuumIO/blaze/labels{/name}","releases_url":"https://api.github.com/repos/ContinuumIO/blaze/releases{/id}","created_at":"2012-10-26T14:25:22Z","updated_at":"2014-09-08T10:40:31Z","pushed_at":"2014-09-10T13:59:18Z","git_url":"git://github.com/ContinuumIO/blaze.git","ssh_url":"git@github.com:ContinuumIO/blaze.git","clone_url":"https://github.com/ContinuumIO/blaze.git","svn_url":"https://github.com/ContinuumIO/blaze","homepage":"blaze.pydata.org","size":23725,"stargazers_count":827,"watchers_count":827,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":93,"mirror_url":null,"open_issues_count":96,"forks":93,"open_issues":96,"watchers":827,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ContinuumIO/blaze/pulls/616"},"html":{"href":"https://github.com/ContinuumIO/blaze/pull/616"},"issue":{"href":"https://api.github.com/repos/ContinuumIO/blaze/issues/616"},"comments":{"href":"https://api.github.com/repos/ContinuumIO/blaze/issues/616/comments"},"review_comments":{"href":"https://api.github.com/repos/ContinuumIO/blaze/pulls/616/comments"},"review_comment":{"href":"https://api.github.com/repos/ContinuumIO/blaze/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ContinuumIO/blaze/pulls/616/commits"},"statuses":{"href":"https://api.github.com/repos/ContinuumIO/blaze/statuses/f2bafe2c24fbc2c5ad868316b75f18731141367a"}}}}