GitHub PullRequestReviewCommentEvent at 2014-07-10 15:42:14
Repository: robottelo
Actor: Ichimonji10
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/omaciel/robottelo/pulls/comments/14773854","id":14773854,"diff_hunk":"@@ -190,6 +192,15 @@ def get(url, **kwargs):\n \n def post(url, data=None, **kwargs):\n     \"\"\"A wrapper for ``requests.post``.\"\"\"\n+    if kwargs.get('json', None):\n+        try:\n+            data = js.dumps(kwargs['json'])\n+            kwargs.setdefault('headers', {})\n+            kwargs['headers']['Content-Type'] = 'application/json'\n+        except:\n+            pass\n+        finally:\n+            del kwargs['json']","path":"robottelo/api/client.py","position":51,"original_position":51,"commit_id":"74383eb3d6a7e50ebeadf5c0c9fc18afe28ae190","original_commit_id":"74383eb3d6a7e50ebeadf5c0c9fc18afe28ae190","user":{"login":"Ichimonji10","id":1012989,"avatar_url":"https://avatars.githubusercontent.com/u/1012989?","gravatar_id":"0d55b0822baba206e15373fbe457bf70","url":"https://api.github.com/users/Ichimonji10","html_url":"https://github.com/Ichimonji10","followers_url":"https://api.github.com/users/Ichimonji10/followers","following_url":"https://api.github.com/users/Ichimonji10/following{/other_user}","gists_url":"https://api.github.com/users/Ichimonji10/gists{/gist_id}","starred_url":"https://api.github.com/users/Ichimonji10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ichimonji10/subscriptions","organizations_url":"https://api.github.com/users/Ichimonji10/orgs","repos_url":"https://api.github.com/users/Ichimonji10/repos","events_url":"https://api.github.com/users/Ichimonji10/events{/privacy}","received_events_url":"https://api.github.com/users/Ichimonji10/received_events","type":"User","site_admin":false},"body":"Hmm. Ok.\r\n\r\nAs far as I can tell, you're adding a new keyword argument of 'json'. Is that correct? Ach. I don't like that. I think the client in this module should mimic the [requests interface](http://docs.python-requests.org/en/latest/api/#main-interface) as exactly as possible, and that includes accepting the same sets of keyword args. I see the reasonableness in setting a default content-type of application/json, but there's got to be a better way of handling data encoding.","created_at":"2014-07-10T15:42:14Z","updated_at":"2014-07-10T15:42:14Z","html_url":"https://github.com/omaciel/robottelo/pull/966#discussion_r14773854","pull_request_url":"https://api.github.com/repos/omaciel/robottelo/pulls/966","_links":{"self":{"href":"https://api.github.com/repos/omaciel/robottelo/pulls/comments/14773854"},"html":{"href":"https://github.com/omaciel/robottelo/pull/966#discussion_r14773854"},"pull_request":{"href":"https://api.github.com/repos/omaciel/robottelo/pulls/966"}}},"pull_request":{"url":"https://api.github.com/repos/omaciel/robottelo/pulls/966","id":18215152,"html_url":"https://github.com/omaciel/robottelo/pull/966","diff_url":"https://github.com/omaciel/robottelo/pull/966.diff","patch_url":"https://github.com/omaciel/robottelo/pull/966.patch","issue_url":"https://api.github.com/repos/omaciel/robottelo/issues/966","number":966,"state":"open","title":"Fixing entities","user":{"login":"AdamSaleh","id":1478202,"avatar_url":"https://avatars.githubusercontent.com/u/1478202?","gravatar_id":"2ddbe290ad47be36548ae5b472ceaf2b","url":"https://api.github.com/users/AdamSaleh","html_url":"https://github.com/AdamSaleh","followers_url":"https://api.github.com/users/AdamSaleh/followers","following_url":"https://api.github.com/users/AdamSaleh/following{/other_user}","gists_url":"https://api.github.com/users/AdamSaleh/gists{/gist_id}","starred_url":"https://api.github.com/users/AdamSaleh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdamSaleh/subscriptions","organizations_url":"https://api.github.com/users/AdamSaleh/orgs","repos_url":"https://api.github.com/users/AdamSaleh/repos","events_url":"https://api.github.com/users/AdamSaleh/events{/privacy}","received_events_url":"https://api.github.com/users/AdamSaleh/received_events","type":"User","site_admin":false},"body":"1) thanks for verbosity hint\r\n2) asked sat6 devs, most of the names are char[255], meaning, that if using utf, that has wider characters, generated names needs to be much smaller, so changing to 100\r\n","created_at":"2014-07-10T12:02:23Z","updated_at":"2014-07-10T15:42:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"219e6ad458ae447ec8c59a7f61167c01f02e8a6a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/omaciel/robottelo/pulls/966/commits","review_comments_url":"https://api.github.com/repos/omaciel/robottelo/pulls/966/comments","review_comment_url":"https://api.github.com/repos/omaciel/robottelo/pulls/comments/{number}","comments_url":"https://api.github.com/repos/omaciel/robottelo/issues/966/comments","statuses_url":"https://api.github.com/repos/omaciel/robottelo/statuses/74383eb3d6a7e50ebeadf5c0c9fc18afe28ae190","head":{"label":"AdamSaleh:fixingents2","ref":"fixingents2","sha":"74383eb3d6a7e50ebeadf5c0c9fc18afe28ae190","user":{"login":"AdamSaleh","id":1478202,"avatar_url":"https://avatars.githubusercontent.com/u/1478202?","gravatar_id":"2ddbe290ad47be36548ae5b472ceaf2b","url":"https://api.github.com/users/AdamSaleh","html_url":"https://github.com/AdamSaleh","followers_url":"https://api.github.com/users/AdamSaleh/followers","following_url":"https://api.github.com/users/AdamSaleh/following{/other_user}","gists_url":"https://api.github.com/users/AdamSaleh/gists{/gist_id}","starred_url":"https://api.github.com/users/AdamSaleh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdamSaleh/subscriptions","organizations_url":"https://api.github.com/users/AdamSaleh/orgs","repos_url":"https://api.github.com/users/AdamSaleh/repos","events_url":"https://api.github.com/users/AdamSaleh/events{/privacy}","received_events_url":"https://api.github.com/users/AdamSaleh/received_events","type":"User","site_admin":false},"repo":{"id":15047222,"name":"robottelo","full_name":"AdamSaleh/robottelo","owner":{"login":"AdamSaleh","id":1478202,"avatar_url":"https://avatars.githubusercontent.com/u/1478202?","gravatar_id":"2ddbe290ad47be36548ae5b472ceaf2b","url":"https://api.github.com/users/AdamSaleh","html_url":"https://github.com/AdamSaleh","followers_url":"https://api.github.com/users/AdamSaleh/followers","following_url":"https://api.github.com/users/AdamSaleh/following{/other_user}","gists_url":"https://api.github.com/users/AdamSaleh/gists{/gist_id}","starred_url":"https://api.github.com/users/AdamSaleh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdamSaleh/subscriptions","organizations_url":"https://api.github.com/users/AdamSaleh/orgs","repos_url":"https://api.github.com/users/AdamSaleh/repos","events_url":"https://api.github.com/users/AdamSaleh/events{/privacy}","received_events_url":"https://api.github.com/users/AdamSaleh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AdamSaleh/robottelo","description":"An automation testing framework for the Katello project.","fork":true,"url":"https://api.github.com/repos/AdamSaleh/robottelo","forks_url":"https://api.github.com/repos/AdamSaleh/robottelo/forks","keys_url":"https://api.github.com/repos/AdamSaleh/robottelo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AdamSaleh/robottelo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AdamSaleh/robottelo/teams","hooks_url":"https://api.github.com/repos/AdamSaleh/robottelo/hooks","issue_events_url":"https://api.github.com/repos/AdamSaleh/robottelo/issues/events{/number}","events_url":"https://api.github.com/repos/AdamSaleh/robottelo/events","assignees_url":"https://api.github.com/repos/AdamSaleh/robottelo/assignees{/user}","branches_url":"https://api.github.com/repos/AdamSaleh/robottelo/branches{/branch}","tags_url":"https://api.github.com/repos/AdamSaleh/robottelo/tags","blobs_url":"https://api.github.com/repos/AdamSaleh/robottelo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AdamSaleh/robottelo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AdamSaleh/robottelo/git/refs{/sha}","trees_url":"https://api.github.com/repos/AdamSaleh/robottelo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AdamSaleh/robottelo/statuses/{sha}","languages_url":"https://api.github.com/repos/AdamSaleh/robottelo/languages","stargazers_url":"https://api.github.com/repos/AdamSaleh/robottelo/stargazers","contributors_url":"https://api.github.com/repos/AdamSaleh/robottelo/contributors","subscribers_url":"https://api.github.com/repos/AdamSaleh/robottelo/subscribers","subscription_url":"https://api.github.com/repos/AdamSaleh/robottelo/subscription","commits_url":"https://api.github.com/repos/AdamSaleh/robottelo/commits{/sha}","git_commits_url":"https://api.github.com/repos/AdamSaleh/robottelo/git/commits{/sha}","comments_url":"https://api.github.com/repos/AdamSaleh/robottelo/comments{/number}","issue_comment_url":"https://api.github.com/repos/AdamSaleh/robottelo/issues/comments/{number}","contents_url":"https://api.github.com/repos/AdamSaleh/robottelo/contents/{+path}","compare_url":"https://api.github.com/repos/AdamSaleh/robottelo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AdamSaleh/robottelo/merges","archive_url":"https://api.github.com/repos/AdamSaleh/robottelo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AdamSaleh/robottelo/downloads","issues_url":"https://api.github.com/repos/AdamSaleh/robottelo/issues{/number}","pulls_url":"https://api.github.com/repos/AdamSaleh/robottelo/pulls{/number}","milestones_url":"https://api.github.com/repos/AdamSaleh/robottelo/milestones{/number}","notifications_url":"https://api.github.com/repos/AdamSaleh/robottelo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AdamSaleh/robottelo/labels{/name}","releases_url":"https://api.github.com/repos/AdamSaleh/robottelo/releases{/id}","created_at":"2013-12-09T12:55:15Z","updated_at":"2014-05-08T12:12:24Z","pushed_at":"2014-07-10T12:00:22Z","git_url":"git://github.com/AdamSaleh/robottelo.git","ssh_url":"git@github.com:AdamSaleh/robottelo.git","clone_url":"https://github.com/AdamSaleh/robottelo.git","svn_url":"https://github.com/AdamSaleh/robottelo","homepage":null,"size":4486,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"omaciel:master","ref":"master","sha":"77e3c61b974654818c7cbab2a43de4a173212e7e","user":{"login":"omaciel","id":53362,"avatar_url":"https://avatars.githubusercontent.com/u/53362?","gravatar_id":"5be9b08cd178f87cca6de19f00a9992c","url":"https://api.github.com/users/omaciel","html_url":"https://github.com/omaciel","followers_url":"https://api.github.com/users/omaciel/followers","following_url":"https://api.github.com/users/omaciel/following{/other_user}","gists_url":"https://api.github.com/users/omaciel/gists{/gist_id}","starred_url":"https://api.github.com/users/omaciel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omaciel/subscriptions","organizations_url":"https://api.github.com/users/omaciel/orgs","repos_url":"https://api.github.com/users/omaciel/repos","events_url":"https://api.github.com/users/omaciel/events{/privacy}","received_events_url":"https://api.github.com/users/omaciel/received_events","type":"User","site_admin":false},"repo":{"id":4000279,"name":"robottelo","full_name":"omaciel/robottelo","owner":{"login":"omaciel","id":53362,"avatar_url":"https://avatars.githubusercontent.com/u/53362?","gravatar_id":"5be9b08cd178f87cca6de19f00a9992c","url":"https://api.github.com/users/omaciel","html_url":"https://github.com/omaciel","followers_url":"https://api.github.com/users/omaciel/followers","following_url":"https://api.github.com/users/omaciel/following{/other_user}","gists_url":"https://api.github.com/users/omaciel/gists{/gist_id}","starred_url":"https://api.github.com/users/omaciel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omaciel/subscriptions","organizations_url":"https://api.github.com/users/omaciel/orgs","repos_url":"https://api.github.com/users/omaciel/repos","events_url":"https://api.github.com/users/omaciel/events{/privacy}","received_events_url":"https://api.github.com/users/omaciel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/omaciel/robottelo","description":"An automation testing framework for the Katello project.","fork":false,"url":"https://api.github.com/repos/omaciel/robottelo","forks_url":"https://api.github.com/repos/omaciel/robottelo/forks","keys_url":"https://api.github.com/repos/omaciel/robottelo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/omaciel/robottelo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/omaciel/robottelo/teams","hooks_url":"https://api.github.com/repos/omaciel/robottelo/hooks","issue_events_url":"https://api.github.com/repos/omaciel/robottelo/issues/events{/number}","events_url":"https://api.github.com/repos/omaciel/robottelo/events","assignees_url":"https://api.github.com/repos/omaciel/robottelo/assignees{/user}","branches_url":"https://api.github.com/repos/omaciel/robottelo/branches{/branch}","tags_url":"https://api.github.com/repos/omaciel/robottelo/tags","blobs_url":"https://api.github.com/repos/omaciel/robottelo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/omaciel/robottelo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/omaciel/robottelo/git/refs{/sha}","trees_url":"https://api.github.com/repos/omaciel/robottelo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/omaciel/robottelo/statuses/{sha}","languages_url":"https://api.github.com/repos/omaciel/robottelo/languages","stargazers_url":"https://api.github.com/repos/omaciel/robottelo/stargazers","contributors_url":"https://api.github.com/repos/omaciel/robottelo/contributors","subscribers_url":"https://api.github.com/repos/omaciel/robottelo/subscribers","subscription_url":"https://api.github.com/repos/omaciel/robottelo/subscription","commits_url":"https://api.github.com/repos/omaciel/robottelo/commits{/sha}","git_commits_url":"https://api.github.com/repos/omaciel/robottelo/git/commits{/sha}","comments_url":"https://api.github.com/repos/omaciel/robottelo/comments{/number}","issue_comment_url":"https://api.github.com/repos/omaciel/robottelo/issues/comments/{number}","contents_url":"https://api.github.com/repos/omaciel/robottelo/contents/{+path}","compare_url":"https://api.github.com/repos/omaciel/robottelo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/omaciel/robottelo/merges","archive_url":"https://api.github.com/repos/omaciel/robottelo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/omaciel/robottelo/downloads","issues_url":"https://api.github.com/repos/omaciel/robottelo/issues{/number}","pulls_url":"https://api.github.com/repos/omaciel/robottelo/pulls{/number}","milestones_url":"https://api.github.com/repos/omaciel/robottelo/milestones{/number}","notifications_url":"https://api.github.com/repos/omaciel/robottelo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/omaciel/robottelo/labels{/name}","releases_url":"https://api.github.com/repos/omaciel/robottelo/releases{/id}","created_at":"2012-04-12T01:36:39Z","updated_at":"2014-06-27T23:03:18Z","pushed_at":"2014-07-10T13:47:38Z","git_url":"git://github.com/omaciel/robottelo.git","ssh_url":"git@github.com:omaciel/robottelo.git","clone_url":"https://github.com/omaciel/robottelo.git","svn_url":"https://github.com/omaciel/robottelo","homepage":null,"size":15385,"stargazers_count":16,"watchers_count":16,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":18,"mirror_url":null,"open_issues_count":59,"forks":18,"open_issues":59,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/omaciel/robottelo/pulls/966"},"html":{"href":"https://github.com/omaciel/robottelo/pull/966"},"issue":{"href":"https://api.github.com/repos/omaciel/robottelo/issues/966"},"comments":{"href":"https://api.github.com/repos/omaciel/robottelo/issues/966/comments"},"review_comments":{"href":"https://api.github.com/repos/omaciel/robottelo/pulls/966/comments"},"review_comment":{"href":"https://api.github.com/repos/omaciel/robottelo/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/omaciel/robottelo/pulls/966/commits"},"statuses":{"href":"https://api.github.com/repos/omaciel/robottelo/statuses/74383eb3d6a7e50ebeadf5c0c9fc18afe28ae190"}}}}