GitHub PullRequestReviewCommentEvent at 2014-04-14 15:37:35
Repository: autocomplete
Actor: bentedder
Payload: {"comment":{"url":"https://api.github.com/repos/lonelyplanet/autocomplete/pulls/comments/11590432","id":11590432,"diff_hunk":"@@ -9,8 +9,19 @@ define([ \"jquery\" ], function($) {\n       el: \"\",\n       threshold: 2,\n       fetch: this.defaultFetch,\n-      template: \"<li>Test</li>\",\n-      onItem: this.defaultOnItem\n+      template: {\n+        resultsContainer: \"<ul>{{items}}</ul>\",\n+        resultsItem: \"<li>Test</li>\"\n+      },","path":"dist/autocomplete.js","position":9,"original_position":9,"commit_id":"96f5479dd3b48b323a0fa757f87ed96ff87e5903","original_commit_id":"96f5479dd3b48b323a0fa757f87ed96ff87e5903","user":{"login":"bentedder","id":1597375,"avatar_url":"https://avatars.githubusercontent.com/u/1597375?","gravatar_id":"a4de3f11def29cbd66ddfd711e65aa1a","url":"https://api.github.com/users/bentedder","html_url":"https://github.com/bentedder","followers_url":"https://api.github.com/users/bentedder/followers","following_url":"https://api.github.com/users/bentedder/following{/other_user}","gists_url":"https://api.github.com/users/bentedder/gists{/gist_id}","starred_url":"https://api.github.com/users/bentedder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bentedder/subscriptions","organizations_url":"https://api.github.com/users/bentedder/orgs","repos_url":"https://api.github.com/users/bentedder/repos","events_url":"https://api.github.com/users/bentedder/events{/privacy}","received_events_url":"https://api.github.com/users/bentedder/received_events","type":"User","site_admin":false},"body":"I like that we can allow the user to say what kind of html elements they use. But couldn't we just have them write \"resultsContainerType\": \"ul\" or something? as opposed to needing them to remember to put in {{items}}? Maybe I'm just not following how {{items}} is used. Just curious.","created_at":"2014-04-14T15:37:35Z","updated_at":"2014-04-14T15:37:35Z","html_url":"https://github.com/lonelyplanet/autocomplete/pull/1#discussion_r11590432","pull_request_url":"https://api.github.com/repos/lonelyplanet/autocomplete/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/lonelyplanet/autocomplete/pulls/comments/11590432"},"html":{"href":"https://github.com/lonelyplanet/autocomplete/pull/1#discussion_r11590432"},"pull_request":{"href":"https://api.github.com/repos/lonelyplanet/autocomplete/pulls/1"}}}}