GitHub PullRequestReviewCommentEvent at 2014-11-14 17:05:55
Repository: WikidataBrowserTests
Actor: zeljkofilipin
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/wmde/WikidataBrowserTests/pulls/comments/20371487","id":20371487,"diff_hunk":"@@ -0,0 +1,54 @@\n+# -*- encoding : utf-8 -*-\n+# Wikidata UI tests\n+#\n+# Author:: Tobias Gritschacher (tobias.gritschacher@wikimedia.de)\n+# License:: GNU GPL v2+\n+#\n+# step implementations for rank selector\n+\n+When(/^I click the rank selector of claim (\\d+) in group (\\d+)$/) do |claim_index, group_index|\n+  on(ItemPage).rank_selector(group_index, claim_index).click\n+end\n+\n+When(/^I select (.+) rank for claim (\\d+) in group (\\d+)$/) do |rank, claim_index, group_index|\n+  on(ItemPage).select_rank(group_index, claim_index, rank)\n+end\n+\n+Then(/^Rank selector for claim (\\d+) in group (\\d+) should not be there$/) do |claim_index, group_index|\n+  on(ItemPage) do |page|\n+    expect(page.rank_selector(group_index, claim_index).present?).to be false\n+    expect(page.rank_selector_disabled(group_index, claim_index).present?).to be false\n+  end\n+end\n+\n+Then(/^Rank selector for claim (\\d+) in group (\\d+) should be there$/) do |claim_index, group_index|\n+  on(ItemPage) do |page|\n+    expect(page.rank_selector(group_index, claim_index).present?).to be true\n+  end\n+end\n+\n+Then(/^Rank selector for claim (\\d+) in group (\\d+) should be disabled/) do |claim_index, group_index|\n+  on(ItemPage) do |page|\n+    expect(page.rank_selector_disabled(group_index, claim_index).present?).to be true\n+  end\n+end\n+\n+Then(/^Rank selector menu should be visible$/) do\n+  expect(on(ItemPage).rank_selector_menu_element.visible?).to be true\n+end\n+\n+Then(/^Rank selector menu should not be visible$/) do\n+  expect(on(ItemPage).rank_selector_menu_element.visible?).to be false","path":"tests/browser/features/step_definitions/rank_selector_steps.rb","position":41,"original_position":41,"commit_id":"2e64aeccdf673ee9a940bf366b65c4fb5e4ad9a5","original_commit_id":"2e64aeccdf673ee9a940bf366b65c4fb5e4ad9a5","user":{"login":"zeljkofilipin","id":23927,"avatar_url":"https://avatars.githubusercontent.com/u/23927?v=3","gravatar_id":"","url":"https://api.github.com/users/zeljkofilipin","html_url":"https://github.com/zeljkofilipin","followers_url":"https://api.github.com/users/zeljkofilipin/followers","following_url":"https://api.github.com/users/zeljkofilipin/following{/other_user}","gists_url":"https://api.github.com/users/zeljkofilipin/gists{/gist_id}","starred_url":"https://api.github.com/users/zeljkofilipin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeljkofilipin/subscriptions","organizations_url":"https://api.github.com/users/zeljkofilipin/orgs","repos_url":"https://api.github.com/users/zeljkofilipin/repos","events_url":"https://api.github.com/users/zeljkofilipin/events{/privacy}","received_events_url":"https://api.github.com/users/zeljkofilipin/received_events","type":"User","site_admin":false},"body":"See the comment with https://github.com/rspec/rspec-expectations#predicate-matchers","created_at":"2014-11-14T17:05:55Z","updated_at":"2014-11-14T17:05:55Z","html_url":"https://github.com/wmde/WikidataBrowserTests/pull/28#discussion_r20371487","pull_request_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/pulls/28","_links":{"self":{"href":"https://api.github.com/repos/wmde/WikidataBrowserTests/pulls/comments/20371487"},"html":{"href":"https://github.com/wmde/WikidataBrowserTests/pull/28#discussion_r20371487"},"pull_request":{"href":"https://api.github.com/repos/wmde/WikidataBrowserTests/pulls/28"}}},"pull_request":{"url":"https://api.github.com/repos/wmde/WikidataBrowserTests/pulls/28","id":24443605,"html_url":"https://github.com/wmde/WikidataBrowserTests/pull/28","diff_url":"https://github.com/wmde/WikidataBrowserTests/pull/28.diff","patch_url":"https://github.com/wmde/WikidataBrowserTests/pull/28.patch","issue_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/issues/28","number":28,"state":"open","locked":false,"title":"Add browsertests for statement ranks","user":{"login":"tobijat","id":2997252,"avatar_url":"https://avatars.githubusercontent.com/u/2997252?v=3","gravatar_id":"","url":"https://api.github.com/users/tobijat","html_url":"https://github.com/tobijat","followers_url":"https://api.github.com/users/tobijat/followers","following_url":"https://api.github.com/users/tobijat/following{/other_user}","gists_url":"https://api.github.com/users/tobijat/gists{/gist_id}","starred_url":"https://api.github.com/users/tobijat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobijat/subscriptions","organizations_url":"https://api.github.com/users/tobijat/orgs","repos_url":"https://api.github.com/users/tobijat/repos","events_url":"https://api.github.com/users/tobijat/events{/privacy}","received_events_url":"https://api.github.com/users/tobijat/received_events","type":"User","site_admin":false},"body":"Bug 67363","created_at":"2014-11-14T14:14:33Z","updated_at":"2014-11-14T17:05:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c33366fac1ae9c423b42bbff73bab9d86f7a75e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/pulls/28/commits","review_comments_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/pulls/28/comments","review_comment_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/pulls/comments/{number}","comments_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/issues/28/comments","statuses_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/statuses/2e64aeccdf673ee9a940bf366b65c4fb5e4ad9a5","head":{"label":"wmde:rank_tests","ref":"rank_tests","sha":"2e64aeccdf673ee9a940bf366b65c4fb5e4ad9a5","user":{"login":"wmde","id":664724,"avatar_url":"https://avatars.githubusercontent.com/u/664724?v=3","gravatar_id":"","url":"https://api.github.com/users/wmde","html_url":"https://github.com/wmde","followers_url":"https://api.github.com/users/wmde/followers","following_url":"https://api.github.com/users/wmde/following{/other_user}","gists_url":"https://api.github.com/users/wmde/gists{/gist_id}","starred_url":"https://api.github.com/users/wmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmde/subscriptions","organizations_url":"https://api.github.com/users/wmde/orgs","repos_url":"https://api.github.com/users/wmde/repos","events_url":"https://api.github.com/users/wmde/events{/privacy}","received_events_url":"https://api.github.com/users/wmde/received_events","type":"Organization","site_admin":false},"repo":{"id":20719449,"name":"WikidataBrowserTests","full_name":"wmde/WikidataBrowserTests","owner":{"login":"wmde","id":664724,"avatar_url":"https://avatars.githubusercontent.com/u/664724?v=3","gravatar_id":"","url":"https://api.github.com/users/wmde","html_url":"https://github.com/wmde","followers_url":"https://api.github.com/users/wmde/followers","following_url":"https://api.github.com/users/wmde/following{/other_user}","gists_url":"https://api.github.com/users/wmde/gists{/gist_id}","starred_url":"https://api.github.com/users/wmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmde/subscriptions","organizations_url":"https://api.github.com/users/wmde/orgs","repos_url":"https://api.github.com/users/wmde/repos","events_url":"https://api.github.com/users/wmde/events{/privacy}","received_events_url":"https://api.github.com/users/wmde/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wmde/WikidataBrowserTests","description":"Browser tests for the Wikibase setup on Wikidata.","fork":false,"url":"https://api.github.com/repos/wmde/WikidataBrowserTests","forks_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/forks","keys_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/teams","hooks_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/hooks","issue_events_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/issues/events{/number}","events_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/events","assignees_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/assignees{/user}","branches_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/branches{/branch}","tags_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/tags","blobs_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/git/refs{/sha}","trees_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/statuses/{sha}","languages_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/languages","stargazers_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/stargazers","contributors_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/contributors","subscribers_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/subscribers","subscription_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/subscription","commits_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/commits{/sha}","git_commits_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/git/commits{/sha}","comments_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/comments{/number}","issue_comment_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/issues/comments/{number}","contents_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/contents/{+path}","compare_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/merges","archive_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/downloads","issues_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/issues{/number}","pulls_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/pulls{/number}","milestones_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/milestones{/number}","notifications_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/labels{/name}","releases_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/releases{/id}","created_at":"2014-06-11T09:20:19Z","updated_at":"2014-09-12T11:02:15Z","pushed_at":"2014-11-14T16:53:00Z","git_url":"git://github.com/wmde/WikidataBrowserTests.git","ssh_url":"git@github.com:wmde/WikidataBrowserTests.git","clone_url":"https://github.com/wmde/WikidataBrowserTests.git","svn_url":"https://github.com/wmde/WikidataBrowserTests","homepage":"https://www.wikidata.org","size":1378,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"wmde:master","ref":"master","sha":"7cc285844fba189c38fe27882fddeb3138f133df","user":{"login":"wmde","id":664724,"avatar_url":"https://avatars.githubusercontent.com/u/664724?v=3","gravatar_id":"","url":"https://api.github.com/users/wmde","html_url":"https://github.com/wmde","followers_url":"https://api.github.com/users/wmde/followers","following_url":"https://api.github.com/users/wmde/following{/other_user}","gists_url":"https://api.github.com/users/wmde/gists{/gist_id}","starred_url":"https://api.github.com/users/wmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmde/subscriptions","organizations_url":"https://api.github.com/users/wmde/orgs","repos_url":"https://api.github.com/users/wmde/repos","events_url":"https://api.github.com/users/wmde/events{/privacy}","received_events_url":"https://api.github.com/users/wmde/received_events","type":"Organization","site_admin":false},"repo":{"id":20719449,"name":"WikidataBrowserTests","full_name":"wmde/WikidataBrowserTests","owner":{"login":"wmde","id":664724,"avatar_url":"https://avatars.githubusercontent.com/u/664724?v=3","gravatar_id":"","url":"https://api.github.com/users/wmde","html_url":"https://github.com/wmde","followers_url":"https://api.github.com/users/wmde/followers","following_url":"https://api.github.com/users/wmde/following{/other_user}","gists_url":"https://api.github.com/users/wmde/gists{/gist_id}","starred_url":"https://api.github.com/users/wmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmde/subscriptions","organizations_url":"https://api.github.com/users/wmde/orgs","repos_url":"https://api.github.com/users/wmde/repos","events_url":"https://api.github.com/users/wmde/events{/privacy}","received_events_url":"https://api.github.com/users/wmde/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wmde/WikidataBrowserTests","description":"Browser tests for the Wikibase setup on Wikidata.","fork":false,"url":"https://api.github.com/repos/wmde/WikidataBrowserTests","forks_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/forks","keys_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/teams","hooks_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/hooks","issue_events_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/issues/events{/number}","events_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/events","assignees_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/assignees{/user}","branches_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/branches{/branch}","tags_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/tags","blobs_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/git/refs{/sha}","trees_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/statuses/{sha}","languages_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/languages","stargazers_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/stargazers","contributors_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/contributors","subscribers_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/subscribers","subscription_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/subscription","commits_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/commits{/sha}","git_commits_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/git/commits{/sha}","comments_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/comments{/number}","issue_comment_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/issues/comments/{number}","contents_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/contents/{+path}","compare_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/merges","archive_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/downloads","issues_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/issues{/number}","pulls_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/pulls{/number}","milestones_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/milestones{/number}","notifications_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/labels{/name}","releases_url":"https://api.github.com/repos/wmde/WikidataBrowserTests/releases{/id}","created_at":"2014-06-11T09:20:19Z","updated_at":"2014-09-12T11:02:15Z","pushed_at":"2014-11-14T16:53:00Z","git_url":"git://github.com/wmde/WikidataBrowserTests.git","ssh_url":"git@github.com:wmde/WikidataBrowserTests.git","clone_url":"https://github.com/wmde/WikidataBrowserTests.git","svn_url":"https://github.com/wmde/WikidataBrowserTests","homepage":"https://www.wikidata.org","size":1378,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wmde/WikidataBrowserTests/pulls/28"},"html":{"href":"https://github.com/wmde/WikidataBrowserTests/pull/28"},"issue":{"href":"https://api.github.com/repos/wmde/WikidataBrowserTests/issues/28"},"comments":{"href":"https://api.github.com/repos/wmde/WikidataBrowserTests/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/wmde/WikidataBrowserTests/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/wmde/WikidataBrowserTests/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/wmde/WikidataBrowserTests/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/wmde/WikidataBrowserTests/statuses/2e64aeccdf673ee9a940bf366b65c4fb5e4ad9a5"}}}}