GitHub PullRequestReviewCommentEvent at 2014-08-26 12:46:53
Repository: tachyon
Actor: rootfs
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/amplab/tachyon/pulls/comments/16710677","id":16710677,"diff_hunk":"@@ -51,22 +52,31 @@ private UnderFileSystemHdfs(String fsDefaultName, Object conf) {\n     } else {\n       tConf = new Configuration();\n     }\n-    tConf.set(\"fs.defaultFS\", fsDefaultName);\n-    String glusterfsPrefix = \"glusterfs:///\";\n-    if (fsDefaultName.startsWith(glusterfsPrefix)) {\n-      tConf.set(\"fs.glusterfs.impl\", CommonConf.get().UNDERFS_GLUSTERFS_IMPL);\n-      tConf.set(\"mapred.system.dir\", CommonConf.get().UNDERFS_GLUSTERFS_MR_DIR);\n-      tConf.set(\"fs.glusterfs.volumes\", CommonConf.get().UNDERFS_GLUSTERFS_VOLUMES);\n-      tConf.set(\"fs.glusterfs.volume.fuse.\" + CommonConf.get().UNDERFS_GLUSTERFS_VOLUMES,\n-          CommonConf.get().UNDERFS_GLUSTERFS_MOUNTS);\n-    } else {\n-      tConf.set(\"fs.hdfs.impl\", CommonConf.get().UNDERFS_HDFS_IMPL);\n \n-      // To disable the instance cache for hdfs client, otherwise it causes the\n-      // FileSystem closed exception. Being configurable for unit/integration\n-      // test only, and not expose to the end-user currently.\n-      tConf.set(\"fs.hdfs.impl.disable.cache\",\n-          System.getProperty(\"fs.hdfs.impl.disable.cache\", \"false\"));\n+    // Setting Hadoop compatible filesystem (HCFS) properties in command argument is not scalable\n+    // for some HCFS e.g. ceph, that has numerous parameters.\n+    // Providing a hadoop core-site.xml that is required for this type of underfs.\n+    InputStream config = UnderFileSystemHdfs.class.getClassLoader().getResourceAsStream(\"core-site.xml\");","path":"core/src/main/java/tachyon/UnderFileSystemHdfs.java","position":31,"original_position":31,"commit_id":"de44ef0736f764b4de8f2eed66467943d7df0e6c","original_commit_id":"de44ef0736f764b4de8f2eed66467943d7df0e6c","user":{"login":"rootfs","id":7062400,"avatar_url":"https://avatars.githubusercontent.com/u/7062400?v=2","gravatar_id":"69e28607756a391ace4eb63296b4e3e2","url":"https://api.github.com/users/rootfs","html_url":"https://github.com/rootfs","followers_url":"https://api.github.com/users/rootfs/followers","following_url":"https://api.github.com/users/rootfs/following{/other_user}","gists_url":"https://api.github.com/users/rootfs/gists{/gist_id}","starred_url":"https://api.github.com/users/rootfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rootfs/subscriptions","organizations_url":"https://api.github.com/users/rootfs/orgs","repos_url":"https://api.github.com/users/rootfs/repos","events_url":"https://api.github.com/users/rootfs/events{/privacy}","received_events_url":"https://api.github.com/users/rootfs/received_events","type":"User","site_admin":false},"body":"@dcapwell agree with you. But under the hood, hadoop has to be told through its env to construct the classpath. Since we are not relying on hadoop's env to start tachyon, our classpath is different.","created_at":"2014-08-26T12:46:53Z","updated_at":"2014-08-26T12:46:53Z","html_url":"https://github.com/amplab/tachyon/pull/388#discussion_r16710677","pull_request_url":"https://api.github.com/repos/amplab/tachyon/pulls/388","_links":{"self":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/comments/16710677"},"html":{"href":"https://github.com/amplab/tachyon/pull/388#discussion_r16710677"},"pull_request":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/388"}}},"pull_request":{"url":"https://api.github.com/repos/amplab/tachyon/pulls/388","id":20250145,"html_url":"https://github.com/amplab/tachyon/pull/388","diff_url":"https://github.com/amplab/tachyon/pull/388.diff","patch_url":"https://github.com/amplab/tachyon/pull/388.patch","issue_url":"https://api.github.com/repos/amplab/tachyon/issues/388","number":388,"state":"open","locked":false,"title":"Support generic Hadoop Compatible Filesystem","user":{"login":"rootfs","id":7062400,"avatar_url":"https://avatars.githubusercontent.com/u/7062400?v=2","gravatar_id":"69e28607756a391ace4eb63296b4e3e2","url":"https://api.github.com/users/rootfs","html_url":"https://github.com/rootfs","followers_url":"https://api.github.com/users/rootfs/followers","following_url":"https://api.github.com/users/rootfs/following{/other_user}","gists_url":"https://api.github.com/users/rootfs/gists{/gist_id}","starred_url":"https://api.github.com/users/rootfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rootfs/subscriptions","organizations_url":"https://api.github.com/users/rootfs/orgs","repos_url":"https://api.github.com/users/rootfs/repos","events_url":"https://api.github.com/users/rootfs/events{/privacy}","received_events_url":"https://api.github.com/users/rootfs/received_events","type":"User","site_admin":false},"body":"This is a shortened version of PR #358, with focus on filesystem only.","created_at":"2014-08-25T14:47:13Z","updated_at":"2014-08-26T12:46:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"14a8378342ca9db82387a6710c81b5367f55bc0a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/amplab/tachyon/pulls/388/commits","review_comments_url":"https://api.github.com/repos/amplab/tachyon/pulls/388/comments","review_comment_url":"https://api.github.com/repos/amplab/tachyon/pulls/comments/{number}","comments_url":"https://api.github.com/repos/amplab/tachyon/issues/388/comments","statuses_url":"https://api.github.com/repos/amplab/tachyon/statuses/de44ef0736f764b4de8f2eed66467943d7df0e6c","head":{"label":"rootfs:wip-hcfs","ref":"wip-hcfs","sha":"de44ef0736f764b4de8f2eed66467943d7df0e6c","user":{"login":"rootfs","id":7062400,"avatar_url":"https://avatars.githubusercontent.com/u/7062400?v=2","gravatar_id":"69e28607756a391ace4eb63296b4e3e2","url":"https://api.github.com/users/rootfs","html_url":"https://github.com/rootfs","followers_url":"https://api.github.com/users/rootfs/followers","following_url":"https://api.github.com/users/rootfs/following{/other_user}","gists_url":"https://api.github.com/users/rootfs/gists{/gist_id}","starred_url":"https://api.github.com/users/rootfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rootfs/subscriptions","organizations_url":"https://api.github.com/users/rootfs/orgs","repos_url":"https://api.github.com/users/rootfs/repos","events_url":"https://api.github.com/users/rootfs/events{/privacy}","received_events_url":"https://api.github.com/users/rootfs/received_events","type":"User","site_admin":false},"repo":{"id":18760988,"name":"tachyon","full_name":"rootfs/tachyon","owner":{"login":"rootfs","id":7062400,"avatar_url":"https://avatars.githubusercontent.com/u/7062400?v=2","gravatar_id":"69e28607756a391ace4eb63296b4e3e2","url":"https://api.github.com/users/rootfs","html_url":"https://github.com/rootfs","followers_url":"https://api.github.com/users/rootfs/followers","following_url":"https://api.github.com/users/rootfs/following{/other_user}","gists_url":"https://api.github.com/users/rootfs/gists{/gist_id}","starred_url":"https://api.github.com/users/rootfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rootfs/subscriptions","organizations_url":"https://api.github.com/users/rootfs/orgs","repos_url":"https://api.github.com/users/rootfs/repos","events_url":"https://api.github.com/users/rootfs/events{/privacy}","received_events_url":"https://api.github.com/users/rootfs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rootfs/tachyon","description":"Reliable File Sharing at Memory Speed Across Cluster Frameworks","fork":true,"url":"https://api.github.com/repos/rootfs/tachyon","forks_url":"https://api.github.com/repos/rootfs/tachyon/forks","keys_url":"https://api.github.com/repos/rootfs/tachyon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rootfs/tachyon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rootfs/tachyon/teams","hooks_url":"https://api.github.com/repos/rootfs/tachyon/hooks","issue_events_url":"https://api.github.com/repos/rootfs/tachyon/issues/events{/number}","events_url":"https://api.github.com/repos/rootfs/tachyon/events","assignees_url":"https://api.github.com/repos/rootfs/tachyon/assignees{/user}","branches_url":"https://api.github.com/repos/rootfs/tachyon/branches{/branch}","tags_url":"https://api.github.com/repos/rootfs/tachyon/tags","blobs_url":"https://api.github.com/repos/rootfs/tachyon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rootfs/tachyon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rootfs/tachyon/git/refs{/sha}","trees_url":"https://api.github.com/repos/rootfs/tachyon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rootfs/tachyon/statuses/{sha}","languages_url":"https://api.github.com/repos/rootfs/tachyon/languages","stargazers_url":"https://api.github.com/repos/rootfs/tachyon/stargazers","contributors_url":"https://api.github.com/repos/rootfs/tachyon/contributors","subscribers_url":"https://api.github.com/repos/rootfs/tachyon/subscribers","subscription_url":"https://api.github.com/repos/rootfs/tachyon/subscription","commits_url":"https://api.github.com/repos/rootfs/tachyon/commits{/sha}","git_commits_url":"https://api.github.com/repos/rootfs/tachyon/git/commits{/sha}","comments_url":"https://api.github.com/repos/rootfs/tachyon/comments{/number}","issue_comment_url":"https://api.github.com/repos/rootfs/tachyon/issues/comments/{number}","contents_url":"https://api.github.com/repos/rootfs/tachyon/contents/{+path}","compare_url":"https://api.github.com/repos/rootfs/tachyon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rootfs/tachyon/merges","archive_url":"https://api.github.com/repos/rootfs/tachyon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rootfs/tachyon/downloads","issues_url":"https://api.github.com/repos/rootfs/tachyon/issues{/number}","pulls_url":"https://api.github.com/repos/rootfs/tachyon/pulls{/number}","milestones_url":"https://api.github.com/repos/rootfs/tachyon/milestones{/number}","notifications_url":"https://api.github.com/repos/rootfs/tachyon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rootfs/tachyon/labels{/name}","releases_url":"https://api.github.com/repos/rootfs/tachyon/releases{/id}","created_at":"2014-04-14T13:11:58Z","updated_at":"2014-07-23T14:29:36Z","pushed_at":"2014-08-25T19:45:29Z","git_url":"git://github.com/rootfs/tachyon.git","ssh_url":"git@github.com:rootfs/tachyon.git","clone_url":"https://github.com/rootfs/tachyon.git","svn_url":"https://github.com/rootfs/tachyon","homepage":"http://tachyon-project.org","size":7912,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"amplab:master","ref":"master","sha":"b4cbe17fa85c09dd711e1a1e099acd7ab0bd43f1","user":{"login":"amplab","id":1438454,"avatar_url":"https://avatars.githubusercontent.com/u/1438454?v=2","gravatar_id":"c0783723b006eb46526c04fa47ba2cd7","url":"https://api.github.com/users/amplab","html_url":"https://github.com/amplab","followers_url":"https://api.github.com/users/amplab/followers","following_url":"https://api.github.com/users/amplab/following{/other_user}","gists_url":"https://api.github.com/users/amplab/gists{/gist_id}","starred_url":"https://api.github.com/users/amplab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amplab/subscriptions","organizations_url":"https://api.github.com/users/amplab/orgs","repos_url":"https://api.github.com/users/amplab/repos","events_url":"https://api.github.com/users/amplab/events{/privacy}","received_events_url":"https://api.github.com/users/amplab/received_events","type":"Organization","site_admin":false},"repo":{"id":7276954,"name":"tachyon","full_name":"amplab/tachyon","owner":{"login":"amplab","id":1438454,"avatar_url":"https://avatars.githubusercontent.com/u/1438454?v=2","gravatar_id":"c0783723b006eb46526c04fa47ba2cd7","url":"https://api.github.com/users/amplab","html_url":"https://github.com/amplab","followers_url":"https://api.github.com/users/amplab/followers","following_url":"https://api.github.com/users/amplab/following{/other_user}","gists_url":"https://api.github.com/users/amplab/gists{/gist_id}","starred_url":"https://api.github.com/users/amplab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amplab/subscriptions","organizations_url":"https://api.github.com/users/amplab/orgs","repos_url":"https://api.github.com/users/amplab/repos","events_url":"https://api.github.com/users/amplab/events{/privacy}","received_events_url":"https://api.github.com/users/amplab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/amplab/tachyon","description":" A Reliable Memory Centric Distributed Storage System","fork":false,"url":"https://api.github.com/repos/amplab/tachyon","forks_url":"https://api.github.com/repos/amplab/tachyon/forks","keys_url":"https://api.github.com/repos/amplab/tachyon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amplab/tachyon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amplab/tachyon/teams","hooks_url":"https://api.github.com/repos/amplab/tachyon/hooks","issue_events_url":"https://api.github.com/repos/amplab/tachyon/issues/events{/number}","events_url":"https://api.github.com/repos/amplab/tachyon/events","assignees_url":"https://api.github.com/repos/amplab/tachyon/assignees{/user}","branches_url":"https://api.github.com/repos/amplab/tachyon/branches{/branch}","tags_url":"https://api.github.com/repos/amplab/tachyon/tags","blobs_url":"https://api.github.com/repos/amplab/tachyon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amplab/tachyon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amplab/tachyon/git/refs{/sha}","trees_url":"https://api.github.com/repos/amplab/tachyon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amplab/tachyon/statuses/{sha}","languages_url":"https://api.github.com/repos/amplab/tachyon/languages","stargazers_url":"https://api.github.com/repos/amplab/tachyon/stargazers","contributors_url":"https://api.github.com/repos/amplab/tachyon/contributors","subscribers_url":"https://api.github.com/repos/amplab/tachyon/subscribers","subscription_url":"https://api.github.com/repos/amplab/tachyon/subscription","commits_url":"https://api.github.com/repos/amplab/tachyon/commits{/sha}","git_commits_url":"https://api.github.com/repos/amplab/tachyon/git/commits{/sha}","comments_url":"https://api.github.com/repos/amplab/tachyon/comments{/number}","issue_comment_url":"https://api.github.com/repos/amplab/tachyon/issues/comments/{number}","contents_url":"https://api.github.com/repos/amplab/tachyon/contents/{+path}","compare_url":"https://api.github.com/repos/amplab/tachyon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amplab/tachyon/merges","archive_url":"https://api.github.com/repos/amplab/tachyon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amplab/tachyon/downloads","issues_url":"https://api.github.com/repos/amplab/tachyon/issues{/number}","pulls_url":"https://api.github.com/repos/amplab/tachyon/pulls{/number}","milestones_url":"https://api.github.com/repos/amplab/tachyon/milestones{/number}","notifications_url":"https://api.github.com/repos/amplab/tachyon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amplab/tachyon/labels{/name}","releases_url":"https://api.github.com/repos/amplab/tachyon/releases{/id}","created_at":"2012-12-21T17:43:46Z","updated_at":"2014-08-26T00:59:15Z","pushed_at":"2014-08-25T01:16:26Z","git_url":"git://github.com/amplab/tachyon.git","ssh_url":"git@github.com:amplab/tachyon.git","clone_url":"https://github.com/amplab/tachyon.git","svn_url":"https://github.com/amplab/tachyon","homepage":"http://tachyon-project.org","size":28187,"stargazers_count":907,"watchers_count":907,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":251,"mirror_url":null,"open_issues_count":24,"forks":251,"open_issues":24,"watchers":907,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/388"},"html":{"href":"https://github.com/amplab/tachyon/pull/388"},"issue":{"href":"https://api.github.com/repos/amplab/tachyon/issues/388"},"comments":{"href":"https://api.github.com/repos/amplab/tachyon/issues/388/comments"},"review_comments":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/388/comments"},"review_comment":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/388/commits"},"statuses":{"href":"https://api.github.com/repos/amplab/tachyon/statuses/de44ef0736f764b4de8f2eed66467943d7df0e6c"}}}}