GitHub PullRequestReviewCommentEvent at 2014-09-22 00:40:41
Repository: dealii
Actor: bangerth
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/dealii/dealii/pulls/comments/17829583","id":17829583,"diff_hunk":"@@ -0,0 +1,71 @@\n+\n+//----------------------------  iges_read.cc  ---------------------------\n+//    $Id: testsuite.html 13373 2006-07-13 13:12:08Z kanschat $\n+//    Version: $Name$ \n+//\n+//    Copyright (C) 2005 by the deal.II authors \n+//\n+//    This file is subject to QPL and may not be  distributed\n+//    without copyright and license information. Please refer\n+//    to the file deal.II/doc/license.html for the  text  and\n+//    further information on this license.\n+//\n+//----------------------------  iges_read.cc  ---------------------------\n+\n+\n+// Read goteborg.iges and dump its topological structure to the logfile.\n+\n+#include \"../tests.h\"\n+#include <fstream>\n+#include <base/logstream.h>\n+\n+#include <deal.II/grid/occ_utilities.h>\n+#include <deal.II/grid/occ_boundary_lib.h>\n+#include <deal.II/grid/tria.h>\n+#include <deal.II/grid/grid_out.h>\n+#include <deal.II/grid/grid_generator.h>\n+\n+#include <TopTools.hxx>\n+#include <TopoDS_Shape.hxx>\n+#include <TopoDS_Edge.hxx>\n+#include <TopoDS_Face.hxx>\n+#include <BRepFill.hxx>\n+#include <Standard_Stream.hxx>\n+\n+using namespace OpenCASCADE;\n+\n+int main () \n+{\n+  std::ofstream logfile(\"output\");\n+  // deallog.attach(logfile);\n+  // deallog.depth_console(0);","path":"tests/opencascade/axis_boundary_01.cc","position":41,"original_position":41,"commit_id":"10b820eed00c0a7033c7514901e74b77b037f315","original_commit_id":"10b820eed00c0a7033c7514901e74b77b037f315","user":{"login":"bangerth","id":7504421,"avatar_url":"https://avatars.githubusercontent.com/u/7504421?v=2","gravatar_id":"bb0cb3b804901b1b3cb33cc459dd5cab","url":"https://api.github.com/users/bangerth","html_url":"https://github.com/bangerth","followers_url":"https://api.github.com/users/bangerth/followers","following_url":"https://api.github.com/users/bangerth/following{/other_user}","gists_url":"https://api.github.com/users/bangerth/gists{/gist_id}","starred_url":"https://api.github.com/users/bangerth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bangerth/subscriptions","organizations_url":"https://api.github.com/users/bangerth/orgs","repos_url":"https://api.github.com/users/bangerth/repos","events_url":"https://api.github.com/users/bangerth/events{/privacy}","received_events_url":"https://api.github.com/users/bangerth/received_events","type":"User","site_admin":false},"body":"same as before","created_at":"2014-09-22T00:40:41Z","updated_at":"2014-09-22T00:40:41Z","html_url":"https://github.com/dealii/dealii/pull/166#discussion_r17829583","pull_request_url":"https://api.github.com/repos/dealii/dealii/pulls/166","_links":{"self":{"href":"https://api.github.com/repos/dealii/dealii/pulls/comments/17829583"},"html":{"href":"https://github.com/dealii/dealii/pull/166#discussion_r17829583"},"pull_request":{"href":"https://api.github.com/repos/dealii/dealii/pulls/166"}}},"pull_request":{"url":"https://api.github.com/repos/dealii/dealii/pulls/166","id":21539948,"html_url":"https://github.com/dealii/dealii/pull/166","diff_url":"https://github.com/dealii/dealii/pull/166.diff","patch_url":"https://github.com/dealii/dealii/pull/166.patch","issue_url":"https://api.github.com/repos/dealii/dealii/issues/166","number":166,"state":"open","locked":false,"title":"Added support for OpenCASCADE (IGES boundary descriptors)","user":{"login":"luca-heltai","id":2919756,"avatar_url":"https://avatars.githubusercontent.com/u/2919756?v=2","gravatar_id":"7ba1a565ebca22a6d4142817145538e2","url":"https://api.github.com/users/luca-heltai","html_url":"https://github.com/luca-heltai","followers_url":"https://api.github.com/users/luca-heltai/followers","following_url":"https://api.github.com/users/luca-heltai/following{/other_user}","gists_url":"https://api.github.com/users/luca-heltai/gists{/gist_id}","starred_url":"https://api.github.com/users/luca-heltai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luca-heltai/subscriptions","organizations_url":"https://api.github.com/users/luca-heltai/orgs","repos_url":"https://api.github.com/users/luca-heltai/repos","events_url":"https://api.github.com/users/luca-heltai/events{/privacy}","received_events_url":"https://api.github.com/users/luca-heltai/received_events","type":"User","site_admin":false},"body":"This PR is not intended to be final. It contains quite a big set of changes, and I'll squash most of them before merging. Before I do this, I'd like some feedback from other developers. We have some more classes that could be added to the OpenCASCADE namespace, but we'll proceed with those once this first set is completed.\r\n\r\nIf you have OpenCASCADE (www.opencascade.org) installed (either because you have SALOME, which comes with OpenCASCADE internally, or because you installed OCE, OpenCASCADE Community Edition), this PR allows you to enable it at configure time, and gives you access to NURBS based surface geometries (for the moment only interfaces to IGES files or direct interface to OpenCASCADE `TopoDS_Shape` objects are supported, but STEP and BREP formats are just a few lines of C++ away). This set of changes has been developed in collaboration with @andreamola, in the framework of project OpenSHIP (www.openship.it), and allows us to work daily with CAD files of ships and boats, like the one you see here (DTMB 5415):\r\n\r\n![barehullzoom](https://cloud.githubusercontent.com/assets/2919756/4346143/fbd64a4a-40ef-11e4-9f04-9309fe8b4946.png)\r\n\r\nwhich, using these classes, can be refined as shown in the picture (with curvature based adaptive refinement)\r\n\r\n![initialmeshboat_6](https://cloud.githubusercontent.com/assets/2919756/4346140/eb71a064-40ef-11e4-8025-71260b032604.png)\r\n\r\nAnother example below:\r\n\r\n![kriso_kvlcc2m](https://cloud.githubusercontent.com/assets/2919756/4346147/420abdc0-40f0-11e4-9e56-e51aba5ba670.png)\r\n\r\nWith a detailed view of the Stern refinement:\r\n\r\n![kvlcc2m_mesh_stern](https://cloud.githubusercontent.com/assets/2919756/4346145/23ff8072-40f0-11e4-8b26-83e58125e97c.png)\r\n","created_at":"2014-09-20T18:05:59Z","updated_at":"2014-09-22T00:40:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3a1bb2ff106f5f133e1821e52f49f348ade23364","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dealii/dealii/pulls/166/commits","review_comments_url":"https://api.github.com/repos/dealii/dealii/pulls/166/comments","review_comment_url":"https://api.github.com/repos/dealii/dealii/pulls/comments/{number}","comments_url":"https://api.github.com/repos/dealii/dealii/issues/166/comments","statuses_url":"https://api.github.com/repos/dealii/dealii/statuses/10b820eed00c0a7033c7514901e74b77b037f315","head":{"label":"luca-heltai:open_cascade","ref":"open_cascade","sha":"10b820eed00c0a7033c7514901e74b77b037f315","user":{"login":"luca-heltai","id":2919756,"avatar_url":"https://avatars.githubusercontent.com/u/2919756?v=2","gravatar_id":"7ba1a565ebca22a6d4142817145538e2","url":"https://api.github.com/users/luca-heltai","html_url":"https://github.com/luca-heltai","followers_url":"https://api.github.com/users/luca-heltai/followers","following_url":"https://api.github.com/users/luca-heltai/following{/other_user}","gists_url":"https://api.github.com/users/luca-heltai/gists{/gist_id}","starred_url":"https://api.github.com/users/luca-heltai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luca-heltai/subscriptions","organizations_url":"https://api.github.com/users/luca-heltai/orgs","repos_url":"https://api.github.com/users/luca-heltai/repos","events_url":"https://api.github.com/users/luca-heltai/events{/privacy}","received_events_url":"https://api.github.com/users/luca-heltai/received_events","type":"User","site_admin":false},"repo":{"id":22053864,"name":"dealii","full_name":"luca-heltai/dealii","owner":{"login":"luca-heltai","id":2919756,"avatar_url":"https://avatars.githubusercontent.com/u/2919756?v=2","gravatar_id":"7ba1a565ebca22a6d4142817145538e2","url":"https://api.github.com/users/luca-heltai","html_url":"https://github.com/luca-heltai","followers_url":"https://api.github.com/users/luca-heltai/followers","following_url":"https://api.github.com/users/luca-heltai/following{/other_user}","gists_url":"https://api.github.com/users/luca-heltai/gists{/gist_id}","starred_url":"https://api.github.com/users/luca-heltai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luca-heltai/subscriptions","organizations_url":"https://api.github.com/users/luca-heltai/orgs","repos_url":"https://api.github.com/users/luca-heltai/repos","events_url":"https://api.github.com/users/luca-heltai/events{/privacy}","received_events_url":"https://api.github.com/users/luca-heltai/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/luca-heltai/dealii","description":"","fork":true,"url":"https://api.github.com/repos/luca-heltai/dealii","forks_url":"https://api.github.com/repos/luca-heltai/dealii/forks","keys_url":"https://api.github.com/repos/luca-heltai/dealii/keys{/key_id}","collaborators_url":"https://api.github.com/repos/luca-heltai/dealii/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/luca-heltai/dealii/teams","hooks_url":"https://api.github.com/repos/luca-heltai/dealii/hooks","issue_events_url":"https://api.github.com/repos/luca-heltai/dealii/issues/events{/number}","events_url":"https://api.github.com/repos/luca-heltai/dealii/events","assignees_url":"https://api.github.com/repos/luca-heltai/dealii/assignees{/user}","branches_url":"https://api.github.com/repos/luca-heltai/dealii/branches{/branch}","tags_url":"https://api.github.com/repos/luca-heltai/dealii/tags","blobs_url":"https://api.github.com/repos/luca-heltai/dealii/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/luca-heltai/dealii/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/luca-heltai/dealii/git/refs{/sha}","trees_url":"https://api.github.com/repos/luca-heltai/dealii/git/trees{/sha}","statuses_url":"https://api.github.com/repos/luca-heltai/dealii/statuses/{sha}","languages_url":"https://api.github.com/repos/luca-heltai/dealii/languages","stargazers_url":"https://api.github.com/repos/luca-heltai/dealii/stargazers","contributors_url":"https://api.github.com/repos/luca-heltai/dealii/contributors","subscribers_url":"https://api.github.com/repos/luca-heltai/dealii/subscribers","subscription_url":"https://api.github.com/repos/luca-heltai/dealii/subscription","commits_url":"https://api.github.com/repos/luca-heltai/dealii/commits{/sha}","git_commits_url":"https://api.github.com/repos/luca-heltai/dealii/git/commits{/sha}","comments_url":"https://api.github.com/repos/luca-heltai/dealii/comments{/number}","issue_comment_url":"https://api.github.com/repos/luca-heltai/dealii/issues/comments/{number}","contents_url":"https://api.github.com/repos/luca-heltai/dealii/contents/{+path}","compare_url":"https://api.github.com/repos/luca-heltai/dealii/compare/{base}...{head}","merges_url":"https://api.github.com/repos/luca-heltai/dealii/merges","archive_url":"https://api.github.com/repos/luca-heltai/dealii/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/luca-heltai/dealii/downloads","issues_url":"https://api.github.com/repos/luca-heltai/dealii/issues{/number}","pulls_url":"https://api.github.com/repos/luca-heltai/dealii/pulls{/number}","milestones_url":"https://api.github.com/repos/luca-heltai/dealii/milestones{/number}","notifications_url":"https://api.github.com/repos/luca-heltai/dealii/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/luca-heltai/dealii/labels{/name}","releases_url":"https://api.github.com/repos/luca-heltai/dealii/releases{/id}","created_at":"2014-07-21T06:17:40Z","updated_at":"2014-07-24T22:48:35Z","pushed_at":"2014-09-20T18:12:55Z","git_url":"git://github.com/luca-heltai/dealii.git","ssh_url":"git@github.com:luca-heltai/dealii.git","clone_url":"https://github.com/luca-heltai/dealii.git","svn_url":"https://github.com/luca-heltai/dealii","homepage":null,"size":97441,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"dealii:master","ref":"master","sha":"94dba6c6f641010ffad8a76e8d7701cef6827519","user":{"login":"dealii","id":7506070,"avatar_url":"https://avatars.githubusercontent.com/u/7506070?v=2","gravatar_id":null,"url":"https://api.github.com/users/dealii","html_url":"https://github.com/dealii","followers_url":"https://api.github.com/users/dealii/followers","following_url":"https://api.github.com/users/dealii/following{/other_user}","gists_url":"https://api.github.com/users/dealii/gists{/gist_id}","starred_url":"https://api.github.com/users/dealii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dealii/subscriptions","organizations_url":"https://api.github.com/users/dealii/orgs","repos_url":"https://api.github.com/users/dealii/repos","events_url":"https://api.github.com/users/dealii/events{/privacy}","received_events_url":"https://api.github.com/users/dealii/received_events","type":"Organization","site_admin":false},"repo":{"id":21943980,"name":"dealii","full_name":"dealii/dealii","owner":{"login":"dealii","id":7506070,"avatar_url":"https://avatars.githubusercontent.com/u/7506070?v=2","gravatar_id":null,"url":"https://api.github.com/users/dealii","html_url":"https://github.com/dealii","followers_url":"https://api.github.com/users/dealii/followers","following_url":"https://api.github.com/users/dealii/following{/other_user}","gists_url":"https://api.github.com/users/dealii/gists{/gist_id}","starred_url":"https://api.github.com/users/dealii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dealii/subscriptions","organizations_url":"https://api.github.com/users/dealii/orgs","repos_url":"https://api.github.com/users/dealii/repos","events_url":"https://api.github.com/users/dealii/events{/privacy}","received_events_url":"https://api.github.com/users/dealii/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dealii/dealii","description":"The development repository for the deal.II finite element library.","fork":false,"url":"https://api.github.com/repos/dealii/dealii","forks_url":"https://api.github.com/repos/dealii/dealii/forks","keys_url":"https://api.github.com/repos/dealii/dealii/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dealii/dealii/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dealii/dealii/teams","hooks_url":"https://api.github.com/repos/dealii/dealii/hooks","issue_events_url":"https://api.github.com/repos/dealii/dealii/issues/events{/number}","events_url":"https://api.github.com/repos/dealii/dealii/events","assignees_url":"https://api.github.com/repos/dealii/dealii/assignees{/user}","branches_url":"https://api.github.com/repos/dealii/dealii/branches{/branch}","tags_url":"https://api.github.com/repos/dealii/dealii/tags","blobs_url":"https://api.github.com/repos/dealii/dealii/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dealii/dealii/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dealii/dealii/git/refs{/sha}","trees_url":"https://api.github.com/repos/dealii/dealii/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dealii/dealii/statuses/{sha}","languages_url":"https://api.github.com/repos/dealii/dealii/languages","stargazers_url":"https://api.github.com/repos/dealii/dealii/stargazers","contributors_url":"https://api.github.com/repos/dealii/dealii/contributors","subscribers_url":"https://api.github.com/repos/dealii/dealii/subscribers","subscription_url":"https://api.github.com/repos/dealii/dealii/subscription","commits_url":"https://api.github.com/repos/dealii/dealii/commits{/sha}","git_commits_url":"https://api.github.com/repos/dealii/dealii/git/commits{/sha}","comments_url":"https://api.github.com/repos/dealii/dealii/comments{/number}","issue_comment_url":"https://api.github.com/repos/dealii/dealii/issues/comments/{number}","contents_url":"https://api.github.com/repos/dealii/dealii/contents/{+path}","compare_url":"https://api.github.com/repos/dealii/dealii/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dealii/dealii/merges","archive_url":"https://api.github.com/repos/dealii/dealii/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dealii/dealii/downloads","issues_url":"https://api.github.com/repos/dealii/dealii/issues{/number}","pulls_url":"https://api.github.com/repos/dealii/dealii/pulls{/number}","milestones_url":"https://api.github.com/repos/dealii/dealii/milestones{/number}","notifications_url":"https://api.github.com/repos/dealii/dealii/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dealii/dealii/labels{/name}","releases_url":"https://api.github.com/repos/dealii/dealii/releases{/id}","created_at":"2014-07-17T14:00:26Z","updated_at":"2014-09-21T09:38:24Z","pushed_at":"2014-09-21T23:55:32Z","git_url":"git://github.com/dealii/dealii.git","ssh_url":"git@github.com:dealii/dealii.git","clone_url":"https://github.com/dealii/dealii.git","svn_url":"https://github.com/dealii/dealii","homepage":"http://www.dealii.org/","size":117176,"stargazers_count":19,"watchers_count":19,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":11,"forks":25,"open_issues":11,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dealii/dealii/pulls/166"},"html":{"href":"https://github.com/dealii/dealii/pull/166"},"issue":{"href":"https://api.github.com/repos/dealii/dealii/issues/166"},"comments":{"href":"https://api.github.com/repos/dealii/dealii/issues/166/comments"},"review_comments":{"href":"https://api.github.com/repos/dealii/dealii/pulls/166/comments"},"review_comment":{"href":"https://api.github.com/repos/dealii/dealii/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/dealii/dealii/pulls/166/commits"},"statuses":{"href":"https://api.github.com/repos/dealii/dealii/statuses/10b820eed00c0a7033c7514901e74b77b037f315"}}}}