GitHub PullRequestReviewCommentEvent at 2014-11-24 16:17:13
Repository: good-file
Actor: cjihrig
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/hapijs/good-file/pulls/comments/20800228","id":20800228,"diff_hunk":"@@ -38,6 +37,6 @@ server.route({\n             id: request.id\n         });\n \n-        reply(200);\n+        reply().statusCode(200);","path":"examples/app.js","position":12,"original_position":12,"commit_id":"a6cb78b57ff171c38b74a50b7dfbf90f8c086545","original_commit_id":"a6cb78b57ff171c38b74a50b7dfbf90f8c086545","user":{"login":"cjihrig","id":2512748,"avatar_url":"https://avatars.githubusercontent.com/u/2512748?v=3","gravatar_id":"","url":"https://api.github.com/users/cjihrig","html_url":"https://github.com/cjihrig","followers_url":"https://api.github.com/users/cjihrig/followers","following_url":"https://api.github.com/users/cjihrig/following{/other_user}","gists_url":"https://api.github.com/users/cjihrig/gists{/gist_id}","starred_url":"https://api.github.com/users/cjihrig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjihrig/subscriptions","organizations_url":"https://api.github.com/users/cjihrig/orgs","repos_url":"https://api.github.com/users/cjihrig/repos","events_url":"https://api.github.com/users/cjihrig/events{/privacy}","received_events_url":"https://api.github.com/users/cjihrig/received_events","type":"User","site_admin":false},"body":"I **think** this is just `code()`","created_at":"2014-11-24T16:17:13Z","updated_at":"2014-11-24T16:17:13Z","html_url":"https://github.com/hapijs/good-file/pull/37#discussion_r20800228","pull_request_url":"https://api.github.com/repos/hapijs/good-file/pulls/37","_links":{"self":{"href":"https://api.github.com/repos/hapijs/good-file/pulls/comments/20800228"},"html":{"href":"https://github.com/hapijs/good-file/pull/37#discussion_r20800228"},"pull_request":{"href":"https://api.github.com/repos/hapijs/good-file/pulls/37"}}},"pull_request":{"url":"https://api.github.com/repos/hapijs/good-file/pulls/37","id":24942965,"html_url":"https://github.com/hapijs/good-file/pull/37","diff_url":"https://github.com/hapijs/good-file/pull/37.diff","patch_url":"https://github.com/hapijs/good-file/pull/37.patch","issue_url":"https://api.github.com/repos/hapijs/good-file/issues/37","number":37,"state":"open","locked":false,"title":"Time Rotation","user":{"login":"arb","id":1591483,"avatar_url":"https://avatars.githubusercontent.com/u/1591483?v=3","gravatar_id":"","url":"https://api.github.com/users/arb","html_url":"https://github.com/arb","followers_url":"https://api.github.com/users/arb/followers","following_url":"https://api.github.com/users/arb/following{/other_user}","gists_url":"https://api.github.com/users/arb/gists{/gist_id}","starred_url":"https://api.github.com/users/arb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arb/subscriptions","organizations_url":"https://api.github.com/users/arb/orgs","repos_url":"https://api.github.com/users/arb/repos","events_url":"https://api.github.com/users/arb/events{/privacy}","received_events_url":"https://api.github.com/users/arb/received_events","type":"User","site_admin":false},"body":"- Added `rotate` options\r\n- Refactored so the stream error was available on `this` to reduce complexity.\r\n- Updated docs\r\n- Added test for `rotate` option\r\n- Added sanitization for file names to prevent `Path.sep` from being in `format`","created_at":"2014-11-24T16:11:19Z","updated_at":"2014-11-24T16:17:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7b670f57a91f2e8fe07722f1814f810a58962b46","assignee":{"login":"cjihrig","id":2512748,"avatar_url":"https://avatars.githubusercontent.com/u/2512748?v=3","gravatar_id":"","url":"https://api.github.com/users/cjihrig","html_url":"https://github.com/cjihrig","followers_url":"https://api.github.com/users/cjihrig/followers","following_url":"https://api.github.com/users/cjihrig/following{/other_user}","gists_url":"https://api.github.com/users/cjihrig/gists{/gist_id}","starred_url":"https://api.github.com/users/cjihrig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjihrig/subscriptions","organizations_url":"https://api.github.com/users/cjihrig/orgs","repos_url":"https://api.github.com/users/cjihrig/repos","events_url":"https://api.github.com/users/cjihrig/events{/privacy}","received_events_url":"https://api.github.com/users/cjihrig/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/hapijs/good-file/milestones/7","labels_url":"https://api.github.com/repos/hapijs/good-file/milestones/7/labels","id":860781,"number":7,"title":"4.0.0","description":"","creator":{"login":"arb","id":1591483,"avatar_url":"https://avatars.githubusercontent.com/u/1591483?v=3","gravatar_id":"","url":"https://api.github.com/users/arb","html_url":"https://github.com/arb","followers_url":"https://api.github.com/users/arb/followers","following_url":"https://api.github.com/users/arb/following{/other_user}","gists_url":"https://api.github.com/users/arb/gists{/gist_id}","starred_url":"https://api.github.com/users/arb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arb/subscriptions","organizations_url":"https://api.github.com/users/arb/orgs","repos_url":"https://api.github.com/users/arb/repos","events_url":"https://api.github.com/users/arb/events{/privacy}","received_events_url":"https://api.github.com/users/arb/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":5,"state":"open","created_at":"2014-11-10T22:22:20Z","updated_at":"2014-11-24T16:11:25Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/hapijs/good-file/pulls/37/commits","review_comments_url":"https://api.github.com/repos/hapijs/good-file/pulls/37/comments","review_comment_url":"https://api.github.com/repos/hapijs/good-file/pulls/comments/{number}","comments_url":"https://api.github.com/repos/hapijs/good-file/issues/37/comments","statuses_url":"https://api.github.com/repos/hapijs/good-file/statuses/a6cb78b57ff171c38b74a50b7dfbf90f8c086545","head":{"label":"arb:rotation","ref":"rotation","sha":"a6cb78b57ff171c38b74a50b7dfbf90f8c086545","user":{"login":"arb","id":1591483,"avatar_url":"https://avatars.githubusercontent.com/u/1591483?v=3","gravatar_id":"","url":"https://api.github.com/users/arb","html_url":"https://github.com/arb","followers_url":"https://api.github.com/users/arb/followers","following_url":"https://api.github.com/users/arb/following{/other_user}","gists_url":"https://api.github.com/users/arb/gists{/gist_id}","starred_url":"https://api.github.com/users/arb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arb/subscriptions","organizations_url":"https://api.github.com/users/arb/orgs","repos_url":"https://api.github.com/users/arb/repos","events_url":"https://api.github.com/users/arb/events{/privacy}","received_events_url":"https://api.github.com/users/arb/received_events","type":"User","site_admin":false},"repo":{"id":24738239,"name":"good-file","full_name":"arb/good-file","owner":{"login":"arb","id":1591483,"avatar_url":"https://avatars.githubusercontent.com/u/1591483?v=3","gravatar_id":"","url":"https://api.github.com/users/arb","html_url":"https://github.com/arb","followers_url":"https://api.github.com/users/arb/followers","following_url":"https://api.github.com/users/arb/following{/other_user}","gists_url":"https://api.github.com/users/arb/gists{/gist_id}","starred_url":"https://api.github.com/users/arb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arb/subscriptions","organizations_url":"https://api.github.com/users/arb/orgs","repos_url":"https://api.github.com/users/arb/repos","events_url":"https://api.github.com/users/arb/events{/privacy}","received_events_url":"https://api.github.com/users/arb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arb/good-file","description":"File broadcasting for Good process monitor","fork":true,"url":"https://api.github.com/repos/arb/good-file","forks_url":"https://api.github.com/repos/arb/good-file/forks","keys_url":"https://api.github.com/repos/arb/good-file/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arb/good-file/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arb/good-file/teams","hooks_url":"https://api.github.com/repos/arb/good-file/hooks","issue_events_url":"https://api.github.com/repos/arb/good-file/issues/events{/number}","events_url":"https://api.github.com/repos/arb/good-file/events","assignees_url":"https://api.github.com/repos/arb/good-file/assignees{/user}","branches_url":"https://api.github.com/repos/arb/good-file/branches{/branch}","tags_url":"https://api.github.com/repos/arb/good-file/tags","blobs_url":"https://api.github.com/repos/arb/good-file/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arb/good-file/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arb/good-file/git/refs{/sha}","trees_url":"https://api.github.com/repos/arb/good-file/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arb/good-file/statuses/{sha}","languages_url":"https://api.github.com/repos/arb/good-file/languages","stargazers_url":"https://api.github.com/repos/arb/good-file/stargazers","contributors_url":"https://api.github.com/repos/arb/good-file/contributors","subscribers_url":"https://api.github.com/repos/arb/good-file/subscribers","subscription_url":"https://api.github.com/repos/arb/good-file/subscription","commits_url":"https://api.github.com/repos/arb/good-file/commits{/sha}","git_commits_url":"https://api.github.com/repos/arb/good-file/git/commits{/sha}","comments_url":"https://api.github.com/repos/arb/good-file/comments{/number}","issue_comment_url":"https://api.github.com/repos/arb/good-file/issues/comments/{number}","contents_url":"https://api.github.com/repos/arb/good-file/contents/{+path}","compare_url":"https://api.github.com/repos/arb/good-file/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arb/good-file/merges","archive_url":"https://api.github.com/repos/arb/good-file/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arb/good-file/downloads","issues_url":"https://api.github.com/repos/arb/good-file/issues{/number}","pulls_url":"https://api.github.com/repos/arb/good-file/pulls{/number}","milestones_url":"https://api.github.com/repos/arb/good-file/milestones{/number}","notifications_url":"https://api.github.com/repos/arb/good-file/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arb/good-file/labels{/name}","releases_url":"https://api.github.com/repos/arb/good-file/releases{/id}","created_at":"2014-10-02T21:54:18Z","updated_at":"2014-09-28T19:17:49Z","pushed_at":"2014-11-24T16:05:48Z","git_url":"git://github.com/arb/good-file.git","ssh_url":"git@github.com:arb/good-file.git","clone_url":"https://github.com/arb/good-file.git","svn_url":"https://github.com/arb/good-file","homepage":null,"size":290,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hapijs:master","ref":"master","sha":"2e91ae1814f2db8cb44fc935413466d04f01fe2f","user":{"login":"hapijs","id":3774533,"avatar_url":"https://avatars.githubusercontent.com/u/3774533?v=3","gravatar_id":"","url":"https://api.github.com/users/hapijs","html_url":"https://github.com/hapijs","followers_url":"https://api.github.com/users/hapijs/followers","following_url":"https://api.github.com/users/hapijs/following{/other_user}","gists_url":"https://api.github.com/users/hapijs/gists{/gist_id}","starred_url":"https://api.github.com/users/hapijs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hapijs/subscriptions","organizations_url":"https://api.github.com/users/hapijs/orgs","repos_url":"https://api.github.com/users/hapijs/repos","events_url":"https://api.github.com/users/hapijs/events{/privacy}","received_events_url":"https://api.github.com/users/hapijs/received_events","type":"Organization","site_admin":false},"repo":{"id":23968038,"name":"good-file","full_name":"hapijs/good-file","owner":{"login":"hapijs","id":3774533,"avatar_url":"https://avatars.githubusercontent.com/u/3774533?v=3","gravatar_id":"","url":"https://api.github.com/users/hapijs","html_url":"https://github.com/hapijs","followers_url":"https://api.github.com/users/hapijs/followers","following_url":"https://api.github.com/users/hapijs/following{/other_user}","gists_url":"https://api.github.com/users/hapijs/gists{/gist_id}","starred_url":"https://api.github.com/users/hapijs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hapijs/subscriptions","organizations_url":"https://api.github.com/users/hapijs/orgs","repos_url":"https://api.github.com/users/hapijs/repos","events_url":"https://api.github.com/users/hapijs/events{/privacy}","received_events_url":"https://api.github.com/users/hapijs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hapijs/good-file","description":"File broadcasting for Good process monitor","fork":false,"url":"https://api.github.com/repos/hapijs/good-file","forks_url":"https://api.github.com/repos/hapijs/good-file/forks","keys_url":"https://api.github.com/repos/hapijs/good-file/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hapijs/good-file/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hapijs/good-file/teams","hooks_url":"https://api.github.com/repos/hapijs/good-file/hooks","issue_events_url":"https://api.github.com/repos/hapijs/good-file/issues/events{/number}","events_url":"https://api.github.com/repos/hapijs/good-file/events","assignees_url":"https://api.github.com/repos/hapijs/good-file/assignees{/user}","branches_url":"https://api.github.com/repos/hapijs/good-file/branches{/branch}","tags_url":"https://api.github.com/repos/hapijs/good-file/tags","blobs_url":"https://api.github.com/repos/hapijs/good-file/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hapijs/good-file/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hapijs/good-file/git/refs{/sha}","trees_url":"https://api.github.com/repos/hapijs/good-file/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hapijs/good-file/statuses/{sha}","languages_url":"https://api.github.com/repos/hapijs/good-file/languages","stargazers_url":"https://api.github.com/repos/hapijs/good-file/stargazers","contributors_url":"https://api.github.com/repos/hapijs/good-file/contributors","subscribers_url":"https://api.github.com/repos/hapijs/good-file/subscribers","subscription_url":"https://api.github.com/repos/hapijs/good-file/subscription","commits_url":"https://api.github.com/repos/hapijs/good-file/commits{/sha}","git_commits_url":"https://api.github.com/repos/hapijs/good-file/git/commits{/sha}","comments_url":"https://api.github.com/repos/hapijs/good-file/comments{/number}","issue_comment_url":"https://api.github.com/repos/hapijs/good-file/issues/comments/{number}","contents_url":"https://api.github.com/repos/hapijs/good-file/contents/{+path}","compare_url":"https://api.github.com/repos/hapijs/good-file/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hapijs/good-file/merges","archive_url":"https://api.github.com/repos/hapijs/good-file/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hapijs/good-file/downloads","issues_url":"https://api.github.com/repos/hapijs/good-file/issues{/number}","pulls_url":"https://api.github.com/repos/hapijs/good-file/pulls{/number}","milestones_url":"https://api.github.com/repos/hapijs/good-file/milestones{/number}","notifications_url":"https://api.github.com/repos/hapijs/good-file/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hapijs/good-file/labels{/name}","releases_url":"https://api.github.com/repos/hapijs/good-file/releases{/id}","created_at":"2014-09-12T16:25:59Z","updated_at":"2014-11-19T17:28:54Z","pushed_at":"2014-11-19T17:28:54Z","git_url":"git://github.com/hapijs/good-file.git","ssh_url":"git@github.com:hapijs/good-file.git","clone_url":"https://github.com/hapijs/good-file.git","svn_url":"https://github.com/hapijs/good-file","homepage":null,"size":484,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":2,"forks":4,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hapijs/good-file/pulls/37"},"html":{"href":"https://github.com/hapijs/good-file/pull/37"},"issue":{"href":"https://api.github.com/repos/hapijs/good-file/issues/37"},"comments":{"href":"https://api.github.com/repos/hapijs/good-file/issues/37/comments"},"review_comments":{"href":"https://api.github.com/repos/hapijs/good-file/pulls/37/comments"},"review_comment":{"href":"https://api.github.com/repos/hapijs/good-file/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/hapijs/good-file/pulls/37/commits"},"statuses":{"href":"https://api.github.com/repos/hapijs/good-file/statuses/a6cb78b57ff171c38b74a50b7dfbf90f8c086545"}}}}