GitHub PullRequestReviewCommentEvent at 2014-10-31 20:50:43
Repository: deis
Actor: mboersma
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/deis/deis/pulls/comments/19692959","id":19692959,"diff_hunk":"@@ -0,0 +1,18 @@\n+package logger\n+\n+import (\n+\t\"bytes\"\n+\t\"fmt\"\n+\t\"strings\"\n+\n+\t\"github.com/Sirupsen/logrus\"","path":"router/parent/logger/stdout_formatter.go","position":8,"original_position":8,"commit_id":"7cfab091ec57b0f6547f1f5a7e40c6ef06c5930b","original_commit_id":"7cfab091ec57b0f6547f1f5a7e40c6ef06c5930b","user":{"login":"mboersma","id":73019,"avatar_url":"https://avatars.githubusercontent.com/u/73019?v=2","gravatar_id":"","url":"https://api.github.com/users/mboersma","html_url":"https://github.com/mboersma","followers_url":"https://api.github.com/users/mboersma/followers","following_url":"https://api.github.com/users/mboersma/following{/other_user}","gists_url":"https://api.github.com/users/mboersma/gists{/gist_id}","starred_url":"https://api.github.com/users/mboersma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mboersma/subscriptions","organizations_url":"https://api.github.com/users/mboersma/orgs","repos_url":"https://api.github.com/users/mboersma/repos","events_url":"https://api.github.com/users/mboersma/events{/privacy}","received_events_url":"https://api.github.com/users/mboersma/received_events","type":"User","site_admin":false},"body":"We shouldn't ever do `go get` or the equivalent in a build process. It can't be versioned and it can't be reproduced. And third-party go packages must always be vendored in as per our [code standards](http://docs.deis.io/en/latest/contributing/standards/#code-standards):\r\n\r\n> Use of third-party go packages should be minimal, but when doing so, vendor code into the Deis package with the `godep` tool.","created_at":"2014-10-31T20:50:43Z","updated_at":"2014-10-31T20:50:43Z","html_url":"https://github.com/deis/deis/pull/2306#discussion_r19692959","pull_request_url":"https://api.github.com/repos/deis/deis/pulls/2306","_links":{"self":{"href":"https://api.github.com/repos/deis/deis/pulls/comments/19692959"},"html":{"href":"https://github.com/deis/deis/pull/2306#discussion_r19692959"},"pull_request":{"href":"https://api.github.com/repos/deis/deis/pulls/2306"}}},"pull_request":{"url":"https://api.github.com/repos/deis/deis/pulls/2306","id":23502764,"html_url":"https://github.com/deis/deis/pull/2306","diff_url":"https://github.com/deis/deis/pull/2306.diff","patch_url":"https://github.com/deis/deis/pull/2306.patch","issue_url":"https://api.github.com/repos/deis/deis/issues/2306","number":2306,"state":"open","locked":false,"title":"feat(router): improve log output.","user":{"login":"aledbf","id":161571,"avatar_url":"https://avatars.githubusercontent.com/u/161571?v=2","gravatar_id":"","url":"https://api.github.com/users/aledbf","html_url":"https://github.com/aledbf","followers_url":"https://api.github.com/users/aledbf/followers","following_url":"https://api.github.com/users/aledbf/following{/other_user}","gists_url":"https://api.github.com/users/aledbf/gists{/gist_id}","starred_url":"https://api.github.com/users/aledbf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aledbf/subscriptions","organizations_url":"https://api.github.com/users/aledbf/orgs","repos_url":"https://api.github.com/users/aledbf/repos","events_url":"https://api.github.com/users/aledbf/events{/privacy}","received_events_url":"https://api.github.com/users/aledbf/received_events","type":"User","site_admin":false},"body":"Add information about the matched host (user application or deis component) and information about the router node.","created_at":"2014-10-29T01:15:03Z","updated_at":"2014-10-31T20:50:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e5b5b82cfe236fd21c04bd5d729cd01505d78e4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/deis/deis/pulls/2306/commits","review_comments_url":"https://api.github.com/repos/deis/deis/pulls/2306/comments","review_comment_url":"https://api.github.com/repos/deis/deis/pulls/comments/{number}","comments_url":"https://api.github.com/repos/deis/deis/issues/2306/comments","statuses_url":"https://api.github.com/repos/deis/deis/statuses/7cfab091ec57b0f6547f1f5a7e40c6ef06c5930b","head":{"label":"aledbf:improve_nginx_log","ref":"improve_nginx_log","sha":"7cfab091ec57b0f6547f1f5a7e40c6ef06c5930b","user":{"login":"aledbf","id":161571,"avatar_url":"https://avatars.githubusercontent.com/u/161571?v=2","gravatar_id":"","url":"https://api.github.com/users/aledbf","html_url":"https://github.com/aledbf","followers_url":"https://api.github.com/users/aledbf/followers","following_url":"https://api.github.com/users/aledbf/following{/other_user}","gists_url":"https://api.github.com/users/aledbf/gists{/gist_id}","starred_url":"https://api.github.com/users/aledbf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aledbf/subscriptions","organizations_url":"https://api.github.com/users/aledbf/orgs","repos_url":"https://api.github.com/users/aledbf/repos","events_url":"https://api.github.com/users/aledbf/events{/privacy}","received_events_url":"https://api.github.com/users/aledbf/received_events","type":"User","site_admin":false},"repo":{"id":23717083,"name":"deis","full_name":"aledbf/deis","owner":{"login":"aledbf","id":161571,"avatar_url":"https://avatars.githubusercontent.com/u/161571?v=2","gravatar_id":"","url":"https://api.github.com/users/aledbf","html_url":"https://github.com/aledbf","followers_url":"https://api.github.com/users/aledbf/followers","following_url":"https://api.github.com/users/aledbf/following{/other_user}","gists_url":"https://api.github.com/users/aledbf/gists{/gist_id}","starred_url":"https://api.github.com/users/aledbf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aledbf/subscriptions","organizations_url":"https://api.github.com/users/aledbf/orgs","repos_url":"https://api.github.com/users/aledbf/repos","events_url":"https://api.github.com/users/aledbf/events{/privacy}","received_events_url":"https://api.github.com/users/aledbf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aledbf/deis","description":"Your PaaS. Your Rules. ","fork":true,"url":"https://api.github.com/repos/aledbf/deis","forks_url":"https://api.github.com/repos/aledbf/deis/forks","keys_url":"https://api.github.com/repos/aledbf/deis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aledbf/deis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aledbf/deis/teams","hooks_url":"https://api.github.com/repos/aledbf/deis/hooks","issue_events_url":"https://api.github.com/repos/aledbf/deis/issues/events{/number}","events_url":"https://api.github.com/repos/aledbf/deis/events","assignees_url":"https://api.github.com/repos/aledbf/deis/assignees{/user}","branches_url":"https://api.github.com/repos/aledbf/deis/branches{/branch}","tags_url":"https://api.github.com/repos/aledbf/deis/tags","blobs_url":"https://api.github.com/repos/aledbf/deis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aledbf/deis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aledbf/deis/git/refs{/sha}","trees_url":"https://api.github.com/repos/aledbf/deis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aledbf/deis/statuses/{sha}","languages_url":"https://api.github.com/repos/aledbf/deis/languages","stargazers_url":"https://api.github.com/repos/aledbf/deis/stargazers","contributors_url":"https://api.github.com/repos/aledbf/deis/contributors","subscribers_url":"https://api.github.com/repos/aledbf/deis/subscribers","subscription_url":"https://api.github.com/repos/aledbf/deis/subscription","commits_url":"https://api.github.com/repos/aledbf/deis/commits{/sha}","git_commits_url":"https://api.github.com/repos/aledbf/deis/git/commits{/sha}","comments_url":"https://api.github.com/repos/aledbf/deis/comments{/number}","issue_comment_url":"https://api.github.com/repos/aledbf/deis/issues/comments/{number}","contents_url":"https://api.github.com/repos/aledbf/deis/contents/{+path}","compare_url":"https://api.github.com/repos/aledbf/deis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aledbf/deis/merges","archive_url":"https://api.github.com/repos/aledbf/deis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aledbf/deis/downloads","issues_url":"https://api.github.com/repos/aledbf/deis/issues{/number}","pulls_url":"https://api.github.com/repos/aledbf/deis/pulls{/number}","milestones_url":"https://api.github.com/repos/aledbf/deis/milestones{/number}","notifications_url":"https://api.github.com/repos/aledbf/deis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aledbf/deis/labels{/name}","releases_url":"https://api.github.com/repos/aledbf/deis/releases{/id}","created_at":"2014-09-05T20:18:40Z","updated_at":"2014-10-27T21:47:23Z","pushed_at":"2014-10-30T18:04:23Z","git_url":"git://github.com/aledbf/deis.git","ssh_url":"git@github.com:aledbf/deis.git","clone_url":"https://github.com/aledbf/deis.git","svn_url":"https://github.com/aledbf/deis","homepage":"http://deis.io","size":14517,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"deis:master","ref":"master","sha":"a3dc69e8bd22284ce282492972f964947fc352d0","user":{"login":"deis","id":6117407,"avatar_url":"https://avatars.githubusercontent.com/u/6117407?v=2","gravatar_id":"","url":"https://api.github.com/users/deis","html_url":"https://github.com/deis","followers_url":"https://api.github.com/users/deis/followers","following_url":"https://api.github.com/users/deis/following{/other_user}","gists_url":"https://api.github.com/users/deis/gists{/gist_id}","starred_url":"https://api.github.com/users/deis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deis/subscriptions","organizations_url":"https://api.github.com/users/deis/orgs","repos_url":"https://api.github.com/users/deis/repos","events_url":"https://api.github.com/users/deis/events{/privacy}","received_events_url":"https://api.github.com/users/deis/received_events","type":"Organization","site_admin":false},"repo":{"id":11589713,"name":"deis","full_name":"deis/deis","owner":{"login":"deis","id":6117407,"avatar_url":"https://avatars.githubusercontent.com/u/6117407?v=2","gravatar_id":"","url":"https://api.github.com/users/deis","html_url":"https://github.com/deis","followers_url":"https://api.github.com/users/deis/followers","following_url":"https://api.github.com/users/deis/following{/other_user}","gists_url":"https://api.github.com/users/deis/gists{/gist_id}","starred_url":"https://api.github.com/users/deis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deis/subscriptions","organizations_url":"https://api.github.com/users/deis/orgs","repos_url":"https://api.github.com/users/deis/repos","events_url":"https://api.github.com/users/deis/events{/privacy}","received_events_url":"https://api.github.com/users/deis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/deis/deis","description":"Your PaaS. Your Rules. ","fork":false,"url":"https://api.github.com/repos/deis/deis","forks_url":"https://api.github.com/repos/deis/deis/forks","keys_url":"https://api.github.com/repos/deis/deis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deis/deis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deis/deis/teams","hooks_url":"https://api.github.com/repos/deis/deis/hooks","issue_events_url":"https://api.github.com/repos/deis/deis/issues/events{/number}","events_url":"https://api.github.com/repos/deis/deis/events","assignees_url":"https://api.github.com/repos/deis/deis/assignees{/user}","branches_url":"https://api.github.com/repos/deis/deis/branches{/branch}","tags_url":"https://api.github.com/repos/deis/deis/tags","blobs_url":"https://api.github.com/repos/deis/deis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deis/deis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deis/deis/git/refs{/sha}","trees_url":"https://api.github.com/repos/deis/deis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deis/deis/statuses/{sha}","languages_url":"https://api.github.com/repos/deis/deis/languages","stargazers_url":"https://api.github.com/repos/deis/deis/stargazers","contributors_url":"https://api.github.com/repos/deis/deis/contributors","subscribers_url":"https://api.github.com/repos/deis/deis/subscribers","subscription_url":"https://api.github.com/repos/deis/deis/subscription","commits_url":"https://api.github.com/repos/deis/deis/commits{/sha}","git_commits_url":"https://api.github.com/repos/deis/deis/git/commits{/sha}","comments_url":"https://api.github.com/repos/deis/deis/comments{/number}","issue_comment_url":"https://api.github.com/repos/deis/deis/issues/comments/{number}","contents_url":"https://api.github.com/repos/deis/deis/contents/{+path}","compare_url":"https://api.github.com/repos/deis/deis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deis/deis/merges","archive_url":"https://api.github.com/repos/deis/deis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deis/deis/downloads","issues_url":"https://api.github.com/repos/deis/deis/issues{/number}","pulls_url":"https://api.github.com/repos/deis/deis/pulls{/number}","milestones_url":"https://api.github.com/repos/deis/deis/milestones{/number}","notifications_url":"https://api.github.com/repos/deis/deis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deis/deis/labels{/name}","releases_url":"https://api.github.com/repos/deis/deis/releases{/id}","created_at":"2013-07-22T19:02:40Z","updated_at":"2014-10-31T15:01:06Z","pushed_at":"2014-10-31T19:39:09Z","git_url":"git://github.com/deis/deis.git","ssh_url":"git@github.com:deis/deis.git","clone_url":"https://github.com/deis/deis.git","svn_url":"https://github.com/deis/deis","homepage":"http://deis.io","size":45603,"stargazers_count":2830,"watchers_count":2830,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":354,"mirror_url":null,"open_issues_count":152,"forks":354,"open_issues":152,"watchers":2830,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/deis/deis/pulls/2306"},"html":{"href":"https://github.com/deis/deis/pull/2306"},"issue":{"href":"https://api.github.com/repos/deis/deis/issues/2306"},"comments":{"href":"https://api.github.com/repos/deis/deis/issues/2306/comments"},"review_comments":{"href":"https://api.github.com/repos/deis/deis/pulls/2306/comments"},"review_comment":{"href":"https://api.github.com/repos/deis/deis/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/deis/deis/pulls/2306/commits"},"statuses":{"href":"https://api.github.com/repos/deis/deis/statuses/7cfab091ec57b0f6547f1f5a7e40c6ef06c5930b"}}}}