GitHub PullRequestEvent at 2014-09-22 11:37:56
Repository: cordova-lib
Actor: sgrebnov
Payload: {"action":"opened","number":89,"pull_request":{"url":"https://api.github.com/repos/apache/cordova-lib/pulls/89","id":21573475,"html_url":"https://github.com/apache/cordova-lib/pull/89","diff_url":"https://github.com/apache/cordova-lib/pull/89.diff","patch_url":"https://github.com/apache/cordova-lib/pull/89.patch","issue_url":"https://api.github.com/repos/apache/cordova-lib/issues/89","number":89,"state":"open","locked":false,"title":"CB-7607 Add xxhdpi and xxxhdpi support to Android Cordova","user":{"login":"sgrebnov","id":981580,"avatar_url":"https://avatars.githubusercontent.com/u/981580?v=2","gravatar_id":"5c4b7f1e8101cd3df7a74d93ae4c6bab","url":"https://api.github.com/users/sgrebnov","html_url":"https://github.com/sgrebnov","followers_url":"https://api.github.com/users/sgrebnov/followers","following_url":"https://api.github.com/users/sgrebnov/following{/other_user}","gists_url":"https://api.github.com/users/sgrebnov/gists{/gist_id}","starred_url":"https://api.github.com/users/sgrebnov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgrebnov/subscriptions","organizations_url":"https://api.github.com/users/sgrebnov/orgs","repos_url":"https://api.github.com/users/sgrebnov/repos","events_url":"https://api.github.com/users/sgrebnov/events{/privacy}","received_events_url":"https://api.github.com/users/sgrebnov/received_events","type":"User","site_admin":false},"body":"https://issues.apache.org/jira/browse/CB-7607\r\n\r\nCurrent Cordova template for Android does not have res sub-folders for xx and xxxhdpi plus due to current splash/icons support implementation it is possible to replace already existing drawables only(see var densities = this.deleteDefaultResource(...)). I don't think we should always keep new hi res images as part of default template due to the their big size so this commit improves splash/icons support implementation to make it possible to add drawables for the densities which are not present in template by default.\r\n\r\nExample configuration for xxhdpi and xxxhdpi assets:\r\n```\r\n<icon src=\"res/android/xxhdpi.png\" density=\"xxhdpi\" />\r\n<icon src=\"res/android/xxxhdpi.png\" density=\"xxxhdpi\" />\r\n\r\n<splash src=\"res/android/land-xxhdpi.png\" density=\"land-xxhdpi\" />\r\n<splash src=\"res/android/port-xxhdpi.png\" density=\"port-xxhdpi\" />\r\n\r\n<splash src=\"res/android/land-xxxhdpi.png\" density=\"land-xxxhdpi\" />\r\n<splash src=\"res/android/port-xxxhdpi.png\" density=\"port-xxxhdpi\" />\r\n```\r\n","created_at":"2014-09-22T11:37:56Z","updated_at":"2014-09-22T11:37:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/cordova-lib/pulls/89/commits","review_comments_url":"https://api.github.com/repos/apache/cordova-lib/pulls/89/comments","review_comment_url":"https://api.github.com/repos/apache/cordova-lib/pulls/comments/{number}","comments_url":"https://api.github.com/repos/apache/cordova-lib/issues/89/comments","statuses_url":"https://api.github.com/repos/apache/cordova-lib/statuses/f01e5b76ca67f728ce5680be252985574924e536","head":{"label":"MSOpenTech:CB-7607","ref":"CB-7607","sha":"f01e5b76ca67f728ce5680be252985574924e536","user":{"login":"MSOpenTech","id":1638184,"avatar_url":"https://avatars.githubusercontent.com/u/1638184?v=2","gravatar_id":"75752e740f4383e6f3eda0767789a815","url":"https://api.github.com/users/MSOpenTech","html_url":"https://github.com/MSOpenTech","followers_url":"https://api.github.com/users/MSOpenTech/followers","following_url":"https://api.github.com/users/MSOpenTech/following{/other_user}","gists_url":"https://api.github.com/users/MSOpenTech/gists{/gist_id}","starred_url":"https://api.github.com/users/MSOpenTech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MSOpenTech/subscriptions","organizations_url":"https://api.github.com/users/MSOpenTech/orgs","repos_url":"https://api.github.com/users/MSOpenTech/repos","events_url":"https://api.github.com/users/MSOpenTech/events{/privacy}","received_events_url":"https://api.github.com/users/MSOpenTech/received_events","type":"Organization","site_admin":false},"repo":{"id":19624574,"name":"cordova-lib","full_name":"MSOpenTech/cordova-lib","owner":{"login":"MSOpenTech","id":1638184,"avatar_url":"https://avatars.githubusercontent.com/u/1638184?v=2","gravatar_id":"75752e740f4383e6f3eda0767789a815","url":"https://api.github.com/users/MSOpenTech","html_url":"https://github.com/MSOpenTech","followers_url":"https://api.github.com/users/MSOpenTech/followers","following_url":"https://api.github.com/users/MSOpenTech/following{/other_user}","gists_url":"https://api.github.com/users/MSOpenTech/gists{/gist_id}","starred_url":"https://api.github.com/users/MSOpenTech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MSOpenTech/subscriptions","organizations_url":"https://api.github.com/users/MSOpenTech/orgs","repos_url":"https://api.github.com/users/MSOpenTech/repos","events_url":"https://api.github.com/users/MSOpenTech/events{/privacy}","received_events_url":"https://api.github.com/users/MSOpenTech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MSOpenTech/cordova-lib","description":"Mirror of Apache Cordova","fork":true,"url":"https://api.github.com/repos/MSOpenTech/cordova-lib","forks_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/forks","keys_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/teams","hooks_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/hooks","issue_events_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/issues/events{/number}","events_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/events","assignees_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/assignees{/user}","branches_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/branches{/branch}","tags_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/tags","blobs_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/languages","stargazers_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/stargazers","contributors_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/contributors","subscribers_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/subscribers","subscription_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/subscription","commits_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/issues/comments/{number}","contents_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/contents/{+path}","compare_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/merges","archive_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/downloads","issues_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/issues{/number}","pulls_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/labels{/name}","releases_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/releases{/id}","created_at":"2014-05-09T20:30:32Z","updated_at":"2014-07-17T16:08:20Z","pushed_at":"2014-09-22T11:20:03Z","git_url":"git://github.com/MSOpenTech/cordova-lib.git","ssh_url":"git@github.com:MSOpenTech/cordova-lib.git","clone_url":"https://github.com/MSOpenTech/cordova-lib.git","svn_url":"https://github.com/MSOpenTech/cordova-lib","homepage":null,"size":43111,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"0f8972424c832377b3f4d73c47b02cfbd2fff025","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=2","gravatar_id":"a676c0bf448fcd49f588249ead719b4c","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":19524397,"name":"cordova-lib","full_name":"apache/cordova-lib","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=2","gravatar_id":"a676c0bf448fcd49f588249ead719b4c","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/cordova-lib","description":"Mirror of Apache Cordova","fork":false,"url":"https://api.github.com/repos/apache/cordova-lib","forks_url":"https://api.github.com/repos/apache/cordova-lib/forks","keys_url":"https://api.github.com/repos/apache/cordova-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/cordova-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/cordova-lib/teams","hooks_url":"https://api.github.com/repos/apache/cordova-lib/hooks","issue_events_url":"https://api.github.com/repos/apache/cordova-lib/issues/events{/number}","events_url":"https://api.github.com/repos/apache/cordova-lib/events","assignees_url":"https://api.github.com/repos/apache/cordova-lib/assignees{/user}","branches_url":"https://api.github.com/repos/apache/cordova-lib/branches{/branch}","tags_url":"https://api.github.com/repos/apache/cordova-lib/tags","blobs_url":"https://api.github.com/repos/apache/cordova-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/cordova-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/cordova-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/cordova-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/cordova-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/cordova-lib/languages","stargazers_url":"https://api.github.com/repos/apache/cordova-lib/stargazers","contributors_url":"https://api.github.com/repos/apache/cordova-lib/contributors","subscribers_url":"https://api.github.com/repos/apache/cordova-lib/subscribers","subscription_url":"https://api.github.com/repos/apache/cordova-lib/subscription","commits_url":"https://api.github.com/repos/apache/cordova-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/cordova-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/cordova-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/cordova-lib/issues/comments/{number}","contents_url":"https://api.github.com/repos/apache/cordova-lib/contents/{+path}","compare_url":"https://api.github.com/repos/apache/cordova-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/cordova-lib/merges","archive_url":"https://api.github.com/repos/apache/cordova-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/cordova-lib/downloads","issues_url":"https://api.github.com/repos/apache/cordova-lib/issues{/number}","pulls_url":"https://api.github.com/repos/apache/cordova-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/cordova-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/cordova-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/cordova-lib/labels{/name}","releases_url":"https://api.github.com/repos/apache/cordova-lib/releases{/id}","created_at":"2014-05-07T07:00:06Z","updated_at":"2014-09-15T08:41:13Z","pushed_at":"2014-09-18T20:08:07Z","git_url":"git://github.com/apache/cordova-lib.git","ssh_url":"git@github.com:apache/cordova-lib.git","clone_url":"https://github.com/apache/cordova-lib.git","svn_url":"https://github.com/apache/cordova-lib","homepage":null,"size":45548,"stargazers_count":13,"watchers_count":13,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":55,"mirror_url":"git://git.apache.org/cordova-lib.git","open_issues_count":19,"forks":55,"open_issues":19,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/cordova-lib/pulls/89"},"html":{"href":"https://github.com/apache/cordova-lib/pull/89"},"issue":{"href":"https://api.github.com/repos/apache/cordova-lib/issues/89"},"comments":{"href":"https://api.github.com/repos/apache/cordova-lib/issues/89/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/cordova-lib/pulls/89/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/cordova-lib/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/apache/cordova-lib/pulls/89/commits"},"statuses":{"href":"https://api.github.com/repos/apache/cordova-lib/statuses/f01e5b76ca67f728ce5680be252985574924e536"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":45,"deletions":56,"changed_files":1}}