GitHub PullRequestEvent at 2014-09-25 09:47:04
Repository: easy-app-tabs
Actor: ttaubert
Payload: {"action":"opened","number":9,"pull_request":{"url":"https://api.github.com/repos/supahgreg/easy-app-tabs/pulls/9","id":21771573,"html_url":"https://github.com/supahgreg/easy-app-tabs/pull/9","diff_url":"https://github.com/supahgreg/easy-app-tabs/pull/9.diff","patch_url":"https://github.com/supahgreg/easy-app-tabs/pull/9.patch","issue_url":"https://api.github.com/repos/supahgreg/easy-app-tabs/issues/9","number":9,"state":"open","locked":false,"title":"Convert to SDK-based add-on and simplify the code. Make it work with e10s.","user":{"login":"ttaubert","id":300895,"avatar_url":"https://avatars.githubusercontent.com/u/300895?v=2","gravatar_id":"","url":"https://api.github.com/users/ttaubert","html_url":"https://github.com/ttaubert","followers_url":"https://api.github.com/users/ttaubert/followers","following_url":"https://api.github.com/users/ttaubert/following{/other_user}","gists_url":"https://api.github.com/users/ttaubert/gists{/gist_id}","starred_url":"https://api.github.com/users/ttaubert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ttaubert/subscriptions","organizations_url":"https://api.github.com/users/ttaubert/orgs","repos_url":"https://api.github.com/users/ttaubert/repos","events_url":"https://api.github.com/users/ttaubert/events{/privacy}","received_events_url":"https://api.github.com/users/ttaubert/received_events","type":"User","site_admin":false},"body":"Hey Greg,\r\n\r\nI love your add-on and noticed that it unfortunately [behaves weird](https://bugzilla.mozilla.org/show_bug.cgi?id=1072821) with e10s. I took a look at the code, started to fix it, and would like to merge the following changes:\r\n\r\n1) I converted the whole add-on to be SDK-based to be able to use the nice SDK APIs. That's what the first changeset does.\r\n\r\n2) The second changeset uses the SDK's WindowTracker API to attach/remove event listeners to/from opened and closed windows. I seized the chance to convert the code to use two event listeners per window instead of having to maintain them per-tab. We can simply walk up the DOM tree until we find the tab the user clicked on.\r\n\r\nI did not change the behavior of the add-on, it should still work the same. I however did add myself to the list of contributors if that's okay :) I tested the add-on in Firefox 32 and Nightly (35) and it works fine.\r\n\r\nShould you wonder why I'm using a \"deprecated\" API (sdk/deprecated/window-utils) then that's because the new window/utils don't offer a similar WindowTracker API yet. That's however tracked in [bug 833011](https://bugzilla.mozilla.org/show_bug.cgi?id=833011) and I assume the deprecated API will not go away before that's fixed.\r\n\r\n- Tim","created_at":"2014-09-25T09:47:04Z","updated_at":"2014-09-25T09:47:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/supahgreg/easy-app-tabs/pulls/9/commits","review_comments_url":"https://api.github.com/repos/supahgreg/easy-app-tabs/pulls/9/comments","review_comment_url":"https://api.github.com/repos/supahgreg/easy-app-tabs/pulls/comments/{number}","comments_url":"https://api.github.com/repos/supahgreg/easy-app-tabs/issues/9/comments","statuses_url":"https://api.github.com/repos/supahgreg/easy-app-tabs/statuses/400c33d818ae0fe49adcbd936de65c33d596d775","head":{"label":"ttaubert:e10s","ref":"e10s","sha":"400c33d818ae0fe49adcbd936de65c33d596d775","user":{"login":"ttaubert","id":300895,"avatar_url":"https://avatars.githubusercontent.com/u/300895?v=2","gravatar_id":"","url":"https://api.github.com/users/ttaubert","html_url":"https://github.com/ttaubert","followers_url":"https://api.github.com/users/ttaubert/followers","following_url":"https://api.github.com/users/ttaubert/following{/other_user}","gists_url":"https://api.github.com/users/ttaubert/gists{/gist_id}","starred_url":"https://api.github.com/users/ttaubert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ttaubert/subscriptions","organizations_url":"https://api.github.com/users/ttaubert/orgs","repos_url":"https://api.github.com/users/ttaubert/repos","events_url":"https://api.github.com/users/ttaubert/events{/privacy}","received_events_url":"https://api.github.com/users/ttaubert/received_events","type":"User","site_admin":false},"repo":{"id":24450170,"name":"easy-app-tabs","full_name":"ttaubert/easy-app-tabs","owner":{"login":"ttaubert","id":300895,"avatar_url":"https://avatars.githubusercontent.com/u/300895?v=2","gravatar_id":"","url":"https://api.github.com/users/ttaubert","html_url":"https://github.com/ttaubert","followers_url":"https://api.github.com/users/ttaubert/followers","following_url":"https://api.github.com/users/ttaubert/following{/other_user}","gists_url":"https://api.github.com/users/ttaubert/gists{/gist_id}","starred_url":"https://api.github.com/users/ttaubert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ttaubert/subscriptions","organizations_url":"https://api.github.com/users/ttaubert/orgs","repos_url":"https://api.github.com/users/ttaubert/repos","events_url":"https://api.github.com/users/ttaubert/events{/privacy}","received_events_url":"https://api.github.com/users/ttaubert/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ttaubert/easy-app-tabs","description":"A Firefox extension which allows you to double-click a tab to convert it to/from an App Tab.","fork":true,"url":"https://api.github.com/repos/ttaubert/easy-app-tabs","forks_url":"https://api.github.com/repos/ttaubert/easy-app-tabs/forks","keys_url":"https://api.github.com/repos/ttaubert/easy-app-tabs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ttaubert/easy-app-tabs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ttaubert/easy-app-tabs/teams","hooks_url":"https://api.github.com/repos/ttaubert/easy-app-tabs/hooks","issue_events_url":"https://api.github.com/repos/ttaubert/easy-app-tabs/issues/events{/number}","events_url":"https://api.github.com/repos/ttaubert/easy-app-tabs/events","assignees_url":"https://api.github.com/repos/ttaubert/easy-app-tabs/assignees{/user}","branches_url":"https://api.github.com/repos/ttaubert/easy-app-tabs/branches{/branch}","tags_url":"https://api.github.com/repos/ttaubert/easy-app-tabs/tags","blobs_url":"https://api.github.com/repos/ttaubert/easy-app-tabs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ttaubert/easy-app-tabs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ttaubert/easy-app-tabs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ttaubert/easy-app-tabs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ttaubert/easy-app-tabs/statuses/{sha}","languages_url":"https://api.github.com/repos/ttaubert/easy-app-tabs/languages","stargazers_url":"https://api.github.com/repos/ttaubert/easy-app-tabs/stargazers","contributors_url":"https://api.github.com/repos/ttaubert/easy-app-tabs/contributors","subscribers_url":"https://api.github.com/repos/ttaubert/easy-app-tabs/subscribers","subscription_url":"https://api.github.com/repos/ttaubert/easy-app-tabs/subscription","commits_url":"https://api.github.com/repos/ttaubert/easy-app-tabs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ttaubert/easy-app-tabs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ttaubert/easy-app-tabs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ttaubert/easy-app-tabs/issues/comments/{number}","contents_url":"https://api.github.com/repos/ttaubert/easy-app-tabs/contents/{+path}","compare_url":"https://api.github.com/repos/ttaubert/easy-app-tabs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ttaubert/easy-app-tabs/merges","archive_url":"https://api.github.com/repos/ttaubert/easy-app-tabs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ttaubert/easy-app-tabs/downloads","issues_url":"https://api.github.com/repos/ttaubert/easy-app-tabs/issues{/number}","pulls_url":"https://api.github.com/repos/ttaubert/easy-app-tabs/pulls{/number}","milestones_url":"https://api.github.com/repos/ttaubert/easy-app-tabs/milestones{/number}","notifications_url":"https://api.github.com/repos/ttaubert/easy-app-tabs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ttaubert/easy-app-tabs/labels{/name}","releases_url":"https://api.github.com/repos/ttaubert/easy-app-tabs/releases{/id}","created_at":"2014-09-25T08:35:36Z","updated_at":"2014-02-05T17:00:15Z","pushed_at":"2014-09-25T09:36:10Z","git_url":"git://github.com/ttaubert/easy-app-tabs.git","ssh_url":"git@github.com:ttaubert/easy-app-tabs.git","clone_url":"https://github.com/ttaubert/easy-app-tabs.git","svn_url":"https://github.com/ttaubert/easy-app-tabs","homepage":"https://addons.mozilla.org/firefox/addon/easy-app-tabs/","size":81,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"supahgreg:master","ref":"master","sha":"116dad4aea923cdc40aaf65a71285a838fdf5e9d","user":{"login":"supahgreg","id":288958,"avatar_url":"https://avatars.githubusercontent.com/u/288958?v=2","gravatar_id":"","url":"https://api.github.com/users/supahgreg","html_url":"https://github.com/supahgreg","followers_url":"https://api.github.com/users/supahgreg/followers","following_url":"https://api.github.com/users/supahgreg/following{/other_user}","gists_url":"https://api.github.com/users/supahgreg/gists{/gist_id}","starred_url":"https://api.github.com/users/supahgreg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/supahgreg/subscriptions","organizations_url":"https://api.github.com/users/supahgreg/orgs","repos_url":"https://api.github.com/users/supahgreg/repos","events_url":"https://api.github.com/users/supahgreg/events{/privacy}","received_events_url":"https://api.github.com/users/supahgreg/received_events","type":"User","site_admin":false},"repo":{"id":1180291,"name":"easy-app-tabs","full_name":"supahgreg/easy-app-tabs","owner":{"login":"supahgreg","id":288958,"avatar_url":"https://avatars.githubusercontent.com/u/288958?v=2","gravatar_id":"","url":"https://api.github.com/users/supahgreg","html_url":"https://github.com/supahgreg","followers_url":"https://api.github.com/users/supahgreg/followers","following_url":"https://api.github.com/users/supahgreg/following{/other_user}","gists_url":"https://api.github.com/users/supahgreg/gists{/gist_id}","starred_url":"https://api.github.com/users/supahgreg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/supahgreg/subscriptions","organizations_url":"https://api.github.com/users/supahgreg/orgs","repos_url":"https://api.github.com/users/supahgreg/repos","events_url":"https://api.github.com/users/supahgreg/events{/privacy}","received_events_url":"https://api.github.com/users/supahgreg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/supahgreg/easy-app-tabs","description":"A Firefox extension which allows you to double-click a tab to convert it to/from an App Tab.","fork":false,"url":"https://api.github.com/repos/supahgreg/easy-app-tabs","forks_url":"https://api.github.com/repos/supahgreg/easy-app-tabs/forks","keys_url":"https://api.github.com/repos/supahgreg/easy-app-tabs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/supahgreg/easy-app-tabs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/supahgreg/easy-app-tabs/teams","hooks_url":"https://api.github.com/repos/supahgreg/easy-app-tabs/hooks","issue_events_url":"https://api.github.com/repos/supahgreg/easy-app-tabs/issues/events{/number}","events_url":"https://api.github.com/repos/supahgreg/easy-app-tabs/events","assignees_url":"https://api.github.com/repos/supahgreg/easy-app-tabs/assignees{/user}","branches_url":"https://api.github.com/repos/supahgreg/easy-app-tabs/branches{/branch}","tags_url":"https://api.github.com/repos/supahgreg/easy-app-tabs/tags","blobs_url":"https://api.github.com/repos/supahgreg/easy-app-tabs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/supahgreg/easy-app-tabs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/supahgreg/easy-app-tabs/git/refs{/sha}","trees_url":"https://api.github.com/repos/supahgreg/easy-app-tabs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/supahgreg/easy-app-tabs/statuses/{sha}","languages_url":"https://api.github.com/repos/supahgreg/easy-app-tabs/languages","stargazers_url":"https://api.github.com/repos/supahgreg/easy-app-tabs/stargazers","contributors_url":"https://api.github.com/repos/supahgreg/easy-app-tabs/contributors","subscribers_url":"https://api.github.com/repos/supahgreg/easy-app-tabs/subscribers","subscription_url":"https://api.github.com/repos/supahgreg/easy-app-tabs/subscription","commits_url":"https://api.github.com/repos/supahgreg/easy-app-tabs/commits{/sha}","git_commits_url":"https://api.github.com/repos/supahgreg/easy-app-tabs/git/commits{/sha}","comments_url":"https://api.github.com/repos/supahgreg/easy-app-tabs/comments{/number}","issue_comment_url":"https://api.github.com/repos/supahgreg/easy-app-tabs/issues/comments/{number}","contents_url":"https://api.github.com/repos/supahgreg/easy-app-tabs/contents/{+path}","compare_url":"https://api.github.com/repos/supahgreg/easy-app-tabs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/supahgreg/easy-app-tabs/merges","archive_url":"https://api.github.com/repos/supahgreg/easy-app-tabs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/supahgreg/easy-app-tabs/downloads","issues_url":"https://api.github.com/repos/supahgreg/easy-app-tabs/issues{/number}","pulls_url":"https://api.github.com/repos/supahgreg/easy-app-tabs/pulls{/number}","milestones_url":"https://api.github.com/repos/supahgreg/easy-app-tabs/milestones{/number}","notifications_url":"https://api.github.com/repos/supahgreg/easy-app-tabs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/supahgreg/easy-app-tabs/labels{/name}","releases_url":"https://api.github.com/repos/supahgreg/easy-app-tabs/releases{/id}","created_at":"2010-12-18T19:07:40Z","updated_at":"2014-02-05T17:00:15Z","pushed_at":"2013-05-05T14:46:49Z","git_url":"git://github.com/supahgreg/easy-app-tabs.git","ssh_url":"git@github.com:supahgreg/easy-app-tabs.git","clone_url":"https://github.com/supahgreg/easy-app-tabs.git","svn_url":"https://github.com/supahgreg/easy-app-tabs","homepage":"https://addons.mozilla.org/firefox/addon/easy-app-tabs/","size":109,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/supahgreg/easy-app-tabs/pulls/9"},"html":{"href":"https://github.com/supahgreg/easy-app-tabs/pull/9"},"issue":{"href":"https://api.github.com/repos/supahgreg/easy-app-tabs/issues/9"},"comments":{"href":"https://api.github.com/repos/supahgreg/easy-app-tabs/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/supahgreg/easy-app-tabs/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/supahgreg/easy-app-tabs/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/supahgreg/easy-app-tabs/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/supahgreg/easy-app-tabs/statuses/400c33d818ae0fe49adcbd936de65c33d596d775"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":90,"deletions":129,"changed_files":4}}