GitHub PullRequestReviewCommentEvent at 2014-07-09 15:24:03
Repository: Android-Terminal-Emulator
Actor: jackpal
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/jackpal/Android-Terminal-Emulator/pulls/comments/14715814","id":14715814,"diff_hunk":"@@ -0,0 +1,7 @@\n+<?xml version=\"1.0\" encoding=\"utf-8\"?>","path":"libraries/emulatorview/res/drawable/btn.xml","position":1,"original_position":1,"commit_id":"2b792187c8b3b6e476cf3088c92e78c3314328bb","original_commit_id":"2b792187c8b3b6e476cf3088c92e78c3314328bb","user":{"login":"jackpal","id":175575,"avatar_url":"https://avatars.githubusercontent.com/u/175575?","gravatar_id":"f540093aacfad36d9fe206550ad1be70","url":"https://api.github.com/users/jackpal","html_url":"https://github.com/jackpal","followers_url":"https://api.github.com/users/jackpal/followers","following_url":"https://api.github.com/users/jackpal/following{/other_user}","gists_url":"https://api.github.com/users/jackpal/gists{/gist_id}","starred_url":"https://api.github.com/users/jackpal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackpal/subscriptions","organizations_url":"https://api.github.com/users/jackpal/orgs","repos_url":"https://api.github.com/users/jackpal/repos","events_url":"https://api.github.com/users/jackpal/events{/privacy}","received_events_url":"https://api.github.com/users/jackpal/received_events","type":"User","site_admin":false},"body":"It looks like your pull request has several unrelated features. Please split the pull request into several patches, one for each feature. I see there are new \"button\" graphics, and also a new \"function key\" feature.","created_at":"2014-07-09T15:24:03Z","updated_at":"2014-07-09T15:24:03Z","html_url":"https://github.com/jackpal/Android-Terminal-Emulator/pull/347#discussion_r14715814","pull_request_url":"https://api.github.com/repos/jackpal/Android-Terminal-Emulator/pulls/347","_links":{"self":{"href":"https://api.github.com/repos/jackpal/Android-Terminal-Emulator/pulls/comments/14715814"},"html":{"href":"https://github.com/jackpal/Android-Terminal-Emulator/pull/347#discussion_r14715814"},"pull_request":{"href":"https://api.github.com/repos/jackpal/Android-Terminal-Emulator/pulls/347"}}},"pull_request":{"url":"https://api.github.com/repos/jackpal/Android-Terminal-Emulator/pulls/347","id":18146765,"html_url":"https://github.com/jackpal/Android-Terminal-Emulator/pull/347","diff_url":"https://github.com/jackpal/Android-Terminal-Emulator/pull/347.diff","patch_url":"https://github.com/jackpal/Android-Terminal-Emulator/pull/347.patch","issue_url":"https://api.github.com/repos/jackpal/Android-Terminal-Emulator/issues/347","number":347,"state":"open","title":"Add shortcut keys","user":{"login":"maoabc","id":3536343,"avatar_url":"https://avatars.githubusercontent.com/u/3536343?","gravatar_id":"84f4fe9fc96b3fdd3ca7e301b3ba9e3b","url":"https://api.github.com/users/maoabc","html_url":"https://github.com/maoabc","followers_url":"https://api.github.com/users/maoabc/followers","following_url":"https://api.github.com/users/maoabc/following{/other_user}","gists_url":"https://api.github.com/users/maoabc/gists{/gist_id}","starred_url":"https://api.github.com/users/maoabc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maoabc/subscriptions","organizations_url":"https://api.github.com/users/maoabc/orgs","repos_url":"https://api.github.com/users/maoabc/repos","events_url":"https://api.github.com/users/maoabc/events{/privacy}","received_events_url":"https://api.github.com/users/maoabc/received_events","type":"User","site_admin":false},"body":"dslkjskl","created_at":"2014-07-09T08:12:08Z","updated_at":"2014-07-09T15:24:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jackpal/Android-Terminal-Emulator/pulls/347/commits","review_comments_url":"https://api.github.com/repos/jackpal/Android-Terminal-Emulator/pulls/347/comments","review_comment_url":"https://api.github.com/repos/jackpal/Android-Terminal-Emulator/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jackpal/Android-Terminal-Emulator/issues/347/comments","statuses_url":"https://api.github.com/repos/jackpal/Android-Terminal-Emulator/statuses/2b792187c8b3b6e476cf3088c92e78c3314328bb","head":{"label":"maoabc:ms2","ref":"ms2","sha":"2b792187c8b3b6e476cf3088c92e78c3314328bb","user":{"login":"maoabc","id":3536343,"avatar_url":"https://avatars.githubusercontent.com/u/3536343?","gravatar_id":"84f4fe9fc96b3fdd3ca7e301b3ba9e3b","url":"https://api.github.com/users/maoabc","html_url":"https://github.com/maoabc","followers_url":"https://api.github.com/users/maoabc/followers","following_url":"https://api.github.com/users/maoabc/following{/other_user}","gists_url":"https://api.github.com/users/maoabc/gists{/gist_id}","starred_url":"https://api.github.com/users/maoabc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maoabc/subscriptions","organizations_url":"https://api.github.com/users/maoabc/orgs","repos_url":"https://api.github.com/users/maoabc/repos","events_url":"https://api.github.com/users/maoabc/events{/privacy}","received_events_url":"https://api.github.com/users/maoabc/received_events","type":"User","site_admin":false},"repo":{"id":9211014,"name":"Android-Terminal-Emulator","full_name":"maoabc/Android-Terminal-Emulator","owner":{"login":"maoabc","id":3536343,"avatar_url":"https://avatars.githubusercontent.com/u/3536343?","gravatar_id":"84f4fe9fc96b3fdd3ca7e301b3ba9e3b","url":"https://api.github.com/users/maoabc","html_url":"https://github.com/maoabc","followers_url":"https://api.github.com/users/maoabc/followers","following_url":"https://api.github.com/users/maoabc/following{/other_user}","gists_url":"https://api.github.com/users/maoabc/gists{/gist_id}","starred_url":"https://api.github.com/users/maoabc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maoabc/subscriptions","organizations_url":"https://api.github.com/users/maoabc/orgs","repos_url":"https://api.github.com/users/maoabc/repos","events_url":"https://api.github.com/users/maoabc/events{/privacy}","received_events_url":"https://api.github.com/users/maoabc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maoabc/Android-Terminal-Emulator","description":"A VT-100 terminal emulator for the Android OS","fork":true,"url":"https://api.github.com/repos/maoabc/Android-Terminal-Emulator","forks_url":"https://api.github.com/repos/maoabc/Android-Terminal-Emulator/forks","keys_url":"https://api.github.com/repos/maoabc/Android-Terminal-Emulator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maoabc/Android-Terminal-Emulator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maoabc/Android-Terminal-Emulator/teams","hooks_url":"https://api.github.com/repos/maoabc/Android-Terminal-Emulator/hooks","issue_events_url":"https://api.github.com/repos/maoabc/Android-Terminal-Emulator/issues/events{/number}","events_url":"https://api.github.com/repos/maoabc/Android-Terminal-Emulator/events","assignees_url":"https://api.github.com/repos/maoabc/Android-Terminal-Emulator/assignees{/user}","branches_url":"https://api.github.com/repos/maoabc/Android-Terminal-Emulator/branches{/branch}","tags_url":"https://api.github.com/repos/maoabc/Android-Terminal-Emulator/tags","blobs_url":"https://api.github.com/repos/maoabc/Android-Terminal-Emulator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maoabc/Android-Terminal-Emulator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maoabc/Android-Terminal-Emulator/git/refs{/sha}","trees_url":"https://api.github.com/repos/maoabc/Android-Terminal-Emulator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maoabc/Android-Terminal-Emulator/statuses/{sha}","languages_url":"https://api.github.com/repos/maoabc/Android-Terminal-Emulator/languages","stargazers_url":"https://api.github.com/repos/maoabc/Android-Terminal-Emulator/stargazers","contributors_url":"https://api.github.com/repos/maoabc/Android-Terminal-Emulator/contributors","subscribers_url":"https://api.github.com/repos/maoabc/Android-Terminal-Emulator/subscribers","subscription_url":"https://api.github.com/repos/maoabc/Android-Terminal-Emulator/subscription","commits_url":"https://api.github.com/repos/maoabc/Android-Terminal-Emulator/commits{/sha}","git_commits_url":"https://api.github.com/repos/maoabc/Android-Terminal-Emulator/git/commits{/sha}","comments_url":"https://api.github.com/repos/maoabc/Android-Terminal-Emulator/comments{/number}","issue_comment_url":"https://api.github.com/repos/maoabc/Android-Terminal-Emulator/issues/comments/{number}","contents_url":"https://api.github.com/repos/maoabc/Android-Terminal-Emulator/contents/{+path}","compare_url":"https://api.github.com/repos/maoabc/Android-Terminal-Emulator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maoabc/Android-Terminal-Emulator/merges","archive_url":"https://api.github.com/repos/maoabc/Android-Terminal-Emulator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maoabc/Android-Terminal-Emulator/downloads","issues_url":"https://api.github.com/repos/maoabc/Android-Terminal-Emulator/issues{/number}","pulls_url":"https://api.github.com/repos/maoabc/Android-Terminal-Emulator/pulls{/number}","milestones_url":"https://api.github.com/repos/maoabc/Android-Terminal-Emulator/milestones{/number}","notifications_url":"https://api.github.com/repos/maoabc/Android-Terminal-Emulator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maoabc/Android-Terminal-Emulator/labels{/name}","releases_url":"https://api.github.com/repos/maoabc/Android-Terminal-Emulator/releases{/id}","created_at":"2013-04-04T04:29:45Z","updated_at":"2014-03-30T19:45:18Z","pushed_at":"2014-07-09T08:42:06Z","git_url":"git://github.com/maoabc/Android-Terminal-Emulator.git","ssh_url":"git@github.com:maoabc/Android-Terminal-Emulator.git","clone_url":"https://github.com/maoabc/Android-Terminal-Emulator.git","svn_url":"https://github.com/maoabc/Android-Terminal-Emulator","homepage":"","size":1923,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"ms2"}},"base":{"label":"jackpal:master","ref":"master","sha":"c730f70efb28296c0ab2f7e32c1673978730df8f","user":{"login":"jackpal","id":175575,"avatar_url":"https://avatars.githubusercontent.com/u/175575?","gravatar_id":"f540093aacfad36d9fe206550ad1be70","url":"https://api.github.com/users/jackpal","html_url":"https://github.com/jackpal","followers_url":"https://api.github.com/users/jackpal/followers","following_url":"https://api.github.com/users/jackpal/following{/other_user}","gists_url":"https://api.github.com/users/jackpal/gists{/gist_id}","starred_url":"https://api.github.com/users/jackpal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackpal/subscriptions","organizations_url":"https://api.github.com/users/jackpal/orgs","repos_url":"https://api.github.com/users/jackpal/repos","events_url":"https://api.github.com/users/jackpal/events{/privacy}","received_events_url":"https://api.github.com/users/jackpal/received_events","type":"User","site_admin":false},"repo":{"id":887840,"name":"Android-Terminal-Emulator","full_name":"jackpal/Android-Terminal-Emulator","owner":{"login":"jackpal","id":175575,"avatar_url":"https://avatars.githubusercontent.com/u/175575?","gravatar_id":"f540093aacfad36d9fe206550ad1be70","url":"https://api.github.com/users/jackpal","html_url":"https://github.com/jackpal","followers_url":"https://api.github.com/users/jackpal/followers","following_url":"https://api.github.com/users/jackpal/following{/other_user}","gists_url":"https://api.github.com/users/jackpal/gists{/gist_id}","starred_url":"https://api.github.com/users/jackpal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackpal/subscriptions","organizations_url":"https://api.github.com/users/jackpal/orgs","repos_url":"https://api.github.com/users/jackpal/repos","events_url":"https://api.github.com/users/jackpal/events{/privacy}","received_events_url":"https://api.github.com/users/jackpal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jackpal/Android-Terminal-Emulator","description":"A VT-100 terminal emulator for the Android OS","fork":false,"url":"https://api.github.com/repos/jackpal/Android-Terminal-Emulator","forks_url":"https://api.github.com/repos/jackpal/Android-Terminal-Emulator/forks","keys_url":"https://api.github.com/repos/jackpal/Android-Terminal-Emulator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jackpal/Android-Terminal-Emulator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jackpal/Android-Terminal-Emulator/teams","hooks_url":"https://api.github.com/repos/jackpal/Android-Terminal-Emulator/hooks","issue_events_url":"https://api.github.com/repos/jackpal/Android-Terminal-Emulator/issues/events{/number}","events_url":"https://api.github.com/repos/jackpal/Android-Terminal-Emulator/events","assignees_url":"https://api.github.com/repos/jackpal/Android-Terminal-Emulator/assignees{/user}","branches_url":"https://api.github.com/repos/jackpal/Android-Terminal-Emulator/branches{/branch}","tags_url":"https://api.github.com/repos/jackpal/Android-Terminal-Emulator/tags","blobs_url":"https://api.github.com/repos/jackpal/Android-Terminal-Emulator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jackpal/Android-Terminal-Emulator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jackpal/Android-Terminal-Emulator/git/refs{/sha}","trees_url":"https://api.github.com/repos/jackpal/Android-Terminal-Emulator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jackpal/Android-Terminal-Emulator/statuses/{sha}","languages_url":"https://api.github.com/repos/jackpal/Android-Terminal-Emulator/languages","stargazers_url":"https://api.github.com/repos/jackpal/Android-Terminal-Emulator/stargazers","contributors_url":"https://api.github.com/repos/jackpal/Android-Terminal-Emulator/contributors","subscribers_url":"https://api.github.com/repos/jackpal/Android-Terminal-Emulator/subscribers","subscription_url":"https://api.github.com/repos/jackpal/Android-Terminal-Emulator/subscription","commits_url":"https://api.github.com/repos/jackpal/Android-Terminal-Emulator/commits{/sha}","git_commits_url":"https://api.github.com/repos/jackpal/Android-Terminal-Emulator/git/commits{/sha}","comments_url":"https://api.github.com/repos/jackpal/Android-Terminal-Emulator/comments{/number}","issue_comment_url":"https://api.github.com/repos/jackpal/Android-Terminal-Emulator/issues/comments/{number}","contents_url":"https://api.github.com/repos/jackpal/Android-Terminal-Emulator/contents/{+path}","compare_url":"https://api.github.com/repos/jackpal/Android-Terminal-Emulator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jackpal/Android-Terminal-Emulator/merges","archive_url":"https://api.github.com/repos/jackpal/Android-Terminal-Emulator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jackpal/Android-Terminal-Emulator/downloads","issues_url":"https://api.github.com/repos/jackpal/Android-Terminal-Emulator/issues{/number}","pulls_url":"https://api.github.com/repos/jackpal/Android-Terminal-Emulator/pulls{/number}","milestones_url":"https://api.github.com/repos/jackpal/Android-Terminal-Emulator/milestones{/number}","notifications_url":"https://api.github.com/repos/jackpal/Android-Terminal-Emulator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jackpal/Android-Terminal-Emulator/labels{/name}","releases_url":"https://api.github.com/repos/jackpal/Android-Terminal-Emulator/releases{/id}","created_at":"2010-09-04T13:48:00Z","updated_at":"2014-07-08T21:17:23Z","pushed_at":"2014-06-30T17:01:20Z","git_url":"git://github.com/jackpal/Android-Terminal-Emulator.git","ssh_url":"git@github.com:jackpal/Android-Terminal-Emulator.git","clone_url":"https://github.com/jackpal/Android-Terminal-Emulator.git","svn_url":"https://github.com/jackpal/Android-Terminal-Emulator","homepage":"","size":10017,"stargazers_count":615,"watchers_count":615,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":274,"mirror_url":null,"open_issues_count":97,"forks":274,"open_issues":97,"watchers":615,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jackpal/Android-Terminal-Emulator/pulls/347"},"html":{"href":"https://github.com/jackpal/Android-Terminal-Emulator/pull/347"},"issue":{"href":"https://api.github.com/repos/jackpal/Android-Terminal-Emulator/issues/347"},"comments":{"href":"https://api.github.com/repos/jackpal/Android-Terminal-Emulator/issues/347/comments"},"review_comments":{"href":"https://api.github.com/repos/jackpal/Android-Terminal-Emulator/pulls/347/comments"},"review_comment":{"href":"https://api.github.com/repos/jackpal/Android-Terminal-Emulator/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jackpal/Android-Terminal-Emulator/pulls/347/commits"},"statuses":{"href":"https://api.github.com/repos/jackpal/Android-Terminal-Emulator/statuses/2b792187c8b3b6e476cf3088c92e78c3314328bb"}}}}