GitHub PullRequestReviewCommentEvent at 2014-10-31 17:02:27
Repository: agile-course-practice
Actor: AoD314
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/UNN-VMK-Software/agile-course-practice/pulls/comments/19679173","id":19679173,"diff_hunk":"@@ -0,0 +1,217 @@\n+package ru.unn.agile.Deque.Model;\n+\n+import org.junit.After;\n+import org.junit.Before;\n+import org.junit.Test;\n+\n+import java.util.ArrayList;\n+import java.util.List;\n+\n+import static org.junit.Assert.*;\n+\n+public class DequeTest {\n+    private Deque<Integer> deque;\n+\n+    @Before\n+    public void setUp() {\n+        deque = Deque.create();\n+    }\n+\n+    @After\n+    public void tearDown() {\n+        deque = null;\n+    }\n+\n+    @Test\n+    public void isNewlyCreatedDequeEmpty() {\n+        assertTrue(deque.isEmpty());\n+    }\n+\n+    @Test\n+    public void isDequeNotEmptyAfterAddFirst() {\n+        deque.addFirst(1);\n+        assertFalse(deque.isEmpty());\n+    }\n+\n+    @Test\n+    public void isDequeNotEmptyAfterAddLast() {\n+        deque.addLast(1);\n+        assertFalse(deque.isEmpty());\n+    }\n+\n+    @Test(expected = NullPointerException.class)\n+    public void cannotAddNullItemToHead() {\n+        deque.addFirst(null);\n+    }\n+\n+    @Test(expected = NullPointerException.class)\n+    public void cannotAddNullItemToTail() {\n+        deque.addLast(null);\n+    }\n+\n+    @Test\n+    public void canAddItemToHead() {\n+        int itemToAdd = 1, firstInDeque = 0;","path":"code/vilchinskii-aleksandr/Model/src/test/ru/unn/agile/Deque/Model/DequeTest.java","position":54,"original_position":54,"commit_id":"7e9538343007dc310e263b98a840e5ba7fcf50f9","original_commit_id":"7e9538343007dc310e263b98a840e5ba7fcf50f9","user":{"login":"AoD314","id":437072,"avatar_url":"https://avatars.githubusercontent.com/u/437072?v=2","gravatar_id":"","url":"https://api.github.com/users/AoD314","html_url":"https://github.com/AoD314","followers_url":"https://api.github.com/users/AoD314/followers","following_url":"https://api.github.com/users/AoD314/following{/other_user}","gists_url":"https://api.github.com/users/AoD314/gists{/gist_id}","starred_url":"https://api.github.com/users/AoD314/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AoD314/subscriptions","organizations_url":"https://api.github.com/users/AoD314/orgs","repos_url":"https://api.github.com/users/AoD314/repos","events_url":"https://api.github.com/users/AoD314/events{/privacy}","received_events_url":"https://api.github.com/users/AoD314/received_events","type":"User","site_admin":false},"body":"зачем так запутывать код?\r\n```java\r\npublic void canAddItemToHead() {\r\n    int itemToAdd = 1;\r\n    deque.addFirst(itemToAdd);\r\n    assertEquals(itemToAdd, deque.getFirst());\r\n}\r\n```\r\n\r\nразве так не проще?","created_at":"2014-10-31T17:02:27Z","updated_at":"2014-10-31T17:02:27Z","html_url":"https://github.com/UNN-VMK-Software/agile-course-practice/pull/55#discussion_r19679173","pull_request_url":"https://api.github.com/repos/UNN-VMK-Software/agile-course-practice/pulls/55","_links":{"self":{"href":"https://api.github.com/repos/UNN-VMK-Software/agile-course-practice/pulls/comments/19679173"},"html":{"href":"https://github.com/UNN-VMK-Software/agile-course-practice/pull/55#discussion_r19679173"},"pull_request":{"href":"https://api.github.com/repos/UNN-VMK-Software/agile-course-practice/pulls/55"}}},"pull_request":{"url":"https://api.github.com/repos/UNN-VMK-Software/agile-course-practice/pulls/55","id":23344619,"html_url":"https://github.com/UNN-VMK-Software/agile-course-practice/pull/55","diff_url":"https://github.com/UNN-VMK-Software/agile-course-practice/pull/55.diff","patch_url":"https://github.com/UNN-VMK-Software/agile-course-practice/pull/55.patch","issue_url":"https://api.github.com/repos/UNN-VMK-Software/agile-course-practice/issues/55","number":55,"state":"open","locked":false,"title":"Вильчинский - Лабораторная работа #1","user":{"login":"VVillwin","id":1944314,"avatar_url":"https://avatars.githubusercontent.com/u/1944314?v=2","gravatar_id":"","url":"https://api.github.com/users/VVillwin","html_url":"https://github.com/VVillwin","followers_url":"https://api.github.com/users/VVillwin/followers","following_url":"https://api.github.com/users/VVillwin/following{/other_user}","gists_url":"https://api.github.com/users/VVillwin/gists{/gist_id}","starred_url":"https://api.github.com/users/VVillwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VVillwin/subscriptions","organizations_url":"https://api.github.com/users/VVillwin/orgs","repos_url":"https://api.github.com/users/VVillwin/repos","events_url":"https://api.github.com/users/VVillwin/events{/privacy}","received_events_url":"https://api.github.com/users/VVillwin/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-10-25T22:36:50Z","updated_at":"2014-10-31T17:02:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc0c6cc78117b602792fb1aa03524540825d1281","assignee":{"login":"Daniil-Osokin","id":2491976,"avatar_url":"https://avatars.githubusercontent.com/u/2491976?v=2","gravatar_id":"","url":"https://api.github.com/users/Daniil-Osokin","html_url":"https://github.com/Daniil-Osokin","followers_url":"https://api.github.com/users/Daniil-Osokin/followers","following_url":"https://api.github.com/users/Daniil-Osokin/following{/other_user}","gists_url":"https://api.github.com/users/Daniil-Osokin/gists{/gist_id}","starred_url":"https://api.github.com/users/Daniil-Osokin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Daniil-Osokin/subscriptions","organizations_url":"https://api.github.com/users/Daniil-Osokin/orgs","repos_url":"https://api.github.com/users/Daniil-Osokin/repos","events_url":"https://api.github.com/users/Daniil-Osokin/events{/privacy}","received_events_url":"https://api.github.com/users/Daniil-Osokin/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/UNN-VMK-Software/agile-course-practice/milestones/5","labels_url":"https://api.github.com/repos/UNN-VMK-Software/agile-course-practice/milestones/5/labels","id":798051,"number":5,"title":"Lab 1","description":"","creator":{"login":"kirill-kornyakov","id":1688526,"avatar_url":"https://avatars.githubusercontent.com/u/1688526?v=2","gravatar_id":"","url":"https://api.github.com/users/kirill-kornyakov","html_url":"https://github.com/kirill-kornyakov","followers_url":"https://api.github.com/users/kirill-kornyakov/followers","following_url":"https://api.github.com/users/kirill-kornyakov/following{/other_user}","gists_url":"https://api.github.com/users/kirill-kornyakov/gists{/gist_id}","starred_url":"https://api.github.com/users/kirill-kornyakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirill-kornyakov/subscriptions","organizations_url":"https://api.github.com/users/kirill-kornyakov/orgs","repos_url":"https://api.github.com/users/kirill-kornyakov/repos","events_url":"https://api.github.com/users/kirill-kornyakov/events{/privacy}","received_events_url":"https://api.github.com/users/kirill-kornyakov/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":2,"state":"open","created_at":"2014-09-22T10:28:40Z","updated_at":"2014-10-31T09:31:49Z","due_on":"2014-11-02T07:00:00Z"},"commits_url":"https://api.github.com/repos/UNN-VMK-Software/agile-course-practice/pulls/55/commits","review_comments_url":"https://api.github.com/repos/UNN-VMK-Software/agile-course-practice/pulls/55/comments","review_comment_url":"https://api.github.com/repos/UNN-VMK-Software/agile-course-practice/pulls/comments/{number}","comments_url":"https://api.github.com/repos/UNN-VMK-Software/agile-course-practice/issues/55/comments","statuses_url":"https://api.github.com/repos/UNN-VMK-Software/agile-course-practice/statuses/7e9538343007dc310e263b98a840e5ba7fcf50f9","head":{"label":"VVillwin:lab1-tdd-deque","ref":"lab1-tdd-deque","sha":"7e9538343007dc310e263b98a840e5ba7fcf50f9","user":{"login":"VVillwin","id":1944314,"avatar_url":"https://avatars.githubusercontent.com/u/1944314?v=2","gravatar_id":"","url":"https://api.github.com/users/VVillwin","html_url":"https://github.com/VVillwin","followers_url":"https://api.github.com/users/VVillwin/followers","following_url":"https://api.github.com/users/VVillwin/following{/other_user}","gists_url":"https://api.github.com/users/VVillwin/gists{/gist_id}","starred_url":"https://api.github.com/users/VVillwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VVillwin/subscriptions","organizations_url":"https://api.github.com/users/VVillwin/orgs","repos_url":"https://api.github.com/users/VVillwin/repos","events_url":"https://api.github.com/users/VVillwin/events{/privacy}","received_events_url":"https://api.github.com/users/VVillwin/received_events","type":"User","site_admin":false},"repo":{"id":24508683,"name":"agile-course-practice","full_name":"VVillwin/agile-course-practice","owner":{"login":"VVillwin","id":1944314,"avatar_url":"https://avatars.githubusercontent.com/u/1944314?v=2","gravatar_id":"","url":"https://api.github.com/users/VVillwin","html_url":"https://github.com/VVillwin","followers_url":"https://api.github.com/users/VVillwin/followers","following_url":"https://api.github.com/users/VVillwin/following{/other_user}","gists_url":"https://api.github.com/users/VVillwin/gists{/gist_id}","starred_url":"https://api.github.com/users/VVillwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VVillwin/subscriptions","organizations_url":"https://api.github.com/users/VVillwin/orgs","repos_url":"https://api.github.com/users/VVillwin/repos","events_url":"https://api.github.com/users/VVillwin/events{/privacy}","received_events_url":"https://api.github.com/users/VVillwin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/VVillwin/agile-course-practice","description":"Master course on Agile Development","fork":true,"url":"https://api.github.com/repos/VVillwin/agile-course-practice","forks_url":"https://api.github.com/repos/VVillwin/agile-course-practice/forks","keys_url":"https://api.github.com/repos/VVillwin/agile-course-practice/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VVillwin/agile-course-practice/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VVillwin/agile-course-practice/teams","hooks_url":"https://api.github.com/repos/VVillwin/agile-course-practice/hooks","issue_events_url":"https://api.github.com/repos/VVillwin/agile-course-practice/issues/events{/number}","events_url":"https://api.github.com/repos/VVillwin/agile-course-practice/events","assignees_url":"https://api.github.com/repos/VVillwin/agile-course-practice/assignees{/user}","branches_url":"https://api.github.com/repos/VVillwin/agile-course-practice/branches{/branch}","tags_url":"https://api.github.com/repos/VVillwin/agile-course-practice/tags","blobs_url":"https://api.github.com/repos/VVillwin/agile-course-practice/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VVillwin/agile-course-practice/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VVillwin/agile-course-practice/git/refs{/sha}","trees_url":"https://api.github.com/repos/VVillwin/agile-course-practice/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VVillwin/agile-course-practice/statuses/{sha}","languages_url":"https://api.github.com/repos/VVillwin/agile-course-practice/languages","stargazers_url":"https://api.github.com/repos/VVillwin/agile-course-practice/stargazers","contributors_url":"https://api.github.com/repos/VVillwin/agile-course-practice/contributors","subscribers_url":"https://api.github.com/repos/VVillwin/agile-course-practice/subscribers","subscription_url":"https://api.github.com/repos/VVillwin/agile-course-practice/subscription","commits_url":"https://api.github.com/repos/VVillwin/agile-course-practice/commits{/sha}","git_commits_url":"https://api.github.com/repos/VVillwin/agile-course-practice/git/commits{/sha}","comments_url":"https://api.github.com/repos/VVillwin/agile-course-practice/comments{/number}","issue_comment_url":"https://api.github.com/repos/VVillwin/agile-course-practice/issues/comments/{number}","contents_url":"https://api.github.com/repos/VVillwin/agile-course-practice/contents/{+path}","compare_url":"https://api.github.com/repos/VVillwin/agile-course-practice/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VVillwin/agile-course-practice/merges","archive_url":"https://api.github.com/repos/VVillwin/agile-course-practice/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VVillwin/agile-course-practice/downloads","issues_url":"https://api.github.com/repos/VVillwin/agile-course-practice/issues{/number}","pulls_url":"https://api.github.com/repos/VVillwin/agile-course-practice/pulls{/number}","milestones_url":"https://api.github.com/repos/VVillwin/agile-course-practice/milestones{/number}","notifications_url":"https://api.github.com/repos/VVillwin/agile-course-practice/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VVillwin/agile-course-practice/labels{/name}","releases_url":"https://api.github.com/repos/VVillwin/agile-course-practice/releases{/id}","created_at":"2014-09-26T17:28:32Z","updated_at":"2014-09-25T18:49:51Z","pushed_at":"2014-10-31T10:32:07Z","git_url":"git://github.com/VVillwin/agile-course-practice.git","ssh_url":"git@github.com:VVillwin/agile-course-practice.git","clone_url":"https://github.com/VVillwin/agile-course-practice.git","svn_url":"https://github.com/VVillwin/agile-course-practice","homepage":"","size":272,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"UNN-VMK-Software:master","ref":"master","sha":"8ff1d376d5c58f3b04aa33520c57d497d4a02577","user":{"login":"UNN-VMK-Software","id":5463209,"avatar_url":"https://avatars.githubusercontent.com/u/5463209?v=2","gravatar_id":"","url":"https://api.github.com/users/UNN-VMK-Software","html_url":"https://github.com/UNN-VMK-Software","followers_url":"https://api.github.com/users/UNN-VMK-Software/followers","following_url":"https://api.github.com/users/UNN-VMK-Software/following{/other_user}","gists_url":"https://api.github.com/users/UNN-VMK-Software/gists{/gist_id}","starred_url":"https://api.github.com/users/UNN-VMK-Software/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UNN-VMK-Software/subscriptions","organizations_url":"https://api.github.com/users/UNN-VMK-Software/orgs","repos_url":"https://api.github.com/users/UNN-VMK-Software/repos","events_url":"https://api.github.com/users/UNN-VMK-Software/events{/privacy}","received_events_url":"https://api.github.com/users/UNN-VMK-Software/received_events","type":"Organization","site_admin":false},"repo":{"id":22540232,"name":"agile-course-practice","full_name":"UNN-VMK-Software/agile-course-practice","owner":{"login":"UNN-VMK-Software","id":5463209,"avatar_url":"https://avatars.githubusercontent.com/u/5463209?v=2","gravatar_id":"","url":"https://api.github.com/users/UNN-VMK-Software","html_url":"https://github.com/UNN-VMK-Software","followers_url":"https://api.github.com/users/UNN-VMK-Software/followers","following_url":"https://api.github.com/users/UNN-VMK-Software/following{/other_user}","gists_url":"https://api.github.com/users/UNN-VMK-Software/gists{/gist_id}","starred_url":"https://api.github.com/users/UNN-VMK-Software/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UNN-VMK-Software/subscriptions","organizations_url":"https://api.github.com/users/UNN-VMK-Software/orgs","repos_url":"https://api.github.com/users/UNN-VMK-Software/repos","events_url":"https://api.github.com/users/UNN-VMK-Software/events{/privacy}","received_events_url":"https://api.github.com/users/UNN-VMK-Software/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UNN-VMK-Software/agile-course-practice","description":"Master course on Agile Development","fork":false,"url":"https://api.github.com/repos/UNN-VMK-Software/agile-course-practice","forks_url":"https://api.github.com/repos/UNN-VMK-Software/agile-course-practice/forks","keys_url":"https://api.github.com/repos/UNN-VMK-Software/agile-course-practice/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UNN-VMK-Software/agile-course-practice/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UNN-VMK-Software/agile-course-practice/teams","hooks_url":"https://api.github.com/repos/UNN-VMK-Software/agile-course-practice/hooks","issue_events_url":"https://api.github.com/repos/UNN-VMK-Software/agile-course-practice/issues/events{/number}","events_url":"https://api.github.com/repos/UNN-VMK-Software/agile-course-practice/events","assignees_url":"https://api.github.com/repos/UNN-VMK-Software/agile-course-practice/assignees{/user}","branches_url":"https://api.github.com/repos/UNN-VMK-Software/agile-course-practice/branches{/branch}","tags_url":"https://api.github.com/repos/UNN-VMK-Software/agile-course-practice/tags","blobs_url":"https://api.github.com/repos/UNN-VMK-Software/agile-course-practice/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UNN-VMK-Software/agile-course-practice/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UNN-VMK-Software/agile-course-practice/git/refs{/sha}","trees_url":"https://api.github.com/repos/UNN-VMK-Software/agile-course-practice/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UNN-VMK-Software/agile-course-practice/statuses/{sha}","languages_url":"https://api.github.com/repos/UNN-VMK-Software/agile-course-practice/languages","stargazers_url":"https://api.github.com/repos/UNN-VMK-Software/agile-course-practice/stargazers","contributors_url":"https://api.github.com/repos/UNN-VMK-Software/agile-course-practice/contributors","subscribers_url":"https://api.github.com/repos/UNN-VMK-Software/agile-course-practice/subscribers","subscription_url":"https://api.github.com/repos/UNN-VMK-Software/agile-course-practice/subscription","commits_url":"https://api.github.com/repos/UNN-VMK-Software/agile-course-practice/commits{/sha}","git_commits_url":"https://api.github.com/repos/UNN-VMK-Software/agile-course-practice/git/commits{/sha}","comments_url":"https://api.github.com/repos/UNN-VMK-Software/agile-course-practice/comments{/number}","issue_comment_url":"https://api.github.com/repos/UNN-VMK-Software/agile-course-practice/issues/comments/{number}","contents_url":"https://api.github.com/repos/UNN-VMK-Software/agile-course-practice/contents/{+path}","compare_url":"https://api.github.com/repos/UNN-VMK-Software/agile-course-practice/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UNN-VMK-Software/agile-course-practice/merges","archive_url":"https://api.github.com/repos/UNN-VMK-Software/agile-course-practice/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UNN-VMK-Software/agile-course-practice/downloads","issues_url":"https://api.github.com/repos/UNN-VMK-Software/agile-course-practice/issues{/number}","pulls_url":"https://api.github.com/repos/UNN-VMK-Software/agile-course-practice/pulls{/number}","milestones_url":"https://api.github.com/repos/UNN-VMK-Software/agile-course-practice/milestones{/number}","notifications_url":"https://api.github.com/repos/UNN-VMK-Software/agile-course-practice/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UNN-VMK-Software/agile-course-practice/labels{/name}","releases_url":"https://api.github.com/repos/UNN-VMK-Software/agile-course-practice/releases{/id}","created_at":"2014-08-02T05:53:52Z","updated_at":"2014-10-31T15:46:08Z","pushed_at":"2014-10-31T09:31:50Z","git_url":"git://github.com/UNN-VMK-Software/agile-course-practice.git","ssh_url":"git@github.com:UNN-VMK-Software/agile-course-practice.git","clone_url":"https://github.com/UNN-VMK-Software/agile-course-practice.git","svn_url":"https://github.com/UNN-VMK-Software/agile-course-practice","homepage":"","size":1543,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":17,"forks":35,"open_issues":17,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/UNN-VMK-Software/agile-course-practice/pulls/55"},"html":{"href":"https://github.com/UNN-VMK-Software/agile-course-practice/pull/55"},"issue":{"href":"https://api.github.com/repos/UNN-VMK-Software/agile-course-practice/issues/55"},"comments":{"href":"https://api.github.com/repos/UNN-VMK-Software/agile-course-practice/issues/55/comments"},"review_comments":{"href":"https://api.github.com/repos/UNN-VMK-Software/agile-course-practice/pulls/55/comments"},"review_comment":{"href":"https://api.github.com/repos/UNN-VMK-Software/agile-course-practice/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/UNN-VMK-Software/agile-course-practice/pulls/55/commits"},"statuses":{"href":"https://api.github.com/repos/UNN-VMK-Software/agile-course-practice/statuses/7e9538343007dc310e263b98a840e5ba7fcf50f9"}}}}