GitHub PullRequestEvent at 2014-02-04 15:06:34
Repository: sp-main
Actor: MattDease
Payload: {"action":"closed","number":15,"pull_request":{"url":"https://api.github.com/repos/MattDease/sp-main/pulls/15","id":12040442,"html_url":"https://github.com/MattDease/sp-main/pull/15","diff_url":"https://github.com/MattDease/sp-main/pull/15.diff","patch_url":"https://github.com/MattDease/sp-main/pull/15.patch","issue_url":"https://api.github.com/repos/MattDease/sp-main/issues/15","number":15,"state":"closed","title":"Basic, single-team gameplay","user":{"login":"MattDease","id":636957,"avatar_url":"https://gravatar.com/avatar/7a61b9759664f6af47cf5d78b256b713?d=https%3A%2F%2Fidenticons.github.com%2F17934630b3cbab43f4e508331a69f17d.png&r=x","gravatar_id":"7a61b9759664f6af47cf5d78b256b713","url":"https://api.github.com/users/MattDease","html_url":"https://github.com/MattDease","followers_url":"https://api.github.com/users/MattDease/followers","following_url":"https://api.github.com/users/MattDease/following{/other_user}","gists_url":"https://api.github.com/users/MattDease/gists{/gist_id}","starred_url":"https://api.github.com/users/MattDease/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattDease/subscriptions","organizations_url":"https://api.github.com/users/MattDease/orgs","repos_url":"https://api.github.com/users/MattDease/repos","events_url":"https://api.github.com/users/MattDease/events{/privacy}","received_events_url":"https://api.github.com/users/MattDease/received_events","type":"User","site_admin":false},"body":"reviewer: @desirino \r\n\r\nChanges:\r\n* Add runner camera positioning.\r\n * Camera is aimed at 1/3 of the viewport width ahead of user-controlled runner.\r\n * Except when the lead runner in the team is so far ahead that they'd be nearly off-screen. in this case, the camera is offset to ensure the leader is always visible.\r\n * If the user-controlled runner goes out of view due to the above, the player is killed.\r\n* Add level segment removal.\r\n* Change level segment addition and removal to consider the position of all team-members.\r\n* Add observer view, camera is centered on the average position of all team-members.\r\n* Add commander player\r\n * Commander camera and game object move with the runner's average position\r\n * Commander will move to the position of the user's touch/mouse\r\n * Commander can move platforms. Implementation is just proof of concept for now.\r\n  * Player position will move with moving platforms.\r\n* Change in-game debug ui to display more relevant information based on game state.\r\n* Add end-game condition checks\r\n * End game if all teams are dead (no active runners in any teams).\r\n * Track team distance.\r\n * Basic handling of player disconnection handling and team validity checks.\r\n* Fix check runner's isGrounded check.\r\n\r\nNote - to test this code live make these additional changes:\r\nGameClass.js L89\r\n```\r\n        return [0, players.Count == 0 ? PlayerRole.Commander : PlayerRole.Runner];\r\n```\r\nGameMenu.js L128\r\n```\r\n        if(GUI.Button(Rect(guiHost[2].offset.x + (Screen.width*0.31 + Screen.width*0.03),Screen.height-Screen.height*0.13,Screen.width*0.17,Screen.height*0.11), startTexture)){\r\n            gameSetupScript.enterGame();\r\n        }\r\n```","created_at":"2014-01-30T15:47:56Z","updated_at":"2014-02-04T15:06:34Z","closed_at":"2014-02-04T15:06:34Z","merged_at":"2014-02-04T15:06:34Z","merge_commit_sha":"aeaab83f371a6b551ce107de522be3cf9faa65e2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/MattDease/sp-main/pulls/15/commits","review_comments_url":"https://api.github.com/repos/MattDease/sp-main/pulls/15/comments","review_comment_url":"https://api.github.com/repos/MattDease/sp-main/pulls/comments/{number}","comments_url":"https://api.github.com/repos/MattDease/sp-main/issues/15/comments","statuses_url":"https://api.github.com/repos/MattDease/sp-main/statuses/4523861faa74fd0ee54c3ac83dbdd2ccda7abd09","head":{"label":"MattDease:gameplay-teams","ref":"gameplay-teams","sha":"4523861faa74fd0ee54c3ac83dbdd2ccda7abd09","user":{"login":"MattDease","id":636957,"avatar_url":"https://gravatar.com/avatar/7a61b9759664f6af47cf5d78b256b713?d=https%3A%2F%2Fidenticons.github.com%2F17934630b3cbab43f4e508331a69f17d.png&r=x","gravatar_id":"7a61b9759664f6af47cf5d78b256b713","url":"https://api.github.com/users/MattDease","html_url":"https://github.com/MattDease","followers_url":"https://api.github.com/users/MattDease/followers","following_url":"https://api.github.com/users/MattDease/following{/other_user}","gists_url":"https://api.github.com/users/MattDease/gists{/gist_id}","starred_url":"https://api.github.com/users/MattDease/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattDease/subscriptions","organizations_url":"https://api.github.com/users/MattDease/orgs","repos_url":"https://api.github.com/users/MattDease/repos","events_url":"https://api.github.com/users/MattDease/events{/privacy}","received_events_url":"https://api.github.com/users/MattDease/received_events","type":"User","site_admin":false},"repo":{"id":12898920,"name":"sp-main","full_name":"MattDease/sp-main","owner":{"login":"MattDease","id":636957,"avatar_url":"https://gravatar.com/avatar/7a61b9759664f6af47cf5d78b256b713?d=https%3A%2F%2Fidenticons.github.com%2F17934630b3cbab43f4e508331a69f17d.png&r=x","gravatar_id":"7a61b9759664f6af47cf5d78b256b713","url":"https://api.github.com/users/MattDease","html_url":"https://github.com/MattDease","followers_url":"https://api.github.com/users/MattDease/followers","following_url":"https://api.github.com/users/MattDease/following{/other_user}","gists_url":"https://api.github.com/users/MattDease/gists{/gist_id}","starred_url":"https://api.github.com/users/MattDease/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattDease/subscriptions","organizations_url":"https://api.github.com/users/MattDease/orgs","repos_url":"https://api.github.com/users/MattDease/repos","events_url":"https://api.github.com/users/MattDease/events{/privacy}","received_events_url":"https://api.github.com/users/MattDease/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MattDease/sp-main","description":"Main repository for IMD Senior Project 2013-2014","fork":false,"url":"https://api.github.com/repos/MattDease/sp-main","forks_url":"https://api.github.com/repos/MattDease/sp-main/forks","keys_url":"https://api.github.com/repos/MattDease/sp-main/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MattDease/sp-main/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MattDease/sp-main/teams","hooks_url":"https://api.github.com/repos/MattDease/sp-main/hooks","issue_events_url":"https://api.github.com/repos/MattDease/sp-main/issues/events{/number}","events_url":"https://api.github.com/repos/MattDease/sp-main/events","assignees_url":"https://api.github.com/repos/MattDease/sp-main/assignees{/user}","branches_url":"https://api.github.com/repos/MattDease/sp-main/branches{/branch}","tags_url":"https://api.github.com/repos/MattDease/sp-main/tags","blobs_url":"https://api.github.com/repos/MattDease/sp-main/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MattDease/sp-main/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MattDease/sp-main/git/refs{/sha}","trees_url":"https://api.github.com/repos/MattDease/sp-main/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MattDease/sp-main/statuses/{sha}","languages_url":"https://api.github.com/repos/MattDease/sp-main/languages","stargazers_url":"https://api.github.com/repos/MattDease/sp-main/stargazers","contributors_url":"https://api.github.com/repos/MattDease/sp-main/contributors","subscribers_url":"https://api.github.com/repos/MattDease/sp-main/subscribers","subscription_url":"https://api.github.com/repos/MattDease/sp-main/subscription","commits_url":"https://api.github.com/repos/MattDease/sp-main/commits{/sha}","git_commits_url":"https://api.github.com/repos/MattDease/sp-main/git/commits{/sha}","comments_url":"https://api.github.com/repos/MattDease/sp-main/comments{/number}","issue_comment_url":"https://api.github.com/repos/MattDease/sp-main/issues/comments/{number}","contents_url":"https://api.github.com/repos/MattDease/sp-main/contents/{+path}","compare_url":"https://api.github.com/repos/MattDease/sp-main/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MattDease/sp-main/merges","archive_url":"https://api.github.com/repos/MattDease/sp-main/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MattDease/sp-main/downloads","issues_url":"https://api.github.com/repos/MattDease/sp-main/issues{/number}","pulls_url":"https://api.github.com/repos/MattDease/sp-main/pulls{/number}","milestones_url":"https://api.github.com/repos/MattDease/sp-main/milestones{/number}","notifications_url":"https://api.github.com/repos/MattDease/sp-main/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MattDease/sp-main/labels{/name}","releases_url":"https://api.github.com/repos/MattDease/sp-main/releases{/id}","created_at":"2013-09-17T15:21:34Z","updated_at":"2014-02-04T15:06:34Z","pushed_at":"2014-02-04T15:06:34Z","git_url":"git://github.com/MattDease/sp-main.git","ssh_url":"git@github.com:MattDease/sp-main.git","clone_url":"https://github.com/MattDease/sp-main.git","svn_url":"https://github.com/MattDease/sp-main","homepage":null,"size":7914,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"MattDease:master","ref":"master","sha":"92e531bcc986c7f16ef4af2d8fa61c003d71484a","user":{"login":"MattDease","id":636957,"avatar_url":"https://gravatar.com/avatar/7a61b9759664f6af47cf5d78b256b713?d=https%3A%2F%2Fidenticons.github.com%2F17934630b3cbab43f4e508331a69f17d.png&r=x","gravatar_id":"7a61b9759664f6af47cf5d78b256b713","url":"https://api.github.com/users/MattDease","html_url":"https://github.com/MattDease","followers_url":"https://api.github.com/users/MattDease/followers","following_url":"https://api.github.com/users/MattDease/following{/other_user}","gists_url":"https://api.github.com/users/MattDease/gists{/gist_id}","starred_url":"https://api.github.com/users/MattDease/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattDease/subscriptions","organizations_url":"https://api.github.com/users/MattDease/orgs","repos_url":"https://api.github.com/users/MattDease/repos","events_url":"https://api.github.com/users/MattDease/events{/privacy}","received_events_url":"https://api.github.com/users/MattDease/received_events","type":"User","site_admin":false},"repo":{"id":12898920,"name":"sp-main","full_name":"MattDease/sp-main","owner":{"login":"MattDease","id":636957,"avatar_url":"https://gravatar.com/avatar/7a61b9759664f6af47cf5d78b256b713?d=https%3A%2F%2Fidenticons.github.com%2F17934630b3cbab43f4e508331a69f17d.png&r=x","gravatar_id":"7a61b9759664f6af47cf5d78b256b713","url":"https://api.github.com/users/MattDease","html_url":"https://github.com/MattDease","followers_url":"https://api.github.com/users/MattDease/followers","following_url":"https://api.github.com/users/MattDease/following{/other_user}","gists_url":"https://api.github.com/users/MattDease/gists{/gist_id}","starred_url":"https://api.github.com/users/MattDease/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattDease/subscriptions","organizations_url":"https://api.github.com/users/MattDease/orgs","repos_url":"https://api.github.com/users/MattDease/repos","events_url":"https://api.github.com/users/MattDease/events{/privacy}","received_events_url":"https://api.github.com/users/MattDease/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MattDease/sp-main","description":"Main repository for IMD Senior Project 2013-2014","fork":false,"url":"https://api.github.com/repos/MattDease/sp-main","forks_url":"https://api.github.com/repos/MattDease/sp-main/forks","keys_url":"https://api.github.com/repos/MattDease/sp-main/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MattDease/sp-main/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MattDease/sp-main/teams","hooks_url":"https://api.github.com/repos/MattDease/sp-main/hooks","issue_events_url":"https://api.github.com/repos/MattDease/sp-main/issues/events{/number}","events_url":"https://api.github.com/repos/MattDease/sp-main/events","assignees_url":"https://api.github.com/repos/MattDease/sp-main/assignees{/user}","branches_url":"https://api.github.com/repos/MattDease/sp-main/branches{/branch}","tags_url":"https://api.github.com/repos/MattDease/sp-main/tags","blobs_url":"https://api.github.com/repos/MattDease/sp-main/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MattDease/sp-main/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MattDease/sp-main/git/refs{/sha}","trees_url":"https://api.github.com/repos/MattDease/sp-main/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MattDease/sp-main/statuses/{sha}","languages_url":"https://api.github.com/repos/MattDease/sp-main/languages","stargazers_url":"https://api.github.com/repos/MattDease/sp-main/stargazers","contributors_url":"https://api.github.com/repos/MattDease/sp-main/contributors","subscribers_url":"https://api.github.com/repos/MattDease/sp-main/subscribers","subscription_url":"https://api.github.com/repos/MattDease/sp-main/subscription","commits_url":"https://api.github.com/repos/MattDease/sp-main/commits{/sha}","git_commits_url":"https://api.github.com/repos/MattDease/sp-main/git/commits{/sha}","comments_url":"https://api.github.com/repos/MattDease/sp-main/comments{/number}","issue_comment_url":"https://api.github.com/repos/MattDease/sp-main/issues/comments/{number}","contents_url":"https://api.github.com/repos/MattDease/sp-main/contents/{+path}","compare_url":"https://api.github.com/repos/MattDease/sp-main/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MattDease/sp-main/merges","archive_url":"https://api.github.com/repos/MattDease/sp-main/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MattDease/sp-main/downloads","issues_url":"https://api.github.com/repos/MattDease/sp-main/issues{/number}","pulls_url":"https://api.github.com/repos/MattDease/sp-main/pulls{/number}","milestones_url":"https://api.github.com/repos/MattDease/sp-main/milestones{/number}","notifications_url":"https://api.github.com/repos/MattDease/sp-main/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MattDease/sp-main/labels{/name}","releases_url":"https://api.github.com/repos/MattDease/sp-main/releases{/id}","created_at":"2013-09-17T15:21:34Z","updated_at":"2014-02-04T15:06:34Z","pushed_at":"2014-02-04T15:06:34Z","git_url":"git://github.com/MattDease/sp-main.git","ssh_url":"git@github.com:MattDease/sp-main.git","clone_url":"https://github.com/MattDease/sp-main.git","svn_url":"https://github.com/MattDease/sp-main","homepage":null,"size":7914,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MattDease/sp-main/pulls/15"},"html":{"href":"https://github.com/MattDease/sp-main/pull/15"},"issue":{"href":"https://api.github.com/repos/MattDease/sp-main/issues/15"},"comments":{"href":"https://api.github.com/repos/MattDease/sp-main/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/MattDease/sp-main/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/MattDease/sp-main/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/MattDease/sp-main/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/MattDease/sp-main/statuses/4523861faa74fd0ee54c3ac83dbdd2ccda7abd09"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"MattDease","id":636957,"avatar_url":"https://gravatar.com/avatar/7a61b9759664f6af47cf5d78b256b713?d=https%3A%2F%2Fidenticons.github.com%2F17934630b3cbab43f4e508331a69f17d.png&r=x","gravatar_id":"7a61b9759664f6af47cf5d78b256b713","url":"https://api.github.com/users/MattDease","html_url":"https://github.com/MattDease","followers_url":"https://api.github.com/users/MattDease/followers","following_url":"https://api.github.com/users/MattDease/following{/other_user}","gists_url":"https://api.github.com/users/MattDease/gists{/gist_id}","starred_url":"https://api.github.com/users/MattDease/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattDease/subscriptions","organizations_url":"https://api.github.com/users/MattDease/orgs","repos_url":"https://api.github.com/users/MattDease/repos","events_url":"https://api.github.com/users/MattDease/events{/privacy}","received_events_url":"https://api.github.com/users/MattDease/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":19,"additions":1493,"deletions":81,"changed_files":36}}