GitHub PullRequestReviewCommentEvent at 2014-06-10 19:16:42
Repository: spring-xd
Actor: ghillert
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/spring-projects/spring-xd/pulls/comments/13613262","id":13613262,"diff_hunk":"@@ -100,6 +116,20 @@\n \t}\n \n \t/**\n+\t * Get all existing job definition names.\n+\t *\n+\t * @return the collection of job definition names\n+\t */\n+\tprivate Collection<String> getJobDefinitionNames() {\n+\t\tCollection<String> jobDefinitionNames = new ArrayList<String>();\n+\t\tIterable<JobDefinition> jobDefinitions = xdJobDefinitionRepository.findAll();","path":"spring-xd-dirt/src/main/java/org/springframework/xd/dirt/rest/BatchJobExecutionsController.java","position":45,"original_position":45,"commit_id":"d4f30ae437c78922d98679d9231ce42354d4c6e0","original_commit_id":"d4f30ae437c78922d98679d9231ce42354d4c6e0","user":{"login":"ghillert","id":685363,"avatar_url":"https://avatars.githubusercontent.com/u/685363?","gravatar_id":"4ac2348f47a05227738a71709aac608f","url":"https://api.github.com/users/ghillert","html_url":"https://github.com/ghillert","followers_url":"https://api.github.com/users/ghillert/followers","following_url":"https://api.github.com/users/ghillert/following{/other_user}","gists_url":"https://api.github.com/users/ghillert/gists{/gist_id}","starred_url":"https://api.github.com/users/ghillert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghillert/subscriptions","organizations_url":"https://api.github.com/users/ghillert/orgs","repos_url":"https://api.github.com/users/ghillert/repos","events_url":"https://api.github.com/users/ghillert/events{/privacy}","received_events_url":"https://api.github.com/users/ghillert/received_events","type":"User","site_admin":false},"body":"On one side we do pagination above but then we retrieve ALL job definitions here. Maybe okay as hopefully there may not ever be a large amount of definitions but still...almost makes me long for a relational DB and more selective queries ;-)","created_at":"2014-06-10T19:16:42Z","updated_at":"2014-06-10T19:16:42Z","html_url":"https://github.com/spring-projects/spring-xd/pull/928#discussion_r13613262","pull_request_url":"https://api.github.com/repos/spring-projects/spring-xd/pulls/928","_links":{"self":{"href":"https://api.github.com/repos/spring-projects/spring-xd/pulls/comments/13613262"},"html":{"href":"https://github.com/spring-projects/spring-xd/pull/928#discussion_r13613262"},"pull_request":{"href":"https://api.github.com/repos/spring-projects/spring-xd/pulls/928"}}},"pull_request":{"url":"https://api.github.com/repos/spring-projects/spring-xd/pulls/928","id":16911901,"html_url":"https://github.com/spring-projects/spring-xd/pull/928","diff_url":"https://github.com/spring-projects/spring-xd/pull/928.diff","patch_url":"https://github.com/spring-projects/spring-xd/pull/928.patch","issue_url":"https://api.github.com/repos/spring-projects/spring-xd/issues/928","number":928,"state":"open","title":"XD-1311 XD-1767 JobExecution deployed/deleted status","user":{"login":"ilayaperumalg","id":151690,"avatar_url":"https://avatars.githubusercontent.com/u/151690?","gravatar_id":"0c71a442dda9887246ee51cace8ce05c","url":"https://api.github.com/users/ilayaperumalg","html_url":"https://github.com/ilayaperumalg","followers_url":"https://api.github.com/users/ilayaperumalg/followers","following_url":"https://api.github.com/users/ilayaperumalg/following{/other_user}","gists_url":"https://api.github.com/users/ilayaperumalg/gists{/gist_id}","starred_url":"https://api.github.com/users/ilayaperumalg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilayaperumalg/subscriptions","organizations_url":"https://api.github.com/users/ilayaperumalg/orgs","repos_url":"https://api.github.com/users/ilayaperumalg/repos","events_url":"https://api.github.com/users/ilayaperumalg/events{/privacy}","received_events_url":"https://api.github.com/users/ilayaperumalg/received_events","type":"User","site_admin":false},"body":"- Add `deployed` and `deleted` status to JobExecutionInfoResource\r\n- At BatchJobExecutionsController:\r\n  - If the job name exists in the `JobDefinitionRepository` but not at the\r\n`JobLocator` then we would set the jobExecution deployed status to `false`\r\n  - If the job name doesn't exist in the `JobDefinitionRepository` at all,\r\nthen we would set the deployed/deleted status to `false`\r\n- At the web UI:\r\n  - Add the label to denote the deployed/deleted status at the\r\nJobExecutions list page\r\n- Fix tests","created_at":"2014-06-09T22:16:12Z","updated_at":"2014-06-10T19:16:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"65f32b590793c8550dcd458995b228a25815440a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/spring-projects/spring-xd/pulls/928/commits","review_comments_url":"https://api.github.com/repos/spring-projects/spring-xd/pulls/928/comments","review_comment_url":"https://api.github.com/repos/spring-projects/spring-xd/pulls/comments/{number}","comments_url":"https://api.github.com/repos/spring-projects/spring-xd/issues/928/comments","statuses_url":"https://api.github.com/repos/spring-projects/spring-xd/statuses/d4f30ae437c78922d98679d9231ce42354d4c6e0","head":{"label":"ilayaperumalg:XD-1311","ref":"XD-1311","sha":"d4f30ae437c78922d98679d9231ce42354d4c6e0","user":{"login":"ilayaperumalg","id":151690,"avatar_url":"https://avatars.githubusercontent.com/u/151690?","gravatar_id":"0c71a442dda9887246ee51cace8ce05c","url":"https://api.github.com/users/ilayaperumalg","html_url":"https://github.com/ilayaperumalg","followers_url":"https://api.github.com/users/ilayaperumalg/followers","following_url":"https://api.github.com/users/ilayaperumalg/following{/other_user}","gists_url":"https://api.github.com/users/ilayaperumalg/gists{/gist_id}","starred_url":"https://api.github.com/users/ilayaperumalg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilayaperumalg/subscriptions","organizations_url":"https://api.github.com/users/ilayaperumalg/orgs","repos_url":"https://api.github.com/users/ilayaperumalg/repos","events_url":"https://api.github.com/users/ilayaperumalg/events{/privacy}","received_events_url":"https://api.github.com/users/ilayaperumalg/received_events","type":"User","site_admin":false},"repo":{"id":9632331,"name":"spring-xd","full_name":"ilayaperumalg/spring-xd","owner":{"login":"ilayaperumalg","id":151690,"avatar_url":"https://avatars.githubusercontent.com/u/151690?","gravatar_id":"0c71a442dda9887246ee51cace8ce05c","url":"https://api.github.com/users/ilayaperumalg","html_url":"https://github.com/ilayaperumalg","followers_url":"https://api.github.com/users/ilayaperumalg/followers","following_url":"https://api.github.com/users/ilayaperumalg/following{/other_user}","gists_url":"https://api.github.com/users/ilayaperumalg/gists{/gist_id}","starred_url":"https://api.github.com/users/ilayaperumalg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilayaperumalg/subscriptions","organizations_url":"https://api.github.com/users/ilayaperumalg/orgs","repos_url":"https://api.github.com/users/ilayaperumalg/repos","events_url":"https://api.github.com/users/ilayaperumalg/events{/privacy}","received_events_url":"https://api.github.com/users/ilayaperumalg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ilayaperumalg/spring-xd","description":"Spring XD makes it easy to solve common big data problems such as data ingestion and export, real-time analytics, and batch workflow orchestration","fork":true,"url":"https://api.github.com/repos/ilayaperumalg/spring-xd","forks_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/forks","keys_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/teams","hooks_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/hooks","issue_events_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/issues/events{/number}","events_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/events","assignees_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/assignees{/user}","branches_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/branches{/branch}","tags_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/tags","blobs_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/git/refs{/sha}","trees_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/statuses/{sha}","languages_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/languages","stargazers_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/stargazers","contributors_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/contributors","subscribers_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/subscribers","subscription_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/subscription","commits_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/commits{/sha}","git_commits_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/git/commits{/sha}","comments_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/comments{/number}","issue_comment_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/issues/comments/{number}","contents_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/contents/{+path}","compare_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/merges","archive_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/downloads","issues_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/issues{/number}","pulls_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/pulls{/number}","milestones_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/milestones{/number}","notifications_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/labels{/name}","releases_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/releases{/id}","created_at":"2013-04-23T20:13:28Z","updated_at":"2014-06-10T18:23:26Z","pushed_at":"2014-06-10T18:23:26Z","git_url":"git://github.com/ilayaperumalg/spring-xd.git","ssh_url":"git@github.com:ilayaperumalg/spring-xd.git","clone_url":"https://github.com/ilayaperumalg/spring-xd.git","svn_url":"https://github.com/ilayaperumalg/spring-xd","homepage":null,"size":23306,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-projects:master","ref":"master","sha":"e0c97ab770efb544311880e3eb9448a3aa551347","user":{"login":"spring-projects","id":317776,"avatar_url":"https://avatars.githubusercontent.com/u/317776?","gravatar_id":"6f8a529bd100f4272a9ff1b8cdfbd26e","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"repo":{"id":9349347,"name":"spring-xd","full_name":"spring-projects/spring-xd","owner":{"login":"spring-projects","id":317776,"avatar_url":"https://avatars.githubusercontent.com/u/317776?","gravatar_id":"6f8a529bd100f4272a9ff1b8cdfbd26e","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-projects/spring-xd","description":"Spring XD makes it easy to solve common big data problems such as data ingestion and export, real-time analytics, and batch workflow orchestration","fork":false,"url":"https://api.github.com/repos/spring-projects/spring-xd","forks_url":"https://api.github.com/repos/spring-projects/spring-xd/forks","keys_url":"https://api.github.com/repos/spring-projects/spring-xd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-projects/spring-xd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-projects/spring-xd/teams","hooks_url":"https://api.github.com/repos/spring-projects/spring-xd/hooks","issue_events_url":"https://api.github.com/repos/spring-projects/spring-xd/issues/events{/number}","events_url":"https://api.github.com/repos/spring-projects/spring-xd/events","assignees_url":"https://api.github.com/repos/spring-projects/spring-xd/assignees{/user}","branches_url":"https://api.github.com/repos/spring-projects/spring-xd/branches{/branch}","tags_url":"https://api.github.com/repos/spring-projects/spring-xd/tags","blobs_url":"https://api.github.com/repos/spring-projects/spring-xd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-projects/spring-xd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-projects/spring-xd/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-projects/spring-xd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-projects/spring-xd/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-projects/spring-xd/languages","stargazers_url":"https://api.github.com/repos/spring-projects/spring-xd/stargazers","contributors_url":"https://api.github.com/repos/spring-projects/spring-xd/contributors","subscribers_url":"https://api.github.com/repos/spring-projects/spring-xd/subscribers","subscription_url":"https://api.github.com/repos/spring-projects/spring-xd/subscription","commits_url":"https://api.github.com/repos/spring-projects/spring-xd/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-projects/spring-xd/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-projects/spring-xd/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-projects/spring-xd/issues/comments/{number}","contents_url":"https://api.github.com/repos/spring-projects/spring-xd/contents/{+path}","compare_url":"https://api.github.com/repos/spring-projects/spring-xd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-projects/spring-xd/merges","archive_url":"https://api.github.com/repos/spring-projects/spring-xd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-projects/spring-xd/downloads","issues_url":"https://api.github.com/repos/spring-projects/spring-xd/issues{/number}","pulls_url":"https://api.github.com/repos/spring-projects/spring-xd/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-projects/spring-xd/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-projects/spring-xd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-projects/spring-xd/labels{/name}","releases_url":"https://api.github.com/repos/spring-projects/spring-xd/releases{/id}","created_at":"2013-04-10T15:31:44Z","updated_at":"2014-06-10T16:16:39Z","pushed_at":"2014-06-10T16:16:41Z","git_url":"git://github.com/spring-projects/spring-xd.git","ssh_url":"git@github.com:spring-projects/spring-xd.git","clone_url":"https://github.com/spring-projects/spring-xd.git","svn_url":"https://github.com/spring-projects/spring-xd","homepage":"http://projects.spring.io/spring-xd","size":59283,"stargazers_count":127,"watchers_count":127,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":118,"mirror_url":null,"open_issues_count":21,"forks":118,"open_issues":21,"watchers":127,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-projects/spring-xd/pulls/928"},"html":{"href":"https://github.com/spring-projects/spring-xd/pull/928"},"issue":{"href":"https://api.github.com/repos/spring-projects/spring-xd/issues/928"},"comments":{"href":"https://api.github.com/repos/spring-projects/spring-xd/issues/928/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-projects/spring-xd/pulls/928/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-projects/spring-xd/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/spring-projects/spring-xd/pulls/928/commits"},"statuses":{"href":"https://api.github.com/repos/spring-projects/spring-xd/statuses/d4f30ae437c78922d98679d9231ce42354d4c6e0"}}}}