GitHub PullRequestReviewCommentEvent at 2014-09-22 06:52:15
Repository: gocd
Actor: houndci
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/gocd/gocd/pulls/comments/17834354","id":17834354,"diff_hunk":"@@ -138,4 +138,14 @@\n       expect(popup_form).to have_selector(\"div.form_error\", :text => \"View is wrong\")\n     end\n   end\n+\n+  it \"should not generate the id for url, username and view fields\" do\n+    render :partial => \"admin/materials/p4/form.html\", :locals => {:scope => {:material => @material_config, :url => \"http://google.com\", :method => \"POST\", :submit_label => \"foo\"}}","path":"server/webapp/WEB-INF/rails.new/spec/views/admin/materials/p4/form_html_spec.rb","position":6,"original_position":6,"commit_id":"996823ddb6e59587115504b5391242ea87d7b3e3","original_commit_id":"996823ddb6e59587115504b5391242ea87d7b3e3","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=2","gravatar_id":"38d9cefd9971a05bf447f07c6cd332cc","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Style/HashSyntax: Use the new Ruby 1.9 hash syntax.<br>Style/SpaceInsideHashLiteralBraces: Space inside { missing.<br>Style/SpaceInsideHashLiteralBraces: Space inside } missing.","created_at":"2014-09-22T06:52:15Z","updated_at":"2014-09-22T06:52:15Z","html_url":"https://github.com/gocd/gocd/pull/557#discussion_r17834354","pull_request_url":"https://api.github.com/repos/gocd/gocd/pulls/557","_links":{"self":{"href":"https://api.github.com/repos/gocd/gocd/pulls/comments/17834354"},"html":{"href":"https://github.com/gocd/gocd/pull/557#discussion_r17834354"},"pull_request":{"href":"https://api.github.com/repos/gocd/gocd/pulls/557"}}},"pull_request":{"url":"https://api.github.com/repos/gocd/gocd/pulls/557","id":21561600,"html_url":"https://github.com/gocd/gocd/pull/557","diff_url":"https://github.com/gocd/gocd/pull/557.diff","patch_url":"https://github.com/gocd/gocd/pull/557.patch","issue_url":"https://api.github.com/repos/gocd/gocd/issues/557","number":557,"state":"open","locked":false,"title":"#130 - Moved the usage of 'omit_id_generation=>true' to ':id=>nil'","user":{"login":"mdaliejaz","id":1577718,"avatar_url":"https://avatars.githubusercontent.com/u/1577718?v=2","gravatar_id":"8e50939cb9ec34c3c3443d39fbcf8eff","url":"https://api.github.com/users/mdaliejaz","html_url":"https://github.com/mdaliejaz","followers_url":"https://api.github.com/users/mdaliejaz/followers","following_url":"https://api.github.com/users/mdaliejaz/following{/other_user}","gists_url":"https://api.github.com/users/mdaliejaz/gists{/gist_id}","starred_url":"https://api.github.com/users/mdaliejaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdaliejaz/subscriptions","organizations_url":"https://api.github.com/users/mdaliejaz/orgs","repos_url":"https://api.github.com/users/mdaliejaz/repos","events_url":"https://api.github.com/users/mdaliejaz/events{/privacy}","received_events_url":"https://api.github.com/users/mdaliejaz/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-09-22T06:52:09Z","updated_at":"2014-09-22T06:52:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"91e1e97d2e43e946dad4378babc363552f8b7591","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gocd/gocd/pulls/557/commits","review_comments_url":"https://api.github.com/repos/gocd/gocd/pulls/557/comments","review_comment_url":"https://api.github.com/repos/gocd/gocd/pulls/comments/{number}","comments_url":"https://api.github.com/repos/gocd/gocd/issues/557/comments","statuses_url":"https://api.github.com/repos/gocd/gocd/statuses/996823ddb6e59587115504b5391242ea87d7b3e3","head":{"label":"mdaliejaz:omit_id_generation","ref":"omit_id_generation","sha":"996823ddb6e59587115504b5391242ea87d7b3e3","user":{"login":"mdaliejaz","id":1577718,"avatar_url":"https://avatars.githubusercontent.com/u/1577718?v=2","gravatar_id":"8e50939cb9ec34c3c3443d39fbcf8eff","url":"https://api.github.com/users/mdaliejaz","html_url":"https://github.com/mdaliejaz","followers_url":"https://api.github.com/users/mdaliejaz/followers","following_url":"https://api.github.com/users/mdaliejaz/following{/other_user}","gists_url":"https://api.github.com/users/mdaliejaz/gists{/gist_id}","starred_url":"https://api.github.com/users/mdaliejaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdaliejaz/subscriptions","organizations_url":"https://api.github.com/users/mdaliejaz/orgs","repos_url":"https://api.github.com/users/mdaliejaz/repos","events_url":"https://api.github.com/users/mdaliejaz/events{/privacy}","received_events_url":"https://api.github.com/users/mdaliejaz/received_events","type":"User","site_admin":false},"repo":{"id":19366747,"name":"gocd","full_name":"mdaliejaz/gocd","owner":{"login":"mdaliejaz","id":1577718,"avatar_url":"https://avatars.githubusercontent.com/u/1577718?v=2","gravatar_id":"8e50939cb9ec34c3c3443d39fbcf8eff","url":"https://api.github.com/users/mdaliejaz","html_url":"https://github.com/mdaliejaz","followers_url":"https://api.github.com/users/mdaliejaz/followers","following_url":"https://api.github.com/users/mdaliejaz/following{/other_user}","gists_url":"https://api.github.com/users/mdaliejaz/gists{/gist_id}","starred_url":"https://api.github.com/users/mdaliejaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdaliejaz/subscriptions","organizations_url":"https://api.github.com/users/mdaliejaz/orgs","repos_url":"https://api.github.com/users/mdaliejaz/repos","events_url":"https://api.github.com/users/mdaliejaz/events{/privacy}","received_events_url":"https://api.github.com/users/mdaliejaz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mdaliejaz/gocd","description":"Main repository for Go Continuous Delivery","fork":true,"url":"https://api.github.com/repos/mdaliejaz/gocd","forks_url":"https://api.github.com/repos/mdaliejaz/gocd/forks","keys_url":"https://api.github.com/repos/mdaliejaz/gocd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mdaliejaz/gocd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mdaliejaz/gocd/teams","hooks_url":"https://api.github.com/repos/mdaliejaz/gocd/hooks","issue_events_url":"https://api.github.com/repos/mdaliejaz/gocd/issues/events{/number}","events_url":"https://api.github.com/repos/mdaliejaz/gocd/events","assignees_url":"https://api.github.com/repos/mdaliejaz/gocd/assignees{/user}","branches_url":"https://api.github.com/repos/mdaliejaz/gocd/branches{/branch}","tags_url":"https://api.github.com/repos/mdaliejaz/gocd/tags","blobs_url":"https://api.github.com/repos/mdaliejaz/gocd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mdaliejaz/gocd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mdaliejaz/gocd/git/refs{/sha}","trees_url":"https://api.github.com/repos/mdaliejaz/gocd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mdaliejaz/gocd/statuses/{sha}","languages_url":"https://api.github.com/repos/mdaliejaz/gocd/languages","stargazers_url":"https://api.github.com/repos/mdaliejaz/gocd/stargazers","contributors_url":"https://api.github.com/repos/mdaliejaz/gocd/contributors","subscribers_url":"https://api.github.com/repos/mdaliejaz/gocd/subscribers","subscription_url":"https://api.github.com/repos/mdaliejaz/gocd/subscription","commits_url":"https://api.github.com/repos/mdaliejaz/gocd/commits{/sha}","git_commits_url":"https://api.github.com/repos/mdaliejaz/gocd/git/commits{/sha}","comments_url":"https://api.github.com/repos/mdaliejaz/gocd/comments{/number}","issue_comment_url":"https://api.github.com/repos/mdaliejaz/gocd/issues/comments/{number}","contents_url":"https://api.github.com/repos/mdaliejaz/gocd/contents/{+path}","compare_url":"https://api.github.com/repos/mdaliejaz/gocd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mdaliejaz/gocd/merges","archive_url":"https://api.github.com/repos/mdaliejaz/gocd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mdaliejaz/gocd/downloads","issues_url":"https://api.github.com/repos/mdaliejaz/gocd/issues{/number}","pulls_url":"https://api.github.com/repos/mdaliejaz/gocd/pulls{/number}","milestones_url":"https://api.github.com/repos/mdaliejaz/gocd/milestones{/number}","notifications_url":"https://api.github.com/repos/mdaliejaz/gocd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mdaliejaz/gocd/labels{/name}","releases_url":"https://api.github.com/repos/mdaliejaz/gocd/releases{/id}","created_at":"2014-05-02T05:23:37Z","updated_at":"2014-07-07T05:39:32Z","pushed_at":"2014-09-22T06:50:33Z","git_url":"git://github.com/mdaliejaz/gocd.git","ssh_url":"git@github.com:mdaliejaz/gocd.git","clone_url":"https://github.com/mdaliejaz/gocd.git","svn_url":"https://github.com/mdaliejaz/gocd","homepage":null,"size":196966,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gocd:master","ref":"master","sha":"b580e99253d5f835f35f777039cb97a065f1bbd4","user":{"login":"gocd","id":6099846,"avatar_url":"https://avatars.githubusercontent.com/u/6099846?v=2","gravatar_id":null,"url":"https://api.github.com/users/gocd","html_url":"https://github.com/gocd","followers_url":"https://api.github.com/users/gocd/followers","following_url":"https://api.github.com/users/gocd/following{/other_user}","gists_url":"https://api.github.com/users/gocd/gists{/gist_id}","starred_url":"https://api.github.com/users/gocd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gocd/subscriptions","organizations_url":"https://api.github.com/users/gocd/orgs","repos_url":"https://api.github.com/users/gocd/repos","events_url":"https://api.github.com/users/gocd/events{/privacy}","received_events_url":"https://api.github.com/users/gocd/received_events","type":"Organization","site_admin":false},"repo":{"id":15155534,"name":"gocd","full_name":"gocd/gocd","owner":{"login":"gocd","id":6099846,"avatar_url":"https://avatars.githubusercontent.com/u/6099846?v=2","gravatar_id":null,"url":"https://api.github.com/users/gocd","html_url":"https://github.com/gocd","followers_url":"https://api.github.com/users/gocd/followers","following_url":"https://api.github.com/users/gocd/following{/other_user}","gists_url":"https://api.github.com/users/gocd/gists{/gist_id}","starred_url":"https://api.github.com/users/gocd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gocd/subscriptions","organizations_url":"https://api.github.com/users/gocd/orgs","repos_url":"https://api.github.com/users/gocd/repos","events_url":"https://api.github.com/users/gocd/events{/privacy}","received_events_url":"https://api.github.com/users/gocd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gocd/gocd","description":"Main repository for Go Continuous Delivery","fork":false,"url":"https://api.github.com/repos/gocd/gocd","forks_url":"https://api.github.com/repos/gocd/gocd/forks","keys_url":"https://api.github.com/repos/gocd/gocd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gocd/gocd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gocd/gocd/teams","hooks_url":"https://api.github.com/repos/gocd/gocd/hooks","issue_events_url":"https://api.github.com/repos/gocd/gocd/issues/events{/number}","events_url":"https://api.github.com/repos/gocd/gocd/events","assignees_url":"https://api.github.com/repos/gocd/gocd/assignees{/user}","branches_url":"https://api.github.com/repos/gocd/gocd/branches{/branch}","tags_url":"https://api.github.com/repos/gocd/gocd/tags","blobs_url":"https://api.github.com/repos/gocd/gocd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gocd/gocd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gocd/gocd/git/refs{/sha}","trees_url":"https://api.github.com/repos/gocd/gocd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gocd/gocd/statuses/{sha}","languages_url":"https://api.github.com/repos/gocd/gocd/languages","stargazers_url":"https://api.github.com/repos/gocd/gocd/stargazers","contributors_url":"https://api.github.com/repos/gocd/gocd/contributors","subscribers_url":"https://api.github.com/repos/gocd/gocd/subscribers","subscription_url":"https://api.github.com/repos/gocd/gocd/subscription","commits_url":"https://api.github.com/repos/gocd/gocd/commits{/sha}","git_commits_url":"https://api.github.com/repos/gocd/gocd/git/commits{/sha}","comments_url":"https://api.github.com/repos/gocd/gocd/comments{/number}","issue_comment_url":"https://api.github.com/repos/gocd/gocd/issues/comments/{number}","contents_url":"https://api.github.com/repos/gocd/gocd/contents/{+path}","compare_url":"https://api.github.com/repos/gocd/gocd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gocd/gocd/merges","archive_url":"https://api.github.com/repos/gocd/gocd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gocd/gocd/downloads","issues_url":"https://api.github.com/repos/gocd/gocd/issues{/number}","pulls_url":"https://api.github.com/repos/gocd/gocd/pulls{/number}","milestones_url":"https://api.github.com/repos/gocd/gocd/milestones{/number}","notifications_url":"https://api.github.com/repos/gocd/gocd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gocd/gocd/labels{/name}","releases_url":"https://api.github.com/repos/gocd/gocd/releases{/id}","created_at":"2013-12-13T05:26:16Z","updated_at":"2014-09-22T01:35:44Z","pushed_at":"2014-09-21T07:18:15Z","git_url":"git://github.com/gocd/gocd.git","ssh_url":"git@github.com:gocd/gocd.git","clone_url":"https://github.com/gocd/gocd.git","svn_url":"https://github.com/gocd/gocd","homepage":null,"size":211731,"stargazers_count":1009,"watchers_count":1009,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":151,"mirror_url":null,"open_issues_count":265,"forks":151,"open_issues":265,"watchers":1009,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gocd/gocd/pulls/557"},"html":{"href":"https://github.com/gocd/gocd/pull/557"},"issue":{"href":"https://api.github.com/repos/gocd/gocd/issues/557"},"comments":{"href":"https://api.github.com/repos/gocd/gocd/issues/557/comments"},"review_comments":{"href":"https://api.github.com/repos/gocd/gocd/pulls/557/comments"},"review_comment":{"href":"https://api.github.com/repos/gocd/gocd/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/gocd/gocd/pulls/557/commits"},"statuses":{"href":"https://api.github.com/repos/gocd/gocd/statuses/996823ddb6e59587115504b5391242ea87d7b3e3"}}}}