GitHub PullRequestReviewCommentEvent at 2014-11-22 16:41:12
Repository: Jewel.jl
Actor: nilshg
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/one-more-minute/Jewel.jl/pulls/comments/20758194","id":20758194,"diff_hunk":"@@ -4,11 +4,13 @@ handle(\"editor.julia.hints\") do editor, data\n   mod = Jewel.getmodule(code, cur, filemod = data[\"module\"])\n   completions = allcompletions(code, cur, mod = mod, file = data[\"path\"])\n   if completions == nothing\n+    temp = @d(:hints => [])\n     raise(editor, \"editor.julia.hints.update\",\n-          {:hints => {}})\n+            temp)\n   else\n+    temp = @d(:hints => completions[:hints],\n+              :pattern => completions[:pattern].pattern)\n     raise(editor, \"editor.julia.hints.update\",\n-          {:hints => completions[:hints],\n-           :pattern => completions[:pattern].pattern})\n+          temp)","path":"src/LightTable/completions.jl","position":null,"original_position":14,"commit_id":"18bbcb5a060edfd9d7cfbb77699e8fbb989a15b0","original_commit_id":"2db524d0804748cbbe63464c8fbede10991f8239","user":{"login":"nilshg","id":7264491,"avatar_url":"https://avatars.githubusercontent.com/u/7264491?v=3","gravatar_id":"","url":"https://api.github.com/users/nilshg","html_url":"https://github.com/nilshg","followers_url":"https://api.github.com/users/nilshg/followers","following_url":"https://api.github.com/users/nilshg/following{/other_user}","gists_url":"https://api.github.com/users/nilshg/gists{/gist_id}","starred_url":"https://api.github.com/users/nilshg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nilshg/subscriptions","organizations_url":"https://api.github.com/users/nilshg/orgs","repos_url":"https://api.github.com/users/nilshg/repos","events_url":"https://api.github.com/users/nilshg/events{/privacy}","received_events_url":"https://api.github.com/users/nilshg/received_events","type":"User","site_admin":false},"body":"Nope, sorry, this was a leftover - when I first started changing things to 0.4 syntax I got errors when using `@compat` as argument of a function call, so I resorted to constructing the Dict before the function call. This is actually unnecessary.","created_at":"2014-11-22T16:41:12Z","updated_at":"2014-11-22T16:41:12Z","html_url":"https://github.com/one-more-minute/Jewel.jl/pull/19#discussion_r20758194","pull_request_url":"https://api.github.com/repos/one-more-minute/Jewel.jl/pulls/19","_links":{"self":{"href":"https://api.github.com/repos/one-more-minute/Jewel.jl/pulls/comments/20758194"},"html":{"href":"https://github.com/one-more-minute/Jewel.jl/pull/19#discussion_r20758194"},"pull_request":{"href":"https://api.github.com/repos/one-more-minute/Jewel.jl/pulls/19"}}},"pull_request":{"url":"https://api.github.com/repos/one-more-minute/Jewel.jl/pulls/19","id":24772631,"html_url":"https://github.com/one-more-minute/Jewel.jl/pull/19","diff_url":"https://github.com/one-more-minute/Jewel.jl/pull/19.diff","patch_url":"https://github.com/one-more-minute/Jewel.jl/pull/19.patch","issue_url":"https://api.github.com/repos/one-more-minute/Jewel.jl/issues/19","number":19,"state":"open","locked":false,"title":"Compatibility to Julia v0.4","user":{"login":"nilshg","id":7264491,"avatar_url":"https://avatars.githubusercontent.com/u/7264491?v=3","gravatar_id":"","url":"https://api.github.com/users/nilshg","html_url":"https://github.com/nilshg","followers_url":"https://api.github.com/users/nilshg/followers","following_url":"https://api.github.com/users/nilshg/following{/other_user}","gists_url":"https://api.github.com/users/nilshg/gists{/gist_id}","starred_url":"https://api.github.com/users/nilshg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nilshg/subscriptions","organizations_url":"https://api.github.com/users/nilshg/orgs","repos_url":"https://api.github.com/users/nilshg/repos","events_url":"https://api.github.com/users/nilshg/events{/privacy}","received_events_url":"https://api.github.com/users/nilshg/received_events","type":"User","site_admin":false},"body":"Requires Compat.jl\r\nIn all my upcoming pull requests, there's a \"using Compat\" included in the file. Probably that's not the way to do it (I guess there should be a require Compat somewhere when loading the package, rather than a using in every file), but it won't work unless I do this on my machine.\r\n\r\nAll of this is tested to run with Light Table 0.7.1, Juno 0.9.1, Julia 0.9.2 plugins using both Julia versions 0.3.2 and 0.4.0  ","created_at":"2014-11-20T15:25:56Z","updated_at":"2014-11-22T16:41:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b6ab8c0f893d17b56db2d15ff4f0fd18f5be83f6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/one-more-minute/Jewel.jl/pulls/19/commits","review_comments_url":"https://api.github.com/repos/one-more-minute/Jewel.jl/pulls/19/comments","review_comment_url":"https://api.github.com/repos/one-more-minute/Jewel.jl/pulls/comments/{number}","comments_url":"https://api.github.com/repos/one-more-minute/Jewel.jl/issues/19/comments","statuses_url":"https://api.github.com/repos/one-more-minute/Jewel.jl/statuses/18bbcb5a060edfd9d7cfbb77699e8fbb989a15b0","head":{"label":"nilshg:master","ref":"master","sha":"18bbcb5a060edfd9d7cfbb77699e8fbb989a15b0","user":{"login":"nilshg","id":7264491,"avatar_url":"https://avatars.githubusercontent.com/u/7264491?v=3","gravatar_id":"","url":"https://api.github.com/users/nilshg","html_url":"https://github.com/nilshg","followers_url":"https://api.github.com/users/nilshg/followers","following_url":"https://api.github.com/users/nilshg/following{/other_user}","gists_url":"https://api.github.com/users/nilshg/gists{/gist_id}","starred_url":"https://api.github.com/users/nilshg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nilshg/subscriptions","organizations_url":"https://api.github.com/users/nilshg/orgs","repos_url":"https://api.github.com/users/nilshg/repos","events_url":"https://api.github.com/users/nilshg/events{/privacy}","received_events_url":"https://api.github.com/users/nilshg/received_events","type":"User","site_admin":false},"repo":{"id":26918159,"name":"Jewel.jl","full_name":"nilshg/Jewel.jl","owner":{"login":"nilshg","id":7264491,"avatar_url":"https://avatars.githubusercontent.com/u/7264491?v=3","gravatar_id":"","url":"https://api.github.com/users/nilshg","html_url":"https://github.com/nilshg","followers_url":"https://api.github.com/users/nilshg/followers","following_url":"https://api.github.com/users/nilshg/following{/other_user}","gists_url":"https://api.github.com/users/nilshg/gists{/gist_id}","starred_url":"https://api.github.com/users/nilshg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nilshg/subscriptions","organizations_url":"https://api.github.com/users/nilshg/orgs","repos_url":"https://api.github.com/users/nilshg/repos","events_url":"https://api.github.com/users/nilshg/events{/privacy}","received_events_url":"https://api.github.com/users/nilshg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nilshg/Jewel.jl","description":"IDE backend for Julia","fork":true,"url":"https://api.github.com/repos/nilshg/Jewel.jl","forks_url":"https://api.github.com/repos/nilshg/Jewel.jl/forks","keys_url":"https://api.github.com/repos/nilshg/Jewel.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nilshg/Jewel.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nilshg/Jewel.jl/teams","hooks_url":"https://api.github.com/repos/nilshg/Jewel.jl/hooks","issue_events_url":"https://api.github.com/repos/nilshg/Jewel.jl/issues/events{/number}","events_url":"https://api.github.com/repos/nilshg/Jewel.jl/events","assignees_url":"https://api.github.com/repos/nilshg/Jewel.jl/assignees{/user}","branches_url":"https://api.github.com/repos/nilshg/Jewel.jl/branches{/branch}","tags_url":"https://api.github.com/repos/nilshg/Jewel.jl/tags","blobs_url":"https://api.github.com/repos/nilshg/Jewel.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nilshg/Jewel.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nilshg/Jewel.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/nilshg/Jewel.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nilshg/Jewel.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/nilshg/Jewel.jl/languages","stargazers_url":"https://api.github.com/repos/nilshg/Jewel.jl/stargazers","contributors_url":"https://api.github.com/repos/nilshg/Jewel.jl/contributors","subscribers_url":"https://api.github.com/repos/nilshg/Jewel.jl/subscribers","subscription_url":"https://api.github.com/repos/nilshg/Jewel.jl/subscription","commits_url":"https://api.github.com/repos/nilshg/Jewel.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/nilshg/Jewel.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/nilshg/Jewel.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/nilshg/Jewel.jl/issues/comments/{number}","contents_url":"https://api.github.com/repos/nilshg/Jewel.jl/contents/{+path}","compare_url":"https://api.github.com/repos/nilshg/Jewel.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nilshg/Jewel.jl/merges","archive_url":"https://api.github.com/repos/nilshg/Jewel.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nilshg/Jewel.jl/downloads","issues_url":"https://api.github.com/repos/nilshg/Jewel.jl/issues{/number}","pulls_url":"https://api.github.com/repos/nilshg/Jewel.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/nilshg/Jewel.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/nilshg/Jewel.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nilshg/Jewel.jl/labels{/name}","releases_url":"https://api.github.com/repos/nilshg/Jewel.jl/releases{/id}","created_at":"2014-11-20T15:19:34Z","updated_at":"2014-11-22T16:39:06Z","pushed_at":"2014-11-22T16:39:06Z","git_url":"git://github.com/nilshg/Jewel.jl.git","ssh_url":"git@github.com:nilshg/Jewel.jl.git","clone_url":"https://github.com/nilshg/Jewel.jl.git","svn_url":"https://github.com/nilshg/Jewel.jl","homepage":"","size":339,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"one-more-minute:master","ref":"master","sha":"9a21bffc69da24de8d4579387387d58b411872df","user":{"login":"one-more-minute","id":2234614,"avatar_url":"https://avatars.githubusercontent.com/u/2234614?v=3","gravatar_id":"","url":"https://api.github.com/users/one-more-minute","html_url":"https://github.com/one-more-minute","followers_url":"https://api.github.com/users/one-more-minute/followers","following_url":"https://api.github.com/users/one-more-minute/following{/other_user}","gists_url":"https://api.github.com/users/one-more-minute/gists{/gist_id}","starred_url":"https://api.github.com/users/one-more-minute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/one-more-minute/subscriptions","organizations_url":"https://api.github.com/users/one-more-minute/orgs","repos_url":"https://api.github.com/users/one-more-minute/repos","events_url":"https://api.github.com/users/one-more-minute/events{/privacy}","received_events_url":"https://api.github.com/users/one-more-minute/received_events","type":"User","site_admin":false},"repo":{"id":16599434,"name":"Jewel.jl","full_name":"one-more-minute/Jewel.jl","owner":{"login":"one-more-minute","id":2234614,"avatar_url":"https://avatars.githubusercontent.com/u/2234614?v=3","gravatar_id":"","url":"https://api.github.com/users/one-more-minute","html_url":"https://github.com/one-more-minute","followers_url":"https://api.github.com/users/one-more-minute/followers","following_url":"https://api.github.com/users/one-more-minute/following{/other_user}","gists_url":"https://api.github.com/users/one-more-minute/gists{/gist_id}","starred_url":"https://api.github.com/users/one-more-minute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/one-more-minute/subscriptions","organizations_url":"https://api.github.com/users/one-more-minute/orgs","repos_url":"https://api.github.com/users/one-more-minute/repos","events_url":"https://api.github.com/users/one-more-minute/events{/privacy}","received_events_url":"https://api.github.com/users/one-more-minute/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/one-more-minute/Jewel.jl","description":"IDE backend for Julia","fork":false,"url":"https://api.github.com/repos/one-more-minute/Jewel.jl","forks_url":"https://api.github.com/repos/one-more-minute/Jewel.jl/forks","keys_url":"https://api.github.com/repos/one-more-minute/Jewel.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/one-more-minute/Jewel.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/one-more-minute/Jewel.jl/teams","hooks_url":"https://api.github.com/repos/one-more-minute/Jewel.jl/hooks","issue_events_url":"https://api.github.com/repos/one-more-minute/Jewel.jl/issues/events{/number}","events_url":"https://api.github.com/repos/one-more-minute/Jewel.jl/events","assignees_url":"https://api.github.com/repos/one-more-minute/Jewel.jl/assignees{/user}","branches_url":"https://api.github.com/repos/one-more-minute/Jewel.jl/branches{/branch}","tags_url":"https://api.github.com/repos/one-more-minute/Jewel.jl/tags","blobs_url":"https://api.github.com/repos/one-more-minute/Jewel.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/one-more-minute/Jewel.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/one-more-minute/Jewel.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/one-more-minute/Jewel.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/one-more-minute/Jewel.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/one-more-minute/Jewel.jl/languages","stargazers_url":"https://api.github.com/repos/one-more-minute/Jewel.jl/stargazers","contributors_url":"https://api.github.com/repos/one-more-minute/Jewel.jl/contributors","subscribers_url":"https://api.github.com/repos/one-more-minute/Jewel.jl/subscribers","subscription_url":"https://api.github.com/repos/one-more-minute/Jewel.jl/subscription","commits_url":"https://api.github.com/repos/one-more-minute/Jewel.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/one-more-minute/Jewel.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/one-more-minute/Jewel.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/one-more-minute/Jewel.jl/issues/comments/{number}","contents_url":"https://api.github.com/repos/one-more-minute/Jewel.jl/contents/{+path}","compare_url":"https://api.github.com/repos/one-more-minute/Jewel.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/one-more-minute/Jewel.jl/merges","archive_url":"https://api.github.com/repos/one-more-minute/Jewel.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/one-more-minute/Jewel.jl/downloads","issues_url":"https://api.github.com/repos/one-more-minute/Jewel.jl/issues{/number}","pulls_url":"https://api.github.com/repos/one-more-minute/Jewel.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/one-more-minute/Jewel.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/one-more-minute/Jewel.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/one-more-minute/Jewel.jl/labels{/name}","releases_url":"https://api.github.com/repos/one-more-minute/Jewel.jl/releases{/id}","created_at":"2014-02-07T00:31:50Z","updated_at":"2014-11-22T13:22:45Z","pushed_at":"2014-11-22T13:22:45Z","git_url":"git://github.com/one-more-minute/Jewel.jl.git","ssh_url":"git@github.com:one-more-minute/Jewel.jl.git","clone_url":"https://github.com/one-more-minute/Jewel.jl.git","svn_url":"https://github.com/one-more-minute/Jewel.jl","homepage":"","size":1817,"stargazers_count":15,"watchers_count":15,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":7,"forks":5,"open_issues":7,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/one-more-minute/Jewel.jl/pulls/19"},"html":{"href":"https://github.com/one-more-minute/Jewel.jl/pull/19"},"issue":{"href":"https://api.github.com/repos/one-more-minute/Jewel.jl/issues/19"},"comments":{"href":"https://api.github.com/repos/one-more-minute/Jewel.jl/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/one-more-minute/Jewel.jl/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/one-more-minute/Jewel.jl/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/one-more-minute/Jewel.jl/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/one-more-minute/Jewel.jl/statuses/18bbcb5a060edfd9d7cfbb77699e8fbb989a15b0"}}}}