GitHub PullRequestReviewCommentEvent at 2014-09-23 18:31:56
Repository: ogs
Actor: endJunction
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/ufz/ogs/pulls/comments/17928931","id":17928931,"diff_hunk":"@@ -242,6 +242,31 @@ bool isPointInTriangle(GeoLib::Point const& q,\n \treturn false;\n }\n \n+bool isPointInTetrahedron(GeoLib::Point const& p, GeoLib::Point const& a, GeoLib::Point const& b, \n+                          GeoLib::Point const& c, GeoLib::Point const& d)\n+{\n+    double const d0 (orient3d(d,a,b,c));\n+    // if tetrahedron is not coplanar\n+    if (d0 != 0)","path":"GeoLib/AnalyticalGeometry.cpp","position":9,"original_position":9,"commit_id":"aac4a828e877fcd450cce2b3adeb3f36c421cb25","original_commit_id":"aac4a828e877fcd450cce2b3adeb3f36c421cb25","user":{"login":"endJunction","id":329493,"avatar_url":"https://avatars.githubusercontent.com/u/329493?v=2","gravatar_id":"","url":"https://api.github.com/users/endJunction","html_url":"https://github.com/endJunction","followers_url":"https://api.github.com/users/endJunction/followers","following_url":"https://api.github.com/users/endJunction/following{/other_user}","gists_url":"https://api.github.com/users/endJunction/gists{/gist_id}","starred_url":"https://api.github.com/users/endJunction/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endJunction/subscriptions","organizations_url":"https://api.github.com/users/endJunction/orgs","repos_url":"https://api.github.com/users/endJunction/repos","events_url":"https://api.github.com/users/endJunction/events{/privacy}","received_events_url":"https://api.github.com/users/endJunction/received_events","type":"User","site_admin":false},"body":"`if (d0 == 0) return false;` => clarifies a special case.\r\nbtw. how coplanar is coplanar? Maybe an eps check is better here?","created_at":"2014-09-23T18:31:56Z","updated_at":"2014-09-23T18:31:56Z","html_url":"https://github.com/ufz/ogs/pull/481#discussion_r17928931","pull_request_url":"https://api.github.com/repos/ufz/ogs/pulls/481","_links":{"self":{"href":"https://api.github.com/repos/ufz/ogs/pulls/comments/17928931"},"html":{"href":"https://github.com/ufz/ogs/pull/481#discussion_r17928931"},"pull_request":{"href":"https://api.github.com/repos/ufz/ogs/pulls/481"}}},"pull_request":{"url":"https://api.github.com/repos/ufz/ogs/pulls/481","id":21649277,"html_url":"https://github.com/ufz/ogs/pull/481","diff_url":"https://github.com/ufz/ogs/pull/481.diff","patch_url":"https://github.com/ufz/ogs/pull/481.patch","issue_url":"https://api.github.com/repos/ufz/ogs/issues/481","number":481,"state":"open","locked":false,"title":"Test point in element","user":{"login":"rinkk","id":798445,"avatar_url":"https://avatars.githubusercontent.com/u/798445?v=2","gravatar_id":"","url":"https://api.github.com/users/rinkk","html_url":"https://github.com/rinkk","followers_url":"https://api.github.com/users/rinkk/followers","following_url":"https://api.github.com/users/rinkk/following{/other_user}","gists_url":"https://api.github.com/users/rinkk/gists{/gist_id}","starred_url":"https://api.github.com/users/rinkk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rinkk/subscriptions","organizations_url":"https://api.github.com/users/rinkk/orgs","repos_url":"https://api.github.com/users/rinkk/repos","events_url":"https://api.github.com/users/rinkk/events{/privacy}","received_events_url":"https://api.github.com/users/rinkk/received_events","type":"User","site_admin":false},"body":"Introduces extension of the Element-interface by adding a method ```bool isPntInElement(GeoLib::Point const& pnt)``` that will return true if the point is located either inside or on the boundary of the element and false otherwise.\r\nFor line-elements it tests if the point is located on that line, for 2D elements the point needs to be coplanar with the element nodes and located inside the 2D element.\r\n\r\nThis introduces a little redundancy to the current Face-interface (i.e. Tri's and Quad's) where already a method ```isPntInside(pnt, eps)``` exists which basically does the same but allows to specify an additional epsilon. Currently, I have left this method as it is. Should I remove it?","created_at":"2014-09-23T14:31:18Z","updated_at":"2014-09-23T18:31:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3fc038316841ab40028786270234d67477a36f99","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ufz/ogs/pulls/481/commits","review_comments_url":"https://api.github.com/repos/ufz/ogs/pulls/481/comments","review_comment_url":"https://api.github.com/repos/ufz/ogs/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ufz/ogs/issues/481/comments","statuses_url":"https://api.github.com/repos/ufz/ogs/statuses/aac4a828e877fcd450cce2b3adeb3f36c421cb25","head":{"label":"rinkk:IsPntInElement","ref":"IsPntInElement","sha":"aac4a828e877fcd450cce2b3adeb3f36c421cb25","user":{"login":"rinkk","id":798445,"avatar_url":"https://avatars.githubusercontent.com/u/798445?v=2","gravatar_id":"","url":"https://api.github.com/users/rinkk","html_url":"https://github.com/rinkk","followers_url":"https://api.github.com/users/rinkk/followers","following_url":"https://api.github.com/users/rinkk/following{/other_user}","gists_url":"https://api.github.com/users/rinkk/gists{/gist_id}","starred_url":"https://api.github.com/users/rinkk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rinkk/subscriptions","organizations_url":"https://api.github.com/users/rinkk/orgs","repos_url":"https://api.github.com/users/rinkk/repos","events_url":"https://api.github.com/users/rinkk/events{/privacy}","received_events_url":"https://api.github.com/users/rinkk/received_events","type":"User","site_admin":false},"repo":{"id":7148641,"name":"ogs","full_name":"rinkk/ogs","owner":{"login":"rinkk","id":798445,"avatar_url":"https://avatars.githubusercontent.com/u/798445?v=2","gravatar_id":"","url":"https://api.github.com/users/rinkk","html_url":"https://github.com/rinkk","followers_url":"https://api.github.com/users/rinkk/followers","following_url":"https://api.github.com/users/rinkk/following{/other_user}","gists_url":"https://api.github.com/users/rinkk/gists{/gist_id}","starred_url":"https://api.github.com/users/rinkk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rinkk/subscriptions","organizations_url":"https://api.github.com/users/rinkk/orgs","repos_url":"https://api.github.com/users/rinkk/repos","events_url":"https://api.github.com/users/rinkk/events{/privacy}","received_events_url":"https://api.github.com/users/rinkk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rinkk/ogs","description":"OGS source code","fork":true,"url":"https://api.github.com/repos/rinkk/ogs","forks_url":"https://api.github.com/repos/rinkk/ogs/forks","keys_url":"https://api.github.com/repos/rinkk/ogs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rinkk/ogs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rinkk/ogs/teams","hooks_url":"https://api.github.com/repos/rinkk/ogs/hooks","issue_events_url":"https://api.github.com/repos/rinkk/ogs/issues/events{/number}","events_url":"https://api.github.com/repos/rinkk/ogs/events","assignees_url":"https://api.github.com/repos/rinkk/ogs/assignees{/user}","branches_url":"https://api.github.com/repos/rinkk/ogs/branches{/branch}","tags_url":"https://api.github.com/repos/rinkk/ogs/tags","blobs_url":"https://api.github.com/repos/rinkk/ogs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rinkk/ogs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rinkk/ogs/git/refs{/sha}","trees_url":"https://api.github.com/repos/rinkk/ogs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rinkk/ogs/statuses/{sha}","languages_url":"https://api.github.com/repos/rinkk/ogs/languages","stargazers_url":"https://api.github.com/repos/rinkk/ogs/stargazers","contributors_url":"https://api.github.com/repos/rinkk/ogs/contributors","subscribers_url":"https://api.github.com/repos/rinkk/ogs/subscribers","subscription_url":"https://api.github.com/repos/rinkk/ogs/subscription","commits_url":"https://api.github.com/repos/rinkk/ogs/commits{/sha}","git_commits_url":"https://api.github.com/repos/rinkk/ogs/git/commits{/sha}","comments_url":"https://api.github.com/repos/rinkk/ogs/comments{/number}","issue_comment_url":"https://api.github.com/repos/rinkk/ogs/issues/comments/{number}","contents_url":"https://api.github.com/repos/rinkk/ogs/contents/{+path}","compare_url":"https://api.github.com/repos/rinkk/ogs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rinkk/ogs/merges","archive_url":"https://api.github.com/repos/rinkk/ogs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rinkk/ogs/downloads","issues_url":"https://api.github.com/repos/rinkk/ogs/issues{/number}","pulls_url":"https://api.github.com/repos/rinkk/ogs/pulls{/number}","milestones_url":"https://api.github.com/repos/rinkk/ogs/milestones{/number}","notifications_url":"https://api.github.com/repos/rinkk/ogs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rinkk/ogs/labels{/name}","releases_url":"https://api.github.com/repos/rinkk/ogs/releases{/id}","created_at":"2012-12-13T13:27:20Z","updated_at":"2014-09-01T13:43:48Z","pushed_at":"2014-09-23T14:25:10Z","git_url":"git://github.com/rinkk/ogs.git","ssh_url":"git@github.com:rinkk/ogs.git","clone_url":"https://github.com/rinkk/ogs.git","svn_url":"https://github.com/rinkk/ogs","homepage":"www.opengeosys.org","size":9178,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ufz:master","ref":"master","sha":"7a758e76555a4cc1ef57cb980bcf3c443e3e724c","user":{"login":"ufz","id":767517,"avatar_url":"https://avatars.githubusercontent.com/u/767517?v=2","gravatar_id":"","url":"https://api.github.com/users/ufz","html_url":"https://github.com/ufz","followers_url":"https://api.github.com/users/ufz/followers","following_url":"https://api.github.com/users/ufz/following{/other_user}","gists_url":"https://api.github.com/users/ufz/gists{/gist_id}","starred_url":"https://api.github.com/users/ufz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ufz/subscriptions","organizations_url":"https://api.github.com/users/ufz/orgs","repos_url":"https://api.github.com/users/ufz/repos","events_url":"https://api.github.com/users/ufz/events{/privacy}","received_events_url":"https://api.github.com/users/ufz/received_events","type":"Organization","site_admin":false},"repo":{"id":1701384,"name":"ogs","full_name":"ufz/ogs","owner":{"login":"ufz","id":767517,"avatar_url":"https://avatars.githubusercontent.com/u/767517?v=2","gravatar_id":"","url":"https://api.github.com/users/ufz","html_url":"https://github.com/ufz","followers_url":"https://api.github.com/users/ufz/followers","following_url":"https://api.github.com/users/ufz/following{/other_user}","gists_url":"https://api.github.com/users/ufz/gists{/gist_id}","starred_url":"https://api.github.com/users/ufz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ufz/subscriptions","organizations_url":"https://api.github.com/users/ufz/orgs","repos_url":"https://api.github.com/users/ufz/repos","events_url":"https://api.github.com/users/ufz/events{/privacy}","received_events_url":"https://api.github.com/users/ufz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ufz/ogs","description":"OGS source code","fork":false,"url":"https://api.github.com/repos/ufz/ogs","forks_url":"https://api.github.com/repos/ufz/ogs/forks","keys_url":"https://api.github.com/repos/ufz/ogs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ufz/ogs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ufz/ogs/teams","hooks_url":"https://api.github.com/repos/ufz/ogs/hooks","issue_events_url":"https://api.github.com/repos/ufz/ogs/issues/events{/number}","events_url":"https://api.github.com/repos/ufz/ogs/events","assignees_url":"https://api.github.com/repos/ufz/ogs/assignees{/user}","branches_url":"https://api.github.com/repos/ufz/ogs/branches{/branch}","tags_url":"https://api.github.com/repos/ufz/ogs/tags","blobs_url":"https://api.github.com/repos/ufz/ogs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ufz/ogs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ufz/ogs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ufz/ogs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ufz/ogs/statuses/{sha}","languages_url":"https://api.github.com/repos/ufz/ogs/languages","stargazers_url":"https://api.github.com/repos/ufz/ogs/stargazers","contributors_url":"https://api.github.com/repos/ufz/ogs/contributors","subscribers_url":"https://api.github.com/repos/ufz/ogs/subscribers","subscription_url":"https://api.github.com/repos/ufz/ogs/subscription","commits_url":"https://api.github.com/repos/ufz/ogs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ufz/ogs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ufz/ogs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ufz/ogs/issues/comments/{number}","contents_url":"https://api.github.com/repos/ufz/ogs/contents/{+path}","compare_url":"https://api.github.com/repos/ufz/ogs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ufz/ogs/merges","archive_url":"https://api.github.com/repos/ufz/ogs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ufz/ogs/downloads","issues_url":"https://api.github.com/repos/ufz/ogs/issues{/number}","pulls_url":"https://api.github.com/repos/ufz/ogs/pulls{/number}","milestones_url":"https://api.github.com/repos/ufz/ogs/milestones{/number}","notifications_url":"https://api.github.com/repos/ufz/ogs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ufz/ogs/labels{/name}","releases_url":"https://api.github.com/repos/ufz/ogs/releases{/id}","created_at":"2011-05-04T14:09:57Z","updated_at":"2014-09-02T11:52:00Z","pushed_at":"2014-09-23T14:13:48Z","git_url":"git://github.com/ufz/ogs.git","ssh_url":"git@github.com:ufz/ogs.git","clone_url":"https://github.com/ufz/ogs.git","svn_url":"https://github.com/ufz/ogs","homepage":"www.opengeosys.org","size":15010,"stargazers_count":13,"watchers_count":13,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":59,"forks":28,"open_issues":59,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ufz/ogs/pulls/481"},"html":{"href":"https://github.com/ufz/ogs/pull/481"},"issue":{"href":"https://api.github.com/repos/ufz/ogs/issues/481"},"comments":{"href":"https://api.github.com/repos/ufz/ogs/issues/481/comments"},"review_comments":{"href":"https://api.github.com/repos/ufz/ogs/pulls/481/comments"},"review_comment":{"href":"https://api.github.com/repos/ufz/ogs/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ufz/ogs/pulls/481/commits"},"statuses":{"href":"https://api.github.com/repos/ufz/ogs/statuses/aac4a828e877fcd450cce2b3adeb3f36c421cb25"}}}}