GitHub PullRequestEvent at 2014-06-04 10:06:32
Repository: GaugeView
Actor: misterbobdobalina
Payload: {"action":"opened","number":7,"pull_request":{"url":"https://api.github.com/repos/CodeAndMagic/GaugeView/pulls/7","id":16700284,"html_url":"https://github.com/CodeAndMagic/GaugeView/pull/7","diff_url":"https://github.com/CodeAndMagic/GaugeView/pull/7.diff","patch_url":"https://github.com/CodeAndMagic/GaugeView/pull/7.patch","issue_url":"https://api.github.com/repos/CodeAndMagic/GaugeView/issues/7","number":7,"state":"open","title":"Fixed api compatibility issues:","user":{"login":"misterbobdobalina","id":6367866,"avatar_url":"https://avatars.githubusercontent.com/u/6367866?","gravatar_id":"9e4acb04abf9bde33fd9502f32055b1e","url":"https://api.github.com/users/misterbobdobalina","html_url":"https://github.com/misterbobdobalina","followers_url":"https://api.github.com/users/misterbobdobalina/followers","following_url":"https://api.github.com/users/misterbobdobalina/following{/other_user}","gists_url":"https://api.github.com/users/misterbobdobalina/gists{/gist_id}","starred_url":"https://api.github.com/users/misterbobdobalina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/misterbobdobalina/subscriptions","organizations_url":"https://api.github.com/users/misterbobdobalina/orgs","repos_url":"https://api.github.com/users/misterbobdobalina/repos","events_url":"https://api.github.com/users/misterbobdobalina/events{/privacy}","received_events_url":"https://api.github.com/users/misterbobdobalina/received_events","type":"User","site_admin":false},"body":"ixed api compatibility issues:\r\n\r\nandroid:minSdkVersion=\"8\"\r\nandroid:targetSdkVersion=\"19\"\r\n\r\nHowever,\r\nTargetApi wasn't introduced until api level 16,\r\nwhich won't work with api level 8 as above.\r\n\r\nSame with:\r\nBuild.VERSION_CODES.HONEYCOMB added in api level 11\r\nView.LAYER_TYPE_SOFTWARE added in api level 11\r\nReplaced them with their constant values instead.\r\n\r\nI have verified that it works on api level 14. It won't compile\r\notherwise.\r\n\r\nFinally:\r\nreadRanges() never uses its input parameters in:\r\n    private void readRanges(final Resources res, final int rangesId, final int colorsId)\r\n\r\n        if (rangesId > 0 && colorsId > 0) {\r\n            final String[] ranges = res.getStringArray(R.array.ranges);\r\n            final String[] colors = res.getStringArray(R.array.rangeColors)\r\n            ...\r\n\r\n Changed it so that it uses rangesId and colorsId instead.\r\n\r\n I have tried this as an apklib an it workds. It was incorrect as\r\n it was before, because it wouldn't reference the correct resources\r\n if I remember correctly.","created_at":"2014-06-04T10:06:32Z","updated_at":"2014-06-04T10:06:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CodeAndMagic/GaugeView/pulls/7/commits","review_comments_url":"https://api.github.com/repos/CodeAndMagic/GaugeView/pulls/7/comments","review_comment_url":"https://api.github.com/repos/CodeAndMagic/GaugeView/pulls/comments/{number}","comments_url":"https://api.github.com/repos/CodeAndMagic/GaugeView/issues/7/comments","statuses_url":"https://api.github.com/repos/CodeAndMagic/GaugeView/statuses/816c4c9268e0c7a4b503d4633ecfefc34277e8f5","head":{"label":"misterbobdobalina:master","ref":"master","sha":"816c4c9268e0c7a4b503d4633ecfefc34277e8f5","user":{"login":"misterbobdobalina","id":6367866,"avatar_url":"https://avatars.githubusercontent.com/u/6367866?","gravatar_id":"9e4acb04abf9bde33fd9502f32055b1e","url":"https://api.github.com/users/misterbobdobalina","html_url":"https://github.com/misterbobdobalina","followers_url":"https://api.github.com/users/misterbobdobalina/followers","following_url":"https://api.github.com/users/misterbobdobalina/following{/other_user}","gists_url":"https://api.github.com/users/misterbobdobalina/gists{/gist_id}","starred_url":"https://api.github.com/users/misterbobdobalina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/misterbobdobalina/subscriptions","organizations_url":"https://api.github.com/users/misterbobdobalina/orgs","repos_url":"https://api.github.com/users/misterbobdobalina/repos","events_url":"https://api.github.com/users/misterbobdobalina/events{/privacy}","received_events_url":"https://api.github.com/users/misterbobdobalina/received_events","type":"User","site_admin":false},"repo":{"id":20476946,"name":"GaugeView","full_name":"misterbobdobalina/GaugeView","owner":{"login":"misterbobdobalina","id":6367866,"avatar_url":"https://avatars.githubusercontent.com/u/6367866?","gravatar_id":"9e4acb04abf9bde33fd9502f32055b1e","url":"https://api.github.com/users/misterbobdobalina","html_url":"https://github.com/misterbobdobalina","followers_url":"https://api.github.com/users/misterbobdobalina/followers","following_url":"https://api.github.com/users/misterbobdobalina/following{/other_user}","gists_url":"https://api.github.com/users/misterbobdobalina/gists{/gist_id}","starred_url":"https://api.github.com/users/misterbobdobalina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/misterbobdobalina/subscriptions","organizations_url":"https://api.github.com/users/misterbobdobalina/orgs","repos_url":"https://api.github.com/users/misterbobdobalina/repos","events_url":"https://api.github.com/users/misterbobdobalina/events{/privacy}","received_events_url":"https://api.github.com/users/misterbobdobalina/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/misterbobdobalina/GaugeView","description":"An Android library for drawing gauges on Canvas.","fork":true,"url":"https://api.github.com/repos/misterbobdobalina/GaugeView","forks_url":"https://api.github.com/repos/misterbobdobalina/GaugeView/forks","keys_url":"https://api.github.com/repos/misterbobdobalina/GaugeView/keys{/key_id}","collaborators_url":"https://api.github.com/repos/misterbobdobalina/GaugeView/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/misterbobdobalina/GaugeView/teams","hooks_url":"https://api.github.com/repos/misterbobdobalina/GaugeView/hooks","issue_events_url":"https://api.github.com/repos/misterbobdobalina/GaugeView/issues/events{/number}","events_url":"https://api.github.com/repos/misterbobdobalina/GaugeView/events","assignees_url":"https://api.github.com/repos/misterbobdobalina/GaugeView/assignees{/user}","branches_url":"https://api.github.com/repos/misterbobdobalina/GaugeView/branches{/branch}","tags_url":"https://api.github.com/repos/misterbobdobalina/GaugeView/tags","blobs_url":"https://api.github.com/repos/misterbobdobalina/GaugeView/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/misterbobdobalina/GaugeView/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/misterbobdobalina/GaugeView/git/refs{/sha}","trees_url":"https://api.github.com/repos/misterbobdobalina/GaugeView/git/trees{/sha}","statuses_url":"https://api.github.com/repos/misterbobdobalina/GaugeView/statuses/{sha}","languages_url":"https://api.github.com/repos/misterbobdobalina/GaugeView/languages","stargazers_url":"https://api.github.com/repos/misterbobdobalina/GaugeView/stargazers","contributors_url":"https://api.github.com/repos/misterbobdobalina/GaugeView/contributors","subscribers_url":"https://api.github.com/repos/misterbobdobalina/GaugeView/subscribers","subscription_url":"https://api.github.com/repos/misterbobdobalina/GaugeView/subscription","commits_url":"https://api.github.com/repos/misterbobdobalina/GaugeView/commits{/sha}","git_commits_url":"https://api.github.com/repos/misterbobdobalina/GaugeView/git/commits{/sha}","comments_url":"https://api.github.com/repos/misterbobdobalina/GaugeView/comments{/number}","issue_comment_url":"https://api.github.com/repos/misterbobdobalina/GaugeView/issues/comments/{number}","contents_url":"https://api.github.com/repos/misterbobdobalina/GaugeView/contents/{+path}","compare_url":"https://api.github.com/repos/misterbobdobalina/GaugeView/compare/{base}...{head}","merges_url":"https://api.github.com/repos/misterbobdobalina/GaugeView/merges","archive_url":"https://api.github.com/repos/misterbobdobalina/GaugeView/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/misterbobdobalina/GaugeView/downloads","issues_url":"https://api.github.com/repos/misterbobdobalina/GaugeView/issues{/number}","pulls_url":"https://api.github.com/repos/misterbobdobalina/GaugeView/pulls{/number}","milestones_url":"https://api.github.com/repos/misterbobdobalina/GaugeView/milestones{/number}","notifications_url":"https://api.github.com/repos/misterbobdobalina/GaugeView/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/misterbobdobalina/GaugeView/labels{/name}","releases_url":"https://api.github.com/repos/misterbobdobalina/GaugeView/releases{/id}","created_at":"2014-06-04T09:09:38Z","updated_at":"2014-06-04T10:06:32Z","pushed_at":"2014-06-04T10:03:05Z","git_url":"git://github.com/misterbobdobalina/GaugeView.git","ssh_url":"git@github.com:misterbobdobalina/GaugeView.git","clone_url":"https://github.com/misterbobdobalina/GaugeView.git","svn_url":"https://github.com/misterbobdobalina/GaugeView","homepage":null,"size":1302,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CodeAndMagic:master","ref":"master","sha":"380ee02b63effcc80917bb17020a6ebb9e89ca8c","user":{"login":"CodeAndMagic","id":521692,"avatar_url":"https://avatars.githubusercontent.com/u/521692?","gravatar_id":"c3bc2bb4734feca625abde2a676234d6","url":"https://api.github.com/users/CodeAndMagic","html_url":"https://github.com/CodeAndMagic","followers_url":"https://api.github.com/users/CodeAndMagic/followers","following_url":"https://api.github.com/users/CodeAndMagic/following{/other_user}","gists_url":"https://api.github.com/users/CodeAndMagic/gists{/gist_id}","starred_url":"https://api.github.com/users/CodeAndMagic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodeAndMagic/subscriptions","organizations_url":"https://api.github.com/users/CodeAndMagic/orgs","repos_url":"https://api.github.com/users/CodeAndMagic/repos","events_url":"https://api.github.com/users/CodeAndMagic/events{/privacy}","received_events_url":"https://api.github.com/users/CodeAndMagic/received_events","type":"Organization","site_admin":false},"repo":{"id":5601454,"name":"GaugeView","full_name":"CodeAndMagic/GaugeView","owner":{"login":"CodeAndMagic","id":521692,"avatar_url":"https://avatars.githubusercontent.com/u/521692?","gravatar_id":"c3bc2bb4734feca625abde2a676234d6","url":"https://api.github.com/users/CodeAndMagic","html_url":"https://github.com/CodeAndMagic","followers_url":"https://api.github.com/users/CodeAndMagic/followers","following_url":"https://api.github.com/users/CodeAndMagic/following{/other_user}","gists_url":"https://api.github.com/users/CodeAndMagic/gists{/gist_id}","starred_url":"https://api.github.com/users/CodeAndMagic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodeAndMagic/subscriptions","organizations_url":"https://api.github.com/users/CodeAndMagic/orgs","repos_url":"https://api.github.com/users/CodeAndMagic/repos","events_url":"https://api.github.com/users/CodeAndMagic/events{/privacy}","received_events_url":"https://api.github.com/users/CodeAndMagic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CodeAndMagic/GaugeView","description":"An Android library for drawing gauges on Canvas.","fork":false,"url":"https://api.github.com/repos/CodeAndMagic/GaugeView","forks_url":"https://api.github.com/repos/CodeAndMagic/GaugeView/forks","keys_url":"https://api.github.com/repos/CodeAndMagic/GaugeView/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CodeAndMagic/GaugeView/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CodeAndMagic/GaugeView/teams","hooks_url":"https://api.github.com/repos/CodeAndMagic/GaugeView/hooks","issue_events_url":"https://api.github.com/repos/CodeAndMagic/GaugeView/issues/events{/number}","events_url":"https://api.github.com/repos/CodeAndMagic/GaugeView/events","assignees_url":"https://api.github.com/repos/CodeAndMagic/GaugeView/assignees{/user}","branches_url":"https://api.github.com/repos/CodeAndMagic/GaugeView/branches{/branch}","tags_url":"https://api.github.com/repos/CodeAndMagic/GaugeView/tags","blobs_url":"https://api.github.com/repos/CodeAndMagic/GaugeView/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CodeAndMagic/GaugeView/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CodeAndMagic/GaugeView/git/refs{/sha}","trees_url":"https://api.github.com/repos/CodeAndMagic/GaugeView/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CodeAndMagic/GaugeView/statuses/{sha}","languages_url":"https://api.github.com/repos/CodeAndMagic/GaugeView/languages","stargazers_url":"https://api.github.com/repos/CodeAndMagic/GaugeView/stargazers","contributors_url":"https://api.github.com/repos/CodeAndMagic/GaugeView/contributors","subscribers_url":"https://api.github.com/repos/CodeAndMagic/GaugeView/subscribers","subscription_url":"https://api.github.com/repos/CodeAndMagic/GaugeView/subscription","commits_url":"https://api.github.com/repos/CodeAndMagic/GaugeView/commits{/sha}","git_commits_url":"https://api.github.com/repos/CodeAndMagic/GaugeView/git/commits{/sha}","comments_url":"https://api.github.com/repos/CodeAndMagic/GaugeView/comments{/number}","issue_comment_url":"https://api.github.com/repos/CodeAndMagic/GaugeView/issues/comments/{number}","contents_url":"https://api.github.com/repos/CodeAndMagic/GaugeView/contents/{+path}","compare_url":"https://api.github.com/repos/CodeAndMagic/GaugeView/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CodeAndMagic/GaugeView/merges","archive_url":"https://api.github.com/repos/CodeAndMagic/GaugeView/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CodeAndMagic/GaugeView/downloads","issues_url":"https://api.github.com/repos/CodeAndMagic/GaugeView/issues{/number}","pulls_url":"https://api.github.com/repos/CodeAndMagic/GaugeView/pulls{/number}","milestones_url":"https://api.github.com/repos/CodeAndMagic/GaugeView/milestones{/number}","notifications_url":"https://api.github.com/repos/CodeAndMagic/GaugeView/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CodeAndMagic/GaugeView/labels{/name}","releases_url":"https://api.github.com/repos/CodeAndMagic/GaugeView/releases{/id}","created_at":"2012-08-29T14:13:15Z","updated_at":"2014-06-03T07:08:34Z","pushed_at":"2014-01-14T21:16:19Z","git_url":"git://github.com/CodeAndMagic/GaugeView.git","ssh_url":"git@github.com:CodeAndMagic/GaugeView.git","clone_url":"https://github.com/CodeAndMagic/GaugeView.git","svn_url":"https://github.com/CodeAndMagic/GaugeView","homepage":null,"size":1302,"stargazers_count":92,"watchers_count":92,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":47,"mirror_url":null,"open_issues_count":6,"forks":47,"open_issues":6,"watchers":92,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CodeAndMagic/GaugeView/pulls/7"},"html":{"href":"https://github.com/CodeAndMagic/GaugeView/pull/7"},"issue":{"href":"https://api.github.com/repos/CodeAndMagic/GaugeView/issues/7"},"comments":{"href":"https://api.github.com/repos/CodeAndMagic/GaugeView/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/CodeAndMagic/GaugeView/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/CodeAndMagic/GaugeView/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/CodeAndMagic/GaugeView/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/CodeAndMagic/GaugeView/statuses/816c4c9268e0c7a4b503d4633ecfefc34277e8f5"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":5,"deletions":20,"changed_files":1}}