GitHub PullRequestEvent at 2014-03-15 21:55:54
Repository: http
Actor: ixti
Payload: {"action":"closed","number":97,"pull_request":{"url":"https://api.github.com/repos/tarcieri/http/pulls/97","id":13576639,"html_url":"https://github.com/tarcieri/http/pull/97","diff_url":"https://github.com/tarcieri/http/pull/97.diff","patch_url":"https://github.com/tarcieri/http/pull/97.patch","issue_url":"https://api.github.com/repos/tarcieri/http/issues/97","number":97,"state":"closed","title":"Fix Request#redirect","user":{"login":"challengee","id":68248,"avatar_url":"https://gravatar.com/avatar/6e9f97c8a65905a3432a5c8385015511?d=https%3A%2F%2Fidenticons.github.com%2Fdd2cf52976e02d7114123023191745ea.png&r=x","gravatar_id":"6e9f97c8a65905a3432a5c8385015511","url":"https://api.github.com/users/challengee","html_url":"https://github.com/challengee","followers_url":"https://api.github.com/users/challengee/followers","following_url":"https://api.github.com/users/challengee/following{/other_user}","gists_url":"https://api.github.com/users/challengee/gists{/gist_id}","starred_url":"https://api.github.com/users/challengee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/challengee/subscriptions","organizations_url":"https://api.github.com/users/challengee/orgs","repos_url":"https://api.github.com/users/challengee/repos","events_url":"https://api.github.com/users/challengee/events{/privacy}","received_events_url":"https://api.github.com/users/challengee/received_events","type":"User","site_admin":false},"body":"The `Request#redirect` does not work correctly and is untested. I fixed the method and added a spec.\r\n\r\n* Add missing proxy argument to new call\r\n* Actually replace the host instead of “adding” one\r\n\r\nReplacing the host through `merge!` is not the most transparent... maybe we should look again at the implementation of `Headers#[]=`.\r\n\r\nThanks for this great library ;)","created_at":"2014-03-14T15:35:01Z","updated_at":"2014-03-15T21:55:52Z","closed_at":"2014-03-15T21:55:52Z","merged_at":null,"merge_commit_sha":"a30109d8d942f5dc177b406385e4535ce6047a54","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tarcieri/http/pulls/97/commits","review_comments_url":"https://api.github.com/repos/tarcieri/http/pulls/97/comments","review_comment_url":"https://api.github.com/repos/tarcieri/http/pulls/comments/{number}","comments_url":"https://api.github.com/repos/tarcieri/http/issues/97/comments","statuses_url":"https://api.github.com/repos/tarcieri/http/statuses/6fb176398e0fee9960199817dcf408e5f6803537","head":{"label":"challengee:redirect-fixes","ref":"redirect-fixes","sha":"6fb176398e0fee9960199817dcf408e5f6803537","user":{"login":"challengee","id":68248,"avatar_url":"https://gravatar.com/avatar/6e9f97c8a65905a3432a5c8385015511?d=https%3A%2F%2Fidenticons.github.com%2Fdd2cf52976e02d7114123023191745ea.png&r=x","gravatar_id":"6e9f97c8a65905a3432a5c8385015511","url":"https://api.github.com/users/challengee","html_url":"https://github.com/challengee","followers_url":"https://api.github.com/users/challengee/followers","following_url":"https://api.github.com/users/challengee/following{/other_user}","gists_url":"https://api.github.com/users/challengee/gists{/gist_id}","starred_url":"https://api.github.com/users/challengee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/challengee/subscriptions","organizations_url":"https://api.github.com/users/challengee/orgs","repos_url":"https://api.github.com/users/challengee/repos","events_url":"https://api.github.com/users/challengee/events{/privacy}","received_events_url":"https://api.github.com/users/challengee/received_events","type":"User","site_admin":false},"repo":{"id":17750307,"name":"http","full_name":"challengee/http","owner":{"login":"challengee","id":68248,"avatar_url":"https://gravatar.com/avatar/6e9f97c8a65905a3432a5c8385015511?d=https%3A%2F%2Fidenticons.github.com%2Fdd2cf52976e02d7114123023191745ea.png&r=x","gravatar_id":"6e9f97c8a65905a3432a5c8385015511","url":"https://api.github.com/users/challengee","html_url":"https://github.com/challengee","followers_url":"https://api.github.com/users/challengee/followers","following_url":"https://api.github.com/users/challengee/following{/other_user}","gists_url":"https://api.github.com/users/challengee/gists{/gist_id}","starred_url":"https://api.github.com/users/challengee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/challengee/subscriptions","organizations_url":"https://api.github.com/users/challengee/orgs","repos_url":"https://api.github.com/users/challengee/repos","events_url":"https://api.github.com/users/challengee/events{/privacy}","received_events_url":"https://api.github.com/users/challengee/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/challengee/http","description":"The HTTP Gem: a simple Ruby DSL for making HTTP requests","fork":true,"url":"https://api.github.com/repos/challengee/http","forks_url":"https://api.github.com/repos/challengee/http/forks","keys_url":"https://api.github.com/repos/challengee/http/keys{/key_id}","collaborators_url":"https://api.github.com/repos/challengee/http/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/challengee/http/teams","hooks_url":"https://api.github.com/repos/challengee/http/hooks","issue_events_url":"https://api.github.com/repos/challengee/http/issues/events{/number}","events_url":"https://api.github.com/repos/challengee/http/events","assignees_url":"https://api.github.com/repos/challengee/http/assignees{/user}","branches_url":"https://api.github.com/repos/challengee/http/branches{/branch}","tags_url":"https://api.github.com/repos/challengee/http/tags","blobs_url":"https://api.github.com/repos/challengee/http/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/challengee/http/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/challengee/http/git/refs{/sha}","trees_url":"https://api.github.com/repos/challengee/http/git/trees{/sha}","statuses_url":"https://api.github.com/repos/challengee/http/statuses/{sha}","languages_url":"https://api.github.com/repos/challengee/http/languages","stargazers_url":"https://api.github.com/repos/challengee/http/stargazers","contributors_url":"https://api.github.com/repos/challengee/http/contributors","subscribers_url":"https://api.github.com/repos/challengee/http/subscribers","subscription_url":"https://api.github.com/repos/challengee/http/subscription","commits_url":"https://api.github.com/repos/challengee/http/commits{/sha}","git_commits_url":"https://api.github.com/repos/challengee/http/git/commits{/sha}","comments_url":"https://api.github.com/repos/challengee/http/comments{/number}","issue_comment_url":"https://api.github.com/repos/challengee/http/issues/comments/{number}","contents_url":"https://api.github.com/repos/challengee/http/contents/{+path}","compare_url":"https://api.github.com/repos/challengee/http/compare/{base}...{head}","merges_url":"https://api.github.com/repos/challengee/http/merges","archive_url":"https://api.github.com/repos/challengee/http/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/challengee/http/downloads","issues_url":"https://api.github.com/repos/challengee/http/issues{/number}","pulls_url":"https://api.github.com/repos/challengee/http/pulls{/number}","milestones_url":"https://api.github.com/repos/challengee/http/milestones{/number}","notifications_url":"https://api.github.com/repos/challengee/http/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/challengee/http/labels{/name}","releases_url":"https://api.github.com/repos/challengee/http/releases{/id}","created_at":"2014-03-14T15:14:55Z","updated_at":"2014-03-15T21:55:52Z","pushed_at":"2014-03-14T15:32:00Z","git_url":"git://github.com/challengee/http.git","ssh_url":"git@github.com:challengee/http.git","clone_url":"https://github.com/challengee/http.git","svn_url":"https://github.com/challengee/http","homepage":"","size":2938,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"tarcieri:master","ref":"master","sha":"36d78b148fafdc6ca4626c7affd06a882acb8162","user":{"login":"tarcieri","id":797,"avatar_url":"https://gravatar.com/avatar/4131d2f57a0db2a2b4d9a62bd389fd44?d=https%3A%2F%2Fidenticons.github.com%2Fbeb22fb694d513edcf5533cf006dfeae.png&r=x","gravatar_id":"4131d2f57a0db2a2b4d9a62bd389fd44","url":"https://api.github.com/users/tarcieri","html_url":"https://github.com/tarcieri","followers_url":"https://api.github.com/users/tarcieri/followers","following_url":"https://api.github.com/users/tarcieri/following{/other_user}","gists_url":"https://api.github.com/users/tarcieri/gists{/gist_id}","starred_url":"https://api.github.com/users/tarcieri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tarcieri/subscriptions","organizations_url":"https://api.github.com/users/tarcieri/orgs","repos_url":"https://api.github.com/users/tarcieri/repos","events_url":"https://api.github.com/users/tarcieri/events{/privacy}","received_events_url":"https://api.github.com/users/tarcieri/received_events","type":"User","site_admin":false},"repo":{"id":2524005,"name":"http","full_name":"tarcieri/http","owner":{"login":"tarcieri","id":797,"avatar_url":"https://gravatar.com/avatar/4131d2f57a0db2a2b4d9a62bd389fd44?d=https%3A%2F%2Fidenticons.github.com%2Fbeb22fb694d513edcf5533cf006dfeae.png&r=x","gravatar_id":"4131d2f57a0db2a2b4d9a62bd389fd44","url":"https://api.github.com/users/tarcieri","html_url":"https://github.com/tarcieri","followers_url":"https://api.github.com/users/tarcieri/followers","following_url":"https://api.github.com/users/tarcieri/following{/other_user}","gists_url":"https://api.github.com/users/tarcieri/gists{/gist_id}","starred_url":"https://api.github.com/users/tarcieri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tarcieri/subscriptions","organizations_url":"https://api.github.com/users/tarcieri/orgs","repos_url":"https://api.github.com/users/tarcieri/repos","events_url":"https://api.github.com/users/tarcieri/events{/privacy}","received_events_url":"https://api.github.com/users/tarcieri/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tarcieri/http","description":"The HTTP Gem: a simple Ruby DSL for making HTTP requests","fork":false,"url":"https://api.github.com/repos/tarcieri/http","forks_url":"https://api.github.com/repos/tarcieri/http/forks","keys_url":"https://api.github.com/repos/tarcieri/http/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tarcieri/http/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tarcieri/http/teams","hooks_url":"https://api.github.com/repos/tarcieri/http/hooks","issue_events_url":"https://api.github.com/repos/tarcieri/http/issues/events{/number}","events_url":"https://api.github.com/repos/tarcieri/http/events","assignees_url":"https://api.github.com/repos/tarcieri/http/assignees{/user}","branches_url":"https://api.github.com/repos/tarcieri/http/branches{/branch}","tags_url":"https://api.github.com/repos/tarcieri/http/tags","blobs_url":"https://api.github.com/repos/tarcieri/http/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tarcieri/http/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tarcieri/http/git/refs{/sha}","trees_url":"https://api.github.com/repos/tarcieri/http/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tarcieri/http/statuses/{sha}","languages_url":"https://api.github.com/repos/tarcieri/http/languages","stargazers_url":"https://api.github.com/repos/tarcieri/http/stargazers","contributors_url":"https://api.github.com/repos/tarcieri/http/contributors","subscribers_url":"https://api.github.com/repos/tarcieri/http/subscribers","subscription_url":"https://api.github.com/repos/tarcieri/http/subscription","commits_url":"https://api.github.com/repos/tarcieri/http/commits{/sha}","git_commits_url":"https://api.github.com/repos/tarcieri/http/git/commits{/sha}","comments_url":"https://api.github.com/repos/tarcieri/http/comments{/number}","issue_comment_url":"https://api.github.com/repos/tarcieri/http/issues/comments/{number}","contents_url":"https://api.github.com/repos/tarcieri/http/contents/{+path}","compare_url":"https://api.github.com/repos/tarcieri/http/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tarcieri/http/merges","archive_url":"https://api.github.com/repos/tarcieri/http/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tarcieri/http/downloads","issues_url":"https://api.github.com/repos/tarcieri/http/issues{/number}","pulls_url":"https://api.github.com/repos/tarcieri/http/pulls{/number}","milestones_url":"https://api.github.com/repos/tarcieri/http/milestones{/number}","notifications_url":"https://api.github.com/repos/tarcieri/http/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tarcieri/http/labels{/name}","releases_url":"https://api.github.com/repos/tarcieri/http/releases{/id}","created_at":"2011-10-06T04:19:10Z","updated_at":"2014-03-15T21:54:58Z","pushed_at":"2014-03-15T21:54:58Z","git_url":"git://github.com/tarcieri/http.git","ssh_url":"git@github.com:tarcieri/http.git","clone_url":"https://github.com/tarcieri/http.git","svn_url":"https://github.com/tarcieri/http","homepage":"","size":2938,"stargazers_count":475,"watchers_count":475,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":46,"mirror_url":null,"open_issues_count":13,"forks":46,"open_issues":13,"watchers":475,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tarcieri/http/pulls/97"},"html":{"href":"https://github.com/tarcieri/http/pull/97"},"issue":{"href":"https://api.github.com/repos/tarcieri/http/issues/97"},"comments":{"href":"https://api.github.com/repos/tarcieri/http/issues/97/comments"},"review_comments":{"href":"https://api.github.com/repos/tarcieri/http/pulls/97/comments"},"review_comment":{"href":"https://api.github.com/repos/tarcieri/http/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/tarcieri/http/pulls/97/commits"},"statuses":{"href":"https://api.github.com/repos/tarcieri/http/statuses/6fb176398e0fee9960199817dcf408e5f6803537"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":2,"review_comments":0,"commits":1,"additions":17,"deletions":2,"changed_files":2}}