GitHub PushEvent at 2014-12-22 05:39:59
Repository: rails
Actor: tgxworld
Payload: {"shas":[["aa9d1332b20305dd860b21a7ada06c5252bebad5","46912bed2c3b56d601323fb1c76bee025b5234eb@gmail.com","[Testing guide] Use \"Fixtures API\" instead of \"fixture api\".","Prathamesh Sonpatki",true],["9109365ab9e07a893b68c7d208591a083871a4e8","46912bed2c3b56d601323fb1c76bee025b5234eb@gmail.com","[Testing guide] Using \"Fixtures API\" consistently\n\n- In guides, \"API\" is used consistently instead of \"api\".\n- Reason behind replacing \"fixtures API\" to \"Fixtures API\" is because\n  here we are referring to the concept of \"fixtures\". In other places in\n  the guide \"fixture\" OR \"fixtures\" is referred to the single or\n  multiple instances of test data.\n- This is also followup of https://github.com/rails/docrails/commit/aa9d1332b20305dd860b21a7ada06c5252bebad5#commitcomment-8497376.","Prathamesh Sonpatki",true],["bd9ffa7e1fb433f359ee096a2afd924a652d1912","62206885db46acd03a938c8b3a626f8152619019@gmail.com","Fix grammar on ActiveRecord::AttributeMethods doc.\n\n[ci skip]","Hendy Tanata",true],["f7dbf388bd867cba7a66abf44affb09960ccb4c1","6f09c0de2880731daf652fc34f199742fe7a6c57@gmail.com","allow 'all' for :domain option in addition to :all","rockrep",true],["f9411b464dd477131540d32bed1fa8f18ef5ee4c","16356534c1589fe78070f5640bedf8614007153c@gmail.com","Don't remove mailer layouts files","yuuji.yaginuma",true],["cbcec99fdbd635bba77bcc94c8622369690bdb4a","1d6e1cf70ec6f9ab28d3ea4b27a49a77654d370e@yukinishijima.net","Remove custom errors page section from the guides\n\nThis pattern is too problematic and introduces a lot of edge cases:\n\n  * On 4.2, the issue https://github.com/rails/rails/issues/15124 is\n    back again.\n  * needs to define each action for each http status otherwise the\n    router raises ActionController::RoutingError (No route matches).\n  * If the router has `match \"/*username\",...` and some action is\n    missing, Rails will pick up the \"match\" and try to do its job.\n  * encourages people to copy & paste programming. Not DRY.\n\n[ci skip]","Yuki Nishijima",true],["2fa4cbeebde4cbaf4fdddb1723960710c67f89a8","595dd64ae70cba48b18751fc0e175aad48f66f12@aripollak.com","Fix Sidekiq ActiveJob integration setup\n\n* .connect on a Redis connection wasn't valid\n* Reset logger after we're done testing for redis connection to avoid\n  \"closed stream\" error when starting server for real from a fork","Ari Pollak",true],["802630378e5ed7ffae500034bc926b8318524e43","595dd64ae70cba48b18751fc0e175aad48f66f12@aripollak.com","Hide potentially sensitive ActiveJob params from logs\n\n* Show GlobalID instead of full object .inspect output","Ari Pollak",true],["079ac4a0584b24625266a0e9448503d1b96c2b7f","6fa5945caf8e8f3cd65cd902d129ab2b0a35637e@gmail.com","Merge branch 'master' of github.com:rails/rails","Vijay Dev",true],["25c8ea264ea4d690da00439d1414083750a52616","595dd64ae70cba48b18751fc0e175aad48f66f12@aripollak.com","Only filter GIDable objects; remove cosmetic changes","Ari Pollak",true],["05a6fafdd5559ff53897afb8a2aff353e5ac8805","46912bed2c3b56d601323fb1c76bee025b5234eb@gmail.com","Removed use of mocha in the info_controller tests","Prathamesh Sonpatki",true],["ccc3ddb7762bae0df7e2f8d643b19b6a4769d5be","20b70f0af00562e63758b9ee42012ecc96c58590@khabarov.ca","fixing mailer previews for apps with globbing route","Oleg",true],["286ab9b606f726787bbfdf8d426380d4b42e65f1","0ecfbc3894c7b8e374232cadc0afa67162a600be@thoughtbot.com","Move PredicateBuilder instantiation to constructor\n\nIn order to maintain thread safety and prevent race condition from memoization.","Melanie Gilman",true],["b612df9a25db1b7e509c6410b3f4fbd4a87144c4","d7e19930cc1f42c2d0781f4d9e6f1fe5891bf9cf@seantheprogrammer.com","Merge pull request #17898 from mrgilman/move-predicate-builder-to-constructor\n\nMove PredicateBuilder instantiation to constructor","Sean Griffin",true],["a83ad97f473a684417dc22fd7854ee5526e1b8ca","5282eb8a112e0c62fe591e7e5c0a8d029936dc09@gmail.com","Merge pull request #17891 from prathamesh-sonpatki/remove-mocha-from-info-controller-tests\n\nRemoved use of mocha in the info_controller tests","Guillermo Iguaran",true],["db64f5d7ebef9834dcfe8476c3e8941cd9ce598c","6229a3e4f86172a005a6eaab5029d1bd13acce1f@gocardless.com","Clarify that batching methods can be used with any orderable type primary key, not just integer ones, as per @a58cafeb3a86be46849de57481b6644094fb8165","Isaac Seymour",true],["8dcfc5d0814942edfb8bb07366fd2a57bdea3512","bca6f4261a19f75277fe4325de3272d15492eb61@gmail.com","Prevent Symbol GC","Ryuta Kamizono",true],["9fd4fbd1fb74f1eafed456875e39164ae0f6d7c8","ebd73beb044ee5759f027a56464cea105bbc60a7@gmail.com","Add documentation to MessageVerifier\n\n[ci skip]\n\nComplements #17727 and closes ee73d9ff8.\n\n@lleger How do you feel about this?","claudiob",true],["e428ddececf43923dec4299c40b29451e5bea80d","ebd73beb044ee5759f027a56464cea105bbc60a7@gmail.com","Remove \"rescue\" clause around \"require 'openssl'\"\n\nSome `require 'openssl'` statements were surrounded by `rescue` blocks to deal with Ruby versions that did not support `OpenSSL::Digest::SHA1` or `OpenSSL::PKCS5`.\n\n[As @jeremy explains](https://github.com/rails/rails/commit/a6a0904fcb12b876469c48b1c885aadafe9188cf#commitcomment-8826666) in the original commit:\n\n> If jruby didn't have jruby-openssl gem, the require wouldn't work. Not sure whether either of these are still relevant today.\n\nAccording to the [release notes for JRuby 1.7.13](http://www.jruby.org/2014/06/24/jruby-1-7-13.html):\n\n> jruby-openssl 0.9.5 bundled\n\nwhich means the above `rescue` block is not needed anymore.\n\nAll the Ruby versions supported by the current version of Rails provide those OpenSSL libraries, so Travis CI should also be happy by removing the `rescue` blocks.\n\n---\n\nJust to confirm, with JRuby:\n\n    $ ruby --version #=> jruby 1.7.16.1 (1.9.3p392) 2014-10-28 4e93f31 on Java HotSpot(TM) 64-Bit Server VM 1.8.0_20-b26 +jit [darwin-x86_64]\n    $ irb\n    irb(main):001:0> require 'openssl' #=> true\n    irb(main):002:0> OpenSSL::Digest::SHA1 #=> OpenSSL::Digest::SHA1\n    irb(main):003:0> OpenSSL::PKCS5 # => OpenSSL::PKCS5\n\nAnd with Ruby 2.1:\n\n    $ ruby --version #=> ruby 2.1.2p95 (2014-05-08 revision 45877) [x86_64-darwin13.0]\n    $ irb\n    irb(main):001:0> require 'openssl' #=> true\n    irb(main):002:0> OpenSSL::Digest::SHA1 #=> OpenSSL::Digest::SHA1\n    irb(main):003:0> OpenSSL::PKCS5 #=> OpenSSL::PKCS5","claudiob",true],["bc7623a500c93421152cbf3a45157392a6204c43","63b51a7b3ff1fafca81cda6f7ce2446b69bc82b3@gmail.com","Merge pull request #17901 from isaacseymour/fix-find-each-docs\n\nCorrect docs for ActiveRecord batching methods [ci skip]","Yves Senn",true]],"size":317,"ref":"refs/heads/master","head":"d402b15d39e7b0a746eac18118cddfa751e9f4c9"}