GitHub PullRequestReviewCommentEvent at 2014-11-21 11:48:57
Repository: fiware-puppetwrapper
Actor: flopezag
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/telefonicaid/fiware-puppetwrapper/pulls/comments/20710665","id":20710665,"diff_hunk":"@@ -144,6 +144,8 @@ public Node action(Action action, String group, String nodeName, String softName\n      * (java.lang.String)\n      */\n     public void deleteNode(String nodeName) throws IOException {\n+        catalogManager.getNode(nodeName);","path":"src/main/java/com/telefonica/euro_iaas/sdc/puppetwrapper/services/impl/ActionsServiceImpl.java","position":4,"original_position":4,"commit_id":"cc94e9975627b4392c3191831a4ed3dbd33b9257","original_commit_id":"cc94e9975627b4392c3191831a4ed3dbd33b9257","user":{"login":"flopezag","id":1379796,"avatar_url":"https://avatars.githubusercontent.com/u/1379796?v=3","gravatar_id":"","url":"https://api.github.com/users/flopezag","html_url":"https://github.com/flopezag","followers_url":"https://api.github.com/users/flopezag/followers","following_url":"https://api.github.com/users/flopezag/following{/other_user}","gists_url":"https://api.github.com/users/flopezag/gists{/gist_id}","starred_url":"https://api.github.com/users/flopezag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flopezag/subscriptions","organizations_url":"https://api.github.com/users/flopezag/orgs","repos_url":"https://api.github.com/users/flopezag/repos","events_url":"https://api.github.com/users/flopezag/events{/privacy}","received_events_url":"https://api.github.com/users/flopezag/received_events","type":"User","site_admin":false},"body":"I mean, you are getting a node but you do not recover in a variable the information of the method. You only try to see if you can recover the information of the method.\r\n\r\nThen, I suggest to put a comment in order to explain it and why do you not need a assign to a variable this operation.","created_at":"2014-11-21T11:48:57Z","updated_at":"2014-11-21T11:48:57Z","html_url":"https://github.com/telefonicaid/fiware-puppetwrapper/pull/22#discussion_r20710665","pull_request_url":"https://api.github.com/repos/telefonicaid/fiware-puppetwrapper/pulls/22","_links":{"self":{"href":"https://api.github.com/repos/telefonicaid/fiware-puppetwrapper/pulls/comments/20710665"},"html":{"href":"https://github.com/telefonicaid/fiware-puppetwrapper/pull/22#discussion_r20710665"},"pull_request":{"href":"https://api.github.com/repos/telefonicaid/fiware-puppetwrapper/pulls/22"}}},"pull_request":{"url":"https://api.github.com/repos/telefonicaid/fiware-puppetwrapper/pulls/22","id":24681360,"html_url":"https://github.com/telefonicaid/fiware-puppetwrapper/pull/22","diff_url":"https://github.com/telefonicaid/fiware-puppetwrapper/pull/22.diff","patch_url":"https://github.com/telefonicaid/fiware-puppetwrapper/pull/22.patch","issue_url":"https://api.github.com/repos/telefonicaid/fiware-puppetwrapper/issues/22","number":22,"state":"open","locked":false,"title":"fix bug loading node before deleting","user":{"login":"alberts-tid","id":7240467,"avatar_url":"https://avatars.githubusercontent.com/u/7240467?v=3","gravatar_id":"","url":"https://api.github.com/users/alberts-tid","html_url":"https://github.com/alberts-tid","followers_url":"https://api.github.com/users/alberts-tid/followers","following_url":"https://api.github.com/users/alberts-tid/following{/other_user}","gists_url":"https://api.github.com/users/alberts-tid/gists{/gist_id}","starred_url":"https://api.github.com/users/alberts-tid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alberts-tid/subscriptions","organizations_url":"https://api.github.com/users/alberts-tid/orgs","repos_url":"https://api.github.com/users/alberts-tid/repos","events_url":"https://api.github.com/users/alberts-tid/events{/privacy}","received_events_url":"https://api.github.com/users/alberts-tid/received_events","type":"User","site_admin":false},"body":"#### Reviewers\r\n@jframos @flopezag  \r\n\r\n#### Description\r\nFIX bug\r\n\r\n#### Test\r\ntested locally ","created_at":"2014-11-19T11:20:41Z","updated_at":"2014-11-21T11:48:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8fb99a57fe321955907ba0a625f7b0bc41609361","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/telefonicaid/fiware-puppetwrapper/pulls/22/commits","review_comments_url":"https://api.github.com/repos/telefonicaid/fiware-puppetwrapper/pulls/22/comments","review_comment_url":"https://api.github.com/repos/telefonicaid/fiware-puppetwrapper/pulls/comments/{number}","comments_url":"https://api.github.com/repos/telefonicaid/fiware-puppetwrapper/issues/22/comments","statuses_url":"https://api.github.com/repos/telefonicaid/fiware-puppetwrapper/statuses/cc94e9975627b4392c3191831a4ed3dbd33b9257","head":{"label":"alberts-tid:bug/CLAUDIA-4240","ref":"bug/CLAUDIA-4240","sha":"cc94e9975627b4392c3191831a4ed3dbd33b9257","user":{"login":"alberts-tid","id":7240467,"avatar_url":"https://avatars.githubusercontent.com/u/7240467?v=3","gravatar_id":"","url":"https://api.github.com/users/alberts-tid","html_url":"https://github.com/alberts-tid","followers_url":"https://api.github.com/users/alberts-tid/followers","following_url":"https://api.github.com/users/alberts-tid/following{/other_user}","gists_url":"https://api.github.com/users/alberts-tid/gists{/gist_id}","starred_url":"https://api.github.com/users/alberts-tid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alberts-tid/subscriptions","organizations_url":"https://api.github.com/users/alberts-tid/orgs","repos_url":"https://api.github.com/users/alberts-tid/repos","events_url":"https://api.github.com/users/alberts-tid/events{/privacy}","received_events_url":"https://api.github.com/users/alberts-tid/received_events","type":"User","site_admin":false},"repo":{"id":21032104,"name":"fiware-puppetwrapper","full_name":"alberts-tid/fiware-puppetwrapper","owner":{"login":"alberts-tid","id":7240467,"avatar_url":"https://avatars.githubusercontent.com/u/7240467?v=3","gravatar_id":"","url":"https://api.github.com/users/alberts-tid","html_url":"https://github.com/alberts-tid","followers_url":"https://api.github.com/users/alberts-tid/followers","following_url":"https://api.github.com/users/alberts-tid/following{/other_user}","gists_url":"https://api.github.com/users/alberts-tid/gists{/gist_id}","starred_url":"https://api.github.com/users/alberts-tid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alberts-tid/subscriptions","organizations_url":"https://api.github.com/users/alberts-tid/orgs","repos_url":"https://api.github.com/users/alberts-tid/repos","events_url":"https://api.github.com/users/alberts-tid/events{/privacy}","received_events_url":"https://api.github.com/users/alberts-tid/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alberts-tid/fiware-puppetwrapper","description":"SDC wrapper in order to deploy artifacts following puppet manifests","fork":true,"url":"https://api.github.com/repos/alberts-tid/fiware-puppetwrapper","forks_url":"https://api.github.com/repos/alberts-tid/fiware-puppetwrapper/forks","keys_url":"https://api.github.com/repos/alberts-tid/fiware-puppetwrapper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alberts-tid/fiware-puppetwrapper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alberts-tid/fiware-puppetwrapper/teams","hooks_url":"https://api.github.com/repos/alberts-tid/fiware-puppetwrapper/hooks","issue_events_url":"https://api.github.com/repos/alberts-tid/fiware-puppetwrapper/issues/events{/number}","events_url":"https://api.github.com/repos/alberts-tid/fiware-puppetwrapper/events","assignees_url":"https://api.github.com/repos/alberts-tid/fiware-puppetwrapper/assignees{/user}","branches_url":"https://api.github.com/repos/alberts-tid/fiware-puppetwrapper/branches{/branch}","tags_url":"https://api.github.com/repos/alberts-tid/fiware-puppetwrapper/tags","blobs_url":"https://api.github.com/repos/alberts-tid/fiware-puppetwrapper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alberts-tid/fiware-puppetwrapper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alberts-tid/fiware-puppetwrapper/git/refs{/sha}","trees_url":"https://api.github.com/repos/alberts-tid/fiware-puppetwrapper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alberts-tid/fiware-puppetwrapper/statuses/{sha}","languages_url":"https://api.github.com/repos/alberts-tid/fiware-puppetwrapper/languages","stargazers_url":"https://api.github.com/repos/alberts-tid/fiware-puppetwrapper/stargazers","contributors_url":"https://api.github.com/repos/alberts-tid/fiware-puppetwrapper/contributors","subscribers_url":"https://api.github.com/repos/alberts-tid/fiware-puppetwrapper/subscribers","subscription_url":"https://api.github.com/repos/alberts-tid/fiware-puppetwrapper/subscription","commits_url":"https://api.github.com/repos/alberts-tid/fiware-puppetwrapper/commits{/sha}","git_commits_url":"https://api.github.com/repos/alberts-tid/fiware-puppetwrapper/git/commits{/sha}","comments_url":"https://api.github.com/repos/alberts-tid/fiware-puppetwrapper/comments{/number}","issue_comment_url":"https://api.github.com/repos/alberts-tid/fiware-puppetwrapper/issues/comments/{number}","contents_url":"https://api.github.com/repos/alberts-tid/fiware-puppetwrapper/contents/{+path}","compare_url":"https://api.github.com/repos/alberts-tid/fiware-puppetwrapper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alberts-tid/fiware-puppetwrapper/merges","archive_url":"https://api.github.com/repos/alberts-tid/fiware-puppetwrapper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alberts-tid/fiware-puppetwrapper/downloads","issues_url":"https://api.github.com/repos/alberts-tid/fiware-puppetwrapper/issues{/number}","pulls_url":"https://api.github.com/repos/alberts-tid/fiware-puppetwrapper/pulls{/number}","milestones_url":"https://api.github.com/repos/alberts-tid/fiware-puppetwrapper/milestones{/number}","notifications_url":"https://api.github.com/repos/alberts-tid/fiware-puppetwrapper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alberts-tid/fiware-puppetwrapper/labels{/name}","releases_url":"https://api.github.com/repos/alberts-tid/fiware-puppetwrapper/releases{/id}","created_at":"2014-06-20T09:13:06Z","updated_at":"2014-07-01T11:29:46Z","pushed_at":"2014-11-21T08:34:48Z","git_url":"git://github.com/alberts-tid/fiware-puppetwrapper.git","ssh_url":"git@github.com:alberts-tid/fiware-puppetwrapper.git","clone_url":"https://github.com/alberts-tid/fiware-puppetwrapper.git","svn_url":"https://github.com/alberts-tid/fiware-puppetwrapper","homepage":"","size":8220,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"telefonicaid:develop","ref":"develop","sha":"19798feff699b66322c370c075eeee7ca476eae3","user":{"login":"telefonicaid","id":968363,"avatar_url":"https://avatars.githubusercontent.com/u/968363?v=3","gravatar_id":"","url":"https://api.github.com/users/telefonicaid","html_url":"https://github.com/telefonicaid","followers_url":"https://api.github.com/users/telefonicaid/followers","following_url":"https://api.github.com/users/telefonicaid/following{/other_user}","gists_url":"https://api.github.com/users/telefonicaid/gists{/gist_id}","starred_url":"https://api.github.com/users/telefonicaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telefonicaid/subscriptions","organizations_url":"https://api.github.com/users/telefonicaid/orgs","repos_url":"https://api.github.com/users/telefonicaid/repos","events_url":"https://api.github.com/users/telefonicaid/events{/privacy}","received_events_url":"https://api.github.com/users/telefonicaid/received_events","type":"Organization","site_admin":false},"repo":{"id":20883577,"name":"fiware-puppetwrapper","full_name":"telefonicaid/fiware-puppetwrapper","owner":{"login":"telefonicaid","id":968363,"avatar_url":"https://avatars.githubusercontent.com/u/968363?v=3","gravatar_id":"","url":"https://api.github.com/users/telefonicaid","html_url":"https://github.com/telefonicaid","followers_url":"https://api.github.com/users/telefonicaid/followers","following_url":"https://api.github.com/users/telefonicaid/following{/other_user}","gists_url":"https://api.github.com/users/telefonicaid/gists{/gist_id}","starred_url":"https://api.github.com/users/telefonicaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telefonicaid/subscriptions","organizations_url":"https://api.github.com/users/telefonicaid/orgs","repos_url":"https://api.github.com/users/telefonicaid/repos","events_url":"https://api.github.com/users/telefonicaid/events{/privacy}","received_events_url":"https://api.github.com/users/telefonicaid/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/telefonicaid/fiware-puppetwrapper","description":"SDC wrapper in order to deploy artifacts following puppet manifests","fork":false,"url":"https://api.github.com/repos/telefonicaid/fiware-puppetwrapper","forks_url":"https://api.github.com/repos/telefonicaid/fiware-puppetwrapper/forks","keys_url":"https://api.github.com/repos/telefonicaid/fiware-puppetwrapper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/telefonicaid/fiware-puppetwrapper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/telefonicaid/fiware-puppetwrapper/teams","hooks_url":"https://api.github.com/repos/telefonicaid/fiware-puppetwrapper/hooks","issue_events_url":"https://api.github.com/repos/telefonicaid/fiware-puppetwrapper/issues/events{/number}","events_url":"https://api.github.com/repos/telefonicaid/fiware-puppetwrapper/events","assignees_url":"https://api.github.com/repos/telefonicaid/fiware-puppetwrapper/assignees{/user}","branches_url":"https://api.github.com/repos/telefonicaid/fiware-puppetwrapper/branches{/branch}","tags_url":"https://api.github.com/repos/telefonicaid/fiware-puppetwrapper/tags","blobs_url":"https://api.github.com/repos/telefonicaid/fiware-puppetwrapper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/telefonicaid/fiware-puppetwrapper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/telefonicaid/fiware-puppetwrapper/git/refs{/sha}","trees_url":"https://api.github.com/repos/telefonicaid/fiware-puppetwrapper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/telefonicaid/fiware-puppetwrapper/statuses/{sha}","languages_url":"https://api.github.com/repos/telefonicaid/fiware-puppetwrapper/languages","stargazers_url":"https://api.github.com/repos/telefonicaid/fiware-puppetwrapper/stargazers","contributors_url":"https://api.github.com/repos/telefonicaid/fiware-puppetwrapper/contributors","subscribers_url":"https://api.github.com/repos/telefonicaid/fiware-puppetwrapper/subscribers","subscription_url":"https://api.github.com/repos/telefonicaid/fiware-puppetwrapper/subscription","commits_url":"https://api.github.com/repos/telefonicaid/fiware-puppetwrapper/commits{/sha}","git_commits_url":"https://api.github.com/repos/telefonicaid/fiware-puppetwrapper/git/commits{/sha}","comments_url":"https://api.github.com/repos/telefonicaid/fiware-puppetwrapper/comments{/number}","issue_comment_url":"https://api.github.com/repos/telefonicaid/fiware-puppetwrapper/issues/comments/{number}","contents_url":"https://api.github.com/repos/telefonicaid/fiware-puppetwrapper/contents/{+path}","compare_url":"https://api.github.com/repos/telefonicaid/fiware-puppetwrapper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/telefonicaid/fiware-puppetwrapper/merges","archive_url":"https://api.github.com/repos/telefonicaid/fiware-puppetwrapper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/telefonicaid/fiware-puppetwrapper/downloads","issues_url":"https://api.github.com/repos/telefonicaid/fiware-puppetwrapper/issues{/number}","pulls_url":"https://api.github.com/repos/telefonicaid/fiware-puppetwrapper/pulls{/number}","milestones_url":"https://api.github.com/repos/telefonicaid/fiware-puppetwrapper/milestones{/number}","notifications_url":"https://api.github.com/repos/telefonicaid/fiware-puppetwrapper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/telefonicaid/fiware-puppetwrapper/labels{/name}","releases_url":"https://api.github.com/repos/telefonicaid/fiware-puppetwrapper/releases{/id}","created_at":"2014-06-16T12:14:27Z","updated_at":"2014-10-01T09:23:38Z","pushed_at":"2014-10-30T17:28:06Z","git_url":"git://github.com/telefonicaid/fiware-puppetwrapper.git","ssh_url":"git@github.com:telefonicaid/fiware-puppetwrapper.git","clone_url":"https://github.com/telefonicaid/fiware-puppetwrapper.git","svn_url":"https://github.com/telefonicaid/fiware-puppetwrapper","homepage":"","size":8347,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/telefonicaid/fiware-puppetwrapper/pulls/22"},"html":{"href":"https://github.com/telefonicaid/fiware-puppetwrapper/pull/22"},"issue":{"href":"https://api.github.com/repos/telefonicaid/fiware-puppetwrapper/issues/22"},"comments":{"href":"https://api.github.com/repos/telefonicaid/fiware-puppetwrapper/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/telefonicaid/fiware-puppetwrapper/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/telefonicaid/fiware-puppetwrapper/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/telefonicaid/fiware-puppetwrapper/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/telefonicaid/fiware-puppetwrapper/statuses/cc94e9975627b4392c3191831a4ed3dbd33b9257"}}}}