GitHub PullRequestReviewCommentEvent at 2014-11-13 09:11:38
Repository: monolog
Actor: xabbuh
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Seldaek/monolog/pulls/comments/20279116","id":20279116,"diff_hunk":"@@ -39,6 +41,10 @@ public function __construct($apiKey, $message, $level = Logger::ERROR, $bubble =\n         if (!$message instanceof \\Swift_Message) {\n             throw new \\InvalidArgumentException('You must provide either a Swift_Message instance or a callable returning it');\n         }\n+        if($responseHandler != null && !is_callable($responseHandler)){","path":"src/Monolog/Handler/MandrillHandler.php","position":22,"original_position":22,"commit_id":"a092cb70486ae3e7b4d0ebea8a3c88ed03a794c0","original_commit_id":"a092cb70486ae3e7b4d0ebea8a3c88ed03a794c0","user":{"login":"xabbuh","id":1957048,"avatar_url":"https://avatars.githubusercontent.com/u/1957048?v=3","gravatar_id":"","url":"https://api.github.com/users/xabbuh","html_url":"https://github.com/xabbuh","followers_url":"https://api.github.com/users/xabbuh/followers","following_url":"https://api.github.com/users/xabbuh/following{/other_user}","gists_url":"https://api.github.com/users/xabbuh/gists{/gist_id}","starred_url":"https://api.github.com/users/xabbuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xabbuh/subscriptions","organizations_url":"https://api.github.com/users/xabbuh/orgs","repos_url":"https://api.github.com/users/xabbuh/repos","events_url":"https://api.github.com/users/xabbuh/events{/privacy}","received_events_url":"https://api.github.com/users/xabbuh/received_events","type":"User","site_admin":false},"body":"By the way, Symfony uses spaces and Yoda expressions like this:\r\n\r\n```php\r\nif (null !== $responseHandler && !is_callable($responseHandler)) {\r\n    // ...\r\n}\r\n```\r\n\r\nMaybe you would like to apply this CS here too. I don't know if @Seldaek does care about it.","created_at":"2014-11-13T09:11:38Z","updated_at":"2014-11-13T09:11:38Z","html_url":"https://github.com/Seldaek/monolog/pull/454#discussion_r20279116","pull_request_url":"https://api.github.com/repos/Seldaek/monolog/pulls/454","_links":{"self":{"href":"https://api.github.com/repos/Seldaek/monolog/pulls/comments/20279116"},"html":{"href":"https://github.com/Seldaek/monolog/pull/454#discussion_r20279116"},"pull_request":{"href":"https://api.github.com/repos/Seldaek/monolog/pulls/454"}}},"pull_request":{"url":"https://api.github.com/repos/Seldaek/monolog/pulls/454","id":24282667,"html_url":"https://github.com/Seldaek/monolog/pull/454","diff_url":"https://github.com/Seldaek/monolog/pull/454.diff","patch_url":"https://github.com/Seldaek/monolog/pull/454.patch","issue_url":"https://api.github.com/repos/Seldaek/monolog/issues/454","number":454,"state":"open","locked":false,"title":"Callback for Mandril Handler","user":{"login":"kevinrademan","id":6704740,"avatar_url":"https://avatars.githubusercontent.com/u/6704740?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinrademan","html_url":"https://github.com/kevinrademan","followers_url":"https://api.github.com/users/kevinrademan/followers","following_url":"https://api.github.com/users/kevinrademan/following{/other_user}","gists_url":"https://api.github.com/users/kevinrademan/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinrademan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinrademan/subscriptions","organizations_url":"https://api.github.com/users/kevinrademan/orgs","repos_url":"https://api.github.com/users/kevinrademan/repos","events_url":"https://api.github.com/users/kevinrademan/events{/privacy}","received_events_url":"https://api.github.com/users/kevinrademan/received_events","type":"User","site_admin":false},"body":"The following code can be used to silence the curl response. It also allows you to pass in a call back function which can then be used to process the response from mandrill. \r\nWe were using this project in a website and upon sending an email to mandrill, the response was being echoed out on our site. ","created_at":"2014-11-12T10:26:39Z","updated_at":"2014-11-13T09:11:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9666a4f44c6d20591077c0bc487a33171d472f47","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Seldaek/monolog/pulls/454/commits","review_comments_url":"https://api.github.com/repos/Seldaek/monolog/pulls/454/comments","review_comment_url":"https://api.github.com/repos/Seldaek/monolog/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Seldaek/monolog/issues/454/comments","statuses_url":"https://api.github.com/repos/Seldaek/monolog/statuses/a092cb70486ae3e7b4d0ebea8a3c88ed03a794c0","head":{"label":"hellofresh:master","ref":"master","sha":"a092cb70486ae3e7b4d0ebea8a3c88ed03a794c0","user":{"login":"hellofresh","id":4430027,"avatar_url":"https://avatars.githubusercontent.com/u/4430027?v=3","gravatar_id":"","url":"https://api.github.com/users/hellofresh","html_url":"https://github.com/hellofresh","followers_url":"https://api.github.com/users/hellofresh/followers","following_url":"https://api.github.com/users/hellofresh/following{/other_user}","gists_url":"https://api.github.com/users/hellofresh/gists{/gist_id}","starred_url":"https://api.github.com/users/hellofresh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hellofresh/subscriptions","organizations_url":"https://api.github.com/users/hellofresh/orgs","repos_url":"https://api.github.com/users/hellofresh/repos","events_url":"https://api.github.com/users/hellofresh/events{/privacy}","received_events_url":"https://api.github.com/users/hellofresh/received_events","type":"Organization","site_admin":false},"repo":{"id":24725573,"name":"monolog","full_name":"hellofresh/monolog","owner":{"login":"hellofresh","id":4430027,"avatar_url":"https://avatars.githubusercontent.com/u/4430027?v=3","gravatar_id":"","url":"https://api.github.com/users/hellofresh","html_url":"https://github.com/hellofresh","followers_url":"https://api.github.com/users/hellofresh/followers","following_url":"https://api.github.com/users/hellofresh/following{/other_user}","gists_url":"https://api.github.com/users/hellofresh/gists{/gist_id}","starred_url":"https://api.github.com/users/hellofresh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hellofresh/subscriptions","organizations_url":"https://api.github.com/users/hellofresh/orgs","repos_url":"https://api.github.com/users/hellofresh/repos","events_url":"https://api.github.com/users/hellofresh/events{/privacy}","received_events_url":"https://api.github.com/users/hellofresh/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hellofresh/monolog","description":"Sends your logs to files, sockets, inboxes, databases and various web services","fork":true,"url":"https://api.github.com/repos/hellofresh/monolog","forks_url":"https://api.github.com/repos/hellofresh/monolog/forks","keys_url":"https://api.github.com/repos/hellofresh/monolog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hellofresh/monolog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hellofresh/monolog/teams","hooks_url":"https://api.github.com/repos/hellofresh/monolog/hooks","issue_events_url":"https://api.github.com/repos/hellofresh/monolog/issues/events{/number}","events_url":"https://api.github.com/repos/hellofresh/monolog/events","assignees_url":"https://api.github.com/repos/hellofresh/monolog/assignees{/user}","branches_url":"https://api.github.com/repos/hellofresh/monolog/branches{/branch}","tags_url":"https://api.github.com/repos/hellofresh/monolog/tags","blobs_url":"https://api.github.com/repos/hellofresh/monolog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hellofresh/monolog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hellofresh/monolog/git/refs{/sha}","trees_url":"https://api.github.com/repos/hellofresh/monolog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hellofresh/monolog/statuses/{sha}","languages_url":"https://api.github.com/repos/hellofresh/monolog/languages","stargazers_url":"https://api.github.com/repos/hellofresh/monolog/stargazers","contributors_url":"https://api.github.com/repos/hellofresh/monolog/contributors","subscribers_url":"https://api.github.com/repos/hellofresh/monolog/subscribers","subscription_url":"https://api.github.com/repos/hellofresh/monolog/subscription","commits_url":"https://api.github.com/repos/hellofresh/monolog/commits{/sha}","git_commits_url":"https://api.github.com/repos/hellofresh/monolog/git/commits{/sha}","comments_url":"https://api.github.com/repos/hellofresh/monolog/comments{/number}","issue_comment_url":"https://api.github.com/repos/hellofresh/monolog/issues/comments/{number}","contents_url":"https://api.github.com/repos/hellofresh/monolog/contents/{+path}","compare_url":"https://api.github.com/repos/hellofresh/monolog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hellofresh/monolog/merges","archive_url":"https://api.github.com/repos/hellofresh/monolog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hellofresh/monolog/downloads","issues_url":"https://api.github.com/repos/hellofresh/monolog/issues{/number}","pulls_url":"https://api.github.com/repos/hellofresh/monolog/pulls{/number}","milestones_url":"https://api.github.com/repos/hellofresh/monolog/milestones{/number}","notifications_url":"https://api.github.com/repos/hellofresh/monolog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hellofresh/monolog/labels{/name}","releases_url":"https://api.github.com/repos/hellofresh/monolog/releases{/id}","created_at":"2014-10-02T15:52:51Z","updated_at":"2014-10-02T16:03:53Z","pushed_at":"2014-11-13T09:03:48Z","git_url":"git://github.com/hellofresh/monolog.git","ssh_url":"git@github.com:hellofresh/monolog.git","clone_url":"https://github.com/hellofresh/monolog.git","svn_url":"https://github.com/hellofresh/monolog","homepage":"","size":1331,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Seldaek:master","ref":"master","sha":"ab41ed9a94196ce2793f400b88313918b4fc64dc","user":{"login":"Seldaek","id":183678,"avatar_url":"https://avatars.githubusercontent.com/u/183678?v=3","gravatar_id":"","url":"https://api.github.com/users/Seldaek","html_url":"https://github.com/Seldaek","followers_url":"https://api.github.com/users/Seldaek/followers","following_url":"https://api.github.com/users/Seldaek/following{/other_user}","gists_url":"https://api.github.com/users/Seldaek/gists{/gist_id}","starred_url":"https://api.github.com/users/Seldaek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Seldaek/subscriptions","organizations_url":"https://api.github.com/users/Seldaek/orgs","repos_url":"https://api.github.com/users/Seldaek/repos","events_url":"https://api.github.com/users/Seldaek/events{/privacy}","received_events_url":"https://api.github.com/users/Seldaek/received_events","type":"User","site_admin":false},"repo":{"id":1376664,"name":"monolog","full_name":"Seldaek/monolog","owner":{"login":"Seldaek","id":183678,"avatar_url":"https://avatars.githubusercontent.com/u/183678?v=3","gravatar_id":"","url":"https://api.github.com/users/Seldaek","html_url":"https://github.com/Seldaek","followers_url":"https://api.github.com/users/Seldaek/followers","following_url":"https://api.github.com/users/Seldaek/following{/other_user}","gists_url":"https://api.github.com/users/Seldaek/gists{/gist_id}","starred_url":"https://api.github.com/users/Seldaek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Seldaek/subscriptions","organizations_url":"https://api.github.com/users/Seldaek/orgs","repos_url":"https://api.github.com/users/Seldaek/repos","events_url":"https://api.github.com/users/Seldaek/events{/privacy}","received_events_url":"https://api.github.com/users/Seldaek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Seldaek/monolog","description":"Sends your logs to files, sockets, inboxes, databases and various web services","fork":false,"url":"https://api.github.com/repos/Seldaek/monolog","forks_url":"https://api.github.com/repos/Seldaek/monolog/forks","keys_url":"https://api.github.com/repos/Seldaek/monolog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Seldaek/monolog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Seldaek/monolog/teams","hooks_url":"https://api.github.com/repos/Seldaek/monolog/hooks","issue_events_url":"https://api.github.com/repos/Seldaek/monolog/issues/events{/number}","events_url":"https://api.github.com/repos/Seldaek/monolog/events","assignees_url":"https://api.github.com/repos/Seldaek/monolog/assignees{/user}","branches_url":"https://api.github.com/repos/Seldaek/monolog/branches{/branch}","tags_url":"https://api.github.com/repos/Seldaek/monolog/tags","blobs_url":"https://api.github.com/repos/Seldaek/monolog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Seldaek/monolog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Seldaek/monolog/git/refs{/sha}","trees_url":"https://api.github.com/repos/Seldaek/monolog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Seldaek/monolog/statuses/{sha}","languages_url":"https://api.github.com/repos/Seldaek/monolog/languages","stargazers_url":"https://api.github.com/repos/Seldaek/monolog/stargazers","contributors_url":"https://api.github.com/repos/Seldaek/monolog/contributors","subscribers_url":"https://api.github.com/repos/Seldaek/monolog/subscribers","subscription_url":"https://api.github.com/repos/Seldaek/monolog/subscription","commits_url":"https://api.github.com/repos/Seldaek/monolog/commits{/sha}","git_commits_url":"https://api.github.com/repos/Seldaek/monolog/git/commits{/sha}","comments_url":"https://api.github.com/repos/Seldaek/monolog/comments{/number}","issue_comment_url":"https://api.github.com/repos/Seldaek/monolog/issues/comments/{number}","contents_url":"https://api.github.com/repos/Seldaek/monolog/contents/{+path}","compare_url":"https://api.github.com/repos/Seldaek/monolog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Seldaek/monolog/merges","archive_url":"https://api.github.com/repos/Seldaek/monolog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Seldaek/monolog/downloads","issues_url":"https://api.github.com/repos/Seldaek/monolog/issues{/number}","pulls_url":"https://api.github.com/repos/Seldaek/monolog/pulls{/number}","milestones_url":"https://api.github.com/repos/Seldaek/monolog/milestones{/number}","notifications_url":"https://api.github.com/repos/Seldaek/monolog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Seldaek/monolog/labels{/name}","releases_url":"https://api.github.com/repos/Seldaek/monolog/releases{/id}","created_at":"2011-02-17T02:07:15Z","updated_at":"2014-11-13T02:16:10Z","pushed_at":"2014-11-11T12:05:51Z","git_url":"git://github.com/Seldaek/monolog.git","ssh_url":"git@github.com:Seldaek/monolog.git","clone_url":"https://github.com/Seldaek/monolog.git","svn_url":"https://github.com/Seldaek/monolog","homepage":"","size":4868,"stargazers_count":2726,"watchers_count":2726,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":479,"mirror_url":null,"open_issues_count":37,"forks":479,"open_issues":37,"watchers":2726,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Seldaek/monolog/pulls/454"},"html":{"href":"https://github.com/Seldaek/monolog/pull/454"},"issue":{"href":"https://api.github.com/repos/Seldaek/monolog/issues/454"},"comments":{"href":"https://api.github.com/repos/Seldaek/monolog/issues/454/comments"},"review_comments":{"href":"https://api.github.com/repos/Seldaek/monolog/pulls/454/comments"},"review_comment":{"href":"https://api.github.com/repos/Seldaek/monolog/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Seldaek/monolog/pulls/454/commits"},"statuses":{"href":"https://api.github.com/repos/Seldaek/monolog/statuses/a092cb70486ae3e7b4d0ebea8a3c88ed03a794c0"}}}}