GitHub PullRequestEvent at 2014-12-07 11:48:16
Repository: airplane-mode
Actor: johnbillion
Payload: {"action":"closed","number":17,"pull_request":{"url":"https://api.github.com/repos/norcross/airplane-mode/pulls/17","id":19501991,"html_url":"https://github.com/norcross/airplane-mode/pull/17","diff_url":"https://github.com/norcross/airplane-mode/pull/17.diff","patch_url":"https://github.com/norcross/airplane-mode/pull/17.patch","issue_url":"https://api.github.com/repos/norcross/airplane-mode/issues/17","number":17,"state":"closed","locked":false,"title":"Blocking AJAX requests when Airplane Mode is enabled","user":{"login":"johnbillion","id":208434,"avatar_url":"https://avatars.githubusercontent.com/u/208434?v=3","gravatar_id":"","url":"https://api.github.com/users/johnbillion","html_url":"https://github.com/johnbillion","followers_url":"https://api.github.com/users/johnbillion/followers","following_url":"https://api.github.com/users/johnbillion/following{/other_user}","gists_url":"https://api.github.com/users/johnbillion/gists{/gist_id}","starred_url":"https://api.github.com/users/johnbillion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnbillion/subscriptions","organizations_url":"https://api.github.com/users/johnbillion/orgs","repos_url":"https://api.github.com/users/johnbillion/repos","events_url":"https://api.github.com/users/johnbillion/events{/privacy}","received_events_url":"https://api.github.com/users/johnbillion/received_events","type":"User","site_admin":false},"body":"I thought you might like to know that I've been working on blocking AJAX requests when Airplane Mode is enabled.\r\n\r\nThis branch introduces some JavaScript which uses jQuery's `ajaxPrefilter` method to abort any jQuery AJAX request on the page. Currently it unconditionally aborts all AJAX requests which isn't very useful in the admin area; I'm finishing up a method for whitelisting domains complete with a filter.\r\n\r\nOne point of interest is that when calling the `abort()` method on the XHR before the request has begun means we have to manually call the `fail()` or `error()` callbacks because they don't get triggered. In case anyone wonders why we're manually calling those methods.\r\n\r\nI'll update this PR as I work on this.","created_at":"2014-08-07T23:43:51Z","updated_at":"2014-12-07T11:48:15Z","closed_at":"2014-12-07T11:48:15Z","merged_at":null,"merge_commit_sha":"d65d86f9fc5deab459ad46999cd9154d7f5754e2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/norcross/airplane-mode/pulls/17/commits","review_comments_url":"https://api.github.com/repos/norcross/airplane-mode/pulls/17/comments","review_comment_url":"https://api.github.com/repos/norcross/airplane-mode/pulls/comments/{number}","comments_url":"https://api.github.com/repos/norcross/airplane-mode/issues/17/comments","statuses_url":"https://api.github.com/repos/norcross/airplane-mode/statuses/600638d91878dd843a3b942c1ab8950769817b15","head":{"label":"johnbillion:feature/abort_ajax","ref":"feature/abort_ajax","sha":"600638d91878dd843a3b942c1ab8950769817b15","user":{"login":"johnbillion","id":208434,"avatar_url":"https://avatars.githubusercontent.com/u/208434?v=3","gravatar_id":"","url":"https://api.github.com/users/johnbillion","html_url":"https://github.com/johnbillion","followers_url":"https://api.github.com/users/johnbillion/followers","following_url":"https://api.github.com/users/johnbillion/following{/other_user}","gists_url":"https://api.github.com/users/johnbillion/gists{/gist_id}","starred_url":"https://api.github.com/users/johnbillion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnbillion/subscriptions","organizations_url":"https://api.github.com/users/johnbillion/orgs","repos_url":"https://api.github.com/users/johnbillion/repos","events_url":"https://api.github.com/users/johnbillion/events{/privacy}","received_events_url":"https://api.github.com/users/johnbillion/received_events","type":"User","site_admin":false},"repo":{"id":22574173,"name":"airplane-mode","full_name":"johnbillion/airplane-mode","owner":{"login":"johnbillion","id":208434,"avatar_url":"https://avatars.githubusercontent.com/u/208434?v=3","gravatar_id":"","url":"https://api.github.com/users/johnbillion","html_url":"https://github.com/johnbillion","followers_url":"https://api.github.com/users/johnbillion/followers","following_url":"https://api.github.com/users/johnbillion/following{/other_user}","gists_url":"https://api.github.com/users/johnbillion/gists{/gist_id}","starred_url":"https://api.github.com/users/johnbillion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnbillion/subscriptions","organizations_url":"https://api.github.com/users/johnbillion/orgs","repos_url":"https://api.github.com/users/johnbillion/repos","events_url":"https://api.github.com/users/johnbillion/events{/privacy}","received_events_url":"https://api.github.com/users/johnbillion/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/johnbillion/airplane-mode","description":"Disables external data calls and loading for working on a purely local (i.e. no internet connection) WordPress site","fork":true,"url":"https://api.github.com/repos/johnbillion/airplane-mode","forks_url":"https://api.github.com/repos/johnbillion/airplane-mode/forks","keys_url":"https://api.github.com/repos/johnbillion/airplane-mode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johnbillion/airplane-mode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johnbillion/airplane-mode/teams","hooks_url":"https://api.github.com/repos/johnbillion/airplane-mode/hooks","issue_events_url":"https://api.github.com/repos/johnbillion/airplane-mode/issues/events{/number}","events_url":"https://api.github.com/repos/johnbillion/airplane-mode/events","assignees_url":"https://api.github.com/repos/johnbillion/airplane-mode/assignees{/user}","branches_url":"https://api.github.com/repos/johnbillion/airplane-mode/branches{/branch}","tags_url":"https://api.github.com/repos/johnbillion/airplane-mode/tags","blobs_url":"https://api.github.com/repos/johnbillion/airplane-mode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johnbillion/airplane-mode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johnbillion/airplane-mode/git/refs{/sha}","trees_url":"https://api.github.com/repos/johnbillion/airplane-mode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johnbillion/airplane-mode/statuses/{sha}","languages_url":"https://api.github.com/repos/johnbillion/airplane-mode/languages","stargazers_url":"https://api.github.com/repos/johnbillion/airplane-mode/stargazers","contributors_url":"https://api.github.com/repos/johnbillion/airplane-mode/contributors","subscribers_url":"https://api.github.com/repos/johnbillion/airplane-mode/subscribers","subscription_url":"https://api.github.com/repos/johnbillion/airplane-mode/subscription","commits_url":"https://api.github.com/repos/johnbillion/airplane-mode/commits{/sha}","git_commits_url":"https://api.github.com/repos/johnbillion/airplane-mode/git/commits{/sha}","comments_url":"https://api.github.com/repos/johnbillion/airplane-mode/comments{/number}","issue_comment_url":"https://api.github.com/repos/johnbillion/airplane-mode/issues/comments/{number}","contents_url":"https://api.github.com/repos/johnbillion/airplane-mode/contents/{+path}","compare_url":"https://api.github.com/repos/johnbillion/airplane-mode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johnbillion/airplane-mode/merges","archive_url":"https://api.github.com/repos/johnbillion/airplane-mode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johnbillion/airplane-mode/downloads","issues_url":"https://api.github.com/repos/johnbillion/airplane-mode/issues{/number}","pulls_url":"https://api.github.com/repos/johnbillion/airplane-mode/pulls{/number}","milestones_url":"https://api.github.com/repos/johnbillion/airplane-mode/milestones{/number}","notifications_url":"https://api.github.com/repos/johnbillion/airplane-mode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johnbillion/airplane-mode/labels{/name}","releases_url":"https://api.github.com/repos/johnbillion/airplane-mode/releases{/id}","created_at":"2014-08-03T12:11:09Z","updated_at":"2014-08-07T23:34:25Z","pushed_at":"2014-10-20T15:51:58Z","git_url":"git://github.com/johnbillion/airplane-mode.git","ssh_url":"git@github.com:johnbillion/airplane-mode.git","clone_url":"https://github.com/johnbillion/airplane-mode.git","svn_url":"https://github.com/johnbillion/airplane-mode","homepage":"","size":257,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"norcross:master","ref":"master","sha":"1c751546acb12635a79bec6c65bc9120237dd76e","user":{"login":"norcross","id":98561,"avatar_url":"https://avatars.githubusercontent.com/u/98561?v=3","gravatar_id":"","url":"https://api.github.com/users/norcross","html_url":"https://github.com/norcross","followers_url":"https://api.github.com/users/norcross/followers","following_url":"https://api.github.com/users/norcross/following{/other_user}","gists_url":"https://api.github.com/users/norcross/gists{/gist_id}","starred_url":"https://api.github.com/users/norcross/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/norcross/subscriptions","organizations_url":"https://api.github.com/users/norcross/orgs","repos_url":"https://api.github.com/users/norcross/repos","events_url":"https://api.github.com/users/norcross/events{/privacy}","received_events_url":"https://api.github.com/users/norcross/received_events","type":"User","site_admin":false},"repo":{"id":20652680,"name":"airplane-mode","full_name":"norcross/airplane-mode","owner":{"login":"norcross","id":98561,"avatar_url":"https://avatars.githubusercontent.com/u/98561?v=3","gravatar_id":"","url":"https://api.github.com/users/norcross","html_url":"https://github.com/norcross","followers_url":"https://api.github.com/users/norcross/followers","following_url":"https://api.github.com/users/norcross/following{/other_user}","gists_url":"https://api.github.com/users/norcross/gists{/gist_id}","starred_url":"https://api.github.com/users/norcross/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/norcross/subscriptions","organizations_url":"https://api.github.com/users/norcross/orgs","repos_url":"https://api.github.com/users/norcross/repos","events_url":"https://api.github.com/users/norcross/events{/privacy}","received_events_url":"https://api.github.com/users/norcross/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/norcross/airplane-mode","description":"Disables external data calls and loading for working on a purely local (i.e. no internet connection) WordPress site","fork":false,"url":"https://api.github.com/repos/norcross/airplane-mode","forks_url":"https://api.github.com/repos/norcross/airplane-mode/forks","keys_url":"https://api.github.com/repos/norcross/airplane-mode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/norcross/airplane-mode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/norcross/airplane-mode/teams","hooks_url":"https://api.github.com/repos/norcross/airplane-mode/hooks","issue_events_url":"https://api.github.com/repos/norcross/airplane-mode/issues/events{/number}","events_url":"https://api.github.com/repos/norcross/airplane-mode/events","assignees_url":"https://api.github.com/repos/norcross/airplane-mode/assignees{/user}","branches_url":"https://api.github.com/repos/norcross/airplane-mode/branches{/branch}","tags_url":"https://api.github.com/repos/norcross/airplane-mode/tags","blobs_url":"https://api.github.com/repos/norcross/airplane-mode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/norcross/airplane-mode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/norcross/airplane-mode/git/refs{/sha}","trees_url":"https://api.github.com/repos/norcross/airplane-mode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/norcross/airplane-mode/statuses/{sha}","languages_url":"https://api.github.com/repos/norcross/airplane-mode/languages","stargazers_url":"https://api.github.com/repos/norcross/airplane-mode/stargazers","contributors_url":"https://api.github.com/repos/norcross/airplane-mode/contributors","subscribers_url":"https://api.github.com/repos/norcross/airplane-mode/subscribers","subscription_url":"https://api.github.com/repos/norcross/airplane-mode/subscription","commits_url":"https://api.github.com/repos/norcross/airplane-mode/commits{/sha}","git_commits_url":"https://api.github.com/repos/norcross/airplane-mode/git/commits{/sha}","comments_url":"https://api.github.com/repos/norcross/airplane-mode/comments{/number}","issue_comment_url":"https://api.github.com/repos/norcross/airplane-mode/issues/comments/{number}","contents_url":"https://api.github.com/repos/norcross/airplane-mode/contents/{+path}","compare_url":"https://api.github.com/repos/norcross/airplane-mode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/norcross/airplane-mode/merges","archive_url":"https://api.github.com/repos/norcross/airplane-mode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/norcross/airplane-mode/downloads","issues_url":"https://api.github.com/repos/norcross/airplane-mode/issues{/number}","pulls_url":"https://api.github.com/repos/norcross/airplane-mode/pulls{/number}","milestones_url":"https://api.github.com/repos/norcross/airplane-mode/milestones{/number}","notifications_url":"https://api.github.com/repos/norcross/airplane-mode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/norcross/airplane-mode/labels{/name}","releases_url":"https://api.github.com/repos/norcross/airplane-mode/releases{/id}","created_at":"2014-06-09T16:02:20Z","updated_at":"2014-12-05T16:34:32Z","pushed_at":"2014-10-20T19:33:58Z","git_url":"git://github.com/norcross/airplane-mode.git","ssh_url":"git@github.com:norcross/airplane-mode.git","clone_url":"https://github.com/norcross/airplane-mode.git","svn_url":"https://github.com/norcross/airplane-mode","homepage":"","size":522,"stargazers_count":169,"watchers_count":169,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":2,"forks":18,"open_issues":2,"watchers":169,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/norcross/airplane-mode/pulls/17"},"html":{"href":"https://github.com/norcross/airplane-mode/pull/17"},"issue":{"href":"https://api.github.com/repos/norcross/airplane-mode/issues/17"},"comments":{"href":"https://api.github.com/repos/norcross/airplane-mode/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/norcross/airplane-mode/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/norcross/airplane-mode/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/norcross/airplane-mode/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/norcross/airplane-mode/statuses/600638d91878dd843a3b942c1ab8950769817b15"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":3,"review_comments":0,"commits":1,"additions":34,"deletions":6,"changed_files":2}}