GitHub PullRequestReviewCommentEvent at 2014-12-01 17:03:01
Repository: wymeditor
Actor: kylegibson
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/wymeditor/wymeditor/pulls/comments/21102082","id":21102082,"diff_hunk":"@@ -475,6 +478,36 @@ WYMeditor.editor.prototype._bindUIEvents = function () {\n             wym.update();\n         }\n     );\n+\n+    // This may recover an unexpected shut down of `designMode`.\n+    wym.$body().bind(\"focus\", function () {","path":"src/wymeditor/editor/base.js","position":27,"original_position":27,"commit_id":"2fecdc92a0277627427c7f3a0cdb61927a7d2cff","original_commit_id":"2fecdc92a0277627427c7f3a0cdb61927a7d2cff","user":{"login":"kylegibson","id":243791,"avatar_url":"https://avatars.githubusercontent.com/u/243791?v=3","gravatar_id":"","url":"https://api.github.com/users/kylegibson","html_url":"https://github.com/kylegibson","followers_url":"https://api.github.com/users/kylegibson/followers","following_url":"https://api.github.com/users/kylegibson/following{/other_user}","gists_url":"https://api.github.com/users/kylegibson/gists{/gist_id}","starred_url":"https://api.github.com/users/kylegibson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kylegibson/subscriptions","organizations_url":"https://api.github.com/users/kylegibson/orgs","repos_url":"https://api.github.com/users/kylegibson/repos","events_url":"https://api.github.com/users/kylegibson/events{/privacy}","received_events_url":"https://api.github.com/users/kylegibson/received_events","type":"User","site_admin":false},"body":"Is there a reason for using `bind` versus `on` ?\r\n\r\nhttp://stackoverflow.com/a/11847066/513197","created_at":"2014-12-01T17:03:01Z","updated_at":"2014-12-01T17:03:01Z","html_url":"https://github.com/wymeditor/wymeditor/pull/628#discussion_r21102082","pull_request_url":"https://api.github.com/repos/wymeditor/wymeditor/pulls/628","_links":{"self":{"href":"https://api.github.com/repos/wymeditor/wymeditor/pulls/comments/21102082"},"html":{"href":"https://github.com/wymeditor/wymeditor/pull/628#discussion_r21102082"},"pull_request":{"href":"https://api.github.com/repos/wymeditor/wymeditor/pulls/628"}}},"pull_request":{"url":"https://api.github.com/repos/wymeditor/wymeditor/pulls/628","id":25168679,"html_url":"https://github.com/wymeditor/wymeditor/pull/628","diff_url":"https://github.com/wymeditor/wymeditor/pull/628.diff","patch_url":"https://github.com/wymeditor/wymeditor/pull/628.patch","issue_url":"https://api.github.com/repos/wymeditor/wymeditor/issues/628","number":628,"state":"open","locked":false,"title":"Check for designMode on focus in all browsers","user":{"login":"mightyiam","id":635591,"avatar_url":"https://avatars.githubusercontent.com/u/635591?v=3","gravatar_id":"","url":"https://api.github.com/users/mightyiam","html_url":"https://github.com/mightyiam","followers_url":"https://api.github.com/users/mightyiam/followers","following_url":"https://api.github.com/users/mightyiam/following{/other_user}","gists_url":"https://api.github.com/users/mightyiam/gists{/gist_id}","starred_url":"https://api.github.com/users/mightyiam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mightyiam/subscriptions","organizations_url":"https://api.github.com/users/mightyiam/orgs","repos_url":"https://api.github.com/users/mightyiam/repos","events_url":"https://api.github.com/users/mightyiam/events{/privacy}","received_events_url":"https://api.github.com/users/mightyiam/received_events","type":"User","site_admin":false},"body":"This PR depends on #629.","created_at":"2014-11-27T20:23:30Z","updated_at":"2014-12-01T17:03:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"16b5f8eeacd3f2d6605dd8377a3ebbf5868c8f2f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wymeditor/wymeditor/pulls/628/commits","review_comments_url":"https://api.github.com/repos/wymeditor/wymeditor/pulls/628/comments","review_comment_url":"https://api.github.com/repos/wymeditor/wymeditor/pulls/comments/{number}","comments_url":"https://api.github.com/repos/wymeditor/wymeditor/issues/628/comments","statuses_url":"https://api.github.com/repos/wymeditor/wymeditor/statuses/2fecdc92a0277627427c7f3a0cdb61927a7d2cff","head":{"label":"wymeditor:geckoFocusResetDesignmodeBug","ref":"geckoFocusResetDesignmodeBug","sha":"2fecdc92a0277627427c7f3a0cdb61927a7d2cff","user":{"login":"wymeditor","id":187598,"avatar_url":"https://avatars.githubusercontent.com/u/187598?v=3","gravatar_id":"","url":"https://api.github.com/users/wymeditor","html_url":"https://github.com/wymeditor","followers_url":"https://api.github.com/users/wymeditor/followers","following_url":"https://api.github.com/users/wymeditor/following{/other_user}","gists_url":"https://api.github.com/users/wymeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/wymeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wymeditor/subscriptions","organizations_url":"https://api.github.com/users/wymeditor/orgs","repos_url":"https://api.github.com/users/wymeditor/repos","events_url":"https://api.github.com/users/wymeditor/events{/privacy}","received_events_url":"https://api.github.com/users/wymeditor/received_events","type":"Organization","site_admin":false},"repo":{"id":483659,"name":"wymeditor","full_name":"wymeditor/wymeditor","owner":{"login":"wymeditor","id":187598,"avatar_url":"https://avatars.githubusercontent.com/u/187598?v=3","gravatar_id":"","url":"https://api.github.com/users/wymeditor","html_url":"https://github.com/wymeditor","followers_url":"https://api.github.com/users/wymeditor/followers","following_url":"https://api.github.com/users/wymeditor/following{/other_user}","gists_url":"https://api.github.com/users/wymeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/wymeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wymeditor/subscriptions","organizations_url":"https://api.github.com/users/wymeditor/orgs","repos_url":"https://api.github.com/users/wymeditor/repos","events_url":"https://api.github.com/users/wymeditor/events{/privacy}","received_events_url":"https://api.github.com/users/wymeditor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wymeditor/wymeditor","description":"Pure js cross-browser WYSIWYM editor with a focus on the clean separation of content and styling.","fork":false,"url":"https://api.github.com/repos/wymeditor/wymeditor","forks_url":"https://api.github.com/repos/wymeditor/wymeditor/forks","keys_url":"https://api.github.com/repos/wymeditor/wymeditor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wymeditor/wymeditor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wymeditor/wymeditor/teams","hooks_url":"https://api.github.com/repos/wymeditor/wymeditor/hooks","issue_events_url":"https://api.github.com/repos/wymeditor/wymeditor/issues/events{/number}","events_url":"https://api.github.com/repos/wymeditor/wymeditor/events","assignees_url":"https://api.github.com/repos/wymeditor/wymeditor/assignees{/user}","branches_url":"https://api.github.com/repos/wymeditor/wymeditor/branches{/branch}","tags_url":"https://api.github.com/repos/wymeditor/wymeditor/tags","blobs_url":"https://api.github.com/repos/wymeditor/wymeditor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wymeditor/wymeditor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wymeditor/wymeditor/git/refs{/sha}","trees_url":"https://api.github.com/repos/wymeditor/wymeditor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wymeditor/wymeditor/statuses/{sha}","languages_url":"https://api.github.com/repos/wymeditor/wymeditor/languages","stargazers_url":"https://api.github.com/repos/wymeditor/wymeditor/stargazers","contributors_url":"https://api.github.com/repos/wymeditor/wymeditor/contributors","subscribers_url":"https://api.github.com/repos/wymeditor/wymeditor/subscribers","subscription_url":"https://api.github.com/repos/wymeditor/wymeditor/subscription","commits_url":"https://api.github.com/repos/wymeditor/wymeditor/commits{/sha}","git_commits_url":"https://api.github.com/repos/wymeditor/wymeditor/git/commits{/sha}","comments_url":"https://api.github.com/repos/wymeditor/wymeditor/comments{/number}","issue_comment_url":"https://api.github.com/repos/wymeditor/wymeditor/issues/comments/{number}","contents_url":"https://api.github.com/repos/wymeditor/wymeditor/contents/{+path}","compare_url":"https://api.github.com/repos/wymeditor/wymeditor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wymeditor/wymeditor/merges","archive_url":"https://api.github.com/repos/wymeditor/wymeditor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wymeditor/wymeditor/downloads","issues_url":"https://api.github.com/repos/wymeditor/wymeditor/issues{/number}","pulls_url":"https://api.github.com/repos/wymeditor/wymeditor/pulls{/number}","milestones_url":"https://api.github.com/repos/wymeditor/wymeditor/milestones{/number}","notifications_url":"https://api.github.com/repos/wymeditor/wymeditor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wymeditor/wymeditor/labels{/name}","releases_url":"https://api.github.com/repos/wymeditor/wymeditor/releases{/id}","created_at":"2010-01-22T10:50:59Z","updated_at":"2014-11-28T18:04:17Z","pushed_at":"2014-12-01T13:46:09Z","git_url":"git://github.com/wymeditor/wymeditor.git","ssh_url":"git@github.com:wymeditor/wymeditor.git","clone_url":"https://github.com/wymeditor/wymeditor.git","svn_url":"https://github.com/wymeditor/wymeditor","homepage":"http://wymeditor.github.io/wymeditor/","size":21376,"stargazers_count":481,"watchers_count":481,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":98,"mirror_url":null,"open_issues_count":111,"forks":98,"open_issues":111,"watchers":481,"default_branch":"master"}},"base":{"label":"wymeditor:master","ref":"master","sha":"dec8d2692e90eb61ede19f1e846855ca09a4787c","user":{"login":"wymeditor","id":187598,"avatar_url":"https://avatars.githubusercontent.com/u/187598?v=3","gravatar_id":"","url":"https://api.github.com/users/wymeditor","html_url":"https://github.com/wymeditor","followers_url":"https://api.github.com/users/wymeditor/followers","following_url":"https://api.github.com/users/wymeditor/following{/other_user}","gists_url":"https://api.github.com/users/wymeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/wymeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wymeditor/subscriptions","organizations_url":"https://api.github.com/users/wymeditor/orgs","repos_url":"https://api.github.com/users/wymeditor/repos","events_url":"https://api.github.com/users/wymeditor/events{/privacy}","received_events_url":"https://api.github.com/users/wymeditor/received_events","type":"Organization","site_admin":false},"repo":{"id":483659,"name":"wymeditor","full_name":"wymeditor/wymeditor","owner":{"login":"wymeditor","id":187598,"avatar_url":"https://avatars.githubusercontent.com/u/187598?v=3","gravatar_id":"","url":"https://api.github.com/users/wymeditor","html_url":"https://github.com/wymeditor","followers_url":"https://api.github.com/users/wymeditor/followers","following_url":"https://api.github.com/users/wymeditor/following{/other_user}","gists_url":"https://api.github.com/users/wymeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/wymeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wymeditor/subscriptions","organizations_url":"https://api.github.com/users/wymeditor/orgs","repos_url":"https://api.github.com/users/wymeditor/repos","events_url":"https://api.github.com/users/wymeditor/events{/privacy}","received_events_url":"https://api.github.com/users/wymeditor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wymeditor/wymeditor","description":"Pure js cross-browser WYSIWYM editor with a focus on the clean separation of content and styling.","fork":false,"url":"https://api.github.com/repos/wymeditor/wymeditor","forks_url":"https://api.github.com/repos/wymeditor/wymeditor/forks","keys_url":"https://api.github.com/repos/wymeditor/wymeditor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wymeditor/wymeditor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wymeditor/wymeditor/teams","hooks_url":"https://api.github.com/repos/wymeditor/wymeditor/hooks","issue_events_url":"https://api.github.com/repos/wymeditor/wymeditor/issues/events{/number}","events_url":"https://api.github.com/repos/wymeditor/wymeditor/events","assignees_url":"https://api.github.com/repos/wymeditor/wymeditor/assignees{/user}","branches_url":"https://api.github.com/repos/wymeditor/wymeditor/branches{/branch}","tags_url":"https://api.github.com/repos/wymeditor/wymeditor/tags","blobs_url":"https://api.github.com/repos/wymeditor/wymeditor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wymeditor/wymeditor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wymeditor/wymeditor/git/refs{/sha}","trees_url":"https://api.github.com/repos/wymeditor/wymeditor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wymeditor/wymeditor/statuses/{sha}","languages_url":"https://api.github.com/repos/wymeditor/wymeditor/languages","stargazers_url":"https://api.github.com/repos/wymeditor/wymeditor/stargazers","contributors_url":"https://api.github.com/repos/wymeditor/wymeditor/contributors","subscribers_url":"https://api.github.com/repos/wymeditor/wymeditor/subscribers","subscription_url":"https://api.github.com/repos/wymeditor/wymeditor/subscription","commits_url":"https://api.github.com/repos/wymeditor/wymeditor/commits{/sha}","git_commits_url":"https://api.github.com/repos/wymeditor/wymeditor/git/commits{/sha}","comments_url":"https://api.github.com/repos/wymeditor/wymeditor/comments{/number}","issue_comment_url":"https://api.github.com/repos/wymeditor/wymeditor/issues/comments/{number}","contents_url":"https://api.github.com/repos/wymeditor/wymeditor/contents/{+path}","compare_url":"https://api.github.com/repos/wymeditor/wymeditor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wymeditor/wymeditor/merges","archive_url":"https://api.github.com/repos/wymeditor/wymeditor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wymeditor/wymeditor/downloads","issues_url":"https://api.github.com/repos/wymeditor/wymeditor/issues{/number}","pulls_url":"https://api.github.com/repos/wymeditor/wymeditor/pulls{/number}","milestones_url":"https://api.github.com/repos/wymeditor/wymeditor/milestones{/number}","notifications_url":"https://api.github.com/repos/wymeditor/wymeditor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wymeditor/wymeditor/labels{/name}","releases_url":"https://api.github.com/repos/wymeditor/wymeditor/releases{/id}","created_at":"2010-01-22T10:50:59Z","updated_at":"2014-11-28T18:04:17Z","pushed_at":"2014-12-01T13:46:09Z","git_url":"git://github.com/wymeditor/wymeditor.git","ssh_url":"git@github.com:wymeditor/wymeditor.git","clone_url":"https://github.com/wymeditor/wymeditor.git","svn_url":"https://github.com/wymeditor/wymeditor","homepage":"http://wymeditor.github.io/wymeditor/","size":21376,"stargazers_count":481,"watchers_count":481,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":98,"mirror_url":null,"open_issues_count":111,"forks":98,"open_issues":111,"watchers":481,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wymeditor/wymeditor/pulls/628"},"html":{"href":"https://github.com/wymeditor/wymeditor/pull/628"},"issue":{"href":"https://api.github.com/repos/wymeditor/wymeditor/issues/628"},"comments":{"href":"https://api.github.com/repos/wymeditor/wymeditor/issues/628/comments"},"review_comments":{"href":"https://api.github.com/repos/wymeditor/wymeditor/pulls/628/comments"},"review_comment":{"href":"https://api.github.com/repos/wymeditor/wymeditor/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/wymeditor/wymeditor/pulls/628/commits"},"statuses":{"href":"https://api.github.com/repos/wymeditor/wymeditor/statuses/2fecdc92a0277627427c7f3a0cdb61927a7d2cff"}}}}