GitHub PullRequestReviewCommentEvent at 2014-06-08 11:48:40
Repository: astropy
Actor: taldcroft
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/taldcroft/astropy/pulls/comments/13523817","id":13523817,"diff_hunk":"@@ -309,3 +309,76 @@ def test_altaz_attributes():\n     aa3 = AltAz(1*u.deg, 2*u.deg, location=EarthLocation(0*u.deg,0*u.deg, 0*u.m))\n     assert isinstance(aa3.location, EarthLocation)\n \n+def test_preferred_representation():\n+    \"\"\"\n+    Test the getter and setter properties for `representation`\n+    \"\"\"\n+    from ..builtin_frames import ICRS\n+\n+    # Create the frame object.\n+    icrs = ICRS(ra=1*u.deg, dec=1*u.deg)\n+    data = icrs.data\n+\n+    # Create some representation objects.\n+    icrs_cart = icrs.cartesian\n+    icrs_spher = icrs.spherical\n+\n+    # Testing when `_representation` set to `CartesianRepresentation`.\n+    icrs.representation = representation.CartesianRepresentation\n+    \n+    assert icrs.representation == representation.CartesianRepresentation\n+    assert icrs_cart.x == icrs.x\n+    assert icrs_cart.y == icrs.y\n+    assert icrs_cart.z == icrs.z\n+    assert repr(icrs) == '<ICRS Coordinate: x=0.99969541351 , y=0.0174497483513 , z=0.0174524064373 >'","path":"astropy/coordinates/tests/test_frames.py","position":25,"original_position":25,"commit_id":"2e8233fe8a19be6cc8b7f19bd2efe5868fe6105e","original_commit_id":"2e8233fe8a19be6cc8b7f19bd2efe5868fe6105e","user":{"login":"taldcroft","id":348089,"avatar_url":"https://avatars.githubusercontent.com/u/348089?","gravatar_id":"2f96f105f664d58e7f857fd6bea74bc0","url":"https://api.github.com/users/taldcroft","html_url":"https://github.com/taldcroft","followers_url":"https://api.github.com/users/taldcroft/followers","following_url":"https://api.github.com/users/taldcroft/following{/other_user}","gists_url":"https://api.github.com/users/taldcroft/gists{/gist_id}","starred_url":"https://api.github.com/users/taldcroft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taldcroft/subscriptions","organizations_url":"https://api.github.com/users/taldcroft/orgs","repos_url":"https://api.github.com/users/taldcroft/repos","events_url":"https://api.github.com/users/taldcroft/events{/privacy}","received_events_url":"https://api.github.com/users/taldcroft/received_events","type":"User","site_admin":false},"body":"To test the values use `np.allclose` or `numpy.testing.assert_allclose` instead of `repr`.","created_at":"2014-06-08T11:48:40Z","updated_at":"2014-06-08T11:48:40Z","html_url":"https://github.com/taldcroft/astropy/pull/9#discussion_r13523817","pull_request_url":"https://api.github.com/repos/taldcroft/astropy/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/taldcroft/astropy/pulls/comments/13523817"},"html":{"href":"https://github.com/taldcroft/astropy/pull/9#discussion_r13523817"},"pull_request":{"href":"https://api.github.com/repos/taldcroft/astropy/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/taldcroft/astropy/pulls/9","id":16851894,"html_url":"https://github.com/taldcroft/astropy/pull/9","diff_url":"https://github.com/taldcroft/astropy/pull/9.diff","patch_url":"https://github.com/taldcroft/astropy/pull/9.patch","issue_url":"https://api.github.com/repos/taldcroft/astropy/issues/9","number":9,"state":"open","title":"Tests for coordinates","user":{"login":"VaticanCameos","id":1412833,"avatar_url":"https://avatars.githubusercontent.com/u/1412833?","gravatar_id":"8cca76f98d63c5a0ef8a8fe0a0ac00d0","url":"https://api.github.com/users/VaticanCameos","html_url":"https://github.com/VaticanCameos","followers_url":"https://api.github.com/users/VaticanCameos/followers","following_url":"https://api.github.com/users/VaticanCameos/following{/other_user}","gists_url":"https://api.github.com/users/VaticanCameos/gists{/gist_id}","starred_url":"https://api.github.com/users/VaticanCameos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VaticanCameos/subscriptions","organizations_url":"https://api.github.com/users/VaticanCameos/orgs","repos_url":"https://api.github.com/users/VaticanCameos/repos","events_url":"https://api.github.com/users/VaticanCameos/events{/privacy}","received_events_url":"https://api.github.com/users/VaticanCameos/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-06-07T06:27:11Z","updated_at":"2014-06-08T11:48:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b49f7d842a9e4a377053b77c9d9f93a0fead7d2f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/taldcroft/astropy/pulls/9/commits","review_comments_url":"https://api.github.com/repos/taldcroft/astropy/pulls/9/comments","review_comment_url":"https://api.github.com/repos/taldcroft/astropy/pulls/comments/{number}","comments_url":"https://api.github.com/repos/taldcroft/astropy/issues/9/comments","statuses_url":"https://api.github.com/repos/taldcroft/astropy/statuses/2e8233fe8a19be6cc8b7f19bd2efe5868fe6105e","head":{"label":"VaticanCameos:coord-pref-tests","ref":"coord-pref-tests","sha":"2e8233fe8a19be6cc8b7f19bd2efe5868fe6105e","user":{"login":"VaticanCameos","id":1412833,"avatar_url":"https://avatars.githubusercontent.com/u/1412833?","gravatar_id":"8cca76f98d63c5a0ef8a8fe0a0ac00d0","url":"https://api.github.com/users/VaticanCameos","html_url":"https://github.com/VaticanCameos","followers_url":"https://api.github.com/users/VaticanCameos/followers","following_url":"https://api.github.com/users/VaticanCameos/following{/other_user}","gists_url":"https://api.github.com/users/VaticanCameos/gists{/gist_id}","starred_url":"https://api.github.com/users/VaticanCameos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VaticanCameos/subscriptions","organizations_url":"https://api.github.com/users/VaticanCameos/orgs","repos_url":"https://api.github.com/users/VaticanCameos/repos","events_url":"https://api.github.com/users/VaticanCameos/events{/privacy}","received_events_url":"https://api.github.com/users/VaticanCameos/received_events","type":"User","site_admin":false},"repo":{"id":18946821,"name":"astropy","full_name":"VaticanCameos/astropy","owner":{"login":"VaticanCameos","id":1412833,"avatar_url":"https://avatars.githubusercontent.com/u/1412833?","gravatar_id":"8cca76f98d63c5a0ef8a8fe0a0ac00d0","url":"https://api.github.com/users/VaticanCameos","html_url":"https://github.com/VaticanCameos","followers_url":"https://api.github.com/users/VaticanCameos/followers","following_url":"https://api.github.com/users/VaticanCameos/following{/other_user}","gists_url":"https://api.github.com/users/VaticanCameos/gists{/gist_id}","starred_url":"https://api.github.com/users/VaticanCameos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VaticanCameos/subscriptions","organizations_url":"https://api.github.com/users/VaticanCameos/orgs","repos_url":"https://api.github.com/users/VaticanCameos/repos","events_url":"https://api.github.com/users/VaticanCameos/events{/privacy}","received_events_url":"https://api.github.com/users/VaticanCameos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/VaticanCameos/astropy","description":"Main Astropy repository","fork":true,"url":"https://api.github.com/repos/VaticanCameos/astropy","forks_url":"https://api.github.com/repos/VaticanCameos/astropy/forks","keys_url":"https://api.github.com/repos/VaticanCameos/astropy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VaticanCameos/astropy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VaticanCameos/astropy/teams","hooks_url":"https://api.github.com/repos/VaticanCameos/astropy/hooks","issue_events_url":"https://api.github.com/repos/VaticanCameos/astropy/issues/events{/number}","events_url":"https://api.github.com/repos/VaticanCameos/astropy/events","assignees_url":"https://api.github.com/repos/VaticanCameos/astropy/assignees{/user}","branches_url":"https://api.github.com/repos/VaticanCameos/astropy/branches{/branch}","tags_url":"https://api.github.com/repos/VaticanCameos/astropy/tags","blobs_url":"https://api.github.com/repos/VaticanCameos/astropy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VaticanCameos/astropy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VaticanCameos/astropy/git/refs{/sha}","trees_url":"https://api.github.com/repos/VaticanCameos/astropy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VaticanCameos/astropy/statuses/{sha}","languages_url":"https://api.github.com/repos/VaticanCameos/astropy/languages","stargazers_url":"https://api.github.com/repos/VaticanCameos/astropy/stargazers","contributors_url":"https://api.github.com/repos/VaticanCameos/astropy/contributors","subscribers_url":"https://api.github.com/repos/VaticanCameos/astropy/subscribers","subscription_url":"https://api.github.com/repos/VaticanCameos/astropy/subscription","commits_url":"https://api.github.com/repos/VaticanCameos/astropy/commits{/sha}","git_commits_url":"https://api.github.com/repos/VaticanCameos/astropy/git/commits{/sha}","comments_url":"https://api.github.com/repos/VaticanCameos/astropy/comments{/number}","issue_comment_url":"https://api.github.com/repos/VaticanCameos/astropy/issues/comments/{number}","contents_url":"https://api.github.com/repos/VaticanCameos/astropy/contents/{+path}","compare_url":"https://api.github.com/repos/VaticanCameos/astropy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VaticanCameos/astropy/merges","archive_url":"https://api.github.com/repos/VaticanCameos/astropy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VaticanCameos/astropy/downloads","issues_url":"https://api.github.com/repos/VaticanCameos/astropy/issues{/number}","pulls_url":"https://api.github.com/repos/VaticanCameos/astropy/pulls{/number}","milestones_url":"https://api.github.com/repos/VaticanCameos/astropy/milestones{/number}","notifications_url":"https://api.github.com/repos/VaticanCameos/astropy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VaticanCameos/astropy/labels{/name}","releases_url":"https://api.github.com/repos/VaticanCameos/astropy/releases{/id}","created_at":"2014-04-19T17:36:20Z","updated_at":"2014-06-08T06:24:28Z","pushed_at":"2014-06-08T06:24:28Z","git_url":"git://github.com/VaticanCameos/astropy.git","ssh_url":"git@github.com:VaticanCameos/astropy.git","clone_url":"https://github.com/VaticanCameos/astropy.git","svn_url":"https://github.com/VaticanCameos/astropy","homepage":"astropy.org","size":26201,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"taldcroft:coordinates-preferred","ref":"coordinates-preferred","sha":"1d597b8c896dc6c34b43d2cd474547cba0d037f2","user":{"login":"taldcroft","id":348089,"avatar_url":"https://avatars.githubusercontent.com/u/348089?","gravatar_id":"2f96f105f664d58e7f857fd6bea74bc0","url":"https://api.github.com/users/taldcroft","html_url":"https://github.com/taldcroft","followers_url":"https://api.github.com/users/taldcroft/followers","following_url":"https://api.github.com/users/taldcroft/following{/other_user}","gists_url":"https://api.github.com/users/taldcroft/gists{/gist_id}","starred_url":"https://api.github.com/users/taldcroft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taldcroft/subscriptions","organizations_url":"https://api.github.com/users/taldcroft/orgs","repos_url":"https://api.github.com/users/taldcroft/repos","events_url":"https://api.github.com/users/taldcroft/events{/privacy}","received_events_url":"https://api.github.com/users/taldcroft/received_events","type":"User","site_admin":false},"repo":{"id":2571537,"name":"astropy","full_name":"taldcroft/astropy","owner":{"login":"taldcroft","id":348089,"avatar_url":"https://avatars.githubusercontent.com/u/348089?","gravatar_id":"2f96f105f664d58e7f857fd6bea74bc0","url":"https://api.github.com/users/taldcroft","html_url":"https://github.com/taldcroft","followers_url":"https://api.github.com/users/taldcroft/followers","following_url":"https://api.github.com/users/taldcroft/following{/other_user}","gists_url":"https://api.github.com/users/taldcroft/gists{/gist_id}","starred_url":"https://api.github.com/users/taldcroft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taldcroft/subscriptions","organizations_url":"https://api.github.com/users/taldcroft/orgs","repos_url":"https://api.github.com/users/taldcroft/repos","events_url":"https://api.github.com/users/taldcroft/events{/privacy}","received_events_url":"https://api.github.com/users/taldcroft/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/taldcroft/astropy","description":"Main AstroPy repository","fork":true,"url":"https://api.github.com/repos/taldcroft/astropy","forks_url":"https://api.github.com/repos/taldcroft/astropy/forks","keys_url":"https://api.github.com/repos/taldcroft/astropy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/taldcroft/astropy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/taldcroft/astropy/teams","hooks_url":"https://api.github.com/repos/taldcroft/astropy/hooks","issue_events_url":"https://api.github.com/repos/taldcroft/astropy/issues/events{/number}","events_url":"https://api.github.com/repos/taldcroft/astropy/events","assignees_url":"https://api.github.com/repos/taldcroft/astropy/assignees{/user}","branches_url":"https://api.github.com/repos/taldcroft/astropy/branches{/branch}","tags_url":"https://api.github.com/repos/taldcroft/astropy/tags","blobs_url":"https://api.github.com/repos/taldcroft/astropy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/taldcroft/astropy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/taldcroft/astropy/git/refs{/sha}","trees_url":"https://api.github.com/repos/taldcroft/astropy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/taldcroft/astropy/statuses/{sha}","languages_url":"https://api.github.com/repos/taldcroft/astropy/languages","stargazers_url":"https://api.github.com/repos/taldcroft/astropy/stargazers","contributors_url":"https://api.github.com/repos/taldcroft/astropy/contributors","subscribers_url":"https://api.github.com/repos/taldcroft/astropy/subscribers","subscription_url":"https://api.github.com/repos/taldcroft/astropy/subscription","commits_url":"https://api.github.com/repos/taldcroft/astropy/commits{/sha}","git_commits_url":"https://api.github.com/repos/taldcroft/astropy/git/commits{/sha}","comments_url":"https://api.github.com/repos/taldcroft/astropy/comments{/number}","issue_comment_url":"https://api.github.com/repos/taldcroft/astropy/issues/comments/{number}","contents_url":"https://api.github.com/repos/taldcroft/astropy/contents/{+path}","compare_url":"https://api.github.com/repos/taldcroft/astropy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/taldcroft/astropy/merges","archive_url":"https://api.github.com/repos/taldcroft/astropy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/taldcroft/astropy/downloads","issues_url":"https://api.github.com/repos/taldcroft/astropy/issues{/number}","pulls_url":"https://api.github.com/repos/taldcroft/astropy/pulls{/number}","milestones_url":"https://api.github.com/repos/taldcroft/astropy/milestones{/number}","notifications_url":"https://api.github.com/repos/taldcroft/astropy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/taldcroft/astropy/labels{/name}","releases_url":"https://api.github.com/repos/taldcroft/astropy/releases{/id}","created_at":"2011-10-13T18:44:28Z","updated_at":"2014-06-08T02:19:04Z","pushed_at":"2014-06-08T02:19:04Z","git_url":"git://github.com/taldcroft/astropy.git","ssh_url":"git@github.com:taldcroft/astropy.git","clone_url":"https://github.com/taldcroft/astropy.git","svn_url":"https://github.com/taldcroft/astropy","homepage":"astropy.org","size":27415,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/taldcroft/astropy/pulls/9"},"html":{"href":"https://github.com/taldcroft/astropy/pull/9"},"issue":{"href":"https://api.github.com/repos/taldcroft/astropy/issues/9"},"comments":{"href":"https://api.github.com/repos/taldcroft/astropy/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/taldcroft/astropy/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/taldcroft/astropy/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/taldcroft/astropy/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/taldcroft/astropy/statuses/2e8233fe8a19be6cc8b7f19bd2efe5868fe6105e"}}}}