GitHub PullRequestReviewCommentEvent at 2014-10-22 17:59:57
Repository: projectile
Actor: YorkZ
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/bbatsov/projectile/pulls/comments/19231952","id":19231952,"diff_hunk":"@@ -1568,26 +1568,24 @@ With a prefix ARG invalidates the cache first.\"\n Expands wildcards using `file-expand-wildcards' before checking.\"\n   (file-expand-wildcards (projectile-expand-root file)))\n \n-(defun projectile-project-vcs (&optional dir)\n+(defun projectile-project-vcs (&optional project-root)\n   \"Determine the VCS used by the project if any.\n DIR is the targeted directory.  If nil, use `projectile-project-root'.\"","path":"projectile.el","position":null,"original_position":7,"commit_id":"792bf40e69b34ad05438370da69ca29f3a0fd1cc","original_commit_id":"11c9fc8d8c3a5366bd430b5018fe820f035aadc4","user":{"login":"YorkZ","id":742238,"avatar_url":"https://avatars.githubusercontent.com/u/742238?v=2","gravatar_id":"","url":"https://api.github.com/users/YorkZ","html_url":"https://github.com/YorkZ","followers_url":"https://api.github.com/users/YorkZ/followers","following_url":"https://api.github.com/users/YorkZ/following{/other_user}","gists_url":"https://api.github.com/users/YorkZ/gists{/gist_id}","starred_url":"https://api.github.com/users/YorkZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YorkZ/subscriptions","organizations_url":"https://api.github.com/users/YorkZ/orgs","repos_url":"https://api.github.com/users/YorkZ/repos","events_url":"https://api.github.com/users/YorkZ/events{/privacy}","received_events_url":"https://api.github.com/users/YorkZ/received_events","type":"User","site_admin":false},"body":"Now I see, you were referring to the name in the doc string, I apologize. I've fixed this, please check it out.\r\n\r\nYork\r\n","created_at":"2014-10-22T17:59:57Z","updated_at":"2014-10-22T17:59:57Z","html_url":"https://github.com/bbatsov/projectile/pull/474#discussion_r19231952","pull_request_url":"https://api.github.com/repos/bbatsov/projectile/pulls/474","_links":{"self":{"href":"https://api.github.com/repos/bbatsov/projectile/pulls/comments/19231952"},"html":{"href":"https://github.com/bbatsov/projectile/pull/474#discussion_r19231952"},"pull_request":{"href":"https://api.github.com/repos/bbatsov/projectile/pulls/474"}}},"pull_request":{"url":"https://api.github.com/repos/bbatsov/projectile/pulls/474","id":22787632,"html_url":"https://github.com/bbatsov/projectile/pull/474","diff_url":"https://github.com/bbatsov/projectile/pull/474.diff","patch_url":"https://github.com/bbatsov/projectile/pull/474.patch","issue_url":"https://api.github.com/repos/bbatsov/projectile/issues/474","number":474,"state":"open","locked":false,"title":"Performance optimization and eliminate boilerplate code","user":{"login":"YorkZ","id":742238,"avatar_url":"https://avatars.githubusercontent.com/u/742238?v=2","gravatar_id":"","url":"https://api.github.com/users/YorkZ","html_url":"https://github.com/YorkZ","followers_url":"https://api.github.com/users/YorkZ/followers","following_url":"https://api.github.com/users/YorkZ/following{/other_user}","gists_url":"https://api.github.com/users/YorkZ/gists{/gist_id}","starred_url":"https://api.github.com/users/YorkZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YorkZ/subscriptions","organizations_url":"https://api.github.com/users/YorkZ/orgs","repos_url":"https://api.github.com/users/YorkZ/repos","events_url":"https://api.github.com/users/YorkZ/events{/privacy}","received_events_url":"https://api.github.com/users/YorkZ/received_events","type":"User","site_admin":false},"body":"Hi Bozhidar,\r\n\r\nI added a few improvements:\r\n\r\n1. Optimized the macro `helm-source-projectile-projects` for the sake of performance. This is because \"list\" in Emacs Lisp is singly-linked list, frequently adding to the end of a list using `add-to-list` can be slow. For this reason, it's better to add to the front of a list, and just do a one-time reverse after adding all the items.\r\n2. Minor cleanup on `projectile-project-vcs`\r\n3. Added the optional parameter `project-root` for function `projectile-vc` to allow being called from `helm-projectile-vc`, to eliminate boilerplate code.\r\n\r\nThanks,\r\n\r\nYork Zhao","created_at":"2014-10-15T14:34:42Z","updated_at":"2014-10-22T17:59:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b1b40235f56dc312dcdb35e5c9f258aebdd37d07","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bbatsov/projectile/pulls/474/commits","review_comments_url":"https://api.github.com/repos/bbatsov/projectile/pulls/474/comments","review_comment_url":"https://api.github.com/repos/bbatsov/projectile/pulls/comments/{number}","comments_url":"https://api.github.com/repos/bbatsov/projectile/issues/474/comments","statuses_url":"https://api.github.com/repos/bbatsov/projectile/statuses/792bf40e69b34ad05438370da69ca29f3a0fd1cc","head":{"label":"YorkZ:helm-switch-project","ref":"helm-switch-project","sha":"792bf40e69b34ad05438370da69ca29f3a0fd1cc","user":{"login":"YorkZ","id":742238,"avatar_url":"https://avatars.githubusercontent.com/u/742238?v=2","gravatar_id":"","url":"https://api.github.com/users/YorkZ","html_url":"https://github.com/YorkZ","followers_url":"https://api.github.com/users/YorkZ/followers","following_url":"https://api.github.com/users/YorkZ/following{/other_user}","gists_url":"https://api.github.com/users/YorkZ/gists{/gist_id}","starred_url":"https://api.github.com/users/YorkZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YorkZ/subscriptions","organizations_url":"https://api.github.com/users/YorkZ/orgs","repos_url":"https://api.github.com/users/YorkZ/repos","events_url":"https://api.github.com/users/YorkZ/events{/privacy}","received_events_url":"https://api.github.com/users/YorkZ/received_events","type":"User","site_admin":false},"repo":{"id":17888361,"name":"projectile","full_name":"YorkZ/projectile","owner":{"login":"YorkZ","id":742238,"avatar_url":"https://avatars.githubusercontent.com/u/742238?v=2","gravatar_id":"","url":"https://api.github.com/users/YorkZ","html_url":"https://github.com/YorkZ","followers_url":"https://api.github.com/users/YorkZ/followers","following_url":"https://api.github.com/users/YorkZ/following{/other_user}","gists_url":"https://api.github.com/users/YorkZ/gists{/gist_id}","starred_url":"https://api.github.com/users/YorkZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YorkZ/subscriptions","organizations_url":"https://api.github.com/users/YorkZ/orgs","repos_url":"https://api.github.com/users/YorkZ/repos","events_url":"https://api.github.com/users/YorkZ/events{/privacy}","received_events_url":"https://api.github.com/users/YorkZ/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/YorkZ/projectile","description":"Project Interaction Library for Emacs","fork":true,"url":"https://api.github.com/repos/YorkZ/projectile","forks_url":"https://api.github.com/repos/YorkZ/projectile/forks","keys_url":"https://api.github.com/repos/YorkZ/projectile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/YorkZ/projectile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/YorkZ/projectile/teams","hooks_url":"https://api.github.com/repos/YorkZ/projectile/hooks","issue_events_url":"https://api.github.com/repos/YorkZ/projectile/issues/events{/number}","events_url":"https://api.github.com/repos/YorkZ/projectile/events","assignees_url":"https://api.github.com/repos/YorkZ/projectile/assignees{/user}","branches_url":"https://api.github.com/repos/YorkZ/projectile/branches{/branch}","tags_url":"https://api.github.com/repos/YorkZ/projectile/tags","blobs_url":"https://api.github.com/repos/YorkZ/projectile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/YorkZ/projectile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/YorkZ/projectile/git/refs{/sha}","trees_url":"https://api.github.com/repos/YorkZ/projectile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/YorkZ/projectile/statuses/{sha}","languages_url":"https://api.github.com/repos/YorkZ/projectile/languages","stargazers_url":"https://api.github.com/repos/YorkZ/projectile/stargazers","contributors_url":"https://api.github.com/repos/YorkZ/projectile/contributors","subscribers_url":"https://api.github.com/repos/YorkZ/projectile/subscribers","subscription_url":"https://api.github.com/repos/YorkZ/projectile/subscription","commits_url":"https://api.github.com/repos/YorkZ/projectile/commits{/sha}","git_commits_url":"https://api.github.com/repos/YorkZ/projectile/git/commits{/sha}","comments_url":"https://api.github.com/repos/YorkZ/projectile/comments{/number}","issue_comment_url":"https://api.github.com/repos/YorkZ/projectile/issues/comments/{number}","contents_url":"https://api.github.com/repos/YorkZ/projectile/contents/{+path}","compare_url":"https://api.github.com/repos/YorkZ/projectile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/YorkZ/projectile/merges","archive_url":"https://api.github.com/repos/YorkZ/projectile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/YorkZ/projectile/downloads","issues_url":"https://api.github.com/repos/YorkZ/projectile/issues{/number}","pulls_url":"https://api.github.com/repos/YorkZ/projectile/pulls{/number}","milestones_url":"https://api.github.com/repos/YorkZ/projectile/milestones{/number}","notifications_url":"https://api.github.com/repos/YorkZ/projectile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/YorkZ/projectile/labels{/name}","releases_url":"https://api.github.com/repos/YorkZ/projectile/releases{/id}","created_at":"2014-03-19T01:31:00Z","updated_at":"2014-08-07T21:17:36Z","pushed_at":"2014-10-22T17:52:12Z","git_url":"git://github.com/YorkZ/projectile.git","ssh_url":"git@github.com:YorkZ/projectile.git","clone_url":"https://github.com/YorkZ/projectile.git","svn_url":"https://github.com/YorkZ/projectile","homepage":"","size":2340,"stargazers_count":0,"watchers_count":0,"language":"Emacs Lisp","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bbatsov:master","ref":"master","sha":"13580d83374e0c17c55b3a680b816dfae407657e","user":{"login":"bbatsov","id":103882,"avatar_url":"https://avatars.githubusercontent.com/u/103882?v=2","gravatar_id":"","url":"https://api.github.com/users/bbatsov","html_url":"https://github.com/bbatsov","followers_url":"https://api.github.com/users/bbatsov/followers","following_url":"https://api.github.com/users/bbatsov/following{/other_user}","gists_url":"https://api.github.com/users/bbatsov/gists{/gist_id}","starred_url":"https://api.github.com/users/bbatsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbatsov/subscriptions","organizations_url":"https://api.github.com/users/bbatsov/orgs","repos_url":"https://api.github.com/users/bbatsov/repos","events_url":"https://api.github.com/users/bbatsov/events{/privacy}","received_events_url":"https://api.github.com/users/bbatsov/received_events","type":"User","site_admin":false},"repo":{"id":2133437,"name":"projectile","full_name":"bbatsov/projectile","owner":{"login":"bbatsov","id":103882,"avatar_url":"https://avatars.githubusercontent.com/u/103882?v=2","gravatar_id":"","url":"https://api.github.com/users/bbatsov","html_url":"https://github.com/bbatsov","followers_url":"https://api.github.com/users/bbatsov/followers","following_url":"https://api.github.com/users/bbatsov/following{/other_user}","gists_url":"https://api.github.com/users/bbatsov/gists{/gist_id}","starred_url":"https://api.github.com/users/bbatsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbatsov/subscriptions","organizations_url":"https://api.github.com/users/bbatsov/orgs","repos_url":"https://api.github.com/users/bbatsov/repos","events_url":"https://api.github.com/users/bbatsov/events{/privacy}","received_events_url":"https://api.github.com/users/bbatsov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bbatsov/projectile","description":"Project Interaction Library for Emacs","fork":false,"url":"https://api.github.com/repos/bbatsov/projectile","forks_url":"https://api.github.com/repos/bbatsov/projectile/forks","keys_url":"https://api.github.com/repos/bbatsov/projectile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bbatsov/projectile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bbatsov/projectile/teams","hooks_url":"https://api.github.com/repos/bbatsov/projectile/hooks","issue_events_url":"https://api.github.com/repos/bbatsov/projectile/issues/events{/number}","events_url":"https://api.github.com/repos/bbatsov/projectile/events","assignees_url":"https://api.github.com/repos/bbatsov/projectile/assignees{/user}","branches_url":"https://api.github.com/repos/bbatsov/projectile/branches{/branch}","tags_url":"https://api.github.com/repos/bbatsov/projectile/tags","blobs_url":"https://api.github.com/repos/bbatsov/projectile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bbatsov/projectile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bbatsov/projectile/git/refs{/sha}","trees_url":"https://api.github.com/repos/bbatsov/projectile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bbatsov/projectile/statuses/{sha}","languages_url":"https://api.github.com/repos/bbatsov/projectile/languages","stargazers_url":"https://api.github.com/repos/bbatsov/projectile/stargazers","contributors_url":"https://api.github.com/repos/bbatsov/projectile/contributors","subscribers_url":"https://api.github.com/repos/bbatsov/projectile/subscribers","subscription_url":"https://api.github.com/repos/bbatsov/projectile/subscription","commits_url":"https://api.github.com/repos/bbatsov/projectile/commits{/sha}","git_commits_url":"https://api.github.com/repos/bbatsov/projectile/git/commits{/sha}","comments_url":"https://api.github.com/repos/bbatsov/projectile/comments{/number}","issue_comment_url":"https://api.github.com/repos/bbatsov/projectile/issues/comments/{number}","contents_url":"https://api.github.com/repos/bbatsov/projectile/contents/{+path}","compare_url":"https://api.github.com/repos/bbatsov/projectile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bbatsov/projectile/merges","archive_url":"https://api.github.com/repos/bbatsov/projectile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bbatsov/projectile/downloads","issues_url":"https://api.github.com/repos/bbatsov/projectile/issues{/number}","pulls_url":"https://api.github.com/repos/bbatsov/projectile/pulls{/number}","milestones_url":"https://api.github.com/repos/bbatsov/projectile/milestones{/number}","notifications_url":"https://api.github.com/repos/bbatsov/projectile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bbatsov/projectile/labels{/name}","releases_url":"https://api.github.com/repos/bbatsov/projectile/releases{/id}","created_at":"2011-07-31T19:12:31Z","updated_at":"2014-10-22T16:49:23Z","pushed_at":"2014-10-21T06:05:23Z","git_url":"git://github.com/bbatsov/projectile.git","ssh_url":"git@github.com:bbatsov/projectile.git","clone_url":"https://github.com/bbatsov/projectile.git","svn_url":"https://github.com/bbatsov/projectile","homepage":"","size":6699,"stargazers_count":735,"watchers_count":735,"language":"Emacs Lisp","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":139,"mirror_url":null,"open_issues_count":51,"forks":139,"open_issues":51,"watchers":735,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bbatsov/projectile/pulls/474"},"html":{"href":"https://github.com/bbatsov/projectile/pull/474"},"issue":{"href":"https://api.github.com/repos/bbatsov/projectile/issues/474"},"comments":{"href":"https://api.github.com/repos/bbatsov/projectile/issues/474/comments"},"review_comments":{"href":"https://api.github.com/repos/bbatsov/projectile/pulls/474/comments"},"review_comment":{"href":"https://api.github.com/repos/bbatsov/projectile/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/bbatsov/projectile/pulls/474/commits"},"statuses":{"href":"https://api.github.com/repos/bbatsov/projectile/statuses/792bf40e69b34ad05438370da69ca29f3a0fd1cc"}}}}