GitHub PullRequestEvent at 2014-08-11 14:47:22
Repository: ember-inspector
Actor: teddyzeenny
Payload: {"action":"closed","number":190,"pull_request":{"url":"https://api.github.com/repos/emberjs/ember-inspector/pulls/190","id":19529154,"html_url":"https://github.com/emberjs/ember-inspector/pull/190","diff_url":"https://github.com/emberjs/ember-inspector/pull/190.diff","patch_url":"https://github.com/emberjs/ember-inspector/pull/190.patch","issue_url":"https://api.github.com/repos/emberjs/ember-inspector/issues/190","number":190,"state":"closed","title":"Add bookmarklet option to support all browsers","user":{"login":"teddyzeenny","id":1061742,"avatar_url":"https://avatars.githubusercontent.com/u/1061742?v=2","gravatar_id":"fcff4ff31a2f4380c73b257492c8b796","url":"https://api.github.com/users/teddyzeenny","html_url":"https://github.com/teddyzeenny","followers_url":"https://api.github.com/users/teddyzeenny/followers","following_url":"https://api.github.com/users/teddyzeenny/following{/other_user}","gists_url":"https://api.github.com/users/teddyzeenny/gists{/gist_id}","starred_url":"https://api.github.com/users/teddyzeenny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teddyzeenny/subscriptions","organizations_url":"https://api.github.com/users/teddyzeenny/orgs","repos_url":"https://api.github.com/users/teddyzeenny/repos","events_url":"https://api.github.com/users/teddyzeenny/events{/privacy}","received_events_url":"https://api.github.com/users/teddyzeenny/received_events","type":"User","site_admin":false},"body":"This will make the inspector work with all browsers, and will allow for easier debugging of the inspector during development.\r\n\r\nIn production mode:\r\n\r\n```javascript\r\njavascript: (function() { var s = document.createElement('script'); s.src = 'http://ember-extension.s3-website-us-east-1.amazonaws.com/dist_bookmarklet/load_inspector.js'; document.body.appendChild(s); }());\r\n```\r\n\r\nTo run the bookmarklet in dev mode:\r\n- `grunt bookmarklet_server`\r\n- create a bookmark:\r\n\r\n```javascript\r\n\r\njavascript: (function() { var s = document.createElement('script'); s.src = 'http://localhost:9191/load_inspector.js'; document.body.appendChild(s); }());\r\n\r\n````\r\n\r\nClicking on the bookmark opens a new window with the inspector.  Make\r\nsure to unblock the popup.\r\n\r\nThis can also be used to debug the inspector (in the popup) using the inspector\r\nextension.\r\n\r\nFixes #145 #184 \r\n\r\n- [x] Bookmarklet for development mode (need to clone repo)\r\n- [x] Handle page reload (Close inspector on reload for now)\r\n- [x] Fix issues with Safari rendering / css\r\n- [x] Check if there's a security issue due to the use of `*` in `window.postMessage` (Added URLs)\r\n- [x] Bookmarklet for production (upload it to s3, which will make it very easy to use)\r\n- [x] Upload to correct s3 domain\r\n","created_at":"2014-08-08T14:12:11Z","updated_at":"2014-08-11T14:47:21Z","closed_at":"2014-08-11T14:47:21Z","merged_at":"2014-08-11T14:47:21Z","merge_commit_sha":"1ac7b1dc266857e569ac6a5f31150b784546abe3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/emberjs/ember-inspector/pulls/190/commits","review_comments_url":"https://api.github.com/repos/emberjs/ember-inspector/pulls/190/comments","review_comment_url":"https://api.github.com/repos/emberjs/ember-inspector/pulls/comments/{number}","comments_url":"https://api.github.com/repos/emberjs/ember-inspector/issues/190/comments","statuses_url":"https://api.github.com/repos/emberjs/ember-inspector/statuses/569fdedf05f8da69fe498a81dd2cb69a46e82794","head":{"label":"emberjs:bookmark","ref":"bookmark","sha":"569fdedf05f8da69fe498a81dd2cb69a46e82794","user":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=2","gravatar_id":"792333d2bad390e8a2e23f5e2f41f214","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":7876204,"name":"ember-inspector","full_name":"emberjs/ember-inspector","owner":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=2","gravatar_id":"792333d2bad390e8a2e23f5e2f41f214","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emberjs/ember-inspector","description":"","fork":false,"url":"https://api.github.com/repos/emberjs/ember-inspector","forks_url":"https://api.github.com/repos/emberjs/ember-inspector/forks","keys_url":"https://api.github.com/repos/emberjs/ember-inspector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emberjs/ember-inspector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emberjs/ember-inspector/teams","hooks_url":"https://api.github.com/repos/emberjs/ember-inspector/hooks","issue_events_url":"https://api.github.com/repos/emberjs/ember-inspector/issues/events{/number}","events_url":"https://api.github.com/repos/emberjs/ember-inspector/events","assignees_url":"https://api.github.com/repos/emberjs/ember-inspector/assignees{/user}","branches_url":"https://api.github.com/repos/emberjs/ember-inspector/branches{/branch}","tags_url":"https://api.github.com/repos/emberjs/ember-inspector/tags","blobs_url":"https://api.github.com/repos/emberjs/ember-inspector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emberjs/ember-inspector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emberjs/ember-inspector/git/refs{/sha}","trees_url":"https://api.github.com/repos/emberjs/ember-inspector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emberjs/ember-inspector/statuses/{sha}","languages_url":"https://api.github.com/repos/emberjs/ember-inspector/languages","stargazers_url":"https://api.github.com/repos/emberjs/ember-inspector/stargazers","contributors_url":"https://api.github.com/repos/emberjs/ember-inspector/contributors","subscribers_url":"https://api.github.com/repos/emberjs/ember-inspector/subscribers","subscription_url":"https://api.github.com/repos/emberjs/ember-inspector/subscription","commits_url":"https://api.github.com/repos/emberjs/ember-inspector/commits{/sha}","git_commits_url":"https://api.github.com/repos/emberjs/ember-inspector/git/commits{/sha}","comments_url":"https://api.github.com/repos/emberjs/ember-inspector/comments{/number}","issue_comment_url":"https://api.github.com/repos/emberjs/ember-inspector/issues/comments/{number}","contents_url":"https://api.github.com/repos/emberjs/ember-inspector/contents/{+path}","compare_url":"https://api.github.com/repos/emberjs/ember-inspector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emberjs/ember-inspector/merges","archive_url":"https://api.github.com/repos/emberjs/ember-inspector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emberjs/ember-inspector/downloads","issues_url":"https://api.github.com/repos/emberjs/ember-inspector/issues{/number}","pulls_url":"https://api.github.com/repos/emberjs/ember-inspector/pulls{/number}","milestones_url":"https://api.github.com/repos/emberjs/ember-inspector/milestones{/number}","notifications_url":"https://api.github.com/repos/emberjs/ember-inspector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emberjs/ember-inspector/labels{/name}","releases_url":"https://api.github.com/repos/emberjs/ember-inspector/releases{/id}","created_at":"2013-01-28T18:36:15Z","updated_at":"2014-08-11T09:39:23Z","pushed_at":"2014-08-11T14:47:21Z","git_url":"git://github.com/emberjs/ember-inspector.git","ssh_url":"git@github.com:emberjs/ember-inspector.git","clone_url":"https://github.com/emberjs/ember-inspector.git","svn_url":"https://github.com/emberjs/ember-inspector","homepage":null,"size":4975,"stargazers_count":524,"watchers_count":524,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":92,"mirror_url":null,"open_issues_count":53,"forks":92,"open_issues":53,"watchers":524,"default_branch":"master"}},"base":{"label":"emberjs:master","ref":"master","sha":"de1da23572444f5aef09f4a31efaa24010161f61","user":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=2","gravatar_id":"792333d2bad390e8a2e23f5e2f41f214","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":7876204,"name":"ember-inspector","full_name":"emberjs/ember-inspector","owner":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=2","gravatar_id":"792333d2bad390e8a2e23f5e2f41f214","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emberjs/ember-inspector","description":"","fork":false,"url":"https://api.github.com/repos/emberjs/ember-inspector","forks_url":"https://api.github.com/repos/emberjs/ember-inspector/forks","keys_url":"https://api.github.com/repos/emberjs/ember-inspector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emberjs/ember-inspector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emberjs/ember-inspector/teams","hooks_url":"https://api.github.com/repos/emberjs/ember-inspector/hooks","issue_events_url":"https://api.github.com/repos/emberjs/ember-inspector/issues/events{/number}","events_url":"https://api.github.com/repos/emberjs/ember-inspector/events","assignees_url":"https://api.github.com/repos/emberjs/ember-inspector/assignees{/user}","branches_url":"https://api.github.com/repos/emberjs/ember-inspector/branches{/branch}","tags_url":"https://api.github.com/repos/emberjs/ember-inspector/tags","blobs_url":"https://api.github.com/repos/emberjs/ember-inspector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emberjs/ember-inspector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emberjs/ember-inspector/git/refs{/sha}","trees_url":"https://api.github.com/repos/emberjs/ember-inspector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emberjs/ember-inspector/statuses/{sha}","languages_url":"https://api.github.com/repos/emberjs/ember-inspector/languages","stargazers_url":"https://api.github.com/repos/emberjs/ember-inspector/stargazers","contributors_url":"https://api.github.com/repos/emberjs/ember-inspector/contributors","subscribers_url":"https://api.github.com/repos/emberjs/ember-inspector/subscribers","subscription_url":"https://api.github.com/repos/emberjs/ember-inspector/subscription","commits_url":"https://api.github.com/repos/emberjs/ember-inspector/commits{/sha}","git_commits_url":"https://api.github.com/repos/emberjs/ember-inspector/git/commits{/sha}","comments_url":"https://api.github.com/repos/emberjs/ember-inspector/comments{/number}","issue_comment_url":"https://api.github.com/repos/emberjs/ember-inspector/issues/comments/{number}","contents_url":"https://api.github.com/repos/emberjs/ember-inspector/contents/{+path}","compare_url":"https://api.github.com/repos/emberjs/ember-inspector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emberjs/ember-inspector/merges","archive_url":"https://api.github.com/repos/emberjs/ember-inspector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emberjs/ember-inspector/downloads","issues_url":"https://api.github.com/repos/emberjs/ember-inspector/issues{/number}","pulls_url":"https://api.github.com/repos/emberjs/ember-inspector/pulls{/number}","milestones_url":"https://api.github.com/repos/emberjs/ember-inspector/milestones{/number}","notifications_url":"https://api.github.com/repos/emberjs/ember-inspector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emberjs/ember-inspector/labels{/name}","releases_url":"https://api.github.com/repos/emberjs/ember-inspector/releases{/id}","created_at":"2013-01-28T18:36:15Z","updated_at":"2014-08-11T09:39:23Z","pushed_at":"2014-08-11T14:47:21Z","git_url":"git://github.com/emberjs/ember-inspector.git","ssh_url":"git@github.com:emberjs/ember-inspector.git","clone_url":"https://github.com/emberjs/ember-inspector.git","svn_url":"https://github.com/emberjs/ember-inspector","homepage":null,"size":4975,"stargazers_count":524,"watchers_count":524,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":92,"mirror_url":null,"open_issues_count":53,"forks":92,"open_issues":53,"watchers":524,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emberjs/ember-inspector/pulls/190"},"html":{"href":"https://github.com/emberjs/ember-inspector/pull/190"},"issue":{"href":"https://api.github.com/repos/emberjs/ember-inspector/issues/190"},"comments":{"href":"https://api.github.com/repos/emberjs/ember-inspector/issues/190/comments"},"review_comments":{"href":"https://api.github.com/repos/emberjs/ember-inspector/pulls/190/comments"},"review_comment":{"href":"https://api.github.com/repos/emberjs/ember-inspector/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/emberjs/ember-inspector/pulls/190/commits"},"statuses":{"href":"https://api.github.com/repos/emberjs/ember-inspector/statuses/569fdedf05f8da69fe498a81dd2cb69a46e82794"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"teddyzeenny","id":1061742,"avatar_url":"https://avatars.githubusercontent.com/u/1061742?v=2","gravatar_id":"fcff4ff31a2f4380c73b257492c8b796","url":"https://api.github.com/users/teddyzeenny","html_url":"https://github.com/teddyzeenny","followers_url":"https://api.github.com/users/teddyzeenny/followers","following_url":"https://api.github.com/users/teddyzeenny/following{/other_user}","gists_url":"https://api.github.com/users/teddyzeenny/gists{/gist_id}","starred_url":"https://api.github.com/users/teddyzeenny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teddyzeenny/subscriptions","organizations_url":"https://api.github.com/users/teddyzeenny/orgs","repos_url":"https://api.github.com/users/teddyzeenny/repos","events_url":"https://api.github.com/users/teddyzeenny/events{/privacy}","received_events_url":"https://api.github.com/users/teddyzeenny/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":5,"additions":268,"deletions":12,"changed_files":15}}