GitHub PushEvent at 2014-07-30 13:20:26
Repository: rails
Actor: robin850
Payload: {"shas":[["c420a8daf58cc1544a89ec1cec67005e1c654ad8","13e82764a467b5d5f160e9fd355c1a921fabb534@vinsol.com","Move to_param to to_query, also Improve tests","Akshay Vishnoi",true],["368525a5a5b43a2955d063c2f81af5d6ed1c2188","a97c4d522bbf25700c868f6869652a8e7e938a5c@gmail.com","Remove finishing? method from transaction.\n\nThe finishing variable on the transaction object was a work-around for\nthe savepoint name, so after a rollback/commit the savepoint could be\nreleased with the previous name.\n\nrelated:\n9296e6939bcc786149a07dac334267c4035b623a\n60c88e64e26682a954f7c8cd6669d409ffffcc8b","Arthur Neves",true],["75f3584d9b87097377b312d35bd124686723ce4a","77544cb4d450f4c37e30115c8ae45f943c1f515e@calebthompson.io","Extract iterator method in AR::SchemaDumper\n\nGems which wish to tie into ActiveRecord::SchemaDumper need to\nduplicate this logic currently. [Foreigner] is one such example, as is a\nlibrary I'm currently working on but which hasn't been released yet:\n\n    def tables_with_foreign_keys(stream)\n      tables_without_foreign_keys(stream)\n      @connection.tables.sort.each do |table|\n        next if ['schema_migrations', ignore_tables].flatten.any? do |ignored|\n          case ignored\n          when String; table == ignored\n          when Regexp; table =~ ignored\n          else\n            raise StandardError, 'ActiveRecord::SchemaDumper.ignore_tables accepts an array of String and / or Regexp values.'\n          end\n        end\n        foreign_keys(table, stream)\n      end\n    end\n\n[Foreigner]: https://github.com/matthuhiggins/foreigner/blob/master/lib/foreigner/schema_dumper.rb#L36-L43\n\nExtract the skip logic to a method, making it much simpler to follow\nthis same behavior in gems that are tying into the migration flow and\nlet them dump only tables that aren't skipped without copying this block\nof code. The above code could then be simplified to:\n\n    def tables_with_foreign_keys(stream)\n      tables_without_foreign_keys(stream)\n      @connection.tables.sort.each do |table|\n        foreign_keys(table, stream) unless ignored?(table)\n      end\n    end\n\nIt also, in my opinion, simplifies the logic on ActiveRecord's side, and\nclarifies the intent of the skip logic.","Caleb Thompson",true],["f6a52f1e9d28d2cf78ed03ab029e2c6692e4045f","a4b8dcaefca5310511dfb499648611ae7c8f1d79@gmail.com","add comment to the empty each method for not removing it in future","Rajarshi Das",true],["dce49f83c806cf884a302b45bb69ebe1b62ad95b","e8c2f7a8c2089798ed47e93254ff2b0473486f80@gmail.com","Fix protect_from_forgery docs","David Albert",true],["69133a4e00fe47210cac67c23bbd650b339dff25","5282eb8a112e0c62fe591e7e5c0a8d029936dc09@gmail.com","Merge pull request #16282 from davidbalbert/patch-1\n\nFix protect_from_forgery docs [ci-skip]","Guillermo Iguaran",true],["2ee8419813b643f92344097d1c8460f045967480","11c923b8ce45cfcf39b516a4f8be1180e8c2e6bc@gmail.com","No verbose backtrace by db:drop when database does not exist.","Kenn Ejima",true],["bd54e1956b939feb605d1f6c05d3e01943933c08","7a0559213618bb59f33e95efd260811728549345@gmail.com","[ci skip] Fix documentation for @macro and reflection types\n\nSince `@macro` doesn't exist anymore and these reflections are no\nlonger AssociationReflections but their own types of reflections\nbased on macro I updated the documentation to match the changes I\nmade in #16089 and #16198. An `AssociationReflection` that had a\n`@macro` of `:has_many` now is a `HasManyReflection`","eileencodes",true],["d94a0fe6b849d3424200eaa74f1b23eef9668fa3","4a0b5627e274e02ac964c745bb385e0b385a088e@gmail.com","Merge pull request #16315 from eileencodes/fix-documentation-that-mentions-macro-instance-var\n\nFix documentation for `@macro` and reflection types","Jeremy Kemper",true],["524f7b494a758f554d899f11bcbc9827cec6d963","cbb19df9741887afec8e7f891463d0a4f9df82fc@gmail.com","Fix example code of `EachValidator` [ci skip]\n\nWe have to specify the `:title` option to really use the\n`TitleValidator` defined above.","Chun-wei Kuo",true],["362cbabf3f623401fc5ef9c0078d77983907f0af","63b51a7b3ff1fafca81cda6f7ce2446b69bc82b3@gmail.com","Merge pull request #16319 from Domon/fix-each-validator-example\n\nFix example code of EachValidator [ci skip]","Yves Senn",true],["be58912c84ee5130ebb49d55bb59b63a2432d896","40b5630f388a3684366d5349ed7e314f6fdc0682@gmail.com","Add where condition so select_one returns the correct record.","Zuhao Wan",true],["473819985a3c2ae54386fc8149e72c2b1a23a887","63b51a7b3ff1fafca81cda6f7ce2446b69bc82b3@gmail.com","Merge pull request #16318 from zuhao/refactor_activerecord_adapter_test\n\nmake `adapter_test` run order independently.","Yves Senn",true],["7bd0af42d6f8541a8247a89e07396c2da159d85d","84c66fc058fe65d1bb08ca33b21bfe0fa5cb8f17@gmail.com","Merge pull request #16295 from kenn/no_stacktrace_drop_task\n\nNo verbose backtrace by db:drop when database does not exist.","Rafael Mendonça França",true],["64e2e81bf924f865c217d2949ceaead62bbaf4e9","84c66fc058fe65d1bb08ca33b21bfe0fa5cb8f17@gmail.com","Merge pull request #16297 from calebthompson/extract-iterator-method\n\nExtract iterator method in AR::SchemaDumper","Rafael Mendonça França",true],["9fb2fdc91370c3b5d3be93feef9fc5598a770028","9674602d7d5bf861516bf0509e5ca9a98acd3ec2@gmail.com","Added nodoc to change_table","Tom Kadwill",true],["171818c60ca2492a1d92feed3bfacd8d9523fc9a","63b51a7b3ff1fafca81cda6f7ce2446b69bc82b3@gmail.com","Merge pull request #16303 from rajcybage/removing_master\n\nremove empty unused method","Yves Senn",true],["a09f0257580c240fc91347d60725cc5ac0d908c7","63b51a7b3ff1fafca81cda6f7ce2446b69bc82b3@gmail.com","docs, clarify attribute query methods on numeric columns. Closes #16246.\n\n[ci skip]","Yves Senn",true],["4e116c56a84bd995c6f9524a84b9227b5d32a09a","84c66fc058fe65d1bb08ca33b21bfe0fa5cb8f17@gmail.com","Fix typo and remove code block since present is not a method.","Rafael Mendonça França",true],["97bb76dc288d998a684b17a09d79708e2e4b584a","a97c4d522bbf25700c868f6869652a8e7e938a5c@gmail.com","Transactions refactoring\n\nAdd a transaction manager per connection, so it can controls the\nconnection responsibilities.\n\nDelegate transaction methods to transaction_manager","Arthur Neves",true]],"size":47,"ref":"refs/heads/rbx-safe-constantize","head":"8e8118e6ff69d63ca85c527b3cdba7071a663d0c"}