GitHub PullRequestReviewCommentEvent at 2014-08-10 08:35:58
Repository: souper
Actor: pcc
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/google/souper/pulls/comments/16030246","id":16030246,"diff_hunk":"@@ -0,0 +1,15 @@\n+; REQUIRES: solver\n+\n+; RUN: llvm-as -o %t %s\n+; RUN: %souper %solver -check %t\n+\n+define i32 @foo(i32 %a, i32 %b) #0 {\n+entry:\n+  %sub = sub nuw i32 0, %a\n+  %sub1 = sub nuw i32 %sub, %b\n+  %cmp = icmp sle i32 %sub1, 0, !expected !1","path":"test/Solver/sub.ll","position":10,"original_position":10,"commit_id":"37c7c0d5523bfc42d51bccc9aadf8488281fddae","original_commit_id":"37c7c0d5523bfc42d51bccc9aadf8488281fddae","user":{"login":"pcc","id":425024,"avatar_url":"https://avatars.githubusercontent.com/u/425024?v=2","gravatar_id":"77dd5d8abf56481edd062b2c2aadc6df","url":"https://api.github.com/users/pcc","html_url":"https://github.com/pcc","followers_url":"https://api.github.com/users/pcc/followers","following_url":"https://api.github.com/users/pcc/following{/other_user}","gists_url":"https://api.github.com/users/pcc/gists{/gist_id}","starred_url":"https://api.github.com/users/pcc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcc/subscriptions","organizations_url":"https://api.github.com/users/pcc/orgs","repos_url":"https://api.github.com/users/pcc/repos","events_url":"https://api.github.com/users/pcc/events{/privacy}","received_events_url":"https://api.github.com/users/pcc/received_events","type":"User","site_admin":false},"body":"I think you can write a stronger test here. The only permitted value of ```%sub``` and hence of ```%sub1``` is zero, so you can simply test that  ```icmp eq %sub1, 0``` simplifies to 1.","created_at":"2014-08-10T08:35:58Z","updated_at":"2014-08-10T08:35:58Z","html_url":"https://github.com/google/souper/pull/32#discussion_r16030246","pull_request_url":"https://api.github.com/repos/google/souper/pulls/32","_links":{"self":{"href":"https://api.github.com/repos/google/souper/pulls/comments/16030246"},"html":{"href":"https://github.com/google/souper/pull/32#discussion_r16030246"},"pull_request":{"href":"https://api.github.com/repos/google/souper/pulls/32"}}},"pull_request":{"url":"https://api.github.com/repos/google/souper/pulls/32","id":19571596,"html_url":"https://github.com/google/souper/pull/32","diff_url":"https://github.com/google/souper/pull/32.diff","patch_url":"https://github.com/google/souper/pull/32.patch","issue_url":"https://api.github.com/repos/google/souper/issues/32","number":32,"state":"open","title":"Added instructions to teach souper about undefined behavior and also add...","user":{"login":"jubitaneja","id":6600596,"avatar_url":"https://avatars.githubusercontent.com/u/6600596?v=2","gravatar_id":"410c1944bac211e712c94df75863f704","url":"https://api.github.com/users/jubitaneja","html_url":"https://github.com/jubitaneja","followers_url":"https://api.github.com/users/jubitaneja/followers","following_url":"https://api.github.com/users/jubitaneja/following{/other_user}","gists_url":"https://api.github.com/users/jubitaneja/gists{/gist_id}","starred_url":"https://api.github.com/users/jubitaneja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jubitaneja/subscriptions","organizations_url":"https://api.github.com/users/jubitaneja/orgs","repos_url":"https://api.github.com/users/jubitaneja/repos","events_url":"https://api.github.com/users/jubitaneja/events{/privacy}","received_events_url":"https://api.github.com/users/jubitaneja/received_events","type":"User","site_admin":false},"body":"...ed test cases\r\n\r\n- This patch has support for all instructions UB\r\n- Test cases integrated in LIT infrastructure\r\n- Fix to set solver path via command line by John","created_at":"2014-08-10T07:40:52Z","updated_at":"2014-08-10T08:35:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f33d0275d95e69949104aea3c05d2e70001e03c5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/google/souper/pulls/32/commits","review_comments_url":"https://api.github.com/repos/google/souper/pulls/32/comments","review_comment_url":"https://api.github.com/repos/google/souper/pulls/comments/{number}","comments_url":"https://api.github.com/repos/google/souper/issues/32/comments","statuses_url":"https://api.github.com/repos/google/souper/statuses/37c7c0d5523bfc42d51bccc9aadf8488281fddae","head":{"label":"jubitaneja:undefined_behavior","ref":"undefined_behavior","sha":"37c7c0d5523bfc42d51bccc9aadf8488281fddae","user":{"login":"jubitaneja","id":6600596,"avatar_url":"https://avatars.githubusercontent.com/u/6600596?v=2","gravatar_id":"410c1944bac211e712c94df75863f704","url":"https://api.github.com/users/jubitaneja","html_url":"https://github.com/jubitaneja","followers_url":"https://api.github.com/users/jubitaneja/followers","following_url":"https://api.github.com/users/jubitaneja/following{/other_user}","gists_url":"https://api.github.com/users/jubitaneja/gists{/gist_id}","starred_url":"https://api.github.com/users/jubitaneja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jubitaneja/subscriptions","organizations_url":"https://api.github.com/users/jubitaneja/orgs","repos_url":"https://api.github.com/users/jubitaneja/repos","events_url":"https://api.github.com/users/jubitaneja/events{/privacy}","received_events_url":"https://api.github.com/users/jubitaneja/received_events","type":"User","site_admin":false},"repo":{"id":20009831,"name":"souper","full_name":"jubitaneja/souper","owner":{"login":"jubitaneja","id":6600596,"avatar_url":"https://avatars.githubusercontent.com/u/6600596?v=2","gravatar_id":"410c1944bac211e712c94df75863f704","url":"https://api.github.com/users/jubitaneja","html_url":"https://github.com/jubitaneja","followers_url":"https://api.github.com/users/jubitaneja/followers","following_url":"https://api.github.com/users/jubitaneja/following{/other_user}","gists_url":"https://api.github.com/users/jubitaneja/gists{/gist_id}","starred_url":"https://api.github.com/users/jubitaneja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jubitaneja/subscriptions","organizations_url":"https://api.github.com/users/jubitaneja/orgs","repos_url":"https://api.github.com/users/jubitaneja/repos","events_url":"https://api.github.com/users/jubitaneja/events{/privacy}","received_events_url":"https://api.github.com/users/jubitaneja/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jubitaneja/souper","description":"Add more functionality in souper ","fork":true,"url":"https://api.github.com/repos/jubitaneja/souper","forks_url":"https://api.github.com/repos/jubitaneja/souper/forks","keys_url":"https://api.github.com/repos/jubitaneja/souper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jubitaneja/souper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jubitaneja/souper/teams","hooks_url":"https://api.github.com/repos/jubitaneja/souper/hooks","issue_events_url":"https://api.github.com/repos/jubitaneja/souper/issues/events{/number}","events_url":"https://api.github.com/repos/jubitaneja/souper/events","assignees_url":"https://api.github.com/repos/jubitaneja/souper/assignees{/user}","branches_url":"https://api.github.com/repos/jubitaneja/souper/branches{/branch}","tags_url":"https://api.github.com/repos/jubitaneja/souper/tags","blobs_url":"https://api.github.com/repos/jubitaneja/souper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jubitaneja/souper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jubitaneja/souper/git/refs{/sha}","trees_url":"https://api.github.com/repos/jubitaneja/souper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jubitaneja/souper/statuses/{sha}","languages_url":"https://api.github.com/repos/jubitaneja/souper/languages","stargazers_url":"https://api.github.com/repos/jubitaneja/souper/stargazers","contributors_url":"https://api.github.com/repos/jubitaneja/souper/contributors","subscribers_url":"https://api.github.com/repos/jubitaneja/souper/subscribers","subscription_url":"https://api.github.com/repos/jubitaneja/souper/subscription","commits_url":"https://api.github.com/repos/jubitaneja/souper/commits{/sha}","git_commits_url":"https://api.github.com/repos/jubitaneja/souper/git/commits{/sha}","comments_url":"https://api.github.com/repos/jubitaneja/souper/comments{/number}","issue_comment_url":"https://api.github.com/repos/jubitaneja/souper/issues/comments/{number}","contents_url":"https://api.github.com/repos/jubitaneja/souper/contents/{+path}","compare_url":"https://api.github.com/repos/jubitaneja/souper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jubitaneja/souper/merges","archive_url":"https://api.github.com/repos/jubitaneja/souper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jubitaneja/souper/downloads","issues_url":"https://api.github.com/repos/jubitaneja/souper/issues{/number}","pulls_url":"https://api.github.com/repos/jubitaneja/souper/pulls{/number}","milestones_url":"https://api.github.com/repos/jubitaneja/souper/milestones{/number}","notifications_url":"https://api.github.com/repos/jubitaneja/souper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jubitaneja/souper/labels{/name}","releases_url":"https://api.github.com/repos/jubitaneja/souper/releases{/id}","created_at":"2014-05-21T06:06:54Z","updated_at":"2014-07-03T01:39:06Z","pushed_at":"2014-08-10T07:33:39Z","git_url":"git://github.com/jubitaneja/souper.git","ssh_url":"git@github.com:jubitaneja/souper.git","clone_url":"https://github.com/jubitaneja/souper.git","svn_url":"https://github.com/jubitaneja/souper","homepage":"","size":914,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"4e31fefc4379ebfee5789858c589e5dd6be8a50b","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=2","gravatar_id":"24ba30616d2a20673f54c2aee36d159e","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":18458047,"name":"souper","full_name":"google/souper","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=2","gravatar_id":"24ba30616d2a20673f54c2aee36d159e","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/souper","description":null,"fork":false,"url":"https://api.github.com/repos/google/souper","forks_url":"https://api.github.com/repos/google/souper/forks","keys_url":"https://api.github.com/repos/google/souper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/souper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/souper/teams","hooks_url":"https://api.github.com/repos/google/souper/hooks","issue_events_url":"https://api.github.com/repos/google/souper/issues/events{/number}","events_url":"https://api.github.com/repos/google/souper/events","assignees_url":"https://api.github.com/repos/google/souper/assignees{/user}","branches_url":"https://api.github.com/repos/google/souper/branches{/branch}","tags_url":"https://api.github.com/repos/google/souper/tags","blobs_url":"https://api.github.com/repos/google/souper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/souper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/souper/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/souper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/souper/statuses/{sha}","languages_url":"https://api.github.com/repos/google/souper/languages","stargazers_url":"https://api.github.com/repos/google/souper/stargazers","contributors_url":"https://api.github.com/repos/google/souper/contributors","subscribers_url":"https://api.github.com/repos/google/souper/subscribers","subscription_url":"https://api.github.com/repos/google/souper/subscription","commits_url":"https://api.github.com/repos/google/souper/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/souper/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/souper/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/souper/issues/comments/{number}","contents_url":"https://api.github.com/repos/google/souper/contents/{+path}","compare_url":"https://api.github.com/repos/google/souper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/souper/merges","archive_url":"https://api.github.com/repos/google/souper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/souper/downloads","issues_url":"https://api.github.com/repos/google/souper/issues{/number}","pulls_url":"https://api.github.com/repos/google/souper/pulls{/number}","milestones_url":"https://api.github.com/repos/google/souper/milestones{/number}","notifications_url":"https://api.github.com/repos/google/souper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/souper/labels{/name}","releases_url":"https://api.github.com/repos/google/souper/releases{/id}","created_at":"2014-04-05T02:09:09Z","updated_at":"2014-08-08T16:13:52Z","pushed_at":"2014-08-08T08:14:26Z","git_url":"git://github.com/google/souper.git","ssh_url":"git@github.com:google/souper.git","clone_url":"https://github.com/google/souper.git","svn_url":"https://github.com/google/souper","homepage":null,"size":1043,"stargazers_count":73,"watchers_count":73,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":10,"mirror_url":null,"open_issues_count":5,"forks":10,"open_issues":5,"watchers":73,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/souper/pulls/32"},"html":{"href":"https://github.com/google/souper/pull/32"},"issue":{"href":"https://api.github.com/repos/google/souper/issues/32"},"comments":{"href":"https://api.github.com/repos/google/souper/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/google/souper/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/google/souper/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/google/souper/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/google/souper/statuses/37c7c0d5523bfc42d51bccc9aadf8488281fddae"}}}}