GitHub PullRequestEvent at 2014-08-04 10:53:08
Repository: sqlalchemy-defaults
Actor: kvesteri
Payload: {"action":"closed","number":5,"pull_request":{"url":"https://api.github.com/repos/kvesteri/sqlalchemy-defaults/pulls/5","id":18965755,"html_url":"https://github.com/kvesteri/sqlalchemy-defaults/pull/5","diff_url":"https://github.com/kvesteri/sqlalchemy-defaults/pull/5.diff","patch_url":"https://github.com/kvesteri/sqlalchemy-defaults/pull/5.patch","issue_url":"https://api.github.com/repos/kvesteri/sqlalchemy-defaults/issues/5","number":5,"state":"closed","title":"AttributeError: 'Sequence' object has no attribute 'arg'","user":{"login":"mkai","id":322750,"avatar_url":"https://avatars.githubusercontent.com/u/322750?v=1","gravatar_id":"bfa143bd7ab6a6a6dcdac9d9edefee52","url":"https://api.github.com/users/mkai","html_url":"https://github.com/mkai","followers_url":"https://api.github.com/users/mkai/followers","following_url":"https://api.github.com/users/mkai/following{/other_user}","gists_url":"https://api.github.com/users/mkai/gists{/gist_id}","starred_url":"https://api.github.com/users/mkai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkai/subscriptions","organizations_url":"https://api.github.com/users/mkai/orgs","repos_url":"https://api.github.com/users/mkai/repos","events_url":"https://api.github.com/users/mkai/events{/privacy}","received_events_url":"https://api.github.com/users/mkai/received_events","type":"User","site_admin":false},"body":"Hi, thanks for the library!\r\nI just started integrating it and had the above error with the Oracle dialect after passing in a ``Sequence`` object for ``default``.\r\n\r\nHowever, I need to pass in a sequence to simulate an auto-incrementing ID:\r\n\r\n```python\r\nid = Column(Integer, default=Sequence('id_seq'), primary_key=True)\r\n```\r\n\r\nThis fix solves the problem by explicity checking if ``column.default`` is a``ColumnDefault`` instance.\r\n\r\nWhat do you think?","created_at":"2014-07-28T13:10:15Z","updated_at":"2014-08-04T10:53:07Z","closed_at":"2014-08-04T10:53:07Z","merged_at":null,"merge_commit_sha":"44461ff25e1d48f656f5983666eadead723aed24","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kvesteri/sqlalchemy-defaults/pulls/5/commits","review_comments_url":"https://api.github.com/repos/kvesteri/sqlalchemy-defaults/pulls/5/comments","review_comment_url":"https://api.github.com/repos/kvesteri/sqlalchemy-defaults/pulls/comments/{number}","comments_url":"https://api.github.com/repos/kvesteri/sqlalchemy-defaults/issues/5/comments","statuses_url":"https://api.github.com/repos/kvesteri/sqlalchemy-defaults/statuses/f3fccd6cd263e084ec87368c13e378768dde59e3","head":{"label":"mkai:patch-1","ref":"patch-1","sha":"f3fccd6cd263e084ec87368c13e378768dde59e3","user":{"login":"mkai","id":322750,"avatar_url":"https://avatars.githubusercontent.com/u/322750?v=1","gravatar_id":"bfa143bd7ab6a6a6dcdac9d9edefee52","url":"https://api.github.com/users/mkai","html_url":"https://github.com/mkai","followers_url":"https://api.github.com/users/mkai/followers","following_url":"https://api.github.com/users/mkai/following{/other_user}","gists_url":"https://api.github.com/users/mkai/gists{/gist_id}","starred_url":"https://api.github.com/users/mkai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkai/subscriptions","organizations_url":"https://api.github.com/users/mkai/orgs","repos_url":"https://api.github.com/users/mkai/repos","events_url":"https://api.github.com/users/mkai/events{/privacy}","received_events_url":"https://api.github.com/users/mkai/received_events","type":"User","site_admin":false},"repo":{"id":22342425,"name":"sqlalchemy-defaults","full_name":"mkai/sqlalchemy-defaults","owner":{"login":"mkai","id":322750,"avatar_url":"https://avatars.githubusercontent.com/u/322750?v=1","gravatar_id":"bfa143bd7ab6a6a6dcdac9d9edefee52","url":"https://api.github.com/users/mkai","html_url":"https://github.com/mkai","followers_url":"https://api.github.com/users/mkai/followers","following_url":"https://api.github.com/users/mkai/following{/other_user}","gists_url":"https://api.github.com/users/mkai/gists{/gist_id}","starred_url":"https://api.github.com/users/mkai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkai/subscriptions","organizations_url":"https://api.github.com/users/mkai/orgs","repos_url":"https://api.github.com/users/mkai/repos","events_url":"https://api.github.com/users/mkai/events{/privacy}","received_events_url":"https://api.github.com/users/mkai/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mkai/sqlalchemy-defaults","description":"Smart SQLAlchemy defaults for lazy guys, like me.","fork":true,"url":"https://api.github.com/repos/mkai/sqlalchemy-defaults","forks_url":"https://api.github.com/repos/mkai/sqlalchemy-defaults/forks","keys_url":"https://api.github.com/repos/mkai/sqlalchemy-defaults/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mkai/sqlalchemy-defaults/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mkai/sqlalchemy-defaults/teams","hooks_url":"https://api.github.com/repos/mkai/sqlalchemy-defaults/hooks","issue_events_url":"https://api.github.com/repos/mkai/sqlalchemy-defaults/issues/events{/number}","events_url":"https://api.github.com/repos/mkai/sqlalchemy-defaults/events","assignees_url":"https://api.github.com/repos/mkai/sqlalchemy-defaults/assignees{/user}","branches_url":"https://api.github.com/repos/mkai/sqlalchemy-defaults/branches{/branch}","tags_url":"https://api.github.com/repos/mkai/sqlalchemy-defaults/tags","blobs_url":"https://api.github.com/repos/mkai/sqlalchemy-defaults/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mkai/sqlalchemy-defaults/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mkai/sqlalchemy-defaults/git/refs{/sha}","trees_url":"https://api.github.com/repos/mkai/sqlalchemy-defaults/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mkai/sqlalchemy-defaults/statuses/{sha}","languages_url":"https://api.github.com/repos/mkai/sqlalchemy-defaults/languages","stargazers_url":"https://api.github.com/repos/mkai/sqlalchemy-defaults/stargazers","contributors_url":"https://api.github.com/repos/mkai/sqlalchemy-defaults/contributors","subscribers_url":"https://api.github.com/repos/mkai/sqlalchemy-defaults/subscribers","subscription_url":"https://api.github.com/repos/mkai/sqlalchemy-defaults/subscription","commits_url":"https://api.github.com/repos/mkai/sqlalchemy-defaults/commits{/sha}","git_commits_url":"https://api.github.com/repos/mkai/sqlalchemy-defaults/git/commits{/sha}","comments_url":"https://api.github.com/repos/mkai/sqlalchemy-defaults/comments{/number}","issue_comment_url":"https://api.github.com/repos/mkai/sqlalchemy-defaults/issues/comments/{number}","contents_url":"https://api.github.com/repos/mkai/sqlalchemy-defaults/contents/{+path}","compare_url":"https://api.github.com/repos/mkai/sqlalchemy-defaults/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mkai/sqlalchemy-defaults/merges","archive_url":"https://api.github.com/repos/mkai/sqlalchemy-defaults/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mkai/sqlalchemy-defaults/downloads","issues_url":"https://api.github.com/repos/mkai/sqlalchemy-defaults/issues{/number}","pulls_url":"https://api.github.com/repos/mkai/sqlalchemy-defaults/pulls{/number}","milestones_url":"https://api.github.com/repos/mkai/sqlalchemy-defaults/milestones{/number}","notifications_url":"https://api.github.com/repos/mkai/sqlalchemy-defaults/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mkai/sqlalchemy-defaults/labels{/name}","releases_url":"https://api.github.com/repos/mkai/sqlalchemy-defaults/releases{/id}","created_at":"2014-07-28T12:57:16Z","updated_at":"2014-07-28T13:09:16Z","pushed_at":"2014-07-28T13:09:16Z","git_url":"git://github.com/mkai/sqlalchemy-defaults.git","ssh_url":"git@github.com:mkai/sqlalchemy-defaults.git","clone_url":"https://github.com/mkai/sqlalchemy-defaults.git","svn_url":"https://github.com/mkai/sqlalchemy-defaults","homepage":null,"size":152,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kvesteri:master","ref":"master","sha":"6ea96b767c3c3ad24532fc24b400c75dae3ed46e","user":{"login":"kvesteri","id":398714,"avatar_url":"https://avatars.githubusercontent.com/u/398714?v=1","gravatar_id":"99728f260f7455fa2effb00b72ced6bc","url":"https://api.github.com/users/kvesteri","html_url":"https://github.com/kvesteri","followers_url":"https://api.github.com/users/kvesteri/followers","following_url":"https://api.github.com/users/kvesteri/following{/other_user}","gists_url":"https://api.github.com/users/kvesteri/gists{/gist_id}","starred_url":"https://api.github.com/users/kvesteri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kvesteri/subscriptions","organizations_url":"https://api.github.com/users/kvesteri/orgs","repos_url":"https://api.github.com/users/kvesteri/repos","events_url":"https://api.github.com/users/kvesteri/events{/privacy}","received_events_url":"https://api.github.com/users/kvesteri/received_events","type":"User","site_admin":false},"repo":{"id":7753602,"name":"sqlalchemy-defaults","full_name":"kvesteri/sqlalchemy-defaults","owner":{"login":"kvesteri","id":398714,"avatar_url":"https://avatars.githubusercontent.com/u/398714?v=1","gravatar_id":"99728f260f7455fa2effb00b72ced6bc","url":"https://api.github.com/users/kvesteri","html_url":"https://github.com/kvesteri","followers_url":"https://api.github.com/users/kvesteri/followers","following_url":"https://api.github.com/users/kvesteri/following{/other_user}","gists_url":"https://api.github.com/users/kvesteri/gists{/gist_id}","starred_url":"https://api.github.com/users/kvesteri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kvesteri/subscriptions","organizations_url":"https://api.github.com/users/kvesteri/orgs","repos_url":"https://api.github.com/users/kvesteri/repos","events_url":"https://api.github.com/users/kvesteri/events{/privacy}","received_events_url":"https://api.github.com/users/kvesteri/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kvesteri/sqlalchemy-defaults","description":"Smart SQLAlchemy defaults for lazy guys, like me.","fork":false,"url":"https://api.github.com/repos/kvesteri/sqlalchemy-defaults","forks_url":"https://api.github.com/repos/kvesteri/sqlalchemy-defaults/forks","keys_url":"https://api.github.com/repos/kvesteri/sqlalchemy-defaults/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kvesteri/sqlalchemy-defaults/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kvesteri/sqlalchemy-defaults/teams","hooks_url":"https://api.github.com/repos/kvesteri/sqlalchemy-defaults/hooks","issue_events_url":"https://api.github.com/repos/kvesteri/sqlalchemy-defaults/issues/events{/number}","events_url":"https://api.github.com/repos/kvesteri/sqlalchemy-defaults/events","assignees_url":"https://api.github.com/repos/kvesteri/sqlalchemy-defaults/assignees{/user}","branches_url":"https://api.github.com/repos/kvesteri/sqlalchemy-defaults/branches{/branch}","tags_url":"https://api.github.com/repos/kvesteri/sqlalchemy-defaults/tags","blobs_url":"https://api.github.com/repos/kvesteri/sqlalchemy-defaults/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kvesteri/sqlalchemy-defaults/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kvesteri/sqlalchemy-defaults/git/refs{/sha}","trees_url":"https://api.github.com/repos/kvesteri/sqlalchemy-defaults/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kvesteri/sqlalchemy-defaults/statuses/{sha}","languages_url":"https://api.github.com/repos/kvesteri/sqlalchemy-defaults/languages","stargazers_url":"https://api.github.com/repos/kvesteri/sqlalchemy-defaults/stargazers","contributors_url":"https://api.github.com/repos/kvesteri/sqlalchemy-defaults/contributors","subscribers_url":"https://api.github.com/repos/kvesteri/sqlalchemy-defaults/subscribers","subscription_url":"https://api.github.com/repos/kvesteri/sqlalchemy-defaults/subscription","commits_url":"https://api.github.com/repos/kvesteri/sqlalchemy-defaults/commits{/sha}","git_commits_url":"https://api.github.com/repos/kvesteri/sqlalchemy-defaults/git/commits{/sha}","comments_url":"https://api.github.com/repos/kvesteri/sqlalchemy-defaults/comments{/number}","issue_comment_url":"https://api.github.com/repos/kvesteri/sqlalchemy-defaults/issues/comments/{number}","contents_url":"https://api.github.com/repos/kvesteri/sqlalchemy-defaults/contents/{+path}","compare_url":"https://api.github.com/repos/kvesteri/sqlalchemy-defaults/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kvesteri/sqlalchemy-defaults/merges","archive_url":"https://api.github.com/repos/kvesteri/sqlalchemy-defaults/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kvesteri/sqlalchemy-defaults/downloads","issues_url":"https://api.github.com/repos/kvesteri/sqlalchemy-defaults/issues{/number}","pulls_url":"https://api.github.com/repos/kvesteri/sqlalchemy-defaults/pulls{/number}","milestones_url":"https://api.github.com/repos/kvesteri/sqlalchemy-defaults/milestones{/number}","notifications_url":"https://api.github.com/repos/kvesteri/sqlalchemy-defaults/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kvesteri/sqlalchemy-defaults/labels{/name}","releases_url":"https://api.github.com/repos/kvesteri/sqlalchemy-defaults/releases{/id}","created_at":"2013-01-22T14:18:28Z","updated_at":"2014-08-04T10:53:07Z","pushed_at":"2014-08-04T10:53:07Z","git_url":"git://github.com/kvesteri/sqlalchemy-defaults.git","ssh_url":"git@github.com:kvesteri/sqlalchemy-defaults.git","clone_url":"https://github.com/kvesteri/sqlalchemy-defaults.git","svn_url":"https://github.com/kvesteri/sqlalchemy-defaults","homepage":null,"size":354,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":5,"mirror_url":null,"open_issues_count":1,"forks":5,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kvesteri/sqlalchemy-defaults/pulls/5"},"html":{"href":"https://github.com/kvesteri/sqlalchemy-defaults/pull/5"},"issue":{"href":"https://api.github.com/repos/kvesteri/sqlalchemy-defaults/issues/5"},"comments":{"href":"https://api.github.com/repos/kvesteri/sqlalchemy-defaults/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/kvesteri/sqlalchemy-defaults/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/kvesteri/sqlalchemy-defaults/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/kvesteri/sqlalchemy-defaults/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/kvesteri/sqlalchemy-defaults/statuses/f3fccd6cd263e084ec87368c13e378768dde59e3"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":2,"review_comments":0,"commits":1,"additions":3,"deletions":2,"changed_files":1}}