GitHub PullRequestReviewCommentEvent at 2014-07-15 16:15:15
Repository: FOSHttpCacheBundle
Actor: stof
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/pulls/comments/14945654","id":14945654,"diff_hunk":"@@ -66,9 +66,29 @@ The options are the same as for Varnish with the addition of the\n     default client. You can set the default with\n     ``fos_http_client.proxy_client.default: nginx`` (resp. ``varnish``).\n \n+Custom Guzzle Client\n+--------------------\n+\n+By default, the proxy client instantiates a Guzzle_ object to talk with the\n+caching proxy. If you need to customize the requests, for example to send a\n+basic authentication header, you can configure a service and specify that in\n+the ``guzzle_client`` option. A sample service definition for using basic\n+authentication looks like this:\n+\n+.. code-block:: yaml\n+\n+    acme.varnish.guzzle.client:\n+        class: Guzzle\\Service\\Client\n+        tags:\n+            - guzzle.client\n+        calls:\n+            - [setDefaultOption, [auth, [%varnish.username%, %varnish.password%, basic ]]]\n+\n Caching Proxy Configuration\n ---------------------------\n \n You need to configure your caching proxy (Varnish or Nginx) to work with this\n bundle. Please refer to the :ref:`FOSHttpCache library’s documentation <foshttpcache:proxy-configuration>`\n for more information.\n+\n+.. _Guzzle: http://guzzle.readthedocs.org/","path":"Resources/doc/configuration/proxy-client.rst","position":29,"original_position":29,"commit_id":"04d273a8c7314d63db68d48f820080eb9ab0dc32","original_commit_id":"04d273a8c7314d63db68d48f820080eb9ab0dc32","user":{"login":"stof","id":439401,"avatar_url":"https://avatars.githubusercontent.com/u/439401?","gravatar_id":"7894bbdf1c05b18a1444ad8c76c9d583","url":"https://api.github.com/users/stof","html_url":"https://github.com/stof","followers_url":"https://api.github.com/users/stof/followers","following_url":"https://api.github.com/users/stof/following{/other_user}","gists_url":"https://api.github.com/users/stof/gists{/gist_id}","starred_url":"https://api.github.com/users/stof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stof/subscriptions","organizations_url":"https://api.github.com/users/stof/orgs","repos_url":"https://api.github.com/users/stof/repos","events_url":"https://api.github.com/users/stof/events{/privacy}","received_events_url":"https://api.github.com/users/stof/received_events","type":"User","site_admin":false},"body":"This is the wrong link. FOSHttpCache relies on Guzzle3, and these are the Guzzle4 docs. the right link is http://guzzle3.readthedocs.org/","created_at":"2014-07-15T16:15:15Z","updated_at":"2014-07-15T16:15:15Z","html_url":"https://github.com/FriendsOfSymfony/FOSHttpCacheBundle/pull/106#discussion_r14945654","pull_request_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/pulls/106","_links":{"self":{"href":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/pulls/comments/14945654"},"html":{"href":"https://github.com/FriendsOfSymfony/FOSHttpCacheBundle/pull/106#discussion_r14945654"},"pull_request":{"href":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/pulls/106"}}},"pull_request":{"url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/pulls/106","id":18417859,"html_url":"https://github.com/FriendsOfSymfony/FOSHttpCacheBundle/pull/106","diff_url":"https://github.com/FriendsOfSymfony/FOSHttpCacheBundle/pull/106.diff","patch_url":"https://github.com/FriendsOfSymfony/FOSHttpCacheBundle/pull/106.patch","issue_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/issues/106","number":106,"state":"open","title":"allow to configure a custom guzzle client for cache proxy requests","user":{"login":"dbu","id":76576,"avatar_url":"https://avatars.githubusercontent.com/u/76576?","gravatar_id":"c9f4f8ce2c2936bacaf49500b5a127dc","url":"https://api.github.com/users/dbu","html_url":"https://github.com/dbu","followers_url":"https://api.github.com/users/dbu/followers","following_url":"https://api.github.com/users/dbu/following{/other_user}","gists_url":"https://api.github.com/users/dbu/gists{/gist_id}","starred_url":"https://api.github.com/users/dbu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbu/subscriptions","organizations_url":"https://api.github.com/users/dbu/orgs","repos_url":"https://api.github.com/users/dbu/repos","events_url":"https://api.github.com/users/dbu/events{/privacy}","received_events_url":"https://api.github.com/users/dbu/received_events","type":"User","site_admin":false},"body":"the LiipCacheControlBundle had an option for any custom curl headers. this seems the simplest solution to get the possibilities back without overcomplicating things. people will have to set up their own guzzle service though.","created_at":"2014-07-15T16:11:05Z","updated_at":"2014-07-15T16:15:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"07b596640af333469ff3929c82dcfe69ee1f1085","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/pulls/106/commits","review_comments_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/pulls/106/comments","review_comment_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/pulls/comments/{number}","comments_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/issues/106/comments","statuses_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/statuses/04d273a8c7314d63db68d48f820080eb9ab0dc32","head":{"label":"FriendsOfSymfony:custom-guzzle","ref":"custom-guzzle","sha":"04d273a8c7314d63db68d48f820080eb9ab0dc32","user":{"login":"FriendsOfSymfony","id":529709,"avatar_url":"https://avatars.githubusercontent.com/u/529709?","gravatar_id":"eedcf60e1fa2ae2d70a06b23c1cca44a","url":"https://api.github.com/users/FriendsOfSymfony","html_url":"https://github.com/FriendsOfSymfony","followers_url":"https://api.github.com/users/FriendsOfSymfony/followers","following_url":"https://api.github.com/users/FriendsOfSymfony/following{/other_user}","gists_url":"https://api.github.com/users/FriendsOfSymfony/gists{/gist_id}","starred_url":"https://api.github.com/users/FriendsOfSymfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FriendsOfSymfony/subscriptions","organizations_url":"https://api.github.com/users/FriendsOfSymfony/orgs","repos_url":"https://api.github.com/users/FriendsOfSymfony/repos","events_url":"https://api.github.com/users/FriendsOfSymfony/events{/privacy}","received_events_url":"https://api.github.com/users/FriendsOfSymfony/received_events","type":"Organization","site_admin":false},"repo":{"id":15187542,"name":"FOSHttpCacheBundle","full_name":"FriendsOfSymfony/FOSHttpCacheBundle","owner":{"login":"FriendsOfSymfony","id":529709,"avatar_url":"https://avatars.githubusercontent.com/u/529709?","gravatar_id":"eedcf60e1fa2ae2d70a06b23c1cca44a","url":"https://api.github.com/users/FriendsOfSymfony","html_url":"https://github.com/FriendsOfSymfony","followers_url":"https://api.github.com/users/FriendsOfSymfony/followers","following_url":"https://api.github.com/users/FriendsOfSymfony/following{/other_user}","gists_url":"https://api.github.com/users/FriendsOfSymfony/gists{/gist_id}","starred_url":"https://api.github.com/users/FriendsOfSymfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FriendsOfSymfony/subscriptions","organizations_url":"https://api.github.com/users/FriendsOfSymfony/orgs","repos_url":"https://api.github.com/users/FriendsOfSymfony/repos","events_url":"https://api.github.com/users/FriendsOfSymfony/events{/privacy}","received_events_url":"https://api.github.com/users/FriendsOfSymfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FriendsOfSymfony/FOSHttpCacheBundle","description":"Use the FOSHttpCache library in your Symfony2 projects","fork":false,"url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle","forks_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/forks","keys_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/teams","hooks_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/hooks","issue_events_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/issues/events{/number}","events_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/events","assignees_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/assignees{/user}","branches_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/branches{/branch}","tags_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/tags","blobs_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/languages","stargazers_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/stargazers","contributors_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/contributors","subscribers_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/subscribers","subscription_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/subscription","commits_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/issues/comments/{number}","contents_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/contents/{+path}","compare_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/merges","archive_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/downloads","issues_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/issues{/number}","pulls_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/labels{/name}","releases_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/releases{/id}","created_at":"2013-12-14T15:13:42Z","updated_at":"2014-07-08T14:55:56Z","pushed_at":"2014-07-15T16:14:40Z","git_url":"git://github.com/FriendsOfSymfony/FOSHttpCacheBundle.git","ssh_url":"git@github.com:FriendsOfSymfony/FOSHttpCacheBundle.git","clone_url":"https://github.com/FriendsOfSymfony/FOSHttpCacheBundle.git","svn_url":"https://github.com/FriendsOfSymfony/FOSHttpCacheBundle","homepage":"http://foshttpcachebundle.readthedocs.org/","size":3263,"stargazers_count":46,"watchers_count":46,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":6,"mirror_url":null,"open_issues_count":15,"forks":6,"open_issues":15,"watchers":46,"default_branch":"master"}},"base":{"label":"FriendsOfSymfony:master","ref":"master","sha":"aefebb65812e6f0dda10ff6354646185f4457bfb","user":{"login":"FriendsOfSymfony","id":529709,"avatar_url":"https://avatars.githubusercontent.com/u/529709?","gravatar_id":"eedcf60e1fa2ae2d70a06b23c1cca44a","url":"https://api.github.com/users/FriendsOfSymfony","html_url":"https://github.com/FriendsOfSymfony","followers_url":"https://api.github.com/users/FriendsOfSymfony/followers","following_url":"https://api.github.com/users/FriendsOfSymfony/following{/other_user}","gists_url":"https://api.github.com/users/FriendsOfSymfony/gists{/gist_id}","starred_url":"https://api.github.com/users/FriendsOfSymfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FriendsOfSymfony/subscriptions","organizations_url":"https://api.github.com/users/FriendsOfSymfony/orgs","repos_url":"https://api.github.com/users/FriendsOfSymfony/repos","events_url":"https://api.github.com/users/FriendsOfSymfony/events{/privacy}","received_events_url":"https://api.github.com/users/FriendsOfSymfony/received_events","type":"Organization","site_admin":false},"repo":{"id":15187542,"name":"FOSHttpCacheBundle","full_name":"FriendsOfSymfony/FOSHttpCacheBundle","owner":{"login":"FriendsOfSymfony","id":529709,"avatar_url":"https://avatars.githubusercontent.com/u/529709?","gravatar_id":"eedcf60e1fa2ae2d70a06b23c1cca44a","url":"https://api.github.com/users/FriendsOfSymfony","html_url":"https://github.com/FriendsOfSymfony","followers_url":"https://api.github.com/users/FriendsOfSymfony/followers","following_url":"https://api.github.com/users/FriendsOfSymfony/following{/other_user}","gists_url":"https://api.github.com/users/FriendsOfSymfony/gists{/gist_id}","starred_url":"https://api.github.com/users/FriendsOfSymfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FriendsOfSymfony/subscriptions","organizations_url":"https://api.github.com/users/FriendsOfSymfony/orgs","repos_url":"https://api.github.com/users/FriendsOfSymfony/repos","events_url":"https://api.github.com/users/FriendsOfSymfony/events{/privacy}","received_events_url":"https://api.github.com/users/FriendsOfSymfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FriendsOfSymfony/FOSHttpCacheBundle","description":"Use the FOSHttpCache library in your Symfony2 projects","fork":false,"url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle","forks_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/forks","keys_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/teams","hooks_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/hooks","issue_events_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/issues/events{/number}","events_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/events","assignees_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/assignees{/user}","branches_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/branches{/branch}","tags_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/tags","blobs_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/languages","stargazers_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/stargazers","contributors_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/contributors","subscribers_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/subscribers","subscription_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/subscription","commits_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/issues/comments/{number}","contents_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/contents/{+path}","compare_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/merges","archive_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/downloads","issues_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/issues{/number}","pulls_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/labels{/name}","releases_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/releases{/id}","created_at":"2013-12-14T15:13:42Z","updated_at":"2014-07-08T14:55:56Z","pushed_at":"2014-07-15T16:14:40Z","git_url":"git://github.com/FriendsOfSymfony/FOSHttpCacheBundle.git","ssh_url":"git@github.com:FriendsOfSymfony/FOSHttpCacheBundle.git","clone_url":"https://github.com/FriendsOfSymfony/FOSHttpCacheBundle.git","svn_url":"https://github.com/FriendsOfSymfony/FOSHttpCacheBundle","homepage":"http://foshttpcachebundle.readthedocs.org/","size":3263,"stargazers_count":46,"watchers_count":46,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":6,"mirror_url":null,"open_issues_count":15,"forks":6,"open_issues":15,"watchers":46,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/pulls/106"},"html":{"href":"https://github.com/FriendsOfSymfony/FOSHttpCacheBundle/pull/106"},"issue":{"href":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/issues/106"},"comments":{"href":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/issues/106/comments"},"review_comments":{"href":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/pulls/106/comments"},"review_comment":{"href":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/pulls/106/commits"},"statuses":{"href":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/statuses/04d273a8c7314d63db68d48f820080eb9ab0dc32"}}}}