GitHub PullRequestReviewCommentEvent at 2014-11-25 08:08:35
Repository: buildbot
Actor: benallard
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/buildbot/buildbot/pulls/comments/20847926","id":20847926,"diff_hunk":"@@ -259,6 +259,8 @@ Changes and Removals\n \n * The name and source of a Property have to be unicode or ascii string.\n \n+* Property values must be serializable in JSON.\n+","path":"master/docs/relnotes/index.rst","position":5,"original_position":5,"commit_id":"946d60699e787d1accaee5fb3ffad714d9aabcd0","original_commit_id":"6c860ddd5a0a286c810ba33f9039f8a4c35769b1","user":{"login":"benallard","id":178188,"avatar_url":"https://avatars.githubusercontent.com/u/178188?v=3","gravatar_id":"","url":"https://api.github.com/users/benallard","html_url":"https://github.com/benallard","followers_url":"https://api.github.com/users/benallard/followers","following_url":"https://api.github.com/users/benallard/following{/other_user}","gists_url":"https://api.github.com/users/benallard/gists{/gist_id}","starred_url":"https://api.github.com/users/benallard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benallard/subscriptions","organizations_url":"https://api.github.com/users/benallard/orgs","repos_url":"https://api.github.com/users/benallard/repos","events_url":"https://api.github.com/users/benallard/events{/privacy}","received_events_url":"https://api.github.com/users/benallard/received_events","type":"User","site_admin":false},"body":"tuples are serialized (as list ...)\r\n\r\nsets are not.\r\n\r\nAnd to answer @sa2ajj's concern about a non-explicit message, the error looks like that::\r\n\r\n    TypeError: set([]) is not JSON serializable","created_at":"2014-11-25T08:08:35Z","updated_at":"2014-11-25T08:08:35Z","html_url":"https://github.com/buildbot/buildbot/pull/1385#discussion_r20847926","pull_request_url":"https://api.github.com/repos/buildbot/buildbot/pulls/1385","_links":{"self":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/comments/20847926"},"html":{"href":"https://github.com/buildbot/buildbot/pull/1385#discussion_r20847926"},"pull_request":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/1385"}}},"pull_request":{"url":"https://api.github.com/repos/buildbot/buildbot/pulls/1385","id":24949956,"html_url":"https://github.com/buildbot/buildbot/pull/1385","diff_url":"https://github.com/buildbot/buildbot/pull/1385.diff","patch_url":"https://github.com/buildbot/buildbot/pull/1385.patch","issue_url":"https://api.github.com/repos/buildbot/buildbot/issues/1385","number":1385,"state":"open","locked":false,"title":"Don't allow non-JSON-able properties any more","user":{"login":"benallard","id":178188,"avatar_url":"https://avatars.githubusercontent.com/u/178188?v=3","gravatar_id":"","url":"https://api.github.com/users/benallard","html_url":"https://github.com/benallard","followers_url":"https://api.github.com/users/benallard/followers","following_url":"https://api.github.com/users/benallard/following{/other_user}","gists_url":"https://api.github.com/users/benallard/gists{/gist_id}","starred_url":"https://api.github.com/users/benallard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benallard/subscriptions","organizations_url":"https://api.github.com/users/benallard/orgs","repos_url":"https://api.github.com/users/benallard/repos","events_url":"https://api.github.com/users/benallard/events{/privacy}","received_events_url":"https://api.github.com/users/benallard/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-11-24T17:46:05Z","updated_at":"2014-11-25T08:08:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"155da2a6691cf09fcecd30a057b94539d3be04c7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/buildbot/buildbot/pulls/1385/commits","review_comments_url":"https://api.github.com/repos/buildbot/buildbot/pulls/1385/comments","review_comment_url":"https://api.github.com/repos/buildbot/buildbot/pulls/comments/{number}","comments_url":"https://api.github.com/repos/buildbot/buildbot/issues/1385/comments","statuses_url":"https://api.github.com/repos/buildbot/buildbot/statuses/946d60699e787d1accaee5fb3ffad714d9aabcd0","head":{"label":"benallard:no-json-no-property","ref":"no-json-no-property","sha":"946d60699e787d1accaee5fb3ffad714d9aabcd0","user":{"login":"benallard","id":178188,"avatar_url":"https://avatars.githubusercontent.com/u/178188?v=3","gravatar_id":"","url":"https://api.github.com/users/benallard","html_url":"https://github.com/benallard","followers_url":"https://api.github.com/users/benallard/followers","following_url":"https://api.github.com/users/benallard/following{/other_user}","gists_url":"https://api.github.com/users/benallard/gists{/gist_id}","starred_url":"https://api.github.com/users/benallard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benallard/subscriptions","organizations_url":"https://api.github.com/users/benallard/orgs","repos_url":"https://api.github.com/users/benallard/repos","events_url":"https://api.github.com/users/benallard/events{/privacy}","received_events_url":"https://api.github.com/users/benallard/received_events","type":"User","site_admin":false},"repo":{"id":462919,"name":"buildbot","full_name":"benallard/buildbot","owner":{"login":"benallard","id":178188,"avatar_url":"https://avatars.githubusercontent.com/u/178188?v=3","gravatar_id":"","url":"https://api.github.com/users/benallard","html_url":"https://github.com/benallard","followers_url":"https://api.github.com/users/benallard/followers","following_url":"https://api.github.com/users/benallard/following{/other_user}","gists_url":"https://api.github.com/users/benallard/gists{/gist_id}","starred_url":"https://api.github.com/users/benallard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benallard/subscriptions","organizations_url":"https://api.github.com/users/benallard/orgs","repos_url":"https://api.github.com/users/benallard/repos","events_url":"https://api.github.com/users/benallard/events{/privacy}","received_events_url":"https://api.github.com/users/benallard/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benallard/buildbot","description":"Python-based continuous integration testing framework; send pull requests for your patches!","fork":true,"url":"https://api.github.com/repos/benallard/buildbot","forks_url":"https://api.github.com/repos/benallard/buildbot/forks","keys_url":"https://api.github.com/repos/benallard/buildbot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benallard/buildbot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benallard/buildbot/teams","hooks_url":"https://api.github.com/repos/benallard/buildbot/hooks","issue_events_url":"https://api.github.com/repos/benallard/buildbot/issues/events{/number}","events_url":"https://api.github.com/repos/benallard/buildbot/events","assignees_url":"https://api.github.com/repos/benallard/buildbot/assignees{/user}","branches_url":"https://api.github.com/repos/benallard/buildbot/branches{/branch}","tags_url":"https://api.github.com/repos/benallard/buildbot/tags","blobs_url":"https://api.github.com/repos/benallard/buildbot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benallard/buildbot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benallard/buildbot/git/refs{/sha}","trees_url":"https://api.github.com/repos/benallard/buildbot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benallard/buildbot/statuses/{sha}","languages_url":"https://api.github.com/repos/benallard/buildbot/languages","stargazers_url":"https://api.github.com/repos/benallard/buildbot/stargazers","contributors_url":"https://api.github.com/repos/benallard/buildbot/contributors","subscribers_url":"https://api.github.com/repos/benallard/buildbot/subscribers","subscription_url":"https://api.github.com/repos/benallard/buildbot/subscription","commits_url":"https://api.github.com/repos/benallard/buildbot/commits{/sha}","git_commits_url":"https://api.github.com/repos/benallard/buildbot/git/commits{/sha}","comments_url":"https://api.github.com/repos/benallard/buildbot/comments{/number}","issue_comment_url":"https://api.github.com/repos/benallard/buildbot/issues/comments/{number}","contents_url":"https://api.github.com/repos/benallard/buildbot/contents/{+path}","compare_url":"https://api.github.com/repos/benallard/buildbot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benallard/buildbot/merges","archive_url":"https://api.github.com/repos/benallard/buildbot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benallard/buildbot/downloads","issues_url":"https://api.github.com/repos/benallard/buildbot/issues{/number}","pulls_url":"https://api.github.com/repos/benallard/buildbot/pulls{/number}","milestones_url":"https://api.github.com/repos/benallard/buildbot/milestones{/number}","notifications_url":"https://api.github.com/repos/benallard/buildbot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benallard/buildbot/labels{/name}","releases_url":"https://api.github.com/repos/benallard/buildbot/releases{/id}","created_at":"2010-01-07T21:01:15Z","updated_at":"2014-11-10T11:50:02Z","pushed_at":"2014-11-24T20:40:50Z","git_url":"git://github.com/benallard/buildbot.git","ssh_url":"git@github.com:benallard/buildbot.git","clone_url":"https://github.com/benallard/buildbot.git","svn_url":"https://github.com/benallard/buildbot","homepage":"http://buildbot.net","size":33980,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"buildbot:master","ref":"master","sha":"38b44b3d2b6fe0dd0738b13d9e6a899aa6d319ee","user":{"login":"buildbot","id":324515,"avatar_url":"https://avatars.githubusercontent.com/u/324515?v=3","gravatar_id":"","url":"https://api.github.com/users/buildbot","html_url":"https://github.com/buildbot","followers_url":"https://api.github.com/users/buildbot/followers","following_url":"https://api.github.com/users/buildbot/following{/other_user}","gists_url":"https://api.github.com/users/buildbot/gists{/gist_id}","starred_url":"https://api.github.com/users/buildbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buildbot/subscriptions","organizations_url":"https://api.github.com/users/buildbot/orgs","repos_url":"https://api.github.com/users/buildbot/repos","events_url":"https://api.github.com/users/buildbot/events{/privacy}","received_events_url":"https://api.github.com/users/buildbot/received_events","type":"Organization","site_admin":false},"repo":{"id":760165,"name":"buildbot","full_name":"buildbot/buildbot","owner":{"login":"buildbot","id":324515,"avatar_url":"https://avatars.githubusercontent.com/u/324515?v=3","gravatar_id":"","url":"https://api.github.com/users/buildbot","html_url":"https://github.com/buildbot","followers_url":"https://api.github.com/users/buildbot/followers","following_url":"https://api.github.com/users/buildbot/following{/other_user}","gists_url":"https://api.github.com/users/buildbot/gists{/gist_id}","starred_url":"https://api.github.com/users/buildbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buildbot/subscriptions","organizations_url":"https://api.github.com/users/buildbot/orgs","repos_url":"https://api.github.com/users/buildbot/repos","events_url":"https://api.github.com/users/buildbot/events{/privacy}","received_events_url":"https://api.github.com/users/buildbot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/buildbot/buildbot","description":"Python-based continuous integration testing framework; send pull requests for your patches!","fork":false,"url":"https://api.github.com/repos/buildbot/buildbot","forks_url":"https://api.github.com/repos/buildbot/buildbot/forks","keys_url":"https://api.github.com/repos/buildbot/buildbot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/buildbot/buildbot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/buildbot/buildbot/teams","hooks_url":"https://api.github.com/repos/buildbot/buildbot/hooks","issue_events_url":"https://api.github.com/repos/buildbot/buildbot/issues/events{/number}","events_url":"https://api.github.com/repos/buildbot/buildbot/events","assignees_url":"https://api.github.com/repos/buildbot/buildbot/assignees{/user}","branches_url":"https://api.github.com/repos/buildbot/buildbot/branches{/branch}","tags_url":"https://api.github.com/repos/buildbot/buildbot/tags","blobs_url":"https://api.github.com/repos/buildbot/buildbot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/buildbot/buildbot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/buildbot/buildbot/git/refs{/sha}","trees_url":"https://api.github.com/repos/buildbot/buildbot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/buildbot/buildbot/statuses/{sha}","languages_url":"https://api.github.com/repos/buildbot/buildbot/languages","stargazers_url":"https://api.github.com/repos/buildbot/buildbot/stargazers","contributors_url":"https://api.github.com/repos/buildbot/buildbot/contributors","subscribers_url":"https://api.github.com/repos/buildbot/buildbot/subscribers","subscription_url":"https://api.github.com/repos/buildbot/buildbot/subscription","commits_url":"https://api.github.com/repos/buildbot/buildbot/commits{/sha}","git_commits_url":"https://api.github.com/repos/buildbot/buildbot/git/commits{/sha}","comments_url":"https://api.github.com/repos/buildbot/buildbot/comments{/number}","issue_comment_url":"https://api.github.com/repos/buildbot/buildbot/issues/comments/{number}","contents_url":"https://api.github.com/repos/buildbot/buildbot/contents/{+path}","compare_url":"https://api.github.com/repos/buildbot/buildbot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/buildbot/buildbot/merges","archive_url":"https://api.github.com/repos/buildbot/buildbot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/buildbot/buildbot/downloads","issues_url":"https://api.github.com/repos/buildbot/buildbot/issues{/number}","pulls_url":"https://api.github.com/repos/buildbot/buildbot/pulls{/number}","milestones_url":"https://api.github.com/repos/buildbot/buildbot/milestones{/number}","notifications_url":"https://api.github.com/repos/buildbot/buildbot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/buildbot/buildbot/labels{/name}","releases_url":"https://api.github.com/repos/buildbot/buildbot/releases{/id}","created_at":"2010-07-06T17:56:53Z","updated_at":"2014-11-24T21:37:33Z","pushed_at":"2014-11-24T16:38:59Z","git_url":"git://github.com/buildbot/buildbot.git","ssh_url":"git@github.com:buildbot/buildbot.git","clone_url":"https://github.com/buildbot/buildbot.git","svn_url":"https://github.com/buildbot/buildbot","homepage":"http://buildbot.net","size":50774,"stargazers_count":1228,"watchers_count":1228,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":610,"mirror_url":null,"open_issues_count":9,"forks":610,"open_issues":9,"watchers":1228,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/1385"},"html":{"href":"https://github.com/buildbot/buildbot/pull/1385"},"issue":{"href":"https://api.github.com/repos/buildbot/buildbot/issues/1385"},"comments":{"href":"https://api.github.com/repos/buildbot/buildbot/issues/1385/comments"},"review_comments":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/1385/comments"},"review_comment":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/1385/commits"},"statuses":{"href":"https://api.github.com/repos/buildbot/buildbot/statuses/946d60699e787d1accaee5fb3ffad714d9aabcd0"}}}}