GitHub PullRequestReviewCommentEvent at 2014-01-19 23:36:43
Repository: rspec-core
Actor: myronmarston
Payload: {"comment":{"url":"https://api.github.com/repos/rspec/rspec-core/pulls/comments/8994753","id":8994753,"diff_hunk":"@@ -19,4 +21,13 @@ def self.warn_deprecation(message)\n     RSpec.configuration.reporter.deprecation :message => message\n   end\n \n+  @orig_warn_with = method(:warn_with)","path":"lib/rspec/core/warnings.rb","position":10,"original_position":10,"commit_id":"8a5be0f3adec8e6de4cbb9db26be9cf2f1f0e58c","original_commit_id":"8a5be0f3adec8e6de4cbb9db26be9cf2f1f0e58c","user":{"login":"myronmarston","id":49391,"avatar_url":"https://gravatar.com/avatar/42d4590355a1404230fbc9aff4dd377b?d=https%3A%2F%2Fidenticons.github.com%2F6916222172eb021e5d5f0043453078b9.png&r=x","gravatar_id":"42d4590355a1404230fbc9aff4dd377b","url":"https://api.github.com/users/myronmarston","html_url":"https://github.com/myronmarston","followers_url":"https://api.github.com/users/myronmarston/followers","following_url":"https://api.github.com/users/myronmarston/following{/other_user}","gists_url":"https://api.github.com/users/myronmarston/gists{/gist_id}","starred_url":"https://api.github.com/users/myronmarston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myronmarston/subscriptions","organizations_url":"https://api.github.com/users/myronmarston/orgs","repos_url":"https://api.github.com/users/myronmarston/repos","events_url":"https://api.github.com/users/myronmarston/events{/privacy}","received_events_url":"https://api.github.com/users/myronmarston/received_events","type":"User","site_admin":false},"body":"Splitting it out like that seems unnecessary.  Instead, I would recommend the following:\r\n\r\n* Define the rspec-support versions of the `warn`, etc methods in a module that gets extended onto `RSpec`.\r\n* Here in rspec-core, define `warn` as a singleton method directly on `RSpec` (e.g. using `def self.warn` from within `module RSpec`).\r\n* Use `super` from the rspec-core definition to delegate up the ancestor chain to the rspec-support version.","created_at":"2014-01-19T23:36:43Z","updated_at":"2014-01-19T23:36:43Z","html_url":"https://github.com/rspec/rspec-core/pull/1253#discussion_r8994753","pull_request_url":"https://api.github.com/repos/rspec/rspec-core/pulls/1253","_links":{"self":{"href":"https://api.github.com/repos/rspec/rspec-core/pulls/comments/8994753"},"html":{"href":"https://github.com/rspec/rspec-core/pull/1253#discussion_r8994753"},"pull_request":{"href":"https://api.github.com/repos/rspec/rspec-core/pulls/1253"}}}}