GitHub PullRequestReviewCommentEvent at 2014-11-12 21:50:59
Repository: moose
Actor: cpritam
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/idaholab/moose/pulls/comments/20254590","id":20254590,"diff_hunk":"@@ -46,6 +46,9 @@ TensorMechanicsMaterial::TensorMechanicsMaterial(const std::string & name,\n {\n   _Cijkl.fillFromInputVector(_Cijkl_vector, _fill_method);\n \n+  RotationTensor R(_Euler_angles); // R type: RealTensorValue\n+  _Cijkl.rotate(R);","path":"modules/tensor_mechanics/src/materials/TensorMechanicsMaterial.C","position":5,"original_position":5,"commit_id":"6fad222aa99c4cfb65e610a6710b985da4f667f3","original_commit_id":"6fad222aa99c4cfb65e610a6710b985da4f667f3","user":{"login":"cpritam","id":7874074,"avatar_url":"https://avatars.githubusercontent.com/u/7874074?v=3","gravatar_id":"","url":"https://api.github.com/users/cpritam","html_url":"https://github.com/cpritam","followers_url":"https://api.github.com/users/cpritam/followers","following_url":"https://api.github.com/users/cpritam/following{/other_user}","gists_url":"https://api.github.com/users/cpritam/gists{/gist_id}","starred_url":"https://api.github.com/users/cpritam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpritam/subscriptions","organizations_url":"https://api.github.com/users/cpritam/orgs","repos_url":"https://api.github.com/users/cpritam/repos","events_url":"https://api.github.com/users/cpritam/events{/privacy}","received_events_url":"https://api.github.com/users/cpritam/received_events","type":"User","site_admin":false},"body":"I can remove the getEulerRotation and use the corresponding ranktwotensor function. computeqpelasticitytensor is meant to create a elasticity tensor. If you look in tensormechanicsmaterial module it is called before stress calculations. The tangent moduli or stiffness calculation (Jacobian_mult) should be moved out of it. I am planning to do this modification.","created_at":"2014-11-12T21:50:59Z","updated_at":"2014-11-12T21:50:59Z","html_url":"https://github.com/idaholab/moose/pull/4199#discussion_r20254590","pull_request_url":"https://api.github.com/repos/idaholab/moose/pulls/4199","_links":{"self":{"href":"https://api.github.com/repos/idaholab/moose/pulls/comments/20254590"},"html":{"href":"https://github.com/idaholab/moose/pull/4199#discussion_r20254590"},"pull_request":{"href":"https://api.github.com/repos/idaholab/moose/pulls/4199"}}},"pull_request":{"url":"https://api.github.com/repos/idaholab/moose/pulls/4199","id":24191968,"html_url":"https://github.com/idaholab/moose/pull/4199","diff_url":"https://github.com/idaholab/moose/pull/4199.diff","patch_url":"https://github.com/idaholab/moose/pull/4199.patch","issue_url":"https://api.github.com/repos/idaholab/moose/issues/4199","number":4199,"state":"open","locked":false,"title":"Reaction calculation 4190","user":{"login":"leizhao987","id":6801000,"avatar_url":"https://avatars.githubusercontent.com/u/6801000?v=3","gravatar_id":"","url":"https://api.github.com/users/leizhao987","html_url":"https://github.com/leizhao987","followers_url":"https://api.github.com/users/leizhao987/followers","following_url":"https://api.github.com/users/leizhao987/following{/other_user}","gists_url":"https://api.github.com/users/leizhao987/gists{/gist_id}","starred_url":"https://api.github.com/users/leizhao987/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leizhao987/subscriptions","organizations_url":"https://api.github.com/users/leizhao987/orgs","repos_url":"https://api.github.com/users/leizhao987/repos","events_url":"https://api.github.com/users/leizhao987/events{/privacy}","received_events_url":"https://api.github.com/users/leizhao987/received_events","type":"User","site_admin":false},"body":"resolve the merge conflict...\r\nRef #4190 ","created_at":"2014-11-11T01:19:30Z","updated_at":"2014-11-12T21:50:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"81a5c537d2002b12f3c87ff7305a19a8f60690eb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/idaholab/moose/pulls/4199/commits","review_comments_url":"https://api.github.com/repos/idaholab/moose/pulls/4199/comments","review_comment_url":"https://api.github.com/repos/idaholab/moose/pulls/comments/{number}","comments_url":"https://api.github.com/repos/idaholab/moose/issues/4199/comments","statuses_url":"https://api.github.com/repos/idaholab/moose/statuses/6fad222aa99c4cfb65e610a6710b985da4f667f3","head":{"label":"leizhao987:ReactionCalculation_4190","ref":"ReactionCalculation_4190","sha":"6fad222aa99c4cfb65e610a6710b985da4f667f3","user":{"login":"leizhao987","id":6801000,"avatar_url":"https://avatars.githubusercontent.com/u/6801000?v=3","gravatar_id":"","url":"https://api.github.com/users/leizhao987","html_url":"https://github.com/leizhao987","followers_url":"https://api.github.com/users/leizhao987/followers","following_url":"https://api.github.com/users/leizhao987/following{/other_user}","gists_url":"https://api.github.com/users/leizhao987/gists{/gist_id}","starred_url":"https://api.github.com/users/leizhao987/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leizhao987/subscriptions","organizations_url":"https://api.github.com/users/leizhao987/orgs","repos_url":"https://api.github.com/users/leizhao987/repos","events_url":"https://api.github.com/users/leizhao987/events{/privacy}","received_events_url":"https://api.github.com/users/leizhao987/received_events","type":"User","site_admin":false},"repo":{"id":26419954,"name":"moose","full_name":"leizhao987/moose","owner":{"login":"leizhao987","id":6801000,"avatar_url":"https://avatars.githubusercontent.com/u/6801000?v=3","gravatar_id":"","url":"https://api.github.com/users/leizhao987","html_url":"https://github.com/leizhao987","followers_url":"https://api.github.com/users/leizhao987/followers","following_url":"https://api.github.com/users/leizhao987/following{/other_user}","gists_url":"https://api.github.com/users/leizhao987/gists{/gist_id}","starred_url":"https://api.github.com/users/leizhao987/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leizhao987/subscriptions","organizations_url":"https://api.github.com/users/leizhao987/orgs","repos_url":"https://api.github.com/users/leizhao987/repos","events_url":"https://api.github.com/users/leizhao987/events{/privacy}","received_events_url":"https://api.github.com/users/leizhao987/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/leizhao987/moose","description":"Multiphysics Object Oriented Simulation Environment","fork":true,"url":"https://api.github.com/repos/leizhao987/moose","forks_url":"https://api.github.com/repos/leizhao987/moose/forks","keys_url":"https://api.github.com/repos/leizhao987/moose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leizhao987/moose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leizhao987/moose/teams","hooks_url":"https://api.github.com/repos/leizhao987/moose/hooks","issue_events_url":"https://api.github.com/repos/leizhao987/moose/issues/events{/number}","events_url":"https://api.github.com/repos/leizhao987/moose/events","assignees_url":"https://api.github.com/repos/leizhao987/moose/assignees{/user}","branches_url":"https://api.github.com/repos/leizhao987/moose/branches{/branch}","tags_url":"https://api.github.com/repos/leizhao987/moose/tags","blobs_url":"https://api.github.com/repos/leizhao987/moose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leizhao987/moose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leizhao987/moose/git/refs{/sha}","trees_url":"https://api.github.com/repos/leizhao987/moose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leizhao987/moose/statuses/{sha}","languages_url":"https://api.github.com/repos/leizhao987/moose/languages","stargazers_url":"https://api.github.com/repos/leizhao987/moose/stargazers","contributors_url":"https://api.github.com/repos/leizhao987/moose/contributors","subscribers_url":"https://api.github.com/repos/leizhao987/moose/subscribers","subscription_url":"https://api.github.com/repos/leizhao987/moose/subscription","commits_url":"https://api.github.com/repos/leizhao987/moose/commits{/sha}","git_commits_url":"https://api.github.com/repos/leizhao987/moose/git/commits{/sha}","comments_url":"https://api.github.com/repos/leizhao987/moose/comments{/number}","issue_comment_url":"https://api.github.com/repos/leizhao987/moose/issues/comments/{number}","contents_url":"https://api.github.com/repos/leizhao987/moose/contents/{+path}","compare_url":"https://api.github.com/repos/leizhao987/moose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leizhao987/moose/merges","archive_url":"https://api.github.com/repos/leizhao987/moose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leizhao987/moose/downloads","issues_url":"https://api.github.com/repos/leizhao987/moose/issues{/number}","pulls_url":"https://api.github.com/repos/leizhao987/moose/pulls{/number}","milestones_url":"https://api.github.com/repos/leizhao987/moose/milestones{/number}","notifications_url":"https://api.github.com/repos/leizhao987/moose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leizhao987/moose/labels{/name}","releases_url":"https://api.github.com/repos/leizhao987/moose/releases{/id}","created_at":"2014-11-10T03:47:00Z","updated_at":"2014-11-10T04:07:31Z","pushed_at":"2014-11-11T21:27:55Z","git_url":"git://github.com/leizhao987/moose.git","ssh_url":"git@github.com:leizhao987/moose.git","clone_url":"https://github.com/leizhao987/moose.git","svn_url":"https://github.com/leizhao987/moose","homepage":null,"size":79769,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"idaholab:devel","ref":"devel","sha":"3ad6474e83496bb3e7a14df824cd280fb1cdc14f","user":{"login":"idaholab","id":3855370,"avatar_url":"https://avatars.githubusercontent.com/u/3855370?v=3","gravatar_id":"","url":"https://api.github.com/users/idaholab","html_url":"https://github.com/idaholab","followers_url":"https://api.github.com/users/idaholab/followers","following_url":"https://api.github.com/users/idaholab/following{/other_user}","gists_url":"https://api.github.com/users/idaholab/gists{/gist_id}","starred_url":"https://api.github.com/users/idaholab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idaholab/subscriptions","organizations_url":"https://api.github.com/users/idaholab/orgs","repos_url":"https://api.github.com/users/idaholab/repos","events_url":"https://api.github.com/users/idaholab/events{/privacy}","received_events_url":"https://api.github.com/users/idaholab/received_events","type":"Organization","site_admin":false},"repo":{"id":16851223,"name":"moose","full_name":"idaholab/moose","owner":{"login":"idaholab","id":3855370,"avatar_url":"https://avatars.githubusercontent.com/u/3855370?v=3","gravatar_id":"","url":"https://api.github.com/users/idaholab","html_url":"https://github.com/idaholab","followers_url":"https://api.github.com/users/idaholab/followers","following_url":"https://api.github.com/users/idaholab/following{/other_user}","gists_url":"https://api.github.com/users/idaholab/gists{/gist_id}","starred_url":"https://api.github.com/users/idaholab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idaholab/subscriptions","organizations_url":"https://api.github.com/users/idaholab/orgs","repos_url":"https://api.github.com/users/idaholab/repos","events_url":"https://api.github.com/users/idaholab/events{/privacy}","received_events_url":"https://api.github.com/users/idaholab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/idaholab/moose","description":"Multiphysics Object Oriented Simulation Environment","fork":false,"url":"https://api.github.com/repos/idaholab/moose","forks_url":"https://api.github.com/repos/idaholab/moose/forks","keys_url":"https://api.github.com/repos/idaholab/moose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/idaholab/moose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/idaholab/moose/teams","hooks_url":"https://api.github.com/repos/idaholab/moose/hooks","issue_events_url":"https://api.github.com/repos/idaholab/moose/issues/events{/number}","events_url":"https://api.github.com/repos/idaholab/moose/events","assignees_url":"https://api.github.com/repos/idaholab/moose/assignees{/user}","branches_url":"https://api.github.com/repos/idaholab/moose/branches{/branch}","tags_url":"https://api.github.com/repos/idaholab/moose/tags","blobs_url":"https://api.github.com/repos/idaholab/moose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/idaholab/moose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/idaholab/moose/git/refs{/sha}","trees_url":"https://api.github.com/repos/idaholab/moose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/idaholab/moose/statuses/{sha}","languages_url":"https://api.github.com/repos/idaholab/moose/languages","stargazers_url":"https://api.github.com/repos/idaholab/moose/stargazers","contributors_url":"https://api.github.com/repos/idaholab/moose/contributors","subscribers_url":"https://api.github.com/repos/idaholab/moose/subscribers","subscription_url":"https://api.github.com/repos/idaholab/moose/subscription","commits_url":"https://api.github.com/repos/idaholab/moose/commits{/sha}","git_commits_url":"https://api.github.com/repos/idaholab/moose/git/commits{/sha}","comments_url":"https://api.github.com/repos/idaholab/moose/comments{/number}","issue_comment_url":"https://api.github.com/repos/idaholab/moose/issues/comments/{number}","contents_url":"https://api.github.com/repos/idaholab/moose/contents/{+path}","compare_url":"https://api.github.com/repos/idaholab/moose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/idaholab/moose/merges","archive_url":"https://api.github.com/repos/idaholab/moose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/idaholab/moose/downloads","issues_url":"https://api.github.com/repos/idaholab/moose/issues{/number}","pulls_url":"https://api.github.com/repos/idaholab/moose/pulls{/number}","milestones_url":"https://api.github.com/repos/idaholab/moose/milestones{/number}","notifications_url":"https://api.github.com/repos/idaholab/moose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/idaholab/moose/labels{/name}","releases_url":"https://api.github.com/repos/idaholab/moose/releases{/id}","created_at":"2014-02-14T22:26:15Z","updated_at":"2014-11-04T13:49:04Z","pushed_at":"2014-11-12T21:15:58Z","git_url":"git://github.com/idaholab/moose.git","ssh_url":"git@github.com:idaholab/moose.git","clone_url":"https://github.com/idaholab/moose.git","svn_url":"https://github.com/idaholab/moose","homepage":null,"size":107389,"stargazers_count":56,"watchers_count":56,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":97,"mirror_url":null,"open_issues_count":403,"forks":97,"open_issues":403,"watchers":56,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/idaholab/moose/pulls/4199"},"html":{"href":"https://github.com/idaholab/moose/pull/4199"},"issue":{"href":"https://api.github.com/repos/idaholab/moose/issues/4199"},"comments":{"href":"https://api.github.com/repos/idaholab/moose/issues/4199/comments"},"review_comments":{"href":"https://api.github.com/repos/idaholab/moose/pulls/4199/comments"},"review_comment":{"href":"https://api.github.com/repos/idaholab/moose/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/idaholab/moose/pulls/4199/commits"},"statuses":{"href":"https://api.github.com/repos/idaholab/moose/statuses/6fad222aa99c4cfb65e610a6710b985da4f667f3"}}}}