GitHub PullRequestReviewCommentEvent at 2014-07-18 18:58:25
Repository: libpalaso
Actor: ermshiperete
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/sillsdev/libpalaso/pulls/comments/15127771","id":15127771,"diff_hunk":"@@ -0,0 +1,106 @@\n+// Copyright (c) 2014 SIL International\n+// This software is licensed under the MIT License (http://opensource.org/licenses/MIT)\n+#if !__MonoCS__\n+using System.Diagnostics.CodeAnalysis;\n+using System.Security;\n+using Microsoft.Win32;\n+using Palaso.UI.WindowsForms.Keyboarding.InternalInterfaces;\n+using Palaso.WritingSystems;\n+\n+namespace Palaso.UI.WindowsForms.Keyboarding.Windows\n+{\n+\t/// ----------------------------------------------------------------------------------------\n+\t/// <summary>\n+\t/// Keyboard description for a Keyman keyboard not associated with a windows language\n+\t/// </summary>\n+\t/// ----------------------------------------------------------------------------------------\n+\t[SuppressMessage(\"Gendarme.Rules.Design\", \"TypesWithNativeFieldsShouldBeDisposableRule\",\n+\t\tJustification = \"WindowHandle is a reference to a control\")]\n+\tinternal class KeymanKeyboardDescription : KeyboardDescription\n+\t{\n+        private static bool s_keymanKeyboardSwitchingSettingEnabled;","path":"PalasoUIWindowsForms/Keyboarding/Windows/KeymanKeyboardDescription.cs","position":21,"original_position":21,"commit_id":"e660445790caca74d13fc4b565d5412fcf3dec0d","original_commit_id":"e660445790caca74d13fc4b565d5412fcf3dec0d","user":{"login":"ermshiperete","id":181336,"avatar_url":"https://avatars.githubusercontent.com/u/181336?","gravatar_id":"56e93ba634a72e535bbc7ec6f78246a4","url":"https://api.github.com/users/ermshiperete","html_url":"https://github.com/ermshiperete","followers_url":"https://api.github.com/users/ermshiperete/followers","following_url":"https://api.github.com/users/ermshiperete/following{/other_user}","gists_url":"https://api.github.com/users/ermshiperete/gists{/gist_id}","starred_url":"https://api.github.com/users/ermshiperete/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ermshiperete/subscriptions","organizations_url":"https://api.github.com/users/ermshiperete/orgs","repos_url":"https://api.github.com/users/ermshiperete/repos","events_url":"https://api.github.com/users/ermshiperete/events{/privacy}","received_events_url":"https://api.github.com/users/ermshiperete/received_events","type":"User","site_admin":false},"body":"Indentation (space instead of tab?)","created_at":"2014-07-18T18:58:25Z","updated_at":"2014-07-18T18:58:25Z","html_url":"https://github.com/sillsdev/libpalaso/pull/68#discussion_r15127771","pull_request_url":"https://api.github.com/repos/sillsdev/libpalaso/pulls/68","_links":{"self":{"href":"https://api.github.com/repos/sillsdev/libpalaso/pulls/comments/15127771"},"html":{"href":"https://github.com/sillsdev/libpalaso/pull/68#discussion_r15127771"},"pull_request":{"href":"https://api.github.com/repos/sillsdev/libpalaso/pulls/68"}}},"pull_request":{"url":"https://api.github.com/repos/sillsdev/libpalaso/pulls/68","id":18532265,"html_url":"https://github.com/sillsdev/libpalaso/pull/68","diff_url":"https://github.com/sillsdev/libpalaso/pull/68.diff","patch_url":"https://github.com/sillsdev/libpalaso/pull/68.patch","issue_url":"https://api.github.com/repos/sillsdev/libpalaso/issues/68","number":68,"state":"open","title":"Direct keyman support","user":{"login":"FoolRunning","id":4229836,"avatar_url":"https://avatars.githubusercontent.com/u/4229836?","gravatar_id":"84c8f98ff9f62e0e8c4899971ce2ab3d","url":"https://api.github.com/users/FoolRunning","html_url":"https://github.com/FoolRunning","followers_url":"https://api.github.com/users/FoolRunning/followers","following_url":"https://api.github.com/users/FoolRunning/following{/other_user}","gists_url":"https://api.github.com/users/FoolRunning/gists{/gist_id}","starred_url":"https://api.github.com/users/FoolRunning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FoolRunning/subscriptions","organizations_url":"https://api.github.com/users/FoolRunning/orgs","repos_url":"https://api.github.com/users/FoolRunning/repos","events_url":"https://api.github.com/users/FoolRunning/events{/privacy}","received_events_url":"https://api.github.com/users/FoolRunning/received_events","type":"User","site_admin":false},"body":"Re-adds support for direct Keyman keyboard support which was removed with the recent keyboard handling changes.\r\nAlso added backwards compatibility for keyboard IDs from older versions of Palaso and Paratext.","created_at":"2014-07-17T14:43:28Z","updated_at":"2014-07-18T18:58:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5957be554e7ce5870635b4023bf41904a6565d39","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sillsdev/libpalaso/pulls/68/commits","review_comments_url":"https://api.github.com/repos/sillsdev/libpalaso/pulls/68/comments","review_comment_url":"https://api.github.com/repos/sillsdev/libpalaso/pulls/comments/{number}","comments_url":"https://api.github.com/repos/sillsdev/libpalaso/issues/68/comments","statuses_url":"https://api.github.com/repos/sillsdev/libpalaso/statuses/e660445790caca74d13fc4b565d5412fcf3dec0d","head":{"label":"sillsdev:DirectKeymanSupport","ref":"DirectKeymanSupport","sha":"e660445790caca74d13fc4b565d5412fcf3dec0d","user":{"login":"sillsdev","id":1095739,"avatar_url":"https://avatars.githubusercontent.com/u/1095739?","gravatar_id":"1ea78f4cffbbae7970a9a76cf5b40922","url":"https://api.github.com/users/sillsdev","html_url":"https://github.com/sillsdev","followers_url":"https://api.github.com/users/sillsdev/followers","following_url":"https://api.github.com/users/sillsdev/following{/other_user}","gists_url":"https://api.github.com/users/sillsdev/gists{/gist_id}","starred_url":"https://api.github.com/users/sillsdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sillsdev/subscriptions","organizations_url":"https://api.github.com/users/sillsdev/orgs","repos_url":"https://api.github.com/users/sillsdev/repos","events_url":"https://api.github.com/users/sillsdev/events{/privacy}","received_events_url":"https://api.github.com/users/sillsdev/received_events","type":"Organization","site_admin":false},"repo":{"id":15614464,"name":"libpalaso","full_name":"sillsdev/libpalaso","owner":{"login":"sillsdev","id":1095739,"avatar_url":"https://avatars.githubusercontent.com/u/1095739?","gravatar_id":"1ea78f4cffbbae7970a9a76cf5b40922","url":"https://api.github.com/users/sillsdev","html_url":"https://github.com/sillsdev","followers_url":"https://api.github.com/users/sillsdev/followers","following_url":"https://api.github.com/users/sillsdev/following{/other_user}","gists_url":"https://api.github.com/users/sillsdev/gists{/gist_id}","starred_url":"https://api.github.com/users/sillsdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sillsdev/subscriptions","organizations_url":"https://api.github.com/users/sillsdev/orgs","repos_url":"https://api.github.com/users/sillsdev/repos","events_url":"https://api.github.com/users/sillsdev/events{/privacy}","received_events_url":"https://api.github.com/users/sillsdev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sillsdev/libpalaso","description":"Palaso Library: A set of .Net libraries useful for developers of Language Software.","fork":false,"url":"https://api.github.com/repos/sillsdev/libpalaso","forks_url":"https://api.github.com/repos/sillsdev/libpalaso/forks","keys_url":"https://api.github.com/repos/sillsdev/libpalaso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sillsdev/libpalaso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sillsdev/libpalaso/teams","hooks_url":"https://api.github.com/repos/sillsdev/libpalaso/hooks","issue_events_url":"https://api.github.com/repos/sillsdev/libpalaso/issues/events{/number}","events_url":"https://api.github.com/repos/sillsdev/libpalaso/events","assignees_url":"https://api.github.com/repos/sillsdev/libpalaso/assignees{/user}","branches_url":"https://api.github.com/repos/sillsdev/libpalaso/branches{/branch}","tags_url":"https://api.github.com/repos/sillsdev/libpalaso/tags","blobs_url":"https://api.github.com/repos/sillsdev/libpalaso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sillsdev/libpalaso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sillsdev/libpalaso/git/refs{/sha}","trees_url":"https://api.github.com/repos/sillsdev/libpalaso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sillsdev/libpalaso/statuses/{sha}","languages_url":"https://api.github.com/repos/sillsdev/libpalaso/languages","stargazers_url":"https://api.github.com/repos/sillsdev/libpalaso/stargazers","contributors_url":"https://api.github.com/repos/sillsdev/libpalaso/contributors","subscribers_url":"https://api.github.com/repos/sillsdev/libpalaso/subscribers","subscription_url":"https://api.github.com/repos/sillsdev/libpalaso/subscription","commits_url":"https://api.github.com/repos/sillsdev/libpalaso/commits{/sha}","git_commits_url":"https://api.github.com/repos/sillsdev/libpalaso/git/commits{/sha}","comments_url":"https://api.github.com/repos/sillsdev/libpalaso/comments{/number}","issue_comment_url":"https://api.github.com/repos/sillsdev/libpalaso/issues/comments/{number}","contents_url":"https://api.github.com/repos/sillsdev/libpalaso/contents/{+path}","compare_url":"https://api.github.com/repos/sillsdev/libpalaso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sillsdev/libpalaso/merges","archive_url":"https://api.github.com/repos/sillsdev/libpalaso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sillsdev/libpalaso/downloads","issues_url":"https://api.github.com/repos/sillsdev/libpalaso/issues{/number}","pulls_url":"https://api.github.com/repos/sillsdev/libpalaso/pulls{/number}","milestones_url":"https://api.github.com/repos/sillsdev/libpalaso/milestones{/number}","notifications_url":"https://api.github.com/repos/sillsdev/libpalaso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sillsdev/libpalaso/labels{/name}","releases_url":"https://api.github.com/repos/sillsdev/libpalaso/releases{/id}","created_at":"2014-01-03T16:57:39Z","updated_at":"2014-07-03T14:47:50Z","pushed_at":"2014-07-18T17:35:55Z","git_url":"git://github.com/sillsdev/libpalaso.git","ssh_url":"git@github.com:sillsdev/libpalaso.git","clone_url":"https://github.com/sillsdev/libpalaso.git","svn_url":"https://github.com/sillsdev/libpalaso","homepage":"","size":21783,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":5,"mirror_url":null,"open_issues_count":3,"forks":5,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"sillsdev:master","ref":"master","sha":"b69c045ecd1ae91b88ac505cfd0d6af3377e66f2","user":{"login":"sillsdev","id":1095739,"avatar_url":"https://avatars.githubusercontent.com/u/1095739?","gravatar_id":"1ea78f4cffbbae7970a9a76cf5b40922","url":"https://api.github.com/users/sillsdev","html_url":"https://github.com/sillsdev","followers_url":"https://api.github.com/users/sillsdev/followers","following_url":"https://api.github.com/users/sillsdev/following{/other_user}","gists_url":"https://api.github.com/users/sillsdev/gists{/gist_id}","starred_url":"https://api.github.com/users/sillsdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sillsdev/subscriptions","organizations_url":"https://api.github.com/users/sillsdev/orgs","repos_url":"https://api.github.com/users/sillsdev/repos","events_url":"https://api.github.com/users/sillsdev/events{/privacy}","received_events_url":"https://api.github.com/users/sillsdev/received_events","type":"Organization","site_admin":false},"repo":{"id":15614464,"name":"libpalaso","full_name":"sillsdev/libpalaso","owner":{"login":"sillsdev","id":1095739,"avatar_url":"https://avatars.githubusercontent.com/u/1095739?","gravatar_id":"1ea78f4cffbbae7970a9a76cf5b40922","url":"https://api.github.com/users/sillsdev","html_url":"https://github.com/sillsdev","followers_url":"https://api.github.com/users/sillsdev/followers","following_url":"https://api.github.com/users/sillsdev/following{/other_user}","gists_url":"https://api.github.com/users/sillsdev/gists{/gist_id}","starred_url":"https://api.github.com/users/sillsdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sillsdev/subscriptions","organizations_url":"https://api.github.com/users/sillsdev/orgs","repos_url":"https://api.github.com/users/sillsdev/repos","events_url":"https://api.github.com/users/sillsdev/events{/privacy}","received_events_url":"https://api.github.com/users/sillsdev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sillsdev/libpalaso","description":"Palaso Library: A set of .Net libraries useful for developers of Language Software.","fork":false,"url":"https://api.github.com/repos/sillsdev/libpalaso","forks_url":"https://api.github.com/repos/sillsdev/libpalaso/forks","keys_url":"https://api.github.com/repos/sillsdev/libpalaso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sillsdev/libpalaso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sillsdev/libpalaso/teams","hooks_url":"https://api.github.com/repos/sillsdev/libpalaso/hooks","issue_events_url":"https://api.github.com/repos/sillsdev/libpalaso/issues/events{/number}","events_url":"https://api.github.com/repos/sillsdev/libpalaso/events","assignees_url":"https://api.github.com/repos/sillsdev/libpalaso/assignees{/user}","branches_url":"https://api.github.com/repos/sillsdev/libpalaso/branches{/branch}","tags_url":"https://api.github.com/repos/sillsdev/libpalaso/tags","blobs_url":"https://api.github.com/repos/sillsdev/libpalaso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sillsdev/libpalaso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sillsdev/libpalaso/git/refs{/sha}","trees_url":"https://api.github.com/repos/sillsdev/libpalaso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sillsdev/libpalaso/statuses/{sha}","languages_url":"https://api.github.com/repos/sillsdev/libpalaso/languages","stargazers_url":"https://api.github.com/repos/sillsdev/libpalaso/stargazers","contributors_url":"https://api.github.com/repos/sillsdev/libpalaso/contributors","subscribers_url":"https://api.github.com/repos/sillsdev/libpalaso/subscribers","subscription_url":"https://api.github.com/repos/sillsdev/libpalaso/subscription","commits_url":"https://api.github.com/repos/sillsdev/libpalaso/commits{/sha}","git_commits_url":"https://api.github.com/repos/sillsdev/libpalaso/git/commits{/sha}","comments_url":"https://api.github.com/repos/sillsdev/libpalaso/comments{/number}","issue_comment_url":"https://api.github.com/repos/sillsdev/libpalaso/issues/comments/{number}","contents_url":"https://api.github.com/repos/sillsdev/libpalaso/contents/{+path}","compare_url":"https://api.github.com/repos/sillsdev/libpalaso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sillsdev/libpalaso/merges","archive_url":"https://api.github.com/repos/sillsdev/libpalaso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sillsdev/libpalaso/downloads","issues_url":"https://api.github.com/repos/sillsdev/libpalaso/issues{/number}","pulls_url":"https://api.github.com/repos/sillsdev/libpalaso/pulls{/number}","milestones_url":"https://api.github.com/repos/sillsdev/libpalaso/milestones{/number}","notifications_url":"https://api.github.com/repos/sillsdev/libpalaso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sillsdev/libpalaso/labels{/name}","releases_url":"https://api.github.com/repos/sillsdev/libpalaso/releases{/id}","created_at":"2014-01-03T16:57:39Z","updated_at":"2014-07-03T14:47:50Z","pushed_at":"2014-07-18T17:35:55Z","git_url":"git://github.com/sillsdev/libpalaso.git","ssh_url":"git@github.com:sillsdev/libpalaso.git","clone_url":"https://github.com/sillsdev/libpalaso.git","svn_url":"https://github.com/sillsdev/libpalaso","homepage":"","size":21783,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":5,"mirror_url":null,"open_issues_count":3,"forks":5,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sillsdev/libpalaso/pulls/68"},"html":{"href":"https://github.com/sillsdev/libpalaso/pull/68"},"issue":{"href":"https://api.github.com/repos/sillsdev/libpalaso/issues/68"},"comments":{"href":"https://api.github.com/repos/sillsdev/libpalaso/issues/68/comments"},"review_comments":{"href":"https://api.github.com/repos/sillsdev/libpalaso/pulls/68/comments"},"review_comment":{"href":"https://api.github.com/repos/sillsdev/libpalaso/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/sillsdev/libpalaso/pulls/68/commits"},"statuses":{"href":"https://api.github.com/repos/sillsdev/libpalaso/statuses/e660445790caca74d13fc4b565d5412fcf3dec0d"}}}}