GitHub PullRequestReviewCommentEvent at 2014-12-04 10:34:36
Repository: angular.js
Actor: gkalpak
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular.js/pulls/comments/21296437","id":21296437,"diff_hunk":"@@ -2018,6 +2012,12 @@ function $CompileProvider($provide, $$sanitizeUriProvider) {\n       }\n     }\n \n+    function invokeEach(funcs) {\n+      for (var key in funcs) {","path":"src/ng/compile.js","position":201,"original_position":201,"commit_id":"89a4f89971faf0705ab025d6e087c8465dbe935f","original_commit_id":"89a4f89971faf0705ab025d6e087c8465dbe935f","user":{"login":"gkalpak","id":8604205,"avatar_url":"https://avatars.githubusercontent.com/u/8604205?v=3","gravatar_id":"","url":"https://api.github.com/users/gkalpak","html_url":"https://github.com/gkalpak","followers_url":"https://api.github.com/users/gkalpak/followers","following_url":"https://api.github.com/users/gkalpak/following{/other_user}","gists_url":"https://api.github.com/users/gkalpak/gists{/gist_id}","starred_url":"https://api.github.com/users/gkalpak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkalpak/subscriptions","organizations_url":"https://api.github.com/users/gkalpak/orgs","repos_url":"https://api.github.com/users/gkalpak/repos","events_url":"https://api.github.com/users/gkalpak/events{/privacy}","received_events_url":"https://api.github.com/users/gkalpak/received_events","type":"User","site_admin":false},"body":"Hm...interesting ! Seems like I had misunderstood `createMap()` a bit. Thx for clarifying things.\r\n\r\nYet your explanation brings up another question:\r\nSince we are trying to access unknown keys in `elementControllers` (based on directive name etc), wouldn't it be better to use `createMap()`, in order to avoid problems with \"unsafe\" directive names (e.g. `toString`) ?","created_at":"2014-12-04T10:34:36Z","updated_at":"2014-12-04T10:34:36Z","html_url":"https://github.com/angular/angular.js/pull/9772#discussion_r21296437","pull_request_url":"https://api.github.com/repos/angular/angular.js/pulls/9772","_links":{"self":{"href":"https://api.github.com/repos/angular/angular.js/pulls/comments/21296437"},"html":{"href":"https://github.com/angular/angular.js/pull/9772#discussion_r21296437"},"pull_request":{"href":"https://api.github.com/repos/angular/angular.js/pulls/9772"}}},"pull_request":{"url":"https://api.github.com/repos/angular/angular.js/pulls/9772","id":23281484,"html_url":"https://github.com/angular/angular.js/pull/9772","diff_url":"https://github.com/angular/angular.js/pull/9772.diff","patch_url":"https://github.com/angular/angular.js/pull/9772.patch","issue_url":"https://api.github.com/repos/angular/angular.js/issues/9772","number":9772,"state":"open","locked":false,"title":"perf(ngmodel/compile): improve ngmodel and general compile/controller performance (#9609)","user":{"login":"jbedard","id":89246,"avatar_url":"https://avatars.githubusercontent.com/u/89246?v=3","gravatar_id":"","url":"https://api.github.com/users/jbedard","html_url":"https://github.com/jbedard","followers_url":"https://api.github.com/users/jbedard/followers","following_url":"https://api.github.com/users/jbedard/following{/other_user}","gists_url":"https://api.github.com/users/jbedard/gists{/gist_id}","starred_url":"https://api.github.com/users/jbedard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbedard/subscriptions","organizations_url":"https://api.github.com/users/jbedard/orgs","repos_url":"https://api.github.com/users/jbedard/repos","events_url":"https://api.github.com/users/jbedard/events{/privacy}","received_events_url":"https://api.github.com/users/jbedard/received_events","type":"User","site_admin":false},"body":"This was mainly focused around #9609 - bringing 1.3 up to speed with 1.2 with an ng-repeated ng-model, at least when not using jQuery.\r\n\r\nOverall these changes make the added benchmark (and the jsfiddle in #9609) 2-3x faster and seem to be faster then 1.2 now.\r\n\r\nThe last 3 commits (refactoring controller stuff in $compile) can probably be squashed but I left them separate for now for nicer diffs.\r\n\r\nThe only functional change (that I know of) is that the NgModelController `$name` is now initialized by the directive (pre-link) instead of within the controller. I'm not sure if this an issue or considered breaking? This was already the case for the `$options` field...","created_at":"2014-10-24T08:11:59Z","updated_at":"2014-12-04T10:34:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5264e97e564a0aa2077f7a4dfded69a721a99a9c","assignee":{"login":"IgorMinar","id":216296,"avatar_url":"https://avatars.githubusercontent.com/u/216296?v=3","gravatar_id":"","url":"https://api.github.com/users/IgorMinar","html_url":"https://github.com/IgorMinar","followers_url":"https://api.github.com/users/IgorMinar/followers","following_url":"https://api.github.com/users/IgorMinar/following{/other_user}","gists_url":"https://api.github.com/users/IgorMinar/gists{/gist_id}","starred_url":"https://api.github.com/users/IgorMinar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IgorMinar/subscriptions","organizations_url":"https://api.github.com/users/IgorMinar/orgs","repos_url":"https://api.github.com/users/IgorMinar/repos","events_url":"https://api.github.com/users/IgorMinar/events{/privacy}","received_events_url":"https://api.github.com/users/IgorMinar/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/angular/angular.js/milestones/32","labels_url":"https://api.github.com/repos/angular/angular.js/milestones/32/labels","id":510155,"number":32,"title":"1.3.x","description":"","creator":{"login":"tbosch","id":690815,"avatar_url":"https://avatars.githubusercontent.com/u/690815?v=3","gravatar_id":"","url":"https://api.github.com/users/tbosch","html_url":"https://github.com/tbosch","followers_url":"https://api.github.com/users/tbosch/followers","following_url":"https://api.github.com/users/tbosch/following{/other_user}","gists_url":"https://api.github.com/users/tbosch/gists{/gist_id}","starred_url":"https://api.github.com/users/tbosch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbosch/subscriptions","organizations_url":"https://api.github.com/users/tbosch/orgs","repos_url":"https://api.github.com/users/tbosch/repos","events_url":"https://api.github.com/users/tbosch/events{/privacy}","received_events_url":"https://api.github.com/users/tbosch/received_events","type":"User","site_admin":false},"open_issues":119,"closed_issues":269,"state":"open","created_at":"2013-12-10T19:41:50Z","updated_at":"2014-12-04T09:17:28Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/angular/angular.js/pulls/9772/commits","review_comments_url":"https://api.github.com/repos/angular/angular.js/pulls/9772/comments","review_comment_url":"https://api.github.com/repos/angular/angular.js/pulls/comments/{number}","comments_url":"https://api.github.com/repos/angular/angular.js/issues/9772/comments","statuses_url":"https://api.github.com/repos/angular/angular.js/statuses/89a4f89971faf0705ab025d6e087c8465dbe935f","head":{"label":"jbedard:9609-ngmodel-perf","ref":"9609-ngmodel-perf","sha":"89a4f89971faf0705ab025d6e087c8465dbe935f","user":{"login":"jbedard","id":89246,"avatar_url":"https://avatars.githubusercontent.com/u/89246?v=3","gravatar_id":"","url":"https://api.github.com/users/jbedard","html_url":"https://github.com/jbedard","followers_url":"https://api.github.com/users/jbedard/followers","following_url":"https://api.github.com/users/jbedard/following{/other_user}","gists_url":"https://api.github.com/users/jbedard/gists{/gist_id}","starred_url":"https://api.github.com/users/jbedard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbedard/subscriptions","organizations_url":"https://api.github.com/users/jbedard/orgs","repos_url":"https://api.github.com/users/jbedard/repos","events_url":"https://api.github.com/users/jbedard/events{/privacy}","received_events_url":"https://api.github.com/users/jbedard/received_events","type":"User","site_admin":false},"repo":{"id":20282210,"name":"angular.js","full_name":"jbedard/angular.js","owner":{"login":"jbedard","id":89246,"avatar_url":"https://avatars.githubusercontent.com/u/89246?v=3","gravatar_id":"","url":"https://api.github.com/users/jbedard","html_url":"https://github.com/jbedard","followers_url":"https://api.github.com/users/jbedard/followers","following_url":"https://api.github.com/users/jbedard/following{/other_user}","gists_url":"https://api.github.com/users/jbedard/gists{/gist_id}","starred_url":"https://api.github.com/users/jbedard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbedard/subscriptions","organizations_url":"https://api.github.com/users/jbedard/orgs","repos_url":"https://api.github.com/users/jbedard/repos","events_url":"https://api.github.com/users/jbedard/events{/privacy}","received_events_url":"https://api.github.com/users/jbedard/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jbedard/angular.js","description":"HTML enhanced for web apps","fork":true,"url":"https://api.github.com/repos/jbedard/angular.js","forks_url":"https://api.github.com/repos/jbedard/angular.js/forks","keys_url":"https://api.github.com/repos/jbedard/angular.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jbedard/angular.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jbedard/angular.js/teams","hooks_url":"https://api.github.com/repos/jbedard/angular.js/hooks","issue_events_url":"https://api.github.com/repos/jbedard/angular.js/issues/events{/number}","events_url":"https://api.github.com/repos/jbedard/angular.js/events","assignees_url":"https://api.github.com/repos/jbedard/angular.js/assignees{/user}","branches_url":"https://api.github.com/repos/jbedard/angular.js/branches{/branch}","tags_url":"https://api.github.com/repos/jbedard/angular.js/tags","blobs_url":"https://api.github.com/repos/jbedard/angular.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jbedard/angular.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jbedard/angular.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/jbedard/angular.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jbedard/angular.js/statuses/{sha}","languages_url":"https://api.github.com/repos/jbedard/angular.js/languages","stargazers_url":"https://api.github.com/repos/jbedard/angular.js/stargazers","contributors_url":"https://api.github.com/repos/jbedard/angular.js/contributors","subscribers_url":"https://api.github.com/repos/jbedard/angular.js/subscribers","subscription_url":"https://api.github.com/repos/jbedard/angular.js/subscription","commits_url":"https://api.github.com/repos/jbedard/angular.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/jbedard/angular.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/jbedard/angular.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/jbedard/angular.js/issues/comments/{number}","contents_url":"https://api.github.com/repos/jbedard/angular.js/contents/{+path}","compare_url":"https://api.github.com/repos/jbedard/angular.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jbedard/angular.js/merges","archive_url":"https://api.github.com/repos/jbedard/angular.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jbedard/angular.js/downloads","issues_url":"https://api.github.com/repos/jbedard/angular.js/issues{/number}","pulls_url":"https://api.github.com/repos/jbedard/angular.js/pulls{/number}","milestones_url":"https://api.github.com/repos/jbedard/angular.js/milestones{/number}","notifications_url":"https://api.github.com/repos/jbedard/angular.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jbedard/angular.js/labels{/name}","releases_url":"https://api.github.com/repos/jbedard/angular.js/releases{/id}","created_at":"2014-05-29T04:33:05Z","updated_at":"2014-07-04T07:17:50Z","pushed_at":"2014-12-04T10:14:40Z","git_url":"git://github.com/jbedard/angular.js.git","ssh_url":"git@github.com:jbedard/angular.js.git","clone_url":"https://github.com/jbedard/angular.js.git","svn_url":"https://github.com/jbedard/angular.js","homepage":"http://angularjs.org","size":60385,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"30694c802763d46d6787f7298f47dfef53ed4229","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":460078,"name":"angular.js","full_name":"angular/angular.js","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular.js","description":"HTML enhanced for web apps","fork":false,"url":"https://api.github.com/repos/angular/angular.js","forks_url":"https://api.github.com/repos/angular/angular.js/forks","keys_url":"https://api.github.com/repos/angular/angular.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular.js/teams","hooks_url":"https://api.github.com/repos/angular/angular.js/hooks","issue_events_url":"https://api.github.com/repos/angular/angular.js/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular.js/events","assignees_url":"https://api.github.com/repos/angular/angular.js/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular.js/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular.js/tags","blobs_url":"https://api.github.com/repos/angular/angular.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular.js/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular.js/languages","stargazers_url":"https://api.github.com/repos/angular/angular.js/stargazers","contributors_url":"https://api.github.com/repos/angular/angular.js/contributors","subscribers_url":"https://api.github.com/repos/angular/angular.js/subscribers","subscription_url":"https://api.github.com/repos/angular/angular.js/subscription","commits_url":"https://api.github.com/repos/angular/angular.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular.js/issues/comments/{number}","contents_url":"https://api.github.com/repos/angular/angular.js/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular.js/merges","archive_url":"https://api.github.com/repos/angular/angular.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular.js/downloads","issues_url":"https://api.github.com/repos/angular/angular.js/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular.js/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular.js/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular.js/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular.js/releases{/id}","created_at":"2010-01-06T00:34:37Z","updated_at":"2014-12-04T10:19:58Z","pushed_at":"2014-12-04T00:59:57Z","git_url":"git://github.com/angular/angular.js.git","ssh_url":"git@github.com:angular/angular.js.git","clone_url":"https://github.com/angular/angular.js.git","svn_url":"https://github.com/angular/angular.js","homepage":"http://angularjs.org","size":203285,"stargazers_count":32412,"watchers_count":32412,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12709,"mirror_url":null,"open_issues_count":1133,"forks":12709,"open_issues":1133,"watchers":32412,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular.js/pulls/9772"},"html":{"href":"https://github.com/angular/angular.js/pull/9772"},"issue":{"href":"https://api.github.com/repos/angular/angular.js/issues/9772"},"comments":{"href":"https://api.github.com/repos/angular/angular.js/issues/9772/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular.js/pulls/9772/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular.js/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/angular/angular.js/pulls/9772/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular.js/statuses/89a4f89971faf0705ab025d6e087c8465dbe935f"}}}}