GitHub PullRequestReviewCommentEvent at 2014-10-07 00:46:34
Repository: ipython
Actor: jdfreder
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/ipython/ipython/pulls/comments/18495226","id":18495226,"diff_hunk":"@@ -137,6 +139,7 @@ define([\n         default_celltoolbar.register(this);\n         rawcell_celltoolbar.register(this);\n         slideshow_celltoolbar.register(this);\n+        tags_celltoolbar.register(this, this.keyboard_manager);","path":"IPython/html/static/notebook/js/notebook.js","position":20,"original_position":20,"commit_id":"ebd7385a074e438498702311b710125a67bf4dde","original_commit_id":"ebd7385a074e438498702311b710125a67bf4dde","user":{"login":"jdfreder","id":3292874,"avatar_url":"https://avatars.githubusercontent.com/u/3292874?v=2","gravatar_id":"","url":"https://api.github.com/users/jdfreder","html_url":"https://github.com/jdfreder","followers_url":"https://api.github.com/users/jdfreder/followers","following_url":"https://api.github.com/users/jdfreder/following{/other_user}","gists_url":"https://api.github.com/users/jdfreder/gists{/gist_id}","starred_url":"https://api.github.com/users/jdfreder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdfreder/subscriptions","organizations_url":"https://api.github.com/users/jdfreder/orgs","repos_url":"https://api.github.com/users/jdfreder/repos","events_url":"https://api.github.com/users/jdfreder/events{/privacy}","received_events_url":"https://api.github.com/users/jdfreder/received_events","type":"User","site_admin":false},"body":"Just because it needs keyboard manager.  AFIAK the others do not.  It is possible to get keyboard_manager via `notebook.keyboard_manager` as seen here, so I can change the sig so it looked the same as the others.","created_at":"2014-10-07T00:46:34Z","updated_at":"2014-10-07T00:46:34Z","html_url":"https://github.com/ipython/ipython/pull/6638#discussion_r18495226","pull_request_url":"https://api.github.com/repos/ipython/ipython/pulls/6638","_links":{"self":{"href":"https://api.github.com/repos/ipython/ipython/pulls/comments/18495226"},"html":{"href":"https://github.com/ipython/ipython/pull/6638#discussion_r18495226"},"pull_request":{"href":"https://api.github.com/repos/ipython/ipython/pulls/6638"}}},"pull_request":{"url":"https://api.github.com/repos/ipython/ipython/pulls/6638","id":22323263,"html_url":"https://github.com/ipython/ipython/pull/6638","diff_url":"https://github.com/ipython/ipython/pull/6638.diff","patch_url":"https://github.com/ipython/ipython/pull/6638.patch","issue_url":"https://api.github.com/repos/ipython/ipython/issues/6638","number":6638,"state":"open","locked":false,"title":"Tagging","user":{"login":"jdfreder","id":3292874,"avatar_url":"https://avatars.githubusercontent.com/u/3292874?v=2","gravatar_id":"","url":"https://api.github.com/users/jdfreder","html_url":"https://github.com/jdfreder","followers_url":"https://api.github.com/users/jdfreder/followers","following_url":"https://api.github.com/users/jdfreder/following{/other_user}","gists_url":"https://api.github.com/users/jdfreder/gists{/gist_id}","starred_url":"https://api.github.com/users/jdfreder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdfreder/subscriptions","organizations_url":"https://api.github.com/users/jdfreder/orgs","repos_url":"https://api.github.com/users/jdfreder/repos","events_url":"https://api.github.com/users/jdfreder/events{/privacy}","received_events_url":"https://api.github.com/users/jdfreder/received_events","type":"User","site_admin":false},"body":"With the addition of cell tags to nbformat v4, it's probably a good time to discuss adding a GUI for tagging and filtering cells.  This PR adds a cell toolbar that uses the Bootstrap-Tags library to enable tagging of cells.  It also adds a filter GUI to the main toolbar that allows you to quickly filter cells by tag.\r\n\r\nPing @jasongrout and @sylvaincorlay who requested this, and @ellisonbg who took a look in person and gave me some suggestions.","created_at":"2014-10-07T00:02:20Z","updated_at":"2014-10-07T00:46:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2eac26f9d816ad1d4dc0f133c0548569e817b22b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ipython/ipython/pulls/6638/commits","review_comments_url":"https://api.github.com/repos/ipython/ipython/pulls/6638/comments","review_comment_url":"https://api.github.com/repos/ipython/ipython/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ipython/ipython/issues/6638/comments","statuses_url":"https://api.github.com/repos/ipython/ipython/statuses/ebd7385a074e438498702311b710125a67bf4dde","head":{"label":"jdfreder:tagging","ref":"tagging","sha":"ebd7385a074e438498702311b710125a67bf4dde","user":{"login":"jdfreder","id":3292874,"avatar_url":"https://avatars.githubusercontent.com/u/3292874?v=2","gravatar_id":"","url":"https://api.github.com/users/jdfreder","html_url":"https://github.com/jdfreder","followers_url":"https://api.github.com/users/jdfreder/followers","following_url":"https://api.github.com/users/jdfreder/following{/other_user}","gists_url":"https://api.github.com/users/jdfreder/gists{/gist_id}","starred_url":"https://api.github.com/users/jdfreder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdfreder/subscriptions","organizations_url":"https://api.github.com/users/jdfreder/orgs","repos_url":"https://api.github.com/users/jdfreder/repos","events_url":"https://api.github.com/users/jdfreder/events{/privacy}","received_events_url":"https://api.github.com/users/jdfreder/received_events","type":"User","site_admin":false},"repo":{"id":7768091,"name":"ipython","full_name":"jdfreder/ipython","owner":{"login":"jdfreder","id":3292874,"avatar_url":"https://avatars.githubusercontent.com/u/3292874?v=2","gravatar_id":"","url":"https://api.github.com/users/jdfreder","html_url":"https://github.com/jdfreder","followers_url":"https://api.github.com/users/jdfreder/followers","following_url":"https://api.github.com/users/jdfreder/following{/other_user}","gists_url":"https://api.github.com/users/jdfreder/gists{/gist_id}","starred_url":"https://api.github.com/users/jdfreder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdfreder/subscriptions","organizations_url":"https://api.github.com/users/jdfreder/orgs","repos_url":"https://api.github.com/users/jdfreder/repos","events_url":"https://api.github.com/users/jdfreder/events{/privacy}","received_events_url":"https://api.github.com/users/jdfreder/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jdfreder/ipython","description":"Official repository for IPython itself. Other repos in the IPython organization contain things like the website, documentation builds, etc.","fork":true,"url":"https://api.github.com/repos/jdfreder/ipython","forks_url":"https://api.github.com/repos/jdfreder/ipython/forks","keys_url":"https://api.github.com/repos/jdfreder/ipython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jdfreder/ipython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jdfreder/ipython/teams","hooks_url":"https://api.github.com/repos/jdfreder/ipython/hooks","issue_events_url":"https://api.github.com/repos/jdfreder/ipython/issues/events{/number}","events_url":"https://api.github.com/repos/jdfreder/ipython/events","assignees_url":"https://api.github.com/repos/jdfreder/ipython/assignees{/user}","branches_url":"https://api.github.com/repos/jdfreder/ipython/branches{/branch}","tags_url":"https://api.github.com/repos/jdfreder/ipython/tags","blobs_url":"https://api.github.com/repos/jdfreder/ipython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jdfreder/ipython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jdfreder/ipython/git/refs{/sha}","trees_url":"https://api.github.com/repos/jdfreder/ipython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jdfreder/ipython/statuses/{sha}","languages_url":"https://api.github.com/repos/jdfreder/ipython/languages","stargazers_url":"https://api.github.com/repos/jdfreder/ipython/stargazers","contributors_url":"https://api.github.com/repos/jdfreder/ipython/contributors","subscribers_url":"https://api.github.com/repos/jdfreder/ipython/subscribers","subscription_url":"https://api.github.com/repos/jdfreder/ipython/subscription","commits_url":"https://api.github.com/repos/jdfreder/ipython/commits{/sha}","git_commits_url":"https://api.github.com/repos/jdfreder/ipython/git/commits{/sha}","comments_url":"https://api.github.com/repos/jdfreder/ipython/comments{/number}","issue_comment_url":"https://api.github.com/repos/jdfreder/ipython/issues/comments/{number}","contents_url":"https://api.github.com/repos/jdfreder/ipython/contents/{+path}","compare_url":"https://api.github.com/repos/jdfreder/ipython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jdfreder/ipython/merges","archive_url":"https://api.github.com/repos/jdfreder/ipython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jdfreder/ipython/downloads","issues_url":"https://api.github.com/repos/jdfreder/ipython/issues{/number}","pulls_url":"https://api.github.com/repos/jdfreder/ipython/pulls{/number}","milestones_url":"https://api.github.com/repos/jdfreder/ipython/milestones{/number}","notifications_url":"https://api.github.com/repos/jdfreder/ipython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jdfreder/ipython/labels{/name}","releases_url":"https://api.github.com/repos/jdfreder/ipython/releases{/id}","created_at":"2013-01-23T05:05:43Z","updated_at":"2014-09-15T18:39:28Z","pushed_at":"2014-10-07T00:09:14Z","git_url":"git://github.com/jdfreder/ipython.git","ssh_url":"git@github.com:jdfreder/ipython.git","clone_url":"https://github.com/jdfreder/ipython.git","svn_url":"https://github.com/jdfreder/ipython","homepage":"http://ipython.org","size":70460,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"ipython:master","ref":"master","sha":"f7e2466ff4c69a058e77f02fcba582fa4cd25e81","user":{"login":"ipython","id":230453,"avatar_url":"https://avatars.githubusercontent.com/u/230453?v=2","gravatar_id":"","url":"https://api.github.com/users/ipython","html_url":"https://github.com/ipython","followers_url":"https://api.github.com/users/ipython/followers","following_url":"https://api.github.com/users/ipython/following{/other_user}","gists_url":"https://api.github.com/users/ipython/gists{/gist_id}","starred_url":"https://api.github.com/users/ipython/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipython/subscriptions","organizations_url":"https://api.github.com/users/ipython/orgs","repos_url":"https://api.github.com/users/ipython/repos","events_url":"https://api.github.com/users/ipython/events{/privacy}","received_events_url":"https://api.github.com/users/ipython/received_events","type":"Organization","site_admin":false},"repo":{"id":658518,"name":"ipython","full_name":"ipython/ipython","owner":{"login":"ipython","id":230453,"avatar_url":"https://avatars.githubusercontent.com/u/230453?v=2","gravatar_id":"","url":"https://api.github.com/users/ipython","html_url":"https://github.com/ipython","followers_url":"https://api.github.com/users/ipython/followers","following_url":"https://api.github.com/users/ipython/following{/other_user}","gists_url":"https://api.github.com/users/ipython/gists{/gist_id}","starred_url":"https://api.github.com/users/ipython/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipython/subscriptions","organizations_url":"https://api.github.com/users/ipython/orgs","repos_url":"https://api.github.com/users/ipython/repos","events_url":"https://api.github.com/users/ipython/events{/privacy}","received_events_url":"https://api.github.com/users/ipython/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ipython/ipython","description":"Official repository for IPython itself. Other repos in the IPython organization contain things like the website, documentation builds, etc.","fork":false,"url":"https://api.github.com/repos/ipython/ipython","forks_url":"https://api.github.com/repos/ipython/ipython/forks","keys_url":"https://api.github.com/repos/ipython/ipython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ipython/ipython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ipython/ipython/teams","hooks_url":"https://api.github.com/repos/ipython/ipython/hooks","issue_events_url":"https://api.github.com/repos/ipython/ipython/issues/events{/number}","events_url":"https://api.github.com/repos/ipython/ipython/events","assignees_url":"https://api.github.com/repos/ipython/ipython/assignees{/user}","branches_url":"https://api.github.com/repos/ipython/ipython/branches{/branch}","tags_url":"https://api.github.com/repos/ipython/ipython/tags","blobs_url":"https://api.github.com/repos/ipython/ipython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ipython/ipython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ipython/ipython/git/refs{/sha}","trees_url":"https://api.github.com/repos/ipython/ipython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ipython/ipython/statuses/{sha}","languages_url":"https://api.github.com/repos/ipython/ipython/languages","stargazers_url":"https://api.github.com/repos/ipython/ipython/stargazers","contributors_url":"https://api.github.com/repos/ipython/ipython/contributors","subscribers_url":"https://api.github.com/repos/ipython/ipython/subscribers","subscription_url":"https://api.github.com/repos/ipython/ipython/subscription","commits_url":"https://api.github.com/repos/ipython/ipython/commits{/sha}","git_commits_url":"https://api.github.com/repos/ipython/ipython/git/commits{/sha}","comments_url":"https://api.github.com/repos/ipython/ipython/comments{/number}","issue_comment_url":"https://api.github.com/repos/ipython/ipython/issues/comments/{number}","contents_url":"https://api.github.com/repos/ipython/ipython/contents/{+path}","compare_url":"https://api.github.com/repos/ipython/ipython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ipython/ipython/merges","archive_url":"https://api.github.com/repos/ipython/ipython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ipython/ipython/downloads","issues_url":"https://api.github.com/repos/ipython/ipython/issues{/number}","pulls_url":"https://api.github.com/repos/ipython/ipython/pulls{/number}","milestones_url":"https://api.github.com/repos/ipython/ipython/milestones{/number}","notifications_url":"https://api.github.com/repos/ipython/ipython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ipython/ipython/labels{/name}","releases_url":"https://api.github.com/repos/ipython/ipython/releases{/id}","created_at":"2010-05-10T04:46:06Z","updated_at":"2014-10-06T21:15:00Z","pushed_at":"2014-10-06T04:15:10Z","git_url":"git://github.com/ipython/ipython.git","ssh_url":"git@github.com:ipython/ipython.git","clone_url":"https://github.com/ipython/ipython.git","svn_url":"https://github.com/ipython/ipython","homepage":"http://ipython.org","size":124074,"stargazers_count":4942,"watchers_count":4942,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1435,"mirror_url":null,"open_issues_count":846,"forks":1435,"open_issues":846,"watchers":4942,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ipython/ipython/pulls/6638"},"html":{"href":"https://github.com/ipython/ipython/pull/6638"},"issue":{"href":"https://api.github.com/repos/ipython/ipython/issues/6638"},"comments":{"href":"https://api.github.com/repos/ipython/ipython/issues/6638/comments"},"review_comments":{"href":"https://api.github.com/repos/ipython/ipython/pulls/6638/comments"},"review_comment":{"href":"https://api.github.com/repos/ipython/ipython/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ipython/ipython/pulls/6638/commits"},"statuses":{"href":"https://api.github.com/repos/ipython/ipython/statuses/ebd7385a074e438498702311b710125a67bf4dde"}}}}