GitHub PullRequestReviewCommentEvent at 2014-07-23 19:34:04
Repository: Baystation12
Actor: Mloc
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments/15310087","id":15310087,"diff_hunk":"@@ -4,16 +4,24 @@ What are the archived variables for?\n \tThis prevents race conditions that arise based on the order of tile processing.\n */\n \n-#define SPECIFIC_HEAT_TOXIN\t\t200\n-#define SPECIFIC_HEAT_AIR\t\t20\n-#define SPECIFIC_HEAT_CDO\t\t30\n+#define SPECIFIC_HEAT_TOXIN\t\t200\t\t// J/(mol*K)\n+#define SPECIFIC_HEAT_AIR\t\t20\t\t// J/(mol*K)\n+#define SPECIFIC_HEAT_CDO\t\t30\t\t// J/(mol*K)\n #define HEAT_CAPACITY_CALCULATION(oxygen,carbon_dioxide,nitrogen,phoron) \\\n \tmax(0, carbon_dioxide * SPECIFIC_HEAT_CDO + (oxygen + nitrogen) * SPECIFIC_HEAT_AIR + phoron * SPECIFIC_HEAT_TOXIN)\n \n+//we should really have a datum for each gas instead of a bunch of constants","path":"code/ZAS/_gas_mixture.dm","position":13,"original_position":13,"commit_id":"09280953b2c70dc51f3e63fdb7dfac43abf4a19e","original_commit_id":"09280953b2c70dc51f3e63fdb7dfac43abf4a19e","user":{"login":"Mloc","id":537056,"avatar_url":"https://avatars.githubusercontent.com/u/537056?","gravatar_id":"a637b5974424ff2330636859a9a7d69f","url":"https://api.github.com/users/Mloc","html_url":"https://github.com/Mloc","followers_url":"https://api.github.com/users/Mloc/followers","following_url":"https://api.github.com/users/Mloc/following{/other_user}","gists_url":"https://api.github.com/users/Mloc/gists{/gist_id}","starred_url":"https://api.github.com/users/Mloc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mloc/subscriptions","organizations_url":"https://api.github.com/users/Mloc/orgs","repos_url":"https://api.github.com/users/Mloc/repos","events_url":"https://api.github.com/users/Mloc/events{/privacy}","received_events_url":"https://api.github.com/users/Mloc/received_events","type":"User","site_admin":false},"body":"It'll definitely make this cleaner if you hook it in with gas_data.","created_at":"2014-07-23T19:34:04Z","updated_at":"2014-07-23T19:34:04Z","html_url":"https://github.com/Baystation12/Baystation12/pull/5619#discussion_r15310087","pull_request_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/5619","_links":{"self":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments/15310087"},"html":{"href":"https://github.com/Baystation12/Baystation12/pull/5619#discussion_r15310087"},"pull_request":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/5619"}}},"pull_request":{"url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/5619","id":18377547,"html_url":"https://github.com/Baystation12/Baystation12/pull/5619","diff_url":"https://github.com/Baystation12/Baystation12/pull/5619.diff","patch_url":"https://github.com/Baystation12/Baystation12/pull/5619.patch","issue_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/5619","number":5619,"state":"open","title":"[DO NOT MERGE] Atmospherics and Power Net Overhaul","user":{"login":"mwerezak","id":242428,"avatar_url":"https://avatars.githubusercontent.com/u/242428?","gravatar_id":"112317dffa1bdfaf9971650eee03f17a","url":"https://api.github.com/users/mwerezak","html_url":"https://github.com/mwerezak","followers_url":"https://api.github.com/users/mwerezak/followers","following_url":"https://api.github.com/users/mwerezak/following{/other_user}","gists_url":"https://api.github.com/users/mwerezak/gists{/gist_id}","starred_url":"https://api.github.com/users/mwerezak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwerezak/subscriptions","organizations_url":"https://api.github.com/users/mwerezak/orgs","repos_url":"https://api.github.com/users/mwerezak/repos","events_url":"https://api.github.com/users/mwerezak/events{/privacy}","received_events_url":"https://api.github.com/users/mwerezak/received_events","type":"User","site_admin":false},"body":"This is still under development, I'm putting it here so people know what's being worked on.\r\n\r\n* Fixes cellrate issues with rechargers, cell chargers, and charging stations.\r\n* Adjusts power usages for airlocks, telecoms equipment, and R&D servers.\r\n* Makes space heaters and air alarms cool the environment and draw power using a system inspired by thermodynamics.\r\n* Makes gas pumps draw power based on gas entropy, in practice this makes the gas pumping rate based on the pressure jump across the pump and the amount of power the pump has available to pump gas.\r\n* Replaces volume pumps (since there's no fundamental difference between them and regular gas pumps now) with high power gas pumps that have twice the power rating.\r\n* Updates vent pumps to draw power as gas pumps do.","created_at":"2014-07-14T22:09:32Z","updated_at":"2014-07-23T19:34:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d26501f9febe569ba1863656ad1219259296590e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/5619/commits","review_comments_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/5619/comments","review_comment_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/5619/comments","statuses_url":"https://api.github.com/repos/Baystation12/Baystation12/statuses/09280953b2c70dc51f3e63fdb7dfac43abf4a19e","head":{"label":"mwerezak:power-net","ref":"power-net","sha":"09280953b2c70dc51f3e63fdb7dfac43abf4a19e","user":{"login":"mwerezak","id":242428,"avatar_url":"https://avatars.githubusercontent.com/u/242428?","gravatar_id":"112317dffa1bdfaf9971650eee03f17a","url":"https://api.github.com/users/mwerezak","html_url":"https://github.com/mwerezak","followers_url":"https://api.github.com/users/mwerezak/followers","following_url":"https://api.github.com/users/mwerezak/following{/other_user}","gists_url":"https://api.github.com/users/mwerezak/gists{/gist_id}","starred_url":"https://api.github.com/users/mwerezak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwerezak/subscriptions","organizations_url":"https://api.github.com/users/mwerezak/orgs","repos_url":"https://api.github.com/users/mwerezak/repos","events_url":"https://api.github.com/users/mwerezak/events{/privacy}","received_events_url":"https://api.github.com/users/mwerezak/received_events","type":"User","site_admin":false},"repo":{"id":18691192,"name":"Baystation12","full_name":"mwerezak/Baystation12","owner":{"login":"mwerezak","id":242428,"avatar_url":"https://avatars.githubusercontent.com/u/242428?","gravatar_id":"112317dffa1bdfaf9971650eee03f17a","url":"https://api.github.com/users/mwerezak","html_url":"https://github.com/mwerezak","followers_url":"https://api.github.com/users/mwerezak/followers","following_url":"https://api.github.com/users/mwerezak/following{/other_user}","gists_url":"https://api.github.com/users/mwerezak/gists{/gist_id}","starred_url":"https://api.github.com/users/mwerezak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwerezak/subscriptions","organizations_url":"https://api.github.com/users/mwerezak/orgs","repos_url":"https://api.github.com/users/mwerezak/repos","events_url":"https://api.github.com/users/mwerezak/events{/privacy}","received_events_url":"https://api.github.com/users/mwerezak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mwerezak/Baystation12","description":"The code for Baystation12's branch of SS13. Developers: please don't forget to update the changelog. Thanks!","fork":true,"url":"https://api.github.com/repos/mwerezak/Baystation12","forks_url":"https://api.github.com/repos/mwerezak/Baystation12/forks","keys_url":"https://api.github.com/repos/mwerezak/Baystation12/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mwerezak/Baystation12/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mwerezak/Baystation12/teams","hooks_url":"https://api.github.com/repos/mwerezak/Baystation12/hooks","issue_events_url":"https://api.github.com/repos/mwerezak/Baystation12/issues/events{/number}","events_url":"https://api.github.com/repos/mwerezak/Baystation12/events","assignees_url":"https://api.github.com/repos/mwerezak/Baystation12/assignees{/user}","branches_url":"https://api.github.com/repos/mwerezak/Baystation12/branches{/branch}","tags_url":"https://api.github.com/repos/mwerezak/Baystation12/tags","blobs_url":"https://api.github.com/repos/mwerezak/Baystation12/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mwerezak/Baystation12/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mwerezak/Baystation12/git/refs{/sha}","trees_url":"https://api.github.com/repos/mwerezak/Baystation12/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mwerezak/Baystation12/statuses/{sha}","languages_url":"https://api.github.com/repos/mwerezak/Baystation12/languages","stargazers_url":"https://api.github.com/repos/mwerezak/Baystation12/stargazers","contributors_url":"https://api.github.com/repos/mwerezak/Baystation12/contributors","subscribers_url":"https://api.github.com/repos/mwerezak/Baystation12/subscribers","subscription_url":"https://api.github.com/repos/mwerezak/Baystation12/subscription","commits_url":"https://api.github.com/repos/mwerezak/Baystation12/commits{/sha}","git_commits_url":"https://api.github.com/repos/mwerezak/Baystation12/git/commits{/sha}","comments_url":"https://api.github.com/repos/mwerezak/Baystation12/comments{/number}","issue_comment_url":"https://api.github.com/repos/mwerezak/Baystation12/issues/comments/{number}","contents_url":"https://api.github.com/repos/mwerezak/Baystation12/contents/{+path}","compare_url":"https://api.github.com/repos/mwerezak/Baystation12/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mwerezak/Baystation12/merges","archive_url":"https://api.github.com/repos/mwerezak/Baystation12/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mwerezak/Baystation12/downloads","issues_url":"https://api.github.com/repos/mwerezak/Baystation12/issues{/number}","pulls_url":"https://api.github.com/repos/mwerezak/Baystation12/pulls{/number}","milestones_url":"https://api.github.com/repos/mwerezak/Baystation12/milestones{/number}","notifications_url":"https://api.github.com/repos/mwerezak/Baystation12/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mwerezak/Baystation12/labels{/name}","releases_url":"https://api.github.com/repos/mwerezak/Baystation12/releases{/id}","created_at":"2014-04-11T23:01:36Z","updated_at":"2014-06-28T18:23:15Z","pushed_at":"2014-07-23T05:44:19Z","git_url":"git://github.com/mwerezak/Baystation12.git","ssh_url":"git@github.com:mwerezak/Baystation12.git","clone_url":"https://github.com/mwerezak/Baystation12.git","svn_url":"https://github.com/mwerezak/Baystation12","homepage":"http://baystation12.net/","size":663981,"stargazers_count":0,"watchers_count":0,"language":"DM","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Baystation12:dev","ref":"dev","sha":"7b6bf985b82d74fe7bfa03dc639e55743993ecf6","user":{"login":"Baystation12","id":1174322,"avatar_url":"https://avatars.githubusercontent.com/u/1174322?","gravatar_id":"12328b8f97222aa865882e4d8afc9e09","url":"https://api.github.com/users/Baystation12","html_url":"https://github.com/Baystation12","followers_url":"https://api.github.com/users/Baystation12/followers","following_url":"https://api.github.com/users/Baystation12/following{/other_user}","gists_url":"https://api.github.com/users/Baystation12/gists{/gist_id}","starred_url":"https://api.github.com/users/Baystation12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Baystation12/subscriptions","organizations_url":"https://api.github.com/users/Baystation12/orgs","repos_url":"https://api.github.com/users/Baystation12/repos","events_url":"https://api.github.com/users/Baystation12/events{/privacy}","received_events_url":"https://api.github.com/users/Baystation12/received_events","type":"Organization","site_admin":false},"repo":{"id":2715933,"name":"Baystation12","full_name":"Baystation12/Baystation12","owner":{"login":"Baystation12","id":1174322,"avatar_url":"https://avatars.githubusercontent.com/u/1174322?","gravatar_id":"12328b8f97222aa865882e4d8afc9e09","url":"https://api.github.com/users/Baystation12","html_url":"https://github.com/Baystation12","followers_url":"https://api.github.com/users/Baystation12/followers","following_url":"https://api.github.com/users/Baystation12/following{/other_user}","gists_url":"https://api.github.com/users/Baystation12/gists{/gist_id}","starred_url":"https://api.github.com/users/Baystation12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Baystation12/subscriptions","organizations_url":"https://api.github.com/users/Baystation12/orgs","repos_url":"https://api.github.com/users/Baystation12/repos","events_url":"https://api.github.com/users/Baystation12/events{/privacy}","received_events_url":"https://api.github.com/users/Baystation12/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Baystation12/Baystation12","description":"The code for Baystation12's branch of SS13","fork":false,"url":"https://api.github.com/repos/Baystation12/Baystation12","forks_url":"https://api.github.com/repos/Baystation12/Baystation12/forks","keys_url":"https://api.github.com/repos/Baystation12/Baystation12/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Baystation12/Baystation12/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Baystation12/Baystation12/teams","hooks_url":"https://api.github.com/repos/Baystation12/Baystation12/hooks","issue_events_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/events{/number}","events_url":"https://api.github.com/repos/Baystation12/Baystation12/events","assignees_url":"https://api.github.com/repos/Baystation12/Baystation12/assignees{/user}","branches_url":"https://api.github.com/repos/Baystation12/Baystation12/branches{/branch}","tags_url":"https://api.github.com/repos/Baystation12/Baystation12/tags","blobs_url":"https://api.github.com/repos/Baystation12/Baystation12/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Baystation12/Baystation12/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Baystation12/Baystation12/git/refs{/sha}","trees_url":"https://api.github.com/repos/Baystation12/Baystation12/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Baystation12/Baystation12/statuses/{sha}","languages_url":"https://api.github.com/repos/Baystation12/Baystation12/languages","stargazers_url":"https://api.github.com/repos/Baystation12/Baystation12/stargazers","contributors_url":"https://api.github.com/repos/Baystation12/Baystation12/contributors","subscribers_url":"https://api.github.com/repos/Baystation12/Baystation12/subscribers","subscription_url":"https://api.github.com/repos/Baystation12/Baystation12/subscription","commits_url":"https://api.github.com/repos/Baystation12/Baystation12/commits{/sha}","git_commits_url":"https://api.github.com/repos/Baystation12/Baystation12/git/commits{/sha}","comments_url":"https://api.github.com/repos/Baystation12/Baystation12/comments{/number}","issue_comment_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/comments/{number}","contents_url":"https://api.github.com/repos/Baystation12/Baystation12/contents/{+path}","compare_url":"https://api.github.com/repos/Baystation12/Baystation12/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Baystation12/Baystation12/merges","archive_url":"https://api.github.com/repos/Baystation12/Baystation12/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Baystation12/Baystation12/downloads","issues_url":"https://api.github.com/repos/Baystation12/Baystation12/issues{/number}","pulls_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls{/number}","milestones_url":"https://api.github.com/repos/Baystation12/Baystation12/milestones{/number}","notifications_url":"https://api.github.com/repos/Baystation12/Baystation12/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Baystation12/Baystation12/labels{/name}","releases_url":"https://api.github.com/repos/Baystation12/Baystation12/releases{/id}","created_at":"2011-11-05T16:12:41Z","updated_at":"2014-07-23T15:27:52Z","pushed_at":"2014-07-23T17:07:44Z","git_url":"git://github.com/Baystation12/Baystation12.git","ssh_url":"git@github.com:Baystation12/Baystation12.git","clone_url":"https://github.com/Baystation12/Baystation12.git","svn_url":"https://github.com/Baystation12/Baystation12","homepage":"http://baystation12.net/","size":834272,"stargazers_count":151,"watchers_count":151,"language":"DM","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":499,"mirror_url":null,"open_issues_count":58,"forks":499,"open_issues":58,"watchers":151,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/5619"},"html":{"href":"https://github.com/Baystation12/Baystation12/pull/5619"},"issue":{"href":"https://api.github.com/repos/Baystation12/Baystation12/issues/5619"},"comments":{"href":"https://api.github.com/repos/Baystation12/Baystation12/issues/5619/comments"},"review_comments":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/5619/comments"},"review_comment":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/5619/commits"},"statuses":{"href":"https://api.github.com/repos/Baystation12/Baystation12/statuses/09280953b2c70dc51f3e63fdb7dfac43abf4a19e"}}}}