GitHub PullRequestEvent at 2014-10-07 21:07:23
Repository: rust
Actor: dotdash
Payload: {"action":"closed","number":17857,"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/17857","id":22382122,"html_url":"https://github.com/rust-lang/rust/pull/17857","diff_url":"https://github.com/rust-lang/rust/pull/17857.diff","patch_url":"https://github.com/rust-lang/rust/pull/17857.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/17857","number":17857,"state":"closed","locked":false,"title":"Generate better code for \"large\" vec![] macro invocations","user":{"login":"dotdash","id":230962,"avatar_url":"https://avatars.githubusercontent.com/u/230962?v=2","gravatar_id":"","url":"https://api.github.com/users/dotdash","html_url":"https://github.com/dotdash","followers_url":"https://api.github.com/users/dotdash/followers","following_url":"https://api.github.com/users/dotdash/following{/other_user}","gists_url":"https://api.github.com/users/dotdash/gists{/gist_id}","starred_url":"https://api.github.com/users/dotdash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotdash/subscriptions","organizations_url":"https://api.github.com/users/dotdash/orgs","repos_url":"https://api.github.com/users/dotdash/repos","events_url":"https://api.github.com/users/dotdash/events{/privacy}","received_events_url":"https://api.github.com/users/dotdash/received_events","type":"User","site_admin":false},"body":"Even when optimized, something like vec![1i,2,3,4,5,6,7,8,9,10] will\r\nallocate three times, because LLVM can only drop the call based on the\r\nobserved size of the previous allocation. Using a simple macro to count\r\nthe number of elements, we can initialize the vector with the correct\r\nsize and avoid reallocations.\r\n\r\nSince LLVM already does constant folding for us, the new count!() macro\r\nresults in a single integer constant even if building without\r\noptimizations, so we don't end up with an awful lot of additions in the\r\ngenerated code.","created_at":"2014-10-07T20:42:47Z","updated_at":"2014-10-07T21:07:22Z","closed_at":"2014-10-07T21:07:22Z","merged_at":null,"merge_commit_sha":"c140cd86aca0e0a2cd4b95cc5bc39706ebf4b106","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/17857/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/17857/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/17857/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/55419bdf697801d0dda8a0ba60a6c5c9ffef76ea","head":{"label":"dotdash:vec_opt","ref":"vec_opt","sha":"55419bdf697801d0dda8a0ba60a6c5c9ffef76ea","user":{"login":"dotdash","id":230962,"avatar_url":"https://avatars.githubusercontent.com/u/230962?v=2","gravatar_id":"","url":"https://api.github.com/users/dotdash","html_url":"https://github.com/dotdash","followers_url":"https://api.github.com/users/dotdash/followers","following_url":"https://api.github.com/users/dotdash/following{/other_user}","gists_url":"https://api.github.com/users/dotdash/gists{/gist_id}","starred_url":"https://api.github.com/users/dotdash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotdash/subscriptions","organizations_url":"https://api.github.com/users/dotdash/orgs","repos_url":"https://api.github.com/users/dotdash/repos","events_url":"https://api.github.com/users/dotdash/events{/privacy}","received_events_url":"https://api.github.com/users/dotdash/received_events","type":"User","site_admin":false},"repo":{"id":9376483,"name":"rust","full_name":"dotdash/rust","owner":{"login":"dotdash","id":230962,"avatar_url":"https://avatars.githubusercontent.com/u/230962?v=2","gravatar_id":"","url":"https://api.github.com/users/dotdash","html_url":"https://github.com/dotdash","followers_url":"https://api.github.com/users/dotdash/followers","following_url":"https://api.github.com/users/dotdash/following{/other_user}","gists_url":"https://api.github.com/users/dotdash/gists{/gist_id}","starred_url":"https://api.github.com/users/dotdash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotdash/subscriptions","organizations_url":"https://api.github.com/users/dotdash/orgs","repos_url":"https://api.github.com/users/dotdash/repos","events_url":"https://api.github.com/users/dotdash/events{/privacy}","received_events_url":"https://api.github.com/users/dotdash/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dotdash/rust","description":"a safe, concurrent, practical language","fork":true,"url":"https://api.github.com/repos/dotdash/rust","forks_url":"https://api.github.com/repos/dotdash/rust/forks","keys_url":"https://api.github.com/repos/dotdash/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotdash/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotdash/rust/teams","hooks_url":"https://api.github.com/repos/dotdash/rust/hooks","issue_events_url":"https://api.github.com/repos/dotdash/rust/issues/events{/number}","events_url":"https://api.github.com/repos/dotdash/rust/events","assignees_url":"https://api.github.com/repos/dotdash/rust/assignees{/user}","branches_url":"https://api.github.com/repos/dotdash/rust/branches{/branch}","tags_url":"https://api.github.com/repos/dotdash/rust/tags","blobs_url":"https://api.github.com/repos/dotdash/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotdash/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotdash/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotdash/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotdash/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/dotdash/rust/languages","stargazers_url":"https://api.github.com/repos/dotdash/rust/stargazers","contributors_url":"https://api.github.com/repos/dotdash/rust/contributors","subscribers_url":"https://api.github.com/repos/dotdash/rust/subscribers","subscription_url":"https://api.github.com/repos/dotdash/rust/subscription","commits_url":"https://api.github.com/repos/dotdash/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotdash/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotdash/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotdash/rust/issues/comments/{number}","contents_url":"https://api.github.com/repos/dotdash/rust/contents/{+path}","compare_url":"https://api.github.com/repos/dotdash/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotdash/rust/merges","archive_url":"https://api.github.com/repos/dotdash/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotdash/rust/downloads","issues_url":"https://api.github.com/repos/dotdash/rust/issues{/number}","pulls_url":"https://api.github.com/repos/dotdash/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/dotdash/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/dotdash/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotdash/rust/labels{/name}","releases_url":"https://api.github.com/repos/dotdash/rust/releases{/id}","created_at":"2013-04-11T17:43:47Z","updated_at":"2014-07-18T19:57:47Z","pushed_at":"2014-10-07T20:42:34Z","git_url":"git://github.com/dotdash/rust.git","ssh_url":"git@github.com:dotdash/rust.git","clone_url":"https://github.com/dotdash/rust.git","svn_url":"https://github.com/dotdash/rust","homepage":"http://www.rust-lang.org","size":167924,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"683e40f355596d211a31066db8524496e432bae5","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=2","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=2","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"a safe, concurrent, practical language","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments/{number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","created_at":"2010-06-16T20:39:03Z","updated_at":"2014-10-07T19:16:44Z","pushed_at":"2014-10-07T20:45:17Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"http://www.rust-lang.org","size":483192,"stargazers_count":6777,"watchers_count":6777,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1328,"mirror_url":null,"open_issues_count":1932,"forks":1328,"open_issues":1932,"watchers":6777,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/17857"},"html":{"href":"https://github.com/rust-lang/rust/pull/17857"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/17857"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/17857/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/17857/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/17857/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/55419bdf697801d0dda8a0ba60a6c5c9ffef76ea"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":27,"deletions":0,"changed_files":1}}