GitHub PushEvent at 2014-10-03 17:46:03
Repository: pants
Actor: jsirois
Payload: {"shas":[["ad7d09d8964999d132c675bee5be634b16da808d","265b11d407c862ea192a8410d23f331de8c26758@lahosken.san-francisco.ca.us","our example repositories snuck into the build dictionary.\n\nOur internal_backend/repositories defines a couple of example repositories that our BUILD files can refer to.\n\nOur BUILD Dictionary builder code looks at symbols defined in our BUILD files to figure out what do doc in http://pantsbuild.github.io/build_dictionary.html\n\nSo...\n\nGive our old @manual.builddict() decorator a new optional arg, suppress.\n\nMark those example repositories with manual.builddict(suppress=True)\n\nBUILD Dictionary builder checks for suppress==True and omits those\n\nTesting Done:\npublish_docs.sh , eyeballed\n\nhttps://travis-ci.org/pantsbuild/pants/builds/36815549\n\nReviewed at https://rbcommons.com/s/twitter/r/1101/","larry hosken (Twitter)",true],["0ea28ad0dfa94411a51d8c666aa780d3f254d786","695d76d5a2f51dc9340d65ccd0d72ad7560773f9@squareup.com","Protobuf and payload cleanups\n\nMoved some of the protobuf examples around to be more consistent.\nSome cleanups from payload refactoring\nAdded a deprecation message for the unused 'buildflags' attribute in java_protobuf_library\nRemoved the ability to use a jar_dependency in java_protobuf_library imports.\n\nTesting Done:\nCI is green.\nAdded a unit test for the java_protobuf_library target\n\nBugs closed: 623\n\nReviewed at https://rbcommons.com/s/twitter/r/1099/","Eric Ayers",true],["c0762f9f34bc26d17214104d658df064a76a5871","695d76d5a2f51dc9340d65ccd0d72ad7560773f9@squareup.com","Adding a list of dirs to exclude from the '::' scan.  The CmdLineSpecParser\n\nBy default passes along the workdir as the one dir to exclude.\nYou can add more directories relative to the build root using 'spec_excludes' in pants.ini\n\nTesting Done:\nci is green.\n\nI also created a bogus BUILD file under .pants.d and ran build-support/bin/ci.sh locally and the tests still passed.\n\nBugs closed: 618, 621\n\nReviewed at https://rbcommons.com/s/twitter/r/1091/","Eric Ayers",true],["32bde41ddac614788113f6d1482a8ca81930a080","265b11d407c862ea192a8410d23f331de8c26758@lahosken.san-francisco.ca.us","'goal builddict' : generate .rst and .html, not just .rst\n\nbefore: running 'goal builddict' generates a couple of .rst files which we then give to Sphinx\n\nafter: running 'goal builddict' generates those .rst files but also a couple of .html files which we then give to sitegen.\n\nIf/when sitegen's in good shape, it'd be good to get rid of the .rst-generating part.\n\nMost of this change is in src/python/pants/backend/core/tasks/builddictionary.py , plus new html templates.\n\nThere are also changes to some docstrings:\n\nI replaced some sphinx-rst-isms with docutil-rst-isms (which also work with Sphinx).\n\nAnd I replaced some lost docstrings which I removed with the \"inherit docstrings\" change because I \"knew\" they'd be inherited from a superclass.\n\nAnd added some docstrings which have been missing for a while which I noticed because increased scrutiny grrrrr.\n\nTesting Done:\nhttps://travis-ci.org/pantsbuild/pants/builds/36888156\n\nRunning sphinx on the generated .rst files now generates warnings :-(\nI poked around 'em for a while, but eventually gave up.\n\nBugs closed: 529\n\nReviewed at https://rbcommons.com/s/twitter/r/1079/","larry hosken (Twitter)",true],["436e83f025d038af3d8d1186bda8962e5e54b339","040cff05bd320eb0560246813fe142b421636f09@gmail.com","Plumb new-style options into the Context.\n\nAllows code to reference option values the new way.\n\nRenamed the overloaded self.options in Command to self.old_options/self.new_options,\nto avoid confusion. Previously these collided and the only reason it worked was that\nself.options happened to be reset to the right one just before using it.\n\nChange a single flag reference to use the new path, as proof that it works.\n\nWith this change we can not only register flags the new way but also reference the option\nvalues the new way. Once everything is ported to use these, we can switch the parser to\nthe new one, and the transition will be complete.\n\nTesting Done:\nci baking.\n\nReviewed at https://rbcommons.com/s/twitter/r/1102/","Benjy Weinberger",true],["d3dd34d4044b5fe35fec564b35482cae56aff4a6","2e951f4de4089b8fc584f3a65157d85fa8514ef1@foursquare.com","Merge remote-tracking branch 'pantsbuild/master'\n\nConflicts:\n\tsrc/python/pants/goal/context.py","Benjy",true],["65b46f6baf87478277e9df6937c5133c4d772a5f","040cff05bd320eb0560246813fe142b421636f09@gmail.com","Switch global option registration to the new options system.\n\nAlso fix a couple of small issues that arose while testing this.\n\nAlso switch the --graph option in list_goals to be read from the\nnew location, to verify that this all works together.\n\nNote that add_global_options is still used when generating the\nbuild dictionary, so we can't get rid of it yet. We'll do so\nin a pending change.\n\nTesting Done:\nRan ci.sh. Ran manual command lines to verify that flags still work.\n\nReviewed at https://rbcommons.com/s/twitter/r/1109/","Benjy Weinberger",true],["bb2055d753f582dba097f167d0bd0eeda59c34c1","e6790d662e1019ca6c466f6e9c1c2294cd870ba9@gmail.com","Add transitive jar dependencies to depmap project info goal for intellij plugin.\n\nAdd transitive jar dependencies to depmap goal for Pants Intellij plugin\n\nWhen creating projects using the plugin, the depmap showed direct dependencies for 3rdparty jar libraries.\nThis change add the trasitive dependency jars to the depmap output.\nThe transitive jars are required to correctly configure intellij modules.\n\nTesting Done:\nyes.\n\nAdded integration tests but need to verify the contents.\n\nPR created here:\nhttps://github.com/pantsbuild/pants/pull/626\n{Coverage increased (+0.04%) when pulling 09790ec on add_transitive_jar_deps into ad7d09d on master.}\n\nLocally tested\n./pants tests/python/pants_test/tasks:depmap_integration\n\nReviewed at https://rbcommons.com/s/twitter/r/1047/","Tejal Desai",true],["1bdfef0cce41342938f249c88db2d23223827864","695d76d5a2f51dc9340d65ccd0d72ad7560773f9@squareup.com","Make sure that 'option java_package' always overrides 'package' in protobuf_gen\n\nFound a bug where:\n\noption java_package = \"foo\";\npackage bar;\n\nwas processed differently from\n\npackage bar;\noption java_package = \"foo\";\n\nFor java code generation, the setting of 'option java_package' should always win.\n\nTesting Done:\nAdded a unit test.\n\nBugs closed: 629\n\nReviewed at https://rbcommons.com/s/twitter/r/1108/","Eric Ayers",true]],"size":9,"ref":"refs/heads/master","head":"1bdfef0cce41342938f249c88db2d23223827864"}