GitHub PullRequestReviewCommentEvent at 2014-09-24 15:10:52
Repository: netty
Actor: Scottmitch
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/netty/netty/pulls/comments/17977027","id":17977027,"diff_hunk":"@@ -37,86 +32,80 @@\n import io.netty.channel.ChannelPromise;\n import io.netty.handler.codec.ByteToMessageDecoder;\n \n-import java.util.ArrayDeque;\n import java.util.Collection;\n import java.util.List;\n \n /**\n- * Abstract base class for a handler of HTTP/2 frames. Handles reading and writing of HTTP/2 frames\n- * as well as management of connection state and flow control for both inbound and outbound data\n- * frames.\n+ * Abstract base class for a handler of HTTP/2 frames. Handles reading and writing of HTTP/2 frames as well as\n+ * management of connection state and flow control for both inbound and outbound data frames.\n  * <p>\n- * Subclasses need to implement the methods defined by the {@link Http2FrameListener} interface for\n- * receiving inbound frames. Outbound frames are sent via one of the {@code writeXXX} methods.\n+ * Subclasses need to implement the methods defined by the {@link Http2FrameListener} interface for receiving inbound\n+ * frames. Outbound frames are sent via one of the {@code writeXXX} methods.\n  * <p>\n- * It should be noted that the connection preface is sent upon either activation or addition of this\n- * handler to the pipeline. Subclasses overriding {@link #channelActive} or {@link #handlerAdded}\n- * must call this class to write the preface to the remote endpoint.\n+ * It should be noted that the connection preface is sent upon either activation or addition of this handler to the\n+ * pipeline. Subclasses overriding {@link #channelActive} or {@link #handlerAdded} must call this class to write the\n+ * preface to the remote endpoint.\n  */\n-public abstract class AbstractHttp2ConnectionHandler extends ByteToMessageDecoder implements\n-        Http2FrameListener {\n+public class DefaultHttp2ConnectionHandler extends ByteToMessageDecoder implements Http2FrameProducer {","path":"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionHandler.java","position":47,"original_position":47,"commit_id":"005a47bee9eacb2842d2d812dcfb852564864383","original_commit_id":"005a47bee9eacb2842d2d812dcfb852564864383","user":{"login":"Scottmitch","id":7562868,"avatar_url":"https://avatars.githubusercontent.com/u/7562868?v=2","gravatar_id":"","url":"https://api.github.com/users/Scottmitch","html_url":"https://github.com/Scottmitch","followers_url":"https://api.github.com/users/Scottmitch/followers","following_url":"https://api.github.com/users/Scottmitch/following{/other_user}","gists_url":"https://api.github.com/users/Scottmitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Scottmitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Scottmitch/subscriptions","organizations_url":"https://api.github.com/users/Scottmitch/orgs","repos_url":"https://api.github.com/users/Scottmitch/repos","events_url":"https://api.github.com/users/Scottmitch/events{/privacy}","received_events_url":"https://api.github.com/users/Scottmitch/received_events","type":"User","site_admin":false},"body":"I like that idea and was hoping that is where it would eventually lead.  I wanted to get the writing restructuring looked at first but if doing the decoupling will help then I can think about that now.","created_at":"2014-09-24T15:10:52Z","updated_at":"2014-09-24T15:10:52Z","html_url":"https://github.com/netty/netty/pull/2935#discussion_r17977027","pull_request_url":"https://api.github.com/repos/netty/netty/pulls/2935","_links":{"self":{"href":"https://api.github.com/repos/netty/netty/pulls/comments/17977027"},"html":{"href":"https://github.com/netty/netty/pull/2935#discussion_r17977027"},"pull_request":{"href":"https://api.github.com/repos/netty/netty/pulls/2935"}}},"pull_request":{"url":"https://api.github.com/repos/netty/netty/pulls/2935","id":21691508,"html_url":"https://github.com/netty/netty/pull/2935","diff_url":"https://github.com/netty/netty/pull/2935.diff","patch_url":"https://github.com/netty/netty/pull/2935.patch","issue_url":"https://api.github.com/repos/netty/netty/issues/2935","number":2935,"state":"open","locked":false,"title":"HTTP/2 Write Compression Support","user":{"login":"Scottmitch","id":7562868,"avatar_url":"https://avatars.githubusercontent.com/u/7562868?v=2","gravatar_id":"","url":"https://api.github.com/users/Scottmitch","html_url":"https://github.com/Scottmitch","followers_url":"https://api.github.com/users/Scottmitch/followers","following_url":"https://api.github.com/users/Scottmitch/following{/other_user}","gists_url":"https://api.github.com/users/Scottmitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Scottmitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Scottmitch/subscriptions","organizations_url":"https://api.github.com/users/Scottmitch/orgs","repos_url":"https://api.github.com/users/Scottmitch/repos","events_url":"https://api.github.com/users/Scottmitch/events{/privacy}","received_events_url":"https://api.github.com/users/Scottmitch/received_events","type":"User","site_admin":false},"body":"Motivation:\r\nThe HTTP/2 codec does not supply an interface which facilitates doing data write compression.\r\nCompressing data is anticipated to be a common use case and this feature is thus anticipated to be useful.\r\n\r\nModifications:\r\n-Restructure the AbstractHttp2ConnectionHandler class to be able to extend write behavior before the outbound flow control gets the data\r\n-Add classes which override the newly restructured interfaces to provide an extensible compression interface\r\n-Add unit tests to test the new capability\r\n\r\nResult:\r\nHTTP/2 codec provides an interface (and default implementation) for data write compression.","created_at":"2014-09-24T04:21:41Z","updated_at":"2014-09-24T15:10:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4cdca4b8a14cafb98a656f804df8bb94af875940","assignee":{"login":"Scottmitch","id":7562868,"avatar_url":"https://avatars.githubusercontent.com/u/7562868?v=2","gravatar_id":"","url":"https://api.github.com/users/Scottmitch","html_url":"https://github.com/Scottmitch","followers_url":"https://api.github.com/users/Scottmitch/followers","following_url":"https://api.github.com/users/Scottmitch/following{/other_user}","gists_url":"https://api.github.com/users/Scottmitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Scottmitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Scottmitch/subscriptions","organizations_url":"https://api.github.com/users/Scottmitch/orgs","repos_url":"https://api.github.com/users/Scottmitch/repos","events_url":"https://api.github.com/users/Scottmitch/events{/privacy}","received_events_url":"https://api.github.com/users/Scottmitch/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/netty/netty/milestones/105","labels_url":"https://api.github.com/repos/netty/netty/milestones/105/labels","id":800277,"number":105,"title":"5.0.0.Alpha3","description":"","creator":{"login":"Scottmitch","id":7562868,"avatar_url":"https://avatars.githubusercontent.com/u/7562868?v=2","gravatar_id":"","url":"https://api.github.com/users/Scottmitch","html_url":"https://github.com/Scottmitch","followers_url":"https://api.github.com/users/Scottmitch/followers","following_url":"https://api.github.com/users/Scottmitch/following{/other_user}","gists_url":"https://api.github.com/users/Scottmitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Scottmitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Scottmitch/subscriptions","organizations_url":"https://api.github.com/users/Scottmitch/orgs","repos_url":"https://api.github.com/users/Scottmitch/repos","events_url":"https://api.github.com/users/Scottmitch/events{/privacy}","received_events_url":"https://api.github.com/users/Scottmitch/received_events","type":"User","site_admin":false},"open_issues":49,"closed_issues":0,"state":"open","created_at":"2014-09-23T19:48:30Z","updated_at":"2014-09-24T04:21:50Z","due_on":null},"commits_url":"https://api.github.com/repos/netty/netty/pulls/2935/commits","review_comments_url":"https://api.github.com/repos/netty/netty/pulls/2935/comments","review_comment_url":"https://api.github.com/repos/netty/netty/pulls/comments/{number}","comments_url":"https://api.github.com/repos/netty/netty/issues/2935/comments","statuses_url":"https://api.github.com/repos/netty/netty/statuses/005a47bee9eacb2842d2d812dcfb852564864383","head":{"label":"akamai:http2_compression","ref":"http2_compression","sha":"005a47bee9eacb2842d2d812dcfb852564864383","user":{"login":"akamai","id":7504551,"avatar_url":"https://avatars.githubusercontent.com/u/7504551?v=2","gravatar_id":"","url":"https://api.github.com/users/akamai","html_url":"https://github.com/akamai","followers_url":"https://api.github.com/users/akamai/followers","following_url":"https://api.github.com/users/akamai/following{/other_user}","gists_url":"https://api.github.com/users/akamai/gists{/gist_id}","starred_url":"https://api.github.com/users/akamai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akamai/subscriptions","organizations_url":"https://api.github.com/users/akamai/orgs","repos_url":"https://api.github.com/users/akamai/repos","events_url":"https://api.github.com/users/akamai/events{/privacy}","received_events_url":"https://api.github.com/users/akamai/received_events","type":"Organization","site_admin":false},"repo":{"id":22530159,"name":"netty","full_name":"akamai/netty","owner":{"login":"akamai","id":7504551,"avatar_url":"https://avatars.githubusercontent.com/u/7504551?v=2","gravatar_id":"","url":"https://api.github.com/users/akamai","html_url":"https://github.com/akamai","followers_url":"https://api.github.com/users/akamai/followers","following_url":"https://api.github.com/users/akamai/following{/other_user}","gists_url":"https://api.github.com/users/akamai/gists{/gist_id}","starred_url":"https://api.github.com/users/akamai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akamai/subscriptions","organizations_url":"https://api.github.com/users/akamai/orgs","repos_url":"https://api.github.com/users/akamai/repos","events_url":"https://api.github.com/users/akamai/events{/privacy}","received_events_url":"https://api.github.com/users/akamai/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akamai/netty","description":"Netty project - an event-driven asynchronous network application framework","fork":true,"url":"https://api.github.com/repos/akamai/netty","forks_url":"https://api.github.com/repos/akamai/netty/forks","keys_url":"https://api.github.com/repos/akamai/netty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akamai/netty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akamai/netty/teams","hooks_url":"https://api.github.com/repos/akamai/netty/hooks","issue_events_url":"https://api.github.com/repos/akamai/netty/issues/events{/number}","events_url":"https://api.github.com/repos/akamai/netty/events","assignees_url":"https://api.github.com/repos/akamai/netty/assignees{/user}","branches_url":"https://api.github.com/repos/akamai/netty/branches{/branch}","tags_url":"https://api.github.com/repos/akamai/netty/tags","blobs_url":"https://api.github.com/repos/akamai/netty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akamai/netty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akamai/netty/git/refs{/sha}","trees_url":"https://api.github.com/repos/akamai/netty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akamai/netty/statuses/{sha}","languages_url":"https://api.github.com/repos/akamai/netty/languages","stargazers_url":"https://api.github.com/repos/akamai/netty/stargazers","contributors_url":"https://api.github.com/repos/akamai/netty/contributors","subscribers_url":"https://api.github.com/repos/akamai/netty/subscribers","subscription_url":"https://api.github.com/repos/akamai/netty/subscription","commits_url":"https://api.github.com/repos/akamai/netty/commits{/sha}","git_commits_url":"https://api.github.com/repos/akamai/netty/git/commits{/sha}","comments_url":"https://api.github.com/repos/akamai/netty/comments{/number}","issue_comment_url":"https://api.github.com/repos/akamai/netty/issues/comments/{number}","contents_url":"https://api.github.com/repos/akamai/netty/contents/{+path}","compare_url":"https://api.github.com/repos/akamai/netty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akamai/netty/merges","archive_url":"https://api.github.com/repos/akamai/netty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akamai/netty/downloads","issues_url":"https://api.github.com/repos/akamai/netty/issues{/number}","pulls_url":"https://api.github.com/repos/akamai/netty/pulls{/number}","milestones_url":"https://api.github.com/repos/akamai/netty/milestones{/number}","notifications_url":"https://api.github.com/repos/akamai/netty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akamai/netty/labels{/name}","releases_url":"https://api.github.com/repos/akamai/netty/releases{/id}","created_at":"2014-08-01T21:49:13Z","updated_at":"2014-08-15T17:45:13Z","pushed_at":"2014-09-24T04:21:09Z","git_url":"git://github.com/akamai/netty.git","ssh_url":"git@github.com:akamai/netty.git","clone_url":"https://github.com/akamai/netty.git","svn_url":"https://github.com/akamai/netty","homepage":"http://netty.io/","size":36261,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"netty:master","ref":"master","sha":"fc273ccbf0bbe62572ff74b929796f10f06d11fe","user":{"login":"netty","id":473791,"avatar_url":"https://avatars.githubusercontent.com/u/473791?v=2","gravatar_id":"","url":"https://api.github.com/users/netty","html_url":"https://github.com/netty","followers_url":"https://api.github.com/users/netty/followers","following_url":"https://api.github.com/users/netty/following{/other_user}","gists_url":"https://api.github.com/users/netty/gists{/gist_id}","starred_url":"https://api.github.com/users/netty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netty/subscriptions","organizations_url":"https://api.github.com/users/netty/orgs","repos_url":"https://api.github.com/users/netty/repos","events_url":"https://api.github.com/users/netty/events{/privacy}","received_events_url":"https://api.github.com/users/netty/received_events","type":"Organization","site_admin":false},"repo":{"id":1064563,"name":"netty","full_name":"netty/netty","owner":{"login":"netty","id":473791,"avatar_url":"https://avatars.githubusercontent.com/u/473791?v=2","gravatar_id":"","url":"https://api.github.com/users/netty","html_url":"https://github.com/netty","followers_url":"https://api.github.com/users/netty/followers","following_url":"https://api.github.com/users/netty/following{/other_user}","gists_url":"https://api.github.com/users/netty/gists{/gist_id}","starred_url":"https://api.github.com/users/netty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netty/subscriptions","organizations_url":"https://api.github.com/users/netty/orgs","repos_url":"https://api.github.com/users/netty/repos","events_url":"https://api.github.com/users/netty/events{/privacy}","received_events_url":"https://api.github.com/users/netty/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/netty/netty","description":"Netty project - an event-driven asynchronous network application framework","fork":false,"url":"https://api.github.com/repos/netty/netty","forks_url":"https://api.github.com/repos/netty/netty/forks","keys_url":"https://api.github.com/repos/netty/netty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/netty/netty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/netty/netty/teams","hooks_url":"https://api.github.com/repos/netty/netty/hooks","issue_events_url":"https://api.github.com/repos/netty/netty/issues/events{/number}","events_url":"https://api.github.com/repos/netty/netty/events","assignees_url":"https://api.github.com/repos/netty/netty/assignees{/user}","branches_url":"https://api.github.com/repos/netty/netty/branches{/branch}","tags_url":"https://api.github.com/repos/netty/netty/tags","blobs_url":"https://api.github.com/repos/netty/netty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/netty/netty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/netty/netty/git/refs{/sha}","trees_url":"https://api.github.com/repos/netty/netty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/netty/netty/statuses/{sha}","languages_url":"https://api.github.com/repos/netty/netty/languages","stargazers_url":"https://api.github.com/repos/netty/netty/stargazers","contributors_url":"https://api.github.com/repos/netty/netty/contributors","subscribers_url":"https://api.github.com/repos/netty/netty/subscribers","subscription_url":"https://api.github.com/repos/netty/netty/subscription","commits_url":"https://api.github.com/repos/netty/netty/commits{/sha}","git_commits_url":"https://api.github.com/repos/netty/netty/git/commits{/sha}","comments_url":"https://api.github.com/repos/netty/netty/comments{/number}","issue_comment_url":"https://api.github.com/repos/netty/netty/issues/comments/{number}","contents_url":"https://api.github.com/repos/netty/netty/contents/{+path}","compare_url":"https://api.github.com/repos/netty/netty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/netty/netty/merges","archive_url":"https://api.github.com/repos/netty/netty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/netty/netty/downloads","issues_url":"https://api.github.com/repos/netty/netty/issues{/number}","pulls_url":"https://api.github.com/repos/netty/netty/pulls{/number}","milestones_url":"https://api.github.com/repos/netty/netty/milestones{/number}","notifications_url":"https://api.github.com/repos/netty/netty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/netty/netty/labels{/name}","releases_url":"https://api.github.com/repos/netty/netty/releases{/id}","created_at":"2010-11-09T09:22:21Z","updated_at":"2014-09-24T14:17:09Z","pushed_at":"2014-09-24T06:00:12Z","git_url":"git://github.com/netty/netty.git","ssh_url":"git@github.com:netty/netty.git","clone_url":"https://github.com/netty/netty.git","svn_url":"https://github.com/netty/netty","homepage":"http://netty.io/","size":116170,"stargazers_count":3550,"watchers_count":3550,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1662,"mirror_url":null,"open_issues_count":164,"forks":1662,"open_issues":164,"watchers":3550,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/netty/netty/pulls/2935"},"html":{"href":"https://github.com/netty/netty/pull/2935"},"issue":{"href":"https://api.github.com/repos/netty/netty/issues/2935"},"comments":{"href":"https://api.github.com/repos/netty/netty/issues/2935/comments"},"review_comments":{"href":"https://api.github.com/repos/netty/netty/pulls/2935/comments"},"review_comment":{"href":"https://api.github.com/repos/netty/netty/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/netty/netty/pulls/2935/commits"},"statuses":{"href":"https://api.github.com/repos/netty/netty/statuses/005a47bee9eacb2842d2d812dcfb852564864383"}}}}