GitHub PullRequestReviewCommentEvent at 2014-09-25 08:15:52
Repository: split
Actor: houndci
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/econsultancy/split/pulls/comments/18019643","id":18019643,"diff_hunk":"@@ -4,20 +4,20 @@\n \n   it \"should return an algorithm\" do\n     experiment = Split::Experiment.find_or_create('link_color', {'blue' => 1}, {'red' => 1 })\n-    Split::Algorithms::Whiplash.choose_alternative(experiment).class.should == Split::Alternative\n+    expect(Split::Algorithms::Whiplash.choose_alternative(experiment).class).to eq(Split::Alternative)\n   end\n \n   it \"should return one of the results\" do\n     experiment = Split::Experiment.find_or_create('link_color', {'blue' => 1}, {'red' => 1 })\n-    ['red', 'blue'].should include Split::Algorithms::Whiplash.choose_alternative(experiment).name\n+    expect(['red', 'blue']).to include Split::Algorithms::Whiplash.choose_alternative(experiment).name\n   end\n \n   it \"should guess floats\" do\n-    Split::Algorithms::Whiplash.send(:arm_guess, 0, 0).class.should == Float\n-    Split::Algorithms::Whiplash.send(:arm_guess, 1, 0).class.should == Float\n-    Split::Algorithms::Whiplash.send(:arm_guess, 2, 1).class.should == Float\n-    Split::Algorithms::Whiplash.send(:arm_guess, 1000, 5).class.should == Float\n-    Split::Algorithms::Whiplash.send(:arm_guess, 10, -2).class.should == Float\n+    expect(Split::Algorithms::Whiplash.send(:arm_guess, 0, 0).class).to eq(Float)\n+    expect(Split::Algorithms::Whiplash.send(:arm_guess, 1, 0).class).to eq(Float)\n+    expect(Split::Algorithms::Whiplash.send(:arm_guess, 2, 1).class).to eq(Float)\n+    expect(Split::Algorithms::Whiplash.send(:arm_guess, 1000, 5).class).to eq(Float)","path":"spec/algorithms/whiplash_spec.rb","position":23,"original_position":23,"commit_id":"4f304c807bdcadd549d3dcca7c478594cb26b19f","original_commit_id":"4f304c807bdcadd549d3dcca7c478594cb26b19f","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=2","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Line is too long. [84/80]","created_at":"2014-09-25T08:15:52Z","updated_at":"2014-09-25T08:15:52Z","html_url":"https://github.com/econsultancy/split/pull/1#discussion_r18019643","pull_request_url":"https://api.github.com/repos/econsultancy/split/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/econsultancy/split/pulls/comments/18019643"},"html":{"href":"https://github.com/econsultancy/split/pull/1#discussion_r18019643"},"pull_request":{"href":"https://api.github.com/repos/econsultancy/split/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/econsultancy/split/pulls/1","id":14801981,"html_url":"https://github.com/econsultancy/split/pull/1","diff_url":"https://github.com/econsultancy/split/pull/1.diff","patch_url":"https://github.com/econsultancy/split/pull/1.patch","issue_url":"https://api.github.com/repos/econsultancy/split/issues/1","number":1,"state":"open","locked":false,"title":"Upstream changes","user":{"login":"forkbot","id":6198419,"avatar_url":"https://avatars.githubusercontent.com/u/6198419?v=2","gravatar_id":"","url":"https://api.github.com/users/forkbot","html_url":"https://github.com/forkbot","followers_url":"https://api.github.com/users/forkbot/followers","following_url":"https://api.github.com/users/forkbot/following{/other_user}","gists_url":"https://api.github.com/users/forkbot/gists{/gist_id}","starred_url":"https://api.github.com/users/forkbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forkbot/subscriptions","organizations_url":"https://api.github.com/users/forkbot/orgs","repos_url":"https://api.github.com/users/forkbot/repos","events_url":"https://api.github.com/users/forkbot/events{/privacy}","received_events_url":"https://api.github.com/users/forkbot/received_events","type":"User","site_admin":false},"body":"Automatically opened by http://forkbomb.io","created_at":"2014-04-16T01:01:41Z","updated_at":"2014-09-25T08:15:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"36c9921f978af0b10fc2fd1b5ac4f58e0e91efcc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/econsultancy/split/pulls/1/commits","review_comments_url":"https://api.github.com/repos/econsultancy/split/pulls/1/comments","review_comment_url":"https://api.github.com/repos/econsultancy/split/pulls/comments/{number}","comments_url":"https://api.github.com/repos/econsultancy/split/issues/1/comments","statuses_url":"https://api.github.com/repos/econsultancy/split/statuses/4f304c807bdcadd549d3dcca7c478594cb26b19f","head":{"label":"andrew:master","ref":"master","sha":"4f304c807bdcadd549d3dcca7c478594cb26b19f","user":{"login":"andrew","id":1060,"avatar_url":"https://avatars.githubusercontent.com/u/1060?v=2","gravatar_id":"","url":"https://api.github.com/users/andrew","html_url":"https://github.com/andrew","followers_url":"https://api.github.com/users/andrew/followers","following_url":"https://api.github.com/users/andrew/following{/other_user}","gists_url":"https://api.github.com/users/andrew/gists{/gist_id}","starred_url":"https://api.github.com/users/andrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrew/subscriptions","organizations_url":"https://api.github.com/users/andrew/orgs","repos_url":"https://api.github.com/users/andrew/repos","events_url":"https://api.github.com/users/andrew/events{/privacy}","received_events_url":"https://api.github.com/users/andrew/received_events","type":"User","site_admin":false},"repo":{"id":1748446,"name":"split","full_name":"andrew/split","owner":{"login":"andrew","id":1060,"avatar_url":"https://avatars.githubusercontent.com/u/1060?v=2","gravatar_id":"","url":"https://api.github.com/users/andrew","html_url":"https://github.com/andrew","followers_url":"https://api.github.com/users/andrew/followers","following_url":"https://api.github.com/users/andrew/following{/other_user}","gists_url":"https://api.github.com/users/andrew/gists{/gist_id}","starred_url":"https://api.github.com/users/andrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrew/subscriptions","organizations_url":"https://api.github.com/users/andrew/orgs","repos_url":"https://api.github.com/users/andrew/repos","events_url":"https://api.github.com/users/andrew/events{/privacy}","received_events_url":"https://api.github.com/users/andrew/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andrew/split","description":"The Rack Based AB testing framework","fork":false,"url":"https://api.github.com/repos/andrew/split","forks_url":"https://api.github.com/repos/andrew/split/forks","keys_url":"https://api.github.com/repos/andrew/split/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andrew/split/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andrew/split/teams","hooks_url":"https://api.github.com/repos/andrew/split/hooks","issue_events_url":"https://api.github.com/repos/andrew/split/issues/events{/number}","events_url":"https://api.github.com/repos/andrew/split/events","assignees_url":"https://api.github.com/repos/andrew/split/assignees{/user}","branches_url":"https://api.github.com/repos/andrew/split/branches{/branch}","tags_url":"https://api.github.com/repos/andrew/split/tags","blobs_url":"https://api.github.com/repos/andrew/split/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andrew/split/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andrew/split/git/refs{/sha}","trees_url":"https://api.github.com/repos/andrew/split/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andrew/split/statuses/{sha}","languages_url":"https://api.github.com/repos/andrew/split/languages","stargazers_url":"https://api.github.com/repos/andrew/split/stargazers","contributors_url":"https://api.github.com/repos/andrew/split/contributors","subscribers_url":"https://api.github.com/repos/andrew/split/subscribers","subscription_url":"https://api.github.com/repos/andrew/split/subscription","commits_url":"https://api.github.com/repos/andrew/split/commits{/sha}","git_commits_url":"https://api.github.com/repos/andrew/split/git/commits{/sha}","comments_url":"https://api.github.com/repos/andrew/split/comments{/number}","issue_comment_url":"https://api.github.com/repos/andrew/split/issues/comments/{number}","contents_url":"https://api.github.com/repos/andrew/split/contents/{+path}","compare_url":"https://api.github.com/repos/andrew/split/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andrew/split/merges","archive_url":"https://api.github.com/repos/andrew/split/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andrew/split/downloads","issues_url":"https://api.github.com/repos/andrew/split/issues{/number}","pulls_url":"https://api.github.com/repos/andrew/split/pulls{/number}","milestones_url":"https://api.github.com/repos/andrew/split/milestones{/number}","notifications_url":"https://api.github.com/repos/andrew/split/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andrew/split/labels{/name}","releases_url":"https://api.github.com/repos/andrew/split/releases{/id}","created_at":"2011-05-14T18:05:47Z","updated_at":"2014-09-20T14:08:39Z","pushed_at":"2014-09-25T08:15:40Z","git_url":"git://github.com/andrew/split.git","ssh_url":"git@github.com:andrew/split.git","clone_url":"https://github.com/andrew/split.git","svn_url":"https://github.com/andrew/split","homepage":"https://rubygems.org/gems/split","size":3237,"stargazers_count":1253,"watchers_count":1253,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":163,"mirror_url":null,"open_issues_count":45,"forks":163,"open_issues":45,"watchers":1253,"default_branch":"master"}},"base":{"label":"econsultancy:master","ref":"master","sha":"9ec43fa278e057164b16175db40c1584cf2f0c70","user":{"login":"econsultancy","id":12679,"avatar_url":"https://avatars.githubusercontent.com/u/12679?v=2","gravatar_id":"","url":"https://api.github.com/users/econsultancy","html_url":"https://github.com/econsultancy","followers_url":"https://api.github.com/users/econsultancy/followers","following_url":"https://api.github.com/users/econsultancy/following{/other_user}","gists_url":"https://api.github.com/users/econsultancy/gists{/gist_id}","starred_url":"https://api.github.com/users/econsultancy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/econsultancy/subscriptions","organizations_url":"https://api.github.com/users/econsultancy/orgs","repos_url":"https://api.github.com/users/econsultancy/repos","events_url":"https://api.github.com/users/econsultancy/events{/privacy}","received_events_url":"https://api.github.com/users/econsultancy/received_events","type":"Organization","site_admin":false},"repo":{"id":2734599,"name":"split","full_name":"econsultancy/split","owner":{"login":"econsultancy","id":12679,"avatar_url":"https://avatars.githubusercontent.com/u/12679?v=2","gravatar_id":"","url":"https://api.github.com/users/econsultancy","html_url":"https://github.com/econsultancy","followers_url":"https://api.github.com/users/econsultancy/followers","following_url":"https://api.github.com/users/econsultancy/following{/other_user}","gists_url":"https://api.github.com/users/econsultancy/gists{/gist_id}","starred_url":"https://api.github.com/users/econsultancy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/econsultancy/subscriptions","organizations_url":"https://api.github.com/users/econsultancy/orgs","repos_url":"https://api.github.com/users/econsultancy/repos","events_url":"https://api.github.com/users/econsultancy/events{/privacy}","received_events_url":"https://api.github.com/users/econsultancy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/econsultancy/split","description":"Rack Based AB testing framework","fork":true,"url":"https://api.github.com/repos/econsultancy/split","forks_url":"https://api.github.com/repos/econsultancy/split/forks","keys_url":"https://api.github.com/repos/econsultancy/split/keys{/key_id}","collaborators_url":"https://api.github.com/repos/econsultancy/split/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/econsultancy/split/teams","hooks_url":"https://api.github.com/repos/econsultancy/split/hooks","issue_events_url":"https://api.github.com/repos/econsultancy/split/issues/events{/number}","events_url":"https://api.github.com/repos/econsultancy/split/events","assignees_url":"https://api.github.com/repos/econsultancy/split/assignees{/user}","branches_url":"https://api.github.com/repos/econsultancy/split/branches{/branch}","tags_url":"https://api.github.com/repos/econsultancy/split/tags","blobs_url":"https://api.github.com/repos/econsultancy/split/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/econsultancy/split/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/econsultancy/split/git/refs{/sha}","trees_url":"https://api.github.com/repos/econsultancy/split/git/trees{/sha}","statuses_url":"https://api.github.com/repos/econsultancy/split/statuses/{sha}","languages_url":"https://api.github.com/repos/econsultancy/split/languages","stargazers_url":"https://api.github.com/repos/econsultancy/split/stargazers","contributors_url":"https://api.github.com/repos/econsultancy/split/contributors","subscribers_url":"https://api.github.com/repos/econsultancy/split/subscribers","subscription_url":"https://api.github.com/repos/econsultancy/split/subscription","commits_url":"https://api.github.com/repos/econsultancy/split/commits{/sha}","git_commits_url":"https://api.github.com/repos/econsultancy/split/git/commits{/sha}","comments_url":"https://api.github.com/repos/econsultancy/split/comments{/number}","issue_comment_url":"https://api.github.com/repos/econsultancy/split/issues/comments/{number}","contents_url":"https://api.github.com/repos/econsultancy/split/contents/{+path}","compare_url":"https://api.github.com/repos/econsultancy/split/compare/{base}...{head}","merges_url":"https://api.github.com/repos/econsultancy/split/merges","archive_url":"https://api.github.com/repos/econsultancy/split/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/econsultancy/split/downloads","issues_url":"https://api.github.com/repos/econsultancy/split/issues{/number}","pulls_url":"https://api.github.com/repos/econsultancy/split/pulls{/number}","milestones_url":"https://api.github.com/repos/econsultancy/split/milestones{/number}","notifications_url":"https://api.github.com/repos/econsultancy/split/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/econsultancy/split/labels{/name}","releases_url":"https://api.github.com/repos/econsultancy/split/releases{/id}","created_at":"2011-11-08T15:16:49Z","updated_at":"2014-03-12T16:55:49Z","pushed_at":"2014-03-12T16:55:50Z","git_url":"git://github.com/econsultancy/split.git","ssh_url":"git@github.com:econsultancy/split.git","clone_url":"https://github.com/econsultancy/split.git","svn_url":"https://github.com/econsultancy/split","homepage":"https://rubygems.org/gems/split","size":864,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/econsultancy/split/pulls/1"},"html":{"href":"https://github.com/econsultancy/split/pull/1"},"issue":{"href":"https://api.github.com/repos/econsultancy/split/issues/1"},"comments":{"href":"https://api.github.com/repos/econsultancy/split/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/econsultancy/split/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/econsultancy/split/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/econsultancy/split/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/econsultancy/split/statuses/4f304c807bdcadd549d3dcca7c478594cb26b19f"}}}}