GitHub PullRequestReviewCommentEvent at 2014-07-27 00:44:11
Repository: angular.js
Actor: IgorMinar
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular.js/pulls/comments/15436609","id":15436609,"diff_hunk":"@@ -1046,6 +1046,73 @@ describe('$route', function() {\n       });\n     });\n \n+    describe('update', function() {\n+      it('should support single-parameter route updating', function() {\n+        var routeChangeSpy = jasmine.createSpy('route change');\n+\n+        module(function($routeProvider) {\n+          $routeProvider.when('/bar/:barId', {controller: angular.noop});\n+        });\n+\n+        inject(function($route, $routeParams, $location, $rootScope) {\n+          $rootScope.$on('$routeChangeSuccess', routeChangeSpy);\n+\n+          $location.path('/bar/1');\n+          $rootScope.$digest();\n+          routeChangeSpy.reset();\n+\n+          $route.update({barId: '2'});\n+          $rootScope.$digest();\n+\n+          expect($routeParams).toEqual({barId: '2'});\n+          expect(routeChangeSpy).toHaveBeenCalledOnce();\n+        });\n+      });\n+\n+      it('should support total multi-parameter route updating', function() {\n+        var routeChangeSpy = jasmine.createSpy('route change');\n+\n+        module(function($routeProvider) {\n+          $routeProvider.when('/bar/:barId/:fooId/:spamId/:eggId', {controller: angular.noop});\n+        });\n+\n+        inject(function($route, $routeParams, $location, $rootScope) {\n+          $rootScope.$on('$routeChangeSuccess', routeChangeSpy);\n+\n+          $location.path('/bar/1/1/1/1');\n+          $rootScope.$digest();\n+          routeChangeSpy.reset();\n+\n+          $route.update({barId: '2', fooId: '2', spamId: '2', eggId: '2'});\n+          $rootScope.$digest();\n+\n+          expect($routeParams).toEqual({barId: '2', fooId: '2', spamId: '2', eggId: '2'});\n+          expect(routeChangeSpy).toHaveBeenCalledOnce();\n+        });\n+      });\n+\n+      it('should support partial multi-parameter route updating', function() {\n+        var routeChangeSpy = jasmine.createSpy('route change');\n+\n+        module(function($routeProvider) {\n+          $routeProvider.when('/bar/:barId/:fooId/:spamId/:eggId', {controller: angular.noop});\n+        });\n+\n+        inject(function($route, $routeParams, $location, $rootScope) {\n+          $rootScope.$on('$routeChangeSuccess', routeChangeSpy);\n+\n+          $location.path('/bar/1/1/1/1');\n+          $rootScope.$digest();\n+          routeChangeSpy.reset();\n+\n+          $route.update({barId: '2', fooId: '2'});\n+          $rootScope.$digest();\n+\n+          expect($routeParams).toEqual({barId: '2', fooId: '2', spamId: '1', eggId: '1'});","path":"test/ngRoute/routeSpec.js","position":66,"original_position":66,"commit_id":"fb0cc849a64bbea415416e130e94e7bf2e086717","original_commit_id":"fb0cc849a64bbea415416e130e94e7bf2e086717","user":{"login":"IgorMinar","id":216296,"avatar_url":"https://avatars.githubusercontent.com/u/216296?","gravatar_id":"fc5dc0d579fb554752763792a2d5f449","url":"https://api.github.com/users/IgorMinar","html_url":"https://github.com/IgorMinar","followers_url":"https://api.github.com/users/IgorMinar/followers","following_url":"https://api.github.com/users/IgorMinar/following{/other_user}","gists_url":"https://api.github.com/users/IgorMinar/gists{/gist_id}","starred_url":"https://api.github.com/users/IgorMinar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IgorMinar/subscriptions","organizations_url":"https://api.github.com/users/IgorMinar/orgs","repos_url":"https://api.github.com/users/IgorMinar/repos","events_url":"https://api.github.com/users/IgorMinar/events{/privacy}","received_events_url":"https://api.github.com/users/IgorMinar/received_events","type":"User","site_admin":false},"body":"can you also assert that $location was updated correctly as well?","created_at":"2014-07-27T00:44:11Z","updated_at":"2014-07-27T00:44:11Z","html_url":"https://github.com/angular/angular.js/pull/8358#discussion_r15436609","pull_request_url":"https://api.github.com/repos/angular/angular.js/pulls/8358","_links":{"self":{"href":"https://api.github.com/repos/angular/angular.js/pulls/comments/15436609"},"html":{"href":"https://github.com/angular/angular.js/pull/8358#discussion_r15436609"},"pull_request":{"href":"https://api.github.com/repos/angular/angular.js/pulls/8358"}}},"pull_request":{"url":"https://api.github.com/repos/angular/angular.js/pulls/8358","id":18936290,"html_url":"https://github.com/angular/angular.js/pull/8358","diff_url":"https://github.com/angular/angular.js/pull/8358.diff","patch_url":"https://github.com/angular/angular.js/pull/8358.patch","issue_url":"https://api.github.com/repos/angular/angular.js/issues/8358","number":8358,"state":"open","title":"feat(ngRoute): add method for changing url params","user":{"login":"NotBobTheBuilder","id":1965587,"avatar_url":"https://avatars.githubusercontent.com/u/1965587?","gravatar_id":"47e1497317b7b5dc185869392f0a4451","url":"https://api.github.com/users/NotBobTheBuilder","html_url":"https://github.com/NotBobTheBuilder","followers_url":"https://api.github.com/users/NotBobTheBuilder/followers","following_url":"https://api.github.com/users/NotBobTheBuilder/following{/other_user}","gists_url":"https://api.github.com/users/NotBobTheBuilder/gists{/gist_id}","starred_url":"https://api.github.com/users/NotBobTheBuilder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NotBobTheBuilder/subscriptions","organizations_url":"https://api.github.com/users/NotBobTheBuilder/orgs","repos_url":"https://api.github.com/users/NotBobTheBuilder/repos","events_url":"https://api.github.com/users/NotBobTheBuilder/events{/privacy}","received_events_url":"https://api.github.com/users/NotBobTheBuilder/received_events","type":"User","site_admin":false},"body":"Request Type: feature\n\nHow to reproduce: \n\nComponent(s): ngRoute\n\nImpact: medium\n\nComplexity: small\n\nThis issue is related to: \n\n**Detailed Description:**\n\nAdd a `$route#update` method for changing the current route\nparameters without having to manually build a URL and call `$location#path`.\nUseful for apps with a structure involving programmatically moving\nbetween pages on the same route, but with different `:param`\nvalues.\n\n**Other Comments:**\n\n","created_at":"2014-07-26T23:41:30Z","updated_at":"2014-07-27T00:44:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1aaea3752474af7db9b6345e1dff94dcad2e614b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/angular/angular.js/pulls/8358/commits","review_comments_url":"https://api.github.com/repos/angular/angular.js/pulls/8358/comments","review_comment_url":"https://api.github.com/repos/angular/angular.js/pulls/comments/{number}","comments_url":"https://api.github.com/repos/angular/angular.js/issues/8358/comments","statuses_url":"https://api.github.com/repos/angular/angular.js/statuses/fb0cc849a64bbea415416e130e94e7bf2e086717","head":{"label":"NotBobTheBuilder:ng-route-update-method","ref":"ng-route-update-method","sha":"fb0cc849a64bbea415416e130e94e7bf2e086717","user":{"login":"NotBobTheBuilder","id":1965587,"avatar_url":"https://avatars.githubusercontent.com/u/1965587?","gravatar_id":"47e1497317b7b5dc185869392f0a4451","url":"https://api.github.com/users/NotBobTheBuilder","html_url":"https://github.com/NotBobTheBuilder","followers_url":"https://api.github.com/users/NotBobTheBuilder/followers","following_url":"https://api.github.com/users/NotBobTheBuilder/following{/other_user}","gists_url":"https://api.github.com/users/NotBobTheBuilder/gists{/gist_id}","starred_url":"https://api.github.com/users/NotBobTheBuilder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NotBobTheBuilder/subscriptions","organizations_url":"https://api.github.com/users/NotBobTheBuilder/orgs","repos_url":"https://api.github.com/users/NotBobTheBuilder/repos","events_url":"https://api.github.com/users/NotBobTheBuilder/events{/privacy}","received_events_url":"https://api.github.com/users/NotBobTheBuilder/received_events","type":"User","site_admin":false},"repo":{"id":22283329,"name":"angular.js","full_name":"NotBobTheBuilder/angular.js","owner":{"login":"NotBobTheBuilder","id":1965587,"avatar_url":"https://avatars.githubusercontent.com/u/1965587?","gravatar_id":"47e1497317b7b5dc185869392f0a4451","url":"https://api.github.com/users/NotBobTheBuilder","html_url":"https://github.com/NotBobTheBuilder","followers_url":"https://api.github.com/users/NotBobTheBuilder/followers","following_url":"https://api.github.com/users/NotBobTheBuilder/following{/other_user}","gists_url":"https://api.github.com/users/NotBobTheBuilder/gists{/gist_id}","starred_url":"https://api.github.com/users/NotBobTheBuilder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NotBobTheBuilder/subscriptions","organizations_url":"https://api.github.com/users/NotBobTheBuilder/orgs","repos_url":"https://api.github.com/users/NotBobTheBuilder/repos","events_url":"https://api.github.com/users/NotBobTheBuilder/events{/privacy}","received_events_url":"https://api.github.com/users/NotBobTheBuilder/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/NotBobTheBuilder/angular.js","description":"HTML enhanced for web apps","fork":true,"url":"https://api.github.com/repos/NotBobTheBuilder/angular.js","forks_url":"https://api.github.com/repos/NotBobTheBuilder/angular.js/forks","keys_url":"https://api.github.com/repos/NotBobTheBuilder/angular.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NotBobTheBuilder/angular.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NotBobTheBuilder/angular.js/teams","hooks_url":"https://api.github.com/repos/NotBobTheBuilder/angular.js/hooks","issue_events_url":"https://api.github.com/repos/NotBobTheBuilder/angular.js/issues/events{/number}","events_url":"https://api.github.com/repos/NotBobTheBuilder/angular.js/events","assignees_url":"https://api.github.com/repos/NotBobTheBuilder/angular.js/assignees{/user}","branches_url":"https://api.github.com/repos/NotBobTheBuilder/angular.js/branches{/branch}","tags_url":"https://api.github.com/repos/NotBobTheBuilder/angular.js/tags","blobs_url":"https://api.github.com/repos/NotBobTheBuilder/angular.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NotBobTheBuilder/angular.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NotBobTheBuilder/angular.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/NotBobTheBuilder/angular.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NotBobTheBuilder/angular.js/statuses/{sha}","languages_url":"https://api.github.com/repos/NotBobTheBuilder/angular.js/languages","stargazers_url":"https://api.github.com/repos/NotBobTheBuilder/angular.js/stargazers","contributors_url":"https://api.github.com/repos/NotBobTheBuilder/angular.js/contributors","subscribers_url":"https://api.github.com/repos/NotBobTheBuilder/angular.js/subscribers","subscription_url":"https://api.github.com/repos/NotBobTheBuilder/angular.js/subscription","commits_url":"https://api.github.com/repos/NotBobTheBuilder/angular.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/NotBobTheBuilder/angular.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/NotBobTheBuilder/angular.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/NotBobTheBuilder/angular.js/issues/comments/{number}","contents_url":"https://api.github.com/repos/NotBobTheBuilder/angular.js/contents/{+path}","compare_url":"https://api.github.com/repos/NotBobTheBuilder/angular.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NotBobTheBuilder/angular.js/merges","archive_url":"https://api.github.com/repos/NotBobTheBuilder/angular.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NotBobTheBuilder/angular.js/downloads","issues_url":"https://api.github.com/repos/NotBobTheBuilder/angular.js/issues{/number}","pulls_url":"https://api.github.com/repos/NotBobTheBuilder/angular.js/pulls{/number}","milestones_url":"https://api.github.com/repos/NotBobTheBuilder/angular.js/milestones{/number}","notifications_url":"https://api.github.com/repos/NotBobTheBuilder/angular.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NotBobTheBuilder/angular.js/labels{/name}","releases_url":"https://api.github.com/repos/NotBobTheBuilder/angular.js/releases{/id}","created_at":"2014-07-26T10:03:32Z","updated_at":"2014-07-26T09:39:58Z","pushed_at":"2014-07-26T23:52:32Z","git_url":"git://github.com/NotBobTheBuilder/angular.js.git","ssh_url":"git@github.com:NotBobTheBuilder/angular.js.git","clone_url":"https://github.com/NotBobTheBuilder/angular.js.git","svn_url":"https://github.com/NotBobTheBuilder/angular.js","homepage":"http://angularjs.org","size":199796,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"ccc3255fea11cbdee0d45d301a2fc13fa899228e","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?","gravatar_id":"f0d91e5cf8ad1ce7972cc486baa20c42","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":460078,"name":"angular.js","full_name":"angular/angular.js","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?","gravatar_id":"f0d91e5cf8ad1ce7972cc486baa20c42","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular.js","description":"HTML enhanced for web apps","fork":false,"url":"https://api.github.com/repos/angular/angular.js","forks_url":"https://api.github.com/repos/angular/angular.js/forks","keys_url":"https://api.github.com/repos/angular/angular.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular.js/teams","hooks_url":"https://api.github.com/repos/angular/angular.js/hooks","issue_events_url":"https://api.github.com/repos/angular/angular.js/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular.js/events","assignees_url":"https://api.github.com/repos/angular/angular.js/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular.js/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular.js/tags","blobs_url":"https://api.github.com/repos/angular/angular.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular.js/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular.js/languages","stargazers_url":"https://api.github.com/repos/angular/angular.js/stargazers","contributors_url":"https://api.github.com/repos/angular/angular.js/contributors","subscribers_url":"https://api.github.com/repos/angular/angular.js/subscribers","subscription_url":"https://api.github.com/repos/angular/angular.js/subscription","commits_url":"https://api.github.com/repos/angular/angular.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular.js/issues/comments/{number}","contents_url":"https://api.github.com/repos/angular/angular.js/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular.js/merges","archive_url":"https://api.github.com/repos/angular/angular.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular.js/downloads","issues_url":"https://api.github.com/repos/angular/angular.js/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular.js/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular.js/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular.js/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular.js/releases{/id}","created_at":"2010-01-06T00:34:37Z","updated_at":"2014-07-27T00:39:12Z","pushed_at":"2014-07-26T19:40:05Z","git_url":"git://github.com/angular/angular.js.git","ssh_url":"git@github.com:angular/angular.js.git","clone_url":"https://github.com/angular/angular.js.git","svn_url":"https://github.com/angular/angular.js","homepage":"http://angularjs.org","size":199796,"stargazers_count":26519,"watchers_count":26519,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":9521,"mirror_url":null,"open_issues_count":1046,"forks":9521,"open_issues":1046,"watchers":26519,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular.js/pulls/8358"},"html":{"href":"https://github.com/angular/angular.js/pull/8358"},"issue":{"href":"https://api.github.com/repos/angular/angular.js/issues/8358"},"comments":{"href":"https://api.github.com/repos/angular/angular.js/issues/8358/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular.js/pulls/8358/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular.js/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/angular/angular.js/pulls/8358/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular.js/statuses/fb0cc849a64bbea415416e130e94e7bf2e086717"}}}}