GitHub PullRequestReviewCommentEvent at 2014-08-01 08:16:17
Repository: bridge
Actor: RWOverdijk
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Islive-io/bridge/pulls/comments/15686004","id":15686004,"diff_hunk":"@@ -39,18 +39,27 @@ define([\n         body   : properties.message\n       };\n \n-      user.getIdentity(function (error) {\n-        if (error) {\n-          return callback(error);\n+      transport.connection.post('/thread', thread, function (response) {\n+        if (response.error) {\n+          return callback(response);\n         }\n \n-        transport.connection.post('/thread', thread, function (response) {\n-          if (response.error) {\n-            return callback(response);\n-          }\n+        callback(null, response);\n+      });\n+    },\n \n-          callback(null, response);\n-        });\n+    /**\n+     * Get the number of unread messages for the authenticated user.\n+     *\n+     * @param {Function} callback","path":"lib/user/message.js","position":55,"original_position":25,"commit_id":"f78ab9bbece0053905ef2be80213bbdf9ab69279","original_commit_id":"c522bdf8282c18d1848cd3d6eccfb0811e652ebc","user":{"login":"RWOverdijk","id":781745,"avatar_url":"https://avatars.githubusercontent.com/u/781745?v=1","gravatar_id":"3d58bab92b2165d78b9d325085a75702","url":"https://api.github.com/users/RWOverdijk","html_url":"https://github.com/RWOverdijk","followers_url":"https://api.github.com/users/RWOverdijk/followers","following_url":"https://api.github.com/users/RWOverdijk/following{/other_user}","gists_url":"https://api.github.com/users/RWOverdijk/gists{/gist_id}","starred_url":"https://api.github.com/users/RWOverdijk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RWOverdijk/subscriptions","organizations_url":"https://api.github.com/users/RWOverdijk/orgs","repos_url":"https://api.github.com/users/RWOverdijk/repos","events_url":"https://api.github.com/users/RWOverdijk/events{/privacy}","received_events_url":"https://api.github.com/users/RWOverdijk/received_events","type":"User","site_admin":false},"body":"Will do, not now. Requires a lot of refactoring. https://trello.com/c/D9D2uJBP/33-refactor-callback-doc-blocks","created_at":"2014-08-01T08:16:17Z","updated_at":"2014-08-01T08:16:17Z","html_url":"https://github.com/Islive-io/bridge/pull/18#discussion_r15686004","pull_request_url":"https://api.github.com/repos/Islive-io/bridge/pulls/18","_links":{"self":{"href":"https://api.github.com/repos/Islive-io/bridge/pulls/comments/15686004"},"html":{"href":"https://github.com/Islive-io/bridge/pull/18#discussion_r15686004"},"pull_request":{"href":"https://api.github.com/repos/Islive-io/bridge/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/Islive-io/bridge/pulls/18","id":19197109,"html_url":"https://github.com/Islive-io/bridge/pull/18","diff_url":"https://github.com/Islive-io/bridge/pull/18.diff","patch_url":"https://github.com/Islive-io/bridge/pull/18.patch","issue_url":"https://api.github.com/repos/Islive-io/bridge/issues/18","number":18,"state":"open","title":"Feature/unread count","user":{"login":"RWOverdijk","id":781745,"avatar_url":"https://avatars.githubusercontent.com/u/781745?v=1","gravatar_id":"3d58bab92b2165d78b9d325085a75702","url":"https://api.github.com/users/RWOverdijk","html_url":"https://github.com/RWOverdijk","followers_url":"https://api.github.com/users/RWOverdijk/followers","following_url":"https://api.github.com/users/RWOverdijk/following{/other_user}","gists_url":"https://api.github.com/users/RWOverdijk/gists{/gist_id}","starred_url":"https://api.github.com/users/RWOverdijk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RWOverdijk/subscriptions","organizations_url":"https://api.github.com/users/RWOverdijk/orgs","repos_url":"https://api.github.com/users/RWOverdijk/repos","events_url":"https://api.github.com/users/RWOverdijk/events{/privacy}","received_events_url":"https://api.github.com/users/RWOverdijk/received_events","type":"User","site_admin":false},"body":"* Removed unneeded user identity checks client side.\r\n* Added `getUnreadCount` method for `message` module\r\n* Added docs for `getUnreadCount`","created_at":"2014-08-01T07:48:21Z","updated_at":"2014-08-01T08:16:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a0a652c8e2a11214c450a62086da35451d4bc96","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Islive-io/bridge/pulls/18/commits","review_comments_url":"https://api.github.com/repos/Islive-io/bridge/pulls/18/comments","review_comment_url":"https://api.github.com/repos/Islive-io/bridge/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Islive-io/bridge/issues/18/comments","statuses_url":"https://api.github.com/repos/Islive-io/bridge/statuses/f78ab9bbece0053905ef2be80213bbdf9ab69279","head":{"label":"RWOverdijk:feature/unread-count","ref":"feature/unread-count","sha":"f78ab9bbece0053905ef2be80213bbdf9ab69279","user":{"login":"RWOverdijk","id":781745,"avatar_url":"https://avatars.githubusercontent.com/u/781745?v=1","gravatar_id":"3d58bab92b2165d78b9d325085a75702","url":"https://api.github.com/users/RWOverdijk","html_url":"https://github.com/RWOverdijk","followers_url":"https://api.github.com/users/RWOverdijk/followers","following_url":"https://api.github.com/users/RWOverdijk/following{/other_user}","gists_url":"https://api.github.com/users/RWOverdijk/gists{/gist_id}","starred_url":"https://api.github.com/users/RWOverdijk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RWOverdijk/subscriptions","organizations_url":"https://api.github.com/users/RWOverdijk/orgs","repos_url":"https://api.github.com/users/RWOverdijk/repos","events_url":"https://api.github.com/users/RWOverdijk/events{/privacy}","received_events_url":"https://api.github.com/users/RWOverdijk/received_events","type":"User","site_admin":false},"repo":{"id":21459730,"name":"bridge","full_name":"RWOverdijk/bridge","owner":{"login":"RWOverdijk","id":781745,"avatar_url":"https://avatars.githubusercontent.com/u/781745?v=1","gravatar_id":"3d58bab92b2165d78b9d325085a75702","url":"https://api.github.com/users/RWOverdijk","html_url":"https://github.com/RWOverdijk","followers_url":"https://api.github.com/users/RWOverdijk/followers","following_url":"https://api.github.com/users/RWOverdijk/following{/other_user}","gists_url":"https://api.github.com/users/RWOverdijk/gists{/gist_id}","starred_url":"https://api.github.com/users/RWOverdijk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RWOverdijk/subscriptions","organizations_url":"https://api.github.com/users/RWOverdijk/orgs","repos_url":"https://api.github.com/users/RWOverdijk/repos","events_url":"https://api.github.com/users/RWOverdijk/events{/privacy}","received_events_url":"https://api.github.com/users/RWOverdijk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RWOverdijk/bridge","description":"The draw-bridge that connects land to the fortress. Islive.io SDK.","fork":true,"url":"https://api.github.com/repos/RWOverdijk/bridge","forks_url":"https://api.github.com/repos/RWOverdijk/bridge/forks","keys_url":"https://api.github.com/repos/RWOverdijk/bridge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RWOverdijk/bridge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RWOverdijk/bridge/teams","hooks_url":"https://api.github.com/repos/RWOverdijk/bridge/hooks","issue_events_url":"https://api.github.com/repos/RWOverdijk/bridge/issues/events{/number}","events_url":"https://api.github.com/repos/RWOverdijk/bridge/events","assignees_url":"https://api.github.com/repos/RWOverdijk/bridge/assignees{/user}","branches_url":"https://api.github.com/repos/RWOverdijk/bridge/branches{/branch}","tags_url":"https://api.github.com/repos/RWOverdijk/bridge/tags","blobs_url":"https://api.github.com/repos/RWOverdijk/bridge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RWOverdijk/bridge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RWOverdijk/bridge/git/refs{/sha}","trees_url":"https://api.github.com/repos/RWOverdijk/bridge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RWOverdijk/bridge/statuses/{sha}","languages_url":"https://api.github.com/repos/RWOverdijk/bridge/languages","stargazers_url":"https://api.github.com/repos/RWOverdijk/bridge/stargazers","contributors_url":"https://api.github.com/repos/RWOverdijk/bridge/contributors","subscribers_url":"https://api.github.com/repos/RWOverdijk/bridge/subscribers","subscription_url":"https://api.github.com/repos/RWOverdijk/bridge/subscription","commits_url":"https://api.github.com/repos/RWOverdijk/bridge/commits{/sha}","git_commits_url":"https://api.github.com/repos/RWOverdijk/bridge/git/commits{/sha}","comments_url":"https://api.github.com/repos/RWOverdijk/bridge/comments{/number}","issue_comment_url":"https://api.github.com/repos/RWOverdijk/bridge/issues/comments/{number}","contents_url":"https://api.github.com/repos/RWOverdijk/bridge/contents/{+path}","compare_url":"https://api.github.com/repos/RWOverdijk/bridge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RWOverdijk/bridge/merges","archive_url":"https://api.github.com/repos/RWOverdijk/bridge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RWOverdijk/bridge/downloads","issues_url":"https://api.github.com/repos/RWOverdijk/bridge/issues{/number}","pulls_url":"https://api.github.com/repos/RWOverdijk/bridge/pulls{/number}","milestones_url":"https://api.github.com/repos/RWOverdijk/bridge/milestones{/number}","notifications_url":"https://api.github.com/repos/RWOverdijk/bridge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RWOverdijk/bridge/labels{/name}","releases_url":"https://api.github.com/repos/RWOverdijk/bridge/releases{/id}","created_at":"2014-07-03T11:11:16Z","updated_at":"2014-07-03T12:44:21Z","pushed_at":"2014-08-01T08:08:31Z","git_url":"git://github.com/RWOverdijk/bridge.git","ssh_url":"git@github.com:RWOverdijk/bridge.git","clone_url":"https://github.com/RWOverdijk/bridge.git","svn_url":"https://github.com/RWOverdijk/bridge","homepage":null,"size":378,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Islive-io:master","ref":"master","sha":"838f5b68468af3b88a1c9d03df8f0332d214be9a","user":{"login":"Islive-io","id":8055212,"avatar_url":"https://avatars.githubusercontent.com/u/8055212?v=1","gravatar_id":null,"url":"https://api.github.com/users/Islive-io","html_url":"https://github.com/Islive-io","followers_url":"https://api.github.com/users/Islive-io/followers","following_url":"https://api.github.com/users/Islive-io/following{/other_user}","gists_url":"https://api.github.com/users/Islive-io/gists{/gist_id}","starred_url":"https://api.github.com/users/Islive-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Islive-io/subscriptions","organizations_url":"https://api.github.com/users/Islive-io/orgs","repos_url":"https://api.github.com/users/Islive-io/repos","events_url":"https://api.github.com/users/Islive-io/events{/privacy}","received_events_url":"https://api.github.com/users/Islive-io/received_events","type":"Organization","site_admin":false},"repo":{"id":21453255,"name":"bridge","full_name":"Islive-io/bridge","owner":{"login":"Islive-io","id":8055212,"avatar_url":"https://avatars.githubusercontent.com/u/8055212?v=1","gravatar_id":null,"url":"https://api.github.com/users/Islive-io","html_url":"https://github.com/Islive-io","followers_url":"https://api.github.com/users/Islive-io/followers","following_url":"https://api.github.com/users/Islive-io/following{/other_user}","gists_url":"https://api.github.com/users/Islive-io/gists{/gist_id}","starred_url":"https://api.github.com/users/Islive-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Islive-io/subscriptions","organizations_url":"https://api.github.com/users/Islive-io/orgs","repos_url":"https://api.github.com/users/Islive-io/repos","events_url":"https://api.github.com/users/Islive-io/events{/privacy}","received_events_url":"https://api.github.com/users/Islive-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Islive-io/bridge","description":"The draw-bridge that connects land to the fortress. Islive.io SDK.","fork":false,"url":"https://api.github.com/repos/Islive-io/bridge","forks_url":"https://api.github.com/repos/Islive-io/bridge/forks","keys_url":"https://api.github.com/repos/Islive-io/bridge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Islive-io/bridge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Islive-io/bridge/teams","hooks_url":"https://api.github.com/repos/Islive-io/bridge/hooks","issue_events_url":"https://api.github.com/repos/Islive-io/bridge/issues/events{/number}","events_url":"https://api.github.com/repos/Islive-io/bridge/events","assignees_url":"https://api.github.com/repos/Islive-io/bridge/assignees{/user}","branches_url":"https://api.github.com/repos/Islive-io/bridge/branches{/branch}","tags_url":"https://api.github.com/repos/Islive-io/bridge/tags","blobs_url":"https://api.github.com/repos/Islive-io/bridge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Islive-io/bridge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Islive-io/bridge/git/refs{/sha}","trees_url":"https://api.github.com/repos/Islive-io/bridge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Islive-io/bridge/statuses/{sha}","languages_url":"https://api.github.com/repos/Islive-io/bridge/languages","stargazers_url":"https://api.github.com/repos/Islive-io/bridge/stargazers","contributors_url":"https://api.github.com/repos/Islive-io/bridge/contributors","subscribers_url":"https://api.github.com/repos/Islive-io/bridge/subscribers","subscription_url":"https://api.github.com/repos/Islive-io/bridge/subscription","commits_url":"https://api.github.com/repos/Islive-io/bridge/commits{/sha}","git_commits_url":"https://api.github.com/repos/Islive-io/bridge/git/commits{/sha}","comments_url":"https://api.github.com/repos/Islive-io/bridge/comments{/number}","issue_comment_url":"https://api.github.com/repos/Islive-io/bridge/issues/comments/{number}","contents_url":"https://api.github.com/repos/Islive-io/bridge/contents/{+path}","compare_url":"https://api.github.com/repos/Islive-io/bridge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Islive-io/bridge/merges","archive_url":"https://api.github.com/repos/Islive-io/bridge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Islive-io/bridge/downloads","issues_url":"https://api.github.com/repos/Islive-io/bridge/issues{/number}","pulls_url":"https://api.github.com/repos/Islive-io/bridge/pulls{/number}","milestones_url":"https://api.github.com/repos/Islive-io/bridge/milestones{/number}","notifications_url":"https://api.github.com/repos/Islive-io/bridge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Islive-io/bridge/labels{/name}","releases_url":"https://api.github.com/repos/Islive-io/bridge/releases{/id}","created_at":"2014-07-03T07:14:29Z","updated_at":"2014-07-03T09:54:22Z","pushed_at":"2014-07-25T11:52:48Z","git_url":"git://github.com/Islive-io/bridge.git","ssh_url":"git@github.com:Islive-io/bridge.git","clone_url":"https://github.com/Islive-io/bridge.git","svn_url":"https://github.com/Islive-io/bridge","homepage":null,"size":521,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Islive-io/bridge/pulls/18"},"html":{"href":"https://github.com/Islive-io/bridge/pull/18"},"issue":{"href":"https://api.github.com/repos/Islive-io/bridge/issues/18"},"comments":{"href":"https://api.github.com/repos/Islive-io/bridge/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/Islive-io/bridge/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/Islive-io/bridge/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Islive-io/bridge/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/Islive-io/bridge/statuses/f78ab9bbece0053905ef2be80213bbdf9ab69279"}}}}