done!


On Sat, May 17, 2014 at 12:58 AM, Martin Dobias <notifications@github.com>wrote:

> In src/core/qgsapplication.cpp:
>
> > @@ -1016,4 +1023,25 @@ bool QgsApplication::createDB( QString *errorMessage )
> >    return true;
> >  }
> >
> > +void QgsApplication::setMaxThreads( int maxThreads )
> > +{
> > +  qDebug("max threads: %d",maxThreads);
> > +
> > +  // make sure value is between 1 and #cores, if not set to -1 (use #cores)
> > +  // 0 could be used to disable any parallel processing
> > +  if ( maxThreads < 1 || maxThreads > QThread::idealThreadCount() )
> > +	maxThreads = -1;
> > +
> > +  // save value
> > +  ABISYM( mMaxThreads ) = maxThreads;
> > +  QSettings().setValue( "/qgis/max_threads", maxThreads );
>
> Could you please move the QSettings::setValue() call to QgsOptions? I
> think it belongs there... a function like this should not has such side
> effect.
>
> Also, it would be good to change qDebug() calls to QgsDebugMsg() as the
> latter one comes from our logging framework...
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/qgis/QGIS/pull/1215/files#r12765931>
> .
>