GitHub PullRequestReviewCommentEvent at 2014-10-02 21:06:36
Repository: AskWikitextSerialization
Actor: JeroenDeDauw
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/wmde/AskWikitextSerialization/pulls/comments/18367968","id":18367968,"diff_hunk":"@@ -34,10 +37,34 @@ private function serializeQueryOptions( QueryOptions $options ) {\n \t\t$result = '';\n \t\t$this->appendOneOption( $result, 'limit', $options->getLimit() );\n \t\t$this->appendOneOption( $result, 'offset', $options->getOffset() );\n+\t\t$this->appendSortExpressions( $result, $options->getSort() );\n \t\treturn $result;\n \t}\n \n-\tprivate function appendOneOption(&$result, $name, $value) {\n+\tprivate function appendSortExpressions( &$result, SortOptions $sort ) {","path":"src/Serializers/Option/QueryOptionsSerializer.php","position":null,"original_position":19,"commit_id":"9154dd209af188ded7117385c4e37c0bf775930f","original_commit_id":"3480baf78113af489164c4a3ed2b7769d394d295","user":{"login":"JeroenDeDauw","id":146040,"avatar_url":"https://avatars.githubusercontent.com/u/146040?v=2","gravatar_id":"","url":"https://api.github.com/users/JeroenDeDauw","html_url":"https://github.com/JeroenDeDauw","followers_url":"https://api.github.com/users/JeroenDeDauw/followers","following_url":"https://api.github.com/users/JeroenDeDauw/following{/other_user}","gists_url":"https://api.github.com/users/JeroenDeDauw/gists{/gist_id}","starred_url":"https://api.github.com/users/JeroenDeDauw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeroenDeDauw/subscriptions","organizations_url":"https://api.github.com/users/JeroenDeDauw/orgs","repos_url":"https://api.github.com/users/JeroenDeDauw/repos","events_url":"https://api.github.com/users/JeroenDeDauw/events{/privacy}","received_events_url":"https://api.github.com/users/JeroenDeDauw/received_events","type":"User","site_admin":false},"body":"> because something always needs to know if a space needs to be appended first. I can move that to a property.\r\n\r\nSo you have a string composed of distinct parts. And have a method for creating each kind of part. Some parts might be empty, and they need to be joined in some way (ie with a space in between them). The later point is quite disjoint from the preceding one no?","created_at":"2014-10-02T21:06:36Z","updated_at":"2014-10-02T21:06:36Z","html_url":"https://github.com/wmde/AskWikitextSerialization/pull/4#discussion_r18367968","pull_request_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/wmde/AskWikitextSerialization/pulls/comments/18367968"},"html":{"href":"https://github.com/wmde/AskWikitextSerialization/pull/4#discussion_r18367968"},"pull_request":{"href":"https://api.github.com/repos/wmde/AskWikitextSerialization/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/wmde/AskWikitextSerialization/pulls/4","id":21861792,"html_url":"https://github.com/wmde/AskWikitextSerialization/pull/4","diff_url":"https://github.com/wmde/AskWikitextSerialization/pull/4.diff","patch_url":"https://github.com/wmde/AskWikitextSerialization/pull/4.patch","issue_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/issues/4","number":4,"state":"open","locked":false,"title":"more serialization implementation","user":{"login":"JanZerebecki","id":7452727,"avatar_url":"https://avatars.githubusercontent.com/u/7452727?v=2","gravatar_id":"","url":"https://api.github.com/users/JanZerebecki","html_url":"https://github.com/JanZerebecki","followers_url":"https://api.github.com/users/JanZerebecki/followers","following_url":"https://api.github.com/users/JanZerebecki/following{/other_user}","gists_url":"https://api.github.com/users/JanZerebecki/gists{/gist_id}","starred_url":"https://api.github.com/users/JanZerebecki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JanZerebecki/subscriptions","organizations_url":"https://api.github.com/users/JanZerebecki/orgs","repos_url":"https://api.github.com/users/JanZerebecki/repos","events_url":"https://api.github.com/users/JanZerebecki/events{/privacy}","received_events_url":"https://api.github.com/users/JanZerebecki/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-09-26T17:08:30Z","updated_at":"2014-10-02T21:06:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fbc01ae2d1e8c0fbecabbec4d74391d12fe41652","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/pulls/4/commits","review_comments_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/pulls/4/comments","review_comment_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/pulls/comments/{number}","comments_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/issues/4/comments","statuses_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/statuses/9154dd209af188ded7117385c4e37c0bf775930f","head":{"label":"wmde:more-implementation","ref":"more-implementation","sha":"9154dd209af188ded7117385c4e37c0bf775930f","user":{"login":"wmde","id":664724,"avatar_url":"https://avatars.githubusercontent.com/u/664724?v=2","gravatar_id":"","url":"https://api.github.com/users/wmde","html_url":"https://github.com/wmde","followers_url":"https://api.github.com/users/wmde/followers","following_url":"https://api.github.com/users/wmde/following{/other_user}","gists_url":"https://api.github.com/users/wmde/gists{/gist_id}","starred_url":"https://api.github.com/users/wmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmde/subscriptions","organizations_url":"https://api.github.com/users/wmde/orgs","repos_url":"https://api.github.com/users/wmde/repos","events_url":"https://api.github.com/users/wmde/events{/privacy}","received_events_url":"https://api.github.com/users/wmde/received_events","type":"Organization","site_admin":false},"repo":{"id":23667649,"name":"AskWikitextSerialization","full_name":"wmde/AskWikitextSerialization","owner":{"login":"wmde","id":664724,"avatar_url":"https://avatars.githubusercontent.com/u/664724?v=2","gravatar_id":"","url":"https://api.github.com/users/wmde","html_url":"https://github.com/wmde","followers_url":"https://api.github.com/users/wmde/followers","following_url":"https://api.github.com/users/wmde/following{/other_user}","gists_url":"https://api.github.com/users/wmde/gists{/gist_id}","starred_url":"https://api.github.com/users/wmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmde/subscriptions","organizations_url":"https://api.github.com/users/wmde/orgs","repos_url":"https://api.github.com/users/wmde/repos","events_url":"https://api.github.com/users/wmde/events{/privacy}","received_events_url":"https://api.github.com/users/wmde/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wmde/AskWikitextSerialization","description":"Wikitext serialializers and deserializers for the Ask query language","fork":false,"url":"https://api.github.com/repos/wmde/AskWikitextSerialization","forks_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/forks","keys_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/teams","hooks_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/hooks","issue_events_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/issues/events{/number}","events_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/events","assignees_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/assignees{/user}","branches_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/branches{/branch}","tags_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/tags","blobs_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/git/refs{/sha}","trees_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/statuses/{sha}","languages_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/languages","stargazers_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/stargazers","contributors_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/contributors","subscribers_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/subscribers","subscription_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/subscription","commits_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/commits{/sha}","git_commits_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/git/commits{/sha}","comments_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/comments{/number}","issue_comment_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/issues/comments/{number}","contents_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/contents/{+path}","compare_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/merges","archive_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/downloads","issues_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/issues{/number}","pulls_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/pulls{/number}","milestones_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/milestones{/number}","notifications_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/labels{/name}","releases_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/releases{/id}","created_at":"2014-09-04T15:17:24Z","updated_at":"2014-09-04T16:09:19Z","pushed_at":"2014-10-01T14:47:24Z","git_url":"git://github.com/wmde/AskWikitextSerialization.git","ssh_url":"git@github.com:wmde/AskWikitextSerialization.git","clone_url":"https://github.com/wmde/AskWikitextSerialization.git","svn_url":"https://github.com/wmde/AskWikitextSerialization","homepage":"","size":260,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"wmde:master","ref":"master","sha":"8d59c29a721591674d4df60e04ff77384b381914","user":{"login":"wmde","id":664724,"avatar_url":"https://avatars.githubusercontent.com/u/664724?v=2","gravatar_id":"","url":"https://api.github.com/users/wmde","html_url":"https://github.com/wmde","followers_url":"https://api.github.com/users/wmde/followers","following_url":"https://api.github.com/users/wmde/following{/other_user}","gists_url":"https://api.github.com/users/wmde/gists{/gist_id}","starred_url":"https://api.github.com/users/wmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmde/subscriptions","organizations_url":"https://api.github.com/users/wmde/orgs","repos_url":"https://api.github.com/users/wmde/repos","events_url":"https://api.github.com/users/wmde/events{/privacy}","received_events_url":"https://api.github.com/users/wmde/received_events","type":"Organization","site_admin":false},"repo":{"id":23667649,"name":"AskWikitextSerialization","full_name":"wmde/AskWikitextSerialization","owner":{"login":"wmde","id":664724,"avatar_url":"https://avatars.githubusercontent.com/u/664724?v=2","gravatar_id":"","url":"https://api.github.com/users/wmde","html_url":"https://github.com/wmde","followers_url":"https://api.github.com/users/wmde/followers","following_url":"https://api.github.com/users/wmde/following{/other_user}","gists_url":"https://api.github.com/users/wmde/gists{/gist_id}","starred_url":"https://api.github.com/users/wmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmde/subscriptions","organizations_url":"https://api.github.com/users/wmde/orgs","repos_url":"https://api.github.com/users/wmde/repos","events_url":"https://api.github.com/users/wmde/events{/privacy}","received_events_url":"https://api.github.com/users/wmde/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wmde/AskWikitextSerialization","description":"Wikitext serialializers and deserializers for the Ask query language","fork":false,"url":"https://api.github.com/repos/wmde/AskWikitextSerialization","forks_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/forks","keys_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/teams","hooks_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/hooks","issue_events_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/issues/events{/number}","events_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/events","assignees_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/assignees{/user}","branches_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/branches{/branch}","tags_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/tags","blobs_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/git/refs{/sha}","trees_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/statuses/{sha}","languages_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/languages","stargazers_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/stargazers","contributors_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/contributors","subscribers_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/subscribers","subscription_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/subscription","commits_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/commits{/sha}","git_commits_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/git/commits{/sha}","comments_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/comments{/number}","issue_comment_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/issues/comments/{number}","contents_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/contents/{+path}","compare_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/merges","archive_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/downloads","issues_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/issues{/number}","pulls_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/pulls{/number}","milestones_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/milestones{/number}","notifications_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/labels{/name}","releases_url":"https://api.github.com/repos/wmde/AskWikitextSerialization/releases{/id}","created_at":"2014-09-04T15:17:24Z","updated_at":"2014-09-04T16:09:19Z","pushed_at":"2014-10-01T14:47:24Z","git_url":"git://github.com/wmde/AskWikitextSerialization.git","ssh_url":"git@github.com:wmde/AskWikitextSerialization.git","clone_url":"https://github.com/wmde/AskWikitextSerialization.git","svn_url":"https://github.com/wmde/AskWikitextSerialization","homepage":"","size":260,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wmde/AskWikitextSerialization/pulls/4"},"html":{"href":"https://github.com/wmde/AskWikitextSerialization/pull/4"},"issue":{"href":"https://api.github.com/repos/wmde/AskWikitextSerialization/issues/4"},"comments":{"href":"https://api.github.com/repos/wmde/AskWikitextSerialization/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/wmde/AskWikitextSerialization/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/wmde/AskWikitextSerialization/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/wmde/AskWikitextSerialization/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/wmde/AskWikitextSerialization/statuses/9154dd209af188ded7117385c4e37c0bf775930f"}}}}