GitHub PullRequestEvent at 2014-12-09 15:42:37
Repository: SocialSharing-PhoneGap-Plugin
Actor: EddyVerbruggen
Payload: {"action":"closed","number":262,"pull_request":{"url":"https://api.github.com/repos/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/pulls/262","id":25751733,"html_url":"https://github.com/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/pull/262","diff_url":"https://github.com/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/pull/262.diff","patch_url":"https://github.com/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/pull/262.patch","issue_url":"https://api.github.com/repos/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/issues/262","number":262,"state":"closed","locked":false,"title":"Possible bug in isAvailableForServiceType","user":{"login":"nhoffmann","id":688047,"avatar_url":"https://avatars.githubusercontent.com/u/688047?v=3","gravatar_id":"","url":"https://api.github.com/users/nhoffmann","html_url":"https://github.com/nhoffmann","followers_url":"https://api.github.com/users/nhoffmann/followers","following_url":"https://api.github.com/users/nhoffmann/following{/other_user}","gists_url":"https://api.github.com/users/nhoffmann/gists{/gist_id}","starred_url":"https://api.github.com/users/nhoffmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhoffmann/subscriptions","organizations_url":"https://api.github.com/users/nhoffmann/orgs","repos_url":"https://api.github.com/users/nhoffmann/repos","events_url":"https://api.github.com/users/nhoffmann/events{/privacy}","received_events_url":"https://api.github.com/users/nhoffmann/received_events","type":"User","site_admin":false},"body":"We ran into a problem where a user did not have whatsapp installed and this plugin did not recognize it properly. \r\nAfter investigation, we traced it down to a problem in [`SLComposeViewController isAvailableForServiceType`](https://developer.apple.com/library/prerelease/ios/documentation/NetworkingInternet/Reference/SLComposeViewController_Class/index.html#//apple_ref/occ/clm/SLComposeViewController/isAvailableForServiceType:). Passing the string \"whatsapp\" oddly returned true for this method; actually any string not in the [defined constants](https://developer.apple.com/library/prerelease/ios/documentation/Social/Reference/SLRequest_Class/index.html#//apple_ref/doc/constant_group/Service_Type_Constants) returned true in our tests.\r\n\r\nThe proposed fix first checks if the type is in the defined constants and return false if not.","created_at":"2014-12-09T15:37:52Z","updated_at":"2014-12-09T15:42:37Z","closed_at":"2014-12-09T15:42:37Z","merged_at":null,"merge_commit_sha":"b943aaaf2438f1d06e28140745204921ce6f8a75","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/pulls/262/commits","review_comments_url":"https://api.github.com/repos/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/pulls/262/comments","review_comment_url":"https://api.github.com/repos/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/pulls/comments/{number}","comments_url":"https://api.github.com/repos/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/issues/262/comments","statuses_url":"https://api.github.com/repos/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/statuses/ef6f804e5c8e8710baae62c0133c3550df16c17b","head":{"label":"nhoffmann:master","ref":"master","sha":"ef6f804e5c8e8710baae62c0133c3550df16c17b","user":{"login":"nhoffmann","id":688047,"avatar_url":"https://avatars.githubusercontent.com/u/688047?v=3","gravatar_id":"","url":"https://api.github.com/users/nhoffmann","html_url":"https://github.com/nhoffmann","followers_url":"https://api.github.com/users/nhoffmann/followers","following_url":"https://api.github.com/users/nhoffmann/following{/other_user}","gists_url":"https://api.github.com/users/nhoffmann/gists{/gist_id}","starred_url":"https://api.github.com/users/nhoffmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhoffmann/subscriptions","organizations_url":"https://api.github.com/users/nhoffmann/orgs","repos_url":"https://api.github.com/users/nhoffmann/repos","events_url":"https://api.github.com/users/nhoffmann/events{/privacy}","received_events_url":"https://api.github.com/users/nhoffmann/received_events","type":"User","site_admin":false},"repo":{"id":27772266,"name":"SocialSharing-PhoneGap-Plugin","full_name":"nhoffmann/SocialSharing-PhoneGap-Plugin","owner":{"login":"nhoffmann","id":688047,"avatar_url":"https://avatars.githubusercontent.com/u/688047?v=3","gravatar_id":"","url":"https://api.github.com/users/nhoffmann","html_url":"https://github.com/nhoffmann","followers_url":"https://api.github.com/users/nhoffmann/followers","following_url":"https://api.github.com/users/nhoffmann/following{/other_user}","gists_url":"https://api.github.com/users/nhoffmann/gists{/gist_id}","starred_url":"https://api.github.com/users/nhoffmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhoffmann/subscriptions","organizations_url":"https://api.github.com/users/nhoffmann/orgs","repos_url":"https://api.github.com/users/nhoffmann/repos","events_url":"https://api.github.com/users/nhoffmann/events{/privacy}","received_events_url":"https://api.github.com/users/nhoffmann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nhoffmann/SocialSharing-PhoneGap-Plugin","description":"Cordova plugin to share text, a file (image/PDF/..), or a URL (or all three) via the native sharing widget","fork":true,"url":"https://api.github.com/repos/nhoffmann/SocialSharing-PhoneGap-Plugin","forks_url":"https://api.github.com/repos/nhoffmann/SocialSharing-PhoneGap-Plugin/forks","keys_url":"https://api.github.com/repos/nhoffmann/SocialSharing-PhoneGap-Plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nhoffmann/SocialSharing-PhoneGap-Plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nhoffmann/SocialSharing-PhoneGap-Plugin/teams","hooks_url":"https://api.github.com/repos/nhoffmann/SocialSharing-PhoneGap-Plugin/hooks","issue_events_url":"https://api.github.com/repos/nhoffmann/SocialSharing-PhoneGap-Plugin/issues/events{/number}","events_url":"https://api.github.com/repos/nhoffmann/SocialSharing-PhoneGap-Plugin/events","assignees_url":"https://api.github.com/repos/nhoffmann/SocialSharing-PhoneGap-Plugin/assignees{/user}","branches_url":"https://api.github.com/repos/nhoffmann/SocialSharing-PhoneGap-Plugin/branches{/branch}","tags_url":"https://api.github.com/repos/nhoffmann/SocialSharing-PhoneGap-Plugin/tags","blobs_url":"https://api.github.com/repos/nhoffmann/SocialSharing-PhoneGap-Plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nhoffmann/SocialSharing-PhoneGap-Plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nhoffmann/SocialSharing-PhoneGap-Plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/nhoffmann/SocialSharing-PhoneGap-Plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nhoffmann/SocialSharing-PhoneGap-Plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/nhoffmann/SocialSharing-PhoneGap-Plugin/languages","stargazers_url":"https://api.github.com/repos/nhoffmann/SocialSharing-PhoneGap-Plugin/stargazers","contributors_url":"https://api.github.com/repos/nhoffmann/SocialSharing-PhoneGap-Plugin/contributors","subscribers_url":"https://api.github.com/repos/nhoffmann/SocialSharing-PhoneGap-Plugin/subscribers","subscription_url":"https://api.github.com/repos/nhoffmann/SocialSharing-PhoneGap-Plugin/subscription","commits_url":"https://api.github.com/repos/nhoffmann/SocialSharing-PhoneGap-Plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/nhoffmann/SocialSharing-PhoneGap-Plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/nhoffmann/SocialSharing-PhoneGap-Plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/nhoffmann/SocialSharing-PhoneGap-Plugin/issues/comments/{number}","contents_url":"https://api.github.com/repos/nhoffmann/SocialSharing-PhoneGap-Plugin/contents/{+path}","compare_url":"https://api.github.com/repos/nhoffmann/SocialSharing-PhoneGap-Plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nhoffmann/SocialSharing-PhoneGap-Plugin/merges","archive_url":"https://api.github.com/repos/nhoffmann/SocialSharing-PhoneGap-Plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nhoffmann/SocialSharing-PhoneGap-Plugin/downloads","issues_url":"https://api.github.com/repos/nhoffmann/SocialSharing-PhoneGap-Plugin/issues{/number}","pulls_url":"https://api.github.com/repos/nhoffmann/SocialSharing-PhoneGap-Plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/nhoffmann/SocialSharing-PhoneGap-Plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/nhoffmann/SocialSharing-PhoneGap-Plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nhoffmann/SocialSharing-PhoneGap-Plugin/labels{/name}","releases_url":"https://api.github.com/repos/nhoffmann/SocialSharing-PhoneGap-Plugin/releases{/id}","created_at":"2014-12-09T15:13:32Z","updated_at":"2014-12-09T15:24:07Z","pushed_at":"2014-12-09T15:24:07Z","git_url":"git://github.com/nhoffmann/SocialSharing-PhoneGap-Plugin.git","ssh_url":"git@github.com:nhoffmann/SocialSharing-PhoneGap-Plugin.git","clone_url":"https://github.com/nhoffmann/SocialSharing-PhoneGap-Plugin.git","svn_url":"https://github.com/nhoffmann/SocialSharing-PhoneGap-Plugin","homepage":"http://www.x-services.nl/phonegap-share-plugin-facebook-twitter-social-media/754","size":2199,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"EddyVerbruggen:master","ref":"master","sha":"e379b1d30ee9bbb5ab8c276de8e8c1d88c5f4302","user":{"login":"EddyVerbruggen","id":1426370,"avatar_url":"https://avatars.githubusercontent.com/u/1426370?v=3","gravatar_id":"","url":"https://api.github.com/users/EddyVerbruggen","html_url":"https://github.com/EddyVerbruggen","followers_url":"https://api.github.com/users/EddyVerbruggen/followers","following_url":"https://api.github.com/users/EddyVerbruggen/following{/other_user}","gists_url":"https://api.github.com/users/EddyVerbruggen/gists{/gist_id}","starred_url":"https://api.github.com/users/EddyVerbruggen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EddyVerbruggen/subscriptions","organizations_url":"https://api.github.com/users/EddyVerbruggen/orgs","repos_url":"https://api.github.com/users/EddyVerbruggen/repos","events_url":"https://api.github.com/users/EddyVerbruggen/events{/privacy}","received_events_url":"https://api.github.com/users/EddyVerbruggen/received_events","type":"User","site_admin":false},"repo":{"id":12791945,"name":"SocialSharing-PhoneGap-Plugin","full_name":"EddyVerbruggen/SocialSharing-PhoneGap-Plugin","owner":{"login":"EddyVerbruggen","id":1426370,"avatar_url":"https://avatars.githubusercontent.com/u/1426370?v=3","gravatar_id":"","url":"https://api.github.com/users/EddyVerbruggen","html_url":"https://github.com/EddyVerbruggen","followers_url":"https://api.github.com/users/EddyVerbruggen/followers","following_url":"https://api.github.com/users/EddyVerbruggen/following{/other_user}","gists_url":"https://api.github.com/users/EddyVerbruggen/gists{/gist_id}","starred_url":"https://api.github.com/users/EddyVerbruggen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EddyVerbruggen/subscriptions","organizations_url":"https://api.github.com/users/EddyVerbruggen/orgs","repos_url":"https://api.github.com/users/EddyVerbruggen/repos","events_url":"https://api.github.com/users/EddyVerbruggen/events{/privacy}","received_events_url":"https://api.github.com/users/EddyVerbruggen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/EddyVerbruggen/SocialSharing-PhoneGap-Plugin","description":"Cordova plugin to share text, a file (image/PDF/..), or a URL (or all three) via the native sharing widget","fork":false,"url":"https://api.github.com/repos/EddyVerbruggen/SocialSharing-PhoneGap-Plugin","forks_url":"https://api.github.com/repos/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/forks","keys_url":"https://api.github.com/repos/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/teams","hooks_url":"https://api.github.com/repos/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/hooks","issue_events_url":"https://api.github.com/repos/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/issues/events{/number}","events_url":"https://api.github.com/repos/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/events","assignees_url":"https://api.github.com/repos/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/assignees{/user}","branches_url":"https://api.github.com/repos/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/branches{/branch}","tags_url":"https://api.github.com/repos/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/tags","blobs_url":"https://api.github.com/repos/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/languages","stargazers_url":"https://api.github.com/repos/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/stargazers","contributors_url":"https://api.github.com/repos/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/contributors","subscribers_url":"https://api.github.com/repos/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/subscribers","subscription_url":"https://api.github.com/repos/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/subscription","commits_url":"https://api.github.com/repos/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/issues/comments/{number}","contents_url":"https://api.github.com/repos/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/contents/{+path}","compare_url":"https://api.github.com/repos/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/merges","archive_url":"https://api.github.com/repos/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/downloads","issues_url":"https://api.github.com/repos/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/issues{/number}","pulls_url":"https://api.github.com/repos/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/labels{/name}","releases_url":"https://api.github.com/repos/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/releases{/id}","created_at":"2013-09-12T18:53:01Z","updated_at":"2014-12-06T14:15:00Z","pushed_at":"2014-12-04T14:55:57Z","git_url":"git://github.com/EddyVerbruggen/SocialSharing-PhoneGap-Plugin.git","ssh_url":"git@github.com:EddyVerbruggen/SocialSharing-PhoneGap-Plugin.git","clone_url":"https://github.com/EddyVerbruggen/SocialSharing-PhoneGap-Plugin.git","svn_url":"https://github.com/EddyVerbruggen/SocialSharing-PhoneGap-Plugin","homepage":"http://www.x-services.nl/phonegap-share-plugin-facebook-twitter-social-media/754","size":2199,"stargazers_count":460,"watchers_count":460,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":155,"mirror_url":null,"open_issues_count":34,"forks":155,"open_issues":34,"watchers":460,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/pulls/262"},"html":{"href":"https://github.com/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/pull/262"},"issue":{"href":"https://api.github.com/repos/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/issues/262"},"comments":{"href":"https://api.github.com/repos/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/issues/262/comments"},"review_comments":{"href":"https://api.github.com/repos/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/pulls/262/comments"},"review_comment":{"href":"https://api.github.com/repos/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/pulls/262/commits"},"statuses":{"href":"https://api.github.com/repos/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/statuses/ef6f804e5c8e8710baae62c0133c3550df16c17b"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":0,"commits":1,"additions":8,"deletions":0,"changed_files":1}}