GitHub PullRequestReviewCommentEvent at 2014-11-12 19:26:59
Repository: twine
Actor: celsodantas
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Shopify/twine/pulls/comments/20243487","id":20243487,"diff_hunk":"@@ -253,7 +253,12 @@ suite \"Twine\", ->\n     test \"unbind should remove event listener\", ->\n       testView = \"<div bind-event-click=\\\"fn()\\\"></div>\"\n       node = setupView(testView, context = fn: @spy())","path":"test/twine_test.coffee","position":3,"original_position":3,"commit_id":"db0e90b298134b109e4efed4edb516a79a3d2c29","original_commit_id":"4e40becce3e507842dbf27e0a0e143ae027ebefa","user":{"login":"celsodantas","id":408219,"avatar_url":"https://avatars.githubusercontent.com/u/408219?v=3","gravatar_id":"","url":"https://api.github.com/users/celsodantas","html_url":"https://github.com/celsodantas","followers_url":"https://api.github.com/users/celsodantas/followers","following_url":"https://api.github.com/users/celsodantas/following{/other_user}","gists_url":"https://api.github.com/users/celsodantas/gists{/gist_id}","starred_url":"https://api.github.com/users/celsodantas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/celsodantas/subscriptions","organizations_url":"https://api.github.com/users/celsodantas/orgs","repos_url":"https://api.github.com/users/celsodantas/repos","events_url":"https://api.github.com/users/celsodantas/events{/privacy}","received_events_url":"https://api.github.com/users/celsodantas/received_events","type":"User","site_admin":false},"body":"yes it is. Updated. Thanks.","created_at":"2014-11-12T19:26:59Z","updated_at":"2014-11-12T19:26:59Z","html_url":"https://github.com/Shopify/twine/pull/16#discussion_r20243487","pull_request_url":"https://api.github.com/repos/Shopify/twine/pulls/16","_links":{"self":{"href":"https://api.github.com/repos/Shopify/twine/pulls/comments/20243487"},"html":{"href":"https://github.com/Shopify/twine/pull/16#discussion_r20243487"},"pull_request":{"href":"https://api.github.com/repos/Shopify/twine/pulls/16"}}},"pull_request":{"url":"https://api.github.com/repos/Shopify/twine/pulls/16","id":24316150,"html_url":"https://github.com/Shopify/twine/pull/16","diff_url":"https://github.com/Shopify/twine/pull/16.diff","patch_url":"https://github.com/Shopify/twine/pull/16.patch","issue_url":"https://api.github.com/repos/Shopify/twine/issues/16","number":16,"state":"open","locked":false,"title":"teardown should also kill bindingId","user":{"login":"celsodantas","id":408219,"avatar_url":"https://avatars.githubusercontent.com/u/408219?v=3","gravatar_id":"","url":"https://api.github.com/users/celsodantas","html_url":"https://github.com/celsodantas","followers_url":"https://api.github.com/users/celsodantas/followers","following_url":"https://api.github.com/users/celsodantas/following{/other_user}","gists_url":"https://api.github.com/users/celsodantas/gists{/gist_id}","starred_url":"https://api.github.com/users/celsodantas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/celsodantas/subscriptions","organizations_url":"https://api.github.com/users/celsodantas/orgs","repos_url":"https://api.github.com/users/celsodantas/repos","events_url":"https://api.github.com/users/celsodantas/events{/privacy}","received_events_url":"https://api.github.com/users/celsodantas/received_events","type":"User","site_admin":false},"body":"@qq99 @nsimmons @pushrax \r\n\r\n## Problem:\r\n\r\nIf unbinding does not clear the `bindingId` of the node, rebinding it would reuse the same `key` and could result in `key` conflicting.\r\n\r\nI noticed this in a bug with the `refresh-except` feature (in turbograft), everything in the page was getting new `bindingId` but the kept block was using old `bindingId`s, so new elements were being generated with the same `bindingId` resulting in a conflict.\r\n\r\n## Solution:\r\n\r\nKill the `bindingId` on `unbind`. Rebinding it would re-generate a new key.","created_at":"2014-11-12T19:04:17Z","updated_at":"2014-11-12T19:26:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec5e4a95ac0349b8fad06bd0d718b47c11396fba","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Shopify/twine/pulls/16/commits","review_comments_url":"https://api.github.com/repos/Shopify/twine/pulls/16/comments","review_comment_url":"https://api.github.com/repos/Shopify/twine/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Shopify/twine/issues/16/comments","statuses_url":"https://api.github.com/repos/Shopify/twine/statuses/db0e90b298134b109e4efed4edb516a79a3d2c29","head":{"label":"Shopify:teardown_kill_binding_id","ref":"teardown_kill_binding_id","sha":"db0e90b298134b109e4efed4edb516a79a3d2c29","user":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":24009103,"name":"twine","full_name":"Shopify/twine","owner":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shopify/twine","description":"Twine is a minimalistic two-way binding system","fork":false,"url":"https://api.github.com/repos/Shopify/twine","forks_url":"https://api.github.com/repos/Shopify/twine/forks","keys_url":"https://api.github.com/repos/Shopify/twine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/twine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/twine/teams","hooks_url":"https://api.github.com/repos/Shopify/twine/hooks","issue_events_url":"https://api.github.com/repos/Shopify/twine/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/twine/events","assignees_url":"https://api.github.com/repos/Shopify/twine/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/twine/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/twine/tags","blobs_url":"https://api.github.com/repos/Shopify/twine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/twine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/twine/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/twine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/twine/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/twine/languages","stargazers_url":"https://api.github.com/repos/Shopify/twine/stargazers","contributors_url":"https://api.github.com/repos/Shopify/twine/contributors","subscribers_url":"https://api.github.com/repos/Shopify/twine/subscribers","subscription_url":"https://api.github.com/repos/Shopify/twine/subscription","commits_url":"https://api.github.com/repos/Shopify/twine/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/twine/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/twine/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/twine/issues/comments/{number}","contents_url":"https://api.github.com/repos/Shopify/twine/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/twine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/twine/merges","archive_url":"https://api.github.com/repos/Shopify/twine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/twine/downloads","issues_url":"https://api.github.com/repos/Shopify/twine/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/twine/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/twine/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/twine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/twine/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/twine/releases{/id}","created_at":"2014-09-13T23:51:04Z","updated_at":"2014-11-02T01:50:21Z","pushed_at":"2014-11-12T19:26:44Z","git_url":"git://github.com/Shopify/twine.git","ssh_url":"git@github.com:Shopify/twine.git","clone_url":"https://github.com/Shopify/twine.git","svn_url":"https://github.com/Shopify/twine","homepage":"","size":453,"stargazers_count":20,"watchers_count":20,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":20,"default_branch":"master"}},"base":{"label":"Shopify:master","ref":"master","sha":"8596c4d10a81d03327e6298d12c57ad3966e2066","user":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":24009103,"name":"twine","full_name":"Shopify/twine","owner":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shopify/twine","description":"Twine is a minimalistic two-way binding system","fork":false,"url":"https://api.github.com/repos/Shopify/twine","forks_url":"https://api.github.com/repos/Shopify/twine/forks","keys_url":"https://api.github.com/repos/Shopify/twine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/twine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/twine/teams","hooks_url":"https://api.github.com/repos/Shopify/twine/hooks","issue_events_url":"https://api.github.com/repos/Shopify/twine/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/twine/events","assignees_url":"https://api.github.com/repos/Shopify/twine/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/twine/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/twine/tags","blobs_url":"https://api.github.com/repos/Shopify/twine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/twine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/twine/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/twine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/twine/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/twine/languages","stargazers_url":"https://api.github.com/repos/Shopify/twine/stargazers","contributors_url":"https://api.github.com/repos/Shopify/twine/contributors","subscribers_url":"https://api.github.com/repos/Shopify/twine/subscribers","subscription_url":"https://api.github.com/repos/Shopify/twine/subscription","commits_url":"https://api.github.com/repos/Shopify/twine/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/twine/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/twine/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/twine/issues/comments/{number}","contents_url":"https://api.github.com/repos/Shopify/twine/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/twine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/twine/merges","archive_url":"https://api.github.com/repos/Shopify/twine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/twine/downloads","issues_url":"https://api.github.com/repos/Shopify/twine/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/twine/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/twine/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/twine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/twine/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/twine/releases{/id}","created_at":"2014-09-13T23:51:04Z","updated_at":"2014-11-02T01:50:21Z","pushed_at":"2014-11-12T19:26:44Z","git_url":"git://github.com/Shopify/twine.git","ssh_url":"git@github.com:Shopify/twine.git","clone_url":"https://github.com/Shopify/twine.git","svn_url":"https://github.com/Shopify/twine","homepage":"","size":453,"stargazers_count":20,"watchers_count":20,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Shopify/twine/pulls/16"},"html":{"href":"https://github.com/Shopify/twine/pull/16"},"issue":{"href":"https://api.github.com/repos/Shopify/twine/issues/16"},"comments":{"href":"https://api.github.com/repos/Shopify/twine/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/Shopify/twine/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/Shopify/twine/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Shopify/twine/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/Shopify/twine/statuses/db0e90b298134b109e4efed4edb516a79a3d2c29"}}}}