GitHub PullRequestEvent at 2014-11-20 20:45:33
Repository: cordova-plugin-datepicker
Actor: SamVerschueren
Payload: {"action":"opened","number":43,"pull_request":{"url":"https://api.github.com/repos/VitaliiBlagodir/cordova-plugin-datepicker/pulls/43","id":24796289,"html_url":"https://github.com/VitaliiBlagodir/cordova-plugin-datepicker/pull/43","diff_url":"https://github.com/VitaliiBlagodir/cordova-plugin-datepicker/pull/43.diff","patch_url":"https://github.com/VitaliiBlagodir/cordova-plugin-datepicker/pull/43.patch","issue_url":"https://api.github.com/repos/VitaliiBlagodir/cordova-plugin-datepicker/issues/43","number":43,"state":"open","locked":false,"title":"[Android] Fixed i18n of Cancel label and fixed cancel callback","user":{"login":"SamVerschueren","id":1913805,"avatar_url":"https://avatars.githubusercontent.com/u/1913805?v=3","gravatar_id":"","url":"https://api.github.com/users/SamVerschueren","html_url":"https://github.com/SamVerschueren","followers_url":"https://api.github.com/users/SamVerschueren/followers","following_url":"https://api.github.com/users/SamVerschueren/following{/other_user}","gists_url":"https://api.github.com/users/SamVerschueren/gists{/gist_id}","starred_url":"https://api.github.com/users/SamVerschueren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamVerschueren/subscriptions","organizations_url":"https://api.github.com/users/SamVerschueren/orgs","repos_url":"https://api.github.com/users/SamVerschueren/repos","events_url":"https://api.github.com/users/SamVerschueren/events{/privacy}","received_events_url":"https://api.github.com/users/SamVerschueren/received_events","type":"User","site_admin":false},"body":"Fixed issue https://github.com/VitaliiBlagodir/cordova-plugin-datepicker/issues/4 and https://github.com/VitaliiBlagodir/cordova-plugin-datepicker/issues/28\r\n\r\nThe cancel button labels are internationalized and are using android.R.string.cancel instead of the hardcoded \"Cancel\" label.\r\n\r\nWhen the user pressed cancel, the callback in android was not fired because it checks for isNaN and does nothing if the parameter is not a number.","created_at":"2014-11-20T20:45:33Z","updated_at":"2014-11-20T20:45:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/VitaliiBlagodir/cordova-plugin-datepicker/pulls/43/commits","review_comments_url":"https://api.github.com/repos/VitaliiBlagodir/cordova-plugin-datepicker/pulls/43/comments","review_comment_url":"https://api.github.com/repos/VitaliiBlagodir/cordova-plugin-datepicker/pulls/comments/{number}","comments_url":"https://api.github.com/repos/VitaliiBlagodir/cordova-plugin-datepicker/issues/43/comments","statuses_url":"https://api.github.com/repos/VitaliiBlagodir/cordova-plugin-datepicker/statuses/b7cdb245baaad3a0803b9b0be8b449aa7ceb935e","head":{"label":"SamVerschueren:master","ref":"master","sha":"b7cdb245baaad3a0803b9b0be8b449aa7ceb935e","user":{"login":"SamVerschueren","id":1913805,"avatar_url":"https://avatars.githubusercontent.com/u/1913805?v=3","gravatar_id":"","url":"https://api.github.com/users/SamVerschueren","html_url":"https://github.com/SamVerschueren","followers_url":"https://api.github.com/users/SamVerschueren/followers","following_url":"https://api.github.com/users/SamVerschueren/following{/other_user}","gists_url":"https://api.github.com/users/SamVerschueren/gists{/gist_id}","starred_url":"https://api.github.com/users/SamVerschueren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamVerschueren/subscriptions","organizations_url":"https://api.github.com/users/SamVerschueren/orgs","repos_url":"https://api.github.com/users/SamVerschueren/repos","events_url":"https://api.github.com/users/SamVerschueren/events{/privacy}","received_events_url":"https://api.github.com/users/SamVerschueren/received_events","type":"User","site_admin":false},"repo":{"id":26912020,"name":"cordova-plugin-datepicker","full_name":"SamVerschueren/cordova-plugin-datepicker","owner":{"login":"SamVerschueren","id":1913805,"avatar_url":"https://avatars.githubusercontent.com/u/1913805?v=3","gravatar_id":"","url":"https://api.github.com/users/SamVerschueren","html_url":"https://github.com/SamVerschueren","followers_url":"https://api.github.com/users/SamVerschueren/followers","following_url":"https://api.github.com/users/SamVerschueren/following{/other_user}","gists_url":"https://api.github.com/users/SamVerschueren/gists{/gist_id}","starred_url":"https://api.github.com/users/SamVerschueren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamVerschueren/subscriptions","organizations_url":"https://api.github.com/users/SamVerschueren/orgs","repos_url":"https://api.github.com/users/SamVerschueren/repos","events_url":"https://api.github.com/users/SamVerschueren/events{/privacy}","received_events_url":"https://api.github.com/users/SamVerschueren/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SamVerschueren/cordova-plugin-datepicker","description":null,"fork":true,"url":"https://api.github.com/repos/SamVerschueren/cordova-plugin-datepicker","forks_url":"https://api.github.com/repos/SamVerschueren/cordova-plugin-datepicker/forks","keys_url":"https://api.github.com/repos/SamVerschueren/cordova-plugin-datepicker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SamVerschueren/cordova-plugin-datepicker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SamVerschueren/cordova-plugin-datepicker/teams","hooks_url":"https://api.github.com/repos/SamVerschueren/cordova-plugin-datepicker/hooks","issue_events_url":"https://api.github.com/repos/SamVerschueren/cordova-plugin-datepicker/issues/events{/number}","events_url":"https://api.github.com/repos/SamVerschueren/cordova-plugin-datepicker/events","assignees_url":"https://api.github.com/repos/SamVerschueren/cordova-plugin-datepicker/assignees{/user}","branches_url":"https://api.github.com/repos/SamVerschueren/cordova-plugin-datepicker/branches{/branch}","tags_url":"https://api.github.com/repos/SamVerschueren/cordova-plugin-datepicker/tags","blobs_url":"https://api.github.com/repos/SamVerschueren/cordova-plugin-datepicker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SamVerschueren/cordova-plugin-datepicker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SamVerschueren/cordova-plugin-datepicker/git/refs{/sha}","trees_url":"https://api.github.com/repos/SamVerschueren/cordova-plugin-datepicker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SamVerschueren/cordova-plugin-datepicker/statuses/{sha}","languages_url":"https://api.github.com/repos/SamVerschueren/cordova-plugin-datepicker/languages","stargazers_url":"https://api.github.com/repos/SamVerschueren/cordova-plugin-datepicker/stargazers","contributors_url":"https://api.github.com/repos/SamVerschueren/cordova-plugin-datepicker/contributors","subscribers_url":"https://api.github.com/repos/SamVerschueren/cordova-plugin-datepicker/subscribers","subscription_url":"https://api.github.com/repos/SamVerschueren/cordova-plugin-datepicker/subscription","commits_url":"https://api.github.com/repos/SamVerschueren/cordova-plugin-datepicker/commits{/sha}","git_commits_url":"https://api.github.com/repos/SamVerschueren/cordova-plugin-datepicker/git/commits{/sha}","comments_url":"https://api.github.com/repos/SamVerschueren/cordova-plugin-datepicker/comments{/number}","issue_comment_url":"https://api.github.com/repos/SamVerschueren/cordova-plugin-datepicker/issues/comments/{number}","contents_url":"https://api.github.com/repos/SamVerschueren/cordova-plugin-datepicker/contents/{+path}","compare_url":"https://api.github.com/repos/SamVerschueren/cordova-plugin-datepicker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SamVerschueren/cordova-plugin-datepicker/merges","archive_url":"https://api.github.com/repos/SamVerschueren/cordova-plugin-datepicker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SamVerschueren/cordova-plugin-datepicker/downloads","issues_url":"https://api.github.com/repos/SamVerschueren/cordova-plugin-datepicker/issues{/number}","pulls_url":"https://api.github.com/repos/SamVerschueren/cordova-plugin-datepicker/pulls{/number}","milestones_url":"https://api.github.com/repos/SamVerschueren/cordova-plugin-datepicker/milestones{/number}","notifications_url":"https://api.github.com/repos/SamVerschueren/cordova-plugin-datepicker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SamVerschueren/cordova-plugin-datepicker/labels{/name}","releases_url":"https://api.github.com/repos/SamVerschueren/cordova-plugin-datepicker/releases{/id}","created_at":"2014-11-20T12:46:36Z","updated_at":"2014-11-20T12:59:50Z","pushed_at":"2014-11-20T12:59:50Z","git_url":"git://github.com/SamVerschueren/cordova-plugin-datepicker.git","ssh_url":"git@github.com:SamVerschueren/cordova-plugin-datepicker.git","clone_url":"https://github.com/SamVerschueren/cordova-plugin-datepicker.git","svn_url":"https://github.com/SamVerschueren/cordova-plugin-datepicker","homepage":null,"size":497,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"VitaliiBlagodir:master","ref":"master","sha":"327cd776687b5bfaf5b537c52ba3441e20ea57fe","user":{"login":"VitaliiBlagodir","id":3941665,"avatar_url":"https://avatars.githubusercontent.com/u/3941665?v=3","gravatar_id":"","url":"https://api.github.com/users/VitaliiBlagodir","html_url":"https://github.com/VitaliiBlagodir","followers_url":"https://api.github.com/users/VitaliiBlagodir/followers","following_url":"https://api.github.com/users/VitaliiBlagodir/following{/other_user}","gists_url":"https://api.github.com/users/VitaliiBlagodir/gists{/gist_id}","starred_url":"https://api.github.com/users/VitaliiBlagodir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VitaliiBlagodir/subscriptions","organizations_url":"https://api.github.com/users/VitaliiBlagodir/orgs","repos_url":"https://api.github.com/users/VitaliiBlagodir/repos","events_url":"https://api.github.com/users/VitaliiBlagodir/events{/privacy}","received_events_url":"https://api.github.com/users/VitaliiBlagodir/received_events","type":"User","site_admin":false},"repo":{"id":13423055,"name":"cordova-plugin-datepicker","full_name":"VitaliiBlagodir/cordova-plugin-datepicker","owner":{"login":"VitaliiBlagodir","id":3941665,"avatar_url":"https://avatars.githubusercontent.com/u/3941665?v=3","gravatar_id":"","url":"https://api.github.com/users/VitaliiBlagodir","html_url":"https://github.com/VitaliiBlagodir","followers_url":"https://api.github.com/users/VitaliiBlagodir/followers","following_url":"https://api.github.com/users/VitaliiBlagodir/following{/other_user}","gists_url":"https://api.github.com/users/VitaliiBlagodir/gists{/gist_id}","starred_url":"https://api.github.com/users/VitaliiBlagodir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VitaliiBlagodir/subscriptions","organizations_url":"https://api.github.com/users/VitaliiBlagodir/orgs","repos_url":"https://api.github.com/users/VitaliiBlagodir/repos","events_url":"https://api.github.com/users/VitaliiBlagodir/events{/privacy}","received_events_url":"https://api.github.com/users/VitaliiBlagodir/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/VitaliiBlagodir/cordova-plugin-datepicker","description":null,"fork":false,"url":"https://api.github.com/repos/VitaliiBlagodir/cordova-plugin-datepicker","forks_url":"https://api.github.com/repos/VitaliiBlagodir/cordova-plugin-datepicker/forks","keys_url":"https://api.github.com/repos/VitaliiBlagodir/cordova-plugin-datepicker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VitaliiBlagodir/cordova-plugin-datepicker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VitaliiBlagodir/cordova-plugin-datepicker/teams","hooks_url":"https://api.github.com/repos/VitaliiBlagodir/cordova-plugin-datepicker/hooks","issue_events_url":"https://api.github.com/repos/VitaliiBlagodir/cordova-plugin-datepicker/issues/events{/number}","events_url":"https://api.github.com/repos/VitaliiBlagodir/cordova-plugin-datepicker/events","assignees_url":"https://api.github.com/repos/VitaliiBlagodir/cordova-plugin-datepicker/assignees{/user}","branches_url":"https://api.github.com/repos/VitaliiBlagodir/cordova-plugin-datepicker/branches{/branch}","tags_url":"https://api.github.com/repos/VitaliiBlagodir/cordova-plugin-datepicker/tags","blobs_url":"https://api.github.com/repos/VitaliiBlagodir/cordova-plugin-datepicker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VitaliiBlagodir/cordova-plugin-datepicker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VitaliiBlagodir/cordova-plugin-datepicker/git/refs{/sha}","trees_url":"https://api.github.com/repos/VitaliiBlagodir/cordova-plugin-datepicker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VitaliiBlagodir/cordova-plugin-datepicker/statuses/{sha}","languages_url":"https://api.github.com/repos/VitaliiBlagodir/cordova-plugin-datepicker/languages","stargazers_url":"https://api.github.com/repos/VitaliiBlagodir/cordova-plugin-datepicker/stargazers","contributors_url":"https://api.github.com/repos/VitaliiBlagodir/cordova-plugin-datepicker/contributors","subscribers_url":"https://api.github.com/repos/VitaliiBlagodir/cordova-plugin-datepicker/subscribers","subscription_url":"https://api.github.com/repos/VitaliiBlagodir/cordova-plugin-datepicker/subscription","commits_url":"https://api.github.com/repos/VitaliiBlagodir/cordova-plugin-datepicker/commits{/sha}","git_commits_url":"https://api.github.com/repos/VitaliiBlagodir/cordova-plugin-datepicker/git/commits{/sha}","comments_url":"https://api.github.com/repos/VitaliiBlagodir/cordova-plugin-datepicker/comments{/number}","issue_comment_url":"https://api.github.com/repos/VitaliiBlagodir/cordova-plugin-datepicker/issues/comments/{number}","contents_url":"https://api.github.com/repos/VitaliiBlagodir/cordova-plugin-datepicker/contents/{+path}","compare_url":"https://api.github.com/repos/VitaliiBlagodir/cordova-plugin-datepicker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VitaliiBlagodir/cordova-plugin-datepicker/merges","archive_url":"https://api.github.com/repos/VitaliiBlagodir/cordova-plugin-datepicker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VitaliiBlagodir/cordova-plugin-datepicker/downloads","issues_url":"https://api.github.com/repos/VitaliiBlagodir/cordova-plugin-datepicker/issues{/number}","pulls_url":"https://api.github.com/repos/VitaliiBlagodir/cordova-plugin-datepicker/pulls{/number}","milestones_url":"https://api.github.com/repos/VitaliiBlagodir/cordova-plugin-datepicker/milestones{/number}","notifications_url":"https://api.github.com/repos/VitaliiBlagodir/cordova-plugin-datepicker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VitaliiBlagodir/cordova-plugin-datepicker/labels{/name}","releases_url":"https://api.github.com/repos/VitaliiBlagodir/cordova-plugin-datepicker/releases{/id}","created_at":"2013-10-08T19:14:41Z","updated_at":"2014-11-20T05:11:43Z","pushed_at":"2014-11-12T16:45:18Z","git_url":"git://github.com/VitaliiBlagodir/cordova-plugin-datepicker.git","ssh_url":"git@github.com:VitaliiBlagodir/cordova-plugin-datepicker.git","clone_url":"https://github.com/VitaliiBlagodir/cordova-plugin-datepicker.git","svn_url":"https://github.com/VitaliiBlagodir/cordova-plugin-datepicker","homepage":null,"size":497,"stargazers_count":62,"watchers_count":62,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":66,"mirror_url":null,"open_issues_count":23,"forks":66,"open_issues":23,"watchers":62,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/VitaliiBlagodir/cordova-plugin-datepicker/pulls/43"},"html":{"href":"https://github.com/VitaliiBlagodir/cordova-plugin-datepicker/pull/43"},"issue":{"href":"https://api.github.com/repos/VitaliiBlagodir/cordova-plugin-datepicker/issues/43"},"comments":{"href":"https://api.github.com/repos/VitaliiBlagodir/cordova-plugin-datepicker/issues/43/comments"},"review_comments":{"href":"https://api.github.com/repos/VitaliiBlagodir/cordova-plugin-datepicker/pulls/43/comments"},"review_comment":{"href":"https://api.github.com/repos/VitaliiBlagodir/cordova-plugin-datepicker/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/VitaliiBlagodir/cordova-plugin-datepicker/pulls/43/commits"},"statuses":{"href":"https://api.github.com/repos/VitaliiBlagodir/cordova-plugin-datepicker/statuses/b7cdb245baaad3a0803b9b0be8b449aa7ceb935e"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":18,"deletions":15,"changed_files":2}}