GitHub PullRequestReviewCommentEvent at 2014-10-02 19:02:36
Repository: ansible-role-cis
Actor: mwarkentin
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/pulls/comments/18359946","id":18359946,"diff_hunk":"@@ -15,4 +15,181 @@\n #   limitations under the License.\n #\n \n-# CIS Section 8 has no Level 2 checks\n\\ No newline at end of file\n+  - name: 8.1.2 Install and Enable auditd Service (Scored)\n+    apt: >\n+      pkg=auditd\n+      state=present\n+    sudo: yes\n+    tags:\n+      - scored\n+      - section8.1\n+      - section8.1.2\n+\n+  - name: 8.1.2 Install and Enable auditd Service (Scored)\n+    service: >\n+      name=auditd\n+      enabled=yes\n+      state=started\n+    sudo: yes\n+    tags:\n+      - scored\n+      - section8.1\n+      - section8.1.2\n+\n+  - name: 8.1.1.1 Configure Audit Log Storage Size (Not Scored)\n+    lineinfile: >\n+      state=present\n+      dest=/etc/audit/auditd.conf\n+      line=\"max_log_file = {{ max_log_file }}\"\n+      regexp=\"^max_log_file\"\n+    sudo: yes\n+    notify: Reload auditd Rules\n+    tags:\n+      - notscored\n+      - section8.1\n+      - section8.1.1\n+      - section8.1.1.1 \n+\n+  - name: 8.1.1.2 Disable System on Audit Log Full (Not Scored)\n+    lineinfile: >\n+      state=present\n+      dest=/etc/audit/auditd.conf\n+      regexp=\"^space_left_action =\"\n+      line=\"space_left_action = {{ space_left_action }}\"\n+    sudo: yes\n+    notify: Reload auditd Rules\n+    tags:\n+      - notscored\n+      - section8.1\n+      - section8.1.1\n+      - section8.1.1.2\n+\n+  - name: 8.1.1.2 Disable System on Audit Log Full (Not Scored)\n+    lineinfile: >\n+      state=present\n+      dest=/etc/audit/auditd.conf\n+      regexp=\"^action_mail_acct =\"\n+      line=\"action_mail_acct = {{ action_mail_acct }}\"\n+    sudo: yes\n+    notify: Reload auditd Rules\n+    tags:\n+      - notscored\n+      - section8.1\n+      - section8.1.1\n+      - section8.1.1.2\n+\n+  - name: 8.1.1.2 Disable System on Audit Log Full (Not Scored)\n+    lineinfile: >\n+      state=present\n+      dest=/etc/audit/auditd.conf\n+      regexp=\"^admin_space_left_action =\"\n+      line=\"admin_space_left_action = {{ admin_space_left_action }}\"\n+    sudo: yes\n+    notify: Reload auditd Rules\n+    tags:\n+      - notscored\n+      - section8.1\n+      - section8.1.1\n+      - section8.1.1.2\n+\n+  - name: 8.1.1.3 Keep All Auditing Information (Scored)\n+    lineinfile: >\n+      state=present\n+      dest=/etc/audit/auditd.conf\n+      regexp=\"^max_log_file_action =\"\n+      line=\"max_log_file_action = {{ max_log_file_action }}\"\n+    sudo: yes\n+    notify: Reload auditd Rules\n+    tags:\n+      - scored\n+      - section8.1\n+      - section8.1.1\n+      - section8.1.1.3","path":"tasks/section_08_level2.yml","position":95,"original_position":95,"commit_id":"1fc3104ff2dda24edb97b57deee2cb478585eaf6","original_commit_id":"1fc3104ff2dda24edb97b57deee2cb478585eaf6","user":{"login":"mwarkentin","id":67560,"avatar_url":"https://avatars.githubusercontent.com/u/67560?v=2","gravatar_id":"","url":"https://api.github.com/users/mwarkentin","html_url":"https://github.com/mwarkentin","followers_url":"https://api.github.com/users/mwarkentin/followers","following_url":"https://api.github.com/users/mwarkentin/following{/other_user}","gists_url":"https://api.github.com/users/mwarkentin/gists{/gist_id}","starred_url":"https://api.github.com/users/mwarkentin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwarkentin/subscriptions","organizations_url":"https://api.github.com/users/mwarkentin/orgs","repos_url":"https://api.github.com/users/mwarkentin/repos","events_url":"https://api.github.com/users/mwarkentin/events{/privacy}","received_events_url":"https://api.github.com/users/mwarkentin/received_events","type":"User","site_admin":false},"body":"Unless there's an issue doing the variable replacement within a for loop.","created_at":"2014-10-02T19:02:36Z","updated_at":"2014-10-02T19:02:36Z","html_url":"https://github.com/waveaccounting/ansible-role-cis/pull/7#discussion_r18359946","pull_request_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/waveaccounting/ansible-role-cis/pulls/comments/18359946"},"html":{"href":"https://github.com/waveaccounting/ansible-role-cis/pull/7#discussion_r18359946"},"pull_request":{"href":"https://api.github.com/repos/waveaccounting/ansible-role-cis/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/pulls/7","id":21941706,"html_url":"https://github.com/waveaccounting/ansible-role-cis/pull/7","diff_url":"https://github.com/waveaccounting/ansible-role-cis/pull/7.diff","patch_url":"https://github.com/waveaccounting/ansible-role-cis/pull/7.patch","issue_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/issues/7","number":7,"state":"open","locked":false,"title":"Added all CIS Section 8 Level 1 & 2 tasks & various fixes","user":{"login":"shouser","id":808881,"avatar_url":"https://avatars.githubusercontent.com/u/808881?v=2","gravatar_id":"","url":"https://api.github.com/users/shouser","html_url":"https://github.com/shouser","followers_url":"https://api.github.com/users/shouser/followers","following_url":"https://api.github.com/users/shouser/following{/other_user}","gists_url":"https://api.github.com/users/shouser/gists{/gist_id}","starred_url":"https://api.github.com/users/shouser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shouser/subscriptions","organizations_url":"https://api.github.com/users/shouser/orgs","repos_url":"https://api.github.com/users/shouser/repos","events_url":"https://api.github.com/users/shouser/events{/privacy}","received_events_url":"https://api.github.com/users/shouser/received_events","type":"User","site_admin":false},"body":"https://benchmarks.cisecurity.org/tools2/ubuntu/CIS_Ubuntu_12.04_LTS_Server_Benchmark_v1.0.0.pdf","created_at":"2014-09-29T15:19:48Z","updated_at":"2014-10-02T19:02:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"81c39f3585cb5698a85a2803a2235b3d505c7d08","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/pulls/7/commits","review_comments_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/pulls/7/comments","review_comment_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/pulls/comments/{number}","comments_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/issues/7/comments","statuses_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/statuses/1fc3104ff2dda24edb97b57deee2cb478585eaf6","head":{"label":"waveaccounting:ubuntu-support-section8","ref":"ubuntu-support-section8","sha":"1fc3104ff2dda24edb97b57deee2cb478585eaf6","user":{"login":"waveaccounting","id":779298,"avatar_url":"https://avatars.githubusercontent.com/u/779298?v=2","gravatar_id":"","url":"https://api.github.com/users/waveaccounting","html_url":"https://github.com/waveaccounting","followers_url":"https://api.github.com/users/waveaccounting/followers","following_url":"https://api.github.com/users/waveaccounting/following{/other_user}","gists_url":"https://api.github.com/users/waveaccounting/gists{/gist_id}","starred_url":"https://api.github.com/users/waveaccounting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waveaccounting/subscriptions","organizations_url":"https://api.github.com/users/waveaccounting/orgs","repos_url":"https://api.github.com/users/waveaccounting/repos","events_url":"https://api.github.com/users/waveaccounting/events{/privacy}","received_events_url":"https://api.github.com/users/waveaccounting/received_events","type":"Organization","site_admin":false},"repo":{"id":24060444,"name":"ansible-role-cis","full_name":"waveaccounting/ansible-role-cis","owner":{"login":"waveaccounting","id":779298,"avatar_url":"https://avatars.githubusercontent.com/u/779298?v=2","gravatar_id":"","url":"https://api.github.com/users/waveaccounting","html_url":"https://github.com/waveaccounting","followers_url":"https://api.github.com/users/waveaccounting/followers","following_url":"https://api.github.com/users/waveaccounting/following{/other_user}","gists_url":"https://api.github.com/users/waveaccounting/gists{/gist_id}","starred_url":"https://api.github.com/users/waveaccounting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waveaccounting/subscriptions","organizations_url":"https://api.github.com/users/waveaccounting/orgs","repos_url":"https://api.github.com/users/waveaccounting/repos","events_url":"https://api.github.com/users/waveaccounting/events{/privacy}","received_events_url":"https://api.github.com/users/waveaccounting/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/waveaccounting/ansible-role-cis","description":"Ansible role for auditing/remediating hosts using CIS security benchmarks","fork":true,"url":"https://api.github.com/repos/waveaccounting/ansible-role-cis","forks_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/forks","keys_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/teams","hooks_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/hooks","issue_events_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/issues/events{/number}","events_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/events","assignees_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/assignees{/user}","branches_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/branches{/branch}","tags_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/tags","blobs_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/git/refs{/sha}","trees_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/statuses/{sha}","languages_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/languages","stargazers_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/stargazers","contributors_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/contributors","subscribers_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/subscribers","subscription_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/subscription","commits_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/commits{/sha}","git_commits_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/git/commits{/sha}","comments_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/comments{/number}","issue_comment_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/issues/comments/{number}","contents_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/contents/{+path}","compare_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/merges","archive_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/downloads","issues_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/issues{/number}","pulls_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/pulls{/number}","milestones_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/milestones{/number}","notifications_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/labels{/name}","releases_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/releases{/id}","created_at":"2014-09-15T14:52:18Z","updated_at":"2014-09-08T11:59:32Z","pushed_at":"2014-10-02T16:50:29Z","git_url":"git://github.com/waveaccounting/ansible-role-cis.git","ssh_url":"git@github.com:waveaccounting/ansible-role-cis.git","clone_url":"https://github.com/waveaccounting/ansible-role-cis.git","svn_url":"https://github.com/waveaccounting/ansible-role-cis","homepage":null,"size":698,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"waveaccounting:master","ref":"master","sha":"d291eea411d19e448be5eedf335893b0621ad398","user":{"login":"waveaccounting","id":779298,"avatar_url":"https://avatars.githubusercontent.com/u/779298?v=2","gravatar_id":"","url":"https://api.github.com/users/waveaccounting","html_url":"https://github.com/waveaccounting","followers_url":"https://api.github.com/users/waveaccounting/followers","following_url":"https://api.github.com/users/waveaccounting/following{/other_user}","gists_url":"https://api.github.com/users/waveaccounting/gists{/gist_id}","starred_url":"https://api.github.com/users/waveaccounting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waveaccounting/subscriptions","organizations_url":"https://api.github.com/users/waveaccounting/orgs","repos_url":"https://api.github.com/users/waveaccounting/repos","events_url":"https://api.github.com/users/waveaccounting/events{/privacy}","received_events_url":"https://api.github.com/users/waveaccounting/received_events","type":"Organization","site_admin":false},"repo":{"id":24060444,"name":"ansible-role-cis","full_name":"waveaccounting/ansible-role-cis","owner":{"login":"waveaccounting","id":779298,"avatar_url":"https://avatars.githubusercontent.com/u/779298?v=2","gravatar_id":"","url":"https://api.github.com/users/waveaccounting","html_url":"https://github.com/waveaccounting","followers_url":"https://api.github.com/users/waveaccounting/followers","following_url":"https://api.github.com/users/waveaccounting/following{/other_user}","gists_url":"https://api.github.com/users/waveaccounting/gists{/gist_id}","starred_url":"https://api.github.com/users/waveaccounting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waveaccounting/subscriptions","organizations_url":"https://api.github.com/users/waveaccounting/orgs","repos_url":"https://api.github.com/users/waveaccounting/repos","events_url":"https://api.github.com/users/waveaccounting/events{/privacy}","received_events_url":"https://api.github.com/users/waveaccounting/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/waveaccounting/ansible-role-cis","description":"Ansible role for auditing/remediating hosts using CIS security benchmarks","fork":true,"url":"https://api.github.com/repos/waveaccounting/ansible-role-cis","forks_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/forks","keys_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/teams","hooks_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/hooks","issue_events_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/issues/events{/number}","events_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/events","assignees_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/assignees{/user}","branches_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/branches{/branch}","tags_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/tags","blobs_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/git/refs{/sha}","trees_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/statuses/{sha}","languages_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/languages","stargazers_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/stargazers","contributors_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/contributors","subscribers_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/subscribers","subscription_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/subscription","commits_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/commits{/sha}","git_commits_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/git/commits{/sha}","comments_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/comments{/number}","issue_comment_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/issues/comments/{number}","contents_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/contents/{+path}","compare_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/merges","archive_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/downloads","issues_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/issues{/number}","pulls_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/pulls{/number}","milestones_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/milestones{/number}","notifications_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/labels{/name}","releases_url":"https://api.github.com/repos/waveaccounting/ansible-role-cis/releases{/id}","created_at":"2014-09-15T14:52:18Z","updated_at":"2014-09-08T11:59:32Z","pushed_at":"2014-10-02T16:50:29Z","git_url":"git://github.com/waveaccounting/ansible-role-cis.git","ssh_url":"git@github.com:waveaccounting/ansible-role-cis.git","clone_url":"https://github.com/waveaccounting/ansible-role-cis.git","svn_url":"https://github.com/waveaccounting/ansible-role-cis","homepage":null,"size":698,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/waveaccounting/ansible-role-cis/pulls/7"},"html":{"href":"https://github.com/waveaccounting/ansible-role-cis/pull/7"},"issue":{"href":"https://api.github.com/repos/waveaccounting/ansible-role-cis/issues/7"},"comments":{"href":"https://api.github.com/repos/waveaccounting/ansible-role-cis/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/waveaccounting/ansible-role-cis/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/waveaccounting/ansible-role-cis/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/waveaccounting/ansible-role-cis/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/waveaccounting/ansible-role-cis/statuses/1fc3104ff2dda24edb97b57deee2cb478585eaf6"}}}}