GitHub PullRequestReviewCommentEvent at 2014-06-06 14:25:03
Repository: parallel_tests
Actor: grosser
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/grosser/parallel_tests/pulls/comments/13491915","id":13491915,"diff_hunk":"@@ -26,12 +26,23 @@ def example_group_started(example_group)\n       super\n     end\n \n-    def example_group_finished(example_group)\n-      @group_nesting -= 1\n-      if @group_nesting == 0\n-        @example_times[example_group.file_path] += ParallelTests.now - @time\n+\n+    if RSpec::Core::Version::STRING.start_with?('3')","path":"lib/parallel_tests/rspec/runtime_logger.rb","position":9,"original_position":9,"commit_id":"a86585ef71f09999c433d24528b9aa5702a52741","original_commit_id":"a86585ef71f09999c433d24528b9aa5702a52741","user":{"login":"grosser","id":11367,"avatar_url":"https://avatars.githubusercontent.com/u/11367?","gravatar_id":"59436ecd4fe6ad7c34f67654d839f05f","url":"https://api.github.com/users/grosser","html_url":"https://github.com/grosser","followers_url":"https://api.github.com/users/grosser/followers","following_url":"https://api.github.com/users/grosser/following{/other_user}","gists_url":"https://api.github.com/users/grosser/gists{/gist_id}","starred_url":"https://api.github.com/users/grosser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grosser/subscriptions","organizations_url":"https://api.github.com/users/grosser/orgs","repos_url":"https://api.github.com/users/grosser/repos","events_url":"https://api.github.com/users/grosser/events{/privacy}","received_events_url":"https://api.github.com/users/grosser/received_events","type":"User","site_admin":false},"body":"if you define `RSPEC3 = RSpec::Core::Version::STRING.start_with?('3')`\r\nthe change can be as simple as `RSPEC3 ? notification.group.file_path : notification.file_path`","created_at":"2014-06-06T14:25:03Z","updated_at":"2014-06-06T14:25:03Z","html_url":"https://github.com/grosser/parallel_tests/pull/321#discussion_r13491915","pull_request_url":"https://api.github.com/repos/grosser/parallel_tests/pulls/321","_links":{"self":{"href":"https://api.github.com/repos/grosser/parallel_tests/pulls/comments/13491915"},"html":{"href":"https://github.com/grosser/parallel_tests/pull/321#discussion_r13491915"},"pull_request":{"href":"https://api.github.com/repos/grosser/parallel_tests/pulls/321"}}},"pull_request":{"url":"https://api.github.com/repos/grosser/parallel_tests/pulls/321","id":16810347,"html_url":"https://github.com/grosser/parallel_tests/pull/321","diff_url":"https://github.com/grosser/parallel_tests/pull/321.diff","patch_url":"https://github.com/grosser/parallel_tests/pull/321.patch","issue_url":"https://api.github.com/repos/grosser/parallel_tests/issues/321","number":321,"state":"open","title":"Make runtime logger formatter rspec 3 friendly","user":{"login":"fcheung","id":5927,"avatar_url":"https://avatars.githubusercontent.com/u/5927?","gravatar_id":"81b61875e41eaa58887543635d556fca","url":"https://api.github.com/users/fcheung","html_url":"https://github.com/fcheung","followers_url":"https://api.github.com/users/fcheung/followers","following_url":"https://api.github.com/users/fcheung/following{/other_user}","gists_url":"https://api.github.com/users/fcheung/gists{/gist_id}","starred_url":"https://api.github.com/users/fcheung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fcheung/subscriptions","organizations_url":"https://api.github.com/users/fcheung/orgs","repos_url":"https://api.github.com/users/fcheung/repos","events_url":"https://api.github.com/users/fcheung/events{/privacy}","received_events_url":"https://api.github.com/users/fcheung/received_events","type":"User","site_admin":false},"body":"This is basically the bare minimum I had to do to get our specs running without deprecation warnings.\r\n\r\nTrying to support rspec 1,2,3  in the same file is getting pretty grungy - perhaps this would be better as a separate rspec3 only formatter (in addition to the legacy one) ?","created_at":"2014-06-06T08:56:08Z","updated_at":"2014-06-06T14:25:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea6b50a20924e6d10b3af1c068bd9c21a1307de1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/grosser/parallel_tests/pulls/321/commits","review_comments_url":"https://api.github.com/repos/grosser/parallel_tests/pulls/321/comments","review_comment_url":"https://api.github.com/repos/grosser/parallel_tests/pulls/comments/{number}","comments_url":"https://api.github.com/repos/grosser/parallel_tests/issues/321/comments","statuses_url":"https://api.github.com/repos/grosser/parallel_tests/statuses/a86585ef71f09999c433d24528b9aa5702a52741","head":{"label":"fcheung:rspec3_formatter","ref":"rspec3_formatter","sha":"a86585ef71f09999c433d24528b9aa5702a52741","user":{"login":"fcheung","id":5927,"avatar_url":"https://avatars.githubusercontent.com/u/5927?","gravatar_id":"81b61875e41eaa58887543635d556fca","url":"https://api.github.com/users/fcheung","html_url":"https://github.com/fcheung","followers_url":"https://api.github.com/users/fcheung/followers","following_url":"https://api.github.com/users/fcheung/following{/other_user}","gists_url":"https://api.github.com/users/fcheung/gists{/gist_id}","starred_url":"https://api.github.com/users/fcheung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fcheung/subscriptions","organizations_url":"https://api.github.com/users/fcheung/orgs","repos_url":"https://api.github.com/users/fcheung/repos","events_url":"https://api.github.com/users/fcheung/events{/privacy}","received_events_url":"https://api.github.com/users/fcheung/received_events","type":"User","site_admin":false},"repo":{"id":1984539,"name":"parallel_tests","full_name":"fcheung/parallel_tests","owner":{"login":"fcheung","id":5927,"avatar_url":"https://avatars.githubusercontent.com/u/5927?","gravatar_id":"81b61875e41eaa58887543635d556fca","url":"https://api.github.com/users/fcheung","html_url":"https://github.com/fcheung","followers_url":"https://api.github.com/users/fcheung/followers","following_url":"https://api.github.com/users/fcheung/following{/other_user}","gists_url":"https://api.github.com/users/fcheung/gists{/gist_id}","starred_url":"https://api.github.com/users/fcheung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fcheung/subscriptions","organizations_url":"https://api.github.com/users/fcheung/orgs","repos_url":"https://api.github.com/users/fcheung/repos","events_url":"https://api.github.com/users/fcheung/events{/privacy}","received_events_url":"https://api.github.com/users/fcheung/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fcheung/parallel_tests","description":"Rails: 2 CPUs = 2x Testing Speed for RSpec, Test::Unit and Cucumber","fork":true,"url":"https://api.github.com/repos/fcheung/parallel_tests","forks_url":"https://api.github.com/repos/fcheung/parallel_tests/forks","keys_url":"https://api.github.com/repos/fcheung/parallel_tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fcheung/parallel_tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fcheung/parallel_tests/teams","hooks_url":"https://api.github.com/repos/fcheung/parallel_tests/hooks","issue_events_url":"https://api.github.com/repos/fcheung/parallel_tests/issues/events{/number}","events_url":"https://api.github.com/repos/fcheung/parallel_tests/events","assignees_url":"https://api.github.com/repos/fcheung/parallel_tests/assignees{/user}","branches_url":"https://api.github.com/repos/fcheung/parallel_tests/branches{/branch}","tags_url":"https://api.github.com/repos/fcheung/parallel_tests/tags","blobs_url":"https://api.github.com/repos/fcheung/parallel_tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fcheung/parallel_tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fcheung/parallel_tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/fcheung/parallel_tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fcheung/parallel_tests/statuses/{sha}","languages_url":"https://api.github.com/repos/fcheung/parallel_tests/languages","stargazers_url":"https://api.github.com/repos/fcheung/parallel_tests/stargazers","contributors_url":"https://api.github.com/repos/fcheung/parallel_tests/contributors","subscribers_url":"https://api.github.com/repos/fcheung/parallel_tests/subscribers","subscription_url":"https://api.github.com/repos/fcheung/parallel_tests/subscription","commits_url":"https://api.github.com/repos/fcheung/parallel_tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/fcheung/parallel_tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/fcheung/parallel_tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/fcheung/parallel_tests/issues/comments/{number}","contents_url":"https://api.github.com/repos/fcheung/parallel_tests/contents/{+path}","compare_url":"https://api.github.com/repos/fcheung/parallel_tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fcheung/parallel_tests/merges","archive_url":"https://api.github.com/repos/fcheung/parallel_tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fcheung/parallel_tests/downloads","issues_url":"https://api.github.com/repos/fcheung/parallel_tests/issues{/number}","pulls_url":"https://api.github.com/repos/fcheung/parallel_tests/pulls{/number}","milestones_url":"https://api.github.com/repos/fcheung/parallel_tests/milestones{/number}","notifications_url":"https://api.github.com/repos/fcheung/parallel_tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fcheung/parallel_tests/labels{/name}","releases_url":"https://api.github.com/repos/fcheung/parallel_tests/releases{/id}","created_at":"2011-07-01T17:40:55Z","updated_at":"2014-06-06T08:56:08Z","pushed_at":"2014-06-06T08:24:03Z","git_url":"git://github.com/fcheung/parallel_tests.git","ssh_url":"git@github.com:fcheung/parallel_tests.git","clone_url":"https://github.com/fcheung/parallel_tests.git","svn_url":"https://github.com/fcheung/parallel_tests","homepage":"","size":461,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"grosser:master","ref":"master","sha":"4204705a09d651458c9bf8e075cf7ad0a8f00b77","user":{"login":"grosser","id":11367,"avatar_url":"https://avatars.githubusercontent.com/u/11367?","gravatar_id":"59436ecd4fe6ad7c34f67654d839f05f","url":"https://api.github.com/users/grosser","html_url":"https://github.com/grosser","followers_url":"https://api.github.com/users/grosser/followers","following_url":"https://api.github.com/users/grosser/following{/other_user}","gists_url":"https://api.github.com/users/grosser/gists{/gist_id}","starred_url":"https://api.github.com/users/grosser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grosser/subscriptions","organizations_url":"https://api.github.com/users/grosser/orgs","repos_url":"https://api.github.com/users/grosser/repos","events_url":"https://api.github.com/users/grosser/events{/privacy}","received_events_url":"https://api.github.com/users/grosser/received_events","type":"User","site_admin":false},"repo":{"id":203076,"name":"parallel_tests","full_name":"grosser/parallel_tests","owner":{"login":"grosser","id":11367,"avatar_url":"https://avatars.githubusercontent.com/u/11367?","gravatar_id":"59436ecd4fe6ad7c34f67654d839f05f","url":"https://api.github.com/users/grosser","html_url":"https://github.com/grosser","followers_url":"https://api.github.com/users/grosser/followers","following_url":"https://api.github.com/users/grosser/following{/other_user}","gists_url":"https://api.github.com/users/grosser/gists{/gist_id}","starred_url":"https://api.github.com/users/grosser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grosser/subscriptions","organizations_url":"https://api.github.com/users/grosser/orgs","repos_url":"https://api.github.com/users/grosser/repos","events_url":"https://api.github.com/users/grosser/events{/privacy}","received_events_url":"https://api.github.com/users/grosser/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/grosser/parallel_tests","description":"Rails: 2 CPUs = 2x Testing Speed for RSpec, Test::Unit and Cucumber","fork":false,"url":"https://api.github.com/repos/grosser/parallel_tests","forks_url":"https://api.github.com/repos/grosser/parallel_tests/forks","keys_url":"https://api.github.com/repos/grosser/parallel_tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grosser/parallel_tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grosser/parallel_tests/teams","hooks_url":"https://api.github.com/repos/grosser/parallel_tests/hooks","issue_events_url":"https://api.github.com/repos/grosser/parallel_tests/issues/events{/number}","events_url":"https://api.github.com/repos/grosser/parallel_tests/events","assignees_url":"https://api.github.com/repos/grosser/parallel_tests/assignees{/user}","branches_url":"https://api.github.com/repos/grosser/parallel_tests/branches{/branch}","tags_url":"https://api.github.com/repos/grosser/parallel_tests/tags","blobs_url":"https://api.github.com/repos/grosser/parallel_tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grosser/parallel_tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grosser/parallel_tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/grosser/parallel_tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grosser/parallel_tests/statuses/{sha}","languages_url":"https://api.github.com/repos/grosser/parallel_tests/languages","stargazers_url":"https://api.github.com/repos/grosser/parallel_tests/stargazers","contributors_url":"https://api.github.com/repos/grosser/parallel_tests/contributors","subscribers_url":"https://api.github.com/repos/grosser/parallel_tests/subscribers","subscription_url":"https://api.github.com/repos/grosser/parallel_tests/subscription","commits_url":"https://api.github.com/repos/grosser/parallel_tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/grosser/parallel_tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/grosser/parallel_tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/grosser/parallel_tests/issues/comments/{number}","contents_url":"https://api.github.com/repos/grosser/parallel_tests/contents/{+path}","compare_url":"https://api.github.com/repos/grosser/parallel_tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grosser/parallel_tests/merges","archive_url":"https://api.github.com/repos/grosser/parallel_tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grosser/parallel_tests/downloads","issues_url":"https://api.github.com/repos/grosser/parallel_tests/issues{/number}","pulls_url":"https://api.github.com/repos/grosser/parallel_tests/pulls{/number}","milestones_url":"https://api.github.com/repos/grosser/parallel_tests/milestones{/number}","notifications_url":"https://api.github.com/repos/grosser/parallel_tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grosser/parallel_tests/labels{/name}","releases_url":"https://api.github.com/repos/grosser/parallel_tests/releases{/id}","created_at":"2009-05-17T10:54:32Z","updated_at":"2014-06-06T04:14:30Z","pushed_at":"2014-06-06T04:14:29Z","git_url":"git://github.com/grosser/parallel_tests.git","ssh_url":"git@github.com:grosser/parallel_tests.git","clone_url":"https://github.com/grosser/parallel_tests.git","svn_url":"https://github.com/grosser/parallel_tests","homepage":"","size":3668,"stargazers_count":1174,"watchers_count":1174,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":238,"mirror_url":null,"open_issues_count":35,"forks":238,"open_issues":35,"watchers":1174,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grosser/parallel_tests/pulls/321"},"html":{"href":"https://github.com/grosser/parallel_tests/pull/321"},"issue":{"href":"https://api.github.com/repos/grosser/parallel_tests/issues/321"},"comments":{"href":"https://api.github.com/repos/grosser/parallel_tests/issues/321/comments"},"review_comments":{"href":"https://api.github.com/repos/grosser/parallel_tests/pulls/321/comments"},"review_comment":{"href":"https://api.github.com/repos/grosser/parallel_tests/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/grosser/parallel_tests/pulls/321/commits"},"statuses":{"href":"https://api.github.com/repos/grosser/parallel_tests/statuses/a86585ef71f09999c433d24528b9aa5702a52741"}}}}