GitHub PullRequestEvent at 2014-05-04 19:45:46
Repository: openFrameworks
Actor: ofTheo
Payload: {"action":"opened","number":2962,"pull_request":{"url":"https://api.github.com/repos/openframeworks/openFrameworks/pulls/2962","id":15474699,"html_url":"https://github.com/openframeworks/openFrameworks/pull/2962","diff_url":"https://github.com/openframeworks/openFrameworks/pull/2962.diff","patch_url":"https://github.com/openframeworks/openFrameworks/pull/2962.patch","issue_url":"https://api.github.com/repos/openframeworks/openFrameworks/issues/2962","number":2962,"state":"open","title":"ofxiOSGetDeviceInfo for querying device type and major / minor versions. ","user":{"login":"ofTheo","id":144000,"avatar_url":"https://avatars.githubusercontent.com/u/144000?","gravatar_id":"3b0860ec0180f7fb7ac4d2cd9252ec3f","url":"https://api.github.com/users/ofTheo","html_url":"https://github.com/ofTheo","followers_url":"https://api.github.com/users/ofTheo/followers","following_url":"https://api.github.com/users/ofTheo/following{/other_user}","gists_url":"https://api.github.com/users/ofTheo/gists{/gist_id}","starred_url":"https://api.github.com/users/ofTheo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofTheo/subscriptions","organizations_url":"https://api.github.com/users/ofTheo/orgs","repos_url":"https://api.github.com/users/ofTheo/repos","events_url":"https://api.github.com/users/ofTheo/events{/privacy}","received_events_url":"https://api.github.com/users/ofTheo/received_events","type":"User","site_admin":false},"body":"As discussed in #2872 \r\n\r\nThis is a more future proof approach for determining version of iOS devices ( vs the older approach of listing every single possible device i.e.: OFXIOS_DEVICE_IPHONE_3GS  OFXIOS_DEVICE_IPHONE_3GS_CHINA etc ) \r\n\r\nIt returns ofxiOSDeviceInfo which contains device type, device string and major and minor versions of the device. \r\nIn the future we could add more info to ofxiOSDeviceInfo i.e.: `bHasCamera` `bRetina` etc \r\n\r\nHere is how it currently works with the an iPhone 5 and the simulator. \r\n\r\n    ofxiOSDeviceInfo info = ofxiOSGetDeviceInfo();\r\n    cout << \"device type \" << (int)info.deviceType <<endl;\r\n    cout << \"device string \" << info.deviceString <<endl;\r\n    cout << \"versionMajor \" << info.versionMajor <<endl;\r\n    cout << \"versionMinor \" << info.versionMinor <<endl;\r\n\r\n    device type 0  // ( OFXIOS_DEVICE_IPHONE )\r\n    device string iPhone5,2\r\n    versionMajor 5\r\n    versionMinor 2\r\n\r\n    device type 0 // ( OFXIOS_DEVICE_IPHONE )\r\n    device string iPhone Simulator\r\n    versionMajor 0\r\n    versionMinor 0\r\n\r\npinging @julapy @admsyn ","created_at":"2014-05-04T19:45:45Z","updated_at":"2014-05-04T19:45:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dbc2a3db2bd837a53b26388ba82b3f9484c8029f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openframeworks/openFrameworks/pulls/2962/commits","review_comments_url":"https://api.github.com/repos/openframeworks/openFrameworks/pulls/2962/comments","review_comment_url":"https://api.github.com/repos/openframeworks/openFrameworks/pulls/comments/{number}","comments_url":"https://api.github.com/repos/openframeworks/openFrameworks/issues/2962/comments","statuses_url":"https://api.github.com/repos/openframeworks/openFrameworks/statuses/5324a8142d8bc4d31d839f5a069531a7f2664fc1","head":{"label":"openframeworks:feature_ios_device","ref":"feature_ios_device","sha":"5324a8142d8bc4d31d839f5a069531a7f2664fc1","user":{"login":"openframeworks","id":142866,"avatar_url":"https://avatars.githubusercontent.com/u/142866?","gravatar_id":"1061569f505705f6ba1f485673c5cc3b","url":"https://api.github.com/users/openframeworks","html_url":"https://github.com/openframeworks","followers_url":"https://api.github.com/users/openframeworks/followers","following_url":"https://api.github.com/users/openframeworks/following{/other_user}","gists_url":"https://api.github.com/users/openframeworks/gists{/gist_id}","starred_url":"https://api.github.com/users/openframeworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openframeworks/subscriptions","organizations_url":"https://api.github.com/users/openframeworks/orgs","repos_url":"https://api.github.com/users/openframeworks/repos","events_url":"https://api.github.com/users/openframeworks/events{/privacy}","received_events_url":"https://api.github.com/users/openframeworks/received_events","type":"Organization","site_admin":false},"repo":{"id":345337,"name":"openFrameworks","full_name":"openframeworks/openFrameworks","owner":{"login":"openframeworks","id":142866,"avatar_url":"https://avatars.githubusercontent.com/u/142866?","gravatar_id":"1061569f505705f6ba1f485673c5cc3b","url":"https://api.github.com/users/openframeworks","html_url":"https://github.com/openframeworks","followers_url":"https://api.github.com/users/openframeworks/followers","following_url":"https://api.github.com/users/openframeworks/following{/other_user}","gists_url":"https://api.github.com/users/openframeworks/gists{/gist_id}","starred_url":"https://api.github.com/users/openframeworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openframeworks/subscriptions","organizations_url":"https://api.github.com/users/openframeworks/orgs","repos_url":"https://api.github.com/users/openframeworks/repos","events_url":"https://api.github.com/users/openframeworks/events{/privacy}","received_events_url":"https://api.github.com/users/openframeworks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openframeworks/openFrameworks","description":"OpenFrameworks is a cross platform open source toolkit for creative coding in C++.","fork":false,"url":"https://api.github.com/repos/openframeworks/openFrameworks","forks_url":"https://api.github.com/repos/openframeworks/openFrameworks/forks","keys_url":"https://api.github.com/repos/openframeworks/openFrameworks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openframeworks/openFrameworks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openframeworks/openFrameworks/teams","hooks_url":"https://api.github.com/repos/openframeworks/openFrameworks/hooks","issue_events_url":"https://api.github.com/repos/openframeworks/openFrameworks/issues/events{/number}","events_url":"https://api.github.com/repos/openframeworks/openFrameworks/events","assignees_url":"https://api.github.com/repos/openframeworks/openFrameworks/assignees{/user}","branches_url":"https://api.github.com/repos/openframeworks/openFrameworks/branches{/branch}","tags_url":"https://api.github.com/repos/openframeworks/openFrameworks/tags","blobs_url":"https://api.github.com/repos/openframeworks/openFrameworks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openframeworks/openFrameworks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openframeworks/openFrameworks/git/refs{/sha}","trees_url":"https://api.github.com/repos/openframeworks/openFrameworks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openframeworks/openFrameworks/statuses/{sha}","languages_url":"https://api.github.com/repos/openframeworks/openFrameworks/languages","stargazers_url":"https://api.github.com/repos/openframeworks/openFrameworks/stargazers","contributors_url":"https://api.github.com/repos/openframeworks/openFrameworks/contributors","subscribers_url":"https://api.github.com/repos/openframeworks/openFrameworks/subscribers","subscription_url":"https://api.github.com/repos/openframeworks/openFrameworks/subscription","commits_url":"https://api.github.com/repos/openframeworks/openFrameworks/commits{/sha}","git_commits_url":"https://api.github.com/repos/openframeworks/openFrameworks/git/commits{/sha}","comments_url":"https://api.github.com/repos/openframeworks/openFrameworks/comments{/number}","issue_comment_url":"https://api.github.com/repos/openframeworks/openFrameworks/issues/comments/{number}","contents_url":"https://api.github.com/repos/openframeworks/openFrameworks/contents/{+path}","compare_url":"https://api.github.com/repos/openframeworks/openFrameworks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openframeworks/openFrameworks/merges","archive_url":"https://api.github.com/repos/openframeworks/openFrameworks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openframeworks/openFrameworks/downloads","issues_url":"https://api.github.com/repos/openframeworks/openFrameworks/issues{/number}","pulls_url":"https://api.github.com/repos/openframeworks/openFrameworks/pulls{/number}","milestones_url":"https://api.github.com/repos/openframeworks/openFrameworks/milestones{/number}","notifications_url":"https://api.github.com/repos/openframeworks/openFrameworks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openframeworks/openFrameworks/labels{/name}","releases_url":"https://api.github.com/repos/openframeworks/openFrameworks/releases{/id}","created_at":"2009-10-21T21:55:54Z","updated_at":"2014-05-04T19:45:45Z","pushed_at":"2014-05-04T19:39:57Z","git_url":"git://github.com/openframeworks/openFrameworks.git","ssh_url":"git@github.com:openframeworks/openFrameworks.git","clone_url":"https://github.com/openframeworks/openFrameworks.git","svn_url":"https://github.com/openframeworks/openFrameworks","homepage":"http://openframeworks.cc","size":1032199,"stargazers_count":2809,"watchers_count":2809,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":913,"mirror_url":null,"open_issues_count":620,"forks":913,"open_issues":620,"watchers":2809,"default_branch":"master"}},"base":{"label":"openframeworks:master","ref":"master","sha":"f4f1d1f4c9f3a3040e037863ddc07e3059c3f340","user":{"login":"openframeworks","id":142866,"avatar_url":"https://avatars.githubusercontent.com/u/142866?","gravatar_id":"1061569f505705f6ba1f485673c5cc3b","url":"https://api.github.com/users/openframeworks","html_url":"https://github.com/openframeworks","followers_url":"https://api.github.com/users/openframeworks/followers","following_url":"https://api.github.com/users/openframeworks/following{/other_user}","gists_url":"https://api.github.com/users/openframeworks/gists{/gist_id}","starred_url":"https://api.github.com/users/openframeworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openframeworks/subscriptions","organizations_url":"https://api.github.com/users/openframeworks/orgs","repos_url":"https://api.github.com/users/openframeworks/repos","events_url":"https://api.github.com/users/openframeworks/events{/privacy}","received_events_url":"https://api.github.com/users/openframeworks/received_events","type":"Organization","site_admin":false},"repo":{"id":345337,"name":"openFrameworks","full_name":"openframeworks/openFrameworks","owner":{"login":"openframeworks","id":142866,"avatar_url":"https://avatars.githubusercontent.com/u/142866?","gravatar_id":"1061569f505705f6ba1f485673c5cc3b","url":"https://api.github.com/users/openframeworks","html_url":"https://github.com/openframeworks","followers_url":"https://api.github.com/users/openframeworks/followers","following_url":"https://api.github.com/users/openframeworks/following{/other_user}","gists_url":"https://api.github.com/users/openframeworks/gists{/gist_id}","starred_url":"https://api.github.com/users/openframeworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openframeworks/subscriptions","organizations_url":"https://api.github.com/users/openframeworks/orgs","repos_url":"https://api.github.com/users/openframeworks/repos","events_url":"https://api.github.com/users/openframeworks/events{/privacy}","received_events_url":"https://api.github.com/users/openframeworks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openframeworks/openFrameworks","description":"OpenFrameworks is a cross platform open source toolkit for creative coding in C++.","fork":false,"url":"https://api.github.com/repos/openframeworks/openFrameworks","forks_url":"https://api.github.com/repos/openframeworks/openFrameworks/forks","keys_url":"https://api.github.com/repos/openframeworks/openFrameworks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openframeworks/openFrameworks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openframeworks/openFrameworks/teams","hooks_url":"https://api.github.com/repos/openframeworks/openFrameworks/hooks","issue_events_url":"https://api.github.com/repos/openframeworks/openFrameworks/issues/events{/number}","events_url":"https://api.github.com/repos/openframeworks/openFrameworks/events","assignees_url":"https://api.github.com/repos/openframeworks/openFrameworks/assignees{/user}","branches_url":"https://api.github.com/repos/openframeworks/openFrameworks/branches{/branch}","tags_url":"https://api.github.com/repos/openframeworks/openFrameworks/tags","blobs_url":"https://api.github.com/repos/openframeworks/openFrameworks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openframeworks/openFrameworks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openframeworks/openFrameworks/git/refs{/sha}","trees_url":"https://api.github.com/repos/openframeworks/openFrameworks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openframeworks/openFrameworks/statuses/{sha}","languages_url":"https://api.github.com/repos/openframeworks/openFrameworks/languages","stargazers_url":"https://api.github.com/repos/openframeworks/openFrameworks/stargazers","contributors_url":"https://api.github.com/repos/openframeworks/openFrameworks/contributors","subscribers_url":"https://api.github.com/repos/openframeworks/openFrameworks/subscribers","subscription_url":"https://api.github.com/repos/openframeworks/openFrameworks/subscription","commits_url":"https://api.github.com/repos/openframeworks/openFrameworks/commits{/sha}","git_commits_url":"https://api.github.com/repos/openframeworks/openFrameworks/git/commits{/sha}","comments_url":"https://api.github.com/repos/openframeworks/openFrameworks/comments{/number}","issue_comment_url":"https://api.github.com/repos/openframeworks/openFrameworks/issues/comments/{number}","contents_url":"https://api.github.com/repos/openframeworks/openFrameworks/contents/{+path}","compare_url":"https://api.github.com/repos/openframeworks/openFrameworks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openframeworks/openFrameworks/merges","archive_url":"https://api.github.com/repos/openframeworks/openFrameworks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openframeworks/openFrameworks/downloads","issues_url":"https://api.github.com/repos/openframeworks/openFrameworks/issues{/number}","pulls_url":"https://api.github.com/repos/openframeworks/openFrameworks/pulls{/number}","milestones_url":"https://api.github.com/repos/openframeworks/openFrameworks/milestones{/number}","notifications_url":"https://api.github.com/repos/openframeworks/openFrameworks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openframeworks/openFrameworks/labels{/name}","releases_url":"https://api.github.com/repos/openframeworks/openFrameworks/releases{/id}","created_at":"2009-10-21T21:55:54Z","updated_at":"2014-05-04T19:45:45Z","pushed_at":"2014-05-04T19:39:57Z","git_url":"git://github.com/openframeworks/openFrameworks.git","ssh_url":"git@github.com:openframeworks/openFrameworks.git","clone_url":"https://github.com/openframeworks/openFrameworks.git","svn_url":"https://github.com/openframeworks/openFrameworks","homepage":"http://openframeworks.cc","size":1032199,"stargazers_count":2809,"watchers_count":2809,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":913,"mirror_url":null,"open_issues_count":620,"forks":913,"open_issues":620,"watchers":2809,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openframeworks/openFrameworks/pulls/2962"},"html":{"href":"https://github.com/openframeworks/openFrameworks/pull/2962"},"issue":{"href":"https://api.github.com/repos/openframeworks/openFrameworks/issues/2962"},"comments":{"href":"https://api.github.com/repos/openframeworks/openFrameworks/issues/2962/comments"},"review_comments":{"href":"https://api.github.com/repos/openframeworks/openFrameworks/pulls/2962/comments"},"review_comment":{"href":"https://api.github.com/repos/openframeworks/openFrameworks/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/openframeworks/openFrameworks/pulls/2962/commits"},"statuses":{"href":"https://api.github.com/repos/openframeworks/openFrameworks/statuses/5324a8142d8bc4d31d839f5a069531a7f2664fc1"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":63,"deletions":0,"changed_files":2}}