GitHub PullRequestReviewCommentEvent at 2014-10-22 09:05:51
Repository: webrtc
Actor: samdutton
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/GoogleChrome/webrtc/pulls/comments/19201595","id":19201595,"diff_hunk":"@@ -220,31 +206,35 @@ function updateGetUserMediaConstraints() {\n                                        selectedVideoDevice);\n \n     if ($('audio').checked) {\n-      if (devices.audioId != null)\n+      if (typeof(devices.audioId) !== 'undefined') {\n         constraints.audio = {optional: [{sourceId: devices.audioId}]};\n+      }\n     }\n \n     if ($('video').checked) {\n-      if (devices.videoId != null)\n+      if (typeof(devices.videoId) !== 'undefined') {","path":"samples/web/content/manual-test/peer2peer/js/main.js","position":261,"original_position":261,"commit_id":"309206c4ebc9afbb0310b4dc6724f2155b487b9a","original_commit_id":"309206c4ebc9afbb0310b4dc6724f2155b487b9a","user":{"login":"samdutton","id":205226,"avatar_url":"https://avatars.githubusercontent.com/u/205226?v=2","gravatar_id":"","url":"https://api.github.com/users/samdutton","html_url":"https://github.com/samdutton","followers_url":"https://api.github.com/users/samdutton/followers","following_url":"https://api.github.com/users/samdutton/following{/other_user}","gists_url":"https://api.github.com/users/samdutton/gists{/gist_id}","starred_url":"https://api.github.com/users/samdutton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samdutton/subscriptions","organizations_url":"https://api.github.com/users/samdutton/orgs","repos_url":"https://api.github.com/users/samdutton/repos","events_url":"https://api.github.com/users/samdutton/events{/privacy}","received_events_url":"https://api.github.com/users/samdutton/received_events","type":"User","site_admin":false},"body":"Remove parentheses for typeof","created_at":"2014-10-22T09:05:51Z","updated_at":"2014-10-22T09:05:51Z","html_url":"https://github.com/GoogleChrome/webrtc/pull/158#discussion_r19201595","pull_request_url":"https://api.github.com/repos/GoogleChrome/webrtc/pulls/158","_links":{"self":{"href":"https://api.github.com/repos/GoogleChrome/webrtc/pulls/comments/19201595"},"html":{"href":"https://github.com/GoogleChrome/webrtc/pull/158#discussion_r19201595"},"pull_request":{"href":"https://api.github.com/repos/GoogleChrome/webrtc/pulls/158"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleChrome/webrtc/pulls/158","id":22861495,"html_url":"https://github.com/GoogleChrome/webrtc/pull/158","diff_url":"https://github.com/GoogleChrome/webrtc/pull/158.diff","patch_url":"https://github.com/GoogleChrome/webrtc/pull/158.patch","issue_url":"https://api.github.com/repos/GoogleChrome/webrtc/issues/158","number":158,"state":"open","locked":false,"title":"Peer2Peer - Fixed all JSHint errors which wont affect (mostly) the planned refactor to classes + some tidying","user":{"login":"KaptenJansson","id":5872605,"avatar_url":"https://avatars.githubusercontent.com/u/5872605?v=2","gravatar_id":"","url":"https://api.github.com/users/KaptenJansson","html_url":"https://github.com/KaptenJansson","followers_url":"https://api.github.com/users/KaptenJansson/followers","following_url":"https://api.github.com/users/KaptenJansson/following{/other_user}","gists_url":"https://api.github.com/users/KaptenJansson/gists{/gist_id}","starred_url":"https://api.github.com/users/KaptenJansson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KaptenJansson/subscriptions","organizations_url":"https://api.github.com/users/KaptenJansson/orgs","repos_url":"https://api.github.com/users/KaptenJansson/repos","events_url":"https://api.github.com/users/KaptenJansson/events{/privacy}","received_events_url":"https://api.github.com/users/KaptenJansson/received_events","type":"User","site_admin":false},"body":"Fixed all JSHint issues except [1].\r\nChanged all comments to // in favor of /*. \r\nRemoved @private comments.\r\nAdded 'use strict' + fixed the errors.\r\nChanged to use equality operators and typeof().\r\n\r\nThe remaining JSHint errors [1]  will be taken care of when it's rewritten as classes.\r\n[1] - Snippet of errors:\r\n\r\nBad option: 'global'.\r\neval can be harmful.\r\n'MediaStreamTrack' is not defined.\r\n'getUserMediaFromHere' is defined but never used.","created_at":"2014-10-16T15:01:45Z","updated_at":"2014-10-22T09:05:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f988f1cef7e003e2deab9cbf8ffbf62b83ed6f53","assignee":{"login":"samdutton","id":205226,"avatar_url":"https://avatars.githubusercontent.com/u/205226?v=2","gravatar_id":"","url":"https://api.github.com/users/samdutton","html_url":"https://github.com/samdutton","followers_url":"https://api.github.com/users/samdutton/followers","following_url":"https://api.github.com/users/samdutton/following{/other_user}","gists_url":"https://api.github.com/users/samdutton/gists{/gist_id}","starred_url":"https://api.github.com/users/samdutton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samdutton/subscriptions","organizations_url":"https://api.github.com/users/samdutton/orgs","repos_url":"https://api.github.com/users/samdutton/repos","events_url":"https://api.github.com/users/samdutton/events{/privacy}","received_events_url":"https://api.github.com/users/samdutton/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/GoogleChrome/webrtc/pulls/158/commits","review_comments_url":"https://api.github.com/repos/GoogleChrome/webrtc/pulls/158/comments","review_comment_url":"https://api.github.com/repos/GoogleChrome/webrtc/pulls/comments/{number}","comments_url":"https://api.github.com/repos/GoogleChrome/webrtc/issues/158/comments","statuses_url":"https://api.github.com/repos/GoogleChrome/webrtc/statuses/309206c4ebc9afbb0310b4dc6724f2155b487b9a","head":{"label":"GoogleChrome:fixjshint","ref":"fixjshint","sha":"309206c4ebc9afbb0310b4dc6724f2155b487b9a","user":{"login":"GoogleChrome","id":1778935,"avatar_url":"https://avatars.githubusercontent.com/u/1778935?v=2","gravatar_id":"","url":"https://api.github.com/users/GoogleChrome","html_url":"https://github.com/GoogleChrome","followers_url":"https://api.github.com/users/GoogleChrome/followers","following_url":"https://api.github.com/users/GoogleChrome/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChrome/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChrome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChrome/subscriptions","organizations_url":"https://api.github.com/users/GoogleChrome/orgs","repos_url":"https://api.github.com/users/GoogleChrome/repos","events_url":"https://api.github.com/users/GoogleChrome/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChrome/received_events","type":"Organization","site_admin":false},"repo":{"id":12970971,"name":"webrtc","full_name":"GoogleChrome/webrtc","owner":{"login":"GoogleChrome","id":1778935,"avatar_url":"https://avatars.githubusercontent.com/u/1778935?v=2","gravatar_id":"","url":"https://api.github.com/users/GoogleChrome","html_url":"https://github.com/GoogleChrome","followers_url":"https://api.github.com/users/GoogleChrome/followers","following_url":"https://api.github.com/users/GoogleChrome/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChrome/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChrome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChrome/subscriptions","organizations_url":"https://api.github.com/users/GoogleChrome/orgs","repos_url":"https://api.github.com/users/GoogleChrome/repos","events_url":"https://api.github.com/users/GoogleChrome/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChrome/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleChrome/webrtc","description":"WebRTC demos and samples","fork":false,"url":"https://api.github.com/repos/GoogleChrome/webrtc","forks_url":"https://api.github.com/repos/GoogleChrome/webrtc/forks","keys_url":"https://api.github.com/repos/GoogleChrome/webrtc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleChrome/webrtc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleChrome/webrtc/teams","hooks_url":"https://api.github.com/repos/GoogleChrome/webrtc/hooks","issue_events_url":"https://api.github.com/repos/GoogleChrome/webrtc/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleChrome/webrtc/events","assignees_url":"https://api.github.com/repos/GoogleChrome/webrtc/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleChrome/webrtc/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleChrome/webrtc/tags","blobs_url":"https://api.github.com/repos/GoogleChrome/webrtc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleChrome/webrtc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleChrome/webrtc/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleChrome/webrtc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleChrome/webrtc/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleChrome/webrtc/languages","stargazers_url":"https://api.github.com/repos/GoogleChrome/webrtc/stargazers","contributors_url":"https://api.github.com/repos/GoogleChrome/webrtc/contributors","subscribers_url":"https://api.github.com/repos/GoogleChrome/webrtc/subscribers","subscription_url":"https://api.github.com/repos/GoogleChrome/webrtc/subscription","commits_url":"https://api.github.com/repos/GoogleChrome/webrtc/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleChrome/webrtc/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleChrome/webrtc/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleChrome/webrtc/issues/comments/{number}","contents_url":"https://api.github.com/repos/GoogleChrome/webrtc/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleChrome/webrtc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleChrome/webrtc/merges","archive_url":"https://api.github.com/repos/GoogleChrome/webrtc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleChrome/webrtc/downloads","issues_url":"https://api.github.com/repos/GoogleChrome/webrtc/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleChrome/webrtc/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleChrome/webrtc/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleChrome/webrtc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleChrome/webrtc/labels{/name}","releases_url":"https://api.github.com/repos/GoogleChrome/webrtc/releases{/id}","created_at":"2013-09-20T10:40:23Z","updated_at":"2014-10-21T03:47:11Z","pushed_at":"2014-10-21T17:36:29Z","git_url":"git://github.com/GoogleChrome/webrtc.git","ssh_url":"git@github.com:GoogleChrome/webrtc.git","clone_url":"https://github.com/GoogleChrome/webrtc.git","svn_url":"https://github.com/GoogleChrome/webrtc","homepage":"http://googlechrome.github.io/webrtc/","size":8043,"stargazers_count":390,"watchers_count":390,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":219,"mirror_url":null,"open_issues_count":43,"forks":219,"open_issues":43,"watchers":390,"default_branch":"master"}},"base":{"label":"GoogleChrome:master","ref":"master","sha":"f0c6c46d7ed6b4196484008609974e1e8e95d389","user":{"login":"GoogleChrome","id":1778935,"avatar_url":"https://avatars.githubusercontent.com/u/1778935?v=2","gravatar_id":"","url":"https://api.github.com/users/GoogleChrome","html_url":"https://github.com/GoogleChrome","followers_url":"https://api.github.com/users/GoogleChrome/followers","following_url":"https://api.github.com/users/GoogleChrome/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChrome/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChrome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChrome/subscriptions","organizations_url":"https://api.github.com/users/GoogleChrome/orgs","repos_url":"https://api.github.com/users/GoogleChrome/repos","events_url":"https://api.github.com/users/GoogleChrome/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChrome/received_events","type":"Organization","site_admin":false},"repo":{"id":12970971,"name":"webrtc","full_name":"GoogleChrome/webrtc","owner":{"login":"GoogleChrome","id":1778935,"avatar_url":"https://avatars.githubusercontent.com/u/1778935?v=2","gravatar_id":"","url":"https://api.github.com/users/GoogleChrome","html_url":"https://github.com/GoogleChrome","followers_url":"https://api.github.com/users/GoogleChrome/followers","following_url":"https://api.github.com/users/GoogleChrome/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChrome/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChrome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChrome/subscriptions","organizations_url":"https://api.github.com/users/GoogleChrome/orgs","repos_url":"https://api.github.com/users/GoogleChrome/repos","events_url":"https://api.github.com/users/GoogleChrome/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChrome/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleChrome/webrtc","description":"WebRTC demos and samples","fork":false,"url":"https://api.github.com/repos/GoogleChrome/webrtc","forks_url":"https://api.github.com/repos/GoogleChrome/webrtc/forks","keys_url":"https://api.github.com/repos/GoogleChrome/webrtc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleChrome/webrtc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleChrome/webrtc/teams","hooks_url":"https://api.github.com/repos/GoogleChrome/webrtc/hooks","issue_events_url":"https://api.github.com/repos/GoogleChrome/webrtc/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleChrome/webrtc/events","assignees_url":"https://api.github.com/repos/GoogleChrome/webrtc/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleChrome/webrtc/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleChrome/webrtc/tags","blobs_url":"https://api.github.com/repos/GoogleChrome/webrtc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleChrome/webrtc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleChrome/webrtc/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleChrome/webrtc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleChrome/webrtc/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleChrome/webrtc/languages","stargazers_url":"https://api.github.com/repos/GoogleChrome/webrtc/stargazers","contributors_url":"https://api.github.com/repos/GoogleChrome/webrtc/contributors","subscribers_url":"https://api.github.com/repos/GoogleChrome/webrtc/subscribers","subscription_url":"https://api.github.com/repos/GoogleChrome/webrtc/subscription","commits_url":"https://api.github.com/repos/GoogleChrome/webrtc/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleChrome/webrtc/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleChrome/webrtc/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleChrome/webrtc/issues/comments/{number}","contents_url":"https://api.github.com/repos/GoogleChrome/webrtc/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleChrome/webrtc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleChrome/webrtc/merges","archive_url":"https://api.github.com/repos/GoogleChrome/webrtc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleChrome/webrtc/downloads","issues_url":"https://api.github.com/repos/GoogleChrome/webrtc/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleChrome/webrtc/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleChrome/webrtc/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleChrome/webrtc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleChrome/webrtc/labels{/name}","releases_url":"https://api.github.com/repos/GoogleChrome/webrtc/releases{/id}","created_at":"2013-09-20T10:40:23Z","updated_at":"2014-10-21T03:47:11Z","pushed_at":"2014-10-21T17:36:29Z","git_url":"git://github.com/GoogleChrome/webrtc.git","ssh_url":"git@github.com:GoogleChrome/webrtc.git","clone_url":"https://github.com/GoogleChrome/webrtc.git","svn_url":"https://github.com/GoogleChrome/webrtc","homepage":"http://googlechrome.github.io/webrtc/","size":8043,"stargazers_count":390,"watchers_count":390,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":219,"mirror_url":null,"open_issues_count":43,"forks":219,"open_issues":43,"watchers":390,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleChrome/webrtc/pulls/158"},"html":{"href":"https://github.com/GoogleChrome/webrtc/pull/158"},"issue":{"href":"https://api.github.com/repos/GoogleChrome/webrtc/issues/158"},"comments":{"href":"https://api.github.com/repos/GoogleChrome/webrtc/issues/158/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleChrome/webrtc/pulls/158/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleChrome/webrtc/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/GoogleChrome/webrtc/pulls/158/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleChrome/webrtc/statuses/309206c4ebc9afbb0310b4dc6724f2155b487b9a"}}}}