GitHub PullRequestReviewCommentEvent at 2014-09-10 22:03:24
Repository: DoctrinePHPCRBundle
Actor: greg0ire
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/doctrine/DoctrinePHPCRBundle/pulls/comments/17392298","id":17392298,"diff_hunk":"@@ -86,6 +86,23 @@ public function __construct(LocaleChooser $chooser, array $allowedLocales, $fall\n     }\n \n     /**\n+     * Decides which locale will be used.\n+     *\n+     * @param GetResponseEvent $event used to get the request\n+     *\n+     * @return mixed string|false a locale or false it cannot be found in the","path":"EventListener/LocaleListener.php","position":8,"original_position":8,"commit_id":"66e247e7f52f28863bfbd34a6dea080c69920704","original_commit_id":"66e247e7f52f28863bfbd34a6dea080c69920704","user":{"login":"greg0ire","id":657779,"avatar_url":"https://avatars.githubusercontent.com/u/657779?v=2","gravatar_id":"66a7716a3557d0feabd739cd930875fb","url":"https://api.github.com/users/greg0ire","html_url":"https://github.com/greg0ire","followers_url":"https://api.github.com/users/greg0ire/followers","following_url":"https://api.github.com/users/greg0ire/following{/other_user}","gists_url":"https://api.github.com/users/greg0ire/gists{/gist_id}","starred_url":"https://api.github.com/users/greg0ire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greg0ire/subscriptions","organizations_url":"https://api.github.com/users/greg0ire/orgs","repos_url":"https://api.github.com/users/greg0ire/repos","events_url":"https://api.github.com/users/greg0ire/events{/privacy}","received_events_url":"https://api.github.com/users/greg0ire/received_events","type":"User","site_admin":false},"body":"woops. I forgot a word \"*if* it cannot be found. I'll make this small PR with your sentence rightaway","created_at":"2014-09-10T22:03:24Z","updated_at":"2014-09-10T22:03:24Z","html_url":"https://github.com/doctrine/DoctrinePHPCRBundle/pull/166#discussion_r17392298","pull_request_url":"https://api.github.com/repos/doctrine/DoctrinePHPCRBundle/pulls/166","_links":{"self":{"href":"https://api.github.com/repos/doctrine/DoctrinePHPCRBundle/pulls/comments/17392298"},"html":{"href":"https://github.com/doctrine/DoctrinePHPCRBundle/pull/166#discussion_r17392298"},"pull_request":{"href":"https://api.github.com/repos/doctrine/DoctrinePHPCRBundle/pulls/166"}}},"pull_request":{"url":"https://api.github.com/repos/doctrine/DoctrinePHPCRBundle/pulls/166","id":20880530,"html_url":"https://github.com/doctrine/DoctrinePHPCRBundle/pull/166","diff_url":"https://github.com/doctrine/DoctrinePHPCRBundle/pull/166.diff","patch_url":"https://github.com/doctrine/DoctrinePHPCRBundle/pull/166.patch","issue_url":"https://api.github.com/repos/doctrine/DoctrinePHPCRBundle/issues/166","number":166,"state":"closed","locked":false,"title":"Extensibility","user":{"login":"greg0ire","id":657779,"avatar_url":"https://avatars.githubusercontent.com/u/657779?v=2","gravatar_id":"66a7716a3557d0feabd739cd930875fb","url":"https://api.github.com/users/greg0ire","html_url":"https://github.com/greg0ire","followers_url":"https://api.github.com/users/greg0ire/followers","following_url":"https://api.github.com/users/greg0ire/following{/other_user}","gists_url":"https://api.github.com/users/greg0ire/gists{/gist_id}","starred_url":"https://api.github.com/users/greg0ire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greg0ire/subscriptions","organizations_url":"https://api.github.com/users/greg0ire/orgs","repos_url":"https://api.github.com/users/greg0ire/repos","events_url":"https://api.github.com/users/greg0ire/events{/privacy}","received_events_url":"https://api.github.com/users/greg0ire/received_events","type":"User","site_admin":false},"body":"Using `private` visibility when creating classes in a library prevents easy code reuse. For instance, in our project, we decided to use the `locale` parameter for the UI, and use another parameter (named `content_locale`) for the content. On one of our website, there will be 2 UI languages, and 4 content langauges (it is an administration interface for a swiss project). We need to have another listener, but the developer in charge of this did not extend your class because he needed to rewrite the same properties because they were private. It's a shame, and it is not the first time this scenario happens to me. I think it calls for a (new ?) best practice : \r\n\r\n> When writing library code, try to avoid `private` .\r\n\r\nDo you agree ?","created_at":"2014-09-08T10:18:14Z","updated_at":"2014-09-10T22:03:24Z","closed_at":"2014-09-10T20:53:55Z","merged_at":"2014-09-10T20:53:55Z","merge_commit_sha":"bf2c8fd4077db3fb63c8eeed5ab4aa8e065028ff","assignee":null,"milestone":{"url":"https://api.github.com/repos/doctrine/DoctrinePHPCRBundle/milestones/3","labels_url":"https://api.github.com/repos/doctrine/DoctrinePHPCRBundle/milestones/3/labels","id":770851,"number":3,"title":"1.2","description":"","creator":{"login":"lsmith77","id":300279,"avatar_url":"https://avatars.githubusercontent.com/u/300279?v=2","gravatar_id":"54787afbd0e7c30936101c2fa84bd89b","url":"https://api.github.com/users/lsmith77","html_url":"https://github.com/lsmith77","followers_url":"https://api.github.com/users/lsmith77/followers","following_url":"https://api.github.com/users/lsmith77/following{/other_user}","gists_url":"https://api.github.com/users/lsmith77/gists{/gist_id}","starred_url":"https://api.github.com/users/lsmith77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsmith77/subscriptions","organizations_url":"https://api.github.com/users/lsmith77/orgs","repos_url":"https://api.github.com/users/lsmith77/repos","events_url":"https://api.github.com/users/lsmith77/events{/privacy}","received_events_url":"https://api.github.com/users/lsmith77/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":2,"state":"open","created_at":"2014-08-29T10:09:47Z","updated_at":"2014-09-10T20:53:55Z","due_on":"2014-09-30T07:00:00Z"},"commits_url":"https://api.github.com/repos/doctrine/DoctrinePHPCRBundle/pulls/166/commits","review_comments_url":"https://api.github.com/repos/doctrine/DoctrinePHPCRBundle/pulls/166/comments","review_comment_url":"https://api.github.com/repos/doctrine/DoctrinePHPCRBundle/pulls/comments/{number}","comments_url":"https://api.github.com/repos/doctrine/DoctrinePHPCRBundle/issues/166/comments","statuses_url":"https://api.github.com/repos/doctrine/DoctrinePHPCRBundle/statuses/66e247e7f52f28863bfbd34a6dea080c69920704","head":{"label":"greg0ire:extensibility","ref":"extensibility","sha":"66e247e7f52f28863bfbd34a6dea080c69920704","user":{"login":"greg0ire","id":657779,"avatar_url":"https://avatars.githubusercontent.com/u/657779?v=2","gravatar_id":"66a7716a3557d0feabd739cd930875fb","url":"https://api.github.com/users/greg0ire","html_url":"https://github.com/greg0ire","followers_url":"https://api.github.com/users/greg0ire/followers","following_url":"https://api.github.com/users/greg0ire/following{/other_user}","gists_url":"https://api.github.com/users/greg0ire/gists{/gist_id}","starred_url":"https://api.github.com/users/greg0ire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greg0ire/subscriptions","organizations_url":"https://api.github.com/users/greg0ire/orgs","repos_url":"https://api.github.com/users/greg0ire/repos","events_url":"https://api.github.com/users/greg0ire/events{/privacy}","received_events_url":"https://api.github.com/users/greg0ire/received_events","type":"User","site_admin":false},"repo":{"id":23786417,"name":"DoctrinePHPCRBundle","full_name":"greg0ire/DoctrinePHPCRBundle","owner":{"login":"greg0ire","id":657779,"avatar_url":"https://avatars.githubusercontent.com/u/657779?v=2","gravatar_id":"66a7716a3557d0feabd739cd930875fb","url":"https://api.github.com/users/greg0ire","html_url":"https://github.com/greg0ire","followers_url":"https://api.github.com/users/greg0ire/followers","following_url":"https://api.github.com/users/greg0ire/following{/other_user}","gists_url":"https://api.github.com/users/greg0ire/gists{/gist_id}","starred_url":"https://api.github.com/users/greg0ire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greg0ire/subscriptions","organizations_url":"https://api.github.com/users/greg0ire/orgs","repos_url":"https://api.github.com/users/greg0ire/repos","events_url":"https://api.github.com/users/greg0ire/events{/privacy}","received_events_url":"https://api.github.com/users/greg0ire/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/greg0ire/DoctrinePHPCRBundle","description":"This bundle integrates Doctrine PHPCR ODM and PHPCR backends into Symfony2","fork":true,"url":"https://api.github.com/repos/greg0ire/DoctrinePHPCRBundle","forks_url":"https://api.github.com/repos/greg0ire/DoctrinePHPCRBundle/forks","keys_url":"https://api.github.com/repos/greg0ire/DoctrinePHPCRBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greg0ire/DoctrinePHPCRBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greg0ire/DoctrinePHPCRBundle/teams","hooks_url":"https://api.github.com/repos/greg0ire/DoctrinePHPCRBundle/hooks","issue_events_url":"https://api.github.com/repos/greg0ire/DoctrinePHPCRBundle/issues/events{/number}","events_url":"https://api.github.com/repos/greg0ire/DoctrinePHPCRBundle/events","assignees_url":"https://api.github.com/repos/greg0ire/DoctrinePHPCRBundle/assignees{/user}","branches_url":"https://api.github.com/repos/greg0ire/DoctrinePHPCRBundle/branches{/branch}","tags_url":"https://api.github.com/repos/greg0ire/DoctrinePHPCRBundle/tags","blobs_url":"https://api.github.com/repos/greg0ire/DoctrinePHPCRBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greg0ire/DoctrinePHPCRBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greg0ire/DoctrinePHPCRBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/greg0ire/DoctrinePHPCRBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greg0ire/DoctrinePHPCRBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/greg0ire/DoctrinePHPCRBundle/languages","stargazers_url":"https://api.github.com/repos/greg0ire/DoctrinePHPCRBundle/stargazers","contributors_url":"https://api.github.com/repos/greg0ire/DoctrinePHPCRBundle/contributors","subscribers_url":"https://api.github.com/repos/greg0ire/DoctrinePHPCRBundle/subscribers","subscription_url":"https://api.github.com/repos/greg0ire/DoctrinePHPCRBundle/subscription","commits_url":"https://api.github.com/repos/greg0ire/DoctrinePHPCRBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/greg0ire/DoctrinePHPCRBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/greg0ire/DoctrinePHPCRBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/greg0ire/DoctrinePHPCRBundle/issues/comments/{number}","contents_url":"https://api.github.com/repos/greg0ire/DoctrinePHPCRBundle/contents/{+path}","compare_url":"https://api.github.com/repos/greg0ire/DoctrinePHPCRBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greg0ire/DoctrinePHPCRBundle/merges","archive_url":"https://api.github.com/repos/greg0ire/DoctrinePHPCRBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greg0ire/DoctrinePHPCRBundle/downloads","issues_url":"https://api.github.com/repos/greg0ire/DoctrinePHPCRBundle/issues{/number}","pulls_url":"https://api.github.com/repos/greg0ire/DoctrinePHPCRBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/greg0ire/DoctrinePHPCRBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/greg0ire/DoctrinePHPCRBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greg0ire/DoctrinePHPCRBundle/labels{/name}","releases_url":"https://api.github.com/repos/greg0ire/DoctrinePHPCRBundle/releases{/id}","created_at":"2014-09-08T10:13:08Z","updated_at":"2014-07-21T13:00:14Z","pushed_at":"2014-09-10T20:55:08Z","git_url":"git://github.com/greg0ire/DoctrinePHPCRBundle.git","ssh_url":"git@github.com:greg0ire/DoctrinePHPCRBundle.git","clone_url":"https://github.com/greg0ire/DoctrinePHPCRBundle.git","svn_url":"https://github.com/greg0ire/DoctrinePHPCRBundle","homepage":"http://phpcr.github.com","size":2571,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"doctrine:master","ref":"master","sha":"b4ac2eac9d7cd81be3ed5b8b0a746b0795d1c560","user":{"login":"doctrine","id":209254,"avatar_url":"https://avatars.githubusercontent.com/u/209254?v=2","gravatar_id":"ba1cea66dea9be22341d7d104d0f22b1","url":"https://api.github.com/users/doctrine","html_url":"https://github.com/doctrine","followers_url":"https://api.github.com/users/doctrine/followers","following_url":"https://api.github.com/users/doctrine/following{/other_user}","gists_url":"https://api.github.com/users/doctrine/gists{/gist_id}","starred_url":"https://api.github.com/users/doctrine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doctrine/subscriptions","organizations_url":"https://api.github.com/users/doctrine/orgs","repos_url":"https://api.github.com/users/doctrine/repos","events_url":"https://api.github.com/users/doctrine/events{/privacy}","received_events_url":"https://api.github.com/users/doctrine/received_events","type":"Organization","site_admin":false},"repo":{"id":2855393,"name":"DoctrinePHPCRBundle","full_name":"doctrine/DoctrinePHPCRBundle","owner":{"login":"doctrine","id":209254,"avatar_url":"https://avatars.githubusercontent.com/u/209254?v=2","gravatar_id":"ba1cea66dea9be22341d7d104d0f22b1","url":"https://api.github.com/users/doctrine","html_url":"https://github.com/doctrine","followers_url":"https://api.github.com/users/doctrine/followers","following_url":"https://api.github.com/users/doctrine/following{/other_user}","gists_url":"https://api.github.com/users/doctrine/gists{/gist_id}","starred_url":"https://api.github.com/users/doctrine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doctrine/subscriptions","organizations_url":"https://api.github.com/users/doctrine/orgs","repos_url":"https://api.github.com/users/doctrine/repos","events_url":"https://api.github.com/users/doctrine/events{/privacy}","received_events_url":"https://api.github.com/users/doctrine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/doctrine/DoctrinePHPCRBundle","description":"This bundle integrates Doctrine PHPCR ODM and PHPCR backends into Symfony2","fork":false,"url":"https://api.github.com/repos/doctrine/DoctrinePHPCRBundle","forks_url":"https://api.github.com/repos/doctrine/DoctrinePHPCRBundle/forks","keys_url":"https://api.github.com/repos/doctrine/DoctrinePHPCRBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/doctrine/DoctrinePHPCRBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/doctrine/DoctrinePHPCRBundle/teams","hooks_url":"https://api.github.com/repos/doctrine/DoctrinePHPCRBundle/hooks","issue_events_url":"https://api.github.com/repos/doctrine/DoctrinePHPCRBundle/issues/events{/number}","events_url":"https://api.github.com/repos/doctrine/DoctrinePHPCRBundle/events","assignees_url":"https://api.github.com/repos/doctrine/DoctrinePHPCRBundle/assignees{/user}","branches_url":"https://api.github.com/repos/doctrine/DoctrinePHPCRBundle/branches{/branch}","tags_url":"https://api.github.com/repos/doctrine/DoctrinePHPCRBundle/tags","blobs_url":"https://api.github.com/repos/doctrine/DoctrinePHPCRBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/doctrine/DoctrinePHPCRBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/doctrine/DoctrinePHPCRBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/doctrine/DoctrinePHPCRBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/doctrine/DoctrinePHPCRBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/doctrine/DoctrinePHPCRBundle/languages","stargazers_url":"https://api.github.com/repos/doctrine/DoctrinePHPCRBundle/stargazers","contributors_url":"https://api.github.com/repos/doctrine/DoctrinePHPCRBundle/contributors","subscribers_url":"https://api.github.com/repos/doctrine/DoctrinePHPCRBundle/subscribers","subscription_url":"https://api.github.com/repos/doctrine/DoctrinePHPCRBundle/subscription","commits_url":"https://api.github.com/repos/doctrine/DoctrinePHPCRBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/doctrine/DoctrinePHPCRBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/doctrine/DoctrinePHPCRBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/doctrine/DoctrinePHPCRBundle/issues/comments/{number}","contents_url":"https://api.github.com/repos/doctrine/DoctrinePHPCRBundle/contents/{+path}","compare_url":"https://api.github.com/repos/doctrine/DoctrinePHPCRBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/doctrine/DoctrinePHPCRBundle/merges","archive_url":"https://api.github.com/repos/doctrine/DoctrinePHPCRBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/doctrine/DoctrinePHPCRBundle/downloads","issues_url":"https://api.github.com/repos/doctrine/DoctrinePHPCRBundle/issues{/number}","pulls_url":"https://api.github.com/repos/doctrine/DoctrinePHPCRBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/doctrine/DoctrinePHPCRBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/doctrine/DoctrinePHPCRBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/doctrine/DoctrinePHPCRBundle/labels{/name}","releases_url":"https://api.github.com/repos/doctrine/DoctrinePHPCRBundle/releases{/id}","created_at":"2011-11-26T12:15:24Z","updated_at":"2014-09-10T13:06:10Z","pushed_at":"2014-09-10T20:53:55Z","git_url":"git://github.com/doctrine/DoctrinePHPCRBundle.git","ssh_url":"git@github.com:doctrine/DoctrinePHPCRBundle.git","clone_url":"https://github.com/doctrine/DoctrinePHPCRBundle.git","svn_url":"https://github.com/doctrine/DoctrinePHPCRBundle","homepage":"http://phpcr.github.com","size":2571,"stargazers_count":41,"watchers_count":41,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":38,"mirror_url":null,"open_issues_count":13,"forks":38,"open_issues":13,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/doctrine/DoctrinePHPCRBundle/pulls/166"},"html":{"href":"https://github.com/doctrine/DoctrinePHPCRBundle/pull/166"},"issue":{"href":"https://api.github.com/repos/doctrine/DoctrinePHPCRBundle/issues/166"},"comments":{"href":"https://api.github.com/repos/doctrine/DoctrinePHPCRBundle/issues/166/comments"},"review_comments":{"href":"https://api.github.com/repos/doctrine/DoctrinePHPCRBundle/pulls/166/comments"},"review_comment":{"href":"https://api.github.com/repos/doctrine/DoctrinePHPCRBundle/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/doctrine/DoctrinePHPCRBundle/pulls/166/commits"},"statuses":{"href":"https://api.github.com/repos/doctrine/DoctrinePHPCRBundle/statuses/66e247e7f52f28863bfbd34a6dea080c69920704"}}}}