GitHub PullRequestReviewCommentEvent at 2014-08-19 07:38:54
Repository: jardiff
Actor: JakeWharton
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/JakeWharton/jardiff/pulls/comments/16400647","id":16400647,"diff_hunk":"@@ -31,24 +31,27 @@ def _chunks(items, chunk_size):\n     yield items[i:i + chunk_size]\n \n \n-def _javap_public(files):\n+def _javap_public(unjar, files):\n   results = []\n   for chunk in _chunks(files, 200):\n-    results.append(str(subprocess.check_output(['javap', '-public'] + chunk)))\n-  return '\\n'.join(results)\n+    for i in range(len(chunk)):\n+      chunk[i] = os.path.relpath(chunk[i], unjar).replace(\".class\", \"\")\n+\n+    results.append(str(subprocess.check_output(['javap', '-classpath', unjar, '-public'] + chunk)))\n+  return os.linesep.join(results)","path":"jardiff.py","position":14,"original_position":14,"commit_id":"eb5a8bae136b4a4e8d2eec7e1a7e97005d09813f","original_commit_id":"eb5a8bae136b4a4e8d2eec7e1a7e97005d09813f","user":{"login":"JakeWharton","id":66577,"avatar_url":"https://avatars.githubusercontent.com/u/66577?v=2","gravatar_id":"e68309f117985270285ade8082f4877d","url":"https://api.github.com/users/JakeWharton","html_url":"https://github.com/JakeWharton","followers_url":"https://api.github.com/users/JakeWharton/followers","following_url":"https://api.github.com/users/JakeWharton/following{/other_user}","gists_url":"https://api.github.com/users/JakeWharton/gists{/gist_id}","starred_url":"https://api.github.com/users/JakeWharton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JakeWharton/subscriptions","organizations_url":"https://api.github.com/users/JakeWharton/orgs","repos_url":"https://api.github.com/users/JakeWharton/repos","events_url":"https://api.github.com/users/JakeWharton/events{/privacy}","received_events_url":"https://api.github.com/users/JakeWharton/received_events","type":"User","site_admin":false},"body":"I meant the `os.linesep` change. There's nothing that follows this function which wouldn't always work with `\\n`.","created_at":"2014-08-19T07:38:54Z","updated_at":"2014-08-19T07:38:54Z","html_url":"https://github.com/JakeWharton/jardiff/pull/6#discussion_r16400647","pull_request_url":"https://api.github.com/repos/JakeWharton/jardiff/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/JakeWharton/jardiff/pulls/comments/16400647"},"html":{"href":"https://github.com/JakeWharton/jardiff/pull/6#discussion_r16400647"},"pull_request":{"href":"https://api.github.com/repos/JakeWharton/jardiff/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/JakeWharton/jardiff/pulls/6","id":19951012,"html_url":"https://github.com/JakeWharton/jardiff/pull/6","diff_url":"https://github.com/JakeWharton/jardiff/pull/6.diff","patch_url":"https://github.com/JakeWharton/jardiff/pull/6.patch","issue_url":"https://api.github.com/repos/JakeWharton/jardiff/issues/6","number":6,"state":"open","locked":false,"title":"Make the jardiff.py fully cross-platform","user":{"login":"HoracioFilho","id":6182310,"avatar_url":"https://avatars.githubusercontent.com/u/6182310?v=2","gravatar_id":"d3d5c6cdfbb14a370614cd87f4bb85e3","url":"https://api.github.com/users/HoracioFilho","html_url":"https://github.com/HoracioFilho","followers_url":"https://api.github.com/users/HoracioFilho/followers","following_url":"https://api.github.com/users/HoracioFilho/following{/other_user}","gists_url":"https://api.github.com/users/HoracioFilho/gists{/gist_id}","starred_url":"https://api.github.com/users/HoracioFilho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HoracioFilho/subscriptions","organizations_url":"https://api.github.com/users/HoracioFilho/orgs","repos_url":"https://api.github.com/users/HoracioFilho/repos","events_url":"https://api.github.com/users/HoracioFilho/events{/privacy}","received_events_url":"https://api.github.com/users/HoracioFilho/received_events","type":"User","site_admin":false},"body":"Make the jardiff.py fully cross-platform. Thanks a lot for help me, the script is working on Windows as well as on UNIX platforms :smile:.\r\n\r\nI do not know how to program in Python, i'm a .Net guy, some things can get better :smile: in code\r\n\r\nIn Windows requires Cygwin. After I send another pull request with information about its installation and required package.\r\n\r\nThanks a lot.","created_at":"2014-08-18T23:06:09Z","updated_at":"2014-08-19T07:38:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"67f2162b136652b6ae3781788149b91a27b7e972","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/JakeWharton/jardiff/pulls/6/commits","review_comments_url":"https://api.github.com/repos/JakeWharton/jardiff/pulls/6/comments","review_comment_url":"https://api.github.com/repos/JakeWharton/jardiff/pulls/comments/{number}","comments_url":"https://api.github.com/repos/JakeWharton/jardiff/issues/6/comments","statuses_url":"https://api.github.com/repos/JakeWharton/jardiff/statuses/eb5a8bae136b4a4e8d2eec7e1a7e97005d09813f","head":{"label":"HoracioFilho:master","ref":"master","sha":"eb5a8bae136b4a4e8d2eec7e1a7e97005d09813f","user":{"login":"HoracioFilho","id":6182310,"avatar_url":"https://avatars.githubusercontent.com/u/6182310?v=2","gravatar_id":"d3d5c6cdfbb14a370614cd87f4bb85e3","url":"https://api.github.com/users/HoracioFilho","html_url":"https://github.com/HoracioFilho","followers_url":"https://api.github.com/users/HoracioFilho/followers","following_url":"https://api.github.com/users/HoracioFilho/following{/other_user}","gists_url":"https://api.github.com/users/HoracioFilho/gists{/gist_id}","starred_url":"https://api.github.com/users/HoracioFilho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HoracioFilho/subscriptions","organizations_url":"https://api.github.com/users/HoracioFilho/orgs","repos_url":"https://api.github.com/users/HoracioFilho/repos","events_url":"https://api.github.com/users/HoracioFilho/events{/privacy}","received_events_url":"https://api.github.com/users/HoracioFilho/received_events","type":"User","site_admin":false},"repo":{"id":23089250,"name":"jardiff","full_name":"HoracioFilho/jardiff","owner":{"login":"HoracioFilho","id":6182310,"avatar_url":"https://avatars.githubusercontent.com/u/6182310?v=2","gravatar_id":"d3d5c6cdfbb14a370614cd87f4bb85e3","url":"https://api.github.com/users/HoracioFilho","html_url":"https://github.com/HoracioFilho","followers_url":"https://api.github.com/users/HoracioFilho/followers","following_url":"https://api.github.com/users/HoracioFilho/following{/other_user}","gists_url":"https://api.github.com/users/HoracioFilho/gists{/gist_id}","starred_url":"https://api.github.com/users/HoracioFilho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HoracioFilho/subscriptions","organizations_url":"https://api.github.com/users/HoracioFilho/orgs","repos_url":"https://api.github.com/users/HoracioFilho/repos","events_url":"https://api.github.com/users/HoracioFilho/events{/privacy}","received_events_url":"https://api.github.com/users/HoracioFilho/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/HoracioFilho/jardiff","description":"A Python script which quickly creates diffs of the public API between two JAR files","fork":true,"url":"https://api.github.com/repos/HoracioFilho/jardiff","forks_url":"https://api.github.com/repos/HoracioFilho/jardiff/forks","keys_url":"https://api.github.com/repos/HoracioFilho/jardiff/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HoracioFilho/jardiff/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HoracioFilho/jardiff/teams","hooks_url":"https://api.github.com/repos/HoracioFilho/jardiff/hooks","issue_events_url":"https://api.github.com/repos/HoracioFilho/jardiff/issues/events{/number}","events_url":"https://api.github.com/repos/HoracioFilho/jardiff/events","assignees_url":"https://api.github.com/repos/HoracioFilho/jardiff/assignees{/user}","branches_url":"https://api.github.com/repos/HoracioFilho/jardiff/branches{/branch}","tags_url":"https://api.github.com/repos/HoracioFilho/jardiff/tags","blobs_url":"https://api.github.com/repos/HoracioFilho/jardiff/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HoracioFilho/jardiff/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HoracioFilho/jardiff/git/refs{/sha}","trees_url":"https://api.github.com/repos/HoracioFilho/jardiff/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HoracioFilho/jardiff/statuses/{sha}","languages_url":"https://api.github.com/repos/HoracioFilho/jardiff/languages","stargazers_url":"https://api.github.com/repos/HoracioFilho/jardiff/stargazers","contributors_url":"https://api.github.com/repos/HoracioFilho/jardiff/contributors","subscribers_url":"https://api.github.com/repos/HoracioFilho/jardiff/subscribers","subscription_url":"https://api.github.com/repos/HoracioFilho/jardiff/subscription","commits_url":"https://api.github.com/repos/HoracioFilho/jardiff/commits{/sha}","git_commits_url":"https://api.github.com/repos/HoracioFilho/jardiff/git/commits{/sha}","comments_url":"https://api.github.com/repos/HoracioFilho/jardiff/comments{/number}","issue_comment_url":"https://api.github.com/repos/HoracioFilho/jardiff/issues/comments/{number}","contents_url":"https://api.github.com/repos/HoracioFilho/jardiff/contents/{+path}","compare_url":"https://api.github.com/repos/HoracioFilho/jardiff/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HoracioFilho/jardiff/merges","archive_url":"https://api.github.com/repos/HoracioFilho/jardiff/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HoracioFilho/jardiff/downloads","issues_url":"https://api.github.com/repos/HoracioFilho/jardiff/issues{/number}","pulls_url":"https://api.github.com/repos/HoracioFilho/jardiff/pulls{/number}","milestones_url":"https://api.github.com/repos/HoracioFilho/jardiff/milestones{/number}","notifications_url":"https://api.github.com/repos/HoracioFilho/jardiff/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HoracioFilho/jardiff/labels{/name}","releases_url":"https://api.github.com/repos/HoracioFilho/jardiff/releases{/id}","created_at":"2014-08-18T22:56:02Z","updated_at":"2014-08-18T22:58:00Z","pushed_at":"2014-08-18T23:42:01Z","git_url":"git://github.com/HoracioFilho/jardiff.git","ssh_url":"git@github.com:HoracioFilho/jardiff.git","clone_url":"https://github.com/HoracioFilho/jardiff.git","svn_url":"https://github.com/HoracioFilho/jardiff","homepage":null,"size":159,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JakeWharton:master","ref":"master","sha":"165222ab500f7c6a0e714fa3e8f57d7bdd175d31","user":{"login":"JakeWharton","id":66577,"avatar_url":"https://avatars.githubusercontent.com/u/66577?v=2","gravatar_id":"e68309f117985270285ade8082f4877d","url":"https://api.github.com/users/JakeWharton","html_url":"https://github.com/JakeWharton","followers_url":"https://api.github.com/users/JakeWharton/followers","following_url":"https://api.github.com/users/JakeWharton/following{/other_user}","gists_url":"https://api.github.com/users/JakeWharton/gists{/gist_id}","starred_url":"https://api.github.com/users/JakeWharton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JakeWharton/subscriptions","organizations_url":"https://api.github.com/users/JakeWharton/orgs","repos_url":"https://api.github.com/users/JakeWharton/repos","events_url":"https://api.github.com/users/JakeWharton/events{/privacy}","received_events_url":"https://api.github.com/users/JakeWharton/received_events","type":"User","site_admin":false},"repo":{"id":21589706,"name":"jardiff","full_name":"JakeWharton/jardiff","owner":{"login":"JakeWharton","id":66577,"avatar_url":"https://avatars.githubusercontent.com/u/66577?v=2","gravatar_id":"e68309f117985270285ade8082f4877d","url":"https://api.github.com/users/JakeWharton","html_url":"https://github.com/JakeWharton","followers_url":"https://api.github.com/users/JakeWharton/followers","following_url":"https://api.github.com/users/JakeWharton/following{/other_user}","gists_url":"https://api.github.com/users/JakeWharton/gists{/gist_id}","starred_url":"https://api.github.com/users/JakeWharton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JakeWharton/subscriptions","organizations_url":"https://api.github.com/users/JakeWharton/orgs","repos_url":"https://api.github.com/users/JakeWharton/repos","events_url":"https://api.github.com/users/JakeWharton/events{/privacy}","received_events_url":"https://api.github.com/users/JakeWharton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JakeWharton/jardiff","description":"A Python script which quickly creates diffs of the public API between two JAR files","fork":false,"url":"https://api.github.com/repos/JakeWharton/jardiff","forks_url":"https://api.github.com/repos/JakeWharton/jardiff/forks","keys_url":"https://api.github.com/repos/JakeWharton/jardiff/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JakeWharton/jardiff/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JakeWharton/jardiff/teams","hooks_url":"https://api.github.com/repos/JakeWharton/jardiff/hooks","issue_events_url":"https://api.github.com/repos/JakeWharton/jardiff/issues/events{/number}","events_url":"https://api.github.com/repos/JakeWharton/jardiff/events","assignees_url":"https://api.github.com/repos/JakeWharton/jardiff/assignees{/user}","branches_url":"https://api.github.com/repos/JakeWharton/jardiff/branches{/branch}","tags_url":"https://api.github.com/repos/JakeWharton/jardiff/tags","blobs_url":"https://api.github.com/repos/JakeWharton/jardiff/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JakeWharton/jardiff/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JakeWharton/jardiff/git/refs{/sha}","trees_url":"https://api.github.com/repos/JakeWharton/jardiff/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JakeWharton/jardiff/statuses/{sha}","languages_url":"https://api.github.com/repos/JakeWharton/jardiff/languages","stargazers_url":"https://api.github.com/repos/JakeWharton/jardiff/stargazers","contributors_url":"https://api.github.com/repos/JakeWharton/jardiff/contributors","subscribers_url":"https://api.github.com/repos/JakeWharton/jardiff/subscribers","subscription_url":"https://api.github.com/repos/JakeWharton/jardiff/subscription","commits_url":"https://api.github.com/repos/JakeWharton/jardiff/commits{/sha}","git_commits_url":"https://api.github.com/repos/JakeWharton/jardiff/git/commits{/sha}","comments_url":"https://api.github.com/repos/JakeWharton/jardiff/comments{/number}","issue_comment_url":"https://api.github.com/repos/JakeWharton/jardiff/issues/comments/{number}","contents_url":"https://api.github.com/repos/JakeWharton/jardiff/contents/{+path}","compare_url":"https://api.github.com/repos/JakeWharton/jardiff/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JakeWharton/jardiff/merges","archive_url":"https://api.github.com/repos/JakeWharton/jardiff/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JakeWharton/jardiff/downloads","issues_url":"https://api.github.com/repos/JakeWharton/jardiff/issues{/number}","pulls_url":"https://api.github.com/repos/JakeWharton/jardiff/pulls{/number}","milestones_url":"https://api.github.com/repos/JakeWharton/jardiff/milestones{/number}","notifications_url":"https://api.github.com/repos/JakeWharton/jardiff/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JakeWharton/jardiff/labels{/name}","releases_url":"https://api.github.com/repos/JakeWharton/jardiff/releases{/id}","created_at":"2014-07-07T23:00:14Z","updated_at":"2014-08-17T02:31:01Z","pushed_at":"2014-07-22T00:36:02Z","git_url":"git://github.com/JakeWharton/jardiff.git","ssh_url":"git@github.com:JakeWharton/jardiff.git","clone_url":"https://github.com/JakeWharton/jardiff.git","svn_url":"https://github.com/JakeWharton/jardiff","homepage":null,"size":159,"stargazers_count":85,"watchers_count":85,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":4,"mirror_url":null,"open_issues_count":4,"forks":4,"open_issues":4,"watchers":85,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JakeWharton/jardiff/pulls/6"},"html":{"href":"https://github.com/JakeWharton/jardiff/pull/6"},"issue":{"href":"https://api.github.com/repos/JakeWharton/jardiff/issues/6"},"comments":{"href":"https://api.github.com/repos/JakeWharton/jardiff/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/JakeWharton/jardiff/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/JakeWharton/jardiff/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/JakeWharton/jardiff/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/JakeWharton/jardiff/statuses/eb5a8bae136b4a4e8d2eec7e1a7e97005d09813f"}}}}