GitHub PullRequestReviewCommentEvent at 2014-04-29 01:26:00
Repository: Octopus-Tools
Actor: PaulStovell
Payload: {"comment":{"url":"https://api.github.com/repos/OctopusDeploy/Octopus-Tools/pulls/comments/12076357","id":12076357,"diff_hunk":"@@ -0,0 +1,44 @@\n+﻿using log4net;\n+using Octopus.Platform.Util;\n+using OctopusTools.Infrastructure;\n+using System;\n+using System.Collections.Generic;\n+using System.IO;\n+using System.Linq;\n+using System.Text;\n+\n+namespace OctopusTools.Commands\n+{\n+    public abstract class BaseImportCommand : ApiCommand\n+    {\n+        readonly IOctopusFileSystem fileSystem;\n+\n+        public BaseImportCommand(IOctopusFileSystem fileSystem, IOctopusRepositoryFactory repositoryFactory, ILog log)\n+            : base(repositoryFactory, log)\n+        {\n+            this.fileSystem = fileSystem;\n+        }\n+\n+        public string GetSerializedObjectFromFile(string filePath)\n+        {\n+            Log.Debug(\"Loading export file\");\n+            if (!fileSystem.FileExists(filePath))\n+                throw new CommandException(\"Unable to find the specified export file\");\n+\n+            var export = string.Empty;","path":"source/OctopusTools/Commands/BaseImportCommand.cs","position":28,"original_position":28,"commit_id":"2e496d04dc9ff97b08b0feb195453110a9e96de6","original_commit_id":"2e496d04dc9ff97b08b0feb195453110a9e96de6","user":{"login":"PaulStovell","id":47085,"avatar_url":"https://avatars.githubusercontent.com/u/47085?","gravatar_id":"2094bc37f443e885894612df3464afe8","url":"https://api.github.com/users/PaulStovell","html_url":"https://github.com/PaulStovell","followers_url":"https://api.github.com/users/PaulStovell/followers","following_url":"https://api.github.com/users/PaulStovell/following{/other_user}","gists_url":"https://api.github.com/users/PaulStovell/gists{/gist_id}","starred_url":"https://api.github.com/users/PaulStovell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaulStovell/subscriptions","organizations_url":"https://api.github.com/users/PaulStovell/orgs","repos_url":"https://api.github.com/users/PaulStovell/repos","events_url":"https://api.github.com/users/PaulStovell/events{/privacy}","received_events_url":"https://api.github.com/users/PaulStovell/received_events","type":"User","site_admin":false},"body":"R# suggests that this can be \r\n\r\n   string export;\r\n\r\nSince the value is overwritten later anyway. I know you aren't using R#, but does CodeRush have a similar warning?","created_at":"2014-04-29T01:26:00Z","updated_at":"2014-04-29T01:26:00Z","html_url":"https://github.com/OctopusDeploy/Octopus-Tools/pull/42#discussion_r12076357","pull_request_url":"https://api.github.com/repos/OctopusDeploy/Octopus-Tools/pulls/42","_links":{"self":{"href":"https://api.github.com/repos/OctopusDeploy/Octopus-Tools/pulls/comments/12076357"},"html":{"href":"https://github.com/OctopusDeploy/Octopus-Tools/pull/42#discussion_r12076357"},"pull_request":{"href":"https://api.github.com/repos/OctopusDeploy/Octopus-Tools/pulls/42"}}}}