GitHub PullRequestReviewCommentEvent at 2014-06-10 21:35:42
Repository: underscore
Actor: megawac
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/jashkenas/underscore/pulls/comments/13621139","id":13621139,"diff_hunk":"@@ -961,16 +961,16 @@\n     var className = toString.call(a);\n     if (className !== toString.call(b)) return false;\n     switch (className) {\n-      // RegExps are coerced to strings for comparison.\n+      // Strings, numbers, regular expressions, dates, and booleans are compared by value.\n       case '[object RegExp]':\n-      // Strings, numbers, dates, and booleans are compared by value.\n+      // RegExps are coerced to strings for comparison (Note: '' + /a/i === '/a/i')\n       case '[object String]':\n         // Primitives and their corresponding object wrappers are equivalent; thus, `\"5\"` is\n-        // equivalent to `String(\"5\")`.\n+        // equivalent to `new String(\"5\")`.","path":"underscore.js","position":12,"original_position":12,"commit_id":"980708e15560152464a85509fe7e5c631ee92c54","original_commit_id":"3698c17caad276620843af7ce6620ad3dcbb55ca","user":{"login":"megawac","id":3475472,"avatar_url":"https://avatars.githubusercontent.com/u/3475472?","gravatar_id":"940d0af29bc817075f3eb6aacf40254f","url":"https://api.github.com/users/megawac","html_url":"https://github.com/megawac","followers_url":"https://api.github.com/users/megawac/followers","following_url":"https://api.github.com/users/megawac/following{/other_user}","gists_url":"https://api.github.com/users/megawac/gists{/gist_id}","starred_url":"https://api.github.com/users/megawac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/megawac/subscriptions","organizations_url":"https://api.github.com/users/megawac/orgs","repos_url":"https://api.github.com/users/megawac/repos","events_url":"https://api.github.com/users/megawac/events{/privacy}","received_events_url":"https://api.github.com/users/megawac/received_events","type":"User","site_admin":false},"body":"Yes, thats what that case is checking, but the comment is saying `new String(\"5\")` is equivalent to `\"5\"`. `\"5\"` is equal to `String(\"5\")` so theres no reason to even comment that. In the reffed commit the meaning changed","created_at":"2014-06-10T21:35:42Z","updated_at":"2014-06-10T21:35:42Z","html_url":"https://github.com/jashkenas/underscore/pull/1673#discussion_r13621139","pull_request_url":"https://api.github.com/repos/jashkenas/underscore/pulls/1673","_links":{"self":{"href":"https://api.github.com/repos/jashkenas/underscore/pulls/comments/13621139"},"html":{"href":"https://github.com/jashkenas/underscore/pull/1673#discussion_r13621139"},"pull_request":{"href":"https://api.github.com/repos/jashkenas/underscore/pulls/1673"}}},"pull_request":{"url":"https://api.github.com/repos/jashkenas/underscore/pulls/1673","id":16963177,"html_url":"https://github.com/jashkenas/underscore/pull/1673","diff_url":"https://github.com/jashkenas/underscore/pull/1673.diff","patch_url":"https://github.com/jashkenas/underscore/pull/1673.patch","issue_url":"https://api.github.com/repos/jashkenas/underscore/issues/1673","number":1673,"state":"open","title":"Add comments and sparse array test for _.isEqual","user":{"login":"megawac","id":3475472,"avatar_url":"https://avatars.githubusercontent.com/u/3475472?","gravatar_id":"940d0af29bc817075f3eb6aacf40254f","url":"https://api.github.com/users/megawac","html_url":"https://github.com/megawac","followers_url":"https://api.github.com/users/megawac/followers","following_url":"https://api.github.com/users/megawac/following{/other_user}","gists_url":"https://api.github.com/users/megawac/gists{/gist_id}","starred_url":"https://api.github.com/users/megawac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/megawac/subscriptions","organizations_url":"https://api.github.com/users/megawac/orgs","repos_url":"https://api.github.com/users/megawac/repos","events_url":"https://api.github.com/users/megawac/events{/privacy}","received_events_url":"https://api.github.com/users/megawac/received_events","type":"User","site_admin":false},"body":"Add some comments for some confusing `_.isEqual` lines and spec sparse array handling (this handling is consistent with `v1.5-v1.6`)","created_at":"2014-06-10T20:23:41Z","updated_at":"2014-06-10T21:35:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4db74dc77568154c975198b6c6be0c50557ac113","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jashkenas/underscore/pulls/1673/commits","review_comments_url":"https://api.github.com/repos/jashkenas/underscore/pulls/1673/comments","review_comment_url":"https://api.github.com/repos/jashkenas/underscore/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jashkenas/underscore/issues/1673/comments","statuses_url":"https://api.github.com/repos/jashkenas/underscore/statuses/980708e15560152464a85509fe7e5c631ee92c54","head":{"label":"megawac:equal-comments","ref":"equal-comments","sha":"980708e15560152464a85509fe7e5c631ee92c54","user":{"login":"megawac","id":3475472,"avatar_url":"https://avatars.githubusercontent.com/u/3475472?","gravatar_id":"940d0af29bc817075f3eb6aacf40254f","url":"https://api.github.com/users/megawac","html_url":"https://github.com/megawac","followers_url":"https://api.github.com/users/megawac/followers","following_url":"https://api.github.com/users/megawac/following{/other_user}","gists_url":"https://api.github.com/users/megawac/gists{/gist_id}","starred_url":"https://api.github.com/users/megawac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/megawac/subscriptions","organizations_url":"https://api.github.com/users/megawac/orgs","repos_url":"https://api.github.com/users/megawac/repos","events_url":"https://api.github.com/users/megawac/events{/privacy}","received_events_url":"https://api.github.com/users/megawac/received_events","type":"User","site_admin":false},"repo":{"id":16108833,"name":"underscore","full_name":"megawac/underscore","owner":{"login":"megawac","id":3475472,"avatar_url":"https://avatars.githubusercontent.com/u/3475472?","gravatar_id":"940d0af29bc817075f3eb6aacf40254f","url":"https://api.github.com/users/megawac","html_url":"https://github.com/megawac","followers_url":"https://api.github.com/users/megawac/followers","following_url":"https://api.github.com/users/megawac/following{/other_user}","gists_url":"https://api.github.com/users/megawac/gists{/gist_id}","starred_url":"https://api.github.com/users/megawac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/megawac/subscriptions","organizations_url":"https://api.github.com/users/megawac/orgs","repos_url":"https://api.github.com/users/megawac/repos","events_url":"https://api.github.com/users/megawac/events{/privacy}","received_events_url":"https://api.github.com/users/megawac/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/megawac/underscore","description":"JavaScript's utility _ belt","fork":true,"url":"https://api.github.com/repos/megawac/underscore","forks_url":"https://api.github.com/repos/megawac/underscore/forks","keys_url":"https://api.github.com/repos/megawac/underscore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/megawac/underscore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/megawac/underscore/teams","hooks_url":"https://api.github.com/repos/megawac/underscore/hooks","issue_events_url":"https://api.github.com/repos/megawac/underscore/issues/events{/number}","events_url":"https://api.github.com/repos/megawac/underscore/events","assignees_url":"https://api.github.com/repos/megawac/underscore/assignees{/user}","branches_url":"https://api.github.com/repos/megawac/underscore/branches{/branch}","tags_url":"https://api.github.com/repos/megawac/underscore/tags","blobs_url":"https://api.github.com/repos/megawac/underscore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/megawac/underscore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/megawac/underscore/git/refs{/sha}","trees_url":"https://api.github.com/repos/megawac/underscore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/megawac/underscore/statuses/{sha}","languages_url":"https://api.github.com/repos/megawac/underscore/languages","stargazers_url":"https://api.github.com/repos/megawac/underscore/stargazers","contributors_url":"https://api.github.com/repos/megawac/underscore/contributors","subscribers_url":"https://api.github.com/repos/megawac/underscore/subscribers","subscription_url":"https://api.github.com/repos/megawac/underscore/subscription","commits_url":"https://api.github.com/repos/megawac/underscore/commits{/sha}","git_commits_url":"https://api.github.com/repos/megawac/underscore/git/commits{/sha}","comments_url":"https://api.github.com/repos/megawac/underscore/comments{/number}","issue_comment_url":"https://api.github.com/repos/megawac/underscore/issues/comments/{number}","contents_url":"https://api.github.com/repos/megawac/underscore/contents/{+path}","compare_url":"https://api.github.com/repos/megawac/underscore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/megawac/underscore/merges","archive_url":"https://api.github.com/repos/megawac/underscore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/megawac/underscore/downloads","issues_url":"https://api.github.com/repos/megawac/underscore/issues{/number}","pulls_url":"https://api.github.com/repos/megawac/underscore/pulls{/number}","milestones_url":"https://api.github.com/repos/megawac/underscore/milestones{/number}","notifications_url":"https://api.github.com/repos/megawac/underscore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/megawac/underscore/labels{/name}","releases_url":"https://api.github.com/repos/megawac/underscore/releases{/id}","created_at":"2014-01-21T16:32:31Z","updated_at":"2014-06-10T20:58:08Z","pushed_at":"2014-06-10T20:58:07Z","git_url":"git://github.com/megawac/underscore.git","ssh_url":"git@github.com:megawac/underscore.git","clone_url":"https://github.com/megawac/underscore.git","svn_url":"https://github.com/megawac/underscore","homepage":"http://underscorejs.org","size":3935,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jashkenas:master","ref":"master","sha":"812334d37f5fd0fbb57aed3a5c6ca4e93cdbbfa9","user":{"login":"jashkenas","id":4732,"avatar_url":"https://avatars.githubusercontent.com/u/4732?","gravatar_id":"32652ed5b8fbd2ecdb1c78e9ac567b4b","url":"https://api.github.com/users/jashkenas","html_url":"https://github.com/jashkenas","followers_url":"https://api.github.com/users/jashkenas/followers","following_url":"https://api.github.com/users/jashkenas/following{/other_user}","gists_url":"https://api.github.com/users/jashkenas/gists{/gist_id}","starred_url":"https://api.github.com/users/jashkenas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jashkenas/subscriptions","organizations_url":"https://api.github.com/users/jashkenas/orgs","repos_url":"https://api.github.com/users/jashkenas/repos","events_url":"https://api.github.com/users/jashkenas/events{/privacy}","received_events_url":"https://api.github.com/users/jashkenas/received_events","type":"User","site_admin":false},"repo":{"id":349241,"name":"underscore","full_name":"jashkenas/underscore","owner":{"login":"jashkenas","id":4732,"avatar_url":"https://avatars.githubusercontent.com/u/4732?","gravatar_id":"32652ed5b8fbd2ecdb1c78e9ac567b4b","url":"https://api.github.com/users/jashkenas","html_url":"https://github.com/jashkenas","followers_url":"https://api.github.com/users/jashkenas/followers","following_url":"https://api.github.com/users/jashkenas/following{/other_user}","gists_url":"https://api.github.com/users/jashkenas/gists{/gist_id}","starred_url":"https://api.github.com/users/jashkenas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jashkenas/subscriptions","organizations_url":"https://api.github.com/users/jashkenas/orgs","repos_url":"https://api.github.com/users/jashkenas/repos","events_url":"https://api.github.com/users/jashkenas/events{/privacy}","received_events_url":"https://api.github.com/users/jashkenas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jashkenas/underscore","description":"JavaScript's utility _ belt","fork":false,"url":"https://api.github.com/repos/jashkenas/underscore","forks_url":"https://api.github.com/repos/jashkenas/underscore/forks","keys_url":"https://api.github.com/repos/jashkenas/underscore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jashkenas/underscore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jashkenas/underscore/teams","hooks_url":"https://api.github.com/repos/jashkenas/underscore/hooks","issue_events_url":"https://api.github.com/repos/jashkenas/underscore/issues/events{/number}","events_url":"https://api.github.com/repos/jashkenas/underscore/events","assignees_url":"https://api.github.com/repos/jashkenas/underscore/assignees{/user}","branches_url":"https://api.github.com/repos/jashkenas/underscore/branches{/branch}","tags_url":"https://api.github.com/repos/jashkenas/underscore/tags","blobs_url":"https://api.github.com/repos/jashkenas/underscore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jashkenas/underscore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jashkenas/underscore/git/refs{/sha}","trees_url":"https://api.github.com/repos/jashkenas/underscore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jashkenas/underscore/statuses/{sha}","languages_url":"https://api.github.com/repos/jashkenas/underscore/languages","stargazers_url":"https://api.github.com/repos/jashkenas/underscore/stargazers","contributors_url":"https://api.github.com/repos/jashkenas/underscore/contributors","subscribers_url":"https://api.github.com/repos/jashkenas/underscore/subscribers","subscription_url":"https://api.github.com/repos/jashkenas/underscore/subscription","commits_url":"https://api.github.com/repos/jashkenas/underscore/commits{/sha}","git_commits_url":"https://api.github.com/repos/jashkenas/underscore/git/commits{/sha}","comments_url":"https://api.github.com/repos/jashkenas/underscore/comments{/number}","issue_comment_url":"https://api.github.com/repos/jashkenas/underscore/issues/comments/{number}","contents_url":"https://api.github.com/repos/jashkenas/underscore/contents/{+path}","compare_url":"https://api.github.com/repos/jashkenas/underscore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jashkenas/underscore/merges","archive_url":"https://api.github.com/repos/jashkenas/underscore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jashkenas/underscore/downloads","issues_url":"https://api.github.com/repos/jashkenas/underscore/issues{/number}","pulls_url":"https://api.github.com/repos/jashkenas/underscore/pulls{/number}","milestones_url":"https://api.github.com/repos/jashkenas/underscore/milestones{/number}","notifications_url":"https://api.github.com/repos/jashkenas/underscore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jashkenas/underscore/labels{/name}","releases_url":"https://api.github.com/repos/jashkenas/underscore/releases{/id}","created_at":"2009-10-25T18:31:06Z","updated_at":"2014-06-10T21:23:26Z","pushed_at":"2014-06-10T21:23:25Z","git_url":"git://github.com/jashkenas/underscore.git","ssh_url":"git@github.com:jashkenas/underscore.git","clone_url":"https://github.com/jashkenas/underscore.git","svn_url":"https://github.com/jashkenas/underscore","homepage":"http://underscorejs.org","size":15009,"stargazers_count":11529,"watchers_count":11529,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":2466,"mirror_url":null,"open_issues_count":43,"forks":2466,"open_issues":43,"watchers":11529,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jashkenas/underscore/pulls/1673"},"html":{"href":"https://github.com/jashkenas/underscore/pull/1673"},"issue":{"href":"https://api.github.com/repos/jashkenas/underscore/issues/1673"},"comments":{"href":"https://api.github.com/repos/jashkenas/underscore/issues/1673/comments"},"review_comments":{"href":"https://api.github.com/repos/jashkenas/underscore/pulls/1673/comments"},"review_comment":{"href":"https://api.github.com/repos/jashkenas/underscore/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jashkenas/underscore/pulls/1673/commits"},"statuses":{"href":"https://api.github.com/repos/jashkenas/underscore/statuses/980708e15560152464a85509fe7e5c631ee92c54"}}}}