GitHub PullRequestEvent at 2014-02-13 03:27:06
Repository: federationregistry
Actor: vladimir-mencl-eresearch
Payload: {"action":"opened","number":156,"pull_request":{"url":"https://api.github.com/repos/ausaccessfed/federationregistry/pulls/156","id":12494900,"html_url":"https://github.com/ausaccessfed/federationregistry/pull/156","diff_url":"https://github.com/ausaccessfed/federationregistry/pull/156.diff","patch_url":"https://github.com/ausaccessfed/federationregistry/pull/156.patch","issue_url":"https://api.github.com/repos/ausaccessfed/federationregistry/issues/156","number":156,"state":"open","title":"Fix several issues with tests:","user":{"login":"vladimir-mencl-eresearch","id":740558,"avatar_url":"https://gravatar.com/avatar/189eb2fc5b1d43cfc51a8582785bd39b?d=https%3A%2F%2Fidenticons.github.com%2F7603bf34455a9c22fede90006183e692.png&r=x","gravatar_id":"189eb2fc5b1d43cfc51a8582785bd39b","url":"https://api.github.com/users/vladimir-mencl-eresearch","html_url":"https://github.com/vladimir-mencl-eresearch","followers_url":"https://api.github.com/users/vladimir-mencl-eresearch/followers","following_url":"https://api.github.com/users/vladimir-mencl-eresearch/following{/other_user}","gists_url":"https://api.github.com/users/vladimir-mencl-eresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/vladimir-mencl-eresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vladimir-mencl-eresearch/subscriptions","organizations_url":"https://api.github.com/users/vladimir-mencl-eresearch/orgs","repos_url":"https://api.github.com/users/vladimir-mencl-eresearch/repos","events_url":"https://api.github.com/users/vladimir-mencl-eresearch/events{/privacy}","received_events_url":"https://api.github.com/users/vladimir-mencl-eresearch/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nThe fixes to plugin tests as discussed:\r\n\r\n(1) Tests: Copy missing resources.groovy among plugins\r\n\r\nCopy missing resources.groovy from base plugin into api, administation and reporting plugins.  Else, tests (grails test-app) fail for these plugins with ClassNotFoundException: resources\r\n\r\n(2) Tests: Metadata: fix output from similarExcludingID\r\n\r\nIn metadata tests, fix the output from similarExcludingID.  If this method call from a \"then\" clause of a Spock test returns false, the output from the test (the error reported) includes only the call to this\r\nmethod - result, method name, arguments.\r\n\r\nCalling this method with a simple Diff object means only the the first difference (which typically is the ID attribute ignored by this method) is printed and the actual XML difference found is hidden away.\r\n\r\nChange the code to instead convert the simple Diff to a DetailedDiff before calling similarExcludingID - that way, all differences captured in the DetailedDiff are printed and the test errors are much easier to\r\ntrack down.\r\n\r\n(3) Tests: metadata: fix validUntil timezone to UTC\r\n\r\nSome tests in the metadata plugin were using hard-coded timestamps but these timestamps were interpreted relative to the current timezone - and in other timezones then Australia/Brisbane caused the tests to fail as the value would not match the UTC-pinned value in expected output.\r\n\r\nExplicitly set the timezone to UTC in the tests and adjust test data accordingly.\r\n\r\n\r\nCheers,\r\nVlad\r\n","created_at":"2014-02-13T03:27:06Z","updated_at":"2014-02-13T03:27:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ausaccessfed/federationregistry/pulls/156/commits","review_comments_url":"https://api.github.com/repos/ausaccessfed/federationregistry/pulls/156/comments","review_comment_url":"https://api.github.com/repos/ausaccessfed/federationregistry/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ausaccessfed/federationregistry/issues/156/comments","statuses_url":"https://api.github.com/repos/ausaccessfed/federationregistry/statuses/1118b69d229e1e6079d2233fbceff9562d122bde","head":{"label":"University-of-Auckland:aaf-develop","ref":"aaf-develop","sha":"1118b69d229e1e6079d2233fbceff9562d122bde","user":{"login":"University-of-Auckland","id":824374,"avatar_url":"https://gravatar.com/avatar/2bd2a77afa51cda918c683fe703c3188?d=https%3A%2F%2Fidenticons.github.com%2F1184ea2f27a46e1e6a11bd40768b9495.png&r=x","gravatar_id":"2bd2a77afa51cda918c683fe703c3188","url":"https://api.github.com/users/University-of-Auckland","html_url":"https://github.com/University-of-Auckland","followers_url":"https://api.github.com/users/University-of-Auckland/followers","following_url":"https://api.github.com/users/University-of-Auckland/following{/other_user}","gists_url":"https://api.github.com/users/University-of-Auckland/gists{/gist_id}","starred_url":"https://api.github.com/users/University-of-Auckland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/University-of-Auckland/subscriptions","organizations_url":"https://api.github.com/users/University-of-Auckland/orgs","repos_url":"https://api.github.com/users/University-of-Auckland/repos","events_url":"https://api.github.com/users/University-of-Auckland/events{/privacy}","received_events_url":"https://api.github.com/users/University-of-Auckland/received_events","type":"Organization","site_admin":false},"repo":{"id":10093001,"name":"federationregistry2-Tuakiri","full_name":"University-of-Auckland/federationregistry2-Tuakiri","owner":{"login":"University-of-Auckland","id":824374,"avatar_url":"https://gravatar.com/avatar/2bd2a77afa51cda918c683fe703c3188?d=https%3A%2F%2Fidenticons.github.com%2F1184ea2f27a46e1e6a11bd40768b9495.png&r=x","gravatar_id":"2bd2a77afa51cda918c683fe703c3188","url":"https://api.github.com/users/University-of-Auckland","html_url":"https://github.com/University-of-Auckland","followers_url":"https://api.github.com/users/University-of-Auckland/followers","following_url":"https://api.github.com/users/University-of-Auckland/following{/other_user}","gists_url":"https://api.github.com/users/University-of-Auckland/gists{/gist_id}","starred_url":"https://api.github.com/users/University-of-Auckland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/University-of-Auckland/subscriptions","organizations_url":"https://api.github.com/users/University-of-Auckland/orgs","repos_url":"https://api.github.com/users/University-of-Auckland/repos","events_url":"https://api.github.com/users/University-of-Auckland/events{/privacy}","received_events_url":"https://api.github.com/users/University-of-Auckland/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/University-of-Auckland/federationregistry2-Tuakiri","description":"Federation Registry by the Australian Access Federation","fork":true,"url":"https://api.github.com/repos/University-of-Auckland/federationregistry2-Tuakiri","forks_url":"https://api.github.com/repos/University-of-Auckland/federationregistry2-Tuakiri/forks","keys_url":"https://api.github.com/repos/University-of-Auckland/federationregistry2-Tuakiri/keys{/key_id}","collaborators_url":"https://api.github.com/repos/University-of-Auckland/federationregistry2-Tuakiri/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/University-of-Auckland/federationregistry2-Tuakiri/teams","hooks_url":"https://api.github.com/repos/University-of-Auckland/federationregistry2-Tuakiri/hooks","issue_events_url":"https://api.github.com/repos/University-of-Auckland/federationregistry2-Tuakiri/issues/events{/number}","events_url":"https://api.github.com/repos/University-of-Auckland/federationregistry2-Tuakiri/events","assignees_url":"https://api.github.com/repos/University-of-Auckland/federationregistry2-Tuakiri/assignees{/user}","branches_url":"https://api.github.com/repos/University-of-Auckland/federationregistry2-Tuakiri/branches{/branch}","tags_url":"https://api.github.com/repos/University-of-Auckland/federationregistry2-Tuakiri/tags","blobs_url":"https://api.github.com/repos/University-of-Auckland/federationregistry2-Tuakiri/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/University-of-Auckland/federationregistry2-Tuakiri/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/University-of-Auckland/federationregistry2-Tuakiri/git/refs{/sha}","trees_url":"https://api.github.com/repos/University-of-Auckland/federationregistry2-Tuakiri/git/trees{/sha}","statuses_url":"https://api.github.com/repos/University-of-Auckland/federationregistry2-Tuakiri/statuses/{sha}","languages_url":"https://api.github.com/repos/University-of-Auckland/federationregistry2-Tuakiri/languages","stargazers_url":"https://api.github.com/repos/University-of-Auckland/federationregistry2-Tuakiri/stargazers","contributors_url":"https://api.github.com/repos/University-of-Auckland/federationregistry2-Tuakiri/contributors","subscribers_url":"https://api.github.com/repos/University-of-Auckland/federationregistry2-Tuakiri/subscribers","subscription_url":"https://api.github.com/repos/University-of-Auckland/federationregistry2-Tuakiri/subscription","commits_url":"https://api.github.com/repos/University-of-Auckland/federationregistry2-Tuakiri/commits{/sha}","git_commits_url":"https://api.github.com/repos/University-of-Auckland/federationregistry2-Tuakiri/git/commits{/sha}","comments_url":"https://api.github.com/repos/University-of-Auckland/federationregistry2-Tuakiri/comments{/number}","issue_comment_url":"https://api.github.com/repos/University-of-Auckland/federationregistry2-Tuakiri/issues/comments/{number}","contents_url":"https://api.github.com/repos/University-of-Auckland/federationregistry2-Tuakiri/contents/{+path}","compare_url":"https://api.github.com/repos/University-of-Auckland/federationregistry2-Tuakiri/compare/{base}...{head}","merges_url":"https://api.github.com/repos/University-of-Auckland/federationregistry2-Tuakiri/merges","archive_url":"https://api.github.com/repos/University-of-Auckland/federationregistry2-Tuakiri/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/University-of-Auckland/federationregistry2-Tuakiri/downloads","issues_url":"https://api.github.com/repos/University-of-Auckland/federationregistry2-Tuakiri/issues{/number}","pulls_url":"https://api.github.com/repos/University-of-Auckland/federationregistry2-Tuakiri/pulls{/number}","milestones_url":"https://api.github.com/repos/University-of-Auckland/federationregistry2-Tuakiri/milestones{/number}","notifications_url":"https://api.github.com/repos/University-of-Auckland/federationregistry2-Tuakiri/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/University-of-Auckland/federationregistry2-Tuakiri/labels{/name}","releases_url":"https://api.github.com/repos/University-of-Auckland/federationregistry2-Tuakiri/releases{/id}","created_at":"2013-05-16T03:30:14Z","updated_at":"2014-02-13T03:27:06Z","pushed_at":"2014-02-13T03:22:44Z","git_url":"git://github.com/University-of-Auckland/federationregistry2-Tuakiri.git","ssh_url":"git@github.com:University-of-Auckland/federationregistry2-Tuakiri.git","clone_url":"https://github.com/University-of-Auckland/federationregistry2-Tuakiri.git","svn_url":"https://github.com/University-of-Auckland/federationregistry2-Tuakiri","homepage":"http://www.aaf.edu.au","size":52657,"stargazers_count":2,"watchers_count":2,"language":"Groovy","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master","master_branch":"master"}},"base":{"label":"ausaccessfed:develop","ref":"develop","sha":"d1999bae3454563e7c1cfcb34c2c13dda13e8fdb","user":{"login":"ausaccessfed","id":149044,"avatar_url":"https://gravatar.com/avatar/ab8ab5baea76b73a7d1c8f48e481661d?d=https%3A%2F%2Fidenticons.github.com%2Fd70ceb81b0dd4340a65741d21b3ca85d.png&r=x","gravatar_id":"ab8ab5baea76b73a7d1c8f48e481661d","url":"https://api.github.com/users/ausaccessfed","html_url":"https://github.com/ausaccessfed","followers_url":"https://api.github.com/users/ausaccessfed/followers","following_url":"https://api.github.com/users/ausaccessfed/following{/other_user}","gists_url":"https://api.github.com/users/ausaccessfed/gists{/gist_id}","starred_url":"https://api.github.com/users/ausaccessfed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ausaccessfed/subscriptions","organizations_url":"https://api.github.com/users/ausaccessfed/orgs","repos_url":"https://api.github.com/users/ausaccessfed/repos","events_url":"https://api.github.com/users/ausaccessfed/events{/privacy}","received_events_url":"https://api.github.com/users/ausaccessfed/received_events","type":"User","site_admin":false},"repo":{"id":3373410,"name":"federationregistry","full_name":"ausaccessfed/federationregistry","owner":{"login":"ausaccessfed","id":149044,"avatar_url":"https://gravatar.com/avatar/ab8ab5baea76b73a7d1c8f48e481661d?d=https%3A%2F%2Fidenticons.github.com%2Fd70ceb81b0dd4340a65741d21b3ca85d.png&r=x","gravatar_id":"ab8ab5baea76b73a7d1c8f48e481661d","url":"https://api.github.com/users/ausaccessfed","html_url":"https://github.com/ausaccessfed","followers_url":"https://api.github.com/users/ausaccessfed/followers","following_url":"https://api.github.com/users/ausaccessfed/following{/other_user}","gists_url":"https://api.github.com/users/ausaccessfed/gists{/gist_id}","starred_url":"https://api.github.com/users/ausaccessfed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ausaccessfed/subscriptions","organizations_url":"https://api.github.com/users/ausaccessfed/orgs","repos_url":"https://api.github.com/users/ausaccessfed/repos","events_url":"https://api.github.com/users/ausaccessfed/events{/privacy}","received_events_url":"https://api.github.com/users/ausaccessfed/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ausaccessfed/federationregistry","description":"Federation Registry by the Australian Access Federation","fork":false,"url":"https://api.github.com/repos/ausaccessfed/federationregistry","forks_url":"https://api.github.com/repos/ausaccessfed/federationregistry/forks","keys_url":"https://api.github.com/repos/ausaccessfed/federationregistry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ausaccessfed/federationregistry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ausaccessfed/federationregistry/teams","hooks_url":"https://api.github.com/repos/ausaccessfed/federationregistry/hooks","issue_events_url":"https://api.github.com/repos/ausaccessfed/federationregistry/issues/events{/number}","events_url":"https://api.github.com/repos/ausaccessfed/federationregistry/events","assignees_url":"https://api.github.com/repos/ausaccessfed/federationregistry/assignees{/user}","branches_url":"https://api.github.com/repos/ausaccessfed/federationregistry/branches{/branch}","tags_url":"https://api.github.com/repos/ausaccessfed/federationregistry/tags","blobs_url":"https://api.github.com/repos/ausaccessfed/federationregistry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ausaccessfed/federationregistry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ausaccessfed/federationregistry/git/refs{/sha}","trees_url":"https://api.github.com/repos/ausaccessfed/federationregistry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ausaccessfed/federationregistry/statuses/{sha}","languages_url":"https://api.github.com/repos/ausaccessfed/federationregistry/languages","stargazers_url":"https://api.github.com/repos/ausaccessfed/federationregistry/stargazers","contributors_url":"https://api.github.com/repos/ausaccessfed/federationregistry/contributors","subscribers_url":"https://api.github.com/repos/ausaccessfed/federationregistry/subscribers","subscription_url":"https://api.github.com/repos/ausaccessfed/federationregistry/subscription","commits_url":"https://api.github.com/repos/ausaccessfed/federationregistry/commits{/sha}","git_commits_url":"https://api.github.com/repos/ausaccessfed/federationregistry/git/commits{/sha}","comments_url":"https://api.github.com/repos/ausaccessfed/federationregistry/comments{/number}","issue_comment_url":"https://api.github.com/repos/ausaccessfed/federationregistry/issues/comments/{number}","contents_url":"https://api.github.com/repos/ausaccessfed/federationregistry/contents/{+path}","compare_url":"https://api.github.com/repos/ausaccessfed/federationregistry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ausaccessfed/federationregistry/merges","archive_url":"https://api.github.com/repos/ausaccessfed/federationregistry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ausaccessfed/federationregistry/downloads","issues_url":"https://api.github.com/repos/ausaccessfed/federationregistry/issues{/number}","pulls_url":"https://api.github.com/repos/ausaccessfed/federationregistry/pulls{/number}","milestones_url":"https://api.github.com/repos/ausaccessfed/federationregistry/milestones{/number}","notifications_url":"https://api.github.com/repos/ausaccessfed/federationregistry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ausaccessfed/federationregistry/labels{/name}","releases_url":"https://api.github.com/repos/ausaccessfed/federationregistry/releases{/id}","created_at":"2012-02-07T02:03:24Z","updated_at":"2014-02-09T21:43:00Z","pushed_at":"2014-02-09T21:43:00Z","git_url":"git://github.com/ausaccessfed/federationregistry.git","ssh_url":"git@github.com:ausaccessfed/federationregistry.git","clone_url":"https://github.com/ausaccessfed/federationregistry.git","svn_url":"https://github.com/ausaccessfed/federationregistry","homepage":"http://www.aaf.edu.au","size":56081,"stargazers_count":10,"watchers_count":10,"language":"Groovy","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":3,"mirror_url":null,"open_issues_count":42,"forks":3,"open_issues":42,"watchers":10,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ausaccessfed/federationregistry/pulls/156"},"html":{"href":"https://github.com/ausaccessfed/federationregistry/pull/156"},"issue":{"href":"https://api.github.com/repos/ausaccessfed/federationregistry/issues/156"},"comments":{"href":"https://api.github.com/repos/ausaccessfed/federationregistry/issues/156/comments"},"review_comments":{"href":"https://api.github.com/repos/ausaccessfed/federationregistry/pulls/156/comments"},"review_comment":{"href":"https://api.github.com/repos/ausaccessfed/federationregistry/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ausaccessfed/federationregistry/pulls/156/commits"},"statuses":{"href":"https://api.github.com/repos/ausaccessfed/federationregistry/statuses/1118b69d229e1e6079d2233fbceff9562d122bde"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":23,"deletions":7,"changed_files":6}}