GitHub PullRequestReviewCommentEvent at 2014-09-22 06:13:27
Repository: PHP-CS-Fixer
Actor: keradus
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/fabpot/PHP-CS-Fixer/pulls/comments/17833604","id":17833604,"diff_hunk":"@@ -63,6 +63,19 @@ public function provideStandardCases()\n                 '<?php $a = new $b[$c[$d ? foo() : bar(\"bar[...]\") - 1]]();',\n                 '<?php $a = new $b[$c[$d ? foo() : bar(\"bar[...]\") - 1]];',\n             ),\n+            array(","path":"Symfony/CS/Tests/Fixer/Symfony/NewWithBracesFixerTest.php","position":4,"original_position":4,"commit_id":"89cb4de8331f8aaebee87a96462a78f0551c7129","original_commit_id":"89cb4de8331f8aaebee87a96462a78f0551c7129","user":{"login":"keradus","id":2716794,"avatar_url":"https://avatars.githubusercontent.com/u/2716794?v=2","gravatar_id":"c5b07b9ecc7801be7f6a3570a2955a06","url":"https://api.github.com/users/keradus","html_url":"https://github.com/keradus","followers_url":"https://api.github.com/users/keradus/followers","following_url":"https://api.github.com/users/keradus/following{/other_user}","gists_url":"https://api.github.com/users/keradus/gists{/gist_id}","starred_url":"https://api.github.com/users/keradus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keradus/subscriptions","organizations_url":"https://api.github.com/users/keradus/orgs","repos_url":"https://api.github.com/users/keradus/repos","events_url":"https://api.github.com/users/keradus/events{/privacy}","received_events_url":"https://api.github.com/users/keradus/received_events","type":"User","site_admin":false},"body":"please add:\r\n```php\r\n'<?php $a = new $b[\\'class\\'] () ;',\r\n'<?php $a = new $b[\\'class\\'] ;',\r\n```","created_at":"2014-09-22T06:13:27Z","updated_at":"2014-09-22T06:13:27Z","html_url":"https://github.com/fabpot/PHP-CS-Fixer/pull/568#discussion_r17833604","pull_request_url":"https://api.github.com/repos/fabpot/PHP-CS-Fixer/pulls/568","_links":{"self":{"href":"https://api.github.com/repos/fabpot/PHP-CS-Fixer/pulls/comments/17833604"},"html":{"href":"https://github.com/fabpot/PHP-CS-Fixer/pull/568#discussion_r17833604"},"pull_request":{"href":"https://api.github.com/repos/fabpot/PHP-CS-Fixer/pulls/568"}}},"pull_request":{"url":"https://api.github.com/repos/fabpot/PHP-CS-Fixer/pulls/568","id":21298299,"html_url":"https://github.com/fabpot/PHP-CS-Fixer/pull/568","diff_url":"https://github.com/fabpot/PHP-CS-Fixer/pull/568.diff","patch_url":"https://github.com/fabpot/PHP-CS-Fixer/pull/568.patch","issue_url":"https://api.github.com/repos/fabpot/PHP-CS-Fixer/issues/568","number":568,"state":"open","locked":false,"title":"Fix dynamically instantiated objects when using newWithBracesFilter.","user":{"login":"wjaspers","id":598148,"avatar_url":"https://avatars.githubusercontent.com/u/598148?v=2","gravatar_id":"3dbf805a4f70dd942d9d04e14cdef7bb","url":"https://api.github.com/users/wjaspers","html_url":"https://github.com/wjaspers","followers_url":"https://api.github.com/users/wjaspers/followers","following_url":"https://api.github.com/users/wjaspers/following{/other_user}","gists_url":"https://api.github.com/users/wjaspers/gists{/gist_id}","starred_url":"https://api.github.com/users/wjaspers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjaspers/subscriptions","organizations_url":"https://api.github.com/users/wjaspers/orgs","repos_url":"https://api.github.com/users/wjaspers/repos","events_url":"https://api.github.com/users/wjaspers/events{/privacy}","received_events_url":"https://api.github.com/users/wjaspers/received_events","type":"User","site_admin":false},"body":"As the test data demonstrates, a dynamically instantiated class would have been incorrectly 'fixed'.\r\n\r\n`return new $someObj['class']($someArg['thing']);`\r\nwould become\r\n`return new $someObj['class'()]($someArg['thing']);`\r\nwhich is invalid PHP.\r\n\r\nthe same applied when no constructor arguments were provided.","created_at":"2014-09-16T13:39:36Z","updated_at":"2014-09-22T06:13:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d7bb7398bf8fba98dd3a5c4f06ba5fc8aac8b0c4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/fabpot/PHP-CS-Fixer/pulls/568/commits","review_comments_url":"https://api.github.com/repos/fabpot/PHP-CS-Fixer/pulls/568/comments","review_comment_url":"https://api.github.com/repos/fabpot/PHP-CS-Fixer/pulls/comments/{number}","comments_url":"https://api.github.com/repos/fabpot/PHP-CS-Fixer/issues/568/comments","statuses_url":"https://api.github.com/repos/fabpot/PHP-CS-Fixer/statuses/89cb4de8331f8aaebee87a96462a78f0551c7129","head":{"label":"wjaspers:master","ref":"master","sha":"89cb4de8331f8aaebee87a96462a78f0551c7129","user":{"login":"wjaspers","id":598148,"avatar_url":"https://avatars.githubusercontent.com/u/598148?v=2","gravatar_id":"3dbf805a4f70dd942d9d04e14cdef7bb","url":"https://api.github.com/users/wjaspers","html_url":"https://github.com/wjaspers","followers_url":"https://api.github.com/users/wjaspers/followers","following_url":"https://api.github.com/users/wjaspers/following{/other_user}","gists_url":"https://api.github.com/users/wjaspers/gists{/gist_id}","starred_url":"https://api.github.com/users/wjaspers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjaspers/subscriptions","organizations_url":"https://api.github.com/users/wjaspers/orgs","repos_url":"https://api.github.com/users/wjaspers/repos","events_url":"https://api.github.com/users/wjaspers/events{/privacy}","received_events_url":"https://api.github.com/users/wjaspers/received_events","type":"User","site_admin":false},"repo":{"id":24063606,"name":"PHP-CS-Fixer","full_name":"wjaspers/PHP-CS-Fixer","owner":{"login":"wjaspers","id":598148,"avatar_url":"https://avatars.githubusercontent.com/u/598148?v=2","gravatar_id":"3dbf805a4f70dd942d9d04e14cdef7bb","url":"https://api.github.com/users/wjaspers","html_url":"https://github.com/wjaspers","followers_url":"https://api.github.com/users/wjaspers/followers","following_url":"https://api.github.com/users/wjaspers/following{/other_user}","gists_url":"https://api.github.com/users/wjaspers/gists{/gist_id}","starred_url":"https://api.github.com/users/wjaspers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjaspers/subscriptions","organizations_url":"https://api.github.com/users/wjaspers/orgs","repos_url":"https://api.github.com/users/wjaspers/repos","events_url":"https://api.github.com/users/wjaspers/events{/privacy}","received_events_url":"https://api.github.com/users/wjaspers/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wjaspers/PHP-CS-Fixer","description":"Analyzes some PHP source code and tries to fix coding standards issues (PSR-1 and PSR-2 compatible)","fork":true,"url":"https://api.github.com/repos/wjaspers/PHP-CS-Fixer","forks_url":"https://api.github.com/repos/wjaspers/PHP-CS-Fixer/forks","keys_url":"https://api.github.com/repos/wjaspers/PHP-CS-Fixer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wjaspers/PHP-CS-Fixer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wjaspers/PHP-CS-Fixer/teams","hooks_url":"https://api.github.com/repos/wjaspers/PHP-CS-Fixer/hooks","issue_events_url":"https://api.github.com/repos/wjaspers/PHP-CS-Fixer/issues/events{/number}","events_url":"https://api.github.com/repos/wjaspers/PHP-CS-Fixer/events","assignees_url":"https://api.github.com/repos/wjaspers/PHP-CS-Fixer/assignees{/user}","branches_url":"https://api.github.com/repos/wjaspers/PHP-CS-Fixer/branches{/branch}","tags_url":"https://api.github.com/repos/wjaspers/PHP-CS-Fixer/tags","blobs_url":"https://api.github.com/repos/wjaspers/PHP-CS-Fixer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wjaspers/PHP-CS-Fixer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wjaspers/PHP-CS-Fixer/git/refs{/sha}","trees_url":"https://api.github.com/repos/wjaspers/PHP-CS-Fixer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wjaspers/PHP-CS-Fixer/statuses/{sha}","languages_url":"https://api.github.com/repos/wjaspers/PHP-CS-Fixer/languages","stargazers_url":"https://api.github.com/repos/wjaspers/PHP-CS-Fixer/stargazers","contributors_url":"https://api.github.com/repos/wjaspers/PHP-CS-Fixer/contributors","subscribers_url":"https://api.github.com/repos/wjaspers/PHP-CS-Fixer/subscribers","subscription_url":"https://api.github.com/repos/wjaspers/PHP-CS-Fixer/subscription","commits_url":"https://api.github.com/repos/wjaspers/PHP-CS-Fixer/commits{/sha}","git_commits_url":"https://api.github.com/repos/wjaspers/PHP-CS-Fixer/git/commits{/sha}","comments_url":"https://api.github.com/repos/wjaspers/PHP-CS-Fixer/comments{/number}","issue_comment_url":"https://api.github.com/repos/wjaspers/PHP-CS-Fixer/issues/comments/{number}","contents_url":"https://api.github.com/repos/wjaspers/PHP-CS-Fixer/contents/{+path}","compare_url":"https://api.github.com/repos/wjaspers/PHP-CS-Fixer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wjaspers/PHP-CS-Fixer/merges","archive_url":"https://api.github.com/repos/wjaspers/PHP-CS-Fixer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wjaspers/PHP-CS-Fixer/downloads","issues_url":"https://api.github.com/repos/wjaspers/PHP-CS-Fixer/issues{/number}","pulls_url":"https://api.github.com/repos/wjaspers/PHP-CS-Fixer/pulls{/number}","milestones_url":"https://api.github.com/repos/wjaspers/PHP-CS-Fixer/milestones{/number}","notifications_url":"https://api.github.com/repos/wjaspers/PHP-CS-Fixer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wjaspers/PHP-CS-Fixer/labels{/name}","releases_url":"https://api.github.com/repos/wjaspers/PHP-CS-Fixer/releases{/id}","created_at":"2014-09-15T16:19:20Z","updated_at":"2014-09-16T13:32:51Z","pushed_at":"2014-09-22T03:29:56Z","git_url":"git://github.com/wjaspers/PHP-CS-Fixer.git","ssh_url":"git@github.com:wjaspers/PHP-CS-Fixer.git","clone_url":"https://github.com/wjaspers/PHP-CS-Fixer.git","svn_url":"https://github.com/wjaspers/PHP-CS-Fixer","homepage":"cs.sensiolabs.org","size":1298,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fabpot:master","ref":"master","sha":"ba1b7c5eaf918084cf0a46dfd3396c98339600e9","user":{"login":"fabpot","id":47313,"avatar_url":"https://avatars.githubusercontent.com/u/47313?v=2","gravatar_id":"f1a2c5905e121d09feba5ad73898ffca","url":"https://api.github.com/users/fabpot","html_url":"https://github.com/fabpot","followers_url":"https://api.github.com/users/fabpot/followers","following_url":"https://api.github.com/users/fabpot/following{/other_user}","gists_url":"https://api.github.com/users/fabpot/gists{/gist_id}","starred_url":"https://api.github.com/users/fabpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabpot/subscriptions","organizations_url":"https://api.github.com/users/fabpot/orgs","repos_url":"https://api.github.com/users/fabpot/repos","events_url":"https://api.github.com/users/fabpot/events{/privacy}","received_events_url":"https://api.github.com/users/fabpot/received_events","type":"User","site_admin":false},"repo":{"id":4344257,"name":"PHP-CS-Fixer","full_name":"fabpot/PHP-CS-Fixer","owner":{"login":"fabpot","id":47313,"avatar_url":"https://avatars.githubusercontent.com/u/47313?v=2","gravatar_id":"f1a2c5905e121d09feba5ad73898ffca","url":"https://api.github.com/users/fabpot","html_url":"https://github.com/fabpot","followers_url":"https://api.github.com/users/fabpot/followers","following_url":"https://api.github.com/users/fabpot/following{/other_user}","gists_url":"https://api.github.com/users/fabpot/gists{/gist_id}","starred_url":"https://api.github.com/users/fabpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabpot/subscriptions","organizations_url":"https://api.github.com/users/fabpot/orgs","repos_url":"https://api.github.com/users/fabpot/repos","events_url":"https://api.github.com/users/fabpot/events{/privacy}","received_events_url":"https://api.github.com/users/fabpot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fabpot/PHP-CS-Fixer","description":"Analyzes some PHP source code and tries to fix coding standards issues (PSR-1 and PSR-2 compatible)","fork":false,"url":"https://api.github.com/repos/fabpot/PHP-CS-Fixer","forks_url":"https://api.github.com/repos/fabpot/PHP-CS-Fixer/forks","keys_url":"https://api.github.com/repos/fabpot/PHP-CS-Fixer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabpot/PHP-CS-Fixer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabpot/PHP-CS-Fixer/teams","hooks_url":"https://api.github.com/repos/fabpot/PHP-CS-Fixer/hooks","issue_events_url":"https://api.github.com/repos/fabpot/PHP-CS-Fixer/issues/events{/number}","events_url":"https://api.github.com/repos/fabpot/PHP-CS-Fixer/events","assignees_url":"https://api.github.com/repos/fabpot/PHP-CS-Fixer/assignees{/user}","branches_url":"https://api.github.com/repos/fabpot/PHP-CS-Fixer/branches{/branch}","tags_url":"https://api.github.com/repos/fabpot/PHP-CS-Fixer/tags","blobs_url":"https://api.github.com/repos/fabpot/PHP-CS-Fixer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabpot/PHP-CS-Fixer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabpot/PHP-CS-Fixer/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabpot/PHP-CS-Fixer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabpot/PHP-CS-Fixer/statuses/{sha}","languages_url":"https://api.github.com/repos/fabpot/PHP-CS-Fixer/languages","stargazers_url":"https://api.github.com/repos/fabpot/PHP-CS-Fixer/stargazers","contributors_url":"https://api.github.com/repos/fabpot/PHP-CS-Fixer/contributors","subscribers_url":"https://api.github.com/repos/fabpot/PHP-CS-Fixer/subscribers","subscription_url":"https://api.github.com/repos/fabpot/PHP-CS-Fixer/subscription","commits_url":"https://api.github.com/repos/fabpot/PHP-CS-Fixer/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabpot/PHP-CS-Fixer/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabpot/PHP-CS-Fixer/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabpot/PHP-CS-Fixer/issues/comments/{number}","contents_url":"https://api.github.com/repos/fabpot/PHP-CS-Fixer/contents/{+path}","compare_url":"https://api.github.com/repos/fabpot/PHP-CS-Fixer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabpot/PHP-CS-Fixer/merges","archive_url":"https://api.github.com/repos/fabpot/PHP-CS-Fixer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabpot/PHP-CS-Fixer/downloads","issues_url":"https://api.github.com/repos/fabpot/PHP-CS-Fixer/issues{/number}","pulls_url":"https://api.github.com/repos/fabpot/PHP-CS-Fixer/pulls{/number}","milestones_url":"https://api.github.com/repos/fabpot/PHP-CS-Fixer/milestones{/number}","notifications_url":"https://api.github.com/repos/fabpot/PHP-CS-Fixer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabpot/PHP-CS-Fixer/labels{/name}","releases_url":"https://api.github.com/repos/fabpot/PHP-CS-Fixer/releases{/id}","created_at":"2012-05-16T06:42:23Z","updated_at":"2014-09-19T15:18:13Z","pushed_at":"2014-09-21T14:21:33Z","git_url":"git://github.com/fabpot/PHP-CS-Fixer.git","ssh_url":"git@github.com:fabpot/PHP-CS-Fixer.git","clone_url":"https://github.com/fabpot/PHP-CS-Fixer.git","svn_url":"https://github.com/fabpot/PHP-CS-Fixer","homepage":"cs.sensiolabs.org","size":7690,"stargazers_count":1518,"watchers_count":1518,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":257,"mirror_url":null,"open_issues_count":60,"forks":257,"open_issues":60,"watchers":1518,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fabpot/PHP-CS-Fixer/pulls/568"},"html":{"href":"https://github.com/fabpot/PHP-CS-Fixer/pull/568"},"issue":{"href":"https://api.github.com/repos/fabpot/PHP-CS-Fixer/issues/568"},"comments":{"href":"https://api.github.com/repos/fabpot/PHP-CS-Fixer/issues/568/comments"},"review_comments":{"href":"https://api.github.com/repos/fabpot/PHP-CS-Fixer/pulls/568/comments"},"review_comment":{"href":"https://api.github.com/repos/fabpot/PHP-CS-Fixer/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/fabpot/PHP-CS-Fixer/pulls/568/commits"},"statuses":{"href":"https://api.github.com/repos/fabpot/PHP-CS-Fixer/statuses/89cb4de8331f8aaebee87a96462a78f0551c7129"}}}}