GitHub PullRequestReviewCommentEvent at 2014-11-10 05:31:06
Repository: fjord
Actor: rehandalal
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/fjord/pulls/comments/20067276","id":20067276,"diff_hunk":"@@ -41,104 +248,107 @@ textarea.error {\n \n   &.warning {\n     color: orange;\n+    font-weight: bold;\n   }\n }\n \n-aside {\n-  background-color: #D8E9F5;\n-  border: 1px solid #A4C5DB;\n-  font-size: 0.9em;\n-  margin: 3vh auto;\n+body.html-rtl #description-counter {\n+  text-align: left;\n+}\n \n+#id_url {\n+  box-sizing: border-box;\n   width: 100%;\n-\n-  div {\n-    padding: 5px;\n-  }\n }\n \n-x-card {\n-  display: none;\n-\n-  section {\n-    display: block;\n-    margin: 0 auto;\n-    max-width: 320px;\n-    overflow: visible;\n-    padding: 5px;\n-\n-    textarea {\n-      .box-sizing(border-box);\n-      height: 4em;\n-      width: 100%;\n-    }\n-  }\n+#id_email {\n+  box-sizing: border-box;\n+  width: 100%;\n+}\n \n-  &.happy {\n-    .sad {\n-      display: none;\n-    }\n-  }\n-  &.sad {\n-    .happy {\n-      display: none;\n-    }\n-  }\n+aside {\n+  background-color: #d8e9f5;\n+  border-radius: 10px;\n+  border: 1px solid #a4c5db;\n+  box-sizing: border-box;\n+  font-size: 10pt;\n+  margin: 20px;\n+  padding: 10px;\n+  text-align: center;\n }\n \n-x-appbar {\n+.btn.submit {\n+  background-color: #81BC2E;\n+  background-clip: padding-box;\n+  background-image: -moz-linear-gradient(center top , #81BC2E 0px, #629827 100%);\n+  border-color: -moz-use-text-color -moz-use-text-color #548322;\n+  -moz-border-top-colors: none;\n+  -moz-border-right-colors: none;\n+  -moz-border-bottom-colors: none;\n+  -moz-border-left-colors: none;","path":"fjord/feedback/static/css/generic_feedback_dev.less","position":333,"original_position":333,"commit_id":"f511215347706c07d94e9a6b1b29a3cdcea3ba87","original_commit_id":"f511215347706c07d94e9a6b1b29a3cdcea3ba87","user":{"login":"rehandalal","id":987136,"avatar_url":"https://avatars.githubusercontent.com/u/987136?v=3","gravatar_id":"","url":"https://api.github.com/users/rehandalal","html_url":"https://github.com/rehandalal","followers_url":"https://api.github.com/users/rehandalal/followers","following_url":"https://api.github.com/users/rehandalal/following{/other_user}","gists_url":"https://api.github.com/users/rehandalal/gists{/gist_id}","starred_url":"https://api.github.com/users/rehandalal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rehandalal/subscriptions","organizations_url":"https://api.github.com/users/rehandalal/orgs","repos_url":"https://api.github.com/users/rehandalal/repos","events_url":"https://api.github.com/users/rehandalal/events{/privacy}","received_events_url":"https://api.github.com/users/rehandalal/received_events","type":"User","site_admin":false},"body":"likewise with the `-moz-border` stuff. not sure why you've got these in there?","created_at":"2014-11-10T05:31:06Z","updated_at":"2014-11-10T05:31:06Z","html_url":"https://github.com/mozilla/fjord/pull/377#discussion_r20067276","pull_request_url":"https://api.github.com/repos/mozilla/fjord/pulls/377","_links":{"self":{"href":"https://api.github.com/repos/mozilla/fjord/pulls/comments/20067276"},"html":{"href":"https://github.com/mozilla/fjord/pull/377#discussion_r20067276"},"pull_request":{"href":"https://api.github.com/repos/mozilla/fjord/pulls/377"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/fjord/pulls/377","id":24085806,"html_url":"https://github.com/mozilla/fjord/pull/377","diff_url":"https://github.com/mozilla/fjord/pull/377.diff","patch_url":"https://github.com/mozilla/fjord/pull/377.patch","issue_url":"https://api.github.com/repos/mozilla/fjord/issues/377","number":377,"state":"open","locked":false,"title":"1077423 overhaul generic","user":{"login":"willkg","id":820826,"avatar_url":"https://avatars.githubusercontent.com/u/820826?v=3","gravatar_id":"","url":"https://api.github.com/users/willkg","html_url":"https://github.com/willkg","followers_url":"https://api.github.com/users/willkg/followers","following_url":"https://api.github.com/users/willkg/following{/other_user}","gists_url":"https://api.github.com/users/willkg/gists{/gist_id}","starred_url":"https://api.github.com/users/willkg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willkg/subscriptions","organizations_url":"https://api.github.com/users/willkg/orgs","repos_url":"https://api.github.com/users/willkg/repos","events_url":"https://api.github.com/users/willkg/events{/privacy}","received_events_url":"https://api.github.com/users/willkg/received_events","type":"User","site_admin":false},"body":"TOTAL GENERIC FORM (DEV VERSION) OVERHAUL!\r\n\r\nThis is a big change. To see it in your browser:\r\n\r\n1. do `./manage.py runserver`\r\n2. visit `/feedback/?feedbackdev=1`\r\n\r\nTo review:\r\n\r\n1. check out the CSS--it's a completely new file, so don't bother looking at the diff. does it look ok? am i doing dumb css things?\r\n2. check out the js--i reused a bunch of stuff, so i'm feeling pretty ok with this.\r\n3. check out the html template--does it look ok?\r\n4. run the tests.\r\n5. run the smoketests if you can.","created_at":"2014-11-07T22:03:52Z","updated_at":"2014-11-10T05:31:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f50fefab1d74fe652978a73e8fb7b0c2fb081f19","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/fjord/pulls/377/commits","review_comments_url":"https://api.github.com/repos/mozilla/fjord/pulls/377/comments","review_comment_url":"https://api.github.com/repos/mozilla/fjord/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla/fjord/issues/377/comments","statuses_url":"https://api.github.com/repos/mozilla/fjord/statuses/f511215347706c07d94e9a6b1b29a3cdcea3ba87","head":{"label":"willkg:1077423-overhaul-generic","ref":"1077423-overhaul-generic","sha":"f511215347706c07d94e9a6b1b29a3cdcea3ba87","user":{"login":"willkg","id":820826,"avatar_url":"https://avatars.githubusercontent.com/u/820826?v=3","gravatar_id":"","url":"https://api.github.com/users/willkg","html_url":"https://github.com/willkg","followers_url":"https://api.github.com/users/willkg/followers","following_url":"https://api.github.com/users/willkg/following{/other_user}","gists_url":"https://api.github.com/users/willkg/gists{/gist_id}","starred_url":"https://api.github.com/users/willkg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willkg/subscriptions","organizations_url":"https://api.github.com/users/willkg/orgs","repos_url":"https://api.github.com/users/willkg/repos","events_url":"https://api.github.com/users/willkg/events{/privacy}","received_events_url":"https://api.github.com/users/willkg/received_events","type":"User","site_admin":false},"repo":{"id":5204498,"name":"fjord","full_name":"willkg/fjord","owner":{"login":"willkg","id":820826,"avatar_url":"https://avatars.githubusercontent.com/u/820826?v=3","gravatar_id":"","url":"https://api.github.com/users/willkg","html_url":"https://github.com/willkg","followers_url":"https://api.github.com/users/willkg/followers","following_url":"https://api.github.com/users/willkg/following{/other_user}","gists_url":"https://api.github.com/users/willkg/gists{/gist_id}","starred_url":"https://api.github.com/users/willkg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willkg/subscriptions","organizations_url":"https://api.github.com/users/willkg/orgs","repos_url":"https://api.github.com/users/willkg/repos","events_url":"https://api.github.com/users/willkg/events{/privacy}","received_events_url":"https://api.github.com/users/willkg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/willkg/fjord","description":"Software that runs the new input.mozilla.org","fork":true,"url":"https://api.github.com/repos/willkg/fjord","forks_url":"https://api.github.com/repos/willkg/fjord/forks","keys_url":"https://api.github.com/repos/willkg/fjord/keys{/key_id}","collaborators_url":"https://api.github.com/repos/willkg/fjord/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/willkg/fjord/teams","hooks_url":"https://api.github.com/repos/willkg/fjord/hooks","issue_events_url":"https://api.github.com/repos/willkg/fjord/issues/events{/number}","events_url":"https://api.github.com/repos/willkg/fjord/events","assignees_url":"https://api.github.com/repos/willkg/fjord/assignees{/user}","branches_url":"https://api.github.com/repos/willkg/fjord/branches{/branch}","tags_url":"https://api.github.com/repos/willkg/fjord/tags","blobs_url":"https://api.github.com/repos/willkg/fjord/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/willkg/fjord/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/willkg/fjord/git/refs{/sha}","trees_url":"https://api.github.com/repos/willkg/fjord/git/trees{/sha}","statuses_url":"https://api.github.com/repos/willkg/fjord/statuses/{sha}","languages_url":"https://api.github.com/repos/willkg/fjord/languages","stargazers_url":"https://api.github.com/repos/willkg/fjord/stargazers","contributors_url":"https://api.github.com/repos/willkg/fjord/contributors","subscribers_url":"https://api.github.com/repos/willkg/fjord/subscribers","subscription_url":"https://api.github.com/repos/willkg/fjord/subscription","commits_url":"https://api.github.com/repos/willkg/fjord/commits{/sha}","git_commits_url":"https://api.github.com/repos/willkg/fjord/git/commits{/sha}","comments_url":"https://api.github.com/repos/willkg/fjord/comments{/number}","issue_comment_url":"https://api.github.com/repos/willkg/fjord/issues/comments/{number}","contents_url":"https://api.github.com/repos/willkg/fjord/contents/{+path}","compare_url":"https://api.github.com/repos/willkg/fjord/compare/{base}...{head}","merges_url":"https://api.github.com/repos/willkg/fjord/merges","archive_url":"https://api.github.com/repos/willkg/fjord/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/willkg/fjord/downloads","issues_url":"https://api.github.com/repos/willkg/fjord/issues{/number}","pulls_url":"https://api.github.com/repos/willkg/fjord/pulls{/number}","milestones_url":"https://api.github.com/repos/willkg/fjord/milestones{/number}","notifications_url":"https://api.github.com/repos/willkg/fjord/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/willkg/fjord/labels{/name}","releases_url":"https://api.github.com/repos/willkg/fjord/releases{/id}","created_at":"2012-07-27T12:53:19Z","updated_at":"2014-09-05T23:19:01Z","pushed_at":"2014-11-07T22:01:34Z","git_url":"git://github.com/willkg/fjord.git","ssh_url":"git@github.com:willkg/fjord.git","clone_url":"https://github.com/willkg/fjord.git","svn_url":"https://github.com/willkg/fjord","homepage":null,"size":24020,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"11193d7e86f0a84a53c2b88c932ff54cc0b24715","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":5197539,"name":"fjord","full_name":"mozilla/fjord","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/fjord","description":"Software that runs the new input.mozilla.org","fork":false,"url":"https://api.github.com/repos/mozilla/fjord","forks_url":"https://api.github.com/repos/mozilla/fjord/forks","keys_url":"https://api.github.com/repos/mozilla/fjord/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/fjord/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/fjord/teams","hooks_url":"https://api.github.com/repos/mozilla/fjord/hooks","issue_events_url":"https://api.github.com/repos/mozilla/fjord/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/fjord/events","assignees_url":"https://api.github.com/repos/mozilla/fjord/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/fjord/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/fjord/tags","blobs_url":"https://api.github.com/repos/mozilla/fjord/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/fjord/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/fjord/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/fjord/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/fjord/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/fjord/languages","stargazers_url":"https://api.github.com/repos/mozilla/fjord/stargazers","contributors_url":"https://api.github.com/repos/mozilla/fjord/contributors","subscribers_url":"https://api.github.com/repos/mozilla/fjord/subscribers","subscription_url":"https://api.github.com/repos/mozilla/fjord/subscription","commits_url":"https://api.github.com/repos/mozilla/fjord/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/fjord/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/fjord/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/fjord/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla/fjord/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/fjord/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/fjord/merges","archive_url":"https://api.github.com/repos/mozilla/fjord/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/fjord/downloads","issues_url":"https://api.github.com/repos/mozilla/fjord/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/fjord/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/fjord/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/fjord/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/fjord/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/fjord/releases{/id}","created_at":"2012-07-26T21:25:00Z","updated_at":"2014-10-18T18:11:13Z","pushed_at":"2014-11-06T01:36:01Z","git_url":"git://github.com/mozilla/fjord.git","ssh_url":"git@github.com:mozilla/fjord.git","clone_url":"https://github.com/mozilla/fjord.git","svn_url":"https://github.com/mozilla/fjord","homepage":null,"size":28542,"stargazers_count":17,"watchers_count":17,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":38,"mirror_url":null,"open_issues_count":1,"forks":38,"open_issues":1,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/fjord/pulls/377"},"html":{"href":"https://github.com/mozilla/fjord/pull/377"},"issue":{"href":"https://api.github.com/repos/mozilla/fjord/issues/377"},"comments":{"href":"https://api.github.com/repos/mozilla/fjord/issues/377/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/fjord/pulls/377/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/fjord/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla/fjord/pulls/377/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/fjord/statuses/f511215347706c07d94e9a6b1b29a3cdcea3ba87"}}}}