GitHub PullRequestReviewCommentEvent at 2014-07-02 03:18:21
Repository: nunit-vs-adapter
Actor: sandshadow
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/nunit/nunit-vs-adapter/pulls/comments/14439356","id":14439356,"diff_hunk":"@@ -174,6 +175,23 @@ public void TestOutput_CallsSendMessageCorrectly(string nunitMessage, string exp\n \n         #endregion\n \n+        #region Listener Lifetime Tests\n+        [Test]","path":"src/NUnitTestAdapterTests/NUnitEventListenerTests.cs","position":22,"original_position":22,"commit_id":"2c7ca929ca90b37f55175d32c9209004ef87dcba","original_commit_id":"2c7ca929ca90b37f55175d32c9209004ef87dcba","user":{"login":"sandshadow","id":7919106,"avatar_url":"https://avatars.githubusercontent.com/u/7919106?","gravatar_id":"a62a9c3afd8ef40ab270deff9dbc3de6","url":"https://api.github.com/users/sandshadow","html_url":"https://github.com/sandshadow","followers_url":"https://api.github.com/users/sandshadow/followers","following_url":"https://api.github.com/users/sandshadow/following{/other_user}","gists_url":"https://api.github.com/users/sandshadow/gists{/gist_id}","starred_url":"https://api.github.com/users/sandshadow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandshadow/subscriptions","organizations_url":"https://api.github.com/users/sandshadow/orgs","repos_url":"https://api.github.com/users/sandshadow/repos","events_url":"https://api.github.com/users/sandshadow/events{/privacy}","received_events_url":"https://api.github.com/users/sandshadow/received_events","type":"User","site_admin":false},"body":"I'd argue that it verifies that the listener actually has a null lifetime. I'm open to alternative ways to test this, though the only real regression test I could think of was to execute all tests in the IssueNo24Tests class and verify that all 4 were run. This would introduce a test that's much longer induration than anything else you have here though.","created_at":"2014-07-02T03:18:21Z","updated_at":"2014-07-02T03:18:21Z","html_url":"https://github.com/nunit/nunit-vs-adapter/pull/36#discussion_r14439356","pull_request_url":"https://api.github.com/repos/nunit/nunit-vs-adapter/pulls/36","_links":{"self":{"href":"https://api.github.com/repos/nunit/nunit-vs-adapter/pulls/comments/14439356"},"html":{"href":"https://github.com/nunit/nunit-vs-adapter/pull/36#discussion_r14439356"},"pull_request":{"href":"https://api.github.com/repos/nunit/nunit-vs-adapter/pulls/36"}}},"pull_request":{"url":"https://api.github.com/repos/nunit/nunit-vs-adapter/pulls/36","id":17806306,"html_url":"https://github.com/nunit/nunit-vs-adapter/pull/36","diff_url":"https://github.com/nunit/nunit-vs-adapter/pull/36.diff","patch_url":"https://github.com/nunit/nunit-vs-adapter/pull/36.patch","issue_url":"https://api.github.com/repos/nunit/nunit-vs-adapter/issues/36","number":36,"state":"open","title":"Fix for issue No 24","user":{"login":"sandshadow","id":7919106,"avatar_url":"https://avatars.githubusercontent.com/u/7919106?","gravatar_id":"a62a9c3afd8ef40ab270deff9dbc3de6","url":"https://api.github.com/users/sandshadow","html_url":"https://github.com/sandshadow","followers_url":"https://api.github.com/users/sandshadow/followers","following_url":"https://api.github.com/users/sandshadow/following{/other_user}","gists_url":"https://api.github.com/users/sandshadow/gists{/gist_id}","starred_url":"https://api.github.com/users/sandshadow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandshadow/subscriptions","organizations_url":"https://api.github.com/users/sandshadow/orgs","repos_url":"https://api.github.com/users/sandshadow/repos","events_url":"https://api.github.com/users/sandshadow/events{/privacy}","received_events_url":"https://api.github.com/users/sandshadow/received_events","type":"User","site_admin":false},"body":"Fix for issue No 24\r\nThe root issue is that NUnitEventListener is a MarshalByRefObject. This means it has a default lifetime lease of 5 minutes, with an extension of 2 minutes every time it receives a callback.\r\nhttp://msdn.microsoft.com/en-us/magazine/cc300474.aspx#edupdate\r\nChanges:\r\n1. Give NUnitEventListener an infinite lifetime lease\r\n2. Implement IDisposable, and call RemotingServices.Disconnect to prevent memory leaks\r\n\r\nI have verified under WinDBG/SOS that when running tests from multiple assemblies, there is only 1 NUnitEventListener on the heap with parents. Without calling RemotingServices.Disconnect, there is an NUnitEventListener for each test assembly. (This is also the case with the current code, until the lifetime lease expires).\r\n\r\nThe IssueNo24Tests included in the pull request can be excluded from runs with -Trait:\"LongRunning\". Or I could exclude them from the pull request once the fix has been verified, and just rely on the Listener_LeaseLifetimeWillNotExpire test for coverage.\r\n\r\nThis is my first GitHub pull request/contribution, so if I have missed something in the workflow, please let me know.","created_at":"2014-07-01T00:23:51Z","updated_at":"2014-07-02T03:18:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4875de58c0e5a7b89c91ca5ee73f9133235cfe00","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nunit/nunit-vs-adapter/pulls/36/commits","review_comments_url":"https://api.github.com/repos/nunit/nunit-vs-adapter/pulls/36/comments","review_comment_url":"https://api.github.com/repos/nunit/nunit-vs-adapter/pulls/comments/{number}","comments_url":"https://api.github.com/repos/nunit/nunit-vs-adapter/issues/36/comments","statuses_url":"https://api.github.com/repos/nunit/nunit-vs-adapter/statuses/2c7ca929ca90b37f55175d32c9209004ef87dcba","head":{"label":"sandshadow:master","ref":"master","sha":"2c7ca929ca90b37f55175d32c9209004ef87dcba","user":{"login":"sandshadow","id":7919106,"avatar_url":"https://avatars.githubusercontent.com/u/7919106?","gravatar_id":"a62a9c3afd8ef40ab270deff9dbc3de6","url":"https://api.github.com/users/sandshadow","html_url":"https://github.com/sandshadow","followers_url":"https://api.github.com/users/sandshadow/followers","following_url":"https://api.github.com/users/sandshadow/following{/other_user}","gists_url":"https://api.github.com/users/sandshadow/gists{/gist_id}","starred_url":"https://api.github.com/users/sandshadow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandshadow/subscriptions","organizations_url":"https://api.github.com/users/sandshadow/orgs","repos_url":"https://api.github.com/users/sandshadow/repos","events_url":"https://api.github.com/users/sandshadow/events{/privacy}","received_events_url":"https://api.github.com/users/sandshadow/received_events","type":"User","site_admin":false},"repo":{"id":21252464,"name":"nunit-vs-adapter","full_name":"sandshadow/nunit-vs-adapter","owner":{"login":"sandshadow","id":7919106,"avatar_url":"https://avatars.githubusercontent.com/u/7919106?","gravatar_id":"a62a9c3afd8ef40ab270deff9dbc3de6","url":"https://api.github.com/users/sandshadow","html_url":"https://github.com/sandshadow","followers_url":"https://api.github.com/users/sandshadow/followers","following_url":"https://api.github.com/users/sandshadow/following{/other_user}","gists_url":"https://api.github.com/users/sandshadow/gists{/gist_id}","starred_url":"https://api.github.com/users/sandshadow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandshadow/subscriptions","organizations_url":"https://api.github.com/users/sandshadow/orgs","repos_url":"https://api.github.com/users/sandshadow/repos","events_url":"https://api.github.com/users/sandshadow/events{/privacy}","received_events_url":"https://api.github.com/users/sandshadow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sandshadow/nunit-vs-adapter","description":"Runs NUnit tests inside the Visual Studio 2012 or 2013 Test Explorer window.","fork":true,"url":"https://api.github.com/repos/sandshadow/nunit-vs-adapter","forks_url":"https://api.github.com/repos/sandshadow/nunit-vs-adapter/forks","keys_url":"https://api.github.com/repos/sandshadow/nunit-vs-adapter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sandshadow/nunit-vs-adapter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sandshadow/nunit-vs-adapter/teams","hooks_url":"https://api.github.com/repos/sandshadow/nunit-vs-adapter/hooks","issue_events_url":"https://api.github.com/repos/sandshadow/nunit-vs-adapter/issues/events{/number}","events_url":"https://api.github.com/repos/sandshadow/nunit-vs-adapter/events","assignees_url":"https://api.github.com/repos/sandshadow/nunit-vs-adapter/assignees{/user}","branches_url":"https://api.github.com/repos/sandshadow/nunit-vs-adapter/branches{/branch}","tags_url":"https://api.github.com/repos/sandshadow/nunit-vs-adapter/tags","blobs_url":"https://api.github.com/repos/sandshadow/nunit-vs-adapter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sandshadow/nunit-vs-adapter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sandshadow/nunit-vs-adapter/git/refs{/sha}","trees_url":"https://api.github.com/repos/sandshadow/nunit-vs-adapter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sandshadow/nunit-vs-adapter/statuses/{sha}","languages_url":"https://api.github.com/repos/sandshadow/nunit-vs-adapter/languages","stargazers_url":"https://api.github.com/repos/sandshadow/nunit-vs-adapter/stargazers","contributors_url":"https://api.github.com/repos/sandshadow/nunit-vs-adapter/contributors","subscribers_url":"https://api.github.com/repos/sandshadow/nunit-vs-adapter/subscribers","subscription_url":"https://api.github.com/repos/sandshadow/nunit-vs-adapter/subscription","commits_url":"https://api.github.com/repos/sandshadow/nunit-vs-adapter/commits{/sha}","git_commits_url":"https://api.github.com/repos/sandshadow/nunit-vs-adapter/git/commits{/sha}","comments_url":"https://api.github.com/repos/sandshadow/nunit-vs-adapter/comments{/number}","issue_comment_url":"https://api.github.com/repos/sandshadow/nunit-vs-adapter/issues/comments/{number}","contents_url":"https://api.github.com/repos/sandshadow/nunit-vs-adapter/contents/{+path}","compare_url":"https://api.github.com/repos/sandshadow/nunit-vs-adapter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sandshadow/nunit-vs-adapter/merges","archive_url":"https://api.github.com/repos/sandshadow/nunit-vs-adapter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sandshadow/nunit-vs-adapter/downloads","issues_url":"https://api.github.com/repos/sandshadow/nunit-vs-adapter/issues{/number}","pulls_url":"https://api.github.com/repos/sandshadow/nunit-vs-adapter/pulls{/number}","milestones_url":"https://api.github.com/repos/sandshadow/nunit-vs-adapter/milestones{/number}","notifications_url":"https://api.github.com/repos/sandshadow/nunit-vs-adapter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sandshadow/nunit-vs-adapter/labels{/name}","releases_url":"https://api.github.com/repos/sandshadow/nunit-vs-adapter/releases{/id}","created_at":"2014-06-26T19:34:58Z","updated_at":"2014-06-15T21:49:16Z","pushed_at":"2014-06-26T21:14:26Z","git_url":"git://github.com/sandshadow/nunit-vs-adapter.git","ssh_url":"git@github.com:sandshadow/nunit-vs-adapter.git","clone_url":"https://github.com/sandshadow/nunit-vs-adapter.git","svn_url":"https://github.com/sandshadow/nunit-vs-adapter","homepage":null,"size":1535,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nunit:master","ref":"master","sha":"eb66cedd461789f10b574c65088a2a6ea5316eaf","user":{"login":"nunit","id":2678858,"avatar_url":"https://avatars.githubusercontent.com/u/2678858?","gravatar_id":null,"url":"https://api.github.com/users/nunit","html_url":"https://github.com/nunit","followers_url":"https://api.github.com/users/nunit/followers","following_url":"https://api.github.com/users/nunit/following{/other_user}","gists_url":"https://api.github.com/users/nunit/gists{/gist_id}","starred_url":"https://api.github.com/users/nunit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nunit/subscriptions","organizations_url":"https://api.github.com/users/nunit/orgs","repos_url":"https://api.github.com/users/nunit/repos","events_url":"https://api.github.com/users/nunit/events{/privacy}","received_events_url":"https://api.github.com/users/nunit/received_events","type":"Organization","site_admin":false},"repo":{"id":13373318,"name":"nunit-vs-adapter","full_name":"nunit/nunit-vs-adapter","owner":{"login":"nunit","id":2678858,"avatar_url":"https://avatars.githubusercontent.com/u/2678858?","gravatar_id":null,"url":"https://api.github.com/users/nunit","html_url":"https://github.com/nunit","followers_url":"https://api.github.com/users/nunit/followers","following_url":"https://api.github.com/users/nunit/following{/other_user}","gists_url":"https://api.github.com/users/nunit/gists{/gist_id}","starred_url":"https://api.github.com/users/nunit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nunit/subscriptions","organizations_url":"https://api.github.com/users/nunit/orgs","repos_url":"https://api.github.com/users/nunit/repos","events_url":"https://api.github.com/users/nunit/events{/privacy}","received_events_url":"https://api.github.com/users/nunit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nunit/nunit-vs-adapter","description":"Runs NUnit tests inside the Visual Studio 2012 or 2013 Test Explorer window.","fork":false,"url":"https://api.github.com/repos/nunit/nunit-vs-adapter","forks_url":"https://api.github.com/repos/nunit/nunit-vs-adapter/forks","keys_url":"https://api.github.com/repos/nunit/nunit-vs-adapter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nunit/nunit-vs-adapter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nunit/nunit-vs-adapter/teams","hooks_url":"https://api.github.com/repos/nunit/nunit-vs-adapter/hooks","issue_events_url":"https://api.github.com/repos/nunit/nunit-vs-adapter/issues/events{/number}","events_url":"https://api.github.com/repos/nunit/nunit-vs-adapter/events","assignees_url":"https://api.github.com/repos/nunit/nunit-vs-adapter/assignees{/user}","branches_url":"https://api.github.com/repos/nunit/nunit-vs-adapter/branches{/branch}","tags_url":"https://api.github.com/repos/nunit/nunit-vs-adapter/tags","blobs_url":"https://api.github.com/repos/nunit/nunit-vs-adapter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nunit/nunit-vs-adapter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nunit/nunit-vs-adapter/git/refs{/sha}","trees_url":"https://api.github.com/repos/nunit/nunit-vs-adapter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nunit/nunit-vs-adapter/statuses/{sha}","languages_url":"https://api.github.com/repos/nunit/nunit-vs-adapter/languages","stargazers_url":"https://api.github.com/repos/nunit/nunit-vs-adapter/stargazers","contributors_url":"https://api.github.com/repos/nunit/nunit-vs-adapter/contributors","subscribers_url":"https://api.github.com/repos/nunit/nunit-vs-adapter/subscribers","subscription_url":"https://api.github.com/repos/nunit/nunit-vs-adapter/subscription","commits_url":"https://api.github.com/repos/nunit/nunit-vs-adapter/commits{/sha}","git_commits_url":"https://api.github.com/repos/nunit/nunit-vs-adapter/git/commits{/sha}","comments_url":"https://api.github.com/repos/nunit/nunit-vs-adapter/comments{/number}","issue_comment_url":"https://api.github.com/repos/nunit/nunit-vs-adapter/issues/comments/{number}","contents_url":"https://api.github.com/repos/nunit/nunit-vs-adapter/contents/{+path}","compare_url":"https://api.github.com/repos/nunit/nunit-vs-adapter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nunit/nunit-vs-adapter/merges","archive_url":"https://api.github.com/repos/nunit/nunit-vs-adapter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nunit/nunit-vs-adapter/downloads","issues_url":"https://api.github.com/repos/nunit/nunit-vs-adapter/issues{/number}","pulls_url":"https://api.github.com/repos/nunit/nunit-vs-adapter/pulls{/number}","milestones_url":"https://api.github.com/repos/nunit/nunit-vs-adapter/milestones{/number}","notifications_url":"https://api.github.com/repos/nunit/nunit-vs-adapter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nunit/nunit-vs-adapter/labels{/name}","releases_url":"https://api.github.com/repos/nunit/nunit-vs-adapter/releases{/id}","created_at":"2013-10-07T02:09:46Z","updated_at":"2014-06-15T21:49:16Z","pushed_at":"2014-06-15T21:49:15Z","git_url":"git://github.com/nunit/nunit-vs-adapter.git","ssh_url":"git@github.com:nunit/nunit-vs-adapter.git","clone_url":"https://github.com/nunit/nunit-vs-adapter.git","svn_url":"https://github.com/nunit/nunit-vs-adapter","homepage":null,"size":2072,"stargazers_count":15,"watchers_count":15,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":8,"mirror_url":null,"open_issues_count":19,"forks":8,"open_issues":19,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nunit/nunit-vs-adapter/pulls/36"},"html":{"href":"https://github.com/nunit/nunit-vs-adapter/pull/36"},"issue":{"href":"https://api.github.com/repos/nunit/nunit-vs-adapter/issues/36"},"comments":{"href":"https://api.github.com/repos/nunit/nunit-vs-adapter/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/nunit/nunit-vs-adapter/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/nunit/nunit-vs-adapter/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/nunit/nunit-vs-adapter/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/nunit/nunit-vs-adapter/statuses/2c7ca929ca90b37f55175d32c9209004ef87dcba"}}}}