GitHub PullRequestReviewCommentEvent at 2014-07-04 13:07:08
Repository: yast-services-manager
Actor: kobliha
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/yast/yast-services-manager/pulls/comments/14558944","id":14558944,"diff_hunk":"@@ -16,6 +16,17 @@ module Target\n       include ServicesManagerTargetClass::BaseTargets\n \n       SUPPORTED = [ GRAPHICAL, MULTIUSER ]\n+\n+      TRANSLATIONS = {\n+        # Default target option #1\n+        GRAPHICAL => _(\"Graphical\"),","path":"src/clients/default_target_proposal.rb","position":7,"original_position":7,"commit_id":"3cfc81263e22613c5b21b36f832e58d426f409ca","original_commit_id":"3cfc81263e22613c5b21b36f832e58d426f409ca","user":{"login":"kobliha","id":463995,"avatar_url":"https://avatars.githubusercontent.com/u/463995?","gravatar_id":"a12d10a88ba9289623fd78f307083655","url":"https://api.github.com/users/kobliha","html_url":"https://github.com/kobliha","followers_url":"https://api.github.com/users/kobliha/followers","following_url":"https://api.github.com/users/kobliha/following{/other_user}","gists_url":"https://api.github.com/users/kobliha/gists{/gist_id}","starred_url":"https://api.github.com/users/kobliha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kobliha/subscriptions","organizations_url":"https://api.github.com/users/kobliha/orgs","repos_url":"https://api.github.com/users/kobliha/repos","events_url":"https://api.github.com/users/kobliha/events{/privacy}","received_events_url":"https://api.github.com/users/kobliha/received_events","type":"User","site_admin":false},"body":"In fact `_(TRANSLATIONS[target_name])` will be enough","created_at":"2014-07-04T13:07:08Z","updated_at":"2014-07-04T13:07:08Z","html_url":"https://github.com/yast/yast-services-manager/pull/73#discussion_r14558944","pull_request_url":"https://api.github.com/repos/yast/yast-services-manager/pulls/73","_links":{"self":{"href":"https://api.github.com/repos/yast/yast-services-manager/pulls/comments/14558944"},"html":{"href":"https://github.com/yast/yast-services-manager/pull/73#discussion_r14558944"},"pull_request":{"href":"https://api.github.com/repos/yast/yast-services-manager/pulls/73"}}},"pull_request":{"url":"https://api.github.com/repos/yast/yast-services-manager/pulls/73","id":17993280,"html_url":"https://github.com/yast/yast-services-manager/pull/73","diff_url":"https://github.com/yast/yast-services-manager/pull/73.diff","patch_url":"https://github.com/yast/yast-services-manager/pull/73.patch","issue_url":"https://api.github.com/repos/yast/yast-services-manager/issues/73","number":73,"state":"open","title":"Default systemd target names marked for translation","user":{"login":"kobliha","id":463995,"avatar_url":"https://avatars.githubusercontent.com/u/463995?","gravatar_id":"a12d10a88ba9289623fd78f307083655","url":"https://api.github.com/users/kobliha","html_url":"https://github.com/kobliha","followers_url":"https://api.github.com/users/kobliha/followers","following_url":"https://api.github.com/users/kobliha/following{/other_user}","gists_url":"https://api.github.com/users/kobliha/gists{/gist_id}","starred_url":"https://api.github.com/users/kobliha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kobliha/subscriptions","organizations_url":"https://api.github.com/users/kobliha/orgs","repos_url":"https://api.github.com/users/kobliha/repos","events_url":"https://api.github.com/users/kobliha/events{/privacy}","received_events_url":"https://api.github.com/users/kobliha/received_events","type":"User","site_admin":false},"body":"- bnc#884339\r\n- build passes\r\n","created_at":"2014-07-04T12:52:05Z","updated_at":"2014-07-04T13:07:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c9d1b5db774d8eb46c2edcd69a43b92593862ad4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/yast/yast-services-manager/pulls/73/commits","review_comments_url":"https://api.github.com/repos/yast/yast-services-manager/pulls/73/comments","review_comment_url":"https://api.github.com/repos/yast/yast-services-manager/pulls/comments/{number}","comments_url":"https://api.github.com/repos/yast/yast-services-manager/issues/73/comments","statuses_url":"https://api.github.com/repos/yast/yast-services-manager/statuses/3cfc81263e22613c5b21b36f832e58d426f409ca","head":{"label":"kobliha:master","ref":"master","sha":"3cfc81263e22613c5b21b36f832e58d426f409ca","user":{"login":"kobliha","id":463995,"avatar_url":"https://avatars.githubusercontent.com/u/463995?","gravatar_id":"a12d10a88ba9289623fd78f307083655","url":"https://api.github.com/users/kobliha","html_url":"https://github.com/kobliha","followers_url":"https://api.github.com/users/kobliha/followers","following_url":"https://api.github.com/users/kobliha/following{/other_user}","gists_url":"https://api.github.com/users/kobliha/gists{/gist_id}","starred_url":"https://api.github.com/users/kobliha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kobliha/subscriptions","organizations_url":"https://api.github.com/users/kobliha/orgs","repos_url":"https://api.github.com/users/kobliha/repos","events_url":"https://api.github.com/users/kobliha/events{/privacy}","received_events_url":"https://api.github.com/users/kobliha/received_events","type":"User","site_admin":false},"repo":{"id":15709216,"name":"yast-services-manager","full_name":"kobliha/yast-services-manager","owner":{"login":"kobliha","id":463995,"avatar_url":"https://avatars.githubusercontent.com/u/463995?","gravatar_id":"a12d10a88ba9289623fd78f307083655","url":"https://api.github.com/users/kobliha","html_url":"https://github.com/kobliha","followers_url":"https://api.github.com/users/kobliha/followers","following_url":"https://api.github.com/users/kobliha/following{/other_user}","gists_url":"https://api.github.com/users/kobliha/gists{/gist_id}","starred_url":"https://api.github.com/users/kobliha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kobliha/subscriptions","organizations_url":"https://api.github.com/users/kobliha/orgs","repos_url":"https://api.github.com/users/kobliha/repos","events_url":"https://api.github.com/users/kobliha/events{/privacy}","received_events_url":"https://api.github.com/users/kobliha/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kobliha/yast-services-manager","description":"","fork":true,"url":"https://api.github.com/repos/kobliha/yast-services-manager","forks_url":"https://api.github.com/repos/kobliha/yast-services-manager/forks","keys_url":"https://api.github.com/repos/kobliha/yast-services-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kobliha/yast-services-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kobliha/yast-services-manager/teams","hooks_url":"https://api.github.com/repos/kobliha/yast-services-manager/hooks","issue_events_url":"https://api.github.com/repos/kobliha/yast-services-manager/issues/events{/number}","events_url":"https://api.github.com/repos/kobliha/yast-services-manager/events","assignees_url":"https://api.github.com/repos/kobliha/yast-services-manager/assignees{/user}","branches_url":"https://api.github.com/repos/kobliha/yast-services-manager/branches{/branch}","tags_url":"https://api.github.com/repos/kobliha/yast-services-manager/tags","blobs_url":"https://api.github.com/repos/kobliha/yast-services-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kobliha/yast-services-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kobliha/yast-services-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/kobliha/yast-services-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kobliha/yast-services-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/kobliha/yast-services-manager/languages","stargazers_url":"https://api.github.com/repos/kobliha/yast-services-manager/stargazers","contributors_url":"https://api.github.com/repos/kobliha/yast-services-manager/contributors","subscribers_url":"https://api.github.com/repos/kobliha/yast-services-manager/subscribers","subscription_url":"https://api.github.com/repos/kobliha/yast-services-manager/subscription","commits_url":"https://api.github.com/repos/kobliha/yast-services-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/kobliha/yast-services-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/kobliha/yast-services-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/kobliha/yast-services-manager/issues/comments/{number}","contents_url":"https://api.github.com/repos/kobliha/yast-services-manager/contents/{+path}","compare_url":"https://api.github.com/repos/kobliha/yast-services-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kobliha/yast-services-manager/merges","archive_url":"https://api.github.com/repos/kobliha/yast-services-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kobliha/yast-services-manager/downloads","issues_url":"https://api.github.com/repos/kobliha/yast-services-manager/issues{/number}","pulls_url":"https://api.github.com/repos/kobliha/yast-services-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/kobliha/yast-services-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/kobliha/yast-services-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kobliha/yast-services-manager/labels{/name}","releases_url":"https://api.github.com/repos/kobliha/yast-services-manager/releases{/id}","created_at":"2014-01-07T16:05:43Z","updated_at":"2014-07-03T14:04:50Z","pushed_at":"2014-07-04T12:50:43Z","git_url":"git://github.com/kobliha/yast-services-manager.git","ssh_url":"git@github.com:kobliha/yast-services-manager.git","clone_url":"https://github.com/kobliha/yast-services-manager.git","svn_url":"https://github.com/kobliha/yast-services-manager","homepage":null,"size":504,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yast:master","ref":"master","sha":"7467940a00a64cb868c01a6a1d685b2124b19ed7","user":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?","gravatar_id":"e467a14202136d0b384e7b8ce386d6d5","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"repo":{"id":10642759,"name":"yast-services-manager","full_name":"yast/yast-services-manager","owner":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?","gravatar_id":"e467a14202136d0b384e7b8ce386d6d5","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yast/yast-services-manager","description":"","fork":false,"url":"https://api.github.com/repos/yast/yast-services-manager","forks_url":"https://api.github.com/repos/yast/yast-services-manager/forks","keys_url":"https://api.github.com/repos/yast/yast-services-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yast/yast-services-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yast/yast-services-manager/teams","hooks_url":"https://api.github.com/repos/yast/yast-services-manager/hooks","issue_events_url":"https://api.github.com/repos/yast/yast-services-manager/issues/events{/number}","events_url":"https://api.github.com/repos/yast/yast-services-manager/events","assignees_url":"https://api.github.com/repos/yast/yast-services-manager/assignees{/user}","branches_url":"https://api.github.com/repos/yast/yast-services-manager/branches{/branch}","tags_url":"https://api.github.com/repos/yast/yast-services-manager/tags","blobs_url":"https://api.github.com/repos/yast/yast-services-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yast/yast-services-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yast/yast-services-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/yast/yast-services-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yast/yast-services-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/yast/yast-services-manager/languages","stargazers_url":"https://api.github.com/repos/yast/yast-services-manager/stargazers","contributors_url":"https://api.github.com/repos/yast/yast-services-manager/contributors","subscribers_url":"https://api.github.com/repos/yast/yast-services-manager/subscribers","subscription_url":"https://api.github.com/repos/yast/yast-services-manager/subscription","commits_url":"https://api.github.com/repos/yast/yast-services-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/yast/yast-services-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/yast/yast-services-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/yast/yast-services-manager/issues/comments/{number}","contents_url":"https://api.github.com/repos/yast/yast-services-manager/contents/{+path}","compare_url":"https://api.github.com/repos/yast/yast-services-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yast/yast-services-manager/merges","archive_url":"https://api.github.com/repos/yast/yast-services-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yast/yast-services-manager/downloads","issues_url":"https://api.github.com/repos/yast/yast-services-manager/issues{/number}","pulls_url":"https://api.github.com/repos/yast/yast-services-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/yast/yast-services-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/yast/yast-services-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yast/yast-services-manager/labels{/name}","releases_url":"https://api.github.com/repos/yast/yast-services-manager/releases{/id}","created_at":"2013-06-12T12:53:21Z","updated_at":"2014-07-01T11:25:43Z","pushed_at":"2014-07-04T07:16:15Z","git_url":"git://github.com/yast/yast-services-manager.git","ssh_url":"git@github.com:yast/yast-services-manager.git","clone_url":"https://github.com/yast/yast-services-manager.git","svn_url":"https://github.com/yast/yast-services-manager","homepage":null,"size":1305,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":4,"mirror_url":null,"open_issues_count":3,"forks":4,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yast/yast-services-manager/pulls/73"},"html":{"href":"https://github.com/yast/yast-services-manager/pull/73"},"issue":{"href":"https://api.github.com/repos/yast/yast-services-manager/issues/73"},"comments":{"href":"https://api.github.com/repos/yast/yast-services-manager/issues/73/comments"},"review_comments":{"href":"https://api.github.com/repos/yast/yast-services-manager/pulls/73/comments"},"review_comment":{"href":"https://api.github.com/repos/yast/yast-services-manager/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/yast/yast-services-manager/pulls/73/commits"},"statuses":{"href":"https://api.github.com/repos/yast/yast-services-manager/statuses/3cfc81263e22613c5b21b36f832e58d426f409ca"}}}}