GitHub PullRequestEvent at 2014-10-31 16:42:33
Repository: manageiq
Actor: Fryguy
Payload: {"action":"closed","number":185,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/185","id":18224839,"html_url":"https://github.com/ManageIQ/manageiq/pull/185","diff_url":"https://github.com/ManageIQ/manageiq/pull/185.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/185.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/185","number":185,"state":"closed","locked":false,"title":"Upgrade to Ruby 2.0","user":{"login":"jrafanie","id":19339,"avatar_url":"https://avatars.githubusercontent.com/u/19339?v=2","gravatar_id":"","url":"https://api.github.com/users/jrafanie","html_url":"https://github.com/jrafanie","followers_url":"https://api.github.com/users/jrafanie/followers","following_url":"https://api.github.com/users/jrafanie/following{/other_user}","gists_url":"https://api.github.com/users/jrafanie/gists{/gist_id}","starred_url":"https://api.github.com/users/jrafanie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrafanie/subscriptions","organizations_url":"https://api.github.com/users/jrafanie/orgs","repos_url":"https://api.github.com/users/jrafanie/repos","events_url":"https://api.github.com/users/jrafanie/events{/privacy}","received_events_url":"https://api.github.com/users/jrafanie/received_events","type":"User","site_admin":false},"body":"MERGE AFTER #933\r\n\r\nWe're now ready to merge this and run travis against ruby 2.0 and 1.9.3.\r\n\r\nLinks to related issues:\r\n\r\nUTF-8 default encoding of ruby scripts:\r\n#218 \r\n#465 \r\n#589\r\n#715 \r\n#732\r\n#804 \r\n\r\nProtected methods don't respond_to?\r\n#685 \r\n\r\nFile descriptors are closed on exec (when spawning a new process)\r\n#459 \r\n#682\r\n\r\nOthers:\r\n#233 \r\n#581 \r\n\r\nPatches/extensions:\r\n#535 \r\n#536 \r\n#714 \r\n#728 \r\n#826 \r\n\r\nThere are remaining open ruby 2 issues unrelated to getting ruby 2.0 on travis:\r\nhttps://github.com/ManageIQ/manageiq/labels/ruby%202\r\n\r\n**EDIT**\r\nAdded screenshot showing travis build matrix with ruby 2.1 allowing the vmdb suite to fail (and thereby finish fast)... Thanks @Fryguy for getting the .travis.yml to work.\r\n![screen shot 2014-10-21 at 6 54 55 pm](https://cloud.githubusercontent.com/assets/19339/4728387/4ea60d8a-5975-11e4-885f-3561f9e5c555.png)\r\n\r\n\r\n","created_at":"2014-07-10T15:04:44Z","updated_at":"2014-10-31T16:42:32Z","closed_at":"2014-10-31T16:42:30Z","merged_at":"2014-10-31T16:42:30Z","merge_commit_sha":"62756b92637b7f81ca6a4758c1463fe352c1fd77","assignee":{"login":"jrafanie","id":19339,"avatar_url":"https://avatars.githubusercontent.com/u/19339?v=2","gravatar_id":"","url":"https://api.github.com/users/jrafanie","html_url":"https://github.com/jrafanie","followers_url":"https://api.github.com/users/jrafanie/followers","following_url":"https://api.github.com/users/jrafanie/following{/other_user}","gists_url":"https://api.github.com/users/jrafanie/gists{/gist_id}","starred_url":"https://api.github.com/users/jrafanie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrafanie/subscriptions","organizations_url":"https://api.github.com/users/jrafanie/orgs","repos_url":"https://api.github.com/users/jrafanie/repos","events_url":"https://api.github.com/users/jrafanie/events{/privacy}","received_events_url":"https://api.github.com/users/jrafanie/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/ManageIQ/manageiq/milestones/7","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones/7/labels","id":782701,"number":7,"title":"Roadmap","description":"## General Code Improvements\r\n\r\n* Improve Test Coverage\r\n* Improve Test Performance\r\n* Improve Code via CodeClimate\r\n  * Deduplication\r\n\r\n## Code Extraction\r\n\r\n* All the directories in the high-level lib directory should be extracted to ruby gems\r\n* When REST API is mature and capable enough\r\n  * Automation Engine should be extracted into separate Rails Engine project\r\n  * UI (most controllers and views) should be extracted into separate Rails Engine project\r\n\r\n## Refactor\r\n\r\n* Job should belong_to Task and UI should ONLY show Task Progress\r\n* VmOrTemplate and Host should be changed to has_one ComputerSystem\r\n  * common attributes should be extracted from Host and VmOrTemplate models\r\n  * should be fleece-able\r\n  * should be report-able\r\n  * should support policy enforcement on  \r\n\r\n## Logging\r\n\r\n* Log messages should be categorized and numbered\r\n* Log levels should be settable by category (eg database, communication, vmware, events)\r\n\r\n## Cloud Providers\r\n\r\n* OpenStack\r\n  * support Heat\r\n  * Events via Ceilometer\r\n* Amazon AWS\r\n  * support CloudFormations\r\n* Microsoft Azure\r\n  * no support yet\r\n\r\n## Virtual Infrastructure Providers\r\n\r\n* VMware\r\n* oVirt / RHEV\r\n* Microsoft SCVMM\r\n\r\n## Storage Providers\r\n\r\n* NetApp\r\n  * should be reviewed / re-tested\r\n* Gluster\r\n* Hitachi\r\n* EMC\r\n\r\n## General Features\r\n\r\n* Zone-based Memcache Daemon\r\n* MiqQueue should transition to industry standard message bus\r\n* Use Ruby 2.x (currently using Ruby 1.9.3)\r\n* Use Rails 4.x (currently using Rails 3.2)\r\n* Use PostgreSQL Clustering for SQL High Availability and Failover\r\n* Configuration Settings should be specified and enforced at Region/Zone/Appliance/Worker levels (currently at the Appliance Level only)\r\n* Database Introspection\r\n  * should be reviewed / re-tested\r\n* System should be introspective\r\n  * should monitor activity\r\n  * should make recommendations\r\n    * add/remove appliance\r\n    * add/remove worker\r\n    * add/remove role\r\n  * should present information in GUI\r\n  * should present information in log periodically\r\n","creator":{"login":"Fryguy","id":52120,"avatar_url":"https://avatars.githubusercontent.com/u/52120?v=2","gravatar_id":"","url":"https://api.github.com/users/Fryguy","html_url":"https://github.com/Fryguy","followers_url":"https://api.github.com/users/Fryguy/followers","following_url":"https://api.github.com/users/Fryguy/following{/other_user}","gists_url":"https://api.github.com/users/Fryguy/gists{/gist_id}","starred_url":"https://api.github.com/users/Fryguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fryguy/subscriptions","organizations_url":"https://api.github.com/users/Fryguy/orgs","repos_url":"https://api.github.com/users/Fryguy/repos","events_url":"https://api.github.com/users/Fryguy/events{/privacy}","received_events_url":"https://api.github.com/users/Fryguy/received_events","type":"User","site_admin":false},"open_issues":37,"closed_issues":1,"state":"open","created_at":"2014-09-08T20:09:33Z","updated_at":"2014-10-31T16:42:30Z","due_on":null},"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/185/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/185/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/185/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/a648a66fbbcee4153f5331718bfff65f97308b01","head":{"label":"jrafanie:ruby_2_x_support","ref":"ruby_2_x_support","sha":"a648a66fbbcee4153f5331718bfff65f97308b01","user":{"login":"jrafanie","id":19339,"avatar_url":"https://avatars.githubusercontent.com/u/19339?v=2","gravatar_id":"","url":"https://api.github.com/users/jrafanie","html_url":"https://github.com/jrafanie","followers_url":"https://api.github.com/users/jrafanie/followers","following_url":"https://api.github.com/users/jrafanie/following{/other_user}","gists_url":"https://api.github.com/users/jrafanie/gists{/gist_id}","starred_url":"https://api.github.com/users/jrafanie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrafanie/subscriptions","organizations_url":"https://api.github.com/users/jrafanie/orgs","repos_url":"https://api.github.com/users/jrafanie/repos","events_url":"https://api.github.com/users/jrafanie/events{/privacy}","received_events_url":"https://api.github.com/users/jrafanie/received_events","type":"User","site_admin":false},"repo":{"id":20803842,"name":"manageiq","full_name":"jrafanie/manageiq","owner":{"login":"jrafanie","id":19339,"avatar_url":"https://avatars.githubusercontent.com/u/19339?v=2","gravatar_id":"","url":"https://api.github.com/users/jrafanie","html_url":"https://github.com/jrafanie","followers_url":"https://api.github.com/users/jrafanie/followers","following_url":"https://api.github.com/users/jrafanie/following{/other_user}","gists_url":"https://api.github.com/users/jrafanie/gists{/gist_id}","starred_url":"https://api.github.com/users/jrafanie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrafanie/subscriptions","organizations_url":"https://api.github.com/users/jrafanie/orgs","repos_url":"https://api.github.com/users/jrafanie/repos","events_url":"https://api.github.com/users/jrafanie/events{/privacy}","received_events_url":"https://api.github.com/users/jrafanie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jrafanie/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/jrafanie/manageiq","forks_url":"https://api.github.com/repos/jrafanie/manageiq/forks","keys_url":"https://api.github.com/repos/jrafanie/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jrafanie/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jrafanie/manageiq/teams","hooks_url":"https://api.github.com/repos/jrafanie/manageiq/hooks","issue_events_url":"https://api.github.com/repos/jrafanie/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/jrafanie/manageiq/events","assignees_url":"https://api.github.com/repos/jrafanie/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/jrafanie/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/jrafanie/manageiq/tags","blobs_url":"https://api.github.com/repos/jrafanie/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jrafanie/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jrafanie/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/jrafanie/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jrafanie/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/jrafanie/manageiq/languages","stargazers_url":"https://api.github.com/repos/jrafanie/manageiq/stargazers","contributors_url":"https://api.github.com/repos/jrafanie/manageiq/contributors","subscribers_url":"https://api.github.com/repos/jrafanie/manageiq/subscribers","subscription_url":"https://api.github.com/repos/jrafanie/manageiq/subscription","commits_url":"https://api.github.com/repos/jrafanie/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/jrafanie/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/jrafanie/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/jrafanie/manageiq/issues/comments/{number}","contents_url":"https://api.github.com/repos/jrafanie/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/jrafanie/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jrafanie/manageiq/merges","archive_url":"https://api.github.com/repos/jrafanie/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jrafanie/manageiq/downloads","issues_url":"https://api.github.com/repos/jrafanie/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/jrafanie/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/jrafanie/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/jrafanie/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jrafanie/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/jrafanie/manageiq/releases{/id}","created_at":"2014-06-13T12:47:01Z","updated_at":"2014-10-09T20:20:24Z","pushed_at":"2014-10-31T16:42:32Z","git_url":"git://github.com/jrafanie/manageiq.git","ssh_url":"git@github.com:jrafanie/manageiq.git","clone_url":"https://github.com/jrafanie/manageiq.git","svn_url":"https://github.com/jrafanie/manageiq","homepage":null,"size":59743,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"b30a3ca0b97316247146c7d9e35ba6aa8b56fa31","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=2","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=2","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Cloud Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/{number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","created_at":"2014-06-13T02:31:26Z","updated_at":"2014-10-29T13:48:27Z","pushed_at":"2014-10-31T16:42:31Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":86980,"stargazers_count":63,"watchers_count":63,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":68,"mirror_url":null,"open_issues_count":157,"forks":68,"open_issues":157,"watchers":63,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/185"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/185"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/185"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/185/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/185/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/185/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/a648a66fbbcee4153f5331718bfff65f97308b01"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"Fryguy","id":52120,"avatar_url":"https://avatars.githubusercontent.com/u/52120?v=2","gravatar_id":"","url":"https://api.github.com/users/Fryguy","html_url":"https://github.com/Fryguy","followers_url":"https://api.github.com/users/Fryguy/followers","following_url":"https://api.github.com/users/Fryguy/following{/other_user}","gists_url":"https://api.github.com/users/Fryguy/gists{/gist_id}","starred_url":"https://api.github.com/users/Fryguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fryguy/subscriptions","organizations_url":"https://api.github.com/users/Fryguy/orgs","repos_url":"https://api.github.com/users/Fryguy/repos","events_url":"https://api.github.com/users/Fryguy/events{/privacy}","received_events_url":"https://api.github.com/users/Fryguy/received_events","type":"User","site_admin":false},"comments":25,"review_comments":2,"commits":1,"additions":14,"deletions":7,"changed_files":1}}