GitHub PullRequestReviewCommentEvent at 2014-12-13 06:49:45
Repository: kalabox
Actor: pirog
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/kalabox/kalabox/pulls/comments/21786479","id":21786479,"diff_hunk":"@@ -26,23 +25,20 @@ var b2d = require('../lib/b2d.js');\n var kenv = require('../lib/kEnv.js');\n \n // Set env\n-var setDockerHost = function(conf) {\n+var setDockerHost = function() {\n   // @todo: it would be great to get this to run RIGHT BEFORE a dockerode call\n   // because that would likely mean the VM is on and we can do a B2D ip check.\n   // We'd also be able to do this only once and in a place that\n-  // makes more sense\n-  b2d.state(3, function(status) {\n-    if (status === 'running' && argv._[0] !== 'down') {\n-      b2d.ip(3, function(err, ip) {\n-        if (err) {\n-          throw err;\n-        } else {\n-          var dockerHost = 'tcp://' + ip + ':2375';\n-          kenv.setDockerHost(dockerHost);\n-        }\n-      });\n-    }\n-  });\n+  // makes more sense.\n+  //\n+  // Originally we were going to do a b2d.ip here but that only works if b2d is\n+  // installed first.\n+  var PLATFORM_LINUX = 'linux';","path":"bin/kbox.js","position":34,"original_position":34,"commit_id":"99704e3b1d42d9e28eb0c1bd7bd0f6f3b1385c56","original_commit_id":"99704e3b1d42d9e28eb0c1bd7bd0f6f3b1385c56","user":{"login":"pirog","id":713424,"avatar_url":"https://avatars.githubusercontent.com/u/713424?v=3","gravatar_id":"","url":"https://api.github.com/users/pirog","html_url":"https://github.com/pirog","followers_url":"https://api.github.com/users/pirog/followers","following_url":"https://api.github.com/users/pirog/following{/other_user}","gists_url":"https://api.github.com/users/pirog/gists{/gist_id}","starred_url":"https://api.github.com/users/pirog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pirog/subscriptions","organizations_url":"https://api.github.com/users/pirog/orgs","repos_url":"https://api.github.com/users/pirog/repos","events_url":"https://api.github.com/users/pirog/events{/privacy}","received_events_url":"https://api.github.com/users/pirog/received_events","type":"User","site_admin":false},"body":"this fails if you dont have b2d installed so stubbing out until we have a better way to handle setting `DOCKER_HOST`","created_at":"2014-12-13T06:49:45Z","updated_at":"2014-12-13T06:49:45Z","html_url":"https://github.com/kalabox/kalabox/pull/47#discussion_r21786479","pull_request_url":"https://api.github.com/repos/kalabox/kalabox/pulls/47","_links":{"self":{"href":"https://api.github.com/repos/kalabox/kalabox/pulls/comments/21786479"},"html":{"href":"https://github.com/kalabox/kalabox/pull/47#discussion_r21786479"},"pull_request":{"href":"https://api.github.com/repos/kalabox/kalabox/pulls/47"}}},"pull_request":{"url":"https://api.github.com/repos/kalabox/kalabox/pulls/47","id":26018161,"html_url":"https://github.com/kalabox/kalabox/pull/47","diff_url":"https://github.com/kalabox/kalabox/pull/47.diff","patch_url":"https://github.com/kalabox/kalabox/pull/47.patch","issue_url":"https://api.github.com/repos/kalabox/kalabox/issues/47","number":47,"state":"open","locked":false,"title":"110 b2dprof install","user":{"login":"pirog","id":713424,"avatar_url":"https://avatars.githubusercontent.com/u/713424?v=3","gravatar_id":"","url":"https://api.github.com/users/pirog","html_url":"https://github.com/pirog","followers_url":"https://api.github.com/users/pirog/followers","following_url":"https://api.github.com/users/pirog/following{/other_user}","gists_url":"https://api.github.com/users/pirog/gists{/gist_id}","starred_url":"https://api.github.com/users/pirog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pirog/subscriptions","organizations_url":"https://api.github.com/users/pirog/orgs","repos_url":"https://api.github.com/users/pirog/repos","events_url":"https://api.github.com/users/pirog/events{/privacy}","received_events_url":"https://api.github.com/users/pirog/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-12-13T06:48:15Z","updated_at":"2014-12-13T06:49:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"83d93ad668485e70609b48115deb1256d41d2ba7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kalabox/kalabox/pulls/47/commits","review_comments_url":"https://api.github.com/repos/kalabox/kalabox/pulls/47/comments","review_comment_url":"https://api.github.com/repos/kalabox/kalabox/pulls/comments/{number}","comments_url":"https://api.github.com/repos/kalabox/kalabox/issues/47/comments","statuses_url":"https://api.github.com/repos/kalabox/kalabox/statuses/99704e3b1d42d9e28eb0c1bd7bd0f6f3b1385c56","head":{"label":"kalabox:110-b2dprof-install","ref":"110-b2dprof-install","sha":"99704e3b1d42d9e28eb0c1bd7bd0f6f3b1385c56","user":{"login":"kalabox","id":8390749,"avatar_url":"https://avatars.githubusercontent.com/u/8390749?v=3","gravatar_id":"","url":"https://api.github.com/users/kalabox","html_url":"https://github.com/kalabox","followers_url":"https://api.github.com/users/kalabox/followers","following_url":"https://api.github.com/users/kalabox/following{/other_user}","gists_url":"https://api.github.com/users/kalabox/gists{/gist_id}","starred_url":"https://api.github.com/users/kalabox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalabox/subscriptions","organizations_url":"https://api.github.com/users/kalabox/orgs","repos_url":"https://api.github.com/users/kalabox/repos","events_url":"https://api.github.com/users/kalabox/events{/privacy}","received_events_url":"https://api.github.com/users/kalabox/received_events","type":"Organization","site_admin":false},"repo":{"id":25185119,"name":"kalabox","full_name":"kalabox/kalabox","owner":{"login":"kalabox","id":8390749,"avatar_url":"https://avatars.githubusercontent.com/u/8390749?v=3","gravatar_id":"","url":"https://api.github.com/users/kalabox","html_url":"https://github.com/kalabox","followers_url":"https://api.github.com/users/kalabox/followers","following_url":"https://api.github.com/users/kalabox/following{/other_user}","gists_url":"https://api.github.com/users/kalabox/gists{/gist_id}","starred_url":"https://api.github.com/users/kalabox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalabox/subscriptions","organizations_url":"https://api.github.com/users/kalabox/orgs","repos_url":"https://api.github.com/users/kalabox/repos","events_url":"https://api.github.com/users/kalabox/events{/privacy}","received_events_url":"https://api.github.com/users/kalabox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kalabox/kalabox","description":"All the goodness.","fork":false,"url":"https://api.github.com/repos/kalabox/kalabox","forks_url":"https://api.github.com/repos/kalabox/kalabox/forks","keys_url":"https://api.github.com/repos/kalabox/kalabox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kalabox/kalabox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kalabox/kalabox/teams","hooks_url":"https://api.github.com/repos/kalabox/kalabox/hooks","issue_events_url":"https://api.github.com/repos/kalabox/kalabox/issues/events{/number}","events_url":"https://api.github.com/repos/kalabox/kalabox/events","assignees_url":"https://api.github.com/repos/kalabox/kalabox/assignees{/user}","branches_url":"https://api.github.com/repos/kalabox/kalabox/branches{/branch}","tags_url":"https://api.github.com/repos/kalabox/kalabox/tags","blobs_url":"https://api.github.com/repos/kalabox/kalabox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kalabox/kalabox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kalabox/kalabox/git/refs{/sha}","trees_url":"https://api.github.com/repos/kalabox/kalabox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kalabox/kalabox/statuses/{sha}","languages_url":"https://api.github.com/repos/kalabox/kalabox/languages","stargazers_url":"https://api.github.com/repos/kalabox/kalabox/stargazers","contributors_url":"https://api.github.com/repos/kalabox/kalabox/contributors","subscribers_url":"https://api.github.com/repos/kalabox/kalabox/subscribers","subscription_url":"https://api.github.com/repos/kalabox/kalabox/subscription","commits_url":"https://api.github.com/repos/kalabox/kalabox/commits{/sha}","git_commits_url":"https://api.github.com/repos/kalabox/kalabox/git/commits{/sha}","comments_url":"https://api.github.com/repos/kalabox/kalabox/comments{/number}","issue_comment_url":"https://api.github.com/repos/kalabox/kalabox/issues/comments/{number}","contents_url":"https://api.github.com/repos/kalabox/kalabox/contents/{+path}","compare_url":"https://api.github.com/repos/kalabox/kalabox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kalabox/kalabox/merges","archive_url":"https://api.github.com/repos/kalabox/kalabox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kalabox/kalabox/downloads","issues_url":"https://api.github.com/repos/kalabox/kalabox/issues{/number}","pulls_url":"https://api.github.com/repos/kalabox/kalabox/pulls{/number}","milestones_url":"https://api.github.com/repos/kalabox/kalabox/milestones{/number}","notifications_url":"https://api.github.com/repos/kalabox/kalabox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kalabox/kalabox/labels{/name}","releases_url":"https://api.github.com/repos/kalabox/kalabox/releases{/id}","created_at":"2014-10-14T01:25:05Z","updated_at":"2014-12-13T03:15:10Z","pushed_at":"2014-12-13T06:48:00Z","git_url":"git://github.com/kalabox/kalabox.git","ssh_url":"git@github.com:kalabox/kalabox.git","clone_url":"https://github.com/kalabox/kalabox.git","svn_url":"https://github.com/kalabox/kalabox","homepage":"","size":1975,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":2,"forks":5,"open_issues":2,"watchers":8,"default_branch":"master"}},"base":{"label":"kalabox:master","ref":"master","sha":"220ba246e0205da74fef0f067dceb38eed1d004b","user":{"login":"kalabox","id":8390749,"avatar_url":"https://avatars.githubusercontent.com/u/8390749?v=3","gravatar_id":"","url":"https://api.github.com/users/kalabox","html_url":"https://github.com/kalabox","followers_url":"https://api.github.com/users/kalabox/followers","following_url":"https://api.github.com/users/kalabox/following{/other_user}","gists_url":"https://api.github.com/users/kalabox/gists{/gist_id}","starred_url":"https://api.github.com/users/kalabox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalabox/subscriptions","organizations_url":"https://api.github.com/users/kalabox/orgs","repos_url":"https://api.github.com/users/kalabox/repos","events_url":"https://api.github.com/users/kalabox/events{/privacy}","received_events_url":"https://api.github.com/users/kalabox/received_events","type":"Organization","site_admin":false},"repo":{"id":25185119,"name":"kalabox","full_name":"kalabox/kalabox","owner":{"login":"kalabox","id":8390749,"avatar_url":"https://avatars.githubusercontent.com/u/8390749?v=3","gravatar_id":"","url":"https://api.github.com/users/kalabox","html_url":"https://github.com/kalabox","followers_url":"https://api.github.com/users/kalabox/followers","following_url":"https://api.github.com/users/kalabox/following{/other_user}","gists_url":"https://api.github.com/users/kalabox/gists{/gist_id}","starred_url":"https://api.github.com/users/kalabox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalabox/subscriptions","organizations_url":"https://api.github.com/users/kalabox/orgs","repos_url":"https://api.github.com/users/kalabox/repos","events_url":"https://api.github.com/users/kalabox/events{/privacy}","received_events_url":"https://api.github.com/users/kalabox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kalabox/kalabox","description":"All the goodness.","fork":false,"url":"https://api.github.com/repos/kalabox/kalabox","forks_url":"https://api.github.com/repos/kalabox/kalabox/forks","keys_url":"https://api.github.com/repos/kalabox/kalabox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kalabox/kalabox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kalabox/kalabox/teams","hooks_url":"https://api.github.com/repos/kalabox/kalabox/hooks","issue_events_url":"https://api.github.com/repos/kalabox/kalabox/issues/events{/number}","events_url":"https://api.github.com/repos/kalabox/kalabox/events","assignees_url":"https://api.github.com/repos/kalabox/kalabox/assignees{/user}","branches_url":"https://api.github.com/repos/kalabox/kalabox/branches{/branch}","tags_url":"https://api.github.com/repos/kalabox/kalabox/tags","blobs_url":"https://api.github.com/repos/kalabox/kalabox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kalabox/kalabox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kalabox/kalabox/git/refs{/sha}","trees_url":"https://api.github.com/repos/kalabox/kalabox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kalabox/kalabox/statuses/{sha}","languages_url":"https://api.github.com/repos/kalabox/kalabox/languages","stargazers_url":"https://api.github.com/repos/kalabox/kalabox/stargazers","contributors_url":"https://api.github.com/repos/kalabox/kalabox/contributors","subscribers_url":"https://api.github.com/repos/kalabox/kalabox/subscribers","subscription_url":"https://api.github.com/repos/kalabox/kalabox/subscription","commits_url":"https://api.github.com/repos/kalabox/kalabox/commits{/sha}","git_commits_url":"https://api.github.com/repos/kalabox/kalabox/git/commits{/sha}","comments_url":"https://api.github.com/repos/kalabox/kalabox/comments{/number}","issue_comment_url":"https://api.github.com/repos/kalabox/kalabox/issues/comments/{number}","contents_url":"https://api.github.com/repos/kalabox/kalabox/contents/{+path}","compare_url":"https://api.github.com/repos/kalabox/kalabox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kalabox/kalabox/merges","archive_url":"https://api.github.com/repos/kalabox/kalabox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kalabox/kalabox/downloads","issues_url":"https://api.github.com/repos/kalabox/kalabox/issues{/number}","pulls_url":"https://api.github.com/repos/kalabox/kalabox/pulls{/number}","milestones_url":"https://api.github.com/repos/kalabox/kalabox/milestones{/number}","notifications_url":"https://api.github.com/repos/kalabox/kalabox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kalabox/kalabox/labels{/name}","releases_url":"https://api.github.com/repos/kalabox/kalabox/releases{/id}","created_at":"2014-10-14T01:25:05Z","updated_at":"2014-12-13T03:15:10Z","pushed_at":"2014-12-13T06:48:00Z","git_url":"git://github.com/kalabox/kalabox.git","ssh_url":"git@github.com:kalabox/kalabox.git","clone_url":"https://github.com/kalabox/kalabox.git","svn_url":"https://github.com/kalabox/kalabox","homepage":"","size":1975,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":2,"forks":5,"open_issues":2,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kalabox/kalabox/pulls/47"},"html":{"href":"https://github.com/kalabox/kalabox/pull/47"},"issue":{"href":"https://api.github.com/repos/kalabox/kalabox/issues/47"},"comments":{"href":"https://api.github.com/repos/kalabox/kalabox/issues/47/comments"},"review_comments":{"href":"https://api.github.com/repos/kalabox/kalabox/pulls/47/comments"},"review_comment":{"href":"https://api.github.com/repos/kalabox/kalabox/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/kalabox/kalabox/pulls/47/commits"},"statuses":{"href":"https://api.github.com/repos/kalabox/kalabox/statuses/99704e3b1d42d9e28eb0c1bd7bd0f6f3b1385c56"}}}}