GitHub PullRequestReviewCommentEvent at 2014-11-18 16:34:55
Repository: bootstrap
Actor: dg
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/nette/bootstrap/pulls/comments/20517857","id":20517857,"diff_hunk":"@@ -226,7 +226,13 @@ public function afterCompile(Nette\\PhpGenerator\\ClassType $class)\n \t\t}\n \n \t\tforeach ((array) $config['forms']['messages'] as $name => $text) {\n-\t\t\t$initialize->addBody('Nette\\Forms\\Rules::$defaultMessages[Nette\\Forms\\Form::?] = ?;', array($name, $text));\n+\t\t\tif (defined('Nette\\Forms\\Form::' . $name)) {\n+\t\t\t\t$initialize->addBody('Nette\\Forms\\Validator::$messages[Nette\\Forms\\Form::?] = ?;', array($name, $text));\n+\t\t\t} elseif (defined($name)) {\n+\t\t\t\t$initialize->addBody('Nette\\Forms\\Validator::$messages[' . $name . '] = ?;', array($text));\n+\t\t\t} else {","path":"src/Bridges/Framework/NetteExtension.php","position":9,"original_position":9,"commit_id":"f10e6764088b4875092eb09bda28d360f0b3c18e","original_commit_id":"f10e6764088b4875092eb09bda28d360f0b3c18e","user":{"login":"dg","id":194960,"avatar_url":"https://avatars.githubusercontent.com/u/194960?v=3","gravatar_id":"","url":"https://api.github.com/users/dg","html_url":"https://github.com/dg","followers_url":"https://api.github.com/users/dg/followers","following_url":"https://api.github.com/users/dg/following{/other_user}","gists_url":"https://api.github.com/users/dg/gists{/gist_id}","starred_url":"https://api.github.com/users/dg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dg/subscriptions","organizations_url":"https://api.github.com/users/dg/orgs","repos_url":"https://api.github.com/users/dg/repos","events_url":"https://api.github.com/users/dg/events{/privacy}","received_events_url":"https://api.github.com/users/dg/received_events","type":"User","site_admin":false},"body":"`Nette\\Forms\\Validator::$messages[?] = ?` seems better","created_at":"2014-11-18T16:34:55Z","updated_at":"2014-11-18T16:34:55Z","html_url":"https://github.com/nette/bootstrap/pull/26#discussion_r20517857","pull_request_url":"https://api.github.com/repos/nette/bootstrap/pulls/26","_links":{"self":{"href":"https://api.github.com/repos/nette/bootstrap/pulls/comments/20517857"},"html":{"href":"https://github.com/nette/bootstrap/pull/26#discussion_r20517857"},"pull_request":{"href":"https://api.github.com/repos/nette/bootstrap/pulls/26"}}},"pull_request":{"url":"https://api.github.com/repos/nette/bootstrap/pulls/26","id":24573118,"html_url":"https://github.com/nette/bootstrap/pull/26","diff_url":"https://github.com/nette/bootstrap/pull/26.diff","patch_url":"https://github.com/nette/bootstrap/pull/26.patch","issue_url":"https://api.github.com/repos/nette/bootstrap/issues/26","number":26,"state":"open","locked":false,"title":"Fixed NetteExtension form messages configuration","user":{"login":"castamir","id":1245190,"avatar_url":"https://avatars.githubusercontent.com/u/1245190?v=3","gravatar_id":"","url":"https://api.github.com/users/castamir","html_url":"https://github.com/castamir","followers_url":"https://api.github.com/users/castamir/followers","following_url":"https://api.github.com/users/castamir/following{/other_user}","gists_url":"https://api.github.com/users/castamir/gists{/gist_id}","starred_url":"https://api.github.com/users/castamir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/castamir/subscriptions","organizations_url":"https://api.github.com/users/castamir/orgs","repos_url":"https://api.github.com/users/castamir/repos","events_url":"https://api.github.com/users/castamir/events{/privacy}","received_events_url":"https://api.github.com/users/castamir/received_events","type":"User","site_admin":false},"body":"Fixed selectbox validator message configuration, enables to config custom validator messages","created_at":"2014-11-17T22:32:53Z","updated_at":"2014-11-18T16:34:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"457166e69078477afbfe683fc3679efa8643acca","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nette/bootstrap/pulls/26/commits","review_comments_url":"https://api.github.com/repos/nette/bootstrap/pulls/26/comments","review_comment_url":"https://api.github.com/repos/nette/bootstrap/pulls/comments/{number}","comments_url":"https://api.github.com/repos/nette/bootstrap/issues/26/comments","statuses_url":"https://api.github.com/repos/nette/bootstrap/statuses/f10e6764088b4875092eb09bda28d360f0b3c18e","head":{"label":"castamir:validator-messages","ref":"validator-messages","sha":"f10e6764088b4875092eb09bda28d360f0b3c18e","user":{"login":"castamir","id":1245190,"avatar_url":"https://avatars.githubusercontent.com/u/1245190?v=3","gravatar_id":"","url":"https://api.github.com/users/castamir","html_url":"https://github.com/castamir","followers_url":"https://api.github.com/users/castamir/followers","following_url":"https://api.github.com/users/castamir/following{/other_user}","gists_url":"https://api.github.com/users/castamir/gists{/gist_id}","starred_url":"https://api.github.com/users/castamir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/castamir/subscriptions","organizations_url":"https://api.github.com/users/castamir/orgs","repos_url":"https://api.github.com/users/castamir/repos","events_url":"https://api.github.com/users/castamir/events{/privacy}","received_events_url":"https://api.github.com/users/castamir/received_events","type":"User","site_admin":false},"repo":{"id":26779373,"name":"bootstrap","full_name":"castamir/bootstrap","owner":{"login":"castamir","id":1245190,"avatar_url":"https://avatars.githubusercontent.com/u/1245190?v=3","gravatar_id":"","url":"https://api.github.com/users/castamir","html_url":"https://github.com/castamir","followers_url":"https://api.github.com/users/castamir/followers","following_url":"https://api.github.com/users/castamir/following{/other_user}","gists_url":"https://api.github.com/users/castamir/gists{/gist_id}","starred_url":"https://api.github.com/users/castamir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/castamir/subscriptions","organizations_url":"https://api.github.com/users/castamir/orgs","repos_url":"https://api.github.com/users/castamir/repos","events_url":"https://api.github.com/users/castamir/events{/privacy}","received_events_url":"https://api.github.com/users/castamir/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/castamir/bootstrap","description":"Nette Bootstrap component","fork":true,"url":"https://api.github.com/repos/castamir/bootstrap","forks_url":"https://api.github.com/repos/castamir/bootstrap/forks","keys_url":"https://api.github.com/repos/castamir/bootstrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/castamir/bootstrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/castamir/bootstrap/teams","hooks_url":"https://api.github.com/repos/castamir/bootstrap/hooks","issue_events_url":"https://api.github.com/repos/castamir/bootstrap/issues/events{/number}","events_url":"https://api.github.com/repos/castamir/bootstrap/events","assignees_url":"https://api.github.com/repos/castamir/bootstrap/assignees{/user}","branches_url":"https://api.github.com/repos/castamir/bootstrap/branches{/branch}","tags_url":"https://api.github.com/repos/castamir/bootstrap/tags","blobs_url":"https://api.github.com/repos/castamir/bootstrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/castamir/bootstrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/castamir/bootstrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/castamir/bootstrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/castamir/bootstrap/statuses/{sha}","languages_url":"https://api.github.com/repos/castamir/bootstrap/languages","stargazers_url":"https://api.github.com/repos/castamir/bootstrap/stargazers","contributors_url":"https://api.github.com/repos/castamir/bootstrap/contributors","subscribers_url":"https://api.github.com/repos/castamir/bootstrap/subscribers","subscription_url":"https://api.github.com/repos/castamir/bootstrap/subscription","commits_url":"https://api.github.com/repos/castamir/bootstrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/castamir/bootstrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/castamir/bootstrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/castamir/bootstrap/issues/comments/{number}","contents_url":"https://api.github.com/repos/castamir/bootstrap/contents/{+path}","compare_url":"https://api.github.com/repos/castamir/bootstrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/castamir/bootstrap/merges","archive_url":"https://api.github.com/repos/castamir/bootstrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/castamir/bootstrap/downloads","issues_url":"https://api.github.com/repos/castamir/bootstrap/issues{/number}","pulls_url":"https://api.github.com/repos/castamir/bootstrap/pulls{/number}","milestones_url":"https://api.github.com/repos/castamir/bootstrap/milestones{/number}","notifications_url":"https://api.github.com/repos/castamir/bootstrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/castamir/bootstrap/labels{/name}","releases_url":"https://api.github.com/repos/castamir/bootstrap/releases{/id}","created_at":"2014-11-17T22:00:30Z","updated_at":"2014-11-17T22:00:31Z","pushed_at":"2014-11-18T12:26:13Z","git_url":"git://github.com/castamir/bootstrap.git","ssh_url":"git@github.com:castamir/bootstrap.git","clone_url":"https://github.com/castamir/bootstrap.git","svn_url":"https://github.com/castamir/bootstrap","homepage":"http://nette.org","size":1543,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nette:master","ref":"master","sha":"faa068671e3f4d0bb43de0a24991420a9a43cb3e","user":{"login":"nette","id":99965,"avatar_url":"https://avatars.githubusercontent.com/u/99965?v=3","gravatar_id":"","url":"https://api.github.com/users/nette","html_url":"https://github.com/nette","followers_url":"https://api.github.com/users/nette/followers","following_url":"https://api.github.com/users/nette/following{/other_user}","gists_url":"https://api.github.com/users/nette/gists{/gist_id}","starred_url":"https://api.github.com/users/nette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nette/subscriptions","organizations_url":"https://api.github.com/users/nette/orgs","repos_url":"https://api.github.com/users/nette/repos","events_url":"https://api.github.com/users/nette/events{/privacy}","received_events_url":"https://api.github.com/users/nette/received_events","type":"Organization","site_admin":false},"repo":{"id":19296825,"name":"bootstrap","full_name":"nette/bootstrap","owner":{"login":"nette","id":99965,"avatar_url":"https://avatars.githubusercontent.com/u/99965?v=3","gravatar_id":"","url":"https://api.github.com/users/nette","html_url":"https://github.com/nette","followers_url":"https://api.github.com/users/nette/followers","following_url":"https://api.github.com/users/nette/following{/other_user}","gists_url":"https://api.github.com/users/nette/gists{/gist_id}","starred_url":"https://api.github.com/users/nette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nette/subscriptions","organizations_url":"https://api.github.com/users/nette/orgs","repos_url":"https://api.github.com/users/nette/repos","events_url":"https://api.github.com/users/nette/events{/privacy}","received_events_url":"https://api.github.com/users/nette/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nette/bootstrap","description":"Nette Bootstrap component","fork":false,"url":"https://api.github.com/repos/nette/bootstrap","forks_url":"https://api.github.com/repos/nette/bootstrap/forks","keys_url":"https://api.github.com/repos/nette/bootstrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nette/bootstrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nette/bootstrap/teams","hooks_url":"https://api.github.com/repos/nette/bootstrap/hooks","issue_events_url":"https://api.github.com/repos/nette/bootstrap/issues/events{/number}","events_url":"https://api.github.com/repos/nette/bootstrap/events","assignees_url":"https://api.github.com/repos/nette/bootstrap/assignees{/user}","branches_url":"https://api.github.com/repos/nette/bootstrap/branches{/branch}","tags_url":"https://api.github.com/repos/nette/bootstrap/tags","blobs_url":"https://api.github.com/repos/nette/bootstrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nette/bootstrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nette/bootstrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/nette/bootstrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nette/bootstrap/statuses/{sha}","languages_url":"https://api.github.com/repos/nette/bootstrap/languages","stargazers_url":"https://api.github.com/repos/nette/bootstrap/stargazers","contributors_url":"https://api.github.com/repos/nette/bootstrap/contributors","subscribers_url":"https://api.github.com/repos/nette/bootstrap/subscribers","subscription_url":"https://api.github.com/repos/nette/bootstrap/subscription","commits_url":"https://api.github.com/repos/nette/bootstrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/nette/bootstrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/nette/bootstrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/nette/bootstrap/issues/comments/{number}","contents_url":"https://api.github.com/repos/nette/bootstrap/contents/{+path}","compare_url":"https://api.github.com/repos/nette/bootstrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nette/bootstrap/merges","archive_url":"https://api.github.com/repos/nette/bootstrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nette/bootstrap/downloads","issues_url":"https://api.github.com/repos/nette/bootstrap/issues{/number}","pulls_url":"https://api.github.com/repos/nette/bootstrap/pulls{/number}","milestones_url":"https://api.github.com/repos/nette/bootstrap/milestones{/number}","notifications_url":"https://api.github.com/repos/nette/bootstrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nette/bootstrap/labels{/name}","releases_url":"https://api.github.com/repos/nette/bootstrap/releases{/id}","created_at":"2014-04-30T01:13:48Z","updated_at":"2014-11-18T01:15:54Z","pushed_at":"2014-11-18T01:15:54Z","git_url":"git://github.com/nette/bootstrap.git","ssh_url":"git@github.com:nette/bootstrap.git","clone_url":"https://github.com/nette/bootstrap.git","svn_url":"https://github.com/nette/bootstrap","homepage":"http://nette.org","size":1543,"stargazers_count":37,"watchers_count":37,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":6,"forks":13,"open_issues":6,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nette/bootstrap/pulls/26"},"html":{"href":"https://github.com/nette/bootstrap/pull/26"},"issue":{"href":"https://api.github.com/repos/nette/bootstrap/issues/26"},"comments":{"href":"https://api.github.com/repos/nette/bootstrap/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/nette/bootstrap/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/nette/bootstrap/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/nette/bootstrap/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/nette/bootstrap/statuses/f10e6764088b4875092eb09bda28d360f0b3c18e"}}}}