GitHub PullRequestEvent at 2014-07-15 10:57:59
Repository: vagrant-librarian-chef
Actor: jimmycuadra
Payload: {"action":"closed","number":25,"pull_request":{"url":"https://api.github.com/repos/jimmycuadra/vagrant-librarian-chef/pulls/25","id":18397528,"html_url":"https://github.com/jimmycuadra/vagrant-librarian-chef/pull/25","diff_url":"https://github.com/jimmycuadra/vagrant-librarian-chef/pull/25.diff","patch_url":"https://github.com/jimmycuadra/vagrant-librarian-chef/pull/25.patch","issue_url":"https://api.github.com/repos/jimmycuadra/vagrant-librarian-chef/issues/25","number":25,"state":"closed","title":"Ensure Vagrant can properly merge multiple configurations","user":{"login":"emyl","id":562707,"avatar_url":"https://avatars.githubusercontent.com/u/562707?","gravatar_id":"cf8bcb88e6a2b84c6f97d8156882e674","url":"https://api.github.com/users/emyl","html_url":"https://github.com/emyl","followers_url":"https://api.github.com/users/emyl/followers","following_url":"https://api.github.com/users/emyl/following{/other_user}","gists_url":"https://api.github.com/users/emyl/gists{/gist_id}","starred_url":"https://api.github.com/users/emyl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emyl/subscriptions","organizations_url":"https://api.github.com/users/emyl/orgs","repos_url":"https://api.github.com/users/emyl/repos","events_url":"https://api.github.com/users/emyl/events{/privacy}","received_events_url":"https://api.github.com/users/emyl/received_events","type":"User","site_admin":false},"body":"In my humble opinion it would be better to use the canonical way for defining configuration variables.\r\n\r\nAccording to [Vagrant docs](http://docs.vagrantup.com/v2/plugins/configuration.html), `UNSET_VALUE` is used  for ensuring correct Vagrantfile merge-logic.","created_at":"2014-07-15T09:40:08Z","updated_at":"2014-07-15T10:57:59Z","closed_at":"2014-07-15T10:57:59Z","merged_at":"2014-07-15T10:57:59Z","merge_commit_sha":"1eee156b1f4ea634b86764cc711c9f1ec5821409","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jimmycuadra/vagrant-librarian-chef/pulls/25/commits","review_comments_url":"https://api.github.com/repos/jimmycuadra/vagrant-librarian-chef/pulls/25/comments","review_comment_url":"https://api.github.com/repos/jimmycuadra/vagrant-librarian-chef/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jimmycuadra/vagrant-librarian-chef/issues/25/comments","statuses_url":"https://api.github.com/repos/jimmycuadra/vagrant-librarian-chef/statuses/419d680af940c2ab302d8fa20d0ca37d80a8d2f4","head":{"label":"emyl:fix-config","ref":"fix-config","sha":"419d680af940c2ab302d8fa20d0ca37d80a8d2f4","user":{"login":"emyl","id":562707,"avatar_url":"https://avatars.githubusercontent.com/u/562707?","gravatar_id":"cf8bcb88e6a2b84c6f97d8156882e674","url":"https://api.github.com/users/emyl","html_url":"https://github.com/emyl","followers_url":"https://api.github.com/users/emyl/followers","following_url":"https://api.github.com/users/emyl/following{/other_user}","gists_url":"https://api.github.com/users/emyl/gists{/gist_id}","starred_url":"https://api.github.com/users/emyl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emyl/subscriptions","organizations_url":"https://api.github.com/users/emyl/orgs","repos_url":"https://api.github.com/users/emyl/repos","events_url":"https://api.github.com/users/emyl/events{/privacy}","received_events_url":"https://api.github.com/users/emyl/received_events","type":"User","site_admin":false},"repo":{"id":17447732,"name":"vagrant-librarian-chef-nochef","full_name":"emyl/vagrant-librarian-chef-nochef","owner":{"login":"emyl","id":562707,"avatar_url":"https://avatars.githubusercontent.com/u/562707?","gravatar_id":"cf8bcb88e6a2b84c6f97d8156882e674","url":"https://api.github.com/users/emyl","html_url":"https://github.com/emyl","followers_url":"https://api.github.com/users/emyl/followers","following_url":"https://api.github.com/users/emyl/following{/other_user}","gists_url":"https://api.github.com/users/emyl/gists{/gist_id}","starred_url":"https://api.github.com/users/emyl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emyl/subscriptions","organizations_url":"https://api.github.com/users/emyl/orgs","repos_url":"https://api.github.com/users/emyl/repos","events_url":"https://api.github.com/users/emyl/events{/privacy}","received_events_url":"https://api.github.com/users/emyl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/emyl/vagrant-librarian-chef-nochef","description":"A fork of the vagrant-librarian-chef plugin that use the librarian-chef-nochef gem.","fork":true,"url":"https://api.github.com/repos/emyl/vagrant-librarian-chef-nochef","forks_url":"https://api.github.com/repos/emyl/vagrant-librarian-chef-nochef/forks","keys_url":"https://api.github.com/repos/emyl/vagrant-librarian-chef-nochef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emyl/vagrant-librarian-chef-nochef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emyl/vagrant-librarian-chef-nochef/teams","hooks_url":"https://api.github.com/repos/emyl/vagrant-librarian-chef-nochef/hooks","issue_events_url":"https://api.github.com/repos/emyl/vagrant-librarian-chef-nochef/issues/events{/number}","events_url":"https://api.github.com/repos/emyl/vagrant-librarian-chef-nochef/events","assignees_url":"https://api.github.com/repos/emyl/vagrant-librarian-chef-nochef/assignees{/user}","branches_url":"https://api.github.com/repos/emyl/vagrant-librarian-chef-nochef/branches{/branch}","tags_url":"https://api.github.com/repos/emyl/vagrant-librarian-chef-nochef/tags","blobs_url":"https://api.github.com/repos/emyl/vagrant-librarian-chef-nochef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emyl/vagrant-librarian-chef-nochef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emyl/vagrant-librarian-chef-nochef/git/refs{/sha}","trees_url":"https://api.github.com/repos/emyl/vagrant-librarian-chef-nochef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emyl/vagrant-librarian-chef-nochef/statuses/{sha}","languages_url":"https://api.github.com/repos/emyl/vagrant-librarian-chef-nochef/languages","stargazers_url":"https://api.github.com/repos/emyl/vagrant-librarian-chef-nochef/stargazers","contributors_url":"https://api.github.com/repos/emyl/vagrant-librarian-chef-nochef/contributors","subscribers_url":"https://api.github.com/repos/emyl/vagrant-librarian-chef-nochef/subscribers","subscription_url":"https://api.github.com/repos/emyl/vagrant-librarian-chef-nochef/subscription","commits_url":"https://api.github.com/repos/emyl/vagrant-librarian-chef-nochef/commits{/sha}","git_commits_url":"https://api.github.com/repos/emyl/vagrant-librarian-chef-nochef/git/commits{/sha}","comments_url":"https://api.github.com/repos/emyl/vagrant-librarian-chef-nochef/comments{/number}","issue_comment_url":"https://api.github.com/repos/emyl/vagrant-librarian-chef-nochef/issues/comments/{number}","contents_url":"https://api.github.com/repos/emyl/vagrant-librarian-chef-nochef/contents/{+path}","compare_url":"https://api.github.com/repos/emyl/vagrant-librarian-chef-nochef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emyl/vagrant-librarian-chef-nochef/merges","archive_url":"https://api.github.com/repos/emyl/vagrant-librarian-chef-nochef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emyl/vagrant-librarian-chef-nochef/downloads","issues_url":"https://api.github.com/repos/emyl/vagrant-librarian-chef-nochef/issues{/number}","pulls_url":"https://api.github.com/repos/emyl/vagrant-librarian-chef-nochef/pulls{/number}","milestones_url":"https://api.github.com/repos/emyl/vagrant-librarian-chef-nochef/milestones{/number}","notifications_url":"https://api.github.com/repos/emyl/vagrant-librarian-chef-nochef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emyl/vagrant-librarian-chef-nochef/labels{/name}","releases_url":"https://api.github.com/repos/emyl/vagrant-librarian-chef-nochef/releases{/id}","created_at":"2014-03-05T16:53:18Z","updated_at":"2014-07-15T09:23:28Z","pushed_at":"2014-07-15T09:32:11Z","git_url":"git://github.com/emyl/vagrant-librarian-chef-nochef.git","ssh_url":"git@github.com:emyl/vagrant-librarian-chef-nochef.git","clone_url":"https://github.com/emyl/vagrant-librarian-chef-nochef.git","svn_url":"https://github.com/emyl/vagrant-librarian-chef-nochef","homepage":"","size":163,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"jimmycuadra:master","ref":"master","sha":"7d07715451e39aecfb15c77c1b1d98cb441b417a","user":{"login":"jimmycuadra","id":122457,"avatar_url":"https://avatars.githubusercontent.com/u/122457?","gravatar_id":"8893e2e206c0377ff776d2535887d23f","url":"https://api.github.com/users/jimmycuadra","html_url":"https://github.com/jimmycuadra","followers_url":"https://api.github.com/users/jimmycuadra/followers","following_url":"https://api.github.com/users/jimmycuadra/following{/other_user}","gists_url":"https://api.github.com/users/jimmycuadra/gists{/gist_id}","starred_url":"https://api.github.com/users/jimmycuadra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimmycuadra/subscriptions","organizations_url":"https://api.github.com/users/jimmycuadra/orgs","repos_url":"https://api.github.com/users/jimmycuadra/repos","events_url":"https://api.github.com/users/jimmycuadra/events{/privacy}","received_events_url":"https://api.github.com/users/jimmycuadra/received_events","type":"User","site_admin":false},"repo":{"id":9337677,"name":"vagrant-librarian-chef","full_name":"jimmycuadra/vagrant-librarian-chef","owner":{"login":"jimmycuadra","id":122457,"avatar_url":"https://avatars.githubusercontent.com/u/122457?","gravatar_id":"8893e2e206c0377ff776d2535887d23f","url":"https://api.github.com/users/jimmycuadra","html_url":"https://github.com/jimmycuadra","followers_url":"https://api.github.com/users/jimmycuadra/followers","following_url":"https://api.github.com/users/jimmycuadra/following{/other_user}","gists_url":"https://api.github.com/users/jimmycuadra/gists{/gist_id}","starred_url":"https://api.github.com/users/jimmycuadra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimmycuadra/subscriptions","organizations_url":"https://api.github.com/users/jimmycuadra/orgs","repos_url":"https://api.github.com/users/jimmycuadra/repos","events_url":"https://api.github.com/users/jimmycuadra/events{/privacy}","received_events_url":"https://api.github.com/users/jimmycuadra/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jimmycuadra/vagrant-librarian-chef","description":"A Vagrant plugin to install Chef cookbooks using Librarian-Chef.","fork":false,"url":"https://api.github.com/repos/jimmycuadra/vagrant-librarian-chef","forks_url":"https://api.github.com/repos/jimmycuadra/vagrant-librarian-chef/forks","keys_url":"https://api.github.com/repos/jimmycuadra/vagrant-librarian-chef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jimmycuadra/vagrant-librarian-chef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jimmycuadra/vagrant-librarian-chef/teams","hooks_url":"https://api.github.com/repos/jimmycuadra/vagrant-librarian-chef/hooks","issue_events_url":"https://api.github.com/repos/jimmycuadra/vagrant-librarian-chef/issues/events{/number}","events_url":"https://api.github.com/repos/jimmycuadra/vagrant-librarian-chef/events","assignees_url":"https://api.github.com/repos/jimmycuadra/vagrant-librarian-chef/assignees{/user}","branches_url":"https://api.github.com/repos/jimmycuadra/vagrant-librarian-chef/branches{/branch}","tags_url":"https://api.github.com/repos/jimmycuadra/vagrant-librarian-chef/tags","blobs_url":"https://api.github.com/repos/jimmycuadra/vagrant-librarian-chef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jimmycuadra/vagrant-librarian-chef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jimmycuadra/vagrant-librarian-chef/git/refs{/sha}","trees_url":"https://api.github.com/repos/jimmycuadra/vagrant-librarian-chef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jimmycuadra/vagrant-librarian-chef/statuses/{sha}","languages_url":"https://api.github.com/repos/jimmycuadra/vagrant-librarian-chef/languages","stargazers_url":"https://api.github.com/repos/jimmycuadra/vagrant-librarian-chef/stargazers","contributors_url":"https://api.github.com/repos/jimmycuadra/vagrant-librarian-chef/contributors","subscribers_url":"https://api.github.com/repos/jimmycuadra/vagrant-librarian-chef/subscribers","subscription_url":"https://api.github.com/repos/jimmycuadra/vagrant-librarian-chef/subscription","commits_url":"https://api.github.com/repos/jimmycuadra/vagrant-librarian-chef/commits{/sha}","git_commits_url":"https://api.github.com/repos/jimmycuadra/vagrant-librarian-chef/git/commits{/sha}","comments_url":"https://api.github.com/repos/jimmycuadra/vagrant-librarian-chef/comments{/number}","issue_comment_url":"https://api.github.com/repos/jimmycuadra/vagrant-librarian-chef/issues/comments/{number}","contents_url":"https://api.github.com/repos/jimmycuadra/vagrant-librarian-chef/contents/{+path}","compare_url":"https://api.github.com/repos/jimmycuadra/vagrant-librarian-chef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jimmycuadra/vagrant-librarian-chef/merges","archive_url":"https://api.github.com/repos/jimmycuadra/vagrant-librarian-chef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jimmycuadra/vagrant-librarian-chef/downloads","issues_url":"https://api.github.com/repos/jimmycuadra/vagrant-librarian-chef/issues{/number}","pulls_url":"https://api.github.com/repos/jimmycuadra/vagrant-librarian-chef/pulls{/number}","milestones_url":"https://api.github.com/repos/jimmycuadra/vagrant-librarian-chef/milestones{/number}","notifications_url":"https://api.github.com/repos/jimmycuadra/vagrant-librarian-chef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jimmycuadra/vagrant-librarian-chef/labels{/name}","releases_url":"https://api.github.com/repos/jimmycuadra/vagrant-librarian-chef/releases{/id}","created_at":"2013-04-10T03:54:51Z","updated_at":"2014-07-03T09:31:05Z","pushed_at":"2014-07-15T10:57:59Z","git_url":"git://github.com/jimmycuadra/vagrant-librarian-chef.git","ssh_url":"git@github.com:jimmycuadra/vagrant-librarian-chef.git","clone_url":"https://github.com/jimmycuadra/vagrant-librarian-chef.git","svn_url":"https://github.com/jimmycuadra/vagrant-librarian-chef","homepage":null,"size":251,"stargazers_count":62,"watchers_count":62,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":14,"mirror_url":null,"open_issues_count":4,"forks":14,"open_issues":4,"watchers":62,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jimmycuadra/vagrant-librarian-chef/pulls/25"},"html":{"href":"https://github.com/jimmycuadra/vagrant-librarian-chef/pull/25"},"issue":{"href":"https://api.github.com/repos/jimmycuadra/vagrant-librarian-chef/issues/25"},"comments":{"href":"https://api.github.com/repos/jimmycuadra/vagrant-librarian-chef/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/jimmycuadra/vagrant-librarian-chef/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/jimmycuadra/vagrant-librarian-chef/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jimmycuadra/vagrant-librarian-chef/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/jimmycuadra/vagrant-librarian-chef/statuses/419d680af940c2ab302d8fa20d0ca37d80a8d2f4"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jimmycuadra","id":122457,"avatar_url":"https://avatars.githubusercontent.com/u/122457?","gravatar_id":"8893e2e206c0377ff776d2535887d23f","url":"https://api.github.com/users/jimmycuadra","html_url":"https://github.com/jimmycuadra","followers_url":"https://api.github.com/users/jimmycuadra/followers","following_url":"https://api.github.com/users/jimmycuadra/following{/other_user}","gists_url":"https://api.github.com/users/jimmycuadra/gists{/gist_id}","starred_url":"https://api.github.com/users/jimmycuadra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimmycuadra/subscriptions","organizations_url":"https://api.github.com/users/jimmycuadra/orgs","repos_url":"https://api.github.com/users/jimmycuadra/repos","events_url":"https://api.github.com/users/jimmycuadra/events{/privacy}","received_events_url":"https://api.github.com/users/jimmycuadra/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":1,"changed_files":1}}