GitHub PullRequestReviewCommentEvent at 2014-11-01 17:40:44
Repository: Sonarr
Actor: kayone
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Sonarr/Sonarr/pulls/comments/19706071","id":19706071,"diff_hunk":"@@ -0,0 +1,44 @@\n+﻿using System;\n+using System.Collections.Generic;\n+using System.Linq;\n+using System.Text;\n+using NzbDrone.Common.Serializer;\n+\n+namespace NzbDrone.Common.Http\n+{\n+    public class JsonRpcRequestBuilder : HttpRequestBuilder\n+    {\n+        public String Method { get; private set; }\n+        public List<Object> Parameters { get; private set; }\n+\n+        public JsonRpcRequestBuilder(String baseUri, String method, Object[] parameters)","path":"src/NzbDrone.Common/Http/JsonRpcRequestBuilder.cs","position":14,"original_position":14,"commit_id":"4d753347ea01692ee3ac3e959b6e142c2a580894","original_commit_id":"4d753347ea01692ee3ac3e959b6e142c2a580894","user":{"login":"kayone","id":412280,"avatar_url":"https://avatars.githubusercontent.com/u/412280?v=2","gravatar_id":"","url":"https://api.github.com/users/kayone","html_url":"https://github.com/kayone","followers_url":"https://api.github.com/users/kayone/followers","following_url":"https://api.github.com/users/kayone/following{/other_user}","gists_url":"https://api.github.com/users/kayone/gists{/gist_id}","starred_url":"https://api.github.com/users/kayone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kayone/subscriptions","organizations_url":"https://api.github.com/users/kayone/orgs","repos_url":"https://api.github.com/users/kayone/repos","events_url":"https://api.github.com/users/kayone/events{/privacy}","received_events_url":"https://api.github.com/users/kayone/received_events","type":"User","site_admin":false},"body":"`IEnumerable<object>` since you are calling .ToList() anyways.","created_at":"2014-11-01T17:40:44Z","updated_at":"2014-11-01T17:40:44Z","html_url":"https://github.com/Sonarr/Sonarr/pull/131#discussion_r19706071","pull_request_url":"https://api.github.com/repos/Sonarr/Sonarr/pulls/131","_links":{"self":{"href":"https://api.github.com/repos/Sonarr/Sonarr/pulls/comments/19706071"},"html":{"href":"https://github.com/Sonarr/Sonarr/pull/131#discussion_r19706071"},"pull_request":{"href":"https://api.github.com/repos/Sonarr/Sonarr/pulls/131"}}},"pull_request":{"url":"https://api.github.com/repos/Sonarr/Sonarr/pulls/131","id":23718814,"html_url":"https://github.com/Sonarr/Sonarr/pull/131","diff_url":"https://github.com/Sonarr/Sonarr/pull/131.diff","patch_url":"https://github.com/Sonarr/Sonarr/pull/131.patch","issue_url":"https://api.github.com/repos/Sonarr/Sonarr/issues/131","number":131,"state":"open","locked":false,"title":"Torrents support","user":{"login":"Taloth","id":6383890,"avatar_url":"https://avatars.githubusercontent.com/u/6383890?v=2","gravatar_id":"","url":"https://api.github.com/users/Taloth","html_url":"https://github.com/Taloth","followers_url":"https://api.github.com/users/Taloth/followers","following_url":"https://api.github.com/users/Taloth/following{/other_user}","gists_url":"https://api.github.com/users/Taloth/gists{/gist_id}","starred_url":"https://api.github.com/users/Taloth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Taloth/subscriptions","organizations_url":"https://api.github.com/users/Taloth/orgs","repos_url":"https://api.github.com/users/Taloth/repos","events_url":"https://api.github.com/users/Taloth/events{/privacy}","received_events_url":"https://api.github.com/users/Taloth/received_events","type":"User","site_admin":false},"body":"This PR is intended to do a final checkup on all changes pertaining to torrents before merging it into dev.\r\nObviously we aren't finished, some features are missing and some things we should have done differently.\r\n\r\nOne thing I particularly dislike is the torrent proxies remembering authentication state. I rather have a Connection class that contains that state and caching as well. This would also better allow callback logic, like the Deluge daemon rpc has.\r\nBut it would be a significant undertaking to make that a reality, so i'll settle for \"good enough\". Once everything is in dev or even master, we can look at implementing Connection state.\r\n\r\nFeel free to comment on anything you like.","created_at":"2014-11-01T12:13:24Z","updated_at":"2014-11-01T17:40:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6e579da306da89882b0846c83b29e94b714257bb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Sonarr/Sonarr/pulls/131/commits","review_comments_url":"https://api.github.com/repos/Sonarr/Sonarr/pulls/131/comments","review_comment_url":"https://api.github.com/repos/Sonarr/Sonarr/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Sonarr/Sonarr/issues/131/comments","statuses_url":"https://api.github.com/repos/Sonarr/Sonarr/statuses/4d753347ea01692ee3ac3e959b6e142c2a580894","head":{"label":"Sonarr:torrents","ref":"torrents","sha":"4d753347ea01692ee3ac3e959b6e142c2a580894","user":{"login":"Sonarr","id":1082903,"avatar_url":"https://avatars.githubusercontent.com/u/1082903?v=2","gravatar_id":"","url":"https://api.github.com/users/Sonarr","html_url":"https://github.com/Sonarr","followers_url":"https://api.github.com/users/Sonarr/followers","following_url":"https://api.github.com/users/Sonarr/following{/other_user}","gists_url":"https://api.github.com/users/Sonarr/gists{/gist_id}","starred_url":"https://api.github.com/users/Sonarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sonarr/subscriptions","organizations_url":"https://api.github.com/users/Sonarr/orgs","repos_url":"https://api.github.com/users/Sonarr/repos","events_url":"https://api.github.com/users/Sonarr/events{/privacy}","received_events_url":"https://api.github.com/users/Sonarr/received_events","type":"Organization","site_admin":false},"repo":{"id":2465723,"name":"Sonarr","full_name":"Sonarr/Sonarr","owner":{"login":"Sonarr","id":1082903,"avatar_url":"https://avatars.githubusercontent.com/u/1082903?v=2","gravatar_id":"","url":"https://api.github.com/users/Sonarr","html_url":"https://github.com/Sonarr","followers_url":"https://api.github.com/users/Sonarr/followers","following_url":"https://api.github.com/users/Sonarr/following{/other_user}","gists_url":"https://api.github.com/users/Sonarr/gists{/gist_id}","starred_url":"https://api.github.com/users/Sonarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sonarr/subscriptions","organizations_url":"https://api.github.com/users/Sonarr/orgs","repos_url":"https://api.github.com/users/Sonarr/repos","events_url":"https://api.github.com/users/Sonarr/events{/privacy}","received_events_url":"https://api.github.com/users/Sonarr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Sonarr/Sonarr","description":"Smart PVR for newsgroup users.","fork":false,"url":"https://api.github.com/repos/Sonarr/Sonarr","forks_url":"https://api.github.com/repos/Sonarr/Sonarr/forks","keys_url":"https://api.github.com/repos/Sonarr/Sonarr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sonarr/Sonarr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sonarr/Sonarr/teams","hooks_url":"https://api.github.com/repos/Sonarr/Sonarr/hooks","issue_events_url":"https://api.github.com/repos/Sonarr/Sonarr/issues/events{/number}","events_url":"https://api.github.com/repos/Sonarr/Sonarr/events","assignees_url":"https://api.github.com/repos/Sonarr/Sonarr/assignees{/user}","branches_url":"https://api.github.com/repos/Sonarr/Sonarr/branches{/branch}","tags_url":"https://api.github.com/repos/Sonarr/Sonarr/tags","blobs_url":"https://api.github.com/repos/Sonarr/Sonarr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sonarr/Sonarr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sonarr/Sonarr/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sonarr/Sonarr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sonarr/Sonarr/statuses/{sha}","languages_url":"https://api.github.com/repos/Sonarr/Sonarr/languages","stargazers_url":"https://api.github.com/repos/Sonarr/Sonarr/stargazers","contributors_url":"https://api.github.com/repos/Sonarr/Sonarr/contributors","subscribers_url":"https://api.github.com/repos/Sonarr/Sonarr/subscribers","subscription_url":"https://api.github.com/repos/Sonarr/Sonarr/subscription","commits_url":"https://api.github.com/repos/Sonarr/Sonarr/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sonarr/Sonarr/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sonarr/Sonarr/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sonarr/Sonarr/issues/comments/{number}","contents_url":"https://api.github.com/repos/Sonarr/Sonarr/contents/{+path}","compare_url":"https://api.github.com/repos/Sonarr/Sonarr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sonarr/Sonarr/merges","archive_url":"https://api.github.com/repos/Sonarr/Sonarr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sonarr/Sonarr/downloads","issues_url":"https://api.github.com/repos/Sonarr/Sonarr/issues{/number}","pulls_url":"https://api.github.com/repos/Sonarr/Sonarr/pulls{/number}","milestones_url":"https://api.github.com/repos/Sonarr/Sonarr/milestones{/number}","notifications_url":"https://api.github.com/repos/Sonarr/Sonarr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sonarr/Sonarr/labels{/name}","releases_url":"https://api.github.com/repos/Sonarr/Sonarr/releases{/id}","created_at":"2011-09-27T05:57:16Z","updated_at":"2014-10-31T11:31:56Z","pushed_at":"2014-11-01T11:42:33Z","git_url":"git://github.com/Sonarr/Sonarr.git","ssh_url":"git@github.com:Sonarr/Sonarr.git","clone_url":"https://github.com/Sonarr/Sonarr.git","svn_url":"https://github.com/Sonarr/Sonarr","homepage":"https://nzbdrone.com","size":207321,"stargazers_count":266,"watchers_count":266,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":89,"mirror_url":null,"open_issues_count":6,"forks":89,"open_issues":6,"watchers":266,"default_branch":"develop"}},"base":{"label":"Sonarr:develop","ref":"develop","sha":"e6494ba2292df0cd65c8846926fc089556b8b83b","user":{"login":"Sonarr","id":1082903,"avatar_url":"https://avatars.githubusercontent.com/u/1082903?v=2","gravatar_id":"","url":"https://api.github.com/users/Sonarr","html_url":"https://github.com/Sonarr","followers_url":"https://api.github.com/users/Sonarr/followers","following_url":"https://api.github.com/users/Sonarr/following{/other_user}","gists_url":"https://api.github.com/users/Sonarr/gists{/gist_id}","starred_url":"https://api.github.com/users/Sonarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sonarr/subscriptions","organizations_url":"https://api.github.com/users/Sonarr/orgs","repos_url":"https://api.github.com/users/Sonarr/repos","events_url":"https://api.github.com/users/Sonarr/events{/privacy}","received_events_url":"https://api.github.com/users/Sonarr/received_events","type":"Organization","site_admin":false},"repo":{"id":2465723,"name":"Sonarr","full_name":"Sonarr/Sonarr","owner":{"login":"Sonarr","id":1082903,"avatar_url":"https://avatars.githubusercontent.com/u/1082903?v=2","gravatar_id":"","url":"https://api.github.com/users/Sonarr","html_url":"https://github.com/Sonarr","followers_url":"https://api.github.com/users/Sonarr/followers","following_url":"https://api.github.com/users/Sonarr/following{/other_user}","gists_url":"https://api.github.com/users/Sonarr/gists{/gist_id}","starred_url":"https://api.github.com/users/Sonarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sonarr/subscriptions","organizations_url":"https://api.github.com/users/Sonarr/orgs","repos_url":"https://api.github.com/users/Sonarr/repos","events_url":"https://api.github.com/users/Sonarr/events{/privacy}","received_events_url":"https://api.github.com/users/Sonarr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Sonarr/Sonarr","description":"Smart PVR for newsgroup users.","fork":false,"url":"https://api.github.com/repos/Sonarr/Sonarr","forks_url":"https://api.github.com/repos/Sonarr/Sonarr/forks","keys_url":"https://api.github.com/repos/Sonarr/Sonarr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sonarr/Sonarr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sonarr/Sonarr/teams","hooks_url":"https://api.github.com/repos/Sonarr/Sonarr/hooks","issue_events_url":"https://api.github.com/repos/Sonarr/Sonarr/issues/events{/number}","events_url":"https://api.github.com/repos/Sonarr/Sonarr/events","assignees_url":"https://api.github.com/repos/Sonarr/Sonarr/assignees{/user}","branches_url":"https://api.github.com/repos/Sonarr/Sonarr/branches{/branch}","tags_url":"https://api.github.com/repos/Sonarr/Sonarr/tags","blobs_url":"https://api.github.com/repos/Sonarr/Sonarr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sonarr/Sonarr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sonarr/Sonarr/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sonarr/Sonarr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sonarr/Sonarr/statuses/{sha}","languages_url":"https://api.github.com/repos/Sonarr/Sonarr/languages","stargazers_url":"https://api.github.com/repos/Sonarr/Sonarr/stargazers","contributors_url":"https://api.github.com/repos/Sonarr/Sonarr/contributors","subscribers_url":"https://api.github.com/repos/Sonarr/Sonarr/subscribers","subscription_url":"https://api.github.com/repos/Sonarr/Sonarr/subscription","commits_url":"https://api.github.com/repos/Sonarr/Sonarr/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sonarr/Sonarr/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sonarr/Sonarr/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sonarr/Sonarr/issues/comments/{number}","contents_url":"https://api.github.com/repos/Sonarr/Sonarr/contents/{+path}","compare_url":"https://api.github.com/repos/Sonarr/Sonarr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sonarr/Sonarr/merges","archive_url":"https://api.github.com/repos/Sonarr/Sonarr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sonarr/Sonarr/downloads","issues_url":"https://api.github.com/repos/Sonarr/Sonarr/issues{/number}","pulls_url":"https://api.github.com/repos/Sonarr/Sonarr/pulls{/number}","milestones_url":"https://api.github.com/repos/Sonarr/Sonarr/milestones{/number}","notifications_url":"https://api.github.com/repos/Sonarr/Sonarr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sonarr/Sonarr/labels{/name}","releases_url":"https://api.github.com/repos/Sonarr/Sonarr/releases{/id}","created_at":"2011-09-27T05:57:16Z","updated_at":"2014-10-31T11:31:56Z","pushed_at":"2014-11-01T11:42:33Z","git_url":"git://github.com/Sonarr/Sonarr.git","ssh_url":"git@github.com:Sonarr/Sonarr.git","clone_url":"https://github.com/Sonarr/Sonarr.git","svn_url":"https://github.com/Sonarr/Sonarr","homepage":"https://nzbdrone.com","size":207321,"stargazers_count":266,"watchers_count":266,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":89,"mirror_url":null,"open_issues_count":6,"forks":89,"open_issues":6,"watchers":266,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Sonarr/Sonarr/pulls/131"},"html":{"href":"https://github.com/Sonarr/Sonarr/pull/131"},"issue":{"href":"https://api.github.com/repos/Sonarr/Sonarr/issues/131"},"comments":{"href":"https://api.github.com/repos/Sonarr/Sonarr/issues/131/comments"},"review_comments":{"href":"https://api.github.com/repos/Sonarr/Sonarr/pulls/131/comments"},"review_comment":{"href":"https://api.github.com/repos/Sonarr/Sonarr/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Sonarr/Sonarr/pulls/131/commits"},"statuses":{"href":"https://api.github.com/repos/Sonarr/Sonarr/statuses/4d753347ea01692ee3ac3e959b6e142c2a580894"}}}}