GitHub PullRequestEvent at 2014-04-12 18:06:05
Repository: rails
Actor: philr
Payload: {"action":"opened","number":14720,"pull_request":{"url":"https://api.github.com/repos/rails/rails/pulls/14720","id":14687478,"html_url":"https://github.com/rails/rails/pull/14720","diff_url":"https://github.com/rails/rails/pull/14720.diff","patch_url":"https://github.com/rails/rails/pull/14720.patch","issue_url":"https://api.github.com/repos/rails/rails/issues/14720","number":14720,"state":"open","title":"Bundle tzinfo-data on :x64_mingw (64-bit Ruby on Windows).","user":{"login":"philr","id":190067,"avatar_url":"https://avatars.githubusercontent.com/u/190067?","gravatar_id":"ba2db2b1eda72da7dbd5ec91dd875b6f","url":"https://api.github.com/users/philr","html_url":"https://github.com/philr","followers_url":"https://api.github.com/users/philr/followers","following_url":"https://api.github.com/users/philr/following{/other_user}","gists_url":"https://api.github.com/users/philr/gists{/gist_id}","starred_url":"https://api.github.com/users/philr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philr/subscriptions","organizations_url":"https://api.github.com/users/philr/orgs","repos_url":"https://api.github.com/users/philr/repos","events_url":"https://api.github.com/users/philr/events{/privacy}","received_events_url":"https://api.github.com/users/philr/received_events","type":"User","site_admin":false},"body":"On Windows, the default Rails 4.1.0 `Gemfile` includes the following line:\r\n\r\n```ruby\r\n# Windows does not include zoneinfo files, so bundle the tzinfo-data gem\r\ngem 'tzinfo-data', platforms: [:mingw, :mswin]\r\n```\r\n\r\nHowever, this doesn't match 64-bit Windows MinGW builds of Ruby (such as the x64 RubyInstaller build). Users on this platform will encounter a `TZInfo::DataSourceNotFound` exception starting Rails unless they manually alter their `Gemfile`.\r\n\r\nThis pull request adds `:x64_mingw` to the platforms so that tzinfo-data is also used on 64-bit MinGW Ruby builds.","created_at":"2014-04-12T18:06:04Z","updated_at":"2014-04-12T18:06:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rails/rails/pulls/14720/commits","review_comments_url":"https://api.github.com/repos/rails/rails/pulls/14720/comments","review_comment_url":"https://api.github.com/repos/rails/rails/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rails/rails/issues/14720/comments","statuses_url":"https://api.github.com/repos/rails/rails/statuses/c8ccab05277dd5639cea509c2911af6ee35b0cf9","head":{"label":"philr:tzinfo_data_x64_mingw","ref":"tzinfo_data_x64_mingw","sha":"c8ccab05277dd5639cea509c2911af6ee35b0cf9","user":{"login":"philr","id":190067,"avatar_url":"https://avatars.githubusercontent.com/u/190067?","gravatar_id":"ba2db2b1eda72da7dbd5ec91dd875b6f","url":"https://api.github.com/users/philr","html_url":"https://github.com/philr","followers_url":"https://api.github.com/users/philr/followers","following_url":"https://api.github.com/users/philr/following{/other_user}","gists_url":"https://api.github.com/users/philr/gists{/gist_id}","starred_url":"https://api.github.com/users/philr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philr/subscriptions","organizations_url":"https://api.github.com/users/philr/orgs","repos_url":"https://api.github.com/users/philr/repos","events_url":"https://api.github.com/users/philr/events{/privacy}","received_events_url":"https://api.github.com/users/philr/received_events","type":"User","site_admin":false},"repo":{"id":18710421,"name":"rails","full_name":"philr/rails","owner":{"login":"philr","id":190067,"avatar_url":"https://avatars.githubusercontent.com/u/190067?","gravatar_id":"ba2db2b1eda72da7dbd5ec91dd875b6f","url":"https://api.github.com/users/philr","html_url":"https://github.com/philr","followers_url":"https://api.github.com/users/philr/followers","following_url":"https://api.github.com/users/philr/following{/other_user}","gists_url":"https://api.github.com/users/philr/gists{/gist_id}","starred_url":"https://api.github.com/users/philr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philr/subscriptions","organizations_url":"https://api.github.com/users/philr/orgs","repos_url":"https://api.github.com/users/philr/repos","events_url":"https://api.github.com/users/philr/events{/privacy}","received_events_url":"https://api.github.com/users/philr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/philr/rails","description":"Ruby on Rails","fork":true,"url":"https://api.github.com/repos/philr/rails","forks_url":"https://api.github.com/repos/philr/rails/forks","keys_url":"https://api.github.com/repos/philr/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/philr/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/philr/rails/teams","hooks_url":"https://api.github.com/repos/philr/rails/hooks","issue_events_url":"https://api.github.com/repos/philr/rails/issues/events{/number}","events_url":"https://api.github.com/repos/philr/rails/events","assignees_url":"https://api.github.com/repos/philr/rails/assignees{/user}","branches_url":"https://api.github.com/repos/philr/rails/branches{/branch}","tags_url":"https://api.github.com/repos/philr/rails/tags","blobs_url":"https://api.github.com/repos/philr/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/philr/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/philr/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/philr/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/philr/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/philr/rails/languages","stargazers_url":"https://api.github.com/repos/philr/rails/stargazers","contributors_url":"https://api.github.com/repos/philr/rails/contributors","subscribers_url":"https://api.github.com/repos/philr/rails/subscribers","subscription_url":"https://api.github.com/repos/philr/rails/subscription","commits_url":"https://api.github.com/repos/philr/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/philr/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/philr/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/philr/rails/issues/comments/{number}","contents_url":"https://api.github.com/repos/philr/rails/contents/{+path}","compare_url":"https://api.github.com/repos/philr/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/philr/rails/merges","archive_url":"https://api.github.com/repos/philr/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/philr/rails/downloads","issues_url":"https://api.github.com/repos/philr/rails/issues{/number}","pulls_url":"https://api.github.com/repos/philr/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/philr/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/philr/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/philr/rails/labels{/name}","releases_url":"https://api.github.com/repos/philr/rails/releases{/id}","created_at":"2014-04-12T17:47:54Z","updated_at":"2014-04-12T18:06:04Z","pushed_at":"2014-04-12T17:57:18Z","git_url":"git://github.com/philr/rails.git","ssh_url":"git@github.com:philr/rails.git","clone_url":"https://github.com/philr/rails.git","svn_url":"https://github.com/philr/rails","homepage":"http://rubyonrails.org","size":281638,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"rails:master","ref":"master","sha":"711a882f106385e248135c84ea9a6a827f0bd1e1","user":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?","gravatar_id":"30f39a09e233e8369dddf6feb4be0308","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"repo":{"id":8514,"name":"rails","full_name":"rails/rails","owner":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?","gravatar_id":"30f39a09e233e8369dddf6feb4be0308","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rails/rails","description":"Ruby on Rails","fork":false,"url":"https://api.github.com/repos/rails/rails","forks_url":"https://api.github.com/repos/rails/rails/forks","keys_url":"https://api.github.com/repos/rails/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails/rails/teams","hooks_url":"https://api.github.com/repos/rails/rails/hooks","issue_events_url":"https://api.github.com/repos/rails/rails/issues/events{/number}","events_url":"https://api.github.com/repos/rails/rails/events","assignees_url":"https://api.github.com/repos/rails/rails/assignees{/user}","branches_url":"https://api.github.com/repos/rails/rails/branches{/branch}","tags_url":"https://api.github.com/repos/rails/rails/tags","blobs_url":"https://api.github.com/repos/rails/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/rails/rails/languages","stargazers_url":"https://api.github.com/repos/rails/rails/stargazers","contributors_url":"https://api.github.com/repos/rails/rails/contributors","subscribers_url":"https://api.github.com/repos/rails/rails/subscribers","subscription_url":"https://api.github.com/repos/rails/rails/subscription","commits_url":"https://api.github.com/repos/rails/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails/rails/issues/comments/{number}","contents_url":"https://api.github.com/repos/rails/rails/contents/{+path}","compare_url":"https://api.github.com/repos/rails/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails/rails/merges","archive_url":"https://api.github.com/repos/rails/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails/rails/downloads","issues_url":"https://api.github.com/repos/rails/rails/issues{/number}","pulls_url":"https://api.github.com/repos/rails/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/rails/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/rails/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails/rails/labels{/name}","releases_url":"https://api.github.com/repos/rails/rails/releases{/id}","created_at":"2008-04-11T02:19:47Z","updated_at":"2014-04-12T17:54:19Z","pushed_at":"2014-04-12T17:54:19Z","git_url":"git://github.com/rails/rails.git","ssh_url":"git@github.com:rails/rails.git","clone_url":"https://github.com/rails/rails.git","svn_url":"https://github.com/rails/rails","homepage":"http://rubyonrails.org","size":281638,"stargazers_count":21437,"watchers_count":21437,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":7772,"mirror_url":null,"open_issues_count":722,"forks":7772,"open_issues":722,"watchers":21437,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/14720"},"html":{"href":"https://github.com/rails/rails/pull/14720"},"issue":{"href":"https://api.github.com/repos/rails/rails/issues/14720"},"comments":{"href":"https://api.github.com/repos/rails/rails/issues/14720/comments"},"review_comments":{"href":"https://api.github.com/repos/rails/rails/pulls/14720/comments"},"review_comment":{"href":"https://api.github.com/repos/rails/rails/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rails/rails/pulls/14720/commits"},"statuses":{"href":"https://api.github.com/repos/rails/rails/statuses/c8ccab05277dd5639cea509c2911af6ee35b0cf9"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}