GitHub PullRequestReviewCommentEvent at 2014-09-11 17:07:00
Repository: mixxx
Actor: ywwg
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/17433269","id":17433269,"diff_hunk":"@@ -0,0 +1,55 @@\n+#ifndef GOASLICEREFFECT_H\n+#define GOASLICEREFFECT_H\n+\n+#include <QMap>\n+\n+#include \"effects/effect.h\"\n+#include \"effects/effectprocessor.h\"\n+#include \"engine/effects/engineeffect.h\"\n+#include \"engine/effects/engineeffectparameter.h\"\n+#include \"sampleutil.h\"\n+#include \"util.h\"\n+\n+struct GoaSlicerGroupState {\n+    GoaSlicerGroupState()\n+            // TODO(XXX) 44100 should be changed to real sample rate","path":"src/effects/native/goaslicereffect.h","position":15,"original_position":15,"commit_id":"488a2b05f4ad0681e2da96e706048ad84631ef55","original_commit_id":"488a2b05f4ad0681e2da96e706048ad84631ef55","user":{"login":"ywwg","id":888940,"avatar_url":"https://avatars.githubusercontent.com/u/888940?v=2","gravatar_id":"4014ed6d62e2c214b8be9099508e0a10","url":"https://api.github.com/users/ywwg","html_url":"https://github.com/ywwg","followers_url":"https://api.github.com/users/ywwg/followers","following_url":"https://api.github.com/users/ywwg/following{/other_user}","gists_url":"https://api.github.com/users/ywwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ywwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ywwg/subscriptions","organizations_url":"https://api.github.com/users/ywwg/orgs","repos_url":"https://api.github.com/users/ywwg/repos","events_url":"https://api.github.com/users/ywwg/events{/privacy}","received_events_url":"https://api.github.com/users/ywwg/received_events","type":"User","site_admin":false},"body":"current trunk passes the sample rate into the process function.  get it from there","created_at":"2014-09-11T17:07:00Z","updated_at":"2014-09-11T17:07:00Z","html_url":"https://github.com/mixxxdj/mixxx/pull/337#discussion_r17433269","pull_request_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/337","_links":{"self":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/17433269"},"html":{"href":"https://github.com/mixxxdj/mixxx/pull/337#discussion_r17433269"},"pull_request":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/337"}}},"pull_request":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/337","id":21098416,"html_url":"https://github.com/mixxxdj/mixxx/pull/337","diff_url":"https://github.com/mixxxdj/mixxx/pull/337.diff","patch_url":"https://github.com/mixxxdj/mixxx/pull/337.patch","issue_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/337","number":337,"state":"open","locked":false,"title":"Goaslicer: WIP","user":{"login":"pwhelan","id":601645,"avatar_url":"https://avatars.githubusercontent.com/u/601645?v=2","gravatar_id":"886397ef021af76782c734b086e88e22","url":"https://api.github.com/users/pwhelan","html_url":"https://github.com/pwhelan","followers_url":"https://api.github.com/users/pwhelan/followers","following_url":"https://api.github.com/users/pwhelan/following{/other_user}","gists_url":"https://api.github.com/users/pwhelan/gists{/gist_id}","starred_url":"https://api.github.com/users/pwhelan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwhelan/subscriptions","organizations_url":"https://api.github.com/users/pwhelan/orgs","repos_url":"https://api.github.com/users/pwhelan/repos","events_url":"https://api.github.com/users/pwhelan/events{/privacy}","received_events_url":"https://api.github.com/users/pwhelan/received_events","type":"User","site_admin":false},"body":"This is a goa slicer effect (a gapper, basically). The last bit that needs to be done is to get the parameters to work smoothly. So far I have had no luck. The trickiest parameter is the period parameter since it sounds best when using values between 2 and 32 that are a power of two.\r\n\r\nDoes anyone have any suggestions? Any help would be great.\r\n","created_at":"2014-09-11T16:07:04Z","updated_at":"2014-09-11T17:07:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"40b3ab1048760831f801c96a6f25b74da10e270d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/337/commits","review_comments_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/337/comments","review_comment_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/337/comments","statuses_url":"https://api.github.com/repos/mixxxdj/mixxx/statuses/488a2b05f4ad0681e2da96e706048ad84631ef55","head":{"label":"pwhelan:goaslicer","ref":"goaslicer","sha":"488a2b05f4ad0681e2da96e706048ad84631ef55","user":{"login":"pwhelan","id":601645,"avatar_url":"https://avatars.githubusercontent.com/u/601645?v=2","gravatar_id":"886397ef021af76782c734b086e88e22","url":"https://api.github.com/users/pwhelan","html_url":"https://github.com/pwhelan","followers_url":"https://api.github.com/users/pwhelan/followers","following_url":"https://api.github.com/users/pwhelan/following{/other_user}","gists_url":"https://api.github.com/users/pwhelan/gists{/gist_id}","starred_url":"https://api.github.com/users/pwhelan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwhelan/subscriptions","organizations_url":"https://api.github.com/users/pwhelan/orgs","repos_url":"https://api.github.com/users/pwhelan/repos","events_url":"https://api.github.com/users/pwhelan/events{/privacy}","received_events_url":"https://api.github.com/users/pwhelan/received_events","type":"User","site_admin":false},"repo":{"id":20142445,"name":"mixxx","full_name":"pwhelan/mixxx","owner":{"login":"pwhelan","id":601645,"avatar_url":"https://avatars.githubusercontent.com/u/601645?v=2","gravatar_id":"886397ef021af76782c734b086e88e22","url":"https://api.github.com/users/pwhelan","html_url":"https://github.com/pwhelan","followers_url":"https://api.github.com/users/pwhelan/followers","following_url":"https://api.github.com/users/pwhelan/following{/other_user}","gists_url":"https://api.github.com/users/pwhelan/gists{/gist_id}","starred_url":"https://api.github.com/users/pwhelan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwhelan/subscriptions","organizations_url":"https://api.github.com/users/pwhelan/orgs","repos_url":"https://api.github.com/users/pwhelan/repos","events_url":"https://api.github.com/users/pwhelan/events{/privacy}","received_events_url":"https://api.github.com/users/pwhelan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pwhelan/mixxx","description":"Mixxx is Free DJ software that gives you everything you need to perform live mixes.","fork":true,"url":"https://api.github.com/repos/pwhelan/mixxx","forks_url":"https://api.github.com/repos/pwhelan/mixxx/forks","keys_url":"https://api.github.com/repos/pwhelan/mixxx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pwhelan/mixxx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pwhelan/mixxx/teams","hooks_url":"https://api.github.com/repos/pwhelan/mixxx/hooks","issue_events_url":"https://api.github.com/repos/pwhelan/mixxx/issues/events{/number}","events_url":"https://api.github.com/repos/pwhelan/mixxx/events","assignees_url":"https://api.github.com/repos/pwhelan/mixxx/assignees{/user}","branches_url":"https://api.github.com/repos/pwhelan/mixxx/branches{/branch}","tags_url":"https://api.github.com/repos/pwhelan/mixxx/tags","blobs_url":"https://api.github.com/repos/pwhelan/mixxx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pwhelan/mixxx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pwhelan/mixxx/git/refs{/sha}","trees_url":"https://api.github.com/repos/pwhelan/mixxx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pwhelan/mixxx/statuses/{sha}","languages_url":"https://api.github.com/repos/pwhelan/mixxx/languages","stargazers_url":"https://api.github.com/repos/pwhelan/mixxx/stargazers","contributors_url":"https://api.github.com/repos/pwhelan/mixxx/contributors","subscribers_url":"https://api.github.com/repos/pwhelan/mixxx/subscribers","subscription_url":"https://api.github.com/repos/pwhelan/mixxx/subscription","commits_url":"https://api.github.com/repos/pwhelan/mixxx/commits{/sha}","git_commits_url":"https://api.github.com/repos/pwhelan/mixxx/git/commits{/sha}","comments_url":"https://api.github.com/repos/pwhelan/mixxx/comments{/number}","issue_comment_url":"https://api.github.com/repos/pwhelan/mixxx/issues/comments/{number}","contents_url":"https://api.github.com/repos/pwhelan/mixxx/contents/{+path}","compare_url":"https://api.github.com/repos/pwhelan/mixxx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pwhelan/mixxx/merges","archive_url":"https://api.github.com/repos/pwhelan/mixxx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pwhelan/mixxx/downloads","issues_url":"https://api.github.com/repos/pwhelan/mixxx/issues{/number}","pulls_url":"https://api.github.com/repos/pwhelan/mixxx/pulls{/number}","milestones_url":"https://api.github.com/repos/pwhelan/mixxx/milestones{/number}","notifications_url":"https://api.github.com/repos/pwhelan/mixxx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pwhelan/mixxx/labels{/name}","releases_url":"https://api.github.com/repos/pwhelan/mixxx/releases{/id}","created_at":"2014-05-24T23:50:41Z","updated_at":"2014-06-13T09:16:12Z","pushed_at":"2014-09-11T16:04:47Z","git_url":"git://github.com/pwhelan/mixxx.git","ssh_url":"git@github.com:pwhelan/mixxx.git","clone_url":"https://github.com/pwhelan/mixxx.git","svn_url":"https://github.com/pwhelan/mixxx","homepage":"http://mixxx.org","size":220465,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mixxxdj:master","ref":"master","sha":"b17043912417e52f6d5dc701afd40dad326092ea","user":{"login":"mixxxdj","id":1743769,"avatar_url":"https://avatars.githubusercontent.com/u/1743769?v=2","gravatar_id":"c81bbd7f450afcdd452e0ccf9294868f","url":"https://api.github.com/users/mixxxdj","html_url":"https://github.com/mixxxdj","followers_url":"https://api.github.com/users/mixxxdj/followers","following_url":"https://api.github.com/users/mixxxdj/following{/other_user}","gists_url":"https://api.github.com/users/mixxxdj/gists{/gist_id}","starred_url":"https://api.github.com/users/mixxxdj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixxxdj/subscriptions","organizations_url":"https://api.github.com/users/mixxxdj/orgs","repos_url":"https://api.github.com/users/mixxxdj/repos","events_url":"https://api.github.com/users/mixxxdj/events{/privacy}","received_events_url":"https://api.github.com/users/mixxxdj/received_events","type":"Organization","site_admin":false},"repo":{"id":10126031,"name":"mixxx","full_name":"mixxxdj/mixxx","owner":{"login":"mixxxdj","id":1743769,"avatar_url":"https://avatars.githubusercontent.com/u/1743769?v=2","gravatar_id":"c81bbd7f450afcdd452e0ccf9294868f","url":"https://api.github.com/users/mixxxdj","html_url":"https://github.com/mixxxdj","followers_url":"https://api.github.com/users/mixxxdj/followers","following_url":"https://api.github.com/users/mixxxdj/following{/other_user}","gists_url":"https://api.github.com/users/mixxxdj/gists{/gist_id}","starred_url":"https://api.github.com/users/mixxxdj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixxxdj/subscriptions","organizations_url":"https://api.github.com/users/mixxxdj/orgs","repos_url":"https://api.github.com/users/mixxxdj/repos","events_url":"https://api.github.com/users/mixxxdj/events{/privacy}","received_events_url":"https://api.github.com/users/mixxxdj/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mixxxdj/mixxx","description":"Mixxx is Free DJ software that gives you everything you need to perform live mixes.","fork":false,"url":"https://api.github.com/repos/mixxxdj/mixxx","forks_url":"https://api.github.com/repos/mixxxdj/mixxx/forks","keys_url":"https://api.github.com/repos/mixxxdj/mixxx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mixxxdj/mixxx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mixxxdj/mixxx/teams","hooks_url":"https://api.github.com/repos/mixxxdj/mixxx/hooks","issue_events_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/events{/number}","events_url":"https://api.github.com/repos/mixxxdj/mixxx/events","assignees_url":"https://api.github.com/repos/mixxxdj/mixxx/assignees{/user}","branches_url":"https://api.github.com/repos/mixxxdj/mixxx/branches{/branch}","tags_url":"https://api.github.com/repos/mixxxdj/mixxx/tags","blobs_url":"https://api.github.com/repos/mixxxdj/mixxx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mixxxdj/mixxx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mixxxdj/mixxx/git/refs{/sha}","trees_url":"https://api.github.com/repos/mixxxdj/mixxx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mixxxdj/mixxx/statuses/{sha}","languages_url":"https://api.github.com/repos/mixxxdj/mixxx/languages","stargazers_url":"https://api.github.com/repos/mixxxdj/mixxx/stargazers","contributors_url":"https://api.github.com/repos/mixxxdj/mixxx/contributors","subscribers_url":"https://api.github.com/repos/mixxxdj/mixxx/subscribers","subscription_url":"https://api.github.com/repos/mixxxdj/mixxx/subscription","commits_url":"https://api.github.com/repos/mixxxdj/mixxx/commits{/sha}","git_commits_url":"https://api.github.com/repos/mixxxdj/mixxx/git/commits{/sha}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/comments{/number}","issue_comment_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/comments/{number}","contents_url":"https://api.github.com/repos/mixxxdj/mixxx/contents/{+path}","compare_url":"https://api.github.com/repos/mixxxdj/mixxx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mixxxdj/mixxx/merges","archive_url":"https://api.github.com/repos/mixxxdj/mixxx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mixxxdj/mixxx/downloads","issues_url":"https://api.github.com/repos/mixxxdj/mixxx/issues{/number}","pulls_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls{/number}","milestones_url":"https://api.github.com/repos/mixxxdj/mixxx/milestones{/number}","notifications_url":"https://api.github.com/repos/mixxxdj/mixxx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mixxxdj/mixxx/labels{/name}","releases_url":"https://api.github.com/repos/mixxxdj/mixxx/releases{/id}","created_at":"2013-05-17T15:14:38Z","updated_at":"2014-09-09T14:10:40Z","pushed_at":"2014-09-11T09:48:19Z","git_url":"git://github.com/mixxxdj/mixxx.git","ssh_url":"git@github.com:mixxxdj/mixxx.git","clone_url":"https://github.com/mixxxdj/mixxx.git","svn_url":"https://github.com/mixxxdj/mixxx","homepage":"http://mixxx.org","size":300283,"stargazers_count":162,"watchers_count":162,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":143,"mirror_url":null,"open_issues_count":25,"forks":143,"open_issues":25,"watchers":162,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/337"},"html":{"href":"https://github.com/mixxxdj/mixxx/pull/337"},"issue":{"href":"https://api.github.com/repos/mixxxdj/mixxx/issues/337"},"comments":{"href":"https://api.github.com/repos/mixxxdj/mixxx/issues/337/comments"},"review_comments":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/337/comments"},"review_comment":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/337/commits"},"statuses":{"href":"https://api.github.com/repos/mixxxdj/mixxx/statuses/488a2b05f4ad0681e2da96e706048ad84631ef55"}}}}