GitHub PullRequestEvent at 2014-09-30 20:49:58
Repository: furious
Actor: markshaule-wf
Payload: {"action":"opened","number":155,"pull_request":{"url":"https://api.github.com/repos/WebFilings/furious/pulls/155","id":22034225,"html_url":"https://github.com/WebFilings/furious/pull/155","diff_url":"https://github.com/WebFilings/furious/pull/155.diff","patch_url":"https://github.com/WebFilings/furious/pull/155.patch","issue_url":"https://api.github.com/repos/WebFilings/furious/issues/155","number":155,"state":"open","locked":false,"title":"transient_error_retry - Retry transient errors when attempting to insert_tasks, and re-raise if the reinsert fails.","user":{"login":"markshaule-wf","id":4356496,"avatar_url":"https://avatars.githubusercontent.com/u/4356496?v=2","gravatar_id":"","url":"https://api.github.com/users/markshaule-wf","html_url":"https://github.com/markshaule-wf","followers_url":"https://api.github.com/users/markshaule-wf/followers","following_url":"https://api.github.com/users/markshaule-wf/following{/other_user}","gists_url":"https://api.github.com/users/markshaule-wf/gists{/gist_id}","starred_url":"https://api.github.com/users/markshaule-wf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markshaule-wf/subscriptions","organizations_url":"https://api.github.com/users/markshaule-wf/orgs","repos_url":"https://api.github.com/users/markshaule-wf/repos","events_url":"https://api.github.com/users/markshaule-wf/events{/privacy}","received_events_url":"https://api.github.com/users/markshaule-wf/received_events","type":"User","site_admin":false},"body":"Instead of silently failing on a TransientError on task inserts, we check the options to see if we should retry the failure (after a delay).  If the retry fails, we re-raise.\r\n\r\nCurrently, the default option is to retry.  I can't think of a scenario that the called would not want to have the errors retry, or at least trigger an error.\r\nAs a side effect, this may break custom implementations of ```_insert_tasks``` since we have added a parameter.\r\n\r\n@beaulyddon-wf @robertkluin-wf @johnlockwood-wf @tannermiller-wf @rosshendrickson-wf @macleodbroad-wf @tylertreat-wf\r\n\r\nFYI: @jasonaguilon-wf @erikpetersen-wf \r\n\r\n","created_at":"2014-09-30T20:49:57Z","updated_at":"2014-09-30T20:49:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/WebFilings/furious/pulls/155/commits","review_comments_url":"https://api.github.com/repos/WebFilings/furious/pulls/155/comments","review_comment_url":"https://api.github.com/repos/WebFilings/furious/pulls/comments/{number}","comments_url":"https://api.github.com/repos/WebFilings/furious/issues/155/comments","statuses_url":"https://api.github.com/repos/WebFilings/furious/statuses/cbcb7066b34272e2bf99d298b7c8f9429e829555","head":{"label":"markshaule-wf:transient_error_retry","ref":"transient_error_retry","sha":"cbcb7066b34272e2bf99d298b7c8f9429e829555","user":{"login":"markshaule-wf","id":4356496,"avatar_url":"https://avatars.githubusercontent.com/u/4356496?v=2","gravatar_id":"","url":"https://api.github.com/users/markshaule-wf","html_url":"https://github.com/markshaule-wf","followers_url":"https://api.github.com/users/markshaule-wf/followers","following_url":"https://api.github.com/users/markshaule-wf/following{/other_user}","gists_url":"https://api.github.com/users/markshaule-wf/gists{/gist_id}","starred_url":"https://api.github.com/users/markshaule-wf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markshaule-wf/subscriptions","organizations_url":"https://api.github.com/users/markshaule-wf/orgs","repos_url":"https://api.github.com/users/markshaule-wf/repos","events_url":"https://api.github.com/users/markshaule-wf/events{/privacy}","received_events_url":"https://api.github.com/users/markshaule-wf/received_events","type":"User","site_admin":false},"repo":{"id":22078853,"name":"furious","full_name":"markshaule-wf/furious","owner":{"login":"markshaule-wf","id":4356496,"avatar_url":"https://avatars.githubusercontent.com/u/4356496?v=2","gravatar_id":"","url":"https://api.github.com/users/markshaule-wf","html_url":"https://github.com/markshaule-wf","followers_url":"https://api.github.com/users/markshaule-wf/followers","following_url":"https://api.github.com/users/markshaule-wf/following{/other_user}","gists_url":"https://api.github.com/users/markshaule-wf/gists{/gist_id}","starred_url":"https://api.github.com/users/markshaule-wf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markshaule-wf/subscriptions","organizations_url":"https://api.github.com/users/markshaule-wf/orgs","repos_url":"https://api.github.com/users/markshaule-wf/repos","events_url":"https://api.github.com/users/markshaule-wf/events{/privacy}","received_events_url":"https://api.github.com/users/markshaule-wf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/markshaule-wf/furious","description":"Fast and modular async task library for Google App Engine.","fork":true,"url":"https://api.github.com/repos/markshaule-wf/furious","forks_url":"https://api.github.com/repos/markshaule-wf/furious/forks","keys_url":"https://api.github.com/repos/markshaule-wf/furious/keys{/key_id}","collaborators_url":"https://api.github.com/repos/markshaule-wf/furious/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/markshaule-wf/furious/teams","hooks_url":"https://api.github.com/repos/markshaule-wf/furious/hooks","issue_events_url":"https://api.github.com/repos/markshaule-wf/furious/issues/events{/number}","events_url":"https://api.github.com/repos/markshaule-wf/furious/events","assignees_url":"https://api.github.com/repos/markshaule-wf/furious/assignees{/user}","branches_url":"https://api.github.com/repos/markshaule-wf/furious/branches{/branch}","tags_url":"https://api.github.com/repos/markshaule-wf/furious/tags","blobs_url":"https://api.github.com/repos/markshaule-wf/furious/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/markshaule-wf/furious/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/markshaule-wf/furious/git/refs{/sha}","trees_url":"https://api.github.com/repos/markshaule-wf/furious/git/trees{/sha}","statuses_url":"https://api.github.com/repos/markshaule-wf/furious/statuses/{sha}","languages_url":"https://api.github.com/repos/markshaule-wf/furious/languages","stargazers_url":"https://api.github.com/repos/markshaule-wf/furious/stargazers","contributors_url":"https://api.github.com/repos/markshaule-wf/furious/contributors","subscribers_url":"https://api.github.com/repos/markshaule-wf/furious/subscribers","subscription_url":"https://api.github.com/repos/markshaule-wf/furious/subscription","commits_url":"https://api.github.com/repos/markshaule-wf/furious/commits{/sha}","git_commits_url":"https://api.github.com/repos/markshaule-wf/furious/git/commits{/sha}","comments_url":"https://api.github.com/repos/markshaule-wf/furious/comments{/number}","issue_comment_url":"https://api.github.com/repos/markshaule-wf/furious/issues/comments/{number}","contents_url":"https://api.github.com/repos/markshaule-wf/furious/contents/{+path}","compare_url":"https://api.github.com/repos/markshaule-wf/furious/compare/{base}...{head}","merges_url":"https://api.github.com/repos/markshaule-wf/furious/merges","archive_url":"https://api.github.com/repos/markshaule-wf/furious/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/markshaule-wf/furious/downloads","issues_url":"https://api.github.com/repos/markshaule-wf/furious/issues{/number}","pulls_url":"https://api.github.com/repos/markshaule-wf/furious/pulls{/number}","milestones_url":"https://api.github.com/repos/markshaule-wf/furious/milestones{/number}","notifications_url":"https://api.github.com/repos/markshaule-wf/furious/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/markshaule-wf/furious/labels{/name}","releases_url":"https://api.github.com/repos/markshaule-wf/furious/releases{/id}","created_at":"2014-07-21T20:24:51Z","updated_at":"2014-06-27T19:48:51Z","pushed_at":"2014-09-30T20:36:09Z","git_url":"git://github.com/markshaule-wf/furious.git","ssh_url":"git@github.com:markshaule-wf/furious.git","clone_url":"https://github.com/markshaule-wf/furious.git","svn_url":"https://github.com/markshaule-wf/furious","homepage":null,"size":899,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"WebFilings:master","ref":"master","sha":"f32c34114699ea64e6a4b030aecbb72807ddf5c1","user":{"login":"WebFilings","id":1087529,"avatar_url":"https://avatars.githubusercontent.com/u/1087529?v=2","gravatar_id":"","url":"https://api.github.com/users/WebFilings","html_url":"https://github.com/WebFilings","followers_url":"https://api.github.com/users/WebFilings/followers","following_url":"https://api.github.com/users/WebFilings/following{/other_user}","gists_url":"https://api.github.com/users/WebFilings/gists{/gist_id}","starred_url":"https://api.github.com/users/WebFilings/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebFilings/subscriptions","organizations_url":"https://api.github.com/users/WebFilings/orgs","repos_url":"https://api.github.com/users/WebFilings/repos","events_url":"https://api.github.com/users/WebFilings/events{/privacy}","received_events_url":"https://api.github.com/users/WebFilings/received_events","type":"Organization","site_admin":false},"repo":{"id":5531034,"name":"furious","full_name":"WebFilings/furious","owner":{"login":"WebFilings","id":1087529,"avatar_url":"https://avatars.githubusercontent.com/u/1087529?v=2","gravatar_id":"","url":"https://api.github.com/users/WebFilings","html_url":"https://github.com/WebFilings","followers_url":"https://api.github.com/users/WebFilings/followers","following_url":"https://api.github.com/users/WebFilings/following{/other_user}","gists_url":"https://api.github.com/users/WebFilings/gists{/gist_id}","starred_url":"https://api.github.com/users/WebFilings/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebFilings/subscriptions","organizations_url":"https://api.github.com/users/WebFilings/orgs","repos_url":"https://api.github.com/users/WebFilings/repos","events_url":"https://api.github.com/users/WebFilings/events{/privacy}","received_events_url":"https://api.github.com/users/WebFilings/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WebFilings/furious","description":"Fast and modular async task library for Google App Engine.","fork":false,"url":"https://api.github.com/repos/WebFilings/furious","forks_url":"https://api.github.com/repos/WebFilings/furious/forks","keys_url":"https://api.github.com/repos/WebFilings/furious/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WebFilings/furious/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WebFilings/furious/teams","hooks_url":"https://api.github.com/repos/WebFilings/furious/hooks","issue_events_url":"https://api.github.com/repos/WebFilings/furious/issues/events{/number}","events_url":"https://api.github.com/repos/WebFilings/furious/events","assignees_url":"https://api.github.com/repos/WebFilings/furious/assignees{/user}","branches_url":"https://api.github.com/repos/WebFilings/furious/branches{/branch}","tags_url":"https://api.github.com/repos/WebFilings/furious/tags","blobs_url":"https://api.github.com/repos/WebFilings/furious/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WebFilings/furious/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WebFilings/furious/git/refs{/sha}","trees_url":"https://api.github.com/repos/WebFilings/furious/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WebFilings/furious/statuses/{sha}","languages_url":"https://api.github.com/repos/WebFilings/furious/languages","stargazers_url":"https://api.github.com/repos/WebFilings/furious/stargazers","contributors_url":"https://api.github.com/repos/WebFilings/furious/contributors","subscribers_url":"https://api.github.com/repos/WebFilings/furious/subscribers","subscription_url":"https://api.github.com/repos/WebFilings/furious/subscription","commits_url":"https://api.github.com/repos/WebFilings/furious/commits{/sha}","git_commits_url":"https://api.github.com/repos/WebFilings/furious/git/commits{/sha}","comments_url":"https://api.github.com/repos/WebFilings/furious/comments{/number}","issue_comment_url":"https://api.github.com/repos/WebFilings/furious/issues/comments/{number}","contents_url":"https://api.github.com/repos/WebFilings/furious/contents/{+path}","compare_url":"https://api.github.com/repos/WebFilings/furious/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WebFilings/furious/merges","archive_url":"https://api.github.com/repos/WebFilings/furious/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WebFilings/furious/downloads","issues_url":"https://api.github.com/repos/WebFilings/furious/issues{/number}","pulls_url":"https://api.github.com/repos/WebFilings/furious/pulls{/number}","milestones_url":"https://api.github.com/repos/WebFilings/furious/milestones{/number}","notifications_url":"https://api.github.com/repos/WebFilings/furious/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WebFilings/furious/labels{/name}","releases_url":"https://api.github.com/repos/WebFilings/furious/releases{/id}","created_at":"2012-08-23T19:08:25Z","updated_at":"2014-07-30T20:20:13Z","pushed_at":"2014-07-31T03:31:32Z","git_url":"git://github.com/WebFilings/furious.git","ssh_url":"git@github.com:WebFilings/furious.git","clone_url":"https://github.com/WebFilings/furious.git","svn_url":"https://github.com/WebFilings/furious","homepage":null,"size":2732,"stargazers_count":27,"watchers_count":27,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":20,"forks":25,"open_issues":20,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/WebFilings/furious/pulls/155"},"html":{"href":"https://github.com/WebFilings/furious/pull/155"},"issue":{"href":"https://api.github.com/repos/WebFilings/furious/issues/155"},"comments":{"href":"https://api.github.com/repos/WebFilings/furious/issues/155/comments"},"review_comments":{"href":"https://api.github.com/repos/WebFilings/furious/pulls/155/comments"},"review_comment":{"href":"https://api.github.com/repos/WebFilings/furious/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/WebFilings/furious/pulls/155/commits"},"statuses":{"href":"https://api.github.com/repos/WebFilings/furious/statuses/cbcb7066b34272e2bf99d298b7c8f9429e829555"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":64,"deletions":22,"changed_files":2}}