GitHub PullRequestReviewCommentEvent at 2014-04-24 14:19:03
Repository: mf-geoadmin3
Actor: gjn
Payload: {"comment":{"url":"https://api.github.com/repos/geoadmin/mf-geoadmin3/pulls/comments/11950932","id":11950932,"diff_hunk":"@@ -467,14 +562,20 @@\n               });\n \n               //if search parameter specified, start it with a search parameter\n-              var searchParam = gaPermalink.getParams()['swisssearch'];\n+              var searchParam = gaPermalink.getParams().swisssearch;\n               if (angular.isDefined(searchParam) &&\n                   searchParam.length > 0) {\n                 var unregister = scope.$on('gaLayersChange', function() {\n+                  // At this point layers are not added to the map yet\n+                  var unregisterLayers = scope.$watchCollection('layers',\n+                      function(layers) {\n+                    triggerSearch(FEATURES);\n+                    triggerSearch(LAYERS);","path":"src/components/search/SearchDirective.js","position":388,"original_position":388,"commit_id":"84a31c581cfc5767b51a38a6696b214bb9289e21","original_commit_id":"84a31c581cfc5767b51a38a6696b214bb9289e21","user":{"login":"gjn","id":2572317,"avatar_url":"https://avatars.githubusercontent.com/u/2572317?","gravatar_id":"6856d9511ef090dc14eb7d14bcd19ffc","url":"https://api.github.com/users/gjn","html_url":"https://github.com/gjn","followers_url":"https://api.github.com/users/gjn/followers","following_url":"https://api.github.com/users/gjn/following{/other_user}","gists_url":"https://api.github.com/users/gjn/gists{/gist_id}","starred_url":"https://api.github.com/users/gjn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gjn/subscriptions","organizations_url":"https://api.github.com/users/gjn/orgs","repos_url":"https://api.github.com/users/gjn/repos","events_url":"https://api.github.com/users/gjn/events{/privacy}","received_events_url":"https://api.github.com/users/gjn/received_events","type":"User","site_admin":false},"body":"I thing the triggerSearch for LAYERS can be put outside (as it was before).","created_at":"2014-04-24T14:19:03Z","updated_at":"2014-04-24T14:19:03Z","html_url":"https://github.com/geoadmin/mf-geoadmin3/pull/1345#discussion_r11950932","pull_request_url":"https://api.github.com/repos/geoadmin/mf-geoadmin3/pulls/1345","_links":{"self":{"href":"https://api.github.com/repos/geoadmin/mf-geoadmin3/pulls/comments/11950932"},"html":{"href":"https://github.com/geoadmin/mf-geoadmin3/pull/1345#discussion_r11950932"},"pull_request":{"href":"https://api.github.com/repos/geoadmin/mf-geoadmin3/pulls/1345"}}}}