GitHub PullRequestReviewCommentEvent at 2014-02-25 07:46:42
Repository: shib-cas-authn2
Actor: mmoayyed
Payload: {"comment":{"url":"https://api.github.com/repos/UniconLabs/shib-cas-authn2/pulls/comments/10026769","id":10026769,"diff_hunk":"@@ -45,53 +47,53 @@\n      * <li>cas.server\r\n      * <li>idp.server\r\n      */\r\n-    public CasLoginHandler(String propertiesFile) {\r\n+    public CasLoginHandler(final String propertiesFile) {\r\n         Properties props = new Properties();\r\n         try {\r\n             try {\r\n                 FileReader reader = new FileReader(new File(propertiesFile));\r\n                 props.load(reader);\r\n                 reader.close();\r","path":"idp-cas-invoker/src/main/java/net/unicon/idp/authn/provider/CasLoginHandler.java","position":35,"original_position":35,"commit_id":"8f8588f2243433d22a27d41e5f684c408255c1a4","original_commit_id":"8f8588f2243433d22a27d41e5f684c408255c1a4","user":{"login":"mmoayyed","id":1205228,"avatar_url":"https://gravatar.com/avatar/c9007ddcff7509416844cd4849d64009?d=https%3A%2F%2Fidenticons.github.com%2F174d816d54714361b2c174201dfbe39a.png&r=x","gravatar_id":"c9007ddcff7509416844cd4849d64009","url":"https://api.github.com/users/mmoayyed","html_url":"https://github.com/mmoayyed","followers_url":"https://api.github.com/users/mmoayyed/followers","following_url":"https://api.github.com/users/mmoayyed/following{/other_user}","gists_url":"https://api.github.com/users/mmoayyed/gists{/gist_id}","starred_url":"https://api.github.com/users/mmoayyed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmoayyed/subscriptions","organizations_url":"https://api.github.com/users/mmoayyed/orgs","repos_url":"https://api.github.com/users/mmoayyed/repos","events_url":"https://api.github.com/users/mmoayyed/events{/privacy}","received_events_url":"https://api.github.com/users/mmoayyed/received_events","type":"User","site_admin":false},"body":"Lets move close() to a finally block","created_at":"2014-02-25T07:46:42Z","updated_at":"2014-02-25T07:46:42Z","html_url":"https://github.com/UniconLabs/shib-cas-authn2/pull/5#discussion_r10026769","pull_request_url":"https://api.github.com/repos/UniconLabs/shib-cas-authn2/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/UniconLabs/shib-cas-authn2/pulls/comments/10026769"},"html":{"href":"https://github.com/UniconLabs/shib-cas-authn2/pull/5#discussion_r10026769"},"pull_request":{"href":"https://api.github.com/repos/UniconLabs/shib-cas-authn2/pulls/5"}}}}