GitHub PullRequestReviewCommentEvent at 2014-02-19 08:00:13
Repository: gaia
Actor: fabi1cazenave
Payload: {"comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/9856901","id":9856901,"diff_hunk":"@@ -35,20 +49,52 @@\n     var settings = Settings.mozSettings;\n     var lock = settings.createLock();\n \n-    function showStkEntry(menu) {\n-      if (!menu || !menu.items ||\n-        (menu.items.length == 1 && menu.items[0] === null)) {\n+    function showStkEntries(menu) {\n+      DUMP('STK cached menu: ', menu);\n+      if (!menu || typeof(menu) !== 'object' || Object.keys(menu).length == 0) {","path":"apps/settings/js/icc_menu.js","position":57,"original_position":57,"commit_id":"4bca76ea223d226d31d9c5d26aef32ac3cc888b2","original_commit_id":"4bca76ea223d226d31d9c5d26aef32ac3cc888b2","user":{"login":"fabi1cazenave","id":457778,"avatar_url":"https://gravatar.com/avatar/aec50e19b6e10e548965786197d4e620?d=https%3A%2F%2Fidenticons.github.com%2F3f0d47ccd722e53ffca16d2f13cf0f1a.png&r=x","gravatar_id":"aec50e19b6e10e548965786197d4e620","url":"https://api.github.com/users/fabi1cazenave","html_url":"https://github.com/fabi1cazenave","followers_url":"https://api.github.com/users/fabi1cazenave/followers","following_url":"https://api.github.com/users/fabi1cazenave/following{/other_user}","gists_url":"https://api.github.com/users/fabi1cazenave/gists{/gist_id}","starred_url":"https://api.github.com/users/fabi1cazenave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabi1cazenave/subscriptions","organizations_url":"https://api.github.com/users/fabi1cazenave/orgs","repos_url":"https://api.github.com/users/fabi1cazenave/repos","events_url":"https://api.github.com/users/fabi1cazenave/events{/privacy}","received_events_url":"https://api.github.com/users/fabi1cazenave/received_events","type":"User","site_admin":false},"body":"nit: `typeof` is an operator, you don’t need any parenthesis around `menu`","created_at":"2014-02-19T08:00:13Z","updated_at":"2014-02-19T08:00:13Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/15532#discussion_r9856901","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/15532","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/9856901"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/15532#discussion_r9856901"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/15532"}}}}