GitHub PullRequestReviewCommentEvent at 2014-10-02 15:57:50
Repository: tideline
Actor: jebeck
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/tidepool-org/tideline/pulls/comments/18348316","id":18348316,"diff_hunk":"@@ -25,6 +25,15 @@ var log = require('bows')('BGUtil');\n function BGUtil(data, opts) {\n \n   opts = opts || {};\n+  var defaults = {\n+    categories: {","path":"js/data/bgutil.js","position":5,"original_position":5,"commit_id":"f85e17134635c259bfe3874326ed84b7b530bee5","original_commit_id":"f85e17134635c259bfe3874326ed84b7b530bee5","user":{"login":"jebeck","id":1588547,"avatar_url":"https://avatars.githubusercontent.com/u/1588547?v=2","gravatar_id":"","url":"https://api.github.com/users/jebeck","html_url":"https://github.com/jebeck","followers_url":"https://api.github.com/users/jebeck/followers","following_url":"https://api.github.com/users/jebeck/following{/other_user}","gists_url":"https://api.github.com/users/jebeck/gists{/gist_id}","starred_url":"https://api.github.com/users/jebeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jebeck/subscriptions","organizations_url":"https://api.github.com/users/jebeck/orgs","repos_url":"https://api.github.com/users/jebeck/repos","events_url":"https://api.github.com/users/jebeck/events{/privacy}","received_events_url":"https://api.github.com/users/jebeck/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2014-10-02T15:57:50Z","updated_at":"2014-10-02T15:57:50Z","html_url":"https://github.com/tidepool-org/tideline/pull/176#discussion_r18348316","pull_request_url":"https://api.github.com/repos/tidepool-org/tideline/pulls/176","_links":{"self":{"href":"https://api.github.com/repos/tidepool-org/tideline/pulls/comments/18348316"},"html":{"href":"https://github.com/tidepool-org/tideline/pull/176#discussion_r18348316"},"pull_request":{"href":"https://api.github.com/repos/tidepool-org/tideline/pulls/176"}}},"pull_request":{"url":"https://api.github.com/repos/tidepool-org/tideline/pulls/176","id":21190122,"html_url":"https://github.com/tidepool-org/tideline/pull/176","diff_url":"https://github.com/tidepool-org/tideline/pull/176.diff","patch_url":"https://github.com/tidepool-org/tideline/pull/176.patch","issue_url":"https://api.github.com/repos/tidepool-org/tideline/issues/176","number":176,"state":"open","locked":false,"title":"nurse shark, first draft","user":{"login":"jebeck","id":1588547,"avatar_url":"https://avatars.githubusercontent.com/u/1588547?v=2","gravatar_id":"","url":"https://api.github.com/users/jebeck","html_url":"https://github.com/jebeck","followers_url":"https://api.github.com/users/jebeck/followers","following_url":"https://api.github.com/users/jebeck/following{/other_user}","gists_url":"https://api.github.com/users/jebeck/gists{/gist_id}","starred_url":"https://api.github.com/users/jebeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jebeck/subscriptions","organizations_url":"https://api.github.com/users/jebeck/orgs","repos_url":"https://api.github.com/users/jebeck/repos","events_url":"https://api.github.com/users/jebeck/events{/privacy}","received_events_url":"https://api.github.com/users/jebeck/received_events","type":"User","site_admin":false},"body":"Open for feedback, but *not* for merge. I'll be working on this branch as well to update the viz code for the new data model.\r\n\r\nThe only things you can test here presently are validation with the node script `dev/validate-with-timing.js` and the tests for nurse shark, `test/nurseshark_test.js`. The visualization itself is broken, as expected.\r\n\r\n@cheddar I added a couple of things that were missing to the schematron, as per my comment on the Trello card.","created_at":"2014-09-13T06:32:34Z","updated_at":"2014-10-02T15:57:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b7429e2c8437661082c7b57ec6817a9467a7a794","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tidepool-org/tideline/pulls/176/commits","review_comments_url":"https://api.github.com/repos/tidepool-org/tideline/pulls/176/comments","review_comment_url":"https://api.github.com/repos/tidepool-org/tideline/pulls/comments/{number}","comments_url":"https://api.github.com/repos/tidepool-org/tideline/issues/176/comments","statuses_url":"https://api.github.com/repos/tidepool-org/tideline/statuses/f85e17134635c259bfe3874326ed84b7b530bee5","head":{"label":"tidepool-org:jebeck/nurse-shark","ref":"jebeck/nurse-shark","sha":"f85e17134635c259bfe3874326ed84b7b530bee5","user":{"login":"tidepool-org","id":4390820,"avatar_url":"https://avatars.githubusercontent.com/u/4390820?v=2","gravatar_id":"","url":"https://api.github.com/users/tidepool-org","html_url":"https://github.com/tidepool-org","followers_url":"https://api.github.com/users/tidepool-org/followers","following_url":"https://api.github.com/users/tidepool-org/following{/other_user}","gists_url":"https://api.github.com/users/tidepool-org/gists{/gist_id}","starred_url":"https://api.github.com/users/tidepool-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tidepool-org/subscriptions","organizations_url":"https://api.github.com/users/tidepool-org/orgs","repos_url":"https://api.github.com/users/tidepool-org/repos","events_url":"https://api.github.com/users/tidepool-org/events{/privacy}","received_events_url":"https://api.github.com/users/tidepool-org/received_events","type":"Organization","site_admin":false},"repo":{"id":15691740,"name":"tideline","full_name":"tidepool-org/tideline","owner":{"login":"tidepool-org","id":4390820,"avatar_url":"https://avatars.githubusercontent.com/u/4390820?v=2","gravatar_id":"","url":"https://api.github.com/users/tidepool-org","html_url":"https://github.com/tidepool-org","followers_url":"https://api.github.com/users/tidepool-org/followers","following_url":"https://api.github.com/users/tidepool-org/following{/other_user}","gists_url":"https://api.github.com/users/tidepool-org/gists{/gist_id}","starred_url":"https://api.github.com/users/tidepool-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tidepool-org/subscriptions","organizations_url":"https://api.github.com/users/tidepool-org/orgs","repos_url":"https://api.github.com/users/tidepool-org/repos","events_url":"https://api.github.com/users/tidepool-org/events{/privacy}","received_events_url":"https://api.github.com/users/tidepool-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tidepool-org/tideline","description":"","fork":false,"url":"https://api.github.com/repos/tidepool-org/tideline","forks_url":"https://api.github.com/repos/tidepool-org/tideline/forks","keys_url":"https://api.github.com/repos/tidepool-org/tideline/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tidepool-org/tideline/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tidepool-org/tideline/teams","hooks_url":"https://api.github.com/repos/tidepool-org/tideline/hooks","issue_events_url":"https://api.github.com/repos/tidepool-org/tideline/issues/events{/number}","events_url":"https://api.github.com/repos/tidepool-org/tideline/events","assignees_url":"https://api.github.com/repos/tidepool-org/tideline/assignees{/user}","branches_url":"https://api.github.com/repos/tidepool-org/tideline/branches{/branch}","tags_url":"https://api.github.com/repos/tidepool-org/tideline/tags","blobs_url":"https://api.github.com/repos/tidepool-org/tideline/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tidepool-org/tideline/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tidepool-org/tideline/git/refs{/sha}","trees_url":"https://api.github.com/repos/tidepool-org/tideline/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tidepool-org/tideline/statuses/{sha}","languages_url":"https://api.github.com/repos/tidepool-org/tideline/languages","stargazers_url":"https://api.github.com/repos/tidepool-org/tideline/stargazers","contributors_url":"https://api.github.com/repos/tidepool-org/tideline/contributors","subscribers_url":"https://api.github.com/repos/tidepool-org/tideline/subscribers","subscription_url":"https://api.github.com/repos/tidepool-org/tideline/subscription","commits_url":"https://api.github.com/repos/tidepool-org/tideline/commits{/sha}","git_commits_url":"https://api.github.com/repos/tidepool-org/tideline/git/commits{/sha}","comments_url":"https://api.github.com/repos/tidepool-org/tideline/comments{/number}","issue_comment_url":"https://api.github.com/repos/tidepool-org/tideline/issues/comments/{number}","contents_url":"https://api.github.com/repos/tidepool-org/tideline/contents/{+path}","compare_url":"https://api.github.com/repos/tidepool-org/tideline/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tidepool-org/tideline/merges","archive_url":"https://api.github.com/repos/tidepool-org/tideline/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tidepool-org/tideline/downloads","issues_url":"https://api.github.com/repos/tidepool-org/tideline/issues{/number}","pulls_url":"https://api.github.com/repos/tidepool-org/tideline/pulls{/number}","milestones_url":"https://api.github.com/repos/tidepool-org/tideline/milestones{/number}","notifications_url":"https://api.github.com/repos/tidepool-org/tideline/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tidepool-org/tideline/labels{/name}","releases_url":"https://api.github.com/repos/tidepool-org/tideline/releases{/id}","created_at":"2014-01-07T01:22:13Z","updated_at":"2014-09-20T23:14:00Z","pushed_at":"2014-10-02T15:49:53Z","git_url":"git://github.com/tidepool-org/tideline.git","ssh_url":"git@github.com:tidepool-org/tideline.git","clone_url":"https://github.com/tidepool-org/tideline.git","svn_url":"https://github.com/tidepool-org/tideline","homepage":"","size":40162,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"open_issues_count":18,"forks":4,"open_issues":18,"watchers":10,"default_branch":"master"}},"base":{"label":"tidepool-org:master","ref":"master","sha":"3dc76db78cf2f0b7a7631ed97d32f68a6c862067","user":{"login":"tidepool-org","id":4390820,"avatar_url":"https://avatars.githubusercontent.com/u/4390820?v=2","gravatar_id":"","url":"https://api.github.com/users/tidepool-org","html_url":"https://github.com/tidepool-org","followers_url":"https://api.github.com/users/tidepool-org/followers","following_url":"https://api.github.com/users/tidepool-org/following{/other_user}","gists_url":"https://api.github.com/users/tidepool-org/gists{/gist_id}","starred_url":"https://api.github.com/users/tidepool-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tidepool-org/subscriptions","organizations_url":"https://api.github.com/users/tidepool-org/orgs","repos_url":"https://api.github.com/users/tidepool-org/repos","events_url":"https://api.github.com/users/tidepool-org/events{/privacy}","received_events_url":"https://api.github.com/users/tidepool-org/received_events","type":"Organization","site_admin":false},"repo":{"id":15691740,"name":"tideline","full_name":"tidepool-org/tideline","owner":{"login":"tidepool-org","id":4390820,"avatar_url":"https://avatars.githubusercontent.com/u/4390820?v=2","gravatar_id":"","url":"https://api.github.com/users/tidepool-org","html_url":"https://github.com/tidepool-org","followers_url":"https://api.github.com/users/tidepool-org/followers","following_url":"https://api.github.com/users/tidepool-org/following{/other_user}","gists_url":"https://api.github.com/users/tidepool-org/gists{/gist_id}","starred_url":"https://api.github.com/users/tidepool-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tidepool-org/subscriptions","organizations_url":"https://api.github.com/users/tidepool-org/orgs","repos_url":"https://api.github.com/users/tidepool-org/repos","events_url":"https://api.github.com/users/tidepool-org/events{/privacy}","received_events_url":"https://api.github.com/users/tidepool-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tidepool-org/tideline","description":"","fork":false,"url":"https://api.github.com/repos/tidepool-org/tideline","forks_url":"https://api.github.com/repos/tidepool-org/tideline/forks","keys_url":"https://api.github.com/repos/tidepool-org/tideline/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tidepool-org/tideline/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tidepool-org/tideline/teams","hooks_url":"https://api.github.com/repos/tidepool-org/tideline/hooks","issue_events_url":"https://api.github.com/repos/tidepool-org/tideline/issues/events{/number}","events_url":"https://api.github.com/repos/tidepool-org/tideline/events","assignees_url":"https://api.github.com/repos/tidepool-org/tideline/assignees{/user}","branches_url":"https://api.github.com/repos/tidepool-org/tideline/branches{/branch}","tags_url":"https://api.github.com/repos/tidepool-org/tideline/tags","blobs_url":"https://api.github.com/repos/tidepool-org/tideline/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tidepool-org/tideline/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tidepool-org/tideline/git/refs{/sha}","trees_url":"https://api.github.com/repos/tidepool-org/tideline/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tidepool-org/tideline/statuses/{sha}","languages_url":"https://api.github.com/repos/tidepool-org/tideline/languages","stargazers_url":"https://api.github.com/repos/tidepool-org/tideline/stargazers","contributors_url":"https://api.github.com/repos/tidepool-org/tideline/contributors","subscribers_url":"https://api.github.com/repos/tidepool-org/tideline/subscribers","subscription_url":"https://api.github.com/repos/tidepool-org/tideline/subscription","commits_url":"https://api.github.com/repos/tidepool-org/tideline/commits{/sha}","git_commits_url":"https://api.github.com/repos/tidepool-org/tideline/git/commits{/sha}","comments_url":"https://api.github.com/repos/tidepool-org/tideline/comments{/number}","issue_comment_url":"https://api.github.com/repos/tidepool-org/tideline/issues/comments/{number}","contents_url":"https://api.github.com/repos/tidepool-org/tideline/contents/{+path}","compare_url":"https://api.github.com/repos/tidepool-org/tideline/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tidepool-org/tideline/merges","archive_url":"https://api.github.com/repos/tidepool-org/tideline/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tidepool-org/tideline/downloads","issues_url":"https://api.github.com/repos/tidepool-org/tideline/issues{/number}","pulls_url":"https://api.github.com/repos/tidepool-org/tideline/pulls{/number}","milestones_url":"https://api.github.com/repos/tidepool-org/tideline/milestones{/number}","notifications_url":"https://api.github.com/repos/tidepool-org/tideline/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tidepool-org/tideline/labels{/name}","releases_url":"https://api.github.com/repos/tidepool-org/tideline/releases{/id}","created_at":"2014-01-07T01:22:13Z","updated_at":"2014-09-20T23:14:00Z","pushed_at":"2014-10-02T15:49:53Z","git_url":"git://github.com/tidepool-org/tideline.git","ssh_url":"git@github.com:tidepool-org/tideline.git","clone_url":"https://github.com/tidepool-org/tideline.git","svn_url":"https://github.com/tidepool-org/tideline","homepage":"","size":40162,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"open_issues_count":18,"forks":4,"open_issues":18,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tidepool-org/tideline/pulls/176"},"html":{"href":"https://github.com/tidepool-org/tideline/pull/176"},"issue":{"href":"https://api.github.com/repos/tidepool-org/tideline/issues/176"},"comments":{"href":"https://api.github.com/repos/tidepool-org/tideline/issues/176/comments"},"review_comments":{"href":"https://api.github.com/repos/tidepool-org/tideline/pulls/176/comments"},"review_comment":{"href":"https://api.github.com/repos/tidepool-org/tideline/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/tidepool-org/tideline/pulls/176/commits"},"statuses":{"href":"https://api.github.com/repos/tidepool-org/tideline/statuses/f85e17134635c259bfe3874326ed84b7b530bee5"}}}}