GitHub PullRequestReviewCommentEvent at 2014-09-29 13:51:11
Repository: invenio
Actor: invenio-developers
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/inveniosoftware/invenio/pulls/comments/18154390","id":18154390,"diff_hunk":"@@ -94,6 +94,7 @@","path":"invenio/legacy/inveniocfg.py","position":0,"original_position":0,"commit_id":"2ea13fb28c608afbc1911362e5785d7d95f3169d","original_commit_id":"2ea13fb28c608afbc1911362e5785d7d95f3169d","user":{"login":"invenio-developers","id":7439566,"avatar_url":"https://avatars.githubusercontent.com/u/7439566?v=2","gravatar_id":"","url":"https://api.github.com/users/invenio-developers","html_url":"https://github.com/invenio-developers","followers_url":"https://api.github.com/users/invenio-developers/followers","following_url":"https://api.github.com/users/invenio-developers/following{/other_user}","gists_url":"https://api.github.com/users/invenio-developers/gists{/gist_id}","starred_url":"https://api.github.com/users/invenio-developers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/invenio-developers/subscriptions","organizations_url":"https://api.github.com/users/invenio-developers/orgs","repos_url":"https://api.github.com/users/invenio-developers/repos","events_url":"https://api.github.com/users/invenio-developers/events{/privacy}","received_events_url":"https://api.github.com/users/invenio-developers/received_events","type":"User","site_admin":false},"body":"1: D100 Docstring missing\n88:1: F401 'random' imported but unused\n92:1: F401 'string' imported but unused\n97:1: F401 'exc' imported but unused\n105: D290 White spaces around docstring should be trimmed.\n105: D400 First line should end with '.', not 'o'\n116: D202 No blank lines allowed *after* function docstring, found 1\n116: D400 First line should end with '.', not 'g'\n116: D205 Blank line missing between one-line summary and description\n321: D103 Docstring missing\n327: D400 First line should end with '.', not 's'\n327: D205 Blank line missing between one-line summary and description\n343: D205 Blank line missing between one-line summary and description\n352:21: E127 continuation line over-indented for visual indent\n357:50: E502 the backslash is redundant between brackets\n358:25: E127 continuation line over-indented for visual indent\n358:66: E502 the backslash is redundant between brackets\n359:25: E127 continuation line over-indented for visual indent\n370: D205 Blank line missing between one-line summary and description\n379:21: E127 continuation line over-indented for visual indent\n399: D400 First line should end with '.', not '6'\n399: D205 Blank line missing between one-line summary and description\n416: D400 First line should end with '.', not 'r'\n416: D205 Blank line missing between one-line summary and description\n426:14: E127 continuation line over-indented for visual indent\n430:16: E126 continuation line over-indented for hanging indent\n445:45: E128 continuation line under-indented for visual indent\n446:45: E128 continuation line under-indented for visual indent\n455: D400 First line should end with '.', not 'd'\n455: D205 Blank line missing between one-line summary and description\n483: D209 Put multi-line docstring closing quotes on separate line\n483: D400 First line should end with '.', not 'n'\n483: D205 Blank line missing between one-line summary and description\n509:32: F841 local variable 'err' is assigned to but never used\n529: D209 Put multi-line docstring closing quotes on separate line\n529: D400 First line should end with '.', not 'n'\n529: D205 Blank line missing between one-line summary and description\n543: D200 One-line docstring should not occupy 3 lines\n558: D400 First line should end with '.', not 'N'\n558: D205 Blank line missing between one-line summary and description\n598:49: E128 continuation line under-indented for visual indent\n609:82: E231 missing whitespace after ','\n624: D400 First line should end with '.', not 's'\n624: D205 Blank line missing between one-line summary and description\n643: D209 Put multi-line docstring closing quotes on separate line\n643: D205 Blank line missing between one-line summary and description\n668: D103 Docstring missing\n678: D103 Docstring missing\n713:72: E502 the backslash is redundant between brackets\n714:20: E127 continuation line over-indented for visual indent\n714:44: E231 missing whitespace after ','\n718:35: E261 at least two spaces before inline comment\n737:21: E128 continuation line under-indented for visual indent\n737:93: E231 missing whitespace after ','\n755:50: E231 missing whitespace after ','\n775:48: E231 missing whitespace after ','\n828: D400 First line should end with '.', not 'e'\n828: D205 Blank line missing between one-line summary and description\n845: D400 First line should end with '.', not 's'\n845: D205 Blank line missing between one-line summary and description\n860: D400 First line should end with '.', not 'r'\n860: D205 Blank line missing between one-line summary and description\n870:10: E122 continuation line missing indentation or outdented\n883: D200 One-line docstring should not occupy 3 lines\n898: D400 First line should end with '.', not 'y'\n898: D205 Blank line missing between one-line summary and description\n917: D400 First line should end with '.', not 'L'\n917: D205 Blank line missing between one-line summary and description\n932: D400 First line should end with '.', not 's'\n932: D200 One-line docstring should not occupy 3 lines\n946: D400 First line should end with '.', not 's'\n946: D200 One-line docstring should not occupy 3 lines\n960: D400 First line should end with '.', not 'd'\n960: D200 One-line docstring should not occupy 3 lines\n974: D200 One-line docstring should not occupy 3 lines\n988: D202 No blank lines allowed *after* function docstring, found 1\n991: D203 Expected 1 blank line *before* class docstring, found 0\n991: D204 Expected 1 blank line *after* class docstring, found 0\n991: D400 First line should end with '.', not 'l'\n1107: D290 White spaces around docstring should be trimmed.\n1107: D400 First line should end with '.', not 's'","created_at":"2014-09-29T13:51:11Z","updated_at":"2014-09-29T13:51:11Z","html_url":"https://github.com/inveniosoftware/invenio/pull/2345#discussion_r18154390","pull_request_url":"https://api.github.com/repos/inveniosoftware/invenio/pulls/2345","_links":{"self":{"href":"https://api.github.com/repos/inveniosoftware/invenio/pulls/comments/18154390"},"html":{"href":"https://github.com/inveniosoftware/invenio/pull/2345#discussion_r18154390"},"pull_request":{"href":"https://api.github.com/repos/inveniosoftware/invenio/pulls/2345"}}},"pull_request":{"url":"https://api.github.com/repos/inveniosoftware/invenio/pulls/2345","id":21845057,"html_url":"https://github.com/inveniosoftware/invenio/pull/2345","diff_url":"https://github.com/inveniosoftware/invenio/pull/2345.diff","patch_url":"https://github.com/inveniosoftware/invenio/pull/2345.patch","issue_url":"https://api.github.com/repos/inveniosoftware/invenio/issues/2345","number":2345,"state":"open","locked":false,"title":"inveniocfg: fix PostgreSQL test connection","user":{"login":"hachreak","id":377047,"avatar_url":"https://avatars.githubusercontent.com/u/377047?v=2","gravatar_id":"","url":"https://api.github.com/users/hachreak","html_url":"https://github.com/hachreak","followers_url":"https://api.github.com/users/hachreak/followers","following_url":"https://api.github.com/users/hachreak/following{/other_user}","gists_url":"https://api.github.com/users/hachreak/gists{/gist_id}","starred_url":"https://api.github.com/users/hachreak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hachreak/subscriptions","organizations_url":"https://api.github.com/users/hachreak/orgs","repos_url":"https://api.github.com/users/hachreak/repos","events_url":"https://api.github.com/users/hachreak/events{/privacy}","received_events_url":"https://api.github.com/users/hachreak/received_events","type":"User","site_admin":false},"body":"* Use a SQLAlchemy's independent query to test connection.\r\n\r\n* Create a dialect depending procedure to initially test the db.\r\n\r\nSigned-off-by: Leonardo Rossi <leonardo.r@cern.ch>","created_at":"2014-09-26T12:25:10Z","updated_at":"2014-09-29T13:51:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"75e24acc83a3dd477d1fc73d37b50a526038e890","assignee":{"login":"hachreak","id":377047,"avatar_url":"https://avatars.githubusercontent.com/u/377047?v=2","gravatar_id":"","url":"https://api.github.com/users/hachreak","html_url":"https://github.com/hachreak","followers_url":"https://api.github.com/users/hachreak/followers","following_url":"https://api.github.com/users/hachreak/following{/other_user}","gists_url":"https://api.github.com/users/hachreak/gists{/gist_id}","starred_url":"https://api.github.com/users/hachreak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hachreak/subscriptions","organizations_url":"https://api.github.com/users/hachreak/orgs","repos_url":"https://api.github.com/users/hachreak/repos","events_url":"https://api.github.com/users/hachreak/events{/privacy}","received_events_url":"https://api.github.com/users/hachreak/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/inveniosoftware/invenio/milestones/11","labels_url":"https://api.github.com/repos/inveniosoftware/invenio/milestones/11/labels","id":769792,"number":11,"title":"v2.0.x","description":null,"creator":{"login":"tiborsimko","id":517546,"avatar_url":"https://avatars.githubusercontent.com/u/517546?v=2","gravatar_id":"","url":"https://api.github.com/users/tiborsimko","html_url":"https://github.com/tiborsimko","followers_url":"https://api.github.com/users/tiborsimko/followers","following_url":"https://api.github.com/users/tiborsimko/following{/other_user}","gists_url":"https://api.github.com/users/tiborsimko/gists{/gist_id}","starred_url":"https://api.github.com/users/tiborsimko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiborsimko/subscriptions","organizations_url":"https://api.github.com/users/tiborsimko/orgs","repos_url":"https://api.github.com/users/tiborsimko/repos","events_url":"https://api.github.com/users/tiborsimko/events{/privacy}","received_events_url":"https://api.github.com/users/tiborsimko/received_events","type":"User","site_admin":false},"open_issues":20,"closed_issues":37,"state":"open","created_at":"2014-08-28T16:18:55Z","updated_at":"2014-09-29T13:15:29Z","due_on":null},"commits_url":"https://api.github.com/repos/inveniosoftware/invenio/pulls/2345/commits","review_comments_url":"https://api.github.com/repos/inveniosoftware/invenio/pulls/2345/comments","review_comment_url":"https://api.github.com/repos/inveniosoftware/invenio/pulls/comments/{number}","comments_url":"https://api.github.com/repos/inveniosoftware/invenio/issues/2345/comments","statuses_url":"https://api.github.com/repos/inveniosoftware/invenio/statuses/2ea13fb28c608afbc1911362e5785d7d95f3169d","head":{"label":"hachreak:2338_fix_postgresql_test_database","ref":"2338_fix_postgresql_test_database","sha":"2ea13fb28c608afbc1911362e5785d7d95f3169d","user":{"login":"hachreak","id":377047,"avatar_url":"https://avatars.githubusercontent.com/u/377047?v=2","gravatar_id":"","url":"https://api.github.com/users/hachreak","html_url":"https://github.com/hachreak","followers_url":"https://api.github.com/users/hachreak/followers","following_url":"https://api.github.com/users/hachreak/following{/other_user}","gists_url":"https://api.github.com/users/hachreak/gists{/gist_id}","starred_url":"https://api.github.com/users/hachreak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hachreak/subscriptions","organizations_url":"https://api.github.com/users/hachreak/orgs","repos_url":"https://api.github.com/users/hachreak/repos","events_url":"https://api.github.com/users/hachreak/events{/privacy}","received_events_url":"https://api.github.com/users/hachreak/received_events","type":"User","site_admin":false},"repo":{"id":23670712,"name":"invenio","full_name":"hachreak/invenio","owner":{"login":"hachreak","id":377047,"avatar_url":"https://avatars.githubusercontent.com/u/377047?v=2","gravatar_id":"","url":"https://api.github.com/users/hachreak","html_url":"https://github.com/hachreak","followers_url":"https://api.github.com/users/hachreak/followers","following_url":"https://api.github.com/users/hachreak/following{/other_user}","gists_url":"https://api.github.com/users/hachreak/gists{/gist_id}","starred_url":"https://api.github.com/users/hachreak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hachreak/subscriptions","organizations_url":"https://api.github.com/users/hachreak/orgs","repos_url":"https://api.github.com/users/hachreak/repos","events_url":"https://api.github.com/users/hachreak/events{/privacy}","received_events_url":"https://api.github.com/users/hachreak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hachreak/invenio","description":"Invenio digital library software","fork":true,"url":"https://api.github.com/repos/hachreak/invenio","forks_url":"https://api.github.com/repos/hachreak/invenio/forks","keys_url":"https://api.github.com/repos/hachreak/invenio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hachreak/invenio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hachreak/invenio/teams","hooks_url":"https://api.github.com/repos/hachreak/invenio/hooks","issue_events_url":"https://api.github.com/repos/hachreak/invenio/issues/events{/number}","events_url":"https://api.github.com/repos/hachreak/invenio/events","assignees_url":"https://api.github.com/repos/hachreak/invenio/assignees{/user}","branches_url":"https://api.github.com/repos/hachreak/invenio/branches{/branch}","tags_url":"https://api.github.com/repos/hachreak/invenio/tags","blobs_url":"https://api.github.com/repos/hachreak/invenio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hachreak/invenio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hachreak/invenio/git/refs{/sha}","trees_url":"https://api.github.com/repos/hachreak/invenio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hachreak/invenio/statuses/{sha}","languages_url":"https://api.github.com/repos/hachreak/invenio/languages","stargazers_url":"https://api.github.com/repos/hachreak/invenio/stargazers","contributors_url":"https://api.github.com/repos/hachreak/invenio/contributors","subscribers_url":"https://api.github.com/repos/hachreak/invenio/subscribers","subscription_url":"https://api.github.com/repos/hachreak/invenio/subscription","commits_url":"https://api.github.com/repos/hachreak/invenio/commits{/sha}","git_commits_url":"https://api.github.com/repos/hachreak/invenio/git/commits{/sha}","comments_url":"https://api.github.com/repos/hachreak/invenio/comments{/number}","issue_comment_url":"https://api.github.com/repos/hachreak/invenio/issues/comments/{number}","contents_url":"https://api.github.com/repos/hachreak/invenio/contents/{+path}","compare_url":"https://api.github.com/repos/hachreak/invenio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hachreak/invenio/merges","archive_url":"https://api.github.com/repos/hachreak/invenio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hachreak/invenio/downloads","issues_url":"https://api.github.com/repos/hachreak/invenio/issues{/number}","pulls_url":"https://api.github.com/repos/hachreak/invenio/pulls{/number}","milestones_url":"https://api.github.com/repos/hachreak/invenio/milestones{/number}","notifications_url":"https://api.github.com/repos/hachreak/invenio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hachreak/invenio/labels{/name}","releases_url":"https://api.github.com/repos/hachreak/invenio/releases{/id}","created_at":"2014-09-04T16:41:39Z","updated_at":"2014-08-29T21:25:45Z","pushed_at":"2014-09-29T13:50:59Z","git_url":"git://github.com/hachreak/invenio.git","ssh_url":"git@github.com:hachreak/invenio.git","clone_url":"https://github.com/hachreak/invenio.git","svn_url":"https://github.com/hachreak/invenio","homepage":"http://invenio-software.org/","size":71234,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"inveniosoftware:pu","ref":"pu","sha":"25daeddfc682c79f6072cdc9cf8d14a3de8e9c8d","user":{"login":"inveniosoftware","id":1157480,"avatar_url":"https://avatars.githubusercontent.com/u/1157480?v=2","gravatar_id":"","url":"https://api.github.com/users/inveniosoftware","html_url":"https://github.com/inveniosoftware","followers_url":"https://api.github.com/users/inveniosoftware/followers","following_url":"https://api.github.com/users/inveniosoftware/following{/other_user}","gists_url":"https://api.github.com/users/inveniosoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/inveniosoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inveniosoftware/subscriptions","organizations_url":"https://api.github.com/users/inveniosoftware/orgs","repos_url":"https://api.github.com/users/inveniosoftware/repos","events_url":"https://api.github.com/users/inveniosoftware/events{/privacy}","received_events_url":"https://api.github.com/users/inveniosoftware/received_events","type":"Organization","site_admin":false},"repo":{"id":2665618,"name":"invenio","full_name":"inveniosoftware/invenio","owner":{"login":"inveniosoftware","id":1157480,"avatar_url":"https://avatars.githubusercontent.com/u/1157480?v=2","gravatar_id":"","url":"https://api.github.com/users/inveniosoftware","html_url":"https://github.com/inveniosoftware","followers_url":"https://api.github.com/users/inveniosoftware/followers","following_url":"https://api.github.com/users/inveniosoftware/following{/other_user}","gists_url":"https://api.github.com/users/inveniosoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/inveniosoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inveniosoftware/subscriptions","organizations_url":"https://api.github.com/users/inveniosoftware/orgs","repos_url":"https://api.github.com/users/inveniosoftware/repos","events_url":"https://api.github.com/users/inveniosoftware/events{/privacy}","received_events_url":"https://api.github.com/users/inveniosoftware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/inveniosoftware/invenio","description":"Invenio digital library software","fork":false,"url":"https://api.github.com/repos/inveniosoftware/invenio","forks_url":"https://api.github.com/repos/inveniosoftware/invenio/forks","keys_url":"https://api.github.com/repos/inveniosoftware/invenio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inveniosoftware/invenio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inveniosoftware/invenio/teams","hooks_url":"https://api.github.com/repos/inveniosoftware/invenio/hooks","issue_events_url":"https://api.github.com/repos/inveniosoftware/invenio/issues/events{/number}","events_url":"https://api.github.com/repos/inveniosoftware/invenio/events","assignees_url":"https://api.github.com/repos/inveniosoftware/invenio/assignees{/user}","branches_url":"https://api.github.com/repos/inveniosoftware/invenio/branches{/branch}","tags_url":"https://api.github.com/repos/inveniosoftware/invenio/tags","blobs_url":"https://api.github.com/repos/inveniosoftware/invenio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inveniosoftware/invenio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inveniosoftware/invenio/git/refs{/sha}","trees_url":"https://api.github.com/repos/inveniosoftware/invenio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inveniosoftware/invenio/statuses/{sha}","languages_url":"https://api.github.com/repos/inveniosoftware/invenio/languages","stargazers_url":"https://api.github.com/repos/inveniosoftware/invenio/stargazers","contributors_url":"https://api.github.com/repos/inveniosoftware/invenio/contributors","subscribers_url":"https://api.github.com/repos/inveniosoftware/invenio/subscribers","subscription_url":"https://api.github.com/repos/inveniosoftware/invenio/subscription","commits_url":"https://api.github.com/repos/inveniosoftware/invenio/commits{/sha}","git_commits_url":"https://api.github.com/repos/inveniosoftware/invenio/git/commits{/sha}","comments_url":"https://api.github.com/repos/inveniosoftware/invenio/comments{/number}","issue_comment_url":"https://api.github.com/repos/inveniosoftware/invenio/issues/comments/{number}","contents_url":"https://api.github.com/repos/inveniosoftware/invenio/contents/{+path}","compare_url":"https://api.github.com/repos/inveniosoftware/invenio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inveniosoftware/invenio/merges","archive_url":"https://api.github.com/repos/inveniosoftware/invenio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inveniosoftware/invenio/downloads","issues_url":"https://api.github.com/repos/inveniosoftware/invenio/issues{/number}","pulls_url":"https://api.github.com/repos/inveniosoftware/invenio/pulls{/number}","milestones_url":"https://api.github.com/repos/inveniosoftware/invenio/milestones{/number}","notifications_url":"https://api.github.com/repos/inveniosoftware/invenio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inveniosoftware/invenio/labels{/name}","releases_url":"https://api.github.com/repos/inveniosoftware/invenio/releases{/id}","created_at":"2011-10-28T14:33:51Z","updated_at":"2014-09-28T05:59:35Z","pushed_at":"2014-09-29T13:15:28Z","git_url":"git://github.com/inveniosoftware/invenio.git","ssh_url":"git@github.com:inveniosoftware/invenio.git","clone_url":"https://github.com/inveniosoftware/invenio.git","svn_url":"https://github.com/inveniosoftware/invenio","homepage":"http://invenio-software.org/","size":87018,"stargazers_count":32,"watchers_count":32,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":93,"mirror_url":null,"open_issues_count":854,"forks":93,"open_issues":854,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/inveniosoftware/invenio/pulls/2345"},"html":{"href":"https://github.com/inveniosoftware/invenio/pull/2345"},"issue":{"href":"https://api.github.com/repos/inveniosoftware/invenio/issues/2345"},"comments":{"href":"https://api.github.com/repos/inveniosoftware/invenio/issues/2345/comments"},"review_comments":{"href":"https://api.github.com/repos/inveniosoftware/invenio/pulls/2345/comments"},"review_comment":{"href":"https://api.github.com/repos/inveniosoftware/invenio/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/inveniosoftware/invenio/pulls/2345/commits"},"statuses":{"href":"https://api.github.com/repos/inveniosoftware/invenio/statuses/2ea13fb28c608afbc1911362e5785d7d95f3169d"}}}}