GitHub PullRequestReviewCommentEvent at 2014-11-13 18:28:10
Repository: elysium
Actor: elvisinaka
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/inaka/elysium/pulls/comments/20311710","id":20311710,"diff_hunk":"@@ -291,12 +421,68 @@ checkin_pending(Config, Node, Sid, Pending_Queue) ->\n exec_pending_request(Reply_Ref, Reply_Pid, Node, Sid, {bare_fun, Config, Query_Fun, Args, Consistency}) ->\n     try   Reply = Query_Fun(Sid, Args, Consistency),\n           Reply_Pid ! {wrr, Reply_Ref, Reply}\n-    catch A:B -> error_logger:error_msg(\"Query execution caught ~p:~p for ~p ~p\", [A,B, Reply_Pid, Args])\n-    after _ = checkin_connection(Config, Node, Sid)\n+    catch A:B -> lager:error(\"Query execution caught ~p:~p for ~p ~p ~9999p~n\",\n+                             [A,B, Reply_Pid, Args, erlang:get_stacktrace()])\n+    after _ = checkin_connection(Config, Node, Sid, false)\n     end;\n exec_pending_request(Reply_Ref, Reply_Pid, Node, Sid, {mod_fun,  Config, Mod,  Fun, Args, Consistency}) ->\n     try   Reply = Mod:Fun(Sid, Args, Consistency),\n           Reply_Pid ! {wrr, Reply_Ref, Reply}\n-    catch A:B -> error_logger:error_msg(\"Query execution caught ~p:~p for ~p ~p\", [A,B, Reply_Pid, Args])\n-    after _ = checkin_connection(Config, Node, Sid)\n+    catch A:B -> lager:error(\"Query execution caught ~p:~p for ~p ~p ~9999p~n\",\n+                             [A,B, Reply_Pid, Args, erlang:get_stacktrace()])","path":"src/elysium_bs_serial.erl","position":523,"original_position":523,"commit_id":"37cca477d0beb04f75c5062b03155b11ac33fbdd","original_commit_id":"37cca477d0beb04f75c5062b03155b11ac33fbdd","user":{"login":"elvisinaka","id":8136322,"avatar_url":"https://avatars.githubusercontent.com/u/8136322?v=3","gravatar_id":"","url":"https://api.github.com/users/elvisinaka","html_url":"https://github.com/elvisinaka","followers_url":"https://api.github.com/users/elvisinaka/followers","following_url":"https://api.github.com/users/elvisinaka/following{/other_user}","gists_url":"https://api.github.com/users/elvisinaka/gists{/gist_id}","starred_url":"https://api.github.com/users/elvisinaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elvisinaka/subscriptions","organizations_url":"https://api.github.com/users/elvisinaka/orgs","repos_url":"https://api.github.com/users/elvisinaka/repos","events_url":"https://api.github.com/users/elvisinaka/events{/privacy}","received_events_url":"https://api.github.com/users/elvisinaka/received_events","type":"User","site_admin":false},"body":"Missing space after \",\" on line 432","created_at":"2014-11-13T18:28:10Z","updated_at":"2014-11-13T18:28:10Z","html_url":"https://github.com/inaka/elysium/pull/1#discussion_r20311710","pull_request_url":"https://api.github.com/repos/inaka/elysium/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/inaka/elysium/pulls/comments/20311710"},"html":{"href":"https://github.com/inaka/elysium/pull/1#discussion_r20311710"},"pull_request":{"href":"https://api.github.com/repos/inaka/elysium/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/inaka/elysium/pulls/1","id":24389247,"html_url":"https://github.com/inaka/elysium/pull/1","diff_url":"https://github.com/inaka/elysium/pull/1.diff","patch_url":"https://github.com/inaka/elysium/pull/1.patch","issue_url":"https://api.github.com/repos/inaka/elysium/issues/1","number":1,"state":"closed","locked":false,"title":"Up to date","user":{"login":"HernanRivasAcosta","id":5691671,"avatar_url":"https://avatars.githubusercontent.com/u/5691671?v=3","gravatar_id":"","url":"https://api.github.com/users/HernanRivasAcosta","html_url":"https://github.com/HernanRivasAcosta","followers_url":"https://api.github.com/users/HernanRivasAcosta/followers","following_url":"https://api.github.com/users/HernanRivasAcosta/following{/other_user}","gists_url":"https://api.github.com/users/HernanRivasAcosta/gists{/gist_id}","starred_url":"https://api.github.com/users/HernanRivasAcosta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HernanRivasAcosta/subscriptions","organizations_url":"https://api.github.com/users/HernanRivasAcosta/orgs","repos_url":"https://api.github.com/users/HernanRivasAcosta/repos","events_url":"https://api.github.com/users/HernanRivasAcosta/events{/privacy}","received_events_url":"https://api.github.com/users/HernanRivasAcosta/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-11-13T18:26:57Z","updated_at":"2014-11-13T18:28:10Z","closed_at":"2014-11-13T18:27:56Z","merged_at":null,"merge_commit_sha":"a72986d87e4cefc1039607628657465b2ad79a70","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/inaka/elysium/pulls/1/commits","review_comments_url":"https://api.github.com/repos/inaka/elysium/pulls/1/comments","review_comment_url":"https://api.github.com/repos/inaka/elysium/pulls/comments/{number}","comments_url":"https://api.github.com/repos/inaka/elysium/issues/1/comments","statuses_url":"https://api.github.com/repos/inaka/elysium/statuses/37cca477d0beb04f75c5062b03155b11ac33fbdd","head":{"label":"tigertext:master","ref":"master","sha":"37cca477d0beb04f75c5062b03155b11ac33fbdd","user":{"login":"tigertext","id":173280,"avatar_url":"https://avatars.githubusercontent.com/u/173280?v=3","gravatar_id":"","url":"https://api.github.com/users/tigertext","html_url":"https://github.com/tigertext","followers_url":"https://api.github.com/users/tigertext/followers","following_url":"https://api.github.com/users/tigertext/following{/other_user}","gists_url":"https://api.github.com/users/tigertext/gists{/gist_id}","starred_url":"https://api.github.com/users/tigertext/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tigertext/subscriptions","organizations_url":"https://api.github.com/users/tigertext/orgs","repos_url":"https://api.github.com/users/tigertext/repos","events_url":"https://api.github.com/users/tigertext/events{/privacy}","received_events_url":"https://api.github.com/users/tigertext/received_events","type":"Organization","site_admin":false},"repo":{"id":24917017,"name":"elysium","full_name":"tigertext/elysium","owner":{"login":"tigertext","id":173280,"avatar_url":"https://avatars.githubusercontent.com/u/173280?v=3","gravatar_id":"","url":"https://api.github.com/users/tigertext","html_url":"https://github.com/tigertext","followers_url":"https://api.github.com/users/tigertext/followers","following_url":"https://api.github.com/users/tigertext/following{/other_user}","gists_url":"https://api.github.com/users/tigertext/gists{/gist_id}","starred_url":"https://api.github.com/users/tigertext/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tigertext/subscriptions","organizations_url":"https://api.github.com/users/tigertext/orgs","repos_url":"https://api.github.com/users/tigertext/repos","events_url":"https://api.github.com/users/tigertext/events{/privacy}","received_events_url":"https://api.github.com/users/tigertext/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tigertext/elysium","description":"The blessed and happy erlang afterlife for Cassandra","fork":true,"url":"https://api.github.com/repos/tigertext/elysium","forks_url":"https://api.github.com/repos/tigertext/elysium/forks","keys_url":"https://api.github.com/repos/tigertext/elysium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tigertext/elysium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tigertext/elysium/teams","hooks_url":"https://api.github.com/repos/tigertext/elysium/hooks","issue_events_url":"https://api.github.com/repos/tigertext/elysium/issues/events{/number}","events_url":"https://api.github.com/repos/tigertext/elysium/events","assignees_url":"https://api.github.com/repos/tigertext/elysium/assignees{/user}","branches_url":"https://api.github.com/repos/tigertext/elysium/branches{/branch}","tags_url":"https://api.github.com/repos/tigertext/elysium/tags","blobs_url":"https://api.github.com/repos/tigertext/elysium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tigertext/elysium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tigertext/elysium/git/refs{/sha}","trees_url":"https://api.github.com/repos/tigertext/elysium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tigertext/elysium/statuses/{sha}","languages_url":"https://api.github.com/repos/tigertext/elysium/languages","stargazers_url":"https://api.github.com/repos/tigertext/elysium/stargazers","contributors_url":"https://api.github.com/repos/tigertext/elysium/contributors","subscribers_url":"https://api.github.com/repos/tigertext/elysium/subscribers","subscription_url":"https://api.github.com/repos/tigertext/elysium/subscription","commits_url":"https://api.github.com/repos/tigertext/elysium/commits{/sha}","git_commits_url":"https://api.github.com/repos/tigertext/elysium/git/commits{/sha}","comments_url":"https://api.github.com/repos/tigertext/elysium/comments{/number}","issue_comment_url":"https://api.github.com/repos/tigertext/elysium/issues/comments/{number}","contents_url":"https://api.github.com/repos/tigertext/elysium/contents/{+path}","compare_url":"https://api.github.com/repos/tigertext/elysium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tigertext/elysium/merges","archive_url":"https://api.github.com/repos/tigertext/elysium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tigertext/elysium/downloads","issues_url":"https://api.github.com/repos/tigertext/elysium/issues{/number}","pulls_url":"https://api.github.com/repos/tigertext/elysium/pulls{/number}","milestones_url":"https://api.github.com/repos/tigertext/elysium/milestones{/number}","notifications_url":"https://api.github.com/repos/tigertext/elysium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tigertext/elysium/labels{/name}","releases_url":"https://api.github.com/repos/tigertext/elysium/releases{/id}","created_at":"2014-10-08T00:02:02Z","updated_at":"2014-10-15T21:47:30Z","pushed_at":"2014-11-13T06:07:18Z","git_url":"git://github.com/tigertext/elysium.git","ssh_url":"git@github.com:tigertext/elysium.git","clone_url":"https://github.com/tigertext/elysium.git","svn_url":"https://github.com/tigertext/elysium","homepage":null,"size":675,"stargazers_count":0,"watchers_count":0,"language":"Erlang","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"inaka:master","ref":"master","sha":"cdd4be536f0a749ee4b48d6e5d9036ab33c39e28","user":{"login":"inaka","id":867053,"avatar_url":"https://avatars.githubusercontent.com/u/867053?v=3","gravatar_id":"","url":"https://api.github.com/users/inaka","html_url":"https://github.com/inaka","followers_url":"https://api.github.com/users/inaka/followers","following_url":"https://api.github.com/users/inaka/following{/other_user}","gists_url":"https://api.github.com/users/inaka/gists{/gist_id}","starred_url":"https://api.github.com/users/inaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inaka/subscriptions","organizations_url":"https://api.github.com/users/inaka/orgs","repos_url":"https://api.github.com/users/inaka/repos","events_url":"https://api.github.com/users/inaka/events{/privacy}","received_events_url":"https://api.github.com/users/inaka/received_events","type":"Organization","site_admin":false},"repo":{"id":25830237,"name":"elysium","full_name":"inaka/elysium","owner":{"login":"inaka","id":867053,"avatar_url":"https://avatars.githubusercontent.com/u/867053?v=3","gravatar_id":"","url":"https://api.github.com/users/inaka","html_url":"https://github.com/inaka","followers_url":"https://api.github.com/users/inaka/followers","following_url":"https://api.github.com/users/inaka/following{/other_user}","gists_url":"https://api.github.com/users/inaka/gists{/gist_id}","starred_url":"https://api.github.com/users/inaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inaka/subscriptions","organizations_url":"https://api.github.com/users/inaka/orgs","repos_url":"https://api.github.com/users/inaka/repos","events_url":"https://api.github.com/users/inaka/events{/privacy}","received_events_url":"https://api.github.com/users/inaka/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/inaka/elysium","description":"The blessed and happy erlang afterlife for Cassandra","fork":true,"url":"https://api.github.com/repos/inaka/elysium","forks_url":"https://api.github.com/repos/inaka/elysium/forks","keys_url":"https://api.github.com/repos/inaka/elysium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inaka/elysium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inaka/elysium/teams","hooks_url":"https://api.github.com/repos/inaka/elysium/hooks","issue_events_url":"https://api.github.com/repos/inaka/elysium/issues/events{/number}","events_url":"https://api.github.com/repos/inaka/elysium/events","assignees_url":"https://api.github.com/repos/inaka/elysium/assignees{/user}","branches_url":"https://api.github.com/repos/inaka/elysium/branches{/branch}","tags_url":"https://api.github.com/repos/inaka/elysium/tags","blobs_url":"https://api.github.com/repos/inaka/elysium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inaka/elysium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inaka/elysium/git/refs{/sha}","trees_url":"https://api.github.com/repos/inaka/elysium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inaka/elysium/statuses/{sha}","languages_url":"https://api.github.com/repos/inaka/elysium/languages","stargazers_url":"https://api.github.com/repos/inaka/elysium/stargazers","contributors_url":"https://api.github.com/repos/inaka/elysium/contributors","subscribers_url":"https://api.github.com/repos/inaka/elysium/subscribers","subscription_url":"https://api.github.com/repos/inaka/elysium/subscription","commits_url":"https://api.github.com/repos/inaka/elysium/commits{/sha}","git_commits_url":"https://api.github.com/repos/inaka/elysium/git/commits{/sha}","comments_url":"https://api.github.com/repos/inaka/elysium/comments{/number}","issue_comment_url":"https://api.github.com/repos/inaka/elysium/issues/comments/{number}","contents_url":"https://api.github.com/repos/inaka/elysium/contents/{+path}","compare_url":"https://api.github.com/repos/inaka/elysium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inaka/elysium/merges","archive_url":"https://api.github.com/repos/inaka/elysium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inaka/elysium/downloads","issues_url":"https://api.github.com/repos/inaka/elysium/issues{/number}","pulls_url":"https://api.github.com/repos/inaka/elysium/pulls{/number}","milestones_url":"https://api.github.com/repos/inaka/elysium/milestones{/number}","notifications_url":"https://api.github.com/repos/inaka/elysium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inaka/elysium/labels{/name}","releases_url":"https://api.github.com/repos/inaka/elysium/releases{/id}","created_at":"2014-10-27T17:16:14Z","updated_at":"2014-10-15T21:47:30Z","pushed_at":"2014-10-27T17:16:47Z","git_url":"git://github.com/inaka/elysium.git","ssh_url":"git@github.com:inaka/elysium.git","clone_url":"https://github.com/inaka/elysium.git","svn_url":"https://github.com/inaka/elysium","homepage":null,"size":169,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/inaka/elysium/pulls/1"},"html":{"href":"https://github.com/inaka/elysium/pull/1"},"issue":{"href":"https://api.github.com/repos/inaka/elysium/issues/1"},"comments":{"href":"https://api.github.com/repos/inaka/elysium/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/inaka/elysium/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/inaka/elysium/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/inaka/elysium/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/inaka/elysium/statuses/37cca477d0beb04f75c5062b03155b11ac33fbdd"}}}}