GitHub PullRequestReviewCommentEvent at 2014-10-14 14:51:09
Repository: generator-bem-stub
Actor: dab
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/bem/generator-bem-stub/pulls/comments/18833330","id":18833330,"diff_hunk":"@@ -48,7 +48,8 @@\n       \"bemtree.js\"         : \"require('enb-bemxjst/techs/bemtree-old')\",\n       \"core-bemhtml\"       : \"require('enb-bemxjst/techs/bemhtml-old')\",\n       \"bh\"                 : \"require('enb-bh/techs/bh-server')\",\n-      \"node.js\"            : \"require('enb-diverse-js/techs/node-js')\",\n+      \"pre-node.js\"      : \"require('enb-diverse-js/techs/node-js'), { target: '?.pre.node.js' }\",\n+      \"node.js\"            : \"require('enb-modules/techs/prepend-modules'), { source: '?.pre.node.js', target: '?.node.js' }\",","path":"app/config/config.json","position":6,"original_position":6,"commit_id":"bdbe435c94cfdf86436bd168e758586dbaee793b","original_commit_id":"bdbe435c94cfdf86436bd168e758586dbaee793b","user":{"login":"dab","id":10816,"avatar_url":"https://avatars.githubusercontent.com/u/10816?v=2","gravatar_id":"","url":"https://api.github.com/users/dab","html_url":"https://github.com/dab","followers_url":"https://api.github.com/users/dab/followers","following_url":"https://api.github.com/users/dab/following{/other_user}","gists_url":"https://api.github.com/users/dab/gists{/gist_id}","starred_url":"https://api.github.com/users/dab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dab/subscriptions","organizations_url":"https://api.github.com/users/dab/orgs","repos_url":"https://api.github.com/users/dab/repos","events_url":"https://api.github.com/users/dab/events{/privacy}","received_events_url":"https://api.github.com/users/dab/received_events","type":"User","site_admin":false},"body":"@tadatuta just checked `index.node.js`, generated by `bem-tools`, and it contains requiring modules before other requires:\r\n\r\n```js\r\nif(typeof module !== 'undefined') {\r\nmodules = require('../../libs/bem-core/node_modules/ym/modules.js');\r\n}\r\nrequire('../../libs/bem-core/common.blocks/i-bem/i-bem.vanilla.js');\r\nrequire('../../libs/bem-core/common.blocks/i-bem/__internal/i-bem__internal.vanilla.js');\r\nrequire('../../libs/bem-core/common.blocks/inherit/inherit.vanilla.js');\r\nrequire('../../libs/bem-core/common.blocks/identify/identify.vanilla.js');\r\nrequire('../../libs/bem-core/common.blocks/next-tick/next-tick.vanilla.js');\r\nrequire('../../libs/bem-core/common.blocks/objects/objects.vanilla.js');\r\nrequire('../../libs/bem-core/common.blocks/functions/functions.vanilla.js');\r\nrequire('../../libs/bem-core/common.blocks/events/events.vanilla.js');\r\nrequire('../../libs/bem-core/common.blocks/functions/__debounce/functions__debounce.vanilla.js');\r\nrequire('../../libs/bem-core/common.blocks/tick/tick.vanilla.js');\r\nrequire('../../desktop.blocks/service/_type/service_type_twitter.node.js');\r\nrequire('../../desktop.blocks/service/_type/service_type_instagram.node.js');\r\nrequire('../../desktop.blocks/server/server.node.js');\r\n```","created_at":"2014-10-14T14:51:09Z","updated_at":"2014-10-14T14:51:09Z","html_url":"https://github.com/bem/generator-bem-stub/pull/80#discussion_r18833330","pull_request_url":"https://api.github.com/repos/bem/generator-bem-stub/pulls/80","_links":{"self":{"href":"https://api.github.com/repos/bem/generator-bem-stub/pulls/comments/18833330"},"html":{"href":"https://github.com/bem/generator-bem-stub/pull/80#discussion_r18833330"},"pull_request":{"href":"https://api.github.com/repos/bem/generator-bem-stub/pulls/80"}}},"pull_request":{"url":"https://api.github.com/repos/bem/generator-bem-stub/pulls/80","id":22703772,"html_url":"https://github.com/bem/generator-bem-stub/pull/80","diff_url":"https://github.com/bem/generator-bem-stub/pull/80.diff","patch_url":"https://github.com/bem/generator-bem-stub/pull/80.patch","issue_url":"https://api.github.com/repos/bem/generator-bem-stub/issues/80","number":80,"state":"closed","locked":false,"title":"added modules prepend to node.js tech","user":{"login":"dab","id":10816,"avatar_url":"https://avatars.githubusercontent.com/u/10816?v=2","gravatar_id":"","url":"https://api.github.com/users/dab","html_url":"https://github.com/dab","followers_url":"https://api.github.com/users/dab/followers","following_url":"https://api.github.com/users/dab/following{/other_user}","gists_url":"https://api.github.com/users/dab/gists{/gist_id}","starred_url":"https://api.github.com/users/dab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dab/subscriptions","organizations_url":"https://api.github.com/users/dab/orgs","repos_url":"https://api.github.com/users/dab/repos","events_url":"https://api.github.com/users/dab/events{/privacy}","received_events_url":"https://api.github.com/users/dab/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-10-14T11:14:59Z","updated_at":"2014-10-14T14:51:09Z","closed_at":"2014-10-14T13:56:04Z","merged_at":null,"merge_commit_sha":"60ad6f058fc318546ced19df6a6673f480a7690f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bem/generator-bem-stub/pulls/80/commits","review_comments_url":"https://api.github.com/repos/bem/generator-bem-stub/pulls/80/comments","review_comment_url":"https://api.github.com/repos/bem/generator-bem-stub/pulls/comments/{number}","comments_url":"https://api.github.com/repos/bem/generator-bem-stub/issues/80/comments","statuses_url":"https://api.github.com/repos/bem/generator-bem-stub/statuses/bdbe435c94cfdf86436bd168e758586dbaee793b","head":{"label":"bem:issue-79","ref":"issue-79","sha":"bdbe435c94cfdf86436bd168e758586dbaee793b","user":{"login":"bem","id":223412,"avatar_url":"https://avatars.githubusercontent.com/u/223412?v=2","gravatar_id":"","url":"https://api.github.com/users/bem","html_url":"https://github.com/bem","followers_url":"https://api.github.com/users/bem/followers","following_url":"https://api.github.com/users/bem/following{/other_user}","gists_url":"https://api.github.com/users/bem/gists{/gist_id}","starred_url":"https://api.github.com/users/bem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bem/subscriptions","organizations_url":"https://api.github.com/users/bem/orgs","repos_url":"https://api.github.com/users/bem/repos","events_url":"https://api.github.com/users/bem/events{/privacy}","received_events_url":"https://api.github.com/users/bem/received_events","type":"Organization","site_admin":false},"repo":{"id":16618690,"name":"generator-bem-stub","full_name":"bem/generator-bem-stub","owner":{"login":"bem","id":223412,"avatar_url":"https://avatars.githubusercontent.com/u/223412?v=2","gravatar_id":"","url":"https://api.github.com/users/bem","html_url":"https://github.com/bem","followers_url":"https://api.github.com/users/bem/followers","following_url":"https://api.github.com/users/bem/following{/other_user}","gists_url":"https://api.github.com/users/bem/gists{/gist_id}","starred_url":"https://api.github.com/users/bem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bem/subscriptions","organizations_url":"https://api.github.com/users/bem/orgs","repos_url":"https://api.github.com/users/bem/repos","events_url":"https://api.github.com/users/bem/events{/privacy}","received_events_url":"https://api.github.com/users/bem/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bem/generator-bem-stub","description":"A generator of BEM projects","fork":false,"url":"https://api.github.com/repos/bem/generator-bem-stub","forks_url":"https://api.github.com/repos/bem/generator-bem-stub/forks","keys_url":"https://api.github.com/repos/bem/generator-bem-stub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bem/generator-bem-stub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bem/generator-bem-stub/teams","hooks_url":"https://api.github.com/repos/bem/generator-bem-stub/hooks","issue_events_url":"https://api.github.com/repos/bem/generator-bem-stub/issues/events{/number}","events_url":"https://api.github.com/repos/bem/generator-bem-stub/events","assignees_url":"https://api.github.com/repos/bem/generator-bem-stub/assignees{/user}","branches_url":"https://api.github.com/repos/bem/generator-bem-stub/branches{/branch}","tags_url":"https://api.github.com/repos/bem/generator-bem-stub/tags","blobs_url":"https://api.github.com/repos/bem/generator-bem-stub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bem/generator-bem-stub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bem/generator-bem-stub/git/refs{/sha}","trees_url":"https://api.github.com/repos/bem/generator-bem-stub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bem/generator-bem-stub/statuses/{sha}","languages_url":"https://api.github.com/repos/bem/generator-bem-stub/languages","stargazers_url":"https://api.github.com/repos/bem/generator-bem-stub/stargazers","contributors_url":"https://api.github.com/repos/bem/generator-bem-stub/contributors","subscribers_url":"https://api.github.com/repos/bem/generator-bem-stub/subscribers","subscription_url":"https://api.github.com/repos/bem/generator-bem-stub/subscription","commits_url":"https://api.github.com/repos/bem/generator-bem-stub/commits{/sha}","git_commits_url":"https://api.github.com/repos/bem/generator-bem-stub/git/commits{/sha}","comments_url":"https://api.github.com/repos/bem/generator-bem-stub/comments{/number}","issue_comment_url":"https://api.github.com/repos/bem/generator-bem-stub/issues/comments/{number}","contents_url":"https://api.github.com/repos/bem/generator-bem-stub/contents/{+path}","compare_url":"https://api.github.com/repos/bem/generator-bem-stub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bem/generator-bem-stub/merges","archive_url":"https://api.github.com/repos/bem/generator-bem-stub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bem/generator-bem-stub/downloads","issues_url":"https://api.github.com/repos/bem/generator-bem-stub/issues{/number}","pulls_url":"https://api.github.com/repos/bem/generator-bem-stub/pulls{/number}","milestones_url":"https://api.github.com/repos/bem/generator-bem-stub/milestones{/number}","notifications_url":"https://api.github.com/repos/bem/generator-bem-stub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bem/generator-bem-stub/labels{/name}","releases_url":"https://api.github.com/repos/bem/generator-bem-stub/releases{/id}","created_at":"2014-02-07T15:32:31Z","updated_at":"2014-10-13T16:58:13Z","pushed_at":"2014-10-14T11:14:48Z","git_url":"git://github.com/bem/generator-bem-stub.git","ssh_url":"git@github.com:bem/generator-bem-stub.git","clone_url":"https://github.com/bem/generator-bem-stub.git","svn_url":"https://github.com/bem/generator-bem-stub","homepage":"http://bem.info/tools/bem/bem-stub/","size":4376,"stargazers_count":18,"watchers_count":18,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":5,"forks":2,"open_issues":5,"watchers":18,"default_branch":"master"}},"base":{"label":"bem:master","ref":"master","sha":"2ade48fa9d12f55a9fcb981bf70ee874ae373d26","user":{"login":"bem","id":223412,"avatar_url":"https://avatars.githubusercontent.com/u/223412?v=2","gravatar_id":"","url":"https://api.github.com/users/bem","html_url":"https://github.com/bem","followers_url":"https://api.github.com/users/bem/followers","following_url":"https://api.github.com/users/bem/following{/other_user}","gists_url":"https://api.github.com/users/bem/gists{/gist_id}","starred_url":"https://api.github.com/users/bem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bem/subscriptions","organizations_url":"https://api.github.com/users/bem/orgs","repos_url":"https://api.github.com/users/bem/repos","events_url":"https://api.github.com/users/bem/events{/privacy}","received_events_url":"https://api.github.com/users/bem/received_events","type":"Organization","site_admin":false},"repo":{"id":16618690,"name":"generator-bem-stub","full_name":"bem/generator-bem-stub","owner":{"login":"bem","id":223412,"avatar_url":"https://avatars.githubusercontent.com/u/223412?v=2","gravatar_id":"","url":"https://api.github.com/users/bem","html_url":"https://github.com/bem","followers_url":"https://api.github.com/users/bem/followers","following_url":"https://api.github.com/users/bem/following{/other_user}","gists_url":"https://api.github.com/users/bem/gists{/gist_id}","starred_url":"https://api.github.com/users/bem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bem/subscriptions","organizations_url":"https://api.github.com/users/bem/orgs","repos_url":"https://api.github.com/users/bem/repos","events_url":"https://api.github.com/users/bem/events{/privacy}","received_events_url":"https://api.github.com/users/bem/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bem/generator-bem-stub","description":"A generator of BEM projects","fork":false,"url":"https://api.github.com/repos/bem/generator-bem-stub","forks_url":"https://api.github.com/repos/bem/generator-bem-stub/forks","keys_url":"https://api.github.com/repos/bem/generator-bem-stub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bem/generator-bem-stub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bem/generator-bem-stub/teams","hooks_url":"https://api.github.com/repos/bem/generator-bem-stub/hooks","issue_events_url":"https://api.github.com/repos/bem/generator-bem-stub/issues/events{/number}","events_url":"https://api.github.com/repos/bem/generator-bem-stub/events","assignees_url":"https://api.github.com/repos/bem/generator-bem-stub/assignees{/user}","branches_url":"https://api.github.com/repos/bem/generator-bem-stub/branches{/branch}","tags_url":"https://api.github.com/repos/bem/generator-bem-stub/tags","blobs_url":"https://api.github.com/repos/bem/generator-bem-stub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bem/generator-bem-stub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bem/generator-bem-stub/git/refs{/sha}","trees_url":"https://api.github.com/repos/bem/generator-bem-stub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bem/generator-bem-stub/statuses/{sha}","languages_url":"https://api.github.com/repos/bem/generator-bem-stub/languages","stargazers_url":"https://api.github.com/repos/bem/generator-bem-stub/stargazers","contributors_url":"https://api.github.com/repos/bem/generator-bem-stub/contributors","subscribers_url":"https://api.github.com/repos/bem/generator-bem-stub/subscribers","subscription_url":"https://api.github.com/repos/bem/generator-bem-stub/subscription","commits_url":"https://api.github.com/repos/bem/generator-bem-stub/commits{/sha}","git_commits_url":"https://api.github.com/repos/bem/generator-bem-stub/git/commits{/sha}","comments_url":"https://api.github.com/repos/bem/generator-bem-stub/comments{/number}","issue_comment_url":"https://api.github.com/repos/bem/generator-bem-stub/issues/comments/{number}","contents_url":"https://api.github.com/repos/bem/generator-bem-stub/contents/{+path}","compare_url":"https://api.github.com/repos/bem/generator-bem-stub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bem/generator-bem-stub/merges","archive_url":"https://api.github.com/repos/bem/generator-bem-stub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bem/generator-bem-stub/downloads","issues_url":"https://api.github.com/repos/bem/generator-bem-stub/issues{/number}","pulls_url":"https://api.github.com/repos/bem/generator-bem-stub/pulls{/number}","milestones_url":"https://api.github.com/repos/bem/generator-bem-stub/milestones{/number}","notifications_url":"https://api.github.com/repos/bem/generator-bem-stub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bem/generator-bem-stub/labels{/name}","releases_url":"https://api.github.com/repos/bem/generator-bem-stub/releases{/id}","created_at":"2014-02-07T15:32:31Z","updated_at":"2014-10-13T16:58:13Z","pushed_at":"2014-10-14T11:14:48Z","git_url":"git://github.com/bem/generator-bem-stub.git","ssh_url":"git@github.com:bem/generator-bem-stub.git","clone_url":"https://github.com/bem/generator-bem-stub.git","svn_url":"https://github.com/bem/generator-bem-stub","homepage":"http://bem.info/tools/bem/bem-stub/","size":4376,"stargazers_count":18,"watchers_count":18,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":5,"forks":2,"open_issues":5,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bem/generator-bem-stub/pulls/80"},"html":{"href":"https://github.com/bem/generator-bem-stub/pull/80"},"issue":{"href":"https://api.github.com/repos/bem/generator-bem-stub/issues/80"},"comments":{"href":"https://api.github.com/repos/bem/generator-bem-stub/issues/80/comments"},"review_comments":{"href":"https://api.github.com/repos/bem/generator-bem-stub/pulls/80/comments"},"review_comment":{"href":"https://api.github.com/repos/bem/generator-bem-stub/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/bem/generator-bem-stub/pulls/80/commits"},"statuses":{"href":"https://api.github.com/repos/bem/generator-bem-stub/statuses/bdbe435c94cfdf86436bd168e758586dbaee793b"}}}}