GitHub PushEvent at 2014-08-27 13:06:01
Repository: Console
Actor: sensiolabs-splitter
Payload: {"shas":[["13ddfc0beca0d0a6a961f5ecea70b443fdd66d29","6d5fe1f1ea2d938364c0f0387aef1852813c4772@spa.it","[Console][ProgressBar] Developer experience  - Create getProgress/setProgress methods to replace getStep/setCurrent  - ProgressBar::setCurrent should auto-start the ProgressBar.  - You should be able to pass max to start  - getStepWidth is internal information that should not be public  - when verbosity set to quiet, the progress bar does not even need to    execute all the logic to generate output that is then thrown away","Stefano Sala",true],["2ad7142450d50c0fa27ebc9ca6543b8b213de506","3f735b0edba35f2f28fc1e2ec64c1dcf5e47e265@antistatique.net","[Console][ProgressBar] Allow to advance past max.","Gilles Doge",true],["4fc2c744f431efd519ba67baa15ec32b414217b2","6d5fe1f1ea2d938364c0f0387aef1852813c4772@spa.it","[Console][ProgressBar] Developer experience:  - Removed barCharOriginal  - getProgressPercent should return float instead of int.  - Minor refactoring","Stefano Sala",true],["1bbbcdc8f55338a72adc8a7d1171c020b044f0a9","d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","feature #11346 [Console] ProgressBar developer experience (stefanosala, gido)\n\nThis PR was merged into the 2.6-dev branch.\n\nDiscussion\n----------\n\n[Console] ProgressBar developer experience\n\n| Q             | A\n| ------------- | ---\n| Bug fix?      | yes\n| New feature?  | no\n| BC breaks?    | no\n| Deprecations? | yes\n| Tests pass?   | yes\n| Fixed tickets | #11184\n| License       | MIT\n| Doc PR        | WIP\n\n## TODO\n\n- [x] Create `getProgress/setProgress` methods to replace `getStep/setCurrent`\n- [x] `ProgressBar::setCurrent` should auto-start the ProgressBar.\n- [x] You should be able to pass `max` to `start`\n- [x] `barCharOriginal` not needed. Logic can simply be part of `getBarChar`\n- [x] `getStepWidth` is internal information that should not be public\n- [x] when verbosity set to quiet, the progress bar does not even need to execute all the logic to generate output that is then thrown away\n- [x] Allow to advance past max.\n- [x] negative max needs to be validated\n- [x] `getProgressPercent` should return float instead of int.\n\nCommits\n-------\n\n42b95df [Console][ProgressBar] Developer experience:  - Removed barCharOriginal  - getProgressPercent should return float instead of int.  - Minor refactoring\n3011685 [Console][ProgressBar] Allow to advance past max.\n73ca340 [Console][ProgressBar] Developer experience  - Create getProgress/setProgress methods to replace getStep/setCurrent  - ProgressBar::setCurrent should auto-start the ProgressBar.  - You should be able to pass max to start  - getStepWidth is internal information that should not be public  - when verbosity set to quiet, the progress bar does not even need to    execute all the logic to generate output that is then thrown away","Fabien Potencier",true]],"size":4,"ref":"refs/heads/master","head":"1bbbcdc8f55338a72adc8a7d1171c020b044f0a9"}