GitHub PullRequestReviewCommentEvent at 2014-10-28 16:06:55
Repository: ezpublish-kernel
Actor: flovntp
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/comments/19481483","id":19481483,"diff_hunk":"@@ -12,10 +12,13 @@\n use Symfony\\Component\\Routing\\RouterInterface;\n use Symfony\\Component\\Routing\\RequestContext;\n use Symfony\\Component\\Routing\\RouteCollection;\n+use Symfony\\Component\\HttpFoundation\\Request;\n+use Symfony\\Component\\Routing\\Matcher\\RequestMatcherInterface;\n use Symfony\\Component\\Routing\\Exception\\RouteNotFoundException;\n use Psr\\Log\\LoggerInterface;\n+use Symfony\\Component\\Yaml\\Exception\\RuntimeException;","path":"eZ/Bundle/EzPublishLegacyBundle/Routing/FallbackRouter.php","position":null,"original_position":8,"commit_id":"33238551a0cf564867d0804c65b3636c9879e812","original_commit_id":"81f8762fc072b31aeaaf4ba67b51293ec6952f6a","user":{"login":"flovntp","id":1842696,"avatar_url":"https://avatars.githubusercontent.com/u/1842696?v=2","gravatar_id":"","url":"https://api.github.com/users/flovntp","html_url":"https://github.com/flovntp","followers_url":"https://api.github.com/users/flovntp/followers","following_url":"https://api.github.com/users/flovntp/following{/other_user}","gists_url":"https://api.github.com/users/flovntp/gists{/gist_id}","starred_url":"https://api.github.com/users/flovntp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flovntp/subscriptions","organizations_url":"https://api.github.com/users/flovntp/orgs","repos_url":"https://api.github.com/users/flovntp/repos","events_url":"https://api.github.com/users/flovntp/events{/privacy}","received_events_url":"https://api.github.com/users/flovntp/received_events","type":"User","site_admin":false},"body":"done","created_at":"2014-10-28T16:06:55Z","updated_at":"2014-10-28T16:06:55Z","html_url":"https://github.com/ezsystems/ezpublish-kernel/pull/1055#discussion_r19481483","pull_request_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/1055","_links":{"self":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/comments/19481483"},"html":{"href":"https://github.com/ezsystems/ezpublish-kernel/pull/1055#discussion_r19481483"},"pull_request":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/1055"}}},"pull_request":{"url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/1055","id":23460365,"html_url":"https://github.com/ezsystems/ezpublish-kernel/pull/1055","diff_url":"https://github.com/ezsystems/ezpublish-kernel/pull/1055.diff","patch_url":"https://github.com/ezsystems/ezpublish-kernel/pull/1055.patch","issue_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/1055","number":1055,"state":"open","locked":false,"title":"EZP-23516: fix generation for ez_legacy routes using url twig function","user":{"login":"flovntp","id":1842696,"avatar_url":"https://avatars.githubusercontent.com/u/1842696?v=2","gravatar_id":"","url":"https://api.github.com/users/flovntp","html_url":"https://github.com/flovntp","followers_url":"https://api.github.com/users/flovntp/followers","following_url":"https://api.github.com/users/flovntp/following{/other_user}","gists_url":"https://api.github.com/users/flovntp/gists{/gist_id}","starred_url":"https://api.github.com/users/flovntp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flovntp/subscriptions","organizations_url":"https://api.github.com/users/flovntp/orgs","repos_url":"https://api.github.com/users/flovntp/repos","events_url":"https://api.github.com/users/flovntp/events{/privacy}","received_events_url":"https://api.github.com/users/flovntp/received_events","type":"User","site_admin":false},"body":"When trying to generate a route for legacy modules (languages switcher), it raised an error like \r\n```\r\nAn exception has been thrown during the rendering of a template (\"When generating an eZ Publish legacy fallback route, \"uri\" parameter must be provided.\") in EzConsultingBundle:Language:switcher.html.twig at line 17.\r\n```\r\nThis modification solve issue https://jira.ez.no/browse/EZP-23516 \r\nand generate the good url for legacy module using url twig function\r\n```\r\n{{ url( routeRef ) }}\r\n```\r\n","created_at":"2014-10-28T14:35:45Z","updated_at":"2014-10-28T16:06:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"67d5a73c24c19ed754c6e8608be8fc9b1ad7b7e6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/1055/commits","review_comments_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/1055/comments","review_comment_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/1055/comments","statuses_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/statuses/33238551a0cf564867d0804c65b3636c9879e812","head":{"label":"flovntp:EZP-23516-languages-switcher-and-legacy-module","ref":"EZP-23516-languages-switcher-and-legacy-module","sha":"33238551a0cf564867d0804c65b3636c9879e812","user":{"login":"flovntp","id":1842696,"avatar_url":"https://avatars.githubusercontent.com/u/1842696?v=2","gravatar_id":"","url":"https://api.github.com/users/flovntp","html_url":"https://github.com/flovntp","followers_url":"https://api.github.com/users/flovntp/followers","following_url":"https://api.github.com/users/flovntp/following{/other_user}","gists_url":"https://api.github.com/users/flovntp/gists{/gist_id}","starred_url":"https://api.github.com/users/flovntp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flovntp/subscriptions","organizations_url":"https://api.github.com/users/flovntp/orgs","repos_url":"https://api.github.com/users/flovntp/repos","events_url":"https://api.github.com/users/flovntp/events{/privacy}","received_events_url":"https://api.github.com/users/flovntp/received_events","type":"User","site_admin":false},"repo":{"id":10733341,"name":"ezpublish-kernel","full_name":"flovntp/ezpublish-kernel","owner":{"login":"flovntp","id":1842696,"avatar_url":"https://avatars.githubusercontent.com/u/1842696?v=2","gravatar_id":"","url":"https://api.github.com/users/flovntp","html_url":"https://github.com/flovntp","followers_url":"https://api.github.com/users/flovntp/followers","following_url":"https://api.github.com/users/flovntp/following{/other_user}","gists_url":"https://api.github.com/users/flovntp/gists{/gist_id}","starred_url":"https://api.github.com/users/flovntp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flovntp/subscriptions","organizations_url":"https://api.github.com/users/flovntp/orgs","repos_url":"https://api.github.com/users/flovntp/repos","events_url":"https://api.github.com/users/flovntp/events{/privacy}","received_events_url":"https://api.github.com/users/flovntp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/flovntp/ezpublish-kernel","description":"","fork":true,"url":"https://api.github.com/repos/flovntp/ezpublish-kernel","forks_url":"https://api.github.com/repos/flovntp/ezpublish-kernel/forks","keys_url":"https://api.github.com/repos/flovntp/ezpublish-kernel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flovntp/ezpublish-kernel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flovntp/ezpublish-kernel/teams","hooks_url":"https://api.github.com/repos/flovntp/ezpublish-kernel/hooks","issue_events_url":"https://api.github.com/repos/flovntp/ezpublish-kernel/issues/events{/number}","events_url":"https://api.github.com/repos/flovntp/ezpublish-kernel/events","assignees_url":"https://api.github.com/repos/flovntp/ezpublish-kernel/assignees{/user}","branches_url":"https://api.github.com/repos/flovntp/ezpublish-kernel/branches{/branch}","tags_url":"https://api.github.com/repos/flovntp/ezpublish-kernel/tags","blobs_url":"https://api.github.com/repos/flovntp/ezpublish-kernel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flovntp/ezpublish-kernel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flovntp/ezpublish-kernel/git/refs{/sha}","trees_url":"https://api.github.com/repos/flovntp/ezpublish-kernel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flovntp/ezpublish-kernel/statuses/{sha}","languages_url":"https://api.github.com/repos/flovntp/ezpublish-kernel/languages","stargazers_url":"https://api.github.com/repos/flovntp/ezpublish-kernel/stargazers","contributors_url":"https://api.github.com/repos/flovntp/ezpublish-kernel/contributors","subscribers_url":"https://api.github.com/repos/flovntp/ezpublish-kernel/subscribers","subscription_url":"https://api.github.com/repos/flovntp/ezpublish-kernel/subscription","commits_url":"https://api.github.com/repos/flovntp/ezpublish-kernel/commits{/sha}","git_commits_url":"https://api.github.com/repos/flovntp/ezpublish-kernel/git/commits{/sha}","comments_url":"https://api.github.com/repos/flovntp/ezpublish-kernel/comments{/number}","issue_comment_url":"https://api.github.com/repos/flovntp/ezpublish-kernel/issues/comments/{number}","contents_url":"https://api.github.com/repos/flovntp/ezpublish-kernel/contents/{+path}","compare_url":"https://api.github.com/repos/flovntp/ezpublish-kernel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flovntp/ezpublish-kernel/merges","archive_url":"https://api.github.com/repos/flovntp/ezpublish-kernel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flovntp/ezpublish-kernel/downloads","issues_url":"https://api.github.com/repos/flovntp/ezpublish-kernel/issues{/number}","pulls_url":"https://api.github.com/repos/flovntp/ezpublish-kernel/pulls{/number}","milestones_url":"https://api.github.com/repos/flovntp/ezpublish-kernel/milestones{/number}","notifications_url":"https://api.github.com/repos/flovntp/ezpublish-kernel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flovntp/ezpublish-kernel/labels{/name}","releases_url":"https://api.github.com/repos/flovntp/ezpublish-kernel/releases{/id}","created_at":"2013-06-17T08:41:53Z","updated_at":"2014-05-15T09:24:42Z","pushed_at":"2014-10-28T16:04:04Z","git_url":"git://github.com/flovntp/ezpublish-kernel.git","ssh_url":"git@github.com:flovntp/ezpublish-kernel.git","clone_url":"https://github.com/flovntp/ezpublish-kernel.git","svn_url":"https://github.com/flovntp/ezpublish-kernel","homepage":"","size":334399,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ezsystems:master","ref":"master","sha":"df5662ae5f3aa0b40b1c8e966a777ba40cfe001d","user":{"login":"ezsystems","id":295311,"avatar_url":"https://avatars.githubusercontent.com/u/295311?v=2","gravatar_id":"","url":"https://api.github.com/users/ezsystems","html_url":"https://github.com/ezsystems","followers_url":"https://api.github.com/users/ezsystems/followers","following_url":"https://api.github.com/users/ezsystems/following{/other_user}","gists_url":"https://api.github.com/users/ezsystems/gists{/gist_id}","starred_url":"https://api.github.com/users/ezsystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezsystems/subscriptions","organizations_url":"https://api.github.com/users/ezsystems/orgs","repos_url":"https://api.github.com/users/ezsystems/repos","events_url":"https://api.github.com/users/ezsystems/events{/privacy}","received_events_url":"https://api.github.com/users/ezsystems/received_events","type":"Organization","site_admin":false},"repo":{"id":1663890,"name":"ezpublish-kernel","full_name":"ezsystems/ezpublish-kernel","owner":{"login":"ezsystems","id":295311,"avatar_url":"https://avatars.githubusercontent.com/u/295311?v=2","gravatar_id":"","url":"https://api.github.com/users/ezsystems","html_url":"https://github.com/ezsystems","followers_url":"https://api.github.com/users/ezsystems/followers","following_url":"https://api.github.com/users/ezsystems/following{/other_user}","gists_url":"https://api.github.com/users/ezsystems/gists{/gist_id}","starred_url":"https://api.github.com/users/ezsystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezsystems/subscriptions","organizations_url":"https://api.github.com/users/ezsystems/orgs","repos_url":"https://api.github.com/users/ezsystems/repos","events_url":"https://api.github.com/users/ezsystems/events{/privacy}","received_events_url":"https://api.github.com/users/ezsystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ezsystems/ezpublish-kernel","description":"eZ Publish 5 kernel","fork":false,"url":"https://api.github.com/repos/ezsystems/ezpublish-kernel","forks_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/forks","keys_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/teams","hooks_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/hooks","issue_events_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/events{/number}","events_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/events","assignees_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/assignees{/user}","branches_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/branches{/branch}","tags_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/tags","blobs_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/git/refs{/sha}","trees_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/statuses/{sha}","languages_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/languages","stargazers_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/stargazers","contributors_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/contributors","subscribers_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/subscribers","subscription_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/subscription","commits_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/commits{/sha}","git_commits_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/git/commits{/sha}","comments_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/comments{/number}","issue_comment_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/comments/{number}","contents_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/contents/{+path}","compare_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/merges","archive_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/downloads","issues_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues{/number}","pulls_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls{/number}","milestones_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/milestones{/number}","notifications_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/labels{/name}","releases_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/releases{/id}","created_at":"2011-04-26T08:54:24Z","updated_at":"2014-10-21T01:56:18Z","pushed_at":"2014-10-28T14:50:20Z","git_url":"git://github.com/ezsystems/ezpublish-kernel.git","ssh_url":"git@github.com:ezsystems/ezpublish-kernel.git","clone_url":"https://github.com/ezsystems/ezpublish-kernel.git","svn_url":"https://github.com/ezsystems/ezpublish-kernel","homepage":"http://ez.no","size":66712,"stargazers_count":92,"watchers_count":92,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":104,"mirror_url":null,"open_issues_count":37,"forks":104,"open_issues":37,"watchers":92,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/1055"},"html":{"href":"https://github.com/ezsystems/ezpublish-kernel/pull/1055"},"issue":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/1055"},"comments":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/1055/comments"},"review_comments":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/1055/comments"},"review_comment":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/1055/commits"},"statuses":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/statuses/33238551a0cf564867d0804c65b3636c9879e812"}}}}