GitHub PullRequestReviewCommentEvent at 2014-03-20 21:50:03
Repository: voltdb
Actor: paulmartel
Payload: {"comment":{"url":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments/10818416","id":10818416,"diff_hunk":"@@ -192,7 +193,7 @@ class TableSerializeTest : public Test {\n     EXPECT_EQ(\"\", deserialized->columnName(0));\n     EXPECT_EQ(VALUE_TYPE_VARCHAR, table_->schema()->columnType(0));\n     EXPECT_EQ(VALUE_TYPE_VARCHAR, deserialized->schema()->columnType(0));\n-    EXPECT_EQ(true, table_->schema()->columnIsInlined(0));\n+    EXPECT_EQ(false, table_->schema()->columnIsInlined(0));","path":"tests/ee/storage/serialize_test.cpp","position":13,"original_position":13,"commit_id":"53f45d112cde02fdd2151c6d1fdd4b6e84cbe1cf","original_commit_id":"53f45d112cde02fdd2151c6d1fdd4b6e84cbe1cf","user":{"login":"paulmartel","id":1512099,"avatar_url":"https://avatars.githubusercontent.com/u/1512099?","gravatar_id":"6ead0214cbf028f95dcc28142fa4d7bd","url":"https://api.github.com/users/paulmartel","html_url":"https://github.com/paulmartel","followers_url":"https://api.github.com/users/paulmartel/followers","following_url":"https://api.github.com/users/paulmartel/following{/other_user}","gists_url":"https://api.github.com/users/paulmartel/gists{/gist_id}","starred_url":"https://api.github.com/users/paulmartel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulmartel/subscriptions","organizations_url":"https://api.github.com/users/paulmartel/orgs","repos_url":"https://api.github.com/users/paulmartel/repos","events_url":"https://api.github.com/users/paulmartel/events{/privacy}","received_events_url":"https://api.github.com/users/paulmartel/received_events","type":"User","site_admin":false},"body":"Review or change or add to this test to make sure it (also) covers an inlined example.","created_at":"2014-03-20T21:50:03Z","updated_at":"2014-03-20T21:50:03Z","html_url":"https://github.com/VoltDB/voltdb/pull/1223#discussion_r10818416","pull_request_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/1223","_links":{"self":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments/10818416"},"html":{"href":"https://github.com/VoltDB/voltdb/pull/1223#discussion_r10818416"},"pull_request":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/1223"}}}}