GitHub PullRequestEvent at 2014-12-11 19:34:51
Repository: OpenStudio
Actor: macumber
Payload: {"action":"closed","number":1301,"pull_request":{"url":"https://api.github.com/repos/NREL/OpenStudio/pulls/1301","id":25636639,"html_url":"https://github.com/NREL/OpenStudio/pull/1301","diff_url":"https://github.com/NREL/OpenStudio/pull/1301.diff","patch_url":"https://github.com/NREL/OpenStudio/pull/1301.patch","issue_url":"https://api.github.com/repos/NREL/OpenStudio/issues/1301","number":1301,"state":"closed","locked":false,"title":"83818462 energy plus build sha version","user":{"login":"lefticus","id":234279,"avatar_url":"https://avatars.githubusercontent.com/u/234279?v=3","gravatar_id":"","url":"https://api.github.com/users/lefticus","html_url":"https://github.com/lefticus","followers_url":"https://api.github.com/users/lefticus/followers","following_url":"https://api.github.com/users/lefticus/following{/other_user}","gists_url":"https://api.github.com/users/lefticus/gists{/gist_id}","starred_url":"https://api.github.com/users/lefticus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lefticus/subscriptions","organizations_url":"https://api.github.com/users/lefticus/orgs","repos_url":"https://api.github.com/users/lefticus/repos","events_url":"https://api.github.com/users/lefticus/events{/privacy}","received_events_url":"https://api.github.com/users/lefticus/received_events","type":"User","site_admin":false},"body":"@kbenne The only part of this I'm not satisfied with is that there's no unit test for the new `IddFile::build()` function, but I don't see how to add one until/if/when the `ProposedEnergy+.idd` is updated.\r\n\r\nThe single line of most interest to you is probably this one: https://github.com/NREL/OpenStudio/compare/83818462-EnergyPlusBuildSHAVersion?expand=1#diff-a6b897b61c185627e8bc67aeb86a5eeeR120 if you specify the SHA, it *must* match to get the version you want. You can choose to specify *only* the sha and the rest of the version number can be left unspecified.\r\n\r\n","created_at":"2014-12-07T20:14:34Z","updated_at":"2014-12-11T19:34:51Z","closed_at":"2014-12-11T19:34:50Z","merged_at":"2014-12-11T19:34:50Z","merge_commit_sha":"347e502722c44e15a94c46bb413ead8694282eae","assignee":{"login":"kbenne","id":707488,"avatar_url":"https://avatars.githubusercontent.com/u/707488?v=3","gravatar_id":"","url":"https://api.github.com/users/kbenne","html_url":"https://github.com/kbenne","followers_url":"https://api.github.com/users/kbenne/followers","following_url":"https://api.github.com/users/kbenne/following{/other_user}","gists_url":"https://api.github.com/users/kbenne/gists{/gist_id}","starred_url":"https://api.github.com/users/kbenne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbenne/subscriptions","organizations_url":"https://api.github.com/users/kbenne/orgs","repos_url":"https://api.github.com/users/kbenne/repos","events_url":"https://api.github.com/users/kbenne/events{/privacy}","received_events_url":"https://api.github.com/users/kbenne/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/NREL/OpenStudio/pulls/1301/commits","review_comments_url":"https://api.github.com/repos/NREL/OpenStudio/pulls/1301/comments","review_comment_url":"https://api.github.com/repos/NREL/OpenStudio/pulls/comments/{number}","comments_url":"https://api.github.com/repos/NREL/OpenStudio/issues/1301/comments","statuses_url":"https://api.github.com/repos/NREL/OpenStudio/statuses/24716418866340a7702df9feaf784b4c57eb3c3a","head":{"label":"NREL:83818462-EnergyPlusBuildSHAVersion","ref":"83818462-EnergyPlusBuildSHAVersion","sha":"24716418866340a7702df9feaf784b4c57eb3c3a","user":{"login":"NREL","id":1906800,"avatar_url":"https://avatars.githubusercontent.com/u/1906800?v=3","gravatar_id":"","url":"https://api.github.com/users/NREL","html_url":"https://github.com/NREL","followers_url":"https://api.github.com/users/NREL/followers","following_url":"https://api.github.com/users/NREL/following{/other_user}","gists_url":"https://api.github.com/users/NREL/gists{/gist_id}","starred_url":"https://api.github.com/users/NREL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NREL/subscriptions","organizations_url":"https://api.github.com/users/NREL/orgs","repos_url":"https://api.github.com/users/NREL/repos","events_url":"https://api.github.com/users/NREL/events{/privacy}","received_events_url":"https://api.github.com/users/NREL/received_events","type":"Organization","site_admin":false},"repo":{"id":11159552,"name":"OpenStudio","full_name":"NREL/OpenStudio","owner":{"login":"NREL","id":1906800,"avatar_url":"https://avatars.githubusercontent.com/u/1906800?v=3","gravatar_id":"","url":"https://api.github.com/users/NREL","html_url":"https://github.com/NREL","followers_url":"https://api.github.com/users/NREL/followers","following_url":"https://api.github.com/users/NREL/following{/other_user}","gists_url":"https://api.github.com/users/NREL/gists{/gist_id}","starred_url":"https://api.github.com/users/NREL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NREL/subscriptions","organizations_url":"https://api.github.com/users/NREL/orgs","repos_url":"https://api.github.com/users/NREL/repos","events_url":"https://api.github.com/users/NREL/events{/privacy}","received_events_url":"https://api.github.com/users/NREL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NREL/OpenStudio","description":"OpenStudio is a cross-platform collection of software tools to support whole building energy modeling using EnergyPlus and advanced daylight analysis using Radiance.","fork":false,"url":"https://api.github.com/repos/NREL/OpenStudio","forks_url":"https://api.github.com/repos/NREL/OpenStudio/forks","keys_url":"https://api.github.com/repos/NREL/OpenStudio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NREL/OpenStudio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NREL/OpenStudio/teams","hooks_url":"https://api.github.com/repos/NREL/OpenStudio/hooks","issue_events_url":"https://api.github.com/repos/NREL/OpenStudio/issues/events{/number}","events_url":"https://api.github.com/repos/NREL/OpenStudio/events","assignees_url":"https://api.github.com/repos/NREL/OpenStudio/assignees{/user}","branches_url":"https://api.github.com/repos/NREL/OpenStudio/branches{/branch}","tags_url":"https://api.github.com/repos/NREL/OpenStudio/tags","blobs_url":"https://api.github.com/repos/NREL/OpenStudio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NREL/OpenStudio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NREL/OpenStudio/git/refs{/sha}","trees_url":"https://api.github.com/repos/NREL/OpenStudio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NREL/OpenStudio/statuses/{sha}","languages_url":"https://api.github.com/repos/NREL/OpenStudio/languages","stargazers_url":"https://api.github.com/repos/NREL/OpenStudio/stargazers","contributors_url":"https://api.github.com/repos/NREL/OpenStudio/contributors","subscribers_url":"https://api.github.com/repos/NREL/OpenStudio/subscribers","subscription_url":"https://api.github.com/repos/NREL/OpenStudio/subscription","commits_url":"https://api.github.com/repos/NREL/OpenStudio/commits{/sha}","git_commits_url":"https://api.github.com/repos/NREL/OpenStudio/git/commits{/sha}","comments_url":"https://api.github.com/repos/NREL/OpenStudio/comments{/number}","issue_comment_url":"https://api.github.com/repos/NREL/OpenStudio/issues/comments/{number}","contents_url":"https://api.github.com/repos/NREL/OpenStudio/contents/{+path}","compare_url":"https://api.github.com/repos/NREL/OpenStudio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NREL/OpenStudio/merges","archive_url":"https://api.github.com/repos/NREL/OpenStudio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NREL/OpenStudio/downloads","issues_url":"https://api.github.com/repos/NREL/OpenStudio/issues{/number}","pulls_url":"https://api.github.com/repos/NREL/OpenStudio/pulls{/number}","milestones_url":"https://api.github.com/repos/NREL/OpenStudio/milestones{/number}","notifications_url":"https://api.github.com/repos/NREL/OpenStudio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NREL/OpenStudio/labels{/name}","releases_url":"https://api.github.com/repos/NREL/OpenStudio/releases{/id}","created_at":"2013-07-03T19:34:37Z","updated_at":"2014-12-09T04:34:10Z","pushed_at":"2014-12-11T19:34:50Z","git_url":"git://github.com/NREL/OpenStudio.git","ssh_url":"git@github.com:NREL/OpenStudio.git","clone_url":"https://github.com/NREL/OpenStudio.git","svn_url":"https://github.com/NREL/OpenStudio","homepage":"https://www.openstudio.net/","size":242932,"stargazers_count":59,"watchers_count":59,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"open_issues_count":633,"forks":54,"open_issues":633,"watchers":59,"default_branch":"develop"}},"base":{"label":"NREL:develop","ref":"develop","sha":"99333beb9a5e01353a3e7b7882c21ff29556a4a8","user":{"login":"NREL","id":1906800,"avatar_url":"https://avatars.githubusercontent.com/u/1906800?v=3","gravatar_id":"","url":"https://api.github.com/users/NREL","html_url":"https://github.com/NREL","followers_url":"https://api.github.com/users/NREL/followers","following_url":"https://api.github.com/users/NREL/following{/other_user}","gists_url":"https://api.github.com/users/NREL/gists{/gist_id}","starred_url":"https://api.github.com/users/NREL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NREL/subscriptions","organizations_url":"https://api.github.com/users/NREL/orgs","repos_url":"https://api.github.com/users/NREL/repos","events_url":"https://api.github.com/users/NREL/events{/privacy}","received_events_url":"https://api.github.com/users/NREL/received_events","type":"Organization","site_admin":false},"repo":{"id":11159552,"name":"OpenStudio","full_name":"NREL/OpenStudio","owner":{"login":"NREL","id":1906800,"avatar_url":"https://avatars.githubusercontent.com/u/1906800?v=3","gravatar_id":"","url":"https://api.github.com/users/NREL","html_url":"https://github.com/NREL","followers_url":"https://api.github.com/users/NREL/followers","following_url":"https://api.github.com/users/NREL/following{/other_user}","gists_url":"https://api.github.com/users/NREL/gists{/gist_id}","starred_url":"https://api.github.com/users/NREL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NREL/subscriptions","organizations_url":"https://api.github.com/users/NREL/orgs","repos_url":"https://api.github.com/users/NREL/repos","events_url":"https://api.github.com/users/NREL/events{/privacy}","received_events_url":"https://api.github.com/users/NREL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NREL/OpenStudio","description":"OpenStudio is a cross-platform collection of software tools to support whole building energy modeling using EnergyPlus and advanced daylight analysis using Radiance.","fork":false,"url":"https://api.github.com/repos/NREL/OpenStudio","forks_url":"https://api.github.com/repos/NREL/OpenStudio/forks","keys_url":"https://api.github.com/repos/NREL/OpenStudio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NREL/OpenStudio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NREL/OpenStudio/teams","hooks_url":"https://api.github.com/repos/NREL/OpenStudio/hooks","issue_events_url":"https://api.github.com/repos/NREL/OpenStudio/issues/events{/number}","events_url":"https://api.github.com/repos/NREL/OpenStudio/events","assignees_url":"https://api.github.com/repos/NREL/OpenStudio/assignees{/user}","branches_url":"https://api.github.com/repos/NREL/OpenStudio/branches{/branch}","tags_url":"https://api.github.com/repos/NREL/OpenStudio/tags","blobs_url":"https://api.github.com/repos/NREL/OpenStudio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NREL/OpenStudio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NREL/OpenStudio/git/refs{/sha}","trees_url":"https://api.github.com/repos/NREL/OpenStudio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NREL/OpenStudio/statuses/{sha}","languages_url":"https://api.github.com/repos/NREL/OpenStudio/languages","stargazers_url":"https://api.github.com/repos/NREL/OpenStudio/stargazers","contributors_url":"https://api.github.com/repos/NREL/OpenStudio/contributors","subscribers_url":"https://api.github.com/repos/NREL/OpenStudio/subscribers","subscription_url":"https://api.github.com/repos/NREL/OpenStudio/subscription","commits_url":"https://api.github.com/repos/NREL/OpenStudio/commits{/sha}","git_commits_url":"https://api.github.com/repos/NREL/OpenStudio/git/commits{/sha}","comments_url":"https://api.github.com/repos/NREL/OpenStudio/comments{/number}","issue_comment_url":"https://api.github.com/repos/NREL/OpenStudio/issues/comments/{number}","contents_url":"https://api.github.com/repos/NREL/OpenStudio/contents/{+path}","compare_url":"https://api.github.com/repos/NREL/OpenStudio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NREL/OpenStudio/merges","archive_url":"https://api.github.com/repos/NREL/OpenStudio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NREL/OpenStudio/downloads","issues_url":"https://api.github.com/repos/NREL/OpenStudio/issues{/number}","pulls_url":"https://api.github.com/repos/NREL/OpenStudio/pulls{/number}","milestones_url":"https://api.github.com/repos/NREL/OpenStudio/milestones{/number}","notifications_url":"https://api.github.com/repos/NREL/OpenStudio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NREL/OpenStudio/labels{/name}","releases_url":"https://api.github.com/repos/NREL/OpenStudio/releases{/id}","created_at":"2013-07-03T19:34:37Z","updated_at":"2014-12-09T04:34:10Z","pushed_at":"2014-12-11T19:34:50Z","git_url":"git://github.com/NREL/OpenStudio.git","ssh_url":"git@github.com:NREL/OpenStudio.git","clone_url":"https://github.com/NREL/OpenStudio.git","svn_url":"https://github.com/NREL/OpenStudio","homepage":"https://www.openstudio.net/","size":242932,"stargazers_count":59,"watchers_count":59,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"open_issues_count":633,"forks":54,"open_issues":633,"watchers":59,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/NREL/OpenStudio/pulls/1301"},"html":{"href":"https://github.com/NREL/OpenStudio/pull/1301"},"issue":{"href":"https://api.github.com/repos/NREL/OpenStudio/issues/1301"},"comments":{"href":"https://api.github.com/repos/NREL/OpenStudio/issues/1301/comments"},"review_comments":{"href":"https://api.github.com/repos/NREL/OpenStudio/pulls/1301/comments"},"review_comment":{"href":"https://api.github.com/repos/NREL/OpenStudio/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/NREL/OpenStudio/pulls/1301/commits"},"statuses":{"href":"https://api.github.com/repos/NREL/OpenStudio/statuses/24716418866340a7702df9feaf784b4c57eb3c3a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"macumber","id":1327850,"avatar_url":"https://avatars.githubusercontent.com/u/1327850?v=3","gravatar_id":"","url":"https://api.github.com/users/macumber","html_url":"https://github.com/macumber","followers_url":"https://api.github.com/users/macumber/followers","following_url":"https://api.github.com/users/macumber/following{/other_user}","gists_url":"https://api.github.com/users/macumber/gists{/gist_id}","starred_url":"https://api.github.com/users/macumber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macumber/subscriptions","organizations_url":"https://api.github.com/users/macumber/orgs","repos_url":"https://api.github.com/users/macumber/repos","events_url":"https://api.github.com/users/macumber/events{/privacy}","received_events_url":"https://api.github.com/users/macumber/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":2,"additions":164,"deletions":55,"changed_files":14}}