GitHub PullRequestReviewCommentEvent at 2014-12-13 22:49:08
Repository: JSQMessagesViewController
Actor: jessesquires
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/pulls/comments/21792117","id":21792117,"diff_hunk":"@@ -212,6 +212,11 @@ - (void)jsq_didReceiveKeyboardDidHideNotification:(NSNotification *)notification\n     \n     [self jsq_handleKeyboardNotification:notification completion:^(BOOL finished) {\n         [self.panGestureRecognizer removeTarget:self action:NULL];\n+        \n+        if ([self.delegate respondsToSelector:@selector(keyboardControllerDidReceiveKeyboardHideNotification:)]) {","path":"JSQMessagesViewController/Controllers/JSQMessagesKeyboardController.m","position":5,"original_position":5,"commit_id":"276e9f94a65252098d139e9f7c1fb1631f63276d","original_commit_id":"276e9f94a65252098d139e9f7c1fb1631f63276d","user":{"login":"jessesquires","id":2301114,"avatar_url":"https://avatars.githubusercontent.com/u/2301114?v=3","gravatar_id":"","url":"https://api.github.com/users/jessesquires","html_url":"https://github.com/jessesquires","followers_url":"https://api.github.com/users/jessesquires/followers","following_url":"https://api.github.com/users/jessesquires/following{/other_user}","gists_url":"https://api.github.com/users/jessesquires/gists{/gist_id}","starred_url":"https://api.github.com/users/jessesquires/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessesquires/subscriptions","organizations_url":"https://api.github.com/users/jessesquires/orgs","repos_url":"https://api.github.com/users/jessesquires/repos","events_url":"https://api.github.com/users/jessesquires/events{/privacy}","received_events_url":"https://api.github.com/users/jessesquires/received_events","type":"User","site_admin":false},"body":"with this being required, we can just call the method.","created_at":"2014-12-13T22:49:08Z","updated_at":"2014-12-13T22:49:08Z","html_url":"https://github.com/jessesquires/JSQMessagesViewController/pull/646#discussion_r21792117","pull_request_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/pulls/646","_links":{"self":{"href":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/pulls/comments/21792117"},"html":{"href":"https://github.com/jessesquires/JSQMessagesViewController/pull/646#discussion_r21792117"},"pull_request":{"href":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/pulls/646"}}},"pull_request":{"url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/pulls/646","id":25056990,"html_url":"https://github.com/jessesquires/JSQMessagesViewController/pull/646","diff_url":"https://github.com/jessesquires/JSQMessagesViewController/pull/646.diff","patch_url":"https://github.com/jessesquires/JSQMessagesViewController/pull/646.patch","issue_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/issues/646","number":646,"state":"open","locked":false,"title":"add 'keyboardDidHide' notification handling","user":{"login":"toblerpwn","id":1731512,"avatar_url":"https://avatars.githubusercontent.com/u/1731512?v=3","gravatar_id":"","url":"https://api.github.com/users/toblerpwn","html_url":"https://github.com/toblerpwn","followers_url":"https://api.github.com/users/toblerpwn/followers","following_url":"https://api.github.com/users/toblerpwn/following{/other_user}","gists_url":"https://api.github.com/users/toblerpwn/gists{/gist_id}","starred_url":"https://api.github.com/users/toblerpwn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toblerpwn/subscriptions","organizations_url":"https://api.github.com/users/toblerpwn/orgs","repos_url":"https://api.github.com/users/toblerpwn/repos","events_url":"https://api.github.com/users/toblerpwn/events{/privacy}","received_events_url":"https://api.github.com/users/toblerpwn/received_events","type":"User","site_admin":false},"body":"fixes #645, and possibly related issues\r\n\r\n:: JSQMessagesKeyboardControllerDelegate protocol adds optional `keyboardControllerDidReceiveKeyboardHideNotification:` method\r\n:: this method is called within the completion block of the typical keyboard frame change notification handler, ensuring that the 'hide' message is received last\r\n:: `JSQMessagesViewController` uses this delegate callback to call `jsq_setToolbarBottomLayoutGuideConstant:` with a value of `0.0f` (ensuring that a 'hidden' keyboard results in a 0-position input toolbar)","created_at":"2014-11-26T02:26:58Z","updated_at":"2014-12-13T22:49:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5e4c370bf351b7cc47ccc5733f7cea7efe735bcf","assignee":null,"milestone":{"url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/milestones/5","labels_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/milestones/5/labels","id":878989,"number":5,"title":"Release 6.1.1","description":"Bug fixes","creator":{"login":"jessesquires","id":2301114,"avatar_url":"https://avatars.githubusercontent.com/u/2301114?v=3","gravatar_id":"","url":"https://api.github.com/users/jessesquires","html_url":"https://github.com/jessesquires","followers_url":"https://api.github.com/users/jessesquires/followers","following_url":"https://api.github.com/users/jessesquires/following{/other_user}","gists_url":"https://api.github.com/users/jessesquires/gists{/gist_id}","starred_url":"https://api.github.com/users/jessesquires/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessesquires/subscriptions","organizations_url":"https://api.github.com/users/jessesquires/orgs","repos_url":"https://api.github.com/users/jessesquires/repos","events_url":"https://api.github.com/users/jessesquires/events{/privacy}","received_events_url":"https://api.github.com/users/jessesquires/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":3,"state":"open","created_at":"2014-11-24T21:15:17Z","updated_at":"2014-12-13T22:13:20Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/pulls/646/commits","review_comments_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/pulls/646/comments","review_comment_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/issues/646/comments","statuses_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/statuses/276e9f94a65252098d139e9f7c1fb1631f63276d","head":{"label":"evilstudios:keyboard-notification-fix","ref":"keyboard-notification-fix","sha":"276e9f94a65252098d139e9f7c1fb1631f63276d","user":{"login":"evilstudios","id":6590319,"avatar_url":"https://avatars.githubusercontent.com/u/6590319?v=3","gravatar_id":"","url":"https://api.github.com/users/evilstudios","html_url":"https://github.com/evilstudios","followers_url":"https://api.github.com/users/evilstudios/followers","following_url":"https://api.github.com/users/evilstudios/following{/other_user}","gists_url":"https://api.github.com/users/evilstudios/gists{/gist_id}","starred_url":"https://api.github.com/users/evilstudios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evilstudios/subscriptions","organizations_url":"https://api.github.com/users/evilstudios/orgs","repos_url":"https://api.github.com/users/evilstudios/repos","events_url":"https://api.github.com/users/evilstudios/events{/privacy}","received_events_url":"https://api.github.com/users/evilstudios/received_events","type":"Organization","site_admin":false},"repo":{"id":27150331,"name":"JSQMessagesViewController","full_name":"evilstudios/JSQMessagesViewController","owner":{"login":"evilstudios","id":6590319,"avatar_url":"https://avatars.githubusercontent.com/u/6590319?v=3","gravatar_id":"","url":"https://api.github.com/users/evilstudios","html_url":"https://github.com/evilstudios","followers_url":"https://api.github.com/users/evilstudios/followers","following_url":"https://api.github.com/users/evilstudios/following{/other_user}","gists_url":"https://api.github.com/users/evilstudios/gists{/gist_id}","starred_url":"https://api.github.com/users/evilstudios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evilstudios/subscriptions","organizations_url":"https://api.github.com/users/evilstudios/orgs","repos_url":"https://api.github.com/users/evilstudios/repos","events_url":"https://api.github.com/users/evilstudios/events{/privacy}","received_events_url":"https://api.github.com/users/evilstudios/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/evilstudios/JSQMessagesViewController","description":"An elegant messages UI library for iOS","fork":true,"url":"https://api.github.com/repos/evilstudios/JSQMessagesViewController","forks_url":"https://api.github.com/repos/evilstudios/JSQMessagesViewController/forks","keys_url":"https://api.github.com/repos/evilstudios/JSQMessagesViewController/keys{/key_id}","collaborators_url":"https://api.github.com/repos/evilstudios/JSQMessagesViewController/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/evilstudios/JSQMessagesViewController/teams","hooks_url":"https://api.github.com/repos/evilstudios/JSQMessagesViewController/hooks","issue_events_url":"https://api.github.com/repos/evilstudios/JSQMessagesViewController/issues/events{/number}","events_url":"https://api.github.com/repos/evilstudios/JSQMessagesViewController/events","assignees_url":"https://api.github.com/repos/evilstudios/JSQMessagesViewController/assignees{/user}","branches_url":"https://api.github.com/repos/evilstudios/JSQMessagesViewController/branches{/branch}","tags_url":"https://api.github.com/repos/evilstudios/JSQMessagesViewController/tags","blobs_url":"https://api.github.com/repos/evilstudios/JSQMessagesViewController/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/evilstudios/JSQMessagesViewController/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/evilstudios/JSQMessagesViewController/git/refs{/sha}","trees_url":"https://api.github.com/repos/evilstudios/JSQMessagesViewController/git/trees{/sha}","statuses_url":"https://api.github.com/repos/evilstudios/JSQMessagesViewController/statuses/{sha}","languages_url":"https://api.github.com/repos/evilstudios/JSQMessagesViewController/languages","stargazers_url":"https://api.github.com/repos/evilstudios/JSQMessagesViewController/stargazers","contributors_url":"https://api.github.com/repos/evilstudios/JSQMessagesViewController/contributors","subscribers_url":"https://api.github.com/repos/evilstudios/JSQMessagesViewController/subscribers","subscription_url":"https://api.github.com/repos/evilstudios/JSQMessagesViewController/subscription","commits_url":"https://api.github.com/repos/evilstudios/JSQMessagesViewController/commits{/sha}","git_commits_url":"https://api.github.com/repos/evilstudios/JSQMessagesViewController/git/commits{/sha}","comments_url":"https://api.github.com/repos/evilstudios/JSQMessagesViewController/comments{/number}","issue_comment_url":"https://api.github.com/repos/evilstudios/JSQMessagesViewController/issues/comments/{number}","contents_url":"https://api.github.com/repos/evilstudios/JSQMessagesViewController/contents/{+path}","compare_url":"https://api.github.com/repos/evilstudios/JSQMessagesViewController/compare/{base}...{head}","merges_url":"https://api.github.com/repos/evilstudios/JSQMessagesViewController/merges","archive_url":"https://api.github.com/repos/evilstudios/JSQMessagesViewController/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/evilstudios/JSQMessagesViewController/downloads","issues_url":"https://api.github.com/repos/evilstudios/JSQMessagesViewController/issues{/number}","pulls_url":"https://api.github.com/repos/evilstudios/JSQMessagesViewController/pulls{/number}","milestones_url":"https://api.github.com/repos/evilstudios/JSQMessagesViewController/milestones{/number}","notifications_url":"https://api.github.com/repos/evilstudios/JSQMessagesViewController/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/evilstudios/JSQMessagesViewController/labels{/name}","releases_url":"https://api.github.com/repos/evilstudios/JSQMessagesViewController/releases{/id}","created_at":"2014-11-25T23:05:36Z","updated_at":"2014-11-26T02:32:31Z","pushed_at":"2014-11-27T05:19:28Z","git_url":"git://github.com/evilstudios/JSQMessagesViewController.git","ssh_url":"git@github.com:evilstudios/JSQMessagesViewController.git","clone_url":"https://github.com/evilstudios/JSQMessagesViewController.git","svn_url":"https://github.com/evilstudios/JSQMessagesViewController","homepage":"http://jessesquires.com/JSQMessagesViewController","size":14491,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"jessesquires:develop","ref":"develop","sha":"8f28bc513e44e3d849ae25e0f6fbd53265c61860","user":{"login":"jessesquires","id":2301114,"avatar_url":"https://avatars.githubusercontent.com/u/2301114?v=3","gravatar_id":"","url":"https://api.github.com/users/jessesquires","html_url":"https://github.com/jessesquires","followers_url":"https://api.github.com/users/jessesquires/followers","following_url":"https://api.github.com/users/jessesquires/following{/other_user}","gists_url":"https://api.github.com/users/jessesquires/gists{/gist_id}","starred_url":"https://api.github.com/users/jessesquires/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessesquires/subscriptions","organizations_url":"https://api.github.com/users/jessesquires/orgs","repos_url":"https://api.github.com/users/jessesquires/repos","events_url":"https://api.github.com/users/jessesquires/events{/privacy}","received_events_url":"https://api.github.com/users/jessesquires/received_events","type":"User","site_admin":false},"repo":{"id":8257106,"name":"JSQMessagesViewController","full_name":"jessesquires/JSQMessagesViewController","owner":{"login":"jessesquires","id":2301114,"avatar_url":"https://avatars.githubusercontent.com/u/2301114?v=3","gravatar_id":"","url":"https://api.github.com/users/jessesquires","html_url":"https://github.com/jessesquires","followers_url":"https://api.github.com/users/jessesquires/followers","following_url":"https://api.github.com/users/jessesquires/following{/other_user}","gists_url":"https://api.github.com/users/jessesquires/gists{/gist_id}","starred_url":"https://api.github.com/users/jessesquires/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessesquires/subscriptions","organizations_url":"https://api.github.com/users/jessesquires/orgs","repos_url":"https://api.github.com/users/jessesquires/repos","events_url":"https://api.github.com/users/jessesquires/events{/privacy}","received_events_url":"https://api.github.com/users/jessesquires/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jessesquires/JSQMessagesViewController","description":"An elegant messages UI library for iOS","fork":false,"url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController","forks_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/forks","keys_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/teams","hooks_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/hooks","issue_events_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/issues/events{/number}","events_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/events","assignees_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/assignees{/user}","branches_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/branches{/branch}","tags_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/tags","blobs_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/git/refs{/sha}","trees_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/statuses/{sha}","languages_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/languages","stargazers_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/stargazers","contributors_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/contributors","subscribers_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/subscribers","subscription_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/subscription","commits_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/commits{/sha}","git_commits_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/git/commits{/sha}","comments_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/comments{/number}","issue_comment_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/issues/comments/{number}","contents_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/contents/{+path}","compare_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/merges","archive_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/downloads","issues_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/issues{/number}","pulls_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/pulls{/number}","milestones_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/milestones{/number}","notifications_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/labels{/name}","releases_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/releases{/id}","created_at":"2013-02-17T21:40:44Z","updated_at":"2014-12-13T22:35:57Z","pushed_at":"2014-12-13T22:35:56Z","git_url":"git://github.com/jessesquires/JSQMessagesViewController.git","ssh_url":"git@github.com:jessesquires/JSQMessagesViewController.git","clone_url":"https://github.com/jessesquires/JSQMessagesViewController.git","svn_url":"https://github.com/jessesquires/JSQMessagesViewController","homepage":"http://jessesquires.com/JSQMessagesViewController","size":44586,"stargazers_count":3065,"watchers_count":3065,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":693,"mirror_url":null,"open_issues_count":60,"forks":693,"open_issues":60,"watchers":3065,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/pulls/646"},"html":{"href":"https://github.com/jessesquires/JSQMessagesViewController/pull/646"},"issue":{"href":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/issues/646"},"comments":{"href":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/issues/646/comments"},"review_comments":{"href":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/pulls/646/comments"},"review_comment":{"href":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/pulls/646/commits"},"statuses":{"href":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/statuses/276e9f94a65252098d139e9f7c1fb1631f63276d"}}}}