GitHub PullRequestEvent at 2014-12-09 10:03:27
Repository: JsonPath
Actor: jgogstad
Payload: {"action":"opened","number":63,"pull_request":{"url":"https://api.github.com/repos/jayway/JsonPath/pulls/63","id":25731099,"html_url":"https://github.com/jayway/JsonPath/pull/63","diff_url":"https://github.com/jayway/JsonPath/pull/63.diff","patch_url":"https://github.com/jayway/JsonPath/pull/63.patch","issue_url":"https://api.github.com/repos/jayway/JsonPath/issues/63","number":63,"state":"open","locked":false,"title":"Providers are not avaiable in OSGi containers. Moved package \"jsonpath.internal.spi\" to \"jsonpath.spi\".","user":{"login":"jgogstad","id":523922,"avatar_url":"https://avatars.githubusercontent.com/u/523922?v=3","gravatar_id":"","url":"https://api.github.com/users/jgogstad","html_url":"https://github.com/jgogstad","followers_url":"https://api.github.com/users/jgogstad/followers","following_url":"https://api.github.com/users/jgogstad/following{/other_user}","gists_url":"https://api.github.com/users/jgogstad/gists{/gist_id}","starred_url":"https://api.github.com/users/jgogstad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgogstad/subscriptions","organizations_url":"https://api.github.com/users/jgogstad/orgs","repos_url":"https://api.github.com/users/jgogstad/repos","events_url":"https://api.github.com/users/jgogstad/events{/privacy}","received_events_url":"https://api.github.com/users/jgogstad/received_events","type":"User","site_admin":false},"body":"Custom providers does not work on OSGi containers. Apache Felix's `maven-bundle-plugin` will not include packages named \"impl\" or \"internal\" ([documentation](http://felix.apache.org/site/apache-felix-maven-bundle-plugin-bnd.html)) in the `Export-Package`-header. Since all the providers resides in `com.jayway.jsonpath.internal.spi.json`, they are not exported, and clients on OSGi containers can not use them. This PR moves the package `com.jayway.jsonpath.internal.spi.json` to `com.jayway.jsonpath.spi.json` so that the providers can be used on OSGi.\r\n\r\nAnother interesting solution to the problem of configuring json-path on OSGi, is to use fragment-bundles to preload custom client code, http://wiki.osgi.org/wiki/Fragment. Just an idea.","created_at":"2014-12-09T10:03:27Z","updated_at":"2014-12-09T10:03:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jayway/JsonPath/pulls/63/commits","review_comments_url":"https://api.github.com/repos/jayway/JsonPath/pulls/63/comments","review_comment_url":"https://api.github.com/repos/jayway/JsonPath/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jayway/JsonPath/issues/63/comments","statuses_url":"https://api.github.com/repos/jayway/JsonPath/statuses/702142fcd27d529864d1594233bf9b4fb8d98a75","head":{"label":"jgogstad:master","ref":"master","sha":"702142fcd27d529864d1594233bf9b4fb8d98a75","user":{"login":"jgogstad","id":523922,"avatar_url":"https://avatars.githubusercontent.com/u/523922?v=3","gravatar_id":"","url":"https://api.github.com/users/jgogstad","html_url":"https://github.com/jgogstad","followers_url":"https://api.github.com/users/jgogstad/followers","following_url":"https://api.github.com/users/jgogstad/following{/other_user}","gists_url":"https://api.github.com/users/jgogstad/gists{/gist_id}","starred_url":"https://api.github.com/users/jgogstad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgogstad/subscriptions","organizations_url":"https://api.github.com/users/jgogstad/orgs","repos_url":"https://api.github.com/users/jgogstad/repos","events_url":"https://api.github.com/users/jgogstad/events{/privacy}","received_events_url":"https://api.github.com/users/jgogstad/received_events","type":"User","site_admin":false},"repo":{"id":25812462,"name":"JsonPath","full_name":"jgogstad/JsonPath","owner":{"login":"jgogstad","id":523922,"avatar_url":"https://avatars.githubusercontent.com/u/523922?v=3","gravatar_id":"","url":"https://api.github.com/users/jgogstad","html_url":"https://github.com/jgogstad","followers_url":"https://api.github.com/users/jgogstad/followers","following_url":"https://api.github.com/users/jgogstad/following{/other_user}","gists_url":"https://api.github.com/users/jgogstad/gists{/gist_id}","starred_url":"https://api.github.com/users/jgogstad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgogstad/subscriptions","organizations_url":"https://api.github.com/users/jgogstad/orgs","repos_url":"https://api.github.com/users/jgogstad/repos","events_url":"https://api.github.com/users/jgogstad/events{/privacy}","received_events_url":"https://api.github.com/users/jgogstad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jgogstad/JsonPath","description":"Java JsonPath implementation","fork":true,"url":"https://api.github.com/repos/jgogstad/JsonPath","forks_url":"https://api.github.com/repos/jgogstad/JsonPath/forks","keys_url":"https://api.github.com/repos/jgogstad/JsonPath/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jgogstad/JsonPath/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jgogstad/JsonPath/teams","hooks_url":"https://api.github.com/repos/jgogstad/JsonPath/hooks","issue_events_url":"https://api.github.com/repos/jgogstad/JsonPath/issues/events{/number}","events_url":"https://api.github.com/repos/jgogstad/JsonPath/events","assignees_url":"https://api.github.com/repos/jgogstad/JsonPath/assignees{/user}","branches_url":"https://api.github.com/repos/jgogstad/JsonPath/branches{/branch}","tags_url":"https://api.github.com/repos/jgogstad/JsonPath/tags","blobs_url":"https://api.github.com/repos/jgogstad/JsonPath/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jgogstad/JsonPath/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jgogstad/JsonPath/git/refs{/sha}","trees_url":"https://api.github.com/repos/jgogstad/JsonPath/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jgogstad/JsonPath/statuses/{sha}","languages_url":"https://api.github.com/repos/jgogstad/JsonPath/languages","stargazers_url":"https://api.github.com/repos/jgogstad/JsonPath/stargazers","contributors_url":"https://api.github.com/repos/jgogstad/JsonPath/contributors","subscribers_url":"https://api.github.com/repos/jgogstad/JsonPath/subscribers","subscription_url":"https://api.github.com/repos/jgogstad/JsonPath/subscription","commits_url":"https://api.github.com/repos/jgogstad/JsonPath/commits{/sha}","git_commits_url":"https://api.github.com/repos/jgogstad/JsonPath/git/commits{/sha}","comments_url":"https://api.github.com/repos/jgogstad/JsonPath/comments{/number}","issue_comment_url":"https://api.github.com/repos/jgogstad/JsonPath/issues/comments/{number}","contents_url":"https://api.github.com/repos/jgogstad/JsonPath/contents/{+path}","compare_url":"https://api.github.com/repos/jgogstad/JsonPath/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jgogstad/JsonPath/merges","archive_url":"https://api.github.com/repos/jgogstad/JsonPath/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jgogstad/JsonPath/downloads","issues_url":"https://api.github.com/repos/jgogstad/JsonPath/issues{/number}","pulls_url":"https://api.github.com/repos/jgogstad/JsonPath/pulls{/number}","milestones_url":"https://api.github.com/repos/jgogstad/JsonPath/milestones{/number}","notifications_url":"https://api.github.com/repos/jgogstad/JsonPath/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jgogstad/JsonPath/labels{/name}","releases_url":"https://api.github.com/repos/jgogstad/JsonPath/releases{/id}","created_at":"2014-10-27T09:50:09Z","updated_at":"2014-12-09T07:44:57Z","pushed_at":"2014-12-09T07:44:57Z","git_url":"git://github.com/jgogstad/JsonPath.git","ssh_url":"git@github.com:jgogstad/JsonPath.git","clone_url":"https://github.com/jgogstad/JsonPath.git","svn_url":"https://github.com/jgogstad/JsonPath","homepage":"http://code.google.com/p/json-path/","size":1487,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jayway:master","ref":"master","sha":"3457ccbc9220f0bcb8240052061bc0902ba6cf4a","user":{"login":"jayway","id":89926,"avatar_url":"https://avatars.githubusercontent.com/u/89926?v=3","gravatar_id":"","url":"https://api.github.com/users/jayway","html_url":"https://github.com/jayway","followers_url":"https://api.github.com/users/jayway/followers","following_url":"https://api.github.com/users/jayway/following{/other_user}","gists_url":"https://api.github.com/users/jayway/gists{/gist_id}","starred_url":"https://api.github.com/users/jayway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jayway/subscriptions","organizations_url":"https://api.github.com/users/jayway/orgs","repos_url":"https://api.github.com/users/jayway/repos","events_url":"https://api.github.com/users/jayway/events{/privacy}","received_events_url":"https://api.github.com/users/jayway/received_events","type":"Organization","site_admin":false},"repo":{"id":1287669,"name":"JsonPath","full_name":"jayway/JsonPath","owner":{"login":"jayway","id":89926,"avatar_url":"https://avatars.githubusercontent.com/u/89926?v=3","gravatar_id":"","url":"https://api.github.com/users/jayway","html_url":"https://github.com/jayway","followers_url":"https://api.github.com/users/jayway/followers","following_url":"https://api.github.com/users/jayway/following{/other_user}","gists_url":"https://api.github.com/users/jayway/gists{/gist_id}","starred_url":"https://api.github.com/users/jayway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jayway/subscriptions","organizations_url":"https://api.github.com/users/jayway/orgs","repos_url":"https://api.github.com/users/jayway/repos","events_url":"https://api.github.com/users/jayway/events{/privacy}","received_events_url":"https://api.github.com/users/jayway/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jayway/JsonPath","description":"Java JsonPath implementation","fork":false,"url":"https://api.github.com/repos/jayway/JsonPath","forks_url":"https://api.github.com/repos/jayway/JsonPath/forks","keys_url":"https://api.github.com/repos/jayway/JsonPath/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jayway/JsonPath/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jayway/JsonPath/teams","hooks_url":"https://api.github.com/repos/jayway/JsonPath/hooks","issue_events_url":"https://api.github.com/repos/jayway/JsonPath/issues/events{/number}","events_url":"https://api.github.com/repos/jayway/JsonPath/events","assignees_url":"https://api.github.com/repos/jayway/JsonPath/assignees{/user}","branches_url":"https://api.github.com/repos/jayway/JsonPath/branches{/branch}","tags_url":"https://api.github.com/repos/jayway/JsonPath/tags","blobs_url":"https://api.github.com/repos/jayway/JsonPath/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jayway/JsonPath/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jayway/JsonPath/git/refs{/sha}","trees_url":"https://api.github.com/repos/jayway/JsonPath/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jayway/JsonPath/statuses/{sha}","languages_url":"https://api.github.com/repos/jayway/JsonPath/languages","stargazers_url":"https://api.github.com/repos/jayway/JsonPath/stargazers","contributors_url":"https://api.github.com/repos/jayway/JsonPath/contributors","subscribers_url":"https://api.github.com/repos/jayway/JsonPath/subscribers","subscription_url":"https://api.github.com/repos/jayway/JsonPath/subscription","commits_url":"https://api.github.com/repos/jayway/JsonPath/commits{/sha}","git_commits_url":"https://api.github.com/repos/jayway/JsonPath/git/commits{/sha}","comments_url":"https://api.github.com/repos/jayway/JsonPath/comments{/number}","issue_comment_url":"https://api.github.com/repos/jayway/JsonPath/issues/comments/{number}","contents_url":"https://api.github.com/repos/jayway/JsonPath/contents/{+path}","compare_url":"https://api.github.com/repos/jayway/JsonPath/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jayway/JsonPath/merges","archive_url":"https://api.github.com/repos/jayway/JsonPath/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jayway/JsonPath/downloads","issues_url":"https://api.github.com/repos/jayway/JsonPath/issues{/number}","pulls_url":"https://api.github.com/repos/jayway/JsonPath/pulls{/number}","milestones_url":"https://api.github.com/repos/jayway/JsonPath/milestones{/number}","notifications_url":"https://api.github.com/repos/jayway/JsonPath/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jayway/JsonPath/labels{/name}","releases_url":"https://api.github.com/repos/jayway/JsonPath/releases{/id}","created_at":"2011-01-24T13:19:19Z","updated_at":"2014-12-08T17:40:20Z","pushed_at":"2014-12-08T12:42:32Z","git_url":"git://github.com/jayway/JsonPath.git","ssh_url":"git@github.com:jayway/JsonPath.git","clone_url":"https://github.com/jayway/JsonPath.git","svn_url":"https://github.com/jayway/JsonPath","homepage":"http://code.google.com/p/json-path/","size":2714,"stargazers_count":256,"watchers_count":256,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":115,"mirror_url":null,"open_issues_count":4,"forks":115,"open_issues":4,"watchers":256,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jayway/JsonPath/pulls/63"},"html":{"href":"https://github.com/jayway/JsonPath/pull/63"},"issue":{"href":"https://api.github.com/repos/jayway/JsonPath/issues/63"},"comments":{"href":"https://api.github.com/repos/jayway/JsonPath/issues/63/comments"},"review_comments":{"href":"https://api.github.com/repos/jayway/JsonPath/pulls/63/comments"},"review_comment":{"href":"https://api.github.com/repos/jayway/JsonPath/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jayway/JsonPath/pulls/63/commits"},"statuses":{"href":"https://api.github.com/repos/jayway/JsonPath/statuses/702142fcd27d529864d1594233bf9b4fb8d98a75"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":18,"deletions":30,"changed_files":13}}