GitHub PullRequestEvent at 2014-11-09 13:31:34
Repository: neovim
Actor: jszakmeister
Payload: {"action":"closed","number":1437,"pull_request":{"url":"https://api.github.com/repos/neovim/neovim/pulls/1437","id":24106541,"html_url":"https://github.com/neovim/neovim/pull/1437","diff_url":"https://github.com/neovim/neovim/pull/1437.diff","patch_url":"https://github.com/neovim/neovim/pull/1437.patch","issue_url":"https://api.github.com/repos/neovim/neovim/issues/1437","number":1437,"state":"closed","locked":false,"title":"[RFC] A few fixes for some build-related issues.","user":{"login":"jszakmeister","id":448087,"avatar_url":"https://avatars.githubusercontent.com/u/448087?v=3","gravatar_id":"","url":"https://api.github.com/users/jszakmeister","html_url":"https://github.com/jszakmeister","followers_url":"https://api.github.com/users/jszakmeister/followers","following_url":"https://api.github.com/users/jszakmeister/following{/other_user}","gists_url":"https://api.github.com/users/jszakmeister/gists{/gist_id}","starred_url":"https://api.github.com/users/jszakmeister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jszakmeister/subscriptions","organizations_url":"https://api.github.com/users/jszakmeister/orgs","repos_url":"https://api.github.com/users/jszakmeister/repos","events_url":"https://api.github.com/users/jszakmeister/events{/privacy}","received_events_url":"https://api.github.com/users/jszakmeister/received_events","type":"User","site_admin":false},"body":"This should fix an issue discovered in #1370, as well as provide more control if someone needs to select a particular iconv library.  The root of the problem stems from the fact that CMake treats `/sw` and `/opt/local` almost as extensions to the system paths by appending them after the normal system paths, but you quickly run into problems if a dependency is found there.  Since other dependencies offered by the system may also be available in `/opt/local`, you can run into version issues--which was the root cause of the problem discussed in #1370.  So this PR moves them up in priority.\r\n\r\nThis also fixes an improper use of `LibIntl_INCLUDE_DIR`--it should be `LibIntl_INCLUDE_DIRS`, though it's not a serious issue.","created_at":"2014-11-08T21:43:13Z","updated_at":"2014-11-09T13:31:33Z","closed_at":"2014-11-09T13:31:33Z","merged_at":"2014-11-09T13:31:33Z","merge_commit_sha":"23becf5ea1e889fa6b3330e523d087b797311d20","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/neovim/neovim/pulls/1437/commits","review_comments_url":"https://api.github.com/repos/neovim/neovim/pulls/1437/comments","review_comment_url":"https://api.github.com/repos/neovim/neovim/pulls/comments/{number}","comments_url":"https://api.github.com/repos/neovim/neovim/issues/1437/comments","statuses_url":"https://api.github.com/repos/neovim/neovim/statuses/9344a40e741557948215dfeb4ae32b7c0d6d7b6b","head":{"label":"jszakmeister:build-search-fixes","ref":"build-search-fixes","sha":"9344a40e741557948215dfeb4ae32b7c0d6d7b6b","user":{"login":"jszakmeister","id":448087,"avatar_url":"https://avatars.githubusercontent.com/u/448087?v=3","gravatar_id":"","url":"https://api.github.com/users/jszakmeister","html_url":"https://github.com/jszakmeister","followers_url":"https://api.github.com/users/jszakmeister/followers","following_url":"https://api.github.com/users/jszakmeister/following{/other_user}","gists_url":"https://api.github.com/users/jszakmeister/gists{/gist_id}","starred_url":"https://api.github.com/users/jszakmeister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jszakmeister/subscriptions","organizations_url":"https://api.github.com/users/jszakmeister/orgs","repos_url":"https://api.github.com/users/jszakmeister/repos","events_url":"https://api.github.com/users/jszakmeister/events{/privacy}","received_events_url":"https://api.github.com/users/jszakmeister/received_events","type":"User","site_admin":false},"repo":{"id":17115700,"name":"neovim","full_name":"jszakmeister/neovim","owner":{"login":"jszakmeister","id":448087,"avatar_url":"https://avatars.githubusercontent.com/u/448087?v=3","gravatar_id":"","url":"https://api.github.com/users/jszakmeister","html_url":"https://github.com/jszakmeister","followers_url":"https://api.github.com/users/jszakmeister/followers","following_url":"https://api.github.com/users/jszakmeister/following{/other_user}","gists_url":"https://api.github.com/users/jszakmeister/gists{/gist_id}","starred_url":"https://api.github.com/users/jszakmeister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jszakmeister/subscriptions","organizations_url":"https://api.github.com/users/jszakmeister/orgs","repos_url":"https://api.github.com/users/jszakmeister/repos","events_url":"https://api.github.com/users/jszakmeister/events{/privacy}","received_events_url":"https://api.github.com/users/jszakmeister/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jszakmeister/neovim","description":"Vim's rebirth for the 21st century","fork":true,"url":"https://api.github.com/repos/jszakmeister/neovim","forks_url":"https://api.github.com/repos/jszakmeister/neovim/forks","keys_url":"https://api.github.com/repos/jszakmeister/neovim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jszakmeister/neovim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jszakmeister/neovim/teams","hooks_url":"https://api.github.com/repos/jszakmeister/neovim/hooks","issue_events_url":"https://api.github.com/repos/jszakmeister/neovim/issues/events{/number}","events_url":"https://api.github.com/repos/jszakmeister/neovim/events","assignees_url":"https://api.github.com/repos/jszakmeister/neovim/assignees{/user}","branches_url":"https://api.github.com/repos/jszakmeister/neovim/branches{/branch}","tags_url":"https://api.github.com/repos/jszakmeister/neovim/tags","blobs_url":"https://api.github.com/repos/jszakmeister/neovim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jszakmeister/neovim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jszakmeister/neovim/git/refs{/sha}","trees_url":"https://api.github.com/repos/jszakmeister/neovim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jszakmeister/neovim/statuses/{sha}","languages_url":"https://api.github.com/repos/jszakmeister/neovim/languages","stargazers_url":"https://api.github.com/repos/jszakmeister/neovim/stargazers","contributors_url":"https://api.github.com/repos/jszakmeister/neovim/contributors","subscribers_url":"https://api.github.com/repos/jszakmeister/neovim/subscribers","subscription_url":"https://api.github.com/repos/jszakmeister/neovim/subscription","commits_url":"https://api.github.com/repos/jszakmeister/neovim/commits{/sha}","git_commits_url":"https://api.github.com/repos/jszakmeister/neovim/git/commits{/sha}","comments_url":"https://api.github.com/repos/jszakmeister/neovim/comments{/number}","issue_comment_url":"https://api.github.com/repos/jszakmeister/neovim/issues/comments/{number}","contents_url":"https://api.github.com/repos/jszakmeister/neovim/contents/{+path}","compare_url":"https://api.github.com/repos/jszakmeister/neovim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jszakmeister/neovim/merges","archive_url":"https://api.github.com/repos/jszakmeister/neovim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jszakmeister/neovim/downloads","issues_url":"https://api.github.com/repos/jszakmeister/neovim/issues{/number}","pulls_url":"https://api.github.com/repos/jszakmeister/neovim/pulls{/number}","milestones_url":"https://api.github.com/repos/jszakmeister/neovim/milestones{/number}","notifications_url":"https://api.github.com/repos/jszakmeister/neovim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jszakmeister/neovim/labels{/name}","releases_url":"https://api.github.com/repos/jszakmeister/neovim/releases{/id}","created_at":"2014-02-23T19:59:02Z","updated_at":"2014-08-01T10:21:22Z","pushed_at":"2014-11-09T13:31:09Z","git_url":"git://github.com/jszakmeister/neovim.git","ssh_url":"git@github.com:jszakmeister/neovim.git","clone_url":"https://github.com/jszakmeister/neovim.git","svn_url":"https://github.com/jszakmeister/neovim","homepage":"","size":25525,"stargazers_count":1,"watchers_count":1,"language":"VimL","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"neovim:master","ref":"master","sha":"2aeda4ba6f033707dd96daabd2084d239ac82b3d","user":{"login":"neovim","id":6471485,"avatar_url":"https://avatars.githubusercontent.com/u/6471485?v=3","gravatar_id":"","url":"https://api.github.com/users/neovim","html_url":"https://github.com/neovim","followers_url":"https://api.github.com/users/neovim/followers","following_url":"https://api.github.com/users/neovim/following{/other_user}","gists_url":"https://api.github.com/users/neovim/gists{/gist_id}","starred_url":"https://api.github.com/users/neovim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neovim/subscriptions","organizations_url":"https://api.github.com/users/neovim/orgs","repos_url":"https://api.github.com/users/neovim/repos","events_url":"https://api.github.com/users/neovim/events{/privacy}","received_events_url":"https://api.github.com/users/neovim/received_events","type":"Organization","site_admin":false},"repo":{"id":16408992,"name":"neovim","full_name":"neovim/neovim","owner":{"login":"neovim","id":6471485,"avatar_url":"https://avatars.githubusercontent.com/u/6471485?v=3","gravatar_id":"","url":"https://api.github.com/users/neovim","html_url":"https://github.com/neovim","followers_url":"https://api.github.com/users/neovim/followers","following_url":"https://api.github.com/users/neovim/following{/other_user}","gists_url":"https://api.github.com/users/neovim/gists{/gist_id}","starred_url":"https://api.github.com/users/neovim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neovim/subscriptions","organizations_url":"https://api.github.com/users/neovim/orgs","repos_url":"https://api.github.com/users/neovim/repos","events_url":"https://api.github.com/users/neovim/events{/privacy}","received_events_url":"https://api.github.com/users/neovim/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neovim/neovim","description":"vim for the 21st century","fork":false,"url":"https://api.github.com/repos/neovim/neovim","forks_url":"https://api.github.com/repos/neovim/neovim/forks","keys_url":"https://api.github.com/repos/neovim/neovim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neovim/neovim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neovim/neovim/teams","hooks_url":"https://api.github.com/repos/neovim/neovim/hooks","issue_events_url":"https://api.github.com/repos/neovim/neovim/issues/events{/number}","events_url":"https://api.github.com/repos/neovim/neovim/events","assignees_url":"https://api.github.com/repos/neovim/neovim/assignees{/user}","branches_url":"https://api.github.com/repos/neovim/neovim/branches{/branch}","tags_url":"https://api.github.com/repos/neovim/neovim/tags","blobs_url":"https://api.github.com/repos/neovim/neovim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neovim/neovim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neovim/neovim/git/refs{/sha}","trees_url":"https://api.github.com/repos/neovim/neovim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neovim/neovim/statuses/{sha}","languages_url":"https://api.github.com/repos/neovim/neovim/languages","stargazers_url":"https://api.github.com/repos/neovim/neovim/stargazers","contributors_url":"https://api.github.com/repos/neovim/neovim/contributors","subscribers_url":"https://api.github.com/repos/neovim/neovim/subscribers","subscription_url":"https://api.github.com/repos/neovim/neovim/subscription","commits_url":"https://api.github.com/repos/neovim/neovim/commits{/sha}","git_commits_url":"https://api.github.com/repos/neovim/neovim/git/commits{/sha}","comments_url":"https://api.github.com/repos/neovim/neovim/comments{/number}","issue_comment_url":"https://api.github.com/repos/neovim/neovim/issues/comments/{number}","contents_url":"https://api.github.com/repos/neovim/neovim/contents/{+path}","compare_url":"https://api.github.com/repos/neovim/neovim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neovim/neovim/merges","archive_url":"https://api.github.com/repos/neovim/neovim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neovim/neovim/downloads","issues_url":"https://api.github.com/repos/neovim/neovim/issues{/number}","pulls_url":"https://api.github.com/repos/neovim/neovim/pulls{/number}","milestones_url":"https://api.github.com/repos/neovim/neovim/milestones{/number}","notifications_url":"https://api.github.com/repos/neovim/neovim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neovim/neovim/labels{/name}","releases_url":"https://api.github.com/repos/neovim/neovim/releases{/id}","created_at":"2014-01-31T13:39:22Z","updated_at":"2014-11-09T12:58:24Z","pushed_at":"2014-11-09T13:31:33Z","git_url":"git://github.com/neovim/neovim.git","ssh_url":"git@github.com:neovim/neovim.git","clone_url":"https://github.com/neovim/neovim.git","svn_url":"https://github.com/neovim/neovim","homepage":"http://neovim.org/","size":63096,"stargazers_count":10476,"watchers_count":10476,"language":"VimL","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":679,"mirror_url":null,"open_issues_count":264,"forks":679,"open_issues":264,"watchers":10476,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/neovim/neovim/pulls/1437"},"html":{"href":"https://github.com/neovim/neovim/pull/1437"},"issue":{"href":"https://api.github.com/repos/neovim/neovim/issues/1437"},"comments":{"href":"https://api.github.com/repos/neovim/neovim/issues/1437/comments"},"review_comments":{"href":"https://api.github.com/repos/neovim/neovim/pulls/1437/comments"},"review_comment":{"href":"https://api.github.com/repos/neovim/neovim/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/neovim/neovim/pulls/1437/commits"},"statuses":{"href":"https://api.github.com/repos/neovim/neovim/statuses/9344a40e741557948215dfeb4ae32b7c0d6d7b6b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jszakmeister","id":448087,"avatar_url":"https://avatars.githubusercontent.com/u/448087?v=3","gravatar_id":"","url":"https://api.github.com/users/jszakmeister","html_url":"https://github.com/jszakmeister","followers_url":"https://api.github.com/users/jszakmeister/followers","following_url":"https://api.github.com/users/jszakmeister/following{/other_user}","gists_url":"https://api.github.com/users/jszakmeister/gists{/gist_id}","starred_url":"https://api.github.com/users/jszakmeister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jszakmeister/subscriptions","organizations_url":"https://api.github.com/users/jszakmeister/orgs","repos_url":"https://api.github.com/users/jszakmeister/repos","events_url":"https://api.github.com/users/jszakmeister/events{/privacy}","received_events_url":"https://api.github.com/users/jszakmeister/received_events","type":"User","site_admin":false},"comments":5,"review_comments":3,"commits":3,"additions":48,"deletions":19,"changed_files":4}}