GitHub PullRequestEvent at 2014-04-15 14:02:09
Repository: meteor-session-timeout
Actor: eluck
Payload: {"action":"opened","number":1,"pull_request":{"url":"https://api.github.com/repos/recursivefaults/meteor-session-timeout/pulls/1","id":14771045,"html_url":"https://github.com/recursivefaults/meteor-session-timeout/pull/1","diff_url":"https://github.com/recursivefaults/meteor-session-timeout/pull/1.diff","patch_url":"https://github.com/recursivefaults/meteor-session-timeout/pull/1.patch","issue_url":"https://api.github.com/repos/recursivefaults/meteor-session-timeout/issues/1","number":1,"state":"open","title":"Increased stability and flexibility, and decreased resources consumption","user":{"login":"eluck","id":3399956,"avatar_url":"https://avatars.githubusercontent.com/u/3399956?","gravatar_id":"7fb9fe2dd38d99bae14191e5e340fb94","url":"https://api.github.com/users/eluck","html_url":"https://github.com/eluck","followers_url":"https://api.github.com/users/eluck/followers","following_url":"https://api.github.com/users/eluck/following{/other_user}","gists_url":"https://api.github.com/users/eluck/gists{/gist_id}","starred_url":"https://api.github.com/users/eluck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eluck/subscriptions","organizations_url":"https://api.github.com/users/eluck/orgs","repos_url":"https://api.github.com/users/eluck/repos","events_url":"https://api.github.com/users/eluck/events{/privacy}","received_events_url":"https://api.github.com/users/eluck/received_events","type":"User","site_admin":false},"body":"Thanks for your contribution and for that I didn't have to invent things myself. However to suit my needs, I had to tweak the project. List of changes:\r\n\r\n1. Set `services.resume.forceLogout` istead of deleteing login tokens. After deleteing login tokens collections' publication is likely to stop, so user might not even get to know that the tokens were deleted. It's the only reason I could think of when the project didn't work for me. (It might be interesting that Meteor solves the similar task the similar way)\r\n\r\n2. Replaced multiple DB requests by requests containing arrays. This should work faster.\r\n\r\n3. Added custom logout function Meteor.forcedLogout which anyone can override to employ custom logout logic.\r\n\r\n4. Added loginAttempt handler which should wear off all forced logout effects.\r\n\r\n5. Increased timeouts because querying Meteor.users every 3 seconds is too expensive. Let a DB server work for users and not for nothing.\r\n\r\nBest,\r\nEvgeny","created_at":"2014-04-15T14:02:08Z","updated_at":"2014-04-15T14:02:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/recursivefaults/meteor-session-timeout/pulls/1/commits","review_comments_url":"https://api.github.com/repos/recursivefaults/meteor-session-timeout/pulls/1/comments","review_comment_url":"https://api.github.com/repos/recursivefaults/meteor-session-timeout/pulls/comments/{number}","comments_url":"https://api.github.com/repos/recursivefaults/meteor-session-timeout/issues/1/comments","statuses_url":"https://api.github.com/repos/recursivefaults/meteor-session-timeout/statuses/778b44ea384684c30b4598d3bce656b4203a8813","head":{"label":"eluck:master","ref":"master","sha":"778b44ea384684c30b4598d3bce656b4203a8813","user":{"login":"eluck","id":3399956,"avatar_url":"https://avatars.githubusercontent.com/u/3399956?","gravatar_id":"7fb9fe2dd38d99bae14191e5e340fb94","url":"https://api.github.com/users/eluck","html_url":"https://github.com/eluck","followers_url":"https://api.github.com/users/eluck/followers","following_url":"https://api.github.com/users/eluck/following{/other_user}","gists_url":"https://api.github.com/users/eluck/gists{/gist_id}","starred_url":"https://api.github.com/users/eluck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eluck/subscriptions","organizations_url":"https://api.github.com/users/eluck/orgs","repos_url":"https://api.github.com/users/eluck/repos","events_url":"https://api.github.com/users/eluck/events{/privacy}","received_events_url":"https://api.github.com/users/eluck/received_events","type":"User","site_admin":false},"repo":{"id":18794445,"name":"meteor-session-timeout","full_name":"eluck/meteor-session-timeout","owner":{"login":"eluck","id":3399956,"avatar_url":"https://avatars.githubusercontent.com/u/3399956?","gravatar_id":"7fb9fe2dd38d99bae14191e5e340fb94","url":"https://api.github.com/users/eluck","html_url":"https://github.com/eluck","followers_url":"https://api.github.com/users/eluck/followers","following_url":"https://api.github.com/users/eluck/following{/other_user}","gists_url":"https://api.github.com/users/eluck/gists{/gist_id}","starred_url":"https://api.github.com/users/eluck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eluck/subscriptions","organizations_url":"https://api.github.com/users/eluck/orgs","repos_url":"https://api.github.com/users/eluck/repos","events_url":"https://api.github.com/users/eluck/events{/privacy}","received_events_url":"https://api.github.com/users/eluck/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eluck/meteor-session-timeout","description":"A simple meteorite package to give you session timeouts.","fork":true,"url":"https://api.github.com/repos/eluck/meteor-session-timeout","forks_url":"https://api.github.com/repos/eluck/meteor-session-timeout/forks","keys_url":"https://api.github.com/repos/eluck/meteor-session-timeout/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eluck/meteor-session-timeout/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eluck/meteor-session-timeout/teams","hooks_url":"https://api.github.com/repos/eluck/meteor-session-timeout/hooks","issue_events_url":"https://api.github.com/repos/eluck/meteor-session-timeout/issues/events{/number}","events_url":"https://api.github.com/repos/eluck/meteor-session-timeout/events","assignees_url":"https://api.github.com/repos/eluck/meteor-session-timeout/assignees{/user}","branches_url":"https://api.github.com/repos/eluck/meteor-session-timeout/branches{/branch}","tags_url":"https://api.github.com/repos/eluck/meteor-session-timeout/tags","blobs_url":"https://api.github.com/repos/eluck/meteor-session-timeout/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eluck/meteor-session-timeout/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eluck/meteor-session-timeout/git/refs{/sha}","trees_url":"https://api.github.com/repos/eluck/meteor-session-timeout/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eluck/meteor-session-timeout/statuses/{sha}","languages_url":"https://api.github.com/repos/eluck/meteor-session-timeout/languages","stargazers_url":"https://api.github.com/repos/eluck/meteor-session-timeout/stargazers","contributors_url":"https://api.github.com/repos/eluck/meteor-session-timeout/contributors","subscribers_url":"https://api.github.com/repos/eluck/meteor-session-timeout/subscribers","subscription_url":"https://api.github.com/repos/eluck/meteor-session-timeout/subscription","commits_url":"https://api.github.com/repos/eluck/meteor-session-timeout/commits{/sha}","git_commits_url":"https://api.github.com/repos/eluck/meteor-session-timeout/git/commits{/sha}","comments_url":"https://api.github.com/repos/eluck/meteor-session-timeout/comments{/number}","issue_comment_url":"https://api.github.com/repos/eluck/meteor-session-timeout/issues/comments/{number}","contents_url":"https://api.github.com/repos/eluck/meteor-session-timeout/contents/{+path}","compare_url":"https://api.github.com/repos/eluck/meteor-session-timeout/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eluck/meteor-session-timeout/merges","archive_url":"https://api.github.com/repos/eluck/meteor-session-timeout/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eluck/meteor-session-timeout/downloads","issues_url":"https://api.github.com/repos/eluck/meteor-session-timeout/issues{/number}","pulls_url":"https://api.github.com/repos/eluck/meteor-session-timeout/pulls{/number}","milestones_url":"https://api.github.com/repos/eluck/meteor-session-timeout/milestones{/number}","notifications_url":"https://api.github.com/repos/eluck/meteor-session-timeout/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eluck/meteor-session-timeout/labels{/name}","releases_url":"https://api.github.com/repos/eluck/meteor-session-timeout/releases{/id}","created_at":"2014-04-15T09:25:14Z","updated_at":"2014-04-15T14:02:09Z","pushed_at":"2014-04-15T13:45:38Z","git_url":"git://github.com/eluck/meteor-session-timeout.git","ssh_url":"git@github.com:eluck/meteor-session-timeout.git","clone_url":"https://github.com/eluck/meteor-session-timeout.git","svn_url":"https://github.com/eluck/meteor-session-timeout","homepage":null,"size":126,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"recursivefaults:master","ref":"master","sha":"13d0f8113e806ac3b1a74f92ac85c018241cc9c2","user":{"login":"recursivefaults","id":792405,"avatar_url":"https://avatars.githubusercontent.com/u/792405?","gravatar_id":"71d55537710ab6fe89b023b6382cffaf","url":"https://api.github.com/users/recursivefaults","html_url":"https://github.com/recursivefaults","followers_url":"https://api.github.com/users/recursivefaults/followers","following_url":"https://api.github.com/users/recursivefaults/following{/other_user}","gists_url":"https://api.github.com/users/recursivefaults/gists{/gist_id}","starred_url":"https://api.github.com/users/recursivefaults/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/recursivefaults/subscriptions","organizations_url":"https://api.github.com/users/recursivefaults/orgs","repos_url":"https://api.github.com/users/recursivefaults/repos","events_url":"https://api.github.com/users/recursivefaults/events{/privacy}","received_events_url":"https://api.github.com/users/recursivefaults/received_events","type":"User","site_admin":false},"repo":{"id":12651061,"name":"meteor-session-timeout","full_name":"recursivefaults/meteor-session-timeout","owner":{"login":"recursivefaults","id":792405,"avatar_url":"https://avatars.githubusercontent.com/u/792405?","gravatar_id":"71d55537710ab6fe89b023b6382cffaf","url":"https://api.github.com/users/recursivefaults","html_url":"https://github.com/recursivefaults","followers_url":"https://api.github.com/users/recursivefaults/followers","following_url":"https://api.github.com/users/recursivefaults/following{/other_user}","gists_url":"https://api.github.com/users/recursivefaults/gists{/gist_id}","starred_url":"https://api.github.com/users/recursivefaults/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/recursivefaults/subscriptions","organizations_url":"https://api.github.com/users/recursivefaults/orgs","repos_url":"https://api.github.com/users/recursivefaults/repos","events_url":"https://api.github.com/users/recursivefaults/events{/privacy}","received_events_url":"https://api.github.com/users/recursivefaults/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/recursivefaults/meteor-session-timeout","description":"A simple meteorite package to give you session timeouts.","fork":false,"url":"https://api.github.com/repos/recursivefaults/meteor-session-timeout","forks_url":"https://api.github.com/repos/recursivefaults/meteor-session-timeout/forks","keys_url":"https://api.github.com/repos/recursivefaults/meteor-session-timeout/keys{/key_id}","collaborators_url":"https://api.github.com/repos/recursivefaults/meteor-session-timeout/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/recursivefaults/meteor-session-timeout/teams","hooks_url":"https://api.github.com/repos/recursivefaults/meteor-session-timeout/hooks","issue_events_url":"https://api.github.com/repos/recursivefaults/meteor-session-timeout/issues/events{/number}","events_url":"https://api.github.com/repos/recursivefaults/meteor-session-timeout/events","assignees_url":"https://api.github.com/repos/recursivefaults/meteor-session-timeout/assignees{/user}","branches_url":"https://api.github.com/repos/recursivefaults/meteor-session-timeout/branches{/branch}","tags_url":"https://api.github.com/repos/recursivefaults/meteor-session-timeout/tags","blobs_url":"https://api.github.com/repos/recursivefaults/meteor-session-timeout/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/recursivefaults/meteor-session-timeout/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/recursivefaults/meteor-session-timeout/git/refs{/sha}","trees_url":"https://api.github.com/repos/recursivefaults/meteor-session-timeout/git/trees{/sha}","statuses_url":"https://api.github.com/repos/recursivefaults/meteor-session-timeout/statuses/{sha}","languages_url":"https://api.github.com/repos/recursivefaults/meteor-session-timeout/languages","stargazers_url":"https://api.github.com/repos/recursivefaults/meteor-session-timeout/stargazers","contributors_url":"https://api.github.com/repos/recursivefaults/meteor-session-timeout/contributors","subscribers_url":"https://api.github.com/repos/recursivefaults/meteor-session-timeout/subscribers","subscription_url":"https://api.github.com/repos/recursivefaults/meteor-session-timeout/subscription","commits_url":"https://api.github.com/repos/recursivefaults/meteor-session-timeout/commits{/sha}","git_commits_url":"https://api.github.com/repos/recursivefaults/meteor-session-timeout/git/commits{/sha}","comments_url":"https://api.github.com/repos/recursivefaults/meteor-session-timeout/comments{/number}","issue_comment_url":"https://api.github.com/repos/recursivefaults/meteor-session-timeout/issues/comments/{number}","contents_url":"https://api.github.com/repos/recursivefaults/meteor-session-timeout/contents/{+path}","compare_url":"https://api.github.com/repos/recursivefaults/meteor-session-timeout/compare/{base}...{head}","merges_url":"https://api.github.com/repos/recursivefaults/meteor-session-timeout/merges","archive_url":"https://api.github.com/repos/recursivefaults/meteor-session-timeout/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/recursivefaults/meteor-session-timeout/downloads","issues_url":"https://api.github.com/repos/recursivefaults/meteor-session-timeout/issues{/number}","pulls_url":"https://api.github.com/repos/recursivefaults/meteor-session-timeout/pulls{/number}","milestones_url":"https://api.github.com/repos/recursivefaults/meteor-session-timeout/milestones{/number}","notifications_url":"https://api.github.com/repos/recursivefaults/meteor-session-timeout/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/recursivefaults/meteor-session-timeout/labels{/name}","releases_url":"https://api.github.com/repos/recursivefaults/meteor-session-timeout/releases{/id}","created_at":"2013-09-06T18:12:49Z","updated_at":"2013-11-30T11:16:23Z","pushed_at":"2013-09-10T18:25:08Z","git_url":"git://github.com/recursivefaults/meteor-session-timeout.git","ssh_url":"git@github.com:recursivefaults/meteor-session-timeout.git","clone_url":"https://github.com/recursivefaults/meteor-session-timeout.git","svn_url":"https://github.com/recursivefaults/meteor-session-timeout","homepage":null,"size":140,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/recursivefaults/meteor-session-timeout/pulls/1"},"html":{"href":"https://github.com/recursivefaults/meteor-session-timeout/pull/1"},"issue":{"href":"https://api.github.com/repos/recursivefaults/meteor-session-timeout/issues/1"},"comments":{"href":"https://api.github.com/repos/recursivefaults/meteor-session-timeout/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/recursivefaults/meteor-session-timeout/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/recursivefaults/meteor-session-timeout/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/recursivefaults/meteor-session-timeout/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/recursivefaults/meteor-session-timeout/statuses/778b44ea384684c30b4598d3bce656b4203a8813"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":9,"additions":70,"deletions":52,"changed_files":6}}