GitHub PullRequestReviewCommentEvent at 2014-04-16 09:32:57
Repository: logsearch-boshrelease
Actor: wdneto
Payload: {"comment":{"url":"https://api.github.com/repos/logsearch/logsearch-boshrelease/pulls/comments/11676255","id":11676255,"diff_hunk":"@@ -1,5 +1,10 @@\n input {\n-\tsyslog {\n+\ttcp {","path":"jobs/ingestor_syslog/templates/config/syslog_to_redis.conf.erb","position":3,"original_position":3,"commit_id":"7644df2dd9fca6a13bc981749b0703e5314b67bb","original_commit_id":"7644df2dd9fca6a13bc981749b0703e5314b67bb","user":{"login":"wdneto","id":6300112,"avatar_url":"https://avatars.githubusercontent.com/u/6300112?","gravatar_id":"26e37b7e73ba4e8c6612e38abd4a5364","url":"https://api.github.com/users/wdneto","html_url":"https://github.com/wdneto","followers_url":"https://api.github.com/users/wdneto/followers","following_url":"https://api.github.com/users/wdneto/following{/other_user}","gists_url":"https://api.github.com/users/wdneto/gists{/gist_id}","starred_url":"https://api.github.com/users/wdneto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wdneto/subscriptions","organizations_url":"https://api.github.com/users/wdneto/orgs","repos_url":"https://api.github.com/users/wdneto/repos","events_url":"https://api.github.com/users/wdneto/events{/privacy}","received_events_url":"https://api.github.com/users/wdneto/received_events","type":"User","site_admin":false},"body":"That would work. As an alternative solution, we could do the same as what the syslog input does, at the logstash-filters-common level.\r\n\r\nThis would allow you to still support both methods (but put if statements around them), and still allows you to specify syslog_forwarder.all on CF, thereby capturing both vcap as well as general server syslog (which means you cannot have multiple log endpoints).\r\n\r\nAs for naming, could we not simply merge all ingestors into one, and allowing ingestor.transport: (relp|tcp|udp|lumberjack)?","created_at":"2014-04-16T09:32:57Z","updated_at":"2014-04-16T09:32:57Z","html_url":"https://github.com/logsearch/logsearch-boshrelease/pull/7#discussion_r11676255","pull_request_url":"https://api.github.com/repos/logsearch/logsearch-boshrelease/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/logsearch/logsearch-boshrelease/pulls/comments/11676255"},"html":{"href":"https://github.com/logsearch/logsearch-boshrelease/pull/7#discussion_r11676255"},"pull_request":{"href":"https://api.github.com/repos/logsearch/logsearch-boshrelease/pulls/7"}}}}