GitHub PullRequestReviewCommentEvent at 2014-06-04 15:50:24
Repository: ValueView
Actor: thiemowmde
Payload: {"comment":{"url":"https://api.github.com/repos/wmde/ValueView/pulls/comments/13393732","id":13393732,"diff_hunk":"@@ -16,16 +16,71 @@\n \n \ttestExpertExtenderExtension.constructor(\n \t\tExpertExtender.Listrotator,\n-\t\tnew ExpertExtender.Listrotator( '', [ 'value' ] )\n+\t\tnew ExpertExtender.Listrotator( '', [ { value: 'value', label: 'label' } ] )\n \t);\n \ttestExpertExtenderExtension.destroy(\n \t\tExpertExtender.Listrotator,\n-\t\tnew ExpertExtender.Listrotator( '', [ 'value' ] )\n+\t\tnew ExpertExtender.Listrotator( '', [ { value: 'value', label: 'label' } ] )\n \t);\n \ttestExpertExtenderExtension.init(\n-\t\tnew ExpertExtender.Listrotator( '', [ 'value' ] )\n+\t\tnew ExpertExtender.Listrotator( '', [ { value: 'value', label: 'label' } ] )\n \t);\n \n+\tQUnit.test( 'supports custom values', function( assert ) {\n+\t\tvar getUpstreamValue = function() {\n+\t\t\treturn {\n+\t\t\t\tcustom: true,\n+\t\t\t\tvalue: 'custom value',\n+\t\t\t\tlabel: 'label for custom value'\n+\t\t\t};\n+\t\t};\n+\t\tvar $extender = $( '<div />' );\n+\n+\t\tvar listrotator = new ExpertExtender.Listrotator(\n+\t\t\t'',\n+\t\t\t[ { value: 'fixed value', label: 'label for fixed value' } ],","path":"tests/src/ExpertExtender/ExpertExtender.Listrotator.tests.js","position":29,"original_position":29,"commit_id":"e5a4e95f246f3cd653e14577eea673614d0194d6","original_commit_id":"e5a4e95f246f3cd653e14577eea673614d0194d6","user":{"login":"thiemowmde","id":6576639,"avatar_url":"https://avatars.githubusercontent.com/u/6576639?","gravatar_id":"37a5d7555c26958a623057f5937bbe05","url":"https://api.github.com/users/thiemowmde","html_url":"https://github.com/thiemowmde","followers_url":"https://api.github.com/users/thiemowmde/followers","following_url":"https://api.github.com/users/thiemowmde/following{/other_user}","gists_url":"https://api.github.com/users/thiemowmde/gists{/gist_id}","starred_url":"https://api.github.com/users/thiemowmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thiemowmde/subscriptions","organizations_url":"https://api.github.com/users/thiemowmde/orgs","repos_url":"https://api.github.com/users/thiemowmde/repos","events_url":"https://api.github.com/users/thiemowmde/events{/privacy}","received_events_url":"https://api.github.com/users/thiemowmde/received_events","type":"User","site_admin":false},"body":"It seems you are testing here with non-custom values that are object and not numbers as the code above expects. Shouldn't this test fail then?","created_at":"2014-06-04T15:50:24Z","updated_at":"2014-06-04T15:50:24Z","html_url":"https://github.com/wmde/ValueView/pull/58#discussion_r13393732","pull_request_url":"https://api.github.com/repos/wmde/ValueView/pulls/58","_links":{"self":{"href":"https://api.github.com/repos/wmde/ValueView/pulls/comments/13393732"},"html":{"href":"https://github.com/wmde/ValueView/pull/58#discussion_r13393732"},"pull_request":{"href":"https://api.github.com/repos/wmde/ValueView/pulls/58"}}}}