GitHub PullRequestEvent at 2014-02-17 10:52:41
Repository: jpmml
Actor: vruusmann
Payload: {"action":"closed","number":7,"pull_request":{"url":"https://api.github.com/repos/jpmml/jpmml/pulls/7","id":9886986,"html_url":"https://github.com/jpmml/jpmml/pull/7","diff_url":"https://github.com/jpmml/jpmml/pull/7.diff","patch_url":"https://github.com/jpmml/jpmml/pull/7.patch","issue_url":"https://api.github.com/repos/jpmml/jpmml/issues/7","number":7,"state":"closed","title":"Refactor : pushFrame is replaced with passing argument to evaluation con...","user":{"login":"vshcherb","id":1042025,"avatar_url":"https://gravatar.com/avatar/28a7fef76bac950ef1b3b32077e032b9?d=https%3A%2F%2Fidenticons.github.com%2Fd3eb3865088182340a2d9793c230e814.png&r=x","gravatar_id":"28a7fef76bac950ef1b3b32077e032b9","url":"https://api.github.com/users/vshcherb","html_url":"https://github.com/vshcherb","followers_url":"https://api.github.com/users/vshcherb/followers","following_url":"https://api.github.com/users/vshcherb/following{/other_user}","gists_url":"https://api.github.com/users/vshcherb/gists{/gist_id}","starred_url":"https://api.github.com/users/vshcherb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vshcherb/subscriptions","organizations_url":"https://api.github.com/users/vshcherb/orgs","repos_url":"https://api.github.com/users/vshcherb/repos","events_url":"https://api.github.com/users/vshcherb/events{/privacy}","received_events_url":"https://api.github.com/users/vshcherb/received_events","type":"User","site_admin":false},"body":"I did performance tests and apparently the biggest load is in HashMap.putAll (from pushStackFrame). I'm trying to understand how to workaround this place. \r\nBut first of all, I would like to refactor push/pop relations to see how much it is used. It is a good practice to have matching push and pop methods (and actually for safety reasons, put pop into finally block).\r\n\r\nPlease review the change and comment it if you feel uncomfortable with it.","created_at":"2013-11-12T16:16:05Z","updated_at":"2014-02-17T10:52:41Z","closed_at":"2014-02-17T10:52:41Z","merged_at":null,"merge_commit_sha":"93c21fedeca0c20aacae72c6afcf02b3319feef2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jpmml/jpmml/pulls/7/commits","review_comments_url":"https://api.github.com/repos/jpmml/jpmml/pulls/7/comments","review_comment_url":"https://api.github.com/repos/jpmml/jpmml/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jpmml/jpmml/issues/7/comments","statuses_url":"https://api.github.com/repos/jpmml/jpmml/statuses/a7f033aac19b7bd41b5d5ed92f3e943426649de1","head":{"label":"vshcherb:performanceChanges","ref":"performanceChanges","sha":"a7f033aac19b7bd41b5d5ed92f3e943426649de1","user":{"login":"vshcherb","id":1042025,"avatar_url":"https://gravatar.com/avatar/28a7fef76bac950ef1b3b32077e032b9?d=https%3A%2F%2Fidenticons.github.com%2Fd3eb3865088182340a2d9793c230e814.png&r=x","gravatar_id":"28a7fef76bac950ef1b3b32077e032b9","url":"https://api.github.com/users/vshcherb","html_url":"https://github.com/vshcherb","followers_url":"https://api.github.com/users/vshcherb/followers","following_url":"https://api.github.com/users/vshcherb/following{/other_user}","gists_url":"https://api.github.com/users/vshcherb/gists{/gist_id}","starred_url":"https://api.github.com/users/vshcherb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vshcherb/subscriptions","organizations_url":"https://api.github.com/users/vshcherb/orgs","repos_url":"https://api.github.com/users/vshcherb/repos","events_url":"https://api.github.com/users/vshcherb/events{/privacy}","received_events_url":"https://api.github.com/users/vshcherb/received_events","type":"User","site_admin":false},"repo":{"id":14297145,"name":"jpmml","full_name":"vshcherb/jpmml","owner":{"login":"vshcherb","id":1042025,"avatar_url":"https://gravatar.com/avatar/28a7fef76bac950ef1b3b32077e032b9?d=https%3A%2F%2Fidenticons.github.com%2Fd3eb3865088182340a2d9793c230e814.png&r=x","gravatar_id":"28a7fef76bac950ef1b3b32077e032b9","url":"https://api.github.com/users/vshcherb","html_url":"https://github.com/vshcherb","followers_url":"https://api.github.com/users/vshcherb/followers","following_url":"https://api.github.com/users/vshcherb/following{/other_user}","gists_url":"https://api.github.com/users/vshcherb/gists{/gist_id}","starred_url":"https://api.github.com/users/vshcherb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vshcherb/subscriptions","organizations_url":"https://api.github.com/users/vshcherb/orgs","repos_url":"https://api.github.com/users/vshcherb/repos","events_url":"https://api.github.com/users/vshcherb/events{/privacy}","received_events_url":"https://api.github.com/users/vshcherb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vshcherb/jpmml","description":"Java PMML API","fork":true,"url":"https://api.github.com/repos/vshcherb/jpmml","forks_url":"https://api.github.com/repos/vshcherb/jpmml/forks","keys_url":"https://api.github.com/repos/vshcherb/jpmml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vshcherb/jpmml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vshcherb/jpmml/teams","hooks_url":"https://api.github.com/repos/vshcherb/jpmml/hooks","issue_events_url":"https://api.github.com/repos/vshcherb/jpmml/issues/events{/number}","events_url":"https://api.github.com/repos/vshcherb/jpmml/events","assignees_url":"https://api.github.com/repos/vshcherb/jpmml/assignees{/user}","branches_url":"https://api.github.com/repos/vshcherb/jpmml/branches{/branch}","tags_url":"https://api.github.com/repos/vshcherb/jpmml/tags","blobs_url":"https://api.github.com/repos/vshcherb/jpmml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vshcherb/jpmml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vshcherb/jpmml/git/refs{/sha}","trees_url":"https://api.github.com/repos/vshcherb/jpmml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vshcherb/jpmml/statuses/{sha}","languages_url":"https://api.github.com/repos/vshcherb/jpmml/languages","stargazers_url":"https://api.github.com/repos/vshcherb/jpmml/stargazers","contributors_url":"https://api.github.com/repos/vshcherb/jpmml/contributors","subscribers_url":"https://api.github.com/repos/vshcherb/jpmml/subscribers","subscription_url":"https://api.github.com/repos/vshcherb/jpmml/subscription","commits_url":"https://api.github.com/repos/vshcherb/jpmml/commits{/sha}","git_commits_url":"https://api.github.com/repos/vshcherb/jpmml/git/commits{/sha}","comments_url":"https://api.github.com/repos/vshcherb/jpmml/comments{/number}","issue_comment_url":"https://api.github.com/repos/vshcherb/jpmml/issues/comments/{number}","contents_url":"https://api.github.com/repos/vshcherb/jpmml/contents/{+path}","compare_url":"https://api.github.com/repos/vshcherb/jpmml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vshcherb/jpmml/merges","archive_url":"https://api.github.com/repos/vshcherb/jpmml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vshcherb/jpmml/downloads","issues_url":"https://api.github.com/repos/vshcherb/jpmml/issues{/number}","pulls_url":"https://api.github.com/repos/vshcherb/jpmml/pulls{/number}","milestones_url":"https://api.github.com/repos/vshcherb/jpmml/milestones{/number}","notifications_url":"https://api.github.com/repos/vshcherb/jpmml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vshcherb/jpmml/labels{/name}","releases_url":"https://api.github.com/repos/vshcherb/jpmml/releases{/id}","created_at":"2013-11-11T09:53:27Z","updated_at":"2013-11-12T16:16:05Z","pushed_at":"2013-11-12T16:12:00Z","git_url":"git://github.com/vshcherb/jpmml.git","ssh_url":"git@github.com:vshcherb/jpmml.git","clone_url":"https://github.com/vshcherb/jpmml.git","svn_url":"https://github.com/vshcherb/jpmml","homepage":null,"size":2011,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"jpmml:master","ref":"master","sha":"0669635d359d29d3407c4b74d2de229b877f7b1f","user":{"login":"jpmml","id":3713638,"avatar_url":"https://gravatar.com/avatar/d5f4a9a4a4c6a7726005bd6214e6bad8?d=https%3A%2F%2Fidenticons.github.com%2F160d668c92373357e18971a4447239e1.png&r=x","gravatar_id":"d5f4a9a4a4c6a7726005bd6214e6bad8","url":"https://api.github.com/users/jpmml","html_url":"https://github.com/jpmml","followers_url":"https://api.github.com/users/jpmml/followers","following_url":"https://api.github.com/users/jpmml/following{/other_user}","gists_url":"https://api.github.com/users/jpmml/gists{/gist_id}","starred_url":"https://api.github.com/users/jpmml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpmml/subscriptions","organizations_url":"https://api.github.com/users/jpmml/orgs","repos_url":"https://api.github.com/users/jpmml/repos","events_url":"https://api.github.com/users/jpmml/events{/privacy}","received_events_url":"https://api.github.com/users/jpmml/received_events","type":"Organization","site_admin":false},"repo":{"id":8455875,"name":"jpmml","full_name":"jpmml/jpmml","owner":{"login":"jpmml","id":3713638,"avatar_url":"https://gravatar.com/avatar/d5f4a9a4a4c6a7726005bd6214e6bad8?d=https%3A%2F%2Fidenticons.github.com%2F160d668c92373357e18971a4447239e1.png&r=x","gravatar_id":"d5f4a9a4a4c6a7726005bd6214e6bad8","url":"https://api.github.com/users/jpmml","html_url":"https://github.com/jpmml","followers_url":"https://api.github.com/users/jpmml/followers","following_url":"https://api.github.com/users/jpmml/following{/other_user}","gists_url":"https://api.github.com/users/jpmml/gists{/gist_id}","starred_url":"https://api.github.com/users/jpmml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpmml/subscriptions","organizations_url":"https://api.github.com/users/jpmml/orgs","repos_url":"https://api.github.com/users/jpmml/repos","events_url":"https://api.github.com/users/jpmml/events{/privacy}","received_events_url":"https://api.github.com/users/jpmml/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jpmml/jpmml","description":"Java PMML API","fork":false,"url":"https://api.github.com/repos/jpmml/jpmml","forks_url":"https://api.github.com/repos/jpmml/jpmml/forks","keys_url":"https://api.github.com/repos/jpmml/jpmml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jpmml/jpmml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jpmml/jpmml/teams","hooks_url":"https://api.github.com/repos/jpmml/jpmml/hooks","issue_events_url":"https://api.github.com/repos/jpmml/jpmml/issues/events{/number}","events_url":"https://api.github.com/repos/jpmml/jpmml/events","assignees_url":"https://api.github.com/repos/jpmml/jpmml/assignees{/user}","branches_url":"https://api.github.com/repos/jpmml/jpmml/branches{/branch}","tags_url":"https://api.github.com/repos/jpmml/jpmml/tags","blobs_url":"https://api.github.com/repos/jpmml/jpmml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jpmml/jpmml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jpmml/jpmml/git/refs{/sha}","trees_url":"https://api.github.com/repos/jpmml/jpmml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jpmml/jpmml/statuses/{sha}","languages_url":"https://api.github.com/repos/jpmml/jpmml/languages","stargazers_url":"https://api.github.com/repos/jpmml/jpmml/stargazers","contributors_url":"https://api.github.com/repos/jpmml/jpmml/contributors","subscribers_url":"https://api.github.com/repos/jpmml/jpmml/subscribers","subscription_url":"https://api.github.com/repos/jpmml/jpmml/subscription","commits_url":"https://api.github.com/repos/jpmml/jpmml/commits{/sha}","git_commits_url":"https://api.github.com/repos/jpmml/jpmml/git/commits{/sha}","comments_url":"https://api.github.com/repos/jpmml/jpmml/comments{/number}","issue_comment_url":"https://api.github.com/repos/jpmml/jpmml/issues/comments/{number}","contents_url":"https://api.github.com/repos/jpmml/jpmml/contents/{+path}","compare_url":"https://api.github.com/repos/jpmml/jpmml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jpmml/jpmml/merges","archive_url":"https://api.github.com/repos/jpmml/jpmml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jpmml/jpmml/downloads","issues_url":"https://api.github.com/repos/jpmml/jpmml/issues{/number}","pulls_url":"https://api.github.com/repos/jpmml/jpmml/pulls{/number}","milestones_url":"https://api.github.com/repos/jpmml/jpmml/milestones{/number}","notifications_url":"https://api.github.com/repos/jpmml/jpmml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jpmml/jpmml/labels{/name}","releases_url":"https://api.github.com/repos/jpmml/jpmml/releases{/id}","created_at":"2013-02-27T12:54:09Z","updated_at":"2014-02-17T09:01:05Z","pushed_at":"2014-02-17T09:01:05Z","git_url":"git://github.com/jpmml/jpmml.git","ssh_url":"git@github.com:jpmml/jpmml.git","clone_url":"https://github.com/jpmml/jpmml.git","svn_url":"https://github.com/jpmml/jpmml","homepage":null,"size":3015,"stargazers_count":21,"watchers_count":21,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":10,"mirror_url":null,"open_issues_count":0,"forks":10,"open_issues":0,"watchers":21,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jpmml/jpmml/pulls/7"},"html":{"href":"https://github.com/jpmml/jpmml/pull/7"},"issue":{"href":"https://api.github.com/repos/jpmml/jpmml/issues/7"},"comments":{"href":"https://api.github.com/repos/jpmml/jpmml/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/jpmml/jpmml/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/jpmml/jpmml/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jpmml/jpmml/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/jpmml/jpmml/statuses/a7f033aac19b7bd41b5d5ed92f3e943426649de1"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":38,"deletions":46,"changed_files":24}}