GitHub PullRequestReviewCommentEvent at 2014-12-11 14:15:24
Repository: pixi.js
Actor: beeglebug
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/pulls/comments/21677859","id":21677859,"diff_hunk":"@@ -278,7 +291,7 @@ PIXI.InteractionManager.prototype.removeEvents = function()\n  */\n PIXI.InteractionManager.prototype.update = function()\n {\n-    if (!this.target) return;\n+    if (!this.interactionDOMElement) return;","path":"src/pixi/InteractionManager.js","position":135,"original_position":135,"commit_id":"97eee6a7caf1746254a1482c74c21f6ac7915a43","original_commit_id":"97eee6a7caf1746254a1482c74c21f6ac7915a43","user":{"login":"beeglebug","id":954416,"avatar_url":"https://avatars.githubusercontent.com/u/954416?v=3","gravatar_id":"","url":"https://api.github.com/users/beeglebug","html_url":"https://github.com/beeglebug","followers_url":"https://api.github.com/users/beeglebug/followers","following_url":"https://api.github.com/users/beeglebug/following{/other_user}","gists_url":"https://api.github.com/users/beeglebug/gists{/gist_id}","starred_url":"https://api.github.com/users/beeglebug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beeglebug/subscriptions","organizations_url":"https://api.github.com/users/beeglebug/orgs","repos_url":"https://api.github.com/users/beeglebug/repos","events_url":"https://api.github.com/users/beeglebug/events{/privacy}","received_events_url":"https://api.github.com/users/beeglebug/received_events","type":"User","site_admin":false},"body":"The only place `target` was being used was inside the event listeners, and only width and height properties were being accessed, so it made sense to lose a property and just the domElement.","created_at":"2014-12-11T14:15:24Z","updated_at":"2014-12-11T14:15:24Z","html_url":"https://github.com/GoodBoyDigital/pixi.js/pull/1265#discussion_r21677859","pull_request_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/pulls/1265","_links":{"self":{"href":"https://api.github.com/repos/GoodBoyDigital/pixi.js/pulls/comments/21677859"},"html":{"href":"https://github.com/GoodBoyDigital/pixi.js/pull/1265#discussion_r21677859"},"pull_request":{"href":"https://api.github.com/repos/GoodBoyDigital/pixi.js/pulls/1265"}}},"pull_request":{"url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/pulls/1265","id":25901830,"html_url":"https://github.com/GoodBoyDigital/pixi.js/pull/1265","diff_url":"https://github.com/GoodBoyDigital/pixi.js/pull/1265.diff","patch_url":"https://github.com/GoodBoyDigital/pixi.js/pull/1265.patch","issue_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/issues/1265","number":1265,"state":"open","locked":false,"title":"Fixes for setInteractionDelegate","user":{"login":"beeglebug","id":954416,"avatar_url":"https://avatars.githubusercontent.com/u/954416?v=3","gravatar_id":"","url":"https://api.github.com/users/beeglebug","html_url":"https://github.com/beeglebug","followers_url":"https://api.github.com/users/beeglebug/followers","following_url":"https://api.github.com/users/beeglebug/following{/other_user}","gists_url":"https://api.github.com/users/beeglebug/gists{/gist_id}","starred_url":"https://api.github.com/users/beeglebug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beeglebug/subscriptions","organizations_url":"https://api.github.com/users/beeglebug/orgs","repos_url":"https://api.github.com/users/beeglebug/repos","events_url":"https://api.github.com/users/beeglebug/events{/privacy}","received_events_url":"https://api.github.com/users/beeglebug/received_events","type":"User","site_admin":false},"body":"See #1264 for original issue.","created_at":"2014-12-11T14:09:50Z","updated_at":"2014-12-11T14:15:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3af3406af7a4964aba7677b5675c96c6f1344017","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/pulls/1265/commits","review_comments_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/pulls/1265/comments","review_comment_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/pulls/comments/{number}","comments_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/issues/1265/comments","statuses_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/statuses/97eee6a7caf1746254a1482c74c21f6ac7915a43","head":{"label":"beeglebug:dev","ref":"dev","sha":"97eee6a7caf1746254a1482c74c21f6ac7915a43","user":{"login":"beeglebug","id":954416,"avatar_url":"https://avatars.githubusercontent.com/u/954416?v=3","gravatar_id":"","url":"https://api.github.com/users/beeglebug","html_url":"https://github.com/beeglebug","followers_url":"https://api.github.com/users/beeglebug/followers","following_url":"https://api.github.com/users/beeglebug/following{/other_user}","gists_url":"https://api.github.com/users/beeglebug/gists{/gist_id}","starred_url":"https://api.github.com/users/beeglebug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beeglebug/subscriptions","organizations_url":"https://api.github.com/users/beeglebug/orgs","repos_url":"https://api.github.com/users/beeglebug/repos","events_url":"https://api.github.com/users/beeglebug/events{/privacy}","received_events_url":"https://api.github.com/users/beeglebug/received_events","type":"User","site_admin":false},"repo":{"id":20016719,"name":"pixi.js","full_name":"beeglebug/pixi.js","owner":{"login":"beeglebug","id":954416,"avatar_url":"https://avatars.githubusercontent.com/u/954416?v=3","gravatar_id":"","url":"https://api.github.com/users/beeglebug","html_url":"https://github.com/beeglebug","followers_url":"https://api.github.com/users/beeglebug/followers","following_url":"https://api.github.com/users/beeglebug/following{/other_user}","gists_url":"https://api.github.com/users/beeglebug/gists{/gist_id}","starred_url":"https://api.github.com/users/beeglebug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beeglebug/subscriptions","organizations_url":"https://api.github.com/users/beeglebug/orgs","repos_url":"https://api.github.com/users/beeglebug/repos","events_url":"https://api.github.com/users/beeglebug/events{/privacy}","received_events_url":"https://api.github.com/users/beeglebug/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/beeglebug/pixi.js","description":"Super fast HTML 5 2D rendering engine that uses webGL with canvas fallback","fork":true,"url":"https://api.github.com/repos/beeglebug/pixi.js","forks_url":"https://api.github.com/repos/beeglebug/pixi.js/forks","keys_url":"https://api.github.com/repos/beeglebug/pixi.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/beeglebug/pixi.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/beeglebug/pixi.js/teams","hooks_url":"https://api.github.com/repos/beeglebug/pixi.js/hooks","issue_events_url":"https://api.github.com/repos/beeglebug/pixi.js/issues/events{/number}","events_url":"https://api.github.com/repos/beeglebug/pixi.js/events","assignees_url":"https://api.github.com/repos/beeglebug/pixi.js/assignees{/user}","branches_url":"https://api.github.com/repos/beeglebug/pixi.js/branches{/branch}","tags_url":"https://api.github.com/repos/beeglebug/pixi.js/tags","blobs_url":"https://api.github.com/repos/beeglebug/pixi.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/beeglebug/pixi.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/beeglebug/pixi.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/beeglebug/pixi.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/beeglebug/pixi.js/statuses/{sha}","languages_url":"https://api.github.com/repos/beeglebug/pixi.js/languages","stargazers_url":"https://api.github.com/repos/beeglebug/pixi.js/stargazers","contributors_url":"https://api.github.com/repos/beeglebug/pixi.js/contributors","subscribers_url":"https://api.github.com/repos/beeglebug/pixi.js/subscribers","subscription_url":"https://api.github.com/repos/beeglebug/pixi.js/subscription","commits_url":"https://api.github.com/repos/beeglebug/pixi.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/beeglebug/pixi.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/beeglebug/pixi.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/beeglebug/pixi.js/issues/comments/{number}","contents_url":"https://api.github.com/repos/beeglebug/pixi.js/contents/{+path}","compare_url":"https://api.github.com/repos/beeglebug/pixi.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/beeglebug/pixi.js/merges","archive_url":"https://api.github.com/repos/beeglebug/pixi.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/beeglebug/pixi.js/downloads","issues_url":"https://api.github.com/repos/beeglebug/pixi.js/issues{/number}","pulls_url":"https://api.github.com/repos/beeglebug/pixi.js/pulls{/number}","milestones_url":"https://api.github.com/repos/beeglebug/pixi.js/milestones{/number}","notifications_url":"https://api.github.com/repos/beeglebug/pixi.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/beeglebug/pixi.js/labels{/name}","releases_url":"https://api.github.com/repos/beeglebug/pixi.js/releases{/id}","created_at":"2014-05-21T10:00:01Z","updated_at":"2014-05-23T14:28:46Z","pushed_at":"2014-12-11T14:06:22Z","git_url":"git://github.com/beeglebug/pixi.js.git","ssh_url":"git@github.com:beeglebug/pixi.js.git","clone_url":"https://github.com/beeglebug/pixi.js.git","svn_url":"https://github.com/beeglebug/pixi.js","homepage":null,"size":19090,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoodBoyDigital:dev","ref":"dev","sha":"e1d200ff3744091f1e237323af1b0539559816c5","user":{"login":"GoodBoyDigital","id":3112434,"avatar_url":"https://avatars.githubusercontent.com/u/3112434?v=3","gravatar_id":"","url":"https://api.github.com/users/GoodBoyDigital","html_url":"https://github.com/GoodBoyDigital","followers_url":"https://api.github.com/users/GoodBoyDigital/followers","following_url":"https://api.github.com/users/GoodBoyDigital/following{/other_user}","gists_url":"https://api.github.com/users/GoodBoyDigital/gists{/gist_id}","starred_url":"https://api.github.com/users/GoodBoyDigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoodBoyDigital/subscriptions","organizations_url":"https://api.github.com/users/GoodBoyDigital/orgs","repos_url":"https://api.github.com/users/GoodBoyDigital/repos","events_url":"https://api.github.com/users/GoodBoyDigital/events{/privacy}","received_events_url":"https://api.github.com/users/GoodBoyDigital/received_events","type":"User","site_admin":false},"repo":{"id":7741856,"name":"pixi.js","full_name":"GoodBoyDigital/pixi.js","owner":{"login":"GoodBoyDigital","id":3112434,"avatar_url":"https://avatars.githubusercontent.com/u/3112434?v=3","gravatar_id":"","url":"https://api.github.com/users/GoodBoyDigital","html_url":"https://github.com/GoodBoyDigital","followers_url":"https://api.github.com/users/GoodBoyDigital/followers","following_url":"https://api.github.com/users/GoodBoyDigital/following{/other_user}","gists_url":"https://api.github.com/users/GoodBoyDigital/gists{/gist_id}","starred_url":"https://api.github.com/users/GoodBoyDigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoodBoyDigital/subscriptions","organizations_url":"https://api.github.com/users/GoodBoyDigital/orgs","repos_url":"https://api.github.com/users/GoodBoyDigital/repos","events_url":"https://api.github.com/users/GoodBoyDigital/events{/privacy}","received_events_url":"https://api.github.com/users/GoodBoyDigital/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GoodBoyDigital/pixi.js","description":"Super fast HTML 5 2D rendering engine that uses webGL with canvas fallback","fork":false,"url":"https://api.github.com/repos/GoodBoyDigital/pixi.js","forks_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/forks","keys_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/teams","hooks_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/hooks","issue_events_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/issues/events{/number}","events_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/events","assignees_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/assignees{/user}","branches_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/branches{/branch}","tags_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/tags","blobs_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/statuses/{sha}","languages_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/languages","stargazers_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/stargazers","contributors_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/contributors","subscribers_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/subscribers","subscription_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/subscription","commits_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/issues/comments/{number}","contents_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/contents/{+path}","compare_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/merges","archive_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/downloads","issues_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/issues{/number}","pulls_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/pulls{/number}","milestones_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/milestones{/number}","notifications_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/labels{/name}","releases_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/releases{/id}","created_at":"2013-01-21T22:40:50Z","updated_at":"2014-12-11T09:25:07Z","pushed_at":"2014-12-08T18:26:35Z","git_url":"git://github.com/GoodBoyDigital/pixi.js.git","ssh_url":"git@github.com:GoodBoyDigital/pixi.js.git","clone_url":"https://github.com/GoodBoyDigital/pixi.js.git","svn_url":"https://github.com/GoodBoyDigital/pixi.js","homepage":null,"size":42963,"stargazers_count":6064,"watchers_count":6064,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1172,"mirror_url":null,"open_issues_count":173,"forks":1172,"open_issues":173,"watchers":6064,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoodBoyDigital/pixi.js/pulls/1265"},"html":{"href":"https://github.com/GoodBoyDigital/pixi.js/pull/1265"},"issue":{"href":"https://api.github.com/repos/GoodBoyDigital/pixi.js/issues/1265"},"comments":{"href":"https://api.github.com/repos/GoodBoyDigital/pixi.js/issues/1265/comments"},"review_comments":{"href":"https://api.github.com/repos/GoodBoyDigital/pixi.js/pulls/1265/comments"},"review_comment":{"href":"https://api.github.com/repos/GoodBoyDigital/pixi.js/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/GoodBoyDigital/pixi.js/pulls/1265/commits"},"statuses":{"href":"https://api.github.com/repos/GoodBoyDigital/pixi.js/statuses/97eee6a7caf1746254a1482c74c21f6ac7915a43"}}}}