GitHub PullRequestEvent at 2014-09-22 07:46:59
Repository: angular-timer
Actor: mathiasmoeller
Payload: {"action":"opened","number":112,"pull_request":{"url":"https://api.github.com/repos/siddii/angular-timer/pulls/112","id":21563260,"html_url":"https://github.com/siddii/angular-timer/pull/112","diff_url":"https://github.com/siddii/angular-timer/pull/112.diff","patch_url":"https://github.com/siddii/angular-timer/pull/112.patch","issue_url":"https://api.github.com/repos/siddii/angular-timer/issues/112","number":112,"state":"open","locked":false,"title":"added a 'timer-set-startTime' listener","user":{"login":"mathiasmoeller","id":8833906,"avatar_url":"https://avatars.githubusercontent.com/u/8833906?v=2","gravatar_id":"1449496861690ddf657a546031e84226","url":"https://api.github.com/users/mathiasmoeller","html_url":"https://github.com/mathiasmoeller","followers_url":"https://api.github.com/users/mathiasmoeller/followers","following_url":"https://api.github.com/users/mathiasmoeller/following{/other_user}","gists_url":"https://api.github.com/users/mathiasmoeller/gists{/gist_id}","starred_url":"https://api.github.com/users/mathiasmoeller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathiasmoeller/subscriptions","organizations_url":"https://api.github.com/users/mathiasmoeller/orgs","repos_url":"https://api.github.com/users/mathiasmoeller/repos","events_url":"https://api.github.com/users/mathiasmoeller/events{/privacy}","received_events_url":"https://api.github.com/users/mathiasmoeller/received_events","type":"User","site_admin":false},"body":"added a watcher to listen on 'timer-set-startTime' events. Before there was the problem that when you used the start-time attribute the value could not be changed after compilation. you had to compile the whole timer object again. this method should fix this problem by setting the startTimeAttr manually\r\n\r\n#88 is a similar problem. you postet the plunkr using $compile but that is not realy the nice way is it? ;)\r\n#44 is a similiar problem as well. in that case the problem was the countdown value.\r\n\r\nif you find another way to handle this problem please tell me","created_at":"2014-09-22T07:46:59Z","updated_at":"2014-09-22T07:46:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/siddii/angular-timer/pulls/112/commits","review_comments_url":"https://api.github.com/repos/siddii/angular-timer/pulls/112/comments","review_comment_url":"https://api.github.com/repos/siddii/angular-timer/pulls/comments/{number}","comments_url":"https://api.github.com/repos/siddii/angular-timer/issues/112/comments","statuses_url":"https://api.github.com/repos/siddii/angular-timer/statuses/18ea1e1bc95b399b2a021ea6dcd230a970cc1700","head":{"label":"mathiasmoeller:master","ref":"master","sha":"18ea1e1bc95b399b2a021ea6dcd230a970cc1700","user":{"login":"mathiasmoeller","id":8833906,"avatar_url":"https://avatars.githubusercontent.com/u/8833906?v=2","gravatar_id":"1449496861690ddf657a546031e84226","url":"https://api.github.com/users/mathiasmoeller","html_url":"https://github.com/mathiasmoeller","followers_url":"https://api.github.com/users/mathiasmoeller/followers","following_url":"https://api.github.com/users/mathiasmoeller/following{/other_user}","gists_url":"https://api.github.com/users/mathiasmoeller/gists{/gist_id}","starred_url":"https://api.github.com/users/mathiasmoeller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathiasmoeller/subscriptions","organizations_url":"https://api.github.com/users/mathiasmoeller/orgs","repos_url":"https://api.github.com/users/mathiasmoeller/repos","events_url":"https://api.github.com/users/mathiasmoeller/events{/privacy}","received_events_url":"https://api.github.com/users/mathiasmoeller/received_events","type":"User","site_admin":false},"repo":{"id":24233382,"name":"angular-timer","full_name":"mathiasmoeller/angular-timer","owner":{"login":"mathiasmoeller","id":8833906,"avatar_url":"https://avatars.githubusercontent.com/u/8833906?v=2","gravatar_id":"1449496861690ddf657a546031e84226","url":"https://api.github.com/users/mathiasmoeller","html_url":"https://github.com/mathiasmoeller","followers_url":"https://api.github.com/users/mathiasmoeller/followers","following_url":"https://api.github.com/users/mathiasmoeller/following{/other_user}","gists_url":"https://api.github.com/users/mathiasmoeller/gists{/gist_id}","starred_url":"https://api.github.com/users/mathiasmoeller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathiasmoeller/subscriptions","organizations_url":"https://api.github.com/users/mathiasmoeller/orgs","repos_url":"https://api.github.com/users/mathiasmoeller/repos","events_url":"https://api.github.com/users/mathiasmoeller/events{/privacy}","received_events_url":"https://api.github.com/users/mathiasmoeller/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mathiasmoeller/angular-timer","description":"re-usable/inter-operable AngularJS timer directive","fork":true,"url":"https://api.github.com/repos/mathiasmoeller/angular-timer","forks_url":"https://api.github.com/repos/mathiasmoeller/angular-timer/forks","keys_url":"https://api.github.com/repos/mathiasmoeller/angular-timer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mathiasmoeller/angular-timer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mathiasmoeller/angular-timer/teams","hooks_url":"https://api.github.com/repos/mathiasmoeller/angular-timer/hooks","issue_events_url":"https://api.github.com/repos/mathiasmoeller/angular-timer/issues/events{/number}","events_url":"https://api.github.com/repos/mathiasmoeller/angular-timer/events","assignees_url":"https://api.github.com/repos/mathiasmoeller/angular-timer/assignees{/user}","branches_url":"https://api.github.com/repos/mathiasmoeller/angular-timer/branches{/branch}","tags_url":"https://api.github.com/repos/mathiasmoeller/angular-timer/tags","blobs_url":"https://api.github.com/repos/mathiasmoeller/angular-timer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mathiasmoeller/angular-timer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mathiasmoeller/angular-timer/git/refs{/sha}","trees_url":"https://api.github.com/repos/mathiasmoeller/angular-timer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mathiasmoeller/angular-timer/statuses/{sha}","languages_url":"https://api.github.com/repos/mathiasmoeller/angular-timer/languages","stargazers_url":"https://api.github.com/repos/mathiasmoeller/angular-timer/stargazers","contributors_url":"https://api.github.com/repos/mathiasmoeller/angular-timer/contributors","subscribers_url":"https://api.github.com/repos/mathiasmoeller/angular-timer/subscribers","subscription_url":"https://api.github.com/repos/mathiasmoeller/angular-timer/subscription","commits_url":"https://api.github.com/repos/mathiasmoeller/angular-timer/commits{/sha}","git_commits_url":"https://api.github.com/repos/mathiasmoeller/angular-timer/git/commits{/sha}","comments_url":"https://api.github.com/repos/mathiasmoeller/angular-timer/comments{/number}","issue_comment_url":"https://api.github.com/repos/mathiasmoeller/angular-timer/issues/comments/{number}","contents_url":"https://api.github.com/repos/mathiasmoeller/angular-timer/contents/{+path}","compare_url":"https://api.github.com/repos/mathiasmoeller/angular-timer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mathiasmoeller/angular-timer/merges","archive_url":"https://api.github.com/repos/mathiasmoeller/angular-timer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mathiasmoeller/angular-timer/downloads","issues_url":"https://api.github.com/repos/mathiasmoeller/angular-timer/issues{/number}","pulls_url":"https://api.github.com/repos/mathiasmoeller/angular-timer/pulls{/number}","milestones_url":"https://api.github.com/repos/mathiasmoeller/angular-timer/milestones{/number}","notifications_url":"https://api.github.com/repos/mathiasmoeller/angular-timer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mathiasmoeller/angular-timer/labels{/name}","releases_url":"https://api.github.com/repos/mathiasmoeller/angular-timer/releases{/id}","created_at":"2014-09-19T14:44:22Z","updated_at":"2014-09-22T07:37:27Z","pushed_at":"2014-09-22T07:37:27Z","git_url":"git://github.com/mathiasmoeller/angular-timer.git","ssh_url":"git@github.com:mathiasmoeller/angular-timer.git","clone_url":"https://github.com/mathiasmoeller/angular-timer.git","svn_url":"https://github.com/mathiasmoeller/angular-timer","homepage":"http://siddii.github.io/angular-timer/","size":37973,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"siddii:master","ref":"master","sha":"97204ec8d6d8287d05bcb5b16398aafbc83ece74","user":{"login":"siddii","id":326472,"avatar_url":"https://avatars.githubusercontent.com/u/326472?v=2","gravatar_id":"2d60805283ee9c34d64e6cfd46b60fd0","url":"https://api.github.com/users/siddii","html_url":"https://github.com/siddii","followers_url":"https://api.github.com/users/siddii/followers","following_url":"https://api.github.com/users/siddii/following{/other_user}","gists_url":"https://api.github.com/users/siddii/gists{/gist_id}","starred_url":"https://api.github.com/users/siddii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siddii/subscriptions","organizations_url":"https://api.github.com/users/siddii/orgs","repos_url":"https://api.github.com/users/siddii/repos","events_url":"https://api.github.com/users/siddii/events{/privacy}","received_events_url":"https://api.github.com/users/siddii/received_events","type":"User","site_admin":false},"repo":{"id":10250823,"name":"angular-timer","full_name":"siddii/angular-timer","owner":{"login":"siddii","id":326472,"avatar_url":"https://avatars.githubusercontent.com/u/326472?v=2","gravatar_id":"2d60805283ee9c34d64e6cfd46b60fd0","url":"https://api.github.com/users/siddii","html_url":"https://github.com/siddii","followers_url":"https://api.github.com/users/siddii/followers","following_url":"https://api.github.com/users/siddii/following{/other_user}","gists_url":"https://api.github.com/users/siddii/gists{/gist_id}","starred_url":"https://api.github.com/users/siddii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siddii/subscriptions","organizations_url":"https://api.github.com/users/siddii/orgs","repos_url":"https://api.github.com/users/siddii/repos","events_url":"https://api.github.com/users/siddii/events{/privacy}","received_events_url":"https://api.github.com/users/siddii/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/siddii/angular-timer","description":"re-usable/inter-operable AngularJS timer directive","fork":false,"url":"https://api.github.com/repos/siddii/angular-timer","forks_url":"https://api.github.com/repos/siddii/angular-timer/forks","keys_url":"https://api.github.com/repos/siddii/angular-timer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/siddii/angular-timer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/siddii/angular-timer/teams","hooks_url":"https://api.github.com/repos/siddii/angular-timer/hooks","issue_events_url":"https://api.github.com/repos/siddii/angular-timer/issues/events{/number}","events_url":"https://api.github.com/repos/siddii/angular-timer/events","assignees_url":"https://api.github.com/repos/siddii/angular-timer/assignees{/user}","branches_url":"https://api.github.com/repos/siddii/angular-timer/branches{/branch}","tags_url":"https://api.github.com/repos/siddii/angular-timer/tags","blobs_url":"https://api.github.com/repos/siddii/angular-timer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/siddii/angular-timer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/siddii/angular-timer/git/refs{/sha}","trees_url":"https://api.github.com/repos/siddii/angular-timer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/siddii/angular-timer/statuses/{sha}","languages_url":"https://api.github.com/repos/siddii/angular-timer/languages","stargazers_url":"https://api.github.com/repos/siddii/angular-timer/stargazers","contributors_url":"https://api.github.com/repos/siddii/angular-timer/contributors","subscribers_url":"https://api.github.com/repos/siddii/angular-timer/subscribers","subscription_url":"https://api.github.com/repos/siddii/angular-timer/subscription","commits_url":"https://api.github.com/repos/siddii/angular-timer/commits{/sha}","git_commits_url":"https://api.github.com/repos/siddii/angular-timer/git/commits{/sha}","comments_url":"https://api.github.com/repos/siddii/angular-timer/comments{/number}","issue_comment_url":"https://api.github.com/repos/siddii/angular-timer/issues/comments/{number}","contents_url":"https://api.github.com/repos/siddii/angular-timer/contents/{+path}","compare_url":"https://api.github.com/repos/siddii/angular-timer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/siddii/angular-timer/merges","archive_url":"https://api.github.com/repos/siddii/angular-timer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/siddii/angular-timer/downloads","issues_url":"https://api.github.com/repos/siddii/angular-timer/issues{/number}","pulls_url":"https://api.github.com/repos/siddii/angular-timer/pulls{/number}","milestones_url":"https://api.github.com/repos/siddii/angular-timer/milestones{/number}","notifications_url":"https://api.github.com/repos/siddii/angular-timer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/siddii/angular-timer/labels{/name}","releases_url":"https://api.github.com/repos/siddii/angular-timer/releases{/id}","created_at":"2013-05-23T18:44:47Z","updated_at":"2014-09-22T01:25:41Z","pushed_at":"2014-09-17T21:26:19Z","git_url":"git://github.com/siddii/angular-timer.git","ssh_url":"git@github.com:siddii/angular-timer.git","clone_url":"https://github.com/siddii/angular-timer.git","svn_url":"https://github.com/siddii/angular-timer","homepage":"http://siddii.github.io/angular-timer/","size":37973,"stargazers_count":247,"watchers_count":247,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":168,"mirror_url":null,"open_issues_count":31,"forks":168,"open_issues":31,"watchers":247,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/siddii/angular-timer/pulls/112"},"html":{"href":"https://github.com/siddii/angular-timer/pull/112"},"issue":{"href":"https://api.github.com/repos/siddii/angular-timer/issues/112"},"comments":{"href":"https://api.github.com/repos/siddii/angular-timer/issues/112/comments"},"review_comments":{"href":"https://api.github.com/repos/siddii/angular-timer/pulls/112/comments"},"review_comment":{"href":"https://api.github.com/repos/siddii/angular-timer/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/siddii/angular-timer/pulls/112/commits"},"statuses":{"href":"https://api.github.com/repos/siddii/angular-timer/statuses/18ea1e1bc95b399b2a021ea6dcd230a970cc1700"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":4,"deletions":0,"changed_files":1}}