GitHub PullRequestEvent at 2014-11-01 12:29:30
Repository: MSnbase
Actor: sgibb
Payload: {"action":"opened","number":40,"pull_request":{"url":"https://api.github.com/repos/lgatto/MSnbase/pulls/40","id":23718931,"html_url":"https://github.com/lgatto/MSnbase/pull/40","diff_url":"https://github.com/lgatto/MSnbase/pull/40.diff","patch_url":"https://github.com/lgatto/MSnbase/pull/40.patch","issue_url":"https://api.github.com/repos/lgatto/MSnbase/issues/40","number":40,"state":"open","locked":false,"title":"`R CMD check` warning: \"no visible function definition\"","user":{"login":"sgibb","id":1828443,"avatar_url":"https://avatars.githubusercontent.com/u/1828443?v=2","gravatar_id":"","url":"https://api.github.com/users/sgibb","html_url":"https://github.com/sgibb","followers_url":"https://api.github.com/users/sgibb/followers","following_url":"https://api.github.com/users/sgibb/following{/other_user}","gists_url":"https://api.github.com/users/sgibb/gists{/gist_id}","starred_url":"https://api.github.com/users/sgibb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgibb/subscriptions","organizations_url":"https://api.github.com/users/sgibb/orgs","repos_url":"https://api.github.com/users/sgibb/repos","events_url":"https://api.github.com/users/sgibb/events{/privacy}","received_events_url":"https://api.github.com/users/sgibb/received_events","type":"User","site_admin":false},"body":"While checking synapter via `R CMD check` I get the following warnings:\r\n\r\n    .filterIntensity: no visible global function definition for ‘fData’\r\n    .filterIntensity: no visible global function definition for ‘fData<-’\r\n    .getSpectrum: no visible global function definition for ‘assayData’\r\n    .plotCxRow : <anonymous>: no visible global function definition for ‘fData’\r\n    coerce,Synapter-MSnSet: no visible global function definition for ‘fData’\r\n    coerce,Synapter-MSnSet: no visible global function definition for ‘featureNames<-’\r\n\r\nIMHO you have to export overloaded methods as well.\r\nThat's why I added `assayData`, `fData` and `featureNames` to `NAMESPACE` but maybe more methods are affected.","created_at":"2014-11-01T12:29:30Z","updated_at":"2014-11-01T12:29:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lgatto/MSnbase/pulls/40/commits","review_comments_url":"https://api.github.com/repos/lgatto/MSnbase/pulls/40/comments","review_comment_url":"https://api.github.com/repos/lgatto/MSnbase/pulls/comments/{number}","comments_url":"https://api.github.com/repos/lgatto/MSnbase/issues/40/comments","statuses_url":"https://api.github.com/repos/lgatto/MSnbase/statuses/41e025e2c7c2f46f60a3424826866d5349f50c1d","head":{"label":"lgatto:visibleFunctionDefinition","ref":"visibleFunctionDefinition","sha":"41e025e2c7c2f46f60a3424826866d5349f50c1d","user":{"login":"lgatto","id":384198,"avatar_url":"https://avatars.githubusercontent.com/u/384198?v=2","gravatar_id":"","url":"https://api.github.com/users/lgatto","html_url":"https://github.com/lgatto","followers_url":"https://api.github.com/users/lgatto/followers","following_url":"https://api.github.com/users/lgatto/following{/other_user}","gists_url":"https://api.github.com/users/lgatto/gists{/gist_id}","starred_url":"https://api.github.com/users/lgatto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgatto/subscriptions","organizations_url":"https://api.github.com/users/lgatto/orgs","repos_url":"https://api.github.com/users/lgatto/repos","events_url":"https://api.github.com/users/lgatto/events{/privacy}","received_events_url":"https://api.github.com/users/lgatto/received_events","type":"User","site_admin":false},"repo":{"id":956680,"name":"MSnbase","full_name":"lgatto/MSnbase","owner":{"login":"lgatto","id":384198,"avatar_url":"https://avatars.githubusercontent.com/u/384198?v=2","gravatar_id":"","url":"https://api.github.com/users/lgatto","html_url":"https://github.com/lgatto","followers_url":"https://api.github.com/users/lgatto/followers","following_url":"https://api.github.com/users/lgatto/following{/other_user}","gists_url":"https://api.github.com/users/lgatto/gists{/gist_id}","starred_url":"https://api.github.com/users/lgatto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgatto/subscriptions","organizations_url":"https://api.github.com/users/lgatto/orgs","repos_url":"https://api.github.com/users/lgatto/repos","events_url":"https://api.github.com/users/lgatto/events{/privacy}","received_events_url":"https://api.github.com/users/lgatto/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lgatto/MSnbase","description":"Base Classes and Functions for MS-based Proteomics","fork":false,"url":"https://api.github.com/repos/lgatto/MSnbase","forks_url":"https://api.github.com/repos/lgatto/MSnbase/forks","keys_url":"https://api.github.com/repos/lgatto/MSnbase/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lgatto/MSnbase/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lgatto/MSnbase/teams","hooks_url":"https://api.github.com/repos/lgatto/MSnbase/hooks","issue_events_url":"https://api.github.com/repos/lgatto/MSnbase/issues/events{/number}","events_url":"https://api.github.com/repos/lgatto/MSnbase/events","assignees_url":"https://api.github.com/repos/lgatto/MSnbase/assignees{/user}","branches_url":"https://api.github.com/repos/lgatto/MSnbase/branches{/branch}","tags_url":"https://api.github.com/repos/lgatto/MSnbase/tags","blobs_url":"https://api.github.com/repos/lgatto/MSnbase/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lgatto/MSnbase/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lgatto/MSnbase/git/refs{/sha}","trees_url":"https://api.github.com/repos/lgatto/MSnbase/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lgatto/MSnbase/statuses/{sha}","languages_url":"https://api.github.com/repos/lgatto/MSnbase/languages","stargazers_url":"https://api.github.com/repos/lgatto/MSnbase/stargazers","contributors_url":"https://api.github.com/repos/lgatto/MSnbase/contributors","subscribers_url":"https://api.github.com/repos/lgatto/MSnbase/subscribers","subscription_url":"https://api.github.com/repos/lgatto/MSnbase/subscription","commits_url":"https://api.github.com/repos/lgatto/MSnbase/commits{/sha}","git_commits_url":"https://api.github.com/repos/lgatto/MSnbase/git/commits{/sha}","comments_url":"https://api.github.com/repos/lgatto/MSnbase/comments{/number}","issue_comment_url":"https://api.github.com/repos/lgatto/MSnbase/issues/comments/{number}","contents_url":"https://api.github.com/repos/lgatto/MSnbase/contents/{+path}","compare_url":"https://api.github.com/repos/lgatto/MSnbase/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lgatto/MSnbase/merges","archive_url":"https://api.github.com/repos/lgatto/MSnbase/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lgatto/MSnbase/downloads","issues_url":"https://api.github.com/repos/lgatto/MSnbase/issues{/number}","pulls_url":"https://api.github.com/repos/lgatto/MSnbase/pulls{/number}","milestones_url":"https://api.github.com/repos/lgatto/MSnbase/milestones{/number}","notifications_url":"https://api.github.com/repos/lgatto/MSnbase/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lgatto/MSnbase/labels{/name}","releases_url":"https://api.github.com/repos/lgatto/MSnbase/releases{/id}","created_at":"2010-10-02T15:27:36Z","updated_at":"2014-10-15T08:22:28Z","pushed_at":"2014-11-01T12:25:11Z","git_url":"git://github.com/lgatto/MSnbase.git","ssh_url":"git@github.com:lgatto/MSnbase.git","clone_url":"https://github.com/lgatto/MSnbase.git","svn_url":"https://github.com/lgatto/MSnbase","homepage":"","size":10833,"stargazers_count":3,"watchers_count":3,"language":"R","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":11,"forks":4,"open_issues":11,"watchers":3,"default_branch":"master"}},"base":{"label":"lgatto:master","ref":"master","sha":"a474bba8e7ae7da2c1b7ed606c5def13c6f521dd","user":{"login":"lgatto","id":384198,"avatar_url":"https://avatars.githubusercontent.com/u/384198?v=2","gravatar_id":"","url":"https://api.github.com/users/lgatto","html_url":"https://github.com/lgatto","followers_url":"https://api.github.com/users/lgatto/followers","following_url":"https://api.github.com/users/lgatto/following{/other_user}","gists_url":"https://api.github.com/users/lgatto/gists{/gist_id}","starred_url":"https://api.github.com/users/lgatto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgatto/subscriptions","organizations_url":"https://api.github.com/users/lgatto/orgs","repos_url":"https://api.github.com/users/lgatto/repos","events_url":"https://api.github.com/users/lgatto/events{/privacy}","received_events_url":"https://api.github.com/users/lgatto/received_events","type":"User","site_admin":false},"repo":{"id":956680,"name":"MSnbase","full_name":"lgatto/MSnbase","owner":{"login":"lgatto","id":384198,"avatar_url":"https://avatars.githubusercontent.com/u/384198?v=2","gravatar_id":"","url":"https://api.github.com/users/lgatto","html_url":"https://github.com/lgatto","followers_url":"https://api.github.com/users/lgatto/followers","following_url":"https://api.github.com/users/lgatto/following{/other_user}","gists_url":"https://api.github.com/users/lgatto/gists{/gist_id}","starred_url":"https://api.github.com/users/lgatto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgatto/subscriptions","organizations_url":"https://api.github.com/users/lgatto/orgs","repos_url":"https://api.github.com/users/lgatto/repos","events_url":"https://api.github.com/users/lgatto/events{/privacy}","received_events_url":"https://api.github.com/users/lgatto/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lgatto/MSnbase","description":"Base Classes and Functions for MS-based Proteomics","fork":false,"url":"https://api.github.com/repos/lgatto/MSnbase","forks_url":"https://api.github.com/repos/lgatto/MSnbase/forks","keys_url":"https://api.github.com/repos/lgatto/MSnbase/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lgatto/MSnbase/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lgatto/MSnbase/teams","hooks_url":"https://api.github.com/repos/lgatto/MSnbase/hooks","issue_events_url":"https://api.github.com/repos/lgatto/MSnbase/issues/events{/number}","events_url":"https://api.github.com/repos/lgatto/MSnbase/events","assignees_url":"https://api.github.com/repos/lgatto/MSnbase/assignees{/user}","branches_url":"https://api.github.com/repos/lgatto/MSnbase/branches{/branch}","tags_url":"https://api.github.com/repos/lgatto/MSnbase/tags","blobs_url":"https://api.github.com/repos/lgatto/MSnbase/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lgatto/MSnbase/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lgatto/MSnbase/git/refs{/sha}","trees_url":"https://api.github.com/repos/lgatto/MSnbase/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lgatto/MSnbase/statuses/{sha}","languages_url":"https://api.github.com/repos/lgatto/MSnbase/languages","stargazers_url":"https://api.github.com/repos/lgatto/MSnbase/stargazers","contributors_url":"https://api.github.com/repos/lgatto/MSnbase/contributors","subscribers_url":"https://api.github.com/repos/lgatto/MSnbase/subscribers","subscription_url":"https://api.github.com/repos/lgatto/MSnbase/subscription","commits_url":"https://api.github.com/repos/lgatto/MSnbase/commits{/sha}","git_commits_url":"https://api.github.com/repos/lgatto/MSnbase/git/commits{/sha}","comments_url":"https://api.github.com/repos/lgatto/MSnbase/comments{/number}","issue_comment_url":"https://api.github.com/repos/lgatto/MSnbase/issues/comments/{number}","contents_url":"https://api.github.com/repos/lgatto/MSnbase/contents/{+path}","compare_url":"https://api.github.com/repos/lgatto/MSnbase/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lgatto/MSnbase/merges","archive_url":"https://api.github.com/repos/lgatto/MSnbase/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lgatto/MSnbase/downloads","issues_url":"https://api.github.com/repos/lgatto/MSnbase/issues{/number}","pulls_url":"https://api.github.com/repos/lgatto/MSnbase/pulls{/number}","milestones_url":"https://api.github.com/repos/lgatto/MSnbase/milestones{/number}","notifications_url":"https://api.github.com/repos/lgatto/MSnbase/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lgatto/MSnbase/labels{/name}","releases_url":"https://api.github.com/repos/lgatto/MSnbase/releases{/id}","created_at":"2010-10-02T15:27:36Z","updated_at":"2014-10-15T08:22:28Z","pushed_at":"2014-11-01T12:25:11Z","git_url":"git://github.com/lgatto/MSnbase.git","ssh_url":"git@github.com:lgatto/MSnbase.git","clone_url":"https://github.com/lgatto/MSnbase.git","svn_url":"https://github.com/lgatto/MSnbase","homepage":"","size":10833,"stargazers_count":3,"watchers_count":3,"language":"R","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":11,"forks":4,"open_issues":11,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lgatto/MSnbase/pulls/40"},"html":{"href":"https://github.com/lgatto/MSnbase/pull/40"},"issue":{"href":"https://api.github.com/repos/lgatto/MSnbase/issues/40"},"comments":{"href":"https://api.github.com/repos/lgatto/MSnbase/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/lgatto/MSnbase/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/lgatto/MSnbase/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/lgatto/MSnbase/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/lgatto/MSnbase/statuses/41e025e2c7c2f46f60a3424826866d5349f50c1d"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":8,"deletions":1,"changed_files":2}}