GitHub PullRequestReviewCommentEvent at 2014-11-10 21:08:57
Repository: btcwallet
Actor: davecgh
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/conformal/btcwallet/pulls/comments/20112867","id":20112867,"diff_hunk":"@@ -0,0 +1,92 @@\n+/*\n+ * Copyright (c) 2014 Conformal Systems LLC <info@conformal.com>\n+ *\n+ * Permission to use, copy, modify, and distribute this software for any\n+ * purpose with or without fee is hereby granted, provided that the above\n+ * copyright notice and this permission notice appear in all copies.\n+ *\n+ * THE SOFTWARE IS PROVIDED \"AS IS\" AND THE AUTHOR DISCLAIMS ALL WARRANTIES\n+ * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF\n+ * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR\n+ * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES\n+ * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN\n+ * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF\n+ * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.\n+ */\n+\n+package walletdb\n+\n+import (\n+\t\"errors\"\n+)\n+\n+// Errors that can occur during driver registration.\n+var (\n+\t// ErrDbTypeRegistered is returned when two different database drivers\n+\t// attempt to register with the name database type.\n+\tErrDbTypeRegistered = errors.New(\"database type already registered\")","path":"walletdb/error.go","position":27,"original_position":27,"commit_id":"bfdce3bc04a06b236f04ed2a9c71de5815bcb96f","original_commit_id":"bfdce3bc04a06b236f04ed2a9c71de5815bcb96f","user":{"login":"davecgh","id":2115102,"avatar_url":"https://avatars.githubusercontent.com/u/2115102?v=3","gravatar_id":"","url":"https://api.github.com/users/davecgh","html_url":"https://github.com/davecgh","followers_url":"https://api.github.com/users/davecgh/followers","following_url":"https://api.github.com/users/davecgh/following{/other_user}","gists_url":"https://api.github.com/users/davecgh/gists{/gist_id}","starred_url":"https://api.github.com/users/davecgh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davecgh/subscriptions","organizations_url":"https://api.github.com/users/davecgh/orgs","repos_url":"https://api.github.com/users/davecgh/repos","events_url":"https://api.github.com/users/davecgh/events{/privacy}","received_events_url":"https://api.github.com/users/davecgh/received_events","type":"User","site_admin":false},"body":"I'd rather leave these `ErrDbFoo` as I think that reads better than `ErrDBFoo`.  However, the one in `example_test.go` needs to be updated so it shows against the interface properly in the godoc.","created_at":"2014-11-10T21:08:57Z","updated_at":"2014-11-10T21:08:57Z","html_url":"https://github.com/conformal/btcwallet/pull/152#discussion_r20112867","pull_request_url":"https://api.github.com/repos/conformal/btcwallet/pulls/152","_links":{"self":{"href":"https://api.github.com/repos/conformal/btcwallet/pulls/comments/20112867"},"html":{"href":"https://github.com/conformal/btcwallet/pull/152#discussion_r20112867"},"pull_request":{"href":"https://api.github.com/repos/conformal/btcwallet/pulls/152"}}},"pull_request":{"url":"https://api.github.com/repos/conformal/btcwallet/pulls/152","id":24122044,"html_url":"https://github.com/conformal/btcwallet/pull/152","diff_url":"https://github.com/conformal/btcwallet/pull/152.diff","patch_url":"https://github.com/conformal/btcwallet/pull/152.patch","issue_url":"https://api.github.com/repos/conformal/btcwallet/issues/152","number":152,"state":"open","locked":false,"title":"Implement new namespaced db package named walletdb","user":{"login":"davecgh","id":2115102,"avatar_url":"https://avatars.githubusercontent.com/u/2115102?v=3","gravatar_id":"","url":"https://api.github.com/users/davecgh","html_url":"https://github.com/davecgh","followers_url":"https://api.github.com/users/davecgh/followers","following_url":"https://api.github.com/users/davecgh/following{/other_user}","gists_url":"https://api.github.com/users/davecgh/gists{/gist_id}","starred_url":"https://api.github.com/users/davecgh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davecgh/subscriptions","organizations_url":"https://api.github.com/users/davecgh/orgs","repos_url":"https://api.github.com/users/davecgh/repos","events_url":"https://api.github.com/users/davecgh/events{/privacy}","received_events_url":"https://api.github.com/users/davecgh/received_events","type":"User","site_admin":false},"body":"This pull request implements a new namespaced db package which  is intended to be used be wallet and any sub-packages as its data storage mechanism.\r\n\r\n- Key/value store\r\n- Namespace support\r\n- Allows multiple packages to have their own area in the database without\r\n  worrying about conflicts\r\n- Read-only and read-write transactions with both manual and managed modes\r\n- Nested buckets\r\n- Supports registration of backend databases\r\n- Comprehensive test coverage","created_at":"2014-11-10T00:40:48Z","updated_at":"2014-11-10T21:08:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1e7ac9632db2896998e34240e72df34a77353ed8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/conformal/btcwallet/pulls/152/commits","review_comments_url":"https://api.github.com/repos/conformal/btcwallet/pulls/152/comments","review_comment_url":"https://api.github.com/repos/conformal/btcwallet/pulls/comments/{number}","comments_url":"https://api.github.com/repos/conformal/btcwallet/issues/152/comments","statuses_url":"https://api.github.com/repos/conformal/btcwallet/statuses/bfdce3bc04a06b236f04ed2a9c71de5815bcb96f","head":{"label":"davecgh:davec_walletdb","ref":"davec_walletdb","sha":"bfdce3bc04a06b236f04ed2a9c71de5815bcb96f","user":{"login":"davecgh","id":2115102,"avatar_url":"https://avatars.githubusercontent.com/u/2115102?v=3","gravatar_id":"","url":"https://api.github.com/users/davecgh","html_url":"https://github.com/davecgh","followers_url":"https://api.github.com/users/davecgh/followers","following_url":"https://api.github.com/users/davecgh/following{/other_user}","gists_url":"https://api.github.com/users/davecgh/gists{/gist_id}","starred_url":"https://api.github.com/users/davecgh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davecgh/subscriptions","organizations_url":"https://api.github.com/users/davecgh/orgs","repos_url":"https://api.github.com/users/davecgh/repos","events_url":"https://api.github.com/users/davecgh/events{/privacy}","received_events_url":"https://api.github.com/users/davecgh/received_events","type":"User","site_admin":false},"repo":{"id":23343668,"name":"btcwallet","full_name":"davecgh/btcwallet","owner":{"login":"davecgh","id":2115102,"avatar_url":"https://avatars.githubusercontent.com/u/2115102?v=3","gravatar_id":"","url":"https://api.github.com/users/davecgh","html_url":"https://github.com/davecgh","followers_url":"https://api.github.com/users/davecgh/followers","following_url":"https://api.github.com/users/davecgh/following{/other_user}","gists_url":"https://api.github.com/users/davecgh/gists{/gist_id}","starred_url":"https://api.github.com/users/davecgh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davecgh/subscriptions","organizations_url":"https://api.github.com/users/davecgh/orgs","repos_url":"https://api.github.com/users/davecgh/repos","events_url":"https://api.github.com/users/davecgh/events{/privacy}","received_events_url":"https://api.github.com/users/davecgh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davecgh/btcwallet","description":"","fork":true,"url":"https://api.github.com/repos/davecgh/btcwallet","forks_url":"https://api.github.com/repos/davecgh/btcwallet/forks","keys_url":"https://api.github.com/repos/davecgh/btcwallet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davecgh/btcwallet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davecgh/btcwallet/teams","hooks_url":"https://api.github.com/repos/davecgh/btcwallet/hooks","issue_events_url":"https://api.github.com/repos/davecgh/btcwallet/issues/events{/number}","events_url":"https://api.github.com/repos/davecgh/btcwallet/events","assignees_url":"https://api.github.com/repos/davecgh/btcwallet/assignees{/user}","branches_url":"https://api.github.com/repos/davecgh/btcwallet/branches{/branch}","tags_url":"https://api.github.com/repos/davecgh/btcwallet/tags","blobs_url":"https://api.github.com/repos/davecgh/btcwallet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davecgh/btcwallet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davecgh/btcwallet/git/refs{/sha}","trees_url":"https://api.github.com/repos/davecgh/btcwallet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davecgh/btcwallet/statuses/{sha}","languages_url":"https://api.github.com/repos/davecgh/btcwallet/languages","stargazers_url":"https://api.github.com/repos/davecgh/btcwallet/stargazers","contributors_url":"https://api.github.com/repos/davecgh/btcwallet/contributors","subscribers_url":"https://api.github.com/repos/davecgh/btcwallet/subscribers","subscription_url":"https://api.github.com/repos/davecgh/btcwallet/subscription","commits_url":"https://api.github.com/repos/davecgh/btcwallet/commits{/sha}","git_commits_url":"https://api.github.com/repos/davecgh/btcwallet/git/commits{/sha}","comments_url":"https://api.github.com/repos/davecgh/btcwallet/comments{/number}","issue_comment_url":"https://api.github.com/repos/davecgh/btcwallet/issues/comments/{number}","contents_url":"https://api.github.com/repos/davecgh/btcwallet/contents/{+path}","compare_url":"https://api.github.com/repos/davecgh/btcwallet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davecgh/btcwallet/merges","archive_url":"https://api.github.com/repos/davecgh/btcwallet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davecgh/btcwallet/downloads","issues_url":"https://api.github.com/repos/davecgh/btcwallet/issues{/number}","pulls_url":"https://api.github.com/repos/davecgh/btcwallet/pulls{/number}","milestones_url":"https://api.github.com/repos/davecgh/btcwallet/milestones{/number}","notifications_url":"https://api.github.com/repos/davecgh/btcwallet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davecgh/btcwallet/labels{/name}","releases_url":"https://api.github.com/repos/davecgh/btcwallet/releases{/id}","created_at":"2014-08-26T08:00:02Z","updated_at":"2014-08-30T05:16:02Z","pushed_at":"2014-11-10T20:22:24Z","git_url":"git://github.com/davecgh/btcwallet.git","ssh_url":"git@github.com:davecgh/btcwallet.git","clone_url":"https://github.com/davecgh/btcwallet.git","svn_url":"https://github.com/davecgh/btcwallet","homepage":null,"size":2142,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"conformal:master","ref":"master","sha":"9225863706b3c45cb6e7f62dcca380a16ab46e01","user":{"login":"conformal","id":1123608,"avatar_url":"https://avatars.githubusercontent.com/u/1123608?v=3","gravatar_id":"","url":"https://api.github.com/users/conformal","html_url":"https://github.com/conformal","followers_url":"https://api.github.com/users/conformal/followers","following_url":"https://api.github.com/users/conformal/following{/other_user}","gists_url":"https://api.github.com/users/conformal/gists{/gist_id}","starred_url":"https://api.github.com/users/conformal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conformal/subscriptions","organizations_url":"https://api.github.com/users/conformal/orgs","repos_url":"https://api.github.com/users/conformal/repos","events_url":"https://api.github.com/users/conformal/events{/privacy}","received_events_url":"https://api.github.com/users/conformal/received_events","type":"Organization","site_admin":false},"repo":{"id":12136863,"name":"btcwallet","full_name":"conformal/btcwallet","owner":{"login":"conformal","id":1123608,"avatar_url":"https://avatars.githubusercontent.com/u/1123608?v=3","gravatar_id":"","url":"https://api.github.com/users/conformal","html_url":"https://github.com/conformal","followers_url":"https://api.github.com/users/conformal/followers","following_url":"https://api.github.com/users/conformal/following{/other_user}","gists_url":"https://api.github.com/users/conformal/gists{/gist_id}","starred_url":"https://api.github.com/users/conformal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conformal/subscriptions","organizations_url":"https://api.github.com/users/conformal/orgs","repos_url":"https://api.github.com/users/conformal/repos","events_url":"https://api.github.com/users/conformal/events{/privacy}","received_events_url":"https://api.github.com/users/conformal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/conformal/btcwallet","description":"","fork":false,"url":"https://api.github.com/repos/conformal/btcwallet","forks_url":"https://api.github.com/repos/conformal/btcwallet/forks","keys_url":"https://api.github.com/repos/conformal/btcwallet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/conformal/btcwallet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/conformal/btcwallet/teams","hooks_url":"https://api.github.com/repos/conformal/btcwallet/hooks","issue_events_url":"https://api.github.com/repos/conformal/btcwallet/issues/events{/number}","events_url":"https://api.github.com/repos/conformal/btcwallet/events","assignees_url":"https://api.github.com/repos/conformal/btcwallet/assignees{/user}","branches_url":"https://api.github.com/repos/conformal/btcwallet/branches{/branch}","tags_url":"https://api.github.com/repos/conformal/btcwallet/tags","blobs_url":"https://api.github.com/repos/conformal/btcwallet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/conformal/btcwallet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/conformal/btcwallet/git/refs{/sha}","trees_url":"https://api.github.com/repos/conformal/btcwallet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/conformal/btcwallet/statuses/{sha}","languages_url":"https://api.github.com/repos/conformal/btcwallet/languages","stargazers_url":"https://api.github.com/repos/conformal/btcwallet/stargazers","contributors_url":"https://api.github.com/repos/conformal/btcwallet/contributors","subscribers_url":"https://api.github.com/repos/conformal/btcwallet/subscribers","subscription_url":"https://api.github.com/repos/conformal/btcwallet/subscription","commits_url":"https://api.github.com/repos/conformal/btcwallet/commits{/sha}","git_commits_url":"https://api.github.com/repos/conformal/btcwallet/git/commits{/sha}","comments_url":"https://api.github.com/repos/conformal/btcwallet/comments{/number}","issue_comment_url":"https://api.github.com/repos/conformal/btcwallet/issues/comments/{number}","contents_url":"https://api.github.com/repos/conformal/btcwallet/contents/{+path}","compare_url":"https://api.github.com/repos/conformal/btcwallet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/conformal/btcwallet/merges","archive_url":"https://api.github.com/repos/conformal/btcwallet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/conformal/btcwallet/downloads","issues_url":"https://api.github.com/repos/conformal/btcwallet/issues{/number}","pulls_url":"https://api.github.com/repos/conformal/btcwallet/pulls{/number}","milestones_url":"https://api.github.com/repos/conformal/btcwallet/milestones{/number}","notifications_url":"https://api.github.com/repos/conformal/btcwallet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/conformal/btcwallet/labels{/name}","releases_url":"https://api.github.com/repos/conformal/btcwallet/releases{/id}","created_at":"2013-08-15T14:53:57Z","updated_at":"2014-11-07T01:32:57Z","pushed_at":"2014-11-07T14:03:37Z","git_url":"git://github.com/conformal/btcwallet.git","ssh_url":"git@github.com:conformal/btcwallet.git","clone_url":"https://github.com/conformal/btcwallet.git","svn_url":"https://github.com/conformal/btcwallet","homepage":null,"size":6278,"stargazers_count":49,"watchers_count":49,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":28,"forks":25,"open_issues":28,"watchers":49,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/conformal/btcwallet/pulls/152"},"html":{"href":"https://github.com/conformal/btcwallet/pull/152"},"issue":{"href":"https://api.github.com/repos/conformal/btcwallet/issues/152"},"comments":{"href":"https://api.github.com/repos/conformal/btcwallet/issues/152/comments"},"review_comments":{"href":"https://api.github.com/repos/conformal/btcwallet/pulls/152/comments"},"review_comment":{"href":"https://api.github.com/repos/conformal/btcwallet/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/conformal/btcwallet/pulls/152/commits"},"statuses":{"href":"https://api.github.com/repos/conformal/btcwallet/statuses/bfdce3bc04a06b236f04ed2a9c71de5815bcb96f"}}}}