GitHub PullRequestReviewCommentEvent at 2014-09-20 05:18:01
Repository: machinekit
Actor: zultron
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/machinekit/machinekit/pulls/comments/17818078","id":17818078,"diff_hunk":"@@ -43,6 +43,12 @@ REALTIME=@REALTIME@\n LINUXCNC_IMAGEDIR=@EMC2_IMAGE_DIR@\n LINUXCNC_TCL_LIB_DIR=@EMC2_TCL_LIB_DIR@\n \n+# if not overridden by user, point MACHINEKIT_INI to installed default:\n+if [ -z \"$MACHINEKIT_INI\" ]; then\n+    MACHINEKIT_INI=@EMC2_HOME@/etc/linuxcnc/machinekit.ini","path":"scripts/linuxcnc.in","position":6,"original_position":6,"commit_id":"eeed0e25c88b47c2cb90a1554e39b3ddd6fc99e5","original_commit_id":"eeed0e25c88b47c2cb90a1554e39b3ddd6fc99e5","user":{"login":"zultron","id":1940736,"avatar_url":"https://avatars.githubusercontent.com/u/1940736?v=2","gravatar_id":"fabe51524daf3f5480c796797354a1a8","url":"https://api.github.com/users/zultron","html_url":"https://github.com/zultron","followers_url":"https://api.github.com/users/zultron/followers","following_url":"https://api.github.com/users/zultron/following{/other_user}","gists_url":"https://api.github.com/users/zultron/gists{/gist_id}","starred_url":"https://api.github.com/users/zultron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zultron/subscriptions","organizations_url":"https://api.github.com/users/zultron/orgs","repos_url":"https://api.github.com/users/zultron/repos","events_url":"https://api.github.com/users/zultron/events{/privacy}","received_events_url":"https://api.github.com/users/zultron/received_events","type":"User","site_admin":false},"body":"I think this needs to be `@EMC2_SYSTEM_CONFIG_DIR@/machinekit.ini`, or else system installs will get something like `/usr/etc/linuxcnc/machinekit.ini`.\r\n\r\nSame deal with `scripts/realtime.in`.","created_at":"2014-09-20T05:18:01Z","updated_at":"2014-09-20T05:18:01Z","html_url":"https://github.com/machinekit/machinekit/pull/299#discussion_r17818078","pull_request_url":"https://api.github.com/repos/machinekit/machinekit/pulls/299","_links":{"self":{"href":"https://api.github.com/repos/machinekit/machinekit/pulls/comments/17818078"},"html":{"href":"https://github.com/machinekit/machinekit/pull/299#discussion_r17818078"},"pull_request":{"href":"https://api.github.com/repos/machinekit/machinekit/pulls/299"}}},"pull_request":{"url":"https://api.github.com/repos/machinekit/machinekit/pulls/299","id":21483075,"html_url":"https://github.com/machinekit/machinekit/pull/299","diff_url":"https://github.com/machinekit/machinekit/pull/299.diff","patch_url":"https://github.com/machinekit/machinekit/pull/299.patch","issue_url":"https://api.github.com/repos/machinekit/machinekit/issues/299","number":299,"state":"open","locked":false,"title":"fix missing MACHINEKIT_INI default + export, /var/log/linuxcnc.log permissions + logging","user":{"login":"mhaberler","id":901479,"avatar_url":"https://avatars.githubusercontent.com/u/901479?v=2","gravatar_id":"b474dce15a2814c28fb223a9f91c4e16","url":"https://api.github.com/users/mhaberler","html_url":"https://github.com/mhaberler","followers_url":"https://api.github.com/users/mhaberler/followers","following_url":"https://api.github.com/users/mhaberler/following{/other_user}","gists_url":"https://api.github.com/users/mhaberler/gists{/gist_id}","starred_url":"https://api.github.com/users/mhaberler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhaberler/subscriptions","organizations_url":"https://api.github.com/users/mhaberler/orgs","repos_url":"https://api.github.com/users/mhaberler/repos","events_url":"https://api.github.com/users/mhaberler/events{/privacy}","received_events_url":"https://api.github.com/users/mhaberler/received_events","type":"User","site_admin":false},"body":"I hope this covers most of the open issues\r\n\r\nhowever, I do not understand why /etc/linuxcnc/machinekit.ini is not carried over into the package; rtapi.ini - which is in the same directory - shouldnt this be covered by: https://github.com/machinekit/machinekit/blob/master/debian/machinekit.install#L1 ?\r\n\r\n","created_at":"2014-09-19T08:04:56Z","updated_at":"2014-09-20T05:18:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"17fc2063dc84bef27ac0f6b72a156f5609165053","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/machinekit/machinekit/pulls/299/commits","review_comments_url":"https://api.github.com/repos/machinekit/machinekit/pulls/299/comments","review_comment_url":"https://api.github.com/repos/machinekit/machinekit/pulls/comments/{number}","comments_url":"https://api.github.com/repos/machinekit/machinekit/issues/299/comments","statuses_url":"https://api.github.com/repos/machinekit/machinekit/statuses/eeed0e25c88b47c2cb90a1554e39b3ddd6fc99e5","head":{"label":"mhaberler:touchups","ref":"touchups","sha":"eeed0e25c88b47c2cb90a1554e39b3ddd6fc99e5","user":{"login":"mhaberler","id":901479,"avatar_url":"https://avatars.githubusercontent.com/u/901479?v=2","gravatar_id":"b474dce15a2814c28fb223a9f91c4e16","url":"https://api.github.com/users/mhaberler","html_url":"https://github.com/mhaberler","followers_url":"https://api.github.com/users/mhaberler/followers","following_url":"https://api.github.com/users/mhaberler/following{/other_user}","gists_url":"https://api.github.com/users/mhaberler/gists{/gist_id}","starred_url":"https://api.github.com/users/mhaberler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhaberler/subscriptions","organizations_url":"https://api.github.com/users/mhaberler/orgs","repos_url":"https://api.github.com/users/mhaberler/repos","events_url":"https://api.github.com/users/mhaberler/events{/privacy}","received_events_url":"https://api.github.com/users/mhaberler/received_events","type":"User","site_admin":false},"repo":{"id":11419885,"name":"machinekit","full_name":"mhaberler/machinekit","owner":{"login":"mhaberler","id":901479,"avatar_url":"https://avatars.githubusercontent.com/u/901479?v=2","gravatar_id":"b474dce15a2814c28fb223a9f91c4e16","url":"https://api.github.com/users/mhaberler","html_url":"https://github.com/mhaberler","followers_url":"https://api.github.com/users/mhaberler/followers","following_url":"https://api.github.com/users/mhaberler/following{/other_user}","gists_url":"https://api.github.com/users/mhaberler/gists{/gist_id}","starred_url":"https://api.github.com/users/mhaberler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhaberler/subscriptions","organizations_url":"https://api.github.com/users/mhaberler/orgs","repos_url":"https://api.github.com/users/mhaberler/repos","events_url":"https://api.github.com/users/mhaberler/events{/privacy}","received_events_url":"https://api.github.com/users/mhaberler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mhaberler/machinekit","description":"private repo - nothing useful here","fork":true,"url":"https://api.github.com/repos/mhaberler/machinekit","forks_url":"https://api.github.com/repos/mhaberler/machinekit/forks","keys_url":"https://api.github.com/repos/mhaberler/machinekit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mhaberler/machinekit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mhaberler/machinekit/teams","hooks_url":"https://api.github.com/repos/mhaberler/machinekit/hooks","issue_events_url":"https://api.github.com/repos/mhaberler/machinekit/issues/events{/number}","events_url":"https://api.github.com/repos/mhaberler/machinekit/events","assignees_url":"https://api.github.com/repos/mhaberler/machinekit/assignees{/user}","branches_url":"https://api.github.com/repos/mhaberler/machinekit/branches{/branch}","tags_url":"https://api.github.com/repos/mhaberler/machinekit/tags","blobs_url":"https://api.github.com/repos/mhaberler/machinekit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mhaberler/machinekit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mhaberler/machinekit/git/refs{/sha}","trees_url":"https://api.github.com/repos/mhaberler/machinekit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mhaberler/machinekit/statuses/{sha}","languages_url":"https://api.github.com/repos/mhaberler/machinekit/languages","stargazers_url":"https://api.github.com/repos/mhaberler/machinekit/stargazers","contributors_url":"https://api.github.com/repos/mhaberler/machinekit/contributors","subscribers_url":"https://api.github.com/repos/mhaberler/machinekit/subscribers","subscription_url":"https://api.github.com/repos/mhaberler/machinekit/subscription","commits_url":"https://api.github.com/repos/mhaberler/machinekit/commits{/sha}","git_commits_url":"https://api.github.com/repos/mhaberler/machinekit/git/commits{/sha}","comments_url":"https://api.github.com/repos/mhaberler/machinekit/comments{/number}","issue_comment_url":"https://api.github.com/repos/mhaberler/machinekit/issues/comments/{number}","contents_url":"https://api.github.com/repos/mhaberler/machinekit/contents/{+path}","compare_url":"https://api.github.com/repos/mhaberler/machinekit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mhaberler/machinekit/merges","archive_url":"https://api.github.com/repos/mhaberler/machinekit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mhaberler/machinekit/downloads","issues_url":"https://api.github.com/repos/mhaberler/machinekit/issues{/number}","pulls_url":"https://api.github.com/repos/mhaberler/machinekit/pulls{/number}","milestones_url":"https://api.github.com/repos/mhaberler/machinekit/milestones{/number}","notifications_url":"https://api.github.com/repos/mhaberler/machinekit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mhaberler/machinekit/labels{/name}","releases_url":"https://api.github.com/repos/mhaberler/machinekit/releases{/id}","created_at":"2013-07-15T09:46:44Z","updated_at":"2014-06-25T14:20:38Z","pushed_at":"2014-09-19T11:50:48Z","git_url":"git://github.com/mhaberler/machinekit.git","ssh_url":"git@github.com:mhaberler/machinekit.git","clone_url":"https://github.com/mhaberler/machinekit.git","svn_url":"https://github.com/mhaberler/machinekit","homepage":"http://www.machinekit.io","size":91666,"stargazers_count":2,"watchers_count":2,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":0,"forks":4,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"machinekit:master","ref":"master","sha":"a2ebe78437b92a3a9bfcc7af0326be94febb1384","user":{"login":"machinekit","id":6759549,"avatar_url":"https://avatars.githubusercontent.com/u/6759549?v=2","gravatar_id":"cb1cec19f8db3dbd7165ec464a5971a8","url":"https://api.github.com/users/machinekit","html_url":"https://github.com/machinekit","followers_url":"https://api.github.com/users/machinekit/followers","following_url":"https://api.github.com/users/machinekit/following{/other_user}","gists_url":"https://api.github.com/users/machinekit/gists{/gist_id}","starred_url":"https://api.github.com/users/machinekit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/machinekit/subscriptions","organizations_url":"https://api.github.com/users/machinekit/orgs","repos_url":"https://api.github.com/users/machinekit/repos","events_url":"https://api.github.com/users/machinekit/events{/privacy}","received_events_url":"https://api.github.com/users/machinekit/received_events","type":"Organization","site_admin":false},"repo":{"id":7700636,"name":"machinekit","full_name":"machinekit/machinekit","owner":{"login":"machinekit","id":6759549,"avatar_url":"https://avatars.githubusercontent.com/u/6759549?v=2","gravatar_id":"cb1cec19f8db3dbd7165ec464a5971a8","url":"https://api.github.com/users/machinekit","html_url":"https://github.com/machinekit","followers_url":"https://api.github.com/users/machinekit/followers","following_url":"https://api.github.com/users/machinekit/following{/other_user}","gists_url":"https://api.github.com/users/machinekit/gists{/gist_id}","starred_url":"https://api.github.com/users/machinekit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/machinekit/subscriptions","organizations_url":"https://api.github.com/users/machinekit/orgs","repos_url":"https://api.github.com/users/machinekit/repos","events_url":"https://api.github.com/users/machinekit/events{/privacy}","received_events_url":"https://api.github.com/users/machinekit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/machinekit/machinekit","description":"","fork":true,"url":"https://api.github.com/repos/machinekit/machinekit","forks_url":"https://api.github.com/repos/machinekit/machinekit/forks","keys_url":"https://api.github.com/repos/machinekit/machinekit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/machinekit/machinekit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/machinekit/machinekit/teams","hooks_url":"https://api.github.com/repos/machinekit/machinekit/hooks","issue_events_url":"https://api.github.com/repos/machinekit/machinekit/issues/events{/number}","events_url":"https://api.github.com/repos/machinekit/machinekit/events","assignees_url":"https://api.github.com/repos/machinekit/machinekit/assignees{/user}","branches_url":"https://api.github.com/repos/machinekit/machinekit/branches{/branch}","tags_url":"https://api.github.com/repos/machinekit/machinekit/tags","blobs_url":"https://api.github.com/repos/machinekit/machinekit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/machinekit/machinekit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/machinekit/machinekit/git/refs{/sha}","trees_url":"https://api.github.com/repos/machinekit/machinekit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/machinekit/machinekit/statuses/{sha}","languages_url":"https://api.github.com/repos/machinekit/machinekit/languages","stargazers_url":"https://api.github.com/repos/machinekit/machinekit/stargazers","contributors_url":"https://api.github.com/repos/machinekit/machinekit/contributors","subscribers_url":"https://api.github.com/repos/machinekit/machinekit/subscribers","subscription_url":"https://api.github.com/repos/machinekit/machinekit/subscription","commits_url":"https://api.github.com/repos/machinekit/machinekit/commits{/sha}","git_commits_url":"https://api.github.com/repos/machinekit/machinekit/git/commits{/sha}","comments_url":"https://api.github.com/repos/machinekit/machinekit/comments{/number}","issue_comment_url":"https://api.github.com/repos/machinekit/machinekit/issues/comments/{number}","contents_url":"https://api.github.com/repos/machinekit/machinekit/contents/{+path}","compare_url":"https://api.github.com/repos/machinekit/machinekit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/machinekit/machinekit/merges","archive_url":"https://api.github.com/repos/machinekit/machinekit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/machinekit/machinekit/downloads","issues_url":"https://api.github.com/repos/machinekit/machinekit/issues{/number}","pulls_url":"https://api.github.com/repos/machinekit/machinekit/pulls{/number}","milestones_url":"https://api.github.com/repos/machinekit/machinekit/milestones{/number}","notifications_url":"https://api.github.com/repos/machinekit/machinekit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/machinekit/machinekit/labels{/name}","releases_url":"https://api.github.com/repos/machinekit/machinekit/releases{/id}","created_at":"2013-01-19T07:31:19Z","updated_at":"2014-09-16T01:43:36Z","pushed_at":"2014-09-20T05:12:37Z","git_url":"git://github.com/machinekit/machinekit.git","ssh_url":"git@github.com:machinekit/machinekit.git","clone_url":"https://github.com/machinekit/machinekit.git","svn_url":"https://github.com/machinekit/machinekit","homepage":"http://machinekit.io","size":83940,"stargazers_count":12,"watchers_count":12,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":65,"forks":26,"open_issues":65,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/machinekit/machinekit/pulls/299"},"html":{"href":"https://github.com/machinekit/machinekit/pull/299"},"issue":{"href":"https://api.github.com/repos/machinekit/machinekit/issues/299"},"comments":{"href":"https://api.github.com/repos/machinekit/machinekit/issues/299/comments"},"review_comments":{"href":"https://api.github.com/repos/machinekit/machinekit/pulls/299/comments"},"review_comment":{"href":"https://api.github.com/repos/machinekit/machinekit/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/machinekit/machinekit/pulls/299/commits"},"statuses":{"href":"https://api.github.com/repos/machinekit/machinekit/statuses/eeed0e25c88b47c2cb90a1554e39b3ddd6fc99e5"}}}}