GitHub PullRequestReviewCommentEvent at 2014-07-04 18:34:32
Repository: csympy
Actor: thilinarmtb
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/sympy/csympy/pulls/comments/14566318","id":14566318,"diff_hunk":"@@ -792,11 +820,32 @@ void cholesky(const DenseMatrix &A, DenseMatrix &L)\n                 sub(A.m_[i*col + j], sum));\n         }\n         sum = zero;\n-        for (k = 0; k < i; k++)\n+        for (k = 0; k < i; k++) {\n+            // std::cout << \"a: \" << *sum << \" b: \" << *L.m_[i*col + k] << std::endl;","path":"src/dense_matrix.cpp","position":210,"original_position":210,"commit_id":"3a1f403d66671cd90680e18580dcbd28114c9907","original_commit_id":"3a1f403d66671cd90680e18580dcbd28114c9907","user":{"login":"thilinarmtb","id":1346780,"avatar_url":"https://avatars.githubusercontent.com/u/1346780?","gravatar_id":"8ccd21c14794d3d064b60a91526687f0","url":"https://api.github.com/users/thilinarmtb","html_url":"https://github.com/thilinarmtb","followers_url":"https://api.github.com/users/thilinarmtb/followers","following_url":"https://api.github.com/users/thilinarmtb/following{/other_user}","gists_url":"https://api.github.com/users/thilinarmtb/gists{/gist_id}","starred_url":"https://api.github.com/users/thilinarmtb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thilinarmtb/subscriptions","organizations_url":"https://api.github.com/users/thilinarmtb/orgs","repos_url":"https://api.github.com/users/thilinarmtb/repos","events_url":"https://api.github.com/users/thilinarmtb/events{/privacy}","received_events_url":"https://api.github.com/users/thilinarmtb/received_events","type":"User","site_admin":false},"body":"Oops, this should be removed.","created_at":"2014-07-04T18:34:32Z","updated_at":"2014-07-04T18:34:32Z","html_url":"https://github.com/sympy/csympy/pull/235#discussion_r14566318","pull_request_url":"https://api.github.com/repos/sympy/csympy/pulls/235","_links":{"self":{"href":"https://api.github.com/repos/sympy/csympy/pulls/comments/14566318"},"html":{"href":"https://github.com/sympy/csympy/pull/235#discussion_r14566318"},"pull_request":{"href":"https://api.github.com/repos/sympy/csympy/pulls/235"}}},"pull_request":{"url":"https://api.github.com/repos/sympy/csympy/pulls/235","id":18002636,"html_url":"https://github.com/sympy/csympy/pull/235","diff_url":"https://github.com/sympy/csympy/pull/235.diff","patch_url":"https://github.com/sympy/csympy/pull/235.patch","issue_url":"https://api.github.com/repos/sympy/csympy/issues/235","number":235,"state":"open","title":"Implement decomposition based solve functions for solving Ax = b","user":{"login":"thilinarmtb","id":1346780,"avatar_url":"https://avatars.githubusercontent.com/u/1346780?","gravatar_id":"8ccd21c14794d3d064b60a91526687f0","url":"https://api.github.com/users/thilinarmtb","html_url":"https://github.com/thilinarmtb","followers_url":"https://api.github.com/users/thilinarmtb/followers","following_url":"https://api.github.com/users/thilinarmtb/following{/other_user}","gists_url":"https://api.github.com/users/thilinarmtb/gists{/gist_id}","starred_url":"https://api.github.com/users/thilinarmtb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thilinarmtb/subscriptions","organizations_url":"https://api.github.com/users/thilinarmtb/orgs","repos_url":"https://api.github.com/users/thilinarmtb/repos","events_url":"https://api.github.com/users/thilinarmtb/events{/privacy}","received_events_url":"https://api.github.com/users/thilinarmtb/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-07-04T18:26:33Z","updated_at":"2014-07-04T18:34:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a967ec640489657766a88719498a06a09c29cf1e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sympy/csympy/pulls/235/commits","review_comments_url":"https://api.github.com/repos/sympy/csympy/pulls/235/comments","review_comment_url":"https://api.github.com/repos/sympy/csympy/pulls/comments/{number}","comments_url":"https://api.github.com/repos/sympy/csympy/issues/235/comments","statuses_url":"https://api.github.com/repos/sympy/csympy/statuses/3a1f403d66671cd90680e18580dcbd28114c9907","head":{"label":"thilinarmtb:solve_ax_b","ref":"solve_ax_b","sha":"3a1f403d66671cd90680e18580dcbd28114c9907","user":{"login":"thilinarmtb","id":1346780,"avatar_url":"https://avatars.githubusercontent.com/u/1346780?","gravatar_id":"8ccd21c14794d3d064b60a91526687f0","url":"https://api.github.com/users/thilinarmtb","html_url":"https://github.com/thilinarmtb","followers_url":"https://api.github.com/users/thilinarmtb/followers","following_url":"https://api.github.com/users/thilinarmtb/following{/other_user}","gists_url":"https://api.github.com/users/thilinarmtb/gists{/gist_id}","starred_url":"https://api.github.com/users/thilinarmtb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thilinarmtb/subscriptions","organizations_url":"https://api.github.com/users/thilinarmtb/orgs","repos_url":"https://api.github.com/users/thilinarmtb/repos","events_url":"https://api.github.com/users/thilinarmtb/events{/privacy}","received_events_url":"https://api.github.com/users/thilinarmtb/received_events","type":"User","site_admin":false},"repo":{"id":12099700,"name":"csympy","full_name":"thilinarmtb/csympy","owner":{"login":"thilinarmtb","id":1346780,"avatar_url":"https://avatars.githubusercontent.com/u/1346780?","gravatar_id":"8ccd21c14794d3d064b60a91526687f0","url":"https://api.github.com/users/thilinarmtb","html_url":"https://github.com/thilinarmtb","followers_url":"https://api.github.com/users/thilinarmtb/followers","following_url":"https://api.github.com/users/thilinarmtb/following{/other_user}","gists_url":"https://api.github.com/users/thilinarmtb/gists{/gist_id}","starred_url":"https://api.github.com/users/thilinarmtb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thilinarmtb/subscriptions","organizations_url":"https://api.github.com/users/thilinarmtb/orgs","repos_url":"https://api.github.com/users/thilinarmtb/repos","events_url":"https://api.github.com/users/thilinarmtb/events{/privacy}","received_events_url":"https://api.github.com/users/thilinarmtb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thilinarmtb/csympy","description":"Experimental SymPy core written in C++","fork":true,"url":"https://api.github.com/repos/thilinarmtb/csympy","forks_url":"https://api.github.com/repos/thilinarmtb/csympy/forks","keys_url":"https://api.github.com/repos/thilinarmtb/csympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thilinarmtb/csympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thilinarmtb/csympy/teams","hooks_url":"https://api.github.com/repos/thilinarmtb/csympy/hooks","issue_events_url":"https://api.github.com/repos/thilinarmtb/csympy/issues/events{/number}","events_url":"https://api.github.com/repos/thilinarmtb/csympy/events","assignees_url":"https://api.github.com/repos/thilinarmtb/csympy/assignees{/user}","branches_url":"https://api.github.com/repos/thilinarmtb/csympy/branches{/branch}","tags_url":"https://api.github.com/repos/thilinarmtb/csympy/tags","blobs_url":"https://api.github.com/repos/thilinarmtb/csympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thilinarmtb/csympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thilinarmtb/csympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/thilinarmtb/csympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thilinarmtb/csympy/statuses/{sha}","languages_url":"https://api.github.com/repos/thilinarmtb/csympy/languages","stargazers_url":"https://api.github.com/repos/thilinarmtb/csympy/stargazers","contributors_url":"https://api.github.com/repos/thilinarmtb/csympy/contributors","subscribers_url":"https://api.github.com/repos/thilinarmtb/csympy/subscribers","subscription_url":"https://api.github.com/repos/thilinarmtb/csympy/subscription","commits_url":"https://api.github.com/repos/thilinarmtb/csympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/thilinarmtb/csympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/thilinarmtb/csympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/thilinarmtb/csympy/issues/comments/{number}","contents_url":"https://api.github.com/repos/thilinarmtb/csympy/contents/{+path}","compare_url":"https://api.github.com/repos/thilinarmtb/csympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thilinarmtb/csympy/merges","archive_url":"https://api.github.com/repos/thilinarmtb/csympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thilinarmtb/csympy/downloads","issues_url":"https://api.github.com/repos/thilinarmtb/csympy/issues{/number}","pulls_url":"https://api.github.com/repos/thilinarmtb/csympy/pulls{/number}","milestones_url":"https://api.github.com/repos/thilinarmtb/csympy/milestones{/number}","notifications_url":"https://api.github.com/repos/thilinarmtb/csympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thilinarmtb/csympy/labels{/name}","releases_url":"https://api.github.com/repos/thilinarmtb/csympy/releases{/id}","created_at":"2013-08-14T04:11:44Z","updated_at":"2014-06-25T08:28:23Z","pushed_at":"2014-07-04T18:25:02Z","git_url":"git://github.com/thilinarmtb/csympy.git","ssh_url":"git@github.com:thilinarmtb/csympy.git","clone_url":"https://github.com/thilinarmtb/csympy.git","svn_url":"https://github.com/thilinarmtb/csympy","homepage":"http://sympy.org","size":2080,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sympy:master","ref":"master","sha":"a0508ae9946205a9d2593ca95ed03b726f61c788","user":{"login":"sympy","id":260832,"avatar_url":"https://avatars.githubusercontent.com/u/260832?","gravatar_id":"cbddfebe00a15f38108875eaafa827de","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"repo":{"id":42376,"name":"csympy","full_name":"sympy/csympy","owner":{"login":"sympy","id":260832,"avatar_url":"https://avatars.githubusercontent.com/u/260832?","gravatar_id":"cbddfebe00a15f38108875eaafa827de","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sympy/csympy","description":"Fast symbolic manipulation library, written in C++","fork":false,"url":"https://api.github.com/repos/sympy/csympy","forks_url":"https://api.github.com/repos/sympy/csympy/forks","keys_url":"https://api.github.com/repos/sympy/csympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sympy/csympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sympy/csympy/teams","hooks_url":"https://api.github.com/repos/sympy/csympy/hooks","issue_events_url":"https://api.github.com/repos/sympy/csympy/issues/events{/number}","events_url":"https://api.github.com/repos/sympy/csympy/events","assignees_url":"https://api.github.com/repos/sympy/csympy/assignees{/user}","branches_url":"https://api.github.com/repos/sympy/csympy/branches{/branch}","tags_url":"https://api.github.com/repos/sympy/csympy/tags","blobs_url":"https://api.github.com/repos/sympy/csympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sympy/csympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sympy/csympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/sympy/csympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sympy/csympy/statuses/{sha}","languages_url":"https://api.github.com/repos/sympy/csympy/languages","stargazers_url":"https://api.github.com/repos/sympy/csympy/stargazers","contributors_url":"https://api.github.com/repos/sympy/csympy/contributors","subscribers_url":"https://api.github.com/repos/sympy/csympy/subscribers","subscription_url":"https://api.github.com/repos/sympy/csympy/subscription","commits_url":"https://api.github.com/repos/sympy/csympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/sympy/csympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/sympy/csympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/sympy/csympy/issues/comments/{number}","contents_url":"https://api.github.com/repos/sympy/csympy/contents/{+path}","compare_url":"https://api.github.com/repos/sympy/csympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sympy/csympy/merges","archive_url":"https://api.github.com/repos/sympy/csympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sympy/csympy/downloads","issues_url":"https://api.github.com/repos/sympy/csympy/issues{/number}","pulls_url":"https://api.github.com/repos/sympy/csympy/pulls{/number}","milestones_url":"https://api.github.com/repos/sympy/csympy/milestones{/number}","notifications_url":"https://api.github.com/repos/sympy/csympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sympy/csympy/labels{/name}","releases_url":"https://api.github.com/repos/sympy/csympy/releases{/id}","created_at":"2008-08-13T18:40:14Z","updated_at":"2014-06-29T23:14:14Z","pushed_at":"2014-07-04T03:01:50Z","git_url":"git://github.com/sympy/csympy.git","ssh_url":"git@github.com:sympy/csympy.git","clone_url":"https://github.com/sympy/csympy.git","svn_url":"https://github.com/sympy/csympy","homepage":"http://sympy.org","size":5006,"stargazers_count":26,"watchers_count":26,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":26,"mirror_url":null,"open_issues_count":52,"forks":26,"open_issues":52,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sympy/csympy/pulls/235"},"html":{"href":"https://github.com/sympy/csympy/pull/235"},"issue":{"href":"https://api.github.com/repos/sympy/csympy/issues/235"},"comments":{"href":"https://api.github.com/repos/sympy/csympy/issues/235/comments"},"review_comments":{"href":"https://api.github.com/repos/sympy/csympy/pulls/235/comments"},"review_comment":{"href":"https://api.github.com/repos/sympy/csympy/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/sympy/csympy/pulls/235/commits"},"statuses":{"href":"https://api.github.com/repos/sympy/csympy/statuses/3a1f403d66671cd90680e18580dcbd28114c9907"}}}}