GitHub PullRequestEvent at 2014-10-09 16:06:27
Repository: robottelo
Actor: JacobCallahan
Payload: {"action":"closed","number":1538,"pull_request":{"url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/1538","id":22504024,"html_url":"https://github.com/SatelliteQE/robottelo/pull/1538","diff_url":"https://github.com/SatelliteQE/robottelo/pull/1538.diff","patch_url":"https://github.com/SatelliteQE/robottelo/pull/1538.patch","issue_url":"https://api.github.com/repos/SatelliteQE/robottelo/issues/1538","number":1538,"state":"closed","locked":false,"title":"Add comments, make comparison less strict","user":{"login":"Ichimonji10","id":1012989,"avatar_url":"https://avatars.githubusercontent.com/u/1012989?v=2","gravatar_id":"","url":"https://api.github.com/users/Ichimonji10","html_url":"https://github.com/Ichimonji10","followers_url":"https://api.github.com/users/Ichimonji10/followers","following_url":"https://api.github.com/users/Ichimonji10/following{/other_user}","gists_url":"https://api.github.com/users/Ichimonji10/gists{/gist_id}","starred_url":"https://api.github.com/users/Ichimonji10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ichimonji10/subscriptions","organizations_url":"https://api.github.com/users/Ichimonji10/orgs","repos_url":"https://api.github.com/users/Ichimonji10/repos","events_url":"https://api.github.com/users/Ichimonji10/events{/privacy}","received_events_url":"https://api.github.com/users/Ichimonji10/received_events","type":"User","site_admin":false},"body":"Using `assertIsInstance` should allow the intent of the test to be validated\r\nwithout worrying about implementation issues like \"does the mock library swap\r\nout objects under the hood?\"","created_at":"2014-10-09T16:03:06Z","updated_at":"2014-10-09T16:06:26Z","closed_at":"2014-10-09T16:06:26Z","merged_at":"2014-10-09T16:06:26Z","merge_commit_sha":"50ba74d475b49660364028a2e5473b170c94e135","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/1538/commits","review_comments_url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/1538/comments","review_comment_url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/comments/{number}","comments_url":"https://api.github.com/repos/SatelliteQE/robottelo/issues/1538/comments","statuses_url":"https://api.github.com/repos/SatelliteQE/robottelo/statuses/ea7c20d3983507b655cd8d6e9e77461a1b0d32da","head":{"label":"Ichimonji10:fix-test","ref":"fix-test","sha":"ea7c20d3983507b655cd8d6e9e77461a1b0d32da","user":{"login":"Ichimonji10","id":1012989,"avatar_url":"https://avatars.githubusercontent.com/u/1012989?v=2","gravatar_id":"","url":"https://api.github.com/users/Ichimonji10","html_url":"https://github.com/Ichimonji10","followers_url":"https://api.github.com/users/Ichimonji10/followers","following_url":"https://api.github.com/users/Ichimonji10/following{/other_user}","gists_url":"https://api.github.com/users/Ichimonji10/gists{/gist_id}","starred_url":"https://api.github.com/users/Ichimonji10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ichimonji10/subscriptions","organizations_url":"https://api.github.com/users/Ichimonji10/orgs","repos_url":"https://api.github.com/users/Ichimonji10/repos","events_url":"https://api.github.com/users/Ichimonji10/events{/privacy}","received_events_url":"https://api.github.com/users/Ichimonji10/received_events","type":"User","site_admin":false},"repo":{"id":20566902,"name":"robottelo","full_name":"Ichimonji10/robottelo","owner":{"login":"Ichimonji10","id":1012989,"avatar_url":"https://avatars.githubusercontent.com/u/1012989?v=2","gravatar_id":"","url":"https://api.github.com/users/Ichimonji10","html_url":"https://github.com/Ichimonji10","followers_url":"https://api.github.com/users/Ichimonji10/followers","following_url":"https://api.github.com/users/Ichimonji10/following{/other_user}","gists_url":"https://api.github.com/users/Ichimonji10/gists{/gist_id}","starred_url":"https://api.github.com/users/Ichimonji10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ichimonji10/subscriptions","organizations_url":"https://api.github.com/users/Ichimonji10/orgs","repos_url":"https://api.github.com/users/Ichimonji10/repos","events_url":"https://api.github.com/users/Ichimonji10/events{/privacy}","received_events_url":"https://api.github.com/users/Ichimonji10/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ichimonji10/robottelo","description":"An automation testing framework for the Katello project.","fork":true,"url":"https://api.github.com/repos/Ichimonji10/robottelo","forks_url":"https://api.github.com/repos/Ichimonji10/robottelo/forks","keys_url":"https://api.github.com/repos/Ichimonji10/robottelo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ichimonji10/robottelo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ichimonji10/robottelo/teams","hooks_url":"https://api.github.com/repos/Ichimonji10/robottelo/hooks","issue_events_url":"https://api.github.com/repos/Ichimonji10/robottelo/issues/events{/number}","events_url":"https://api.github.com/repos/Ichimonji10/robottelo/events","assignees_url":"https://api.github.com/repos/Ichimonji10/robottelo/assignees{/user}","branches_url":"https://api.github.com/repos/Ichimonji10/robottelo/branches{/branch}","tags_url":"https://api.github.com/repos/Ichimonji10/robottelo/tags","blobs_url":"https://api.github.com/repos/Ichimonji10/robottelo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ichimonji10/robottelo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ichimonji10/robottelo/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ichimonji10/robottelo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ichimonji10/robottelo/statuses/{sha}","languages_url":"https://api.github.com/repos/Ichimonji10/robottelo/languages","stargazers_url":"https://api.github.com/repos/Ichimonji10/robottelo/stargazers","contributors_url":"https://api.github.com/repos/Ichimonji10/robottelo/contributors","subscribers_url":"https://api.github.com/repos/Ichimonji10/robottelo/subscribers","subscription_url":"https://api.github.com/repos/Ichimonji10/robottelo/subscription","commits_url":"https://api.github.com/repos/Ichimonji10/robottelo/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ichimonji10/robottelo/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ichimonji10/robottelo/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ichimonji10/robottelo/issues/comments/{number}","contents_url":"https://api.github.com/repos/Ichimonji10/robottelo/contents/{+path}","compare_url":"https://api.github.com/repos/Ichimonji10/robottelo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ichimonji10/robottelo/merges","archive_url":"https://api.github.com/repos/Ichimonji10/robottelo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ichimonji10/robottelo/downloads","issues_url":"https://api.github.com/repos/Ichimonji10/robottelo/issues{/number}","pulls_url":"https://api.github.com/repos/Ichimonji10/robottelo/pulls{/number}","milestones_url":"https://api.github.com/repos/Ichimonji10/robottelo/milestones{/number}","notifications_url":"https://api.github.com/repos/Ichimonji10/robottelo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ichimonji10/robottelo/labels{/name}","releases_url":"https://api.github.com/repos/Ichimonji10/robottelo/releases{/id}","created_at":"2014-06-06T14:38:05Z","updated_at":"2014-06-25T13:36:09Z","pushed_at":"2014-10-09T16:02:55Z","git_url":"git://github.com/Ichimonji10/robottelo.git","ssh_url":"git@github.com:Ichimonji10/robottelo.git","clone_url":"https://github.com/Ichimonji10/robottelo.git","svn_url":"https://github.com/Ichimonji10/robottelo","homepage":null,"size":10849,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SatelliteQE:master","ref":"master","sha":"e5cc6f2ea7969cf5c578483c606dcb60f85da9c1","user":{"login":"SatelliteQE","id":8754276,"avatar_url":"https://avatars.githubusercontent.com/u/8754276?v=2","gravatar_id":"","url":"https://api.github.com/users/SatelliteQE","html_url":"https://github.com/SatelliteQE","followers_url":"https://api.github.com/users/SatelliteQE/followers","following_url":"https://api.github.com/users/SatelliteQE/following{/other_user}","gists_url":"https://api.github.com/users/SatelliteQE/gists{/gist_id}","starred_url":"https://api.github.com/users/SatelliteQE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SatelliteQE/subscriptions","organizations_url":"https://api.github.com/users/SatelliteQE/orgs","repos_url":"https://api.github.com/users/SatelliteQE/repos","events_url":"https://api.github.com/users/SatelliteQE/events{/privacy}","received_events_url":"https://api.github.com/users/SatelliteQE/received_events","type":"Organization","site_admin":false},"repo":{"id":4000279,"name":"robottelo","full_name":"SatelliteQE/robottelo","owner":{"login":"SatelliteQE","id":8754276,"avatar_url":"https://avatars.githubusercontent.com/u/8754276?v=2","gravatar_id":"","url":"https://api.github.com/users/SatelliteQE","html_url":"https://github.com/SatelliteQE","followers_url":"https://api.github.com/users/SatelliteQE/followers","following_url":"https://api.github.com/users/SatelliteQE/following{/other_user}","gists_url":"https://api.github.com/users/SatelliteQE/gists{/gist_id}","starred_url":"https://api.github.com/users/SatelliteQE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SatelliteQE/subscriptions","organizations_url":"https://api.github.com/users/SatelliteQE/orgs","repos_url":"https://api.github.com/users/SatelliteQE/repos","events_url":"https://api.github.com/users/SatelliteQE/events{/privacy}","received_events_url":"https://api.github.com/users/SatelliteQE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SatelliteQE/robottelo","description":"An automation testing framework for the Katello project.","fork":false,"url":"https://api.github.com/repos/SatelliteQE/robottelo","forks_url":"https://api.github.com/repos/SatelliteQE/robottelo/forks","keys_url":"https://api.github.com/repos/SatelliteQE/robottelo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SatelliteQE/robottelo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SatelliteQE/robottelo/teams","hooks_url":"https://api.github.com/repos/SatelliteQE/robottelo/hooks","issue_events_url":"https://api.github.com/repos/SatelliteQE/robottelo/issues/events{/number}","events_url":"https://api.github.com/repos/SatelliteQE/robottelo/events","assignees_url":"https://api.github.com/repos/SatelliteQE/robottelo/assignees{/user}","branches_url":"https://api.github.com/repos/SatelliteQE/robottelo/branches{/branch}","tags_url":"https://api.github.com/repos/SatelliteQE/robottelo/tags","blobs_url":"https://api.github.com/repos/SatelliteQE/robottelo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SatelliteQE/robottelo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SatelliteQE/robottelo/git/refs{/sha}","trees_url":"https://api.github.com/repos/SatelliteQE/robottelo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SatelliteQE/robottelo/statuses/{sha}","languages_url":"https://api.github.com/repos/SatelliteQE/robottelo/languages","stargazers_url":"https://api.github.com/repos/SatelliteQE/robottelo/stargazers","contributors_url":"https://api.github.com/repos/SatelliteQE/robottelo/contributors","subscribers_url":"https://api.github.com/repos/SatelliteQE/robottelo/subscribers","subscription_url":"https://api.github.com/repos/SatelliteQE/robottelo/subscription","commits_url":"https://api.github.com/repos/SatelliteQE/robottelo/commits{/sha}","git_commits_url":"https://api.github.com/repos/SatelliteQE/robottelo/git/commits{/sha}","comments_url":"https://api.github.com/repos/SatelliteQE/robottelo/comments{/number}","issue_comment_url":"https://api.github.com/repos/SatelliteQE/robottelo/issues/comments/{number}","contents_url":"https://api.github.com/repos/SatelliteQE/robottelo/contents/{+path}","compare_url":"https://api.github.com/repos/SatelliteQE/robottelo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SatelliteQE/robottelo/merges","archive_url":"https://api.github.com/repos/SatelliteQE/robottelo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SatelliteQE/robottelo/downloads","issues_url":"https://api.github.com/repos/SatelliteQE/robottelo/issues{/number}","pulls_url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls{/number}","milestones_url":"https://api.github.com/repos/SatelliteQE/robottelo/milestones{/number}","notifications_url":"https://api.github.com/repos/SatelliteQE/robottelo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SatelliteQE/robottelo/labels{/name}","releases_url":"https://api.github.com/repos/SatelliteQE/robottelo/releases{/id}","created_at":"2012-04-12T01:36:39Z","updated_at":"2014-10-03T18:11:55Z","pushed_at":"2014-10-09T16:06:26Z","git_url":"git://github.com/SatelliteQE/robottelo.git","ssh_url":"git@github.com:SatelliteQE/robottelo.git","clone_url":"https://github.com/SatelliteQE/robottelo.git","svn_url":"https://github.com/SatelliteQE/robottelo","homepage":null,"size":24647,"stargazers_count":17,"watchers_count":17,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":20,"mirror_url":null,"open_issues_count":100,"forks":20,"open_issues":100,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/1538"},"html":{"href":"https://github.com/SatelliteQE/robottelo/pull/1538"},"issue":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/issues/1538"},"comments":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/issues/1538/comments"},"review_comments":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/1538/comments"},"review_comment":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/1538/commits"},"statuses":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/statuses/ea7c20d3983507b655cd8d6e9e77461a1b0d32da"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"JacobCallahan","id":6618303,"avatar_url":"https://avatars.githubusercontent.com/u/6618303?v=2","gravatar_id":"","url":"https://api.github.com/users/JacobCallahan","html_url":"https://github.com/JacobCallahan","followers_url":"https://api.github.com/users/JacobCallahan/followers","following_url":"https://api.github.com/users/JacobCallahan/following{/other_user}","gists_url":"https://api.github.com/users/JacobCallahan/gists{/gist_id}","starred_url":"https://api.github.com/users/JacobCallahan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JacobCallahan/subscriptions","organizations_url":"https://api.github.com/users/JacobCallahan/orgs","repos_url":"https://api.github.com/users/JacobCallahan/repos","events_url":"https://api.github.com/users/JacobCallahan/events{/privacy}","received_events_url":"https://api.github.com/users/JacobCallahan/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":1,"additions":4,"deletions":1,"changed_files":1}}