GitHub PullRequestReviewCommentEvent at 2014-10-22 05:02:51
Repository: tachyon
Actor: shimingfei
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/amplab/tachyon/pulls/comments/19194517","id":19194517,"diff_hunk":"@@ -95,31 +97,31 @@ public void accessBlock(long blockId) {\n    * Add information of a block in current StorageDir\n    * \n    * @param blockId Id of the block\n-   * @param size size of the block in bytes\n+   * @param sizeBytes size of the block in bytes\n    */\n   private void addBlockId(long blockId, long sizeBytes) {\n     accessBlock(blockId);\n     mBlockSizes.put(blockId, sizeBytes);\n   }\n \n-  /**\n-   * Move the cached block file from user temporary directory to data directory\n-   * \n-   * @param userId Id of the user\n-   * @param blockId Id of the block\n-   * @return true if success, false otherwise\n-   * @throws IOException\n-   */\n-  public boolean cacheBlock(long userId, long blockId) throws IOException {\n-    String srcPath = getUserTempFilePath(userId, blockId);\n-    String dstPath = getBlockFilePath(blockId);\n-    long blockSize = mFs.getFileSize(srcPath);\n-    boolean result = mFs.rename(srcPath, dstPath);\n-    if (result) {\n-      addBlockId(blockId, blockSize);\n-    }\n-    return result;\n-  }\n+//  /**\n+//   * Move the cached block file from user temporary directory to data directory","path":"core/src/main/java/tachyon/worker/hierarchy/StorageDir.java","position":38,"original_position":50,"commit_id":"18c00bd7b72f12a99b5d4c761608a3d9edc914a3","original_commit_id":"1bf54e40fd2771939c46f236bec2fe794c948555","user":{"login":"shimingfei","id":2638130,"avatar_url":"https://avatars.githubusercontent.com/u/2638130?v=2","gravatar_id":"","url":"https://api.github.com/users/shimingfei","html_url":"https://github.com/shimingfei","followers_url":"https://api.github.com/users/shimingfei/followers","following_url":"https://api.github.com/users/shimingfei/following{/other_user}","gists_url":"https://api.github.com/users/shimingfei/gists{/gist_id}","starred_url":"https://api.github.com/users/shimingfei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shimingfei/subscriptions","organizations_url":"https://api.github.com/users/shimingfei/orgs","repos_url":"https://api.github.com/users/shimingfei/repos","events_url":"https://api.github.com/users/shimingfei/events{/privacy}","received_events_url":"https://api.github.com/users/shimingfei/received_events","type":"User","site_admin":false},"body":"memory will also managed by tiered storage. current cacheBlock logic in WorkerStorage will be replaced.","created_at":"2014-10-22T05:02:51Z","updated_at":"2014-10-22T05:02:51Z","html_url":"https://github.com/amplab/tachyon/pull/461#discussion_r19194517","pull_request_url":"https://api.github.com/repos/amplab/tachyon/pulls/461","_links":{"self":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/comments/19194517"},"html":{"href":"https://github.com/amplab/tachyon/pull/461#discussion_r19194517"},"pull_request":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/461"}}},"pull_request":{"url":"https://api.github.com/repos/amplab/tachyon/pulls/461","id":22176705,"html_url":"https://github.com/amplab/tachyon/pull/461","diff_url":"https://github.com/amplab/tachyon/pull/461.diff","patch_url":"https://github.com/amplab/tachyon/pull/461.patch","issue_url":"https://api.github.com/repos/amplab/tachyon/issues/461","number":461,"state":"open","locked":false,"title":"Refactor storage dir","user":{"login":"dcapwell","id":1852601,"avatar_url":"https://avatars.githubusercontent.com/u/1852601?v=2","gravatar_id":"","url":"https://api.github.com/users/dcapwell","html_url":"https://github.com/dcapwell","followers_url":"https://api.github.com/users/dcapwell/followers","following_url":"https://api.github.com/users/dcapwell/following{/other_user}","gists_url":"https://api.github.com/users/dcapwell/gists{/gist_id}","starred_url":"https://api.github.com/users/dcapwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcapwell/subscriptions","organizations_url":"https://api.github.com/users/dcapwell/orgs","repos_url":"https://api.github.com/users/dcapwell/repos","events_url":"https://api.github.com/users/dcapwell/events{/privacy}","received_events_url":"https://api.github.com/users/dcapwell/received_events","type":"User","site_admin":false},"body":"I propose that we make `StorageDir` the entry point and drop `BlockHandler`.  The core reasons for this are that:\r\n\r\n`BlockHandler` is the same thing as java's `Channel`.  Easier to use one std convention than create a new one.\r\n`StorageDir` is the main entry point anyways, since the path is relative to the tier, so `BlockHandler` can't be the gateway since it's path depends on the `StorageDir`.","created_at":"2014-10-02T23:03:19Z","updated_at":"2014-10-22T05:02:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b99acd926303f15aa8620629b72e5152c866eb3e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/amplab/tachyon/pulls/461/commits","review_comments_url":"https://api.github.com/repos/amplab/tachyon/pulls/461/comments","review_comment_url":"https://api.github.com/repos/amplab/tachyon/pulls/comments/{number}","comments_url":"https://api.github.com/repos/amplab/tachyon/issues/461/comments","statuses_url":"https://api.github.com/repos/amplab/tachyon/statuses/18c00bd7b72f12a99b5d4c761608a3d9edc914a3","head":{"label":"dcapwell:refactorStorageDir","ref":"refactorStorageDir","sha":"18c00bd7b72f12a99b5d4c761608a3d9edc914a3","user":{"login":"dcapwell","id":1852601,"avatar_url":"https://avatars.githubusercontent.com/u/1852601?v=2","gravatar_id":"","url":"https://api.github.com/users/dcapwell","html_url":"https://github.com/dcapwell","followers_url":"https://api.github.com/users/dcapwell/followers","following_url":"https://api.github.com/users/dcapwell/following{/other_user}","gists_url":"https://api.github.com/users/dcapwell/gists{/gist_id}","starred_url":"https://api.github.com/users/dcapwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcapwell/subscriptions","organizations_url":"https://api.github.com/users/dcapwell/orgs","repos_url":"https://api.github.com/users/dcapwell/repos","events_url":"https://api.github.com/users/dcapwell/events{/privacy}","received_events_url":"https://api.github.com/users/dcapwell/received_events","type":"User","site_admin":false},"repo":{"id":21745003,"name":"tachyon","full_name":"dcapwell/tachyon","owner":{"login":"dcapwell","id":1852601,"avatar_url":"https://avatars.githubusercontent.com/u/1852601?v=2","gravatar_id":"","url":"https://api.github.com/users/dcapwell","html_url":"https://github.com/dcapwell","followers_url":"https://api.github.com/users/dcapwell/followers","following_url":"https://api.github.com/users/dcapwell/following{/other_user}","gists_url":"https://api.github.com/users/dcapwell/gists{/gist_id}","starred_url":"https://api.github.com/users/dcapwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcapwell/subscriptions","organizations_url":"https://api.github.com/users/dcapwell/orgs","repos_url":"https://api.github.com/users/dcapwell/repos","events_url":"https://api.github.com/users/dcapwell/events{/privacy}","received_events_url":"https://api.github.com/users/dcapwell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dcapwell/tachyon","description":"Memory-centric Storage System for Big Data Analytics","fork":true,"url":"https://api.github.com/repos/dcapwell/tachyon","forks_url":"https://api.github.com/repos/dcapwell/tachyon/forks","keys_url":"https://api.github.com/repos/dcapwell/tachyon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcapwell/tachyon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcapwell/tachyon/teams","hooks_url":"https://api.github.com/repos/dcapwell/tachyon/hooks","issue_events_url":"https://api.github.com/repos/dcapwell/tachyon/issues/events{/number}","events_url":"https://api.github.com/repos/dcapwell/tachyon/events","assignees_url":"https://api.github.com/repos/dcapwell/tachyon/assignees{/user}","branches_url":"https://api.github.com/repos/dcapwell/tachyon/branches{/branch}","tags_url":"https://api.github.com/repos/dcapwell/tachyon/tags","blobs_url":"https://api.github.com/repos/dcapwell/tachyon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcapwell/tachyon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcapwell/tachyon/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcapwell/tachyon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcapwell/tachyon/statuses/{sha}","languages_url":"https://api.github.com/repos/dcapwell/tachyon/languages","stargazers_url":"https://api.github.com/repos/dcapwell/tachyon/stargazers","contributors_url":"https://api.github.com/repos/dcapwell/tachyon/contributors","subscribers_url":"https://api.github.com/repos/dcapwell/tachyon/subscribers","subscription_url":"https://api.github.com/repos/dcapwell/tachyon/subscription","commits_url":"https://api.github.com/repos/dcapwell/tachyon/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcapwell/tachyon/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcapwell/tachyon/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcapwell/tachyon/issues/comments/{number}","contents_url":"https://api.github.com/repos/dcapwell/tachyon/contents/{+path}","compare_url":"https://api.github.com/repos/dcapwell/tachyon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcapwell/tachyon/merges","archive_url":"https://api.github.com/repos/dcapwell/tachyon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcapwell/tachyon/downloads","issues_url":"https://api.github.com/repos/dcapwell/tachyon/issues{/number}","pulls_url":"https://api.github.com/repos/dcapwell/tachyon/pulls{/number}","milestones_url":"https://api.github.com/repos/dcapwell/tachyon/milestones{/number}","notifications_url":"https://api.github.com/repos/dcapwell/tachyon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcapwell/tachyon/labels{/name}","releases_url":"https://api.github.com/repos/dcapwell/tachyon/releases{/id}","created_at":"2014-07-11T17:22:53Z","updated_at":"2014-07-12T00:24:31Z","pushed_at":"2014-10-21T23:23:51Z","git_url":"git://github.com/dcapwell/tachyon.git","ssh_url":"git@github.com:dcapwell/tachyon.git","clone_url":"https://github.com/dcapwell/tachyon.git","svn_url":"https://github.com/dcapwell/tachyon","homepage":"http://tachyon-project.org","size":10076,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"amplab:master","ref":"master","sha":"6831bf58039e609657b961706a17764f89bdd468","user":{"login":"amplab","id":1438454,"avatar_url":"https://avatars.githubusercontent.com/u/1438454?v=2","gravatar_id":"","url":"https://api.github.com/users/amplab","html_url":"https://github.com/amplab","followers_url":"https://api.github.com/users/amplab/followers","following_url":"https://api.github.com/users/amplab/following{/other_user}","gists_url":"https://api.github.com/users/amplab/gists{/gist_id}","starred_url":"https://api.github.com/users/amplab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amplab/subscriptions","organizations_url":"https://api.github.com/users/amplab/orgs","repos_url":"https://api.github.com/users/amplab/repos","events_url":"https://api.github.com/users/amplab/events{/privacy}","received_events_url":"https://api.github.com/users/amplab/received_events","type":"Organization","site_admin":false},"repo":{"id":7276954,"name":"tachyon","full_name":"amplab/tachyon","owner":{"login":"amplab","id":1438454,"avatar_url":"https://avatars.githubusercontent.com/u/1438454?v=2","gravatar_id":"","url":"https://api.github.com/users/amplab","html_url":"https://github.com/amplab","followers_url":"https://api.github.com/users/amplab/followers","following_url":"https://api.github.com/users/amplab/following{/other_user}","gists_url":"https://api.github.com/users/amplab/gists{/gist_id}","starred_url":"https://api.github.com/users/amplab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amplab/subscriptions","organizations_url":"https://api.github.com/users/amplab/orgs","repos_url":"https://api.github.com/users/amplab/repos","events_url":"https://api.github.com/users/amplab/events{/privacy}","received_events_url":"https://api.github.com/users/amplab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/amplab/tachyon","description":" A Reliable Memory Centric Distributed Storage System","fork":false,"url":"https://api.github.com/repos/amplab/tachyon","forks_url":"https://api.github.com/repos/amplab/tachyon/forks","keys_url":"https://api.github.com/repos/amplab/tachyon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amplab/tachyon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amplab/tachyon/teams","hooks_url":"https://api.github.com/repos/amplab/tachyon/hooks","issue_events_url":"https://api.github.com/repos/amplab/tachyon/issues/events{/number}","events_url":"https://api.github.com/repos/amplab/tachyon/events","assignees_url":"https://api.github.com/repos/amplab/tachyon/assignees{/user}","branches_url":"https://api.github.com/repos/amplab/tachyon/branches{/branch}","tags_url":"https://api.github.com/repos/amplab/tachyon/tags","blobs_url":"https://api.github.com/repos/amplab/tachyon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amplab/tachyon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amplab/tachyon/git/refs{/sha}","trees_url":"https://api.github.com/repos/amplab/tachyon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amplab/tachyon/statuses/{sha}","languages_url":"https://api.github.com/repos/amplab/tachyon/languages","stargazers_url":"https://api.github.com/repos/amplab/tachyon/stargazers","contributors_url":"https://api.github.com/repos/amplab/tachyon/contributors","subscribers_url":"https://api.github.com/repos/amplab/tachyon/subscribers","subscription_url":"https://api.github.com/repos/amplab/tachyon/subscription","commits_url":"https://api.github.com/repos/amplab/tachyon/commits{/sha}","git_commits_url":"https://api.github.com/repos/amplab/tachyon/git/commits{/sha}","comments_url":"https://api.github.com/repos/amplab/tachyon/comments{/number}","issue_comment_url":"https://api.github.com/repos/amplab/tachyon/issues/comments/{number}","contents_url":"https://api.github.com/repos/amplab/tachyon/contents/{+path}","compare_url":"https://api.github.com/repos/amplab/tachyon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amplab/tachyon/merges","archive_url":"https://api.github.com/repos/amplab/tachyon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amplab/tachyon/downloads","issues_url":"https://api.github.com/repos/amplab/tachyon/issues{/number}","pulls_url":"https://api.github.com/repos/amplab/tachyon/pulls{/number}","milestones_url":"https://api.github.com/repos/amplab/tachyon/milestones{/number}","notifications_url":"https://api.github.com/repos/amplab/tachyon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amplab/tachyon/labels{/name}","releases_url":"https://api.github.com/repos/amplab/tachyon/releases{/id}","created_at":"2012-12-21T17:43:46Z","updated_at":"2014-10-19T05:53:03Z","pushed_at":"2014-10-21T03:42:17Z","git_url":"git://github.com/amplab/tachyon.git","ssh_url":"git@github.com:amplab/tachyon.git","clone_url":"https://github.com/amplab/tachyon.git","svn_url":"https://github.com/amplab/tachyon","homepage":"http://tachyon-project.org","size":31172,"stargazers_count":986,"watchers_count":986,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":310,"mirror_url":null,"open_issues_count":26,"forks":310,"open_issues":26,"watchers":986,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/461"},"html":{"href":"https://github.com/amplab/tachyon/pull/461"},"issue":{"href":"https://api.github.com/repos/amplab/tachyon/issues/461"},"comments":{"href":"https://api.github.com/repos/amplab/tachyon/issues/461/comments"},"review_comments":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/461/comments"},"review_comment":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/461/commits"},"statuses":{"href":"https://api.github.com/repos/amplab/tachyon/statuses/18c00bd7b72f12a99b5d4c761608a3d9edc914a3"}}}}