GitHub PullRequestReviewCommentEvent at 2014-07-29 08:50:16
Repository: whisper
Actor: esc
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/graphite-project/whisper/pulls/comments/15511912","id":15511912,"diff_hunk":"@@ -910,7 +921,7 @@ def file_diff(fh_from, fh_to, ignore_empty = False):\n     (toTimeInfo, toValues) = __archive_fetch(fh_to, archive, startTime, untilTime)\n     (start, end, archive_step) = ( min(fromTimeInfo[0],toTimeInfo[0]), max(fromTimeInfo[1],toTimeInfo[1]), min(fromTimeInfo[2],toTimeInfo[2]) )\n \n-    points = map(lambda s: (s * archive_step + start,fromValues[s],toValues[s]), range(0,(end - start) / archive_step))\n+    points = map(lambda s: (s * archive_step + start,fromValues[s],toValues[s]), xrange(0,(end - start) // archive_step))","path":"whisper.py","position":239,"original_position":239,"commit_id":"4fd39fac5b21c523e471808eabdf5f420c7708b2","original_commit_id":"4fd39fac5b21c523e471808eabdf5f420c7708b2","user":{"login":"esc","id":41563,"avatar_url":"https://avatars.githubusercontent.com/u/41563?","gravatar_id":"677c2e10f993cd87c8ed8ff8ae073a80","url":"https://api.github.com/users/esc","html_url":"https://github.com/esc","followers_url":"https://api.github.com/users/esc/followers","following_url":"https://api.github.com/users/esc/following{/other_user}","gists_url":"https://api.github.com/users/esc/gists{/gist_id}","starred_url":"https://api.github.com/users/esc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esc/subscriptions","organizations_url":"https://api.github.com/users/esc/orgs","repos_url":"https://api.github.com/users/esc/repos","events_url":"https://api.github.com/users/esc/events{/privacy}","received_events_url":"https://api.github.com/users/esc/received_events","type":"User","site_admin":false},"body":"I agree with @brutasse getting python 3 support and refactoring existing code should be orthogonal.","created_at":"2014-07-29T08:50:16Z","updated_at":"2014-07-29T08:50:16Z","html_url":"https://github.com/graphite-project/whisper/pull/70#discussion_r15511912","pull_request_url":"https://api.github.com/repos/graphite-project/whisper/pulls/70","_links":{"self":{"href":"https://api.github.com/repos/graphite-project/whisper/pulls/comments/15511912"},"html":{"href":"https://github.com/graphite-project/whisper/pull/70#discussion_r15511912"},"pull_request":{"href":"https://api.github.com/repos/graphite-project/whisper/pulls/70"}}},"pull_request":{"url":"https://api.github.com/repos/graphite-project/whisper/pulls/70","id":13236539,"html_url":"https://github.com/graphite-project/whisper/pull/70","diff_url":"https://github.com/graphite-project/whisper/pull/70.diff","patch_url":"https://github.com/graphite-project/whisper/pull/70.patch","issue_url":"https://api.github.com/repos/graphite-project/whisper/issues/70","number":70,"state":"open","title":"Python 3 support","user":{"login":"brutasse","id":31269,"avatar_url":"https://avatars.githubusercontent.com/u/31269?","gravatar_id":"bd9b4485bcf325b989b5721bd0ef4d91","url":"https://api.github.com/users/brutasse","html_url":"https://github.com/brutasse","followers_url":"https://api.github.com/users/brutasse/followers","following_url":"https://api.github.com/users/brutasse/following{/other_user}","gists_url":"https://api.github.com/users/brutasse/gists{/gist_id}","starred_url":"https://api.github.com/users/brutasse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brutasse/subscriptions","organizations_url":"https://api.github.com/users/brutasse/orgs","repos_url":"https://api.github.com/users/brutasse/repos","events_url":"https://api.github.com/users/brutasse/events{/privacy}","received_events_url":"https://api.github.com/users/brutasse/received_events","type":"User","site_admin":false},"body":"Mostly fixes related to integer divisions and bytes/str stricter separation.\r\n\r\nI haven't tested this in production but I'm able to graph a whisper file in python 3, which is encouraging.","created_at":"2014-03-05T22:34:50Z","updated_at":"2014-07-29T08:50:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"828a4d7df573f69be29ac6e7e4711d13f2f7ef6c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/graphite-project/whisper/pulls/70/commits","review_comments_url":"https://api.github.com/repos/graphite-project/whisper/pulls/70/comments","review_comment_url":"https://api.github.com/repos/graphite-project/whisper/pulls/comments/{number}","comments_url":"https://api.github.com/repos/graphite-project/whisper/issues/70/comments","statuses_url":"https://api.github.com/repos/graphite-project/whisper/statuses/4fd39fac5b21c523e471808eabdf5f420c7708b2","head":{"label":"brutasse:feature/py3","ref":"feature/py3","sha":"4fd39fac5b21c523e471808eabdf5f420c7708b2","user":{"login":"brutasse","id":31269,"avatar_url":"https://avatars.githubusercontent.com/u/31269?","gravatar_id":"bd9b4485bcf325b989b5721bd0ef4d91","url":"https://api.github.com/users/brutasse","html_url":"https://github.com/brutasse","followers_url":"https://api.github.com/users/brutasse/followers","following_url":"https://api.github.com/users/brutasse/following{/other_user}","gists_url":"https://api.github.com/users/brutasse/gists{/gist_id}","starred_url":"https://api.github.com/users/brutasse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brutasse/subscriptions","organizations_url":"https://api.github.com/users/brutasse/orgs","repos_url":"https://api.github.com/users/brutasse/repos","events_url":"https://api.github.com/users/brutasse/events{/privacy}","received_events_url":"https://api.github.com/users/brutasse/received_events","type":"User","site_admin":false},"repo":{"id":17456974,"name":"whisper","full_name":"brutasse/whisper","owner":{"login":"brutasse","id":31269,"avatar_url":"https://avatars.githubusercontent.com/u/31269?","gravatar_id":"bd9b4485bcf325b989b5721bd0ef4d91","url":"https://api.github.com/users/brutasse","html_url":"https://github.com/brutasse","followers_url":"https://api.github.com/users/brutasse/followers","following_url":"https://api.github.com/users/brutasse/following{/other_user}","gists_url":"https://api.github.com/users/brutasse/gists{/gist_id}","starred_url":"https://api.github.com/users/brutasse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brutasse/subscriptions","organizations_url":"https://api.github.com/users/brutasse/orgs","repos_url":"https://api.github.com/users/brutasse/repos","events_url":"https://api.github.com/users/brutasse/events{/privacy}","received_events_url":"https://api.github.com/users/brutasse/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brutasse/whisper","description":"","fork":true,"url":"https://api.github.com/repos/brutasse/whisper","forks_url":"https://api.github.com/repos/brutasse/whisper/forks","keys_url":"https://api.github.com/repos/brutasse/whisper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brutasse/whisper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brutasse/whisper/teams","hooks_url":"https://api.github.com/repos/brutasse/whisper/hooks","issue_events_url":"https://api.github.com/repos/brutasse/whisper/issues/events{/number}","events_url":"https://api.github.com/repos/brutasse/whisper/events","assignees_url":"https://api.github.com/repos/brutasse/whisper/assignees{/user}","branches_url":"https://api.github.com/repos/brutasse/whisper/branches{/branch}","tags_url":"https://api.github.com/repos/brutasse/whisper/tags","blobs_url":"https://api.github.com/repos/brutasse/whisper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brutasse/whisper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brutasse/whisper/git/refs{/sha}","trees_url":"https://api.github.com/repos/brutasse/whisper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brutasse/whisper/statuses/{sha}","languages_url":"https://api.github.com/repos/brutasse/whisper/languages","stargazers_url":"https://api.github.com/repos/brutasse/whisper/stargazers","contributors_url":"https://api.github.com/repos/brutasse/whisper/contributors","subscribers_url":"https://api.github.com/repos/brutasse/whisper/subscribers","subscription_url":"https://api.github.com/repos/brutasse/whisper/subscription","commits_url":"https://api.github.com/repos/brutasse/whisper/commits{/sha}","git_commits_url":"https://api.github.com/repos/brutasse/whisper/git/commits{/sha}","comments_url":"https://api.github.com/repos/brutasse/whisper/comments{/number}","issue_comment_url":"https://api.github.com/repos/brutasse/whisper/issues/comments/{number}","contents_url":"https://api.github.com/repos/brutasse/whisper/contents/{+path}","compare_url":"https://api.github.com/repos/brutasse/whisper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brutasse/whisper/merges","archive_url":"https://api.github.com/repos/brutasse/whisper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brutasse/whisper/downloads","issues_url":"https://api.github.com/repos/brutasse/whisper/issues{/number}","pulls_url":"https://api.github.com/repos/brutasse/whisper/pulls{/number}","milestones_url":"https://api.github.com/repos/brutasse/whisper/milestones{/number}","notifications_url":"https://api.github.com/repos/brutasse/whisper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brutasse/whisper/labels{/name}","releases_url":"https://api.github.com/repos/brutasse/whisper/releases{/id}","created_at":"2014-03-05T22:07:09Z","updated_at":"2014-03-11T13:25:13Z","pushed_at":"2014-03-11T13:25:12Z","git_url":"git://github.com/brutasse/whisper.git","ssh_url":"git@github.com:brutasse/whisper.git","clone_url":"https://github.com/brutasse/whisper.git","svn_url":"https://github.com/brutasse/whisper","homepage":null,"size":282,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"graphite-project:master","ref":"master","sha":"9101c802540c10aa5ae80f54595fa12037038f05","user":{"login":"graphite-project","id":1714806,"avatar_url":"https://avatars.githubusercontent.com/u/1714806?","gravatar_id":"6cb9d54d641c957e9bd20b66b366730a","url":"https://api.github.com/users/graphite-project","html_url":"https://github.com/graphite-project","followers_url":"https://api.github.com/users/graphite-project/followers","following_url":"https://api.github.com/users/graphite-project/following{/other_user}","gists_url":"https://api.github.com/users/graphite-project/gists{/gist_id}","starred_url":"https://api.github.com/users/graphite-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graphite-project/subscriptions","organizations_url":"https://api.github.com/users/graphite-project/orgs","repos_url":"https://api.github.com/users/graphite-project/repos","events_url":"https://api.github.com/users/graphite-project/events{/privacy}","received_events_url":"https://api.github.com/users/graphite-project/received_events","type":"Organization","site_admin":false},"repo":{"id":4254334,"name":"whisper","full_name":"graphite-project/whisper","owner":{"login":"graphite-project","id":1714806,"avatar_url":"https://avatars.githubusercontent.com/u/1714806?","gravatar_id":"6cb9d54d641c957e9bd20b66b366730a","url":"https://api.github.com/users/graphite-project","html_url":"https://github.com/graphite-project","followers_url":"https://api.github.com/users/graphite-project/followers","following_url":"https://api.github.com/users/graphite-project/following{/other_user}","gists_url":"https://api.github.com/users/graphite-project/gists{/gist_id}","starred_url":"https://api.github.com/users/graphite-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graphite-project/subscriptions","organizations_url":"https://api.github.com/users/graphite-project/orgs","repos_url":"https://api.github.com/users/graphite-project/repos","events_url":"https://api.github.com/users/graphite-project/events{/privacy}","received_events_url":"https://api.github.com/users/graphite-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/graphite-project/whisper","description":"","fork":false,"url":"https://api.github.com/repos/graphite-project/whisper","forks_url":"https://api.github.com/repos/graphite-project/whisper/forks","keys_url":"https://api.github.com/repos/graphite-project/whisper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/graphite-project/whisper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/graphite-project/whisper/teams","hooks_url":"https://api.github.com/repos/graphite-project/whisper/hooks","issue_events_url":"https://api.github.com/repos/graphite-project/whisper/issues/events{/number}","events_url":"https://api.github.com/repos/graphite-project/whisper/events","assignees_url":"https://api.github.com/repos/graphite-project/whisper/assignees{/user}","branches_url":"https://api.github.com/repos/graphite-project/whisper/branches{/branch}","tags_url":"https://api.github.com/repos/graphite-project/whisper/tags","blobs_url":"https://api.github.com/repos/graphite-project/whisper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/graphite-project/whisper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/graphite-project/whisper/git/refs{/sha}","trees_url":"https://api.github.com/repos/graphite-project/whisper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/graphite-project/whisper/statuses/{sha}","languages_url":"https://api.github.com/repos/graphite-project/whisper/languages","stargazers_url":"https://api.github.com/repos/graphite-project/whisper/stargazers","contributors_url":"https://api.github.com/repos/graphite-project/whisper/contributors","subscribers_url":"https://api.github.com/repos/graphite-project/whisper/subscribers","subscription_url":"https://api.github.com/repos/graphite-project/whisper/subscription","commits_url":"https://api.github.com/repos/graphite-project/whisper/commits{/sha}","git_commits_url":"https://api.github.com/repos/graphite-project/whisper/git/commits{/sha}","comments_url":"https://api.github.com/repos/graphite-project/whisper/comments{/number}","issue_comment_url":"https://api.github.com/repos/graphite-project/whisper/issues/comments/{number}","contents_url":"https://api.github.com/repos/graphite-project/whisper/contents/{+path}","compare_url":"https://api.github.com/repos/graphite-project/whisper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/graphite-project/whisper/merges","archive_url":"https://api.github.com/repos/graphite-project/whisper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/graphite-project/whisper/downloads","issues_url":"https://api.github.com/repos/graphite-project/whisper/issues{/number}","pulls_url":"https://api.github.com/repos/graphite-project/whisper/pulls{/number}","milestones_url":"https://api.github.com/repos/graphite-project/whisper/milestones{/number}","notifications_url":"https://api.github.com/repos/graphite-project/whisper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/graphite-project/whisper/labels{/name}","releases_url":"https://api.github.com/repos/graphite-project/whisper/releases{/id}","created_at":"2012-05-07T21:30:26Z","updated_at":"2014-07-18T20:45:51Z","pushed_at":"2014-06-24T01:16:28Z","git_url":"git://github.com/graphite-project/whisper.git","ssh_url":"git@github.com:graphite-project/whisper.git","clone_url":"https://github.com/graphite-project/whisper.git","svn_url":"https://github.com/graphite-project/whisper","homepage":null,"size":836,"stargazers_count":369,"watchers_count":369,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":136,"mirror_url":null,"open_issues_count":41,"forks":136,"open_issues":41,"watchers":369,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/graphite-project/whisper/pulls/70"},"html":{"href":"https://github.com/graphite-project/whisper/pull/70"},"issue":{"href":"https://api.github.com/repos/graphite-project/whisper/issues/70"},"comments":{"href":"https://api.github.com/repos/graphite-project/whisper/issues/70/comments"},"review_comments":{"href":"https://api.github.com/repos/graphite-project/whisper/pulls/70/comments"},"review_comment":{"href":"https://api.github.com/repos/graphite-project/whisper/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/graphite-project/whisper/pulls/70/commits"},"statuses":{"href":"https://api.github.com/repos/graphite-project/whisper/statuses/4fd39fac5b21c523e471808eabdf5f420c7708b2"}}}}