GitHub PullRequestReviewCommentEvent at 2014-12-06 18:48:09
Repository: backbone.marionette
Actor: samccone
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/comments/21418296","id":21418296,"diff_hunk":"@@ -79,6 +102,15 @@ describe('view ui elements', function() {\n     it('should not affect future ui bindings', function() {\n       expect(this.viewTwo.ui).to.deep.equal(this.uiHash);\n     });\n+\n+    it('should throw ViewNotYetRendered when accessing ui bindings through getUI', function() {\n+      expect(_.bind(function() {\n+        this.viewOne.getUI('foo');","path":"test/unit/view.ui-bindings.spec.js","position":51,"original_position":51,"commit_id":"579c427005cbcd6f4ebe45ef046ebcfdedc7597f","original_commit_id":"579c427005cbcd6f4ebe45ef046ebcfdedc7597f","user":{"login":"samccone","id":883126,"avatar_url":"https://avatars.githubusercontent.com/u/883126?v=3","gravatar_id":"","url":"https://api.github.com/users/samccone","html_url":"https://github.com/samccone","followers_url":"https://api.github.com/users/samccone/followers","following_url":"https://api.github.com/users/samccone/following{/other_user}","gists_url":"https://api.github.com/users/samccone/gists{/gist_id}","starred_url":"https://api.github.com/users/samccone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samccone/subscriptions","organizations_url":"https://api.github.com/users/samccone/orgs","repos_url":"https://api.github.com/users/samccone/repos","events_url":"https://api.github.com/users/samccone/events{/privacy}","received_events_url":"https://api.github.com/users/samccone/received_events","type":"User","site_admin":false},"body":"return","created_at":"2014-12-06T18:48:09Z","updated_at":"2014-12-06T18:48:09Z","html_url":"https://github.com/marionettejs/backbone.marionette/pull/2115#discussion_r21418296","pull_request_url":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/2115","_links":{"self":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/comments/21418296"},"html":{"href":"https://github.com/marionettejs/backbone.marionette/pull/2115#discussion_r21418296"},"pull_request":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/2115"}}},"pull_request":{"url":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/2115","id":25618233,"html_url":"https://github.com/marionettejs/backbone.marionette/pull/2115","diff_url":"https://github.com/marionettejs/backbone.marionette/pull/2115.diff","patch_url":"https://github.com/marionettejs/backbone.marionette/pull/2115.patch","issue_url":"https://api.github.com/repos/marionettejs/backbone.marionette/issues/2115","number":2115,"state":"open","locked":false,"title":"Introduce view.getUI","user":{"login":"duncanbeevers","id":7367,"avatar_url":"https://avatars.githubusercontent.com/u/7367?v=3","gravatar_id":"","url":"https://api.github.com/users/duncanbeevers","html_url":"https://github.com/duncanbeevers","followers_url":"https://api.github.com/users/duncanbeevers/followers","following_url":"https://api.github.com/users/duncanbeevers/following{/other_user}","gists_url":"https://api.github.com/users/duncanbeevers/gists{/gist_id}","starred_url":"https://api.github.com/users/duncanbeevers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duncanbeevers/subscriptions","organizations_url":"https://api.github.com/users/duncanbeevers/orgs","repos_url":"https://api.github.com/users/duncanbeevers/repos","events_url":"https://api.github.com/users/duncanbeevers/events{/privacy}","received_events_url":"https://api.github.com/users/duncanbeevers/received_events","type":"User","site_admin":false},"body":"getUI is a stable interface to the view ui hash\r\n\r\nAn error is thrown when attempting to access undefined ui elements.\r\nAn error is thrown when attempting to access ui elements before the view has been rendered.\r\nThe jQuery collection matching the ui element selector is returned when the view is live.\r\nAn empty jQuery collection is returned after the view has been destroyed.\r\n\r\nFixes #2102","created_at":"2014-12-06T12:09:45Z","updated_at":"2014-12-06T18:48:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b5e8550e9833edd889d2f0895f54d12b41c41d8e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/2115/commits","review_comments_url":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/2115/comments","review_comment_url":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/comments/{number}","comments_url":"https://api.github.com/repos/marionettejs/backbone.marionette/issues/2115/comments","statuses_url":"https://api.github.com/repos/marionettejs/backbone.marionette/statuses/579c427005cbcd6f4ebe45ef046ebcfdedc7597f","head":{"label":"duncanbeevers:get-ui","ref":"get-ui","sha":"579c427005cbcd6f4ebe45ef046ebcfdedc7597f","user":{"login":"duncanbeevers","id":7367,"avatar_url":"https://avatars.githubusercontent.com/u/7367?v=3","gravatar_id":"","url":"https://api.github.com/users/duncanbeevers","html_url":"https://github.com/duncanbeevers","followers_url":"https://api.github.com/users/duncanbeevers/followers","following_url":"https://api.github.com/users/duncanbeevers/following{/other_user}","gists_url":"https://api.github.com/users/duncanbeevers/gists{/gist_id}","starred_url":"https://api.github.com/users/duncanbeevers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duncanbeevers/subscriptions","organizations_url":"https://api.github.com/users/duncanbeevers/orgs","repos_url":"https://api.github.com/users/duncanbeevers/repos","events_url":"https://api.github.com/users/duncanbeevers/events{/privacy}","received_events_url":"https://api.github.com/users/duncanbeevers/received_events","type":"User","site_admin":false},"repo":{"id":25043352,"name":"backbone.marionette","full_name":"duncanbeevers/backbone.marionette","owner":{"login":"duncanbeevers","id":7367,"avatar_url":"https://avatars.githubusercontent.com/u/7367?v=3","gravatar_id":"","url":"https://api.github.com/users/duncanbeevers","html_url":"https://github.com/duncanbeevers","followers_url":"https://api.github.com/users/duncanbeevers/followers","following_url":"https://api.github.com/users/duncanbeevers/following{/other_user}","gists_url":"https://api.github.com/users/duncanbeevers/gists{/gist_id}","starred_url":"https://api.github.com/users/duncanbeevers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duncanbeevers/subscriptions","organizations_url":"https://api.github.com/users/duncanbeevers/orgs","repos_url":"https://api.github.com/users/duncanbeevers/repos","events_url":"https://api.github.com/users/duncanbeevers/events{/privacy}","received_events_url":"https://api.github.com/users/duncanbeevers/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/duncanbeevers/backbone.marionette","description":"The Backbone framework","fork":true,"url":"https://api.github.com/repos/duncanbeevers/backbone.marionette","forks_url":"https://api.github.com/repos/duncanbeevers/backbone.marionette/forks","keys_url":"https://api.github.com/repos/duncanbeevers/backbone.marionette/keys{/key_id}","collaborators_url":"https://api.github.com/repos/duncanbeevers/backbone.marionette/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/duncanbeevers/backbone.marionette/teams","hooks_url":"https://api.github.com/repos/duncanbeevers/backbone.marionette/hooks","issue_events_url":"https://api.github.com/repos/duncanbeevers/backbone.marionette/issues/events{/number}","events_url":"https://api.github.com/repos/duncanbeevers/backbone.marionette/events","assignees_url":"https://api.github.com/repos/duncanbeevers/backbone.marionette/assignees{/user}","branches_url":"https://api.github.com/repos/duncanbeevers/backbone.marionette/branches{/branch}","tags_url":"https://api.github.com/repos/duncanbeevers/backbone.marionette/tags","blobs_url":"https://api.github.com/repos/duncanbeevers/backbone.marionette/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/duncanbeevers/backbone.marionette/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/duncanbeevers/backbone.marionette/git/refs{/sha}","trees_url":"https://api.github.com/repos/duncanbeevers/backbone.marionette/git/trees{/sha}","statuses_url":"https://api.github.com/repos/duncanbeevers/backbone.marionette/statuses/{sha}","languages_url":"https://api.github.com/repos/duncanbeevers/backbone.marionette/languages","stargazers_url":"https://api.github.com/repos/duncanbeevers/backbone.marionette/stargazers","contributors_url":"https://api.github.com/repos/duncanbeevers/backbone.marionette/contributors","subscribers_url":"https://api.github.com/repos/duncanbeevers/backbone.marionette/subscribers","subscription_url":"https://api.github.com/repos/duncanbeevers/backbone.marionette/subscription","commits_url":"https://api.github.com/repos/duncanbeevers/backbone.marionette/commits{/sha}","git_commits_url":"https://api.github.com/repos/duncanbeevers/backbone.marionette/git/commits{/sha}","comments_url":"https://api.github.com/repos/duncanbeevers/backbone.marionette/comments{/number}","issue_comment_url":"https://api.github.com/repos/duncanbeevers/backbone.marionette/issues/comments/{number}","contents_url":"https://api.github.com/repos/duncanbeevers/backbone.marionette/contents/{+path}","compare_url":"https://api.github.com/repos/duncanbeevers/backbone.marionette/compare/{base}...{head}","merges_url":"https://api.github.com/repos/duncanbeevers/backbone.marionette/merges","archive_url":"https://api.github.com/repos/duncanbeevers/backbone.marionette/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/duncanbeevers/backbone.marionette/downloads","issues_url":"https://api.github.com/repos/duncanbeevers/backbone.marionette/issues{/number}","pulls_url":"https://api.github.com/repos/duncanbeevers/backbone.marionette/pulls{/number}","milestones_url":"https://api.github.com/repos/duncanbeevers/backbone.marionette/milestones{/number}","notifications_url":"https://api.github.com/repos/duncanbeevers/backbone.marionette/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/duncanbeevers/backbone.marionette/labels{/name}","releases_url":"https://api.github.com/repos/duncanbeevers/backbone.marionette/releases{/id}","created_at":"2014-10-10T16:17:08Z","updated_at":"2014-10-10T13:36:01Z","pushed_at":"2014-12-06T12:09:14Z","git_url":"git://github.com/duncanbeevers/backbone.marionette.git","ssh_url":"git@github.com:duncanbeevers/backbone.marionette.git","clone_url":"https://github.com/duncanbeevers/backbone.marionette.git","svn_url":"https://github.com/duncanbeevers/backbone.marionette","homepage":"http://marionettejs.com","size":9362,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"marionettejs:minor","ref":"minor","sha":"f22a7aeab1439654ba16b30e625c59635376b2a4","user":{"login":"marionettejs","id":2273169,"avatar_url":"https://avatars.githubusercontent.com/u/2273169?v=3","gravatar_id":"","url":"https://api.github.com/users/marionettejs","html_url":"https://github.com/marionettejs","followers_url":"https://api.github.com/users/marionettejs/followers","following_url":"https://api.github.com/users/marionettejs/following{/other_user}","gists_url":"https://api.github.com/users/marionettejs/gists{/gist_id}","starred_url":"https://api.github.com/users/marionettejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marionettejs/subscriptions","organizations_url":"https://api.github.com/users/marionettejs/orgs","repos_url":"https://api.github.com/users/marionettejs/repos","events_url":"https://api.github.com/users/marionettejs/events{/privacy}","received_events_url":"https://api.github.com/users/marionettejs/received_events","type":"Organization","site_admin":false},"repo":{"id":2965621,"name":"backbone.marionette","full_name":"marionettejs/backbone.marionette","owner":{"login":"marionettejs","id":2273169,"avatar_url":"https://avatars.githubusercontent.com/u/2273169?v=3","gravatar_id":"","url":"https://api.github.com/users/marionettejs","html_url":"https://github.com/marionettejs","followers_url":"https://api.github.com/users/marionettejs/followers","following_url":"https://api.github.com/users/marionettejs/following{/other_user}","gists_url":"https://api.github.com/users/marionettejs/gists{/gist_id}","starred_url":"https://api.github.com/users/marionettejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marionettejs/subscriptions","organizations_url":"https://api.github.com/users/marionettejs/orgs","repos_url":"https://api.github.com/users/marionettejs/repos","events_url":"https://api.github.com/users/marionettejs/events{/privacy}","received_events_url":"https://api.github.com/users/marionettejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/marionettejs/backbone.marionette","description":"The Backbone framework","fork":false,"url":"https://api.github.com/repos/marionettejs/backbone.marionette","forks_url":"https://api.github.com/repos/marionettejs/backbone.marionette/forks","keys_url":"https://api.github.com/repos/marionettejs/backbone.marionette/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marionettejs/backbone.marionette/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marionettejs/backbone.marionette/teams","hooks_url":"https://api.github.com/repos/marionettejs/backbone.marionette/hooks","issue_events_url":"https://api.github.com/repos/marionettejs/backbone.marionette/issues/events{/number}","events_url":"https://api.github.com/repos/marionettejs/backbone.marionette/events","assignees_url":"https://api.github.com/repos/marionettejs/backbone.marionette/assignees{/user}","branches_url":"https://api.github.com/repos/marionettejs/backbone.marionette/branches{/branch}","tags_url":"https://api.github.com/repos/marionettejs/backbone.marionette/tags","blobs_url":"https://api.github.com/repos/marionettejs/backbone.marionette/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marionettejs/backbone.marionette/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marionettejs/backbone.marionette/git/refs{/sha}","trees_url":"https://api.github.com/repos/marionettejs/backbone.marionette/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marionettejs/backbone.marionette/statuses/{sha}","languages_url":"https://api.github.com/repos/marionettejs/backbone.marionette/languages","stargazers_url":"https://api.github.com/repos/marionettejs/backbone.marionette/stargazers","contributors_url":"https://api.github.com/repos/marionettejs/backbone.marionette/contributors","subscribers_url":"https://api.github.com/repos/marionettejs/backbone.marionette/subscribers","subscription_url":"https://api.github.com/repos/marionettejs/backbone.marionette/subscription","commits_url":"https://api.github.com/repos/marionettejs/backbone.marionette/commits{/sha}","git_commits_url":"https://api.github.com/repos/marionettejs/backbone.marionette/git/commits{/sha}","comments_url":"https://api.github.com/repos/marionettejs/backbone.marionette/comments{/number}","issue_comment_url":"https://api.github.com/repos/marionettejs/backbone.marionette/issues/comments/{number}","contents_url":"https://api.github.com/repos/marionettejs/backbone.marionette/contents/{+path}","compare_url":"https://api.github.com/repos/marionettejs/backbone.marionette/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marionettejs/backbone.marionette/merges","archive_url":"https://api.github.com/repos/marionettejs/backbone.marionette/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marionettejs/backbone.marionette/downloads","issues_url":"https://api.github.com/repos/marionettejs/backbone.marionette/issues{/number}","pulls_url":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls{/number}","milestones_url":"https://api.github.com/repos/marionettejs/backbone.marionette/milestones{/number}","notifications_url":"https://api.github.com/repos/marionettejs/backbone.marionette/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marionettejs/backbone.marionette/labels{/name}","releases_url":"https://api.github.com/repos/marionettejs/backbone.marionette/releases{/id}","created_at":"2011-12-12T16:36:09Z","updated_at":"2014-12-06T18:10:20Z","pushed_at":"2014-12-03T21:58:40Z","git_url":"git://github.com/marionettejs/backbone.marionette.git","ssh_url":"git@github.com:marionettejs/backbone.marionette.git","clone_url":"https://github.com/marionettejs/backbone.marionette.git","svn_url":"https://github.com/marionettejs/backbone.marionette","homepage":"http://marionettejs.com","size":35165,"stargazers_count":5647,"watchers_count":5647,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1052,"mirror_url":null,"open_issues_count":73,"forks":1052,"open_issues":73,"watchers":5647,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/2115"},"html":{"href":"https://github.com/marionettejs/backbone.marionette/pull/2115"},"issue":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/issues/2115"},"comments":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/issues/2115/comments"},"review_comments":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/2115/comments"},"review_comment":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/2115/commits"},"statuses":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/statuses/579c427005cbcd6f4ebe45ef046ebcfdedc7597f"}}}}