GitHub PullRequestReviewCommentEvent at 2014-08-21 17:46:37
Repository: aws-cli
Actor: jamesls
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/aws/aws-cli/pulls/comments/16554824","id":16554824,"diff_hunk":"@@ -546,6 +546,8 @@ def invoke(self, operation_object, parameters, parsed_globals):\n             endpoint_url=parsed_globals.endpoint_url,\n             verify=parsed_globals.verify_ssl)\n         if operation_object.can_paginate and parsed_globals.paginate:\n+            if getattr(parsed_globals, 'page_size', None):","path":"awscli/clidriver.py","position":4,"original_position":4,"commit_id":"7bc2e3a74c9474923f0462542315a1566c61b6dd","original_commit_id":"7bc2e3a74c9474923f0462542315a1566c61b6dd","user":{"login":"jamesls","id":368057,"avatar_url":"https://avatars.githubusercontent.com/u/368057?v=2","gravatar_id":"a8cb6a42bfa3881315aafa5e027390e3","url":"https://api.github.com/users/jamesls","html_url":"https://github.com/jamesls","followers_url":"https://api.github.com/users/jamesls/followers","following_url":"https://api.github.com/users/jamesls/following{/other_user}","gists_url":"https://api.github.com/users/jamesls/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesls/subscriptions","organizations_url":"https://api.github.com/users/jamesls/orgs","repos_url":"https://api.github.com/users/jamesls/repos","events_url":"https://api.github.com/users/jamesls/events{/privacy}","received_events_url":"https://api.github.com/users/jamesls/received_events","type":"User","site_admin":false},"body":"why is getattr() needed here?  If it's a global arg you should just be able to access `parsed_globals.page_size` directly right?","created_at":"2014-08-21T17:46:37Z","updated_at":"2014-08-21T17:46:37Z","html_url":"https://github.com/aws/aws-cli/pull/889#discussion_r16554824","pull_request_url":"https://api.github.com/repos/aws/aws-cli/pulls/889","_links":{"self":{"href":"https://api.github.com/repos/aws/aws-cli/pulls/comments/16554824"},"html":{"href":"https://github.com/aws/aws-cli/pull/889#discussion_r16554824"},"pull_request":{"href":"https://api.github.com/repos/aws/aws-cli/pulls/889"}}},"pull_request":{"url":"https://api.github.com/repos/aws/aws-cli/pulls/889","id":20077695,"html_url":"https://github.com/aws/aws-cli/pull/889","diff_url":"https://github.com/aws/aws-cli/pull/889.diff","patch_url":"https://github.com/aws/aws-cli/pull/889.patch","issue_url":"https://api.github.com/repos/aws/aws-cli/issues/889","number":889,"state":"open","locked":false,"title":"Enabled ``--page-size`` as global argument.","user":{"login":"kyleknap","id":4605355,"avatar_url":"https://avatars.githubusercontent.com/u/4605355?v=2","gravatar_id":"e9d1ea4ead5698594bd70e2166b2930f","url":"https://api.github.com/users/kyleknap","html_url":"https://github.com/kyleknap","followers_url":"https://api.github.com/users/kyleknap/followers","following_url":"https://api.github.com/users/kyleknap/following{/other_user}","gists_url":"https://api.github.com/users/kyleknap/gists{/gist_id}","starred_url":"https://api.github.com/users/kyleknap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyleknap/subscriptions","organizations_url":"https://api.github.com/users/kyleknap/orgs","repos_url":"https://api.github.com/users/kyleknap/repos","events_url":"https://api.github.com/users/kyleknap/events{/privacy}","received_events_url":"https://api.github.com/users/kyleknap/received_events","type":"User","site_admin":false},"body":"The page size controls the amount of items returned by\r\neach page while paginating. Smoke tests were added for ``ec2``\r\nand ``s3api`` to ensure the parameter does what is expected to\r\ndo for known paginating operations.\r\n\r\ncc @jamesls @danielgtaylor","created_at":"2014-08-20T22:08:12Z","updated_at":"2014-08-21T17:46:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c8cbf495119caf098795c923ae8105500ad9f4c0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aws/aws-cli/pulls/889/commits","review_comments_url":"https://api.github.com/repos/aws/aws-cli/pulls/889/comments","review_comment_url":"https://api.github.com/repos/aws/aws-cli/pulls/comments/{number}","comments_url":"https://api.github.com/repos/aws/aws-cli/issues/889/comments","statuses_url":"https://api.github.com/repos/aws/aws-cli/statuses/7bc2e3a74c9474923f0462542315a1566c61b6dd","head":{"label":"kyleknap:page-size","ref":"page-size","sha":"7bc2e3a74c9474923f0462542315a1566c61b6dd","user":{"login":"kyleknap","id":4605355,"avatar_url":"https://avatars.githubusercontent.com/u/4605355?v=2","gravatar_id":"e9d1ea4ead5698594bd70e2166b2930f","url":"https://api.github.com/users/kyleknap","html_url":"https://github.com/kyleknap","followers_url":"https://api.github.com/users/kyleknap/followers","following_url":"https://api.github.com/users/kyleknap/following{/other_user}","gists_url":"https://api.github.com/users/kyleknap/gists{/gist_id}","starred_url":"https://api.github.com/users/kyleknap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyleknap/subscriptions","organizations_url":"https://api.github.com/users/kyleknap/orgs","repos_url":"https://api.github.com/users/kyleknap/repos","events_url":"https://api.github.com/users/kyleknap/events{/privacy}","received_events_url":"https://api.github.com/users/kyleknap/received_events","type":"User","site_admin":false},"repo":{"id":12092925,"name":"aws-cli","full_name":"kyleknap/aws-cli","owner":{"login":"kyleknap","id":4605355,"avatar_url":"https://avatars.githubusercontent.com/u/4605355?v=2","gravatar_id":"e9d1ea4ead5698594bd70e2166b2930f","url":"https://api.github.com/users/kyleknap","html_url":"https://github.com/kyleknap","followers_url":"https://api.github.com/users/kyleknap/followers","following_url":"https://api.github.com/users/kyleknap/following{/other_user}","gists_url":"https://api.github.com/users/kyleknap/gists{/gist_id}","starred_url":"https://api.github.com/users/kyleknap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyleknap/subscriptions","organizations_url":"https://api.github.com/users/kyleknap/orgs","repos_url":"https://api.github.com/users/kyleknap/repos","events_url":"https://api.github.com/users/kyleknap/events{/privacy}","received_events_url":"https://api.github.com/users/kyleknap/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kyleknap/aws-cli","description":"Universal Command Line Interface for Amazon Web Services","fork":true,"url":"https://api.github.com/repos/kyleknap/aws-cli","forks_url":"https://api.github.com/repos/kyleknap/aws-cli/forks","keys_url":"https://api.github.com/repos/kyleknap/aws-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kyleknap/aws-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kyleknap/aws-cli/teams","hooks_url":"https://api.github.com/repos/kyleknap/aws-cli/hooks","issue_events_url":"https://api.github.com/repos/kyleknap/aws-cli/issues/events{/number}","events_url":"https://api.github.com/repos/kyleknap/aws-cli/events","assignees_url":"https://api.github.com/repos/kyleknap/aws-cli/assignees{/user}","branches_url":"https://api.github.com/repos/kyleknap/aws-cli/branches{/branch}","tags_url":"https://api.github.com/repos/kyleknap/aws-cli/tags","blobs_url":"https://api.github.com/repos/kyleknap/aws-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kyleknap/aws-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kyleknap/aws-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/kyleknap/aws-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kyleknap/aws-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/kyleknap/aws-cli/languages","stargazers_url":"https://api.github.com/repos/kyleknap/aws-cli/stargazers","contributors_url":"https://api.github.com/repos/kyleknap/aws-cli/contributors","subscribers_url":"https://api.github.com/repos/kyleknap/aws-cli/subscribers","subscription_url":"https://api.github.com/repos/kyleknap/aws-cli/subscription","commits_url":"https://api.github.com/repos/kyleknap/aws-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/kyleknap/aws-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/kyleknap/aws-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/kyleknap/aws-cli/issues/comments/{number}","contents_url":"https://api.github.com/repos/kyleknap/aws-cli/contents/{+path}","compare_url":"https://api.github.com/repos/kyleknap/aws-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kyleknap/aws-cli/merges","archive_url":"https://api.github.com/repos/kyleknap/aws-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kyleknap/aws-cli/downloads","issues_url":"https://api.github.com/repos/kyleknap/aws-cli/issues{/number}","pulls_url":"https://api.github.com/repos/kyleknap/aws-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/kyleknap/aws-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/kyleknap/aws-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kyleknap/aws-cli/labels{/name}","releases_url":"https://api.github.com/repos/kyleknap/aws-cli/releases{/id}","created_at":"2013-08-13T21:03:11Z","updated_at":"2014-07-28T21:42:02Z","pushed_at":"2014-08-20T22:02:39Z","git_url":"git://github.com/kyleknap/aws-cli.git","ssh_url":"git@github.com:kyleknap/aws-cli.git","clone_url":"https://github.com/kyleknap/aws-cli.git","svn_url":"https://github.com/kyleknap/aws-cli","homepage":null,"size":5274,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"aws:develop","ref":"develop","sha":"c560dfe87774e2ada1a48bafcffc09a937a1943a","user":{"login":"aws","id":2232217,"avatar_url":"https://avatars.githubusercontent.com/u/2232217?v=2","gravatar_id":"b66042c7e9e8ae1a0fe1c0c3245d3d91","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"repo":{"id":6780767,"name":"aws-cli","full_name":"aws/aws-cli","owner":{"login":"aws","id":2232217,"avatar_url":"https://avatars.githubusercontent.com/u/2232217?v=2","gravatar_id":"b66042c7e9e8ae1a0fe1c0c3245d3d91","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aws/aws-cli","description":"Universal Command Line Interface for Amazon Web Services","fork":false,"url":"https://api.github.com/repos/aws/aws-cli","forks_url":"https://api.github.com/repos/aws/aws-cli/forks","keys_url":"https://api.github.com/repos/aws/aws-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aws/aws-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aws/aws-cli/teams","hooks_url":"https://api.github.com/repos/aws/aws-cli/hooks","issue_events_url":"https://api.github.com/repos/aws/aws-cli/issues/events{/number}","events_url":"https://api.github.com/repos/aws/aws-cli/events","assignees_url":"https://api.github.com/repos/aws/aws-cli/assignees{/user}","branches_url":"https://api.github.com/repos/aws/aws-cli/branches{/branch}","tags_url":"https://api.github.com/repos/aws/aws-cli/tags","blobs_url":"https://api.github.com/repos/aws/aws-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aws/aws-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aws/aws-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/aws/aws-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aws/aws-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/aws/aws-cli/languages","stargazers_url":"https://api.github.com/repos/aws/aws-cli/stargazers","contributors_url":"https://api.github.com/repos/aws/aws-cli/contributors","subscribers_url":"https://api.github.com/repos/aws/aws-cli/subscribers","subscription_url":"https://api.github.com/repos/aws/aws-cli/subscription","commits_url":"https://api.github.com/repos/aws/aws-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/aws/aws-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/aws/aws-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/aws/aws-cli/issues/comments/{number}","contents_url":"https://api.github.com/repos/aws/aws-cli/contents/{+path}","compare_url":"https://api.github.com/repos/aws/aws-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aws/aws-cli/merges","archive_url":"https://api.github.com/repos/aws/aws-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aws/aws-cli/downloads","issues_url":"https://api.github.com/repos/aws/aws-cli/issues{/number}","pulls_url":"https://api.github.com/repos/aws/aws-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/aws/aws-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/aws/aws-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aws/aws-cli/labels{/name}","releases_url":"https://api.github.com/repos/aws/aws-cli/releases{/id}","created_at":"2012-11-20T16:07:36Z","updated_at":"2014-08-21T15:06:22Z","pushed_at":"2014-08-20T20:44:24Z","git_url":"git://github.com/aws/aws-cli.git","ssh_url":"git@github.com:aws/aws-cli.git","clone_url":"https://github.com/aws/aws-cli.git","svn_url":"https://github.com/aws/aws-cli","homepage":null,"size":14736,"stargazers_count":2105,"watchers_count":2105,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":249,"mirror_url":null,"open_issues_count":100,"forks":249,"open_issues":100,"watchers":2105,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/aws/aws-cli/pulls/889"},"html":{"href":"https://github.com/aws/aws-cli/pull/889"},"issue":{"href":"https://api.github.com/repos/aws/aws-cli/issues/889"},"comments":{"href":"https://api.github.com/repos/aws/aws-cli/issues/889/comments"},"review_comments":{"href":"https://api.github.com/repos/aws/aws-cli/pulls/889/comments"},"review_comment":{"href":"https://api.github.com/repos/aws/aws-cli/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/aws/aws-cli/pulls/889/commits"},"statuses":{"href":"https://api.github.com/repos/aws/aws-cli/statuses/7bc2e3a74c9474923f0462542315a1566c61b6dd"}}}}