GitHub PullRequestReviewCommentEvent at 2014-02-24 14:41:17
Repository: pandora
Actor: stoewer
Payload: {"comment":{"url":"https://api.github.com/repos/G-Node/pandora/pulls/comments/9992793","id":9992793,"diff_hunk":"@@ -63,6 +63,11 @@ class NIXAPI Property : virtual public base::IProperty, public base::NamedEntity\n     std::string mapping() const {\n         return impl_ptr->mapping();\n     }\n+    \n+    \n+    void mapping(const boost::none_t t) {","path":"include/nix/Property.hpp","position":6,"original_position":6,"commit_id":"8ce4a3600dac04d904cd94f57f6a9478fb5f61b4","original_commit_id":"8ce4a3600dac04d904cd94f57f6a9478fb5f61b4","user":{"login":"stoewer","id":2076136,"avatar_url":"https://gravatar.com/avatar/0534f4e66895400ab270025866d6ea0b?d=https%3A%2F%2Fidenticons.github.com%2F2802543562991406a74786a3d28978cb.png&r=x","gravatar_id":"0534f4e66895400ab270025866d6ea0b","url":"https://api.github.com/users/stoewer","html_url":"https://github.com/stoewer","followers_url":"https://api.github.com/users/stoewer/followers","following_url":"https://api.github.com/users/stoewer/following{/other_user}","gists_url":"https://api.github.com/users/stoewer/gists{/gist_id}","starred_url":"https://api.github.com/users/stoewer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stoewer/subscriptions","organizations_url":"https://api.github.com/users/stoewer/orgs","repos_url":"https://api.github.com/users/stoewer/repos","events_url":"https://api.github.com/users/stoewer/events{/privacy}","received_events_url":"https://api.github.com/users/stoewer/received_events","type":"User","site_admin":false},"body":"If there is a setter with none_t, shouldn't then the getter return an optional?","created_at":"2014-02-24T14:41:17Z","updated_at":"2014-02-24T14:41:17Z","html_url":"https://github.com/G-Node/pandora/pull/110#discussion_r9992793","pull_request_url":"https://api.github.com/repos/G-Node/pandora/pulls/110","_links":{"self":{"href":"https://api.github.com/repos/G-Node/pandora/pulls/comments/9992793"},"html":{"href":"https://github.com/G-Node/pandora/pull/110#discussion_r9992793"},"pull_request":{"href":"https://api.github.com/repos/G-Node/pandora/pulls/110"}}}}