GitHub PullRequestReviewCommentEvent at 2014-07-17 07:21:29
Repository: spark
Actor: sryza
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/15043860","id":15043860,"diff_hunk":"@@ -216,17 +216,17 @@ class PairRDDFunctions[K, V](self: RDD[(K, V)])\n \n     def reducePartition(iter: Iterator[(K, V)]): Iterator[JHashMap[K, V]] = {\n       val map = new JHashMap[K, V]\n-      iter.foreach { case (k, v) =>\n-        val old = map.get(k)\n-        map.put(k, if (old == null) v else func(old, v))\n+      iter.foreach { pair =>\n+        val old = map.get(pair._1)","path":"core/src/main/scala/org/apache/spark/rdd/PairRDDFunctions.scala","position":8,"original_position":8,"commit_id":"906e6b362db11a4ac5a3f8096668c6f968dc48aa","original_commit_id":"906e6b362db11a4ac5a3f8096668c6f968dc48aa","user":{"login":"sryza","id":654855,"avatar_url":"https://avatars.githubusercontent.com/u/654855?","gravatar_id":"dab861f2a8878e52c6f9289d6bb3817b","url":"https://api.github.com/users/sryza","html_url":"https://github.com/sryza","followers_url":"https://api.github.com/users/sryza/followers","following_url":"https://api.github.com/users/sryza/following{/other_user}","gists_url":"https://api.github.com/users/sryza/gists{/gist_id}","starred_url":"https://api.github.com/users/sryza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sryza/subscriptions","organizations_url":"https://api.github.com/users/sryza/orgs","repos_url":"https://api.github.com/users/sryza/repos","events_url":"https://api.github.com/users/sryza/events{/privacy}","received_events_url":"https://api.github.com/users/sryza/received_events","type":"User","site_admin":false},"body":"Also on removing the calls to _1,  these values should be in cache, so accesses will be really fast.  Will hold off on these for now, but happy to make the change if y'all want.","created_at":"2014-07-17T07:21:29Z","updated_at":"2014-07-17T07:21:29Z","html_url":"https://github.com/apache/spark/pull/1447#discussion_r15043860","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/1447","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/15043860"},"html":{"href":"https://github.com/apache/spark/pull/1447#discussion_r15043860"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/1447"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/1447","id":18495360,"html_url":"https://github.com/apache/spark/pull/1447","diff_url":"https://github.com/apache/spark/pull/1447.diff","patch_url":"https://github.com/apache/spark/pull/1447.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/1447","number":1447,"state":"open","title":"SPARK-2519 part 2. Remove pattern matching on Tuple2 in critical section...","user":{"login":"sryza","id":654855,"avatar_url":"https://avatars.githubusercontent.com/u/654855?","gravatar_id":"dab861f2a8878e52c6f9289d6bb3817b","url":"https://api.github.com/users/sryza","html_url":"https://github.com/sryza","followers_url":"https://api.github.com/users/sryza/followers","following_url":"https://api.github.com/users/sryza/following{/other_user}","gists_url":"https://api.github.com/users/sryza/gists{/gist_id}","starred_url":"https://api.github.com/users/sryza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sryza/subscriptions","organizations_url":"https://api.github.com/users/sryza/orgs","repos_url":"https://api.github.com/users/sryza/repos","events_url":"https://api.github.com/users/sryza/events{/privacy}","received_events_url":"https://api.github.com/users/sryza/received_events","type":"User","site_admin":false},"body":"...s of CoGroupedRDD and PairRDDFunctions\r\n\r\nThis also removes an unnecessary tuple creation in cogroup.","created_at":"2014-07-16T21:09:54Z","updated_at":"2014-07-17T07:21:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f7128741e7ae8e89429c25e20118bcf03d1e4862","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/1447/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/1447/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments/{number}","comments_url":"https://api.github.com/repos/apache/spark/issues/1447/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/906e6b362db11a4ac5a3f8096668c6f968dc48aa","head":{"label":"sryza:sandy-spark-2519-2","ref":"sandy-spark-2519-2","sha":"906e6b362db11a4ac5a3f8096668c6f968dc48aa","user":{"login":"sryza","id":654855,"avatar_url":"https://avatars.githubusercontent.com/u/654855?","gravatar_id":"dab861f2a8878e52c6f9289d6bb3817b","url":"https://api.github.com/users/sryza","html_url":"https://github.com/sryza","followers_url":"https://api.github.com/users/sryza/followers","following_url":"https://api.github.com/users/sryza/following{/other_user}","gists_url":"https://api.github.com/users/sryza/gists{/gist_id}","starred_url":"https://api.github.com/users/sryza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sryza/subscriptions","organizations_url":"https://api.github.com/users/sryza/orgs","repos_url":"https://api.github.com/users/sryza/repos","events_url":"https://api.github.com/users/sryza/events{/privacy}","received_events_url":"https://api.github.com/users/sryza/received_events","type":"User","site_admin":false},"repo":{"id":17230980,"name":"spark","full_name":"sryza/spark","owner":{"login":"sryza","id":654855,"avatar_url":"https://avatars.githubusercontent.com/u/654855?","gravatar_id":"dab861f2a8878e52c6f9289d6bb3817b","url":"https://api.github.com/users/sryza","html_url":"https://github.com/sryza","followers_url":"https://api.github.com/users/sryza/followers","following_url":"https://api.github.com/users/sryza/following{/other_user}","gists_url":"https://api.github.com/users/sryza/gists{/gist_id}","starred_url":"https://api.github.com/users/sryza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sryza/subscriptions","organizations_url":"https://api.github.com/users/sryza/orgs","repos_url":"https://api.github.com/users/sryza/repos","events_url":"https://api.github.com/users/sryza/events{/privacy}","received_events_url":"https://api.github.com/users/sryza/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sryza/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/sryza/spark","forks_url":"https://api.github.com/repos/sryza/spark/forks","keys_url":"https://api.github.com/repos/sryza/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sryza/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sryza/spark/teams","hooks_url":"https://api.github.com/repos/sryza/spark/hooks","issue_events_url":"https://api.github.com/repos/sryza/spark/issues/events{/number}","events_url":"https://api.github.com/repos/sryza/spark/events","assignees_url":"https://api.github.com/repos/sryza/spark/assignees{/user}","branches_url":"https://api.github.com/repos/sryza/spark/branches{/branch}","tags_url":"https://api.github.com/repos/sryza/spark/tags","blobs_url":"https://api.github.com/repos/sryza/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sryza/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sryza/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/sryza/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sryza/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/sryza/spark/languages","stargazers_url":"https://api.github.com/repos/sryza/spark/stargazers","contributors_url":"https://api.github.com/repos/sryza/spark/contributors","subscribers_url":"https://api.github.com/repos/sryza/spark/subscribers","subscription_url":"https://api.github.com/repos/sryza/spark/subscription","commits_url":"https://api.github.com/repos/sryza/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/sryza/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/sryza/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/sryza/spark/issues/comments/{number}","contents_url":"https://api.github.com/repos/sryza/spark/contents/{+path}","compare_url":"https://api.github.com/repos/sryza/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sryza/spark/merges","archive_url":"https://api.github.com/repos/sryza/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sryza/spark/downloads","issues_url":"https://api.github.com/repos/sryza/spark/issues{/number}","pulls_url":"https://api.github.com/repos/sryza/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/sryza/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/sryza/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sryza/spark/labels{/name}","releases_url":"https://api.github.com/repos/sryza/spark/releases{/id}","created_at":"2014-02-27T00:28:05Z","updated_at":"2014-06-25T08:18:09Z","pushed_at":"2014-07-16T21:08:57Z","git_url":"git://github.com/sryza/spark.git","ssh_url":"git@github.com:sryza/spark.git","clone_url":"https://github.com/sryza/spark.git","svn_url":"https://github.com/sryza/spark","homepage":null,"size":72043,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"7c8d123225bbdcc605642099b107c2d843e87340","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?","gravatar_id":"a676c0bf448fcd49f588249ead719b4c","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?","gravatar_id":"a676c0bf448fcd49f588249ead719b4c","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments/{number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2014-07-17T05:33:07Z","pushed_at":"2014-07-17T07:03:30Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":2229986,"stargazers_count":846,"watchers_count":846,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":863,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":249,"forks":863,"open_issues":249,"watchers":846,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/1447"},"html":{"href":"https://github.com/apache/spark/pull/1447"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/1447"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/1447/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/1447/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/1447/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/906e6b362db11a4ac5a3f8096668c6f968dc48aa"}}}}