GitHub PullRequestReviewCommentEvent at 2014-10-01 20:53:19
Repository: resource_kit
Actor: davidcelis
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/digitalocean/resource_kit/pulls/comments/18307151","id":18307151,"diff_hunk":"@@ -0,0 +1,54 @@\n+require 'spec_helper'\n+\n+describe ResourceKit::InheritableAttribute do\n+  subject do\n+    Class.new(Object) do\n+      extend ResourceKit::InheritableAttribute\n+\n+      inheritable_attr :_resources\n+    end\n+  end\n+\n+  it 'provides a reader with an empty inherited attribute' do\n+    expect(subject._resources).to be_nil\n+  end\n+\n+  it 'provides a reader with empty inherited attributes in a derived class' do\n+    expect(Class.new(subject)._resources).to be_nil\n+\n+    # subject._resouces = true\n+    # Class.new(subject)._resources # TODO: crashes.","path":"spec/lib/resource_kit/inheritable_attribute_spec.rb","position":20,"original_position":20,"commit_id":"28685e4717b70d7c50e64cf92b3d8e3b45ca5b79","original_commit_id":"28685e4717b70d7c50e64cf92b3d8e3b45ca5b79","user":{"login":"davidcelis","id":36873,"avatar_url":"https://avatars.githubusercontent.com/u/36873?v=2","gravatar_id":"","url":"https://api.github.com/users/davidcelis","html_url":"https://github.com/davidcelis","followers_url":"https://api.github.com/users/davidcelis/followers","following_url":"https://api.github.com/users/davidcelis/following{/other_user}","gists_url":"https://api.github.com/users/davidcelis/gists{/gist_id}","starred_url":"https://api.github.com/users/davidcelis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidcelis/subscriptions","organizations_url":"https://api.github.com/users/davidcelis/orgs","repos_url":"https://api.github.com/users/davidcelis/repos","events_url":"https://api.github.com/users/davidcelis/events{/privacy}","received_events_url":"https://api.github.com/users/davidcelis/received_events","type":"User","site_admin":false},"body":"Haha that was in the source of where I got this implementation of. Figured I should leave it for posterity.","created_at":"2014-10-01T20:53:19Z","updated_at":"2014-10-01T20:53:19Z","html_url":"https://github.com/digitalocean/resource_kit/pull/10#discussion_r18307151","pull_request_url":"https://api.github.com/repos/digitalocean/resource_kit/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/digitalocean/resource_kit/pulls/comments/18307151"},"html":{"href":"https://github.com/digitalocean/resource_kit/pull/10#discussion_r18307151"},"pull_request":{"href":"https://api.github.com/repos/digitalocean/resource_kit/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/digitalocean/resource_kit/pulls/10","id":22093586,"html_url":"https://github.com/digitalocean/resource_kit/pull/10","diff_url":"https://github.com/digitalocean/resource_kit/pull/10.diff","patch_url":"https://github.com/digitalocean/resource_kit/pull/10.patch","issue_url":"https://api.github.com/repos/digitalocean/resource_kit/issues/10","number":10,"state":"closed","locked":false,"title":"Remove dependency on ActiveSupport (fixes #8)","user":{"login":"davidcelis","id":36873,"avatar_url":"https://avatars.githubusercontent.com/u/36873?v=2","gravatar_id":"","url":"https://api.github.com/users/davidcelis","html_url":"https://github.com/davidcelis","followers_url":"https://api.github.com/users/davidcelis/followers","following_url":"https://api.github.com/users/davidcelis/following{/other_user}","gists_url":"https://api.github.com/users/davidcelis/gists{/gist_id}","starred_url":"https://api.github.com/users/davidcelis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidcelis/subscriptions","organizations_url":"https://api.github.com/users/davidcelis/orgs","repos_url":"https://api.github.com/users/davidcelis/repos","events_url":"https://api.github.com/users/davidcelis/events{/privacy}","received_events_url":"https://api.github.com/users/davidcelis/received_events","type":"User","site_admin":false},"body":"We only use ActiveSupport for a few core extensions that are easily\r\nswapped out for their slightly-less-readable alternatives. There is also\r\na single instance of `class_attribute`, but that is easily implemented\r\nas a mixin (included, tested)\r\n\r\nSigned-off-by: David Celis <me@davidcel.is>","created_at":"2014-10-01T18:32:10Z","updated_at":"2014-10-01T20:53:19Z","closed_at":"2014-10-01T20:27:36Z","merged_at":"2014-10-01T20:27:36Z","merge_commit_sha":"dea0147a544145d9df1f01ccee283c29ad36faa5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/digitalocean/resource_kit/pulls/10/commits","review_comments_url":"https://api.github.com/repos/digitalocean/resource_kit/pulls/10/comments","review_comment_url":"https://api.github.com/repos/digitalocean/resource_kit/pulls/comments/{number}","comments_url":"https://api.github.com/repos/digitalocean/resource_kit/issues/10/comments","statuses_url":"https://api.github.com/repos/digitalocean/resource_kit/statuses/28685e4717b70d7c50e64cf92b3d8e3b45ca5b79","head":{"label":"davidcelis:remove-activesupport","ref":"remove-activesupport","sha":"28685e4717b70d7c50e64cf92b3d8e3b45ca5b79","user":{"login":"davidcelis","id":36873,"avatar_url":"https://avatars.githubusercontent.com/u/36873?v=2","gravatar_id":"","url":"https://api.github.com/users/davidcelis","html_url":"https://github.com/davidcelis","followers_url":"https://api.github.com/users/davidcelis/followers","following_url":"https://api.github.com/users/davidcelis/following{/other_user}","gists_url":"https://api.github.com/users/davidcelis/gists{/gist_id}","starred_url":"https://api.github.com/users/davidcelis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidcelis/subscriptions","organizations_url":"https://api.github.com/users/davidcelis/orgs","repos_url":"https://api.github.com/users/davidcelis/repos","events_url":"https://api.github.com/users/davidcelis/events{/privacy}","received_events_url":"https://api.github.com/users/davidcelis/received_events","type":"User","site_admin":false},"repo":{"id":24686639,"name":"resource_kit","full_name":"davidcelis/resource_kit","owner":{"login":"davidcelis","id":36873,"avatar_url":"https://avatars.githubusercontent.com/u/36873?v=2","gravatar_id":"","url":"https://api.github.com/users/davidcelis","html_url":"https://github.com/davidcelis","followers_url":"https://api.github.com/users/davidcelis/followers","following_url":"https://api.github.com/users/davidcelis/following{/other_user}","gists_url":"https://api.github.com/users/davidcelis/gists{/gist_id}","starred_url":"https://api.github.com/users/davidcelis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidcelis/subscriptions","organizations_url":"https://api.github.com/users/davidcelis/orgs","repos_url":"https://api.github.com/users/davidcelis/repos","events_url":"https://api.github.com/users/davidcelis/events{/privacy}","received_events_url":"https://api.github.com/users/davidcelis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davidcelis/resource_kit","description":"Resource Kit provides tools to aid in making API Clients. Such as URL resolving, Request / Response layer, and more.","fork":true,"url":"https://api.github.com/repos/davidcelis/resource_kit","forks_url":"https://api.github.com/repos/davidcelis/resource_kit/forks","keys_url":"https://api.github.com/repos/davidcelis/resource_kit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidcelis/resource_kit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidcelis/resource_kit/teams","hooks_url":"https://api.github.com/repos/davidcelis/resource_kit/hooks","issue_events_url":"https://api.github.com/repos/davidcelis/resource_kit/issues/events{/number}","events_url":"https://api.github.com/repos/davidcelis/resource_kit/events","assignees_url":"https://api.github.com/repos/davidcelis/resource_kit/assignees{/user}","branches_url":"https://api.github.com/repos/davidcelis/resource_kit/branches{/branch}","tags_url":"https://api.github.com/repos/davidcelis/resource_kit/tags","blobs_url":"https://api.github.com/repos/davidcelis/resource_kit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidcelis/resource_kit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidcelis/resource_kit/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidcelis/resource_kit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidcelis/resource_kit/statuses/{sha}","languages_url":"https://api.github.com/repos/davidcelis/resource_kit/languages","stargazers_url":"https://api.github.com/repos/davidcelis/resource_kit/stargazers","contributors_url":"https://api.github.com/repos/davidcelis/resource_kit/contributors","subscribers_url":"https://api.github.com/repos/davidcelis/resource_kit/subscribers","subscription_url":"https://api.github.com/repos/davidcelis/resource_kit/subscription","commits_url":"https://api.github.com/repos/davidcelis/resource_kit/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidcelis/resource_kit/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidcelis/resource_kit/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidcelis/resource_kit/issues/comments/{number}","contents_url":"https://api.github.com/repos/davidcelis/resource_kit/contents/{+path}","compare_url":"https://api.github.com/repos/davidcelis/resource_kit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidcelis/resource_kit/merges","archive_url":"https://api.github.com/repos/davidcelis/resource_kit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidcelis/resource_kit/downloads","issues_url":"https://api.github.com/repos/davidcelis/resource_kit/issues{/number}","pulls_url":"https://api.github.com/repos/davidcelis/resource_kit/pulls{/number}","milestones_url":"https://api.github.com/repos/davidcelis/resource_kit/milestones{/number}","notifications_url":"https://api.github.com/repos/davidcelis/resource_kit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidcelis/resource_kit/labels{/name}","releases_url":"https://api.github.com/repos/davidcelis/resource_kit/releases{/id}","created_at":"2014-10-01T16:53:47Z","updated_at":"2014-09-27T07:40:05Z","pushed_at":"2014-10-01T18:32:09Z","git_url":"git://github.com/davidcelis/resource_kit.git","ssh_url":"git@github.com:davidcelis/resource_kit.git","clone_url":"https://github.com/davidcelis/resource_kit.git","svn_url":"https://github.com/davidcelis/resource_kit","homepage":"https://github.com/digitaloceancloud/resource_kit","size":341,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"digitalocean:master","ref":"master","sha":"8530605a377806733098a49ed85140422ebeb7e3","user":{"login":"digitalocean","id":4650108,"avatar_url":"https://avatars.githubusercontent.com/u/4650108?v=2","gravatar_id":"","url":"https://api.github.com/users/digitalocean","html_url":"https://github.com/digitalocean","followers_url":"https://api.github.com/users/digitalocean/followers","following_url":"https://api.github.com/users/digitalocean/following{/other_user}","gists_url":"https://api.github.com/users/digitalocean/gists{/gist_id}","starred_url":"https://api.github.com/users/digitalocean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digitalocean/subscriptions","organizations_url":"https://api.github.com/users/digitalocean/orgs","repos_url":"https://api.github.com/users/digitalocean/repos","events_url":"https://api.github.com/users/digitalocean/events{/privacy}","received_events_url":"https://api.github.com/users/digitalocean/received_events","type":"Organization","site_admin":false},"repo":{"id":22613761,"name":"resource_kit","full_name":"digitalocean/resource_kit","owner":{"login":"digitalocean","id":4650108,"avatar_url":"https://avatars.githubusercontent.com/u/4650108?v=2","gravatar_id":"","url":"https://api.github.com/users/digitalocean","html_url":"https://github.com/digitalocean","followers_url":"https://api.github.com/users/digitalocean/followers","following_url":"https://api.github.com/users/digitalocean/following{/other_user}","gists_url":"https://api.github.com/users/digitalocean/gists{/gist_id}","starred_url":"https://api.github.com/users/digitalocean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digitalocean/subscriptions","organizations_url":"https://api.github.com/users/digitalocean/orgs","repos_url":"https://api.github.com/users/digitalocean/repos","events_url":"https://api.github.com/users/digitalocean/events{/privacy}","received_events_url":"https://api.github.com/users/digitalocean/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/digitalocean/resource_kit","description":"Resource Kit provides tools to aid in making API Clients. Such as URL resolving, Request / Response layer, and more.","fork":false,"url":"https://api.github.com/repos/digitalocean/resource_kit","forks_url":"https://api.github.com/repos/digitalocean/resource_kit/forks","keys_url":"https://api.github.com/repos/digitalocean/resource_kit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/digitalocean/resource_kit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/digitalocean/resource_kit/teams","hooks_url":"https://api.github.com/repos/digitalocean/resource_kit/hooks","issue_events_url":"https://api.github.com/repos/digitalocean/resource_kit/issues/events{/number}","events_url":"https://api.github.com/repos/digitalocean/resource_kit/events","assignees_url":"https://api.github.com/repos/digitalocean/resource_kit/assignees{/user}","branches_url":"https://api.github.com/repos/digitalocean/resource_kit/branches{/branch}","tags_url":"https://api.github.com/repos/digitalocean/resource_kit/tags","blobs_url":"https://api.github.com/repos/digitalocean/resource_kit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/digitalocean/resource_kit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/digitalocean/resource_kit/git/refs{/sha}","trees_url":"https://api.github.com/repos/digitalocean/resource_kit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/digitalocean/resource_kit/statuses/{sha}","languages_url":"https://api.github.com/repos/digitalocean/resource_kit/languages","stargazers_url":"https://api.github.com/repos/digitalocean/resource_kit/stargazers","contributors_url":"https://api.github.com/repos/digitalocean/resource_kit/contributors","subscribers_url":"https://api.github.com/repos/digitalocean/resource_kit/subscribers","subscription_url":"https://api.github.com/repos/digitalocean/resource_kit/subscription","commits_url":"https://api.github.com/repos/digitalocean/resource_kit/commits{/sha}","git_commits_url":"https://api.github.com/repos/digitalocean/resource_kit/git/commits{/sha}","comments_url":"https://api.github.com/repos/digitalocean/resource_kit/comments{/number}","issue_comment_url":"https://api.github.com/repos/digitalocean/resource_kit/issues/comments/{number}","contents_url":"https://api.github.com/repos/digitalocean/resource_kit/contents/{+path}","compare_url":"https://api.github.com/repos/digitalocean/resource_kit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/digitalocean/resource_kit/merges","archive_url":"https://api.github.com/repos/digitalocean/resource_kit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/digitalocean/resource_kit/downloads","issues_url":"https://api.github.com/repos/digitalocean/resource_kit/issues{/number}","pulls_url":"https://api.github.com/repos/digitalocean/resource_kit/pulls{/number}","milestones_url":"https://api.github.com/repos/digitalocean/resource_kit/milestones{/number}","notifications_url":"https://api.github.com/repos/digitalocean/resource_kit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/digitalocean/resource_kit/labels{/name}","releases_url":"https://api.github.com/repos/digitalocean/resource_kit/releases{/id}","created_at":"2014-08-04T17:44:51Z","updated_at":"2014-09-27T07:40:05Z","pushed_at":"2014-10-01T20:27:53Z","git_url":"git://github.com/digitalocean/resource_kit.git","ssh_url":"git@github.com:digitalocean/resource_kit.git","clone_url":"https://github.com/digitalocean/resource_kit.git","svn_url":"https://github.com/digitalocean/resource_kit","homepage":"https://github.com/digitaloceancloud/resource_kit","size":341,"stargazers_count":70,"watchers_count":70,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":70,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/digitalocean/resource_kit/pulls/10"},"html":{"href":"https://github.com/digitalocean/resource_kit/pull/10"},"issue":{"href":"https://api.github.com/repos/digitalocean/resource_kit/issues/10"},"comments":{"href":"https://api.github.com/repos/digitalocean/resource_kit/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/digitalocean/resource_kit/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/digitalocean/resource_kit/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/digitalocean/resource_kit/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/digitalocean/resource_kit/statuses/28685e4717b70d7c50e64cf92b3d8e3b45ca5b79"}}}}