GitHub PullRequestReviewCommentEvent at 2014-03-11 15:18:39
Repository: buildout.recipe.uwsgi
Actor: lcosmin
Payload: {"comment":{"url":"https://api.github.com/repos/lcosmin/buildout.recipe.uwsgi/pulls/comments/10477760","id":10477760,"diff_hunk":"@@ -106,14 +106,16 @@ def build_uwsgi(self, uwsgi_path):\n \n         # Change dir to uwsgi_path for compile.\n         os.chdir(uwsgi_path)\n+        build_stdout = tempfile.TemporaryFile()\n         try:\n             # Build uWSGI. We don't use the Makefile, since it uses an\n             # override variable (with :=) we cannot specify the\n             # Python interpreter we want to use.\n-            subprocess.check_output([self.options.get('executable', sys.executable),\n-                                    os.path.join(uwsgi_path, 'uwsgiconfig.py'),\n-                                    '--build',\n-                                    profile])\n+            subprocess.check_call([self.options.get('executable', sys.executable),\n+                                   os.path.join(uwsgi_path, 'uwsgiconfig.py'),\n+                                   '--build',\n+                                   profile],\n+                                  stdout=build_stdout)","path":"buildout/recipe/uwsgi.py","position":17,"original_position":17,"commit_id":"6aeaffd678487485d85e09f281ca51a614276adb","original_commit_id":"6aeaffd678487485d85e09f281ca51a614276adb","user":{"login":"lcosmin","id":1164572,"avatar_url":"https://gravatar.com/avatar/0a8e69733ea25111666ecf580096338a?d=https%3A%2F%2Fidenticons.github.com%2Fea44fe7d21b69fedde8786c125661e6d.png&r=x","gravatar_id":"0a8e69733ea25111666ecf580096338a","url":"https://api.github.com/users/lcosmin","html_url":"https://github.com/lcosmin","followers_url":"https://api.github.com/users/lcosmin/followers","following_url":"https://api.github.com/users/lcosmin/following{/other_user}","gists_url":"https://api.github.com/users/lcosmin/gists{/gist_id}","starred_url":"https://api.github.com/users/lcosmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lcosmin/subscriptions","organizations_url":"https://api.github.com/users/lcosmin/orgs","repos_url":"https://api.github.com/users/lcosmin/repos","events_url":"https://api.github.com/users/lcosmin/events{/privacy}","received_events_url":"https://api.github.com/users/lcosmin/received_events","type":"User","site_admin":false},"body":"No, it's ok like this. It didn't occur to me at first that if you don't capture stdout it will go to...well, stdout. :smile: ","created_at":"2014-03-11T15:18:39Z","updated_at":"2014-03-11T15:18:39Z","html_url":"https://github.com/lcosmin/buildout.recipe.uwsgi/pull/16#discussion_r10477760","pull_request_url":"https://api.github.com/repos/lcosmin/buildout.recipe.uwsgi/pulls/16","_links":{"self":{"href":"https://api.github.com/repos/lcosmin/buildout.recipe.uwsgi/pulls/comments/10477760"},"html":{"href":"https://github.com/lcosmin/buildout.recipe.uwsgi/pull/16#discussion_r10477760"},"pull_request":{"href":"https://api.github.com/repos/lcosmin/buildout.recipe.uwsgi/pulls/16"}}}}