GitHub PullRequestReviewCommentEvent at 2014-03-06 14:04:00
Repository: openlayers
Actor: sbrunner
Payload: {"comment":{"url":"https://api.github.com/repos/openlayers/openlayers/pulls/comments/10342678","id":10342678,"diff_hunk":"@@ -416,6 +416,10 @@ OpenLayers.Layer.WMTS = OpenLayers.Class(OpenLayers.Layer.Grid, {\n             var info = this.getTileInfo(center);\n             var matrixId = this.matrix.identifier;\n             var dimensions = this.dimensions, params;\n+            //prevent the request of negative tiles or those that exceed the given matrixWidth/matrixHeight\n+            if (info.row < 0 || info.col < 0 || info.row > matrixSet.matrixWidth || info.col > matrixSet.matrixHeight){\n+                return url","path":"lib/OpenLayers/Layer/WMTS.js","position":6,"original_position":6,"commit_id":"24fc3932f1e513598d4a58f72271ebfc1efa46bf","original_commit_id":"24fc3932f1e513598d4a58f72271ebfc1efa46bf","user":{"login":"sbrunner","id":353872,"avatar_url":"https://gravatar.com/avatar/357d0f4feb67f5d6595e3d00fa10bbe3?d=https%3A%2F%2Fidenticons.github.com%2F95dd030a61c5ecccb3b7caa89b6328df.png&r=x","gravatar_id":"357d0f4feb67f5d6595e3d00fa10bbe3","url":"https://api.github.com/users/sbrunner","html_url":"https://github.com/sbrunner","followers_url":"https://api.github.com/users/sbrunner/followers","following_url":"https://api.github.com/users/sbrunner/following{/other_user}","gists_url":"https://api.github.com/users/sbrunner/gists{/gist_id}","starred_url":"https://api.github.com/users/sbrunner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbrunner/subscriptions","organizations_url":"https://api.github.com/users/sbrunner/orgs","repos_url":"https://api.github.com/users/sbrunner/repos","events_url":"https://api.github.com/users/sbrunner/events{/privacy}","received_events_url":"https://api.github.com/users/sbrunner/received_events","type":"User","site_admin":false},"body":"Why don't directly return `null` ? I think that will be clearer...","created_at":"2014-03-06T14:04:00Z","updated_at":"2014-03-06T14:04:00Z","html_url":"https://github.com/openlayers/openlayers/pull/1268#discussion_r10342678","pull_request_url":"https://api.github.com/repos/openlayers/openlayers/pulls/1268","_links":{"self":{"href":"https://api.github.com/repos/openlayers/openlayers/pulls/comments/10342678"},"html":{"href":"https://github.com/openlayers/openlayers/pull/1268#discussion_r10342678"},"pull_request":{"href":"https://api.github.com/repos/openlayers/openlayers/pulls/1268"}}}}