GitHub PullRequestReviewCommentEvent at 2014-03-26 13:51:46
Repository: crate
Actor: dobe
Payload: {"comment":{"url":"https://api.github.com/repos/crate/crate/pulls/comments/10976533","id":10976533,"diff_hunk":"@@ -196,6 +195,32 @@ public Context process(TableInfo table, Function whereClause) {\n     }\n \n     @Override\n+    public Void visitReference(Reference reference, Context context) {\n+        String columnName = reference.info().ident().columnIdent().name();\n+        if (!reference.info().ident().tableIdent().equals(context.table.ident())) {\n+            return invalidate(context);\n+        }\n+\n+        // where booleanCol; can be handled like: where booleanCol = true;\n+        if (reference.valueType() == DataType.BOOLEAN) {\n+            boolean clusteredBySet = false;\n+            if (columnName.equals(context.table.clusteredBy())) {\n+                setClusterBy(context, BooleanLiteral.TRUE);\n+                clusteredBySet = true;\n+            }\n+            int idx = context.table.primaryKey().indexOf(columnName);\n+            if (idx < 0 && !clusteredBySet) {\n+                // do not return here, as we might be searching for version","path":"sql/src/main/java/io/crate/analyze/PrimaryKeyVisitor.java","position":33,"original_position":33,"commit_id":"94ef5a4bb440f49d278f0b9f67290d79644ea2b0","original_commit_id":"94ef5a4bb440f49d278f0b9f67290d79644ea2b0","user":{"login":"dobe","id":48020,"avatar_url":"https://avatars.githubusercontent.com/u/48020?","gravatar_id":"8c4c0f6e2a311eb34d48174df24ec6f2","url":"https://api.github.com/users/dobe","html_url":"https://github.com/dobe","followers_url":"https://api.github.com/users/dobe/followers","following_url":"https://api.github.com/users/dobe/following{/other_user}","gists_url":"https://api.github.com/users/dobe/gists{/gist_id}","starred_url":"https://api.github.com/users/dobe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dobe/subscriptions","organizations_url":"https://api.github.com/users/dobe/orgs","repos_url":"https://api.github.com/users/dobe/repos","events_url":"https://api.github.com/users/dobe/events{/privacy}","received_events_url":"https://api.github.com/users/dobe/received_events","type":"User","site_admin":false},"body":"version is not a boolean","created_at":"2014-03-26T13:51:46Z","updated_at":"2014-03-26T13:51:46Z","html_url":"https://github.com/crate/crate/pull/619#discussion_r10976533","pull_request_url":"https://api.github.com/repos/crate/crate/pulls/619","_links":{"self":{"href":"https://api.github.com/repos/crate/crate/pulls/comments/10976533"},"html":{"href":"https://github.com/crate/crate/pull/619#discussion_r10976533"},"pull_request":{"href":"https://api.github.com/repos/crate/crate/pulls/619"}}}}