GitHub PullRequestReviewCommentEvent at 2014-08-27 00:01:34
Repository: Behat
Actor: stof
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Behat/Behat/pulls/comments/16750982","id":16750982,"diff_hunk":"@@ -17,16 +17,16 @@\n use Symfony\\Component\\Console\\Output\\StreamOutput;\n \n /**\n- * Symfony2\\Console-based output printer.\n+ * Symfony2\\Console-based output printer for printing to streams.\n  *\n  * @author Konstantin Kudryashov <ever.zet@gmail.com>\n  */\n-class ConsoleOutputPrinter implements OutputPrinter\n+class StreamOutputPrinter implements OutputPrinter","path":"src/Behat/Testwork/Output/Printer/StreamOutputPrinter.php","position":10,"original_position":10,"commit_id":"b4ce3d2b7c3ff6d6c74501b006fd79b3ef2de2b0","original_commit_id":"b4ce3d2b7c3ff6d6c74501b006fd79b3ef2de2b0","user":{"login":"stof","id":439401,"avatar_url":"https://avatars.githubusercontent.com/u/439401?v=2","gravatar_id":"7894bbdf1c05b18a1444ad8c76c9d583","url":"https://api.github.com/users/stof","html_url":"https://github.com/stof","followers_url":"https://api.github.com/users/stof/followers","following_url":"https://api.github.com/users/stof/following{/other_user}","gists_url":"https://api.github.com/users/stof/gists{/gist_id}","starred_url":"https://api.github.com/users/stof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stof/subscriptions","organizations_url":"https://api.github.com/users/stof/orgs","repos_url":"https://api.github.com/users/stof/repos","events_url":"https://api.github.com/users/stof/events{/privacy}","received_events_url":"https://api.github.com/users/stof/received_events","type":"User","site_admin":false},"body":"renaming the class is a BC break. It is not worth it IMO","created_at":"2014-08-27T00:01:34Z","updated_at":"2014-08-27T00:01:34Z","html_url":"https://github.com/Behat/Behat/pull/618#discussion_r16750982","pull_request_url":"https://api.github.com/repos/Behat/Behat/pulls/618","_links":{"self":{"href":"https://api.github.com/repos/Behat/Behat/pulls/comments/16750982"},"html":{"href":"https://github.com/Behat/Behat/pull/618#discussion_r16750982"},"pull_request":{"href":"https://api.github.com/repos/Behat/Behat/pulls/618"}}},"pull_request":{"url":"https://api.github.com/repos/Behat/Behat/pulls/618","id":20297720,"html_url":"https://github.com/Behat/Behat/pull/618","diff_url":"https://github.com/Behat/Behat/pull/618.diff","patch_url":"https://github.com/Behat/Behat/pull/618.patch","issue_url":"https://api.github.com/repos/Behat/Behat/issues/618","number":618,"state":"open","locked":false,"title":"Formatter JUnit","user":{"login":"james75","id":975619,"avatar_url":"https://avatars.githubusercontent.com/u/975619?v=2","gravatar_id":"9fa75a6d620c3e9f7fd7e0d27aade0a4","url":"https://api.github.com/users/james75","html_url":"https://github.com/james75","followers_url":"https://api.github.com/users/james75/followers","following_url":"https://api.github.com/users/james75/following{/other_user}","gists_url":"https://api.github.com/users/james75/gists{/gist_id}","starred_url":"https://api.github.com/users/james75/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/james75/subscriptions","organizations_url":"https://api.github.com/users/james75/orgs","repos_url":"https://api.github.com/users/james75/repos","events_url":"https://api.github.com/users/james75/events{/privacy}","received_events_url":"https://api.github.com/users/james75/received_events","type":"User","site_admin":false},"body":"The work on this Junit formatter at https://github.com/Behat/Behat/pull/527 seems to have stalled. I have take what was done by WouterJ done a refactor on the xml creation and completed the work. I have also brought the base inline with master so it can be merged.","created_at":"2014-08-26T09:43:56Z","updated_at":"2014-08-27T00:01:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f1f9f8e34baf3361ffdf59588ffe7e551385c58f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Behat/Behat/pulls/618/commits","review_comments_url":"https://api.github.com/repos/Behat/Behat/pulls/618/comments","review_comment_url":"https://api.github.com/repos/Behat/Behat/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Behat/Behat/issues/618/comments","statuses_url":"https://api.github.com/repos/Behat/Behat/statuses/b4ce3d2b7c3ff6d6c74501b006fd79b3ef2de2b0","head":{"label":"james75:formatter_junit_1","ref":"formatter_junit_1","sha":"b4ce3d2b7c3ff6d6c74501b006fd79b3ef2de2b0","user":{"login":"james75","id":975619,"avatar_url":"https://avatars.githubusercontent.com/u/975619?v=2","gravatar_id":"9fa75a6d620c3e9f7fd7e0d27aade0a4","url":"https://api.github.com/users/james75","html_url":"https://github.com/james75","followers_url":"https://api.github.com/users/james75/followers","following_url":"https://api.github.com/users/james75/following{/other_user}","gists_url":"https://api.github.com/users/james75/gists{/gist_id}","starred_url":"https://api.github.com/users/james75/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/james75/subscriptions","organizations_url":"https://api.github.com/users/james75/orgs","repos_url":"https://api.github.com/users/james75/repos","events_url":"https://api.github.com/users/james75/events{/privacy}","received_events_url":"https://api.github.com/users/james75/received_events","type":"User","site_admin":false},"repo":{"id":19528670,"name":"Behat","full_name":"james75/Behat","owner":{"login":"james75","id":975619,"avatar_url":"https://avatars.githubusercontent.com/u/975619?v=2","gravatar_id":"9fa75a6d620c3e9f7fd7e0d27aade0a4","url":"https://api.github.com/users/james75","html_url":"https://github.com/james75","followers_url":"https://api.github.com/users/james75/followers","following_url":"https://api.github.com/users/james75/following{/other_user}","gists_url":"https://api.github.com/users/james75/gists{/gist_id}","starred_url":"https://api.github.com/users/james75/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/james75/subscriptions","organizations_url":"https://api.github.com/users/james75/orgs","repos_url":"https://api.github.com/users/james75/repos","events_url":"https://api.github.com/users/james75/events{/privacy}","received_events_url":"https://api.github.com/users/james75/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/james75/Behat","description":"BDD framework for PHP 5.3+","fork":true,"url":"https://api.github.com/repos/james75/Behat","forks_url":"https://api.github.com/repos/james75/Behat/forks","keys_url":"https://api.github.com/repos/james75/Behat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/james75/Behat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/james75/Behat/teams","hooks_url":"https://api.github.com/repos/james75/Behat/hooks","issue_events_url":"https://api.github.com/repos/james75/Behat/issues/events{/number}","events_url":"https://api.github.com/repos/james75/Behat/events","assignees_url":"https://api.github.com/repos/james75/Behat/assignees{/user}","branches_url":"https://api.github.com/repos/james75/Behat/branches{/branch}","tags_url":"https://api.github.com/repos/james75/Behat/tags","blobs_url":"https://api.github.com/repos/james75/Behat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/james75/Behat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/james75/Behat/git/refs{/sha}","trees_url":"https://api.github.com/repos/james75/Behat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/james75/Behat/statuses/{sha}","languages_url":"https://api.github.com/repos/james75/Behat/languages","stargazers_url":"https://api.github.com/repos/james75/Behat/stargazers","contributors_url":"https://api.github.com/repos/james75/Behat/contributors","subscribers_url":"https://api.github.com/repos/james75/Behat/subscribers","subscription_url":"https://api.github.com/repos/james75/Behat/subscription","commits_url":"https://api.github.com/repos/james75/Behat/commits{/sha}","git_commits_url":"https://api.github.com/repos/james75/Behat/git/commits{/sha}","comments_url":"https://api.github.com/repos/james75/Behat/comments{/number}","issue_comment_url":"https://api.github.com/repos/james75/Behat/issues/comments/{number}","contents_url":"https://api.github.com/repos/james75/Behat/contents/{+path}","compare_url":"https://api.github.com/repos/james75/Behat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/james75/Behat/merges","archive_url":"https://api.github.com/repos/james75/Behat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/james75/Behat/downloads","issues_url":"https://api.github.com/repos/james75/Behat/issues{/number}","pulls_url":"https://api.github.com/repos/james75/Behat/pulls{/number}","milestones_url":"https://api.github.com/repos/james75/Behat/milestones{/number}","notifications_url":"https://api.github.com/repos/james75/Behat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/james75/Behat/labels{/name}","releases_url":"https://api.github.com/repos/james75/Behat/releases{/id}","created_at":"2014-05-07T09:30:19Z","updated_at":"2014-07-23T15:34:04Z","pushed_at":"2014-08-26T17:27:11Z","git_url":"git://github.com/james75/Behat.git","ssh_url":"git@github.com:james75/Behat.git","clone_url":"https://github.com/james75/Behat.git","svn_url":"https://github.com/james75/Behat","homepage":"http://behat.org","size":5313,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Behat:master","ref":"master","sha":"860860d4b997bc8121aba470f1cb13a1500586ee","user":{"login":"Behat","id":547869,"avatar_url":"https://avatars.githubusercontent.com/u/547869?v=2","gravatar_id":"19bcb18e3b02d994c5c2fad3198fe537","url":"https://api.github.com/users/Behat","html_url":"https://github.com/Behat","followers_url":"https://api.github.com/users/Behat/followers","following_url":"https://api.github.com/users/Behat/following{/other_user}","gists_url":"https://api.github.com/users/Behat/gists{/gist_id}","starred_url":"https://api.github.com/users/Behat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Behat/subscriptions","organizations_url":"https://api.github.com/users/Behat/orgs","repos_url":"https://api.github.com/users/Behat/repos","events_url":"https://api.github.com/users/Behat/events{/privacy}","received_events_url":"https://api.github.com/users/Behat/received_events","type":"Organization","site_admin":false},"repo":{"id":1367484,"name":"Behat","full_name":"Behat/Behat","owner":{"login":"Behat","id":547869,"avatar_url":"https://avatars.githubusercontent.com/u/547869?v=2","gravatar_id":"19bcb18e3b02d994c5c2fad3198fe537","url":"https://api.github.com/users/Behat","html_url":"https://github.com/Behat","followers_url":"https://api.github.com/users/Behat/followers","following_url":"https://api.github.com/users/Behat/following{/other_user}","gists_url":"https://api.github.com/users/Behat/gists{/gist_id}","starred_url":"https://api.github.com/users/Behat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Behat/subscriptions","organizations_url":"https://api.github.com/users/Behat/orgs","repos_url":"https://api.github.com/users/Behat/repos","events_url":"https://api.github.com/users/Behat/events{/privacy}","received_events_url":"https://api.github.com/users/Behat/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Behat/Behat","description":"BDD framework for PHP 5.3+","fork":false,"url":"https://api.github.com/repos/Behat/Behat","forks_url":"https://api.github.com/repos/Behat/Behat/forks","keys_url":"https://api.github.com/repos/Behat/Behat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Behat/Behat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Behat/Behat/teams","hooks_url":"https://api.github.com/repos/Behat/Behat/hooks","issue_events_url":"https://api.github.com/repos/Behat/Behat/issues/events{/number}","events_url":"https://api.github.com/repos/Behat/Behat/events","assignees_url":"https://api.github.com/repos/Behat/Behat/assignees{/user}","branches_url":"https://api.github.com/repos/Behat/Behat/branches{/branch}","tags_url":"https://api.github.com/repos/Behat/Behat/tags","blobs_url":"https://api.github.com/repos/Behat/Behat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Behat/Behat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Behat/Behat/git/refs{/sha}","trees_url":"https://api.github.com/repos/Behat/Behat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Behat/Behat/statuses/{sha}","languages_url":"https://api.github.com/repos/Behat/Behat/languages","stargazers_url":"https://api.github.com/repos/Behat/Behat/stargazers","contributors_url":"https://api.github.com/repos/Behat/Behat/contributors","subscribers_url":"https://api.github.com/repos/Behat/Behat/subscribers","subscription_url":"https://api.github.com/repos/Behat/Behat/subscription","commits_url":"https://api.github.com/repos/Behat/Behat/commits{/sha}","git_commits_url":"https://api.github.com/repos/Behat/Behat/git/commits{/sha}","comments_url":"https://api.github.com/repos/Behat/Behat/comments{/number}","issue_comment_url":"https://api.github.com/repos/Behat/Behat/issues/comments/{number}","contents_url":"https://api.github.com/repos/Behat/Behat/contents/{+path}","compare_url":"https://api.github.com/repos/Behat/Behat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Behat/Behat/merges","archive_url":"https://api.github.com/repos/Behat/Behat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Behat/Behat/downloads","issues_url":"https://api.github.com/repos/Behat/Behat/issues{/number}","pulls_url":"https://api.github.com/repos/Behat/Behat/pulls{/number}","milestones_url":"https://api.github.com/repos/Behat/Behat/milestones{/number}","notifications_url":"https://api.github.com/repos/Behat/Behat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Behat/Behat/labels{/name}","releases_url":"https://api.github.com/repos/Behat/Behat/releases{/id}","created_at":"2011-02-15T00:02:39Z","updated_at":"2014-08-26T00:27:01Z","pushed_at":"2014-08-21T16:20:09Z","git_url":"git://github.com/Behat/Behat.git","ssh_url":"git@github.com:Behat/Behat.git","clone_url":"https://github.com/Behat/Behat.git","svn_url":"https://github.com/Behat/Behat","homepage":"http://behat.org","size":10741,"stargazers_count":1136,"watchers_count":1136,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":242,"mirror_url":null,"open_issues_count":41,"forks":242,"open_issues":41,"watchers":1136,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Behat/Behat/pulls/618"},"html":{"href":"https://github.com/Behat/Behat/pull/618"},"issue":{"href":"https://api.github.com/repos/Behat/Behat/issues/618"},"comments":{"href":"https://api.github.com/repos/Behat/Behat/issues/618/comments"},"review_comments":{"href":"https://api.github.com/repos/Behat/Behat/pulls/618/comments"},"review_comment":{"href":"https://api.github.com/repos/Behat/Behat/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Behat/Behat/pulls/618/commits"},"statuses":{"href":"https://api.github.com/repos/Behat/Behat/statuses/b4ce3d2b7c3ff6d6c74501b006fd79b3ef2de2b0"}}}}