GitHub PullRequestReviewCommentEvent at 2014-06-09 11:34:25
Repository: MonoGame
Actor: darthdurden
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/flibitijibibo/MonoGame/pulls/comments/13536907","id":13536907,"diff_hunk":"@@ -334,27 +335,23 @@ int elementCount\n \t\t\t\t);\n \t\t\t}\n \n-\t\t\tOpenGLDevice.Instance.BindTexture(texture);\n-\n \t\t\tif (glFormat == (PixelFormat) All.CompressedTextureFormats)\n \t\t\t{\n \t\t\t\tthrow new NotImplementedException(\"GetData, CompressedTexture\");\n \t\t\t}\n-\t\t\telse if (rect == null)\n-\t\t\t{\n-\t\t\t\t// Just throw the whole texture into the user array.\n-\t\t\t\tGL.GetTexImage(\n-\t\t\t\t\tTextureTarget.Texture2D,\n-\t\t\t\t\t0,\n-\t\t\t\t\tglFormat,\n-\t\t\t\t\tglType,\n-\t\t\t\t\tdata\n-\t\t\t\t);\n-\t\t\t}\n-\t\t\telse\n+\n+\t\t\tif (!OpenGLDevice.Instance.ReadTargetIfApplicable(texture, level, data, rect))\n \t\t\t{\n+\t\t\t\tOpenGLDevice.Instance.BindTexture(texture);\n+\n+\t\t\t\t// Make sure our read buffer is the size of the texture\n+\t\t\t\tT[] texData = data;\n+\t\t\t\tif (rect != null)","path":"MonoGame.Framework/Graphics/Texture2D.cs","position":37,"original_position":37,"commit_id":"1edda0f713ce7a10454b915fbe75c0c60bd205e4","original_commit_id":"729ef4de0a0c12dd1399b1a9f4fc9008d177119d","user":{"login":"darthdurden","id":5131001,"avatar_url":"https://avatars.githubusercontent.com/u/5131001?","gravatar_id":"97719f22844fffa8860d74c21fd92dad","url":"https://api.github.com/users/darthdurden","html_url":"https://github.com/darthdurden","followers_url":"https://api.github.com/users/darthdurden/followers","following_url":"https://api.github.com/users/darthdurden/following{/other_user}","gists_url":"https://api.github.com/users/darthdurden/gists{/gist_id}","starred_url":"https://api.github.com/users/darthdurden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darthdurden/subscriptions","organizations_url":"https://api.github.com/users/darthdurden/orgs","repos_url":"https://api.github.com/users/darthdurden/repos","events_url":"https://api.github.com/users/darthdurden/events{/privacy}","received_events_url":"https://api.github.com/users/darthdurden/received_events","type":"User","site_admin":false},"body":"I hate multiple returns.  But for you I will make a sacrifice.","created_at":"2014-06-09T11:34:25Z","updated_at":"2014-06-09T11:34:25Z","html_url":"https://github.com/flibitijibibo/MonoGame/pull/237#discussion_r13536907","pull_request_url":"https://api.github.com/repos/flibitijibibo/MonoGame/pulls/237","_links":{"self":{"href":"https://api.github.com/repos/flibitijibibo/MonoGame/pulls/comments/13536907"},"html":{"href":"https://github.com/flibitijibibo/MonoGame/pull/237#discussion_r13536907"},"pull_request":{"href":"https://api.github.com/repos/flibitijibibo/MonoGame/pulls/237"}}},"pull_request":{"url":"https://api.github.com/repos/flibitijibibo/MonoGame/pulls/237","id":16766725,"html_url":"https://github.com/flibitijibibo/MonoGame/pull/237","diff_url":"https://github.com/flibitijibibo/MonoGame/pull/237.diff","patch_url":"https://github.com/flibitijibibo/MonoGame/pull/237.patch","issue_url":"https://api.github.com/repos/flibitijibibo/MonoGame/issues/237","number":237,"state":"open","title":"BlueLine Patches","user":{"login":"darthdurden","id":5131001,"avatar_url":"https://avatars.githubusercontent.com/u/5131001?","gravatar_id":"97719f22844fffa8860d74c21fd92dad","url":"https://api.github.com/users/darthdurden","html_url":"https://github.com/darthdurden","followers_url":"https://api.github.com/users/darthdurden/followers","following_url":"https://api.github.com/users/darthdurden/following{/other_user}","gists_url":"https://api.github.com/users/darthdurden/gists{/gist_id}","starred_url":"https://api.github.com/users/darthdurden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darthdurden/subscriptions","organizations_url":"https://api.github.com/users/darthdurden/orgs","repos_url":"https://api.github.com/users/darthdurden/repos","events_url":"https://api.github.com/users/darthdurden/events{/privacy}","received_events_url":"https://api.github.com/users/darthdurden/received_events","type":"User","site_admin":false},"body":"Alright, here are my changes to add a GL.ReadPixels on Texture2D when it it applicable","created_at":"2014-06-05T13:51:30Z","updated_at":"2014-06-09T11:34:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"61f294270f86027d3b4e0a9ca835f91b14dfd251","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/flibitijibibo/MonoGame/pulls/237/commits","review_comments_url":"https://api.github.com/repos/flibitijibibo/MonoGame/pulls/237/comments","review_comment_url":"https://api.github.com/repos/flibitijibibo/MonoGame/pulls/comments/{number}","comments_url":"https://api.github.com/repos/flibitijibibo/MonoGame/issues/237/comments","statuses_url":"https://api.github.com/repos/flibitijibibo/MonoGame/statuses/1edda0f713ce7a10454b915fbe75c0c60bd205e4","head":{"label":"SeanColombo:monogame-synctotrunk","ref":"monogame-synctotrunk","sha":"1edda0f713ce7a10454b915fbe75c0c60bd205e4","user":{"login":"SeanColombo","id":237336,"avatar_url":"https://avatars.githubusercontent.com/u/237336?","gravatar_id":"aeeba9b5af7e987195b94610b285a0d8","url":"https://api.github.com/users/SeanColombo","html_url":"https://github.com/SeanColombo","followers_url":"https://api.github.com/users/SeanColombo/followers","following_url":"https://api.github.com/users/SeanColombo/following{/other_user}","gists_url":"https://api.github.com/users/SeanColombo/gists{/gist_id}","starred_url":"https://api.github.com/users/SeanColombo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeanColombo/subscriptions","organizations_url":"https://api.github.com/users/SeanColombo/orgs","repos_url":"https://api.github.com/users/SeanColombo/repos","events_url":"https://api.github.com/users/SeanColombo/events{/privacy}","received_events_url":"https://api.github.com/users/SeanColombo/received_events","type":"User","site_admin":false},"repo":{"id":12745475,"name":"MonoGame","full_name":"SeanColombo/MonoGame","owner":{"login":"SeanColombo","id":237336,"avatar_url":"https://avatars.githubusercontent.com/u/237336?","gravatar_id":"aeeba9b5af7e987195b94610b285a0d8","url":"https://api.github.com/users/SeanColombo","html_url":"https://github.com/SeanColombo","followers_url":"https://api.github.com/users/SeanColombo/followers","following_url":"https://api.github.com/users/SeanColombo/following{/other_user}","gists_url":"https://api.github.com/users/SeanColombo/gists{/gist_id}","starred_url":"https://api.github.com/users/SeanColombo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeanColombo/subscriptions","organizations_url":"https://api.github.com/users/SeanColombo/orgs","repos_url":"https://api.github.com/users/SeanColombo/repos","events_url":"https://api.github.com/users/SeanColombo/events{/privacy}","received_events_url":"https://api.github.com/users/SeanColombo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SeanColombo/MonoGame","description":"XNA Implementation for Mono based platforms","fork":true,"url":"https://api.github.com/repos/SeanColombo/MonoGame","forks_url":"https://api.github.com/repos/SeanColombo/MonoGame/forks","keys_url":"https://api.github.com/repos/SeanColombo/MonoGame/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SeanColombo/MonoGame/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SeanColombo/MonoGame/teams","hooks_url":"https://api.github.com/repos/SeanColombo/MonoGame/hooks","issue_events_url":"https://api.github.com/repos/SeanColombo/MonoGame/issues/events{/number}","events_url":"https://api.github.com/repos/SeanColombo/MonoGame/events","assignees_url":"https://api.github.com/repos/SeanColombo/MonoGame/assignees{/user}","branches_url":"https://api.github.com/repos/SeanColombo/MonoGame/branches{/branch}","tags_url":"https://api.github.com/repos/SeanColombo/MonoGame/tags","blobs_url":"https://api.github.com/repos/SeanColombo/MonoGame/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SeanColombo/MonoGame/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SeanColombo/MonoGame/git/refs{/sha}","trees_url":"https://api.github.com/repos/SeanColombo/MonoGame/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SeanColombo/MonoGame/statuses/{sha}","languages_url":"https://api.github.com/repos/SeanColombo/MonoGame/languages","stargazers_url":"https://api.github.com/repos/SeanColombo/MonoGame/stargazers","contributors_url":"https://api.github.com/repos/SeanColombo/MonoGame/contributors","subscribers_url":"https://api.github.com/repos/SeanColombo/MonoGame/subscribers","subscription_url":"https://api.github.com/repos/SeanColombo/MonoGame/subscription","commits_url":"https://api.github.com/repos/SeanColombo/MonoGame/commits{/sha}","git_commits_url":"https://api.github.com/repos/SeanColombo/MonoGame/git/commits{/sha}","comments_url":"https://api.github.com/repos/SeanColombo/MonoGame/comments{/number}","issue_comment_url":"https://api.github.com/repos/SeanColombo/MonoGame/issues/comments/{number}","contents_url":"https://api.github.com/repos/SeanColombo/MonoGame/contents/{+path}","compare_url":"https://api.github.com/repos/SeanColombo/MonoGame/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SeanColombo/MonoGame/merges","archive_url":"https://api.github.com/repos/SeanColombo/MonoGame/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SeanColombo/MonoGame/downloads","issues_url":"https://api.github.com/repos/SeanColombo/MonoGame/issues{/number}","pulls_url":"https://api.github.com/repos/SeanColombo/MonoGame/pulls{/number}","milestones_url":"https://api.github.com/repos/SeanColombo/MonoGame/milestones{/number}","notifications_url":"https://api.github.com/repos/SeanColombo/MonoGame/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SeanColombo/MonoGame/labels{/name}","releases_url":"https://api.github.com/repos/SeanColombo/MonoGame/releases{/id}","created_at":"2013-09-11T02:13:58Z","updated_at":"2014-06-09T10:44:47Z","pushed_at":"2014-06-09T10:44:50Z","git_url":"git://github.com/SeanColombo/MonoGame.git","ssh_url":"git@github.com:SeanColombo/MonoGame.git","clone_url":"https://github.com/SeanColombo/MonoGame.git","svn_url":"https://github.com/SeanColombo/MonoGame","homepage":"http://monogame.codeplex.com","size":52349,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"monogame-sdl2"}},"base":{"label":"flibitijibibo:monogame-sdl2","ref":"monogame-sdl2","sha":"d4a959028be9d2b87a6af7400211b75727dce6fe","user":{"login":"flibitijibibo","id":1396814,"avatar_url":"https://avatars.githubusercontent.com/u/1396814?","gravatar_id":"f72913968167f06b4c9e2c765eb60afe","url":"https://api.github.com/users/flibitijibibo","html_url":"https://github.com/flibitijibibo","followers_url":"https://api.github.com/users/flibitijibibo/followers","following_url":"https://api.github.com/users/flibitijibibo/following{/other_user}","gists_url":"https://api.github.com/users/flibitijibibo/gists{/gist_id}","starred_url":"https://api.github.com/users/flibitijibibo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flibitijibibo/subscriptions","organizations_url":"https://api.github.com/users/flibitijibibo/orgs","repos_url":"https://api.github.com/users/flibitijibibo/repos","events_url":"https://api.github.com/users/flibitijibibo/events{/privacy}","received_events_url":"https://api.github.com/users/flibitijibibo/received_events","type":"User","site_admin":false},"repo":{"id":7511493,"name":"MonoGame","full_name":"flibitijibibo/MonoGame","owner":{"login":"flibitijibibo","id":1396814,"avatar_url":"https://avatars.githubusercontent.com/u/1396814?","gravatar_id":"f72913968167f06b4c9e2c765eb60afe","url":"https://api.github.com/users/flibitijibibo","html_url":"https://github.com/flibitijibibo","followers_url":"https://api.github.com/users/flibitijibibo/followers","following_url":"https://api.github.com/users/flibitijibibo/following{/other_user}","gists_url":"https://api.github.com/users/flibitijibibo/gists{/gist_id}","starred_url":"https://api.github.com/users/flibitijibibo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flibitijibibo/subscriptions","organizations_url":"https://api.github.com/users/flibitijibibo/orgs","repos_url":"https://api.github.com/users/flibitijibibo/repos","events_url":"https://api.github.com/users/flibitijibibo/events{/privacy}","received_events_url":"https://api.github.com/users/flibitijibibo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/flibitijibibo/MonoGame","description":"XNA4 reimplementation using SDL2, branched from MonoGame","fork":true,"url":"https://api.github.com/repos/flibitijibibo/MonoGame","forks_url":"https://api.github.com/repos/flibitijibibo/MonoGame/forks","keys_url":"https://api.github.com/repos/flibitijibibo/MonoGame/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flibitijibibo/MonoGame/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flibitijibibo/MonoGame/teams","hooks_url":"https://api.github.com/repos/flibitijibibo/MonoGame/hooks","issue_events_url":"https://api.github.com/repos/flibitijibibo/MonoGame/issues/events{/number}","events_url":"https://api.github.com/repos/flibitijibibo/MonoGame/events","assignees_url":"https://api.github.com/repos/flibitijibibo/MonoGame/assignees{/user}","branches_url":"https://api.github.com/repos/flibitijibibo/MonoGame/branches{/branch}","tags_url":"https://api.github.com/repos/flibitijibibo/MonoGame/tags","blobs_url":"https://api.github.com/repos/flibitijibibo/MonoGame/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flibitijibibo/MonoGame/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flibitijibibo/MonoGame/git/refs{/sha}","trees_url":"https://api.github.com/repos/flibitijibibo/MonoGame/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flibitijibibo/MonoGame/statuses/{sha}","languages_url":"https://api.github.com/repos/flibitijibibo/MonoGame/languages","stargazers_url":"https://api.github.com/repos/flibitijibibo/MonoGame/stargazers","contributors_url":"https://api.github.com/repos/flibitijibibo/MonoGame/contributors","subscribers_url":"https://api.github.com/repos/flibitijibibo/MonoGame/subscribers","subscription_url":"https://api.github.com/repos/flibitijibibo/MonoGame/subscription","commits_url":"https://api.github.com/repos/flibitijibibo/MonoGame/commits{/sha}","git_commits_url":"https://api.github.com/repos/flibitijibibo/MonoGame/git/commits{/sha}","comments_url":"https://api.github.com/repos/flibitijibibo/MonoGame/comments{/number}","issue_comment_url":"https://api.github.com/repos/flibitijibibo/MonoGame/issues/comments/{number}","contents_url":"https://api.github.com/repos/flibitijibibo/MonoGame/contents/{+path}","compare_url":"https://api.github.com/repos/flibitijibibo/MonoGame/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flibitijibibo/MonoGame/merges","archive_url":"https://api.github.com/repos/flibitijibibo/MonoGame/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flibitijibibo/MonoGame/downloads","issues_url":"https://api.github.com/repos/flibitijibibo/MonoGame/issues{/number}","pulls_url":"https://api.github.com/repos/flibitijibibo/MonoGame/pulls{/number}","milestones_url":"https://api.github.com/repos/flibitijibibo/MonoGame/milestones{/number}","notifications_url":"https://api.github.com/repos/flibitijibibo/MonoGame/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flibitijibibo/MonoGame/labels{/name}","releases_url":"https://api.github.com/repos/flibitijibibo/MonoGame/releases{/id}","created_at":"2013-01-08T23:40:24Z","updated_at":"2014-06-09T08:24:27Z","pushed_at":"2014-06-09T01:34:25Z","git_url":"git://github.com/flibitijibibo/MonoGame.git","ssh_url":"git@github.com:flibitijibibo/MonoGame.git","clone_url":"https://github.com/flibitijibibo/MonoGame.git","svn_url":"https://github.com/flibitijibibo/MonoGame","homepage":"http://www.flibitijibibo.com/","size":66823,"stargazers_count":103,"watchers_count":103,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":28,"mirror_url":null,"open_issues_count":7,"forks":28,"open_issues":7,"watchers":103,"default_branch":"monogame-sdl2"}},"_links":{"self":{"href":"https://api.github.com/repos/flibitijibibo/MonoGame/pulls/237"},"html":{"href":"https://github.com/flibitijibibo/MonoGame/pull/237"},"issue":{"href":"https://api.github.com/repos/flibitijibibo/MonoGame/issues/237"},"comments":{"href":"https://api.github.com/repos/flibitijibibo/MonoGame/issues/237/comments"},"review_comments":{"href":"https://api.github.com/repos/flibitijibibo/MonoGame/pulls/237/comments"},"review_comment":{"href":"https://api.github.com/repos/flibitijibibo/MonoGame/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/flibitijibibo/MonoGame/pulls/237/commits"},"statuses":{"href":"https://api.github.com/repos/flibitijibibo/MonoGame/statuses/1edda0f713ce7a10454b915fbe75c0c60bd205e4"}}}}