GitHub PullRequestReviewCommentEvent at 2014-12-05 16:40:23
Repository: charmstore
Actor: rogpeppe
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/juju/charmstore/pulls/comments/21382779","id":21382779,"diff_hunk":"@@ -58,30 +49,76 @@ var deprecatedSeries = map[string]bool{\n \t\"saucy\":   true,\n }\n \n-// put inserts an entity into elasticsearch if elasticsearch\n-// is configured. The entity with id r is extracted from mongodb\n-// and written into elasticsearch.\n-func (ses *storeElasticSearch) put(r *charm.Reference) error {\n-\tif ses == nil || ses.SearchIndex == nil {\n+// SearchDoc is a mongodoc.Entity with additional fields useful for searching.\n+// This is the document that is stored in the search index.\n+type SearchDoc struct {","path":"internal/charmstore/search.go","position":27,"original_position":27,"commit_id":"105ca941be5835eee4a40c3ba109fb6c7d680066","original_commit_id":"cd5a7247e0cca2d074a79a780de77618d9abf456","user":{"login":"rogpeppe","id":66491,"avatar_url":"https://avatars.githubusercontent.com/u/66491?v=3","gravatar_id":"","url":"https://api.github.com/users/rogpeppe","html_url":"https://github.com/rogpeppe","followers_url":"https://api.github.com/users/rogpeppe/followers","following_url":"https://api.github.com/users/rogpeppe/following{/other_user}","gists_url":"https://api.github.com/users/rogpeppe/gists{/gist_id}","starred_url":"https://api.github.com/users/rogpeppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rogpeppe/subscriptions","organizations_url":"https://api.github.com/users/rogpeppe/orgs","repos_url":"https://api.github.com/users/rogpeppe/repos","events_url":"https://api.github.com/users/rogpeppe/events{/privacy}","received_events_url":"https://api.github.com/users/rogpeppe/received_events","type":"User","site_admin":false},"body":"- [ ] tRsst\r\n- [x] Ted","created_at":"2014-12-05T16:40:23Z","updated_at":"2014-12-05T16:40:23Z","html_url":"https://github.com/juju/charmstore/pull/248#discussion_r21382779","pull_request_url":"https://api.github.com/repos/juju/charmstore/pulls/248","_links":{"self":{"href":"https://api.github.com/repos/juju/charmstore/pulls/comments/21382779"},"html":{"href":"https://github.com/juju/charmstore/pull/248#discussion_r21382779"},"pull_request":{"href":"https://api.github.com/repos/juju/charmstore/pulls/248"}}},"pull_request":{"url":"https://api.github.com/repos/juju/charmstore/pulls/248","id":25512877,"html_url":"https://github.com/juju/charmstore/pull/248","diff_url":"https://github.com/juju/charmstore/pull/248.diff","patch_url":"https://github.com/juju/charmstore/pull/248.patch","issue_url":"https://api.github.com/repos/juju/charmstore/issues/248","number":248,"state":"closed","locked":false,"title":"Add download counts into elasticsearch","user":{"login":"mhilton","id":1136018,"avatar_url":"https://avatars.githubusercontent.com/u/1136018?v=3","gravatar_id":"","url":"https://api.github.com/users/mhilton","html_url":"https://github.com/mhilton","followers_url":"https://api.github.com/users/mhilton/followers","following_url":"https://api.github.com/users/mhilton/following{/other_user}","gists_url":"https://api.github.com/users/mhilton/gists{/gist_id}","starred_url":"https://api.github.com/users/mhilton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhilton/subscriptions","organizations_url":"https://api.github.com/users/mhilton/orgs","repos_url":"https://api.github.com/users/mhilton/repos","events_url":"https://api.github.com/users/mhilton/events{/privacy}","received_events_url":"https://api.github.com/users/mhilton/received_events","type":"User","site_admin":false},"body":"Total download counts are now in elasticsearch. Along with some changes to the integration that made things simpler. It will be possible to implement sorting and boosting on download counts.","created_at":"2014-12-04T17:23:58Z","updated_at":"2014-12-05T16:40:23Z","closed_at":"2014-12-05T10:36:26Z","merged_at":"2014-12-05T10:36:26Z","merge_commit_sha":"104ecf3a1f9581ae2ae01035d5e921e4595f13f0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/juju/charmstore/pulls/248/commits","review_comments_url":"https://api.github.com/repos/juju/charmstore/pulls/248/comments","review_comment_url":"https://api.github.com/repos/juju/charmstore/pulls/comments/{number}","comments_url":"https://api.github.com/repos/juju/charmstore/issues/248/comments","statuses_url":"https://api.github.com/repos/juju/charmstore/statuses/105ca941be5835eee4a40c3ba109fb6c7d680066","head":{"label":"mhilton:download-count-in-search","ref":"download-count-in-search","sha":"105ca941be5835eee4a40c3ba109fb6c7d680066","user":{"login":"mhilton","id":1136018,"avatar_url":"https://avatars.githubusercontent.com/u/1136018?v=3","gravatar_id":"","url":"https://api.github.com/users/mhilton","html_url":"https://github.com/mhilton","followers_url":"https://api.github.com/users/mhilton/followers","following_url":"https://api.github.com/users/mhilton/following{/other_user}","gists_url":"https://api.github.com/users/mhilton/gists{/gist_id}","starred_url":"https://api.github.com/users/mhilton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhilton/subscriptions","organizations_url":"https://api.github.com/users/mhilton/orgs","repos_url":"https://api.github.com/users/mhilton/repos","events_url":"https://api.github.com/users/mhilton/events{/privacy}","received_events_url":"https://api.github.com/users/mhilton/received_events","type":"User","site_admin":false},"repo":{"id":24229515,"name":"charmstore","full_name":"mhilton/charmstore","owner":{"login":"mhilton","id":1136018,"avatar_url":"https://avatars.githubusercontent.com/u/1136018?v=3","gravatar_id":"","url":"https://api.github.com/users/mhilton","html_url":"https://github.com/mhilton","followers_url":"https://api.github.com/users/mhilton/followers","following_url":"https://api.github.com/users/mhilton/following{/other_user}","gists_url":"https://api.github.com/users/mhilton/gists{/gist_id}","starred_url":"https://api.github.com/users/mhilton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhilton/subscriptions","organizations_url":"https://api.github.com/users/mhilton/orgs","repos_url":"https://api.github.com/users/mhilton/repos","events_url":"https://api.github.com/users/mhilton/events{/privacy}","received_events_url":"https://api.github.com/users/mhilton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mhilton/charmstore","description":"The charm store server.","fork":true,"url":"https://api.github.com/repos/mhilton/charmstore","forks_url":"https://api.github.com/repos/mhilton/charmstore/forks","keys_url":"https://api.github.com/repos/mhilton/charmstore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mhilton/charmstore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mhilton/charmstore/teams","hooks_url":"https://api.github.com/repos/mhilton/charmstore/hooks","issue_events_url":"https://api.github.com/repos/mhilton/charmstore/issues/events{/number}","events_url":"https://api.github.com/repos/mhilton/charmstore/events","assignees_url":"https://api.github.com/repos/mhilton/charmstore/assignees{/user}","branches_url":"https://api.github.com/repos/mhilton/charmstore/branches{/branch}","tags_url":"https://api.github.com/repos/mhilton/charmstore/tags","blobs_url":"https://api.github.com/repos/mhilton/charmstore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mhilton/charmstore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mhilton/charmstore/git/refs{/sha}","trees_url":"https://api.github.com/repos/mhilton/charmstore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mhilton/charmstore/statuses/{sha}","languages_url":"https://api.github.com/repos/mhilton/charmstore/languages","stargazers_url":"https://api.github.com/repos/mhilton/charmstore/stargazers","contributors_url":"https://api.github.com/repos/mhilton/charmstore/contributors","subscribers_url":"https://api.github.com/repos/mhilton/charmstore/subscribers","subscription_url":"https://api.github.com/repos/mhilton/charmstore/subscription","commits_url":"https://api.github.com/repos/mhilton/charmstore/commits{/sha}","git_commits_url":"https://api.github.com/repos/mhilton/charmstore/git/commits{/sha}","comments_url":"https://api.github.com/repos/mhilton/charmstore/comments{/number}","issue_comment_url":"https://api.github.com/repos/mhilton/charmstore/issues/comments/{number}","contents_url":"https://api.github.com/repos/mhilton/charmstore/contents/{+path}","compare_url":"https://api.github.com/repos/mhilton/charmstore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mhilton/charmstore/merges","archive_url":"https://api.github.com/repos/mhilton/charmstore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mhilton/charmstore/downloads","issues_url":"https://api.github.com/repos/mhilton/charmstore/issues{/number}","pulls_url":"https://api.github.com/repos/mhilton/charmstore/pulls{/number}","milestones_url":"https://api.github.com/repos/mhilton/charmstore/milestones{/number}","notifications_url":"https://api.github.com/repos/mhilton/charmstore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mhilton/charmstore/labels{/name}","releases_url":"https://api.github.com/repos/mhilton/charmstore/releases{/id}","created_at":"2014-09-19T12:48:28Z","updated_at":"2014-12-04T08:41:31Z","pushed_at":"2014-12-05T14:58:37Z","git_url":"git://github.com/mhilton/charmstore.git","ssh_url":"git@github.com:mhilton/charmstore.git","clone_url":"https://github.com/mhilton/charmstore.git","svn_url":"https://github.com/mhilton/charmstore","homepage":null,"size":1596,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"v4"}},"base":{"label":"juju:v4","ref":"v4","sha":"c7cc529b4139ac2e0a75a1c4df59b3cad4a52aad","user":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=3","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"repo":{"id":20720417,"name":"charmstore","full_name":"juju/charmstore","owner":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=3","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju/charmstore","description":"The charm store server.","fork":false,"url":"https://api.github.com/repos/juju/charmstore","forks_url":"https://api.github.com/repos/juju/charmstore/forks","keys_url":"https://api.github.com/repos/juju/charmstore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju/charmstore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju/charmstore/teams","hooks_url":"https://api.github.com/repos/juju/charmstore/hooks","issue_events_url":"https://api.github.com/repos/juju/charmstore/issues/events{/number}","events_url":"https://api.github.com/repos/juju/charmstore/events","assignees_url":"https://api.github.com/repos/juju/charmstore/assignees{/user}","branches_url":"https://api.github.com/repos/juju/charmstore/branches{/branch}","tags_url":"https://api.github.com/repos/juju/charmstore/tags","blobs_url":"https://api.github.com/repos/juju/charmstore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju/charmstore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju/charmstore/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju/charmstore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju/charmstore/statuses/{sha}","languages_url":"https://api.github.com/repos/juju/charmstore/languages","stargazers_url":"https://api.github.com/repos/juju/charmstore/stargazers","contributors_url":"https://api.github.com/repos/juju/charmstore/contributors","subscribers_url":"https://api.github.com/repos/juju/charmstore/subscribers","subscription_url":"https://api.github.com/repos/juju/charmstore/subscription","commits_url":"https://api.github.com/repos/juju/charmstore/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju/charmstore/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju/charmstore/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju/charmstore/issues/comments/{number}","contents_url":"https://api.github.com/repos/juju/charmstore/contents/{+path}","compare_url":"https://api.github.com/repos/juju/charmstore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju/charmstore/merges","archive_url":"https://api.github.com/repos/juju/charmstore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju/charmstore/downloads","issues_url":"https://api.github.com/repos/juju/charmstore/issues{/number}","pulls_url":"https://api.github.com/repos/juju/charmstore/pulls{/number}","milestones_url":"https://api.github.com/repos/juju/charmstore/milestones{/number}","notifications_url":"https://api.github.com/repos/juju/charmstore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju/charmstore/labels{/name}","releases_url":"https://api.github.com/repos/juju/charmstore/releases{/id}","created_at":"2014-06-11T09:53:37Z","updated_at":"2014-12-05T15:39:05Z","pushed_at":"2014-12-05T15:39:04Z","git_url":"git://github.com/juju/charmstore.git","ssh_url":"git@github.com:juju/charmstore.git","clone_url":"https://github.com/juju/charmstore.git","svn_url":"https://github.com/juju/charmstore","homepage":null,"size":2513,"stargazers_count":3,"watchers_count":3,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":8,"forks":12,"open_issues":8,"watchers":3,"default_branch":"v4"}},"_links":{"self":{"href":"https://api.github.com/repos/juju/charmstore/pulls/248"},"html":{"href":"https://github.com/juju/charmstore/pull/248"},"issue":{"href":"https://api.github.com/repos/juju/charmstore/issues/248"},"comments":{"href":"https://api.github.com/repos/juju/charmstore/issues/248/comments"},"review_comments":{"href":"https://api.github.com/repos/juju/charmstore/pulls/248/comments"},"review_comment":{"href":"https://api.github.com/repos/juju/charmstore/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/juju/charmstore/pulls/248/commits"},"statuses":{"href":"https://api.github.com/repos/juju/charmstore/statuses/105ca941be5835eee4a40c3ba109fb6c7d680066"}}}}