GitHub PushEvent at 2014-09-17 10:36:45
Repository: hhvm
Actor: SiebelsTim
Payload: {"shas":[["ef4968b9dfd10e2018d0a95a383a94aa6dc977a7","363321912c8af25d1104fb33c2c64b848c097226@fb.com","migrate many callsites from Config::GetFoo to Config::Bind\n\nSummary: codemod -m --extensions cpp '([^ ]*)\\s*=\\s*Config::Get(Bool|String|Byte|UByte|Int16|UInt16|Int32|UInt32|Int64|UInt64)[(]ini,\\s*([^\\s]*),\\s*([^\\s]*)[)];' 'Config::Bind(\\1, ini, \\2, \\3);'\n\nand some manual rebasing to current behavior\n\nReviewed By: @ptarjan\n\nDifferential Revision: D1371389","Joel Marcey",false],["dfe661eb5a6b5de4fc699a034b7fed40904c59d7","1459d19acca8aa0d331ced91d7cdfdd61263a03a@fb.com","Add hhvm.pcre.jit ini flag to check build config\n\nSummary: Want the benchmark script to check this.\n\nReviewed By: @oyamauchi\n\nDifferential Revision: D1545388","Fred Emmott",false],["f6f9913b98dbb544c46c3a66d77dc0914bb3a3c5","1459d19acca8aa0d331ced91d7cdfdd61263a03a@fb.com","Add hhvm.build_type ini setting\n\nSummary: Also want the benchmark script to check this === release\n\nReviewed By: @JoelMarcey\n\nDifferential Revision: D1545461","Fred Emmott",false],["3e3433b01ab326795fb690de9f12ceafcdf3f0ff","dae244579ddac8f450b3e6096ebb59fe56692f7b@yahoo.de","Implement RegexIterator::INVERT_MATCH\n\nSummary: Closes https://github.com/facebook/hhvm/pull/3718\n\nReviewed By: @sgolemon\n\nDifferential Revision: D1547317","Tim Siebels",false],["67a3f2cb885115bc6772abd0742e899dc1b0e8ca","f7a3a5c0528e7657f3f7816faa0a5e2de16317f6@fb.com","Re-fix CMake jemalloc check\n\nSummary: Get rid of backslashes that nobody\nfully understands and add 0x to the version\nconstant, 'cause it's supposed to be hex.\n\nReviewed By: @fredemmott\n\nDifferential Revision: D1547859","Sara Golemon",false],["e6d26e254a8c1de2218a5b1c4476a3bc621350e5","1459d19acca8aa0d331ced91d7cdfdd61263a03a@fb.com","Improve siege flags\n\nReviewed By: @​aravind\n\nDifferential Revision: D1548017","Fred Emmott",false],["e7e66e8df85de902afdeb00ac195de7207ed9899","1459d19acca8aa0d331ced91d7cdfdd61263a03a@fb.com","Make benchmarking script check HHVM build is suitable\n\nSummary: ```\n[fredemmott@devbig076 ~/fbcode/hphp/test/frameworks/perf] hhvm perf.php --toys --hhvm=/data/fio/fbcode/_bin/hphp/hhvm/hhvm\nHHVM build is not suitable for benchmarking:\n  HHVM build type: Debug\n  Required: Release\nExisting due to invalid config. You can run anyway with --i-am-not-benchmarking, but the results will not be suitable for any kind of comparison.\n[fredemmott@devbig076 ~/fbcode/hphp/test/frameworks/perf] hhvm perf.php --toys --hhvm=/data/fio/fbcode/_bin/hphp/hhvm/hhvm --i-am-not-benchmarking\n\n***********************\n** 2014-09-09 21:40:42\n** Installing framework\n\n**********************\n** 2014-09-09 21:40:42\n** Starting Nginx\n```\n\nReviewed By: @JoelMarcey\n\nDifferential Revision: D1545572","Fred Emmott",false],["2b08158cdd43858fc8dd0862009e76e6f5304f16","f7a3a5c0528e7657f3f7816faa0a5e2de16317f6@fb.com","--wrap is specific to linux's gcc linker\n\nSummary: This broke the Mac OSX build.\n\nReviewed By: @JoelMarcey\n\nDifferential Revision: D1546684","Sara Golemon",false],["dfa8965472f5d3504c0a8b71a5ec43df90618979","8fe4eacdc8aaa79406accb1339d17293db96da99@fb.com","Fix race in user*Handler destruction\n\nSummary: Closes #3329\n\nReviewed By: @ptarjan\n\nDifferential Revision: D1546084","Paul Bissonnette",false],["037def2b94e85dfd8ec7856a4912382b1baeb039","1650efe4630bf7b93325107599da3e871b6859a7@fb.com","try not to use ThreadInfo::s_threadInfo before it is constructed\n\nSummary: I'm seeing lots of segfaults like:\n\n  0  HPHP::File::TranslatePathKeepRelative(HPHP::String const&) at hphp/runtime/base/file.cpp:62\n  1  _M_invoke at hphp/runtime/base/request-injection-data.cpp:144\n  2  std::_Function_handler<bool (folly::dynamic const&), void HPHP::IniSetting::Bind<std::basic_fbstring<char, std::char_traits<char>, std::allocator<char>, std::fbstring_core<char> > >(HPHP::Extension const*, HPHP::IniSetting::Mode, std::basic_fbstring<char, std::char_traits<char>, std::allocator<char>, std::fbstring_core<char> > const&, char const*, HPHP::IniSetting::SetAndGet<std::basic_fbstring<char, std::char_traits<char>, std::allocator<char>, std::fbstring_core<char> > >, std::basic_fbstring<char, std::char_traits<char>, std::allocator<char>, std::fbstring_core<char> >*)::{lambda(folly::dynamic const&) 1}>::_M_invoke(std::_Any_data const&, folly::dynamic const&) at third-party2/libgcc/4.8.1/gcc-4.8.1-glibc-2.17-fb/8aac7fc/include/c++/4.8.1/functional:2468\n  3  void HPHP::IniSetting::Bind<std::basic_fbstring<char, std::char_traits<char>, std::allocator<char>, std::fbstring_core<char> > >(HPHP::Extension const*, HPHP::IniSetting::Mode, std::basic_fbstring<char, std::char_traits<char>, std::allocator<char>, std::fbstring_core<char> > const&, char const*, HPHP::IniSetting::SetAndGet<std::basic_fbstring<char, std::char_traits<char>, std::allocator<char>, std::fbstring_core<char> > >, std::basic_fbstring<char, std::char_traits<char>, std::allocator<char>, std::fbstring_core<char> >*) at hphp/runtime/base/ini-setting.h:226\n  4  HPHP::RequestInjectionData::threadInit() at hphp/runtime/base/ini-setting.h:235\n  5  HPHP::RequestInjectionData::RequestInjectionData() at hphp/runtime/base/request-injection-data.h:68\n  6  HPHP::ThreadInfo::ThreadInfo() at hphp/runtime/base/thread-info.cpp:52\n  7  HPHP::ThreadLocalNoCheck<HPHP::ThreadInfo>::create() at hphp/util/thread-local.h:250\n  8  HPHP::ThreadLocalNoCheck<HPHP::ThreadInfo>::getCheck() const at hphp/util/thread-local.h:255\n  9  HPHP::init_thread_locals(void*) at hphp/runtime/base/thread-init-fini.cpp:60\n  10 HPHP::hphp_process_init() at hphp/runtime/base/program-functions.cpp:1628\n  11 HPHP::execute_program_impl(int, char**) at hphp/runtime/base/program-functions.cpp:1431\n  12 HPHP::execute_program(int, char**) at hphp/runtime/base/program-functions.cpp:944\n  13 main at hphp/hhvm/main.cpp:61\n\nI'm not sure what introduced this recently, but it looks like a legit calling order, and this code I'm changing is probably wrong. Instead of trying to read in the global state, I'll use the local instance as we do in other places while binding other INI settings.\n\nI found this crash going all the way back a month:\n\n-rw------- 1 twsvcscm twsvcscm 4285 Aug  6 15:25 stacktrace.3303.log\n\nReviewed By: @markw65\n\nDifferential Revision: D1546487","Paul Tarjan",false],["6ce6853bd37ce67dfbce58fcddb5a3ce799712dc","2b5c240e6abd88e71ffc225b0459016e4cba9bda@fb.com","Remove prepXMM() and cgBinaryDblOp()\n\nSummary: prepXMM() was guaranteed to always be passed Dbl args\nassigned to virtual registers, turning the whole thing\ninto a nop. Consequently, cgBinaryDblOp became a nop too,\nso just hand-inlined it everywhere. Removed a few\nunnecessary copies too.\n\nReviewed By: @ottoni\n\nDifferential Revision: D1548190\n(I inspected each one, and it's just the FTP tests which\nare failing many diffs)","Edwin Smith",false],["14560d4a677a9b413f17202468b494642d3468bb","b8eeaacbfbefa77cd4cb0a961f265cafd2a8213e@fb.com","Fix Vasm generation for Jmp\n\nSummary: It wasn't handling source operands with types that have constant value (Null, Uninit), which don't require any registers.\n\nReviewed By: @edwinsmith\n\nDifferential Revision: D1547383","Guilherme Ottoni",false],["0e85bf98dc124d00cc9c6c264a48460149d947f2","1650efe4630bf7b93325107599da3e871b6859a7@fb.com","stop killing LightProcesses while writing out stacktrace.log\n\nSummary: This check was added 4.5 years ago in a very different environment. We're seeing a lot of deadlocks while writing out the stacktrace file and it would be better to just make LightProcesses able to have its parent go away.\n\nReviewed By: @markw65\n\nDifferential Revision: D1547676","Paul Tarjan",false],["44d81c1893964ac634cd11dd1d573049ffdf039f","521b71b66118ece0fda08843b612c77cfd6c2588@fb.com","Rewrite + speed up unit test script.\n\nSummary: * Python is easier to maintain\n* I want to add coverage support, so this rewrite makes it easier\n* We run tests in parallel now, with a 3-4x speedup!\n* Easy to run tests independently of fbmake (and avoid its slow startup time) -- and we can either test a single file or an entire directory @elgenie said this would be useful)\n\nReviewed By: @elgenie\n\nDifferential Revision: D1546618","Jez Ng",false],["952efcd4e468bdf0dd060c872c1b2cff77b7baba","2b5c240e6abd88e71ffc225b0459016e4cba9bda@fb.com","VASM: remove useless instructions\n\nSummary: This diff implements dead code elimination over VASM. Instructions\nthat modify cpu flags, physical registers, memory, or control flow,\nare considered \"useful\"; this is conservative but correct when we aren't doing\ndataflow analysis on machine state (registers, flags, memory).\n\nA current limitation is that we don't track liveness of status flags, so we\ncannot remove otherwise-dead ALU instructions (in case the flags are used).\n\nRuns DCE before register allocation.\n\nReviewed By: @jasone\n\nDifferential Revision: D1460512","Edwin Smith",false],["e194490b3b91096a3b3214f1ef01c9f1fb4f4c96","1650efe4630bf7b93325107599da3e871b6859a7@fb.com","make server.inc more robust\n\nSummary: @jlreyes made this more robust, but I forgot to make him also change the import script to keep it. So when I did a re-import, it blew it up.\n\nReviewed By: @JoelMarcey\n\nDifferential Revision: D1549523","Paul Tarjan",false],["c66b09e0dab067de1b86f9d23c21b246bac49a6c","1459d19acca8aa0d331ced91d7cdfdd61263a03a@fb.com","Revert \"Updated mockery to 0.9.2\"\n\nReviewed By: @ptarjan","Fred Emmott",false],["c273896e5ff856e0044c0d4f9b0ddd052d01a0bf","f7a3a5c0528e7657f3f7816faa0a5e2de16317f6@fb.com","Update third-party to pull in folly 5:0","Sara Golemon",false],["d97b3e15fc53a6727fdd7e044e61c725ba51fbdc","63e28e422f1f9a67f8cba9390f6f43b0c2acb111@fb.com","Get hhvm compiling with clang-3.5\n\nSummary: This really wasn't that bad. A few mistaken uses of abs(), a few\nfunctions unused except in debug mode, and some apparently-redundant\nbool conversions.\n\nReviewed By: @meyering\n\nDifferential Revision: D1546566","Owen Yamauchi",false],["088a28be5aa0c5940fa294d4e093b2201b361b1a","f7a3a5c0528e7657f3f7816faa0a5e2de16317f6@fb.com","Update third-party for modified folly build","Sara Golemon",false]],"size":79,"ref":"refs/heads/fix-posix-grname","head":"c51a0ed7a0088b9348c27a8d204aa3a24b7cd4c8"}