GitHub PullRequestReviewCommentEvent at 2014-11-06 22:16:33
Repository: onejs
Actor: xirzec
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/OneJSToolkit/onejs/pulls/comments/19980223","id":19980223,"diff_hunk":"@@ -141,6 +141,12 @@ class View extends BaseView {\n         // $toggle\n         // $member.foo\n \n+        // Although our param is strongly typed in TS, we need to ensure we're getting only strings\n+        // due to certain apps that modify their String prototype","path":"src/View.ts","position":5,"original_position":5,"commit_id":"96bec058046c5d8109a68a2623a0f958c3ac3fa5","original_commit_id":"96bec058046c5d8109a68a2623a0f958c3ac3fa5","user":{"login":"xirzec","id":639216,"avatar_url":"https://avatars.githubusercontent.com/u/639216?v=2","gravatar_id":"","url":"https://api.github.com/users/xirzec","html_url":"https://github.com/xirzec","followers_url":"https://api.github.com/users/xirzec/followers","following_url":"https://api.github.com/users/xirzec/following{/other_user}","gists_url":"https://api.github.com/users/xirzec/gists{/gist_id}","starred_url":"https://api.github.com/users/xirzec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xirzec/subscriptions","organizations_url":"https://api.github.com/users/xirzec/orgs","repos_url":"https://api.github.com/users/xirzec/repos","events_url":"https://api.github.com/users/xirzec/events{/privacy}","received_events_url":"https://api.github.com/users/xirzec/received_events","type":"User","site_admin":false},"body":"What does this mean? I'm familiar with some people polyfilling helpers like trim() onto strings, but how would that affect us?","created_at":"2014-11-06T22:16:33Z","updated_at":"2014-11-06T22:16:33Z","html_url":"https://github.com/OneJSToolkit/onejs/pull/37#discussion_r19980223","pull_request_url":"https://api.github.com/repos/OneJSToolkit/onejs/pulls/37","_links":{"self":{"href":"https://api.github.com/repos/OneJSToolkit/onejs/pulls/comments/19980223"},"html":{"href":"https://github.com/OneJSToolkit/onejs/pull/37#discussion_r19980223"},"pull_request":{"href":"https://api.github.com/repos/OneJSToolkit/onejs/pulls/37"}}},"pull_request":{"url":"https://api.github.com/repos/OneJSToolkit/onejs/pulls/37","id":24008746,"html_url":"https://github.com/OneJSToolkit/onejs/pull/37","diff_url":"https://github.com/OneJSToolkit/onejs/pull/37.diff","patch_url":"https://github.com/OneJSToolkit/onejs/pull/37.patch","issue_url":"https://api.github.com/repos/OneJSToolkit/onejs/issues/37","number":37,"state":"open","locked":false,"title":"Fix an edge case for apps that modify their string prototype","user":{"login":"BobNisco","id":1316246,"avatar_url":"https://avatars.githubusercontent.com/u/1316246?v=2","gravatar_id":"","url":"https://api.github.com/users/BobNisco","html_url":"https://github.com/BobNisco","followers_url":"https://api.github.com/users/BobNisco/followers","following_url":"https://api.github.com/users/BobNisco/following{/other_user}","gists_url":"https://api.github.com/users/BobNisco/gists{/gist_id}","starred_url":"https://api.github.com/users/BobNisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BobNisco/subscriptions","organizations_url":"https://api.github.com/users/BobNisco/orgs","repos_url":"https://api.github.com/users/BobNisco/repos","events_url":"https://api.github.com/users/BobNisco/events{/privacy}","received_events_url":"https://api.github.com/users/BobNisco/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-11-06T20:10:55Z","updated_at":"2014-11-06T22:16:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e2394f36a9de1a4a8147ce120d50c8ac7eb51092","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OneJSToolkit/onejs/pulls/37/commits","review_comments_url":"https://api.github.com/repos/OneJSToolkit/onejs/pulls/37/comments","review_comment_url":"https://api.github.com/repos/OneJSToolkit/onejs/pulls/comments/{number}","comments_url":"https://api.github.com/repos/OneJSToolkit/onejs/issues/37/comments","statuses_url":"https://api.github.com/repos/OneJSToolkit/onejs/statuses/96bec058046c5d8109a68a2623a0f958c3ac3fa5","head":{"label":"OneJSToolkit:bobnisco/proptarget-fix","ref":"bobnisco/proptarget-fix","sha":"96bec058046c5d8109a68a2623a0f958c3ac3fa5","user":{"login":"OneJSToolkit","id":9060569,"avatar_url":"https://avatars.githubusercontent.com/u/9060569?v=2","gravatar_id":"","url":"https://api.github.com/users/OneJSToolkit","html_url":"https://github.com/OneJSToolkit","followers_url":"https://api.github.com/users/OneJSToolkit/followers","following_url":"https://api.github.com/users/OneJSToolkit/following{/other_user}","gists_url":"https://api.github.com/users/OneJSToolkit/gists{/gist_id}","starred_url":"https://api.github.com/users/OneJSToolkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OneJSToolkit/subscriptions","organizations_url":"https://api.github.com/users/OneJSToolkit/orgs","repos_url":"https://api.github.com/users/OneJSToolkit/repos","events_url":"https://api.github.com/users/OneJSToolkit/events{/privacy}","received_events_url":"https://api.github.com/users/OneJSToolkit/received_events","type":"Organization","site_admin":false},"repo":{"id":22066928,"name":"onejs","full_name":"OneJSToolkit/onejs","owner":{"login":"OneJSToolkit","id":9060569,"avatar_url":"https://avatars.githubusercontent.com/u/9060569?v=2","gravatar_id":"","url":"https://api.github.com/users/OneJSToolkit","html_url":"https://github.com/OneJSToolkit","followers_url":"https://api.github.com/users/OneJSToolkit/followers","following_url":"https://api.github.com/users/OneJSToolkit/following{/other_user}","gists_url":"https://api.github.com/users/OneJSToolkit/gists{/gist_id}","starred_url":"https://api.github.com/users/OneJSToolkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OneJSToolkit/subscriptions","organizations_url":"https://api.github.com/users/OneJSToolkit/orgs","repos_url":"https://api.github.com/users/OneJSToolkit/repos","events_url":"https://api.github.com/users/OneJSToolkit/events{/privacy}","received_events_url":"https://api.github.com/users/OneJSToolkit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OneJSToolkit/onejs","description":"","fork":false,"url":"https://api.github.com/repos/OneJSToolkit/onejs","forks_url":"https://api.github.com/repos/OneJSToolkit/onejs/forks","keys_url":"https://api.github.com/repos/OneJSToolkit/onejs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OneJSToolkit/onejs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OneJSToolkit/onejs/teams","hooks_url":"https://api.github.com/repos/OneJSToolkit/onejs/hooks","issue_events_url":"https://api.github.com/repos/OneJSToolkit/onejs/issues/events{/number}","events_url":"https://api.github.com/repos/OneJSToolkit/onejs/events","assignees_url":"https://api.github.com/repos/OneJSToolkit/onejs/assignees{/user}","branches_url":"https://api.github.com/repos/OneJSToolkit/onejs/branches{/branch}","tags_url":"https://api.github.com/repos/OneJSToolkit/onejs/tags","blobs_url":"https://api.github.com/repos/OneJSToolkit/onejs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OneJSToolkit/onejs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OneJSToolkit/onejs/git/refs{/sha}","trees_url":"https://api.github.com/repos/OneJSToolkit/onejs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OneJSToolkit/onejs/statuses/{sha}","languages_url":"https://api.github.com/repos/OneJSToolkit/onejs/languages","stargazers_url":"https://api.github.com/repos/OneJSToolkit/onejs/stargazers","contributors_url":"https://api.github.com/repos/OneJSToolkit/onejs/contributors","subscribers_url":"https://api.github.com/repos/OneJSToolkit/onejs/subscribers","subscription_url":"https://api.github.com/repos/OneJSToolkit/onejs/subscription","commits_url":"https://api.github.com/repos/OneJSToolkit/onejs/commits{/sha}","git_commits_url":"https://api.github.com/repos/OneJSToolkit/onejs/git/commits{/sha}","comments_url":"https://api.github.com/repos/OneJSToolkit/onejs/comments{/number}","issue_comment_url":"https://api.github.com/repos/OneJSToolkit/onejs/issues/comments/{number}","contents_url":"https://api.github.com/repos/OneJSToolkit/onejs/contents/{+path}","compare_url":"https://api.github.com/repos/OneJSToolkit/onejs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OneJSToolkit/onejs/merges","archive_url":"https://api.github.com/repos/OneJSToolkit/onejs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OneJSToolkit/onejs/downloads","issues_url":"https://api.github.com/repos/OneJSToolkit/onejs/issues{/number}","pulls_url":"https://api.github.com/repos/OneJSToolkit/onejs/pulls{/number}","milestones_url":"https://api.github.com/repos/OneJSToolkit/onejs/milestones{/number}","notifications_url":"https://api.github.com/repos/OneJSToolkit/onejs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OneJSToolkit/onejs/labels{/name}","releases_url":"https://api.github.com/repos/OneJSToolkit/onejs/releases{/id}","created_at":"2014-07-21T14:12:55Z","updated_at":"2014-10-21T16:20:41Z","pushed_at":"2014-11-06T20:10:11Z","git_url":"git://github.com/OneJSToolkit/onejs.git","ssh_url":"git@github.com:OneJSToolkit/onejs.git","clone_url":"https://github.com/OneJSToolkit/onejs.git","svn_url":"https://github.com/OneJSToolkit/onejs","homepage":null,"size":2523,"stargazers_count":7,"watchers_count":7,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":5,"forks":3,"open_issues":5,"watchers":7,"default_branch":"master"}},"base":{"label":"OneJSToolkit:master","ref":"master","sha":"8622c92e5de416be60c5bd015614bedf428869ba","user":{"login":"OneJSToolkit","id":9060569,"avatar_url":"https://avatars.githubusercontent.com/u/9060569?v=2","gravatar_id":"","url":"https://api.github.com/users/OneJSToolkit","html_url":"https://github.com/OneJSToolkit","followers_url":"https://api.github.com/users/OneJSToolkit/followers","following_url":"https://api.github.com/users/OneJSToolkit/following{/other_user}","gists_url":"https://api.github.com/users/OneJSToolkit/gists{/gist_id}","starred_url":"https://api.github.com/users/OneJSToolkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OneJSToolkit/subscriptions","organizations_url":"https://api.github.com/users/OneJSToolkit/orgs","repos_url":"https://api.github.com/users/OneJSToolkit/repos","events_url":"https://api.github.com/users/OneJSToolkit/events{/privacy}","received_events_url":"https://api.github.com/users/OneJSToolkit/received_events","type":"Organization","site_admin":false},"repo":{"id":22066928,"name":"onejs","full_name":"OneJSToolkit/onejs","owner":{"login":"OneJSToolkit","id":9060569,"avatar_url":"https://avatars.githubusercontent.com/u/9060569?v=2","gravatar_id":"","url":"https://api.github.com/users/OneJSToolkit","html_url":"https://github.com/OneJSToolkit","followers_url":"https://api.github.com/users/OneJSToolkit/followers","following_url":"https://api.github.com/users/OneJSToolkit/following{/other_user}","gists_url":"https://api.github.com/users/OneJSToolkit/gists{/gist_id}","starred_url":"https://api.github.com/users/OneJSToolkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OneJSToolkit/subscriptions","organizations_url":"https://api.github.com/users/OneJSToolkit/orgs","repos_url":"https://api.github.com/users/OneJSToolkit/repos","events_url":"https://api.github.com/users/OneJSToolkit/events{/privacy}","received_events_url":"https://api.github.com/users/OneJSToolkit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OneJSToolkit/onejs","description":"","fork":false,"url":"https://api.github.com/repos/OneJSToolkit/onejs","forks_url":"https://api.github.com/repos/OneJSToolkit/onejs/forks","keys_url":"https://api.github.com/repos/OneJSToolkit/onejs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OneJSToolkit/onejs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OneJSToolkit/onejs/teams","hooks_url":"https://api.github.com/repos/OneJSToolkit/onejs/hooks","issue_events_url":"https://api.github.com/repos/OneJSToolkit/onejs/issues/events{/number}","events_url":"https://api.github.com/repos/OneJSToolkit/onejs/events","assignees_url":"https://api.github.com/repos/OneJSToolkit/onejs/assignees{/user}","branches_url":"https://api.github.com/repos/OneJSToolkit/onejs/branches{/branch}","tags_url":"https://api.github.com/repos/OneJSToolkit/onejs/tags","blobs_url":"https://api.github.com/repos/OneJSToolkit/onejs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OneJSToolkit/onejs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OneJSToolkit/onejs/git/refs{/sha}","trees_url":"https://api.github.com/repos/OneJSToolkit/onejs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OneJSToolkit/onejs/statuses/{sha}","languages_url":"https://api.github.com/repos/OneJSToolkit/onejs/languages","stargazers_url":"https://api.github.com/repos/OneJSToolkit/onejs/stargazers","contributors_url":"https://api.github.com/repos/OneJSToolkit/onejs/contributors","subscribers_url":"https://api.github.com/repos/OneJSToolkit/onejs/subscribers","subscription_url":"https://api.github.com/repos/OneJSToolkit/onejs/subscription","commits_url":"https://api.github.com/repos/OneJSToolkit/onejs/commits{/sha}","git_commits_url":"https://api.github.com/repos/OneJSToolkit/onejs/git/commits{/sha}","comments_url":"https://api.github.com/repos/OneJSToolkit/onejs/comments{/number}","issue_comment_url":"https://api.github.com/repos/OneJSToolkit/onejs/issues/comments/{number}","contents_url":"https://api.github.com/repos/OneJSToolkit/onejs/contents/{+path}","compare_url":"https://api.github.com/repos/OneJSToolkit/onejs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OneJSToolkit/onejs/merges","archive_url":"https://api.github.com/repos/OneJSToolkit/onejs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OneJSToolkit/onejs/downloads","issues_url":"https://api.github.com/repos/OneJSToolkit/onejs/issues{/number}","pulls_url":"https://api.github.com/repos/OneJSToolkit/onejs/pulls{/number}","milestones_url":"https://api.github.com/repos/OneJSToolkit/onejs/milestones{/number}","notifications_url":"https://api.github.com/repos/OneJSToolkit/onejs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OneJSToolkit/onejs/labels{/name}","releases_url":"https://api.github.com/repos/OneJSToolkit/onejs/releases{/id}","created_at":"2014-07-21T14:12:55Z","updated_at":"2014-10-21T16:20:41Z","pushed_at":"2014-11-06T20:10:11Z","git_url":"git://github.com/OneJSToolkit/onejs.git","ssh_url":"git@github.com:OneJSToolkit/onejs.git","clone_url":"https://github.com/OneJSToolkit/onejs.git","svn_url":"https://github.com/OneJSToolkit/onejs","homepage":null,"size":2523,"stargazers_count":7,"watchers_count":7,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":5,"forks":3,"open_issues":5,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OneJSToolkit/onejs/pulls/37"},"html":{"href":"https://github.com/OneJSToolkit/onejs/pull/37"},"issue":{"href":"https://api.github.com/repos/OneJSToolkit/onejs/issues/37"},"comments":{"href":"https://api.github.com/repos/OneJSToolkit/onejs/issues/37/comments"},"review_comments":{"href":"https://api.github.com/repos/OneJSToolkit/onejs/pulls/37/comments"},"review_comment":{"href":"https://api.github.com/repos/OneJSToolkit/onejs/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/OneJSToolkit/onejs/pulls/37/commits"},"statuses":{"href":"https://api.github.com/repos/OneJSToolkit/onejs/statuses/96bec058046c5d8109a68a2623a0f958c3ac3fa5"}}}}