GitHub PullRequestReviewCommentEvent at 2014-10-01 01:50:48
Repository: piconot
Actor: mculhane
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/hmc-cs111-fall2014/piconot/pulls/comments/18258099","id":18258099,"diff_hunk":"@@ -0,0 +1,57 @@\n+Names: Ellen Hui and Mauricio Molina\n+Date: September 28, 2014\n+Domain Specific Languages\n+Professor Ben\n+\n+\n+\n+\n+\n+- New syntax for defining picobot code\n+\n+\tWe decided to change the syntax for the inner declarations from\n+\n+    surroundedBy \"NExx\" then move \"W\" newState \"confused\"\n+\n+\tand instead merge then move into thenDo, and also remove the newState keyword\n+\t(instead adding the new state argument into the thenDo call).  This also\n+\tnecessitated adding parentheses, now that we have two arguments to thenDo, so w\n+\tfigured we should give surroundedBy parentheses as well, for consistency.\n+\n+    surroundedBy(\"NExx\") thenMove(\"W\", \"confused\")\n+\n+\talthough not as clean and clear about what they're doing, it allows for a conditional structure rule creation. \n+\n+\tinState(\"StateName\"){\t\t\t\t\t\t\tif inState(\"StateName\"){\n+\t\tsurroundedBy(\"NExx\") {\t\t\t\t\t\t\t\tif(surroundedBy(Surroundings)){\n+\t\t\tthenMove(\"W\", \"confused\")\t\t\t\t\t\t\t\tthenMove(Direction, newState)\n+\t\t}\t\t\t\t\t\t\t\t\t\t\t\t\t}\n+\t}\t \t\t\t\t\t\t\t\t\t\t\t}\n+\n+\n+\n+\tOriginally started with a myState class that would hold all the information about a state\n+\tunder our implementation and handle creation of rules defined by the user. However\n+\twe ended up finding scoping issues where we could not execute code in the way that we wanted. \n+\tWe attempted passing units of code through 3 methods to get it to our myClass constructor, but \n+\tended up losing that code while passing. The solution ended up being to get rid of the myState class entirely \n+\tand simply mapped from string name to state.\n+\n+\n+\n+- Allowing user to user string names instead of requiring numbers\n+\n+\tWe mapped the string class names given by user to states using a map. While the user will use the state name they gave, \n+\twe are still using number values to define states. It is hidden from the user. ","path":"evaluation.txt","position":45,"original_position":45,"commit_id":"ae62f9c9b7e7919d502b416935a7068998fb423b","original_commit_id":"ae62f9c9b7e7919d502b416935a7068998fb423b","user":{"login":"mculhane","id":3872922,"avatar_url":"https://avatars.githubusercontent.com/u/3872922?v=2","gravatar_id":"","url":"https://api.github.com/users/mculhane","html_url":"https://github.com/mculhane","followers_url":"https://api.github.com/users/mculhane/followers","following_url":"https://api.github.com/users/mculhane/following{/other_user}","gists_url":"https://api.github.com/users/mculhane/gists{/gist_id}","starred_url":"https://api.github.com/users/mculhane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mculhane/subscriptions","organizations_url":"https://api.github.com/users/mculhane/orgs","repos_url":"https://api.github.com/users/mculhane/repos","events_url":"https://api.github.com/users/mculhane/events{/privacy}","received_events_url":"https://api.github.com/users/mculhane/received_events","type":"User","site_admin":false},"body":"This is a cool improvement that makes it easier for the user to build their mental model right into the text of a program.","created_at":"2014-10-01T01:50:48Z","updated_at":"2014-10-01T01:50:48Z","html_url":"https://github.com/hmc-cs111-fall2014/piconot/pull/4#discussion_r18258099","pull_request_url":"https://api.github.com/repos/hmc-cs111-fall2014/piconot/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/hmc-cs111-fall2014/piconot/pulls/comments/18258099"},"html":{"href":"https://github.com/hmc-cs111-fall2014/piconot/pull/4#discussion_r18258099"},"pull_request":{"href":"https://api.github.com/repos/hmc-cs111-fall2014/piconot/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/hmc-cs111-fall2014/piconot/pulls/4","id":21906557,"html_url":"https://github.com/hmc-cs111-fall2014/piconot/pull/4","diff_url":"https://github.com/hmc-cs111-fall2014/piconot/pull/4.diff","patch_url":"https://github.com/hmc-cs111-fall2014/piconot/pull/4.patch","issue_url":"https://api.github.com/repos/hmc-cs111-fall2014/piconot/issues/4","number":4,"state":"open","locked":false,"title":"Assignment 3 - Ellen Hui and Mauricio Molina (Team #5)","user":{"login":"ellenfkh","id":3672564,"avatar_url":"https://avatars.githubusercontent.com/u/3672564?v=2","gravatar_id":"","url":"https://api.github.com/users/ellenfkh","html_url":"https://github.com/ellenfkh","followers_url":"https://api.github.com/users/ellenfkh/followers","following_url":"https://api.github.com/users/ellenfkh/following{/other_user}","gists_url":"https://api.github.com/users/ellenfkh/gists{/gist_id}","starred_url":"https://api.github.com/users/ellenfkh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ellenfkh/subscriptions","organizations_url":"https://api.github.com/users/ellenfkh/orgs","repos_url":"https://api.github.com/users/ellenfkh/repos","events_url":"https://api.github.com/users/ellenfkh/events{/privacy}","received_events_url":"https://api.github.com/users/ellenfkh/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-09-28T21:08:13Z","updated_at":"2014-10-01T01:50:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fe300f4209b596305a298f479fc193b7194f11d3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hmc-cs111-fall2014/piconot/pulls/4/commits","review_comments_url":"https://api.github.com/repos/hmc-cs111-fall2014/piconot/pulls/4/comments","review_comment_url":"https://api.github.com/repos/hmc-cs111-fall2014/piconot/pulls/comments/{number}","comments_url":"https://api.github.com/repos/hmc-cs111-fall2014/piconot/issues/4/comments","statuses_url":"https://api.github.com/repos/hmc-cs111-fall2014/piconot/statuses/ae62f9c9b7e7919d502b416935a7068998fb423b","head":{"label":"mmauricio11235:master","ref":"master","sha":"ae62f9c9b7e7919d502b416935a7068998fb423b","user":{"login":"mmauricio11235","id":4110302,"avatar_url":"https://avatars.githubusercontent.com/u/4110302?v=2","gravatar_id":"","url":"https://api.github.com/users/mmauricio11235","html_url":"https://github.com/mmauricio11235","followers_url":"https://api.github.com/users/mmauricio11235/followers","following_url":"https://api.github.com/users/mmauricio11235/following{/other_user}","gists_url":"https://api.github.com/users/mmauricio11235/gists{/gist_id}","starred_url":"https://api.github.com/users/mmauricio11235/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmauricio11235/subscriptions","organizations_url":"https://api.github.com/users/mmauricio11235/orgs","repos_url":"https://api.github.com/users/mmauricio11235/repos","events_url":"https://api.github.com/users/mmauricio11235/events{/privacy}","received_events_url":"https://api.github.com/users/mmauricio11235/received_events","type":"User","site_admin":false},"repo":{"id":24343426,"name":"piconot","full_name":"mmauricio11235/piconot","owner":{"login":"mmauricio11235","id":4110302,"avatar_url":"https://avatars.githubusercontent.com/u/4110302?v=2","gravatar_id":"","url":"https://api.github.com/users/mmauricio11235","html_url":"https://github.com/mmauricio11235","followers_url":"https://api.github.com/users/mmauricio11235/followers","following_url":"https://api.github.com/users/mmauricio11235/following{/other_user}","gists_url":"https://api.github.com/users/mmauricio11235/gists{/gist_id}","starred_url":"https://api.github.com/users/mmauricio11235/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmauricio11235/subscriptions","organizations_url":"https://api.github.com/users/mmauricio11235/orgs","repos_url":"https://api.github.com/users/mmauricio11235/repos","events_url":"https://api.github.com/users/mmauricio11235/events{/privacy}","received_events_url":"https://api.github.com/users/mmauricio11235/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mmauricio11235/piconot","description":"","fork":true,"url":"https://api.github.com/repos/mmauricio11235/piconot","forks_url":"https://api.github.com/repos/mmauricio11235/piconot/forks","keys_url":"https://api.github.com/repos/mmauricio11235/piconot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mmauricio11235/piconot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mmauricio11235/piconot/teams","hooks_url":"https://api.github.com/repos/mmauricio11235/piconot/hooks","issue_events_url":"https://api.github.com/repos/mmauricio11235/piconot/issues/events{/number}","events_url":"https://api.github.com/repos/mmauricio11235/piconot/events","assignees_url":"https://api.github.com/repos/mmauricio11235/piconot/assignees{/user}","branches_url":"https://api.github.com/repos/mmauricio11235/piconot/branches{/branch}","tags_url":"https://api.github.com/repos/mmauricio11235/piconot/tags","blobs_url":"https://api.github.com/repos/mmauricio11235/piconot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mmauricio11235/piconot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mmauricio11235/piconot/git/refs{/sha}","trees_url":"https://api.github.com/repos/mmauricio11235/piconot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mmauricio11235/piconot/statuses/{sha}","languages_url":"https://api.github.com/repos/mmauricio11235/piconot/languages","stargazers_url":"https://api.github.com/repos/mmauricio11235/piconot/stargazers","contributors_url":"https://api.github.com/repos/mmauricio11235/piconot/contributors","subscribers_url":"https://api.github.com/repos/mmauricio11235/piconot/subscribers","subscription_url":"https://api.github.com/repos/mmauricio11235/piconot/subscription","commits_url":"https://api.github.com/repos/mmauricio11235/piconot/commits{/sha}","git_commits_url":"https://api.github.com/repos/mmauricio11235/piconot/git/commits{/sha}","comments_url":"https://api.github.com/repos/mmauricio11235/piconot/comments{/number}","issue_comment_url":"https://api.github.com/repos/mmauricio11235/piconot/issues/comments/{number}","contents_url":"https://api.github.com/repos/mmauricio11235/piconot/contents/{+path}","compare_url":"https://api.github.com/repos/mmauricio11235/piconot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mmauricio11235/piconot/merges","archive_url":"https://api.github.com/repos/mmauricio11235/piconot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mmauricio11235/piconot/downloads","issues_url":"https://api.github.com/repos/mmauricio11235/piconot/issues{/number}","pulls_url":"https://api.github.com/repos/mmauricio11235/piconot/pulls{/number}","milestones_url":"https://api.github.com/repos/mmauricio11235/piconot/milestones{/number}","notifications_url":"https://api.github.com/repos/mmauricio11235/piconot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mmauricio11235/piconot/labels{/name}","releases_url":"https://api.github.com/repos/mmauricio11235/piconot/releases{/id}","created_at":"2014-09-22T19:59:50Z","updated_at":"2014-09-23T22:56:48Z","pushed_at":"2014-09-28T21:06:58Z","git_url":"git://github.com/mmauricio11235/piconot.git","ssh_url":"git@github.com:mmauricio11235/piconot.git","clone_url":"https://github.com/mmauricio11235/piconot.git","svn_url":"https://github.com/mmauricio11235/piconot","homepage":null,"size":336,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hmc-cs111-fall2014:master","ref":"master","sha":"316a4679fc9ae7c219a13ffef87dfa53fd7f4b3a","user":{"login":"hmc-cs111-fall2014","id":8164020,"avatar_url":"https://avatars.githubusercontent.com/u/8164020?v=2","gravatar_id":"","url":"https://api.github.com/users/hmc-cs111-fall2014","html_url":"https://github.com/hmc-cs111-fall2014","followers_url":"https://api.github.com/users/hmc-cs111-fall2014/followers","following_url":"https://api.github.com/users/hmc-cs111-fall2014/following{/other_user}","gists_url":"https://api.github.com/users/hmc-cs111-fall2014/gists{/gist_id}","starred_url":"https://api.github.com/users/hmc-cs111-fall2014/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmc-cs111-fall2014/subscriptions","organizations_url":"https://api.github.com/users/hmc-cs111-fall2014/orgs","repos_url":"https://api.github.com/users/hmc-cs111-fall2014/repos","events_url":"https://api.github.com/users/hmc-cs111-fall2014/events{/privacy}","received_events_url":"https://api.github.com/users/hmc-cs111-fall2014/received_events","type":"Organization","site_admin":false},"repo":{"id":24044276,"name":"piconot","full_name":"hmc-cs111-fall2014/piconot","owner":{"login":"hmc-cs111-fall2014","id":8164020,"avatar_url":"https://avatars.githubusercontent.com/u/8164020?v=2","gravatar_id":"","url":"https://api.github.com/users/hmc-cs111-fall2014","html_url":"https://github.com/hmc-cs111-fall2014","followers_url":"https://api.github.com/users/hmc-cs111-fall2014/followers","following_url":"https://api.github.com/users/hmc-cs111-fall2014/following{/other_user}","gists_url":"https://api.github.com/users/hmc-cs111-fall2014/gists{/gist_id}","starred_url":"https://api.github.com/users/hmc-cs111-fall2014/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmc-cs111-fall2014/subscriptions","organizations_url":"https://api.github.com/users/hmc-cs111-fall2014/orgs","repos_url":"https://api.github.com/users/hmc-cs111-fall2014/repos","events_url":"https://api.github.com/users/hmc-cs111-fall2014/events{/privacy}","received_events_url":"https://api.github.com/users/hmc-cs111-fall2014/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmc-cs111-fall2014/piconot","description":"","fork":false,"url":"https://api.github.com/repos/hmc-cs111-fall2014/piconot","forks_url":"https://api.github.com/repos/hmc-cs111-fall2014/piconot/forks","keys_url":"https://api.github.com/repos/hmc-cs111-fall2014/piconot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmc-cs111-fall2014/piconot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmc-cs111-fall2014/piconot/teams","hooks_url":"https://api.github.com/repos/hmc-cs111-fall2014/piconot/hooks","issue_events_url":"https://api.github.com/repos/hmc-cs111-fall2014/piconot/issues/events{/number}","events_url":"https://api.github.com/repos/hmc-cs111-fall2014/piconot/events","assignees_url":"https://api.github.com/repos/hmc-cs111-fall2014/piconot/assignees{/user}","branches_url":"https://api.github.com/repos/hmc-cs111-fall2014/piconot/branches{/branch}","tags_url":"https://api.github.com/repos/hmc-cs111-fall2014/piconot/tags","blobs_url":"https://api.github.com/repos/hmc-cs111-fall2014/piconot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmc-cs111-fall2014/piconot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmc-cs111-fall2014/piconot/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmc-cs111-fall2014/piconot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmc-cs111-fall2014/piconot/statuses/{sha}","languages_url":"https://api.github.com/repos/hmc-cs111-fall2014/piconot/languages","stargazers_url":"https://api.github.com/repos/hmc-cs111-fall2014/piconot/stargazers","contributors_url":"https://api.github.com/repos/hmc-cs111-fall2014/piconot/contributors","subscribers_url":"https://api.github.com/repos/hmc-cs111-fall2014/piconot/subscribers","subscription_url":"https://api.github.com/repos/hmc-cs111-fall2014/piconot/subscription","commits_url":"https://api.github.com/repos/hmc-cs111-fall2014/piconot/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmc-cs111-fall2014/piconot/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmc-cs111-fall2014/piconot/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmc-cs111-fall2014/piconot/issues/comments/{number}","contents_url":"https://api.github.com/repos/hmc-cs111-fall2014/piconot/contents/{+path}","compare_url":"https://api.github.com/repos/hmc-cs111-fall2014/piconot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmc-cs111-fall2014/piconot/merges","archive_url":"https://api.github.com/repos/hmc-cs111-fall2014/piconot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmc-cs111-fall2014/piconot/downloads","issues_url":"https://api.github.com/repos/hmc-cs111-fall2014/piconot/issues{/number}","pulls_url":"https://api.github.com/repos/hmc-cs111-fall2014/piconot/pulls{/number}","milestones_url":"https://api.github.com/repos/hmc-cs111-fall2014/piconot/milestones{/number}","notifications_url":"https://api.github.com/repos/hmc-cs111-fall2014/piconot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmc-cs111-fall2014/piconot/labels{/name}","releases_url":"https://api.github.com/repos/hmc-cs111-fall2014/piconot/releases{/id}","created_at":"2014-09-15T05:39:16Z","updated_at":"2014-09-17T19:51:22Z","pushed_at":"2014-09-30T04:02:19Z","git_url":"git://github.com/hmc-cs111-fall2014/piconot.git","ssh_url":"git@github.com:hmc-cs111-fall2014/piconot.git","clone_url":"https://github.com/hmc-cs111-fall2014/piconot.git","svn_url":"https://github.com/hmc-cs111-fall2014/piconot","homepage":null,"size":971,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":9,"forks":11,"open_issues":9,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hmc-cs111-fall2014/piconot/pulls/4"},"html":{"href":"https://github.com/hmc-cs111-fall2014/piconot/pull/4"},"issue":{"href":"https://api.github.com/repos/hmc-cs111-fall2014/piconot/issues/4"},"comments":{"href":"https://api.github.com/repos/hmc-cs111-fall2014/piconot/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/hmc-cs111-fall2014/piconot/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/hmc-cs111-fall2014/piconot/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/hmc-cs111-fall2014/piconot/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/hmc-cs111-fall2014/piconot/statuses/ae62f9c9b7e7919d502b416935a7068998fb423b"}}}}