GitHub PullRequestEvent at 2014-07-15 19:36:03
Repository: hhvm
Actor: fredemmott
Payload: {"action":"closed","number":2920,"pull_request":{"url":"https://api.github.com/repos/facebook/hhvm/pulls/2920","id":17034656,"html_url":"https://github.com/facebook/hhvm/pull/2920","diff_url":"https://github.com/facebook/hhvm/pull/2920.diff","patch_url":"https://github.com/facebook/hhvm/pull/2920.patch","issue_url":"https://api.github.com/repos/facebook/hhvm/issues/2920","number":2920,"state":"closed","title":"Refactor constant lookup JIT helpers","user":{"login":"Aatch","id":342416,"avatar_url":"https://avatars.githubusercontent.com/u/342416?","gravatar_id":"7a71739a8b962c2e1c43c76f8184450f","url":"https://api.github.com/users/Aatch","html_url":"https://github.com/Aatch","followers_url":"https://api.github.com/users/Aatch/followers","following_url":"https://api.github.com/users/Aatch/following{/other_user}","gists_url":"https://api.github.com/users/Aatch/gists{/gist_id}","starred_url":"https://api.github.com/users/Aatch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aatch/subscriptions","organizations_url":"https://api.github.com/users/Aatch/orgs","repos_url":"https://api.github.com/users/Aatch/repos","events_url":"https://api.github.com/users/Aatch/events{/privacy}","received_events_url":"https://api.github.com/users/Aatch/received_events","type":"User","site_admin":false},"body":"There are two helpers for looking up constants in the JIT.\r\n`lookupCnsHelper`, for getting constants without a fallback, and\r\n`lookupCnsUHelper` for constants with a fallback. Each function did their jobs\r\nslightly differently, with `lookupCnsUHelper` actually having a bug in the\r\nfallback case.\r\n\r\nThis commit refactors the two helpers into a single `lookupCnsCommonHelper`\r\nhelper. Which should help keep things in sync.\r\n\r\nFixes #2544","created_at":"2014-06-12T02:13:50Z","updated_at":"2014-07-15T19:36:00Z","closed_at":"2014-07-15T19:36:00Z","merged_at":null,"merge_commit_sha":"a94ef3a9eaa1b3ae313177a4fd0e65b72e00db5f","assignee":{"login":"fredemmott","id":360927,"avatar_url":"https://avatars.githubusercontent.com/u/360927?","gravatar_id":"626dcba04ffe56343d03d9c4f869b75e","url":"https://api.github.com/users/fredemmott","html_url":"https://github.com/fredemmott","followers_url":"https://api.github.com/users/fredemmott/followers","following_url":"https://api.github.com/users/fredemmott/following{/other_user}","gists_url":"https://api.github.com/users/fredemmott/gists{/gist_id}","starred_url":"https://api.github.com/users/fredemmott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fredemmott/subscriptions","organizations_url":"https://api.github.com/users/fredemmott/orgs","repos_url":"https://api.github.com/users/fredemmott/repos","events_url":"https://api.github.com/users/fredemmott/events{/privacy}","received_events_url":"https://api.github.com/users/fredemmott/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/facebook/hhvm/pulls/2920/commits","review_comments_url":"https://api.github.com/repos/facebook/hhvm/pulls/2920/comments","review_comment_url":"https://api.github.com/repos/facebook/hhvm/pulls/comments/{number}","comments_url":"https://api.github.com/repos/facebook/hhvm/issues/2920/comments","statuses_url":"https://api.github.com/repos/facebook/hhvm/statuses/0d0c227bd395ab7fa76e8cc49cddb27ea5c71e2b","head":{"label":"PocketRent:constant-fallback-jit","ref":"constant-fallback-jit","sha":"0d0c227bd395ab7fa76e8cc49cddb27ea5c71e2b","user":{"login":"PocketRent","id":5009199,"avatar_url":"https://avatars.githubusercontent.com/u/5009199?","gravatar_id":"f43ad1f30a1816d6e869186934c0ef7a","url":"https://api.github.com/users/PocketRent","html_url":"https://github.com/PocketRent","followers_url":"https://api.github.com/users/PocketRent/followers","following_url":"https://api.github.com/users/PocketRent/following{/other_user}","gists_url":"https://api.github.com/users/PocketRent/gists{/gist_id}","starred_url":"https://api.github.com/users/PocketRent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PocketRent/subscriptions","organizations_url":"https://api.github.com/users/PocketRent/orgs","repos_url":"https://api.github.com/users/PocketRent/repos","events_url":"https://api.github.com/users/PocketRent/events{/privacy}","received_events_url":"https://api.github.com/users/PocketRent/received_events","type":"Organization","site_admin":false},"repo":{"id":11595847,"name":"hhvm","full_name":"PocketRent/hhvm","owner":{"login":"PocketRent","id":5009199,"avatar_url":"https://avatars.githubusercontent.com/u/5009199?","gravatar_id":"f43ad1f30a1816d6e869186934c0ef7a","url":"https://api.github.com/users/PocketRent","html_url":"https://github.com/PocketRent","followers_url":"https://api.github.com/users/PocketRent/followers","following_url":"https://api.github.com/users/PocketRent/following{/other_user}","gists_url":"https://api.github.com/users/PocketRent/gists{/gist_id}","starred_url":"https://api.github.com/users/PocketRent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PocketRent/subscriptions","organizations_url":"https://api.github.com/users/PocketRent/orgs","repos_url":"https://api.github.com/users/PocketRent/repos","events_url":"https://api.github.com/users/PocketRent/events{/privacy}","received_events_url":"https://api.github.com/users/PocketRent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PocketRent/hhvm","description":"Virtual Machine, Runtime, and JIT for PHP","fork":true,"url":"https://api.github.com/repos/PocketRent/hhvm","forks_url":"https://api.github.com/repos/PocketRent/hhvm/forks","keys_url":"https://api.github.com/repos/PocketRent/hhvm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PocketRent/hhvm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PocketRent/hhvm/teams","hooks_url":"https://api.github.com/repos/PocketRent/hhvm/hooks","issue_events_url":"https://api.github.com/repos/PocketRent/hhvm/issues/events{/number}","events_url":"https://api.github.com/repos/PocketRent/hhvm/events","assignees_url":"https://api.github.com/repos/PocketRent/hhvm/assignees{/user}","branches_url":"https://api.github.com/repos/PocketRent/hhvm/branches{/branch}","tags_url":"https://api.github.com/repos/PocketRent/hhvm/tags","blobs_url":"https://api.github.com/repos/PocketRent/hhvm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PocketRent/hhvm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PocketRent/hhvm/git/refs{/sha}","trees_url":"https://api.github.com/repos/PocketRent/hhvm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PocketRent/hhvm/statuses/{sha}","languages_url":"https://api.github.com/repos/PocketRent/hhvm/languages","stargazers_url":"https://api.github.com/repos/PocketRent/hhvm/stargazers","contributors_url":"https://api.github.com/repos/PocketRent/hhvm/contributors","subscribers_url":"https://api.github.com/repos/PocketRent/hhvm/subscribers","subscription_url":"https://api.github.com/repos/PocketRent/hhvm/subscription","commits_url":"https://api.github.com/repos/PocketRent/hhvm/commits{/sha}","git_commits_url":"https://api.github.com/repos/PocketRent/hhvm/git/commits{/sha}","comments_url":"https://api.github.com/repos/PocketRent/hhvm/comments{/number}","issue_comment_url":"https://api.github.com/repos/PocketRent/hhvm/issues/comments/{number}","contents_url":"https://api.github.com/repos/PocketRent/hhvm/contents/{+path}","compare_url":"https://api.github.com/repos/PocketRent/hhvm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PocketRent/hhvm/merges","archive_url":"https://api.github.com/repos/PocketRent/hhvm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PocketRent/hhvm/downloads","issues_url":"https://api.github.com/repos/PocketRent/hhvm/issues{/number}","pulls_url":"https://api.github.com/repos/PocketRent/hhvm/pulls{/number}","milestones_url":"https://api.github.com/repos/PocketRent/hhvm/milestones{/number}","notifications_url":"https://api.github.com/repos/PocketRent/hhvm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PocketRent/hhvm/labels{/name}","releases_url":"https://api.github.com/repos/PocketRent/hhvm/releases{/id}","created_at":"2013-07-23T00:38:12Z","updated_at":"2014-07-07T03:47:00Z","pushed_at":"2014-07-08T05:06:18Z","git_url":"git://github.com/PocketRent/hhvm.git","ssh_url":"git@github.com:PocketRent/hhvm.git","clone_url":"https://github.com/PocketRent/hhvm.git","svn_url":"https://github.com/PocketRent/hhvm","homepage":"http://www.hhvm.com","size":134737,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":false,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"d54777e4d85c134087c4c0f65392ff9065356949","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?","gravatar_id":"18a83f753fa76b3ea0d594247f4c93b1","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":455600,"name":"hhvm","full_name":"facebook/hhvm","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?","gravatar_id":"18a83f753fa76b3ea0d594247f4c93b1","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/hhvm","description":"HHVM is an open-source virtual machine designed for executing programs written in Hack and PHP. HHVM uses a just-in-time (JIT) compilation approach to achieve superior performance while maintaining the flexibility that PHP developers are accustomed to.","fork":false,"url":"https://api.github.com/repos/facebook/hhvm","forks_url":"https://api.github.com/repos/facebook/hhvm/forks","keys_url":"https://api.github.com/repos/facebook/hhvm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/hhvm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/hhvm/teams","hooks_url":"https://api.github.com/repos/facebook/hhvm/hooks","issue_events_url":"https://api.github.com/repos/facebook/hhvm/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/hhvm/events","assignees_url":"https://api.github.com/repos/facebook/hhvm/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/hhvm/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/hhvm/tags","blobs_url":"https://api.github.com/repos/facebook/hhvm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/hhvm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/hhvm/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/hhvm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/hhvm/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/hhvm/languages","stargazers_url":"https://api.github.com/repos/facebook/hhvm/stargazers","contributors_url":"https://api.github.com/repos/facebook/hhvm/contributors","subscribers_url":"https://api.github.com/repos/facebook/hhvm/subscribers","subscription_url":"https://api.github.com/repos/facebook/hhvm/subscription","commits_url":"https://api.github.com/repos/facebook/hhvm/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/hhvm/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/hhvm/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/hhvm/issues/comments/{number}","contents_url":"https://api.github.com/repos/facebook/hhvm/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/hhvm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/hhvm/merges","archive_url":"https://api.github.com/repos/facebook/hhvm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/hhvm/downloads","issues_url":"https://api.github.com/repos/facebook/hhvm/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/hhvm/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/hhvm/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/hhvm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/hhvm/labels{/name}","releases_url":"https://api.github.com/repos/facebook/hhvm/releases{/id}","created_at":"2010-01-02T01:17:06Z","updated_at":"2014-07-15T19:22:53Z","pushed_at":"2014-07-15T19:11:39Z","git_url":"git://github.com/facebook/hhvm.git","ssh_url":"git@github.com:facebook/hhvm.git","clone_url":"https://github.com/facebook/hhvm.git","svn_url":"https://github.com/facebook/hhvm","homepage":"http://hhvm.com","size":251106,"stargazers_count":9377,"watchers_count":9377,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":true,"forks_count":1570,"mirror_url":null,"open_issues_count":334,"forks":1570,"open_issues":334,"watchers":9377,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/hhvm/pulls/2920"},"html":{"href":"https://github.com/facebook/hhvm/pull/2920"},"issue":{"href":"https://api.github.com/repos/facebook/hhvm/issues/2920"},"comments":{"href":"https://api.github.com/repos/facebook/hhvm/issues/2920/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/hhvm/pulls/2920/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/hhvm/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/facebook/hhvm/pulls/2920/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/hhvm/statuses/0d0c227bd395ab7fa76e8cc49cddb27ea5c71e2b"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":12,"review_comments":7,"commits":3,"additions":84,"deletions":64,"changed_files":3}}