GitHub PullRequestReviewCommentEvent at 2014-04-22 18:23:35
Repository: juju-gui
Actor: mitechie
Payload: {"comment":{"url":"https://api.github.com/repos/juju/juju-gui/pulls/comments/11867994","id":11867994,"diff_hunk":"@@ -922,9 +926,16 @@ YUI.add('juju-topology-relation', function(Y) {\n       topo.bindAllD3Events();\n       // Fire event to add relation in juju.\n       // This needs to specify interface in the future.\n-      env.add_relation(endpoints[0], endpoints[1],\n-          Y.bind(this._addRelationCallback, this, module, relation_id)\n-      );\n+      if (window.flags.ecs) {","path":"app/views/topology/relation.js","position":20,"original_position":20,"commit_id":"f16c62daae5a6a564a4c3590067b6e66e860c305","original_commit_id":"f16c62daae5a6a564a4c3590067b6e66e860c305","user":{"login":"mitechie","id":75915,"avatar_url":"https://avatars.githubusercontent.com/u/75915?","gravatar_id":"1641c0f988b844f44de596fcef3adc62","url":"https://api.github.com/users/mitechie","html_url":"https://github.com/mitechie","followers_url":"https://api.github.com/users/mitechie/followers","following_url":"https://api.github.com/users/mitechie/following{/other_user}","gists_url":"https://api.github.com/users/mitechie/gists{/gist_id}","starred_url":"https://api.github.com/users/mitechie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitechie/subscriptions","organizations_url":"https://api.github.com/users/mitechie/orgs","repos_url":"https://api.github.com/users/mitechie/repos","events_url":"https://api.github.com/users/mitechie/events{/privacy}","received_events_url":"https://api.github.com/users/mitechie/received_events","type":"User","site_admin":false},"body":"But at which point can we escape the 'how it has always been done' model? This is new functionality that's not directly tied to how the topology works at all. We could even go so far as to call a method on the env if you want to. It's a bit insane how much tied knowledge is done between these two things. So skip the event. Just make add_relation use the ecs and not the topo itself?","created_at":"2014-04-22T18:23:35Z","updated_at":"2014-04-22T18:23:35Z","html_url":"https://github.com/juju/juju-gui/pull/253#discussion_r11867994","pull_request_url":"https://api.github.com/repos/juju/juju-gui/pulls/253","_links":{"self":{"href":"https://api.github.com/repos/juju/juju-gui/pulls/comments/11867994"},"html":{"href":"https://github.com/juju/juju-gui/pull/253#discussion_r11867994"},"pull_request":{"href":"https://api.github.com/repos/juju/juju-gui/pulls/253"}}}}