GitHub PullRequestReviewCommentEvent at 2014-08-12 21:40:07
Repository: finagle
Actor: suncelesta
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/twitter/finagle/pulls/comments/16144776","id":16144776,"diff_hunk":"@@ -0,0 +1,85 @@\n+package com.twitter.finagle\n+\n+import com.twitter.finagle.client.{DefaultClient, Bridge}\n+import com.twitter.finagle.smtp._\n+import com.twitter.finagle.smtp.filter.{MailFilter, HeadersFilter, DataFilter}\n+import com.twitter.finagle.smtp.reply._\n+import com.twitter.finagle.smtp.transport.SmtpTransporter\n+import com.twitter.util.{Time, Future}\n+\n+// TODO: switch to StackClient\n+\n+/**\n+ * Implements an SMTP client. This type of client is capable of sending\n+ * separate SMTP commands and receiving replies to them.\n+ */\n+object Smtp extends Client[Request, Reply]{\n+\n+  private[this] val defaultClient = DefaultClient[Request, Reply] (\n+    name = \"smtp\",\n+    endpointer = {\n+      val bridge = Bridge[Request, UnspecifiedReply, Request, Reply](\n+        SmtpTransporter, new SmtpClientDispatcher(_)\n+      )\n+      (addr, stats) => bridge(addr, stats)\n+    })\n+\n+  /**\n+   * Constructs an SMTP client.\n+   *\n+   * Upon closing the connection this client sends QUIT command;\n+   * it also performs dot stuffing.\n+   */\n+  override def newClient(dest: Name, label: String): ServiceFactory[Request, Reply] = {\n+\n+    val quitOnCloseClient = {","path":"finagle-smtp/src/main/scala/com/twitter/finagle/Smtp.scala","position":35,"original_position":35,"commit_id":"caa31e3c9e33fb7d5a9a89af4af877ec3d503b7c","original_commit_id":"caa31e3c9e33fb7d5a9a89af4af877ec3d503b7c","user":{"login":"suncelesta","id":3384412,"avatar_url":"https://avatars.githubusercontent.com/u/3384412?v=2","gravatar_id":"4f6085f954d26ef2d06c74839a75a150","url":"https://api.github.com/users/suncelesta","html_url":"https://github.com/suncelesta","followers_url":"https://api.github.com/users/suncelesta/followers","following_url":"https://api.github.com/users/suncelesta/following{/other_user}","gists_url":"https://api.github.com/users/suncelesta/gists{/gist_id}","starred_url":"https://api.github.com/users/suncelesta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suncelesta/subscriptions","organizations_url":"https://api.github.com/users/suncelesta/orgs","repos_url":"https://api.github.com/users/suncelesta/repos","events_url":"https://api.github.com/users/suncelesta/events{/privacy}","received_events_url":"https://api.github.com/users/suncelesta/received_events","type":"User","site_admin":false},"body":"It's what I've recently pushed (look below), and it has correct behavior.","created_at":"2014-08-12T21:40:07Z","updated_at":"2014-08-12T21:40:07Z","html_url":"https://github.com/twitter/finagle/pull/287#discussion_r16144776","pull_request_url":"https://api.github.com/repos/twitter/finagle/pulls/287","_links":{"self":{"href":"https://api.github.com/repos/twitter/finagle/pulls/comments/16144776"},"html":{"href":"https://github.com/twitter/finagle/pull/287#discussion_r16144776"},"pull_request":{"href":"https://api.github.com/repos/twitter/finagle/pulls/287"}}},"pull_request":{"url":"https://api.github.com/repos/twitter/finagle/pulls/287","id":17611457,"html_url":"https://github.com/twitter/finagle/pull/287","diff_url":"https://github.com/twitter/finagle/pull/287.diff","patch_url":"https://github.com/twitter/finagle/pull/287.patch","issue_url":"https://api.github.com/repos/twitter/finagle/issues/287","number":287,"state":"open","title":"GSoC: finagle-smtp - initial","user":{"login":"suncelesta","id":3384412,"avatar_url":"https://avatars.githubusercontent.com/u/3384412?v=2","gravatar_id":"4f6085f954d26ef2d06c74839a75a150","url":"https://api.github.com/users/suncelesta","html_url":"https://github.com/suncelesta","followers_url":"https://api.github.com/users/suncelesta/followers","following_url":"https://api.github.com/users/suncelesta/following{/other_user}","gists_url":"https://api.github.com/users/suncelesta/gists{/gist_id}","starred_url":"https://api.github.com/users/suncelesta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suncelesta/subscriptions","organizations_url":"https://api.github.com/users/suncelesta/orgs","repos_url":"https://api.github.com/users/suncelesta/repos","events_url":"https://api.github.com/users/suncelesta/events{/privacy}","received_events_url":"https://api.github.com/users/suncelesta/received_events","type":"User","site_admin":false},"body":"This is initial version of SMTP client for Finagle, which I am working on during GSoC'14.\r\nFor now it supports sending independent commands to SMTP server and sending a simple text email to one ore more addresses (without cc, bcc and reply-to). Usage is described in `README.md`. ","created_at":"2014-06-25T19:36:33Z","updated_at":"2014-08-12T21:40:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"07f408ef3f4c0b38d1f0fd6fd71bdcc0773be74a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/twitter/finagle/pulls/287/commits","review_comments_url":"https://api.github.com/repos/twitter/finagle/pulls/287/comments","review_comment_url":"https://api.github.com/repos/twitter/finagle/pulls/comments/{number}","comments_url":"https://api.github.com/repos/twitter/finagle/issues/287/comments","statuses_url":"https://api.github.com/repos/twitter/finagle/statuses/caa31e3c9e33fb7d5a9a89af4af877ec3d503b7c","head":{"label":"suncelesta:finagle-smtp","ref":"finagle-smtp","sha":"caa31e3c9e33fb7d5a9a89af4af877ec3d503b7c","user":{"login":"suncelesta","id":3384412,"avatar_url":"https://avatars.githubusercontent.com/u/3384412?v=2","gravatar_id":"4f6085f954d26ef2d06c74839a75a150","url":"https://api.github.com/users/suncelesta","html_url":"https://github.com/suncelesta","followers_url":"https://api.github.com/users/suncelesta/followers","following_url":"https://api.github.com/users/suncelesta/following{/other_user}","gists_url":"https://api.github.com/users/suncelesta/gists{/gist_id}","starred_url":"https://api.github.com/users/suncelesta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suncelesta/subscriptions","organizations_url":"https://api.github.com/users/suncelesta/orgs","repos_url":"https://api.github.com/users/suncelesta/repos","events_url":"https://api.github.com/users/suncelesta/events{/privacy}","received_events_url":"https://api.github.com/users/suncelesta/received_events","type":"User","site_admin":false},"repo":{"id":17537502,"name":"finagle","full_name":"suncelesta/finagle","owner":{"login":"suncelesta","id":3384412,"avatar_url":"https://avatars.githubusercontent.com/u/3384412?v=2","gravatar_id":"4f6085f954d26ef2d06c74839a75a150","url":"https://api.github.com/users/suncelesta","html_url":"https://github.com/suncelesta","followers_url":"https://api.github.com/users/suncelesta/followers","following_url":"https://api.github.com/users/suncelesta/following{/other_user}","gists_url":"https://api.github.com/users/suncelesta/gists{/gist_id}","starred_url":"https://api.github.com/users/suncelesta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suncelesta/subscriptions","organizations_url":"https://api.github.com/users/suncelesta/orgs","repos_url":"https://api.github.com/users/suncelesta/repos","events_url":"https://api.github.com/users/suncelesta/events{/privacy}","received_events_url":"https://api.github.com/users/suncelesta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/suncelesta/finagle","description":"A fault tolerant, protocol-agnostic RPC system","fork":true,"url":"https://api.github.com/repos/suncelesta/finagle","forks_url":"https://api.github.com/repos/suncelesta/finagle/forks","keys_url":"https://api.github.com/repos/suncelesta/finagle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/suncelesta/finagle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/suncelesta/finagle/teams","hooks_url":"https://api.github.com/repos/suncelesta/finagle/hooks","issue_events_url":"https://api.github.com/repos/suncelesta/finagle/issues/events{/number}","events_url":"https://api.github.com/repos/suncelesta/finagle/events","assignees_url":"https://api.github.com/repos/suncelesta/finagle/assignees{/user}","branches_url":"https://api.github.com/repos/suncelesta/finagle/branches{/branch}","tags_url":"https://api.github.com/repos/suncelesta/finagle/tags","blobs_url":"https://api.github.com/repos/suncelesta/finagle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/suncelesta/finagle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/suncelesta/finagle/git/refs{/sha}","trees_url":"https://api.github.com/repos/suncelesta/finagle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/suncelesta/finagle/statuses/{sha}","languages_url":"https://api.github.com/repos/suncelesta/finagle/languages","stargazers_url":"https://api.github.com/repos/suncelesta/finagle/stargazers","contributors_url":"https://api.github.com/repos/suncelesta/finagle/contributors","subscribers_url":"https://api.github.com/repos/suncelesta/finagle/subscribers","subscription_url":"https://api.github.com/repos/suncelesta/finagle/subscription","commits_url":"https://api.github.com/repos/suncelesta/finagle/commits{/sha}","git_commits_url":"https://api.github.com/repos/suncelesta/finagle/git/commits{/sha}","comments_url":"https://api.github.com/repos/suncelesta/finagle/comments{/number}","issue_comment_url":"https://api.github.com/repos/suncelesta/finagle/issues/comments/{number}","contents_url":"https://api.github.com/repos/suncelesta/finagle/contents/{+path}","compare_url":"https://api.github.com/repos/suncelesta/finagle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/suncelesta/finagle/merges","archive_url":"https://api.github.com/repos/suncelesta/finagle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/suncelesta/finagle/downloads","issues_url":"https://api.github.com/repos/suncelesta/finagle/issues{/number}","pulls_url":"https://api.github.com/repos/suncelesta/finagle/pulls{/number}","milestones_url":"https://api.github.com/repos/suncelesta/finagle/milestones{/number}","notifications_url":"https://api.github.com/repos/suncelesta/finagle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/suncelesta/finagle/labels{/name}","releases_url":"https://api.github.com/repos/suncelesta/finagle/releases{/id}","created_at":"2014-03-08T07:36:08Z","updated_at":"2014-06-25T10:32:56Z","pushed_at":"2014-08-12T21:26:52Z","git_url":"git://github.com/suncelesta/finagle.git","ssh_url":"git@github.com:suncelesta/finagle.git","clone_url":"https://github.com/suncelesta/finagle.git","svn_url":"https://github.com/suncelesta/finagle","homepage":"http://twitter.github.io/finagle","size":17773,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"twitter:master","ref":"master","sha":"84e36f37a76f488d16e18ae827d6b8fa2a8be8ef","user":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=2","gravatar_id":"2f4a8254d032a8ec5e4c48d461e54fcc","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"repo":{"id":1007362,"name":"finagle","full_name":"twitter/finagle","owner":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=2","gravatar_id":"2f4a8254d032a8ec5e4c48d461e54fcc","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twitter/finagle","description":"A fault tolerant, protocol-agnostic RPC system","fork":false,"url":"https://api.github.com/repos/twitter/finagle","forks_url":"https://api.github.com/repos/twitter/finagle/forks","keys_url":"https://api.github.com/repos/twitter/finagle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twitter/finagle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twitter/finagle/teams","hooks_url":"https://api.github.com/repos/twitter/finagle/hooks","issue_events_url":"https://api.github.com/repos/twitter/finagle/issues/events{/number}","events_url":"https://api.github.com/repos/twitter/finagle/events","assignees_url":"https://api.github.com/repos/twitter/finagle/assignees{/user}","branches_url":"https://api.github.com/repos/twitter/finagle/branches{/branch}","tags_url":"https://api.github.com/repos/twitter/finagle/tags","blobs_url":"https://api.github.com/repos/twitter/finagle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twitter/finagle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twitter/finagle/git/refs{/sha}","trees_url":"https://api.github.com/repos/twitter/finagle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twitter/finagle/statuses/{sha}","languages_url":"https://api.github.com/repos/twitter/finagle/languages","stargazers_url":"https://api.github.com/repos/twitter/finagle/stargazers","contributors_url":"https://api.github.com/repos/twitter/finagle/contributors","subscribers_url":"https://api.github.com/repos/twitter/finagle/subscribers","subscription_url":"https://api.github.com/repos/twitter/finagle/subscription","commits_url":"https://api.github.com/repos/twitter/finagle/commits{/sha}","git_commits_url":"https://api.github.com/repos/twitter/finagle/git/commits{/sha}","comments_url":"https://api.github.com/repos/twitter/finagle/comments{/number}","issue_comment_url":"https://api.github.com/repos/twitter/finagle/issues/comments/{number}","contents_url":"https://api.github.com/repos/twitter/finagle/contents/{+path}","compare_url":"https://api.github.com/repos/twitter/finagle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twitter/finagle/merges","archive_url":"https://api.github.com/repos/twitter/finagle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twitter/finagle/downloads","issues_url":"https://api.github.com/repos/twitter/finagle/issues{/number}","pulls_url":"https://api.github.com/repos/twitter/finagle/pulls{/number}","milestones_url":"https://api.github.com/repos/twitter/finagle/milestones{/number}","notifications_url":"https://api.github.com/repos/twitter/finagle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twitter/finagle/labels{/name}","releases_url":"https://api.github.com/repos/twitter/finagle/releases{/id}","created_at":"2010-10-19T22:10:09Z","updated_at":"2014-08-12T21:03:06Z","pushed_at":"2014-08-06T15:26:45Z","git_url":"git://github.com/twitter/finagle.git","ssh_url":"git@github.com:twitter/finagle.git","clone_url":"https://github.com/twitter/finagle.git","svn_url":"https://github.com/twitter/finagle","homepage":"http://twitter.github.io/finagle","size":26409,"stargazers_count":2749,"watchers_count":2749,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":476,"mirror_url":null,"open_issues_count":41,"forks":476,"open_issues":41,"watchers":2749,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/twitter/finagle/pulls/287"},"html":{"href":"https://github.com/twitter/finagle/pull/287"},"issue":{"href":"https://api.github.com/repos/twitter/finagle/issues/287"},"comments":{"href":"https://api.github.com/repos/twitter/finagle/issues/287/comments"},"review_comments":{"href":"https://api.github.com/repos/twitter/finagle/pulls/287/comments"},"review_comment":{"href":"https://api.github.com/repos/twitter/finagle/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/twitter/finagle/pulls/287/commits"},"statuses":{"href":"https://api.github.com/repos/twitter/finagle/statuses/caa31e3c9e33fb7d5a9a89af4af877ec3d503b7c"}}}}