GitHub PullRequestReviewCommentEvent at 2014-11-26 13:54:39
Repository: clean-iOS-architecture-generator
Actor: houndci
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/pulls/comments/20935420","id":20935420,"diff_hunk":"@@ -0,0 +1,126 @@\n+require 'spec_helper'\n+include IOSGen::Base\n+\n+describe IOSGen::Base::Interactor do\n+\n+  description = 'Api Interactions required by Notification ViewModel'\n+\n+  name = 'FJBNotificationsApiInteractor'\n+\n+  properties = [Property.new(type: 'TestType', name: 'TestName'),\n+                Property.new(type: 'TestType2', name: 'TestName2')]\n+\n+  action = Action.new(description: 'Perform API request to mark a notification as read',\n+                      return_type: 'void',\n+                      name: 'markNotificationAsRead:onCompletionBlock:',\n+                      arguments: [Property.new(type: 'NSString', name: 'notificationId'),\n+                                  Property.new(type: '^()', name: 'completionBlock')])\n+  actions = [action]\n+\n+  describe '#Properties' do\n+    interactor = described_class.new(description: description,\n+                                     name: name,\n+                                     properties: properties,\n+                                     actions: actions)\n+\n+    it 'has a description' do\n+      expect(interactor.description).to eq(description)\n+    end\n+\n+    it 'has a name' do\n+      expect(interactor.name).to eq(name)\n+    end\n+\n+    it 'has properties' do\n+      expect(interactor.properties).to be_a Array\n+      expect(interactor.properties.length).to eq(2)\n+      property1 = interactor.properties[0]\n+      property2 = interactor.properties[1]\n+      expect(property1).to be_a Property\n+      expect(property2).to be_a Property\n+    end\n+\n+    it 'has actions' do","path":"spec/ios_gen/base/interactor_spec.rb","position":43,"original_position":43,"commit_id":"e42c316e447752144541811e249bfb7b5fef0bbb","original_commit_id":"e42c316e447752144541811e249bfb7b5fef0bbb","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.","created_at":"2014-11-26T13:54:39Z","updated_at":"2014-11-26T13:54:39Z","html_url":"https://github.com/fjbelchi/clean-iOS-architecture-generator/pull/11#discussion_r20935420","pull_request_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/pulls/11","_links":{"self":{"href":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/pulls/comments/20935420"},"html":{"href":"https://github.com/fjbelchi/clean-iOS-architecture-generator/pull/11#discussion_r20935420"},"pull_request":{"href":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/pulls/11","id":25085007,"html_url":"https://github.com/fjbelchi/clean-iOS-architecture-generator/pull/11","diff_url":"https://github.com/fjbelchi/clean-iOS-architecture-generator/pull/11.diff","patch_url":"https://github.com/fjbelchi/clean-iOS-architecture-generator/pull/11.patch","issue_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/issues/11","number":11,"state":"open","locked":false,"title":"Issue 1","user":{"login":"fjbelchi","id":626713,"avatar_url":"https://avatars.githubusercontent.com/u/626713?v=3","gravatar_id":"","url":"https://api.github.com/users/fjbelchi","html_url":"https://github.com/fjbelchi","followers_url":"https://api.github.com/users/fjbelchi/followers","following_url":"https://api.github.com/users/fjbelchi/following{/other_user}","gists_url":"https://api.github.com/users/fjbelchi/gists{/gist_id}","starred_url":"https://api.github.com/users/fjbelchi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjbelchi/subscriptions","organizations_url":"https://api.github.com/users/fjbelchi/orgs","repos_url":"https://api.github.com/users/fjbelchi/repos","events_url":"https://api.github.com/users/fjbelchi/events{/privacy}","received_events_url":"https://api.github.com/users/fjbelchi/received_events","type":"User","site_admin":false},"body":"fix #1 ","created_at":"2014-11-26T13:54:21Z","updated_at":"2014-11-26T13:54:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86342f08bb27cc2617d8fa5556f948ddc23e9675","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/pulls/11/commits","review_comments_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/pulls/11/comments","review_comment_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/pulls/comments/{number}","comments_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/issues/11/comments","statuses_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/statuses/e42c316e447752144541811e249bfb7b5fef0bbb","head":{"label":"fjbelchi:Issue-1","ref":"Issue-1","sha":"e42c316e447752144541811e249bfb7b5fef0bbb","user":{"login":"fjbelchi","id":626713,"avatar_url":"https://avatars.githubusercontent.com/u/626713?v=3","gravatar_id":"","url":"https://api.github.com/users/fjbelchi","html_url":"https://github.com/fjbelchi","followers_url":"https://api.github.com/users/fjbelchi/followers","following_url":"https://api.github.com/users/fjbelchi/following{/other_user}","gists_url":"https://api.github.com/users/fjbelchi/gists{/gist_id}","starred_url":"https://api.github.com/users/fjbelchi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjbelchi/subscriptions","organizations_url":"https://api.github.com/users/fjbelchi/orgs","repos_url":"https://api.github.com/users/fjbelchi/repos","events_url":"https://api.github.com/users/fjbelchi/events{/privacy}","received_events_url":"https://api.github.com/users/fjbelchi/received_events","type":"User","site_admin":false},"repo":{"id":26745475,"name":"clean-iOS-architecture-generator","full_name":"fjbelchi/clean-iOS-architecture-generator","owner":{"login":"fjbelchi","id":626713,"avatar_url":"https://avatars.githubusercontent.com/u/626713?v=3","gravatar_id":"","url":"https://api.github.com/users/fjbelchi","html_url":"https://github.com/fjbelchi","followers_url":"https://api.github.com/users/fjbelchi/followers","following_url":"https://api.github.com/users/fjbelchi/following{/other_user}","gists_url":"https://api.github.com/users/fjbelchi/gists{/gist_id}","starred_url":"https://api.github.com/users/fjbelchi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjbelchi/subscriptions","organizations_url":"https://api.github.com/users/fjbelchi/orgs","repos_url":"https://api.github.com/users/fjbelchi/repos","events_url":"https://api.github.com/users/fjbelchi/events{/privacy}","received_events_url":"https://api.github.com/users/fjbelchi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fjbelchi/clean-iOS-architecture-generator","description":"Ruby gem to generate a clean iOS architecture","fork":false,"url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator","forks_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/forks","keys_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/teams","hooks_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/hooks","issue_events_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/issues/events{/number}","events_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/events","assignees_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/assignees{/user}","branches_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/branches{/branch}","tags_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/tags","blobs_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/git/refs{/sha}","trees_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/statuses/{sha}","languages_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/languages","stargazers_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/stargazers","contributors_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/contributors","subscribers_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/subscribers","subscription_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/subscription","commits_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/commits{/sha}","git_commits_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/git/commits{/sha}","comments_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/comments{/number}","issue_comment_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/issues/comments/{number}","contents_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/contents/{+path}","compare_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/merges","archive_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/downloads","issues_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/issues{/number}","pulls_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/pulls{/number}","milestones_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/milestones{/number}","notifications_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/labels{/name}","releases_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/releases{/id}","created_at":"2014-11-17T07:38:51Z","updated_at":"2014-11-25T08:53:56Z","pushed_at":"2014-11-26T13:53:43Z","git_url":"git://github.com/fjbelchi/clean-iOS-architecture-generator.git","ssh_url":"git@github.com:fjbelchi/clean-iOS-architecture-generator.git","clone_url":"https://github.com/fjbelchi/clean-iOS-architecture-generator.git","svn_url":"https://github.com/fjbelchi/clean-iOS-architecture-generator","homepage":null,"size":376,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":7,"forks":0,"open_issues":7,"watchers":0,"default_branch":"master"}},"base":{"label":"fjbelchi:master","ref":"master","sha":"bbaa3ff3d98f8cb6ca90743b77c4f11e9dba134c","user":{"login":"fjbelchi","id":626713,"avatar_url":"https://avatars.githubusercontent.com/u/626713?v=3","gravatar_id":"","url":"https://api.github.com/users/fjbelchi","html_url":"https://github.com/fjbelchi","followers_url":"https://api.github.com/users/fjbelchi/followers","following_url":"https://api.github.com/users/fjbelchi/following{/other_user}","gists_url":"https://api.github.com/users/fjbelchi/gists{/gist_id}","starred_url":"https://api.github.com/users/fjbelchi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjbelchi/subscriptions","organizations_url":"https://api.github.com/users/fjbelchi/orgs","repos_url":"https://api.github.com/users/fjbelchi/repos","events_url":"https://api.github.com/users/fjbelchi/events{/privacy}","received_events_url":"https://api.github.com/users/fjbelchi/received_events","type":"User","site_admin":false},"repo":{"id":26745475,"name":"clean-iOS-architecture-generator","full_name":"fjbelchi/clean-iOS-architecture-generator","owner":{"login":"fjbelchi","id":626713,"avatar_url":"https://avatars.githubusercontent.com/u/626713?v=3","gravatar_id":"","url":"https://api.github.com/users/fjbelchi","html_url":"https://github.com/fjbelchi","followers_url":"https://api.github.com/users/fjbelchi/followers","following_url":"https://api.github.com/users/fjbelchi/following{/other_user}","gists_url":"https://api.github.com/users/fjbelchi/gists{/gist_id}","starred_url":"https://api.github.com/users/fjbelchi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjbelchi/subscriptions","organizations_url":"https://api.github.com/users/fjbelchi/orgs","repos_url":"https://api.github.com/users/fjbelchi/repos","events_url":"https://api.github.com/users/fjbelchi/events{/privacy}","received_events_url":"https://api.github.com/users/fjbelchi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fjbelchi/clean-iOS-architecture-generator","description":"Ruby gem to generate a clean iOS architecture","fork":false,"url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator","forks_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/forks","keys_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/teams","hooks_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/hooks","issue_events_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/issues/events{/number}","events_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/events","assignees_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/assignees{/user}","branches_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/branches{/branch}","tags_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/tags","blobs_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/git/refs{/sha}","trees_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/statuses/{sha}","languages_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/languages","stargazers_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/stargazers","contributors_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/contributors","subscribers_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/subscribers","subscription_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/subscription","commits_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/commits{/sha}","git_commits_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/git/commits{/sha}","comments_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/comments{/number}","issue_comment_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/issues/comments/{number}","contents_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/contents/{+path}","compare_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/merges","archive_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/downloads","issues_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/issues{/number}","pulls_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/pulls{/number}","milestones_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/milestones{/number}","notifications_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/labels{/name}","releases_url":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/releases{/id}","created_at":"2014-11-17T07:38:51Z","updated_at":"2014-11-25T08:53:56Z","pushed_at":"2014-11-26T13:53:43Z","git_url":"git://github.com/fjbelchi/clean-iOS-architecture-generator.git","ssh_url":"git@github.com:fjbelchi/clean-iOS-architecture-generator.git","clone_url":"https://github.com/fjbelchi/clean-iOS-architecture-generator.git","svn_url":"https://github.com/fjbelchi/clean-iOS-architecture-generator","homepage":null,"size":376,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":7,"forks":0,"open_issues":7,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/pulls/11"},"html":{"href":"https://github.com/fjbelchi/clean-iOS-architecture-generator/pull/11"},"issue":{"href":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/issues/11"},"comments":{"href":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/fjbelchi/clean-iOS-architecture-generator/statuses/e42c316e447752144541811e249bfb7b5fef0bbb"}}}}