GitHub PullRequestEvent at 2014-08-28 02:20:55
Repository: generator-cpui
Actor: 8bitDesigner
Payload: {"action":"opened","number":8,"pull_request":{"url":"https://api.github.com/repos/Fullscreen/generator-cpui/pulls/8","id":20414300,"html_url":"https://github.com/Fullscreen/generator-cpui/pull/8","diff_url":"https://github.com/Fullscreen/generator-cpui/pull/8.diff","patch_url":"https://github.com/Fullscreen/generator-cpui/pull/8.patch","issue_url":"https://api.github.com/repos/Fullscreen/generator-cpui/issues/8","number":8,"state":"open","locked":false,"title":"Fix routes","user":{"login":"8bitDesigner","id":139790,"avatar_url":"https://avatars.githubusercontent.com/u/139790?v=2","gravatar_id":"e22310aa39101a767542fd659830caef","url":"https://api.github.com/users/8bitDesigner","html_url":"https://github.com/8bitDesigner","followers_url":"https://api.github.com/users/8bitDesigner/followers","following_url":"https://api.github.com/users/8bitDesigner/following{/other_user}","gists_url":"https://api.github.com/users/8bitDesigner/gists{/gist_id}","starred_url":"https://api.github.com/users/8bitDesigner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/8bitDesigner/subscriptions","organizations_url":"https://api.github.com/users/8bitDesigner/orgs","repos_url":"https://api.github.com/users/8bitDesigner/repos","events_url":"https://api.github.com/users/8bitDesigner/events{/privacy}","received_events_url":"https://api.github.com/users/8bitDesigner/received_events","type":"User","site_admin":false},"body":"A few things here:\r\n\r\n1. When you called a generator without a config previously, it would create the config and then exit without doing what you initially asked the generator to do, [so that's fixed]\r\n2. There was [an early exit in a getModule() check] which should also be fixed\r\n3. The Great Un-`self`-ing, in which I killed the `self = undefined` pattern, as\r\n  * jshint was getting gripey about it\r\n  * `var self = this` is the preferred JS syntax. `varname = undefined` is a Coffescript-ism that's needed due to its weird ass scoping rules.","created_at":"2014-08-28T02:20:54Z","updated_at":"2014-08-28T02:20:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Fullscreen/generator-cpui/pulls/8/commits","review_comments_url":"https://api.github.com/repos/Fullscreen/generator-cpui/pulls/8/comments","review_comment_url":"https://api.github.com/repos/Fullscreen/generator-cpui/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Fullscreen/generator-cpui/issues/8/comments","statuses_url":"https://api.github.com/repos/Fullscreen/generator-cpui/statuses/c1632a07b11e56a6e72dfd3c78fa272bcadd4408","head":{"label":"Fullscreen:fix-routes","ref":"fix-routes","sha":"c1632a07b11e56a6e72dfd3c78fa272bcadd4408","user":{"login":"Fullscreen","id":682200,"avatar_url":"https://avatars.githubusercontent.com/u/682200?v=2","gravatar_id":"224f077ce541f028790ce6e46fc5871c","url":"https://api.github.com/users/Fullscreen","html_url":"https://github.com/Fullscreen","followers_url":"https://api.github.com/users/Fullscreen/followers","following_url":"https://api.github.com/users/Fullscreen/following{/other_user}","gists_url":"https://api.github.com/users/Fullscreen/gists{/gist_id}","starred_url":"https://api.github.com/users/Fullscreen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fullscreen/subscriptions","organizations_url":"https://api.github.com/users/Fullscreen/orgs","repos_url":"https://api.github.com/users/Fullscreen/repos","events_url":"https://api.github.com/users/Fullscreen/events{/privacy}","received_events_url":"https://api.github.com/users/Fullscreen/received_events","type":"Organization","site_admin":false},"repo":{"id":20820520,"name":"generator-cpui","full_name":"Fullscreen/generator-cpui","owner":{"login":"Fullscreen","id":682200,"avatar_url":"https://avatars.githubusercontent.com/u/682200?v=2","gravatar_id":"224f077ce541f028790ce6e46fc5871c","url":"https://api.github.com/users/Fullscreen","html_url":"https://github.com/Fullscreen","followers_url":"https://api.github.com/users/Fullscreen/followers","following_url":"https://api.github.com/users/Fullscreen/following{/other_user}","gists_url":"https://api.github.com/users/Fullscreen/gists{/gist_id}","starred_url":"https://api.github.com/users/Fullscreen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fullscreen/subscriptions","organizations_url":"https://api.github.com/users/Fullscreen/orgs","repos_url":"https://api.github.com/users/Fullscreen/repos","events_url":"https://api.github.com/users/Fullscreen/events{/privacy}","received_events_url":"https://api.github.com/users/Fullscreen/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Fullscreen/generator-cpui","description":"Custom code generator for Creator Platform Angular modules","fork":false,"url":"https://api.github.com/repos/Fullscreen/generator-cpui","forks_url":"https://api.github.com/repos/Fullscreen/generator-cpui/forks","keys_url":"https://api.github.com/repos/Fullscreen/generator-cpui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Fullscreen/generator-cpui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Fullscreen/generator-cpui/teams","hooks_url":"https://api.github.com/repos/Fullscreen/generator-cpui/hooks","issue_events_url":"https://api.github.com/repos/Fullscreen/generator-cpui/issues/events{/number}","events_url":"https://api.github.com/repos/Fullscreen/generator-cpui/events","assignees_url":"https://api.github.com/repos/Fullscreen/generator-cpui/assignees{/user}","branches_url":"https://api.github.com/repos/Fullscreen/generator-cpui/branches{/branch}","tags_url":"https://api.github.com/repos/Fullscreen/generator-cpui/tags","blobs_url":"https://api.github.com/repos/Fullscreen/generator-cpui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Fullscreen/generator-cpui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Fullscreen/generator-cpui/git/refs{/sha}","trees_url":"https://api.github.com/repos/Fullscreen/generator-cpui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Fullscreen/generator-cpui/statuses/{sha}","languages_url":"https://api.github.com/repos/Fullscreen/generator-cpui/languages","stargazers_url":"https://api.github.com/repos/Fullscreen/generator-cpui/stargazers","contributors_url":"https://api.github.com/repos/Fullscreen/generator-cpui/contributors","subscribers_url":"https://api.github.com/repos/Fullscreen/generator-cpui/subscribers","subscription_url":"https://api.github.com/repos/Fullscreen/generator-cpui/subscription","commits_url":"https://api.github.com/repos/Fullscreen/generator-cpui/commits{/sha}","git_commits_url":"https://api.github.com/repos/Fullscreen/generator-cpui/git/commits{/sha}","comments_url":"https://api.github.com/repos/Fullscreen/generator-cpui/comments{/number}","issue_comment_url":"https://api.github.com/repos/Fullscreen/generator-cpui/issues/comments/{number}","contents_url":"https://api.github.com/repos/Fullscreen/generator-cpui/contents/{+path}","compare_url":"https://api.github.com/repos/Fullscreen/generator-cpui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Fullscreen/generator-cpui/merges","archive_url":"https://api.github.com/repos/Fullscreen/generator-cpui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Fullscreen/generator-cpui/downloads","issues_url":"https://api.github.com/repos/Fullscreen/generator-cpui/issues{/number}","pulls_url":"https://api.github.com/repos/Fullscreen/generator-cpui/pulls{/number}","milestones_url":"https://api.github.com/repos/Fullscreen/generator-cpui/milestones{/number}","notifications_url":"https://api.github.com/repos/Fullscreen/generator-cpui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Fullscreen/generator-cpui/labels{/name}","releases_url":"https://api.github.com/repos/Fullscreen/generator-cpui/releases{/id}","created_at":"2014-06-13T23:18:12Z","updated_at":"2014-08-20T21:20:44Z","pushed_at":"2014-08-28T02:14:38Z","git_url":"git://github.com/Fullscreen/generator-cpui.git","ssh_url":"git@github.com:Fullscreen/generator-cpui.git","clone_url":"https://github.com/Fullscreen/generator-cpui.git","svn_url":"https://github.com/Fullscreen/generator-cpui","homepage":null,"size":783,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":1,"default_branch":"master"}},"base":{"label":"Fullscreen:master","ref":"master","sha":"c590c76d7f81c065409349054ca80564230a91af","user":{"login":"Fullscreen","id":682200,"avatar_url":"https://avatars.githubusercontent.com/u/682200?v=2","gravatar_id":"224f077ce541f028790ce6e46fc5871c","url":"https://api.github.com/users/Fullscreen","html_url":"https://github.com/Fullscreen","followers_url":"https://api.github.com/users/Fullscreen/followers","following_url":"https://api.github.com/users/Fullscreen/following{/other_user}","gists_url":"https://api.github.com/users/Fullscreen/gists{/gist_id}","starred_url":"https://api.github.com/users/Fullscreen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fullscreen/subscriptions","organizations_url":"https://api.github.com/users/Fullscreen/orgs","repos_url":"https://api.github.com/users/Fullscreen/repos","events_url":"https://api.github.com/users/Fullscreen/events{/privacy}","received_events_url":"https://api.github.com/users/Fullscreen/received_events","type":"Organization","site_admin":false},"repo":{"id":20820520,"name":"generator-cpui","full_name":"Fullscreen/generator-cpui","owner":{"login":"Fullscreen","id":682200,"avatar_url":"https://avatars.githubusercontent.com/u/682200?v=2","gravatar_id":"224f077ce541f028790ce6e46fc5871c","url":"https://api.github.com/users/Fullscreen","html_url":"https://github.com/Fullscreen","followers_url":"https://api.github.com/users/Fullscreen/followers","following_url":"https://api.github.com/users/Fullscreen/following{/other_user}","gists_url":"https://api.github.com/users/Fullscreen/gists{/gist_id}","starred_url":"https://api.github.com/users/Fullscreen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fullscreen/subscriptions","organizations_url":"https://api.github.com/users/Fullscreen/orgs","repos_url":"https://api.github.com/users/Fullscreen/repos","events_url":"https://api.github.com/users/Fullscreen/events{/privacy}","received_events_url":"https://api.github.com/users/Fullscreen/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Fullscreen/generator-cpui","description":"Custom code generator for Creator Platform Angular modules","fork":false,"url":"https://api.github.com/repos/Fullscreen/generator-cpui","forks_url":"https://api.github.com/repos/Fullscreen/generator-cpui/forks","keys_url":"https://api.github.com/repos/Fullscreen/generator-cpui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Fullscreen/generator-cpui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Fullscreen/generator-cpui/teams","hooks_url":"https://api.github.com/repos/Fullscreen/generator-cpui/hooks","issue_events_url":"https://api.github.com/repos/Fullscreen/generator-cpui/issues/events{/number}","events_url":"https://api.github.com/repos/Fullscreen/generator-cpui/events","assignees_url":"https://api.github.com/repos/Fullscreen/generator-cpui/assignees{/user}","branches_url":"https://api.github.com/repos/Fullscreen/generator-cpui/branches{/branch}","tags_url":"https://api.github.com/repos/Fullscreen/generator-cpui/tags","blobs_url":"https://api.github.com/repos/Fullscreen/generator-cpui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Fullscreen/generator-cpui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Fullscreen/generator-cpui/git/refs{/sha}","trees_url":"https://api.github.com/repos/Fullscreen/generator-cpui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Fullscreen/generator-cpui/statuses/{sha}","languages_url":"https://api.github.com/repos/Fullscreen/generator-cpui/languages","stargazers_url":"https://api.github.com/repos/Fullscreen/generator-cpui/stargazers","contributors_url":"https://api.github.com/repos/Fullscreen/generator-cpui/contributors","subscribers_url":"https://api.github.com/repos/Fullscreen/generator-cpui/subscribers","subscription_url":"https://api.github.com/repos/Fullscreen/generator-cpui/subscription","commits_url":"https://api.github.com/repos/Fullscreen/generator-cpui/commits{/sha}","git_commits_url":"https://api.github.com/repos/Fullscreen/generator-cpui/git/commits{/sha}","comments_url":"https://api.github.com/repos/Fullscreen/generator-cpui/comments{/number}","issue_comment_url":"https://api.github.com/repos/Fullscreen/generator-cpui/issues/comments/{number}","contents_url":"https://api.github.com/repos/Fullscreen/generator-cpui/contents/{+path}","compare_url":"https://api.github.com/repos/Fullscreen/generator-cpui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Fullscreen/generator-cpui/merges","archive_url":"https://api.github.com/repos/Fullscreen/generator-cpui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Fullscreen/generator-cpui/downloads","issues_url":"https://api.github.com/repos/Fullscreen/generator-cpui/issues{/number}","pulls_url":"https://api.github.com/repos/Fullscreen/generator-cpui/pulls{/number}","milestones_url":"https://api.github.com/repos/Fullscreen/generator-cpui/milestones{/number}","notifications_url":"https://api.github.com/repos/Fullscreen/generator-cpui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Fullscreen/generator-cpui/labels{/name}","releases_url":"https://api.github.com/repos/Fullscreen/generator-cpui/releases{/id}","created_at":"2014-06-13T23:18:12Z","updated_at":"2014-08-20T21:20:44Z","pushed_at":"2014-08-28T02:14:38Z","git_url":"git://github.com/Fullscreen/generator-cpui.git","ssh_url":"git@github.com:Fullscreen/generator-cpui.git","clone_url":"https://github.com/Fullscreen/generator-cpui.git","svn_url":"https://github.com/Fullscreen/generator-cpui","homepage":null,"size":783,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Fullscreen/generator-cpui/pulls/8"},"html":{"href":"https://github.com/Fullscreen/generator-cpui/pull/8"},"issue":{"href":"https://api.github.com/repos/Fullscreen/generator-cpui/issues/8"},"comments":{"href":"https://api.github.com/repos/Fullscreen/generator-cpui/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/Fullscreen/generator-cpui/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/Fullscreen/generator-cpui/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Fullscreen/generator-cpui/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/Fullscreen/generator-cpui/statuses/c1632a07b11e56a6e72dfd3c78fa272bcadd4408"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":4,"additions":76,"deletions":210,"changed_files":15}}