GitHub PullRequestReviewCommentEvent at 2014-06-12 12:46:46
Repository: elasticsearch
Actor: s1monw
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/comments/13699151","id":13699151,"diff_hunk":"@@ -89,7 +134,9 @@ boolean hasItems() {\n \n         void replay(BucketCollector collector) throws IOException {\n             lastDocId = 0;\n+            collector.setNextReader(this.topReaderContext);","path":"src/main/java/org/elasticsearch/search/aggregations/RecordingPerReaderBucketCollector.java","position":86,"original_position":86,"commit_id":"bf1c5197724022bddde513a3b147cfed8af51ae2","original_commit_id":"bf1c5197724022bddde513a3b147cfed8af51ae2","user":{"login":"s1monw","id":973334,"avatar_url":"https://avatars.githubusercontent.com/u/973334?","gravatar_id":"8c12b7030c2431ff54d71891a722ff9a","url":"https://api.github.com/users/s1monw","html_url":"https://github.com/s1monw","followers_url":"https://api.github.com/users/s1monw/followers","following_url":"https://api.github.com/users/s1monw/following{/other_user}","gists_url":"https://api.github.com/users/s1monw/gists{/gist_id}","starred_url":"https://api.github.com/users/s1monw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s1monw/subscriptions","organizations_url":"https://api.github.com/users/s1monw/orgs","repos_url":"https://api.github.com/users/s1monw/repos","events_url":"https://api.github.com/users/s1monw/events{/privacy}","received_events_url":"https://api.github.com/users/s1monw/received_events","type":"User","site_admin":false},"body":"hmm we do this twice? this looks odd","created_at":"2014-06-12T12:46:46Z","updated_at":"2014-06-12T12:46:46Z","html_url":"https://github.com/elasticsearch/elasticsearch/pull/6477#discussion_r13699151","pull_request_url":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/6477","_links":{"self":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/comments/13699151"},"html":{"href":"https://github.com/elasticsearch/elasticsearch/pull/6477#discussion_r13699151"},"pull_request":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/6477"}}},"pull_request":{"url":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/6477","id":17046828,"html_url":"https://github.com/elasticsearch/elasticsearch/pull/6477","diff_url":"https://github.com/elasticsearch/elasticsearch/pull/6477.diff","patch_url":"https://github.com/elasticsearch/elasticsearch/pull/6477.patch","issue_url":"https://api.github.com/repos/elasticsearch/elasticsearch/issues/6477","number":6477,"state":"open","title":"Aggregations: Delegation of nextReader calls","user":{"login":"colings86","id":236731,"avatar_url":"https://avatars.githubusercontent.com/u/236731?","gravatar_id":"2bb28435e89d818ec9c705bb786a1aec","url":"https://api.github.com/users/colings86","html_url":"https://github.com/colings86","followers_url":"https://api.github.com/users/colings86/followers","following_url":"https://api.github.com/users/colings86/following{/other_user}","gists_url":"https://api.github.com/users/colings86/gists{/gist_id}","starred_url":"https://api.github.com/users/colings86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colings86/subscriptions","organizations_url":"https://api.github.com/users/colings86/orgs","repos_url":"https://api.github.com/users/colings86/repos","events_url":"https://api.github.com/users/colings86/events{/privacy}","received_events_url":"https://api.github.com/users/colings86/received_events","type":"User","site_admin":false},"body":"Currently aggregations subscribe to setNextReader calls in AggregationContext.  When a new reader is used all reader aware objects are notified of the new reader.  With deferred aggregations children aggregations of a breath-first aggregation do not require to be notified of reader changes until the replay stage. Also, at the replay stage only the child aggregations of the breath-first aggregation need to be notified, we should not be notifying all the other aggregations of the new reader.\r\n\r\nTo solve this the calls for setNextReader are now handled by each aggregation so it can notify its child aggregations and any other ReaderContextAware objects (e.g. ValueSources) of the new reader at the relevant time.\r\n\r\nThe same idea has also been applied to the setScorer and setTopReader calls for Aggregators and ValueSources.","created_at":"2014-06-12T10:08:45Z","updated_at":"2014-06-12T12:46:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"666d7739743b9ddc1cd5846fea29f070b2f19435","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/6477/commits","review_comments_url":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/6477/comments","review_comment_url":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/comments/{number}","comments_url":"https://api.github.com/repos/elasticsearch/elasticsearch/issues/6477/comments","statuses_url":"https://api.github.com/repos/elasticsearch/elasticsearch/statuses/bf1c5197724022bddde513a3b147cfed8af51ae2","head":{"label":"colings86:feature/delegatedNextReader","ref":"feature/delegatedNextReader","sha":"bf1c5197724022bddde513a3b147cfed8af51ae2","user":{"login":"colings86","id":236731,"avatar_url":"https://avatars.githubusercontent.com/u/236731?","gravatar_id":"2bb28435e89d818ec9c705bb786a1aec","url":"https://api.github.com/users/colings86","html_url":"https://github.com/colings86","followers_url":"https://api.github.com/users/colings86/followers","following_url":"https://api.github.com/users/colings86/following{/other_user}","gists_url":"https://api.github.com/users/colings86/gists{/gist_id}","starred_url":"https://api.github.com/users/colings86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colings86/subscriptions","organizations_url":"https://api.github.com/users/colings86/orgs","repos_url":"https://api.github.com/users/colings86/repos","events_url":"https://api.github.com/users/colings86/events{/privacy}","received_events_url":"https://api.github.com/users/colings86/received_events","type":"User","site_admin":false},"repo":{"id":19935914,"name":"elasticsearch","full_name":"colings86/elasticsearch","owner":{"login":"colings86","id":236731,"avatar_url":"https://avatars.githubusercontent.com/u/236731?","gravatar_id":"2bb28435e89d818ec9c705bb786a1aec","url":"https://api.github.com/users/colings86","html_url":"https://github.com/colings86","followers_url":"https://api.github.com/users/colings86/followers","following_url":"https://api.github.com/users/colings86/following{/other_user}","gists_url":"https://api.github.com/users/colings86/gists{/gist_id}","starred_url":"https://api.github.com/users/colings86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colings86/subscriptions","organizations_url":"https://api.github.com/users/colings86/orgs","repos_url":"https://api.github.com/users/colings86/repos","events_url":"https://api.github.com/users/colings86/events{/privacy}","received_events_url":"https://api.github.com/users/colings86/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/colings86/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":true,"url":"https://api.github.com/repos/colings86/elasticsearch","forks_url":"https://api.github.com/repos/colings86/elasticsearch/forks","keys_url":"https://api.github.com/repos/colings86/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/colings86/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/colings86/elasticsearch/teams","hooks_url":"https://api.github.com/repos/colings86/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/colings86/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/colings86/elasticsearch/events","assignees_url":"https://api.github.com/repos/colings86/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/colings86/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/colings86/elasticsearch/tags","blobs_url":"https://api.github.com/repos/colings86/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/colings86/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/colings86/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/colings86/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/colings86/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/colings86/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/colings86/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/colings86/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/colings86/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/colings86/elasticsearch/subscription","commits_url":"https://api.github.com/repos/colings86/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/colings86/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/colings86/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/colings86/elasticsearch/issues/comments/{number}","contents_url":"https://api.github.com/repos/colings86/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/colings86/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/colings86/elasticsearch/merges","archive_url":"https://api.github.com/repos/colings86/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/colings86/elasticsearch/downloads","issues_url":"https://api.github.com/repos/colings86/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/colings86/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/colings86/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/colings86/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/colings86/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/colings86/elasticsearch/releases{/id}","created_at":"2014-05-19T09:22:57Z","updated_at":"2014-06-12T10:08:45Z","pushed_at":"2014-06-12T10:05:08Z","git_url":"git://github.com/colings86/elasticsearch.git","ssh_url":"git@github.com:colings86/elasticsearch.git","clone_url":"https://github.com/colings86/elasticsearch.git","svn_url":"https://github.com/colings86/elasticsearch","homepage":"http://elasticsearch.org","size":58771,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elasticsearch:master","ref":"master","sha":"29c10ed1bb3729a0544407d58a744838e176b595","user":{"login":"elasticsearch","id":141304,"avatar_url":"https://avatars.githubusercontent.com/u/141304?","gravatar_id":"1aecf795625bbc7251068cfbc39800ab","url":"https://api.github.com/users/elasticsearch","html_url":"https://github.com/elasticsearch","followers_url":"https://api.github.com/users/elasticsearch/followers","following_url":"https://api.github.com/users/elasticsearch/following{/other_user}","gists_url":"https://api.github.com/users/elasticsearch/gists{/gist_id}","starred_url":"https://api.github.com/users/elasticsearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elasticsearch/subscriptions","organizations_url":"https://api.github.com/users/elasticsearch/orgs","repos_url":"https://api.github.com/users/elasticsearch/repos","events_url":"https://api.github.com/users/elasticsearch/events{/privacy}","received_events_url":"https://api.github.com/users/elasticsearch/received_events","type":"Organization","site_admin":false},"repo":{"id":507775,"name":"elasticsearch","full_name":"elasticsearch/elasticsearch","owner":{"login":"elasticsearch","id":141304,"avatar_url":"https://avatars.githubusercontent.com/u/141304?","gravatar_id":"1aecf795625bbc7251068cfbc39800ab","url":"https://api.github.com/users/elasticsearch","html_url":"https://github.com/elasticsearch","followers_url":"https://api.github.com/users/elasticsearch/followers","following_url":"https://api.github.com/users/elasticsearch/following{/other_user}","gists_url":"https://api.github.com/users/elasticsearch/gists{/gist_id}","starred_url":"https://api.github.com/users/elasticsearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elasticsearch/subscriptions","organizations_url":"https://api.github.com/users/elasticsearch/orgs","repos_url":"https://api.github.com/users/elasticsearch/repos","events_url":"https://api.github.com/users/elasticsearch/events{/privacy}","received_events_url":"https://api.github.com/users/elasticsearch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elasticsearch/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":false,"url":"https://api.github.com/repos/elasticsearch/elasticsearch","forks_url":"https://api.github.com/repos/elasticsearch/elasticsearch/forks","keys_url":"https://api.github.com/repos/elasticsearch/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elasticsearch/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elasticsearch/elasticsearch/teams","hooks_url":"https://api.github.com/repos/elasticsearch/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/elasticsearch/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/elasticsearch/elasticsearch/events","assignees_url":"https://api.github.com/repos/elasticsearch/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/elasticsearch/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/elasticsearch/elasticsearch/tags","blobs_url":"https://api.github.com/repos/elasticsearch/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elasticsearch/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elasticsearch/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/elasticsearch/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elasticsearch/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/elasticsearch/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/elasticsearch/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/elasticsearch/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/elasticsearch/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/elasticsearch/elasticsearch/subscription","commits_url":"https://api.github.com/repos/elasticsearch/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/elasticsearch/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/elasticsearch/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/elasticsearch/elasticsearch/issues/comments/{number}","contents_url":"https://api.github.com/repos/elasticsearch/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/elasticsearch/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elasticsearch/elasticsearch/merges","archive_url":"https://api.github.com/repos/elasticsearch/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elasticsearch/elasticsearch/downloads","issues_url":"https://api.github.com/repos/elasticsearch/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/elasticsearch/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/elasticsearch/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elasticsearch/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/elasticsearch/elasticsearch/releases{/id}","created_at":"2010-02-08T13:20:56Z","updated_at":"2014-06-12T12:38:34Z","pushed_at":"2014-06-12T12:23:40Z","git_url":"git://github.com/elasticsearch/elasticsearch.git","ssh_url":"git@github.com:elasticsearch/elasticsearch.git","clone_url":"https://github.com/elasticsearch/elasticsearch.git","svn_url":"https://github.com/elasticsearch/elasticsearch","homepage":"http://elasticsearch.org","size":196989,"stargazers_count":7274,"watchers_count":7274,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":2036,"mirror_url":null,"open_issues_count":1041,"forks":2036,"open_issues":1041,"watchers":7274,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/6477"},"html":{"href":"https://github.com/elasticsearch/elasticsearch/pull/6477"},"issue":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/issues/6477"},"comments":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/issues/6477/comments"},"review_comments":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/6477/comments"},"review_comment":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/6477/commits"},"statuses":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/statuses/bf1c5197724022bddde513a3b147cfed8af51ae2"}}}}