GitHub PullRequestReviewCommentEvent at 2014-06-17 15:56:37
Repository: spring-xd
Actor: markfisher
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/spring-projects/spring-xd/pulls/comments/13867774","id":13867774,"diff_hunk":"@@ -163,6 +163,10 @@ public void resolve(StreamLookupEnvironment env) {\n \t\t\t\t\t\tindexingElements.clear();\n \t\t\t\t\t\tindexingElements.add(0, sn.getModuleNodes().get(index).getName() + \".\" + index);\n \t\t\t\t\t}\n+\t\t\t\t\telse {","path":"spring-xd-dirt/src/main/java/org/springframework/xd/dirt/stream/dsl/ChannelNode.java","position":4,"original_position":4,"commit_id":"82ea83a3166a0d9a48cc2e6cc28334742ad878f0","original_commit_id":"82ea83a3166a0d9a48cc2e6cc28334742ad878f0","user":{"login":"markfisher","id":140784,"avatar_url":"https://avatars.githubusercontent.com/u/140784?","gravatar_id":"443e6ec0242c3f54001dae34374780e2","url":"https://api.github.com/users/markfisher","html_url":"https://github.com/markfisher","followers_url":"https://api.github.com/users/markfisher/followers","following_url":"https://api.github.com/users/markfisher/following{/other_user}","gists_url":"https://api.github.com/users/markfisher/gists{/gist_id}","starred_url":"https://api.github.com/users/markfisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markfisher/subscriptions","organizations_url":"https://api.github.com/users/markfisher/orgs","repos_url":"https://api.github.com/users/markfisher/repos","events_url":"https://api.github.com/users/markfisher/events{/privacy}","received_events_url":"https://api.github.com/users/markfisher/received_events","type":"User","site_admin":false},"body":"Do we even want to keep the numeric index support above this?","created_at":"2014-06-17T15:56:37Z","updated_at":"2014-06-17T15:56:37Z","html_url":"https://github.com/spring-projects/spring-xd/pull/951#discussion_r13867774","pull_request_url":"https://api.github.com/repos/spring-projects/spring-xd/pulls/951","_links":{"self":{"href":"https://api.github.com/repos/spring-projects/spring-xd/pulls/comments/13867774"},"html":{"href":"https://github.com/spring-projects/spring-xd/pull/951#discussion_r13867774"},"pull_request":{"href":"https://api.github.com/repos/spring-projects/spring-xd/pulls/951"}}},"pull_request":{"url":"https://api.github.com/repos/spring-projects/spring-xd/pulls/951","id":17243716,"html_url":"https://github.com/spring-projects/spring-xd/pull/951","diff_url":"https://github.com/spring-projects/spring-xd/pull/951.diff","patch_url":"https://github.com/spring-projects/spring-xd/pull/951.patch","issue_url":"https://api.github.com/repos/spring-projects/spring-xd/issues/951","number":951,"state":"open","title":"XD-777: Prevent tapping on an inexistant module","user":{"login":"ericbottard","id":313494,"avatar_url":"https://avatars.githubusercontent.com/u/313494?","gravatar_id":"917fa776e40325e488d52571546353a5","url":"https://api.github.com/users/ericbottard","html_url":"https://github.com/ericbottard","followers_url":"https://api.github.com/users/ericbottard/followers","following_url":"https://api.github.com/users/ericbottard/following{/other_user}","gists_url":"https://api.github.com/users/ericbottard/gists{/gist_id}","starred_url":"https://api.github.com/users/ericbottard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericbottard/subscriptions","organizations_url":"https://api.github.com/users/ericbottard/orgs","repos_url":"https://api.github.com/users/ericbottard/repos","events_url":"https://api.github.com/users/ericbottard/events{/privacy}","received_events_url":"https://api.github.com/users/ericbottard/received_events","type":"User","site_admin":false},"body":"Would be nice if we had access to the error location. Created https://jira.spring.io/browse/XD-1858","created_at":"2014-06-17T15:49:22Z","updated_at":"2014-06-17T15:56:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9852a9eaca3227ab2eefead665070468ce4798af","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/spring-projects/spring-xd/pulls/951/commits","review_comments_url":"https://api.github.com/repos/spring-projects/spring-xd/pulls/951/comments","review_comment_url":"https://api.github.com/repos/spring-projects/spring-xd/pulls/comments/{number}","comments_url":"https://api.github.com/repos/spring-projects/spring-xd/issues/951/comments","statuses_url":"https://api.github.com/repos/spring-projects/spring-xd/statuses/82ea83a3166a0d9a48cc2e6cc28334742ad878f0","head":{"label":"ericbottard:XD-777","ref":"XD-777","sha":"82ea83a3166a0d9a48cc2e6cc28334742ad878f0","user":{"login":"ericbottard","id":313494,"avatar_url":"https://avatars.githubusercontent.com/u/313494?","gravatar_id":"917fa776e40325e488d52571546353a5","url":"https://api.github.com/users/ericbottard","html_url":"https://github.com/ericbottard","followers_url":"https://api.github.com/users/ericbottard/followers","following_url":"https://api.github.com/users/ericbottard/following{/other_user}","gists_url":"https://api.github.com/users/ericbottard/gists{/gist_id}","starred_url":"https://api.github.com/users/ericbottard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericbottard/subscriptions","organizations_url":"https://api.github.com/users/ericbottard/orgs","repos_url":"https://api.github.com/users/ericbottard/repos","events_url":"https://api.github.com/users/ericbottard/events{/privacy}","received_events_url":"https://api.github.com/users/ericbottard/received_events","type":"User","site_admin":false},"repo":{"id":10668513,"name":"spring-xd","full_name":"ericbottard/spring-xd","owner":{"login":"ericbottard","id":313494,"avatar_url":"https://avatars.githubusercontent.com/u/313494?","gravatar_id":"917fa776e40325e488d52571546353a5","url":"https://api.github.com/users/ericbottard","html_url":"https://github.com/ericbottard","followers_url":"https://api.github.com/users/ericbottard/followers","following_url":"https://api.github.com/users/ericbottard/following{/other_user}","gists_url":"https://api.github.com/users/ericbottard/gists{/gist_id}","starred_url":"https://api.github.com/users/ericbottard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericbottard/subscriptions","organizations_url":"https://api.github.com/users/ericbottard/orgs","repos_url":"https://api.github.com/users/ericbottard/repos","events_url":"https://api.github.com/users/ericbottard/events{/privacy}","received_events_url":"https://api.github.com/users/ericbottard/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ericbottard/spring-xd","description":"Spring XD makes it easy to solve common big data problems such as data ingestion and export, real-time analytics, and batch workflow orchestration","fork":true,"url":"https://api.github.com/repos/ericbottard/spring-xd","forks_url":"https://api.github.com/repos/ericbottard/spring-xd/forks","keys_url":"https://api.github.com/repos/ericbottard/spring-xd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ericbottard/spring-xd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ericbottard/spring-xd/teams","hooks_url":"https://api.github.com/repos/ericbottard/spring-xd/hooks","issue_events_url":"https://api.github.com/repos/ericbottard/spring-xd/issues/events{/number}","events_url":"https://api.github.com/repos/ericbottard/spring-xd/events","assignees_url":"https://api.github.com/repos/ericbottard/spring-xd/assignees{/user}","branches_url":"https://api.github.com/repos/ericbottard/spring-xd/branches{/branch}","tags_url":"https://api.github.com/repos/ericbottard/spring-xd/tags","blobs_url":"https://api.github.com/repos/ericbottard/spring-xd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ericbottard/spring-xd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ericbottard/spring-xd/git/refs{/sha}","trees_url":"https://api.github.com/repos/ericbottard/spring-xd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ericbottard/spring-xd/statuses/{sha}","languages_url":"https://api.github.com/repos/ericbottard/spring-xd/languages","stargazers_url":"https://api.github.com/repos/ericbottard/spring-xd/stargazers","contributors_url":"https://api.github.com/repos/ericbottard/spring-xd/contributors","subscribers_url":"https://api.github.com/repos/ericbottard/spring-xd/subscribers","subscription_url":"https://api.github.com/repos/ericbottard/spring-xd/subscription","commits_url":"https://api.github.com/repos/ericbottard/spring-xd/commits{/sha}","git_commits_url":"https://api.github.com/repos/ericbottard/spring-xd/git/commits{/sha}","comments_url":"https://api.github.com/repos/ericbottard/spring-xd/comments{/number}","issue_comment_url":"https://api.github.com/repos/ericbottard/spring-xd/issues/comments/{number}","contents_url":"https://api.github.com/repos/ericbottard/spring-xd/contents/{+path}","compare_url":"https://api.github.com/repos/ericbottard/spring-xd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ericbottard/spring-xd/merges","archive_url":"https://api.github.com/repos/ericbottard/spring-xd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ericbottard/spring-xd/downloads","issues_url":"https://api.github.com/repos/ericbottard/spring-xd/issues{/number}","pulls_url":"https://api.github.com/repos/ericbottard/spring-xd/pulls{/number}","milestones_url":"https://api.github.com/repos/ericbottard/spring-xd/milestones{/number}","notifications_url":"https://api.github.com/repos/ericbottard/spring-xd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ericbottard/spring-xd/labels{/name}","releases_url":"https://api.github.com/repos/ericbottard/spring-xd/releases{/id}","created_at":"2013-06-13T14:55:49Z","updated_at":"2014-06-17T15:49:22Z","pushed_at":"2014-06-17T15:48:12Z","git_url":"git://github.com/ericbottard/spring-xd.git","ssh_url":"git@github.com:ericbottard/spring-xd.git","clone_url":"https://github.com/ericbottard/spring-xd.git","svn_url":"https://github.com/ericbottard/spring-xd","homepage":null,"size":22881,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-projects:master","ref":"master","sha":"858b028baa3d8806c64cd58a6ffb9b9f60b0c671","user":{"login":"spring-projects","id":317776,"avatar_url":"https://avatars.githubusercontent.com/u/317776?","gravatar_id":"6f8a529bd100f4272a9ff1b8cdfbd26e","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"repo":{"id":9349347,"name":"spring-xd","full_name":"spring-projects/spring-xd","owner":{"login":"spring-projects","id":317776,"avatar_url":"https://avatars.githubusercontent.com/u/317776?","gravatar_id":"6f8a529bd100f4272a9ff1b8cdfbd26e","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-projects/spring-xd","description":"Spring XD makes it easy to solve common big data problems such as data ingestion and export, real-time analytics, and batch workflow orchestration","fork":false,"url":"https://api.github.com/repos/spring-projects/spring-xd","forks_url":"https://api.github.com/repos/spring-projects/spring-xd/forks","keys_url":"https://api.github.com/repos/spring-projects/spring-xd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-projects/spring-xd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-projects/spring-xd/teams","hooks_url":"https://api.github.com/repos/spring-projects/spring-xd/hooks","issue_events_url":"https://api.github.com/repos/spring-projects/spring-xd/issues/events{/number}","events_url":"https://api.github.com/repos/spring-projects/spring-xd/events","assignees_url":"https://api.github.com/repos/spring-projects/spring-xd/assignees{/user}","branches_url":"https://api.github.com/repos/spring-projects/spring-xd/branches{/branch}","tags_url":"https://api.github.com/repos/spring-projects/spring-xd/tags","blobs_url":"https://api.github.com/repos/spring-projects/spring-xd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-projects/spring-xd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-projects/spring-xd/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-projects/spring-xd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-projects/spring-xd/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-projects/spring-xd/languages","stargazers_url":"https://api.github.com/repos/spring-projects/spring-xd/stargazers","contributors_url":"https://api.github.com/repos/spring-projects/spring-xd/contributors","subscribers_url":"https://api.github.com/repos/spring-projects/spring-xd/subscribers","subscription_url":"https://api.github.com/repos/spring-projects/spring-xd/subscription","commits_url":"https://api.github.com/repos/spring-projects/spring-xd/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-projects/spring-xd/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-projects/spring-xd/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-projects/spring-xd/issues/comments/{number}","contents_url":"https://api.github.com/repos/spring-projects/spring-xd/contents/{+path}","compare_url":"https://api.github.com/repos/spring-projects/spring-xd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-projects/spring-xd/merges","archive_url":"https://api.github.com/repos/spring-projects/spring-xd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-projects/spring-xd/downloads","issues_url":"https://api.github.com/repos/spring-projects/spring-xd/issues{/number}","pulls_url":"https://api.github.com/repos/spring-projects/spring-xd/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-projects/spring-xd/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-projects/spring-xd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-projects/spring-xd/labels{/name}","releases_url":"https://api.github.com/repos/spring-projects/spring-xd/releases{/id}","created_at":"2013-04-10T15:31:44Z","updated_at":"2014-06-17T15:51:04Z","pushed_at":"2014-06-17T15:51:04Z","git_url":"git://github.com/spring-projects/spring-xd.git","ssh_url":"git@github.com:spring-projects/spring-xd.git","clone_url":"https://github.com/spring-projects/spring-xd.git","svn_url":"https://github.com/spring-projects/spring-xd","homepage":"http://projects.spring.io/spring-xd","size":60680,"stargazers_count":129,"watchers_count":129,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":120,"mirror_url":null,"open_issues_count":17,"forks":120,"open_issues":17,"watchers":129,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-projects/spring-xd/pulls/951"},"html":{"href":"https://github.com/spring-projects/spring-xd/pull/951"},"issue":{"href":"https://api.github.com/repos/spring-projects/spring-xd/issues/951"},"comments":{"href":"https://api.github.com/repos/spring-projects/spring-xd/issues/951/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-projects/spring-xd/pulls/951/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-projects/spring-xd/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/spring-projects/spring-xd/pulls/951/commits"},"statuses":{"href":"https://api.github.com/repos/spring-projects/spring-xd/statuses/82ea83a3166a0d9a48cc2e6cc28334742ad878f0"}}}}