GitHub PullRequestEvent at 2014-09-11 17:11:52
Repository: ServiceStack.OrmLite
Actor: jessemcdowell-AI
Payload: {"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/BruceCowan-AI/ServiceStack.OrmLite/pulls/1","id":21060125,"html_url":"https://github.com/BruceCowan-AI/ServiceStack.OrmLite/pull/1","diff_url":"https://github.com/BruceCowan-AI/ServiceStack.OrmLite/pull/1.diff","patch_url":"https://github.com/BruceCowan-AI/ServiceStack.OrmLite/pull/1.patch","issue_url":"https://api.github.com/repos/BruceCowan-AI/ServiceStack.OrmLite/issues/1","number":1,"state":"closed","locked":false,"title":"Switch cache to use weak reference","user":{"login":"jessemcdowell-AI","id":7407231,"avatar_url":"https://avatars.githubusercontent.com/u/7407231?v=2","gravatar_id":"f1ea2167e2b240ff1fd70db9f57bfb97","url":"https://api.github.com/users/jessemcdowell-AI","html_url":"https://github.com/jessemcdowell-AI","followers_url":"https://api.github.com/users/jessemcdowell-AI/followers","following_url":"https://api.github.com/users/jessemcdowell-AI/following{/other_user}","gists_url":"https://api.github.com/users/jessemcdowell-AI/gists{/gist_id}","starred_url":"https://api.github.com/users/jessemcdowell-AI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessemcdowell-AI/subscriptions","organizations_url":"https://api.github.com/users/jessemcdowell-AI/orgs","repos_url":"https://api.github.com/users/jessemcdowell-AI/repos","events_url":"https://api.github.com/users/jessemcdowell-AI/events{/privacy}","received_events_url":"https://api.github.com/users/jessemcdowell-AI/received_events","type":"User","site_admin":false},"body":"Since I had nothing better to do, I tried switching the cache to use WeakReference.\r\n\r\nI dropped a couple of the cache purge tests, because I couldn't think of an easy way to test them any more. Even after the interval, the items will still be cached if the connection wasn't garbage collected.\r\n\r\nAnother quirk of this implementation: I'm not searching the cache for pre-existing items for the same connection. I started down that path, but I suspect that scanning references may not be very fast, and it added a lot more locking code. This implementation has the disadvantage that if someone does hold a connection for a long time, the cache will grow every time they do an insert, and never shrink.","created_at":"2014-09-11T00:35:15Z","updated_at":"2014-09-11T17:11:48Z","closed_at":"2014-09-11T17:11:48Z","merged_at":null,"merge_commit_sha":"da1b1d7182f66771930e387672875d6df80779f3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/BruceCowan-AI/ServiceStack.OrmLite/pulls/1/commits","review_comments_url":"https://api.github.com/repos/BruceCowan-AI/ServiceStack.OrmLite/pulls/1/comments","review_comment_url":"https://api.github.com/repos/BruceCowan-AI/ServiceStack.OrmLite/pulls/comments/{number}","comments_url":"https://api.github.com/repos/BruceCowan-AI/ServiceStack.OrmLite/issues/1/comments","statuses_url":"https://api.github.com/repos/BruceCowan-AI/ServiceStack.OrmLite/statuses/5846aa94198a46eaa813352fed7d7b8022fb91c2","head":{"label":"jessemcdowell-AI:SwitchToWeakReference","ref":"SwitchToWeakReference","sha":"5846aa94198a46eaa813352fed7d7b8022fb91c2","user":{"login":"jessemcdowell-AI","id":7407231,"avatar_url":"https://avatars.githubusercontent.com/u/7407231?v=2","gravatar_id":"f1ea2167e2b240ff1fd70db9f57bfb97","url":"https://api.github.com/users/jessemcdowell-AI","html_url":"https://github.com/jessemcdowell-AI","followers_url":"https://api.github.com/users/jessemcdowell-AI/followers","following_url":"https://api.github.com/users/jessemcdowell-AI/following{/other_user}","gists_url":"https://api.github.com/users/jessemcdowell-AI/gists{/gist_id}","starred_url":"https://api.github.com/users/jessemcdowell-AI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessemcdowell-AI/subscriptions","organizations_url":"https://api.github.com/users/jessemcdowell-AI/orgs","repos_url":"https://api.github.com/users/jessemcdowell-AI/repos","events_url":"https://api.github.com/users/jessemcdowell-AI/events{/privacy}","received_events_url":"https://api.github.com/users/jessemcdowell-AI/received_events","type":"User","site_admin":false},"repo":{"id":19832693,"name":"ServiceStack.OrmLite","full_name":"jessemcdowell-AI/ServiceStack.OrmLite","owner":{"login":"jessemcdowell-AI","id":7407231,"avatar_url":"https://avatars.githubusercontent.com/u/7407231?v=2","gravatar_id":"f1ea2167e2b240ff1fd70db9f57bfb97","url":"https://api.github.com/users/jessemcdowell-AI","html_url":"https://github.com/jessemcdowell-AI","followers_url":"https://api.github.com/users/jessemcdowell-AI/followers","following_url":"https://api.github.com/users/jessemcdowell-AI/following{/other_user}","gists_url":"https://api.github.com/users/jessemcdowell-AI/gists{/gist_id}","starred_url":"https://api.github.com/users/jessemcdowell-AI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessemcdowell-AI/subscriptions","organizations_url":"https://api.github.com/users/jessemcdowell-AI/orgs","repos_url":"https://api.github.com/users/jessemcdowell-AI/repos","events_url":"https://api.github.com/users/jessemcdowell-AI/events{/privacy}","received_events_url":"https://api.github.com/users/jessemcdowell-AI/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jessemcdowell-AI/ServiceStack.OrmLite","description":"ServiceStack.NET OrmLite - Light, simple and fast convention-based POCO ORM ","fork":true,"url":"https://api.github.com/repos/jessemcdowell-AI/ServiceStack.OrmLite","forks_url":"https://api.github.com/repos/jessemcdowell-AI/ServiceStack.OrmLite/forks","keys_url":"https://api.github.com/repos/jessemcdowell-AI/ServiceStack.OrmLite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jessemcdowell-AI/ServiceStack.OrmLite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jessemcdowell-AI/ServiceStack.OrmLite/teams","hooks_url":"https://api.github.com/repos/jessemcdowell-AI/ServiceStack.OrmLite/hooks","issue_events_url":"https://api.github.com/repos/jessemcdowell-AI/ServiceStack.OrmLite/issues/events{/number}","events_url":"https://api.github.com/repos/jessemcdowell-AI/ServiceStack.OrmLite/events","assignees_url":"https://api.github.com/repos/jessemcdowell-AI/ServiceStack.OrmLite/assignees{/user}","branches_url":"https://api.github.com/repos/jessemcdowell-AI/ServiceStack.OrmLite/branches{/branch}","tags_url":"https://api.github.com/repos/jessemcdowell-AI/ServiceStack.OrmLite/tags","blobs_url":"https://api.github.com/repos/jessemcdowell-AI/ServiceStack.OrmLite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jessemcdowell-AI/ServiceStack.OrmLite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jessemcdowell-AI/ServiceStack.OrmLite/git/refs{/sha}","trees_url":"https://api.github.com/repos/jessemcdowell-AI/ServiceStack.OrmLite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jessemcdowell-AI/ServiceStack.OrmLite/statuses/{sha}","languages_url":"https://api.github.com/repos/jessemcdowell-AI/ServiceStack.OrmLite/languages","stargazers_url":"https://api.github.com/repos/jessemcdowell-AI/ServiceStack.OrmLite/stargazers","contributors_url":"https://api.github.com/repos/jessemcdowell-AI/ServiceStack.OrmLite/contributors","subscribers_url":"https://api.github.com/repos/jessemcdowell-AI/ServiceStack.OrmLite/subscribers","subscription_url":"https://api.github.com/repos/jessemcdowell-AI/ServiceStack.OrmLite/subscription","commits_url":"https://api.github.com/repos/jessemcdowell-AI/ServiceStack.OrmLite/commits{/sha}","git_commits_url":"https://api.github.com/repos/jessemcdowell-AI/ServiceStack.OrmLite/git/commits{/sha}","comments_url":"https://api.github.com/repos/jessemcdowell-AI/ServiceStack.OrmLite/comments{/number}","issue_comment_url":"https://api.github.com/repos/jessemcdowell-AI/ServiceStack.OrmLite/issues/comments/{number}","contents_url":"https://api.github.com/repos/jessemcdowell-AI/ServiceStack.OrmLite/contents/{+path}","compare_url":"https://api.github.com/repos/jessemcdowell-AI/ServiceStack.OrmLite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jessemcdowell-AI/ServiceStack.OrmLite/merges","archive_url":"https://api.github.com/repos/jessemcdowell-AI/ServiceStack.OrmLite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jessemcdowell-AI/ServiceStack.OrmLite/downloads","issues_url":"https://api.github.com/repos/jessemcdowell-AI/ServiceStack.OrmLite/issues{/number}","pulls_url":"https://api.github.com/repos/jessemcdowell-AI/ServiceStack.OrmLite/pulls{/number}","milestones_url":"https://api.github.com/repos/jessemcdowell-AI/ServiceStack.OrmLite/milestones{/number}","notifications_url":"https://api.github.com/repos/jessemcdowell-AI/ServiceStack.OrmLite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jessemcdowell-AI/ServiceStack.OrmLite/labels{/name}","releases_url":"https://api.github.com/repos/jessemcdowell-AI/ServiceStack.OrmLite/releases{/id}","created_at":"2014-05-15T19:39:55Z","updated_at":"2014-06-04T16:42:02Z","pushed_at":"2014-09-11T00:31:18Z","git_url":"git://github.com/jessemcdowell-AI/ServiceStack.OrmLite.git","ssh_url":"git@github.com:jessemcdowell-AI/ServiceStack.OrmLite.git","clone_url":"https://github.com/jessemcdowell-AI/ServiceStack.OrmLite.git","svn_url":"https://github.com/jessemcdowell-AI/ServiceStack.OrmLite","homepage":"http://www.servicestack.net","size":92366,"stargazers_count":0,"watchers_count":0,"language":"SQL","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"BruceCowan-AI:FixOracleMultiConnectionId","ref":"FixOracleMultiConnectionId","sha":"a8b7f2f8c3fbba5c5bac724bce6308562f0796ea","user":{"login":"BruceCowan-AI","id":3277441,"avatar_url":"https://avatars.githubusercontent.com/u/3277441?v=2","gravatar_id":"91df596afd0fed1b32abeea2f563c2c8","url":"https://api.github.com/users/BruceCowan-AI","html_url":"https://github.com/BruceCowan-AI","followers_url":"https://api.github.com/users/BruceCowan-AI/followers","following_url":"https://api.github.com/users/BruceCowan-AI/following{/other_user}","gists_url":"https://api.github.com/users/BruceCowan-AI/gists{/gist_id}","starred_url":"https://api.github.com/users/BruceCowan-AI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BruceCowan-AI/subscriptions","organizations_url":"https://api.github.com/users/BruceCowan-AI/orgs","repos_url":"https://api.github.com/users/BruceCowan-AI/repos","events_url":"https://api.github.com/users/BruceCowan-AI/events{/privacy}","received_events_url":"https://api.github.com/users/BruceCowan-AI/received_events","type":"User","site_admin":false},"repo":{"id":17073679,"name":"ServiceStack.OrmLite","full_name":"BruceCowan-AI/ServiceStack.OrmLite","owner":{"login":"BruceCowan-AI","id":3277441,"avatar_url":"https://avatars.githubusercontent.com/u/3277441?v=2","gravatar_id":"91df596afd0fed1b32abeea2f563c2c8","url":"https://api.github.com/users/BruceCowan-AI","html_url":"https://github.com/BruceCowan-AI","followers_url":"https://api.github.com/users/BruceCowan-AI/followers","following_url":"https://api.github.com/users/BruceCowan-AI/following{/other_user}","gists_url":"https://api.github.com/users/BruceCowan-AI/gists{/gist_id}","starred_url":"https://api.github.com/users/BruceCowan-AI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BruceCowan-AI/subscriptions","organizations_url":"https://api.github.com/users/BruceCowan-AI/orgs","repos_url":"https://api.github.com/users/BruceCowan-AI/repos","events_url":"https://api.github.com/users/BruceCowan-AI/events{/privacy}","received_events_url":"https://api.github.com/users/BruceCowan-AI/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BruceCowan-AI/ServiceStack.OrmLite","description":"ServiceStack.NET OrmLite - Light, simple and fast convention-based POCO ORM ","fork":true,"url":"https://api.github.com/repos/BruceCowan-AI/ServiceStack.OrmLite","forks_url":"https://api.github.com/repos/BruceCowan-AI/ServiceStack.OrmLite/forks","keys_url":"https://api.github.com/repos/BruceCowan-AI/ServiceStack.OrmLite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BruceCowan-AI/ServiceStack.OrmLite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BruceCowan-AI/ServiceStack.OrmLite/teams","hooks_url":"https://api.github.com/repos/BruceCowan-AI/ServiceStack.OrmLite/hooks","issue_events_url":"https://api.github.com/repos/BruceCowan-AI/ServiceStack.OrmLite/issues/events{/number}","events_url":"https://api.github.com/repos/BruceCowan-AI/ServiceStack.OrmLite/events","assignees_url":"https://api.github.com/repos/BruceCowan-AI/ServiceStack.OrmLite/assignees{/user}","branches_url":"https://api.github.com/repos/BruceCowan-AI/ServiceStack.OrmLite/branches{/branch}","tags_url":"https://api.github.com/repos/BruceCowan-AI/ServiceStack.OrmLite/tags","blobs_url":"https://api.github.com/repos/BruceCowan-AI/ServiceStack.OrmLite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BruceCowan-AI/ServiceStack.OrmLite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BruceCowan-AI/ServiceStack.OrmLite/git/refs{/sha}","trees_url":"https://api.github.com/repos/BruceCowan-AI/ServiceStack.OrmLite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BruceCowan-AI/ServiceStack.OrmLite/statuses/{sha}","languages_url":"https://api.github.com/repos/BruceCowan-AI/ServiceStack.OrmLite/languages","stargazers_url":"https://api.github.com/repos/BruceCowan-AI/ServiceStack.OrmLite/stargazers","contributors_url":"https://api.github.com/repos/BruceCowan-AI/ServiceStack.OrmLite/contributors","subscribers_url":"https://api.github.com/repos/BruceCowan-AI/ServiceStack.OrmLite/subscribers","subscription_url":"https://api.github.com/repos/BruceCowan-AI/ServiceStack.OrmLite/subscription","commits_url":"https://api.github.com/repos/BruceCowan-AI/ServiceStack.OrmLite/commits{/sha}","git_commits_url":"https://api.github.com/repos/BruceCowan-AI/ServiceStack.OrmLite/git/commits{/sha}","comments_url":"https://api.github.com/repos/BruceCowan-AI/ServiceStack.OrmLite/comments{/number}","issue_comment_url":"https://api.github.com/repos/BruceCowan-AI/ServiceStack.OrmLite/issues/comments/{number}","contents_url":"https://api.github.com/repos/BruceCowan-AI/ServiceStack.OrmLite/contents/{+path}","compare_url":"https://api.github.com/repos/BruceCowan-AI/ServiceStack.OrmLite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BruceCowan-AI/ServiceStack.OrmLite/merges","archive_url":"https://api.github.com/repos/BruceCowan-AI/ServiceStack.OrmLite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BruceCowan-AI/ServiceStack.OrmLite/downloads","issues_url":"https://api.github.com/repos/BruceCowan-AI/ServiceStack.OrmLite/issues{/number}","pulls_url":"https://api.github.com/repos/BruceCowan-AI/ServiceStack.OrmLite/pulls{/number}","milestones_url":"https://api.github.com/repos/BruceCowan-AI/ServiceStack.OrmLite/milestones{/number}","notifications_url":"https://api.github.com/repos/BruceCowan-AI/ServiceStack.OrmLite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BruceCowan-AI/ServiceStack.OrmLite/labels{/name}","releases_url":"https://api.github.com/repos/BruceCowan-AI/ServiceStack.OrmLite/releases{/id}","created_at":"2014-02-21T23:43:52Z","updated_at":"2014-06-30T14:54:27Z","pushed_at":"2014-09-10T17:10:36Z","git_url":"git://github.com/BruceCowan-AI/ServiceStack.OrmLite.git","ssh_url":"git@github.com:BruceCowan-AI/ServiceStack.OrmLite.git","clone_url":"https://github.com/BruceCowan-AI/ServiceStack.OrmLite.git","svn_url":"https://github.com/BruceCowan-AI/ServiceStack.OrmLite","homepage":"http://www.servicestack.net","size":111202,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BruceCowan-AI/ServiceStack.OrmLite/pulls/1"},"html":{"href":"https://github.com/BruceCowan-AI/ServiceStack.OrmLite/pull/1"},"issue":{"href":"https://api.github.com/repos/BruceCowan-AI/ServiceStack.OrmLite/issues/1"},"comments":{"href":"https://api.github.com/repos/BruceCowan-AI/ServiceStack.OrmLite/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/BruceCowan-AI/ServiceStack.OrmLite/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/BruceCowan-AI/ServiceStack.OrmLite/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/BruceCowan-AI/ServiceStack.OrmLite/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/BruceCowan-AI/ServiceStack.OrmLite/statuses/5846aa94198a46eaa813352fed7d7b8022fb91c2"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":34,"deletions":110,"changed_files":2}}