GitHub PullRequestReviewCommentEvent at 2014-12-05 02:14:41
Repository: logstash
Actor: ph
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/elasticsearch/logstash/pulls/comments/21351603","id":21351603,"diff_hunk":"@@ -81,12 +81,12 @@ def utc\n \n     def to_json(*args)\n       # ignore arguments to respect accepted to_json method signature\n-      LogStash::Json.dump(@time.iso8601(ISO8601_PRECISION))\n+      \"\\\"\" + to_iso8601 + \"\\\"\"\n     end\n     alias_method :inspect, :to_json\n \n     def to_iso8601\n-      @time.iso8601(ISO8601_PRECISION)\n+      @iso8601 ||= @time.iso8601(ISO8601_PRECISION)","path":"lib/logstash/timestamp.rb","position":11,"original_position":11,"commit_id":"413141a46b627c174ac9955ab23d111afe4790bb","original_commit_id":"413141a46b627c174ac9955ab23d111afe4790bb","user":{"login":"ph","id":640,"avatar_url":"https://avatars.githubusercontent.com/u/640?v=3","gravatar_id":"","url":"https://api.github.com/users/ph","html_url":"https://github.com/ph","followers_url":"https://api.github.com/users/ph/followers","following_url":"https://api.github.com/users/ph/following{/other_user}","gists_url":"https://api.github.com/users/ph/gists{/gist_id}","starred_url":"https://api.github.com/users/ph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ph/subscriptions","organizations_url":"https://api.github.com/users/ph/orgs","repos_url":"https://api.github.com/users/ph/repos","events_url":"https://api.github.com/users/ph/events{/privacy}","received_events_url":"https://api.github.com/users/ph/received_events","type":"User","site_admin":false},"body":"We are recreating a new instance of timestamp if we update it and @time is read_only outside the class.","created_at":"2014-12-05T02:14:41Z","updated_at":"2014-12-05T02:14:41Z","html_url":"https://github.com/elasticsearch/logstash/pull/2179#discussion_r21351603","pull_request_url":"https://api.github.com/repos/elasticsearch/logstash/pulls/2179","_links":{"self":{"href":"https://api.github.com/repos/elasticsearch/logstash/pulls/comments/21351603"},"html":{"href":"https://github.com/elasticsearch/logstash/pull/2179#discussion_r21351603"},"pull_request":{"href":"https://api.github.com/repos/elasticsearch/logstash/pulls/2179"}}},"pull_request":{"url":"https://api.github.com/repos/elasticsearch/logstash/pulls/2179","id":25538764,"html_url":"https://github.com/elasticsearch/logstash/pull/2179","diff_url":"https://github.com/elasticsearch/logstash/pull/2179.diff","patch_url":"https://github.com/elasticsearch/logstash/pull/2179.patch","issue_url":"https://api.github.com/repos/elasticsearch/logstash/issues/2179","number":2179,"state":"open","locked":false,"title":"timestamp performance improvement","user":{"login":"colinsurprenant","id":2010,"avatar_url":"https://avatars.githubusercontent.com/u/2010?v=3","gravatar_id":"","url":"https://api.github.com/users/colinsurprenant","html_url":"https://github.com/colinsurprenant","followers_url":"https://api.github.com/users/colinsurprenant/followers","following_url":"https://api.github.com/users/colinsurprenant/following{/other_user}","gists_url":"https://api.github.com/users/colinsurprenant/gists{/gist_id}","starred_url":"https://api.github.com/users/colinsurprenant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colinsurprenant/subscriptions","organizations_url":"https://api.github.com/users/colinsurprenant/orgs","repos_url":"https://api.github.com/users/colinsurprenant/repos","events_url":"https://api.github.com/users/colinsurprenant/events{/privacy}","received_events_url":"https://api.github.com/users/colinsurprenant/received_events","type":"User","site_admin":false},"body":"- The `Timestamp#to_json` method was very very slow, this fix improves json serialization performance. \r\n- Also added a cleanup and performance improvement to `Event#to_s`","created_at":"2014-12-04T23:43:36Z","updated_at":"2014-12-05T02:14:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4eef0b7b52ac8a7148bdb3daed801c26a2a6eeb4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/elasticsearch/logstash/pulls/2179/commits","review_comments_url":"https://api.github.com/repos/elasticsearch/logstash/pulls/2179/comments","review_comment_url":"https://api.github.com/repos/elasticsearch/logstash/pulls/comments/{number}","comments_url":"https://api.github.com/repos/elasticsearch/logstash/issues/2179/comments","statuses_url":"https://api.github.com/repos/elasticsearch/logstash/statuses/413141a46b627c174ac9955ab23d111afe4790bb","head":{"label":"colinsurprenant:fix/timestamp","ref":"fix/timestamp","sha":"413141a46b627c174ac9955ab23d111afe4790bb","user":{"login":"colinsurprenant","id":2010,"avatar_url":"https://avatars.githubusercontent.com/u/2010?v=3","gravatar_id":"","url":"https://api.github.com/users/colinsurprenant","html_url":"https://github.com/colinsurprenant","followers_url":"https://api.github.com/users/colinsurprenant/followers","following_url":"https://api.github.com/users/colinsurprenant/following{/other_user}","gists_url":"https://api.github.com/users/colinsurprenant/gists{/gist_id}","starred_url":"https://api.github.com/users/colinsurprenant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colinsurprenant/subscriptions","organizations_url":"https://api.github.com/users/colinsurprenant/orgs","repos_url":"https://api.github.com/users/colinsurprenant/repos","events_url":"https://api.github.com/users/colinsurprenant/events{/privacy}","received_events_url":"https://api.github.com/users/colinsurprenant/received_events","type":"User","site_admin":false},"repo":{"id":17155108,"name":"logstash","full_name":"colinsurprenant/logstash","owner":{"login":"colinsurprenant","id":2010,"avatar_url":"https://avatars.githubusercontent.com/u/2010?v=3","gravatar_id":"","url":"https://api.github.com/users/colinsurprenant","html_url":"https://github.com/colinsurprenant","followers_url":"https://api.github.com/users/colinsurprenant/followers","following_url":"https://api.github.com/users/colinsurprenant/following{/other_user}","gists_url":"https://api.github.com/users/colinsurprenant/gists{/gist_id}","starred_url":"https://api.github.com/users/colinsurprenant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colinsurprenant/subscriptions","organizations_url":"https://api.github.com/users/colinsurprenant/orgs","repos_url":"https://api.github.com/users/colinsurprenant/repos","events_url":"https://api.github.com/users/colinsurprenant/events{/privacy}","received_events_url":"https://api.github.com/users/colinsurprenant/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/colinsurprenant/logstash","description":"logstash - logs/event transport, processing, management, search.","fork":true,"url":"https://api.github.com/repos/colinsurprenant/logstash","forks_url":"https://api.github.com/repos/colinsurprenant/logstash/forks","keys_url":"https://api.github.com/repos/colinsurprenant/logstash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/colinsurprenant/logstash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/colinsurprenant/logstash/teams","hooks_url":"https://api.github.com/repos/colinsurprenant/logstash/hooks","issue_events_url":"https://api.github.com/repos/colinsurprenant/logstash/issues/events{/number}","events_url":"https://api.github.com/repos/colinsurprenant/logstash/events","assignees_url":"https://api.github.com/repos/colinsurprenant/logstash/assignees{/user}","branches_url":"https://api.github.com/repos/colinsurprenant/logstash/branches{/branch}","tags_url":"https://api.github.com/repos/colinsurprenant/logstash/tags","blobs_url":"https://api.github.com/repos/colinsurprenant/logstash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/colinsurprenant/logstash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/colinsurprenant/logstash/git/refs{/sha}","trees_url":"https://api.github.com/repos/colinsurprenant/logstash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/colinsurprenant/logstash/statuses/{sha}","languages_url":"https://api.github.com/repos/colinsurprenant/logstash/languages","stargazers_url":"https://api.github.com/repos/colinsurprenant/logstash/stargazers","contributors_url":"https://api.github.com/repos/colinsurprenant/logstash/contributors","subscribers_url":"https://api.github.com/repos/colinsurprenant/logstash/subscribers","subscription_url":"https://api.github.com/repos/colinsurprenant/logstash/subscription","commits_url":"https://api.github.com/repos/colinsurprenant/logstash/commits{/sha}","git_commits_url":"https://api.github.com/repos/colinsurprenant/logstash/git/commits{/sha}","comments_url":"https://api.github.com/repos/colinsurprenant/logstash/comments{/number}","issue_comment_url":"https://api.github.com/repos/colinsurprenant/logstash/issues/comments/{number}","contents_url":"https://api.github.com/repos/colinsurprenant/logstash/contents/{+path}","compare_url":"https://api.github.com/repos/colinsurprenant/logstash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/colinsurprenant/logstash/merges","archive_url":"https://api.github.com/repos/colinsurprenant/logstash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/colinsurprenant/logstash/downloads","issues_url":"https://api.github.com/repos/colinsurprenant/logstash/issues{/number}","pulls_url":"https://api.github.com/repos/colinsurprenant/logstash/pulls{/number}","milestones_url":"https://api.github.com/repos/colinsurprenant/logstash/milestones{/number}","notifications_url":"https://api.github.com/repos/colinsurprenant/logstash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/colinsurprenant/logstash/labels{/name}","releases_url":"https://api.github.com/repos/colinsurprenant/logstash/releases{/id}","created_at":"2014-02-24T23:52:15Z","updated_at":"2014-07-14T00:14:27Z","pushed_at":"2014-12-04T23:40:14Z","git_url":"git://github.com/colinsurprenant/logstash.git","ssh_url":"git@github.com:colinsurprenant/logstash.git","clone_url":"https://github.com/colinsurprenant/logstash.git","svn_url":"https://github.com/colinsurprenant/logstash","homepage":"http://logstash.net/","size":71830,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elasticsearch:master","ref":"master","sha":"37df140bcebc414f96a9fb7619d4f8648db12fbc","user":{"login":"elasticsearch","id":141304,"avatar_url":"https://avatars.githubusercontent.com/u/141304?v=3","gravatar_id":"","url":"https://api.github.com/users/elasticsearch","html_url":"https://github.com/elasticsearch","followers_url":"https://api.github.com/users/elasticsearch/followers","following_url":"https://api.github.com/users/elasticsearch/following{/other_user}","gists_url":"https://api.github.com/users/elasticsearch/gists{/gist_id}","starred_url":"https://api.github.com/users/elasticsearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elasticsearch/subscriptions","organizations_url":"https://api.github.com/users/elasticsearch/orgs","repos_url":"https://api.github.com/users/elasticsearch/repos","events_url":"https://api.github.com/users/elasticsearch/events{/privacy}","received_events_url":"https://api.github.com/users/elasticsearch/received_events","type":"Organization","site_admin":false},"repo":{"id":1090311,"name":"logstash","full_name":"elasticsearch/logstash","owner":{"login":"elasticsearch","id":141304,"avatar_url":"https://avatars.githubusercontent.com/u/141304?v=3","gravatar_id":"","url":"https://api.github.com/users/elasticsearch","html_url":"https://github.com/elasticsearch","followers_url":"https://api.github.com/users/elasticsearch/followers","following_url":"https://api.github.com/users/elasticsearch/following{/other_user}","gists_url":"https://api.github.com/users/elasticsearch/gists{/gist_id}","starred_url":"https://api.github.com/users/elasticsearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elasticsearch/subscriptions","organizations_url":"https://api.github.com/users/elasticsearch/orgs","repos_url":"https://api.github.com/users/elasticsearch/repos","events_url":"https://api.github.com/users/elasticsearch/events{/privacy}","received_events_url":"https://api.github.com/users/elasticsearch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elasticsearch/logstash","description":"logstash - logs/event transport, processing, management, search.","fork":false,"url":"https://api.github.com/repos/elasticsearch/logstash","forks_url":"https://api.github.com/repos/elasticsearch/logstash/forks","keys_url":"https://api.github.com/repos/elasticsearch/logstash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elasticsearch/logstash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elasticsearch/logstash/teams","hooks_url":"https://api.github.com/repos/elasticsearch/logstash/hooks","issue_events_url":"https://api.github.com/repos/elasticsearch/logstash/issues/events{/number}","events_url":"https://api.github.com/repos/elasticsearch/logstash/events","assignees_url":"https://api.github.com/repos/elasticsearch/logstash/assignees{/user}","branches_url":"https://api.github.com/repos/elasticsearch/logstash/branches{/branch}","tags_url":"https://api.github.com/repos/elasticsearch/logstash/tags","blobs_url":"https://api.github.com/repos/elasticsearch/logstash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elasticsearch/logstash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elasticsearch/logstash/git/refs{/sha}","trees_url":"https://api.github.com/repos/elasticsearch/logstash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elasticsearch/logstash/statuses/{sha}","languages_url":"https://api.github.com/repos/elasticsearch/logstash/languages","stargazers_url":"https://api.github.com/repos/elasticsearch/logstash/stargazers","contributors_url":"https://api.github.com/repos/elasticsearch/logstash/contributors","subscribers_url":"https://api.github.com/repos/elasticsearch/logstash/subscribers","subscription_url":"https://api.github.com/repos/elasticsearch/logstash/subscription","commits_url":"https://api.github.com/repos/elasticsearch/logstash/commits{/sha}","git_commits_url":"https://api.github.com/repos/elasticsearch/logstash/git/commits{/sha}","comments_url":"https://api.github.com/repos/elasticsearch/logstash/comments{/number}","issue_comment_url":"https://api.github.com/repos/elasticsearch/logstash/issues/comments/{number}","contents_url":"https://api.github.com/repos/elasticsearch/logstash/contents/{+path}","compare_url":"https://api.github.com/repos/elasticsearch/logstash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elasticsearch/logstash/merges","archive_url":"https://api.github.com/repos/elasticsearch/logstash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elasticsearch/logstash/downloads","issues_url":"https://api.github.com/repos/elasticsearch/logstash/issues{/number}","pulls_url":"https://api.github.com/repos/elasticsearch/logstash/pulls{/number}","milestones_url":"https://api.github.com/repos/elasticsearch/logstash/milestones{/number}","notifications_url":"https://api.github.com/repos/elasticsearch/logstash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elasticsearch/logstash/labels{/name}","releases_url":"https://api.github.com/repos/elasticsearch/logstash/releases{/id}","created_at":"2010-11-18T01:31:50Z","updated_at":"2014-12-05T02:10:43Z","pushed_at":"2014-12-05T01:43:02Z","git_url":"git://github.com/elasticsearch/logstash.git","ssh_url":"git@github.com:elasticsearch/logstash.git","clone_url":"https://github.com/elasticsearch/logstash.git","svn_url":"https://github.com/elasticsearch/logstash","homepage":"http://logstash.net/","size":86875,"stargazers_count":3327,"watchers_count":3327,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1266,"mirror_url":null,"open_issues_count":562,"forks":1266,"open_issues":562,"watchers":3327,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elasticsearch/logstash/pulls/2179"},"html":{"href":"https://github.com/elasticsearch/logstash/pull/2179"},"issue":{"href":"https://api.github.com/repos/elasticsearch/logstash/issues/2179"},"comments":{"href":"https://api.github.com/repos/elasticsearch/logstash/issues/2179/comments"},"review_comments":{"href":"https://api.github.com/repos/elasticsearch/logstash/pulls/2179/comments"},"review_comment":{"href":"https://api.github.com/repos/elasticsearch/logstash/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/elasticsearch/logstash/pulls/2179/commits"},"statuses":{"href":"https://api.github.com/repos/elasticsearch/logstash/statuses/413141a46b627c174ac9955ab23d111afe4790bb"}}}}