GitHub PullRequestEvent at 2014-05-03 13:45:23
Repository: Haskell-Pipes-ByteString-Library
Actor: jdnavarro
Payload: {"action":"opened","number":37,"pull_request":{"url":"https://api.github.com/repos/Gabriel439/Haskell-Pipes-ByteString-Library/pulls/37","id":15462744,"html_url":"https://github.com/Gabriel439/Haskell-Pipes-ByteString-Library/pull/37","diff_url":"https://github.com/Gabriel439/Haskell-Pipes-ByteString-Library/pull/37.diff","patch_url":"https://github.com/Gabriel439/Haskell-Pipes-ByteString-Library/pull/37.patch","issue_url":"https://api.github.com/repos/Gabriel439/Haskell-Pipes-ByteString-Library/issues/37","number":37,"state":"open","title":"Add `fromBuilder`","user":{"login":"jdnavarro","id":215438,"avatar_url":"https://avatars.githubusercontent.com/u/215438?","gravatar_id":"ece6abdd9b9420799ee7764dd5e89119","url":"https://api.github.com/users/jdnavarro","html_url":"https://github.com/jdnavarro","followers_url":"https://api.github.com/users/jdnavarro/followers","following_url":"https://api.github.com/users/jdnavarro/following{/other_user}","gists_url":"https://api.github.com/users/jdnavarro/gists{/gist_id}","starred_url":"https://api.github.com/users/jdnavarro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdnavarro/subscriptions","organizations_url":"https://api.github.com/users/jdnavarro/orgs","repos_url":"https://api.github.com/users/jdnavarro/repos","events_url":"https://api.github.com/users/jdnavarro/events{/privacy}","received_events_url":"https://api.github.com/users/jdnavarro/received_events","type":"User","site_admin":false},"body":"This is actually more of a question than a pull-request.\n\nI'm experimenting between working directly with `ByteString` vs using `Builder`s. By using `Builder`s I get the benefit of automatic buffering but I don't know if introducing lazy bytestrings in the process will make it worthwhile.\n\nDo you think this, in the general case, is better than working with `ByteString`s directly and introduce another custom pipe component to deal with buffering?\n\nIf you think the latter option is in most cases preferable, don't hesitate in rejecting this pull request.\n\nNotice that I had to bump. If you want to support lower versions of `bytestring`, I could introduce a CPP pragma.","created_at":"2014-05-03T13:45:21Z","updated_at":"2014-05-03T13:45:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Gabriel439/Haskell-Pipes-ByteString-Library/pulls/37/commits","review_comments_url":"https://api.github.com/repos/Gabriel439/Haskell-Pipes-ByteString-Library/pulls/37/comments","review_comment_url":"https://api.github.com/repos/Gabriel439/Haskell-Pipes-ByteString-Library/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Gabriel439/Haskell-Pipes-ByteString-Library/issues/37/comments","statuses_url":"https://api.github.com/repos/Gabriel439/Haskell-Pipes-ByteString-Library/statuses/71c7befb6801e6d0137030cd11e50f7b19a38575","head":{"label":"jdnavarro:master","ref":"master","sha":"71c7befb6801e6d0137030cd11e50f7b19a38575","user":{"login":"jdnavarro","id":215438,"avatar_url":"https://avatars.githubusercontent.com/u/215438?","gravatar_id":"ece6abdd9b9420799ee7764dd5e89119","url":"https://api.github.com/users/jdnavarro","html_url":"https://github.com/jdnavarro","followers_url":"https://api.github.com/users/jdnavarro/followers","following_url":"https://api.github.com/users/jdnavarro/following{/other_user}","gists_url":"https://api.github.com/users/jdnavarro/gists{/gist_id}","starred_url":"https://api.github.com/users/jdnavarro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdnavarro/subscriptions","organizations_url":"https://api.github.com/users/jdnavarro/orgs","repos_url":"https://api.github.com/users/jdnavarro/repos","events_url":"https://api.github.com/users/jdnavarro/events{/privacy}","received_events_url":"https://api.github.com/users/jdnavarro/received_events","type":"User","site_admin":false},"repo":{"id":18178883,"name":"Haskell-Pipes-ByteString-Library","full_name":"jdnavarro/Haskell-Pipes-ByteString-Library","owner":{"login":"jdnavarro","id":215438,"avatar_url":"https://avatars.githubusercontent.com/u/215438?","gravatar_id":"ece6abdd9b9420799ee7764dd5e89119","url":"https://api.github.com/users/jdnavarro","html_url":"https://github.com/jdnavarro","followers_url":"https://api.github.com/users/jdnavarro/followers","following_url":"https://api.github.com/users/jdnavarro/following{/other_user}","gists_url":"https://api.github.com/users/jdnavarro/gists{/gist_id}","starred_url":"https://api.github.com/users/jdnavarro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdnavarro/subscriptions","organizations_url":"https://api.github.com/users/jdnavarro/orgs","repos_url":"https://api.github.com/users/jdnavarro/repos","events_url":"https://api.github.com/users/jdnavarro/events{/privacy}","received_events_url":"https://api.github.com/users/jdnavarro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jdnavarro/Haskell-Pipes-ByteString-Library","description":"ByteString support for pipes","fork":true,"url":"https://api.github.com/repos/jdnavarro/Haskell-Pipes-ByteString-Library","forks_url":"https://api.github.com/repos/jdnavarro/Haskell-Pipes-ByteString-Library/forks","keys_url":"https://api.github.com/repos/jdnavarro/Haskell-Pipes-ByteString-Library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jdnavarro/Haskell-Pipes-ByteString-Library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jdnavarro/Haskell-Pipes-ByteString-Library/teams","hooks_url":"https://api.github.com/repos/jdnavarro/Haskell-Pipes-ByteString-Library/hooks","issue_events_url":"https://api.github.com/repos/jdnavarro/Haskell-Pipes-ByteString-Library/issues/events{/number}","events_url":"https://api.github.com/repos/jdnavarro/Haskell-Pipes-ByteString-Library/events","assignees_url":"https://api.github.com/repos/jdnavarro/Haskell-Pipes-ByteString-Library/assignees{/user}","branches_url":"https://api.github.com/repos/jdnavarro/Haskell-Pipes-ByteString-Library/branches{/branch}","tags_url":"https://api.github.com/repos/jdnavarro/Haskell-Pipes-ByteString-Library/tags","blobs_url":"https://api.github.com/repos/jdnavarro/Haskell-Pipes-ByteString-Library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jdnavarro/Haskell-Pipes-ByteString-Library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jdnavarro/Haskell-Pipes-ByteString-Library/git/refs{/sha}","trees_url":"https://api.github.com/repos/jdnavarro/Haskell-Pipes-ByteString-Library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jdnavarro/Haskell-Pipes-ByteString-Library/statuses/{sha}","languages_url":"https://api.github.com/repos/jdnavarro/Haskell-Pipes-ByteString-Library/languages","stargazers_url":"https://api.github.com/repos/jdnavarro/Haskell-Pipes-ByteString-Library/stargazers","contributors_url":"https://api.github.com/repos/jdnavarro/Haskell-Pipes-ByteString-Library/contributors","subscribers_url":"https://api.github.com/repos/jdnavarro/Haskell-Pipes-ByteString-Library/subscribers","subscription_url":"https://api.github.com/repos/jdnavarro/Haskell-Pipes-ByteString-Library/subscription","commits_url":"https://api.github.com/repos/jdnavarro/Haskell-Pipes-ByteString-Library/commits{/sha}","git_commits_url":"https://api.github.com/repos/jdnavarro/Haskell-Pipes-ByteString-Library/git/commits{/sha}","comments_url":"https://api.github.com/repos/jdnavarro/Haskell-Pipes-ByteString-Library/comments{/number}","issue_comment_url":"https://api.github.com/repos/jdnavarro/Haskell-Pipes-ByteString-Library/issues/comments/{number}","contents_url":"https://api.github.com/repos/jdnavarro/Haskell-Pipes-ByteString-Library/contents/{+path}","compare_url":"https://api.github.com/repos/jdnavarro/Haskell-Pipes-ByteString-Library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jdnavarro/Haskell-Pipes-ByteString-Library/merges","archive_url":"https://api.github.com/repos/jdnavarro/Haskell-Pipes-ByteString-Library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jdnavarro/Haskell-Pipes-ByteString-Library/downloads","issues_url":"https://api.github.com/repos/jdnavarro/Haskell-Pipes-ByteString-Library/issues{/number}","pulls_url":"https://api.github.com/repos/jdnavarro/Haskell-Pipes-ByteString-Library/pulls{/number}","milestones_url":"https://api.github.com/repos/jdnavarro/Haskell-Pipes-ByteString-Library/milestones{/number}","notifications_url":"https://api.github.com/repos/jdnavarro/Haskell-Pipes-ByteString-Library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jdnavarro/Haskell-Pipes-ByteString-Library/labels{/name}","releases_url":"https://api.github.com/repos/jdnavarro/Haskell-Pipes-ByteString-Library/releases{/id}","created_at":"2014-03-27T14:35:00Z","updated_at":"2014-05-03T13:45:21Z","pushed_at":"2014-05-03T13:34:10Z","git_url":"git://github.com/jdnavarro/Haskell-Pipes-ByteString-Library.git","ssh_url":"git@github.com:jdnavarro/Haskell-Pipes-ByteString-Library.git","clone_url":"https://github.com/jdnavarro/Haskell-Pipes-ByteString-Library.git","svn_url":"https://github.com/jdnavarro/Haskell-Pipes-ByteString-Library","homepage":null,"size":269,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Gabriel439:master","ref":"master","sha":"f4202ab238df785722665191591921a82b586dd5","user":{"login":"Gabriel439","id":1313787,"avatar_url":"https://avatars.githubusercontent.com/u/1313787?","gravatar_id":"e4cf2da845e7862bd0b0e4edd405f77d","url":"https://api.github.com/users/Gabriel439","html_url":"https://github.com/Gabriel439","followers_url":"https://api.github.com/users/Gabriel439/followers","following_url":"https://api.github.com/users/Gabriel439/following{/other_user}","gists_url":"https://api.github.com/users/Gabriel439/gists{/gist_id}","starred_url":"https://api.github.com/users/Gabriel439/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gabriel439/subscriptions","organizations_url":"https://api.github.com/users/Gabriel439/orgs","repos_url":"https://api.github.com/users/Gabriel439/repos","events_url":"https://api.github.com/users/Gabriel439/events{/privacy}","received_events_url":"https://api.github.com/users/Gabriel439/received_events","type":"User","site_admin":false},"repo":{"id":7362130,"name":"Haskell-Pipes-ByteString-Library","full_name":"Gabriel439/Haskell-Pipes-ByteString-Library","owner":{"login":"Gabriel439","id":1313787,"avatar_url":"https://avatars.githubusercontent.com/u/1313787?","gravatar_id":"e4cf2da845e7862bd0b0e4edd405f77d","url":"https://api.github.com/users/Gabriel439","html_url":"https://github.com/Gabriel439","followers_url":"https://api.github.com/users/Gabriel439/followers","following_url":"https://api.github.com/users/Gabriel439/following{/other_user}","gists_url":"https://api.github.com/users/Gabriel439/gists{/gist_id}","starred_url":"https://api.github.com/users/Gabriel439/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gabriel439/subscriptions","organizations_url":"https://api.github.com/users/Gabriel439/orgs","repos_url":"https://api.github.com/users/Gabriel439/repos","events_url":"https://api.github.com/users/Gabriel439/events{/privacy}","received_events_url":"https://api.github.com/users/Gabriel439/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Gabriel439/Haskell-Pipes-ByteString-Library","description":"ByteString support for pipes","fork":false,"url":"https://api.github.com/repos/Gabriel439/Haskell-Pipes-ByteString-Library","forks_url":"https://api.github.com/repos/Gabriel439/Haskell-Pipes-ByteString-Library/forks","keys_url":"https://api.github.com/repos/Gabriel439/Haskell-Pipes-ByteString-Library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Gabriel439/Haskell-Pipes-ByteString-Library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Gabriel439/Haskell-Pipes-ByteString-Library/teams","hooks_url":"https://api.github.com/repos/Gabriel439/Haskell-Pipes-ByteString-Library/hooks","issue_events_url":"https://api.github.com/repos/Gabriel439/Haskell-Pipes-ByteString-Library/issues/events{/number}","events_url":"https://api.github.com/repos/Gabriel439/Haskell-Pipes-ByteString-Library/events","assignees_url":"https://api.github.com/repos/Gabriel439/Haskell-Pipes-ByteString-Library/assignees{/user}","branches_url":"https://api.github.com/repos/Gabriel439/Haskell-Pipes-ByteString-Library/branches{/branch}","tags_url":"https://api.github.com/repos/Gabriel439/Haskell-Pipes-ByteString-Library/tags","blobs_url":"https://api.github.com/repos/Gabriel439/Haskell-Pipes-ByteString-Library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Gabriel439/Haskell-Pipes-ByteString-Library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Gabriel439/Haskell-Pipes-ByteString-Library/git/refs{/sha}","trees_url":"https://api.github.com/repos/Gabriel439/Haskell-Pipes-ByteString-Library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Gabriel439/Haskell-Pipes-ByteString-Library/statuses/{sha}","languages_url":"https://api.github.com/repos/Gabriel439/Haskell-Pipes-ByteString-Library/languages","stargazers_url":"https://api.github.com/repos/Gabriel439/Haskell-Pipes-ByteString-Library/stargazers","contributors_url":"https://api.github.com/repos/Gabriel439/Haskell-Pipes-ByteString-Library/contributors","subscribers_url":"https://api.github.com/repos/Gabriel439/Haskell-Pipes-ByteString-Library/subscribers","subscription_url":"https://api.github.com/repos/Gabriel439/Haskell-Pipes-ByteString-Library/subscription","commits_url":"https://api.github.com/repos/Gabriel439/Haskell-Pipes-ByteString-Library/commits{/sha}","git_commits_url":"https://api.github.com/repos/Gabriel439/Haskell-Pipes-ByteString-Library/git/commits{/sha}","comments_url":"https://api.github.com/repos/Gabriel439/Haskell-Pipes-ByteString-Library/comments{/number}","issue_comment_url":"https://api.github.com/repos/Gabriel439/Haskell-Pipes-ByteString-Library/issues/comments/{number}","contents_url":"https://api.github.com/repos/Gabriel439/Haskell-Pipes-ByteString-Library/contents/{+path}","compare_url":"https://api.github.com/repos/Gabriel439/Haskell-Pipes-ByteString-Library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Gabriel439/Haskell-Pipes-ByteString-Library/merges","archive_url":"https://api.github.com/repos/Gabriel439/Haskell-Pipes-ByteString-Library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Gabriel439/Haskell-Pipes-ByteString-Library/downloads","issues_url":"https://api.github.com/repos/Gabriel439/Haskell-Pipes-ByteString-Library/issues{/number}","pulls_url":"https://api.github.com/repos/Gabriel439/Haskell-Pipes-ByteString-Library/pulls{/number}","milestones_url":"https://api.github.com/repos/Gabriel439/Haskell-Pipes-ByteString-Library/milestones{/number}","notifications_url":"https://api.github.com/repos/Gabriel439/Haskell-Pipes-ByteString-Library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Gabriel439/Haskell-Pipes-ByteString-Library/labels{/name}","releases_url":"https://api.github.com/repos/Gabriel439/Haskell-Pipes-ByteString-Library/releases{/id}","created_at":"2012-12-29T02:26:04Z","updated_at":"2014-04-30T22:29:20Z","pushed_at":"2014-04-30T22:29:21Z","git_url":"git://github.com/Gabriel439/Haskell-Pipes-ByteString-Library.git","ssh_url":"git@github.com:Gabriel439/Haskell-Pipes-ByteString-Library.git","clone_url":"https://github.com/Gabriel439/Haskell-Pipes-ByteString-Library.git","svn_url":"https://github.com/Gabriel439/Haskell-Pipes-ByteString-Library","homepage":null,"size":670,"stargazers_count":8,"watchers_count":8,"language":"Haskell","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":9,"mirror_url":null,"open_issues_count":4,"forks":9,"open_issues":4,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Gabriel439/Haskell-Pipes-ByteString-Library/pulls/37"},"html":{"href":"https://github.com/Gabriel439/Haskell-Pipes-ByteString-Library/pull/37"},"issue":{"href":"https://api.github.com/repos/Gabriel439/Haskell-Pipes-ByteString-Library/issues/37"},"comments":{"href":"https://api.github.com/repos/Gabriel439/Haskell-Pipes-ByteString-Library/issues/37/comments"},"review_comments":{"href":"https://api.github.com/repos/Gabriel439/Haskell-Pipes-ByteString-Library/pulls/37/comments"},"review_comment":{"href":"https://api.github.com/repos/Gabriel439/Haskell-Pipes-ByteString-Library/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Gabriel439/Haskell-Pipes-ByteString-Library/pulls/37/commits"},"statuses":{"href":"https://api.github.com/repos/Gabriel439/Haskell-Pipes-ByteString-Library/statuses/71c7befb6801e6d0137030cd11e50f7b19a38575"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":14,"deletions":7,"changed_files":2}}