GitHub PullRequestReviewCommentEvent at 2014-11-15 02:36:08
Repository: incubator-brooklyn
Actor: ahgittin
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/comments/20399054","id":20399054,"diff_hunk":"@@ -72,6 +64,7 @@\n     protected T newApp;\n     protected ManagementContext newManagementContext;","path":"core/src/test/java/brooklyn/entity/rebind/RebindTestFixture.java","position":37,"original_position":37,"commit_id":"ecff23c7320410187b2b73264d6573bb830b2480","original_commit_id":"ecff23c7320410187b2b73264d6573bb830b2480","user":{"login":"ahgittin","id":496540,"avatar_url":"https://avatars.githubusercontent.com/u/496540?v=3","gravatar_id":"","url":"https://api.github.com/users/ahgittin","html_url":"https://github.com/ahgittin","followers_url":"https://api.github.com/users/ahgittin/followers","following_url":"https://api.github.com/users/ahgittin/following{/other_user}","gists_url":"https://api.github.com/users/ahgittin/gists{/gist_id}","starred_url":"https://api.github.com/users/ahgittin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahgittin/subscriptions","organizations_url":"https://api.github.com/users/ahgittin/orgs","repos_url":"https://api.github.com/users/ahgittin/repos","events_url":"https://api.github.com/users/ahgittin/events{/privacy}","received_events_url":"https://api.github.com/users/ahgittin/received_events","type":"User","site_admin":false},"body":"we've left this field here but stopped setting it in several places, replacing with locally-scoped.  one of the nice things about this one though was it automatically got terminated; are things still terminated?  (probably yes, but i dind't see where)","created_at":"2014-11-15T02:36:08Z","updated_at":"2014-11-15T02:36:08Z","html_url":"https://github.com/apache/incubator-brooklyn/pull/309#discussion_r20399054","pull_request_url":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/309","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/comments/20399054"},"html":{"href":"https://github.com/apache/incubator-brooklyn/pull/309#discussion_r20399054"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/309"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/309","id":24044394,"html_url":"https://github.com/apache/incubator-brooklyn/pull/309","diff_url":"https://github.com/apache/incubator-brooklyn/pull/309.diff","patch_url":"https://github.com/apache/incubator-brooklyn/pull/309.patch","issue_url":"https://api.github.com/repos/apache/incubator-brooklyn/issues/309","number":309,"state":"open","locked":false,"title":"Refactor rebind code, and tidy","user":{"login":"aledsage","id":593113,"avatar_url":"https://avatars.githubusercontent.com/u/593113?v=3","gravatar_id":"","url":"https://api.github.com/users/aledsage","html_url":"https://github.com/aledsage","followers_url":"https://api.github.com/users/aledsage/followers","following_url":"https://api.github.com/users/aledsage/following{/other_user}","gists_url":"https://api.github.com/users/aledsage/gists{/gist_id}","starred_url":"https://api.github.com/users/aledsage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aledsage/subscriptions","organizations_url":"https://api.github.com/users/aledsage/orgs","repos_url":"https://api.github.com/users/aledsage/repos","events_url":"https://api.github.com/users/aledsage/events{/privacy}","received_events_url":"https://api.github.com/users/aledsage/received_events","type":"User","site_admin":false},"body":"Please merge https://github.com/apache/incubator-brooklyn/pull/308 first","created_at":"2014-11-07T10:26:09Z","updated_at":"2014-11-15T02:36:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3e8b9c1d1a8b1d371d7a7eaec82841ea6015cb88","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/309/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/309/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/comments/{number}","comments_url":"https://api.github.com/repos/apache/incubator-brooklyn/issues/309/comments","statuses_url":"https://api.github.com/repos/apache/incubator-brooklyn/statuses/ecff23c7320410187b2b73264d6573bb830b2480","head":{"label":"aledsage:refactor/Rebind-code-tidy","ref":"refactor/Rebind-code-tidy","sha":"ecff23c7320410187b2b73264d6573bb830b2480","user":{"login":"aledsage","id":593113,"avatar_url":"https://avatars.githubusercontent.com/u/593113?v=3","gravatar_id":"","url":"https://api.github.com/users/aledsage","html_url":"https://github.com/aledsage","followers_url":"https://api.github.com/users/aledsage/followers","following_url":"https://api.github.com/users/aledsage/following{/other_user}","gists_url":"https://api.github.com/users/aledsage/gists{/gist_id}","starred_url":"https://api.github.com/users/aledsage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aledsage/subscriptions","organizations_url":"https://api.github.com/users/aledsage/orgs","repos_url":"https://api.github.com/users/aledsage/repos","events_url":"https://api.github.com/users/aledsage/events{/privacy}","received_events_url":"https://api.github.com/users/aledsage/received_events","type":"User","site_admin":false},"repo":{"id":21017170,"name":"incubator-brooklyn","full_name":"aledsage/incubator-brooklyn","owner":{"login":"aledsage","id":593113,"avatar_url":"https://avatars.githubusercontent.com/u/593113?v=3","gravatar_id":"","url":"https://api.github.com/users/aledsage","html_url":"https://github.com/aledsage","followers_url":"https://api.github.com/users/aledsage/followers","following_url":"https://api.github.com/users/aledsage/following{/other_user}","gists_url":"https://api.github.com/users/aledsage/gists{/gist_id}","starred_url":"https://api.github.com/users/aledsage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aledsage/subscriptions","organizations_url":"https://api.github.com/users/aledsage/orgs","repos_url":"https://api.github.com/users/aledsage/repos","events_url":"https://api.github.com/users/aledsage/events{/privacy}","received_events_url":"https://api.github.com/users/aledsage/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aledsage/incubator-brooklyn","description":"Mirror of Apache Brooklyn","fork":true,"url":"https://api.github.com/repos/aledsage/incubator-brooklyn","forks_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/forks","keys_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/teams","hooks_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/hooks","issue_events_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/issues/events{/number}","events_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/events","assignees_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/assignees{/user}","branches_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/branches{/branch}","tags_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/tags","blobs_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/statuses/{sha}","languages_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/languages","stargazers_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/stargazers","contributors_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/contributors","subscribers_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/subscribers","subscription_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/subscription","commits_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/issues/comments/{number}","contents_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/contents/{+path}","compare_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/merges","archive_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/downloads","issues_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/issues{/number}","pulls_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/pulls{/number}","milestones_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/milestones{/number}","notifications_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/labels{/name}","releases_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/releases{/id}","created_at":"2014-06-19T22:03:41Z","updated_at":"2014-06-24T09:45:44Z","pushed_at":"2014-11-14T22:05:24Z","git_url":"git://github.com/aledsage/incubator-brooklyn.git","ssh_url":"git@github.com:aledsage/incubator-brooklyn.git","clone_url":"https://github.com/aledsage/incubator-brooklyn.git","svn_url":"https://github.com/aledsage/incubator-brooklyn","homepage":null,"size":231344,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"6791d51d4b8e35c7e5a306ed4fb0984746b1385e","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":19368221,"name":"incubator-brooklyn","full_name":"apache/incubator-brooklyn","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-brooklyn","description":"Mirror of Apache Brooklyn","fork":false,"url":"https://api.github.com/repos/apache/incubator-brooklyn","forks_url":"https://api.github.com/repos/apache/incubator-brooklyn/forks","keys_url":"https://api.github.com/repos/apache/incubator-brooklyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-brooklyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-brooklyn/teams","hooks_url":"https://api.github.com/repos/apache/incubator-brooklyn/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-brooklyn/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-brooklyn/events","assignees_url":"https://api.github.com/repos/apache/incubator-brooklyn/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-brooklyn/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-brooklyn/tags","blobs_url":"https://api.github.com/repos/apache/incubator-brooklyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-brooklyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-brooklyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-brooklyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-brooklyn/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-brooklyn/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-brooklyn/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-brooklyn/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-brooklyn/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-brooklyn/subscription","commits_url":"https://api.github.com/repos/apache/incubator-brooklyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-brooklyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-brooklyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-brooklyn/issues/comments/{number}","contents_url":"https://api.github.com/repos/apache/incubator-brooklyn/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-brooklyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-brooklyn/merges","archive_url":"https://api.github.com/repos/apache/incubator-brooklyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-brooklyn/downloads","issues_url":"https://api.github.com/repos/apache/incubator-brooklyn/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-brooklyn/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-brooklyn/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-brooklyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-brooklyn/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-brooklyn/releases{/id}","created_at":"2014-05-02T07:00:07Z","updated_at":"2014-11-12T22:05:50Z","pushed_at":"2014-11-15T01:28:14Z","git_url":"git://github.com/apache/incubator-brooklyn.git","ssh_url":"git@github.com:apache/incubator-brooklyn.git","clone_url":"https://github.com/apache/incubator-brooklyn.git","svn_url":"https://github.com/apache/incubator-brooklyn","homepage":null,"size":243734,"stargazers_count":29,"watchers_count":29,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":31,"mirror_url":"git://git.apache.org/incubator-brooklyn.git","open_issues_count":11,"forks":31,"open_issues":11,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/309"},"html":{"href":"https://github.com/apache/incubator-brooklyn/pull/309"},"issue":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/issues/309"},"comments":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/issues/309/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/309/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/309/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/statuses/ecff23c7320410187b2b73264d6573bb830b2480"}}}}