GitHub PullRequestReviewCommentEvent at 2014-10-17 00:09:20
Repository: etcd
Actor: jonboulle
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/coreos/etcd/pulls/comments/18995059","id":18995059,"diff_hunk":"@@ -896,8 +896,8 @@ func TestRecvMsgBeat(t *testing.T) {\n \n func TestRestore(t *testing.T) {\n \ts := pb.Snapshot{\n-\t\tIndex:        defaultCompactThreshold + 1,\n-\t\tTerm:         defaultCompactThreshold + 1,\n+\t\tIndex:        11,","path":"raft/raft_test.go","position":6,"original_position":6,"commit_id":"d375f546c8d5c6ecf2f8365850c6333b5c77abb1","original_commit_id":"d375f546c8d5c6ecf2f8365850c6333b5c77abb1","user":{"login":"jonboulle","id":2601015,"avatar_url":"https://avatars.githubusercontent.com/u/2601015?v=2","gravatar_id":"","url":"https://api.github.com/users/jonboulle","html_url":"https://github.com/jonboulle","followers_url":"https://api.github.com/users/jonboulle/followers","following_url":"https://api.github.com/users/jonboulle/following{/other_user}","gists_url":"https://api.github.com/users/jonboulle/gists{/gist_id}","starred_url":"https://api.github.com/users/jonboulle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonboulle/subscriptions","organizations_url":"https://api.github.com/users/jonboulle/orgs","repos_url":"https://api.github.com/users/jonboulle/repos","events_url":"https://api.github.com/users/jonboulle/events{/privacy}","received_events_url":"https://api.github.com/users/jonboulle/received_events","type":"User","site_admin":false},"body":"It doesn't really represent that any more, does it?","created_at":"2014-10-17T00:09:20Z","updated_at":"2014-10-17T00:09:20Z","html_url":"https://github.com/coreos/etcd/pull/1314#discussion_r18995059","pull_request_url":"https://api.github.com/repos/coreos/etcd/pulls/1314","_links":{"self":{"href":"https://api.github.com/repos/coreos/etcd/pulls/comments/18995059"},"html":{"href":"https://github.com/coreos/etcd/pull/1314#discussion_r18995059"},"pull_request":{"href":"https://api.github.com/repos/coreos/etcd/pulls/1314"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/etcd/pulls/1314","id":22891996,"html_url":"https://github.com/coreos/etcd/pull/1314","diff_url":"https://github.com/coreos/etcd/pull/1314.diff","patch_url":"https://github.com/coreos/etcd/pull/1314.patch","issue_url":"https://api.github.com/repos/coreos/etcd/issues/1314","number":1314,"state":"open","locked":false,"title":"raft: remove unused compactThreshold","user":{"login":"jonboulle","id":2601015,"avatar_url":"https://avatars.githubusercontent.com/u/2601015?v=2","gravatar_id":"","url":"https://api.github.com/users/jonboulle","html_url":"https://github.com/jonboulle","followers_url":"https://api.github.com/users/jonboulle/followers","following_url":"https://api.github.com/users/jonboulle/following{/other_user}","gists_url":"https://api.github.com/users/jonboulle/gists{/gist_id}","starred_url":"https://api.github.com/users/jonboulle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonboulle/subscriptions","organizations_url":"https://api.github.com/users/jonboulle/orgs","repos_url":"https://api.github.com/users/jonboulle/repos","events_url":"https://api.github.com/users/jonboulle/events{/privacy}","received_events_url":"https://api.github.com/users/jonboulle/received_events","type":"User","site_admin":false},"body":"This speeds up the test considerably (3.5s -> 1.5s), and I don't see a strong reason that it needs to be such a high figure in the tests","created_at":"2014-10-16T22:33:39Z","updated_at":"2014-10-17T00:09:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b811fa9a7d16569c061e760a70f880d52cfccfd9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/coreos/etcd/pulls/1314/commits","review_comments_url":"https://api.github.com/repos/coreos/etcd/pulls/1314/comments","review_comment_url":"https://api.github.com/repos/coreos/etcd/pulls/comments/{number}","comments_url":"https://api.github.com/repos/coreos/etcd/issues/1314/comments","statuses_url":"https://api.github.com/repos/coreos/etcd/statuses/d375f546c8d5c6ecf2f8365850c6333b5c77abb1","head":{"label":"jonboulle:raft_tests","ref":"raft_tests","sha":"d375f546c8d5c6ecf2f8365850c6333b5c77abb1","user":{"login":"jonboulle","id":2601015,"avatar_url":"https://avatars.githubusercontent.com/u/2601015?v=2","gravatar_id":"","url":"https://api.github.com/users/jonboulle","html_url":"https://github.com/jonboulle","followers_url":"https://api.github.com/users/jonboulle/followers","following_url":"https://api.github.com/users/jonboulle/following{/other_user}","gists_url":"https://api.github.com/users/jonboulle/gists{/gist_id}","starred_url":"https://api.github.com/users/jonboulle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonboulle/subscriptions","organizations_url":"https://api.github.com/users/jonboulle/orgs","repos_url":"https://api.github.com/users/jonboulle/repos","events_url":"https://api.github.com/users/jonboulle/events{/privacy}","received_events_url":"https://api.github.com/users/jonboulle/received_events","type":"User","site_admin":false},"repo":{"id":16238846,"name":"etcd","full_name":"jonboulle/etcd","owner":{"login":"jonboulle","id":2601015,"avatar_url":"https://avatars.githubusercontent.com/u/2601015?v=2","gravatar_id":"","url":"https://api.github.com/users/jonboulle","html_url":"https://github.com/jonboulle","followers_url":"https://api.github.com/users/jonboulle/followers","following_url":"https://api.github.com/users/jonboulle/following{/other_user}","gists_url":"https://api.github.com/users/jonboulle/gists{/gist_id}","starred_url":"https://api.github.com/users/jonboulle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonboulle/subscriptions","organizations_url":"https://api.github.com/users/jonboulle/orgs","repos_url":"https://api.github.com/users/jonboulle/repos","events_url":"https://api.github.com/users/jonboulle/events{/privacy}","received_events_url":"https://api.github.com/users/jonboulle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jonboulle/etcd","description":"A highly-available key value store for shared configuration and service discovery","fork":true,"url":"https://api.github.com/repos/jonboulle/etcd","forks_url":"https://api.github.com/repos/jonboulle/etcd/forks","keys_url":"https://api.github.com/repos/jonboulle/etcd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jonboulle/etcd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jonboulle/etcd/teams","hooks_url":"https://api.github.com/repos/jonboulle/etcd/hooks","issue_events_url":"https://api.github.com/repos/jonboulle/etcd/issues/events{/number}","events_url":"https://api.github.com/repos/jonboulle/etcd/events","assignees_url":"https://api.github.com/repos/jonboulle/etcd/assignees{/user}","branches_url":"https://api.github.com/repos/jonboulle/etcd/branches{/branch}","tags_url":"https://api.github.com/repos/jonboulle/etcd/tags","blobs_url":"https://api.github.com/repos/jonboulle/etcd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jonboulle/etcd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jonboulle/etcd/git/refs{/sha}","trees_url":"https://api.github.com/repos/jonboulle/etcd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jonboulle/etcd/statuses/{sha}","languages_url":"https://api.github.com/repos/jonboulle/etcd/languages","stargazers_url":"https://api.github.com/repos/jonboulle/etcd/stargazers","contributors_url":"https://api.github.com/repos/jonboulle/etcd/contributors","subscribers_url":"https://api.github.com/repos/jonboulle/etcd/subscribers","subscription_url":"https://api.github.com/repos/jonboulle/etcd/subscription","commits_url":"https://api.github.com/repos/jonboulle/etcd/commits{/sha}","git_commits_url":"https://api.github.com/repos/jonboulle/etcd/git/commits{/sha}","comments_url":"https://api.github.com/repos/jonboulle/etcd/comments{/number}","issue_comment_url":"https://api.github.com/repos/jonboulle/etcd/issues/comments/{number}","contents_url":"https://api.github.com/repos/jonboulle/etcd/contents/{+path}","compare_url":"https://api.github.com/repos/jonboulle/etcd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jonboulle/etcd/merges","archive_url":"https://api.github.com/repos/jonboulle/etcd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jonboulle/etcd/downloads","issues_url":"https://api.github.com/repos/jonboulle/etcd/issues{/number}","pulls_url":"https://api.github.com/repos/jonboulle/etcd/pulls{/number}","milestones_url":"https://api.github.com/repos/jonboulle/etcd/milestones{/number}","notifications_url":"https://api.github.com/repos/jonboulle/etcd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jonboulle/etcd/labels{/name}","releases_url":"https://api.github.com/repos/jonboulle/etcd/releases{/id}","created_at":"2014-01-25T20:07:46Z","updated_at":"2014-09-04T19:32:13Z","pushed_at":"2014-10-17T00:03:52Z","git_url":"git://github.com/jonboulle/etcd.git","ssh_url":"git@github.com:jonboulle/etcd.git","clone_url":"https://github.com/jonboulle/etcd.git","svn_url":"https://github.com/jonboulle/etcd","homepage":"","size":12259,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"f7988e6069b30bf8687987a0c3b80c2c9e6766c0","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=2","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":11225014,"name":"etcd","full_name":"coreos/etcd","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=2","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/etcd","description":"A highly-available key value store for shared configuration and service discovery","fork":false,"url":"https://api.github.com/repos/coreos/etcd","forks_url":"https://api.github.com/repos/coreos/etcd/forks","keys_url":"https://api.github.com/repos/coreos/etcd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/etcd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/etcd/teams","hooks_url":"https://api.github.com/repos/coreos/etcd/hooks","issue_events_url":"https://api.github.com/repos/coreos/etcd/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/etcd/events","assignees_url":"https://api.github.com/repos/coreos/etcd/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/etcd/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/etcd/tags","blobs_url":"https://api.github.com/repos/coreos/etcd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/etcd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/etcd/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/etcd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/etcd/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/etcd/languages","stargazers_url":"https://api.github.com/repos/coreos/etcd/stargazers","contributors_url":"https://api.github.com/repos/coreos/etcd/contributors","subscribers_url":"https://api.github.com/repos/coreos/etcd/subscribers","subscription_url":"https://api.github.com/repos/coreos/etcd/subscription","commits_url":"https://api.github.com/repos/coreos/etcd/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/etcd/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/etcd/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/etcd/issues/comments/{number}","contents_url":"https://api.github.com/repos/coreos/etcd/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/etcd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/etcd/merges","archive_url":"https://api.github.com/repos/coreos/etcd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/etcd/downloads","issues_url":"https://api.github.com/repos/coreos/etcd/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/etcd/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/etcd/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/etcd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/etcd/labels{/name}","releases_url":"https://api.github.com/repos/coreos/etcd/releases{/id}","created_at":"2013-07-06T21:57:21Z","updated_at":"2014-10-16T19:40:32Z","pushed_at":"2014-10-16T23:50:31Z","git_url":"git://github.com/coreos/etcd.git","ssh_url":"git@github.com:coreos/etcd.git","clone_url":"https://github.com/coreos/etcd.git","svn_url":"https://github.com/coreos/etcd","homepage":"","size":26068,"stargazers_count":4412,"watchers_count":4412,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":444,"mirror_url":null,"open_issues_count":137,"forks":444,"open_issues":137,"watchers":4412,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/etcd/pulls/1314"},"html":{"href":"https://github.com/coreos/etcd/pull/1314"},"issue":{"href":"https://api.github.com/repos/coreos/etcd/issues/1314"},"comments":{"href":"https://api.github.com/repos/coreos/etcd/issues/1314/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/etcd/pulls/1314/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/etcd/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/coreos/etcd/pulls/1314/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/etcd/statuses/d375f546c8d5c6ecf2f8365850c6333b5c77abb1"}}}}