GitHub PullRequestReviewCommentEvent at 2014-10-31 19:06:14
Repository: SynapseWebClient
Actor: jay-hodgson
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/pulls/comments/19687112","id":19687112,"diff_hunk":"@@ -0,0 +1,127 @@\n+package org.sagebionetworks.web.client.widget.entity.menu.v2;\r\n+\r\n+import java.util.HashMap;\r\n+import java.util.LinkedList;\r\n+import java.util.List;\r\n+import java.util.Map;\r\n+\r\n+import org.gwtbootstrap3.client.ui.constants.IconType;\r\n+import org.sagebionetworks.web.client.widget.entity.menu.v2.ActionMenuWidget.ActionListener;\r\n+\r\n+import com.google.gwt.user.client.ui.Widget;\r\n+import com.google.inject.Inject;\r\n+\r\n+/**\r\n+ * This ActionMenuWidget implementation will synchronize with its view to find\r\n+ * the ActionViews associated with each action. The synchronize is done once\r\n+ * during construction.\r\n+ * \r\n+ * @author John\r\n+ * \r\n+ */\r\n+public class ActionMenuWidgetImpl implements ActionMenuWidget, ActionListener {\r\n+\r\n+\tActionMenuWidgetView view;\r\n+\r\n+\tMap<Action, ActionView> actionViewMap;\r\n+\tMap<Action, List<ActionListener>> actionListenerMap;\r","path":"src/main/java/org/sagebionetworks/web/client/widget/entity/menu/v2/ActionMenuWidgetImpl.java","position":27,"original_position":27,"commit_id":"65cb5c29ae21c5d21be5a6b086a3941d8d0b23bf","original_commit_id":"65cb5c29ae21c5d21be5a6b086a3941d8d0b23bf","user":{"login":"jay-hodgson","id":1864447,"avatar_url":"https://avatars.githubusercontent.com/u/1864447?v=2","gravatar_id":"","url":"https://api.github.com/users/jay-hodgson","html_url":"https://github.com/jay-hodgson","followers_url":"https://api.github.com/users/jay-hodgson/followers","following_url":"https://api.github.com/users/jay-hodgson/following{/other_user}","gists_url":"https://api.github.com/users/jay-hodgson/gists{/gist_id}","starred_url":"https://api.github.com/users/jay-hodgson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jay-hodgson/subscriptions","organizations_url":"https://api.github.com/users/jay-hodgson/orgs","repos_url":"https://api.github.com/users/jay-hodgson/repos","events_url":"https://api.github.com/users/jay-hodgson/events{/privacy}","received_events_url":"https://api.github.com/users/jay-hodgson/received_events","type":"User","site_admin":false},"body":"May want to make this a single ActionListener rather than a list.  If I'm the listener for DELETE, I don't want anyone else to handle.","created_at":"2014-10-31T19:06:14Z","updated_at":"2014-10-31T19:06:14Z","html_url":"https://github.com/Sage-Bionetworks/SynapseWebClient/pull/1285#discussion_r19687112","pull_request_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/pulls/1285","_links":{"self":{"href":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/pulls/comments/19687112"},"html":{"href":"https://github.com/Sage-Bionetworks/SynapseWebClient/pull/1285#discussion_r19687112"},"pull_request":{"href":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/pulls/1285"}}},"pull_request":{"url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/pulls/1285","id":23649872,"html_url":"https://github.com/Sage-Bionetworks/SynapseWebClient/pull/1285","diff_url":"https://github.com/Sage-Bionetworks/SynapseWebClient/pull/1285.diff","patch_url":"https://github.com/Sage-Bionetworks/SynapseWebClient/pull/1285.patch","issue_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/issues/1285","number":1285,"state":"open","locked":false,"title":"Swc 1696 new b","user":{"login":"john-hill","id":1728181,"avatar_url":"https://avatars.githubusercontent.com/u/1728181?v=2","gravatar_id":"","url":"https://api.github.com/users/john-hill","html_url":"https://github.com/john-hill","followers_url":"https://api.github.com/users/john-hill/followers","following_url":"https://api.github.com/users/john-hill/following{/other_user}","gists_url":"https://api.github.com/users/john-hill/gists{/gist_id}","starred_url":"https://api.github.com/users/john-hill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/john-hill/subscriptions","organizations_url":"https://api.github.com/users/john-hill/orgs","repos_url":"https://api.github.com/users/john-hill/repos","events_url":"https://api.github.com/users/john-hill/events{/privacy}","received_events_url":"https://api.github.com/users/john-hill/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-10-31T00:44:03Z","updated_at":"2014-10-31T19:06:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3657053bc80725594ab84cf066ed8cd919e598ad","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/pulls/1285/commits","review_comments_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/pulls/1285/comments","review_comment_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/issues/1285/comments","statuses_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/statuses/65cb5c29ae21c5d21be5a6b086a3941d8d0b23bf","head":{"label":"john-hill:SWC-1696-new-b","ref":"SWC-1696-new-b","sha":"65cb5c29ae21c5d21be5a6b086a3941d8d0b23bf","user":{"login":"john-hill","id":1728181,"avatar_url":"https://avatars.githubusercontent.com/u/1728181?v=2","gravatar_id":"","url":"https://api.github.com/users/john-hill","html_url":"https://github.com/john-hill","followers_url":"https://api.github.com/users/john-hill/followers","following_url":"https://api.github.com/users/john-hill/following{/other_user}","gists_url":"https://api.github.com/users/john-hill/gists{/gist_id}","starred_url":"https://api.github.com/users/john-hill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/john-hill/subscriptions","organizations_url":"https://api.github.com/users/john-hill/orgs","repos_url":"https://api.github.com/users/john-hill/repos","events_url":"https://api.github.com/users/john-hill/events{/privacy}","received_events_url":"https://api.github.com/users/john-hill/received_events","type":"User","site_admin":false},"repo":{"id":5049002,"name":"SynapseWebClient","full_name":"john-hill/SynapseWebClient","owner":{"login":"john-hill","id":1728181,"avatar_url":"https://avatars.githubusercontent.com/u/1728181?v=2","gravatar_id":"","url":"https://api.github.com/users/john-hill","html_url":"https://github.com/john-hill","followers_url":"https://api.github.com/users/john-hill/followers","following_url":"https://api.github.com/users/john-hill/following{/other_user}","gists_url":"https://api.github.com/users/john-hill/gists{/gist_id}","starred_url":"https://api.github.com/users/john-hill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/john-hill/subscriptions","organizations_url":"https://api.github.com/users/john-hill/orgs","repos_url":"https://api.github.com/users/john-hill/repos","events_url":"https://api.github.com/users/john-hill/events{/privacy}","received_events_url":"https://api.github.com/users/john-hill/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/john-hill/SynapseWebClient","description":"The web client of the Synapse REST service core","fork":true,"url":"https://api.github.com/repos/john-hill/SynapseWebClient","forks_url":"https://api.github.com/repos/john-hill/SynapseWebClient/forks","keys_url":"https://api.github.com/repos/john-hill/SynapseWebClient/keys{/key_id}","collaborators_url":"https://api.github.com/repos/john-hill/SynapseWebClient/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/john-hill/SynapseWebClient/teams","hooks_url":"https://api.github.com/repos/john-hill/SynapseWebClient/hooks","issue_events_url":"https://api.github.com/repos/john-hill/SynapseWebClient/issues/events{/number}","events_url":"https://api.github.com/repos/john-hill/SynapseWebClient/events","assignees_url":"https://api.github.com/repos/john-hill/SynapseWebClient/assignees{/user}","branches_url":"https://api.github.com/repos/john-hill/SynapseWebClient/branches{/branch}","tags_url":"https://api.github.com/repos/john-hill/SynapseWebClient/tags","blobs_url":"https://api.github.com/repos/john-hill/SynapseWebClient/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/john-hill/SynapseWebClient/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/john-hill/SynapseWebClient/git/refs{/sha}","trees_url":"https://api.github.com/repos/john-hill/SynapseWebClient/git/trees{/sha}","statuses_url":"https://api.github.com/repos/john-hill/SynapseWebClient/statuses/{sha}","languages_url":"https://api.github.com/repos/john-hill/SynapseWebClient/languages","stargazers_url":"https://api.github.com/repos/john-hill/SynapseWebClient/stargazers","contributors_url":"https://api.github.com/repos/john-hill/SynapseWebClient/contributors","subscribers_url":"https://api.github.com/repos/john-hill/SynapseWebClient/subscribers","subscription_url":"https://api.github.com/repos/john-hill/SynapseWebClient/subscription","commits_url":"https://api.github.com/repos/john-hill/SynapseWebClient/commits{/sha}","git_commits_url":"https://api.github.com/repos/john-hill/SynapseWebClient/git/commits{/sha}","comments_url":"https://api.github.com/repos/john-hill/SynapseWebClient/comments{/number}","issue_comment_url":"https://api.github.com/repos/john-hill/SynapseWebClient/issues/comments/{number}","contents_url":"https://api.github.com/repos/john-hill/SynapseWebClient/contents/{+path}","compare_url":"https://api.github.com/repos/john-hill/SynapseWebClient/compare/{base}...{head}","merges_url":"https://api.github.com/repos/john-hill/SynapseWebClient/merges","archive_url":"https://api.github.com/repos/john-hill/SynapseWebClient/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/john-hill/SynapseWebClient/downloads","issues_url":"https://api.github.com/repos/john-hill/SynapseWebClient/issues{/number}","pulls_url":"https://api.github.com/repos/john-hill/SynapseWebClient/pulls{/number}","milestones_url":"https://api.github.com/repos/john-hill/SynapseWebClient/milestones{/number}","notifications_url":"https://api.github.com/repos/john-hill/SynapseWebClient/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/john-hill/SynapseWebClient/labels{/name}","releases_url":"https://api.github.com/repos/john-hill/SynapseWebClient/releases{/id}","created_at":"2012-07-14T16:29:35Z","updated_at":"2014-06-25T01:50:58Z","pushed_at":"2014-10-31T00:42:54Z","git_url":"git://github.com/john-hill/SynapseWebClient.git","ssh_url":"git@github.com:john-hill/SynapseWebClient.git","clone_url":"https://github.com/john-hill/SynapseWebClient.git","svn_url":"https://github.com/john-hill/SynapseWebClient","homepage":null,"size":53159,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"Sage-Bionetworks:develop","ref":"develop","sha":"7a7d3ce79a6d72b864a95e8ca863dc23c92dabe7","user":{"login":"Sage-Bionetworks","id":1250897,"avatar_url":"https://avatars.githubusercontent.com/u/1250897?v=2","gravatar_id":"","url":"https://api.github.com/users/Sage-Bionetworks","html_url":"https://github.com/Sage-Bionetworks","followers_url":"https://api.github.com/users/Sage-Bionetworks/followers","following_url":"https://api.github.com/users/Sage-Bionetworks/following{/other_user}","gists_url":"https://api.github.com/users/Sage-Bionetworks/gists{/gist_id}","starred_url":"https://api.github.com/users/Sage-Bionetworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sage-Bionetworks/subscriptions","organizations_url":"https://api.github.com/users/Sage-Bionetworks/orgs","repos_url":"https://api.github.com/users/Sage-Bionetworks/repos","events_url":"https://api.github.com/users/Sage-Bionetworks/events{/privacy}","received_events_url":"https://api.github.com/users/Sage-Bionetworks/received_events","type":"Organization","site_admin":false},"repo":{"id":4302671,"name":"SynapseWebClient","full_name":"Sage-Bionetworks/SynapseWebClient","owner":{"login":"Sage-Bionetworks","id":1250897,"avatar_url":"https://avatars.githubusercontent.com/u/1250897?v=2","gravatar_id":"","url":"https://api.github.com/users/Sage-Bionetworks","html_url":"https://github.com/Sage-Bionetworks","followers_url":"https://api.github.com/users/Sage-Bionetworks/followers","following_url":"https://api.github.com/users/Sage-Bionetworks/following{/other_user}","gists_url":"https://api.github.com/users/Sage-Bionetworks/gists{/gist_id}","starred_url":"https://api.github.com/users/Sage-Bionetworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sage-Bionetworks/subscriptions","organizations_url":"https://api.github.com/users/Sage-Bionetworks/orgs","repos_url":"https://api.github.com/users/Sage-Bionetworks/repos","events_url":"https://api.github.com/users/Sage-Bionetworks/events{/privacy}","received_events_url":"https://api.github.com/users/Sage-Bionetworks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Sage-Bionetworks/SynapseWebClient","description":"The web client of the Synapse REST service core","fork":false,"url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient","forks_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/forks","keys_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/teams","hooks_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/hooks","issue_events_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/issues/events{/number}","events_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/events","assignees_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/assignees{/user}","branches_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/branches{/branch}","tags_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/tags","blobs_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/statuses/{sha}","languages_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/languages","stargazers_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/stargazers","contributors_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/contributors","subscribers_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/subscribers","subscription_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/subscription","commits_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/issues/comments/{number}","contents_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/contents/{+path}","compare_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/merges","archive_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/downloads","issues_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/issues{/number}","pulls_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/pulls{/number}","milestones_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/milestones{/number}","notifications_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/labels{/name}","releases_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/releases{/id}","created_at":"2012-05-11T23:11:54Z","updated_at":"2014-09-03T16:59:51Z","pushed_at":"2014-10-31T17:28:41Z","git_url":"git://github.com/Sage-Bionetworks/SynapseWebClient.git","ssh_url":"git@github.com:Sage-Bionetworks/SynapseWebClient.git","clone_url":"https://github.com/Sage-Bionetworks/SynapseWebClient.git","svn_url":"https://github.com/Sage-Bionetworks/SynapseWebClient","homepage":null,"size":53992,"stargazers_count":15,"watchers_count":15,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":4,"forks":19,"open_issues":4,"watchers":15,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/pulls/1285"},"html":{"href":"https://github.com/Sage-Bionetworks/SynapseWebClient/pull/1285"},"issue":{"href":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/issues/1285"},"comments":{"href":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/issues/1285/comments"},"review_comments":{"href":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/pulls/1285/comments"},"review_comment":{"href":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/pulls/1285/commits"},"statuses":{"href":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/statuses/65cb5c29ae21c5d21be5a6b086a3941d8d0b23bf"}}}}