GitHub PullRequestReviewCommentEvent at 2014-07-02 21:25:39
Repository: nixpkgs
Actor: flosse
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/14484829","id":14484829,"diff_hunk":"@@ -35,6 +35,9 @@ stdenv.mkDerivation rec {\n     sed <\"etc/lua.pc\" >\"$out/lib/pkgconfig/lua.pc\" -e \"s|^prefix=.*|prefix=$out|\"\n     mv \"doc/\"*.{gif,png,css,html} \"$out/share/doc/lua/\"\n     rmdir $out/{share,lib}/lua/5.1 $out/{share,lib}/lua\n+    wrapProgram $out/bin/lua \\\n+      --set LUA_PATH  '\"$HOME/.nix-profile/lib/lua/5.1/?.lua;$HOME/.nix-profile/share/lua/5.1/?.lua\"' \\\n+      --set LUA_CPATH '\"$HOME/.nix-profile/lib/lua/5.1/?.so;$HOME/.nix-profile/share/lua/5.1/?.so\"'","path":"pkgs/development/interpreters/lua-5/5.1.nix","position":26,"original_position":26,"commit_id":"0d3071835786d38ae8d1963935bec2d644a9cc3f","original_commit_id":"0d3071835786d38ae8d1963935bec2d644a9cc3f","user":{"login":"flosse","id":276043,"avatar_url":"https://avatars.githubusercontent.com/u/276043?","gravatar_id":"b2dae46e93c0529ad3642fa3e4eff907","url":"https://api.github.com/users/flosse","html_url":"https://github.com/flosse","followers_url":"https://api.github.com/users/flosse/followers","following_url":"https://api.github.com/users/flosse/following{/other_user}","gists_url":"https://api.github.com/users/flosse/gists{/gist_id}","starred_url":"https://api.github.com/users/flosse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flosse/subscriptions","organizations_url":"https://api.github.com/users/flosse/orgs","repos_url":"https://api.github.com/users/flosse/repos","events_url":"https://api.github.com/users/flosse/events{/privacy}","received_events_url":"https://api.github.com/users/flosse/received_events","type":"User","site_admin":false},"body":"@bjornfor I'm totally new to Nix so I'd be happy for some more hints :)","created_at":"2014-07-02T21:25:39Z","updated_at":"2014-07-02T21:25:39Z","html_url":"https://github.com/NixOS/nixpkgs/pull/3137#discussion_r14484829","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/3137","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/14484829"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/3137#discussion_r14484829"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/3137"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/3137","id":17753290,"html_url":"https://github.com/NixOS/nixpkgs/pull/3137","diff_url":"https://github.com/NixOS/nixpkgs/pull/3137.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/3137.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/3137","number":3137,"state":"closed","title":"use wrapper to set LUA_PATH variable to fix #3036","user":{"login":"flosse","id":276043,"avatar_url":"https://avatars.githubusercontent.com/u/276043?","gravatar_id":"b2dae46e93c0529ad3642fa3e4eff907","url":"https://api.github.com/users/flosse","html_url":"https://github.com/flosse","followers_url":"https://api.github.com/users/flosse/followers","following_url":"https://api.github.com/users/flosse/following{/other_user}","gists_url":"https://api.github.com/users/flosse/gists{/gist_id}","starred_url":"https://api.github.com/users/flosse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flosse/subscriptions","organizations_url":"https://api.github.com/users/flosse/orgs","repos_url":"https://api.github.com/users/flosse/repos","events_url":"https://api.github.com/users/flosse/events{/privacy}","received_events_url":"https://api.github.com/users/flosse/received_events","type":"User","site_admin":false},"body":"Here is an approach to fix #3036.","created_at":"2014-06-30T01:45:30Z","updated_at":"2014-07-02T21:25:39Z","closed_at":"2014-07-02T18:47:21Z","merged_at":"2014-07-02T18:47:21Z","merge_commit_sha":"8025370cbd7815e195a4408630357cdf0767acdd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/3137/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/3137/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/{number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/3137/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/0d3071835786d38ae8d1963935bec2d644a9cc3f","head":{"label":"flosse:lua5-prefix-fix","ref":"lua5-prefix-fix","sha":"0d3071835786d38ae8d1963935bec2d644a9cc3f","user":{"login":"flosse","id":276043,"avatar_url":"https://avatars.githubusercontent.com/u/276043?","gravatar_id":"b2dae46e93c0529ad3642fa3e4eff907","url":"https://api.github.com/users/flosse","html_url":"https://github.com/flosse","followers_url":"https://api.github.com/users/flosse/followers","following_url":"https://api.github.com/users/flosse/following{/other_user}","gists_url":"https://api.github.com/users/flosse/gists{/gist_id}","starred_url":"https://api.github.com/users/flosse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flosse/subscriptions","organizations_url":"https://api.github.com/users/flosse/orgs","repos_url":"https://api.github.com/users/flosse/repos","events_url":"https://api.github.com/users/flosse/events{/privacy}","received_events_url":"https://api.github.com/users/flosse/received_events","type":"User","site_admin":false},"repo":{"id":20982320,"name":"nixpkgs","full_name":"flosse/nixpkgs","owner":{"login":"flosse","id":276043,"avatar_url":"https://avatars.githubusercontent.com/u/276043?","gravatar_id":"b2dae46e93c0529ad3642fa3e4eff907","url":"https://api.github.com/users/flosse","html_url":"https://github.com/flosse","followers_url":"https://api.github.com/users/flosse/followers","following_url":"https://api.github.com/users/flosse/following{/other_user}","gists_url":"https://api.github.com/users/flosse/gists{/gist_id}","starred_url":"https://api.github.com/users/flosse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flosse/subscriptions","organizations_url":"https://api.github.com/users/flosse/orgs","repos_url":"https://api.github.com/users/flosse/repos","events_url":"https://api.github.com/users/flosse/events{/privacy}","received_events_url":"https://api.github.com/users/flosse/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/flosse/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/flosse/nixpkgs","forks_url":"https://api.github.com/repos/flosse/nixpkgs/forks","keys_url":"https://api.github.com/repos/flosse/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flosse/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flosse/nixpkgs/teams","hooks_url":"https://api.github.com/repos/flosse/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/flosse/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/flosse/nixpkgs/events","assignees_url":"https://api.github.com/repos/flosse/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/flosse/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/flosse/nixpkgs/tags","blobs_url":"https://api.github.com/repos/flosse/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flosse/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flosse/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/flosse/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flosse/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/flosse/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/flosse/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/flosse/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/flosse/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/flosse/nixpkgs/subscription","commits_url":"https://api.github.com/repos/flosse/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/flosse/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/flosse/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/flosse/nixpkgs/issues/comments/{number}","contents_url":"https://api.github.com/repos/flosse/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/flosse/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flosse/nixpkgs/merges","archive_url":"https://api.github.com/repos/flosse/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flosse/nixpkgs/downloads","issues_url":"https://api.github.com/repos/flosse/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/flosse/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/flosse/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/flosse/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flosse/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/flosse/nixpkgs/releases{/id}","created_at":"2014-06-19T00:20:02Z","updated_at":"2014-06-19T00:20:13Z","pushed_at":"2014-07-01T17:19:46Z","git_url":"git://github.com/flosse/nixpkgs.git","ssh_url":"git@github.com:flosse/nixpkgs.git","clone_url":"https://github.com/flosse/nixpkgs.git","svn_url":"https://github.com/flosse/nixpkgs","homepage":null,"size":130697,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"f8e984b9b24f05891ddef1309d57bc3071ed1c4c","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?","gravatar_id":"ef3a4fb799584882e0f7a40f9aec1b09","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?","gravatar_id":"ef3a4fb799584882e0f7a40f9aec1b09","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments/{number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","created_at":"2012-06-04T02:49:46Z","updated_at":"2014-06-30T13:35:37Z","pushed_at":"2014-07-02T20:57:14Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":239932,"stargazers_count":235,"watchers_count":235,"language":"Nix","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":304,"mirror_url":null,"open_issues_count":327,"forks":304,"open_issues":327,"watchers":235,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/3137"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/3137"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/3137"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/3137/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/3137/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/3137/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/0d3071835786d38ae8d1963935bec2d644a9cc3f"}}}}