GitHub PullRequestReviewCommentEvent at 2014-06-23 02:23:27
Repository: ost
Actor: lakshmivyas
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/lml/ost/pulls/comments/14058897","id":14058897,"diff_hunk":"@@ -95,7 +99,7 @@\n \n <% end %>\n \n-<% if klass.is_educator?(present_user) || Researcher.is_one?(present_user) || present_user.is_administrator? %>\n+<% if authority? %>","path":"app/views/assignments/show.html.erb","position":29,"original_position":29,"commit_id":"2d324f97dde3d7a0aeb5d810bebb3e52206f13ac","original_commit_id":"2b2decdd860997c64f9f65485ca4dac54c854086","user":{"login":"lakshmivyas","id":45002,"avatar_url":"https://avatars.githubusercontent.com/u/45002?","gravatar_id":"c8f2e9e405caa51f2ee776505e1ee8f1","url":"https://api.github.com/users/lakshmivyas","html_url":"https://github.com/lakshmivyas","followers_url":"https://api.github.com/users/lakshmivyas/followers","following_url":"https://api.github.com/users/lakshmivyas/following{/other_user}","gists_url":"https://api.github.com/users/lakshmivyas/gists{/gist_id}","starred_url":"https://api.github.com/users/lakshmivyas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lakshmivyas/subscriptions","organizations_url":"https://api.github.com/users/lakshmivyas/orgs","repos_url":"https://api.github.com/users/lakshmivyas/repos","events_url":"https://api.github.com/users/lakshmivyas/events{/privacy}","received_events_url":"https://api.github.com/users/lakshmivyas/received_events","type":"User","site_admin":false},"body":"@Dantemss : Thanks for the detailed explanation.  This was very helpful.  I added memoization to the `authority?` function. (See 2d324f9).","created_at":"2014-06-23T02:23:27Z","updated_at":"2014-06-23T02:23:27Z","html_url":"https://github.com/lml/ost/pull/349#discussion_r14058897","pull_request_url":"https://api.github.com/repos/lml/ost/pulls/349","_links":{"self":{"href":"https://api.github.com/repos/lml/ost/pulls/comments/14058897"},"html":{"href":"https://github.com/lml/ost/pull/349#discussion_r14058897"},"pull_request":{"href":"https://api.github.com/repos/lml/ost/pulls/349"}}},"pull_request":{"url":"https://api.github.com/repos/lml/ost/pulls/349","id":17038502,"html_url":"https://github.com/lml/ost/pull/349","diff_url":"https://github.com/lml/ost/pull/349.diff","patch_url":"https://github.com/lml/ost/pull/349.patch","issue_url":"https://api.github.com/repos/lml/ost/issues/349","number":349,"state":"open","title":"lml/ost#345: Add questions with links to exercises section.","user":{"login":"lakshmivyas","id":45002,"avatar_url":"https://avatars.githubusercontent.com/u/45002?","gravatar_id":"c8f2e9e405caa51f2ee776505e1ee8f1","url":"https://api.github.com/users/lakshmivyas","html_url":"https://github.com/lakshmivyas","followers_url":"https://api.github.com/users/lakshmivyas/followers","following_url":"https://api.github.com/users/lakshmivyas/following{/other_user}","gists_url":"https://api.github.com/users/lakshmivyas/gists{/gist_id}","starred_url":"https://api.github.com/users/lakshmivyas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lakshmivyas/subscriptions","organizations_url":"https://api.github.com/users/lakshmivyas/orgs","repos_url":"https://api.github.com/users/lakshmivyas/repos","events_url":"https://api.github.com/users/lakshmivyas/events{/privacy}","received_events_url":"https://api.github.com/users/lakshmivyas/received_events","type":"User","site_admin":false},"body":"- Add `family` scope and method to the assignment model.\r\n- Add `_questions` partial to show the exercise questions.\r\n- Add `show_url` param and ability to the `_question` partial.\r\n- Add `authority?` view helper function.\r\n- Use `authority?` view helper function.\r\n- Fix copyrights.\r\n\r\nTODO:\r\n\r\n- The styles for questions are a little weird.  Leaving things\r\n  as is to wait for the UX review.","created_at":"2014-06-12T05:49:30Z","updated_at":"2014-06-23T02:23:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d5285ccccfc338361f319ecabe6f0fa0e0abc43","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lml/ost/pulls/349/commits","review_comments_url":"https://api.github.com/repos/lml/ost/pulls/349/comments","review_comment_url":"https://api.github.com/repos/lml/ost/pulls/comments/{number}","comments_url":"https://api.github.com/repos/lml/ost/issues/349/comments","statuses_url":"https://api.github.com/repos/lml/ost/statuses/2d324f97dde3d7a0aeb5d810bebb3e52206f13ac","head":{"label":"lakshmivyas:feature/linkqb","ref":"feature/linkqb","sha":"2d324f97dde3d7a0aeb5d810bebb3e52206f13ac","user":{"login":"lakshmivyas","id":45002,"avatar_url":"https://avatars.githubusercontent.com/u/45002?","gravatar_id":"c8f2e9e405caa51f2ee776505e1ee8f1","url":"https://api.github.com/users/lakshmivyas","html_url":"https://github.com/lakshmivyas","followers_url":"https://api.github.com/users/lakshmivyas/followers","following_url":"https://api.github.com/users/lakshmivyas/following{/other_user}","gists_url":"https://api.github.com/users/lakshmivyas/gists{/gist_id}","starred_url":"https://api.github.com/users/lakshmivyas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lakshmivyas/subscriptions","organizations_url":"https://api.github.com/users/lakshmivyas/orgs","repos_url":"https://api.github.com/users/lakshmivyas/repos","events_url":"https://api.github.com/users/lakshmivyas/events{/privacy}","received_events_url":"https://api.github.com/users/lakshmivyas/received_events","type":"User","site_admin":false},"repo":{"id":19930670,"name":"ost","full_name":"lakshmivyas/ost","owner":{"login":"lakshmivyas","id":45002,"avatar_url":"https://avatars.githubusercontent.com/u/45002?","gravatar_id":"c8f2e9e405caa51f2ee776505e1ee8f1","url":"https://api.github.com/users/lakshmivyas","html_url":"https://github.com/lakshmivyas","followers_url":"https://api.github.com/users/lakshmivyas/followers","following_url":"https://api.github.com/users/lakshmivyas/following{/other_user}","gists_url":"https://api.github.com/users/lakshmivyas/gists{/gist_id}","starred_url":"https://api.github.com/users/lakshmivyas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lakshmivyas/subscriptions","organizations_url":"https://api.github.com/users/lakshmivyas/orgs","repos_url":"https://api.github.com/users/lakshmivyas/repos","events_url":"https://api.github.com/users/lakshmivyas/events{/privacy}","received_events_url":"https://api.github.com/users/lakshmivyas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lakshmivyas/ost","description":"OpenStax Tutor","fork":true,"url":"https://api.github.com/repos/lakshmivyas/ost","forks_url":"https://api.github.com/repos/lakshmivyas/ost/forks","keys_url":"https://api.github.com/repos/lakshmivyas/ost/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lakshmivyas/ost/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lakshmivyas/ost/teams","hooks_url":"https://api.github.com/repos/lakshmivyas/ost/hooks","issue_events_url":"https://api.github.com/repos/lakshmivyas/ost/issues/events{/number}","events_url":"https://api.github.com/repos/lakshmivyas/ost/events","assignees_url":"https://api.github.com/repos/lakshmivyas/ost/assignees{/user}","branches_url":"https://api.github.com/repos/lakshmivyas/ost/branches{/branch}","tags_url":"https://api.github.com/repos/lakshmivyas/ost/tags","blobs_url":"https://api.github.com/repos/lakshmivyas/ost/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lakshmivyas/ost/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lakshmivyas/ost/git/refs{/sha}","trees_url":"https://api.github.com/repos/lakshmivyas/ost/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lakshmivyas/ost/statuses/{sha}","languages_url":"https://api.github.com/repos/lakshmivyas/ost/languages","stargazers_url":"https://api.github.com/repos/lakshmivyas/ost/stargazers","contributors_url":"https://api.github.com/repos/lakshmivyas/ost/contributors","subscribers_url":"https://api.github.com/repos/lakshmivyas/ost/subscribers","subscription_url":"https://api.github.com/repos/lakshmivyas/ost/subscription","commits_url":"https://api.github.com/repos/lakshmivyas/ost/commits{/sha}","git_commits_url":"https://api.github.com/repos/lakshmivyas/ost/git/commits{/sha}","comments_url":"https://api.github.com/repos/lakshmivyas/ost/comments{/number}","issue_comment_url":"https://api.github.com/repos/lakshmivyas/ost/issues/comments/{number}","contents_url":"https://api.github.com/repos/lakshmivyas/ost/contents/{+path}","compare_url":"https://api.github.com/repos/lakshmivyas/ost/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lakshmivyas/ost/merges","archive_url":"https://api.github.com/repos/lakshmivyas/ost/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lakshmivyas/ost/downloads","issues_url":"https://api.github.com/repos/lakshmivyas/ost/issues{/number}","pulls_url":"https://api.github.com/repos/lakshmivyas/ost/pulls{/number}","milestones_url":"https://api.github.com/repos/lakshmivyas/ost/milestones{/number}","notifications_url":"https://api.github.com/repos/lakshmivyas/ost/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lakshmivyas/ost/labels{/name}","releases_url":"https://api.github.com/repos/lakshmivyas/ost/releases{/id}","created_at":"2014-05-19T05:56:38Z","updated_at":"2014-06-23T02:22:06Z","pushed_at":"2014-06-23T02:22:06Z","git_url":"git://github.com/lakshmivyas/ost.git","ssh_url":"git@github.com:lakshmivyas/ost.git","clone_url":"https://github.com/lakshmivyas/ost.git","svn_url":"https://github.com/lakshmivyas/ost","homepage":null,"size":10125,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lml:master","ref":"master","sha":"2c65099a4c8f553f5dc57d796cdd586164efc76f","user":{"login":"lml","id":1001889,"avatar_url":"https://avatars.githubusercontent.com/u/1001889?","gravatar_id":"0315212faeeff16b747f5ffdd9c9e928","url":"https://api.github.com/users/lml","html_url":"https://github.com/lml","followers_url":"https://api.github.com/users/lml/followers","following_url":"https://api.github.com/users/lml/following{/other_user}","gists_url":"https://api.github.com/users/lml/gists{/gist_id}","starred_url":"https://api.github.com/users/lml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lml/subscriptions","organizations_url":"https://api.github.com/users/lml/orgs","repos_url":"https://api.github.com/users/lml/repos","events_url":"https://api.github.com/users/lml/events{/privacy}","received_events_url":"https://api.github.com/users/lml/received_events","type":"Organization","site_admin":false},"repo":{"id":5051390,"name":"ost","full_name":"lml/ost","owner":{"login":"lml","id":1001889,"avatar_url":"https://avatars.githubusercontent.com/u/1001889?","gravatar_id":"0315212faeeff16b747f5ffdd9c9e928","url":"https://api.github.com/users/lml","html_url":"https://github.com/lml","followers_url":"https://api.github.com/users/lml/followers","following_url":"https://api.github.com/users/lml/following{/other_user}","gists_url":"https://api.github.com/users/lml/gists{/gist_id}","starred_url":"https://api.github.com/users/lml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lml/subscriptions","organizations_url":"https://api.github.com/users/lml/orgs","repos_url":"https://api.github.com/users/lml/repos","events_url":"https://api.github.com/users/lml/events{/privacy}","received_events_url":"https://api.github.com/users/lml/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lml/ost","description":"OpenStax Tutor","fork":false,"url":"https://api.github.com/repos/lml/ost","forks_url":"https://api.github.com/repos/lml/ost/forks","keys_url":"https://api.github.com/repos/lml/ost/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lml/ost/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lml/ost/teams","hooks_url":"https://api.github.com/repos/lml/ost/hooks","issue_events_url":"https://api.github.com/repos/lml/ost/issues/events{/number}","events_url":"https://api.github.com/repos/lml/ost/events","assignees_url":"https://api.github.com/repos/lml/ost/assignees{/user}","branches_url":"https://api.github.com/repos/lml/ost/branches{/branch}","tags_url":"https://api.github.com/repos/lml/ost/tags","blobs_url":"https://api.github.com/repos/lml/ost/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lml/ost/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lml/ost/git/refs{/sha}","trees_url":"https://api.github.com/repos/lml/ost/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lml/ost/statuses/{sha}","languages_url":"https://api.github.com/repos/lml/ost/languages","stargazers_url":"https://api.github.com/repos/lml/ost/stargazers","contributors_url":"https://api.github.com/repos/lml/ost/contributors","subscribers_url":"https://api.github.com/repos/lml/ost/subscribers","subscription_url":"https://api.github.com/repos/lml/ost/subscription","commits_url":"https://api.github.com/repos/lml/ost/commits{/sha}","git_commits_url":"https://api.github.com/repos/lml/ost/git/commits{/sha}","comments_url":"https://api.github.com/repos/lml/ost/comments{/number}","issue_comment_url":"https://api.github.com/repos/lml/ost/issues/comments/{number}","contents_url":"https://api.github.com/repos/lml/ost/contents/{+path}","compare_url":"https://api.github.com/repos/lml/ost/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lml/ost/merges","archive_url":"https://api.github.com/repos/lml/ost/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lml/ost/downloads","issues_url":"https://api.github.com/repos/lml/ost/issues{/number}","pulls_url":"https://api.github.com/repos/lml/ost/pulls{/number}","milestones_url":"https://api.github.com/repos/lml/ost/milestones{/number}","notifications_url":"https://api.github.com/repos/lml/ost/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lml/ost/labels{/name}","releases_url":"https://api.github.com/repos/lml/ost/releases{/id}","created_at":"2012-07-14T21:54:32Z","updated_at":"2014-06-16T15:14:13Z","pushed_at":"2014-06-16T15:14:12Z","git_url":"git://github.com/lml/ost.git","ssh_url":"git@github.com:lml/ost.git","clone_url":"https://github.com/lml/ost.git","svn_url":"https://github.com/lml/ost","homepage":null,"size":11164,"stargazers_count":5,"watchers_count":5,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":6,"mirror_url":null,"open_issues_count":89,"forks":6,"open_issues":89,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lml/ost/pulls/349"},"html":{"href":"https://github.com/lml/ost/pull/349"},"issue":{"href":"https://api.github.com/repos/lml/ost/issues/349"},"comments":{"href":"https://api.github.com/repos/lml/ost/issues/349/comments"},"review_comments":{"href":"https://api.github.com/repos/lml/ost/pulls/349/comments"},"review_comment":{"href":"https://api.github.com/repos/lml/ost/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/lml/ost/pulls/349/commits"},"statuses":{"href":"https://api.github.com/repos/lml/ost/statuses/2d324f97dde3d7a0aeb5d810bebb3e52206f13ac"}}}}