GitHub PullRequestReviewCommentEvent at 2014-02-03 17:14:36
Repository: rust
Actor: alexcrichton
Payload: {"comment":{"url":"https://api.github.com/repos/mozilla/rust/pulls/comments/9390509","id":9390509,"diff_hunk":"@@ -64,7 +68,8 @@ pub struct AtomicUint {\n  */\n pub struct AtomicPtr<T> {\n     priv p: *mut T,\n-    priv nocopy: NonCopyable\n+    priv freeze: marker::NoFreeze,","path":"src/libstd/sync/atomics.rs","position":null,"original_position":55,"commit_id":"2db7d0663aa3e08c0472642733cd302dba104f8b","original_commit_id":"4b57e560992506ea80e37c8e36e8d961e9518478","user":{"login":"alexcrichton","id":64996,"avatar_url":"https://gravatar.com/avatar/477e2098d9864b482d28e5ef8e657f43?d=https%3A%2F%2Fidenticons.github.com%2F621df6a7a3377f22b1ae3afc962c3f68.png&r=x","gravatar_id":"477e2098d9864b482d28e5ef8e657f43","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"body":"Hm, right now all the methods take `&mut self`, so I don't think that this is necessary just yet. If we decide to go with #11583, however, they will need to be `no_freeze` because they would all take `&self`.","created_at":"2014-02-03T17:14:36Z","updated_at":"2014-02-03T17:14:36Z","html_url":"https://github.com/mozilla/rust/pull/12016#discussion_r9390509","pull_request_url":"https://api.github.com/repos/mozilla/rust/pulls/12016","_links":{"self":{"href":"https://api.github.com/repos/mozilla/rust/pulls/comments/9390509"},"html":{"href":"https://github.com/mozilla/rust/pull/12016#discussion_r9390509"},"pull_request":{"href":"https://api.github.com/repos/mozilla/rust/pulls/12016"}}}}