GitHub PullRequestReviewCommentEvent at 2014-08-06 13:42:09
Repository: frontend
Actor: ironsidevsquincy
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/guardian/frontend/pulls/comments/15873701","id":15873701,"diff_hunk":"@@ -1,27 +1,31 @@\n-@(video: Option[VideoElement], title: String)\n+@(video: model.VideoElement, profile: views.support.Profile, title: String, width: Int, height: Int, use16_9AspectRatio: Boolean = true)\n \n-@video.map { video =>\n-    @defining(Item620.bestFor(video).getOrElse(Static(\"images/media-holding.jpg\"))) { poster =>\n-        <div class=\"gu-media-wrapper gu-media-wrapper--video\">\n-            <div class=\"u-responsive-ratio u-responsive-ratio--hd\">\n-                <video controls=\"controls\" class=\"gu-media gu-media--video js-gu-media\" data-title=\"@title\"\n-                    poster=\"@poster\" data-duration=\"@video.duration.toString()\" data-media-id=\"@video.id\">\n+@import conf.Static\n+@import views.support.RenderClasses\n \n-                    @video.encodings.map { encoding =>\n-                        <source src=\"@encoding.url\" type=\"@encoding.format\" />\n-                    }\n+@defining(profile.bestFor(video).getOrElse(Static(\"images/media-holding.jpg\"))) { poster =>\n+    <div class=\"gu-media-wrapper gu-media-wrapper--video\">\n+        <div class=\"@RenderClasses(Map(\n+            \"u-responsive-ratio\" -> true,\n+            \"u-responsive-ratio--hd\" -> use16_9AspectRatio\n+        ))\">\n+            <video controls=\"controls\" class=\"gu-media gu-media--video js-gu-media\" data-title=\"@title\"\n+                poster=\"@poster\" data-duration=\"@video.duration.toString()\" data-media-id=\"@video.id\">\n \n-                    @video.encodings.find(_.format == \"video/mp4\").map { encoding =>\n-                        <object type=\"application/x-shockwave-flash\" data=\"@Static(\"flash/flashmediaelement.swf\")\" width=\"620\" height=\"350\">\n-                            <param name=\"allowFullScreen\" value=\"true\" />\n-                            <param name=\"movie\" value=\"@Static(\"flash/flashmediaelement.swf\")\" />\n-                            <param name=\"flashvars\" value=\"controls=true&amp;file=@encoding.url\" />\n-                            <img src=\"@poster\" alt=\"\" width=\"620\" height=\"350\" />\n-                            Sorry, your browser is unable to play this video.\n-                        </object>\n-                    }\n-                </video>\n-            </div>\n+                @video.encodings.map { encoding =>\n+                    <source src=\"@encoding.url\" type=\"@encoding.format\" />\n+                }\n+\n+                @video.encodings.find(_.format == \"video/mp4\").map { encoding =>\n+                    <object type=\"application/x-shockwave-flash\" data=\"@Static(\"flash/flashmediaelement.swf\")\" width=\"@width\" height=\"@height\">\n+                        <param name=\"allowFullScreen\" value=\"true\" />\n+                        <param name=\"movie\" value=\"@Static(\"flash/flashmediaelement.swf\")\" />\n+                        <param name=\"flashvars\" value=\"controls=true&amp;file=@encoding.url\" />\n+                        <img src=\"@poster\" alt=\"\" width=\"@width\" height=\"@height\" />","path":"common/app/views/fragments/media/video.scala.html","position":45,"original_position":45,"commit_id":"42f8607de4186b7d8d1055241f687c6825b692c9","original_commit_id":"42f8607de4186b7d8d1055241f687c6825b692c9","user":{"login":"ironsidevsquincy","id":74132,"avatar_url":"https://avatars.githubusercontent.com/u/74132?v=2","gravatar_id":"3995af57bb75c35dbc360f7178d113f0","url":"https://api.github.com/users/ironsidevsquincy","html_url":"https://github.com/ironsidevsquincy","followers_url":"https://api.github.com/users/ironsidevsquincy/followers","following_url":"https://api.github.com/users/ironsidevsquincy/following{/other_user}","gists_url":"https://api.github.com/users/ironsidevsquincy/gists{/gist_id}","starred_url":"https://api.github.com/users/ironsidevsquincy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ironsidevsquincy/subscriptions","organizations_url":"https://api.github.com/users/ironsidevsquincy/orgs","repos_url":"https://api.github.com/users/ironsidevsquincy/repos","events_url":"https://api.github.com/users/ironsidevsquincy/events{/privacy}","received_events_url":"https://api.github.com/users/ironsidevsquincy/received_events","type":"User","site_admin":false},"body":"annoying that we have to pass in these; wonder if we can leave them out","created_at":"2014-08-06T13:42:09Z","updated_at":"2014-08-06T13:42:09Z","html_url":"https://github.com/guardian/frontend/pull/5392#discussion_r15873701","pull_request_url":"https://api.github.com/repos/guardian/frontend/pulls/5392","_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments/15873701"},"html":{"href":"https://github.com/guardian/frontend/pull/5392#discussion_r15873701"},"pull_request":{"href":"https://api.github.com/repos/guardian/frontend/pulls/5392"}}},"pull_request":{"url":"https://api.github.com/repos/guardian/frontend/pulls/5392","id":19396640,"html_url":"https://github.com/guardian/frontend/pull/5392","diff_url":"https://github.com/guardian/frontend/pull/5392.diff","patch_url":"https://github.com/guardian/frontend/pull/5392.patch","issue_url":"https://api.github.com/repos/guardian/frontend/issues/5392","number":5392,"state":"open","title":"Play video in fronts","user":{"login":"robertberry","id":1001642,"avatar_url":"https://avatars.githubusercontent.com/u/1001642?v=2","gravatar_id":"fcbb2e5042107b14a7edb045199c1412","url":"https://api.github.com/users/robertberry","html_url":"https://github.com/robertberry","followers_url":"https://api.github.com/users/robertberry/followers","following_url":"https://api.github.com/users/robertberry/following{/other_user}","gists_url":"https://api.github.com/users/robertberry/gists{/gist_id}","starred_url":"https://api.github.com/users/robertberry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertberry/subscriptions","organizations_url":"https://api.github.com/users/robertberry/orgs","repos_url":"https://api.github.com/users/robertberry/repos","events_url":"https://api.github.com/users/robertberry/events{/privacy}","received_events_url":"https://api.github.com/users/robertberry/received_events","type":"User","site_admin":false},"body":"Only does it if the size of what the image would have been is large enough ...\r\n\r\nSo you get it playing on baguette, on fromage (boosted) and on rows of two big items. (Which includes when the item is boosted to the left, boosted to the right, or when both items are boosted.)\r\n\r\n@mattosborn was going to look into whether I needed to add anything for the tracking or whether it should just work off the bat.\r\n\r\n@mattosborn, @kaelig, please could you look at this and let me know if it's all kosher?\r\n\r\n![screen shot 2014-08-05 at 15 45 45](https://cloud.githubusercontent.com/assets/1001642/3825645/9c28ed44-1d56-11e4-8636-4821e535d081.png)\r\n\r\n![screen shot 2014-08-05 at 15 45 57](https://cloud.githubusercontent.com/assets/1001642/3825646/9fc83e46-1d56-11e4-9af5-332bdd55fa47.png)\r\n\r\n![screen shot 2014-08-05 at 15 46 06](https://cloud.githubusercontent.com/assets/1001642/3825647/a208964c-1d56-11e4-835f-f7982fbca9af.png)\r\n\r\n![screen shot 2014-08-06 at 11 19 06](https://cloud.githubusercontent.com/assets/1001642/3825655/b8798ed6-1d56-11e4-8bd4-a5be2f760bf3.png)\r\n\r\n![screen shot 2014-08-06 at 11 19 29](https://cloud.githubusercontent.com/assets/1001642/3825656/c1995fb4-1d56-11e4-8deb-c80c3eb20166.png)\r\n\r\n![screen shot 2014-08-06 at 11 19 36](https://cloud.githubusercontent.com/assets/1001642/3825658/cc2e79be-1d56-11e4-8ff7-607d507fd263.png)\r\n\r\n![screen shot 2014-08-06 at 11 20 06](https://cloud.githubusercontent.com/assets/1001642/3825660/d74e6962-1d56-11e4-9b81-fdeba10bbcd1.png)\r\n\r\n![screen shot 2014-08-06 at 11 20 19](https://cloud.githubusercontent.com/assets/1001642/3825662/db859406-1d56-11e4-887f-aec9156eb1f3.png)\r\n\r\n![screen shot 2014-08-06 at 11 20 29](https://cloud.githubusercontent.com/assets/1001642/3825663/deab0d28-1d56-11e4-9006-c4db67d2777f.png)\r\n\r\n![screen shot 2014-08-06 at 11 22 09](https://cloud.githubusercontent.com/assets/1001642/3825664/e5a8e1b8-1d56-11e4-90a7-5fc3c91c44e4.png)\r\n\r\n![screen shot 2014-08-06 at 11 22 19](https://cloud.githubusercontent.com/assets/1001642/3825665/e89921bc-1d56-11e4-81bd-2a251a83df85.png)\r\n\r\n![screen shot 2014-08-06 at 11 22 26](https://cloud.githubusercontent.com/assets/1001642/3825666/eaa86b3e-1d56-11e4-8838-dc9b25531db8.png)\r\n","created_at":"2014-08-06T10:47:01Z","updated_at":"2014-08-06T13:42:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6be209dac5502732650cf66d4b8abe734f2fe149","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/guardian/frontend/pulls/5392/commits","review_comments_url":"https://api.github.com/repos/guardian/frontend/pulls/5392/comments","review_comment_url":"https://api.github.com/repos/guardian/frontend/pulls/comments/{number}","comments_url":"https://api.github.com/repos/guardian/frontend/issues/5392/comments","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/42f8607de4186b7d8d1055241f687c6825b692c9","head":{"label":"guardian:play-video-in-fronts","ref":"play-video-in-fronts","sha":"42f8607de4186b7d8d1055241f687c6825b692c9","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=2","gravatar_id":"2ddf2e74b78084fcf451b3cdeb075e73","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=2","gravatar_id":"2ddf2e74b78084fcf451b3cdeb075e73","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for the Guardian's responsive site, coming soon to a desktop near you...","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments/{number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","created_at":"2012-05-18T15:39:15Z","updated_at":"2014-08-05T13:06:50Z","pushed_at":"2014-08-06T13:35:28Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"http://www.theguardian.com/uk?view=mobile","size":437322,"stargazers_count":2194,"watchers_count":2194,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":183,"mirror_url":null,"open_issues_count":55,"forks":183,"open_issues":55,"watchers":2194,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"e9622eec13fe4a37739c697523500977fbeebd78","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=2","gravatar_id":"2ddf2e74b78084fcf451b3cdeb075e73","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=2","gravatar_id":"2ddf2e74b78084fcf451b3cdeb075e73","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for the Guardian's responsive site, coming soon to a desktop near you...","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments/{number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","created_at":"2012-05-18T15:39:15Z","updated_at":"2014-08-05T13:06:50Z","pushed_at":"2014-08-06T13:35:28Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"http://www.theguardian.com/uk?view=mobile","size":437322,"stargazers_count":2194,"watchers_count":2194,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":183,"mirror_url":null,"open_issues_count":55,"forks":183,"open_issues":55,"watchers":2194,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/5392"},"html":{"href":"https://github.com/guardian/frontend/pull/5392"},"issue":{"href":"https://api.github.com/repos/guardian/frontend/issues/5392"},"comments":{"href":"https://api.github.com/repos/guardian/frontend/issues/5392/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/frontend/pulls/5392/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/guardian/frontend/pulls/5392/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/frontend/statuses/42f8607de4186b7d8d1055241f687c6825b692c9"}}}}