GitHub PullRequestReviewCommentEvent at 2014-04-23 14:19:28
Repository: Theano
Actor: abergeron
Payload: {"comment":{"url":"https://api.github.com/repos/Theano/Theano/pulls/comments/11902093","id":11902093,"diff_hunk":"@@ -159,6 +184,13 @@ def local_gpureshape(node):\n \n \n @register_opt()\n+@op_lifter([tensor.Rebroadcast])\n+def local_gpu_rebroadcast(node):\n+    if isinstance(node.inputs[0].owner.op, HostFromGpu):\n+        return node.op(node.inputs[0].owner.inputs[0])","path":"theano/sandbox/gpuarray/opt.py","position":101,"original_position":101,"commit_id":"a11b232f62842309787aa4490d2c384cca5d656a","original_commit_id":"a11b232f62842309787aa4490d2c384cca5d656a","user":{"login":"abergeron","id":1002504,"avatar_url":"https://avatars.githubusercontent.com/u/1002504?","gravatar_id":"cd77a1586454ca2d9ee66c9ef292dba0","url":"https://api.github.com/users/abergeron","html_url":"https://github.com/abergeron","followers_url":"https://api.github.com/users/abergeron/followers","following_url":"https://api.github.com/users/abergeron/following{/other_user}","gists_url":"https://api.github.com/users/abergeron/gists{/gist_id}","starred_url":"https://api.github.com/users/abergeron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abergeron/subscriptions","organizations_url":"https://api.github.com/users/abergeron/orgs","repos_url":"https://api.github.com/users/abergeron/repos","events_url":"https://api.github.com/users/abergeron/events{/privacy}","received_events_url":"https://api.github.com/users/abergeron/received_events","type":"User","site_admin":false},"body":"I really don't see what kind of test this can have.  It's essentially a ViewOp that changes the broadcastable properties (and that remains in the graph, which should be fixed eventually I guess).\r\n\r\nDo you just want me to test that we can make graphs with it?  Or that it introduces no transfers?","created_at":"2014-04-23T14:19:28Z","updated_at":"2014-04-23T14:19:28Z","html_url":"https://github.com/Theano/Theano/pull/1807#discussion_r11902093","pull_request_url":"https://api.github.com/repos/Theano/Theano/pulls/1807","_links":{"self":{"href":"https://api.github.com/repos/Theano/Theano/pulls/comments/11902093"},"html":{"href":"https://github.com/Theano/Theano/pull/1807#discussion_r11902093"},"pull_request":{"href":"https://api.github.com/repos/Theano/Theano/pulls/1807"}}}}