GitHub PullRequestReviewCommentEvent at 2014-10-19 11:06:44
Repository: OpenBazaar
Actor: Renelvon
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/pulls/comments/19059500","id":19059500,"diff_hunk":"@@ -227,11 +225,11 @@ def peer_to_tuple(self):\n     def get_guid(self):\n         return self.guid\n \n-\n class PeerListener(object):\n-    def __init__(self, ip, port, ctx, data_cb):\n+    def __init__(self, ip, port, ctx, guid, data_cb):\n         self.ip = ip\n         self.port = port\n+        self.guid = guid","path":"node/connection.py","position":86,"original_position":86,"commit_id":"7e3fc2b41899a4917fba17049b7cb83e33ba86f0","original_commit_id":"7e3fc2b41899a4917fba17049b7cb83e33ba86f0","user":{"login":"Renelvon","id":860034,"avatar_url":"https://avatars.githubusercontent.com/u/860034?v=2","gravatar_id":"","url":"https://api.github.com/users/Renelvon","html_url":"https://github.com/Renelvon","followers_url":"https://api.github.com/users/Renelvon/followers","following_url":"https://api.github.com/users/Renelvon/following{/other_user}","gists_url":"https://api.github.com/users/Renelvon/gists{/gist_id}","starred_url":"https://api.github.com/users/Renelvon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Renelvon/subscriptions","organizations_url":"https://api.github.com/users/Renelvon/orgs","repos_url":"https://api.github.com/users/Renelvon/repos","events_url":"https://api.github.com/users/Renelvon/events{/privacy}","received_events_url":"https://api.github.com/users/Renelvon/received_events","type":"User","site_admin":false},"body":"This is easier to accomplish by making `PeerListener` inherit from `guid.GUIDMixin`.","created_at":"2014-10-19T11:06:44Z","updated_at":"2014-10-19T11:06:44Z","html_url":"https://github.com/OpenBazaar/OpenBazaar/pull/811#discussion_r19059500","pull_request_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/pulls/811","_links":{"self":{"href":"https://api.github.com/repos/OpenBazaar/OpenBazaar/pulls/comments/19059500"},"html":{"href":"https://github.com/OpenBazaar/OpenBazaar/pull/811#discussion_r19059500"},"pull_request":{"href":"https://api.github.com/repos/OpenBazaar/OpenBazaar/pulls/811"}}},"pull_request":{"url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/pulls/811","id":22831090,"html_url":"https://github.com/OpenBazaar/OpenBazaar/pull/811","diff_url":"https://github.com/OpenBazaar/OpenBazaar/pull/811.diff","patch_url":"https://github.com/OpenBazaar/OpenBazaar/pull/811.patch","issue_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/issues/811","number":811,"state":"open","locked":false,"title":"Sign then Encrypt","user":{"login":"hoffmabc","id":45482,"avatar_url":"https://avatars.githubusercontent.com/u/45482?v=2","gravatar_id":"","url":"https://api.github.com/users/hoffmabc","html_url":"https://github.com/hoffmabc","followers_url":"https://api.github.com/users/hoffmabc/followers","following_url":"https://api.github.com/users/hoffmabc/following{/other_user}","gists_url":"https://api.github.com/users/hoffmabc/gists{/gist_id}","starred_url":"https://api.github.com/users/hoffmabc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoffmabc/subscriptions","organizations_url":"https://api.github.com/users/hoffmabc/orgs","repos_url":"https://api.github.com/users/hoffmabc/repos","events_url":"https://api.github.com/users/hoffmabc/events{/privacy}","received_events_url":"https://api.github.com/users/hoffmabc/received_events","type":"User","site_admin":false},"body":"Just as a heads up this is wacky as shit because of some weird merging and rebasing…I'm still looking at it but if you see anything odd please let me know.","created_at":"2014-10-16T03:52:04Z","updated_at":"2014-10-19T11:06:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f4e4929d83132b311dd4d463dabea40331b9a052","assignee":{"login":"Renelvon","id":860034,"avatar_url":"https://avatars.githubusercontent.com/u/860034?v=2","gravatar_id":"","url":"https://api.github.com/users/Renelvon","html_url":"https://github.com/Renelvon","followers_url":"https://api.github.com/users/Renelvon/followers","following_url":"https://api.github.com/users/Renelvon/following{/other_user}","gists_url":"https://api.github.com/users/Renelvon/gists{/gist_id}","starred_url":"https://api.github.com/users/Renelvon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Renelvon/subscriptions","organizations_url":"https://api.github.com/users/Renelvon/orgs","repos_url":"https://api.github.com/users/Renelvon/repos","events_url":"https://api.github.com/users/Renelvon/events{/privacy}","received_events_url":"https://api.github.com/users/Renelvon/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/milestones/5","labels_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/milestones/5/labels","id":763426,"number":5,"title":"Beta 3.0","description":"","creator":{"login":"SamPatt","id":6955773,"avatar_url":"https://avatars.githubusercontent.com/u/6955773?v=2","gravatar_id":"","url":"https://api.github.com/users/SamPatt","html_url":"https://github.com/SamPatt","followers_url":"https://api.github.com/users/SamPatt/followers","following_url":"https://api.github.com/users/SamPatt/following{/other_user}","gists_url":"https://api.github.com/users/SamPatt/gists{/gist_id}","starred_url":"https://api.github.com/users/SamPatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamPatt/subscriptions","organizations_url":"https://api.github.com/users/SamPatt/orgs","repos_url":"https://api.github.com/users/SamPatt/repos","events_url":"https://api.github.com/users/SamPatt/events{/privacy}","received_events_url":"https://api.github.com/users/SamPatt/received_events","type":"User","site_admin":false},"open_issues":41,"closed_issues":23,"state":"open","created_at":"2014-08-23T16:34:40Z","updated_at":"2014-10-18T14:42:37Z","due_on":"2014-10-31T07:00:00Z"},"commits_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/pulls/811/commits","review_comments_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/pulls/811/comments","review_comment_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/pulls/comments/{number}","comments_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/issues/811/comments","statuses_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/statuses/7e3fc2b41899a4917fba17049b7cb83e33ba86f0","head":{"label":"hoffmabc:fix-encryption-signing","ref":"fix-encryption-signing","sha":"7e3fc2b41899a4917fba17049b7cb83e33ba86f0","user":{"login":"hoffmabc","id":45482,"avatar_url":"https://avatars.githubusercontent.com/u/45482?v=2","gravatar_id":"","url":"https://api.github.com/users/hoffmabc","html_url":"https://github.com/hoffmabc","followers_url":"https://api.github.com/users/hoffmabc/followers","following_url":"https://api.github.com/users/hoffmabc/following{/other_user}","gists_url":"https://api.github.com/users/hoffmabc/gists{/gist_id}","starred_url":"https://api.github.com/users/hoffmabc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoffmabc/subscriptions","organizations_url":"https://api.github.com/users/hoffmabc/orgs","repos_url":"https://api.github.com/users/hoffmabc/repos","events_url":"https://api.github.com/users/hoffmabc/events{/privacy}","received_events_url":"https://api.github.com/users/hoffmabc/received_events","type":"User","site_admin":false},"repo":{"id":23429671,"name":"OpenBazaar","full_name":"hoffmabc/OpenBazaar","owner":{"login":"hoffmabc","id":45482,"avatar_url":"https://avatars.githubusercontent.com/u/45482?v=2","gravatar_id":"","url":"https://api.github.com/users/hoffmabc","html_url":"https://github.com/hoffmabc","followers_url":"https://api.github.com/users/hoffmabc/followers","following_url":"https://api.github.com/users/hoffmabc/following{/other_user}","gists_url":"https://api.github.com/users/hoffmabc/gists{/gist_id}","starred_url":"https://api.github.com/users/hoffmabc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoffmabc/subscriptions","organizations_url":"https://api.github.com/users/hoffmabc/orgs","repos_url":"https://api.github.com/users/hoffmabc/repos","events_url":"https://api.github.com/users/hoffmabc/events{/privacy}","received_events_url":"https://api.github.com/users/hoffmabc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hoffmabc/OpenBazaar","description":"Test Drive at http://seed.openbazaar.org:8888  ","fork":true,"url":"https://api.github.com/repos/hoffmabc/OpenBazaar","forks_url":"https://api.github.com/repos/hoffmabc/OpenBazaar/forks","keys_url":"https://api.github.com/repos/hoffmabc/OpenBazaar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hoffmabc/OpenBazaar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hoffmabc/OpenBazaar/teams","hooks_url":"https://api.github.com/repos/hoffmabc/OpenBazaar/hooks","issue_events_url":"https://api.github.com/repos/hoffmabc/OpenBazaar/issues/events{/number}","events_url":"https://api.github.com/repos/hoffmabc/OpenBazaar/events","assignees_url":"https://api.github.com/repos/hoffmabc/OpenBazaar/assignees{/user}","branches_url":"https://api.github.com/repos/hoffmabc/OpenBazaar/branches{/branch}","tags_url":"https://api.github.com/repos/hoffmabc/OpenBazaar/tags","blobs_url":"https://api.github.com/repos/hoffmabc/OpenBazaar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hoffmabc/OpenBazaar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hoffmabc/OpenBazaar/git/refs{/sha}","trees_url":"https://api.github.com/repos/hoffmabc/OpenBazaar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hoffmabc/OpenBazaar/statuses/{sha}","languages_url":"https://api.github.com/repos/hoffmabc/OpenBazaar/languages","stargazers_url":"https://api.github.com/repos/hoffmabc/OpenBazaar/stargazers","contributors_url":"https://api.github.com/repos/hoffmabc/OpenBazaar/contributors","subscribers_url":"https://api.github.com/repos/hoffmabc/OpenBazaar/subscribers","subscription_url":"https://api.github.com/repos/hoffmabc/OpenBazaar/subscription","commits_url":"https://api.github.com/repos/hoffmabc/OpenBazaar/commits{/sha}","git_commits_url":"https://api.github.com/repos/hoffmabc/OpenBazaar/git/commits{/sha}","comments_url":"https://api.github.com/repos/hoffmabc/OpenBazaar/comments{/number}","issue_comment_url":"https://api.github.com/repos/hoffmabc/OpenBazaar/issues/comments/{number}","contents_url":"https://api.github.com/repos/hoffmabc/OpenBazaar/contents/{+path}","compare_url":"https://api.github.com/repos/hoffmabc/OpenBazaar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hoffmabc/OpenBazaar/merges","archive_url":"https://api.github.com/repos/hoffmabc/OpenBazaar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hoffmabc/OpenBazaar/downloads","issues_url":"https://api.github.com/repos/hoffmabc/OpenBazaar/issues{/number}","pulls_url":"https://api.github.com/repos/hoffmabc/OpenBazaar/pulls{/number}","milestones_url":"https://api.github.com/repos/hoffmabc/OpenBazaar/milestones{/number}","notifications_url":"https://api.github.com/repos/hoffmabc/OpenBazaar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hoffmabc/OpenBazaar/labels{/name}","releases_url":"https://api.github.com/repos/hoffmabc/OpenBazaar/releases{/id}","created_at":"2014-08-28T13:51:36Z","updated_at":"2014-08-28T14:04:15Z","pushed_at":"2014-10-19T04:52:17Z","git_url":"git://github.com/hoffmabc/OpenBazaar.git","ssh_url":"git@github.com:hoffmabc/OpenBazaar.git","clone_url":"https://github.com/hoffmabc/OpenBazaar.git","svn_url":"https://github.com/hoffmabc/OpenBazaar","homepage":"http://forum.openbazaar.org","size":20246,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OpenBazaar:develop","ref":"develop","sha":"896149717b60f32f7b4d195307fe27fddb3da658","user":{"login":"OpenBazaar","id":7438770,"avatar_url":"https://avatars.githubusercontent.com/u/7438770?v=2","gravatar_id":"","url":"https://api.github.com/users/OpenBazaar","html_url":"https://github.com/OpenBazaar","followers_url":"https://api.github.com/users/OpenBazaar/followers","following_url":"https://api.github.com/users/OpenBazaar/following{/other_user}","gists_url":"https://api.github.com/users/OpenBazaar/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenBazaar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenBazaar/subscriptions","organizations_url":"https://api.github.com/users/OpenBazaar/orgs","repos_url":"https://api.github.com/users/OpenBazaar/repos","events_url":"https://api.github.com/users/OpenBazaar/events{/privacy}","received_events_url":"https://api.github.com/users/OpenBazaar/received_events","type":"Organization","site_admin":false},"repo":{"id":19147609,"name":"OpenBazaar","full_name":"OpenBazaar/OpenBazaar","owner":{"login":"OpenBazaar","id":7438770,"avatar_url":"https://avatars.githubusercontent.com/u/7438770?v=2","gravatar_id":"","url":"https://api.github.com/users/OpenBazaar","html_url":"https://github.com/OpenBazaar","followers_url":"https://api.github.com/users/OpenBazaar/followers","following_url":"https://api.github.com/users/OpenBazaar/following{/other_user}","gists_url":"https://api.github.com/users/OpenBazaar/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenBazaar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenBazaar/subscriptions","organizations_url":"https://api.github.com/users/OpenBazaar/orgs","repos_url":"https://api.github.com/users/OpenBazaar/repos","events_url":"https://api.github.com/users/OpenBazaar/events{/privacy}","received_events_url":"https://api.github.com/users/OpenBazaar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenBazaar/OpenBazaar","description":"A decentralized marketplace","fork":false,"url":"https://api.github.com/repos/OpenBazaar/OpenBazaar","forks_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/forks","keys_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/teams","hooks_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/hooks","issue_events_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/issues/events{/number}","events_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/events","assignees_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/assignees{/user}","branches_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/branches{/branch}","tags_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/tags","blobs_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/languages","stargazers_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/stargazers","contributors_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/contributors","subscribers_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/subscribers","subscription_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/subscription","commits_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/issues/comments/{number}","contents_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/contents/{+path}","compare_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/merges","archive_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/downloads","issues_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/issues{/number}","pulls_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/labels{/name}","releases_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/releases{/id}","created_at":"2014-04-25T13:49:36Z","updated_at":"2014-10-18T21:13:51Z","pushed_at":"2014-10-18T17:10:58Z","git_url":"git://github.com/OpenBazaar/OpenBazaar.git","ssh_url":"git@github.com:OpenBazaar/OpenBazaar.git","clone_url":"https://github.com/OpenBazaar/OpenBazaar.git","svn_url":"https://github.com/OpenBazaar/OpenBazaar","homepage":"http://forum.openbazaar.org","size":38818,"stargazers_count":716,"watchers_count":716,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":200,"mirror_url":null,"open_issues_count":187,"forks":200,"open_issues":187,"watchers":716,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenBazaar/OpenBazaar/pulls/811"},"html":{"href":"https://github.com/OpenBazaar/OpenBazaar/pull/811"},"issue":{"href":"https://api.github.com/repos/OpenBazaar/OpenBazaar/issues/811"},"comments":{"href":"https://api.github.com/repos/OpenBazaar/OpenBazaar/issues/811/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenBazaar/OpenBazaar/pulls/811/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenBazaar/OpenBazaar/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/OpenBazaar/OpenBazaar/pulls/811/commits"},"statuses":{"href":"https://api.github.com/repos/OpenBazaar/OpenBazaar/statuses/7e3fc2b41899a4917fba17049b7cb83e33ba86f0"}}}}