GitHub PullRequestEvent at 2014-03-23 22:07:06
Repository: rack-mini-profiler
Actor: SamSaffron
Payload: {"action":"closed","number":69,"pull_request":{"url":"https://api.github.com/repos/MiniProfiler/rack-mini-profiler/pulls/69","id":13866211,"html_url":"https://github.com/MiniProfiler/rack-mini-profiler/pull/69","diff_url":"https://github.com/MiniProfiler/rack-mini-profiler/pull/69.diff","patch_url":"https://github.com/MiniProfiler/rack-mini-profiler/pull/69.patch","issue_url":"https://api.github.com/repos/MiniProfiler/rack-mini-profiler/issues/69","number":69,"state":"closed","title":"Add no-store to Cache-Control setting?","user":{"login":"gsmendoza","id":61476,"avatar_url":"https://avatars.githubusercontent.com/u/61476?","gravatar_id":"2456250b860e130e613c57b7bad99542","url":"https://api.github.com/users/gsmendoza","html_url":"https://github.com/gsmendoza","followers_url":"https://api.github.com/users/gsmendoza/followers","following_url":"https://api.github.com/users/gsmendoza/following{/other_user}","gists_url":"https://api.github.com/users/gsmendoza/gists{/gist_id}","starred_url":"https://api.github.com/users/gsmendoza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsmendoza/subscriptions","organizations_url":"https://api.github.com/users/gsmendoza/orgs","repos_url":"https://api.github.com/users/gsmendoza/repos","events_url":"https://api.github.com/users/gsmendoza/events{/privacy}","received_events_url":"https://api.github.com/users/gsmendoza/received_events","type":"User","site_admin":false},"body":"Hello!\r\n\r\nAppreciate if you can help us with this issue we're encountering with rack-mini-profiler, [wiselinks](https://github.com/igor-alexandrov/wiselinks), and Chrome.\r\n\r\n### Description\r\n\r\nGiven I am using Chromium 33\r\nAnd my Rails app is using both rack mini profiler 0.9.1 and wiselinks 1.2.0\r\nAnd the app has a wiselinks-enabled link in some page A that loads another page B via ajax\r\nAnd the app has another link that is not wiselinks-enabled\r\nWhen I go to page A\r\nAnd I click on the page B link\r\nThen page B will be loaded via ajax\r\nWhen I click on a link that is not wiselinks-enabled\r\nAnd I return to page B with the back button of the browser\r\nThen I will see page B without any layout\r\n\r\n### Demo\r\n\r\nYou can find a demo of the bug at https://github.com/lovewithfood/rack-mini-profiler-wiselinks-bug-demo.\r\n\r\n### Cause \r\n\r\nwiselinks [sets](https://github.com/igor-alexandrov/wiselinks/blob/e473ebd81addf613e175ba729be68ae7834b2c37/lib/wiselinks/rendering.rb#L14) Cache-Control to 'no-cache, no-store, max-age=0, must-revalidate.' However, rack-mini-profiler removes the no-store value when it [sets](https://github.com/MiniProfiler/rack-mini-profiler/blob/734c8a5d47b0a4ce3a1d07e5fe3c6aa64dee548e/lib/mini_profiler/profiler.rb#L378) Cache-Control to 'must-revalidate, private, max-age=0'. According to [this StackOverflow post](http://stackoverflow.com/questions/16173322/google-chrome-does-not-revalidate-etag-on-back-forth), this allows Chrome to reload the wiselinks partial response from the cache when using the back button.\r\n\r\nChrome is the only browser I know encountering this issue. I haven't encountered the issue in Firefox or IE9 to 11.\r\n\r\n### Solution/Work-around\r\n\r\nAdded no-store to the Cache-Control setting of rack-mini-profiler. \r\n\r\nWill this cause any issues with the gem?\r\n\r\n","created_at":"2014-03-22T07:42:17Z","updated_at":"2014-03-23T22:07:06Z","closed_at":"2014-03-23T22:07:06Z","merged_at":"2014-03-23T22:07:06Z","merge_commit_sha":"a0cb3a80f6d3f99feacffd9d9b0b174121577d97","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/MiniProfiler/rack-mini-profiler/pulls/69/commits","review_comments_url":"https://api.github.com/repos/MiniProfiler/rack-mini-profiler/pulls/69/comments","review_comment_url":"https://api.github.com/repos/MiniProfiler/rack-mini-profiler/pulls/comments/{number}","comments_url":"https://api.github.com/repos/MiniProfiler/rack-mini-profiler/issues/69/comments","statuses_url":"https://api.github.com/repos/MiniProfiler/rack-mini-profiler/statuses/6b10c5fa1cc1b4ddd77c5cf75884d3bf7dee7978","head":{"label":"lovewithfood:with_no_store_cache_control","ref":"with_no_store_cache_control","sha":"6b10c5fa1cc1b4ddd77c5cf75884d3bf7dee7978","user":{"login":"lovewithfood","id":1184282,"avatar_url":"https://avatars.githubusercontent.com/u/1184282?","gravatar_id":"2763ab98bd11c35fb46acb19a2af5c31","url":"https://api.github.com/users/lovewithfood","html_url":"https://github.com/lovewithfood","followers_url":"https://api.github.com/users/lovewithfood/followers","following_url":"https://api.github.com/users/lovewithfood/following{/other_user}","gists_url":"https://api.github.com/users/lovewithfood/gists{/gist_id}","starred_url":"https://api.github.com/users/lovewithfood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lovewithfood/subscriptions","organizations_url":"https://api.github.com/users/lovewithfood/orgs","repos_url":"https://api.github.com/users/lovewithfood/repos","events_url":"https://api.github.com/users/lovewithfood/events{/privacy}","received_events_url":"https://api.github.com/users/lovewithfood/received_events","type":"Organization","site_admin":false},"repo":{"id":18004070,"name":"rack-mini-profiler","full_name":"lovewithfood/rack-mini-profiler","owner":{"login":"lovewithfood","id":1184282,"avatar_url":"https://avatars.githubusercontent.com/u/1184282?","gravatar_id":"2763ab98bd11c35fb46acb19a2af5c31","url":"https://api.github.com/users/lovewithfood","html_url":"https://github.com/lovewithfood","followers_url":"https://api.github.com/users/lovewithfood/followers","following_url":"https://api.github.com/users/lovewithfood/following{/other_user}","gists_url":"https://api.github.com/users/lovewithfood/gists{/gist_id}","starred_url":"https://api.github.com/users/lovewithfood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lovewithfood/subscriptions","organizations_url":"https://api.github.com/users/lovewithfood/orgs","repos_url":"https://api.github.com/users/lovewithfood/repos","events_url":"https://api.github.com/users/lovewithfood/events{/privacy}","received_events_url":"https://api.github.com/users/lovewithfood/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lovewithfood/rack-mini-profiler","description":"Profiler for your development and production Ruby rack apps. ","fork":true,"url":"https://api.github.com/repos/lovewithfood/rack-mini-profiler","forks_url":"https://api.github.com/repos/lovewithfood/rack-mini-profiler/forks","keys_url":"https://api.github.com/repos/lovewithfood/rack-mini-profiler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lovewithfood/rack-mini-profiler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lovewithfood/rack-mini-profiler/teams","hooks_url":"https://api.github.com/repos/lovewithfood/rack-mini-profiler/hooks","issue_events_url":"https://api.github.com/repos/lovewithfood/rack-mini-profiler/issues/events{/number}","events_url":"https://api.github.com/repos/lovewithfood/rack-mini-profiler/events","assignees_url":"https://api.github.com/repos/lovewithfood/rack-mini-profiler/assignees{/user}","branches_url":"https://api.github.com/repos/lovewithfood/rack-mini-profiler/branches{/branch}","tags_url":"https://api.github.com/repos/lovewithfood/rack-mini-profiler/tags","blobs_url":"https://api.github.com/repos/lovewithfood/rack-mini-profiler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lovewithfood/rack-mini-profiler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lovewithfood/rack-mini-profiler/git/refs{/sha}","trees_url":"https://api.github.com/repos/lovewithfood/rack-mini-profiler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lovewithfood/rack-mini-profiler/statuses/{sha}","languages_url":"https://api.github.com/repos/lovewithfood/rack-mini-profiler/languages","stargazers_url":"https://api.github.com/repos/lovewithfood/rack-mini-profiler/stargazers","contributors_url":"https://api.github.com/repos/lovewithfood/rack-mini-profiler/contributors","subscribers_url":"https://api.github.com/repos/lovewithfood/rack-mini-profiler/subscribers","subscription_url":"https://api.github.com/repos/lovewithfood/rack-mini-profiler/subscription","commits_url":"https://api.github.com/repos/lovewithfood/rack-mini-profiler/commits{/sha}","git_commits_url":"https://api.github.com/repos/lovewithfood/rack-mini-profiler/git/commits{/sha}","comments_url":"https://api.github.com/repos/lovewithfood/rack-mini-profiler/comments{/number}","issue_comment_url":"https://api.github.com/repos/lovewithfood/rack-mini-profiler/issues/comments/{number}","contents_url":"https://api.github.com/repos/lovewithfood/rack-mini-profiler/contents/{+path}","compare_url":"https://api.github.com/repos/lovewithfood/rack-mini-profiler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lovewithfood/rack-mini-profiler/merges","archive_url":"https://api.github.com/repos/lovewithfood/rack-mini-profiler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lovewithfood/rack-mini-profiler/downloads","issues_url":"https://api.github.com/repos/lovewithfood/rack-mini-profiler/issues{/number}","pulls_url":"https://api.github.com/repos/lovewithfood/rack-mini-profiler/pulls{/number}","milestones_url":"https://api.github.com/repos/lovewithfood/rack-mini-profiler/milestones{/number}","notifications_url":"https://api.github.com/repos/lovewithfood/rack-mini-profiler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lovewithfood/rack-mini-profiler/labels{/name}","releases_url":"https://api.github.com/repos/lovewithfood/rack-mini-profiler/releases{/id}","created_at":"2014-03-22T07:03:28Z","updated_at":"2014-03-23T22:07:06Z","pushed_at":"2014-03-22T07:36:04Z","git_url":"git://github.com/lovewithfood/rack-mini-profiler.git","ssh_url":"git@github.com:lovewithfood/rack-mini-profiler.git","clone_url":"https://github.com/lovewithfood/rack-mini-profiler.git","svn_url":"https://github.com/lovewithfood/rack-mini-profiler","homepage":null,"size":1047,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"MiniProfiler:master","ref":"master","sha":"dfb32841f9c7145a23b447095831c220d9af1c76","user":{"login":"MiniProfiler","id":1631473,"avatar_url":"https://avatars.githubusercontent.com/u/1631473?","gravatar_id":"3219e0b287f1c4722967f464b030576a","url":"https://api.github.com/users/MiniProfiler","html_url":"https://github.com/MiniProfiler","followers_url":"https://api.github.com/users/MiniProfiler/followers","following_url":"https://api.github.com/users/MiniProfiler/following{/other_user}","gists_url":"https://api.github.com/users/MiniProfiler/gists{/gist_id}","starred_url":"https://api.github.com/users/MiniProfiler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MiniProfiler/subscriptions","organizations_url":"https://api.github.com/users/MiniProfiler/orgs","repos_url":"https://api.github.com/users/MiniProfiler/repos","events_url":"https://api.github.com/users/MiniProfiler/events{/privacy}","received_events_url":"https://api.github.com/users/MiniProfiler/received_events","type":"Organization","site_admin":false},"repo":{"id":12656803,"name":"rack-mini-profiler","full_name":"MiniProfiler/rack-mini-profiler","owner":{"login":"MiniProfiler","id":1631473,"avatar_url":"https://avatars.githubusercontent.com/u/1631473?","gravatar_id":"3219e0b287f1c4722967f464b030576a","url":"https://api.github.com/users/MiniProfiler","html_url":"https://github.com/MiniProfiler","followers_url":"https://api.github.com/users/MiniProfiler/followers","following_url":"https://api.github.com/users/MiniProfiler/following{/other_user}","gists_url":"https://api.github.com/users/MiniProfiler/gists{/gist_id}","starred_url":"https://api.github.com/users/MiniProfiler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MiniProfiler/subscriptions","organizations_url":"https://api.github.com/users/MiniProfiler/orgs","repos_url":"https://api.github.com/users/MiniProfiler/repos","events_url":"https://api.github.com/users/MiniProfiler/events{/privacy}","received_events_url":"https://api.github.com/users/MiniProfiler/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MiniProfiler/rack-mini-profiler","description":"Profiler for your development and production Ruby rack apps. ","fork":false,"url":"https://api.github.com/repos/MiniProfiler/rack-mini-profiler","forks_url":"https://api.github.com/repos/MiniProfiler/rack-mini-profiler/forks","keys_url":"https://api.github.com/repos/MiniProfiler/rack-mini-profiler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MiniProfiler/rack-mini-profiler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MiniProfiler/rack-mini-profiler/teams","hooks_url":"https://api.github.com/repos/MiniProfiler/rack-mini-profiler/hooks","issue_events_url":"https://api.github.com/repos/MiniProfiler/rack-mini-profiler/issues/events{/number}","events_url":"https://api.github.com/repos/MiniProfiler/rack-mini-profiler/events","assignees_url":"https://api.github.com/repos/MiniProfiler/rack-mini-profiler/assignees{/user}","branches_url":"https://api.github.com/repos/MiniProfiler/rack-mini-profiler/branches{/branch}","tags_url":"https://api.github.com/repos/MiniProfiler/rack-mini-profiler/tags","blobs_url":"https://api.github.com/repos/MiniProfiler/rack-mini-profiler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MiniProfiler/rack-mini-profiler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MiniProfiler/rack-mini-profiler/git/refs{/sha}","trees_url":"https://api.github.com/repos/MiniProfiler/rack-mini-profiler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MiniProfiler/rack-mini-profiler/statuses/{sha}","languages_url":"https://api.github.com/repos/MiniProfiler/rack-mini-profiler/languages","stargazers_url":"https://api.github.com/repos/MiniProfiler/rack-mini-profiler/stargazers","contributors_url":"https://api.github.com/repos/MiniProfiler/rack-mini-profiler/contributors","subscribers_url":"https://api.github.com/repos/MiniProfiler/rack-mini-profiler/subscribers","subscription_url":"https://api.github.com/repos/MiniProfiler/rack-mini-profiler/subscription","commits_url":"https://api.github.com/repos/MiniProfiler/rack-mini-profiler/commits{/sha}","git_commits_url":"https://api.github.com/repos/MiniProfiler/rack-mini-profiler/git/commits{/sha}","comments_url":"https://api.github.com/repos/MiniProfiler/rack-mini-profiler/comments{/number}","issue_comment_url":"https://api.github.com/repos/MiniProfiler/rack-mini-profiler/issues/comments/{number}","contents_url":"https://api.github.com/repos/MiniProfiler/rack-mini-profiler/contents/{+path}","compare_url":"https://api.github.com/repos/MiniProfiler/rack-mini-profiler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MiniProfiler/rack-mini-profiler/merges","archive_url":"https://api.github.com/repos/MiniProfiler/rack-mini-profiler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MiniProfiler/rack-mini-profiler/downloads","issues_url":"https://api.github.com/repos/MiniProfiler/rack-mini-profiler/issues{/number}","pulls_url":"https://api.github.com/repos/MiniProfiler/rack-mini-profiler/pulls{/number}","milestones_url":"https://api.github.com/repos/MiniProfiler/rack-mini-profiler/milestones{/number}","notifications_url":"https://api.github.com/repos/MiniProfiler/rack-mini-profiler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MiniProfiler/rack-mini-profiler/labels{/name}","releases_url":"https://api.github.com/repos/MiniProfiler/rack-mini-profiler/releases{/id}","created_at":"2013-09-06T23:32:44Z","updated_at":"2014-03-23T22:07:06Z","pushed_at":"2014-03-23T22:07:06Z","git_url":"git://github.com/MiniProfiler/rack-mini-profiler.git","ssh_url":"git@github.com:MiniProfiler/rack-mini-profiler.git","clone_url":"https://github.com/MiniProfiler/rack-mini-profiler.git","svn_url":"https://github.com/MiniProfiler/rack-mini-profiler","homepage":null,"size":1047,"stargazers_count":312,"watchers_count":312,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":65,"mirror_url":null,"open_issues_count":11,"forks":65,"open_issues":11,"watchers":312,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MiniProfiler/rack-mini-profiler/pulls/69"},"html":{"href":"https://github.com/MiniProfiler/rack-mini-profiler/pull/69"},"issue":{"href":"https://api.github.com/repos/MiniProfiler/rack-mini-profiler/issues/69"},"comments":{"href":"https://api.github.com/repos/MiniProfiler/rack-mini-profiler/issues/69/comments"},"review_comments":{"href":"https://api.github.com/repos/MiniProfiler/rack-mini-profiler/pulls/69/comments"},"review_comment":{"href":"https://api.github.com/repos/MiniProfiler/rack-mini-profiler/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/MiniProfiler/rack-mini-profiler/pulls/69/commits"},"statuses":{"href":"https://api.github.com/repos/MiniProfiler/rack-mini-profiler/statuses/6b10c5fa1cc1b4ddd77c5cf75884d3bf7dee7978"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"SamSaffron","id":5213,"avatar_url":"https://avatars.githubusercontent.com/u/5213?","gravatar_id":"3dcae8378d46c244172a115c28ca49ce","url":"https://api.github.com/users/SamSaffron","html_url":"https://github.com/SamSaffron","followers_url":"https://api.github.com/users/SamSaffron/followers","following_url":"https://api.github.com/users/SamSaffron/following{/other_user}","gists_url":"https://api.github.com/users/SamSaffron/gists{/gist_id}","starred_url":"https://api.github.com/users/SamSaffron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamSaffron/subscriptions","organizations_url":"https://api.github.com/users/SamSaffron/orgs","repos_url":"https://api.github.com/users/SamSaffron/repos","events_url":"https://api.github.com/users/SamSaffron/events{/privacy}","received_events_url":"https://api.github.com/users/SamSaffron/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}