GitHub PushEvent at 2014-06-04 07:02:13
Repository: riak_kv
Actor: andrewjstone
Payload: {"shas":[["59fbde68f99c194ac540719830ea76704cb43cc4","dc7803c06ca8b2a56b6e44b65f25cf5b9be76fab@gmail.com","Cuttlefish schema for background manager subsystem (aae and handoff) kill/enable switch","Chris Tilt",false],["57398354e1d0c3c4f0f5895fd3952d08498065c1","d7e19930cc1f42c2d0781f4d9e6f1fe5891bf9cf@basho.com","Rename background manager settings and add unit tests for the schema.","Sean Cribbs",false],["0d454dbbd67465cc7925875a3c145b37d17bbf1e","d7e19930cc1f42c2d0781f4d9e6f1fe5891bf9cf@basho.com","{level, advanced} -> hidden","Sean Cribbs",false],["718d139fe0683d7862a23ee9ea22a86bf91b4996","055af6b6617817c802827a477de34fe0a8edd21b@snookles.com","Send reply in event of a premature exit (via throw) from fold.","Scott Lystig Fritchie",false],["b06195d476295e11b38a5f43832c2b4a8b4929a4","055af6b6617817c802827a477de34fe0a8edd21b@snookles.com","Ignore {ack,_,now_executing} that arrive late","Scott Lystig Fritchie",false],["34fe50c06cf3102458df4dc80f2c7305a0dc56bc","055af6b6617817c802827a477de34fe0a8edd21b@snookles.com","borshop kludge: adjust temporary dialyzer.ignore-warnings","Scott Lystig Fritchie",false],["a670cc5377ffa9adae79cd8e01495d45305c551d","1f4d9895740d1b07c3b2f21f4b03e23d1086f158@gmail.com","Clean up webmachine resource specs\n\n* Remove use of reqdata(), which is not an exported type\n* Change old-style @spec to -spec\n* Create context() types where needed\n* Remove some unused types\n* Remove use of unknown types, replace with term() where I can't figure\n  out what it would otherwise be","Reid Draper",false],["e66f3ffdc637d0e2385301f74d984c0632029493","ed57dc17449df205198c0f8d07804de6a4eb8ad7@basho.com","Merge pull request #914 from basho/feature/webmachine-specs-cleanup\n\nClean up webmachine resource specs\n\nReviewed-by: cmeiklejohn","Bishop Bors",false],["1ab3720cfcc37d476f52e8064052c2f3c116546f","a79e04750344b607a9f50266674b5875dff51849@basho.com","Add sys_monitor_count and sys_port_count.\n\nPermits tracking of potentially leakable resources.","Jon Meredith",false],["4d9032fd09d1578e141feca4639796abe1403217","1f4d9895740d1b07c3b2f21f4b03e23d1086f158@gmail.com","Fix some dialyzer errors\n\nriak_kv_vnode:fold_extras was only ever called with the atom 'keys' as\nits first argument, so I just renamed the function and removed the\nunused parameter. I also removed the catch-all pattern match that would\nnever match.","Reid Draper",false],["5ea1dbbdbda25bd856d7481a1ff98a6ff80237a5","462f72b27bf31c811fa1242d7e0eeba76c3c649c@gmail.com","Fix some AAE dialyzer errors\n\nThis commit fixes all the dialyzer errors for `riak_kv_entropy_info`\nas well as an error for `riak_kv_exchange_fsm`.  The main change was\nto fix the spec for `#index_info.repaired` which is actually a\n`#simple_stat{}` not a `pos_integer()`. However, even after that\ndialyzer was not happy with the explicit default values of `undefined`\nwithout corresponding entries in the type definition. This seemed like\na waste to me given that Erlang will implicitly default records values\nto `undefined` and insert the appropriate type spec. This is discussed\nin the following reference manual:\n\nhttp://www.erlang.org/doc/reference_manual/typespec.html#typeinrecords\n\nHere is the full list of dialyzer errors which have been fixed:\n\n```\nriak_kv_entropy_info.erl:78: Function exchange_complete/4 has no local\nreturn\nriak_kv_entropy_info.erl:83: Function exchange_complete/5 has no local\nreturn\nriak_kv_entropy_info.erl:84: The call\nriak_kv_entropy_info:update_index_info({_,_},{'exchange_complete',_,_,_})\nwill never return since it differs in the 2nd argument fr\nriak_kv_entropy_info.erl:161: Record construction\nrepaired::pos_integer() and last_exchange::{non_neg_inte\nriak_kv_entropy_info.erl:194: The call\nriak_kv_entropy_info:update_simple_stat(Repaired::'undefined' |\npos_integer(),pos_integer()) will never return since it differs in\nriak_kv_entropy_info.erl:208: Function compute_exchange_info/4 has no\nlocal return\nriak_kv_entropy_info.erl:218: The call\nriak_kv_entropy_info:stat_tuple(Repaired::pos_integer()) will never\nreturn since it differs in the 1st argument from the success t\nriak_kv_entropy_info.erl:225: Function update_simple_stat/2 has no local\nreturn\nriak_kv_entropy_info.erl:225: The pattern <Value, 'undefined'> can never\nmatch the type <'undefined' | pos_integer(),pos_integer()>\nriak_kv_entropy_info.erl:227: The pattern <Value, Stat = {'simple_stat',\n_, Min, Max, Cnt, Sum}> can never match the type <'undefined' |\npos_integer(),pos_integer()>\nriak_kv_entropy_info.erl:234: Function stat_tuple/1 has no local return\nriak_kv_entropy_info.erl:234: The pattern 'undefined' can never match\nthe type pos_integer()\nriak_kv_entropy_info.erl:236: The pattern {'simple_stat', Last, Min,\nMax, Cnt, Sum} can never match the type pos_integer()\nriak_kv_exchange_fsm.erl:379: Function exchange_complete/4 has no local\nreturn\n```","rzezeski",false],["cd46b2222f0db477f4c523a60588fa74e9c9ba99","1f4d9895740d1b07c3b2f21f4b03e23d1086f158@gmail.com","Create a one-arity build_filter function\n\nWhen called with `undefined` as the last argument, build_filter/3 was\nignoring its first argument (it still does for backward compatibility).\nBecause we were providing it with a dummy 'all' argument, dialyzer was\ncomplaining. Since we know at the call-site whether we're calling the\nfunction with `undefined` or not, we can just use the new one-arity\nversion.\n\nFixes #923","Reid Draper",false],["ded4f044b2076daa52e8dfaaf1906d61ec6330e1","055af6b6617817c802827a477de34fe0a8edd21b@snookles.com","Add 'late_put_fsm_coordinator_ack' counter","Scott Lystig Fritchie",false],["47acefd4e936b9f6852b0abc55cc38c29feea67e","055af6b6617817c802827a477de34fe0a8edd21b@snookles.com","Dialyzer warning shift, part II","Scott Lystig Fritchie",false],["a85edb4440338c74a4c3d69ad43510217b0d1919","f03f7b035106bba3da9b565be6f0115dc0d88f87@basho.com","Specified return code for riak_kv_console:bucket_type_status","Jon Glick",false],["c1c6c9c2ef8fc07eaa6e42852ed3279a4d88a1a8","7a4255afd9c57b6683c0a61b60767f34686dfd0a@ieee.org","fix #929: wait for riak_kv_stat to unregister\n\nThe {{already_started, ...}, {child, ...}} error noted in the description\nof issue #929 is caused by an instance of riak_kv_stat trying to register\nits name when another instance is already registered. Add\nriak_kv_test_util:wait_for_unregister/1 and use it in\nriak_kv_test_util:cleanup/3 to wait for the registered instance of\nriak_kv_stat to unregister and stop. Remove similar functionality in\ntest/get_put_monitor_eqc.erl and make that module call\nriak_kv_test_util:wait_for_unregister/1 instead.\n\nAlso add goldrush to the app list in riak_kv_test_util:dep_apps/2 to ensure\nit's started and stopped correctly; this prevents crash dumps caused by\n{application_terminated,goldrush,killed} at the end of \"make test\".","Steve Vinoski",false],["2bab35bf763f7efc0e27653f4633fdf4e3f71926","d7e19930cc1f42c2d0781f4d9e6f1fe5891bf9cf@basho.com","Use binary_to_atom/2 instead of binary_to_existing_atom/2.\n\nThere's a possibility that the riak_dt code that contains the set\noperation atoms hasn't been loaded when\nriak_kv_crdt_json:set_op_from_json/1 is invoked, meaning\nbinary_to_existing_atom/2 will raise a badarg. We are already checking\nthe incoming operation as a binary via a guard on the relevant\nfunction clause, so it is safe to use binary_to_atom/2 instead.","Sean Cribbs",false],["748f80c7dd79ec5f66735db7475f15158579b2f1","698111742b200de727b385f59332618741402b79@basho.com","Whitespace cleanup","Joe DeVivo",false],["d934ade282176ac0e1cf4c418951856b60ab1976","698111742b200de727b385f59332618741402b79@basho.com","Erlang environment changes for R16B02-basho5","Joe DeVivo",false],["12e18b72acf4781492fde329a1ee83ba3926f9bd","698111742b200de727b385f59332618741402b79@basho.com","removed TODO saying to fix the thing I just fixed","Joe DeVivo",false]],"size":81,"ref":"refs/heads/ajs/ensemble_remove_node","head":"8f338aa69c61af0744a11fdf59f788101dc7ea46"}