GitHub PullRequestReviewCommentEvent at 2014-06-16 09:23:33
Repository: dart-js-wrapping
Actor: a14n
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/a14n/dart-js-wrapping/pulls/comments/13796884","id":13796884,"diff_hunk":"@@ -60,14 +59,16 @@ dynamic jsify(data) {\n   return _convert(data);\n }\n \n-bool isTransferable(data) => data == null ||\n-    data is num || data is bool || data is String || data is DateTime ||\n-    data is Blob || data is Event || data is ImageData || data is Node || data is Window ||\n-    data is KeyRange ||\n-    data is TypedData;\n+/// Returns `true` when `data` can be transferred directly from Dart to JS or `false` when it needs\n+/// to be wrapped in a [JsObject].\n+bool isTransferable(data) => data is JsObject ||\n+    data == null || data is num || data is bool || data is String || data is DateTime ||\n+    data is Blob || data is Event || data is HtmlCollection || data is ImageData || data is Node ||\n+    data is NodeList || data is Window || data is KeyRange ||\n+    (data is TypedData && data is! ByteBuffer);\n \n /// Calls [Serializable.$unwrap] if [o] is a [Serializable].\n-mayUnwrap(o) => o is Serializable ? Serializable.$unwrap(o) : o;\n+dynamic mayUnwrap(o) => o is Serializable ? Serializable.$unwrap(o) : o;","path":"lib/src/wrapping/utils.dart","position":null,"original_position":56,"commit_id":"d60d92ef791300f6c4a421d923939bb3f650546e","original_commit_id":"f670e6cf59856e09262a2cba95ba3b32cf63f71c","user":{"login":"a14n","id":1206632,"avatar_url":"https://avatars.githubusercontent.com/u/1206632?","gravatar_id":"198449a7e196c4b0f2ed25f65279bf84","url":"https://api.github.com/users/a14n","html_url":"https://github.com/a14n","followers_url":"https://api.github.com/users/a14n/followers","following_url":"https://api.github.com/users/a14n/following{/other_user}","gists_url":"https://api.github.com/users/a14n/gists{/gist_id}","starred_url":"https://api.github.com/users/a14n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a14n/subscriptions","organizations_url":"https://api.github.com/users/a14n/orgs","repos_url":"https://api.github.com/users/a14n/repos","events_url":"https://api.github.com/users/a14n/events{/privacy}","received_events_url":"https://api.github.com/users/a14n/received_events","type":"User","site_admin":false},"body":"Reading https://www.dartlang.org/articles/style-guide/#do-annotate-with-object-instead-of-dynamic-to-indicate-any-object-is-accepted I also wonder if this shouldn't be `Object`.\r\n\r\nLet go by omitting type for now.","created_at":"2014-06-16T09:23:33Z","updated_at":"2014-06-16T09:23:33Z","html_url":"https://github.com/a14n/dart-js-wrapping/pull/4#discussion_r13796884","pull_request_url":"https://api.github.com/repos/a14n/dart-js-wrapping/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/a14n/dart-js-wrapping/pulls/comments/13796884"},"html":{"href":"https://github.com/a14n/dart-js-wrapping/pull/4#discussion_r13796884"},"pull_request":{"href":"https://api.github.com/repos/a14n/dart-js-wrapping/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/a14n/dart-js-wrapping/pulls/4","id":17152423,"html_url":"https://github.com/a14n/dart-js-wrapping/pull/4","diff_url":"https://github.com/a14n/dart-js-wrapping/pull/4.diff","patch_url":"https://github.com/a14n/dart-js-wrapping/pull/4.patch","issue_url":"https://api.github.com/repos/a14n/dart-js-wrapping/issues/4","number":4,"state":"open","title":"misc improvements","user":{"login":"vicb","id":248818,"avatar_url":"https://avatars.githubusercontent.com/u/248818?","gravatar_id":"ca6e92a6fc51417b3749e68d26df1f29","url":"https://api.github.com/users/vicb","html_url":"https://github.com/vicb","followers_url":"https://api.github.com/users/vicb/followers","following_url":"https://api.github.com/users/vicb/following{/other_user}","gists_url":"https://api.github.com/users/vicb/gists{/gist_id}","starred_url":"https://api.github.com/users/vicb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vicb/subscriptions","organizations_url":"https://api.github.com/users/vicb/orgs","repos_url":"https://api.github.com/users/vicb/repos","events_url":"https://api.github.com/users/vicb/events{/privacy}","received_events_url":"https://api.github.com/users/vicb/received_events","type":"User","site_admin":false},"body":"see commit comments for details","created_at":"2014-06-15T12:49:45Z","updated_at":"2014-06-16T09:23:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ba749619c057bf224924739351b91033b06971d3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/a14n/dart-js-wrapping/pulls/4/commits","review_comments_url":"https://api.github.com/repos/a14n/dart-js-wrapping/pulls/4/comments","review_comment_url":"https://api.github.com/repos/a14n/dart-js-wrapping/pulls/comments/{number}","comments_url":"https://api.github.com/repos/a14n/dart-js-wrapping/issues/4/comments","statuses_url":"https://api.github.com/repos/a14n/dart-js-wrapping/statuses/d60d92ef791300f6c4a421d923939bb3f650546e","head":{"label":"vicb:0615-misc","ref":"0615-misc","sha":"d60d92ef791300f6c4a421d923939bb3f650546e","user":{"login":"vicb","id":248818,"avatar_url":"https://avatars.githubusercontent.com/u/248818?","gravatar_id":"ca6e92a6fc51417b3749e68d26df1f29","url":"https://api.github.com/users/vicb","html_url":"https://github.com/vicb","followers_url":"https://api.github.com/users/vicb/followers","following_url":"https://api.github.com/users/vicb/following{/other_user}","gists_url":"https://api.github.com/users/vicb/gists{/gist_id}","starred_url":"https://api.github.com/users/vicb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vicb/subscriptions","organizations_url":"https://api.github.com/users/vicb/orgs","repos_url":"https://api.github.com/users/vicb/repos","events_url":"https://api.github.com/users/vicb/events{/privacy}","received_events_url":"https://api.github.com/users/vicb/received_events","type":"User","site_admin":false},"repo":{"id":20853205,"name":"dart-js-wrapping","full_name":"vicb/dart-js-wrapping","owner":{"login":"vicb","id":248818,"avatar_url":"https://avatars.githubusercontent.com/u/248818?","gravatar_id":"ca6e92a6fc51417b3749e68d26df1f29","url":"https://api.github.com/users/vicb","html_url":"https://github.com/vicb","followers_url":"https://api.github.com/users/vicb/followers","following_url":"https://api.github.com/users/vicb/following{/other_user}","gists_url":"https://api.github.com/users/vicb/gists{/gist_id}","starred_url":"https://api.github.com/users/vicb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vicb/subscriptions","organizations_url":"https://api.github.com/users/vicb/orgs","repos_url":"https://api.github.com/users/vicb/repos","events_url":"https://api.github.com/users/vicb/events{/privacy}","received_events_url":"https://api.github.com/users/vicb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vicb/dart-js-wrapping","description":"","fork":true,"url":"https://api.github.com/repos/vicb/dart-js-wrapping","forks_url":"https://api.github.com/repos/vicb/dart-js-wrapping/forks","keys_url":"https://api.github.com/repos/vicb/dart-js-wrapping/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vicb/dart-js-wrapping/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vicb/dart-js-wrapping/teams","hooks_url":"https://api.github.com/repos/vicb/dart-js-wrapping/hooks","issue_events_url":"https://api.github.com/repos/vicb/dart-js-wrapping/issues/events{/number}","events_url":"https://api.github.com/repos/vicb/dart-js-wrapping/events","assignees_url":"https://api.github.com/repos/vicb/dart-js-wrapping/assignees{/user}","branches_url":"https://api.github.com/repos/vicb/dart-js-wrapping/branches{/branch}","tags_url":"https://api.github.com/repos/vicb/dart-js-wrapping/tags","blobs_url":"https://api.github.com/repos/vicb/dart-js-wrapping/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vicb/dart-js-wrapping/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vicb/dart-js-wrapping/git/refs{/sha}","trees_url":"https://api.github.com/repos/vicb/dart-js-wrapping/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vicb/dart-js-wrapping/statuses/{sha}","languages_url":"https://api.github.com/repos/vicb/dart-js-wrapping/languages","stargazers_url":"https://api.github.com/repos/vicb/dart-js-wrapping/stargazers","contributors_url":"https://api.github.com/repos/vicb/dart-js-wrapping/contributors","subscribers_url":"https://api.github.com/repos/vicb/dart-js-wrapping/subscribers","subscription_url":"https://api.github.com/repos/vicb/dart-js-wrapping/subscription","commits_url":"https://api.github.com/repos/vicb/dart-js-wrapping/commits{/sha}","git_commits_url":"https://api.github.com/repos/vicb/dart-js-wrapping/git/commits{/sha}","comments_url":"https://api.github.com/repos/vicb/dart-js-wrapping/comments{/number}","issue_comment_url":"https://api.github.com/repos/vicb/dart-js-wrapping/issues/comments/{number}","contents_url":"https://api.github.com/repos/vicb/dart-js-wrapping/contents/{+path}","compare_url":"https://api.github.com/repos/vicb/dart-js-wrapping/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vicb/dart-js-wrapping/merges","archive_url":"https://api.github.com/repos/vicb/dart-js-wrapping/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vicb/dart-js-wrapping/downloads","issues_url":"https://api.github.com/repos/vicb/dart-js-wrapping/issues{/number}","pulls_url":"https://api.github.com/repos/vicb/dart-js-wrapping/pulls{/number}","milestones_url":"https://api.github.com/repos/vicb/dart-js-wrapping/milestones{/number}","notifications_url":"https://api.github.com/repos/vicb/dart-js-wrapping/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vicb/dart-js-wrapping/labels{/name}","releases_url":"https://api.github.com/repos/vicb/dart-js-wrapping/releases{/id}","created_at":"2014-06-15T10:39:41Z","updated_at":"2014-06-16T09:22:09Z","pushed_at":"2014-06-16T09:22:08Z","git_url":"git://github.com/vicb/dart-js-wrapping.git","ssh_url":"git@github.com:vicb/dart-js-wrapping.git","clone_url":"https://github.com/vicb/dart-js-wrapping.git","svn_url":"https://github.com/vicb/dart-js-wrapping","homepage":null,"size":197,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"a14n:master","ref":"master","sha":"f67ca99d8f5305d0b645586157509e311ac65b3c","user":{"login":"a14n","id":1206632,"avatar_url":"https://avatars.githubusercontent.com/u/1206632?","gravatar_id":"198449a7e196c4b0f2ed25f65279bf84","url":"https://api.github.com/users/a14n","html_url":"https://github.com/a14n","followers_url":"https://api.github.com/users/a14n/followers","following_url":"https://api.github.com/users/a14n/following{/other_user}","gists_url":"https://api.github.com/users/a14n/gists{/gist_id}","starred_url":"https://api.github.com/users/a14n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a14n/subscriptions","organizations_url":"https://api.github.com/users/a14n/orgs","repos_url":"https://api.github.com/users/a14n/repos","events_url":"https://api.github.com/users/a14n/events{/privacy}","received_events_url":"https://api.github.com/users/a14n/received_events","type":"User","site_admin":false},"repo":{"id":7444168,"name":"dart-js-wrapping","full_name":"a14n/dart-js-wrapping","owner":{"login":"a14n","id":1206632,"avatar_url":"https://avatars.githubusercontent.com/u/1206632?","gravatar_id":"198449a7e196c4b0f2ed25f65279bf84","url":"https://api.github.com/users/a14n","html_url":"https://github.com/a14n","followers_url":"https://api.github.com/users/a14n/followers","following_url":"https://api.github.com/users/a14n/following{/other_user}","gists_url":"https://api.github.com/users/a14n/gists{/gist_id}","starred_url":"https://api.github.com/users/a14n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a14n/subscriptions","organizations_url":"https://api.github.com/users/a14n/orgs","repos_url":"https://api.github.com/users/a14n/repos","events_url":"https://api.github.com/users/a14n/events{/privacy}","received_events_url":"https://api.github.com/users/a14n/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/a14n/dart-js-wrapping","description":"","fork":false,"url":"https://api.github.com/repos/a14n/dart-js-wrapping","forks_url":"https://api.github.com/repos/a14n/dart-js-wrapping/forks","keys_url":"https://api.github.com/repos/a14n/dart-js-wrapping/keys{/key_id}","collaborators_url":"https://api.github.com/repos/a14n/dart-js-wrapping/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/a14n/dart-js-wrapping/teams","hooks_url":"https://api.github.com/repos/a14n/dart-js-wrapping/hooks","issue_events_url":"https://api.github.com/repos/a14n/dart-js-wrapping/issues/events{/number}","events_url":"https://api.github.com/repos/a14n/dart-js-wrapping/events","assignees_url":"https://api.github.com/repos/a14n/dart-js-wrapping/assignees{/user}","branches_url":"https://api.github.com/repos/a14n/dart-js-wrapping/branches{/branch}","tags_url":"https://api.github.com/repos/a14n/dart-js-wrapping/tags","blobs_url":"https://api.github.com/repos/a14n/dart-js-wrapping/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/a14n/dart-js-wrapping/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/a14n/dart-js-wrapping/git/refs{/sha}","trees_url":"https://api.github.com/repos/a14n/dart-js-wrapping/git/trees{/sha}","statuses_url":"https://api.github.com/repos/a14n/dart-js-wrapping/statuses/{sha}","languages_url":"https://api.github.com/repos/a14n/dart-js-wrapping/languages","stargazers_url":"https://api.github.com/repos/a14n/dart-js-wrapping/stargazers","contributors_url":"https://api.github.com/repos/a14n/dart-js-wrapping/contributors","subscribers_url":"https://api.github.com/repos/a14n/dart-js-wrapping/subscribers","subscription_url":"https://api.github.com/repos/a14n/dart-js-wrapping/subscription","commits_url":"https://api.github.com/repos/a14n/dart-js-wrapping/commits{/sha}","git_commits_url":"https://api.github.com/repos/a14n/dart-js-wrapping/git/commits{/sha}","comments_url":"https://api.github.com/repos/a14n/dart-js-wrapping/comments{/number}","issue_comment_url":"https://api.github.com/repos/a14n/dart-js-wrapping/issues/comments/{number}","contents_url":"https://api.github.com/repos/a14n/dart-js-wrapping/contents/{+path}","compare_url":"https://api.github.com/repos/a14n/dart-js-wrapping/compare/{base}...{head}","merges_url":"https://api.github.com/repos/a14n/dart-js-wrapping/merges","archive_url":"https://api.github.com/repos/a14n/dart-js-wrapping/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/a14n/dart-js-wrapping/downloads","issues_url":"https://api.github.com/repos/a14n/dart-js-wrapping/issues{/number}","pulls_url":"https://api.github.com/repos/a14n/dart-js-wrapping/pulls{/number}","milestones_url":"https://api.github.com/repos/a14n/dart-js-wrapping/milestones{/number}","notifications_url":"https://api.github.com/repos/a14n/dart-js-wrapping/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/a14n/dart-js-wrapping/labels{/name}","releases_url":"https://api.github.com/repos/a14n/dart-js-wrapping/releases{/id}","created_at":"2013-01-04T17:19:39Z","updated_at":"2014-06-16T05:55:47Z","pushed_at":"2014-06-16T05:55:46Z","git_url":"git://github.com/a14n/dart-js-wrapping.git","ssh_url":"git@github.com:a14n/dart-js-wrapping.git","clone_url":"https://github.com/a14n/dart-js-wrapping.git","svn_url":"https://github.com/a14n/dart-js-wrapping","homepage":null,"size":364,"stargazers_count":5,"watchers_count":5,"language":"Dart","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/a14n/dart-js-wrapping/pulls/4"},"html":{"href":"https://github.com/a14n/dart-js-wrapping/pull/4"},"issue":{"href":"https://api.github.com/repos/a14n/dart-js-wrapping/issues/4"},"comments":{"href":"https://api.github.com/repos/a14n/dart-js-wrapping/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/a14n/dart-js-wrapping/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/a14n/dart-js-wrapping/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/a14n/dart-js-wrapping/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/a14n/dart-js-wrapping/statuses/d60d92ef791300f6c4a421d923939bb3f650546e"}}}}