GitHub PullRequestEvent at 2014-04-28 17:52:15
Repository: calcentral
Actor: chikoon
Payload: {"action":"opened","number":2434,"pull_request":{"url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/2434","id":15250522,"html_url":"https://github.com/ets-berkeley-edu/calcentral/pull/2434","diff_url":"https://github.com/ets-berkeley-edu/calcentral/pull/2434.diff","patch_url":"https://github.com/ets-berkeley-edu/calcentral/pull/2434.patch","issue_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/2434","number":2434,"state":"open","title":"CLC-3415: Require re-authentication when accessing admin level functions","user":{"login":"chikoon","id":168363,"avatar_url":"https://avatars.githubusercontent.com/u/168363?","gravatar_id":"448cf464ff43d8933fbfe3cbbd34c5d9","url":"https://api.github.com/users/chikoon","html_url":"https://github.com/chikoon","followers_url":"https://api.github.com/users/chikoon/followers","following_url":"https://api.github.com/users/chikoon/following{/other_user}","gists_url":"https://api.github.com/users/chikoon/gists{/gist_id}","starred_url":"https://api.github.com/users/chikoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chikoon/subscriptions","organizations_url":"https://api.github.com/users/chikoon/orgs","repos_url":"https://api.github.com/users/chikoon/repos","events_url":"https://api.github.com/users/chikoon/events{/privacy}","received_events_url":"https://api.github.com/users/chikoon/received_events","type":"User","site_admin":false},"body":"https://jira.ets.berkeley.edu/jira/browse/CLC-3415\r\n\r\nFor admins who have not reauthenticated in the last 8 hours who\r\ntry to access ccadmin, they are redirected to the CAS login page.\r\n\r\nAt that point, they are reauthorized for the next 8 hours and may\r\nenter ccadmin _and_ as-as another user without being asked to\r\nreauthenticate.\r\n\r\nHow to test v1:\r\n1. log out of calcentral\r\n2. log into calcentral as an admin\r\n3. try accessing /ccadmin\r\n4. you should be asked to reauthenticate on the CAS single sign-on page\r\n5. after that you should enter the rails admin (ccadmin) page\r\n6. go back to the dashboard\r\n7. try accessing /ccadmin\r\n8. you should not be asked to authenticate\r\n9. go to the settings page\r\n10. try viewing as any user (oski, for example)\r\n11. you should view-as as oski without having to reauthenticate\r\n\r\nHow to test v2.\r\n1. log out of calcentral\r\n2. log into calcentral as an admin\r\n3. try viewing as another user\r\n4. you should be asked to reauthenticate on the CAS single sign-on page\r\n5. after that you should be viewing-as the given user\r\n6. hit the stop viewing as page\r\n7. try accessing /ccadmin\r\n8. you should access the rails_admin site administration page without being asked to authenticate\r\n\r\nReauthentication cookie is deleted on manual logouts.  Otherwise, they hang around for 8 hours.\r\n\r\nThis is all behind the Settings.features.reauthentication feature flag.","created_at":"2014-04-28T17:52:14Z","updated_at":"2014-04-28T17:52:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/2434/commits","review_comments_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/2434/comments","review_comment_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/2434/comments","statuses_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/statuses/8bd853f9f93b8ac0c20dba804675bbc5ae175f5b","head":{"label":"chikoon:CLC-3415-reauth-when-accessing-ccadmin","ref":"CLC-3415-reauth-when-accessing-ccadmin","sha":"8bd853f9f93b8ac0c20dba804675bbc5ae175f5b","user":{"login":"chikoon","id":168363,"avatar_url":"https://avatars.githubusercontent.com/u/168363?","gravatar_id":"448cf464ff43d8933fbfe3cbbd34c5d9","url":"https://api.github.com/users/chikoon","html_url":"https://github.com/chikoon","followers_url":"https://api.github.com/users/chikoon/followers","following_url":"https://api.github.com/users/chikoon/following{/other_user}","gists_url":"https://api.github.com/users/chikoon/gists{/gist_id}","starred_url":"https://api.github.com/users/chikoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chikoon/subscriptions","organizations_url":"https://api.github.com/users/chikoon/orgs","repos_url":"https://api.github.com/users/chikoon/repos","events_url":"https://api.github.com/users/chikoon/events{/privacy}","received_events_url":"https://api.github.com/users/chikoon/received_events","type":"User","site_admin":false},"repo":{"id":15139155,"name":"calcentral","full_name":"chikoon/calcentral","owner":{"login":"chikoon","id":168363,"avatar_url":"https://avatars.githubusercontent.com/u/168363?","gravatar_id":"448cf464ff43d8933fbfe3cbbd34c5d9","url":"https://api.github.com/users/chikoon","html_url":"https://github.com/chikoon","followers_url":"https://api.github.com/users/chikoon/followers","following_url":"https://api.github.com/users/chikoon/following{/other_user}","gists_url":"https://api.github.com/users/chikoon/gists{/gist_id}","starred_url":"https://api.github.com/users/chikoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chikoon/subscriptions","organizations_url":"https://api.github.com/users/chikoon/orgs","repos_url":"https://api.github.com/users/chikoon/repos","events_url":"https://api.github.com/users/chikoon/events{/privacy}","received_events_url":"https://api.github.com/users/chikoon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chikoon/calcentral","description":"","fork":true,"url":"https://api.github.com/repos/chikoon/calcentral","forks_url":"https://api.github.com/repos/chikoon/calcentral/forks","keys_url":"https://api.github.com/repos/chikoon/calcentral/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chikoon/calcentral/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chikoon/calcentral/teams","hooks_url":"https://api.github.com/repos/chikoon/calcentral/hooks","issue_events_url":"https://api.github.com/repos/chikoon/calcentral/issues/events{/number}","events_url":"https://api.github.com/repos/chikoon/calcentral/events","assignees_url":"https://api.github.com/repos/chikoon/calcentral/assignees{/user}","branches_url":"https://api.github.com/repos/chikoon/calcentral/branches{/branch}","tags_url":"https://api.github.com/repos/chikoon/calcentral/tags","blobs_url":"https://api.github.com/repos/chikoon/calcentral/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chikoon/calcentral/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chikoon/calcentral/git/refs{/sha}","trees_url":"https://api.github.com/repos/chikoon/calcentral/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chikoon/calcentral/statuses/{sha}","languages_url":"https://api.github.com/repos/chikoon/calcentral/languages","stargazers_url":"https://api.github.com/repos/chikoon/calcentral/stargazers","contributors_url":"https://api.github.com/repos/chikoon/calcentral/contributors","subscribers_url":"https://api.github.com/repos/chikoon/calcentral/subscribers","subscription_url":"https://api.github.com/repos/chikoon/calcentral/subscription","commits_url":"https://api.github.com/repos/chikoon/calcentral/commits{/sha}","git_commits_url":"https://api.github.com/repos/chikoon/calcentral/git/commits{/sha}","comments_url":"https://api.github.com/repos/chikoon/calcentral/comments{/number}","issue_comment_url":"https://api.github.com/repos/chikoon/calcentral/issues/comments/{number}","contents_url":"https://api.github.com/repos/chikoon/calcentral/contents/{+path}","compare_url":"https://api.github.com/repos/chikoon/calcentral/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chikoon/calcentral/merges","archive_url":"https://api.github.com/repos/chikoon/calcentral/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chikoon/calcentral/downloads","issues_url":"https://api.github.com/repos/chikoon/calcentral/issues{/number}","pulls_url":"https://api.github.com/repos/chikoon/calcentral/pulls{/number}","milestones_url":"https://api.github.com/repos/chikoon/calcentral/milestones{/number}","notifications_url":"https://api.github.com/repos/chikoon/calcentral/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chikoon/calcentral/labels{/name}","releases_url":"https://api.github.com/repos/chikoon/calcentral/releases{/id}","created_at":"2013-12-12T15:12:11Z","updated_at":"2014-04-28T17:52:14Z","pushed_at":"2014-04-28T14:35:20Z","git_url":"git://github.com/chikoon/calcentral.git","ssh_url":"git@github.com:chikoon/calcentral.git","clone_url":"https://github.com/chikoon/calcentral.git","svn_url":"https://github.com/chikoon/calcentral","homepage":null,"size":15220,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ets-berkeley-edu:master","ref":"master","sha":"193b516bcc2b81e70419aa27f15f4b95f8ea69de","user":{"login":"ets-berkeley-edu","id":283538,"avatar_url":"https://avatars.githubusercontent.com/u/283538?","gravatar_id":"77e5cbc1c9f6207ed24dae279098c618","url":"https://api.github.com/users/ets-berkeley-edu","html_url":"https://github.com/ets-berkeley-edu","followers_url":"https://api.github.com/users/ets-berkeley-edu/followers","following_url":"https://api.github.com/users/ets-berkeley-edu/following{/other_user}","gists_url":"https://api.github.com/users/ets-berkeley-edu/gists{/gist_id}","starred_url":"https://api.github.com/users/ets-berkeley-edu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ets-berkeley-edu/subscriptions","organizations_url":"https://api.github.com/users/ets-berkeley-edu/orgs","repos_url":"https://api.github.com/users/ets-berkeley-edu/repos","events_url":"https://api.github.com/users/ets-berkeley-edu/events{/privacy}","received_events_url":"https://api.github.com/users/ets-berkeley-edu/received_events","type":"Organization","site_admin":false},"repo":{"id":5483921,"name":"calcentral","full_name":"ets-berkeley-edu/calcentral","owner":{"login":"ets-berkeley-edu","id":283538,"avatar_url":"https://avatars.githubusercontent.com/u/283538?","gravatar_id":"77e5cbc1c9f6207ed24dae279098c618","url":"https://api.github.com/users/ets-berkeley-edu","html_url":"https://github.com/ets-berkeley-edu","followers_url":"https://api.github.com/users/ets-berkeley-edu/followers","following_url":"https://api.github.com/users/ets-berkeley-edu/following{/other_user}","gists_url":"https://api.github.com/users/ets-berkeley-edu/gists{/gist_id}","starred_url":"https://api.github.com/users/ets-berkeley-edu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ets-berkeley-edu/subscriptions","organizations_url":"https://api.github.com/users/ets-berkeley-edu/orgs","repos_url":"https://api.github.com/users/ets-berkeley-edu/repos","events_url":"https://api.github.com/users/ets-berkeley-edu/events{/privacy}","received_events_url":"https://api.github.com/users/ets-berkeley-edu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ets-berkeley-edu/calcentral","description":"","fork":false,"url":"https://api.github.com/repos/ets-berkeley-edu/calcentral","forks_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/forks","keys_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/teams","hooks_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/hooks","issue_events_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/events{/number}","events_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/events","assignees_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/assignees{/user}","branches_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/branches{/branch}","tags_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/tags","blobs_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/git/refs{/sha}","trees_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/statuses/{sha}","languages_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/languages","stargazers_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/stargazers","contributors_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/contributors","subscribers_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/subscribers","subscription_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/subscription","commits_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/commits{/sha}","git_commits_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/git/commits{/sha}","comments_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/comments{/number}","issue_comment_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/comments/{number}","contents_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/contents/{+path}","compare_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/merges","archive_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/downloads","issues_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues{/number}","pulls_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls{/number}","milestones_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/milestones{/number}","notifications_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/labels{/name}","releases_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/releases{/id}","created_at":"2012-08-20T16:45:39Z","updated_at":"2014-04-25T22:54:42Z","pushed_at":"2014-04-25T22:54:41Z","git_url":"git://github.com/ets-berkeley-edu/calcentral.git","ssh_url":"git@github.com:ets-berkeley-edu/calcentral.git","clone_url":"https://github.com/ets-berkeley-edu/calcentral.git","svn_url":"https://github.com/ets-berkeley-edu/calcentral","homepage":"https://calcentral.berkeley.edu","size":26548,"stargazers_count":22,"watchers_count":22,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":30,"mirror_url":null,"open_issues_count":3,"forks":30,"open_issues":3,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/2434"},"html":{"href":"https://github.com/ets-berkeley-edu/calcentral/pull/2434"},"issue":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/2434"},"comments":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/2434/comments"},"review_comments":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/2434/comments"},"review_comment":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/2434/commits"},"statuses":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/statuses/8bd853f9f93b8ac0c20dba804675bbc5ae175f5b"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":56,"deletions":16,"changed_files":6}}