GitHub PullRequestReviewCommentEvent at 2014-11-07 10:44:59
Repository: symfony-docs
Actor: stof
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony-docs/pulls/comments/20004081","id":20004081,"diff_hunk":"@@ -192,9 +192,7 @@ you need is the JavaScript:\n \n                     // create a new list element and add it to the list\n                     var newLi = jQuery('<li></li>').html(newWidget);\n-                    newLi.appendTo(jQuery('#email-fields-list'));\n-\n-                    return false;","path":"reference/forms/types/collection.rst","position":17,"original_position":6,"commit_id":"9d41f67024bb6509088640592facdff10bb98d43","original_commit_id":"9d29df6d4f60f1d9b9847f8fc1841e8aff5896bf","user":{"login":"stof","id":439401,"avatar_url":"https://avatars.githubusercontent.com/u/439401?v=2","gravatar_id":"","url":"https://api.github.com/users/stof","html_url":"https://github.com/stof","followers_url":"https://api.github.com/users/stof/followers","following_url":"https://api.github.com/users/stof/following{/other_user}","gists_url":"https://api.github.com/users/stof/gists{/gist_id}","starred_url":"https://api.github.com/users/stof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stof/subscriptions","organizations_url":"https://api.github.com/users/stof/orgs","repos_url":"https://api.github.com/users/stof/repos","events_url":"https://api.github.com/users/stof/events{/privacy}","received_events_url":"https://api.github.com/users/stof/received_events","type":"User","site_admin":false},"body":"@flip111 to make the review complete, preventing the default is needed. Otherwise, the behavior of ``href=\"#\"`` will be to make your browser scroll to the top of the page","created_at":"2014-11-07T10:44:59Z","updated_at":"2014-11-07T10:44:59Z","html_url":"https://github.com/symfony/symfony-docs/pull/4376#discussion_r20004081","pull_request_url":"https://api.github.com/repos/symfony/symfony-docs/pulls/4376","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/comments/20004081"},"html":{"href":"https://github.com/symfony/symfony-docs/pull/4376#discussion_r20004081"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/4376"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony-docs/pulls/4376","id":23345180,"html_url":"https://github.com/symfony/symfony-docs/pull/4376","diff_url":"https://github.com/symfony/symfony-docs/pull/4376.diff","patch_url":"https://github.com/symfony/symfony-docs/pull/4376.patch","issue_url":"https://api.github.com/repos/symfony/symfony-docs/issues/4376","number":4376,"state":"closed","locked":false,"title":"Cleaned up javascript code","user":{"login":"flip111","id":2244480,"avatar_url":"https://avatars.githubusercontent.com/u/2244480?v=2","gravatar_id":"","url":"https://api.github.com/users/flip111","html_url":"https://github.com/flip111","followers_url":"https://api.github.com/users/flip111/followers","following_url":"https://api.github.com/users/flip111/following{/other_user}","gists_url":"https://api.github.com/users/flip111/gists{/gist_id}","starred_url":"https://api.github.com/users/flip111/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flip111/subscriptions","organizations_url":"https://api.github.com/users/flip111/orgs","repos_url":"https://api.github.com/users/flip111/repos","events_url":"https://api.github.com/users/flip111/events{/privacy}","received_events_url":"https://api.github.com/users/flip111/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Doc fix?      | yes\r\n| New docs?     | no\r\n| Applies to    | 2.3\r\n| Fixed tickets | n/a\r\n\r\n1. Reused variable `emailList` which is best practice and easier to read\r\n2. Removed `return false`. There is no use for it in this context and many consider it to be bad use as well. For example: http://fuelyourcoding.com/jquery-events-stop-misusing-return-false/","created_at":"2014-10-25T23:39:31Z","updated_at":"2014-11-07T10:44:59Z","closed_at":"2014-10-26T14:16:23Z","merged_at":null,"merge_commit_sha":"0038550bb8b81f70c417c49fd868abdf74cfa993","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony-docs/pulls/4376/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony-docs/pulls/4376/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony-docs/pulls/comments/{number}","comments_url":"https://api.github.com/repos/symfony/symfony-docs/issues/4376/comments","statuses_url":"https://api.github.com/repos/symfony/symfony-docs/statuses/9d41f67024bb6509088640592facdff10bb98d43","head":{"label":"flip111:patch-js","ref":"patch-js","sha":"9d41f67024bb6509088640592facdff10bb98d43","user":{"login":"flip111","id":2244480,"avatar_url":"https://avatars.githubusercontent.com/u/2244480?v=2","gravatar_id":"","url":"https://api.github.com/users/flip111","html_url":"https://github.com/flip111","followers_url":"https://api.github.com/users/flip111/followers","following_url":"https://api.github.com/users/flip111/following{/other_user}","gists_url":"https://api.github.com/users/flip111/gists{/gist_id}","starred_url":"https://api.github.com/users/flip111/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flip111/subscriptions","organizations_url":"https://api.github.com/users/flip111/orgs","repos_url":"https://api.github.com/users/flip111/repos","events_url":"https://api.github.com/users/flip111/events{/privacy}","received_events_url":"https://api.github.com/users/flip111/received_events","type":"User","site_admin":false},"repo":{"id":25750542,"name":"symfony-docs","full_name":"flip111/symfony-docs","owner":{"login":"flip111","id":2244480,"avatar_url":"https://avatars.githubusercontent.com/u/2244480?v=2","gravatar_id":"","url":"https://api.github.com/users/flip111","html_url":"https://github.com/flip111","followers_url":"https://api.github.com/users/flip111/followers","following_url":"https://api.github.com/users/flip111/following{/other_user}","gists_url":"https://api.github.com/users/flip111/gists{/gist_id}","starred_url":"https://api.github.com/users/flip111/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flip111/subscriptions","organizations_url":"https://api.github.com/users/flip111/orgs","repos_url":"https://api.github.com/users/flip111/repos","events_url":"https://api.github.com/users/flip111/events{/privacy}","received_events_url":"https://api.github.com/users/flip111/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/flip111/symfony-docs","description":"The Symfony2 documentation","fork":true,"url":"https://api.github.com/repos/flip111/symfony-docs","forks_url":"https://api.github.com/repos/flip111/symfony-docs/forks","keys_url":"https://api.github.com/repos/flip111/symfony-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flip111/symfony-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flip111/symfony-docs/teams","hooks_url":"https://api.github.com/repos/flip111/symfony-docs/hooks","issue_events_url":"https://api.github.com/repos/flip111/symfony-docs/issues/events{/number}","events_url":"https://api.github.com/repos/flip111/symfony-docs/events","assignees_url":"https://api.github.com/repos/flip111/symfony-docs/assignees{/user}","branches_url":"https://api.github.com/repos/flip111/symfony-docs/branches{/branch}","tags_url":"https://api.github.com/repos/flip111/symfony-docs/tags","blobs_url":"https://api.github.com/repos/flip111/symfony-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flip111/symfony-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flip111/symfony-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/flip111/symfony-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flip111/symfony-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/flip111/symfony-docs/languages","stargazers_url":"https://api.github.com/repos/flip111/symfony-docs/stargazers","contributors_url":"https://api.github.com/repos/flip111/symfony-docs/contributors","subscribers_url":"https://api.github.com/repos/flip111/symfony-docs/subscribers","subscription_url":"https://api.github.com/repos/flip111/symfony-docs/subscription","commits_url":"https://api.github.com/repos/flip111/symfony-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/flip111/symfony-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/flip111/symfony-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/flip111/symfony-docs/issues/comments/{number}","contents_url":"https://api.github.com/repos/flip111/symfony-docs/contents/{+path}","compare_url":"https://api.github.com/repos/flip111/symfony-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flip111/symfony-docs/merges","archive_url":"https://api.github.com/repos/flip111/symfony-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flip111/symfony-docs/downloads","issues_url":"https://api.github.com/repos/flip111/symfony-docs/issues{/number}","pulls_url":"https://api.github.com/repos/flip111/symfony-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/flip111/symfony-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/flip111/symfony-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flip111/symfony-docs/labels{/name}","releases_url":"https://api.github.com/repos/flip111/symfony-docs/releases{/id}","created_at":"2014-10-25T23:29:11Z","updated_at":"2014-10-23T12:27:32Z","pushed_at":"2014-10-27T21:46:20Z","git_url":"git://github.com/flip111/symfony-docs.git","ssh_url":"git@github.com:flip111/symfony-docs.git","clone_url":"https://github.com/flip111/symfony-docs.git","svn_url":"https://github.com/flip111/symfony-docs","homepage":"http://symfony.com/doc/current/","size":22330,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:2.3","ref":"2.3","sha":"06e7c5f54a75e55d0cdb6ddf364aa8a17bbda22d","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=2","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":521583,"name":"symfony-docs","full_name":"symfony/symfony-docs","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=2","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony-docs","description":"The Symfony2 documentation","fork":false,"url":"https://api.github.com/repos/symfony/symfony-docs","forks_url":"https://api.github.com/repos/symfony/symfony-docs/forks","keys_url":"https://api.github.com/repos/symfony/symfony-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony-docs/teams","hooks_url":"https://api.github.com/repos/symfony/symfony-docs/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony-docs/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony-docs/events","assignees_url":"https://api.github.com/repos/symfony/symfony-docs/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony-docs/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony-docs/tags","blobs_url":"https://api.github.com/repos/symfony/symfony-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony-docs/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony-docs/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony-docs/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony-docs/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony-docs/subscription","commits_url":"https://api.github.com/repos/symfony/symfony-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony-docs/issues/comments/{number}","contents_url":"https://api.github.com/repos/symfony/symfony-docs/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony-docs/merges","archive_url":"https://api.github.com/repos/symfony/symfony-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony-docs/downloads","issues_url":"https://api.github.com/repos/symfony/symfony-docs/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony-docs/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony-docs/releases{/id}","created_at":"2010-02-17T08:43:51Z","updated_at":"2014-11-05T19:11:17Z","pushed_at":"2014-11-07T10:20:38Z","git_url":"git://github.com/symfony/symfony-docs.git","ssh_url":"git@github.com:symfony/symfony-docs.git","clone_url":"https://github.com/symfony/symfony-docs.git","svn_url":"https://github.com/symfony/symfony-docs","homepage":"http://symfony.com/doc/current/","size":55834,"stargazers_count":932,"watchers_count":932,"language":"Assembly","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1515,"mirror_url":null,"open_issues_count":225,"forks":1515,"open_issues":225,"watchers":932,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/4376"},"html":{"href":"https://github.com/symfony/symfony-docs/pull/4376"},"issue":{"href":"https://api.github.com/repos/symfony/symfony-docs/issues/4376"},"comments":{"href":"https://api.github.com/repos/symfony/symfony-docs/issues/4376/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/4376/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/4376/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony-docs/statuses/9d41f67024bb6509088640592facdff10bb98d43"}}}}