GitHub PullRequestReviewCommentEvent at 2014-09-25 16:42:51
Repository: chef-bcpc
Actor: cbaenziger
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/bloomberg/chef-bcpc/pulls/comments/18043604","id":18043604,"diff_hunk":"@@ -1,3 +1,4 @@\n+export ZOO_DATADIR_AUTOCREATE_DISABLE=1","path":"cookbooks/bcpc-hadoop/templates/default/hdp_zookeeper-server.default.erb","position":1,"original_position":1,"commit_id":"063d7e2f2e61d7b905c61af2f5368af775837295","original_commit_id":"063d7e2f2e61d7b905c61af2f5368af775837295","user":{"login":"cbaenziger","id":4192761,"avatar_url":"https://avatars.githubusercontent.com/u/4192761?v=2","gravatar_id":"","url":"https://api.github.com/users/cbaenziger","html_url":"https://github.com/cbaenziger","followers_url":"https://api.github.com/users/cbaenziger/followers","following_url":"https://api.github.com/users/cbaenziger/following{/other_user}","gists_url":"https://api.github.com/users/cbaenziger/gists{/gist_id}","starred_url":"https://api.github.com/users/cbaenziger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbaenziger/subscriptions","organizations_url":"https://api.github.com/users/cbaenziger/orgs","repos_url":"https://api.github.com/users/cbaenziger/repos","events_url":"https://api.github.com/users/cbaenziger/events{/privacy}","received_events_url":"https://api.github.com/users/cbaenziger/received_events","type":"User","site_admin":false},"body":"Awesome, did not think to actually look at [Zookeeper](http://zookeeper.apache.org/doc/trunk/zookeeperAdmin.html#Disabling+data+directory+autocreation) itself.","created_at":"2014-09-25T16:42:51Z","updated_at":"2014-09-25T16:42:51Z","html_url":"https://github.com/bloomberg/chef-bcpc/pull/336#discussion_r18043604","pull_request_url":"https://api.github.com/repos/bloomberg/chef-bcpc/pulls/336","_links":{"self":{"href":"https://api.github.com/repos/bloomberg/chef-bcpc/pulls/comments/18043604"},"html":{"href":"https://github.com/bloomberg/chef-bcpc/pull/336#discussion_r18043604"},"pull_request":{"href":"https://api.github.com/repos/bloomberg/chef-bcpc/pulls/336"}}},"pull_request":{"url":"https://api.github.com/repos/bloomberg/chef-bcpc/pulls/336","id":21721087,"html_url":"https://github.com/bloomberg/chef-bcpc/pull/336","diff_url":"https://github.com/bloomberg/chef-bcpc/pull/336.diff","patch_url":"https://github.com/bloomberg/chef-bcpc/pull/336.patch","issue_url":"https://api.github.com/repos/bloomberg/chef-bcpc/issues/336","number":336,"state":"open","locked":false,"title":"Fix for issue #294 and other clean-ups related to ZK installation","user":{"login":"bijugs","id":7581305,"avatar_url":"https://avatars.githubusercontent.com/u/7581305?v=2","gravatar_id":"","url":"https://api.github.com/users/bijugs","html_url":"https://github.com/bijugs","followers_url":"https://api.github.com/users/bijugs/followers","following_url":"https://api.github.com/users/bijugs/following{/other_user}","gists_url":"https://api.github.com/users/bijugs/gists{/gist_id}","starred_url":"https://api.github.com/users/bijugs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bijugs/subscriptions","organizations_url":"https://api.github.com/users/bijugs/orgs","repos_url":"https://api.github.com/users/bijugs/repos","events_url":"https://api.github.com/users/bijugs/events{/privacy}","received_events_url":"https://api.github.com/users/bijugs/received_events","type":"User","site_admin":false},"body":"Changes in prep for ZK rolling restart implementation include:\r\n- Fix for issue #294.\r\n- Changes for enhancement #309 \r\n- Changes to prevent manual change to the zookeeper data directory by an admin. But changing the data directory through chef attributes will not be stopped since the directory gets created in chef recipe before ZK gets start.\r\n- Stop [ZK init](https://github.com/bloomberg/chef-bcpc/blob/4c4ba33f0106468f287470e29e624be3b163326c/cookbooks/bcpc-hadoop/recipes/zookeeper_server.rb#L53-L56) and [update-alternatives](https://github.com/bloomberg/chef-bcpc/blob/4c4ba33f0106468f287470e29e624be3b163326c/cookbooks/bcpc-hadoop/recipes/zookeeper_config.rb#L12-L17) resources after the first run. ","created_at":"2014-09-24T15:15:01Z","updated_at":"2014-09-25T16:42:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3a6cb4cf1896432b2094f06599338495162c9cbd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bloomberg/chef-bcpc/pulls/336/commits","review_comments_url":"https://api.github.com/repos/bloomberg/chef-bcpc/pulls/336/comments","review_comment_url":"https://api.github.com/repos/bloomberg/chef-bcpc/pulls/comments/{number}","comments_url":"https://api.github.com/repos/bloomberg/chef-bcpc/issues/336/comments","statuses_url":"https://api.github.com/repos/bloomberg/chef-bcpc/statuses/063d7e2f2e61d7b905c61af2f5368af775837295","head":{"label":"bijugs:fix_issue_294","ref":"fix_issue_294","sha":"063d7e2f2e61d7b905c61af2f5368af775837295","user":{"login":"bijugs","id":7581305,"avatar_url":"https://avatars.githubusercontent.com/u/7581305?v=2","gravatar_id":"","url":"https://api.github.com/users/bijugs","html_url":"https://github.com/bijugs","followers_url":"https://api.github.com/users/bijugs/followers","following_url":"https://api.github.com/users/bijugs/following{/other_user}","gists_url":"https://api.github.com/users/bijugs/gists{/gist_id}","starred_url":"https://api.github.com/users/bijugs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bijugs/subscriptions","organizations_url":"https://api.github.com/users/bijugs/orgs","repos_url":"https://api.github.com/users/bijugs/repos","events_url":"https://api.github.com/users/bijugs/events{/privacy}","received_events_url":"https://api.github.com/users/bijugs/received_events","type":"User","site_admin":false},"repo":{"id":20936589,"name":"chef-bcpc","full_name":"bijugs/chef-bcpc","owner":{"login":"bijugs","id":7581305,"avatar_url":"https://avatars.githubusercontent.com/u/7581305?v=2","gravatar_id":"","url":"https://api.github.com/users/bijugs","html_url":"https://github.com/bijugs","followers_url":"https://api.github.com/users/bijugs/followers","following_url":"https://api.github.com/users/bijugs/following{/other_user}","gists_url":"https://api.github.com/users/bijugs/gists{/gist_id}","starred_url":"https://api.github.com/users/bijugs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bijugs/subscriptions","organizations_url":"https://api.github.com/users/bijugs/orgs","repos_url":"https://api.github.com/users/bijugs/repos","events_url":"https://api.github.com/users/bijugs/events{/privacy}","received_events_url":"https://api.github.com/users/bijugs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bijugs/chef-bcpc","description":"A set of recipes for Chef used to build Bloomberg Clustered Private Cloud nodes.","fork":true,"url":"https://api.github.com/repos/bijugs/chef-bcpc","forks_url":"https://api.github.com/repos/bijugs/chef-bcpc/forks","keys_url":"https://api.github.com/repos/bijugs/chef-bcpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bijugs/chef-bcpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bijugs/chef-bcpc/teams","hooks_url":"https://api.github.com/repos/bijugs/chef-bcpc/hooks","issue_events_url":"https://api.github.com/repos/bijugs/chef-bcpc/issues/events{/number}","events_url":"https://api.github.com/repos/bijugs/chef-bcpc/events","assignees_url":"https://api.github.com/repos/bijugs/chef-bcpc/assignees{/user}","branches_url":"https://api.github.com/repos/bijugs/chef-bcpc/branches{/branch}","tags_url":"https://api.github.com/repos/bijugs/chef-bcpc/tags","blobs_url":"https://api.github.com/repos/bijugs/chef-bcpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bijugs/chef-bcpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bijugs/chef-bcpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/bijugs/chef-bcpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bijugs/chef-bcpc/statuses/{sha}","languages_url":"https://api.github.com/repos/bijugs/chef-bcpc/languages","stargazers_url":"https://api.github.com/repos/bijugs/chef-bcpc/stargazers","contributors_url":"https://api.github.com/repos/bijugs/chef-bcpc/contributors","subscribers_url":"https://api.github.com/repos/bijugs/chef-bcpc/subscribers","subscription_url":"https://api.github.com/repos/bijugs/chef-bcpc/subscription","commits_url":"https://api.github.com/repos/bijugs/chef-bcpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/bijugs/chef-bcpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/bijugs/chef-bcpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/bijugs/chef-bcpc/issues/comments/{number}","contents_url":"https://api.github.com/repos/bijugs/chef-bcpc/contents/{+path}","compare_url":"https://api.github.com/repos/bijugs/chef-bcpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bijugs/chef-bcpc/merges","archive_url":"https://api.github.com/repos/bijugs/chef-bcpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bijugs/chef-bcpc/downloads","issues_url":"https://api.github.com/repos/bijugs/chef-bcpc/issues{/number}","pulls_url":"https://api.github.com/repos/bijugs/chef-bcpc/pulls{/number}","milestones_url":"https://api.github.com/repos/bijugs/chef-bcpc/milestones{/number}","notifications_url":"https://api.github.com/repos/bijugs/chef-bcpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bijugs/chef-bcpc/labels{/name}","releases_url":"https://api.github.com/repos/bijugs/chef-bcpc/releases{/id}","created_at":"2014-06-17T19:18:53Z","updated_at":"2014-07-14T15:00:53Z","pushed_at":"2014-09-25T14:47:53Z","git_url":"git://github.com/bijugs/chef-bcpc.git","ssh_url":"git@github.com:bijugs/chef-bcpc.git","clone_url":"https://github.com/bijugs/chef-bcpc.git","svn_url":"https://github.com/bijugs/chef-bcpc","homepage":null,"size":3280,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"hadoop_hortonworks"}},"base":{"label":"bloomberg:hadoop_hortonworks","ref":"hadoop_hortonworks","sha":"aa954c4f4d16f25ca321e186c0e11b41b8acc309","user":{"login":"bloomberg","id":1416818,"avatar_url":"https://avatars.githubusercontent.com/u/1416818?v=2","gravatar_id":"","url":"https://api.github.com/users/bloomberg","html_url":"https://github.com/bloomberg","followers_url":"https://api.github.com/users/bloomberg/followers","following_url":"https://api.github.com/users/bloomberg/following{/other_user}","gists_url":"https://api.github.com/users/bloomberg/gists{/gist_id}","starred_url":"https://api.github.com/users/bloomberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bloomberg/subscriptions","organizations_url":"https://api.github.com/users/bloomberg/orgs","repos_url":"https://api.github.com/users/bloomberg/repos","events_url":"https://api.github.com/users/bloomberg/events{/privacy}","received_events_url":"https://api.github.com/users/bloomberg/received_events","type":"Organization","site_admin":false},"repo":{"id":9452427,"name":"chef-bcpc","full_name":"bloomberg/chef-bcpc","owner":{"login":"bloomberg","id":1416818,"avatar_url":"https://avatars.githubusercontent.com/u/1416818?v=2","gravatar_id":"","url":"https://api.github.com/users/bloomberg","html_url":"https://github.com/bloomberg","followers_url":"https://api.github.com/users/bloomberg/followers","following_url":"https://api.github.com/users/bloomberg/following{/other_user}","gists_url":"https://api.github.com/users/bloomberg/gists{/gist_id}","starred_url":"https://api.github.com/users/bloomberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bloomberg/subscriptions","organizations_url":"https://api.github.com/users/bloomberg/orgs","repos_url":"https://api.github.com/users/bloomberg/repos","events_url":"https://api.github.com/users/bloomberg/events{/privacy}","received_events_url":"https://api.github.com/users/bloomberg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bloomberg/chef-bcpc","description":"A set of recipes for Chef used to build Bloomberg Clustered Private Cloud nodes.","fork":false,"url":"https://api.github.com/repos/bloomberg/chef-bcpc","forks_url":"https://api.github.com/repos/bloomberg/chef-bcpc/forks","keys_url":"https://api.github.com/repos/bloomberg/chef-bcpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bloomberg/chef-bcpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bloomberg/chef-bcpc/teams","hooks_url":"https://api.github.com/repos/bloomberg/chef-bcpc/hooks","issue_events_url":"https://api.github.com/repos/bloomberg/chef-bcpc/issues/events{/number}","events_url":"https://api.github.com/repos/bloomberg/chef-bcpc/events","assignees_url":"https://api.github.com/repos/bloomberg/chef-bcpc/assignees{/user}","branches_url":"https://api.github.com/repos/bloomberg/chef-bcpc/branches{/branch}","tags_url":"https://api.github.com/repos/bloomberg/chef-bcpc/tags","blobs_url":"https://api.github.com/repos/bloomberg/chef-bcpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bloomberg/chef-bcpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bloomberg/chef-bcpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/bloomberg/chef-bcpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bloomberg/chef-bcpc/statuses/{sha}","languages_url":"https://api.github.com/repos/bloomberg/chef-bcpc/languages","stargazers_url":"https://api.github.com/repos/bloomberg/chef-bcpc/stargazers","contributors_url":"https://api.github.com/repos/bloomberg/chef-bcpc/contributors","subscribers_url":"https://api.github.com/repos/bloomberg/chef-bcpc/subscribers","subscription_url":"https://api.github.com/repos/bloomberg/chef-bcpc/subscription","commits_url":"https://api.github.com/repos/bloomberg/chef-bcpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/bloomberg/chef-bcpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/bloomberg/chef-bcpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/bloomberg/chef-bcpc/issues/comments/{number}","contents_url":"https://api.github.com/repos/bloomberg/chef-bcpc/contents/{+path}","compare_url":"https://api.github.com/repos/bloomberg/chef-bcpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bloomberg/chef-bcpc/merges","archive_url":"https://api.github.com/repos/bloomberg/chef-bcpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bloomberg/chef-bcpc/downloads","issues_url":"https://api.github.com/repos/bloomberg/chef-bcpc/issues{/number}","pulls_url":"https://api.github.com/repos/bloomberg/chef-bcpc/pulls{/number}","milestones_url":"https://api.github.com/repos/bloomberg/chef-bcpc/milestones{/number}","notifications_url":"https://api.github.com/repos/bloomberg/chef-bcpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bloomberg/chef-bcpc/labels{/name}","releases_url":"https://api.github.com/repos/bloomberg/chef-bcpc/releases{/id}","created_at":"2013-04-15T15:56:32Z","updated_at":"2014-09-18T21:03:32Z","pushed_at":"2014-09-24T18:58:07Z","git_url":"git://github.com/bloomberg/chef-bcpc.git","ssh_url":"git@github.com:bloomberg/chef-bcpc.git","clone_url":"https://github.com/bloomberg/chef-bcpc.git","svn_url":"https://github.com/bloomberg/chef-bcpc","homepage":null,"size":9112,"stargazers_count":94,"watchers_count":94,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":45,"mirror_url":null,"open_issues_count":82,"forks":45,"open_issues":82,"watchers":94,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bloomberg/chef-bcpc/pulls/336"},"html":{"href":"https://github.com/bloomberg/chef-bcpc/pull/336"},"issue":{"href":"https://api.github.com/repos/bloomberg/chef-bcpc/issues/336"},"comments":{"href":"https://api.github.com/repos/bloomberg/chef-bcpc/issues/336/comments"},"review_comments":{"href":"https://api.github.com/repos/bloomberg/chef-bcpc/pulls/336/comments"},"review_comment":{"href":"https://api.github.com/repos/bloomberg/chef-bcpc/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/bloomberg/chef-bcpc/pulls/336/commits"},"statuses":{"href":"https://api.github.com/repos/bloomberg/chef-bcpc/statuses/063d7e2f2e61d7b905c61af2f5368af775837295"}}}}