GitHub PullRequestReviewCommentEvent at 2014-07-23 20:14:54
Repository: MMMexercise
Actor: seanwolter
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/seanwolter/MMMexercise/pulls/comments/15312577","id":15312577,"diff_hunk":"@@ -47,7 +49,9 @@ - (instancetype)init\n                           [NSDate date],\n                           [NSDate date],\n                           ] retain]; //Why retain this array? What does @[] return?\n-        [self retain];\n+        //This array is created and retained as part of the initialization of the \"fish\" object. It will be released by the statement in the dealloc method below.\n+//        [self retain];\n+        //I am removing this line because there is no need to further retain this object that is already initialized and given an autorelease. Furthermore, only a moron would further use retain in an init method.","path":"ManualMemoryManagement/MMMFish.m","position":23,"original_position":23,"commit_id":"573916f546e37fde6e5a4919c3fd7a73d0cfc638","original_commit_id":"573916f546e37fde6e5a4919c3fd7a73d0cfc638","user":{"login":"seanwolter","id":68043,"avatar_url":"https://avatars.githubusercontent.com/u/68043?","gravatar_id":"646d315b9d1a130648d26a0cc22c906c","url":"https://api.github.com/users/seanwolter","html_url":"https://github.com/seanwolter","followers_url":"https://api.github.com/users/seanwolter/followers","following_url":"https://api.github.com/users/seanwolter/following{/other_user}","gists_url":"https://api.github.com/users/seanwolter/gists{/gist_id}","starred_url":"https://api.github.com/users/seanwolter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanwolter/subscriptions","organizations_url":"https://api.github.com/users/seanwolter/orgs","repos_url":"https://api.github.com/users/seanwolter/repos","events_url":"https://api.github.com/users/seanwolter/events{/privacy}","received_events_url":"https://api.github.com/users/seanwolter/received_events","type":"User","site_admin":false},"body":"The last part is correct. The first part is half correct. The autorelease in the convenience constructor is outside the scope of this method.","created_at":"2014-07-23T20:14:54Z","updated_at":"2014-07-23T20:14:54Z","html_url":"https://github.com/seanwolter/MMMexercise/pull/1#discussion_r15312577","pull_request_url":"https://api.github.com/repos/seanwolter/MMMexercise/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/seanwolter/MMMexercise/pulls/comments/15312577"},"html":{"href":"https://github.com/seanwolter/MMMexercise/pull/1#discussion_r15312577"},"pull_request":{"href":"https://api.github.com/repos/seanwolter/MMMexercise/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/seanwolter/MMMexercise/pulls/1","id":18798869,"html_url":"https://github.com/seanwolter/MMMexercise/pull/1","diff_url":"https://github.com/seanwolter/MMMexercise/pull/1.diff","patch_url":"https://github.com/seanwolter/MMMexercise/pull/1.patch","issue_url":"https://api.github.com/repos/seanwolter/MMMexercise/issues/1","number":1,"state":"open","title":"Assignment completed","user":{"login":"mvoracek","id":6088189,"avatar_url":"https://avatars.githubusercontent.com/u/6088189?","gravatar_id":"23d41ddac97547619b109aa7624f1eaf","url":"https://api.github.com/users/mvoracek","html_url":"https://github.com/mvoracek","followers_url":"https://api.github.com/users/mvoracek/followers","following_url":"https://api.github.com/users/mvoracek/following{/other_user}","gists_url":"https://api.github.com/users/mvoracek/gists{/gist_id}","starred_url":"https://api.github.com/users/mvoracek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvoracek/subscriptions","organizations_url":"https://api.github.com/users/mvoracek/orgs","repos_url":"https://api.github.com/users/mvoracek/repos","events_url":"https://api.github.com/users/mvoracek/events{/privacy}","received_events_url":"https://api.github.com/users/mvoracek/received_events","type":"User","site_admin":false},"body":"Check this out at your leisure.","created_at":"2014-07-23T19:57:42Z","updated_at":"2014-07-23T20:14:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e7b6faabb4e99be2c7f7303e128e791cf365525c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/seanwolter/MMMexercise/pulls/1/commits","review_comments_url":"https://api.github.com/repos/seanwolter/MMMexercise/pulls/1/comments","review_comment_url":"https://api.github.com/repos/seanwolter/MMMexercise/pulls/comments/{number}","comments_url":"https://api.github.com/repos/seanwolter/MMMexercise/issues/1/comments","statuses_url":"https://api.github.com/repos/seanwolter/MMMexercise/statuses/573916f546e37fde6e5a4919c3fd7a73d0cfc638","head":{"label":"mvoracek:master","ref":"master","sha":"573916f546e37fde6e5a4919c3fd7a73d0cfc638","user":{"login":"mvoracek","id":6088189,"avatar_url":"https://avatars.githubusercontent.com/u/6088189?","gravatar_id":"23d41ddac97547619b109aa7624f1eaf","url":"https://api.github.com/users/mvoracek","html_url":"https://github.com/mvoracek","followers_url":"https://api.github.com/users/mvoracek/followers","following_url":"https://api.github.com/users/mvoracek/following{/other_user}","gists_url":"https://api.github.com/users/mvoracek/gists{/gist_id}","starred_url":"https://api.github.com/users/mvoracek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvoracek/subscriptions","organizations_url":"https://api.github.com/users/mvoracek/orgs","repos_url":"https://api.github.com/users/mvoracek/repos","events_url":"https://api.github.com/users/mvoracek/events{/privacy}","received_events_url":"https://api.github.com/users/mvoracek/received_events","type":"User","site_admin":false},"repo":{"id":22077343,"name":"MMMexercise","full_name":"mvoracek/MMMexercise","owner":{"login":"mvoracek","id":6088189,"avatar_url":"https://avatars.githubusercontent.com/u/6088189?","gravatar_id":"23d41ddac97547619b109aa7624f1eaf","url":"https://api.github.com/users/mvoracek","html_url":"https://github.com/mvoracek","followers_url":"https://api.github.com/users/mvoracek/followers","following_url":"https://api.github.com/users/mvoracek/following{/other_user}","gists_url":"https://api.github.com/users/mvoracek/gists{/gist_id}","starred_url":"https://api.github.com/users/mvoracek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvoracek/subscriptions","organizations_url":"https://api.github.com/users/mvoracek/orgs","repos_url":"https://api.github.com/users/mvoracek/repos","events_url":"https://api.github.com/users/mvoracek/events{/privacy}","received_events_url":"https://api.github.com/users/mvoracek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mvoracek/MMMexercise","description":"a manual memory management exercise","fork":true,"url":"https://api.github.com/repos/mvoracek/MMMexercise","forks_url":"https://api.github.com/repos/mvoracek/MMMexercise/forks","keys_url":"https://api.github.com/repos/mvoracek/MMMexercise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mvoracek/MMMexercise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mvoracek/MMMexercise/teams","hooks_url":"https://api.github.com/repos/mvoracek/MMMexercise/hooks","issue_events_url":"https://api.github.com/repos/mvoracek/MMMexercise/issues/events{/number}","events_url":"https://api.github.com/repos/mvoracek/MMMexercise/events","assignees_url":"https://api.github.com/repos/mvoracek/MMMexercise/assignees{/user}","branches_url":"https://api.github.com/repos/mvoracek/MMMexercise/branches{/branch}","tags_url":"https://api.github.com/repos/mvoracek/MMMexercise/tags","blobs_url":"https://api.github.com/repos/mvoracek/MMMexercise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mvoracek/MMMexercise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mvoracek/MMMexercise/git/refs{/sha}","trees_url":"https://api.github.com/repos/mvoracek/MMMexercise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mvoracek/MMMexercise/statuses/{sha}","languages_url":"https://api.github.com/repos/mvoracek/MMMexercise/languages","stargazers_url":"https://api.github.com/repos/mvoracek/MMMexercise/stargazers","contributors_url":"https://api.github.com/repos/mvoracek/MMMexercise/contributors","subscribers_url":"https://api.github.com/repos/mvoracek/MMMexercise/subscribers","subscription_url":"https://api.github.com/repos/mvoracek/MMMexercise/subscription","commits_url":"https://api.github.com/repos/mvoracek/MMMexercise/commits{/sha}","git_commits_url":"https://api.github.com/repos/mvoracek/MMMexercise/git/commits{/sha}","comments_url":"https://api.github.com/repos/mvoracek/MMMexercise/comments{/number}","issue_comment_url":"https://api.github.com/repos/mvoracek/MMMexercise/issues/comments/{number}","contents_url":"https://api.github.com/repos/mvoracek/MMMexercise/contents/{+path}","compare_url":"https://api.github.com/repos/mvoracek/MMMexercise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mvoracek/MMMexercise/merges","archive_url":"https://api.github.com/repos/mvoracek/MMMexercise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mvoracek/MMMexercise/downloads","issues_url":"https://api.github.com/repos/mvoracek/MMMexercise/issues{/number}","pulls_url":"https://api.github.com/repos/mvoracek/MMMexercise/pulls{/number}","milestones_url":"https://api.github.com/repos/mvoracek/MMMexercise/milestones{/number}","notifications_url":"https://api.github.com/repos/mvoracek/MMMexercise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mvoracek/MMMexercise/labels{/name}","releases_url":"https://api.github.com/repos/mvoracek/MMMexercise/releases{/id}","created_at":"2014-07-21T19:31:09Z","updated_at":"2014-07-22T15:45:24Z","pushed_at":"2014-07-23T19:56:28Z","git_url":"git://github.com/mvoracek/MMMexercise.git","ssh_url":"git@github.com:mvoracek/MMMexercise.git","clone_url":"https://github.com/mvoracek/MMMexercise.git","svn_url":"https://github.com/mvoracek/MMMexercise","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"seanwolter:master","ref":"master","sha":"0c4240412994b0fc9975134f3fc88aea2ac6cc8c","user":{"login":"seanwolter","id":68043,"avatar_url":"https://avatars.githubusercontent.com/u/68043?","gravatar_id":"646d315b9d1a130648d26a0cc22c906c","url":"https://api.github.com/users/seanwolter","html_url":"https://github.com/seanwolter","followers_url":"https://api.github.com/users/seanwolter/followers","following_url":"https://api.github.com/users/seanwolter/following{/other_user}","gists_url":"https://api.github.com/users/seanwolter/gists{/gist_id}","starred_url":"https://api.github.com/users/seanwolter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanwolter/subscriptions","organizations_url":"https://api.github.com/users/seanwolter/orgs","repos_url":"https://api.github.com/users/seanwolter/repos","events_url":"https://api.github.com/users/seanwolter/events{/privacy}","received_events_url":"https://api.github.com/users/seanwolter/received_events","type":"User","site_admin":false},"repo":{"id":22067100,"name":"MMMexercise","full_name":"seanwolter/MMMexercise","owner":{"login":"seanwolter","id":68043,"avatar_url":"https://avatars.githubusercontent.com/u/68043?","gravatar_id":"646d315b9d1a130648d26a0cc22c906c","url":"https://api.github.com/users/seanwolter","html_url":"https://github.com/seanwolter","followers_url":"https://api.github.com/users/seanwolter/followers","following_url":"https://api.github.com/users/seanwolter/following{/other_user}","gists_url":"https://api.github.com/users/seanwolter/gists{/gist_id}","starred_url":"https://api.github.com/users/seanwolter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanwolter/subscriptions","organizations_url":"https://api.github.com/users/seanwolter/orgs","repos_url":"https://api.github.com/users/seanwolter/repos","events_url":"https://api.github.com/users/seanwolter/events{/privacy}","received_events_url":"https://api.github.com/users/seanwolter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/seanwolter/MMMexercise","description":"a manual memory management exercise","fork":false,"url":"https://api.github.com/repos/seanwolter/MMMexercise","forks_url":"https://api.github.com/repos/seanwolter/MMMexercise/forks","keys_url":"https://api.github.com/repos/seanwolter/MMMexercise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/seanwolter/MMMexercise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/seanwolter/MMMexercise/teams","hooks_url":"https://api.github.com/repos/seanwolter/MMMexercise/hooks","issue_events_url":"https://api.github.com/repos/seanwolter/MMMexercise/issues/events{/number}","events_url":"https://api.github.com/repos/seanwolter/MMMexercise/events","assignees_url":"https://api.github.com/repos/seanwolter/MMMexercise/assignees{/user}","branches_url":"https://api.github.com/repos/seanwolter/MMMexercise/branches{/branch}","tags_url":"https://api.github.com/repos/seanwolter/MMMexercise/tags","blobs_url":"https://api.github.com/repos/seanwolter/MMMexercise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/seanwolter/MMMexercise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/seanwolter/MMMexercise/git/refs{/sha}","trees_url":"https://api.github.com/repos/seanwolter/MMMexercise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/seanwolter/MMMexercise/statuses/{sha}","languages_url":"https://api.github.com/repos/seanwolter/MMMexercise/languages","stargazers_url":"https://api.github.com/repos/seanwolter/MMMexercise/stargazers","contributors_url":"https://api.github.com/repos/seanwolter/MMMexercise/contributors","subscribers_url":"https://api.github.com/repos/seanwolter/MMMexercise/subscribers","subscription_url":"https://api.github.com/repos/seanwolter/MMMexercise/subscription","commits_url":"https://api.github.com/repos/seanwolter/MMMexercise/commits{/sha}","git_commits_url":"https://api.github.com/repos/seanwolter/MMMexercise/git/commits{/sha}","comments_url":"https://api.github.com/repos/seanwolter/MMMexercise/comments{/number}","issue_comment_url":"https://api.github.com/repos/seanwolter/MMMexercise/issues/comments/{number}","contents_url":"https://api.github.com/repos/seanwolter/MMMexercise/contents/{+path}","compare_url":"https://api.github.com/repos/seanwolter/MMMexercise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/seanwolter/MMMexercise/merges","archive_url":"https://api.github.com/repos/seanwolter/MMMexercise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/seanwolter/MMMexercise/downloads","issues_url":"https://api.github.com/repos/seanwolter/MMMexercise/issues{/number}","pulls_url":"https://api.github.com/repos/seanwolter/MMMexercise/pulls{/number}","milestones_url":"https://api.github.com/repos/seanwolter/MMMexercise/milestones{/number}","notifications_url":"https://api.github.com/repos/seanwolter/MMMexercise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/seanwolter/MMMexercise/labels{/name}","releases_url":"https://api.github.com/repos/seanwolter/MMMexercise/releases{/id}","created_at":"2014-07-21T14:18:06Z","updated_at":"2014-07-21T14:19:19Z","pushed_at":"2014-07-21T14:20:39Z","git_url":"git://github.com/seanwolter/MMMexercise.git","ssh_url":"git@github.com:seanwolter/MMMexercise.git","clone_url":"https://github.com/seanwolter/MMMexercise.git","svn_url":"https://github.com/seanwolter/MMMexercise","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/seanwolter/MMMexercise/pulls/1"},"html":{"href":"https://github.com/seanwolter/MMMexercise/pull/1"},"issue":{"href":"https://api.github.com/repos/seanwolter/MMMexercise/issues/1"},"comments":{"href":"https://api.github.com/repos/seanwolter/MMMexercise/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/seanwolter/MMMexercise/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/seanwolter/MMMexercise/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/seanwolter/MMMexercise/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/seanwolter/MMMexercise/statuses/573916f546e37fde6e5a4919c3fd7a73d0cfc638"}}}}