GitHub PullRequestReviewCommentEvent at 2014-09-24 17:28:36
Repository: zds-site
Actor: Alex-D
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/zestedesavoir/zds-site/pulls/comments/17986340","id":17986340,"diff_hunk":"@@ -16,3 +16,64 @@ Si vous voulez installer et démarrer une instance locale de ZdS, vous devez cli\n    install/install-windows\n    install/install-os-x\n    install/install-linux\n+\n+Il est possible de personnaliser ZdS pour n'importe quel site communautaire de partage. Un ensemble de paramètres est disponible dans le fichier ``settings.py`` via un dictionnaire. Vous pourrez donc écraser ces variables par défaut dans votre fichier ``settings_prod.py``. Le dictionnaire de variables relatives au site est donc le suivant :\n+\n+.. sourcecode:: python\n+\n+    ZDS_APP = {","path":"doc/sphinx/source/introduction.rst","position":9,"original_position":9,"commit_id":"c78a3e18b0c0091adceb49beca94195ef1b6f8ea","original_commit_id":"c78a3e18b0c0091adceb49beca94195ef1b6f8ea","user":{"login":"Alex-D","id":426843,"avatar_url":"https://avatars.githubusercontent.com/u/426843?v=2","gravatar_id":"","url":"https://api.github.com/users/Alex-D","html_url":"https://github.com/Alex-D","followers_url":"https://api.github.com/users/Alex-D/followers","following_url":"https://api.github.com/users/Alex-D/following{/other_user}","gists_url":"https://api.github.com/users/Alex-D/gists{/gist_id}","starred_url":"https://api.github.com/users/Alex-D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alex-D/subscriptions","organizations_url":"https://api.github.com/users/Alex-D/orgs","repos_url":"https://api.github.com/users/Alex-D/repos","events_url":"https://api.github.com/users/Alex-D/events{/privacy}","received_events_url":"https://api.github.com/users/Alex-D/received_events","type":"User","site_admin":false},"body":"C'est pas très judicieux de mettre ZDS dans le nom de la variable, vu que ça concerne l'application en général et que ce nom est utilisé en dur dans le code python.","created_at":"2014-09-24T17:28:36Z","updated_at":"2014-09-24T17:28:36Z","html_url":"https://github.com/zestedesavoir/zds-site/pull/1531#discussion_r17986340","pull_request_url":"https://api.github.com/repos/zestedesavoir/zds-site/pulls/1531","_links":{"self":{"href":"https://api.github.com/repos/zestedesavoir/zds-site/pulls/comments/17986340"},"html":{"href":"https://github.com/zestedesavoir/zds-site/pull/1531#discussion_r17986340"},"pull_request":{"href":"https://api.github.com/repos/zestedesavoir/zds-site/pulls/1531"}}},"pull_request":{"url":"https://api.github.com/repos/zestedesavoir/zds-site/pulls/1531","id":21719748,"html_url":"https://github.com/zestedesavoir/zds-site/pull/1531","diff_url":"https://github.com/zestedesavoir/zds-site/pull/1531.diff","patch_url":"https://github.com/zestedesavoir/zds-site/pull/1531.patch","issue_url":"https://api.github.com/repos/zestedesavoir/zds-site/issues/1531","number":1531,"state":"open","locked":false,"title":"Rendre le site vraiment opensource","user":{"login":"firm1","id":6066015,"avatar_url":"https://avatars.githubusercontent.com/u/6066015?v=2","gravatar_id":"","url":"https://api.github.com/users/firm1","html_url":"https://github.com/firm1","followers_url":"https://api.github.com/users/firm1/followers","following_url":"https://api.github.com/users/firm1/following{/other_user}","gists_url":"https://api.github.com/users/firm1/gists{/gist_id}","starred_url":"https://api.github.com/users/firm1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firm1/subscriptions","organizations_url":"https://api.github.com/users/firm1/orgs","repos_url":"https://api.github.com/users/firm1/repos","events_url":"https://api.github.com/users/firm1/events{/privacy}","received_events_url":"https://api.github.com/users/firm1/received_events","type":"User","site_admin":false},"body":"| Q                         | R\r\n| ------------------------- | -------------------------------------------\r\n| Correction de bugs ?      | non\r\n| Nouvelle Fonctionnalité ? | non\r\n| Nettoyage ? | oui\r\n| Tickets concernés         | #1520\r\n\r\nCette PR a pour objectif de rendre le site **vraiment** opensource. Car les paramètres liées aux informations générales du site, sont désormais localisés à un seul endroit (un dictionnaire). Et le reste du site s'adaptera aux paramètres en question.\r\n\r\nN'importe qui peut maintenant forker zds pour l'utiliser pour **lui** et pas uniquement pour ZdS.\r\n\r\n**Note pour QA**\r\n\r\nModifier les paramètres dans le dictionnaire du settings.py avec les infos suivantes (par exemple), et vérifier que le site s'est adapté dans la présentation : \r\n\r\n```\r\n    ZDS_APP = {\r\n        'site': {\r\n            'name': u\"Developpez.com\",\r\n            'litteral_name': u\"Club Developpez.com\",\r\n            'slogan': u\"Developpez.com, Club des développeurs et IT pro \",\r\n            'abbr': u\"dvpz\",\r\n            'url': u\"http://127.0.0.1:8000\",\r\n            'dns': u\"developpez.com\",\r\n            'email_contact': u\"communication@developpez.com\",\r\n            'email_noreply': u\"noreply@developpez.com\",\r\n            'repository': u\"https://github.com/developpez/zds-site\",\r\n            'short_description': u\"\",\r\n            'long_description': u\"le club Developpez.com est la plus grande communauté \"\r\n                                u\"internationale des professionnels en informatique de langue \"\r\n                                u\"française (France, Belgique, Luxembourg, Suisse, Canada, Afrique)\",\r\n            'year': u\"2000-2014\",\r\n            'hosting': {\r\n                'name': u\"Ikoula\",\r\n                'address': u\"177 Rue d'Aguesseau, 92100 Boulogne-Billancourt\"\r\n            },\r\n            'cnil': u\"45879653\",\r\n        },\r\n        'member': {\r\n            'bot_account': u\"admin\",\r\n            'members_per_page': 100,\r\n        },\r\n        'gallery': {\r\n            'image_max_size': 1024 * 1024,\r\n        },\r\n        'article': {\r\n            'repo_path': os.path.join(SITE_ROOT, 'articles-data'),\r\n        },\r\n        'tutorial': {\r\n            'repo_path': os.path.join(SITE_ROOT, 'tutoriels-private'),\r\n            'repo_public_path': os.path.join(SITE_ROOT, 'tutoriels-public'),\r\n            'default_license_pk': 7\r\n        },\r\n        'forum': {\r\n            'posts_per_page': 21,\r\n            'topics_per_page': 21,\r\n            'spam_limit_seconds': 60 * 15,\r\n            'spam_limit_participant': 2,\r\n            'followed_topics_per_page': 21,\r\n            'beta_forum_id': 1,\r\n            'max_post_length': 1000000,\r\n            'top_tag_max': 5,\r\n        }\r\n    }\r\n```\r\n","created_at":"2014-09-24T14:58:18Z","updated_at":"2014-09-24T17:28:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"81a853fe6ff7604d4cdf06660a5c151b957863c6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zestedesavoir/zds-site/pulls/1531/commits","review_comments_url":"https://api.github.com/repos/zestedesavoir/zds-site/pulls/1531/comments","review_comment_url":"https://api.github.com/repos/zestedesavoir/zds-site/pulls/comments/{number}","comments_url":"https://api.github.com/repos/zestedesavoir/zds-site/issues/1531/comments","statuses_url":"https://api.github.com/repos/zestedesavoir/zds-site/statuses/c78a3e18b0c0091adceb49beca94195ef1b6f8ea","head":{"label":"firm1:opensourcify","ref":"opensourcify","sha":"c78a3e18b0c0091adceb49beca94195ef1b6f8ea","user":{"login":"firm1","id":6066015,"avatar_url":"https://avatars.githubusercontent.com/u/6066015?v=2","gravatar_id":"","url":"https://api.github.com/users/firm1","html_url":"https://github.com/firm1","followers_url":"https://api.github.com/users/firm1/followers","following_url":"https://api.github.com/users/firm1/following{/other_user}","gists_url":"https://api.github.com/users/firm1/gists{/gist_id}","starred_url":"https://api.github.com/users/firm1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firm1/subscriptions","organizations_url":"https://api.github.com/users/firm1/orgs","repos_url":"https://api.github.com/users/firm1/repos","events_url":"https://api.github.com/users/firm1/events{/privacy}","received_events_url":"https://api.github.com/users/firm1/received_events","type":"User","site_admin":false},"repo":{"id":22507463,"name":"zds-site","full_name":"firm1/zds-site","owner":{"login":"firm1","id":6066015,"avatar_url":"https://avatars.githubusercontent.com/u/6066015?v=2","gravatar_id":"","url":"https://api.github.com/users/firm1","html_url":"https://github.com/firm1","followers_url":"https://api.github.com/users/firm1/followers","following_url":"https://api.github.com/users/firm1/following{/other_user}","gists_url":"https://api.github.com/users/firm1/gists{/gist_id}","starred_url":"https://api.github.com/users/firm1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firm1/subscriptions","organizations_url":"https://api.github.com/users/firm1/orgs","repos_url":"https://api.github.com/users/firm1/repos","events_url":"https://api.github.com/users/firm1/events{/privacy}","received_events_url":"https://api.github.com/users/firm1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/firm1/zds-site","description":"Dépot ZDS","fork":true,"url":"https://api.github.com/repos/firm1/zds-site","forks_url":"https://api.github.com/repos/firm1/zds-site/forks","keys_url":"https://api.github.com/repos/firm1/zds-site/keys{/key_id}","collaborators_url":"https://api.github.com/repos/firm1/zds-site/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/firm1/zds-site/teams","hooks_url":"https://api.github.com/repos/firm1/zds-site/hooks","issue_events_url":"https://api.github.com/repos/firm1/zds-site/issues/events{/number}","events_url":"https://api.github.com/repos/firm1/zds-site/events","assignees_url":"https://api.github.com/repos/firm1/zds-site/assignees{/user}","branches_url":"https://api.github.com/repos/firm1/zds-site/branches{/branch}","tags_url":"https://api.github.com/repos/firm1/zds-site/tags","blobs_url":"https://api.github.com/repos/firm1/zds-site/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/firm1/zds-site/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/firm1/zds-site/git/refs{/sha}","trees_url":"https://api.github.com/repos/firm1/zds-site/git/trees{/sha}","statuses_url":"https://api.github.com/repos/firm1/zds-site/statuses/{sha}","languages_url":"https://api.github.com/repos/firm1/zds-site/languages","stargazers_url":"https://api.github.com/repos/firm1/zds-site/stargazers","contributors_url":"https://api.github.com/repos/firm1/zds-site/contributors","subscribers_url":"https://api.github.com/repos/firm1/zds-site/subscribers","subscription_url":"https://api.github.com/repos/firm1/zds-site/subscription","commits_url":"https://api.github.com/repos/firm1/zds-site/commits{/sha}","git_commits_url":"https://api.github.com/repos/firm1/zds-site/git/commits{/sha}","comments_url":"https://api.github.com/repos/firm1/zds-site/comments{/number}","issue_comment_url":"https://api.github.com/repos/firm1/zds-site/issues/comments/{number}","contents_url":"https://api.github.com/repos/firm1/zds-site/contents/{+path}","compare_url":"https://api.github.com/repos/firm1/zds-site/compare/{base}...{head}","merges_url":"https://api.github.com/repos/firm1/zds-site/merges","archive_url":"https://api.github.com/repos/firm1/zds-site/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/firm1/zds-site/downloads","issues_url":"https://api.github.com/repos/firm1/zds-site/issues{/number}","pulls_url":"https://api.github.com/repos/firm1/zds-site/pulls{/number}","milestones_url":"https://api.github.com/repos/firm1/zds-site/milestones{/number}","notifications_url":"https://api.github.com/repos/firm1/zds-site/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/firm1/zds-site/labels{/name}","releases_url":"https://api.github.com/repos/firm1/zds-site/releases{/id}","created_at":"2014-08-01T11:47:06Z","updated_at":"2014-08-12T01:02:34Z","pushed_at":"2014-09-24T11:04:05Z","git_url":"git://github.com/firm1/zds-site.git","ssh_url":"git@github.com:firm1/zds-site.git","clone_url":"https://github.com/firm1/zds-site.git","svn_url":"https://github.com/firm1/zds-site","homepage":null,"size":51367,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"zestedesavoir:dev","ref":"dev","sha":"d67c1155e3e493366ebced241d5c84c124741d39","user":{"login":"zestedesavoir","id":7406239,"avatar_url":"https://avatars.githubusercontent.com/u/7406239?v=2","gravatar_id":"","url":"https://api.github.com/users/zestedesavoir","html_url":"https://github.com/zestedesavoir","followers_url":"https://api.github.com/users/zestedesavoir/followers","following_url":"https://api.github.com/users/zestedesavoir/following{/other_user}","gists_url":"https://api.github.com/users/zestedesavoir/gists{/gist_id}","starred_url":"https://api.github.com/users/zestedesavoir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zestedesavoir/subscriptions","organizations_url":"https://api.github.com/users/zestedesavoir/orgs","repos_url":"https://api.github.com/users/zestedesavoir/repos","events_url":"https://api.github.com/users/zestedesavoir/events{/privacy}","received_events_url":"https://api.github.com/users/zestedesavoir/received_events","type":"Organization","site_admin":false},"repo":{"id":14778920,"name":"zds-site","full_name":"zestedesavoir/zds-site","owner":{"login":"zestedesavoir","id":7406239,"avatar_url":"https://avatars.githubusercontent.com/u/7406239?v=2","gravatar_id":"","url":"https://api.github.com/users/zestedesavoir","html_url":"https://github.com/zestedesavoir","followers_url":"https://api.github.com/users/zestedesavoir/followers","following_url":"https://api.github.com/users/zestedesavoir/following{/other_user}","gists_url":"https://api.github.com/users/zestedesavoir/gists{/gist_id}","starred_url":"https://api.github.com/users/zestedesavoir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zestedesavoir/subscriptions","organizations_url":"https://api.github.com/users/zestedesavoir/orgs","repos_url":"https://api.github.com/users/zestedesavoir/repos","events_url":"https://api.github.com/users/zestedesavoir/events{/privacy}","received_events_url":"https://api.github.com/users/zestedesavoir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zestedesavoir/zds-site","description":"Dépot ZDS","fork":false,"url":"https://api.github.com/repos/zestedesavoir/zds-site","forks_url":"https://api.github.com/repos/zestedesavoir/zds-site/forks","keys_url":"https://api.github.com/repos/zestedesavoir/zds-site/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zestedesavoir/zds-site/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zestedesavoir/zds-site/teams","hooks_url":"https://api.github.com/repos/zestedesavoir/zds-site/hooks","issue_events_url":"https://api.github.com/repos/zestedesavoir/zds-site/issues/events{/number}","events_url":"https://api.github.com/repos/zestedesavoir/zds-site/events","assignees_url":"https://api.github.com/repos/zestedesavoir/zds-site/assignees{/user}","branches_url":"https://api.github.com/repos/zestedesavoir/zds-site/branches{/branch}","tags_url":"https://api.github.com/repos/zestedesavoir/zds-site/tags","blobs_url":"https://api.github.com/repos/zestedesavoir/zds-site/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zestedesavoir/zds-site/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zestedesavoir/zds-site/git/refs{/sha}","trees_url":"https://api.github.com/repos/zestedesavoir/zds-site/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zestedesavoir/zds-site/statuses/{sha}","languages_url":"https://api.github.com/repos/zestedesavoir/zds-site/languages","stargazers_url":"https://api.github.com/repos/zestedesavoir/zds-site/stargazers","contributors_url":"https://api.github.com/repos/zestedesavoir/zds-site/contributors","subscribers_url":"https://api.github.com/repos/zestedesavoir/zds-site/subscribers","subscription_url":"https://api.github.com/repos/zestedesavoir/zds-site/subscription","commits_url":"https://api.github.com/repos/zestedesavoir/zds-site/commits{/sha}","git_commits_url":"https://api.github.com/repos/zestedesavoir/zds-site/git/commits{/sha}","comments_url":"https://api.github.com/repos/zestedesavoir/zds-site/comments{/number}","issue_comment_url":"https://api.github.com/repos/zestedesavoir/zds-site/issues/comments/{number}","contents_url":"https://api.github.com/repos/zestedesavoir/zds-site/contents/{+path}","compare_url":"https://api.github.com/repos/zestedesavoir/zds-site/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zestedesavoir/zds-site/merges","archive_url":"https://api.github.com/repos/zestedesavoir/zds-site/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zestedesavoir/zds-site/downloads","issues_url":"https://api.github.com/repos/zestedesavoir/zds-site/issues{/number}","pulls_url":"https://api.github.com/repos/zestedesavoir/zds-site/pulls{/number}","milestones_url":"https://api.github.com/repos/zestedesavoir/zds-site/milestones{/number}","notifications_url":"https://api.github.com/repos/zestedesavoir/zds-site/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zestedesavoir/zds-site/labels{/name}","releases_url":"https://api.github.com/repos/zestedesavoir/zds-site/releases{/id}","created_at":"2013-11-28T14:23:48Z","updated_at":"2014-09-23T12:56:42Z","pushed_at":"2014-09-24T15:11:26Z","git_url":"git://github.com/zestedesavoir/zds-site.git","ssh_url":"git@github.com:zestedesavoir/zds-site.git","clone_url":"https://github.com/zestedesavoir/zds-site.git","svn_url":"https://github.com/zestedesavoir/zds-site","homepage":null,"size":138046,"stargazers_count":56,"watchers_count":56,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":50,"mirror_url":null,"open_issues_count":147,"forks":50,"open_issues":147,"watchers":56,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/zestedesavoir/zds-site/pulls/1531"},"html":{"href":"https://github.com/zestedesavoir/zds-site/pull/1531"},"issue":{"href":"https://api.github.com/repos/zestedesavoir/zds-site/issues/1531"},"comments":{"href":"https://api.github.com/repos/zestedesavoir/zds-site/issues/1531/comments"},"review_comments":{"href":"https://api.github.com/repos/zestedesavoir/zds-site/pulls/1531/comments"},"review_comment":{"href":"https://api.github.com/repos/zestedesavoir/zds-site/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/zestedesavoir/zds-site/pulls/1531/commits"},"statuses":{"href":"https://api.github.com/repos/zestedesavoir/zds-site/statuses/c78a3e18b0c0091adceb49beca94195ef1b6f8ea"}}}}