GitHub PullRequestReviewCommentEvent at 2014-06-23 19:29:44
Repository: knife-openstack
Actor: btm
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/opscode/knife-openstack/pulls/comments/14094919","id":14094919,"diff_hunk":"@@ -512,6 +525,29 @@ def get_node_name(chef_node_name)\n         # lazy uuids\n         chef_node_name = \"os-\" + rand.to_s.split('.')[1]\n       end\n+\n+      # warn on using secret_key in knife.rb\n+      def warn_chef_config_secret_key\n+        unless Chef::Config[:encrypted_data_bag_secret].nil?\n+          ui.warn \"* \" * 40\n+          ui.warn(<<-WARNING)\n+Specifying the encrypted data bag secret key using an 'encrypted_data_bag_secret'\n+entry in 'knife.rb' is deprecated. Please see CHEF-4011 for more details. You\n+can supress this warning and still distribute the secret key to all bootstrapped","path":"lib/chef/knife/openstack_server_create.rb","position":46,"original_position":46,"commit_id":"ae1f3745ec3ea8bfb165885fe16d12356bafae0e","original_commit_id":"ae1f3745ec3ea8bfb165885fe16d12356bafae0e","user":{"login":"btm","id":4381,"avatar_url":"https://avatars.githubusercontent.com/u/4381?","gravatar_id":"4e4adb8dd390e1daecb15a67f05ae0d1","url":"https://api.github.com/users/btm","html_url":"https://github.com/btm","followers_url":"https://api.github.com/users/btm/followers","following_url":"https://api.github.com/users/btm/following{/other_user}","gists_url":"https://api.github.com/users/btm/gists{/gist_id}","starred_url":"https://api.github.com/users/btm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btm/subscriptions","organizations_url":"https://api.github.com/users/btm/orgs","repos_url":"https://api.github.com/users/btm/repos","events_url":"https://api.github.com/users/btm/events{/privacy}","received_events_url":"https://api.github.com/users/btm/received_events","type":"User","site_admin":false},"body":"I realize you copied this from another file, but *suppress* is the correct spelling and would be good to fix.","created_at":"2014-06-23T19:29:44Z","updated_at":"2014-06-23T19:29:44Z","html_url":"https://github.com/opscode/knife-openstack/pull/113#discussion_r14094919","pull_request_url":"https://api.github.com/repos/opscode/knife-openstack/pulls/113","_links":{"self":{"href":"https://api.github.com/repos/opscode/knife-openstack/pulls/comments/14094919"},"html":{"href":"https://github.com/opscode/knife-openstack/pull/113#discussion_r14094919"},"pull_request":{"href":"https://api.github.com/repos/opscode/knife-openstack/pulls/113"}}},"pull_request":{"url":"https://api.github.com/repos/opscode/knife-openstack/pulls/113","id":16532136,"html_url":"https://github.com/opscode/knife-openstack/pull/113","diff_url":"https://github.com/opscode/knife-openstack/pull/113.diff","patch_url":"https://github.com/opscode/knife-openstack/pull/113.patch","issue_url":"https://api.github.com/repos/opscode/knife-openstack/issues/113","number":113,"state":"open","title":"KNIFE-494 add options for secret and secret_file to support encrypted data bags","user":{"login":"jvervlied","id":4173528,"avatar_url":"https://avatars.githubusercontent.com/u/4173528?","gravatar_id":"99908ec3dc195d9001ad2c49d2ed72a7","url":"https://api.github.com/users/jvervlied","html_url":"https://github.com/jvervlied","followers_url":"https://api.github.com/users/jvervlied/followers","following_url":"https://api.github.com/users/jvervlied/following{/other_user}","gists_url":"https://api.github.com/users/jvervlied/gists{/gist_id}","starred_url":"https://api.github.com/users/jvervlied/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvervlied/subscriptions","organizations_url":"https://api.github.com/users/jvervlied/orgs","repos_url":"https://api.github.com/users/jvervlied/repos","events_url":"https://api.github.com/users/jvervlied/events{/privacy}","received_events_url":"https://api.github.com/users/jvervlied/received_events","type":"User","site_admin":false},"body":"When using encrypted data bags, the current plugin uses the soon to be deprecated encrypted_data_bag_secret and encrypted_data_bag_secret_file options. This patch updates knife openstack server create to use the same functionality as knife bootstrap. Also it allows for command line switches to use this functionality instead of having to embed it in the knife.rb file.\r\n\r\nThe warning included was copied directly out of knife bootstrap.","created_at":"2014-05-30T13:18:09Z","updated_at":"2014-06-23T19:29:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3a8bad2f5e6cc885287cf82bd8f5eb8e1b38b8a0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/opscode/knife-openstack/pulls/113/commits","review_comments_url":"https://api.github.com/repos/opscode/knife-openstack/pulls/113/comments","review_comment_url":"https://api.github.com/repos/opscode/knife-openstack/pulls/comments/{number}","comments_url":"https://api.github.com/repos/opscode/knife-openstack/issues/113/comments","statuses_url":"https://api.github.com/repos/opscode/knife-openstack/statuses/ae1f3745ec3ea8bfb165885fe16d12356bafae0e","head":{"label":"jvervlied:master","ref":"master","sha":"ae1f3745ec3ea8bfb165885fe16d12356bafae0e","user":{"login":"jvervlied","id":4173528,"avatar_url":"https://avatars.githubusercontent.com/u/4173528?","gravatar_id":"99908ec3dc195d9001ad2c49d2ed72a7","url":"https://api.github.com/users/jvervlied","html_url":"https://github.com/jvervlied","followers_url":"https://api.github.com/users/jvervlied/followers","following_url":"https://api.github.com/users/jvervlied/following{/other_user}","gists_url":"https://api.github.com/users/jvervlied/gists{/gist_id}","starred_url":"https://api.github.com/users/jvervlied/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvervlied/subscriptions","organizations_url":"https://api.github.com/users/jvervlied/orgs","repos_url":"https://api.github.com/users/jvervlied/repos","events_url":"https://api.github.com/users/jvervlied/events{/privacy}","received_events_url":"https://api.github.com/users/jvervlied/received_events","type":"User","site_admin":false},"repo":{"id":15169313,"name":"knife-openstack","full_name":"jvervlied/knife-openstack","owner":{"login":"jvervlied","id":4173528,"avatar_url":"https://avatars.githubusercontent.com/u/4173528?","gravatar_id":"99908ec3dc195d9001ad2c49d2ed72a7","url":"https://api.github.com/users/jvervlied","html_url":"https://github.com/jvervlied","followers_url":"https://api.github.com/users/jvervlied/followers","following_url":"https://api.github.com/users/jvervlied/following{/other_user}","gists_url":"https://api.github.com/users/jvervlied/gists{/gist_id}","starred_url":"https://api.github.com/users/jvervlied/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvervlied/subscriptions","organizations_url":"https://api.github.com/users/jvervlied/orgs","repos_url":"https://api.github.com/users/jvervlied/repos","events_url":"https://api.github.com/users/jvervlied/events{/privacy}","received_events_url":"https://api.github.com/users/jvervlied/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jvervlied/knife-openstack","description":"Opscode Chef knife plug-in for OpenStack","fork":true,"url":"https://api.github.com/repos/jvervlied/knife-openstack","forks_url":"https://api.github.com/repos/jvervlied/knife-openstack/forks","keys_url":"https://api.github.com/repos/jvervlied/knife-openstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jvervlied/knife-openstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jvervlied/knife-openstack/teams","hooks_url":"https://api.github.com/repos/jvervlied/knife-openstack/hooks","issue_events_url":"https://api.github.com/repos/jvervlied/knife-openstack/issues/events{/number}","events_url":"https://api.github.com/repos/jvervlied/knife-openstack/events","assignees_url":"https://api.github.com/repos/jvervlied/knife-openstack/assignees{/user}","branches_url":"https://api.github.com/repos/jvervlied/knife-openstack/branches{/branch}","tags_url":"https://api.github.com/repos/jvervlied/knife-openstack/tags","blobs_url":"https://api.github.com/repos/jvervlied/knife-openstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jvervlied/knife-openstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jvervlied/knife-openstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/jvervlied/knife-openstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jvervlied/knife-openstack/statuses/{sha}","languages_url":"https://api.github.com/repos/jvervlied/knife-openstack/languages","stargazers_url":"https://api.github.com/repos/jvervlied/knife-openstack/stargazers","contributors_url":"https://api.github.com/repos/jvervlied/knife-openstack/contributors","subscribers_url":"https://api.github.com/repos/jvervlied/knife-openstack/subscribers","subscription_url":"https://api.github.com/repos/jvervlied/knife-openstack/subscription","commits_url":"https://api.github.com/repos/jvervlied/knife-openstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/jvervlied/knife-openstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/jvervlied/knife-openstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/jvervlied/knife-openstack/issues/comments/{number}","contents_url":"https://api.github.com/repos/jvervlied/knife-openstack/contents/{+path}","compare_url":"https://api.github.com/repos/jvervlied/knife-openstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jvervlied/knife-openstack/merges","archive_url":"https://api.github.com/repos/jvervlied/knife-openstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jvervlied/knife-openstack/downloads","issues_url":"https://api.github.com/repos/jvervlied/knife-openstack/issues{/number}","pulls_url":"https://api.github.com/repos/jvervlied/knife-openstack/pulls{/number}","milestones_url":"https://api.github.com/repos/jvervlied/knife-openstack/milestones{/number}","notifications_url":"https://api.github.com/repos/jvervlied/knife-openstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jvervlied/knife-openstack/labels{/name}","releases_url":"https://api.github.com/repos/jvervlied/knife-openstack/releases{/id}","created_at":"2013-12-13T17:11:51Z","updated_at":"2014-05-30T13:18:09Z","pushed_at":"2014-05-30T13:14:00Z","git_url":"git://github.com/jvervlied/knife-openstack.git","ssh_url":"git@github.com:jvervlied/knife-openstack.git","clone_url":"https://github.com/jvervlied/knife-openstack.git","svn_url":"https://github.com/jvervlied/knife-openstack","homepage":"","size":560,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opscode:master","ref":"master","sha":"9a798aa6edcc5e5c6793ec2d238f76262a2a5485","user":{"login":"opscode","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?","gravatar_id":"890bf76f4dc18c12a19c55e988a1bd5e","url":"https://api.github.com/users/opscode","html_url":"https://github.com/opscode","followers_url":"https://api.github.com/users/opscode/followers","following_url":"https://api.github.com/users/opscode/following{/other_user}","gists_url":"https://api.github.com/users/opscode/gists{/gist_id}","starred_url":"https://api.github.com/users/opscode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opscode/subscriptions","organizations_url":"https://api.github.com/users/opscode/orgs","repos_url":"https://api.github.com/users/opscode/repos","events_url":"https://api.github.com/users/opscode/events{/privacy}","received_events_url":"https://api.github.com/users/opscode/received_events","type":"Organization","site_admin":false},"repo":{"id":1507487,"name":"knife-openstack","full_name":"opscode/knife-openstack","owner":{"login":"opscode","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?","gravatar_id":"890bf76f4dc18c12a19c55e988a1bd5e","url":"https://api.github.com/users/opscode","html_url":"https://github.com/opscode","followers_url":"https://api.github.com/users/opscode/followers","following_url":"https://api.github.com/users/opscode/following{/other_user}","gists_url":"https://api.github.com/users/opscode/gists{/gist_id}","starred_url":"https://api.github.com/users/opscode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opscode/subscriptions","organizations_url":"https://api.github.com/users/opscode/orgs","repos_url":"https://api.github.com/users/opscode/repos","events_url":"https://api.github.com/users/opscode/events{/privacy}","received_events_url":"https://api.github.com/users/opscode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opscode/knife-openstack","description":"Opscode Chef knife plug-in for OpenStack","fork":false,"url":"https://api.github.com/repos/opscode/knife-openstack","forks_url":"https://api.github.com/repos/opscode/knife-openstack/forks","keys_url":"https://api.github.com/repos/opscode/knife-openstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opscode/knife-openstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opscode/knife-openstack/teams","hooks_url":"https://api.github.com/repos/opscode/knife-openstack/hooks","issue_events_url":"https://api.github.com/repos/opscode/knife-openstack/issues/events{/number}","events_url":"https://api.github.com/repos/opscode/knife-openstack/events","assignees_url":"https://api.github.com/repos/opscode/knife-openstack/assignees{/user}","branches_url":"https://api.github.com/repos/opscode/knife-openstack/branches{/branch}","tags_url":"https://api.github.com/repos/opscode/knife-openstack/tags","blobs_url":"https://api.github.com/repos/opscode/knife-openstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opscode/knife-openstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opscode/knife-openstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/opscode/knife-openstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opscode/knife-openstack/statuses/{sha}","languages_url":"https://api.github.com/repos/opscode/knife-openstack/languages","stargazers_url":"https://api.github.com/repos/opscode/knife-openstack/stargazers","contributors_url":"https://api.github.com/repos/opscode/knife-openstack/contributors","subscribers_url":"https://api.github.com/repos/opscode/knife-openstack/subscribers","subscription_url":"https://api.github.com/repos/opscode/knife-openstack/subscription","commits_url":"https://api.github.com/repos/opscode/knife-openstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/opscode/knife-openstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/opscode/knife-openstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/opscode/knife-openstack/issues/comments/{number}","contents_url":"https://api.github.com/repos/opscode/knife-openstack/contents/{+path}","compare_url":"https://api.github.com/repos/opscode/knife-openstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opscode/knife-openstack/merges","archive_url":"https://api.github.com/repos/opscode/knife-openstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opscode/knife-openstack/downloads","issues_url":"https://api.github.com/repos/opscode/knife-openstack/issues{/number}","pulls_url":"https://api.github.com/repos/opscode/knife-openstack/pulls{/number}","milestones_url":"https://api.github.com/repos/opscode/knife-openstack/milestones{/number}","notifications_url":"https://api.github.com/repos/opscode/knife-openstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opscode/knife-openstack/labels{/name}","releases_url":"https://api.github.com/repos/opscode/knife-openstack/releases{/id}","created_at":"2011-03-21T16:41:13Z","updated_at":"2014-06-20T21:27:00Z","pushed_at":"2014-06-20T21:26:59Z","git_url":"git://github.com/opscode/knife-openstack.git","ssh_url":"git@github.com:opscode/knife-openstack.git","clone_url":"https://github.com/opscode/knife-openstack.git","svn_url":"https://github.com/opscode/knife-openstack","homepage":"","size":2648,"stargazers_count":111,"watchers_count":111,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":99,"mirror_url":null,"open_issues_count":9,"forks":99,"open_issues":9,"watchers":111,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opscode/knife-openstack/pulls/113"},"html":{"href":"https://github.com/opscode/knife-openstack/pull/113"},"issue":{"href":"https://api.github.com/repos/opscode/knife-openstack/issues/113"},"comments":{"href":"https://api.github.com/repos/opscode/knife-openstack/issues/113/comments"},"review_comments":{"href":"https://api.github.com/repos/opscode/knife-openstack/pulls/113/comments"},"review_comment":{"href":"https://api.github.com/repos/opscode/knife-openstack/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/opscode/knife-openstack/pulls/113/commits"},"statuses":{"href":"https://api.github.com/repos/opscode/knife-openstack/statuses/ae1f3745ec3ea8bfb165885fe16d12356bafae0e"}}}}