GitHub PullRequestReviewCommentEvent at 2014-09-17 11:56:32
Repository: Bukkit
Actor: Ribesg
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Ribesg/Bukkit/pulls/comments/17659353","id":17659353,"diff_hunk":"@@ -445,7 +445,7 @@ public Part setLocalizedText(String id, String... parameters) {\n      * @return this Part for chain calls\n      */\n     public Part setLocalizedTextParameters(String... parameters) {\n-        this.localizedTextParameters = parameters.length == 0 ? null : parameters;\n+        this.localizedTextParameters = parameters == null || parameters.length == 0 ? null : parameters;","path":"src/main/java/org/bukkit/chat/Part.java","position":5,"original_position":5,"commit_id":"c80cfd77d5447c69355f0f2766b7455f58d81fb4","original_commit_id":"c80cfd77d5447c69355f0f2766b7455f58d81fb4","user":{"login":"Ribesg","id":1339686,"avatar_url":"https://avatars.githubusercontent.com/u/1339686?v=2","gravatar_id":"0cb67ceda76e6c0325a87839e18fcf9d","url":"https://api.github.com/users/Ribesg","html_url":"https://github.com/Ribesg","followers_url":"https://api.github.com/users/Ribesg/followers","following_url":"https://api.github.com/users/Ribesg/following{/other_user}","gists_url":"https://api.github.com/users/Ribesg/gists{/gist_id}","starred_url":"https://api.github.com/users/Ribesg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ribesg/subscriptions","organizations_url":"https://api.github.com/users/Ribesg/orgs","repos_url":"https://api.github.com/users/Ribesg/repos","events_url":"https://api.github.com/users/Ribesg/events{/privacy}","received_events_url":"https://api.github.com/users/Ribesg/received_events","type":"User","site_admin":false},"body":"I'm really not sure about this. Can you pass a null object to this method? Doesn't it create a ``String`` array of length 1 with ``parameters[0] == null``?\r\n\r\nMaybe you can pass a ``null`` variable of type ``String[]``. Would require testing maybe?","created_at":"2014-09-17T11:56:32Z","updated_at":"2014-09-17T11:56:32Z","html_url":"https://github.com/Ribesg/Bukkit/pull/17#discussion_r17659353","pull_request_url":"https://api.github.com/repos/Ribesg/Bukkit/pulls/17","_links":{"self":{"href":"https://api.github.com/repos/Ribesg/Bukkit/pulls/comments/17659353"},"html":{"href":"https://github.com/Ribesg/Bukkit/pull/17#discussion_r17659353"},"pull_request":{"href":"https://api.github.com/repos/Ribesg/Bukkit/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/Ribesg/Bukkit/pulls/17","id":21317750,"html_url":"https://github.com/Ribesg/Bukkit/pull/17","diff_url":"https://github.com/Ribesg/Bukkit/pull/17.diff","patch_url":"https://github.com/Ribesg/Bukkit/pull/17.patch","issue_url":"https://api.github.com/repos/Ribesg/Bukkit/issues/17","number":17,"state":"open","locked":false,"title":"Minor improvements","user":{"login":"ST-DDT","id":1579362,"avatar_url":"https://avatars.githubusercontent.com/u/1579362?v=2","gravatar_id":"9168201aca5c88c3545cfd442d772ee6","url":"https://api.github.com/users/ST-DDT","html_url":"https://github.com/ST-DDT","followers_url":"https://api.github.com/users/ST-DDT/followers","following_url":"https://api.github.com/users/ST-DDT/following{/other_user}","gists_url":"https://api.github.com/users/ST-DDT/gists{/gist_id}","starred_url":"https://api.github.com/users/ST-DDT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ST-DDT/subscriptions","organizations_url":"https://api.github.com/users/ST-DDT/orgs","repos_url":"https://api.github.com/users/ST-DDT/repos","events_url":"https://api.github.com/users/ST-DDT/events{/privacy}","received_events_url":"https://api.github.com/users/ST-DDT/received_events","type":"User","site_admin":false},"body":"Added ````return this```` to ````Message.set(int,Part)````\r\nFixed potential NPE in ````Part.setLocalizedTextParameters(String...)````","created_at":"2014-09-16T18:21:24Z","updated_at":"2014-09-17T11:56:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e97ccfbca4431721adc7c0847c03d75056ec739f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Ribesg/Bukkit/pulls/17/commits","review_comments_url":"https://api.github.com/repos/Ribesg/Bukkit/pulls/17/comments","review_comment_url":"https://api.github.com/repos/Ribesg/Bukkit/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Ribesg/Bukkit/issues/17/comments","statuses_url":"https://api.github.com/repos/Ribesg/Bukkit/statuses/c80cfd77d5447c69355f0f2766b7455f58d81fb4","head":{"label":"ST-DDT:BUKKIT-5245-v2_improvements","ref":"BUKKIT-5245-v2_improvements","sha":"c80cfd77d5447c69355f0f2766b7455f58d81fb4","user":{"login":"ST-DDT","id":1579362,"avatar_url":"https://avatars.githubusercontent.com/u/1579362?v=2","gravatar_id":"9168201aca5c88c3545cfd442d772ee6","url":"https://api.github.com/users/ST-DDT","html_url":"https://github.com/ST-DDT","followers_url":"https://api.github.com/users/ST-DDT/followers","following_url":"https://api.github.com/users/ST-DDT/following{/other_user}","gists_url":"https://api.github.com/users/ST-DDT/gists{/gist_id}","starred_url":"https://api.github.com/users/ST-DDT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ST-DDT/subscriptions","organizations_url":"https://api.github.com/users/ST-DDT/orgs","repos_url":"https://api.github.com/users/ST-DDT/repos","events_url":"https://api.github.com/users/ST-DDT/events{/privacy}","received_events_url":"https://api.github.com/users/ST-DDT/received_events","type":"User","site_admin":false},"repo":{"id":15265740,"name":"Bukkit","full_name":"ST-DDT/Bukkit","owner":{"login":"ST-DDT","id":1579362,"avatar_url":"https://avatars.githubusercontent.com/u/1579362?v=2","gravatar_id":"9168201aca5c88c3545cfd442d772ee6","url":"https://api.github.com/users/ST-DDT","html_url":"https://github.com/ST-DDT","followers_url":"https://api.github.com/users/ST-DDT/followers","following_url":"https://api.github.com/users/ST-DDT/following{/other_user}","gists_url":"https://api.github.com/users/ST-DDT/gists{/gist_id}","starred_url":"https://api.github.com/users/ST-DDT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ST-DDT/subscriptions","organizations_url":"https://api.github.com/users/ST-DDT/orgs","repos_url":"https://api.github.com/users/ST-DDT/repos","events_url":"https://api.github.com/users/ST-DDT/events{/privacy}","received_events_url":"https://api.github.com/users/ST-DDT/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ST-DDT/Bukkit","description":"The Minecraft Mod API","fork":true,"url":"https://api.github.com/repos/ST-DDT/Bukkit","forks_url":"https://api.github.com/repos/ST-DDT/Bukkit/forks","keys_url":"https://api.github.com/repos/ST-DDT/Bukkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ST-DDT/Bukkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ST-DDT/Bukkit/teams","hooks_url":"https://api.github.com/repos/ST-DDT/Bukkit/hooks","issue_events_url":"https://api.github.com/repos/ST-DDT/Bukkit/issues/events{/number}","events_url":"https://api.github.com/repos/ST-DDT/Bukkit/events","assignees_url":"https://api.github.com/repos/ST-DDT/Bukkit/assignees{/user}","branches_url":"https://api.github.com/repos/ST-DDT/Bukkit/branches{/branch}","tags_url":"https://api.github.com/repos/ST-DDT/Bukkit/tags","blobs_url":"https://api.github.com/repos/ST-DDT/Bukkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ST-DDT/Bukkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ST-DDT/Bukkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/ST-DDT/Bukkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ST-DDT/Bukkit/statuses/{sha}","languages_url":"https://api.github.com/repos/ST-DDT/Bukkit/languages","stargazers_url":"https://api.github.com/repos/ST-DDT/Bukkit/stargazers","contributors_url":"https://api.github.com/repos/ST-DDT/Bukkit/contributors","subscribers_url":"https://api.github.com/repos/ST-DDT/Bukkit/subscribers","subscription_url":"https://api.github.com/repos/ST-DDT/Bukkit/subscription","commits_url":"https://api.github.com/repos/ST-DDT/Bukkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/ST-DDT/Bukkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/ST-DDT/Bukkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/ST-DDT/Bukkit/issues/comments/{number}","contents_url":"https://api.github.com/repos/ST-DDT/Bukkit/contents/{+path}","compare_url":"https://api.github.com/repos/ST-DDT/Bukkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ST-DDT/Bukkit/merges","archive_url":"https://api.github.com/repos/ST-DDT/Bukkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ST-DDT/Bukkit/downloads","issues_url":"https://api.github.com/repos/ST-DDT/Bukkit/issues{/number}","pulls_url":"https://api.github.com/repos/ST-DDT/Bukkit/pulls{/number}","milestones_url":"https://api.github.com/repos/ST-DDT/Bukkit/milestones{/number}","notifications_url":"https://api.github.com/repos/ST-DDT/Bukkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ST-DDT/Bukkit/labels{/name}","releases_url":"https://api.github.com/repos/ST-DDT/Bukkit/releases{/id}","created_at":"2013-12-17T20:58:42Z","updated_at":"2014-07-10T18:57:13Z","pushed_at":"2014-09-16T18:19:02Z","git_url":"git://github.com/ST-DDT/Bukkit.git","ssh_url":"git@github.com:ST-DDT/Bukkit.git","clone_url":"https://github.com/ST-DDT/Bukkit.git","svn_url":"https://github.com/ST-DDT/Bukkit","homepage":"http://bukkit.org","size":5126,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Ribesg:BUKKIT-5245-v2","ref":"BUKKIT-5245-v2","sha":"5fb2d366d1b0b3dcd9ab77316c57573f16aaba02","user":{"login":"Ribesg","id":1339686,"avatar_url":"https://avatars.githubusercontent.com/u/1339686?v=2","gravatar_id":"0cb67ceda76e6c0325a87839e18fcf9d","url":"https://api.github.com/users/Ribesg","html_url":"https://github.com/Ribesg","followers_url":"https://api.github.com/users/Ribesg/followers","following_url":"https://api.github.com/users/Ribesg/following{/other_user}","gists_url":"https://api.github.com/users/Ribesg/gists{/gist_id}","starred_url":"https://api.github.com/users/Ribesg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ribesg/subscriptions","organizations_url":"https://api.github.com/users/Ribesg/orgs","repos_url":"https://api.github.com/users/Ribesg/repos","events_url":"https://api.github.com/users/Ribesg/events{/privacy}","received_events_url":"https://api.github.com/users/Ribesg/received_events","type":"User","site_admin":false},"repo":{"id":15670576,"name":"Bukkit","full_name":"Ribesg/Bukkit","owner":{"login":"Ribesg","id":1339686,"avatar_url":"https://avatars.githubusercontent.com/u/1339686?v=2","gravatar_id":"0cb67ceda76e6c0325a87839e18fcf9d","url":"https://api.github.com/users/Ribesg","html_url":"https://github.com/Ribesg","followers_url":"https://api.github.com/users/Ribesg/followers","following_url":"https://api.github.com/users/Ribesg/following{/other_user}","gists_url":"https://api.github.com/users/Ribesg/gists{/gist_id}","starred_url":"https://api.github.com/users/Ribesg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ribesg/subscriptions","organizations_url":"https://api.github.com/users/Ribesg/orgs","repos_url":"https://api.github.com/users/Ribesg/repos","events_url":"https://api.github.com/users/Ribesg/events{/privacy}","received_events_url":"https://api.github.com/users/Ribesg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ribesg/Bukkit","description":"The Minecraft Mod API","fork":true,"url":"https://api.github.com/repos/Ribesg/Bukkit","forks_url":"https://api.github.com/repos/Ribesg/Bukkit/forks","keys_url":"https://api.github.com/repos/Ribesg/Bukkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ribesg/Bukkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ribesg/Bukkit/teams","hooks_url":"https://api.github.com/repos/Ribesg/Bukkit/hooks","issue_events_url":"https://api.github.com/repos/Ribesg/Bukkit/issues/events{/number}","events_url":"https://api.github.com/repos/Ribesg/Bukkit/events","assignees_url":"https://api.github.com/repos/Ribesg/Bukkit/assignees{/user}","branches_url":"https://api.github.com/repos/Ribesg/Bukkit/branches{/branch}","tags_url":"https://api.github.com/repos/Ribesg/Bukkit/tags","blobs_url":"https://api.github.com/repos/Ribesg/Bukkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ribesg/Bukkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ribesg/Bukkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ribesg/Bukkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ribesg/Bukkit/statuses/{sha}","languages_url":"https://api.github.com/repos/Ribesg/Bukkit/languages","stargazers_url":"https://api.github.com/repos/Ribesg/Bukkit/stargazers","contributors_url":"https://api.github.com/repos/Ribesg/Bukkit/contributors","subscribers_url":"https://api.github.com/repos/Ribesg/Bukkit/subscribers","subscription_url":"https://api.github.com/repos/Ribesg/Bukkit/subscription","commits_url":"https://api.github.com/repos/Ribesg/Bukkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ribesg/Bukkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ribesg/Bukkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ribesg/Bukkit/issues/comments/{number}","contents_url":"https://api.github.com/repos/Ribesg/Bukkit/contents/{+path}","compare_url":"https://api.github.com/repos/Ribesg/Bukkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ribesg/Bukkit/merges","archive_url":"https://api.github.com/repos/Ribesg/Bukkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ribesg/Bukkit/downloads","issues_url":"https://api.github.com/repos/Ribesg/Bukkit/issues{/number}","pulls_url":"https://api.github.com/repos/Ribesg/Bukkit/pulls{/number}","milestones_url":"https://api.github.com/repos/Ribesg/Bukkit/milestones{/number}","notifications_url":"https://api.github.com/repos/Ribesg/Bukkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ribesg/Bukkit/labels{/name}","releases_url":"https://api.github.com/repos/Ribesg/Bukkit/releases{/id}","created_at":"2014-01-06T09:48:01Z","updated_at":"2014-07-17T11:10:47Z","pushed_at":"2014-09-06T22:54:56Z","git_url":"git://github.com/Ribesg/Bukkit.git","ssh_url":"git@github.com:Ribesg/Bukkit.git","clone_url":"https://github.com/Ribesg/Bukkit.git","svn_url":"https://github.com/Ribesg/Bukkit","homepage":"http://bukkit.org","size":5772,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Ribesg/Bukkit/pulls/17"},"html":{"href":"https://github.com/Ribesg/Bukkit/pull/17"},"issue":{"href":"https://api.github.com/repos/Ribesg/Bukkit/issues/17"},"comments":{"href":"https://api.github.com/repos/Ribesg/Bukkit/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/Ribesg/Bukkit/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/Ribesg/Bukkit/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Ribesg/Bukkit/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/Ribesg/Bukkit/statuses/c80cfd77d5447c69355f0f2766b7455f58d81fb4"}}}}