GitHub PullRequestEvent at 2014-10-15 18:27:55
Repository: authlogic
Actor: tiegz
Payload: {"action":"closed","number":421,"pull_request":{"url":"https://api.github.com/repos/binarylogic/authlogic/pulls/421","id":18369081,"html_url":"https://github.com/binarylogic/authlogic/pull/421","diff_url":"https://github.com/binarylogic/authlogic/pull/421.diff","patch_url":"https://github.com/binarylogic/authlogic/pull/421.patch","issue_url":"https://api.github.com/repos/binarylogic/authlogic/issues/421","number":421,"state":"closed","locked":false,"title":"Fix Rails 4.1 test errors","user":{"login":"tiegz","id":5054,"avatar_url":"https://avatars.githubusercontent.com/u/5054?v=2","gravatar_id":"","url":"https://api.github.com/users/tiegz","html_url":"https://github.com/tiegz","followers_url":"https://api.github.com/users/tiegz/followers","following_url":"https://api.github.com/users/tiegz/following{/other_user}","gists_url":"https://api.github.com/users/tiegz/gists{/gist_id}","starred_url":"https://api.github.com/users/tiegz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiegz/subscriptions","organizations_url":"https://api.github.com/users/tiegz/orgs","repos_url":"https://api.github.com/users/tiegz/repos","events_url":"https://api.github.com/users/tiegz/events{/privacy}","received_events_url":"https://api.github.com/users/tiegz/received_events","type":"User","site_admin":false},"body":"### WHAT\r\n\r\nFixing the Rails 4.1 test errors. This is really a bug that affects all Rails versions' tests, but just surfacing in 4.1.\r\n\r\n### WHY\r\n\r\nThere are a few places in the tests where `acts_as_authentic` is called on the `User` test model.\r\n\r\nWhenever `acts_as_authentic` executes, it includes all of its modules into the receiver (eg including the `Authlogic::ActsAsAuthentic::Login` module, which adds login-related validations).\r\n\r\nHence, when you run the full test suite, there are a bunch of duplicate validators on the `User` class.\r\n\r\n### ALTERNATE\r\n\r\nAnother fix would be to just ensure the modules can't be included multiple times, but maybe that's not necessary until someone runs into it in a non-test environment?\r\n\r\n### NOTE\r\n\r\nThere are some other minor test fixes in here too.","created_at":"2014-07-14T19:38:13Z","updated_at":"2014-10-15T18:27:54Z","closed_at":"2014-10-15T18:27:54Z","merged_at":null,"merge_commit_sha":"e4096db96d7dd8401ca42b23d495b1e0ad79f6e1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/binarylogic/authlogic/pulls/421/commits","review_comments_url":"https://api.github.com/repos/binarylogic/authlogic/pulls/421/comments","review_comment_url":"https://api.github.com/repos/binarylogic/authlogic/pulls/comments/{number}","comments_url":"https://api.github.com/repos/binarylogic/authlogic/issues/421/comments","statuses_url":"https://api.github.com/repos/binarylogic/authlogic/statuses/f18f5fa7d30010b60003040fef5181a486295272","head":{"label":"tiegz:fix_rails41_errors","ref":"fix_rails41_errors","sha":"f18f5fa7d30010b60003040fef5181a486295272","user":{"login":"tiegz","id":5054,"avatar_url":"https://avatars.githubusercontent.com/u/5054?v=2","gravatar_id":"","url":"https://api.github.com/users/tiegz","html_url":"https://github.com/tiegz","followers_url":"https://api.github.com/users/tiegz/followers","following_url":"https://api.github.com/users/tiegz/following{/other_user}","gists_url":"https://api.github.com/users/tiegz/gists{/gist_id}","starred_url":"https://api.github.com/users/tiegz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiegz/subscriptions","organizations_url":"https://api.github.com/users/tiegz/orgs","repos_url":"https://api.github.com/users/tiegz/repos","events_url":"https://api.github.com/users/tiegz/events{/privacy}","received_events_url":"https://api.github.com/users/tiegz/received_events","type":"User","site_admin":false},"repo":{"id":2579141,"name":"authlogic","full_name":"tiegz/authlogic","owner":{"login":"tiegz","id":5054,"avatar_url":"https://avatars.githubusercontent.com/u/5054?v=2","gravatar_id":"","url":"https://api.github.com/users/tiegz","html_url":"https://github.com/tiegz","followers_url":"https://api.github.com/users/tiegz/followers","following_url":"https://api.github.com/users/tiegz/following{/other_user}","gists_url":"https://api.github.com/users/tiegz/gists{/gist_id}","starred_url":"https://api.github.com/users/tiegz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiegz/subscriptions","organizations_url":"https://api.github.com/users/tiegz/orgs","repos_url":"https://api.github.com/users/tiegz/repos","events_url":"https://api.github.com/users/tiegz/events{/privacy}","received_events_url":"https://api.github.com/users/tiegz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tiegz/authlogic","description":"A simple model based ruby authentication solution.","fork":true,"url":"https://api.github.com/repos/tiegz/authlogic","forks_url":"https://api.github.com/repos/tiegz/authlogic/forks","keys_url":"https://api.github.com/repos/tiegz/authlogic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tiegz/authlogic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tiegz/authlogic/teams","hooks_url":"https://api.github.com/repos/tiegz/authlogic/hooks","issue_events_url":"https://api.github.com/repos/tiegz/authlogic/issues/events{/number}","events_url":"https://api.github.com/repos/tiegz/authlogic/events","assignees_url":"https://api.github.com/repos/tiegz/authlogic/assignees{/user}","branches_url":"https://api.github.com/repos/tiegz/authlogic/branches{/branch}","tags_url":"https://api.github.com/repos/tiegz/authlogic/tags","blobs_url":"https://api.github.com/repos/tiegz/authlogic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tiegz/authlogic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tiegz/authlogic/git/refs{/sha}","trees_url":"https://api.github.com/repos/tiegz/authlogic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tiegz/authlogic/statuses/{sha}","languages_url":"https://api.github.com/repos/tiegz/authlogic/languages","stargazers_url":"https://api.github.com/repos/tiegz/authlogic/stargazers","contributors_url":"https://api.github.com/repos/tiegz/authlogic/contributors","subscribers_url":"https://api.github.com/repos/tiegz/authlogic/subscribers","subscription_url":"https://api.github.com/repos/tiegz/authlogic/subscription","commits_url":"https://api.github.com/repos/tiegz/authlogic/commits{/sha}","git_commits_url":"https://api.github.com/repos/tiegz/authlogic/git/commits{/sha}","comments_url":"https://api.github.com/repos/tiegz/authlogic/comments{/number}","issue_comment_url":"https://api.github.com/repos/tiegz/authlogic/issues/comments/{number}","contents_url":"https://api.github.com/repos/tiegz/authlogic/contents/{+path}","compare_url":"https://api.github.com/repos/tiegz/authlogic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tiegz/authlogic/merges","archive_url":"https://api.github.com/repos/tiegz/authlogic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tiegz/authlogic/downloads","issues_url":"https://api.github.com/repos/tiegz/authlogic/issues{/number}","pulls_url":"https://api.github.com/repos/tiegz/authlogic/pulls{/number}","milestones_url":"https://api.github.com/repos/tiegz/authlogic/milestones{/number}","notifications_url":"https://api.github.com/repos/tiegz/authlogic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tiegz/authlogic/labels{/name}","releases_url":"https://api.github.com/repos/tiegz/authlogic/releases{/id}","created_at":"2011-10-14T22:01:41Z","updated_at":"2014-07-11T14:08:57Z","pushed_at":"2014-10-09T20:53:51Z","git_url":"git://github.com/tiegz/authlogic.git","ssh_url":"git@github.com:tiegz/authlogic.git","clone_url":"https://github.com/tiegz/authlogic.git","svn_url":"https://github.com/tiegz/authlogic","homepage":"http://rdoc.info/projects/binarylogic/authlogic","size":2217,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"binarylogic:master","ref":"master","sha":"98f88d06d1532f8144ea085159ee53ed1e45c2a9","user":{"login":"binarylogic","id":4136,"avatar_url":"https://avatars.githubusercontent.com/u/4136?v=2","gravatar_id":"","url":"https://api.github.com/users/binarylogic","html_url":"https://github.com/binarylogic","followers_url":"https://api.github.com/users/binarylogic/followers","following_url":"https://api.github.com/users/binarylogic/following{/other_user}","gists_url":"https://api.github.com/users/binarylogic/gists{/gist_id}","starred_url":"https://api.github.com/users/binarylogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binarylogic/subscriptions","organizations_url":"https://api.github.com/users/binarylogic/orgs","repos_url":"https://api.github.com/users/binarylogic/repos","events_url":"https://api.github.com/users/binarylogic/events{/privacy}","received_events_url":"https://api.github.com/users/binarylogic/received_events","type":"Organization","site_admin":false},"repo":{"id":67451,"name":"authlogic","full_name":"binarylogic/authlogic","owner":{"login":"binarylogic","id":4136,"avatar_url":"https://avatars.githubusercontent.com/u/4136?v=2","gravatar_id":"","url":"https://api.github.com/users/binarylogic","html_url":"https://github.com/binarylogic","followers_url":"https://api.github.com/users/binarylogic/followers","following_url":"https://api.github.com/users/binarylogic/following{/other_user}","gists_url":"https://api.github.com/users/binarylogic/gists{/gist_id}","starred_url":"https://api.github.com/users/binarylogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binarylogic/subscriptions","organizations_url":"https://api.github.com/users/binarylogic/orgs","repos_url":"https://api.github.com/users/binarylogic/repos","events_url":"https://api.github.com/users/binarylogic/events{/privacy}","received_events_url":"https://api.github.com/users/binarylogic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/binarylogic/authlogic","description":"A simple ruby authentication solution.","fork":false,"url":"https://api.github.com/repos/binarylogic/authlogic","forks_url":"https://api.github.com/repos/binarylogic/authlogic/forks","keys_url":"https://api.github.com/repos/binarylogic/authlogic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/binarylogic/authlogic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/binarylogic/authlogic/teams","hooks_url":"https://api.github.com/repos/binarylogic/authlogic/hooks","issue_events_url":"https://api.github.com/repos/binarylogic/authlogic/issues/events{/number}","events_url":"https://api.github.com/repos/binarylogic/authlogic/events","assignees_url":"https://api.github.com/repos/binarylogic/authlogic/assignees{/user}","branches_url":"https://api.github.com/repos/binarylogic/authlogic/branches{/branch}","tags_url":"https://api.github.com/repos/binarylogic/authlogic/tags","blobs_url":"https://api.github.com/repos/binarylogic/authlogic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/binarylogic/authlogic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/binarylogic/authlogic/git/refs{/sha}","trees_url":"https://api.github.com/repos/binarylogic/authlogic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/binarylogic/authlogic/statuses/{sha}","languages_url":"https://api.github.com/repos/binarylogic/authlogic/languages","stargazers_url":"https://api.github.com/repos/binarylogic/authlogic/stargazers","contributors_url":"https://api.github.com/repos/binarylogic/authlogic/contributors","subscribers_url":"https://api.github.com/repos/binarylogic/authlogic/subscribers","subscription_url":"https://api.github.com/repos/binarylogic/authlogic/subscription","commits_url":"https://api.github.com/repos/binarylogic/authlogic/commits{/sha}","git_commits_url":"https://api.github.com/repos/binarylogic/authlogic/git/commits{/sha}","comments_url":"https://api.github.com/repos/binarylogic/authlogic/comments{/number}","issue_comment_url":"https://api.github.com/repos/binarylogic/authlogic/issues/comments/{number}","contents_url":"https://api.github.com/repos/binarylogic/authlogic/contents/{+path}","compare_url":"https://api.github.com/repos/binarylogic/authlogic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/binarylogic/authlogic/merges","archive_url":"https://api.github.com/repos/binarylogic/authlogic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/binarylogic/authlogic/downloads","issues_url":"https://api.github.com/repos/binarylogic/authlogic/issues{/number}","pulls_url":"https://api.github.com/repos/binarylogic/authlogic/pulls{/number}","milestones_url":"https://api.github.com/repos/binarylogic/authlogic/milestones{/number}","notifications_url":"https://api.github.com/repos/binarylogic/authlogic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/binarylogic/authlogic/labels{/name}","releases_url":"https://api.github.com/repos/binarylogic/authlogic/releases{/id}","created_at":"2008-10-24T21:13:34Z","updated_at":"2014-10-14T13:22:21Z","pushed_at":"2014-10-15T18:18:24Z","git_url":"git://github.com/binarylogic/authlogic.git","ssh_url":"git@github.com:binarylogic/authlogic.git","clone_url":"https://github.com/binarylogic/authlogic.git","svn_url":"https://github.com/binarylogic/authlogic","homepage":"http://rdoc.info/projects/binarylogic/authlogic","size":4289,"stargazers_count":3577,"watchers_count":3577,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":517,"mirror_url":null,"open_issues_count":170,"forks":517,"open_issues":170,"watchers":3577,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/binarylogic/authlogic/pulls/421"},"html":{"href":"https://github.com/binarylogic/authlogic/pull/421"},"issue":{"href":"https://api.github.com/repos/binarylogic/authlogic/issues/421"},"comments":{"href":"https://api.github.com/repos/binarylogic/authlogic/issues/421/comments"},"review_comments":{"href":"https://api.github.com/repos/binarylogic/authlogic/pulls/421/comments"},"review_comment":{"href":"https://api.github.com/repos/binarylogic/authlogic/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/binarylogic/authlogic/pulls/421/commits"},"statuses":{"href":"https://api.github.com/repos/binarylogic/authlogic/statuses/f18f5fa7d30010b60003040fef5181a486295272"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":5,"review_comments":1,"commits":3,"additions":789,"deletions":595,"changed_files":28}}