GitHub PullRequestEvent at 2014-04-18 14:35:24
Repository: matplotlib
Actor: jbmohler
Payload: {"action":"closed","number":2979,"pull_request":{"url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/2979","id":14731100,"html_url":"https://github.com/matplotlib/matplotlib/pull/2979","diff_url":"https://github.com/matplotlib/matplotlib/pull/2979.diff","patch_url":"https://github.com/matplotlib/matplotlib/pull/2979.patch","issue_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/2979","number":2979,"state":"closed","title":"add 'buttons' parameter in LassoSelector and SpanSelector","user":{"login":"jbmohler","id":1854435,"avatar_url":"https://avatars.githubusercontent.com/u/1854435?","gravatar_id":"b2db4b0b3cbd9a71916c1fd9da69c80f","url":"https://api.github.com/users/jbmohler","html_url":"https://github.com/jbmohler","followers_url":"https://api.github.com/users/jbmohler/followers","following_url":"https://api.github.com/users/jbmohler/following{/other_user}","gists_url":"https://api.github.com/users/jbmohler/gists{/gist_id}","starred_url":"https://api.github.com/users/jbmohler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbmohler/subscriptions","organizations_url":"https://api.github.com/users/jbmohler/orgs","repos_url":"https://api.github.com/users/jbmohler/repos","events_url":"https://api.github.com/users/jbmohler/events{/privacy}","received_events_url":"https://api.github.com/users/jbmohler/received_events","type":"User","site_admin":false},"body":"It seems to me that the RectangleSelector, LassoSelector and SpanSelector are similar and could expose a more similar API.  This PR moves in this direction by adding a 'buttons' parameter in LassoSelector and SpanSelector with semantics identical to the RectangleSelector.\r\n\r\nThe purpose of this PR is to request feedback on the philosophy of the design and the changes.  Currently, I think the changes here don't maintain the backwards compatibility quite as much as it could.  Further actions in this philosophy would be default the line and rect styles in a consistent way for all of them.","created_at":"2014-04-14T17:48:14Z","updated_at":"2014-04-18T14:35:23Z","closed_at":"2014-04-18T14:35:23Z","merged_at":null,"merge_commit_sha":"a40c6ba2ebfc60794202e969f5d42083e1a96d55","assignee":null,"milestone":{"url":"https://api.github.com/repos/matplotlib/matplotlib/milestones/12","labels_url":"https://api.github.com/repos/matplotlib/matplotlib/milestones/12/labels","id":534144,"number":12,"title":"v1.5.x","description":null,"creator":{"login":"tacaswell","id":199813,"avatar_url":"https://avatars.githubusercontent.com/u/199813?","gravatar_id":"8744048060e5931c500d3c9d1ecb997e","url":"https://api.github.com/users/tacaswell","html_url":"https://github.com/tacaswell","followers_url":"https://api.github.com/users/tacaswell/followers","following_url":"https://api.github.com/users/tacaswell/following{/other_user}","gists_url":"https://api.github.com/users/tacaswell/gists{/gist_id}","starred_url":"https://api.github.com/users/tacaswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tacaswell/subscriptions","organizations_url":"https://api.github.com/users/tacaswell/orgs","repos_url":"https://api.github.com/users/tacaswell/repos","events_url":"https://api.github.com/users/tacaswell/events{/privacy}","received_events_url":"https://api.github.com/users/tacaswell/received_events","type":"User","site_admin":false},"open_issues":95,"closed_issues":8,"state":"open","created_at":"2014-01-13T03:21:09Z","updated_at":"2014-04-18T14:35:23Z","due_on":null},"commits_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/2979/commits","review_comments_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/2979/comments","review_comment_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments/{number}","comments_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/2979/comments","statuses_url":"https://api.github.com/repos/matplotlib/matplotlib/statuses/e9d9abfe1dcd059970d6daa13ad1819cf0ede388","head":{"label":"jbmohler:master","ref":"master","sha":"e9d9abfe1dcd059970d6daa13ad1819cf0ede388","user":{"login":"jbmohler","id":1854435,"avatar_url":"https://avatars.githubusercontent.com/u/1854435?","gravatar_id":"b2db4b0b3cbd9a71916c1fd9da69c80f","url":"https://api.github.com/users/jbmohler","html_url":"https://github.com/jbmohler","followers_url":"https://api.github.com/users/jbmohler/followers","following_url":"https://api.github.com/users/jbmohler/following{/other_user}","gists_url":"https://api.github.com/users/jbmohler/gists{/gist_id}","starred_url":"https://api.github.com/users/jbmohler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbmohler/subscriptions","organizations_url":"https://api.github.com/users/jbmohler/orgs","repos_url":"https://api.github.com/users/jbmohler/repos","events_url":"https://api.github.com/users/jbmohler/events{/privacy}","received_events_url":"https://api.github.com/users/jbmohler/received_events","type":"User","site_admin":false},"repo":{"id":18769901,"name":"matplotlib","full_name":"jbmohler/matplotlib","owner":{"login":"jbmohler","id":1854435,"avatar_url":"https://avatars.githubusercontent.com/u/1854435?","gravatar_id":"b2db4b0b3cbd9a71916c1fd9da69c80f","url":"https://api.github.com/users/jbmohler","html_url":"https://github.com/jbmohler","followers_url":"https://api.github.com/users/jbmohler/followers","following_url":"https://api.github.com/users/jbmohler/following{/other_user}","gists_url":"https://api.github.com/users/jbmohler/gists{/gist_id}","starred_url":"https://api.github.com/users/jbmohler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbmohler/subscriptions","organizations_url":"https://api.github.com/users/jbmohler/orgs","repos_url":"https://api.github.com/users/jbmohler/repos","events_url":"https://api.github.com/users/jbmohler/events{/privacy}","received_events_url":"https://api.github.com/users/jbmohler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jbmohler/matplotlib","description":"matplotlib: plotting with Python","fork":true,"url":"https://api.github.com/repos/jbmohler/matplotlib","forks_url":"https://api.github.com/repos/jbmohler/matplotlib/forks","keys_url":"https://api.github.com/repos/jbmohler/matplotlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jbmohler/matplotlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jbmohler/matplotlib/teams","hooks_url":"https://api.github.com/repos/jbmohler/matplotlib/hooks","issue_events_url":"https://api.github.com/repos/jbmohler/matplotlib/issues/events{/number}","events_url":"https://api.github.com/repos/jbmohler/matplotlib/events","assignees_url":"https://api.github.com/repos/jbmohler/matplotlib/assignees{/user}","branches_url":"https://api.github.com/repos/jbmohler/matplotlib/branches{/branch}","tags_url":"https://api.github.com/repos/jbmohler/matplotlib/tags","blobs_url":"https://api.github.com/repos/jbmohler/matplotlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jbmohler/matplotlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jbmohler/matplotlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/jbmohler/matplotlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jbmohler/matplotlib/statuses/{sha}","languages_url":"https://api.github.com/repos/jbmohler/matplotlib/languages","stargazers_url":"https://api.github.com/repos/jbmohler/matplotlib/stargazers","contributors_url":"https://api.github.com/repos/jbmohler/matplotlib/contributors","subscribers_url":"https://api.github.com/repos/jbmohler/matplotlib/subscribers","subscription_url":"https://api.github.com/repos/jbmohler/matplotlib/subscription","commits_url":"https://api.github.com/repos/jbmohler/matplotlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/jbmohler/matplotlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/jbmohler/matplotlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/jbmohler/matplotlib/issues/comments/{number}","contents_url":"https://api.github.com/repos/jbmohler/matplotlib/contents/{+path}","compare_url":"https://api.github.com/repos/jbmohler/matplotlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jbmohler/matplotlib/merges","archive_url":"https://api.github.com/repos/jbmohler/matplotlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jbmohler/matplotlib/downloads","issues_url":"https://api.github.com/repos/jbmohler/matplotlib/issues{/number}","pulls_url":"https://api.github.com/repos/jbmohler/matplotlib/pulls{/number}","milestones_url":"https://api.github.com/repos/jbmohler/matplotlib/milestones{/number}","notifications_url":"https://api.github.com/repos/jbmohler/matplotlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jbmohler/matplotlib/labels{/name}","releases_url":"https://api.github.com/repos/jbmohler/matplotlib/releases{/id}","created_at":"2014-04-14T17:36:11Z","updated_at":"2014-04-18T14:08:42Z","pushed_at":"2014-04-18T14:08:42Z","git_url":"git://github.com/jbmohler/matplotlib.git","ssh_url":"git@github.com:jbmohler/matplotlib.git","clone_url":"https://github.com/jbmohler/matplotlib.git","svn_url":"https://github.com/jbmohler/matplotlib","homepage":"http://matplotlib.org/","size":187701,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"matplotlib:master","ref":"master","sha":"03e60dc875168f98448de7208588a77b1bf63181","user":{"login":"matplotlib","id":215947,"avatar_url":"https://avatars.githubusercontent.com/u/215947?","gravatar_id":"9cb63f8da873ea78bc89d440f9ecb03a","url":"https://api.github.com/users/matplotlib","html_url":"https://github.com/matplotlib","followers_url":"https://api.github.com/users/matplotlib/followers","following_url":"https://api.github.com/users/matplotlib/following{/other_user}","gists_url":"https://api.github.com/users/matplotlib/gists{/gist_id}","starred_url":"https://api.github.com/users/matplotlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matplotlib/subscriptions","organizations_url":"https://api.github.com/users/matplotlib/orgs","repos_url":"https://api.github.com/users/matplotlib/repos","events_url":"https://api.github.com/users/matplotlib/events{/privacy}","received_events_url":"https://api.github.com/users/matplotlib/received_events","type":"Organization","site_admin":false},"repo":{"id":1385122,"name":"matplotlib","full_name":"matplotlib/matplotlib","owner":{"login":"matplotlib","id":215947,"avatar_url":"https://avatars.githubusercontent.com/u/215947?","gravatar_id":"9cb63f8da873ea78bc89d440f9ecb03a","url":"https://api.github.com/users/matplotlib","html_url":"https://github.com/matplotlib","followers_url":"https://api.github.com/users/matplotlib/followers","following_url":"https://api.github.com/users/matplotlib/following{/other_user}","gists_url":"https://api.github.com/users/matplotlib/gists{/gist_id}","starred_url":"https://api.github.com/users/matplotlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matplotlib/subscriptions","organizations_url":"https://api.github.com/users/matplotlib/orgs","repos_url":"https://api.github.com/users/matplotlib/repos","events_url":"https://api.github.com/users/matplotlib/events{/privacy}","received_events_url":"https://api.github.com/users/matplotlib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/matplotlib/matplotlib","description":"matplotlib: plotting with Python","fork":false,"url":"https://api.github.com/repos/matplotlib/matplotlib","forks_url":"https://api.github.com/repos/matplotlib/matplotlib/forks","keys_url":"https://api.github.com/repos/matplotlib/matplotlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matplotlib/matplotlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matplotlib/matplotlib/teams","hooks_url":"https://api.github.com/repos/matplotlib/matplotlib/hooks","issue_events_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/events{/number}","events_url":"https://api.github.com/repos/matplotlib/matplotlib/events","assignees_url":"https://api.github.com/repos/matplotlib/matplotlib/assignees{/user}","branches_url":"https://api.github.com/repos/matplotlib/matplotlib/branches{/branch}","tags_url":"https://api.github.com/repos/matplotlib/matplotlib/tags","blobs_url":"https://api.github.com/repos/matplotlib/matplotlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matplotlib/matplotlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matplotlib/matplotlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/matplotlib/matplotlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matplotlib/matplotlib/statuses/{sha}","languages_url":"https://api.github.com/repos/matplotlib/matplotlib/languages","stargazers_url":"https://api.github.com/repos/matplotlib/matplotlib/stargazers","contributors_url":"https://api.github.com/repos/matplotlib/matplotlib/contributors","subscribers_url":"https://api.github.com/repos/matplotlib/matplotlib/subscribers","subscription_url":"https://api.github.com/repos/matplotlib/matplotlib/subscription","commits_url":"https://api.github.com/repos/matplotlib/matplotlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/matplotlib/matplotlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/matplotlib/matplotlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/comments/{number}","contents_url":"https://api.github.com/repos/matplotlib/matplotlib/contents/{+path}","compare_url":"https://api.github.com/repos/matplotlib/matplotlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matplotlib/matplotlib/merges","archive_url":"https://api.github.com/repos/matplotlib/matplotlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matplotlib/matplotlib/downloads","issues_url":"https://api.github.com/repos/matplotlib/matplotlib/issues{/number}","pulls_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls{/number}","milestones_url":"https://api.github.com/repos/matplotlib/matplotlib/milestones{/number}","notifications_url":"https://api.github.com/repos/matplotlib/matplotlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matplotlib/matplotlib/labels{/name}","releases_url":"https://api.github.com/repos/matplotlib/matplotlib/releases{/id}","created_at":"2011-02-19T03:17:12Z","updated_at":"2014-04-17T19:16:25Z","pushed_at":"2014-04-17T19:16:25Z","git_url":"git://github.com/matplotlib/matplotlib.git","ssh_url":"git@github.com:matplotlib/matplotlib.git","clone_url":"https://github.com/matplotlib/matplotlib.git","svn_url":"https://github.com/matplotlib/matplotlib","homepage":"http://matplotlib.org/","size":216569,"stargazers_count":1472,"watchers_count":1472,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":683,"mirror_url":null,"open_issues_count":353,"forks":683,"open_issues":353,"watchers":1472,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/2979"},"html":{"href":"https://github.com/matplotlib/matplotlib/pull/2979"},"issue":{"href":"https://api.github.com/repos/matplotlib/matplotlib/issues/2979"},"comments":{"href":"https://api.github.com/repos/matplotlib/matplotlib/issues/2979/comments"},"review_comments":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/2979/comments"},"review_comment":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/2979/commits"},"statuses":{"href":"https://api.github.com/repos/matplotlib/matplotlib/statuses/e9d9abfe1dcd059970d6daa13ad1819cf0ede388"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":3,"review_comments":0,"commits":2,"additions":92,"deletions":69,"changed_files":2}}