GitHub PullRequestEvent at 2014-03-16 15:23:30
Repository: FXForms
Actor: nicklockwood
Payload: {"action":"closed","number":7,"pull_request":{"url":"https://api.github.com/repos/nicklockwood/FXForms/pulls/7","id":13411897,"html_url":"https://github.com/nicklockwood/FXForms/pull/7","diff_url":"https://github.com/nicklockwood/FXForms/pull/7.diff","patch_url":"https://github.com/nicklockwood/FXForms/pull/7.patch","issue_url":"https://api.github.com/repos/nicklockwood/FXForms/issues/7","number":7,"state":"closed","title":"Add FXFormFieldValueTransformer option","user":{"login":"bartvandendriessche","id":58052,"avatar_url":"https://gravatar.com/avatar/c9a6862c54191c2c9cfc389b354ddb37?d=https%3A%2F%2Fidenticons.github.com%2Ff18ce99435c80c880d00ef40ffc6bacb.png&r=x","gravatar_id":"c9a6862c54191c2c9cfc389b354ddb37","url":"https://api.github.com/users/bartvandendriessche","html_url":"https://github.com/bartvandendriessche","followers_url":"https://api.github.com/users/bartvandendriessche/followers","following_url":"https://api.github.com/users/bartvandendriessche/following{/other_user}","gists_url":"https://api.github.com/users/bartvandendriessche/gists{/gist_id}","starred_url":"https://api.github.com/users/bartvandendriessche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartvandendriessche/subscriptions","organizations_url":"https://api.github.com/users/bartvandendriessche/orgs","repos_url":"https://api.github.com/users/bartvandendriessche/repos","events_url":"https://api.github.com/users/bartvandendriessche/events{/privacy}","received_events_url":"https://api.github.com/users/bartvandendriessche/received_events","type":"User","site_admin":false},"body":"This adds a `FXFormFieldValueTransformer` option.\r\n\r\nThis makes it a bit easier to work with string enums, such as e.g. locals.\r\n\r\nI have a `Customer` form which has a `region` field. My supported regions are e.g.:\r\n\r\n`@[@\"BE-VLG\", @\"BE-BRU\", @\"BE-WAL\", @\"NL\", @\"DE\", @\"FR\", @\"LU\"]`\r\n\r\nBut I would like to show them as:\r\n\r\n`@[@\"Flanders\", @\"Brussels\", @\"Wallonia\", @\"Netherlands\", @\"Germany\", @\"France\", @\"Luxemburg\"]`\r\n\r\nWith this patch, I can define the region field as follows:\r\n\r\n```Objective-C\r\n@{\r\n    FXFormFieldKey: @\"region\",\r\n    FXFormFieldTitle: NSLocalizedString(@\"Region\", nil),\r\n    FXFormFieldOptions: @[@\"BE-VLG\", @\"BE-BRU\", @\"BE-WAL\", @\"NL\", @\"DE\", @\"FR\", @\"LU\"],\r\n    FXFormFieldValueTransformer: [NSValueTransformer valueTransformerForName:ISO33612ValueTransformerName],\r\n}\r\n```\r\n\r\nAs a side-note, I'm wondering if you'd be interested in allowing `FXOptionsForm`s to work with a datasource. I think it would be an awesome option to have for complexer option forms.\r\n\r\nIn my region example, it would allow me to group `Flanders`, `Brussels` and `Wallonia` under the `Belgium section`.\r\n","created_at":"2014-03-11T09:35:02Z","updated_at":"2014-03-16T15:23:28Z","closed_at":"2014-03-16T15:23:28Z","merged_at":"2014-03-16T15:23:28Z","merge_commit_sha":"d58173b1d7283ce89ab36e49fdc6e73eac3088ad","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nicklockwood/FXForms/pulls/7/commits","review_comments_url":"https://api.github.com/repos/nicklockwood/FXForms/pulls/7/comments","review_comment_url":"https://api.github.com/repos/nicklockwood/FXForms/pulls/comments/{number}","comments_url":"https://api.github.com/repos/nicklockwood/FXForms/issues/7/comments","statuses_url":"https://api.github.com/repos/nicklockwood/FXForms/statuses/24fe17d31c636cad6cadd8c2ee7e2051aa460be6","head":{"label":"bartvandendriessche:feature/FXFormFieldValueTransformer","ref":"feature/FXFormFieldValueTransformer","sha":"24fe17d31c636cad6cadd8c2ee7e2051aa460be6","user":{"login":"bartvandendriessche","id":58052,"avatar_url":"https://gravatar.com/avatar/c9a6862c54191c2c9cfc389b354ddb37?d=https%3A%2F%2Fidenticons.github.com%2Ff18ce99435c80c880d00ef40ffc6bacb.png&r=x","gravatar_id":"c9a6862c54191c2c9cfc389b354ddb37","url":"https://api.github.com/users/bartvandendriessche","html_url":"https://github.com/bartvandendriessche","followers_url":"https://api.github.com/users/bartvandendriessche/followers","following_url":"https://api.github.com/users/bartvandendriessche/following{/other_user}","gists_url":"https://api.github.com/users/bartvandendriessche/gists{/gist_id}","starred_url":"https://api.github.com/users/bartvandendriessche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartvandendriessche/subscriptions","organizations_url":"https://api.github.com/users/bartvandendriessche/orgs","repos_url":"https://api.github.com/users/bartvandendriessche/repos","events_url":"https://api.github.com/users/bartvandendriessche/events{/privacy}","received_events_url":"https://api.github.com/users/bartvandendriessche/received_events","type":"User","site_admin":false},"repo":{"id":17622854,"name":"FXForms","full_name":"bartvandendriessche/FXForms","owner":{"login":"bartvandendriessche","id":58052,"avatar_url":"https://gravatar.com/avatar/c9a6862c54191c2c9cfc389b354ddb37?d=https%3A%2F%2Fidenticons.github.com%2Ff18ce99435c80c880d00ef40ffc6bacb.png&r=x","gravatar_id":"c9a6862c54191c2c9cfc389b354ddb37","url":"https://api.github.com/users/bartvandendriessche","html_url":"https://github.com/bartvandendriessche","followers_url":"https://api.github.com/users/bartvandendriessche/followers","following_url":"https://api.github.com/users/bartvandendriessche/following{/other_user}","gists_url":"https://api.github.com/users/bartvandendriessche/gists{/gist_id}","starred_url":"https://api.github.com/users/bartvandendriessche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartvandendriessche/subscriptions","organizations_url":"https://api.github.com/users/bartvandendriessche/orgs","repos_url":"https://api.github.com/users/bartvandendriessche/repos","events_url":"https://api.github.com/users/bartvandendriessche/events{/privacy}","received_events_url":"https://api.github.com/users/bartvandendriessche/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bartvandendriessche/FXForms","description":" FXForms is an Objective-C library for easily creating table-based forms on iOS. It is ideal for settings pages, or user data entry tasks.","fork":true,"url":"https://api.github.com/repos/bartvandendriessche/FXForms","forks_url":"https://api.github.com/repos/bartvandendriessche/FXForms/forks","keys_url":"https://api.github.com/repos/bartvandendriessche/FXForms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bartvandendriessche/FXForms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bartvandendriessche/FXForms/teams","hooks_url":"https://api.github.com/repos/bartvandendriessche/FXForms/hooks","issue_events_url":"https://api.github.com/repos/bartvandendriessche/FXForms/issues/events{/number}","events_url":"https://api.github.com/repos/bartvandendriessche/FXForms/events","assignees_url":"https://api.github.com/repos/bartvandendriessche/FXForms/assignees{/user}","branches_url":"https://api.github.com/repos/bartvandendriessche/FXForms/branches{/branch}","tags_url":"https://api.github.com/repos/bartvandendriessche/FXForms/tags","blobs_url":"https://api.github.com/repos/bartvandendriessche/FXForms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bartvandendriessche/FXForms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bartvandendriessche/FXForms/git/refs{/sha}","trees_url":"https://api.github.com/repos/bartvandendriessche/FXForms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bartvandendriessche/FXForms/statuses/{sha}","languages_url":"https://api.github.com/repos/bartvandendriessche/FXForms/languages","stargazers_url":"https://api.github.com/repos/bartvandendriessche/FXForms/stargazers","contributors_url":"https://api.github.com/repos/bartvandendriessche/FXForms/contributors","subscribers_url":"https://api.github.com/repos/bartvandendriessche/FXForms/subscribers","subscription_url":"https://api.github.com/repos/bartvandendriessche/FXForms/subscription","commits_url":"https://api.github.com/repos/bartvandendriessche/FXForms/commits{/sha}","git_commits_url":"https://api.github.com/repos/bartvandendriessche/FXForms/git/commits{/sha}","comments_url":"https://api.github.com/repos/bartvandendriessche/FXForms/comments{/number}","issue_comment_url":"https://api.github.com/repos/bartvandendriessche/FXForms/issues/comments/{number}","contents_url":"https://api.github.com/repos/bartvandendriessche/FXForms/contents/{+path}","compare_url":"https://api.github.com/repos/bartvandendriessche/FXForms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bartvandendriessche/FXForms/merges","archive_url":"https://api.github.com/repos/bartvandendriessche/FXForms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bartvandendriessche/FXForms/downloads","issues_url":"https://api.github.com/repos/bartvandendriessche/FXForms/issues{/number}","pulls_url":"https://api.github.com/repos/bartvandendriessche/FXForms/pulls{/number}","milestones_url":"https://api.github.com/repos/bartvandendriessche/FXForms/milestones{/number}","notifications_url":"https://api.github.com/repos/bartvandendriessche/FXForms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bartvandendriessche/FXForms/labels{/name}","releases_url":"https://api.github.com/repos/bartvandendriessche/FXForms/releases{/id}","created_at":"2014-03-11T08:11:02Z","updated_at":"2014-03-16T15:23:28Z","pushed_at":"2014-03-12T19:25:00Z","git_url":"git://github.com/bartvandendriessche/FXForms.git","ssh_url":"git@github.com:bartvandendriessche/FXForms.git","clone_url":"https://github.com/bartvandendriessche/FXForms.git","svn_url":"https://github.com/bartvandendriessche/FXForms","homepage":null,"size":257,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"nicklockwood:master","ref":"master","sha":"1f3d6826849a448dd29cce8543ea995890e5f7b6","user":{"login":"nicklockwood","id":546885,"avatar_url":"https://gravatar.com/avatar/cbf84770b8cf76a258ffe446f177c7f9?d=https%3A%2F%2Fidenticons.github.com%2F9eff3610c614b2e72c83761c8f5366f8.png&r=x","gravatar_id":"cbf84770b8cf76a258ffe446f177c7f9","url":"https://api.github.com/users/nicklockwood","html_url":"https://github.com/nicklockwood","followers_url":"https://api.github.com/users/nicklockwood/followers","following_url":"https://api.github.com/users/nicklockwood/following{/other_user}","gists_url":"https://api.github.com/users/nicklockwood/gists{/gist_id}","starred_url":"https://api.github.com/users/nicklockwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicklockwood/subscriptions","organizations_url":"https://api.github.com/users/nicklockwood/orgs","repos_url":"https://api.github.com/users/nicklockwood/repos","events_url":"https://api.github.com/users/nicklockwood/events{/privacy}","received_events_url":"https://api.github.com/users/nicklockwood/received_events","type":"User","site_admin":false},"repo":{"id":17406308,"name":"FXForms","full_name":"nicklockwood/FXForms","owner":{"login":"nicklockwood","id":546885,"avatar_url":"https://gravatar.com/avatar/cbf84770b8cf76a258ffe446f177c7f9?d=https%3A%2F%2Fidenticons.github.com%2F9eff3610c614b2e72c83761c8f5366f8.png&r=x","gravatar_id":"cbf84770b8cf76a258ffe446f177c7f9","url":"https://api.github.com/users/nicklockwood","html_url":"https://github.com/nicklockwood","followers_url":"https://api.github.com/users/nicklockwood/followers","following_url":"https://api.github.com/users/nicklockwood/following{/other_user}","gists_url":"https://api.github.com/users/nicklockwood/gists{/gist_id}","starred_url":"https://api.github.com/users/nicklockwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicklockwood/subscriptions","organizations_url":"https://api.github.com/users/nicklockwood/orgs","repos_url":"https://api.github.com/users/nicklockwood/repos","events_url":"https://api.github.com/users/nicklockwood/events{/privacy}","received_events_url":"https://api.github.com/users/nicklockwood/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nicklockwood/FXForms","description":" FXForms is an Objective-C library for easily creating table-based forms on iOS. It is ideal for settings pages, or user data entry tasks.","fork":false,"url":"https://api.github.com/repos/nicklockwood/FXForms","forks_url":"https://api.github.com/repos/nicklockwood/FXForms/forks","keys_url":"https://api.github.com/repos/nicklockwood/FXForms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nicklockwood/FXForms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nicklockwood/FXForms/teams","hooks_url":"https://api.github.com/repos/nicklockwood/FXForms/hooks","issue_events_url":"https://api.github.com/repos/nicklockwood/FXForms/issues/events{/number}","events_url":"https://api.github.com/repos/nicklockwood/FXForms/events","assignees_url":"https://api.github.com/repos/nicklockwood/FXForms/assignees{/user}","branches_url":"https://api.github.com/repos/nicklockwood/FXForms/branches{/branch}","tags_url":"https://api.github.com/repos/nicklockwood/FXForms/tags","blobs_url":"https://api.github.com/repos/nicklockwood/FXForms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nicklockwood/FXForms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nicklockwood/FXForms/git/refs{/sha}","trees_url":"https://api.github.com/repos/nicklockwood/FXForms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nicklockwood/FXForms/statuses/{sha}","languages_url":"https://api.github.com/repos/nicklockwood/FXForms/languages","stargazers_url":"https://api.github.com/repos/nicklockwood/FXForms/stargazers","contributors_url":"https://api.github.com/repos/nicklockwood/FXForms/contributors","subscribers_url":"https://api.github.com/repos/nicklockwood/FXForms/subscribers","subscription_url":"https://api.github.com/repos/nicklockwood/FXForms/subscription","commits_url":"https://api.github.com/repos/nicklockwood/FXForms/commits{/sha}","git_commits_url":"https://api.github.com/repos/nicklockwood/FXForms/git/commits{/sha}","comments_url":"https://api.github.com/repos/nicklockwood/FXForms/comments{/number}","issue_comment_url":"https://api.github.com/repos/nicklockwood/FXForms/issues/comments/{number}","contents_url":"https://api.github.com/repos/nicklockwood/FXForms/contents/{+path}","compare_url":"https://api.github.com/repos/nicklockwood/FXForms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nicklockwood/FXForms/merges","archive_url":"https://api.github.com/repos/nicklockwood/FXForms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nicklockwood/FXForms/downloads","issues_url":"https://api.github.com/repos/nicklockwood/FXForms/issues{/number}","pulls_url":"https://api.github.com/repos/nicklockwood/FXForms/pulls{/number}","milestones_url":"https://api.github.com/repos/nicklockwood/FXForms/milestones{/number}","notifications_url":"https://api.github.com/repos/nicklockwood/FXForms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nicklockwood/FXForms/labels{/name}","releases_url":"https://api.github.com/repos/nicklockwood/FXForms/releases{/id}","created_at":"2014-03-04T15:12:08Z","updated_at":"2014-03-16T15:23:29Z","pushed_at":"2014-03-16T15:23:29Z","git_url":"git://github.com/nicklockwood/FXForms.git","ssh_url":"git@github.com:nicklockwood/FXForms.git","clone_url":"https://github.com/nicklockwood/FXForms.git","svn_url":"https://github.com/nicklockwood/FXForms","homepage":null,"size":389,"stargazers_count":779,"watchers_count":779,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":34,"mirror_url":null,"open_issues_count":4,"forks":34,"open_issues":4,"watchers":779,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nicklockwood/FXForms/pulls/7"},"html":{"href":"https://github.com/nicklockwood/FXForms/pull/7"},"issue":{"href":"https://api.github.com/repos/nicklockwood/FXForms/issues/7"},"comments":{"href":"https://api.github.com/repos/nicklockwood/FXForms/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/nicklockwood/FXForms/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/nicklockwood/FXForms/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/nicklockwood/FXForms/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/nicklockwood/FXForms/statuses/24fe17d31c636cad6cadd8c2ee7e2051aa460be6"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"nicklockwood","id":546885,"avatar_url":"https://gravatar.com/avatar/cbf84770b8cf76a258ffe446f177c7f9?d=https%3A%2F%2Fidenticons.github.com%2F9eff3610c614b2e72c83761c8f5366f8.png&r=x","gravatar_id":"cbf84770b8cf76a258ffe446f177c7f9","url":"https://api.github.com/users/nicklockwood","html_url":"https://github.com/nicklockwood","followers_url":"https://api.github.com/users/nicklockwood/followers","following_url":"https://api.github.com/users/nicklockwood/following{/other_user}","gists_url":"https://api.github.com/users/nicklockwood/gists{/gist_id}","starred_url":"https://api.github.com/users/nicklockwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicklockwood/subscriptions","organizations_url":"https://api.github.com/users/nicklockwood/orgs","repos_url":"https://api.github.com/users/nicklockwood/repos","events_url":"https://api.github.com/users/nicklockwood/events{/privacy}","received_events_url":"https://api.github.com/users/nicklockwood/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":1,"additions":11,"deletions":1,"changed_files":2}}