GitHub PushEvent at 2014-06-11 22:43:55
Repository: reviewboard
Actor: davidt
Payload: {"shas":[["9a0085b147dc842bb17524c1206b4bd65934eed3","a3e5bf1e23f9b398fd796b3f030b30fdb8b825f9@chipx86.com","Fix the reply draft banner sticking around after a second publish.\n\nPublishing a reply to a comment and then following it up with a second\nreply would result in the reply banner sticking around, acting as if the\npublish hadn't gone through.\n\nThis happened because signal handlers for the \"publishing\" and\n\"destroyed\" events were registered twice on the first ReviewReply, which\nwould cause the state to mess up. We only really needed to register\nthese once.\n\nReviewed at https://reviews.reviewboard.org/r/5964/","Christian Hammond",true],["260619e2530f6ca7d1ff7f4eb38e5849b61a4087","c4a40333d2e70b3fcac4e7cd05d0e9037471cc26@gmail.com","Do a better job of escaping text in commentcounts tag.\n\nIf a user set their full name to include </script>, they could cause some\nproblems. Most of this was fixed in Djblets 0.7.30 and 0.8.3, but the\ncommentcounts tag in Review Board 1.7.x didn't use json_dumps, and therefore\nstill had the problem.\n\nThis change adds some more escaping for different parts of the commentcounts\nstructure that gets serialized.\n\nTesting done:\n* Tested the view_diff.html template.\n* Ran unit tests\n\nReviewed at https://reviews.reviewboard.org/r/5955/","David Trowbridge",false],["2ced9f8286cc0cf974a594729fab3a0b73d60d46","c4a40333d2e70b3fcac4e7cd05d0e9037471cc26@gmail.com","Add draft release notes for 1.7.26\n\nThis adds draft release notes for the bug fixes, security fixes, and one new\nfeature since 1.7.25.\n\nTesting done: Built HTML docs.\n\nReviewed at https://reviews.reviewboard.org/r/5956/","David Trowbridge",false],["c910c77e1d93c1343720e1c69e2b18804fa2a33c","a3e5bf1e23f9b398fd796b3f030b30fdb8b825f9@chipx86.com","Require Djblets 0.7.30.\n\nThis contains security fixes needed for json_dumps and gravatars.","Christian Hammond",false],["a91a98cf7d139be42a18615cb30bc694cf927a62","a3e5bf1e23f9b398fd796b3f030b30fdb8b825f9@chipx86.com","Release Review Board 1.7.26.","Christian Hammond",false],["195aba462c53ce287e9b88af640f4c46c1537f6b","c4a40333d2e70b3fcac4e7cd05d0e9037471cc26@gmail.com","Escape some more usernames and real names.\n\nThis change escapes a few more instances of usernames and real names which get\ndumped into json code that gets executed.\n\nTesting done: Ran unit tests.\n\nReviewed at https://reviews.reviewboard.org/r/5968/","David Trowbridge",false],["a6046191522525cd7395a61f4ce4905965be6cd9","a3e5bf1e23f9b398fd796b3f030b30fdb8b825f9@chipx86.com","Merge branch 'release-1.7.x' into release-2.0.x","Christian Hammond",true],["0971b25bd55d87f57983022ee55bcafeb665ae31","ce547a98b2631aa2d77a4879bbd4113e9564a44b@gmail.com","Retry fetching a file using the base commit id if the original rev fails\n\nWhen developing with Mercurial, a common workflow is to be working on a series\nof patches at any one time, and push/pop them as required. So, \"hg log\" might\nlist something like:\n\n5 qtip [mq] patch3\n4 [mq] patch2\n3 [mq] patch1\n2 qparent second checkin\n1 first checkin\n\nWhen creating a review request, 'rbt post qtip' creates two diffs: from 2-4\n(the parent diff) and 4-5 (diff in review). The problem occurs when a file is\nchanged in patch3 that's not in any of the previous patches. In this case, the\ndiff in review is relative to changeset 4, but \"hg cat -r 4 path/to/a/file\"\nfails because the file isn't in the parent diff.\n\nWork around this problem by trying to get a file from the base commit id if\nfetching it via the revision recorded in the diff fails.\n\nTesting Done:\nPushed 4 patches and ran 'rbt post qtip'; verified that the diff viewer showed\nall of the changes.\n\nReviewed at https://reviews.reviewboard.org/r/5965/","Bruce Cran",true]],"size":8,"ref":"refs/heads/release-2.0.x","head":"0971b25bd55d87f57983022ee55bcafeb665ae31"}