GitHub PullRequestEvent at 2014-03-24 19:13:09
Repository: st
Actor: isaacs
Payload: {"action":"closed","number":36,"pull_request":{"url":"https://api.github.com/repos/isaacs/st/pulls/36","id":13243819,"html_url":"https://github.com/isaacs/st/pull/36","diff_url":"https://github.com/isaacs/st/pull/36.diff","patch_url":"https://github.com/isaacs/st/pull/36.patch","issue_url":"https://api.github.com/repos/isaacs/st/issues/36","number":36,"state":"closed","title":"Leverage browser caching by specifying max-age","user":{"login":"icflorescu","id":581999,"avatar_url":"https://avatars.githubusercontent.com/u/581999?","gravatar_id":"886217404dd00de750a06897b89c1091","url":"https://api.github.com/users/icflorescu","html_url":"https://github.com/icflorescu","followers_url":"https://api.github.com/users/icflorescu/followers","following_url":"https://api.github.com/users/icflorescu/following{/other_user}","gists_url":"https://api.github.com/users/icflorescu/gists{/gist_id}","starred_url":"https://api.github.com/users/icflorescu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icflorescu/subscriptions","organizations_url":"https://api.github.com/users/icflorescu/orgs","repos_url":"https://api.github.com/users/icflorescu/repos","events_url":"https://api.github.com/users/icflorescu/events{/privacy}","received_events_url":"https://api.github.com/users/icflorescu/received_events","type":"User","site_admin":false},"body":"I've noticed that adding a `max-age` value to `cache-control` header results in a much better real-life behaviour and yields a better results in speed test analysing tools such as Google's [PageSpeed Insights](https://developers.google.com/speed/pagespeed/insights/) or [Pingdom Tools](http://tools.pingdom.com/fpt/).\r\n\r\nEven though requests to cached resources are quickly responded with `304`, adding a `max-age` value results in **less requests** being made to the server.\r\n\r\nIdeally we would need to have a separate `browser.axAge` cache option, but it somehow seems logical to assimilate it with `content.maxAge`...\r\n\r\nWhat do you think?","created_at":"2014-03-06T02:14:24Z","updated_at":"2014-03-24T19:13:09Z","closed_at":"2014-03-24T19:13:09Z","merged_at":null,"merge_commit_sha":"712f1275f82daeca47ccebdd6d57e3d925ba7c30","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/isaacs/st/pulls/36/commits","review_comments_url":"https://api.github.com/repos/isaacs/st/pulls/36/comments","review_comment_url":"https://api.github.com/repos/isaacs/st/pulls/comments/{number}","comments_url":"https://api.github.com/repos/isaacs/st/issues/36/comments","statuses_url":"https://api.github.com/repos/isaacs/st/statuses/7b92740e13312bd797fbd6edb77475b824e5857e","head":{"label":"icflorescu:master","ref":"master","sha":"7b92740e13312bd797fbd6edb77475b824e5857e","user":{"login":"icflorescu","id":581999,"avatar_url":"https://avatars.githubusercontent.com/u/581999?","gravatar_id":"886217404dd00de750a06897b89c1091","url":"https://api.github.com/users/icflorescu","html_url":"https://github.com/icflorescu","followers_url":"https://api.github.com/users/icflorescu/followers","following_url":"https://api.github.com/users/icflorescu/following{/other_user}","gists_url":"https://api.github.com/users/icflorescu/gists{/gist_id}","starred_url":"https://api.github.com/users/icflorescu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icflorescu/subscriptions","organizations_url":"https://api.github.com/users/icflorescu/orgs","repos_url":"https://api.github.com/users/icflorescu/repos","events_url":"https://api.github.com/users/icflorescu/events{/privacy}","received_events_url":"https://api.github.com/users/icflorescu/received_events","type":"User","site_admin":false},"repo":{"id":17461728,"name":"st","full_name":"icflorescu/st","owner":{"login":"icflorescu","id":581999,"avatar_url":"https://avatars.githubusercontent.com/u/581999?","gravatar_id":"886217404dd00de750a06897b89c1091","url":"https://api.github.com/users/icflorescu","html_url":"https://github.com/icflorescu","followers_url":"https://api.github.com/users/icflorescu/followers","following_url":"https://api.github.com/users/icflorescu/following{/other_user}","gists_url":"https://api.github.com/users/icflorescu/gists{/gist_id}","starred_url":"https://api.github.com/users/icflorescu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icflorescu/subscriptions","organizations_url":"https://api.github.com/users/icflorescu/orgs","repos_url":"https://api.github.com/users/icflorescu/repos","events_url":"https://api.github.com/users/icflorescu/events{/privacy}","received_events_url":"https://api.github.com/users/icflorescu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/icflorescu/st","description":"A node module for serving static files.  Does etags, caching, etc. ","fork":true,"url":"https://api.github.com/repos/icflorescu/st","forks_url":"https://api.github.com/repos/icflorescu/st/forks","keys_url":"https://api.github.com/repos/icflorescu/st/keys{/key_id}","collaborators_url":"https://api.github.com/repos/icflorescu/st/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/icflorescu/st/teams","hooks_url":"https://api.github.com/repos/icflorescu/st/hooks","issue_events_url":"https://api.github.com/repos/icflorescu/st/issues/events{/number}","events_url":"https://api.github.com/repos/icflorescu/st/events","assignees_url":"https://api.github.com/repos/icflorescu/st/assignees{/user}","branches_url":"https://api.github.com/repos/icflorescu/st/branches{/branch}","tags_url":"https://api.github.com/repos/icflorescu/st/tags","blobs_url":"https://api.github.com/repos/icflorescu/st/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/icflorescu/st/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/icflorescu/st/git/refs{/sha}","trees_url":"https://api.github.com/repos/icflorescu/st/git/trees{/sha}","statuses_url":"https://api.github.com/repos/icflorescu/st/statuses/{sha}","languages_url":"https://api.github.com/repos/icflorescu/st/languages","stargazers_url":"https://api.github.com/repos/icflorescu/st/stargazers","contributors_url":"https://api.github.com/repos/icflorescu/st/contributors","subscribers_url":"https://api.github.com/repos/icflorescu/st/subscribers","subscription_url":"https://api.github.com/repos/icflorescu/st/subscription","commits_url":"https://api.github.com/repos/icflorescu/st/commits{/sha}","git_commits_url":"https://api.github.com/repos/icflorescu/st/git/commits{/sha}","comments_url":"https://api.github.com/repos/icflorescu/st/comments{/number}","issue_comment_url":"https://api.github.com/repos/icflorescu/st/issues/comments/{number}","contents_url":"https://api.github.com/repos/icflorescu/st/contents/{+path}","compare_url":"https://api.github.com/repos/icflorescu/st/compare/{base}...{head}","merges_url":"https://api.github.com/repos/icflorescu/st/merges","archive_url":"https://api.github.com/repos/icflorescu/st/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/icflorescu/st/downloads","issues_url":"https://api.github.com/repos/icflorescu/st/issues{/number}","pulls_url":"https://api.github.com/repos/icflorescu/st/pulls{/number}","milestones_url":"https://api.github.com/repos/icflorescu/st/milestones{/number}","notifications_url":"https://api.github.com/repos/icflorescu/st/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/icflorescu/st/labels{/name}","releases_url":"https://api.github.com/repos/icflorescu/st/releases{/id}","created_at":"2014-03-06T01:13:55Z","updated_at":"2014-03-06T02:14:24Z","pushed_at":"2014-03-06T01:35:10Z","git_url":"git://github.com/icflorescu/st.git","ssh_url":"git@github.com:icflorescu/st.git","clone_url":"https://github.com/icflorescu/st.git","svn_url":"https://github.com/icflorescu/st","homepage":null,"size":181,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"isaacs:master","ref":"master","sha":"3ef0174292f0e0bf0679be06d6dd812b7af1f0fc","user":{"login":"isaacs","id":9287,"avatar_url":"https://avatars.githubusercontent.com/u/9287?","gravatar_id":"73a2b24daecb976af81e010b7a3ce3c6","url":"https://api.github.com/users/isaacs","html_url":"https://github.com/isaacs","followers_url":"https://api.github.com/users/isaacs/followers","following_url":"https://api.github.com/users/isaacs/following{/other_user}","gists_url":"https://api.github.com/users/isaacs/gists{/gist_id}","starred_url":"https://api.github.com/users/isaacs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaacs/subscriptions","organizations_url":"https://api.github.com/users/isaacs/orgs","repos_url":"https://api.github.com/users/isaacs/repos","events_url":"https://api.github.com/users/isaacs/events{/privacy}","received_events_url":"https://api.github.com/users/isaacs/received_events","type":"User","site_admin":false},"repo":{"id":5363427,"name":"st","full_name":"isaacs/st","owner":{"login":"isaacs","id":9287,"avatar_url":"https://avatars.githubusercontent.com/u/9287?","gravatar_id":"73a2b24daecb976af81e010b7a3ce3c6","url":"https://api.github.com/users/isaacs","html_url":"https://github.com/isaacs","followers_url":"https://api.github.com/users/isaacs/followers","following_url":"https://api.github.com/users/isaacs/following{/other_user}","gists_url":"https://api.github.com/users/isaacs/gists{/gist_id}","starred_url":"https://api.github.com/users/isaacs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaacs/subscriptions","organizations_url":"https://api.github.com/users/isaacs/orgs","repos_url":"https://api.github.com/users/isaacs/repos","events_url":"https://api.github.com/users/isaacs/events{/privacy}","received_events_url":"https://api.github.com/users/isaacs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/isaacs/st","description":"A node module for serving static files.  Does etags, caching, etc. ","fork":false,"url":"https://api.github.com/repos/isaacs/st","forks_url":"https://api.github.com/repos/isaacs/st/forks","keys_url":"https://api.github.com/repos/isaacs/st/keys{/key_id}","collaborators_url":"https://api.github.com/repos/isaacs/st/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/isaacs/st/teams","hooks_url":"https://api.github.com/repos/isaacs/st/hooks","issue_events_url":"https://api.github.com/repos/isaacs/st/issues/events{/number}","events_url":"https://api.github.com/repos/isaacs/st/events","assignees_url":"https://api.github.com/repos/isaacs/st/assignees{/user}","branches_url":"https://api.github.com/repos/isaacs/st/branches{/branch}","tags_url":"https://api.github.com/repos/isaacs/st/tags","blobs_url":"https://api.github.com/repos/isaacs/st/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/isaacs/st/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/isaacs/st/git/refs{/sha}","trees_url":"https://api.github.com/repos/isaacs/st/git/trees{/sha}","statuses_url":"https://api.github.com/repos/isaacs/st/statuses/{sha}","languages_url":"https://api.github.com/repos/isaacs/st/languages","stargazers_url":"https://api.github.com/repos/isaacs/st/stargazers","contributors_url":"https://api.github.com/repos/isaacs/st/contributors","subscribers_url":"https://api.github.com/repos/isaacs/st/subscribers","subscription_url":"https://api.github.com/repos/isaacs/st/subscription","commits_url":"https://api.github.com/repos/isaacs/st/commits{/sha}","git_commits_url":"https://api.github.com/repos/isaacs/st/git/commits{/sha}","comments_url":"https://api.github.com/repos/isaacs/st/comments{/number}","issue_comment_url":"https://api.github.com/repos/isaacs/st/issues/comments/{number}","contents_url":"https://api.github.com/repos/isaacs/st/contents/{+path}","compare_url":"https://api.github.com/repos/isaacs/st/compare/{base}...{head}","merges_url":"https://api.github.com/repos/isaacs/st/merges","archive_url":"https://api.github.com/repos/isaacs/st/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/isaacs/st/downloads","issues_url":"https://api.github.com/repos/isaacs/st/issues{/number}","pulls_url":"https://api.github.com/repos/isaacs/st/pulls{/number}","milestones_url":"https://api.github.com/repos/isaacs/st/milestones{/number}","notifications_url":"https://api.github.com/repos/isaacs/st/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/isaacs/st/labels{/name}","releases_url":"https://api.github.com/repos/isaacs/st/releases{/id}","created_at":"2012-08-10T01:09:46Z","updated_at":"2014-03-24T19:12:46Z","pushed_at":"2014-03-24T19:12:48Z","git_url":"git://github.com/isaacs/st.git","ssh_url":"git@github.com:isaacs/st.git","clone_url":"https://github.com/isaacs/st.git","svn_url":"https://github.com/isaacs/st","homepage":null,"size":530,"stargazers_count":151,"watchers_count":151,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":23,"mirror_url":null,"open_issues_count":6,"forks":23,"open_issues":6,"watchers":151,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/isaacs/st/pulls/36"},"html":{"href":"https://github.com/isaacs/st/pull/36"},"issue":{"href":"https://api.github.com/repos/isaacs/st/issues/36"},"comments":{"href":"https://api.github.com/repos/isaacs/st/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/isaacs/st/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/isaacs/st/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/isaacs/st/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/isaacs/st/statuses/7b92740e13312bd797fbd6edb77475b824e5857e"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":6,"review_comments":0,"commits":1,"additions":3,"deletions":1,"changed_files":1}}