GitHub PullRequestReviewCommentEvent at 2014-06-17 09:32:18
Repository: juju
Actor: jameinel
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/juju/juju/pulls/comments/13849936","id":13849936,"diff_hunk":"@@ -593,6 +593,13 @@ func (c *Client) DestroyEnvironment() error {\n \treturn c.call(\"DestroyEnvironment\", nil, nil)\n }\n \n+const BACKUP_FILENAME = \"jujubackup-%d.tar.gz\"","path":"state/api/client.go","position":4,"original_position":4,"commit_id":"83bd3ce05ef4e6aaefc40354bd1c2c6f83f4c352","original_commit_id":"83bd3ce05ef4e6aaefc40354bd1c2c6f83f4c352","user":{"login":"jameinel","id":202877,"avatar_url":"https://avatars.githubusercontent.com/u/202877?","gravatar_id":"7e8cd608c5279257b9eca560b543b8ad","url":"https://api.github.com/users/jameinel","html_url":"https://github.com/jameinel","followers_url":"https://api.github.com/users/jameinel/followers","following_url":"https://api.github.com/users/jameinel/following{/other_user}","gists_url":"https://api.github.com/users/jameinel/gists{/gist_id}","starred_url":"https://api.github.com/users/jameinel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jameinel/subscriptions","organizations_url":"https://api.github.com/users/jameinel/orgs","repos_url":"https://api.github.com/users/jameinel/repos","events_url":"https://api.github.com/users/jameinel/events{/privacy}","received_events_url":"https://api.github.com/users/jameinel/received_events","type":"User","site_admin":false},"body":"Offhand, this really doesn't feel like it should be in the state/api file.\r\nThis seems very specific to how the CLI is going to interact with the API. And as such, it is entirely appropriate to have the constant in the CLI code.\r\nIt might be that there would be a constant somewhere inside the apiserver that would be saying something like (psuedocode):\r\n if filename == \"\" {\r\n   filename = fmt.Sprintf(FilenameTemplate, time.Now())\r\n  }\r\nsort of thing. However, it would be inappropriate (IMO) to have the CLI code peeking at constants in \"apiserver\" code.\r\nSo from that point of view, it might just be more appropriate to not have a template at all that we try to share, and just write it as explicit text in the help doc.\r\nThoughts?","created_at":"2014-06-17T09:32:18Z","updated_at":"2014-06-17T09:32:18Z","html_url":"https://github.com/juju/juju/pull/97#discussion_r13849936","pull_request_url":"https://api.github.com/repos/juju/juju/pulls/97","_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/comments/13849936"},"html":{"href":"https://github.com/juju/juju/pull/97#discussion_r13849936"},"pull_request":{"href":"https://api.github.com/repos/juju/juju/pulls/97"}}},"pull_request":{"url":"https://api.github.com/repos/juju/juju/pulls/97","id":17133824,"html_url":"https://github.com/juju/juju/pull/97","diff_url":"https://github.com/juju/juju/pull/97.diff","patch_url":"https://github.com/juju/juju/pull/97.patch","issue_url":"https://api.github.com/repos/juju/juju/issues/97","number":97,"state":"open","title":"Add a juju subcommand for backups.","user":{"login":"ericsnowcurrently","id":1152074,"avatar_url":"https://avatars.githubusercontent.com/u/1152074?","gravatar_id":"dd4761743695d5efd3692f2a3b35d37d","url":"https://api.github.com/users/ericsnowcurrently","html_url":"https://github.com/ericsnowcurrently","followers_url":"https://api.github.com/users/ericsnowcurrently/followers","following_url":"https://api.github.com/users/ericsnowcurrently/following{/other_user}","gists_url":"https://api.github.com/users/ericsnowcurrently/gists{/gist_id}","starred_url":"https://api.github.com/users/ericsnowcurrently/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericsnowcurrently/subscriptions","organizations_url":"https://api.github.com/users/ericsnowcurrently/orgs","repos_url":"https://api.github.com/users/ericsnowcurrently/repos","events_url":"https://api.github.com/users/ericsnowcurrently/events{/privacy}","received_events_url":"https://api.github.com/users/ericsnowcurrently/received_events","type":"User","site_admin":false},"body":"This will fit on top of the client API that Michael is writing.","created_at":"2014-06-13T21:52:12Z","updated_at":"2014-06-17T09:32:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"831bef8b86f9b89689e1f14d70ba8e1a4b0bc53d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/juju/juju/pulls/97/commits","review_comments_url":"https://api.github.com/repos/juju/juju/pulls/97/comments","review_comment_url":"https://api.github.com/repos/juju/juju/pulls/comments/{number}","comments_url":"https://api.github.com/repos/juju/juju/issues/97/comments","statuses_url":"https://api.github.com/repos/juju/juju/statuses/83bd3ce05ef4e6aaefc40354bd1c2c6f83f4c352","head":{"label":"ericsnowcurrently:backup-command","ref":"backup-command","sha":"83bd3ce05ef4e6aaefc40354bd1c2c6f83f4c352","user":{"login":"ericsnowcurrently","id":1152074,"avatar_url":"https://avatars.githubusercontent.com/u/1152074?","gravatar_id":"dd4761743695d5efd3692f2a3b35d37d","url":"https://api.github.com/users/ericsnowcurrently","html_url":"https://github.com/ericsnowcurrently","followers_url":"https://api.github.com/users/ericsnowcurrently/followers","following_url":"https://api.github.com/users/ericsnowcurrently/following{/other_user}","gists_url":"https://api.github.com/users/ericsnowcurrently/gists{/gist_id}","starred_url":"https://api.github.com/users/ericsnowcurrently/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericsnowcurrently/subscriptions","organizations_url":"https://api.github.com/users/ericsnowcurrently/orgs","repos_url":"https://api.github.com/users/ericsnowcurrently/repos","events_url":"https://api.github.com/users/ericsnowcurrently/events{/privacy}","received_events_url":"https://api.github.com/users/ericsnowcurrently/received_events","type":"User","site_admin":false},"repo":{"id":20663016,"name":"juju","full_name":"ericsnowcurrently/juju","owner":{"login":"ericsnowcurrently","id":1152074,"avatar_url":"https://avatars.githubusercontent.com/u/1152074?","gravatar_id":"dd4761743695d5efd3692f2a3b35d37d","url":"https://api.github.com/users/ericsnowcurrently","html_url":"https://github.com/ericsnowcurrently","followers_url":"https://api.github.com/users/ericsnowcurrently/followers","following_url":"https://api.github.com/users/ericsnowcurrently/following{/other_user}","gists_url":"https://api.github.com/users/ericsnowcurrently/gists{/gist_id}","starred_url":"https://api.github.com/users/ericsnowcurrently/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericsnowcurrently/subscriptions","organizations_url":"https://api.github.com/users/ericsnowcurrently/orgs","repos_url":"https://api.github.com/users/ericsnowcurrently/repos","events_url":"https://api.github.com/users/ericsnowcurrently/events{/privacy}","received_events_url":"https://api.github.com/users/ericsnowcurrently/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ericsnowcurrently/juju","description":"juju is devops distilled","fork":true,"url":"https://api.github.com/repos/ericsnowcurrently/juju","forks_url":"https://api.github.com/repos/ericsnowcurrently/juju/forks","keys_url":"https://api.github.com/repos/ericsnowcurrently/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ericsnowcurrently/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ericsnowcurrently/juju/teams","hooks_url":"https://api.github.com/repos/ericsnowcurrently/juju/hooks","issue_events_url":"https://api.github.com/repos/ericsnowcurrently/juju/issues/events{/number}","events_url":"https://api.github.com/repos/ericsnowcurrently/juju/events","assignees_url":"https://api.github.com/repos/ericsnowcurrently/juju/assignees{/user}","branches_url":"https://api.github.com/repos/ericsnowcurrently/juju/branches{/branch}","tags_url":"https://api.github.com/repos/ericsnowcurrently/juju/tags","blobs_url":"https://api.github.com/repos/ericsnowcurrently/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ericsnowcurrently/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ericsnowcurrently/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/ericsnowcurrently/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ericsnowcurrently/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/ericsnowcurrently/juju/languages","stargazers_url":"https://api.github.com/repos/ericsnowcurrently/juju/stargazers","contributors_url":"https://api.github.com/repos/ericsnowcurrently/juju/contributors","subscribers_url":"https://api.github.com/repos/ericsnowcurrently/juju/subscribers","subscription_url":"https://api.github.com/repos/ericsnowcurrently/juju/subscription","commits_url":"https://api.github.com/repos/ericsnowcurrently/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/ericsnowcurrently/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/ericsnowcurrently/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/ericsnowcurrently/juju/issues/comments/{number}","contents_url":"https://api.github.com/repos/ericsnowcurrently/juju/contents/{+path}","compare_url":"https://api.github.com/repos/ericsnowcurrently/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ericsnowcurrently/juju/merges","archive_url":"https://api.github.com/repos/ericsnowcurrently/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ericsnowcurrently/juju/downloads","issues_url":"https://api.github.com/repos/ericsnowcurrently/juju/issues{/number}","pulls_url":"https://api.github.com/repos/ericsnowcurrently/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/ericsnowcurrently/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/ericsnowcurrently/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ericsnowcurrently/juju/labels{/name}","releases_url":"https://api.github.com/repos/ericsnowcurrently/juju/releases{/id}","created_at":"2014-06-09T21:34:34Z","updated_at":"2014-06-17T02:06:07Z","pushed_at":"2014-06-16T23:09:41Z","git_url":"git://github.com/ericsnowcurrently/juju.git","ssh_url":"git@github.com:ericsnowcurrently/juju.git","clone_url":"https://github.com/ericsnowcurrently/juju.git","svn_url":"https://github.com/ericsnowcurrently/juju","homepage":"juju.ubuntu.com","size":23414,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"juju:master","ref":"master","sha":"a8c7652206252c848e6da529ee098426493ec99f","user":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?","gravatar_id":"b095d1e26e5705abe0ad2de7d87aac2e","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"repo":{"id":20445947,"name":"juju","full_name":"juju/juju","owner":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?","gravatar_id":"b095d1e26e5705abe0ad2de7d87aac2e","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju/juju","description":"juju is devops distilled","fork":false,"url":"https://api.github.com/repos/juju/juju","forks_url":"https://api.github.com/repos/juju/juju/forks","keys_url":"https://api.github.com/repos/juju/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju/juju/teams","hooks_url":"https://api.github.com/repos/juju/juju/hooks","issue_events_url":"https://api.github.com/repos/juju/juju/issues/events{/number}","events_url":"https://api.github.com/repos/juju/juju/events","assignees_url":"https://api.github.com/repos/juju/juju/assignees{/user}","branches_url":"https://api.github.com/repos/juju/juju/branches{/branch}","tags_url":"https://api.github.com/repos/juju/juju/tags","blobs_url":"https://api.github.com/repos/juju/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/juju/juju/languages","stargazers_url":"https://api.github.com/repos/juju/juju/stargazers","contributors_url":"https://api.github.com/repos/juju/juju/contributors","subscribers_url":"https://api.github.com/repos/juju/juju/subscribers","subscription_url":"https://api.github.com/repos/juju/juju/subscription","commits_url":"https://api.github.com/repos/juju/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju/juju/issues/comments/{number}","contents_url":"https://api.github.com/repos/juju/juju/contents/{+path}","compare_url":"https://api.github.com/repos/juju/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju/juju/merges","archive_url":"https://api.github.com/repos/juju/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju/juju/downloads","issues_url":"https://api.github.com/repos/juju/juju/issues{/number}","pulls_url":"https://api.github.com/repos/juju/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/juju/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/juju/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju/juju/labels{/name}","releases_url":"https://api.github.com/repos/juju/juju/releases{/id}","created_at":"2014-06-03T14:28:10Z","updated_at":"2014-06-17T07:40:07Z","pushed_at":"2014-06-17T07:40:11Z","git_url":"git://github.com/juju/juju.git","ssh_url":"git@github.com:juju/juju.git","clone_url":"https://github.com/juju/juju.git","svn_url":"https://github.com/juju/juju","homepage":"juju.ubuntu.com","size":25888,"stargazers_count":154,"watchers_count":154,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":37,"mirror_url":null,"open_issues_count":24,"forks":37,"open_issues":24,"watchers":154,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/97"},"html":{"href":"https://github.com/juju/juju/pull/97"},"issue":{"href":"https://api.github.com/repos/juju/juju/issues/97"},"comments":{"href":"https://api.github.com/repos/juju/juju/issues/97/comments"},"review_comments":{"href":"https://api.github.com/repos/juju/juju/pulls/97/comments"},"review_comment":{"href":"https://api.github.com/repos/juju/juju/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/juju/juju/pulls/97/commits"},"statuses":{"href":"https://api.github.com/repos/juju/juju/statuses/83bd3ce05ef4e6aaefc40354bd1c2c6f83f4c352"}}}}