GitHub PullRequestReviewCommentEvent at 2014-02-12 15:20:54
Repository: homebrew
Actor: daviewales
Payload: {"comment":{"url":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/9670767","id":9670767,"diff_hunk":"@@ -19,14 +19,36 @@ class Pygobject3 < Formula\n \n   depends_on 'libffi' => :optional\n   depends_on 'glib'\n-  depends_on :python\n+  depends_on :python => :recommended\n   depends_on :python3 => :optional\n-  depends_on 'py2cairo'\n+  depends_on 'py2cairo' if build.with? 'python'\n   depends_on 'py3cairo' if build.with? 'python3'\n   depends_on 'gobject-introspection'\n \n   option :universal\n \n+  if !Formula.factory(\"python\").installed? && build.with?(\"python\") &&\n+    build.with?(\"python3\")\n+  odie <<-EOS.undent\n+    gobject-introspection: You cannot use system Python 2 and Homebrew's Python 3\n+    simultaneously.\n+    Either `brew install python` or use `--without-python3`.\n+  EOS\n+  elsif build.without?(\"python3\") && build.without?(\"python\")\n+    odie \"gobject-introspection: --with-python3 must be specified when using --without-python\"\n+  end","path":"Library/Formula/pygobject3.rb","position":23,"original_position":23,"commit_id":"f234a24efbd41e0d023f8342dc85f4b30e80239d","original_commit_id":"f234a24efbd41e0d023f8342dc85f4b30e80239d","user":{"login":"daviewales","id":2499066,"avatar_url":"https://gravatar.com/avatar/71ba3964ea0f6279b1f7416d0b91fb72?d=https%3A%2F%2Fidenticons.github.com%2F2057029ceed0827480290be3bc2efdf3.png&r=x","gravatar_id":"71ba3964ea0f6279b1f7416d0b91fb72","url":"https://api.github.com/users/daviewales","html_url":"https://github.com/daviewales","followers_url":"https://api.github.com/users/daviewales/followers","following_url":"https://api.github.com/users/daviewales/following{/other_user}","gists_url":"https://api.github.com/users/daviewales/gists{/gist_id}","starred_url":"https://api.github.com/users/daviewales/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daviewales/subscriptions","organizations_url":"https://api.github.com/users/daviewales/orgs","repos_url":"https://api.github.com/users/daviewales/repos","events_url":"https://api.github.com/users/daviewales/events{/privacy}","received_events_url":"https://api.github.com/users/daviewales/received_events","type":"User","site_admin":false},"body":"I will move it to the install method. There is similar code in pyqt and sip, and a lot of the other formulae that have been updated for Python 3 in the last couple of days, so they will need to be fixed as well.","created_at":"2014-02-12T15:20:54Z","updated_at":"2014-02-12T15:20:54Z","html_url":"https://github.com/Homebrew/homebrew/pull/26655#discussion_r9670767","pull_request_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/26655","_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/9670767"},"html":{"href":"https://github.com/Homebrew/homebrew/pull/26655#discussion_r9670767"},"pull_request":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/26655"}}}}