GitHub PullRequestReviewCommentEvent at 2014-05-11 22:54:33
Repository: 8cc
Actor: rui314
Payload: {"comment":{"url":"https://api.github.com/repos/rui314/8cc/pulls/comments/12511307","id":12511307,"diff_hunk":"@@ -1383,7 +1388,28 @@ static void emit_data_charptr(char *s, int depth) {\n     emit(\".quad %s\", label);\n }\n \n+static char * get_const_expr_as_str(ConstExpr *cexpr) {\n+    static char buff[1024];","path":"gen.c","position":17,"original_position":17,"commit_id":"bece7b0a1d2439ebb4a44e712877e54614fd6fe8","original_commit_id":"bece7b0a1d2439ebb4a44e712877e54614fd6fe8","user":{"login":"rui314","id":47400,"avatar_url":"https://avatars.githubusercontent.com/u/47400?","gravatar_id":"10662f0729332c49bbfa022473800d73","url":"https://api.github.com/users/rui314","html_url":"https://github.com/rui314","followers_url":"https://api.github.com/users/rui314/followers","following_url":"https://api.github.com/users/rui314/following{/other_user}","gists_url":"https://api.github.com/users/rui314/gists{/gist_id}","starred_url":"https://api.github.com/users/rui314/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rui314/subscriptions","organizations_url":"https://api.github.com/users/rui314/orgs","repos_url":"https://api.github.com/users/rui314/repos","events_url":"https://api.github.com/users/rui314/events{/privacy}","received_events_url":"https://api.github.com/users/rui314/received_events","type":"User","site_admin":false},"body":"Returning an address to a function local storage is not multi-thread safe. 8cc is not a multi-threaded program, but it's not generally a good practice. I'd use format() instead.\r\n\r\nAlso, is this function for debug? If so, it may have to be moved to debug.c.","created_at":"2014-05-11T22:54:33Z","updated_at":"2014-05-11T22:54:33Z","html_url":"https://github.com/rui314/8cc/pull/8#discussion_r12511307","pull_request_url":"https://api.github.com/repos/rui314/8cc/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/rui314/8cc/pulls/comments/12511307"},"html":{"href":"https://github.com/rui314/8cc/pull/8#discussion_r12511307"},"pull_request":{"href":"https://api.github.com/repos/rui314/8cc/pulls/8"}}}}