GitHub PullRequestReviewCommentEvent at 2014-01-22 18:02:43
Repository: sympy
Actor: smichr
Payload: {"comment":{"url":"https://api.github.com/repos/sympy/sympy/pulls/comments/9084664","id":9084664,"diff_hunk":"@@ -739,6 +739,54 @@ def is_tangent(self, o):\n         else:\n             raise NotImplementedError(\"Unknown argument type\")\n \n+    def normal_lines(self, p):\n+        \"\"\"Normal lines between `p` and the ellipse.\n+\n+        Parameters\n+        ==========\n+\n+        p : Point\n+\n+        Returns\n+        =======\n+\n+        normal_lines : list with 1 , 2 or 4 Lines\n+\n+        Examples\n+        ========\n+\n+        >>> from sympy import*\n+        >>> e1= Ellipse(Point(0,0),2,3)\n+        >>> e1.normal_lines(Point(1,0))\n+        [Line(Point(1, 0), Point(2, 0))]\n+\n+        >>> from sympy import*\n+        >>> e1=Ellipse(Point(3,2),2,3)\n+        >>> e1.normal_lines(Point(3,2))\n+        [Line(Point(3, 2), Point(4, 2)), Line(Point(3, 2), Point(3, 3))]\"\"\"\n+\n+        if self.centre == p:\n+            return [Line(p, Point(p.x + 1, p.y)), Line(p, Point(p.x, p.y + 1))]\n+        elif p.x == self.center.x & p.y != self.center.y:","path":"sympy/geometry/ellipse.py","position":32,"original_position":32,"commit_id":"c0445ee9c6ba1c90f183527fc0c41659e9c0b1be","original_commit_id":"c0445ee9c6ba1c90f183527fc0c41659e9c0b1be","user":{"login":"smichr","id":90703,"avatar_url":"https://gravatar.com/avatar/61e106a28e171b4407171702b182759f?d=https%3A%2F%2Fidenticons.github.com%2Fb803a999ff8aafc51219d9118f0a88e1.png&r=x","gravatar_id":"61e106a28e171b4407171702b182759f","url":"https://api.github.com/users/smichr","html_url":"https://github.com/smichr","followers_url":"https://api.github.com/users/smichr/followers","following_url":"https://api.github.com/users/smichr/following{/other_user}","gists_url":"https://api.github.com/users/smichr/gists{/gist_id}","starred_url":"https://api.github.com/users/smichr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smichr/subscriptions","organizations_url":"https://api.github.com/users/smichr/orgs","repos_url":"https://api.github.com/users/smichr/repos","events_url":"https://api.github.com/users/smichr/events{/privacy}","received_events_url":"https://api.github.com/users/smichr/received_events","type":"User","site_admin":false},"body":"because of the last test we know that p.y can't be at the center, so the 2nd half of the test is not needed.","created_at":"2014-01-22T18:02:43Z","updated_at":"2014-01-22T18:02:43Z","html_url":"https://github.com/sympy/sympy/pull/2811#discussion_r9084664","pull_request_url":"https://api.github.com/repos/sympy/sympy/pulls/2811","_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments/9084664"},"html":{"href":"https://github.com/sympy/sympy/pull/2811#discussion_r9084664"},"pull_request":{"href":"https://api.github.com/repos/sympy/sympy/pulls/2811"}}}}