GitHub PullRequestReviewCommentEvent at 2014-07-24 09:19:31
Repository: mongo-php-driver
Actor: derickr
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mongodb/mongo-php-driver/pulls/comments/15337147","id":15337147,"diff_hunk":"@@ -758,33 +754,60 @@ PHP_METHOD(MongoClient, selectDB)\n \t\t\t\t);\n \n \t\t\t\t/* Create the new link object */\n-\t\t\t\tMAKE_STD_ZVAL(new_link);\n-\t\t\t\tobject_init_ex(new_link, mongo_ce_MongoClient);\n-\t\t\t\ttmp_link = (mongoclient*) zend_object_store_get_object(new_link TSRMLS_CC);\n+\t\t\t\tMAKE_STD_ZVAL(zlink_tmp);\n+\t\t\t\tobject_init_ex(zlink_tmp, mongo_ce_MongoClient);\n+\t\t\t\tlink_tmp = (mongoclient*) zend_object_store_get_object(zlink_tmp TSRMLS_CC);","path":"mongoclient.c","position":78,"original_position":78,"commit_id":"b6a4824ef7b77fc3e9ac1256cfa2ae941fde620a","original_commit_id":"b6a4824ef7b77fc3e9ac1256cfa2ae941fde620a","user":{"login":"derickr","id":208074,"avatar_url":"https://avatars.githubusercontent.com/u/208074?","gravatar_id":"2ef995275795830995d4241368713176","url":"https://api.github.com/users/derickr","html_url":"https://github.com/derickr","followers_url":"https://api.github.com/users/derickr/followers","following_url":"https://api.github.com/users/derickr/following{/other_user}","gists_url":"https://api.github.com/users/derickr/gists{/gist_id}","starred_url":"https://api.github.com/users/derickr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derickr/subscriptions","organizations_url":"https://api.github.com/users/derickr/orgs","repos_url":"https://api.github.com/users/derickr/repos","events_url":"https://api.github.com/users/derickr/events{/privacy}","received_events_url":"https://api.github.com/users/derickr/received_events","type":"User","site_admin":false},"body":"This looks like a change for the sake of a change.","created_at":"2014-07-24T09:19:31Z","updated_at":"2014-07-24T09:19:31Z","html_url":"https://github.com/mongodb/mongo-php-driver/pull/719#discussion_r15337147","pull_request_url":"https://api.github.com/repos/mongodb/mongo-php-driver/pulls/719","_links":{"self":{"href":"https://api.github.com/repos/mongodb/mongo-php-driver/pulls/comments/15337147"},"html":{"href":"https://github.com/mongodb/mongo-php-driver/pull/719#discussion_r15337147"},"pull_request":{"href":"https://api.github.com/repos/mongodb/mongo-php-driver/pulls/719"}}},"pull_request":{"url":"https://api.github.com/repos/mongodb/mongo-php-driver/pulls/719","id":18742853,"html_url":"https://github.com/mongodb/mongo-php-driver/pull/719","diff_url":"https://github.com/mongodb/mongo-php-driver/pull/719.diff","patch_url":"https://github.com/mongodb/mongo-php-driver/pull/719.patch","issue_url":"https://api.github.com/repos/mongodb/mongo-php-driver/issues/719","number":719,"state":"open","title":"Refactoring MONGO_METHOD calls in mongoclient.c and mongo.c","user":{"login":"jmikola","id":244663,"avatar_url":"https://avatars.githubusercontent.com/u/244663?","gravatar_id":"f23700b51dc0c196c1dc02f84aeeecdf","url":"https://api.github.com/users/jmikola","html_url":"https://github.com/jmikola","followers_url":"https://api.github.com/users/jmikola/followers","following_url":"https://api.github.com/users/jmikola/following{/other_user}","gists_url":"https://api.github.com/users/jmikola/gists{/gist_id}","starred_url":"https://api.github.com/users/jmikola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmikola/subscriptions","organizations_url":"https://api.github.com/users/jmikola/orgs","repos_url":"https://api.github.com/users/jmikola/repos","events_url":"https://api.github.com/users/jmikola/events{/privacy}","received_events_url":"https://api.github.com/users/jmikola/received_events","type":"User","site_admin":false},"body":"https://jira.mongodb.org/browse/PHP-820 and related sub-tasks","created_at":"2014-07-22T21:23:03Z","updated_at":"2014-07-24T09:19:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b9c99f086b1e09bab600b2ad3d11b512427e01c4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mongodb/mongo-php-driver/pulls/719/commits","review_comments_url":"https://api.github.com/repos/mongodb/mongo-php-driver/pulls/719/comments","review_comment_url":"https://api.github.com/repos/mongodb/mongo-php-driver/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mongodb/mongo-php-driver/issues/719/comments","statuses_url":"https://api.github.com/repos/mongodb/mongo-php-driver/statuses/b6a4824ef7b77fc3e9ac1256cfa2ae941fde620a","head":{"label":"jmikola:1.6-mongo_method-refactor","ref":"1.6-mongo_method-refactor","sha":"b6a4824ef7b77fc3e9ac1256cfa2ae941fde620a","user":{"login":"jmikola","id":244663,"avatar_url":"https://avatars.githubusercontent.com/u/244663?","gravatar_id":"f23700b51dc0c196c1dc02f84aeeecdf","url":"https://api.github.com/users/jmikola","html_url":"https://github.com/jmikola","followers_url":"https://api.github.com/users/jmikola/followers","following_url":"https://api.github.com/users/jmikola/following{/other_user}","gists_url":"https://api.github.com/users/jmikola/gists{/gist_id}","starred_url":"https://api.github.com/users/jmikola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmikola/subscriptions","organizations_url":"https://api.github.com/users/jmikola/orgs","repos_url":"https://api.github.com/users/jmikola/repos","events_url":"https://api.github.com/users/jmikola/events{/privacy}","received_events_url":"https://api.github.com/users/jmikola/received_events","type":"User","site_admin":false},"repo":{"id":4825115,"name":"mongo-php-driver","full_name":"jmikola/mongo-php-driver","owner":{"login":"jmikola","id":244663,"avatar_url":"https://avatars.githubusercontent.com/u/244663?","gravatar_id":"f23700b51dc0c196c1dc02f84aeeecdf","url":"https://api.github.com/users/jmikola","html_url":"https://github.com/jmikola","followers_url":"https://api.github.com/users/jmikola/followers","following_url":"https://api.github.com/users/jmikola/following{/other_user}","gists_url":"https://api.github.com/users/jmikola/gists{/gist_id}","starred_url":"https://api.github.com/users/jmikola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmikola/subscriptions","organizations_url":"https://api.github.com/users/jmikola/orgs","repos_url":"https://api.github.com/users/jmikola/repos","events_url":"https://api.github.com/users/jmikola/events{/privacy}","received_events_url":"https://api.github.com/users/jmikola/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmikola/mongo-php-driver","description":"Officially supported PHP driver for MongoDB","fork":true,"url":"https://api.github.com/repos/jmikola/mongo-php-driver","forks_url":"https://api.github.com/repos/jmikola/mongo-php-driver/forks","keys_url":"https://api.github.com/repos/jmikola/mongo-php-driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmikola/mongo-php-driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmikola/mongo-php-driver/teams","hooks_url":"https://api.github.com/repos/jmikola/mongo-php-driver/hooks","issue_events_url":"https://api.github.com/repos/jmikola/mongo-php-driver/issues/events{/number}","events_url":"https://api.github.com/repos/jmikola/mongo-php-driver/events","assignees_url":"https://api.github.com/repos/jmikola/mongo-php-driver/assignees{/user}","branches_url":"https://api.github.com/repos/jmikola/mongo-php-driver/branches{/branch}","tags_url":"https://api.github.com/repos/jmikola/mongo-php-driver/tags","blobs_url":"https://api.github.com/repos/jmikola/mongo-php-driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmikola/mongo-php-driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmikola/mongo-php-driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmikola/mongo-php-driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmikola/mongo-php-driver/statuses/{sha}","languages_url":"https://api.github.com/repos/jmikola/mongo-php-driver/languages","stargazers_url":"https://api.github.com/repos/jmikola/mongo-php-driver/stargazers","contributors_url":"https://api.github.com/repos/jmikola/mongo-php-driver/contributors","subscribers_url":"https://api.github.com/repos/jmikola/mongo-php-driver/subscribers","subscription_url":"https://api.github.com/repos/jmikola/mongo-php-driver/subscription","commits_url":"https://api.github.com/repos/jmikola/mongo-php-driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmikola/mongo-php-driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmikola/mongo-php-driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmikola/mongo-php-driver/issues/comments/{number}","contents_url":"https://api.github.com/repos/jmikola/mongo-php-driver/contents/{+path}","compare_url":"https://api.github.com/repos/jmikola/mongo-php-driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmikola/mongo-php-driver/merges","archive_url":"https://api.github.com/repos/jmikola/mongo-php-driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmikola/mongo-php-driver/downloads","issues_url":"https://api.github.com/repos/jmikola/mongo-php-driver/issues{/number}","pulls_url":"https://api.github.com/repos/jmikola/mongo-php-driver/pulls{/number}","milestones_url":"https://api.github.com/repos/jmikola/mongo-php-driver/milestones{/number}","notifications_url":"https://api.github.com/repos/jmikola/mongo-php-driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmikola/mongo-php-driver/labels{/name}","releases_url":"https://api.github.com/repos/jmikola/mongo-php-driver/releases{/id}","created_at":"2012-06-28T20:16:18Z","updated_at":"2014-06-27T22:07:35Z","pushed_at":"2014-07-23T20:51:47Z","git_url":"git://github.com/jmikola/mongo-php-driver.git","ssh_url":"git@github.com:jmikola/mongo-php-driver.git","clone_url":"https://github.com/jmikola/mongo-php-driver.git","svn_url":"https://github.com/jmikola/mongo-php-driver","homepage":"http://www.mongodb.org/display/DOCS/PHP+Language+Center","size":11052,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"mongodb:master","ref":"master","sha":"903688872874183ecf88fdb6431a3cda8ae4e46a","user":{"login":"mongodb","id":45120,"avatar_url":"https://avatars.githubusercontent.com/u/45120?","gravatar_id":"c17ac52a9e94e768c4fab0ce37065841","url":"https://api.github.com/users/mongodb","html_url":"https://github.com/mongodb","followers_url":"https://api.github.com/users/mongodb/followers","following_url":"https://api.github.com/users/mongodb/following{/other_user}","gists_url":"https://api.github.com/users/mongodb/gists{/gist_id}","starred_url":"https://api.github.com/users/mongodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mongodb/subscriptions","organizations_url":"https://api.github.com/users/mongodb/orgs","repos_url":"https://api.github.com/users/mongodb/repos","events_url":"https://api.github.com/users/mongodb/events{/privacy}","received_events_url":"https://api.github.com/users/mongodb/received_events","type":"Organization","site_admin":false},"repo":{"id":121842,"name":"mongo-php-driver","full_name":"mongodb/mongo-php-driver","owner":{"login":"mongodb","id":45120,"avatar_url":"https://avatars.githubusercontent.com/u/45120?","gravatar_id":"c17ac52a9e94e768c4fab0ce37065841","url":"https://api.github.com/users/mongodb","html_url":"https://github.com/mongodb","followers_url":"https://api.github.com/users/mongodb/followers","following_url":"https://api.github.com/users/mongodb/following{/other_user}","gists_url":"https://api.github.com/users/mongodb/gists{/gist_id}","starred_url":"https://api.github.com/users/mongodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mongodb/subscriptions","organizations_url":"https://api.github.com/users/mongodb/orgs","repos_url":"https://api.github.com/users/mongodb/repos","events_url":"https://api.github.com/users/mongodb/events{/privacy}","received_events_url":"https://api.github.com/users/mongodb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mongodb/mongo-php-driver","description":"Officially supported PHP driver for MongoDB","fork":false,"url":"https://api.github.com/repos/mongodb/mongo-php-driver","forks_url":"https://api.github.com/repos/mongodb/mongo-php-driver/forks","keys_url":"https://api.github.com/repos/mongodb/mongo-php-driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mongodb/mongo-php-driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mongodb/mongo-php-driver/teams","hooks_url":"https://api.github.com/repos/mongodb/mongo-php-driver/hooks","issue_events_url":"https://api.github.com/repos/mongodb/mongo-php-driver/issues/events{/number}","events_url":"https://api.github.com/repos/mongodb/mongo-php-driver/events","assignees_url":"https://api.github.com/repos/mongodb/mongo-php-driver/assignees{/user}","branches_url":"https://api.github.com/repos/mongodb/mongo-php-driver/branches{/branch}","tags_url":"https://api.github.com/repos/mongodb/mongo-php-driver/tags","blobs_url":"https://api.github.com/repos/mongodb/mongo-php-driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mongodb/mongo-php-driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mongodb/mongo-php-driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/mongodb/mongo-php-driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mongodb/mongo-php-driver/statuses/{sha}","languages_url":"https://api.github.com/repos/mongodb/mongo-php-driver/languages","stargazers_url":"https://api.github.com/repos/mongodb/mongo-php-driver/stargazers","contributors_url":"https://api.github.com/repos/mongodb/mongo-php-driver/contributors","subscribers_url":"https://api.github.com/repos/mongodb/mongo-php-driver/subscribers","subscription_url":"https://api.github.com/repos/mongodb/mongo-php-driver/subscription","commits_url":"https://api.github.com/repos/mongodb/mongo-php-driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/mongodb/mongo-php-driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/mongodb/mongo-php-driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/mongodb/mongo-php-driver/issues/comments/{number}","contents_url":"https://api.github.com/repos/mongodb/mongo-php-driver/contents/{+path}","compare_url":"https://api.github.com/repos/mongodb/mongo-php-driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mongodb/mongo-php-driver/merges","archive_url":"https://api.github.com/repos/mongodb/mongo-php-driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mongodb/mongo-php-driver/downloads","issues_url":"https://api.github.com/repos/mongodb/mongo-php-driver/issues{/number}","pulls_url":"https://api.github.com/repos/mongodb/mongo-php-driver/pulls{/number}","milestones_url":"https://api.github.com/repos/mongodb/mongo-php-driver/milestones{/number}","notifications_url":"https://api.github.com/repos/mongodb/mongo-php-driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mongodb/mongo-php-driver/labels{/name}","releases_url":"https://api.github.com/repos/mongodb/mongo-php-driver/releases{/id}","created_at":"2009-02-04T21:30:35Z","updated_at":"2014-07-23T17:08:58Z","pushed_at":"2014-07-23T15:26:33Z","git_url":"git://github.com/mongodb/mongo-php-driver.git","ssh_url":"git@github.com:mongodb/mongo-php-driver.git","clone_url":"https://github.com/mongodb/mongo-php-driver.git","svn_url":"https://github.com/mongodb/mongo-php-driver","homepage":"http://docs.mongodb.org/ecosystem/drivers/php/","size":17517,"stargazers_count":908,"watchers_count":908,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":243,"mirror_url":null,"open_issues_count":1,"forks":243,"open_issues":1,"watchers":908,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mongodb/mongo-php-driver/pulls/719"},"html":{"href":"https://github.com/mongodb/mongo-php-driver/pull/719"},"issue":{"href":"https://api.github.com/repos/mongodb/mongo-php-driver/issues/719"},"comments":{"href":"https://api.github.com/repos/mongodb/mongo-php-driver/issues/719/comments"},"review_comments":{"href":"https://api.github.com/repos/mongodb/mongo-php-driver/pulls/719/comments"},"review_comment":{"href":"https://api.github.com/repos/mongodb/mongo-php-driver/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mongodb/mongo-php-driver/pulls/719/commits"},"statuses":{"href":"https://api.github.com/repos/mongodb/mongo-php-driver/statuses/b6a4824ef7b77fc3e9ac1256cfa2ae941fde620a"}}}}