GitHub PullRequestEvent at 2014-08-17 16:46:07
Repository: ppsspp
Actor: neobrain
Payload: {"action":"opened","number":6732,"pull_request":{"url":"https://api.github.com/repos/hrydgard/ppsspp/pulls/6732","id":19891054,"html_url":"https://github.com/hrydgard/ppsspp/pull/6732","diff_url":"https://github.com/hrydgard/ppsspp/pull/6732.diff","patch_url":"https://github.com/hrydgard/ppsspp/pull/6732.patch","issue_url":"https://api.github.com/repos/hrydgard/ppsspp/issues/6732","number":6732,"state":"open","locked":false,"title":"Math3D: Change the vector swizzlers to return const objects.","user":{"login":"neobrain","id":4840017,"avatar_url":"https://avatars.githubusercontent.com/u/4840017?v=2","gravatar_id":"0e2ad4f720c57b96ab4bc6a24c2b59fd","url":"https://api.github.com/users/neobrain","html_url":"https://github.com/neobrain","followers_url":"https://api.github.com/users/neobrain/followers","following_url":"https://api.github.com/users/neobrain/following{/other_user}","gists_url":"https://api.github.com/users/neobrain/gists{/gist_id}","starred_url":"https://api.github.com/users/neobrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neobrain/subscriptions","organizations_url":"https://api.github.com/users/neobrain/orgs","repos_url":"https://api.github.com/users/neobrain/repos","events_url":"https://api.github.com/users/neobrain/events{/privacy}","received_events_url":"https://api.github.com/users/neobrain/received_events","type":"User","site_admin":false},"body":"Something I stumbled upon when re-using portions of this file for citra. This could cause stupid bugs when you try to do something like `some_vec4.xyz() = some_vec3`, which would compile to a no-op because `xyz()` doesn't return references.\r\n\r\nFwiw, a number of other design changes have been made in https://github.com/citra-emu/citra/commit/57911b6e245c59ec07d439d9a50bcc5b57d0546f , but I won't submit a PR for this because the files are already somewhat out-of-sync and the other changes might not be everyone's taste anyway :)\r\n","created_at":"2014-08-17T16:46:06Z","updated_at":"2014-08-17T16:46:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hrydgard/ppsspp/pulls/6732/commits","review_comments_url":"https://api.github.com/repos/hrydgard/ppsspp/pulls/6732/comments","review_comment_url":"https://api.github.com/repos/hrydgard/ppsspp/pulls/comments/{number}","comments_url":"https://api.github.com/repos/hrydgard/ppsspp/issues/6732/comments","statuses_url":"https://api.github.com/repos/hrydgard/ppsspp/statuses/d09b9fa6a1aab379e1ae779650574ee6dca69035","head":{"label":"neobrain:master","ref":"master","sha":"d09b9fa6a1aab379e1ae779650574ee6dca69035","user":{"login":"neobrain","id":4840017,"avatar_url":"https://avatars.githubusercontent.com/u/4840017?v=2","gravatar_id":"0e2ad4f720c57b96ab4bc6a24c2b59fd","url":"https://api.github.com/users/neobrain","html_url":"https://github.com/neobrain","followers_url":"https://api.github.com/users/neobrain/followers","following_url":"https://api.github.com/users/neobrain/following{/other_user}","gists_url":"https://api.github.com/users/neobrain/gists{/gist_id}","starred_url":"https://api.github.com/users/neobrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neobrain/subscriptions","organizations_url":"https://api.github.com/users/neobrain/orgs","repos_url":"https://api.github.com/users/neobrain/repos","events_url":"https://api.github.com/users/neobrain/events{/privacy}","received_events_url":"https://api.github.com/users/neobrain/received_events","type":"User","site_admin":false},"repo":{"id":10978061,"name":"ppsspp","full_name":"neobrain/ppsspp","owner":{"login":"neobrain","id":4840017,"avatar_url":"https://avatars.githubusercontent.com/u/4840017?v=2","gravatar_id":"0e2ad4f720c57b96ab4bc6a24c2b59fd","url":"https://api.github.com/users/neobrain","html_url":"https://github.com/neobrain","followers_url":"https://api.github.com/users/neobrain/followers","following_url":"https://api.github.com/users/neobrain/following{/other_user}","gists_url":"https://api.github.com/users/neobrain/gists{/gist_id}","starred_url":"https://api.github.com/users/neobrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neobrain/subscriptions","organizations_url":"https://api.github.com/users/neobrain/orgs","repos_url":"https://api.github.com/users/neobrain/repos","events_url":"https://api.github.com/users/neobrain/events{/privacy}","received_events_url":"https://api.github.com/users/neobrain/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/neobrain/ppsspp","description":"A PSP emulator for Android, Windows, Mac, Linux and Blackberry 10, written in C++. Want to contribute? Join us in #ppsspp on EFnet (IRC) or just send pull requests / issues.","fork":true,"url":"https://api.github.com/repos/neobrain/ppsspp","forks_url":"https://api.github.com/repos/neobrain/ppsspp/forks","keys_url":"https://api.github.com/repos/neobrain/ppsspp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neobrain/ppsspp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neobrain/ppsspp/teams","hooks_url":"https://api.github.com/repos/neobrain/ppsspp/hooks","issue_events_url":"https://api.github.com/repos/neobrain/ppsspp/issues/events{/number}","events_url":"https://api.github.com/repos/neobrain/ppsspp/events","assignees_url":"https://api.github.com/repos/neobrain/ppsspp/assignees{/user}","branches_url":"https://api.github.com/repos/neobrain/ppsspp/branches{/branch}","tags_url":"https://api.github.com/repos/neobrain/ppsspp/tags","blobs_url":"https://api.github.com/repos/neobrain/ppsspp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neobrain/ppsspp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neobrain/ppsspp/git/refs{/sha}","trees_url":"https://api.github.com/repos/neobrain/ppsspp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neobrain/ppsspp/statuses/{sha}","languages_url":"https://api.github.com/repos/neobrain/ppsspp/languages","stargazers_url":"https://api.github.com/repos/neobrain/ppsspp/stargazers","contributors_url":"https://api.github.com/repos/neobrain/ppsspp/contributors","subscribers_url":"https://api.github.com/repos/neobrain/ppsspp/subscribers","subscription_url":"https://api.github.com/repos/neobrain/ppsspp/subscription","commits_url":"https://api.github.com/repos/neobrain/ppsspp/commits{/sha}","git_commits_url":"https://api.github.com/repos/neobrain/ppsspp/git/commits{/sha}","comments_url":"https://api.github.com/repos/neobrain/ppsspp/comments{/number}","issue_comment_url":"https://api.github.com/repos/neobrain/ppsspp/issues/comments/{number}","contents_url":"https://api.github.com/repos/neobrain/ppsspp/contents/{+path}","compare_url":"https://api.github.com/repos/neobrain/ppsspp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neobrain/ppsspp/merges","archive_url":"https://api.github.com/repos/neobrain/ppsspp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neobrain/ppsspp/downloads","issues_url":"https://api.github.com/repos/neobrain/ppsspp/issues{/number}","pulls_url":"https://api.github.com/repos/neobrain/ppsspp/pulls{/number}","milestones_url":"https://api.github.com/repos/neobrain/ppsspp/milestones{/number}","notifications_url":"https://api.github.com/repos/neobrain/ppsspp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neobrain/ppsspp/labels{/name}","releases_url":"https://api.github.com/repos/neobrain/ppsspp/releases{/id}","created_at":"2013-06-26T20:15:41Z","updated_at":"2014-08-17T16:42:41Z","pushed_at":"2014-08-17T16:42:38Z","git_url":"git://github.com/neobrain/ppsspp.git","ssh_url":"git@github.com:neobrain/ppsspp.git","clone_url":"https://github.com/neobrain/ppsspp.git","svn_url":"https://github.com/neobrain/ppsspp","homepage":"http://www.ppsspp.org","size":57154,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"hrydgard:master","ref":"master","sha":"3e42aae5b0ddf551524cd32b456a1e5ddf9d0739","user":{"login":"hrydgard","id":130929,"avatar_url":"https://avatars.githubusercontent.com/u/130929?v=2","gravatar_id":"2d47f033439c83a9aa9a9212e8b93096","url":"https://api.github.com/users/hrydgard","html_url":"https://github.com/hrydgard","followers_url":"https://api.github.com/users/hrydgard/followers","following_url":"https://api.github.com/users/hrydgard/following{/other_user}","gists_url":"https://api.github.com/users/hrydgard/gists{/gist_id}","starred_url":"https://api.github.com/users/hrydgard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hrydgard/subscriptions","organizations_url":"https://api.github.com/users/hrydgard/orgs","repos_url":"https://api.github.com/users/hrydgard/repos","events_url":"https://api.github.com/users/hrydgard/events{/privacy}","received_events_url":"https://api.github.com/users/hrydgard/received_events","type":"User","site_admin":false},"repo":{"id":6486826,"name":"ppsspp","full_name":"hrydgard/ppsspp","owner":{"login":"hrydgard","id":130929,"avatar_url":"https://avatars.githubusercontent.com/u/130929?v=2","gravatar_id":"2d47f033439c83a9aa9a9212e8b93096","url":"https://api.github.com/users/hrydgard","html_url":"https://github.com/hrydgard","followers_url":"https://api.github.com/users/hrydgard/followers","following_url":"https://api.github.com/users/hrydgard/following{/other_user}","gists_url":"https://api.github.com/users/hrydgard/gists{/gist_id}","starred_url":"https://api.github.com/users/hrydgard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hrydgard/subscriptions","organizations_url":"https://api.github.com/users/hrydgard/orgs","repos_url":"https://api.github.com/users/hrydgard/repos","events_url":"https://api.github.com/users/hrydgard/events{/privacy}","received_events_url":"https://api.github.com/users/hrydgard/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hrydgard/ppsspp","description":"A PSP emulator for Android, Windows, Mac, Linux and Blackberry 10, written in C++. Want to contribute? Join us in #ppsspp on freenode (IRC) or just send pull requests / issues.","fork":false,"url":"https://api.github.com/repos/hrydgard/ppsspp","forks_url":"https://api.github.com/repos/hrydgard/ppsspp/forks","keys_url":"https://api.github.com/repos/hrydgard/ppsspp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hrydgard/ppsspp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hrydgard/ppsspp/teams","hooks_url":"https://api.github.com/repos/hrydgard/ppsspp/hooks","issue_events_url":"https://api.github.com/repos/hrydgard/ppsspp/issues/events{/number}","events_url":"https://api.github.com/repos/hrydgard/ppsspp/events","assignees_url":"https://api.github.com/repos/hrydgard/ppsspp/assignees{/user}","branches_url":"https://api.github.com/repos/hrydgard/ppsspp/branches{/branch}","tags_url":"https://api.github.com/repos/hrydgard/ppsspp/tags","blobs_url":"https://api.github.com/repos/hrydgard/ppsspp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hrydgard/ppsspp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hrydgard/ppsspp/git/refs{/sha}","trees_url":"https://api.github.com/repos/hrydgard/ppsspp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hrydgard/ppsspp/statuses/{sha}","languages_url":"https://api.github.com/repos/hrydgard/ppsspp/languages","stargazers_url":"https://api.github.com/repos/hrydgard/ppsspp/stargazers","contributors_url":"https://api.github.com/repos/hrydgard/ppsspp/contributors","subscribers_url":"https://api.github.com/repos/hrydgard/ppsspp/subscribers","subscription_url":"https://api.github.com/repos/hrydgard/ppsspp/subscription","commits_url":"https://api.github.com/repos/hrydgard/ppsspp/commits{/sha}","git_commits_url":"https://api.github.com/repos/hrydgard/ppsspp/git/commits{/sha}","comments_url":"https://api.github.com/repos/hrydgard/ppsspp/comments{/number}","issue_comment_url":"https://api.github.com/repos/hrydgard/ppsspp/issues/comments/{number}","contents_url":"https://api.github.com/repos/hrydgard/ppsspp/contents/{+path}","compare_url":"https://api.github.com/repos/hrydgard/ppsspp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hrydgard/ppsspp/merges","archive_url":"https://api.github.com/repos/hrydgard/ppsspp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hrydgard/ppsspp/downloads","issues_url":"https://api.github.com/repos/hrydgard/ppsspp/issues{/number}","pulls_url":"https://api.github.com/repos/hrydgard/ppsspp/pulls{/number}","milestones_url":"https://api.github.com/repos/hrydgard/ppsspp/milestones{/number}","notifications_url":"https://api.github.com/repos/hrydgard/ppsspp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hrydgard/ppsspp/labels{/name}","releases_url":"https://api.github.com/repos/hrydgard/ppsspp/releases{/id}","created_at":"2012-11-01T08:41:48Z","updated_at":"2014-08-16T22:06:23Z","pushed_at":"2014-08-17T16:00:42Z","git_url":"git://github.com/hrydgard/ppsspp.git","ssh_url":"git@github.com:hrydgard/ppsspp.git","clone_url":"https://github.com/hrydgard/ppsspp.git","svn_url":"https://github.com/hrydgard/ppsspp","homepage":"http://www.ppsspp.org","size":209075,"stargazers_count":1211,"watchers_count":1211,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":599,"mirror_url":null,"open_issues_count":480,"forks":599,"open_issues":480,"watchers":1211,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hrydgard/ppsspp/pulls/6732"},"html":{"href":"https://github.com/hrydgard/ppsspp/pull/6732"},"issue":{"href":"https://api.github.com/repos/hrydgard/ppsspp/issues/6732"},"comments":{"href":"https://api.github.com/repos/hrydgard/ppsspp/issues/6732/comments"},"review_comments":{"href":"https://api.github.com/repos/hrydgard/ppsspp/pulls/6732/comments"},"review_comment":{"href":"https://api.github.com/repos/hrydgard/ppsspp/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/hrydgard/ppsspp/pulls/6732/commits"},"statuses":{"href":"https://api.github.com/repos/hrydgard/ppsspp/statuses/d09b9fa6a1aab379e1ae779650574ee6dca69035"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":7,"deletions":7,"changed_files":1}}