GitHub PullRequestReviewCommentEvent at 2014-12-03 21:58:29
Repository: node-voicemail-mailbox
Actor: samuelg
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/asterisk/node-voicemail-mailbox/pulls/comments/21268669","id":21268669,"diff_hunk":"@@ -230,19 +246,58 @@ function fsm(mailbox, channel, dependencies) {\n           this.transition('processing');\n         },\n \n-        changeFolder: function() {\n-          dependencies.logger.trace('changeFolder called');\n+        previousMenu: function() {\n+          var self = this;\n+\n+          dependencies.logger.trace('previousMenu called');\n \n           var sounds = dependencies\n             .config\n             .getAppConfig()\n             .prompts\n             .mailboxReader\n-            .changeFolder;\n-\n+            .goodbye\n           this.currentPrompt = dependencies.prompt.create(sounds, channel);\n \n           this.currentPrompt.play()\n+            .finally(function(played) {\n+              self.hangup();\n+            })\n+        },\n+\n+        repeatMenu: function() {\n+          var self = this;\n+\n+          dependencies.logger.trace('repeateMenu called');","path":"lib/reader.js","position":60,"original_position":60,"commit_id":"f391a2948a6541b6f1137b57b86a047620ddaaec","original_commit_id":"f391a2948a6541b6f1137b57b86a047620ddaaec","user":{"login":"samuelg","id":21962,"avatar_url":"https://avatars.githubusercontent.com/u/21962?v=3","gravatar_id":"","url":"https://api.github.com/users/samuelg","html_url":"https://github.com/samuelg","followers_url":"https://api.github.com/users/samuelg/followers","following_url":"https://api.github.com/users/samuelg/following{/other_user}","gists_url":"https://api.github.com/users/samuelg/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelg/subscriptions","organizations_url":"https://api.github.com/users/samuelg/orgs","repos_url":"https://api.github.com/users/samuelg/repos","events_url":"https://api.github.com/users/samuelg/events{/privacy}","received_events_url":"https://api.github.com/users/samuelg/received_events","type":"User","site_admin":false},"body":"log statement should read 'repeatMenu called'","created_at":"2014-12-03T21:58:29Z","updated_at":"2014-12-03T21:58:29Z","html_url":"https://github.com/asterisk/node-voicemail-mailbox/pull/1#discussion_r21268669","pull_request_url":"https://api.github.com/repos/asterisk/node-voicemail-mailbox/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/asterisk/node-voicemail-mailbox/pulls/comments/21268669"},"html":{"href":"https://github.com/asterisk/node-voicemail-mailbox/pull/1#discussion_r21268669"},"pull_request":{"href":"https://api.github.com/repos/asterisk/node-voicemail-mailbox/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/asterisk/node-voicemail-mailbox/pulls/1","id":25117921,"html_url":"https://github.com/asterisk/node-voicemail-mailbox/pull/1","diff_url":"https://github.com/asterisk/node-voicemail-mailbox/pull/1.diff","patch_url":"https://github.com/asterisk/node-voicemail-mailbox/pull/1.patch","issue_url":"https://api.github.com/repos/asterisk/node-voicemail-mailbox/issues/1","number":1,"state":"open","locked":false,"title":"Add DTMF handling for '*' (repeat menu) and '#' (return to menu/exit)","user":{"login":"jrrose","id":768742,"avatar_url":"https://avatars.githubusercontent.com/u/768742?v=3","gravatar_id":"","url":"https://api.github.com/users/jrrose","html_url":"https://github.com/jrrose","followers_url":"https://api.github.com/users/jrrose/followers","following_url":"https://api.github.com/users/jrrose/following{/other_user}","gists_url":"https://api.github.com/users/jrrose/gists{/gist_id}","starred_url":"https://api.github.com/users/jrrose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrrose/subscriptions","organizations_url":"https://api.github.com/users/jrrose/orgs","repos_url":"https://api.github.com/users/jrrose/repos","events_url":"https://api.github.com/users/jrrose/events{/privacy}","received_events_url":"https://api.github.com/users/jrrose/received_events","type":"User","site_admin":false},"body":"Adds support for the following DTMF buttons:\r\n\r\n'*' - repeats the last menu.\r\n'#' - exits from the change folders prompt. If already in the main menu, plays bye and hangs up.","created_at":"2014-11-26T22:23:22Z","updated_at":"2014-12-03T21:58:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"19f0242aa9c7decb7e407128b690f4d843ae8524","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/asterisk/node-voicemail-mailbox/pulls/1/commits","review_comments_url":"https://api.github.com/repos/asterisk/node-voicemail-mailbox/pulls/1/comments","review_comment_url":"https://api.github.com/repos/asterisk/node-voicemail-mailbox/pulls/comments/{number}","comments_url":"https://api.github.com/repos/asterisk/node-voicemail-mailbox/issues/1/comments","statuses_url":"https://api.github.com/repos/asterisk/node-voicemail-mailbox/statuses/f391a2948a6541b6f1137b57b86a047620ddaaec","head":{"label":"jrrose:master","ref":"master","sha":"f391a2948a6541b6f1137b57b86a047620ddaaec","user":{"login":"jrrose","id":768742,"avatar_url":"https://avatars.githubusercontent.com/u/768742?v=3","gravatar_id":"","url":"https://api.github.com/users/jrrose","html_url":"https://github.com/jrrose","followers_url":"https://api.github.com/users/jrrose/followers","following_url":"https://api.github.com/users/jrrose/following{/other_user}","gists_url":"https://api.github.com/users/jrrose/gists{/gist_id}","starred_url":"https://api.github.com/users/jrrose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrrose/subscriptions","organizations_url":"https://api.github.com/users/jrrose/orgs","repos_url":"https://api.github.com/users/jrrose/repos","events_url":"https://api.github.com/users/jrrose/events{/privacy}","received_events_url":"https://api.github.com/users/jrrose/received_events","type":"User","site_admin":false},"repo":{"id":27192129,"name":"node-voicemail-mailbox","full_name":"jrrose/node-voicemail-mailbox","owner":{"login":"jrrose","id":768742,"avatar_url":"https://avatars.githubusercontent.com/u/768742?v=3","gravatar_id":"","url":"https://api.github.com/users/jrrose","html_url":"https://github.com/jrrose","followers_url":"https://api.github.com/users/jrrose/followers","following_url":"https://api.github.com/users/jrrose/following{/other_user}","gists_url":"https://api.github.com/users/jrrose/gists{/gist_id}","starred_url":"https://api.github.com/users/jrrose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrrose/subscriptions","organizations_url":"https://api.github.com/users/jrrose/orgs","repos_url":"https://api.github.com/users/jrrose/repos","events_url":"https://api.github.com/users/jrrose/events{/privacy}","received_events_url":"https://api.github.com/users/jrrose/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jrrose/node-voicemail-mailbox","description":"Mailbox module for voicemail","fork":true,"url":"https://api.github.com/repos/jrrose/node-voicemail-mailbox","forks_url":"https://api.github.com/repos/jrrose/node-voicemail-mailbox/forks","keys_url":"https://api.github.com/repos/jrrose/node-voicemail-mailbox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jrrose/node-voicemail-mailbox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jrrose/node-voicemail-mailbox/teams","hooks_url":"https://api.github.com/repos/jrrose/node-voicemail-mailbox/hooks","issue_events_url":"https://api.github.com/repos/jrrose/node-voicemail-mailbox/issues/events{/number}","events_url":"https://api.github.com/repos/jrrose/node-voicemail-mailbox/events","assignees_url":"https://api.github.com/repos/jrrose/node-voicemail-mailbox/assignees{/user}","branches_url":"https://api.github.com/repos/jrrose/node-voicemail-mailbox/branches{/branch}","tags_url":"https://api.github.com/repos/jrrose/node-voicemail-mailbox/tags","blobs_url":"https://api.github.com/repos/jrrose/node-voicemail-mailbox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jrrose/node-voicemail-mailbox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jrrose/node-voicemail-mailbox/git/refs{/sha}","trees_url":"https://api.github.com/repos/jrrose/node-voicemail-mailbox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jrrose/node-voicemail-mailbox/statuses/{sha}","languages_url":"https://api.github.com/repos/jrrose/node-voicemail-mailbox/languages","stargazers_url":"https://api.github.com/repos/jrrose/node-voicemail-mailbox/stargazers","contributors_url":"https://api.github.com/repos/jrrose/node-voicemail-mailbox/contributors","subscribers_url":"https://api.github.com/repos/jrrose/node-voicemail-mailbox/subscribers","subscription_url":"https://api.github.com/repos/jrrose/node-voicemail-mailbox/subscription","commits_url":"https://api.github.com/repos/jrrose/node-voicemail-mailbox/commits{/sha}","git_commits_url":"https://api.github.com/repos/jrrose/node-voicemail-mailbox/git/commits{/sha}","comments_url":"https://api.github.com/repos/jrrose/node-voicemail-mailbox/comments{/number}","issue_comment_url":"https://api.github.com/repos/jrrose/node-voicemail-mailbox/issues/comments/{number}","contents_url":"https://api.github.com/repos/jrrose/node-voicemail-mailbox/contents/{+path}","compare_url":"https://api.github.com/repos/jrrose/node-voicemail-mailbox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jrrose/node-voicemail-mailbox/merges","archive_url":"https://api.github.com/repos/jrrose/node-voicemail-mailbox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jrrose/node-voicemail-mailbox/downloads","issues_url":"https://api.github.com/repos/jrrose/node-voicemail-mailbox/issues{/number}","pulls_url":"https://api.github.com/repos/jrrose/node-voicemail-mailbox/pulls{/number}","milestones_url":"https://api.github.com/repos/jrrose/node-voicemail-mailbox/milestones{/number}","notifications_url":"https://api.github.com/repos/jrrose/node-voicemail-mailbox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jrrose/node-voicemail-mailbox/labels{/name}","releases_url":"https://api.github.com/repos/jrrose/node-voicemail-mailbox/releases{/id}","created_at":"2014-11-26T19:11:15Z","updated_at":"2014-12-02T23:23:20Z","pushed_at":"2014-12-02T23:23:20Z","git_url":"git://github.com/jrrose/node-voicemail-mailbox.git","ssh_url":"git@github.com:jrrose/node-voicemail-mailbox.git","clone_url":"https://github.com/jrrose/node-voicemail-mailbox.git","svn_url":"https://github.com/jrrose/node-voicemail-mailbox","homepage":"","size":142,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"asterisk:master","ref":"master","sha":"0e27eee79346daa9c338569a219ea44dcd57cee6","user":{"login":"asterisk","id":2914369,"avatar_url":"https://avatars.githubusercontent.com/u/2914369?v=3","gravatar_id":"","url":"https://api.github.com/users/asterisk","html_url":"https://github.com/asterisk","followers_url":"https://api.github.com/users/asterisk/followers","following_url":"https://api.github.com/users/asterisk/following{/other_user}","gists_url":"https://api.github.com/users/asterisk/gists{/gist_id}","starred_url":"https://api.github.com/users/asterisk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asterisk/subscriptions","organizations_url":"https://api.github.com/users/asterisk/orgs","repos_url":"https://api.github.com/users/asterisk/repos","events_url":"https://api.github.com/users/asterisk/events{/privacy}","received_events_url":"https://api.github.com/users/asterisk/received_events","type":"Organization","site_admin":false},"repo":{"id":24428842,"name":"node-voicemail-mailbox","full_name":"asterisk/node-voicemail-mailbox","owner":{"login":"asterisk","id":2914369,"avatar_url":"https://avatars.githubusercontent.com/u/2914369?v=3","gravatar_id":"","url":"https://api.github.com/users/asterisk","html_url":"https://github.com/asterisk","followers_url":"https://api.github.com/users/asterisk/followers","following_url":"https://api.github.com/users/asterisk/following{/other_user}","gists_url":"https://api.github.com/users/asterisk/gists{/gist_id}","starred_url":"https://api.github.com/users/asterisk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asterisk/subscriptions","organizations_url":"https://api.github.com/users/asterisk/orgs","repos_url":"https://api.github.com/users/asterisk/repos","events_url":"https://api.github.com/users/asterisk/events{/privacy}","received_events_url":"https://api.github.com/users/asterisk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/asterisk/node-voicemail-mailbox","description":"Mailbox module for voicemail","fork":false,"url":"https://api.github.com/repos/asterisk/node-voicemail-mailbox","forks_url":"https://api.github.com/repos/asterisk/node-voicemail-mailbox/forks","keys_url":"https://api.github.com/repos/asterisk/node-voicemail-mailbox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/asterisk/node-voicemail-mailbox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/asterisk/node-voicemail-mailbox/teams","hooks_url":"https://api.github.com/repos/asterisk/node-voicemail-mailbox/hooks","issue_events_url":"https://api.github.com/repos/asterisk/node-voicemail-mailbox/issues/events{/number}","events_url":"https://api.github.com/repos/asterisk/node-voicemail-mailbox/events","assignees_url":"https://api.github.com/repos/asterisk/node-voicemail-mailbox/assignees{/user}","branches_url":"https://api.github.com/repos/asterisk/node-voicemail-mailbox/branches{/branch}","tags_url":"https://api.github.com/repos/asterisk/node-voicemail-mailbox/tags","blobs_url":"https://api.github.com/repos/asterisk/node-voicemail-mailbox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/asterisk/node-voicemail-mailbox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/asterisk/node-voicemail-mailbox/git/refs{/sha}","trees_url":"https://api.github.com/repos/asterisk/node-voicemail-mailbox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/asterisk/node-voicemail-mailbox/statuses/{sha}","languages_url":"https://api.github.com/repos/asterisk/node-voicemail-mailbox/languages","stargazers_url":"https://api.github.com/repos/asterisk/node-voicemail-mailbox/stargazers","contributors_url":"https://api.github.com/repos/asterisk/node-voicemail-mailbox/contributors","subscribers_url":"https://api.github.com/repos/asterisk/node-voicemail-mailbox/subscribers","subscription_url":"https://api.github.com/repos/asterisk/node-voicemail-mailbox/subscription","commits_url":"https://api.github.com/repos/asterisk/node-voicemail-mailbox/commits{/sha}","git_commits_url":"https://api.github.com/repos/asterisk/node-voicemail-mailbox/git/commits{/sha}","comments_url":"https://api.github.com/repos/asterisk/node-voicemail-mailbox/comments{/number}","issue_comment_url":"https://api.github.com/repos/asterisk/node-voicemail-mailbox/issues/comments/{number}","contents_url":"https://api.github.com/repos/asterisk/node-voicemail-mailbox/contents/{+path}","compare_url":"https://api.github.com/repos/asterisk/node-voicemail-mailbox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/asterisk/node-voicemail-mailbox/merges","archive_url":"https://api.github.com/repos/asterisk/node-voicemail-mailbox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/asterisk/node-voicemail-mailbox/downloads","issues_url":"https://api.github.com/repos/asterisk/node-voicemail-mailbox/issues{/number}","pulls_url":"https://api.github.com/repos/asterisk/node-voicemail-mailbox/pulls{/number}","milestones_url":"https://api.github.com/repos/asterisk/node-voicemail-mailbox/milestones{/number}","notifications_url":"https://api.github.com/repos/asterisk/node-voicemail-mailbox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/asterisk/node-voicemail-mailbox/labels{/name}","releases_url":"https://api.github.com/repos/asterisk/node-voicemail-mailbox/releases{/id}","created_at":"2014-09-24T19:12:47Z","updated_at":"2014-11-25T15:49:28Z","pushed_at":"2014-11-25T15:49:28Z","git_url":"git://github.com/asterisk/node-voicemail-mailbox.git","ssh_url":"git@github.com:asterisk/node-voicemail-mailbox.git","clone_url":"https://github.com/asterisk/node-voicemail-mailbox.git","svn_url":"https://github.com/asterisk/node-voicemail-mailbox","homepage":"","size":284,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/asterisk/node-voicemail-mailbox/pulls/1"},"html":{"href":"https://github.com/asterisk/node-voicemail-mailbox/pull/1"},"issue":{"href":"https://api.github.com/repos/asterisk/node-voicemail-mailbox/issues/1"},"comments":{"href":"https://api.github.com/repos/asterisk/node-voicemail-mailbox/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/asterisk/node-voicemail-mailbox/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/asterisk/node-voicemail-mailbox/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/asterisk/node-voicemail-mailbox/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/asterisk/node-voicemail-mailbox/statuses/f391a2948a6541b6f1137b57b86a047620ddaaec"}}}}