GitHub PullRequestReviewCommentEvent at 2014-06-21 11:21:17
Repository: disqus-for-drupal8
Actor: slashrsm
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/pulls/comments/14049333","id":14049333,"diff_hunk":"@@ -23,17 +25,17 @@ define('DISQUS_API_REMOVE', 2);\n /**\n  * Implements hook_help().\n  */\n-function disqus_help($path, $arg) {\n-  switch ($path) {\n-  case 'help.page.disqus':\n-    $output = '<p>'. t('Uses the <a href=\"@disqus\">Disqus</a> comment system to enhance comments.', array('@disqus' => 'http://disqus.com')) .'</p>';\n-    $output.= '<h3>'. t('Installation') .'</h3>';\n-    $output.= '<ol><li>'. t('Register your site information at <a href=\"http://disqus.com\">Disqus</a>') .'</li>';\n-    $output.= '<li>'. t('In the <a href=\"@configuration\">Disqus configuration</a>, set the domain to what you registered with Disqus, and what node types you would like to have comments', array('@configuration' => url('admin/config/services/disqus'))) .'</li>';\n-    $output.= '<li>'. t('Visit the <a href=\"@permissions\">permissions</a>, and set which users you would like to have the ability to view Disqus threads (recommended for role)', array('@permissions' => url('admin/people/permissions', array('fragment' => 'module-disqus')))) .'</li></ol>';\n-    return $output;\n-  case 'system.admin_config_services.disqus':\n-    return '<p>'. t('The following provides the general configuration options for the <a href=\"@disqus\">Disqus</a> comment web service.', array('@disqus' => 'http://disqus.com')) .'</p>';\n+function disqus_help($route_name, Request $request) {\n+  switch ($route_name) {\n+    case 'help.page.disqus':\n+      $output = '<p>'. t('Uses the <a href=\"@disqus\">Disqus</a> comment system to enhance comments.', array('@disqus' => 'http://disqus.com')) .'</p>';\n+      $output.= '<h3>'. t('Installation') .'</h3>';\n+      $output.= '<ol><li>'. t('Register your site information at <a href=\"http://disqus.com\">Disqus</a>') .'</li>';\n+      $output.= '<li>'. t('In the <a href=\"@configuration\">Disqus configuration</a>, set the domain to what you registered with Disqus, and what node types you would like to have comments', array('@configuration' => url('admin/config/services/disqus'))) .'</li>';","path":"disqus.module","position":30,"original_position":30,"commit_id":"7b41a79a1a605cae4ba583e3ce085904bc8798c8","original_commit_id":"7b41a79a1a605cae4ba583e3ce085904bc8798c8","user":{"login":"slashrsm","id":376889,"avatar_url":"https://avatars.githubusercontent.com/u/376889?","gravatar_id":"3bdc1ad872e4fb7f14367116f180e497","url":"https://api.github.com/users/slashrsm","html_url":"https://github.com/slashrsm","followers_url":"https://api.github.com/users/slashrsm/followers","following_url":"https://api.github.com/users/slashrsm/following{/other_user}","gists_url":"https://api.github.com/users/slashrsm/gists{/gist_id}","starred_url":"https://api.github.com/users/slashrsm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slashrsm/subscriptions","organizations_url":"https://api.github.com/users/slashrsm/orgs","repos_url":"https://api.github.com/users/slashrsm/repos","events_url":"https://api.github.com/users/slashrsm/events{/privacy}","received_events_url":"https://api.github.com/users/slashrsm/received_events","type":"User","site_admin":false},"body":"We should probably use route names instead of url() and internal url. See action_help() in core to see how that works.","created_at":"2014-06-21T11:21:17Z","updated_at":"2014-06-21T11:21:17Z","html_url":"https://github.com/angrycodr/disqus-for-drupal8/pull/5#discussion_r14049333","pull_request_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/pulls/comments/14049333"},"html":{"href":"https://github.com/angrycodr/disqus-for-drupal8/pull/5#discussion_r14049333"},"pull_request":{"href":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/pulls/5","id":17406922,"html_url":"https://github.com/angrycodr/disqus-for-drupal8/pull/5","diff_url":"https://github.com/angrycodr/disqus-for-drupal8/pull/5.diff","patch_url":"https://github.com/angrycodr/disqus-for-drupal8/pull/5.patch","issue_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/issues/5","number":5,"state":"open","title":"Updated disqus_help()","user":{"login":"angrycodr","id":6861614,"avatar_url":"https://avatars.githubusercontent.com/u/6861614?","gravatar_id":"d1802b2ad3e784b727213b412c5438ce","url":"https://api.github.com/users/angrycodr","html_url":"https://github.com/angrycodr","followers_url":"https://api.github.com/users/angrycodr/followers","following_url":"https://api.github.com/users/angrycodr/following{/other_user}","gists_url":"https://api.github.com/users/angrycodr/gists{/gist_id}","starred_url":"https://api.github.com/users/angrycodr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angrycodr/subscriptions","organizations_url":"https://api.github.com/users/angrycodr/orgs","repos_url":"https://api.github.com/users/angrycodr/repos","events_url":"https://api.github.com/users/angrycodr/events{/privacy}","received_events_url":"https://api.github.com/users/angrycodr/received_events","type":"User","site_admin":false},"body":"Issue on Disqus issue queue on drupal.org: https://www.drupal.org/node/2289293","created_at":"2014-06-20T14:05:21Z","updated_at":"2014-06-21T11:21:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9535d2f0ae15bd6c8410e0fe37a3e4dd2f450df5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/pulls/5/commits","review_comments_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/pulls/5/comments","review_comment_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/pulls/comments/{number}","comments_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/issues/5/comments","statuses_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/statuses/7b41a79a1a605cae4ba583e3ce085904bc8798c8","head":{"label":"angrycodr:Update-disqus_help","ref":"Update-disqus_help","sha":"7b41a79a1a605cae4ba583e3ce085904bc8798c8","user":{"login":"angrycodr","id":6861614,"avatar_url":"https://avatars.githubusercontent.com/u/6861614?","gravatar_id":"d1802b2ad3e784b727213b412c5438ce","url":"https://api.github.com/users/angrycodr","html_url":"https://github.com/angrycodr","followers_url":"https://api.github.com/users/angrycodr/followers","following_url":"https://api.github.com/users/angrycodr/following{/other_user}","gists_url":"https://api.github.com/users/angrycodr/gists{/gist_id}","starred_url":"https://api.github.com/users/angrycodr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angrycodr/subscriptions","organizations_url":"https://api.github.com/users/angrycodr/orgs","repos_url":"https://api.github.com/users/angrycodr/repos","events_url":"https://api.github.com/users/angrycodr/events{/privacy}","received_events_url":"https://api.github.com/users/angrycodr/received_events","type":"User","site_admin":false},"repo":{"id":19279416,"name":"disqus-for-drupal8","full_name":"angrycodr/disqus-for-drupal8","owner":{"login":"angrycodr","id":6861614,"avatar_url":"https://avatars.githubusercontent.com/u/6861614?","gravatar_id":"d1802b2ad3e784b727213b412c5438ce","url":"https://api.github.com/users/angrycodr","html_url":"https://github.com/angrycodr","followers_url":"https://api.github.com/users/angrycodr/followers","following_url":"https://api.github.com/users/angrycodr/following{/other_user}","gists_url":"https://api.github.com/users/angrycodr/gists{/gist_id}","starred_url":"https://api.github.com/users/angrycodr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angrycodr/subscriptions","organizations_url":"https://api.github.com/users/angrycodr/orgs","repos_url":"https://api.github.com/users/angrycodr/repos","events_url":"https://api.github.com/users/angrycodr/events{/privacy}","received_events_url":"https://api.github.com/users/angrycodr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/angrycodr/disqus-for-drupal8","description":"","fork":false,"url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8","forks_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/forks","keys_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/teams","hooks_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/hooks","issue_events_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/issues/events{/number}","events_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/events","assignees_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/assignees{/user}","branches_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/branches{/branch}","tags_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/tags","blobs_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/git/refs{/sha}","trees_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/statuses/{sha}","languages_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/languages","stargazers_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/stargazers","contributors_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/contributors","subscribers_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/subscribers","subscription_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/subscription","commits_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/commits{/sha}","git_commits_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/git/commits{/sha}","comments_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/comments{/number}","issue_comment_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/issues/comments/{number}","contents_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/contents/{+path}","compare_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/merges","archive_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/downloads","issues_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/issues{/number}","pulls_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/pulls{/number}","milestones_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/milestones{/number}","notifications_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/labels{/name}","releases_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/releases{/id}","created_at":"2014-04-29T14:30:26Z","updated_at":"2014-06-20T16:22:14Z","pushed_at":"2014-06-20T16:22:14Z","git_url":"git://github.com/angrycodr/disqus-for-drupal8.git","ssh_url":"git@github.com:angrycodr/disqus-for-drupal8.git","clone_url":"https://github.com/angrycodr/disqus-for-drupal8.git","svn_url":"https://github.com/angrycodr/disqus-for-drupal8","homepage":null,"size":488,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"8.x-1.x"}},"base":{"label":"angrycodr:8.x-1.x","ref":"8.x-1.x","sha":"48b8f16d64106ee9f6210ce22bbbed3ef647ca8c","user":{"login":"angrycodr","id":6861614,"avatar_url":"https://avatars.githubusercontent.com/u/6861614?","gravatar_id":"d1802b2ad3e784b727213b412c5438ce","url":"https://api.github.com/users/angrycodr","html_url":"https://github.com/angrycodr","followers_url":"https://api.github.com/users/angrycodr/followers","following_url":"https://api.github.com/users/angrycodr/following{/other_user}","gists_url":"https://api.github.com/users/angrycodr/gists{/gist_id}","starred_url":"https://api.github.com/users/angrycodr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angrycodr/subscriptions","organizations_url":"https://api.github.com/users/angrycodr/orgs","repos_url":"https://api.github.com/users/angrycodr/repos","events_url":"https://api.github.com/users/angrycodr/events{/privacy}","received_events_url":"https://api.github.com/users/angrycodr/received_events","type":"User","site_admin":false},"repo":{"id":19279416,"name":"disqus-for-drupal8","full_name":"angrycodr/disqus-for-drupal8","owner":{"login":"angrycodr","id":6861614,"avatar_url":"https://avatars.githubusercontent.com/u/6861614?","gravatar_id":"d1802b2ad3e784b727213b412c5438ce","url":"https://api.github.com/users/angrycodr","html_url":"https://github.com/angrycodr","followers_url":"https://api.github.com/users/angrycodr/followers","following_url":"https://api.github.com/users/angrycodr/following{/other_user}","gists_url":"https://api.github.com/users/angrycodr/gists{/gist_id}","starred_url":"https://api.github.com/users/angrycodr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angrycodr/subscriptions","organizations_url":"https://api.github.com/users/angrycodr/orgs","repos_url":"https://api.github.com/users/angrycodr/repos","events_url":"https://api.github.com/users/angrycodr/events{/privacy}","received_events_url":"https://api.github.com/users/angrycodr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/angrycodr/disqus-for-drupal8","description":"","fork":false,"url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8","forks_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/forks","keys_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/teams","hooks_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/hooks","issue_events_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/issues/events{/number}","events_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/events","assignees_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/assignees{/user}","branches_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/branches{/branch}","tags_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/tags","blobs_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/git/refs{/sha}","trees_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/statuses/{sha}","languages_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/languages","stargazers_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/stargazers","contributors_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/contributors","subscribers_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/subscribers","subscription_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/subscription","commits_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/commits{/sha}","git_commits_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/git/commits{/sha}","comments_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/comments{/number}","issue_comment_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/issues/comments/{number}","contents_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/contents/{+path}","compare_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/merges","archive_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/downloads","issues_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/issues{/number}","pulls_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/pulls{/number}","milestones_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/milestones{/number}","notifications_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/labels{/name}","releases_url":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/releases{/id}","created_at":"2014-04-29T14:30:26Z","updated_at":"2014-06-20T16:22:14Z","pushed_at":"2014-06-20T16:22:14Z","git_url":"git://github.com/angrycodr/disqus-for-drupal8.git","ssh_url":"git@github.com:angrycodr/disqus-for-drupal8.git","clone_url":"https://github.com/angrycodr/disqus-for-drupal8.git","svn_url":"https://github.com/angrycodr/disqus-for-drupal8","homepage":null,"size":488,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"8.x-1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/pulls/5"},"html":{"href":"https://github.com/angrycodr/disqus-for-drupal8/pull/5"},"issue":{"href":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/issues/5"},"comments":{"href":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/angrycodr/disqus-for-drupal8/statuses/7b41a79a1a605cae4ba583e3ce085904bc8798c8"}}}}