GitHub PullRequestReviewCommentEvent at 2014-11-11 23:19:11
Repository: debian-package-builder-plugin
Actor: roadrunner2
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/debian-package-builder-plugin/pulls/comments/20189868","id":20189868,"diff_hunk":"@@ -196,6 +191,16 @@ public boolean perform(AbstractBuild<?, ?> build, Launcher launcher, BuildListen\n \t\t} catch (DebianizingException e) {\n \t\t\tlogger.println(MessageFormat.format(DebianPackageBuilder.ABORT_MESSAGE, PREFIX, e.getMessage()));\n \t\t\tbuild.setResult(Result.UNSTABLE);\n+\t\t} finally {\n+\t\t\tif (tempFiles != null) {","path":"src/main/java/ru/yandex/jenkins/plugins/debuilder/DebianPackagePublisher.java","position":82,"original_position":82,"commit_id":"45255e79e17e8528f9914f0ac0dcae3da74f99f5","original_commit_id":"45255e79e17e8528f9914f0ac0dcae3da74f99f5","user":{"login":"roadrunner2","id":133040,"avatar_url":"https://avatars.githubusercontent.com/u/133040?v=3","gravatar_id":"","url":"https://api.github.com/users/roadrunner2","html_url":"https://github.com/roadrunner2","followers_url":"https://api.github.com/users/roadrunner2/followers","following_url":"https://api.github.com/users/roadrunner2/following{/other_user}","gists_url":"https://api.github.com/users/roadrunner2/gists{/gist_id}","starred_url":"https://api.github.com/users/roadrunner2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roadrunner2/subscriptions","organizations_url":"https://api.github.com/users/roadrunner2/orgs","repos_url":"https://api.github.com/users/roadrunner2/repos","events_url":"https://api.github.com/users/roadrunner2/events{/privacy}","received_events_url":"https://api.github.com/users/roadrunner2/received_events","type":"User","site_admin":false},"body":"I'm not sure what you mean by \"invented trap\". If you're referring to the 'trap' in the shell snippet, then these are two different things: that trap removes just the local dupload.conf copies; this here removes both the temporary duploadXXXX.conf and the temporary privateXXXX.key files in the working dir, both of which were being left over after builds.","created_at":"2014-11-11T23:19:11Z","updated_at":"2014-11-11T23:19:11Z","html_url":"https://github.com/jenkinsci/debian-package-builder-plugin/pull/35#discussion_r20189868","pull_request_url":"https://api.github.com/repos/jenkinsci/debian-package-builder-plugin/pulls/35","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/debian-package-builder-plugin/pulls/comments/20189868"},"html":{"href":"https://github.com/jenkinsci/debian-package-builder-plugin/pull/35#discussion_r20189868"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/debian-package-builder-plugin/pulls/35"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/debian-package-builder-plugin/pulls/35","id":24128023,"html_url":"https://github.com/jenkinsci/debian-package-builder-plugin/pull/35","diff_url":"https://github.com/jenkinsci/debian-package-builder-plugin/pull/35.diff","patch_url":"https://github.com/jenkinsci/debian-package-builder-plugin/pull/35.patch","issue_url":"https://api.github.com/repos/jenkinsci/debian-package-builder-plugin/issues/35","number":35,"state":"open","locked":false,"title":"Fix race and leak","user":{"login":"roadrunner2","id":133040,"avatar_url":"https://avatars.githubusercontent.com/u/133040?v=3","gravatar_id":"","url":"https://api.github.com/users/roadrunner2","html_url":"https://github.com/roadrunner2","followers_url":"https://api.github.com/users/roadrunner2/followers","following_url":"https://api.github.com/users/roadrunner2/following{/other_user}","gists_url":"https://api.github.com/users/roadrunner2/gists{/gist_id}","starred_url":"https://api.github.com/users/roadrunner2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roadrunner2/subscriptions","organizations_url":"https://api.github.com/users/roadrunner2/orgs","repos_url":"https://api.github.com/users/roadrunner2/repos","events_url":"https://api.github.com/users/roadrunner2/events{/privacy}","received_events_url":"https://api.github.com/users/roadrunner2/received_events","type":"User","site_admin":false},"body":"Sorry for submitting two commits in this pull request, but the second builds on the first.","created_at":"2014-11-10T05:53:11Z","updated_at":"2014-11-11T23:19:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fdb78f9f4adab5d72270c38e3d0acc9e79c9b85e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/debian-package-builder-plugin/pulls/35/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/debian-package-builder-plugin/pulls/35/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/debian-package-builder-plugin/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jenkinsci/debian-package-builder-plugin/issues/35/comments","statuses_url":"https://api.github.com/repos/jenkinsci/debian-package-builder-plugin/statuses/45255e79e17e8528f9914f0ac0dcae3da74f99f5","head":{"label":"roadrunner2:fixRaceAndLeak","ref":"fixRaceAndLeak","sha":"45255e79e17e8528f9914f0ac0dcae3da74f99f5","user":{"login":"roadrunner2","id":133040,"avatar_url":"https://avatars.githubusercontent.com/u/133040?v=3","gravatar_id":"","url":"https://api.github.com/users/roadrunner2","html_url":"https://github.com/roadrunner2","followers_url":"https://api.github.com/users/roadrunner2/followers","following_url":"https://api.github.com/users/roadrunner2/following{/other_user}","gists_url":"https://api.github.com/users/roadrunner2/gists{/gist_id}","starred_url":"https://api.github.com/users/roadrunner2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roadrunner2/subscriptions","organizations_url":"https://api.github.com/users/roadrunner2/orgs","repos_url":"https://api.github.com/users/roadrunner2/repos","events_url":"https://api.github.com/users/roadrunner2/events{/privacy}","received_events_url":"https://api.github.com/users/roadrunner2/received_events","type":"User","site_admin":false},"repo":{"id":26422817,"name":"debian-package-builder-plugin","full_name":"roadrunner2/debian-package-builder-plugin","owner":{"login":"roadrunner2","id":133040,"avatar_url":"https://avatars.githubusercontent.com/u/133040?v=3","gravatar_id":"","url":"https://api.github.com/users/roadrunner2","html_url":"https://github.com/roadrunner2","followers_url":"https://api.github.com/users/roadrunner2/followers","following_url":"https://api.github.com/users/roadrunner2/following{/other_user}","gists_url":"https://api.github.com/users/roadrunner2/gists{/gist_id}","starred_url":"https://api.github.com/users/roadrunner2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roadrunner2/subscriptions","organizations_url":"https://api.github.com/users/roadrunner2/orgs","repos_url":"https://api.github.com/users/roadrunner2/repos","events_url":"https://api.github.com/users/roadrunner2/events{/privacy}","received_events_url":"https://api.github.com/users/roadrunner2/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/roadrunner2/debian-package-builder-plugin","description":"Jenkins plugin for debian package building","fork":true,"url":"https://api.github.com/repos/roadrunner2/debian-package-builder-plugin","forks_url":"https://api.github.com/repos/roadrunner2/debian-package-builder-plugin/forks","keys_url":"https://api.github.com/repos/roadrunner2/debian-package-builder-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/roadrunner2/debian-package-builder-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/roadrunner2/debian-package-builder-plugin/teams","hooks_url":"https://api.github.com/repos/roadrunner2/debian-package-builder-plugin/hooks","issue_events_url":"https://api.github.com/repos/roadrunner2/debian-package-builder-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/roadrunner2/debian-package-builder-plugin/events","assignees_url":"https://api.github.com/repos/roadrunner2/debian-package-builder-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/roadrunner2/debian-package-builder-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/roadrunner2/debian-package-builder-plugin/tags","blobs_url":"https://api.github.com/repos/roadrunner2/debian-package-builder-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/roadrunner2/debian-package-builder-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/roadrunner2/debian-package-builder-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/roadrunner2/debian-package-builder-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/roadrunner2/debian-package-builder-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/roadrunner2/debian-package-builder-plugin/languages","stargazers_url":"https://api.github.com/repos/roadrunner2/debian-package-builder-plugin/stargazers","contributors_url":"https://api.github.com/repos/roadrunner2/debian-package-builder-plugin/contributors","subscribers_url":"https://api.github.com/repos/roadrunner2/debian-package-builder-plugin/subscribers","subscription_url":"https://api.github.com/repos/roadrunner2/debian-package-builder-plugin/subscription","commits_url":"https://api.github.com/repos/roadrunner2/debian-package-builder-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/roadrunner2/debian-package-builder-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/roadrunner2/debian-package-builder-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/roadrunner2/debian-package-builder-plugin/issues/comments/{number}","contents_url":"https://api.github.com/repos/roadrunner2/debian-package-builder-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/roadrunner2/debian-package-builder-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/roadrunner2/debian-package-builder-plugin/merges","archive_url":"https://api.github.com/repos/roadrunner2/debian-package-builder-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/roadrunner2/debian-package-builder-plugin/downloads","issues_url":"https://api.github.com/repos/roadrunner2/debian-package-builder-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/roadrunner2/debian-package-builder-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/roadrunner2/debian-package-builder-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/roadrunner2/debian-package-builder-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/roadrunner2/debian-package-builder-plugin/labels{/name}","releases_url":"https://api.github.com/repos/roadrunner2/debian-package-builder-plugin/releases{/id}","created_at":"2014-11-10T05:46:05Z","updated_at":"2014-10-03T20:39:34Z","pushed_at":"2014-11-10T05:48:35Z","git_url":"git://github.com/roadrunner2/debian-package-builder-plugin.git","ssh_url":"git@github.com:roadrunner2/debian-package-builder-plugin.git","clone_url":"https://github.com/roadrunner2/debian-package-builder-plugin.git","svn_url":"https://github.com/roadrunner2/debian-package-builder-plugin","homepage":null,"size":1179,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"96c13d94005d88851082adb9e963ec0ec0751acd","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":6331732,"name":"debian-package-builder-plugin","full_name":"jenkinsci/debian-package-builder-plugin","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/debian-package-builder-plugin","description":"Jenkins plugin for debian package building","fork":false,"url":"https://api.github.com/repos/jenkinsci/debian-package-builder-plugin","forks_url":"https://api.github.com/repos/jenkinsci/debian-package-builder-plugin/forks","keys_url":"https://api.github.com/repos/jenkinsci/debian-package-builder-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/debian-package-builder-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/debian-package-builder-plugin/teams","hooks_url":"https://api.github.com/repos/jenkinsci/debian-package-builder-plugin/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/debian-package-builder-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/debian-package-builder-plugin/events","assignees_url":"https://api.github.com/repos/jenkinsci/debian-package-builder-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/debian-package-builder-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/debian-package-builder-plugin/tags","blobs_url":"https://api.github.com/repos/jenkinsci/debian-package-builder-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/debian-package-builder-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/debian-package-builder-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/debian-package-builder-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/debian-package-builder-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/debian-package-builder-plugin/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/debian-package-builder-plugin/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/debian-package-builder-plugin/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/debian-package-builder-plugin/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/debian-package-builder-plugin/subscription","commits_url":"https://api.github.com/repos/jenkinsci/debian-package-builder-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/debian-package-builder-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/debian-package-builder-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/debian-package-builder-plugin/issues/comments/{number}","contents_url":"https://api.github.com/repos/jenkinsci/debian-package-builder-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/debian-package-builder-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/debian-package-builder-plugin/merges","archive_url":"https://api.github.com/repos/jenkinsci/debian-package-builder-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/debian-package-builder-plugin/downloads","issues_url":"https://api.github.com/repos/jenkinsci/debian-package-builder-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/debian-package-builder-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/debian-package-builder-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/debian-package-builder-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/debian-package-builder-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/debian-package-builder-plugin/releases{/id}","created_at":"2012-10-22T08:29:03Z","updated_at":"2014-10-03T20:39:34Z","pushed_at":"2014-11-06T11:22:01Z","git_url":"git://github.com/jenkinsci/debian-package-builder-plugin.git","ssh_url":"git@github.com:jenkinsci/debian-package-builder-plugin.git","clone_url":"https://github.com/jenkinsci/debian-package-builder-plugin.git","svn_url":"https://github.com/jenkinsci/debian-package-builder-plugin","homepage":null,"size":1179,"stargazers_count":16,"watchers_count":16,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":9,"forks":20,"open_issues":9,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/debian-package-builder-plugin/pulls/35"},"html":{"href":"https://github.com/jenkinsci/debian-package-builder-plugin/pull/35"},"issue":{"href":"https://api.github.com/repos/jenkinsci/debian-package-builder-plugin/issues/35"},"comments":{"href":"https://api.github.com/repos/jenkinsci/debian-package-builder-plugin/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/debian-package-builder-plugin/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/debian-package-builder-plugin/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/debian-package-builder-plugin/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/debian-package-builder-plugin/statuses/45255e79e17e8528f9914f0ac0dcae3da74f99f5"}}}}