GitHub PullRequestEvent at 2014-12-17 18:28:38
Repository: and-son
Actor: jcredding
Payload: {"action":"opened","number":38,"pull_request":{"url":"https://api.github.com/repos/redding/and-son/pulls/38","id":26245427,"html_url":"https://github.com/redding/and-son/pull/38","diff_url":"https://github.com/redding/and-son/pull/38.diff","patch_url":"https://github.com/redding/and-son/pull/38.patch","issue_url":"https://api.github.com/repos/redding/and-son/issues/38","number":38,"state":"open","locked":false,"title":"Allow adding a response for a service for any params","user":{"login":"jcredding","id":85966,"avatar_url":"https://avatars.githubusercontent.com/u/85966?v=3","gravatar_id":"","url":"https://api.github.com/users/jcredding","html_url":"https://github.com/jcredding","followers_url":"https://api.github.com/users/jcredding/followers","following_url":"https://api.github.com/users/jcredding/following{/other_user}","gists_url":"https://api.github.com/users/jcredding/gists{/gist_id}","starred_url":"https://api.github.com/users/jcredding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcredding/subscriptions","organizations_url":"https://api.github.com/users/jcredding/orgs","repos_url":"https://api.github.com/users/jcredding/repos","events_url":"https://api.github.com/users/jcredding/events{/privacy}","received_events_url":"https://api.github.com/users/jcredding/received_events","type":"User","site_admin":false},"body":"This updates the stored response \"stubbing\" to allow stubbing only\r\na service name and having any calls made to that service generate\r\na response. This is useful in testing for cases where there isn't\r\nany need to generate different responses for different params.\r\nFor example, to test how a part of code behaves when a service\r\nreturns a failing response you would stub the response to return\r\na 500 status code. Previously, you had to stub the service with the\r\nparams you expected to be called. This is annoying and typically\r\nwe just want to say whatever calls this service, return a 500 no\r\nmatter what params it receives. This allows for simpler tests that\r\nfocus only on the pieces that we care about and don't have extra\r\ncruft that hides the goal of the test.\r\n\r\nThis makes the interface similar to `Assert`'s stubbing interface\r\nand isn't backwards compatible. All the previous behavior is still\r\npresent, only the interface for using it has changed.\r\n\r\nThis also starts changes to the system tests to match our current\r\nconventions. This moves the stored response system tests to a\r\nclient tests file and updates them to test multiple scenarios.\r\n\r\n@kellyredding - Ready for review. I made a note that a change like this would probably be useful after seeing how we've used this in our tests. Since I'm planning on touching a lot of and-son calls I figured this would be a decent time to make this change.","created_at":"2014-12-17T18:28:38Z","updated_at":"2014-12-17T18:28:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/redding/and-son/pulls/38/commits","review_comments_url":"https://api.github.com/repos/redding/and-son/pulls/38/comments","review_comment_url":"https://api.github.com/repos/redding/and-son/pulls/comments/{number}","comments_url":"https://api.github.com/repos/redding/and-son/issues/38/comments","statuses_url":"https://api.github.com/repos/redding/and-son/statuses/07c353f1f41ab1fb9ce67a00e12eef08fd8f47aa","head":{"label":"redding:jcr-change-stub","ref":"jcr-change-stub","sha":"07c353f1f41ab1fb9ce67a00e12eef08fd8f47aa","user":{"login":"redding","id":2427810,"avatar_url":"https://avatars.githubusercontent.com/u/2427810?v=3","gravatar_id":"","url":"https://api.github.com/users/redding","html_url":"https://github.com/redding","followers_url":"https://api.github.com/users/redding/followers","following_url":"https://api.github.com/users/redding/following{/other_user}","gists_url":"https://api.github.com/users/redding/gists{/gist_id}","starred_url":"https://api.github.com/users/redding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redding/subscriptions","organizations_url":"https://api.github.com/users/redding/orgs","repos_url":"https://api.github.com/users/redding/repos","events_url":"https://api.github.com/users/redding/events{/privacy}","received_events_url":"https://api.github.com/users/redding/received_events","type":"Organization","site_admin":false},"repo":{"id":6706238,"name":"and-son","full_name":"redding/and-son","owner":{"login":"redding","id":2427810,"avatar_url":"https://avatars.githubusercontent.com/u/2427810?v=3","gravatar_id":"","url":"https://api.github.com/users/redding","html_url":"https://github.com/redding","followers_url":"https://api.github.com/users/redding/followers","following_url":"https://api.github.com/users/redding/following{/other_user}","gists_url":"https://api.github.com/users/redding/gists{/gist_id}","starred_url":"https://api.github.com/users/redding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redding/subscriptions","organizations_url":"https://api.github.com/users/redding/orgs","repos_url":"https://api.github.com/users/redding/repos","events_url":"https://api.github.com/users/redding/events{/privacy}","received_events_url":"https://api.github.com/users/redding/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/redding/and-son","description":"Simple Sanford client for Ruby","fork":false,"url":"https://api.github.com/repos/redding/and-son","forks_url":"https://api.github.com/repos/redding/and-son/forks","keys_url":"https://api.github.com/repos/redding/and-son/keys{/key_id}","collaborators_url":"https://api.github.com/repos/redding/and-son/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/redding/and-son/teams","hooks_url":"https://api.github.com/repos/redding/and-son/hooks","issue_events_url":"https://api.github.com/repos/redding/and-son/issues/events{/number}","events_url":"https://api.github.com/repos/redding/and-son/events","assignees_url":"https://api.github.com/repos/redding/and-son/assignees{/user}","branches_url":"https://api.github.com/repos/redding/and-son/branches{/branch}","tags_url":"https://api.github.com/repos/redding/and-son/tags","blobs_url":"https://api.github.com/repos/redding/and-son/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/redding/and-son/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/redding/and-son/git/refs{/sha}","trees_url":"https://api.github.com/repos/redding/and-son/git/trees{/sha}","statuses_url":"https://api.github.com/repos/redding/and-son/statuses/{sha}","languages_url":"https://api.github.com/repos/redding/and-son/languages","stargazers_url":"https://api.github.com/repos/redding/and-son/stargazers","contributors_url":"https://api.github.com/repos/redding/and-son/contributors","subscribers_url":"https://api.github.com/repos/redding/and-son/subscribers","subscription_url":"https://api.github.com/repos/redding/and-son/subscription","commits_url":"https://api.github.com/repos/redding/and-son/commits{/sha}","git_commits_url":"https://api.github.com/repos/redding/and-son/git/commits{/sha}","comments_url":"https://api.github.com/repos/redding/and-son/comments{/number}","issue_comment_url":"https://api.github.com/repos/redding/and-son/issues/comments/{number}","contents_url":"https://api.github.com/repos/redding/and-son/contents/{+path}","compare_url":"https://api.github.com/repos/redding/and-son/compare/{base}...{head}","merges_url":"https://api.github.com/repos/redding/and-son/merges","archive_url":"https://api.github.com/repos/redding/and-son/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/redding/and-son/downloads","issues_url":"https://api.github.com/repos/redding/and-son/issues{/number}","pulls_url":"https://api.github.com/repos/redding/and-son/pulls{/number}","milestones_url":"https://api.github.com/repos/redding/and-son/milestones{/number}","notifications_url":"https://api.github.com/repos/redding/and-son/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/redding/and-son/labels{/name}","releases_url":"https://api.github.com/repos/redding/and-son/releases{/id}","created_at":"2012-11-15T14:49:39Z","updated_at":"2014-09-26T16:15:26Z","pushed_at":"2014-12-17T18:27:38Z","git_url":"git://github.com/redding/and-son.git","ssh_url":"git@github.com:redding/and-son.git","clone_url":"https://github.com/redding/and-son.git","svn_url":"https://github.com/redding/and-son","homepage":"https://github.com/redding/sanford-protocol","size":768,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"redding:master","ref":"master","sha":"294efef8e0ea3630bd9b1c4b8488b61a244ddbe0","user":{"login":"redding","id":2427810,"avatar_url":"https://avatars.githubusercontent.com/u/2427810?v=3","gravatar_id":"","url":"https://api.github.com/users/redding","html_url":"https://github.com/redding","followers_url":"https://api.github.com/users/redding/followers","following_url":"https://api.github.com/users/redding/following{/other_user}","gists_url":"https://api.github.com/users/redding/gists{/gist_id}","starred_url":"https://api.github.com/users/redding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redding/subscriptions","organizations_url":"https://api.github.com/users/redding/orgs","repos_url":"https://api.github.com/users/redding/repos","events_url":"https://api.github.com/users/redding/events{/privacy}","received_events_url":"https://api.github.com/users/redding/received_events","type":"Organization","site_admin":false},"repo":{"id":6706238,"name":"and-son","full_name":"redding/and-son","owner":{"login":"redding","id":2427810,"avatar_url":"https://avatars.githubusercontent.com/u/2427810?v=3","gravatar_id":"","url":"https://api.github.com/users/redding","html_url":"https://github.com/redding","followers_url":"https://api.github.com/users/redding/followers","following_url":"https://api.github.com/users/redding/following{/other_user}","gists_url":"https://api.github.com/users/redding/gists{/gist_id}","starred_url":"https://api.github.com/users/redding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redding/subscriptions","organizations_url":"https://api.github.com/users/redding/orgs","repos_url":"https://api.github.com/users/redding/repos","events_url":"https://api.github.com/users/redding/events{/privacy}","received_events_url":"https://api.github.com/users/redding/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/redding/and-son","description":"Simple Sanford client for Ruby","fork":false,"url":"https://api.github.com/repos/redding/and-son","forks_url":"https://api.github.com/repos/redding/and-son/forks","keys_url":"https://api.github.com/repos/redding/and-son/keys{/key_id}","collaborators_url":"https://api.github.com/repos/redding/and-son/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/redding/and-son/teams","hooks_url":"https://api.github.com/repos/redding/and-son/hooks","issue_events_url":"https://api.github.com/repos/redding/and-son/issues/events{/number}","events_url":"https://api.github.com/repos/redding/and-son/events","assignees_url":"https://api.github.com/repos/redding/and-son/assignees{/user}","branches_url":"https://api.github.com/repos/redding/and-son/branches{/branch}","tags_url":"https://api.github.com/repos/redding/and-son/tags","blobs_url":"https://api.github.com/repos/redding/and-son/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/redding/and-son/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/redding/and-son/git/refs{/sha}","trees_url":"https://api.github.com/repos/redding/and-son/git/trees{/sha}","statuses_url":"https://api.github.com/repos/redding/and-son/statuses/{sha}","languages_url":"https://api.github.com/repos/redding/and-son/languages","stargazers_url":"https://api.github.com/repos/redding/and-son/stargazers","contributors_url":"https://api.github.com/repos/redding/and-son/contributors","subscribers_url":"https://api.github.com/repos/redding/and-son/subscribers","subscription_url":"https://api.github.com/repos/redding/and-son/subscription","commits_url":"https://api.github.com/repos/redding/and-son/commits{/sha}","git_commits_url":"https://api.github.com/repos/redding/and-son/git/commits{/sha}","comments_url":"https://api.github.com/repos/redding/and-son/comments{/number}","issue_comment_url":"https://api.github.com/repos/redding/and-son/issues/comments/{number}","contents_url":"https://api.github.com/repos/redding/and-son/contents/{+path}","compare_url":"https://api.github.com/repos/redding/and-son/compare/{base}...{head}","merges_url":"https://api.github.com/repos/redding/and-son/merges","archive_url":"https://api.github.com/repos/redding/and-son/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/redding/and-son/downloads","issues_url":"https://api.github.com/repos/redding/and-son/issues{/number}","pulls_url":"https://api.github.com/repos/redding/and-son/pulls{/number}","milestones_url":"https://api.github.com/repos/redding/and-son/milestones{/number}","notifications_url":"https://api.github.com/repos/redding/and-son/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/redding/and-son/labels{/name}","releases_url":"https://api.github.com/repos/redding/and-son/releases{/id}","created_at":"2012-11-15T14:49:39Z","updated_at":"2014-09-26T16:15:26Z","pushed_at":"2014-12-17T18:27:38Z","git_url":"git://github.com/redding/and-son.git","ssh_url":"git@github.com:redding/and-son.git","clone_url":"https://github.com/redding/and-son.git","svn_url":"https://github.com/redding/and-son","homepage":"https://github.com/redding/sanford-protocol","size":768,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/redding/and-son/pulls/38"},"html":{"href":"https://github.com/redding/and-son/pull/38"},"issue":{"href":"https://api.github.com/repos/redding/and-son/issues/38"},"comments":{"href":"https://api.github.com/repos/redding/and-son/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/redding/and-son/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/redding/and-son/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/redding/and-son/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/redding/and-son/statuses/07c353f1f41ab1fb9ce67a00e12eef08fd8f47aa"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":195,"deletions":84,"changed_files":6}}