GitHub PullRequestReviewCommentEvent at 2014-12-09 08:45:40
Repository: hazelcast-stabilizer
Actor: gurbuzali
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/pulls/comments/21513394","id":21513394,"diff_hunk":"@@ -41,19 +45,38 @@\n     //number of bytes for the value/payload of a key\n     public int valueSize=100;\n \n-    //the size of the cache can be larger than the defined max-size by this percentage before the test fails\n-    public double cacheSizeMargin=0.2;\n+    public double putProb=0.8;\n+    public double putAsyncProb=0.1;\n+    public double putAllProb=0.1;\n \n     //used as the basename of the data structure\n     public String basename;\n \n+    // As clients might be running this test they have no way of knowing the value\n+    // Default value is 271 or configure via \"GroupProperties.PROP_PARTITION_COUNT\" property\n+    public int partitionCount=271;","path":"stabilizer/src/main/java/com/hazelcast/stabilizer/tests/icache/EvictionICacheTest.java","position":31,"original_position":28,"commit_id":"13708873dfa9a92088a6274d189d6247f5969bd7","original_commit_id":"54bce4a5a271034ff16c72dc234bce154113cbed","user":{"login":"gurbuzali","id":1741680,"avatar_url":"https://avatars.githubusercontent.com/u/1741680?v=3","gravatar_id":"","url":"https://api.github.com/users/gurbuzali","html_url":"https://github.com/gurbuzali","followers_url":"https://api.github.com/users/gurbuzali/followers","following_url":"https://api.github.com/users/gurbuzali/following{/other_user}","gists_url":"https://api.github.com/users/gurbuzali/gists{/gist_id}","starred_url":"https://api.github.com/users/gurbuzali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gurbuzali/subscriptions","organizations_url":"https://api.github.com/users/gurbuzali/orgs","repos_url":"https://api.github.com/users/gurbuzali/repos","events_url":"https://api.github.com/users/gurbuzali/events{/privacy}","received_events_url":"https://api.github.com/users/gurbuzali/received_events","type":"User","site_admin":false},"body":"dumb client knows it too","created_at":"2014-12-09T08:45:40Z","updated_at":"2014-12-09T08:45:40Z","html_url":"https://github.com/hazelcast/hazelcast-stabilizer/pull/424#discussion_r21513394","pull_request_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/pulls/424","_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/pulls/comments/21513394"},"html":{"href":"https://github.com/hazelcast/hazelcast-stabilizer/pull/424#discussion_r21513394"},"pull_request":{"href":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/pulls/424"}}},"pull_request":{"url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/pulls/424","id":25685124,"html_url":"https://github.com/hazelcast/hazelcast-stabilizer/pull/424","diff_url":"https://github.com/hazelcast/hazelcast-stabilizer/pull/424.diff","patch_url":"https://github.com/hazelcast/hazelcast-stabilizer/pull/424.patch","issue_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/issues/424","number":424,"state":"open","locked":false,"title":"jcache eviction test","user":{"login":"Danny-Hazelcast","id":5988678,"avatar_url":"https://avatars.githubusercontent.com/u/5988678?v=3","gravatar_id":"","url":"https://api.github.com/users/Danny-Hazelcast","html_url":"https://github.com/Danny-Hazelcast","followers_url":"https://api.github.com/users/Danny-Hazelcast/followers","following_url":"https://api.github.com/users/Danny-Hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/Danny-Hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/Danny-Hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Danny-Hazelcast/subscriptions","organizations_url":"https://api.github.com/users/Danny-Hazelcast/orgs","repos_url":"https://api.github.com/users/Danny-Hazelcast/repos","events_url":"https://api.github.com/users/Danny-Hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/Danny-Hazelcast/received_events","type":"User","site_admin":false},"body":"so you can squash the commits,  but a force push to a branch you all ready made a RP from and git hub seems to ignore it ","created_at":"2014-12-08T18:14:24Z","updated_at":"2014-12-09T08:45:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7d52fac60b96dc5aead94d32cdde2c7fb58bc3c6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/pulls/424/commits","review_comments_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/pulls/424/comments","review_comment_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/pulls/comments/{number}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/issues/424/comments","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/statuses/13708873dfa9a92088a6274d189d6247f5969bd7","head":{"label":"Danny-Hazelcast:jcacheMax2","ref":"jcacheMax2","sha":"13708873dfa9a92088a6274d189d6247f5969bd7","user":{"login":"Danny-Hazelcast","id":5988678,"avatar_url":"https://avatars.githubusercontent.com/u/5988678?v=3","gravatar_id":"","url":"https://api.github.com/users/Danny-Hazelcast","html_url":"https://github.com/Danny-Hazelcast","followers_url":"https://api.github.com/users/Danny-Hazelcast/followers","following_url":"https://api.github.com/users/Danny-Hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/Danny-Hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/Danny-Hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Danny-Hazelcast/subscriptions","organizations_url":"https://api.github.com/users/Danny-Hazelcast/orgs","repos_url":"https://api.github.com/users/Danny-Hazelcast/repos","events_url":"https://api.github.com/users/Danny-Hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/Danny-Hazelcast/received_events","type":"User","site_admin":false},"repo":{"id":19455541,"name":"hazelcast-stabilizer","full_name":"Danny-Hazelcast/hazelcast-stabilizer","owner":{"login":"Danny-Hazelcast","id":5988678,"avatar_url":"https://avatars.githubusercontent.com/u/5988678?v=3","gravatar_id":"","url":"https://api.github.com/users/Danny-Hazelcast","html_url":"https://github.com/Danny-Hazelcast","followers_url":"https://api.github.com/users/Danny-Hazelcast/followers","following_url":"https://api.github.com/users/Danny-Hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/Danny-Hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/Danny-Hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Danny-Hazelcast/subscriptions","organizations_url":"https://api.github.com/users/Danny-Hazelcast/orgs","repos_url":"https://api.github.com/users/Danny-Hazelcast/repos","events_url":"https://api.github.com/users/Danny-Hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/Danny-Hazelcast/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Danny-Hazelcast/hazelcast-stabilizer","description":"A tool for stress testing Hazelcast","fork":true,"url":"https://api.github.com/repos/Danny-Hazelcast/hazelcast-stabilizer","forks_url":"https://api.github.com/repos/Danny-Hazelcast/hazelcast-stabilizer/forks","keys_url":"https://api.github.com/repos/Danny-Hazelcast/hazelcast-stabilizer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Danny-Hazelcast/hazelcast-stabilizer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Danny-Hazelcast/hazelcast-stabilizer/teams","hooks_url":"https://api.github.com/repos/Danny-Hazelcast/hazelcast-stabilizer/hooks","issue_events_url":"https://api.github.com/repos/Danny-Hazelcast/hazelcast-stabilizer/issues/events{/number}","events_url":"https://api.github.com/repos/Danny-Hazelcast/hazelcast-stabilizer/events","assignees_url":"https://api.github.com/repos/Danny-Hazelcast/hazelcast-stabilizer/assignees{/user}","branches_url":"https://api.github.com/repos/Danny-Hazelcast/hazelcast-stabilizer/branches{/branch}","tags_url":"https://api.github.com/repos/Danny-Hazelcast/hazelcast-stabilizer/tags","blobs_url":"https://api.github.com/repos/Danny-Hazelcast/hazelcast-stabilizer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Danny-Hazelcast/hazelcast-stabilizer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Danny-Hazelcast/hazelcast-stabilizer/git/refs{/sha}","trees_url":"https://api.github.com/repos/Danny-Hazelcast/hazelcast-stabilizer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Danny-Hazelcast/hazelcast-stabilizer/statuses/{sha}","languages_url":"https://api.github.com/repos/Danny-Hazelcast/hazelcast-stabilizer/languages","stargazers_url":"https://api.github.com/repos/Danny-Hazelcast/hazelcast-stabilizer/stargazers","contributors_url":"https://api.github.com/repos/Danny-Hazelcast/hazelcast-stabilizer/contributors","subscribers_url":"https://api.github.com/repos/Danny-Hazelcast/hazelcast-stabilizer/subscribers","subscription_url":"https://api.github.com/repos/Danny-Hazelcast/hazelcast-stabilizer/subscription","commits_url":"https://api.github.com/repos/Danny-Hazelcast/hazelcast-stabilizer/commits{/sha}","git_commits_url":"https://api.github.com/repos/Danny-Hazelcast/hazelcast-stabilizer/git/commits{/sha}","comments_url":"https://api.github.com/repos/Danny-Hazelcast/hazelcast-stabilizer/comments{/number}","issue_comment_url":"https://api.github.com/repos/Danny-Hazelcast/hazelcast-stabilizer/issues/comments/{number}","contents_url":"https://api.github.com/repos/Danny-Hazelcast/hazelcast-stabilizer/contents/{+path}","compare_url":"https://api.github.com/repos/Danny-Hazelcast/hazelcast-stabilizer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Danny-Hazelcast/hazelcast-stabilizer/merges","archive_url":"https://api.github.com/repos/Danny-Hazelcast/hazelcast-stabilizer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Danny-Hazelcast/hazelcast-stabilizer/downloads","issues_url":"https://api.github.com/repos/Danny-Hazelcast/hazelcast-stabilizer/issues{/number}","pulls_url":"https://api.github.com/repos/Danny-Hazelcast/hazelcast-stabilizer/pulls{/number}","milestones_url":"https://api.github.com/repos/Danny-Hazelcast/hazelcast-stabilizer/milestones{/number}","notifications_url":"https://api.github.com/repos/Danny-Hazelcast/hazelcast-stabilizer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Danny-Hazelcast/hazelcast-stabilizer/labels{/name}","releases_url":"https://api.github.com/repos/Danny-Hazelcast/hazelcast-stabilizer/releases{/id}","created_at":"2014-05-05T12:50:45Z","updated_at":"2014-11-27T10:30:26Z","pushed_at":"2014-12-09T08:22:19Z","git_url":"git://github.com/Danny-Hazelcast/hazelcast-stabilizer.git","ssh_url":"git@github.com:Danny-Hazelcast/hazelcast-stabilizer.git","clone_url":"https://github.com/Danny-Hazelcast/hazelcast-stabilizer.git","svn_url":"https://github.com/Danny-Hazelcast/hazelcast-stabilizer","homepage":null,"size":8608,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hazelcast:master","ref":"master","sha":"3bfcf5f6e12d502ee2818ac06480f280b42d983b","user":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"repo":{"id":11445479,"name":"hazelcast-stabilizer","full_name":"hazelcast/hazelcast-stabilizer","owner":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hazelcast/hazelcast-stabilizer","description":"A tool for stress testing Hazelcast","fork":false,"url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer","forks_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/forks","keys_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/teams","hooks_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/hooks","issue_events_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/issues/events{/number}","events_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/events","assignees_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/assignees{/user}","branches_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/branches{/branch}","tags_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/tags","blobs_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/git/refs{/sha}","trees_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/statuses/{sha}","languages_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/languages","stargazers_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/stargazers","contributors_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/contributors","subscribers_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/subscribers","subscription_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/subscription","commits_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/commits{/sha}","git_commits_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/git/commits{/sha}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/comments{/number}","issue_comment_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/issues/comments/{number}","contents_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/contents/{+path}","compare_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/merges","archive_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/downloads","issues_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/issues{/number}","pulls_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/pulls{/number}","milestones_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/milestones{/number}","notifications_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/labels{/name}","releases_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/releases{/id}","created_at":"2013-07-16T09:18:54Z","updated_at":"2014-12-08T13:15:01Z","pushed_at":"2014-12-08T13:15:01Z","git_url":"git://github.com/hazelcast/hazelcast-stabilizer.git","ssh_url":"git@github.com:hazelcast/hazelcast-stabilizer.git","clone_url":"https://github.com/hazelcast/hazelcast-stabilizer.git","svn_url":"https://github.com/hazelcast/hazelcast-stabilizer","homepage":null,"size":11147,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":88,"forks":11,"open_issues":88,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/pulls/424"},"html":{"href":"https://github.com/hazelcast/hazelcast-stabilizer/pull/424"},"issue":{"href":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/issues/424"},"comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/issues/424/comments"},"review_comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/pulls/424/comments"},"review_comment":{"href":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/pulls/424/commits"},"statuses":{"href":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/statuses/13708873dfa9a92088a6274d189d6247f5969bd7"}}}}