GitHub PullRequestReviewCommentEvent at 2014-06-06 07:09:27
Repository: icpc-notebook
Actor: bmerry
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/bmerry/icpc-notebook/pulls/comments/13478573","id":13478573,"diff_hunk":"@@ -1,82 +0,0 @@\n-#include<bits/stdc++.h>\n-\n-#define x first\n-#define y second\n-#define EPS 1e-9\n-\n-using namespace std;\n-\n-typedef pair<double,double> pt;\n-\n-double d2(pt a, pt b)\n-{\n-\treturn (a.x-b.x)*(a.x-b.x)+(a.y-b.y)*(a.y-b.y);\n-}\n-\n-double ccw(pt a, pt b, pt c)\n-{\n-\treturn (b.x-a.x)*(c.y-b.y)-(b.y-a.y)*(c.x-b.x);\n-}\n-\n-//excluding points interior to sides of conv hull\n-//O(n log n)\n-vector<pt> conv_hull(vector<pt> inp)","path":"geometry/graham_scan/graham_scan.cpp","position":23,"original_position":23,"commit_id":"e24c44f706083253736cb7d05905b89d0915fa9e","original_commit_id":"e24c44f706083253736cb7d05905b89d0915fa9e","user":{"login":"bmerry","id":1963944,"avatar_url":"https://avatars.githubusercontent.com/u/1963944?","gravatar_id":"b40dd07aba6270c907f68d055cc5ede9","url":"https://api.github.com/users/bmerry","html_url":"https://github.com/bmerry","followers_url":"https://api.github.com/users/bmerry/followers","following_url":"https://api.github.com/users/bmerry/following{/other_user}","gists_url":"https://api.github.com/users/bmerry/gists{/gist_id}","starred_url":"https://api.github.com/users/bmerry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmerry/subscriptions","organizations_url":"https://api.github.com/users/bmerry/orgs","repos_url":"https://api.github.com/users/bmerry/repos","events_url":"https://api.github.com/users/bmerry/events{/privacy}","received_events_url":"https://api.github.com/users/bmerry/received_events","type":"User","site_admin":false},"body":"std::sort can go quite badly wrong if your comparator isn't a strict weak ordering. If you have dups, rather pre-filter them out - it keeps the convex hull code much simpler.","created_at":"2014-06-06T07:09:27Z","updated_at":"2014-06-06T07:09:27Z","html_url":"https://github.com/bmerry/icpc-notebook/pull/1#discussion_r13478573","pull_request_url":"https://api.github.com/repos/bmerry/icpc-notebook/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/bmerry/icpc-notebook/pulls/comments/13478573"},"html":{"href":"https://github.com/bmerry/icpc-notebook/pull/1#discussion_r13478573"},"pull_request":{"href":"https://api.github.com/repos/bmerry/icpc-notebook/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/bmerry/icpc-notebook/pulls/1","id":16704725,"html_url":"https://github.com/bmerry/icpc-notebook/pull/1","diff_url":"https://github.com/bmerry/icpc-notebook/pull/1.diff","patch_url":"https://github.com/bmerry/icpc-notebook/pull/1.patch","issue_url":"https://api.github.com/repos/bmerry/icpc-notebook/issues/1","number":1,"state":"open","title":"Review of the current code","user":{"login":"bmerry","id":1963944,"avatar_url":"https://avatars.githubusercontent.com/u/1963944?","gravatar_id":"b40dd07aba6270c907f68d055cc5ede9","url":"https://api.github.com/users/bmerry","html_url":"https://github.com/bmerry","followers_url":"https://api.github.com/users/bmerry/followers","following_url":"https://api.github.com/users/bmerry/following{/other_user}","gists_url":"https://api.github.com/users/bmerry/gists{/gist_id}","starred_url":"https://api.github.com/users/bmerry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmerry/subscriptions","organizations_url":"https://api.github.com/users/bmerry/orgs","repos_url":"https://api.github.com/users/bmerry/repos","events_url":"https://api.github.com/users/bmerry/events{/privacy}","received_events_url":"https://api.github.com/users/bmerry/received_events","type":"User","site_admin":false},"body":"This is necessary to allow github comments on all the code. Don't\r\nactually merge this!","created_at":"2014-06-04T12:08:54Z","updated_at":"2014-06-06T07:09:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"014e1b763fae4b286e4f6de745674cbf1db38225","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bmerry/icpc-notebook/pulls/1/commits","review_comments_url":"https://api.github.com/repos/bmerry/icpc-notebook/pulls/1/comments","review_comment_url":"https://api.github.com/repos/bmerry/icpc-notebook/pulls/comments/{number}","comments_url":"https://api.github.com/repos/bmerry/icpc-notebook/issues/1/comments","statuses_url":"https://api.github.com/repos/bmerry/icpc-notebook/statuses/e24c44f706083253736cb7d05905b89d0915fa9e","head":{"label":"bmerry:rm_all","ref":"rm_all","sha":"e24c44f706083253736cb7d05905b89d0915fa9e","user":{"login":"bmerry","id":1963944,"avatar_url":"https://avatars.githubusercontent.com/u/1963944?","gravatar_id":"b40dd07aba6270c907f68d055cc5ede9","url":"https://api.github.com/users/bmerry","html_url":"https://github.com/bmerry","followers_url":"https://api.github.com/users/bmerry/followers","following_url":"https://api.github.com/users/bmerry/following{/other_user}","gists_url":"https://api.github.com/users/bmerry/gists{/gist_id}","starred_url":"https://api.github.com/users/bmerry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmerry/subscriptions","organizations_url":"https://api.github.com/users/bmerry/orgs","repos_url":"https://api.github.com/users/bmerry/repos","events_url":"https://api.github.com/users/bmerry/events{/privacy}","received_events_url":"https://api.github.com/users/bmerry/received_events","type":"User","site_admin":false},"repo":{"id":20481425,"name":"icpc-notebook","full_name":"bmerry/icpc-notebook","owner":{"login":"bmerry","id":1963944,"avatar_url":"https://avatars.githubusercontent.com/u/1963944?","gravatar_id":"b40dd07aba6270c907f68d055cc5ede9","url":"https://api.github.com/users/bmerry","html_url":"https://github.com/bmerry","followers_url":"https://api.github.com/users/bmerry/followers","following_url":"https://api.github.com/users/bmerry/following{/other_user}","gists_url":"https://api.github.com/users/bmerry/gists{/gist_id}","starred_url":"https://api.github.com/users/bmerry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmerry/subscriptions","organizations_url":"https://api.github.com/users/bmerry/orgs","repos_url":"https://api.github.com/users/bmerry/repos","events_url":"https://api.github.com/users/bmerry/events{/privacy}","received_events_url":"https://api.github.com/users/bmerry/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bmerry/icpc-notebook","description":"A whole lot of code for potential inclusion in the UCT 2014 ICPC Team notebook.","fork":true,"url":"https://api.github.com/repos/bmerry/icpc-notebook","forks_url":"https://api.github.com/repos/bmerry/icpc-notebook/forks","keys_url":"https://api.github.com/repos/bmerry/icpc-notebook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bmerry/icpc-notebook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bmerry/icpc-notebook/teams","hooks_url":"https://api.github.com/repos/bmerry/icpc-notebook/hooks","issue_events_url":"https://api.github.com/repos/bmerry/icpc-notebook/issues/events{/number}","events_url":"https://api.github.com/repos/bmerry/icpc-notebook/events","assignees_url":"https://api.github.com/repos/bmerry/icpc-notebook/assignees{/user}","branches_url":"https://api.github.com/repos/bmerry/icpc-notebook/branches{/branch}","tags_url":"https://api.github.com/repos/bmerry/icpc-notebook/tags","blobs_url":"https://api.github.com/repos/bmerry/icpc-notebook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bmerry/icpc-notebook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bmerry/icpc-notebook/git/refs{/sha}","trees_url":"https://api.github.com/repos/bmerry/icpc-notebook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bmerry/icpc-notebook/statuses/{sha}","languages_url":"https://api.github.com/repos/bmerry/icpc-notebook/languages","stargazers_url":"https://api.github.com/repos/bmerry/icpc-notebook/stargazers","contributors_url":"https://api.github.com/repos/bmerry/icpc-notebook/contributors","subscribers_url":"https://api.github.com/repos/bmerry/icpc-notebook/subscribers","subscription_url":"https://api.github.com/repos/bmerry/icpc-notebook/subscription","commits_url":"https://api.github.com/repos/bmerry/icpc-notebook/commits{/sha}","git_commits_url":"https://api.github.com/repos/bmerry/icpc-notebook/git/commits{/sha}","comments_url":"https://api.github.com/repos/bmerry/icpc-notebook/comments{/number}","issue_comment_url":"https://api.github.com/repos/bmerry/icpc-notebook/issues/comments/{number}","contents_url":"https://api.github.com/repos/bmerry/icpc-notebook/contents/{+path}","compare_url":"https://api.github.com/repos/bmerry/icpc-notebook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bmerry/icpc-notebook/merges","archive_url":"https://api.github.com/repos/bmerry/icpc-notebook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bmerry/icpc-notebook/downloads","issues_url":"https://api.github.com/repos/bmerry/icpc-notebook/issues{/number}","pulls_url":"https://api.github.com/repos/bmerry/icpc-notebook/pulls{/number}","milestones_url":"https://api.github.com/repos/bmerry/icpc-notebook/milestones{/number}","notifications_url":"https://api.github.com/repos/bmerry/icpc-notebook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bmerry/icpc-notebook/labels{/name}","releases_url":"https://api.github.com/repos/bmerry/icpc-notebook/releases{/id}","created_at":"2014-06-04T11:52:59Z","updated_at":"2014-06-04T12:08:54Z","pushed_at":"2014-06-04T12:01:38Z","git_url":"git://github.com/bmerry/icpc-notebook.git","ssh_url":"git@github.com:bmerry/icpc-notebook.git","clone_url":"https://github.com/bmerry/icpc-notebook.git","svn_url":"https://github.com/bmerry/icpc-notebook","homepage":null,"size":162,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"bmerry:master","ref":"master","sha":"ab92f4fb70fdc449b1ca58a61a13b59bf01d0e43","user":{"login":"bmerry","id":1963944,"avatar_url":"https://avatars.githubusercontent.com/u/1963944?","gravatar_id":"b40dd07aba6270c907f68d055cc5ede9","url":"https://api.github.com/users/bmerry","html_url":"https://github.com/bmerry","followers_url":"https://api.github.com/users/bmerry/followers","following_url":"https://api.github.com/users/bmerry/following{/other_user}","gists_url":"https://api.github.com/users/bmerry/gists{/gist_id}","starred_url":"https://api.github.com/users/bmerry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmerry/subscriptions","organizations_url":"https://api.github.com/users/bmerry/orgs","repos_url":"https://api.github.com/users/bmerry/repos","events_url":"https://api.github.com/users/bmerry/events{/privacy}","received_events_url":"https://api.github.com/users/bmerry/received_events","type":"User","site_admin":false},"repo":{"id":20481425,"name":"icpc-notebook","full_name":"bmerry/icpc-notebook","owner":{"login":"bmerry","id":1963944,"avatar_url":"https://avatars.githubusercontent.com/u/1963944?","gravatar_id":"b40dd07aba6270c907f68d055cc5ede9","url":"https://api.github.com/users/bmerry","html_url":"https://github.com/bmerry","followers_url":"https://api.github.com/users/bmerry/followers","following_url":"https://api.github.com/users/bmerry/following{/other_user}","gists_url":"https://api.github.com/users/bmerry/gists{/gist_id}","starred_url":"https://api.github.com/users/bmerry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmerry/subscriptions","organizations_url":"https://api.github.com/users/bmerry/orgs","repos_url":"https://api.github.com/users/bmerry/repos","events_url":"https://api.github.com/users/bmerry/events{/privacy}","received_events_url":"https://api.github.com/users/bmerry/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bmerry/icpc-notebook","description":"A whole lot of code for potential inclusion in the UCT 2014 ICPC Team notebook.","fork":true,"url":"https://api.github.com/repos/bmerry/icpc-notebook","forks_url":"https://api.github.com/repos/bmerry/icpc-notebook/forks","keys_url":"https://api.github.com/repos/bmerry/icpc-notebook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bmerry/icpc-notebook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bmerry/icpc-notebook/teams","hooks_url":"https://api.github.com/repos/bmerry/icpc-notebook/hooks","issue_events_url":"https://api.github.com/repos/bmerry/icpc-notebook/issues/events{/number}","events_url":"https://api.github.com/repos/bmerry/icpc-notebook/events","assignees_url":"https://api.github.com/repos/bmerry/icpc-notebook/assignees{/user}","branches_url":"https://api.github.com/repos/bmerry/icpc-notebook/branches{/branch}","tags_url":"https://api.github.com/repos/bmerry/icpc-notebook/tags","blobs_url":"https://api.github.com/repos/bmerry/icpc-notebook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bmerry/icpc-notebook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bmerry/icpc-notebook/git/refs{/sha}","trees_url":"https://api.github.com/repos/bmerry/icpc-notebook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bmerry/icpc-notebook/statuses/{sha}","languages_url":"https://api.github.com/repos/bmerry/icpc-notebook/languages","stargazers_url":"https://api.github.com/repos/bmerry/icpc-notebook/stargazers","contributors_url":"https://api.github.com/repos/bmerry/icpc-notebook/contributors","subscribers_url":"https://api.github.com/repos/bmerry/icpc-notebook/subscribers","subscription_url":"https://api.github.com/repos/bmerry/icpc-notebook/subscription","commits_url":"https://api.github.com/repos/bmerry/icpc-notebook/commits{/sha}","git_commits_url":"https://api.github.com/repos/bmerry/icpc-notebook/git/commits{/sha}","comments_url":"https://api.github.com/repos/bmerry/icpc-notebook/comments{/number}","issue_comment_url":"https://api.github.com/repos/bmerry/icpc-notebook/issues/comments/{number}","contents_url":"https://api.github.com/repos/bmerry/icpc-notebook/contents/{+path}","compare_url":"https://api.github.com/repos/bmerry/icpc-notebook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bmerry/icpc-notebook/merges","archive_url":"https://api.github.com/repos/bmerry/icpc-notebook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bmerry/icpc-notebook/downloads","issues_url":"https://api.github.com/repos/bmerry/icpc-notebook/issues{/number}","pulls_url":"https://api.github.com/repos/bmerry/icpc-notebook/pulls{/number}","milestones_url":"https://api.github.com/repos/bmerry/icpc-notebook/milestones{/number}","notifications_url":"https://api.github.com/repos/bmerry/icpc-notebook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bmerry/icpc-notebook/labels{/name}","releases_url":"https://api.github.com/repos/bmerry/icpc-notebook/releases{/id}","created_at":"2014-06-04T11:52:59Z","updated_at":"2014-06-04T12:08:54Z","pushed_at":"2014-06-04T12:01:38Z","git_url":"git://github.com/bmerry/icpc-notebook.git","ssh_url":"git@github.com:bmerry/icpc-notebook.git","clone_url":"https://github.com/bmerry/icpc-notebook.git","svn_url":"https://github.com/bmerry/icpc-notebook","homepage":null,"size":162,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bmerry/icpc-notebook/pulls/1"},"html":{"href":"https://github.com/bmerry/icpc-notebook/pull/1"},"issue":{"href":"https://api.github.com/repos/bmerry/icpc-notebook/issues/1"},"comments":{"href":"https://api.github.com/repos/bmerry/icpc-notebook/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/bmerry/icpc-notebook/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/bmerry/icpc-notebook/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/bmerry/icpc-notebook/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/bmerry/icpc-notebook/statuses/e24c44f706083253736cb7d05905b89d0915fa9e"}}}}