GitHub PullRequestReviewCommentEvent at 2014-09-02 15:03:40
Repository: push-api
Actor: beverloo
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/w3c/push-api/pulls/comments/16992276","id":16992276,"diff_hunk":"@@ -1030,7 +1048,31 @@\n     \n   </section>\n \n-\n+<!************************* Enumerations  **********************************>\n+  <section>\n+    <h2>Enumerations</h2>\n+\n+    <dl class=\"idl\" title=\"enum PushPermissionStatus\">\n+          <dt>granted</dt>\n+          <dd>\n+              The <a class=\"internalDFN\" href=\"#dfn-webapp\">webapp</a> has\n+              permission to use Push API.\n+          </dd>\n+\n+          <dt>denied</dt>\n+          <dd>\n+              The <a class=\"internalDFN\" href=\"#dfn-webapp\">webapp</a> has been\n+              denied permission to use Push API.\n+          </dd>\n+\n+          <dt>needToAsk</dt>","path":"index.html","position":133,"original_position":133,"commit_id":"1df6cece51688a54ce92259a224731b1ffbe3cd4","original_commit_id":"1df6cece51688a54ce92259a224731b1ffbe3cd4","user":{"login":"beverloo","id":418835,"avatar_url":"https://avatars.githubusercontent.com/u/418835?v=2","gravatar_id":"380872667fd950e5ef2db8b6fabbb69d","url":"https://api.github.com/users/beverloo","html_url":"https://github.com/beverloo","followers_url":"https://api.github.com/users/beverloo/followers","following_url":"https://api.github.com/users/beverloo/following{/other_user}","gists_url":"https://api.github.com/users/beverloo/gists{/gist_id}","starred_url":"https://api.github.com/users/beverloo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beverloo/subscriptions","organizations_url":"https://api.github.com/users/beverloo/orgs","repos_url":"https://api.github.com/users/beverloo/repos","events_url":"https://api.github.com/users/beverloo/events{/privacy}","received_events_url":"https://api.github.com/users/beverloo/received_events","type":"User","site_admin":false},"body":"The Web Notification API uses \"default\" for this, Mounir proposed a Permissions API to DAP today that uses \"prompt\", you're introducing \"needToAsk\" :-).\r\n\r\nCould we settle on a single keyword? While I'm a fan of \"prompt\", \"default\" is already out there.\r\n\r\n@mounirlamouri ","created_at":"2014-09-02T15:03:40Z","updated_at":"2014-09-02T15:03:40Z","html_url":"https://github.com/w3c/push-api/pull/13#discussion_r16992276","pull_request_url":"https://api.github.com/repos/w3c/push-api/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/w3c/push-api/pulls/comments/16992276"},"html":{"href":"https://github.com/w3c/push-api/pull/13#discussion_r16992276"},"pull_request":{"href":"https://api.github.com/repos/w3c/push-api/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/w3c/push-api/pulls/13","id":19717004,"html_url":"https://github.com/w3c/push-api/pull/13","diff_url":"https://github.com/w3c/push-api/pull/13.diff","patch_url":"https://github.com/w3c/push-api/pull/13.patch","issue_url":"https://api.github.com/repos/w3c/push-api/issues/13","number":13,"state":"open","locked":false,"title":"Push manager. Fixes issue #2","user":{"login":"efullea","id":1729054,"avatar_url":"https://avatars.githubusercontent.com/u/1729054?v=2","gravatar_id":"2b18678f19e4ee95d861ae2a23d43698","url":"https://api.github.com/users/efullea","html_url":"https://github.com/efullea","followers_url":"https://api.github.com/users/efullea/followers","following_url":"https://api.github.com/users/efullea/following{/other_user}","gists_url":"https://api.github.com/users/efullea/gists{/gist_id}","starred_url":"https://api.github.com/users/efullea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/efullea/subscriptions","organizations_url":"https://api.github.com/users/efullea/orgs","repos_url":"https://api.github.com/users/efullea/repos","events_url":"https://api.github.com/users/efullea/events{/privacy}","received_events_url":"https://api.github.com/users/efullea/received_events","type":"User","site_admin":false},"body":"Changes:\r\n-Move pushRegistrationManager to ServiceWorkerRegistration (Fixes issue #2)\r\n-PushManager --> PushRegistrationManager\r\n-Adding PushRegistrationManager.hasPermission","created_at":"2014-08-13T10:55:08Z","updated_at":"2014-09-02T15:03:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1fc0ea6495aaa968bb9fd6279bcb60f4f4f7ce35","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/w3c/push-api/pulls/13/commits","review_comments_url":"https://api.github.com/repos/w3c/push-api/pulls/13/comments","review_comment_url":"https://api.github.com/repos/w3c/push-api/pulls/comments/{number}","comments_url":"https://api.github.com/repos/w3c/push-api/issues/13/comments","statuses_url":"https://api.github.com/repos/w3c/push-api/statuses/1df6cece51688a54ce92259a224731b1ffbe3cd4","head":{"label":"efullea:pushManager","ref":"pushManager","sha":"1df6cece51688a54ce92259a224731b1ffbe3cd4","user":{"login":"efullea","id":1729054,"avatar_url":"https://avatars.githubusercontent.com/u/1729054?v=2","gravatar_id":"2b18678f19e4ee95d861ae2a23d43698","url":"https://api.github.com/users/efullea","html_url":"https://github.com/efullea","followers_url":"https://api.github.com/users/efullea/followers","following_url":"https://api.github.com/users/efullea/following{/other_user}","gists_url":"https://api.github.com/users/efullea/gists{/gist_id}","starred_url":"https://api.github.com/users/efullea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/efullea/subscriptions","organizations_url":"https://api.github.com/users/efullea/orgs","repos_url":"https://api.github.com/users/efullea/repos","events_url":"https://api.github.com/users/efullea/events{/privacy}","received_events_url":"https://api.github.com/users/efullea/received_events","type":"User","site_admin":false},"repo":{"id":22753073,"name":"push-api","full_name":"efullea/push-api","owner":{"login":"efullea","id":1729054,"avatar_url":"https://avatars.githubusercontent.com/u/1729054?v=2","gravatar_id":"2b18678f19e4ee95d861ae2a23d43698","url":"https://api.github.com/users/efullea","html_url":"https://github.com/efullea","followers_url":"https://api.github.com/users/efullea/followers","following_url":"https://api.github.com/users/efullea/following{/other_user}","gists_url":"https://api.github.com/users/efullea/gists{/gist_id}","starred_url":"https://api.github.com/users/efullea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/efullea/subscriptions","organizations_url":"https://api.github.com/users/efullea/orgs","repos_url":"https://api.github.com/users/efullea/repos","events_url":"https://api.github.com/users/efullea/events{/privacy}","received_events_url":"https://api.github.com/users/efullea/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/efullea/push-api","description":"","fork":true,"url":"https://api.github.com/repos/efullea/push-api","forks_url":"https://api.github.com/repos/efullea/push-api/forks","keys_url":"https://api.github.com/repos/efullea/push-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/efullea/push-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/efullea/push-api/teams","hooks_url":"https://api.github.com/repos/efullea/push-api/hooks","issue_events_url":"https://api.github.com/repos/efullea/push-api/issues/events{/number}","events_url":"https://api.github.com/repos/efullea/push-api/events","assignees_url":"https://api.github.com/repos/efullea/push-api/assignees{/user}","branches_url":"https://api.github.com/repos/efullea/push-api/branches{/branch}","tags_url":"https://api.github.com/repos/efullea/push-api/tags","blobs_url":"https://api.github.com/repos/efullea/push-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/efullea/push-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/efullea/push-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/efullea/push-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/efullea/push-api/statuses/{sha}","languages_url":"https://api.github.com/repos/efullea/push-api/languages","stargazers_url":"https://api.github.com/repos/efullea/push-api/stargazers","contributors_url":"https://api.github.com/repos/efullea/push-api/contributors","subscribers_url":"https://api.github.com/repos/efullea/push-api/subscribers","subscription_url":"https://api.github.com/repos/efullea/push-api/subscription","commits_url":"https://api.github.com/repos/efullea/push-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/efullea/push-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/efullea/push-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/efullea/push-api/issues/comments/{number}","contents_url":"https://api.github.com/repos/efullea/push-api/contents/{+path}","compare_url":"https://api.github.com/repos/efullea/push-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/efullea/push-api/merges","archive_url":"https://api.github.com/repos/efullea/push-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/efullea/push-api/downloads","issues_url":"https://api.github.com/repos/efullea/push-api/issues{/number}","pulls_url":"https://api.github.com/repos/efullea/push-api/pulls{/number}","milestones_url":"https://api.github.com/repos/efullea/push-api/milestones{/number}","notifications_url":"https://api.github.com/repos/efullea/push-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/efullea/push-api/labels{/name}","releases_url":"https://api.github.com/repos/efullea/push-api/releases{/id}","created_at":"2014-08-08T09:37:18Z","updated_at":"2014-08-13T06:21:45Z","pushed_at":"2014-08-20T10:47:55Z","git_url":"git://github.com/efullea/push-api.git","ssh_url":"git@github.com:efullea/push-api.git","clone_url":"https://github.com/efullea/push-api.git","svn_url":"https://github.com/efullea/push-api","homepage":null,"size":213,"stargazers_count":1,"watchers_count":1,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"gh-pages"}},"base":{"label":"w3c:gh-pages","ref":"gh-pages","sha":"d80f82a1a66473968f2f36a41c548c7125a57297","user":{"login":"w3c","id":379216,"avatar_url":"https://avatars.githubusercontent.com/u/379216?v=2","gravatar_id":"85dfda2c583d777a50eb433f6aab289f","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"repo":{"id":19316848,"name":"push-api","full_name":"w3c/push-api","owner":{"login":"w3c","id":379216,"avatar_url":"https://avatars.githubusercontent.com/u/379216?v=2","gravatar_id":"85dfda2c583d777a50eb433f6aab289f","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/w3c/push-api","description":"","fork":false,"url":"https://api.github.com/repos/w3c/push-api","forks_url":"https://api.github.com/repos/w3c/push-api/forks","keys_url":"https://api.github.com/repos/w3c/push-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/w3c/push-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/w3c/push-api/teams","hooks_url":"https://api.github.com/repos/w3c/push-api/hooks","issue_events_url":"https://api.github.com/repos/w3c/push-api/issues/events{/number}","events_url":"https://api.github.com/repos/w3c/push-api/events","assignees_url":"https://api.github.com/repos/w3c/push-api/assignees{/user}","branches_url":"https://api.github.com/repos/w3c/push-api/branches{/branch}","tags_url":"https://api.github.com/repos/w3c/push-api/tags","blobs_url":"https://api.github.com/repos/w3c/push-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/w3c/push-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/w3c/push-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/w3c/push-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/w3c/push-api/statuses/{sha}","languages_url":"https://api.github.com/repos/w3c/push-api/languages","stargazers_url":"https://api.github.com/repos/w3c/push-api/stargazers","contributors_url":"https://api.github.com/repos/w3c/push-api/contributors","subscribers_url":"https://api.github.com/repos/w3c/push-api/subscribers","subscription_url":"https://api.github.com/repos/w3c/push-api/subscription","commits_url":"https://api.github.com/repos/w3c/push-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/w3c/push-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/w3c/push-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/w3c/push-api/issues/comments/{number}","contents_url":"https://api.github.com/repos/w3c/push-api/contents/{+path}","compare_url":"https://api.github.com/repos/w3c/push-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/w3c/push-api/merges","archive_url":"https://api.github.com/repos/w3c/push-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/w3c/push-api/downloads","issues_url":"https://api.github.com/repos/w3c/push-api/issues{/number}","pulls_url":"https://api.github.com/repos/w3c/push-api/pulls{/number}","milestones_url":"https://api.github.com/repos/w3c/push-api/milestones{/number}","notifications_url":"https://api.github.com/repos/w3c/push-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/w3c/push-api/labels{/name}","releases_url":"https://api.github.com/repos/w3c/push-api/releases{/id}","created_at":"2014-04-30T14:46:01Z","updated_at":"2014-08-30T07:48:25Z","pushed_at":"2014-09-01T05:46:39Z","git_url":"git://github.com/w3c/push-api.git","ssh_url":"git@github.com:w3c/push-api.git","clone_url":"https://github.com/w3c/push-api.git","svn_url":"https://github.com/w3c/push-api","homepage":null,"size":363,"stargazers_count":8,"watchers_count":8,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":7,"mirror_url":null,"open_issues_count":18,"forks":7,"open_issues":18,"watchers":8,"default_branch":"gh-pages"}},"_links":{"self":{"href":"https://api.github.com/repos/w3c/push-api/pulls/13"},"html":{"href":"https://github.com/w3c/push-api/pull/13"},"issue":{"href":"https://api.github.com/repos/w3c/push-api/issues/13"},"comments":{"href":"https://api.github.com/repos/w3c/push-api/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/w3c/push-api/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/w3c/push-api/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/w3c/push-api/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/w3c/push-api/statuses/1df6cece51688a54ce92259a224731b1ffbe3cd4"}}}}