GitHub PullRequestReviewCommentEvent at 2014-09-29 03:07:38
Repository: angular-google-maps
Actor: nmccready
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/angular-ui/angular-google-maps/pulls/comments/18135888","id":18135888,"diff_hunk":"@@ -175,9 +176,17 @@ module.exports = (grunt) ->\n         dest: 'tmp/wrapped_libs.js'\n       uuid:\n         options:\n-          patterns: [match: 'REPLACE_W_LIBS', replacement: '<%= grunt.file.read(\"bower_components/uuid/dist/uuid.core.js\") %>']\n+          patterns: [\n+            match: 'REPLACE_W_LIBS',\n+            replacement: '<%= grunt.file.read(\"bower_components/uuid/dist/uuid.core.js\") %>'\n+          ]\n         src: 'src/js/wrapped/uuid.core.js'\n         dest: 'tmp/wrapped_uuid.js'\n \n+    subgrunt:","path":"GruntOptions.coffee","position":20,"original_position":20,"commit_id":"59e681a3893918d484ddd1b6f7a69247032dc4a9","original_commit_id":"59e681a3893918d484ddd1b6f7a69247032dc4a9","user":{"login":"nmccready","id":583593,"avatar_url":"https://avatars.githubusercontent.com/u/583593?v=2","gravatar_id":"","url":"https://api.github.com/users/nmccready","html_url":"https://github.com/nmccready","followers_url":"https://api.github.com/users/nmccready/followers","following_url":"https://api.github.com/users/nmccready/following{/other_user}","gists_url":"https://api.github.com/users/nmccready/gists{/gist_id}","starred_url":"https://api.github.com/users/nmccready/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmccready/subscriptions","organizations_url":"https://api.github.com/users/nmccready/orgs","repos_url":"https://api.github.com/users/nmccready/repos","events_url":"https://api.github.com/users/nmccready/events{/privacy}","received_events_url":"https://api.github.com/users/nmccready/received_events","type":"User","site_admin":false},"body":"in case we decide we want to wrapp bluebird as a bare min wrapped service","created_at":"2014-09-29T03:07:38Z","updated_at":"2014-09-29T03:07:38Z","html_url":"https://github.com/angular-ui/angular-google-maps/pull/723#discussion_r18135888","pull_request_url":"https://api.github.com/repos/angular-ui/angular-google-maps/pulls/723","_links":{"self":{"href":"https://api.github.com/repos/angular-ui/angular-google-maps/pulls/comments/18135888"},"html":{"href":"https://github.com/angular-ui/angular-google-maps/pull/723#discussion_r18135888"},"pull_request":{"href":"https://api.github.com/repos/angular-ui/angular-google-maps/pulls/723"}}},"pull_request":{"url":"https://api.github.com/repos/angular-ui/angular-google-maps/pulls/723","id":21911592,"html_url":"https://github.com/angular-ui/angular-google-maps/pull/723","diff_url":"https://github.com/angular-ui/angular-google-maps/pull/723.diff","patch_url":"https://github.com/angular-ui/angular-google-maps/pull/723.patch","issue_url":"https://api.github.com/repos/angular-ui/angular-google-maps/issues/723","number":723,"state":"open","locked":false,"title":"issue 621/async promise chunking","user":{"login":"nmccready","id":583593,"avatar_url":"https://avatars.githubusercontent.com/u/583593?v=2","gravatar_id":"","url":"https://api.github.com/users/nmccready","html_url":"https://github.com/nmccready","followers_url":"https://api.github.com/users/nmccready/followers","following_url":"https://api.github.com/users/nmccready/following{/other_user}","gists_url":"https://api.github.com/users/nmccready/gists{/gist_id}","starred_url":"https://api.github.com/users/nmccready/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmccready/subscriptions","organizations_url":"https://api.github.com/users/nmccready/orgs","repos_url":"https://api.github.com/users/nmccready/repos","events_url":"https://api.github.com/users/nmccready/events{/privacy}","received_events_url":"https://api.github.com/users/nmccready/received_events","type":"User","site_admin":false},"body":"@gitnik @cthrax \r\n\r\nI chose bluebird as it is known to be faster, I also got tired of trying to make $q work on specs. All the rootscope.$apply()'s were having no effect on digest cycles. Maybe you guys can tell me where to correct it? Otherwise we gain an external dependency.\r\n\r\nplease review.","created_at":"2014-09-29T03:06:45Z","updated_at":"2014-09-29T03:07:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"90a969cc12f19b182a6ab79f6d7f70dd43164b0e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/angular-ui/angular-google-maps/pulls/723/commits","review_comments_url":"https://api.github.com/repos/angular-ui/angular-google-maps/pulls/723/comments","review_comment_url":"https://api.github.com/repos/angular-ui/angular-google-maps/pulls/comments/{number}","comments_url":"https://api.github.com/repos/angular-ui/angular-google-maps/issues/723/comments","statuses_url":"https://api.github.com/repos/angular-ui/angular-google-maps/statuses/59e681a3893918d484ddd1b6f7a69247032dc4a9","head":{"label":"nmccready:nick_mc/issue-621/async_promise_chunking","ref":"nick_mc/issue-621/async_promise_chunking","sha":"59e681a3893918d484ddd1b6f7a69247032dc4a9","user":{"login":"nmccready","id":583593,"avatar_url":"https://avatars.githubusercontent.com/u/583593?v=2","gravatar_id":"","url":"https://api.github.com/users/nmccready","html_url":"https://github.com/nmccready","followers_url":"https://api.github.com/users/nmccready/followers","following_url":"https://api.github.com/users/nmccready/following{/other_user}","gists_url":"https://api.github.com/users/nmccready/gists{/gist_id}","starred_url":"https://api.github.com/users/nmccready/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmccready/subscriptions","organizations_url":"https://api.github.com/users/nmccready/orgs","repos_url":"https://api.github.com/users/nmccready/repos","events_url":"https://api.github.com/users/nmccready/events{/privacy}","received_events_url":"https://api.github.com/users/nmccready/received_events","type":"User","site_admin":false},"repo":{"id":24297353,"name":"angular-google-maps","full_name":"nmccready/angular-google-maps","owner":{"login":"nmccready","id":583593,"avatar_url":"https://avatars.githubusercontent.com/u/583593?v=2","gravatar_id":"","url":"https://api.github.com/users/nmccready","html_url":"https://github.com/nmccready","followers_url":"https://api.github.com/users/nmccready/followers","following_url":"https://api.github.com/users/nmccready/following{/other_user}","gists_url":"https://api.github.com/users/nmccready/gists{/gist_id}","starred_url":"https://api.github.com/users/nmccready/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmccready/subscriptions","organizations_url":"https://api.github.com/users/nmccready/orgs","repos_url":"https://api.github.com/users/nmccready/repos","events_url":"https://api.github.com/users/nmccready/events{/privacy}","received_events_url":"https://api.github.com/users/nmccready/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nmccready/angular-google-maps","description":"AngularJS directives for the Google Maps Javascript API","fork":true,"url":"https://api.github.com/repos/nmccready/angular-google-maps","forks_url":"https://api.github.com/repos/nmccready/angular-google-maps/forks","keys_url":"https://api.github.com/repos/nmccready/angular-google-maps/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nmccready/angular-google-maps/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nmccready/angular-google-maps/teams","hooks_url":"https://api.github.com/repos/nmccready/angular-google-maps/hooks","issue_events_url":"https://api.github.com/repos/nmccready/angular-google-maps/issues/events{/number}","events_url":"https://api.github.com/repos/nmccready/angular-google-maps/events","assignees_url":"https://api.github.com/repos/nmccready/angular-google-maps/assignees{/user}","branches_url":"https://api.github.com/repos/nmccready/angular-google-maps/branches{/branch}","tags_url":"https://api.github.com/repos/nmccready/angular-google-maps/tags","blobs_url":"https://api.github.com/repos/nmccready/angular-google-maps/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nmccready/angular-google-maps/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nmccready/angular-google-maps/git/refs{/sha}","trees_url":"https://api.github.com/repos/nmccready/angular-google-maps/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nmccready/angular-google-maps/statuses/{sha}","languages_url":"https://api.github.com/repos/nmccready/angular-google-maps/languages","stargazers_url":"https://api.github.com/repos/nmccready/angular-google-maps/stargazers","contributors_url":"https://api.github.com/repos/nmccready/angular-google-maps/contributors","subscribers_url":"https://api.github.com/repos/nmccready/angular-google-maps/subscribers","subscription_url":"https://api.github.com/repos/nmccready/angular-google-maps/subscription","commits_url":"https://api.github.com/repos/nmccready/angular-google-maps/commits{/sha}","git_commits_url":"https://api.github.com/repos/nmccready/angular-google-maps/git/commits{/sha}","comments_url":"https://api.github.com/repos/nmccready/angular-google-maps/comments{/number}","issue_comment_url":"https://api.github.com/repos/nmccready/angular-google-maps/issues/comments/{number}","contents_url":"https://api.github.com/repos/nmccready/angular-google-maps/contents/{+path}","compare_url":"https://api.github.com/repos/nmccready/angular-google-maps/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nmccready/angular-google-maps/merges","archive_url":"https://api.github.com/repos/nmccready/angular-google-maps/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nmccready/angular-google-maps/downloads","issues_url":"https://api.github.com/repos/nmccready/angular-google-maps/issues{/number}","pulls_url":"https://api.github.com/repos/nmccready/angular-google-maps/pulls{/number}","milestones_url":"https://api.github.com/repos/nmccready/angular-google-maps/milestones{/number}","notifications_url":"https://api.github.com/repos/nmccready/angular-google-maps/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nmccready/angular-google-maps/labels{/name}","releases_url":"https://api.github.com/repos/nmccready/angular-google-maps/releases{/id}","created_at":"2014-09-21T17:10:43Z","updated_at":"2014-09-21T17:09:40Z","pushed_at":"2014-09-29T03:04:56Z","git_url":"git://github.com/nmccready/angular-google-maps.git","ssh_url":"git@github.com:nmccready/angular-google-maps.git","clone_url":"https://github.com/nmccready/angular-google-maps.git","svn_url":"https://github.com/nmccready/angular-google-maps","homepage":null,"size":10032,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular-ui:develop","ref":"develop","sha":"2b149acdce56b0e51bc75751f601bd452f4c0490","user":{"login":"angular-ui","id":1530011,"avatar_url":"https://avatars.githubusercontent.com/u/1530011?v=2","gravatar_id":"","url":"https://api.github.com/users/angular-ui","html_url":"https://github.com/angular-ui","followers_url":"https://api.github.com/users/angular-ui/followers","following_url":"https://api.github.com/users/angular-ui/following{/other_user}","gists_url":"https://api.github.com/users/angular-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/angular-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular-ui/subscriptions","organizations_url":"https://api.github.com/users/angular-ui/orgs","repos_url":"https://api.github.com/users/angular-ui/repos","events_url":"https://api.github.com/users/angular-ui/events{/privacy}","received_events_url":"https://api.github.com/users/angular-ui/received_events","type":"Organization","site_admin":false},"repo":{"id":5438867,"name":"angular-google-maps","full_name":"angular-ui/angular-google-maps","owner":{"login":"angular-ui","id":1530011,"avatar_url":"https://avatars.githubusercontent.com/u/1530011?v=2","gravatar_id":"","url":"https://api.github.com/users/angular-ui","html_url":"https://github.com/angular-ui","followers_url":"https://api.github.com/users/angular-ui/followers","following_url":"https://api.github.com/users/angular-ui/following{/other_user}","gists_url":"https://api.github.com/users/angular-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/angular-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular-ui/subscriptions","organizations_url":"https://api.github.com/users/angular-ui/orgs","repos_url":"https://api.github.com/users/angular-ui/repos","events_url":"https://api.github.com/users/angular-ui/events{/privacy}","received_events_url":"https://api.github.com/users/angular-ui/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular-ui/angular-google-maps","description":"AngularJS directives for the Google Maps Javascript API","fork":false,"url":"https://api.github.com/repos/angular-ui/angular-google-maps","forks_url":"https://api.github.com/repos/angular-ui/angular-google-maps/forks","keys_url":"https://api.github.com/repos/angular-ui/angular-google-maps/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular-ui/angular-google-maps/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular-ui/angular-google-maps/teams","hooks_url":"https://api.github.com/repos/angular-ui/angular-google-maps/hooks","issue_events_url":"https://api.github.com/repos/angular-ui/angular-google-maps/issues/events{/number}","events_url":"https://api.github.com/repos/angular-ui/angular-google-maps/events","assignees_url":"https://api.github.com/repos/angular-ui/angular-google-maps/assignees{/user}","branches_url":"https://api.github.com/repos/angular-ui/angular-google-maps/branches{/branch}","tags_url":"https://api.github.com/repos/angular-ui/angular-google-maps/tags","blobs_url":"https://api.github.com/repos/angular-ui/angular-google-maps/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular-ui/angular-google-maps/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular-ui/angular-google-maps/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular-ui/angular-google-maps/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular-ui/angular-google-maps/statuses/{sha}","languages_url":"https://api.github.com/repos/angular-ui/angular-google-maps/languages","stargazers_url":"https://api.github.com/repos/angular-ui/angular-google-maps/stargazers","contributors_url":"https://api.github.com/repos/angular-ui/angular-google-maps/contributors","subscribers_url":"https://api.github.com/repos/angular-ui/angular-google-maps/subscribers","subscription_url":"https://api.github.com/repos/angular-ui/angular-google-maps/subscription","commits_url":"https://api.github.com/repos/angular-ui/angular-google-maps/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular-ui/angular-google-maps/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular-ui/angular-google-maps/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular-ui/angular-google-maps/issues/comments/{number}","contents_url":"https://api.github.com/repos/angular-ui/angular-google-maps/contents/{+path}","compare_url":"https://api.github.com/repos/angular-ui/angular-google-maps/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular-ui/angular-google-maps/merges","archive_url":"https://api.github.com/repos/angular-ui/angular-google-maps/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular-ui/angular-google-maps/downloads","issues_url":"https://api.github.com/repos/angular-ui/angular-google-maps/issues{/number}","pulls_url":"https://api.github.com/repos/angular-ui/angular-google-maps/pulls{/number}","milestones_url":"https://api.github.com/repos/angular-ui/angular-google-maps/milestones{/number}","notifications_url":"https://api.github.com/repos/angular-ui/angular-google-maps/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular-ui/angular-google-maps/labels{/name}","releases_url":"https://api.github.com/repos/angular-ui/angular-google-maps/releases{/id}","created_at":"2012-08-16T12:50:47Z","updated_at":"2014-09-28T19:12:17Z","pushed_at":"2014-09-27T21:05:54Z","git_url":"git://github.com/angular-ui/angular-google-maps.git","ssh_url":"git@github.com:angular-ui/angular-google-maps.git","clone_url":"https://github.com/angular-ui/angular-google-maps.git","svn_url":"https://github.com/angular-ui/angular-google-maps","homepage":"http://angular-ui.github.io/angular-google-maps","size":27602,"stargazers_count":1106,"watchers_count":1106,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":433,"mirror_url":null,"open_issues_count":66,"forks":433,"open_issues":66,"watchers":1106,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular-ui/angular-google-maps/pulls/723"},"html":{"href":"https://github.com/angular-ui/angular-google-maps/pull/723"},"issue":{"href":"https://api.github.com/repos/angular-ui/angular-google-maps/issues/723"},"comments":{"href":"https://api.github.com/repos/angular-ui/angular-google-maps/issues/723/comments"},"review_comments":{"href":"https://api.github.com/repos/angular-ui/angular-google-maps/pulls/723/comments"},"review_comment":{"href":"https://api.github.com/repos/angular-ui/angular-google-maps/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/angular-ui/angular-google-maps/pulls/723/commits"},"statuses":{"href":"https://api.github.com/repos/angular-ui/angular-google-maps/statuses/59e681a3893918d484ddd1b6f7a69247032dc4a9"}}}}