GitHub PullRequestReviewCommentEvent at 2014-10-19 07:20:59
Repository: Dynamo
Actor: Benglin
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments/19058367","id":19058367,"diff_hunk":"@@ -32,10 +32,11 @@ namespace Dynamo.UI.Controls\n     public partial class CodeBlockEditor : UserControl\n     {\n         private NodeViewModel nodeViewModel;\n-        private DynamoViewModel dynamoViewModel;\n+        internal DynamoViewModel dynamoViewModel;","path":"src/DynamoCore/UI/Controls/CodeBlockEditor.xaml.cs","position":5,"original_position":5,"commit_id":"8ea316552c660330631dc59d613e49f63bd20c57","original_commit_id":"8ea316552c660330631dc59d613e49f63bd20c57","user":{"login":"Benglin","id":5086849,"avatar_url":"https://avatars.githubusercontent.com/u/5086849?v=2","gravatar_id":"","url":"https://api.github.com/users/Benglin","html_url":"https://github.com/Benglin","followers_url":"https://api.github.com/users/Benglin/followers","following_url":"https://api.github.com/users/Benglin/following{/other_user}","gists_url":"https://api.github.com/users/Benglin/gists{/gist_id}","starred_url":"https://api.github.com/users/Benglin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Benglin/subscriptions","organizations_url":"https://api.github.com/users/Benglin/orgs","repos_url":"https://api.github.com/users/Benglin/repos","events_url":"https://api.github.com/users/Benglin/events{/privacy}","received_events_url":"https://api.github.com/users/Benglin/received_events","type":"User","site_admin":false},"body":"I tend to question the decision making something more visible, in this case ```dynamoViewModel``` does not have to be. The callers in unit test cases below look unnatural enough that they need to be tweaked. Let's set the ```DynamoViewModel``` through constructor parameter, if such constructor is to be used only by unit tests, then make them ```internal``` (I think they will still be visible for unit test cases, if not add a statement in ```AssemblyInfo.cs``` that looks like:\r\n\r\n```cs\r\n[assembly: InternalsVisibleTo(\"DynamoCoreUITests\")]\r\n```","created_at":"2014-10-19T07:20:59Z","updated_at":"2014-10-19T07:20:59Z","html_url":"https://github.com/DynamoDS/Dynamo/pull/2688#discussion_r19058367","pull_request_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/2688","_links":{"self":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments/19058367"},"html":{"href":"https://github.com/DynamoDS/Dynamo/pull/2688#discussion_r19058367"},"pull_request":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/2688"}}},"pull_request":{"url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/2688","id":22626549,"html_url":"https://github.com/DynamoDS/Dynamo/pull/2688","diff_url":"https://github.com/DynamoDS/Dynamo/pull/2688.diff","patch_url":"https://github.com/DynamoDS/Dynamo/pull/2688.patch","issue_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/2688","number":2688,"state":"open","locked":false,"title":"Added auto-completion of function signatures - Part 4 (Final)","user":{"login":"aparajit-pratap","id":5710686,"avatar_url":"https://avatars.githubusercontent.com/u/5710686?v=2","gravatar_id":"","url":"https://api.github.com/users/aparajit-pratap","html_url":"https://github.com/aparajit-pratap","followers_url":"https://api.github.com/users/aparajit-pratap/followers","following_url":"https://api.github.com/users/aparajit-pratap/following{/other_user}","gists_url":"https://api.github.com/users/aparajit-pratap/gists{/gist_id}","starred_url":"https://api.github.com/users/aparajit-pratap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aparajit-pratap/subscriptions","organizations_url":"https://api.github.com/users/aparajit-pratap/orgs","repos_url":"https://api.github.com/users/aparajit-pratap/repos","events_url":"https://api.github.com/users/aparajit-pratap/events{/privacy}","received_events_url":"https://api.github.com/users/aparajit-pratap/received_events","type":"User","site_admin":false},"body":"This PR adds the functionality to complete function signatures as you type '(' (open parantheses) after typing a method name. The following are example scenarios on how it looks like:\r\n1. Auto-completion of global (built-in) methods\r\n![image](https://cloud.githubusercontent.com/assets/5710686/4609197/a461e002-5298-11e4-884a-63ecba79cc83.png)\r\n\r\n2. Completion of static methods and constructors\r\n![image](https://cloud.githubusercontent.com/assets/5710686/4609198/a8def1ba-5298-11e4-8ca6-d9b6bdf3fbe1.png)\r\n\r\n3. Completion of instance methods\r\n![image](https://cloud.githubusercontent.com/assets/5710686/4609200/add2fe1e-5298-11e4-9aa1-b40a21777760.png)\r\n\r\nFuture Enhancements:\r\n1. Highlighting parameters in function signature tooltip is not supported yet and will be handled in successive implementations\r\n2. Function signature completion from a selection listbox as per EB's designs: https://docs.google.com/a/adsk-oss.com/document/d/1gzgyVMbpK_r7OFx2IoDXF2J5lQgTdOUA-SQ7_WB1nZ8/edit\r\n\r\n@Benglin please take a look. Thanks.\r\n@elayabharath we spoke briefly on the design considerations. Please add your comments here. Thanks.","created_at":"2014-10-13T05:28:57Z","updated_at":"2014-10-19T07:20:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0058e78d506251adc1185e00d61fd94b3c6e6811","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/2688/commits","review_comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/2688/comments","review_comment_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments/{number}","comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/2688/comments","statuses_url":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/8ea316552c660330631dc59d613e49f63bd20c57","head":{"label":"aparajit-pratap:Intellisense","ref":"Intellisense","sha":"8ea316552c660330631dc59d613e49f63bd20c57","user":{"login":"aparajit-pratap","id":5710686,"avatar_url":"https://avatars.githubusercontent.com/u/5710686?v=2","gravatar_id":"","url":"https://api.github.com/users/aparajit-pratap","html_url":"https://github.com/aparajit-pratap","followers_url":"https://api.github.com/users/aparajit-pratap/followers","following_url":"https://api.github.com/users/aparajit-pratap/following{/other_user}","gists_url":"https://api.github.com/users/aparajit-pratap/gists{/gist_id}","starred_url":"https://api.github.com/users/aparajit-pratap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aparajit-pratap/subscriptions","organizations_url":"https://api.github.com/users/aparajit-pratap/orgs","repos_url":"https://api.github.com/users/aparajit-pratap/repos","events_url":"https://api.github.com/users/aparajit-pratap/events{/privacy}","received_events_url":"https://api.github.com/users/aparajit-pratap/received_events","type":"User","site_admin":false},"repo":{"id":15271868,"name":"Dynamo","full_name":"aparajit-pratap/Dynamo","owner":{"login":"aparajit-pratap","id":5710686,"avatar_url":"https://avatars.githubusercontent.com/u/5710686?v=2","gravatar_id":"","url":"https://api.github.com/users/aparajit-pratap","html_url":"https://github.com/aparajit-pratap","followers_url":"https://api.github.com/users/aparajit-pratap/followers","following_url":"https://api.github.com/users/aparajit-pratap/following{/other_user}","gists_url":"https://api.github.com/users/aparajit-pratap/gists{/gist_id}","starred_url":"https://api.github.com/users/aparajit-pratap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aparajit-pratap/subscriptions","organizations_url":"https://api.github.com/users/aparajit-pratap/orgs","repos_url":"https://api.github.com/users/aparajit-pratap/repos","events_url":"https://api.github.com/users/aparajit-pratap/events{/privacy}","received_events_url":"https://api.github.com/users/aparajit-pratap/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aparajit-pratap/Dynamo","description":"Visual Programming For Revit","fork":true,"url":"https://api.github.com/repos/aparajit-pratap/Dynamo","forks_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/forks","keys_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/teams","hooks_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/hooks","issue_events_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/issues/events{/number}","events_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/events","assignees_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/assignees{/user}","branches_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/branches{/branch}","tags_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/tags","blobs_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/git/refs{/sha}","trees_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/statuses/{sha}","languages_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/languages","stargazers_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/stargazers","contributors_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/contributors","subscribers_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/subscribers","subscription_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/subscription","commits_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/commits{/sha}","git_commits_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/git/commits{/sha}","comments_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/comments{/number}","issue_comment_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/issues/comments/{number}","contents_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/contents/{+path}","compare_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/merges","archive_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/downloads","issues_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/issues{/number}","pulls_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/pulls{/number}","milestones_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/milestones{/number}","notifications_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/labels{/name}","releases_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/releases{/id}","created_at":"2013-12-18T02:34:41Z","updated_at":"2014-06-25T09:56:58Z","pushed_at":"2014-10-18T15:14:38Z","git_url":"git://github.com/aparajit-pratap/Dynamo.git","ssh_url":"git@github.com:aparajit-pratap/Dynamo.git","clone_url":"https://github.com/aparajit-pratap/Dynamo.git","svn_url":"https://github.com/aparajit-pratap/Dynamo","homepage":"http://dynamobim.org","size":730922,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DynamoDS:master","ref":"master","sha":"5d7701e7677c124af6d3126142219003e9aede85","user":{"login":"DynamoDS","id":6528209,"avatar_url":"https://avatars.githubusercontent.com/u/6528209?v=2","gravatar_id":"","url":"https://api.github.com/users/DynamoDS","html_url":"https://github.com/DynamoDS","followers_url":"https://api.github.com/users/DynamoDS/followers","following_url":"https://api.github.com/users/DynamoDS/following{/other_user}","gists_url":"https://api.github.com/users/DynamoDS/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoDS/subscriptions","organizations_url":"https://api.github.com/users/DynamoDS/orgs","repos_url":"https://api.github.com/users/DynamoDS/repos","events_url":"https://api.github.com/users/DynamoDS/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoDS/received_events","type":"Organization","site_admin":false},"repo":{"id":3395179,"name":"Dynamo","full_name":"DynamoDS/Dynamo","owner":{"login":"DynamoDS","id":6528209,"avatar_url":"https://avatars.githubusercontent.com/u/6528209?v=2","gravatar_id":"","url":"https://api.github.com/users/DynamoDS","html_url":"https://github.com/DynamoDS","followers_url":"https://api.github.com/users/DynamoDS/followers","following_url":"https://api.github.com/users/DynamoDS/following{/other_user}","gists_url":"https://api.github.com/users/DynamoDS/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoDS/subscriptions","organizations_url":"https://api.github.com/users/DynamoDS/orgs","repos_url":"https://api.github.com/users/DynamoDS/repos","events_url":"https://api.github.com/users/DynamoDS/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoDS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DynamoDS/Dynamo","description":"Visual Programming For Revit","fork":false,"url":"https://api.github.com/repos/DynamoDS/Dynamo","forks_url":"https://api.github.com/repos/DynamoDS/Dynamo/forks","keys_url":"https://api.github.com/repos/DynamoDS/Dynamo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DynamoDS/Dynamo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DynamoDS/Dynamo/teams","hooks_url":"https://api.github.com/repos/DynamoDS/Dynamo/hooks","issue_events_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/events{/number}","events_url":"https://api.github.com/repos/DynamoDS/Dynamo/events","assignees_url":"https://api.github.com/repos/DynamoDS/Dynamo/assignees{/user}","branches_url":"https://api.github.com/repos/DynamoDS/Dynamo/branches{/branch}","tags_url":"https://api.github.com/repos/DynamoDS/Dynamo/tags","blobs_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/refs{/sha}","trees_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/{sha}","languages_url":"https://api.github.com/repos/DynamoDS/Dynamo/languages","stargazers_url":"https://api.github.com/repos/DynamoDS/Dynamo/stargazers","contributors_url":"https://api.github.com/repos/DynamoDS/Dynamo/contributors","subscribers_url":"https://api.github.com/repos/DynamoDS/Dynamo/subscribers","subscription_url":"https://api.github.com/repos/DynamoDS/Dynamo/subscription","commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/commits{/sha}","git_commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/commits{/sha}","comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/comments{/number}","issue_comment_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/comments/{number}","contents_url":"https://api.github.com/repos/DynamoDS/Dynamo/contents/{+path}","compare_url":"https://api.github.com/repos/DynamoDS/Dynamo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DynamoDS/Dynamo/merges","archive_url":"https://api.github.com/repos/DynamoDS/Dynamo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DynamoDS/Dynamo/downloads","issues_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues{/number}","pulls_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls{/number}","milestones_url":"https://api.github.com/repos/DynamoDS/Dynamo/milestones{/number}","notifications_url":"https://api.github.com/repos/DynamoDS/Dynamo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DynamoDS/Dynamo/labels{/name}","releases_url":"https://api.github.com/repos/DynamoDS/Dynamo/releases{/id}","created_at":"2012-02-09T07:35:33Z","updated_at":"2014-10-17T05:32:04Z","pushed_at":"2014-10-19T06:50:09Z","git_url":"git://github.com/DynamoDS/Dynamo.git","ssh_url":"git@github.com:DynamoDS/Dynamo.git","clone_url":"https://github.com/DynamoDS/Dynamo.git","svn_url":"https://github.com/DynamoDS/Dynamo","homepage":"http://dynamobim.org","size":803566,"stargazers_count":154,"watchers_count":154,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":111,"mirror_url":null,"open_issues_count":409,"forks":111,"open_issues":409,"watchers":154,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/2688"},"html":{"href":"https://github.com/DynamoDS/Dynamo/pull/2688"},"issue":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/issues/2688"},"comments":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/issues/2688/comments"},"review_comments":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/2688/comments"},"review_comment":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/2688/commits"},"statuses":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/8ea316552c660330631dc59d613e49f63bd20c57"}}}}