GitHub PullRequestEvent at 2014-12-04 18:50:37
Repository: serrano
Actor: bruth
Payload: {"action":"closed","number":248,"pull_request":{"url":"https://api.github.com/repos/cbmi/serrano/pulls/248","id":25518248,"html_url":"https://github.com/cbmi/serrano/pull/248","diff_url":"https://github.com/cbmi/serrano/pull/248.diff","patch_url":"https://github.com/cbmi/serrano/pull/248.patch","issue_url":"https://api.github.com/repos/cbmi/serrano/issues/248","number":248,"state":"closed","locked":false,"title":"Fix case where nulls were being included in dims response","user":{"login":"naegelyd","id":3911912,"avatar_url":"https://avatars.githubusercontent.com/u/3911912?v=3","gravatar_id":"","url":"https://api.github.com/users/naegelyd","html_url":"https://github.com/naegelyd","followers_url":"https://api.github.com/users/naegelyd/followers","following_url":"https://api.github.com/users/naegelyd/following{/other_user}","gists_url":"https://api.github.com/users/naegelyd/gists{/gist_id}","starred_url":"https://api.github.com/users/naegelyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naegelyd/subscriptions","organizations_url":"https://api.github.com/users/naegelyd/orgs","repos_url":"https://api.github.com/users/naegelyd/repos","events_url":"https://api.github.com/users/naegelyd/events{/privacy}","received_events_url":"https://api.github.com/users/naegelyd/received_events","type":"User","site_admin":false},"body":"The fix was to call values on the queryset AFTER the null exclusion. Additionally, this change switches from exclude to filter for clarity.\r\n\r\nSigned-off-by: Don Naegely <naegelyd@gmail.com>","created_at":"2014-12-04T18:42:29Z","updated_at":"2014-12-04T18:50:37Z","closed_at":"2014-12-04T18:50:37Z","merged_at":"2014-12-04T18:50:37Z","merge_commit_sha":"12002f66ca77d504fd1012091c929acefe201869","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cbmi/serrano/pulls/248/commits","review_comments_url":"https://api.github.com/repos/cbmi/serrano/pulls/248/comments","review_comment_url":"https://api.github.com/repos/cbmi/serrano/pulls/comments/{number}","comments_url":"https://api.github.com/repos/cbmi/serrano/issues/248/comments","statuses_url":"https://api.github.com/repos/cbmi/serrano/statuses/e090a47daffdc8ea80c5d2273601ec2c7a7d44d7","head":{"label":"cbmi:dims-nulls-fix","ref":"dims-nulls-fix","sha":"e090a47daffdc8ea80c5d2273601ec2c7a7d44d7","user":{"login":"cbmi","id":709892,"avatar_url":"https://avatars.githubusercontent.com/u/709892?v=3","gravatar_id":"","url":"https://api.github.com/users/cbmi","html_url":"https://github.com/cbmi","followers_url":"https://api.github.com/users/cbmi/followers","following_url":"https://api.github.com/users/cbmi/following{/other_user}","gists_url":"https://api.github.com/users/cbmi/gists{/gist_id}","starred_url":"https://api.github.com/users/cbmi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbmi/subscriptions","organizations_url":"https://api.github.com/users/cbmi/orgs","repos_url":"https://api.github.com/users/cbmi/repos","events_url":"https://api.github.com/users/cbmi/events{/privacy}","received_events_url":"https://api.github.com/users/cbmi/received_events","type":"Organization","site_admin":false},"repo":{"id":2338279,"name":"serrano","full_name":"cbmi/serrano","owner":{"login":"cbmi","id":709892,"avatar_url":"https://avatars.githubusercontent.com/u/709892?v=3","gravatar_id":"","url":"https://api.github.com/users/cbmi","html_url":"https://github.com/cbmi","followers_url":"https://api.github.com/users/cbmi/followers","following_url":"https://api.github.com/users/cbmi/following{/other_user}","gists_url":"https://api.github.com/users/cbmi/gists{/gist_id}","starred_url":"https://api.github.com/users/cbmi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbmi/subscriptions","organizations_url":"https://api.github.com/users/cbmi/orgs","repos_url":"https://api.github.com/users/cbmi/repos","events_url":"https://api.github.com/users/cbmi/events{/privacy}","received_events_url":"https://api.github.com/users/cbmi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cbmi/serrano","description":"Serrano implements a hypermedia API for Avocado. Avocado is a Django app which targets developers who are interested in letting their data do the work for them.","fork":false,"url":"https://api.github.com/repos/cbmi/serrano","forks_url":"https://api.github.com/repos/cbmi/serrano/forks","keys_url":"https://api.github.com/repos/cbmi/serrano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cbmi/serrano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cbmi/serrano/teams","hooks_url":"https://api.github.com/repos/cbmi/serrano/hooks","issue_events_url":"https://api.github.com/repos/cbmi/serrano/issues/events{/number}","events_url":"https://api.github.com/repos/cbmi/serrano/events","assignees_url":"https://api.github.com/repos/cbmi/serrano/assignees{/user}","branches_url":"https://api.github.com/repos/cbmi/serrano/branches{/branch}","tags_url":"https://api.github.com/repos/cbmi/serrano/tags","blobs_url":"https://api.github.com/repos/cbmi/serrano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cbmi/serrano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cbmi/serrano/git/refs{/sha}","trees_url":"https://api.github.com/repos/cbmi/serrano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cbmi/serrano/statuses/{sha}","languages_url":"https://api.github.com/repos/cbmi/serrano/languages","stargazers_url":"https://api.github.com/repos/cbmi/serrano/stargazers","contributors_url":"https://api.github.com/repos/cbmi/serrano/contributors","subscribers_url":"https://api.github.com/repos/cbmi/serrano/subscribers","subscription_url":"https://api.github.com/repos/cbmi/serrano/subscription","commits_url":"https://api.github.com/repos/cbmi/serrano/commits{/sha}","git_commits_url":"https://api.github.com/repos/cbmi/serrano/git/commits{/sha}","comments_url":"https://api.github.com/repos/cbmi/serrano/comments{/number}","issue_comment_url":"https://api.github.com/repos/cbmi/serrano/issues/comments/{number}","contents_url":"https://api.github.com/repos/cbmi/serrano/contents/{+path}","compare_url":"https://api.github.com/repos/cbmi/serrano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cbmi/serrano/merges","archive_url":"https://api.github.com/repos/cbmi/serrano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cbmi/serrano/downloads","issues_url":"https://api.github.com/repos/cbmi/serrano/issues{/number}","pulls_url":"https://api.github.com/repos/cbmi/serrano/pulls{/number}","milestones_url":"https://api.github.com/repos/cbmi/serrano/milestones{/number}","notifications_url":"https://api.github.com/repos/cbmi/serrano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cbmi/serrano/labels{/name}","releases_url":"https://api.github.com/repos/cbmi/serrano/releases{/id}","created_at":"2011-09-07T00:01:38Z","updated_at":"2014-12-04T18:50:37Z","pushed_at":"2014-12-04T18:50:37Z","git_url":"git://github.com/cbmi/serrano.git","ssh_url":"git@github.com:cbmi/serrano.git","clone_url":"https://github.com/cbmi/serrano.git","svn_url":"https://github.com/cbmi/serrano","homepage":"http://serrano.harvest.io","size":5220,"stargazers_count":15,"watchers_count":15,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":7,"mirror_url":null,"open_issues_count":17,"forks":7,"open_issues":17,"watchers":15,"default_branch":"master"}},"base":{"label":"cbmi:master","ref":"master","sha":"ede42a9eecab3587129286c78e8f686eb6a473d3","user":{"login":"cbmi","id":709892,"avatar_url":"https://avatars.githubusercontent.com/u/709892?v=3","gravatar_id":"","url":"https://api.github.com/users/cbmi","html_url":"https://github.com/cbmi","followers_url":"https://api.github.com/users/cbmi/followers","following_url":"https://api.github.com/users/cbmi/following{/other_user}","gists_url":"https://api.github.com/users/cbmi/gists{/gist_id}","starred_url":"https://api.github.com/users/cbmi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbmi/subscriptions","organizations_url":"https://api.github.com/users/cbmi/orgs","repos_url":"https://api.github.com/users/cbmi/repos","events_url":"https://api.github.com/users/cbmi/events{/privacy}","received_events_url":"https://api.github.com/users/cbmi/received_events","type":"Organization","site_admin":false},"repo":{"id":2338279,"name":"serrano","full_name":"cbmi/serrano","owner":{"login":"cbmi","id":709892,"avatar_url":"https://avatars.githubusercontent.com/u/709892?v=3","gravatar_id":"","url":"https://api.github.com/users/cbmi","html_url":"https://github.com/cbmi","followers_url":"https://api.github.com/users/cbmi/followers","following_url":"https://api.github.com/users/cbmi/following{/other_user}","gists_url":"https://api.github.com/users/cbmi/gists{/gist_id}","starred_url":"https://api.github.com/users/cbmi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbmi/subscriptions","organizations_url":"https://api.github.com/users/cbmi/orgs","repos_url":"https://api.github.com/users/cbmi/repos","events_url":"https://api.github.com/users/cbmi/events{/privacy}","received_events_url":"https://api.github.com/users/cbmi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cbmi/serrano","description":"Serrano implements a hypermedia API for Avocado. Avocado is a Django app which targets developers who are interested in letting their data do the work for them.","fork":false,"url":"https://api.github.com/repos/cbmi/serrano","forks_url":"https://api.github.com/repos/cbmi/serrano/forks","keys_url":"https://api.github.com/repos/cbmi/serrano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cbmi/serrano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cbmi/serrano/teams","hooks_url":"https://api.github.com/repos/cbmi/serrano/hooks","issue_events_url":"https://api.github.com/repos/cbmi/serrano/issues/events{/number}","events_url":"https://api.github.com/repos/cbmi/serrano/events","assignees_url":"https://api.github.com/repos/cbmi/serrano/assignees{/user}","branches_url":"https://api.github.com/repos/cbmi/serrano/branches{/branch}","tags_url":"https://api.github.com/repos/cbmi/serrano/tags","blobs_url":"https://api.github.com/repos/cbmi/serrano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cbmi/serrano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cbmi/serrano/git/refs{/sha}","trees_url":"https://api.github.com/repos/cbmi/serrano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cbmi/serrano/statuses/{sha}","languages_url":"https://api.github.com/repos/cbmi/serrano/languages","stargazers_url":"https://api.github.com/repos/cbmi/serrano/stargazers","contributors_url":"https://api.github.com/repos/cbmi/serrano/contributors","subscribers_url":"https://api.github.com/repos/cbmi/serrano/subscribers","subscription_url":"https://api.github.com/repos/cbmi/serrano/subscription","commits_url":"https://api.github.com/repos/cbmi/serrano/commits{/sha}","git_commits_url":"https://api.github.com/repos/cbmi/serrano/git/commits{/sha}","comments_url":"https://api.github.com/repos/cbmi/serrano/comments{/number}","issue_comment_url":"https://api.github.com/repos/cbmi/serrano/issues/comments/{number}","contents_url":"https://api.github.com/repos/cbmi/serrano/contents/{+path}","compare_url":"https://api.github.com/repos/cbmi/serrano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cbmi/serrano/merges","archive_url":"https://api.github.com/repos/cbmi/serrano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cbmi/serrano/downloads","issues_url":"https://api.github.com/repos/cbmi/serrano/issues{/number}","pulls_url":"https://api.github.com/repos/cbmi/serrano/pulls{/number}","milestones_url":"https://api.github.com/repos/cbmi/serrano/milestones{/number}","notifications_url":"https://api.github.com/repos/cbmi/serrano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cbmi/serrano/labels{/name}","releases_url":"https://api.github.com/repos/cbmi/serrano/releases{/id}","created_at":"2011-09-07T00:01:38Z","updated_at":"2014-12-04T18:50:37Z","pushed_at":"2014-12-04T18:50:37Z","git_url":"git://github.com/cbmi/serrano.git","ssh_url":"git@github.com:cbmi/serrano.git","clone_url":"https://github.com/cbmi/serrano.git","svn_url":"https://github.com/cbmi/serrano","homepage":"http://serrano.harvest.io","size":5220,"stargazers_count":15,"watchers_count":15,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":7,"mirror_url":null,"open_issues_count":17,"forks":7,"open_issues":17,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cbmi/serrano/pulls/248"},"html":{"href":"https://github.com/cbmi/serrano/pull/248"},"issue":{"href":"https://api.github.com/repos/cbmi/serrano/issues/248"},"comments":{"href":"https://api.github.com/repos/cbmi/serrano/issues/248/comments"},"review_comments":{"href":"https://api.github.com/repos/cbmi/serrano/pulls/248/comments"},"review_comment":{"href":"https://api.github.com/repos/cbmi/serrano/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/cbmi/serrano/pulls/248/commits"},"statuses":{"href":"https://api.github.com/repos/cbmi/serrano/statuses/e090a47daffdc8ea80c5d2273601ec2c7a7d44d7"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"bruth","id":515142,"avatar_url":"https://avatars.githubusercontent.com/u/515142?v=3","gravatar_id":"","url":"https://api.github.com/users/bruth","html_url":"https://github.com/bruth","followers_url":"https://api.github.com/users/bruth/followers","following_url":"https://api.github.com/users/bruth/following{/other_user}","gists_url":"https://api.github.com/users/bruth/gists{/gist_id}","starred_url":"https://api.github.com/users/bruth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bruth/subscriptions","organizations_url":"https://api.github.com/users/bruth/orgs","repos_url":"https://api.github.com/users/bruth/repos","events_url":"https://api.github.com/users/bruth/events{/privacy}","received_events_url":"https://api.github.com/users/bruth/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":5,"deletions":5,"changed_files":1}}