GitHub PullRequestEvent at 2014-01-09 09:29:29
Repository: lodmill
Actor: fsteeg
Payload: {"action":"opened","number":294,"pull_request":{"url":"https://api.github.com/repos/lobid/lodmill/pulls/294","id":11353993,"html_url":"https://github.com/lobid/lodmill/pull/294","diff_url":"https://github.com/lobid/lodmill/pull/294.diff","patch_url":"https://github.com/lobid/lodmill/pull/294.patch","issue_url":"https://github.com/lobid/lodmill/pull/294","number":294,"state":"open","title":"Switch from n-grams to edge n-grams for suggestions","user":{"login":"fsteeg","id":128229,"avatar_url":"https://gravatar.com/avatar/528394f867632bcca8497088cd71a6d4?d=https%3A%2F%2Fidenticons.github.com%2Fd683fe001a6042286a172f5c64341fd4.png&r=x","gravatar_id":"528394f867632bcca8497088cd71a6d4","url":"https://api.github.com/users/fsteeg","html_url":"https://github.com/fsteeg","followers_url":"https://api.github.com/users/fsteeg/followers","following_url":"https://api.github.com/users/fsteeg/following{/other_user}","gists_url":"https://api.github.com/users/fsteeg/gists{/gist_id}","starred_url":"https://api.github.com/users/fsteeg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fsteeg/subscriptions","organizations_url":"https://api.github.com/users/fsteeg/orgs","repos_url":"https://api.github.com/users/fsteeg/repos","events_url":"https://api.github.com/users/fsteeg/events{/privacy}","received_events_url":"https://api.github.com/users/fsteeg/received_events","type":"User","site_admin":false},"body":"This change completely switches from n-grams to edge n-grams, so only suggestions where a token *starts* with the query are returned (so both `Thomas Mann` and `Mann, Thomas` yield a result, but no n-grams within a token, e.g. `mas` in this case). This is true for all queries, but as the n-grams were meant for suggestions in the first place, I think this might work as the general behavior.\r\n\r\nIn an attempt to keep things simple, this commit also removes the manual sorting of results after they are returned from Elasticsearch. This requirement was caused by the overwhelmingly large suggestions list (which this commit solves). It also didn't make much sense conceptually, since it only sorted the paged result returned from Elasticsearch, not the entire result set.\r\n\r\nSee details and discussion in #264.\r\n\r\nDeployed to staging, see http://staging.api.lobid.org/person?name=Thomas+Mann&format=short","created_at":"2014-01-09T09:29:29Z","updated_at":"2014-01-09T09:29:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://github.com/lobid/lodmill/pull/294/commits","review_comments_url":"https://github.com/lobid/lodmill/pull/294/comments","review_comment_url":"/repos/lobid/lodmill/pulls/comments/{number}","comments_url":"https://api.github.com/repos/lobid/lodmill/issues/294/comments","statuses_url":"https://api.github.com/repos/lobid/lodmill/statuses/102b48131a87e4952d2a68ed08b16de7127321ce","head":{"label":"fsteeg:issue-264-ranking","ref":"issue-264-ranking","sha":"102b48131a87e4952d2a68ed08b16de7127321ce","user":{"login":"fsteeg","id":128229,"avatar_url":"https://gravatar.com/avatar/528394f867632bcca8497088cd71a6d4?d=https%3A%2F%2Fidenticons.github.com%2Fd683fe001a6042286a172f5c64341fd4.png&r=x","gravatar_id":"528394f867632bcca8497088cd71a6d4","url":"https://api.github.com/users/fsteeg","html_url":"https://github.com/fsteeg","followers_url":"https://api.github.com/users/fsteeg/followers","following_url":"https://api.github.com/users/fsteeg/following{/other_user}","gists_url":"https://api.github.com/users/fsteeg/gists{/gist_id}","starred_url":"https://api.github.com/users/fsteeg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fsteeg/subscriptions","organizations_url":"https://api.github.com/users/fsteeg/orgs","repos_url":"https://api.github.com/users/fsteeg/repos","events_url":"https://api.github.com/users/fsteeg/events{/privacy}","received_events_url":"https://api.github.com/users/fsteeg/received_events","type":"User","site_admin":false},"repo":{"id":6546717,"name":"lodmill","full_name":"fsteeg/lodmill","owner":{"login":"fsteeg","id":128229,"avatar_url":"https://gravatar.com/avatar/528394f867632bcca8497088cd71a6d4?d=https%3A%2F%2Fidenticons.github.com%2Fd683fe001a6042286a172f5c64341fd4.png&r=x","gravatar_id":"528394f867632bcca8497088cd71a6d4","url":"https://api.github.com/users/fsteeg","html_url":"https://github.com/fsteeg","followers_url":"https://api.github.com/users/fsteeg/followers","following_url":"https://api.github.com/users/fsteeg/following{/other_user}","gists_url":"https://api.github.com/users/fsteeg/gists{/gist_id}","starred_url":"https://api.github.com/users/fsteeg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fsteeg/subscriptions","organizations_url":"https://api.github.com/users/fsteeg/orgs","repos_url":"https://api.github.com/users/fsteeg/repos","events_url":"https://api.github.com/users/fsteeg/events{/privacy}","received_events_url":"https://api.github.com/users/fsteeg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fsteeg/lodmill","description":"Blend, grind, and enjoy LOD – fresh from the mill!","fork":true,"url":"https://api.github.com/repos/fsteeg/lodmill","forks_url":"https://api.github.com/repos/fsteeg/lodmill/forks","keys_url":"https://api.github.com/repos/fsteeg/lodmill/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fsteeg/lodmill/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fsteeg/lodmill/teams","hooks_url":"https://api.github.com/repos/fsteeg/lodmill/hooks","issue_events_url":"https://api.github.com/repos/fsteeg/lodmill/issues/events{/number}","events_url":"https://api.github.com/repos/fsteeg/lodmill/events","assignees_url":"https://api.github.com/repos/fsteeg/lodmill/assignees{/user}","branches_url":"https://api.github.com/repos/fsteeg/lodmill/branches{/branch}","tags_url":"https://api.github.com/repos/fsteeg/lodmill/tags","blobs_url":"https://api.github.com/repos/fsteeg/lodmill/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fsteeg/lodmill/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fsteeg/lodmill/git/refs{/sha}","trees_url":"https://api.github.com/repos/fsteeg/lodmill/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fsteeg/lodmill/statuses/{sha}","languages_url":"https://api.github.com/repos/fsteeg/lodmill/languages","stargazers_url":"https://api.github.com/repos/fsteeg/lodmill/stargazers","contributors_url":"https://api.github.com/repos/fsteeg/lodmill/contributors","subscribers_url":"https://api.github.com/repos/fsteeg/lodmill/subscribers","subscription_url":"https://api.github.com/repos/fsteeg/lodmill/subscription","commits_url":"https://api.github.com/repos/fsteeg/lodmill/commits{/sha}","git_commits_url":"https://api.github.com/repos/fsteeg/lodmill/git/commits{/sha}","comments_url":"https://api.github.com/repos/fsteeg/lodmill/comments{/number}","issue_comment_url":"https://api.github.com/repos/fsteeg/lodmill/issues/comments/{number}","contents_url":"https://api.github.com/repos/fsteeg/lodmill/contents/{+path}","compare_url":"https://api.github.com/repos/fsteeg/lodmill/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fsteeg/lodmill/merges","archive_url":"https://api.github.com/repos/fsteeg/lodmill/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fsteeg/lodmill/downloads","issues_url":"https://api.github.com/repos/fsteeg/lodmill/issues{/number}","pulls_url":"https://api.github.com/repos/fsteeg/lodmill/pulls{/number}","milestones_url":"https://api.github.com/repos/fsteeg/lodmill/milestones{/number}","notifications_url":"https://api.github.com/repos/fsteeg/lodmill/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fsteeg/lodmill/labels{/name}","releases_url":"https://api.github.com/repos/fsteeg/lodmill/releases{/id}","created_at":"2012-11-05T15:34:17Z","updated_at":"2014-01-09T09:29:29Z","pushed_at":"2014-01-08T17:46:28Z","git_url":"git://github.com/fsteeg/lodmill.git","ssh_url":"git@github.com:fsteeg/lodmill.git","clone_url":"https://github.com/fsteeg/lodmill.git","svn_url":"https://github.com/fsteeg/lodmill","homepage":null,"size":9104,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"lobid:master","ref":"master","sha":"249181fb5b1cd9b74699706a541fc496f598a6a6","user":{"login":"lobid","id":756959,"avatar_url":"https://gravatar.com/avatar/c7edab8d350fffad9fa06e2de9d4e885?d=https%3A%2F%2Fidenticons.github.com%2F3cae0fddd15851a198861f551eaa1de1.png&r=x","gravatar_id":"c7edab8d350fffad9fa06e2de9d4e885","url":"https://api.github.com/users/lobid","html_url":"https://github.com/lobid","followers_url":"https://api.github.com/users/lobid/followers","following_url":"https://api.github.com/users/lobid/following{/other_user}","gists_url":"https://api.github.com/users/lobid/gists{/gist_id}","starred_url":"https://api.github.com/users/lobid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lobid/subscriptions","organizations_url":"https://api.github.com/users/lobid/orgs","repos_url":"https://api.github.com/users/lobid/repos","events_url":"https://api.github.com/users/lobid/events{/privacy}","received_events_url":"https://api.github.com/users/lobid/received_events","type":"Organization","site_admin":false},"repo":{"id":6543378,"name":"lodmill","full_name":"lobid/lodmill","owner":{"login":"lobid","id":756959,"avatar_url":"https://gravatar.com/avatar/c7edab8d350fffad9fa06e2de9d4e885?d=https%3A%2F%2Fidenticons.github.com%2F3cae0fddd15851a198861f551eaa1de1.png&r=x","gravatar_id":"c7edab8d350fffad9fa06e2de9d4e885","url":"https://api.github.com/users/lobid","html_url":"https://github.com/lobid","followers_url":"https://api.github.com/users/lobid/followers","following_url":"https://api.github.com/users/lobid/following{/other_user}","gists_url":"https://api.github.com/users/lobid/gists{/gist_id}","starred_url":"https://api.github.com/users/lobid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lobid/subscriptions","organizations_url":"https://api.github.com/users/lobid/orgs","repos_url":"https://api.github.com/users/lobid/repos","events_url":"https://api.github.com/users/lobid/events{/privacy}","received_events_url":"https://api.github.com/users/lobid/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lobid/lodmill","description":"Blend, grind, and enjoy LOD – fresh from the mill!","fork":false,"url":"https://api.github.com/repos/lobid/lodmill","forks_url":"https://api.github.com/repos/lobid/lodmill/forks","keys_url":"https://api.github.com/repos/lobid/lodmill/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lobid/lodmill/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lobid/lodmill/teams","hooks_url":"https://api.github.com/repos/lobid/lodmill/hooks","issue_events_url":"https://api.github.com/repos/lobid/lodmill/issues/events{/number}","events_url":"https://api.github.com/repos/lobid/lodmill/events","assignees_url":"https://api.github.com/repos/lobid/lodmill/assignees{/user}","branches_url":"https://api.github.com/repos/lobid/lodmill/branches{/branch}","tags_url":"https://api.github.com/repos/lobid/lodmill/tags","blobs_url":"https://api.github.com/repos/lobid/lodmill/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lobid/lodmill/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lobid/lodmill/git/refs{/sha}","trees_url":"https://api.github.com/repos/lobid/lodmill/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lobid/lodmill/statuses/{sha}","languages_url":"https://api.github.com/repos/lobid/lodmill/languages","stargazers_url":"https://api.github.com/repos/lobid/lodmill/stargazers","contributors_url":"https://api.github.com/repos/lobid/lodmill/contributors","subscribers_url":"https://api.github.com/repos/lobid/lodmill/subscribers","subscription_url":"https://api.github.com/repos/lobid/lodmill/subscription","commits_url":"https://api.github.com/repos/lobid/lodmill/commits{/sha}","git_commits_url":"https://api.github.com/repos/lobid/lodmill/git/commits{/sha}","comments_url":"https://api.github.com/repos/lobid/lodmill/comments{/number}","issue_comment_url":"https://api.github.com/repos/lobid/lodmill/issues/comments/{number}","contents_url":"https://api.github.com/repos/lobid/lodmill/contents/{+path}","compare_url":"https://api.github.com/repos/lobid/lodmill/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lobid/lodmill/merges","archive_url":"https://api.github.com/repos/lobid/lodmill/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lobid/lodmill/downloads","issues_url":"https://api.github.com/repos/lobid/lodmill/issues{/number}","pulls_url":"https://api.github.com/repos/lobid/lodmill/pulls{/number}","milestones_url":"https://api.github.com/repos/lobid/lodmill/milestones{/number}","notifications_url":"https://api.github.com/repos/lobid/lodmill/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lobid/lodmill/labels{/name}","releases_url":"https://api.github.com/repos/lobid/lodmill/releases{/id}","created_at":"2012-11-05T11:36:04Z","updated_at":"2014-01-07T14:58:57Z","pushed_at":"2014-01-07T14:58:55Z","git_url":"git://github.com/lobid/lodmill.git","ssh_url":"git@github.com:lobid/lodmill.git","clone_url":"https://github.com/lobid/lodmill.git","svn_url":"https://github.com/lobid/lodmill","homepage":null,"size":9130,"stargazers_count":12,"watchers_count":12,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":4,"mirror_url":null,"open_issues_count":77,"forks":4,"open_issues":77,"watchers":12,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lobid/lodmill/pulls/294"},"html":{"href":"https://github.com/lobid/lodmill/pull/294"},"issue":{"href":"https://api.github.com/repos/lobid/lodmill/issues/294"},"comments":{"href":"https://api.github.com/repos/lobid/lodmill/issues/294/comments"},"review_comments":{"href":"https://api.github.com/repos/lobid/lodmill/pulls/294/comments"},"statuses":{"href":"https://api.github.com/repos/lobid/lodmill/statuses/102b48131a87e4952d2a68ed08b16de7127321ce"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":470,"deletions":154,"changed_files":14}}