GitHub PullRequestReviewCommentEvent at 2014-07-01 17:28:23
Repository: astropy
Actor: mdboom
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/astropy/astropy/pulls/comments/14417532","id":14417532,"diff_hunk":"@@ -11,12 +11,71 @@ Overview\n \n Astropy 0.4 is a major release that adds new functionality since the 0.3.x\n series of releases. One new sub-package is included (see `SAMP`_), and many\n-new features have been implemented in the existing sub-pacakges, a few of\n-which are described below. In addition to usability improvements, we have\n+new features have been implemented in the existing sub-pacakges, and\n+highlights are described below. In addition to usability improvements, we have\n made a number of changes in the infrastructure for setting up/installing the\n package, and for the configuration system (see `astropy-helpers`_ and\n `Configuration`_).\n \n+Coordinates\n+-----------\n+\n+The :ref:`astropy-coordinates` sub-package has been re-designed based on\n+feedback and experience with v0.2 and v0.3.  The design motivation is\n+described by\n+`APE5 <https://github.com/astropy/astropy-APEs/blob/master/APE5.rst>`_,\n+and details of the new usage is covered in detail in the\n+:ref:`astropy-coordinates` documentation section. Moving foreward, we\n+do not expect future backwards-incompatible changes to this subpackage.\n+\n+For typical users, the major change is that the recommended way to use\n+coordinate functionality is via the `~astropy.coordinates.SkyCoord` class,\n+instead of the classes like `~astropy.coordinates.ICRS` classes (now called\n+\"frame classes\").\n+\n+For most users of pre-v0.4 coordinates, this means that the best way to\n+adapt old code to the new framework is to change code like::\n+\n+    >>> from astropy import units as u\n+    >>> from astropy.coordinates import ICRS  # or FK5, or Galactic, or similar\n+    >>> coordinate = ICRS(123.4*u.deg, 56.7*u.deg)\n+\n+to instead be::\n+\n+    >>> from astropy import units as u\n+    >>> from astropy.coordinates import SkyCoord\n+    >>> coordinate = SkyCoord(123.4*u.deg, 56.7*u.deg, frame='icrs')\n+\n+Note that usage like::\n+\n+    >>> coordinate = ICRS(123.4, 56.7, unit=('deg', 'deg'))  # NOT RECOMMENDED!\n+\n+will continue to work in v0.4, but will yield a `~astropy.coordinates.SkyCoord`\n+instead of an `~astropy.coordinates.ICRS` object (the former behaves\n+more like the pre-v0.4 `~astropy.coordinates.ICRS`).  This compatibility\n+feature will be removed in the next major version, so you should update\n+your code to use `~astropy.coordinates.SkyCoord` directly by the next\n+release.","path":"docs/whatsnew/0.4.rst","position":50,"original_position":50,"commit_id":"55023cbacb084e42ffc94f5798761ed2dd27bfb3","original_commit_id":"55023cbacb084e42ffc94f5798761ed2dd27bfb3","user":{"login":"mdboom","id":38294,"avatar_url":"https://avatars.githubusercontent.com/u/38294?","gravatar_id":"8988285911e50fbe248b659d43bccf83","url":"https://api.github.com/users/mdboom","html_url":"https://github.com/mdboom","followers_url":"https://api.github.com/users/mdboom/followers","following_url":"https://api.github.com/users/mdboom/following{/other_user}","gists_url":"https://api.github.com/users/mdboom/gists{/gist_id}","starred_url":"https://api.github.com/users/mdboom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdboom/subscriptions","organizations_url":"https://api.github.com/users/mdboom/orgs","repos_url":"https://api.github.com/users/mdboom/repos","events_url":"https://api.github.com/users/mdboom/events{/privacy}","received_events_url":"https://api.github.com/users/mdboom/received_events","type":"User","site_admin":false},"body":"Is there also a `DeprecationWarning` in this case?  If so, maybe mention that here...?","created_at":"2014-07-01T17:28:23Z","updated_at":"2014-07-01T17:28:23Z","html_url":"https://github.com/astropy/astropy/pull/2676#discussion_r14417532","pull_request_url":"https://api.github.com/repos/astropy/astropy/pulls/2676","_links":{"self":{"href":"https://api.github.com/repos/astropy/astropy/pulls/comments/14417532"},"html":{"href":"https://github.com/astropy/astropy/pull/2676#discussion_r14417532"},"pull_request":{"href":"https://api.github.com/repos/astropy/astropy/pulls/2676"}}},"pull_request":{"url":"https://api.github.com/repos/astropy/astropy/pulls/2676","id":17843341,"html_url":"https://github.com/astropy/astropy/pull/2676","diff_url":"https://github.com/astropy/astropy/pull/2676.diff","patch_url":"https://github.com/astropy/astropy/pull/2676.patch","issue_url":"https://api.github.com/repos/astropy/astropy/issues/2676","number":2676,"state":"open","title":"Add 0.4 what's new section about coordinates","user":{"login":"eteq","id":346587,"avatar_url":"https://avatars.githubusercontent.com/u/346587?","gravatar_id":"b2a66b4a75397bcd42fdd7bb399ee553","url":"https://api.github.com/users/eteq","html_url":"https://github.com/eteq","followers_url":"https://api.github.com/users/eteq/followers","following_url":"https://api.github.com/users/eteq/following{/other_user}","gists_url":"https://api.github.com/users/eteq/gists{/gist_id}","starred_url":"https://api.github.com/users/eteq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eteq/subscriptions","organizations_url":"https://api.github.com/users/eteq/orgs","repos_url":"https://api.github.com/users/eteq/repos","events_url":"https://api.github.com/users/eteq/events{/privacy}","received_events_url":"https://api.github.com/users/eteq/received_events","type":"User","site_admin":false},"body":"As discussed in #2416, this adds a \"what's new\" section about the APE5 coordinate changes.\r\n\r\nAs also discussed in #2416, I'm about to begin some travel and am not sure when I'll next have good internet.  So if there are comments that require changes and I'm unresponsive,  @taldcroft, feel free to make your own PR based on this and merge that instead of this.\r\n\r\ncc @astrofrog @Cadair @adrn","created_at":"2014-07-01T17:17:30Z","updated_at":"2014-07-01T17:28:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"144e6f5304019ed94cd58dd5806c4c2c2baaaa60","assignee":null,"milestone":{"url":"https://api.github.com/repos/astropy/astropy/milestones/12","labels_url":"https://api.github.com/repos/astropy/astropy/milestones/12/labels","id":432768,"number":12,"title":"v0.4.0","description":"","creator":{"login":"astrofrog","id":314716,"avatar_url":"https://avatars.githubusercontent.com/u/314716?","gravatar_id":"f586e2a9879fe0a55fd1e3ea529c664f","url":"https://api.github.com/users/astrofrog","html_url":"https://github.com/astrofrog","followers_url":"https://api.github.com/users/astrofrog/followers","following_url":"https://api.github.com/users/astrofrog/following{/other_user}","gists_url":"https://api.github.com/users/astrofrog/gists{/gist_id}","starred_url":"https://api.github.com/users/astrofrog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astrofrog/subscriptions","organizations_url":"https://api.github.com/users/astrofrog/orgs","repos_url":"https://api.github.com/users/astrofrog/repos","events_url":"https://api.github.com/users/astrofrog/events{/privacy}","received_events_url":"https://api.github.com/users/astrofrog/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":352,"state":"open","created_at":"2013-09-20T19:02:11Z","updated_at":"2014-07-01T17:24:48Z","due_on":"2014-06-03T07:00:00Z"},"commits_url":"https://api.github.com/repos/astropy/astropy/pulls/2676/commits","review_comments_url":"https://api.github.com/repos/astropy/astropy/pulls/2676/comments","review_comment_url":"https://api.github.com/repos/astropy/astropy/pulls/comments/{number}","comments_url":"https://api.github.com/repos/astropy/astropy/issues/2676/comments","statuses_url":"https://api.github.com/repos/astropy/astropy/statuses/55023cbacb084e42ffc94f5798761ed2dd27bfb3","head":{"label":"eteq:whats-new-04-coordinates","ref":"whats-new-04-coordinates","sha":"55023cbacb084e42ffc94f5798761ed2dd27bfb3","user":{"login":"eteq","id":346587,"avatar_url":"https://avatars.githubusercontent.com/u/346587?","gravatar_id":"b2a66b4a75397bcd42fdd7bb399ee553","url":"https://api.github.com/users/eteq","html_url":"https://github.com/eteq","followers_url":"https://api.github.com/users/eteq/followers","following_url":"https://api.github.com/users/eteq/following{/other_user}","gists_url":"https://api.github.com/users/eteq/gists{/gist_id}","starred_url":"https://api.github.com/users/eteq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eteq/subscriptions","organizations_url":"https://api.github.com/users/eteq/orgs","repos_url":"https://api.github.com/users/eteq/repos","events_url":"https://api.github.com/users/eteq/events{/privacy}","received_events_url":"https://api.github.com/users/eteq/received_events","type":"User","site_admin":false},"repo":{"id":2103466,"name":"astropy","full_name":"eteq/astropy","owner":{"login":"eteq","id":346587,"avatar_url":"https://avatars.githubusercontent.com/u/346587?","gravatar_id":"b2a66b4a75397bcd42fdd7bb399ee553","url":"https://api.github.com/users/eteq","html_url":"https://github.com/eteq","followers_url":"https://api.github.com/users/eteq/followers","following_url":"https://api.github.com/users/eteq/following{/other_user}","gists_url":"https://api.github.com/users/eteq/gists{/gist_id}","starred_url":"https://api.github.com/users/eteq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eteq/subscriptions","organizations_url":"https://api.github.com/users/eteq/orgs","repos_url":"https://api.github.com/users/eteq/repos","events_url":"https://api.github.com/users/eteq/events{/privacy}","received_events_url":"https://api.github.com/users/eteq/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eteq/astropy","description":"Main AstroPy repository","fork":true,"url":"https://api.github.com/repos/eteq/astropy","forks_url":"https://api.github.com/repos/eteq/astropy/forks","keys_url":"https://api.github.com/repos/eteq/astropy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eteq/astropy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eteq/astropy/teams","hooks_url":"https://api.github.com/repos/eteq/astropy/hooks","issue_events_url":"https://api.github.com/repos/eteq/astropy/issues/events{/number}","events_url":"https://api.github.com/repos/eteq/astropy/events","assignees_url":"https://api.github.com/repos/eteq/astropy/assignees{/user}","branches_url":"https://api.github.com/repos/eteq/astropy/branches{/branch}","tags_url":"https://api.github.com/repos/eteq/astropy/tags","blobs_url":"https://api.github.com/repos/eteq/astropy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eteq/astropy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eteq/astropy/git/refs{/sha}","trees_url":"https://api.github.com/repos/eteq/astropy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eteq/astropy/statuses/{sha}","languages_url":"https://api.github.com/repos/eteq/astropy/languages","stargazers_url":"https://api.github.com/repos/eteq/astropy/stargazers","contributors_url":"https://api.github.com/repos/eteq/astropy/contributors","subscribers_url":"https://api.github.com/repos/eteq/astropy/subscribers","subscription_url":"https://api.github.com/repos/eteq/astropy/subscription","commits_url":"https://api.github.com/repos/eteq/astropy/commits{/sha}","git_commits_url":"https://api.github.com/repos/eteq/astropy/git/commits{/sha}","comments_url":"https://api.github.com/repos/eteq/astropy/comments{/number}","issue_comment_url":"https://api.github.com/repos/eteq/astropy/issues/comments/{number}","contents_url":"https://api.github.com/repos/eteq/astropy/contents/{+path}","compare_url":"https://api.github.com/repos/eteq/astropy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eteq/astropy/merges","archive_url":"https://api.github.com/repos/eteq/astropy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eteq/astropy/downloads","issues_url":"https://api.github.com/repos/eteq/astropy/issues{/number}","pulls_url":"https://api.github.com/repos/eteq/astropy/pulls{/number}","milestones_url":"https://api.github.com/repos/eteq/astropy/milestones{/number}","notifications_url":"https://api.github.com/repos/eteq/astropy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eteq/astropy/labels{/name}","releases_url":"https://api.github.com/repos/eteq/astropy/releases{/id}","created_at":"2011-07-25T21:02:57Z","updated_at":"2014-06-25T09:31:58Z","pushed_at":"2014-07-01T17:27:43Z","git_url":"git://github.com/eteq/astropy.git","ssh_url":"git@github.com:eteq/astropy.git","clone_url":"https://github.com/eteq/astropy.git","svn_url":"https://github.com/eteq/astropy","homepage":"astropy.org","size":45503,"stargazers_count":2,"watchers_count":2,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":2,"default_branch":"staging"}},"base":{"label":"astropy:master","ref":"master","sha":"f5834c6441f302d00848abb2daed14b8c3dadab8","user":{"login":"astropy","id":847984,"avatar_url":"https://avatars.githubusercontent.com/u/847984?","gravatar_id":"df333e02889464493106cdf6de217066","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"repo":{"id":2081289,"name":"astropy","full_name":"astropy/astropy","owner":{"login":"astropy","id":847984,"avatar_url":"https://avatars.githubusercontent.com/u/847984?","gravatar_id":"df333e02889464493106cdf6de217066","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/astropy/astropy","description":"Repository for the Astropy core package","fork":false,"url":"https://api.github.com/repos/astropy/astropy","forks_url":"https://api.github.com/repos/astropy/astropy/forks","keys_url":"https://api.github.com/repos/astropy/astropy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/astropy/astropy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/astropy/astropy/teams","hooks_url":"https://api.github.com/repos/astropy/astropy/hooks","issue_events_url":"https://api.github.com/repos/astropy/astropy/issues/events{/number}","events_url":"https://api.github.com/repos/astropy/astropy/events","assignees_url":"https://api.github.com/repos/astropy/astropy/assignees{/user}","branches_url":"https://api.github.com/repos/astropy/astropy/branches{/branch}","tags_url":"https://api.github.com/repos/astropy/astropy/tags","blobs_url":"https://api.github.com/repos/astropy/astropy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/astropy/astropy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/astropy/astropy/git/refs{/sha}","trees_url":"https://api.github.com/repos/astropy/astropy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/astropy/astropy/statuses/{sha}","languages_url":"https://api.github.com/repos/astropy/astropy/languages","stargazers_url":"https://api.github.com/repos/astropy/astropy/stargazers","contributors_url":"https://api.github.com/repos/astropy/astropy/contributors","subscribers_url":"https://api.github.com/repos/astropy/astropy/subscribers","subscription_url":"https://api.github.com/repos/astropy/astropy/subscription","commits_url":"https://api.github.com/repos/astropy/astropy/commits{/sha}","git_commits_url":"https://api.github.com/repos/astropy/astropy/git/commits{/sha}","comments_url":"https://api.github.com/repos/astropy/astropy/comments{/number}","issue_comment_url":"https://api.github.com/repos/astropy/astropy/issues/comments/{number}","contents_url":"https://api.github.com/repos/astropy/astropy/contents/{+path}","compare_url":"https://api.github.com/repos/astropy/astropy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/astropy/astropy/merges","archive_url":"https://api.github.com/repos/astropy/astropy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/astropy/astropy/downloads","issues_url":"https://api.github.com/repos/astropy/astropy/issues{/number}","pulls_url":"https://api.github.com/repos/astropy/astropy/pulls{/number}","milestones_url":"https://api.github.com/repos/astropy/astropy/milestones{/number}","notifications_url":"https://api.github.com/repos/astropy/astropy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/astropy/astropy/labels{/name}","releases_url":"https://api.github.com/repos/astropy/astropy/releases{/id}","created_at":"2011-07-21T01:33:49Z","updated_at":"2014-07-01T04:20:55Z","pushed_at":"2014-07-01T17:00:37Z","git_url":"git://github.com/astropy/astropy.git","ssh_url":"git@github.com:astropy/astropy.git","clone_url":"https://github.com/astropy/astropy.git","svn_url":"https://github.com/astropy/astropy","homepage":"www.astropy.org","size":60811,"stargazers_count":348,"watchers_count":348,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":252,"mirror_url":null,"open_issues_count":332,"forks":252,"open_issues":332,"watchers":348,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/astropy/astropy/pulls/2676"},"html":{"href":"https://github.com/astropy/astropy/pull/2676"},"issue":{"href":"https://api.github.com/repos/astropy/astropy/issues/2676"},"comments":{"href":"https://api.github.com/repos/astropy/astropy/issues/2676/comments"},"review_comments":{"href":"https://api.github.com/repos/astropy/astropy/pulls/2676/comments"},"review_comment":{"href":"https://api.github.com/repos/astropy/astropy/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/astropy/astropy/pulls/2676/commits"},"statuses":{"href":"https://api.github.com/repos/astropy/astropy/statuses/55023cbacb084e42ffc94f5798761ed2dd27bfb3"}}}}