GitHub PullRequestReviewCommentEvent at 2014-07-02 22:18:36
Repository: finagle
Actor: adamdecaf
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/twitter/finagle/pulls/comments/14487468","id":14487468,"diff_hunk":"@@ -0,0 +1,92 @@\n+package com.twitter.finagle.http\n+import com.twitter.conversions.time._\n+import org.junit.runner.RunWith\n+import org.scalatest.FunSuite\n+import org.scalatest.junit.JUnitRunner\n+\n+@RunWith(classOf[JUnitRunner])\n+class CookieMapTest extends FunSuite {\n+\n+  test(\"no cookies\") {\n+    val request = Request()\n+    request.cookies.isEmpty === true\n+  }\n+\n+  test(\"request cookie basics\") {\n+    val request = Request()\n+    request.headers.set(\"Cookie\", \"name=value; name2=value2\")\n+    assert(request.cookies(\"name\").value == \"value\")\n+    assert(request.cookies(\"name2\").value == \"value2\")\n+    assert(request.cookies.isValid == true)\n+  }\n+\n+  test(\"response cookie basics\") {\n+    val response = Response()\n+    response.headers.set(\"Set-Cookie\", \"name=value; name2=value2\")\n+    assert(response.cookies(\"name\").value == \"value\")\n+    assert(response.cookies(\"name2\").value == \"value2\")\n+  }\n+\n+  test(\"cookie with attributes\") {\n+    val request = Request()\n+    request.headers.set(\"Cookie\", \"name=value; Max-Age=23; Domain=.example.com; Path=/\")\n+    val cookie = request.cookies(\"name\")\n+\n+    assert(cookie.value == \"value\")","path":"finagle-http/src/test/scala/com/twitter/finagle/http/CookieMapTest.scala","position":null,"original_position":35,"commit_id":"f4e7e7dfaa7fb325b0dfac112d5b75fc643617f5","original_commit_id":"012033d754806fa5ca4ffef95e84d442c701d8b7","user":{"login":"adamdecaf","id":120951,"avatar_url":"https://avatars.githubusercontent.com/u/120951?","gravatar_id":"943c786ed589c07dca95e34ec4d530d7","url":"https://api.github.com/users/adamdecaf","html_url":"https://github.com/adamdecaf","followers_url":"https://api.github.com/users/adamdecaf/followers","following_url":"https://api.github.com/users/adamdecaf/following{/other_user}","gists_url":"https://api.github.com/users/adamdecaf/gists{/gist_id}","starred_url":"https://api.github.com/users/adamdecaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamdecaf/subscriptions","organizations_url":"https://api.github.com/users/adamdecaf/orgs","repos_url":"https://api.github.com/users/adamdecaf/repos","events_url":"https://api.github.com/users/adamdecaf/events{/privacy}","received_events_url":"https://api.github.com/users/adamdecaf/received_events","type":"User","site_admin":false},"body":"Updated the PR.","created_at":"2014-07-02T22:18:36Z","updated_at":"2014-07-02T22:18:36Z","html_url":"https://github.com/twitter/finagle/pull/289#discussion_r14487468","pull_request_url":"https://api.github.com/repos/twitter/finagle/pulls/289","_links":{"self":{"href":"https://api.github.com/repos/twitter/finagle/pulls/comments/14487468"},"html":{"href":"https://github.com/twitter/finagle/pull/289#discussion_r14487468"},"pull_request":{"href":"https://api.github.com/repos/twitter/finagle/pulls/289"}}},"pull_request":{"url":"https://api.github.com/repos/twitter/finagle/pulls/289","id":17888488,"html_url":"https://github.com/twitter/finagle/pull/289","diff_url":"https://github.com/twitter/finagle/pull/289.diff","patch_url":"https://github.com/twitter/finagle/pull/289.patch","issue_url":"https://api.github.com/repos/twitter/finagle/issues/289","number":289,"state":"open","title":"Removing specs usage from the CookieMapSpec.","user":{"login":"adamdecaf","id":120951,"avatar_url":"https://avatars.githubusercontent.com/u/120951?","gravatar_id":"943c786ed589c07dca95e34ec4d530d7","url":"https://api.github.com/users/adamdecaf","html_url":"https://github.com/adamdecaf","followers_url":"https://api.github.com/users/adamdecaf/followers","following_url":"https://api.github.com/users/adamdecaf/following{/other_user}","gists_url":"https://api.github.com/users/adamdecaf/gists{/gist_id}","starred_url":"https://api.github.com/users/adamdecaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamdecaf/subscriptions","organizations_url":"https://api.github.com/users/adamdecaf/orgs","repos_url":"https://api.github.com/users/adamdecaf/repos","events_url":"https://api.github.com/users/adamdecaf/events{/privacy}","received_events_url":"https://api.github.com/users/adamdecaf/received_events","type":"User","site_admin":false},"body":"As per the discussion over on this [twitter/util](https://github.com/twitter/util/pull/97) PR I was going to help out with moving a bunch of twitter projects over to cross compile with 2.11. This is just a \"sample\" PR to make sure the style and everything was going to be okay to be merged. ","created_at":"2014-07-02T14:19:28Z","updated_at":"2014-07-02T22:18:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cdcdf4abdae5d24fd2fae8e00ae0b922c4a72d45","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/twitter/finagle/pulls/289/commits","review_comments_url":"https://api.github.com/repos/twitter/finagle/pulls/289/comments","review_comment_url":"https://api.github.com/repos/twitter/finagle/pulls/comments/{number}","comments_url":"https://api.github.com/repos/twitter/finagle/issues/289/comments","statuses_url":"https://api.github.com/repos/twitter/finagle/statuses/f4e7e7dfaa7fb325b0dfac112d5b75fc643617f5","head":{"label":"Banno:remove-specs2","ref":"remove-specs2","sha":"f4e7e7dfaa7fb325b0dfac112d5b75fc643617f5","user":{"login":"Banno","id":371161,"avatar_url":"https://avatars.githubusercontent.com/u/371161?","gravatar_id":"73ffa01da668bf63659a87b8dd0e9c11","url":"https://api.github.com/users/Banno","html_url":"https://github.com/Banno","followers_url":"https://api.github.com/users/Banno/followers","following_url":"https://api.github.com/users/Banno/following{/other_user}","gists_url":"https://api.github.com/users/Banno/gists{/gist_id}","starred_url":"https://api.github.com/users/Banno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Banno/subscriptions","organizations_url":"https://api.github.com/users/Banno/orgs","repos_url":"https://api.github.com/users/Banno/repos","events_url":"https://api.github.com/users/Banno/events{/privacy}","received_events_url":"https://api.github.com/users/Banno/received_events","type":"Organization","site_admin":false},"repo":{"id":21397213,"name":"finagle","full_name":"Banno/finagle","owner":{"login":"Banno","id":371161,"avatar_url":"https://avatars.githubusercontent.com/u/371161?","gravatar_id":"73ffa01da668bf63659a87b8dd0e9c11","url":"https://api.github.com/users/Banno","html_url":"https://github.com/Banno","followers_url":"https://api.github.com/users/Banno/followers","following_url":"https://api.github.com/users/Banno/following{/other_user}","gists_url":"https://api.github.com/users/Banno/gists{/gist_id}","starred_url":"https://api.github.com/users/Banno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Banno/subscriptions","organizations_url":"https://api.github.com/users/Banno/orgs","repos_url":"https://api.github.com/users/Banno/repos","events_url":"https://api.github.com/users/Banno/events{/privacy}","received_events_url":"https://api.github.com/users/Banno/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Banno/finagle","description":"A fault tolerant, protocol-agnostic RPC system","fork":true,"url":"https://api.github.com/repos/Banno/finagle","forks_url":"https://api.github.com/repos/Banno/finagle/forks","keys_url":"https://api.github.com/repos/Banno/finagle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Banno/finagle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Banno/finagle/teams","hooks_url":"https://api.github.com/repos/Banno/finagle/hooks","issue_events_url":"https://api.github.com/repos/Banno/finagle/issues/events{/number}","events_url":"https://api.github.com/repos/Banno/finagle/events","assignees_url":"https://api.github.com/repos/Banno/finagle/assignees{/user}","branches_url":"https://api.github.com/repos/Banno/finagle/branches{/branch}","tags_url":"https://api.github.com/repos/Banno/finagle/tags","blobs_url":"https://api.github.com/repos/Banno/finagle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Banno/finagle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Banno/finagle/git/refs{/sha}","trees_url":"https://api.github.com/repos/Banno/finagle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Banno/finagle/statuses/{sha}","languages_url":"https://api.github.com/repos/Banno/finagle/languages","stargazers_url":"https://api.github.com/repos/Banno/finagle/stargazers","contributors_url":"https://api.github.com/repos/Banno/finagle/contributors","subscribers_url":"https://api.github.com/repos/Banno/finagle/subscribers","subscription_url":"https://api.github.com/repos/Banno/finagle/subscription","commits_url":"https://api.github.com/repos/Banno/finagle/commits{/sha}","git_commits_url":"https://api.github.com/repos/Banno/finagle/git/commits{/sha}","comments_url":"https://api.github.com/repos/Banno/finagle/comments{/number}","issue_comment_url":"https://api.github.com/repos/Banno/finagle/issues/comments/{number}","contents_url":"https://api.github.com/repos/Banno/finagle/contents/{+path}","compare_url":"https://api.github.com/repos/Banno/finagle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Banno/finagle/merges","archive_url":"https://api.github.com/repos/Banno/finagle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Banno/finagle/downloads","issues_url":"https://api.github.com/repos/Banno/finagle/issues{/number}","pulls_url":"https://api.github.com/repos/Banno/finagle/pulls{/number}","milestones_url":"https://api.github.com/repos/Banno/finagle/milestones{/number}","notifications_url":"https://api.github.com/repos/Banno/finagle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Banno/finagle/labels{/name}","releases_url":"https://api.github.com/repos/Banno/finagle/releases{/id}","created_at":"2014-07-01T17:52:21Z","updated_at":"2014-07-01T15:35:21Z","pushed_at":"2014-07-02T22:18:11Z","git_url":"git://github.com/Banno/finagle.git","ssh_url":"git@github.com:Banno/finagle.git","clone_url":"https://github.com/Banno/finagle.git","svn_url":"https://github.com/Banno/finagle","homepage":"http://twitter.github.io/finagle","size":24977,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"twitter:master","ref":"master","sha":"84e36f37a76f488d16e18ae827d6b8fa2a8be8ef","user":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?","gravatar_id":"2f4a8254d032a8ec5e4c48d461e54fcc","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"repo":{"id":1007362,"name":"finagle","full_name":"twitter/finagle","owner":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?","gravatar_id":"2f4a8254d032a8ec5e4c48d461e54fcc","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twitter/finagle","description":"A fault tolerant, protocol-agnostic RPC system","fork":false,"url":"https://api.github.com/repos/twitter/finagle","forks_url":"https://api.github.com/repos/twitter/finagle/forks","keys_url":"https://api.github.com/repos/twitter/finagle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twitter/finagle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twitter/finagle/teams","hooks_url":"https://api.github.com/repos/twitter/finagle/hooks","issue_events_url":"https://api.github.com/repos/twitter/finagle/issues/events{/number}","events_url":"https://api.github.com/repos/twitter/finagle/events","assignees_url":"https://api.github.com/repos/twitter/finagle/assignees{/user}","branches_url":"https://api.github.com/repos/twitter/finagle/branches{/branch}","tags_url":"https://api.github.com/repos/twitter/finagle/tags","blobs_url":"https://api.github.com/repos/twitter/finagle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twitter/finagle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twitter/finagle/git/refs{/sha}","trees_url":"https://api.github.com/repos/twitter/finagle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twitter/finagle/statuses/{sha}","languages_url":"https://api.github.com/repos/twitter/finagle/languages","stargazers_url":"https://api.github.com/repos/twitter/finagle/stargazers","contributors_url":"https://api.github.com/repos/twitter/finagle/contributors","subscribers_url":"https://api.github.com/repos/twitter/finagle/subscribers","subscription_url":"https://api.github.com/repos/twitter/finagle/subscription","commits_url":"https://api.github.com/repos/twitter/finagle/commits{/sha}","git_commits_url":"https://api.github.com/repos/twitter/finagle/git/commits{/sha}","comments_url":"https://api.github.com/repos/twitter/finagle/comments{/number}","issue_comment_url":"https://api.github.com/repos/twitter/finagle/issues/comments/{number}","contents_url":"https://api.github.com/repos/twitter/finagle/contents/{+path}","compare_url":"https://api.github.com/repos/twitter/finagle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twitter/finagle/merges","archive_url":"https://api.github.com/repos/twitter/finagle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twitter/finagle/downloads","issues_url":"https://api.github.com/repos/twitter/finagle/issues{/number}","pulls_url":"https://api.github.com/repos/twitter/finagle/pulls{/number}","milestones_url":"https://api.github.com/repos/twitter/finagle/milestones{/number}","notifications_url":"https://api.github.com/repos/twitter/finagle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twitter/finagle/labels{/name}","releases_url":"https://api.github.com/repos/twitter/finagle/releases{/id}","created_at":"2010-10-19T22:10:09Z","updated_at":"2014-07-01T19:39:35Z","pushed_at":"2014-06-25T19:22:24Z","git_url":"git://github.com/twitter/finagle.git","ssh_url":"git@github.com:twitter/finagle.git","clone_url":"https://github.com/twitter/finagle.git","svn_url":"https://github.com/twitter/finagle","homepage":"http://twitter.github.io/finagle","size":24977,"stargazers_count":2661,"watchers_count":2661,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":455,"mirror_url":null,"open_issues_count":40,"forks":455,"open_issues":40,"watchers":2661,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/twitter/finagle/pulls/289"},"html":{"href":"https://github.com/twitter/finagle/pull/289"},"issue":{"href":"https://api.github.com/repos/twitter/finagle/issues/289"},"comments":{"href":"https://api.github.com/repos/twitter/finagle/issues/289/comments"},"review_comments":{"href":"https://api.github.com/repos/twitter/finagle/pulls/289/comments"},"review_comment":{"href":"https://api.github.com/repos/twitter/finagle/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/twitter/finagle/pulls/289/commits"},"statuses":{"href":"https://api.github.com/repos/twitter/finagle/statuses/f4e7e7dfaa7fb325b0dfac112d5b75fc643617f5"}}}}