GitHub PullRequestReviewCommentEvent at 2014-06-21 20:41:07
Repository: vgstation13
Actor: N3X15
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/d3athrow/vgstation13/pulls/comments/14051532","id":14051532,"diff_hunk":"@@ -25,16 +25,23 @@ var/global/datum/controller/garbage_collector/garbage\n \n \t\tgarbage = src\n \n-/datum/controller/garbage_collector/proc/addTrash(const/atom/movable/AM)\n-\tif (isnull(AM))\n+/datum/controller/garbage_collector/proc/addTrash(const/datum/D)\n+\tif (isnull(D))\n \t\treturn\n \n \tif (del_everything)\n-\t\tdel AM\n+\t\tdel D\n \t\thard_dels++\n \t\tdels_count++\n \t\treturn\n \n+\tif(!istype(D, /atom/movable))","path":"code/controllers/garbage.dm","position":26,"original_position":26,"commit_id":"64a8c4ae77f4aefea988da938932580b6911be77","original_commit_id":"64a8c4ae77f4aefea988da938932580b6911be77","user":{"login":"N3X15","id":110073,"avatar_url":"https://avatars.githubusercontent.com/u/110073?","gravatar_id":"85b30979271e470ba965725bcb602737","url":"https://api.github.com/users/N3X15","html_url":"https://github.com/N3X15","followers_url":"https://api.github.com/users/N3X15/followers","following_url":"https://api.github.com/users/N3X15/following{/other_user}","gists_url":"https://api.github.com/users/N3X15/gists{/gist_id}","starred_url":"https://api.github.com/users/N3X15/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/N3X15/subscriptions","organizations_url":"https://api.github.com/users/N3X15/orgs","repos_url":"https://api.github.com/users/N3X15/repos","events_url":"https://api.github.com/users/N3X15/events{/privacy}","received_events_url":"https://api.github.com/users/N3X15/received_events","type":"User","site_admin":false},"body":"If you left the arg as /atom/movable, you could just go if(!istype(AM)) here.","created_at":"2014-06-21T20:41:07Z","updated_at":"2014-06-21T20:41:07Z","html_url":"https://github.com/d3athrow/vgstation13/pull/940#discussion_r14051532","pull_request_url":"https://api.github.com/repos/d3athrow/vgstation13/pulls/940","_links":{"self":{"href":"https://api.github.com/repos/d3athrow/vgstation13/pulls/comments/14051532"},"html":{"href":"https://github.com/d3athrow/vgstation13/pull/940#discussion_r14051532"},"pull_request":{"href":"https://api.github.com/repos/d3athrow/vgstation13/pulls/940"}}},"pull_request":{"url":"https://api.github.com/repos/d3athrow/vgstation13/pulls/940","id":17439814,"html_url":"https://github.com/d3athrow/vgstation13/pull/940","diff_url":"https://github.com/d3athrow/vgstation13/pull/940.diff","patch_url":"https://github.com/d3athrow/vgstation13/pull/940.patch","issue_url":"https://api.github.com/repos/d3athrow/vgstation13/issues/940","number":940,"state":"open","title":"Refactor GC controller procs.","user":{"login":"ESwordTheCat","id":6364195,"avatar_url":"https://avatars.githubusercontent.com/u/6364195?","gravatar_id":"703dd8eb6fba2aed51ff2d5c5205ae68","url":"https://api.github.com/users/ESwordTheCat","html_url":"https://github.com/ESwordTheCat","followers_url":"https://api.github.com/users/ESwordTheCat/followers","following_url":"https://api.github.com/users/ESwordTheCat/following{/other_user}","gists_url":"https://api.github.com/users/ESwordTheCat/gists{/gist_id}","starred_url":"https://api.github.com/users/ESwordTheCat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ESwordTheCat/subscriptions","organizations_url":"https://api.github.com/users/ESwordTheCat/orgs","repos_url":"https://api.github.com/users/ESwordTheCat/repos","events_url":"https://api.github.com/users/ESwordTheCat/events{/privacy}","received_events_url":"https://api.github.com/users/ESwordTheCat/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-06-21T14:26:55Z","updated_at":"2014-06-21T20:41:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"341a257905c9d435a48da7237877b2e4bdbb4db4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/d3athrow/vgstation13/pulls/940/commits","review_comments_url":"https://api.github.com/repos/d3athrow/vgstation13/pulls/940/comments","review_comment_url":"https://api.github.com/repos/d3athrow/vgstation13/pulls/comments/{number}","comments_url":"https://api.github.com/repos/d3athrow/vgstation13/issues/940/comments","statuses_url":"https://api.github.com/repos/d3athrow/vgstation13/statuses/64a8c4ae77f4aefea988da938932580b6911be77","head":{"label":"ESwordTheCat:hWvbOvDa","ref":"hWvbOvDa","sha":"64a8c4ae77f4aefea988da938932580b6911be77","user":{"login":"ESwordTheCat","id":6364195,"avatar_url":"https://avatars.githubusercontent.com/u/6364195?","gravatar_id":"703dd8eb6fba2aed51ff2d5c5205ae68","url":"https://api.github.com/users/ESwordTheCat","html_url":"https://github.com/ESwordTheCat","followers_url":"https://api.github.com/users/ESwordTheCat/followers","following_url":"https://api.github.com/users/ESwordTheCat/following{/other_user}","gists_url":"https://api.github.com/users/ESwordTheCat/gists{/gist_id}","starred_url":"https://api.github.com/users/ESwordTheCat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ESwordTheCat/subscriptions","organizations_url":"https://api.github.com/users/ESwordTheCat/orgs","repos_url":"https://api.github.com/users/ESwordTheCat/repos","events_url":"https://api.github.com/users/ESwordTheCat/events{/privacy}","received_events_url":"https://api.github.com/users/ESwordTheCat/received_events","type":"User","site_admin":false},"repo":{"id":19178105,"name":"vgstation13","full_name":"ESwordTheCat/vgstation13","owner":{"login":"ESwordTheCat","id":6364195,"avatar_url":"https://avatars.githubusercontent.com/u/6364195?","gravatar_id":"703dd8eb6fba2aed51ff2d5c5205ae68","url":"https://api.github.com/users/ESwordTheCat","html_url":"https://github.com/ESwordTheCat","followers_url":"https://api.github.com/users/ESwordTheCat/followers","following_url":"https://api.github.com/users/ESwordTheCat/following{/other_user}","gists_url":"https://api.github.com/users/ESwordTheCat/gists{/gist_id}","starred_url":"https://api.github.com/users/ESwordTheCat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ESwordTheCat/subscriptions","organizations_url":"https://api.github.com/users/ESwordTheCat/orgs","repos_url":"https://api.github.com/users/ESwordTheCat/repos","events_url":"https://api.github.com/users/ESwordTheCat/events{/privacy}","received_events_url":"https://api.github.com/users/ESwordTheCat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ESwordTheCat/vgstation13","description":"This is the vgstation's fork of baystation12's code.","fork":true,"url":"https://api.github.com/repos/ESwordTheCat/vgstation13","forks_url":"https://api.github.com/repos/ESwordTheCat/vgstation13/forks","keys_url":"https://api.github.com/repos/ESwordTheCat/vgstation13/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ESwordTheCat/vgstation13/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ESwordTheCat/vgstation13/teams","hooks_url":"https://api.github.com/repos/ESwordTheCat/vgstation13/hooks","issue_events_url":"https://api.github.com/repos/ESwordTheCat/vgstation13/issues/events{/number}","events_url":"https://api.github.com/repos/ESwordTheCat/vgstation13/events","assignees_url":"https://api.github.com/repos/ESwordTheCat/vgstation13/assignees{/user}","branches_url":"https://api.github.com/repos/ESwordTheCat/vgstation13/branches{/branch}","tags_url":"https://api.github.com/repos/ESwordTheCat/vgstation13/tags","blobs_url":"https://api.github.com/repos/ESwordTheCat/vgstation13/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ESwordTheCat/vgstation13/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ESwordTheCat/vgstation13/git/refs{/sha}","trees_url":"https://api.github.com/repos/ESwordTheCat/vgstation13/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ESwordTheCat/vgstation13/statuses/{sha}","languages_url":"https://api.github.com/repos/ESwordTheCat/vgstation13/languages","stargazers_url":"https://api.github.com/repos/ESwordTheCat/vgstation13/stargazers","contributors_url":"https://api.github.com/repos/ESwordTheCat/vgstation13/contributors","subscribers_url":"https://api.github.com/repos/ESwordTheCat/vgstation13/subscribers","subscription_url":"https://api.github.com/repos/ESwordTheCat/vgstation13/subscription","commits_url":"https://api.github.com/repos/ESwordTheCat/vgstation13/commits{/sha}","git_commits_url":"https://api.github.com/repos/ESwordTheCat/vgstation13/git/commits{/sha}","comments_url":"https://api.github.com/repos/ESwordTheCat/vgstation13/comments{/number}","issue_comment_url":"https://api.github.com/repos/ESwordTheCat/vgstation13/issues/comments/{number}","contents_url":"https://api.github.com/repos/ESwordTheCat/vgstation13/contents/{+path}","compare_url":"https://api.github.com/repos/ESwordTheCat/vgstation13/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ESwordTheCat/vgstation13/merges","archive_url":"https://api.github.com/repos/ESwordTheCat/vgstation13/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ESwordTheCat/vgstation13/downloads","issues_url":"https://api.github.com/repos/ESwordTheCat/vgstation13/issues{/number}","pulls_url":"https://api.github.com/repos/ESwordTheCat/vgstation13/pulls{/number}","milestones_url":"https://api.github.com/repos/ESwordTheCat/vgstation13/milestones{/number}","notifications_url":"https://api.github.com/repos/ESwordTheCat/vgstation13/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ESwordTheCat/vgstation13/labels{/name}","releases_url":"https://api.github.com/repos/ESwordTheCat/vgstation13/releases{/id}","created_at":"2014-04-26T13:33:14Z","updated_at":"2014-06-21T14:30:46Z","pushed_at":"2014-06-21T14:30:46Z","git_url":"git://github.com/ESwordTheCat/vgstation13.git","ssh_url":"git@github.com:ESwordTheCat/vgstation13.git","clone_url":"https://github.com/ESwordTheCat/vgstation13.git","svn_url":"https://github.com/ESwordTheCat/vgstation13","homepage":"","size":529468,"stargazers_count":0,"watchers_count":0,"language":"DM","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"d3athrow:Bleeding-Edge","ref":"Bleeding-Edge","sha":"18946dc798808216288c18a89b942a594daa11de","user":{"login":"d3athrow","id":706947,"avatar_url":"https://avatars.githubusercontent.com/u/706947?","gravatar_id":"a53449aa3ba352fd64103e3721aaa89e","url":"https://api.github.com/users/d3athrow","html_url":"https://github.com/d3athrow","followers_url":"https://api.github.com/users/d3athrow/followers","following_url":"https://api.github.com/users/d3athrow/following{/other_user}","gists_url":"https://api.github.com/users/d3athrow/gists{/gist_id}","starred_url":"https://api.github.com/users/d3athrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d3athrow/subscriptions","organizations_url":"https://api.github.com/users/d3athrow/orgs","repos_url":"https://api.github.com/users/d3athrow/repos","events_url":"https://api.github.com/users/d3athrow/events{/privacy}","received_events_url":"https://api.github.com/users/d3athrow/received_events","type":"User","site_admin":false},"repo":{"id":10441188,"name":"vgstation13","full_name":"d3athrow/vgstation13","owner":{"login":"d3athrow","id":706947,"avatar_url":"https://avatars.githubusercontent.com/u/706947?","gravatar_id":"a53449aa3ba352fd64103e3721aaa89e","url":"https://api.github.com/users/d3athrow","html_url":"https://github.com/d3athrow","followers_url":"https://api.github.com/users/d3athrow/followers","following_url":"https://api.github.com/users/d3athrow/following{/other_user}","gists_url":"https://api.github.com/users/d3athrow/gists{/gist_id}","starred_url":"https://api.github.com/users/d3athrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d3athrow/subscriptions","organizations_url":"https://api.github.com/users/d3athrow/orgs","repos_url":"https://api.github.com/users/d3athrow/repos","events_url":"https://api.github.com/users/d3athrow/events{/privacy}","received_events_url":"https://api.github.com/users/d3athrow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/d3athrow/vgstation13","description":"This is the vgstation's fork of baystation12's code.","fork":true,"url":"https://api.github.com/repos/d3athrow/vgstation13","forks_url":"https://api.github.com/repos/d3athrow/vgstation13/forks","keys_url":"https://api.github.com/repos/d3athrow/vgstation13/keys{/key_id}","collaborators_url":"https://api.github.com/repos/d3athrow/vgstation13/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/d3athrow/vgstation13/teams","hooks_url":"https://api.github.com/repos/d3athrow/vgstation13/hooks","issue_events_url":"https://api.github.com/repos/d3athrow/vgstation13/issues/events{/number}","events_url":"https://api.github.com/repos/d3athrow/vgstation13/events","assignees_url":"https://api.github.com/repos/d3athrow/vgstation13/assignees{/user}","branches_url":"https://api.github.com/repos/d3athrow/vgstation13/branches{/branch}","tags_url":"https://api.github.com/repos/d3athrow/vgstation13/tags","blobs_url":"https://api.github.com/repos/d3athrow/vgstation13/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/d3athrow/vgstation13/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/d3athrow/vgstation13/git/refs{/sha}","trees_url":"https://api.github.com/repos/d3athrow/vgstation13/git/trees{/sha}","statuses_url":"https://api.github.com/repos/d3athrow/vgstation13/statuses/{sha}","languages_url":"https://api.github.com/repos/d3athrow/vgstation13/languages","stargazers_url":"https://api.github.com/repos/d3athrow/vgstation13/stargazers","contributors_url":"https://api.github.com/repos/d3athrow/vgstation13/contributors","subscribers_url":"https://api.github.com/repos/d3athrow/vgstation13/subscribers","subscription_url":"https://api.github.com/repos/d3athrow/vgstation13/subscription","commits_url":"https://api.github.com/repos/d3athrow/vgstation13/commits{/sha}","git_commits_url":"https://api.github.com/repos/d3athrow/vgstation13/git/commits{/sha}","comments_url":"https://api.github.com/repos/d3athrow/vgstation13/comments{/number}","issue_comment_url":"https://api.github.com/repos/d3athrow/vgstation13/issues/comments/{number}","contents_url":"https://api.github.com/repos/d3athrow/vgstation13/contents/{+path}","compare_url":"https://api.github.com/repos/d3athrow/vgstation13/compare/{base}...{head}","merges_url":"https://api.github.com/repos/d3athrow/vgstation13/merges","archive_url":"https://api.github.com/repos/d3athrow/vgstation13/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/d3athrow/vgstation13/downloads","issues_url":"https://api.github.com/repos/d3athrow/vgstation13/issues{/number}","pulls_url":"https://api.github.com/repos/d3athrow/vgstation13/pulls{/number}","milestones_url":"https://api.github.com/repos/d3athrow/vgstation13/milestones{/number}","notifications_url":"https://api.github.com/repos/d3athrow/vgstation13/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/d3athrow/vgstation13/labels{/name}","releases_url":"https://api.github.com/repos/d3athrow/vgstation13/releases{/id}","created_at":"2013-06-02T19:39:54Z","updated_at":"2014-06-21T20:39:03Z","pushed_at":"2014-06-21T20:39:03Z","git_url":"git://github.com/d3athrow/vgstation13.git","ssh_url":"git@github.com:d3athrow/vgstation13.git","clone_url":"https://github.com/d3athrow/vgstation13.git","svn_url":"https://github.com/d3athrow/vgstation13","homepage":"","size":586140,"stargazers_count":23,"watchers_count":23,"language":"DM","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":72,"mirror_url":null,"open_issues_count":128,"forks":72,"open_issues":128,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/d3athrow/vgstation13/pulls/940"},"html":{"href":"https://github.com/d3athrow/vgstation13/pull/940"},"issue":{"href":"https://api.github.com/repos/d3athrow/vgstation13/issues/940"},"comments":{"href":"https://api.github.com/repos/d3athrow/vgstation13/issues/940/comments"},"review_comments":{"href":"https://api.github.com/repos/d3athrow/vgstation13/pulls/940/comments"},"review_comment":{"href":"https://api.github.com/repos/d3athrow/vgstation13/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/d3athrow/vgstation13/pulls/940/commits"},"statuses":{"href":"https://api.github.com/repos/d3athrow/vgstation13/statuses/64a8c4ae77f4aefea988da938932580b6911be77"}}}}