GitHub PullRequestEvent at 2014-10-01 19:42:59
Repository: direct-sqlite
Actor: nurpax
Payload: {"action":"closed","number":49,"pull_request":{"url":"https://api.github.com/repos/IreneKnapp/direct-sqlite/pulls/49","id":21200961,"html_url":"https://github.com/IreneKnapp/direct-sqlite/pull/49","diff_url":"https://github.com/IreneKnapp/direct-sqlite/pull/49.diff","patch_url":"https://github.com/IreneKnapp/direct-sqlite/pull/49.patch","issue_url":"https://api.github.com/repos/IreneKnapp/direct-sqlite/issues/49","number":49,"state":"closed","locked":false,"title":"Bump version bounds for text 1.2.0.0 (released September 9, 2014)","user":{"login":"joeyadams","id":425532,"avatar_url":"https://avatars.githubusercontent.com/u/425532?v=2","gravatar_id":"","url":"https://api.github.com/users/joeyadams","html_url":"https://github.com/joeyadams","followers_url":"https://api.github.com/users/joeyadams/followers","following_url":"https://api.github.com/users/joeyadams/following{/other_user}","gists_url":"https://api.github.com/users/joeyadams/gists{/gist_id}","starred_url":"https://api.github.com/users/joeyadams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joeyadams/subscriptions","organizations_url":"https://api.github.com/users/joeyadams/orgs","repos_url":"https://api.github.com/users/joeyadams/repos","events_url":"https://api.github.com/users/joeyadams/events{/privacy}","received_events_url":"https://api.github.com/users/joeyadams/received_events","type":"User","site_admin":false},"body":"Right now, bytestring is on 0.10.4.0 (not affected by < 1), and text is on 1.2.0.0 (affected by < 1.2).  This lets direct-sqlite be built with the latest version of the text package (released on September 9, 2014).  I tested cabal install and cabal test do work with these packages under GHC 7.8.3 and cabal-install 1.20.0.3.\r\n\r\nI'm not a fan of putting upper bounds on dependencies everywhere, nor is most of the Haskell community (I think...I could be wrong).  They force us to update bounds every time a new version of a dependency comes out.  On the other hand, this forces us to test to make sure our code actually works with the new version.\r\n\r\nThis pull request removes the upper bounds entirely.  If you instead prefer upper bounds on dependencies, please:\r\n * Bump the upper bound of text so we can build with 1.2.\r\n * Fix the bound on bytestring to be < 0.10 instead of < 1.  That, or fix text to be < 2.  As is, the comparisons are inconsistent; the bytestring bound waits for A.x.x.x to change, while the text bound waits for A.B.x.x to change.","created_at":"2014-09-14T06:06:49Z","updated_at":"2014-10-01T19:42:58Z","closed_at":"2014-10-01T19:42:58Z","merged_at":"2014-10-01T19:42:58Z","merge_commit_sha":"2d6d91a2339be2af839bdc2b3ebb41efc5de7cef","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/IreneKnapp/direct-sqlite/pulls/49/commits","review_comments_url":"https://api.github.com/repos/IreneKnapp/direct-sqlite/pulls/49/comments","review_comment_url":"https://api.github.com/repos/IreneKnapp/direct-sqlite/pulls/comments/{number}","comments_url":"https://api.github.com/repos/IreneKnapp/direct-sqlite/issues/49/comments","statuses_url":"https://api.github.com/repos/IreneKnapp/direct-sqlite/statuses/8c7c2762775f20afaac833557cd35ba3fbf2cfb8","head":{"label":"joeyadams:text-version-bound","ref":"text-version-bound","sha":"8c7c2762775f20afaac833557cd35ba3fbf2cfb8","user":{"login":"joeyadams","id":425532,"avatar_url":"https://avatars.githubusercontent.com/u/425532?v=2","gravatar_id":"","url":"https://api.github.com/users/joeyadams","html_url":"https://github.com/joeyadams","followers_url":"https://api.github.com/users/joeyadams/followers","following_url":"https://api.github.com/users/joeyadams/following{/other_user}","gists_url":"https://api.github.com/users/joeyadams/gists{/gist_id}","starred_url":"https://api.github.com/users/joeyadams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joeyadams/subscriptions","organizations_url":"https://api.github.com/users/joeyadams/orgs","repos_url":"https://api.github.com/users/joeyadams/repos","events_url":"https://api.github.com/users/joeyadams/events{/privacy}","received_events_url":"https://api.github.com/users/joeyadams/received_events","type":"User","site_admin":false},"repo":{"id":5429327,"name":"direct-sqlite","full_name":"joeyadams/direct-sqlite","owner":{"login":"joeyadams","id":425532,"avatar_url":"https://avatars.githubusercontent.com/u/425532?v=2","gravatar_id":"","url":"https://api.github.com/users/joeyadams","html_url":"https://github.com/joeyadams","followers_url":"https://api.github.com/users/joeyadams/followers","following_url":"https://api.github.com/users/joeyadams/following{/other_user}","gists_url":"https://api.github.com/users/joeyadams/gists{/gist_id}","starred_url":"https://api.github.com/users/joeyadams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joeyadams/subscriptions","organizations_url":"https://api.github.com/users/joeyadams/orgs","repos_url":"https://api.github.com/users/joeyadams/repos","events_url":"https://api.github.com/users/joeyadams/events{/privacy}","received_events_url":"https://api.github.com/users/joeyadams/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joeyadams/direct-sqlite","description":"","fork":true,"url":"https://api.github.com/repos/joeyadams/direct-sqlite","forks_url":"https://api.github.com/repos/joeyadams/direct-sqlite/forks","keys_url":"https://api.github.com/repos/joeyadams/direct-sqlite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joeyadams/direct-sqlite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joeyadams/direct-sqlite/teams","hooks_url":"https://api.github.com/repos/joeyadams/direct-sqlite/hooks","issue_events_url":"https://api.github.com/repos/joeyadams/direct-sqlite/issues/events{/number}","events_url":"https://api.github.com/repos/joeyadams/direct-sqlite/events","assignees_url":"https://api.github.com/repos/joeyadams/direct-sqlite/assignees{/user}","branches_url":"https://api.github.com/repos/joeyadams/direct-sqlite/branches{/branch}","tags_url":"https://api.github.com/repos/joeyadams/direct-sqlite/tags","blobs_url":"https://api.github.com/repos/joeyadams/direct-sqlite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joeyadams/direct-sqlite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joeyadams/direct-sqlite/git/refs{/sha}","trees_url":"https://api.github.com/repos/joeyadams/direct-sqlite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joeyadams/direct-sqlite/statuses/{sha}","languages_url":"https://api.github.com/repos/joeyadams/direct-sqlite/languages","stargazers_url":"https://api.github.com/repos/joeyadams/direct-sqlite/stargazers","contributors_url":"https://api.github.com/repos/joeyadams/direct-sqlite/contributors","subscribers_url":"https://api.github.com/repos/joeyadams/direct-sqlite/subscribers","subscription_url":"https://api.github.com/repos/joeyadams/direct-sqlite/subscription","commits_url":"https://api.github.com/repos/joeyadams/direct-sqlite/commits{/sha}","git_commits_url":"https://api.github.com/repos/joeyadams/direct-sqlite/git/commits{/sha}","comments_url":"https://api.github.com/repos/joeyadams/direct-sqlite/comments{/number}","issue_comment_url":"https://api.github.com/repos/joeyadams/direct-sqlite/issues/comments/{number}","contents_url":"https://api.github.com/repos/joeyadams/direct-sqlite/contents/{+path}","compare_url":"https://api.github.com/repos/joeyadams/direct-sqlite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joeyadams/direct-sqlite/merges","archive_url":"https://api.github.com/repos/joeyadams/direct-sqlite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joeyadams/direct-sqlite/downloads","issues_url":"https://api.github.com/repos/joeyadams/direct-sqlite/issues{/number}","pulls_url":"https://api.github.com/repos/joeyadams/direct-sqlite/pulls{/number}","milestones_url":"https://api.github.com/repos/joeyadams/direct-sqlite/milestones{/number}","notifications_url":"https://api.github.com/repos/joeyadams/direct-sqlite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joeyadams/direct-sqlite/labels{/name}","releases_url":"https://api.github.com/repos/joeyadams/direct-sqlite/releases{/id}","created_at":"2012-08-15T17:43:55Z","updated_at":"2014-09-14T05:43:18Z","pushed_at":"2014-09-14T05:52:31Z","git_url":"git://github.com/joeyadams/direct-sqlite.git","ssh_url":"git@github.com:joeyadams/direct-sqlite.git","clone_url":"https://github.com/joeyadams/direct-sqlite.git","svn_url":"https://github.com/joeyadams/direct-sqlite","homepage":null,"size":2348,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"IreneKnapp:master","ref":"master","sha":"2c47a2df2902bb847623d00ecfa57fcd66a1bf64","user":{"login":"IreneKnapp","id":157678,"avatar_url":"https://avatars.githubusercontent.com/u/157678?v=2","gravatar_id":"","url":"https://api.github.com/users/IreneKnapp","html_url":"https://github.com/IreneKnapp","followers_url":"https://api.github.com/users/IreneKnapp/followers","following_url":"https://api.github.com/users/IreneKnapp/following{/other_user}","gists_url":"https://api.github.com/users/IreneKnapp/gists{/gist_id}","starred_url":"https://api.github.com/users/IreneKnapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IreneKnapp/subscriptions","organizations_url":"https://api.github.com/users/IreneKnapp/orgs","repos_url":"https://api.github.com/users/IreneKnapp/repos","events_url":"https://api.github.com/users/IreneKnapp/events{/privacy}","received_events_url":"https://api.github.com/users/IreneKnapp/received_events","type":"User","site_admin":false},"repo":{"id":5278058,"name":"direct-sqlite","full_name":"IreneKnapp/direct-sqlite","owner":{"login":"IreneKnapp","id":157678,"avatar_url":"https://avatars.githubusercontent.com/u/157678?v=2","gravatar_id":"","url":"https://api.github.com/users/IreneKnapp","html_url":"https://github.com/IreneKnapp","followers_url":"https://api.github.com/users/IreneKnapp/followers","following_url":"https://api.github.com/users/IreneKnapp/following{/other_user}","gists_url":"https://api.github.com/users/IreneKnapp/gists{/gist_id}","starred_url":"https://api.github.com/users/IreneKnapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IreneKnapp/subscriptions","organizations_url":"https://api.github.com/users/IreneKnapp/orgs","repos_url":"https://api.github.com/users/IreneKnapp/repos","events_url":"https://api.github.com/users/IreneKnapp/events{/privacy}","received_events_url":"https://api.github.com/users/IreneKnapp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/IreneKnapp/direct-sqlite","description":"","fork":false,"url":"https://api.github.com/repos/IreneKnapp/direct-sqlite","forks_url":"https://api.github.com/repos/IreneKnapp/direct-sqlite/forks","keys_url":"https://api.github.com/repos/IreneKnapp/direct-sqlite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IreneKnapp/direct-sqlite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IreneKnapp/direct-sqlite/teams","hooks_url":"https://api.github.com/repos/IreneKnapp/direct-sqlite/hooks","issue_events_url":"https://api.github.com/repos/IreneKnapp/direct-sqlite/issues/events{/number}","events_url":"https://api.github.com/repos/IreneKnapp/direct-sqlite/events","assignees_url":"https://api.github.com/repos/IreneKnapp/direct-sqlite/assignees{/user}","branches_url":"https://api.github.com/repos/IreneKnapp/direct-sqlite/branches{/branch}","tags_url":"https://api.github.com/repos/IreneKnapp/direct-sqlite/tags","blobs_url":"https://api.github.com/repos/IreneKnapp/direct-sqlite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IreneKnapp/direct-sqlite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IreneKnapp/direct-sqlite/git/refs{/sha}","trees_url":"https://api.github.com/repos/IreneKnapp/direct-sqlite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IreneKnapp/direct-sqlite/statuses/{sha}","languages_url":"https://api.github.com/repos/IreneKnapp/direct-sqlite/languages","stargazers_url":"https://api.github.com/repos/IreneKnapp/direct-sqlite/stargazers","contributors_url":"https://api.github.com/repos/IreneKnapp/direct-sqlite/contributors","subscribers_url":"https://api.github.com/repos/IreneKnapp/direct-sqlite/subscribers","subscription_url":"https://api.github.com/repos/IreneKnapp/direct-sqlite/subscription","commits_url":"https://api.github.com/repos/IreneKnapp/direct-sqlite/commits{/sha}","git_commits_url":"https://api.github.com/repos/IreneKnapp/direct-sqlite/git/commits{/sha}","comments_url":"https://api.github.com/repos/IreneKnapp/direct-sqlite/comments{/number}","issue_comment_url":"https://api.github.com/repos/IreneKnapp/direct-sqlite/issues/comments/{number}","contents_url":"https://api.github.com/repos/IreneKnapp/direct-sqlite/contents/{+path}","compare_url":"https://api.github.com/repos/IreneKnapp/direct-sqlite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IreneKnapp/direct-sqlite/merges","archive_url":"https://api.github.com/repos/IreneKnapp/direct-sqlite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IreneKnapp/direct-sqlite/downloads","issues_url":"https://api.github.com/repos/IreneKnapp/direct-sqlite/issues{/number}","pulls_url":"https://api.github.com/repos/IreneKnapp/direct-sqlite/pulls{/number}","milestones_url":"https://api.github.com/repos/IreneKnapp/direct-sqlite/milestones{/number}","notifications_url":"https://api.github.com/repos/IreneKnapp/direct-sqlite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IreneKnapp/direct-sqlite/labels{/name}","releases_url":"https://api.github.com/repos/IreneKnapp/direct-sqlite/releases{/id}","created_at":"2012-08-02T21:24:00Z","updated_at":"2014-06-27T00:15:43Z","pushed_at":"2014-10-01T19:42:59Z","git_url":"git://github.com/IreneKnapp/direct-sqlite.git","ssh_url":"git@github.com:IreneKnapp/direct-sqlite.git","clone_url":"https://github.com/IreneKnapp/direct-sqlite.git","svn_url":"https://github.com/IreneKnapp/direct-sqlite","homepage":null,"size":3991,"stargazers_count":6,"watchers_count":6,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":5,"forks":7,"open_issues":5,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/IreneKnapp/direct-sqlite/pulls/49"},"html":{"href":"https://github.com/IreneKnapp/direct-sqlite/pull/49"},"issue":{"href":"https://api.github.com/repos/IreneKnapp/direct-sqlite/issues/49"},"comments":{"href":"https://api.github.com/repos/IreneKnapp/direct-sqlite/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/IreneKnapp/direct-sqlite/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/IreneKnapp/direct-sqlite/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/IreneKnapp/direct-sqlite/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/IreneKnapp/direct-sqlite/statuses/8c7c2762775f20afaac833557cd35ba3fbf2cfb8"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"nurpax","id":297823,"avatar_url":"https://avatars.githubusercontent.com/u/297823?v=2","gravatar_id":"","url":"https://api.github.com/users/nurpax","html_url":"https://github.com/nurpax","followers_url":"https://api.github.com/users/nurpax/followers","following_url":"https://api.github.com/users/nurpax/following{/other_user}","gists_url":"https://api.github.com/users/nurpax/gists{/gist_id}","starred_url":"https://api.github.com/users/nurpax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nurpax/subscriptions","organizations_url":"https://api.github.com/users/nurpax/orgs","repos_url":"https://api.github.com/users/nurpax/repos","events_url":"https://api.github.com/users/nurpax/events{/privacy}","received_events_url":"https://api.github.com/users/nurpax/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":2,"deletions":2,"changed_files":1}}