GitHub PullRequestEvent at 2014-03-14 12:55:47
Repository: phobos
Actor: MartinNowak
Payload: {"action":"closed","number":1961,"pull_request":{"url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/1961","id":12834058,"html_url":"https://github.com/D-Programming-Language/phobos/pull/1961","diff_url":"https://github.com/D-Programming-Language/phobos/pull/1961.diff","patch_url":"https://github.com/D-Programming-Language/phobos/pull/1961.patch","issue_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/1961","number":1961,"state":"closed","title":"[ARM] Some FPUs do not support exception trapping, disable test","user":{"login":"jpf91","id":583238,"avatar_url":"https://gravatar.com/avatar/1d9daffde7b2994f627c20f799ce324f?d=https%3A%2F%2Fidenticons.github.com%2F49fc0521bd9bea3e4e45164ea6df663b.png&r=x","gravatar_id":"1d9daffde7b2994f627c20f799ce324f","url":"https://api.github.com/users/jpf91","html_url":"https://github.com/jpf91","followers_url":"https://api.github.com/users/jpf91/followers","following_url":"https://api.github.com/users/jpf91/following{/other_user}","gists_url":"https://api.github.com/users/jpf91/gists{/gist_id}","starred_url":"https://api.github.com/users/jpf91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpf91/subscriptions","organizations_url":"https://api.github.com/users/jpf91/orgs","repos_url":"https://api.github.com/users/jpf91/repos","events_url":"https://api.github.com/users/jpf91/events{/privacy}","received_events_url":"https://api.github.com/users/jpf91/received_events","type":"User","site_admin":false},"body":"Some ARM FPUs do not support exception trapping ('signaling exceptions', exceptions which you don't have to poll for, but get a signal if they occur).\r\n\r\nThis pull adds:\r\n* A ```hasExceptionTraps``` function which returns true if the current FPU supports exception trapping\r\n* ```assert(hasExceptionTraps)``` checks for ```enabledExceptions```, ```enableExceptions```, ```disableExceptions```\r\n* A check for ```hasExceptionTraps``` to disable the unit test  if exception trapping isn't available\r\n\r\nI'm not sure if it's always possible to get the ```hasExceptionTraps``` information for all architectures. Should we use an enum with ```true/false/unknown``` as a return value?","created_at":"2014-02-23T18:21:41Z","updated_at":"2014-03-14T12:55:47Z","closed_at":"2014-03-14T12:55:46Z","merged_at":"2014-03-14T12:55:46Z","merge_commit_sha":"60d1e67ddb0947488a74d58966805c008a159f7f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/1961/commits","review_comments_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/1961/comments","review_comment_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/comments/{number}","comments_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/1961/comments","statuses_url":"https://api.github.com/repos/D-Programming-Language/phobos/statuses/63a98882c64ea73ab278c63edc768fcf57430f48","head":{"label":"jpf91:armFPU","ref":"armFPU","sha":"63a98882c64ea73ab278c63edc768fcf57430f48","user":{"login":"jpf91","id":583238,"avatar_url":"https://gravatar.com/avatar/1d9daffde7b2994f627c20f799ce324f?d=https%3A%2F%2Fidenticons.github.com%2F49fc0521bd9bea3e4e45164ea6df663b.png&r=x","gravatar_id":"1d9daffde7b2994f627c20f799ce324f","url":"https://api.github.com/users/jpf91","html_url":"https://github.com/jpf91","followers_url":"https://api.github.com/users/jpf91/followers","following_url":"https://api.github.com/users/jpf91/following{/other_user}","gists_url":"https://api.github.com/users/jpf91/gists{/gist_id}","starred_url":"https://api.github.com/users/jpf91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpf91/subscriptions","organizations_url":"https://api.github.com/users/jpf91/orgs","repos_url":"https://api.github.com/users/jpf91/repos","events_url":"https://api.github.com/users/jpf91/events{/privacy}","received_events_url":"https://api.github.com/users/jpf91/received_events","type":"User","site_admin":false},"repo":{"id":2092636,"name":"phobos","full_name":"jpf91/phobos","owner":{"login":"jpf91","id":583238,"avatar_url":"https://gravatar.com/avatar/1d9daffde7b2994f627c20f799ce324f?d=https%3A%2F%2Fidenticons.github.com%2F49fc0521bd9bea3e4e45164ea6df663b.png&r=x","gravatar_id":"1d9daffde7b2994f627c20f799ce324f","url":"https://api.github.com/users/jpf91","html_url":"https://github.com/jpf91","followers_url":"https://api.github.com/users/jpf91/followers","following_url":"https://api.github.com/users/jpf91/following{/other_user}","gists_url":"https://api.github.com/users/jpf91/gists{/gist_id}","starred_url":"https://api.github.com/users/jpf91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpf91/subscriptions","organizations_url":"https://api.github.com/users/jpf91/orgs","repos_url":"https://api.github.com/users/jpf91/repos","events_url":"https://api.github.com/users/jpf91/events{/privacy}","received_events_url":"https://api.github.com/users/jpf91/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jpf91/phobos","description":"Runtime library for the D programming language","fork":true,"url":"https://api.github.com/repos/jpf91/phobos","forks_url":"https://api.github.com/repos/jpf91/phobos/forks","keys_url":"https://api.github.com/repos/jpf91/phobos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jpf91/phobos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jpf91/phobos/teams","hooks_url":"https://api.github.com/repos/jpf91/phobos/hooks","issue_events_url":"https://api.github.com/repos/jpf91/phobos/issues/events{/number}","events_url":"https://api.github.com/repos/jpf91/phobos/events","assignees_url":"https://api.github.com/repos/jpf91/phobos/assignees{/user}","branches_url":"https://api.github.com/repos/jpf91/phobos/branches{/branch}","tags_url":"https://api.github.com/repos/jpf91/phobos/tags","blobs_url":"https://api.github.com/repos/jpf91/phobos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jpf91/phobos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jpf91/phobos/git/refs{/sha}","trees_url":"https://api.github.com/repos/jpf91/phobos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jpf91/phobos/statuses/{sha}","languages_url":"https://api.github.com/repos/jpf91/phobos/languages","stargazers_url":"https://api.github.com/repos/jpf91/phobos/stargazers","contributors_url":"https://api.github.com/repos/jpf91/phobos/contributors","subscribers_url":"https://api.github.com/repos/jpf91/phobos/subscribers","subscription_url":"https://api.github.com/repos/jpf91/phobos/subscription","commits_url":"https://api.github.com/repos/jpf91/phobos/commits{/sha}","git_commits_url":"https://api.github.com/repos/jpf91/phobos/git/commits{/sha}","comments_url":"https://api.github.com/repos/jpf91/phobos/comments{/number}","issue_comment_url":"https://api.github.com/repos/jpf91/phobos/issues/comments/{number}","contents_url":"https://api.github.com/repos/jpf91/phobos/contents/{+path}","compare_url":"https://api.github.com/repos/jpf91/phobos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jpf91/phobos/merges","archive_url":"https://api.github.com/repos/jpf91/phobos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jpf91/phobos/downloads","issues_url":"https://api.github.com/repos/jpf91/phobos/issues{/number}","pulls_url":"https://api.github.com/repos/jpf91/phobos/pulls{/number}","milestones_url":"https://api.github.com/repos/jpf91/phobos/milestones{/number}","notifications_url":"https://api.github.com/repos/jpf91/phobos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jpf91/phobos/labels{/name}","releases_url":"https://api.github.com/repos/jpf91/phobos/releases{/id}","created_at":"2011-07-23T10:15:44Z","updated_at":"2014-03-14T12:55:47Z","pushed_at":"2014-03-10T14:23:26Z","git_url":"git://github.com/jpf91/phobos.git","ssh_url":"git@github.com:jpf91/phobos.git","clone_url":"https://github.com/jpf91/phobos.git","svn_url":"https://github.com/jpf91/phobos","homepage":"d-programming-language.org","size":20582,"stargazers_count":3,"watchers_count":3,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":3,"default_branch":"master","master_branch":"master"}},"base":{"label":"D-Programming-Language:master","ref":"master","sha":"b0aabc6c9328ee2a83a0cdb3863d55ba7ee71342","user":{"login":"D-Programming-Language","id":565913,"avatar_url":"https://gravatar.com/avatar/1fe90c0586802aee103ff9ac0b8f3fbe?d=https%3A%2F%2Fidenticons.github.com%2Fe648986736986fcf5bbab3fa635cfb66.png&r=x","gravatar_id":"1fe90c0586802aee103ff9ac0b8f3fbe","url":"https://api.github.com/users/D-Programming-Language","html_url":"https://github.com/D-Programming-Language","followers_url":"https://api.github.com/users/D-Programming-Language/followers","following_url":"https://api.github.com/users/D-Programming-Language/following{/other_user}","gists_url":"https://api.github.com/users/D-Programming-Language/gists{/gist_id}","starred_url":"https://api.github.com/users/D-Programming-Language/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D-Programming-Language/subscriptions","organizations_url":"https://api.github.com/users/D-Programming-Language/orgs","repos_url":"https://api.github.com/users/D-Programming-Language/repos","events_url":"https://api.github.com/users/D-Programming-Language/events{/privacy}","received_events_url":"https://api.github.com/users/D-Programming-Language/received_events","type":"Organization","site_admin":false},"repo":{"id":1257084,"name":"phobos","full_name":"D-Programming-Language/phobos","owner":{"login":"D-Programming-Language","id":565913,"avatar_url":"https://gravatar.com/avatar/1fe90c0586802aee103ff9ac0b8f3fbe?d=https%3A%2F%2Fidenticons.github.com%2Fe648986736986fcf5bbab3fa635cfb66.png&r=x","gravatar_id":"1fe90c0586802aee103ff9ac0b8f3fbe","url":"https://api.github.com/users/D-Programming-Language","html_url":"https://github.com/D-Programming-Language","followers_url":"https://api.github.com/users/D-Programming-Language/followers","following_url":"https://api.github.com/users/D-Programming-Language/following{/other_user}","gists_url":"https://api.github.com/users/D-Programming-Language/gists{/gist_id}","starred_url":"https://api.github.com/users/D-Programming-Language/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D-Programming-Language/subscriptions","organizations_url":"https://api.github.com/users/D-Programming-Language/orgs","repos_url":"https://api.github.com/users/D-Programming-Language/repos","events_url":"https://api.github.com/users/D-Programming-Language/events{/privacy}","received_events_url":"https://api.github.com/users/D-Programming-Language/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/D-Programming-Language/phobos","description":"The standard library of the D programming language","fork":false,"url":"https://api.github.com/repos/D-Programming-Language/phobos","forks_url":"https://api.github.com/repos/D-Programming-Language/phobos/forks","keys_url":"https://api.github.com/repos/D-Programming-Language/phobos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/D-Programming-Language/phobos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/D-Programming-Language/phobos/teams","hooks_url":"https://api.github.com/repos/D-Programming-Language/phobos/hooks","issue_events_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/events{/number}","events_url":"https://api.github.com/repos/D-Programming-Language/phobos/events","assignees_url":"https://api.github.com/repos/D-Programming-Language/phobos/assignees{/user}","branches_url":"https://api.github.com/repos/D-Programming-Language/phobos/branches{/branch}","tags_url":"https://api.github.com/repos/D-Programming-Language/phobos/tags","blobs_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/refs{/sha}","trees_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/D-Programming-Language/phobos/statuses/{sha}","languages_url":"https://api.github.com/repos/D-Programming-Language/phobos/languages","stargazers_url":"https://api.github.com/repos/D-Programming-Language/phobos/stargazers","contributors_url":"https://api.github.com/repos/D-Programming-Language/phobos/contributors","subscribers_url":"https://api.github.com/repos/D-Programming-Language/phobos/subscribers","subscription_url":"https://api.github.com/repos/D-Programming-Language/phobos/subscription","commits_url":"https://api.github.com/repos/D-Programming-Language/phobos/commits{/sha}","git_commits_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/commits{/sha}","comments_url":"https://api.github.com/repos/D-Programming-Language/phobos/comments{/number}","issue_comment_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/comments/{number}","contents_url":"https://api.github.com/repos/D-Programming-Language/phobos/contents/{+path}","compare_url":"https://api.github.com/repos/D-Programming-Language/phobos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/D-Programming-Language/phobos/merges","archive_url":"https://api.github.com/repos/D-Programming-Language/phobos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/D-Programming-Language/phobos/downloads","issues_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues{/number}","pulls_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls{/number}","milestones_url":"https://api.github.com/repos/D-Programming-Language/phobos/milestones{/number}","notifications_url":"https://api.github.com/repos/D-Programming-Language/phobos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/D-Programming-Language/phobos/labels{/name}","releases_url":"https://api.github.com/repos/D-Programming-Language/phobos/releases{/id}","created_at":"2011-01-15T07:00:06Z","updated_at":"2014-03-14T12:55:46Z","pushed_at":"2014-03-14T12:55:46Z","git_url":"git://github.com/D-Programming-Language/phobos.git","ssh_url":"git@github.com:D-Programming-Language/phobos.git","clone_url":"https://github.com/D-Programming-Language/phobos.git","svn_url":"https://github.com/D-Programming-Language/phobos","homepage":"dlang.org/phobos","size":40917,"stargazers_count":450,"watchers_count":450,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":273,"mirror_url":null,"open_issues_count":50,"forks":273,"open_issues":50,"watchers":450,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/1961"},"html":{"href":"https://github.com/D-Programming-Language/phobos/pull/1961"},"issue":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/issues/1961"},"comments":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/issues/1961/comments"},"review_comments":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/1961/comments"},"review_comment":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/1961/commits"},"statuses":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/statuses/63a98882c64ea73ab278c63edc768fcf57430f48"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"MartinNowak","id":288976,"avatar_url":"https://gravatar.com/avatar/d919a6f84bb1b92ff78e2da0810a844d?d=https%3A%2F%2Fidenticons.github.com%2F70af8121c515935ba0c2cde9ede20fa9.png&r=x","gravatar_id":"d919a6f84bb1b92ff78e2da0810a844d","url":"https://api.github.com/users/MartinNowak","html_url":"https://github.com/MartinNowak","followers_url":"https://api.github.com/users/MartinNowak/followers","following_url":"https://api.github.com/users/MartinNowak/following{/other_user}","gists_url":"https://api.github.com/users/MartinNowak/gists{/gist_id}","starred_url":"https://api.github.com/users/MartinNowak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartinNowak/subscriptions","organizations_url":"https://api.github.com/users/MartinNowak/orgs","repos_url":"https://api.github.com/users/MartinNowak/repos","events_url":"https://api.github.com/users/MartinNowak/events{/privacy}","received_events_url":"https://api.github.com/users/MartinNowak/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"commits":1,"additions":25,"deletions":0,"changed_files":1}}