GitHub PullRequestEvent at 2014-09-18 03:04:48
Repository: express
Actor: dougwilson
Payload: {"action":"closed","number":2361,"pull_request":{"url":"https://api.github.com/repos/strongloop/express/pulls/2361","id":21383740,"html_url":"https://github.com/strongloop/express/pull/2361","diff_url":"https://github.com/strongloop/express/pull/2361.diff","patch_url":"https://github.com/strongloop/express/pull/2361.patch","issue_url":"https://api.github.com/repos/strongloop/express/issues/2361","number":2361,"state":"closed","locked":false,"title":"Fix .use with empty string as path","user":{"login":"dmoscrop","id":586516,"avatar_url":"https://avatars.githubusercontent.com/u/586516?v=2","gravatar_id":"1df8b40671b0a97e427c586568635b0f","url":"https://api.github.com/users/dmoscrop","html_url":"https://github.com/dmoscrop","followers_url":"https://api.github.com/users/dmoscrop/followers","following_url":"https://api.github.com/users/dmoscrop/following{/other_user}","gists_url":"https://api.github.com/users/dmoscrop/gists{/gist_id}","starred_url":"https://api.github.com/users/dmoscrop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmoscrop/subscriptions","organizations_url":"https://api.github.com/users/dmoscrop/orgs","repos_url":"https://api.github.com/users/dmoscrop/repos","events_url":"https://api.github.com/users/dmoscrop/events{/privacy}","received_events_url":"https://api.github.com/users/dmoscrop/received_events","type":"User","site_admin":false},"body":"I don't know if this was ever intended, but prior to 4.9.1 (specifically, https://github.com/strongloop/express/commit/cf41a8f25434bde16ee8606ce12bb699ef9de39e#diff-5372f626ee15242f1e2c6eb31655b4faR168) an empty path \"worked\". I'm not saying it was a good practice, but the ensuing error message after upgrading to 4.9.1 is a bit unhelpful (\"expected function but got Object\").\r\n\r\nSo this 'restores' the tolerance for `app.use` with an empty string as the path. Alternatively, maybe checking if `fn` is an empty string and throwing a more specific error message would be better if the intention was to actually disallow it.","created_at":"2014-09-17T17:53:59Z","updated_at":"2014-09-18T03:04:47Z","closed_at":"2014-09-18T03:04:47Z","merged_at":null,"merge_commit_sha":"088ff7331d773023f07c7e26dcc4ded2587b4103","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/strongloop/express/pulls/2361/commits","review_comments_url":"https://api.github.com/repos/strongloop/express/pulls/2361/comments","review_comment_url":"https://api.github.com/repos/strongloop/express/pulls/comments/{number}","comments_url":"https://api.github.com/repos/strongloop/express/issues/2361/comments","statuses_url":"https://api.github.com/repos/strongloop/express/statuses/af42b7825112e3d7500d654e745500842f8459a1","head":{"label":"dmoscrop:master","ref":"master","sha":"af42b7825112e3d7500d654e745500842f8459a1","user":{"login":"dmoscrop","id":586516,"avatar_url":"https://avatars.githubusercontent.com/u/586516?v=2","gravatar_id":"1df8b40671b0a97e427c586568635b0f","url":"https://api.github.com/users/dmoscrop","html_url":"https://github.com/dmoscrop","followers_url":"https://api.github.com/users/dmoscrop/followers","following_url":"https://api.github.com/users/dmoscrop/following{/other_user}","gists_url":"https://api.github.com/users/dmoscrop/gists{/gist_id}","starred_url":"https://api.github.com/users/dmoscrop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmoscrop/subscriptions","organizations_url":"https://api.github.com/users/dmoscrop/orgs","repos_url":"https://api.github.com/users/dmoscrop/repos","events_url":"https://api.github.com/users/dmoscrop/events{/privacy}","received_events_url":"https://api.github.com/users/dmoscrop/received_events","type":"User","site_admin":false},"repo":{"id":24152971,"name":"express","full_name":"dmoscrop/express","owner":{"login":"dmoscrop","id":586516,"avatar_url":"https://avatars.githubusercontent.com/u/586516?v=2","gravatar_id":"1df8b40671b0a97e427c586568635b0f","url":"https://api.github.com/users/dmoscrop","html_url":"https://github.com/dmoscrop","followers_url":"https://api.github.com/users/dmoscrop/followers","following_url":"https://api.github.com/users/dmoscrop/following{/other_user}","gists_url":"https://api.github.com/users/dmoscrop/gists{/gist_id}","starred_url":"https://api.github.com/users/dmoscrop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmoscrop/subscriptions","organizations_url":"https://api.github.com/users/dmoscrop/orgs","repos_url":"https://api.github.com/users/dmoscrop/repos","events_url":"https://api.github.com/users/dmoscrop/events{/privacy}","received_events_url":"https://api.github.com/users/dmoscrop/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dmoscrop/express","description":"Sinatra inspired web development framework for node.js -- insanely fast, flexible, and simple","fork":true,"url":"https://api.github.com/repos/dmoscrop/express","forks_url":"https://api.github.com/repos/dmoscrop/express/forks","keys_url":"https://api.github.com/repos/dmoscrop/express/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmoscrop/express/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmoscrop/express/teams","hooks_url":"https://api.github.com/repos/dmoscrop/express/hooks","issue_events_url":"https://api.github.com/repos/dmoscrop/express/issues/events{/number}","events_url":"https://api.github.com/repos/dmoscrop/express/events","assignees_url":"https://api.github.com/repos/dmoscrop/express/assignees{/user}","branches_url":"https://api.github.com/repos/dmoscrop/express/branches{/branch}","tags_url":"https://api.github.com/repos/dmoscrop/express/tags","blobs_url":"https://api.github.com/repos/dmoscrop/express/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmoscrop/express/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmoscrop/express/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmoscrop/express/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmoscrop/express/statuses/{sha}","languages_url":"https://api.github.com/repos/dmoscrop/express/languages","stargazers_url":"https://api.github.com/repos/dmoscrop/express/stargazers","contributors_url":"https://api.github.com/repos/dmoscrop/express/contributors","subscribers_url":"https://api.github.com/repos/dmoscrop/express/subscribers","subscription_url":"https://api.github.com/repos/dmoscrop/express/subscription","commits_url":"https://api.github.com/repos/dmoscrop/express/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmoscrop/express/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmoscrop/express/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmoscrop/express/issues/comments/{number}","contents_url":"https://api.github.com/repos/dmoscrop/express/contents/{+path}","compare_url":"https://api.github.com/repos/dmoscrop/express/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmoscrop/express/merges","archive_url":"https://api.github.com/repos/dmoscrop/express/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmoscrop/express/downloads","issues_url":"https://api.github.com/repos/dmoscrop/express/issues{/number}","pulls_url":"https://api.github.com/repos/dmoscrop/express/pulls{/number}","milestones_url":"https://api.github.com/repos/dmoscrop/express/milestones{/number}","notifications_url":"https://api.github.com/repos/dmoscrop/express/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmoscrop/express/labels{/name}","releases_url":"https://api.github.com/repos/dmoscrop/express/releases{/id}","created_at":"2014-09-17T16:32:09Z","updated_at":"2014-09-17T17:46:02Z","pushed_at":"2014-09-17T17:46:02Z","git_url":"git://github.com/dmoscrop/express.git","ssh_url":"git@github.com:dmoscrop/express.git","clone_url":"https://github.com/dmoscrop/express.git","svn_url":"https://github.com/dmoscrop/express","homepage":"http://expressjs.com","size":27471,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"strongloop:master","ref":"master","sha":"947fb8b27425851f3316ae9d39df5035085dde4a","user":{"login":"strongloop","id":3020012,"avatar_url":"https://avatars.githubusercontent.com/u/3020012?v=2","gravatar_id":"4c9f25755f54f494818279ebab42a6eb","url":"https://api.github.com/users/strongloop","html_url":"https://github.com/strongloop","followers_url":"https://api.github.com/users/strongloop/followers","following_url":"https://api.github.com/users/strongloop/following{/other_user}","gists_url":"https://api.github.com/users/strongloop/gists{/gist_id}","starred_url":"https://api.github.com/users/strongloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strongloop/subscriptions","organizations_url":"https://api.github.com/users/strongloop/orgs","repos_url":"https://api.github.com/users/strongloop/repos","events_url":"https://api.github.com/users/strongloop/events{/privacy}","received_events_url":"https://api.github.com/users/strongloop/received_events","type":"Organization","site_admin":false},"repo":{"id":237159,"name":"express","full_name":"strongloop/express","owner":{"login":"strongloop","id":3020012,"avatar_url":"https://avatars.githubusercontent.com/u/3020012?v=2","gravatar_id":"4c9f25755f54f494818279ebab42a6eb","url":"https://api.github.com/users/strongloop","html_url":"https://github.com/strongloop","followers_url":"https://api.github.com/users/strongloop/followers","following_url":"https://api.github.com/users/strongloop/following{/other_user}","gists_url":"https://api.github.com/users/strongloop/gists{/gist_id}","starred_url":"https://api.github.com/users/strongloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strongloop/subscriptions","organizations_url":"https://api.github.com/users/strongloop/orgs","repos_url":"https://api.github.com/users/strongloop/repos","events_url":"https://api.github.com/users/strongloop/events{/privacy}","received_events_url":"https://api.github.com/users/strongloop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/strongloop/express","description":"Sinatra inspired web development framework for node.js -- insanely fast, flexible, and simple","fork":false,"url":"https://api.github.com/repos/strongloop/express","forks_url":"https://api.github.com/repos/strongloop/express/forks","keys_url":"https://api.github.com/repos/strongloop/express/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strongloop/express/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strongloop/express/teams","hooks_url":"https://api.github.com/repos/strongloop/express/hooks","issue_events_url":"https://api.github.com/repos/strongloop/express/issues/events{/number}","events_url":"https://api.github.com/repos/strongloop/express/events","assignees_url":"https://api.github.com/repos/strongloop/express/assignees{/user}","branches_url":"https://api.github.com/repos/strongloop/express/branches{/branch}","tags_url":"https://api.github.com/repos/strongloop/express/tags","blobs_url":"https://api.github.com/repos/strongloop/express/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strongloop/express/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strongloop/express/git/refs{/sha}","trees_url":"https://api.github.com/repos/strongloop/express/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strongloop/express/statuses/{sha}","languages_url":"https://api.github.com/repos/strongloop/express/languages","stargazers_url":"https://api.github.com/repos/strongloop/express/stargazers","contributors_url":"https://api.github.com/repos/strongloop/express/contributors","subscribers_url":"https://api.github.com/repos/strongloop/express/subscribers","subscription_url":"https://api.github.com/repos/strongloop/express/subscription","commits_url":"https://api.github.com/repos/strongloop/express/commits{/sha}","git_commits_url":"https://api.github.com/repos/strongloop/express/git/commits{/sha}","comments_url":"https://api.github.com/repos/strongloop/express/comments{/number}","issue_comment_url":"https://api.github.com/repos/strongloop/express/issues/comments/{number}","contents_url":"https://api.github.com/repos/strongloop/express/contents/{+path}","compare_url":"https://api.github.com/repos/strongloop/express/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strongloop/express/merges","archive_url":"https://api.github.com/repos/strongloop/express/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strongloop/express/downloads","issues_url":"https://api.github.com/repos/strongloop/express/issues{/number}","pulls_url":"https://api.github.com/repos/strongloop/express/pulls{/number}","milestones_url":"https://api.github.com/repos/strongloop/express/milestones{/number}","notifications_url":"https://api.github.com/repos/strongloop/express/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strongloop/express/labels{/name}","releases_url":"https://api.github.com/repos/strongloop/express/releases{/id}","created_at":"2009-06-26T18:56:01Z","updated_at":"2014-09-18T01:57:31Z","pushed_at":"2014-09-18T03:04:44Z","git_url":"git://github.com/strongloop/express.git","ssh_url":"git@github.com:strongloop/express.git","clone_url":"https://github.com/strongloop/express.git","svn_url":"https://github.com/strongloop/express","homepage":"http://expressjs.com","size":27471,"stargazers_count":15619,"watchers_count":15619,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3210,"mirror_url":null,"open_issues_count":27,"forks":3210,"open_issues":27,"watchers":15619,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/strongloop/express/pulls/2361"},"html":{"href":"https://github.com/strongloop/express/pull/2361"},"issue":{"href":"https://api.github.com/repos/strongloop/express/issues/2361"},"comments":{"href":"https://api.github.com/repos/strongloop/express/issues/2361/comments"},"review_comments":{"href":"https://api.github.com/repos/strongloop/express/pulls/2361/comments"},"review_comment":{"href":"https://api.github.com/repos/strongloop/express/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/strongloop/express/pulls/2361/commits"},"statuses":{"href":"https://api.github.com/repos/strongloop/express/statuses/af42b7825112e3d7500d654e745500842f8459a1"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":2,"review_comments":0,"commits":1,"additions":13,"deletions":1,"changed_files":2}}