GitHub PullRequestReviewCommentEvent at 2014-11-12 19:00:06
Repository: acceptance-test-harness
Actor: olivergondza
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/pulls/comments/20241275","id":20241275,"diff_hunk":"@@ -0,0 +1,48 @@\n+/*\n+ * The MIT License\n+ *\n+ * Copyright (c) 2014 Ericsson\n+ *\n+ * Permission is hereby granted, free of charge, to any person obtaining a copy\n+ * of this software and associated documentation files (the \"Software\"), to deal\n+ * in the Software without restriction, including without limitation the rights\n+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell\n+ * copies of the Software, and to permit persons to whom the Software is\n+ * furnished to do so, subject to the following conditions:\n+ *\n+ * The above copyright notice and this permission notice shall be included in\n+ * all copies or substantial portions of the Software.\n+ *\n+ * THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR\n+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,\n+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE\n+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER\n+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,\n+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN\n+ * THE SOFTWARE.\n+ */\n+package org.jenkinsci.test.acceptance.utils.pluginTests;\n+\n+import org.jenkinsci.test.acceptance.plugins.matrix_auth.MatrixRow;\n+import org.jenkinsci.test.acceptance.plugins.matrix_auth.ProjectBasedMatrixAuthorizationStrategy;\n+import org.jenkinsci.test.acceptance.po.GlobalSecurityConfig;\n+\n+public class SecurityConfigUtils {\n+\n+    private SecurityConfigUtils() {\n+    }\n+\n+    /**\n+     * Add and authorize given user admin role under \"Project-based Matrix Authorization Strategy\"\n+     *\n+     * @param user user to be added and authorized as admin\n+     * @param security page object\n+     * @return security page object\n+     */\n+    public static GlobalSecurityConfig authorizeUserAsAdmin(String user, GlobalSecurityConfig security) {","path":"src/main/java/org/jenkinsci/test/acceptance/utils/pluginTests/SecurityConfigUtils.java","position":42,"original_position":42,"commit_id":"2c87fd8530c83bee5dc61caab1b8051d76ec9c6a","original_commit_id":"2c87fd8530c83bee5dc61caab1b8051d76ec9c6a","user":{"login":"olivergondza","id":206841,"avatar_url":"https://avatars.githubusercontent.com/u/206841?v=3","gravatar_id":"","url":"https://api.github.com/users/olivergondza","html_url":"https://github.com/olivergondza","followers_url":"https://api.github.com/users/olivergondza/followers","following_url":"https://api.github.com/users/olivergondza/following{/other_user}","gists_url":"https://api.github.com/users/olivergondza/gists{/gist_id}","starred_url":"https://api.github.com/users/olivergondza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olivergondza/subscriptions","organizations_url":"https://api.github.com/users/olivergondza/orgs","repos_url":"https://api.github.com/users/olivergondza/repos","events_url":"https://api.github.com/users/olivergondza/events{/privacy}","received_events_url":"https://api.github.com/users/olivergondza/received_events","type":"User","site_admin":false},"body":"This probably belongs to `ProjectBasedMatrixAuthorizationStrategy`.","created_at":"2014-11-12T19:00:06Z","updated_at":"2014-11-12T19:00:06Z","html_url":"https://github.com/jenkinsci/acceptance-test-harness/pull/18#discussion_r20241275","pull_request_url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/pulls/18","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/pulls/comments/20241275"},"html":{"href":"https://github.com/jenkinsci/acceptance-test-harness/pull/18#discussion_r20241275"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/pulls/18","id":24315331,"html_url":"https://github.com/jenkinsci/acceptance-test-harness/pull/18","diff_url":"https://github.com/jenkinsci/acceptance-test-harness/pull/18.diff","patch_url":"https://github.com/jenkinsci/acceptance-test-harness/pull/18.patch","issue_url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/issues/18","number":18,"state":"open","locked":false,"title":"[JENKINS-25576] A Ldap plugin test that runs with LDAP server is added.","user":{"login":"conan-z","id":6955801,"avatar_url":"https://avatars.githubusercontent.com/u/6955801?v=3","gravatar_id":"","url":"https://api.github.com/users/conan-z","html_url":"https://github.com/conan-z","followers_url":"https://api.github.com/users/conan-z/followers","following_url":"https://api.github.com/users/conan-z/following{/other_user}","gists_url":"https://api.github.com/users/conan-z/gists{/gist_id}","starred_url":"https://api.github.com/users/conan-z/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conan-z/subscriptions","organizations_url":"https://api.github.com/users/conan-z/orgs","repos_url":"https://api.github.com/users/conan-z/repos","events_url":"https://api.github.com/users/conan-z/events{/privacy}","received_events_url":"https://api.github.com/users/conan-z/received_events","type":"User","site_admin":false},"body":"There was only one Ldap plugin test which requires Docker to run. The\r\nnewly created LdapPluginNoDockerTest runs without Docker but with a\r\nreal LDAP server. Detailed configuration information can be set through\r\nenvironment variables.\r\n\r\nBecause LdapPluginNoDockerTest has similar test stories with\r\nActiveDirectoryTest, ActiveDirectoryTest is refactored to reduce\r\nduplicate code.","created_at":"2014-11-12T18:52:57Z","updated_at":"2014-11-12T19:00:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d61edbf375bb1d672d5664de77a986e4f585b8a2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/pulls/18/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/pulls/18/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/issues/18/comments","statuses_url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/statuses/2c87fd8530c83bee5dc61caab1b8051d76ec9c6a","head":{"label":"conan-z:ldapNoDockerTest","ref":"ldapNoDockerTest","sha":"2c87fd8530c83bee5dc61caab1b8051d76ec9c6a","user":{"login":"conan-z","id":6955801,"avatar_url":"https://avatars.githubusercontent.com/u/6955801?v=3","gravatar_id":"","url":"https://api.github.com/users/conan-z","html_url":"https://github.com/conan-z","followers_url":"https://api.github.com/users/conan-z/followers","following_url":"https://api.github.com/users/conan-z/following{/other_user}","gists_url":"https://api.github.com/users/conan-z/gists{/gist_id}","starred_url":"https://api.github.com/users/conan-z/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conan-z/subscriptions","organizations_url":"https://api.github.com/users/conan-z/orgs","repos_url":"https://api.github.com/users/conan-z/repos","events_url":"https://api.github.com/users/conan-z/events{/privacy}","received_events_url":"https://api.github.com/users/conan-z/received_events","type":"User","site_admin":false},"repo":{"id":25822567,"name":"acceptance-test-harness","full_name":"conan-z/acceptance-test-harness","owner":{"login":"conan-z","id":6955801,"avatar_url":"https://avatars.githubusercontent.com/u/6955801?v=3","gravatar_id":"","url":"https://api.github.com/users/conan-z","html_url":"https://github.com/conan-z","followers_url":"https://api.github.com/users/conan-z/followers","following_url":"https://api.github.com/users/conan-z/following{/other_user}","gists_url":"https://api.github.com/users/conan-z/gists{/gist_id}","starred_url":"https://api.github.com/users/conan-z/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conan-z/subscriptions","organizations_url":"https://api.github.com/users/conan-z/orgs","repos_url":"https://api.github.com/users/conan-z/repos","events_url":"https://api.github.com/users/conan-z/events{/privacy}","received_events_url":"https://api.github.com/users/conan-z/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/conan-z/acceptance-test-harness","description":"Attempted port from selenium-tests to Java","fork":true,"url":"https://api.github.com/repos/conan-z/acceptance-test-harness","forks_url":"https://api.github.com/repos/conan-z/acceptance-test-harness/forks","keys_url":"https://api.github.com/repos/conan-z/acceptance-test-harness/keys{/key_id}","collaborators_url":"https://api.github.com/repos/conan-z/acceptance-test-harness/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/conan-z/acceptance-test-harness/teams","hooks_url":"https://api.github.com/repos/conan-z/acceptance-test-harness/hooks","issue_events_url":"https://api.github.com/repos/conan-z/acceptance-test-harness/issues/events{/number}","events_url":"https://api.github.com/repos/conan-z/acceptance-test-harness/events","assignees_url":"https://api.github.com/repos/conan-z/acceptance-test-harness/assignees{/user}","branches_url":"https://api.github.com/repos/conan-z/acceptance-test-harness/branches{/branch}","tags_url":"https://api.github.com/repos/conan-z/acceptance-test-harness/tags","blobs_url":"https://api.github.com/repos/conan-z/acceptance-test-harness/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/conan-z/acceptance-test-harness/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/conan-z/acceptance-test-harness/git/refs{/sha}","trees_url":"https://api.github.com/repos/conan-z/acceptance-test-harness/git/trees{/sha}","statuses_url":"https://api.github.com/repos/conan-z/acceptance-test-harness/statuses/{sha}","languages_url":"https://api.github.com/repos/conan-z/acceptance-test-harness/languages","stargazers_url":"https://api.github.com/repos/conan-z/acceptance-test-harness/stargazers","contributors_url":"https://api.github.com/repos/conan-z/acceptance-test-harness/contributors","subscribers_url":"https://api.github.com/repos/conan-z/acceptance-test-harness/subscribers","subscription_url":"https://api.github.com/repos/conan-z/acceptance-test-harness/subscription","commits_url":"https://api.github.com/repos/conan-z/acceptance-test-harness/commits{/sha}","git_commits_url":"https://api.github.com/repos/conan-z/acceptance-test-harness/git/commits{/sha}","comments_url":"https://api.github.com/repos/conan-z/acceptance-test-harness/comments{/number}","issue_comment_url":"https://api.github.com/repos/conan-z/acceptance-test-harness/issues/comments/{number}","contents_url":"https://api.github.com/repos/conan-z/acceptance-test-harness/contents/{+path}","compare_url":"https://api.github.com/repos/conan-z/acceptance-test-harness/compare/{base}...{head}","merges_url":"https://api.github.com/repos/conan-z/acceptance-test-harness/merges","archive_url":"https://api.github.com/repos/conan-z/acceptance-test-harness/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/conan-z/acceptance-test-harness/downloads","issues_url":"https://api.github.com/repos/conan-z/acceptance-test-harness/issues{/number}","pulls_url":"https://api.github.com/repos/conan-z/acceptance-test-harness/pulls{/number}","milestones_url":"https://api.github.com/repos/conan-z/acceptance-test-harness/milestones{/number}","notifications_url":"https://api.github.com/repos/conan-z/acceptance-test-harness/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/conan-z/acceptance-test-harness/labels{/name}","releases_url":"https://api.github.com/repos/conan-z/acceptance-test-harness/releases{/id}","created_at":"2014-10-27T14:19:44Z","updated_at":"2014-11-10T21:15:14Z","pushed_at":"2014-11-12T17:47:51Z","git_url":"git://github.com/conan-z/acceptance-test-harness.git","ssh_url":"git@github.com:conan-z/acceptance-test-harness.git","clone_url":"https://github.com/conan-z/acceptance-test-harness.git","svn_url":"https://github.com/conan-z/acceptance-test-harness","homepage":null,"size":7012,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"076fb39b10456a984f5c2c8e789adef66ce1ec7e","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":17294237,"name":"acceptance-test-harness","full_name":"jenkinsci/acceptance-test-harness","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/acceptance-test-harness","description":"Attempted port from selenium-tests to Java","fork":false,"url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness","forks_url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/forks","keys_url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/teams","hooks_url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/events","assignees_url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/tags","blobs_url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/subscription","commits_url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/issues/comments/{number}","contents_url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/merges","archive_url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/downloads","issues_url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/releases{/id}","created_at":"2014-02-28T17:39:55Z","updated_at":"2014-10-29T01:46:49Z","pushed_at":"2014-11-10T22:37:01Z","git_url":"git://github.com/jenkinsci/acceptance-test-harness.git","ssh_url":"git@github.com:jenkinsci/acceptance-test-harness.git","clone_url":"https://github.com/jenkinsci/acceptance-test-harness.git","svn_url":"https://github.com/jenkinsci/acceptance-test-harness","homepage":null,"size":11718,"stargazers_count":25,"watchers_count":25,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":2,"forks":29,"open_issues":2,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/pulls/18"},"html":{"href":"https://github.com/jenkinsci/acceptance-test-harness/pull/18"},"issue":{"href":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/issues/18"},"comments":{"href":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/statuses/2c87fd8530c83bee5dc61caab1b8051d76ec9c6a"}}}}