GitHub PullRequestReviewCommentEvent at 2014-05-10 19:51:43
Repository: shogun
Actor: vigsterkr
Payload: {"comment":{"url":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/comments/12505846","id":12505846,"diff_hunk":"@@ -0,0 +1,189 @@\n+/*\n+ * Copyright (c) The Shogun Machine Learning Toolbox\n+ * Written (w) 2014 Soumyajit De\n+ * All rights reserved.\n+ *\n+ * Redistribution and use in source and binary forms, with or without\n+ * modification, are permitted provided that the following conditions are met:\n+ *\n+ * 1. Redistributions of source code must retain the above copyright notice, this\n+ *    list of conditions and the following disclaimer.\n+ * 2. Redistributions in binary form must reproduce the above copyright notice,\n+ *    this list of conditions and the following disclaimer in the documentation\n+ *    and/or other materials provided with the distribution.\n+ *\n+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS \"AS IS\" AND\n+ * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED\n+ * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE\n+ * DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR\n+ * ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES\n+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;\n+ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND\n+ * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT\n+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS\n+ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n+ *\n+ * The views and conclusions contained in the software and documentation are those\n+ * of the authors and should not be interpreted as representing official policies,\n+ * either expressed or implied, of the Shogun Development Team.\n+ */\n+\n+#ifndef LINALG_H_\n+#define LINALG_H_\n+\n+#include <shogun/lib/config.h>\n+\n+/**\n+ * Just include this file to use in your applications.\n+ */\n+\n+/**\n+ * This namespace contains all linear algebra specific modules and operations.\n+ */\n+namespace linalg\n+{\n+\n+/**\n+ * Developer's Note :\n+ * - Changing the default backend would just require to change it in the following\n+ *   enum and in the following ifdef\n+ * - Please use the same names as HAVE_<BACKEND> macros (e.g. HAVE_EIGEN3)\n+ */\n+\n+/**\n+ * @brief\n+ * All currently supported linear algebra backend libraries, with a default\n+ * backend, which will be used for all the tasks if any particular backend is\n+ * not set explicitly via cmake options.\n+ *\n+ * Note - Currently EIGEN3 is the default.\n+ *\n+ */\n+enum class Backend\n+{\n+\tEIGEN3,","path":"src/shogun/mathematics/linalg/linalg.h","position":64,"original_position":64,"commit_id":"379c5f6996e937d6f4c80357777385441b790947","original_commit_id":"379c5f6996e937d6f4c80357777385441b790947","user":{"login":"vigsterkr","id":30353,"avatar_url":"https://avatars.githubusercontent.com/u/30353?","gravatar_id":"af15f285b9b1aeff8f82c4d208bf30d7","url":"https://api.github.com/users/vigsterkr","html_url":"https://github.com/vigsterkr","followers_url":"https://api.github.com/users/vigsterkr/followers","following_url":"https://api.github.com/users/vigsterkr/following{/other_user}","gists_url":"https://api.github.com/users/vigsterkr/gists{/gist_id}","starred_url":"https://api.github.com/users/vigsterkr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vigsterkr/subscriptions","organizations_url":"https://api.github.com/users/vigsterkr/orgs","repos_url":"https://api.github.com/users/vigsterkr/repos","events_url":"https://api.github.com/users/vigsterkr/events{/privacy}","received_events_url":"https://api.github.com/users/vigsterkr/received_events","type":"User","site_admin":false},"body":"you should not even have an enum defined if the supporting backend is not available...","created_at":"2014-05-10T19:51:43Z","updated_at":"2014-05-10T19:51:43Z","html_url":"https://github.com/shogun-toolbox/shogun/pull/2217#discussion_r12505846","pull_request_url":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/2217","_links":{"self":{"href":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/comments/12505846"},"html":{"href":"https://github.com/shogun-toolbox/shogun/pull/2217#discussion_r12505846"},"pull_request":{"href":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/2217"}}}}