GitHub PullRequestReviewCommentEvent at 2014-11-19 12:57:40
Repository: Elgg
Actor: mrclay
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Elgg/Elgg/pulls/comments/20572849","id":20572849,"diff_hunk":"@@ -46,6 +51,24 @@ function elgg_echo($message_key, $args = array(), $language = \"\") {\n \t\t$language = $CURRENT_LANGUAGE;\n \t}\n \n+\tif (is_array($message_key)) {","path":"engine/lib/languages.php","position":29,"original_position":29,"commit_id":"7d593351309cb39847121430eb6ecd7123716e35","original_commit_id":"7d593351309cb39847121430eb6ecd7123716e35","user":{"login":"mrclay","id":170687,"avatar_url":"https://avatars.githubusercontent.com/u/170687?v=3","gravatar_id":"","url":"https://api.github.com/users/mrclay","html_url":"https://github.com/mrclay","followers_url":"https://api.github.com/users/mrclay/followers","following_url":"https://api.github.com/users/mrclay/following{/other_user}","gists_url":"https://api.github.com/users/mrclay/gists{/gist_id}","starred_url":"https://api.github.com/users/mrclay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrclay/subscriptions","organizations_url":"https://api.github.com/users/mrclay/orgs","repos_url":"https://api.github.com/users/mrclay/repos","events_url":"https://api.github.com/users/mrclay/events{/privacy}","received_events_url":"https://api.github.com/users/mrclay/received_events","type":"User","site_admin":false},"body":"How about elgg_echo just accepts an array, and if none are found it returns the last key. So all these Just Work without any special rules:\r\n\r\n```php\r\nelgg_echo('not_a_key'); // \"not_a_key\"\r\nelgg_echo(['not_a_key']); // \"not_a_key\"\r\nelgg_echo(['not_a_key', '']); // \"\"\r\n```","created_at":"2014-11-19T12:57:40Z","updated_at":"2014-11-19T12:57:40Z","html_url":"https://github.com/Elgg/Elgg/pull/7430#discussion_r20572849","pull_request_url":"https://api.github.com/repos/Elgg/Elgg/pulls/7430","_links":{"self":{"href":"https://api.github.com/repos/Elgg/Elgg/pulls/comments/20572849"},"html":{"href":"https://github.com/Elgg/Elgg/pull/7430#discussion_r20572849"},"pull_request":{"href":"https://api.github.com/repos/Elgg/Elgg/pulls/7430"}}},"pull_request":{"url":"https://api.github.com/repos/Elgg/Elgg/pulls/7430","id":23728725,"html_url":"https://github.com/Elgg/Elgg/pull/7430","diff_url":"https://github.com/Elgg/Elgg/pull/7430.diff","patch_url":"https://github.com/Elgg/Elgg/pull/7430.patch","issue_url":"https://api.github.com/repos/Elgg/Elgg/issues/7430","number":7430,"state":"open","locked":false,"title":"feature(i18n): allows passing multiple message keys to elgg_echo()","user":{"login":"mrclay","id":170687,"avatar_url":"https://avatars.githubusercontent.com/u/170687?v=3","gravatar_id":"","url":"https://api.github.com/users/mrclay","html_url":"https://github.com/mrclay","followers_url":"https://api.github.com/users/mrclay/followers","following_url":"https://api.github.com/users/mrclay/following{/other_user}","gists_url":"https://api.github.com/users/mrclay/gists{/gist_id}","starred_url":"https://api.github.com/users/mrclay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrclay/subscriptions","organizations_url":"https://api.github.com/users/mrclay/orgs","repos_url":"https://api.github.com/users/mrclay/repos","events_url":"https://api.github.com/users/mrclay/events{/privacy}","received_events_url":"https://api.github.com/users/mrclay/received_events","type":"User","site_admin":false},"body":"When an array of keys are passed, it looks for each translation (including\r\nEnglish versions) and returns false if none are found. No notices are\r\nemitted.\r\n\r\nFixes #6299\r\n\r\n/cc @ewinslow @juho-jaakkola @jdalsem \r\n\r\nTODO:\r\n - [ ] Rebase and add to new `I18n\\Translator` class\r\n - [ ] Split into a separate function from `elgg_echo`?","created_at":"2014-11-02T06:41:54Z","updated_at":"2014-11-19T12:57:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e33490ddf61c466bd39f49a03a24ecea150dfe13","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Elgg/Elgg/pulls/7430/commits","review_comments_url":"https://api.github.com/repos/Elgg/Elgg/pulls/7430/comments","review_comment_url":"https://api.github.com/repos/Elgg/Elgg/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Elgg/Elgg/issues/7430/comments","statuses_url":"https://api.github.com/repos/Elgg/Elgg/statuses/7d593351309cb39847121430eb6ecd7123716e35","head":{"label":"mrclay:6299_fix3","ref":"6299_fix3","sha":"7d593351309cb39847121430eb6ecd7123716e35","user":{"login":"mrclay","id":170687,"avatar_url":"https://avatars.githubusercontent.com/u/170687?v=3","gravatar_id":"","url":"https://api.github.com/users/mrclay","html_url":"https://github.com/mrclay","followers_url":"https://api.github.com/users/mrclay/followers","following_url":"https://api.github.com/users/mrclay/following{/other_user}","gists_url":"https://api.github.com/users/mrclay/gists{/gist_id}","starred_url":"https://api.github.com/users/mrclay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrclay/subscriptions","organizations_url":"https://api.github.com/users/mrclay/orgs","repos_url":"https://api.github.com/users/mrclay/repos","events_url":"https://api.github.com/users/mrclay/events{/privacy}","received_events_url":"https://api.github.com/users/mrclay/received_events","type":"User","site_admin":false},"repo":{"id":2142685,"name":"Elgg-leaf","full_name":"mrclay/Elgg-leaf","owner":{"login":"mrclay","id":170687,"avatar_url":"https://avatars.githubusercontent.com/u/170687?v=3","gravatar_id":"","url":"https://api.github.com/users/mrclay","html_url":"https://github.com/mrclay","followers_url":"https://api.github.com/users/mrclay/followers","following_url":"https://api.github.com/users/mrclay/following{/other_user}","gists_url":"https://api.github.com/users/mrclay/gists{/gist_id}","starred_url":"https://api.github.com/users/mrclay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrclay/subscriptions","organizations_url":"https://api.github.com/users/mrclay/orgs","repos_url":"https://api.github.com/users/mrclay/repos","events_url":"https://api.github.com/users/mrclay/events{/privacy}","received_events_url":"https://api.github.com/users/mrclay/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mrclay/Elgg-leaf","description":"A social networking engine","fork":true,"url":"https://api.github.com/repos/mrclay/Elgg-leaf","forks_url":"https://api.github.com/repos/mrclay/Elgg-leaf/forks","keys_url":"https://api.github.com/repos/mrclay/Elgg-leaf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrclay/Elgg-leaf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrclay/Elgg-leaf/teams","hooks_url":"https://api.github.com/repos/mrclay/Elgg-leaf/hooks","issue_events_url":"https://api.github.com/repos/mrclay/Elgg-leaf/issues/events{/number}","events_url":"https://api.github.com/repos/mrclay/Elgg-leaf/events","assignees_url":"https://api.github.com/repos/mrclay/Elgg-leaf/assignees{/user}","branches_url":"https://api.github.com/repos/mrclay/Elgg-leaf/branches{/branch}","tags_url":"https://api.github.com/repos/mrclay/Elgg-leaf/tags","blobs_url":"https://api.github.com/repos/mrclay/Elgg-leaf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrclay/Elgg-leaf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrclay/Elgg-leaf/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrclay/Elgg-leaf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrclay/Elgg-leaf/statuses/{sha}","languages_url":"https://api.github.com/repos/mrclay/Elgg-leaf/languages","stargazers_url":"https://api.github.com/repos/mrclay/Elgg-leaf/stargazers","contributors_url":"https://api.github.com/repos/mrclay/Elgg-leaf/contributors","subscribers_url":"https://api.github.com/repos/mrclay/Elgg-leaf/subscribers","subscription_url":"https://api.github.com/repos/mrclay/Elgg-leaf/subscription","commits_url":"https://api.github.com/repos/mrclay/Elgg-leaf/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrclay/Elgg-leaf/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrclay/Elgg-leaf/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrclay/Elgg-leaf/issues/comments/{number}","contents_url":"https://api.github.com/repos/mrclay/Elgg-leaf/contents/{+path}","compare_url":"https://api.github.com/repos/mrclay/Elgg-leaf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrclay/Elgg-leaf/merges","archive_url":"https://api.github.com/repos/mrclay/Elgg-leaf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrclay/Elgg-leaf/downloads","issues_url":"https://api.github.com/repos/mrclay/Elgg-leaf/issues{/number}","pulls_url":"https://api.github.com/repos/mrclay/Elgg-leaf/pulls{/number}","milestones_url":"https://api.github.com/repos/mrclay/Elgg-leaf/milestones{/number}","notifications_url":"https://api.github.com/repos/mrclay/Elgg-leaf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrclay/Elgg-leaf/labels{/name}","releases_url":"https://api.github.com/repos/mrclay/Elgg-leaf/releases{/id}","created_at":"2011-08-02T13:45:11Z","updated_at":"2014-06-24T23:34:38Z","pushed_at":"2014-11-19T04:29:53Z","git_url":"git://github.com/mrclay/Elgg-leaf.git","ssh_url":"git@github.com:mrclay/Elgg-leaf.git","clone_url":"https://github.com/mrclay/Elgg-leaf.git","svn_url":"https://github.com/mrclay/Elgg-leaf","homepage":"http://elgg.org","size":37330,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"Elgg:1.x","ref":"1.x","sha":"227c86e86c3f0337ada0c6d6c91d170fbfaec0ee","user":{"login":"Elgg","id":79167,"avatar_url":"https://avatars.githubusercontent.com/u/79167?v=3","gravatar_id":"","url":"https://api.github.com/users/Elgg","html_url":"https://github.com/Elgg","followers_url":"https://api.github.com/users/Elgg/followers","following_url":"https://api.github.com/users/Elgg/following{/other_user}","gists_url":"https://api.github.com/users/Elgg/gists{/gist_id}","starred_url":"https://api.github.com/users/Elgg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Elgg/subscriptions","organizations_url":"https://api.github.com/users/Elgg/orgs","repos_url":"https://api.github.com/users/Elgg/repos","events_url":"https://api.github.com/users/Elgg/events{/privacy}","received_events_url":"https://api.github.com/users/Elgg/received_events","type":"Organization","site_admin":false},"repo":{"id":299271,"name":"Elgg","full_name":"Elgg/Elgg","owner":{"login":"Elgg","id":79167,"avatar_url":"https://avatars.githubusercontent.com/u/79167?v=3","gravatar_id":"","url":"https://api.github.com/users/Elgg","html_url":"https://github.com/Elgg","followers_url":"https://api.github.com/users/Elgg/followers","following_url":"https://api.github.com/users/Elgg/following{/other_user}","gists_url":"https://api.github.com/users/Elgg/gists{/gist_id}","starred_url":"https://api.github.com/users/Elgg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Elgg/subscriptions","organizations_url":"https://api.github.com/users/Elgg/orgs","repos_url":"https://api.github.com/users/Elgg/repos","events_url":"https://api.github.com/users/Elgg/events{/privacy}","received_events_url":"https://api.github.com/users/Elgg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Elgg/Elgg","description":"A social networking engine","fork":false,"url":"https://api.github.com/repos/Elgg/Elgg","forks_url":"https://api.github.com/repos/Elgg/Elgg/forks","keys_url":"https://api.github.com/repos/Elgg/Elgg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Elgg/Elgg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Elgg/Elgg/teams","hooks_url":"https://api.github.com/repos/Elgg/Elgg/hooks","issue_events_url":"https://api.github.com/repos/Elgg/Elgg/issues/events{/number}","events_url":"https://api.github.com/repos/Elgg/Elgg/events","assignees_url":"https://api.github.com/repos/Elgg/Elgg/assignees{/user}","branches_url":"https://api.github.com/repos/Elgg/Elgg/branches{/branch}","tags_url":"https://api.github.com/repos/Elgg/Elgg/tags","blobs_url":"https://api.github.com/repos/Elgg/Elgg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Elgg/Elgg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Elgg/Elgg/git/refs{/sha}","trees_url":"https://api.github.com/repos/Elgg/Elgg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Elgg/Elgg/statuses/{sha}","languages_url":"https://api.github.com/repos/Elgg/Elgg/languages","stargazers_url":"https://api.github.com/repos/Elgg/Elgg/stargazers","contributors_url":"https://api.github.com/repos/Elgg/Elgg/contributors","subscribers_url":"https://api.github.com/repos/Elgg/Elgg/subscribers","subscription_url":"https://api.github.com/repos/Elgg/Elgg/subscription","commits_url":"https://api.github.com/repos/Elgg/Elgg/commits{/sha}","git_commits_url":"https://api.github.com/repos/Elgg/Elgg/git/commits{/sha}","comments_url":"https://api.github.com/repos/Elgg/Elgg/comments{/number}","issue_comment_url":"https://api.github.com/repos/Elgg/Elgg/issues/comments/{number}","contents_url":"https://api.github.com/repos/Elgg/Elgg/contents/{+path}","compare_url":"https://api.github.com/repos/Elgg/Elgg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Elgg/Elgg/merges","archive_url":"https://api.github.com/repos/Elgg/Elgg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Elgg/Elgg/downloads","issues_url":"https://api.github.com/repos/Elgg/Elgg/issues{/number}","pulls_url":"https://api.github.com/repos/Elgg/Elgg/pulls{/number}","milestones_url":"https://api.github.com/repos/Elgg/Elgg/milestones{/number}","notifications_url":"https://api.github.com/repos/Elgg/Elgg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Elgg/Elgg/labels{/name}","releases_url":"https://api.github.com/repos/Elgg/Elgg/releases{/id}","created_at":"2009-09-06T17:10:11Z","updated_at":"2014-11-18T23:04:51Z","pushed_at":"2014-11-18T23:22:22Z","git_url":"git://github.com/Elgg/Elgg.git","ssh_url":"git@github.com:Elgg/Elgg.git","clone_url":"https://github.com/Elgg/Elgg.git","svn_url":"https://github.com/Elgg/Elgg","homepage":"http://elgg.org","size":63755,"stargazers_count":637,"watchers_count":637,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":391,"mirror_url":null,"open_issues_count":826,"forks":391,"open_issues":826,"watchers":637,"default_branch":"1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/Elgg/Elgg/pulls/7430"},"html":{"href":"https://github.com/Elgg/Elgg/pull/7430"},"issue":{"href":"https://api.github.com/repos/Elgg/Elgg/issues/7430"},"comments":{"href":"https://api.github.com/repos/Elgg/Elgg/issues/7430/comments"},"review_comments":{"href":"https://api.github.com/repos/Elgg/Elgg/pulls/7430/comments"},"review_comment":{"href":"https://api.github.com/repos/Elgg/Elgg/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Elgg/Elgg/pulls/7430/commits"},"statuses":{"href":"https://api.github.com/repos/Elgg/Elgg/statuses/7d593351309cb39847121430eb6ecd7123716e35"}}}}