GitHub PullRequestReviewCommentEvent at 2014-12-18 16:39:29
Repository: incubator-reef
Actor: markusweimer
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-reef/pulls/comments/22053271","id":22053271,"diff_hunk":"@@ -0,0 +1,94 @@\n+/**\n+ * Licensed to the Apache Software Foundation (ASF) under one\n+ * or more contributor license agreements.  See the NOTICE file\n+ * distributed with this work for additional information\n+ * regarding copyright ownership.  The ASF licenses this file\n+ * to you under the Apache License, Version 2.0 (the\n+ * \"License\"); you may not use this file except in compliance\n+ * with the License.  You may obtain a copy of the License at\n+ *\n+ *   http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing,\n+ * software distributed under the License is distributed on an\n+ * \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY\n+ * KIND, either express or implied.  See the License for the\n+ * specific language governing permissions and limitations\n+ * under the License.\n+ */\n+package org.apache.reef.runtime.yarn.driver;\n+\n+import org.apache.hadoop.fs.FileContext;\n+import org.apache.hadoop.fs.FileStatus;\n+import org.apache.hadoop.fs.FileSystem;\n+import org.apache.hadoop.fs.Path;\n+import org.apache.hadoop.yarn.api.records.LocalResource;\n+import org.apache.hadoop.yarn.api.records.LocalResourceType;\n+import org.apache.hadoop.yarn.api.records.LocalResourceVisibility;\n+import org.apache.hadoop.yarn.conf.YarnConfiguration;\n+import org.apache.hadoop.yarn.util.ConverterUtils;\n+import org.apache.hadoop.yarn.util.Records;\n+import org.apache.reef.runtime.yarn.driver.parameters.JobSubmissionDirectory;\n+import org.apache.reef.tang.annotations.Parameter;\n+\n+import javax.inject.Inject;\n+import java.io.File;\n+import java.io.IOException;\n+import java.util.logging.Level;\n+import java.util.logging.Logger;\n+\n+/**\n+ * Uploads files to the current job folder.\n+ */\n+final class UploaderToJobfolder {","path":"reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/UploaderToJobfolder.java","position":43,"original_position":43,"commit_id":"4164d999f01f941257a17dc24ac6c63253e4d88b","original_commit_id":"4164d999f01f941257a17dc24ac6c63253e4d88b","user":{"login":"markusweimer","id":502371,"avatar_url":"https://avatars.githubusercontent.com/u/502371?v=3","gravatar_id":"","url":"https://api.github.com/users/markusweimer","html_url":"https://github.com/markusweimer","followers_url":"https://api.github.com/users/markusweimer/followers","following_url":"https://api.github.com/users/markusweimer/following{/other_user}","gists_url":"https://api.github.com/users/markusweimer/gists{/gist_id}","starred_url":"https://api.github.com/users/markusweimer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markusweimer/subscriptions","organizations_url":"https://api.github.com/users/markusweimer/orgs","repos_url":"https://api.github.com/users/markusweimer/repos","events_url":"https://api.github.com/users/markusweimer/events{/privacy}","received_events_url":"https://api.github.com/users/markusweimer/received_events","type":"User","site_admin":false},"body":"Thanks! Good catch. I will fix it in the next commit.","created_at":"2014-12-18T16:39:29Z","updated_at":"2014-12-18T16:39:29Z","html_url":"https://github.com/apache/incubator-reef/pull/28#discussion_r22053271","pull_request_url":"https://api.github.com/repos/apache/incubator-reef/pulls/28","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-reef/pulls/comments/22053271"},"html":{"href":"https://github.com/apache/incubator-reef/pull/28#discussion_r22053271"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-reef/pulls/28"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-reef/pulls/28","id":25387730,"html_url":"https://github.com/apache/incubator-reef/pull/28","diff_url":"https://github.com/apache/incubator-reef/pull/28.diff","patch_url":"https://github.com/apache/incubator-reef/pull/28.patch","issue_url":"https://api.github.com/repos/apache/incubator-reef/issues/28","number":28,"state":"open","locked":false,"title":"[REEF-55]: Delayed creation and upload of the global.jar file until the first Evaluator submission on YARN.","user":{"login":"markusweimer","id":502371,"avatar_url":"https://avatars.githubusercontent.com/u/502371?v=3","gravatar_id":"","url":"https://api.github.com/users/markusweimer","html_url":"https://github.com/markusweimer","followers_url":"https://api.github.com/users/markusweimer/followers","following_url":"https://api.github.com/users/markusweimer/following{/other_user}","gists_url":"https://api.github.com/users/markusweimer/gists{/gist_id}","starred_url":"https://api.github.com/users/markusweimer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markusweimer/subscriptions","organizations_url":"https://api.github.com/users/markusweimer/orgs","repos_url":"https://api.github.com/users/markusweimer/repos","events_url":"https://api.github.com/users/markusweimer/events{/privacy}","received_events_url":"https://api.github.com/users/markusweimer/received_events","type":"User","site_admin":false},"body":"  * Added the `GlobalJarUploader` class which performs the creation and upload. It is a `Callable` such that we can move this to a thread in a future version\r\n  * Moved the actual upload logic from `EvaluatorSetupHelper` to `UploaderToJobFolder`\r\n\r\nJIRA:\r\n  [REEF-55]: https://issues.apache.org/jira/browse/REEF-55","created_at":"2014-12-03T00:43:47Z","updated_at":"2014-12-18T16:39:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"45e6f06c8008a07423c7cd2646bd0a5804b19201","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-reef/pulls/28/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-reef/pulls/28/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-reef/pulls/comments/{number}","comments_url":"https://api.github.com/repos/apache/incubator-reef/issues/28/comments","statuses_url":"https://api.github.com/repos/apache/incubator-reef/statuses/4164d999f01f941257a17dc24ac6c63253e4d88b","head":{"label":"markusweimer:reef-55","ref":"reef-55","sha":"4164d999f01f941257a17dc24ac6c63253e4d88b","user":{"login":"markusweimer","id":502371,"avatar_url":"https://avatars.githubusercontent.com/u/502371?v=3","gravatar_id":"","url":"https://api.github.com/users/markusweimer","html_url":"https://github.com/markusweimer","followers_url":"https://api.github.com/users/markusweimer/followers","following_url":"https://api.github.com/users/markusweimer/following{/other_user}","gists_url":"https://api.github.com/users/markusweimer/gists{/gist_id}","starred_url":"https://api.github.com/users/markusweimer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markusweimer/subscriptions","organizations_url":"https://api.github.com/users/markusweimer/orgs","repos_url":"https://api.github.com/users/markusweimer/repos","events_url":"https://api.github.com/users/markusweimer/events{/privacy}","received_events_url":"https://api.github.com/users/markusweimer/received_events","type":"User","site_admin":false},"repo":{"id":25646809,"name":"incubator-reef","full_name":"markusweimer/incubator-reef","owner":{"login":"markusweimer","id":502371,"avatar_url":"https://avatars.githubusercontent.com/u/502371?v=3","gravatar_id":"","url":"https://api.github.com/users/markusweimer","html_url":"https://github.com/markusweimer","followers_url":"https://api.github.com/users/markusweimer/followers","following_url":"https://api.github.com/users/markusweimer/following{/other_user}","gists_url":"https://api.github.com/users/markusweimer/gists{/gist_id}","starred_url":"https://api.github.com/users/markusweimer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markusweimer/subscriptions","organizations_url":"https://api.github.com/users/markusweimer/orgs","repos_url":"https://api.github.com/users/markusweimer/repos","events_url":"https://api.github.com/users/markusweimer/events{/privacy}","received_events_url":"https://api.github.com/users/markusweimer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/markusweimer/incubator-reef","description":"Mirror of Apache REEF (Incubating)","fork":true,"url":"https://api.github.com/repos/markusweimer/incubator-reef","forks_url":"https://api.github.com/repos/markusweimer/incubator-reef/forks","keys_url":"https://api.github.com/repos/markusweimer/incubator-reef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/markusweimer/incubator-reef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/markusweimer/incubator-reef/teams","hooks_url":"https://api.github.com/repos/markusweimer/incubator-reef/hooks","issue_events_url":"https://api.github.com/repos/markusweimer/incubator-reef/issues/events{/number}","events_url":"https://api.github.com/repos/markusweimer/incubator-reef/events","assignees_url":"https://api.github.com/repos/markusweimer/incubator-reef/assignees{/user}","branches_url":"https://api.github.com/repos/markusweimer/incubator-reef/branches{/branch}","tags_url":"https://api.github.com/repos/markusweimer/incubator-reef/tags","blobs_url":"https://api.github.com/repos/markusweimer/incubator-reef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/markusweimer/incubator-reef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/markusweimer/incubator-reef/git/refs{/sha}","trees_url":"https://api.github.com/repos/markusweimer/incubator-reef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/markusweimer/incubator-reef/statuses/{sha}","languages_url":"https://api.github.com/repos/markusweimer/incubator-reef/languages","stargazers_url":"https://api.github.com/repos/markusweimer/incubator-reef/stargazers","contributors_url":"https://api.github.com/repos/markusweimer/incubator-reef/contributors","subscribers_url":"https://api.github.com/repos/markusweimer/incubator-reef/subscribers","subscription_url":"https://api.github.com/repos/markusweimer/incubator-reef/subscription","commits_url":"https://api.github.com/repos/markusweimer/incubator-reef/commits{/sha}","git_commits_url":"https://api.github.com/repos/markusweimer/incubator-reef/git/commits{/sha}","comments_url":"https://api.github.com/repos/markusweimer/incubator-reef/comments{/number}","issue_comment_url":"https://api.github.com/repos/markusweimer/incubator-reef/issues/comments/{number}","contents_url":"https://api.github.com/repos/markusweimer/incubator-reef/contents/{+path}","compare_url":"https://api.github.com/repos/markusweimer/incubator-reef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/markusweimer/incubator-reef/merges","archive_url":"https://api.github.com/repos/markusweimer/incubator-reef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/markusweimer/incubator-reef/downloads","issues_url":"https://api.github.com/repos/markusweimer/incubator-reef/issues{/number}","pulls_url":"https://api.github.com/repos/markusweimer/incubator-reef/pulls{/number}","milestones_url":"https://api.github.com/repos/markusweimer/incubator-reef/milestones{/number}","notifications_url":"https://api.github.com/repos/markusweimer/incubator-reef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/markusweimer/incubator-reef/labels{/name}","releases_url":"https://api.github.com/repos/markusweimer/incubator-reef/releases{/id}","created_at":"2014-10-23T16:30:56Z","updated_at":"2014-10-23T15:08:44Z","pushed_at":"2014-12-14T18:43:45Z","git_url":"git://github.com/markusweimer/incubator-reef.git","ssh_url":"git@github.com:markusweimer/incubator-reef.git","clone_url":"https://github.com/markusweimer/incubator-reef.git","svn_url":"https://github.com/markusweimer/incubator-reef","homepage":null,"size":9721,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"7492d26b5f295fcba4a746b353318ce234aea0cc","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":25623941,"name":"incubator-reef","full_name":"apache/incubator-reef","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-reef","description":"Mirror of Apache REEF (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-reef","forks_url":"https://api.github.com/repos/apache/incubator-reef/forks","keys_url":"https://api.github.com/repos/apache/incubator-reef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-reef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-reef/teams","hooks_url":"https://api.github.com/repos/apache/incubator-reef/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-reef/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-reef/events","assignees_url":"https://api.github.com/repos/apache/incubator-reef/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-reef/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-reef/tags","blobs_url":"https://api.github.com/repos/apache/incubator-reef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-reef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-reef/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-reef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-reef/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-reef/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-reef/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-reef/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-reef/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-reef/subscription","commits_url":"https://api.github.com/repos/apache/incubator-reef/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-reef/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-reef/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-reef/issues/comments/{number}","contents_url":"https://api.github.com/repos/apache/incubator-reef/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-reef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-reef/merges","archive_url":"https://api.github.com/repos/apache/incubator-reef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-reef/downloads","issues_url":"https://api.github.com/repos/apache/incubator-reef/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-reef/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-reef/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-reef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-reef/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-reef/releases{/id}","created_at":"2014-10-23T07:00:10Z","updated_at":"2014-12-18T04:30:26Z","pushed_at":"2014-12-18T07:22:35Z","git_url":"git://github.com/apache/incubator-reef.git","ssh_url":"git@github.com:apache/incubator-reef.git","clone_url":"https://github.com/apache/incubator-reef.git","svn_url":"https://github.com/apache/incubator-reef","homepage":null,"size":10196,"stargazers_count":7,"watchers_count":7,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":"git://git.apache.org/incubator-reef.git","open_issues_count":3,"forks":11,"open_issues":3,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-reef/pulls/28"},"html":{"href":"https://github.com/apache/incubator-reef/pull/28"},"issue":{"href":"https://api.github.com/repos/apache/incubator-reef/issues/28"},"comments":{"href":"https://api.github.com/repos/apache/incubator-reef/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-reef/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-reef/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-reef/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-reef/statuses/4164d999f01f941257a17dc24ac6c63253e4d88b"}}}}