GitHub PullRequestReviewCommentEvent at 2014-02-11 07:19:05
Repository: occmodel
Actor: paulmelnikow
Payload: {"comment":{"url":"https://api.github.com/repos/tenko/occmodel/pulls/comments/9615306","id":9615306,"diff_hunk":"@@ -60,15 +60,15 @@\n     OCCLIBS = []\n     OBJECTS = [name + '.lib' for name in OCC.split()] + ['occmodel.lib',]\n else:\n-    OCCINCLUDE = '/usr/include/oce'\n+    OCCINCLUDE = (sys.platform == 'darwin') and '/usr/local/include/oce' or '/usr/include/oce'\n     OCCLIBS = OCC.split()\n-    LIBS.append(\"occmodel\")\n     LIBS.append(\"pthread\")\n     COMPILE_ARGS.append(\"-fpermissive\")\n \n EXTENSIONS = [\n     Extension(\"occmodel\",\n-        sources = [\"occmodel/occmodel.pyx\"],\n+        sources = [\"occmodel/occmodel.pyx\"] + \\\n+                  glob.glob(\"occmodel/@src/*.cpp\"),","path":"setup_build.py","position":24,"original_position":24,"commit_id":"4f50dc975b9a4c1cee1dc039f3910fd2c1b902f6","original_commit_id":"4f50dc975b9a4c1cee1dc039f3910fd2c1b902f6","user":{"login":"paulmelnikow","id":1487036,"avatar_url":"https://gravatar.com/avatar/822d02802477a759f8d3f2fa637055f6?d=https%3A%2F%2Fidenticons.github.com%2Fc86981602b240cd0210b568a3fc6c807.png&r=x","gravatar_id":"822d02802477a759f8d3f2fa637055f6","url":"https://api.github.com/users/paulmelnikow","html_url":"https://github.com/paulmelnikow","followers_url":"https://api.github.com/users/paulmelnikow/followers","following_url":"https://api.github.com/users/paulmelnikow/following{/other_user}","gists_url":"https://api.github.com/users/paulmelnikow/gists{/gist_id}","starred_url":"https://api.github.com/users/paulmelnikow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulmelnikow/subscriptions","organizations_url":"https://api.github.com/users/paulmelnikow/orgs","repos_url":"https://api.github.com/users/paulmelnikow/repos","events_url":"https://api.github.com/users/paulmelnikow/events{/privacy}","received_events_url":"https://api.github.com/users/paulmelnikow/received_events","type":"User","site_admin":false},"body":"Without the .cpp files, occmodel is not importable.","created_at":"2014-02-11T07:19:05Z","updated_at":"2014-02-11T07:19:05Z","html_url":"https://github.com/tenko/occmodel/pull/1#discussion_r9615306","pull_request_url":"https://api.github.com/repos/tenko/occmodel/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/tenko/occmodel/pulls/comments/9615306"},"html":{"href":"https://github.com/tenko/occmodel/pull/1#discussion_r9615306"},"pull_request":{"href":"https://api.github.com/repos/tenko/occmodel/pulls/1"}}}}