GitHub PullRequestReviewCommentEvent at 2014-07-22 15:16:15
Repository: brackets
Actor: MiguelCastillo
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/adobe/brackets/pulls/comments/15233638","id":15233638,"diff_hunk":"@@ -347,6 +551,10 @@ define(function (require, exports, module) {\n     CommandManager.register(Strings.CMD_THEMES,             Commands.CMD_THEMES_OPEN_SETTINGS, _handleThemeSettings);\n \n     PreferencesManager.convertPreferences(module, {\"fontSizeAdjustment\": \"user\"}, true, _convertToNewViewState);\n+    \n+    prefs.definePreference(\"fontSize\",   \"string\", DEFAULT_FONT_SIZE + \"px\");","path":"src/view/ViewCommandHandlers.js","position":390,"original_position":390,"commit_id":"9c339f0bc1a4bdcafa581c92e5f4e15082044855","original_commit_id":"9c339f0bc1a4bdcafa581c92e5f4e15082044855","user":{"login":"MiguelCastillo","id":1457701,"avatar_url":"https://avatars.githubusercontent.com/u/1457701?","gravatar_id":"2e4ded36d9857f81ea2e5daf00e929cc","url":"https://api.github.com/users/MiguelCastillo","html_url":"https://github.com/MiguelCastillo","followers_url":"https://api.github.com/users/MiguelCastillo/followers","following_url":"https://api.github.com/users/MiguelCastillo/following{/other_user}","gists_url":"https://api.github.com/users/MiguelCastillo/gists{/gist_id}","starred_url":"https://api.github.com/users/MiguelCastillo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MiguelCastillo/subscriptions","organizations_url":"https://api.github.com/users/MiguelCastillo/orgs","repos_url":"https://api.github.com/users/MiguelCastillo/repos","events_url":"https://api.github.com/users/MiguelCastillo/events{/privacy}","received_events_url":"https://api.github.com/users/MiguelCastillo/received_events","type":"User","site_admin":false},"body":"Yeah man, I had that before... I removed it because for some odd reason the listener was never getting called.  I guess I should have asked :/\r\n\r\nhttps://github.com/MiguelCastillo/brackets/commit/395dd1e471087646960d6e2da4d8c466362aa579","created_at":"2014-07-22T15:16:15Z","updated_at":"2014-07-22T15:16:15Z","html_url":"https://github.com/adobe/brackets/pull/8492#discussion_r15233638","pull_request_url":"https://api.github.com/repos/adobe/brackets/pulls/8492","_links":{"self":{"href":"https://api.github.com/repos/adobe/brackets/pulls/comments/15233638"},"html":{"href":"https://github.com/adobe/brackets/pull/8492#discussion_r15233638"},"pull_request":{"href":"https://api.github.com/repos/adobe/brackets/pulls/8492"}}},"pull_request":{"url":"https://api.github.com/repos/adobe/brackets/pulls/8492","id":18691564,"html_url":"https://github.com/adobe/brackets/pull/8492","diff_url":"https://github.com/adobe/brackets/pull/8492.diff","patch_url":"https://github.com/adobe/brackets/pull/8492.patch","issue_url":"https://api.github.com/repos/adobe/brackets/issues/8492","number":8492,"state":"open","title":"Fonts api with Themes integrated","user":{"login":"MiguelCastillo","id":1457701,"avatar_url":"https://avatars.githubusercontent.com/u/1457701?","gravatar_id":"2e4ded36d9857f81ea2e5daf00e929cc","url":"https://api.github.com/users/MiguelCastillo","html_url":"https://github.com/MiguelCastillo","followers_url":"https://api.github.com/users/MiguelCastillo/followers","following_url":"https://api.github.com/users/MiguelCastillo/following{/other_user}","gists_url":"https://api.github.com/users/MiguelCastillo/gists{/gist_id}","starred_url":"https://api.github.com/users/MiguelCastillo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MiguelCastillo/subscriptions","organizations_url":"https://api.github.com/users/MiguelCastillo/orgs","repos_url":"https://api.github.com/users/MiguelCastillo/repos","events_url":"https://api.github.com/users/MiguelCastillo/events{/privacy}","received_events_url":"https://api.github.com/users/MiguelCastillo/received_events","type":"User","site_admin":false},"body":"Fixes:\r\nhttps://github.com/adobe/brackets/issues/8425\r\nhttps://github.com/adobe/brackets/issues/8381\r\n\r\nReferences:\r\nhttps://github.com/adobe/brackets/pull/8305\r\n","created_at":"2014-07-22T02:11:36Z","updated_at":"2014-07-22T15:16:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c4e6329cb9bfd80f5cd53b4e661a75aacb677a1d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/adobe/brackets/pulls/8492/commits","review_comments_url":"https://api.github.com/repos/adobe/brackets/pulls/8492/comments","review_comment_url":"https://api.github.com/repos/adobe/brackets/pulls/comments/{number}","comments_url":"https://api.github.com/repos/adobe/brackets/issues/8492/comments","statuses_url":"https://api.github.com/repos/adobe/brackets/statuses/9c339f0bc1a4bdcafa581c92e5f4e15082044855","head":{"label":"MiguelCastillo:fonts","ref":"fonts","sha":"9c339f0bc1a4bdcafa581c92e5f4e15082044855","user":{"login":"MiguelCastillo","id":1457701,"avatar_url":"https://avatars.githubusercontent.com/u/1457701?","gravatar_id":"2e4ded36d9857f81ea2e5daf00e929cc","url":"https://api.github.com/users/MiguelCastillo","html_url":"https://github.com/MiguelCastillo","followers_url":"https://api.github.com/users/MiguelCastillo/followers","following_url":"https://api.github.com/users/MiguelCastillo/following{/other_user}","gists_url":"https://api.github.com/users/MiguelCastillo/gists{/gist_id}","starred_url":"https://api.github.com/users/MiguelCastillo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MiguelCastillo/subscriptions","organizations_url":"https://api.github.com/users/MiguelCastillo/orgs","repos_url":"https://api.github.com/users/MiguelCastillo/repos","events_url":"https://api.github.com/users/MiguelCastillo/events{/privacy}","received_events_url":"https://api.github.com/users/MiguelCastillo/received_events","type":"User","site_admin":false},"repo":{"id":19053237,"name":"brackets","full_name":"MiguelCastillo/brackets","owner":{"login":"MiguelCastillo","id":1457701,"avatar_url":"https://avatars.githubusercontent.com/u/1457701?","gravatar_id":"2e4ded36d9857f81ea2e5daf00e929cc","url":"https://api.github.com/users/MiguelCastillo","html_url":"https://github.com/MiguelCastillo","followers_url":"https://api.github.com/users/MiguelCastillo/followers","following_url":"https://api.github.com/users/MiguelCastillo/following{/other_user}","gists_url":"https://api.github.com/users/MiguelCastillo/gists{/gist_id}","starred_url":"https://api.github.com/users/MiguelCastillo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MiguelCastillo/subscriptions","organizations_url":"https://api.github.com/users/MiguelCastillo/orgs","repos_url":"https://api.github.com/users/MiguelCastillo/repos","events_url":"https://api.github.com/users/MiguelCastillo/events{/privacy}","received_events_url":"https://api.github.com/users/MiguelCastillo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MiguelCastillo/brackets","description":"An open source code editor for the web, written in JavaScript, HTML and CSS.","fork":true,"url":"https://api.github.com/repos/MiguelCastillo/brackets","forks_url":"https://api.github.com/repos/MiguelCastillo/brackets/forks","keys_url":"https://api.github.com/repos/MiguelCastillo/brackets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MiguelCastillo/brackets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MiguelCastillo/brackets/teams","hooks_url":"https://api.github.com/repos/MiguelCastillo/brackets/hooks","issue_events_url":"https://api.github.com/repos/MiguelCastillo/brackets/issues/events{/number}","events_url":"https://api.github.com/repos/MiguelCastillo/brackets/events","assignees_url":"https://api.github.com/repos/MiguelCastillo/brackets/assignees{/user}","branches_url":"https://api.github.com/repos/MiguelCastillo/brackets/branches{/branch}","tags_url":"https://api.github.com/repos/MiguelCastillo/brackets/tags","blobs_url":"https://api.github.com/repos/MiguelCastillo/brackets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MiguelCastillo/brackets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MiguelCastillo/brackets/git/refs{/sha}","trees_url":"https://api.github.com/repos/MiguelCastillo/brackets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MiguelCastillo/brackets/statuses/{sha}","languages_url":"https://api.github.com/repos/MiguelCastillo/brackets/languages","stargazers_url":"https://api.github.com/repos/MiguelCastillo/brackets/stargazers","contributors_url":"https://api.github.com/repos/MiguelCastillo/brackets/contributors","subscribers_url":"https://api.github.com/repos/MiguelCastillo/brackets/subscribers","subscription_url":"https://api.github.com/repos/MiguelCastillo/brackets/subscription","commits_url":"https://api.github.com/repos/MiguelCastillo/brackets/commits{/sha}","git_commits_url":"https://api.github.com/repos/MiguelCastillo/brackets/git/commits{/sha}","comments_url":"https://api.github.com/repos/MiguelCastillo/brackets/comments{/number}","issue_comment_url":"https://api.github.com/repos/MiguelCastillo/brackets/issues/comments/{number}","contents_url":"https://api.github.com/repos/MiguelCastillo/brackets/contents/{+path}","compare_url":"https://api.github.com/repos/MiguelCastillo/brackets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MiguelCastillo/brackets/merges","archive_url":"https://api.github.com/repos/MiguelCastillo/brackets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MiguelCastillo/brackets/downloads","issues_url":"https://api.github.com/repos/MiguelCastillo/brackets/issues{/number}","pulls_url":"https://api.github.com/repos/MiguelCastillo/brackets/pulls{/number}","milestones_url":"https://api.github.com/repos/MiguelCastillo/brackets/milestones{/number}","notifications_url":"https://api.github.com/repos/MiguelCastillo/brackets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MiguelCastillo/brackets/labels{/name}","releases_url":"https://api.github.com/repos/MiguelCastillo/brackets/releases{/id}","created_at":"2014-04-23T01:51:18Z","updated_at":"2014-06-29T13:47:10Z","pushed_at":"2014-07-22T13:43:53Z","git_url":"git://github.com/MiguelCastillo/brackets.git","ssh_url":"git@github.com:MiguelCastillo/brackets.git","clone_url":"https://github.com/MiguelCastillo/brackets.git","svn_url":"https://github.com/MiguelCastillo/brackets","homepage":"http://brackets.io","size":64892,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"adobe:master","ref":"master","sha":"2bd4f7baceb18c302d24b8260e3e4f2561a94e4b","user":{"login":"adobe","id":476009,"avatar_url":"https://avatars.githubusercontent.com/u/476009?","gravatar_id":"cc40327f6f93a7b75207a152962d8dbe","url":"https://api.github.com/users/adobe","html_url":"https://github.com/adobe","followers_url":"https://api.github.com/users/adobe/followers","following_url":"https://api.github.com/users/adobe/following{/other_user}","gists_url":"https://api.github.com/users/adobe/gists{/gist_id}","starred_url":"https://api.github.com/users/adobe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adobe/subscriptions","organizations_url":"https://api.github.com/users/adobe/orgs","repos_url":"https://api.github.com/users/adobe/repos","events_url":"https://api.github.com/users/adobe/events{/privacy}","received_events_url":"https://api.github.com/users/adobe/received_events","type":"Organization","site_admin":false},"repo":{"id":2935735,"name":"brackets","full_name":"adobe/brackets","owner":{"login":"adobe","id":476009,"avatar_url":"https://avatars.githubusercontent.com/u/476009?","gravatar_id":"cc40327f6f93a7b75207a152962d8dbe","url":"https://api.github.com/users/adobe","html_url":"https://github.com/adobe","followers_url":"https://api.github.com/users/adobe/followers","following_url":"https://api.github.com/users/adobe/following{/other_user}","gists_url":"https://api.github.com/users/adobe/gists{/gist_id}","starred_url":"https://api.github.com/users/adobe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adobe/subscriptions","organizations_url":"https://api.github.com/users/adobe/orgs","repos_url":"https://api.github.com/users/adobe/repos","events_url":"https://api.github.com/users/adobe/events{/privacy}","received_events_url":"https://api.github.com/users/adobe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/adobe/brackets","description":"An open source code editor for the web, written in JavaScript, HTML and CSS.","fork":false,"url":"https://api.github.com/repos/adobe/brackets","forks_url":"https://api.github.com/repos/adobe/brackets/forks","keys_url":"https://api.github.com/repos/adobe/brackets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adobe/brackets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adobe/brackets/teams","hooks_url":"https://api.github.com/repos/adobe/brackets/hooks","issue_events_url":"https://api.github.com/repos/adobe/brackets/issues/events{/number}","events_url":"https://api.github.com/repos/adobe/brackets/events","assignees_url":"https://api.github.com/repos/adobe/brackets/assignees{/user}","branches_url":"https://api.github.com/repos/adobe/brackets/branches{/branch}","tags_url":"https://api.github.com/repos/adobe/brackets/tags","blobs_url":"https://api.github.com/repos/adobe/brackets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adobe/brackets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adobe/brackets/git/refs{/sha}","trees_url":"https://api.github.com/repos/adobe/brackets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adobe/brackets/statuses/{sha}","languages_url":"https://api.github.com/repos/adobe/brackets/languages","stargazers_url":"https://api.github.com/repos/adobe/brackets/stargazers","contributors_url":"https://api.github.com/repos/adobe/brackets/contributors","subscribers_url":"https://api.github.com/repos/adobe/brackets/subscribers","subscription_url":"https://api.github.com/repos/adobe/brackets/subscription","commits_url":"https://api.github.com/repos/adobe/brackets/commits{/sha}","git_commits_url":"https://api.github.com/repos/adobe/brackets/git/commits{/sha}","comments_url":"https://api.github.com/repos/adobe/brackets/comments{/number}","issue_comment_url":"https://api.github.com/repos/adobe/brackets/issues/comments/{number}","contents_url":"https://api.github.com/repos/adobe/brackets/contents/{+path}","compare_url":"https://api.github.com/repos/adobe/brackets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adobe/brackets/merges","archive_url":"https://api.github.com/repos/adobe/brackets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adobe/brackets/downloads","issues_url":"https://api.github.com/repos/adobe/brackets/issues{/number}","pulls_url":"https://api.github.com/repos/adobe/brackets/pulls{/number}","milestones_url":"https://api.github.com/repos/adobe/brackets/milestones{/number}","notifications_url":"https://api.github.com/repos/adobe/brackets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adobe/brackets/labels{/name}","releases_url":"https://api.github.com/repos/adobe/brackets/releases{/id}","created_at":"2011-12-07T21:14:40Z","updated_at":"2014-07-22T13:52:09Z","pushed_at":"2014-07-22T13:08:37Z","git_url":"git://github.com/adobe/brackets.git","ssh_url":"git@github.com:adobe/brackets.git","clone_url":"https://github.com/adobe/brackets.git","svn_url":"https://github.com/adobe/brackets","homepage":"http://brackets.io","size":300255,"stargazers_count":16963,"watchers_count":16963,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":3490,"mirror_url":null,"open_issues_count":913,"forks":3490,"open_issues":913,"watchers":16963,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/adobe/brackets/pulls/8492"},"html":{"href":"https://github.com/adobe/brackets/pull/8492"},"issue":{"href":"https://api.github.com/repos/adobe/brackets/issues/8492"},"comments":{"href":"https://api.github.com/repos/adobe/brackets/issues/8492/comments"},"review_comments":{"href":"https://api.github.com/repos/adobe/brackets/pulls/8492/comments"},"review_comment":{"href":"https://api.github.com/repos/adobe/brackets/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/adobe/brackets/pulls/8492/commits"},"statuses":{"href":"https://api.github.com/repos/adobe/brackets/statuses/9c339f0bc1a4bdcafa581c92e5f4e15082044855"}}}}