GitHub PullRequestReviewCommentEvent at 2014-12-03 14:39:52
Repository: phpspec
Actor: richardmiller
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/phpspec/phpspec/pulls/comments/21234589","id":21234589,"diff_hunk":"@@ -173,4 +169,34 @@ protected function parseConfigurationFile(InputInterface $input)\n \n         return $config;\n     }\n+\n+    /**\n+     * @param ServiceContainer $container\n+     * @param $class\n+     * @param $extensionConfig\n+     * @throws \\RuntimeException\n+     */\n+    private function loadExtension(ServiceContainer $container, $class, $extensionConfig)\n+    {\n+        $extension = new $class();\n+\n+        if ($extension instanceof Extension\\ExtensionInterface) {\n+            $extension->load($container, $container->getParam('compat.testwork-extensions.config'));","path":"src/PhpSpec/Console/Application.php","position":67,"original_position":67,"commit_id":"295aae39b4a86f0d229f0d5eac2b0b910507b0d7","original_commit_id":"295aae39b4a86f0d229f0d5eac2b0b910507b0d7","user":{"login":"richardmiller","id":783827,"avatar_url":"https://avatars.githubusercontent.com/u/783827?v=3","gravatar_id":"","url":"https://api.github.com/users/richardmiller","html_url":"https://github.com/richardmiller","followers_url":"https://api.github.com/users/richardmiller/followers","following_url":"https://api.github.com/users/richardmiller/following{/other_user}","gists_url":"https://api.github.com/users/richardmiller/gists{/gist_id}","starred_url":"https://api.github.com/users/richardmiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardmiller/subscriptions","organizations_url":"https://api.github.com/users/richardmiller/orgs","repos_url":"https://api.github.com/users/richardmiller/repos","events_url":"https://api.github.com/users/richardmiller/events{/privacy}","received_events_url":"https://api.github.com/users/richardmiller/received_events","type":"User","site_admin":false},"body":"Actually looking again that should not be passed at all to the legacy extensions and doesn't need to be. I will remove it.","created_at":"2014-12-03T14:39:52Z","updated_at":"2014-12-03T14:39:52Z","html_url":"https://github.com/phpspec/phpspec/pull/575#discussion_r21234589","pull_request_url":"https://api.github.com/repos/phpspec/phpspec/pulls/575","_links":{"self":{"href":"https://api.github.com/repos/phpspec/phpspec/pulls/comments/21234589"},"html":{"href":"https://github.com/phpspec/phpspec/pull/575#discussion_r21234589"},"pull_request":{"href":"https://api.github.com/repos/phpspec/phpspec/pulls/575"}}},"pull_request":{"url":"https://api.github.com/repos/phpspec/phpspec/pulls/575","id":25328759,"html_url":"https://github.com/phpspec/phpspec/pull/575","diff_url":"https://github.com/phpspec/phpspec/pull/575.diff","patch_url":"https://github.com/phpspec/phpspec/pull/575.patch","issue_url":"https://api.github.com/repos/phpspec/phpspec/issues/575","number":575,"state":"open","locked":false,"title":"[WIP] Introduce symfony service container and testwork extensions","user":{"login":"richardmiller","id":783827,"avatar_url":"https://avatars.githubusercontent.com/u/783827?v=3","gravatar_id":"","url":"https://api.github.com/users/richardmiller","html_url":"https://github.com/richardmiller","followers_url":"https://api.github.com/users/richardmiller/followers","following_url":"https://api.github.com/users/richardmiller/following{/other_user}","gists_url":"https://api.github.com/users/richardmiller/gists{/gist_id}","starred_url":"https://api.github.com/users/richardmiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardmiller/subscriptions","organizations_url":"https://api.github.com/users/richardmiller/orgs","repos_url":"https://api.github.com/users/richardmiller/repos","events_url":"https://api.github.com/users/richardmiller/events{/privacy}","received_events_url":"https://api.github.com/users/richardmiller/received_events","type":"User","site_admin":false},"body":"Starts to replace the custom container with the Symfony one. Its wrapped inside it at the moment with a view to just having the symfony container in a later major version. As a result of trying to maintain b/c its quite hacky at the moment and would require quite a bit of clean up at a later stage.\r\n\r\nSupports both current phpspec extensions and testwork extensions. Started moving some of the core services to testwork extensions. ","created_at":"2014-12-02T09:38:39Z","updated_at":"2014-12-03T14:39:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3a300c42ff995ec470148ed54fe13c448041f58c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/phpspec/phpspec/pulls/575/commits","review_comments_url":"https://api.github.com/repos/phpspec/phpspec/pulls/575/comments","review_comment_url":"https://api.github.com/repos/phpspec/phpspec/pulls/comments/{number}","comments_url":"https://api.github.com/repos/phpspec/phpspec/issues/575/comments","statuses_url":"https://api.github.com/repos/phpspec/phpspec/statuses/295aae39b4a86f0d229f0d5eac2b0b910507b0d7","head":{"label":"richardmiller:symfony-container","ref":"symfony-container","sha":"295aae39b4a86f0d229f0d5eac2b0b910507b0d7","user":{"login":"richardmiller","id":783827,"avatar_url":"https://avatars.githubusercontent.com/u/783827?v=3","gravatar_id":"","url":"https://api.github.com/users/richardmiller","html_url":"https://github.com/richardmiller","followers_url":"https://api.github.com/users/richardmiller/followers","following_url":"https://api.github.com/users/richardmiller/following{/other_user}","gists_url":"https://api.github.com/users/richardmiller/gists{/gist_id}","starred_url":"https://api.github.com/users/richardmiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardmiller/subscriptions","organizations_url":"https://api.github.com/users/richardmiller/orgs","repos_url":"https://api.github.com/users/richardmiller/repos","events_url":"https://api.github.com/users/richardmiller/events{/privacy}","received_events_url":"https://api.github.com/users/richardmiller/received_events","type":"User","site_admin":false},"repo":{"id":11844911,"name":"phpspec","full_name":"richardmiller/phpspec","owner":{"login":"richardmiller","id":783827,"avatar_url":"https://avatars.githubusercontent.com/u/783827?v=3","gravatar_id":"","url":"https://api.github.com/users/richardmiller","html_url":"https://github.com/richardmiller","followers_url":"https://api.github.com/users/richardmiller/followers","following_url":"https://api.github.com/users/richardmiller/following{/other_user}","gists_url":"https://api.github.com/users/richardmiller/gists{/gist_id}","starred_url":"https://api.github.com/users/richardmiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardmiller/subscriptions","organizations_url":"https://api.github.com/users/richardmiller/orgs","repos_url":"https://api.github.com/users/richardmiller/repos","events_url":"https://api.github.com/users/richardmiller/events{/privacy}","received_events_url":"https://api.github.com/users/richardmiller/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/richardmiller/phpspec","description":"SpecBDD Framework for PHP","fork":true,"url":"https://api.github.com/repos/richardmiller/phpspec","forks_url":"https://api.github.com/repos/richardmiller/phpspec/forks","keys_url":"https://api.github.com/repos/richardmiller/phpspec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/richardmiller/phpspec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/richardmiller/phpspec/teams","hooks_url":"https://api.github.com/repos/richardmiller/phpspec/hooks","issue_events_url":"https://api.github.com/repos/richardmiller/phpspec/issues/events{/number}","events_url":"https://api.github.com/repos/richardmiller/phpspec/events","assignees_url":"https://api.github.com/repos/richardmiller/phpspec/assignees{/user}","branches_url":"https://api.github.com/repos/richardmiller/phpspec/branches{/branch}","tags_url":"https://api.github.com/repos/richardmiller/phpspec/tags","blobs_url":"https://api.github.com/repos/richardmiller/phpspec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/richardmiller/phpspec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/richardmiller/phpspec/git/refs{/sha}","trees_url":"https://api.github.com/repos/richardmiller/phpspec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/richardmiller/phpspec/statuses/{sha}","languages_url":"https://api.github.com/repos/richardmiller/phpspec/languages","stargazers_url":"https://api.github.com/repos/richardmiller/phpspec/stargazers","contributors_url":"https://api.github.com/repos/richardmiller/phpspec/contributors","subscribers_url":"https://api.github.com/repos/richardmiller/phpspec/subscribers","subscription_url":"https://api.github.com/repos/richardmiller/phpspec/subscription","commits_url":"https://api.github.com/repos/richardmiller/phpspec/commits{/sha}","git_commits_url":"https://api.github.com/repos/richardmiller/phpspec/git/commits{/sha}","comments_url":"https://api.github.com/repos/richardmiller/phpspec/comments{/number}","issue_comment_url":"https://api.github.com/repos/richardmiller/phpspec/issues/comments/{number}","contents_url":"https://api.github.com/repos/richardmiller/phpspec/contents/{+path}","compare_url":"https://api.github.com/repos/richardmiller/phpspec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/richardmiller/phpspec/merges","archive_url":"https://api.github.com/repos/richardmiller/phpspec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/richardmiller/phpspec/downloads","issues_url":"https://api.github.com/repos/richardmiller/phpspec/issues{/number}","pulls_url":"https://api.github.com/repos/richardmiller/phpspec/pulls{/number}","milestones_url":"https://api.github.com/repos/richardmiller/phpspec/milestones{/number}","notifications_url":"https://api.github.com/repos/richardmiller/phpspec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/richardmiller/phpspec/labels{/name}","releases_url":"https://api.github.com/repos/richardmiller/phpspec/releases{/id}","created_at":"2013-08-02T14:18:04Z","updated_at":"2014-01-03T14:58:03Z","pushed_at":"2014-12-02T09:34:06Z","git_url":"git://github.com/richardmiller/phpspec.git","ssh_url":"git@github.com:richardmiller/phpspec.git","clone_url":"https://github.com/richardmiller/phpspec.git","svn_url":"https://github.com/richardmiller/phpspec","homepage":"http://www.phpspec.net","size":3454,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"phpspec:master","ref":"master","sha":"018247c33801f13c39e26d13fdd0593c7ff1b510","user":{"login":"phpspec","id":416702,"avatar_url":"https://avatars.githubusercontent.com/u/416702?v=3","gravatar_id":"","url":"https://api.github.com/users/phpspec","html_url":"https://github.com/phpspec","followers_url":"https://api.github.com/users/phpspec/followers","following_url":"https://api.github.com/users/phpspec/following{/other_user}","gists_url":"https://api.github.com/users/phpspec/gists{/gist_id}","starred_url":"https://api.github.com/users/phpspec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phpspec/subscriptions","organizations_url":"https://api.github.com/users/phpspec/orgs","repos_url":"https://api.github.com/users/phpspec/repos","events_url":"https://api.github.com/users/phpspec/events{/privacy}","received_events_url":"https://api.github.com/users/phpspec/received_events","type":"Organization","site_admin":false},"repo":{"id":1582219,"name":"phpspec","full_name":"phpspec/phpspec","owner":{"login":"phpspec","id":416702,"avatar_url":"https://avatars.githubusercontent.com/u/416702?v=3","gravatar_id":"","url":"https://api.github.com/users/phpspec","html_url":"https://github.com/phpspec","followers_url":"https://api.github.com/users/phpspec/followers","following_url":"https://api.github.com/users/phpspec/following{/other_user}","gists_url":"https://api.github.com/users/phpspec/gists{/gist_id}","starred_url":"https://api.github.com/users/phpspec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phpspec/subscriptions","organizations_url":"https://api.github.com/users/phpspec/orgs","repos_url":"https://api.github.com/users/phpspec/repos","events_url":"https://api.github.com/users/phpspec/events{/privacy}","received_events_url":"https://api.github.com/users/phpspec/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/phpspec/phpspec","description":"SpecBDD Framework for PHP","fork":false,"url":"https://api.github.com/repos/phpspec/phpspec","forks_url":"https://api.github.com/repos/phpspec/phpspec/forks","keys_url":"https://api.github.com/repos/phpspec/phpspec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phpspec/phpspec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phpspec/phpspec/teams","hooks_url":"https://api.github.com/repos/phpspec/phpspec/hooks","issue_events_url":"https://api.github.com/repos/phpspec/phpspec/issues/events{/number}","events_url":"https://api.github.com/repos/phpspec/phpspec/events","assignees_url":"https://api.github.com/repos/phpspec/phpspec/assignees{/user}","branches_url":"https://api.github.com/repos/phpspec/phpspec/branches{/branch}","tags_url":"https://api.github.com/repos/phpspec/phpspec/tags","blobs_url":"https://api.github.com/repos/phpspec/phpspec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phpspec/phpspec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phpspec/phpspec/git/refs{/sha}","trees_url":"https://api.github.com/repos/phpspec/phpspec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phpspec/phpspec/statuses/{sha}","languages_url":"https://api.github.com/repos/phpspec/phpspec/languages","stargazers_url":"https://api.github.com/repos/phpspec/phpspec/stargazers","contributors_url":"https://api.github.com/repos/phpspec/phpspec/contributors","subscribers_url":"https://api.github.com/repos/phpspec/phpspec/subscribers","subscription_url":"https://api.github.com/repos/phpspec/phpspec/subscription","commits_url":"https://api.github.com/repos/phpspec/phpspec/commits{/sha}","git_commits_url":"https://api.github.com/repos/phpspec/phpspec/git/commits{/sha}","comments_url":"https://api.github.com/repos/phpspec/phpspec/comments{/number}","issue_comment_url":"https://api.github.com/repos/phpspec/phpspec/issues/comments/{number}","contents_url":"https://api.github.com/repos/phpspec/phpspec/contents/{+path}","compare_url":"https://api.github.com/repos/phpspec/phpspec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phpspec/phpspec/merges","archive_url":"https://api.github.com/repos/phpspec/phpspec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phpspec/phpspec/downloads","issues_url":"https://api.github.com/repos/phpspec/phpspec/issues{/number}","pulls_url":"https://api.github.com/repos/phpspec/phpspec/pulls{/number}","milestones_url":"https://api.github.com/repos/phpspec/phpspec/milestones{/number}","notifications_url":"https://api.github.com/repos/phpspec/phpspec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phpspec/phpspec/labels{/name}","releases_url":"https://api.github.com/repos/phpspec/phpspec/releases{/id}","created_at":"2011-04-07T12:48:08Z","updated_at":"2014-12-02T18:51:57Z","pushed_at":"2014-11-30T16:03:04Z","git_url":"git://github.com/phpspec/phpspec.git","ssh_url":"git@github.com:phpspec/phpspec.git","clone_url":"https://github.com/phpspec/phpspec.git","svn_url":"https://github.com/phpspec/phpspec","homepage":"http://www.phpspec.net","size":8512,"stargazers_count":628,"watchers_count":628,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":128,"mirror_url":null,"open_issues_count":47,"forks":128,"open_issues":47,"watchers":628,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/phpspec/phpspec/pulls/575"},"html":{"href":"https://github.com/phpspec/phpspec/pull/575"},"issue":{"href":"https://api.github.com/repos/phpspec/phpspec/issues/575"},"comments":{"href":"https://api.github.com/repos/phpspec/phpspec/issues/575/comments"},"review_comments":{"href":"https://api.github.com/repos/phpspec/phpspec/pulls/575/comments"},"review_comment":{"href":"https://api.github.com/repos/phpspec/phpspec/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/phpspec/phpspec/pulls/575/commits"},"statuses":{"href":"https://api.github.com/repos/phpspec/phpspec/statuses/295aae39b4a86f0d229f0d5eac2b0b910507b0d7"}}}}