GitHub PullRequestReviewCommentEvent at 2014-08-19 06:11:15
Repository: spreads
Actor: jbaiter
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/DIYBookScanner/spreads/pulls/comments/16398505","id":16398505,"diff_hunk":"@@ -547,10 +547,10 @@\n \n       if (workflow.get('pages').length) {\n         var lastPages = _.sortBy(workflow.get('pages').slice(-2), function(page) {\n-          return page.capture_num;\n+          return page.sequence_num;\n         });\n-        evenImage = util.getPageUrl(workflow, lastPages[0].capture_num, 'raw');\n-        oddImage = util.getPageUrl(workflow, lastPages[1].capture_num, 'raw');\n+        evenImage = util.getPageUrl(workflow, lastPages[0].sequence_num, 'raw');","path":"spreadsplug/web/client/src/components/capture.js","position":27,"original_position":27,"commit_id":"13b1355bb28cac5d4521a4d6c14284cf8c731c84","original_commit_id":"13b1355bb28cac5d4521a4d6c14284cf8c731c84","user":{"login":"jbaiter","id":608610,"avatar_url":"https://avatars.githubusercontent.com/u/608610?v=2","gravatar_id":"dd77541b61d10aa5f3304463a5f63427","url":"https://api.github.com/users/jbaiter","html_url":"https://github.com/jbaiter","followers_url":"https://api.github.com/users/jbaiter/followers","following_url":"https://api.github.com/users/jbaiter/following{/other_user}","gists_url":"https://api.github.com/users/jbaiter/gists{/gist_id}","starred_url":"https://api.github.com/users/jbaiter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbaiter/subscriptions","organizations_url":"https://api.github.com/users/jbaiter/orgs","repos_url":"https://api.github.com/users/jbaiter/repos","events_url":"https://api.github.com/users/jbaiter/events{/privacy}","received_events_url":"https://api.github.com/users/jbaiter/received_events","type":"User","site_admin":false},"body":"The usage of `capture_num` over `sequence_num` is deliberate here. The reason being that when we retake a capture, the sequence number does not change, while the capture number does (you can think of it as the unique identifier for pages). Due to this, the browser would not refresh the review for the retaken pictures, since from its perspective nothing has changed. Neither would React btw, due to the way its DOM diffing algorithm works. \r\nSo if there is a bug in the preview image logic, it's not here.","created_at":"2014-08-19T06:11:15Z","updated_at":"2014-08-19T06:11:15Z","html_url":"https://github.com/DIYBookScanner/spreads/pull/118#discussion_r16398505","pull_request_url":"https://api.github.com/repos/DIYBookScanner/spreads/pulls/118","_links":{"self":{"href":"https://api.github.com/repos/DIYBookScanner/spreads/pulls/comments/16398505"},"html":{"href":"https://github.com/DIYBookScanner/spreads/pull/118#discussion_r16398505"},"pull_request":{"href":"https://api.github.com/repos/DIYBookScanner/spreads/pulls/118"}}},"pull_request":{"url":"https://api.github.com/repos/DIYBookScanner/spreads/pulls/118","id":19957046,"html_url":"https://github.com/DIYBookScanner/spreads/pull/118","diff_url":"https://github.com/DIYBookScanner/spreads/pull/118.diff","patch_url":"https://github.com/DIYBookScanner/spreads/pull/118.patch","issue_url":"https://api.github.com/repos/DIYBookScanner/spreads/issues/118","number":118,"state":"open","locked":false,"title":"Stable rc","user":{"login":"duerig","id":879692,"avatar_url":"https://avatars.githubusercontent.com/u/879692?v=2","gravatar_id":"7088bee6d6f3ce35c4e73acfda6b09e7","url":"https://api.github.com/users/duerig","html_url":"https://github.com/duerig","followers_url":"https://api.github.com/users/duerig/followers","following_url":"https://api.github.com/users/duerig/following{/other_user}","gists_url":"https://api.github.com/users/duerig/gists{/gist_id}","starred_url":"https://api.github.com/users/duerig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duerig/subscriptions","organizations_url":"https://api.github.com/users/duerig/orgs","repos_url":"https://api.github.com/users/duerig/repos","events_url":"https://api.github.com/users/duerig/events{/privacy}","received_events_url":"https://api.github.com/users/duerig/received_events","type":"User","site_admin":false},"body":"Fix various crashes in the web interface. Fix capture-replace and most of the numbering inconsistencies.","created_at":"2014-08-19T02:28:39Z","updated_at":"2014-08-19T06:11:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c4c9f437881949b1a691362f26417655c8290cb2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/DIYBookScanner/spreads/pulls/118/commits","review_comments_url":"https://api.github.com/repos/DIYBookScanner/spreads/pulls/118/comments","review_comment_url":"https://api.github.com/repos/DIYBookScanner/spreads/pulls/comments/{number}","comments_url":"https://api.github.com/repos/DIYBookScanner/spreads/issues/118/comments","statuses_url":"https://api.github.com/repos/DIYBookScanner/spreads/statuses/13b1355bb28cac5d4521a4d6c14284cf8c731c84","head":{"label":"duerig:stable-rc","ref":"stable-rc","sha":"13b1355bb28cac5d4521a4d6c14284cf8c731c84","user":{"login":"duerig","id":879692,"avatar_url":"https://avatars.githubusercontent.com/u/879692?v=2","gravatar_id":"7088bee6d6f3ce35c4e73acfda6b09e7","url":"https://api.github.com/users/duerig","html_url":"https://github.com/duerig","followers_url":"https://api.github.com/users/duerig/followers","following_url":"https://api.github.com/users/duerig/following{/other_user}","gists_url":"https://api.github.com/users/duerig/gists{/gist_id}","starred_url":"https://api.github.com/users/duerig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duerig/subscriptions","organizations_url":"https://api.github.com/users/duerig/orgs","repos_url":"https://api.github.com/users/duerig/repos","events_url":"https://api.github.com/users/duerig/events{/privacy}","received_events_url":"https://api.github.com/users/duerig/received_events","type":"User","site_admin":false},"repo":{"id":21295285,"name":"spreads","full_name":"duerig/spreads","owner":{"login":"duerig","id":879692,"avatar_url":"https://avatars.githubusercontent.com/u/879692?v=2","gravatar_id":"7088bee6d6f3ce35c4e73acfda6b09e7","url":"https://api.github.com/users/duerig","html_url":"https://github.com/duerig","followers_url":"https://api.github.com/users/duerig/followers","following_url":"https://api.github.com/users/duerig/following{/other_user}","gists_url":"https://api.github.com/users/duerig/gists{/gist_id}","starred_url":"https://api.github.com/users/duerig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duerig/subscriptions","organizations_url":"https://api.github.com/users/duerig/orgs","repos_url":"https://api.github.com/users/duerig/repos","events_url":"https://api.github.com/users/duerig/events{/privacy}","received_events_url":"https://api.github.com/users/duerig/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/duerig/spreads","description":"Modular workflow assistant for book digitization","fork":true,"url":"https://api.github.com/repos/duerig/spreads","forks_url":"https://api.github.com/repos/duerig/spreads/forks","keys_url":"https://api.github.com/repos/duerig/spreads/keys{/key_id}","collaborators_url":"https://api.github.com/repos/duerig/spreads/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/duerig/spreads/teams","hooks_url":"https://api.github.com/repos/duerig/spreads/hooks","issue_events_url":"https://api.github.com/repos/duerig/spreads/issues/events{/number}","events_url":"https://api.github.com/repos/duerig/spreads/events","assignees_url":"https://api.github.com/repos/duerig/spreads/assignees{/user}","branches_url":"https://api.github.com/repos/duerig/spreads/branches{/branch}","tags_url":"https://api.github.com/repos/duerig/spreads/tags","blobs_url":"https://api.github.com/repos/duerig/spreads/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/duerig/spreads/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/duerig/spreads/git/refs{/sha}","trees_url":"https://api.github.com/repos/duerig/spreads/git/trees{/sha}","statuses_url":"https://api.github.com/repos/duerig/spreads/statuses/{sha}","languages_url":"https://api.github.com/repos/duerig/spreads/languages","stargazers_url":"https://api.github.com/repos/duerig/spreads/stargazers","contributors_url":"https://api.github.com/repos/duerig/spreads/contributors","subscribers_url":"https://api.github.com/repos/duerig/spreads/subscribers","subscription_url":"https://api.github.com/repos/duerig/spreads/subscription","commits_url":"https://api.github.com/repos/duerig/spreads/commits{/sha}","git_commits_url":"https://api.github.com/repos/duerig/spreads/git/commits{/sha}","comments_url":"https://api.github.com/repos/duerig/spreads/comments{/number}","issue_comment_url":"https://api.github.com/repos/duerig/spreads/issues/comments/{number}","contents_url":"https://api.github.com/repos/duerig/spreads/contents/{+path}","compare_url":"https://api.github.com/repos/duerig/spreads/compare/{base}...{head}","merges_url":"https://api.github.com/repos/duerig/spreads/merges","archive_url":"https://api.github.com/repos/duerig/spreads/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/duerig/spreads/downloads","issues_url":"https://api.github.com/repos/duerig/spreads/issues{/number}","pulls_url":"https://api.github.com/repos/duerig/spreads/pulls{/number}","milestones_url":"https://api.github.com/repos/duerig/spreads/milestones{/number}","notifications_url":"https://api.github.com/repos/duerig/spreads/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/duerig/spreads/labels{/name}","releases_url":"https://api.github.com/repos/duerig/spreads/releases{/id}","created_at":"2014-06-28T03:29:59Z","updated_at":"2014-06-24T10:57:15Z","pushed_at":"2014-08-19T02:27:25Z","git_url":"git://github.com/duerig/spreads.git","ssh_url":"git@github.com:duerig/spreads.git","clone_url":"https://github.com/duerig/spreads.git","svn_url":"https://github.com/duerig/spreads","homepage":"","size":21106,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DIYBookScanner:master","ref":"master","sha":"388e7511b69ef5848f37c59d986b0955ca3723b9","user":{"login":"DIYBookScanner","id":6325083,"avatar_url":"https://avatars.githubusercontent.com/u/6325083?v=2","gravatar_id":"da296466ff7653fbacb70e5074dc0594","url":"https://api.github.com/users/DIYBookScanner","html_url":"https://github.com/DIYBookScanner","followers_url":"https://api.github.com/users/DIYBookScanner/followers","following_url":"https://api.github.com/users/DIYBookScanner/following{/other_user}","gists_url":"https://api.github.com/users/DIYBookScanner/gists{/gist_id}","starred_url":"https://api.github.com/users/DIYBookScanner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DIYBookScanner/subscriptions","organizations_url":"https://api.github.com/users/DIYBookScanner/orgs","repos_url":"https://api.github.com/users/DIYBookScanner/repos","events_url":"https://api.github.com/users/DIYBookScanner/events{/privacy}","received_events_url":"https://api.github.com/users/DIYBookScanner/received_events","type":"Organization","site_admin":false},"repo":{"id":10726640,"name":"spreads","full_name":"DIYBookScanner/spreads","owner":{"login":"DIYBookScanner","id":6325083,"avatar_url":"https://avatars.githubusercontent.com/u/6325083?v=2","gravatar_id":"da296466ff7653fbacb70e5074dc0594","url":"https://api.github.com/users/DIYBookScanner","html_url":"https://github.com/DIYBookScanner","followers_url":"https://api.github.com/users/DIYBookScanner/followers","following_url":"https://api.github.com/users/DIYBookScanner/following{/other_user}","gists_url":"https://api.github.com/users/DIYBookScanner/gists{/gist_id}","starred_url":"https://api.github.com/users/DIYBookScanner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DIYBookScanner/subscriptions","organizations_url":"https://api.github.com/users/DIYBookScanner/orgs","repos_url":"https://api.github.com/users/DIYBookScanner/repos","events_url":"https://api.github.com/users/DIYBookScanner/events{/privacy}","received_events_url":"https://api.github.com/users/DIYBookScanner/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DIYBookScanner/spreads","description":"Modular workflow assistant for book digitization","fork":false,"url":"https://api.github.com/repos/DIYBookScanner/spreads","forks_url":"https://api.github.com/repos/DIYBookScanner/spreads/forks","keys_url":"https://api.github.com/repos/DIYBookScanner/spreads/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DIYBookScanner/spreads/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DIYBookScanner/spreads/teams","hooks_url":"https://api.github.com/repos/DIYBookScanner/spreads/hooks","issue_events_url":"https://api.github.com/repos/DIYBookScanner/spreads/issues/events{/number}","events_url":"https://api.github.com/repos/DIYBookScanner/spreads/events","assignees_url":"https://api.github.com/repos/DIYBookScanner/spreads/assignees{/user}","branches_url":"https://api.github.com/repos/DIYBookScanner/spreads/branches{/branch}","tags_url":"https://api.github.com/repos/DIYBookScanner/spreads/tags","blobs_url":"https://api.github.com/repos/DIYBookScanner/spreads/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DIYBookScanner/spreads/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DIYBookScanner/spreads/git/refs{/sha}","trees_url":"https://api.github.com/repos/DIYBookScanner/spreads/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DIYBookScanner/spreads/statuses/{sha}","languages_url":"https://api.github.com/repos/DIYBookScanner/spreads/languages","stargazers_url":"https://api.github.com/repos/DIYBookScanner/spreads/stargazers","contributors_url":"https://api.github.com/repos/DIYBookScanner/spreads/contributors","subscribers_url":"https://api.github.com/repos/DIYBookScanner/spreads/subscribers","subscription_url":"https://api.github.com/repos/DIYBookScanner/spreads/subscription","commits_url":"https://api.github.com/repos/DIYBookScanner/spreads/commits{/sha}","git_commits_url":"https://api.github.com/repos/DIYBookScanner/spreads/git/commits{/sha}","comments_url":"https://api.github.com/repos/DIYBookScanner/spreads/comments{/number}","issue_comment_url":"https://api.github.com/repos/DIYBookScanner/spreads/issues/comments/{number}","contents_url":"https://api.github.com/repos/DIYBookScanner/spreads/contents/{+path}","compare_url":"https://api.github.com/repos/DIYBookScanner/spreads/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DIYBookScanner/spreads/merges","archive_url":"https://api.github.com/repos/DIYBookScanner/spreads/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DIYBookScanner/spreads/downloads","issues_url":"https://api.github.com/repos/DIYBookScanner/spreads/issues{/number}","pulls_url":"https://api.github.com/repos/DIYBookScanner/spreads/pulls{/number}","milestones_url":"https://api.github.com/repos/DIYBookScanner/spreads/milestones{/number}","notifications_url":"https://api.github.com/repos/DIYBookScanner/spreads/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DIYBookScanner/spreads/labels{/name}","releases_url":"https://api.github.com/repos/DIYBookScanner/spreads/releases{/id}","created_at":"2013-06-16T22:41:19Z","updated_at":"2014-08-18T18:16:41Z","pushed_at":"2014-08-18T22:14:34Z","git_url":"git://github.com/DIYBookScanner/spreads.git","ssh_url":"git@github.com:DIYBookScanner/spreads.git","clone_url":"https://github.com/DIYBookScanner/spreads.git","svn_url":"https://github.com/DIYBookScanner/spreads","homepage":"","size":23768,"stargazers_count":23,"watchers_count":23,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":23,"mirror_url":null,"open_issues_count":10,"forks":23,"open_issues":10,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DIYBookScanner/spreads/pulls/118"},"html":{"href":"https://github.com/DIYBookScanner/spreads/pull/118"},"issue":{"href":"https://api.github.com/repos/DIYBookScanner/spreads/issues/118"},"comments":{"href":"https://api.github.com/repos/DIYBookScanner/spreads/issues/118/comments"},"review_comments":{"href":"https://api.github.com/repos/DIYBookScanner/spreads/pulls/118/comments"},"review_comment":{"href":"https://api.github.com/repos/DIYBookScanner/spreads/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/DIYBookScanner/spreads/pulls/118/commits"},"statuses":{"href":"https://api.github.com/repos/DIYBookScanner/spreads/statuses/13b1355bb28cac5d4521a4d6c14284cf8c731c84"}}}}