GitHub PullRequestReviewCommentEvent at 2014-06-20 16:42:04
Repository: flare-engine
Actor: stefanbeller
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/clintbellanger/flare-engine/pulls/comments/14029086","id":14029086,"diff_hunk":"@@ -0,0 +1,23 @@\n+<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n+<application>\n+ <id type=\"desktop\">flare-engine.desktop</id>","path":"distribution/appdata","position":3,"original_position":3,"commit_id":"bde3495f5a19b726a85edc1008675aa48ea55266","original_commit_id":"bde3495f5a19b726a85edc1008675aa48ea55266","user":{"login":"stefanbeller","id":455868,"avatar_url":"https://avatars.githubusercontent.com/u/455868?","gravatar_id":"c7507a91680ee194c6df1db26af9a2e7","url":"https://api.github.com/users/stefanbeller","html_url":"https://github.com/stefanbeller","followers_url":"https://api.github.com/users/stefanbeller/followers","following_url":"https://api.github.com/users/stefanbeller/following{/other_user}","gists_url":"https://api.github.com/users/stefanbeller/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanbeller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanbeller/subscriptions","organizations_url":"https://api.github.com/users/stefanbeller/orgs","repos_url":"https://api.github.com/users/stefanbeller/repos","events_url":"https://api.github.com/users/stefanbeller/events{/privacy}","received_events_url":"https://api.github.com/users/stefanbeller/received_events","type":"User","site_admin":false},"body":"I certainly don't want to reintroduce the desktop file here. Sorry for the mistake.\r\nIn my opinion the engine would not need such an appfile anyway, but each game on its own has an appdata file. This flare engine should not be visible to the end user ideally, i.e. the end user installs flare-game or polymorphable from the package manager and may be even unaware the same engine is driving 2 games.\r\nWhy would they care anyway?","created_at":"2014-06-20T16:42:04Z","updated_at":"2014-06-20T16:42:04Z","html_url":"https://github.com/clintbellanger/flare-engine/pull/1098#discussion_r14029086","pull_request_url":"https://api.github.com/repos/clintbellanger/flare-engine/pulls/1098","_links":{"self":{"href":"https://api.github.com/repos/clintbellanger/flare-engine/pulls/comments/14029086"},"html":{"href":"https://github.com/clintbellanger/flare-engine/pull/1098#discussion_r14029086"},"pull_request":{"href":"https://api.github.com/repos/clintbellanger/flare-engine/pulls/1098"}}},"pull_request":{"url":"https://api.github.com/repos/clintbellanger/flare-engine/pulls/1098","id":17415009,"html_url":"https://github.com/clintbellanger/flare-engine/pull/1098","diff_url":"https://github.com/clintbellanger/flare-engine/pull/1098.diff","patch_url":"https://github.com/clintbellanger/flare-engine/pull/1098.patch","issue_url":"https://api.github.com/repos/clintbellanger/flare-engine/issues/1098","number":1098,"state":"open","title":"Add appdata file for the Fedora Software center","user":{"login":"stefanbeller","id":455868,"avatar_url":"https://avatars.githubusercontent.com/u/455868?","gravatar_id":"c7507a91680ee194c6df1db26af9a2e7","url":"https://api.github.com/users/stefanbeller","html_url":"https://github.com/stefanbeller","followers_url":"https://api.github.com/users/stefanbeller/followers","following_url":"https://api.github.com/users/stefanbeller/following{/other_user}","gists_url":"https://api.github.com/users/stefanbeller/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanbeller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanbeller/subscriptions","organizations_url":"https://api.github.com/users/stefanbeller/orgs","repos_url":"https://api.github.com/users/stefanbeller/repos","events_url":"https://api.github.com/users/stefanbeller/events{/privacy}","received_events_url":"https://api.github.com/users/stefanbeller/received_events","type":"User","site_admin":false},"body":"Solves #960\r\n\r\n@Ablu Would such an appdata file be sufficient?\r\n\r\nAnyway we should have our own quality screenshots in our wiki, not linking to tiled.","created_at":"2014-06-20T16:32:26Z","updated_at":"2014-06-20T16:42:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a816314314b6ded6fd7bbda252b3d81be0b53b76","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/clintbellanger/flare-engine/pulls/1098/commits","review_comments_url":"https://api.github.com/repos/clintbellanger/flare-engine/pulls/1098/comments","review_comment_url":"https://api.github.com/repos/clintbellanger/flare-engine/pulls/comments/{number}","comments_url":"https://api.github.com/repos/clintbellanger/flare-engine/issues/1098/comments","statuses_url":"https://api.github.com/repos/clintbellanger/flare-engine/statuses/bde3495f5a19b726a85edc1008675aa48ea55266","head":{"label":"stefanbeller:appdata","ref":"appdata","sha":"bde3495f5a19b726a85edc1008675aa48ea55266","user":{"login":"stefanbeller","id":455868,"avatar_url":"https://avatars.githubusercontent.com/u/455868?","gravatar_id":"c7507a91680ee194c6df1db26af9a2e7","url":"https://api.github.com/users/stefanbeller","html_url":"https://github.com/stefanbeller","followers_url":"https://api.github.com/users/stefanbeller/followers","following_url":"https://api.github.com/users/stefanbeller/following{/other_user}","gists_url":"https://api.github.com/users/stefanbeller/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanbeller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanbeller/subscriptions","organizations_url":"https://api.github.com/users/stefanbeller/orgs","repos_url":"https://api.github.com/users/stefanbeller/repos","events_url":"https://api.github.com/users/stefanbeller/events{/privacy}","received_events_url":"https://api.github.com/users/stefanbeller/received_events","type":"User","site_admin":false},"repo":{"id":5851949,"name":"flare-engine","full_name":"stefanbeller/flare-engine","owner":{"login":"stefanbeller","id":455868,"avatar_url":"https://avatars.githubusercontent.com/u/455868?","gravatar_id":"c7507a91680ee194c6df1db26af9a2e7","url":"https://api.github.com/users/stefanbeller","html_url":"https://github.com/stefanbeller","followers_url":"https://api.github.com/users/stefanbeller/followers","following_url":"https://api.github.com/users/stefanbeller/following{/other_user}","gists_url":"https://api.github.com/users/stefanbeller/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanbeller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanbeller/subscriptions","organizations_url":"https://api.github.com/users/stefanbeller/orgs","repos_url":"https://api.github.com/users/stefanbeller/repos","events_url":"https://api.github.com/users/stefanbeller/events{/privacy}","received_events_url":"https://api.github.com/users/stefanbeller/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stefanbeller/flare-engine","description":"Free/Libre Action Roleplaying Engine (engine only)","fork":true,"url":"https://api.github.com/repos/stefanbeller/flare-engine","forks_url":"https://api.github.com/repos/stefanbeller/flare-engine/forks","keys_url":"https://api.github.com/repos/stefanbeller/flare-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stefanbeller/flare-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stefanbeller/flare-engine/teams","hooks_url":"https://api.github.com/repos/stefanbeller/flare-engine/hooks","issue_events_url":"https://api.github.com/repos/stefanbeller/flare-engine/issues/events{/number}","events_url":"https://api.github.com/repos/stefanbeller/flare-engine/events","assignees_url":"https://api.github.com/repos/stefanbeller/flare-engine/assignees{/user}","branches_url":"https://api.github.com/repos/stefanbeller/flare-engine/branches{/branch}","tags_url":"https://api.github.com/repos/stefanbeller/flare-engine/tags","blobs_url":"https://api.github.com/repos/stefanbeller/flare-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stefanbeller/flare-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stefanbeller/flare-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/stefanbeller/flare-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stefanbeller/flare-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/stefanbeller/flare-engine/languages","stargazers_url":"https://api.github.com/repos/stefanbeller/flare-engine/stargazers","contributors_url":"https://api.github.com/repos/stefanbeller/flare-engine/contributors","subscribers_url":"https://api.github.com/repos/stefanbeller/flare-engine/subscribers","subscription_url":"https://api.github.com/repos/stefanbeller/flare-engine/subscription","commits_url":"https://api.github.com/repos/stefanbeller/flare-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/stefanbeller/flare-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/stefanbeller/flare-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/stefanbeller/flare-engine/issues/comments/{number}","contents_url":"https://api.github.com/repos/stefanbeller/flare-engine/contents/{+path}","compare_url":"https://api.github.com/repos/stefanbeller/flare-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stefanbeller/flare-engine/merges","archive_url":"https://api.github.com/repos/stefanbeller/flare-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stefanbeller/flare-engine/downloads","issues_url":"https://api.github.com/repos/stefanbeller/flare-engine/issues{/number}","pulls_url":"https://api.github.com/repos/stefanbeller/flare-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/stefanbeller/flare-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/stefanbeller/flare-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stefanbeller/flare-engine/labels{/name}","releases_url":"https://api.github.com/repos/stefanbeller/flare-engine/releases{/id}","created_at":"2012-09-18T05:43:40Z","updated_at":"2014-06-20T16:36:30Z","pushed_at":"2014-06-20T16:36:30Z","git_url":"git://github.com/stefanbeller/flare-engine.git","ssh_url":"git@github.com:stefanbeller/flare-engine.git","clone_url":"https://github.com/stefanbeller/flare-engine.git","svn_url":"https://github.com/stefanbeller/flare-engine","homepage":null,"size":12482,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"clintbellanger:master","ref":"master","sha":"4312a94b5b7672209713d07adcabf3769ce90143","user":{"login":"clintbellanger","id":689593,"avatar_url":"https://avatars.githubusercontent.com/u/689593?","gravatar_id":"6c99d9948611e18b8f0b3df5c35bd3b5","url":"https://api.github.com/users/clintbellanger","html_url":"https://github.com/clintbellanger","followers_url":"https://api.github.com/users/clintbellanger/followers","following_url":"https://api.github.com/users/clintbellanger/following{/other_user}","gists_url":"https://api.github.com/users/clintbellanger/gists{/gist_id}","starred_url":"https://api.github.com/users/clintbellanger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clintbellanger/subscriptions","organizations_url":"https://api.github.com/users/clintbellanger/orgs","repos_url":"https://api.github.com/users/clintbellanger/repos","events_url":"https://api.github.com/users/clintbellanger/events{/privacy}","received_events_url":"https://api.github.com/users/clintbellanger/received_events","type":"User","site_admin":false},"repo":{"id":5846904,"name":"flare-engine","full_name":"clintbellanger/flare-engine","owner":{"login":"clintbellanger","id":689593,"avatar_url":"https://avatars.githubusercontent.com/u/689593?","gravatar_id":"6c99d9948611e18b8f0b3df5c35bd3b5","url":"https://api.github.com/users/clintbellanger","html_url":"https://github.com/clintbellanger","followers_url":"https://api.github.com/users/clintbellanger/followers","following_url":"https://api.github.com/users/clintbellanger/following{/other_user}","gists_url":"https://api.github.com/users/clintbellanger/gists{/gist_id}","starred_url":"https://api.github.com/users/clintbellanger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clintbellanger/subscriptions","organizations_url":"https://api.github.com/users/clintbellanger/orgs","repos_url":"https://api.github.com/users/clintbellanger/repos","events_url":"https://api.github.com/users/clintbellanger/events{/privacy}","received_events_url":"https://api.github.com/users/clintbellanger/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/clintbellanger/flare-engine","description":"Free/Libre Action Roleplaying Engine (engine only)","fork":false,"url":"https://api.github.com/repos/clintbellanger/flare-engine","forks_url":"https://api.github.com/repos/clintbellanger/flare-engine/forks","keys_url":"https://api.github.com/repos/clintbellanger/flare-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clintbellanger/flare-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clintbellanger/flare-engine/teams","hooks_url":"https://api.github.com/repos/clintbellanger/flare-engine/hooks","issue_events_url":"https://api.github.com/repos/clintbellanger/flare-engine/issues/events{/number}","events_url":"https://api.github.com/repos/clintbellanger/flare-engine/events","assignees_url":"https://api.github.com/repos/clintbellanger/flare-engine/assignees{/user}","branches_url":"https://api.github.com/repos/clintbellanger/flare-engine/branches{/branch}","tags_url":"https://api.github.com/repos/clintbellanger/flare-engine/tags","blobs_url":"https://api.github.com/repos/clintbellanger/flare-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clintbellanger/flare-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clintbellanger/flare-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/clintbellanger/flare-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clintbellanger/flare-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/clintbellanger/flare-engine/languages","stargazers_url":"https://api.github.com/repos/clintbellanger/flare-engine/stargazers","contributors_url":"https://api.github.com/repos/clintbellanger/flare-engine/contributors","subscribers_url":"https://api.github.com/repos/clintbellanger/flare-engine/subscribers","subscription_url":"https://api.github.com/repos/clintbellanger/flare-engine/subscription","commits_url":"https://api.github.com/repos/clintbellanger/flare-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/clintbellanger/flare-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/clintbellanger/flare-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/clintbellanger/flare-engine/issues/comments/{number}","contents_url":"https://api.github.com/repos/clintbellanger/flare-engine/contents/{+path}","compare_url":"https://api.github.com/repos/clintbellanger/flare-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clintbellanger/flare-engine/merges","archive_url":"https://api.github.com/repos/clintbellanger/flare-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clintbellanger/flare-engine/downloads","issues_url":"https://api.github.com/repos/clintbellanger/flare-engine/issues{/number}","pulls_url":"https://api.github.com/repos/clintbellanger/flare-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/clintbellanger/flare-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/clintbellanger/flare-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clintbellanger/flare-engine/labels{/name}","releases_url":"https://api.github.com/repos/clintbellanger/flare-engine/releases{/id}","created_at":"2012-09-17T20:30:02Z","updated_at":"2014-06-20T16:30:11Z","pushed_at":"2014-06-20T16:30:11Z","git_url":"git://github.com/clintbellanger/flare-engine.git","ssh_url":"git@github.com:clintbellanger/flare-engine.git","clone_url":"https://github.com/clintbellanger/flare-engine.git","svn_url":"https://github.com/clintbellanger/flare-engine","homepage":null,"size":17800,"stargazers_count":212,"watchers_count":212,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":73,"mirror_url":null,"open_issues_count":59,"forks":73,"open_issues":59,"watchers":212,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/clintbellanger/flare-engine/pulls/1098"},"html":{"href":"https://github.com/clintbellanger/flare-engine/pull/1098"},"issue":{"href":"https://api.github.com/repos/clintbellanger/flare-engine/issues/1098"},"comments":{"href":"https://api.github.com/repos/clintbellanger/flare-engine/issues/1098/comments"},"review_comments":{"href":"https://api.github.com/repos/clintbellanger/flare-engine/pulls/1098/comments"},"review_comment":{"href":"https://api.github.com/repos/clintbellanger/flare-engine/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/clintbellanger/flare-engine/pulls/1098/commits"},"statuses":{"href":"https://api.github.com/repos/clintbellanger/flare-engine/statuses/bde3495f5a19b726a85edc1008675aa48ea55266"}}}}