GitHub PullRequestEvent at 2014-12-18 03:45:16
Repository: Config-ENV
Actor: issm
Payload: {"action":"opened","number":6,"pull_request":{"url":"https://api.github.com/repos/cho45/Config-ENV/pulls/6","id":26275956,"html_url":"https://github.com/cho45/Config-ENV/pull/6","diff_url":"https://github.com/cho45/Config-ENV/pull/6.diff","patch_url":"https://github.com/cho45/Config-ENV/pull/6.patch","issue_url":"https://api.github.com/repos/cho45/Config-ENV/issues/6","number":6,"state":"open","locked":false,"title":"Fix error returning in `load` and skipping test `perlcritic`","user":{"login":"issm","id":94762,"avatar_url":"https://avatars.githubusercontent.com/u/94762?v=3","gravatar_id":"","url":"https://api.github.com/users/issm","html_url":"https://github.com/issm","followers_url":"https://api.github.com/users/issm/followers","following_url":"https://api.github.com/users/issm/following{/other_user}","gists_url":"https://api.github.com/users/issm/gists{/gist_id}","starred_url":"https://api.github.com/users/issm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/issm/subscriptions","organizations_url":"https://api.github.com/users/issm/orgs","repos_url":"https://api.github.com/users/issm/repos","events_url":"https://api.github.com/users/issm/events{/privacy}","received_events_url":"https://api.github.com/users/issm/received_events","type":"User","site_admin":false},"body":"I fixed following 2 issues:\r\n\r\n* fix a returning error in `load`\r\n* fix skipping test `perlcritic`\r\n\r\n\r\n**fix a returning error in `load`**\r\n\r\nI failed install/test in `cpanm Config::ENV` and `perl Build.PL && ./Build && .,/Build test` on Mac OSX (10.9).\r\n\r\nSo, I fixed for successful install/test. (maybe, also OK in linux)\r\n\r\n\r\n**fix skipping test `perlcritic`**\r\n\r\nWithout Test::Perl::Critic, test fails as following:\r\n\r\n```\r\n$ perl Build.PL && ./Build && ./Build test\r\n...\r\nxt/98_perlcritic.t .. Can't locate Test/Perl/Critic.pm in @INC (@INC contains: /home/travis/build/issm/Config-ENV/blib/lib /home/travis/build/issm/Config-ENV/blib/arch /home/travis/build/issm/Config-ENV/_build/lib /home/travis/perl5/perlbrew/perls/5.14/lib/site_pe\r\nrl/5.14.4/x86_64-linux /home/travis/perl5/perlbrew/perls/5.14/lib/site_perl/5.14.4 /home/travis/perl5/perlbrew/perls/5.14/lib/5.14.4/x86_64-linux /home/travis/perl5/perlbrew/perls/5.14/lib/5.14.4 .) at xt/98_perlcritic.t line 3.\r\nBEGIN failed--compilation aborted at xt/98_perlcritic.t line 3.\r\nxt/98_perlcritic.t .. Dubious, test returned 2 (wstat 512, 0x200)\r\nNo subtests run\r\nxt/podspell.t ....... skipped: Test::Spelling is not installed.\r\n```\r\n\r\nSo, I fixed to be able to skip.\r\n\r\n\r\n**Why 2 issues in 1 PR?**\r\n\r\nI wanted to send these PRs separately, but CI fails due to an issue of each other :)\r\n\r\n* https://travis-ci.org/issm/Config-ENV/builds/44409177\r\n* https://travis-ci.org/issm/Config-ENV/builds/44410028\r\n","created_at":"2014-12-18T03:45:16Z","updated_at":"2014-12-18T03:45:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cho45/Config-ENV/pulls/6/commits","review_comments_url":"https://api.github.com/repos/cho45/Config-ENV/pulls/6/comments","review_comment_url":"https://api.github.com/repos/cho45/Config-ENV/pulls/comments/{number}","comments_url":"https://api.github.com/repos/cho45/Config-ENV/issues/6/comments","statuses_url":"https://api.github.com/repos/cho45/Config-ENV/statuses/55afb0851482092e278c5b6cf1fc307153e8a988","head":{"label":"issm:fix-test-perlcritic-skipping-and-load-error","ref":"fix-test-perlcritic-skipping-and-load-error","sha":"55afb0851482092e278c5b6cf1fc307153e8a988","user":{"login":"issm","id":94762,"avatar_url":"https://avatars.githubusercontent.com/u/94762?v=3","gravatar_id":"","url":"https://api.github.com/users/issm","html_url":"https://github.com/issm","followers_url":"https://api.github.com/users/issm/followers","following_url":"https://api.github.com/users/issm/following{/other_user}","gists_url":"https://api.github.com/users/issm/gists{/gist_id}","starred_url":"https://api.github.com/users/issm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/issm/subscriptions","organizations_url":"https://api.github.com/users/issm/orgs","repos_url":"https://api.github.com/users/issm/repos","events_url":"https://api.github.com/users/issm/events{/privacy}","received_events_url":"https://api.github.com/users/issm/received_events","type":"User","site_admin":false},"repo":{"id":28164985,"name":"Config-ENV","full_name":"issm/Config-ENV","owner":{"login":"issm","id":94762,"avatar_url":"https://avatars.githubusercontent.com/u/94762?v=3","gravatar_id":"","url":"https://api.github.com/users/issm","html_url":"https://github.com/issm","followers_url":"https://api.github.com/users/issm/followers","following_url":"https://api.github.com/users/issm/following{/other_user}","gists_url":"https://api.github.com/users/issm/gists{/gist_id}","starred_url":"https://api.github.com/users/issm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/issm/subscriptions","organizations_url":"https://api.github.com/users/issm/orgs","repos_url":"https://api.github.com/users/issm/repos","events_url":"https://api.github.com/users/issm/events{/privacy}","received_events_url":"https://api.github.com/users/issm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/issm/Config-ENV","description":"","fork":true,"url":"https://api.github.com/repos/issm/Config-ENV","forks_url":"https://api.github.com/repos/issm/Config-ENV/forks","keys_url":"https://api.github.com/repos/issm/Config-ENV/keys{/key_id}","collaborators_url":"https://api.github.com/repos/issm/Config-ENV/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/issm/Config-ENV/teams","hooks_url":"https://api.github.com/repos/issm/Config-ENV/hooks","issue_events_url":"https://api.github.com/repos/issm/Config-ENV/issues/events{/number}","events_url":"https://api.github.com/repos/issm/Config-ENV/events","assignees_url":"https://api.github.com/repos/issm/Config-ENV/assignees{/user}","branches_url":"https://api.github.com/repos/issm/Config-ENV/branches{/branch}","tags_url":"https://api.github.com/repos/issm/Config-ENV/tags","blobs_url":"https://api.github.com/repos/issm/Config-ENV/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/issm/Config-ENV/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/issm/Config-ENV/git/refs{/sha}","trees_url":"https://api.github.com/repos/issm/Config-ENV/git/trees{/sha}","statuses_url":"https://api.github.com/repos/issm/Config-ENV/statuses/{sha}","languages_url":"https://api.github.com/repos/issm/Config-ENV/languages","stargazers_url":"https://api.github.com/repos/issm/Config-ENV/stargazers","contributors_url":"https://api.github.com/repos/issm/Config-ENV/contributors","subscribers_url":"https://api.github.com/repos/issm/Config-ENV/subscribers","subscription_url":"https://api.github.com/repos/issm/Config-ENV/subscription","commits_url":"https://api.github.com/repos/issm/Config-ENV/commits{/sha}","git_commits_url":"https://api.github.com/repos/issm/Config-ENV/git/commits{/sha}","comments_url":"https://api.github.com/repos/issm/Config-ENV/comments{/number}","issue_comment_url":"https://api.github.com/repos/issm/Config-ENV/issues/comments/{number}","contents_url":"https://api.github.com/repos/issm/Config-ENV/contents/{+path}","compare_url":"https://api.github.com/repos/issm/Config-ENV/compare/{base}...{head}","merges_url":"https://api.github.com/repos/issm/Config-ENV/merges","archive_url":"https://api.github.com/repos/issm/Config-ENV/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/issm/Config-ENV/downloads","issues_url":"https://api.github.com/repos/issm/Config-ENV/issues{/number}","pulls_url":"https://api.github.com/repos/issm/Config-ENV/pulls{/number}","milestones_url":"https://api.github.com/repos/issm/Config-ENV/milestones{/number}","notifications_url":"https://api.github.com/repos/issm/Config-ENV/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/issm/Config-ENV/labels{/name}","releases_url":"https://api.github.com/repos/issm/Config-ENV/releases{/id}","created_at":"2014-12-18T02:27:40Z","updated_at":"2014-12-18T02:27:42Z","pushed_at":"2014-12-18T03:09:35Z","git_url":"git://github.com/issm/Config-ENV.git","ssh_url":"git@github.com:issm/Config-ENV.git","clone_url":"https://github.com/issm/Config-ENV.git","svn_url":"https://github.com/issm/Config-ENV","homepage":"","size":142,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cho45:master","ref":"master","sha":"af3e584293997c35a7ca6a273327d8f18da8d1d3","user":{"login":"cho45","id":3092,"avatar_url":"https://avatars.githubusercontent.com/u/3092?v=3","gravatar_id":"","url":"https://api.github.com/users/cho45","html_url":"https://github.com/cho45","followers_url":"https://api.github.com/users/cho45/followers","following_url":"https://api.github.com/users/cho45/following{/other_user}","gists_url":"https://api.github.com/users/cho45/gists{/gist_id}","starred_url":"https://api.github.com/users/cho45/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cho45/subscriptions","organizations_url":"https://api.github.com/users/cho45/orgs","repos_url":"https://api.github.com/users/cho45/repos","events_url":"https://api.github.com/users/cho45/events{/privacy}","received_events_url":"https://api.github.com/users/cho45/received_events","type":"User","site_admin":false},"repo":{"id":2104983,"name":"Config-ENV","full_name":"cho45/Config-ENV","owner":{"login":"cho45","id":3092,"avatar_url":"https://avatars.githubusercontent.com/u/3092?v=3","gravatar_id":"","url":"https://api.github.com/users/cho45","html_url":"https://github.com/cho45","followers_url":"https://api.github.com/users/cho45/followers","following_url":"https://api.github.com/users/cho45/following{/other_user}","gists_url":"https://api.github.com/users/cho45/gists{/gist_id}","starred_url":"https://api.github.com/users/cho45/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cho45/subscriptions","organizations_url":"https://api.github.com/users/cho45/orgs","repos_url":"https://api.github.com/users/cho45/repos","events_url":"https://api.github.com/users/cho45/events{/privacy}","received_events_url":"https://api.github.com/users/cho45/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cho45/Config-ENV","description":"","fork":false,"url":"https://api.github.com/repos/cho45/Config-ENV","forks_url":"https://api.github.com/repos/cho45/Config-ENV/forks","keys_url":"https://api.github.com/repos/cho45/Config-ENV/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cho45/Config-ENV/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cho45/Config-ENV/teams","hooks_url":"https://api.github.com/repos/cho45/Config-ENV/hooks","issue_events_url":"https://api.github.com/repos/cho45/Config-ENV/issues/events{/number}","events_url":"https://api.github.com/repos/cho45/Config-ENV/events","assignees_url":"https://api.github.com/repos/cho45/Config-ENV/assignees{/user}","branches_url":"https://api.github.com/repos/cho45/Config-ENV/branches{/branch}","tags_url":"https://api.github.com/repos/cho45/Config-ENV/tags","blobs_url":"https://api.github.com/repos/cho45/Config-ENV/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cho45/Config-ENV/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cho45/Config-ENV/git/refs{/sha}","trees_url":"https://api.github.com/repos/cho45/Config-ENV/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cho45/Config-ENV/statuses/{sha}","languages_url":"https://api.github.com/repos/cho45/Config-ENV/languages","stargazers_url":"https://api.github.com/repos/cho45/Config-ENV/stargazers","contributors_url":"https://api.github.com/repos/cho45/Config-ENV/contributors","subscribers_url":"https://api.github.com/repos/cho45/Config-ENV/subscribers","subscription_url":"https://api.github.com/repos/cho45/Config-ENV/subscription","commits_url":"https://api.github.com/repos/cho45/Config-ENV/commits{/sha}","git_commits_url":"https://api.github.com/repos/cho45/Config-ENV/git/commits{/sha}","comments_url":"https://api.github.com/repos/cho45/Config-ENV/comments{/number}","issue_comment_url":"https://api.github.com/repos/cho45/Config-ENV/issues/comments/{number}","contents_url":"https://api.github.com/repos/cho45/Config-ENV/contents/{+path}","compare_url":"https://api.github.com/repos/cho45/Config-ENV/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cho45/Config-ENV/merges","archive_url":"https://api.github.com/repos/cho45/Config-ENV/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cho45/Config-ENV/downloads","issues_url":"https://api.github.com/repos/cho45/Config-ENV/issues{/number}","pulls_url":"https://api.github.com/repos/cho45/Config-ENV/pulls{/number}","milestones_url":"https://api.github.com/repos/cho45/Config-ENV/milestones{/number}","notifications_url":"https://api.github.com/repos/cho45/Config-ENV/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cho45/Config-ENV/labels{/name}","releases_url":"https://api.github.com/repos/cho45/Config-ENV/releases{/id}","created_at":"2011-07-26T04:02:03Z","updated_at":"2014-09-08T22:53:13Z","pushed_at":"2013-05-31T07:10:49Z","git_url":"git://github.com/cho45/Config-ENV.git","ssh_url":"git@github.com:cho45/Config-ENV.git","clone_url":"https://github.com/cho45/Config-ENV.git","svn_url":"https://github.com/cho45/Config-ENV","homepage":"","size":170,"stargazers_count":5,"watchers_count":5,"language":"Perl","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":3,"forks":5,"open_issues":3,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cho45/Config-ENV/pulls/6"},"html":{"href":"https://github.com/cho45/Config-ENV/pull/6"},"issue":{"href":"https://api.github.com/repos/cho45/Config-ENV/issues/6"},"comments":{"href":"https://api.github.com/repos/cho45/Config-ENV/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/cho45/Config-ENV/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/cho45/Config-ENV/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/cho45/Config-ENV/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/cho45/Config-ENV/statuses/55afb0851482092e278c5b6cf1fc307153e8a988"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":10,"deletions":3,"changed_files":3}}