GitHub PullRequestEvent at 2014-06-04 16:22:40
Repository: Easy-Digital-Downloads
Actor: somewebmedia
Payload: {"action":"opened","number":2346,"pull_request":{"url":"https://api.github.com/repos/easydigitaldownloads/Easy-Digital-Downloads/pulls/2346","id":16718469,"html_url":"https://github.com/easydigitaldownloads/Easy-Digital-Downloads/pull/2346","diff_url":"https://github.com/easydigitaldownloads/Easy-Digital-Downloads/pull/2346.diff","patch_url":"https://github.com/easydigitaldownloads/Easy-Digital-Downloads/pull/2346.patch","issue_url":"https://api.github.com/repos/easydigitaldownloads/Easy-Digital-Downloads/issues/2346","number":2346,"state":"open","title":"edd_ajax_apply_discount fix","user":{"login":"somewebmedia","id":2186159,"avatar_url":"https://avatars.githubusercontent.com/u/2186159?","gravatar_id":null,"url":"https://api.github.com/users/somewebmedia","html_url":"https://github.com/somewebmedia","followers_url":"https://api.github.com/users/somewebmedia/followers","following_url":"https://api.github.com/users/somewebmedia/following{/other_user}","gists_url":"https://api.github.com/users/somewebmedia/gists{/gist_id}","starred_url":"https://api.github.com/users/somewebmedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/somewebmedia/subscriptions","organizations_url":"https://api.github.com/users/somewebmedia/orgs","repos_url":"https://api.github.com/users/somewebmedia/repos","events_url":"https://api.github.com/users/somewebmedia/events{/privacy}","received_events_url":"https://api.github.com/users/somewebmedia/received_events","type":"User","site_admin":false},"body":"When calling 'edd_ajax_apply_discount' via ajax, response fails with the following messages:\r\n\r\nNotice:  Undefined variable: key in ..\\easy-digital-downloads\\includes\\discount-functions.php on line 761\r\nNotice:  Undefined variable: value in ...\\easy-digital-downloads\\includes\\discount-functions.php on line 762\r\n\r\nIn ajax-function.php on line 164 there is a call to <code>edd_is_discount_valid()</code> without passing a user. That function later calls <code>edd_is_discount_used()</code> which failed because no user is sent.\r\n\r\nP.S. Sorry for not creating issue first, I just read the guidelines, next time I will ;)","created_at":"2014-06-04T16:22:39Z","updated_at":"2014-06-04T16:22:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/easydigitaldownloads/Easy-Digital-Downloads/pulls/2346/commits","review_comments_url":"https://api.github.com/repos/easydigitaldownloads/Easy-Digital-Downloads/pulls/2346/comments","review_comment_url":"https://api.github.com/repos/easydigitaldownloads/Easy-Digital-Downloads/pulls/comments/{number}","comments_url":"https://api.github.com/repos/easydigitaldownloads/Easy-Digital-Downloads/issues/2346/comments","statuses_url":"https://api.github.com/repos/easydigitaldownloads/Easy-Digital-Downloads/statuses/283132735b1390d310be1357ebdce4aa0a2dea8a","head":{"label":"somewebmedia:master","ref":"master","sha":"283132735b1390d310be1357ebdce4aa0a2dea8a","user":{"login":"somewebmedia","id":2186159,"avatar_url":"https://avatars.githubusercontent.com/u/2186159?","gravatar_id":null,"url":"https://api.github.com/users/somewebmedia","html_url":"https://github.com/somewebmedia","followers_url":"https://api.github.com/users/somewebmedia/followers","following_url":"https://api.github.com/users/somewebmedia/following{/other_user}","gists_url":"https://api.github.com/users/somewebmedia/gists{/gist_id}","starred_url":"https://api.github.com/users/somewebmedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/somewebmedia/subscriptions","organizations_url":"https://api.github.com/users/somewebmedia/orgs","repos_url":"https://api.github.com/users/somewebmedia/repos","events_url":"https://api.github.com/users/somewebmedia/events{/privacy}","received_events_url":"https://api.github.com/users/somewebmedia/received_events","type":"User","site_admin":false},"repo":{"id":20490048,"name":"Easy-Digital-Downloads","full_name":"somewebmedia/Easy-Digital-Downloads","owner":{"login":"somewebmedia","id":2186159,"avatar_url":"https://avatars.githubusercontent.com/u/2186159?","gravatar_id":null,"url":"https://api.github.com/users/somewebmedia","html_url":"https://github.com/somewebmedia","followers_url":"https://api.github.com/users/somewebmedia/followers","following_url":"https://api.github.com/users/somewebmedia/following{/other_user}","gists_url":"https://api.github.com/users/somewebmedia/gists{/gist_id}","starred_url":"https://api.github.com/users/somewebmedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/somewebmedia/subscriptions","organizations_url":"https://api.github.com/users/somewebmedia/orgs","repos_url":"https://api.github.com/users/somewebmedia/repos","events_url":"https://api.github.com/users/somewebmedia/events{/privacy}","received_events_url":"https://api.github.com/users/somewebmedia/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/somewebmedia/Easy-Digital-Downloads","description":"Sell digital downloads through WordPress","fork":true,"url":"https://api.github.com/repos/somewebmedia/Easy-Digital-Downloads","forks_url":"https://api.github.com/repos/somewebmedia/Easy-Digital-Downloads/forks","keys_url":"https://api.github.com/repos/somewebmedia/Easy-Digital-Downloads/keys{/key_id}","collaborators_url":"https://api.github.com/repos/somewebmedia/Easy-Digital-Downloads/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/somewebmedia/Easy-Digital-Downloads/teams","hooks_url":"https://api.github.com/repos/somewebmedia/Easy-Digital-Downloads/hooks","issue_events_url":"https://api.github.com/repos/somewebmedia/Easy-Digital-Downloads/issues/events{/number}","events_url":"https://api.github.com/repos/somewebmedia/Easy-Digital-Downloads/events","assignees_url":"https://api.github.com/repos/somewebmedia/Easy-Digital-Downloads/assignees{/user}","branches_url":"https://api.github.com/repos/somewebmedia/Easy-Digital-Downloads/branches{/branch}","tags_url":"https://api.github.com/repos/somewebmedia/Easy-Digital-Downloads/tags","blobs_url":"https://api.github.com/repos/somewebmedia/Easy-Digital-Downloads/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/somewebmedia/Easy-Digital-Downloads/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/somewebmedia/Easy-Digital-Downloads/git/refs{/sha}","trees_url":"https://api.github.com/repos/somewebmedia/Easy-Digital-Downloads/git/trees{/sha}","statuses_url":"https://api.github.com/repos/somewebmedia/Easy-Digital-Downloads/statuses/{sha}","languages_url":"https://api.github.com/repos/somewebmedia/Easy-Digital-Downloads/languages","stargazers_url":"https://api.github.com/repos/somewebmedia/Easy-Digital-Downloads/stargazers","contributors_url":"https://api.github.com/repos/somewebmedia/Easy-Digital-Downloads/contributors","subscribers_url":"https://api.github.com/repos/somewebmedia/Easy-Digital-Downloads/subscribers","subscription_url":"https://api.github.com/repos/somewebmedia/Easy-Digital-Downloads/subscription","commits_url":"https://api.github.com/repos/somewebmedia/Easy-Digital-Downloads/commits{/sha}","git_commits_url":"https://api.github.com/repos/somewebmedia/Easy-Digital-Downloads/git/commits{/sha}","comments_url":"https://api.github.com/repos/somewebmedia/Easy-Digital-Downloads/comments{/number}","issue_comment_url":"https://api.github.com/repos/somewebmedia/Easy-Digital-Downloads/issues/comments/{number}","contents_url":"https://api.github.com/repos/somewebmedia/Easy-Digital-Downloads/contents/{+path}","compare_url":"https://api.github.com/repos/somewebmedia/Easy-Digital-Downloads/compare/{base}...{head}","merges_url":"https://api.github.com/repos/somewebmedia/Easy-Digital-Downloads/merges","archive_url":"https://api.github.com/repos/somewebmedia/Easy-Digital-Downloads/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/somewebmedia/Easy-Digital-Downloads/downloads","issues_url":"https://api.github.com/repos/somewebmedia/Easy-Digital-Downloads/issues{/number}","pulls_url":"https://api.github.com/repos/somewebmedia/Easy-Digital-Downloads/pulls{/number}","milestones_url":"https://api.github.com/repos/somewebmedia/Easy-Digital-Downloads/milestones{/number}","notifications_url":"https://api.github.com/repos/somewebmedia/Easy-Digital-Downloads/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/somewebmedia/Easy-Digital-Downloads/labels{/name}","releases_url":"https://api.github.com/repos/somewebmedia/Easy-Digital-Downloads/releases{/id}","created_at":"2014-06-04T15:57:55Z","updated_at":"2014-06-04T16:22:39Z","pushed_at":"2014-06-04T16:10:57Z","git_url":"git://github.com/somewebmedia/Easy-Digital-Downloads.git","ssh_url":"git@github.com:somewebmedia/Easy-Digital-Downloads.git","clone_url":"https://github.com/somewebmedia/Easy-Digital-Downloads.git","svn_url":"https://github.com/somewebmedia/Easy-Digital-Downloads","homepage":"http://easydigitaldownloads.com","size":39980,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"easydigitaldownloads:master","ref":"master","sha":"0dc745d9dcd6c1e18477b8b8a78ef672938b262b","user":{"login":"easydigitaldownloads","id":2955346,"avatar_url":"https://avatars.githubusercontent.com/u/2955346?","gravatar_id":null,"url":"https://api.github.com/users/easydigitaldownloads","html_url":"https://github.com/easydigitaldownloads","followers_url":"https://api.github.com/users/easydigitaldownloads/followers","following_url":"https://api.github.com/users/easydigitaldownloads/following{/other_user}","gists_url":"https://api.github.com/users/easydigitaldownloads/gists{/gist_id}","starred_url":"https://api.github.com/users/easydigitaldownloads/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/easydigitaldownloads/subscriptions","organizations_url":"https://api.github.com/users/easydigitaldownloads/orgs","repos_url":"https://api.github.com/users/easydigitaldownloads/repos","events_url":"https://api.github.com/users/easydigitaldownloads/events{/privacy}","received_events_url":"https://api.github.com/users/easydigitaldownloads/received_events","type":"Organization","site_admin":false},"repo":{"id":3961425,"name":"Easy-Digital-Downloads","full_name":"easydigitaldownloads/Easy-Digital-Downloads","owner":{"login":"easydigitaldownloads","id":2955346,"avatar_url":"https://avatars.githubusercontent.com/u/2955346?","gravatar_id":null,"url":"https://api.github.com/users/easydigitaldownloads","html_url":"https://github.com/easydigitaldownloads","followers_url":"https://api.github.com/users/easydigitaldownloads/followers","following_url":"https://api.github.com/users/easydigitaldownloads/following{/other_user}","gists_url":"https://api.github.com/users/easydigitaldownloads/gists{/gist_id}","starred_url":"https://api.github.com/users/easydigitaldownloads/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/easydigitaldownloads/subscriptions","organizations_url":"https://api.github.com/users/easydigitaldownloads/orgs","repos_url":"https://api.github.com/users/easydigitaldownloads/repos","events_url":"https://api.github.com/users/easydigitaldownloads/events{/privacy}","received_events_url":"https://api.github.com/users/easydigitaldownloads/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/easydigitaldownloads/Easy-Digital-Downloads","description":"Sell digital downloads through WordPress","fork":false,"url":"https://api.github.com/repos/easydigitaldownloads/Easy-Digital-Downloads","forks_url":"https://api.github.com/repos/easydigitaldownloads/Easy-Digital-Downloads/forks","keys_url":"https://api.github.com/repos/easydigitaldownloads/Easy-Digital-Downloads/keys{/key_id}","collaborators_url":"https://api.github.com/repos/easydigitaldownloads/Easy-Digital-Downloads/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/easydigitaldownloads/Easy-Digital-Downloads/teams","hooks_url":"https://api.github.com/repos/easydigitaldownloads/Easy-Digital-Downloads/hooks","issue_events_url":"https://api.github.com/repos/easydigitaldownloads/Easy-Digital-Downloads/issues/events{/number}","events_url":"https://api.github.com/repos/easydigitaldownloads/Easy-Digital-Downloads/events","assignees_url":"https://api.github.com/repos/easydigitaldownloads/Easy-Digital-Downloads/assignees{/user}","branches_url":"https://api.github.com/repos/easydigitaldownloads/Easy-Digital-Downloads/branches{/branch}","tags_url":"https://api.github.com/repos/easydigitaldownloads/Easy-Digital-Downloads/tags","blobs_url":"https://api.github.com/repos/easydigitaldownloads/Easy-Digital-Downloads/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/easydigitaldownloads/Easy-Digital-Downloads/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/easydigitaldownloads/Easy-Digital-Downloads/git/refs{/sha}","trees_url":"https://api.github.com/repos/easydigitaldownloads/Easy-Digital-Downloads/git/trees{/sha}","statuses_url":"https://api.github.com/repos/easydigitaldownloads/Easy-Digital-Downloads/statuses/{sha}","languages_url":"https://api.github.com/repos/easydigitaldownloads/Easy-Digital-Downloads/languages","stargazers_url":"https://api.github.com/repos/easydigitaldownloads/Easy-Digital-Downloads/stargazers","contributors_url":"https://api.github.com/repos/easydigitaldownloads/Easy-Digital-Downloads/contributors","subscribers_url":"https://api.github.com/repos/easydigitaldownloads/Easy-Digital-Downloads/subscribers","subscription_url":"https://api.github.com/repos/easydigitaldownloads/Easy-Digital-Downloads/subscription","commits_url":"https://api.github.com/repos/easydigitaldownloads/Easy-Digital-Downloads/commits{/sha}","git_commits_url":"https://api.github.com/repos/easydigitaldownloads/Easy-Digital-Downloads/git/commits{/sha}","comments_url":"https://api.github.com/repos/easydigitaldownloads/Easy-Digital-Downloads/comments{/number}","issue_comment_url":"https://api.github.com/repos/easydigitaldownloads/Easy-Digital-Downloads/issues/comments/{number}","contents_url":"https://api.github.com/repos/easydigitaldownloads/Easy-Digital-Downloads/contents/{+path}","compare_url":"https://api.github.com/repos/easydigitaldownloads/Easy-Digital-Downloads/compare/{base}...{head}","merges_url":"https://api.github.com/repos/easydigitaldownloads/Easy-Digital-Downloads/merges","archive_url":"https://api.github.com/repos/easydigitaldownloads/Easy-Digital-Downloads/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/easydigitaldownloads/Easy-Digital-Downloads/downloads","issues_url":"https://api.github.com/repos/easydigitaldownloads/Easy-Digital-Downloads/issues{/number}","pulls_url":"https://api.github.com/repos/easydigitaldownloads/Easy-Digital-Downloads/pulls{/number}","milestones_url":"https://api.github.com/repos/easydigitaldownloads/Easy-Digital-Downloads/milestones{/number}","notifications_url":"https://api.github.com/repos/easydigitaldownloads/Easy-Digital-Downloads/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/easydigitaldownloads/Easy-Digital-Downloads/labels{/name}","releases_url":"https://api.github.com/repos/easydigitaldownloads/Easy-Digital-Downloads/releases{/id}","created_at":"2012-04-08T00:12:22Z","updated_at":"2014-06-04T01:29:39Z","pushed_at":"2014-06-04T01:29:42Z","git_url":"git://github.com/easydigitaldownloads/Easy-Digital-Downloads.git","ssh_url":"git@github.com:easydigitaldownloads/Easy-Digital-Downloads.git","clone_url":"https://github.com/easydigitaldownloads/Easy-Digital-Downloads.git","svn_url":"https://github.com/easydigitaldownloads/Easy-Digital-Downloads","homepage":"http://easydigitaldownloads.com","size":39980,"stargazers_count":336,"watchers_count":336,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":200,"mirror_url":null,"open_issues_count":70,"forks":200,"open_issues":70,"watchers":336,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/easydigitaldownloads/Easy-Digital-Downloads/pulls/2346"},"html":{"href":"https://github.com/easydigitaldownloads/Easy-Digital-Downloads/pull/2346"},"issue":{"href":"https://api.github.com/repos/easydigitaldownloads/Easy-Digital-Downloads/issues/2346"},"comments":{"href":"https://api.github.com/repos/easydigitaldownloads/Easy-Digital-Downloads/issues/2346/comments"},"review_comments":{"href":"https://api.github.com/repos/easydigitaldownloads/Easy-Digital-Downloads/pulls/2346/comments"},"review_comment":{"href":"https://api.github.com/repos/easydigitaldownloads/Easy-Digital-Downloads/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/easydigitaldownloads/Easy-Digital-Downloads/pulls/2346/commits"},"statuses":{"href":"https://api.github.com/repos/easydigitaldownloads/Easy-Digital-Downloads/statuses/283132735b1390d310be1357ebdce4aa0a2dea8a"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":4,"deletions":3,"changed_files":1}}