GitHub PullRequestEvent at 2014-04-07 23:53:30
Repository: SOEN-6471-iFreeBudget-Milestone-4
Actor: kishanvshah007
Payload: {"action":"opened","number":2,"pull_request":{"url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/pulls/2","id":14477395,"html_url":"https://github.com/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/pull/2","diff_url":"https://github.com/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/pull/2.diff","patch_url":"https://github.com/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/pull/2.patch","issue_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/issues/2","number":2,"state":"open","title":"Extract class-Move method","user":{"login":"kishanvshah007","id":2430888,"avatar_url":"https://avatars.githubusercontent.com/u/2430888?","gravatar_id":"c810a1717504c895cb974b365ebe8c58","url":"https://api.github.com/users/kishanvshah007","html_url":"https://github.com/kishanvshah007","followers_url":"https://api.github.com/users/kishanvshah007/followers","following_url":"https://api.github.com/users/kishanvshah007/following{/other_user}","gists_url":"https://api.github.com/users/kishanvshah007/gists{/gist_id}","starred_url":"https://api.github.com/users/kishanvshah007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kishanvshah007/subscriptions","organizations_url":"https://api.github.com/users/kishanvshah007/orgs","repos_url":"https://api.github.com/users/kishanvshah007/repos","events_url":"https://api.github.com/users/kishanvshah007/events{/privacy}","received_events_url":"https://api.github.com/users/kishanvshah007/received_events","type":"User","site_admin":false},"body":"Problem: The FManEntityManager acts as a god class taking to much responsibility upon itself.It has methods to handle transactions(like add/update/delete/get transactions),accounts,user and portfolio.\r\n\r\nSolution: We decided to solve this code smell by extracting a separate class that would handle all the methods that are related to Accounts.We have created a new class FManAccountEntityManager and moved all the methods that are responsible for account related actions to the new class.\r\n\r\nStep 1:Created a new Class FManAccountEntityManager and moved all the account related methods like addAccount,getAccount,deleteAccount,updateAccount to it.\r\n\r\nStep 2: We have created an object of the new FManAccountEntityManager class and used its reference for calling the different account methods present inside it. Since there are a number of methods that uses the FManEnityManager class, we have delegated all the account related methods to the  FManAccountEntityManager class.","created_at":"2014-04-07T23:53:29Z","updated_at":"2014-04-07T23:53:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"af245afa69b575b6787dfe21964bfe1ed14e638b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/pulls/2/commits","review_comments_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/pulls/2/comments","review_comment_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/pulls/comments/{number}","comments_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/issues/2/comments","statuses_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/statuses/81721fa1de4e0174bbf052bf2f98dc8ca8342f32","head":{"label":"kishanvshah007:ExtractClass-MoveMethod","ref":"ExtractClass-MoveMethod","sha":"81721fa1de4e0174bbf052bf2f98dc8ca8342f32","user":{"login":"kishanvshah007","id":2430888,"avatar_url":"https://avatars.githubusercontent.com/u/2430888?","gravatar_id":"c810a1717504c895cb974b365ebe8c58","url":"https://api.github.com/users/kishanvshah007","html_url":"https://github.com/kishanvshah007","followers_url":"https://api.github.com/users/kishanvshah007/followers","following_url":"https://api.github.com/users/kishanvshah007/following{/other_user}","gists_url":"https://api.github.com/users/kishanvshah007/gists{/gist_id}","starred_url":"https://api.github.com/users/kishanvshah007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kishanvshah007/subscriptions","organizations_url":"https://api.github.com/users/kishanvshah007/orgs","repos_url":"https://api.github.com/users/kishanvshah007/repos","events_url":"https://api.github.com/users/kishanvshah007/events{/privacy}","received_events_url":"https://api.github.com/users/kishanvshah007/received_events","type":"User","site_admin":false},"repo":{"id":18537685,"name":"SOEN-6471-iFreeBudget-Milestone-4","full_name":"kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4","owner":{"login":"kishanvshah007","id":2430888,"avatar_url":"https://avatars.githubusercontent.com/u/2430888?","gravatar_id":"c810a1717504c895cb974b365ebe8c58","url":"https://api.github.com/users/kishanvshah007","html_url":"https://github.com/kishanvshah007","followers_url":"https://api.github.com/users/kishanvshah007/followers","following_url":"https://api.github.com/users/kishanvshah007/following{/other_user}","gists_url":"https://api.github.com/users/kishanvshah007/gists{/gist_id}","starred_url":"https://api.github.com/users/kishanvshah007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kishanvshah007/subscriptions","organizations_url":"https://api.github.com/users/kishanvshah007/orgs","repos_url":"https://api.github.com/users/kishanvshah007/repos","events_url":"https://api.github.com/users/kishanvshah007/events{/privacy}","received_events_url":"https://api.github.com/users/kishanvshah007/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4","description":null,"fork":false,"url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4","forks_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/forks","keys_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/teams","hooks_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/hooks","issue_events_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/issues/events{/number}","events_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/events","assignees_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/assignees{/user}","branches_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/branches{/branch}","tags_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/tags","blobs_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/git/refs{/sha}","trees_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/statuses/{sha}","languages_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/languages","stargazers_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/stargazers","contributors_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/contributors","subscribers_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/subscribers","subscription_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/subscription","commits_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/commits{/sha}","git_commits_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/git/commits{/sha}","comments_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/comments{/number}","issue_comment_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/issues/comments/{number}","contents_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/contents/{+path}","compare_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/merges","archive_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/downloads","issues_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/issues{/number}","pulls_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/pulls{/number}","milestones_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/milestones{/number}","notifications_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/labels{/name}","releases_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/releases{/id}","created_at":"2014-04-07T23:03:21Z","updated_at":"2014-04-07T23:53:29Z","pushed_at":"2014-04-07T23:35:05Z","git_url":"git://github.com/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4.git","ssh_url":"git@github.com:kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4.git","clone_url":"https://github.com/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4.git","svn_url":"https://github.com/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"kishanvshah007:master","ref":"master","sha":"b626314ba0f2db54f323e730a79a32f7c8e3969a","user":{"login":"kishanvshah007","id":2430888,"avatar_url":"https://avatars.githubusercontent.com/u/2430888?","gravatar_id":"c810a1717504c895cb974b365ebe8c58","url":"https://api.github.com/users/kishanvshah007","html_url":"https://github.com/kishanvshah007","followers_url":"https://api.github.com/users/kishanvshah007/followers","following_url":"https://api.github.com/users/kishanvshah007/following{/other_user}","gists_url":"https://api.github.com/users/kishanvshah007/gists{/gist_id}","starred_url":"https://api.github.com/users/kishanvshah007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kishanvshah007/subscriptions","organizations_url":"https://api.github.com/users/kishanvshah007/orgs","repos_url":"https://api.github.com/users/kishanvshah007/repos","events_url":"https://api.github.com/users/kishanvshah007/events{/privacy}","received_events_url":"https://api.github.com/users/kishanvshah007/received_events","type":"User","site_admin":false},"repo":{"id":18537685,"name":"SOEN-6471-iFreeBudget-Milestone-4","full_name":"kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4","owner":{"login":"kishanvshah007","id":2430888,"avatar_url":"https://avatars.githubusercontent.com/u/2430888?","gravatar_id":"c810a1717504c895cb974b365ebe8c58","url":"https://api.github.com/users/kishanvshah007","html_url":"https://github.com/kishanvshah007","followers_url":"https://api.github.com/users/kishanvshah007/followers","following_url":"https://api.github.com/users/kishanvshah007/following{/other_user}","gists_url":"https://api.github.com/users/kishanvshah007/gists{/gist_id}","starred_url":"https://api.github.com/users/kishanvshah007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kishanvshah007/subscriptions","organizations_url":"https://api.github.com/users/kishanvshah007/orgs","repos_url":"https://api.github.com/users/kishanvshah007/repos","events_url":"https://api.github.com/users/kishanvshah007/events{/privacy}","received_events_url":"https://api.github.com/users/kishanvshah007/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4","description":null,"fork":false,"url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4","forks_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/forks","keys_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/teams","hooks_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/hooks","issue_events_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/issues/events{/number}","events_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/events","assignees_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/assignees{/user}","branches_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/branches{/branch}","tags_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/tags","blobs_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/git/refs{/sha}","trees_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/statuses/{sha}","languages_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/languages","stargazers_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/stargazers","contributors_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/contributors","subscribers_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/subscribers","subscription_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/subscription","commits_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/commits{/sha}","git_commits_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/git/commits{/sha}","comments_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/comments{/number}","issue_comment_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/issues/comments/{number}","contents_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/contents/{+path}","compare_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/merges","archive_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/downloads","issues_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/issues{/number}","pulls_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/pulls{/number}","milestones_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/milestones{/number}","notifications_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/labels{/name}","releases_url":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/releases{/id}","created_at":"2014-04-07T23:03:21Z","updated_at":"2014-04-07T23:53:29Z","pushed_at":"2014-04-07T23:35:05Z","git_url":"git://github.com/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4.git","ssh_url":"git@github.com:kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4.git","clone_url":"https://github.com/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4.git","svn_url":"https://github.com/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/pulls/2"},"html":{"href":"https://github.com/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/pull/2"},"issue":{"href":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/issues/2"},"comments":{"href":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/kishanvshah007/SOEN-6471-iFreeBudget-Milestone-4/statuses/81721fa1de4e0174bbf052bf2f98dc8ca8342f32"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":777,"deletions":579,"changed_files":2}}