GitHub PullRequestReviewCommentEvent at 2014-01-07 09:09:43
Repository: symfony
Actor: stloyd
Payload: {"comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/8688517","id":8688517,"diff_hunk":"@@ -132,6 +156,20 @@ public function buildView(FormView $view, FormInterface $form, array $options)\n             // POST request.\n             $view->vars['full_name'] = $view->vars['full_name'].'[]';\n         }\n+\n+        $choicesAttributes = $options['choices_attributes'];\n+        $choicesPrototypes = $options['choices_prototypes'];\n+        if (count($choicesAttributes) || count($choicesPrototypes)) {","path":"src/Symfony/Component/Form/Extension/Core/Type/ChoiceType.php","position":52,"original_position":52,"commit_id":"084ddc010290980d0f8f97d35f0331586320763b","original_commit_id":"084ddc010290980d0f8f97d35f0331586320763b","user":{"login":"stloyd","id":67402,"avatar_url":"https://gravatar.com/avatar/b494363ed38b483b240180920c0d38c2?d=https%3A%2F%2Fidenticons.github.com%2F7152f4f2dfa4e1cc7db86648913b8ac9.png&r=x","gravatar_id":"b494363ed38b483b240180920c0d38c2","url":"https://api.github.com/users/stloyd","html_url":"https://github.com/stloyd","followers_url":"https://api.github.com/users/stloyd/followers","following_url":"https://api.github.com/users/stloyd/following{/other_user}","gists_url":"https://api.github.com/users/stloyd/gists{/gist_id}","starred_url":"https://api.github.com/users/stloyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stloyd/subscriptions","organizations_url":"https://api.github.com/users/stloyd/orgs","repos_url":"https://api.github.com/users/stloyd/repos","events_url":"https://api.github.com/users/stloyd/events{/privacy}","received_events_url":"https://api.github.com/users/stloyd/received_events","type":"User","site_admin":false},"body":"Why not:\r\n```php\r\nif (!empty($options['choices_attributes']) || !empty($options['choices_prototypes'])) {}\r\n```\r\nAs you don't need to know how many choices exists, but just there are somem, also those new variable are useless (even you use only one of those).","created_at":"2014-01-07T09:09:43Z","updated_at":"2014-01-07T09:09:43Z","html_url":"https://github.com/symfony/symfony/pull/9694#discussion_r8688517","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/9694","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/8688517"},"html":{"href":"https://github.com/symfony/symfony/pull/9694#discussion_r8688517"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/9694"}}}}