GitHub PullRequestReviewCommentEvent at 2014-12-28 10:38:32
Repository: react-bootstrap
Actor: nelix
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/pulls/comments/22297267","id":22297267,"diff_hunk":"@@ -126,6 +126,10 @@ var Modal = React.createClass({\n \n     if (this.props.backdrop) {\n       this.iosClickHack();\n+      if (document && document.body) {","path":"src/Modal.jsx","position":4,"original_position":4,"commit_id":"f9962a73c3d6350a39d23cba08c9894060454849","original_commit_id":"f9962a73c3d6350a39d23cba08c9894060454849","user":{"login":"nelix","id":33324,"avatar_url":"https://avatars.githubusercontent.com/u/33324?v=3","gravatar_id":"","url":"https://api.github.com/users/nelix","html_url":"https://github.com/nelix","followers_url":"https://api.github.com/users/nelix/followers","following_url":"https://api.github.com/users/nelix/following{/other_user}","gists_url":"https://api.github.com/users/nelix/gists{/gist_id}","starred_url":"https://api.github.com/users/nelix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nelix/subscriptions","organizations_url":"https://api.github.com/users/nelix/orgs","repos_url":"https://api.github.com/users/nelix/repos","events_url":"https://api.github.com/users/nelix/events{/privacy}","received_events_url":"https://api.github.com/users/nelix/received_events","type":"User","site_admin":false},"body":"but what if we are not rendering on the browser? or if the document has no body? etc","created_at":"2014-12-28T10:38:32Z","updated_at":"2014-12-28T10:38:32Z","html_url":"https://github.com/react-bootstrap/react-bootstrap/pull/283#discussion_r22297267","pull_request_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/pulls/283","_links":{"self":{"href":"https://api.github.com/repos/react-bootstrap/react-bootstrap/pulls/comments/22297267"},"html":{"href":"https://github.com/react-bootstrap/react-bootstrap/pull/283#discussion_r22297267"},"pull_request":{"href":"https://api.github.com/repos/react-bootstrap/react-bootstrap/pulls/283"}}},"pull_request":{"url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/pulls/283","id":24744565,"html_url":"https://github.com/react-bootstrap/react-bootstrap/pull/283","diff_url":"https://github.com/react-bootstrap/react-bootstrap/pull/283.diff","patch_url":"https://github.com/react-bootstrap/react-bootstrap/pull/283.patch","issue_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues/283","number":283,"state":"closed","locked":false,"title":"Add modal-open class to body when modals are opened","user":{"login":"pcardune","id":124827,"avatar_url":"https://avatars.githubusercontent.com/u/124827?v=3","gravatar_id":"","url":"https://api.github.com/users/pcardune","html_url":"https://github.com/pcardune","followers_url":"https://api.github.com/users/pcardune/followers","following_url":"https://api.github.com/users/pcardune/following{/other_user}","gists_url":"https://api.github.com/users/pcardune/gists{/gist_id}","starred_url":"https://api.github.com/users/pcardune/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcardune/subscriptions","organizations_url":"https://api.github.com/users/pcardune/orgs","repos_url":"https://api.github.com/users/pcardune/repos","events_url":"https://api.github.com/users/pcardune/events{/privacy}","received_events_url":"https://api.github.com/users/pcardune/received_events","type":"User","site_admin":false},"body":"Given that this is how normal bootstrap works, it makes sense to break React's encapsulation convention.\r\n\r\nNot sure what the right way to write a test for this is, but I confirmed that the modal demos on the docs site work the same way as on the bootstrap site.","created_at":"2014-11-20T06:00:52Z","updated_at":"2014-12-28T10:38:32Z","closed_at":"2014-12-28T07:27:19Z","merged_at":null,"merge_commit_sha":"b8c5ef35a1011ebeb992d8f9cd9a212a20aa7271","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/pulls/283/commits","review_comments_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/pulls/283/comments","review_comment_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/pulls/comments/{number}","comments_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues/283/comments","statuses_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/statuses/f9962a73c3d6350a39d23cba08c9894060454849","head":{"label":"pcardune:master","ref":"master","sha":"f9962a73c3d6350a39d23cba08c9894060454849","user":{"login":"pcardune","id":124827,"avatar_url":"https://avatars.githubusercontent.com/u/124827?v=3","gravatar_id":"","url":"https://api.github.com/users/pcardune","html_url":"https://github.com/pcardune","followers_url":"https://api.github.com/users/pcardune/followers","following_url":"https://api.github.com/users/pcardune/following{/other_user}","gists_url":"https://api.github.com/users/pcardune/gists{/gist_id}","starred_url":"https://api.github.com/users/pcardune/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcardune/subscriptions","organizations_url":"https://api.github.com/users/pcardune/orgs","repos_url":"https://api.github.com/users/pcardune/repos","events_url":"https://api.github.com/users/pcardune/events{/privacy}","received_events_url":"https://api.github.com/users/pcardune/received_events","type":"User","site_admin":false},"repo":{"id":26897085,"name":"react-bootstrap","full_name":"pcardune/react-bootstrap","owner":{"login":"pcardune","id":124827,"avatar_url":"https://avatars.githubusercontent.com/u/124827?v=3","gravatar_id":"","url":"https://api.github.com/users/pcardune","html_url":"https://github.com/pcardune","followers_url":"https://api.github.com/users/pcardune/followers","following_url":"https://api.github.com/users/pcardune/following{/other_user}","gists_url":"https://api.github.com/users/pcardune/gists{/gist_id}","starred_url":"https://api.github.com/users/pcardune/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcardune/subscriptions","organizations_url":"https://api.github.com/users/pcardune/orgs","repos_url":"https://api.github.com/users/pcardune/repos","events_url":"https://api.github.com/users/pcardune/events{/privacy}","received_events_url":"https://api.github.com/users/pcardune/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pcardune/react-bootstrap","description":"Bootstrap 3 components built with React","fork":true,"url":"https://api.github.com/repos/pcardune/react-bootstrap","forks_url":"https://api.github.com/repos/pcardune/react-bootstrap/forks","keys_url":"https://api.github.com/repos/pcardune/react-bootstrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pcardune/react-bootstrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pcardune/react-bootstrap/teams","hooks_url":"https://api.github.com/repos/pcardune/react-bootstrap/hooks","issue_events_url":"https://api.github.com/repos/pcardune/react-bootstrap/issues/events{/number}","events_url":"https://api.github.com/repos/pcardune/react-bootstrap/events","assignees_url":"https://api.github.com/repos/pcardune/react-bootstrap/assignees{/user}","branches_url":"https://api.github.com/repos/pcardune/react-bootstrap/branches{/branch}","tags_url":"https://api.github.com/repos/pcardune/react-bootstrap/tags","blobs_url":"https://api.github.com/repos/pcardune/react-bootstrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pcardune/react-bootstrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pcardune/react-bootstrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/pcardune/react-bootstrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pcardune/react-bootstrap/statuses/{sha}","languages_url":"https://api.github.com/repos/pcardune/react-bootstrap/languages","stargazers_url":"https://api.github.com/repos/pcardune/react-bootstrap/stargazers","contributors_url":"https://api.github.com/repos/pcardune/react-bootstrap/contributors","subscribers_url":"https://api.github.com/repos/pcardune/react-bootstrap/subscribers","subscription_url":"https://api.github.com/repos/pcardune/react-bootstrap/subscription","commits_url":"https://api.github.com/repos/pcardune/react-bootstrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/pcardune/react-bootstrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/pcardune/react-bootstrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/pcardune/react-bootstrap/issues/comments/{number}","contents_url":"https://api.github.com/repos/pcardune/react-bootstrap/contents/{+path}","compare_url":"https://api.github.com/repos/pcardune/react-bootstrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pcardune/react-bootstrap/merges","archive_url":"https://api.github.com/repos/pcardune/react-bootstrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pcardune/react-bootstrap/downloads","issues_url":"https://api.github.com/repos/pcardune/react-bootstrap/issues{/number}","pulls_url":"https://api.github.com/repos/pcardune/react-bootstrap/pulls{/number}","milestones_url":"https://api.github.com/repos/pcardune/react-bootstrap/milestones{/number}","notifications_url":"https://api.github.com/repos/pcardune/react-bootstrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pcardune/react-bootstrap/labels{/name}","releases_url":"https://api.github.com/repos/pcardune/react-bootstrap/releases{/id}","created_at":"2014-11-20T05:21:08Z","updated_at":"2014-11-20T05:56:03Z","pushed_at":"2014-11-20T05:56:02Z","git_url":"git://github.com/pcardune/react-bootstrap.git","ssh_url":"git@github.com:pcardune/react-bootstrap.git","clone_url":"https://github.com/pcardune/react-bootstrap.git","svn_url":"https://github.com/pcardune/react-bootstrap","homepage":"http://react-bootstrap.github.io/","size":2179,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"react-bootstrap:master","ref":"master","sha":"19e48257b2dc6c77cb73bed16a9ee15fead3577b","user":{"login":"react-bootstrap","id":6853419,"avatar_url":"https://avatars.githubusercontent.com/u/6853419?v=3","gravatar_id":"","url":"https://api.github.com/users/react-bootstrap","html_url":"https://github.com/react-bootstrap","followers_url":"https://api.github.com/users/react-bootstrap/followers","following_url":"https://api.github.com/users/react-bootstrap/following{/other_user}","gists_url":"https://api.github.com/users/react-bootstrap/gists{/gist_id}","starred_url":"https://api.github.com/users/react-bootstrap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/react-bootstrap/subscriptions","organizations_url":"https://api.github.com/users/react-bootstrap/orgs","repos_url":"https://api.github.com/users/react-bootstrap/repos","events_url":"https://api.github.com/users/react-bootstrap/events{/privacy}","received_events_url":"https://api.github.com/users/react-bootstrap/received_events","type":"Organization","site_admin":false},"repo":{"id":15480067,"name":"react-bootstrap","full_name":"react-bootstrap/react-bootstrap","owner":{"login":"react-bootstrap","id":6853419,"avatar_url":"https://avatars.githubusercontent.com/u/6853419?v=3","gravatar_id":"","url":"https://api.github.com/users/react-bootstrap","html_url":"https://github.com/react-bootstrap","followers_url":"https://api.github.com/users/react-bootstrap/followers","following_url":"https://api.github.com/users/react-bootstrap/following{/other_user}","gists_url":"https://api.github.com/users/react-bootstrap/gists{/gist_id}","starred_url":"https://api.github.com/users/react-bootstrap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/react-bootstrap/subscriptions","organizations_url":"https://api.github.com/users/react-bootstrap/orgs","repos_url":"https://api.github.com/users/react-bootstrap/repos","events_url":"https://api.github.com/users/react-bootstrap/events{/privacy}","received_events_url":"https://api.github.com/users/react-bootstrap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/react-bootstrap/react-bootstrap","description":"Bootstrap 3 components built with React","fork":false,"url":"https://api.github.com/repos/react-bootstrap/react-bootstrap","forks_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/forks","keys_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/teams","hooks_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/hooks","issue_events_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues/events{/number}","events_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/events","assignees_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/assignees{/user}","branches_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/branches{/branch}","tags_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/tags","blobs_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/statuses/{sha}","languages_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/languages","stargazers_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/stargazers","contributors_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/contributors","subscribers_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/subscribers","subscription_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/subscription","commits_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues/comments/{number}","contents_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/contents/{+path}","compare_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/merges","archive_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/downloads","issues_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues{/number}","pulls_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/pulls{/number}","milestones_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/milestones{/number}","notifications_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/labels{/name}","releases_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/releases{/id}","created_at":"2013-12-27T19:06:07Z","updated_at":"2014-12-28T07:47:06Z","pushed_at":"2014-12-28T07:47:06Z","git_url":"git://github.com/react-bootstrap/react-bootstrap.git","ssh_url":"git@github.com:react-bootstrap/react-bootstrap.git","clone_url":"https://github.com/react-bootstrap/react-bootstrap.git","svn_url":"https://github.com/react-bootstrap/react-bootstrap","homepage":"http://react-bootstrap.github.io/","size":3637,"stargazers_count":1217,"watchers_count":1217,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":156,"mirror_url":null,"open_issues_count":68,"forks":156,"open_issues":68,"watchers":1217,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/react-bootstrap/react-bootstrap/pulls/283"},"html":{"href":"https://github.com/react-bootstrap/react-bootstrap/pull/283"},"issue":{"href":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues/283"},"comments":{"href":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues/283/comments"},"review_comments":{"href":"https://api.github.com/repos/react-bootstrap/react-bootstrap/pulls/283/comments"},"review_comment":{"href":"https://api.github.com/repos/react-bootstrap/react-bootstrap/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/react-bootstrap/react-bootstrap/pulls/283/commits"},"statuses":{"href":"https://api.github.com/repos/react-bootstrap/react-bootstrap/statuses/f9962a73c3d6350a39d23cba08c9894060454849"}}}}