GitHub PullRequestEvent at 2014-10-15 12:00:06
Repository: tosdr-firefox
Actor: AbdullahDiaa
Payload: {"action":"closed","number":22,"pull_request":{"url":"https://api.github.com/repos/tosdr/tosdr-firefox/pulls/22","id":22459657,"html_url":"https://github.com/tosdr/tosdr-firefox/pull/22","diff_url":"https://github.com/tosdr/tosdr-firefox/pull/22.diff","patch_url":"https://github.com/tosdr/tosdr-firefox/pull/22.patch","issue_url":"https://api.github.com/repos/tosdr/tosdr-firefox/issues/22","number":22,"state":"closed","locked":false,"title":"Refactor service update logic","user":{"login":"cimm","id":68112,"avatar_url":"https://avatars.githubusercontent.com/u/68112?v=2","gravatar_id":"","url":"https://api.github.com/users/cimm","html_url":"https://github.com/cimm","followers_url":"https://api.github.com/users/cimm/followers","following_url":"https://api.github.com/users/cimm/following{/other_user}","gists_url":"https://api.github.com/users/cimm/gists{/gist_id}","starred_url":"https://api.github.com/users/cimm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cimm/subscriptions","organizations_url":"https://api.github.com/users/cimm/orgs","repos_url":"https://api.github.com/users/cimm/repos","events_url":"https://api.github.com/users/cimm/events{/privacy}","received_events_url":"https://api.github.com/users/cimm/received_events","type":"User","site_admin":false},"body":"Second pull request to try to separate the responsibilities from `main.js` into multiple functions, see #21 for the TOSDR API calls.\r\n\r\nThis commit adds an UpdateTracker function which contains all the logic to decide if it's time to fetch the list of services from the TOSDR server (after 13 days, like before). This removes the need for date calculations in the `main.js` file and removes the duplicate request services call code.\r\n\r\n~~**Note**: this pull request and pull request #21 will probably conflict on master when both are merged at the same time. If one is merged with master I'll rebase the other one.~~\r\n\r\n@AbdullahDiaa Feel free to give your opinion. Tell me if you feel this is useless. I would like to help but totally understand it's your project and you might not agree with my programming ideas. ;) Just tell me and reject both pull requests, no hard feelings.","created_at":"2014-10-08T22:26:19Z","updated_at":"2014-10-15T12:00:06Z","closed_at":"2014-10-15T12:00:06Z","merged_at":"2014-10-15T12:00:06Z","merge_commit_sha":"404e953c2278d231542d356b3f272285bd007115","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tosdr/tosdr-firefox/pulls/22/commits","review_comments_url":"https://api.github.com/repos/tosdr/tosdr-firefox/pulls/22/comments","review_comment_url":"https://api.github.com/repos/tosdr/tosdr-firefox/pulls/comments/{number}","comments_url":"https://api.github.com/repos/tosdr/tosdr-firefox/issues/22/comments","statuses_url":"https://api.github.com/repos/tosdr/tosdr-firefox/statuses/423a94301fcae7b31511e235b107a5a1fa52956e","head":{"label":"cimm:update-tracker","ref":"update-tracker","sha":"423a94301fcae7b31511e235b107a5a1fa52956e","user":{"login":"cimm","id":68112,"avatar_url":"https://avatars.githubusercontent.com/u/68112?v=2","gravatar_id":"","url":"https://api.github.com/users/cimm","html_url":"https://github.com/cimm","followers_url":"https://api.github.com/users/cimm/followers","following_url":"https://api.github.com/users/cimm/following{/other_user}","gists_url":"https://api.github.com/users/cimm/gists{/gist_id}","starred_url":"https://api.github.com/users/cimm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cimm/subscriptions","organizations_url":"https://api.github.com/users/cimm/orgs","repos_url":"https://api.github.com/users/cimm/repos","events_url":"https://api.github.com/users/cimm/events{/privacy}","received_events_url":"https://api.github.com/users/cimm/received_events","type":"User","site_admin":false},"repo":{"id":24771132,"name":"tosdr-firefox","full_name":"cimm/tosdr-firefox","owner":{"login":"cimm","id":68112,"avatar_url":"https://avatars.githubusercontent.com/u/68112?v=2","gravatar_id":"","url":"https://api.github.com/users/cimm","html_url":"https://github.com/cimm","followers_url":"https://api.github.com/users/cimm/followers","following_url":"https://api.github.com/users/cimm/following{/other_user}","gists_url":"https://api.github.com/users/cimm/gists{/gist_id}","starred_url":"https://api.github.com/users/cimm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cimm/subscriptions","organizations_url":"https://api.github.com/users/cimm/orgs","repos_url":"https://api.github.com/users/cimm/repos","events_url":"https://api.github.com/users/cimm/events{/privacy}","received_events_url":"https://api.github.com/users/cimm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cimm/tosdr-firefox","description":"Firefox add-on for Terms of Service; Didn't Read. “I have read and agree to the Terms” is the biggest lie on the web. We aim to fix that. Get informed instantly about websites' terms & privacy policies, with ratings and summaries from the www.tosdr.org initiative.","fork":true,"url":"https://api.github.com/repos/cimm/tosdr-firefox","forks_url":"https://api.github.com/repos/cimm/tosdr-firefox/forks","keys_url":"https://api.github.com/repos/cimm/tosdr-firefox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cimm/tosdr-firefox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cimm/tosdr-firefox/teams","hooks_url":"https://api.github.com/repos/cimm/tosdr-firefox/hooks","issue_events_url":"https://api.github.com/repos/cimm/tosdr-firefox/issues/events{/number}","events_url":"https://api.github.com/repos/cimm/tosdr-firefox/events","assignees_url":"https://api.github.com/repos/cimm/tosdr-firefox/assignees{/user}","branches_url":"https://api.github.com/repos/cimm/tosdr-firefox/branches{/branch}","tags_url":"https://api.github.com/repos/cimm/tosdr-firefox/tags","blobs_url":"https://api.github.com/repos/cimm/tosdr-firefox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cimm/tosdr-firefox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cimm/tosdr-firefox/git/refs{/sha}","trees_url":"https://api.github.com/repos/cimm/tosdr-firefox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cimm/tosdr-firefox/statuses/{sha}","languages_url":"https://api.github.com/repos/cimm/tosdr-firefox/languages","stargazers_url":"https://api.github.com/repos/cimm/tosdr-firefox/stargazers","contributors_url":"https://api.github.com/repos/cimm/tosdr-firefox/contributors","subscribers_url":"https://api.github.com/repos/cimm/tosdr-firefox/subscribers","subscription_url":"https://api.github.com/repos/cimm/tosdr-firefox/subscription","commits_url":"https://api.github.com/repos/cimm/tosdr-firefox/commits{/sha}","git_commits_url":"https://api.github.com/repos/cimm/tosdr-firefox/git/commits{/sha}","comments_url":"https://api.github.com/repos/cimm/tosdr-firefox/comments{/number}","issue_comment_url":"https://api.github.com/repos/cimm/tosdr-firefox/issues/comments/{number}","contents_url":"https://api.github.com/repos/cimm/tosdr-firefox/contents/{+path}","compare_url":"https://api.github.com/repos/cimm/tosdr-firefox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cimm/tosdr-firefox/merges","archive_url":"https://api.github.com/repos/cimm/tosdr-firefox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cimm/tosdr-firefox/downloads","issues_url":"https://api.github.com/repos/cimm/tosdr-firefox/issues{/number}","pulls_url":"https://api.github.com/repos/cimm/tosdr-firefox/pulls{/number}","milestones_url":"https://api.github.com/repos/cimm/tosdr-firefox/milestones{/number}","notifications_url":"https://api.github.com/repos/cimm/tosdr-firefox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cimm/tosdr-firefox/labels{/name}","releases_url":"https://api.github.com/repos/cimm/tosdr-firefox/releases{/id}","created_at":"2014-10-03T19:35:32Z","updated_at":"2014-10-03T19:44:58Z","pushed_at":"2014-10-13T12:55:43Z","git_url":"git://github.com/cimm/tosdr-firefox.git","ssh_url":"git@github.com:cimm/tosdr-firefox.git","clone_url":"https://github.com/cimm/tosdr-firefox.git","svn_url":"https://github.com/cimm/tosdr-firefox","homepage":"http://tosdr.org/downloads.html","size":2664,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tosdr:master","ref":"master","sha":"904fca827c1e7040d86cca1f3ac9ba6066eff1cf","user":{"login":"tosdr","id":3402969,"avatar_url":"https://avatars.githubusercontent.com/u/3402969?v=2","gravatar_id":"","url":"https://api.github.com/users/tosdr","html_url":"https://github.com/tosdr","followers_url":"https://api.github.com/users/tosdr/followers","following_url":"https://api.github.com/users/tosdr/following{/other_user}","gists_url":"https://api.github.com/users/tosdr/gists{/gist_id}","starred_url":"https://api.github.com/users/tosdr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tosdr/subscriptions","organizations_url":"https://api.github.com/users/tosdr/orgs","repos_url":"https://api.github.com/users/tosdr/repos","events_url":"https://api.github.com/users/tosdr/events{/privacy}","received_events_url":"https://api.github.com/users/tosdr/received_events","type":"Organization","site_admin":false},"repo":{"id":5451616,"name":"tosdr-firefox","full_name":"tosdr/tosdr-firefox","owner":{"login":"tosdr","id":3402969,"avatar_url":"https://avatars.githubusercontent.com/u/3402969?v=2","gravatar_id":"","url":"https://api.github.com/users/tosdr","html_url":"https://github.com/tosdr","followers_url":"https://api.github.com/users/tosdr/followers","following_url":"https://api.github.com/users/tosdr/following{/other_user}","gists_url":"https://api.github.com/users/tosdr/gists{/gist_id}","starred_url":"https://api.github.com/users/tosdr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tosdr/subscriptions","organizations_url":"https://api.github.com/users/tosdr/orgs","repos_url":"https://api.github.com/users/tosdr/repos","events_url":"https://api.github.com/users/tosdr/events{/privacy}","received_events_url":"https://api.github.com/users/tosdr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tosdr/tosdr-firefox","description":"Firefox add-on for Terms of Service; Didn't Read. “I have read and agree to the Terms” is the biggest lie on the web. We aim to fix that. Get informed instantly about websites' terms & privacy policies, with ratings and summaries from the www.tosdr.org initiative.","fork":true,"url":"https://api.github.com/repos/tosdr/tosdr-firefox","forks_url":"https://api.github.com/repos/tosdr/tosdr-firefox/forks","keys_url":"https://api.github.com/repos/tosdr/tosdr-firefox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tosdr/tosdr-firefox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tosdr/tosdr-firefox/teams","hooks_url":"https://api.github.com/repos/tosdr/tosdr-firefox/hooks","issue_events_url":"https://api.github.com/repos/tosdr/tosdr-firefox/issues/events{/number}","events_url":"https://api.github.com/repos/tosdr/tosdr-firefox/events","assignees_url":"https://api.github.com/repos/tosdr/tosdr-firefox/assignees{/user}","branches_url":"https://api.github.com/repos/tosdr/tosdr-firefox/branches{/branch}","tags_url":"https://api.github.com/repos/tosdr/tosdr-firefox/tags","blobs_url":"https://api.github.com/repos/tosdr/tosdr-firefox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tosdr/tosdr-firefox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tosdr/tosdr-firefox/git/refs{/sha}","trees_url":"https://api.github.com/repos/tosdr/tosdr-firefox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tosdr/tosdr-firefox/statuses/{sha}","languages_url":"https://api.github.com/repos/tosdr/tosdr-firefox/languages","stargazers_url":"https://api.github.com/repos/tosdr/tosdr-firefox/stargazers","contributors_url":"https://api.github.com/repos/tosdr/tosdr-firefox/contributors","subscribers_url":"https://api.github.com/repos/tosdr/tosdr-firefox/subscribers","subscription_url":"https://api.github.com/repos/tosdr/tosdr-firefox/subscription","commits_url":"https://api.github.com/repos/tosdr/tosdr-firefox/commits{/sha}","git_commits_url":"https://api.github.com/repos/tosdr/tosdr-firefox/git/commits{/sha}","comments_url":"https://api.github.com/repos/tosdr/tosdr-firefox/comments{/number}","issue_comment_url":"https://api.github.com/repos/tosdr/tosdr-firefox/issues/comments/{number}","contents_url":"https://api.github.com/repos/tosdr/tosdr-firefox/contents/{+path}","compare_url":"https://api.github.com/repos/tosdr/tosdr-firefox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tosdr/tosdr-firefox/merges","archive_url":"https://api.github.com/repos/tosdr/tosdr-firefox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tosdr/tosdr-firefox/downloads","issues_url":"https://api.github.com/repos/tosdr/tosdr-firefox/issues{/number}","pulls_url":"https://api.github.com/repos/tosdr/tosdr-firefox/pulls{/number}","milestones_url":"https://api.github.com/repos/tosdr/tosdr-firefox/milestones{/number}","notifications_url":"https://api.github.com/repos/tosdr/tosdr-firefox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tosdr/tosdr-firefox/labels{/name}","releases_url":"https://api.github.com/repos/tosdr/tosdr-firefox/releases{/id}","created_at":"2012-08-17T11:51:35Z","updated_at":"2014-10-04T16:47:05Z","pushed_at":"2014-10-15T12:00:06Z","git_url":"git://github.com/tosdr/tosdr-firefox.git","ssh_url":"git@github.com:tosdr/tosdr-firefox.git","clone_url":"https://github.com/tosdr/tosdr-firefox.git","svn_url":"https://github.com/tosdr/tosdr-firefox","homepage":"http://tosdr.org/downloads.html","size":2929,"stargazers_count":18,"watchers_count":18,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":3,"forks":9,"open_issues":3,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tosdr/tosdr-firefox/pulls/22"},"html":{"href":"https://github.com/tosdr/tosdr-firefox/pull/22"},"issue":{"href":"https://api.github.com/repos/tosdr/tosdr-firefox/issues/22"},"comments":{"href":"https://api.github.com/repos/tosdr/tosdr-firefox/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/tosdr/tosdr-firefox/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/tosdr/tosdr-firefox/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/tosdr/tosdr-firefox/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/tosdr/tosdr-firefox/statuses/423a94301fcae7b31511e235b107a5a1fa52956e"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"AbdullahDiaa","id":733794,"avatar_url":"https://avatars.githubusercontent.com/u/733794?v=2","gravatar_id":"","url":"https://api.github.com/users/AbdullahDiaa","html_url":"https://github.com/AbdullahDiaa","followers_url":"https://api.github.com/users/AbdullahDiaa/followers","following_url":"https://api.github.com/users/AbdullahDiaa/following{/other_user}","gists_url":"https://api.github.com/users/AbdullahDiaa/gists{/gist_id}","starred_url":"https://api.github.com/users/AbdullahDiaa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AbdullahDiaa/subscriptions","organizations_url":"https://api.github.com/users/AbdullahDiaa/orgs","repos_url":"https://api.github.com/users/AbdullahDiaa/repos","events_url":"https://api.github.com/users/AbdullahDiaa/events{/privacy}","received_events_url":"https://api.github.com/users/AbdullahDiaa/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":76,"deletions":15,"changed_files":2}}