GitHub PullRequestReviewCommentEvent at 2014-12-04 10:02:08
Repository: mixxx
Actor: daschuer
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/21294915","id":21294915,"diff_hunk":"@@ -18,18 +20,51 @@ int computeTextureStride(int size) {\n Waveform::Waveform(const QByteArray data)\n         : m_id(-1),\n           m_bDirty(true),\n-          m_numChannels(2),\n           m_dataSize(0),\n           m_visualSampleRate(0),\n-          m_audioVisualRatio(0.),\n+          m_audioVisualRatio(0),\n           m_textureStride(computeTextureStride(0)),\n-          m_completion(-1),\n-          m_mutex(new QMutex()) {\n+          m_completion(-1) {\n     readByteArray(data);","path":"src/waveform/waveform.cpp","position":22,"original_position":22,"commit_id":"a61a72b80ff1ade7ac43630bb85c17a65fc888bc","original_commit_id":"a61a72b80ff1ade7ac43630bb85c17a65fc888bc","user":{"login":"daschuer","id":1777442,"avatar_url":"https://avatars.githubusercontent.com/u/1777442?v=3","gravatar_id":"","url":"https://api.github.com/users/daschuer","html_url":"https://github.com/daschuer","followers_url":"https://api.github.com/users/daschuer/followers","following_url":"https://api.github.com/users/daschuer/following{/other_user}","gists_url":"https://api.github.com/users/daschuer/gists{/gist_id}","starred_url":"https://api.github.com/users/daschuer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daschuer/subscriptions","organizations_url":"https://api.github.com/users/daschuer/orgs","repos_url":"https://api.github.com/users/daschuer/repos","events_url":"https://api.github.com/users/daschuer/events{/privacy}","received_events_url":"https://api.github.com/users/daschuer/received_events","type":"User","site_admin":false},"body":"This call looks odd now with all our other const approaches. \r\nWhat about move this to a factory class, and treat the class  Waveform as pure data storage. \r\n... probably not worth the effort, so never mind.","created_at":"2014-12-04T10:02:08Z","updated_at":"2014-12-04T10:02:08Z","html_url":"https://github.com/mixxxdj/mixxx/pull/420#discussion_r21294915","pull_request_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/420","_links":{"self":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/21294915"},"html":{"href":"https://github.com/mixxxdj/mixxx/pull/420#discussion_r21294915"},"pull_request":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/420"}}},"pull_request":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/420","id":25460541,"html_url":"https://github.com/mixxxdj/mixxx/pull/420","diff_url":"https://github.com/mixxxdj/mixxx/pull/420.diff","patch_url":"https://github.com/mixxxdj/mixxx/pull/420.patch","issue_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/420","number":420,"state":"open","locked":false,"title":"Fix waveform concurrency issues. Possible fix for Bug #1383404","user":{"login":"rryan","id":26527,"avatar_url":"https://avatars.githubusercontent.com/u/26527?v=3","gravatar_id":"","url":"https://api.github.com/users/rryan","html_url":"https://github.com/rryan","followers_url":"https://api.github.com/users/rryan/followers","following_url":"https://api.github.com/users/rryan/following{/other_user}","gists_url":"https://api.github.com/users/rryan/gists{/gist_id}","starred_url":"https://api.github.com/users/rryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rryan/subscriptions","organizations_url":"https://api.github.com/users/rryan/orgs","repos_url":"https://api.github.com/users/rryan/repos","events_url":"https://api.github.com/users/rryan/events{/privacy}","received_events_url":"https://api.github.com/users/rryan/received_events","type":"User","site_admin":false},"body":"* Use const shared pointers for waveforms.\r\n* Move all std::vector sizing operations to the Waveform constructor. No\r\n  vector state is allowed to change after the constructor finishes.\r\n* Clarify comments.\r\n* Remove waveform mutex usage in WOverview variants.\r\n* Use the track's waveform pointer to atomically swap the waveform\r\n  rather than mutating the waveform in place.\r\n* Remove unused code.","created_at":"2014-12-03T23:15:14Z","updated_at":"2014-12-04T10:02:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"db791ae8e8ed5cb2fa4069ccd2dedfc403f2964f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/420/commits","review_comments_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/420/comments","review_comment_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/420/comments","statuses_url":"https://api.github.com/repos/mixxxdj/mixxx/statuses/a61a72b80ff1ade7ac43630bb85c17a65fc888bc","head":{"label":"rryan:waveform","ref":"waveform","sha":"a61a72b80ff1ade7ac43630bb85c17a65fc888bc","user":{"login":"rryan","id":26527,"avatar_url":"https://avatars.githubusercontent.com/u/26527?v=3","gravatar_id":"","url":"https://api.github.com/users/rryan","html_url":"https://github.com/rryan","followers_url":"https://api.github.com/users/rryan/followers","following_url":"https://api.github.com/users/rryan/following{/other_user}","gists_url":"https://api.github.com/users/rryan/gists{/gist_id}","starred_url":"https://api.github.com/users/rryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rryan/subscriptions","organizations_url":"https://api.github.com/users/rryan/orgs","repos_url":"https://api.github.com/users/rryan/repos","events_url":"https://api.github.com/users/rryan/events{/privacy}","received_events_url":"https://api.github.com/users/rryan/received_events","type":"User","site_admin":false},"repo":{"id":10690290,"name":"mixxx","full_name":"rryan/mixxx","owner":{"login":"rryan","id":26527,"avatar_url":"https://avatars.githubusercontent.com/u/26527?v=3","gravatar_id":"","url":"https://api.github.com/users/rryan","html_url":"https://github.com/rryan","followers_url":"https://api.github.com/users/rryan/followers","following_url":"https://api.github.com/users/rryan/following{/other_user}","gists_url":"https://api.github.com/users/rryan/gists{/gist_id}","starred_url":"https://api.github.com/users/rryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rryan/subscriptions","organizations_url":"https://api.github.com/users/rryan/orgs","repos_url":"https://api.github.com/users/rryan/repos","events_url":"https://api.github.com/users/rryan/events{/privacy}","received_events_url":"https://api.github.com/users/rryan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rryan/mixxx","description":"Mixxx is Free DJ software that gives you everything you need to perform live mixes.","fork":true,"url":"https://api.github.com/repos/rryan/mixxx","forks_url":"https://api.github.com/repos/rryan/mixxx/forks","keys_url":"https://api.github.com/repos/rryan/mixxx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rryan/mixxx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rryan/mixxx/teams","hooks_url":"https://api.github.com/repos/rryan/mixxx/hooks","issue_events_url":"https://api.github.com/repos/rryan/mixxx/issues/events{/number}","events_url":"https://api.github.com/repos/rryan/mixxx/events","assignees_url":"https://api.github.com/repos/rryan/mixxx/assignees{/user}","branches_url":"https://api.github.com/repos/rryan/mixxx/branches{/branch}","tags_url":"https://api.github.com/repos/rryan/mixxx/tags","blobs_url":"https://api.github.com/repos/rryan/mixxx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rryan/mixxx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rryan/mixxx/git/refs{/sha}","trees_url":"https://api.github.com/repos/rryan/mixxx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rryan/mixxx/statuses/{sha}","languages_url":"https://api.github.com/repos/rryan/mixxx/languages","stargazers_url":"https://api.github.com/repos/rryan/mixxx/stargazers","contributors_url":"https://api.github.com/repos/rryan/mixxx/contributors","subscribers_url":"https://api.github.com/repos/rryan/mixxx/subscribers","subscription_url":"https://api.github.com/repos/rryan/mixxx/subscription","commits_url":"https://api.github.com/repos/rryan/mixxx/commits{/sha}","git_commits_url":"https://api.github.com/repos/rryan/mixxx/git/commits{/sha}","comments_url":"https://api.github.com/repos/rryan/mixxx/comments{/number}","issue_comment_url":"https://api.github.com/repos/rryan/mixxx/issues/comments/{number}","contents_url":"https://api.github.com/repos/rryan/mixxx/contents/{+path}","compare_url":"https://api.github.com/repos/rryan/mixxx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rryan/mixxx/merges","archive_url":"https://api.github.com/repos/rryan/mixxx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rryan/mixxx/downloads","issues_url":"https://api.github.com/repos/rryan/mixxx/issues{/number}","pulls_url":"https://api.github.com/repos/rryan/mixxx/pulls{/number}","milestones_url":"https://api.github.com/repos/rryan/mixxx/milestones{/number}","notifications_url":"https://api.github.com/repos/rryan/mixxx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rryan/mixxx/labels{/name}","releases_url":"https://api.github.com/repos/rryan/mixxx/releases{/id}","created_at":"2013-06-14T14:11:10Z","updated_at":"2014-09-27T19:25:20Z","pushed_at":"2014-12-04T03:58:08Z","git_url":"git://github.com/rryan/mixxx.git","ssh_url":"git@github.com:rryan/mixxx.git","clone_url":"https://github.com/rryan/mixxx.git","svn_url":"https://github.com/rryan/mixxx","homepage":"http://mixxx.org","size":245577,"stargazers_count":1,"watchers_count":1,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"mixxxdj:master","ref":"master","sha":"974461056518bc894cb98df116a0f24c152d4193","user":{"login":"mixxxdj","id":1743769,"avatar_url":"https://avatars.githubusercontent.com/u/1743769?v=3","gravatar_id":"","url":"https://api.github.com/users/mixxxdj","html_url":"https://github.com/mixxxdj","followers_url":"https://api.github.com/users/mixxxdj/followers","following_url":"https://api.github.com/users/mixxxdj/following{/other_user}","gists_url":"https://api.github.com/users/mixxxdj/gists{/gist_id}","starred_url":"https://api.github.com/users/mixxxdj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixxxdj/subscriptions","organizations_url":"https://api.github.com/users/mixxxdj/orgs","repos_url":"https://api.github.com/users/mixxxdj/repos","events_url":"https://api.github.com/users/mixxxdj/events{/privacy}","received_events_url":"https://api.github.com/users/mixxxdj/received_events","type":"Organization","site_admin":false},"repo":{"id":10126031,"name":"mixxx","full_name":"mixxxdj/mixxx","owner":{"login":"mixxxdj","id":1743769,"avatar_url":"https://avatars.githubusercontent.com/u/1743769?v=3","gravatar_id":"","url":"https://api.github.com/users/mixxxdj","html_url":"https://github.com/mixxxdj","followers_url":"https://api.github.com/users/mixxxdj/followers","following_url":"https://api.github.com/users/mixxxdj/following{/other_user}","gists_url":"https://api.github.com/users/mixxxdj/gists{/gist_id}","starred_url":"https://api.github.com/users/mixxxdj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixxxdj/subscriptions","organizations_url":"https://api.github.com/users/mixxxdj/orgs","repos_url":"https://api.github.com/users/mixxxdj/repos","events_url":"https://api.github.com/users/mixxxdj/events{/privacy}","received_events_url":"https://api.github.com/users/mixxxdj/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mixxxdj/mixxx","description":"Mixxx is Free DJ software that gives you everything you need to perform live mixes.","fork":false,"url":"https://api.github.com/repos/mixxxdj/mixxx","forks_url":"https://api.github.com/repos/mixxxdj/mixxx/forks","keys_url":"https://api.github.com/repos/mixxxdj/mixxx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mixxxdj/mixxx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mixxxdj/mixxx/teams","hooks_url":"https://api.github.com/repos/mixxxdj/mixxx/hooks","issue_events_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/events{/number}","events_url":"https://api.github.com/repos/mixxxdj/mixxx/events","assignees_url":"https://api.github.com/repos/mixxxdj/mixxx/assignees{/user}","branches_url":"https://api.github.com/repos/mixxxdj/mixxx/branches{/branch}","tags_url":"https://api.github.com/repos/mixxxdj/mixxx/tags","blobs_url":"https://api.github.com/repos/mixxxdj/mixxx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mixxxdj/mixxx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mixxxdj/mixxx/git/refs{/sha}","trees_url":"https://api.github.com/repos/mixxxdj/mixxx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mixxxdj/mixxx/statuses/{sha}","languages_url":"https://api.github.com/repos/mixxxdj/mixxx/languages","stargazers_url":"https://api.github.com/repos/mixxxdj/mixxx/stargazers","contributors_url":"https://api.github.com/repos/mixxxdj/mixxx/contributors","subscribers_url":"https://api.github.com/repos/mixxxdj/mixxx/subscribers","subscription_url":"https://api.github.com/repos/mixxxdj/mixxx/subscription","commits_url":"https://api.github.com/repos/mixxxdj/mixxx/commits{/sha}","git_commits_url":"https://api.github.com/repos/mixxxdj/mixxx/git/commits{/sha}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/comments{/number}","issue_comment_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/comments/{number}","contents_url":"https://api.github.com/repos/mixxxdj/mixxx/contents/{+path}","compare_url":"https://api.github.com/repos/mixxxdj/mixxx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mixxxdj/mixxx/merges","archive_url":"https://api.github.com/repos/mixxxdj/mixxx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mixxxdj/mixxx/downloads","issues_url":"https://api.github.com/repos/mixxxdj/mixxx/issues{/number}","pulls_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls{/number}","milestones_url":"https://api.github.com/repos/mixxxdj/mixxx/milestones{/number}","notifications_url":"https://api.github.com/repos/mixxxdj/mixxx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mixxxdj/mixxx/labels{/name}","releases_url":"https://api.github.com/repos/mixxxdj/mixxx/releases{/id}","created_at":"2013-05-17T15:14:38Z","updated_at":"2014-12-04T01:30:13Z","pushed_at":"2014-12-04T01:30:13Z","git_url":"git://github.com/mixxxdj/mixxx.git","ssh_url":"git@github.com:mixxxdj/mixxx.git","clone_url":"https://github.com/mixxxdj/mixxx.git","svn_url":"https://github.com/mixxxdj/mixxx","homepage":"http://mixxx.org","size":304427,"stargazers_count":207,"watchers_count":207,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":167,"mirror_url":null,"open_issues_count":26,"forks":167,"open_issues":26,"watchers":207,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/420"},"html":{"href":"https://github.com/mixxxdj/mixxx/pull/420"},"issue":{"href":"https://api.github.com/repos/mixxxdj/mixxx/issues/420"},"comments":{"href":"https://api.github.com/repos/mixxxdj/mixxx/issues/420/comments"},"review_comments":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/420/comments"},"review_comment":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/420/commits"},"statuses":{"href":"https://api.github.com/repos/mixxxdj/mixxx/statuses/a61a72b80ff1ade7ac43630bb85c17a65fc888bc"}}}}