GitHub PullRequestReviewCommentEvent at 2014-03-17 03:11:09
Repository: angular.dart
Actor: chalin
Payload: {"comment":{"url":"https://api.github.com/repos/angular/angular.dart/pulls/comments/10644539","id":10644539,"diff_hunk":"@@ -79,40 +79,48 @@ Before you submit your pull request consider the following guidelines:\n      git checkout -b my-fix-branch master\n      ```\n \n-* Create your patch, including appropriate test cases.\n-* Follow our [Coding Rules](#coding-rules)\n-* Commit your changes and create a descriptive commit message (the\n-  commit message is used to generate release notes, please check out our\n-  [commit message conventions](#commit-message-format) and our commit message presubmit hook\n-  `validate-commit-msg.js`):\n+* Create your patch, **including appropriate test cases**.\n+* Follow our [Coding Rules](#coding-rules).\n+* Run the full AngularDart test suite, as described in the [developer documentation][dev-doc],\n+  and ensure that all tests pass.\n+* Commit your changes using a descriptive commit message that follows our\n+  [commit message conventions](#commit-message-format) and passes our commit message presubmit hook\n+  `validate-commit-msg.js`. Adherence to the [commit message conventions](#commit-message-format)\n+  is required because release notes are automatically generated from these messages.\n \n      ```shell\n      git commit -a\n      ```\n-\n-* Build your changes locally to ensure all the tests pass: see the [developer documentation][dev-doc].\n-\n-* Push your branch to Github:\n+  Note: the optional commit `-a` command line option will automatically \"add\" and \"rm\" edited files.\n+* Push your branch to GitHub:\n \n     ```shell\n     git push origin my-fix-branch\n     ```\n \n-* In Github, send a pull request to `angular:master`.\n-* If we suggest changes then you can modify your branch, rebase and force a new push to your GitHub\n-  repository to update the Pull Request:\n+* In GitHub, send a pull request to `angular:master`.\n+* If we suggest changes then \n+  * Make the required updates.\n+  * Re-run the AngularDart test suite to ensure tests are still passing.\n+  * Rebase your branch and force push to your GitHub repository (this will update your Pull Request):\n \n     ```shell\n     git rebase master -i\n     git push -f\n     ```\n+* If there are several rounds of reviews and commits, and we ask you to _squash_ your multiple","path":"CONTRIBUTING.md","position":63,"original_position":63,"commit_id":"c95c0ef7498c92f6102c9112c95c85c68ec3ae0b","original_commit_id":"c95c0ef7498c92f6102c9112c95c85c68ec3ae0b","user":{"login":"chalin","id":4140793,"avatar_url":"https://gravatar.com/avatar/c735441a8f71994ab500ce5e599b7fda?d=https%3A%2F%2Fidenticons.github.com%2F7fc0659b4ffdfef6cc13af2565d6b1dc.png&r=x","gravatar_id":"c735441a8f71994ab500ce5e599b7fda","url":"https://api.github.com/users/chalin","html_url":"https://github.com/chalin","followers_url":"https://api.github.com/users/chalin/followers","following_url":"https://api.github.com/users/chalin/following{/other_user}","gists_url":"https://api.github.com/users/chalin/gists{/gist_id}","starred_url":"https://api.github.com/users/chalin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chalin/subscriptions","organizations_url":"https://api.github.com/users/chalin/orgs","repos_url":"https://api.github.com/users/chalin/repos","events_url":"https://api.github.com/users/chalin/events{/privacy}","received_events_url":"https://api.github.com/users/chalin/received_events","type":"User","site_admin":false},"body":"If I recall correctly, the last time I tried `git rebase -i` it didn't work because I didn't have any commits to rebase. Hence the possible need for an extra step in that case.","created_at":"2014-03-17T03:11:09Z","updated_at":"2014-03-17T03:11:09Z","html_url":"https://github.com/angular/angular.dart/pull/740#discussion_r10644539","pull_request_url":"https://api.github.com/repos/angular/angular.dart/pulls/740","_links":{"self":{"href":"https://api.github.com/repos/angular/angular.dart/pulls/comments/10644539"},"html":{"href":"https://github.com/angular/angular.dart/pull/740#discussion_r10644539"},"pull_request":{"href":"https://api.github.com/repos/angular/angular.dart/pulls/740"}}}}