GitHub PullRequestEvent at 2014-07-04 07:28:20
Repository: scala
Actor: adriaanm
Payload: {"action":"closed","number":3752,"pull_request":{"url":"https://api.github.com/repos/scala/scala/pulls/3752","id":15902332,"html_url":"https://github.com/scala/scala/pull/3752","diff_url":"https://github.com/scala/scala/pull/3752.diff","patch_url":"https://github.com/scala/scala/pull/3752.patch","issue_url":"https://api.github.com/repos/scala/scala/issues/3752","number":3752,"state":"closed","title":"SI-8589 Performance improvement for ArrayCharSequence.toString","user":{"login":"jeroentervoorde","id":3625507,"avatar_url":"https://avatars.githubusercontent.com/u/3625507?","gravatar_id":"96361395eba6802b146c2e939d7c19cd","url":"https://api.github.com/users/jeroentervoorde","html_url":"https://github.com/jeroentervoorde","followers_url":"https://api.github.com/users/jeroentervoorde/followers","following_url":"https://api.github.com/users/jeroentervoorde/following{/other_user}","gists_url":"https://api.github.com/users/jeroentervoorde/gists{/gist_id}","starred_url":"https://api.github.com/users/jeroentervoorde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeroentervoorde/subscriptions","organizations_url":"https://api.github.com/users/jeroentervoorde/orgs","repos_url":"https://api.github.com/users/jeroentervoorde/repos","events_url":"https://api.github.com/users/jeroentervoorde/events{/privacy}","received_events_url":"https://api.github.com/users/jeroentervoorde/received_events","type":"User","site_admin":false},"body":"While using a csv parser to process large char arrays i ran into the problem that the toString method of ArrayCharSequence was very slow on large buffers (and, as it appears, also on small buffers)\r\nThe problematic method:\r\noverride def toString = xs drop start take length mkString \"\"\r\n\r\nI created a faster version which is already almost 50% faster on an empty charsequence and only becomes relatively faster when the array gets bigger.\r\n\r\nSee https://issues.scala-lang.org/browse/SI-8589","created_at":"2014-05-14T20:48:01Z","updated_at":"2014-07-04T07:28:19Z","closed_at":"2014-07-04T07:28:19Z","merged_at":"2014-07-04T07:28:19Z","merge_commit_sha":"4dbe4f5fa939c6174f055b7b8032ab77b2e43c08","assignee":{"login":"Ichoran","id":2298644,"avatar_url":"https://avatars.githubusercontent.com/u/2298644?","gravatar_id":"3698349ad0b898d398a6573f4d1f867a","url":"https://api.github.com/users/Ichoran","html_url":"https://github.com/Ichoran","followers_url":"https://api.github.com/users/Ichoran/followers","following_url":"https://api.github.com/users/Ichoran/following{/other_user}","gists_url":"https://api.github.com/users/Ichoran/gists{/gist_id}","starred_url":"https://api.github.com/users/Ichoran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ichoran/subscriptions","organizations_url":"https://api.github.com/users/Ichoran/orgs","repos_url":"https://api.github.com/users/Ichoran/repos","events_url":"https://api.github.com/users/Ichoran/events{/privacy}","received_events_url":"https://api.github.com/users/Ichoran/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/scala/scala/milestones/29","labels_url":"https://api.github.com/repos/scala/scala/milestones/29/labels","id":542603,"number":29,"title":"2.10.5","description":"Merge to 2.10.x\r\n\r\n(Release Oct 6. PR queue closes Sep 26.)","creator":{"login":"retronym","id":65551,"avatar_url":"https://avatars.githubusercontent.com/u/65551?","gravatar_id":"5df8faf17a57ccab478a9b8056862fc3","url":"https://api.github.com/users/retronym","html_url":"https://github.com/retronym","followers_url":"https://api.github.com/users/retronym/followers","following_url":"https://api.github.com/users/retronym/following{/other_user}","gists_url":"https://api.github.com/users/retronym/gists{/gist_id}","starred_url":"https://api.github.com/users/retronym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/retronym/subscriptions","organizations_url":"https://api.github.com/users/retronym/orgs","repos_url":"https://api.github.com/users/retronym/repos","events_url":"https://api.github.com/users/retronym/events{/privacy}","received_events_url":"https://api.github.com/users/retronym/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":4,"state":"open","created_at":"2014-01-21T11:57:51Z","updated_at":"2014-07-04T07:28:19Z","due_on":"2014-09-26T07:00:00Z"},"commits_url":"https://api.github.com/repos/scala/scala/pulls/3752/commits","review_comments_url":"https://api.github.com/repos/scala/scala/pulls/3752/comments","review_comment_url":"https://api.github.com/repos/scala/scala/pulls/comments/{number}","comments_url":"https://api.github.com/repos/scala/scala/issues/3752/comments","statuses_url":"https://api.github.com/repos/scala/scala/statuses/099a426dd6a176e704f47ed665669bf093a6d3f6","head":{"label":"jeroentervoorde:SI_8589","ref":"SI_8589","sha":"099a426dd6a176e704f47ed665669bf093a6d3f6","user":{"login":"jeroentervoorde","id":3625507,"avatar_url":"https://avatars.githubusercontent.com/u/3625507?","gravatar_id":"96361395eba6802b146c2e939d7c19cd","url":"https://api.github.com/users/jeroentervoorde","html_url":"https://github.com/jeroentervoorde","followers_url":"https://api.github.com/users/jeroentervoorde/followers","following_url":"https://api.github.com/users/jeroentervoorde/following{/other_user}","gists_url":"https://api.github.com/users/jeroentervoorde/gists{/gist_id}","starred_url":"https://api.github.com/users/jeroentervoorde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeroentervoorde/subscriptions","organizations_url":"https://api.github.com/users/jeroentervoorde/orgs","repos_url":"https://api.github.com/users/jeroentervoorde/repos","events_url":"https://api.github.com/users/jeroentervoorde/events{/privacy}","received_events_url":"https://api.github.com/users/jeroentervoorde/received_events","type":"User","site_admin":false},"repo":{"id":19793773,"name":"scala","full_name":"jeroentervoorde/scala","owner":{"login":"jeroentervoorde","id":3625507,"avatar_url":"https://avatars.githubusercontent.com/u/3625507?","gravatar_id":"96361395eba6802b146c2e939d7c19cd","url":"https://api.github.com/users/jeroentervoorde","html_url":"https://github.com/jeroentervoorde","followers_url":"https://api.github.com/users/jeroentervoorde/followers","following_url":"https://api.github.com/users/jeroentervoorde/following{/other_user}","gists_url":"https://api.github.com/users/jeroentervoorde/gists{/gist_id}","starred_url":"https://api.github.com/users/jeroentervoorde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeroentervoorde/subscriptions","organizations_url":"https://api.github.com/users/jeroentervoorde/orgs","repos_url":"https://api.github.com/users/jeroentervoorde/repos","events_url":"https://api.github.com/users/jeroentervoorde/events{/privacy}","received_events_url":"https://api.github.com/users/jeroentervoorde/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jeroentervoorde/scala","description":"The Scala programming language","fork":true,"url":"https://api.github.com/repos/jeroentervoorde/scala","forks_url":"https://api.github.com/repos/jeroentervoorde/scala/forks","keys_url":"https://api.github.com/repos/jeroentervoorde/scala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeroentervoorde/scala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeroentervoorde/scala/teams","hooks_url":"https://api.github.com/repos/jeroentervoorde/scala/hooks","issue_events_url":"https://api.github.com/repos/jeroentervoorde/scala/issues/events{/number}","events_url":"https://api.github.com/repos/jeroentervoorde/scala/events","assignees_url":"https://api.github.com/repos/jeroentervoorde/scala/assignees{/user}","branches_url":"https://api.github.com/repos/jeroentervoorde/scala/branches{/branch}","tags_url":"https://api.github.com/repos/jeroentervoorde/scala/tags","blobs_url":"https://api.github.com/repos/jeroentervoorde/scala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeroentervoorde/scala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeroentervoorde/scala/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeroentervoorde/scala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeroentervoorde/scala/statuses/{sha}","languages_url":"https://api.github.com/repos/jeroentervoorde/scala/languages","stargazers_url":"https://api.github.com/repos/jeroentervoorde/scala/stargazers","contributors_url":"https://api.github.com/repos/jeroentervoorde/scala/contributors","subscribers_url":"https://api.github.com/repos/jeroentervoorde/scala/subscribers","subscription_url":"https://api.github.com/repos/jeroentervoorde/scala/subscription","commits_url":"https://api.github.com/repos/jeroentervoorde/scala/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeroentervoorde/scala/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeroentervoorde/scala/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeroentervoorde/scala/issues/comments/{number}","contents_url":"https://api.github.com/repos/jeroentervoorde/scala/contents/{+path}","compare_url":"https://api.github.com/repos/jeroentervoorde/scala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeroentervoorde/scala/merges","archive_url":"https://api.github.com/repos/jeroentervoorde/scala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeroentervoorde/scala/downloads","issues_url":"https://api.github.com/repos/jeroentervoorde/scala/issues{/number}","pulls_url":"https://api.github.com/repos/jeroentervoorde/scala/pulls{/number}","milestones_url":"https://api.github.com/repos/jeroentervoorde/scala/milestones{/number}","notifications_url":"https://api.github.com/repos/jeroentervoorde/scala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeroentervoorde/scala/labels{/name}","releases_url":"https://api.github.com/repos/jeroentervoorde/scala/releases{/id}","created_at":"2014-05-14T19:47:53Z","updated_at":"2014-06-19T20:08:01Z","pushed_at":"2014-06-19T20:08:01Z","git_url":"git://github.com/jeroentervoorde/scala.git","ssh_url":"git@github.com:jeroentervoorde/scala.git","clone_url":"https://github.com/jeroentervoorde/scala.git","svn_url":"https://github.com/jeroentervoorde/scala","homepage":"http://www.scala-lang.org/","size":77939,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"2.12.x"}},"base":{"label":"scala:2.10.x","ref":"2.10.x","sha":"300db2a1e3eefc2a6ed379c870bc7da42a26e69a","user":{"login":"scala","id":57059,"avatar_url":"https://avatars.githubusercontent.com/u/57059?","gravatar_id":"034ea19230dbc7c67b487e6ba64127f0","url":"https://api.github.com/users/scala","html_url":"https://github.com/scala","followers_url":"https://api.github.com/users/scala/followers","following_url":"https://api.github.com/users/scala/following{/other_user}","gists_url":"https://api.github.com/users/scala/gists{/gist_id}","starred_url":"https://api.github.com/users/scala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scala/subscriptions","organizations_url":"https://api.github.com/users/scala/orgs","repos_url":"https://api.github.com/users/scala/repos","events_url":"https://api.github.com/users/scala/events{/privacy}","received_events_url":"https://api.github.com/users/scala/received_events","type":"Organization","site_admin":false},"repo":{"id":2888818,"name":"scala","full_name":"scala/scala","owner":{"login":"scala","id":57059,"avatar_url":"https://avatars.githubusercontent.com/u/57059?","gravatar_id":"034ea19230dbc7c67b487e6ba64127f0","url":"https://api.github.com/users/scala","html_url":"https://github.com/scala","followers_url":"https://api.github.com/users/scala/followers","following_url":"https://api.github.com/users/scala/following{/other_user}","gists_url":"https://api.github.com/users/scala/gists{/gist_id}","starred_url":"https://api.github.com/users/scala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scala/subscriptions","organizations_url":"https://api.github.com/users/scala/orgs","repos_url":"https://api.github.com/users/scala/repos","events_url":"https://api.github.com/users/scala/events{/privacy}","received_events_url":"https://api.github.com/users/scala/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scala/scala","description":"The Scala programming language","fork":false,"url":"https://api.github.com/repos/scala/scala","forks_url":"https://api.github.com/repos/scala/scala/forks","keys_url":"https://api.github.com/repos/scala/scala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scala/scala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scala/scala/teams","hooks_url":"https://api.github.com/repos/scala/scala/hooks","issue_events_url":"https://api.github.com/repos/scala/scala/issues/events{/number}","events_url":"https://api.github.com/repos/scala/scala/events","assignees_url":"https://api.github.com/repos/scala/scala/assignees{/user}","branches_url":"https://api.github.com/repos/scala/scala/branches{/branch}","tags_url":"https://api.github.com/repos/scala/scala/tags","blobs_url":"https://api.github.com/repos/scala/scala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scala/scala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scala/scala/git/refs{/sha}","trees_url":"https://api.github.com/repos/scala/scala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scala/scala/statuses/{sha}","languages_url":"https://api.github.com/repos/scala/scala/languages","stargazers_url":"https://api.github.com/repos/scala/scala/stargazers","contributors_url":"https://api.github.com/repos/scala/scala/contributors","subscribers_url":"https://api.github.com/repos/scala/scala/subscribers","subscription_url":"https://api.github.com/repos/scala/scala/subscription","commits_url":"https://api.github.com/repos/scala/scala/commits{/sha}","git_commits_url":"https://api.github.com/repos/scala/scala/git/commits{/sha}","comments_url":"https://api.github.com/repos/scala/scala/comments{/number}","issue_comment_url":"https://api.github.com/repos/scala/scala/issues/comments/{number}","contents_url":"https://api.github.com/repos/scala/scala/contents/{+path}","compare_url":"https://api.github.com/repos/scala/scala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scala/scala/merges","archive_url":"https://api.github.com/repos/scala/scala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scala/scala/downloads","issues_url":"https://api.github.com/repos/scala/scala/issues{/number}","pulls_url":"https://api.github.com/repos/scala/scala/pulls{/number}","milestones_url":"https://api.github.com/repos/scala/scala/milestones{/number}","notifications_url":"https://api.github.com/repos/scala/scala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scala/scala/labels{/name}","releases_url":"https://api.github.com/repos/scala/scala/releases{/id}","created_at":"2011-12-01T05:02:34Z","updated_at":"2014-07-04T05:32:24Z","pushed_at":"2014-07-04T07:28:20Z","git_url":"git://github.com/scala/scala.git","ssh_url":"git@github.com:scala/scala.git","clone_url":"https://github.com/scala/scala.git","svn_url":"https://github.com/scala/scala","homepage":"http://www.scala-lang.org/","size":170404,"stargazers_count":2636,"watchers_count":2636,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":734,"mirror_url":null,"open_issues_count":28,"forks":734,"open_issues":28,"watchers":2636,"default_branch":"2.12.x"}},"_links":{"self":{"href":"https://api.github.com/repos/scala/scala/pulls/3752"},"html":{"href":"https://github.com/scala/scala/pull/3752"},"issue":{"href":"https://api.github.com/repos/scala/scala/issues/3752"},"comments":{"href":"https://api.github.com/repos/scala/scala/issues/3752/comments"},"review_comments":{"href":"https://api.github.com/repos/scala/scala/pulls/3752/comments"},"review_comment":{"href":"https://api.github.com/repos/scala/scala/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/scala/scala/pulls/3752/commits"},"statuses":{"href":"https://api.github.com/repos/scala/scala/statuses/099a426dd6a176e704f47ed665669bf093a6d3f6"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"adriaanm","id":91083,"avatar_url":"https://avatars.githubusercontent.com/u/91083?","gravatar_id":"d573d4b8a6bd9e2f41611d8d566c533e","url":"https://api.github.com/users/adriaanm","html_url":"https://github.com/adriaanm","followers_url":"https://api.github.com/users/adriaanm/followers","following_url":"https://api.github.com/users/adriaanm/following{/other_user}","gists_url":"https://api.github.com/users/adriaanm/gists{/gist_id}","starred_url":"https://api.github.com/users/adriaanm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriaanm/subscriptions","organizations_url":"https://api.github.com/users/adriaanm/orgs","repos_url":"https://api.github.com/users/adriaanm/repos","events_url":"https://api.github.com/users/adriaanm/events{/privacy}","received_events_url":"https://api.github.com/users/adriaanm/received_events","type":"User","site_admin":false},"comments":12,"review_comments":2,"commits":1,"additions":6,"deletions":1,"changed_files":1}}