GitHub PullRequestReviewCommentEvent at 2014-06-27 11:32:10
Repository: node
Actor: bnoordhuis
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/joyent/node/pulls/comments/14288647","id":14288647,"diff_hunk":"@@ -0,0 +1,270 @@\n+# Copyright (c) IBM Corporation and Others. All Rights Reserved.\n+# very loosely based on icu.gyp from Chromium\n+# Copyright (c) 2012 The Chromium Authors. All rights reserved.\n+# Use of this source code is governed by a BSD-style license that can be\n+# found in the LICENSE file.\n+\n+\n+{\n+  # hard-coded for now. move to config.gypi?\n+  'variables': { 'icu_UCONFIG_NO_LEGACY_CONVERSION' : 1,\n+                 'icu_UCONFIG_NO_IDNA': 1,\n+                 'icu_UCONFIG_NO_BREAK_ITERATION' : 0,\n+                 'icu_UCONFIG_NO_TRANSLITERATION' : 1,","path":"deps/icu-generic-win.gyp","position":13,"original_position":13,"commit_id":"0d5f74250c668aa64eafa82aaec9ffac0b7d56a2","original_commit_id":"2ebeb4ee39f8079d9a3fa363a9178d0423a7d70c","user":{"login":"bnoordhuis","id":275871,"avatar_url":"https://avatars.githubusercontent.com/u/275871?","gravatar_id":"3d43d9038ab645ecb2e3a1df2951d30a","url":"https://api.github.com/users/bnoordhuis","html_url":"https://github.com/bnoordhuis","followers_url":"https://api.github.com/users/bnoordhuis/followers","following_url":"https://api.github.com/users/bnoordhuis/following{/other_user}","gists_url":"https://api.github.com/users/bnoordhuis/gists{/gist_id}","starred_url":"https://api.github.com/users/bnoordhuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnoordhuis/subscriptions","organizations_url":"https://api.github.com/users/bnoordhuis/orgs","repos_url":"https://api.github.com/users/bnoordhuis/repos","events_url":"https://api.github.com/users/bnoordhuis/events{/privacy}","received_events_url":"https://api.github.com/users/bnoordhuis/received_events","type":"User","site_admin":false},"body":"Good to know, thanks.  I use transliteration a lot with node-iconv and I imagine I'm not the only one.  Would be great to have it in core someday.","created_at":"2014-06-27T11:32:10Z","updated_at":"2014-06-27T11:32:10Z","html_url":"https://github.com/joyent/node/pull/7719#discussion_r14288647","pull_request_url":"https://api.github.com/repos/joyent/node/pulls/7719","_links":{"self":{"href":"https://api.github.com/repos/joyent/node/pulls/comments/14288647"},"html":{"href":"https://github.com/joyent/node/pull/7719#discussion_r14288647"},"pull_request":{"href":"https://api.github.com/repos/joyent/node/pulls/7719"}}},"pull_request":{"url":"https://api.github.com/repos/joyent/node/pulls/7719","id":16624608,"html_url":"https://github.com/joyent/node/pull/7719","diff_url":"https://github.com/joyent/node/pull/7719.diff","patch_url":"https://github.com/joyent/node/pull/7719.patch","issue_url":"https://api.github.com/repos/joyent/node/issues/7719","number":7719,"state":"open","title":"build: enable a smaller Intl (i18n / ICU) build","user":{"login":"srl295","id":855219,"avatar_url":"https://avatars.githubusercontent.com/u/855219?","gravatar_id":"94a290285ee4431dfc2f89e66315f24c","url":"https://api.github.com/users/srl295","html_url":"https://github.com/srl295","followers_url":"https://api.github.com/users/srl295/followers","following_url":"https://api.github.com/users/srl295/following{/other_user}","gists_url":"https://api.github.com/users/srl295/gists{/gist_id}","starred_url":"https://api.github.com/users/srl295/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srl295/subscriptions","organizations_url":"https://api.github.com/users/srl295/orgs","repos_url":"https://api.github.com/users/srl295/repos","events_url":"https://api.github.com/users/srl295/events{/privacy}","received_events_url":"https://api.github.com/users/srl295/received_events","type":"User","site_admin":false},"body":"Implements joyent/node#7676 - see `README.md` for details.\r\n\r\nPasses `make test` *as well as* current HEAD did (some network test failures?)\r\n\r\nknown TODOs:\r\n- doc\r\n  - [ ] Too much detail in the `README.md`. Move elsewhere/delete. \r\n- build\r\n  - [x] Windows build? Rewrite `icu-generic.sh` in python and/or use cygwin?\r\n      - [x] but, need to allow build of linked-in ICU data (large and small) in windows.\r\n  - [x] Switch to turn on and off \"little by default\"\r\n  - [ ] Enable use of any ICU (not just special SRL branch) - will probably do this by\r\n      - [ ] copying iculslocs.c and icutrim.py into node\r\n      - [ ] making the unixy build work the same way as windows.\r\n      - [ ] update the instructions to say \"grab an ICU tarball, unpack as `deps/icu`, enjoy\"\r\n- v8 ( discussion here: https://groups.google.com/forum/#!topic/v8-dev/uAdEzPBcdXE ) \r\n  - [x] need `InitializeICU` function https://code.google.com/p/v8/issues/detail?id=3344  ( workaround: could call the ICU functions directly from node..    )  *Update: v8's preference may be that node call into ICU directly here for setup. Fine, I can move that code out of deps/v8 and into node.cc or elsewhere. *\r\n  - [x] bug fixes to v8  https://code.google.com/p/v8/issues/detail?id=3348  *not a hard dependency, I can take this out of the PR*\r\n  - [x] Save 1M by turning off breakiterator if unneeded https://code.google.com/p/v8/issues/detail?id=3345   *This saves 1M - but can pull it out of the PR also. *\r\n- ICU\r\n    - [ ] the \"smaller ICU\" changes could be pushed into a future ICU version. (already have bugs filed for this, not a blocker here)\r\n\r\nNB: I have signed the CLA, you will find me under `srloomis` at US dot IBM dot COM","created_at":"2014-06-02T21:51:48Z","updated_at":"2014-06-27T11:32:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"caece2dd1797671a4edb3710b8f3e679172f27b6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/joyent/node/pulls/7719/commits","review_comments_url":"https://api.github.com/repos/joyent/node/pulls/7719/comments","review_comment_url":"https://api.github.com/repos/joyent/node/pulls/comments/{number}","comments_url":"https://api.github.com/repos/joyent/node/issues/7719/comments","statuses_url":"https://api.github.com/repos/joyent/node/statuses/0d5f74250c668aa64eafa82aaec9ffac0b7d56a2","head":{"label":"srl295:smaller-icu","ref":"smaller-icu","sha":"0d5f74250c668aa64eafa82aaec9ffac0b7d56a2","user":{"login":"srl295","id":855219,"avatar_url":"https://avatars.githubusercontent.com/u/855219?","gravatar_id":"94a290285ee4431dfc2f89e66315f24c","url":"https://api.github.com/users/srl295","html_url":"https://github.com/srl295","followers_url":"https://api.github.com/users/srl295/followers","following_url":"https://api.github.com/users/srl295/following{/other_user}","gists_url":"https://api.github.com/users/srl295/gists{/gist_id}","starred_url":"https://api.github.com/users/srl295/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srl295/subscriptions","organizations_url":"https://api.github.com/users/srl295/orgs","repos_url":"https://api.github.com/users/srl295/repos","events_url":"https://api.github.com/users/srl295/events{/privacy}","received_events_url":"https://api.github.com/users/srl295/received_events","type":"User","site_admin":false},"repo":{"id":11932918,"name":"node","full_name":"srl295/node","owner":{"login":"srl295","id":855219,"avatar_url":"https://avatars.githubusercontent.com/u/855219?","gravatar_id":"94a290285ee4431dfc2f89e66315f24c","url":"https://api.github.com/users/srl295","html_url":"https://github.com/srl295","followers_url":"https://api.github.com/users/srl295/followers","following_url":"https://api.github.com/users/srl295/following{/other_user}","gists_url":"https://api.github.com/users/srl295/gists{/gist_id}","starred_url":"https://api.github.com/users/srl295/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srl295/subscriptions","organizations_url":"https://api.github.com/users/srl295/orgs","repos_url":"https://api.github.com/users/srl295/repos","events_url":"https://api.github.com/users/srl295/events{/privacy}","received_events_url":"https://api.github.com/users/srl295/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/srl295/node","description":"evented I/O for v8 javascript","fork":true,"url":"https://api.github.com/repos/srl295/node","forks_url":"https://api.github.com/repos/srl295/node/forks","keys_url":"https://api.github.com/repos/srl295/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/srl295/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/srl295/node/teams","hooks_url":"https://api.github.com/repos/srl295/node/hooks","issue_events_url":"https://api.github.com/repos/srl295/node/issues/events{/number}","events_url":"https://api.github.com/repos/srl295/node/events","assignees_url":"https://api.github.com/repos/srl295/node/assignees{/user}","branches_url":"https://api.github.com/repos/srl295/node/branches{/branch}","tags_url":"https://api.github.com/repos/srl295/node/tags","blobs_url":"https://api.github.com/repos/srl295/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/srl295/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/srl295/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/srl295/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/srl295/node/statuses/{sha}","languages_url":"https://api.github.com/repos/srl295/node/languages","stargazers_url":"https://api.github.com/repos/srl295/node/stargazers","contributors_url":"https://api.github.com/repos/srl295/node/contributors","subscribers_url":"https://api.github.com/repos/srl295/node/subscribers","subscription_url":"https://api.github.com/repos/srl295/node/subscription","commits_url":"https://api.github.com/repos/srl295/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/srl295/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/srl295/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/srl295/node/issues/comments/{number}","contents_url":"https://api.github.com/repos/srl295/node/contents/{+path}","compare_url":"https://api.github.com/repos/srl295/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/srl295/node/merges","archive_url":"https://api.github.com/repos/srl295/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/srl295/node/downloads","issues_url":"https://api.github.com/repos/srl295/node/issues{/number}","pulls_url":"https://api.github.com/repos/srl295/node/pulls{/number}","milestones_url":"https://api.github.com/repos/srl295/node/milestones{/number}","notifications_url":"https://api.github.com/repos/srl295/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/srl295/node/labels{/name}","releases_url":"https://api.github.com/repos/srl295/node/releases{/id}","created_at":"2013-08-06T19:41:52Z","updated_at":"2014-06-27T02:04:24Z","pushed_at":"2014-06-27T02:11:21Z","git_url":"git://github.com/srl295/node.git","ssh_url":"git@github.com:srl295/node.git","clone_url":"https://github.com/srl295/node.git","svn_url":"https://github.com/srl295/node","homepage":"http://nodejs.org/","size":99697,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"smaller-icu"}},"base":{"label":"joyent:master","ref":"master","sha":"1a1b1a75347a4d68aedefb71b8bacce050b1768b","user":{"login":"joyent","id":10161,"avatar_url":"https://avatars.githubusercontent.com/u/10161?","gravatar_id":"95c8b4070c2ba024f87a8fdca63e9d24","url":"https://api.github.com/users/joyent","html_url":"https://github.com/joyent","followers_url":"https://api.github.com/users/joyent/followers","following_url":"https://api.github.com/users/joyent/following{/other_user}","gists_url":"https://api.github.com/users/joyent/gists{/gist_id}","starred_url":"https://api.github.com/users/joyent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joyent/subscriptions","organizations_url":"https://api.github.com/users/joyent/orgs","repos_url":"https://api.github.com/users/joyent/repos","events_url":"https://api.github.com/users/joyent/events{/privacy}","received_events_url":"https://api.github.com/users/joyent/received_events","type":"Organization","site_admin":false},"repo":{"id":211666,"name":"node","full_name":"joyent/node","owner":{"login":"joyent","id":10161,"avatar_url":"https://avatars.githubusercontent.com/u/10161?","gravatar_id":"95c8b4070c2ba024f87a8fdca63e9d24","url":"https://api.github.com/users/joyent","html_url":"https://github.com/joyent","followers_url":"https://api.github.com/users/joyent/followers","following_url":"https://api.github.com/users/joyent/following{/other_user}","gists_url":"https://api.github.com/users/joyent/gists{/gist_id}","starred_url":"https://api.github.com/users/joyent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joyent/subscriptions","organizations_url":"https://api.github.com/users/joyent/orgs","repos_url":"https://api.github.com/users/joyent/repos","events_url":"https://api.github.com/users/joyent/events{/privacy}","received_events_url":"https://api.github.com/users/joyent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joyent/node","description":"evented I/O for v8 javascript","fork":false,"url":"https://api.github.com/repos/joyent/node","forks_url":"https://api.github.com/repos/joyent/node/forks","keys_url":"https://api.github.com/repos/joyent/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joyent/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joyent/node/teams","hooks_url":"https://api.github.com/repos/joyent/node/hooks","issue_events_url":"https://api.github.com/repos/joyent/node/issues/events{/number}","events_url":"https://api.github.com/repos/joyent/node/events","assignees_url":"https://api.github.com/repos/joyent/node/assignees{/user}","branches_url":"https://api.github.com/repos/joyent/node/branches{/branch}","tags_url":"https://api.github.com/repos/joyent/node/tags","blobs_url":"https://api.github.com/repos/joyent/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joyent/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joyent/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/joyent/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joyent/node/statuses/{sha}","languages_url":"https://api.github.com/repos/joyent/node/languages","stargazers_url":"https://api.github.com/repos/joyent/node/stargazers","contributors_url":"https://api.github.com/repos/joyent/node/contributors","subscribers_url":"https://api.github.com/repos/joyent/node/subscribers","subscription_url":"https://api.github.com/repos/joyent/node/subscription","commits_url":"https://api.github.com/repos/joyent/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/joyent/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/joyent/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/joyent/node/issues/comments/{number}","contents_url":"https://api.github.com/repos/joyent/node/contents/{+path}","compare_url":"https://api.github.com/repos/joyent/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joyent/node/merges","archive_url":"https://api.github.com/repos/joyent/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joyent/node/downloads","issues_url":"https://api.github.com/repos/joyent/node/issues{/number}","pulls_url":"https://api.github.com/repos/joyent/node/pulls{/number}","milestones_url":"https://api.github.com/repos/joyent/node/milestones{/number}","notifications_url":"https://api.github.com/repos/joyent/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joyent/node/labels{/name}","releases_url":"https://api.github.com/repos/joyent/node/releases{/id}","created_at":"2009-05-27T16:29:46Z","updated_at":"2014-06-27T11:27:46Z","pushed_at":"2014-06-27T11:00:36Z","git_url":"git://github.com/joyent/node.git","ssh_url":"git@github.com:joyent/node.git","clone_url":"https://github.com/joyent/node.git","svn_url":"https://github.com/joyent/node","homepage":"http://nodejs.org/","size":461224,"stargazers_count":30536,"watchers_count":30536,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":true,"forks_count":6685,"mirror_url":null,"open_issues_count":842,"forks":6685,"open_issues":842,"watchers":30536,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/joyent/node/pulls/7719"},"html":{"href":"https://github.com/joyent/node/pull/7719"},"issue":{"href":"https://api.github.com/repos/joyent/node/issues/7719"},"comments":{"href":"https://api.github.com/repos/joyent/node/issues/7719/comments"},"review_comments":{"href":"https://api.github.com/repos/joyent/node/pulls/7719/comments"},"review_comment":{"href":"https://api.github.com/repos/joyent/node/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/joyent/node/pulls/7719/commits"},"statuses":{"href":"https://api.github.com/repos/joyent/node/statuses/0d5f74250c668aa64eafa82aaec9ffac0b7d56a2"}}}}