GitHub PullRequestReviewCommentEvent at 2014-07-31 11:57:38
Repository: opentsdb
Actor: jzeeck
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/hi3g/opentsdb/pulls/comments/15637861","id":15637861,"diff_hunk":"@@ -185,6 +181,16 @@ public TSDB(final Config config) {\n       }\n     }\n \n+    class HandleNoSuchUniqueNameCB implements Callback<Object, Exception> {\n+      public Object call(final Exception e) {\n+        if (e instanceof NoSuchUniqueName) {\n+          return metrics.createId(metric);\n+        }\n+\n+        return e; // Other unexpected exception, let it bubble up.","path":"src/core/TSDB.java","position":32,"original_position":32,"commit_id":"54f66b2541955a9dd03622b21fce855955253a63","original_commit_id":"c5eda3c1479da356d7a4e51041ad6669736d8ff4","user":{"login":"jzeeck","id":1387446,"avatar_url":"https://avatars.githubusercontent.com/u/1387446?v=1","gravatar_id":"b30f032aca9133e004f7bc964acb8de7","url":"https://api.github.com/users/jzeeck","html_url":"https://github.com/jzeeck","followers_url":"https://api.github.com/users/jzeeck/followers","following_url":"https://api.github.com/users/jzeeck/following{/other_user}","gists_url":"https://api.github.com/users/jzeeck/gists{/gist_id}","starred_url":"https://api.github.com/users/jzeeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jzeeck/subscriptions","organizations_url":"https://api.github.com/users/jzeeck/orgs","repos_url":"https://api.github.com/users/jzeeck/repos","events_url":"https://api.github.com/users/jzeeck/events{/privacy}","received_events_url":"https://api.github.com/users/jzeeck/received_events","type":"User","site_admin":false},"body":"bubble up - very swedish of you","created_at":"2014-07-31T11:57:38Z","updated_at":"2014-07-31T11:57:38Z","html_url":"https://github.com/hi3g/opentsdb/pull/8#discussion_r15637861","pull_request_url":"https://api.github.com/repos/hi3g/opentsdb/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/hi3g/opentsdb/pulls/comments/15637861"},"html":{"href":"https://github.com/hi3g/opentsdb/pull/8#discussion_r15637861"},"pull_request":{"href":"https://api.github.com/repos/hi3g/opentsdb/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/hi3g/opentsdb/pulls/8","id":19140138,"html_url":"https://github.com/hi3g/opentsdb/pull/8","diff_url":"https://github.com/hi3g/opentsdb/pull/8.diff","patch_url":"https://github.com/hi3g/opentsdb/pull/8.patch","issue_url":"https://api.github.com/repos/hi3g/opentsdb/issues/8","number":8,"state":"open","title":"Replace #getOrCreate with separate calls to #get and #create","user":{"login":"luuse","id":111528,"avatar_url":"https://avatars.githubusercontent.com/u/111528?v=1","gravatar_id":"ee3e371deb19803bc535837e5254f67e","url":"https://api.github.com/users/luuse","html_url":"https://github.com/luuse","followers_url":"https://api.github.com/users/luuse/followers","following_url":"https://api.github.com/users/luuse/following{/other_user}","gists_url":"https://api.github.com/users/luuse/gists{/gist_id}","starred_url":"https://api.github.com/users/luuse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luuse/subscriptions","organizations_url":"https://api.github.com/users/luuse/orgs","repos_url":"https://api.github.com/users/luuse/repos","events_url":"https://api.github.com/users/luuse/events{/privacy}","received_events_url":"https://api.github.com/users/luuse/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-07-31T09:11:55Z","updated_at":"2014-07-31T11:57:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8701709413ea77c73dec80b04504e7b1939cb574","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hi3g/opentsdb/pulls/8/commits","review_comments_url":"https://api.github.com/repos/hi3g/opentsdb/pulls/8/comments","review_comment_url":"https://api.github.com/repos/hi3g/opentsdb/pulls/comments/{number}","comments_url":"https://api.github.com/repos/hi3g/opentsdb/issues/8/comments","statuses_url":"https://api.github.com/repos/hi3g/opentsdb/statuses/54f66b2541955a9dd03622b21fce855955253a63","head":{"label":"hi3g:remove_getorcreate","ref":"remove_getorcreate","sha":"54f66b2541955a9dd03622b21fce855955253a63","user":{"login":"hi3g","id":8111300,"avatar_url":"https://avatars.githubusercontent.com/u/8111300?v=1","gravatar_id":null,"url":"https://api.github.com/users/hi3g","html_url":"https://github.com/hi3g","followers_url":"https://api.github.com/users/hi3g/followers","following_url":"https://api.github.com/users/hi3g/following{/other_user}","gists_url":"https://api.github.com/users/hi3g/gists{/gist_id}","starred_url":"https://api.github.com/users/hi3g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hi3g/subscriptions","organizations_url":"https://api.github.com/users/hi3g/orgs","repos_url":"https://api.github.com/users/hi3g/repos","events_url":"https://api.github.com/users/hi3g/events{/privacy}","received_events_url":"https://api.github.com/users/hi3g/received_events","type":"Organization","site_admin":false},"repo":{"id":21644204,"name":"opentsdb","full_name":"hi3g/opentsdb","owner":{"login":"hi3g","id":8111300,"avatar_url":"https://avatars.githubusercontent.com/u/8111300?v=1","gravatar_id":null,"url":"https://api.github.com/users/hi3g","html_url":"https://github.com/hi3g","followers_url":"https://api.github.com/users/hi3g/followers","following_url":"https://api.github.com/users/hi3g/following{/other_user}","gists_url":"https://api.github.com/users/hi3g/gists{/gist_id}","starred_url":"https://api.github.com/users/hi3g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hi3g/subscriptions","organizations_url":"https://api.github.com/users/hi3g/orgs","repos_url":"https://api.github.com/users/hi3g/repos","events_url":"https://api.github.com/users/hi3g/events{/privacy}","received_events_url":"https://api.github.com/users/hi3g/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hi3g/opentsdb","description":"A scalable, distributed Time Series Database.","fork":true,"url":"https://api.github.com/repos/hi3g/opentsdb","forks_url":"https://api.github.com/repos/hi3g/opentsdb/forks","keys_url":"https://api.github.com/repos/hi3g/opentsdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hi3g/opentsdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hi3g/opentsdb/teams","hooks_url":"https://api.github.com/repos/hi3g/opentsdb/hooks","issue_events_url":"https://api.github.com/repos/hi3g/opentsdb/issues/events{/number}","events_url":"https://api.github.com/repos/hi3g/opentsdb/events","assignees_url":"https://api.github.com/repos/hi3g/opentsdb/assignees{/user}","branches_url":"https://api.github.com/repos/hi3g/opentsdb/branches{/branch}","tags_url":"https://api.github.com/repos/hi3g/opentsdb/tags","blobs_url":"https://api.github.com/repos/hi3g/opentsdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hi3g/opentsdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hi3g/opentsdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/hi3g/opentsdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hi3g/opentsdb/statuses/{sha}","languages_url":"https://api.github.com/repos/hi3g/opentsdb/languages","stargazers_url":"https://api.github.com/repos/hi3g/opentsdb/stargazers","contributors_url":"https://api.github.com/repos/hi3g/opentsdb/contributors","subscribers_url":"https://api.github.com/repos/hi3g/opentsdb/subscribers","subscription_url":"https://api.github.com/repos/hi3g/opentsdb/subscription","commits_url":"https://api.github.com/repos/hi3g/opentsdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/hi3g/opentsdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/hi3g/opentsdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/hi3g/opentsdb/issues/comments/{number}","contents_url":"https://api.github.com/repos/hi3g/opentsdb/contents/{+path}","compare_url":"https://api.github.com/repos/hi3g/opentsdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hi3g/opentsdb/merges","archive_url":"https://api.github.com/repos/hi3g/opentsdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hi3g/opentsdb/downloads","issues_url":"https://api.github.com/repos/hi3g/opentsdb/issues{/number}","pulls_url":"https://api.github.com/repos/hi3g/opentsdb/pulls{/number}","milestones_url":"https://api.github.com/repos/hi3g/opentsdb/milestones{/number}","notifications_url":"https://api.github.com/repos/hi3g/opentsdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hi3g/opentsdb/labels{/name}","releases_url":"https://api.github.com/repos/hi3g/opentsdb/releases{/id}","created_at":"2014-07-09T08:03:29Z","updated_at":"2014-07-14T19:54:15Z","pushed_at":"2014-07-31T11:45:17Z","git_url":"git://github.com/hi3g/opentsdb.git","ssh_url":"git@github.com:hi3g/opentsdb.git","clone_url":"https://github.com/hi3g/opentsdb.git","svn_url":"https://github.com/hi3g/opentsdb","homepage":"http://opentsdb.net","size":28973,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"hi3g:next_storage","ref":"next_storage","sha":"015c69558078f2b34116b5cdf5f03528d65f7029","user":{"login":"hi3g","id":8111300,"avatar_url":"https://avatars.githubusercontent.com/u/8111300?v=1","gravatar_id":null,"url":"https://api.github.com/users/hi3g","html_url":"https://github.com/hi3g","followers_url":"https://api.github.com/users/hi3g/followers","following_url":"https://api.github.com/users/hi3g/following{/other_user}","gists_url":"https://api.github.com/users/hi3g/gists{/gist_id}","starred_url":"https://api.github.com/users/hi3g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hi3g/subscriptions","organizations_url":"https://api.github.com/users/hi3g/orgs","repos_url":"https://api.github.com/users/hi3g/repos","events_url":"https://api.github.com/users/hi3g/events{/privacy}","received_events_url":"https://api.github.com/users/hi3g/received_events","type":"Organization","site_admin":false},"repo":{"id":21644204,"name":"opentsdb","full_name":"hi3g/opentsdb","owner":{"login":"hi3g","id":8111300,"avatar_url":"https://avatars.githubusercontent.com/u/8111300?v=1","gravatar_id":null,"url":"https://api.github.com/users/hi3g","html_url":"https://github.com/hi3g","followers_url":"https://api.github.com/users/hi3g/followers","following_url":"https://api.github.com/users/hi3g/following{/other_user}","gists_url":"https://api.github.com/users/hi3g/gists{/gist_id}","starred_url":"https://api.github.com/users/hi3g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hi3g/subscriptions","organizations_url":"https://api.github.com/users/hi3g/orgs","repos_url":"https://api.github.com/users/hi3g/repos","events_url":"https://api.github.com/users/hi3g/events{/privacy}","received_events_url":"https://api.github.com/users/hi3g/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hi3g/opentsdb","description":"A scalable, distributed Time Series Database.","fork":true,"url":"https://api.github.com/repos/hi3g/opentsdb","forks_url":"https://api.github.com/repos/hi3g/opentsdb/forks","keys_url":"https://api.github.com/repos/hi3g/opentsdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hi3g/opentsdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hi3g/opentsdb/teams","hooks_url":"https://api.github.com/repos/hi3g/opentsdb/hooks","issue_events_url":"https://api.github.com/repos/hi3g/opentsdb/issues/events{/number}","events_url":"https://api.github.com/repos/hi3g/opentsdb/events","assignees_url":"https://api.github.com/repos/hi3g/opentsdb/assignees{/user}","branches_url":"https://api.github.com/repos/hi3g/opentsdb/branches{/branch}","tags_url":"https://api.github.com/repos/hi3g/opentsdb/tags","blobs_url":"https://api.github.com/repos/hi3g/opentsdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hi3g/opentsdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hi3g/opentsdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/hi3g/opentsdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hi3g/opentsdb/statuses/{sha}","languages_url":"https://api.github.com/repos/hi3g/opentsdb/languages","stargazers_url":"https://api.github.com/repos/hi3g/opentsdb/stargazers","contributors_url":"https://api.github.com/repos/hi3g/opentsdb/contributors","subscribers_url":"https://api.github.com/repos/hi3g/opentsdb/subscribers","subscription_url":"https://api.github.com/repos/hi3g/opentsdb/subscription","commits_url":"https://api.github.com/repos/hi3g/opentsdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/hi3g/opentsdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/hi3g/opentsdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/hi3g/opentsdb/issues/comments/{number}","contents_url":"https://api.github.com/repos/hi3g/opentsdb/contents/{+path}","compare_url":"https://api.github.com/repos/hi3g/opentsdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hi3g/opentsdb/merges","archive_url":"https://api.github.com/repos/hi3g/opentsdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hi3g/opentsdb/downloads","issues_url":"https://api.github.com/repos/hi3g/opentsdb/issues{/number}","pulls_url":"https://api.github.com/repos/hi3g/opentsdb/pulls{/number}","milestones_url":"https://api.github.com/repos/hi3g/opentsdb/milestones{/number}","notifications_url":"https://api.github.com/repos/hi3g/opentsdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hi3g/opentsdb/labels{/name}","releases_url":"https://api.github.com/repos/hi3g/opentsdb/releases{/id}","created_at":"2014-07-09T08:03:29Z","updated_at":"2014-07-14T19:54:15Z","pushed_at":"2014-07-31T11:45:17Z","git_url":"git://github.com/hi3g/opentsdb.git","ssh_url":"git@github.com:hi3g/opentsdb.git","clone_url":"https://github.com/hi3g/opentsdb.git","svn_url":"https://github.com/hi3g/opentsdb","homepage":"http://opentsdb.net","size":28973,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hi3g/opentsdb/pulls/8"},"html":{"href":"https://github.com/hi3g/opentsdb/pull/8"},"issue":{"href":"https://api.github.com/repos/hi3g/opentsdb/issues/8"},"comments":{"href":"https://api.github.com/repos/hi3g/opentsdb/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/hi3g/opentsdb/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/hi3g/opentsdb/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/hi3g/opentsdb/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/hi3g/opentsdb/statuses/54f66b2541955a9dd03622b21fce855955253a63"}}}}