GitHub PullRequestReviewCommentEvent at 2014-12-18 17:53:16
Repository: lumX
Actor: malexandre
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/lumapps/lumX/pulls/comments/22058224","id":22058224,"diff_hunk":"@@ -40,6 +30,16 @@ angular.module('lumx.date-picker', [])\n             generateCalendar();\n         };\n \n+        this.updateModel = function(val)\n+        {\n+            $scope.model = val;","path":"js/date-picker/js/lumx.date_picker_directive.js","position":31,"original_position":31,"commit_id":"04df6d43c19436c6d4b71b70531ffa80fff8b1a2","original_commit_id":"04df6d43c19436c6d4b71b70531ffa80fff8b1a2","user":{"login":"malexandre","id":1535967,"avatar_url":"https://avatars.githubusercontent.com/u/1535967?v=3","gravatar_id":"","url":"https://api.github.com/users/malexandre","html_url":"https://github.com/malexandre","followers_url":"https://api.github.com/users/malexandre/followers","following_url":"https://api.github.com/users/malexandre/following{/other_user}","gists_url":"https://api.github.com/users/malexandre/gists{/gist_id}","starred_url":"https://api.github.com/users/malexandre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/malexandre/subscriptions","organizations_url":"https://api.github.com/users/malexandre/orgs","repos_url":"https://api.github.com/users/malexandre/repos","events_url":"https://api.github.com/users/malexandre/events{/privacy}","received_events_url":"https://api.github.com/users/malexandre/received_events","type":"User","site_admin":false},"body":"I think it's dangerous to have the watcher updating the value (and thus possibly re-launching the watcher). I know that it's supposed to be the same value, but it's a risky move.","created_at":"2014-12-18T17:53:16Z","updated_at":"2014-12-18T17:53:16Z","html_url":"https://github.com/lumapps/lumX/pull/73#discussion_r22058224","pull_request_url":"https://api.github.com/repos/lumapps/lumX/pulls/73","_links":{"self":{"href":"https://api.github.com/repos/lumapps/lumX/pulls/comments/22058224"},"html":{"href":"https://github.com/lumapps/lumX/pull/73#discussion_r22058224"},"pull_request":{"href":"https://api.github.com/repos/lumapps/lumX/pulls/73"}}},"pull_request":{"url":"https://api.github.com/repos/lumapps/lumX/pulls/73","id":26305276,"html_url":"https://github.com/lumapps/lumX/pull/73","diff_url":"https://github.com/lumapps/lumX/pull/73.diff","patch_url":"https://github.com/lumapps/lumX/pull/73.patch","issue_url":"https://api.github.com/repos/lumapps/lumX/issues/73","number":73,"state":"open","locked":false,"title":"fix date-picker: watch the scope to handle async binding","user":{"login":"Argetloum","id":1721447,"avatar_url":"https://avatars.githubusercontent.com/u/1721447?v=3","gravatar_id":"","url":"https://api.github.com/users/Argetloum","html_url":"https://github.com/Argetloum","followers_url":"https://api.github.com/users/Argetloum/followers","following_url":"https://api.github.com/users/Argetloum/following{/other_user}","gists_url":"https://api.github.com/users/Argetloum/gists{/gist_id}","starred_url":"https://api.github.com/users/Argetloum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Argetloum/subscriptions","organizations_url":"https://api.github.com/users/Argetloum/orgs","repos_url":"https://api.github.com/users/Argetloum/repos","events_url":"https://api.github.com/users/Argetloum/events{/privacy}","received_events_url":"https://api.github.com/users/Argetloum/received_events","type":"User","site_admin":false},"body":"Before, async binding doesn't work.\r\nWatching the \"model\" scope permit to update the date-picker correctly.","created_at":"2014-12-18T14:54:13Z","updated_at":"2014-12-18T17:53:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3d43224f0ddc212feb6e867e01915676672d2979","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lumapps/lumX/pulls/73/commits","review_comments_url":"https://api.github.com/repos/lumapps/lumX/pulls/73/comments","review_comment_url":"https://api.github.com/repos/lumapps/lumX/pulls/comments/{number}","comments_url":"https://api.github.com/repos/lumapps/lumX/issues/73/comments","statuses_url":"https://api.github.com/repos/lumapps/lumX/statuses/04df6d43c19436c6d4b71b70531ffa80fff8b1a2","head":{"label":"lumapps:fix/date-picker","ref":"fix/date-picker","sha":"04df6d43c19436c6d4b71b70531ffa80fff8b1a2","user":{"login":"lumapps","id":2465187,"avatar_url":"https://avatars.githubusercontent.com/u/2465187?v=3","gravatar_id":"","url":"https://api.github.com/users/lumapps","html_url":"https://github.com/lumapps","followers_url":"https://api.github.com/users/lumapps/followers","following_url":"https://api.github.com/users/lumapps/following{/other_user}","gists_url":"https://api.github.com/users/lumapps/gists{/gist_id}","starred_url":"https://api.github.com/users/lumapps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lumapps/subscriptions","organizations_url":"https://api.github.com/users/lumapps/orgs","repos_url":"https://api.github.com/users/lumapps/repos","events_url":"https://api.github.com/users/lumapps/events{/privacy}","received_events_url":"https://api.github.com/users/lumapps/received_events","type":"Organization","site_admin":false},"repo":{"id":26854025,"name":"lumX","full_name":"lumapps/lumX","owner":{"login":"lumapps","id":2465187,"avatar_url":"https://avatars.githubusercontent.com/u/2465187?v=3","gravatar_id":"","url":"https://api.github.com/users/lumapps","html_url":"https://github.com/lumapps","followers_url":"https://api.github.com/users/lumapps/followers","following_url":"https://api.github.com/users/lumapps/following{/other_user}","gists_url":"https://api.github.com/users/lumapps/gists{/gist_id}","starred_url":"https://api.github.com/users/lumapps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lumapps/subscriptions","organizations_url":"https://api.github.com/users/lumapps/orgs","repos_url":"https://api.github.com/users/lumapps/repos","events_url":"https://api.github.com/users/lumapps/events{/privacy}","received_events_url":"https://api.github.com/users/lumapps/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lumapps/lumX","description":"","fork":false,"url":"https://api.github.com/repos/lumapps/lumX","forks_url":"https://api.github.com/repos/lumapps/lumX/forks","keys_url":"https://api.github.com/repos/lumapps/lumX/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lumapps/lumX/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lumapps/lumX/teams","hooks_url":"https://api.github.com/repos/lumapps/lumX/hooks","issue_events_url":"https://api.github.com/repos/lumapps/lumX/issues/events{/number}","events_url":"https://api.github.com/repos/lumapps/lumX/events","assignees_url":"https://api.github.com/repos/lumapps/lumX/assignees{/user}","branches_url":"https://api.github.com/repos/lumapps/lumX/branches{/branch}","tags_url":"https://api.github.com/repos/lumapps/lumX/tags","blobs_url":"https://api.github.com/repos/lumapps/lumX/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lumapps/lumX/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lumapps/lumX/git/refs{/sha}","trees_url":"https://api.github.com/repos/lumapps/lumX/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lumapps/lumX/statuses/{sha}","languages_url":"https://api.github.com/repos/lumapps/lumX/languages","stargazers_url":"https://api.github.com/repos/lumapps/lumX/stargazers","contributors_url":"https://api.github.com/repos/lumapps/lumX/contributors","subscribers_url":"https://api.github.com/repos/lumapps/lumX/subscribers","subscription_url":"https://api.github.com/repos/lumapps/lumX/subscription","commits_url":"https://api.github.com/repos/lumapps/lumX/commits{/sha}","git_commits_url":"https://api.github.com/repos/lumapps/lumX/git/commits{/sha}","comments_url":"https://api.github.com/repos/lumapps/lumX/comments{/number}","issue_comment_url":"https://api.github.com/repos/lumapps/lumX/issues/comments/{number}","contents_url":"https://api.github.com/repos/lumapps/lumX/contents/{+path}","compare_url":"https://api.github.com/repos/lumapps/lumX/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lumapps/lumX/merges","archive_url":"https://api.github.com/repos/lumapps/lumX/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lumapps/lumX/downloads","issues_url":"https://api.github.com/repos/lumapps/lumX/issues{/number}","pulls_url":"https://api.github.com/repos/lumapps/lumX/pulls{/number}","milestones_url":"https://api.github.com/repos/lumapps/lumX/milestones{/number}","notifications_url":"https://api.github.com/repos/lumapps/lumX/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lumapps/lumX/labels{/name}","releases_url":"https://api.github.com/repos/lumapps/lumX/releases{/id}","created_at":"2014-11-19T09:28:58Z","updated_at":"2014-12-18T17:22:56Z","pushed_at":"2014-12-18T17:22:56Z","git_url":"git://github.com/lumapps/lumX.git","ssh_url":"git@github.com:lumapps/lumX.git","clone_url":"https://github.com/lumapps/lumX.git","svn_url":"https://github.com/lumapps/lumX","homepage":null,"size":6538,"stargazers_count":249,"watchers_count":249,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":22,"forks":25,"open_issues":22,"watchers":249,"default_branch":"master"}},"base":{"label":"lumapps:master","ref":"master","sha":"145151eee936809470dcc188e6eb928fc3258d0f","user":{"login":"lumapps","id":2465187,"avatar_url":"https://avatars.githubusercontent.com/u/2465187?v=3","gravatar_id":"","url":"https://api.github.com/users/lumapps","html_url":"https://github.com/lumapps","followers_url":"https://api.github.com/users/lumapps/followers","following_url":"https://api.github.com/users/lumapps/following{/other_user}","gists_url":"https://api.github.com/users/lumapps/gists{/gist_id}","starred_url":"https://api.github.com/users/lumapps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lumapps/subscriptions","organizations_url":"https://api.github.com/users/lumapps/orgs","repos_url":"https://api.github.com/users/lumapps/repos","events_url":"https://api.github.com/users/lumapps/events{/privacy}","received_events_url":"https://api.github.com/users/lumapps/received_events","type":"Organization","site_admin":false},"repo":{"id":26854025,"name":"lumX","full_name":"lumapps/lumX","owner":{"login":"lumapps","id":2465187,"avatar_url":"https://avatars.githubusercontent.com/u/2465187?v=3","gravatar_id":"","url":"https://api.github.com/users/lumapps","html_url":"https://github.com/lumapps","followers_url":"https://api.github.com/users/lumapps/followers","following_url":"https://api.github.com/users/lumapps/following{/other_user}","gists_url":"https://api.github.com/users/lumapps/gists{/gist_id}","starred_url":"https://api.github.com/users/lumapps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lumapps/subscriptions","organizations_url":"https://api.github.com/users/lumapps/orgs","repos_url":"https://api.github.com/users/lumapps/repos","events_url":"https://api.github.com/users/lumapps/events{/privacy}","received_events_url":"https://api.github.com/users/lumapps/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lumapps/lumX","description":"","fork":false,"url":"https://api.github.com/repos/lumapps/lumX","forks_url":"https://api.github.com/repos/lumapps/lumX/forks","keys_url":"https://api.github.com/repos/lumapps/lumX/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lumapps/lumX/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lumapps/lumX/teams","hooks_url":"https://api.github.com/repos/lumapps/lumX/hooks","issue_events_url":"https://api.github.com/repos/lumapps/lumX/issues/events{/number}","events_url":"https://api.github.com/repos/lumapps/lumX/events","assignees_url":"https://api.github.com/repos/lumapps/lumX/assignees{/user}","branches_url":"https://api.github.com/repos/lumapps/lumX/branches{/branch}","tags_url":"https://api.github.com/repos/lumapps/lumX/tags","blobs_url":"https://api.github.com/repos/lumapps/lumX/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lumapps/lumX/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lumapps/lumX/git/refs{/sha}","trees_url":"https://api.github.com/repos/lumapps/lumX/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lumapps/lumX/statuses/{sha}","languages_url":"https://api.github.com/repos/lumapps/lumX/languages","stargazers_url":"https://api.github.com/repos/lumapps/lumX/stargazers","contributors_url":"https://api.github.com/repos/lumapps/lumX/contributors","subscribers_url":"https://api.github.com/repos/lumapps/lumX/subscribers","subscription_url":"https://api.github.com/repos/lumapps/lumX/subscription","commits_url":"https://api.github.com/repos/lumapps/lumX/commits{/sha}","git_commits_url":"https://api.github.com/repos/lumapps/lumX/git/commits{/sha}","comments_url":"https://api.github.com/repos/lumapps/lumX/comments{/number}","issue_comment_url":"https://api.github.com/repos/lumapps/lumX/issues/comments/{number}","contents_url":"https://api.github.com/repos/lumapps/lumX/contents/{+path}","compare_url":"https://api.github.com/repos/lumapps/lumX/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lumapps/lumX/merges","archive_url":"https://api.github.com/repos/lumapps/lumX/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lumapps/lumX/downloads","issues_url":"https://api.github.com/repos/lumapps/lumX/issues{/number}","pulls_url":"https://api.github.com/repos/lumapps/lumX/pulls{/number}","milestones_url":"https://api.github.com/repos/lumapps/lumX/milestones{/number}","notifications_url":"https://api.github.com/repos/lumapps/lumX/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lumapps/lumX/labels{/name}","releases_url":"https://api.github.com/repos/lumapps/lumX/releases{/id}","created_at":"2014-11-19T09:28:58Z","updated_at":"2014-12-18T17:22:56Z","pushed_at":"2014-12-18T17:22:56Z","git_url":"git://github.com/lumapps/lumX.git","ssh_url":"git@github.com:lumapps/lumX.git","clone_url":"https://github.com/lumapps/lumX.git","svn_url":"https://github.com/lumapps/lumX","homepage":null,"size":6538,"stargazers_count":249,"watchers_count":249,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":22,"forks":25,"open_issues":22,"watchers":249,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lumapps/lumX/pulls/73"},"html":{"href":"https://github.com/lumapps/lumX/pull/73"},"issue":{"href":"https://api.github.com/repos/lumapps/lumX/issues/73"},"comments":{"href":"https://api.github.com/repos/lumapps/lumX/issues/73/comments"},"review_comments":{"href":"https://api.github.com/repos/lumapps/lumX/pulls/73/comments"},"review_comment":{"href":"https://api.github.com/repos/lumapps/lumX/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/lumapps/lumX/pulls/73/commits"},"statuses":{"href":"https://api.github.com/repos/lumapps/lumX/statuses/04df6d43c19436c6d4b71b70531ffa80fff8b1a2"}}}}