GitHub PullRequestReviewCommentEvent at 2014-11-21 19:23:01
Repository: mirage
Actor: dsheets
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mirage/mirage/pulls/comments/20735662","id":20735662,"diff_hunk":"@@ -0,0 +1,24 @@\n+(*\n+ * Copyright (c) 2014 David Sheets <sheets@alum.mit.edu>\n+ *\n+ * Permission to use, copy, modify, and distribute this software for any\n+ * purpose with or without fee is hereby granted, provided that the above\n+ * copyright notice and this permission notice appear in all copies.\n+ *\n+ * THE SOFTWARE IS PROVIDED \"AS IS\" AND THE AUTHOR DISCLAIMS ALL WARRANTIES\n+ * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF\n+ * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR\n+ * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES\n+ * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN\n+ * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF\n+ * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.\n+ *)\n+\n+(** Mirage run-time utilities *)\n+\n+(** {2 Friendly run-time errors} *)\n+\n+val friendly_network_error:\n+  string -> [> `Unknown of string | `Unimplemented | `Disconnected ] -> string\n+(** Generate a helpful string for network interface errors from the\n+    interface name and the error constructor. *)","path":"lib/mirage_rt.mli","position":24,"original_position":24,"commit_id":"373d59ebcb98632c757e752af17e060e0455dac2","original_commit_id":"373d59ebcb98632c757e752af17e060e0455dac2","user":{"login":"dsheets","id":59918,"avatar_url":"https://avatars.githubusercontent.com/u/59918?v=3","gravatar_id":"","url":"https://api.github.com/users/dsheets","html_url":"https://github.com/dsheets","followers_url":"https://api.github.com/users/dsheets/followers","following_url":"https://api.github.com/users/dsheets/following{/other_user}","gists_url":"https://api.github.com/users/dsheets/gists{/gist_id}","starred_url":"https://api.github.com/users/dsheets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsheets/subscriptions","organizations_url":"https://api.github.com/users/dsheets/orgs","repos_url":"https://api.github.com/users/dsheets/repos","events_url":"https://api.github.com/users/dsheets/events{/privacy}","received_events_url":"https://api.github.com/users/dsheets/received_events","type":"User","site_admin":false},"body":"`network_init_error_string`? `string_of_network_init_error`?","created_at":"2014-11-21T19:23:01Z","updated_at":"2014-11-21T19:23:01Z","html_url":"https://github.com/mirage/mirage/pull/327#discussion_r20735662","pull_request_url":"https://api.github.com/repos/mirage/mirage/pulls/327","_links":{"self":{"href":"https://api.github.com/repos/mirage/mirage/pulls/comments/20735662"},"html":{"href":"https://github.com/mirage/mirage/pull/327#discussion_r20735662"},"pull_request":{"href":"https://api.github.com/repos/mirage/mirage/pulls/327"}}},"pull_request":{"url":"https://api.github.com/repos/mirage/mirage/pulls/327","id":24862314,"html_url":"https://github.com/mirage/mirage/pull/327","diff_url":"https://github.com/mirage/mirage/pull/327.diff","patch_url":"https://github.com/mirage/mirage/pull/327.patch","issue_url":"https://api.github.com/repos/mirage/mirage/issues/327","number":327,"state":"open","locked":false,"title":"When net_tap driver can't initialize, emit human error","user":{"login":"dsheets","id":59918,"avatar_url":"https://avatars.githubusercontent.com/u/59918?v=3","gravatar_id":"","url":"https://api.github.com/users/dsheets","html_url":"https://github.com/dsheets","followers_url":"https://api.github.com/users/dsheets/followers","following_url":"https://api.github.com/users/dsheets/following{/other_user}","gists_url":"https://api.github.com/users/dsheets/gists{/gist_id}","starred_url":"https://api.github.com/users/dsheets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsheets/subscriptions","organizations_url":"https://api.github.com/users/dsheets/orgs","repos_url":"https://api.github.com/users/dsheets/repos","events_url":"https://api.github.com/users/dsheets/events{/privacy}","received_events_url":"https://api.github.com/users/dsheets/received_events","type":"User","site_admin":false},"body":"Introduces `mirage.runtime` library and corresponding `Mirage_rt` module. This may be totally wrong and there is a better place to put it but I couldn't find one at first glance. Suggestions very welcome.\r\n\r\nFixes #164.","created_at":"2014-11-21T19:18:52Z","updated_at":"2014-11-21T19:23:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"788ca6728564d495d54e323f681d399f64be23aa","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mirage/mirage/pulls/327/commits","review_comments_url":"https://api.github.com/repos/mirage/mirage/pulls/327/comments","review_comment_url":"https://api.github.com/repos/mirage/mirage/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mirage/mirage/issues/327/comments","statuses_url":"https://api.github.com/repos/mirage/mirage/statuses/373d59ebcb98632c757e752af17e060e0455dac2","head":{"label":"dsheets:tap-human-error","ref":"tap-human-error","sha":"373d59ebcb98632c757e752af17e060e0455dac2","user":{"login":"dsheets","id":59918,"avatar_url":"https://avatars.githubusercontent.com/u/59918?v=3","gravatar_id":"","url":"https://api.github.com/users/dsheets","html_url":"https://github.com/dsheets","followers_url":"https://api.github.com/users/dsheets/followers","following_url":"https://api.github.com/users/dsheets/following{/other_user}","gists_url":"https://api.github.com/users/dsheets/gists{/gist_id}","starred_url":"https://api.github.com/users/dsheets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsheets/subscriptions","organizations_url":"https://api.github.com/users/dsheets/orgs","repos_url":"https://api.github.com/users/dsheets/repos","events_url":"https://api.github.com/users/dsheets/events{/privacy}","received_events_url":"https://api.github.com/users/dsheets/received_events","type":"User","site_admin":false},"repo":{"id":26972149,"name":"mirage","full_name":"dsheets/mirage","owner":{"login":"dsheets","id":59918,"avatar_url":"https://avatars.githubusercontent.com/u/59918?v=3","gravatar_id":"","url":"https://api.github.com/users/dsheets","html_url":"https://github.com/dsheets","followers_url":"https://api.github.com/users/dsheets/followers","following_url":"https://api.github.com/users/dsheets/following{/other_user}","gists_url":"https://api.github.com/users/dsheets/gists{/gist_id}","starred_url":"https://api.github.com/users/dsheets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsheets/subscriptions","organizations_url":"https://api.github.com/users/dsheets/orgs","repos_url":"https://api.github.com/users/dsheets/repos","events_url":"https://api.github.com/users/dsheets/events{/privacy}","received_events_url":"https://api.github.com/users/dsheets/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dsheets/mirage","description":"Cloud programming platform","fork":true,"url":"https://api.github.com/repos/dsheets/mirage","forks_url":"https://api.github.com/repos/dsheets/mirage/forks","keys_url":"https://api.github.com/repos/dsheets/mirage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dsheets/mirage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dsheets/mirage/teams","hooks_url":"https://api.github.com/repos/dsheets/mirage/hooks","issue_events_url":"https://api.github.com/repos/dsheets/mirage/issues/events{/number}","events_url":"https://api.github.com/repos/dsheets/mirage/events","assignees_url":"https://api.github.com/repos/dsheets/mirage/assignees{/user}","branches_url":"https://api.github.com/repos/dsheets/mirage/branches{/branch}","tags_url":"https://api.github.com/repos/dsheets/mirage/tags","blobs_url":"https://api.github.com/repos/dsheets/mirage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dsheets/mirage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dsheets/mirage/git/refs{/sha}","trees_url":"https://api.github.com/repos/dsheets/mirage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dsheets/mirage/statuses/{sha}","languages_url":"https://api.github.com/repos/dsheets/mirage/languages","stargazers_url":"https://api.github.com/repos/dsheets/mirage/stargazers","contributors_url":"https://api.github.com/repos/dsheets/mirage/contributors","subscribers_url":"https://api.github.com/repos/dsheets/mirage/subscribers","subscription_url":"https://api.github.com/repos/dsheets/mirage/subscription","commits_url":"https://api.github.com/repos/dsheets/mirage/commits{/sha}","git_commits_url":"https://api.github.com/repos/dsheets/mirage/git/commits{/sha}","comments_url":"https://api.github.com/repos/dsheets/mirage/comments{/number}","issue_comment_url":"https://api.github.com/repos/dsheets/mirage/issues/comments/{number}","contents_url":"https://api.github.com/repos/dsheets/mirage/contents/{+path}","compare_url":"https://api.github.com/repos/dsheets/mirage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dsheets/mirage/merges","archive_url":"https://api.github.com/repos/dsheets/mirage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dsheets/mirage/downloads","issues_url":"https://api.github.com/repos/dsheets/mirage/issues{/number}","pulls_url":"https://api.github.com/repos/dsheets/mirage/pulls{/number}","milestones_url":"https://api.github.com/repos/dsheets/mirage/milestones{/number}","notifications_url":"https://api.github.com/repos/dsheets/mirage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dsheets/mirage/labels{/name}","releases_url":"https://api.github.com/repos/dsheets/mirage/releases{/id}","created_at":"2014-11-21T18:19:19Z","updated_at":"2014-11-21T18:19:20Z","pushed_at":"2014-11-21T19:17:01Z","git_url":"git://github.com/dsheets/mirage.git","ssh_url":"git@github.com:dsheets/mirage.git","clone_url":"https://github.com/dsheets/mirage.git","svn_url":"https://github.com/dsheets/mirage","homepage":"http://www.openmirage.org/","size":27667,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mirage:master","ref":"master","sha":"97833d786eac111afa7d38f0995e9cc4eb292bbc","user":{"login":"mirage","id":131943,"avatar_url":"https://avatars.githubusercontent.com/u/131943?v=3","gravatar_id":"","url":"https://api.github.com/users/mirage","html_url":"https://github.com/mirage","followers_url":"https://api.github.com/users/mirage/followers","following_url":"https://api.github.com/users/mirage/following{/other_user}","gists_url":"https://api.github.com/users/mirage/gists{/gist_id}","starred_url":"https://api.github.com/users/mirage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirage/subscriptions","organizations_url":"https://api.github.com/users/mirage/orgs","repos_url":"https://api.github.com/users/mirage/repos","events_url":"https://api.github.com/users/mirage/events{/privacy}","received_events_url":"https://api.github.com/users/mirage/received_events","type":"Organization","site_admin":false},"repo":{"id":395561,"name":"mirage","full_name":"mirage/mirage","owner":{"login":"mirage","id":131943,"avatar_url":"https://avatars.githubusercontent.com/u/131943?v=3","gravatar_id":"","url":"https://api.github.com/users/mirage","html_url":"https://github.com/mirage","followers_url":"https://api.github.com/users/mirage/followers","following_url":"https://api.github.com/users/mirage/following{/other_user}","gists_url":"https://api.github.com/users/mirage/gists{/gist_id}","starred_url":"https://api.github.com/users/mirage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirage/subscriptions","organizations_url":"https://api.github.com/users/mirage/orgs","repos_url":"https://api.github.com/users/mirage/repos","events_url":"https://api.github.com/users/mirage/events{/privacy}","received_events_url":"https://api.github.com/users/mirage/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mirage/mirage","description":"Cloud programming platform","fork":false,"url":"https://api.github.com/repos/mirage/mirage","forks_url":"https://api.github.com/repos/mirage/mirage/forks","keys_url":"https://api.github.com/repos/mirage/mirage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mirage/mirage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mirage/mirage/teams","hooks_url":"https://api.github.com/repos/mirage/mirage/hooks","issue_events_url":"https://api.github.com/repos/mirage/mirage/issues/events{/number}","events_url":"https://api.github.com/repos/mirage/mirage/events","assignees_url":"https://api.github.com/repos/mirage/mirage/assignees{/user}","branches_url":"https://api.github.com/repos/mirage/mirage/branches{/branch}","tags_url":"https://api.github.com/repos/mirage/mirage/tags","blobs_url":"https://api.github.com/repos/mirage/mirage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mirage/mirage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mirage/mirage/git/refs{/sha}","trees_url":"https://api.github.com/repos/mirage/mirage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mirage/mirage/statuses/{sha}","languages_url":"https://api.github.com/repos/mirage/mirage/languages","stargazers_url":"https://api.github.com/repos/mirage/mirage/stargazers","contributors_url":"https://api.github.com/repos/mirage/mirage/contributors","subscribers_url":"https://api.github.com/repos/mirage/mirage/subscribers","subscription_url":"https://api.github.com/repos/mirage/mirage/subscription","commits_url":"https://api.github.com/repos/mirage/mirage/commits{/sha}","git_commits_url":"https://api.github.com/repos/mirage/mirage/git/commits{/sha}","comments_url":"https://api.github.com/repos/mirage/mirage/comments{/number}","issue_comment_url":"https://api.github.com/repos/mirage/mirage/issues/comments/{number}","contents_url":"https://api.github.com/repos/mirage/mirage/contents/{+path}","compare_url":"https://api.github.com/repos/mirage/mirage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mirage/mirage/merges","archive_url":"https://api.github.com/repos/mirage/mirage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mirage/mirage/downloads","issues_url":"https://api.github.com/repos/mirage/mirage/issues{/number}","pulls_url":"https://api.github.com/repos/mirage/mirage/pulls{/number}","milestones_url":"https://api.github.com/repos/mirage/mirage/milestones{/number}","notifications_url":"https://api.github.com/repos/mirage/mirage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mirage/mirage/labels{/name}","releases_url":"https://api.github.com/repos/mirage/mirage/releases{/id}","created_at":"2009-12-04T17:00:34Z","updated_at":"2014-11-21T10:40:19Z","pushed_at":"2014-11-21T18:18:35Z","git_url":"git://github.com/mirage/mirage.git","ssh_url":"git@github.com:mirage/mirage.git","clone_url":"https://github.com/mirage/mirage.git","svn_url":"https://github.com/mirage/mirage","homepage":"http://www.openmirage.org/","size":27667,"stargazers_count":354,"watchers_count":354,"language":"OCaml","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":56,"mirror_url":null,"open_issues_count":79,"forks":56,"open_issues":79,"watchers":354,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mirage/mirage/pulls/327"},"html":{"href":"https://github.com/mirage/mirage/pull/327"},"issue":{"href":"https://api.github.com/repos/mirage/mirage/issues/327"},"comments":{"href":"https://api.github.com/repos/mirage/mirage/issues/327/comments"},"review_comments":{"href":"https://api.github.com/repos/mirage/mirage/pulls/327/comments"},"review_comment":{"href":"https://api.github.com/repos/mirage/mirage/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mirage/mirage/pulls/327/commits"},"statuses":{"href":"https://api.github.com/repos/mirage/mirage/statuses/373d59ebcb98632c757e752af17e060e0455dac2"}}}}