GitHub PullRequestEvent at 2014-06-05 09:27:24
Repository: coinffeine
Actor: sortega
Payload: {"action":"closed","number":144,"pull_request":{"url":"https://api.github.com/repos/Coinffeine/coinffeine/pulls/144","id":16754675,"html_url":"https://github.com/Coinffeine/coinffeine/pull/144","diff_url":"https://github.com/Coinffeine/coinffeine/pull/144.diff","patch_url":"https://github.com/Coinffeine/coinffeine/pull/144.patch","issue_url":"https://api.github.com/repos/Coinffeine/coinffeine/issues/144","number":144,"state":"closed","title":"Provide a type-safe replacement for `BtcAmount` and `FiatAmount`","user":{"login":"apoloval","id":738507,"avatar_url":"https://avatars.githubusercontent.com/u/738507?","gravatar_id":"3b49ed98bc948569fd0d5747b07bf474","url":"https://api.github.com/users/apoloval","html_url":"https://github.com/apoloval","followers_url":"https://api.github.com/users/apoloval/followers","following_url":"https://api.github.com/users/apoloval/following{/other_user}","gists_url":"https://api.github.com/users/apoloval/gists{/gist_id}","starred_url":"https://api.github.com/users/apoloval/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apoloval/subscriptions","organizations_url":"https://api.github.com/users/apoloval/orgs","repos_url":"https://api.github.com/users/apoloval/repos","events_url":"https://api.github.com/users/apoloval/events{/privacy}","received_events_url":"https://api.github.com/users/apoloval/received_events","type":"User","site_admin":false},"body":"As reported in issue #141, class `FiatAmount` is not as robust as it could be. The instances of different currencies share the same class, what requires continuous checks to verify we are not mixing different currencies inappropriately.\r\n\r\nThis change proposes a new replacement for `FiatAmount` and `BtcAmount` which uses a type-safe mechanism that makes impossible to mix amounts of different currencies.\r\n","created_at":"2014-06-05T08:57:52Z","updated_at":"2014-06-05T09:27:24Z","closed_at":"2014-06-05T09:27:24Z","merged_at":"2014-06-05T09:27:24Z","merge_commit_sha":"e9838ab49833b03c3732bd4000069d4fc160cfea","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Coinffeine/coinffeine/pulls/144/commits","review_comments_url":"https://api.github.com/repos/Coinffeine/coinffeine/pulls/144/comments","review_comment_url":"https://api.github.com/repos/Coinffeine/coinffeine/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Coinffeine/coinffeine/issues/144/comments","statuses_url":"https://api.github.com/repos/Coinffeine/coinffeine/statuses/6e08339e4303bc878d21335a0f3bd2659eb7a551","head":{"label":"apoloval:issue/141","ref":"issue/141","sha":"6e08339e4303bc878d21335a0f3bd2659eb7a551","user":{"login":"apoloval","id":738507,"avatar_url":"https://avatars.githubusercontent.com/u/738507?","gravatar_id":"3b49ed98bc948569fd0d5747b07bf474","url":"https://api.github.com/users/apoloval","html_url":"https://github.com/apoloval","followers_url":"https://api.github.com/users/apoloval/followers","following_url":"https://api.github.com/users/apoloval/following{/other_user}","gists_url":"https://api.github.com/users/apoloval/gists{/gist_id}","starred_url":"https://api.github.com/users/apoloval/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apoloval/subscriptions","organizations_url":"https://api.github.com/users/apoloval/orgs","repos_url":"https://api.github.com/users/apoloval/repos","events_url":"https://api.github.com/users/apoloval/events{/privacy}","received_events_url":"https://api.github.com/users/apoloval/received_events","type":"User","site_admin":false},"repo":{"id":17539521,"name":"coinffeine","full_name":"apoloval/coinffeine","owner":{"login":"apoloval","id":738507,"avatar_url":"https://avatars.githubusercontent.com/u/738507?","gravatar_id":"3b49ed98bc948569fd0d5747b07bf474","url":"https://api.github.com/users/apoloval","html_url":"https://github.com/apoloval","followers_url":"https://api.github.com/users/apoloval/followers","following_url":"https://api.github.com/users/apoloval/following{/other_user}","gists_url":"https://api.github.com/users/apoloval/gists{/gist_id}","starred_url":"https://api.github.com/users/apoloval/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apoloval/subscriptions","organizations_url":"https://api.github.com/users/apoloval/orgs","repos_url":"https://api.github.com/users/apoloval/repos","events_url":"https://api.github.com/users/apoloval/events{/privacy}","received_events_url":"https://api.github.com/users/apoloval/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/apoloval/coinffeine","description":"P2P and Decentralized Bitcoin Exchange","fork":true,"url":"https://api.github.com/repos/apoloval/coinffeine","forks_url":"https://api.github.com/repos/apoloval/coinffeine/forks","keys_url":"https://api.github.com/repos/apoloval/coinffeine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apoloval/coinffeine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apoloval/coinffeine/teams","hooks_url":"https://api.github.com/repos/apoloval/coinffeine/hooks","issue_events_url":"https://api.github.com/repos/apoloval/coinffeine/issues/events{/number}","events_url":"https://api.github.com/repos/apoloval/coinffeine/events","assignees_url":"https://api.github.com/repos/apoloval/coinffeine/assignees{/user}","branches_url":"https://api.github.com/repos/apoloval/coinffeine/branches{/branch}","tags_url":"https://api.github.com/repos/apoloval/coinffeine/tags","blobs_url":"https://api.github.com/repos/apoloval/coinffeine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apoloval/coinffeine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apoloval/coinffeine/git/refs{/sha}","trees_url":"https://api.github.com/repos/apoloval/coinffeine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apoloval/coinffeine/statuses/{sha}","languages_url":"https://api.github.com/repos/apoloval/coinffeine/languages","stargazers_url":"https://api.github.com/repos/apoloval/coinffeine/stargazers","contributors_url":"https://api.github.com/repos/apoloval/coinffeine/contributors","subscribers_url":"https://api.github.com/repos/apoloval/coinffeine/subscribers","subscription_url":"https://api.github.com/repos/apoloval/coinffeine/subscription","commits_url":"https://api.github.com/repos/apoloval/coinffeine/commits{/sha}","git_commits_url":"https://api.github.com/repos/apoloval/coinffeine/git/commits{/sha}","comments_url":"https://api.github.com/repos/apoloval/coinffeine/comments{/number}","issue_comment_url":"https://api.github.com/repos/apoloval/coinffeine/issues/comments/{number}","contents_url":"https://api.github.com/repos/apoloval/coinffeine/contents/{+path}","compare_url":"https://api.github.com/repos/apoloval/coinffeine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apoloval/coinffeine/merges","archive_url":"https://api.github.com/repos/apoloval/coinffeine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apoloval/coinffeine/downloads","issues_url":"https://api.github.com/repos/apoloval/coinffeine/issues{/number}","pulls_url":"https://api.github.com/repos/apoloval/coinffeine/pulls{/number}","milestones_url":"https://api.github.com/repos/apoloval/coinffeine/milestones{/number}","notifications_url":"https://api.github.com/repos/apoloval/coinffeine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apoloval/coinffeine/labels{/name}","releases_url":"https://api.github.com/repos/apoloval/coinffeine/releases{/id}","created_at":"2014-03-08T10:09:16Z","updated_at":"2014-06-05T09:27:24Z","pushed_at":"2014-06-05T08:56:27Z","git_url":"git://github.com/apoloval/coinffeine.git","ssh_url":"git@github.com:apoloval/coinffeine.git","clone_url":"https://github.com/apoloval/coinffeine.git","svn_url":"https://github.com/apoloval/coinffeine","homepage":"http://www.coinffeine.com/","size":742,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Coinffeine:master","ref":"master","sha":"f06d5ccd564cc2bf5643faa0351ce548c0a4ac82","user":{"login":"Coinffeine","id":5500298,"avatar_url":"https://avatars.githubusercontent.com/u/5500298?","gravatar_id":"07f19cc7c5af0e48dcbe78df5027e1c8","url":"https://api.github.com/users/Coinffeine","html_url":"https://github.com/Coinffeine","followers_url":"https://api.github.com/users/Coinffeine/followers","following_url":"https://api.github.com/users/Coinffeine/following{/other_user}","gists_url":"https://api.github.com/users/Coinffeine/gists{/gist_id}","starred_url":"https://api.github.com/users/Coinffeine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Coinffeine/subscriptions","organizations_url":"https://api.github.com/users/Coinffeine/orgs","repos_url":"https://api.github.com/users/Coinffeine/repos","events_url":"https://api.github.com/users/Coinffeine/events{/privacy}","received_events_url":"https://api.github.com/users/Coinffeine/received_events","type":"Organization","site_admin":false},"repo":{"id":14274903,"name":"coinffeine","full_name":"Coinffeine/coinffeine","owner":{"login":"Coinffeine","id":5500298,"avatar_url":"https://avatars.githubusercontent.com/u/5500298?","gravatar_id":"07f19cc7c5af0e48dcbe78df5027e1c8","url":"https://api.github.com/users/Coinffeine","html_url":"https://github.com/Coinffeine","followers_url":"https://api.github.com/users/Coinffeine/followers","following_url":"https://api.github.com/users/Coinffeine/following{/other_user}","gists_url":"https://api.github.com/users/Coinffeine/gists{/gist_id}","starred_url":"https://api.github.com/users/Coinffeine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Coinffeine/subscriptions","organizations_url":"https://api.github.com/users/Coinffeine/orgs","repos_url":"https://api.github.com/users/Coinffeine/repos","events_url":"https://api.github.com/users/Coinffeine/events{/privacy}","received_events_url":"https://api.github.com/users/Coinffeine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Coinffeine/coinffeine","description":"P2P and Decentralized Bitcoin Exchange","fork":false,"url":"https://api.github.com/repos/Coinffeine/coinffeine","forks_url":"https://api.github.com/repos/Coinffeine/coinffeine/forks","keys_url":"https://api.github.com/repos/Coinffeine/coinffeine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Coinffeine/coinffeine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Coinffeine/coinffeine/teams","hooks_url":"https://api.github.com/repos/Coinffeine/coinffeine/hooks","issue_events_url":"https://api.github.com/repos/Coinffeine/coinffeine/issues/events{/number}","events_url":"https://api.github.com/repos/Coinffeine/coinffeine/events","assignees_url":"https://api.github.com/repos/Coinffeine/coinffeine/assignees{/user}","branches_url":"https://api.github.com/repos/Coinffeine/coinffeine/branches{/branch}","tags_url":"https://api.github.com/repos/Coinffeine/coinffeine/tags","blobs_url":"https://api.github.com/repos/Coinffeine/coinffeine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Coinffeine/coinffeine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Coinffeine/coinffeine/git/refs{/sha}","trees_url":"https://api.github.com/repos/Coinffeine/coinffeine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Coinffeine/coinffeine/statuses/{sha}","languages_url":"https://api.github.com/repos/Coinffeine/coinffeine/languages","stargazers_url":"https://api.github.com/repos/Coinffeine/coinffeine/stargazers","contributors_url":"https://api.github.com/repos/Coinffeine/coinffeine/contributors","subscribers_url":"https://api.github.com/repos/Coinffeine/coinffeine/subscribers","subscription_url":"https://api.github.com/repos/Coinffeine/coinffeine/subscription","commits_url":"https://api.github.com/repos/Coinffeine/coinffeine/commits{/sha}","git_commits_url":"https://api.github.com/repos/Coinffeine/coinffeine/git/commits{/sha}","comments_url":"https://api.github.com/repos/Coinffeine/coinffeine/comments{/number}","issue_comment_url":"https://api.github.com/repos/Coinffeine/coinffeine/issues/comments/{number}","contents_url":"https://api.github.com/repos/Coinffeine/coinffeine/contents/{+path}","compare_url":"https://api.github.com/repos/Coinffeine/coinffeine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Coinffeine/coinffeine/merges","archive_url":"https://api.github.com/repos/Coinffeine/coinffeine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Coinffeine/coinffeine/downloads","issues_url":"https://api.github.com/repos/Coinffeine/coinffeine/issues{/number}","pulls_url":"https://api.github.com/repos/Coinffeine/coinffeine/pulls{/number}","milestones_url":"https://api.github.com/repos/Coinffeine/coinffeine/milestones{/number}","notifications_url":"https://api.github.com/repos/Coinffeine/coinffeine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Coinffeine/coinffeine/labels{/name}","releases_url":"https://api.github.com/repos/Coinffeine/coinffeine/releases{/id}","created_at":"2013-11-10T11:01:12Z","updated_at":"2014-06-05T09:27:24Z","pushed_at":"2014-06-05T09:27:24Z","git_url":"git://github.com/Coinffeine/coinffeine.git","ssh_url":"git@github.com:Coinffeine/coinffeine.git","clone_url":"https://github.com/Coinffeine/coinffeine.git","svn_url":"https://github.com/Coinffeine/coinffeine","homepage":"http://www.coinffeine.com/","size":6013,"stargazers_count":60,"watchers_count":60,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":12,"mirror_url":null,"open_issues_count":12,"forks":12,"open_issues":12,"watchers":60,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Coinffeine/coinffeine/pulls/144"},"html":{"href":"https://github.com/Coinffeine/coinffeine/pull/144"},"issue":{"href":"https://api.github.com/repos/Coinffeine/coinffeine/issues/144"},"comments":{"href":"https://api.github.com/repos/Coinffeine/coinffeine/issues/144/comments"},"review_comments":{"href":"https://api.github.com/repos/Coinffeine/coinffeine/pulls/144/comments"},"review_comment":{"href":"https://api.github.com/repos/Coinffeine/coinffeine/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Coinffeine/coinffeine/pulls/144/commits"},"statuses":{"href":"https://api.github.com/repos/Coinffeine/coinffeine/statuses/6e08339e4303bc878d21335a0f3bd2659eb7a551"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"sortega","id":259587,"avatar_url":"https://avatars.githubusercontent.com/u/259587?","gravatar_id":"0e03253a910b45e94b96cde22ea7734a","url":"https://api.github.com/users/sortega","html_url":"https://github.com/sortega","followers_url":"https://api.github.com/users/sortega/followers","following_url":"https://api.github.com/users/sortega/following{/other_user}","gists_url":"https://api.github.com/users/sortega/gists{/gist_id}","starred_url":"https://api.github.com/users/sortega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sortega/subscriptions","organizations_url":"https://api.github.com/users/sortega/orgs","repos_url":"https://api.github.com/users/sortega/repos","events_url":"https://api.github.com/users/sortega/events{/privacy}","received_events_url":"https://api.github.com/users/sortega/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":138,"deletions":1,"changed_files":4}}