GitHub PullRequestReviewCommentEvent at 2014-09-29 15:19:35
Repository: spartan
Actor: fegin
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/spartan-array/spartan/pulls/comments/18160956","id":18160956,"diff_hunk":"@@ -120,3 +120,26 @@ def test_reshape_dot(self):\n     t3 = expr.dot(expr.reshape(t1, (718, 1)), t2)\n     Assert.all_eq(result, t3.glom(), 10e-9)\n \n+  def test_colslice_reshape(self):\n+    n_orig = np.arange(start = 1, stop = 25).reshape(4, 6)\n+    a_orig = expr.from_numpy(n_orig)\n+\n+    na = n_orig.reshape(3, 8)\n+    a  = a_orig.reshape((3, 8))\n+\n+    Assert.all_eq(na[:, 3:5], a[:, 3:5].glom())\n+    Assert.all_eq(na[1:, 4:5], a[1:, 4:5].glom())\n+    Assert.all_eq(na[2:, :1], a[2:, :1].glom())\n+\n+    na = n_orig.reshape(8, 3)\n+    a  = a_orig.reshape((8, 3))\n+\n+    Assert.all_eq(na[:, 1:2], a[:, 1:2].glom())\n+    Assert.all_eq(na[2:, 1:], a[2:, 1:].glom())\n+    Assert.all_eq(na[2:6, 2:], a[2:6, 2:].glom())","path":"tests/test_reshape.py","position":20,"original_position":20,"commit_id":"a3e6e3e6887604f89cdd852644163b85a53f978e","original_commit_id":"a3e6e3e6887604f89cdd852644163b85a53f978e","user":{"login":"fegin","id":2461448,"avatar_url":"https://avatars.githubusercontent.com/u/2461448?v=2","gravatar_id":"","url":"https://api.github.com/users/fegin","html_url":"https://github.com/fegin","followers_url":"https://api.github.com/users/fegin/followers","following_url":"https://api.github.com/users/fegin/following{/other_user}","gists_url":"https://api.github.com/users/fegin/gists{/gist_id}","starred_url":"https://api.github.com/users/fegin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fegin/subscriptions","organizations_url":"https://api.github.com/users/fegin/orgs","repos_url":"https://api.github.com/users/fegin/repos","events_url":"https://api.github.com/users/fegin/events{/privacy}","received_events_url":"https://api.github.com/users/fegin/received_events","type":"User","site_admin":false},"body":"Same as line 132.","created_at":"2014-09-29T15:19:35Z","updated_at":"2014-09-29T15:19:35Z","html_url":"https://github.com/spartan-array/spartan/pull/216#discussion_r18160956","pull_request_url":"https://api.github.com/repos/spartan-array/spartan/pulls/216","_links":{"self":{"href":"https://api.github.com/repos/spartan-array/spartan/pulls/comments/18160956"},"html":{"href":"https://github.com/spartan-array/spartan/pull/216#discussion_r18160956"},"pull_request":{"href":"https://api.github.com/repos/spartan-array/spartan/pulls/216"}}},"pull_request":{"url":"https://api.github.com/repos/spartan-array/spartan/pulls/216","id":21911603,"html_url":"https://github.com/spartan-array/spartan/pull/216","diff_url":"https://github.com/spartan-array/spartan/pull/216.diff","patch_url":"https://github.com/spartan-array/spartan/pull/216.patch","issue_url":"https://api.github.com/repos/spartan-array/spartan/issues/216","number":216,"state":"open","locked":false,"title":"Adding support to reshape: column fetch","user":{"login":"GabrielWen","id":4784270,"avatar_url":"https://avatars.githubusercontent.com/u/4784270?v=2","gravatar_id":"","url":"https://api.github.com/users/GabrielWen","html_url":"https://github.com/GabrielWen","followers_url":"https://api.github.com/users/GabrielWen/followers","following_url":"https://api.github.com/users/GabrielWen/following{/other_user}","gists_url":"https://api.github.com/users/GabrielWen/gists{/gist_id}","starred_url":"https://api.github.com/users/GabrielWen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GabrielWen/subscriptions","organizations_url":"https://api.github.com/users/GabrielWen/orgs","repos_url":"https://api.github.com/users/GabrielWen/repos","events_url":"https://api.github.com/users/GabrielWen/events{/privacy}","received_events_url":"https://api.github.com/users/GabrielWen/received_events","type":"User","site_admin":false},"body":"Currently support column fetch up to 2d array.","created_at":"2014-09-29T03:07:25Z","updated_at":"2014-09-29T15:19:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"29789a1943bbfe73cf089da334f01b5eb270c9d9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/spartan-array/spartan/pulls/216/commits","review_comments_url":"https://api.github.com/repos/spartan-array/spartan/pulls/216/comments","review_comment_url":"https://api.github.com/repos/spartan-array/spartan/pulls/comments/{number}","comments_url":"https://api.github.com/repos/spartan-array/spartan/issues/216/comments","statuses_url":"https://api.github.com/repos/spartan-array/spartan/statuses/a3e6e3e6887604f89cdd852644163b85a53f978e","head":{"label":"GabrielWen:reshape","ref":"reshape","sha":"a3e6e3e6887604f89cdd852644163b85a53f978e","user":{"login":"GabrielWen","id":4784270,"avatar_url":"https://avatars.githubusercontent.com/u/4784270?v=2","gravatar_id":"","url":"https://api.github.com/users/GabrielWen","html_url":"https://github.com/GabrielWen","followers_url":"https://api.github.com/users/GabrielWen/followers","following_url":"https://api.github.com/users/GabrielWen/following{/other_user}","gists_url":"https://api.github.com/users/GabrielWen/gists{/gist_id}","starred_url":"https://api.github.com/users/GabrielWen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GabrielWen/subscriptions","organizations_url":"https://api.github.com/users/GabrielWen/orgs","repos_url":"https://api.github.com/users/GabrielWen/repos","events_url":"https://api.github.com/users/GabrielWen/events{/privacy}","received_events_url":"https://api.github.com/users/GabrielWen/received_events","type":"User","site_admin":false},"repo":{"id":23709168,"name":"spartan","full_name":"GabrielWen/spartan","owner":{"login":"GabrielWen","id":4784270,"avatar_url":"https://avatars.githubusercontent.com/u/4784270?v=2","gravatar_id":"","url":"https://api.github.com/users/GabrielWen","html_url":"https://github.com/GabrielWen","followers_url":"https://api.github.com/users/GabrielWen/followers","following_url":"https://api.github.com/users/GabrielWen/following{/other_user}","gists_url":"https://api.github.com/users/GabrielWen/gists{/gist_id}","starred_url":"https://api.github.com/users/GabrielWen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GabrielWen/subscriptions","organizations_url":"https://api.github.com/users/GabrielWen/orgs","repos_url":"https://api.github.com/users/GabrielWen/repos","events_url":"https://api.github.com/users/GabrielWen/events{/privacy}","received_events_url":"https://api.github.com/users/GabrielWen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GabrielWen/spartan","description":"Distributed Numpy","fork":true,"url":"https://api.github.com/repos/GabrielWen/spartan","forks_url":"https://api.github.com/repos/GabrielWen/spartan/forks","keys_url":"https://api.github.com/repos/GabrielWen/spartan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GabrielWen/spartan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GabrielWen/spartan/teams","hooks_url":"https://api.github.com/repos/GabrielWen/spartan/hooks","issue_events_url":"https://api.github.com/repos/GabrielWen/spartan/issues/events{/number}","events_url":"https://api.github.com/repos/GabrielWen/spartan/events","assignees_url":"https://api.github.com/repos/GabrielWen/spartan/assignees{/user}","branches_url":"https://api.github.com/repos/GabrielWen/spartan/branches{/branch}","tags_url":"https://api.github.com/repos/GabrielWen/spartan/tags","blobs_url":"https://api.github.com/repos/GabrielWen/spartan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GabrielWen/spartan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GabrielWen/spartan/git/refs{/sha}","trees_url":"https://api.github.com/repos/GabrielWen/spartan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GabrielWen/spartan/statuses/{sha}","languages_url":"https://api.github.com/repos/GabrielWen/spartan/languages","stargazers_url":"https://api.github.com/repos/GabrielWen/spartan/stargazers","contributors_url":"https://api.github.com/repos/GabrielWen/spartan/contributors","subscribers_url":"https://api.github.com/repos/GabrielWen/spartan/subscribers","subscription_url":"https://api.github.com/repos/GabrielWen/spartan/subscription","commits_url":"https://api.github.com/repos/GabrielWen/spartan/commits{/sha}","git_commits_url":"https://api.github.com/repos/GabrielWen/spartan/git/commits{/sha}","comments_url":"https://api.github.com/repos/GabrielWen/spartan/comments{/number}","issue_comment_url":"https://api.github.com/repos/GabrielWen/spartan/issues/comments/{number}","contents_url":"https://api.github.com/repos/GabrielWen/spartan/contents/{+path}","compare_url":"https://api.github.com/repos/GabrielWen/spartan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GabrielWen/spartan/merges","archive_url":"https://api.github.com/repos/GabrielWen/spartan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GabrielWen/spartan/downloads","issues_url":"https://api.github.com/repos/GabrielWen/spartan/issues{/number}","pulls_url":"https://api.github.com/repos/GabrielWen/spartan/pulls{/number}","milestones_url":"https://api.github.com/repos/GabrielWen/spartan/milestones{/number}","notifications_url":"https://api.github.com/repos/GabrielWen/spartan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GabrielWen/spartan/labels{/name}","releases_url":"https://api.github.com/repos/GabrielWen/spartan/releases{/id}","created_at":"2014-09-05T16:00:12Z","updated_at":"2014-09-05T16:16:20Z","pushed_at":"2014-09-29T15:00:47Z","git_url":"git://github.com/GabrielWen/spartan.git","ssh_url":"git@github.com:GabrielWen/spartan.git","clone_url":"https://github.com/GabrielWen/spartan.git","svn_url":"https://github.com/GabrielWen/spartan","homepage":"http://spartan-array.github.io/spartan/","size":3435,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spartan-array:master","ref":"master","sha":"e159a792e5c04f9badaa5013ef00303c44f5644d","user":{"login":"spartan-array","id":6606369,"avatar_url":"https://avatars.githubusercontent.com/u/6606369?v=2","gravatar_id":"","url":"https://api.github.com/users/spartan-array","html_url":"https://github.com/spartan-array","followers_url":"https://api.github.com/users/spartan-array/followers","following_url":"https://api.github.com/users/spartan-array/following{/other_user}","gists_url":"https://api.github.com/users/spartan-array/gists{/gist_id}","starred_url":"https://api.github.com/users/spartan-array/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spartan-array/subscriptions","organizations_url":"https://api.github.com/users/spartan-array/orgs","repos_url":"https://api.github.com/users/spartan-array/repos","events_url":"https://api.github.com/users/spartan-array/events{/privacy}","received_events_url":"https://api.github.com/users/spartan-array/received_events","type":"Organization","site_admin":false},"repo":{"id":11694978,"name":"spartan","full_name":"spartan-array/spartan","owner":{"login":"spartan-array","id":6606369,"avatar_url":"https://avatars.githubusercontent.com/u/6606369?v=2","gravatar_id":"","url":"https://api.github.com/users/spartan-array","html_url":"https://github.com/spartan-array","followers_url":"https://api.github.com/users/spartan-array/followers","following_url":"https://api.github.com/users/spartan-array/following{/other_user}","gists_url":"https://api.github.com/users/spartan-array/gists{/gist_id}","starred_url":"https://api.github.com/users/spartan-array/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spartan-array/subscriptions","organizations_url":"https://api.github.com/users/spartan-array/orgs","repos_url":"https://api.github.com/users/spartan-array/repos","events_url":"https://api.github.com/users/spartan-array/events{/privacy}","received_events_url":"https://api.github.com/users/spartan-array/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spartan-array/spartan","description":"Distributed Numpy","fork":false,"url":"https://api.github.com/repos/spartan-array/spartan","forks_url":"https://api.github.com/repos/spartan-array/spartan/forks","keys_url":"https://api.github.com/repos/spartan-array/spartan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spartan-array/spartan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spartan-array/spartan/teams","hooks_url":"https://api.github.com/repos/spartan-array/spartan/hooks","issue_events_url":"https://api.github.com/repos/spartan-array/spartan/issues/events{/number}","events_url":"https://api.github.com/repos/spartan-array/spartan/events","assignees_url":"https://api.github.com/repos/spartan-array/spartan/assignees{/user}","branches_url":"https://api.github.com/repos/spartan-array/spartan/branches{/branch}","tags_url":"https://api.github.com/repos/spartan-array/spartan/tags","blobs_url":"https://api.github.com/repos/spartan-array/spartan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spartan-array/spartan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spartan-array/spartan/git/refs{/sha}","trees_url":"https://api.github.com/repos/spartan-array/spartan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spartan-array/spartan/statuses/{sha}","languages_url":"https://api.github.com/repos/spartan-array/spartan/languages","stargazers_url":"https://api.github.com/repos/spartan-array/spartan/stargazers","contributors_url":"https://api.github.com/repos/spartan-array/spartan/contributors","subscribers_url":"https://api.github.com/repos/spartan-array/spartan/subscribers","subscription_url":"https://api.github.com/repos/spartan-array/spartan/subscription","commits_url":"https://api.github.com/repos/spartan-array/spartan/commits{/sha}","git_commits_url":"https://api.github.com/repos/spartan-array/spartan/git/commits{/sha}","comments_url":"https://api.github.com/repos/spartan-array/spartan/comments{/number}","issue_comment_url":"https://api.github.com/repos/spartan-array/spartan/issues/comments/{number}","contents_url":"https://api.github.com/repos/spartan-array/spartan/contents/{+path}","compare_url":"https://api.github.com/repos/spartan-array/spartan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spartan-array/spartan/merges","archive_url":"https://api.github.com/repos/spartan-array/spartan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spartan-array/spartan/downloads","issues_url":"https://api.github.com/repos/spartan-array/spartan/issues{/number}","pulls_url":"https://api.github.com/repos/spartan-array/spartan/pulls{/number}","milestones_url":"https://api.github.com/repos/spartan-array/spartan/milestones{/number}","notifications_url":"https://api.github.com/repos/spartan-array/spartan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spartan-array/spartan/labels{/name}","releases_url":"https://api.github.com/repos/spartan-array/spartan/releases{/id}","created_at":"2013-07-26T21:14:54Z","updated_at":"2014-09-12T17:17:06Z","pushed_at":"2014-09-29T15:04:29Z","git_url":"git://github.com/spartan-array/spartan.git","ssh_url":"git@github.com:spartan-array/spartan.git","clone_url":"https://github.com/spartan-array/spartan.git","svn_url":"https://github.com/spartan-array/spartan","homepage":"http://spartan-array.github.io/spartan/","size":8494,"stargazers_count":10,"watchers_count":10,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"open_issues_count":14,"forks":5,"open_issues":14,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spartan-array/spartan/pulls/216"},"html":{"href":"https://github.com/spartan-array/spartan/pull/216"},"issue":{"href":"https://api.github.com/repos/spartan-array/spartan/issues/216"},"comments":{"href":"https://api.github.com/repos/spartan-array/spartan/issues/216/comments"},"review_comments":{"href":"https://api.github.com/repos/spartan-array/spartan/pulls/216/comments"},"review_comment":{"href":"https://api.github.com/repos/spartan-array/spartan/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/spartan-array/spartan/pulls/216/commits"},"statuses":{"href":"https://api.github.com/repos/spartan-array/spartan/statuses/a3e6e3e6887604f89cdd852644163b85a53f978e"}}}}