GitHub PullRequestReviewCommentEvent at 2014-12-08 11:36:41
Repository: atmosphere
Actor: houndci
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/dice-cyfronet/atmosphere/pulls/comments/21447566","id":21447566,"diff_hunk":"@@ -1,25 +1,26 @@\n-#require 'spec_helper'\n require 'rails_helper'\n \n describe Atmosphere::Cloud::VmTagsManager do\n-\n   it 'tags worker is invoked' do\n-\n-    server_name = 'SERVER NAME'\n-    server_id = 'SERVER_ID'\n     u1 = create(:user, login: 'user1')\n-    u2 = create(:user,login: 'user2')\n+    u2 = create(:user, login: 'user2')\n     at = create(:appliance_type)\n     a_set_1 = create(:appliance_set, user: u1)\n     a_set_2 = create(:appliance_set, user: u2)\n     appl1 = create(:appliance, appliance_type: at, appliance_set: a_set_1)\n     appl2 = create(:appliance, appliance_type: at, appliance_set: a_set_2)\n     cs = create(:compute_site)\n-    vm = create(:virtual_machine, appliances: [appl1, appl2], compute_site: cs, id_at_site: server_id)\n+    vm = create(:virtual_machine,\n+                appliances: [appl1, appl2],\n+                compute_site: cs, id_at_site: 'SERVER_ID')\n+\n+    expect(Atmosphere::VmTagsCreatorWorker)\n+      .to receive(:perform_async) do |vm_id, hsh|","path":"spec/services/atmosphere/cloud/vm_tags_manager_spec.rb","position":25,"original_position":25,"commit_id":"97535fc009ebc1d9a882919b3ea5ee16ed834a94","original_commit_id":"97535fc009ebc1d9a882919b3ea5ee16ed834a94","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Place the . on the previous line, together with the method call receiver.","created_at":"2014-12-08T11:36:41Z","updated_at":"2014-12-08T11:36:41Z","html_url":"https://github.com/dice-cyfronet/atmosphere/pull/29#discussion_r21447566","pull_request_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/pulls/29","_links":{"self":{"href":"https://api.github.com/repos/dice-cyfronet/atmosphere/pulls/comments/21447566"},"html":{"href":"https://github.com/dice-cyfronet/atmosphere/pull/29#discussion_r21447566"},"pull_request":{"href":"https://api.github.com/repos/dice-cyfronet/atmosphere/pulls/29"}}},"pull_request":{"url":"https://api.github.com/repos/dice-cyfronet/atmosphere/pulls/29","id":25660375,"html_url":"https://github.com/dice-cyfronet/atmosphere/pull/29","diff_url":"https://github.com/dice-cyfronet/atmosphere/pull/29.diff","patch_url":"https://github.com/dice-cyfronet/atmosphere/pull/29.patch","issue_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/issues/29","number":29,"state":"open","locked":false,"title":"fix for random failing vm tags manager test","user":{"login":"mkasztelnik","id":1265430,"avatar_url":"https://avatars.githubusercontent.com/u/1265430?v=3","gravatar_id":"","url":"https://api.github.com/users/mkasztelnik","html_url":"https://github.com/mkasztelnik","followers_url":"https://api.github.com/users/mkasztelnik/followers","following_url":"https://api.github.com/users/mkasztelnik/following{/other_user}","gists_url":"https://api.github.com/users/mkasztelnik/gists{/gist_id}","starred_url":"https://api.github.com/users/mkasztelnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkasztelnik/subscriptions","organizations_url":"https://api.github.com/users/mkasztelnik/orgs","repos_url":"https://api.github.com/users/mkasztelnik/repos","events_url":"https://api.github.com/users/mkasztelnik/events{/privacy}","received_events_url":"https://api.github.com/users/mkasztelnik/received_events","type":"User","site_admin":false},"body":"Fix for redmine 3269 issue","created_at":"2014-12-08T11:36:39Z","updated_at":"2014-12-08T11:36:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"616a5e4924bba8d3ba27c222f21947a2ab23e01f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/pulls/29/commits","review_comments_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/pulls/29/comments","review_comment_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/pulls/comments/{number}","comments_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/issues/29/comments","statuses_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/statuses/97535fc009ebc1d9a882919b3ea5ee16ed834a94","head":{"label":"dice-cyfronet:fix/tags_creator_spec","ref":"fix/tags_creator_spec","sha":"97535fc009ebc1d9a882919b3ea5ee16ed834a94","user":{"login":"dice-cyfronet","id":1628782,"avatar_url":"https://avatars.githubusercontent.com/u/1628782?v=3","gravatar_id":"","url":"https://api.github.com/users/dice-cyfronet","html_url":"https://github.com/dice-cyfronet","followers_url":"https://api.github.com/users/dice-cyfronet/followers","following_url":"https://api.github.com/users/dice-cyfronet/following{/other_user}","gists_url":"https://api.github.com/users/dice-cyfronet/gists{/gist_id}","starred_url":"https://api.github.com/users/dice-cyfronet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dice-cyfronet/subscriptions","organizations_url":"https://api.github.com/users/dice-cyfronet/orgs","repos_url":"https://api.github.com/users/dice-cyfronet/repos","events_url":"https://api.github.com/users/dice-cyfronet/events{/privacy}","received_events_url":"https://api.github.com/users/dice-cyfronet/received_events","type":"Organization","site_admin":false},"repo":{"id":25483417,"name":"atmosphere","full_name":"dice-cyfronet/atmosphere","owner":{"login":"dice-cyfronet","id":1628782,"avatar_url":"https://avatars.githubusercontent.com/u/1628782?v=3","gravatar_id":"","url":"https://api.github.com/users/dice-cyfronet","html_url":"https://github.com/dice-cyfronet","followers_url":"https://api.github.com/users/dice-cyfronet/followers","following_url":"https://api.github.com/users/dice-cyfronet/following{/other_user}","gists_url":"https://api.github.com/users/dice-cyfronet/gists{/gist_id}","starred_url":"https://api.github.com/users/dice-cyfronet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dice-cyfronet/subscriptions","organizations_url":"https://api.github.com/users/dice-cyfronet/orgs","repos_url":"https://api.github.com/users/dice-cyfronet/repos","events_url":"https://api.github.com/users/dice-cyfronet/events{/privacy}","received_events_url":"https://api.github.com/users/dice-cyfronet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dice-cyfronet/atmosphere","description":"Atmosphere cloud platform","fork":false,"url":"https://api.github.com/repos/dice-cyfronet/atmosphere","forks_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/forks","keys_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/teams","hooks_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/hooks","issue_events_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/issues/events{/number}","events_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/events","assignees_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/assignees{/user}","branches_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/branches{/branch}","tags_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/tags","blobs_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/git/refs{/sha}","trees_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/statuses/{sha}","languages_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/languages","stargazers_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/stargazers","contributors_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/contributors","subscribers_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/subscribers","subscription_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/subscription","commits_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/commits{/sha}","git_commits_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/git/commits{/sha}","comments_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/comments{/number}","issue_comment_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/issues/comments/{number}","contents_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/contents/{+path}","compare_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/merges","archive_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/downloads","issues_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/issues{/number}","pulls_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/pulls{/number}","milestones_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/milestones{/number}","notifications_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/labels{/name}","releases_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/releases{/id}","created_at":"2014-10-20T19:40:11Z","updated_at":"2014-12-05T08:24:59Z","pushed_at":"2014-12-08T11:35:13Z","git_url":"git://github.com/dice-cyfronet/atmosphere.git","ssh_url":"git@github.com:dice-cyfronet/atmosphere.git","clone_url":"https://github.com/dice-cyfronet/atmosphere.git","svn_url":"https://github.com/dice-cyfronet/atmosphere","homepage":null,"size":4828,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":12,"forks":0,"open_issues":12,"watchers":1,"default_branch":"master"}},"base":{"label":"dice-cyfronet:master","ref":"master","sha":"4bb8657f6ce4fdf7d29c6dca5f9e23261f806a82","user":{"login":"dice-cyfronet","id":1628782,"avatar_url":"https://avatars.githubusercontent.com/u/1628782?v=3","gravatar_id":"","url":"https://api.github.com/users/dice-cyfronet","html_url":"https://github.com/dice-cyfronet","followers_url":"https://api.github.com/users/dice-cyfronet/followers","following_url":"https://api.github.com/users/dice-cyfronet/following{/other_user}","gists_url":"https://api.github.com/users/dice-cyfronet/gists{/gist_id}","starred_url":"https://api.github.com/users/dice-cyfronet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dice-cyfronet/subscriptions","organizations_url":"https://api.github.com/users/dice-cyfronet/orgs","repos_url":"https://api.github.com/users/dice-cyfronet/repos","events_url":"https://api.github.com/users/dice-cyfronet/events{/privacy}","received_events_url":"https://api.github.com/users/dice-cyfronet/received_events","type":"Organization","site_admin":false},"repo":{"id":25483417,"name":"atmosphere","full_name":"dice-cyfronet/atmosphere","owner":{"login":"dice-cyfronet","id":1628782,"avatar_url":"https://avatars.githubusercontent.com/u/1628782?v=3","gravatar_id":"","url":"https://api.github.com/users/dice-cyfronet","html_url":"https://github.com/dice-cyfronet","followers_url":"https://api.github.com/users/dice-cyfronet/followers","following_url":"https://api.github.com/users/dice-cyfronet/following{/other_user}","gists_url":"https://api.github.com/users/dice-cyfronet/gists{/gist_id}","starred_url":"https://api.github.com/users/dice-cyfronet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dice-cyfronet/subscriptions","organizations_url":"https://api.github.com/users/dice-cyfronet/orgs","repos_url":"https://api.github.com/users/dice-cyfronet/repos","events_url":"https://api.github.com/users/dice-cyfronet/events{/privacy}","received_events_url":"https://api.github.com/users/dice-cyfronet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dice-cyfronet/atmosphere","description":"Atmosphere cloud platform","fork":false,"url":"https://api.github.com/repos/dice-cyfronet/atmosphere","forks_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/forks","keys_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/teams","hooks_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/hooks","issue_events_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/issues/events{/number}","events_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/events","assignees_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/assignees{/user}","branches_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/branches{/branch}","tags_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/tags","blobs_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/git/refs{/sha}","trees_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/statuses/{sha}","languages_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/languages","stargazers_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/stargazers","contributors_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/contributors","subscribers_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/subscribers","subscription_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/subscription","commits_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/commits{/sha}","git_commits_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/git/commits{/sha}","comments_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/comments{/number}","issue_comment_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/issues/comments/{number}","contents_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/contents/{+path}","compare_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/merges","archive_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/downloads","issues_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/issues{/number}","pulls_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/pulls{/number}","milestones_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/milestones{/number}","notifications_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/labels{/name}","releases_url":"https://api.github.com/repos/dice-cyfronet/atmosphere/releases{/id}","created_at":"2014-10-20T19:40:11Z","updated_at":"2014-12-05T08:24:59Z","pushed_at":"2014-12-08T11:35:13Z","git_url":"git://github.com/dice-cyfronet/atmosphere.git","ssh_url":"git@github.com:dice-cyfronet/atmosphere.git","clone_url":"https://github.com/dice-cyfronet/atmosphere.git","svn_url":"https://github.com/dice-cyfronet/atmosphere","homepage":null,"size":4828,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":12,"forks":0,"open_issues":12,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dice-cyfronet/atmosphere/pulls/29"},"html":{"href":"https://github.com/dice-cyfronet/atmosphere/pull/29"},"issue":{"href":"https://api.github.com/repos/dice-cyfronet/atmosphere/issues/29"},"comments":{"href":"https://api.github.com/repos/dice-cyfronet/atmosphere/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/dice-cyfronet/atmosphere/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/dice-cyfronet/atmosphere/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/dice-cyfronet/atmosphere/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/dice-cyfronet/atmosphere/statuses/97535fc009ebc1d9a882919b3ea5ee16ed834a94"}}}}