GitHub PullRequestReviewCommentEvent at 2014-08-03 01:25:19
Repository: oo
Actor: Exodia
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/ecomfe/oo/pulls/comments/15732536","id":15732536,"diff_hunk":"@@ -187,14 +247,22 @@ void function (define) {\n             }\n         }\n \n-        function hasOwnProperty(obj, key) {\n-            return Object.prototype.hasOwnProperty.call(obj, key);\n-        }\n-\n+        /**\n+         * toString method\n+         *\n+         * @ignore\n+         * @return {string}\n+         */\n         function toString() {\n             return this.prototype.constructor.toString();\n         }\n \n         return Class;\n     });\n-}(typeof define === 'function' && define.amd ? define : function (factory) { module.exports = factory(require); });\n\\ No newline at end of file\n+})(typeof define === 'function' && define.amd","path":"src/oo.js","position":217,"original_position":217,"commit_id":"9b6606e7333ef7a05411c2fe46ca8a90fa8e8fa2","original_commit_id":"9b6606e7333ef7a05411c2fe46ca8a90fa8e8fa2","user":{"login":"Exodia","id":2111298,"avatar_url":"https://avatars.githubusercontent.com/u/2111298?v=1","gravatar_id":"a6fbdf755a7d1abd699339a7dc0f76a5","url":"https://api.github.com/users/Exodia","html_url":"https://github.com/Exodia","followers_url":"https://api.github.com/users/Exodia/followers","following_url":"https://api.github.com/users/Exodia/following{/other_user}","gists_url":"https://api.github.com/users/Exodia/gists{/gist_id}","starred_url":"https://api.github.com/users/Exodia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Exodia/subscriptions","organizations_url":"https://api.github.com/users/Exodia/orgs","repos_url":"https://api.github.com/users/Exodia/repos","events_url":"https://api.github.com/users/Exodia/events{/privacy}","received_events_url":"https://api.github.com/users/Exodia/received_events","type":"User","site_admin":false},"body":"若要严格按照格式，这行代码应该换行才对？","created_at":"2014-08-03T01:25:19Z","updated_at":"2014-08-03T01:25:19Z","html_url":"https://github.com/ecomfe/oo/pull/12#discussion_r15732536","pull_request_url":"https://api.github.com/repos/ecomfe/oo/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/ecomfe/oo/pulls/comments/15732536"},"html":{"href":"https://github.com/ecomfe/oo/pull/12#discussion_r15732536"},"pull_request":{"href":"https://api.github.com/repos/ecomfe/oo/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/ecomfe/oo/pulls/12","id":19248581,"html_url":"https://github.com/ecomfe/oo/pull/12","diff_url":"https://github.com/ecomfe/oo/pull/12.diff","patch_url":"https://github.com/ecomfe/oo/pull/12.patch","issue_url":"https://api.github.com/repos/ecomfe/oo/issues/12","number":12,"state":"open","title":"注释补充及风格修改","user":{"login":"bobshen","id":2577670,"avatar_url":"https://avatars.githubusercontent.com/u/2577670?v=1","gravatar_id":"0c4d12be92d2a39943674fa90e0caf8d","url":"https://api.github.com/users/bobshen","html_url":"https://github.com/bobshen","followers_url":"https://api.github.com/users/bobshen/followers","following_url":"https://api.github.com/users/bobshen/following{/other_user}","gists_url":"https://api.github.com/users/bobshen/gists{/gist_id}","starred_url":"https://api.github.com/users/bobshen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobshen/subscriptions","organizations_url":"https://api.github.com/users/bobshen/orgs","repos_url":"https://api.github.com/users/bobshen/repos","events_url":"https://api.github.com/users/bobshen/events{/privacy}","received_events_url":"https://api.github.com/users/bobshen/received_events","type":"User","site_admin":false},"body":"1. 补充函数的jsdoc\r\n2. 修复大部分jshint warning\r\n3. 部分代码实现的修改","created_at":"2014-08-02T18:49:42Z","updated_at":"2014-08-03T01:25:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cf4bc88b5ae4262213098818fd74519269bb7214","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ecomfe/oo/pulls/12/commits","review_comments_url":"https://api.github.com/repos/ecomfe/oo/pulls/12/comments","review_comment_url":"https://api.github.com/repos/ecomfe/oo/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ecomfe/oo/issues/12/comments","statuses_url":"https://api.github.com/repos/ecomfe/oo/statuses/9b6606e7333ef7a05411c2fe46ca8a90fa8e8fa2","head":{"label":"bobshen:master","ref":"master","sha":"9b6606e7333ef7a05411c2fe46ca8a90fa8e8fa2","user":{"login":"bobshen","id":2577670,"avatar_url":"https://avatars.githubusercontent.com/u/2577670?v=1","gravatar_id":"0c4d12be92d2a39943674fa90e0caf8d","url":"https://api.github.com/users/bobshen","html_url":"https://github.com/bobshen","followers_url":"https://api.github.com/users/bobshen/followers","following_url":"https://api.github.com/users/bobshen/following{/other_user}","gists_url":"https://api.github.com/users/bobshen/gists{/gist_id}","starred_url":"https://api.github.com/users/bobshen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobshen/subscriptions","organizations_url":"https://api.github.com/users/bobshen/orgs","repos_url":"https://api.github.com/users/bobshen/repos","events_url":"https://api.github.com/users/bobshen/events{/privacy}","received_events_url":"https://api.github.com/users/bobshen/received_events","type":"User","site_admin":false},"repo":{"id":22548632,"name":"oo","full_name":"bobshen/oo","owner":{"login":"bobshen","id":2577670,"avatar_url":"https://avatars.githubusercontent.com/u/2577670?v=1","gravatar_id":"0c4d12be92d2a39943674fa90e0caf8d","url":"https://api.github.com/users/bobshen","html_url":"https://github.com/bobshen","followers_url":"https://api.github.com/users/bobshen/followers","following_url":"https://api.github.com/users/bobshen/following{/other_user}","gists_url":"https://api.github.com/users/bobshen/gists{/gist_id}","starred_url":"https://api.github.com/users/bobshen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobshen/subscriptions","organizations_url":"https://api.github.com/users/bobshen/orgs","repos_url":"https://api.github.com/users/bobshen/repos","events_url":"https://api.github.com/users/bobshen/events{/privacy}","received_events_url":"https://api.github.com/users/bobshen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bobshen/oo","description":"Base library for OO style programming","fork":true,"url":"https://api.github.com/repos/bobshen/oo","forks_url":"https://api.github.com/repos/bobshen/oo/forks","keys_url":"https://api.github.com/repos/bobshen/oo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bobshen/oo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bobshen/oo/teams","hooks_url":"https://api.github.com/repos/bobshen/oo/hooks","issue_events_url":"https://api.github.com/repos/bobshen/oo/issues/events{/number}","events_url":"https://api.github.com/repos/bobshen/oo/events","assignees_url":"https://api.github.com/repos/bobshen/oo/assignees{/user}","branches_url":"https://api.github.com/repos/bobshen/oo/branches{/branch}","tags_url":"https://api.github.com/repos/bobshen/oo/tags","blobs_url":"https://api.github.com/repos/bobshen/oo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bobshen/oo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bobshen/oo/git/refs{/sha}","trees_url":"https://api.github.com/repos/bobshen/oo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bobshen/oo/statuses/{sha}","languages_url":"https://api.github.com/repos/bobshen/oo/languages","stargazers_url":"https://api.github.com/repos/bobshen/oo/stargazers","contributors_url":"https://api.github.com/repos/bobshen/oo/contributors","subscribers_url":"https://api.github.com/repos/bobshen/oo/subscribers","subscription_url":"https://api.github.com/repos/bobshen/oo/subscription","commits_url":"https://api.github.com/repos/bobshen/oo/commits{/sha}","git_commits_url":"https://api.github.com/repos/bobshen/oo/git/commits{/sha}","comments_url":"https://api.github.com/repos/bobshen/oo/comments{/number}","issue_comment_url":"https://api.github.com/repos/bobshen/oo/issues/comments/{number}","contents_url":"https://api.github.com/repos/bobshen/oo/contents/{+path}","compare_url":"https://api.github.com/repos/bobshen/oo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bobshen/oo/merges","archive_url":"https://api.github.com/repos/bobshen/oo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bobshen/oo/downloads","issues_url":"https://api.github.com/repos/bobshen/oo/issues{/number}","pulls_url":"https://api.github.com/repos/bobshen/oo/pulls{/number}","milestones_url":"https://api.github.com/repos/bobshen/oo/milestones{/number}","notifications_url":"https://api.github.com/repos/bobshen/oo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bobshen/oo/labels{/name}","releases_url":"https://api.github.com/repos/bobshen/oo/releases{/id}","created_at":"2014-08-02T15:22:01Z","updated_at":"2014-08-02T18:37:10Z","pushed_at":"2014-08-02T18:37:10Z","git_url":"git://github.com/bobshen/oo.git","ssh_url":"git@github.com:bobshen/oo.git","clone_url":"https://github.com/bobshen/oo.git","svn_url":"https://github.com/bobshen/oo","homepage":null,"size":119,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ecomfe:master","ref":"master","sha":"b2adc83be4d2e60737eaf1b48fea8d35118dcfcc","user":{"login":"ecomfe","id":2268460,"avatar_url":"https://avatars.githubusercontent.com/u/2268460?v=1","gravatar_id":"52eec96c6d0e280a2c9b07720b72d13f","url":"https://api.github.com/users/ecomfe","html_url":"https://github.com/ecomfe","followers_url":"https://api.github.com/users/ecomfe/followers","following_url":"https://api.github.com/users/ecomfe/following{/other_user}","gists_url":"https://api.github.com/users/ecomfe/gists{/gist_id}","starred_url":"https://api.github.com/users/ecomfe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ecomfe/subscriptions","organizations_url":"https://api.github.com/users/ecomfe/orgs","repos_url":"https://api.github.com/users/ecomfe/repos","events_url":"https://api.github.com/users/ecomfe/events{/privacy}","received_events_url":"https://api.github.com/users/ecomfe/received_events","type":"Organization","site_admin":false},"repo":{"id":19460517,"name":"oo","full_name":"ecomfe/oo","owner":{"login":"ecomfe","id":2268460,"avatar_url":"https://avatars.githubusercontent.com/u/2268460?v=1","gravatar_id":"52eec96c6d0e280a2c9b07720b72d13f","url":"https://api.github.com/users/ecomfe","html_url":"https://github.com/ecomfe","followers_url":"https://api.github.com/users/ecomfe/followers","following_url":"https://api.github.com/users/ecomfe/following{/other_user}","gists_url":"https://api.github.com/users/ecomfe/gists{/gist_id}","starred_url":"https://api.github.com/users/ecomfe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ecomfe/subscriptions","organizations_url":"https://api.github.com/users/ecomfe/orgs","repos_url":"https://api.github.com/users/ecomfe/repos","events_url":"https://api.github.com/users/ecomfe/events{/privacy}","received_events_url":"https://api.github.com/users/ecomfe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ecomfe/oo","description":"Base library for OO style programming","fork":false,"url":"https://api.github.com/repos/ecomfe/oo","forks_url":"https://api.github.com/repos/ecomfe/oo/forks","keys_url":"https://api.github.com/repos/ecomfe/oo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ecomfe/oo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ecomfe/oo/teams","hooks_url":"https://api.github.com/repos/ecomfe/oo/hooks","issue_events_url":"https://api.github.com/repos/ecomfe/oo/issues/events{/number}","events_url":"https://api.github.com/repos/ecomfe/oo/events","assignees_url":"https://api.github.com/repos/ecomfe/oo/assignees{/user}","branches_url":"https://api.github.com/repos/ecomfe/oo/branches{/branch}","tags_url":"https://api.github.com/repos/ecomfe/oo/tags","blobs_url":"https://api.github.com/repos/ecomfe/oo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ecomfe/oo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ecomfe/oo/git/refs{/sha}","trees_url":"https://api.github.com/repos/ecomfe/oo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ecomfe/oo/statuses/{sha}","languages_url":"https://api.github.com/repos/ecomfe/oo/languages","stargazers_url":"https://api.github.com/repos/ecomfe/oo/stargazers","contributors_url":"https://api.github.com/repos/ecomfe/oo/contributors","subscribers_url":"https://api.github.com/repos/ecomfe/oo/subscribers","subscription_url":"https://api.github.com/repos/ecomfe/oo/subscription","commits_url":"https://api.github.com/repos/ecomfe/oo/commits{/sha}","git_commits_url":"https://api.github.com/repos/ecomfe/oo/git/commits{/sha}","comments_url":"https://api.github.com/repos/ecomfe/oo/comments{/number}","issue_comment_url":"https://api.github.com/repos/ecomfe/oo/issues/comments/{number}","contents_url":"https://api.github.com/repos/ecomfe/oo/contents/{+path}","compare_url":"https://api.github.com/repos/ecomfe/oo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ecomfe/oo/merges","archive_url":"https://api.github.com/repos/ecomfe/oo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ecomfe/oo/downloads","issues_url":"https://api.github.com/repos/ecomfe/oo/issues{/number}","pulls_url":"https://api.github.com/repos/ecomfe/oo/pulls{/number}","milestones_url":"https://api.github.com/repos/ecomfe/oo/milestones{/number}","notifications_url":"https://api.github.com/repos/ecomfe/oo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ecomfe/oo/labels{/name}","releases_url":"https://api.github.com/repos/ecomfe/oo/releases{/id}","created_at":"2014-05-05T15:24:28Z","updated_at":"2014-07-09T07:39:19Z","pushed_at":"2014-07-18T07:57:53Z","git_url":"git://github.com/ecomfe/oo.git","ssh_url":"git@github.com:ecomfe/oo.git","clone_url":"https://github.com/ecomfe/oo.git","svn_url":"https://github.com/ecomfe/oo","homepage":null,"size":370,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":2,"mirror_url":null,"open_issues_count":8,"forks":2,"open_issues":8,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ecomfe/oo/pulls/12"},"html":{"href":"https://github.com/ecomfe/oo/pull/12"},"issue":{"href":"https://api.github.com/repos/ecomfe/oo/issues/12"},"comments":{"href":"https://api.github.com/repos/ecomfe/oo/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/ecomfe/oo/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/ecomfe/oo/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ecomfe/oo/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/ecomfe/oo/statuses/9b6606e7333ef7a05411c2fe46ca8a90fa8e8fa2"}}}}