GitHub PullRequestEvent at 2014-05-26 23:28:31
Repository: GPUImage
Actor: BradLarson
Payload: {"action":"closed","number":1570,"pull_request":{"url":"https://api.github.com/repos/BradLarson/GPUImage/pulls/1570","id":15857842,"html_url":"https://github.com/BradLarson/GPUImage/pull/1570","diff_url":"https://github.com/BradLarson/GPUImage/pull/1570.diff","patch_url":"https://github.com/BradLarson/GPUImage/pull/1570.patch","issue_url":"https://api.github.com/repos/BradLarson/GPUImage/issues/1570","number":1570,"state":"closed","title":"Fix setFloatArray:... so that it copies the data in case it's on the stack","user":{"login":"cobbal","id":180339,"avatar_url":"https://avatars.githubusercontent.com/u/180339?","gravatar_id":"cb47c3d6646d7672839881f478d85b2f","url":"https://api.github.com/users/cobbal","html_url":"https://github.com/cobbal","followers_url":"https://api.github.com/users/cobbal/followers","following_url":"https://api.github.com/users/cobbal/following{/other_user}","gists_url":"https://api.github.com/users/cobbal/gists{/gist_id}","starred_url":"https://api.github.com/users/cobbal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cobbal/subscriptions","organizations_url":"https://api.github.com/users/cobbal/orgs","repos_url":"https://api.github.com/users/cobbal/repos","events_url":"https://api.github.com/users/cobbal/events{/privacy}","received_events_url":"https://api.github.com/users/cobbal/received_events","type":"User","site_admin":false},"body":"The function previously relied on `arrayValue' remaining in place long\r\nenough for the async call to read it, which doesn't always happen,\r\nespecially if it was allocated on the stack.\r\n\r\nI think this also was the cause of https://github.com/BradLarson/GPUImage/issues/847","created_at":"2014-05-14T02:09:18Z","updated_at":"2014-05-26T23:28:30Z","closed_at":"2014-05-26T23:28:30Z","merged_at":"2014-05-26T23:28:30Z","merge_commit_sha":"fa8a8cf0dc1859c7c5da4577f7651bb76d935a18","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/BradLarson/GPUImage/pulls/1570/commits","review_comments_url":"https://api.github.com/repos/BradLarson/GPUImage/pulls/1570/comments","review_comment_url":"https://api.github.com/repos/BradLarson/GPUImage/pulls/comments/{number}","comments_url":"https://api.github.com/repos/BradLarson/GPUImage/issues/1570/comments","statuses_url":"https://api.github.com/repos/BradLarson/GPUImage/statuses/437acb0a080a9afc923bef633ad3e9154dd0d1ea","head":{"label":"cobbal:master","ref":"master","sha":"437acb0a080a9afc923bef633ad3e9154dd0d1ea","user":{"login":"cobbal","id":180339,"avatar_url":"https://avatars.githubusercontent.com/u/180339?","gravatar_id":"cb47c3d6646d7672839881f478d85b2f","url":"https://api.github.com/users/cobbal","html_url":"https://github.com/cobbal","followers_url":"https://api.github.com/users/cobbal/followers","following_url":"https://api.github.com/users/cobbal/following{/other_user}","gists_url":"https://api.github.com/users/cobbal/gists{/gist_id}","starred_url":"https://api.github.com/users/cobbal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cobbal/subscriptions","organizations_url":"https://api.github.com/users/cobbal/orgs","repos_url":"https://api.github.com/users/cobbal/repos","events_url":"https://api.github.com/users/cobbal/events{/privacy}","received_events_url":"https://api.github.com/users/cobbal/received_events","type":"User","site_admin":false},"repo":{"id":19760308,"name":"GPUImage","full_name":"cobbal/GPUImage","owner":{"login":"cobbal","id":180339,"avatar_url":"https://avatars.githubusercontent.com/u/180339?","gravatar_id":"cb47c3d6646d7672839881f478d85b2f","url":"https://api.github.com/users/cobbal","html_url":"https://github.com/cobbal","followers_url":"https://api.github.com/users/cobbal/followers","following_url":"https://api.github.com/users/cobbal/following{/other_user}","gists_url":"https://api.github.com/users/cobbal/gists{/gist_id}","starred_url":"https://api.github.com/users/cobbal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cobbal/subscriptions","organizations_url":"https://api.github.com/users/cobbal/orgs","repos_url":"https://api.github.com/users/cobbal/repos","events_url":"https://api.github.com/users/cobbal/events{/privacy}","received_events_url":"https://api.github.com/users/cobbal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cobbal/GPUImage","description":"An open source iOS framework for GPU-based image and video processing","fork":true,"url":"https://api.github.com/repos/cobbal/GPUImage","forks_url":"https://api.github.com/repos/cobbal/GPUImage/forks","keys_url":"https://api.github.com/repos/cobbal/GPUImage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cobbal/GPUImage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cobbal/GPUImage/teams","hooks_url":"https://api.github.com/repos/cobbal/GPUImage/hooks","issue_events_url":"https://api.github.com/repos/cobbal/GPUImage/issues/events{/number}","events_url":"https://api.github.com/repos/cobbal/GPUImage/events","assignees_url":"https://api.github.com/repos/cobbal/GPUImage/assignees{/user}","branches_url":"https://api.github.com/repos/cobbal/GPUImage/branches{/branch}","tags_url":"https://api.github.com/repos/cobbal/GPUImage/tags","blobs_url":"https://api.github.com/repos/cobbal/GPUImage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cobbal/GPUImage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cobbal/GPUImage/git/refs{/sha}","trees_url":"https://api.github.com/repos/cobbal/GPUImage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cobbal/GPUImage/statuses/{sha}","languages_url":"https://api.github.com/repos/cobbal/GPUImage/languages","stargazers_url":"https://api.github.com/repos/cobbal/GPUImage/stargazers","contributors_url":"https://api.github.com/repos/cobbal/GPUImage/contributors","subscribers_url":"https://api.github.com/repos/cobbal/GPUImage/subscribers","subscription_url":"https://api.github.com/repos/cobbal/GPUImage/subscription","commits_url":"https://api.github.com/repos/cobbal/GPUImage/commits{/sha}","git_commits_url":"https://api.github.com/repos/cobbal/GPUImage/git/commits{/sha}","comments_url":"https://api.github.com/repos/cobbal/GPUImage/comments{/number}","issue_comment_url":"https://api.github.com/repos/cobbal/GPUImage/issues/comments/{number}","contents_url":"https://api.github.com/repos/cobbal/GPUImage/contents/{+path}","compare_url":"https://api.github.com/repos/cobbal/GPUImage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cobbal/GPUImage/merges","archive_url":"https://api.github.com/repos/cobbal/GPUImage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cobbal/GPUImage/downloads","issues_url":"https://api.github.com/repos/cobbal/GPUImage/issues{/number}","pulls_url":"https://api.github.com/repos/cobbal/GPUImage/pulls{/number}","milestones_url":"https://api.github.com/repos/cobbal/GPUImage/milestones{/number}","notifications_url":"https://api.github.com/repos/cobbal/GPUImage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cobbal/GPUImage/labels{/name}","releases_url":"https://api.github.com/repos/cobbal/GPUImage/releases{/id}","created_at":"2014-05-14T00:08:28Z","updated_at":"2014-05-26T23:28:30Z","pushed_at":"2014-05-14T00:40:34Z","git_url":"git://github.com/cobbal/GPUImage.git","ssh_url":"git@github.com:cobbal/GPUImage.git","clone_url":"https://github.com/cobbal/GPUImage.git","svn_url":"https://github.com/cobbal/GPUImage","homepage":"http://www.sunsetlakesoftware.com/2012/02/12/introducing-gpuimage-framework","size":11637,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"BradLarson:master","ref":"master","sha":"9f95bc95e2efb62524efbf1d2e65fe682c9757c3","user":{"login":"BradLarson","id":954279,"avatar_url":"https://avatars.githubusercontent.com/u/954279?","gravatar_id":"52a2ffb44b1c11ab9001cb67e0a0021c","url":"https://api.github.com/users/BradLarson","html_url":"https://github.com/BradLarson","followers_url":"https://api.github.com/users/BradLarson/followers","following_url":"https://api.github.com/users/BradLarson/following{/other_user}","gists_url":"https://api.github.com/users/BradLarson/gists{/gist_id}","starred_url":"https://api.github.com/users/BradLarson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BradLarson/subscriptions","organizations_url":"https://api.github.com/users/BradLarson/orgs","repos_url":"https://api.github.com/users/BradLarson/repos","events_url":"https://api.github.com/users/BradLarson/events{/privacy}","received_events_url":"https://api.github.com/users/BradLarson/received_events","type":"User","site_admin":false},"repo":{"id":3431083,"name":"GPUImage","full_name":"BradLarson/GPUImage","owner":{"login":"BradLarson","id":954279,"avatar_url":"https://avatars.githubusercontent.com/u/954279?","gravatar_id":"52a2ffb44b1c11ab9001cb67e0a0021c","url":"https://api.github.com/users/BradLarson","html_url":"https://github.com/BradLarson","followers_url":"https://api.github.com/users/BradLarson/followers","following_url":"https://api.github.com/users/BradLarson/following{/other_user}","gists_url":"https://api.github.com/users/BradLarson/gists{/gist_id}","starred_url":"https://api.github.com/users/BradLarson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BradLarson/subscriptions","organizations_url":"https://api.github.com/users/BradLarson/orgs","repos_url":"https://api.github.com/users/BradLarson/repos","events_url":"https://api.github.com/users/BradLarson/events{/privacy}","received_events_url":"https://api.github.com/users/BradLarson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BradLarson/GPUImage","description":"An open source iOS framework for GPU-based image and video processing","fork":false,"url":"https://api.github.com/repos/BradLarson/GPUImage","forks_url":"https://api.github.com/repos/BradLarson/GPUImage/forks","keys_url":"https://api.github.com/repos/BradLarson/GPUImage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BradLarson/GPUImage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BradLarson/GPUImage/teams","hooks_url":"https://api.github.com/repos/BradLarson/GPUImage/hooks","issue_events_url":"https://api.github.com/repos/BradLarson/GPUImage/issues/events{/number}","events_url":"https://api.github.com/repos/BradLarson/GPUImage/events","assignees_url":"https://api.github.com/repos/BradLarson/GPUImage/assignees{/user}","branches_url":"https://api.github.com/repos/BradLarson/GPUImage/branches{/branch}","tags_url":"https://api.github.com/repos/BradLarson/GPUImage/tags","blobs_url":"https://api.github.com/repos/BradLarson/GPUImage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BradLarson/GPUImage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BradLarson/GPUImage/git/refs{/sha}","trees_url":"https://api.github.com/repos/BradLarson/GPUImage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BradLarson/GPUImage/statuses/{sha}","languages_url":"https://api.github.com/repos/BradLarson/GPUImage/languages","stargazers_url":"https://api.github.com/repos/BradLarson/GPUImage/stargazers","contributors_url":"https://api.github.com/repos/BradLarson/GPUImage/contributors","subscribers_url":"https://api.github.com/repos/BradLarson/GPUImage/subscribers","subscription_url":"https://api.github.com/repos/BradLarson/GPUImage/subscription","commits_url":"https://api.github.com/repos/BradLarson/GPUImage/commits{/sha}","git_commits_url":"https://api.github.com/repos/BradLarson/GPUImage/git/commits{/sha}","comments_url":"https://api.github.com/repos/BradLarson/GPUImage/comments{/number}","issue_comment_url":"https://api.github.com/repos/BradLarson/GPUImage/issues/comments/{number}","contents_url":"https://api.github.com/repos/BradLarson/GPUImage/contents/{+path}","compare_url":"https://api.github.com/repos/BradLarson/GPUImage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BradLarson/GPUImage/merges","archive_url":"https://api.github.com/repos/BradLarson/GPUImage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BradLarson/GPUImage/downloads","issues_url":"https://api.github.com/repos/BradLarson/GPUImage/issues{/number}","pulls_url":"https://api.github.com/repos/BradLarson/GPUImage/pulls{/number}","milestones_url":"https://api.github.com/repos/BradLarson/GPUImage/milestones{/number}","notifications_url":"https://api.github.com/repos/BradLarson/GPUImage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BradLarson/GPUImage/labels{/name}","releases_url":"https://api.github.com/repos/BradLarson/GPUImage/releases{/id}","created_at":"2012-02-13T15:20:02Z","updated_at":"2014-05-26T23:28:30Z","pushed_at":"2014-05-26T23:28:30Z","git_url":"git://github.com/BradLarson/GPUImage.git","ssh_url":"git@github.com:BradLarson/GPUImage.git","clone_url":"https://github.com/BradLarson/GPUImage.git","svn_url":"https://github.com/BradLarson/GPUImage","homepage":"http://www.sunsetlakesoftware.com/2012/02/12/introducing-gpuimage-framework","size":44524,"stargazers_count":6071,"watchers_count":6071,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1471,"mirror_url":null,"open_issues_count":537,"forks":1471,"open_issues":537,"watchers":6071,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BradLarson/GPUImage/pulls/1570"},"html":{"href":"https://github.com/BradLarson/GPUImage/pull/1570"},"issue":{"href":"https://api.github.com/repos/BradLarson/GPUImage/issues/1570"},"comments":{"href":"https://api.github.com/repos/BradLarson/GPUImage/issues/1570/comments"},"review_comments":{"href":"https://api.github.com/repos/BradLarson/GPUImage/pulls/1570/comments"},"review_comment":{"href":"https://api.github.com/repos/BradLarson/GPUImage/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/BradLarson/GPUImage/pulls/1570/commits"},"statuses":{"href":"https://api.github.com/repos/BradLarson/GPUImage/statuses/437acb0a080a9afc923bef633ad3e9154dd0d1ea"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"BradLarson","id":954279,"avatar_url":"https://avatars.githubusercontent.com/u/954279?","gravatar_id":"52a2ffb44b1c11ab9001cb67e0a0021c","url":"https://api.github.com/users/BradLarson","html_url":"https://github.com/BradLarson","followers_url":"https://api.github.com/users/BradLarson/followers","following_url":"https://api.github.com/users/BradLarson/following{/other_user}","gists_url":"https://api.github.com/users/BradLarson/gists{/gist_id}","starred_url":"https://api.github.com/users/BradLarson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BradLarson/subscriptions","organizations_url":"https://api.github.com/users/BradLarson/orgs","repos_url":"https://api.github.com/users/BradLarson/repos","events_url":"https://api.github.com/users/BradLarson/events{/privacy}","received_events_url":"https://api.github.com/users/BradLarson/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":4,"deletions":1,"changed_files":1}}