GitHub PullRequestReviewCommentEvent at 2014-11-26 16:22:07
Repository: mconf-web
Actor: daronco
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mconf/mconf-web/pulls/comments/20945018","id":20945018,"diff_hunk":"@@ -0,0 +1,27 @@\n+# -*- coding: utf-8 -*-\n+# This file is part of Mconf-Web, a web application that provides access\n+# to the Mconf webconferencing system. Copyright (C) 2010-2012 Mconf\n+#\n+# This file is licensed under the Affero General Public License version\n+# 3 or later. See the LICENSE file.\n+\n+class UserMailer < BaseMailer\n+\n+  def default_email(user_id, email_name)\n+    user = User.find(user_id)\n+    I18n.with_locale(default_email_locale(user, nil)) do\n+      @user_name = user.name\n+      @subject = t(\"user_mailer.#{email_name}.subject\")\n+      create_email(user.email, Site.current.smtp_sender, @subject)\n+    end\n+  end\n+\n+  def registration_notification_email(user_id)\n+    default_email(user_id, 'registration_notification_email')\n+  end\n+\n+  def waiting_for_approval_email(user_id)","path":"app/mailers/user_mailer.rb","position":23,"original_position":23,"commit_id":"2d1ce3df6ff4638b99295f072c8956f656949c47","original_commit_id":"2d1ce3df6ff4638b99295f072c8956f656949c47","user":{"login":"daronco","id":498566,"avatar_url":"https://avatars.githubusercontent.com/u/498566?v=3","gravatar_id":"","url":"https://api.github.com/users/daronco","html_url":"https://github.com/daronco","followers_url":"https://api.github.com/users/daronco/followers","following_url":"https://api.github.com/users/daronco/following{/other_user}","gists_url":"https://api.github.com/users/daronco/gists{/gist_id}","starred_url":"https://api.github.com/users/daronco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daronco/subscriptions","organizations_url":"https://api.github.com/users/daronco/orgs","repos_url":"https://api.github.com/users/daronco/repos","events_url":"https://api.github.com/users/daronco/events{/privacy}","received_events_url":"https://api.github.com/users/daronco/received_events","type":"User","site_admin":false},"body":"Do we really need this? It's not being called anywhere.\r\n\r\nOur \"waiting for approval email\" for now is [devise's registration confirmation email](https://github.com/mconf/mconf-web/blob/master/app/views/devise/mailer/confirmation_instructions.html.haml#L10).","created_at":"2014-11-26T16:22:07Z","updated_at":"2014-11-26T16:22:07Z","html_url":"https://github.com/mconf/mconf-web/pull/54#discussion_r20945018","pull_request_url":"https://api.github.com/repos/mconf/mconf-web/pulls/54","_links":{"self":{"href":"https://api.github.com/repos/mconf/mconf-web/pulls/comments/20945018"},"html":{"href":"https://github.com/mconf/mconf-web/pull/54#discussion_r20945018"},"pull_request":{"href":"https://api.github.com/repos/mconf/mconf-web/pulls/54"}}},"pull_request":{"url":"https://api.github.com/repos/mconf/mconf-web/pulls/54","id":24947688,"html_url":"https://github.com/mconf/mconf-web/pull/54","diff_url":"https://github.com/mconf/mconf-web/pull/54.diff","patch_url":"https://github.com/mconf/mconf-web/pull/54.patch","issue_url":"https://api.github.com/repos/mconf/mconf-web/issues/54","number":54,"state":"open","locked":false,"title":"Bug1370 -  Confirmation emails for registration via Shibboleth and LDAP","user":{"login":"lfzawacki","id":33211,"avatar_url":"https://avatars.githubusercontent.com/u/33211?v=3","gravatar_id":"","url":"https://api.github.com/users/lfzawacki","html_url":"https://github.com/lfzawacki","followers_url":"https://api.github.com/users/lfzawacki/followers","following_url":"https://api.github.com/users/lfzawacki/following{/other_user}","gists_url":"https://api.github.com/users/lfzawacki/gists{/gist_id}","starred_url":"https://api.github.com/users/lfzawacki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lfzawacki/subscriptions","organizations_url":"https://api.github.com/users/lfzawacki/orgs","repos_url":"https://api.github.com/users/lfzawacki/repos","events_url":"https://api.github.com/users/lfzawacki/events{/privacy}","received_events_url":"https://api.github.com/users/lfzawacki/received_events","type":"User","site_admin":false},"body":"For now the email code is called after creation inside ldap and shibolleth libs. This could be made better if we had a recent activity for user creation and linked it with the tokens (ldaptoken and shibtoken), then we could have a worker that searched for these activities and created emails with notifications.","created_at":"2014-11-24T17:12:48Z","updated_at":"2014-11-26T16:22:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4339b5c116ac56908ca1e5082ac005750945582a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mconf/mconf-web/pulls/54/commits","review_comments_url":"https://api.github.com/repos/mconf/mconf-web/pulls/54/comments","review_comment_url":"https://api.github.com/repos/mconf/mconf-web/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mconf/mconf-web/issues/54/comments","statuses_url":"https://api.github.com/repos/mconf/mconf-web/statuses/2d1ce3df6ff4638b99295f072c8956f656949c47","head":{"label":"mconf:bug1370","ref":"bug1370","sha":"2d1ce3df6ff4638b99295f072c8956f656949c47","user":{"login":"mconf","id":524474,"avatar_url":"https://avatars.githubusercontent.com/u/524474?v=3","gravatar_id":"","url":"https://api.github.com/users/mconf","html_url":"https://github.com/mconf","followers_url":"https://api.github.com/users/mconf/followers","following_url":"https://api.github.com/users/mconf/following{/other_user}","gists_url":"https://api.github.com/users/mconf/gists{/gist_id}","starred_url":"https://api.github.com/users/mconf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mconf/subscriptions","organizations_url":"https://api.github.com/users/mconf/orgs","repos_url":"https://api.github.com/users/mconf/repos","events_url":"https://api.github.com/users/mconf/events{/privacy}","received_events_url":"https://api.github.com/users/mconf/received_events","type":"Organization","site_admin":false},"repo":{"id":1287796,"name":"mconf-web","full_name":"mconf/mconf-web","owner":{"login":"mconf","id":524474,"avatar_url":"https://avatars.githubusercontent.com/u/524474?v=3","gravatar_id":"","url":"https://api.github.com/users/mconf","html_url":"https://github.com/mconf","followers_url":"https://api.github.com/users/mconf/followers","following_url":"https://api.github.com/users/mconf/following{/other_user}","gists_url":"https://api.github.com/users/mconf/gists{/gist_id}","starred_url":"https://api.github.com/users/mconf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mconf/subscriptions","organizations_url":"https://api.github.com/users/mconf/orgs","repos_url":"https://api.github.com/users/mconf/repos","events_url":"https://api.github.com/users/mconf/events{/privacy}","received_events_url":"https://api.github.com/users/mconf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mconf/mconf-web","description":"Mconf-Web is the web application that controls the access to the Mconf webconferencing system","fork":false,"url":"https://api.github.com/repos/mconf/mconf-web","forks_url":"https://api.github.com/repos/mconf/mconf-web/forks","keys_url":"https://api.github.com/repos/mconf/mconf-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mconf/mconf-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mconf/mconf-web/teams","hooks_url":"https://api.github.com/repos/mconf/mconf-web/hooks","issue_events_url":"https://api.github.com/repos/mconf/mconf-web/issues/events{/number}","events_url":"https://api.github.com/repos/mconf/mconf-web/events","assignees_url":"https://api.github.com/repos/mconf/mconf-web/assignees{/user}","branches_url":"https://api.github.com/repos/mconf/mconf-web/branches{/branch}","tags_url":"https://api.github.com/repos/mconf/mconf-web/tags","blobs_url":"https://api.github.com/repos/mconf/mconf-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mconf/mconf-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mconf/mconf-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/mconf/mconf-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mconf/mconf-web/statuses/{sha}","languages_url":"https://api.github.com/repos/mconf/mconf-web/languages","stargazers_url":"https://api.github.com/repos/mconf/mconf-web/stargazers","contributors_url":"https://api.github.com/repos/mconf/mconf-web/contributors","subscribers_url":"https://api.github.com/repos/mconf/mconf-web/subscribers","subscription_url":"https://api.github.com/repos/mconf/mconf-web/subscription","commits_url":"https://api.github.com/repos/mconf/mconf-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/mconf/mconf-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/mconf/mconf-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/mconf/mconf-web/issues/comments/{number}","contents_url":"https://api.github.com/repos/mconf/mconf-web/contents/{+path}","compare_url":"https://api.github.com/repos/mconf/mconf-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mconf/mconf-web/merges","archive_url":"https://api.github.com/repos/mconf/mconf-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mconf/mconf-web/downloads","issues_url":"https://api.github.com/repos/mconf/mconf-web/issues{/number}","pulls_url":"https://api.github.com/repos/mconf/mconf-web/pulls{/number}","milestones_url":"https://api.github.com/repos/mconf/mconf-web/milestones{/number}","notifications_url":"https://api.github.com/repos/mconf/mconf-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mconf/mconf-web/labels{/name}","releases_url":"https://api.github.com/repos/mconf/mconf-web/releases{/id}","created_at":"2011-01-24T14:07:02Z","updated_at":"2014-11-25T19:17:24Z","pushed_at":"2014-11-26T14:58:58Z","git_url":"git://github.com/mconf/mconf-web.git","ssh_url":"git@github.com:mconf/mconf-web.git","clone_url":"https://github.com/mconf/mconf-web.git","svn_url":"https://github.com/mconf/mconf-web","homepage":"http://mconf.org","size":94241,"stargazers_count":36,"watchers_count":36,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"open_issues_count":5,"forks":37,"open_issues":5,"watchers":36,"default_branch":"master"}},"base":{"label":"mconf:master","ref":"master","sha":"60d47bba9d01b2b104b67ccc88a4700cd7ad689f","user":{"login":"mconf","id":524474,"avatar_url":"https://avatars.githubusercontent.com/u/524474?v=3","gravatar_id":"","url":"https://api.github.com/users/mconf","html_url":"https://github.com/mconf","followers_url":"https://api.github.com/users/mconf/followers","following_url":"https://api.github.com/users/mconf/following{/other_user}","gists_url":"https://api.github.com/users/mconf/gists{/gist_id}","starred_url":"https://api.github.com/users/mconf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mconf/subscriptions","organizations_url":"https://api.github.com/users/mconf/orgs","repos_url":"https://api.github.com/users/mconf/repos","events_url":"https://api.github.com/users/mconf/events{/privacy}","received_events_url":"https://api.github.com/users/mconf/received_events","type":"Organization","site_admin":false},"repo":{"id":1287796,"name":"mconf-web","full_name":"mconf/mconf-web","owner":{"login":"mconf","id":524474,"avatar_url":"https://avatars.githubusercontent.com/u/524474?v=3","gravatar_id":"","url":"https://api.github.com/users/mconf","html_url":"https://github.com/mconf","followers_url":"https://api.github.com/users/mconf/followers","following_url":"https://api.github.com/users/mconf/following{/other_user}","gists_url":"https://api.github.com/users/mconf/gists{/gist_id}","starred_url":"https://api.github.com/users/mconf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mconf/subscriptions","organizations_url":"https://api.github.com/users/mconf/orgs","repos_url":"https://api.github.com/users/mconf/repos","events_url":"https://api.github.com/users/mconf/events{/privacy}","received_events_url":"https://api.github.com/users/mconf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mconf/mconf-web","description":"Mconf-Web is the web application that controls the access to the Mconf webconferencing system","fork":false,"url":"https://api.github.com/repos/mconf/mconf-web","forks_url":"https://api.github.com/repos/mconf/mconf-web/forks","keys_url":"https://api.github.com/repos/mconf/mconf-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mconf/mconf-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mconf/mconf-web/teams","hooks_url":"https://api.github.com/repos/mconf/mconf-web/hooks","issue_events_url":"https://api.github.com/repos/mconf/mconf-web/issues/events{/number}","events_url":"https://api.github.com/repos/mconf/mconf-web/events","assignees_url":"https://api.github.com/repos/mconf/mconf-web/assignees{/user}","branches_url":"https://api.github.com/repos/mconf/mconf-web/branches{/branch}","tags_url":"https://api.github.com/repos/mconf/mconf-web/tags","blobs_url":"https://api.github.com/repos/mconf/mconf-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mconf/mconf-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mconf/mconf-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/mconf/mconf-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mconf/mconf-web/statuses/{sha}","languages_url":"https://api.github.com/repos/mconf/mconf-web/languages","stargazers_url":"https://api.github.com/repos/mconf/mconf-web/stargazers","contributors_url":"https://api.github.com/repos/mconf/mconf-web/contributors","subscribers_url":"https://api.github.com/repos/mconf/mconf-web/subscribers","subscription_url":"https://api.github.com/repos/mconf/mconf-web/subscription","commits_url":"https://api.github.com/repos/mconf/mconf-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/mconf/mconf-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/mconf/mconf-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/mconf/mconf-web/issues/comments/{number}","contents_url":"https://api.github.com/repos/mconf/mconf-web/contents/{+path}","compare_url":"https://api.github.com/repos/mconf/mconf-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mconf/mconf-web/merges","archive_url":"https://api.github.com/repos/mconf/mconf-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mconf/mconf-web/downloads","issues_url":"https://api.github.com/repos/mconf/mconf-web/issues{/number}","pulls_url":"https://api.github.com/repos/mconf/mconf-web/pulls{/number}","milestones_url":"https://api.github.com/repos/mconf/mconf-web/milestones{/number}","notifications_url":"https://api.github.com/repos/mconf/mconf-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mconf/mconf-web/labels{/name}","releases_url":"https://api.github.com/repos/mconf/mconf-web/releases{/id}","created_at":"2011-01-24T14:07:02Z","updated_at":"2014-11-25T19:17:24Z","pushed_at":"2014-11-26T14:58:58Z","git_url":"git://github.com/mconf/mconf-web.git","ssh_url":"git@github.com:mconf/mconf-web.git","clone_url":"https://github.com/mconf/mconf-web.git","svn_url":"https://github.com/mconf/mconf-web","homepage":"http://mconf.org","size":94241,"stargazers_count":36,"watchers_count":36,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"open_issues_count":5,"forks":37,"open_issues":5,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mconf/mconf-web/pulls/54"},"html":{"href":"https://github.com/mconf/mconf-web/pull/54"},"issue":{"href":"https://api.github.com/repos/mconf/mconf-web/issues/54"},"comments":{"href":"https://api.github.com/repos/mconf/mconf-web/issues/54/comments"},"review_comments":{"href":"https://api.github.com/repos/mconf/mconf-web/pulls/54/comments"},"review_comment":{"href":"https://api.github.com/repos/mconf/mconf-web/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mconf/mconf-web/pulls/54/commits"},"statuses":{"href":"https://api.github.com/repos/mconf/mconf-web/statuses/2d1ce3df6ff4638b99295f072c8956f656949c47"}}}}