GitHub PullRequestReviewCommentEvent at 2014-12-22 13:52:55
Repository: buffer
Actor: marcomorain
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/clibs/buffer/pulls/comments/22166466","id":22166466,"diff_hunk":"@@ -144,21 +144,29 @@ buffer_resize(buffer_t *self, size_t n) {\n  */\n \n int\n-buffer_append(buffer_t *self, char *str) {\n-  size_t len = strlen(str);\n+buffer_append(buffer_t *self, const char *str) {\n+  return buffer_append_n(self, str, strlen(str));","path":"buffer.c","position":7,"original_position":7,"commit_id":"8ba3f52086900d20d13bc210aabb12efa29f1ec6","original_commit_id":"8ba3f52086900d20d13bc210aabb12efa29f1ec6","user":{"login":"marcomorain","id":448001,"avatar_url":"https://avatars.githubusercontent.com/u/448001?v=3","gravatar_id":"","url":"https://api.github.com/users/marcomorain","html_url":"https://github.com/marcomorain","followers_url":"https://api.github.com/users/marcomorain/followers","following_url":"https://api.github.com/users/marcomorain/following{/other_user}","gists_url":"https://api.github.com/users/marcomorain/gists{/gist_id}","starred_url":"https://api.github.com/users/marcomorain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcomorain/subscriptions","organizations_url":"https://api.github.com/users/marcomorain/orgs","repos_url":"https://api.github.com/users/marcomorain/repos","events_url":"https://api.github.com/users/marcomorain/events{/privacy}","received_events_url":"https://api.github.com/users/marcomorain/received_events","type":"User","site_admin":false},"body":"aha, so I do have a bug but it `buffer_append_n `.","created_at":"2014-12-22T13:52:55Z","updated_at":"2014-12-22T13:52:55Z","html_url":"https://github.com/clibs/buffer/pull/8#discussion_r22166466","pull_request_url":"https://api.github.com/repos/clibs/buffer/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/clibs/buffer/pulls/comments/22166466"},"html":{"href":"https://github.com/clibs/buffer/pull/8#discussion_r22166466"},"pull_request":{"href":"https://api.github.com/repos/clibs/buffer/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/clibs/buffer/pulls/8","id":20708260,"html_url":"https://github.com/clibs/buffer/pull/8","diff_url":"https://github.com/clibs/buffer/pull/8.diff","patch_url":"https://github.com/clibs/buffer/pull/8.patch","issue_url":"https://api.github.com/repos/clibs/buffer/issues/8","number":8,"state":"open","locked":false,"title":"Add function to append n bytes","user":{"login":"marcomorain","id":448001,"avatar_url":"https://avatars.githubusercontent.com/u/448001?v=3","gravatar_id":"","url":"https://api.github.com/users/marcomorain","html_url":"https://github.com/marcomorain","followers_url":"https://api.github.com/users/marcomorain/followers","following_url":"https://api.github.com/users/marcomorain/following{/other_user}","gists_url":"https://api.github.com/users/marcomorain/gists{/gist_id}","starred_url":"https://api.github.com/users/marcomorain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcomorain/subscriptions","organizations_url":"https://api.github.com/users/marcomorain/orgs","repos_url":"https://api.github.com/users/marcomorain/repos","events_url":"https://api.github.com/users/marcomorain/events{/privacy}","received_events_url":"https://api.github.com/users/marcomorain/received_events","type":"User","site_admin":false},"body":"This adds a function to add the first N bytes from a string into a buffer.","created_at":"2014-09-03T21:42:08Z","updated_at":"2014-12-22T13:52:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"54490b6fb869184708233d651b9c56361b54c92b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/clibs/buffer/pulls/8/commits","review_comments_url":"https://api.github.com/repos/clibs/buffer/pulls/8/comments","review_comment_url":"https://api.github.com/repos/clibs/buffer/pulls/comments/{number}","comments_url":"https://api.github.com/repos/clibs/buffer/issues/8/comments","statuses_url":"https://api.github.com/repos/clibs/buffer/statuses/8ba3f52086900d20d13bc210aabb12efa29f1ec6","head":{"label":"marcomorain:append-n","ref":"append-n","sha":"8ba3f52086900d20d13bc210aabb12efa29f1ec6","user":{"login":"marcomorain","id":448001,"avatar_url":"https://avatars.githubusercontent.com/u/448001?v=3","gravatar_id":"","url":"https://api.github.com/users/marcomorain","html_url":"https://github.com/marcomorain","followers_url":"https://api.github.com/users/marcomorain/followers","following_url":"https://api.github.com/users/marcomorain/following{/other_user}","gists_url":"https://api.github.com/users/marcomorain/gists{/gist_id}","starred_url":"https://api.github.com/users/marcomorain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcomorain/subscriptions","organizations_url":"https://api.github.com/users/marcomorain/orgs","repos_url":"https://api.github.com/users/marcomorain/repos","events_url":"https://api.github.com/users/marcomorain/events{/privacy}","received_events_url":"https://api.github.com/users/marcomorain/received_events","type":"User","site_admin":false},"repo":{"id":23638248,"name":"buffer","full_name":"marcomorain/buffer","owner":{"login":"marcomorain","id":448001,"avatar_url":"https://avatars.githubusercontent.com/u/448001?v=3","gravatar_id":"","url":"https://api.github.com/users/marcomorain","html_url":"https://github.com/marcomorain","followers_url":"https://api.github.com/users/marcomorain/followers","following_url":"https://api.github.com/users/marcomorain/following{/other_user}","gists_url":"https://api.github.com/users/marcomorain/gists{/gist_id}","starred_url":"https://api.github.com/users/marcomorain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcomorain/subscriptions","organizations_url":"https://api.github.com/users/marcomorain/orgs","repos_url":"https://api.github.com/users/marcomorain/repos","events_url":"https://api.github.com/users/marcomorain/events{/privacy}","received_events_url":"https://api.github.com/users/marcomorain/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marcomorain/buffer","description":"Tiny C string library","fork":true,"url":"https://api.github.com/repos/marcomorain/buffer","forks_url":"https://api.github.com/repos/marcomorain/buffer/forks","keys_url":"https://api.github.com/repos/marcomorain/buffer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marcomorain/buffer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marcomorain/buffer/teams","hooks_url":"https://api.github.com/repos/marcomorain/buffer/hooks","issue_events_url":"https://api.github.com/repos/marcomorain/buffer/issues/events{/number}","events_url":"https://api.github.com/repos/marcomorain/buffer/events","assignees_url":"https://api.github.com/repos/marcomorain/buffer/assignees{/user}","branches_url":"https://api.github.com/repos/marcomorain/buffer/branches{/branch}","tags_url":"https://api.github.com/repos/marcomorain/buffer/tags","blobs_url":"https://api.github.com/repos/marcomorain/buffer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marcomorain/buffer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marcomorain/buffer/git/refs{/sha}","trees_url":"https://api.github.com/repos/marcomorain/buffer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marcomorain/buffer/statuses/{sha}","languages_url":"https://api.github.com/repos/marcomorain/buffer/languages","stargazers_url":"https://api.github.com/repos/marcomorain/buffer/stargazers","contributors_url":"https://api.github.com/repos/marcomorain/buffer/contributors","subscribers_url":"https://api.github.com/repos/marcomorain/buffer/subscribers","subscription_url":"https://api.github.com/repos/marcomorain/buffer/subscription","commits_url":"https://api.github.com/repos/marcomorain/buffer/commits{/sha}","git_commits_url":"https://api.github.com/repos/marcomorain/buffer/git/commits{/sha}","comments_url":"https://api.github.com/repos/marcomorain/buffer/comments{/number}","issue_comment_url":"https://api.github.com/repos/marcomorain/buffer/issues/comments/{number}","contents_url":"https://api.github.com/repos/marcomorain/buffer/contents/{+path}","compare_url":"https://api.github.com/repos/marcomorain/buffer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marcomorain/buffer/merges","archive_url":"https://api.github.com/repos/marcomorain/buffer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marcomorain/buffer/downloads","issues_url":"https://api.github.com/repos/marcomorain/buffer/issues{/number}","pulls_url":"https://api.github.com/repos/marcomorain/buffer/pulls{/number}","milestones_url":"https://api.github.com/repos/marcomorain/buffer/milestones{/number}","notifications_url":"https://api.github.com/repos/marcomorain/buffer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marcomorain/buffer/labels{/name}","releases_url":"https://api.github.com/repos/marcomorain/buffer/releases{/id}","created_at":"2014-09-03T21:27:26Z","updated_at":"2014-08-16T08:54:22Z","pushed_at":"2014-09-03T21:59:35Z","git_url":"git://github.com/marcomorain/buffer.git","ssh_url":"git@github.com:marcomorain/buffer.git","clone_url":"https://github.com/marcomorain/buffer.git","svn_url":"https://github.com/marcomorain/buffer","homepage":"","size":108,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"clibs:master","ref":"master","sha":"722611d26f55fb44f9ffc57648596f7e36852dac","user":{"login":"clibs","id":5657447,"avatar_url":"https://avatars.githubusercontent.com/u/5657447?v=3","gravatar_id":"","url":"https://api.github.com/users/clibs","html_url":"https://github.com/clibs","followers_url":"https://api.github.com/users/clibs/followers","following_url":"https://api.github.com/users/clibs/following{/other_user}","gists_url":"https://api.github.com/users/clibs/gists{/gist_id}","starred_url":"https://api.github.com/users/clibs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clibs/subscriptions","organizations_url":"https://api.github.com/users/clibs/orgs","repos_url":"https://api.github.com/users/clibs/repos","events_url":"https://api.github.com/users/clibs/events{/privacy}","received_events_url":"https://api.github.com/users/clibs/received_events","type":"Organization","site_admin":false},"repo":{"id":7196580,"name":"buffer","full_name":"clibs/buffer","owner":{"login":"clibs","id":5657447,"avatar_url":"https://avatars.githubusercontent.com/u/5657447?v=3","gravatar_id":"","url":"https://api.github.com/users/clibs","html_url":"https://github.com/clibs","followers_url":"https://api.github.com/users/clibs/followers","following_url":"https://api.github.com/users/clibs/following{/other_user}","gists_url":"https://api.github.com/users/clibs/gists{/gist_id}","starred_url":"https://api.github.com/users/clibs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clibs/subscriptions","organizations_url":"https://api.github.com/users/clibs/orgs","repos_url":"https://api.github.com/users/clibs/repos","events_url":"https://api.github.com/users/clibs/events{/privacy}","received_events_url":"https://api.github.com/users/clibs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/clibs/buffer","description":"Tiny C string library","fork":false,"url":"https://api.github.com/repos/clibs/buffer","forks_url":"https://api.github.com/repos/clibs/buffer/forks","keys_url":"https://api.github.com/repos/clibs/buffer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clibs/buffer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clibs/buffer/teams","hooks_url":"https://api.github.com/repos/clibs/buffer/hooks","issue_events_url":"https://api.github.com/repos/clibs/buffer/issues/events{/number}","events_url":"https://api.github.com/repos/clibs/buffer/events","assignees_url":"https://api.github.com/repos/clibs/buffer/assignees{/user}","branches_url":"https://api.github.com/repos/clibs/buffer/branches{/branch}","tags_url":"https://api.github.com/repos/clibs/buffer/tags","blobs_url":"https://api.github.com/repos/clibs/buffer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clibs/buffer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clibs/buffer/git/refs{/sha}","trees_url":"https://api.github.com/repos/clibs/buffer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clibs/buffer/statuses/{sha}","languages_url":"https://api.github.com/repos/clibs/buffer/languages","stargazers_url":"https://api.github.com/repos/clibs/buffer/stargazers","contributors_url":"https://api.github.com/repos/clibs/buffer/contributors","subscribers_url":"https://api.github.com/repos/clibs/buffer/subscribers","subscription_url":"https://api.github.com/repos/clibs/buffer/subscription","commits_url":"https://api.github.com/repos/clibs/buffer/commits{/sha}","git_commits_url":"https://api.github.com/repos/clibs/buffer/git/commits{/sha}","comments_url":"https://api.github.com/repos/clibs/buffer/comments{/number}","issue_comment_url":"https://api.github.com/repos/clibs/buffer/issues/comments/{number}","contents_url":"https://api.github.com/repos/clibs/buffer/contents/{+path}","compare_url":"https://api.github.com/repos/clibs/buffer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clibs/buffer/merges","archive_url":"https://api.github.com/repos/clibs/buffer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clibs/buffer/downloads","issues_url":"https://api.github.com/repos/clibs/buffer/issues{/number}","pulls_url":"https://api.github.com/repos/clibs/buffer/pulls{/number}","milestones_url":"https://api.github.com/repos/clibs/buffer/milestones{/number}","notifications_url":"https://api.github.com/repos/clibs/buffer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clibs/buffer/labels{/name}","releases_url":"https://api.github.com/repos/clibs/buffer/releases{/id}","created_at":"2012-12-16T23:08:42Z","updated_at":"2014-09-22T01:18:47Z","pushed_at":"2013-11-24T18:20:04Z","git_url":"git://github.com/clibs/buffer.git","ssh_url":"git@github.com:clibs/buffer.git","clone_url":"https://github.com/clibs/buffer.git","svn_url":"https://github.com/clibs/buffer","homepage":"","size":134,"stargazers_count":42,"watchers_count":42,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":3,"forks":10,"open_issues":3,"watchers":42,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/clibs/buffer/pulls/8"},"html":{"href":"https://github.com/clibs/buffer/pull/8"},"issue":{"href":"https://api.github.com/repos/clibs/buffer/issues/8"},"comments":{"href":"https://api.github.com/repos/clibs/buffer/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/clibs/buffer/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/clibs/buffer/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/clibs/buffer/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/clibs/buffer/statuses/8ba3f52086900d20d13bc210aabb12efa29f1ec6"}}}}