GitHub PullRequestReviewCommentEvent at 2014-12-29 16:54:50
Repository: openproject
Actor: houndci
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/opf/openproject/pulls/comments/22318559","id":22318559,"diff_hunk":"@@ -0,0 +1,166 @@\n+//-- copyright\n+// OpenProject is a project management system.\n+// Copyright (C) 2012-2014 the OpenProject Foundation (OPF)\n+//\n+// This program is free software; you can redistribute it and/or\n+// modify it under the terms of the GNU General Public License version 3.\n+//\n+// OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:\n+// Copyright (C) 2006-2013 Jean-Philippe Lang\n+// Copyright (C) 2010-2013 the ChiliProject Team\n+//\n+// This program is free software; you can redistribute it and/or\n+// modify it under the terms of the GNU General Public License\n+// as published by the Free Software Foundation; either version 2\n+// of the License, or (at your option) any later version.\n+//\n+// This program is distributed in the hope that it will be useful,\n+// but WITHOUT ANY WARRANTY; without even the implied warranty of\n+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the\n+// GNU General Public License for more details.\n+//\n+// You should have received a copy of the GNU General Public License\n+// along with this program; if not, write to the Free Software\n+// Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.\n+//\n+// See doc/COPYRIGHT.rdoc for more details.\n+//++\n+\n+module.exports = function($scope, I18n, columnsModal, exportModal, saveModal, settingsModal, shareModal, sortingModal, groupingModal, QueryService, AuthorisationService, $window, $state, $timeout){\n+  // angular.element($window).bind('click', function() {\n+  // $scope.$emit('hideAllDropdowns');\n+  // });\n+\n+  $scope.$watch('query.displaySums', function(newValue, oldValue) {\n+    $timeout(function() {\n+      $scope.displaySumsLabel = (newValue) ? I18n.t('js.toolbar.settings.hide_sums')\n+                                          : I18n.t('js.toolbar.settings.display_sums');\n+    });\n+  });\n+\n+  $scope.saveQuery = function(event){\n+    if (!$scope.query.dirty) {\n+      return;\n+    }\n+    if($scope.query.isNew()){\n+      if( allowQueryAction(event, 'create') ){\n+        // $scope.$emit('hideAllDropdowns');\n+        saveModal.activate();\n+      }\n+    } else {\n+      if( allowQueryAction(event, 'update') ) {\n+        QueryService.saveQuery()\n+          .then(function(data){\n+            $scope.$emit('flashMessage', data.status);\n+            $state.go('work-packages.list',\n+                      { query_id: $scope.query.id, query_props: null },","path":"frontend/app/work_packages/controllers/menus/options-dropdown-menu-controller.js","position":56,"original_position":56,"commit_id":"ecd4a827aabfc732c3926d4b600c7325cfca7ba2","original_commit_id":"ecd4a827aabfc732c3926d4b600c7325cfca7ba2","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Identifier 'query_id' is not in camel case.<br>Identifier 'query_props' is not in camel case.","created_at":"2014-12-29T16:54:50Z","updated_at":"2014-12-29T16:54:50Z","html_url":"https://github.com/opf/openproject/pull/2391#discussion_r22318559","pull_request_url":"https://api.github.com/repos/opf/openproject/pulls/2391","_links":{"self":{"href":"https://api.github.com/repos/opf/openproject/pulls/comments/22318559"},"html":{"href":"https://github.com/opf/openproject/pull/2391#discussion_r22318559"},"pull_request":{"href":"https://api.github.com/repos/opf/openproject/pulls/2391"}}},"pull_request":{"url":"https://api.github.com/repos/opf/openproject/pulls/2391","id":26651802,"html_url":"https://github.com/opf/openproject/pull/2391","diff_url":"https://github.com/opf/openproject/pull/2391.diff","patch_url":"https://github.com/opf/openproject/pull/2391.patch","issue_url":"https://api.github.com/repos/opf/openproject/issues/2391","number":2391,"state":"open","locked":false,"title":"begin menu harmonization","user":{"login":"0xF013","id":1038822,"avatar_url":"https://avatars.githubusercontent.com/u/1038822?v=3","gravatar_id":"","url":"https://api.github.com/users/0xF013","html_url":"https://github.com/0xF013","followers_url":"https://api.github.com/users/0xF013/followers","following_url":"https://api.github.com/users/0xF013/following{/other_user}","gists_url":"https://api.github.com/users/0xF013/gists{/gist_id}","starred_url":"https://api.github.com/users/0xF013/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xF013/subscriptions","organizations_url":"https://api.github.com/users/0xF013/orgs","repos_url":"https://api.github.com/users/0xF013/repos","events_url":"https://api.github.com/users/0xF013/events{/privacy}","received_events_url":"https://api.github.com/users/0xF013/received_events","type":"User","site_admin":false},"body":"[``* `#15711 `harmonize-action-and-dropdown-menus``](http://community.openproject.org/work_packages/15711)","created_at":"2014-12-29T16:54:42Z","updated_at":"2014-12-29T16:54:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0ed7d341398e6d64bf16fe72897e67765d9eba47","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/opf/openproject/pulls/2391/commits","review_comments_url":"https://api.github.com/repos/opf/openproject/pulls/2391/comments","review_comment_url":"https://api.github.com/repos/opf/openproject/pulls/comments/{number}","comments_url":"https://api.github.com/repos/opf/openproject/issues/2391/comments","statuses_url":"https://api.github.com/repos/opf/openproject/statuses/ecd4a827aabfc732c3926d4b600c7325cfca7ba2","head":{"label":"0xF013:feature/15711-harmonize-action-and-dropdown-menus","ref":"feature/15711-harmonize-action-and-dropdown-menus","sha":"ecd4a827aabfc732c3926d4b600c7325cfca7ba2","user":{"login":"0xF013","id":1038822,"avatar_url":"https://avatars.githubusercontent.com/u/1038822?v=3","gravatar_id":"","url":"https://api.github.com/users/0xF013","html_url":"https://github.com/0xF013","followers_url":"https://api.github.com/users/0xF013/followers","following_url":"https://api.github.com/users/0xF013/following{/other_user}","gists_url":"https://api.github.com/users/0xF013/gists{/gist_id}","starred_url":"https://api.github.com/users/0xF013/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xF013/subscriptions","organizations_url":"https://api.github.com/users/0xF013/orgs","repos_url":"https://api.github.com/users/0xF013/repos","events_url":"https://api.github.com/users/0xF013/events{/privacy}","received_events_url":"https://api.github.com/users/0xF013/received_events","type":"User","site_admin":false},"repo":{"id":23571676,"name":"openproject","full_name":"0xF013/openproject","owner":{"login":"0xF013","id":1038822,"avatar_url":"https://avatars.githubusercontent.com/u/1038822?v=3","gravatar_id":"","url":"https://api.github.com/users/0xF013","html_url":"https://github.com/0xF013","followers_url":"https://api.github.com/users/0xF013/followers","following_url":"https://api.github.com/users/0xF013/following{/other_user}","gists_url":"https://api.github.com/users/0xF013/gists{/gist_id}","starred_url":"https://api.github.com/users/0xF013/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xF013/subscriptions","organizations_url":"https://api.github.com/users/0xF013/orgs","repos_url":"https://api.github.com/users/0xF013/repos","events_url":"https://api.github.com/users/0xF013/events{/privacy}","received_events_url":"https://api.github.com/users/0xF013/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/0xF013/openproject","description":"OpenProject is a web based project management system built on Ruby on Rails","fork":true,"url":"https://api.github.com/repos/0xF013/openproject","forks_url":"https://api.github.com/repos/0xF013/openproject/forks","keys_url":"https://api.github.com/repos/0xF013/openproject/keys{/key_id}","collaborators_url":"https://api.github.com/repos/0xF013/openproject/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/0xF013/openproject/teams","hooks_url":"https://api.github.com/repos/0xF013/openproject/hooks","issue_events_url":"https://api.github.com/repos/0xF013/openproject/issues/events{/number}","events_url":"https://api.github.com/repos/0xF013/openproject/events","assignees_url":"https://api.github.com/repos/0xF013/openproject/assignees{/user}","branches_url":"https://api.github.com/repos/0xF013/openproject/branches{/branch}","tags_url":"https://api.github.com/repos/0xF013/openproject/tags","blobs_url":"https://api.github.com/repos/0xF013/openproject/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/0xF013/openproject/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/0xF013/openproject/git/refs{/sha}","trees_url":"https://api.github.com/repos/0xF013/openproject/git/trees{/sha}","statuses_url":"https://api.github.com/repos/0xF013/openproject/statuses/{sha}","languages_url":"https://api.github.com/repos/0xF013/openproject/languages","stargazers_url":"https://api.github.com/repos/0xF013/openproject/stargazers","contributors_url":"https://api.github.com/repos/0xF013/openproject/contributors","subscribers_url":"https://api.github.com/repos/0xF013/openproject/subscribers","subscription_url":"https://api.github.com/repos/0xF013/openproject/subscription","commits_url":"https://api.github.com/repos/0xF013/openproject/commits{/sha}","git_commits_url":"https://api.github.com/repos/0xF013/openproject/git/commits{/sha}","comments_url":"https://api.github.com/repos/0xF013/openproject/comments{/number}","issue_comment_url":"https://api.github.com/repos/0xF013/openproject/issues/comments/{number}","contents_url":"https://api.github.com/repos/0xF013/openproject/contents/{+path}","compare_url":"https://api.github.com/repos/0xF013/openproject/compare/{base}...{head}","merges_url":"https://api.github.com/repos/0xF013/openproject/merges","archive_url":"https://api.github.com/repos/0xF013/openproject/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/0xF013/openproject/downloads","issues_url":"https://api.github.com/repos/0xF013/openproject/issues{/number}","pulls_url":"https://api.github.com/repos/0xF013/openproject/pulls{/number}","milestones_url":"https://api.github.com/repos/0xF013/openproject/milestones{/number}","notifications_url":"https://api.github.com/repos/0xF013/openproject/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/0xF013/openproject/labels{/name}","releases_url":"https://api.github.com/repos/0xF013/openproject/releases{/id}","created_at":"2014-09-02T08:53:59Z","updated_at":"2014-12-04T19:50:30Z","pushed_at":"2014-12-29T16:53:44Z","git_url":"git://github.com/0xF013/openproject.git","ssh_url":"git@github.com:0xF013/openproject.git","clone_url":"https://github.com/0xF013/openproject.git","svn_url":"https://github.com/0xF013/openproject","homepage":"https://www.openproject.org","size":60425,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"feature/15173-subprojects-are-not-copied-correctly"}},"base":{"label":"opf:dev","ref":"dev","sha":"6d88d71c812145c322badb239ed118104d1c6c2e","user":{"login":"opf","id":1756674,"avatar_url":"https://avatars.githubusercontent.com/u/1756674?v=3","gravatar_id":"","url":"https://api.github.com/users/opf","html_url":"https://github.com/opf","followers_url":"https://api.github.com/users/opf/followers","following_url":"https://api.github.com/users/opf/following{/other_user}","gists_url":"https://api.github.com/users/opf/gists{/gist_id}","starred_url":"https://api.github.com/users/opf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opf/subscriptions","organizations_url":"https://api.github.com/users/opf/orgs","repos_url":"https://api.github.com/users/opf/repos","events_url":"https://api.github.com/users/opf/events{/privacy}","received_events_url":"https://api.github.com/users/opf/received_events","type":"Organization","site_admin":false},"repo":{"id":6899875,"name":"openproject","full_name":"opf/openproject","owner":{"login":"opf","id":1756674,"avatar_url":"https://avatars.githubusercontent.com/u/1756674?v=3","gravatar_id":"","url":"https://api.github.com/users/opf","html_url":"https://github.com/opf","followers_url":"https://api.github.com/users/opf/followers","following_url":"https://api.github.com/users/opf/following{/other_user}","gists_url":"https://api.github.com/users/opf/gists{/gist_id}","starred_url":"https://api.github.com/users/opf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opf/subscriptions","organizations_url":"https://api.github.com/users/opf/orgs","repos_url":"https://api.github.com/users/opf/repos","events_url":"https://api.github.com/users/opf/events{/privacy}","received_events_url":"https://api.github.com/users/opf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opf/openproject","description":"OpenProject is a web based project management system built on Ruby on Rails","fork":false,"url":"https://api.github.com/repos/opf/openproject","forks_url":"https://api.github.com/repos/opf/openproject/forks","keys_url":"https://api.github.com/repos/opf/openproject/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opf/openproject/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opf/openproject/teams","hooks_url":"https://api.github.com/repos/opf/openproject/hooks","issue_events_url":"https://api.github.com/repos/opf/openproject/issues/events{/number}","events_url":"https://api.github.com/repos/opf/openproject/events","assignees_url":"https://api.github.com/repos/opf/openproject/assignees{/user}","branches_url":"https://api.github.com/repos/opf/openproject/branches{/branch}","tags_url":"https://api.github.com/repos/opf/openproject/tags","blobs_url":"https://api.github.com/repos/opf/openproject/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opf/openproject/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opf/openproject/git/refs{/sha}","trees_url":"https://api.github.com/repos/opf/openproject/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opf/openproject/statuses/{sha}","languages_url":"https://api.github.com/repos/opf/openproject/languages","stargazers_url":"https://api.github.com/repos/opf/openproject/stargazers","contributors_url":"https://api.github.com/repos/opf/openproject/contributors","subscribers_url":"https://api.github.com/repos/opf/openproject/subscribers","subscription_url":"https://api.github.com/repos/opf/openproject/subscription","commits_url":"https://api.github.com/repos/opf/openproject/commits{/sha}","git_commits_url":"https://api.github.com/repos/opf/openproject/git/commits{/sha}","comments_url":"https://api.github.com/repos/opf/openproject/comments{/number}","issue_comment_url":"https://api.github.com/repos/opf/openproject/issues/comments/{number}","contents_url":"https://api.github.com/repos/opf/openproject/contents/{+path}","compare_url":"https://api.github.com/repos/opf/openproject/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opf/openproject/merges","archive_url":"https://api.github.com/repos/opf/openproject/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opf/openproject/downloads","issues_url":"https://api.github.com/repos/opf/openproject/issues{/number}","pulls_url":"https://api.github.com/repos/opf/openproject/pulls{/number}","milestones_url":"https://api.github.com/repos/opf/openproject/milestones{/number}","notifications_url":"https://api.github.com/repos/opf/openproject/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opf/openproject/labels{/name}","releases_url":"https://api.github.com/repos/opf/openproject/releases{/id}","created_at":"2012-11-28T09:59:11Z","updated_at":"2014-12-29T13:16:13Z","pushed_at":"2014-12-26T11:36:38Z","git_url":"git://github.com/opf/openproject.git","ssh_url":"git@github.com:opf/openproject.git","clone_url":"https://github.com/opf/openproject.git","svn_url":"https://github.com/opf/openproject","homepage":"https://www.openproject.org","size":156879,"stargazers_count":450,"watchers_count":450,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":210,"mirror_url":null,"open_issues_count":53,"forks":210,"open_issues":53,"watchers":450,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/opf/openproject/pulls/2391"},"html":{"href":"https://github.com/opf/openproject/pull/2391"},"issue":{"href":"https://api.github.com/repos/opf/openproject/issues/2391"},"comments":{"href":"https://api.github.com/repos/opf/openproject/issues/2391/comments"},"review_comments":{"href":"https://api.github.com/repos/opf/openproject/pulls/2391/comments"},"review_comment":{"href":"https://api.github.com/repos/opf/openproject/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/opf/openproject/pulls/2391/commits"},"statuses":{"href":"https://api.github.com/repos/opf/openproject/statuses/ecd4a827aabfc732c3926d4b600c7325cfca7ba2"}}}}