GitHub PullRequestReviewCommentEvent at 2014-07-27 17:47:05
Repository: gonzales-pe
Actor: tonyganch
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/tonyganch/gonzales-pe/pulls/comments/15440504","id":15440504,"diff_hunk":"@@ -88,17 +108,18 @@ module.exports = function(css) {\n      * @param {string} q Quote (either `'` or `\"`)\n      */\n     function parseString(css, q) {\n-        var start = pos;\n+        var start = pos,\n+            startCol = col;\n \n         // Read the string until we meet a matching quote:\n-        for (pos = pos + 1; pos < css.length; pos++) {\n+        for (shiftRight(); pos < css.length; shiftRight()) {\n             // Skip escaped quotes:\n-            if (css.charAt(pos) === '\\\\') pos++;\n+            if (css.charAt(pos) === '\\\\') shiftRight();\n             else if (css.charAt(pos) === q) break;\n         }\n \n         // Add the string (including quotes) to tokens:\n-        pushToken(q === '\"' ? TokenType.StringDQ : TokenType.StringSQ, css.substring(start, pos + 1));\n+        pushToken(q === '\"' ? TokenType.StringDQ : TokenType.StringSQ, css.substring(start, pos + 1), startCol);","path":"lib/css/tokenizer.js","position":84,"original_position":84,"commit_id":"51779e698690ba7b8a44056cd76fb6f412e4cefa","original_commit_id":"51779e698690ba7b8a44056cd76fb6f412e4cefa","user":{"login":"tonyganch","id":872004,"avatar_url":"https://avatars.githubusercontent.com/u/872004?","gravatar_id":"aacec354a4e8181d30e21cc4e3d6f76e","url":"https://api.github.com/users/tonyganch","html_url":"https://github.com/tonyganch","followers_url":"https://api.github.com/users/tonyganch/followers","following_url":"https://api.github.com/users/tonyganch/following{/other_user}","gists_url":"https://api.github.com/users/tonyganch/gists{/gist_id}","starred_url":"https://api.github.com/users/tonyganch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonyganch/subscriptions","organizations_url":"https://api.github.com/users/tonyganch/orgs","repos_url":"https://api.github.com/users/tonyganch/repos","events_url":"https://api.github.com/users/tonyganch/events{/privacy}","received_events_url":"https://api.github.com/users/tonyganch/received_events","type":"User","site_admin":false},"body":"Yes, I see it now, you are right","created_at":"2014-07-27T17:47:05Z","updated_at":"2014-07-27T17:47:05Z","html_url":"https://github.com/tonyganch/gonzales-pe/pull/23#discussion_r15440504","pull_request_url":"https://api.github.com/repos/tonyganch/gonzales-pe/pulls/23","_links":{"self":{"href":"https://api.github.com/repos/tonyganch/gonzales-pe/pulls/comments/15440504"},"html":{"href":"https://github.com/tonyganch/gonzales-pe/pull/23#discussion_r15440504"},"pull_request":{"href":"https://api.github.com/repos/tonyganch/gonzales-pe/pulls/23"}}},"pull_request":{"url":"https://api.github.com/repos/tonyganch/gonzales-pe/pulls/23","id":18942333,"html_url":"https://github.com/tonyganch/gonzales-pe/pull/23","diff_url":"https://github.com/tonyganch/gonzales-pe/pull/23.diff","patch_url":"https://github.com/tonyganch/gonzales-pe/pull/23.patch","issue_url":"https://api.github.com/repos/tonyganch/gonzales-pe/issues/23","number":23,"state":"open","title":"Add column numbers to tokens","user":{"login":"vecmezoni","id":189443,"avatar_url":"https://avatars.githubusercontent.com/u/189443?","gravatar_id":"e944e586e9f691a213df9a177553ba61","url":"https://api.github.com/users/vecmezoni","html_url":"https://github.com/vecmezoni","followers_url":"https://api.github.com/users/vecmezoni/followers","following_url":"https://api.github.com/users/vecmezoni/following{/other_user}","gists_url":"https://api.github.com/users/vecmezoni/gists{/gist_id}","starred_url":"https://api.github.com/users/vecmezoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vecmezoni/subscriptions","organizations_url":"https://api.github.com/users/vecmezoni/orgs","repos_url":"https://api.github.com/users/vecmezoni/repos","events_url":"https://api.github.com/users/vecmezoni/events{/privacy}","received_events_url":"https://api.github.com/users/vecmezoni/received_events","type":"User","site_admin":false},"body":"Added column numbers to tokens and fixed line number counting for multiline comments in some syntaxes. Partially fixes https://github.com/tonyganch/gonzales-pe/issues/19, need to pass column numbers from rules to ```srcToAST```. Also need to cover this with unit-tests.\r\nNeed your comments, @tonyganch.","created_at":"2014-07-27T16:52:16Z","updated_at":"2014-07-27T17:47:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"efd559a12f3f4923e1916a3334d51ce551dbdd4d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tonyganch/gonzales-pe/pulls/23/commits","review_comments_url":"https://api.github.com/repos/tonyganch/gonzales-pe/pulls/23/comments","review_comment_url":"https://api.github.com/repos/tonyganch/gonzales-pe/pulls/comments/{number}","comments_url":"https://api.github.com/repos/tonyganch/gonzales-pe/issues/23/comments","statuses_url":"https://api.github.com/repos/tonyganch/gonzales-pe/statuses/51779e698690ba7b8a44056cd76fb6f412e4cefa","head":{"label":"vecmezoni:columns","ref":"columns","sha":"51779e698690ba7b8a44056cd76fb6f412e4cefa","user":{"login":"vecmezoni","id":189443,"avatar_url":"https://avatars.githubusercontent.com/u/189443?","gravatar_id":"e944e586e9f691a213df9a177553ba61","url":"https://api.github.com/users/vecmezoni","html_url":"https://github.com/vecmezoni","followers_url":"https://api.github.com/users/vecmezoni/followers","following_url":"https://api.github.com/users/vecmezoni/following{/other_user}","gists_url":"https://api.github.com/users/vecmezoni/gists{/gist_id}","starred_url":"https://api.github.com/users/vecmezoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vecmezoni/subscriptions","organizations_url":"https://api.github.com/users/vecmezoni/orgs","repos_url":"https://api.github.com/users/vecmezoni/repos","events_url":"https://api.github.com/users/vecmezoni/events{/privacy}","received_events_url":"https://api.github.com/users/vecmezoni/received_events","type":"User","site_admin":false},"repo":{"id":22316081,"name":"gonzales-pe","full_name":"vecmezoni/gonzales-pe","owner":{"login":"vecmezoni","id":189443,"avatar_url":"https://avatars.githubusercontent.com/u/189443?","gravatar_id":"e944e586e9f691a213df9a177553ba61","url":"https://api.github.com/users/vecmezoni","html_url":"https://github.com/vecmezoni","followers_url":"https://api.github.com/users/vecmezoni/followers","following_url":"https://api.github.com/users/vecmezoni/following{/other_user}","gists_url":"https://api.github.com/users/vecmezoni/gists{/gist_id}","starred_url":"https://api.github.com/users/vecmezoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vecmezoni/subscriptions","organizations_url":"https://api.github.com/users/vecmezoni/orgs","repos_url":"https://api.github.com/users/vecmezoni/repos","events_url":"https://api.github.com/users/vecmezoni/events{/privacy}","received_events_url":"https://api.github.com/users/vecmezoni/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vecmezoni/gonzales-pe","description":"Gonzales Preprocessor Edition (fast CSS parser)","fork":true,"url":"https://api.github.com/repos/vecmezoni/gonzales-pe","forks_url":"https://api.github.com/repos/vecmezoni/gonzales-pe/forks","keys_url":"https://api.github.com/repos/vecmezoni/gonzales-pe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vecmezoni/gonzales-pe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vecmezoni/gonzales-pe/teams","hooks_url":"https://api.github.com/repos/vecmezoni/gonzales-pe/hooks","issue_events_url":"https://api.github.com/repos/vecmezoni/gonzales-pe/issues/events{/number}","events_url":"https://api.github.com/repos/vecmezoni/gonzales-pe/events","assignees_url":"https://api.github.com/repos/vecmezoni/gonzales-pe/assignees{/user}","branches_url":"https://api.github.com/repos/vecmezoni/gonzales-pe/branches{/branch}","tags_url":"https://api.github.com/repos/vecmezoni/gonzales-pe/tags","blobs_url":"https://api.github.com/repos/vecmezoni/gonzales-pe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vecmezoni/gonzales-pe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vecmezoni/gonzales-pe/git/refs{/sha}","trees_url":"https://api.github.com/repos/vecmezoni/gonzales-pe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vecmezoni/gonzales-pe/statuses/{sha}","languages_url":"https://api.github.com/repos/vecmezoni/gonzales-pe/languages","stargazers_url":"https://api.github.com/repos/vecmezoni/gonzales-pe/stargazers","contributors_url":"https://api.github.com/repos/vecmezoni/gonzales-pe/contributors","subscribers_url":"https://api.github.com/repos/vecmezoni/gonzales-pe/subscribers","subscription_url":"https://api.github.com/repos/vecmezoni/gonzales-pe/subscription","commits_url":"https://api.github.com/repos/vecmezoni/gonzales-pe/commits{/sha}","git_commits_url":"https://api.github.com/repos/vecmezoni/gonzales-pe/git/commits{/sha}","comments_url":"https://api.github.com/repos/vecmezoni/gonzales-pe/comments{/number}","issue_comment_url":"https://api.github.com/repos/vecmezoni/gonzales-pe/issues/comments/{number}","contents_url":"https://api.github.com/repos/vecmezoni/gonzales-pe/contents/{+path}","compare_url":"https://api.github.com/repos/vecmezoni/gonzales-pe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vecmezoni/gonzales-pe/merges","archive_url":"https://api.github.com/repos/vecmezoni/gonzales-pe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vecmezoni/gonzales-pe/downloads","issues_url":"https://api.github.com/repos/vecmezoni/gonzales-pe/issues{/number}","pulls_url":"https://api.github.com/repos/vecmezoni/gonzales-pe/pulls{/number}","milestones_url":"https://api.github.com/repos/vecmezoni/gonzales-pe/milestones{/number}","notifications_url":"https://api.github.com/repos/vecmezoni/gonzales-pe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vecmezoni/gonzales-pe/labels{/name}","releases_url":"https://api.github.com/repos/vecmezoni/gonzales-pe/releases{/id}","created_at":"2014-07-27T16:47:25Z","updated_at":"2014-07-22T12:00:55Z","pushed_at":"2014-07-27T16:47:50Z","git_url":"git://github.com/vecmezoni/gonzales-pe.git","ssh_url":"git@github.com:vecmezoni/gonzales-pe.git","clone_url":"https://github.com/vecmezoni/gonzales-pe.git","svn_url":"https://github.com/vecmezoni/gonzales-pe","homepage":"","size":1074,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tonyganch:dev","ref":"dev","sha":"8d860d993f2a645644c0e5bc0d59951cdb64990b","user":{"login":"tonyganch","id":872004,"avatar_url":"https://avatars.githubusercontent.com/u/872004?","gravatar_id":"aacec354a4e8181d30e21cc4e3d6f76e","url":"https://api.github.com/users/tonyganch","html_url":"https://github.com/tonyganch","followers_url":"https://api.github.com/users/tonyganch/followers","following_url":"https://api.github.com/users/tonyganch/following{/other_user}","gists_url":"https://api.github.com/users/tonyganch/gists{/gist_id}","starred_url":"https://api.github.com/users/tonyganch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonyganch/subscriptions","organizations_url":"https://api.github.com/users/tonyganch/orgs","repos_url":"https://api.github.com/users/tonyganch/repos","events_url":"https://api.github.com/users/tonyganch/events{/privacy}","received_events_url":"https://api.github.com/users/tonyganch/received_events","type":"User","site_admin":false},"repo":{"id":13370349,"name":"gonzales-pe","full_name":"tonyganch/gonzales-pe","owner":{"login":"tonyganch","id":872004,"avatar_url":"https://avatars.githubusercontent.com/u/872004?","gravatar_id":"aacec354a4e8181d30e21cc4e3d6f76e","url":"https://api.github.com/users/tonyganch","html_url":"https://github.com/tonyganch","followers_url":"https://api.github.com/users/tonyganch/followers","following_url":"https://api.github.com/users/tonyganch/following{/other_user}","gists_url":"https://api.github.com/users/tonyganch/gists{/gist_id}","starred_url":"https://api.github.com/users/tonyganch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonyganch/subscriptions","organizations_url":"https://api.github.com/users/tonyganch/orgs","repos_url":"https://api.github.com/users/tonyganch/repos","events_url":"https://api.github.com/users/tonyganch/events{/privacy}","received_events_url":"https://api.github.com/users/tonyganch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tonyganch/gonzales-pe","description":"Gonzales Preprocessor Edition (fast CSS parser)","fork":false,"url":"https://api.github.com/repos/tonyganch/gonzales-pe","forks_url":"https://api.github.com/repos/tonyganch/gonzales-pe/forks","keys_url":"https://api.github.com/repos/tonyganch/gonzales-pe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tonyganch/gonzales-pe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tonyganch/gonzales-pe/teams","hooks_url":"https://api.github.com/repos/tonyganch/gonzales-pe/hooks","issue_events_url":"https://api.github.com/repos/tonyganch/gonzales-pe/issues/events{/number}","events_url":"https://api.github.com/repos/tonyganch/gonzales-pe/events","assignees_url":"https://api.github.com/repos/tonyganch/gonzales-pe/assignees{/user}","branches_url":"https://api.github.com/repos/tonyganch/gonzales-pe/branches{/branch}","tags_url":"https://api.github.com/repos/tonyganch/gonzales-pe/tags","blobs_url":"https://api.github.com/repos/tonyganch/gonzales-pe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tonyganch/gonzales-pe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tonyganch/gonzales-pe/git/refs{/sha}","trees_url":"https://api.github.com/repos/tonyganch/gonzales-pe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tonyganch/gonzales-pe/statuses/{sha}","languages_url":"https://api.github.com/repos/tonyganch/gonzales-pe/languages","stargazers_url":"https://api.github.com/repos/tonyganch/gonzales-pe/stargazers","contributors_url":"https://api.github.com/repos/tonyganch/gonzales-pe/contributors","subscribers_url":"https://api.github.com/repos/tonyganch/gonzales-pe/subscribers","subscription_url":"https://api.github.com/repos/tonyganch/gonzales-pe/subscription","commits_url":"https://api.github.com/repos/tonyganch/gonzales-pe/commits{/sha}","git_commits_url":"https://api.github.com/repos/tonyganch/gonzales-pe/git/commits{/sha}","comments_url":"https://api.github.com/repos/tonyganch/gonzales-pe/comments{/number}","issue_comment_url":"https://api.github.com/repos/tonyganch/gonzales-pe/issues/comments/{number}","contents_url":"https://api.github.com/repos/tonyganch/gonzales-pe/contents/{+path}","compare_url":"https://api.github.com/repos/tonyganch/gonzales-pe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tonyganch/gonzales-pe/merges","archive_url":"https://api.github.com/repos/tonyganch/gonzales-pe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tonyganch/gonzales-pe/downloads","issues_url":"https://api.github.com/repos/tonyganch/gonzales-pe/issues{/number}","pulls_url":"https://api.github.com/repos/tonyganch/gonzales-pe/pulls{/number}","milestones_url":"https://api.github.com/repos/tonyganch/gonzales-pe/milestones{/number}","notifications_url":"https://api.github.com/repos/tonyganch/gonzales-pe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tonyganch/gonzales-pe/labels{/name}","releases_url":"https://api.github.com/repos/tonyganch/gonzales-pe/releases{/id}","created_at":"2013-10-06T22:06:58Z","updated_at":"2014-07-22T12:00:55Z","pushed_at":"2014-07-18T16:22:28Z","git_url":"git://github.com/tonyganch/gonzales-pe.git","ssh_url":"git@github.com:tonyganch/gonzales-pe.git","clone_url":"https://github.com/tonyganch/gonzales-pe.git","svn_url":"https://github.com/tonyganch/gonzales-pe","homepage":"","size":1074,"stargazers_count":30,"watchers_count":30,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":4,"mirror_url":null,"open_issues_count":11,"forks":4,"open_issues":11,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tonyganch/gonzales-pe/pulls/23"},"html":{"href":"https://github.com/tonyganch/gonzales-pe/pull/23"},"issue":{"href":"https://api.github.com/repos/tonyganch/gonzales-pe/issues/23"},"comments":{"href":"https://api.github.com/repos/tonyganch/gonzales-pe/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/tonyganch/gonzales-pe/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/tonyganch/gonzales-pe/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/tonyganch/gonzales-pe/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/tonyganch/gonzales-pe/statuses/51779e698690ba7b8a44056cd76fb6f412e4cefa"}}}}