GitHub PushEvent at 2014-03-10 14:56:56
Repository: git
Actor: gitster
Payload: {"shas":[["3f419d45ef0dfc33dc301d9ae4737043c091291a","696e3fbcf235d40b6ea1ebd61c87cbea79d444e7@peff.net","show_ident_date: fix tz range check\n\nCommit 1dca155fe3fa (log: handle integer overflow in\ntimestamps, 2014-02-24) tried to catch integer overflow\ncoming from strtol() on the timezone field by comparing against\nLONG_MIN/LONG_MAX. However, the intermediate \"tz\" variable\nis an \"int\", which means it can never be LONG_MAX on LP64\nsystems; we would truncate the output from strtol before the\ncomparison.\n\nClang's -Wtautological-constant-out-of-range-compare notices\nthis and rightly complains.\n\nLet's instead store the result of strtol in a long, and then\ncompare it against INT_MIN/INT_MAX. This will catch overflow\nfrom strtol, and also overflow when we pass the result as an\nint to show_date.\n\nReported-by: Eric Sunshine <sunshine@sunshineco.com>\nSigned-off-by: Jeff King <peff@peff.net>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","Jeff King",false]],"size":1,"ref":"refs/heads/jk/commit-dates-parsing-fix","head":"3f419d45ef0dfc33dc301d9ae4737043c091291a"}