GitHub PullRequestReviewCommentEvent at 2014-06-26 04:32:35
Repository: vwf
Actor: davideaster
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/virtual-world-framework/vwf/pulls/comments/14224937","id":14224937,"diff_hunk":"@@ -3192,6 +3199,12 @@ if ( ! childComponent.source ) {\n \n             this.logger.debuggx( \"createEvent\", nodeID, eventName, eventParameters );\n \n+            // Encode any namespacing into the name. (Namespaced names were added in 0.6.21.)\n+\n+            if ( typeof eventName === \"object\" && eventName instanceof Array ) {","path":"support/client/lib/vwf.js","position":73,"original_position":73,"commit_id":"14deef318155866ef72b4610cc57eab3d52188bb","original_commit_id":"14deef318155866ef72b4610cc57eab3d52188bb","user":{"login":"davideaster","id":1580409,"avatar_url":"https://avatars.githubusercontent.com/u/1580409?","gravatar_id":"f30497f5e997fadbbfe3a0161e802838","url":"https://api.github.com/users/davideaster","html_url":"https://github.com/davideaster","followers_url":"https://api.github.com/users/davideaster/followers","following_url":"https://api.github.com/users/davideaster/following{/other_user}","gists_url":"https://api.github.com/users/davideaster/gists{/gist_id}","starred_url":"https://api.github.com/users/davideaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davideaster/subscriptions","organizations_url":"https://api.github.com/users/davideaster/orgs","repos_url":"https://api.github.com/users/davideaster/repos","events_url":"https://api.github.com/users/davideaster/events{/privacy}","received_events_url":"https://api.github.com/users/davideaster/received_events","type":"User","site_admin":false},"body":"Yes, that's better.\r\n\r\nI like to handle API variants right at the top, very explicitly. But that's covered by making the `namespaceEncodedName` call at all. The argument list parsing can be inside it.\r\n","created_at":"2014-06-26T04:32:35Z","updated_at":"2014-06-26T04:32:35Z","html_url":"https://github.com/virtual-world-framework/vwf/pull/142#discussion_r14224937","pull_request_url":"https://api.github.com/repos/virtual-world-framework/vwf/pulls/142","_links":{"self":{"href":"https://api.github.com/repos/virtual-world-framework/vwf/pulls/comments/14224937"},"html":{"href":"https://github.com/virtual-world-framework/vwf/pull/142#discussion_r14224937"},"pull_request":{"href":"https://api.github.com/repos/virtual-world-framework/vwf/pulls/142"}}},"pull_request":{"url":"https://api.github.com/repos/virtual-world-framework/vwf/pulls/142","id":12873097,"html_url":"https://github.com/virtual-world-framework/vwf/pull/142","diff_url":"https://github.com/virtual-world-framework/vwf/pull/142.diff","patch_url":"https://github.com/virtual-world-framework/vwf/pull/142.patch","issue_url":"https://api.github.com/repos/virtual-world-framework/vwf/issues/142","number":142,"state":"open","title":"Manage listeners from the kernel","user":{"login":"davideaster","id":1580409,"avatar_url":"https://avatars.githubusercontent.com/u/1580409?","gravatar_id":"f30497f5e997fadbbfe3a0161e802838","url":"https://api.github.com/users/davideaster","html_url":"https://github.com/davideaster","followers_url":"https://api.github.com/users/davideaster/followers","following_url":"https://api.github.com/users/davideaster/following{/other_user}","gists_url":"https://api.github.com/users/davideaster/gists{/gist_id}","starred_url":"https://api.github.com/users/davideaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davideaster/subscriptions","organizations_url":"https://api.github.com/users/davideaster/orgs","repos_url":"https://api.github.com/users/davideaster/repos","events_url":"https://api.github.com/users/davideaster/events{/privacy}","received_events_url":"https://api.github.com/users/davideaster/received_events","type":"User","site_admin":false},"body":"Have the kernel directly manage event listeners. Support namespaced event names.\r\n\r\nThe kernel will use a private namespace in `branch/collection-events` to send meta events into the application using names that won't conflict with any possible application event name. Additionally, the kernel will need to have direct knowledge of event listeners in order to replicate them correctly.\r\n\r\nThis is a predecessor to `branch/collection-events`, which uses the event mechanism for the kernel to deliver meta events into the application.\r\n\r\n@eric79 , please review.\r\n","created_at":"2014-02-24T20:43:48Z","updated_at":"2014-06-26T04:32:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"039b77fc07faeeafe973d3806515a83af403ef27","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/virtual-world-framework/vwf/pulls/142/commits","review_comments_url":"https://api.github.com/repos/virtual-world-framework/vwf/pulls/142/comments","review_comment_url":"https://api.github.com/repos/virtual-world-framework/vwf/pulls/comments/{number}","comments_url":"https://api.github.com/repos/virtual-world-framework/vwf/issues/142/comments","statuses_url":"https://api.github.com/repos/virtual-world-framework/vwf/statuses/14deef318155866ef72b4610cc57eab3d52188bb","head":{"label":"virtual-world-framework:branch/kernel-listeners","ref":"branch/kernel-listeners","sha":"14deef318155866ef72b4610cc57eab3d52188bb","user":{"login":"virtual-world-framework","id":1552130,"avatar_url":"https://avatars.githubusercontent.com/u/1552130?","gravatar_id":"4030558125d47329a00e5378c95d401b","url":"https://api.github.com/users/virtual-world-framework","html_url":"https://github.com/virtual-world-framework","followers_url":"https://api.github.com/users/virtual-world-framework/followers","following_url":"https://api.github.com/users/virtual-world-framework/following{/other_user}","gists_url":"https://api.github.com/users/virtual-world-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/virtual-world-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/virtual-world-framework/subscriptions","organizations_url":"https://api.github.com/users/virtual-world-framework/orgs","repos_url":"https://api.github.com/users/virtual-world-framework/repos","events_url":"https://api.github.com/users/virtual-world-framework/events{/privacy}","received_events_url":"https://api.github.com/users/virtual-world-framework/received_events","type":"Organization","site_admin":false},"repo":{"id":3857149,"name":"vwf","full_name":"virtual-world-framework/vwf","owner":{"login":"virtual-world-framework","id":1552130,"avatar_url":"https://avatars.githubusercontent.com/u/1552130?","gravatar_id":"4030558125d47329a00e5378c95d401b","url":"https://api.github.com/users/virtual-world-framework","html_url":"https://github.com/virtual-world-framework","followers_url":"https://api.github.com/users/virtual-world-framework/followers","following_url":"https://api.github.com/users/virtual-world-framework/following{/other_user}","gists_url":"https://api.github.com/users/virtual-world-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/virtual-world-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/virtual-world-framework/subscriptions","organizations_url":"https://api.github.com/users/virtual-world-framework/orgs","repos_url":"https://api.github.com/users/virtual-world-framework/repos","events_url":"https://api.github.com/users/virtual-world-framework/events{/privacy}","received_events_url":"https://api.github.com/users/virtual-world-framework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/virtual-world-framework/vwf","description":"Virtual World Framework","fork":false,"url":"https://api.github.com/repos/virtual-world-framework/vwf","forks_url":"https://api.github.com/repos/virtual-world-framework/vwf/forks","keys_url":"https://api.github.com/repos/virtual-world-framework/vwf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/virtual-world-framework/vwf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/virtual-world-framework/vwf/teams","hooks_url":"https://api.github.com/repos/virtual-world-framework/vwf/hooks","issue_events_url":"https://api.github.com/repos/virtual-world-framework/vwf/issues/events{/number}","events_url":"https://api.github.com/repos/virtual-world-framework/vwf/events","assignees_url":"https://api.github.com/repos/virtual-world-framework/vwf/assignees{/user}","branches_url":"https://api.github.com/repos/virtual-world-framework/vwf/branches{/branch}","tags_url":"https://api.github.com/repos/virtual-world-framework/vwf/tags","blobs_url":"https://api.github.com/repos/virtual-world-framework/vwf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/virtual-world-framework/vwf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/virtual-world-framework/vwf/git/refs{/sha}","trees_url":"https://api.github.com/repos/virtual-world-framework/vwf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/virtual-world-framework/vwf/statuses/{sha}","languages_url":"https://api.github.com/repos/virtual-world-framework/vwf/languages","stargazers_url":"https://api.github.com/repos/virtual-world-framework/vwf/stargazers","contributors_url":"https://api.github.com/repos/virtual-world-framework/vwf/contributors","subscribers_url":"https://api.github.com/repos/virtual-world-framework/vwf/subscribers","subscription_url":"https://api.github.com/repos/virtual-world-framework/vwf/subscription","commits_url":"https://api.github.com/repos/virtual-world-framework/vwf/commits{/sha}","git_commits_url":"https://api.github.com/repos/virtual-world-framework/vwf/git/commits{/sha}","comments_url":"https://api.github.com/repos/virtual-world-framework/vwf/comments{/number}","issue_comment_url":"https://api.github.com/repos/virtual-world-framework/vwf/issues/comments/{number}","contents_url":"https://api.github.com/repos/virtual-world-framework/vwf/contents/{+path}","compare_url":"https://api.github.com/repos/virtual-world-framework/vwf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/virtual-world-framework/vwf/merges","archive_url":"https://api.github.com/repos/virtual-world-framework/vwf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/virtual-world-framework/vwf/downloads","issues_url":"https://api.github.com/repos/virtual-world-framework/vwf/issues{/number}","pulls_url":"https://api.github.com/repos/virtual-world-framework/vwf/pulls{/number}","milestones_url":"https://api.github.com/repos/virtual-world-framework/vwf/milestones{/number}","notifications_url":"https://api.github.com/repos/virtual-world-framework/vwf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/virtual-world-framework/vwf/labels{/name}","releases_url":"https://api.github.com/repos/virtual-world-framework/vwf/releases{/id}","created_at":"2012-03-28T16:40:09Z","updated_at":"2014-06-25T04:38:06Z","pushed_at":"2014-06-25T17:49:28Z","git_url":"git://github.com/virtual-world-framework/vwf.git","ssh_url":"git@github.com:virtual-world-framework/vwf.git","clone_url":"https://github.com/virtual-world-framework/vwf.git","svn_url":"https://github.com/virtual-world-framework/vwf","homepage":"http://virtual.wf","size":733020,"stargazers_count":72,"watchers_count":72,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":40,"mirror_url":null,"open_issues_count":23,"forks":40,"open_issues":23,"watchers":72,"default_branch":"master"}},"base":{"label":"virtual-world-framework:branch/collection-refactor","ref":"branch/collection-refactor","sha":"b6600e4b0118cca0fe2b204a37d1227a187633d6","user":{"login":"virtual-world-framework","id":1552130,"avatar_url":"https://avatars.githubusercontent.com/u/1552130?","gravatar_id":"4030558125d47329a00e5378c95d401b","url":"https://api.github.com/users/virtual-world-framework","html_url":"https://github.com/virtual-world-framework","followers_url":"https://api.github.com/users/virtual-world-framework/followers","following_url":"https://api.github.com/users/virtual-world-framework/following{/other_user}","gists_url":"https://api.github.com/users/virtual-world-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/virtual-world-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/virtual-world-framework/subscriptions","organizations_url":"https://api.github.com/users/virtual-world-framework/orgs","repos_url":"https://api.github.com/users/virtual-world-framework/repos","events_url":"https://api.github.com/users/virtual-world-framework/events{/privacy}","received_events_url":"https://api.github.com/users/virtual-world-framework/received_events","type":"Organization","site_admin":false},"repo":{"id":3857149,"name":"vwf","full_name":"virtual-world-framework/vwf","owner":{"login":"virtual-world-framework","id":1552130,"avatar_url":"https://avatars.githubusercontent.com/u/1552130?","gravatar_id":"4030558125d47329a00e5378c95d401b","url":"https://api.github.com/users/virtual-world-framework","html_url":"https://github.com/virtual-world-framework","followers_url":"https://api.github.com/users/virtual-world-framework/followers","following_url":"https://api.github.com/users/virtual-world-framework/following{/other_user}","gists_url":"https://api.github.com/users/virtual-world-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/virtual-world-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/virtual-world-framework/subscriptions","organizations_url":"https://api.github.com/users/virtual-world-framework/orgs","repos_url":"https://api.github.com/users/virtual-world-framework/repos","events_url":"https://api.github.com/users/virtual-world-framework/events{/privacy}","received_events_url":"https://api.github.com/users/virtual-world-framework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/virtual-world-framework/vwf","description":"Virtual World Framework","fork":false,"url":"https://api.github.com/repos/virtual-world-framework/vwf","forks_url":"https://api.github.com/repos/virtual-world-framework/vwf/forks","keys_url":"https://api.github.com/repos/virtual-world-framework/vwf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/virtual-world-framework/vwf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/virtual-world-framework/vwf/teams","hooks_url":"https://api.github.com/repos/virtual-world-framework/vwf/hooks","issue_events_url":"https://api.github.com/repos/virtual-world-framework/vwf/issues/events{/number}","events_url":"https://api.github.com/repos/virtual-world-framework/vwf/events","assignees_url":"https://api.github.com/repos/virtual-world-framework/vwf/assignees{/user}","branches_url":"https://api.github.com/repos/virtual-world-framework/vwf/branches{/branch}","tags_url":"https://api.github.com/repos/virtual-world-framework/vwf/tags","blobs_url":"https://api.github.com/repos/virtual-world-framework/vwf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/virtual-world-framework/vwf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/virtual-world-framework/vwf/git/refs{/sha}","trees_url":"https://api.github.com/repos/virtual-world-framework/vwf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/virtual-world-framework/vwf/statuses/{sha}","languages_url":"https://api.github.com/repos/virtual-world-framework/vwf/languages","stargazers_url":"https://api.github.com/repos/virtual-world-framework/vwf/stargazers","contributors_url":"https://api.github.com/repos/virtual-world-framework/vwf/contributors","subscribers_url":"https://api.github.com/repos/virtual-world-framework/vwf/subscribers","subscription_url":"https://api.github.com/repos/virtual-world-framework/vwf/subscription","commits_url":"https://api.github.com/repos/virtual-world-framework/vwf/commits{/sha}","git_commits_url":"https://api.github.com/repos/virtual-world-framework/vwf/git/commits{/sha}","comments_url":"https://api.github.com/repos/virtual-world-framework/vwf/comments{/number}","issue_comment_url":"https://api.github.com/repos/virtual-world-framework/vwf/issues/comments/{number}","contents_url":"https://api.github.com/repos/virtual-world-framework/vwf/contents/{+path}","compare_url":"https://api.github.com/repos/virtual-world-framework/vwf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/virtual-world-framework/vwf/merges","archive_url":"https://api.github.com/repos/virtual-world-framework/vwf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/virtual-world-framework/vwf/downloads","issues_url":"https://api.github.com/repos/virtual-world-framework/vwf/issues{/number}","pulls_url":"https://api.github.com/repos/virtual-world-framework/vwf/pulls{/number}","milestones_url":"https://api.github.com/repos/virtual-world-framework/vwf/milestones{/number}","notifications_url":"https://api.github.com/repos/virtual-world-framework/vwf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/virtual-world-framework/vwf/labels{/name}","releases_url":"https://api.github.com/repos/virtual-world-framework/vwf/releases{/id}","created_at":"2012-03-28T16:40:09Z","updated_at":"2014-06-25T04:38:06Z","pushed_at":"2014-06-25T17:49:28Z","git_url":"git://github.com/virtual-world-framework/vwf.git","ssh_url":"git@github.com:virtual-world-framework/vwf.git","clone_url":"https://github.com/virtual-world-framework/vwf.git","svn_url":"https://github.com/virtual-world-framework/vwf","homepage":"http://virtual.wf","size":733020,"stargazers_count":72,"watchers_count":72,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":40,"mirror_url":null,"open_issues_count":23,"forks":40,"open_issues":23,"watchers":72,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/virtual-world-framework/vwf/pulls/142"},"html":{"href":"https://github.com/virtual-world-framework/vwf/pull/142"},"issue":{"href":"https://api.github.com/repos/virtual-world-framework/vwf/issues/142"},"comments":{"href":"https://api.github.com/repos/virtual-world-framework/vwf/issues/142/comments"},"review_comments":{"href":"https://api.github.com/repos/virtual-world-framework/vwf/pulls/142/comments"},"review_comment":{"href":"https://api.github.com/repos/virtual-world-framework/vwf/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/virtual-world-framework/vwf/pulls/142/commits"},"statuses":{"href":"https://api.github.com/repos/virtual-world-framework/vwf/statuses/14deef318155866ef72b4610cc57eab3d52188bb"}}}}