GitHub PullRequestReviewCommentEvent at 2014-03-21 11:52:00
Repository: barclamp-database
Actor: vuntz
Payload: {"comment":{"url":"https://api.github.com/repos/vuntz/barclamp-database/pulls/comments/10833487","id":10833487,"diff_hunk":"@@ -18,4 +18,36 @@ $(document).ready(function($) {\n     $(selector).hide(100).attr('disabled', 'disabled');\n     $(current).show(100).removeAttr('disabled');\n   }).trigger('change');\n+\n+  function isCluster(node_id) {\n+     return !!node_id.match(/^cluster:/);","path":"crowbar_framework/app/assets/javascripts/barclamps/database/form.js","position":6,"original_position":6,"commit_id":"77c9d985ab93850eac4544e11c6603a710307d1d","original_commit_id":"77c9d985ab93850eac4544e11c6603a710307d1d","user":{"login":"vuntz","id":1758783,"avatar_url":"https://avatars.githubusercontent.com/u/1758783?","gravatar_id":"d7cc6451b64c4351e27db322d114d4aa","url":"https://api.github.com/users/vuntz","html_url":"https://github.com/vuntz","followers_url":"https://api.github.com/users/vuntz/followers","following_url":"https://api.github.com/users/vuntz/following{/other_user}","gists_url":"https://api.github.com/users/vuntz/gists{/gist_id}","starred_url":"https://api.github.com/users/vuntz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuntz/subscriptions","organizations_url":"https://api.github.com/users/vuntz/orgs","repos_url":"https://api.github.com/users/vuntz/repos","events_url":"https://api.github.com/users/vuntz/events{/privacy}","received_events_url":"https://api.github.com/users/vuntz/received_events","type":"User","site_admin":false},"body":"I'm not sure how doable this would be, but ideally we would not hardcode ```cluster:```; we've tried hard avoiding that in all the other places. Can't really think of a good way to avoid this, though.","created_at":"2014-03-21T11:52:00Z","updated_at":"2014-03-21T11:52:00Z","html_url":"https://github.com/vuntz/barclamp-database/pull/1#discussion_r10833487","pull_request_url":"https://api.github.com/repos/vuntz/barclamp-database/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/vuntz/barclamp-database/pulls/comments/10833487"},"html":{"href":"https://github.com/vuntz/barclamp-database/pull/1#discussion_r10833487"},"pull_request":{"href":"https://api.github.com/repos/vuntz/barclamp-database/pulls/1"}}}}