GitHub PullRequestReviewCommentEvent at 2014-10-03 23:47:35
Repository: gocd
Actor: houndci
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/gocd/gocd/pulls/comments/18425246","id":18425246,"diff_hunk":"@@ -15,53 +15,84 @@\n  *************************GO-LICENSE-END**********************************/\n \n var MockXHR = Class.create({\n-  initialize: function(responseHeaders, responseText){\n-    this.status = 0;\n-    this.readyState = 0;\n-    this.onreadystatechange = Prototype.emptyFunction;\n-    this.headers = responseHeaders ? responseHeaders : {};\n-    this.setResponseCode();\n-    this.responseText = responseText ? responseText : '';\n-  },\n-  setResponseHeaders: function(headers){\n-    this.headers;\n-  },\n-  setResponseText: function(text){\n-    this.responseText = text;\n-  },\n-  setResponseCode: function(){\n-    if(this.headers.status){\n-      this.status = this.headers.status;\n-    }\n-    if(this.headers.statusText){\n-      this.statusText = this.headers.statusText;\n-    }\n-  },\n-  process: function(){\n-    if(this.readyState < 0 || this.readyState > 4){\n-      return;\n+    initialize: function(responseHeaders, responseText){\n+        this.status = 0;\n+        this.readyState = 0;\n+        this.onreadystatechange = Prototype.emptyFunction;\n+        this.headers = responseHeaders ? responseHeaders : {};\n+        this.setResponseCode();\n+        this.responseText = responseText ? responseText : '';\n+\n+        this.headersSentInRequest = {};\n+        this.bodyOfRequest = \"\";\n+        this.urlOfRequest = \"\";\n+        this.methodOfRequest = \"\";\n+    },\n+    setResponseHeaders: function(headers){\n+        this.headers;\n+    },\n+    setResponseText: function(text){\n+        this.responseText = text;\n+    },\n+    setResponseCode: function(){\n+        if(this.headers.status){\n+            this.status = this.headers.status;\n+        }\n+        if(this.headers.statusText){\n+            this.statusText = this.headers.statusText;\n+        }\n+    },\n+    process: function(){\n+        if(this.readyState < 0 || this.readyState > 4){\n+            return;\n+        }\n+        this.readyState++;\n+        this.onreadystatechange();\n+        this.process();\n+    },\n+    /* mock methods */\n+    getResponseHeader: function(name){\n+        return this.headers[name];\n+    },\n+    setRequestHeader: function(name, value){\n+        console.log(\"Got header: \" + name + \" \" + value);\n+        this.headersSentInRequest[name] = value;\n+    },\n+    open: function(method, url, asynchronous){\n+        this.urlOfRequest = url;\n+        this.methodOfRequest = url;\n+    },\n+    send: function(body){\n+        this.bodyOfRequest = body;\n+        this.process();\n     }\n-    this.readyState++;\n-    this.onreadystatechange();\n-    this.process();\n-  },\n-  /* mock methods */\n-  getResponseHeader: function(name){\n-    return this.headers[name];\n-  },\n-  setRequestHeader: function(name, value){\n-    //do nothing\n-  },\n-  open: function(method, url, asynchronous){\n-    \n-  },\n-  send: function(body){\n-    this.process();\n-  }\n });\n \n+function getReadyToMockRequests() {\n+    window.originalTransport = window.Ajax.getTransport;\n+}\n+\n+function cleanUpMockRequests() {","path":"server/webapp/WEB-INF/rails.new/spec/javascripts/helpers/test_helper.js","position":103,"original_position":103,"commit_id":"b62ac15c5754d5db1e5596e7b601ad2bf264f7ed","original_commit_id":"b62ac15c5754d5db1e5596e7b601ad2bf264f7ed","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=2","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"'cleanUpMockRequests' is defined but never used.","created_at":"2014-10-03T23:47:35Z","updated_at":"2014-10-03T23:47:35Z","html_url":"https://github.com/gocd/gocd/pull/616#discussion_r18425246","pull_request_url":"https://api.github.com/repos/gocd/gocd/pulls/616","_links":{"self":{"href":"https://api.github.com/repos/gocd/gocd/pulls/comments/18425246"},"html":{"href":"https://github.com/gocd/gocd/pull/616#discussion_r18425246"},"pull_request":{"href":"https://api.github.com/repos/gocd/gocd/pulls/616"}}},"pull_request":{"url":"https://api.github.com/repos/gocd/gocd/pulls/616","id":22236566,"html_url":"https://github.com/gocd/gocd/pull/616","diff_url":"https://github.com/gocd/gocd/pull/616.diff","patch_url":"https://github.com/gocd/gocd/pull/616.patch","issue_url":"https://api.github.com/repos/gocd/gocd/issues/616","number":616,"state":"open","locked":false,"title":"#560 - Fix server config validation issues.","user":{"login":"arvindsv","id":172235,"avatar_url":"https://avatars.githubusercontent.com/u/172235?v=2","gravatar_id":"","url":"https://api.github.com/users/arvindsv","html_url":"https://github.com/arvindsv","followers_url":"https://api.github.com/users/arvindsv/followers","following_url":"https://api.github.com/users/arvindsv/following{/other_user}","gists_url":"https://api.github.com/users/arvindsv/gists{/gist_id}","starred_url":"https://api.github.com/users/arvindsv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvindsv/subscriptions","organizations_url":"https://api.github.com/users/arvindsv/orgs","repos_url":"https://api.github.com/users/arvindsv/repos","events_url":"https://api.github.com/users/arvindsv/events{/privacy}","received_events_url":"https://api.github.com/users/arvindsv/received_events","type":"User","site_admin":false},"body":"Sorry for the confusion. This is the same as PR https://github.com/gocd/gocd/pull/611, which I merged by mistake.","created_at":"2014-10-03T23:47:27Z","updated_at":"2014-10-03T23:47:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"69cd1777f1593dada29020cd17fe06871ae4b304","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gocd/gocd/pulls/616/commits","review_comments_url":"https://api.github.com/repos/gocd/gocd/pulls/616/comments","review_comment_url":"https://api.github.com/repos/gocd/gocd/pulls/comments/{number}","comments_url":"https://api.github.com/repos/gocd/gocd/issues/616/comments","statuses_url":"https://api.github.com/repos/gocd/gocd/statuses/b62ac15c5754d5db1e5596e7b601ad2bf264f7ed","head":{"label":"arvindsv:fix_server_config_issues","ref":"fix_server_config_issues","sha":"b62ac15c5754d5db1e5596e7b601ad2bf264f7ed","user":{"login":"arvindsv","id":172235,"avatar_url":"https://avatars.githubusercontent.com/u/172235?v=2","gravatar_id":"","url":"https://api.github.com/users/arvindsv","html_url":"https://github.com/arvindsv","followers_url":"https://api.github.com/users/arvindsv/followers","following_url":"https://api.github.com/users/arvindsv/following{/other_user}","gists_url":"https://api.github.com/users/arvindsv/gists{/gist_id}","starred_url":"https://api.github.com/users/arvindsv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvindsv/subscriptions","organizations_url":"https://api.github.com/users/arvindsv/orgs","repos_url":"https://api.github.com/users/arvindsv/repos","events_url":"https://api.github.com/users/arvindsv/events{/privacy}","received_events_url":"https://api.github.com/users/arvindsv/received_events","type":"User","site_admin":false},"repo":{"id":19228032,"name":"gocd","full_name":"arvindsv/gocd","owner":{"login":"arvindsv","id":172235,"avatar_url":"https://avatars.githubusercontent.com/u/172235?v=2","gravatar_id":"","url":"https://api.github.com/users/arvindsv","html_url":"https://github.com/arvindsv","followers_url":"https://api.github.com/users/arvindsv/followers","following_url":"https://api.github.com/users/arvindsv/following{/other_user}","gists_url":"https://api.github.com/users/arvindsv/gists{/gist_id}","starred_url":"https://api.github.com/users/arvindsv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvindsv/subscriptions","organizations_url":"https://api.github.com/users/arvindsv/orgs","repos_url":"https://api.github.com/users/arvindsv/repos","events_url":"https://api.github.com/users/arvindsv/events{/privacy}","received_events_url":"https://api.github.com/users/arvindsv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arvindsv/gocd","description":"Main repository for Go Continuous Delivery","fork":true,"url":"https://api.github.com/repos/arvindsv/gocd","forks_url":"https://api.github.com/repos/arvindsv/gocd/forks","keys_url":"https://api.github.com/repos/arvindsv/gocd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arvindsv/gocd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arvindsv/gocd/teams","hooks_url":"https://api.github.com/repos/arvindsv/gocd/hooks","issue_events_url":"https://api.github.com/repos/arvindsv/gocd/issues/events{/number}","events_url":"https://api.github.com/repos/arvindsv/gocd/events","assignees_url":"https://api.github.com/repos/arvindsv/gocd/assignees{/user}","branches_url":"https://api.github.com/repos/arvindsv/gocd/branches{/branch}","tags_url":"https://api.github.com/repos/arvindsv/gocd/tags","blobs_url":"https://api.github.com/repos/arvindsv/gocd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arvindsv/gocd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arvindsv/gocd/git/refs{/sha}","trees_url":"https://api.github.com/repos/arvindsv/gocd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arvindsv/gocd/statuses/{sha}","languages_url":"https://api.github.com/repos/arvindsv/gocd/languages","stargazers_url":"https://api.github.com/repos/arvindsv/gocd/stargazers","contributors_url":"https://api.github.com/repos/arvindsv/gocd/contributors","subscribers_url":"https://api.github.com/repos/arvindsv/gocd/subscribers","subscription_url":"https://api.github.com/repos/arvindsv/gocd/subscription","commits_url":"https://api.github.com/repos/arvindsv/gocd/commits{/sha}","git_commits_url":"https://api.github.com/repos/arvindsv/gocd/git/commits{/sha}","comments_url":"https://api.github.com/repos/arvindsv/gocd/comments{/number}","issue_comment_url":"https://api.github.com/repos/arvindsv/gocd/issues/comments/{number}","contents_url":"https://api.github.com/repos/arvindsv/gocd/contents/{+path}","compare_url":"https://api.github.com/repos/arvindsv/gocd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arvindsv/gocd/merges","archive_url":"https://api.github.com/repos/arvindsv/gocd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arvindsv/gocd/downloads","issues_url":"https://api.github.com/repos/arvindsv/gocd/issues{/number}","pulls_url":"https://api.github.com/repos/arvindsv/gocd/pulls{/number}","milestones_url":"https://api.github.com/repos/arvindsv/gocd/milestones{/number}","notifications_url":"https://api.github.com/repos/arvindsv/gocd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arvindsv/gocd/labels{/name}","releases_url":"https://api.github.com/repos/arvindsv/gocd/releases{/id}","created_at":"2014-04-28T05:27:12Z","updated_at":"2014-09-12T19:09:28Z","pushed_at":"2014-10-03T23:45:44Z","git_url":"git://github.com/arvindsv/gocd.git","ssh_url":"git@github.com:arvindsv/gocd.git","clone_url":"https://github.com/arvindsv/gocd.git","svn_url":"https://github.com/arvindsv/gocd","homepage":null,"size":198247,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gocd:master","ref":"master","sha":"e886d10e7852e265cc394cbc22729e7c09d43091","user":{"login":"gocd","id":6099846,"avatar_url":"https://avatars.githubusercontent.com/u/6099846?v=2","gravatar_id":"","url":"https://api.github.com/users/gocd","html_url":"https://github.com/gocd","followers_url":"https://api.github.com/users/gocd/followers","following_url":"https://api.github.com/users/gocd/following{/other_user}","gists_url":"https://api.github.com/users/gocd/gists{/gist_id}","starred_url":"https://api.github.com/users/gocd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gocd/subscriptions","organizations_url":"https://api.github.com/users/gocd/orgs","repos_url":"https://api.github.com/users/gocd/repos","events_url":"https://api.github.com/users/gocd/events{/privacy}","received_events_url":"https://api.github.com/users/gocd/received_events","type":"Organization","site_admin":false},"repo":{"id":15155534,"name":"gocd","full_name":"gocd/gocd","owner":{"login":"gocd","id":6099846,"avatar_url":"https://avatars.githubusercontent.com/u/6099846?v=2","gravatar_id":"","url":"https://api.github.com/users/gocd","html_url":"https://github.com/gocd","followers_url":"https://api.github.com/users/gocd/followers","following_url":"https://api.github.com/users/gocd/following{/other_user}","gists_url":"https://api.github.com/users/gocd/gists{/gist_id}","starred_url":"https://api.github.com/users/gocd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gocd/subscriptions","organizations_url":"https://api.github.com/users/gocd/orgs","repos_url":"https://api.github.com/users/gocd/repos","events_url":"https://api.github.com/users/gocd/events{/privacy}","received_events_url":"https://api.github.com/users/gocd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gocd/gocd","description":"Main repository for Go Continuous Delivery","fork":false,"url":"https://api.github.com/repos/gocd/gocd","forks_url":"https://api.github.com/repos/gocd/gocd/forks","keys_url":"https://api.github.com/repos/gocd/gocd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gocd/gocd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gocd/gocd/teams","hooks_url":"https://api.github.com/repos/gocd/gocd/hooks","issue_events_url":"https://api.github.com/repos/gocd/gocd/issues/events{/number}","events_url":"https://api.github.com/repos/gocd/gocd/events","assignees_url":"https://api.github.com/repos/gocd/gocd/assignees{/user}","branches_url":"https://api.github.com/repos/gocd/gocd/branches{/branch}","tags_url":"https://api.github.com/repos/gocd/gocd/tags","blobs_url":"https://api.github.com/repos/gocd/gocd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gocd/gocd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gocd/gocd/git/refs{/sha}","trees_url":"https://api.github.com/repos/gocd/gocd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gocd/gocd/statuses/{sha}","languages_url":"https://api.github.com/repos/gocd/gocd/languages","stargazers_url":"https://api.github.com/repos/gocd/gocd/stargazers","contributors_url":"https://api.github.com/repos/gocd/gocd/contributors","subscribers_url":"https://api.github.com/repos/gocd/gocd/subscribers","subscription_url":"https://api.github.com/repos/gocd/gocd/subscription","commits_url":"https://api.github.com/repos/gocd/gocd/commits{/sha}","git_commits_url":"https://api.github.com/repos/gocd/gocd/git/commits{/sha}","comments_url":"https://api.github.com/repos/gocd/gocd/comments{/number}","issue_comment_url":"https://api.github.com/repos/gocd/gocd/issues/comments/{number}","contents_url":"https://api.github.com/repos/gocd/gocd/contents/{+path}","compare_url":"https://api.github.com/repos/gocd/gocd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gocd/gocd/merges","archive_url":"https://api.github.com/repos/gocd/gocd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gocd/gocd/downloads","issues_url":"https://api.github.com/repos/gocd/gocd/issues{/number}","pulls_url":"https://api.github.com/repos/gocd/gocd/pulls{/number}","milestones_url":"https://api.github.com/repos/gocd/gocd/milestones{/number}","notifications_url":"https://api.github.com/repos/gocd/gocd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gocd/gocd/labels{/name}","releases_url":"https://api.github.com/repos/gocd/gocd/releases{/id}","created_at":"2013-12-13T05:26:16Z","updated_at":"2014-10-03T12:02:07Z","pushed_at":"2014-10-03T23:40:55Z","git_url":"git://github.com/gocd/gocd.git","ssh_url":"git@github.com:gocd/gocd.git","clone_url":"https://github.com/gocd/gocd.git","svn_url":"https://github.com/gocd/gocd","homepage":null,"size":212546,"stargazers_count":1033,"watchers_count":1033,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":155,"mirror_url":null,"open_issues_count":272,"forks":155,"open_issues":272,"watchers":1033,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gocd/gocd/pulls/616"},"html":{"href":"https://github.com/gocd/gocd/pull/616"},"issue":{"href":"https://api.github.com/repos/gocd/gocd/issues/616"},"comments":{"href":"https://api.github.com/repos/gocd/gocd/issues/616/comments"},"review_comments":{"href":"https://api.github.com/repos/gocd/gocd/pulls/616/comments"},"review_comment":{"href":"https://api.github.com/repos/gocd/gocd/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/gocd/gocd/pulls/616/commits"},"statuses":{"href":"https://api.github.com/repos/gocd/gocd/statuses/b62ac15c5754d5db1e5596e7b601ad2bf264f7ed"}}}}