GitHub PullRequestEvent at 2014-06-04 16:39:31
Repository: makedrive
Actor: yoavgurevich
Payload: {"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/yoavgurevich/makedrive/pulls/1","id":16718981,"html_url":"https://github.com/yoavgurevich/makedrive/pull/1","diff_url":"https://github.com/yoavgurevich/makedrive/pull/1.diff","patch_url":"https://github.com/yoavgurevich/makedrive/pull/1.patch","issue_url":"https://api.github.com/repos/yoavgurevich/makedrive/issues/1","number":1,"state":"closed","title":"Tests","user":{"login":"humphd","id":427398,"avatar_url":"https://avatars.githubusercontent.com/u/427398?","gravatar_id":"467b6f36e2a9ba3f0ec119eddaab6a62","url":"https://api.github.com/users/humphd","html_url":"https://github.com/humphd","followers_url":"https://api.github.com/users/humphd/followers","following_url":"https://api.github.com/users/humphd/following{/other_user}","gists_url":"https://api.github.com/users/humphd/gists{/gist_id}","starred_url":"https://api.github.com/users/humphd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/humphd/subscriptions","organizations_url":"https://api.github.com/users/humphd/orgs","repos_url":"https://api.github.com/users/humphd/repos","events_url":"https://api.github.com/users/humphd/events{/privacy}","received_events_url":"https://api.github.com/users/humphd/received_events","type":"User","site_admin":false},"body":"This builds on what you did and reworks things into a better structure.  I've written tests for the test lib itself, which should show you how things work (see `tests/lib/util.js` and `tests/unit/util-tests.js`).  I've also written one simple route test using the new harness so you can see that working too. Other tests can be added in a similar manner.","created_at":"2014-06-04T16:31:54Z","updated_at":"2014-06-04T16:39:31Z","closed_at":"2014-06-04T16:39:31Z","merged_at":"2014-06-04T16:39:31Z","merge_commit_sha":"e79f9fe73d5bd315a4a78e39fa5169a70417a9cb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/yoavgurevich/makedrive/pulls/1/commits","review_comments_url":"https://api.github.com/repos/yoavgurevich/makedrive/pulls/1/comments","review_comment_url":"https://api.github.com/repos/yoavgurevich/makedrive/pulls/comments/{number}","comments_url":"https://api.github.com/repos/yoavgurevich/makedrive/issues/1/comments","statuses_url":"https://api.github.com/repos/yoavgurevich/makedrive/statuses/176861e65f386aff6a32a92cdf58d51c169162e0","head":{"label":"humphd:tests","ref":"tests","sha":"176861e65f386aff6a32a92cdf58d51c169162e0","user":{"login":"humphd","id":427398,"avatar_url":"https://avatars.githubusercontent.com/u/427398?","gravatar_id":"467b6f36e2a9ba3f0ec119eddaab6a62","url":"https://api.github.com/users/humphd","html_url":"https://github.com/humphd","followers_url":"https://api.github.com/users/humphd/followers","following_url":"https://api.github.com/users/humphd/following{/other_user}","gists_url":"https://api.github.com/users/humphd/gists{/gist_id}","starred_url":"https://api.github.com/users/humphd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/humphd/subscriptions","organizations_url":"https://api.github.com/users/humphd/orgs","repos_url":"https://api.github.com/users/humphd/repos","events_url":"https://api.github.com/users/humphd/events{/privacy}","received_events_url":"https://api.github.com/users/humphd/received_events","type":"User","site_admin":false},"repo":{"id":18801855,"name":"makedrive","full_name":"humphd/makedrive","owner":{"login":"humphd","id":427398,"avatar_url":"https://avatars.githubusercontent.com/u/427398?","gravatar_id":"467b6f36e2a9ba3f0ec119eddaab6a62","url":"https://api.github.com/users/humphd","html_url":"https://github.com/humphd","followers_url":"https://api.github.com/users/humphd/followers","following_url":"https://api.github.com/users/humphd/following{/other_user}","gists_url":"https://api.github.com/users/humphd/gists{/gist_id}","starred_url":"https://api.github.com/users/humphd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/humphd/subscriptions","organizations_url":"https://api.github.com/users/humphd/orgs","repos_url":"https://api.github.com/users/humphd/repos","events_url":"https://api.github.com/users/humphd/events{/privacy}","received_events_url":"https://api.github.com/users/humphd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/humphd/makedrive","description":"Webmaker Filesystem","fork":true,"url":"https://api.github.com/repos/humphd/makedrive","forks_url":"https://api.github.com/repos/humphd/makedrive/forks","keys_url":"https://api.github.com/repos/humphd/makedrive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/humphd/makedrive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/humphd/makedrive/teams","hooks_url":"https://api.github.com/repos/humphd/makedrive/hooks","issue_events_url":"https://api.github.com/repos/humphd/makedrive/issues/events{/number}","events_url":"https://api.github.com/repos/humphd/makedrive/events","assignees_url":"https://api.github.com/repos/humphd/makedrive/assignees{/user}","branches_url":"https://api.github.com/repos/humphd/makedrive/branches{/branch}","tags_url":"https://api.github.com/repos/humphd/makedrive/tags","blobs_url":"https://api.github.com/repos/humphd/makedrive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/humphd/makedrive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/humphd/makedrive/git/refs{/sha}","trees_url":"https://api.github.com/repos/humphd/makedrive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/humphd/makedrive/statuses/{sha}","languages_url":"https://api.github.com/repos/humphd/makedrive/languages","stargazers_url":"https://api.github.com/repos/humphd/makedrive/stargazers","contributors_url":"https://api.github.com/repos/humphd/makedrive/contributors","subscribers_url":"https://api.github.com/repos/humphd/makedrive/subscribers","subscription_url":"https://api.github.com/repos/humphd/makedrive/subscription","commits_url":"https://api.github.com/repos/humphd/makedrive/commits{/sha}","git_commits_url":"https://api.github.com/repos/humphd/makedrive/git/commits{/sha}","comments_url":"https://api.github.com/repos/humphd/makedrive/comments{/number}","issue_comment_url":"https://api.github.com/repos/humphd/makedrive/issues/comments/{number}","contents_url":"https://api.github.com/repos/humphd/makedrive/contents/{+path}","compare_url":"https://api.github.com/repos/humphd/makedrive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/humphd/makedrive/merges","archive_url":"https://api.github.com/repos/humphd/makedrive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/humphd/makedrive/downloads","issues_url":"https://api.github.com/repos/humphd/makedrive/issues{/number}","pulls_url":"https://api.github.com/repos/humphd/makedrive/pulls{/number}","milestones_url":"https://api.github.com/repos/humphd/makedrive/milestones{/number}","notifications_url":"https://api.github.com/repos/humphd/makedrive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/humphd/makedrive/labels{/name}","releases_url":"https://api.github.com/repos/humphd/makedrive/releases{/id}","created_at":"2014-04-15T13:54:15Z","updated_at":"2014-06-04T16:39:31Z","pushed_at":"2014-06-04T16:29:39Z","git_url":"git://github.com/humphd/makedrive.git","ssh_url":"git@github.com:humphd/makedrive.git","clone_url":"https://github.com/humphd/makedrive.git","svn_url":"https://github.com/humphd/makedrive","homepage":null,"size":371,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"yoavgurevich:master","ref":"master","sha":"e3f823f4b7693546faa3bfec94f52fee5932a549","user":{"login":"yoavgurevich","id":2465960,"avatar_url":"https://avatars.githubusercontent.com/u/2465960?","gravatar_id":"a35a701eef438f322b826a1d5de7f85b","url":"https://api.github.com/users/yoavgurevich","html_url":"https://github.com/yoavgurevich","followers_url":"https://api.github.com/users/yoavgurevich/followers","following_url":"https://api.github.com/users/yoavgurevich/following{/other_user}","gists_url":"https://api.github.com/users/yoavgurevich/gists{/gist_id}","starred_url":"https://api.github.com/users/yoavgurevich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yoavgurevich/subscriptions","organizations_url":"https://api.github.com/users/yoavgurevich/orgs","repos_url":"https://api.github.com/users/yoavgurevich/repos","events_url":"https://api.github.com/users/yoavgurevich/events{/privacy}","received_events_url":"https://api.github.com/users/yoavgurevich/received_events","type":"User","site_admin":false},"repo":{"id":20410156,"name":"makedrive","full_name":"yoavgurevich/makedrive","owner":{"login":"yoavgurevich","id":2465960,"avatar_url":"https://avatars.githubusercontent.com/u/2465960?","gravatar_id":"a35a701eef438f322b826a1d5de7f85b","url":"https://api.github.com/users/yoavgurevich","html_url":"https://github.com/yoavgurevich","followers_url":"https://api.github.com/users/yoavgurevich/followers","following_url":"https://api.github.com/users/yoavgurevich/following{/other_user}","gists_url":"https://api.github.com/users/yoavgurevich/gists{/gist_id}","starred_url":"https://api.github.com/users/yoavgurevich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yoavgurevich/subscriptions","organizations_url":"https://api.github.com/users/yoavgurevich/orgs","repos_url":"https://api.github.com/users/yoavgurevich/repos","events_url":"https://api.github.com/users/yoavgurevich/events{/privacy}","received_events_url":"https://api.github.com/users/yoavgurevich/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yoavgurevich/makedrive","description":"Webmaker Filesystem","fork":true,"url":"https://api.github.com/repos/yoavgurevich/makedrive","forks_url":"https://api.github.com/repos/yoavgurevich/makedrive/forks","keys_url":"https://api.github.com/repos/yoavgurevich/makedrive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yoavgurevich/makedrive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yoavgurevich/makedrive/teams","hooks_url":"https://api.github.com/repos/yoavgurevich/makedrive/hooks","issue_events_url":"https://api.github.com/repos/yoavgurevich/makedrive/issues/events{/number}","events_url":"https://api.github.com/repos/yoavgurevich/makedrive/events","assignees_url":"https://api.github.com/repos/yoavgurevich/makedrive/assignees{/user}","branches_url":"https://api.github.com/repos/yoavgurevich/makedrive/branches{/branch}","tags_url":"https://api.github.com/repos/yoavgurevich/makedrive/tags","blobs_url":"https://api.github.com/repos/yoavgurevich/makedrive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yoavgurevich/makedrive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yoavgurevich/makedrive/git/refs{/sha}","trees_url":"https://api.github.com/repos/yoavgurevich/makedrive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yoavgurevich/makedrive/statuses/{sha}","languages_url":"https://api.github.com/repos/yoavgurevich/makedrive/languages","stargazers_url":"https://api.github.com/repos/yoavgurevich/makedrive/stargazers","contributors_url":"https://api.github.com/repos/yoavgurevich/makedrive/contributors","subscribers_url":"https://api.github.com/repos/yoavgurevich/makedrive/subscribers","subscription_url":"https://api.github.com/repos/yoavgurevich/makedrive/subscription","commits_url":"https://api.github.com/repos/yoavgurevich/makedrive/commits{/sha}","git_commits_url":"https://api.github.com/repos/yoavgurevich/makedrive/git/commits{/sha}","comments_url":"https://api.github.com/repos/yoavgurevich/makedrive/comments{/number}","issue_comment_url":"https://api.github.com/repos/yoavgurevich/makedrive/issues/comments/{number}","contents_url":"https://api.github.com/repos/yoavgurevich/makedrive/contents/{+path}","compare_url":"https://api.github.com/repos/yoavgurevich/makedrive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yoavgurevich/makedrive/merges","archive_url":"https://api.github.com/repos/yoavgurevich/makedrive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yoavgurevich/makedrive/downloads","issues_url":"https://api.github.com/repos/yoavgurevich/makedrive/issues{/number}","pulls_url":"https://api.github.com/repos/yoavgurevich/makedrive/pulls{/number}","milestones_url":"https://api.github.com/repos/yoavgurevich/makedrive/milestones{/number}","notifications_url":"https://api.github.com/repos/yoavgurevich/makedrive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yoavgurevich/makedrive/labels{/name}","releases_url":"https://api.github.com/repos/yoavgurevich/makedrive/releases{/id}","created_at":"2014-06-02T16:03:00Z","updated_at":"2014-06-04T16:39:31Z","pushed_at":"2014-06-04T16:39:31Z","git_url":"git://github.com/yoavgurevich/makedrive.git","ssh_url":"git@github.com:yoavgurevich/makedrive.git","clone_url":"https://github.com/yoavgurevich/makedrive.git","svn_url":"https://github.com/yoavgurevich/makedrive","homepage":null,"size":371,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yoavgurevich/makedrive/pulls/1"},"html":{"href":"https://github.com/yoavgurevich/makedrive/pull/1"},"issue":{"href":"https://api.github.com/repos/yoavgurevich/makedrive/issues/1"},"comments":{"href":"https://api.github.com/repos/yoavgurevich/makedrive/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/yoavgurevich/makedrive/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/yoavgurevich/makedrive/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/yoavgurevich/makedrive/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/yoavgurevich/makedrive/statuses/176861e65f386aff6a32a92cdf58d51c169162e0"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"yoavgurevich","id":2465960,"avatar_url":"https://avatars.githubusercontent.com/u/2465960?","gravatar_id":"a35a701eef438f322b826a1d5de7f85b","url":"https://api.github.com/users/yoavgurevich","html_url":"https://github.com/yoavgurevich","followers_url":"https://api.github.com/users/yoavgurevich/followers","following_url":"https://api.github.com/users/yoavgurevich/following{/other_user}","gists_url":"https://api.github.com/users/yoavgurevich/gists{/gist_id}","starred_url":"https://api.github.com/users/yoavgurevich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yoavgurevich/subscriptions","organizations_url":"https://api.github.com/users/yoavgurevich/orgs","repos_url":"https://api.github.com/users/yoavgurevich/repos","events_url":"https://api.github.com/users/yoavgurevich/events{/privacy}","received_events_url":"https://api.github.com/users/yoavgurevich/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":4,"additions":270,"deletions":2,"changed_files":5}}