GitHub PullRequestReviewCommentEvent at 2014-10-15 17:00:11
Repository: knife-windows
Actor: btm
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/opscode/knife-windows/pulls/comments/18906748","id":18906748,"diff_hunk":"@@ -171,7 +171,10 @@ def session_from_list(list)\n           session_opts[:operation_timeout] = 1800 # 30 min OperationTimeout for long bootstraps fix for KNIFE_WINDOWS-8\n \n           ## If you have a \\\\ in your name you need to use NTLM domain authentication\n-          if session_opts[:user].split(\"\\\\\").length.eql?(2)\n+          username_components = session_opts[:user].split(\"\\\\\")\n+          is_ntlm_auth = username_components.length.eql?(2)","path":"lib/chef/knife/winrm.rb","position":29,"original_position":29,"commit_id":"85aa4bcae760b98e2ff76d743e8c6c0d49fc64ca","original_commit_id":"85aa4bcae760b98e2ff76d743e8c6c0d49fc64ca","user":{"login":"btm","id":4381,"avatar_url":"https://avatars.githubusercontent.com/u/4381?v=2","gravatar_id":"","url":"https://api.github.com/users/btm","html_url":"https://github.com/btm","followers_url":"https://api.github.com/users/btm/followers","following_url":"https://api.github.com/users/btm/following{/other_user}","gists_url":"https://api.github.com/users/btm/gists{/gist_id}","starred_url":"https://api.github.com/users/btm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btm/subscriptions","organizations_url":"https://api.github.com/users/btm/orgs","repos_url":"https://api.github.com/users/btm/repos","events_url":"https://api.github.com/users/btm/events{/privacy}","received_events_url":"https://api.github.com/users/btm/received_events","type":"User","site_admin":false},"body":"Are we actually checking to see if we need to use ntlm auth because we have both a domain and user? Can we name this `username_contains_domain?` and then below something like\r\n\r\n```\r\n           if username_contains_domain?\r\n             # We cannot use basic_auth for domain authentication\r\n             session_opts[:basic_auth_only] = false\r\n           else\r\n             session_opts[:basic_auth_only] = true\r\n```","created_at":"2014-10-15T17:00:11Z","updated_at":"2014-10-15T17:00:11Z","html_url":"https://github.com/opscode/knife-windows/pull/109#discussion_r18906748","pull_request_url":"https://api.github.com/repos/opscode/knife-windows/pulls/109","_links":{"self":{"href":"https://api.github.com/repos/opscode/knife-windows/pulls/comments/18906748"},"html":{"href":"https://github.com/opscode/knife-windows/pull/109#discussion_r18906748"},"pull_request":{"href":"https://api.github.com/repos/opscode/knife-windows/pulls/109"}}},"pull_request":{"url":"https://api.github.com/repos/opscode/knife-windows/pulls/109","id":22654678,"html_url":"https://github.com/opscode/knife-windows/pull/109","diff_url":"https://github.com/opscode/knife-windows/pull/109.diff","patch_url":"https://github.com/opscode/knife-windows/pull/109.patch","issue_url":"https://api.github.com/repos/opscode/knife-windows/issues/109","number":109,"state":"open","locked":false,"title":"[#108] \"Error: Unencrypted communication not supported\" with 0.8.0 and winrm #108","user":{"login":"prabhu-das","id":3692131,"avatar_url":"https://avatars.githubusercontent.com/u/3692131?v=2","gravatar_id":"","url":"https://api.github.com/users/prabhu-das","html_url":"https://github.com/prabhu-das","followers_url":"https://api.github.com/users/prabhu-das/followers","following_url":"https://api.github.com/users/prabhu-das/following{/other_user}","gists_url":"https://api.github.com/users/prabhu-das/gists{/gist_id}","starred_url":"https://api.github.com/users/prabhu-das/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prabhu-das/subscriptions","organizations_url":"https://api.github.com/users/prabhu-das/orgs","repos_url":"https://api.github.com/users/prabhu-das/repos","events_url":"https://api.github.com/users/prabhu-das/events{/privacy}","received_events_url":"https://api.github.com/users/prabhu-das/received_events","type":"User","site_admin":false},"body":"@adamedx  @muktaa \r\nIt includes:\r\n1> I've added changes to fix https://github.com/opscode/knife-windows/issues/108 issue.\r\n2> @siddheshwar-more has fixed bug related to winrm session exit code\r\n","created_at":"2014-10-13T16:00:45Z","updated_at":"2014-10-15T17:00:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"76efe81a8d3788630eebc3e44587da16b59a17c8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/opscode/knife-windows/pulls/109/commits","review_comments_url":"https://api.github.com/repos/opscode/knife-windows/pulls/109/comments","review_comment_url":"https://api.github.com/repos/opscode/knife-windows/pulls/comments/{number}","comments_url":"https://api.github.com/repos/opscode/knife-windows/issues/109/comments","statuses_url":"https://api.github.com/repos/opscode/knife-windows/statuses/85aa4bcae760b98e2ff76d743e8c6c0d49fc64ca","head":{"label":"ClogenyTechnologies:pd/fix-winrms-basic-auth-issue","ref":"pd/fix-winrms-basic-auth-issue","sha":"85aa4bcae760b98e2ff76d743e8c6c0d49fc64ca","user":{"login":"ClogenyTechnologies","id":2493241,"avatar_url":"https://avatars.githubusercontent.com/u/2493241?v=2","gravatar_id":"","url":"https://api.github.com/users/ClogenyTechnologies","html_url":"https://github.com/ClogenyTechnologies","followers_url":"https://api.github.com/users/ClogenyTechnologies/followers","following_url":"https://api.github.com/users/ClogenyTechnologies/following{/other_user}","gists_url":"https://api.github.com/users/ClogenyTechnologies/gists{/gist_id}","starred_url":"https://api.github.com/users/ClogenyTechnologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ClogenyTechnologies/subscriptions","organizations_url":"https://api.github.com/users/ClogenyTechnologies/orgs","repos_url":"https://api.github.com/users/ClogenyTechnologies/repos","events_url":"https://api.github.com/users/ClogenyTechnologies/events{/privacy}","received_events_url":"https://api.github.com/users/ClogenyTechnologies/received_events","type":"Organization","site_admin":false},"repo":{"id":11443488,"name":"knife-windows","full_name":"ClogenyTechnologies/knife-windows","owner":{"login":"ClogenyTechnologies","id":2493241,"avatar_url":"https://avatars.githubusercontent.com/u/2493241?v=2","gravatar_id":"","url":"https://api.github.com/users/ClogenyTechnologies","html_url":"https://github.com/ClogenyTechnologies","followers_url":"https://api.github.com/users/ClogenyTechnologies/followers","following_url":"https://api.github.com/users/ClogenyTechnologies/following{/other_user}","gists_url":"https://api.github.com/users/ClogenyTechnologies/gists{/gist_id}","starred_url":"https://api.github.com/users/ClogenyTechnologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ClogenyTechnologies/subscriptions","organizations_url":"https://api.github.com/users/ClogenyTechnologies/orgs","repos_url":"https://api.github.com/users/ClogenyTechnologies/repos","events_url":"https://api.github.com/users/ClogenyTechnologies/events{/privacy}","received_events_url":"https://api.github.com/users/ClogenyTechnologies/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ClogenyTechnologies/knife-windows","description":"Plugin for Chef's knife tool for working with Windows nodes","fork":true,"url":"https://api.github.com/repos/ClogenyTechnologies/knife-windows","forks_url":"https://api.github.com/repos/ClogenyTechnologies/knife-windows/forks","keys_url":"https://api.github.com/repos/ClogenyTechnologies/knife-windows/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ClogenyTechnologies/knife-windows/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ClogenyTechnologies/knife-windows/teams","hooks_url":"https://api.github.com/repos/ClogenyTechnologies/knife-windows/hooks","issue_events_url":"https://api.github.com/repos/ClogenyTechnologies/knife-windows/issues/events{/number}","events_url":"https://api.github.com/repos/ClogenyTechnologies/knife-windows/events","assignees_url":"https://api.github.com/repos/ClogenyTechnologies/knife-windows/assignees{/user}","branches_url":"https://api.github.com/repos/ClogenyTechnologies/knife-windows/branches{/branch}","tags_url":"https://api.github.com/repos/ClogenyTechnologies/knife-windows/tags","blobs_url":"https://api.github.com/repos/ClogenyTechnologies/knife-windows/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ClogenyTechnologies/knife-windows/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ClogenyTechnologies/knife-windows/git/refs{/sha}","trees_url":"https://api.github.com/repos/ClogenyTechnologies/knife-windows/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ClogenyTechnologies/knife-windows/statuses/{sha}","languages_url":"https://api.github.com/repos/ClogenyTechnologies/knife-windows/languages","stargazers_url":"https://api.github.com/repos/ClogenyTechnologies/knife-windows/stargazers","contributors_url":"https://api.github.com/repos/ClogenyTechnologies/knife-windows/contributors","subscribers_url":"https://api.github.com/repos/ClogenyTechnologies/knife-windows/subscribers","subscription_url":"https://api.github.com/repos/ClogenyTechnologies/knife-windows/subscription","commits_url":"https://api.github.com/repos/ClogenyTechnologies/knife-windows/commits{/sha}","git_commits_url":"https://api.github.com/repos/ClogenyTechnologies/knife-windows/git/commits{/sha}","comments_url":"https://api.github.com/repos/ClogenyTechnologies/knife-windows/comments{/number}","issue_comment_url":"https://api.github.com/repos/ClogenyTechnologies/knife-windows/issues/comments/{number}","contents_url":"https://api.github.com/repos/ClogenyTechnologies/knife-windows/contents/{+path}","compare_url":"https://api.github.com/repos/ClogenyTechnologies/knife-windows/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ClogenyTechnologies/knife-windows/merges","archive_url":"https://api.github.com/repos/ClogenyTechnologies/knife-windows/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ClogenyTechnologies/knife-windows/downloads","issues_url":"https://api.github.com/repos/ClogenyTechnologies/knife-windows/issues{/number}","pulls_url":"https://api.github.com/repos/ClogenyTechnologies/knife-windows/pulls{/number}","milestones_url":"https://api.github.com/repos/ClogenyTechnologies/knife-windows/milestones{/number}","notifications_url":"https://api.github.com/repos/ClogenyTechnologies/knife-windows/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ClogenyTechnologies/knife-windows/labels{/name}","releases_url":"https://api.github.com/repos/ClogenyTechnologies/knife-windows/releases{/id}","created_at":"2013-07-16T07:31:59Z","updated_at":"2014-07-25T12:12:58Z","pushed_at":"2014-10-15T16:20:20Z","git_url":"git://github.com/ClogenyTechnologies/knife-windows.git","ssh_url":"git@github.com:ClogenyTechnologies/knife-windows.git","clone_url":"https://github.com/ClogenyTechnologies/knife-windows.git","svn_url":"https://github.com/ClogenyTechnologies/knife-windows","homepage":"http://tickets.opscode.com/browse/KNIFE_WINDOWS","size":1062,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"opscode:master","ref":"master","sha":"4dd96cd1caafd88bb0fa588ddc953600bd05c6e0","user":{"login":"opscode","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=2","gravatar_id":"","url":"https://api.github.com/users/opscode","html_url":"https://github.com/opscode","followers_url":"https://api.github.com/users/opscode/followers","following_url":"https://api.github.com/users/opscode/following{/other_user}","gists_url":"https://api.github.com/users/opscode/gists{/gist_id}","starred_url":"https://api.github.com/users/opscode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opscode/subscriptions","organizations_url":"https://api.github.com/users/opscode/orgs","repos_url":"https://api.github.com/users/opscode/repos","events_url":"https://api.github.com/users/opscode/events{/privacy}","received_events_url":"https://api.github.com/users/opscode/received_events","type":"Organization","site_admin":false},"repo":{"id":1440272,"name":"knife-windows","full_name":"opscode/knife-windows","owner":{"login":"opscode","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=2","gravatar_id":"","url":"https://api.github.com/users/opscode","html_url":"https://github.com/opscode","followers_url":"https://api.github.com/users/opscode/followers","following_url":"https://api.github.com/users/opscode/following{/other_user}","gists_url":"https://api.github.com/users/opscode/gists{/gist_id}","starred_url":"https://api.github.com/users/opscode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opscode/subscriptions","organizations_url":"https://api.github.com/users/opscode/orgs","repos_url":"https://api.github.com/users/opscode/repos","events_url":"https://api.github.com/users/opscode/events{/privacy}","received_events_url":"https://api.github.com/users/opscode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opscode/knife-windows","description":"Plugin for Chef's knife tool for working with Windows nodes","fork":false,"url":"https://api.github.com/repos/opscode/knife-windows","forks_url":"https://api.github.com/repos/opscode/knife-windows/forks","keys_url":"https://api.github.com/repos/opscode/knife-windows/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opscode/knife-windows/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opscode/knife-windows/teams","hooks_url":"https://api.github.com/repos/opscode/knife-windows/hooks","issue_events_url":"https://api.github.com/repos/opscode/knife-windows/issues/events{/number}","events_url":"https://api.github.com/repos/opscode/knife-windows/events","assignees_url":"https://api.github.com/repos/opscode/knife-windows/assignees{/user}","branches_url":"https://api.github.com/repos/opscode/knife-windows/branches{/branch}","tags_url":"https://api.github.com/repos/opscode/knife-windows/tags","blobs_url":"https://api.github.com/repos/opscode/knife-windows/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opscode/knife-windows/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opscode/knife-windows/git/refs{/sha}","trees_url":"https://api.github.com/repos/opscode/knife-windows/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opscode/knife-windows/statuses/{sha}","languages_url":"https://api.github.com/repos/opscode/knife-windows/languages","stargazers_url":"https://api.github.com/repos/opscode/knife-windows/stargazers","contributors_url":"https://api.github.com/repos/opscode/knife-windows/contributors","subscribers_url":"https://api.github.com/repos/opscode/knife-windows/subscribers","subscription_url":"https://api.github.com/repos/opscode/knife-windows/subscription","commits_url":"https://api.github.com/repos/opscode/knife-windows/commits{/sha}","git_commits_url":"https://api.github.com/repos/opscode/knife-windows/git/commits{/sha}","comments_url":"https://api.github.com/repos/opscode/knife-windows/comments{/number}","issue_comment_url":"https://api.github.com/repos/opscode/knife-windows/issues/comments/{number}","contents_url":"https://api.github.com/repos/opscode/knife-windows/contents/{+path}","compare_url":"https://api.github.com/repos/opscode/knife-windows/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opscode/knife-windows/merges","archive_url":"https://api.github.com/repos/opscode/knife-windows/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opscode/knife-windows/downloads","issues_url":"https://api.github.com/repos/opscode/knife-windows/issues{/number}","pulls_url":"https://api.github.com/repos/opscode/knife-windows/pulls{/number}","milestones_url":"https://api.github.com/repos/opscode/knife-windows/milestones{/number}","notifications_url":"https://api.github.com/repos/opscode/knife-windows/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opscode/knife-windows/labels{/name}","releases_url":"https://api.github.com/repos/opscode/knife-windows/releases{/id}","created_at":"2011-03-04T17:30:51Z","updated_at":"2014-10-09T15:31:22Z","pushed_at":"2014-10-07T04:30:35Z","git_url":"git://github.com/opscode/knife-windows.git","ssh_url":"git@github.com:opscode/knife-windows.git","clone_url":"https://github.com/opscode/knife-windows.git","svn_url":"https://github.com/opscode/knife-windows","homepage":"http://tickets.opscode.com/browse/knife","size":1657,"stargazers_count":89,"watchers_count":89,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":79,"mirror_url":null,"open_issues_count":18,"forks":79,"open_issues":18,"watchers":89,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opscode/knife-windows/pulls/109"},"html":{"href":"https://github.com/opscode/knife-windows/pull/109"},"issue":{"href":"https://api.github.com/repos/opscode/knife-windows/issues/109"},"comments":{"href":"https://api.github.com/repos/opscode/knife-windows/issues/109/comments"},"review_comments":{"href":"https://api.github.com/repos/opscode/knife-windows/pulls/109/comments"},"review_comment":{"href":"https://api.github.com/repos/opscode/knife-windows/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/opscode/knife-windows/pulls/109/commits"},"statuses":{"href":"https://api.github.com/repos/opscode/knife-windows/statuses/85aa4bcae760b98e2ff76d743e8c6c0d49fc64ca"}}}}