GitHub PullRequestEvent at 2014-06-14 07:08:15
Repository: wesnoth
Actor: Rift-Walker
Payload: {"action":"opened","number":203,"pull_request":{"url":"https://api.github.com/repos/wesnoth/wesnoth/pulls/203","id":17140981,"html_url":"https://github.com/wesnoth/wesnoth/pull/203","diff_url":"https://github.com/wesnoth/wesnoth/pull/203.diff","patch_url":"https://github.com/wesnoth/wesnoth/pull/203.patch","issue_url":"https://api.github.com/repos/wesnoth/wesnoth/issues/203","number":203,"state":"open","title":"Add define functionality to scenarios, eras, and mods","user":{"login":"Rift-Walker","id":7005772,"avatar_url":"https://avatars.githubusercontent.com/u/7005772?","gravatar_id":"43a73b49aa51fb8d1f87c20adb597b3b","url":"https://api.github.com/users/Rift-Walker","html_url":"https://github.com/Rift-Walker","followers_url":"https://api.github.com/users/Rift-Walker/followers","following_url":"https://api.github.com/users/Rift-Walker/following{/other_user}","gists_url":"https://api.github.com/users/Rift-Walker/gists{/gist_id}","starred_url":"https://api.github.com/users/Rift-Walker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rift-Walker/subscriptions","organizations_url":"https://api.github.com/users/Rift-Walker/orgs","repos_url":"https://api.github.com/users/Rift-Walker/repos","events_url":"https://api.github.com/users/Rift-Walker/events{/privacy}","received_events_url":"https://api.github.com/users/Rift-Walker/received_events","type":"User","site_admin":false},"body":"This pull request extends the define= system, currently used in campaigns, to multiplayer scenarios, eras, and mods. The system is intended to defer loading sections of config until they are required (when a level is selected). As a result, less config is loaded at mp_create, and less unnecessary config is floating around, taking up memory and namespace in multiplayer.\r\nIn order for this system to be effective, UMC devs will have to edit their code to utilize it. As a rule, toplevel attributes and [side] tags should be outside of #ifdefs, while everything else should be inside. Child tags of [side] should also be inside of an #ifdef.\r\nHere I have already edited all the scenarios and eras in data/multiplayer/ to use the system.","created_at":"2014-06-14T07:08:15Z","updated_at":"2014-06-14T07:08:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wesnoth/wesnoth/pulls/203/commits","review_comments_url":"https://api.github.com/repos/wesnoth/wesnoth/pulls/203/comments","review_comment_url":"https://api.github.com/repos/wesnoth/wesnoth/pulls/comments/{number}","comments_url":"https://api.github.com/repos/wesnoth/wesnoth/issues/203/comments","statuses_url":"https://api.github.com/repos/wesnoth/wesnoth/statuses/1c04d9c1418cf9c6eec060ce9de3f22388e72817","head":{"label":"Rift-Walker:scenario_era_mod_defines","ref":"scenario_era_mod_defines","sha":"1c04d9c1418cf9c6eec060ce9de3f22388e72817","user":{"login":"Rift-Walker","id":7005772,"avatar_url":"https://avatars.githubusercontent.com/u/7005772?","gravatar_id":"43a73b49aa51fb8d1f87c20adb597b3b","url":"https://api.github.com/users/Rift-Walker","html_url":"https://github.com/Rift-Walker","followers_url":"https://api.github.com/users/Rift-Walker/followers","following_url":"https://api.github.com/users/Rift-Walker/following{/other_user}","gists_url":"https://api.github.com/users/Rift-Walker/gists{/gist_id}","starred_url":"https://api.github.com/users/Rift-Walker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rift-Walker/subscriptions","organizations_url":"https://api.github.com/users/Rift-Walker/orgs","repos_url":"https://api.github.com/users/Rift-Walker/repos","events_url":"https://api.github.com/users/Rift-Walker/events{/privacy}","received_events_url":"https://api.github.com/users/Rift-Walker/received_events","type":"User","site_admin":false},"repo":{"id":17927046,"name":"wesnoth","full_name":"Rift-Walker/wesnoth","owner":{"login":"Rift-Walker","id":7005772,"avatar_url":"https://avatars.githubusercontent.com/u/7005772?","gravatar_id":"43a73b49aa51fb8d1f87c20adb597b3b","url":"https://api.github.com/users/Rift-Walker","html_url":"https://github.com/Rift-Walker","followers_url":"https://api.github.com/users/Rift-Walker/followers","following_url":"https://api.github.com/users/Rift-Walker/following{/other_user}","gists_url":"https://api.github.com/users/Rift-Walker/gists{/gist_id}","starred_url":"https://api.github.com/users/Rift-Walker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rift-Walker/subscriptions","organizations_url":"https://api.github.com/users/Rift-Walker/orgs","repos_url":"https://api.github.com/users/Rift-Walker/repos","events_url":"https://api.github.com/users/Rift-Walker/events{/privacy}","received_events_url":"https://api.github.com/users/Rift-Walker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Rift-Walker/wesnoth","description":"Free, turn-based strategy game with a high fantasy theme, featuring both single-player, and online/hotseat multiplayer combat.","fork":true,"url":"https://api.github.com/repos/Rift-Walker/wesnoth","forks_url":"https://api.github.com/repos/Rift-Walker/wesnoth/forks","keys_url":"https://api.github.com/repos/Rift-Walker/wesnoth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Rift-Walker/wesnoth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Rift-Walker/wesnoth/teams","hooks_url":"https://api.github.com/repos/Rift-Walker/wesnoth/hooks","issue_events_url":"https://api.github.com/repos/Rift-Walker/wesnoth/issues/events{/number}","events_url":"https://api.github.com/repos/Rift-Walker/wesnoth/events","assignees_url":"https://api.github.com/repos/Rift-Walker/wesnoth/assignees{/user}","branches_url":"https://api.github.com/repos/Rift-Walker/wesnoth/branches{/branch}","tags_url":"https://api.github.com/repos/Rift-Walker/wesnoth/tags","blobs_url":"https://api.github.com/repos/Rift-Walker/wesnoth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Rift-Walker/wesnoth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Rift-Walker/wesnoth/git/refs{/sha}","trees_url":"https://api.github.com/repos/Rift-Walker/wesnoth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Rift-Walker/wesnoth/statuses/{sha}","languages_url":"https://api.github.com/repos/Rift-Walker/wesnoth/languages","stargazers_url":"https://api.github.com/repos/Rift-Walker/wesnoth/stargazers","contributors_url":"https://api.github.com/repos/Rift-Walker/wesnoth/contributors","subscribers_url":"https://api.github.com/repos/Rift-Walker/wesnoth/subscribers","subscription_url":"https://api.github.com/repos/Rift-Walker/wesnoth/subscription","commits_url":"https://api.github.com/repos/Rift-Walker/wesnoth/commits{/sha}","git_commits_url":"https://api.github.com/repos/Rift-Walker/wesnoth/git/commits{/sha}","comments_url":"https://api.github.com/repos/Rift-Walker/wesnoth/comments{/number}","issue_comment_url":"https://api.github.com/repos/Rift-Walker/wesnoth/issues/comments/{number}","contents_url":"https://api.github.com/repos/Rift-Walker/wesnoth/contents/{+path}","compare_url":"https://api.github.com/repos/Rift-Walker/wesnoth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Rift-Walker/wesnoth/merges","archive_url":"https://api.github.com/repos/Rift-Walker/wesnoth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Rift-Walker/wesnoth/downloads","issues_url":"https://api.github.com/repos/Rift-Walker/wesnoth/issues{/number}","pulls_url":"https://api.github.com/repos/Rift-Walker/wesnoth/pulls{/number}","milestones_url":"https://api.github.com/repos/Rift-Walker/wesnoth/milestones{/number}","notifications_url":"https://api.github.com/repos/Rift-Walker/wesnoth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Rift-Walker/wesnoth/labels{/name}","releases_url":"https://api.github.com/repos/Rift-Walker/wesnoth/releases{/id}","created_at":"2014-03-20T01:40:50Z","updated_at":"2014-06-14T07:08:15Z","pushed_at":"2014-06-14T06:36:11Z","git_url":"git://github.com/Rift-Walker/wesnoth.git","ssh_url":"git@github.com:Rift-Walker/wesnoth.git","clone_url":"https://github.com/Rift-Walker/wesnoth.git","svn_url":"https://github.com/Rift-Walker/wesnoth","homepage":"http://www.wesnoth.org/","size":1900331,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"wesnoth:master","ref":"master","sha":"65570f5cb9e92f73a96d76c48654511dc1860b00","user":{"login":"wesnoth","id":4024232,"avatar_url":"https://avatars.githubusercontent.com/u/4024232?","gravatar_id":"ec74329b1e3b5a5eec4ea3adad4cfca4","url":"https://api.github.com/users/wesnoth","html_url":"https://github.com/wesnoth","followers_url":"https://api.github.com/users/wesnoth/followers","following_url":"https://api.github.com/users/wesnoth/following{/other_user}","gists_url":"https://api.github.com/users/wesnoth/gists{/gist_id}","starred_url":"https://api.github.com/users/wesnoth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesnoth/subscriptions","organizations_url":"https://api.github.com/users/wesnoth/orgs","repos_url":"https://api.github.com/users/wesnoth/repos","events_url":"https://api.github.com/users/wesnoth/events{/privacy}","received_events_url":"https://api.github.com/users/wesnoth/received_events","type":"Organization","site_admin":false},"repo":{"id":9432220,"name":"wesnoth","full_name":"wesnoth/wesnoth","owner":{"login":"wesnoth","id":4024232,"avatar_url":"https://avatars.githubusercontent.com/u/4024232?","gravatar_id":"ec74329b1e3b5a5eec4ea3adad4cfca4","url":"https://api.github.com/users/wesnoth","html_url":"https://github.com/wesnoth","followers_url":"https://api.github.com/users/wesnoth/followers","following_url":"https://api.github.com/users/wesnoth/following{/other_user}","gists_url":"https://api.github.com/users/wesnoth/gists{/gist_id}","starred_url":"https://api.github.com/users/wesnoth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesnoth/subscriptions","organizations_url":"https://api.github.com/users/wesnoth/orgs","repos_url":"https://api.github.com/users/wesnoth/repos","events_url":"https://api.github.com/users/wesnoth/events{/privacy}","received_events_url":"https://api.github.com/users/wesnoth/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wesnoth/wesnoth","description":"Free, turn-based strategy game with a high fantasy theme, featuring both single-player, and online/hotseat multiplayer combat.","fork":false,"url":"https://api.github.com/repos/wesnoth/wesnoth","forks_url":"https://api.github.com/repos/wesnoth/wesnoth/forks","keys_url":"https://api.github.com/repos/wesnoth/wesnoth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wesnoth/wesnoth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wesnoth/wesnoth/teams","hooks_url":"https://api.github.com/repos/wesnoth/wesnoth/hooks","issue_events_url":"https://api.github.com/repos/wesnoth/wesnoth/issues/events{/number}","events_url":"https://api.github.com/repos/wesnoth/wesnoth/events","assignees_url":"https://api.github.com/repos/wesnoth/wesnoth/assignees{/user}","branches_url":"https://api.github.com/repos/wesnoth/wesnoth/branches{/branch}","tags_url":"https://api.github.com/repos/wesnoth/wesnoth/tags","blobs_url":"https://api.github.com/repos/wesnoth/wesnoth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wesnoth/wesnoth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wesnoth/wesnoth/git/refs{/sha}","trees_url":"https://api.github.com/repos/wesnoth/wesnoth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wesnoth/wesnoth/statuses/{sha}","languages_url":"https://api.github.com/repos/wesnoth/wesnoth/languages","stargazers_url":"https://api.github.com/repos/wesnoth/wesnoth/stargazers","contributors_url":"https://api.github.com/repos/wesnoth/wesnoth/contributors","subscribers_url":"https://api.github.com/repos/wesnoth/wesnoth/subscribers","subscription_url":"https://api.github.com/repos/wesnoth/wesnoth/subscription","commits_url":"https://api.github.com/repos/wesnoth/wesnoth/commits{/sha}","git_commits_url":"https://api.github.com/repos/wesnoth/wesnoth/git/commits{/sha}","comments_url":"https://api.github.com/repos/wesnoth/wesnoth/comments{/number}","issue_comment_url":"https://api.github.com/repos/wesnoth/wesnoth/issues/comments/{number}","contents_url":"https://api.github.com/repos/wesnoth/wesnoth/contents/{+path}","compare_url":"https://api.github.com/repos/wesnoth/wesnoth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wesnoth/wesnoth/merges","archive_url":"https://api.github.com/repos/wesnoth/wesnoth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wesnoth/wesnoth/downloads","issues_url":"https://api.github.com/repos/wesnoth/wesnoth/issues{/number}","pulls_url":"https://api.github.com/repos/wesnoth/wesnoth/pulls{/number}","milestones_url":"https://api.github.com/repos/wesnoth/wesnoth/milestones{/number}","notifications_url":"https://api.github.com/repos/wesnoth/wesnoth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wesnoth/wesnoth/labels{/name}","releases_url":"https://api.github.com/repos/wesnoth/wesnoth/releases{/id}","created_at":"2013-04-14T17:13:06Z","updated_at":"2014-06-14T05:17:36Z","pushed_at":"2014-06-14T05:17:39Z","git_url":"git://github.com/wesnoth/wesnoth.git","ssh_url":"git@github.com:wesnoth/wesnoth.git","clone_url":"https://github.com/wesnoth/wesnoth.git","svn_url":"https://github.com/wesnoth/wesnoth","homepage":"http://www.wesnoth.org/","size":2072091,"stargazers_count":308,"watchers_count":308,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":93,"mirror_url":null,"open_issues_count":11,"forks":93,"open_issues":11,"watchers":308,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wesnoth/wesnoth/pulls/203"},"html":{"href":"https://github.com/wesnoth/wesnoth/pull/203"},"issue":{"href":"https://api.github.com/repos/wesnoth/wesnoth/issues/203"},"comments":{"href":"https://api.github.com/repos/wesnoth/wesnoth/issues/203/comments"},"review_comments":{"href":"https://api.github.com/repos/wesnoth/wesnoth/pulls/203/comments"},"review_comment":{"href":"https://api.github.com/repos/wesnoth/wesnoth/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/wesnoth/wesnoth/pulls/203/commits"},"statuses":{"href":"https://api.github.com/repos/wesnoth/wesnoth/statuses/1c04d9c1418cf9c6eec060ce9de3f22388e72817"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":314,"deletions":17,"changed_files":59}}