GitHub PullRequestReviewCommentEvent at 2014-05-05 20:48:44
Repository: admin-ui
Actor: jackfengibm
Payload: {"comment":{"url":"https://api.github.com/repos/cloudfoundry-incubator/admin-ui/pulls/comments/12298895","id":12298895,"diff_hunk":"@@ -128,6 +128,48 @@\n         expect(config.stats_refresh_time).to eq(stats_refresh_time)\n       end\n \n+      it 'stats_refresh_time with mix use of range and sequence' do","path":"spec/unit/config_spec.rb","position":4,"original_position":4,"commit_id":"57fc2002b9a9440386dab34e6239dfc4ab7f9cae","original_commit_id":"57fc2002b9a9440386dab34e6239dfc4ab7f9cae","user":{"login":"jackfengibm","id":5741623,"avatar_url":"https://avatars.githubusercontent.com/u/5741623?","gravatar_id":"37d0bd3ddf0c72a6ea5c199839583c66","url":"https://api.github.com/users/jackfengibm","html_url":"https://github.com/jackfengibm","followers_url":"https://api.github.com/users/jackfengibm/followers","following_url":"https://api.github.com/users/jackfengibm/following{/other_user}","gists_url":"https://api.github.com/users/jackfengibm/gists{/gist_id}","starred_url":"https://api.github.com/users/jackfengibm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackfengibm/subscriptions","organizations_url":"https://api.github.com/users/jackfengibm/orgs","repos_url":"https://api.github.com/users/jackfengibm/repos","events_url":"https://api.github.com/users/jackfengibm/events{/privacy}","received_events_url":"https://api.github.com/users/jackfengibm/received_events","type":"User","site_admin":false},"body":"Negative test cases are located around line 473 to 489 of conf_spec.rb.  \r\n\r\nIn response to your comments, I also added checks for error messages in test cases and a test case for scenario in which both stats_refresh_time and stats_refresh_schedules are not set.","created_at":"2014-05-05T20:48:44Z","updated_at":"2014-05-05T20:48:44Z","html_url":"https://github.com/cloudfoundry-incubator/admin-ui/pull/63#discussion_r12298895","pull_request_url":"https://api.github.com/repos/cloudfoundry-incubator/admin-ui/pulls/63","_links":{"self":{"href":"https://api.github.com/repos/cloudfoundry-incubator/admin-ui/pulls/comments/12298895"},"html":{"href":"https://github.com/cloudfoundry-incubator/admin-ui/pull/63#discussion_r12298895"},"pull_request":{"href":"https://api.github.com/repos/cloudfoundry-incubator/admin-ui/pulls/63"}}}}