GitHub PullRequestReviewCommentEvent at 2014-07-03 07:51:34
Repository: ruby-china
Actor: houndci
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/ruby-china/ruby-china/pulls/comments/14500942","id":14500942,"diff_hunk":"@@ -19,118 +19,134 @@\n     end\n \n     it \"should match complex urls\" do\n-      helper.format_topic_body(\"http://movie.douban.com/tag/%E7%BE%8E%E5%9B%BD\").should ==\n+      expect(helper.format_topic_body(\"http://movie.douban.com/tag/%E7%BE%8E%E5%9B%BD\")).to eq(\n         '<p><a href=\"http://movie.douban.com/tag/%E7%BE%8E%E5%9B%BD\" rel=\"nofollow\" target=\"_blank\">http://movie.douban.com/tag/%E7%BE%8E%E5%9B%BD</a></p>'\n-      helper.format_topic_body(\"http://ruby-china.org/self_posts/11?datas=20,33|100&format=.jpg\").should ==\n+      )\n+      expect(helper.format_topic_body(\"http://ruby-china.org/self_posts/11?datas=20,33|100&format=.jpg\")).to eq(\n         '<p><a href=\"http://ruby-china.org/self_posts/11?datas=20,33%7C100&amp;format=.jpg\" rel=\"nofollow\" target=\"_blank\">http://ruby-china.org/self_posts/11?datas=20,33|100&amp;format=.jpg</a></p>'\n-      helper.format_topic_body(\"https://g.l/b/?fromgroups#!searchin/gitlabhq/self$20regist/gitlabhq/5ha_FyX-Pr4/VNZTPnSN0S4J\").should ==\n+      )\n+      expect(helper.format_topic_body(\"https://g.l/b/?fromgroups#!searchin/gitlabhq/self$20regist/gitlabhq/5ha_FyX-Pr4/VNZTPnSN0S4J\")).to eq(\n         '<p><a href=\"https://g.l/b/?fromgroups#!searchin/gitlabhq/self%2420regist/gitlabhq/5ha_FyX-Pr4/VNZTPnSN0S4J\" rel=\"nofollow\" target=\"_blank\">https://g.l/b/?fromgroups#!searchin/gitlabhq/self$20regist/gitlabhq/5ha_FyX-Pr4/VNZTPnSN0S4J</a></p>'\n+      )\n     end\n \n     it \"should bold text \" do\n-      helper.format_topic_body(\"**bold**\").should == '<p><strong>bold</strong></p>'\n+      expect(helper.format_topic_body(\"**bold**\")).to eq('<p><strong>bold</strong></p>')\n     end\n \n     it \"should italic text\" do\n-      helper.format_topic_body(\"*italic*\").should == '<p><em>italic</em></p>'\n+      expect(helper.format_topic_body(\"*italic*\")).to eq('<p><em>italic</em></p>')\n     end\n \n     it \"should strikethrough text\" do\n-      helper.format_topic_body(\"~~strikethrough~~\").should == '<p><del>strikethrough</del></p>'\n+      expect(helper.format_topic_body(\"~~strikethrough~~\")).to eq('<p><del>strikethrough</del></p>')\n     end\n \n     it \"should auto link\" do\n-      helper.format_topic_body(\"this is a link: http://ruby-china.org test\").should  ==\n+      expect(helper.format_topic_body(\"this is a link: http://ruby-china.org test\")).to  eq(\n         '<p>this is a link: <a href=\"http://ruby-china.org\" rel=\"nofollow\" target=\"_blank\">http://ruby-china.org</a> test</p>'\n+      )\n     end\n     \n     it \"should auto link\" do\n-      helper.format_topic_body(\"http://ruby-china.org/~users\").should  ==\n+      expect(helper.format_topic_body(\"http://ruby-china.org/~users\")).to  eq(\n         '<p><a href=\"http://ruby-china.org/~users\" rel=\"nofollow\" target=\"_blank\">http://ruby-china.org/~users</a></p>'\n+      )\n     end\n \n     it \"should auto link with Chinese\" do\n-      helper.format_topic_body(\"靠着中文http://foo.com，\").should  ==\n+      expect(helper.format_topic_body(\"靠着中文http://foo.com，\")).to  eq(\n         \"<p>靠着中文<a href=\\\"http://foo.com\\\" rel=\\\"nofollow\\\" target=\\\"_blank\\\">http://foo.com</a>，</p>\"\n+      )\n     end\n \n     it \"should render bbcode style image tag\" do\n-      helper.format_topic_body(\"[img]http://ruby-china.org/logo.png[/img]\").should ==\n+      expect(helper.format_topic_body(\"[img]http://ruby-china.org/logo.png[/img]\")).to eq(\n         '<p><img src=\"http://ruby-china.org/logo.png\" alt=\"Logo\"></p>'\n+      )\n     end\n \n     it \"should link mentioned user\" do\n       user = Factory(:user)\n-      helper.format_topic_body(\"hello @#{user.name} @b @a @#{user.name}\").should ==\n+      expect(helper.format_topic_body(\"hello @#{user.name} @b @a @#{user.name}\")).to eq(\n       \"<p>hello <a href=\\\"/#{user.name}\\\" class=\\\"at_user\\\" title=\\\"@#{user.name}\\\"><i>@</i>#{user.name}</a> <a href=\\\"/b\\\" class=\\\"at_user\\\" title=\\\"@b\\\"><i>@</i>b</a> <a href=\\\"/a\\\" class=\\\"at_user\\\" title=\\\"@a\\\"><i>@</i>a</a> <a href=\\\"/#{user.name}\\\" class=\\\"at_user\\\" title=\\\"@#{user.name}\\\"><i>@</i>#{user.name}</a></p>\"\n+      )\n     end\n \n     it \"should link mentioned user at first of line\" do\n-      helper.format_topic_body(\"@huacnlee hello @ruby_box\").should == \"<p><a href=\\\"/huacnlee\\\" class=\\\"at_user\\\" title=\\\"@huacnlee\\\"><i>@</i>huacnlee</a> hello <a href=\\\"/ruby_box\\\" class=\\\"at_user\\\" title=\\\"@ruby_box\\\"><i>@</i>ruby_box</a></p>\"\n+      expect(helper.format_topic_body(\"@huacnlee hello @ruby_box\")).to eq(\"<p><a href=\\\"/huacnlee\\\" class=\\\"at_user\\\" title=\\\"@huacnlee\\\"><i>@</i>huacnlee</a> hello <a href=\\\"/ruby_box\\\" class=\\\"at_user\\\" title=\\\"@ruby_box\\\"><i>@</i>ruby_box</a></p>\")","path":"spec/helpers/topics_helper_spec.rb","position":81,"original_position":81,"commit_id":"1eab363496fead4d4b2f1787f209657c010d82fb","original_commit_id":"1eab363496fead4d4b2f1787f209657c010d82fb","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?","gravatar_id":"38d9cefd9971a05bf447f07c6cd332cc","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Line is too long. [251/80]","created_at":"2014-07-03T07:51:34Z","updated_at":"2014-07-03T07:51:34Z","html_url":"https://github.com/ruby-china/ruby-china/pull/323#discussion_r14500942","pull_request_url":"https://api.github.com/repos/ruby-china/ruby-china/pulls/323","_links":{"self":{"href":"https://api.github.com/repos/ruby-china/ruby-china/pulls/comments/14500942"},"html":{"href":"https://github.com/ruby-china/ruby-china/pull/323#discussion_r14500942"},"pull_request":{"href":"https://api.github.com/repos/ruby-china/ruby-china/pulls/323"}}},"pull_request":{"url":"https://api.github.com/repos/ruby-china/ruby-china/pulls/323","id":17929356,"html_url":"https://github.com/ruby-china/ruby-china/pull/323","diff_url":"https://github.com/ruby-china/ruby-china/pull/323.diff","patch_url":"https://github.com/ruby-china/ruby-china/pull/323.patch","issue_url":"https://api.github.com/repos/ruby-china/ruby-china/issues/323","number":323,"state":"open","title":"Migrate to RSpec 3 and eliminate all deprecations","user":{"login":"pmq20","id":13315,"avatar_url":"https://avatars.githubusercontent.com/u/13315?","gravatar_id":"8002c84eb4c18170632f8fb7efb09288","url":"https://api.github.com/users/pmq20","html_url":"https://github.com/pmq20","followers_url":"https://api.github.com/users/pmq20/followers","following_url":"https://api.github.com/users/pmq20/following{/other_user}","gists_url":"https://api.github.com/users/pmq20/gists{/gist_id}","starred_url":"https://api.github.com/users/pmq20/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmq20/subscriptions","organizations_url":"https://api.github.com/users/pmq20/orgs","repos_url":"https://api.github.com/users/pmq20/repos","events_url":"https://api.github.com/users/pmq20/events{/privacy}","received_events_url":"https://api.github.com/users/pmq20/received_events","type":"User","site_admin":false},"body":"* Add RSpec 3.x rails_helper and spec_helper conventions\r\n* Use the `expect` syntax over the old `should` syntax\r\n* Use the `allow` syntax over the old `mock` syntax\r\n* Remove `visit` in controller specs\r\n* Change :example_group filtering\r\n* Change `expect(record).not_to have(1).error_on(:slug)` syntax\r\n* w/ capybara upgraded from `0.2` to `2.3`\r\n* w/ cancan upgraded to `cancancan`\r\n\r\n![2014-07-03 15 12 55](https://cloud.githubusercontent.com/assets/13315/3466599/5b9359c4-0283-11e4-9890-801c01fd32e6.png)","created_at":"2014-07-03T07:26:54Z","updated_at":"2014-07-03T07:51:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e0ff625a7d2a908cfd5de0e39e4d6cc94f374155","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ruby-china/ruby-china/pulls/323/commits","review_comments_url":"https://api.github.com/repos/ruby-china/ruby-china/pulls/323/comments","review_comment_url":"https://api.github.com/repos/ruby-china/ruby-china/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ruby-china/ruby-china/issues/323/comments","statuses_url":"https://api.github.com/repos/ruby-china/ruby-china/statuses/1eab363496fead4d4b2f1787f209657c010d82fb","head":{"label":"pmq20:upgrading_rspec_23","ref":"upgrading_rspec_23","sha":"1eab363496fead4d4b2f1787f209657c010d82fb","user":{"login":"pmq20","id":13315,"avatar_url":"https://avatars.githubusercontent.com/u/13315?","gravatar_id":"8002c84eb4c18170632f8fb7efb09288","url":"https://api.github.com/users/pmq20","html_url":"https://github.com/pmq20","followers_url":"https://api.github.com/users/pmq20/followers","following_url":"https://api.github.com/users/pmq20/following{/other_user}","gists_url":"https://api.github.com/users/pmq20/gists{/gist_id}","starred_url":"https://api.github.com/users/pmq20/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmq20/subscriptions","organizations_url":"https://api.github.com/users/pmq20/orgs","repos_url":"https://api.github.com/users/pmq20/repos","events_url":"https://api.github.com/users/pmq20/events{/privacy}","received_events_url":"https://api.github.com/users/pmq20/received_events","type":"User","site_admin":false},"repo":{"id":18589843,"name":"ruby-china","full_name":"pmq20/ruby-china","owner":{"login":"pmq20","id":13315,"avatar_url":"https://avatars.githubusercontent.com/u/13315?","gravatar_id":"8002c84eb4c18170632f8fb7efb09288","url":"https://api.github.com/users/pmq20","html_url":"https://github.com/pmq20","followers_url":"https://api.github.com/users/pmq20/followers","following_url":"https://api.github.com/users/pmq20/following{/other_user}","gists_url":"https://api.github.com/users/pmq20/gists{/gist_id}","starred_url":"https://api.github.com/users/pmq20/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmq20/subscriptions","organizations_url":"https://api.github.com/users/pmq20/orgs","repos_url":"https://api.github.com/users/pmq20/repos","events_url":"https://api.github.com/users/pmq20/events{/privacy}","received_events_url":"https://api.github.com/users/pmq20/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pmq20/ruby-china","description":"ruby-china.org website source code.","fork":true,"url":"https://api.github.com/repos/pmq20/ruby-china","forks_url":"https://api.github.com/repos/pmq20/ruby-china/forks","keys_url":"https://api.github.com/repos/pmq20/ruby-china/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pmq20/ruby-china/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pmq20/ruby-china/teams","hooks_url":"https://api.github.com/repos/pmq20/ruby-china/hooks","issue_events_url":"https://api.github.com/repos/pmq20/ruby-china/issues/events{/number}","events_url":"https://api.github.com/repos/pmq20/ruby-china/events","assignees_url":"https://api.github.com/repos/pmq20/ruby-china/assignees{/user}","branches_url":"https://api.github.com/repos/pmq20/ruby-china/branches{/branch}","tags_url":"https://api.github.com/repos/pmq20/ruby-china/tags","blobs_url":"https://api.github.com/repos/pmq20/ruby-china/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pmq20/ruby-china/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pmq20/ruby-china/git/refs{/sha}","trees_url":"https://api.github.com/repos/pmq20/ruby-china/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pmq20/ruby-china/statuses/{sha}","languages_url":"https://api.github.com/repos/pmq20/ruby-china/languages","stargazers_url":"https://api.github.com/repos/pmq20/ruby-china/stargazers","contributors_url":"https://api.github.com/repos/pmq20/ruby-china/contributors","subscribers_url":"https://api.github.com/repos/pmq20/ruby-china/subscribers","subscription_url":"https://api.github.com/repos/pmq20/ruby-china/subscription","commits_url":"https://api.github.com/repos/pmq20/ruby-china/commits{/sha}","git_commits_url":"https://api.github.com/repos/pmq20/ruby-china/git/commits{/sha}","comments_url":"https://api.github.com/repos/pmq20/ruby-china/comments{/number}","issue_comment_url":"https://api.github.com/repos/pmq20/ruby-china/issues/comments/{number}","contents_url":"https://api.github.com/repos/pmq20/ruby-china/contents/{+path}","compare_url":"https://api.github.com/repos/pmq20/ruby-china/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pmq20/ruby-china/merges","archive_url":"https://api.github.com/repos/pmq20/ruby-china/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pmq20/ruby-china/downloads","issues_url":"https://api.github.com/repos/pmq20/ruby-china/issues{/number}","pulls_url":"https://api.github.com/repos/pmq20/ruby-china/pulls{/number}","milestones_url":"https://api.github.com/repos/pmq20/ruby-china/milestones{/number}","notifications_url":"https://api.github.com/repos/pmq20/ruby-china/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pmq20/ruby-china/labels{/name}","releases_url":"https://api.github.com/repos/pmq20/ruby-china/releases{/id}","created_at":"2014-04-09T08:03:18Z","updated_at":"2014-07-03T04:28:34Z","pushed_at":"2014-07-03T07:50:11Z","git_url":"git://github.com/pmq20/ruby-china.git","ssh_url":"git@github.com:pmq20/ruby-china.git","clone_url":"https://github.com/pmq20/ruby-china.git","svn_url":"https://github.com/pmq20/ruby-china","homepage":"http://ruby-china.org","size":22732,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ruby-china:master","ref":"master","sha":"e76b14c2de9d173f985b97db83f9a6e3bb1e9788","user":{"login":"ruby-china","id":1331033,"avatar_url":"https://avatars.githubusercontent.com/u/1331033?","gravatar_id":"cb7bc291caac1fc35fc01914f22bab9a","url":"https://api.github.com/users/ruby-china","html_url":"https://github.com/ruby-china","followers_url":"https://api.github.com/users/ruby-china/followers","following_url":"https://api.github.com/users/ruby-china/following{/other_user}","gists_url":"https://api.github.com/users/ruby-china/gists{/gist_id}","starred_url":"https://api.github.com/users/ruby-china/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruby-china/subscriptions","organizations_url":"https://api.github.com/users/ruby-china/orgs","repos_url":"https://api.github.com/users/ruby-china/repos","events_url":"https://api.github.com/users/ruby-china/events{/privacy}","received_events_url":"https://api.github.com/users/ruby-china/received_events","type":"Organization","site_admin":false},"repo":{"id":3842593,"name":"ruby-china","full_name":"ruby-china/ruby-china","owner":{"login":"ruby-china","id":1331033,"avatar_url":"https://avatars.githubusercontent.com/u/1331033?","gravatar_id":"cb7bc291caac1fc35fc01914f22bab9a","url":"https://api.github.com/users/ruby-china","html_url":"https://github.com/ruby-china","followers_url":"https://api.github.com/users/ruby-china/followers","following_url":"https://api.github.com/users/ruby-china/following{/other_user}","gists_url":"https://api.github.com/users/ruby-china/gists{/gist_id}","starred_url":"https://api.github.com/users/ruby-china/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruby-china/subscriptions","organizations_url":"https://api.github.com/users/ruby-china/orgs","repos_url":"https://api.github.com/users/ruby-china/repos","events_url":"https://api.github.com/users/ruby-china/events{/privacy}","received_events_url":"https://api.github.com/users/ruby-china/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ruby-china/ruby-china","description":"ruby-china.org website source code.","fork":true,"url":"https://api.github.com/repos/ruby-china/ruby-china","forks_url":"https://api.github.com/repos/ruby-china/ruby-china/forks","keys_url":"https://api.github.com/repos/ruby-china/ruby-china/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ruby-china/ruby-china/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ruby-china/ruby-china/teams","hooks_url":"https://api.github.com/repos/ruby-china/ruby-china/hooks","issue_events_url":"https://api.github.com/repos/ruby-china/ruby-china/issues/events{/number}","events_url":"https://api.github.com/repos/ruby-china/ruby-china/events","assignees_url":"https://api.github.com/repos/ruby-china/ruby-china/assignees{/user}","branches_url":"https://api.github.com/repos/ruby-china/ruby-china/branches{/branch}","tags_url":"https://api.github.com/repos/ruby-china/ruby-china/tags","blobs_url":"https://api.github.com/repos/ruby-china/ruby-china/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ruby-china/ruby-china/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ruby-china/ruby-china/git/refs{/sha}","trees_url":"https://api.github.com/repos/ruby-china/ruby-china/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ruby-china/ruby-china/statuses/{sha}","languages_url":"https://api.github.com/repos/ruby-china/ruby-china/languages","stargazers_url":"https://api.github.com/repos/ruby-china/ruby-china/stargazers","contributors_url":"https://api.github.com/repos/ruby-china/ruby-china/contributors","subscribers_url":"https://api.github.com/repos/ruby-china/ruby-china/subscribers","subscription_url":"https://api.github.com/repos/ruby-china/ruby-china/subscription","commits_url":"https://api.github.com/repos/ruby-china/ruby-china/commits{/sha}","git_commits_url":"https://api.github.com/repos/ruby-china/ruby-china/git/commits{/sha}","comments_url":"https://api.github.com/repos/ruby-china/ruby-china/comments{/number}","issue_comment_url":"https://api.github.com/repos/ruby-china/ruby-china/issues/comments/{number}","contents_url":"https://api.github.com/repos/ruby-china/ruby-china/contents/{+path}","compare_url":"https://api.github.com/repos/ruby-china/ruby-china/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ruby-china/ruby-china/merges","archive_url":"https://api.github.com/repos/ruby-china/ruby-china/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ruby-china/ruby-china/downloads","issues_url":"https://api.github.com/repos/ruby-china/ruby-china/issues{/number}","pulls_url":"https://api.github.com/repos/ruby-china/ruby-china/pulls{/number}","milestones_url":"https://api.github.com/repos/ruby-china/ruby-china/milestones{/number}","notifications_url":"https://api.github.com/repos/ruby-china/ruby-china/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ruby-china/ruby-china/labels{/name}","releases_url":"https://api.github.com/repos/ruby-china/ruby-china/releases{/id}","created_at":"2012-03-27T10:26:23Z","updated_at":"2014-07-02T05:17:14Z","pushed_at":"2014-06-27T02:16:48Z","git_url":"git://github.com/ruby-china/ruby-china.git","ssh_url":"git@github.com:ruby-china/ruby-china.git","clone_url":"https://github.com/ruby-china/ruby-china.git","svn_url":"https://github.com/ruby-china/ruby-china","homepage":"http://ruby-china.org","size":25780,"stargazers_count":1012,"watchers_count":1012,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":507,"mirror_url":null,"open_issues_count":26,"forks":507,"open_issues":26,"watchers":1012,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ruby-china/ruby-china/pulls/323"},"html":{"href":"https://github.com/ruby-china/ruby-china/pull/323"},"issue":{"href":"https://api.github.com/repos/ruby-china/ruby-china/issues/323"},"comments":{"href":"https://api.github.com/repos/ruby-china/ruby-china/issues/323/comments"},"review_comments":{"href":"https://api.github.com/repos/ruby-china/ruby-china/pulls/323/comments"},"review_comment":{"href":"https://api.github.com/repos/ruby-china/ruby-china/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ruby-china/ruby-china/pulls/323/commits"},"statuses":{"href":"https://api.github.com/repos/ruby-china/ruby-china/statuses/1eab363496fead4d4b2f1787f209657c010d82fb"}}}}