GitHub PullRequestEvent at 2014-10-05 15:07:07
Repository: lithium
Actor: davidpersson
Payload: {"action":"opened","number":1137,"pull_request":{"url":"https://api.github.com/repos/UnionOfRAD/lithium/pulls/1137","id":22255348,"html_url":"https://github.com/UnionOfRAD/lithium/pull/1137","diff_url":"https://github.com/UnionOfRAD/lithium/pull/1137.diff","patch_url":"https://github.com/UnionOfRAD/lithium/pull/1137.patch","issue_url":"https://api.github.com/repos/UnionOfRAD/lithium/issues/1137","number":1137,"state":"open","locked":false,"title":"Bug/form sign fixes","user":{"login":"davidpersson","id":29702,"avatar_url":"https://avatars.githubusercontent.com/u/29702?v=2","gravatar_id":"","url":"https://api.github.com/users/davidpersson","html_url":"https://github.com/davidpersson","followers_url":"https://api.github.com/users/davidpersson/followers","following_url":"https://api.github.com/users/davidpersson/following{/other_user}","gists_url":"https://api.github.com/users/davidpersson/gists{/gist_id}","starred_url":"https://api.github.com/users/davidpersson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidpersson/subscriptions","organizations_url":"https://api.github.com/users/davidpersson/orgs","repos_url":"https://api.github.com/users/davidpersson/repos","events_url":"https://api.github.com/users/davidpersson/events{/privacy}","received_events_url":"https://api.github.com/users/davidpersson/received_events","type":"User","site_admin":false},"body":"1. This PR adds excluded fields to the compiled form signature. I believe that was intended but code blocking that feature was still left in the codebase.\r\n\r\n2. Fixes a case where form signature checking would wrongly fail even though all fields are present and have not changed. Fixes 2. of issue #998.","created_at":"2014-10-05T15:07:07Z","updated_at":"2014-10-05T15:07:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/UnionOfRAD/lithium/pulls/1137/commits","review_comments_url":"https://api.github.com/repos/UnionOfRAD/lithium/pulls/1137/comments","review_comment_url":"https://api.github.com/repos/UnionOfRAD/lithium/pulls/comments/{number}","comments_url":"https://api.github.com/repos/UnionOfRAD/lithium/issues/1137/comments","statuses_url":"https://api.github.com/repos/UnionOfRAD/lithium/statuses/9b33972f7b0901c8f4849d7a92cc3ddd25008681","head":{"label":"davidpersson:bug/form-sign-fixes","ref":"bug/form-sign-fixes","sha":"9b33972f7b0901c8f4849d7a92cc3ddd25008681","user":{"login":"davidpersson","id":29702,"avatar_url":"https://avatars.githubusercontent.com/u/29702?v=2","gravatar_id":"","url":"https://api.github.com/users/davidpersson","html_url":"https://github.com/davidpersson","followers_url":"https://api.github.com/users/davidpersson/followers","following_url":"https://api.github.com/users/davidpersson/following{/other_user}","gists_url":"https://api.github.com/users/davidpersson/gists{/gist_id}","starred_url":"https://api.github.com/users/davidpersson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidpersson/subscriptions","organizations_url":"https://api.github.com/users/davidpersson/orgs","repos_url":"https://api.github.com/users/davidpersson/repos","events_url":"https://api.github.com/users/davidpersson/events{/privacy}","received_events_url":"https://api.github.com/users/davidpersson/received_events","type":"User","site_admin":false},"repo":{"id":11051886,"name":"lithium","full_name":"davidpersson/lithium","owner":{"login":"davidpersson","id":29702,"avatar_url":"https://avatars.githubusercontent.com/u/29702?v=2","gravatar_id":"","url":"https://api.github.com/users/davidpersson","html_url":"https://github.com/davidpersson","followers_url":"https://api.github.com/users/davidpersson/followers","following_url":"https://api.github.com/users/davidpersson/following{/other_user}","gists_url":"https://api.github.com/users/davidpersson/gists{/gist_id}","starred_url":"https://api.github.com/users/davidpersson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidpersson/subscriptions","organizations_url":"https://api.github.com/users/davidpersson/orgs","repos_url":"https://api.github.com/users/davidpersson/repos","events_url":"https://api.github.com/users/davidpersson/events{/privacy}","received_events_url":"https://api.github.com/users/davidpersson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davidpersson/lithium","description":"Lithium; repository to conduct experiments. See the original repository for the real thing.","fork":true,"url":"https://api.github.com/repos/davidpersson/lithium","forks_url":"https://api.github.com/repos/davidpersson/lithium/forks","keys_url":"https://api.github.com/repos/davidpersson/lithium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidpersson/lithium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidpersson/lithium/teams","hooks_url":"https://api.github.com/repos/davidpersson/lithium/hooks","issue_events_url":"https://api.github.com/repos/davidpersson/lithium/issues/events{/number}","events_url":"https://api.github.com/repos/davidpersson/lithium/events","assignees_url":"https://api.github.com/repos/davidpersson/lithium/assignees{/user}","branches_url":"https://api.github.com/repos/davidpersson/lithium/branches{/branch}","tags_url":"https://api.github.com/repos/davidpersson/lithium/tags","blobs_url":"https://api.github.com/repos/davidpersson/lithium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidpersson/lithium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidpersson/lithium/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidpersson/lithium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidpersson/lithium/statuses/{sha}","languages_url":"https://api.github.com/repos/davidpersson/lithium/languages","stargazers_url":"https://api.github.com/repos/davidpersson/lithium/stargazers","contributors_url":"https://api.github.com/repos/davidpersson/lithium/contributors","subscribers_url":"https://api.github.com/repos/davidpersson/lithium/subscribers","subscription_url":"https://api.github.com/repos/davidpersson/lithium/subscription","commits_url":"https://api.github.com/repos/davidpersson/lithium/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidpersson/lithium/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidpersson/lithium/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidpersson/lithium/issues/comments/{number}","contents_url":"https://api.github.com/repos/davidpersson/lithium/contents/{+path}","compare_url":"https://api.github.com/repos/davidpersson/lithium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidpersson/lithium/merges","archive_url":"https://api.github.com/repos/davidpersson/lithium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidpersson/lithium/downloads","issues_url":"https://api.github.com/repos/davidpersson/lithium/issues{/number}","pulls_url":"https://api.github.com/repos/davidpersson/lithium/pulls{/number}","milestones_url":"https://api.github.com/repos/davidpersson/lithium/milestones{/number}","notifications_url":"https://api.github.com/repos/davidpersson/lithium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidpersson/lithium/labels{/name}","releases_url":"https://api.github.com/repos/davidpersson/lithium/releases{/id}","created_at":"2013-06-29T12:19:05Z","updated_at":"2014-08-03T19:49:52Z","pushed_at":"2014-10-05T15:05:00Z","git_url":"git://github.com/davidpersson/lithium.git","ssh_url":"git@github.com:davidpersson/lithium.git","clone_url":"https://github.com/davidpersson/lithium.git","svn_url":"https://github.com/davidpersson/lithium","homepage":"https://github.com/UnionOfRAD/lithium","size":20033,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"UnionOfRAD:dev","ref":"dev","sha":"3185a66f97d99fb1170fc2ee22b63534db719982","user":{"login":"UnionOfRAD","id":193425,"avatar_url":"https://avatars.githubusercontent.com/u/193425?v=2","gravatar_id":"","url":"https://api.github.com/users/UnionOfRAD","html_url":"https://github.com/UnionOfRAD","followers_url":"https://api.github.com/users/UnionOfRAD/followers","following_url":"https://api.github.com/users/UnionOfRAD/following{/other_user}","gists_url":"https://api.github.com/users/UnionOfRAD/gists{/gist_id}","starred_url":"https://api.github.com/users/UnionOfRAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UnionOfRAD/subscriptions","organizations_url":"https://api.github.com/users/UnionOfRAD/orgs","repos_url":"https://api.github.com/users/UnionOfRAD/repos","events_url":"https://api.github.com/users/UnionOfRAD/events{/privacy}","received_events_url":"https://api.github.com/users/UnionOfRAD/received_events","type":"Organization","site_admin":false},"repo":{"id":1860938,"name":"lithium","full_name":"UnionOfRAD/lithium","owner":{"login":"UnionOfRAD","id":193425,"avatar_url":"https://avatars.githubusercontent.com/u/193425?v=2","gravatar_id":"","url":"https://api.github.com/users/UnionOfRAD","html_url":"https://github.com/UnionOfRAD","followers_url":"https://api.github.com/users/UnionOfRAD/followers","following_url":"https://api.github.com/users/UnionOfRAD/following{/other_user}","gists_url":"https://api.github.com/users/UnionOfRAD/gists{/gist_id}","starred_url":"https://api.github.com/users/UnionOfRAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UnionOfRAD/subscriptions","organizations_url":"https://api.github.com/users/UnionOfRAD/orgs","repos_url":"https://api.github.com/users/UnionOfRAD/repos","events_url":"https://api.github.com/users/UnionOfRAD/events{/privacy}","received_events_url":"https://api.github.com/users/UnionOfRAD/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UnionOfRAD/lithium","description":"Lithium is a light, fast, and highly configurable framework for PHP 5.3+.","fork":false,"url":"https://api.github.com/repos/UnionOfRAD/lithium","forks_url":"https://api.github.com/repos/UnionOfRAD/lithium/forks","keys_url":"https://api.github.com/repos/UnionOfRAD/lithium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UnionOfRAD/lithium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UnionOfRAD/lithium/teams","hooks_url":"https://api.github.com/repos/UnionOfRAD/lithium/hooks","issue_events_url":"https://api.github.com/repos/UnionOfRAD/lithium/issues/events{/number}","events_url":"https://api.github.com/repos/UnionOfRAD/lithium/events","assignees_url":"https://api.github.com/repos/UnionOfRAD/lithium/assignees{/user}","branches_url":"https://api.github.com/repos/UnionOfRAD/lithium/branches{/branch}","tags_url":"https://api.github.com/repos/UnionOfRAD/lithium/tags","blobs_url":"https://api.github.com/repos/UnionOfRAD/lithium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UnionOfRAD/lithium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UnionOfRAD/lithium/git/refs{/sha}","trees_url":"https://api.github.com/repos/UnionOfRAD/lithium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UnionOfRAD/lithium/statuses/{sha}","languages_url":"https://api.github.com/repos/UnionOfRAD/lithium/languages","stargazers_url":"https://api.github.com/repos/UnionOfRAD/lithium/stargazers","contributors_url":"https://api.github.com/repos/UnionOfRAD/lithium/contributors","subscribers_url":"https://api.github.com/repos/UnionOfRAD/lithium/subscribers","subscription_url":"https://api.github.com/repos/UnionOfRAD/lithium/subscription","commits_url":"https://api.github.com/repos/UnionOfRAD/lithium/commits{/sha}","git_commits_url":"https://api.github.com/repos/UnionOfRAD/lithium/git/commits{/sha}","comments_url":"https://api.github.com/repos/UnionOfRAD/lithium/comments{/number}","issue_comment_url":"https://api.github.com/repos/UnionOfRAD/lithium/issues/comments/{number}","contents_url":"https://api.github.com/repos/UnionOfRAD/lithium/contents/{+path}","compare_url":"https://api.github.com/repos/UnionOfRAD/lithium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UnionOfRAD/lithium/merges","archive_url":"https://api.github.com/repos/UnionOfRAD/lithium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UnionOfRAD/lithium/downloads","issues_url":"https://api.github.com/repos/UnionOfRAD/lithium/issues{/number}","pulls_url":"https://api.github.com/repos/UnionOfRAD/lithium/pulls{/number}","milestones_url":"https://api.github.com/repos/UnionOfRAD/lithium/milestones{/number}","notifications_url":"https://api.github.com/repos/UnionOfRAD/lithium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UnionOfRAD/lithium/labels{/name}","releases_url":"https://api.github.com/repos/UnionOfRAD/lithium/releases{/id}","created_at":"2011-06-07T16:55:24Z","updated_at":"2014-10-03T17:24:13Z","pushed_at":"2014-10-05T14:28:06Z","git_url":"git://github.com/UnionOfRAD/lithium.git","ssh_url":"git@github.com:UnionOfRAD/lithium.git","clone_url":"https://github.com/UnionOfRAD/lithium.git","svn_url":"https://github.com/UnionOfRAD/lithium","homepage":"li3.me","size":26015,"stargazers_count":929,"watchers_count":929,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":236,"mirror_url":null,"open_issues_count":48,"forks":236,"open_issues":48,"watchers":929,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/UnionOfRAD/lithium/pulls/1137"},"html":{"href":"https://github.com/UnionOfRAD/lithium/pull/1137"},"issue":{"href":"https://api.github.com/repos/UnionOfRAD/lithium/issues/1137"},"comments":{"href":"https://api.github.com/repos/UnionOfRAD/lithium/issues/1137/comments"},"review_comments":{"href":"https://api.github.com/repos/UnionOfRAD/lithium/pulls/1137/comments"},"review_comment":{"href":"https://api.github.com/repos/UnionOfRAD/lithium/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/UnionOfRAD/lithium/pulls/1137/commits"},"statuses":{"href":"https://api.github.com/repos/UnionOfRAD/lithium/statuses/9b33972f7b0901c8f4849d7a92cc3ddd25008681"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":4,"additions":297,"deletions":29,"changed_files":5}}