GitHub PullRequestReviewCommentEvent at 2014-08-28 07:27:39
Repository: SugarRecord
Actor: pepibumur
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/SugarRecord/SugarRecord/pulls/comments/16824591","id":16824591,"diff_hunk":"@@ -49,7 +53,7 @@ class SugarRecord {\n      :param: automigrating Specifies if the old database should be auto migrated\n      :param: databaseName  Database name. If not passed, default one will be used\n      */\n-    class func setupCoreDataStack (automigrating: Bool?, databaseName: String?) -> () {\n+    class func setupCoreDataStack(#automigrating: Bool?, databaseName: String?) {","path":"SugarRecord/SugarRecord.swift","position":41,"original_position":41,"commit_id":"7131b8d2ce1f229ddfe9dce5da0b372a1e9ab050","original_commit_id":"7131b8d2ce1f229ddfe9dce5da0b372a1e9ab050","user":{"login":"pepibumur","id":663605,"avatar_url":"https://avatars.githubusercontent.com/u/663605?v=2","gravatar_id":"b0a336761194918a853deeff1f22b537","url":"https://api.github.com/users/pepibumur","html_url":"https://github.com/pepibumur","followers_url":"https://api.github.com/users/pepibumur/followers","following_url":"https://api.github.com/users/pepibumur/following{/other_user}","gists_url":"https://api.github.com/users/pepibumur/gists{/gist_id}","starred_url":"https://api.github.com/users/pepibumur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pepibumur/subscriptions","organizations_url":"https://api.github.com/users/pepibumur/orgs","repos_url":"https://api.github.com/users/pepibumur/repos","events_url":"https://api.github.com/users/pepibumur/events{/privacy}","received_events_url":"https://api.github.com/users/pepibumur/received_events","type":"User","site_admin":false},"body":"Sorry but my ignorance but what `#`did? @fjbelchi  ","created_at":"2014-08-28T07:27:39Z","updated_at":"2014-08-28T07:27:39Z","html_url":"https://github.com/SugarRecord/SugarRecord/pull/4#discussion_r16824591","pull_request_url":"https://api.github.com/repos/SugarRecord/SugarRecord/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/SugarRecord/SugarRecord/pulls/comments/16824591"},"html":{"href":"https://github.com/SugarRecord/SugarRecord/pull/4#discussion_r16824591"},"pull_request":{"href":"https://api.github.com/repos/SugarRecord/SugarRecord/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/SugarRecord/SugarRecord/pulls/4","id":20421540,"html_url":"https://github.com/SugarRecord/SugarRecord/pull/4","diff_url":"https://github.com/SugarRecord/SugarRecord/pull/4.diff","patch_url":"https://github.com/SugarRecord/SugarRecord/pull/4.patch","issue_url":"https://api.github.com/repos/SugarRecord/SugarRecord/issues/4","number":4,"state":"open","locked":false,"title":"[WIP] Sugar record class","user":{"login":"fjbelchi","id":626713,"avatar_url":"https://avatars.githubusercontent.com/u/626713?v=2","gravatar_id":"cc282ace9232a821c846541a075c8647","url":"https://api.github.com/users/fjbelchi","html_url":"https://github.com/fjbelchi","followers_url":"https://api.github.com/users/fjbelchi/followers","following_url":"https://api.github.com/users/fjbelchi/following{/other_user}","gists_url":"https://api.github.com/users/fjbelchi/gists{/gist_id}","starred_url":"https://api.github.com/users/fjbelchi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjbelchi/subscriptions","organizations_url":"https://api.github.com/users/fjbelchi/orgs","repos_url":"https://api.github.com/users/fjbelchi/repos","events_url":"https://api.github.com/users/fjbelchi/events{/privacy}","received_events_url":"https://api.github.com/users/fjbelchi/received_events","type":"User","site_admin":false},"body":"Hi Pedro,\r\n\r\nI'm making my hands dirty touching the SugarRecord.swift class. I saw this morning the amazing work you did with the documentation and splitting the classes, so I couldn't resist to open my first PR :)\r\n\r\nI will comment about this later in the email I have pending to reply, but essentially in this PR I wanted to get familiar with the code so I did a few tweaks meanwhile I was reading. I don't want to merge this PR until I have the test ready for testing the class methods of SugarRecord.swift to ensure I haven't broke anything.\r\n\r\nSo in this PR the changes so far are:\r\n\r\n- Moved the files to the right path to match with the group on xcode\r\n- I changed the KVO strings from var to let. I think the name of the constants doesn't follow the style guide.\r\n- I saw all the class methods where returning tuples, so I removed it.\r\n- More tweaks I comment inline\r\n\r\n","created_at":"2014-08-28T07:23:27Z","updated_at":"2014-08-28T07:27:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eadbf7e450dbe578f1ce81fc9d6cd745ed7b6bb5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SugarRecord/SugarRecord/pulls/4/commits","review_comments_url":"https://api.github.com/repos/SugarRecord/SugarRecord/pulls/4/comments","review_comment_url":"https://api.github.com/repos/SugarRecord/SugarRecord/pulls/comments/{number}","comments_url":"https://api.github.com/repos/SugarRecord/SugarRecord/issues/4/comments","statuses_url":"https://api.github.com/repos/SugarRecord/SugarRecord/statuses/7131b8d2ce1f229ddfe9dce5da0b372a1e9ab050","head":{"label":"fjbelchi:SugarRecord-Class","ref":"SugarRecord-Class","sha":"7131b8d2ce1f229ddfe9dce5da0b372a1e9ab050","user":{"login":"fjbelchi","id":626713,"avatar_url":"https://avatars.githubusercontent.com/u/626713?v=2","gravatar_id":"cc282ace9232a821c846541a075c8647","url":"https://api.github.com/users/fjbelchi","html_url":"https://github.com/fjbelchi","followers_url":"https://api.github.com/users/fjbelchi/followers","following_url":"https://api.github.com/users/fjbelchi/following{/other_user}","gists_url":"https://api.github.com/users/fjbelchi/gists{/gist_id}","starred_url":"https://api.github.com/users/fjbelchi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjbelchi/subscriptions","organizations_url":"https://api.github.com/users/fjbelchi/orgs","repos_url":"https://api.github.com/users/fjbelchi/repos","events_url":"https://api.github.com/users/fjbelchi/events{/privacy}","received_events_url":"https://api.github.com/users/fjbelchi/received_events","type":"User","site_admin":false},"repo":{"id":23321105,"name":"SugarRecord","full_name":"fjbelchi/SugarRecord","owner":{"login":"fjbelchi","id":626713,"avatar_url":"https://avatars.githubusercontent.com/u/626713?v=2","gravatar_id":"cc282ace9232a821c846541a075c8647","url":"https://api.github.com/users/fjbelchi","html_url":"https://github.com/fjbelchi","followers_url":"https://api.github.com/users/fjbelchi/followers","following_url":"https://api.github.com/users/fjbelchi/following{/other_user}","gists_url":"https://api.github.com/users/fjbelchi/gists{/gist_id}","starred_url":"https://api.github.com/users/fjbelchi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjbelchi/subscriptions","organizations_url":"https://api.github.com/users/fjbelchi/orgs","repos_url":"https://api.github.com/users/fjbelchi/repos","events_url":"https://api.github.com/users/fjbelchi/events{/privacy}","received_events_url":"https://api.github.com/users/fjbelchi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fjbelchi/SugarRecord","description":"CoreData management library written in Swift","fork":true,"url":"https://api.github.com/repos/fjbelchi/SugarRecord","forks_url":"https://api.github.com/repos/fjbelchi/SugarRecord/forks","keys_url":"https://api.github.com/repos/fjbelchi/SugarRecord/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fjbelchi/SugarRecord/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fjbelchi/SugarRecord/teams","hooks_url":"https://api.github.com/repos/fjbelchi/SugarRecord/hooks","issue_events_url":"https://api.github.com/repos/fjbelchi/SugarRecord/issues/events{/number}","events_url":"https://api.github.com/repos/fjbelchi/SugarRecord/events","assignees_url":"https://api.github.com/repos/fjbelchi/SugarRecord/assignees{/user}","branches_url":"https://api.github.com/repos/fjbelchi/SugarRecord/branches{/branch}","tags_url":"https://api.github.com/repos/fjbelchi/SugarRecord/tags","blobs_url":"https://api.github.com/repos/fjbelchi/SugarRecord/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fjbelchi/SugarRecord/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fjbelchi/SugarRecord/git/refs{/sha}","trees_url":"https://api.github.com/repos/fjbelchi/SugarRecord/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fjbelchi/SugarRecord/statuses/{sha}","languages_url":"https://api.github.com/repos/fjbelchi/SugarRecord/languages","stargazers_url":"https://api.github.com/repos/fjbelchi/SugarRecord/stargazers","contributors_url":"https://api.github.com/repos/fjbelchi/SugarRecord/contributors","subscribers_url":"https://api.github.com/repos/fjbelchi/SugarRecord/subscribers","subscription_url":"https://api.github.com/repos/fjbelchi/SugarRecord/subscription","commits_url":"https://api.github.com/repos/fjbelchi/SugarRecord/commits{/sha}","git_commits_url":"https://api.github.com/repos/fjbelchi/SugarRecord/git/commits{/sha}","comments_url":"https://api.github.com/repos/fjbelchi/SugarRecord/comments{/number}","issue_comment_url":"https://api.github.com/repos/fjbelchi/SugarRecord/issues/comments/{number}","contents_url":"https://api.github.com/repos/fjbelchi/SugarRecord/contents/{+path}","compare_url":"https://api.github.com/repos/fjbelchi/SugarRecord/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fjbelchi/SugarRecord/merges","archive_url":"https://api.github.com/repos/fjbelchi/SugarRecord/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fjbelchi/SugarRecord/downloads","issues_url":"https://api.github.com/repos/fjbelchi/SugarRecord/issues{/number}","pulls_url":"https://api.github.com/repos/fjbelchi/SugarRecord/pulls{/number}","milestones_url":"https://api.github.com/repos/fjbelchi/SugarRecord/milestones{/number}","notifications_url":"https://api.github.com/repos/fjbelchi/SugarRecord/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fjbelchi/SugarRecord/labels{/name}","releases_url":"https://api.github.com/repos/fjbelchi/SugarRecord/releases{/id}","created_at":"2014-08-25T16:46:32Z","updated_at":"2014-08-26T06:32:07Z","pushed_at":"2014-08-28T07:17:00Z","git_url":"git://github.com/fjbelchi/SugarRecord.git","ssh_url":"git@github.com:fjbelchi/SugarRecord.git","clone_url":"https://github.com/fjbelchi/SugarRecord.git","svn_url":"https://github.com/fjbelchi/SugarRecord","homepage":null,"size":652,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SugarRecord:master","ref":"master","sha":"795f3c666732cb8ad65e2f8cbd114ee20a050965","user":{"login":"SugarRecord","id":8554741,"avatar_url":"https://avatars.githubusercontent.com/u/8554741?v=2","gravatar_id":null,"url":"https://api.github.com/users/SugarRecord","html_url":"https://github.com/SugarRecord","followers_url":"https://api.github.com/users/SugarRecord/followers","following_url":"https://api.github.com/users/SugarRecord/following{/other_user}","gists_url":"https://api.github.com/users/SugarRecord/gists{/gist_id}","starred_url":"https://api.github.com/users/SugarRecord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SugarRecord/subscriptions","organizations_url":"https://api.github.com/users/SugarRecord/orgs","repos_url":"https://api.github.com/users/SugarRecord/repos","events_url":"https://api.github.com/users/SugarRecord/events{/privacy}","received_events_url":"https://api.github.com/users/SugarRecord/received_events","type":"Organization","site_admin":false},"repo":{"id":22596493,"name":"SugarRecord","full_name":"SugarRecord/SugarRecord","owner":{"login":"SugarRecord","id":8554741,"avatar_url":"https://avatars.githubusercontent.com/u/8554741?v=2","gravatar_id":null,"url":"https://api.github.com/users/SugarRecord","html_url":"https://github.com/SugarRecord","followers_url":"https://api.github.com/users/SugarRecord/followers","following_url":"https://api.github.com/users/SugarRecord/following{/other_user}","gists_url":"https://api.github.com/users/SugarRecord/gists{/gist_id}","starred_url":"https://api.github.com/users/SugarRecord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SugarRecord/subscriptions","organizations_url":"https://api.github.com/users/SugarRecord/orgs","repos_url":"https://api.github.com/users/SugarRecord/repos","events_url":"https://api.github.com/users/SugarRecord/events{/privacy}","received_events_url":"https://api.github.com/users/SugarRecord/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SugarRecord/SugarRecord","description":"CoreData management library written in Swift","fork":false,"url":"https://api.github.com/repos/SugarRecord/SugarRecord","forks_url":"https://api.github.com/repos/SugarRecord/SugarRecord/forks","keys_url":"https://api.github.com/repos/SugarRecord/SugarRecord/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SugarRecord/SugarRecord/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SugarRecord/SugarRecord/teams","hooks_url":"https://api.github.com/repos/SugarRecord/SugarRecord/hooks","issue_events_url":"https://api.github.com/repos/SugarRecord/SugarRecord/issues/events{/number}","events_url":"https://api.github.com/repos/SugarRecord/SugarRecord/events","assignees_url":"https://api.github.com/repos/SugarRecord/SugarRecord/assignees{/user}","branches_url":"https://api.github.com/repos/SugarRecord/SugarRecord/branches{/branch}","tags_url":"https://api.github.com/repos/SugarRecord/SugarRecord/tags","blobs_url":"https://api.github.com/repos/SugarRecord/SugarRecord/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SugarRecord/SugarRecord/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SugarRecord/SugarRecord/git/refs{/sha}","trees_url":"https://api.github.com/repos/SugarRecord/SugarRecord/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SugarRecord/SugarRecord/statuses/{sha}","languages_url":"https://api.github.com/repos/SugarRecord/SugarRecord/languages","stargazers_url":"https://api.github.com/repos/SugarRecord/SugarRecord/stargazers","contributors_url":"https://api.github.com/repos/SugarRecord/SugarRecord/contributors","subscribers_url":"https://api.github.com/repos/SugarRecord/SugarRecord/subscribers","subscription_url":"https://api.github.com/repos/SugarRecord/SugarRecord/subscription","commits_url":"https://api.github.com/repos/SugarRecord/SugarRecord/commits{/sha}","git_commits_url":"https://api.github.com/repos/SugarRecord/SugarRecord/git/commits{/sha}","comments_url":"https://api.github.com/repos/SugarRecord/SugarRecord/comments{/number}","issue_comment_url":"https://api.github.com/repos/SugarRecord/SugarRecord/issues/comments/{number}","contents_url":"https://api.github.com/repos/SugarRecord/SugarRecord/contents/{+path}","compare_url":"https://api.github.com/repos/SugarRecord/SugarRecord/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SugarRecord/SugarRecord/merges","archive_url":"https://api.github.com/repos/SugarRecord/SugarRecord/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SugarRecord/SugarRecord/downloads","issues_url":"https://api.github.com/repos/SugarRecord/SugarRecord/issues{/number}","pulls_url":"https://api.github.com/repos/SugarRecord/SugarRecord/pulls{/number}","milestones_url":"https://api.github.com/repos/SugarRecord/SugarRecord/milestones{/number}","notifications_url":"https://api.github.com/repos/SugarRecord/SugarRecord/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SugarRecord/SugarRecord/labels{/name}","releases_url":"https://api.github.com/repos/SugarRecord/SugarRecord/releases{/id}","created_at":"2014-08-04T08:05:03Z","updated_at":"2014-08-27T23:56:10Z","pushed_at":"2014-08-27T21:39:28Z","git_url":"git://github.com/SugarRecord/SugarRecord.git","ssh_url":"git@github.com:SugarRecord/SugarRecord.git","clone_url":"https://github.com/SugarRecord/SugarRecord.git","svn_url":"https://github.com/SugarRecord/SugarRecord","homepage":null,"size":652,"stargazers_count":7,"watchers_count":7,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":2,"mirror_url":null,"open_issues_count":3,"forks":2,"open_issues":3,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SugarRecord/SugarRecord/pulls/4"},"html":{"href":"https://github.com/SugarRecord/SugarRecord/pull/4"},"issue":{"href":"https://api.github.com/repos/SugarRecord/SugarRecord/issues/4"},"comments":{"href":"https://api.github.com/repos/SugarRecord/SugarRecord/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/SugarRecord/SugarRecord/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/SugarRecord/SugarRecord/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/SugarRecord/SugarRecord/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/SugarRecord/SugarRecord/statuses/7131b8d2ce1f229ddfe9dce5da0b372a1e9ab050"}}}}