GitHub PullRequestEvent at 2014-08-19 23:50:24
Repository: plottable
Actor: simoneschaffer
Payload: {"action":"reopened","number":850,"pull_request":{"url":"https://api.github.com/repos/palantir/plottable/pulls/850","id":19958484,"html_url":"https://github.com/palantir/plottable/pull/850","diff_url":"https://github.com/palantir/plottable/pull/850.diff","patch_url":"https://github.com/palantir/plottable/pull/850.patch","issue_url":"https://api.github.com/repos/palantir/plottable/issues/850","number":850,"state":"open","locked":false,"title":"Dragbox resizing when edges are dragged","user":{"login":"fent","id":933490,"avatar_url":"https://avatars.githubusercontent.com/u/933490?v=2","gravatar_id":"3471337d7de26218e5fced27d186f020","url":"https://api.github.com/users/fent","html_url":"https://github.com/fent","followers_url":"https://api.github.com/users/fent/followers","following_url":"https://api.github.com/users/fent/following{/other_user}","gists_url":"https://api.github.com/users/fent/gists{/gist_id}","starred_url":"https://api.github.com/users/fent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fent/subscriptions","organizations_url":"https://api.github.com/users/fent/orgs","repos_url":"https://api.github.com/users/fent/repos","events_url":"https://api.github.com/users/fent/events{/privacy}","received_events_url":"https://api.github.com/users/fent/received_events","type":"User","site_admin":false},"body":"This PR implements resizing a dragbox by dragging its edges when it's drawn on screen. The cursor changes appropriately even on first draw.\r\n\r\nhttp://jsfiddle.net/552z0h27/\r\n\r\nThere are some questionable areas I'd like feedback on, specifically on how organized code looks and its simplicity. The code added to `XYDragBoxInteraction.ts` seems like a lot for example.\r\n\r\nThe API for dragging events still works like before, the callbacks the  `start` and `end` points, even on resizing even if the dragbox is not bounded by those points. For that, there is `DragBox.selection` which is a `SelectionArea`.\r\n\r\n","created_at":"2014-08-19T03:31:04Z","updated_at":"2014-08-19T23:50:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/palantir/plottable/pulls/850/commits","review_comments_url":"https://api.github.com/repos/palantir/plottable/pulls/850/comments","review_comment_url":"https://api.github.com/repos/palantir/plottable/pulls/comments/{number}","comments_url":"https://api.github.com/repos/palantir/plottable/issues/850/comments","statuses_url":"https://api.github.com/repos/palantir/plottable/statuses/c4e4b32c3baf50c6c3682e9914766f07d62b020c","head":{"label":"poptip:dragresize","ref":"dragresize","sha":"c4e4b32c3baf50c6c3682e9914766f07d62b020c","user":{"login":"poptip","id":896930,"avatar_url":"https://avatars.githubusercontent.com/u/896930?v=2","gravatar_id":"fd2741961bf7467ccfcb167d6aa61440","url":"https://api.github.com/users/poptip","html_url":"https://github.com/poptip","followers_url":"https://api.github.com/users/poptip/followers","following_url":"https://api.github.com/users/poptip/following{/other_user}","gists_url":"https://api.github.com/users/poptip/gists{/gist_id}","starred_url":"https://api.github.com/users/poptip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poptip/subscriptions","organizations_url":"https://api.github.com/users/poptip/orgs","repos_url":"https://api.github.com/users/poptip/repos","events_url":"https://api.github.com/users/poptip/events{/privacy}","received_events_url":"https://api.github.com/users/poptip/received_events","type":"Organization","site_admin":false},"repo":{"id":22314009,"name":"plottable","full_name":"poptip/plottable","owner":{"login":"poptip","id":896930,"avatar_url":"https://avatars.githubusercontent.com/u/896930?v=2","gravatar_id":"fd2741961bf7467ccfcb167d6aa61440","url":"https://api.github.com/users/poptip","html_url":"https://github.com/poptip","followers_url":"https://api.github.com/users/poptip/followers","following_url":"https://api.github.com/users/poptip/following{/other_user}","gists_url":"https://api.github.com/users/poptip/gists{/gist_id}","starred_url":"https://api.github.com/users/poptip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poptip/subscriptions","organizations_url":"https://api.github.com/users/poptip/orgs","repos_url":"https://api.github.com/users/poptip/repos","events_url":"https://api.github.com/users/poptip/events{/privacy}","received_events_url":"https://api.github.com/users/poptip/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/poptip/plottable","description":"A library for creating interactive charts within a grid layout.","fork":true,"url":"https://api.github.com/repos/poptip/plottable","forks_url":"https://api.github.com/repos/poptip/plottable/forks","keys_url":"https://api.github.com/repos/poptip/plottable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/poptip/plottable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/poptip/plottable/teams","hooks_url":"https://api.github.com/repos/poptip/plottable/hooks","issue_events_url":"https://api.github.com/repos/poptip/plottable/issues/events{/number}","events_url":"https://api.github.com/repos/poptip/plottable/events","assignees_url":"https://api.github.com/repos/poptip/plottable/assignees{/user}","branches_url":"https://api.github.com/repos/poptip/plottable/branches{/branch}","tags_url":"https://api.github.com/repos/poptip/plottable/tags","blobs_url":"https://api.github.com/repos/poptip/plottable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/poptip/plottable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/poptip/plottable/git/refs{/sha}","trees_url":"https://api.github.com/repos/poptip/plottable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/poptip/plottable/statuses/{sha}","languages_url":"https://api.github.com/repos/poptip/plottable/languages","stargazers_url":"https://api.github.com/repos/poptip/plottable/stargazers","contributors_url":"https://api.github.com/repos/poptip/plottable/contributors","subscribers_url":"https://api.github.com/repos/poptip/plottable/subscribers","subscription_url":"https://api.github.com/repos/poptip/plottable/subscription","commits_url":"https://api.github.com/repos/poptip/plottable/commits{/sha}","git_commits_url":"https://api.github.com/repos/poptip/plottable/git/commits{/sha}","comments_url":"https://api.github.com/repos/poptip/plottable/comments{/number}","issue_comment_url":"https://api.github.com/repos/poptip/plottable/issues/comments/{number}","contents_url":"https://api.github.com/repos/poptip/plottable/contents/{+path}","compare_url":"https://api.github.com/repos/poptip/plottable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/poptip/plottable/merges","archive_url":"https://api.github.com/repos/poptip/plottable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/poptip/plottable/downloads","issues_url":"https://api.github.com/repos/poptip/plottable/issues{/number}","pulls_url":"https://api.github.com/repos/poptip/plottable/pulls{/number}","milestones_url":"https://api.github.com/repos/poptip/plottable/milestones{/number}","notifications_url":"https://api.github.com/repos/poptip/plottable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/poptip/plottable/labels{/name}","releases_url":"https://api.github.com/repos/poptip/plottable/releases{/id}","created_at":"2014-07-27T15:23:16Z","updated_at":"2014-07-26T04:52:51Z","pushed_at":"2014-08-19T22:04:14Z","git_url":"git://github.com/poptip/plottable.git","ssh_url":"git@github.com:poptip/plottable.git","clone_url":"https://github.com/poptip/plottable.git","svn_url":"https://github.com/poptip/plottable","homepage":"palantir.github.io/plottable","size":15188,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"palantir:master","ref":"master","sha":"4f1fac7b94ea8954e2ca308e429b5235beea3e48","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=2","gravatar_id":"c593136bf7c6a139280354bfc1448a14","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":16149854,"name":"plottable","full_name":"palantir/plottable","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=2","gravatar_id":"c593136bf7c6a139280354bfc1448a14","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/plottable","description":"A library for creating interactive charts within a grid layout.","fork":false,"url":"https://api.github.com/repos/palantir/plottable","forks_url":"https://api.github.com/repos/palantir/plottable/forks","keys_url":"https://api.github.com/repos/palantir/plottable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/plottable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/plottable/teams","hooks_url":"https://api.github.com/repos/palantir/plottable/hooks","issue_events_url":"https://api.github.com/repos/palantir/plottable/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/plottable/events","assignees_url":"https://api.github.com/repos/palantir/plottable/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/plottable/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/plottable/tags","blobs_url":"https://api.github.com/repos/palantir/plottable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/plottable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/plottable/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/plottable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/plottable/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/plottable/languages","stargazers_url":"https://api.github.com/repos/palantir/plottable/stargazers","contributors_url":"https://api.github.com/repos/palantir/plottable/contributors","subscribers_url":"https://api.github.com/repos/palantir/plottable/subscribers","subscription_url":"https://api.github.com/repos/palantir/plottable/subscription","commits_url":"https://api.github.com/repos/palantir/plottable/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/plottable/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/plottable/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/plottable/issues/comments/{number}","contents_url":"https://api.github.com/repos/palantir/plottable/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/plottable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/plottable/merges","archive_url":"https://api.github.com/repos/palantir/plottable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/plottable/downloads","issues_url":"https://api.github.com/repos/palantir/plottable/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/plottable/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/plottable/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/plottable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/plottable/labels{/name}","releases_url":"https://api.github.com/repos/palantir/plottable/releases{/id}","created_at":"2014-01-22T19:29:19Z","updated_at":"2014-08-19T17:40:33Z","pushed_at":"2014-08-19T23:37:27Z","git_url":"git://github.com/palantir/plottable.git","ssh_url":"git@github.com:palantir/plottable.git","clone_url":"https://github.com/palantir/plottable.git","svn_url":"https://github.com/palantir/plottable","homepage":"palantir.github.io/plottable","size":39517,"stargazers_count":94,"watchers_count":94,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":14,"mirror_url":null,"open_issues_count":96,"forks":14,"open_issues":96,"watchers":94,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/palantir/plottable/pulls/850"},"html":{"href":"https://github.com/palantir/plottable/pull/850"},"issue":{"href":"https://api.github.com/repos/palantir/plottable/issues/850"},"comments":{"href":"https://api.github.com/repos/palantir/plottable/issues/850/comments"},"review_comments":{"href":"https://api.github.com/repos/palantir/plottable/pulls/850/comments"},"review_comment":{"href":"https://api.github.com/repos/palantir/plottable/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/palantir/plottable/pulls/850/commits"},"statuses":{"href":"https://api.github.com/repos/palantir/plottable/statuses/c4e4b32c3baf50c6c3682e9914766f07d62b020c"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":8,"review_comments":16,"commits":24,"additions":6825,"deletions":1016,"changed_files":9}}