GitHub PullRequestReviewCommentEvent at 2014-06-11 00:07:00
Repository: svg-animation
Actor: shans
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/ericwilligers/svg-animation/pulls/comments/13627374","id":13627374,"diff_hunk":"@@ -0,0 +1,9 @@\n+<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n+<!DOCTYPE svg PUBLIC \"-//W3C//DTD SVG 1.1 Tiny//EN\" \"http://www.w3.org/Graphics/SVG/1.1/DTD/svg11-tiny.dtd\">\n+<svg xmlns=\"http://www.w3.org/2000/svg\" xmlns:xlink=\"http://www.w3.org/1999/xlink\" width=\"800\" height=\"100\">\n+  <!-- I don't understand why changing rect width to \"100\" prevents animation width ever exceeding 100 -->","path":"examples/svg/targetElement.svg","position":4,"original_position":4,"commit_id":"abffec4ae1f500e23830929c02be8e8835a3ec34","original_commit_id":"abffec4ae1f500e23830929c02be8e8835a3ec34","user":{"login":"shans","id":329053,"avatar_url":"https://avatars.githubusercontent.com/u/329053?","gravatar_id":"c1d7a74ec0df54a2fe3bc4585dec4e6f","url":"https://api.github.com/users/shans","html_url":"https://github.com/shans","followers_url":"https://api.github.com/users/shans/followers","following_url":"https://api.github.com/users/shans/following{/other_user}","gists_url":"https://api.github.com/users/shans/gists{/gist_id}","starred_url":"https://api.github.com/users/shans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shans/subscriptions","organizations_url":"https://api.github.com/users/shans/orgs","repos_url":"https://api.github.com/users/shans/repos","events_url":"https://api.github.com/users/shans/events{/privacy}","received_events_url":"https://api.github.com/users/shans/received_events","type":"User","site_admin":false},"body":"Ah, it's because targetElement isn't an SVG attribute.","created_at":"2014-06-11T00:07:00Z","updated_at":"2014-06-11T00:07:00Z","html_url":"https://github.com/ericwilligers/svg-animation/pull/1#discussion_r13627374","pull_request_url":"https://api.github.com/repos/ericwilligers/svg-animation/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/ericwilligers/svg-animation/pulls/comments/13627374"},"html":{"href":"https://github.com/ericwilligers/svg-animation/pull/1#discussion_r13627374"},"pull_request":{"href":"https://api.github.com/repos/ericwilligers/svg-animation/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/ericwilligers/svg-animation/pulls/1","id":16973090,"html_url":"https://github.com/ericwilligers/svg-animation/pull/1","diff_url":"https://github.com/ericwilligers/svg-animation/pull/1.diff","patch_url":"https://github.com/ericwilligers/svg-animation/pull/1.patch","issue_url":"https://api.github.com/repos/ericwilligers/svg-animation/issues/1","number":1,"state":"open","title":"Simplest examples of SVG animation","user":{"login":"ewilligers","id":929206,"avatar_url":"https://avatars.githubusercontent.com/u/929206?","gravatar_id":"b3a2c389ef8422f5599f7c7da8401748","url":"https://api.github.com/users/ewilligers","html_url":"https://github.com/ewilligers","followers_url":"https://api.github.com/users/ewilligers/followers","following_url":"https://api.github.com/users/ewilligers/following{/other_user}","gists_url":"https://api.github.com/users/ewilligers/gists{/gist_id}","starred_url":"https://api.github.com/users/ewilligers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewilligers/subscriptions","organizations_url":"https://api.github.com/users/ewilligers/orgs","repos_url":"https://api.github.com/users/ewilligers/repos","events_url":"https://api.github.com/users/ewilligers/events{/privacy}","received_events_url":"https://api.github.com/users/ewilligers/received_events","type":"User","site_admin":false},"body":"Each svg/ file illustrates a SMIL feature.\r\n\r\nEach web/ file illustrates how the same behavior can be achieved using Web Animations.","created_at":"2014-06-10T23:51:40Z","updated_at":"2014-06-11T00:07:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ac9d5ef2450a4113aed8783a5a3f1a7e46628732","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ericwilligers/svg-animation/pulls/1/commits","review_comments_url":"https://api.github.com/repos/ericwilligers/svg-animation/pulls/1/comments","review_comment_url":"https://api.github.com/repos/ericwilligers/svg-animation/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ericwilligers/svg-animation/issues/1/comments","statuses_url":"https://api.github.com/repos/ericwilligers/svg-animation/statuses/abffec4ae1f500e23830929c02be8e8835a3ec34","head":{"label":"ewilligers:simplest-examples","ref":"simplest-examples","sha":"abffec4ae1f500e23830929c02be8e8835a3ec34","user":{"login":"ewilligers","id":929206,"avatar_url":"https://avatars.githubusercontent.com/u/929206?","gravatar_id":"b3a2c389ef8422f5599f7c7da8401748","url":"https://api.github.com/users/ewilligers","html_url":"https://github.com/ewilligers","followers_url":"https://api.github.com/users/ewilligers/followers","following_url":"https://api.github.com/users/ewilligers/following{/other_user}","gists_url":"https://api.github.com/users/ewilligers/gists{/gist_id}","starred_url":"https://api.github.com/users/ewilligers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewilligers/subscriptions","organizations_url":"https://api.github.com/users/ewilligers/orgs","repos_url":"https://api.github.com/users/ewilligers/repos","events_url":"https://api.github.com/users/ewilligers/events{/privacy}","received_events_url":"https://api.github.com/users/ewilligers/received_events","type":"User","site_admin":false},"repo":{"id":20705210,"name":"svg-animation","full_name":"ewilligers/svg-animation","owner":{"login":"ewilligers","id":929206,"avatar_url":"https://avatars.githubusercontent.com/u/929206?","gravatar_id":"b3a2c389ef8422f5599f7c7da8401748","url":"https://api.github.com/users/ewilligers","html_url":"https://github.com/ewilligers","followers_url":"https://api.github.com/users/ewilligers/followers","following_url":"https://api.github.com/users/ewilligers/following{/other_user}","gists_url":"https://api.github.com/users/ewilligers/gists{/gist_id}","starred_url":"https://api.github.com/users/ewilligers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewilligers/subscriptions","organizations_url":"https://api.github.com/users/ewilligers/orgs","repos_url":"https://api.github.com/users/ewilligers/repos","events_url":"https://api.github.com/users/ewilligers/events{/privacy}","received_events_url":"https://api.github.com/users/ewilligers/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ewilligers/svg-animation","description":"Implement SVG animation in JavaScript using Web Animations","fork":true,"url":"https://api.github.com/repos/ewilligers/svg-animation","forks_url":"https://api.github.com/repos/ewilligers/svg-animation/forks","keys_url":"https://api.github.com/repos/ewilligers/svg-animation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ewilligers/svg-animation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ewilligers/svg-animation/teams","hooks_url":"https://api.github.com/repos/ewilligers/svg-animation/hooks","issue_events_url":"https://api.github.com/repos/ewilligers/svg-animation/issues/events{/number}","events_url":"https://api.github.com/repos/ewilligers/svg-animation/events","assignees_url":"https://api.github.com/repos/ewilligers/svg-animation/assignees{/user}","branches_url":"https://api.github.com/repos/ewilligers/svg-animation/branches{/branch}","tags_url":"https://api.github.com/repos/ewilligers/svg-animation/tags","blobs_url":"https://api.github.com/repos/ewilligers/svg-animation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ewilligers/svg-animation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ewilligers/svg-animation/git/refs{/sha}","trees_url":"https://api.github.com/repos/ewilligers/svg-animation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ewilligers/svg-animation/statuses/{sha}","languages_url":"https://api.github.com/repos/ewilligers/svg-animation/languages","stargazers_url":"https://api.github.com/repos/ewilligers/svg-animation/stargazers","contributors_url":"https://api.github.com/repos/ewilligers/svg-animation/contributors","subscribers_url":"https://api.github.com/repos/ewilligers/svg-animation/subscribers","subscription_url":"https://api.github.com/repos/ewilligers/svg-animation/subscription","commits_url":"https://api.github.com/repos/ewilligers/svg-animation/commits{/sha}","git_commits_url":"https://api.github.com/repos/ewilligers/svg-animation/git/commits{/sha}","comments_url":"https://api.github.com/repos/ewilligers/svg-animation/comments{/number}","issue_comment_url":"https://api.github.com/repos/ewilligers/svg-animation/issues/comments/{number}","contents_url":"https://api.github.com/repos/ewilligers/svg-animation/contents/{+path}","compare_url":"https://api.github.com/repos/ewilligers/svg-animation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ewilligers/svg-animation/merges","archive_url":"https://api.github.com/repos/ewilligers/svg-animation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ewilligers/svg-animation/downloads","issues_url":"https://api.github.com/repos/ewilligers/svg-animation/issues{/number}","pulls_url":"https://api.github.com/repos/ewilligers/svg-animation/pulls{/number}","milestones_url":"https://api.github.com/repos/ewilligers/svg-animation/milestones{/number}","notifications_url":"https://api.github.com/repos/ewilligers/svg-animation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ewilligers/svg-animation/labels{/name}","releases_url":"https://api.github.com/repos/ewilligers/svg-animation/releases{/id}","created_at":"2014-06-10T23:22:54Z","updated_at":"2014-06-10T23:51:40Z","pushed_at":"2014-06-10T23:50:54Z","git_url":"git://github.com/ewilligers/svg-animation.git","ssh_url":"git@github.com:ewilligers/svg-animation.git","clone_url":"https://github.com/ewilligers/svg-animation.git","svn_url":"https://github.com/ewilligers/svg-animation","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ericwilligers:master","ref":"master","sha":"8c3039ff0acf563f34f0ac4750f42f4750f5d533","user":{"login":"ericwilligers","id":3839073,"avatar_url":"https://avatars.githubusercontent.com/u/3839073?","gravatar_id":"35fe9fccd3a02be6df3204fa9bb6184c","url":"https://api.github.com/users/ericwilligers","html_url":"https://github.com/ericwilligers","followers_url":"https://api.github.com/users/ericwilligers/followers","following_url":"https://api.github.com/users/ericwilligers/following{/other_user}","gists_url":"https://api.github.com/users/ericwilligers/gists{/gist_id}","starred_url":"https://api.github.com/users/ericwilligers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericwilligers/subscriptions","organizations_url":"https://api.github.com/users/ericwilligers/orgs","repos_url":"https://api.github.com/users/ericwilligers/repos","events_url":"https://api.github.com/users/ericwilligers/events{/privacy}","received_events_url":"https://api.github.com/users/ericwilligers/received_events","type":"User","site_admin":false},"repo":{"id":20704866,"name":"svg-animation","full_name":"ericwilligers/svg-animation","owner":{"login":"ericwilligers","id":3839073,"avatar_url":"https://avatars.githubusercontent.com/u/3839073?","gravatar_id":"35fe9fccd3a02be6df3204fa9bb6184c","url":"https://api.github.com/users/ericwilligers","html_url":"https://github.com/ericwilligers","followers_url":"https://api.github.com/users/ericwilligers/followers","following_url":"https://api.github.com/users/ericwilligers/following{/other_user}","gists_url":"https://api.github.com/users/ericwilligers/gists{/gist_id}","starred_url":"https://api.github.com/users/ericwilligers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericwilligers/subscriptions","organizations_url":"https://api.github.com/users/ericwilligers/orgs","repos_url":"https://api.github.com/users/ericwilligers/repos","events_url":"https://api.github.com/users/ericwilligers/events{/privacy}","received_events_url":"https://api.github.com/users/ericwilligers/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ericwilligers/svg-animation","description":"Implement SVG animation in JavaScript using Web Animations","fork":false,"url":"https://api.github.com/repos/ericwilligers/svg-animation","forks_url":"https://api.github.com/repos/ericwilligers/svg-animation/forks","keys_url":"https://api.github.com/repos/ericwilligers/svg-animation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ericwilligers/svg-animation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ericwilligers/svg-animation/teams","hooks_url":"https://api.github.com/repos/ericwilligers/svg-animation/hooks","issue_events_url":"https://api.github.com/repos/ericwilligers/svg-animation/issues/events{/number}","events_url":"https://api.github.com/repos/ericwilligers/svg-animation/events","assignees_url":"https://api.github.com/repos/ericwilligers/svg-animation/assignees{/user}","branches_url":"https://api.github.com/repos/ericwilligers/svg-animation/branches{/branch}","tags_url":"https://api.github.com/repos/ericwilligers/svg-animation/tags","blobs_url":"https://api.github.com/repos/ericwilligers/svg-animation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ericwilligers/svg-animation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ericwilligers/svg-animation/git/refs{/sha}","trees_url":"https://api.github.com/repos/ericwilligers/svg-animation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ericwilligers/svg-animation/statuses/{sha}","languages_url":"https://api.github.com/repos/ericwilligers/svg-animation/languages","stargazers_url":"https://api.github.com/repos/ericwilligers/svg-animation/stargazers","contributors_url":"https://api.github.com/repos/ericwilligers/svg-animation/contributors","subscribers_url":"https://api.github.com/repos/ericwilligers/svg-animation/subscribers","subscription_url":"https://api.github.com/repos/ericwilligers/svg-animation/subscription","commits_url":"https://api.github.com/repos/ericwilligers/svg-animation/commits{/sha}","git_commits_url":"https://api.github.com/repos/ericwilligers/svg-animation/git/commits{/sha}","comments_url":"https://api.github.com/repos/ericwilligers/svg-animation/comments{/number}","issue_comment_url":"https://api.github.com/repos/ericwilligers/svg-animation/issues/comments/{number}","contents_url":"https://api.github.com/repos/ericwilligers/svg-animation/contents/{+path}","compare_url":"https://api.github.com/repos/ericwilligers/svg-animation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ericwilligers/svg-animation/merges","archive_url":"https://api.github.com/repos/ericwilligers/svg-animation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ericwilligers/svg-animation/downloads","issues_url":"https://api.github.com/repos/ericwilligers/svg-animation/issues{/number}","pulls_url":"https://api.github.com/repos/ericwilligers/svg-animation/pulls{/number}","milestones_url":"https://api.github.com/repos/ericwilligers/svg-animation/milestones{/number}","notifications_url":"https://api.github.com/repos/ericwilligers/svg-animation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ericwilligers/svg-animation/labels{/name}","releases_url":"https://api.github.com/repos/ericwilligers/svg-animation/releases{/id}","created_at":"2014-06-10T23:08:42Z","updated_at":"2014-06-10T23:10:04Z","pushed_at":"2014-06-10T23:10:04Z","git_url":"git://github.com/ericwilligers/svg-animation.git","ssh_url":"git@github.com:ericwilligers/svg-animation.git","clone_url":"https://github.com/ericwilligers/svg-animation.git","svn_url":"https://github.com/ericwilligers/svg-animation","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ericwilligers/svg-animation/pulls/1"},"html":{"href":"https://github.com/ericwilligers/svg-animation/pull/1"},"issue":{"href":"https://api.github.com/repos/ericwilligers/svg-animation/issues/1"},"comments":{"href":"https://api.github.com/repos/ericwilligers/svg-animation/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/ericwilligers/svg-animation/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/ericwilligers/svg-animation/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ericwilligers/svg-animation/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/ericwilligers/svg-animation/statuses/abffec4ae1f500e23830929c02be8e8835a3ec34"}}}}