GitHub PullRequestEvent at 2014-10-28 15:01:26
Repository: mantisbt
Actor: vboctor
Payload: {"action":"closed","number":519,"pull_request":{"url":"https://api.github.com/repos/mantisbt/mantisbt/pulls/519","id":23334907,"html_url":"https://github.com/mantisbt/mantisbt/pull/519","diff_url":"https://github.com/mantisbt/mantisbt/pull/519.diff","patch_url":"https://github.com/mantisbt/mantisbt/pull/519.patch","issue_url":"https://api.github.com/repos/mantisbt/mantisbt/issues/519","number":519,"state":"closed","locked":false,"title":"Fix #15420: category not found denial of service","user":{"login":"vboctor","id":6446,"avatar_url":"https://avatars.githubusercontent.com/u/6446?v=2","gravatar_id":"","url":"https://api.github.com/users/vboctor","html_url":"https://github.com/vboctor","followers_url":"https://api.github.com/users/vboctor/followers","following_url":"https://api.github.com/users/vboctor/following{/other_user}","gists_url":"https://api.github.com/users/vboctor/gists{/gist_id}","starred_url":"https://api.github.com/users/vboctor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vboctor/subscriptions","organizations_url":"https://api.github.com/users/vboctor/orgs","repos_url":"https://api.github.com/users/vboctor/repos","events_url":"https://api.github.com/users/vboctor/events{/privacy}","received_events_url":"https://api.github.com/users/vboctor/received_events","type":"User","site_admin":false},"body":"There are several scenarios where we may end up in a denial-of-service because one issue has a category that no longer exists.  Some are known and some aren't.  Some also involve a race condition between validation and writing to database.\r\n\r\nSome of the known:\r\n- Move Issue with default category not existing.\r\n- Add Issue / Delete simultaneously (race condition - though we now have a check there).\r\n\r\nThis pull requests adopts the same model we use in handling unknown enumerations like status, severity, priority, etc.  It also removes related troubleshooting section and adds a config page check.","created_at":"2014-10-25T03:29:58Z","updated_at":"2014-10-28T15:01:26Z","closed_at":"2014-10-28T15:01:26Z","merged_at":null,"merge_commit_sha":"da70b3fe0af964ae4c67e95169501c9d92df9d30","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mantisbt/mantisbt/pulls/519/commits","review_comments_url":"https://api.github.com/repos/mantisbt/mantisbt/pulls/519/comments","review_comment_url":"https://api.github.com/repos/mantisbt/mantisbt/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mantisbt/mantisbt/issues/519/comments","statuses_url":"https://api.github.com/repos/mantisbt/mantisbt/statuses/1739ce03d5a489b34d0ea389bb05d2498e5fb1b0","head":{"label":"vboctor:Issue15420_category_error","ref":"Issue15420_category_error","sha":"1739ce03d5a489b34d0ea389bb05d2498e5fb1b0","user":{"login":"vboctor","id":6446,"avatar_url":"https://avatars.githubusercontent.com/u/6446?v=2","gravatar_id":"","url":"https://api.github.com/users/vboctor","html_url":"https://github.com/vboctor","followers_url":"https://api.github.com/users/vboctor/followers","following_url":"https://api.github.com/users/vboctor/following{/other_user}","gists_url":"https://api.github.com/users/vboctor/gists{/gist_id}","starred_url":"https://api.github.com/users/vboctor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vboctor/subscriptions","organizations_url":"https://api.github.com/users/vboctor/orgs","repos_url":"https://api.github.com/users/vboctor/repos","events_url":"https://api.github.com/users/vboctor/events{/privacy}","received_events_url":"https://api.github.com/users/vboctor/received_events","type":"User","site_admin":false},"repo":{"id":9786963,"name":"mantisbt","full_name":"vboctor/mantisbt","owner":{"login":"vboctor","id":6446,"avatar_url":"https://avatars.githubusercontent.com/u/6446?v=2","gravatar_id":"","url":"https://api.github.com/users/vboctor","html_url":"https://github.com/vboctor","followers_url":"https://api.github.com/users/vboctor/followers","following_url":"https://api.github.com/users/vboctor/following{/other_user}","gists_url":"https://api.github.com/users/vboctor/gists{/gist_id}","starred_url":"https://api.github.com/users/vboctor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vboctor/subscriptions","organizations_url":"https://api.github.com/users/vboctor/orgs","repos_url":"https://api.github.com/users/vboctor/repos","events_url":"https://api.github.com/users/vboctor/events{/privacy}","received_events_url":"https://api.github.com/users/vboctor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vboctor/mantisbt","description":"Mantis Bug Tracker (MantisBT)","fork":true,"url":"https://api.github.com/repos/vboctor/mantisbt","forks_url":"https://api.github.com/repos/vboctor/mantisbt/forks","keys_url":"https://api.github.com/repos/vboctor/mantisbt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vboctor/mantisbt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vboctor/mantisbt/teams","hooks_url":"https://api.github.com/repos/vboctor/mantisbt/hooks","issue_events_url":"https://api.github.com/repos/vboctor/mantisbt/issues/events{/number}","events_url":"https://api.github.com/repos/vboctor/mantisbt/events","assignees_url":"https://api.github.com/repos/vboctor/mantisbt/assignees{/user}","branches_url":"https://api.github.com/repos/vboctor/mantisbt/branches{/branch}","tags_url":"https://api.github.com/repos/vboctor/mantisbt/tags","blobs_url":"https://api.github.com/repos/vboctor/mantisbt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vboctor/mantisbt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vboctor/mantisbt/git/refs{/sha}","trees_url":"https://api.github.com/repos/vboctor/mantisbt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vboctor/mantisbt/statuses/{sha}","languages_url":"https://api.github.com/repos/vboctor/mantisbt/languages","stargazers_url":"https://api.github.com/repos/vboctor/mantisbt/stargazers","contributors_url":"https://api.github.com/repos/vboctor/mantisbt/contributors","subscribers_url":"https://api.github.com/repos/vboctor/mantisbt/subscribers","subscription_url":"https://api.github.com/repos/vboctor/mantisbt/subscription","commits_url":"https://api.github.com/repos/vboctor/mantisbt/commits{/sha}","git_commits_url":"https://api.github.com/repos/vboctor/mantisbt/git/commits{/sha}","comments_url":"https://api.github.com/repos/vboctor/mantisbt/comments{/number}","issue_comment_url":"https://api.github.com/repos/vboctor/mantisbt/issues/comments/{number}","contents_url":"https://api.github.com/repos/vboctor/mantisbt/contents/{+path}","compare_url":"https://api.github.com/repos/vboctor/mantisbt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vboctor/mantisbt/merges","archive_url":"https://api.github.com/repos/vboctor/mantisbt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vboctor/mantisbt/downloads","issues_url":"https://api.github.com/repos/vboctor/mantisbt/issues{/number}","pulls_url":"https://api.github.com/repos/vboctor/mantisbt/pulls{/number}","milestones_url":"https://api.github.com/repos/vboctor/mantisbt/milestones{/number}","notifications_url":"https://api.github.com/repos/vboctor/mantisbt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vboctor/mantisbt/labels{/name}","releases_url":"https://api.github.com/repos/vboctor/mantisbt/releases{/id}","created_at":"2013-05-01T06:35:52Z","updated_at":"2014-06-10T01:43:46Z","pushed_at":"2014-10-28T14:33:05Z","git_url":"git://github.com/vboctor/mantisbt.git","ssh_url":"git@github.com:vboctor/mantisbt.git","clone_url":"https://github.com/vboctor/mantisbt.git","svn_url":"https://github.com/vboctor/mantisbt","homepage":"http://www.mantisbt.org","size":61801,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master-1.2.x"}},"base":{"label":"mantisbt:master","ref":"master","sha":"487ef2ff3cc35f44c13214c337e8c5c1d5800694","user":{"login":"mantisbt","id":318027,"avatar_url":"https://avatars.githubusercontent.com/u/318027?v=2","gravatar_id":"","url":"https://api.github.com/users/mantisbt","html_url":"https://github.com/mantisbt","followers_url":"https://api.github.com/users/mantisbt/followers","following_url":"https://api.github.com/users/mantisbt/following{/other_user}","gists_url":"https://api.github.com/users/mantisbt/gists{/gist_id}","starred_url":"https://api.github.com/users/mantisbt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantisbt/subscriptions","organizations_url":"https://api.github.com/users/mantisbt/orgs","repos_url":"https://api.github.com/users/mantisbt/repos","events_url":"https://api.github.com/users/mantisbt/events{/privacy}","received_events_url":"https://api.github.com/users/mantisbt/received_events","type":"Organization","site_admin":false},"repo":{"id":747755,"name":"mantisbt","full_name":"mantisbt/mantisbt","owner":{"login":"mantisbt","id":318027,"avatar_url":"https://avatars.githubusercontent.com/u/318027?v=2","gravatar_id":"","url":"https://api.github.com/users/mantisbt","html_url":"https://github.com/mantisbt","followers_url":"https://api.github.com/users/mantisbt/followers","following_url":"https://api.github.com/users/mantisbt/following{/other_user}","gists_url":"https://api.github.com/users/mantisbt/gists{/gist_id}","starred_url":"https://api.github.com/users/mantisbt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantisbt/subscriptions","organizations_url":"https://api.github.com/users/mantisbt/orgs","repos_url":"https://api.github.com/users/mantisbt/repos","events_url":"https://api.github.com/users/mantisbt/events{/privacy}","received_events_url":"https://api.github.com/users/mantisbt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mantisbt/mantisbt","description":"Mantis Bug Tracker (MantisBT)","fork":false,"url":"https://api.github.com/repos/mantisbt/mantisbt","forks_url":"https://api.github.com/repos/mantisbt/mantisbt/forks","keys_url":"https://api.github.com/repos/mantisbt/mantisbt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mantisbt/mantisbt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mantisbt/mantisbt/teams","hooks_url":"https://api.github.com/repos/mantisbt/mantisbt/hooks","issue_events_url":"https://api.github.com/repos/mantisbt/mantisbt/issues/events{/number}","events_url":"https://api.github.com/repos/mantisbt/mantisbt/events","assignees_url":"https://api.github.com/repos/mantisbt/mantisbt/assignees{/user}","branches_url":"https://api.github.com/repos/mantisbt/mantisbt/branches{/branch}","tags_url":"https://api.github.com/repos/mantisbt/mantisbt/tags","blobs_url":"https://api.github.com/repos/mantisbt/mantisbt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mantisbt/mantisbt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mantisbt/mantisbt/git/refs{/sha}","trees_url":"https://api.github.com/repos/mantisbt/mantisbt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mantisbt/mantisbt/statuses/{sha}","languages_url":"https://api.github.com/repos/mantisbt/mantisbt/languages","stargazers_url":"https://api.github.com/repos/mantisbt/mantisbt/stargazers","contributors_url":"https://api.github.com/repos/mantisbt/mantisbt/contributors","subscribers_url":"https://api.github.com/repos/mantisbt/mantisbt/subscribers","subscription_url":"https://api.github.com/repos/mantisbt/mantisbt/subscription","commits_url":"https://api.github.com/repos/mantisbt/mantisbt/commits{/sha}","git_commits_url":"https://api.github.com/repos/mantisbt/mantisbt/git/commits{/sha}","comments_url":"https://api.github.com/repos/mantisbt/mantisbt/comments{/number}","issue_comment_url":"https://api.github.com/repos/mantisbt/mantisbt/issues/comments/{number}","contents_url":"https://api.github.com/repos/mantisbt/mantisbt/contents/{+path}","compare_url":"https://api.github.com/repos/mantisbt/mantisbt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mantisbt/mantisbt/merges","archive_url":"https://api.github.com/repos/mantisbt/mantisbt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mantisbt/mantisbt/downloads","issues_url":"https://api.github.com/repos/mantisbt/mantisbt/issues{/number}","pulls_url":"https://api.github.com/repos/mantisbt/mantisbt/pulls{/number}","milestones_url":"https://api.github.com/repos/mantisbt/mantisbt/milestones{/number}","notifications_url":"https://api.github.com/repos/mantisbt/mantisbt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mantisbt/mantisbt/labels{/name}","releases_url":"https://api.github.com/repos/mantisbt/mantisbt/releases{/id}","created_at":"2010-06-29T21:42:07Z","updated_at":"2014-10-27T07:03:50Z","pushed_at":"2014-10-28T14:59:16Z","git_url":"git://github.com/mantisbt/mantisbt.git","ssh_url":"git@github.com:mantisbt/mantisbt.git","clone_url":"https://github.com/mantisbt/mantisbt.git","svn_url":"https://github.com/mantisbt/mantisbt","homepage":"http://www.mantisbt.org","size":63442,"stargazers_count":405,"watchers_count":405,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":223,"mirror_url":null,"open_issues_count":44,"forks":223,"open_issues":44,"watchers":405,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mantisbt/mantisbt/pulls/519"},"html":{"href":"https://github.com/mantisbt/mantisbt/pull/519"},"issue":{"href":"https://api.github.com/repos/mantisbt/mantisbt/issues/519"},"comments":{"href":"https://api.github.com/repos/mantisbt/mantisbt/issues/519/comments"},"review_comments":{"href":"https://api.github.com/repos/mantisbt/mantisbt/pulls/519/comments"},"review_comment":{"href":"https://api.github.com/repos/mantisbt/mantisbt/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mantisbt/mantisbt/pulls/519/commits"},"statuses":{"href":"https://api.github.com/repos/mantisbt/mantisbt/statuses/1739ce03d5a489b34d0ea389bb05d2498e5fb1b0"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":3,"review_comments":1,"commits":9,"additions":66,"deletions":125,"changed_files":13}}