GitHub PullRequestReviewCommentEvent at 2014-02-13 18:23:37
Repository: django
Actor: timgraham
Payload: {"comment":{"url":"https://api.github.com/repos/django/django/pulls/comments/9720368","id":9720368,"diff_hunk":"@@ -383,7 +383,7 @@ def _reverse_with_prefix(self, lookup_view, _prefix, *args, **kwargs):\n \n         try:","path":"django/core/urlresolvers.py","position":2,"original_position":2,"commit_id":"a680533c5ba55f650c5f5d9a3eae0d116eb430a2","original_commit_id":"a680533c5ba55f650c5f5d9a3eae0d116eb430a2","user":{"login":"timgraham","id":411869,"avatar_url":"https://gravatar.com/avatar/fa170777273ca7b235bdde7d80e9f8a6?d=https%3A%2F%2Fidenticons.github.com%2F21b737a0a0ea61dbaa744cbe9d162dd9.png&r=x","gravatar_id":"fa170777273ca7b235bdde7d80e9f8a6","url":"https://api.github.com/users/timgraham","html_url":"https://github.com/timgraham","followers_url":"https://api.github.com/users/timgraham/followers","following_url":"https://api.github.com/users/timgraham/following{/other_user}","gists_url":"https://api.github.com/users/timgraham/gists{/gist_id}","starred_url":"https://api.github.com/users/timgraham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timgraham/subscriptions","organizations_url":"https://api.github.com/users/timgraham/orgs","repos_url":"https://api.github.com/users/timgraham/repos","events_url":"https://api.github.com/users/timgraham/events{/privacy}","received_events_url":"https://api.github.com/users/timgraham/received_events","type":"User","site_admin":false},"body":"I think it might be better to explicitly handle relative URLs, something like this, right before this try/except.\r\n```\r\n# Relative URLs\r\nif isinstance(lookup_view, six.string_types) and lookup_view.startswith('../'):\r\n    return lookup_view\r\n```\r\nWhat do you think?","created_at":"2014-02-13T18:23:37Z","updated_at":"2014-02-13T18:23:37Z","html_url":"https://github.com/django/django/pull/1670#discussion_r9720368","pull_request_url":"https://api.github.com/repos/django/django/pulls/1670","_links":{"self":{"href":"https://api.github.com/repos/django/django/pulls/comments/9720368"},"html":{"href":"https://github.com/django/django/pull/1670#discussion_r9720368"},"pull_request":{"href":"https://api.github.com/repos/django/django/pulls/1670"}}}}