GitHub PullRequestReviewCommentEvent at 2014-11-04 01:08:16
Repository: opsicle
Actor: ChrisArcand
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/sportngin/opsicle/pulls/comments/19779880","id":19779880,"diff_hunk":"@@ -6,7 +6,7 @@ def launch_stack_monitor(response, options={})\n         open_deploy(response[:deployment_id])\n       elsif options[:monitor] # Default option\n         Output.say_verbose \"Starting Stack Monitor...\"\n-        @monitor = Opsicle::Monitor::App.new(@environment, options)\n+        @monitor = Opsicle::Monitor::App.new(@environment, parse_options(response, options))","path":"lib/opsicle/deploy_helper.rb","position":5,"original_position":5,"commit_id":"84f3e9f164f09f37c475d61116a7e5793202b5cd","original_commit_id":"84f3e9f164f09f37c475d61116a7e5793202b5cd","user":{"login":"ChrisArcand","id":2430490,"avatar_url":"https://avatars.githubusercontent.com/u/2430490?v=2","gravatar_id":"","url":"https://api.github.com/users/ChrisArcand","html_url":"https://github.com/ChrisArcand","followers_url":"https://api.github.com/users/ChrisArcand/followers","following_url":"https://api.github.com/users/ChrisArcand/following{/other_user}","gists_url":"https://api.github.com/users/ChrisArcand/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisArcand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisArcand/subscriptions","organizations_url":"https://api.github.com/users/ChrisArcand/orgs","repos_url":"https://api.github.com/users/ChrisArcand/repos","events_url":"https://api.github.com/users/ChrisArcand/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisArcand/received_events","type":"User","site_admin":false},"body":"s/minimizing methods/being more choosy about adding methods than I think most people are/","created_at":"2014-11-04T01:08:16Z","updated_at":"2014-11-04T01:08:16Z","html_url":"https://github.com/sportngin/opsicle/pull/64#discussion_r19779880","pull_request_url":"https://api.github.com/repos/sportngin/opsicle/pulls/64","_links":{"self":{"href":"https://api.github.com/repos/sportngin/opsicle/pulls/comments/19779880"},"html":{"href":"https://github.com/sportngin/opsicle/pull/64#discussion_r19779880"},"pull_request":{"href":"https://api.github.com/repos/sportngin/opsicle/pulls/64"}}},"pull_request":{"url":"https://api.github.com/repos/sportngin/opsicle/pulls/64","id":23803114,"html_url":"https://github.com/sportngin/opsicle/pull/64","diff_url":"https://github.com/sportngin/opsicle/pull/64.diff","patch_url":"https://github.com/sportngin/opsicle/pull/64.patch","issue_url":"https://api.github.com/repos/sportngin/opsicle/issues/64","number":64,"state":"open","locked":false,"title":"One push deploys","user":{"login":"NickLaMuro","id":314014,"avatar_url":"https://avatars.githubusercontent.com/u/314014?v=2","gravatar_id":"","url":"https://api.github.com/users/NickLaMuro","html_url":"https://github.com/NickLaMuro","followers_url":"https://api.github.com/users/NickLaMuro/followers","following_url":"https://api.github.com/users/NickLaMuro/following{/other_user}","gists_url":"https://api.github.com/users/NickLaMuro/gists{/gist_id}","starred_url":"https://api.github.com/users/NickLaMuro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NickLaMuro/subscriptions","organizations_url":"https://api.github.com/users/NickLaMuro/orgs","repos_url":"https://api.github.com/users/NickLaMuro/repos","events_url":"https://api.github.com/users/NickLaMuro/events{/privacy}","received_events_url":"https://api.github.com/users/NickLaMuro/received_events","type":"User","site_admin":false},"body":"This will make it so the monitor will exit on completion of the deploy that was executed.  It will exit with a non-zero exit status if the deploy failed, otherwise it will exit normally.\r\n\r\nIt should be noted that this is hooking up a second poller to the monitor (conditionally) that does the exact same API call that is done to populate the data for the monitor.  There might be a clever way that I can share that data, but it was too nested in the spies and such of the monitor lib to try and do so for this feature.  I fully expect that AWS can handle the traffic though.","created_at":"2014-11-04T00:30:10Z","updated_at":"2014-11-04T01:08:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb7fb0635642f55bee9c81ad45a878b1f6c704f1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sportngin/opsicle/pulls/64/commits","review_comments_url":"https://api.github.com/repos/sportngin/opsicle/pulls/64/comments","review_comment_url":"https://api.github.com/repos/sportngin/opsicle/pulls/comments/{number}","comments_url":"https://api.github.com/repos/sportngin/opsicle/issues/64/comments","statuses_url":"https://api.github.com/repos/sportngin/opsicle/statuses/84f3e9f164f09f37c475d61116a7e5793202b5cd","head":{"label":"sportngin:one-push-deploys","ref":"one-push-deploys","sha":"84f3e9f164f09f37c475d61116a7e5793202b5cd","user":{"login":"sportngin","id":3728684,"avatar_url":"https://avatars.githubusercontent.com/u/3728684?v=2","gravatar_id":"","url":"https://api.github.com/users/sportngin","html_url":"https://github.com/sportngin","followers_url":"https://api.github.com/users/sportngin/followers","following_url":"https://api.github.com/users/sportngin/following{/other_user}","gists_url":"https://api.github.com/users/sportngin/gists{/gist_id}","starred_url":"https://api.github.com/users/sportngin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sportngin/subscriptions","organizations_url":"https://api.github.com/users/sportngin/orgs","repos_url":"https://api.github.com/users/sportngin/repos","events_url":"https://api.github.com/users/sportngin/events{/privacy}","received_events_url":"https://api.github.com/users/sportngin/received_events","type":"Organization","site_admin":false},"repo":{"id":14806020,"name":"opsicle","full_name":"sportngin/opsicle","owner":{"login":"sportngin","id":3728684,"avatar_url":"https://avatars.githubusercontent.com/u/3728684?v=2","gravatar_id":"","url":"https://api.github.com/users/sportngin","html_url":"https://github.com/sportngin","followers_url":"https://api.github.com/users/sportngin/followers","following_url":"https://api.github.com/users/sportngin/following{/other_user}","gists_url":"https://api.github.com/users/sportngin/gists{/gist_id}","starred_url":"https://api.github.com/users/sportngin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sportngin/subscriptions","organizations_url":"https://api.github.com/users/sportngin/orgs","repos_url":"https://api.github.com/users/sportngin/repos","events_url":"https://api.github.com/users/sportngin/events{/privacy}","received_events_url":"https://api.github.com/users/sportngin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sportngin/opsicle","description":"","fork":false,"url":"https://api.github.com/repos/sportngin/opsicle","forks_url":"https://api.github.com/repos/sportngin/opsicle/forks","keys_url":"https://api.github.com/repos/sportngin/opsicle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sportngin/opsicle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sportngin/opsicle/teams","hooks_url":"https://api.github.com/repos/sportngin/opsicle/hooks","issue_events_url":"https://api.github.com/repos/sportngin/opsicle/issues/events{/number}","events_url":"https://api.github.com/repos/sportngin/opsicle/events","assignees_url":"https://api.github.com/repos/sportngin/opsicle/assignees{/user}","branches_url":"https://api.github.com/repos/sportngin/opsicle/branches{/branch}","tags_url":"https://api.github.com/repos/sportngin/opsicle/tags","blobs_url":"https://api.github.com/repos/sportngin/opsicle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sportngin/opsicle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sportngin/opsicle/git/refs{/sha}","trees_url":"https://api.github.com/repos/sportngin/opsicle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sportngin/opsicle/statuses/{sha}","languages_url":"https://api.github.com/repos/sportngin/opsicle/languages","stargazers_url":"https://api.github.com/repos/sportngin/opsicle/stargazers","contributors_url":"https://api.github.com/repos/sportngin/opsicle/contributors","subscribers_url":"https://api.github.com/repos/sportngin/opsicle/subscribers","subscription_url":"https://api.github.com/repos/sportngin/opsicle/subscription","commits_url":"https://api.github.com/repos/sportngin/opsicle/commits{/sha}","git_commits_url":"https://api.github.com/repos/sportngin/opsicle/git/commits{/sha}","comments_url":"https://api.github.com/repos/sportngin/opsicle/comments{/number}","issue_comment_url":"https://api.github.com/repos/sportngin/opsicle/issues/comments/{number}","contents_url":"https://api.github.com/repos/sportngin/opsicle/contents/{+path}","compare_url":"https://api.github.com/repos/sportngin/opsicle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sportngin/opsicle/merges","archive_url":"https://api.github.com/repos/sportngin/opsicle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sportngin/opsicle/downloads","issues_url":"https://api.github.com/repos/sportngin/opsicle/issues{/number}","pulls_url":"https://api.github.com/repos/sportngin/opsicle/pulls{/number}","milestones_url":"https://api.github.com/repos/sportngin/opsicle/milestones{/number}","notifications_url":"https://api.github.com/repos/sportngin/opsicle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sportngin/opsicle/labels{/name}","releases_url":"https://api.github.com/repos/sportngin/opsicle/releases{/id}","created_at":"2013-11-29T16:34:07Z","updated_at":"2014-09-10T18:02:52Z","pushed_at":"2014-11-04T00:25:29Z","git_url":"git://github.com/sportngin/opsicle.git","ssh_url":"git@github.com:sportngin/opsicle.git","clone_url":"https://github.com/sportngin/opsicle.git","svn_url":"https://github.com/sportngin/opsicle","homepage":null,"size":2694,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":15,"forks":3,"open_issues":15,"watchers":3,"default_branch":"master"}},"base":{"label":"sportngin:master","ref":"master","sha":"555f765a2c10305090af8c8f796046be41bea7b4","user":{"login":"sportngin","id":3728684,"avatar_url":"https://avatars.githubusercontent.com/u/3728684?v=2","gravatar_id":"","url":"https://api.github.com/users/sportngin","html_url":"https://github.com/sportngin","followers_url":"https://api.github.com/users/sportngin/followers","following_url":"https://api.github.com/users/sportngin/following{/other_user}","gists_url":"https://api.github.com/users/sportngin/gists{/gist_id}","starred_url":"https://api.github.com/users/sportngin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sportngin/subscriptions","organizations_url":"https://api.github.com/users/sportngin/orgs","repos_url":"https://api.github.com/users/sportngin/repos","events_url":"https://api.github.com/users/sportngin/events{/privacy}","received_events_url":"https://api.github.com/users/sportngin/received_events","type":"Organization","site_admin":false},"repo":{"id":14806020,"name":"opsicle","full_name":"sportngin/opsicle","owner":{"login":"sportngin","id":3728684,"avatar_url":"https://avatars.githubusercontent.com/u/3728684?v=2","gravatar_id":"","url":"https://api.github.com/users/sportngin","html_url":"https://github.com/sportngin","followers_url":"https://api.github.com/users/sportngin/followers","following_url":"https://api.github.com/users/sportngin/following{/other_user}","gists_url":"https://api.github.com/users/sportngin/gists{/gist_id}","starred_url":"https://api.github.com/users/sportngin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sportngin/subscriptions","organizations_url":"https://api.github.com/users/sportngin/orgs","repos_url":"https://api.github.com/users/sportngin/repos","events_url":"https://api.github.com/users/sportngin/events{/privacy}","received_events_url":"https://api.github.com/users/sportngin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sportngin/opsicle","description":"","fork":false,"url":"https://api.github.com/repos/sportngin/opsicle","forks_url":"https://api.github.com/repos/sportngin/opsicle/forks","keys_url":"https://api.github.com/repos/sportngin/opsicle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sportngin/opsicle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sportngin/opsicle/teams","hooks_url":"https://api.github.com/repos/sportngin/opsicle/hooks","issue_events_url":"https://api.github.com/repos/sportngin/opsicle/issues/events{/number}","events_url":"https://api.github.com/repos/sportngin/opsicle/events","assignees_url":"https://api.github.com/repos/sportngin/opsicle/assignees{/user}","branches_url":"https://api.github.com/repos/sportngin/opsicle/branches{/branch}","tags_url":"https://api.github.com/repos/sportngin/opsicle/tags","blobs_url":"https://api.github.com/repos/sportngin/opsicle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sportngin/opsicle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sportngin/opsicle/git/refs{/sha}","trees_url":"https://api.github.com/repos/sportngin/opsicle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sportngin/opsicle/statuses/{sha}","languages_url":"https://api.github.com/repos/sportngin/opsicle/languages","stargazers_url":"https://api.github.com/repos/sportngin/opsicle/stargazers","contributors_url":"https://api.github.com/repos/sportngin/opsicle/contributors","subscribers_url":"https://api.github.com/repos/sportngin/opsicle/subscribers","subscription_url":"https://api.github.com/repos/sportngin/opsicle/subscription","commits_url":"https://api.github.com/repos/sportngin/opsicle/commits{/sha}","git_commits_url":"https://api.github.com/repos/sportngin/opsicle/git/commits{/sha}","comments_url":"https://api.github.com/repos/sportngin/opsicle/comments{/number}","issue_comment_url":"https://api.github.com/repos/sportngin/opsicle/issues/comments/{number}","contents_url":"https://api.github.com/repos/sportngin/opsicle/contents/{+path}","compare_url":"https://api.github.com/repos/sportngin/opsicle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sportngin/opsicle/merges","archive_url":"https://api.github.com/repos/sportngin/opsicle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sportngin/opsicle/downloads","issues_url":"https://api.github.com/repos/sportngin/opsicle/issues{/number}","pulls_url":"https://api.github.com/repos/sportngin/opsicle/pulls{/number}","milestones_url":"https://api.github.com/repos/sportngin/opsicle/milestones{/number}","notifications_url":"https://api.github.com/repos/sportngin/opsicle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sportngin/opsicle/labels{/name}","releases_url":"https://api.github.com/repos/sportngin/opsicle/releases{/id}","created_at":"2013-11-29T16:34:07Z","updated_at":"2014-09-10T18:02:52Z","pushed_at":"2014-11-04T00:25:29Z","git_url":"git://github.com/sportngin/opsicle.git","ssh_url":"git@github.com:sportngin/opsicle.git","clone_url":"https://github.com/sportngin/opsicle.git","svn_url":"https://github.com/sportngin/opsicle","homepage":null,"size":2694,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":15,"forks":3,"open_issues":15,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sportngin/opsicle/pulls/64"},"html":{"href":"https://github.com/sportngin/opsicle/pull/64"},"issue":{"href":"https://api.github.com/repos/sportngin/opsicle/issues/64"},"comments":{"href":"https://api.github.com/repos/sportngin/opsicle/issues/64/comments"},"review_comments":{"href":"https://api.github.com/repos/sportngin/opsicle/pulls/64/comments"},"review_comment":{"href":"https://api.github.com/repos/sportngin/opsicle/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/sportngin/opsicle/pulls/64/commits"},"statuses":{"href":"https://api.github.com/repos/sportngin/opsicle/statuses/84f3e9f164f09f37c475d61116a7e5793202b5cd"}}}}