GitHub PullRequestReviewCommentEvent at 2014-10-20 16:57:37
Repository: ember-qunit
Actor: igorT
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/rwjblue/ember-qunit/pulls/comments/19097490","id":19097490,"diff_hunk":"@@ -0,0 +1,53 @@\n+import { moduleFor, test } from 'ember-qunit';\n+import { setResolverRegistry } from 'tests/test-support/resolver';\n+\n+function setupRegistry() {\n+  setResolverRegistry({\n+    'component:x-foo': Ember.Component.extend()\n+  });\n+}\n+\n+var a = 0;","path":"tests/module-for-test.js","position":10,"original_position":10,"commit_id":"89ea8e2069a1b80f77958f3207e01c9fb157c812","original_commit_id":"89ea8e2069a1b80f77958f3207e01c9fb157c812","user":{"login":"igorT","id":715175,"avatar_url":"https://avatars.githubusercontent.com/u/715175?v=2","gravatar_id":"","url":"https://api.github.com/users/igorT","html_url":"https://github.com/igorT","followers_url":"https://api.github.com/users/igorT/followers","following_url":"https://api.github.com/users/igorT/following{/other_user}","gists_url":"https://api.github.com/users/igorT/gists{/gist_id}","starred_url":"https://api.github.com/users/igorT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igorT/subscriptions","organizations_url":"https://api.github.com/users/igorT/orgs","repos_url":"https://api.github.com/users/igorT/repos","events_url":"https://api.github.com/users/igorT/events{/privacy}","received_events_url":"https://api.github.com/users/igorT/received_events","type":"User","site_admin":false},"body":"Any chance a and b could be renamed? Its pretty hard to follow the test logic with all the += and -=","created_at":"2014-10-20T16:57:37Z","updated_at":"2014-10-20T16:57:37Z","html_url":"https://github.com/rwjblue/ember-qunit/pull/99#discussion_r19097490","pull_request_url":"https://api.github.com/repos/rwjblue/ember-qunit/pulls/99","_links":{"self":{"href":"https://api.github.com/repos/rwjblue/ember-qunit/pulls/comments/19097490"},"html":{"href":"https://github.com/rwjblue/ember-qunit/pull/99#discussion_r19097490"},"pull_request":{"href":"https://api.github.com/repos/rwjblue/ember-qunit/pulls/99"}}},"pull_request":{"url":"https://api.github.com/repos/rwjblue/ember-qunit/pulls/99","id":23026228,"html_url":"https://github.com/rwjblue/ember-qunit/pull/99","diff_url":"https://github.com/rwjblue/ember-qunit/pull/99.diff","patch_url":"https://github.com/rwjblue/ember-qunit/pull/99.patch","issue_url":"https://api.github.com/repos/rwjblue/ember-qunit/issues/99","number":99,"state":"open","locked":false,"title":"Refactor to use the extracted lib ember-test-helpers","user":{"login":"dgeb","id":29122,"avatar_url":"https://avatars.githubusercontent.com/u/29122?v=2","gravatar_id":"","url":"https://api.github.com/users/dgeb","html_url":"https://github.com/dgeb","followers_url":"https://api.github.com/users/dgeb/followers","following_url":"https://api.github.com/users/dgeb/following{/other_user}","gists_url":"https://api.github.com/users/dgeb/gists{/gist_id}","starred_url":"https://api.github.com/users/dgeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgeb/subscriptions","organizations_url":"https://api.github.com/users/dgeb/orgs","repos_url":"https://api.github.com/users/dgeb/repos","events_url":"https://api.github.com/users/dgeb/events{/privacy}","received_events_url":"https://api.github.com/users/dgeb/received_events","type":"User","site_admin":false},"body":"This PR extracts the core logic from ember-qunit into [switchfly/ember-test-helpers](https://github.com/switchfly/ember-test-helpers). This library now simply wraps ember-test-helpers with QUnit-specific helpers. This approach allows other libraries, such as [ember-mocha](https://github.com/switchfly/ember-mocha), to share the same internals.\r\n\r\nThis PR also removes the `dist/` dir. @rwjblue favors creating a separate bower repo for distribution.\r\n\r\nAlso, karma has been replaced with testem to be consistent with ember-cli and its related libraries.\r\n\r\nCredit for backing all of this work, including the development of ember-test-helpers and ember-mocha, goes to my client [Switchfly](https://github.com/switchfly). Many thanks to them!","created_at":"2014-10-20T16:16:24Z","updated_at":"2014-10-20T16:57:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4004726c2b33b5b1c88b717eef3488eb2bf3dee1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rwjblue/ember-qunit/pulls/99/commits","review_comments_url":"https://api.github.com/repos/rwjblue/ember-qunit/pulls/99/comments","review_comment_url":"https://api.github.com/repos/rwjblue/ember-qunit/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rwjblue/ember-qunit/issues/99/comments","statuses_url":"https://api.github.com/repos/rwjblue/ember-qunit/statuses/89ea8e2069a1b80f77958f3207e01c9fb157c812","head":{"label":"dgeb:separate-test-helpers","ref":"separate-test-helpers","sha":"89ea8e2069a1b80f77958f3207e01c9fb157c812","user":{"login":"dgeb","id":29122,"avatar_url":"https://avatars.githubusercontent.com/u/29122?v=2","gravatar_id":"","url":"https://api.github.com/users/dgeb","html_url":"https://github.com/dgeb","followers_url":"https://api.github.com/users/dgeb/followers","following_url":"https://api.github.com/users/dgeb/following{/other_user}","gists_url":"https://api.github.com/users/dgeb/gists{/gist_id}","starred_url":"https://api.github.com/users/dgeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgeb/subscriptions","organizations_url":"https://api.github.com/users/dgeb/orgs","repos_url":"https://api.github.com/users/dgeb/repos","events_url":"https://api.github.com/users/dgeb/events{/privacy}","received_events_url":"https://api.github.com/users/dgeb/received_events","type":"User","site_admin":false},"repo":{"id":24118496,"name":"ember-qunit","full_name":"dgeb/ember-qunit","owner":{"login":"dgeb","id":29122,"avatar_url":"https://avatars.githubusercontent.com/u/29122?v=2","gravatar_id":"","url":"https://api.github.com/users/dgeb","html_url":"https://github.com/dgeb","followers_url":"https://api.github.com/users/dgeb/followers","following_url":"https://api.github.com/users/dgeb/following{/other_user}","gists_url":"https://api.github.com/users/dgeb/gists{/gist_id}","starred_url":"https://api.github.com/users/dgeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgeb/subscriptions","organizations_url":"https://api.github.com/users/dgeb/orgs","repos_url":"https://api.github.com/users/dgeb/repos","events_url":"https://api.github.com/users/dgeb/events{/privacy}","received_events_url":"https://api.github.com/users/dgeb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dgeb/ember-qunit","description":"unit test helpers for ember","fork":true,"url":"https://api.github.com/repos/dgeb/ember-qunit","forks_url":"https://api.github.com/repos/dgeb/ember-qunit/forks","keys_url":"https://api.github.com/repos/dgeb/ember-qunit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dgeb/ember-qunit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dgeb/ember-qunit/teams","hooks_url":"https://api.github.com/repos/dgeb/ember-qunit/hooks","issue_events_url":"https://api.github.com/repos/dgeb/ember-qunit/issues/events{/number}","events_url":"https://api.github.com/repos/dgeb/ember-qunit/events","assignees_url":"https://api.github.com/repos/dgeb/ember-qunit/assignees{/user}","branches_url":"https://api.github.com/repos/dgeb/ember-qunit/branches{/branch}","tags_url":"https://api.github.com/repos/dgeb/ember-qunit/tags","blobs_url":"https://api.github.com/repos/dgeb/ember-qunit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dgeb/ember-qunit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dgeb/ember-qunit/git/refs{/sha}","trees_url":"https://api.github.com/repos/dgeb/ember-qunit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dgeb/ember-qunit/statuses/{sha}","languages_url":"https://api.github.com/repos/dgeb/ember-qunit/languages","stargazers_url":"https://api.github.com/repos/dgeb/ember-qunit/stargazers","contributors_url":"https://api.github.com/repos/dgeb/ember-qunit/contributors","subscribers_url":"https://api.github.com/repos/dgeb/ember-qunit/subscribers","subscription_url":"https://api.github.com/repos/dgeb/ember-qunit/subscription","commits_url":"https://api.github.com/repos/dgeb/ember-qunit/commits{/sha}","git_commits_url":"https://api.github.com/repos/dgeb/ember-qunit/git/commits{/sha}","comments_url":"https://api.github.com/repos/dgeb/ember-qunit/comments{/number}","issue_comment_url":"https://api.github.com/repos/dgeb/ember-qunit/issues/comments/{number}","contents_url":"https://api.github.com/repos/dgeb/ember-qunit/contents/{+path}","compare_url":"https://api.github.com/repos/dgeb/ember-qunit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dgeb/ember-qunit/merges","archive_url":"https://api.github.com/repos/dgeb/ember-qunit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dgeb/ember-qunit/downloads","issues_url":"https://api.github.com/repos/dgeb/ember-qunit/issues{/number}","pulls_url":"https://api.github.com/repos/dgeb/ember-qunit/pulls{/number}","milestones_url":"https://api.github.com/repos/dgeb/ember-qunit/milestones{/number}","notifications_url":"https://api.github.com/repos/dgeb/ember-qunit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dgeb/ember-qunit/labels{/name}","releases_url":"https://api.github.com/repos/dgeb/ember-qunit/releases{/id}","created_at":"2014-09-16T21:30:29Z","updated_at":"2014-09-24T15:27:39Z","pushed_at":"2014-10-20T16:03:04Z","git_url":"git://github.com/dgeb/ember-qunit.git","ssh_url":"git@github.com:dgeb/ember-qunit.git","clone_url":"https://github.com/dgeb/ember-qunit.git","svn_url":"https://github.com/dgeb/ember-qunit","homepage":"","size":258,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rwjblue:master","ref":"master","sha":"f3f852789bc80486afae1a9ddb7810356050fe9b","user":{"login":"rwjblue","id":12637,"avatar_url":"https://avatars.githubusercontent.com/u/12637?v=2","gravatar_id":"","url":"https://api.github.com/users/rwjblue","html_url":"https://github.com/rwjblue","followers_url":"https://api.github.com/users/rwjblue/followers","following_url":"https://api.github.com/users/rwjblue/following{/other_user}","gists_url":"https://api.github.com/users/rwjblue/gists{/gist_id}","starred_url":"https://api.github.com/users/rwjblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwjblue/subscriptions","organizations_url":"https://api.github.com/users/rwjblue/orgs","repos_url":"https://api.github.com/users/rwjblue/repos","events_url":"https://api.github.com/users/rwjblue/events{/privacy}","received_events_url":"https://api.github.com/users/rwjblue/received_events","type":"User","site_admin":false},"repo":{"id":17152449,"name":"ember-qunit","full_name":"rwjblue/ember-qunit","owner":{"login":"rwjblue","id":12637,"avatar_url":"https://avatars.githubusercontent.com/u/12637?v=2","gravatar_id":"","url":"https://api.github.com/users/rwjblue","html_url":"https://github.com/rwjblue","followers_url":"https://api.github.com/users/rwjblue/followers","following_url":"https://api.github.com/users/rwjblue/following{/other_user}","gists_url":"https://api.github.com/users/rwjblue/gists{/gist_id}","starred_url":"https://api.github.com/users/rwjblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwjblue/subscriptions","organizations_url":"https://api.github.com/users/rwjblue/orgs","repos_url":"https://api.github.com/users/rwjblue/repos","events_url":"https://api.github.com/users/rwjblue/events{/privacy}","received_events_url":"https://api.github.com/users/rwjblue/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rwjblue/ember-qunit","description":"unit test helpers for ember","fork":false,"url":"https://api.github.com/repos/rwjblue/ember-qunit","forks_url":"https://api.github.com/repos/rwjblue/ember-qunit/forks","keys_url":"https://api.github.com/repos/rwjblue/ember-qunit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rwjblue/ember-qunit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rwjblue/ember-qunit/teams","hooks_url":"https://api.github.com/repos/rwjblue/ember-qunit/hooks","issue_events_url":"https://api.github.com/repos/rwjblue/ember-qunit/issues/events{/number}","events_url":"https://api.github.com/repos/rwjblue/ember-qunit/events","assignees_url":"https://api.github.com/repos/rwjblue/ember-qunit/assignees{/user}","branches_url":"https://api.github.com/repos/rwjblue/ember-qunit/branches{/branch}","tags_url":"https://api.github.com/repos/rwjblue/ember-qunit/tags","blobs_url":"https://api.github.com/repos/rwjblue/ember-qunit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rwjblue/ember-qunit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rwjblue/ember-qunit/git/refs{/sha}","trees_url":"https://api.github.com/repos/rwjblue/ember-qunit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rwjblue/ember-qunit/statuses/{sha}","languages_url":"https://api.github.com/repos/rwjblue/ember-qunit/languages","stargazers_url":"https://api.github.com/repos/rwjblue/ember-qunit/stargazers","contributors_url":"https://api.github.com/repos/rwjblue/ember-qunit/contributors","subscribers_url":"https://api.github.com/repos/rwjblue/ember-qunit/subscribers","subscription_url":"https://api.github.com/repos/rwjblue/ember-qunit/subscription","commits_url":"https://api.github.com/repos/rwjblue/ember-qunit/commits{/sha}","git_commits_url":"https://api.github.com/repos/rwjblue/ember-qunit/git/commits{/sha}","comments_url":"https://api.github.com/repos/rwjblue/ember-qunit/comments{/number}","issue_comment_url":"https://api.github.com/repos/rwjblue/ember-qunit/issues/comments/{number}","contents_url":"https://api.github.com/repos/rwjblue/ember-qunit/contents/{+path}","compare_url":"https://api.github.com/repos/rwjblue/ember-qunit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rwjblue/ember-qunit/merges","archive_url":"https://api.github.com/repos/rwjblue/ember-qunit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rwjblue/ember-qunit/downloads","issues_url":"https://api.github.com/repos/rwjblue/ember-qunit/issues{/number}","pulls_url":"https://api.github.com/repos/rwjblue/ember-qunit/pulls{/number}","milestones_url":"https://api.github.com/repos/rwjblue/ember-qunit/milestones{/number}","notifications_url":"https://api.github.com/repos/rwjblue/ember-qunit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rwjblue/ember-qunit/labels{/name}","releases_url":"https://api.github.com/repos/rwjblue/ember-qunit/releases{/id}","created_at":"2014-02-24T22:02:49Z","updated_at":"2014-10-15T02:42:50Z","pushed_at":"2014-09-23T14:35:26Z","git_url":"git://github.com/rwjblue/ember-qunit.git","ssh_url":"git@github.com:rwjblue/ember-qunit.git","clone_url":"https://github.com/rwjblue/ember-qunit.git","svn_url":"https://github.com/rwjblue/ember-qunit","homepage":"","size":1260,"stargazers_count":132,"watchers_count":132,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":47,"mirror_url":null,"open_issues_count":40,"forks":47,"open_issues":40,"watchers":132,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rwjblue/ember-qunit/pulls/99"},"html":{"href":"https://github.com/rwjblue/ember-qunit/pull/99"},"issue":{"href":"https://api.github.com/repos/rwjblue/ember-qunit/issues/99"},"comments":{"href":"https://api.github.com/repos/rwjblue/ember-qunit/issues/99/comments"},"review_comments":{"href":"https://api.github.com/repos/rwjblue/ember-qunit/pulls/99/comments"},"review_comment":{"href":"https://api.github.com/repos/rwjblue/ember-qunit/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rwjblue/ember-qunit/pulls/99/commits"},"statuses":{"href":"https://api.github.com/repos/rwjblue/ember-qunit/statuses/89ea8e2069a1b80f77958f3207e01c9fb157c812"}}}}