GitHub PullRequestReviewCommentEvent at 2014-11-18 00:02:05
Repository: neovim
Actor: jszakmeister
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/neovim/neovim/pulls/comments/20476208","id":20476208,"diff_hunk":"@@ -16068,10 +16092,15 @@ void free_tv(typval_T *varp)\n void clear_tv(typval_T *varp)\n {\n   if (varp != NULL) {\n+    char_u *null_string = (char_u *)\"\";\n     switch (varp->v_type) {\n     case VAR_FUNC:\n       func_unref(varp->vval.v_string);\n-    /*FALLTHROUGH*/\n+      if (varp->vval.v_string != null_string) {","path":"src/nvim/eval.c","position":134,"original_position":134,"commit_id":"bbf15a37092f650d9e3c97f4db8bda73a9759b75","original_commit_id":"bbf15a37092f650d9e3c97f4db8bda73a9759b75","user":{"login":"jszakmeister","id":448087,"avatar_url":"https://avatars.githubusercontent.com/u/448087?v=3","gravatar_id":"","url":"https://api.github.com/users/jszakmeister","html_url":"https://github.com/jszakmeister","followers_url":"https://api.github.com/users/jszakmeister/followers","following_url":"https://api.github.com/users/jszakmeister/following{/other_user}","gists_url":"https://api.github.com/users/jszakmeister/gists{/gist_id}","starred_url":"https://api.github.com/users/jszakmeister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jszakmeister/subscriptions","organizations_url":"https://api.github.com/users/jszakmeister/orgs","repos_url":"https://api.github.com/users/jszakmeister/repos","events_url":"https://api.github.com/users/jszakmeister/events{/privacy}","received_events_url":"https://api.github.com/users/jszakmeister/received_events","type":"User","site_admin":false},"body":"Yeah, that seems wrong.  Is there ever a time when `varp->vval.v_string == null_string`?  If so, I think it's just luck and the compiler consolidated references.","created_at":"2014-11-18T00:02:05Z","updated_at":"2014-11-18T00:02:05Z","html_url":"https://github.com/neovim/neovim/pull/1478#discussion_r20476208","pull_request_url":"https://api.github.com/repos/neovim/neovim/pulls/1478","_links":{"self":{"href":"https://api.github.com/repos/neovim/neovim/pulls/comments/20476208"},"html":{"href":"https://github.com/neovim/neovim/pull/1478#discussion_r20476208"},"pull_request":{"href":"https://api.github.com/repos/neovim/neovim/pulls/1478"}}},"pull_request":{"url":"https://api.github.com/repos/neovim/neovim/pulls/1478","id":24471990,"html_url":"https://github.com/neovim/neovim/pull/1478","diff_url":"https://github.com/neovim/neovim/pull/1478.diff","patch_url":"https://github.com/neovim/neovim/pull/1478.patch","issue_url":"https://api.github.com/repos/neovim/neovim/issues/1478","number":1478,"state":"open","locked":false,"title":"[RFC] Fix clang analysis warnings. (4)","user":{"login":"elmart","id":135757,"avatar_url":"https://avatars.githubusercontent.com/u/135757?v=3","gravatar_id":"","url":"https://api.github.com/users/elmart","html_url":"https://github.com/elmart","followers_url":"https://api.github.com/users/elmart/followers","following_url":"https://api.github.com/users/elmart/following{/other_user}","gists_url":"https://api.github.com/users/elmart/gists{/gist_id}","starred_url":"https://api.github.com/users/elmart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elmart/subscriptions","organizations_url":"https://api.github.com/users/elmart/orgs","repos_url":"https://api.github.com/users/elmart/repos","events_url":"https://api.github.com/users/elmart/events{/privacy}","received_events_url":"https://api.github.com/users/elmart/received_events","type":"User","site_admin":false},"body":"Continues #1389, #1431, and #1460 .\r\n\r\nThis fixes **18** warnings in:\r\n- tag.c\r\n- window.c\r\n- eval.c\r\n- screen.c","created_at":"2014-11-14T21:33:53Z","updated_at":"2014-11-18T00:02:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fa4d6663c74ef07545950f88d42d9c9a33c56871","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/neovim/neovim/pulls/1478/commits","review_comments_url":"https://api.github.com/repos/neovim/neovim/pulls/1478/comments","review_comment_url":"https://api.github.com/repos/neovim/neovim/pulls/comments/{number}","comments_url":"https://api.github.com/repos/neovim/neovim/issues/1478/comments","statuses_url":"https://api.github.com/repos/neovim/neovim/statuses/bbf15a37092f650d9e3c97f4db8bda73a9759b75","head":{"label":"elmart:clang-analysis-fixes-4","ref":"clang-analysis-fixes-4","sha":"bbf15a37092f650d9e3c97f4db8bda73a9759b75","user":{"login":"elmart","id":135757,"avatar_url":"https://avatars.githubusercontent.com/u/135757?v=3","gravatar_id":"","url":"https://api.github.com/users/elmart","html_url":"https://github.com/elmart","followers_url":"https://api.github.com/users/elmart/followers","following_url":"https://api.github.com/users/elmart/following{/other_user}","gists_url":"https://api.github.com/users/elmart/gists{/gist_id}","starred_url":"https://api.github.com/users/elmart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elmart/subscriptions","organizations_url":"https://api.github.com/users/elmart/orgs","repos_url":"https://api.github.com/users/elmart/repos","events_url":"https://api.github.com/users/elmart/events{/privacy}","received_events_url":"https://api.github.com/users/elmart/received_events","type":"User","site_admin":false},"repo":{"id":18412494,"name":"neovim","full_name":"elmart/neovim","owner":{"login":"elmart","id":135757,"avatar_url":"https://avatars.githubusercontent.com/u/135757?v=3","gravatar_id":"","url":"https://api.github.com/users/elmart","html_url":"https://github.com/elmart","followers_url":"https://api.github.com/users/elmart/followers","following_url":"https://api.github.com/users/elmart/following{/other_user}","gists_url":"https://api.github.com/users/elmart/gists{/gist_id}","starred_url":"https://api.github.com/users/elmart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elmart/subscriptions","organizations_url":"https://api.github.com/users/elmart/orgs","repos_url":"https://api.github.com/users/elmart/repos","events_url":"https://api.github.com/users/elmart/events{/privacy}","received_events_url":"https://api.github.com/users/elmart/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/elmart/neovim","description":"vim's rebirth for the 21st century","fork":true,"url":"https://api.github.com/repos/elmart/neovim","forks_url":"https://api.github.com/repos/elmart/neovim/forks","keys_url":"https://api.github.com/repos/elmart/neovim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elmart/neovim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elmart/neovim/teams","hooks_url":"https://api.github.com/repos/elmart/neovim/hooks","issue_events_url":"https://api.github.com/repos/elmart/neovim/issues/events{/number}","events_url":"https://api.github.com/repos/elmart/neovim/events","assignees_url":"https://api.github.com/repos/elmart/neovim/assignees{/user}","branches_url":"https://api.github.com/repos/elmart/neovim/branches{/branch}","tags_url":"https://api.github.com/repos/elmart/neovim/tags","blobs_url":"https://api.github.com/repos/elmart/neovim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elmart/neovim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elmart/neovim/git/refs{/sha}","trees_url":"https://api.github.com/repos/elmart/neovim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elmart/neovim/statuses/{sha}","languages_url":"https://api.github.com/repos/elmart/neovim/languages","stargazers_url":"https://api.github.com/repos/elmart/neovim/stargazers","contributors_url":"https://api.github.com/repos/elmart/neovim/contributors","subscribers_url":"https://api.github.com/repos/elmart/neovim/subscribers","subscription_url":"https://api.github.com/repos/elmart/neovim/subscription","commits_url":"https://api.github.com/repos/elmart/neovim/commits{/sha}","git_commits_url":"https://api.github.com/repos/elmart/neovim/git/commits{/sha}","comments_url":"https://api.github.com/repos/elmart/neovim/comments{/number}","issue_comment_url":"https://api.github.com/repos/elmart/neovim/issues/comments/{number}","contents_url":"https://api.github.com/repos/elmart/neovim/contents/{+path}","compare_url":"https://api.github.com/repos/elmart/neovim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elmart/neovim/merges","archive_url":"https://api.github.com/repos/elmart/neovim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elmart/neovim/downloads","issues_url":"https://api.github.com/repos/elmart/neovim/issues{/number}","pulls_url":"https://api.github.com/repos/elmart/neovim/pulls{/number}","milestones_url":"https://api.github.com/repos/elmart/neovim/milestones{/number}","notifications_url":"https://api.github.com/repos/elmart/neovim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elmart/neovim/labels{/name}","releases_url":"https://api.github.com/repos/elmart/neovim/releases{/id}","created_at":"2014-04-03T17:50:33Z","updated_at":"2014-10-28T21:16:17Z","pushed_at":"2014-11-17T16:00:00Z","git_url":"git://github.com/elmart/neovim.git","ssh_url":"git@github.com:elmart/neovim.git","clone_url":"https://github.com/elmart/neovim.git","svn_url":"https://github.com/elmart/neovim","homepage":"http://neovim.org/","size":23350,"stargazers_count":0,"watchers_count":0,"language":"VimL","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"neovim:master","ref":"master","sha":"3b8661745b2c5ed8b4b9a7bfe4fa75935eb1afeb","user":{"login":"neovim","id":6471485,"avatar_url":"https://avatars.githubusercontent.com/u/6471485?v=3","gravatar_id":"","url":"https://api.github.com/users/neovim","html_url":"https://github.com/neovim","followers_url":"https://api.github.com/users/neovim/followers","following_url":"https://api.github.com/users/neovim/following{/other_user}","gists_url":"https://api.github.com/users/neovim/gists{/gist_id}","starred_url":"https://api.github.com/users/neovim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neovim/subscriptions","organizations_url":"https://api.github.com/users/neovim/orgs","repos_url":"https://api.github.com/users/neovim/repos","events_url":"https://api.github.com/users/neovim/events{/privacy}","received_events_url":"https://api.github.com/users/neovim/received_events","type":"Organization","site_admin":false},"repo":{"id":16408992,"name":"neovim","full_name":"neovim/neovim","owner":{"login":"neovim","id":6471485,"avatar_url":"https://avatars.githubusercontent.com/u/6471485?v=3","gravatar_id":"","url":"https://api.github.com/users/neovim","html_url":"https://github.com/neovim","followers_url":"https://api.github.com/users/neovim/followers","following_url":"https://api.github.com/users/neovim/following{/other_user}","gists_url":"https://api.github.com/users/neovim/gists{/gist_id}","starred_url":"https://api.github.com/users/neovim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neovim/subscriptions","organizations_url":"https://api.github.com/users/neovim/orgs","repos_url":"https://api.github.com/users/neovim/repos","events_url":"https://api.github.com/users/neovim/events{/privacy}","received_events_url":"https://api.github.com/users/neovim/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neovim/neovim","description":"vim out of the box","fork":false,"url":"https://api.github.com/repos/neovim/neovim","forks_url":"https://api.github.com/repos/neovim/neovim/forks","keys_url":"https://api.github.com/repos/neovim/neovim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neovim/neovim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neovim/neovim/teams","hooks_url":"https://api.github.com/repos/neovim/neovim/hooks","issue_events_url":"https://api.github.com/repos/neovim/neovim/issues/events{/number}","events_url":"https://api.github.com/repos/neovim/neovim/events","assignees_url":"https://api.github.com/repos/neovim/neovim/assignees{/user}","branches_url":"https://api.github.com/repos/neovim/neovim/branches{/branch}","tags_url":"https://api.github.com/repos/neovim/neovim/tags","blobs_url":"https://api.github.com/repos/neovim/neovim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neovim/neovim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neovim/neovim/git/refs{/sha}","trees_url":"https://api.github.com/repos/neovim/neovim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neovim/neovim/statuses/{sha}","languages_url":"https://api.github.com/repos/neovim/neovim/languages","stargazers_url":"https://api.github.com/repos/neovim/neovim/stargazers","contributors_url":"https://api.github.com/repos/neovim/neovim/contributors","subscribers_url":"https://api.github.com/repos/neovim/neovim/subscribers","subscription_url":"https://api.github.com/repos/neovim/neovim/subscription","commits_url":"https://api.github.com/repos/neovim/neovim/commits{/sha}","git_commits_url":"https://api.github.com/repos/neovim/neovim/git/commits{/sha}","comments_url":"https://api.github.com/repos/neovim/neovim/comments{/number}","issue_comment_url":"https://api.github.com/repos/neovim/neovim/issues/comments/{number}","contents_url":"https://api.github.com/repos/neovim/neovim/contents/{+path}","compare_url":"https://api.github.com/repos/neovim/neovim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neovim/neovim/merges","archive_url":"https://api.github.com/repos/neovim/neovim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neovim/neovim/downloads","issues_url":"https://api.github.com/repos/neovim/neovim/issues{/number}","pulls_url":"https://api.github.com/repos/neovim/neovim/pulls{/number}","milestones_url":"https://api.github.com/repos/neovim/neovim/milestones{/number}","notifications_url":"https://api.github.com/repos/neovim/neovim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neovim/neovim/labels{/name}","releases_url":"https://api.github.com/repos/neovim/neovim/releases{/id}","created_at":"2014-01-31T13:39:22Z","updated_at":"2014-11-17T23:03:59Z","pushed_at":"2014-11-17T23:03:58Z","git_url":"git://github.com/neovim/neovim.git","ssh_url":"git@github.com:neovim/neovim.git","clone_url":"https://github.com/neovim/neovim.git","svn_url":"https://github.com/neovim/neovim","homepage":"http://neovim.org/","size":66335,"stargazers_count":10610,"watchers_count":10610,"language":"VimL","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":687,"mirror_url":null,"open_issues_count":264,"forks":687,"open_issues":264,"watchers":10610,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/neovim/neovim/pulls/1478"},"html":{"href":"https://github.com/neovim/neovim/pull/1478"},"issue":{"href":"https://api.github.com/repos/neovim/neovim/issues/1478"},"comments":{"href":"https://api.github.com/repos/neovim/neovim/issues/1478/comments"},"review_comments":{"href":"https://api.github.com/repos/neovim/neovim/pulls/1478/comments"},"review_comment":{"href":"https://api.github.com/repos/neovim/neovim/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/neovim/neovim/pulls/1478/commits"},"statuses":{"href":"https://api.github.com/repos/neovim/neovim/statuses/bbf15a37092f650d9e3c97f4db8bda73a9759b75"}}}}