GitHub PullRequestReviewCommentEvent at 2014-09-23 09:30:35
Repository: gitlab_git
Actor: Razer6
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/gitlabhq/gitlab_git/pulls/comments/17898921","id":17898921,"diff_hunk":"@@ -65,6 +67,20 @@ def init_from_grit(grit)\n         end\n       end\n \n+      def init_from_rugged(rugged)\n+        @raw_diff = rugged\n+\n+        @diff = rugged\n+        @new_path = rugged.delta.new_file[:path]\n+        @old_path = rugged.delta.old_file[:path]\n+        @a_mode = rugged.delta.old_file[:mode]\n+        @b_mode = rugged.delta.new_file[:mode]\n+        @new_file = rugged.delta.new_file\n+        @old_file = rugged.delta.old_file\n+        @renamed_file = rugged.delta.renamed?\n+        @deleted_file = rugged.delta.deleted?\n+      end\n+","path":"lib/gitlab_git/diff.rb","position":26,"original_position":26,"commit_id":"59c3e9b6a156cce330ff19a731d7210290ea53de","original_commit_id":"59c3e9b6a156cce330ff19a731d7210290ea53de","user":{"login":"Razer6","id":278301,"avatar_url":"https://avatars.githubusercontent.com/u/278301?v=2","gravatar_id":"","url":"https://api.github.com/users/Razer6","html_url":"https://github.com/Razer6","followers_url":"https://api.github.com/users/Razer6/followers","following_url":"https://api.github.com/users/Razer6/following{/other_user}","gists_url":"https://api.github.com/users/Razer6/gists{/gist_id}","starred_url":"https://api.github.com/users/Razer6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Razer6/subscriptions","organizations_url":"https://api.github.com/users/Razer6/orgs","repos_url":"https://api.github.com/users/Razer6/repos","events_url":"https://api.github.com/users/Razer6/events{/privacy}","received_events_url":"https://api.github.com/users/Razer6/received_events","type":"User","site_admin":false},"body":":+1: ","created_at":"2014-09-23T09:30:35Z","updated_at":"2014-09-23T09:30:35Z","html_url":"https://github.com/gitlabhq/gitlab_git/pull/40#discussion_r17898921","pull_request_url":"https://api.github.com/repos/gitlabhq/gitlab_git/pulls/40","_links":{"self":{"href":"https://api.github.com/repos/gitlabhq/gitlab_git/pulls/comments/17898921"},"html":{"href":"https://github.com/gitlabhq/gitlab_git/pull/40#discussion_r17898921"},"pull_request":{"href":"https://api.github.com/repos/gitlabhq/gitlab_git/pulls/40"}}},"pull_request":{"url":"https://api.github.com/repos/gitlabhq/gitlab_git/pulls/40","id":20312137,"html_url":"https://github.com/gitlabhq/gitlab_git/pull/40","diff_url":"https://github.com/gitlabhq/gitlab_git/pull/40.diff","patch_url":"https://github.com/gitlabhq/gitlab_git/pull/40.patch","issue_url":"https://api.github.com/repos/gitlabhq/gitlab_git/issues/40","number":40,"state":"open","locked":false,"title":"Use Rugged in Commit, Diff, and Repository.log()","user":{"login":"mr-vinn","id":2551678,"avatar_url":"https://avatars.githubusercontent.com/u/2551678?v=2","gravatar_id":"","url":"https://api.github.com/users/mr-vinn","html_url":"https://github.com/mr-vinn","followers_url":"https://api.github.com/users/mr-vinn/followers","following_url":"https://api.github.com/users/mr-vinn/following{/other_user}","gists_url":"https://api.github.com/users/mr-vinn/gists{/gist_id}","starred_url":"https://api.github.com/users/mr-vinn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mr-vinn/subscriptions","organizations_url":"https://api.github.com/users/mr-vinn/orgs","repos_url":"https://api.github.com/users/mr-vinn/repos","events_url":"https://api.github.com/users/mr-vinn/events{/privacy}","received_events_url":"https://api.github.com/users/mr-vinn/received_events","type":"User","site_admin":false},"body":"I gave the Commit and Diff objects the ability to wrap either a Rugged object or a Grit object.  That allows the `Repository.log()` method to use Rugged instead of Grit and return an array of Rugged commit objects.\r\n\r\n### Breaking changes\r\n* __`Gitlab::Git::Commit.parents` returns an array of `Gitlab::Git::Commit` objects instead of Rugged commits__\r\n    I did this to be consistent with the existing `diffs` method.  You can still get the Rugged parent commits with `raw_commit`.\r\n\r\n* __The new `CommitStats` class doesn't implement a `files` method__\r\n    The `files` method isn't used internally or by Gitlab CE.\r\n\r\n* __`Repository.log` no longer uses the `follow` option__\r\n    This option isn't used internally or by Gitlab CE.\r\n\r\n* __The `raw_commit` or `raw_diff` object might be a Rugged object, while callers may be expecting a Grit object.__\r\n    This seemed acceptable; callers shouldn't expect to access Grit objects if the library is being removed from gitlab_git.","created_at":"2014-08-26T14:28:40Z","updated_at":"2014-09-23T09:30:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f7b0f2517aa32ed6ebf17e9deb8ab61ab10cd021","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gitlabhq/gitlab_git/pulls/40/commits","review_comments_url":"https://api.github.com/repos/gitlabhq/gitlab_git/pulls/40/comments","review_comment_url":"https://api.github.com/repos/gitlabhq/gitlab_git/pulls/comments/{number}","comments_url":"https://api.github.com/repos/gitlabhq/gitlab_git/issues/40/comments","statuses_url":"https://api.github.com/repos/gitlabhq/gitlab_git/statuses/59c3e9b6a156cce330ff19a731d7210290ea53de","head":{"label":"mr-vinn:use-more-rugged","ref":"use-more-rugged","sha":"59c3e9b6a156cce330ff19a731d7210290ea53de","user":{"login":"mr-vinn","id":2551678,"avatar_url":"https://avatars.githubusercontent.com/u/2551678?v=2","gravatar_id":"","url":"https://api.github.com/users/mr-vinn","html_url":"https://github.com/mr-vinn","followers_url":"https://api.github.com/users/mr-vinn/followers","following_url":"https://api.github.com/users/mr-vinn/following{/other_user}","gists_url":"https://api.github.com/users/mr-vinn/gists{/gist_id}","starred_url":"https://api.github.com/users/mr-vinn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mr-vinn/subscriptions","organizations_url":"https://api.github.com/users/mr-vinn/orgs","repos_url":"https://api.github.com/users/mr-vinn/repos","events_url":"https://api.github.com/users/mr-vinn/events{/privacy}","received_events_url":"https://api.github.com/users/mr-vinn/received_events","type":"User","site_admin":false},"repo":{"id":19654731,"name":"gitlab_git","full_name":"mr-vinn/gitlab_git","owner":{"login":"mr-vinn","id":2551678,"avatar_url":"https://avatars.githubusercontent.com/u/2551678?v=2","gravatar_id":"","url":"https://api.github.com/users/mr-vinn","html_url":"https://github.com/mr-vinn","followers_url":"https://api.github.com/users/mr-vinn/followers","following_url":"https://api.github.com/users/mr-vinn/following{/other_user}","gists_url":"https://api.github.com/users/mr-vinn/gists{/gist_id}","starred_url":"https://api.github.com/users/mr-vinn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mr-vinn/subscriptions","organizations_url":"https://api.github.com/users/mr-vinn/orgs","repos_url":"https://api.github.com/users/mr-vinn/repos","events_url":"https://api.github.com/users/mr-vinn/events{/privacy}","received_events_url":"https://api.github.com/users/mr-vinn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mr-vinn/gitlab_git","description":"Access git objects via GitLab Git. Basically its wrapper around grit","fork":true,"url":"https://api.github.com/repos/mr-vinn/gitlab_git","forks_url":"https://api.github.com/repos/mr-vinn/gitlab_git/forks","keys_url":"https://api.github.com/repos/mr-vinn/gitlab_git/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mr-vinn/gitlab_git/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mr-vinn/gitlab_git/teams","hooks_url":"https://api.github.com/repos/mr-vinn/gitlab_git/hooks","issue_events_url":"https://api.github.com/repos/mr-vinn/gitlab_git/issues/events{/number}","events_url":"https://api.github.com/repos/mr-vinn/gitlab_git/events","assignees_url":"https://api.github.com/repos/mr-vinn/gitlab_git/assignees{/user}","branches_url":"https://api.github.com/repos/mr-vinn/gitlab_git/branches{/branch}","tags_url":"https://api.github.com/repos/mr-vinn/gitlab_git/tags","blobs_url":"https://api.github.com/repos/mr-vinn/gitlab_git/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mr-vinn/gitlab_git/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mr-vinn/gitlab_git/git/refs{/sha}","trees_url":"https://api.github.com/repos/mr-vinn/gitlab_git/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mr-vinn/gitlab_git/statuses/{sha}","languages_url":"https://api.github.com/repos/mr-vinn/gitlab_git/languages","stargazers_url":"https://api.github.com/repos/mr-vinn/gitlab_git/stargazers","contributors_url":"https://api.github.com/repos/mr-vinn/gitlab_git/contributors","subscribers_url":"https://api.github.com/repos/mr-vinn/gitlab_git/subscribers","subscription_url":"https://api.github.com/repos/mr-vinn/gitlab_git/subscription","commits_url":"https://api.github.com/repos/mr-vinn/gitlab_git/commits{/sha}","git_commits_url":"https://api.github.com/repos/mr-vinn/gitlab_git/git/commits{/sha}","comments_url":"https://api.github.com/repos/mr-vinn/gitlab_git/comments{/number}","issue_comment_url":"https://api.github.com/repos/mr-vinn/gitlab_git/issues/comments/{number}","contents_url":"https://api.github.com/repos/mr-vinn/gitlab_git/contents/{+path}","compare_url":"https://api.github.com/repos/mr-vinn/gitlab_git/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mr-vinn/gitlab_git/merges","archive_url":"https://api.github.com/repos/mr-vinn/gitlab_git/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mr-vinn/gitlab_git/downloads","issues_url":"https://api.github.com/repos/mr-vinn/gitlab_git/issues{/number}","pulls_url":"https://api.github.com/repos/mr-vinn/gitlab_git/pulls{/number}","milestones_url":"https://api.github.com/repos/mr-vinn/gitlab_git/milestones{/number}","notifications_url":"https://api.github.com/repos/mr-vinn/gitlab_git/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mr-vinn/gitlab_git/labels{/name}","releases_url":"https://api.github.com/repos/mr-vinn/gitlab_git/releases{/id}","created_at":"2014-05-10T23:46:30Z","updated_at":"2014-08-22T20:03:52Z","pushed_at":"2014-09-16T02:30:39Z","git_url":"git://github.com/mr-vinn/gitlab_git.git","ssh_url":"git@github.com:mr-vinn/gitlab_git.git","clone_url":"https://github.com/mr-vinn/gitlab_git.git","svn_url":"https://github.com/mr-vinn/gitlab_git","homepage":"","size":16468,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gitlabhq:master","ref":"master","sha":"441daa12025ded930bf3f77719a81c3d11a0b481","user":{"login":"gitlabhq","id":1086321,"avatar_url":"https://avatars.githubusercontent.com/u/1086321?v=2","gravatar_id":"","url":"https://api.github.com/users/gitlabhq","html_url":"https://github.com/gitlabhq","followers_url":"https://api.github.com/users/gitlabhq/followers","following_url":"https://api.github.com/users/gitlabhq/following{/other_user}","gists_url":"https://api.github.com/users/gitlabhq/gists{/gist_id}","starred_url":"https://api.github.com/users/gitlabhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gitlabhq/subscriptions","organizations_url":"https://api.github.com/users/gitlabhq/orgs","repos_url":"https://api.github.com/users/gitlabhq/repos","events_url":"https://api.github.com/users/gitlabhq/events{/privacy}","received_events_url":"https://api.github.com/users/gitlabhq/received_events","type":"Organization","site_admin":false},"repo":{"id":9712023,"name":"gitlab_git","full_name":"gitlabhq/gitlab_git","owner":{"login":"gitlabhq","id":1086321,"avatar_url":"https://avatars.githubusercontent.com/u/1086321?v=2","gravatar_id":"","url":"https://api.github.com/users/gitlabhq","html_url":"https://github.com/gitlabhq","followers_url":"https://api.github.com/users/gitlabhq/followers","following_url":"https://api.github.com/users/gitlabhq/following{/other_user}","gists_url":"https://api.github.com/users/gitlabhq/gists{/gist_id}","starred_url":"https://api.github.com/users/gitlabhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gitlabhq/subscriptions","organizations_url":"https://api.github.com/users/gitlabhq/orgs","repos_url":"https://api.github.com/users/gitlabhq/repos","events_url":"https://api.github.com/users/gitlabhq/events{/privacy}","received_events_url":"https://api.github.com/users/gitlabhq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gitlabhq/gitlab_git","description":"Access git objects via GitLab Git. Basically its wrapper around grit","fork":false,"url":"https://api.github.com/repos/gitlabhq/gitlab_git","forks_url":"https://api.github.com/repos/gitlabhq/gitlab_git/forks","keys_url":"https://api.github.com/repos/gitlabhq/gitlab_git/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gitlabhq/gitlab_git/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gitlabhq/gitlab_git/teams","hooks_url":"https://api.github.com/repos/gitlabhq/gitlab_git/hooks","issue_events_url":"https://api.github.com/repos/gitlabhq/gitlab_git/issues/events{/number}","events_url":"https://api.github.com/repos/gitlabhq/gitlab_git/events","assignees_url":"https://api.github.com/repos/gitlabhq/gitlab_git/assignees{/user}","branches_url":"https://api.github.com/repos/gitlabhq/gitlab_git/branches{/branch}","tags_url":"https://api.github.com/repos/gitlabhq/gitlab_git/tags","blobs_url":"https://api.github.com/repos/gitlabhq/gitlab_git/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gitlabhq/gitlab_git/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gitlabhq/gitlab_git/git/refs{/sha}","trees_url":"https://api.github.com/repos/gitlabhq/gitlab_git/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gitlabhq/gitlab_git/statuses/{sha}","languages_url":"https://api.github.com/repos/gitlabhq/gitlab_git/languages","stargazers_url":"https://api.github.com/repos/gitlabhq/gitlab_git/stargazers","contributors_url":"https://api.github.com/repos/gitlabhq/gitlab_git/contributors","subscribers_url":"https://api.github.com/repos/gitlabhq/gitlab_git/subscribers","subscription_url":"https://api.github.com/repos/gitlabhq/gitlab_git/subscription","commits_url":"https://api.github.com/repos/gitlabhq/gitlab_git/commits{/sha}","git_commits_url":"https://api.github.com/repos/gitlabhq/gitlab_git/git/commits{/sha}","comments_url":"https://api.github.com/repos/gitlabhq/gitlab_git/comments{/number}","issue_comment_url":"https://api.github.com/repos/gitlabhq/gitlab_git/issues/comments/{number}","contents_url":"https://api.github.com/repos/gitlabhq/gitlab_git/contents/{+path}","compare_url":"https://api.github.com/repos/gitlabhq/gitlab_git/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gitlabhq/gitlab_git/merges","archive_url":"https://api.github.com/repos/gitlabhq/gitlab_git/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gitlabhq/gitlab_git/downloads","issues_url":"https://api.github.com/repos/gitlabhq/gitlab_git/issues{/number}","pulls_url":"https://api.github.com/repos/gitlabhq/gitlab_git/pulls{/number}","milestones_url":"https://api.github.com/repos/gitlabhq/gitlab_git/milestones{/number}","notifications_url":"https://api.github.com/repos/gitlabhq/gitlab_git/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gitlabhq/gitlab_git/labels{/name}","releases_url":"https://api.github.com/repos/gitlabhq/gitlab_git/releases{/id}","created_at":"2013-04-27T08:52:56Z","updated_at":"2014-09-14T07:36:05Z","pushed_at":"2014-09-15T15:09:10Z","git_url":"git://github.com/gitlabhq/gitlab_git.git","ssh_url":"git@github.com:gitlabhq/gitlab_git.git","clone_url":"https://github.com/gitlabhq/gitlab_git.git","svn_url":"https://github.com/gitlabhq/gitlab_git","homepage":"","size":17179,"stargazers_count":36,"watchers_count":36,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":12,"forks":34,"open_issues":12,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gitlabhq/gitlab_git/pulls/40"},"html":{"href":"https://github.com/gitlabhq/gitlab_git/pull/40"},"issue":{"href":"https://api.github.com/repos/gitlabhq/gitlab_git/issues/40"},"comments":{"href":"https://api.github.com/repos/gitlabhq/gitlab_git/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/gitlabhq/gitlab_git/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/gitlabhq/gitlab_git/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/gitlabhq/gitlab_git/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/gitlabhq/gitlab_git/statuses/59c3e9b6a156cce330ff19a731d7210290ea53de"}}}}