GitHub PullRequestEvent at 2014-07-17 15:10:19
Repository: ReactiveCocoa
Actor: epatey
Payload: {"action":"opened","number":1414,"pull_request":{"url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/pulls/1414","id":18534058,"html_url":"https://github.com/ReactiveCocoa/ReactiveCocoa/pull/1414","diff_url":"https://github.com/ReactiveCocoa/ReactiveCocoa/pull/1414.diff","patch_url":"https://github.com/ReactiveCocoa/ReactiveCocoa/pull/1414.patch","issue_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/issues/1414","number":1414,"state":"open","title":"For consideration. Increase speed of +combineLatest: by 60% by converting to a non-recursive implementation.","user":{"login":"epatey","id":769548,"avatar_url":"https://avatars.githubusercontent.com/u/769548?","gravatar_id":"e627463102e2bbc09a27c190f16379e6","url":"https://api.github.com/users/epatey","html_url":"https://github.com/epatey","followers_url":"https://api.github.com/users/epatey/followers","following_url":"https://api.github.com/users/epatey/following{/other_user}","gists_url":"https://api.github.com/users/epatey/gists{/gist_id}","starred_url":"https://api.github.com/users/epatey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/epatey/subscriptions","organizations_url":"https://api.github.com/users/epatey/orgs","repos_url":"https://api.github.com/users/epatey/repos","events_url":"https://api.github.com/users/epatey/events{/privacy}","received_events_url":"https://api.github.com/users/epatey/received_events","type":"User","site_admin":false},"body":"One performance issue I've consistently found with my iOS app, particularly in table view and collection view cells, is the performance of `+combineLatest:`. Although the current implementation of the signal is a simple and elegant composition using `+join:block` and `-combineLatestWith` the recursive simplicity comes at material performance cost.\r\n\r\nI've taken a stab at a non-recursive implementation and found that it takes ~40% as much time to subscribe to a `combineLatest:` signal.\r\n\r\nI'm running with this code in my product, and I'm curious what others think about the approach.","created_at":"2014-07-17T15:10:19Z","updated_at":"2014-07-17T15:10:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/pulls/1414/commits","review_comments_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/pulls/1414/comments","review_comment_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/issues/1414/comments","statuses_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/statuses/dff36edfe76863d15789ba2e15cb1ee7688888be","head":{"label":"talko:combineLatest","ref":"combineLatest","sha":"dff36edfe76863d15789ba2e15cb1ee7688888be","user":{"login":"talko","id":797196,"avatar_url":"https://avatars.githubusercontent.com/u/797196?","gravatar_id":"f88a493fcf3568ea2248f3435dfce681","url":"https://api.github.com/users/talko","html_url":"https://github.com/talko","followers_url":"https://api.github.com/users/talko/followers","following_url":"https://api.github.com/users/talko/following{/other_user}","gists_url":"https://api.github.com/users/talko/gists{/gist_id}","starred_url":"https://api.github.com/users/talko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talko/subscriptions","organizations_url":"https://api.github.com/users/talko/orgs","repos_url":"https://api.github.com/users/talko/repos","events_url":"https://api.github.com/users/talko/events{/privacy}","received_events_url":"https://api.github.com/users/talko/received_events","type":"Organization","site_admin":false},"repo":{"id":15396938,"name":"ReactiveCocoa","full_name":"talko/ReactiveCocoa","owner":{"login":"talko","id":797196,"avatar_url":"https://avatars.githubusercontent.com/u/797196?","gravatar_id":"f88a493fcf3568ea2248f3435dfce681","url":"https://api.github.com/users/talko","html_url":"https://github.com/talko","followers_url":"https://api.github.com/users/talko/followers","following_url":"https://api.github.com/users/talko/following{/other_user}","gists_url":"https://api.github.com/users/talko/gists{/gist_id}","starred_url":"https://api.github.com/users/talko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talko/subscriptions","organizations_url":"https://api.github.com/users/talko/orgs","repos_url":"https://api.github.com/users/talko/repos","events_url":"https://api.github.com/users/talko/events{/privacy}","received_events_url":"https://api.github.com/users/talko/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/talko/ReactiveCocoa","description":"A framework for composing and transforming streams of values","fork":true,"url":"https://api.github.com/repos/talko/ReactiveCocoa","forks_url":"https://api.github.com/repos/talko/ReactiveCocoa/forks","keys_url":"https://api.github.com/repos/talko/ReactiveCocoa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/talko/ReactiveCocoa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/talko/ReactiveCocoa/teams","hooks_url":"https://api.github.com/repos/talko/ReactiveCocoa/hooks","issue_events_url":"https://api.github.com/repos/talko/ReactiveCocoa/issues/events{/number}","events_url":"https://api.github.com/repos/talko/ReactiveCocoa/events","assignees_url":"https://api.github.com/repos/talko/ReactiveCocoa/assignees{/user}","branches_url":"https://api.github.com/repos/talko/ReactiveCocoa/branches{/branch}","tags_url":"https://api.github.com/repos/talko/ReactiveCocoa/tags","blobs_url":"https://api.github.com/repos/talko/ReactiveCocoa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/talko/ReactiveCocoa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/talko/ReactiveCocoa/git/refs{/sha}","trees_url":"https://api.github.com/repos/talko/ReactiveCocoa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/talko/ReactiveCocoa/statuses/{sha}","languages_url":"https://api.github.com/repos/talko/ReactiveCocoa/languages","stargazers_url":"https://api.github.com/repos/talko/ReactiveCocoa/stargazers","contributors_url":"https://api.github.com/repos/talko/ReactiveCocoa/contributors","subscribers_url":"https://api.github.com/repos/talko/ReactiveCocoa/subscribers","subscription_url":"https://api.github.com/repos/talko/ReactiveCocoa/subscription","commits_url":"https://api.github.com/repos/talko/ReactiveCocoa/commits{/sha}","git_commits_url":"https://api.github.com/repos/talko/ReactiveCocoa/git/commits{/sha}","comments_url":"https://api.github.com/repos/talko/ReactiveCocoa/comments{/number}","issue_comment_url":"https://api.github.com/repos/talko/ReactiveCocoa/issues/comments/{number}","contents_url":"https://api.github.com/repos/talko/ReactiveCocoa/contents/{+path}","compare_url":"https://api.github.com/repos/talko/ReactiveCocoa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/talko/ReactiveCocoa/merges","archive_url":"https://api.github.com/repos/talko/ReactiveCocoa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/talko/ReactiveCocoa/downloads","issues_url":"https://api.github.com/repos/talko/ReactiveCocoa/issues{/number}","pulls_url":"https://api.github.com/repos/talko/ReactiveCocoa/pulls{/number}","milestones_url":"https://api.github.com/repos/talko/ReactiveCocoa/milestones{/number}","notifications_url":"https://api.github.com/repos/talko/ReactiveCocoa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/talko/ReactiveCocoa/labels{/name}","releases_url":"https://api.github.com/repos/talko/ReactiveCocoa/releases{/id}","created_at":"2013-12-23T14:15:57Z","updated_at":"2014-05-26T11:15:02Z","pushed_at":"2014-07-17T14:14:37Z","git_url":"git://github.com/talko/ReactiveCocoa.git","ssh_url":"git@github.com:talko/ReactiveCocoa.git","clone_url":"https://github.com/talko/ReactiveCocoa.git","svn_url":"https://github.com/talko/ReactiveCocoa","homepage":"","size":10626,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ReactiveCocoa:master","ref":"master","sha":"ec8ff5fb5e76358c229f0af9699da9f462843d75","user":{"login":"ReactiveCocoa","id":3422977,"avatar_url":"https://avatars.githubusercontent.com/u/3422977?","gravatar_id":"8c25f83d415c6d871c409aa33e80548d","url":"https://api.github.com/users/ReactiveCocoa","html_url":"https://github.com/ReactiveCocoa","followers_url":"https://api.github.com/users/ReactiveCocoa/followers","following_url":"https://api.github.com/users/ReactiveCocoa/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveCocoa/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveCocoa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveCocoa/subscriptions","organizations_url":"https://api.github.com/users/ReactiveCocoa/orgs","repos_url":"https://api.github.com/users/ReactiveCocoa/repos","events_url":"https://api.github.com/users/ReactiveCocoa/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveCocoa/received_events","type":"Organization","site_admin":false},"repo":{"id":3606624,"name":"ReactiveCocoa","full_name":"ReactiveCocoa/ReactiveCocoa","owner":{"login":"ReactiveCocoa","id":3422977,"avatar_url":"https://avatars.githubusercontent.com/u/3422977?","gravatar_id":"8c25f83d415c6d871c409aa33e80548d","url":"https://api.github.com/users/ReactiveCocoa","html_url":"https://github.com/ReactiveCocoa","followers_url":"https://api.github.com/users/ReactiveCocoa/followers","following_url":"https://api.github.com/users/ReactiveCocoa/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveCocoa/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveCocoa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveCocoa/subscriptions","organizations_url":"https://api.github.com/users/ReactiveCocoa/orgs","repos_url":"https://api.github.com/users/ReactiveCocoa/repos","events_url":"https://api.github.com/users/ReactiveCocoa/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveCocoa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ReactiveCocoa/ReactiveCocoa","description":"A framework for composing and transforming streams of values","fork":false,"url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa","forks_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/forks","keys_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/teams","hooks_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/hooks","issue_events_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/issues/events{/number}","events_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/events","assignees_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/assignees{/user}","branches_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/branches{/branch}","tags_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/tags","blobs_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/git/refs{/sha}","trees_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/statuses/{sha}","languages_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/languages","stargazers_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/stargazers","contributors_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/contributors","subscribers_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/subscribers","subscription_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/subscription","commits_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/commits{/sha}","git_commits_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/git/commits{/sha}","comments_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/comments{/number}","issue_comment_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/issues/comments/{number}","contents_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/contents/{+path}","compare_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/merges","archive_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/downloads","issues_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/issues{/number}","pulls_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/pulls{/number}","milestones_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/milestones{/number}","notifications_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/labels{/name}","releases_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/releases{/id}","created_at":"2012-03-02T22:11:24Z","updated_at":"2014-07-17T11:36:28Z","pushed_at":"2014-07-16T18:39:47Z","git_url":"git://github.com/ReactiveCocoa/ReactiveCocoa.git","ssh_url":"git@github.com:ReactiveCocoa/ReactiveCocoa.git","clone_url":"https://github.com/ReactiveCocoa/ReactiveCocoa.git","svn_url":"https://github.com/ReactiveCocoa/ReactiveCocoa","homepage":"","size":25610,"stargazers_count":4972,"watchers_count":4972,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":612,"mirror_url":null,"open_issues_count":61,"forks":612,"open_issues":61,"watchers":4972,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/pulls/1414"},"html":{"href":"https://github.com/ReactiveCocoa/ReactiveCocoa/pull/1414"},"issue":{"href":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/issues/1414"},"comments":{"href":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/issues/1414/comments"},"review_comments":{"href":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/pulls/1414/comments"},"review_comment":{"href":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/pulls/1414/commits"},"statuses":{"href":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/statuses/dff36edfe76863d15789ba2e15cb1ee7688888be"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":44,"deletions":3,"changed_files":1}}