GitHub PullRequestReviewCommentEvent at 2014-05-28 17:45:13
Repository: phpbb
Actor: PayBas
Payload: {"comment":{"url":"https://api.github.com/repos/phpbb/phpbb/pulls/comments/13144636","id":13144636,"diff_hunk":"@@ -5,20 +5,18 @@\n \n <!-- EVENT index_body_linklist_before -->\n \n-<!-- IF S_DISPLAY_SEARCH or (S_USER_LOGGED_IN and not S_IS_BOT) -->\n-<ul class=\"linklist bulletin\">\n+<!-- IF S_DISPLAY_SEARCH or (S_USER_LOGGED_IN and not S_IS_BOT and U_MARK_FORUMS) -->\n+<div class=\"topic-actions\">\n \t<!-- IF S_DISPLAY_SEARCH -->\n-\t\t<li><a href=\"{U_SEARCH_UNANSWERED}\">{L_SEARCH_UNANSWERED}</a></li>\n-\t\t<!-- IF S_LOAD_UNREADS --> \n-\t\t\t<li><a href=\"{U_SEARCH_UNREAD}\">{L_SEARCH_UNREAD}</a></li>\n-\t\t<!-- ENDIF -->\n-\t\t<!-- IF S_USER_LOGGED_IN -->\n-\t\t\t<li><a href=\"{U_SEARCH_NEW}\">{L_SEARCH_NEW}</a></li>\n-\t\t<!-- ENDIF -->\n-\t\t<li><a href=\"{U_SEARCH_ACTIVE_TOPICS}\">{L_SEARCH_ACTIVE_TOPICS}</a></li>\n+\t\t<!-- INCLUDE search_tools.html -->\n \t<!-- ENDIF -->\n-\t<!-- IF not S_IS_BOT and U_MARK_FORUMS --><li class=\"rightside mark-read\"><a href=\"{U_MARK_FORUMS}\" accesskey=\"m\" data-ajax=\"mark_forums_read\">{L_MARK_FORUMS_READ}</a></li><!-- ENDIF -->\n-</ul>\n+\t\n+\t<!-- IF S_USER_LOGGED_IN and not S_IS_BOT and U_MARK_FORUMS -->\n+\t<div class=\"pagination\">\n+\t\t<a href=\"{U_MARK_FORUMS}\" accesskey=\"m\" data-ajax=\"mark_forums_read\">{L_MARK_FORUMS_READ}</a></li>\n+\t</div>","path":"phpBB/styles/prosilver/template/index_body.html","position":25,"original_position":25,"commit_id":"c87c0622b027b183cc9322451dd4a3be2987662a","original_commit_id":"c87c0622b027b183cc9322451dd4a3be2987662a","user":{"login":"PayBas","id":3015760,"avatar_url":"https://avatars.githubusercontent.com/u/3015760?","gravatar_id":"09358afdb1e3b9c34c0b368002b55dee","url":"https://api.github.com/users/PayBas","html_url":"https://github.com/PayBas","followers_url":"https://api.github.com/users/PayBas/followers","following_url":"https://api.github.com/users/PayBas/following{/other_user}","gists_url":"https://api.github.com/users/PayBas/gists{/gist_id}","starred_url":"https://api.github.com/users/PayBas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PayBas/subscriptions","organizations_url":"https://api.github.com/users/PayBas/orgs","repos_url":"https://api.github.com/users/PayBas/repos","events_url":"https://api.github.com/users/PayBas/events{/privacy}","received_events_url":"https://api.github.com/users/PayBas/received_events","type":"User","site_admin":false},"body":"One of the main reasons for this was in fact to hide them. They clutter the layout quite a lot and even get a separate drop-down menu in responsive mode (so they are hidden anyway).\r\n\r\nThey are search functions, and should logically be close to the other search functions.\r\n\r\nBut better yet: by including them in the search-tools, these links are accessible from almost every page, instead of only the index!","created_at":"2014-05-28T17:45:13Z","updated_at":"2014-05-28T17:45:13Z","html_url":"https://github.com/phpbb/phpbb/pull/2504#discussion_r13144636","pull_request_url":"https://api.github.com/repos/phpbb/phpbb/pulls/2504","_links":{"self":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/comments/13144636"},"html":{"href":"https://github.com/phpbb/phpbb/pull/2504#discussion_r13144636"},"pull_request":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/2504"}}}}