GitHub PullRequestEvent at 2014-09-19 20:18:59
Repository: moonstone
Actor: ryanjduffy
Payload: {"action":"closed","number":1635,"pull_request":{"url":"https://api.github.com/repos/enyojs/moonstone/pulls/1635","id":21520599,"html_url":"https://github.com/enyojs/moonstone/pull/1635","diff_url":"https://github.com/enyojs/moonstone/pull/1635.diff","patch_url":"https://github.com/enyojs/moonstone/pull/1635.patch","issue_url":"https://api.github.com/repos/enyojs/moonstone/issues/1635","number":1635,"state":"closed","locked":false,"title":"Fix for: BHV-14466","user":{"login":"clinuz","id":639723,"avatar_url":"https://avatars.githubusercontent.com/u/639723?v=2","gravatar_id":"622a3b4bafc8c3515f92726a6c5ec614","url":"https://api.github.com/users/clinuz","html_url":"https://github.com/clinuz","followers_url":"https://api.github.com/users/clinuz/followers","following_url":"https://api.github.com/users/clinuz/following{/other_user}","gists_url":"https://api.github.com/users/clinuz/gists{/gist_id}","starred_url":"https://api.github.com/users/clinuz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clinuz/subscriptions","organizations_url":"https://api.github.com/users/clinuz/orgs","repos_url":"https://api.github.com/users/clinuz/repos","events_url":"https://api.github.com/users/clinuz/events{/privacy}","received_events_url":"https://api.github.com/users/clinuz/received_events","type":"User","site_admin":false},"body":"# Issue\r\n\r\nThe _moon.ListActions_ kind handles an event propagated by its internal _moon.ListActionsDrawer_ the same whether it comes from a post-render (`rendered`) routine or an actual animation event (from open/close state change). If it happens because of an open/close state change then we want spotlight to be involved and properly spot the next control but if it is post-render then we need spotlight not to interfere. When pushing a new _moon.Panel_ into _moon.Panels_ where the panel has, in its _moon.Header_ a _moon.ListActions_ the post-render spotlight spotting of the control interferes with initialization measurements made by the arranger and it becomes impossible to navigate between panels.\r\n\r\n# Fix\r\n\r\nSeparate out logic being actioned by the event handler so they can be called directly from the `rendered` routine of _moon.ListActions_; differentiate the post-render case from the actual state-change case.","created_at":"2014-09-19T20:07:29Z","updated_at":"2014-09-19T20:18:59Z","closed_at":"2014-09-19T20:18:58Z","merged_at":"2014-09-19T20:18:58Z","merge_commit_sha":"ac8242fe6a988a6537804d2c5f25c5800394fb95","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/enyojs/moonstone/pulls/1635/commits","review_comments_url":"https://api.github.com/repos/enyojs/moonstone/pulls/1635/comments","review_comment_url":"https://api.github.com/repos/enyojs/moonstone/pulls/comments/{number}","comments_url":"https://api.github.com/repos/enyojs/moonstone/issues/1635/comments","statuses_url":"https://api.github.com/repos/enyojs/moonstone/statuses/cea364b85efc38f3f739944601daaa922ce2b560","head":{"label":"enyojs:BHV-14466-coledavis","ref":"BHV-14466-coledavis","sha":"cea364b85efc38f3f739944601daaa922ce2b560","user":{"login":"enyojs","id":1266337,"avatar_url":"https://avatars.githubusercontent.com/u/1266337?v=2","gravatar_id":"70103c13ada6801c095816e50198045c","url":"https://api.github.com/users/enyojs","html_url":"https://github.com/enyojs","followers_url":"https://api.github.com/users/enyojs/followers","following_url":"https://api.github.com/users/enyojs/following{/other_user}","gists_url":"https://api.github.com/users/enyojs/gists{/gist_id}","starred_url":"https://api.github.com/users/enyojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enyojs/subscriptions","organizations_url":"https://api.github.com/users/enyojs/orgs","repos_url":"https://api.github.com/users/enyojs/repos","events_url":"https://api.github.com/users/enyojs/events{/privacy}","received_events_url":"https://api.github.com/users/enyojs/received_events","type":"Organization","site_admin":false},"repo":{"id":7251076,"name":"moonstone","full_name":"enyojs/moonstone","owner":{"login":"enyojs","id":1266337,"avatar_url":"https://avatars.githubusercontent.com/u/1266337?v=2","gravatar_id":"70103c13ada6801c095816e50198045c","url":"https://api.github.com/users/enyojs","html_url":"https://github.com/enyojs","followers_url":"https://api.github.com/users/enyojs/followers","following_url":"https://api.github.com/users/enyojs/following{/other_user}","gists_url":"https://api.github.com/users/enyojs/gists{/gist_id}","starred_url":"https://api.github.com/users/enyojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enyojs/subscriptions","organizations_url":"https://api.github.com/users/enyojs/orgs","repos_url":"https://api.github.com/users/enyojs/repos","events_url":"https://api.github.com/users/enyojs/events{/privacy}","received_events_url":"https://api.github.com/users/enyojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/enyojs/moonstone","description":"Moonstone UI library for TV user interfaces.","fork":false,"url":"https://api.github.com/repos/enyojs/moonstone","forks_url":"https://api.github.com/repos/enyojs/moonstone/forks","keys_url":"https://api.github.com/repos/enyojs/moonstone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enyojs/moonstone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enyojs/moonstone/teams","hooks_url":"https://api.github.com/repos/enyojs/moonstone/hooks","issue_events_url":"https://api.github.com/repos/enyojs/moonstone/issues/events{/number}","events_url":"https://api.github.com/repos/enyojs/moonstone/events","assignees_url":"https://api.github.com/repos/enyojs/moonstone/assignees{/user}","branches_url":"https://api.github.com/repos/enyojs/moonstone/branches{/branch}","tags_url":"https://api.github.com/repos/enyojs/moonstone/tags","blobs_url":"https://api.github.com/repos/enyojs/moonstone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enyojs/moonstone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enyojs/moonstone/git/refs{/sha}","trees_url":"https://api.github.com/repos/enyojs/moonstone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enyojs/moonstone/statuses/{sha}","languages_url":"https://api.github.com/repos/enyojs/moonstone/languages","stargazers_url":"https://api.github.com/repos/enyojs/moonstone/stargazers","contributors_url":"https://api.github.com/repos/enyojs/moonstone/contributors","subscribers_url":"https://api.github.com/repos/enyojs/moonstone/subscribers","subscription_url":"https://api.github.com/repos/enyojs/moonstone/subscription","commits_url":"https://api.github.com/repos/enyojs/moonstone/commits{/sha}","git_commits_url":"https://api.github.com/repos/enyojs/moonstone/git/commits{/sha}","comments_url":"https://api.github.com/repos/enyojs/moonstone/comments{/number}","issue_comment_url":"https://api.github.com/repos/enyojs/moonstone/issues/comments/{number}","contents_url":"https://api.github.com/repos/enyojs/moonstone/contents/{+path}","compare_url":"https://api.github.com/repos/enyojs/moonstone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enyojs/moonstone/merges","archive_url":"https://api.github.com/repos/enyojs/moonstone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enyojs/moonstone/downloads","issues_url":"https://api.github.com/repos/enyojs/moonstone/issues{/number}","pulls_url":"https://api.github.com/repos/enyojs/moonstone/pulls{/number}","milestones_url":"https://api.github.com/repos/enyojs/moonstone/milestones{/number}","notifications_url":"https://api.github.com/repos/enyojs/moonstone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enyojs/moonstone/labels{/name}","releases_url":"https://api.github.com/repos/enyojs/moonstone/releases{/id}","created_at":"2012-12-20T02:41:05Z","updated_at":"2014-09-02T20:53:52Z","pushed_at":"2014-09-19T20:18:58Z","git_url":"git://github.com/enyojs/moonstone.git","ssh_url":"git@github.com:enyojs/moonstone.git","clone_url":"https://github.com/enyojs/moonstone.git","svn_url":"https://github.com/enyojs/moonstone","homepage":"","size":96483,"stargazers_count":27,"watchers_count":27,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":32,"forks":5,"open_issues":32,"watchers":27,"default_branch":"master"}},"base":{"label":"enyojs:master","ref":"master","sha":"bff9fc6b8824f67abbc6e52585f48e98b6571289","user":{"login":"enyojs","id":1266337,"avatar_url":"https://avatars.githubusercontent.com/u/1266337?v=2","gravatar_id":"70103c13ada6801c095816e50198045c","url":"https://api.github.com/users/enyojs","html_url":"https://github.com/enyojs","followers_url":"https://api.github.com/users/enyojs/followers","following_url":"https://api.github.com/users/enyojs/following{/other_user}","gists_url":"https://api.github.com/users/enyojs/gists{/gist_id}","starred_url":"https://api.github.com/users/enyojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enyojs/subscriptions","organizations_url":"https://api.github.com/users/enyojs/orgs","repos_url":"https://api.github.com/users/enyojs/repos","events_url":"https://api.github.com/users/enyojs/events{/privacy}","received_events_url":"https://api.github.com/users/enyojs/received_events","type":"Organization","site_admin":false},"repo":{"id":7251076,"name":"moonstone","full_name":"enyojs/moonstone","owner":{"login":"enyojs","id":1266337,"avatar_url":"https://avatars.githubusercontent.com/u/1266337?v=2","gravatar_id":"70103c13ada6801c095816e50198045c","url":"https://api.github.com/users/enyojs","html_url":"https://github.com/enyojs","followers_url":"https://api.github.com/users/enyojs/followers","following_url":"https://api.github.com/users/enyojs/following{/other_user}","gists_url":"https://api.github.com/users/enyojs/gists{/gist_id}","starred_url":"https://api.github.com/users/enyojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enyojs/subscriptions","organizations_url":"https://api.github.com/users/enyojs/orgs","repos_url":"https://api.github.com/users/enyojs/repos","events_url":"https://api.github.com/users/enyojs/events{/privacy}","received_events_url":"https://api.github.com/users/enyojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/enyojs/moonstone","description":"Moonstone UI library for TV user interfaces.","fork":false,"url":"https://api.github.com/repos/enyojs/moonstone","forks_url":"https://api.github.com/repos/enyojs/moonstone/forks","keys_url":"https://api.github.com/repos/enyojs/moonstone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enyojs/moonstone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enyojs/moonstone/teams","hooks_url":"https://api.github.com/repos/enyojs/moonstone/hooks","issue_events_url":"https://api.github.com/repos/enyojs/moonstone/issues/events{/number}","events_url":"https://api.github.com/repos/enyojs/moonstone/events","assignees_url":"https://api.github.com/repos/enyojs/moonstone/assignees{/user}","branches_url":"https://api.github.com/repos/enyojs/moonstone/branches{/branch}","tags_url":"https://api.github.com/repos/enyojs/moonstone/tags","blobs_url":"https://api.github.com/repos/enyojs/moonstone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enyojs/moonstone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enyojs/moonstone/git/refs{/sha}","trees_url":"https://api.github.com/repos/enyojs/moonstone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enyojs/moonstone/statuses/{sha}","languages_url":"https://api.github.com/repos/enyojs/moonstone/languages","stargazers_url":"https://api.github.com/repos/enyojs/moonstone/stargazers","contributors_url":"https://api.github.com/repos/enyojs/moonstone/contributors","subscribers_url":"https://api.github.com/repos/enyojs/moonstone/subscribers","subscription_url":"https://api.github.com/repos/enyojs/moonstone/subscription","commits_url":"https://api.github.com/repos/enyojs/moonstone/commits{/sha}","git_commits_url":"https://api.github.com/repos/enyojs/moonstone/git/commits{/sha}","comments_url":"https://api.github.com/repos/enyojs/moonstone/comments{/number}","issue_comment_url":"https://api.github.com/repos/enyojs/moonstone/issues/comments/{number}","contents_url":"https://api.github.com/repos/enyojs/moonstone/contents/{+path}","compare_url":"https://api.github.com/repos/enyojs/moonstone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enyojs/moonstone/merges","archive_url":"https://api.github.com/repos/enyojs/moonstone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enyojs/moonstone/downloads","issues_url":"https://api.github.com/repos/enyojs/moonstone/issues{/number}","pulls_url":"https://api.github.com/repos/enyojs/moonstone/pulls{/number}","milestones_url":"https://api.github.com/repos/enyojs/moonstone/milestones{/number}","notifications_url":"https://api.github.com/repos/enyojs/moonstone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enyojs/moonstone/labels{/name}","releases_url":"https://api.github.com/repos/enyojs/moonstone/releases{/id}","created_at":"2012-12-20T02:41:05Z","updated_at":"2014-09-02T20:53:52Z","pushed_at":"2014-09-19T20:18:58Z","git_url":"git://github.com/enyojs/moonstone.git","ssh_url":"git@github.com:enyojs/moonstone.git","clone_url":"https://github.com/enyojs/moonstone.git","svn_url":"https://github.com/enyojs/moonstone","homepage":"","size":96483,"stargazers_count":27,"watchers_count":27,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":32,"forks":5,"open_issues":32,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/enyojs/moonstone/pulls/1635"},"html":{"href":"https://github.com/enyojs/moonstone/pull/1635"},"issue":{"href":"https://api.github.com/repos/enyojs/moonstone/issues/1635"},"comments":{"href":"https://api.github.com/repos/enyojs/moonstone/issues/1635/comments"},"review_comments":{"href":"https://api.github.com/repos/enyojs/moonstone/pulls/1635/comments"},"review_comment":{"href":"https://api.github.com/repos/enyojs/moonstone/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/enyojs/moonstone/pulls/1635/commits"},"statuses":{"href":"https://api.github.com/repos/enyojs/moonstone/statuses/cea364b85efc38f3f739944601daaa922ce2b560"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"ryanjduffy","id":788456,"avatar_url":"https://avatars.githubusercontent.com/u/788456?v=2","gravatar_id":"9d9ef720860edfffd477c6f2330efc91","url":"https://api.github.com/users/ryanjduffy","html_url":"https://github.com/ryanjduffy","followers_url":"https://api.github.com/users/ryanjduffy/followers","following_url":"https://api.github.com/users/ryanjduffy/following{/other_user}","gists_url":"https://api.github.com/users/ryanjduffy/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanjduffy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanjduffy/subscriptions","organizations_url":"https://api.github.com/users/ryanjduffy/orgs","repos_url":"https://api.github.com/users/ryanjduffy/repos","events_url":"https://api.github.com/users/ryanjduffy/events{/privacy}","received_events_url":"https://api.github.com/users/ryanjduffy/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":42,"deletions":15,"changed_files":2}}