GitHub PullRequestReviewCommentEvent at 2014-12-30 19:32:42
Repository: dygraphs
Actor: cthrax
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/danvk/dygraphs/pulls/comments/22360989","id":22360989,"diff_hunk":"@@ -0,0 +1,165 @@\n+var gulp = require('gulp');\n+var plugins = require('gulp-load-plugins')();\n+var karma = require('karma').server;\n+var lazypipe = require('lazypipe');\n+var path = require('path');\n+\n+var dev = false;\n+var src = {\n+    base: \"src\",\n+    lib: {\n+        base: \"src/lib\",\n+        files: [\n+            \"console.js\",\n+            \"dashed-canvas.js\"\n+        ]\n+    },\n+    main: {\n+        base: \"src/dygraph\",\n+        files: [\n+            \"dygraph-options.js\",\n+            \"dygraph-layout.js\",\n+            \"dygraph-canvas.js\",\n+            \"dygraph.js\",\n+            \"dygraph-utils.js\",\n+            \"dygraph-gviz.js\",\n+            \"dygraph-interaction-model.js\",\n+            \"dygraph-tickers.js\",\n+            \"dygraph-plugin-base.js\"\n+        ]\n+    } ,\n+    plugins: {\n+        base: \"src/dygraph/plugins\",\n+        files: [\n+            \"annotations.js\",\n+            \"axes.js\",\n+            \"chart-labels.js\",\n+            \"grid.js\",\n+            \"legend.js\",\n+            \"range-selector.js\",\n+            \"../dygraph-plugin-install.js\"\n+        ]\n+    },\n+    // Only used by dynamic loader\n+    devOptions: {\n+        base: \"src/dygraph\",\n+        files: [\"dygraph-options-reference.js\"]\n+    },\n+    datahandlers: {\n+        base: \"src/dygraph/datahandler\",\n+        files: [\n+            \"datahandler.js\",\n+            \"default.js\",\n+            \"default-fractions.js\",\n+            \"bars.js\",\n+            \"bars-error.js\",\n+            \"bars-custom.js\",\n+            \"bars-fractions.js\"\n+        ]\n+    }\n+};\n+\n+// Convenience function to merge multiple arrays into one\n+var mergePaths = function() {\n+    var paths = [];\n+    var pathobj = null;\n+    if (arguments.length > 0) {\n+        for (var i = 0; i < arguments.length; i++) {\n+            pathObj = arguments[i];\n+            pathObj.files.map(function(filename) {\n+                paths.push(path.join(pathObj.base, filename));\n+            });\n+        }\n+\n+        return paths;\n+    } else {\n+        return [];\n+    }\n+};\n+\n+var copyright = '/*! @license Copyright 2014 Dan Vanderkam (danvdk@gmail.com) MIT-licensed (http://opensource.org/licenses/MIT) */';\n+\n+// Creates the dygraph-autoloader\n+gulp.task('create-loader', function() {\n+    // Create string ready for javascript array\n+    var files = mergePaths(src.lib, src.main, src.plugins, src.devOptions, src.datahandlers)\n+        .map(function(filename) {\n+            // Make the path relative to dist file and add quotes\n+            return \"'\" + filename.replace(src.base, '../../' + src.base) + \"'\";\n+        })\n+        .join(\",\");\n+\n+    return gulp.src(src.base + '/dygraph/dygraph-autoloader.js')\n+        .pipe(plugins.replace(/\\/\\* REPLACEME \\*\\//, files))\n+        .pipe(gulp.dest('dist/scratch'));\n+});\n+\n+gulp.task('create-dev', function() {\n+    var dest = 'dist/scratch';\n+    return gulp.src(mergePaths(src.lib, src.main, src.plugins, src.devOptions, src.datahandlers))\n+        .pipe(plugins.sourcemaps.init())\n+        .pipe(plugins.concat('dygraph-combined.dev.js'))\n+        .pipe(plugins.header(copyright))\n+        .pipe(gulp.dest(dest));\n+});\n+\n+gulp.task('concat', function() {\n+    var dest = 'dist/scratch';\n+    return gulp.src(mergePaths(src.lib, src.main, src.plugins, src.datahandlers))\n+       .pipe(plugins.sourcemaps.init())\n+       .pipe(plugins.concat('dygraph-combined.js'))\n+       .pipe(plugins.header(copyright))\n+       .pipe(gulp.dest(dest))\n+       .pipe(plugins.uglify({","path":"gulpfile.js","position":113,"original_position":113,"commit_id":"a8cd565c6e18cc0051ae4e5857c87e43431a5590","original_commit_id":"a8cd565c6e18cc0051ae4e5857c87e43431a5590","user":{"login":"cthrax","id":102173,"avatar_url":"https://avatars.githubusercontent.com/u/102173?v=3","gravatar_id":"","url":"https://api.github.com/users/cthrax","html_url":"https://github.com/cthrax","followers_url":"https://api.github.com/users/cthrax/followers","following_url":"https://api.github.com/users/cthrax/following{/other_user}","gists_url":"https://api.github.com/users/cthrax/gists{/gist_id}","starred_url":"https://api.github.com/users/cthrax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cthrax/subscriptions","organizations_url":"https://api.github.com/users/cthrax/orgs","repos_url":"https://api.github.com/users/cthrax/repos","events_url":"https://api.github.com/users/cthrax/events{/privacy}","received_events_url":"https://api.github.com/users/cthrax/received_events","type":"User","site_admin":false},"body":"Now uglify the file and write it out with the min extension. (ie dygraph-combined.min.js)","created_at":"2014-12-30T19:32:42Z","updated_at":"2014-12-30T19:32:42Z","html_url":"https://github.com/danvk/dygraphs/pull/528#discussion_r22360989","pull_request_url":"https://api.github.com/repos/danvk/dygraphs/pulls/528","_links":{"self":{"href":"https://api.github.com/repos/danvk/dygraphs/pulls/comments/22360989"},"html":{"href":"https://github.com/danvk/dygraphs/pull/528#discussion_r22360989"},"pull_request":{"href":"https://api.github.com/repos/danvk/dygraphs/pulls/528"}}},"pull_request":{"url":"https://api.github.com/repos/danvk/dygraphs/pulls/528","id":26699498,"html_url":"https://github.com/danvk/dygraphs/pull/528","diff_url":"https://github.com/danvk/dygraphs/pull/528.diff","patch_url":"https://github.com/danvk/dygraphs/pull/528.patch","issue_url":"https://api.github.com/repos/danvk/dygraphs/issues/528","number":528,"state":"open","locked":false,"title":"Start down path of new build system:","user":{"login":"cthrax","id":102173,"avatar_url":"https://avatars.githubusercontent.com/u/102173?v=3","gravatar_id":"","url":"https://api.github.com/users/cthrax","html_url":"https://github.com/cthrax","followers_url":"https://api.github.com/users/cthrax/followers","following_url":"https://api.github.com/users/cthrax/following{/other_user}","gists_url":"https://api.github.com/users/cthrax/gists{/gist_id}","starred_url":"https://api.github.com/users/cthrax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cthrax/subscriptions","organizations_url":"https://api.github.com/users/cthrax/orgs","repos_url":"https://api.github.com/users/cthrax/repos","events_url":"https://api.github.com/users/cthrax/events{/privacy}","received_events_url":"https://api.github.com/users/cthrax/received_events","type":"User","site_admin":false},"body":"- Move tests to karma test runner and mocha framework, also adding chai assertions\r\n- Add gulp tasks for testing, watching, concatting and compressing\r\n- Update travis file to use new build system\r\n- Remove jstestDriver stuff\r\n- Reorganize a bit so that it's easier to see what's going on\r\n- Create a dist folder to hold the output of builds (should probably look at having a bower branch/repository where these are held, instead of master)\r\n\r\nI'm pretty sure we don't want to push this to master, but that's where this was diffed against.","created_at":"2014-12-30T19:26:40Z","updated_at":"2014-12-30T19:32:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"54b276cc4991bae0bbf85121116debc831f1f1de","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/danvk/dygraphs/pulls/528/commits","review_comments_url":"https://api.github.com/repos/danvk/dygraphs/pulls/528/comments","review_comment_url":"https://api.github.com/repos/danvk/dygraphs/pulls/comments/{number}","comments_url":"https://api.github.com/repos/danvk/dygraphs/issues/528/comments","statuses_url":"https://api.github.com/repos/danvk/dygraphs/statuses/a8cd565c6e18cc0051ae4e5857c87e43431a5590","head":{"label":"cthrax:cthrax/gulp-changes","ref":"cthrax/gulp-changes","sha":"a8cd565c6e18cc0051ae4e5857c87e43431a5590","user":{"login":"cthrax","id":102173,"avatar_url":"https://avatars.githubusercontent.com/u/102173?v=3","gravatar_id":"","url":"https://api.github.com/users/cthrax","html_url":"https://github.com/cthrax","followers_url":"https://api.github.com/users/cthrax/followers","following_url":"https://api.github.com/users/cthrax/following{/other_user}","gists_url":"https://api.github.com/users/cthrax/gists{/gist_id}","starred_url":"https://api.github.com/users/cthrax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cthrax/subscriptions","organizations_url":"https://api.github.com/users/cthrax/orgs","repos_url":"https://api.github.com/users/cthrax/repos","events_url":"https://api.github.com/users/cthrax/events{/privacy}","received_events_url":"https://api.github.com/users/cthrax/received_events","type":"User","site_admin":false},"repo":{"id":28609175,"name":"dygraphs","full_name":"cthrax/dygraphs","owner":{"login":"cthrax","id":102173,"avatar_url":"https://avatars.githubusercontent.com/u/102173?v=3","gravatar_id":"","url":"https://api.github.com/users/cthrax","html_url":"https://github.com/cthrax","followers_url":"https://api.github.com/users/cthrax/followers","following_url":"https://api.github.com/users/cthrax/following{/other_user}","gists_url":"https://api.github.com/users/cthrax/gists{/gist_id}","starred_url":"https://api.github.com/users/cthrax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cthrax/subscriptions","organizations_url":"https://api.github.com/users/cthrax/orgs","repos_url":"https://api.github.com/users/cthrax/repos","events_url":"https://api.github.com/users/cthrax/events{/privacy}","received_events_url":"https://api.github.com/users/cthrax/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cthrax/dygraphs","description":"Interactive visualizations of time series using JavaScript and the HTML canvas tag","fork":true,"url":"https://api.github.com/repos/cthrax/dygraphs","forks_url":"https://api.github.com/repos/cthrax/dygraphs/forks","keys_url":"https://api.github.com/repos/cthrax/dygraphs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cthrax/dygraphs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cthrax/dygraphs/teams","hooks_url":"https://api.github.com/repos/cthrax/dygraphs/hooks","issue_events_url":"https://api.github.com/repos/cthrax/dygraphs/issues/events{/number}","events_url":"https://api.github.com/repos/cthrax/dygraphs/events","assignees_url":"https://api.github.com/repos/cthrax/dygraphs/assignees{/user}","branches_url":"https://api.github.com/repos/cthrax/dygraphs/branches{/branch}","tags_url":"https://api.github.com/repos/cthrax/dygraphs/tags","blobs_url":"https://api.github.com/repos/cthrax/dygraphs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cthrax/dygraphs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cthrax/dygraphs/git/refs{/sha}","trees_url":"https://api.github.com/repos/cthrax/dygraphs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cthrax/dygraphs/statuses/{sha}","languages_url":"https://api.github.com/repos/cthrax/dygraphs/languages","stargazers_url":"https://api.github.com/repos/cthrax/dygraphs/stargazers","contributors_url":"https://api.github.com/repos/cthrax/dygraphs/contributors","subscribers_url":"https://api.github.com/repos/cthrax/dygraphs/subscribers","subscription_url":"https://api.github.com/repos/cthrax/dygraphs/subscription","commits_url":"https://api.github.com/repos/cthrax/dygraphs/commits{/sha}","git_commits_url":"https://api.github.com/repos/cthrax/dygraphs/git/commits{/sha}","comments_url":"https://api.github.com/repos/cthrax/dygraphs/comments{/number}","issue_comment_url":"https://api.github.com/repos/cthrax/dygraphs/issues/comments/{number}","contents_url":"https://api.github.com/repos/cthrax/dygraphs/contents/{+path}","compare_url":"https://api.github.com/repos/cthrax/dygraphs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cthrax/dygraphs/merges","archive_url":"https://api.github.com/repos/cthrax/dygraphs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cthrax/dygraphs/downloads","issues_url":"https://api.github.com/repos/cthrax/dygraphs/issues{/number}","pulls_url":"https://api.github.com/repos/cthrax/dygraphs/pulls{/number}","milestones_url":"https://api.github.com/repos/cthrax/dygraphs/milestones{/number}","notifications_url":"https://api.github.com/repos/cthrax/dygraphs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cthrax/dygraphs/labels{/name}","releases_url":"https://api.github.com/repos/cthrax/dygraphs/releases{/id}","created_at":"2014-12-29T22:46:47Z","updated_at":"2014-12-29T22:46:48Z","pushed_at":"2014-12-30T19:23:29Z","git_url":"git://github.com/cthrax/dygraphs.git","ssh_url":"git@github.com:cthrax/dygraphs.git","clone_url":"https://github.com/cthrax/dygraphs.git","svn_url":"https://github.com/cthrax/dygraphs","homepage":"http://dygraphs.com","size":17623,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"danvk:master","ref":"master","sha":"b94ba4b52e227816448775cce9687f33a80cfe9a","user":{"login":"danvk","id":98301,"avatar_url":"https://avatars.githubusercontent.com/u/98301?v=3","gravatar_id":"","url":"https://api.github.com/users/danvk","html_url":"https://github.com/danvk","followers_url":"https://api.github.com/users/danvk/followers","following_url":"https://api.github.com/users/danvk/following{/other_user}","gists_url":"https://api.github.com/users/danvk/gists{/gist_id}","starred_url":"https://api.github.com/users/danvk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danvk/subscriptions","organizations_url":"https://api.github.com/users/danvk/orgs","repos_url":"https://api.github.com/users/danvk/repos","events_url":"https://api.github.com/users/danvk/events{/privacy}","received_events_url":"https://api.github.com/users/danvk/received_events","type":"User","site_admin":false},"repo":{"id":383715,"name":"dygraphs","full_name":"danvk/dygraphs","owner":{"login":"danvk","id":98301,"avatar_url":"https://avatars.githubusercontent.com/u/98301?v=3","gravatar_id":"","url":"https://api.github.com/users/danvk","html_url":"https://github.com/danvk","followers_url":"https://api.github.com/users/danvk/followers","following_url":"https://api.github.com/users/danvk/following{/other_user}","gists_url":"https://api.github.com/users/danvk/gists{/gist_id}","starred_url":"https://api.github.com/users/danvk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danvk/subscriptions","organizations_url":"https://api.github.com/users/danvk/orgs","repos_url":"https://api.github.com/users/danvk/repos","events_url":"https://api.github.com/users/danvk/events{/privacy}","received_events_url":"https://api.github.com/users/danvk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danvk/dygraphs","description":"Interactive visualizations of time series using JavaScript and the HTML canvas tag","fork":false,"url":"https://api.github.com/repos/danvk/dygraphs","forks_url":"https://api.github.com/repos/danvk/dygraphs/forks","keys_url":"https://api.github.com/repos/danvk/dygraphs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danvk/dygraphs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danvk/dygraphs/teams","hooks_url":"https://api.github.com/repos/danvk/dygraphs/hooks","issue_events_url":"https://api.github.com/repos/danvk/dygraphs/issues/events{/number}","events_url":"https://api.github.com/repos/danvk/dygraphs/events","assignees_url":"https://api.github.com/repos/danvk/dygraphs/assignees{/user}","branches_url":"https://api.github.com/repos/danvk/dygraphs/branches{/branch}","tags_url":"https://api.github.com/repos/danvk/dygraphs/tags","blobs_url":"https://api.github.com/repos/danvk/dygraphs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danvk/dygraphs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danvk/dygraphs/git/refs{/sha}","trees_url":"https://api.github.com/repos/danvk/dygraphs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danvk/dygraphs/statuses/{sha}","languages_url":"https://api.github.com/repos/danvk/dygraphs/languages","stargazers_url":"https://api.github.com/repos/danvk/dygraphs/stargazers","contributors_url":"https://api.github.com/repos/danvk/dygraphs/contributors","subscribers_url":"https://api.github.com/repos/danvk/dygraphs/subscribers","subscription_url":"https://api.github.com/repos/danvk/dygraphs/subscription","commits_url":"https://api.github.com/repos/danvk/dygraphs/commits{/sha}","git_commits_url":"https://api.github.com/repos/danvk/dygraphs/git/commits{/sha}","comments_url":"https://api.github.com/repos/danvk/dygraphs/comments{/number}","issue_comment_url":"https://api.github.com/repos/danvk/dygraphs/issues/comments/{number}","contents_url":"https://api.github.com/repos/danvk/dygraphs/contents/{+path}","compare_url":"https://api.github.com/repos/danvk/dygraphs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danvk/dygraphs/merges","archive_url":"https://api.github.com/repos/danvk/dygraphs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danvk/dygraphs/downloads","issues_url":"https://api.github.com/repos/danvk/dygraphs/issues{/number}","pulls_url":"https://api.github.com/repos/danvk/dygraphs/pulls{/number}","milestones_url":"https://api.github.com/repos/danvk/dygraphs/milestones{/number}","notifications_url":"https://api.github.com/repos/danvk/dygraphs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danvk/dygraphs/labels{/name}","releases_url":"https://api.github.com/repos/danvk/dygraphs/releases{/id}","created_at":"2009-11-24T10:26:21Z","updated_at":"2014-12-30T01:57:03Z","pushed_at":"2014-12-15T21:55:44Z","git_url":"git://github.com/danvk/dygraphs.git","ssh_url":"git@github.com:danvk/dygraphs.git","clone_url":"https://github.com/danvk/dygraphs.git","svn_url":"https://github.com/danvk/dygraphs","homepage":"http://dygraphs.com","size":21627,"stargazers_count":1379,"watchers_count":1379,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":302,"mirror_url":null,"open_issues_count":135,"forks":302,"open_issues":135,"watchers":1379,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/danvk/dygraphs/pulls/528"},"html":{"href":"https://github.com/danvk/dygraphs/pull/528"},"issue":{"href":"https://api.github.com/repos/danvk/dygraphs/issues/528"},"comments":{"href":"https://api.github.com/repos/danvk/dygraphs/issues/528/comments"},"review_comments":{"href":"https://api.github.com/repos/danvk/dygraphs/pulls/528/comments"},"review_comment":{"href":"https://api.github.com/repos/danvk/dygraphs/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/danvk/dygraphs/pulls/528/commits"},"statuses":{"href":"https://api.github.com/repos/danvk/dygraphs/statuses/a8cd565c6e18cc0051ae4e5857c87e43431a5590"}}}}