GitHub PullRequestReviewCommentEvent at 2014-07-01 13:34:19
Repository: antok
Actor: legordian
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/AntokBatchelorMaintainers/antok/pulls/comments/14403401","id":14403401,"diff_hunk":"@@ -432,23 +436,43 @@ antok::Function* antok::generators::generateGetLorentzVec(const YAML::Node& func\n \tdouble* yAddr;\n \tdouble* zAddr;\n \tdouble* mAddr;\n-\tif(pType) {\n-\t\targs.push_back(std::pair<std::string, std::string>(\"Px\", \"double\"));\n-\t\targs.push_back(std::pair<std::string, std::string>(\"Py\", \"double\"));\n-\t\targs.push_back(std::pair<std::string, std::string>(\"Pz\", \"double\"));\n-\t\targs.push_back(std::pair<std::string, std::string>(\"E\", \"double\"));\n-\t} else {\n-\t\targs.push_back(std::pair<std::string, std::string>(\"X\", \"double\"));\n-\t\targs.push_back(std::pair<std::string, std::string>(\"Y\", \"double\"));\n-\t\targs.push_back(std::pair<std::string, std::string>(\"Z\", \"double\"));\n-\t\ttry {\n-\t\t\tfunction[\"M\"].as<double>();\n-\t\t} catch(const YAML::TypedBadConversion<double>& e) {\n-\t\t\tstd::cerr<<\"Argument \\\"M\\\" in function \\\"mass\\\" should be of type double (variable \\\"\"<<quantityName<<\"\\\").\"<<std::endl;\n+\tTVector3* vec3Addr;\n+\n+\tswitch(pType)\n+\t{\n+\t\tcase 0:\n+\t\t\targs.push_back(std::pair<std::string, std::string>(\"X\", \"double\"));\n+\t\t\targs.push_back(std::pair<std::string, std::string>(\"Y\", \"double\"));\n+\t\t\targs.push_back(std::pair<std::string, std::string>(\"Z\", \"double\"));\n+\t\t\ttry {\n+\t\t\t\tfunction[\"M\"].as<double>();\n+\t\t\t} catch(const YAML::TypedBadConversion<double>& e) {\n+\t\t\t\tstd::cerr<<\"Argument \\\"M\\\" in function \\\"mass\\\" should be of type double (variable \\\"\"<<quantityName<<\"\\\").\"<<std::endl;\n \t\t\treturn 0;","path":"src/generators_functions.cxx","position":49,"original_position":49,"commit_id":"a9972f6d9d2ebafc7bb52d657c109ba14de91e04","original_commit_id":"a9972f6d9d2ebafc7bb52d657c109ba14de91e04","user":{"login":"legordian","id":1710317,"avatar_url":"https://avatars.githubusercontent.com/u/1710317?","gravatar_id":"d51c8b95adb26e7ad5cd43e7ff69ce2e","url":"https://api.github.com/users/legordian","html_url":"https://github.com/legordian","followers_url":"https://api.github.com/users/legordian/followers","following_url":"https://api.github.com/users/legordian/following{/other_user}","gists_url":"https://api.github.com/users/legordian/gists{/gist_id}","starred_url":"https://api.github.com/users/legordian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/legordian/subscriptions","organizations_url":"https://api.github.com/users/legordian/orgs","repos_url":"https://api.github.com/users/legordian/repos","events_url":"https://api.github.com/users/legordian/events{/privacy}","received_events_url":"https://api.github.com/users/legordian/received_events","type":"User","site_admin":false},"body":"The indentation here is wrong, please correct this.","created_at":"2014-07-01T13:34:19Z","updated_at":"2014-07-01T13:34:19Z","html_url":"https://github.com/AntokBatchelorMaintainers/antok/pull/12#discussion_r14403401","pull_request_url":"https://api.github.com/repos/AntokBatchelorMaintainers/antok/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/AntokBatchelorMaintainers/antok/pulls/comments/14403401"},"html":{"href":"https://github.com/AntokBatchelorMaintainers/antok/pull/12#discussion_r14403401"},"pull_request":{"href":"https://api.github.com/repos/AntokBatchelorMaintainers/antok/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/AntokBatchelorMaintainers/antok/pulls/12","id":17714633,"html_url":"https://github.com/AntokBatchelorMaintainers/antok/pull/12","diff_url":"https://github.com/AntokBatchelorMaintainers/antok/pull/12.diff","patch_url":"https://github.com/AntokBatchelorMaintainers/antok/pull/12.patch","issue_url":"https://api.github.com/repos/AntokBatchelorMaintainers/antok/issues/12","number":12,"state":"open","title":"fix proton mask constant error, extend getlorentzVector","user":{"login":"cdreisbach","id":7963601,"avatar_url":"https://avatars.githubusercontent.com/u/7963601?","gravatar_id":"808c9c20cf0b57e04e48522cbc9ee367","url":"https://api.github.com/users/cdreisbach","html_url":"https://github.com/cdreisbach","followers_url":"https://api.github.com/users/cdreisbach/followers","following_url":"https://api.github.com/users/cdreisbach/following{/other_user}","gists_url":"https://api.github.com/users/cdreisbach/gists{/gist_id}","starred_url":"https://api.github.com/users/cdreisbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdreisbach/subscriptions","organizations_url":"https://api.github.com/users/cdreisbach/orgs","repos_url":"https://api.github.com/users/cdreisbach/repos","events_url":"https://api.github.com/users/cdreisbach/events{/privacy}","received_events_url":"https://api.github.com/users/cdreisbach/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-06-27T17:18:27Z","updated_at":"2014-07-01T13:34:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f2d40d3ff5643ae2366c8aa074369b158fc6119","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/AntokBatchelorMaintainers/antok/pulls/12/commits","review_comments_url":"https://api.github.com/repos/AntokBatchelorMaintainers/antok/pulls/12/comments","review_comment_url":"https://api.github.com/repos/AntokBatchelorMaintainers/antok/pulls/comments/{number}","comments_url":"https://api.github.com/repos/AntokBatchelorMaintainers/antok/issues/12/comments","statuses_url":"https://api.github.com/repos/AntokBatchelorMaintainers/antok/statuses/a9972f6d9d2ebafc7bb52d657c109ba14de91e04","head":{"label":"cdreisbach:pr2","ref":"pr2","sha":"a9972f6d9d2ebafc7bb52d657c109ba14de91e04","user":{"login":"cdreisbach","id":7963601,"avatar_url":"https://avatars.githubusercontent.com/u/7963601?","gravatar_id":"808c9c20cf0b57e04e48522cbc9ee367","url":"https://api.github.com/users/cdreisbach","html_url":"https://github.com/cdreisbach","followers_url":"https://api.github.com/users/cdreisbach/followers","following_url":"https://api.github.com/users/cdreisbach/following{/other_user}","gists_url":"https://api.github.com/users/cdreisbach/gists{/gist_id}","starred_url":"https://api.github.com/users/cdreisbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdreisbach/subscriptions","organizations_url":"https://api.github.com/users/cdreisbach/orgs","repos_url":"https://api.github.com/users/cdreisbach/repos","events_url":"https://api.github.com/users/cdreisbach/events{/privacy}","received_events_url":"https://api.github.com/users/cdreisbach/received_events","type":"User","site_admin":false},"repo":{"id":21279840,"name":"antok","full_name":"cdreisbach/antok","owner":{"login":"cdreisbach","id":7963601,"avatar_url":"https://avatars.githubusercontent.com/u/7963601?","gravatar_id":"808c9c20cf0b57e04e48522cbc9ee367","url":"https://api.github.com/users/cdreisbach","html_url":"https://github.com/cdreisbach","followers_url":"https://api.github.com/users/cdreisbach/followers","following_url":"https://api.github.com/users/cdreisbach/following{/other_user}","gists_url":"https://api.github.com/users/cdreisbach/gists{/gist_id}","starred_url":"https://api.github.com/users/cdreisbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdreisbach/subscriptions","organizations_url":"https://api.github.com/users/cdreisbach/orgs","repos_url":"https://api.github.com/users/cdreisbach/repos","events_url":"https://api.github.com/users/cdreisbach/events{/privacy}","received_events_url":"https://api.github.com/users/cdreisbach/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cdreisbach/antok","description":"","fork":true,"url":"https://api.github.com/repos/cdreisbach/antok","forks_url":"https://api.github.com/repos/cdreisbach/antok/forks","keys_url":"https://api.github.com/repos/cdreisbach/antok/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cdreisbach/antok/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cdreisbach/antok/teams","hooks_url":"https://api.github.com/repos/cdreisbach/antok/hooks","issue_events_url":"https://api.github.com/repos/cdreisbach/antok/issues/events{/number}","events_url":"https://api.github.com/repos/cdreisbach/antok/events","assignees_url":"https://api.github.com/repos/cdreisbach/antok/assignees{/user}","branches_url":"https://api.github.com/repos/cdreisbach/antok/branches{/branch}","tags_url":"https://api.github.com/repos/cdreisbach/antok/tags","blobs_url":"https://api.github.com/repos/cdreisbach/antok/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cdreisbach/antok/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cdreisbach/antok/git/refs{/sha}","trees_url":"https://api.github.com/repos/cdreisbach/antok/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cdreisbach/antok/statuses/{sha}","languages_url":"https://api.github.com/repos/cdreisbach/antok/languages","stargazers_url":"https://api.github.com/repos/cdreisbach/antok/stargazers","contributors_url":"https://api.github.com/repos/cdreisbach/antok/contributors","subscribers_url":"https://api.github.com/repos/cdreisbach/antok/subscribers","subscription_url":"https://api.github.com/repos/cdreisbach/antok/subscription","commits_url":"https://api.github.com/repos/cdreisbach/antok/commits{/sha}","git_commits_url":"https://api.github.com/repos/cdreisbach/antok/git/commits{/sha}","comments_url":"https://api.github.com/repos/cdreisbach/antok/comments{/number}","issue_comment_url":"https://api.github.com/repos/cdreisbach/antok/issues/comments/{number}","contents_url":"https://api.github.com/repos/cdreisbach/antok/contents/{+path}","compare_url":"https://api.github.com/repos/cdreisbach/antok/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cdreisbach/antok/merges","archive_url":"https://api.github.com/repos/cdreisbach/antok/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cdreisbach/antok/downloads","issues_url":"https://api.github.com/repos/cdreisbach/antok/issues{/number}","pulls_url":"https://api.github.com/repos/cdreisbach/antok/pulls{/number}","milestones_url":"https://api.github.com/repos/cdreisbach/antok/milestones{/number}","notifications_url":"https://api.github.com/repos/cdreisbach/antok/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cdreisbach/antok/labels{/name}","releases_url":"https://api.github.com/repos/cdreisbach/antok/releases{/id}","created_at":"2014-06-27T15:11:50Z","updated_at":"2014-06-26T14:13:07Z","pushed_at":"2014-06-30T18:22:16Z","git_url":"git://github.com/cdreisbach/antok.git","ssh_url":"git@github.com:cdreisbach/antok.git","clone_url":"https://github.com/cdreisbach/antok.git","svn_url":"https://github.com/cdreisbach/antok","homepage":null,"size":697,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AntokBatchelorMaintainers:master","ref":"master","sha":"a2b87321d712ef48e716517f4aacb7ebc2fd0829","user":{"login":"AntokBatchelorMaintainers","id":7826327,"avatar_url":"https://avatars.githubusercontent.com/u/7826327?","gravatar_id":null,"url":"https://api.github.com/users/AntokBatchelorMaintainers","html_url":"https://github.com/AntokBatchelorMaintainers","followers_url":"https://api.github.com/users/AntokBatchelorMaintainers/followers","following_url":"https://api.github.com/users/AntokBatchelorMaintainers/following{/other_user}","gists_url":"https://api.github.com/users/AntokBatchelorMaintainers/gists{/gist_id}","starred_url":"https://api.github.com/users/AntokBatchelorMaintainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AntokBatchelorMaintainers/subscriptions","organizations_url":"https://api.github.com/users/AntokBatchelorMaintainers/orgs","repos_url":"https://api.github.com/users/AntokBatchelorMaintainers/repos","events_url":"https://api.github.com/users/AntokBatchelorMaintainers/events{/privacy}","received_events_url":"https://api.github.com/users/AntokBatchelorMaintainers/received_events","type":"Organization","site_admin":false},"repo":{"id":20600753,"name":"antok","full_name":"AntokBatchelorMaintainers/antok","owner":{"login":"AntokBatchelorMaintainers","id":7826327,"avatar_url":"https://avatars.githubusercontent.com/u/7826327?","gravatar_id":null,"url":"https://api.github.com/users/AntokBatchelorMaintainers","html_url":"https://github.com/AntokBatchelorMaintainers","followers_url":"https://api.github.com/users/AntokBatchelorMaintainers/followers","following_url":"https://api.github.com/users/AntokBatchelorMaintainers/following{/other_user}","gists_url":"https://api.github.com/users/AntokBatchelorMaintainers/gists{/gist_id}","starred_url":"https://api.github.com/users/AntokBatchelorMaintainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AntokBatchelorMaintainers/subscriptions","organizations_url":"https://api.github.com/users/AntokBatchelorMaintainers/orgs","repos_url":"https://api.github.com/users/AntokBatchelorMaintainers/repos","events_url":"https://api.github.com/users/AntokBatchelorMaintainers/events{/privacy}","received_events_url":"https://api.github.com/users/AntokBatchelorMaintainers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AntokBatchelorMaintainers/antok","description":"","fork":false,"url":"https://api.github.com/repos/AntokBatchelorMaintainers/antok","forks_url":"https://api.github.com/repos/AntokBatchelorMaintainers/antok/forks","keys_url":"https://api.github.com/repos/AntokBatchelorMaintainers/antok/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AntokBatchelorMaintainers/antok/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AntokBatchelorMaintainers/antok/teams","hooks_url":"https://api.github.com/repos/AntokBatchelorMaintainers/antok/hooks","issue_events_url":"https://api.github.com/repos/AntokBatchelorMaintainers/antok/issues/events{/number}","events_url":"https://api.github.com/repos/AntokBatchelorMaintainers/antok/events","assignees_url":"https://api.github.com/repos/AntokBatchelorMaintainers/antok/assignees{/user}","branches_url":"https://api.github.com/repos/AntokBatchelorMaintainers/antok/branches{/branch}","tags_url":"https://api.github.com/repos/AntokBatchelorMaintainers/antok/tags","blobs_url":"https://api.github.com/repos/AntokBatchelorMaintainers/antok/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AntokBatchelorMaintainers/antok/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AntokBatchelorMaintainers/antok/git/refs{/sha}","trees_url":"https://api.github.com/repos/AntokBatchelorMaintainers/antok/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AntokBatchelorMaintainers/antok/statuses/{sha}","languages_url":"https://api.github.com/repos/AntokBatchelorMaintainers/antok/languages","stargazers_url":"https://api.github.com/repos/AntokBatchelorMaintainers/antok/stargazers","contributors_url":"https://api.github.com/repos/AntokBatchelorMaintainers/antok/contributors","subscribers_url":"https://api.github.com/repos/AntokBatchelorMaintainers/antok/subscribers","subscription_url":"https://api.github.com/repos/AntokBatchelorMaintainers/antok/subscription","commits_url":"https://api.github.com/repos/AntokBatchelorMaintainers/antok/commits{/sha}","git_commits_url":"https://api.github.com/repos/AntokBatchelorMaintainers/antok/git/commits{/sha}","comments_url":"https://api.github.com/repos/AntokBatchelorMaintainers/antok/comments{/number}","issue_comment_url":"https://api.github.com/repos/AntokBatchelorMaintainers/antok/issues/comments/{number}","contents_url":"https://api.github.com/repos/AntokBatchelorMaintainers/antok/contents/{+path}","compare_url":"https://api.github.com/repos/AntokBatchelorMaintainers/antok/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AntokBatchelorMaintainers/antok/merges","archive_url":"https://api.github.com/repos/AntokBatchelorMaintainers/antok/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AntokBatchelorMaintainers/antok/downloads","issues_url":"https://api.github.com/repos/AntokBatchelorMaintainers/antok/issues{/number}","pulls_url":"https://api.github.com/repos/AntokBatchelorMaintainers/antok/pulls{/number}","milestones_url":"https://api.github.com/repos/AntokBatchelorMaintainers/antok/milestones{/number}","notifications_url":"https://api.github.com/repos/AntokBatchelorMaintainers/antok/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AntokBatchelorMaintainers/antok/labels{/name}","releases_url":"https://api.github.com/repos/AntokBatchelorMaintainers/antok/releases{/id}","created_at":"2014-06-07T19:14:56Z","updated_at":"2014-06-26T14:13:07Z","pushed_at":"2014-06-27T16:59:12Z","git_url":"git://github.com/AntokBatchelorMaintainers/antok.git","ssh_url":"git@github.com:AntokBatchelorMaintainers/antok.git","clone_url":"https://github.com/AntokBatchelorMaintainers/antok.git","svn_url":"https://github.com/AntokBatchelorMaintainers/antok","homepage":null,"size":697,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AntokBatchelorMaintainers/antok/pulls/12"},"html":{"href":"https://github.com/AntokBatchelorMaintainers/antok/pull/12"},"issue":{"href":"https://api.github.com/repos/AntokBatchelorMaintainers/antok/issues/12"},"comments":{"href":"https://api.github.com/repos/AntokBatchelorMaintainers/antok/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/AntokBatchelorMaintainers/antok/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/AntokBatchelorMaintainers/antok/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/AntokBatchelorMaintainers/antok/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/AntokBatchelorMaintainers/antok/statuses/a9972f6d9d2ebafc7bb52d657c109ba14de91e04"}}}}