GitHub PullRequestReviewCommentEvent at 2014-05-29 18:04:24
Repository: socks-rtc
Actor: keroserene
Payload: {"comment":{"url":"https://api.github.com/repos/uProxy/socks-rtc/pulls/comments/13194891","id":13194891,"diff_hunk":"@@ -55,7 +59,17 @@ module SocksToRTC {\n       // Messages received via signalling channel must reach the remote peer\n       // through something other than the peerconnection. (e.g. XMPP)\n       fCore.createChannel().then((chan) => {\n-        this.transport_.setup('SocksToRtc-' + peerId, chan.identifier);\n+        this.transport_.setup('SocksToRtc-' + peerId, chan.identifier).then(\n+          () => {\n+            console.log('SocksToRtc transport_.setup succeeded');","path":"src/socks-to-rtc/socks-to-rtc.ts","position":18,"original_position":18,"commit_id":"74c2aace9c1e5c2309a41a9c7c8fcad5fbaf692e","original_commit_id":"74c2aace9c1e5c2309a41a9c7c8fcad5fbaf692e","user":{"login":"keroserene","id":666963,"avatar_url":"https://avatars.githubusercontent.com/u/666963?","gravatar_id":"25e2cbd2ff043fde7daaf5ce9b8a5e2d","url":"https://api.github.com/users/keroserene","html_url":"https://github.com/keroserene","followers_url":"https://api.github.com/users/keroserene/followers","following_url":"https://api.github.com/users/keroserene/following{/other_user}","gists_url":"https://api.github.com/users/keroserene/gists{/gist_id}","starred_url":"https://api.github.com/users/keroserene/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keroserene/subscriptions","organizations_url":"https://api.github.com/users/keroserene/orgs","repos_url":"https://api.github.com/users/keroserene/repos","events_url":"https://api.github.com/users/keroserene/events{/privacy}","received_events_url":"https://api.github.com/users/keroserene/received_events","type":"User","site_admin":false},"body":"Should the `console.log` and `console.error`s be `dbg*`s? (This way all log messages can be disabled later, if we want)","created_at":"2014-05-29T18:04:24Z","updated_at":"2014-05-29T18:04:24Z","html_url":"https://github.com/uProxy/socks-rtc/pull/84#discussion_r13194891","pull_request_url":"https://api.github.com/repos/uProxy/socks-rtc/pulls/84","_links":{"self":{"href":"https://api.github.com/repos/uProxy/socks-rtc/pulls/comments/13194891"},"html":{"href":"https://github.com/uProxy/socks-rtc/pull/84#discussion_r13194891"},"pull_request":{"href":"https://api.github.com/repos/uProxy/socks-rtc/pulls/84"}}}}