GitHub PullRequestEvent at 2014-11-30 21:47:29
Repository: 18f.gsa.gov
Actor: meiqimichelle
Payload: {"action":"closed","number":402,"pull_request":{"url":"https://api.github.com/repos/18F/18f.gsa.gov/pulls/402","id":25231272,"html_url":"https://github.com/18F/18f.gsa.gov/pull/402","diff_url":"https://github.com/18F/18f.gsa.gov/pull/402.diff","patch_url":"https://github.com/18F/18f.gsa.gov/pull/402.patch","issue_url":"https://api.github.com/repos/18F/18f.gsa.gov/issues/402","number":402,"state":"closed","locked":false,"title":"Fix OpenGraph metadata for Facebook shares","user":{"login":"konklone","id":4592,"avatar_url":"https://avatars.githubusercontent.com/u/4592?v=3","gravatar_id":"","url":"https://api.github.com/users/konklone","html_url":"https://github.com/konklone","followers_url":"https://api.github.com/users/konklone/followers","following_url":"https://api.github.com/users/konklone/following{/other_user}","gists_url":"https://api.github.com/users/konklone/gists{/gist_id}","starred_url":"https://api.github.com/users/konklone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/konklone/subscriptions","organizations_url":"https://api.github.com/users/konklone/orgs","repos_url":"https://api.github.com/users/konklone/repos","events_url":"https://api.github.com/users/konklone/events{/privacy}","received_events_url":"https://api.github.com/users/konklone/received_events","type":"User","site_admin":false},"body":"I used the [Facebook Open Graph debugger](https://developers.facebook.com/tools/debug/) to test our open graph tags, and figured out why they're not working so well.\r\n\r\nThis PR fixes them. Once merged, when we have an image for a post, it will look like this:\r\n\r\n![webhooks](https://cloud.githubusercontent.com/assets/4592/5236893/78e0359e-7829-11e4-9f40-89578bba3e5e.png)\r\n\r\nAnd when we don't, it will look like this:\r\n\r\n![building](https://cloud.githubusercontent.com/assets/4592/5236894/7b651140-7829-11e4-8882-ed1a7327b146.png)\r\n\r\n(These were both taken using [`ngrok`](https://ngrok.com/).)\r\n\r\nThe `og:url` field needed to be the URL of the page itself, not the root of the page. Facebook treats the `og:url` field as a redirect, so Facebook ends up downloading the root page. (Twitter does not do this.)\r\n\r\nThe `og:image` field was a) a broken link, but b) even when fixed, wasn't good enough. Facebook's debugger says the minimum size of an image is 200x200, but their [latest documentation](https://developers.facebook.com/docs/sharing/best-practices) says the minimum is 600x315, and the recommended is 1200x630. Since our 18F logo doesn't fit very well at that size or aspect ratio, I screenshotted the rendered slideshow on the most pleasant-looking image, and added that as the default \"sharing\" image.\r\n\r\nThis image will be overridden when a post specifies its own `image` field in its YAML front-matter, so posts with images should make sure their images are at least `600x315` in size.\r\n\r\nThis PR also updates the image field of the webhooks post, as I neglected to specify the header image as the post's `image`.","created_at":"2014-11-30T05:40:55Z","updated_at":"2014-11-30T21:47:28Z","closed_at":"2014-11-30T21:47:28Z","merged_at":"2014-11-30T21:47:28Z","merge_commit_sha":"926c4dc6cb6cd1d1dafc6b52b8be1dca1c1fa322","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/18F/18f.gsa.gov/pulls/402/commits","review_comments_url":"https://api.github.com/repos/18F/18f.gsa.gov/pulls/402/comments","review_comment_url":"https://api.github.com/repos/18F/18f.gsa.gov/pulls/comments/{number}","comments_url":"https://api.github.com/repos/18F/18f.gsa.gov/issues/402/comments","statuses_url":"https://api.github.com/repos/18F/18f.gsa.gov/statuses/f597df2104966a0b3fbe2fc872d8fe5059545c35","head":{"label":"18F:fix-metadata","ref":"fix-metadata","sha":"f597df2104966a0b3fbe2fc872d8fe5059545c35","user":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"repo":{"id":17324120,"name":"18f.gsa.gov","full_name":"18F/18f.gsa.gov","owner":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/18F/18f.gsa.gov","description":"18F's main website.","fork":false,"url":"https://api.github.com/repos/18F/18f.gsa.gov","forks_url":"https://api.github.com/repos/18F/18f.gsa.gov/forks","keys_url":"https://api.github.com/repos/18F/18f.gsa.gov/keys{/key_id}","collaborators_url":"https://api.github.com/repos/18F/18f.gsa.gov/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/18F/18f.gsa.gov/teams","hooks_url":"https://api.github.com/repos/18F/18f.gsa.gov/hooks","issue_events_url":"https://api.github.com/repos/18F/18f.gsa.gov/issues/events{/number}","events_url":"https://api.github.com/repos/18F/18f.gsa.gov/events","assignees_url":"https://api.github.com/repos/18F/18f.gsa.gov/assignees{/user}","branches_url":"https://api.github.com/repos/18F/18f.gsa.gov/branches{/branch}","tags_url":"https://api.github.com/repos/18F/18f.gsa.gov/tags","blobs_url":"https://api.github.com/repos/18F/18f.gsa.gov/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/18F/18f.gsa.gov/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/18F/18f.gsa.gov/git/refs{/sha}","trees_url":"https://api.github.com/repos/18F/18f.gsa.gov/git/trees{/sha}","statuses_url":"https://api.github.com/repos/18F/18f.gsa.gov/statuses/{sha}","languages_url":"https://api.github.com/repos/18F/18f.gsa.gov/languages","stargazers_url":"https://api.github.com/repos/18F/18f.gsa.gov/stargazers","contributors_url":"https://api.github.com/repos/18F/18f.gsa.gov/contributors","subscribers_url":"https://api.github.com/repos/18F/18f.gsa.gov/subscribers","subscription_url":"https://api.github.com/repos/18F/18f.gsa.gov/subscription","commits_url":"https://api.github.com/repos/18F/18f.gsa.gov/commits{/sha}","git_commits_url":"https://api.github.com/repos/18F/18f.gsa.gov/git/commits{/sha}","comments_url":"https://api.github.com/repos/18F/18f.gsa.gov/comments{/number}","issue_comment_url":"https://api.github.com/repos/18F/18f.gsa.gov/issues/comments/{number}","contents_url":"https://api.github.com/repos/18F/18f.gsa.gov/contents/{+path}","compare_url":"https://api.github.com/repos/18F/18f.gsa.gov/compare/{base}...{head}","merges_url":"https://api.github.com/repos/18F/18f.gsa.gov/merges","archive_url":"https://api.github.com/repos/18F/18f.gsa.gov/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/18F/18f.gsa.gov/downloads","issues_url":"https://api.github.com/repos/18F/18f.gsa.gov/issues{/number}","pulls_url":"https://api.github.com/repos/18F/18f.gsa.gov/pulls{/number}","milestones_url":"https://api.github.com/repos/18F/18f.gsa.gov/milestones{/number}","notifications_url":"https://api.github.com/repos/18F/18f.gsa.gov/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/18F/18f.gsa.gov/labels{/name}","releases_url":"https://api.github.com/repos/18F/18f.gsa.gov/releases{/id}","created_at":"2014-03-01T20:57:14Z","updated_at":"2014-11-28T03:14:35Z","pushed_at":"2014-11-30T21:47:28Z","git_url":"git://github.com/18F/18f.gsa.gov.git","ssh_url":"git@github.com:18F/18f.gsa.gov.git","clone_url":"https://github.com/18F/18f.gsa.gov.git","svn_url":"https://github.com/18F/18f.gsa.gov","homepage":"https://18f.gsa.gov","size":31055,"stargazers_count":29,"watchers_count":29,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":49,"forks":34,"open_issues":49,"watchers":29,"default_branch":"staging"}},"base":{"label":"18F:staging","ref":"staging","sha":"c3c3b14c37a439d3a91adc3e2b4bb7d3239cc3d7","user":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"repo":{"id":17324120,"name":"18f.gsa.gov","full_name":"18F/18f.gsa.gov","owner":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/18F/18f.gsa.gov","description":"18F's main website.","fork":false,"url":"https://api.github.com/repos/18F/18f.gsa.gov","forks_url":"https://api.github.com/repos/18F/18f.gsa.gov/forks","keys_url":"https://api.github.com/repos/18F/18f.gsa.gov/keys{/key_id}","collaborators_url":"https://api.github.com/repos/18F/18f.gsa.gov/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/18F/18f.gsa.gov/teams","hooks_url":"https://api.github.com/repos/18F/18f.gsa.gov/hooks","issue_events_url":"https://api.github.com/repos/18F/18f.gsa.gov/issues/events{/number}","events_url":"https://api.github.com/repos/18F/18f.gsa.gov/events","assignees_url":"https://api.github.com/repos/18F/18f.gsa.gov/assignees{/user}","branches_url":"https://api.github.com/repos/18F/18f.gsa.gov/branches{/branch}","tags_url":"https://api.github.com/repos/18F/18f.gsa.gov/tags","blobs_url":"https://api.github.com/repos/18F/18f.gsa.gov/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/18F/18f.gsa.gov/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/18F/18f.gsa.gov/git/refs{/sha}","trees_url":"https://api.github.com/repos/18F/18f.gsa.gov/git/trees{/sha}","statuses_url":"https://api.github.com/repos/18F/18f.gsa.gov/statuses/{sha}","languages_url":"https://api.github.com/repos/18F/18f.gsa.gov/languages","stargazers_url":"https://api.github.com/repos/18F/18f.gsa.gov/stargazers","contributors_url":"https://api.github.com/repos/18F/18f.gsa.gov/contributors","subscribers_url":"https://api.github.com/repos/18F/18f.gsa.gov/subscribers","subscription_url":"https://api.github.com/repos/18F/18f.gsa.gov/subscription","commits_url":"https://api.github.com/repos/18F/18f.gsa.gov/commits{/sha}","git_commits_url":"https://api.github.com/repos/18F/18f.gsa.gov/git/commits{/sha}","comments_url":"https://api.github.com/repos/18F/18f.gsa.gov/comments{/number}","issue_comment_url":"https://api.github.com/repos/18F/18f.gsa.gov/issues/comments/{number}","contents_url":"https://api.github.com/repos/18F/18f.gsa.gov/contents/{+path}","compare_url":"https://api.github.com/repos/18F/18f.gsa.gov/compare/{base}...{head}","merges_url":"https://api.github.com/repos/18F/18f.gsa.gov/merges","archive_url":"https://api.github.com/repos/18F/18f.gsa.gov/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/18F/18f.gsa.gov/downloads","issues_url":"https://api.github.com/repos/18F/18f.gsa.gov/issues{/number}","pulls_url":"https://api.github.com/repos/18F/18f.gsa.gov/pulls{/number}","milestones_url":"https://api.github.com/repos/18F/18f.gsa.gov/milestones{/number}","notifications_url":"https://api.github.com/repos/18F/18f.gsa.gov/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/18F/18f.gsa.gov/labels{/name}","releases_url":"https://api.github.com/repos/18F/18f.gsa.gov/releases{/id}","created_at":"2014-03-01T20:57:14Z","updated_at":"2014-11-28T03:14:35Z","pushed_at":"2014-11-30T21:47:28Z","git_url":"git://github.com/18F/18f.gsa.gov.git","ssh_url":"git@github.com:18F/18f.gsa.gov.git","clone_url":"https://github.com/18F/18f.gsa.gov.git","svn_url":"https://github.com/18F/18f.gsa.gov","homepage":"https://18f.gsa.gov","size":31055,"stargazers_count":29,"watchers_count":29,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":49,"forks":34,"open_issues":49,"watchers":29,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/18F/18f.gsa.gov/pulls/402"},"html":{"href":"https://github.com/18F/18f.gsa.gov/pull/402"},"issue":{"href":"https://api.github.com/repos/18F/18f.gsa.gov/issues/402"},"comments":{"href":"https://api.github.com/repos/18F/18f.gsa.gov/issues/402/comments"},"review_comments":{"href":"https://api.github.com/repos/18F/18f.gsa.gov/pulls/402/comments"},"review_comment":{"href":"https://api.github.com/repos/18F/18f.gsa.gov/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/18F/18f.gsa.gov/pulls/402/commits"},"statuses":{"href":"https://api.github.com/repos/18F/18f.gsa.gov/statuses/f597df2104966a0b3fbe2fc872d8fe5059545c35"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"meiqimichelle","id":4827522,"avatar_url":"https://avatars.githubusercontent.com/u/4827522?v=3","gravatar_id":"","url":"https://api.github.com/users/meiqimichelle","html_url":"https://github.com/meiqimichelle","followers_url":"https://api.github.com/users/meiqimichelle/followers","following_url":"https://api.github.com/users/meiqimichelle/following{/other_user}","gists_url":"https://api.github.com/users/meiqimichelle/gists{/gist_id}","starred_url":"https://api.github.com/users/meiqimichelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meiqimichelle/subscriptions","organizations_url":"https://api.github.com/users/meiqimichelle/orgs","repos_url":"https://api.github.com/users/meiqimichelle/repos","events_url":"https://api.github.com/users/meiqimichelle/events{/privacy}","received_events_url":"https://api.github.com/users/meiqimichelle/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":3,"additions":5,"deletions":3,"changed_files":2}}