GitHub PullRequestReviewCommentEvent at 2014-12-09 20:44:57
Repository: rails
Actor: arthurnn
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/rails/rails/pulls/comments/21560690","id":21560690,"diff_hunk":"@@ -139,7 +139,8 @@ def save(*)\n     # Attributes marked as readonly are silently ignored if the record is\n     # being updated.\n     def save!(*)\n-      create_or_update || raise(RecordNotSaved.new(nil, self))\n+      create_or_update || raise(RecordNotSaved.new(\"Failed to save the record \" \\\n+                                                   \"because one of the before callbacks returned false\", self))","path":"activerecord/lib/active_record/persistence.rb","position":6,"original_position":6,"commit_id":"f843e8a7833f5b503a378ed2bec9df5197c464f5","original_commit_id":"f843e8a7833f5b503a378ed2bec9df5197c464f5","user":{"login":"arthurnn","id":833383,"avatar_url":"https://avatars.githubusercontent.com/u/833383?v=3","gravatar_id":"","url":"https://api.github.com/users/arthurnn","html_url":"https://github.com/arthurnn","followers_url":"https://api.github.com/users/arthurnn/followers","following_url":"https://api.github.com/users/arthurnn/following{/other_user}","gists_url":"https://api.github.com/users/arthurnn/gists{/gist_id}","starred_url":"https://api.github.com/users/arthurnn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arthurnn/subscriptions","organizations_url":"https://api.github.com/users/arthurnn/orgs","repos_url":"https://api.github.com/users/arthurnn/repos","events_url":"https://api.github.com/users/arthurnn/events{/privacy}","received_events_url":"https://api.github.com/users/arthurnn/received_events","type":"User","site_admin":false},"body":"Talking about callbacks on the `Persistence` module sounds weird, as it should know have any callback concern.","created_at":"2014-12-09T20:44:57Z","updated_at":"2014-12-09T20:44:57Z","html_url":"https://github.com/rails/rails/pull/17824#discussion_r21560690","pull_request_url":"https://api.github.com/repos/rails/rails/pulls/17824","_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/comments/21560690"},"html":{"href":"https://github.com/rails/rails/pull/17824#discussion_r21560690"},"pull_request":{"href":"https://api.github.com/repos/rails/rails/pulls/17824"}}},"pull_request":{"url":"https://api.github.com/repos/rails/rails/pulls/17824","id":25213321,"html_url":"https://github.com/rails/rails/pull/17824","diff_url":"https://github.com/rails/rails/pull/17824.diff","patch_url":"https://github.com/rails/rails/pull/17824.patch","issue_url":"https://api.github.com/repos/rails/rails/issues/17824","number":17824,"state":"open","locked":false,"title":"AR::RecordNotSaved & RecordNotDestroyed from save!/destroy! should include an error message","user":{"login":"yuki24","id":386234,"avatar_url":"https://avatars.githubusercontent.com/u/386234?v=3","gravatar_id":"","url":"https://api.github.com/users/yuki24","html_url":"https://github.com/yuki24","followers_url":"https://api.github.com/users/yuki24/followers","following_url":"https://api.github.com/users/yuki24/following{/other_user}","gists_url":"https://api.github.com/users/yuki24/gists{/gist_id}","starred_url":"https://api.github.com/users/yuki24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuki24/subscriptions","organizations_url":"https://api.github.com/users/yuki24/orgs","repos_url":"https://api.github.com/users/yuki24/repos","events_url":"https://api.github.com/users/yuki24/events{/privacy}","received_events_url":"https://api.github.com/users/yuki24/received_events","type":"User","site_admin":false},"body":"When calling `AR::Base.save!` or `AR::Base.destroy!` and raising one of the exceptions, give a meaningful error message so that people can easily understand why it's failing to save/destroy.\r\n\r\ncc @arthurnn @rafaelfranca","created_at":"2014-11-28T20:48:40Z","updated_at":"2014-12-09T20:44:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a5cc9a31fc16c661583113f89b69820297a82d87","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rails/rails/pulls/17824/commits","review_comments_url":"https://api.github.com/repos/rails/rails/pulls/17824/comments","review_comment_url":"https://api.github.com/repos/rails/rails/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rails/rails/issues/17824/comments","statuses_url":"https://api.github.com/repos/rails/rails/statuses/f843e8a7833f5b503a378ed2bec9df5197c464f5","head":{"label":"yuki24:change-record-not-saved-and-not-destroyed-to-include-error-msg","ref":"change-record-not-saved-and-not-destroyed-to-include-error-msg","sha":"f843e8a7833f5b503a378ed2bec9df5197c464f5","user":{"login":"yuki24","id":386234,"avatar_url":"https://avatars.githubusercontent.com/u/386234?v=3","gravatar_id":"","url":"https://api.github.com/users/yuki24","html_url":"https://github.com/yuki24","followers_url":"https://api.github.com/users/yuki24/followers","following_url":"https://api.github.com/users/yuki24/following{/other_user}","gists_url":"https://api.github.com/users/yuki24/gists{/gist_id}","starred_url":"https://api.github.com/users/yuki24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuki24/subscriptions","organizations_url":"https://api.github.com/users/yuki24/orgs","repos_url":"https://api.github.com/users/yuki24/repos","events_url":"https://api.github.com/users/yuki24/events{/privacy}","received_events_url":"https://api.github.com/users/yuki24/received_events","type":"User","site_admin":false},"repo":{"id":4546410,"name":"rails","full_name":"yuki24/rails","owner":{"login":"yuki24","id":386234,"avatar_url":"https://avatars.githubusercontent.com/u/386234?v=3","gravatar_id":"","url":"https://api.github.com/users/yuki24","html_url":"https://github.com/yuki24","followers_url":"https://api.github.com/users/yuki24/followers","following_url":"https://api.github.com/users/yuki24/following{/other_user}","gists_url":"https://api.github.com/users/yuki24/gists{/gist_id}","starred_url":"https://api.github.com/users/yuki24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuki24/subscriptions","organizations_url":"https://api.github.com/users/yuki24/orgs","repos_url":"https://api.github.com/users/yuki24/repos","events_url":"https://api.github.com/users/yuki24/events{/privacy}","received_events_url":"https://api.github.com/users/yuki24/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yuki24/rails","description":"Ruby on Rails","fork":true,"url":"https://api.github.com/repos/yuki24/rails","forks_url":"https://api.github.com/repos/yuki24/rails/forks","keys_url":"https://api.github.com/repos/yuki24/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yuki24/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yuki24/rails/teams","hooks_url":"https://api.github.com/repos/yuki24/rails/hooks","issue_events_url":"https://api.github.com/repos/yuki24/rails/issues/events{/number}","events_url":"https://api.github.com/repos/yuki24/rails/events","assignees_url":"https://api.github.com/repos/yuki24/rails/assignees{/user}","branches_url":"https://api.github.com/repos/yuki24/rails/branches{/branch}","tags_url":"https://api.github.com/repos/yuki24/rails/tags","blobs_url":"https://api.github.com/repos/yuki24/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yuki24/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yuki24/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/yuki24/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yuki24/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/yuki24/rails/languages","stargazers_url":"https://api.github.com/repos/yuki24/rails/stargazers","contributors_url":"https://api.github.com/repos/yuki24/rails/contributors","subscribers_url":"https://api.github.com/repos/yuki24/rails/subscribers","subscription_url":"https://api.github.com/repos/yuki24/rails/subscription","commits_url":"https://api.github.com/repos/yuki24/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/yuki24/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/yuki24/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/yuki24/rails/issues/comments/{number}","contents_url":"https://api.github.com/repos/yuki24/rails/contents/{+path}","compare_url":"https://api.github.com/repos/yuki24/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yuki24/rails/merges","archive_url":"https://api.github.com/repos/yuki24/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yuki24/rails/downloads","issues_url":"https://api.github.com/repos/yuki24/rails/issues{/number}","pulls_url":"https://api.github.com/repos/yuki24/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/yuki24/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/yuki24/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yuki24/rails/labels{/name}","releases_url":"https://api.github.com/repos/yuki24/rails/releases{/id}","created_at":"2012-06-04T11:33:47Z","updated_at":"2014-11-28T20:37:31Z","pushed_at":"2014-11-28T20:47:21Z","git_url":"git://github.com/yuki24/rails.git","ssh_url":"git@github.com:yuki24/rails.git","clone_url":"https://github.com/yuki24/rails.git","svn_url":"https://github.com/yuki24/rails","homepage":"http://rubyonrails.org","size":123813,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"rails:master","ref":"master","sha":"b599f99281d54047751e48789c44b73ccaec124c","user":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"repo":{"id":8514,"name":"rails","full_name":"rails/rails","owner":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rails/rails","description":"Ruby on Rails","fork":false,"url":"https://api.github.com/repos/rails/rails","forks_url":"https://api.github.com/repos/rails/rails/forks","keys_url":"https://api.github.com/repos/rails/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails/rails/teams","hooks_url":"https://api.github.com/repos/rails/rails/hooks","issue_events_url":"https://api.github.com/repos/rails/rails/issues/events{/number}","events_url":"https://api.github.com/repos/rails/rails/events","assignees_url":"https://api.github.com/repos/rails/rails/assignees{/user}","branches_url":"https://api.github.com/repos/rails/rails/branches{/branch}","tags_url":"https://api.github.com/repos/rails/rails/tags","blobs_url":"https://api.github.com/repos/rails/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/rails/rails/languages","stargazers_url":"https://api.github.com/repos/rails/rails/stargazers","contributors_url":"https://api.github.com/repos/rails/rails/contributors","subscribers_url":"https://api.github.com/repos/rails/rails/subscribers","subscription_url":"https://api.github.com/repos/rails/rails/subscription","commits_url":"https://api.github.com/repos/rails/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails/rails/issues/comments/{number}","contents_url":"https://api.github.com/repos/rails/rails/contents/{+path}","compare_url":"https://api.github.com/repos/rails/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails/rails/merges","archive_url":"https://api.github.com/repos/rails/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails/rails/downloads","issues_url":"https://api.github.com/repos/rails/rails/issues{/number}","pulls_url":"https://api.github.com/repos/rails/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/rails/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/rails/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails/rails/labels{/name}","releases_url":"https://api.github.com/repos/rails/rails/releases{/id}","created_at":"2008-04-11T02:19:47Z","updated_at":"2014-12-09T18:49:06Z","pushed_at":"2014-12-09T17:39:08Z","git_url":"git://github.com/rails/rails.git","ssh_url":"git@github.com:rails/rails.git","clone_url":"https://github.com/rails/rails.git","svn_url":"https://github.com/rails/rails","homepage":"http://rubyonrails.org","size":352443,"stargazers_count":24217,"watchers_count":24217,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9316,"mirror_url":null,"open_issues_count":778,"forks":9316,"open_issues":778,"watchers":24217,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/17824"},"html":{"href":"https://github.com/rails/rails/pull/17824"},"issue":{"href":"https://api.github.com/repos/rails/rails/issues/17824"},"comments":{"href":"https://api.github.com/repos/rails/rails/issues/17824/comments"},"review_comments":{"href":"https://api.github.com/repos/rails/rails/pulls/17824/comments"},"review_comment":{"href":"https://api.github.com/repos/rails/rails/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rails/rails/pulls/17824/commits"},"statuses":{"href":"https://api.github.com/repos/rails/rails/statuses/f843e8a7833f5b503a378ed2bec9df5197c464f5"}}}}