GitHub PullRequestReviewCommentEvent at 2014-08-01 04:15:50
Repository: Chats
Actor: mattdipasquale
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/acani/Chats/pulls/comments/15681903","id":15681903,"diff_hunk":"@@ -1,13 +1,15 @@\n+import UIKit","path":"Chats/Chats/User.swift","position":1,"original_position":1,"commit_id":"d97d76bf98cac06b30569ee14b519b22e598d0f0","original_commit_id":"d97d76bf98cac06b30569ee14b519b22e598d0f0","user":{"login":"mattdipasquale","id":17276,"avatar_url":"https://avatars.githubusercontent.com/u/17276?v=1","gravatar_id":"7e6e0e2b73358e47e0b7f83f8111f75b","url":"https://api.github.com/users/mattdipasquale","html_url":"https://github.com/mattdipasquale","followers_url":"https://api.github.com/users/mattdipasquale/followers","following_url":"https://api.github.com/users/mattdipasquale/following{/other_user}","gists_url":"https://api.github.com/users/mattdipasquale/gists{/gist_id}","starred_url":"https://api.github.com/users/mattdipasquale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattdipasquale/subscriptions","organizations_url":"https://api.github.com/users/mattdipasquale/orgs","repos_url":"https://api.github.com/users/mattdipasquale/repos","events_url":"https://api.github.com/users/mattdipasquale/events{/privacy}","received_events_url":"https://api.github.com/users/mattdipasquale/received_events","type":"User","site_admin":false},"body":"`UIKit` is not needed if we get rid of `UIImage`. I don't think `UIKit` should be used in model files. I prefer separating the model from the view. `UIKit` is related to the view. The model shouldn't decide anything about the user interface.","created_at":"2014-08-01T04:15:50Z","updated_at":"2014-08-01T04:15:50Z","html_url":"https://github.com/acani/Chats/pull/33#discussion_r15681903","pull_request_url":"https://api.github.com/repos/acani/Chats/pulls/33","_links":{"self":{"href":"https://api.github.com/repos/acani/Chats/pulls/comments/15681903"},"html":{"href":"https://github.com/acani/Chats/pull/33#discussion_r15681903"},"pull_request":{"href":"https://api.github.com/repos/acani/Chats/pulls/33"}}},"pull_request":{"url":"https://api.github.com/repos/acani/Chats/pulls/33","id":18953261,"html_url":"https://github.com/acani/Chats/pull/33","diff_url":"https://github.com/acani/Chats/pull/33.diff","patch_url":"https://github.com/acani/Chats/pull/33.patch","issue_url":"https://api.github.com/repos/acani/Chats/issues/33","number":33,"state":"closed","title":"New feature: profile image view now shows initials when user doesn't have a profile picture","user":{"login":"DJBen","id":2078653,"avatar_url":"https://avatars.githubusercontent.com/u/2078653?v=1","gravatar_id":"fef72c5c3f79f6635fac2f61b84e84c2","url":"https://api.github.com/users/DJBen","html_url":"https://github.com/DJBen","followers_url":"https://api.github.com/users/DJBen/followers","following_url":"https://api.github.com/users/DJBen/following{/other_user}","gists_url":"https://api.github.com/users/DJBen/gists{/gist_id}","starred_url":"https://api.github.com/users/DJBen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DJBen/subscriptions","organizations_url":"https://api.github.com/users/DJBen/orgs","repos_url":"https://api.github.com/users/DJBen/repos","events_url":"https://api.github.com/users/DJBen/events{/privacy}","received_events_url":"https://api.github.com/users/DJBen/received_events","type":"User","site_admin":false},"body":"If any user doesn't have a profile picture, his/her name initials will show up in the profile picture area instead.\r\n\r\nAlso updated the insets of chat bubbles to make them more similar to native chat app.\r\nScreenshot attached.\r\n\r\nThe `ID` property of `User` is deleted because it's only related to the profile picture name and nothing else. This will give developers more freedom.\r\n\r\n![ios simulator screen shot jul 28 2014 1 11 57 am](https://cloud.githubusercontent.com/assets/2078653/3717951/e232224e-162e-11e4-916b-b0edf2e2d676.png)\r\n\r\n![ios simulator screen shot jul 28 2014 12 39 11 am](https://cloud.githubusercontent.com/assets/2078653/3717707/588af916-162a-11e4-978a-a8aa5bb1ba7b.png)","created_at":"2014-07-28T07:41:18Z","updated_at":"2014-08-01T04:15:50Z","closed_at":"2014-08-01T04:07:25Z","merged_at":"2014-08-01T04:07:25Z","merge_commit_sha":"5ae25083e8683cbc1078bc1fc871d3ace2761e51","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/acani/Chats/pulls/33/commits","review_comments_url":"https://api.github.com/repos/acani/Chats/pulls/33/comments","review_comment_url":"https://api.github.com/repos/acani/Chats/pulls/comments/{number}","comments_url":"https://api.github.com/repos/acani/Chats/issues/33/comments","statuses_url":"https://api.github.com/repos/acani/Chats/statuses/d97d76bf98cac06b30569ee14b519b22e598d0f0","head":{"label":"DJBen:master","ref":"master","sha":"d97d76bf98cac06b30569ee14b519b22e598d0f0","user":{"login":"DJBen","id":2078653,"avatar_url":"https://avatars.githubusercontent.com/u/2078653?v=1","gravatar_id":"fef72c5c3f79f6635fac2f61b84e84c2","url":"https://api.github.com/users/DJBen","html_url":"https://github.com/DJBen","followers_url":"https://api.github.com/users/DJBen/followers","following_url":"https://api.github.com/users/DJBen/following{/other_user}","gists_url":"https://api.github.com/users/DJBen/gists{/gist_id}","starred_url":"https://api.github.com/users/DJBen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DJBen/subscriptions","organizations_url":"https://api.github.com/users/DJBen/orgs","repos_url":"https://api.github.com/users/DJBen/repos","events_url":"https://api.github.com/users/DJBen/events{/privacy}","received_events_url":"https://api.github.com/users/DJBen/received_events","type":"User","site_admin":false},"repo":{"id":22330457,"name":"Chats","full_name":"DJBen/Chats","owner":{"login":"DJBen","id":2078653,"avatar_url":"https://avatars.githubusercontent.com/u/2078653?v=1","gravatar_id":"fef72c5c3f79f6635fac2f61b84e84c2","url":"https://api.github.com/users/DJBen","html_url":"https://github.com/DJBen","followers_url":"https://api.github.com/users/DJBen/followers","following_url":"https://api.github.com/users/DJBen/following{/other_user}","gists_url":"https://api.github.com/users/DJBen/gists{/gist_id}","starred_url":"https://api.github.com/users/DJBen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DJBen/subscriptions","organizations_url":"https://api.github.com/users/DJBen/orgs","repos_url":"https://api.github.com/users/DJBen/repos","events_url":"https://api.github.com/users/DJBen/events{/privacy}","received_events_url":"https://api.github.com/users/DJBen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DJBen/Chats","description":"Open-Source Native iPhone Messages App","fork":true,"url":"https://api.github.com/repos/DJBen/Chats","forks_url":"https://api.github.com/repos/DJBen/Chats/forks","keys_url":"https://api.github.com/repos/DJBen/Chats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DJBen/Chats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DJBen/Chats/teams","hooks_url":"https://api.github.com/repos/DJBen/Chats/hooks","issue_events_url":"https://api.github.com/repos/DJBen/Chats/issues/events{/number}","events_url":"https://api.github.com/repos/DJBen/Chats/events","assignees_url":"https://api.github.com/repos/DJBen/Chats/assignees{/user}","branches_url":"https://api.github.com/repos/DJBen/Chats/branches{/branch}","tags_url":"https://api.github.com/repos/DJBen/Chats/tags","blobs_url":"https://api.github.com/repos/DJBen/Chats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DJBen/Chats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DJBen/Chats/git/refs{/sha}","trees_url":"https://api.github.com/repos/DJBen/Chats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DJBen/Chats/statuses/{sha}","languages_url":"https://api.github.com/repos/DJBen/Chats/languages","stargazers_url":"https://api.github.com/repos/DJBen/Chats/stargazers","contributors_url":"https://api.github.com/repos/DJBen/Chats/contributors","subscribers_url":"https://api.github.com/repos/DJBen/Chats/subscribers","subscription_url":"https://api.github.com/repos/DJBen/Chats/subscription","commits_url":"https://api.github.com/repos/DJBen/Chats/commits{/sha}","git_commits_url":"https://api.github.com/repos/DJBen/Chats/git/commits{/sha}","comments_url":"https://api.github.com/repos/DJBen/Chats/comments{/number}","issue_comment_url":"https://api.github.com/repos/DJBen/Chats/issues/comments/{number}","contents_url":"https://api.github.com/repos/DJBen/Chats/contents/{+path}","compare_url":"https://api.github.com/repos/DJBen/Chats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DJBen/Chats/merges","archive_url":"https://api.github.com/repos/DJBen/Chats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DJBen/Chats/downloads","issues_url":"https://api.github.com/repos/DJBen/Chats/issues{/number}","pulls_url":"https://api.github.com/repos/DJBen/Chats/pulls{/number}","milestones_url":"https://api.github.com/repos/DJBen/Chats/milestones{/number}","notifications_url":"https://api.github.com/repos/DJBen/Chats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DJBen/Chats/labels{/name}","releases_url":"https://api.github.com/repos/DJBen/Chats/releases{/id}","created_at":"2014-07-28T04:04:29Z","updated_at":"2014-07-28T07:35:07Z","pushed_at":"2014-07-28T08:06:41Z","git_url":"git://github.com/DJBen/Chats.git","ssh_url":"git@github.com:DJBen/Chats.git","clone_url":"https://github.com/DJBen/Chats.git","svn_url":"https://github.com/DJBen/Chats","homepage":"","size":1800,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"acani:master","ref":"master","sha":"c84328ec1b9ae03b399f513cc606d50d398ee800","user":{"login":"acani","id":301345,"avatar_url":"https://avatars.githubusercontent.com/u/301345?v=1","gravatar_id":"e7da3b93b5daf7b25d3c30aa62434b54","url":"https://api.github.com/users/acani","html_url":"https://github.com/acani","followers_url":"https://api.github.com/users/acani/followers","following_url":"https://api.github.com/users/acani/following{/other_user}","gists_url":"https://api.github.com/users/acani/gists{/gist_id}","starred_url":"https://api.github.com/users/acani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acani/subscriptions","organizations_url":"https://api.github.com/users/acani/orgs","repos_url":"https://api.github.com/users/acani/repos","events_url":"https://api.github.com/users/acani/events{/privacy}","received_events_url":"https://api.github.com/users/acani/received_events","type":"Organization","site_admin":false},"repo":{"id":1571229,"name":"Chats","full_name":"acani/Chats","owner":{"login":"acani","id":301345,"avatar_url":"https://avatars.githubusercontent.com/u/301345?v=1","gravatar_id":"e7da3b93b5daf7b25d3c30aa62434b54","url":"https://api.github.com/users/acani","html_url":"https://github.com/acani","followers_url":"https://api.github.com/users/acani/followers","following_url":"https://api.github.com/users/acani/following{/other_user}","gists_url":"https://api.github.com/users/acani/gists{/gist_id}","starred_url":"https://api.github.com/users/acani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acani/subscriptions","organizations_url":"https://api.github.com/users/acani/orgs","repos_url":"https://api.github.com/users/acani/repos","events_url":"https://api.github.com/users/acani/events{/privacy}","received_events_url":"https://api.github.com/users/acani/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/acani/Chats","description":"Open-Source Native iPhone Messages App","fork":false,"url":"https://api.github.com/repos/acani/Chats","forks_url":"https://api.github.com/repos/acani/Chats/forks","keys_url":"https://api.github.com/repos/acani/Chats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/acani/Chats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/acani/Chats/teams","hooks_url":"https://api.github.com/repos/acani/Chats/hooks","issue_events_url":"https://api.github.com/repos/acani/Chats/issues/events{/number}","events_url":"https://api.github.com/repos/acani/Chats/events","assignees_url":"https://api.github.com/repos/acani/Chats/assignees{/user}","branches_url":"https://api.github.com/repos/acani/Chats/branches{/branch}","tags_url":"https://api.github.com/repos/acani/Chats/tags","blobs_url":"https://api.github.com/repos/acani/Chats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/acani/Chats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/acani/Chats/git/refs{/sha}","trees_url":"https://api.github.com/repos/acani/Chats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/acani/Chats/statuses/{sha}","languages_url":"https://api.github.com/repos/acani/Chats/languages","stargazers_url":"https://api.github.com/repos/acani/Chats/stargazers","contributors_url":"https://api.github.com/repos/acani/Chats/contributors","subscribers_url":"https://api.github.com/repos/acani/Chats/subscribers","subscription_url":"https://api.github.com/repos/acani/Chats/subscription","commits_url":"https://api.github.com/repos/acani/Chats/commits{/sha}","git_commits_url":"https://api.github.com/repos/acani/Chats/git/commits{/sha}","comments_url":"https://api.github.com/repos/acani/Chats/comments{/number}","issue_comment_url":"https://api.github.com/repos/acani/Chats/issues/comments/{number}","contents_url":"https://api.github.com/repos/acani/Chats/contents/{+path}","compare_url":"https://api.github.com/repos/acani/Chats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/acani/Chats/merges","archive_url":"https://api.github.com/repos/acani/Chats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/acani/Chats/downloads","issues_url":"https://api.github.com/repos/acani/Chats/issues{/number}","pulls_url":"https://api.github.com/repos/acani/Chats/pulls{/number}","milestones_url":"https://api.github.com/repos/acani/Chats/milestones{/number}","notifications_url":"https://api.github.com/repos/acani/Chats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/acani/Chats/labels{/name}","releases_url":"https://api.github.com/repos/acani/Chats/releases{/id}","created_at":"2011-04-05T08:32:55Z","updated_at":"2014-07-31T11:19:33Z","pushed_at":"2014-08-01T04:07:25Z","git_url":"git://github.com/acani/Chats.git","ssh_url":"git@github.com:acani/Chats.git","clone_url":"https://github.com/acani/Chats.git","svn_url":"https://github.com/acani/Chats","homepage":"","size":1800,"stargazers_count":726,"watchers_count":726,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":153,"mirror_url":null,"open_issues_count":21,"forks":153,"open_issues":21,"watchers":726,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/acani/Chats/pulls/33"},"html":{"href":"https://github.com/acani/Chats/pull/33"},"issue":{"href":"https://api.github.com/repos/acani/Chats/issues/33"},"comments":{"href":"https://api.github.com/repos/acani/Chats/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/acani/Chats/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/acani/Chats/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/acani/Chats/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/acani/Chats/statuses/d97d76bf98cac06b30569ee14b519b22e598d0f0"}}}}