GitHub PullRequestReviewCommentEvent at 2014-02-17 14:10:44
Repository: gaia
Actor: davehunt
Payload: {"comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/9792487","id":9792487,"diff_hunk":"@@ -168,11 +164,38 @@ def check(now):\n             time.sleep(2)\n         raise TimeoutException('Could not switch to app frame %s in time' % app_frame)\n \n+class GaiaFrameManager(object):\n+\n+    def __init__(self, marionette):\n+        self.marionette = marionette\n+\n+    @property\n+    def _element_from_center_point(self):\n+        return self.marionette.execute_script(\n+            \"return document.elementFromPoint(window.innerWidth/2, window.innerHeight/2)\")\n+\n+    @property\n+    def top_frame(self):\n+        self.marionette.switch_to_frame()","path":"tests/python/gaia-ui-tests/gaiatest/gaia_test.py","position":27,"original_position":27,"commit_id":"1a09347a8bcc0c58e6c1ad1fc96e6eba01f16cf9","original_commit_id":"1a09347a8bcc0c58e6c1ad1fc96e6eba01f16cf9","user":{"login":"davehunt","id":122800,"avatar_url":"https://gravatar.com/avatar/fd74178aadc963ffc6397ad1e22d8ce7?d=https%3A%2F%2Fidenticons.github.com%2F40947268c085716bd36a68d080755d7f.png&r=x","gravatar_id":"fd74178aadc963ffc6397ad1e22d8ce7","url":"https://api.github.com/users/davehunt","html_url":"https://github.com/davehunt","followers_url":"https://api.github.com/users/davehunt/followers","following_url":"https://api.github.com/users/davehunt/following{/other_user}","gists_url":"https://api.github.com/users/davehunt/gists{/gist_id}","starred_url":"https://api.github.com/users/davehunt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davehunt/subscriptions","organizations_url":"https://api.github.com/users/davehunt/orgs","repos_url":"https://api.github.com/users/davehunt/repos","events_url":"https://api.github.com/users/davehunt/events{/privacy}","received_events_url":"https://api.github.com/users/davehunt/received_events","type":"User","site_admin":false},"body":"This switches to the system context and doesn't switch back. I'm concerned that this would cause unexpected results as the context will change for any code calling this.","created_at":"2014-02-17T14:10:44Z","updated_at":"2014-02-17T14:10:44Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/15954#discussion_r9792487","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/15954","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/9792487"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/15954#discussion_r9792487"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/15954"}}}}