GitHub PushEvent at 2014-12-22 16:43:41
Repository: markup_calc
Actor: avissernu
Payload: {"shas":[["538a61509b0a64829dc4144d785b3cba9c7b6115","6f9019a59c51da7447ae804dd2cbe5203f6f90ac@localhost","Basic Setup Complete\n\nFigured out unit tests in ruby.\nHave temp product object, needs to be replaced with mock obj","avissernu",true],["6935e95b6a04ede820b2e6c7021ef4081b631079","6f9019a59c51da7447ae804dd2cbe5203f6f90ac@localhost","Setup Mocking in Tests\n\nMocked in tests using minitest::mock\nRemoved product class","avissernu",true],["dbac3041a2c78f7677a36232ea5d1633873fc123","6f9019a59c51da7447ae804dd2cbe5203f6f90ac@localhost","Adding more Error conditions\n\nRaise exceptions when we don't have a usable product object\nchange strings to symbols, believe this is better practice in ruby","avissernu",true],["e9dab7322b71acbde3c5a062a220272fd1d05c91","6f9019a59c51da7447ae804dd2cbe5203f6f90ac@localhost","Refactored to static class\n\nThe MarkupCalculator is written with only a single entry point\nWe can refactor this to be a static class, this could be a problem\n  for dependency injection, need to discuss how this will be used\n  around the rest of a codebase. As a standalone lib, I think this\n  makes sense","avissernu",true],["f7ac108a52d3dfbfdff8c8a7c13d8d09ca398408","6f9019a59c51da7447ae804dd2cbe5203f6f90ac@localhost","Adding Input Validation\n\nBasic input validation/Casting for input data. Should prevent, or at\nleast indicate a problem on invalid input data","avissernu",true],["333d493475a2e85678bb434797b26401aea9701d","6f9019a59c51da7447ae804dd2cbe5203f6f90ac@localhost","Adding README\n\nLayout the interfaces I expect for Product and Category\nProvide basic instructions on running tests","avissernu",true],["90aa74827fc5e34576bc1a1219860eae7646af86","6f9019a59c51da7447ae804dd2cbe5203f6f90ac@localhost","Update README for spelling/grammer and clarity","avissernu",true]],"size":7,"ref":"refs/heads/master","head":"90aa74827fc5e34576bc1a1219860eae7646af86"}