GitHub PullRequestReviewCommentEvent at 2014-11-24 10:41:54
Repository: d3-financial-components
Actor: jleft
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/ScottLogic/d3-financial-components/pulls/comments/20782478","id":20782478,"diff_hunk":"@@ -0,0 +1,206 @@\n+(function (d3, sl) {\n+    'use strict';\n+\n+    sl.tools.callouts = function () {\n+\n+        var xScale = d3.time.scale(),\n+            yScale = d3.scale.linear(),\n+            padding = 5,\n+            spacing = 5,\n+            rounded = 0,\n+            rotationStart = 20,\n+            rotationSteps = 20,\n+            stalkLength = 50,\n+            css = 'callout',\n+            data = [];\n+\n+    \tvar currentBB = null,\n+    \t\tboundingBoxes = [],\n+    \t\tcurrentRotation = 0;\n+\n+    \tvar rectanglesIntersect = function() {\n+    \t\treturn true;\n+    \t}","path":"components/tools/callouts.js","position":23,"original_position":23,"commit_id":"a5310dd8a80ffa14383ba6dbd81699ddf0941b17","original_commit_id":"a5310dd8a80ffa14383ba6dbd81699ddf0941b17","user":{"login":"jleft","id":2017615,"avatar_url":"https://avatars.githubusercontent.com/u/2017615?v=3","gravatar_id":"","url":"https://api.github.com/users/jleft","html_url":"https://github.com/jleft","followers_url":"https://api.github.com/users/jleft/followers","following_url":"https://api.github.com/users/jleft/following{/other_user}","gists_url":"https://api.github.com/users/jleft/gists{/gist_id}","starred_url":"https://api.github.com/users/jleft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jleft/subscriptions","organizations_url":"https://api.github.com/users/jleft/orgs","repos_url":"https://api.github.com/users/jleft/repos","events_url":"https://api.github.com/users/jleft/events{/privacy}","received_events_url":"https://api.github.com/users/jleft/received_events","type":"User","site_admin":false},"body":"Ideally, these function expressions should end with a `;`","created_at":"2014-11-24T10:41:54Z","updated_at":"2014-11-24T10:41:54Z","html_url":"https://github.com/ScottLogic/d3-financial-components/pull/70#discussion_r20782478","pull_request_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/pulls/70","_links":{"self":{"href":"https://api.github.com/repos/ScottLogic/d3-financial-components/pulls/comments/20782478"},"html":{"href":"https://github.com/ScottLogic/d3-financial-components/pull/70#discussion_r20782478"},"pull_request":{"href":"https://api.github.com/repos/ScottLogic/d3-financial-components/pulls/70"}}},"pull_request":{"url":"https://api.github.com/repos/ScottLogic/d3-financial-components/pulls/70","id":24922895,"html_url":"https://github.com/ScottLogic/d3-financial-components/pull/70","diff_url":"https://github.com/ScottLogic/d3-financial-components/pull/70.diff","patch_url":"https://github.com/ScottLogic/d3-financial-components/pull/70.patch","issue_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/issues/70","number":70,"state":"open","locked":false,"title":"Examples recreations of existing charts past and present.","user":{"login":"tunerscafe","id":9034374,"avatar_url":"https://avatars.githubusercontent.com/u/9034374?v=3","gravatar_id":"","url":"https://api.github.com/users/tunerscafe","html_url":"https://github.com/tunerscafe","followers_url":"https://api.github.com/users/tunerscafe/followers","following_url":"https://api.github.com/users/tunerscafe/following{/other_user}","gists_url":"https://api.github.com/users/tunerscafe/gists{/gist_id}","starred_url":"https://api.github.com/users/tunerscafe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tunerscafe/subscriptions","organizations_url":"https://api.github.com/users/tunerscafe/orgs","repos_url":"https://api.github.com/users/tunerscafe/repos","events_url":"https://api.github.com/users/tunerscafe/events{/privacy}","received_events_url":"https://api.github.com/users/tunerscafe/received_events","type":"User","site_admin":false},"body":"These charts required a new lines series and callout component, documentation to follow.","created_at":"2014-11-24T10:15:38Z","updated_at":"2014-11-24T10:41:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b778bfc475948738052e804295cd00d9ba2b1be0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/pulls/70/commits","review_comments_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/pulls/70/comments","review_comment_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/issues/70/comments","statuses_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/statuses/a5310dd8a80ffa14383ba6dbd81699ddf0941b17","head":{"label":"tunerscafe:master","ref":"master","sha":"a5310dd8a80ffa14383ba6dbd81699ddf0941b17","user":{"login":"tunerscafe","id":9034374,"avatar_url":"https://avatars.githubusercontent.com/u/9034374?v=3","gravatar_id":"","url":"https://api.github.com/users/tunerscafe","html_url":"https://github.com/tunerscafe","followers_url":"https://api.github.com/users/tunerscafe/followers","following_url":"https://api.github.com/users/tunerscafe/following{/other_user}","gists_url":"https://api.github.com/users/tunerscafe/gists{/gist_id}","starred_url":"https://api.github.com/users/tunerscafe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tunerscafe/subscriptions","organizations_url":"https://api.github.com/users/tunerscafe/orgs","repos_url":"https://api.github.com/users/tunerscafe/repos","events_url":"https://api.github.com/users/tunerscafe/events{/privacy}","received_events_url":"https://api.github.com/users/tunerscafe/received_events","type":"User","site_admin":false},"repo":{"id":26111759,"name":"d3-financial-components","full_name":"tunerscafe/d3-financial-components","owner":{"login":"tunerscafe","id":9034374,"avatar_url":"https://avatars.githubusercontent.com/u/9034374?v=3","gravatar_id":"","url":"https://api.github.com/users/tunerscafe","html_url":"https://github.com/tunerscafe","followers_url":"https://api.github.com/users/tunerscafe/followers","following_url":"https://api.github.com/users/tunerscafe/following{/other_user}","gists_url":"https://api.github.com/users/tunerscafe/gists{/gist_id}","starred_url":"https://api.github.com/users/tunerscafe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tunerscafe/subscriptions","organizations_url":"https://api.github.com/users/tunerscafe/orgs","repos_url":"https://api.github.com/users/tunerscafe/repos","events_url":"https://api.github.com/users/tunerscafe/events{/privacy}","received_events_url":"https://api.github.com/users/tunerscafe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tunerscafe/d3-financial-components","description":"A set of re-useable components for building financial charts with D3","fork":true,"url":"https://api.github.com/repos/tunerscafe/d3-financial-components","forks_url":"https://api.github.com/repos/tunerscafe/d3-financial-components/forks","keys_url":"https://api.github.com/repos/tunerscafe/d3-financial-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tunerscafe/d3-financial-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tunerscafe/d3-financial-components/teams","hooks_url":"https://api.github.com/repos/tunerscafe/d3-financial-components/hooks","issue_events_url":"https://api.github.com/repos/tunerscafe/d3-financial-components/issues/events{/number}","events_url":"https://api.github.com/repos/tunerscafe/d3-financial-components/events","assignees_url":"https://api.github.com/repos/tunerscafe/d3-financial-components/assignees{/user}","branches_url":"https://api.github.com/repos/tunerscafe/d3-financial-components/branches{/branch}","tags_url":"https://api.github.com/repos/tunerscafe/d3-financial-components/tags","blobs_url":"https://api.github.com/repos/tunerscafe/d3-financial-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tunerscafe/d3-financial-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tunerscafe/d3-financial-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/tunerscafe/d3-financial-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tunerscafe/d3-financial-components/statuses/{sha}","languages_url":"https://api.github.com/repos/tunerscafe/d3-financial-components/languages","stargazers_url":"https://api.github.com/repos/tunerscafe/d3-financial-components/stargazers","contributors_url":"https://api.github.com/repos/tunerscafe/d3-financial-components/contributors","subscribers_url":"https://api.github.com/repos/tunerscafe/d3-financial-components/subscribers","subscription_url":"https://api.github.com/repos/tunerscafe/d3-financial-components/subscription","commits_url":"https://api.github.com/repos/tunerscafe/d3-financial-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/tunerscafe/d3-financial-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/tunerscafe/d3-financial-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/tunerscafe/d3-financial-components/issues/comments/{number}","contents_url":"https://api.github.com/repos/tunerscafe/d3-financial-components/contents/{+path}","compare_url":"https://api.github.com/repos/tunerscafe/d3-financial-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tunerscafe/d3-financial-components/merges","archive_url":"https://api.github.com/repos/tunerscafe/d3-financial-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tunerscafe/d3-financial-components/downloads","issues_url":"https://api.github.com/repos/tunerscafe/d3-financial-components/issues{/number}","pulls_url":"https://api.github.com/repos/tunerscafe/d3-financial-components/pulls{/number}","milestones_url":"https://api.github.com/repos/tunerscafe/d3-financial-components/milestones{/number}","notifications_url":"https://api.github.com/repos/tunerscafe/d3-financial-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tunerscafe/d3-financial-components/labels{/name}","releases_url":"https://api.github.com/repos/tunerscafe/d3-financial-components/releases{/id}","created_at":"2014-11-03T09:24:21Z","updated_at":"2014-11-24T10:20:07Z","pushed_at":"2014-11-24T10:20:07Z","git_url":"git://github.com/tunerscafe/d3-financial-components.git","ssh_url":"git@github.com:tunerscafe/d3-financial-components.git","clone_url":"https://github.com/tunerscafe/d3-financial-components.git","svn_url":"https://github.com/tunerscafe/d3-financial-components","homepage":"","size":1795,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ScottLogic:master","ref":"master","sha":"9381f47e412fde139a35e68114c4b4ba6e1081c9","user":{"login":"ScottLogic","id":2046037,"avatar_url":"https://avatars.githubusercontent.com/u/2046037?v=3","gravatar_id":"","url":"https://api.github.com/users/ScottLogic","html_url":"https://github.com/ScottLogic","followers_url":"https://api.github.com/users/ScottLogic/followers","following_url":"https://api.github.com/users/ScottLogic/following{/other_user}","gists_url":"https://api.github.com/users/ScottLogic/gists{/gist_id}","starred_url":"https://api.github.com/users/ScottLogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScottLogic/subscriptions","organizations_url":"https://api.github.com/users/ScottLogic/orgs","repos_url":"https://api.github.com/users/ScottLogic/repos","events_url":"https://api.github.com/users/ScottLogic/events{/privacy}","received_events_url":"https://api.github.com/users/ScottLogic/received_events","type":"Organization","site_admin":false},"repo":{"id":24850617,"name":"d3-financial-components","full_name":"ScottLogic/d3-financial-components","owner":{"login":"ScottLogic","id":2046037,"avatar_url":"https://avatars.githubusercontent.com/u/2046037?v=3","gravatar_id":"","url":"https://api.github.com/users/ScottLogic","html_url":"https://github.com/ScottLogic","followers_url":"https://api.github.com/users/ScottLogic/followers","following_url":"https://api.github.com/users/ScottLogic/following{/other_user}","gists_url":"https://api.github.com/users/ScottLogic/gists{/gist_id}","starred_url":"https://api.github.com/users/ScottLogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScottLogic/subscriptions","organizations_url":"https://api.github.com/users/ScottLogic/orgs","repos_url":"https://api.github.com/users/ScottLogic/repos","events_url":"https://api.github.com/users/ScottLogic/events{/privacy}","received_events_url":"https://api.github.com/users/ScottLogic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ScottLogic/d3-financial-components","description":"A set of re-useable components for building financial charts with D3","fork":false,"url":"https://api.github.com/repos/ScottLogic/d3-financial-components","forks_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/forks","keys_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/teams","hooks_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/hooks","issue_events_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/issues/events{/number}","events_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/events","assignees_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/assignees{/user}","branches_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/branches{/branch}","tags_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/tags","blobs_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/statuses/{sha}","languages_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/languages","stargazers_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/stargazers","contributors_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/contributors","subscribers_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/subscribers","subscription_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/subscription","commits_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/issues/comments/{number}","contents_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/contents/{+path}","compare_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/merges","archive_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/downloads","issues_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/issues{/number}","pulls_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/pulls{/number}","milestones_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/milestones{/number}","notifications_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/labels{/name}","releases_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/releases{/id}","created_at":"2014-10-06T15:03:11Z","updated_at":"2014-11-22T00:03:20Z","pushed_at":"2014-11-21T15:58:33Z","git_url":"git://github.com/ScottLogic/d3-financial-components.git","ssh_url":"git@github.com:ScottLogic/d3-financial-components.git","clone_url":"https://github.com/ScottLogic/d3-financial-components.git","svn_url":"https://github.com/ScottLogic/d3-financial-components","homepage":"","size":2000,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":43,"forks":5,"open_issues":43,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ScottLogic/d3-financial-components/pulls/70"},"html":{"href":"https://github.com/ScottLogic/d3-financial-components/pull/70"},"issue":{"href":"https://api.github.com/repos/ScottLogic/d3-financial-components/issues/70"},"comments":{"href":"https://api.github.com/repos/ScottLogic/d3-financial-components/issues/70/comments"},"review_comments":{"href":"https://api.github.com/repos/ScottLogic/d3-financial-components/pulls/70/comments"},"review_comment":{"href":"https://api.github.com/repos/ScottLogic/d3-financial-components/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ScottLogic/d3-financial-components/pulls/70/commits"},"statuses":{"href":"https://api.github.com/repos/ScottLogic/d3-financial-components/statuses/a5310dd8a80ffa14383ba6dbd81699ddf0941b17"}}}}