GitHub PullRequestEvent at 2014-05-30 13:15:29
Repository: lmms
Actor: tobydox
Payload: {"action":"closed","number":778,"pull_request":{"url":"https://api.github.com/repos/LMMS/lmms/pulls/778","id":16404641,"html_url":"https://github.com/LMMS/lmms/pull/778","diff_url":"https://github.com/LMMS/lmms/pull/778.diff","patch_url":"https://github.com/LMMS/lmms/pull/778.patch","issue_url":"https://api.github.com/repos/LMMS/lmms/issues/778","number":778,"state":"closed","title":"PianoRoll: Note Quick Resize","user":{"login":"diizy","id":6368868,"avatar_url":"https://avatars.githubusercontent.com/u/6368868?","gravatar_id":"78b8cb9dd8648a43225c809012bc9837","url":"https://api.github.com/users/diizy","html_url":"https://github.com/diizy","followers_url":"https://api.github.com/users/diizy/followers","following_url":"https://api.github.com/users/diizy/following{/other_user}","gists_url":"https://api.github.com/users/diizy/gists{/gist_id}","starred_url":"https://api.github.com/users/diizy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diizy/subscriptions","organizations_url":"https://api.github.com/users/diizy/orgs","repos_url":"https://api.github.com/users/diizy/repos","events_url":"https://api.github.com/users/diizy/events{/privacy}","received_events_url":"https://api.github.com/users/diizy/received_events","type":"User","site_admin":false},"body":"Basically, this works as such:\r\n- if you click shift *after* starting a note move OR after creating a new note, the note move action is switched into resize mode, so you can quickly resize the note you just created, or the note you just moved. This saves time and improves workflow - at least based on my own experience: I've always wished I could do this, this is a huge time saving when you want to quickly jot down notes of differing lengths.\r\n- if shift is already pressed when you click, the above will not happen, because that would mess with the note copy function. Copying notes with shift-dragging works the same as before.\r\n- note test playback is halted when you click shift while moving. This is purely because it was causing some crackling noise, probably because of the changing length of a note that is currently playing. Maybe that can be fixed later, although it's arguably better not to hear the note while resizing - it's consistent with the other resize.\r\n- works on group of notes as well, if you start moving a group of notes and then click shift, it will go into resize. Exception is notes copied with shift-drag... for obvious reasons.\r\n- that should be all. Testing appreciated.","created_at":"2014-05-28T00:48:44Z","updated_at":"2014-05-30T13:15:28Z","closed_at":"2014-05-30T13:15:28Z","merged_at":"2014-05-30T13:15:28Z","merge_commit_sha":"29793d7209a6d3090a8b3b27d18a3648154b5f14","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/LMMS/lmms/pulls/778/commits","review_comments_url":"https://api.github.com/repos/LMMS/lmms/pulls/778/comments","review_comment_url":"https://api.github.com/repos/LMMS/lmms/pulls/comments/{number}","comments_url":"https://api.github.com/repos/LMMS/lmms/issues/778/comments","statuses_url":"https://api.github.com/repos/LMMS/lmms/statuses/adea08d5b936030de47d8d74359ed667fadd610e","head":{"label":"diizy:pianoroll","ref":"pianoroll","sha":"adea08d5b936030de47d8d74359ed667fadd610e","user":{"login":"diizy","id":6368868,"avatar_url":"https://avatars.githubusercontent.com/u/6368868?","gravatar_id":"78b8cb9dd8648a43225c809012bc9837","url":"https://api.github.com/users/diizy","html_url":"https://github.com/diizy","followers_url":"https://api.github.com/users/diizy/followers","following_url":"https://api.github.com/users/diizy/following{/other_user}","gists_url":"https://api.github.com/users/diizy/gists{/gist_id}","starred_url":"https://api.github.com/users/diizy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diizy/subscriptions","organizations_url":"https://api.github.com/users/diizy/orgs","repos_url":"https://api.github.com/users/diizy/repos","events_url":"https://api.github.com/users/diizy/events{/privacy}","received_events_url":"https://api.github.com/users/diizy/received_events","type":"User","site_admin":false},"repo":{"id":15815002,"name":"lmms","full_name":"diizy/lmms","owner":{"login":"diizy","id":6368868,"avatar_url":"https://avatars.githubusercontent.com/u/6368868?","gravatar_id":"78b8cb9dd8648a43225c809012bc9837","url":"https://api.github.com/users/diizy","html_url":"https://github.com/diizy","followers_url":"https://api.github.com/users/diizy/followers","following_url":"https://api.github.com/users/diizy/following{/other_user}","gists_url":"https://api.github.com/users/diizy/gists{/gist_id}","starred_url":"https://api.github.com/users/diizy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diizy/subscriptions","organizations_url":"https://api.github.com/users/diizy/orgs","repos_url":"https://api.github.com/users/diizy/repos","events_url":"https://api.github.com/users/diizy/events{/privacy}","received_events_url":"https://api.github.com/users/diizy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/diizy/lmms","description":"","fork":true,"url":"https://api.github.com/repos/diizy/lmms","forks_url":"https://api.github.com/repos/diizy/lmms/forks","keys_url":"https://api.github.com/repos/diizy/lmms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/diizy/lmms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/diizy/lmms/teams","hooks_url":"https://api.github.com/repos/diizy/lmms/hooks","issue_events_url":"https://api.github.com/repos/diizy/lmms/issues/events{/number}","events_url":"https://api.github.com/repos/diizy/lmms/events","assignees_url":"https://api.github.com/repos/diizy/lmms/assignees{/user}","branches_url":"https://api.github.com/repos/diizy/lmms/branches{/branch}","tags_url":"https://api.github.com/repos/diizy/lmms/tags","blobs_url":"https://api.github.com/repos/diizy/lmms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/diizy/lmms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/diizy/lmms/git/refs{/sha}","trees_url":"https://api.github.com/repos/diizy/lmms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/diizy/lmms/statuses/{sha}","languages_url":"https://api.github.com/repos/diizy/lmms/languages","stargazers_url":"https://api.github.com/repos/diizy/lmms/stargazers","contributors_url":"https://api.github.com/repos/diizy/lmms/contributors","subscribers_url":"https://api.github.com/repos/diizy/lmms/subscribers","subscription_url":"https://api.github.com/repos/diizy/lmms/subscription","commits_url":"https://api.github.com/repos/diizy/lmms/commits{/sha}","git_commits_url":"https://api.github.com/repos/diizy/lmms/git/commits{/sha}","comments_url":"https://api.github.com/repos/diizy/lmms/comments{/number}","issue_comment_url":"https://api.github.com/repos/diizy/lmms/issues/comments/{number}","contents_url":"https://api.github.com/repos/diizy/lmms/contents/{+path}","compare_url":"https://api.github.com/repos/diizy/lmms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/diizy/lmms/merges","archive_url":"https://api.github.com/repos/diizy/lmms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/diizy/lmms/downloads","issues_url":"https://api.github.com/repos/diizy/lmms/issues{/number}","pulls_url":"https://api.github.com/repos/diizy/lmms/pulls{/number}","milestones_url":"https://api.github.com/repos/diizy/lmms/milestones{/number}","notifications_url":"https://api.github.com/repos/diizy/lmms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/diizy/lmms/labels{/name}","releases_url":"https://api.github.com/repos/diizy/lmms/releases{/id}","created_at":"2014-01-11T01:58:53Z","updated_at":"2014-05-30T13:15:28Z","pushed_at":"2014-05-30T05:20:22Z","git_url":"git://github.com/diizy/lmms.git","ssh_url":"git@github.com:diizy/lmms.git","clone_url":"https://github.com/diizy/lmms.git","svn_url":"https://github.com/diizy/lmms","homepage":null,"size":49968,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":1,"default_branch":"stable-0.4"}},"base":{"label":"LMMS:master","ref":"master","sha":"957aed4b80d80644d661d90cac2eb1e8ec3a1bad","user":{"login":"LMMS","id":6363159,"avatar_url":"https://avatars.githubusercontent.com/u/6363159?","gravatar_id":"5aa6ee6f2082e03ce426571f78d00e27","url":"https://api.github.com/users/LMMS","html_url":"https://github.com/LMMS","followers_url":"https://api.github.com/users/LMMS/followers","following_url":"https://api.github.com/users/LMMS/following{/other_user}","gists_url":"https://api.github.com/users/LMMS/gists{/gist_id}","starred_url":"https://api.github.com/users/LMMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LMMS/subscriptions","organizations_url":"https://api.github.com/users/LMMS/orgs","repos_url":"https://api.github.com/users/LMMS/repos","events_url":"https://api.github.com/users/LMMS/events{/privacy}","received_events_url":"https://api.github.com/users/LMMS/received_events","type":"Organization","site_admin":false},"repo":{"id":15778896,"name":"lmms","full_name":"LMMS/lmms","owner":{"login":"LMMS","id":6363159,"avatar_url":"https://avatars.githubusercontent.com/u/6363159?","gravatar_id":"5aa6ee6f2082e03ce426571f78d00e27","url":"https://api.github.com/users/LMMS","html_url":"https://github.com/LMMS","followers_url":"https://api.github.com/users/LMMS/followers","following_url":"https://api.github.com/users/LMMS/following{/other_user}","gists_url":"https://api.github.com/users/LMMS/gists{/gist_id}","starred_url":"https://api.github.com/users/LMMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LMMS/subscriptions","organizations_url":"https://api.github.com/users/LMMS/orgs","repos_url":"https://api.github.com/users/LMMS/repos","events_url":"https://api.github.com/users/LMMS/events{/privacy}","received_events_url":"https://api.github.com/users/LMMS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LMMS/lmms","description":"cross-platform music production software","fork":false,"url":"https://api.github.com/repos/LMMS/lmms","forks_url":"https://api.github.com/repos/LMMS/lmms/forks","keys_url":"https://api.github.com/repos/LMMS/lmms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LMMS/lmms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LMMS/lmms/teams","hooks_url":"https://api.github.com/repos/LMMS/lmms/hooks","issue_events_url":"https://api.github.com/repos/LMMS/lmms/issues/events{/number}","events_url":"https://api.github.com/repos/LMMS/lmms/events","assignees_url":"https://api.github.com/repos/LMMS/lmms/assignees{/user}","branches_url":"https://api.github.com/repos/LMMS/lmms/branches{/branch}","tags_url":"https://api.github.com/repos/LMMS/lmms/tags","blobs_url":"https://api.github.com/repos/LMMS/lmms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LMMS/lmms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LMMS/lmms/git/refs{/sha}","trees_url":"https://api.github.com/repos/LMMS/lmms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LMMS/lmms/statuses/{sha}","languages_url":"https://api.github.com/repos/LMMS/lmms/languages","stargazers_url":"https://api.github.com/repos/LMMS/lmms/stargazers","contributors_url":"https://api.github.com/repos/LMMS/lmms/contributors","subscribers_url":"https://api.github.com/repos/LMMS/lmms/subscribers","subscription_url":"https://api.github.com/repos/LMMS/lmms/subscription","commits_url":"https://api.github.com/repos/LMMS/lmms/commits{/sha}","git_commits_url":"https://api.github.com/repos/LMMS/lmms/git/commits{/sha}","comments_url":"https://api.github.com/repos/LMMS/lmms/comments{/number}","issue_comment_url":"https://api.github.com/repos/LMMS/lmms/issues/comments/{number}","contents_url":"https://api.github.com/repos/LMMS/lmms/contents/{+path}","compare_url":"https://api.github.com/repos/LMMS/lmms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LMMS/lmms/merges","archive_url":"https://api.github.com/repos/LMMS/lmms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LMMS/lmms/downloads","issues_url":"https://api.github.com/repos/LMMS/lmms/issues{/number}","pulls_url":"https://api.github.com/repos/LMMS/lmms/pulls{/number}","milestones_url":"https://api.github.com/repos/LMMS/lmms/milestones{/number}","notifications_url":"https://api.github.com/repos/LMMS/lmms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LMMS/lmms/labels{/name}","releases_url":"https://api.github.com/repos/LMMS/lmms/releases{/id}","created_at":"2014-01-09T20:43:43Z","updated_at":"2014-05-30T13:15:28Z","pushed_at":"2014-05-30T13:15:28Z","git_url":"git://github.com/LMMS/lmms.git","ssh_url":"git@github.com:LMMS/lmms.git","clone_url":"https://github.com/LMMS/lmms.git","svn_url":"https://github.com/LMMS/lmms","homepage":"http://lmms.sourceforge.net/","size":61037,"stargazers_count":82,"watchers_count":82,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":51,"mirror_url":null,"open_issues_count":245,"forks":51,"open_issues":245,"watchers":82,"default_branch":"stable-1.0"}},"_links":{"self":{"href":"https://api.github.com/repos/LMMS/lmms/pulls/778"},"html":{"href":"https://github.com/LMMS/lmms/pull/778"},"issue":{"href":"https://api.github.com/repos/LMMS/lmms/issues/778"},"comments":{"href":"https://api.github.com/repos/LMMS/lmms/issues/778/comments"},"review_comments":{"href":"https://api.github.com/repos/LMMS/lmms/pulls/778/comments"},"review_comment":{"href":"https://api.github.com/repos/LMMS/lmms/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/LMMS/lmms/pulls/778/commits"},"statuses":{"href":"https://api.github.com/repos/LMMS/lmms/statuses/adea08d5b936030de47d8d74359ed667fadd610e"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"tobydox","id":3300739,"avatar_url":"https://avatars.githubusercontent.com/u/3300739?","gravatar_id":"1a4bf211dba5b959f1b20eeed8dacaf3","url":"https://api.github.com/users/tobydox","html_url":"https://github.com/tobydox","followers_url":"https://api.github.com/users/tobydox/followers","following_url":"https://api.github.com/users/tobydox/following{/other_user}","gists_url":"https://api.github.com/users/tobydox/gists{/gist_id}","starred_url":"https://api.github.com/users/tobydox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobydox/subscriptions","organizations_url":"https://api.github.com/users/tobydox/orgs","repos_url":"https://api.github.com/users/tobydox/repos","events_url":"https://api.github.com/users/tobydox/events{/privacy}","received_events_url":"https://api.github.com/users/tobydox/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":20,"deletions":4,"changed_files":2}}