GitHub PullRequestReviewCommentEvent at 2014-10-21 10:21:46
Repository: fluentd
Actor: repeatedly
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/fluent/fluentd/pulls/comments/19139714","id":19139714,"diff_hunk":"@@ -45,6 +45,16 @@ class TestSection < ::Test::Unit::TestCase\n           end\n         end\n \n+        sub_test_case '#object_id' do\n+          test 'returns its object id' do\n+            s1 = Fluent::Config::Section.new({})\n+            assert s1.object_id.is_a?(Fixnum)","path":"test/config/test_section.rb","position":7,"original_position":7,"commit_id":"a4d128a2fc43b36a0187e5cad6c0822b9769670d","original_commit_id":"a4d128a2fc43b36a0187e5cad6c0822b9769670d","user":{"login":"repeatedly","id":16928,"avatar_url":"https://avatars.githubusercontent.com/u/16928?v=2","gravatar_id":"","url":"https://api.github.com/users/repeatedly","html_url":"https://github.com/repeatedly","followers_url":"https://api.github.com/users/repeatedly/followers","following_url":"https://api.github.com/users/repeatedly/following{/other_user}","gists_url":"https://api.github.com/users/repeatedly/gists{/gist_id}","starred_url":"https://api.github.com/users/repeatedly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/repeatedly/subscriptions","organizations_url":"https://api.github.com/users/repeatedly/orgs","repos_url":"https://api.github.com/users/repeatedly/repos","events_url":"https://api.github.com/users/repeatedly/events{/privacy}","received_events_url":"https://api.github.com/users/repeatedly/received_events","type":"User","site_admin":false},"body":"Fluentd should not care actual `__id__` implementation.\r\nHow about using `Object.new.object_id.class` instead?","created_at":"2014-10-21T10:21:46Z","updated_at":"2014-10-21T10:21:46Z","html_url":"https://github.com/fluent/fluentd/pull/460#discussion_r19139714","pull_request_url":"https://api.github.com/repos/fluent/fluentd/pulls/460","_links":{"self":{"href":"https://api.github.com/repos/fluent/fluentd/pulls/comments/19139714"},"html":{"href":"https://github.com/fluent/fluentd/pull/460#discussion_r19139714"},"pull_request":{"href":"https://api.github.com/repos/fluent/fluentd/pulls/460"}}},"pull_request":{"url":"https://api.github.com/repos/fluent/fluentd/pulls/460","id":23067271,"html_url":"https://github.com/fluent/fluentd/pull/460","diff_url":"https://github.com/fluent/fluentd/pull/460.diff","patch_url":"https://github.com/fluent/fluentd/pull/460.patch","issue_url":"https://api.github.com/repos/fluent/fluentd/issues/460","number":460,"state":"open","locked":false,"title":"add Fluent::Config::Section#object_id","user":{"login":"tagomoris","id":230654,"avatar_url":"https://avatars.githubusercontent.com/u/230654?v=2","gravatar_id":"","url":"https://api.github.com/users/tagomoris","html_url":"https://github.com/tagomoris","followers_url":"https://api.github.com/users/tagomoris/followers","following_url":"https://api.github.com/users/tagomoris/following{/other_user}","gists_url":"https://api.github.com/users/tagomoris/gists{/gist_id}","starred_url":"https://api.github.com/users/tagomoris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tagomoris/subscriptions","organizations_url":"https://api.github.com/users/tagomoris/orgs","repos_url":"https://api.github.com/users/tagomoris/repos","events_url":"https://api.github.com/users/tagomoris/events{/privacy}","received_events_url":"https://api.github.com/users/tagomoris/received_events","type":"User","site_admin":false},"body":"Not to raise NoMethodError by pp or other object dump tools in runtime\r\n(logger or other inspection tools may touch this danger spot)","created_at":"2014-10-21T07:38:16Z","updated_at":"2014-10-21T10:21:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3c08e8c6d33591834cc67ccc7eaa6968aff21bfe","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/fluent/fluentd/pulls/460/commits","review_comments_url":"https://api.github.com/repos/fluent/fluentd/pulls/460/comments","review_comment_url":"https://api.github.com/repos/fluent/fluentd/pulls/comments/{number}","comments_url":"https://api.github.com/repos/fluent/fluentd/issues/460/comments","statuses_url":"https://api.github.com/repos/fluent/fluentd/statuses/a4d128a2fc43b36a0187e5cad6c0822b9769670d","head":{"label":"tagomoris:config-section_object_id","ref":"config-section_object_id","sha":"a4d128a2fc43b36a0187e5cad6c0822b9769670d","user":{"login":"tagomoris","id":230654,"avatar_url":"https://avatars.githubusercontent.com/u/230654?v=2","gravatar_id":"","url":"https://api.github.com/users/tagomoris","html_url":"https://github.com/tagomoris","followers_url":"https://api.github.com/users/tagomoris/followers","following_url":"https://api.github.com/users/tagomoris/following{/other_user}","gists_url":"https://api.github.com/users/tagomoris/gists{/gist_id}","starred_url":"https://api.github.com/users/tagomoris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tagomoris/subscriptions","organizations_url":"https://api.github.com/users/tagomoris/orgs","repos_url":"https://api.github.com/users/tagomoris/repos","events_url":"https://api.github.com/users/tagomoris/events{/privacy}","received_events_url":"https://api.github.com/users/tagomoris/received_events","type":"User","site_admin":false},"repo":{"id":2864618,"name":"fluentd","full_name":"tagomoris/fluentd","owner":{"login":"tagomoris","id":230654,"avatar_url":"https://avatars.githubusercontent.com/u/230654?v=2","gravatar_id":"","url":"https://api.github.com/users/tagomoris","html_url":"https://github.com/tagomoris","followers_url":"https://api.github.com/users/tagomoris/followers","following_url":"https://api.github.com/users/tagomoris/following{/other_user}","gists_url":"https://api.github.com/users/tagomoris/gists{/gist_id}","starred_url":"https://api.github.com/users/tagomoris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tagomoris/subscriptions","organizations_url":"https://api.github.com/users/tagomoris/orgs","repos_url":"https://api.github.com/users/tagomoris/repos","events_url":"https://api.github.com/users/tagomoris/events{/privacy}","received_events_url":"https://api.github.com/users/tagomoris/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tagomoris/fluentd","description":"Fluentd event collector","fork":true,"url":"https://api.github.com/repos/tagomoris/fluentd","forks_url":"https://api.github.com/repos/tagomoris/fluentd/forks","keys_url":"https://api.github.com/repos/tagomoris/fluentd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tagomoris/fluentd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tagomoris/fluentd/teams","hooks_url":"https://api.github.com/repos/tagomoris/fluentd/hooks","issue_events_url":"https://api.github.com/repos/tagomoris/fluentd/issues/events{/number}","events_url":"https://api.github.com/repos/tagomoris/fluentd/events","assignees_url":"https://api.github.com/repos/tagomoris/fluentd/assignees{/user}","branches_url":"https://api.github.com/repos/tagomoris/fluentd/branches{/branch}","tags_url":"https://api.github.com/repos/tagomoris/fluentd/tags","blobs_url":"https://api.github.com/repos/tagomoris/fluentd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tagomoris/fluentd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tagomoris/fluentd/git/refs{/sha}","trees_url":"https://api.github.com/repos/tagomoris/fluentd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tagomoris/fluentd/statuses/{sha}","languages_url":"https://api.github.com/repos/tagomoris/fluentd/languages","stargazers_url":"https://api.github.com/repos/tagomoris/fluentd/stargazers","contributors_url":"https://api.github.com/repos/tagomoris/fluentd/contributors","subscribers_url":"https://api.github.com/repos/tagomoris/fluentd/subscribers","subscription_url":"https://api.github.com/repos/tagomoris/fluentd/subscription","commits_url":"https://api.github.com/repos/tagomoris/fluentd/commits{/sha}","git_commits_url":"https://api.github.com/repos/tagomoris/fluentd/git/commits{/sha}","comments_url":"https://api.github.com/repos/tagomoris/fluentd/comments{/number}","issue_comment_url":"https://api.github.com/repos/tagomoris/fluentd/issues/comments/{number}","contents_url":"https://api.github.com/repos/tagomoris/fluentd/contents/{+path}","compare_url":"https://api.github.com/repos/tagomoris/fluentd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tagomoris/fluentd/merges","archive_url":"https://api.github.com/repos/tagomoris/fluentd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tagomoris/fluentd/downloads","issues_url":"https://api.github.com/repos/tagomoris/fluentd/issues{/number}","pulls_url":"https://api.github.com/repos/tagomoris/fluentd/pulls{/number}","milestones_url":"https://api.github.com/repos/tagomoris/fluentd/milestones{/number}","notifications_url":"https://api.github.com/repos/tagomoris/fluentd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tagomoris/fluentd/labels{/name}","releases_url":"https://api.github.com/repos/tagomoris/fluentd/releases{/id}","created_at":"2011-11-28T03:35:41Z","updated_at":"2014-06-27T09:43:21Z","pushed_at":"2014-10-21T10:10:21Z","git_url":"git://github.com/tagomoris/fluentd.git","ssh_url":"git@github.com:tagomoris/fluentd.git","clone_url":"https://github.com/tagomoris/fluentd.git","svn_url":"https://github.com/tagomoris/fluentd","homepage":"http://fluentd.org/","size":2592,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"fluent:master","ref":"master","sha":"6068b5e89358466bce4e96c8b176511ed8f368af","user":{"login":"fluent","id":859518,"avatar_url":"https://avatars.githubusercontent.com/u/859518?v=2","gravatar_id":"","url":"https://api.github.com/users/fluent","html_url":"https://github.com/fluent","followers_url":"https://api.github.com/users/fluent/followers","following_url":"https://api.github.com/users/fluent/following{/other_user}","gists_url":"https://api.github.com/users/fluent/gists{/gist_id}","starred_url":"https://api.github.com/users/fluent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fluent/subscriptions","organizations_url":"https://api.github.com/users/fluent/orgs","repos_url":"https://api.github.com/users/fluent/repos","events_url":"https://api.github.com/users/fluent/events{/privacy}","received_events_url":"https://api.github.com/users/fluent/received_events","type":"Organization","site_admin":false},"repo":{"id":1918677,"name":"fluentd","full_name":"fluent/fluentd","owner":{"login":"fluent","id":859518,"avatar_url":"https://avatars.githubusercontent.com/u/859518?v=2","gravatar_id":"","url":"https://api.github.com/users/fluent","html_url":"https://github.com/fluent","followers_url":"https://api.github.com/users/fluent/followers","following_url":"https://api.github.com/users/fluent/following{/other_user}","gists_url":"https://api.github.com/users/fluent/gists{/gist_id}","starred_url":"https://api.github.com/users/fluent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fluent/subscriptions","organizations_url":"https://api.github.com/users/fluent/orgs","repos_url":"https://api.github.com/users/fluent/repos","events_url":"https://api.github.com/users/fluent/events{/privacy}","received_events_url":"https://api.github.com/users/fluent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fluent/fluentd","description":"Fluentd data collector","fork":false,"url":"https://api.github.com/repos/fluent/fluentd","forks_url":"https://api.github.com/repos/fluent/fluentd/forks","keys_url":"https://api.github.com/repos/fluent/fluentd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fluent/fluentd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fluent/fluentd/teams","hooks_url":"https://api.github.com/repos/fluent/fluentd/hooks","issue_events_url":"https://api.github.com/repos/fluent/fluentd/issues/events{/number}","events_url":"https://api.github.com/repos/fluent/fluentd/events","assignees_url":"https://api.github.com/repos/fluent/fluentd/assignees{/user}","branches_url":"https://api.github.com/repos/fluent/fluentd/branches{/branch}","tags_url":"https://api.github.com/repos/fluent/fluentd/tags","blobs_url":"https://api.github.com/repos/fluent/fluentd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fluent/fluentd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fluent/fluentd/git/refs{/sha}","trees_url":"https://api.github.com/repos/fluent/fluentd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fluent/fluentd/statuses/{sha}","languages_url":"https://api.github.com/repos/fluent/fluentd/languages","stargazers_url":"https://api.github.com/repos/fluent/fluentd/stargazers","contributors_url":"https://api.github.com/repos/fluent/fluentd/contributors","subscribers_url":"https://api.github.com/repos/fluent/fluentd/subscribers","subscription_url":"https://api.github.com/repos/fluent/fluentd/subscription","commits_url":"https://api.github.com/repos/fluent/fluentd/commits{/sha}","git_commits_url":"https://api.github.com/repos/fluent/fluentd/git/commits{/sha}","comments_url":"https://api.github.com/repos/fluent/fluentd/comments{/number}","issue_comment_url":"https://api.github.com/repos/fluent/fluentd/issues/comments/{number}","contents_url":"https://api.github.com/repos/fluent/fluentd/contents/{+path}","compare_url":"https://api.github.com/repos/fluent/fluentd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fluent/fluentd/merges","archive_url":"https://api.github.com/repos/fluent/fluentd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fluent/fluentd/downloads","issues_url":"https://api.github.com/repos/fluent/fluentd/issues{/number}","pulls_url":"https://api.github.com/repos/fluent/fluentd/pulls{/number}","milestones_url":"https://api.github.com/repos/fluent/fluentd/milestones{/number}","notifications_url":"https://api.github.com/repos/fluent/fluentd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fluent/fluentd/labels{/name}","releases_url":"https://api.github.com/repos/fluent/fluentd/releases{/id}","created_at":"2011-06-19T08:41:40Z","updated_at":"2014-10-21T09:47:19Z","pushed_at":"2014-10-21T10:04:36Z","git_url":"git://github.com/fluent/fluentd.git","ssh_url":"git@github.com:fluent/fluentd.git","clone_url":"https://github.com/fluent/fluentd.git","svn_url":"https://github.com/fluent/fluentd","homepage":"http://www.fluentd.org/","size":16158,"stargazers_count":2352,"watchers_count":2352,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":273,"mirror_url":null,"open_issues_count":30,"forks":273,"open_issues":30,"watchers":2352,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fluent/fluentd/pulls/460"},"html":{"href":"https://github.com/fluent/fluentd/pull/460"},"issue":{"href":"https://api.github.com/repos/fluent/fluentd/issues/460"},"comments":{"href":"https://api.github.com/repos/fluent/fluentd/issues/460/comments"},"review_comments":{"href":"https://api.github.com/repos/fluent/fluentd/pulls/460/comments"},"review_comment":{"href":"https://api.github.com/repos/fluent/fluentd/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/fluent/fluentd/pulls/460/commits"},"statuses":{"href":"https://api.github.com/repos/fluent/fluentd/statuses/a4d128a2fc43b36a0187e5cad6c0822b9769670d"}}}}