GitHub PullRequestReviewCommentEvent at 2014-06-27 02:54:30
Repository: cocos2d-x
Actor: minggo
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/comments/14278012","id":14278012,"diff_hunk":"@@ -72,24 +81,42 @@ class Bone : public Ref\n     /**\n      * Sets the inverse bind pose matrix.\n      *\n-     * @param m C3DMatrix representing the inverse bind pose for this Bone.\n+     * @param m Mat4 representing the inverse bind pose for this Bone.\n      */\n     void setInverseBindPose(const Mat4& m);\n     \n     /**\n+     * Sets the bone's original pose.\n+     *\n+     * @param m Mat4 representing the original pose for this Bone.\n+     */\n+    void setOriPose(const Mat4& m);","path":"cocos/3d/CCMeshSkin.h","position":45,"original_position":45,"commit_id":"392a769c8f3072e271d71616e1338944dde0b560","original_commit_id":"392a769c8f3072e271d71616e1338944dde0b560","user":{"login":"minggo","id":488203,"avatar_url":"https://avatars.githubusercontent.com/u/488203?","gravatar_id":"69efdc94ffdebdd556c3826b6f1afe8f","url":"https://api.github.com/users/minggo","html_url":"https://github.com/minggo","followers_url":"https://api.github.com/users/minggo/followers","following_url":"https://api.github.com/users/minggo/following{/other_user}","gists_url":"https://api.github.com/users/minggo/gists{/gist_id}","starred_url":"https://api.github.com/users/minggo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minggo/subscriptions","organizations_url":"https://api.github.com/users/minggo/orgs","repos_url":"https://api.github.com/users/minggo/repos","events_url":"https://api.github.com/users/minggo/events{/privacy}","received_events_url":"https://api.github.com/users/minggo/received_events","type":"User","site_admin":false},"body":"Is it a common way to use `Ori` short of `Original`?","created_at":"2014-06-27T02:54:30Z","updated_at":"2014-06-27T02:54:30Z","html_url":"https://github.com/cocos2d/cocos2d-x/pull/7226#discussion_r14278012","pull_request_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/7226","_links":{"self":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/comments/14278012"},"html":{"href":"https://github.com/cocos2d/cocos2d-x/pull/7226#discussion_r14278012"},"pull_request":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/7226"}}},"pull_request":{"url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/7226","id":17653125,"html_url":"https://github.com/cocos2d/cocos2d-x/pull/7226","diff_url":"https://github.com/cocos2d/cocos2d-x/pull/7226.diff","patch_url":"https://github.com/cocos2d/cocos2d-x/pull/7226.patch","issue_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/7226","number":7226,"state":"open","title":"Animation3D","user":{"login":"super626","id":4159090,"avatar_url":"https://avatars.githubusercontent.com/u/4159090?","gravatar_id":"5525ee036d8c31640aea67a33e8eb70e","url":"https://api.github.com/users/super626","html_url":"https://github.com/super626","followers_url":"https://api.github.com/users/super626/followers","following_url":"https://api.github.com/users/super626/following{/other_user}","gists_url":"https://api.github.com/users/super626/gists{/gist_id}","starred_url":"https://api.github.com/users/super626/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/super626/subscriptions","organizations_url":"https://api.github.com/users/super626/orgs","repos_url":"https://api.github.com/users/super626/repos","events_url":"https://api.github.com/users/super626/events{/privacy}","received_events_url":"https://api.github.com/users/super626/received_events","type":"User","site_admin":false},"body":"We are keeping on testing this, so just comment it.\r\n\r\nc3b support\r\nimprove performance. shader simplify, use VAO and batch draw\r\nanimation3d fix, load original pose, transform bugs on bones without skin.\r\nmore test on animate3d, we are keeping on update this.","created_at":"2014-06-26T15:01:32Z","updated_at":"2014-06-27T02:54:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f96dde2e7b7a0c5861ce8b925c16215ffcf521d0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/7226/commits","review_comments_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/7226/comments","review_comment_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/comments/{number}","comments_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/7226/comments","statuses_url":"https://api.github.com/repos/cocos2d/cocos2d-x/statuses/392a769c8f3072e271d71616e1338944dde0b560","head":{"label":"super626:v3","ref":"v3","sha":"392a769c8f3072e271d71616e1338944dde0b560","user":{"login":"super626","id":4159090,"avatar_url":"https://avatars.githubusercontent.com/u/4159090?","gravatar_id":"5525ee036d8c31640aea67a33e8eb70e","url":"https://api.github.com/users/super626","html_url":"https://github.com/super626","followers_url":"https://api.github.com/users/super626/followers","following_url":"https://api.github.com/users/super626/following{/other_user}","gists_url":"https://api.github.com/users/super626/gists{/gist_id}","starred_url":"https://api.github.com/users/super626/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/super626/subscriptions","organizations_url":"https://api.github.com/users/super626/orgs","repos_url":"https://api.github.com/users/super626/repos","events_url":"https://api.github.com/users/super626/events{/privacy}","received_events_url":"https://api.github.com/users/super626/received_events","type":"User","site_admin":false},"repo":{"id":18664943,"name":"cocos2d-x","full_name":"super626/cocos2d-x","owner":{"login":"super626","id":4159090,"avatar_url":"https://avatars.githubusercontent.com/u/4159090?","gravatar_id":"5525ee036d8c31640aea67a33e8eb70e","url":"https://api.github.com/users/super626","html_url":"https://github.com/super626","followers_url":"https://api.github.com/users/super626/followers","following_url":"https://api.github.com/users/super626/following{/other_user}","gists_url":"https://api.github.com/users/super626/gists{/gist_id}","starred_url":"https://api.github.com/users/super626/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/super626/subscriptions","organizations_url":"https://api.github.com/users/super626/orgs","repos_url":"https://api.github.com/users/super626/repos","events_url":"https://api.github.com/users/super626/events{/privacy}","received_events_url":"https://api.github.com/users/super626/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/super626/cocos2d-x","description":"cocos2d-x for C++","fork":true,"url":"https://api.github.com/repos/super626/cocos2d-x","forks_url":"https://api.github.com/repos/super626/cocos2d-x/forks","keys_url":"https://api.github.com/repos/super626/cocos2d-x/keys{/key_id}","collaborators_url":"https://api.github.com/repos/super626/cocos2d-x/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/super626/cocos2d-x/teams","hooks_url":"https://api.github.com/repos/super626/cocos2d-x/hooks","issue_events_url":"https://api.github.com/repos/super626/cocos2d-x/issues/events{/number}","events_url":"https://api.github.com/repos/super626/cocos2d-x/events","assignees_url":"https://api.github.com/repos/super626/cocos2d-x/assignees{/user}","branches_url":"https://api.github.com/repos/super626/cocos2d-x/branches{/branch}","tags_url":"https://api.github.com/repos/super626/cocos2d-x/tags","blobs_url":"https://api.github.com/repos/super626/cocos2d-x/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/super626/cocos2d-x/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/super626/cocos2d-x/git/refs{/sha}","trees_url":"https://api.github.com/repos/super626/cocos2d-x/git/trees{/sha}","statuses_url":"https://api.github.com/repos/super626/cocos2d-x/statuses/{sha}","languages_url":"https://api.github.com/repos/super626/cocos2d-x/languages","stargazers_url":"https://api.github.com/repos/super626/cocos2d-x/stargazers","contributors_url":"https://api.github.com/repos/super626/cocos2d-x/contributors","subscribers_url":"https://api.github.com/repos/super626/cocos2d-x/subscribers","subscription_url":"https://api.github.com/repos/super626/cocos2d-x/subscription","commits_url":"https://api.github.com/repos/super626/cocos2d-x/commits{/sha}","git_commits_url":"https://api.github.com/repos/super626/cocos2d-x/git/commits{/sha}","comments_url":"https://api.github.com/repos/super626/cocos2d-x/comments{/number}","issue_comment_url":"https://api.github.com/repos/super626/cocos2d-x/issues/comments/{number}","contents_url":"https://api.github.com/repos/super626/cocos2d-x/contents/{+path}","compare_url":"https://api.github.com/repos/super626/cocos2d-x/compare/{base}...{head}","merges_url":"https://api.github.com/repos/super626/cocos2d-x/merges","archive_url":"https://api.github.com/repos/super626/cocos2d-x/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/super626/cocos2d-x/downloads","issues_url":"https://api.github.com/repos/super626/cocos2d-x/issues{/number}","pulls_url":"https://api.github.com/repos/super626/cocos2d-x/pulls{/number}","milestones_url":"https://api.github.com/repos/super626/cocos2d-x/milestones{/number}","notifications_url":"https://api.github.com/repos/super626/cocos2d-x/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/super626/cocos2d-x/labels{/name}","releases_url":"https://api.github.com/repos/super626/cocos2d-x/releases{/id}","created_at":"2014-04-11T06:39:38Z","updated_at":"2014-06-26T10:35:41Z","pushed_at":"2014-06-26T14:49:13Z","git_url":"git://github.com/super626/cocos2d-x.git","ssh_url":"git@github.com:super626/cocos2d-x.git","clone_url":"https://github.com/super626/cocos2d-x.git","svn_url":"https://github.com/super626/cocos2d-x","homepage":"http://www.cocos2d-x.org","size":755704,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":0,"default_branch":"v3"}},"base":{"label":"cocos2d:v3","ref":"v3","sha":"6b8fded0887b4ce8fff17b62eace058b6e3f842e","user":{"login":"cocos2d","id":234324,"avatar_url":"https://avatars.githubusercontent.com/u/234324?","gravatar_id":"2c474191a9930625c01a6752b40ebf72","url":"https://api.github.com/users/cocos2d","html_url":"https://github.com/cocos2d","followers_url":"https://api.github.com/users/cocos2d/followers","following_url":"https://api.github.com/users/cocos2d/following{/other_user}","gists_url":"https://api.github.com/users/cocos2d/gists{/gist_id}","starred_url":"https://api.github.com/users/cocos2d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocos2d/subscriptions","organizations_url":"https://api.github.com/users/cocos2d/orgs","repos_url":"https://api.github.com/users/cocos2d/repos","events_url":"https://api.github.com/users/cocos2d/events{/privacy}","received_events_url":"https://api.github.com/users/cocos2d/received_events","type":"Organization","site_admin":false},"repo":{"id":1093228,"name":"cocos2d-x","full_name":"cocos2d/cocos2d-x","owner":{"login":"cocos2d","id":234324,"avatar_url":"https://avatars.githubusercontent.com/u/234324?","gravatar_id":"2c474191a9930625c01a6752b40ebf72","url":"https://api.github.com/users/cocos2d","html_url":"https://github.com/cocos2d","followers_url":"https://api.github.com/users/cocos2d/followers","following_url":"https://api.github.com/users/cocos2d/following{/other_user}","gists_url":"https://api.github.com/users/cocos2d/gists{/gist_id}","starred_url":"https://api.github.com/users/cocos2d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocos2d/subscriptions","organizations_url":"https://api.github.com/users/cocos2d/orgs","repos_url":"https://api.github.com/users/cocos2d/repos","events_url":"https://api.github.com/users/cocos2d/events{/privacy}","received_events_url":"https://api.github.com/users/cocos2d/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cocos2d/cocos2d-x","description":"cocos2d-x for C++","fork":false,"url":"https://api.github.com/repos/cocos2d/cocos2d-x","forks_url":"https://api.github.com/repos/cocos2d/cocos2d-x/forks","keys_url":"https://api.github.com/repos/cocos2d/cocos2d-x/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cocos2d/cocos2d-x/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cocos2d/cocos2d-x/teams","hooks_url":"https://api.github.com/repos/cocos2d/cocos2d-x/hooks","issue_events_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/events{/number}","events_url":"https://api.github.com/repos/cocos2d/cocos2d-x/events","assignees_url":"https://api.github.com/repos/cocos2d/cocos2d-x/assignees{/user}","branches_url":"https://api.github.com/repos/cocos2d/cocos2d-x/branches{/branch}","tags_url":"https://api.github.com/repos/cocos2d/cocos2d-x/tags","blobs_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/refs{/sha}","trees_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cocos2d/cocos2d-x/statuses/{sha}","languages_url":"https://api.github.com/repos/cocos2d/cocos2d-x/languages","stargazers_url":"https://api.github.com/repos/cocos2d/cocos2d-x/stargazers","contributors_url":"https://api.github.com/repos/cocos2d/cocos2d-x/contributors","subscribers_url":"https://api.github.com/repos/cocos2d/cocos2d-x/subscribers","subscription_url":"https://api.github.com/repos/cocos2d/cocos2d-x/subscription","commits_url":"https://api.github.com/repos/cocos2d/cocos2d-x/commits{/sha}","git_commits_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/commits{/sha}","comments_url":"https://api.github.com/repos/cocos2d/cocos2d-x/comments{/number}","issue_comment_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/comments/{number}","contents_url":"https://api.github.com/repos/cocos2d/cocos2d-x/contents/{+path}","compare_url":"https://api.github.com/repos/cocos2d/cocos2d-x/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cocos2d/cocos2d-x/merges","archive_url":"https://api.github.com/repos/cocos2d/cocos2d-x/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cocos2d/cocos2d-x/downloads","issues_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues{/number}","pulls_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls{/number}","milestones_url":"https://api.github.com/repos/cocos2d/cocos2d-x/milestones{/number}","notifications_url":"https://api.github.com/repos/cocos2d/cocos2d-x/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cocos2d/cocos2d-x/labels{/name}","releases_url":"https://api.github.com/repos/cocos2d/cocos2d-x/releases{/id}","created_at":"2010-11-18T23:17:00Z","updated_at":"2014-06-27T02:11:17Z","pushed_at":"2014-06-26T14:59:21Z","git_url":"git://github.com/cocos2d/cocos2d-x.git","ssh_url":"git@github.com:cocos2d/cocos2d-x.git","clone_url":"https://github.com/cocos2d/cocos2d-x.git","svn_url":"https://github.com/cocos2d/cocos2d-x","homepage":"http://www.cocos2d-x.org","size":1142062,"stargazers_count":3784,"watchers_count":3784,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":2772,"mirror_url":null,"open_issues_count":149,"forks":2772,"open_issues":149,"watchers":3784,"default_branch":"v3"}},"_links":{"self":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/7226"},"html":{"href":"https://github.com/cocos2d/cocos2d-x/pull/7226"},"issue":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/7226"},"comments":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/7226/comments"},"review_comments":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/7226/comments"},"review_comment":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/7226/commits"},"statuses":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/statuses/392a769c8f3072e271d71616e1338944dde0b560"}}}}