GitHub PullRequestReviewCommentEvent at 2014-08-19 00:38:18
Repository: NJKScrollFullScreen
Actor: ninjinkun
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/ninjinkun/NJKScrollFullScreen/pulls/comments/16391191","id":16391191,"diff_hunk":"@@ -163,12 +175,12 @@ - (void)setTabBarOriginY:(CGFloat)y animated:(BOOL)animated\n     CGFloat toolBarHeight = frame.size.height;\n     CGSize viewSize = self.tabBarController.view.frame.size;\n     CGFloat viewHeight = UIInterfaceOrientationIsPortrait(self.interfaceOrientation) ? viewSize.height : viewSize.width;\n-\n+    ","path":"NJKScrollFullScreen/UIViewController+NJKFullScreenSupport.m","position":26,"original_position":26,"commit_id":"658e19e5f4316e3618dafb07383bfe3db7500fc0","original_commit_id":"658e19e5f4316e3618dafb07383bfe3db7500fc0","user":{"login":"ninjinkun","id":113420,"avatar_url":"https://avatars.githubusercontent.com/u/113420?v=2","gravatar_id":"6139fd48daa26e786794598c4a6b546a","url":"https://api.github.com/users/ninjinkun","html_url":"https://github.com/ninjinkun","followers_url":"https://api.github.com/users/ninjinkun/followers","following_url":"https://api.github.com/users/ninjinkun/following{/other_user}","gists_url":"https://api.github.com/users/ninjinkun/gists{/gist_id}","starred_url":"https://api.github.com/users/ninjinkun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ninjinkun/subscriptions","organizations_url":"https://api.github.com/users/ninjinkun/orgs","repos_url":"https://api.github.com/users/ninjinkun/repos","events_url":"https://api.github.com/users/ninjinkun/events{/privacy}","received_events_url":"https://api.github.com/users/ninjinkun/received_events","type":"User","site_admin":false},"body":"Please remove white spaces.","created_at":"2014-08-19T00:38:18Z","updated_at":"2014-08-19T00:38:18Z","html_url":"https://github.com/ninjinkun/NJKScrollFullScreen/pull/20#discussion_r16391191","pull_request_url":"https://api.github.com/repos/ninjinkun/NJKScrollFullScreen/pulls/20","_links":{"self":{"href":"https://api.github.com/repos/ninjinkun/NJKScrollFullScreen/pulls/comments/16391191"},"html":{"href":"https://github.com/ninjinkun/NJKScrollFullScreen/pull/20#discussion_r16391191"},"pull_request":{"href":"https://api.github.com/repos/ninjinkun/NJKScrollFullScreen/pulls/20"}}},"pull_request":{"url":"https://api.github.com/repos/ninjinkun/NJKScrollFullScreen/pulls/20","id":19924233,"html_url":"https://github.com/ninjinkun/NJKScrollFullScreen/pull/20","diff_url":"https://github.com/ninjinkun/NJKScrollFullScreen/pull/20.diff","patch_url":"https://github.com/ninjinkun/NJKScrollFullScreen/pull/20.patch","issue_url":"https://api.github.com/repos/ninjinkun/NJKScrollFullScreen/issues/20","number":20,"state":"open","locked":false,"title":"Fixed a problem when using `-showTabBar:` in iPad started in landscape mode","user":{"login":"TonnyXu","id":211446,"avatar_url":"https://avatars.githubusercontent.com/u/211446?v=2","gravatar_id":"ce4f2d1c999079a0d9f43e3300dc57c4","url":"https://api.github.com/users/TonnyXu","html_url":"https://github.com/TonnyXu","followers_url":"https://api.github.com/users/TonnyXu/followers","following_url":"https://api.github.com/users/TonnyXu/following{/other_user}","gists_url":"https://api.github.com/users/TonnyXu/gists{/gist_id}","starred_url":"https://api.github.com/users/TonnyXu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TonnyXu/subscriptions","organizations_url":"https://api.github.com/users/TonnyXu/orgs","repos_url":"https://api.github.com/users/TonnyXu/repos","events_url":"https://api.github.com/users/TonnyXu/events{/privacy}","received_events_url":"https://api.github.com/users/TonnyXu/received_events","type":"User","site_admin":false},"body":"Highly possibly it's a bug in UIKit that when you access the view from the TabBarController, you got a fixed view size discarded the orientation info.","created_at":"2014-08-18T15:18:00Z","updated_at":"2014-08-19T00:38:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"332559cf7a97ec401575741b649423542abb616c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ninjinkun/NJKScrollFullScreen/pulls/20/commits","review_comments_url":"https://api.github.com/repos/ninjinkun/NJKScrollFullScreen/pulls/20/comments","review_comment_url":"https://api.github.com/repos/ninjinkun/NJKScrollFullScreen/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ninjinkun/NJKScrollFullScreen/issues/20/comments","statuses_url":"https://api.github.com/repos/ninjinkun/NJKScrollFullScreen/statuses/658e19e5f4316e3618dafb07383bfe3db7500fc0","head":{"label":"TonnyXu:master","ref":"master","sha":"658e19e5f4316e3618dafb07383bfe3db7500fc0","user":{"login":"TonnyXu","id":211446,"avatar_url":"https://avatars.githubusercontent.com/u/211446?v=2","gravatar_id":"ce4f2d1c999079a0d9f43e3300dc57c4","url":"https://api.github.com/users/TonnyXu","html_url":"https://github.com/TonnyXu","followers_url":"https://api.github.com/users/TonnyXu/followers","following_url":"https://api.github.com/users/TonnyXu/following{/other_user}","gists_url":"https://api.github.com/users/TonnyXu/gists{/gist_id}","starred_url":"https://api.github.com/users/TonnyXu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TonnyXu/subscriptions","organizations_url":"https://api.github.com/users/TonnyXu/orgs","repos_url":"https://api.github.com/users/TonnyXu/repos","events_url":"https://api.github.com/users/TonnyXu/events{/privacy}","received_events_url":"https://api.github.com/users/TonnyXu/received_events","type":"User","site_admin":false},"repo":{"id":23075778,"name":"NJKScrollFullScreen","full_name":"TonnyXu/NJKScrollFullScreen","owner":{"login":"TonnyXu","id":211446,"avatar_url":"https://avatars.githubusercontent.com/u/211446?v=2","gravatar_id":"ce4f2d1c999079a0d9f43e3300dc57c4","url":"https://api.github.com/users/TonnyXu","html_url":"https://github.com/TonnyXu","followers_url":"https://api.github.com/users/TonnyXu/followers","following_url":"https://api.github.com/users/TonnyXu/following{/other_user}","gists_url":"https://api.github.com/users/TonnyXu/gists{/gist_id}","starred_url":"https://api.github.com/users/TonnyXu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TonnyXu/subscriptions","organizations_url":"https://api.github.com/users/TonnyXu/orgs","repos_url":"https://api.github.com/users/TonnyXu/repos","events_url":"https://api.github.com/users/TonnyXu/events{/privacy}","received_events_url":"https://api.github.com/users/TonnyXu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TonnyXu/NJKScrollFullScreen","description":"Scroll to full screen like Facebook app","fork":true,"url":"https://api.github.com/repos/TonnyXu/NJKScrollFullScreen","forks_url":"https://api.github.com/repos/TonnyXu/NJKScrollFullScreen/forks","keys_url":"https://api.github.com/repos/TonnyXu/NJKScrollFullScreen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TonnyXu/NJKScrollFullScreen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TonnyXu/NJKScrollFullScreen/teams","hooks_url":"https://api.github.com/repos/TonnyXu/NJKScrollFullScreen/hooks","issue_events_url":"https://api.github.com/repos/TonnyXu/NJKScrollFullScreen/issues/events{/number}","events_url":"https://api.github.com/repos/TonnyXu/NJKScrollFullScreen/events","assignees_url":"https://api.github.com/repos/TonnyXu/NJKScrollFullScreen/assignees{/user}","branches_url":"https://api.github.com/repos/TonnyXu/NJKScrollFullScreen/branches{/branch}","tags_url":"https://api.github.com/repos/TonnyXu/NJKScrollFullScreen/tags","blobs_url":"https://api.github.com/repos/TonnyXu/NJKScrollFullScreen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TonnyXu/NJKScrollFullScreen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TonnyXu/NJKScrollFullScreen/git/refs{/sha}","trees_url":"https://api.github.com/repos/TonnyXu/NJKScrollFullScreen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TonnyXu/NJKScrollFullScreen/statuses/{sha}","languages_url":"https://api.github.com/repos/TonnyXu/NJKScrollFullScreen/languages","stargazers_url":"https://api.github.com/repos/TonnyXu/NJKScrollFullScreen/stargazers","contributors_url":"https://api.github.com/repos/TonnyXu/NJKScrollFullScreen/contributors","subscribers_url":"https://api.github.com/repos/TonnyXu/NJKScrollFullScreen/subscribers","subscription_url":"https://api.github.com/repos/TonnyXu/NJKScrollFullScreen/subscription","commits_url":"https://api.github.com/repos/TonnyXu/NJKScrollFullScreen/commits{/sha}","git_commits_url":"https://api.github.com/repos/TonnyXu/NJKScrollFullScreen/git/commits{/sha}","comments_url":"https://api.github.com/repos/TonnyXu/NJKScrollFullScreen/comments{/number}","issue_comment_url":"https://api.github.com/repos/TonnyXu/NJKScrollFullScreen/issues/comments/{number}","contents_url":"https://api.github.com/repos/TonnyXu/NJKScrollFullScreen/contents/{+path}","compare_url":"https://api.github.com/repos/TonnyXu/NJKScrollFullScreen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TonnyXu/NJKScrollFullScreen/merges","archive_url":"https://api.github.com/repos/TonnyXu/NJKScrollFullScreen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TonnyXu/NJKScrollFullScreen/downloads","issues_url":"https://api.github.com/repos/TonnyXu/NJKScrollFullScreen/issues{/number}","pulls_url":"https://api.github.com/repos/TonnyXu/NJKScrollFullScreen/pulls{/number}","milestones_url":"https://api.github.com/repos/TonnyXu/NJKScrollFullScreen/milestones{/number}","notifications_url":"https://api.github.com/repos/TonnyXu/NJKScrollFullScreen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TonnyXu/NJKScrollFullScreen/labels{/name}","releases_url":"https://api.github.com/repos/TonnyXu/NJKScrollFullScreen/releases{/id}","created_at":"2014-08-18T15:11:11Z","updated_at":"2014-08-18T15:16:35Z","pushed_at":"2014-08-18T23:07:28Z","git_url":"git://github.com/TonnyXu/NJKScrollFullScreen.git","ssh_url":"git@github.com:TonnyXu/NJKScrollFullScreen.git","clone_url":"https://github.com/TonnyXu/NJKScrollFullScreen.git","svn_url":"https://github.com/TonnyXu/NJKScrollFullScreen","homepage":"","size":7202,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ninjinkun:master","ref":"master","sha":"6bd4683c92c440f50a09b6a1aa58ef6cb30d413c","user":{"login":"ninjinkun","id":113420,"avatar_url":"https://avatars.githubusercontent.com/u/113420?v=2","gravatar_id":"6139fd48daa26e786794598c4a6b546a","url":"https://api.github.com/users/ninjinkun","html_url":"https://github.com/ninjinkun","followers_url":"https://api.github.com/users/ninjinkun/followers","following_url":"https://api.github.com/users/ninjinkun/following{/other_user}","gists_url":"https://api.github.com/users/ninjinkun/gists{/gist_id}","starred_url":"https://api.github.com/users/ninjinkun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ninjinkun/subscriptions","organizations_url":"https://api.github.com/users/ninjinkun/orgs","repos_url":"https://api.github.com/users/ninjinkun/repos","events_url":"https://api.github.com/users/ninjinkun/events{/privacy}","received_events_url":"https://api.github.com/users/ninjinkun/received_events","type":"User","site_admin":false},"repo":{"id":15628859,"name":"NJKScrollFullScreen","full_name":"ninjinkun/NJKScrollFullScreen","owner":{"login":"ninjinkun","id":113420,"avatar_url":"https://avatars.githubusercontent.com/u/113420?v=2","gravatar_id":"6139fd48daa26e786794598c4a6b546a","url":"https://api.github.com/users/ninjinkun","html_url":"https://github.com/ninjinkun","followers_url":"https://api.github.com/users/ninjinkun/followers","following_url":"https://api.github.com/users/ninjinkun/following{/other_user}","gists_url":"https://api.github.com/users/ninjinkun/gists{/gist_id}","starred_url":"https://api.github.com/users/ninjinkun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ninjinkun/subscriptions","organizations_url":"https://api.github.com/users/ninjinkun/orgs","repos_url":"https://api.github.com/users/ninjinkun/repos","events_url":"https://api.github.com/users/ninjinkun/events{/privacy}","received_events_url":"https://api.github.com/users/ninjinkun/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ninjinkun/NJKScrollFullScreen","description":"Scroll to full screen like Facebook app","fork":false,"url":"https://api.github.com/repos/ninjinkun/NJKScrollFullScreen","forks_url":"https://api.github.com/repos/ninjinkun/NJKScrollFullScreen/forks","keys_url":"https://api.github.com/repos/ninjinkun/NJKScrollFullScreen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ninjinkun/NJKScrollFullScreen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ninjinkun/NJKScrollFullScreen/teams","hooks_url":"https://api.github.com/repos/ninjinkun/NJKScrollFullScreen/hooks","issue_events_url":"https://api.github.com/repos/ninjinkun/NJKScrollFullScreen/issues/events{/number}","events_url":"https://api.github.com/repos/ninjinkun/NJKScrollFullScreen/events","assignees_url":"https://api.github.com/repos/ninjinkun/NJKScrollFullScreen/assignees{/user}","branches_url":"https://api.github.com/repos/ninjinkun/NJKScrollFullScreen/branches{/branch}","tags_url":"https://api.github.com/repos/ninjinkun/NJKScrollFullScreen/tags","blobs_url":"https://api.github.com/repos/ninjinkun/NJKScrollFullScreen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ninjinkun/NJKScrollFullScreen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ninjinkun/NJKScrollFullScreen/git/refs{/sha}","trees_url":"https://api.github.com/repos/ninjinkun/NJKScrollFullScreen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ninjinkun/NJKScrollFullScreen/statuses/{sha}","languages_url":"https://api.github.com/repos/ninjinkun/NJKScrollFullScreen/languages","stargazers_url":"https://api.github.com/repos/ninjinkun/NJKScrollFullScreen/stargazers","contributors_url":"https://api.github.com/repos/ninjinkun/NJKScrollFullScreen/contributors","subscribers_url":"https://api.github.com/repos/ninjinkun/NJKScrollFullScreen/subscribers","subscription_url":"https://api.github.com/repos/ninjinkun/NJKScrollFullScreen/subscription","commits_url":"https://api.github.com/repos/ninjinkun/NJKScrollFullScreen/commits{/sha}","git_commits_url":"https://api.github.com/repos/ninjinkun/NJKScrollFullScreen/git/commits{/sha}","comments_url":"https://api.github.com/repos/ninjinkun/NJKScrollFullScreen/comments{/number}","issue_comment_url":"https://api.github.com/repos/ninjinkun/NJKScrollFullScreen/issues/comments/{number}","contents_url":"https://api.github.com/repos/ninjinkun/NJKScrollFullScreen/contents/{+path}","compare_url":"https://api.github.com/repos/ninjinkun/NJKScrollFullScreen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ninjinkun/NJKScrollFullScreen/merges","archive_url":"https://api.github.com/repos/ninjinkun/NJKScrollFullScreen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ninjinkun/NJKScrollFullScreen/downloads","issues_url":"https://api.github.com/repos/ninjinkun/NJKScrollFullScreen/issues{/number}","pulls_url":"https://api.github.com/repos/ninjinkun/NJKScrollFullScreen/pulls{/number}","milestones_url":"https://api.github.com/repos/ninjinkun/NJKScrollFullScreen/milestones{/number}","notifications_url":"https://api.github.com/repos/ninjinkun/NJKScrollFullScreen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ninjinkun/NJKScrollFullScreen/labels{/name}","releases_url":"https://api.github.com/repos/ninjinkun/NJKScrollFullScreen/releases{/id}","created_at":"2014-01-04T08:09:07Z","updated_at":"2014-08-14T18:35:03Z","pushed_at":"2014-08-18T16:21:14Z","git_url":"git://github.com/ninjinkun/NJKScrollFullScreen.git","ssh_url":"git@github.com:ninjinkun/NJKScrollFullScreen.git","clone_url":"https://github.com/ninjinkun/NJKScrollFullScreen.git","svn_url":"https://github.com/ninjinkun/NJKScrollFullScreen","homepage":"","size":7691,"stargazers_count":568,"watchers_count":568,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":53,"mirror_url":null,"open_issues_count":5,"forks":53,"open_issues":5,"watchers":568,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ninjinkun/NJKScrollFullScreen/pulls/20"},"html":{"href":"https://github.com/ninjinkun/NJKScrollFullScreen/pull/20"},"issue":{"href":"https://api.github.com/repos/ninjinkun/NJKScrollFullScreen/issues/20"},"comments":{"href":"https://api.github.com/repos/ninjinkun/NJKScrollFullScreen/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/ninjinkun/NJKScrollFullScreen/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/ninjinkun/NJKScrollFullScreen/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ninjinkun/NJKScrollFullScreen/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/ninjinkun/NJKScrollFullScreen/statuses/658e19e5f4316e3618dafb07383bfe3db7500fc0"}}}}