GitHub PullRequestReviewCommentEvent at 2014-11-25 03:12:58
Repository: rails
Actor: zzak
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/rails/rails/pulls/comments/20840938","id":20840938,"diff_hunk":"@@ -967,6 +967,13 @@ def index\n       end\n     end\n \n+    test \"warns when config.log_level is never set\" do\n+      ENV[\"RAILS_ENV\"] = \"production\"","path":"railties/test/application/configuration_test.rb","position":null,"original_position":5,"commit_id":"789304f1b47b749154d8b4f75bff545ffd71b5ba","original_commit_id":"adfd898c78c08b6455a12536a757328b30886187","user":{"login":"zzak","id":277819,"avatar_url":"https://avatars.githubusercontent.com/u/277819?v=3","gravatar_id":"","url":"https://api.github.com/users/zzak","html_url":"https://github.com/zzak","followers_url":"https://api.github.com/users/zzak/followers","following_url":"https://api.github.com/users/zzak/following{/other_user}","gists_url":"https://api.github.com/users/zzak/gists{/gist_id}","starred_url":"https://api.github.com/users/zzak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zzak/subscriptions","organizations_url":"https://api.github.com/users/zzak/orgs","repos_url":"https://api.github.com/users/zzak/repos","events_url":"https://api.github.com/users/zzak/events{/privacy}","received_events_url":"https://api.github.com/users/zzak/received_events","type":"User","site_admin":false},"body":"@rafaelfranca Done, please see 789304f","created_at":"2014-11-25T03:12:58Z","updated_at":"2014-11-25T03:12:58Z","html_url":"https://github.com/rails/rails/pull/17756#discussion_r20840938","pull_request_url":"https://api.github.com/repos/rails/rails/pulls/17756","_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/comments/20840938"},"html":{"href":"https://github.com/rails/rails/pull/17756#discussion_r20840938"},"pull_request":{"href":"https://api.github.com/repos/rails/rails/pulls/17756"}}},"pull_request":{"url":"https://api.github.com/repos/rails/rails/pulls/17756","id":24977603,"html_url":"https://github.com/rails/rails/pull/17756","diff_url":"https://github.com/rails/rails/pull/17756.diff","patch_url":"https://github.com/rails/rails/pull/17756.patch","issue_url":"https://api.github.com/repos/rails/rails/issues/17756","number":17756,"state":"open","locked":false,"title":"Add test for #16622 as of a6de6f5","user":{"login":"zzak","id":277819,"avatar_url":"https://avatars.githubusercontent.com/u/277819?v=3","gravatar_id":"","url":"https://api.github.com/users/zzak","html_url":"https://github.com/zzak","followers_url":"https://api.github.com/users/zzak/followers","following_url":"https://api.github.com/users/zzak/following{/other_user}","gists_url":"https://api.github.com/users/zzak/gists{/gist_id}","starred_url":"https://api.github.com/users/zzak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zzak/subscriptions","organizations_url":"https://api.github.com/users/zzak/orgs","repos_url":"https://api.github.com/users/zzak/repos","events_url":"https://api.github.com/users/zzak/events{/privacy}","received_events_url":"https://api.github.com/users/zzak/received_events","type":"User","site_admin":false},"body":"cc @chancancode ","created_at":"2014-11-25T01:04:01Z","updated_at":"2014-11-25T03:12:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e90dfe0428cc5dfad87196d434ec405d0fd062c0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rails/rails/pulls/17756/commits","review_comments_url":"https://api.github.com/repos/rails/rails/pulls/17756/comments","review_comment_url":"https://api.github.com/repos/rails/rails/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rails/rails/issues/17756/comments","statuses_url":"https://api.github.com/repos/rails/rails/statuses/789304f1b47b749154d8b4f75bff545ffd71b5ba","head":{"label":"zzak:test-for-16622","ref":"test-for-16622","sha":"789304f1b47b749154d8b4f75bff545ffd71b5ba","user":{"login":"zzak","id":277819,"avatar_url":"https://avatars.githubusercontent.com/u/277819?v=3","gravatar_id":"","url":"https://api.github.com/users/zzak","html_url":"https://github.com/zzak","followers_url":"https://api.github.com/users/zzak/followers","following_url":"https://api.github.com/users/zzak/following{/other_user}","gists_url":"https://api.github.com/users/zzak/gists{/gist_id}","starred_url":"https://api.github.com/users/zzak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zzak/subscriptions","organizations_url":"https://api.github.com/users/zzak/orgs","repos_url":"https://api.github.com/users/zzak/repos","events_url":"https://api.github.com/users/zzak/events{/privacy}","received_events_url":"https://api.github.com/users/zzak/received_events","type":"User","site_admin":false},"repo":{"id":2396446,"name":"rails","full_name":"zzak/rails","owner":{"login":"zzak","id":277819,"avatar_url":"https://avatars.githubusercontent.com/u/277819?v=3","gravatar_id":"","url":"https://api.github.com/users/zzak","html_url":"https://github.com/zzak","followers_url":"https://api.github.com/users/zzak/followers","following_url":"https://api.github.com/users/zzak/following{/other_user}","gists_url":"https://api.github.com/users/zzak/gists{/gist_id}","starred_url":"https://api.github.com/users/zzak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zzak/subscriptions","organizations_url":"https://api.github.com/users/zzak/orgs","repos_url":"https://api.github.com/users/zzak/repos","events_url":"https://api.github.com/users/zzak/events{/privacy}","received_events_url":"https://api.github.com/users/zzak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zzak/rails","description":"Ruby on Rails","fork":true,"url":"https://api.github.com/repos/zzak/rails","forks_url":"https://api.github.com/repos/zzak/rails/forks","keys_url":"https://api.github.com/repos/zzak/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zzak/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zzak/rails/teams","hooks_url":"https://api.github.com/repos/zzak/rails/hooks","issue_events_url":"https://api.github.com/repos/zzak/rails/issues/events{/number}","events_url":"https://api.github.com/repos/zzak/rails/events","assignees_url":"https://api.github.com/repos/zzak/rails/assignees{/user}","branches_url":"https://api.github.com/repos/zzak/rails/branches{/branch}","tags_url":"https://api.github.com/repos/zzak/rails/tags","blobs_url":"https://api.github.com/repos/zzak/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zzak/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zzak/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/zzak/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zzak/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/zzak/rails/languages","stargazers_url":"https://api.github.com/repos/zzak/rails/stargazers","contributors_url":"https://api.github.com/repos/zzak/rails/contributors","subscribers_url":"https://api.github.com/repos/zzak/rails/subscribers","subscription_url":"https://api.github.com/repos/zzak/rails/subscription","commits_url":"https://api.github.com/repos/zzak/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/zzak/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/zzak/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/zzak/rails/issues/comments/{number}","contents_url":"https://api.github.com/repos/zzak/rails/contents/{+path}","compare_url":"https://api.github.com/repos/zzak/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zzak/rails/merges","archive_url":"https://api.github.com/repos/zzak/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zzak/rails/downloads","issues_url":"https://api.github.com/repos/zzak/rails/issues{/number}","pulls_url":"https://api.github.com/repos/zzak/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/zzak/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/zzak/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zzak/rails/labels{/name}","releases_url":"https://api.github.com/repos/zzak/rails/releases{/id}","created_at":"2011-09-16T00:49:17Z","updated_at":"2014-11-25T00:12:29Z","pushed_at":"2014-11-25T03:12:32Z","git_url":"git://github.com/zzak/rails.git","ssh_url":"git@github.com:zzak/rails.git","clone_url":"https://github.com/zzak/rails.git","svn_url":"https://github.com/zzak/rails","homepage":"http://rubyonrails.org","size":119943,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rails:master","ref":"master","sha":"35362fc2263d4d7784de172cb5f97eb2541fb65a","user":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"repo":{"id":8514,"name":"rails","full_name":"rails/rails","owner":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rails/rails","description":"Ruby on Rails","fork":false,"url":"https://api.github.com/repos/rails/rails","forks_url":"https://api.github.com/repos/rails/rails/forks","keys_url":"https://api.github.com/repos/rails/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails/rails/teams","hooks_url":"https://api.github.com/repos/rails/rails/hooks","issue_events_url":"https://api.github.com/repos/rails/rails/issues/events{/number}","events_url":"https://api.github.com/repos/rails/rails/events","assignees_url":"https://api.github.com/repos/rails/rails/assignees{/user}","branches_url":"https://api.github.com/repos/rails/rails/branches{/branch}","tags_url":"https://api.github.com/repos/rails/rails/tags","blobs_url":"https://api.github.com/repos/rails/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/rails/rails/languages","stargazers_url":"https://api.github.com/repos/rails/rails/stargazers","contributors_url":"https://api.github.com/repos/rails/rails/contributors","subscribers_url":"https://api.github.com/repos/rails/rails/subscribers","subscription_url":"https://api.github.com/repos/rails/rails/subscription","commits_url":"https://api.github.com/repos/rails/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails/rails/issues/comments/{number}","contents_url":"https://api.github.com/repos/rails/rails/contents/{+path}","compare_url":"https://api.github.com/repos/rails/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails/rails/merges","archive_url":"https://api.github.com/repos/rails/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails/rails/downloads","issues_url":"https://api.github.com/repos/rails/rails/issues{/number}","pulls_url":"https://api.github.com/repos/rails/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/rails/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/rails/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails/rails/labels{/name}","releases_url":"https://api.github.com/repos/rails/rails/releases{/id}","created_at":"2008-04-11T02:19:47Z","updated_at":"2014-11-25T02:27:03Z","pushed_at":"2014-11-25T02:27:03Z","git_url":"git://github.com/rails/rails.git","ssh_url":"git@github.com:rails/rails.git","clone_url":"https://github.com/rails/rails.git","svn_url":"https://github.com/rails/rails","homepage":"http://rubyonrails.org","size":410365,"stargazers_count":24004,"watchers_count":24004,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9207,"mirror_url":null,"open_issues_count":762,"forks":9207,"open_issues":762,"watchers":24004,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/17756"},"html":{"href":"https://github.com/rails/rails/pull/17756"},"issue":{"href":"https://api.github.com/repos/rails/rails/issues/17756"},"comments":{"href":"https://api.github.com/repos/rails/rails/issues/17756/comments"},"review_comments":{"href":"https://api.github.com/repos/rails/rails/pulls/17756/comments"},"review_comment":{"href":"https://api.github.com/repos/rails/rails/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rails/rails/pulls/17756/commits"},"statuses":{"href":"https://api.github.com/repos/rails/rails/statuses/789304f1b47b749154d8b4f75bff545ffd71b5ba"}}}}