GitHub PullRequestReviewCommentEvent at 2014-11-18 20:57:21
Repository: mapstruct
Actor: gunnarmorling
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mapstruct/mapstruct/pulls/comments/20537498","id":20537498,"diff_hunk":"@@ -161,4 +165,107 @@ public TypeElement visitType(TypeElement e, Void p) {\n \n         return typeElement != null ? typeElement.getQualifiedName().toString() : null;\n     }\n+\n+    /**\n+     * @param mirror the type mirror\n+     * @return the corresponding type element\n+     */\n+    private static TypeElement asTypeElement(TypeMirror mirror) {\n+        return (TypeElement) ( (DeclaredType) mirror ).asElement();\n+    }\n+\n+    /**\n+     * Finds all executable elements within the given type element, including executable elements defined in super\n+     * classes and implemented interfaces. Methods defined in {@link java.lang.Object} are ignored, as well as\n+     * implementations of {@link java.lang.Object#equals(Object)}.\n+     *\n+     * @param elementUtils element helper\n+     * @param element the element to inspect\n+     * @return the executable elements usable in the type\n+     */\n+    public static List<ExecutableElement> getAllEnclosingExecutableElements(","path":"processor/src/main/java/org/mapstruct/ap/util/Executables.java","position":43,"original_position":43,"commit_id":"03535ecb18a985c441a12f545abc30388950880a","original_commit_id":"03535ecb18a985c441a12f545abc30388950880a","user":{"login":"gunnarmorling","id":28612,"avatar_url":"https://avatars.githubusercontent.com/u/28612?v=3","gravatar_id":"","url":"https://api.github.com/users/gunnarmorling","html_url":"https://github.com/gunnarmorling","followers_url":"https://api.github.com/users/gunnarmorling/followers","following_url":"https://api.github.com/users/gunnarmorling/following{/other_user}","gists_url":"https://api.github.com/users/gunnarmorling/gists{/gist_id}","starred_url":"https://api.github.com/users/gunnarmorling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gunnarmorling/subscriptions","organizations_url":"https://api.github.com/users/gunnarmorling/orgs","repos_url":"https://api.github.com/users/gunnarmorling/repos","events_url":"https://api.github.com/users/gunnarmorling/events{/privacy}","received_events_url":"https://api.github.com/users/gunnarmorling/received_events","type":"User","site_admin":false},"body":"I guess that should be `getAllEnclosedExecutableElements()`. I'll change it.","created_at":"2014-11-18T20:57:21Z","updated_at":"2014-11-18T20:57:21Z","html_url":"https://github.com/mapstruct/mapstruct/pull/352#discussion_r20537498","pull_request_url":"https://api.github.com/repos/mapstruct/mapstruct/pulls/352","_links":{"self":{"href":"https://api.github.com/repos/mapstruct/mapstruct/pulls/comments/20537498"},"html":{"href":"https://github.com/mapstruct/mapstruct/pull/352#discussion_r20537498"},"pull_request":{"href":"https://api.github.com/repos/mapstruct/mapstruct/pulls/352"}}},"pull_request":{"url":"https://api.github.com/repos/mapstruct/mapstruct/pulls/352","id":24626692,"html_url":"https://github.com/mapstruct/mapstruct/pull/352","diff_url":"https://github.com/mapstruct/mapstruct/pull/352.diff","patch_url":"https://github.com/mapstruct/mapstruct/pull/352.patch","issue_url":"https://api.github.com/repos/mapstruct/mapstruct/issues/352","number":352,"state":"open","locked":false,"title":"replace any Elements#getAllMembers calls","user":{"login":"agudian","id":2737102,"avatar_url":"https://avatars.githubusercontent.com/u/2737102?v=3","gravatar_id":"","url":"https://api.github.com/users/agudian","html_url":"https://github.com/agudian","followers_url":"https://api.github.com/users/agudian/followers","following_url":"https://api.github.com/users/agudian/following{/other_user}","gists_url":"https://api.github.com/users/agudian/gists{/gist_id}","starred_url":"https://api.github.com/users/agudian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agudian/subscriptions","organizations_url":"https://api.github.com/users/agudian/orgs","repos_url":"https://api.github.com/users/agudian/repos","events_url":"https://api.github.com/users/agudian/events{/privacy}","received_events_url":"https://api.github.com/users/agudian/received_events","type":"User","site_admin":false},"body":"Move MethodRetrievalProcessor#allEnclosingElementsIncludeSuper to Executables#getAllEnclosingExecutableElements and replace any Elements#getAllMembers calls with it (to create a fixed order of property mappings).\r\n\r\n@gunnarmorling: I'm pretty sure the commit could use some code-formatting... :wink: \r\n\r\n","created_at":"2014-11-18T17:02:10Z","updated_at":"2014-11-18T20:57:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1e2db2323252d8be9623411f6a8ffa45f2e533fd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mapstruct/mapstruct/pulls/352/commits","review_comments_url":"https://api.github.com/repos/mapstruct/mapstruct/pulls/352/comments","review_comment_url":"https://api.github.com/repos/mapstruct/mapstruct/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mapstruct/mapstruct/issues/352/comments","statuses_url":"https://api.github.com/repos/mapstruct/mapstruct/statuses/03535ecb18a985c441a12f545abc30388950880a","head":{"label":"agudian:no-get-all-members","ref":"no-get-all-members","sha":"03535ecb18a985c441a12f545abc30388950880a","user":{"login":"agudian","id":2737102,"avatar_url":"https://avatars.githubusercontent.com/u/2737102?v=3","gravatar_id":"","url":"https://api.github.com/users/agudian","html_url":"https://github.com/agudian","followers_url":"https://api.github.com/users/agudian/followers","following_url":"https://api.github.com/users/agudian/following{/other_user}","gists_url":"https://api.github.com/users/agudian/gists{/gist_id}","starred_url":"https://api.github.com/users/agudian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agudian/subscriptions","organizations_url":"https://api.github.com/users/agudian/orgs","repos_url":"https://api.github.com/users/agudian/repos","events_url":"https://api.github.com/users/agudian/events{/privacy}","received_events_url":"https://api.github.com/users/agudian/received_events","type":"User","site_admin":false},"repo":{"id":10036641,"name":"mapstruct","full_name":"agudian/mapstruct","owner":{"login":"agudian","id":2737102,"avatar_url":"https://avatars.githubusercontent.com/u/2737102?v=3","gravatar_id":"","url":"https://api.github.com/users/agudian","html_url":"https://github.com/agudian","followers_url":"https://api.github.com/users/agudian/followers","following_url":"https://api.github.com/users/agudian/following{/other_user}","gists_url":"https://api.github.com/users/agudian/gists{/gist_id}","starred_url":"https://api.github.com/users/agudian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agudian/subscriptions","organizations_url":"https://api.github.com/users/agudian/orgs","repos_url":"https://api.github.com/users/agudian/repos","events_url":"https://api.github.com/users/agudian/events{/privacy}","received_events_url":"https://api.github.com/users/agudian/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/agudian/mapstruct","description":"An annotation processor for generating type-safe bean mappers","fork":true,"url":"https://api.github.com/repos/agudian/mapstruct","forks_url":"https://api.github.com/repos/agudian/mapstruct/forks","keys_url":"https://api.github.com/repos/agudian/mapstruct/keys{/key_id}","collaborators_url":"https://api.github.com/repos/agudian/mapstruct/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/agudian/mapstruct/teams","hooks_url":"https://api.github.com/repos/agudian/mapstruct/hooks","issue_events_url":"https://api.github.com/repos/agudian/mapstruct/issues/events{/number}","events_url":"https://api.github.com/repos/agudian/mapstruct/events","assignees_url":"https://api.github.com/repos/agudian/mapstruct/assignees{/user}","branches_url":"https://api.github.com/repos/agudian/mapstruct/branches{/branch}","tags_url":"https://api.github.com/repos/agudian/mapstruct/tags","blobs_url":"https://api.github.com/repos/agudian/mapstruct/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/agudian/mapstruct/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/agudian/mapstruct/git/refs{/sha}","trees_url":"https://api.github.com/repos/agudian/mapstruct/git/trees{/sha}","statuses_url":"https://api.github.com/repos/agudian/mapstruct/statuses/{sha}","languages_url":"https://api.github.com/repos/agudian/mapstruct/languages","stargazers_url":"https://api.github.com/repos/agudian/mapstruct/stargazers","contributors_url":"https://api.github.com/repos/agudian/mapstruct/contributors","subscribers_url":"https://api.github.com/repos/agudian/mapstruct/subscribers","subscription_url":"https://api.github.com/repos/agudian/mapstruct/subscription","commits_url":"https://api.github.com/repos/agudian/mapstruct/commits{/sha}","git_commits_url":"https://api.github.com/repos/agudian/mapstruct/git/commits{/sha}","comments_url":"https://api.github.com/repos/agudian/mapstruct/comments{/number}","issue_comment_url":"https://api.github.com/repos/agudian/mapstruct/issues/comments/{number}","contents_url":"https://api.github.com/repos/agudian/mapstruct/contents/{+path}","compare_url":"https://api.github.com/repos/agudian/mapstruct/compare/{base}...{head}","merges_url":"https://api.github.com/repos/agudian/mapstruct/merges","archive_url":"https://api.github.com/repos/agudian/mapstruct/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/agudian/mapstruct/downloads","issues_url":"https://api.github.com/repos/agudian/mapstruct/issues{/number}","pulls_url":"https://api.github.com/repos/agudian/mapstruct/pulls{/number}","milestones_url":"https://api.github.com/repos/agudian/mapstruct/milestones{/number}","notifications_url":"https://api.github.com/repos/agudian/mapstruct/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/agudian/mapstruct/labels{/name}","releases_url":"https://api.github.com/repos/agudian/mapstruct/releases{/id}","created_at":"2013-05-13T17:04:13Z","updated_at":"2014-06-29T09:34:42Z","pushed_at":"2014-11-18T16:59:12Z","git_url":"git://github.com/agudian/mapstruct.git","ssh_url":"git@github.com:agudian/mapstruct.git","clone_url":"https://github.com/agudian/mapstruct.git","svn_url":"https://github.com/agudian/mapstruct","homepage":null,"size":3320,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mapstruct:master","ref":"master","sha":"9992801f28e976658227d0157704e4564613825b","user":{"login":"mapstruct","id":4086779,"avatar_url":"https://avatars.githubusercontent.com/u/4086779?v=3","gravatar_id":"","url":"https://api.github.com/users/mapstruct","html_url":"https://github.com/mapstruct","followers_url":"https://api.github.com/users/mapstruct/followers","following_url":"https://api.github.com/users/mapstruct/following{/other_user}","gists_url":"https://api.github.com/users/mapstruct/gists{/gist_id}","starred_url":"https://api.github.com/users/mapstruct/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapstruct/subscriptions","organizations_url":"https://api.github.com/users/mapstruct/orgs","repos_url":"https://api.github.com/users/mapstruct/repos","events_url":"https://api.github.com/users/mapstruct/events{/privacy}","received_events_url":"https://api.github.com/users/mapstruct/received_events","type":"Organization","site_admin":false},"repo":{"id":4470435,"name":"mapstruct","full_name":"mapstruct/mapstruct","owner":{"login":"mapstruct","id":4086779,"avatar_url":"https://avatars.githubusercontent.com/u/4086779?v=3","gravatar_id":"","url":"https://api.github.com/users/mapstruct","html_url":"https://github.com/mapstruct","followers_url":"https://api.github.com/users/mapstruct/followers","following_url":"https://api.github.com/users/mapstruct/following{/other_user}","gists_url":"https://api.github.com/users/mapstruct/gists{/gist_id}","starred_url":"https://api.github.com/users/mapstruct/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapstruct/subscriptions","organizations_url":"https://api.github.com/users/mapstruct/orgs","repos_url":"https://api.github.com/users/mapstruct/repos","events_url":"https://api.github.com/users/mapstruct/events{/privacy}","received_events_url":"https://api.github.com/users/mapstruct/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapstruct/mapstruct","description":"An annotation processor for generating type-safe bean mappers","fork":false,"url":"https://api.github.com/repos/mapstruct/mapstruct","forks_url":"https://api.github.com/repos/mapstruct/mapstruct/forks","keys_url":"https://api.github.com/repos/mapstruct/mapstruct/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapstruct/mapstruct/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapstruct/mapstruct/teams","hooks_url":"https://api.github.com/repos/mapstruct/mapstruct/hooks","issue_events_url":"https://api.github.com/repos/mapstruct/mapstruct/issues/events{/number}","events_url":"https://api.github.com/repos/mapstruct/mapstruct/events","assignees_url":"https://api.github.com/repos/mapstruct/mapstruct/assignees{/user}","branches_url":"https://api.github.com/repos/mapstruct/mapstruct/branches{/branch}","tags_url":"https://api.github.com/repos/mapstruct/mapstruct/tags","blobs_url":"https://api.github.com/repos/mapstruct/mapstruct/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapstruct/mapstruct/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapstruct/mapstruct/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapstruct/mapstruct/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapstruct/mapstruct/statuses/{sha}","languages_url":"https://api.github.com/repos/mapstruct/mapstruct/languages","stargazers_url":"https://api.github.com/repos/mapstruct/mapstruct/stargazers","contributors_url":"https://api.github.com/repos/mapstruct/mapstruct/contributors","subscribers_url":"https://api.github.com/repos/mapstruct/mapstruct/subscribers","subscription_url":"https://api.github.com/repos/mapstruct/mapstruct/subscription","commits_url":"https://api.github.com/repos/mapstruct/mapstruct/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapstruct/mapstruct/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapstruct/mapstruct/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapstruct/mapstruct/issues/comments/{number}","contents_url":"https://api.github.com/repos/mapstruct/mapstruct/contents/{+path}","compare_url":"https://api.github.com/repos/mapstruct/mapstruct/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapstruct/mapstruct/merges","archive_url":"https://api.github.com/repos/mapstruct/mapstruct/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapstruct/mapstruct/downloads","issues_url":"https://api.github.com/repos/mapstruct/mapstruct/issues{/number}","pulls_url":"https://api.github.com/repos/mapstruct/mapstruct/pulls{/number}","milestones_url":"https://api.github.com/repos/mapstruct/mapstruct/milestones{/number}","notifications_url":"https://api.github.com/repos/mapstruct/mapstruct/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapstruct/mapstruct/labels{/name}","releases_url":"https://api.github.com/repos/mapstruct/mapstruct/releases{/id}","created_at":"2012-05-28T12:42:42Z","updated_at":"2014-11-18T14:45:59Z","pushed_at":"2014-11-06T18:12:01Z","git_url":"git://github.com/mapstruct/mapstruct.git","ssh_url":"git@github.com:mapstruct/mapstruct.git","clone_url":"https://github.com/mapstruct/mapstruct.git","svn_url":"https://github.com/mapstruct/mapstruct","homepage":"http://mapstruct.org/","size":5912,"stargazers_count":60,"watchers_count":60,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":85,"forks":21,"open_issues":85,"watchers":60,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapstruct/mapstruct/pulls/352"},"html":{"href":"https://github.com/mapstruct/mapstruct/pull/352"},"issue":{"href":"https://api.github.com/repos/mapstruct/mapstruct/issues/352"},"comments":{"href":"https://api.github.com/repos/mapstruct/mapstruct/issues/352/comments"},"review_comments":{"href":"https://api.github.com/repos/mapstruct/mapstruct/pulls/352/comments"},"review_comment":{"href":"https://api.github.com/repos/mapstruct/mapstruct/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mapstruct/mapstruct/pulls/352/commits"},"statuses":{"href":"https://api.github.com/repos/mapstruct/mapstruct/statuses/03535ecb18a985c441a12f545abc30388950880a"}}}}