GitHub PullRequestReviewCommentEvent at 2014-11-11 16:27:16
Repository: pulp
Actor: jortel
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/pulp/pulp/pulls/comments/20160870","id":20160870,"diff_hunk":"@@ -249,8 +249,8 @@ Requires: mod_ssl\n Requires: openssl\n Requires: nss-tools\n Requires: python-ldap\n-Requires: python-gofer >= 1.3.0\n-Requires: python-gofer-qpid >= 1.3.0\n+Requires: python-gofer >= 1.4.0\n+Requires: python-gofer-qpid >= 1.4.0","path":"pulp.spec","position":7,"original_position":7,"commit_id":"8d4173dd533385004b8d113e7ffdd600155388e0","original_commit_id":"8d4173dd533385004b8d113e7ffdd600155388e0","user":{"login":"jortel","id":1126767,"avatar_url":"https://avatars.githubusercontent.com/u/1126767?v=3","gravatar_id":"","url":"https://api.github.com/users/jortel","html_url":"https://github.com/jortel","followers_url":"https://api.github.com/users/jortel/followers","following_url":"https://api.github.com/users/jortel/following{/other_user}","gists_url":"https://api.github.com/users/jortel/gists{/gist_id}","starred_url":"https://api.github.com/users/jortel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jortel/subscriptions","organizations_url":"https://api.github.com/users/jortel/orgs","repos_url":"https://api.github.com/users/jortel/repos","events_url":"https://api.github.com/users/jortel/events{/privacy}","received_events_url":"https://api.github.com/users/jortel/received_events","type":"User","site_admin":false},"body":"Agreed.  We should remove the *Requires* for the qpid support and handle with comps groups.  However, that is outside the scope of this PR.","created_at":"2014-11-11T16:27:16Z","updated_at":"2014-11-11T16:27:16Z","html_url":"https://github.com/pulp/pulp/pull/1286#discussion_r20160870","pull_request_url":"https://api.github.com/repos/pulp/pulp/pulls/1286","_links":{"self":{"href":"https://api.github.com/repos/pulp/pulp/pulls/comments/20160870"},"html":{"href":"https://github.com/pulp/pulp/pull/1286#discussion_r20160870"},"pull_request":{"href":"https://api.github.com/repos/pulp/pulp/pulls/1286"}}},"pull_request":{"url":"https://api.github.com/repos/pulp/pulp/pulls/1286","id":23938166,"html_url":"https://github.com/pulp/pulp/pull/1286","diff_url":"https://github.com/pulp/pulp/pull/1286.diff","patch_url":"https://github.com/pulp/pulp/pull/1286.patch","issue_url":"https://api.github.com/repos/pulp/pulp/issues/1286","number":1286,"state":"open","locked":false,"title":"1121102 - support unordered agent replies.","user":{"login":"jortel","id":1126767,"avatar_url":"https://avatars.githubusercontent.com/u/1126767?v=3","gravatar_id":"","url":"https://api.github.com/users/jortel","html_url":"https://github.com/jortel","followers_url":"https://api.github.com/users/jortel/followers","following_url":"https://api.github.com/users/jortel/following{/other_user}","gists_url":"https://api.github.com/users/jortel/gists{/gist_id}","starred_url":"https://api.github.com/users/jortel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jortel/subscriptions","organizations_url":"https://api.github.com/users/jortel/orgs","repos_url":"https://api.github.com/users/jortel/repos","events_url":"https://api.github.com/users/jortel/events{/privacy}","received_events_url":"https://api.github.com/users/jortel/received_events","type":"User","site_admin":false},"body":"https://bugzilla.redhat.com/show_bug.cgi?id=1121102\r\n\r\nThe solution:\r\n\r\nRequired gofer 1.4 which includes an ISO-8601 timestamp (UTC) in RMI reply messages.\r\n\r\nMake changes to the task status manager methods to take an optional timestamp.  A timestamp is still created when not passed or an empty string because older agents will not be including timetamps in replies.\r\n\r\nProcessing by reply type:\r\n\r\n- Accepted:\r\n  - state changed to ACCEPTED conditionally when state=WAITING\r\n\r\n- Started:\r\n  - start_time set unconditionally.\r\n  - state changed to RUNNING conditionally when state=(WAITING|ACCEPTED)\r\n\r\n- Succeeded:\r\n  - state changed to FINISHED unconditionally.\r\n  - finish_time set unconditionally.\r\n  - result set to reply result unconditionally.\r\n\r\n- Failed:\r\n  - state changed to ERROR unconditionally.\r\n  - finish_time set unconditionally.\r\n  - traceback set to reply exception info unconditionally.\r\n\r\n- Rejected:\r\n  - state changed to ERROR unconditionally.\r\n  - finish_time set unconditionally.\r\n","created_at":"2014-11-05T21:10:00Z","updated_at":"2014-11-11T16:27:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3bc9bd0342a37ccc5409704ca62c8a0914be21fd","assignee":{"login":"bmbouter","id":180319,"avatar_url":"https://avatars.githubusercontent.com/u/180319?v=3","gravatar_id":"","url":"https://api.github.com/users/bmbouter","html_url":"https://github.com/bmbouter","followers_url":"https://api.github.com/users/bmbouter/followers","following_url":"https://api.github.com/users/bmbouter/following{/other_user}","gists_url":"https://api.github.com/users/bmbouter/gists{/gist_id}","starred_url":"https://api.github.com/users/bmbouter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmbouter/subscriptions","organizations_url":"https://api.github.com/users/bmbouter/orgs","repos_url":"https://api.github.com/users/bmbouter/repos","events_url":"https://api.github.com/users/bmbouter/events{/privacy}","received_events_url":"https://api.github.com/users/bmbouter/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/pulp/pulp/pulls/1286/commits","review_comments_url":"https://api.github.com/repos/pulp/pulp/pulls/1286/comments","review_comment_url":"https://api.github.com/repos/pulp/pulp/pulls/comments/{number}","comments_url":"https://api.github.com/repos/pulp/pulp/issues/1286/comments","statuses_url":"https://api.github.com/repos/pulp/pulp/statuses/8d4173dd533385004b8d113e7ffdd600155388e0","head":{"label":"jortel:1121102","ref":"1121102","sha":"8d4173dd533385004b8d113e7ffdd600155388e0","user":{"login":"jortel","id":1126767,"avatar_url":"https://avatars.githubusercontent.com/u/1126767?v=3","gravatar_id":"","url":"https://api.github.com/users/jortel","html_url":"https://github.com/jortel","followers_url":"https://api.github.com/users/jortel/followers","following_url":"https://api.github.com/users/jortel/following{/other_user}","gists_url":"https://api.github.com/users/jortel/gists{/gist_id}","starred_url":"https://api.github.com/users/jortel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jortel/subscriptions","organizations_url":"https://api.github.com/users/jortel/orgs","repos_url":"https://api.github.com/users/jortel/repos","events_url":"https://api.github.com/users/jortel/events{/privacy}","received_events_url":"https://api.github.com/users/jortel/received_events","type":"User","site_admin":false},"repo":{"id":26142168,"name":"pulp","full_name":"jortel/pulp","owner":{"login":"jortel","id":1126767,"avatar_url":"https://avatars.githubusercontent.com/u/1126767?v=3","gravatar_id":"","url":"https://api.github.com/users/jortel","html_url":"https://github.com/jortel","followers_url":"https://api.github.com/users/jortel/followers","following_url":"https://api.github.com/users/jortel/following{/other_user}","gists_url":"https://api.github.com/users/jortel/gists{/gist_id}","starred_url":"https://api.github.com/users/jortel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jortel/subscriptions","organizations_url":"https://api.github.com/users/jortel/orgs","repos_url":"https://api.github.com/users/jortel/repos","events_url":"https://api.github.com/users/jortel/events{/privacy}","received_events_url":"https://api.github.com/users/jortel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jortel/pulp","description":"Repository for Pulp platform code, including the server and base admin and consumer clients","fork":true,"url":"https://api.github.com/repos/jortel/pulp","forks_url":"https://api.github.com/repos/jortel/pulp/forks","keys_url":"https://api.github.com/repos/jortel/pulp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jortel/pulp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jortel/pulp/teams","hooks_url":"https://api.github.com/repos/jortel/pulp/hooks","issue_events_url":"https://api.github.com/repos/jortel/pulp/issues/events{/number}","events_url":"https://api.github.com/repos/jortel/pulp/events","assignees_url":"https://api.github.com/repos/jortel/pulp/assignees{/user}","branches_url":"https://api.github.com/repos/jortel/pulp/branches{/branch}","tags_url":"https://api.github.com/repos/jortel/pulp/tags","blobs_url":"https://api.github.com/repos/jortel/pulp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jortel/pulp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jortel/pulp/git/refs{/sha}","trees_url":"https://api.github.com/repos/jortel/pulp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jortel/pulp/statuses/{sha}","languages_url":"https://api.github.com/repos/jortel/pulp/languages","stargazers_url":"https://api.github.com/repos/jortel/pulp/stargazers","contributors_url":"https://api.github.com/repos/jortel/pulp/contributors","subscribers_url":"https://api.github.com/repos/jortel/pulp/subscribers","subscription_url":"https://api.github.com/repos/jortel/pulp/subscription","commits_url":"https://api.github.com/repos/jortel/pulp/commits{/sha}","git_commits_url":"https://api.github.com/repos/jortel/pulp/git/commits{/sha}","comments_url":"https://api.github.com/repos/jortel/pulp/comments{/number}","issue_comment_url":"https://api.github.com/repos/jortel/pulp/issues/comments/{number}","contents_url":"https://api.github.com/repos/jortel/pulp/contents/{+path}","compare_url":"https://api.github.com/repos/jortel/pulp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jortel/pulp/merges","archive_url":"https://api.github.com/repos/jortel/pulp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jortel/pulp/downloads","issues_url":"https://api.github.com/repos/jortel/pulp/issues{/number}","pulls_url":"https://api.github.com/repos/jortel/pulp/pulls{/number}","milestones_url":"https://api.github.com/repos/jortel/pulp/milestones{/number}","notifications_url":"https://api.github.com/repos/jortel/pulp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jortel/pulp/labels{/name}","releases_url":"https://api.github.com/repos/jortel/pulp/releases{/id}","created_at":"2014-11-03T22:37:29Z","updated_at":"2014-11-03T13:39:09Z","pushed_at":"2014-11-06T15:06:51Z","git_url":"git://github.com/jortel/pulp.git","ssh_url":"git@github.com:jortel/pulp.git","clone_url":"https://github.com/jortel/pulp.git","svn_url":"https://github.com/jortel/pulp","homepage":"","size":76294,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pulp:2.5-dev","ref":"2.5-dev","sha":"577742fb670ac63db7482f4cbfcbe1ef93b327ae","user":{"login":"pulp","id":2103606,"avatar_url":"https://avatars.githubusercontent.com/u/2103606?v=3","gravatar_id":"","url":"https://api.github.com/users/pulp","html_url":"https://github.com/pulp","followers_url":"https://api.github.com/users/pulp/followers","following_url":"https://api.github.com/users/pulp/following{/other_user}","gists_url":"https://api.github.com/users/pulp/gists{/gist_id}","starred_url":"https://api.github.com/users/pulp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulp/subscriptions","organizations_url":"https://api.github.com/users/pulp/orgs","repos_url":"https://api.github.com/users/pulp/repos","events_url":"https://api.github.com/users/pulp/events{/privacy}","received_events_url":"https://api.github.com/users/pulp/received_events","type":"Organization","site_admin":false},"repo":{"id":5314652,"name":"pulp","full_name":"pulp/pulp","owner":{"login":"pulp","id":2103606,"avatar_url":"https://avatars.githubusercontent.com/u/2103606?v=3","gravatar_id":"","url":"https://api.github.com/users/pulp","html_url":"https://github.com/pulp","followers_url":"https://api.github.com/users/pulp/followers","following_url":"https://api.github.com/users/pulp/following{/other_user}","gists_url":"https://api.github.com/users/pulp/gists{/gist_id}","starred_url":"https://api.github.com/users/pulp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulp/subscriptions","organizations_url":"https://api.github.com/users/pulp/orgs","repos_url":"https://api.github.com/users/pulp/repos","events_url":"https://api.github.com/users/pulp/events{/privacy}","received_events_url":"https://api.github.com/users/pulp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pulp/pulp","description":"Repository for Pulp platform code, including the server and base admin and consumer clients","fork":false,"url":"https://api.github.com/repos/pulp/pulp","forks_url":"https://api.github.com/repos/pulp/pulp/forks","keys_url":"https://api.github.com/repos/pulp/pulp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pulp/pulp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pulp/pulp/teams","hooks_url":"https://api.github.com/repos/pulp/pulp/hooks","issue_events_url":"https://api.github.com/repos/pulp/pulp/issues/events{/number}","events_url":"https://api.github.com/repos/pulp/pulp/events","assignees_url":"https://api.github.com/repos/pulp/pulp/assignees{/user}","branches_url":"https://api.github.com/repos/pulp/pulp/branches{/branch}","tags_url":"https://api.github.com/repos/pulp/pulp/tags","blobs_url":"https://api.github.com/repos/pulp/pulp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pulp/pulp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pulp/pulp/git/refs{/sha}","trees_url":"https://api.github.com/repos/pulp/pulp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pulp/pulp/statuses/{sha}","languages_url":"https://api.github.com/repos/pulp/pulp/languages","stargazers_url":"https://api.github.com/repos/pulp/pulp/stargazers","contributors_url":"https://api.github.com/repos/pulp/pulp/contributors","subscribers_url":"https://api.github.com/repos/pulp/pulp/subscribers","subscription_url":"https://api.github.com/repos/pulp/pulp/subscription","commits_url":"https://api.github.com/repos/pulp/pulp/commits{/sha}","git_commits_url":"https://api.github.com/repos/pulp/pulp/git/commits{/sha}","comments_url":"https://api.github.com/repos/pulp/pulp/comments{/number}","issue_comment_url":"https://api.github.com/repos/pulp/pulp/issues/comments/{number}","contents_url":"https://api.github.com/repos/pulp/pulp/contents/{+path}","compare_url":"https://api.github.com/repos/pulp/pulp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pulp/pulp/merges","archive_url":"https://api.github.com/repos/pulp/pulp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pulp/pulp/downloads","issues_url":"https://api.github.com/repos/pulp/pulp/issues{/number}","pulls_url":"https://api.github.com/repos/pulp/pulp/pulls{/number}","milestones_url":"https://api.github.com/repos/pulp/pulp/milestones{/number}","notifications_url":"https://api.github.com/repos/pulp/pulp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pulp/pulp/labels{/name}","releases_url":"https://api.github.com/repos/pulp/pulp/releases{/id}","created_at":"2012-08-06T13:49:20Z","updated_at":"2014-11-10T12:31:48Z","pushed_at":"2014-11-10T21:50:53Z","git_url":"git://github.com/pulp/pulp.git","ssh_url":"git@github.com:pulp/pulp.git","clone_url":"https://github.com/pulp/pulp.git","svn_url":"https://github.com/pulp/pulp","homepage":"","size":208352,"stargazers_count":149,"watchers_count":149,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":70,"mirror_url":null,"open_issues_count":14,"forks":70,"open_issues":14,"watchers":149,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pulp/pulp/pulls/1286"},"html":{"href":"https://github.com/pulp/pulp/pull/1286"},"issue":{"href":"https://api.github.com/repos/pulp/pulp/issues/1286"},"comments":{"href":"https://api.github.com/repos/pulp/pulp/issues/1286/comments"},"review_comments":{"href":"https://api.github.com/repos/pulp/pulp/pulls/1286/comments"},"review_comment":{"href":"https://api.github.com/repos/pulp/pulp/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/pulp/pulp/pulls/1286/commits"},"statuses":{"href":"https://api.github.com/repos/pulp/pulp/statuses/8d4173dd533385004b8d113e7ffdd600155388e0"}}}}