GitHub PullRequestEvent at 2014-04-27 08:57:21
Repository: phaser
Actor: photonstorm
Payload: {"action":"closed","number":766,"pull_request":{"url":"https://api.github.com/repos/photonstorm/phaser/pulls/766","id":15209594,"html_url":"https://github.com/photonstorm/phaser/pull/766","diff_url":"https://github.com/photonstorm/phaser/pull/766.diff","patch_url":"https://github.com/photonstorm/phaser/pull/766.patch","issue_url":"https://api.github.com/repos/photonstorm/phaser/issues/766","number":766,"state":"closed","title":"Polygon.contains returns true for  points to the left of the polygon","user":{"login":"vilcans","id":48641,"avatar_url":"https://avatars.githubusercontent.com/u/48641?","gravatar_id":"7c5548a05b3b74ed9e04236dbb7490ad","url":"https://api.github.com/users/vilcans","html_url":"https://github.com/vilcans","followers_url":"https://api.github.com/users/vilcans/followers","following_url":"https://api.github.com/users/vilcans/following{/other_user}","gists_url":"https://api.github.com/users/vilcans/gists{/gist_id}","starred_url":"https://api.github.com/users/vilcans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vilcans/subscriptions","organizations_url":"https://api.github.com/users/vilcans/orgs","repos_url":"https://api.github.com/users/vilcans/repos","events_url":"https://api.github.com/users/vilcans/events{/privacy}","received_events_url":"https://api.github.com/users/vilcans/received_events","type":"User","site_admin":false},"body":"Test case:\r\n\r\n            var game = new Phaser.Game(600, 400);\r\n            var poly = new Phaser.Polygon(\r\n                50, 0,\r\n                100, 0,\r\n                100, 50,\r\n                50, 50\r\n            );\r\n            var contains = poly.contains(40, 25);\r\n            console.log('Contains?', contains, '(should be false)');\r\n\r\nSome optimization gone wrong maybe when porting PIXI.Polygon maybe?\r\n\r\nAnyway, a simple fix.","created_at":"2014-04-27T06:40:53Z","updated_at":"2014-04-27T08:57:19Z","closed_at":"2014-04-27T08:57:19Z","merged_at":null,"merge_commit_sha":"3a64920cfda36db028d17720fd1665724b96a7bd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/photonstorm/phaser/pulls/766/commits","review_comments_url":"https://api.github.com/repos/photonstorm/phaser/pulls/766/comments","review_comment_url":"https://api.github.com/repos/photonstorm/phaser/pulls/comments/{number}","comments_url":"https://api.github.com/repos/photonstorm/phaser/issues/766/comments","statuses_url":"https://api.github.com/repos/photonstorm/phaser/statuses/98eb66fde36713084e95af94bc6719af3c18df52","head":{"label":"vilcans:containsfix","ref":"containsfix","sha":"98eb66fde36713084e95af94bc6719af3c18df52","user":{"login":"vilcans","id":48641,"avatar_url":"https://avatars.githubusercontent.com/u/48641?","gravatar_id":"7c5548a05b3b74ed9e04236dbb7490ad","url":"https://api.github.com/users/vilcans","html_url":"https://github.com/vilcans","followers_url":"https://api.github.com/users/vilcans/followers","following_url":"https://api.github.com/users/vilcans/following{/other_user}","gists_url":"https://api.github.com/users/vilcans/gists{/gist_id}","starred_url":"https://api.github.com/users/vilcans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vilcans/subscriptions","organizations_url":"https://api.github.com/users/vilcans/orgs","repos_url":"https://api.github.com/users/vilcans/repos","events_url":"https://api.github.com/users/vilcans/events{/privacy}","received_events_url":"https://api.github.com/users/vilcans/received_events","type":"User","site_admin":false},"repo":{"id":19197390,"name":"phaser","full_name":"vilcans/phaser","owner":{"login":"vilcans","id":48641,"avatar_url":"https://avatars.githubusercontent.com/u/48641?","gravatar_id":"7c5548a05b3b74ed9e04236dbb7490ad","url":"https://api.github.com/users/vilcans","html_url":"https://github.com/vilcans","followers_url":"https://api.github.com/users/vilcans/followers","following_url":"https://api.github.com/users/vilcans/following{/other_user}","gists_url":"https://api.github.com/users/vilcans/gists{/gist_id}","starred_url":"https://api.github.com/users/vilcans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vilcans/subscriptions","organizations_url":"https://api.github.com/users/vilcans/orgs","repos_url":"https://api.github.com/users/vilcans/repos","events_url":"https://api.github.com/users/vilcans/events{/privacy}","received_events_url":"https://api.github.com/users/vilcans/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vilcans/phaser","description":"Phaser is a fun, free and fast 2D game framework for making HTML5 games for desktop and mobile web browsers, supporting Canvas and WebGL rendering.","fork":true,"url":"https://api.github.com/repos/vilcans/phaser","forks_url":"https://api.github.com/repos/vilcans/phaser/forks","keys_url":"https://api.github.com/repos/vilcans/phaser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vilcans/phaser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vilcans/phaser/teams","hooks_url":"https://api.github.com/repos/vilcans/phaser/hooks","issue_events_url":"https://api.github.com/repos/vilcans/phaser/issues/events{/number}","events_url":"https://api.github.com/repos/vilcans/phaser/events","assignees_url":"https://api.github.com/repos/vilcans/phaser/assignees{/user}","branches_url":"https://api.github.com/repos/vilcans/phaser/branches{/branch}","tags_url":"https://api.github.com/repos/vilcans/phaser/tags","blobs_url":"https://api.github.com/repos/vilcans/phaser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vilcans/phaser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vilcans/phaser/git/refs{/sha}","trees_url":"https://api.github.com/repos/vilcans/phaser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vilcans/phaser/statuses/{sha}","languages_url":"https://api.github.com/repos/vilcans/phaser/languages","stargazers_url":"https://api.github.com/repos/vilcans/phaser/stargazers","contributors_url":"https://api.github.com/repos/vilcans/phaser/contributors","subscribers_url":"https://api.github.com/repos/vilcans/phaser/subscribers","subscription_url":"https://api.github.com/repos/vilcans/phaser/subscription","commits_url":"https://api.github.com/repos/vilcans/phaser/commits{/sha}","git_commits_url":"https://api.github.com/repos/vilcans/phaser/git/commits{/sha}","comments_url":"https://api.github.com/repos/vilcans/phaser/comments{/number}","issue_comment_url":"https://api.github.com/repos/vilcans/phaser/issues/comments/{number}","contents_url":"https://api.github.com/repos/vilcans/phaser/contents/{+path}","compare_url":"https://api.github.com/repos/vilcans/phaser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vilcans/phaser/merges","archive_url":"https://api.github.com/repos/vilcans/phaser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vilcans/phaser/downloads","issues_url":"https://api.github.com/repos/vilcans/phaser/issues{/number}","pulls_url":"https://api.github.com/repos/vilcans/phaser/pulls{/number}","milestones_url":"https://api.github.com/repos/vilcans/phaser/milestones{/number}","notifications_url":"https://api.github.com/repos/vilcans/phaser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vilcans/phaser/labels{/name}","releases_url":"https://api.github.com/repos/vilcans/phaser/releases{/id}","created_at":"2014-04-27T06:22:40Z","updated_at":"2014-04-27T06:46:37Z","pushed_at":"2014-04-27T06:46:37Z","git_url":"git://github.com/vilcans/phaser.git","ssh_url":"git@github.com:vilcans/phaser.git","clone_url":"https://github.com/vilcans/phaser.git","svn_url":"https://github.com/vilcans/phaser","homepage":"http://phaser.io","size":138328,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"photonstorm:master","ref":"master","sha":"4c31623e6e89e1f68ad910cb026a9d86f50287e3","user":{"login":"photonstorm","id":164476,"avatar_url":"https://avatars.githubusercontent.com/u/164476?","gravatar_id":"4a45b26416268cd8d20fcea241019b8d","url":"https://api.github.com/users/photonstorm","html_url":"https://github.com/photonstorm","followers_url":"https://api.github.com/users/photonstorm/followers","following_url":"https://api.github.com/users/photonstorm/following{/other_user}","gists_url":"https://api.github.com/users/photonstorm/gists{/gist_id}","starred_url":"https://api.github.com/users/photonstorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/photonstorm/subscriptions","organizations_url":"https://api.github.com/users/photonstorm/orgs","repos_url":"https://api.github.com/users/photonstorm/repos","events_url":"https://api.github.com/users/photonstorm/events{/privacy}","received_events_url":"https://api.github.com/users/photonstorm/received_events","type":"User","site_admin":false},"repo":{"id":9393759,"name":"phaser","full_name":"photonstorm/phaser","owner":{"login":"photonstorm","id":164476,"avatar_url":"https://avatars.githubusercontent.com/u/164476?","gravatar_id":"4a45b26416268cd8d20fcea241019b8d","url":"https://api.github.com/users/photonstorm","html_url":"https://github.com/photonstorm","followers_url":"https://api.github.com/users/photonstorm/followers","following_url":"https://api.github.com/users/photonstorm/following{/other_user}","gists_url":"https://api.github.com/users/photonstorm/gists{/gist_id}","starred_url":"https://api.github.com/users/photonstorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/photonstorm/subscriptions","organizations_url":"https://api.github.com/users/photonstorm/orgs","repos_url":"https://api.github.com/users/photonstorm/repos","events_url":"https://api.github.com/users/photonstorm/events{/privacy}","received_events_url":"https://api.github.com/users/photonstorm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/photonstorm/phaser","description":"Phaser is a fun, free and fast 2D game framework for making HTML5 games for desktop and mobile web browsers, supporting Canvas and WebGL rendering.","fork":false,"url":"https://api.github.com/repos/photonstorm/phaser","forks_url":"https://api.github.com/repos/photonstorm/phaser/forks","keys_url":"https://api.github.com/repos/photonstorm/phaser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/photonstorm/phaser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/photonstorm/phaser/teams","hooks_url":"https://api.github.com/repos/photonstorm/phaser/hooks","issue_events_url":"https://api.github.com/repos/photonstorm/phaser/issues/events{/number}","events_url":"https://api.github.com/repos/photonstorm/phaser/events","assignees_url":"https://api.github.com/repos/photonstorm/phaser/assignees{/user}","branches_url":"https://api.github.com/repos/photonstorm/phaser/branches{/branch}","tags_url":"https://api.github.com/repos/photonstorm/phaser/tags","blobs_url":"https://api.github.com/repos/photonstorm/phaser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/photonstorm/phaser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/photonstorm/phaser/git/refs{/sha}","trees_url":"https://api.github.com/repos/photonstorm/phaser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/photonstorm/phaser/statuses/{sha}","languages_url":"https://api.github.com/repos/photonstorm/phaser/languages","stargazers_url":"https://api.github.com/repos/photonstorm/phaser/stargazers","contributors_url":"https://api.github.com/repos/photonstorm/phaser/contributors","subscribers_url":"https://api.github.com/repos/photonstorm/phaser/subscribers","subscription_url":"https://api.github.com/repos/photonstorm/phaser/subscription","commits_url":"https://api.github.com/repos/photonstorm/phaser/commits{/sha}","git_commits_url":"https://api.github.com/repos/photonstorm/phaser/git/commits{/sha}","comments_url":"https://api.github.com/repos/photonstorm/phaser/comments{/number}","issue_comment_url":"https://api.github.com/repos/photonstorm/phaser/issues/comments/{number}","contents_url":"https://api.github.com/repos/photonstorm/phaser/contents/{+path}","compare_url":"https://api.github.com/repos/photonstorm/phaser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/photonstorm/phaser/merges","archive_url":"https://api.github.com/repos/photonstorm/phaser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/photonstorm/phaser/downloads","issues_url":"https://api.github.com/repos/photonstorm/phaser/issues{/number}","pulls_url":"https://api.github.com/repos/photonstorm/phaser/pulls{/number}","milestones_url":"https://api.github.com/repos/photonstorm/phaser/milestones{/number}","notifications_url":"https://api.github.com/repos/photonstorm/phaser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/photonstorm/phaser/labels{/name}","releases_url":"https://api.github.com/repos/photonstorm/phaser/releases{/id}","created_at":"2013-04-12T12:27:51Z","updated_at":"2014-04-27T08:56:41Z","pushed_at":"2014-04-27T08:56:41Z","git_url":"git://github.com/photonstorm/phaser.git","ssh_url":"git@github.com:photonstorm/phaser.git","clone_url":"https://github.com/photonstorm/phaser.git","svn_url":"https://github.com/photonstorm/phaser","homepage":"http://phaser.io","size":138328,"stargazers_count":4283,"watchers_count":4283,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1158,"mirror_url":null,"open_issues_count":31,"forks":1158,"open_issues":31,"watchers":4283,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/photonstorm/phaser/pulls/766"},"html":{"href":"https://github.com/photonstorm/phaser/pull/766"},"issue":{"href":"https://api.github.com/repos/photonstorm/phaser/issues/766"},"comments":{"href":"https://api.github.com/repos/photonstorm/phaser/issues/766/comments"},"review_comments":{"href":"https://api.github.com/repos/photonstorm/phaser/pulls/766/comments"},"review_comment":{"href":"https://api.github.com/repos/photonstorm/phaser/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/photonstorm/phaser/pulls/766/commits"},"statuses":{"href":"https://api.github.com/repos/photonstorm/phaser/statuses/98eb66fde36713084e95af94bc6719af3c18df52"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":2,"additions":13,"deletions":13,"changed_files":8}}