GitHub PullRequestEvent at 2014-07-28 01:13:57
Repository: rspec-core
Actor: jmondo
Payload: {"action":"opened","number":1651,"pull_request":{"url":"https://api.github.com/repos/rspec/rspec-core/pulls/1651","id":18946539,"html_url":"https://github.com/rspec/rspec-core/pull/1651","diff_url":"https://github.com/rspec/rspec-core/pull/1651.diff","patch_url":"https://github.com/rspec/rspec-core/pull/1651.patch","issue_url":"https://api.github.com/repos/rspec/rspec-core/issues/1651","number":1651,"state":"open","title":"Add --exclude_pattern option to configuration","user":{"login":"jmondo","id":603431,"avatar_url":"https://avatars.githubusercontent.com/u/603431?","gravatar_id":"dd1d3ca31630dab34933c1af8ed1a9d4","url":"https://api.github.com/users/jmondo","html_url":"https://github.com/jmondo","followers_url":"https://api.github.com/users/jmondo/followers","following_url":"https://api.github.com/users/jmondo/following{/other_user}","gists_url":"https://api.github.com/users/jmondo/gists{/gist_id}","starred_url":"https://api.github.com/users/jmondo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmondo/subscriptions","organizations_url":"https://api.github.com/users/jmondo/orgs","repos_url":"https://api.github.com/users/jmondo/repos","events_url":"https://api.github.com/users/jmondo/events{/privacy}","received_events_url":"https://api.github.com/users/jmondo/received_events","type":"User","site_admin":false},"body":"Resolves #1626. It allows passing `--exclude_pattern` to `rspec` on the command line.\r\n\r\nAfaik we still can't use the power of rake tasks. This is because the rake task still uses `FileList` to include files. And once files are included, they can't be changed by passing `--pattern` or `--exclude-pattern` (there is a warning about this when you try). Fortunately, once #1589 is merged, it will be possible to pass  `--exclude-pattern` within `rspec_opts` in the rake task config.  This is because the rake task's `pattern` option will use `--pattern` which can be combined with `--exclude-pattern` for a one-two punch.\r\n\r\n@myronmarston Let me know how this looks! Sorry it took so long.","created_at":"2014-07-28T01:13:57Z","updated_at":"2014-07-28T01:13:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rspec/rspec-core/pulls/1651/commits","review_comments_url":"https://api.github.com/repos/rspec/rspec-core/pulls/1651/comments","review_comment_url":"https://api.github.com/repos/rspec/rspec-core/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rspec/rspec-core/issues/1651/comments","statuses_url":"https://api.github.com/repos/rspec/rspec-core/statuses/4446adb0448d604aaf151039d30dcd92ecc58476","head":{"label":"jmondo:exclude-pattern","ref":"exclude-pattern","sha":"4446adb0448d604aaf151039d30dcd92ecc58476","user":{"login":"jmondo","id":603431,"avatar_url":"https://avatars.githubusercontent.com/u/603431?","gravatar_id":"dd1d3ca31630dab34933c1af8ed1a9d4","url":"https://api.github.com/users/jmondo","html_url":"https://github.com/jmondo","followers_url":"https://api.github.com/users/jmondo/followers","following_url":"https://api.github.com/users/jmondo/following{/other_user}","gists_url":"https://api.github.com/users/jmondo/gists{/gist_id}","starred_url":"https://api.github.com/users/jmondo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmondo/subscriptions","organizations_url":"https://api.github.com/users/jmondo/orgs","repos_url":"https://api.github.com/users/jmondo/repos","events_url":"https://api.github.com/users/jmondo/events{/privacy}","received_events_url":"https://api.github.com/users/jmondo/received_events","type":"User","site_admin":false},"repo":{"id":22326639,"name":"rspec-core","full_name":"jmondo/rspec-core","owner":{"login":"jmondo","id":603431,"avatar_url":"https://avatars.githubusercontent.com/u/603431?","gravatar_id":"dd1d3ca31630dab34933c1af8ed1a9d4","url":"https://api.github.com/users/jmondo","html_url":"https://github.com/jmondo","followers_url":"https://api.github.com/users/jmondo/followers","following_url":"https://api.github.com/users/jmondo/following{/other_user}","gists_url":"https://api.github.com/users/jmondo/gists{/gist_id}","starred_url":"https://api.github.com/users/jmondo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmondo/subscriptions","organizations_url":"https://api.github.com/users/jmondo/orgs","repos_url":"https://api.github.com/users/jmondo/repos","events_url":"https://api.github.com/users/jmondo/events{/privacy}","received_events_url":"https://api.github.com/users/jmondo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmondo/rspec-core","description":"RSpec runner and formatters","fork":true,"url":"https://api.github.com/repos/jmondo/rspec-core","forks_url":"https://api.github.com/repos/jmondo/rspec-core/forks","keys_url":"https://api.github.com/repos/jmondo/rspec-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmondo/rspec-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmondo/rspec-core/teams","hooks_url":"https://api.github.com/repos/jmondo/rspec-core/hooks","issue_events_url":"https://api.github.com/repos/jmondo/rspec-core/issues/events{/number}","events_url":"https://api.github.com/repos/jmondo/rspec-core/events","assignees_url":"https://api.github.com/repos/jmondo/rspec-core/assignees{/user}","branches_url":"https://api.github.com/repos/jmondo/rspec-core/branches{/branch}","tags_url":"https://api.github.com/repos/jmondo/rspec-core/tags","blobs_url":"https://api.github.com/repos/jmondo/rspec-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmondo/rspec-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmondo/rspec-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmondo/rspec-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmondo/rspec-core/statuses/{sha}","languages_url":"https://api.github.com/repos/jmondo/rspec-core/languages","stargazers_url":"https://api.github.com/repos/jmondo/rspec-core/stargazers","contributors_url":"https://api.github.com/repos/jmondo/rspec-core/contributors","subscribers_url":"https://api.github.com/repos/jmondo/rspec-core/subscribers","subscription_url":"https://api.github.com/repos/jmondo/rspec-core/subscription","commits_url":"https://api.github.com/repos/jmondo/rspec-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmondo/rspec-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmondo/rspec-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmondo/rspec-core/issues/comments/{number}","contents_url":"https://api.github.com/repos/jmondo/rspec-core/contents/{+path}","compare_url":"https://api.github.com/repos/jmondo/rspec-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmondo/rspec-core/merges","archive_url":"https://api.github.com/repos/jmondo/rspec-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmondo/rspec-core/downloads","issues_url":"https://api.github.com/repos/jmondo/rspec-core/issues{/number}","pulls_url":"https://api.github.com/repos/jmondo/rspec-core/pulls{/number}","milestones_url":"https://api.github.com/repos/jmondo/rspec-core/milestones{/number}","notifications_url":"https://api.github.com/repos/jmondo/rspec-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmondo/rspec-core/labels{/name}","releases_url":"https://api.github.com/repos/jmondo/rspec-core/releases{/id}","created_at":"2014-07-28T01:00:23Z","updated_at":"2014-07-24T18:55:56Z","pushed_at":"2014-07-28T01:01:33Z","git_url":"git://github.com/jmondo/rspec-core.git","ssh_url":"git@github.com:jmondo/rspec-core.git","clone_url":"https://github.com/jmondo/rspec-core.git","svn_url":"https://github.com/jmondo/rspec-core","homepage":"http://relishapp.com/rspec/rspec-core","size":25543,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":false,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rspec:master","ref":"master","sha":"e551ea039af4c0d72c09daa2f1eab4bc4151d0a3","user":{"login":"rspec","id":22388,"avatar_url":"https://avatars.githubusercontent.com/u/22388?","gravatar_id":"e482036908235889a3439104bdbc3eb9","url":"https://api.github.com/users/rspec","html_url":"https://github.com/rspec","followers_url":"https://api.github.com/users/rspec/followers","following_url":"https://api.github.com/users/rspec/following{/other_user}","gists_url":"https://api.github.com/users/rspec/gists{/gist_id}","starred_url":"https://api.github.com/users/rspec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rspec/subscriptions","organizations_url":"https://api.github.com/users/rspec/orgs","repos_url":"https://api.github.com/users/rspec/repos","events_url":"https://api.github.com/users/rspec/events{/privacy}","received_events_url":"https://api.github.com/users/rspec/received_events","type":"Organization","site_admin":false},"repo":{"id":238972,"name":"rspec-core","full_name":"rspec/rspec-core","owner":{"login":"rspec","id":22388,"avatar_url":"https://avatars.githubusercontent.com/u/22388?","gravatar_id":"e482036908235889a3439104bdbc3eb9","url":"https://api.github.com/users/rspec","html_url":"https://github.com/rspec","followers_url":"https://api.github.com/users/rspec/followers","following_url":"https://api.github.com/users/rspec/following{/other_user}","gists_url":"https://api.github.com/users/rspec/gists{/gist_id}","starred_url":"https://api.github.com/users/rspec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rspec/subscriptions","organizations_url":"https://api.github.com/users/rspec/orgs","repos_url":"https://api.github.com/users/rspec/repos","events_url":"https://api.github.com/users/rspec/events{/privacy}","received_events_url":"https://api.github.com/users/rspec/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rspec/rspec-core","description":"RSpec runner and formatters","fork":false,"url":"https://api.github.com/repos/rspec/rspec-core","forks_url":"https://api.github.com/repos/rspec/rspec-core/forks","keys_url":"https://api.github.com/repos/rspec/rspec-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rspec/rspec-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rspec/rspec-core/teams","hooks_url":"https://api.github.com/repos/rspec/rspec-core/hooks","issue_events_url":"https://api.github.com/repos/rspec/rspec-core/issues/events{/number}","events_url":"https://api.github.com/repos/rspec/rspec-core/events","assignees_url":"https://api.github.com/repos/rspec/rspec-core/assignees{/user}","branches_url":"https://api.github.com/repos/rspec/rspec-core/branches{/branch}","tags_url":"https://api.github.com/repos/rspec/rspec-core/tags","blobs_url":"https://api.github.com/repos/rspec/rspec-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rspec/rspec-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rspec/rspec-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/rspec/rspec-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rspec/rspec-core/statuses/{sha}","languages_url":"https://api.github.com/repos/rspec/rspec-core/languages","stargazers_url":"https://api.github.com/repos/rspec/rspec-core/stargazers","contributors_url":"https://api.github.com/repos/rspec/rspec-core/contributors","subscribers_url":"https://api.github.com/repos/rspec/rspec-core/subscribers","subscription_url":"https://api.github.com/repos/rspec/rspec-core/subscription","commits_url":"https://api.github.com/repos/rspec/rspec-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/rspec/rspec-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/rspec/rspec-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/rspec/rspec-core/issues/comments/{number}","contents_url":"https://api.github.com/repos/rspec/rspec-core/contents/{+path}","compare_url":"https://api.github.com/repos/rspec/rspec-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rspec/rspec-core/merges","archive_url":"https://api.github.com/repos/rspec/rspec-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rspec/rspec-core/downloads","issues_url":"https://api.github.com/repos/rspec/rspec-core/issues{/number}","pulls_url":"https://api.github.com/repos/rspec/rspec-core/pulls{/number}","milestones_url":"https://api.github.com/repos/rspec/rspec-core/milestones{/number}","notifications_url":"https://api.github.com/repos/rspec/rspec-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rspec/rspec-core/labels{/name}","releases_url":"https://api.github.com/repos/rspec/rspec-core/releases{/id}","created_at":"2009-06-29T15:41:05Z","updated_at":"2014-07-24T18:55:56Z","pushed_at":"2014-07-24T17:11:37Z","git_url":"git://github.com/rspec/rspec-core.git","ssh_url":"git@github.com:rspec/rspec-core.git","clone_url":"https://github.com/rspec/rspec-core.git","svn_url":"https://github.com/rspec/rspec-core","homepage":"http://relishapp.com/rspec/rspec-core","size":25543,"stargazers_count":608,"watchers_count":608,"language":"Ruby","has_issues":true,"has_downloads":false,"has_wiki":false,"forks_count":395,"mirror_url":null,"open_issues_count":38,"forks":395,"open_issues":38,"watchers":608,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rspec/rspec-core/pulls/1651"},"html":{"href":"https://github.com/rspec/rspec-core/pull/1651"},"issue":{"href":"https://api.github.com/repos/rspec/rspec-core/issues/1651"},"comments":{"href":"https://api.github.com/repos/rspec/rspec-core/issues/1651/comments"},"review_comments":{"href":"https://api.github.com/repos/rspec/rspec-core/pulls/1651/comments"},"review_comment":{"href":"https://api.github.com/repos/rspec/rspec-core/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rspec/rspec-core/pulls/1651/commits"},"statuses":{"href":"https://api.github.com/repos/rspec/rspec-core/statuses/4446adb0448d604aaf151039d30dcd92ecc58476"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":124,"deletions":9,"changed_files":5}}