GitHub PullRequestReviewCommentEvent at 2014-01-12 19:40:57
Repository: nette
Actor: dg
Payload: {"comment":{"url":"https://api.github.com/repos/nette/nette/pulls/comments/8814951","id":8814951,"diff_hunk":"@@ -80,8 +82,8 @@ public function getControl()\n \t\t\t\t\t$input->max = isset($input->max) ? min($input->max, $range[1]) : $range[1];\n \t\t\t\t}\n \n-\t\t\t} elseif ($rule->validator === Form::PATTERN && is_scalar($rule->arg)) {\n-\t\t\t\t$input->pattern = $rule->arg;\n+\t\t\t} elseif ($exportPattern && $rule->validator === Form::PATTERN && is_scalar($rule->arg)) {\n+\t\t\t\t$input->pattern = '^\\s*(' . $rule->arg . ')\\s*$';\n \t\t\t}","path":"Nette/Forms/Controls/TextInput.php","position":23,"original_position":23,"commit_id":"7007319f10ddf63e0d68d9927ae2b1004f6c54bc","original_commit_id":"7007319f10ddf63e0d68d9927ae2b1004f6c54bc","user":{"login":"dg","id":194960,"avatar_url":"https://gravatar.com/avatar/583bcf76466286a687368ef66a21e5cd?d=https%3A%2F%2Fidenticons.github.com%2Fb36ec7ce867bb525051c81856e390721.png&r=x","gravatar_id":"583bcf76466286a687368ef66a21e5cd","url":"https://api.github.com/users/dg","html_url":"https://github.com/dg","followers_url":"https://api.github.com/users/dg/followers","following_url":"https://api.github.com/users/dg/following{/other_user}","gists_url":"https://api.github.com/users/dg/gists{/gist_id}","starred_url":"https://api.github.com/users/dg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dg/subscriptions","organizations_url":"https://api.github.com/users/dg/orgs","repos_url":"https://api.github.com/users/dg/repos","events_url":"https://api.github.com/users/dg/events{/privacy}","received_events_url":"https://api.github.com/users/dg/received_events","type":"User","site_admin":false},"body":"^ and $ is not needed. http://www.whatwg.org/specs/web-apps/current-work/multipage/common-input-element-attributes.html#the-pattern-attribute\r\n\r\n","created_at":"2014-01-12T19:40:57Z","updated_at":"2014-01-12T19:40:57Z","html_url":"https://github.com/nette/nette/pull/1349#discussion_r8814951","pull_request_url":"https://api.github.com/repos/nette/nette/pulls/1349","_links":{"self":{"href":"https://api.github.com/repos/nette/nette/pulls/comments/8814951"},"html":{"href":"https://github.com/nette/nette/pull/1349#discussion_r8814951"},"pull_request":{"href":"https://api.github.com/repos/nette/nette/pulls/1349"}}}}