GitHub PullRequestReviewCommentEvent at 2014-08-06 11:38:19
Repository: performanceplatform-client
Actor: tombooth
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/performanceplatform-client/pulls/comments/15868340","id":15868340,"diff_hunk":"@@ -44,7 +44,8 @@ def _get(self, path):\n         url = '{0}{1}'.format(self.url, path)\n         headers = {\n             'Authorization': 'Bearer {0}'.format(self.token),\n-            'Accept': 'application/json'\n+            'Accept': 'application/json',\n+            'User-Agent': 'Performance Platform Client',","path":"performanceplatform/client/admin.py","position":6,"original_position":6,"commit_id":"fb7cc6a82a0416f18ef5623479528c1f95644ef0","original_commit_id":"fb7cc6a82a0416f18ef5623479528c1f95644ef0","user":{"login":"tombooth","id":108382,"avatar_url":"https://avatars.githubusercontent.com/u/108382?v=2","gravatar_id":"0d5db21120a408c4c5dbd3ec1e1b55f0","url":"https://api.github.com/users/tombooth","html_url":"https://github.com/tombooth","followers_url":"https://api.github.com/users/tombooth/followers","following_url":"https://api.github.com/users/tombooth/following{/other_user}","gists_url":"https://api.github.com/users/tombooth/gists{/gist_id}","starred_url":"https://api.github.com/users/tombooth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tombooth/subscriptions","organizations_url":"https://api.github.com/users/tombooth/orgs","repos_url":"https://api.github.com/users/tombooth/repos","events_url":"https://api.github.com/users/tombooth/events{/privacy}","received_events_url":"https://api.github.com/users/tombooth/received_events","type":"User","site_admin":false},"body":"Do we not do the __init__.py with version and name var in it because it\r\nneeds to be ready by the publish job? If so could we not just grep it out?\r\n\r\n\r\nOn 6 August 2014 12:33, Rob Young <notifications@github.com> wrote:\r\n\r\n> In performanceplatform/client/admin.py:\r\n>\r\n> > @@ -44,7 +44,8 @@ def _get(self, path):\r\n> >          url = '{0}{1}'.format(self.url, path)\r\n> >          headers = {\r\n> >              'Authorization': 'Bearer {0}'.format(self.token),\r\n> > -            'Accept': 'application/json'\r\n> > +            'Accept': 'application/json',\r\n> > +            'User-Agent': 'Performance Platform Client',\r\n>\r\n> Yes, but not easily, we don't have the version anywhere accessible to the\r\n> package at the moment. Using something like\r\n> https://github.com/pwaller/__autoversion__ could be a good option.\r\n>\r\n> —\r\n> Reply to this email directly or view it on GitHub\r\n> <https://github.com/alphagov/performanceplatform-client/pull/23/files#r15868200>\r\n> .\r\n>","created_at":"2014-08-06T11:38:19Z","updated_at":"2014-08-06T11:38:19Z","html_url":"https://github.com/alphagov/performanceplatform-client/pull/23#discussion_r15868340","pull_request_url":"https://api.github.com/repos/alphagov/performanceplatform-client/pulls/23","_links":{"self":{"href":"https://api.github.com/repos/alphagov/performanceplatform-client/pulls/comments/15868340"},"html":{"href":"https://github.com/alphagov/performanceplatform-client/pull/23#discussion_r15868340"},"pull_request":{"href":"https://api.github.com/repos/alphagov/performanceplatform-client/pulls/23"}}},"pull_request":{"url":"https://api.github.com/repos/alphagov/performanceplatform-client/pulls/23","id":19354446,"html_url":"https://github.com/alphagov/performanceplatform-client/pull/23","diff_url":"https://github.com/alphagov/performanceplatform-client/pull/23.diff","patch_url":"https://github.com/alphagov/performanceplatform-client/pull/23.patch","issue_url":"https://api.github.com/repos/alphagov/performanceplatform-client/issues/23","number":23,"state":"open","title":"Set a custom user agent string","user":{"login":"robyoung","id":14287,"avatar_url":"https://avatars.githubusercontent.com/u/14287?v=2","gravatar_id":"09cbeba69993bb82b3fc7b70926dfc4c","url":"https://api.github.com/users/robyoung","html_url":"https://github.com/robyoung","followers_url":"https://api.github.com/users/robyoung/followers","following_url":"https://api.github.com/users/robyoung/following{/other_user}","gists_url":"https://api.github.com/users/robyoung/gists{/gist_id}","starred_url":"https://api.github.com/users/robyoung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robyoung/subscriptions","organizations_url":"https://api.github.com/users/robyoung/orgs","repos_url":"https://api.github.com/users/robyoung/repos","events_url":"https://api.github.com/users/robyoung/events{/privacy}","received_events_url":"https://api.github.com/users/robyoung/received_events","type":"User","site_admin":false},"body":"This makes it easier to spot requests from the client. It would be nice\r\nto extend this with the ability for the user of this client to set their\r\nown extension to this user agent.","created_at":"2014-08-05T16:53:06Z","updated_at":"2014-08-06T11:38:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d5232250c312677aed8300d0414165cfdff1e2af","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/performanceplatform-client/pulls/23/commits","review_comments_url":"https://api.github.com/repos/alphagov/performanceplatform-client/pulls/23/comments","review_comment_url":"https://api.github.com/repos/alphagov/performanceplatform-client/pulls/comments/{number}","comments_url":"https://api.github.com/repos/alphagov/performanceplatform-client/issues/23/comments","statuses_url":"https://api.github.com/repos/alphagov/performanceplatform-client/statuses/fb7cc6a82a0416f18ef5623479528c1f95644ef0","head":{"label":"alphagov:add-user-agent","ref":"add-user-agent","sha":"fb7cc6a82a0416f18ef5623479528c1f95644ef0","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=2","gravatar_id":"5618b843830194a2475a6e48823f7455","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":21127949,"name":"performanceplatform-client","full_name":"alphagov/performanceplatform-client","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=2","gravatar_id":"5618b843830194a2475a6e48823f7455","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/performanceplatform-client","description":"A Python client library for writing to the Performance Platform API","fork":false,"url":"https://api.github.com/repos/alphagov/performanceplatform-client","forks_url":"https://api.github.com/repos/alphagov/performanceplatform-client/forks","keys_url":"https://api.github.com/repos/alphagov/performanceplatform-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/performanceplatform-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/performanceplatform-client/teams","hooks_url":"https://api.github.com/repos/alphagov/performanceplatform-client/hooks","issue_events_url":"https://api.github.com/repos/alphagov/performanceplatform-client/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/performanceplatform-client/events","assignees_url":"https://api.github.com/repos/alphagov/performanceplatform-client/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/performanceplatform-client/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/performanceplatform-client/tags","blobs_url":"https://api.github.com/repos/alphagov/performanceplatform-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/performanceplatform-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/performanceplatform-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/performanceplatform-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/performanceplatform-client/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/performanceplatform-client/languages","stargazers_url":"https://api.github.com/repos/alphagov/performanceplatform-client/stargazers","contributors_url":"https://api.github.com/repos/alphagov/performanceplatform-client/contributors","subscribers_url":"https://api.github.com/repos/alphagov/performanceplatform-client/subscribers","subscription_url":"https://api.github.com/repos/alphagov/performanceplatform-client/subscription","commits_url":"https://api.github.com/repos/alphagov/performanceplatform-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/performanceplatform-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/performanceplatform-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/performanceplatform-client/issues/comments/{number}","contents_url":"https://api.github.com/repos/alphagov/performanceplatform-client/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/performanceplatform-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/performanceplatform-client/merges","archive_url":"https://api.github.com/repos/alphagov/performanceplatform-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/performanceplatform-client/downloads","issues_url":"https://api.github.com/repos/alphagov/performanceplatform-client/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/performanceplatform-client/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/performanceplatform-client/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/performanceplatform-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/performanceplatform-client/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/performanceplatform-client/releases{/id}","created_at":"2014-06-23T13:50:57Z","updated_at":"2014-07-17T11:05:56Z","pushed_at":"2014-08-06T10:26:45Z","git_url":"git://github.com/alphagov/performanceplatform-client.git","ssh_url":"git@github.com:alphagov/performanceplatform-client.git","clone_url":"https://github.com/alphagov/performanceplatform-client.git","svn_url":"https://github.com/alphagov/performanceplatform-client","homepage":"","size":1084,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"795aa32a79a41bd63f363b0d1efc97cfa88a3b99","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=2","gravatar_id":"5618b843830194a2475a6e48823f7455","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":21127949,"name":"performanceplatform-client","full_name":"alphagov/performanceplatform-client","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=2","gravatar_id":"5618b843830194a2475a6e48823f7455","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/performanceplatform-client","description":"A Python client library for writing to the Performance Platform API","fork":false,"url":"https://api.github.com/repos/alphagov/performanceplatform-client","forks_url":"https://api.github.com/repos/alphagov/performanceplatform-client/forks","keys_url":"https://api.github.com/repos/alphagov/performanceplatform-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/performanceplatform-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/performanceplatform-client/teams","hooks_url":"https://api.github.com/repos/alphagov/performanceplatform-client/hooks","issue_events_url":"https://api.github.com/repos/alphagov/performanceplatform-client/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/performanceplatform-client/events","assignees_url":"https://api.github.com/repos/alphagov/performanceplatform-client/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/performanceplatform-client/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/performanceplatform-client/tags","blobs_url":"https://api.github.com/repos/alphagov/performanceplatform-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/performanceplatform-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/performanceplatform-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/performanceplatform-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/performanceplatform-client/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/performanceplatform-client/languages","stargazers_url":"https://api.github.com/repos/alphagov/performanceplatform-client/stargazers","contributors_url":"https://api.github.com/repos/alphagov/performanceplatform-client/contributors","subscribers_url":"https://api.github.com/repos/alphagov/performanceplatform-client/subscribers","subscription_url":"https://api.github.com/repos/alphagov/performanceplatform-client/subscription","commits_url":"https://api.github.com/repos/alphagov/performanceplatform-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/performanceplatform-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/performanceplatform-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/performanceplatform-client/issues/comments/{number}","contents_url":"https://api.github.com/repos/alphagov/performanceplatform-client/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/performanceplatform-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/performanceplatform-client/merges","archive_url":"https://api.github.com/repos/alphagov/performanceplatform-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/performanceplatform-client/downloads","issues_url":"https://api.github.com/repos/alphagov/performanceplatform-client/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/performanceplatform-client/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/performanceplatform-client/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/performanceplatform-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/performanceplatform-client/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/performanceplatform-client/releases{/id}","created_at":"2014-06-23T13:50:57Z","updated_at":"2014-07-17T11:05:56Z","pushed_at":"2014-08-06T10:26:45Z","git_url":"git://github.com/alphagov/performanceplatform-client.git","ssh_url":"git@github.com:alphagov/performanceplatform-client.git","clone_url":"https://github.com/alphagov/performanceplatform-client.git","svn_url":"https://github.com/alphagov/performanceplatform-client","homepage":"","size":1084,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/performanceplatform-client/pulls/23"},"html":{"href":"https://github.com/alphagov/performanceplatform-client/pull/23"},"issue":{"href":"https://api.github.com/repos/alphagov/performanceplatform-client/issues/23"},"comments":{"href":"https://api.github.com/repos/alphagov/performanceplatform-client/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/performanceplatform-client/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/performanceplatform-client/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/alphagov/performanceplatform-client/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/performanceplatform-client/statuses/fb7cc6a82a0416f18ef5623479528c1f95644ef0"}}}}