GitHub PullRequestReviewCommentEvent at 2014-01-14 14:26:52
Repository: opam
Actor: samoht
Payload: {"comment":{"url":"https://api.github.com/repos/ocaml/opam/pulls/comments/8860704","id":8860704,"diff_hunk":"@@ -97,6 +97,20 @@ let guess_repository_kind kind (address, ext) =\n       else\n         `http\n \n+let guess_repository_kind_urls kind urls =\n+  match kind with\n+  | Some k -> k\n+  | None   -> match urls with\n+    | url::r ->\n+      let k = guess_repository_kind kind url in\n+      if not (List.for_all (fun url -> guess_repository_kind kind url = k) r)\n+      then\n+        OpamGlobals.warning \"Inconsistent addess kinds in %s\"","path":"src/core/opamTypes.ml","position":12,"original_position":12,"commit_id":"543a90e984691ec5bcd31d9f6b17f656f9871aa0","original_commit_id":"543a90e984691ec5bcd31d9f6b17f656f9871aa0","user":{"login":"samoht","id":103693,"avatar_url":"https://gravatar.com/avatar/698b0d9fd426ffed3d4306051c4f66d5?d=https%3A%2F%2Fidenticons.github.com%2F6a9c990c97824c288f1f91fdb703e57d.png&r=x","gravatar_id":"698b0d9fd426ffed3d4306051c4f66d5","url":"https://api.github.com/users/samoht","html_url":"https://github.com/samoht","followers_url":"https://api.github.com/users/samoht/followers","following_url":"https://api.github.com/users/samoht/following{/other_user}","gists_url":"https://api.github.com/users/samoht/gists{/gist_id}","starred_url":"https://api.github.com/users/samoht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samoht/subscriptions","organizations_url":"https://api.github.com/users/samoht/orgs","repos_url":"https://api.github.com/users/samoht/repos","events_url":"https://api.github.com/users/samoht/events{/privacy}","received_events_url":"https://api.github.com/users/samoht/received_events","type":"User","site_admin":false},"body":"typo","created_at":"2014-01-14T14:26:52Z","updated_at":"2014-01-14T14:26:52Z","html_url":"https://github.com/ocaml/opam/pull/1089#discussion_r8860704","pull_request_url":"https://api.github.com/repos/ocaml/opam/pulls/1089","_links":{"self":{"href":"https://api.github.com/repos/ocaml/opam/pulls/comments/8860704"},"html":{"href":"https://github.com/ocaml/opam/pull/1089#discussion_r8860704"},"pull_request":{"href":"https://api.github.com/repos/ocaml/opam/pulls/1089"}}}}