GitHub PullRequestReviewCommentEvent at 2014-11-18 12:44:38
Repository: cmssw
Actor: violatingcp
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/20502570","id":20502570,"diff_hunk":"@@ -5,9 +5,13 @@\n \n #include \"DataFormats/HcalDetId/interface/HcalDetId.h\"\n #include \"CalibCalorimetry/HcalAlgos/interface/HcalPulseShapes.h\"\n+#include \"CalibCalorimetry/HcalAlgos/interface/HcalTimeSlew.h\"\n #include \"CalibFormats/HcalObjects/interface/HcalCoder.h\"\n #include \"CalibFormats/HcalObjects/interface/HcalCalibrations.h\"\n \n+#include \"TFile.h\"\n+#include \"TTree.h\"\n+\n #include <TMinuit.h>","path":"RecoLocalCalo/HcalRecAlgos/interface/PulseShapeFitOOTPileupCorrection.h","position":11,"original_position":11,"commit_id":"200e23aac668f44122c95409cba2cc24b8c833a2","original_commit_id":"200e23aac668f44122c95409cba2cc24b8c833a2","user":{"login":"violatingcp","id":5166561,"avatar_url":"https://avatars.githubusercontent.com/u/5166561?v=3","gravatar_id":"","url":"https://api.github.com/users/violatingcp","html_url":"https://github.com/violatingcp","followers_url":"https://api.github.com/users/violatingcp/followers","following_url":"https://api.github.com/users/violatingcp/following{/other_user}","gists_url":"https://api.github.com/users/violatingcp/gists{/gist_id}","starred_url":"https://api.github.com/users/violatingcp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/violatingcp/subscriptions","organizations_url":"https://api.github.com/users/violatingcp/orgs","repos_url":"https://api.github.com/users/violatingcp/repos","events_url":"https://api.github.com/users/violatingcp/events{/privacy}","received_events_url":"https://api.github.com/users/violatingcp/received_events","type":"User","site_admin":false},"body":"Get rid of them.  That is left over from debug.\r\n\r\nPhil\r\n\r\nOn Tue, Nov 18, 2014 at 1:21 PM, David Lange <notifications@github.com>\r\nwrote:\r\n\r\n> In RecoLocalCalo/HcalRecAlgos/interface/PulseShapeFitOOTPileupCorrection.h:\r\n>\r\n> >  #include \"CalibFormats/HcalObjects/interface/HcalCoder.h\"\r\n> >  #include \"CalibFormats/HcalObjects/interface/HcalCalibrations.h\"\r\n> >\r\n> > +#include \"TFile.h\"\r\n> > +#include \"TTree.h\"\r\n> > +\r\n> >  #include <TMinuit.h>\r\n>\r\n> both the TFile and TTree includes appear to be unneeded (which is good)\r\n>\r\n> —\r\n> Reply to this email directly or view it on GitHub\r\n> <https://github.com/cms-sw/cmssw/pull/6432/files#r20501613>.\r\n>","created_at":"2014-11-18T12:44:38Z","updated_at":"2014-11-18T12:44:38Z","html_url":"https://github.com/cms-sw/cmssw/pull/6432#discussion_r20502570","pull_request_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/6432","_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/20502570"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/6432#discussion_r20502570"},"pull_request":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/6432"}}},"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/6432","id":24504601,"html_url":"https://github.com/cms-sw/cmssw/pull/6432","diff_url":"https://github.com/cms-sw/cmssw/pull/6432.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/6432.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/6432","number":6432,"state":"open","locked":false,"title":"Hcal 25ns constrained Method 2 for pre3","user":{"login":"lihux25","id":5289967,"avatar_url":"https://avatars.githubusercontent.com/u/5289967?v=3","gravatar_id":"","url":"https://api.github.com/users/lihux25","html_url":"https://github.com/lihux25","followers_url":"https://api.github.com/users/lihux25/followers","following_url":"https://api.github.com/users/lihux25/following{/other_user}","gists_url":"https://api.github.com/users/lihux25/gists{/gist_id}","starred_url":"https://api.github.com/users/lihux25/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lihux25/subscriptions","organizations_url":"https://api.github.com/users/lihux25/orgs","repos_url":"https://api.github.com/users/lihux25/repos","events_url":"https://api.github.com/users/lihux25/events{/privacy}","received_events_url":"https://api.github.com/users/lihux25/received_events","type":"User","site_admin":false},"body":"Update on Nov 17th 17:30PM (Chicago time)\r\n] Incorporate comments from Stoyan\r\n] Switch from 3 iterations of the fit to 1 iteration by default\r\n] Fix two problems reported from static analyzer\r\n\r\n==\r\n1. Fix the pulse shape used for MC to be number 105\r\n2. If method 2 fails (nan issue) or not used (e.g., tstrig < ts4Min), it falls back now to Method 0\r\n3. Add an option to control number of fit iterations\r\n4. Separate out the hbheNegativeFlagSetter from the puCorrMethod switch. It was switched off when Method 1 was disabled. This hbheNegaviteFlagSetter is controlled by setNegativeFlags_ anyway.\r\n5. Add print out to what method is actually activated","created_at":"2014-11-16T17:50:56Z","updated_at":"2014-11-18T12:44:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"54730096b63d43b1e46283b480889fdbf319a394","assignee":null,"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/49","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/49/labels","id":791225,"number":49,"title":"Next CMSSW_7_3_X","description":"","creator":{"login":"ktf","id":10544,"avatar_url":"https://avatars.githubusercontent.com/u/10544?v=3","gravatar_id":"","url":"https://api.github.com/users/ktf","html_url":"https://github.com/ktf","followers_url":"https://api.github.com/users/ktf/followers","following_url":"https://api.github.com/users/ktf/following{/other_user}","gists_url":"https://api.github.com/users/ktf/gists{/gist_id}","starred_url":"https://api.github.com/users/ktf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktf/subscriptions","organizations_url":"https://api.github.com/users/ktf/orgs","repos_url":"https://api.github.com/users/ktf/repos","events_url":"https://api.github.com/users/ktf/events{/privacy}","received_events_url":"https://api.github.com/users/ktf/received_events","type":"User","site_admin":false},"open_issues":36,"closed_issues":597,"state":"open","created_at":"2014-09-16T07:39:32Z","updated_at":"2014-11-18T12:08:43Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/6432/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/6432/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/{number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/6432/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/200e23aac668f44122c95409cba2cc24b8c833a2","head":{"label":"lihux25:forpre3_Hcal25nsConstrained","ref":"forpre3_Hcal25nsConstrained","sha":"200e23aac668f44122c95409cba2cc24b8c833a2","user":{"login":"lihux25","id":5289967,"avatar_url":"https://avatars.githubusercontent.com/u/5289967?v=3","gravatar_id":"","url":"https://api.github.com/users/lihux25","html_url":"https://github.com/lihux25","followers_url":"https://api.github.com/users/lihux25/followers","following_url":"https://api.github.com/users/lihux25/following{/other_user}","gists_url":"https://api.github.com/users/lihux25/gists{/gist_id}","starred_url":"https://api.github.com/users/lihux25/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lihux25/subscriptions","organizations_url":"https://api.github.com/users/lihux25/orgs","repos_url":"https://api.github.com/users/lihux25/repos","events_url":"https://api.github.com/users/lihux25/events{/privacy}","received_events_url":"https://api.github.com/users/lihux25/received_events","type":"User","site_admin":false},"repo":{"id":18712864,"name":"cmssw","full_name":"lihux25/cmssw","owner":{"login":"lihux25","id":5289967,"avatar_url":"https://avatars.githubusercontent.com/u/5289967?v=3","gravatar_id":"","url":"https://api.github.com/users/lihux25","html_url":"https://github.com/lihux25","followers_url":"https://api.github.com/users/lihux25/followers","following_url":"https://api.github.com/users/lihux25/following{/other_user}","gists_url":"https://api.github.com/users/lihux25/gists{/gist_id}","starred_url":"https://api.github.com/users/lihux25/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lihux25/subscriptions","organizations_url":"https://api.github.com/users/lihux25/orgs","repos_url":"https://api.github.com/users/lihux25/repos","events_url":"https://api.github.com/users/lihux25/events{/privacy}","received_events_url":"https://api.github.com/users/lihux25/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lihux25/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/lihux25/cmssw","forks_url":"https://api.github.com/repos/lihux25/cmssw/forks","keys_url":"https://api.github.com/repos/lihux25/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lihux25/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lihux25/cmssw/teams","hooks_url":"https://api.github.com/repos/lihux25/cmssw/hooks","issue_events_url":"https://api.github.com/repos/lihux25/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/lihux25/cmssw/events","assignees_url":"https://api.github.com/repos/lihux25/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/lihux25/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/lihux25/cmssw/tags","blobs_url":"https://api.github.com/repos/lihux25/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lihux25/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lihux25/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/lihux25/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lihux25/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/lihux25/cmssw/languages","stargazers_url":"https://api.github.com/repos/lihux25/cmssw/stargazers","contributors_url":"https://api.github.com/repos/lihux25/cmssw/contributors","subscribers_url":"https://api.github.com/repos/lihux25/cmssw/subscribers","subscription_url":"https://api.github.com/repos/lihux25/cmssw/subscription","commits_url":"https://api.github.com/repos/lihux25/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/lihux25/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/lihux25/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/lihux25/cmssw/issues/comments/{number}","contents_url":"https://api.github.com/repos/lihux25/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/lihux25/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lihux25/cmssw/merges","archive_url":"https://api.github.com/repos/lihux25/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lihux25/cmssw/downloads","issues_url":"https://api.github.com/repos/lihux25/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/lihux25/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/lihux25/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/lihux25/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lihux25/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/lihux25/cmssw/releases{/id}","created_at":"2014-04-12T19:39:27Z","updated_at":"2014-05-31T21:57:13Z","pushed_at":"2014-11-17T23:20:54Z","git_url":"git://github.com/lihux25/cmssw.git","ssh_url":"git@github.com:lihux25/cmssw.git","clone_url":"https://github.com/lihux25/cmssw.git","svn_url":"https://github.com/lihux25/cmssw","homepage":"cms-sw.github.io/cmssw","size":599211,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"CMSSW_7_1_X"}},"base":{"label":"cms-sw:CMSSW_7_3_X","ref":"CMSSW_7_3_X","sha":"cc9739526f4d76d90226098314d344b3329eba0a","user":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"name":"cmssw","full_name":"cms-sw/cmssw","owner":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/{number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","created_at":"2013-06-26T14:09:07Z","updated_at":"2014-11-18T12:08:44Z","pushed_at":"2014-11-18T12:10:05Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"cms-sw.github.io/cmssw","size":808682,"stargazers_count":191,"watchers_count":191,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1127,"mirror_url":null,"open_issues_count":125,"forks":1127,"open_issues":125,"watchers":191,"default_branch":"CMSSW_7_3_X"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/6432"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/6432"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/6432"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/6432/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/6432/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/6432/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/200e23aac668f44122c95409cba2cc24b8c833a2"}}}}