GitHub PullRequestEvent at 2014-05-13 19:40:01
Repository: node-soap
Actor: vhwang
Payload: {"action":"opened","number":349,"pull_request":{"url":"https://api.github.com/repos/vpulim/node-soap/pulls/349","id":15842654,"html_url":"https://github.com/vpulim/node-soap/pull/349","diff_url":"https://github.com/vpulim/node-soap/pull/349.diff","patch_url":"https://github.com/vpulim/node-soap/pull/349.patch","issue_url":"https://api.github.com/repos/vpulim/node-soap/issues/349","number":349,"state":"open","title":"Fix for adding an undefined XML namespace to the generated XML's child x...","user":{"login":"vhwang","id":1534890,"avatar_url":"https://avatars.githubusercontent.com/u/1534890?","gravatar_id":"20f8742dd8d9205ce814387a735a7992","url":"https://api.github.com/users/vhwang","html_url":"https://github.com/vhwang","followers_url":"https://api.github.com/users/vhwang/followers","following_url":"https://api.github.com/users/vhwang/following{/other_user}","gists_url":"https://api.github.com/users/vhwang/gists{/gist_id}","starred_url":"https://api.github.com/users/vhwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vhwang/subscriptions","organizations_url":"https://api.github.com/users/vhwang/orgs","repos_url":"https://api.github.com/users/vhwang/repos","events_url":"https://api.github.com/users/vhwang/events{/privacy}","received_events_url":"https://api.github.com/users/vhwang/received_events","type":"User","site_admin":false},"body":"...mlns attribute.\r\n\r\nConverting a JSON object into XML was adding an undefined XML namespace attribute to a child element.    This change checks if the childXmlns is defined before allowing the childXmlnsAttribute to be created.  If the chidlXmlns is not defined then no xmlns is added to the child.\r\n\r\nFor example the following JSON object would generate this XML:\r\n```\r\n    var args = \"Operation\": {\r\n                \"CreateUser\": {\r\n                    \"User\": {\r\n                        \"A\": aVar,\r\n                        \"B\": bVar,\r\n                        \"C\": cVar,\r\n                        \"D\": dVar,\r\n                        \"E\": eVar,\r\n                        \"F\": fVar\r\n                    },\r\n                    \"G\":\"\"\r\n                }\r\n            }\r\n     client.admin(args, function(err, result) {};\r\n```\r\n  Created XML with undefined xmlns in child XML Attribute:\r\n```\r\n<soap:Envelope xmlns:soap=\"http://schemas.xmlsoap.org/soap/envelope/\" xmlns:typens=\"http://schemas.abc.com/abc11\" xmlns:wsdlns=\"http://schemas.abc.com/abc11/wsdl\" xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\">\r\n\t<soap:Header/>\r\n\t<soap:Body>\r\n\t\t<typens:Admin xmlns=\"http://schemas.abc.com/abc11\" xmlns:typens=\"http://schemas.abc.com/abc\">\r\n\t\t\t<typens:Operation>\r\n\t\t\t\t<typens:CreateUser xmlns:typens=\"undefined\">\r\n\t\t\t\t\t<typens:User>\r\n\t\t\t\t\t\t<typens:A>aVal</typens:Name>\r\n\t\t\t\t\t\t<typens:B>bVal</typens:Password>\r\n\t\t\t\t\t\t<typens:C>cVal</typens:Description>\r\n\t\t\t\t\t\t<typens:D>dVal</typens:IsLoginDisabled>\r\n\t\t\t\t\t\t<typens:E>eVal</typens:HomeFolder>\r\n\t\t\t\t\t\t<typens:F>fVal</typens:HomeFolder>\r\n\t\t\t\t\t</typens:User>\r\n\t\t\t\t\t<typens:G/>\r\n\t\t\t\t</typens:CreateUser>\r\n\t\t\t</typens:Operation>\r\n\t\t</typens:Admin>\r\n\t</soap:Body>\r\n</soap:Envelope>\r\n```\r\n\r\nExpected XML / XML generated with this change:\r\n```\r\n<soap:Envelope xmlns:soap=\"http://schemas.xmlsoap.org/soap/envelope/\" xmlns:typens=\"http://schemas.abc.com/abc11\" xmlns:wsdlns=\"http://schemas.abc.com/abc11/wsdl\" xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\">\r\n\t<soap:Header/>\r\n\t<soap:Body>\r\n\t\t<typens:Admin xmlns=\"http://schemas.abc.com/abc11\" xmlns:typens=\"http://schemas.abc.com/abc\">\r\n\t\t\t<typens:Operation>\r\n\t\t\t\t<typens:CreateUser>\r\n\t\t\t\t\t<typens:User>\r\n\t\t\t\t\t\t<typens:A>aVal</typens:Name>\r\n\t\t\t\t\t\t<typens:B>bVal</typens:Password>\r\n\t\t\t\t\t\t<typens:C>cVal</typens:Description>\r\n\t\t\t\t\t\t<typens:D>dVal</typens:IsLoginDisabled>\r\n\t\t\t\t\t\t<typens:E>eVal</typens:HomeFolder>\r\n\t\t\t\t\t\t<typens:F>fVal</typens:HomeFolder>\r\n\t\t\t\t\t</typens:User>\r\n\t\t\t\t\t<typens:G/>\r\n\t\t\t\t</typens:CreateUser>\r\n\t\t\t</typens:Operation>\r\n\t\t</typens:Admin>\r\n\t</soap:Body>\r\n</soap:Envelope>\r\n```","created_at":"2014-05-13T19:40:01Z","updated_at":"2014-05-13T19:40:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/vpulim/node-soap/pulls/349/commits","review_comments_url":"https://api.github.com/repos/vpulim/node-soap/pulls/349/comments","review_comment_url":"https://api.github.com/repos/vpulim/node-soap/pulls/comments/{number}","comments_url":"https://api.github.com/repos/vpulim/node-soap/issues/349/comments","statuses_url":"https://api.github.com/repos/vpulim/node-soap/statuses/bb1e485aa37def4385599db7634b5f258937d84c","head":{"label":"vhwang:master","ref":"master","sha":"bb1e485aa37def4385599db7634b5f258937d84c","user":{"login":"vhwang","id":1534890,"avatar_url":"https://avatars.githubusercontent.com/u/1534890?","gravatar_id":"20f8742dd8d9205ce814387a735a7992","url":"https://api.github.com/users/vhwang","html_url":"https://github.com/vhwang","followers_url":"https://api.github.com/users/vhwang/followers","following_url":"https://api.github.com/users/vhwang/following{/other_user}","gists_url":"https://api.github.com/users/vhwang/gists{/gist_id}","starred_url":"https://api.github.com/users/vhwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vhwang/subscriptions","organizations_url":"https://api.github.com/users/vhwang/orgs","repos_url":"https://api.github.com/users/vhwang/repos","events_url":"https://api.github.com/users/vhwang/events{/privacy}","received_events_url":"https://api.github.com/users/vhwang/received_events","type":"User","site_admin":false},"repo":{"id":19752597,"name":"node-soap","full_name":"vhwang/node-soap","owner":{"login":"vhwang","id":1534890,"avatar_url":"https://avatars.githubusercontent.com/u/1534890?","gravatar_id":"20f8742dd8d9205ce814387a735a7992","url":"https://api.github.com/users/vhwang","html_url":"https://github.com/vhwang","followers_url":"https://api.github.com/users/vhwang/followers","following_url":"https://api.github.com/users/vhwang/following{/other_user}","gists_url":"https://api.github.com/users/vhwang/gists{/gist_id}","starred_url":"https://api.github.com/users/vhwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vhwang/subscriptions","organizations_url":"https://api.github.com/users/vhwang/orgs","repos_url":"https://api.github.com/users/vhwang/repos","events_url":"https://api.github.com/users/vhwang/events{/privacy}","received_events_url":"https://api.github.com/users/vhwang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vhwang/node-soap","description":"A SOAP client and server for node.js.","fork":true,"url":"https://api.github.com/repos/vhwang/node-soap","forks_url":"https://api.github.com/repos/vhwang/node-soap/forks","keys_url":"https://api.github.com/repos/vhwang/node-soap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vhwang/node-soap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vhwang/node-soap/teams","hooks_url":"https://api.github.com/repos/vhwang/node-soap/hooks","issue_events_url":"https://api.github.com/repos/vhwang/node-soap/issues/events{/number}","events_url":"https://api.github.com/repos/vhwang/node-soap/events","assignees_url":"https://api.github.com/repos/vhwang/node-soap/assignees{/user}","branches_url":"https://api.github.com/repos/vhwang/node-soap/branches{/branch}","tags_url":"https://api.github.com/repos/vhwang/node-soap/tags","blobs_url":"https://api.github.com/repos/vhwang/node-soap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vhwang/node-soap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vhwang/node-soap/git/refs{/sha}","trees_url":"https://api.github.com/repos/vhwang/node-soap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vhwang/node-soap/statuses/{sha}","languages_url":"https://api.github.com/repos/vhwang/node-soap/languages","stargazers_url":"https://api.github.com/repos/vhwang/node-soap/stargazers","contributors_url":"https://api.github.com/repos/vhwang/node-soap/contributors","subscribers_url":"https://api.github.com/repos/vhwang/node-soap/subscribers","subscription_url":"https://api.github.com/repos/vhwang/node-soap/subscription","commits_url":"https://api.github.com/repos/vhwang/node-soap/commits{/sha}","git_commits_url":"https://api.github.com/repos/vhwang/node-soap/git/commits{/sha}","comments_url":"https://api.github.com/repos/vhwang/node-soap/comments{/number}","issue_comment_url":"https://api.github.com/repos/vhwang/node-soap/issues/comments/{number}","contents_url":"https://api.github.com/repos/vhwang/node-soap/contents/{+path}","compare_url":"https://api.github.com/repos/vhwang/node-soap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vhwang/node-soap/merges","archive_url":"https://api.github.com/repos/vhwang/node-soap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vhwang/node-soap/downloads","issues_url":"https://api.github.com/repos/vhwang/node-soap/issues{/number}","pulls_url":"https://api.github.com/repos/vhwang/node-soap/pulls{/number}","milestones_url":"https://api.github.com/repos/vhwang/node-soap/milestones{/number}","notifications_url":"https://api.github.com/repos/vhwang/node-soap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vhwang/node-soap/labels{/name}","releases_url":"https://api.github.com/repos/vhwang/node-soap/releases{/id}","created_at":"2014-05-13T19:22:52Z","updated_at":"2014-05-13T19:40:01Z","pushed_at":"2014-05-13T19:30:24Z","git_url":"git://github.com/vhwang/node-soap.git","ssh_url":"git@github.com:vhwang/node-soap.git","clone_url":"https://github.com/vhwang/node-soap.git","svn_url":"https://github.com/vhwang/node-soap","homepage":"","size":3186,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vpulim:master","ref":"master","sha":"ff4b6c98ba01cecf6d343faa040f32fa182b4f5e","user":{"login":"vpulim","id":100092,"avatar_url":"https://avatars.githubusercontent.com/u/100092?","gravatar_id":"a5546dd17a07170257f7b2b55eabdea4","url":"https://api.github.com/users/vpulim","html_url":"https://github.com/vpulim","followers_url":"https://api.github.com/users/vpulim/followers","following_url":"https://api.github.com/users/vpulim/following{/other_user}","gists_url":"https://api.github.com/users/vpulim/gists{/gist_id}","starred_url":"https://api.github.com/users/vpulim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vpulim/subscriptions","organizations_url":"https://api.github.com/users/vpulim/orgs","repos_url":"https://api.github.com/users/vpulim/repos","events_url":"https://api.github.com/users/vpulim/events{/privacy}","received_events_url":"https://api.github.com/users/vpulim/received_events","type":"User","site_admin":false},"repo":{"id":1584707,"name":"node-soap","full_name":"vpulim/node-soap","owner":{"login":"vpulim","id":100092,"avatar_url":"https://avatars.githubusercontent.com/u/100092?","gravatar_id":"a5546dd17a07170257f7b2b55eabdea4","url":"https://api.github.com/users/vpulim","html_url":"https://github.com/vpulim","followers_url":"https://api.github.com/users/vpulim/followers","following_url":"https://api.github.com/users/vpulim/following{/other_user}","gists_url":"https://api.github.com/users/vpulim/gists{/gist_id}","starred_url":"https://api.github.com/users/vpulim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vpulim/subscriptions","organizations_url":"https://api.github.com/users/vpulim/orgs","repos_url":"https://api.github.com/users/vpulim/repos","events_url":"https://api.github.com/users/vpulim/events{/privacy}","received_events_url":"https://api.github.com/users/vpulim/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vpulim/node-soap","description":"A SOAP client and server for node.js.","fork":false,"url":"https://api.github.com/repos/vpulim/node-soap","forks_url":"https://api.github.com/repos/vpulim/node-soap/forks","keys_url":"https://api.github.com/repos/vpulim/node-soap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vpulim/node-soap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vpulim/node-soap/teams","hooks_url":"https://api.github.com/repos/vpulim/node-soap/hooks","issue_events_url":"https://api.github.com/repos/vpulim/node-soap/issues/events{/number}","events_url":"https://api.github.com/repos/vpulim/node-soap/events","assignees_url":"https://api.github.com/repos/vpulim/node-soap/assignees{/user}","branches_url":"https://api.github.com/repos/vpulim/node-soap/branches{/branch}","tags_url":"https://api.github.com/repos/vpulim/node-soap/tags","blobs_url":"https://api.github.com/repos/vpulim/node-soap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vpulim/node-soap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vpulim/node-soap/git/refs{/sha}","trees_url":"https://api.github.com/repos/vpulim/node-soap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vpulim/node-soap/statuses/{sha}","languages_url":"https://api.github.com/repos/vpulim/node-soap/languages","stargazers_url":"https://api.github.com/repos/vpulim/node-soap/stargazers","contributors_url":"https://api.github.com/repos/vpulim/node-soap/contributors","subscribers_url":"https://api.github.com/repos/vpulim/node-soap/subscribers","subscription_url":"https://api.github.com/repos/vpulim/node-soap/subscription","commits_url":"https://api.github.com/repos/vpulim/node-soap/commits{/sha}","git_commits_url":"https://api.github.com/repos/vpulim/node-soap/git/commits{/sha}","comments_url":"https://api.github.com/repos/vpulim/node-soap/comments{/number}","issue_comment_url":"https://api.github.com/repos/vpulim/node-soap/issues/comments/{number}","contents_url":"https://api.github.com/repos/vpulim/node-soap/contents/{+path}","compare_url":"https://api.github.com/repos/vpulim/node-soap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vpulim/node-soap/merges","archive_url":"https://api.github.com/repos/vpulim/node-soap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vpulim/node-soap/downloads","issues_url":"https://api.github.com/repos/vpulim/node-soap/issues{/number}","pulls_url":"https://api.github.com/repos/vpulim/node-soap/pulls{/number}","milestones_url":"https://api.github.com/repos/vpulim/node-soap/milestones{/number}","notifications_url":"https://api.github.com/repos/vpulim/node-soap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vpulim/node-soap/labels{/name}","releases_url":"https://api.github.com/repos/vpulim/node-soap/releases{/id}","created_at":"2011-04-07T22:16:49Z","updated_at":"2014-05-13T07:35:23Z","pushed_at":"2014-05-13T07:35:23Z","git_url":"git://github.com/vpulim/node-soap.git","ssh_url":"git@github.com:vpulim/node-soap.git","clone_url":"https://github.com/vpulim/node-soap.git","svn_url":"https://github.com/vpulim/node-soap","homepage":"","size":3186,"stargazers_count":492,"watchers_count":492,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":344,"mirror_url":null,"open_issues_count":107,"forks":344,"open_issues":107,"watchers":492,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vpulim/node-soap/pulls/349"},"html":{"href":"https://github.com/vpulim/node-soap/pull/349"},"issue":{"href":"https://api.github.com/repos/vpulim/node-soap/issues/349"},"comments":{"href":"https://api.github.com/repos/vpulim/node-soap/issues/349/comments"},"review_comments":{"href":"https://api.github.com/repos/vpulim/node-soap/pulls/349/comments"},"review_comment":{"href":"https://api.github.com/repos/vpulim/node-soap/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/vpulim/node-soap/pulls/349/commits"},"statuses":{"href":"https://api.github.com/repos/vpulim/node-soap/statuses/bb1e485aa37def4385599db7634b5f258937d84c"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":6,"deletions":5,"changed_files":1}}