GitHub PullRequestReviewCommentEvent at 2014-08-14 03:36:07
Repository: kd
Actor: usirin
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/koding/kd/pulls/comments/16219886","id":16219886,"diff_hunk":"@@ -1,9 +1,220 @@\n-{assert} = require 'chai'\n-KDUtils = require '../../src/core/utils'\n+{ assert } = require 'chai'\n+utils      = require '../../src/core/utils'\n \n describe 'KDUtils', ->\n \n   it 'exists', ->\n-    assert.ok(KDUtils)\n+    assert.ok(utils)\n+\n+  # Preparation function for simulating\n+  # a text selection.\n+  selectDummyElement = ->\n+    text             = document.createElement 'div'\n+    text.innerHTML   = 'dummy data'\n+    selection        = window.getSelection()\n+    range            = document.createRange()\n+\n+    document.body.appendChild text\n+\n+    range.selectNodeContents(text)\n+    selection.removeAllRanges()\n+    selection.addRange(range)\n+\n+    return text\n+\n+\n+  describe 'extend', ->\n+\n+    it 'combines objects together', ->\n+      target = {}\n+      firstSource = { a: 1, b: 2 }\n+      secondSource = { c: 3, d: 4 }\n+\n+      extended = utils.extend target, firstSource, secondSource\n+\n+      expected = { a: 1, b: 2, c: 3, d: 4 }\n+\n+      assert.deepEqual extended, expected\n+\n+\n+  describe 'dict', ->","path":"test/core/utils.test.coffee","position":43,"original_position":43,"commit_id":"fbd3932138cbecf70b7c1dd01d4a2ccf125dbcd2","original_commit_id":"fbd3932138cbecf70b7c1dd01d4a2ccf125dbcd2","user":{"login":"usirin","id":1783869,"avatar_url":"https://avatars.githubusercontent.com/u/1783869?v=2","gravatar_id":"a03ae1b1965fd35c3f763f8b651a3854","url":"https://api.github.com/users/usirin","html_url":"https://github.com/usirin","followers_url":"https://api.github.com/users/usirin/followers","following_url":"https://api.github.com/users/usirin/following{/other_user}","gists_url":"https://api.github.com/users/usirin/gists{/gist_id}","starred_url":"https://api.github.com/users/usirin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/usirin/subscriptions","organizations_url":"https://api.github.com/users/usirin/orgs","repos_url":"https://api.github.com/users/usirin/repos","events_url":"https://api.github.com/users/usirin/events{/privacy}","received_events_url":"https://api.github.com/users/usirin/received_events","type":"User","site_admin":false},"body":"I am sorry, I haven't been checking here.\r\n\r\nI am gonna add that test right away and update the code.","created_at":"2014-08-14T03:36:07Z","updated_at":"2014-08-14T03:36:07Z","html_url":"https://github.com/koding/kd/pull/58#discussion_r16219886","pull_request_url":"https://api.github.com/repos/koding/kd/pulls/58","_links":{"self":{"href":"https://api.github.com/repos/koding/kd/pulls/comments/16219886"},"html":{"href":"https://github.com/koding/kd/pull/58#discussion_r16219886"},"pull_request":{"href":"https://api.github.com/repos/koding/kd/pulls/58"}}},"pull_request":{"url":"https://api.github.com/repos/koding/kd/pulls/58","id":19571561,"html_url":"https://github.com/koding/kd/pull/58","diff_url":"https://github.com/koding/kd/pull/58.diff","patch_url":"https://github.com/koding/kd/pull/58.patch","issue_url":"https://api.github.com/repos/koding/kd/issues/58","number":58,"state":"open","locked":false,"title":"Add KD.utils tests","user":{"login":"usirin","id":1783869,"avatar_url":"https://avatars.githubusercontent.com/u/1783869?v=2","gravatar_id":"a03ae1b1965fd35c3f763f8b651a3854","url":"https://api.github.com/users/usirin","html_url":"https://github.com/usirin","followers_url":"https://api.github.com/users/usirin/followers","following_url":"https://api.github.com/users/usirin/following{/other_user}","gists_url":"https://api.github.com/users/usirin/gists{/gist_id}","starred_url":"https://api.github.com/users/usirin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/usirin/subscriptions","organizations_url":"https://api.github.com/users/usirin/orgs","repos_url":"https://api.github.com/users/usirin/repos","events_url":"https://api.github.com/users/usirin/events{/privacy}","received_events_url":"https://api.github.com/users/usirin/received_events","type":"User","site_admin":false},"body":"This PR adds tests for `KD.utils` also fixes not logging out `console.log` statements of `PhantomJS` as well.\r\n\r\n These tests not exactly finished but it covers what we need right now. I will focus on `core` + `list` components tests before those.","created_at":"2014-08-10T07:33:28Z","updated_at":"2014-08-14T03:36:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"413cb9666a1df670a84042f2d937e9b11b421c92","assignee":{"login":"sinan","id":440086,"avatar_url":"https://avatars.githubusercontent.com/u/440086?v=2","gravatar_id":"fb9edfce4f54230c890431a97db6c99e","url":"https://api.github.com/users/sinan","html_url":"https://github.com/sinan","followers_url":"https://api.github.com/users/sinan/followers","following_url":"https://api.github.com/users/sinan/following{/other_user}","gists_url":"https://api.github.com/users/sinan/gists{/gist_id}","starred_url":"https://api.github.com/users/sinan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sinan/subscriptions","organizations_url":"https://api.github.com/users/sinan/orgs","repos_url":"https://api.github.com/users/sinan/repos","events_url":"https://api.github.com/users/sinan/events{/privacy}","received_events_url":"https://api.github.com/users/sinan/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/koding/kd/pulls/58/commits","review_comments_url":"https://api.github.com/repos/koding/kd/pulls/58/comments","review_comment_url":"https://api.github.com/repos/koding/kd/pulls/comments/{number}","comments_url":"https://api.github.com/repos/koding/kd/issues/58/comments","statuses_url":"https://api.github.com/repos/koding/kd/statuses/fbd3932138cbecf70b7c1dd01d4a2ccf125dbcd2","head":{"label":"usirin:utils-tests","ref":"utils-tests","sha":"fbd3932138cbecf70b7c1dd01d4a2ccf125dbcd2","user":{"login":"usirin","id":1783869,"avatar_url":"https://avatars.githubusercontent.com/u/1783869?v=2","gravatar_id":"a03ae1b1965fd35c3f763f8b651a3854","url":"https://api.github.com/users/usirin","html_url":"https://github.com/usirin","followers_url":"https://api.github.com/users/usirin/followers","following_url":"https://api.github.com/users/usirin/following{/other_user}","gists_url":"https://api.github.com/users/usirin/gists{/gist_id}","starred_url":"https://api.github.com/users/usirin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/usirin/subscriptions","organizations_url":"https://api.github.com/users/usirin/orgs","repos_url":"https://api.github.com/users/usirin/repos","events_url":"https://api.github.com/users/usirin/events{/privacy}","received_events_url":"https://api.github.com/users/usirin/received_events","type":"User","site_admin":false},"repo":{"id":21675512,"name":"kd","full_name":"usirin/kd","owner":{"login":"usirin","id":1783869,"avatar_url":"https://avatars.githubusercontent.com/u/1783869?v=2","gravatar_id":"a03ae1b1965fd35c3f763f8b651a3854","url":"https://api.github.com/users/usirin","html_url":"https://github.com/usirin","followers_url":"https://api.github.com/users/usirin/followers","following_url":"https://api.github.com/users/usirin/following{/other_user}","gists_url":"https://api.github.com/users/usirin/gists{/gist_id}","starred_url":"https://api.github.com/users/usirin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/usirin/subscriptions","organizations_url":"https://api.github.com/users/usirin/orgs","repos_url":"https://api.github.com/users/usirin/repos","events_url":"https://api.github.com/users/usirin/events{/privacy}","received_events_url":"https://api.github.com/users/usirin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/usirin/kd","description":"a non-document focused UI Framework for web applications.","fork":true,"url":"https://api.github.com/repos/usirin/kd","forks_url":"https://api.github.com/repos/usirin/kd/forks","keys_url":"https://api.github.com/repos/usirin/kd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/usirin/kd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/usirin/kd/teams","hooks_url":"https://api.github.com/repos/usirin/kd/hooks","issue_events_url":"https://api.github.com/repos/usirin/kd/issues/events{/number}","events_url":"https://api.github.com/repos/usirin/kd/events","assignees_url":"https://api.github.com/repos/usirin/kd/assignees{/user}","branches_url":"https://api.github.com/repos/usirin/kd/branches{/branch}","tags_url":"https://api.github.com/repos/usirin/kd/tags","blobs_url":"https://api.github.com/repos/usirin/kd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/usirin/kd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/usirin/kd/git/refs{/sha}","trees_url":"https://api.github.com/repos/usirin/kd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/usirin/kd/statuses/{sha}","languages_url":"https://api.github.com/repos/usirin/kd/languages","stargazers_url":"https://api.github.com/repos/usirin/kd/stargazers","contributors_url":"https://api.github.com/repos/usirin/kd/contributors","subscribers_url":"https://api.github.com/repos/usirin/kd/subscribers","subscription_url":"https://api.github.com/repos/usirin/kd/subscription","commits_url":"https://api.github.com/repos/usirin/kd/commits{/sha}","git_commits_url":"https://api.github.com/repos/usirin/kd/git/commits{/sha}","comments_url":"https://api.github.com/repos/usirin/kd/comments{/number}","issue_comment_url":"https://api.github.com/repos/usirin/kd/issues/comments/{number}","contents_url":"https://api.github.com/repos/usirin/kd/contents/{+path}","compare_url":"https://api.github.com/repos/usirin/kd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/usirin/kd/merges","archive_url":"https://api.github.com/repos/usirin/kd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/usirin/kd/downloads","issues_url":"https://api.github.com/repos/usirin/kd/issues{/number}","pulls_url":"https://api.github.com/repos/usirin/kd/pulls{/number}","milestones_url":"https://api.github.com/repos/usirin/kd/milestones{/number}","notifications_url":"https://api.github.com/repos/usirin/kd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/usirin/kd/labels{/name}","releases_url":"https://api.github.com/repos/usirin/kd/releases{/id}","created_at":"2014-07-10T01:56:33Z","updated_at":"2014-07-08T17:26:22Z","pushed_at":"2014-08-12T23:36:01Z","git_url":"git://github.com/usirin/kd.git","ssh_url":"git@github.com:usirin/kd.git","clone_url":"https://github.com/usirin/kd.git","svn_url":"https://github.com/usirin/kd","homepage":"http://kd.io","size":2961,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"koding:master.listview","ref":"master.listview","sha":"c9a08c96c0921fd2758a73789151b8c007d11dbb","user":{"login":"koding","id":1066754,"avatar_url":"https://avatars.githubusercontent.com/u/1066754?v=2","gravatar_id":"7e9b90e4807fcd7eee2526aff7d0db60","url":"https://api.github.com/users/koding","html_url":"https://github.com/koding","followers_url":"https://api.github.com/users/koding/followers","following_url":"https://api.github.com/users/koding/following{/other_user}","gists_url":"https://api.github.com/users/koding/gists{/gist_id}","starred_url":"https://api.github.com/users/koding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koding/subscriptions","organizations_url":"https://api.github.com/users/koding/orgs","repos_url":"https://api.github.com/users/koding/repos","events_url":"https://api.github.com/users/koding/events{/privacy}","received_events_url":"https://api.github.com/users/koding/received_events","type":"Organization","site_admin":false},"repo":{"id":17654723,"name":"kd","full_name":"koding/kd","owner":{"login":"koding","id":1066754,"avatar_url":"https://avatars.githubusercontent.com/u/1066754?v=2","gravatar_id":"7e9b90e4807fcd7eee2526aff7d0db60","url":"https://api.github.com/users/koding","html_url":"https://github.com/koding","followers_url":"https://api.github.com/users/koding/followers","following_url":"https://api.github.com/users/koding/following{/other_user}","gists_url":"https://api.github.com/users/koding/gists{/gist_id}","starred_url":"https://api.github.com/users/koding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koding/subscriptions","organizations_url":"https://api.github.com/users/koding/orgs","repos_url":"https://api.github.com/users/koding/repos","events_url":"https://api.github.com/users/koding/events{/privacy}","received_events_url":"https://api.github.com/users/koding/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/koding/kd","description":"a non-document focused UI Framework for web applications.","fork":false,"url":"https://api.github.com/repos/koding/kd","forks_url":"https://api.github.com/repos/koding/kd/forks","keys_url":"https://api.github.com/repos/koding/kd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/koding/kd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/koding/kd/teams","hooks_url":"https://api.github.com/repos/koding/kd/hooks","issue_events_url":"https://api.github.com/repos/koding/kd/issues/events{/number}","events_url":"https://api.github.com/repos/koding/kd/events","assignees_url":"https://api.github.com/repos/koding/kd/assignees{/user}","branches_url":"https://api.github.com/repos/koding/kd/branches{/branch}","tags_url":"https://api.github.com/repos/koding/kd/tags","blobs_url":"https://api.github.com/repos/koding/kd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/koding/kd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/koding/kd/git/refs{/sha}","trees_url":"https://api.github.com/repos/koding/kd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/koding/kd/statuses/{sha}","languages_url":"https://api.github.com/repos/koding/kd/languages","stargazers_url":"https://api.github.com/repos/koding/kd/stargazers","contributors_url":"https://api.github.com/repos/koding/kd/contributors","subscribers_url":"https://api.github.com/repos/koding/kd/subscribers","subscription_url":"https://api.github.com/repos/koding/kd/subscription","commits_url":"https://api.github.com/repos/koding/kd/commits{/sha}","git_commits_url":"https://api.github.com/repos/koding/kd/git/commits{/sha}","comments_url":"https://api.github.com/repos/koding/kd/comments{/number}","issue_comment_url":"https://api.github.com/repos/koding/kd/issues/comments/{number}","contents_url":"https://api.github.com/repos/koding/kd/contents/{+path}","compare_url":"https://api.github.com/repos/koding/kd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/koding/kd/merges","archive_url":"https://api.github.com/repos/koding/kd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/koding/kd/downloads","issues_url":"https://api.github.com/repos/koding/kd/issues{/number}","pulls_url":"https://api.github.com/repos/koding/kd/pulls{/number}","milestones_url":"https://api.github.com/repos/koding/kd/milestones{/number}","notifications_url":"https://api.github.com/repos/koding/kd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/koding/kd/labels{/name}","releases_url":"https://api.github.com/repos/koding/kd/releases{/id}","created_at":"2014-03-12T03:54:59Z","updated_at":"2014-08-13T16:13:15Z","pushed_at":"2014-08-13T21:20:35Z","git_url":"git://github.com/koding/kd.git","ssh_url":"git@github.com:koding/kd.git","clone_url":"https://github.com/koding/kd.git","svn_url":"https://github.com/koding/kd","homepage":"http://kd.io","size":5963,"stargazers_count":40,"watchers_count":40,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":10,"mirror_url":null,"open_issues_count":2,"forks":10,"open_issues":2,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/koding/kd/pulls/58"},"html":{"href":"https://github.com/koding/kd/pull/58"},"issue":{"href":"https://api.github.com/repos/koding/kd/issues/58"},"comments":{"href":"https://api.github.com/repos/koding/kd/issues/58/comments"},"review_comments":{"href":"https://api.github.com/repos/koding/kd/pulls/58/comments"},"review_comment":{"href":"https://api.github.com/repos/koding/kd/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/koding/kd/pulls/58/commits"},"statuses":{"href":"https://api.github.com/repos/koding/kd/statuses/fbd3932138cbecf70b7c1dd01d4a2ccf125dbcd2"}}}}