GitHub PullRequestReviewCommentEvent at 2014-12-05 15:27:24
Repository: openhab
Actor: teichsta
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/openhab/openhab/pulls/comments/21377668","id":21377668,"diff_hunk":"@@ -191,41 +194,105 @@ public void closePort() {\n \t\t\te.printStackTrace();\n \t\t}\n \t\tserialPort.close();\n+\t\tlogger.debug(\"port closed: \"+port);\n+\t}\n+\t\n+\tprotected void resetAfterError() {\n+\t\t//Drop the rest\n+\t\ttry {\n+\t\t\t//sleep(500);","path":"bundles/binding/org.openhab.binding.davis/src/main/java/org/openhab/binding/davis/internal/DavisBinding.java","position":113,"original_position":113,"commit_id":"7f7f321eb1a7c7f1315ef5e02daa2ff7369e7323","original_commit_id":"7f7f321eb1a7c7f1315ef5e02daa2ff7369e7323","user":{"login":"teichsta","id":2108636,"avatar_url":"https://avatars.githubusercontent.com/u/2108636?v=3","gravatar_id":"","url":"https://api.github.com/users/teichsta","html_url":"https://github.com/teichsta","followers_url":"https://api.github.com/users/teichsta/followers","following_url":"https://api.github.com/users/teichsta/following{/other_user}","gists_url":"https://api.github.com/users/teichsta/gists{/gist_id}","starred_url":"https://api.github.com/users/teichsta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teichsta/subscriptions","organizations_url":"https://api.github.com/users/teichsta/orgs","repos_url":"https://api.github.com/users/teichsta/repos","events_url":"https://api.github.com/users/teichsta/events{/privacy}","received_events_url":"https://api.github.com/users/teichsta/received_events","type":"User","site_admin":false},"body":"please remove commented code","created_at":"2014-12-05T15:27:24Z","updated_at":"2014-12-05T15:27:24Z","html_url":"https://github.com/openhab/openhab/pull/1771#discussion_r21377668","pull_request_url":"https://api.github.com/repos/openhab/openhab/pulls/1771","_links":{"self":{"href":"https://api.github.com/repos/openhab/openhab/pulls/comments/21377668"},"html":{"href":"https://github.com/openhab/openhab/pull/1771#discussion_r21377668"},"pull_request":{"href":"https://api.github.com/repos/openhab/openhab/pulls/1771"}}},"pull_request":{"url":"https://api.github.com/repos/openhab/openhab/pulls/1771","id":25241640,"html_url":"https://github.com/openhab/openhab/pull/1771","diff_url":"https://github.com/openhab/openhab/pull/1771.diff","patch_url":"https://github.com/openhab/openhab/pull/1771.patch","issue_url":"https://api.github.com/repos/openhab/openhab/issues/1771","number":1771,"state":"open","locked":false,"title":"reworked serial communication to be more robust","user":{"login":"tomtrath","id":2311255,"avatar_url":"https://avatars.githubusercontent.com/u/2311255?v=3","gravatar_id":"","url":"https://api.github.com/users/tomtrath","html_url":"https://github.com/tomtrath","followers_url":"https://api.github.com/users/tomtrath/followers","following_url":"https://api.github.com/users/tomtrath/following{/other_user}","gists_url":"https://api.github.com/users/tomtrath/gists{/gist_id}","starred_url":"https://api.github.com/users/tomtrath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomtrath/subscriptions","organizations_url":"https://api.github.com/users/tomtrath/orgs","repos_url":"https://api.github.com/users/tomtrath/repos","events_url":"https://api.github.com/users/tomtrath/events{/privacy}","received_events_url":"https://api.github.com/users/tomtrath/received_events","type":"User","site_admin":false},"body":"reworked the serial communication to be more robust","created_at":"2014-11-30T23:32:24Z","updated_at":"2014-12-05T15:27:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bd51e73e1727c983fd387a5318d9cb4fd09ce840","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openhab/openhab/pulls/1771/commits","review_comments_url":"https://api.github.com/repos/openhab/openhab/pulls/1771/comments","review_comment_url":"https://api.github.com/repos/openhab/openhab/pulls/comments/{number}","comments_url":"https://api.github.com/repos/openhab/openhab/issues/1771/comments","statuses_url":"https://api.github.com/repos/openhab/openhab/statuses/7f7f321eb1a7c7f1315ef5e02daa2ff7369e7323","head":{"label":"tomtrath:davis-update","ref":"davis-update","sha":"7f7f321eb1a7c7f1315ef5e02daa2ff7369e7323","user":{"login":"tomtrath","id":2311255,"avatar_url":"https://avatars.githubusercontent.com/u/2311255?v=3","gravatar_id":"","url":"https://api.github.com/users/tomtrath","html_url":"https://github.com/tomtrath","followers_url":"https://api.github.com/users/tomtrath/followers","following_url":"https://api.github.com/users/tomtrath/following{/other_user}","gists_url":"https://api.github.com/users/tomtrath/gists{/gist_id}","starred_url":"https://api.github.com/users/tomtrath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomtrath/subscriptions","organizations_url":"https://api.github.com/users/tomtrath/orgs","repos_url":"https://api.github.com/users/tomtrath/repos","events_url":"https://api.github.com/users/tomtrath/events{/privacy}","received_events_url":"https://api.github.com/users/tomtrath/received_events","type":"User","site_admin":false},"repo":{"id":13009260,"name":"openhab","full_name":"tomtrath/openhab","owner":{"login":"tomtrath","id":2311255,"avatar_url":"https://avatars.githubusercontent.com/u/2311255?v=3","gravatar_id":"","url":"https://api.github.com/users/tomtrath","html_url":"https://github.com/tomtrath","followers_url":"https://api.github.com/users/tomtrath/followers","following_url":"https://api.github.com/users/tomtrath/following{/other_user}","gists_url":"https://api.github.com/users/tomtrath/gists{/gist_id}","starred_url":"https://api.github.com/users/tomtrath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomtrath/subscriptions","organizations_url":"https://api.github.com/users/tomtrath/orgs","repos_url":"https://api.github.com/users/tomtrath/repos","events_url":"https://api.github.com/users/tomtrath/events{/privacy}","received_events_url":"https://api.github.com/users/tomtrath/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tomtrath/openhab","description":"Source code of the HomeCAN binding for open Home Automation Bus (openHAB)","fork":true,"url":"https://api.github.com/repos/tomtrath/openhab","forks_url":"https://api.github.com/repos/tomtrath/openhab/forks","keys_url":"https://api.github.com/repos/tomtrath/openhab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tomtrath/openhab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tomtrath/openhab/teams","hooks_url":"https://api.github.com/repos/tomtrath/openhab/hooks","issue_events_url":"https://api.github.com/repos/tomtrath/openhab/issues/events{/number}","events_url":"https://api.github.com/repos/tomtrath/openhab/events","assignees_url":"https://api.github.com/repos/tomtrath/openhab/assignees{/user}","branches_url":"https://api.github.com/repos/tomtrath/openhab/branches{/branch}","tags_url":"https://api.github.com/repos/tomtrath/openhab/tags","blobs_url":"https://api.github.com/repos/tomtrath/openhab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tomtrath/openhab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tomtrath/openhab/git/refs{/sha}","trees_url":"https://api.github.com/repos/tomtrath/openhab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tomtrath/openhab/statuses/{sha}","languages_url":"https://api.github.com/repos/tomtrath/openhab/languages","stargazers_url":"https://api.github.com/repos/tomtrath/openhab/stargazers","contributors_url":"https://api.github.com/repos/tomtrath/openhab/contributors","subscribers_url":"https://api.github.com/repos/tomtrath/openhab/subscribers","subscription_url":"https://api.github.com/repos/tomtrath/openhab/subscription","commits_url":"https://api.github.com/repos/tomtrath/openhab/commits{/sha}","git_commits_url":"https://api.github.com/repos/tomtrath/openhab/git/commits{/sha}","comments_url":"https://api.github.com/repos/tomtrath/openhab/comments{/number}","issue_comment_url":"https://api.github.com/repos/tomtrath/openhab/issues/comments/{number}","contents_url":"https://api.github.com/repos/tomtrath/openhab/contents/{+path}","compare_url":"https://api.github.com/repos/tomtrath/openhab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tomtrath/openhab/merges","archive_url":"https://api.github.com/repos/tomtrath/openhab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tomtrath/openhab/downloads","issues_url":"https://api.github.com/repos/tomtrath/openhab/issues{/number}","pulls_url":"https://api.github.com/repos/tomtrath/openhab/pulls{/number}","milestones_url":"https://api.github.com/repos/tomtrath/openhab/milestones{/number}","notifications_url":"https://api.github.com/repos/tomtrath/openhab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tomtrath/openhab/labels{/name}","releases_url":"https://api.github.com/repos/tomtrath/openhab/releases{/id}","created_at":"2013-09-22T07:04:19Z","updated_at":"2014-11-30T23:36:15Z","pushed_at":"2014-11-30T23:36:13Z","git_url":"git://github.com/tomtrath/openhab.git","ssh_url":"git@github.com:tomtrath/openhab.git","clone_url":"https://github.com/tomtrath/openhab.git","svn_url":"https://github.com/tomtrath/openhab","homepage":"","size":138047,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"openhab:master","ref":"master","sha":"1caa6793f9b51b41099bcfc79766bd988d7d7ba9","user":{"login":"openhab","id":1007353,"avatar_url":"https://avatars.githubusercontent.com/u/1007353?v=3","gravatar_id":"","url":"https://api.github.com/users/openhab","html_url":"https://github.com/openhab","followers_url":"https://api.github.com/users/openhab/followers","following_url":"https://api.github.com/users/openhab/following{/other_user}","gists_url":"https://api.github.com/users/openhab/gists{/gist_id}","starred_url":"https://api.github.com/users/openhab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openhab/subscriptions","organizations_url":"https://api.github.com/users/openhab/orgs","repos_url":"https://api.github.com/users/openhab/repos","events_url":"https://api.github.com/users/openhab/events{/privacy}","received_events_url":"https://api.github.com/users/openhab/received_events","type":"Organization","site_admin":false},"repo":{"id":12983151,"name":"openhab","full_name":"openhab/openhab","owner":{"login":"openhab","id":1007353,"avatar_url":"https://avatars.githubusercontent.com/u/1007353?v=3","gravatar_id":"","url":"https://api.github.com/users/openhab","html_url":"https://github.com/openhab","followers_url":"https://api.github.com/users/openhab/followers","following_url":"https://api.github.com/users/openhab/following{/other_user}","gists_url":"https://api.github.com/users/openhab/gists{/gist_id}","starred_url":"https://api.github.com/users/openhab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openhab/subscriptions","organizations_url":"https://api.github.com/users/openhab/orgs","repos_url":"https://api.github.com/users/openhab/repos","events_url":"https://api.github.com/users/openhab/events{/privacy}","received_events_url":"https://api.github.com/users/openhab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openhab/openhab","description":"Source code of the open Home Automation Bus (openHAB)","fork":false,"url":"https://api.github.com/repos/openhab/openhab","forks_url":"https://api.github.com/repos/openhab/openhab/forks","keys_url":"https://api.github.com/repos/openhab/openhab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openhab/openhab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openhab/openhab/teams","hooks_url":"https://api.github.com/repos/openhab/openhab/hooks","issue_events_url":"https://api.github.com/repos/openhab/openhab/issues/events{/number}","events_url":"https://api.github.com/repos/openhab/openhab/events","assignees_url":"https://api.github.com/repos/openhab/openhab/assignees{/user}","branches_url":"https://api.github.com/repos/openhab/openhab/branches{/branch}","tags_url":"https://api.github.com/repos/openhab/openhab/tags","blobs_url":"https://api.github.com/repos/openhab/openhab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openhab/openhab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openhab/openhab/git/refs{/sha}","trees_url":"https://api.github.com/repos/openhab/openhab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openhab/openhab/statuses/{sha}","languages_url":"https://api.github.com/repos/openhab/openhab/languages","stargazers_url":"https://api.github.com/repos/openhab/openhab/stargazers","contributors_url":"https://api.github.com/repos/openhab/openhab/contributors","subscribers_url":"https://api.github.com/repos/openhab/openhab/subscribers","subscription_url":"https://api.github.com/repos/openhab/openhab/subscription","commits_url":"https://api.github.com/repos/openhab/openhab/commits{/sha}","git_commits_url":"https://api.github.com/repos/openhab/openhab/git/commits{/sha}","comments_url":"https://api.github.com/repos/openhab/openhab/comments{/number}","issue_comment_url":"https://api.github.com/repos/openhab/openhab/issues/comments/{number}","contents_url":"https://api.github.com/repos/openhab/openhab/contents/{+path}","compare_url":"https://api.github.com/repos/openhab/openhab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openhab/openhab/merges","archive_url":"https://api.github.com/repos/openhab/openhab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openhab/openhab/downloads","issues_url":"https://api.github.com/repos/openhab/openhab/issues{/number}","pulls_url":"https://api.github.com/repos/openhab/openhab/pulls{/number}","milestones_url":"https://api.github.com/repos/openhab/openhab/milestones{/number}","notifications_url":"https://api.github.com/repos/openhab/openhab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openhab/openhab/labels{/name}","releases_url":"https://api.github.com/repos/openhab/openhab/releases{/id}","created_at":"2013-09-20T20:28:43Z","updated_at":"2014-12-05T15:04:01Z","pushed_at":"2014-12-05T15:04:01Z","git_url":"git://github.com/openhab/openhab.git","ssh_url":"git@github.com:openhab/openhab.git","clone_url":"https://github.com/openhab/openhab.git","svn_url":"https://github.com/openhab/openhab","homepage":null,"size":201993,"stargazers_count":857,"watchers_count":857,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":515,"mirror_url":null,"open_issues_count":361,"forks":515,"open_issues":361,"watchers":857,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openhab/openhab/pulls/1771"},"html":{"href":"https://github.com/openhab/openhab/pull/1771"},"issue":{"href":"https://api.github.com/repos/openhab/openhab/issues/1771"},"comments":{"href":"https://api.github.com/repos/openhab/openhab/issues/1771/comments"},"review_comments":{"href":"https://api.github.com/repos/openhab/openhab/pulls/1771/comments"},"review_comment":{"href":"https://api.github.com/repos/openhab/openhab/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/openhab/openhab/pulls/1771/commits"},"statuses":{"href":"https://api.github.com/repos/openhab/openhab/statuses/7f7f321eb1a7c7f1315ef5e02daa2ff7369e7323"}}}}