GitHub PullRequestEvent at 2014-11-10 15:28:44
Repository: flyingsaucer
Actor: pbrant
Payload: {"action":"closed","number":62,"pull_request":{"url":"https://api.github.com/repos/flyingsaucerproject/flyingsaucer/pulls/62","id":24120430,"html_url":"https://github.com/flyingsaucerproject/flyingsaucer/pull/62","diff_url":"https://github.com/flyingsaucerproject/flyingsaucer/pull/62.diff","patch_url":"https://github.com/flyingsaucerproject/flyingsaucer/pull/62.patch","issue_url":"https://api.github.com/repos/flyingsaucerproject/flyingsaucer/issues/62","number":62,"state":"closed","locked":false,"title":"Implement Scrollable interface for viewport resize rules in Swing RootPanel.","user":{"login":"tobymckoi","id":707519,"avatar_url":"https://avatars.githubusercontent.com/u/707519?v=3","gravatar_id":"","url":"https://api.github.com/users/tobymckoi","html_url":"https://github.com/tobymckoi","followers_url":"https://api.github.com/users/tobymckoi/followers","following_url":"https://api.github.com/users/tobymckoi/following{/other_user}","gists_url":"https://api.github.com/users/tobymckoi/gists{/gist_id}","starred_url":"https://api.github.com/users/tobymckoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobymckoi/subscriptions","organizations_url":"https://api.github.com/users/tobymckoi/orgs","repos_url":"https://api.github.com/users/tobymckoi/repos","events_url":"https://api.github.com/users/tobymckoi/events{/privacy}","received_events_url":"https://api.github.com/users/tobymckoi/received_events","type":"User","site_admin":false},"body":"I noticed when Flying Saucer lays out a page within a JScrollPane, the viewport dimensions were often lagging behind the JScrollPane component size. This was causing scroll bars to flicker when resizing a frame with a scrollable RootPanel in it (very noticeable when scroll bar policy is set to 'AS_NEEDED'). This patch fixes the problem by using the Scrollable interface to handle setting the viewport size.","created_at":"2014-11-09T22:41:36Z","updated_at":"2014-11-10T15:28:44Z","closed_at":"2014-11-10T15:28:44Z","merged_at":"2014-11-10T15:28:44Z","merge_commit_sha":"bc7f289c16c57f4de082823e19ae99f6d9ddcd83","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/flyingsaucerproject/flyingsaucer/pulls/62/commits","review_comments_url":"https://api.github.com/repos/flyingsaucerproject/flyingsaucer/pulls/62/comments","review_comment_url":"https://api.github.com/repos/flyingsaucerproject/flyingsaucer/pulls/comments/{number}","comments_url":"https://api.github.com/repos/flyingsaucerproject/flyingsaucer/issues/62/comments","statuses_url":"https://api.github.com/repos/flyingsaucerproject/flyingsaucer/statuses/214bd386a50b2158e724d6d1b5a1ea889dd03af5","head":{"label":"tobymckoi:mainlineupdates","ref":"mainlineupdates","sha":"214bd386a50b2158e724d6d1b5a1ea889dd03af5","user":{"login":"tobymckoi","id":707519,"avatar_url":"https://avatars.githubusercontent.com/u/707519?v=3","gravatar_id":"","url":"https://api.github.com/users/tobymckoi","html_url":"https://github.com/tobymckoi","followers_url":"https://api.github.com/users/tobymckoi/followers","following_url":"https://api.github.com/users/tobymckoi/following{/other_user}","gists_url":"https://api.github.com/users/tobymckoi/gists{/gist_id}","starred_url":"https://api.github.com/users/tobymckoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobymckoi/subscriptions","organizations_url":"https://api.github.com/users/tobymckoi/orgs","repos_url":"https://api.github.com/users/tobymckoi/repos","events_url":"https://api.github.com/users/tobymckoi/events{/privacy}","received_events_url":"https://api.github.com/users/tobymckoi/received_events","type":"User","site_admin":false},"repo":{"id":25886577,"name":"flyingsaucer","full_name":"tobymckoi/flyingsaucer","owner":{"login":"tobymckoi","id":707519,"avatar_url":"https://avatars.githubusercontent.com/u/707519?v=3","gravatar_id":"","url":"https://api.github.com/users/tobymckoi","html_url":"https://github.com/tobymckoi","followers_url":"https://api.github.com/users/tobymckoi/followers","following_url":"https://api.github.com/users/tobymckoi/following{/other_user}","gists_url":"https://api.github.com/users/tobymckoi/gists{/gist_id}","starred_url":"https://api.github.com/users/tobymckoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobymckoi/subscriptions","organizations_url":"https://api.github.com/users/tobymckoi/orgs","repos_url":"https://api.github.com/users/tobymckoi/repos","events_url":"https://api.github.com/users/tobymckoi/events{/privacy}","received_events_url":"https://api.github.com/users/tobymckoi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tobymckoi/flyingsaucer","description":"Fork of Flying Saucer (Pure Java XML/XHTML and CSS 2.1 renderer)","fork":true,"url":"https://api.github.com/repos/tobymckoi/flyingsaucer","forks_url":"https://api.github.com/repos/tobymckoi/flyingsaucer/forks","keys_url":"https://api.github.com/repos/tobymckoi/flyingsaucer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tobymckoi/flyingsaucer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tobymckoi/flyingsaucer/teams","hooks_url":"https://api.github.com/repos/tobymckoi/flyingsaucer/hooks","issue_events_url":"https://api.github.com/repos/tobymckoi/flyingsaucer/issues/events{/number}","events_url":"https://api.github.com/repos/tobymckoi/flyingsaucer/events","assignees_url":"https://api.github.com/repos/tobymckoi/flyingsaucer/assignees{/user}","branches_url":"https://api.github.com/repos/tobymckoi/flyingsaucer/branches{/branch}","tags_url":"https://api.github.com/repos/tobymckoi/flyingsaucer/tags","blobs_url":"https://api.github.com/repos/tobymckoi/flyingsaucer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tobymckoi/flyingsaucer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tobymckoi/flyingsaucer/git/refs{/sha}","trees_url":"https://api.github.com/repos/tobymckoi/flyingsaucer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tobymckoi/flyingsaucer/statuses/{sha}","languages_url":"https://api.github.com/repos/tobymckoi/flyingsaucer/languages","stargazers_url":"https://api.github.com/repos/tobymckoi/flyingsaucer/stargazers","contributors_url":"https://api.github.com/repos/tobymckoi/flyingsaucer/contributors","subscribers_url":"https://api.github.com/repos/tobymckoi/flyingsaucer/subscribers","subscription_url":"https://api.github.com/repos/tobymckoi/flyingsaucer/subscription","commits_url":"https://api.github.com/repos/tobymckoi/flyingsaucer/commits{/sha}","git_commits_url":"https://api.github.com/repos/tobymckoi/flyingsaucer/git/commits{/sha}","comments_url":"https://api.github.com/repos/tobymckoi/flyingsaucer/comments{/number}","issue_comment_url":"https://api.github.com/repos/tobymckoi/flyingsaucer/issues/comments/{number}","contents_url":"https://api.github.com/repos/tobymckoi/flyingsaucer/contents/{+path}","compare_url":"https://api.github.com/repos/tobymckoi/flyingsaucer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tobymckoi/flyingsaucer/merges","archive_url":"https://api.github.com/repos/tobymckoi/flyingsaucer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tobymckoi/flyingsaucer/downloads","issues_url":"https://api.github.com/repos/tobymckoi/flyingsaucer/issues{/number}","pulls_url":"https://api.github.com/repos/tobymckoi/flyingsaucer/pulls{/number}","milestones_url":"https://api.github.com/repos/tobymckoi/flyingsaucer/milestones{/number}","notifications_url":"https://api.github.com/repos/tobymckoi/flyingsaucer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tobymckoi/flyingsaucer/labels{/name}","releases_url":"https://api.github.com/repos/tobymckoi/flyingsaucer/releases{/id}","created_at":"2014-10-28T19:35:06Z","updated_at":"2014-10-29T21:51:48Z","pushed_at":"2014-11-10T02:59:44Z","git_url":"git://github.com/tobymckoi/flyingsaucer.git","ssh_url":"git@github.com:tobymckoi/flyingsaucer.git","clone_url":"https://github.com/tobymckoi/flyingsaucer.git","svn_url":"https://github.com/tobymckoi/flyingsaucer","homepage":"","size":62072,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"flyingsaucerproject:master","ref":"master","sha":"95bfc21a868b15c0753e179040dabb40b59f6b09","user":{"login":"flyingsaucerproject","id":247732,"avatar_url":"https://avatars.githubusercontent.com/u/247732?v=3","gravatar_id":"","url":"https://api.github.com/users/flyingsaucerproject","html_url":"https://github.com/flyingsaucerproject","followers_url":"https://api.github.com/users/flyingsaucerproject/followers","following_url":"https://api.github.com/users/flyingsaucerproject/following{/other_user}","gists_url":"https://api.github.com/users/flyingsaucerproject/gists{/gist_id}","starred_url":"https://api.github.com/users/flyingsaucerproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flyingsaucerproject/subscriptions","organizations_url":"https://api.github.com/users/flyingsaucerproject/orgs","repos_url":"https://api.github.com/users/flyingsaucerproject/repos","events_url":"https://api.github.com/users/flyingsaucerproject/events{/privacy}","received_events_url":"https://api.github.com/users/flyingsaucerproject/received_events","type":"User","site_admin":false},"repo":{"id":618681,"name":"flyingsaucer","full_name":"flyingsaucerproject/flyingsaucer","owner":{"login":"flyingsaucerproject","id":247732,"avatar_url":"https://avatars.githubusercontent.com/u/247732?v=3","gravatar_id":"","url":"https://api.github.com/users/flyingsaucerproject","html_url":"https://github.com/flyingsaucerproject","followers_url":"https://api.github.com/users/flyingsaucerproject/followers","following_url":"https://api.github.com/users/flyingsaucerproject/following{/other_user}","gists_url":"https://api.github.com/users/flyingsaucerproject/gists{/gist_id}","starred_url":"https://api.github.com/users/flyingsaucerproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flyingsaucerproject/subscriptions","organizations_url":"https://api.github.com/users/flyingsaucerproject/orgs","repos_url":"https://api.github.com/users/flyingsaucerproject/repos","events_url":"https://api.github.com/users/flyingsaucerproject/events{/privacy}","received_events_url":"https://api.github.com/users/flyingsaucerproject/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/flyingsaucerproject/flyingsaucer","description":"XML/XHTML and CSS 2.1 renderer in pure Java","fork":false,"url":"https://api.github.com/repos/flyingsaucerproject/flyingsaucer","forks_url":"https://api.github.com/repos/flyingsaucerproject/flyingsaucer/forks","keys_url":"https://api.github.com/repos/flyingsaucerproject/flyingsaucer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flyingsaucerproject/flyingsaucer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flyingsaucerproject/flyingsaucer/teams","hooks_url":"https://api.github.com/repos/flyingsaucerproject/flyingsaucer/hooks","issue_events_url":"https://api.github.com/repos/flyingsaucerproject/flyingsaucer/issues/events{/number}","events_url":"https://api.github.com/repos/flyingsaucerproject/flyingsaucer/events","assignees_url":"https://api.github.com/repos/flyingsaucerproject/flyingsaucer/assignees{/user}","branches_url":"https://api.github.com/repos/flyingsaucerproject/flyingsaucer/branches{/branch}","tags_url":"https://api.github.com/repos/flyingsaucerproject/flyingsaucer/tags","blobs_url":"https://api.github.com/repos/flyingsaucerproject/flyingsaucer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flyingsaucerproject/flyingsaucer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flyingsaucerproject/flyingsaucer/git/refs{/sha}","trees_url":"https://api.github.com/repos/flyingsaucerproject/flyingsaucer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flyingsaucerproject/flyingsaucer/statuses/{sha}","languages_url":"https://api.github.com/repos/flyingsaucerproject/flyingsaucer/languages","stargazers_url":"https://api.github.com/repos/flyingsaucerproject/flyingsaucer/stargazers","contributors_url":"https://api.github.com/repos/flyingsaucerproject/flyingsaucer/contributors","subscribers_url":"https://api.github.com/repos/flyingsaucerproject/flyingsaucer/subscribers","subscription_url":"https://api.github.com/repos/flyingsaucerproject/flyingsaucer/subscription","commits_url":"https://api.github.com/repos/flyingsaucerproject/flyingsaucer/commits{/sha}","git_commits_url":"https://api.github.com/repos/flyingsaucerproject/flyingsaucer/git/commits{/sha}","comments_url":"https://api.github.com/repos/flyingsaucerproject/flyingsaucer/comments{/number}","issue_comment_url":"https://api.github.com/repos/flyingsaucerproject/flyingsaucer/issues/comments/{number}","contents_url":"https://api.github.com/repos/flyingsaucerproject/flyingsaucer/contents/{+path}","compare_url":"https://api.github.com/repos/flyingsaucerproject/flyingsaucer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flyingsaucerproject/flyingsaucer/merges","archive_url":"https://api.github.com/repos/flyingsaucerproject/flyingsaucer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flyingsaucerproject/flyingsaucer/downloads","issues_url":"https://api.github.com/repos/flyingsaucerproject/flyingsaucer/issues{/number}","pulls_url":"https://api.github.com/repos/flyingsaucerproject/flyingsaucer/pulls{/number}","milestones_url":"https://api.github.com/repos/flyingsaucerproject/flyingsaucer/milestones{/number}","notifications_url":"https://api.github.com/repos/flyingsaucerproject/flyingsaucer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flyingsaucerproject/flyingsaucer/labels{/name}","releases_url":"https://api.github.com/repos/flyingsaucerproject/flyingsaucer/releases{/id}","created_at":"2010-04-19T23:26:11Z","updated_at":"2014-11-09T17:51:51Z","pushed_at":"2014-11-10T15:28:44Z","git_url":"git://github.com/flyingsaucerproject/flyingsaucer.git","ssh_url":"git@github.com:flyingsaucerproject/flyingsaucer.git","clone_url":"https://github.com/flyingsaucerproject/flyingsaucer.git","svn_url":"https://github.com/flyingsaucerproject/flyingsaucer","homepage":"http://code.google.com/p/flying-saucer/","size":64621,"stargazers_count":418,"watchers_count":418,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":156,"mirror_url":null,"open_issues_count":14,"forks":156,"open_issues":14,"watchers":418,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flyingsaucerproject/flyingsaucer/pulls/62"},"html":{"href":"https://github.com/flyingsaucerproject/flyingsaucer/pull/62"},"issue":{"href":"https://api.github.com/repos/flyingsaucerproject/flyingsaucer/issues/62"},"comments":{"href":"https://api.github.com/repos/flyingsaucerproject/flyingsaucer/issues/62/comments"},"review_comments":{"href":"https://api.github.com/repos/flyingsaucerproject/flyingsaucer/pulls/62/comments"},"review_comment":{"href":"https://api.github.com/repos/flyingsaucerproject/flyingsaucer/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/flyingsaucerproject/flyingsaucer/pulls/62/commits"},"statuses":{"href":"https://api.github.com/repos/flyingsaucerproject/flyingsaucer/statuses/214bd386a50b2158e724d6d1b5a1ea889dd03af5"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"pbrant","id":24168,"avatar_url":"https://avatars.githubusercontent.com/u/24168?v=3","gravatar_id":"","url":"https://api.github.com/users/pbrant","html_url":"https://github.com/pbrant","followers_url":"https://api.github.com/users/pbrant/followers","following_url":"https://api.github.com/users/pbrant/following{/other_user}","gists_url":"https://api.github.com/users/pbrant/gists{/gist_id}","starred_url":"https://api.github.com/users/pbrant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbrant/subscriptions","organizations_url":"https://api.github.com/users/pbrant/orgs","repos_url":"https://api.github.com/users/pbrant/repos","events_url":"https://api.github.com/users/pbrant/events{/privacy}","received_events_url":"https://api.github.com/users/pbrant/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":2,"additions":64,"deletions":45,"changed_files":1}}