GitHub PullRequestEvent at 2014-04-18 18:01:24
Repository: caffe
Actor: jeffdonahue
Payload: {"action":"opened","number":336,"pull_request":{"url":"https://api.github.com/repos/BVLC/caffe/pulls/336","id":14927316,"html_url":"https://github.com/BVLC/caffe/pull/336","diff_url":"https://github.com/BVLC/caffe/pull/336.diff","patch_url":"https://github.com/BVLC/caffe/pull/336.patch","issue_url":"https://api.github.com/repos/BVLC/caffe/issues/336","number":336,"state":"open","title":"Fix RNG segfault related to #297","user":{"login":"jeffdonahue","id":965190,"avatar_url":"https://avatars.githubusercontent.com/u/965190?","gravatar_id":"c81d5990c0a1fb9cd1c815aac144d9c7","url":"https://api.github.com/users/jeffdonahue","html_url":"https://github.com/jeffdonahue","followers_url":"https://api.github.com/users/jeffdonahue/followers","following_url":"https://api.github.com/users/jeffdonahue/following{/other_user}","gists_url":"https://api.github.com/users/jeffdonahue/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffdonahue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffdonahue/subscriptions","organizations_url":"https://api.github.com/users/jeffdonahue/orgs","repos_url":"https://api.github.com/users/jeffdonahue/repos","events_url":"https://api.github.com/users/jeffdonahue/events{/privacy}","received_events_url":"https://api.github.com/users/jeffdonahue/received_events","type":"User","site_admin":false},"body":"This PR removes the `caffe_set_rng` behavior which was causing a crash (#335) with segfault by constructing a variate generator with a reference to Caffe's RNG engine (something that I found out was possible after hours of googling..).\r\n\r\nFor some reason, I still get a segfault about 10% of the time I try to run ImageNet training, but this time it happens when filling the *biases* in conv1...\r\n\r\n```\r\nI0418 10:50:52.465656 16095 net.cpp:75] Creating Layer conv1                                                                                                                                                                        [399/3264]\r\nI0418 10:50:52.465667 16095 net.cpp:85] conv1 <- data\r\nI0418 10:50:52.465687 16095 net.cpp:111] conv1 -> conv1\r\n[New Thread 0x7fffe2db1700 (LWP 16097)]\r\n\r\nProgram received signal SIGSEGV, Segmentation fault.\r\n0x00007fffef7ee5ae in ?? () from /lib/x86_64-linux-gnu/libc.so.6\r\n(gdb) bt\r\n#0  0x00007fffef7ee5ae in ?? () from /lib/x86_64-linux-gnu/libc.so.6\r\n#1  0x00007fffef7f0f95 in malloc () from /lib/x86_64-linux-gnu/libc.so.6\r\n#2  0x0000000000461c72 in caffe::CaffeMallocHost (ptr=0x9791a0, size=384) at ./include/caffe/syncedmem.hpp:27\r\n#3  0x0000000000461ce7 in caffe::SyncedMemory::to_cpu (this=0x9791a0) at src/caffe/syncedmem.cpp:25\r\n#4  0x0000000000461bb8 in caffe::SyncedMemory::mutable_cpu_data (this=0x9791a0) at src/caffe/syncedmem.cpp:73\r\n#5  0x000000000045f058 in caffe::Blob<float>::mutable_cpu_data (this=0xcfa480) at src/caffe/blob.cpp:67\r\n#6  0x00000000004cc167 in caffe::ConstantFiller<float>::Fill (this=0x936790, blob=0xcfa480)\r\n    at ./include/caffe/filler.hpp:37\r\n#7  0x00000000004d2614 in caffe::ConvolutionLayer<float>::SetUp (this=0x936e60, bottom=..., top=0x8fbb38)\r\n    at src/caffe/layers/conv_layer.cpp:65\r\n#8  0x000000000046419f in caffe::Net<float>::Init (this=0x8fd300, in_param=...) at src/caffe/net.cpp:124\r\n#9  0x0000000000462dc1 in caffe::Net<float>::Net (this=0x8fd300, param_file=...) at src/caffe/net.cpp:31\r\n#10 0x0000000000454c01 in caffe::Solver<float>::Init (this=0x7fffffffda80, param=...) at src/caffe/solver.cpp:39\r\n#11 0x00000000004549e0 in caffe::Solver<float>::Solver (this=0x7fffffffda80, param=...) at src/caffe/solver.cpp:23\r\n#12 0x0000000000415482 in caffe::SGDSolver<float>::SGDSolver (this=0x7fffffffda80, param=...)\r\n    at ./include/caffe/solver.hpp:57\r\n#13 0x0000000000415026 in main (argc=2, argv=0x7fffffffdce8) at tools/train_net.cpp:27\r\n```\r\n\r\nNot exactly sure what to say about this but it seems like it must be unrelated to the RNG since the ConstantFiller does not use it...","created_at":"2014-04-18T18:01:23Z","updated_at":"2014-04-18T18:01:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/BVLC/caffe/pulls/336/commits","review_comments_url":"https://api.github.com/repos/BVLC/caffe/pulls/336/comments","review_comment_url":"https://api.github.com/repos/BVLC/caffe/pulls/comments/{number}","comments_url":"https://api.github.com/repos/BVLC/caffe/issues/336/comments","statuses_url":"https://api.github.com/repos/BVLC/caffe/statuses/a8aaf9b1e33cefd96e4489dbe31a9ffa519abcf1","head":{"label":"jeffdonahue:fix-rng-segfault","ref":"fix-rng-segfault","sha":"a8aaf9b1e33cefd96e4489dbe31a9ffa519abcf1","user":{"login":"jeffdonahue","id":965190,"avatar_url":"https://avatars.githubusercontent.com/u/965190?","gravatar_id":"c81d5990c0a1fb9cd1c815aac144d9c7","url":"https://api.github.com/users/jeffdonahue","html_url":"https://github.com/jeffdonahue","followers_url":"https://api.github.com/users/jeffdonahue/followers","following_url":"https://api.github.com/users/jeffdonahue/following{/other_user}","gists_url":"https://api.github.com/users/jeffdonahue/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffdonahue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffdonahue/subscriptions","organizations_url":"https://api.github.com/users/jeffdonahue/orgs","repos_url":"https://api.github.com/users/jeffdonahue/repos","events_url":"https://api.github.com/users/jeffdonahue/events{/privacy}","received_events_url":"https://api.github.com/users/jeffdonahue/received_events","type":"User","site_admin":false},"repo":{"id":17725787,"name":"caffe","full_name":"jeffdonahue/caffe","owner":{"login":"jeffdonahue","id":965190,"avatar_url":"https://avatars.githubusercontent.com/u/965190?","gravatar_id":"c81d5990c0a1fb9cd1c815aac144d9c7","url":"https://api.github.com/users/jeffdonahue","html_url":"https://github.com/jeffdonahue","followers_url":"https://api.github.com/users/jeffdonahue/followers","following_url":"https://api.github.com/users/jeffdonahue/following{/other_user}","gists_url":"https://api.github.com/users/jeffdonahue/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffdonahue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffdonahue/subscriptions","organizations_url":"https://api.github.com/users/jeffdonahue/orgs","repos_url":"https://api.github.com/users/jeffdonahue/repos","events_url":"https://api.github.com/users/jeffdonahue/events{/privacy}","received_events_url":"https://api.github.com/users/jeffdonahue/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jeffdonahue/caffe","description":"Caffe","fork":true,"url":"https://api.github.com/repos/jeffdonahue/caffe","forks_url":"https://api.github.com/repos/jeffdonahue/caffe/forks","keys_url":"https://api.github.com/repos/jeffdonahue/caffe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeffdonahue/caffe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeffdonahue/caffe/teams","hooks_url":"https://api.github.com/repos/jeffdonahue/caffe/hooks","issue_events_url":"https://api.github.com/repos/jeffdonahue/caffe/issues/events{/number}","events_url":"https://api.github.com/repos/jeffdonahue/caffe/events","assignees_url":"https://api.github.com/repos/jeffdonahue/caffe/assignees{/user}","branches_url":"https://api.github.com/repos/jeffdonahue/caffe/branches{/branch}","tags_url":"https://api.github.com/repos/jeffdonahue/caffe/tags","blobs_url":"https://api.github.com/repos/jeffdonahue/caffe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeffdonahue/caffe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeffdonahue/caffe/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeffdonahue/caffe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeffdonahue/caffe/statuses/{sha}","languages_url":"https://api.github.com/repos/jeffdonahue/caffe/languages","stargazers_url":"https://api.github.com/repos/jeffdonahue/caffe/stargazers","contributors_url":"https://api.github.com/repos/jeffdonahue/caffe/contributors","subscribers_url":"https://api.github.com/repos/jeffdonahue/caffe/subscribers","subscription_url":"https://api.github.com/repos/jeffdonahue/caffe/subscription","commits_url":"https://api.github.com/repos/jeffdonahue/caffe/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeffdonahue/caffe/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeffdonahue/caffe/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeffdonahue/caffe/issues/comments/{number}","contents_url":"https://api.github.com/repos/jeffdonahue/caffe/contents/{+path}","compare_url":"https://api.github.com/repos/jeffdonahue/caffe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeffdonahue/caffe/merges","archive_url":"https://api.github.com/repos/jeffdonahue/caffe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeffdonahue/caffe/downloads","issues_url":"https://api.github.com/repos/jeffdonahue/caffe/issues{/number}","pulls_url":"https://api.github.com/repos/jeffdonahue/caffe/pulls{/number}","milestones_url":"https://api.github.com/repos/jeffdonahue/caffe/milestones{/number}","notifications_url":"https://api.github.com/repos/jeffdonahue/caffe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeffdonahue/caffe/labels{/name}","releases_url":"https://api.github.com/repos/jeffdonahue/caffe/releases{/id}","created_at":"2014-03-13T20:58:04Z","updated_at":"2014-04-18T18:01:23Z","pushed_at":"2014-04-18T17:56:15Z","git_url":"git://github.com/jeffdonahue/caffe.git","ssh_url":"git@github.com:jeffdonahue/caffe.git","clone_url":"https://github.com/jeffdonahue/caffe.git","svn_url":"https://github.com/jeffdonahue/caffe","homepage":"http://caffe.berkeleyvision.org/","size":17680,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"BVLC:dev","ref":"dev","sha":"2dad9ca76268ce4cf64f4c52733b74991063131f","user":{"login":"BVLC","id":6182163,"avatar_url":"https://avatars.githubusercontent.com/u/6182163?","gravatar_id":"36c099c330b6dcee08afd38b6c3168f4","url":"https://api.github.com/users/BVLC","html_url":"https://github.com/BVLC","followers_url":"https://api.github.com/users/BVLC/followers","following_url":"https://api.github.com/users/BVLC/following{/other_user}","gists_url":"https://api.github.com/users/BVLC/gists{/gist_id}","starred_url":"https://api.github.com/users/BVLC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BVLC/subscriptions","organizations_url":"https://api.github.com/users/BVLC/orgs","repos_url":"https://api.github.com/users/BVLC/repos","events_url":"https://api.github.com/users/BVLC/events{/privacy}","received_events_url":"https://api.github.com/users/BVLC/received_events","type":"Organization","site_admin":false},"repo":{"id":12791642,"name":"caffe","full_name":"BVLC/caffe","owner":{"login":"BVLC","id":6182163,"avatar_url":"https://avatars.githubusercontent.com/u/6182163?","gravatar_id":"36c099c330b6dcee08afd38b6c3168f4","url":"https://api.github.com/users/BVLC","html_url":"https://github.com/BVLC","followers_url":"https://api.github.com/users/BVLC/followers","following_url":"https://api.github.com/users/BVLC/following{/other_user}","gists_url":"https://api.github.com/users/BVLC/gists{/gist_id}","starred_url":"https://api.github.com/users/BVLC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BVLC/subscriptions","organizations_url":"https://api.github.com/users/BVLC/orgs","repos_url":"https://api.github.com/users/BVLC/repos","events_url":"https://api.github.com/users/BVLC/events{/privacy}","received_events_url":"https://api.github.com/users/BVLC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BVLC/caffe","description":"Caffe","fork":false,"url":"https://api.github.com/repos/BVLC/caffe","forks_url":"https://api.github.com/repos/BVLC/caffe/forks","keys_url":"https://api.github.com/repos/BVLC/caffe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BVLC/caffe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BVLC/caffe/teams","hooks_url":"https://api.github.com/repos/BVLC/caffe/hooks","issue_events_url":"https://api.github.com/repos/BVLC/caffe/issues/events{/number}","events_url":"https://api.github.com/repos/BVLC/caffe/events","assignees_url":"https://api.github.com/repos/BVLC/caffe/assignees{/user}","branches_url":"https://api.github.com/repos/BVLC/caffe/branches{/branch}","tags_url":"https://api.github.com/repos/BVLC/caffe/tags","blobs_url":"https://api.github.com/repos/BVLC/caffe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BVLC/caffe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BVLC/caffe/git/refs{/sha}","trees_url":"https://api.github.com/repos/BVLC/caffe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BVLC/caffe/statuses/{sha}","languages_url":"https://api.github.com/repos/BVLC/caffe/languages","stargazers_url":"https://api.github.com/repos/BVLC/caffe/stargazers","contributors_url":"https://api.github.com/repos/BVLC/caffe/contributors","subscribers_url":"https://api.github.com/repos/BVLC/caffe/subscribers","subscription_url":"https://api.github.com/repos/BVLC/caffe/subscription","commits_url":"https://api.github.com/repos/BVLC/caffe/commits{/sha}","git_commits_url":"https://api.github.com/repos/BVLC/caffe/git/commits{/sha}","comments_url":"https://api.github.com/repos/BVLC/caffe/comments{/number}","issue_comment_url":"https://api.github.com/repos/BVLC/caffe/issues/comments/{number}","contents_url":"https://api.github.com/repos/BVLC/caffe/contents/{+path}","compare_url":"https://api.github.com/repos/BVLC/caffe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BVLC/caffe/merges","archive_url":"https://api.github.com/repos/BVLC/caffe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BVLC/caffe/downloads","issues_url":"https://api.github.com/repos/BVLC/caffe/issues{/number}","pulls_url":"https://api.github.com/repos/BVLC/caffe/pulls{/number}","milestones_url":"https://api.github.com/repos/BVLC/caffe/milestones{/number}","notifications_url":"https://api.github.com/repos/BVLC/caffe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BVLC/caffe/labels{/name}","releases_url":"https://api.github.com/repos/BVLC/caffe/releases{/id}","created_at":"2013-09-12T18:39:48Z","updated_at":"2014-04-16T18:34:21Z","pushed_at":"2014-04-16T18:34:20Z","git_url":"git://github.com/BVLC/caffe.git","ssh_url":"git@github.com:BVLC/caffe.git","clone_url":"https://github.com/BVLC/caffe.git","svn_url":"https://github.com/BVLC/caffe","homepage":"http://caffe.berkeleyvision.org/","size":25914,"stargazers_count":351,"watchers_count":351,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":171,"mirror_url":null,"open_issues_count":76,"forks":171,"open_issues":76,"watchers":351,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BVLC/caffe/pulls/336"},"html":{"href":"https://github.com/BVLC/caffe/pull/336"},"issue":{"href":"https://api.github.com/repos/BVLC/caffe/issues/336"},"comments":{"href":"https://api.github.com/repos/BVLC/caffe/issues/336/comments"},"review_comments":{"href":"https://api.github.com/repos/BVLC/caffe/pulls/336/comments"},"review_comment":{"href":"https://api.github.com/repos/BVLC/caffe/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/BVLC/caffe/pulls/336/commits"},"statuses":{"href":"https://api.github.com/repos/BVLC/caffe/statuses/a8aaf9b1e33cefd96e4489dbe31a9ffa519abcf1"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":10,"deletions":35,"changed_files":4}}