GitHub PullRequestEvent at 2014-02-09 20:06:12
Repository: sprockets
Actor: josh
Payload: {"action":"closed","number":421,"pull_request":{"url":"https://api.github.com/repos/sstephenson/sprockets/pulls/421","id":4653805,"html_url":"https://github.com/sstephenson/sprockets/pull/421","diff_url":"https://github.com/sstephenson/sprockets/pull/421.diff","patch_url":"https://github.com/sstephenson/sprockets/pull/421.patch","issue_url":"https://api.github.com/repos/sstephenson/sprockets/issues/421","number":421,"state":"closed","title":"Change rack session options only when asset is found","user":{"login":"doitian","id":35768,"avatar_url":"https://gravatar.com/avatar/17bca47a4961a24f82ef972aa9e1c986?d=https%3A%2F%2Fidenticons.github.com%2Fa0b54f42bf035d7f3ee941e0fae94669.png&r=x","gravatar_id":"17bca47a4961a24f82ef972aa9e1c986","url":"https://api.github.com/users/doitian","html_url":"https://github.com/doitian","followers_url":"https://api.github.com/users/doitian/followers","following_url":"https://api.github.com/users/doitian/following{/other_user}","gists_url":"https://api.github.com/users/doitian/gists{/gist_id}","starred_url":"https://api.github.com/users/doitian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doitian/subscriptions","organizations_url":"https://api.github.com/users/doitian/orgs","repos_url":"https://api.github.com/users/doitian/repos","events_url":"https://api.github.com/users/doitian/events{/privacy}","received_events_url":"https://api.github.com/users/doitian/received_events","type":"User","site_admin":false},"body":"If asset is not found, <del>Rack</del><ins>Rails</ins> will try next route since `X-Cascade` header\r\nis set. It is better do not change env when the request is pass through.\r\n\r\n[sporkd/asset_prefix_test](https://github.com/sporkd/asset_prefix_test)\r\nhas demonstrated that when assets prefix is also a prefix of controller\r\nroutes, the session is never stored.","created_at":"2013-03-16T17:07:47Z","updated_at":"2014-02-09T20:06:10Z","closed_at":"2014-02-09T20:06:10Z","merged_at":null,"merge_commit_sha":"14821df90331e5d45223bacdd1d2068b2ab3b31f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sstephenson/sprockets/pulls/421/commits","review_comments_url":"https://api.github.com/repos/sstephenson/sprockets/pulls/421/comments","review_comment_url":"https://api.github.com/repos/sstephenson/sprockets/pulls/comments/{number}","comments_url":"https://api.github.com/repos/sstephenson/sprockets/issues/421/comments","statuses_url":"https://api.github.com/repos/sstephenson/sprockets/statuses/5244fae606fcd228e4b366917c1941b394a6e091","head":{"label":"doitian:do-not-change-rack-session-options-when-asset-not-found","ref":"do-not-change-rack-session-options-when-asset-not-found","sha":"5244fae606fcd228e4b366917c1941b394a6e091","user":{"login":"doitian","id":35768,"avatar_url":"https://gravatar.com/avatar/17bca47a4961a24f82ef972aa9e1c986?d=https%3A%2F%2Fidenticons.github.com%2Fa0b54f42bf035d7f3ee941e0fae94669.png&r=x","gravatar_id":"17bca47a4961a24f82ef972aa9e1c986","url":"https://api.github.com/users/doitian","html_url":"https://github.com/doitian","followers_url":"https://api.github.com/users/doitian/followers","following_url":"https://api.github.com/users/doitian/following{/other_user}","gists_url":"https://api.github.com/users/doitian/gists{/gist_id}","starred_url":"https://api.github.com/users/doitian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doitian/subscriptions","organizations_url":"https://api.github.com/users/doitian/orgs","repos_url":"https://api.github.com/users/doitian/repos","events_url":"https://api.github.com/users/doitian/events{/privacy}","received_events_url":"https://api.github.com/users/doitian/received_events","type":"User","site_admin":false},"repo":{"id":8821538,"name":"sprockets","full_name":"doitian/sprockets","owner":{"login":"doitian","id":35768,"avatar_url":"https://gravatar.com/avatar/17bca47a4961a24f82ef972aa9e1c986?d=https%3A%2F%2Fidenticons.github.com%2Fa0b54f42bf035d7f3ee941e0fae94669.png&r=x","gravatar_id":"17bca47a4961a24f82ef972aa9e1c986","url":"https://api.github.com/users/doitian","html_url":"https://github.com/doitian","followers_url":"https://api.github.com/users/doitian/followers","following_url":"https://api.github.com/users/doitian/following{/other_user}","gists_url":"https://api.github.com/users/doitian/gists{/gist_id}","starred_url":"https://api.github.com/users/doitian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doitian/subscriptions","organizations_url":"https://api.github.com/users/doitian/orgs","repos_url":"https://api.github.com/users/doitian/repos","events_url":"https://api.github.com/users/doitian/events{/privacy}","received_events_url":"https://api.github.com/users/doitian/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/doitian/sprockets","description":"Rack-based asset packaging system","fork":true,"url":"https://api.github.com/repos/doitian/sprockets","forks_url":"https://api.github.com/repos/doitian/sprockets/forks","keys_url":"https://api.github.com/repos/doitian/sprockets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/doitian/sprockets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/doitian/sprockets/teams","hooks_url":"https://api.github.com/repos/doitian/sprockets/hooks","issue_events_url":"https://api.github.com/repos/doitian/sprockets/issues/events{/number}","events_url":"https://api.github.com/repos/doitian/sprockets/events","assignees_url":"https://api.github.com/repos/doitian/sprockets/assignees{/user}","branches_url":"https://api.github.com/repos/doitian/sprockets/branches{/branch}","tags_url":"https://api.github.com/repos/doitian/sprockets/tags","blobs_url":"https://api.github.com/repos/doitian/sprockets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/doitian/sprockets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/doitian/sprockets/git/refs{/sha}","trees_url":"https://api.github.com/repos/doitian/sprockets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/doitian/sprockets/statuses/{sha}","languages_url":"https://api.github.com/repos/doitian/sprockets/languages","stargazers_url":"https://api.github.com/repos/doitian/sprockets/stargazers","contributors_url":"https://api.github.com/repos/doitian/sprockets/contributors","subscribers_url":"https://api.github.com/repos/doitian/sprockets/subscribers","subscription_url":"https://api.github.com/repos/doitian/sprockets/subscription","commits_url":"https://api.github.com/repos/doitian/sprockets/commits{/sha}","git_commits_url":"https://api.github.com/repos/doitian/sprockets/git/commits{/sha}","comments_url":"https://api.github.com/repos/doitian/sprockets/comments{/number}","issue_comment_url":"https://api.github.com/repos/doitian/sprockets/issues/comments/{number}","contents_url":"https://api.github.com/repos/doitian/sprockets/contents/{+path}","compare_url":"https://api.github.com/repos/doitian/sprockets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/doitian/sprockets/merges","archive_url":"https://api.github.com/repos/doitian/sprockets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/doitian/sprockets/downloads","issues_url":"https://api.github.com/repos/doitian/sprockets/issues{/number}","pulls_url":"https://api.github.com/repos/doitian/sprockets/pulls{/number}","milestones_url":"https://api.github.com/repos/doitian/sprockets/milestones{/number}","notifications_url":"https://api.github.com/repos/doitian/sprockets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/doitian/sprockets/labels{/name}","releases_url":"https://api.github.com/repos/doitian/sprockets/releases{/id}","created_at":"2013-03-16T16:24:28Z","updated_at":"2013-03-19T21:07:15Z","pushed_at":"2013-03-16T17:07:24Z","git_url":"git://github.com/doitian/sprockets.git","ssh_url":"git@github.com:doitian/sprockets.git","clone_url":"https://github.com/doitian/sprockets.git","svn_url":"https://github.com/doitian/sprockets","homepage":"","size":1663,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"sstephenson:master","ref":"master","sha":"18fca5c20c0dfa34d8c112353b82520869f5f099","user":{"login":"sstephenson","id":2603,"avatar_url":"https://gravatar.com/avatar/5b9fe87ec1faa67a4599782930f45ec9?d=https%3A%2F%2Fidenticons.github.com%2F92f54963fc39a9d87c2253186808ea61.png&r=x","gravatar_id":"5b9fe87ec1faa67a4599782930f45ec9","url":"https://api.github.com/users/sstephenson","html_url":"https://github.com/sstephenson","followers_url":"https://api.github.com/users/sstephenson/followers","following_url":"https://api.github.com/users/sstephenson/following{/other_user}","gists_url":"https://api.github.com/users/sstephenson/gists{/gist_id}","starred_url":"https://api.github.com/users/sstephenson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sstephenson/subscriptions","organizations_url":"https://api.github.com/users/sstephenson/orgs","repos_url":"https://api.github.com/users/sstephenson/repos","events_url":"https://api.github.com/users/sstephenson/events{/privacy}","received_events_url":"https://api.github.com/users/sstephenson/received_events","type":"User","site_admin":false},"repo":{"id":5497,"name":"sprockets","full_name":"sstephenson/sprockets","owner":{"login":"sstephenson","id":2603,"avatar_url":"https://gravatar.com/avatar/5b9fe87ec1faa67a4599782930f45ec9?d=https%3A%2F%2Fidenticons.github.com%2F92f54963fc39a9d87c2253186808ea61.png&r=x","gravatar_id":"5b9fe87ec1faa67a4599782930f45ec9","url":"https://api.github.com/users/sstephenson","html_url":"https://github.com/sstephenson","followers_url":"https://api.github.com/users/sstephenson/followers","following_url":"https://api.github.com/users/sstephenson/following{/other_user}","gists_url":"https://api.github.com/users/sstephenson/gists{/gist_id}","starred_url":"https://api.github.com/users/sstephenson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sstephenson/subscriptions","organizations_url":"https://api.github.com/users/sstephenson/orgs","repos_url":"https://api.github.com/users/sstephenson/repos","events_url":"https://api.github.com/users/sstephenson/events{/privacy}","received_events_url":"https://api.github.com/users/sstephenson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sstephenson/sprockets","description":"Rack-based asset packaging system","fork":false,"url":"https://api.github.com/repos/sstephenson/sprockets","forks_url":"https://api.github.com/repos/sstephenson/sprockets/forks","keys_url":"https://api.github.com/repos/sstephenson/sprockets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sstephenson/sprockets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sstephenson/sprockets/teams","hooks_url":"https://api.github.com/repos/sstephenson/sprockets/hooks","issue_events_url":"https://api.github.com/repos/sstephenson/sprockets/issues/events{/number}","events_url":"https://api.github.com/repos/sstephenson/sprockets/events","assignees_url":"https://api.github.com/repos/sstephenson/sprockets/assignees{/user}","branches_url":"https://api.github.com/repos/sstephenson/sprockets/branches{/branch}","tags_url":"https://api.github.com/repos/sstephenson/sprockets/tags","blobs_url":"https://api.github.com/repos/sstephenson/sprockets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sstephenson/sprockets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sstephenson/sprockets/git/refs{/sha}","trees_url":"https://api.github.com/repos/sstephenson/sprockets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sstephenson/sprockets/statuses/{sha}","languages_url":"https://api.github.com/repos/sstephenson/sprockets/languages","stargazers_url":"https://api.github.com/repos/sstephenson/sprockets/stargazers","contributors_url":"https://api.github.com/repos/sstephenson/sprockets/contributors","subscribers_url":"https://api.github.com/repos/sstephenson/sprockets/subscribers","subscription_url":"https://api.github.com/repos/sstephenson/sprockets/subscription","commits_url":"https://api.github.com/repos/sstephenson/sprockets/commits{/sha}","git_commits_url":"https://api.github.com/repos/sstephenson/sprockets/git/commits{/sha}","comments_url":"https://api.github.com/repos/sstephenson/sprockets/comments{/number}","issue_comment_url":"https://api.github.com/repos/sstephenson/sprockets/issues/comments/{number}","contents_url":"https://api.github.com/repos/sstephenson/sprockets/contents/{+path}","compare_url":"https://api.github.com/repos/sstephenson/sprockets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sstephenson/sprockets/merges","archive_url":"https://api.github.com/repos/sstephenson/sprockets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sstephenson/sprockets/downloads","issues_url":"https://api.github.com/repos/sstephenson/sprockets/issues{/number}","pulls_url":"https://api.github.com/repos/sstephenson/sprockets/pulls{/number}","milestones_url":"https://api.github.com/repos/sstephenson/sprockets/milestones{/number}","notifications_url":"https://api.github.com/repos/sstephenson/sprockets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sstephenson/sprockets/labels{/name}","releases_url":"https://api.github.com/repos/sstephenson/sprockets/releases{/id}","created_at":"2008-03-27T02:37:32Z","updated_at":"2014-02-09T20:05:44Z","pushed_at":"2014-02-09T20:05:44Z","git_url":"git://github.com/sstephenson/sprockets.git","ssh_url":"git@github.com:sstephenson/sprockets.git","clone_url":"https://github.com/sstephenson/sprockets.git","svn_url":"https://github.com/sstephenson/sprockets","homepage":"","size":3147,"stargazers_count":2175,"watchers_count":2175,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":294,"mirror_url":null,"open_issues_count":65,"forks":294,"open_issues":65,"watchers":2175,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sstephenson/sprockets/pulls/421"},"html":{"href":"https://github.com/sstephenson/sprockets/pull/421"},"issue":{"href":"https://api.github.com/repos/sstephenson/sprockets/issues/421"},"comments":{"href":"https://api.github.com/repos/sstephenson/sprockets/issues/421/comments"},"review_comments":{"href":"https://api.github.com/repos/sstephenson/sprockets/pulls/421/comments"},"review_comment":{"href":"https://api.github.com/repos/sstephenson/sprockets/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/sstephenson/sprockets/pulls/421/commits"},"statuses":{"href":"https://api.github.com/repos/sstephenson/sprockets/statuses/5244fae606fcd228e4b366917c1941b394a6e091"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":22,"deletions":5,"changed_files":2}}