GitHub PullRequestEvent at 2014-01-11 03:21:00
Repository: ninja_timeofday
Actor: chrisn-au
Payload: {"action":"closed","number":2,"pull_request":{"url":"https://api.github.com/repos/chrisn-au/ninja_timeofday/pulls/2","id":11420636,"html_url":"https://github.com/chrisn-au/ninja_timeofday/pull/2","diff_url":"https://github.com/chrisn-au/ninja_timeofday/pull/2.diff","patch_url":"https://github.com/chrisn-au/ninja_timeofday/pull/2.patch","issue_url":"https://github.com/chrisn-au/ninja_timeofday/pull/2","number":2,"state":"closed","title":"fix a typo, add some logging, try next day if times are in past","user":{"login":"dannyclark","id":441920,"avatar_url":"https://gravatar.com/avatar/25c35602d121479ba4365586bb958505?d=https%3A%2F%2Fidenticons.github.com%2F85e825270a12a4fb87b205d9e7badcff.png&r=x","gravatar_id":"25c35602d121479ba4365586bb958505","url":"https://api.github.com/users/dannyclark","html_url":"https://github.com/dannyclark","followers_url":"https://api.github.com/users/dannyclark/followers","following_url":"https://api.github.com/users/dannyclark/following{/other_user}","gists_url":"https://api.github.com/users/dannyclark/gists{/gist_id}","starred_url":"https://api.github.com/users/dannyclark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dannyclark/subscriptions","organizations_url":"https://api.github.com/users/dannyclark/orgs","repos_url":"https://api.github.com/users/dannyclark/repos","events_url":"https://api.github.com/users/dannyclark/events{/privacy}","received_events_url":"https://api.github.com/users/dannyclark/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nWould appreciate it if you can merge these changes.\r\n\r\n* The daily recalc wasn't happening, I think because of a typo, it was calling the updateNinja function instead of the setdayTimes function. I've also moved the daily recalc to midnight+5mins instead of midnight+50s (to make it work here in London)\r\n* SunCalc sometimes returns times in the past as well as in the future: in this case, I call it again for 1 day later and get the next time for the next day (which is in the window of the next 24 hours).\r\n* I've added some logging, which I think will help people diagnose whether it's working for them. Hope it's no too verbose.\r\n\r\nThanks,\r\nDan.","created_at":"2014-01-10T23:10:01Z","updated_at":"2014-01-11T03:21:00Z","closed_at":"2014-01-11T03:21:00Z","merged_at":"2014-01-11T03:21:00Z","merge_commit_sha":"d2600828a328b8a71f9c7496c5b2c6fc37d449dd","assignee":null,"milestone":null,"commits_url":"https://github.com/chrisn-au/ninja_timeofday/pull/2/commits","review_comments_url":"https://github.com/chrisn-au/ninja_timeofday/pull/2/comments","review_comment_url":"/repos/chrisn-au/ninja_timeofday/pulls/comments/{number}","comments_url":"https://api.github.com/repos/chrisn-au/ninja_timeofday/issues/2/comments","statuses_url":"https://api.github.com/repos/chrisn-au/ninja_timeofday/statuses/fb68fecc83c333062e8393da6e9848c6e1d0a8b5","head":{"label":"dannyclark:master","ref":"master","sha":"fb68fecc83c333062e8393da6e9848c6e1d0a8b5","user":{"login":"dannyclark","id":441920,"avatar_url":"https://gravatar.com/avatar/25c35602d121479ba4365586bb958505?d=https%3A%2F%2Fidenticons.github.com%2F85e825270a12a4fb87b205d9e7badcff.png&r=x","gravatar_id":"25c35602d121479ba4365586bb958505","url":"https://api.github.com/users/dannyclark","html_url":"https://github.com/dannyclark","followers_url":"https://api.github.com/users/dannyclark/followers","following_url":"https://api.github.com/users/dannyclark/following{/other_user}","gists_url":"https://api.github.com/users/dannyclark/gists{/gist_id}","starred_url":"https://api.github.com/users/dannyclark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dannyclark/subscriptions","organizations_url":"https://api.github.com/users/dannyclark/orgs","repos_url":"https://api.github.com/users/dannyclark/repos","events_url":"https://api.github.com/users/dannyclark/events{/privacy}","received_events_url":"https://api.github.com/users/dannyclark/received_events","type":"User","site_admin":false},"repo":{"id":15812276,"name":"ninja_timeofday","full_name":"dannyclark/ninja_timeofday","owner":{"login":"dannyclark","id":441920,"avatar_url":"https://gravatar.com/avatar/25c35602d121479ba4365586bb958505?d=https%3A%2F%2Fidenticons.github.com%2F85e825270a12a4fb87b205d9e7badcff.png&r=x","gravatar_id":"25c35602d121479ba4365586bb958505","url":"https://api.github.com/users/dannyclark","html_url":"https://github.com/dannyclark","followers_url":"https://api.github.com/users/dannyclark/followers","following_url":"https://api.github.com/users/dannyclark/following{/other_user}","gists_url":"https://api.github.com/users/dannyclark/gists{/gist_id}","starred_url":"https://api.github.com/users/dannyclark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dannyclark/subscriptions","organizations_url":"https://api.github.com/users/dannyclark/orgs","repos_url":"https://api.github.com/users/dannyclark/repos","events_url":"https://api.github.com/users/dannyclark/events{/privacy}","received_events_url":"https://api.github.com/users/dannyclark/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dannyclark/ninja_timeofday","description":"","fork":true,"url":"https://api.github.com/repos/dannyclark/ninja_timeofday","forks_url":"https://api.github.com/repos/dannyclark/ninja_timeofday/forks","keys_url":"https://api.github.com/repos/dannyclark/ninja_timeofday/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dannyclark/ninja_timeofday/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dannyclark/ninja_timeofday/teams","hooks_url":"https://api.github.com/repos/dannyclark/ninja_timeofday/hooks","issue_events_url":"https://api.github.com/repos/dannyclark/ninja_timeofday/issues/events{/number}","events_url":"https://api.github.com/repos/dannyclark/ninja_timeofday/events","assignees_url":"https://api.github.com/repos/dannyclark/ninja_timeofday/assignees{/user}","branches_url":"https://api.github.com/repos/dannyclark/ninja_timeofday/branches{/branch}","tags_url":"https://api.github.com/repos/dannyclark/ninja_timeofday/tags","blobs_url":"https://api.github.com/repos/dannyclark/ninja_timeofday/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dannyclark/ninja_timeofday/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dannyclark/ninja_timeofday/git/refs{/sha}","trees_url":"https://api.github.com/repos/dannyclark/ninja_timeofday/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dannyclark/ninja_timeofday/statuses/{sha}","languages_url":"https://api.github.com/repos/dannyclark/ninja_timeofday/languages","stargazers_url":"https://api.github.com/repos/dannyclark/ninja_timeofday/stargazers","contributors_url":"https://api.github.com/repos/dannyclark/ninja_timeofday/contributors","subscribers_url":"https://api.github.com/repos/dannyclark/ninja_timeofday/subscribers","subscription_url":"https://api.github.com/repos/dannyclark/ninja_timeofday/subscription","commits_url":"https://api.github.com/repos/dannyclark/ninja_timeofday/commits{/sha}","git_commits_url":"https://api.github.com/repos/dannyclark/ninja_timeofday/git/commits{/sha}","comments_url":"https://api.github.com/repos/dannyclark/ninja_timeofday/comments{/number}","issue_comment_url":"https://api.github.com/repos/dannyclark/ninja_timeofday/issues/comments/{number}","contents_url":"https://api.github.com/repos/dannyclark/ninja_timeofday/contents/{+path}","compare_url":"https://api.github.com/repos/dannyclark/ninja_timeofday/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dannyclark/ninja_timeofday/merges","archive_url":"https://api.github.com/repos/dannyclark/ninja_timeofday/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dannyclark/ninja_timeofday/downloads","issues_url":"https://api.github.com/repos/dannyclark/ninja_timeofday/issues{/number}","pulls_url":"https://api.github.com/repos/dannyclark/ninja_timeofday/pulls{/number}","milestones_url":"https://api.github.com/repos/dannyclark/ninja_timeofday/milestones{/number}","notifications_url":"https://api.github.com/repos/dannyclark/ninja_timeofday/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dannyclark/ninja_timeofday/labels{/name}","releases_url":"https://api.github.com/repos/dannyclark/ninja_timeofday/releases{/id}","created_at":"2014-01-10T22:58:46Z","updated_at":"2014-01-11T03:21:00Z","pushed_at":"2014-01-10T23:02:53Z","git_url":"git://github.com/dannyclark/ninja_timeofday.git","ssh_url":"git@github.com:dannyclark/ninja_timeofday.git","clone_url":"https://github.com/dannyclark/ninja_timeofday.git","svn_url":"https://github.com/dannyclark/ninja_timeofday","homepage":null,"size":164,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"chrisn-au:master","ref":"master","sha":"15985e6e1532481a26c6fb4e3616701eb1b90edf","user":{"login":"chrisn-au","id":3387744,"avatar_url":"https://gravatar.com/avatar/4381a9808aa50677b4adde3739f79a57?d=https%3A%2F%2Fidenticons.github.com%2F1dd944926d18943bb66104a2ba040416.png&r=x","gravatar_id":"4381a9808aa50677b4adde3739f79a57","url":"https://api.github.com/users/chrisn-au","html_url":"https://github.com/chrisn-au","followers_url":"https://api.github.com/users/chrisn-au/followers","following_url":"https://api.github.com/users/chrisn-au/following{/other_user}","gists_url":"https://api.github.com/users/chrisn-au/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisn-au/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisn-au/subscriptions","organizations_url":"https://api.github.com/users/chrisn-au/orgs","repos_url":"https://api.github.com/users/chrisn-au/repos","events_url":"https://api.github.com/users/chrisn-au/events{/privacy}","received_events_url":"https://api.github.com/users/chrisn-au/received_events","type":"User","site_admin":false},"repo":{"id":13432164,"name":"ninja_timeofday","full_name":"chrisn-au/ninja_timeofday","owner":{"login":"chrisn-au","id":3387744,"avatar_url":"https://gravatar.com/avatar/4381a9808aa50677b4adde3739f79a57?d=https%3A%2F%2Fidenticons.github.com%2F1dd944926d18943bb66104a2ba040416.png&r=x","gravatar_id":"4381a9808aa50677b4adde3739f79a57","url":"https://api.github.com/users/chrisn-au","html_url":"https://github.com/chrisn-au","followers_url":"https://api.github.com/users/chrisn-au/followers","following_url":"https://api.github.com/users/chrisn-au/following{/other_user}","gists_url":"https://api.github.com/users/chrisn-au/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisn-au/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisn-au/subscriptions","organizations_url":"https://api.github.com/users/chrisn-au/orgs","repos_url":"https://api.github.com/users/chrisn-au/repos","events_url":"https://api.github.com/users/chrisn-au/events{/privacy}","received_events_url":"https://api.github.com/users/chrisn-au/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chrisn-au/ninja_timeofday","description":"","fork":false,"url":"https://api.github.com/repos/chrisn-au/ninja_timeofday","forks_url":"https://api.github.com/repos/chrisn-au/ninja_timeofday/forks","keys_url":"https://api.github.com/repos/chrisn-au/ninja_timeofday/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chrisn-au/ninja_timeofday/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chrisn-au/ninja_timeofday/teams","hooks_url":"https://api.github.com/repos/chrisn-au/ninja_timeofday/hooks","issue_events_url":"https://api.github.com/repos/chrisn-au/ninja_timeofday/issues/events{/number}","events_url":"https://api.github.com/repos/chrisn-au/ninja_timeofday/events","assignees_url":"https://api.github.com/repos/chrisn-au/ninja_timeofday/assignees{/user}","branches_url":"https://api.github.com/repos/chrisn-au/ninja_timeofday/branches{/branch}","tags_url":"https://api.github.com/repos/chrisn-au/ninja_timeofday/tags","blobs_url":"https://api.github.com/repos/chrisn-au/ninja_timeofday/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chrisn-au/ninja_timeofday/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chrisn-au/ninja_timeofday/git/refs{/sha}","trees_url":"https://api.github.com/repos/chrisn-au/ninja_timeofday/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chrisn-au/ninja_timeofday/statuses/{sha}","languages_url":"https://api.github.com/repos/chrisn-au/ninja_timeofday/languages","stargazers_url":"https://api.github.com/repos/chrisn-au/ninja_timeofday/stargazers","contributors_url":"https://api.github.com/repos/chrisn-au/ninja_timeofday/contributors","subscribers_url":"https://api.github.com/repos/chrisn-au/ninja_timeofday/subscribers","subscription_url":"https://api.github.com/repos/chrisn-au/ninja_timeofday/subscription","commits_url":"https://api.github.com/repos/chrisn-au/ninja_timeofday/commits{/sha}","git_commits_url":"https://api.github.com/repos/chrisn-au/ninja_timeofday/git/commits{/sha}","comments_url":"https://api.github.com/repos/chrisn-au/ninja_timeofday/comments{/number}","issue_comment_url":"https://api.github.com/repos/chrisn-au/ninja_timeofday/issues/comments/{number}","contents_url":"https://api.github.com/repos/chrisn-au/ninja_timeofday/contents/{+path}","compare_url":"https://api.github.com/repos/chrisn-au/ninja_timeofday/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chrisn-au/ninja_timeofday/merges","archive_url":"https://api.github.com/repos/chrisn-au/ninja_timeofday/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chrisn-au/ninja_timeofday/downloads","issues_url":"https://api.github.com/repos/chrisn-au/ninja_timeofday/issues{/number}","pulls_url":"https://api.github.com/repos/chrisn-au/ninja_timeofday/pulls{/number}","milestones_url":"https://api.github.com/repos/chrisn-au/ninja_timeofday/milestones{/number}","notifications_url":"https://api.github.com/repos/chrisn-au/ninja_timeofday/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chrisn-au/ninja_timeofday/labels{/name}","releases_url":"https://api.github.com/repos/chrisn-au/ninja_timeofday/releases{/id}","created_at":"2013-10-09T03:30:46Z","updated_at":"2014-01-11T03:21:00Z","pushed_at":"2014-01-11T03:21:00Z","git_url":"git://github.com/chrisn-au/ninja_timeofday.git","ssh_url":"git@github.com:chrisn-au/ninja_timeofday.git","clone_url":"https://github.com/chrisn-au/ninja_timeofday.git","svn_url":"https://github.com/chrisn-au/ninja_timeofday","homepage":null,"size":164,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":3,"mirror_url":null,"open_issues_count":0,"forks":3,"open_issues":0,"watchers":2,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chrisn-au/ninja_timeofday/pulls/2"},"html":{"href":"https://github.com/chrisn-au/ninja_timeofday/pull/2"},"issue":{"href":"https://api.github.com/repos/chrisn-au/ninja_timeofday/issues/2"},"comments":{"href":"https://api.github.com/repos/chrisn-au/ninja_timeofday/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/chrisn-au/ninja_timeofday/pulls/2/comments"},"statuses":{"href":"https://api.github.com/repos/chrisn-au/ninja_timeofday/statuses/fb68fecc83c333062e8393da6e9848c6e1d0a8b5"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"chrisn-au","id":3387744,"avatar_url":"https://gravatar.com/avatar/4381a9808aa50677b4adde3739f79a57?d=https%3A%2F%2Fidenticons.github.com%2F1dd944926d18943bb66104a2ba040416.png&r=x","gravatar_id":"4381a9808aa50677b4adde3739f79a57","url":"https://api.github.com/users/chrisn-au","html_url":"https://github.com/chrisn-au","followers_url":"https://api.github.com/users/chrisn-au/followers","following_url":"https://api.github.com/users/chrisn-au/following{/other_user}","gists_url":"https://api.github.com/users/chrisn-au/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisn-au/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisn-au/subscriptions","organizations_url":"https://api.github.com/users/chrisn-au/orgs","repos_url":"https://api.github.com/users/chrisn-au/repos","events_url":"https://api.github.com/users/chrisn-au/events{/privacy}","received_events_url":"https://api.github.com/users/chrisn-au/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":14,"deletions":7,"changed_files":2}}