GitHub PullRequestEvent at 2014-11-26 01:17:36
Repository: docker
Actor: crosbymichael
Payload: {"action":"closed","number":8767,"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/8767","id":23327191,"html_url":"https://github.com/docker/docker/pull/8767","diff_url":"https://github.com/docker/docker/pull/8767.diff","patch_url":"https://github.com/docker/docker/pull/8767.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/8767","number":8767,"state":"closed","locked":false,"title":"Links test cleanup","user":{"login":"erikh","id":18923,"avatar_url":"https://avatars.githubusercontent.com/u/18923?v=3","gravatar_id":"","url":"https://api.github.com/users/erikh","html_url":"https://github.com/erikh","followers_url":"https://api.github.com/users/erikh/followers","following_url":"https://api.github.com/users/erikh/following{/other_user}","gists_url":"https://api.github.com/users/erikh/gists{/gist_id}","starred_url":"https://api.github.com/users/erikh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikh/subscriptions","organizations_url":"https://api.github.com/users/erikh/orgs","repos_url":"https://api.github.com/users/erikh/repos","events_url":"https://api.github.com/users/erikh/events{/privacy}","received_events_url":"https://api.github.com/users/erikh/received_events","type":"User","site_admin":false},"body":"While debugging #8721 I noticed there was some opportunity for cleaning up and writing another test for this functionality.\r\n\r\n* new test to ensure hosts files are being injected properly\r\n* refactoring some common functionality into methods.\r\n\r\n/cc @tiborvass @LK4D4 ","created_at":"2014-10-24T21:51:22Z","updated_at":"2014-11-26T01:17:35Z","closed_at":"2014-11-26T01:17:35Z","merged_at":"2014-11-26T01:17:35Z","merge_commit_sha":"ad192516002e0f6a7f188fcb6818f6f1b5a80fbd","assignee":null,"milestone":{"url":"https://api.github.com/repos/docker/docker/milestones/30","labels_url":"https://api.github.com/repos/docker/docker/milestones/30/labels","id":802943,"number":30,"title":"1.4","description":"Docker 1.4 Release Milestone","creator":{"login":"crosbymichael","id":749551,"avatar_url":"https://avatars.githubusercontent.com/u/749551?v=3","gravatar_id":"","url":"https://api.github.com/users/crosbymichael","html_url":"https://github.com/crosbymichael","followers_url":"https://api.github.com/users/crosbymichael/followers","following_url":"https://api.github.com/users/crosbymichael/following{/other_user}","gists_url":"https://api.github.com/users/crosbymichael/gists{/gist_id}","starred_url":"https://api.github.com/users/crosbymichael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crosbymichael/subscriptions","organizations_url":"https://api.github.com/users/crosbymichael/orgs","repos_url":"https://api.github.com/users/crosbymichael/repos","events_url":"https://api.github.com/users/crosbymichael/events{/privacy}","received_events_url":"https://api.github.com/users/crosbymichael/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":38,"state":"open","created_at":"2014-09-25T17:35:20Z","updated_at":"2014-11-26T01:17:35Z","due_on":"2014-12-02T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/docker/docker/pulls/8767/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/8767/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments/{number}","comments_url":"https://api.github.com/repos/docker/docker/issues/8767/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/68bc8de111e4faa2a16583cd45b5c0fd253a3bba","head":{"label":"erikh:update_parents_hosts_part2","ref":"update_parents_hosts_part2","sha":"68bc8de111e4faa2a16583cd45b5c0fd253a3bba","user":{"login":"erikh","id":18923,"avatar_url":"https://avatars.githubusercontent.com/u/18923?v=3","gravatar_id":"","url":"https://api.github.com/users/erikh","html_url":"https://github.com/erikh","followers_url":"https://api.github.com/users/erikh/followers","following_url":"https://api.github.com/users/erikh/following{/other_user}","gists_url":"https://api.github.com/users/erikh/gists{/gist_id}","starred_url":"https://api.github.com/users/erikh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikh/subscriptions","organizations_url":"https://api.github.com/users/erikh/orgs","repos_url":"https://api.github.com/users/erikh/repos","events_url":"https://api.github.com/users/erikh/events{/privacy}","received_events_url":"https://api.github.com/users/erikh/received_events","type":"User","site_admin":false},"repo":{"id":17471699,"name":"docker","full_name":"erikh/docker","owner":{"login":"erikh","id":18923,"avatar_url":"https://avatars.githubusercontent.com/u/18923?v=3","gravatar_id":"","url":"https://api.github.com/users/erikh","html_url":"https://github.com/erikh","followers_url":"https://api.github.com/users/erikh/followers","following_url":"https://api.github.com/users/erikh/following{/other_user}","gists_url":"https://api.github.com/users/erikh/gists{/gist_id}","starred_url":"https://api.github.com/users/erikh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikh/subscriptions","organizations_url":"https://api.github.com/users/erikh/orgs","repos_url":"https://api.github.com/users/erikh/repos","events_url":"https://api.github.com/users/erikh/events{/privacy}","received_events_url":"https://api.github.com/users/erikh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/erikh/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/erikh/docker","forks_url":"https://api.github.com/repos/erikh/docker/forks","keys_url":"https://api.github.com/repos/erikh/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/erikh/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/erikh/docker/teams","hooks_url":"https://api.github.com/repos/erikh/docker/hooks","issue_events_url":"https://api.github.com/repos/erikh/docker/issues/events{/number}","events_url":"https://api.github.com/repos/erikh/docker/events","assignees_url":"https://api.github.com/repos/erikh/docker/assignees{/user}","branches_url":"https://api.github.com/repos/erikh/docker/branches{/branch}","tags_url":"https://api.github.com/repos/erikh/docker/tags","blobs_url":"https://api.github.com/repos/erikh/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/erikh/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/erikh/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/erikh/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/erikh/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/erikh/docker/languages","stargazers_url":"https://api.github.com/repos/erikh/docker/stargazers","contributors_url":"https://api.github.com/repos/erikh/docker/contributors","subscribers_url":"https://api.github.com/repos/erikh/docker/subscribers","subscription_url":"https://api.github.com/repos/erikh/docker/subscription","commits_url":"https://api.github.com/repos/erikh/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/erikh/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/erikh/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/erikh/docker/issues/comments/{number}","contents_url":"https://api.github.com/repos/erikh/docker/contents/{+path}","compare_url":"https://api.github.com/repos/erikh/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/erikh/docker/merges","archive_url":"https://api.github.com/repos/erikh/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/erikh/docker/downloads","issues_url":"https://api.github.com/repos/erikh/docker/issues{/number}","pulls_url":"https://api.github.com/repos/erikh/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/erikh/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/erikh/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/erikh/docker/labels{/name}","releases_url":"https://api.github.com/repos/erikh/docker/releases{/id}","created_at":"2014-03-06T08:54:07Z","updated_at":"2014-07-03T07:21:47Z","pushed_at":"2014-11-26T00:48:45Z","git_url":"git://github.com/erikh/docker.git","ssh_url":"git@github.com:erikh/docker.git","clone_url":"https://github.com/erikh/docker.git","svn_url":"https://github.com/erikh/docker","homepage":"http://www.docker.io","size":40200,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"1eb5e5d25faac6ef175285fb8606484928309802","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments/{number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","created_at":"2013-01-18T18:10:57Z","updated_at":"2014-11-26T01:04:26Z","pushed_at":"2014-11-26T01:17:35Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":162620,"stargazers_count":16996,"watchers_count":16996,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3376,"mirror_url":null,"open_issues_count":904,"forks":3376,"open_issues":904,"watchers":16996,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/8767"},"html":{"href":"https://github.com/docker/docker/pull/8767"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/8767"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/8767/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/8767/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/8767/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/68bc8de111e4faa2a16583cd45b5c0fd253a3bba"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"crosbymichael","id":749551,"avatar_url":"https://avatars.githubusercontent.com/u/749551?v=3","gravatar_id":"","url":"https://api.github.com/users/crosbymichael","html_url":"https://github.com/crosbymichael","followers_url":"https://api.github.com/users/crosbymichael/followers","following_url":"https://api.github.com/users/crosbymichael/following{/other_user}","gists_url":"https://api.github.com/users/crosbymichael/gists{/gist_id}","starred_url":"https://api.github.com/users/crosbymichael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crosbymichael/subscriptions","organizations_url":"https://api.github.com/users/crosbymichael/orgs","repos_url":"https://api.github.com/users/crosbymichael/repos","events_url":"https://api.github.com/users/crosbymichael/events{/privacy}","received_events_url":"https://api.github.com/users/crosbymichael/received_events","type":"User","site_admin":false},"comments":5,"review_comments":4,"commits":2,"additions":80,"deletions":21,"changed_files":4}}