GitHub PullRequestReviewCommentEvent at 2014-01-29 15:53:05
Repository: gaia
Actor: fabi1cazenave
Payload: {"comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/9270947","id":9270947,"diff_hunk":"@@ -362,33 +362,74 @@ form button::-moz-focus-inner {\n  * Right-to-Left layout\n  */\n \n-html[dir=\"rtl\"] form p input:valid,\n-html[dir=\"rtl\"] form p input:valid:focus {\n-  padding: 0 1.2rem 0 3rem;\n-}\n-\n html[dir=\"rtl\"] form p input + button[type=\"reset\"],\n-html[dir=\"rtl\"] form p textarea + button[type=\"reset\"] {\n-  right: auto;\n+form p textarea + button[type=\"reset\"] {\n   left: 0;\n+  right: auto;\n }\n \n-html[dir=\"rtl\"] fieldset legend.action:after {\n-  margin: 0 0.5rem 0 0;\n+html[dir=\"rtl\"] form p input:focus {\n+  padding-left: 3rem;\n+  padding-right: inherit;\n }\n \n html[dir=\"rtl\"] fieldset legend {\n-  padding: 0 1.5rem 0 0.5rem;\n+  padding-right: 1.5rem;\n+  padding-left: .5rem;\n }\n \n-html[dir=\"rtl\"] form[role=\"search\"] p input {\n-  padding: 0;\n+html[dir=\"rtl\"] fieldset section {\n+  border-right: 0.1rem solid #ddd;\n+  border-left: none;\n+  border-radius: 0.3rem 0 0 0.3rem;\n+  margin-right: 9.5rem;\n+  margin-left: auto;\n+}\n+\n+html[dir=\"rtl\"] form[role=\"search\"]:before {\n+  right: 1rem;\n+  left: auto;\n+}\n+\n+html[dir=\"rtl\"] form[role=\"search\"] p {\n+  padding-right: 3.2rem;\n+  padding-left: 1.2rem;\n }\n \n html[dir=\"rtl\"] form[role=\"search\"] p input:focus {\n-  padding: 0 0 0 2rem;\n+  padding-right: 0;\n+  padding-left: 2rem;\n }\n \n-html[dir=\"rtl\"] form[role=\"search\"] button[type=\"submit\"] + p > button {\n+html[dir=\"rtl\"] form[role=\"search\"] button.icon {\n+  float: right;\n+  background-position: 0 50%, 0 100%;\n+}\n+\n+html[dir=\"rtl\"] form[role=\"search\"] button.icon:before {\n+  right: 0;\n+  left: auto;\n+}\n+\n+html[dir=\"rtl\"] form[role=\"search\"] p button[type=\"reset\"] {\n   left: 0;\n+  right: auto;\n }\n+\n+html[dir=\"rtl\"] form[role=\"search\"] button[type=\"submit\"] {\n+  float: left;\n+  background-position: 100% 50%;\n+}\n+\n+html[dir=\"rtl\"] fieldset legend.action {\n+  background-position: 0 100%;\n+}\n+\n+html[dir=\"rtl\"] form[role=\"search\"] button[type=\"submit\"][disabled] {\n+  background-position: 100% 50%, 0 100%;\n+}\n+\n+html[dir=\"rtl\"] form[role=\"search\"].bottom button[type=\"submit\"] {\n+  background-position: 100% 50%, 0 100%;\n+}","path":"shared/style/input_areas.css","position":87,"original_position":87,"commit_id":"7d4cc08efea3af46a191c964bd15b17e95e91343","original_commit_id":"7d4cc08efea3af46a191c964bd15b17e95e91343","user":{"login":"fabi1cazenave","id":457778,"avatar_url":"https://gravatar.com/avatar/aec50e19b6e10e548965786197d4e620?d=https%3A%2F%2Fidenticons.github.com%2F3f0d47ccd722e53ffca16d2f13cf0f1a.png&r=x","gravatar_id":"aec50e19b6e10e548965786197d4e620","url":"https://api.github.com/users/fabi1cazenave","html_url":"https://github.com/fabi1cazenave","followers_url":"https://api.github.com/users/fabi1cazenave/followers","following_url":"https://api.github.com/users/fabi1cazenave/following{/other_user}","gists_url":"https://api.github.com/users/fabi1cazenave/gists{/gist_id}","starred_url":"https://api.github.com/users/fabi1cazenave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabi1cazenave/subscriptions","organizations_url":"https://api.github.com/users/fabi1cazenave/orgs","repos_url":"https://api.github.com/users/fabi1cazenave/repos","events_url":"https://api.github.com/users/fabi1cazenave/events{/privacy}","received_events_url":"https://api.github.com/users/fabi1cazenave/received_events","type":"User","site_admin":false},"body":"nit: please factorize\r\n```css\r\nhtml[dir=\"rtl\"] form[role=\"search\"] button[type=\"submit\"][disabled],\r\nhtml[dir=\"rtl\"] form[role=\"search\"].bottom button[type=\"submit\"] {\r\n  background-position: 100% 50%, 0 100%;\r\n}\r\n```","created_at":"2014-01-29T15:53:05Z","updated_at":"2014-01-29T15:53:05Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/15693#discussion_r9270947","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/15693","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/9270947"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/15693#discussion_r9270947"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/15693"}}}}