GitHub PullRequestReviewCommentEvent at 2014-07-29 16:05:11
Repository: xbmc
Actor: wsnipex
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/15533067","id":15533067,"diff_hunk":"@@ -387,13 +387,30 @@ if test \"$platform_os\" == \"android\"; then\n     AC_MSG_ERROR(\"SDK path is required for android\")\n   fi\n \n-  if [ ! test -f $use_sdk_path/tools/zipalign ]; then\n+  if [ ! test -f $use_sdk_path/tools/android ]; then\n     AC_MSG_ERROR(verify sdk path)\n   fi\n \n   if [ ! test -f $use_ndk/sources/android/native_app_glue/android_native_app_glue.h ]; then\n     AC_MSG_ERROR(verify ndk path)\n   fi\n+\n+  build_tools_path=$use_sdk_path/build-tools/`ls $use_sdk_path/build-tools | sort -V | tail -n 1`\n+\n+  AC_PATH_PROG(AAPT,aapt,\"no\",$build_tools_path)\n+  if test \"x$AAPT\" = \"xno\" ; then\n+    AC_MSG_ERROR(\"Missing program: aapt\")\n+  fi\n+\n+  AC_PATH_PROG(DX,dx,\"no\",$build_tools_path)\n+  if test \"x$DX\" = \"xno\" ; then\n+    AC_MSG_ERROR(\"Missing program: dx\")\n+  fi\n+\n+  AC_PATH_PROG(ZIPALIGN,zipalign,\"no\",$build_tools_path)\n+  if test \"x$ZIPALIGN\" = \"xno\" ; then\n+    AC_MSG_ERROR(\"Missing program: zipalign\")\n+  fi","path":"tools/depends/configure.in","position":28,"original_position":28,"commit_id":"5152ef87986a1304549124deee59d378edd5467d","original_commit_id":"5152ef87986a1304549124deee59d378edd5467d","user":{"login":"wsnipex","id":909455,"avatar_url":"https://avatars.githubusercontent.com/u/909455?","gravatar_id":"5bed488f66f4834fbae3955e1c4ebe4d","url":"https://api.github.com/users/wsnipex","html_url":"https://github.com/wsnipex","followers_url":"https://api.github.com/users/wsnipex/followers","following_url":"https://api.github.com/users/wsnipex/following{/other_user}","gists_url":"https://api.github.com/users/wsnipex/gists{/gist_id}","starred_url":"https://api.github.com/users/wsnipex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wsnipex/subscriptions","organizations_url":"https://api.github.com/users/wsnipex/orgs","repos_url":"https://api.github.com/users/wsnipex/repos","events_url":"https://api.github.com/users/wsnipex/events{/privacy}","received_events_url":"https://api.github.com/users/wsnipex/received_events","type":"User","site_admin":false},"body":"imho its correct to check for all tools we need. there's always a possibility that stuff is missing for one reason or another","created_at":"2014-07-29T16:05:11Z","updated_at":"2014-07-29T16:05:11Z","html_url":"https://github.com/xbmc/xbmc/pull/5109#discussion_r15533067","pull_request_url":"https://api.github.com/repos/xbmc/xbmc/pulls/5109","_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/15533067"},"html":{"href":"https://github.com/xbmc/xbmc/pull/5109#discussion_r15533067"},"pull_request":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/5109"}}},"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/5109","id":18979659,"html_url":"https://github.com/xbmc/xbmc/pull/5109","diff_url":"https://github.com/xbmc/xbmc/pull/5109.diff","patch_url":"https://github.com/xbmc/xbmc/pull/5109.patch","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/5109","number":5109,"state":"open","title":"Improvements in Android building process","user":{"login":"Kuci","id":2872098,"avatar_url":"https://avatars.githubusercontent.com/u/2872098?","gravatar_id":"da178d92e1b1f9f6186a40ada460312a","url":"https://api.github.com/users/Kuci","html_url":"https://github.com/Kuci","followers_url":"https://api.github.com/users/Kuci/followers","following_url":"https://api.github.com/users/Kuci/following{/other_user}","gists_url":"https://api.github.com/users/Kuci/gists{/gist_id}","starred_url":"https://api.github.com/users/Kuci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kuci/subscriptions","organizations_url":"https://api.github.com/users/Kuci/orgs","repos_url":"https://api.github.com/users/Kuci/repos","events_url":"https://api.github.com/users/Kuci/events{/privacy}","received_events_url":"https://api.github.com/users/Kuci/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-07-28T17:01:16Z","updated_at":"2014-07-29T16:05:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d57c4344d18d5b71be1c44661657760c53bedbb0","assignee":null,"milestone":{"url":"https://api.github.com/repos/xbmc/xbmc/milestones/26","labels_url":"https://api.github.com/repos/xbmc/xbmc/milestones/26/labels","id":396004,"number":26,"title":"Pending for inclusion","description":"","creator":{"login":"MartijnKaijser","id":907436,"avatar_url":"https://avatars.githubusercontent.com/u/907436?","gravatar_id":"4a668c97a68a4bbdcb2d40da2ea4029e","url":"https://api.github.com/users/MartijnKaijser","html_url":"https://github.com/MartijnKaijser","followers_url":"https://api.github.com/users/MartijnKaijser/followers","following_url":"https://api.github.com/users/MartijnKaijser/following{/other_user}","gists_url":"https://api.github.com/users/MartijnKaijser/gists{/gist_id}","starred_url":"https://api.github.com/users/MartijnKaijser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartijnKaijser/subscriptions","organizations_url":"https://api.github.com/users/MartijnKaijser/orgs","repos_url":"https://api.github.com/users/MartijnKaijser/repos","events_url":"https://api.github.com/users/MartijnKaijser/events{/privacy}","received_events_url":"https://api.github.com/users/MartijnKaijser/received_events","type":"User","site_admin":false},"open_issues":147,"closed_issues":1,"state":"open","created_at":"2013-08-06T19:03:23Z","updated_at":"2014-07-29T09:00:16Z","due_on":null},"commits_url":"https://api.github.com/repos/xbmc/xbmc/pulls/5109/commits","review_comments_url":"https://api.github.com/repos/xbmc/xbmc/pulls/5109/comments","review_comment_url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/{number}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/5109/comments","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/5152ef87986a1304549124deee59d378edd5467d","head":{"label":"Kuci:master","ref":"master","sha":"5152ef87986a1304549124deee59d378edd5467d","user":{"login":"Kuci","id":2872098,"avatar_url":"https://avatars.githubusercontent.com/u/2872098?","gravatar_id":"da178d92e1b1f9f6186a40ada460312a","url":"https://api.github.com/users/Kuci","html_url":"https://github.com/Kuci","followers_url":"https://api.github.com/users/Kuci/followers","following_url":"https://api.github.com/users/Kuci/following{/other_user}","gists_url":"https://api.github.com/users/Kuci/gists{/gist_id}","starred_url":"https://api.github.com/users/Kuci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kuci/subscriptions","organizations_url":"https://api.github.com/users/Kuci/orgs","repos_url":"https://api.github.com/users/Kuci/repos","events_url":"https://api.github.com/users/Kuci/events{/privacy}","received_events_url":"https://api.github.com/users/Kuci/received_events","type":"User","site_admin":false},"repo":{"id":22307130,"name":"xbmc","full_name":"Kuci/xbmc","owner":{"login":"Kuci","id":2872098,"avatar_url":"https://avatars.githubusercontent.com/u/2872098?","gravatar_id":"da178d92e1b1f9f6186a40ada460312a","url":"https://api.github.com/users/Kuci","html_url":"https://github.com/Kuci","followers_url":"https://api.github.com/users/Kuci/followers","following_url":"https://api.github.com/users/Kuci/following{/other_user}","gists_url":"https://api.github.com/users/Kuci/gists{/gist_id}","starred_url":"https://api.github.com/users/Kuci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kuci/subscriptions","organizations_url":"https://api.github.com/users/Kuci/orgs","repos_url":"https://api.github.com/users/Kuci/repos","events_url":"https://api.github.com/users/Kuci/events{/privacy}","received_events_url":"https://api.github.com/users/Kuci/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Kuci/xbmc","description":"XBMC Main Repository","fork":true,"url":"https://api.github.com/repos/Kuci/xbmc","forks_url":"https://api.github.com/repos/Kuci/xbmc/forks","keys_url":"https://api.github.com/repos/Kuci/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kuci/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kuci/xbmc/teams","hooks_url":"https://api.github.com/repos/Kuci/xbmc/hooks","issue_events_url":"https://api.github.com/repos/Kuci/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/Kuci/xbmc/events","assignees_url":"https://api.github.com/repos/Kuci/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/Kuci/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/Kuci/xbmc/tags","blobs_url":"https://api.github.com/repos/Kuci/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kuci/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kuci/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kuci/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kuci/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/Kuci/xbmc/languages","stargazers_url":"https://api.github.com/repos/Kuci/xbmc/stargazers","contributors_url":"https://api.github.com/repos/Kuci/xbmc/contributors","subscribers_url":"https://api.github.com/repos/Kuci/xbmc/subscribers","subscription_url":"https://api.github.com/repos/Kuci/xbmc/subscription","commits_url":"https://api.github.com/repos/Kuci/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kuci/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kuci/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kuci/xbmc/issues/comments/{number}","contents_url":"https://api.github.com/repos/Kuci/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/Kuci/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kuci/xbmc/merges","archive_url":"https://api.github.com/repos/Kuci/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kuci/xbmc/downloads","issues_url":"https://api.github.com/repos/Kuci/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/Kuci/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/Kuci/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/Kuci/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kuci/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/Kuci/xbmc/releases{/id}","created_at":"2014-07-27T08:59:32Z","updated_at":"2014-07-27T09:33:12Z","pushed_at":"2014-07-29T13:23:43Z","git_url":"git://github.com/Kuci/xbmc.git","ssh_url":"git@github.com:Kuci/xbmc.git","clone_url":"https://github.com/Kuci/xbmc.git","svn_url":"https://github.com/Kuci/xbmc","homepage":"http://xbmc.org","size":464354,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xbmc:master","ref":"master","sha":"d36512390231a9c8e9f3e16dbe779c105f4b1fbb","user":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?","gravatar_id":"8a14492c66bf09a3016b416347a5dcc9","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"repo":{"id":1217614,"name":"xbmc","full_name":"xbmc/xbmc","owner":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?","gravatar_id":"8a14492c66bf09a3016b416347a5dcc9","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xbmc/xbmc","description":"XBMC Main Repository","fork":false,"url":"https://api.github.com/repos/xbmc/xbmc","forks_url":"https://api.github.com/repos/xbmc/xbmc/forks","keys_url":"https://api.github.com/repos/xbmc/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xbmc/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xbmc/xbmc/teams","hooks_url":"https://api.github.com/repos/xbmc/xbmc/hooks","issue_events_url":"https://api.github.com/repos/xbmc/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/xbmc/xbmc/events","assignees_url":"https://api.github.com/repos/xbmc/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/xbmc/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/xbmc/xbmc/tags","blobs_url":"https://api.github.com/repos/xbmc/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xbmc/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xbmc/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/xbmc/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/xbmc/xbmc/languages","stargazers_url":"https://api.github.com/repos/xbmc/xbmc/stargazers","contributors_url":"https://api.github.com/repos/xbmc/xbmc/contributors","subscribers_url":"https://api.github.com/repos/xbmc/xbmc/subscribers","subscription_url":"https://api.github.com/repos/xbmc/xbmc/subscription","commits_url":"https://api.github.com/repos/xbmc/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/xbmc/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/xbmc/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/xbmc/xbmc/issues/comments/{number}","contents_url":"https://api.github.com/repos/xbmc/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/xbmc/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xbmc/xbmc/merges","archive_url":"https://api.github.com/repos/xbmc/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xbmc/xbmc/downloads","issues_url":"https://api.github.com/repos/xbmc/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/xbmc/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/xbmc/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/xbmc/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xbmc/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/xbmc/xbmc/releases{/id}","created_at":"2011-01-03T21:18:51Z","updated_at":"2014-07-29T14:12:56Z","pushed_at":"2014-07-27T16:08:08Z","git_url":"git://github.com/xbmc/xbmc.git","ssh_url":"git@github.com:xbmc/xbmc.git","clone_url":"https://github.com/xbmc/xbmc.git","svn_url":"https://github.com/xbmc/xbmc","homepage":"http://xbmc.org","size":1748665,"stargazers_count":3257,"watchers_count":3257,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":2278,"mirror_url":null,"open_issues_count":208,"forks":2278,"open_issues":208,"watchers":3257,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/5109"},"html":{"href":"https://github.com/xbmc/xbmc/pull/5109"},"issue":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/5109"},"comments":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/5109/comments"},"review_comments":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/5109/comments"},"review_comment":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/5109/commits"},"statuses":{"href":"https://api.github.com/repos/xbmc/xbmc/statuses/5152ef87986a1304549124deee59d378edd5467d"}}}}