GitHub PullRequestEvent at 2014-08-20 23:31:59
Repository: generator-kraken
Actor: grawk
Payload: {"action":"closed","number":118,"pull_request":{"url":"https://api.github.com/repos/krakenjs/generator-kraken/pulls/118","id":19866975,"html_url":"https://github.com/krakenjs/generator-kraken/pull/118","diff_url":"https://github.com/krakenjs/generator-kraken/pull/118.diff","patch_url":"https://github.com/krakenjs/generator-kraken/pull/118.patch","issue_url":"https://api.github.com/repos/krakenjs/generator-kraken/issues/118","number":118,"state":"closed","locked":false,"title":"Listen to right post-npm i hook in generator tests.","user":{"login":"jasisk","id":62923,"avatar_url":"https://avatars.githubusercontent.com/u/62923?v=2","gravatar_id":"7fe1a72cb2c8dcf3b58aa243d872d205","url":"https://api.github.com/users/jasisk","html_url":"https://github.com/jasisk","followers_url":"https://api.github.com/users/jasisk/followers","following_url":"https://api.github.com/users/jasisk/following{/other_user}","gists_url":"https://api.github.com/users/jasisk/gists{/gist_id}","starred_url":"https://api.github.com/users/jasisk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasisk/subscriptions","organizations_url":"https://api.github.com/users/jasisk/orgs","repos_url":"https://api.github.com/users/jasisk/repos","events_url":"https://api.github.com/users/jasisk/events{/privacy}","received_events_url":"https://api.github.com/users/jasisk/received_events","type":"User","site_admin":false},"body":"The generator tests have been broken thanks to a bit of race condition. Our tests were waiting for yeoman to emit a `kraken:app:installDependencies` but this event fires at the beginning of an npm install, not at the end.\r\n\r\nChanges to listen to `npmInstall:end` works since that event fires at the right time.\r\n\r\nThis realized a new error on our tests but it's a result of mocha presently being broken.\r\n\r\n`this.timeout(0)` acts differently as of `1.21.0`. This has been been resolved in master but has not yet been pushed. To account for this, currently pegging mocha to `~1.20`.","created_at":"2014-08-15T20:56:14Z","updated_at":"2014-08-20T23:31:59Z","closed_at":"2014-08-20T23:31:59Z","merged_at":"2014-08-20T23:31:59Z","merge_commit_sha":"ec6d42811a974ca58ee9a8705f0808a098a0c0cf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/krakenjs/generator-kraken/pulls/118/commits","review_comments_url":"https://api.github.com/repos/krakenjs/generator-kraken/pulls/118/comments","review_comment_url":"https://api.github.com/repos/krakenjs/generator-kraken/pulls/comments/{number}","comments_url":"https://api.github.com/repos/krakenjs/generator-kraken/issues/118/comments","statuses_url":"https://api.github.com/repos/krakenjs/generator-kraken/statuses/0d89749866d69942e1e1e648246bd96b2297372e","head":{"label":"krakenjs:fix-generator-tests","ref":"fix-generator-tests","sha":"0d89749866d69942e1e1e648246bd96b2297372e","user":{"login":"krakenjs","id":7001600,"avatar_url":"https://avatars.githubusercontent.com/u/7001600?v=2","gravatar_id":"1d26d7b0d143f4b864607cb33ea8241b","url":"https://api.github.com/users/krakenjs","html_url":"https://github.com/krakenjs","followers_url":"https://api.github.com/users/krakenjs/followers","following_url":"https://api.github.com/users/krakenjs/following{/other_user}","gists_url":"https://api.github.com/users/krakenjs/gists{/gist_id}","starred_url":"https://api.github.com/users/krakenjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krakenjs/subscriptions","organizations_url":"https://api.github.com/users/krakenjs/orgs","repos_url":"https://api.github.com/users/krakenjs/repos","events_url":"https://api.github.com/users/krakenjs/events{/privacy}","received_events_url":"https://api.github.com/users/krakenjs/received_events","type":"Organization","site_admin":false},"repo":{"id":13188011,"name":"generator-kraken","full_name":"krakenjs/generator-kraken","owner":{"login":"krakenjs","id":7001600,"avatar_url":"https://avatars.githubusercontent.com/u/7001600?v=2","gravatar_id":"1d26d7b0d143f4b864607cb33ea8241b","url":"https://api.github.com/users/krakenjs","html_url":"https://github.com/krakenjs","followers_url":"https://api.github.com/users/krakenjs/followers","following_url":"https://api.github.com/users/krakenjs/following{/other_user}","gists_url":"https://api.github.com/users/krakenjs/gists{/gist_id}","starred_url":"https://api.github.com/users/krakenjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krakenjs/subscriptions","organizations_url":"https://api.github.com/users/krakenjs/orgs","repos_url":"https://api.github.com/users/krakenjs/repos","events_url":"https://api.github.com/users/krakenjs/events{/privacy}","received_events_url":"https://api.github.com/users/krakenjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/krakenjs/generator-kraken","description":"Yeoman generator for kraken.js apps","fork":false,"url":"https://api.github.com/repos/krakenjs/generator-kraken","forks_url":"https://api.github.com/repos/krakenjs/generator-kraken/forks","keys_url":"https://api.github.com/repos/krakenjs/generator-kraken/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krakenjs/generator-kraken/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krakenjs/generator-kraken/teams","hooks_url":"https://api.github.com/repos/krakenjs/generator-kraken/hooks","issue_events_url":"https://api.github.com/repos/krakenjs/generator-kraken/issues/events{/number}","events_url":"https://api.github.com/repos/krakenjs/generator-kraken/events","assignees_url":"https://api.github.com/repos/krakenjs/generator-kraken/assignees{/user}","branches_url":"https://api.github.com/repos/krakenjs/generator-kraken/branches{/branch}","tags_url":"https://api.github.com/repos/krakenjs/generator-kraken/tags","blobs_url":"https://api.github.com/repos/krakenjs/generator-kraken/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krakenjs/generator-kraken/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krakenjs/generator-kraken/git/refs{/sha}","trees_url":"https://api.github.com/repos/krakenjs/generator-kraken/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krakenjs/generator-kraken/statuses/{sha}","languages_url":"https://api.github.com/repos/krakenjs/generator-kraken/languages","stargazers_url":"https://api.github.com/repos/krakenjs/generator-kraken/stargazers","contributors_url":"https://api.github.com/repos/krakenjs/generator-kraken/contributors","subscribers_url":"https://api.github.com/repos/krakenjs/generator-kraken/subscribers","subscription_url":"https://api.github.com/repos/krakenjs/generator-kraken/subscription","commits_url":"https://api.github.com/repos/krakenjs/generator-kraken/commits{/sha}","git_commits_url":"https://api.github.com/repos/krakenjs/generator-kraken/git/commits{/sha}","comments_url":"https://api.github.com/repos/krakenjs/generator-kraken/comments{/number}","issue_comment_url":"https://api.github.com/repos/krakenjs/generator-kraken/issues/comments/{number}","contents_url":"https://api.github.com/repos/krakenjs/generator-kraken/contents/{+path}","compare_url":"https://api.github.com/repos/krakenjs/generator-kraken/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krakenjs/generator-kraken/merges","archive_url":"https://api.github.com/repos/krakenjs/generator-kraken/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krakenjs/generator-kraken/downloads","issues_url":"https://api.github.com/repos/krakenjs/generator-kraken/issues{/number}","pulls_url":"https://api.github.com/repos/krakenjs/generator-kraken/pulls{/number}","milestones_url":"https://api.github.com/repos/krakenjs/generator-kraken/milestones{/number}","notifications_url":"https://api.github.com/repos/krakenjs/generator-kraken/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krakenjs/generator-kraken/labels{/name}","releases_url":"https://api.github.com/repos/krakenjs/generator-kraken/releases{/id}","created_at":"2013-09-29T06:51:08Z","updated_at":"2014-08-18T12:22:22Z","pushed_at":"2014-08-20T23:31:59Z","git_url":"git://github.com/krakenjs/generator-kraken.git","ssh_url":"git@github.com:krakenjs/generator-kraken.git","clone_url":"https://github.com/krakenjs/generator-kraken.git","svn_url":"https://github.com/krakenjs/generator-kraken","homepage":"","size":2199,"stargazers_count":84,"watchers_count":84,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":35,"mirror_url":null,"open_issues_count":14,"forks":35,"open_issues":14,"watchers":84,"default_branch":"master"}},"base":{"label":"krakenjs:master","ref":"master","sha":"1a961a93d657aa685ce9d8aafe39b1954f95f577","user":{"login":"krakenjs","id":7001600,"avatar_url":"https://avatars.githubusercontent.com/u/7001600?v=2","gravatar_id":"1d26d7b0d143f4b864607cb33ea8241b","url":"https://api.github.com/users/krakenjs","html_url":"https://github.com/krakenjs","followers_url":"https://api.github.com/users/krakenjs/followers","following_url":"https://api.github.com/users/krakenjs/following{/other_user}","gists_url":"https://api.github.com/users/krakenjs/gists{/gist_id}","starred_url":"https://api.github.com/users/krakenjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krakenjs/subscriptions","organizations_url":"https://api.github.com/users/krakenjs/orgs","repos_url":"https://api.github.com/users/krakenjs/repos","events_url":"https://api.github.com/users/krakenjs/events{/privacy}","received_events_url":"https://api.github.com/users/krakenjs/received_events","type":"Organization","site_admin":false},"repo":{"id":13188011,"name":"generator-kraken","full_name":"krakenjs/generator-kraken","owner":{"login":"krakenjs","id":7001600,"avatar_url":"https://avatars.githubusercontent.com/u/7001600?v=2","gravatar_id":"1d26d7b0d143f4b864607cb33ea8241b","url":"https://api.github.com/users/krakenjs","html_url":"https://github.com/krakenjs","followers_url":"https://api.github.com/users/krakenjs/followers","following_url":"https://api.github.com/users/krakenjs/following{/other_user}","gists_url":"https://api.github.com/users/krakenjs/gists{/gist_id}","starred_url":"https://api.github.com/users/krakenjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krakenjs/subscriptions","organizations_url":"https://api.github.com/users/krakenjs/orgs","repos_url":"https://api.github.com/users/krakenjs/repos","events_url":"https://api.github.com/users/krakenjs/events{/privacy}","received_events_url":"https://api.github.com/users/krakenjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/krakenjs/generator-kraken","description":"Yeoman generator for kraken.js apps","fork":false,"url":"https://api.github.com/repos/krakenjs/generator-kraken","forks_url":"https://api.github.com/repos/krakenjs/generator-kraken/forks","keys_url":"https://api.github.com/repos/krakenjs/generator-kraken/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krakenjs/generator-kraken/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krakenjs/generator-kraken/teams","hooks_url":"https://api.github.com/repos/krakenjs/generator-kraken/hooks","issue_events_url":"https://api.github.com/repos/krakenjs/generator-kraken/issues/events{/number}","events_url":"https://api.github.com/repos/krakenjs/generator-kraken/events","assignees_url":"https://api.github.com/repos/krakenjs/generator-kraken/assignees{/user}","branches_url":"https://api.github.com/repos/krakenjs/generator-kraken/branches{/branch}","tags_url":"https://api.github.com/repos/krakenjs/generator-kraken/tags","blobs_url":"https://api.github.com/repos/krakenjs/generator-kraken/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krakenjs/generator-kraken/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krakenjs/generator-kraken/git/refs{/sha}","trees_url":"https://api.github.com/repos/krakenjs/generator-kraken/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krakenjs/generator-kraken/statuses/{sha}","languages_url":"https://api.github.com/repos/krakenjs/generator-kraken/languages","stargazers_url":"https://api.github.com/repos/krakenjs/generator-kraken/stargazers","contributors_url":"https://api.github.com/repos/krakenjs/generator-kraken/contributors","subscribers_url":"https://api.github.com/repos/krakenjs/generator-kraken/subscribers","subscription_url":"https://api.github.com/repos/krakenjs/generator-kraken/subscription","commits_url":"https://api.github.com/repos/krakenjs/generator-kraken/commits{/sha}","git_commits_url":"https://api.github.com/repos/krakenjs/generator-kraken/git/commits{/sha}","comments_url":"https://api.github.com/repos/krakenjs/generator-kraken/comments{/number}","issue_comment_url":"https://api.github.com/repos/krakenjs/generator-kraken/issues/comments/{number}","contents_url":"https://api.github.com/repos/krakenjs/generator-kraken/contents/{+path}","compare_url":"https://api.github.com/repos/krakenjs/generator-kraken/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krakenjs/generator-kraken/merges","archive_url":"https://api.github.com/repos/krakenjs/generator-kraken/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krakenjs/generator-kraken/downloads","issues_url":"https://api.github.com/repos/krakenjs/generator-kraken/issues{/number}","pulls_url":"https://api.github.com/repos/krakenjs/generator-kraken/pulls{/number}","milestones_url":"https://api.github.com/repos/krakenjs/generator-kraken/milestones{/number}","notifications_url":"https://api.github.com/repos/krakenjs/generator-kraken/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krakenjs/generator-kraken/labels{/name}","releases_url":"https://api.github.com/repos/krakenjs/generator-kraken/releases{/id}","created_at":"2013-09-29T06:51:08Z","updated_at":"2014-08-18T12:22:22Z","pushed_at":"2014-08-20T23:31:59Z","git_url":"git://github.com/krakenjs/generator-kraken.git","ssh_url":"git@github.com:krakenjs/generator-kraken.git","clone_url":"https://github.com/krakenjs/generator-kraken.git","svn_url":"https://github.com/krakenjs/generator-kraken","homepage":"","size":2199,"stargazers_count":84,"watchers_count":84,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":35,"mirror_url":null,"open_issues_count":14,"forks":35,"open_issues":14,"watchers":84,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/krakenjs/generator-kraken/pulls/118"},"html":{"href":"https://github.com/krakenjs/generator-kraken/pull/118"},"issue":{"href":"https://api.github.com/repos/krakenjs/generator-kraken/issues/118"},"comments":{"href":"https://api.github.com/repos/krakenjs/generator-kraken/issues/118/comments"},"review_comments":{"href":"https://api.github.com/repos/krakenjs/generator-kraken/pulls/118/comments"},"review_comment":{"href":"https://api.github.com/repos/krakenjs/generator-kraken/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/krakenjs/generator-kraken/pulls/118/commits"},"statuses":{"href":"https://api.github.com/repos/krakenjs/generator-kraken/statuses/0d89749866d69942e1e1e648246bd96b2297372e"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"grawk","id":1031360,"avatar_url":"https://avatars.githubusercontent.com/u/1031360?v=2","gravatar_id":"5f4e15c67c9be26ffdff80ac41197b6a","url":"https://api.github.com/users/grawk","html_url":"https://github.com/grawk","followers_url":"https://api.github.com/users/grawk/followers","following_url":"https://api.github.com/users/grawk/following{/other_user}","gists_url":"https://api.github.com/users/grawk/gists{/gist_id}","starred_url":"https://api.github.com/users/grawk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grawk/subscriptions","organizations_url":"https://api.github.com/users/grawk/orgs","repos_url":"https://api.github.com/users/grawk/repos","events_url":"https://api.github.com/users/grawk/events{/privacy}","received_events_url":"https://api.github.com/users/grawk/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"commits":2,"additions":2,"deletions":2,"changed_files":2}}