GitHub PullRequestReviewCommentEvent at 2014-10-01 13:35:52
Repository: netty
Actor: Scottmitch
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/netty/netty/pulls/comments/18278144","id":18278144,"diff_hunk":"@@ -550,11 +550,12 @@ private LastHttpContent readTrailingHeaders(ByteBuf buffer) {\n             do {\n                 char firstChar = line.charAt(0);\n                 if (lastHeader != null && (firstChar == ' ' || firstChar == '\\t')) {\n-                    List<String> current = trailer.trailingHeaders().getAll(lastHeader);\n+                    List<CharSequence> current = trailer.trailingHeaders().getAll(lastHeader);\n                     if (!current.isEmpty()) {\n                         int lastPos = current.size() - 1;\n-                        String newString = current.get(lastPos) + line.toString().trim();\n-                        current.set(lastPos, newString);\n+                        StringBuilder b = new StringBuilder(current.get(lastPos));","path":"codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectDecoder.java","position":10,"original_position":10,"commit_id":"07048ef7184c7f32b71a9c3359061865002d8971","original_commit_id":"07048ef7184c7f32b71a9c3359061865002d8971","user":{"login":"Scottmitch","id":7562868,"avatar_url":"https://avatars.githubusercontent.com/u/7562868?v=2","gravatar_id":"","url":"https://api.github.com/users/Scottmitch","html_url":"https://github.com/Scottmitch","followers_url":"https://api.github.com/users/Scottmitch/followers","following_url":"https://api.github.com/users/Scottmitch/following{/other_user}","gists_url":"https://api.github.com/users/Scottmitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Scottmitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Scottmitch/subscriptions","organizations_url":"https://api.github.com/users/Scottmitch/orgs","repos_url":"https://api.github.com/users/Scottmitch/repos","events_url":"https://api.github.com/users/Scottmitch/events{/privacy}","received_events_url":"https://api.github.com/users/Scottmitch/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2014-10-01T13:35:52Z","updated_at":"2014-10-01T13:35:52Z","html_url":"https://github.com/netty/netty/pull/2908#discussion_r18278144","pull_request_url":"https://api.github.com/repos/netty/netty/pulls/2908","_links":{"self":{"href":"https://api.github.com/repos/netty/netty/pulls/comments/18278144"},"html":{"href":"https://github.com/netty/netty/pull/2908#discussion_r18278144"},"pull_request":{"href":"https://api.github.com/repos/netty/netty/pulls/2908"}}},"pull_request":{"url":"https://api.github.com/repos/netty/netty/pulls/2908","id":21468909,"html_url":"https://github.com/netty/netty/pull/2908","diff_url":"https://github.com/netty/netty/pull/2908.diff","patch_url":"https://github.com/netty/netty/pull/2908.patch","issue_url":"https://api.github.com/repos/netty/netty/issues/2908","number":2908,"state":"open","locked":false,"title":"Netty Headers Class Restructure and Algorithm Updates","user":{"login":"Scottmitch","id":7562868,"avatar_url":"https://avatars.githubusercontent.com/u/7562868?v=2","gravatar_id":"","url":"https://api.github.com/users/Scottmitch","html_url":"https://github.com/Scottmitch","followers_url":"https://api.github.com/users/Scottmitch/followers","following_url":"https://api.github.com/users/Scottmitch/following{/other_user}","gists_url":"https://api.github.com/users/Scottmitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Scottmitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Scottmitch/subscriptions","organizations_url":"https://api.github.com/users/Scottmitch/orgs","repos_url":"https://api.github.com/users/Scottmitch/repos","events_url":"https://api.github.com/users/Scottmitch/events{/privacy}","received_events_url":"https://api.github.com/users/Scottmitch/received_events","type":"User","site_admin":false},"body":"Motivation:\r\nHeaders within netty do not cleanly share a common class hierarchy.  As a result some header types support some operations\r\nand don't support others.  The consolidation of the class hierarchy will allow for maintenance and scalability for new codecs.\r\nThe existing hierarchy also has a few short comings such as it is not clear when data conversions are happening.  This\r\ncould result unintentionally getting back a collection or iterator where a conversion on each entry must happen.\r\n\r\nThe current headers algorithm also prepends all elements which means to find the first element or return a collection\r\nin insertion order often requires a complete traversal followed by a collections.reverse call.\r\n\r\nModifications:\r\n-Provide a generic base class which provides all the implementation for headers in netty\r\n-Provide an extension to this class which allows for name type conversions to happen (to accommodate legacy CharSequence to String conversions)\r\n-Update the headers interface to clarify when conversions will happen.\r\n-Update the headers data structure so that appends are done to avoid unnecessary iteration or collection reversal.\r\n\r\nResult:\r\n-More unified class hierarchy for headers in netty\r\n-Improved headers data structure and algorithms\r\n-headers API more clearly identify when conversions are required.","created_at":"2014-09-18T23:07:02Z","updated_at":"2014-10-01T13:35:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f032cc6b21e8f63ad4e8e684b771f51f7235877a","assignee":{"login":"Scottmitch","id":7562868,"avatar_url":"https://avatars.githubusercontent.com/u/7562868?v=2","gravatar_id":"","url":"https://api.github.com/users/Scottmitch","html_url":"https://github.com/Scottmitch","followers_url":"https://api.github.com/users/Scottmitch/followers","following_url":"https://api.github.com/users/Scottmitch/following{/other_user}","gists_url":"https://api.github.com/users/Scottmitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Scottmitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Scottmitch/subscriptions","organizations_url":"https://api.github.com/users/Scottmitch/orgs","repos_url":"https://api.github.com/users/Scottmitch/repos","events_url":"https://api.github.com/users/Scottmitch/events{/privacy}","received_events_url":"https://api.github.com/users/Scottmitch/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/netty/netty/milestones/80","labels_url":"https://api.github.com/repos/netty/netty/milestones/80/labels","id":504488,"number":80,"title":"5.0.0.Alpha2","description":"","creator":{"login":"normanmaurer","id":439362,"avatar_url":"https://avatars.githubusercontent.com/u/439362?v=2","gravatar_id":"","url":"https://api.github.com/users/normanmaurer","html_url":"https://github.com/normanmaurer","followers_url":"https://api.github.com/users/normanmaurer/followers","following_url":"https://api.github.com/users/normanmaurer/following{/other_user}","gists_url":"https://api.github.com/users/normanmaurer/gists{/gist_id}","starred_url":"https://api.github.com/users/normanmaurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normanmaurer/subscriptions","organizations_url":"https://api.github.com/users/normanmaurer/orgs","repos_url":"https://api.github.com/users/normanmaurer/repos","events_url":"https://api.github.com/users/normanmaurer/events{/privacy}","received_events_url":"https://api.github.com/users/normanmaurer/received_events","type":"User","site_admin":false},"open_issues":19,"closed_issues":87,"state":"open","created_at":"2013-12-04T06:57:47Z","updated_at":"2014-10-01T04:44:26Z","due_on":null},"commits_url":"https://api.github.com/repos/netty/netty/pulls/2908/commits","review_comments_url":"https://api.github.com/repos/netty/netty/pulls/2908/comments","review_comment_url":"https://api.github.com/repos/netty/netty/pulls/comments/{number}","comments_url":"https://api.github.com/repos/netty/netty/issues/2908/comments","statuses_url":"https://api.github.com/repos/netty/netty/statuses/07048ef7184c7f32b71a9c3359061865002d8971","head":{"label":"akamai:header_map_append","ref":"header_map_append","sha":"07048ef7184c7f32b71a9c3359061865002d8971","user":{"login":"akamai","id":7504551,"avatar_url":"https://avatars.githubusercontent.com/u/7504551?v=2","gravatar_id":"","url":"https://api.github.com/users/akamai","html_url":"https://github.com/akamai","followers_url":"https://api.github.com/users/akamai/followers","following_url":"https://api.github.com/users/akamai/following{/other_user}","gists_url":"https://api.github.com/users/akamai/gists{/gist_id}","starred_url":"https://api.github.com/users/akamai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akamai/subscriptions","organizations_url":"https://api.github.com/users/akamai/orgs","repos_url":"https://api.github.com/users/akamai/repos","events_url":"https://api.github.com/users/akamai/events{/privacy}","received_events_url":"https://api.github.com/users/akamai/received_events","type":"Organization","site_admin":false},"repo":{"id":22530159,"name":"netty","full_name":"akamai/netty","owner":{"login":"akamai","id":7504551,"avatar_url":"https://avatars.githubusercontent.com/u/7504551?v=2","gravatar_id":"","url":"https://api.github.com/users/akamai","html_url":"https://github.com/akamai","followers_url":"https://api.github.com/users/akamai/followers","following_url":"https://api.github.com/users/akamai/following{/other_user}","gists_url":"https://api.github.com/users/akamai/gists{/gist_id}","starred_url":"https://api.github.com/users/akamai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akamai/subscriptions","organizations_url":"https://api.github.com/users/akamai/orgs","repos_url":"https://api.github.com/users/akamai/repos","events_url":"https://api.github.com/users/akamai/events{/privacy}","received_events_url":"https://api.github.com/users/akamai/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akamai/netty","description":"Netty project - an event-driven asynchronous network application framework","fork":true,"url":"https://api.github.com/repos/akamai/netty","forks_url":"https://api.github.com/repos/akamai/netty/forks","keys_url":"https://api.github.com/repos/akamai/netty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akamai/netty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akamai/netty/teams","hooks_url":"https://api.github.com/repos/akamai/netty/hooks","issue_events_url":"https://api.github.com/repos/akamai/netty/issues/events{/number}","events_url":"https://api.github.com/repos/akamai/netty/events","assignees_url":"https://api.github.com/repos/akamai/netty/assignees{/user}","branches_url":"https://api.github.com/repos/akamai/netty/branches{/branch}","tags_url":"https://api.github.com/repos/akamai/netty/tags","blobs_url":"https://api.github.com/repos/akamai/netty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akamai/netty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akamai/netty/git/refs{/sha}","trees_url":"https://api.github.com/repos/akamai/netty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akamai/netty/statuses/{sha}","languages_url":"https://api.github.com/repos/akamai/netty/languages","stargazers_url":"https://api.github.com/repos/akamai/netty/stargazers","contributors_url":"https://api.github.com/repos/akamai/netty/contributors","subscribers_url":"https://api.github.com/repos/akamai/netty/subscribers","subscription_url":"https://api.github.com/repos/akamai/netty/subscription","commits_url":"https://api.github.com/repos/akamai/netty/commits{/sha}","git_commits_url":"https://api.github.com/repos/akamai/netty/git/commits{/sha}","comments_url":"https://api.github.com/repos/akamai/netty/comments{/number}","issue_comment_url":"https://api.github.com/repos/akamai/netty/issues/comments/{number}","contents_url":"https://api.github.com/repos/akamai/netty/contents/{+path}","compare_url":"https://api.github.com/repos/akamai/netty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akamai/netty/merges","archive_url":"https://api.github.com/repos/akamai/netty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akamai/netty/downloads","issues_url":"https://api.github.com/repos/akamai/netty/issues{/number}","pulls_url":"https://api.github.com/repos/akamai/netty/pulls{/number}","milestones_url":"https://api.github.com/repos/akamai/netty/milestones{/number}","notifications_url":"https://api.github.com/repos/akamai/netty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akamai/netty/labels{/name}","releases_url":"https://api.github.com/repos/akamai/netty/releases{/id}","created_at":"2014-08-01T21:49:13Z","updated_at":"2014-08-15T17:45:13Z","pushed_at":"2014-10-01T13:19:04Z","git_url":"git://github.com/akamai/netty.git","ssh_url":"git@github.com:akamai/netty.git","clone_url":"https://github.com/akamai/netty.git","svn_url":"https://github.com/akamai/netty","homepage":"http://netty.io/","size":36334,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"netty:master","ref":"master","sha":"741ea7766c9626d0ee57102b31a813615f7ea46f","user":{"login":"netty","id":473791,"avatar_url":"https://avatars.githubusercontent.com/u/473791?v=2","gravatar_id":"","url":"https://api.github.com/users/netty","html_url":"https://github.com/netty","followers_url":"https://api.github.com/users/netty/followers","following_url":"https://api.github.com/users/netty/following{/other_user}","gists_url":"https://api.github.com/users/netty/gists{/gist_id}","starred_url":"https://api.github.com/users/netty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netty/subscriptions","organizations_url":"https://api.github.com/users/netty/orgs","repos_url":"https://api.github.com/users/netty/repos","events_url":"https://api.github.com/users/netty/events{/privacy}","received_events_url":"https://api.github.com/users/netty/received_events","type":"Organization","site_admin":false},"repo":{"id":1064563,"name":"netty","full_name":"netty/netty","owner":{"login":"netty","id":473791,"avatar_url":"https://avatars.githubusercontent.com/u/473791?v=2","gravatar_id":"","url":"https://api.github.com/users/netty","html_url":"https://github.com/netty","followers_url":"https://api.github.com/users/netty/followers","following_url":"https://api.github.com/users/netty/following{/other_user}","gists_url":"https://api.github.com/users/netty/gists{/gist_id}","starred_url":"https://api.github.com/users/netty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netty/subscriptions","organizations_url":"https://api.github.com/users/netty/orgs","repos_url":"https://api.github.com/users/netty/repos","events_url":"https://api.github.com/users/netty/events{/privacy}","received_events_url":"https://api.github.com/users/netty/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/netty/netty","description":"Netty project - an event-driven asynchronous network application framework","fork":false,"url":"https://api.github.com/repos/netty/netty","forks_url":"https://api.github.com/repos/netty/netty/forks","keys_url":"https://api.github.com/repos/netty/netty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/netty/netty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/netty/netty/teams","hooks_url":"https://api.github.com/repos/netty/netty/hooks","issue_events_url":"https://api.github.com/repos/netty/netty/issues/events{/number}","events_url":"https://api.github.com/repos/netty/netty/events","assignees_url":"https://api.github.com/repos/netty/netty/assignees{/user}","branches_url":"https://api.github.com/repos/netty/netty/branches{/branch}","tags_url":"https://api.github.com/repos/netty/netty/tags","blobs_url":"https://api.github.com/repos/netty/netty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/netty/netty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/netty/netty/git/refs{/sha}","trees_url":"https://api.github.com/repos/netty/netty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/netty/netty/statuses/{sha}","languages_url":"https://api.github.com/repos/netty/netty/languages","stargazers_url":"https://api.github.com/repos/netty/netty/stargazers","contributors_url":"https://api.github.com/repos/netty/netty/contributors","subscribers_url":"https://api.github.com/repos/netty/netty/subscribers","subscription_url":"https://api.github.com/repos/netty/netty/subscription","commits_url":"https://api.github.com/repos/netty/netty/commits{/sha}","git_commits_url":"https://api.github.com/repos/netty/netty/git/commits{/sha}","comments_url":"https://api.github.com/repos/netty/netty/comments{/number}","issue_comment_url":"https://api.github.com/repos/netty/netty/issues/comments/{number}","contents_url":"https://api.github.com/repos/netty/netty/contents/{+path}","compare_url":"https://api.github.com/repos/netty/netty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/netty/netty/merges","archive_url":"https://api.github.com/repos/netty/netty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/netty/netty/downloads","issues_url":"https://api.github.com/repos/netty/netty/issues{/number}","pulls_url":"https://api.github.com/repos/netty/netty/pulls{/number}","milestones_url":"https://api.github.com/repos/netty/netty/milestones{/number}","notifications_url":"https://api.github.com/repos/netty/netty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/netty/netty/labels{/name}","releases_url":"https://api.github.com/repos/netty/netty/releases{/id}","created_at":"2010-11-09T09:22:21Z","updated_at":"2014-10-01T06:00:21Z","pushed_at":"2014-10-01T12:18:35Z","git_url":"git://github.com/netty/netty.git","ssh_url":"git@github.com:netty/netty.git","clone_url":"https://github.com/netty/netty.git","svn_url":"https://github.com/netty/netty","homepage":"http://netty.io/","size":116826,"stargazers_count":3567,"watchers_count":3567,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1686,"mirror_url":null,"open_issues_count":165,"forks":1686,"open_issues":165,"watchers":3567,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/netty/netty/pulls/2908"},"html":{"href":"https://github.com/netty/netty/pull/2908"},"issue":{"href":"https://api.github.com/repos/netty/netty/issues/2908"},"comments":{"href":"https://api.github.com/repos/netty/netty/issues/2908/comments"},"review_comments":{"href":"https://api.github.com/repos/netty/netty/pulls/2908/comments"},"review_comment":{"href":"https://api.github.com/repos/netty/netty/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/netty/netty/pulls/2908/commits"},"statuses":{"href":"https://api.github.com/repos/netty/netty/statuses/07048ef7184c7f32b71a9c3359061865002d8971"}}}}