GitHub PushEvent at 2014-08-19 17:26:25
Repository: puppet
Actor: jpartlow
Payload: {"shas":[["cad1636ae2a2c8471c659a317e2d4bd7dbd077ba","711c73f64afdce07b7e38039a96d2224209e9a6c@puppetlabs.com","(PUP-3030) Refactor 'store' report to use replace_file\n\nThere was some logic in the 'store' report processor that was\nalmost identical to the logic in 'puppet/util.rb''s 'replace_file'\nmethod.  This commit refactors 'store' to re-use the existing\nlogic.","Chris Price",true],["df06ca2747692bef3a1a9779e638a060132459bd","711c73f64afdce07b7e38039a96d2224209e9a6c@puppetlabs.com","(PUP-3030) Port Util#replace_file to use our Tempfile\n\nThis simply changes the `replace_file` method to\nuse `Puppet::FileSystem::Tempfile`, rather than the\nRuby built-in `Tempfile`.  This will allow us to have\na bit more control over the lifecycle of these files\non the server.","Chris Price",true],["3255aa634927bb33f97a0a047bd848223b327151","711c73f64afdce07b7e38039a96d2224209e9a6c@puppetlabs.com","(PUP-3030) Port P::U::Execution to use our Tempfile\n\nThis commit ports Puppet::Util::Execution over to use our\nalternate implementation of Tempfile.  This will allow\nus to have more explicit control over the life cycle of\nthese files on the server.","Chris Price",true],["19cf4beef924916a5a18d07f3b21ef13f3dd2e56","711c73f64afdce07b7e38039a96d2224209e9a6c@puppetlabs.com","(PUP-3030) Flesh out implementation of P::F::Tempfile\n\nThis commit changes `Puppet::FileSystem::Tempfile` so that\nit no longer subclasses the built-in `Tempfile`.  The goal\nhere is to give us more control over the life cycle of the\nfiles when used on the server.\n\nThe implementation is based on the Ruby 1.9.3 implementation of\n`Tempfile`, but strips out some things like the finalizer\nand methods that we don't need / use.\n\nNote that we had to also port over a few methods from `Dir` in\norder to support ruby 1.8.7.  Relevant source code is here:\n\nhttps://github.com/ruby/ruby/blob/v1_9_3_547/lib/tempfile.rb\nhttps://github.com/ruby/ruby/blob/v1_9_3_547/lib/tmpdir.rb\n\nIn its current incarnation the class is probably poorly\nnamed because it no longer makes any attempt to automagically\nunlink the file at some point in the future.  I intend\nto submit a follow-up commit that renames the class to make\nthis more obvious.","Chris Price",true],["cc4aef94264961f8880d6b51facf935f6592e2e1","711c73f64afdce07b7e38039a96d2224209e9a6c@puppetlabs.com","(PUP-3030) Rename P::F::Tempfile to Uniquefile\n\nSince the new implementation of Puppet::FileSystem::Tempfile is\nnot trying to manage the deletion of files created through it,\nthe name was misleading.  This commit simply changes the name\nto Uniquefile to try to make it a bit more obvious that it is\nnot responsible for deleting the files.","Chris Price",true],["fc6c6b0156d6178338c57d2048ae98ea3a5cbdb6","711c73f64afdce07b7e38039a96d2224209e9a6c@puppetlabs.com","(PUP-3030) Add Uniquefile tests, ported from Ruby source\n\nThis commit adds additional tests for the Uniquefile class.  The\nnew tests are ported from the Ruby 1.9.3 source code for the\nbuilt-in `Tempfile` class, since that is what our `Uniquefile`\nimplementation is based on.\n\nSee: https://github.com/ruby/ruby/blob/v1_9_3_547/test/test_tempfile.rb","Chris Price",true],["d5585ee2937fdad5765d22fb0829481de3719e48","8b9a6d929adb31c4396b7c3190a692c2499625ce@glatisant.org","Merge pull request #2984 from cprice404/bug/master/PUP-3030-server-side-tempfiles\n\n(PUP-3030) More explicit handling of tempfiles on the server","Josh Partlow",true]],"size":7,"ref":"refs/heads/master","head":"d5585ee2937fdad5765d22fb0829481de3719e48"}