GitHub PullRequestReviewCommentEvent at 2014-10-06 21:58:58
Repository: puppet_for_the_win
Actor: ferventcoder
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/pulls/comments/18488859","id":18488859,"diff_hunk":"@@ -185,16 +186,43 @@ namespace :windows do\n \n   task :misc => 'stagedir' do\n     FileUtils.cp_r(\"conf/windows/stage/misc\", \"stagedir/misc\")\n+    FileUtils.cp_r(FileList['downloads/puppet/ext/windows/eventlog/*.dll'], 'stagedir/misc')\n   end\n \n-  task :stage => [:checkout, 'stagedir', :bin, :misc] do\n+  task :service => 'stagedir' do\n+    mkdir_p(\"stagedir/service\")\n+    FileUtils.cp_r(FileList['downloads/puppet/ext/windows/service/*'], 'stagedir/service')\n+    FileUtils.cp('downloads/mcollective/ext/windows/daemon.bat', 'stagedir/service/mco_daemon.bat') if File.exists?('downloads/mcollective/ext/windows/daemon.bat')","path":"tasks/windows/windows.rake","position":19,"original_position":19,"commit_id":"6a0cbbab622d77a0a79b3a63d5968361acc53a48","original_commit_id":"6a0cbbab622d77a0a79b3a63d5968361acc53a48","user":{"login":"ferventcoder","id":63502,"avatar_url":"https://avatars.githubusercontent.com/u/63502?v=2","gravatar_id":"","url":"https://api.github.com/users/ferventcoder","html_url":"https://github.com/ferventcoder","followers_url":"https://api.github.com/users/ferventcoder/followers","following_url":"https://api.github.com/users/ferventcoder/following{/other_user}","gists_url":"https://api.github.com/users/ferventcoder/gists{/gist_id}","starred_url":"https://api.github.com/users/ferventcoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferventcoder/subscriptions","organizations_url":"https://api.github.com/users/ferventcoder/orgs","repos_url":"https://api.github.com/users/ferventcoder/repos","events_url":"https://api.github.com/users/ferventcoder/events{/privacy}","received_events_url":"https://api.github.com/users/ferventcoder/received_events","type":"User","site_admin":false},"body":"@joshcooper I ran into this errorring on attempted copy, so I added a guard to the end.","created_at":"2014-10-06T21:58:58Z","updated_at":"2014-10-06T21:58:58Z","html_url":"https://github.com/puppetlabs/puppet_for_the_win/pull/78#discussion_r18488859","pull_request_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/pulls/78","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/pulls/comments/18488859"},"html":{"href":"https://github.com/puppetlabs/puppet_for_the_win/pull/78#discussion_r18488859"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/pulls/78"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/pulls/78","id":22317465,"html_url":"https://github.com/puppetlabs/puppet_for_the_win/pull/78","diff_url":"https://github.com/puppetlabs/puppet_for_the_win/pull/78.diff","patch_url":"https://github.com/puppetlabs/puppet_for_the_win/pull/78.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/issues/78","number":78,"state":"open","locked":false,"title":"(PUP-3003) Exclude unnecessary files from MSI","user":{"login":"ferventcoder","id":63502,"avatar_url":"https://avatars.githubusercontent.com/u/63502?v=2","gravatar_id":"","url":"https://api.github.com/users/ferventcoder","html_url":"https://github.com/ferventcoder","followers_url":"https://api.github.com/users/ferventcoder/followers","following_url":"https://api.github.com/users/ferventcoder/following{/other_user}","gists_url":"https://api.github.com/users/ferventcoder/gists{/gist_id}","starred_url":"https://api.github.com/users/ferventcoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferventcoder/subscriptions","organizations_url":"https://api.github.com/users/ferventcoder/orgs","repos_url":"https://api.github.com/users/ferventcoder/repos","events_url":"https://api.github.com/users/ferventcoder/events{/privacy}","received_events_url":"https://api.github.com/users/ferventcoder/received_events","type":"User","site_admin":false},"body":"Previously we bundled all of puppet, facter, hiera, mcollective and vendored\r\nruby into the installer, which included many unneeded files, e.g. spec,\r\nacceptance, etc.\r\n\r\nThis commit modifies the stage task to exclude unnecessary files and folders,\r\nso that they are not copied from downloads to staging\r\n(everything in staging is included in the MSI).\r\n\r\nWith this change, the FOSS MSI size is reduced from 19MB to 17MB. The\r\ninstallation directory (uncompressed) changes to 49MB (from 57MB) for the\r\nx64 version.","created_at":"2014-10-06T21:56:52Z","updated_at":"2014-10-06T21:58:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d99801bd441cf5c14569f109735ca270bbd421be","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/pulls/78/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/pulls/78/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/pulls/comments/{number}","comments_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/issues/78/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/statuses/6a0cbbab622d77a0a79b3a63d5968361acc53a48","head":{"label":"ferventcoder:ticket/master/PUP-3003-exclude-unnecessary-files","ref":"ticket/master/PUP-3003-exclude-unnecessary-files","sha":"6a0cbbab622d77a0a79b3a63d5968361acc53a48","user":{"login":"ferventcoder","id":63502,"avatar_url":"https://avatars.githubusercontent.com/u/63502?v=2","gravatar_id":"","url":"https://api.github.com/users/ferventcoder","html_url":"https://github.com/ferventcoder","followers_url":"https://api.github.com/users/ferventcoder/followers","following_url":"https://api.github.com/users/ferventcoder/following{/other_user}","gists_url":"https://api.github.com/users/ferventcoder/gists{/gist_id}","starred_url":"https://api.github.com/users/ferventcoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferventcoder/subscriptions","organizations_url":"https://api.github.com/users/ferventcoder/orgs","repos_url":"https://api.github.com/users/ferventcoder/repos","events_url":"https://api.github.com/users/ferventcoder/events{/privacy}","received_events_url":"https://api.github.com/users/ferventcoder/received_events","type":"User","site_admin":false},"repo":{"id":11299979,"name":"puppet_for_the_win","full_name":"ferventcoder/puppet_for_the_win","owner":{"login":"ferventcoder","id":63502,"avatar_url":"https://avatars.githubusercontent.com/u/63502?v=2","gravatar_id":"","url":"https://api.github.com/users/ferventcoder","html_url":"https://github.com/ferventcoder","followers_url":"https://api.github.com/users/ferventcoder/followers","following_url":"https://api.github.com/users/ferventcoder/following{/other_user}","gists_url":"https://api.github.com/users/ferventcoder/gists{/gist_id}","starred_url":"https://api.github.com/users/ferventcoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferventcoder/subscriptions","organizations_url":"https://api.github.com/users/ferventcoder/orgs","repos_url":"https://api.github.com/users/ferventcoder/repos","events_url":"https://api.github.com/users/ferventcoder/events{/privacy}","received_events_url":"https://api.github.com/users/ferventcoder/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ferventcoder/puppet_for_the_win","description":"Rake tasks to automatically build Puppet Windows MSI Packages","fork":true,"url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win","forks_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/forks","keys_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/teams","hooks_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/hooks","issue_events_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/issues/events{/number}","events_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/events","assignees_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/assignees{/user}","branches_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/branches{/branch}","tags_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/tags","blobs_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/git/refs{/sha}","trees_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/statuses/{sha}","languages_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/languages","stargazers_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/stargazers","contributors_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/contributors","subscribers_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/subscribers","subscription_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/subscription","commits_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/commits{/sha}","git_commits_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/git/commits{/sha}","comments_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/comments{/number}","issue_comment_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/issues/comments/{number}","contents_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/contents/{+path}","compare_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/merges","archive_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/downloads","issues_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/issues{/number}","pulls_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/pulls{/number}","milestones_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/milestones{/number}","notifications_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/labels{/name}","releases_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/releases{/id}","created_at":"2013-07-10T02:31:58Z","updated_at":"2014-07-02T19:18:37Z","pushed_at":"2014-10-06T21:56:07Z","git_url":"git://github.com/ferventcoder/puppet_for_the_win.git","ssh_url":"git@github.com:ferventcoder/puppet_for_the_win.git","clone_url":"https://github.com/ferventcoder/puppet_for_the_win.git","svn_url":"https://github.com/ferventcoder/puppet_for_the_win","homepage":"http://puppetlabs.com","size":931,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"f4f74b1c8d8792089d1d3328b01f5ff075771eb0","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=2","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":3166814,"name":"puppet_for_the_win","full_name":"puppetlabs/puppet_for_the_win","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=2","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppet_for_the_win","description":"Rake tasks to automatically build Puppet Windows MSI Packages","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win","forks_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/issues/comments/{number}","contents_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/releases{/id}","created_at":"2012-01-12T23:13:50Z","updated_at":"2014-10-01T21:28:25Z","pushed_at":"2014-10-06T21:36:08Z","git_url":"git://github.com/puppetlabs/puppet_for_the_win.git","ssh_url":"git@github.com:puppetlabs/puppet_for_the_win.git","clone_url":"https://github.com/puppetlabs/puppet_for_the_win.git","svn_url":"https://github.com/puppetlabs/puppet_for_the_win","homepage":"http://puppetlabs.com","size":1415,"stargazers_count":14,"watchers_count":14,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":1,"forks":14,"open_issues":1,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/pulls/78"},"html":{"href":"https://github.com/puppetlabs/puppet_for_the_win/pull/78"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/issues/78"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/issues/78/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/pulls/78/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/pulls/78/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/statuses/6a0cbbab622d77a0a79b3a63d5968361acc53a48"}}}}