GitHub PullRequestReviewCommentEvent at 2014-09-16 09:43:14
Repository: tech-talks
Actor: studioromeo
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/boxuk/tech-talks/pulls/comments/17591749","id":17591749,"diff_hunk":"@@ -0,0 +1,208 @@\n+<?php\n+\n+namespace BoxUK\\Pagination;\n+\n+/**\n+ * Used to create pagination for a series of items\n+ *\n+ * @category BoxUK\\Pagination\n+ * @package  BoxUK\\Pagination\\Pagination\n+ * @author   Matthew Jones <matthew.jones@boxuk.com>\n+ * @license  GPL http://www.gnu.org/copyleft/gpl.html\n+ * @link     http://github.com/BoxUK/tech-talks","path":"src/BoxUK/Pagination/Pagination.php","position":12,"original_position":12,"commit_id":"9c3e0338b0757c0700a22dea2f4ca812a794840d","original_commit_id":"9c3e0338b0757c0700a22dea2f4ca812a794840d","user":{"login":"studioromeo","id":846587,"avatar_url":"https://avatars.githubusercontent.com/u/846587?v=2","gravatar_id":"0e9925a20787c08b37ad78df63e39d6a","url":"https://api.github.com/users/studioromeo","html_url":"https://github.com/studioromeo","followers_url":"https://api.github.com/users/studioromeo/followers","following_url":"https://api.github.com/users/studioromeo/following{/other_user}","gists_url":"https://api.github.com/users/studioromeo/gists{/gist_id}","starred_url":"https://api.github.com/users/studioromeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/studioromeo/subscriptions","organizations_url":"https://api.github.com/users/studioromeo/orgs","repos_url":"https://api.github.com/users/studioromeo/repos","events_url":"https://api.github.com/users/studioromeo/events{/privacy}","received_events_url":"https://api.github.com/users/studioromeo/received_events","type":"User","site_admin":false},"body":"I think the @'s can go but the rest can remain.","created_at":"2014-09-16T09:43:14Z","updated_at":"2014-09-16T09:43:14Z","html_url":"https://github.com/boxuk/tech-talks/pull/4#discussion_r17591749","pull_request_url":"https://api.github.com/repos/boxuk/tech-talks/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/boxuk/tech-talks/pulls/comments/17591749"},"html":{"href":"https://github.com/boxuk/tech-talks/pull/4#discussion_r17591749"},"pull_request":{"href":"https://api.github.com/repos/boxuk/tech-talks/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/boxuk/tech-talks/pulls/4","id":21017563,"html_url":"https://github.com/boxuk/tech-talks/pull/4","diff_url":"https://github.com/boxuk/tech-talks/pull/4.diff","patch_url":"https://github.com/boxuk/tech-talks/pull/4.patch","issue_url":"https://api.github.com/repos/boxuk/tech-talks/issues/4","number":4,"state":"open","locked":false,"title":"Update vimeo library","user":{"login":"matthewBoxUK","id":7839084,"avatar_url":"https://avatars.githubusercontent.com/u/7839084?v=2","gravatar_id":"22be4815429c6f3823a2665d70f1bdb0","url":"https://api.github.com/users/matthewBoxUK","html_url":"https://github.com/matthewBoxUK","followers_url":"https://api.github.com/users/matthewBoxUK/followers","following_url":"https://api.github.com/users/matthewBoxUK/following{/other_user}","gists_url":"https://api.github.com/users/matthewBoxUK/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewBoxUK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewBoxUK/subscriptions","organizations_url":"https://api.github.com/users/matthewBoxUK/orgs","repos_url":"https://api.github.com/users/matthewBoxUK/repos","events_url":"https://api.github.com/users/matthewBoxUK/events{/privacy}","received_events_url":"https://api.github.com/users/matthewBoxUK/received_events","type":"User","site_admin":false},"body":"Few points to note with this PR...\r\n\r\n1. All the feedback received on the last PR has been addressed (anything in the commits prior to 26th August) so hopefully only the stuff after the 26th needs to be reviewed.\r\n\r\n2. The new Vimeo API uses oAuth, rather than create the entire oAuth dance I've added an oAuth Access Token parameter to the config. This shouldn't expire but obviously not ideal long term. \r\n\r\n3. The values from the Vimeo API response were getting output directly in the template before, the new API returns a completely different structure to the old one which meant changing the templates. To avoid this happening again in the future I've abstracted the logic from the view and created some Video classes to parse the data so should be much easier to handle changes going forward.\r\n\r\n4. The dukt vimeo library no longer supports caching, this could be done in Silex but would impact on pagination (e.g. videos might 'go missing' if some pages are cached but others aren't) - not sure how best to approach that? Advice massively appreciated!\r\n\r\nPlease be nice and apologies for the delay on getting this up... :)\r\n\r\nCheers,\r\nM\r\n","created_at":"2014-09-10T12:39:23Z","updated_at":"2014-09-16T09:43:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cb243c89cbe1ed2d75f0f906f0ca945ad0cd9c92","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/boxuk/tech-talks/pulls/4/commits","review_comments_url":"https://api.github.com/repos/boxuk/tech-talks/pulls/4/comments","review_comment_url":"https://api.github.com/repos/boxuk/tech-talks/pulls/comments/{number}","comments_url":"https://api.github.com/repos/boxuk/tech-talks/issues/4/comments","statuses_url":"https://api.github.com/repos/boxuk/tech-talks/statuses/9c3e0338b0757c0700a22dea2f4ca812a794840d","head":{"label":"boxuk:UpdateVimeoLibrary","ref":"UpdateVimeoLibrary","sha":"9c3e0338b0757c0700a22dea2f4ca812a794840d","user":{"login":"boxuk","id":203949,"avatar_url":"https://avatars.githubusercontent.com/u/203949?v=2","gravatar_id":"fdc39f98e3532c2cbf9821de69e06d9b","url":"https://api.github.com/users/boxuk","html_url":"https://github.com/boxuk","followers_url":"https://api.github.com/users/boxuk/followers","following_url":"https://api.github.com/users/boxuk/following{/other_user}","gists_url":"https://api.github.com/users/boxuk/gists{/gist_id}","starred_url":"https://api.github.com/users/boxuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boxuk/subscriptions","organizations_url":"https://api.github.com/users/boxuk/orgs","repos_url":"https://api.github.com/users/boxuk/repos","events_url":"https://api.github.com/users/boxuk/events{/privacy}","received_events_url":"https://api.github.com/users/boxuk/received_events","type":"Organization","site_admin":false},"repo":{"id":10828715,"name":"tech-talks","full_name":"boxuk/tech-talks","owner":{"login":"boxuk","id":203949,"avatar_url":"https://avatars.githubusercontent.com/u/203949?v=2","gravatar_id":"fdc39f98e3532c2cbf9821de69e06d9b","url":"https://api.github.com/users/boxuk","html_url":"https://github.com/boxuk","followers_url":"https://api.github.com/users/boxuk/followers","following_url":"https://api.github.com/users/boxuk/following{/other_user}","gists_url":"https://api.github.com/users/boxuk/gists{/gist_id}","starred_url":"https://api.github.com/users/boxuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boxuk/subscriptions","organizations_url":"https://api.github.com/users/boxuk/orgs","repos_url":"https://api.github.com/users/boxuk/repos","events_url":"https://api.github.com/users/boxuk/events{/privacy}","received_events_url":"https://api.github.com/users/boxuk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/boxuk/tech-talks","description":"A Silex application that displays videos in a Vimeo album.","fork":false,"url":"https://api.github.com/repos/boxuk/tech-talks","forks_url":"https://api.github.com/repos/boxuk/tech-talks/forks","keys_url":"https://api.github.com/repos/boxuk/tech-talks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/boxuk/tech-talks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/boxuk/tech-talks/teams","hooks_url":"https://api.github.com/repos/boxuk/tech-talks/hooks","issue_events_url":"https://api.github.com/repos/boxuk/tech-talks/issues/events{/number}","events_url":"https://api.github.com/repos/boxuk/tech-talks/events","assignees_url":"https://api.github.com/repos/boxuk/tech-talks/assignees{/user}","branches_url":"https://api.github.com/repos/boxuk/tech-talks/branches{/branch}","tags_url":"https://api.github.com/repos/boxuk/tech-talks/tags","blobs_url":"https://api.github.com/repos/boxuk/tech-talks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/boxuk/tech-talks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/boxuk/tech-talks/git/refs{/sha}","trees_url":"https://api.github.com/repos/boxuk/tech-talks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/boxuk/tech-talks/statuses/{sha}","languages_url":"https://api.github.com/repos/boxuk/tech-talks/languages","stargazers_url":"https://api.github.com/repos/boxuk/tech-talks/stargazers","contributors_url":"https://api.github.com/repos/boxuk/tech-talks/contributors","subscribers_url":"https://api.github.com/repos/boxuk/tech-talks/subscribers","subscription_url":"https://api.github.com/repos/boxuk/tech-talks/subscription","commits_url":"https://api.github.com/repos/boxuk/tech-talks/commits{/sha}","git_commits_url":"https://api.github.com/repos/boxuk/tech-talks/git/commits{/sha}","comments_url":"https://api.github.com/repos/boxuk/tech-talks/comments{/number}","issue_comment_url":"https://api.github.com/repos/boxuk/tech-talks/issues/comments/{number}","contents_url":"https://api.github.com/repos/boxuk/tech-talks/contents/{+path}","compare_url":"https://api.github.com/repos/boxuk/tech-talks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/boxuk/tech-talks/merges","archive_url":"https://api.github.com/repos/boxuk/tech-talks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/boxuk/tech-talks/downloads","issues_url":"https://api.github.com/repos/boxuk/tech-talks/issues{/number}","pulls_url":"https://api.github.com/repos/boxuk/tech-talks/pulls{/number}","milestones_url":"https://api.github.com/repos/boxuk/tech-talks/milestones{/number}","notifications_url":"https://api.github.com/repos/boxuk/tech-talks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/boxuk/tech-talks/labels{/name}","releases_url":"https://api.github.com/repos/boxuk/tech-talks/releases{/id}","created_at":"2013-06-20T20:25:18Z","updated_at":"2014-09-06T15:57:56Z","pushed_at":"2014-09-15T14:32:39Z","git_url":"git://github.com/boxuk/tech-talks.git","ssh_url":"git@github.com:boxuk/tech-talks.git","clone_url":"https://github.com/boxuk/tech-talks.git","svn_url":"https://github.com/boxuk/tech-talks","homepage":null,"size":532,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"boxuk:master","ref":"master","sha":"ffcefcdabdf8da92a5a66ccdf870b24e9551000d","user":{"login":"boxuk","id":203949,"avatar_url":"https://avatars.githubusercontent.com/u/203949?v=2","gravatar_id":"fdc39f98e3532c2cbf9821de69e06d9b","url":"https://api.github.com/users/boxuk","html_url":"https://github.com/boxuk","followers_url":"https://api.github.com/users/boxuk/followers","following_url":"https://api.github.com/users/boxuk/following{/other_user}","gists_url":"https://api.github.com/users/boxuk/gists{/gist_id}","starred_url":"https://api.github.com/users/boxuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boxuk/subscriptions","organizations_url":"https://api.github.com/users/boxuk/orgs","repos_url":"https://api.github.com/users/boxuk/repos","events_url":"https://api.github.com/users/boxuk/events{/privacy}","received_events_url":"https://api.github.com/users/boxuk/received_events","type":"Organization","site_admin":false},"repo":{"id":10828715,"name":"tech-talks","full_name":"boxuk/tech-talks","owner":{"login":"boxuk","id":203949,"avatar_url":"https://avatars.githubusercontent.com/u/203949?v=2","gravatar_id":"fdc39f98e3532c2cbf9821de69e06d9b","url":"https://api.github.com/users/boxuk","html_url":"https://github.com/boxuk","followers_url":"https://api.github.com/users/boxuk/followers","following_url":"https://api.github.com/users/boxuk/following{/other_user}","gists_url":"https://api.github.com/users/boxuk/gists{/gist_id}","starred_url":"https://api.github.com/users/boxuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boxuk/subscriptions","organizations_url":"https://api.github.com/users/boxuk/orgs","repos_url":"https://api.github.com/users/boxuk/repos","events_url":"https://api.github.com/users/boxuk/events{/privacy}","received_events_url":"https://api.github.com/users/boxuk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/boxuk/tech-talks","description":"A Silex application that displays videos in a Vimeo album.","fork":false,"url":"https://api.github.com/repos/boxuk/tech-talks","forks_url":"https://api.github.com/repos/boxuk/tech-talks/forks","keys_url":"https://api.github.com/repos/boxuk/tech-talks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/boxuk/tech-talks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/boxuk/tech-talks/teams","hooks_url":"https://api.github.com/repos/boxuk/tech-talks/hooks","issue_events_url":"https://api.github.com/repos/boxuk/tech-talks/issues/events{/number}","events_url":"https://api.github.com/repos/boxuk/tech-talks/events","assignees_url":"https://api.github.com/repos/boxuk/tech-talks/assignees{/user}","branches_url":"https://api.github.com/repos/boxuk/tech-talks/branches{/branch}","tags_url":"https://api.github.com/repos/boxuk/tech-talks/tags","blobs_url":"https://api.github.com/repos/boxuk/tech-talks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/boxuk/tech-talks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/boxuk/tech-talks/git/refs{/sha}","trees_url":"https://api.github.com/repos/boxuk/tech-talks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/boxuk/tech-talks/statuses/{sha}","languages_url":"https://api.github.com/repos/boxuk/tech-talks/languages","stargazers_url":"https://api.github.com/repos/boxuk/tech-talks/stargazers","contributors_url":"https://api.github.com/repos/boxuk/tech-talks/contributors","subscribers_url":"https://api.github.com/repos/boxuk/tech-talks/subscribers","subscription_url":"https://api.github.com/repos/boxuk/tech-talks/subscription","commits_url":"https://api.github.com/repos/boxuk/tech-talks/commits{/sha}","git_commits_url":"https://api.github.com/repos/boxuk/tech-talks/git/commits{/sha}","comments_url":"https://api.github.com/repos/boxuk/tech-talks/comments{/number}","issue_comment_url":"https://api.github.com/repos/boxuk/tech-talks/issues/comments/{number}","contents_url":"https://api.github.com/repos/boxuk/tech-talks/contents/{+path}","compare_url":"https://api.github.com/repos/boxuk/tech-talks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/boxuk/tech-talks/merges","archive_url":"https://api.github.com/repos/boxuk/tech-talks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/boxuk/tech-talks/downloads","issues_url":"https://api.github.com/repos/boxuk/tech-talks/issues{/number}","pulls_url":"https://api.github.com/repos/boxuk/tech-talks/pulls{/number}","milestones_url":"https://api.github.com/repos/boxuk/tech-talks/milestones{/number}","notifications_url":"https://api.github.com/repos/boxuk/tech-talks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/boxuk/tech-talks/labels{/name}","releases_url":"https://api.github.com/repos/boxuk/tech-talks/releases{/id}","created_at":"2013-06-20T20:25:18Z","updated_at":"2014-09-06T15:57:56Z","pushed_at":"2014-09-15T14:32:39Z","git_url":"git://github.com/boxuk/tech-talks.git","ssh_url":"git@github.com:boxuk/tech-talks.git","clone_url":"https://github.com/boxuk/tech-talks.git","svn_url":"https://github.com/boxuk/tech-talks","homepage":null,"size":532,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/boxuk/tech-talks/pulls/4"},"html":{"href":"https://github.com/boxuk/tech-talks/pull/4"},"issue":{"href":"https://api.github.com/repos/boxuk/tech-talks/issues/4"},"comments":{"href":"https://api.github.com/repos/boxuk/tech-talks/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/boxuk/tech-talks/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/boxuk/tech-talks/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/boxuk/tech-talks/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/boxuk/tech-talks/statuses/9c3e0338b0757c0700a22dea2f4ca812a794840d"}}}}