GitHub PullRequestReviewCommentEvent at 2014-08-04 09:00:35
Repository: yii2
Actor: TriAnMan
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/yiisoft/yii2/pulls/comments/15745952","id":15745952,"diff_hunk":"@@ -113,7 +113,7 @@ it will upgrade your database to the last state according migrations.\n \n To be able to run acceptance tests you need a running webserver. For this you can use the php builtin server and run it in the directory where your main project folder is located. For example if your application is located in `/www/advanced` all you need to is:\n `cd /www` and then `php -S 127.0.0.1:8080 index-test.php` because the default configuration of acceptance tests expects the url of the application to be `/advanced/`.\n-If you already have a server configured or your application is not located in a folder called `advanced`, you may need to adjust the `TEST_ENTRY_URL` in `frontend/tests/_bootstrap.php` and `backend/tests/_bootstrap.php`.\n+If you already have a server configured or your application is not located in a folder called `advanced`, you may need to adjust the `$GLOBALS['TEST_ENTRY_URL']` in `frontend/tests/_bootstrap.php` and `backend/tests/_bootstrap.php`.","path":"apps/advanced/README.md","position":5,"original_position":5,"commit_id":"25dec33ad39a3fb9eda06478e1ee657e57fedeff","original_commit_id":"25dec33ad39a3fb9eda06478e1ee657e57fedeff","user":{"login":"TriAnMan","id":2266882,"avatar_url":"https://avatars.githubusercontent.com/u/2266882?v=1","gravatar_id":"5176b4d5f416eee400845f431258dab2","url":"https://api.github.com/users/TriAnMan","html_url":"https://github.com/TriAnMan","followers_url":"https://api.github.com/users/TriAnMan/followers","following_url":"https://api.github.com/users/TriAnMan/following{/other_user}","gists_url":"https://api.github.com/users/TriAnMan/gists{/gist_id}","starred_url":"https://api.github.com/users/TriAnMan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TriAnMan/subscriptions","organizations_url":"https://api.github.com/users/TriAnMan/orgs","repos_url":"https://api.github.com/users/TriAnMan/repos","events_url":"https://api.github.com/users/TriAnMan/events{/privacy}","received_events_url":"https://api.github.com/users/TriAnMan/received_events","type":"User","site_admin":false},"body":"Since, there is one PHP process for all tests for all applications. If I have already defined a constant, I can't redefine it for other application. Using globals isn't the best solution but I haven't found another.","created_at":"2014-08-04T09:00:35Z","updated_at":"2014-08-04T09:00:35Z","html_url":"https://github.com/yiisoft/yii2/pull/4584#discussion_r15745952","pull_request_url":"https://api.github.com/repos/yiisoft/yii2/pulls/4584","_links":{"self":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/comments/15745952"},"html":{"href":"https://github.com/yiisoft/yii2/pull/4584#discussion_r15745952"},"pull_request":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/4584"}}},"pull_request":{"url":"https://api.github.com/repos/yiisoft/yii2/pulls/4584","id":19260031,"html_url":"https://github.com/yiisoft/yii2/pull/4584","diff_url":"https://github.com/yiisoft/yii2/pull/4584.diff","patch_url":"https://github.com/yiisoft/yii2/pull/4584.patch","issue_url":"https://api.github.com/repos/yiisoft/yii2/issues/4584","number":4584,"state":"open","title":"Provide an aggregate tests runner. See #4583","user":{"login":"TriAnMan","id":2266882,"avatar_url":"https://avatars.githubusercontent.com/u/2266882?v=1","gravatar_id":"5176b4d5f416eee400845f431258dab2","url":"https://api.github.com/users/TriAnMan","html_url":"https://github.com/TriAnMan","followers_url":"https://api.github.com/users/TriAnMan/followers","following_url":"https://api.github.com/users/TriAnMan/following{/other_user}","gists_url":"https://api.github.com/users/TriAnMan/gists{/gist_id}","starred_url":"https://api.github.com/users/TriAnMan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TriAnMan/subscriptions","organizations_url":"https://api.github.com/users/TriAnMan/orgs","repos_url":"https://api.github.com/users/TriAnMan/repos","events_url":"https://api.github.com/users/TriAnMan/events{/privacy}","received_events_url":"https://api.github.com/users/TriAnMan/received_events","type":"User","site_admin":false},"body":"Provide an aggregate tests runner.\r\nSee: #4583\r\nhttp://codeception.com/docs/08-Customization#One-Runner-for-Multiple-Applications","created_at":"2014-08-03T22:20:07Z","updated_at":"2014-08-04T09:00:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"39836bd43126e6fb1e842e589e5d69d0b1053425","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/yiisoft/yii2/pulls/4584/commits","review_comments_url":"https://api.github.com/repos/yiisoft/yii2/pulls/4584/comments","review_comment_url":"https://api.github.com/repos/yiisoft/yii2/pulls/comments/{number}","comments_url":"https://api.github.com/repos/yiisoft/yii2/issues/4584/comments","statuses_url":"https://api.github.com/repos/yiisoft/yii2/statuses/25dec33ad39a3fb9eda06478e1ee657e57fedeff","head":{"label":"TriAnMan:unit-test-runner","ref":"unit-test-runner","sha":"25dec33ad39a3fb9eda06478e1ee657e57fedeff","user":{"login":"TriAnMan","id":2266882,"avatar_url":"https://avatars.githubusercontent.com/u/2266882?v=1","gravatar_id":"5176b4d5f416eee400845f431258dab2","url":"https://api.github.com/users/TriAnMan","html_url":"https://github.com/TriAnMan","followers_url":"https://api.github.com/users/TriAnMan/followers","following_url":"https://api.github.com/users/TriAnMan/following{/other_user}","gists_url":"https://api.github.com/users/TriAnMan/gists{/gist_id}","starred_url":"https://api.github.com/users/TriAnMan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TriAnMan/subscriptions","organizations_url":"https://api.github.com/users/TriAnMan/orgs","repos_url":"https://api.github.com/users/TriAnMan/repos","events_url":"https://api.github.com/users/TriAnMan/events{/privacy}","received_events_url":"https://api.github.com/users/TriAnMan/received_events","type":"User","site_admin":false},"repo":{"id":20063609,"name":"yii2","full_name":"TriAnMan/yii2","owner":{"login":"TriAnMan","id":2266882,"avatar_url":"https://avatars.githubusercontent.com/u/2266882?v=1","gravatar_id":"5176b4d5f416eee400845f431258dab2","url":"https://api.github.com/users/TriAnMan","html_url":"https://github.com/TriAnMan","followers_url":"https://api.github.com/users/TriAnMan/followers","following_url":"https://api.github.com/users/TriAnMan/following{/other_user}","gists_url":"https://api.github.com/users/TriAnMan/gists{/gist_id}","starred_url":"https://api.github.com/users/TriAnMan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TriAnMan/subscriptions","organizations_url":"https://api.github.com/users/TriAnMan/orgs","repos_url":"https://api.github.com/users/TriAnMan/repos","events_url":"https://api.github.com/users/TriAnMan/events{/privacy}","received_events_url":"https://api.github.com/users/TriAnMan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TriAnMan/yii2","description":"Yii 2 framework main development repo","fork":true,"url":"https://api.github.com/repos/TriAnMan/yii2","forks_url":"https://api.github.com/repos/TriAnMan/yii2/forks","keys_url":"https://api.github.com/repos/TriAnMan/yii2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TriAnMan/yii2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TriAnMan/yii2/teams","hooks_url":"https://api.github.com/repos/TriAnMan/yii2/hooks","issue_events_url":"https://api.github.com/repos/TriAnMan/yii2/issues/events{/number}","events_url":"https://api.github.com/repos/TriAnMan/yii2/events","assignees_url":"https://api.github.com/repos/TriAnMan/yii2/assignees{/user}","branches_url":"https://api.github.com/repos/TriAnMan/yii2/branches{/branch}","tags_url":"https://api.github.com/repos/TriAnMan/yii2/tags","blobs_url":"https://api.github.com/repos/TriAnMan/yii2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TriAnMan/yii2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TriAnMan/yii2/git/refs{/sha}","trees_url":"https://api.github.com/repos/TriAnMan/yii2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TriAnMan/yii2/statuses/{sha}","languages_url":"https://api.github.com/repos/TriAnMan/yii2/languages","stargazers_url":"https://api.github.com/repos/TriAnMan/yii2/stargazers","contributors_url":"https://api.github.com/repos/TriAnMan/yii2/contributors","subscribers_url":"https://api.github.com/repos/TriAnMan/yii2/subscribers","subscription_url":"https://api.github.com/repos/TriAnMan/yii2/subscription","commits_url":"https://api.github.com/repos/TriAnMan/yii2/commits{/sha}","git_commits_url":"https://api.github.com/repos/TriAnMan/yii2/git/commits{/sha}","comments_url":"https://api.github.com/repos/TriAnMan/yii2/comments{/number}","issue_comment_url":"https://api.github.com/repos/TriAnMan/yii2/issues/comments/{number}","contents_url":"https://api.github.com/repos/TriAnMan/yii2/contents/{+path}","compare_url":"https://api.github.com/repos/TriAnMan/yii2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TriAnMan/yii2/merges","archive_url":"https://api.github.com/repos/TriAnMan/yii2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TriAnMan/yii2/downloads","issues_url":"https://api.github.com/repos/TriAnMan/yii2/issues{/number}","pulls_url":"https://api.github.com/repos/TriAnMan/yii2/pulls{/number}","milestones_url":"https://api.github.com/repos/TriAnMan/yii2/milestones{/number}","notifications_url":"https://api.github.com/repos/TriAnMan/yii2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TriAnMan/yii2/labels{/name}","releases_url":"https://api.github.com/repos/TriAnMan/yii2/releases{/id}","created_at":"2014-05-22T14:15:01Z","updated_at":"2014-05-22T14:16:26Z","pushed_at":"2014-08-03T22:16:04Z","git_url":"git://github.com/TriAnMan/yii2.git","ssh_url":"git@github.com:TriAnMan/yii2.git","clone_url":"https://github.com/TriAnMan/yii2.git","svn_url":"https://github.com/TriAnMan/yii2","homepage":"http://www.yiiframework.com","size":23403,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yiisoft:master","ref":"master","sha":"89386e7c05a7edc65b2db92f4999073938ac3c38","user":{"login":"yiisoft","id":993323,"avatar_url":"https://avatars.githubusercontent.com/u/993323?v=1","gravatar_id":"45ab5f787f17e41c1c2ed66163b18bb1","url":"https://api.github.com/users/yiisoft","html_url":"https://github.com/yiisoft","followers_url":"https://api.github.com/users/yiisoft/followers","following_url":"https://api.github.com/users/yiisoft/following{/other_user}","gists_url":"https://api.github.com/users/yiisoft/gists{/gist_id}","starred_url":"https://api.github.com/users/yiisoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yiisoft/subscriptions","organizations_url":"https://api.github.com/users/yiisoft/orgs","repos_url":"https://api.github.com/users/yiisoft/repos","events_url":"https://api.github.com/users/yiisoft/events{/privacy}","received_events_url":"https://api.github.com/users/yiisoft/received_events","type":"Organization","site_admin":false},"repo":{"id":3431193,"name":"yii2","full_name":"yiisoft/yii2","owner":{"login":"yiisoft","id":993323,"avatar_url":"https://avatars.githubusercontent.com/u/993323?v=1","gravatar_id":"45ab5f787f17e41c1c2ed66163b18bb1","url":"https://api.github.com/users/yiisoft","html_url":"https://github.com/yiisoft","followers_url":"https://api.github.com/users/yiisoft/followers","following_url":"https://api.github.com/users/yiisoft/following{/other_user}","gists_url":"https://api.github.com/users/yiisoft/gists{/gist_id}","starred_url":"https://api.github.com/users/yiisoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yiisoft/subscriptions","organizations_url":"https://api.github.com/users/yiisoft/orgs","repos_url":"https://api.github.com/users/yiisoft/repos","events_url":"https://api.github.com/users/yiisoft/events{/privacy}","received_events_url":"https://api.github.com/users/yiisoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yiisoft/yii2","description":"Yii 2 framework main development repo","fork":false,"url":"https://api.github.com/repos/yiisoft/yii2","forks_url":"https://api.github.com/repos/yiisoft/yii2/forks","keys_url":"https://api.github.com/repos/yiisoft/yii2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yiisoft/yii2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yiisoft/yii2/teams","hooks_url":"https://api.github.com/repos/yiisoft/yii2/hooks","issue_events_url":"https://api.github.com/repos/yiisoft/yii2/issues/events{/number}","events_url":"https://api.github.com/repos/yiisoft/yii2/events","assignees_url":"https://api.github.com/repos/yiisoft/yii2/assignees{/user}","branches_url":"https://api.github.com/repos/yiisoft/yii2/branches{/branch}","tags_url":"https://api.github.com/repos/yiisoft/yii2/tags","blobs_url":"https://api.github.com/repos/yiisoft/yii2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yiisoft/yii2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yiisoft/yii2/git/refs{/sha}","trees_url":"https://api.github.com/repos/yiisoft/yii2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yiisoft/yii2/statuses/{sha}","languages_url":"https://api.github.com/repos/yiisoft/yii2/languages","stargazers_url":"https://api.github.com/repos/yiisoft/yii2/stargazers","contributors_url":"https://api.github.com/repos/yiisoft/yii2/contributors","subscribers_url":"https://api.github.com/repos/yiisoft/yii2/subscribers","subscription_url":"https://api.github.com/repos/yiisoft/yii2/subscription","commits_url":"https://api.github.com/repos/yiisoft/yii2/commits{/sha}","git_commits_url":"https://api.github.com/repos/yiisoft/yii2/git/commits{/sha}","comments_url":"https://api.github.com/repos/yiisoft/yii2/comments{/number}","issue_comment_url":"https://api.github.com/repos/yiisoft/yii2/issues/comments/{number}","contents_url":"https://api.github.com/repos/yiisoft/yii2/contents/{+path}","compare_url":"https://api.github.com/repos/yiisoft/yii2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yiisoft/yii2/merges","archive_url":"https://api.github.com/repos/yiisoft/yii2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yiisoft/yii2/downloads","issues_url":"https://api.github.com/repos/yiisoft/yii2/issues{/number}","pulls_url":"https://api.github.com/repos/yiisoft/yii2/pulls{/number}","milestones_url":"https://api.github.com/repos/yiisoft/yii2/milestones{/number}","notifications_url":"https://api.github.com/repos/yiisoft/yii2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yiisoft/yii2/labels{/name}","releases_url":"https://api.github.com/repos/yiisoft/yii2/releases{/id}","created_at":"2012-02-13T15:32:36Z","updated_at":"2014-08-04T06:59:35Z","pushed_at":"2014-08-04T02:58:29Z","git_url":"git://github.com/yiisoft/yii2.git","ssh_url":"git@github.com:yiisoft/yii2.git","clone_url":"https://github.com/yiisoft/yii2.git","svn_url":"https://github.com/yiisoft/yii2","homepage":"http://www.yiiframework.com","size":84823,"stargazers_count":2904,"watchers_count":2904,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1330,"mirror_url":null,"open_issues_count":330,"forks":1330,"open_issues":330,"watchers":2904,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/4584"},"html":{"href":"https://github.com/yiisoft/yii2/pull/4584"},"issue":{"href":"https://api.github.com/repos/yiisoft/yii2/issues/4584"},"comments":{"href":"https://api.github.com/repos/yiisoft/yii2/issues/4584/comments"},"review_comments":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/4584/comments"},"review_comment":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/4584/commits"},"statuses":{"href":"https://api.github.com/repos/yiisoft/yii2/statuses/25dec33ad39a3fb9eda06478e1ee657e57fedeff"}}}}