GitHub PullRequestEvent at 2014-06-27 00:35:42
Repository: hubot-twitter
Actor: mikegroseclose
Payload: {"action":"opened","number":19,"pull_request":{"url":"https://api.github.com/repos/MathildeLemee/hubot-twitter/pulls/19","id":17681148,"html_url":"https://github.com/MathildeLemee/hubot-twitter/pull/19","diff_url":"https://github.com/MathildeLemee/hubot-twitter/pull/19.diff","patch_url":"https://github.com/MathildeLemee/hubot-twitter/pull/19.patch","issue_url":"https://api.github.com/repos/MathildeLemee/hubot-twitter/issues/19","number":19,"state":"open","title":"Bug/correctly handle response chunks to avoid SyntaxError","user":{"login":"mikegroseclose","id":5898306,"avatar_url":"https://avatars.githubusercontent.com/u/5898306?","gravatar_id":"3b308527ac4069c51d34b261d75ef976","url":"https://api.github.com/users/mikegroseclose","html_url":"https://github.com/mikegroseclose","followers_url":"https://api.github.com/users/mikegroseclose/followers","following_url":"https://api.github.com/users/mikegroseclose/following{/other_user}","gists_url":"https://api.github.com/users/mikegroseclose/gists{/gist_id}","starred_url":"https://api.github.com/users/mikegroseclose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikegroseclose/subscriptions","organizations_url":"https://api.github.com/users/mikegroseclose/orgs","repos_url":"https://api.github.com/users/mikegroseclose/repos","events_url":"https://api.github.com/users/mikegroseclose/events{/privacy}","received_events_url":"https://api.github.com/users/mikegroseclose/received_events","type":"User","site_admin":false},"body":"* Need to ensure all data is received before trying to run JSON parse or else will end up getting a ‘[SyntaxError: Unexpected token’.\r\n* Since data might come in chunks need to concatenate the chunks wait for a carriage return / newline before parsing.\r\n* Also fixed whitespace since CoffeeScript is sensitive to spacing.\r\n* To make the changes easier to read (due to all the whitespace changes, you can use ?w=1 to the URL to see the diff with whitespace ignored.  First commit is code changes, second commit is whitespace.)","created_at":"2014-06-27T00:35:41Z","updated_at":"2014-06-27T00:35:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"791c4cd987e7b4d036508a066bb1c4b2ad1ea04f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/MathildeLemee/hubot-twitter/pulls/19/commits","review_comments_url":"https://api.github.com/repos/MathildeLemee/hubot-twitter/pulls/19/comments","review_comment_url":"https://api.github.com/repos/MathildeLemee/hubot-twitter/pulls/comments/{number}","comments_url":"https://api.github.com/repos/MathildeLemee/hubot-twitter/issues/19/comments","statuses_url":"https://api.github.com/repos/MathildeLemee/hubot-twitter/statuses/c912b7c4c79f915a520bbcdcc6c6230154303088","head":{"label":"mikegroseclose:bug/correctly-handle-response-chunks-to-avoid-syntaxerror","ref":"bug/correctly-handle-response-chunks-to-avoid-syntaxerror","sha":"c912b7c4c79f915a520bbcdcc6c6230154303088","user":{"login":"mikegroseclose","id":5898306,"avatar_url":"https://avatars.githubusercontent.com/u/5898306?","gravatar_id":"3b308527ac4069c51d34b261d75ef976","url":"https://api.github.com/users/mikegroseclose","html_url":"https://github.com/mikegroseclose","followers_url":"https://api.github.com/users/mikegroseclose/followers","following_url":"https://api.github.com/users/mikegroseclose/following{/other_user}","gists_url":"https://api.github.com/users/mikegroseclose/gists{/gist_id}","starred_url":"https://api.github.com/users/mikegroseclose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikegroseclose/subscriptions","organizations_url":"https://api.github.com/users/mikegroseclose/orgs","repos_url":"https://api.github.com/users/mikegroseclose/repos","events_url":"https://api.github.com/users/mikegroseclose/events{/privacy}","received_events_url":"https://api.github.com/users/mikegroseclose/received_events","type":"User","site_admin":false},"repo":{"id":21252727,"name":"hubot-twitter","full_name":"mikegroseclose/hubot-twitter","owner":{"login":"mikegroseclose","id":5898306,"avatar_url":"https://avatars.githubusercontent.com/u/5898306?","gravatar_id":"3b308527ac4069c51d34b261d75ef976","url":"https://api.github.com/users/mikegroseclose","html_url":"https://github.com/mikegroseclose","followers_url":"https://api.github.com/users/mikegroseclose/followers","following_url":"https://api.github.com/users/mikegroseclose/following{/other_user}","gists_url":"https://api.github.com/users/mikegroseclose/gists{/gist_id}","starred_url":"https://api.github.com/users/mikegroseclose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikegroseclose/subscriptions","organizations_url":"https://api.github.com/users/mikegroseclose/orgs","repos_url":"https://api.github.com/users/mikegroseclose/repos","events_url":"https://api.github.com/users/mikegroseclose/events{/privacy}","received_events_url":"https://api.github.com/users/mikegroseclose/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mikegroseclose/hubot-twitter","description":"Twitter adapter for Hubot","fork":true,"url":"https://api.github.com/repos/mikegroseclose/hubot-twitter","forks_url":"https://api.github.com/repos/mikegroseclose/hubot-twitter/forks","keys_url":"https://api.github.com/repos/mikegroseclose/hubot-twitter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mikegroseclose/hubot-twitter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mikegroseclose/hubot-twitter/teams","hooks_url":"https://api.github.com/repos/mikegroseclose/hubot-twitter/hooks","issue_events_url":"https://api.github.com/repos/mikegroseclose/hubot-twitter/issues/events{/number}","events_url":"https://api.github.com/repos/mikegroseclose/hubot-twitter/events","assignees_url":"https://api.github.com/repos/mikegroseclose/hubot-twitter/assignees{/user}","branches_url":"https://api.github.com/repos/mikegroseclose/hubot-twitter/branches{/branch}","tags_url":"https://api.github.com/repos/mikegroseclose/hubot-twitter/tags","blobs_url":"https://api.github.com/repos/mikegroseclose/hubot-twitter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mikegroseclose/hubot-twitter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mikegroseclose/hubot-twitter/git/refs{/sha}","trees_url":"https://api.github.com/repos/mikegroseclose/hubot-twitter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mikegroseclose/hubot-twitter/statuses/{sha}","languages_url":"https://api.github.com/repos/mikegroseclose/hubot-twitter/languages","stargazers_url":"https://api.github.com/repos/mikegroseclose/hubot-twitter/stargazers","contributors_url":"https://api.github.com/repos/mikegroseclose/hubot-twitter/contributors","subscribers_url":"https://api.github.com/repos/mikegroseclose/hubot-twitter/subscribers","subscription_url":"https://api.github.com/repos/mikegroseclose/hubot-twitter/subscription","commits_url":"https://api.github.com/repos/mikegroseclose/hubot-twitter/commits{/sha}","git_commits_url":"https://api.github.com/repos/mikegroseclose/hubot-twitter/git/commits{/sha}","comments_url":"https://api.github.com/repos/mikegroseclose/hubot-twitter/comments{/number}","issue_comment_url":"https://api.github.com/repos/mikegroseclose/hubot-twitter/issues/comments/{number}","contents_url":"https://api.github.com/repos/mikegroseclose/hubot-twitter/contents/{+path}","compare_url":"https://api.github.com/repos/mikegroseclose/hubot-twitter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mikegroseclose/hubot-twitter/merges","archive_url":"https://api.github.com/repos/mikegroseclose/hubot-twitter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mikegroseclose/hubot-twitter/downloads","issues_url":"https://api.github.com/repos/mikegroseclose/hubot-twitter/issues{/number}","pulls_url":"https://api.github.com/repos/mikegroseclose/hubot-twitter/pulls{/number}","milestones_url":"https://api.github.com/repos/mikegroseclose/hubot-twitter/milestones{/number}","notifications_url":"https://api.github.com/repos/mikegroseclose/hubot-twitter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mikegroseclose/hubot-twitter/labels{/name}","releases_url":"https://api.github.com/repos/mikegroseclose/hubot-twitter/releases{/id}","created_at":"2014-06-26T19:43:56Z","updated_at":"2014-06-22T00:54:05Z","pushed_at":"2014-06-27T00:31:43Z","git_url":"git://github.com/mikegroseclose/hubot-twitter.git","ssh_url":"git@github.com:mikegroseclose/hubot-twitter.git","clone_url":"https://github.com/mikegroseclose/hubot-twitter.git","svn_url":"https://github.com/mikegroseclose/hubot-twitter","homepage":null,"size":173,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MathildeLemee:master","ref":"master","sha":"89515c1c5b79f6280fec7e0488c012bb3f282308","user":{"login":"MathildeLemee","id":794603,"avatar_url":"https://avatars.githubusercontent.com/u/794603?","gravatar_id":"c27a1294054155811ec499d013e113a4","url":"https://api.github.com/users/MathildeLemee","html_url":"https://github.com/MathildeLemee","followers_url":"https://api.github.com/users/MathildeLemee/followers","following_url":"https://api.github.com/users/MathildeLemee/following{/other_user}","gists_url":"https://api.github.com/users/MathildeLemee/gists{/gist_id}","starred_url":"https://api.github.com/users/MathildeLemee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MathildeLemee/subscriptions","organizations_url":"https://api.github.com/users/MathildeLemee/orgs","repos_url":"https://api.github.com/users/MathildeLemee/repos","events_url":"https://api.github.com/users/MathildeLemee/events{/privacy}","received_events_url":"https://api.github.com/users/MathildeLemee/received_events","type":"User","site_admin":false},"repo":{"id":2830807,"name":"hubot-twitter","full_name":"MathildeLemee/hubot-twitter","owner":{"login":"MathildeLemee","id":794603,"avatar_url":"https://avatars.githubusercontent.com/u/794603?","gravatar_id":"c27a1294054155811ec499d013e113a4","url":"https://api.github.com/users/MathildeLemee","html_url":"https://github.com/MathildeLemee","followers_url":"https://api.github.com/users/MathildeLemee/followers","following_url":"https://api.github.com/users/MathildeLemee/following{/other_user}","gists_url":"https://api.github.com/users/MathildeLemee/gists{/gist_id}","starred_url":"https://api.github.com/users/MathildeLemee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MathildeLemee/subscriptions","organizations_url":"https://api.github.com/users/MathildeLemee/orgs","repos_url":"https://api.github.com/users/MathildeLemee/repos","events_url":"https://api.github.com/users/MathildeLemee/events{/privacy}","received_events_url":"https://api.github.com/users/MathildeLemee/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MathildeLemee/hubot-twitter","description":"Twitter adapter for Hubot","fork":false,"url":"https://api.github.com/repos/MathildeLemee/hubot-twitter","forks_url":"https://api.github.com/repos/MathildeLemee/hubot-twitter/forks","keys_url":"https://api.github.com/repos/MathildeLemee/hubot-twitter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MathildeLemee/hubot-twitter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MathildeLemee/hubot-twitter/teams","hooks_url":"https://api.github.com/repos/MathildeLemee/hubot-twitter/hooks","issue_events_url":"https://api.github.com/repos/MathildeLemee/hubot-twitter/issues/events{/number}","events_url":"https://api.github.com/repos/MathildeLemee/hubot-twitter/events","assignees_url":"https://api.github.com/repos/MathildeLemee/hubot-twitter/assignees{/user}","branches_url":"https://api.github.com/repos/MathildeLemee/hubot-twitter/branches{/branch}","tags_url":"https://api.github.com/repos/MathildeLemee/hubot-twitter/tags","blobs_url":"https://api.github.com/repos/MathildeLemee/hubot-twitter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MathildeLemee/hubot-twitter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MathildeLemee/hubot-twitter/git/refs{/sha}","trees_url":"https://api.github.com/repos/MathildeLemee/hubot-twitter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MathildeLemee/hubot-twitter/statuses/{sha}","languages_url":"https://api.github.com/repos/MathildeLemee/hubot-twitter/languages","stargazers_url":"https://api.github.com/repos/MathildeLemee/hubot-twitter/stargazers","contributors_url":"https://api.github.com/repos/MathildeLemee/hubot-twitter/contributors","subscribers_url":"https://api.github.com/repos/MathildeLemee/hubot-twitter/subscribers","subscription_url":"https://api.github.com/repos/MathildeLemee/hubot-twitter/subscription","commits_url":"https://api.github.com/repos/MathildeLemee/hubot-twitter/commits{/sha}","git_commits_url":"https://api.github.com/repos/MathildeLemee/hubot-twitter/git/commits{/sha}","comments_url":"https://api.github.com/repos/MathildeLemee/hubot-twitter/comments{/number}","issue_comment_url":"https://api.github.com/repos/MathildeLemee/hubot-twitter/issues/comments/{number}","contents_url":"https://api.github.com/repos/MathildeLemee/hubot-twitter/contents/{+path}","compare_url":"https://api.github.com/repos/MathildeLemee/hubot-twitter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MathildeLemee/hubot-twitter/merges","archive_url":"https://api.github.com/repos/MathildeLemee/hubot-twitter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MathildeLemee/hubot-twitter/downloads","issues_url":"https://api.github.com/repos/MathildeLemee/hubot-twitter/issues{/number}","pulls_url":"https://api.github.com/repos/MathildeLemee/hubot-twitter/pulls{/number}","milestones_url":"https://api.github.com/repos/MathildeLemee/hubot-twitter/milestones{/number}","notifications_url":"https://api.github.com/repos/MathildeLemee/hubot-twitter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MathildeLemee/hubot-twitter/labels{/name}","releases_url":"https://api.github.com/repos/MathildeLemee/hubot-twitter/releases{/id}","created_at":"2011-11-22T20:43:38Z","updated_at":"2014-06-22T00:54:05Z","pushed_at":"2014-03-30T08:36:39Z","git_url":"git://github.com/MathildeLemee/hubot-twitter.git","ssh_url":"git@github.com:MathildeLemee/hubot-twitter.git","clone_url":"https://github.com/MathildeLemee/hubot-twitter.git","svn_url":"https://github.com/MathildeLemee/hubot-twitter","homepage":null,"size":173,"stargazers_count":33,"watchers_count":33,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":25,"mirror_url":null,"open_issues_count":11,"forks":25,"open_issues":11,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MathildeLemee/hubot-twitter/pulls/19"},"html":{"href":"https://github.com/MathildeLemee/hubot-twitter/pull/19"},"issue":{"href":"https://api.github.com/repos/MathildeLemee/hubot-twitter/issues/19"},"comments":{"href":"https://api.github.com/repos/MathildeLemee/hubot-twitter/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/MathildeLemee/hubot-twitter/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/MathildeLemee/hubot-twitter/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/MathildeLemee/hubot-twitter/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/MathildeLemee/hubot-twitter/statuses/c912b7c4c79f915a520bbcdcc6c6230154303088"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":77,"deletions":78,"changed_files":1}}