GitHub PullRequestReviewCommentEvent at 2014-07-22 23:29:02
Repository: slamengine
Actor: jdegoes
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/slamdata/slamengine/pulls/comments/15262926","id":15262926,"diff_hunk":"@@ -44,20 +44,32 @@ class FileSystemApi(fs: Map[Path, Backend]) {\n   private def dataSourceFor(path: Path): ResponseFunction[Any] \\/ FileSystem = \n     backendFor(path).map(_.dataSource)\n \n+  private def errorResponse(e: Throwable) = e match {","path":"src/main/scala/slamdata/engine/api/fs.scala","position":13,"original_position":13,"commit_id":"15dc7c776df6298d0a653a7b2fdfb1d400de0bf1","original_commit_id":"15dc7c776df6298d0a653a7b2fdfb1d400de0bf1","user":{"login":"jdegoes","id":156745,"avatar_url":"https://avatars.githubusercontent.com/u/156745?","gravatar_id":"6fbccc0537949767c52dfc210003ec9d","url":"https://api.github.com/users/jdegoes","html_url":"https://github.com/jdegoes","followers_url":"https://api.github.com/users/jdegoes/followers","following_url":"https://api.github.com/users/jdegoes/following{/other_user}","gists_url":"https://api.github.com/users/jdegoes/gists{/gist_id}","starred_url":"https://api.github.com/users/jdegoes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdegoes/subscriptions","organizations_url":"https://api.github.com/users/jdegoes/orgs","repos_url":"https://api.github.com/users/jdegoes/repos","events_url":"https://api.github.com/users/jdegoes/events{/privacy}","received_events_url":"https://api.github.com/users/jdegoes/received_events","type":"User","site_admin":false},"body":"This looks good, could you also update README.md to reflect the latest API (i.e. error & phase information)? This way Hardy knows what the structure will look like.","created_at":"2014-07-22T23:29:02Z","updated_at":"2014-07-22T23:29:02Z","html_url":"https://github.com/slamdata/slamengine/pull/134#discussion_r15262926","pull_request_url":"https://api.github.com/repos/slamdata/slamengine/pulls/134","_links":{"self":{"href":"https://api.github.com/repos/slamdata/slamengine/pulls/comments/15262926"},"html":{"href":"https://github.com/slamdata/slamengine/pull/134#discussion_r15262926"},"pull_request":{"href":"https://api.github.com/repos/slamdata/slamengine/pulls/134"}}},"pull_request":{"url":"https://api.github.com/repos/slamdata/slamengine/pulls/134","id":18737337,"html_url":"https://github.com/slamdata/slamengine/pull/134","diff_url":"https://github.com/slamdata/slamengine/pull/134.diff","patch_url":"https://github.com/slamdata/slamengine/pull/134.patch","issue_url":"https://api.github.com/repos/slamdata/slamengine/issues/134","number":134,"state":"open","title":"Capture result from each (major) phase as trees in API","user":{"login":"mossprescott","id":6147371,"avatar_url":"https://avatars.githubusercontent.com/u/6147371?","gravatar_id":"8efbcab730ad4274206c593a1a907dfb","url":"https://api.github.com/users/mossprescott","html_url":"https://github.com/mossprescott","followers_url":"https://api.github.com/users/mossprescott/followers","following_url":"https://api.github.com/users/mossprescott/following{/other_user}","gists_url":"https://api.github.com/users/mossprescott/gists{/gist_id}","starred_url":"https://api.github.com/users/mossprescott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mossprescott/subscriptions","organizations_url":"https://api.github.com/users/mossprescott/orgs","repos_url":"https://api.github.com/users/mossprescott/repos","events_url":"https://api.github.com/users/mossprescott/events{/privacy}","received_events_url":"https://api.github.com/users/mossprescott/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-07-22T19:53:31Z","updated_at":"2014-07-22T23:29:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c9afabd22c22f5ca134db3e5eb1cab6a1344909","assignee":{"login":"jdegoes","id":156745,"avatar_url":"https://avatars.githubusercontent.com/u/156745?","gravatar_id":"6fbccc0537949767c52dfc210003ec9d","url":"https://api.github.com/users/jdegoes","html_url":"https://github.com/jdegoes","followers_url":"https://api.github.com/users/jdegoes/followers","following_url":"https://api.github.com/users/jdegoes/following{/other_user}","gists_url":"https://api.github.com/users/jdegoes/gists{/gist_id}","starred_url":"https://api.github.com/users/jdegoes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdegoes/subscriptions","organizations_url":"https://api.github.com/users/jdegoes/orgs","repos_url":"https://api.github.com/users/jdegoes/repos","events_url":"https://api.github.com/users/jdegoes/events{/privacy}","received_events_url":"https://api.github.com/users/jdegoes/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/slamdata/slamengine/pulls/134/commits","review_comments_url":"https://api.github.com/repos/slamdata/slamengine/pulls/134/comments","review_comment_url":"https://api.github.com/repos/slamdata/slamengine/pulls/comments/{number}","comments_url":"https://api.github.com/repos/slamdata/slamengine/issues/134/comments","statuses_url":"https://api.github.com/repos/slamdata/slamengine/statuses/15dc7c776df6298d0a653a7b2fdfb1d400de0bf1","head":{"label":"mossprescott:wip/133","ref":"wip/133","sha":"15dc7c776df6298d0a653a7b2fdfb1d400de0bf1","user":{"login":"mossprescott","id":6147371,"avatar_url":"https://avatars.githubusercontent.com/u/6147371?","gravatar_id":"8efbcab730ad4274206c593a1a907dfb","url":"https://api.github.com/users/mossprescott","html_url":"https://github.com/mossprescott","followers_url":"https://api.github.com/users/mossprescott/followers","following_url":"https://api.github.com/users/mossprescott/following{/other_user}","gists_url":"https://api.github.com/users/mossprescott/gists{/gist_id}","starred_url":"https://api.github.com/users/mossprescott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mossprescott/subscriptions","organizations_url":"https://api.github.com/users/mossprescott/orgs","repos_url":"https://api.github.com/users/mossprescott/repos","events_url":"https://api.github.com/users/mossprescott/events{/privacy}","received_events_url":"https://api.github.com/users/mossprescott/received_events","type":"User","site_admin":false},"repo":{"id":21178367,"name":"slamengine-1","full_name":"mossprescott/slamengine-1","owner":{"login":"mossprescott","id":6147371,"avatar_url":"https://avatars.githubusercontent.com/u/6147371?","gravatar_id":"8efbcab730ad4274206c593a1a907dfb","url":"https://api.github.com/users/mossprescott","html_url":"https://github.com/mossprescott","followers_url":"https://api.github.com/users/mossprescott/followers","following_url":"https://api.github.com/users/mossprescott/following{/other_user}","gists_url":"https://api.github.com/users/mossprescott/gists{/gist_id}","starred_url":"https://api.github.com/users/mossprescott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mossprescott/subscriptions","organizations_url":"https://api.github.com/users/mossprescott/orgs","repos_url":"https://api.github.com/users/mossprescott/repos","events_url":"https://api.github.com/users/mossprescott/events{/privacy}","received_events_url":"https://api.github.com/users/mossprescott/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mossprescott/slamengine-1","description":"The engine for SlamData","fork":true,"url":"https://api.github.com/repos/mossprescott/slamengine-1","forks_url":"https://api.github.com/repos/mossprescott/slamengine-1/forks","keys_url":"https://api.github.com/repos/mossprescott/slamengine-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mossprescott/slamengine-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mossprescott/slamengine-1/teams","hooks_url":"https://api.github.com/repos/mossprescott/slamengine-1/hooks","issue_events_url":"https://api.github.com/repos/mossprescott/slamengine-1/issues/events{/number}","events_url":"https://api.github.com/repos/mossprescott/slamengine-1/events","assignees_url":"https://api.github.com/repos/mossprescott/slamengine-1/assignees{/user}","branches_url":"https://api.github.com/repos/mossprescott/slamengine-1/branches{/branch}","tags_url":"https://api.github.com/repos/mossprescott/slamengine-1/tags","blobs_url":"https://api.github.com/repos/mossprescott/slamengine-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mossprescott/slamengine-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mossprescott/slamengine-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/mossprescott/slamengine-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mossprescott/slamengine-1/statuses/{sha}","languages_url":"https://api.github.com/repos/mossprescott/slamengine-1/languages","stargazers_url":"https://api.github.com/repos/mossprescott/slamengine-1/stargazers","contributors_url":"https://api.github.com/repos/mossprescott/slamengine-1/contributors","subscribers_url":"https://api.github.com/repos/mossprescott/slamengine-1/subscribers","subscription_url":"https://api.github.com/repos/mossprescott/slamengine-1/subscription","commits_url":"https://api.github.com/repos/mossprescott/slamengine-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/mossprescott/slamengine-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/mossprescott/slamengine-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/mossprescott/slamengine-1/issues/comments/{number}","contents_url":"https://api.github.com/repos/mossprescott/slamengine-1/contents/{+path}","compare_url":"https://api.github.com/repos/mossprescott/slamengine-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mossprescott/slamengine-1/merges","archive_url":"https://api.github.com/repos/mossprescott/slamengine-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mossprescott/slamengine-1/downloads","issues_url":"https://api.github.com/repos/mossprescott/slamengine-1/issues{/number}","pulls_url":"https://api.github.com/repos/mossprescott/slamengine-1/pulls{/number}","milestones_url":"https://api.github.com/repos/mossprescott/slamengine-1/milestones{/number}","notifications_url":"https://api.github.com/repos/mossprescott/slamengine-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mossprescott/slamengine-1/labels{/name}","releases_url":"https://api.github.com/repos/mossprescott/slamengine-1/releases{/id}","created_at":"2014-06-24T19:43:22Z","updated_at":"2014-06-28T16:58:26Z","pushed_at":"2014-07-22T22:26:15Z","git_url":"git://github.com/mossprescott/slamengine-1.git","ssh_url":"git@github.com:mossprescott/slamengine-1.git","clone_url":"https://github.com/mossprescott/slamengine-1.git","svn_url":"https://github.com/mossprescott/slamengine-1","homepage":null,"size":2060,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"slamdata:master","ref":"master","sha":"0553bd17a46b841daf955a0539b25ee41b5f5380","user":{"login":"slamdata","id":5385602,"avatar_url":"https://avatars.githubusercontent.com/u/5385602?","gravatar_id":"432a134a22bd5f9d9fd3c00d5c750405","url":"https://api.github.com/users/slamdata","html_url":"https://github.com/slamdata","followers_url":"https://api.github.com/users/slamdata/followers","following_url":"https://api.github.com/users/slamdata/following{/other_user}","gists_url":"https://api.github.com/users/slamdata/gists{/gist_id}","starred_url":"https://api.github.com/users/slamdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slamdata/subscriptions","organizations_url":"https://api.github.com/users/slamdata/orgs","repos_url":"https://api.github.com/users/slamdata/repos","events_url":"https://api.github.com/users/slamdata/events{/privacy}","received_events_url":"https://api.github.com/users/slamdata/received_events","type":"Organization","site_admin":false},"repo":{"id":16515058,"name":"slamengine","full_name":"slamdata/slamengine","owner":{"login":"slamdata","id":5385602,"avatar_url":"https://avatars.githubusercontent.com/u/5385602?","gravatar_id":"432a134a22bd5f9d9fd3c00d5c750405","url":"https://api.github.com/users/slamdata","html_url":"https://github.com/slamdata","followers_url":"https://api.github.com/users/slamdata/followers","following_url":"https://api.github.com/users/slamdata/following{/other_user}","gists_url":"https://api.github.com/users/slamdata/gists{/gist_id}","starred_url":"https://api.github.com/users/slamdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slamdata/subscriptions","organizations_url":"https://api.github.com/users/slamdata/orgs","repos_url":"https://api.github.com/users/slamdata/repos","events_url":"https://api.github.com/users/slamdata/events{/privacy}","received_events_url":"https://api.github.com/users/slamdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/slamdata/slamengine","description":"The engine for SlamData","fork":false,"url":"https://api.github.com/repos/slamdata/slamengine","forks_url":"https://api.github.com/repos/slamdata/slamengine/forks","keys_url":"https://api.github.com/repos/slamdata/slamengine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slamdata/slamengine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slamdata/slamengine/teams","hooks_url":"https://api.github.com/repos/slamdata/slamengine/hooks","issue_events_url":"https://api.github.com/repos/slamdata/slamengine/issues/events{/number}","events_url":"https://api.github.com/repos/slamdata/slamengine/events","assignees_url":"https://api.github.com/repos/slamdata/slamengine/assignees{/user}","branches_url":"https://api.github.com/repos/slamdata/slamengine/branches{/branch}","tags_url":"https://api.github.com/repos/slamdata/slamengine/tags","blobs_url":"https://api.github.com/repos/slamdata/slamengine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slamdata/slamengine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slamdata/slamengine/git/refs{/sha}","trees_url":"https://api.github.com/repos/slamdata/slamengine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slamdata/slamengine/statuses/{sha}","languages_url":"https://api.github.com/repos/slamdata/slamengine/languages","stargazers_url":"https://api.github.com/repos/slamdata/slamengine/stargazers","contributors_url":"https://api.github.com/repos/slamdata/slamengine/contributors","subscribers_url":"https://api.github.com/repos/slamdata/slamengine/subscribers","subscription_url":"https://api.github.com/repos/slamdata/slamengine/subscription","commits_url":"https://api.github.com/repos/slamdata/slamengine/commits{/sha}","git_commits_url":"https://api.github.com/repos/slamdata/slamengine/git/commits{/sha}","comments_url":"https://api.github.com/repos/slamdata/slamengine/comments{/number}","issue_comment_url":"https://api.github.com/repos/slamdata/slamengine/issues/comments/{number}","contents_url":"https://api.github.com/repos/slamdata/slamengine/contents/{+path}","compare_url":"https://api.github.com/repos/slamdata/slamengine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slamdata/slamengine/merges","archive_url":"https://api.github.com/repos/slamdata/slamengine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slamdata/slamengine/downloads","issues_url":"https://api.github.com/repos/slamdata/slamengine/issues{/number}","pulls_url":"https://api.github.com/repos/slamdata/slamengine/pulls{/number}","milestones_url":"https://api.github.com/repos/slamdata/slamengine/milestones{/number}","notifications_url":"https://api.github.com/repos/slamdata/slamengine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slamdata/slamengine/labels{/name}","releases_url":"https://api.github.com/repos/slamdata/slamengine/releases{/id}","created_at":"2014-02-04T15:01:27Z","updated_at":"2014-07-22T10:37:26Z","pushed_at":"2014-07-15T00:51:56Z","git_url":"git://github.com/slamdata/slamengine.git","ssh_url":"git@github.com:slamdata/slamengine.git","clone_url":"https://github.com/slamdata/slamengine.git","svn_url":"https://github.com/slamdata/slamengine","homepage":null,"size":4823,"stargazers_count":13,"watchers_count":13,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":6,"mirror_url":null,"open_issues_count":40,"forks":6,"open_issues":40,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/slamdata/slamengine/pulls/134"},"html":{"href":"https://github.com/slamdata/slamengine/pull/134"},"issue":{"href":"https://api.github.com/repos/slamdata/slamengine/issues/134"},"comments":{"href":"https://api.github.com/repos/slamdata/slamengine/issues/134/comments"},"review_comments":{"href":"https://api.github.com/repos/slamdata/slamengine/pulls/134/comments"},"review_comment":{"href":"https://api.github.com/repos/slamdata/slamengine/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/slamdata/slamengine/pulls/134/commits"},"statuses":{"href":"https://api.github.com/repos/slamdata/slamengine/statuses/15dc7c776df6298d0a653a7b2fdfb1d400de0bf1"}}}}