GitHub PullRequestReviewCommentEvent at 2014-11-14 17:01:18
Repository: osgjs
Actor: Kuranes
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/cedricpinson/osgjs/pulls/comments/20371169","id":20371169,"diff_hunk":"@@ -400,14 +426,23 @@\n             idx = this._textureNames.indexOf( this._config.texture3Unit0 );\n             if ( idx < 0 ) idx = 0;\n             texture = this._textures[ idx ];\n+            texture.setMinFilter( this._config.texture3UnitMinFilter );\n+            texture.setMagFilter( this._config.texture3UnitMagFilter );\n+            texture.setAnisotropy( this._config.texture3UnitAnisotropy );\n+            //TODO: better dirty when setting dynamically a filter\n+            texture.releaseGLObjects();","path":"examples/materials/main.js","position":88,"original_position":88,"commit_id":"bfdc79df53af34d127f7b1a5420ee8b41b182424","original_commit_id":"bfdc79df53af34d127f7b1a5420ee8b41b182424","user":{"login":"Kuranes","id":128571,"avatar_url":"https://avatars.githubusercontent.com/u/128571?v=3","gravatar_id":"","url":"https://api.github.com/users/Kuranes","html_url":"https://github.com/Kuranes","followers_url":"https://api.github.com/users/Kuranes/followers","following_url":"https://api.github.com/users/Kuranes/following{/other_user}","gists_url":"https://api.github.com/users/Kuranes/gists{/gist_id}","starred_url":"https://api.github.com/users/Kuranes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kuranes/subscriptions","organizations_url":"https://api.github.com/users/Kuranes/orgs","repos_url":"https://api.github.com/users/Kuranes/repos","events_url":"https://api.github.com/users/Kuranes/events{/privacy}","received_events_url":"https://api.github.com/users/Kuranes/received_events","type":"User","site_admin":false},"body":"Without that line, nothing will happen.\r\nNo dirty is set by either setMinFilter or setMagFilter\r\nEven if dirty was set, the texture::apply(state) wouldn't do anything, as it doesn't check for it","created_at":"2014-11-14T17:01:18Z","updated_at":"2014-11-14T17:01:18Z","html_url":"https://github.com/cedricpinson/osgjs/pull/171#discussion_r20371169","pull_request_url":"https://api.github.com/repos/cedricpinson/osgjs/pulls/171","_links":{"self":{"href":"https://api.github.com/repos/cedricpinson/osgjs/pulls/comments/20371169"},"html":{"href":"https://github.com/cedricpinson/osgjs/pull/171#discussion_r20371169"},"pull_request":{"href":"https://api.github.com/repos/cedricpinson/osgjs/pulls/171"}}},"pull_request":{"url":"https://api.github.com/repos/cedricpinson/osgjs/pulls/171","id":24454851,"html_url":"https://github.com/cedricpinson/osgjs/pull/171","diff_url":"https://github.com/cedricpinson/osgjs/pull/171.diff","patch_url":"https://github.com/cedricpinson/osgjs/pull/171.patch","issue_url":"https://api.github.com/repos/cedricpinson/osgjs/issues/171","number":171,"state":"open","locked":false,"title":"Adds Texture:setAnisotropy( filter multiplier)  method","user":{"login":"Kuranes","id":128571,"avatar_url":"https://avatars.githubusercontent.com/u/128571?v=3","gravatar_id":"","url":"https://api.github.com/users/Kuranes","html_url":"https://github.com/Kuranes","followers_url":"https://api.github.com/users/Kuranes/followers","following_url":"https://api.github.com/users/Kuranes/following{/other_user}","gists_url":"https://api.github.com/users/Kuranes/gists{/gist_id}","starred_url":"https://api.github.com/users/Kuranes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kuranes/subscriptions","organizations_url":"https://api.github.com/users/Kuranes/orgs","repos_url":"https://api.github.com/users/Kuranes/repos","events_url":"https://api.github.com/users/Kuranes/events{/privacy}","received_events_url":"https://api.github.com/users/Kuranes/received_events","type":"User","site_admin":false},"body":"- Much better quality when enabled, gracefully handle non supporting (<3%) and multiplier set to > max hardware aniso supported\r\n- added comments (notably the NPOT thing whe should check)\r\n- commented the releaseGLobject that was emptying this._image, which was preventing user side dirty/recreation of gl object from same image when you just change the texture parameters. (ought to be much more friendly, that... osgjs user would expect setting a magfilter would work without him having to manually realase the gl object.)","created_at":"2014-11-14T16:58:53Z","updated_at":"2014-11-14T17:01:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd7576c9467908766ab66278aac88cc9d386ef1b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cedricpinson/osgjs/pulls/171/commits","review_comments_url":"https://api.github.com/repos/cedricpinson/osgjs/pulls/171/comments","review_comment_url":"https://api.github.com/repos/cedricpinson/osgjs/pulls/comments/{number}","comments_url":"https://api.github.com/repos/cedricpinson/osgjs/issues/171/comments","statuses_url":"https://api.github.com/repos/cedricpinson/osgjs/statuses/bfdc79df53af34d127f7b1a5420ee8b41b182424","head":{"label":"cedricpinson:feature/textureAnisotropy","ref":"feature/textureAnisotropy","sha":"bfdc79df53af34d127f7b1a5420ee8b41b182424","user":{"login":"cedricpinson","id":351686,"avatar_url":"https://avatars.githubusercontent.com/u/351686?v=3","gravatar_id":"","url":"https://api.github.com/users/cedricpinson","html_url":"https://github.com/cedricpinson","followers_url":"https://api.github.com/users/cedricpinson/followers","following_url":"https://api.github.com/users/cedricpinson/following{/other_user}","gists_url":"https://api.github.com/users/cedricpinson/gists{/gist_id}","starred_url":"https://api.github.com/users/cedricpinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cedricpinson/subscriptions","organizations_url":"https://api.github.com/users/cedricpinson/orgs","repos_url":"https://api.github.com/users/cedricpinson/repos","events_url":"https://api.github.com/users/cedricpinson/events{/privacy}","received_events_url":"https://api.github.com/users/cedricpinson/received_events","type":"User","site_admin":false},"repo":{"id":1675632,"name":"osgjs","full_name":"cedricpinson/osgjs","owner":{"login":"cedricpinson","id":351686,"avatar_url":"https://avatars.githubusercontent.com/u/351686?v=3","gravatar_id":"","url":"https://api.github.com/users/cedricpinson","html_url":"https://github.com/cedricpinson","followers_url":"https://api.github.com/users/cedricpinson/followers","following_url":"https://api.github.com/users/cedricpinson/following{/other_user}","gists_url":"https://api.github.com/users/cedricpinson/gists{/gist_id}","starred_url":"https://api.github.com/users/cedricpinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cedricpinson/subscriptions","organizations_url":"https://api.github.com/users/cedricpinson/orgs","repos_url":"https://api.github.com/users/cedricpinson/repos","events_url":"https://api.github.com/users/cedricpinson/events{/privacy}","received_events_url":"https://api.github.com/users/cedricpinson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cedricpinson/osgjs","description":"Javascript Implementation of OpenSceneGraph","fork":false,"url":"https://api.github.com/repos/cedricpinson/osgjs","forks_url":"https://api.github.com/repos/cedricpinson/osgjs/forks","keys_url":"https://api.github.com/repos/cedricpinson/osgjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cedricpinson/osgjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cedricpinson/osgjs/teams","hooks_url":"https://api.github.com/repos/cedricpinson/osgjs/hooks","issue_events_url":"https://api.github.com/repos/cedricpinson/osgjs/issues/events{/number}","events_url":"https://api.github.com/repos/cedricpinson/osgjs/events","assignees_url":"https://api.github.com/repos/cedricpinson/osgjs/assignees{/user}","branches_url":"https://api.github.com/repos/cedricpinson/osgjs/branches{/branch}","tags_url":"https://api.github.com/repos/cedricpinson/osgjs/tags","blobs_url":"https://api.github.com/repos/cedricpinson/osgjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cedricpinson/osgjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cedricpinson/osgjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/cedricpinson/osgjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cedricpinson/osgjs/statuses/{sha}","languages_url":"https://api.github.com/repos/cedricpinson/osgjs/languages","stargazers_url":"https://api.github.com/repos/cedricpinson/osgjs/stargazers","contributors_url":"https://api.github.com/repos/cedricpinson/osgjs/contributors","subscribers_url":"https://api.github.com/repos/cedricpinson/osgjs/subscribers","subscription_url":"https://api.github.com/repos/cedricpinson/osgjs/subscription","commits_url":"https://api.github.com/repos/cedricpinson/osgjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/cedricpinson/osgjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/cedricpinson/osgjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/cedricpinson/osgjs/issues/comments/{number}","contents_url":"https://api.github.com/repos/cedricpinson/osgjs/contents/{+path}","compare_url":"https://api.github.com/repos/cedricpinson/osgjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cedricpinson/osgjs/merges","archive_url":"https://api.github.com/repos/cedricpinson/osgjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cedricpinson/osgjs/downloads","issues_url":"https://api.github.com/repos/cedricpinson/osgjs/issues{/number}","pulls_url":"https://api.github.com/repos/cedricpinson/osgjs/pulls{/number}","milestones_url":"https://api.github.com/repos/cedricpinson/osgjs/milestones{/number}","notifications_url":"https://api.github.com/repos/cedricpinson/osgjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cedricpinson/osgjs/labels{/name}","releases_url":"https://api.github.com/repos/cedricpinson/osgjs/releases{/id}","created_at":"2011-04-28T12:36:33Z","updated_at":"2014-10-21T04:51:40Z","pushed_at":"2014-11-14T16:55:47Z","git_url":"git://github.com/cedricpinson/osgjs.git","ssh_url":"git@github.com:cedricpinson/osgjs.git","clone_url":"https://github.com/cedricpinson/osgjs.git","svn_url":"https://github.com/cedricpinson/osgjs","homepage":"http://osgjs.org","size":358478,"stargazers_count":156,"watchers_count":156,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":38,"mirror_url":null,"open_issues_count":12,"forks":38,"open_issues":12,"watchers":156,"default_branch":"develop"}},"base":{"label":"cedricpinson:develop","ref":"develop","sha":"56daca447817a03e84034c3b0474972647840154","user":{"login":"cedricpinson","id":351686,"avatar_url":"https://avatars.githubusercontent.com/u/351686?v=3","gravatar_id":"","url":"https://api.github.com/users/cedricpinson","html_url":"https://github.com/cedricpinson","followers_url":"https://api.github.com/users/cedricpinson/followers","following_url":"https://api.github.com/users/cedricpinson/following{/other_user}","gists_url":"https://api.github.com/users/cedricpinson/gists{/gist_id}","starred_url":"https://api.github.com/users/cedricpinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cedricpinson/subscriptions","organizations_url":"https://api.github.com/users/cedricpinson/orgs","repos_url":"https://api.github.com/users/cedricpinson/repos","events_url":"https://api.github.com/users/cedricpinson/events{/privacy}","received_events_url":"https://api.github.com/users/cedricpinson/received_events","type":"User","site_admin":false},"repo":{"id":1675632,"name":"osgjs","full_name":"cedricpinson/osgjs","owner":{"login":"cedricpinson","id":351686,"avatar_url":"https://avatars.githubusercontent.com/u/351686?v=3","gravatar_id":"","url":"https://api.github.com/users/cedricpinson","html_url":"https://github.com/cedricpinson","followers_url":"https://api.github.com/users/cedricpinson/followers","following_url":"https://api.github.com/users/cedricpinson/following{/other_user}","gists_url":"https://api.github.com/users/cedricpinson/gists{/gist_id}","starred_url":"https://api.github.com/users/cedricpinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cedricpinson/subscriptions","organizations_url":"https://api.github.com/users/cedricpinson/orgs","repos_url":"https://api.github.com/users/cedricpinson/repos","events_url":"https://api.github.com/users/cedricpinson/events{/privacy}","received_events_url":"https://api.github.com/users/cedricpinson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cedricpinson/osgjs","description":"Javascript Implementation of OpenSceneGraph","fork":false,"url":"https://api.github.com/repos/cedricpinson/osgjs","forks_url":"https://api.github.com/repos/cedricpinson/osgjs/forks","keys_url":"https://api.github.com/repos/cedricpinson/osgjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cedricpinson/osgjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cedricpinson/osgjs/teams","hooks_url":"https://api.github.com/repos/cedricpinson/osgjs/hooks","issue_events_url":"https://api.github.com/repos/cedricpinson/osgjs/issues/events{/number}","events_url":"https://api.github.com/repos/cedricpinson/osgjs/events","assignees_url":"https://api.github.com/repos/cedricpinson/osgjs/assignees{/user}","branches_url":"https://api.github.com/repos/cedricpinson/osgjs/branches{/branch}","tags_url":"https://api.github.com/repos/cedricpinson/osgjs/tags","blobs_url":"https://api.github.com/repos/cedricpinson/osgjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cedricpinson/osgjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cedricpinson/osgjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/cedricpinson/osgjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cedricpinson/osgjs/statuses/{sha}","languages_url":"https://api.github.com/repos/cedricpinson/osgjs/languages","stargazers_url":"https://api.github.com/repos/cedricpinson/osgjs/stargazers","contributors_url":"https://api.github.com/repos/cedricpinson/osgjs/contributors","subscribers_url":"https://api.github.com/repos/cedricpinson/osgjs/subscribers","subscription_url":"https://api.github.com/repos/cedricpinson/osgjs/subscription","commits_url":"https://api.github.com/repos/cedricpinson/osgjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/cedricpinson/osgjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/cedricpinson/osgjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/cedricpinson/osgjs/issues/comments/{number}","contents_url":"https://api.github.com/repos/cedricpinson/osgjs/contents/{+path}","compare_url":"https://api.github.com/repos/cedricpinson/osgjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cedricpinson/osgjs/merges","archive_url":"https://api.github.com/repos/cedricpinson/osgjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cedricpinson/osgjs/downloads","issues_url":"https://api.github.com/repos/cedricpinson/osgjs/issues{/number}","pulls_url":"https://api.github.com/repos/cedricpinson/osgjs/pulls{/number}","milestones_url":"https://api.github.com/repos/cedricpinson/osgjs/milestones{/number}","notifications_url":"https://api.github.com/repos/cedricpinson/osgjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cedricpinson/osgjs/labels{/name}","releases_url":"https://api.github.com/repos/cedricpinson/osgjs/releases{/id}","created_at":"2011-04-28T12:36:33Z","updated_at":"2014-10-21T04:51:40Z","pushed_at":"2014-11-14T16:55:47Z","git_url":"git://github.com/cedricpinson/osgjs.git","ssh_url":"git@github.com:cedricpinson/osgjs.git","clone_url":"https://github.com/cedricpinson/osgjs.git","svn_url":"https://github.com/cedricpinson/osgjs","homepage":"http://osgjs.org","size":358478,"stargazers_count":156,"watchers_count":156,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":38,"mirror_url":null,"open_issues_count":12,"forks":38,"open_issues":12,"watchers":156,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/cedricpinson/osgjs/pulls/171"},"html":{"href":"https://github.com/cedricpinson/osgjs/pull/171"},"issue":{"href":"https://api.github.com/repos/cedricpinson/osgjs/issues/171"},"comments":{"href":"https://api.github.com/repos/cedricpinson/osgjs/issues/171/comments"},"review_comments":{"href":"https://api.github.com/repos/cedricpinson/osgjs/pulls/171/comments"},"review_comment":{"href":"https://api.github.com/repos/cedricpinson/osgjs/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/cedricpinson/osgjs/pulls/171/commits"},"statuses":{"href":"https://api.github.com/repos/cedricpinson/osgjs/statuses/bfdc79df53af34d127f7b1a5420ee8b41b182424"}}}}