GitHub PullRequestReviewCommentEvent at 2014-12-10 23:35:10
Repository: phobos
Actor: Hackerpilot
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/comments/21647901","id":21647901,"diff_hunk":"@@ -1179,6 +1184,17 @@ immutable(C)[] buildNormalizedPath(C)(const(C[])[] paths...)\n     if (isSomeChar!C)\n {\n     import core.stdc.stdlib;\n+\n+    //Remove empty fields\n+    bool allEmpty = true;\n+    foreach(ref const(C[]) path ; paths){","path":"std/path.d","position":27,"original_position":27,"commit_id":"c7654bdbc38b20260d8c8c8a93e09b28690b0201","original_commit_id":"c7654bdbc38b20260d8c8c8a93e09b28690b0201","user":{"login":"Hackerpilot","id":1657783,"avatar_url":"https://avatars.githubusercontent.com/u/1657783?v=3","gravatar_id":"","url":"https://api.github.com/users/Hackerpilot","html_url":"https://github.com/Hackerpilot","followers_url":"https://api.github.com/users/Hackerpilot/followers","following_url":"https://api.github.com/users/Hackerpilot/following{/other_user}","gists_url":"https://api.github.com/users/Hackerpilot/gists{/gist_id}","starred_url":"https://api.github.com/users/Hackerpilot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hackerpilot/subscriptions","organizations_url":"https://api.github.com/users/Hackerpilot/orgs","repos_url":"https://api.github.com/users/Hackerpilot/repos","events_url":"https://api.github.com/users/Hackerpilot/events{/privacy}","received_events_url":"https://api.github.com/users/Hackerpilot/received_events","type":"User","site_admin":false},"body":"Please put braces on their own line: http://dlang.org/dstyle.html.","created_at":"2014-12-10T23:35:10Z","updated_at":"2014-12-10T23:35:10Z","html_url":"https://github.com/D-Programming-Language/phobos/pull/2791#discussion_r21647901","pull_request_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2791","_links":{"self":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/comments/21647901"},"html":{"href":"https://github.com/D-Programming-Language/phobos/pull/2791#discussion_r21647901"},"pull_request":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2791"}}},"pull_request":{"url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2791","id":25734367,"html_url":"https://github.com/D-Programming-Language/phobos/pull/2791","diff_url":"https://github.com/D-Programming-Language/phobos/pull/2791.diff","patch_url":"https://github.com/D-Programming-Language/phobos/pull/2791.patch","issue_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/2791","number":2791,"state":"open","locked":false,"title":"Fix Issue 12114 - buildNormalizedPath returns null instead of \".\"","user":{"login":"CromFr","id":999188,"avatar_url":"https://avatars.githubusercontent.com/u/999188?v=3","gravatar_id":"","url":"https://api.github.com/users/CromFr","html_url":"https://github.com/CromFr","followers_url":"https://api.github.com/users/CromFr/followers","following_url":"https://api.github.com/users/CromFr/following{/other_user}","gists_url":"https://api.github.com/users/CromFr/gists{/gist_id}","starred_url":"https://api.github.com/users/CromFr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CromFr/subscriptions","organizations_url":"https://api.github.com/users/CromFr/orgs","repos_url":"https://api.github.com/users/CromFr/repos","events_url":"https://api.github.com/users/CromFr/events{/privacy}","received_events_url":"https://api.github.com/users/CromFr/received_events","type":"User","site_admin":false},"body":"[Issue details](https://issues.dlang.org/show_bug.cgi?id=12114)\r\n\r\nin short:\r\n`buildNormalizedPath(\".\")` and `buildNormalizedPath(\"foo\", \"..\")` should both return `.` instead of null","created_at":"2014-12-09T10:59:19Z","updated_at":"2014-12-10T23:35:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d3b412cde5c00809188f4ed74fa66ef9e5041905","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2791/commits","review_comments_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2791/comments","review_comment_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/comments/{number}","comments_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/2791/comments","statuses_url":"https://api.github.com/repos/D-Programming-Language/phobos/statuses/c7654bdbc38b20260d8c8c8a93e09b28690b0201","head":{"label":"CromFr:issue_12114","ref":"issue_12114","sha":"c7654bdbc38b20260d8c8c8a93e09b28690b0201","user":{"login":"CromFr","id":999188,"avatar_url":"https://avatars.githubusercontent.com/u/999188?v=3","gravatar_id":"","url":"https://api.github.com/users/CromFr","html_url":"https://github.com/CromFr","followers_url":"https://api.github.com/users/CromFr/followers","following_url":"https://api.github.com/users/CromFr/following{/other_user}","gists_url":"https://api.github.com/users/CromFr/gists{/gist_id}","starred_url":"https://api.github.com/users/CromFr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CromFr/subscriptions","organizations_url":"https://api.github.com/users/CromFr/orgs","repos_url":"https://api.github.com/users/CromFr/repos","events_url":"https://api.github.com/users/CromFr/events{/privacy}","received_events_url":"https://api.github.com/users/CromFr/received_events","type":"User","site_admin":false},"repo":{"id":27706639,"name":"phobos","full_name":"CromFr/phobos","owner":{"login":"CromFr","id":999188,"avatar_url":"https://avatars.githubusercontent.com/u/999188?v=3","gravatar_id":"","url":"https://api.github.com/users/CromFr","html_url":"https://github.com/CromFr","followers_url":"https://api.github.com/users/CromFr/followers","following_url":"https://api.github.com/users/CromFr/following{/other_user}","gists_url":"https://api.github.com/users/CromFr/gists{/gist_id}","starred_url":"https://api.github.com/users/CromFr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CromFr/subscriptions","organizations_url":"https://api.github.com/users/CromFr/orgs","repos_url":"https://api.github.com/users/CromFr/repos","events_url":"https://api.github.com/users/CromFr/events{/privacy}","received_events_url":"https://api.github.com/users/CromFr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/CromFr/phobos","description":"The standard library of the D programming language","fork":true,"url":"https://api.github.com/repos/CromFr/phobos","forks_url":"https://api.github.com/repos/CromFr/phobos/forks","keys_url":"https://api.github.com/repos/CromFr/phobos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CromFr/phobos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CromFr/phobos/teams","hooks_url":"https://api.github.com/repos/CromFr/phobos/hooks","issue_events_url":"https://api.github.com/repos/CromFr/phobos/issues/events{/number}","events_url":"https://api.github.com/repos/CromFr/phobos/events","assignees_url":"https://api.github.com/repos/CromFr/phobos/assignees{/user}","branches_url":"https://api.github.com/repos/CromFr/phobos/branches{/branch}","tags_url":"https://api.github.com/repos/CromFr/phobos/tags","blobs_url":"https://api.github.com/repos/CromFr/phobos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CromFr/phobos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CromFr/phobos/git/refs{/sha}","trees_url":"https://api.github.com/repos/CromFr/phobos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CromFr/phobos/statuses/{sha}","languages_url":"https://api.github.com/repos/CromFr/phobos/languages","stargazers_url":"https://api.github.com/repos/CromFr/phobos/stargazers","contributors_url":"https://api.github.com/repos/CromFr/phobos/contributors","subscribers_url":"https://api.github.com/repos/CromFr/phobos/subscribers","subscription_url":"https://api.github.com/repos/CromFr/phobos/subscription","commits_url":"https://api.github.com/repos/CromFr/phobos/commits{/sha}","git_commits_url":"https://api.github.com/repos/CromFr/phobos/git/commits{/sha}","comments_url":"https://api.github.com/repos/CromFr/phobos/comments{/number}","issue_comment_url":"https://api.github.com/repos/CromFr/phobos/issues/comments/{number}","contents_url":"https://api.github.com/repos/CromFr/phobos/contents/{+path}","compare_url":"https://api.github.com/repos/CromFr/phobos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CromFr/phobos/merges","archive_url":"https://api.github.com/repos/CromFr/phobos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CromFr/phobos/downloads","issues_url":"https://api.github.com/repos/CromFr/phobos/issues{/number}","pulls_url":"https://api.github.com/repos/CromFr/phobos/pulls{/number}","milestones_url":"https://api.github.com/repos/CromFr/phobos/milestones{/number}","notifications_url":"https://api.github.com/repos/CromFr/phobos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CromFr/phobos/labels{/name}","releases_url":"https://api.github.com/repos/CromFr/phobos/releases{/id}","created_at":"2014-12-08T09:09:22Z","updated_at":"2014-12-08T09:09:24Z","pushed_at":"2014-12-10T13:54:33Z","git_url":"git://github.com/CromFr/phobos.git","ssh_url":"git@github.com:CromFr/phobos.git","clone_url":"https://github.com/CromFr/phobos.git","svn_url":"https://github.com/CromFr/phobos","homepage":"dlang.org/phobos","size":35289,"stargazers_count":0,"watchers_count":0,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"D-Programming-Language:master","ref":"master","sha":"49eae37265312ea19163da7a89612f08da344d3f","user":{"login":"D-Programming-Language","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=3","gravatar_id":"","url":"https://api.github.com/users/D-Programming-Language","html_url":"https://github.com/D-Programming-Language","followers_url":"https://api.github.com/users/D-Programming-Language/followers","following_url":"https://api.github.com/users/D-Programming-Language/following{/other_user}","gists_url":"https://api.github.com/users/D-Programming-Language/gists{/gist_id}","starred_url":"https://api.github.com/users/D-Programming-Language/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D-Programming-Language/subscriptions","organizations_url":"https://api.github.com/users/D-Programming-Language/orgs","repos_url":"https://api.github.com/users/D-Programming-Language/repos","events_url":"https://api.github.com/users/D-Programming-Language/events{/privacy}","received_events_url":"https://api.github.com/users/D-Programming-Language/received_events","type":"Organization","site_admin":false},"repo":{"id":1257084,"name":"phobos","full_name":"D-Programming-Language/phobos","owner":{"login":"D-Programming-Language","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=3","gravatar_id":"","url":"https://api.github.com/users/D-Programming-Language","html_url":"https://github.com/D-Programming-Language","followers_url":"https://api.github.com/users/D-Programming-Language/followers","following_url":"https://api.github.com/users/D-Programming-Language/following{/other_user}","gists_url":"https://api.github.com/users/D-Programming-Language/gists{/gist_id}","starred_url":"https://api.github.com/users/D-Programming-Language/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D-Programming-Language/subscriptions","organizations_url":"https://api.github.com/users/D-Programming-Language/orgs","repos_url":"https://api.github.com/users/D-Programming-Language/repos","events_url":"https://api.github.com/users/D-Programming-Language/events{/privacy}","received_events_url":"https://api.github.com/users/D-Programming-Language/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/D-Programming-Language/phobos","description":"The standard library of the D programming language","fork":false,"url":"https://api.github.com/repos/D-Programming-Language/phobos","forks_url":"https://api.github.com/repos/D-Programming-Language/phobos/forks","keys_url":"https://api.github.com/repos/D-Programming-Language/phobos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/D-Programming-Language/phobos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/D-Programming-Language/phobos/teams","hooks_url":"https://api.github.com/repos/D-Programming-Language/phobos/hooks","issue_events_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/events{/number}","events_url":"https://api.github.com/repos/D-Programming-Language/phobos/events","assignees_url":"https://api.github.com/repos/D-Programming-Language/phobos/assignees{/user}","branches_url":"https://api.github.com/repos/D-Programming-Language/phobos/branches{/branch}","tags_url":"https://api.github.com/repos/D-Programming-Language/phobos/tags","blobs_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/refs{/sha}","trees_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/D-Programming-Language/phobos/statuses/{sha}","languages_url":"https://api.github.com/repos/D-Programming-Language/phobos/languages","stargazers_url":"https://api.github.com/repos/D-Programming-Language/phobos/stargazers","contributors_url":"https://api.github.com/repos/D-Programming-Language/phobos/contributors","subscribers_url":"https://api.github.com/repos/D-Programming-Language/phobos/subscribers","subscription_url":"https://api.github.com/repos/D-Programming-Language/phobos/subscription","commits_url":"https://api.github.com/repos/D-Programming-Language/phobos/commits{/sha}","git_commits_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/commits{/sha}","comments_url":"https://api.github.com/repos/D-Programming-Language/phobos/comments{/number}","issue_comment_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/comments/{number}","contents_url":"https://api.github.com/repos/D-Programming-Language/phobos/contents/{+path}","compare_url":"https://api.github.com/repos/D-Programming-Language/phobos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/D-Programming-Language/phobos/merges","archive_url":"https://api.github.com/repos/D-Programming-Language/phobos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/D-Programming-Language/phobos/downloads","issues_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues{/number}","pulls_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls{/number}","milestones_url":"https://api.github.com/repos/D-Programming-Language/phobos/milestones{/number}","notifications_url":"https://api.github.com/repos/D-Programming-Language/phobos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/D-Programming-Language/phobos/labels{/name}","releases_url":"https://api.github.com/repos/D-Programming-Language/phobos/releases{/id}","created_at":"2011-01-15T07:00:06Z","updated_at":"2014-12-09T18:06:31Z","pushed_at":"2014-12-09T15:48:44Z","git_url":"git://github.com/D-Programming-Language/phobos.git","ssh_url":"git@github.com:D-Programming-Language/phobos.git","clone_url":"https://github.com/D-Programming-Language/phobos.git","svn_url":"https://github.com/D-Programming-Language/phobos","homepage":"dlang.org/phobos","size":61028,"stargazers_count":542,"watchers_count":542,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":360,"mirror_url":null,"open_issues_count":32,"forks":360,"open_issues":32,"watchers":542,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2791"},"html":{"href":"https://github.com/D-Programming-Language/phobos/pull/2791"},"issue":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/issues/2791"},"comments":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/issues/2791/comments"},"review_comments":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2791/comments"},"review_comment":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2791/commits"},"statuses":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/statuses/c7654bdbc38b20260d8c8c8a93e09b28690b0201"}}}}