GitHub PushEvent at 2014-04-10 17:14:19
Repository: openproject
Actor: myabc
Payload: {"shas":[["6ea4ed825f231bd3db47e5a73c7c3874f7deb861","60c6d277a8bd81de7fdde19201bf9c58a3df08f4@alexbcoles.com","Bump RSpec to ~2.14; bundle update\n\nSigned-off-by: Alex Coles <alex@alexbcoles.com>","Alex Coles",false],["0bdbdcac353f3cce0a89f06f567226c24e633378","60c6d277a8bd81de7fdde19201bf9c58a3df08f4@alexbcoles.com","Convert specs to RSpec 2.14.8 syntax with Transpec\n\nThis conversion is done by Transpec 1.10.4 with the following command:\n    transpec\n\n* 1414 conversions\n    from: obj.should\n      to: expect(obj).to\n\n* 646 conversions\n    from: == expected\n      to: eq(expected)\n\n* 376 conversions\n    from: obj.stub(:message)\n      to: allow(obj).to receive(:message)\n\n* 107 conversions\n    from: obj.should_not\n      to: expect(obj).not_to\n\n* 70 conversions\n    from: obj.should_receive(:message)\n      to: expect(obj).to receive(:message)\n\n* 45 conversions\n    from: =~ [1, 2]\n      to: match_array([1, 2])\n\n* 27 conversions\n    from: lambda { }.should\n      to: expect { }.to\n\n* 13 conversions\n    from: Klass.any_instance.stub(:message)\n      to: allow_any_instance_of(Klass).to receive(:message)\n\n* 8 conversions\n    from: === expected\n      to: be === expected\n\n* 7 conversions\n    from: expect { }.not_to raise_error(SpecificErrorClass)\n      to: expect { }.not_to raise_error\n\n* 6 conversions\n    from: =~ /pattern/\n      to: match(/pattern/)\n\n* 2 conversions\n    from: obj.should_not_receive(:message)\n      to: expect(obj).not_to receive(:message)\n\n* 1 conversion\n    from: < expected\n      to: be < expected\n\n* 1 conversion\n    from: obj.stub!(:message)\n      to: allow(obj).to receive(:message)\n\n* 1 conversion\n    from: stub('something')\n      to: double('something')","Alex Coles",false],["cf7d214906caf8c584d9300dcf53e405ed69468b","60c6d277a8bd81de7fdde19201bf9c58a3df08f4@alexbcoles.com","Fix disable_flash_sweep spec helper\n\nBroken in previous commit 26ade602:\n\nRSpec::Mocks.allow_message is a lower-level API method, allowing us\nto define a stub outside of an ExampleGroup context.\n\nSigned-off-by: Alex Coles <alex@alexbcoles.com>","Alex Coles",false],["eaf8e1c2e93d989f73ba3a6a0ab3aa81134162cb","60c6d277a8bd81de7fdde19201bf9c58a3df08f4@alexbcoles.com","Use disable_flash_sweep in UsersController spec\n\nHelper fixed in previous commit e31bec17.\n\nSigned-off-by: Alex Coles <alex@alexbcoles.com>","Alex Coles",false],["ed1f4fbebb776276b914795ffb9c35e6d91e3982","60c6d277a8bd81de7fdde19201bf9c58a3df08f4@alexbcoles.com","Fix args passed to image_tag in ViewHelpers spec\n\nDeprecated negative raise_error expectations were removed by Transpec\nin previous commit 26ade602: this example was previously masking an\nArgumentError.\n\nSigned-off-by: Alex Coles <alex@alexbcoles.com>","Alex Coles",false],["374694db02f41cfb88d7392f09c4f13192e9dffa","60c6d277a8bd81de7fdde19201bf9c58a3df08f4@alexbcoles.com","Mark a failing wiki routing spec as pending\n\nRSpec should syntax masked an issue with the route_to matcher on a\nseparate line not being called.\n\nSigned-off-by: Alex Coles <alex@alexbcoles.com>","Alex Coles",false],["4774aeb4ee70b546c37a0a94e565678272bdf042","60c6d277a8bd81de7fdde19201bf9c58a3df08f4@alexbcoles.com","Configure RSpec to disable should syntax\n\nSigned-off-by: Alex Coles <alex@alexbcoles.com>","Alex Coles",false],["a1718ca67467c677cc97187cb3a4f12d0b25b9fc","60c6d277a8bd81de7fdde19201bf9c58a3df08f4@alexbcoles.com","Replace #=~ (operator matcher) with #match_array\n\nRSpec expect syntax no longer supports this operator matcher.\n\nSigned-off-by: Alex Coles <alex@alexbcoles.com>","Alex Coles",false],["a0f7deb08134fa57a7033c2a91dbe53d3bcbd2c2","60c6d277a8bd81de7fdde19201bf9c58a3df08f4@alexbcoles.com","Fix pending wiki routing spec: correct HTTP verb\n\n* remove query params from expectation, since routing specs do not\n  test these.\n\n/ HT: @hschink\n\nSigned-off-by: Alex Coles <alex@alexbcoles.com>","Alex Coles",false],["dbdef5766d2f2583c3d5c9fe7f56d47c0d9f55c7","60c6d277a8bd81de7fdde19201bf9c58a3df08f4@alexbcoles.com","Revert bundle update; Bump rspec-rails version\n\nThe previous bundle update of all dependencies broke execution of unit\ntests: I've yet to determine a more specific cause.\n\nThis partially reverts commit 6ea4ed825f231bd3db47e5a73c7c3874f7deb861.\n\nSigned-off-by: Alex Coles <alex@alexbcoles.com>","Alex Coles",false],["d0510d219d8d924979adc58572c35027757b6630","60c6d277a8bd81de7fdde19201bf9c58a3df08f4@alexbcoles.com","Revert \"Configure RSpec to disable should syntax\"\n\nThis will break specs on installations with plugins. Reverting until\npopular plugins are also migrated to the new RSpec syntax\n(see new task: https://www.openproject.org/work_packages/5674)\n\nThis reverts commit 4774aeb4ee70b546c37a0a94e565678272bdf042.","Alex Coles",false],["c66b959854050ae30659e3ad010fb7461d7b6eed","60c6d277a8bd81de7fdde19201bf9c58a3df08f4@alexbcoles.com","Attempt to work-around an AccountController CI failure\n\n     NoMethodError:\n       undefined method `original_path_set' for nil:NilClass\n\nFailure only occurs with a full plugin configuration.\n\nSee https://github.com/rspec/rspec-rails/issues/860","Alex Coles",false],["88e8efe12eebb57ef9fdbb088e6cc7ef36f3f85f","60c6d277a8bd81de7fdde19201bf9c58a3df08f4@alexbcoles.com","Fix failing AccountController#register spec\n\nWith an OpenProject config containing private plugins this spec will\nfail with the following Error:\n\n    ActionView::Template::Error: undefined method `allow_password_changes?' for nil:NilClass\n    ./app/models/user.rb:377:in `change_password_allowed?'\n\nThis failure was most likely previously obscured because\n`render_views` was not enabled.\n\nSigned-off-by: Alex Coles <alex@alexbcoles.com>","Alex Coles",false],["73b809574a8ac7023ae387c28b179bebfaa8ac15","60c6d277a8bd81de7fdde19201bf9c58a3df08f4@alexbcoles.com","Merge branch 'dev' into fix/rspec-expect-syntax\n\nSigned-off-by: Alex Coles <alex@alexbcoles.com>\n\nConflicts:\n\tspec/models/permitted_params_spec.rb\n\tspec/models/work_package/work_package_acts_as_journalized_spec.rb\n\tspec/models/work_package/work_package_planning_spec.rb","Alex Coles",false],["0dcd16d3afea9ad167fbafc86612704614a9d17f","60c6d277a8bd81de7fdde19201bf9c58a3df08f4@alexbcoles.com","Convert specs to RSpec 2.14.8 syntax with Transpec\n\nThis conversion is done by Transpec 1.10.4 with the following command:\n    transpec spec/models/permitted_params_spec.rb\n\n* 10 conversions\n    from: obj.should\n      to: expect(obj).to\n\n* 10 conversions\n    from: == expected\n      to: eq(expected)\n\n* 1 conversion\n    from: obj.should_receive(:message)\n      to: expect(obj).to receive(:message)","Alex Coles",false],["b26b15ce898c9b9f2dc0a3235a110c904a15e1ce","7aa2b466eef8222f66a6ce3eb05355785a4c9dc5@tessenow.org","prepend private_class_method to private class methods\n\nthis applies even if they are in the 'private part' of a class\ndefinition as in:\n\nclass Foo\n  ...\nprivate\n  def foo; 1; end\n  def self.foo; 2; end\nend\n\nFoo.foo #=> 2\nFoo.new.foo #=> NoMethodError: private method `foo' called","Philipp Tessenow",false],["eb4a18ea7d2f7b11a215db711fb4538d7c994612","7aa2b466eef8222f66a6ce3eb05355785a4c9dc5@tessenow.org","do not use ruby 2.1 features so we still support 2.0 inofficially","Philipp Tessenow",false],["21d588a1c325215f40b75cac4599e4b3d7b36665","60c6d277a8bd81de7fdde19201bf9c58a3df08f4@alexbcoles.com","Merge pull request #1092 from opf/fix/ruby_2_0\n\nFix/ruby 2 0","Alex Coles",false],["9db54f08a04901344c4f3fc1a117edd63d32199e","7aa2b466eef8222f66a6ce3eb05355785a4c9dc5@tessenow.org","call private methods the right way","Philipp Tessenow",false],["f4282fc71274bdfceba9aa22392cd30d7bb89c05","cd313aec1c60637fd219803f92f1da0a3fa874a5@student.hpi.uni-potsdam.de","Merge pull request #1064 from opf/fix/rspec-expect-syntax\n\nMigrate all specs to the newer expect syntax","Philipp Tessenow",false]],"size":55,"ref":"refs/heads/feature/angular-directive-tests","head":"6bec90b40d10b6509170421958367053eb22def4"}