GitHub PullRequestReviewCommentEvent at 2014-08-12 19:13:40
Repository: build-farm
Actor: jelmer
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/jelmer/build-farm/pulls/comments/16135638","id":16135638,"diff_hunk":"@@ -604,13 +603,24 @@ def get_previous_build(self, tree, host, compiler, revision):\n             raise NoSuchBuildError(tree, host, compiler, revision)\n         return prev_build\n \n-    def get_latest_build(self, tree, host, compiler):\n-        result = self.store.find(StormBuild,\n-            StormBuild.tree == tree,\n-            StormBuild.host == host,\n-            StormBuild.compiler == compiler)\n-        result = result.order_by(Desc(StormBuild.id))\n-        build = result.first()\n+    def get_latest_build(self, tree, host, compiler, revisions=None):","path":"buildfarm/build.py","position":19,"original_position":19,"commit_id":"f42ea7fdc3db60ac61b9fb4404e367c906408593","original_commit_id":"f42ea7fdc3db60ac61b9fb4404e367c906408593","user":{"login":"jelmer","id":49032,"avatar_url":"https://avatars.githubusercontent.com/u/49032?v=2","gravatar_id":"162df4b0eff1277f9c4d1273a84041c9","url":"https://api.github.com/users/jelmer","html_url":"https://github.com/jelmer","followers_url":"https://api.github.com/users/jelmer/followers","following_url":"https://api.github.com/users/jelmer/following{/other_user}","gists_url":"https://api.github.com/users/jelmer/gists{/gist_id}","starred_url":"https://api.github.com/users/jelmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jelmer/subscriptions","organizations_url":"https://api.github.com/users/jelmer/orgs","repos_url":"https://api.github.com/users/jelmer/repos","events_url":"https://api.github.com/users/jelmer/events{/privacy}","received_events_url":"https://api.github.com/users/jelmer/received_events","type":"User","site_admin":false},"body":"This function is broken - the argument is named \"revisions\", but the rest of the function uses \"revision\".\r\n\r\n(This is one of the reasons why this code should have unit tests, since Python doesn't have a compiler that checks for name errors)","created_at":"2014-08-12T19:13:40Z","updated_at":"2014-08-12T19:13:40Z","html_url":"https://github.com/jelmer/build-farm/pull/13#discussion_r16135638","pull_request_url":"https://api.github.com/repos/jelmer/build-farm/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/jelmer/build-farm/pulls/comments/16135638"},"html":{"href":"https://github.com/jelmer/build-farm/pull/13#discussion_r16135638"},"pull_request":{"href":"https://api.github.com/repos/jelmer/build-farm/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/jelmer/build-farm/pulls/13","id":19565331,"html_url":"https://github.com/jelmer/build-farm/pull/13","diff_url":"https://github.com/jelmer/build-farm/pull/13.diff","patch_url":"https://github.com/jelmer/build-farm/pull/13.patch","issue_url":"https://api.github.com/repos/jelmer/build-farm/issues/13","number":13,"state":"open","title":"mail imporvements","user":{"login":"krishnatejaperannagari","id":6380932,"avatar_url":"https://avatars.githubusercontent.com/u/6380932?v=2","gravatar_id":"2bc3ade425a589207e5b7db8026e788c","url":"https://api.github.com/users/krishnatejaperannagari","html_url":"https://github.com/krishnatejaperannagari","followers_url":"https://api.github.com/users/krishnatejaperannagari/followers","following_url":"https://api.github.com/users/krishnatejaperannagari/following{/other_user}","gists_url":"https://api.github.com/users/krishnatejaperannagari/gists{/gist_id}","starred_url":"https://api.github.com/users/krishnatejaperannagari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krishnatejaperannagari/subscriptions","organizations_url":"https://api.github.com/users/krishnatejaperannagari/orgs","repos_url":"https://api.github.com/users/krishnatejaperannagari/repos","events_url":"https://api.github.com/users/krishnatejaperannagari/events{/privacy}","received_events_url":"https://api.github.com/users/krishnatejaperannagari/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-08-09T15:43:09Z","updated_at":"2014-08-12T19:13:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fa5ffd91c4f6572550b7a1637ace056fc9a3143c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jelmer/build-farm/pulls/13/commits","review_comments_url":"https://api.github.com/repos/jelmer/build-farm/pulls/13/comments","review_comment_url":"https://api.github.com/repos/jelmer/build-farm/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jelmer/build-farm/issues/13/comments","statuses_url":"https://api.github.com/repos/jelmer/build-farm/statuses/f42ea7fdc3db60ac61b9fb4404e367c906408593","head":{"label":"krishnatejaperannagari:mailimprovements","ref":"mailimprovements","sha":"f42ea7fdc3db60ac61b9fb4404e367c906408593","user":{"login":"krishnatejaperannagari","id":6380932,"avatar_url":"https://avatars.githubusercontent.com/u/6380932?v=2","gravatar_id":"2bc3ade425a589207e5b7db8026e788c","url":"https://api.github.com/users/krishnatejaperannagari","html_url":"https://github.com/krishnatejaperannagari","followers_url":"https://api.github.com/users/krishnatejaperannagari/followers","following_url":"https://api.github.com/users/krishnatejaperannagari/following{/other_user}","gists_url":"https://api.github.com/users/krishnatejaperannagari/gists{/gist_id}","starred_url":"https://api.github.com/users/krishnatejaperannagari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krishnatejaperannagari/subscriptions","organizations_url":"https://api.github.com/users/krishnatejaperannagari/orgs","repos_url":"https://api.github.com/users/krishnatejaperannagari/repos","events_url":"https://api.github.com/users/krishnatejaperannagari/events{/privacy}","received_events_url":"https://api.github.com/users/krishnatejaperannagari/received_events","type":"User","site_admin":false},"repo":{"id":20091912,"name":"build-farm","full_name":"krishnatejaperannagari/build-farm","owner":{"login":"krishnatejaperannagari","id":6380932,"avatar_url":"https://avatars.githubusercontent.com/u/6380932?v=2","gravatar_id":"2bc3ade425a589207e5b7db8026e788c","url":"https://api.github.com/users/krishnatejaperannagari","html_url":"https://github.com/krishnatejaperannagari","followers_url":"https://api.github.com/users/krishnatejaperannagari/followers","following_url":"https://api.github.com/users/krishnatejaperannagari/following{/other_user}","gists_url":"https://api.github.com/users/krishnatejaperannagari/gists{/gist_id}","starred_url":"https://api.github.com/users/krishnatejaperannagari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krishnatejaperannagari/subscriptions","organizations_url":"https://api.github.com/users/krishnatejaperannagari/orgs","repos_url":"https://api.github.com/users/krishnatejaperannagari/repos","events_url":"https://api.github.com/users/krishnatejaperannagari/events{/privacy}","received_events_url":"https://api.github.com/users/krishnatejaperannagari/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/krishnatejaperannagari/build-farm","description":"The Samba Build-Farm","fork":true,"url":"https://api.github.com/repos/krishnatejaperannagari/build-farm","forks_url":"https://api.github.com/repos/krishnatejaperannagari/build-farm/forks","keys_url":"https://api.github.com/repos/krishnatejaperannagari/build-farm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krishnatejaperannagari/build-farm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krishnatejaperannagari/build-farm/teams","hooks_url":"https://api.github.com/repos/krishnatejaperannagari/build-farm/hooks","issue_events_url":"https://api.github.com/repos/krishnatejaperannagari/build-farm/issues/events{/number}","events_url":"https://api.github.com/repos/krishnatejaperannagari/build-farm/events","assignees_url":"https://api.github.com/repos/krishnatejaperannagari/build-farm/assignees{/user}","branches_url":"https://api.github.com/repos/krishnatejaperannagari/build-farm/branches{/branch}","tags_url":"https://api.github.com/repos/krishnatejaperannagari/build-farm/tags","blobs_url":"https://api.github.com/repos/krishnatejaperannagari/build-farm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krishnatejaperannagari/build-farm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krishnatejaperannagari/build-farm/git/refs{/sha}","trees_url":"https://api.github.com/repos/krishnatejaperannagari/build-farm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krishnatejaperannagari/build-farm/statuses/{sha}","languages_url":"https://api.github.com/repos/krishnatejaperannagari/build-farm/languages","stargazers_url":"https://api.github.com/repos/krishnatejaperannagari/build-farm/stargazers","contributors_url":"https://api.github.com/repos/krishnatejaperannagari/build-farm/contributors","subscribers_url":"https://api.github.com/repos/krishnatejaperannagari/build-farm/subscribers","subscription_url":"https://api.github.com/repos/krishnatejaperannagari/build-farm/subscription","commits_url":"https://api.github.com/repos/krishnatejaperannagari/build-farm/commits{/sha}","git_commits_url":"https://api.github.com/repos/krishnatejaperannagari/build-farm/git/commits{/sha}","comments_url":"https://api.github.com/repos/krishnatejaperannagari/build-farm/comments{/number}","issue_comment_url":"https://api.github.com/repos/krishnatejaperannagari/build-farm/issues/comments/{number}","contents_url":"https://api.github.com/repos/krishnatejaperannagari/build-farm/contents/{+path}","compare_url":"https://api.github.com/repos/krishnatejaperannagari/build-farm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krishnatejaperannagari/build-farm/merges","archive_url":"https://api.github.com/repos/krishnatejaperannagari/build-farm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krishnatejaperannagari/build-farm/downloads","issues_url":"https://api.github.com/repos/krishnatejaperannagari/build-farm/issues{/number}","pulls_url":"https://api.github.com/repos/krishnatejaperannagari/build-farm/pulls{/number}","milestones_url":"https://api.github.com/repos/krishnatejaperannagari/build-farm/milestones{/number}","notifications_url":"https://api.github.com/repos/krishnatejaperannagari/build-farm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krishnatejaperannagari/build-farm/labels{/name}","releases_url":"https://api.github.com/repos/krishnatejaperannagari/build-farm/releases{/id}","created_at":"2014-05-23T08:14:57Z","updated_at":"2014-06-25T09:21:19Z","pushed_at":"2014-08-12T18:38:00Z","git_url":"git://github.com/krishnatejaperannagari/build-farm.git","ssh_url":"git@github.com:krishnatejaperannagari/build-farm.git","clone_url":"https://github.com/krishnatejaperannagari/build-farm.git","svn_url":"https://github.com/krishnatejaperannagari/build-farm","homepage":null,"size":9334,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jelmer:master","ref":"master","sha":"295dc1ad7e31efcb8313a0ad2fc4ab4683ee40d3","user":{"login":"jelmer","id":49032,"avatar_url":"https://avatars.githubusercontent.com/u/49032?v=2","gravatar_id":"162df4b0eff1277f9c4d1273a84041c9","url":"https://api.github.com/users/jelmer","html_url":"https://github.com/jelmer","followers_url":"https://api.github.com/users/jelmer/followers","following_url":"https://api.github.com/users/jelmer/following{/other_user}","gists_url":"https://api.github.com/users/jelmer/gists{/gist_id}","starred_url":"https://api.github.com/users/jelmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jelmer/subscriptions","organizations_url":"https://api.github.com/users/jelmer/orgs","repos_url":"https://api.github.com/users/jelmer/repos","events_url":"https://api.github.com/users/jelmer/events{/privacy}","received_events_url":"https://api.github.com/users/jelmer/received_events","type":"User","site_admin":false},"repo":{"id":20038937,"name":"build-farm","full_name":"jelmer/build-farm","owner":{"login":"jelmer","id":49032,"avatar_url":"https://avatars.githubusercontent.com/u/49032?v=2","gravatar_id":"162df4b0eff1277f9c4d1273a84041c9","url":"https://api.github.com/users/jelmer","html_url":"https://github.com/jelmer","followers_url":"https://api.github.com/users/jelmer/followers","following_url":"https://api.github.com/users/jelmer/following{/other_user}","gists_url":"https://api.github.com/users/jelmer/gists{/gist_id}","starred_url":"https://api.github.com/users/jelmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jelmer/subscriptions","organizations_url":"https://api.github.com/users/jelmer/orgs","repos_url":"https://api.github.com/users/jelmer/repos","events_url":"https://api.github.com/users/jelmer/events{/privacy}","received_events_url":"https://api.github.com/users/jelmer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jelmer/build-farm","description":"The Samba Build-Farm","fork":false,"url":"https://api.github.com/repos/jelmer/build-farm","forks_url":"https://api.github.com/repos/jelmer/build-farm/forks","keys_url":"https://api.github.com/repos/jelmer/build-farm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jelmer/build-farm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jelmer/build-farm/teams","hooks_url":"https://api.github.com/repos/jelmer/build-farm/hooks","issue_events_url":"https://api.github.com/repos/jelmer/build-farm/issues/events{/number}","events_url":"https://api.github.com/repos/jelmer/build-farm/events","assignees_url":"https://api.github.com/repos/jelmer/build-farm/assignees{/user}","branches_url":"https://api.github.com/repos/jelmer/build-farm/branches{/branch}","tags_url":"https://api.github.com/repos/jelmer/build-farm/tags","blobs_url":"https://api.github.com/repos/jelmer/build-farm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jelmer/build-farm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jelmer/build-farm/git/refs{/sha}","trees_url":"https://api.github.com/repos/jelmer/build-farm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jelmer/build-farm/statuses/{sha}","languages_url":"https://api.github.com/repos/jelmer/build-farm/languages","stargazers_url":"https://api.github.com/repos/jelmer/build-farm/stargazers","contributors_url":"https://api.github.com/repos/jelmer/build-farm/contributors","subscribers_url":"https://api.github.com/repos/jelmer/build-farm/subscribers","subscription_url":"https://api.github.com/repos/jelmer/build-farm/subscription","commits_url":"https://api.github.com/repos/jelmer/build-farm/commits{/sha}","git_commits_url":"https://api.github.com/repos/jelmer/build-farm/git/commits{/sha}","comments_url":"https://api.github.com/repos/jelmer/build-farm/comments{/number}","issue_comment_url":"https://api.github.com/repos/jelmer/build-farm/issues/comments/{number}","contents_url":"https://api.github.com/repos/jelmer/build-farm/contents/{+path}","compare_url":"https://api.github.com/repos/jelmer/build-farm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jelmer/build-farm/merges","archive_url":"https://api.github.com/repos/jelmer/build-farm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jelmer/build-farm/downloads","issues_url":"https://api.github.com/repos/jelmer/build-farm/issues{/number}","pulls_url":"https://api.github.com/repos/jelmer/build-farm/pulls{/number}","milestones_url":"https://api.github.com/repos/jelmer/build-farm/milestones{/number}","notifications_url":"https://api.github.com/repos/jelmer/build-farm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jelmer/build-farm/labels{/name}","releases_url":"https://api.github.com/repos/jelmer/build-farm/releases{/id}","created_at":"2014-05-21T22:01:45Z","updated_at":"2014-07-11T00:19:48Z","pushed_at":"2014-08-02T19:41:18Z","git_url":"git://github.com/jelmer/build-farm.git","ssh_url":"git@github.com:jelmer/build-farm.git","clone_url":"https://github.com/jelmer/build-farm.git","svn_url":"https://github.com/jelmer/build-farm","homepage":null,"size":8771,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jelmer/build-farm/pulls/13"},"html":{"href":"https://github.com/jelmer/build-farm/pull/13"},"issue":{"href":"https://api.github.com/repos/jelmer/build-farm/issues/13"},"comments":{"href":"https://api.github.com/repos/jelmer/build-farm/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/jelmer/build-farm/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/jelmer/build-farm/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jelmer/build-farm/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/jelmer/build-farm/statuses/f42ea7fdc3db60ac61b9fb4404e367c906408593"}}}}