GitHub PullRequestEvent at 2014-12-19 13:22:53
Repository: Sylius
Actor: pjedrzejewski
Payload: {"action":"closed","number":1441,"pull_request":{"url":"https://api.github.com/repos/Sylius/Sylius/pulls/1441","id":15261788,"html_url":"https://github.com/Sylius/Sylius/pull/1441","diff_url":"https://github.com/Sylius/Sylius/pull/1441.diff","patch_url":"https://github.com/Sylius/Sylius/pull/1441.patch","issue_url":"https://api.github.com/repos/Sylius/Sylius/issues/1441","number":1441,"state":"closed","locked":false,"title":"Add knplabs/knp-gaufrette-bundle as a requirement of the Core Component","user":{"login":"tomzx","id":188960,"avatar_url":"https://avatars.githubusercontent.com/u/188960?v=3","gravatar_id":"","url":"https://api.github.com/users/tomzx","html_url":"https://github.com/tomzx","followers_url":"https://api.github.com/users/tomzx/followers","following_url":"https://api.github.com/users/tomzx/following{/other_user}","gists_url":"https://api.github.com/users/tomzx/gists{/gist_id}","starred_url":"https://api.github.com/users/tomzx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomzx/subscriptions","organizations_url":"https://api.github.com/users/tomzx/orgs","repos_url":"https://api.github.com/users/tomzx/repos","events_url":"https://api.github.com/users/tomzx/events{/privacy}","received_events_url":"https://api.github.com/users/tomzx/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | yes\r\n| New feature?  | no\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | -\r\n| License       | MIT\r\n| Doc PR        | -\r\n\r\nHi,\r\n\r\nCurrently, the `knplabs/knp-gaufrette-bundle` dependency is part of the `required-dev` section of the `Core`'s composer.json, but the class `Sylius\\Component\\Core\\Uploader\\ImageUploader` uses  `Gaufrette\\Filesystem` as its constructor parameter which makes it a `require`.","created_at":"2014-04-28T21:33:47Z","updated_at":"2014-12-19T13:22:52Z","closed_at":"2014-12-19T13:22:52Z","merged_at":null,"merge_commit_sha":"7503247bc3b47269e3784b90f8e8121a6e265e1a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Sylius/Sylius/pulls/1441/commits","review_comments_url":"https://api.github.com/repos/Sylius/Sylius/pulls/1441/comments","review_comment_url":"https://api.github.com/repos/Sylius/Sylius/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Sylius/Sylius/issues/1441/comments","statuses_url":"https://api.github.com/repos/Sylius/Sylius/statuses/d9edc82644eac40eca0b37bde5a5f73996dfe26c","head":{"label":"tomzx:fixes/add-knp-gaufrette-bundle-requirement-to-core","ref":"fixes/add-knp-gaufrette-bundle-requirement-to-core","sha":"d9edc82644eac40eca0b37bde5a5f73996dfe26c","user":{"login":"tomzx","id":188960,"avatar_url":"https://avatars.githubusercontent.com/u/188960?v=3","gravatar_id":"","url":"https://api.github.com/users/tomzx","html_url":"https://github.com/tomzx","followers_url":"https://api.github.com/users/tomzx/followers","following_url":"https://api.github.com/users/tomzx/following{/other_user}","gists_url":"https://api.github.com/users/tomzx/gists{/gist_id}","starred_url":"https://api.github.com/users/tomzx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomzx/subscriptions","organizations_url":"https://api.github.com/users/tomzx/orgs","repos_url":"https://api.github.com/users/tomzx/repos","events_url":"https://api.github.com/users/tomzx/events{/privacy}","received_events_url":"https://api.github.com/users/tomzx/received_events","type":"User","site_admin":false},"repo":{"id":18582241,"name":"Sylius","full_name":"tomzx/Sylius","owner":{"login":"tomzx","id":188960,"avatar_url":"https://avatars.githubusercontent.com/u/188960?v=3","gravatar_id":"","url":"https://api.github.com/users/tomzx","html_url":"https://github.com/tomzx","followers_url":"https://api.github.com/users/tomzx/followers","following_url":"https://api.github.com/users/tomzx/following{/other_user}","gists_url":"https://api.github.com/users/tomzx/gists{/gist_id}","starred_url":"https://api.github.com/users/tomzx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomzx/subscriptions","organizations_url":"https://api.github.com/users/tomzx/orgs","repos_url":"https://api.github.com/users/tomzx/repos","events_url":"https://api.github.com/users/tomzx/events{/privacy}","received_events_url":"https://api.github.com/users/tomzx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tomzx/Sylius","description":"Modern e-commerce for PHP, based on the Symfony2 framework.","fork":true,"url":"https://api.github.com/repos/tomzx/Sylius","forks_url":"https://api.github.com/repos/tomzx/Sylius/forks","keys_url":"https://api.github.com/repos/tomzx/Sylius/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tomzx/Sylius/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tomzx/Sylius/teams","hooks_url":"https://api.github.com/repos/tomzx/Sylius/hooks","issue_events_url":"https://api.github.com/repos/tomzx/Sylius/issues/events{/number}","events_url":"https://api.github.com/repos/tomzx/Sylius/events","assignees_url":"https://api.github.com/repos/tomzx/Sylius/assignees{/user}","branches_url":"https://api.github.com/repos/tomzx/Sylius/branches{/branch}","tags_url":"https://api.github.com/repos/tomzx/Sylius/tags","blobs_url":"https://api.github.com/repos/tomzx/Sylius/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tomzx/Sylius/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tomzx/Sylius/git/refs{/sha}","trees_url":"https://api.github.com/repos/tomzx/Sylius/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tomzx/Sylius/statuses/{sha}","languages_url":"https://api.github.com/repos/tomzx/Sylius/languages","stargazers_url":"https://api.github.com/repos/tomzx/Sylius/stargazers","contributors_url":"https://api.github.com/repos/tomzx/Sylius/contributors","subscribers_url":"https://api.github.com/repos/tomzx/Sylius/subscribers","subscription_url":"https://api.github.com/repos/tomzx/Sylius/subscription","commits_url":"https://api.github.com/repos/tomzx/Sylius/commits{/sha}","git_commits_url":"https://api.github.com/repos/tomzx/Sylius/git/commits{/sha}","comments_url":"https://api.github.com/repos/tomzx/Sylius/comments{/number}","issue_comment_url":"https://api.github.com/repos/tomzx/Sylius/issues/comments/{number}","contents_url":"https://api.github.com/repos/tomzx/Sylius/contents/{+path}","compare_url":"https://api.github.com/repos/tomzx/Sylius/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tomzx/Sylius/merges","archive_url":"https://api.github.com/repos/tomzx/Sylius/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tomzx/Sylius/downloads","issues_url":"https://api.github.com/repos/tomzx/Sylius/issues{/number}","pulls_url":"https://api.github.com/repos/tomzx/Sylius/pulls{/number}","milestones_url":"https://api.github.com/repos/tomzx/Sylius/milestones{/number}","notifications_url":"https://api.github.com/repos/tomzx/Sylius/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tomzx/Sylius/labels{/name}","releases_url":"https://api.github.com/repos/tomzx/Sylius/releases{/id}","created_at":"2014-04-09T02:18:16Z","updated_at":"2014-05-09T04:06:42Z","pushed_at":"2014-05-09T04:06:42Z","git_url":"git://github.com/tomzx/Sylius.git","ssh_url":"git@github.com:tomzx/Sylius.git","clone_url":"https://github.com/tomzx/Sylius.git","svn_url":"https://github.com/tomzx/Sylius","homepage":"Sylius.org","size":11215,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Sylius:master","ref":"master","sha":"37fba02502d2715102c5772c2ae557f67e02ad2d","user":{"login":"Sylius","id":719423,"avatar_url":"https://avatars.githubusercontent.com/u/719423?v=3","gravatar_id":"","url":"https://api.github.com/users/Sylius","html_url":"https://github.com/Sylius","followers_url":"https://api.github.com/users/Sylius/followers","following_url":"https://api.github.com/users/Sylius/following{/other_user}","gists_url":"https://api.github.com/users/Sylius/gists{/gist_id}","starred_url":"https://api.github.com/users/Sylius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sylius/subscriptions","organizations_url":"https://api.github.com/users/Sylius/orgs","repos_url":"https://api.github.com/users/Sylius/repos","events_url":"https://api.github.com/users/Sylius/events{/privacy}","received_events_url":"https://api.github.com/users/Sylius/received_events","type":"Organization","site_admin":false},"repo":{"id":2717549,"name":"Sylius","full_name":"Sylius/Sylius","owner":{"login":"Sylius","id":719423,"avatar_url":"https://avatars.githubusercontent.com/u/719423?v=3","gravatar_id":"","url":"https://api.github.com/users/Sylius","html_url":"https://github.com/Sylius","followers_url":"https://api.github.com/users/Sylius/followers","following_url":"https://api.github.com/users/Sylius/following{/other_user}","gists_url":"https://api.github.com/users/Sylius/gists{/gist_id}","starred_url":"https://api.github.com/users/Sylius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sylius/subscriptions","organizations_url":"https://api.github.com/users/Sylius/orgs","repos_url":"https://api.github.com/users/Sylius/repos","events_url":"https://api.github.com/users/Sylius/events{/privacy}","received_events_url":"https://api.github.com/users/Sylius/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Sylius/Sylius","description":"Modern e-commerce for PHP, based on the Symfony2 framework.","fork":false,"url":"https://api.github.com/repos/Sylius/Sylius","forks_url":"https://api.github.com/repos/Sylius/Sylius/forks","keys_url":"https://api.github.com/repos/Sylius/Sylius/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sylius/Sylius/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sylius/Sylius/teams","hooks_url":"https://api.github.com/repos/Sylius/Sylius/hooks","issue_events_url":"https://api.github.com/repos/Sylius/Sylius/issues/events{/number}","events_url":"https://api.github.com/repos/Sylius/Sylius/events","assignees_url":"https://api.github.com/repos/Sylius/Sylius/assignees{/user}","branches_url":"https://api.github.com/repos/Sylius/Sylius/branches{/branch}","tags_url":"https://api.github.com/repos/Sylius/Sylius/tags","blobs_url":"https://api.github.com/repos/Sylius/Sylius/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sylius/Sylius/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sylius/Sylius/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sylius/Sylius/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sylius/Sylius/statuses/{sha}","languages_url":"https://api.github.com/repos/Sylius/Sylius/languages","stargazers_url":"https://api.github.com/repos/Sylius/Sylius/stargazers","contributors_url":"https://api.github.com/repos/Sylius/Sylius/contributors","subscribers_url":"https://api.github.com/repos/Sylius/Sylius/subscribers","subscription_url":"https://api.github.com/repos/Sylius/Sylius/subscription","commits_url":"https://api.github.com/repos/Sylius/Sylius/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sylius/Sylius/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sylius/Sylius/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sylius/Sylius/issues/comments/{number}","contents_url":"https://api.github.com/repos/Sylius/Sylius/contents/{+path}","compare_url":"https://api.github.com/repos/Sylius/Sylius/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sylius/Sylius/merges","archive_url":"https://api.github.com/repos/Sylius/Sylius/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sylius/Sylius/downloads","issues_url":"https://api.github.com/repos/Sylius/Sylius/issues{/number}","pulls_url":"https://api.github.com/repos/Sylius/Sylius/pulls{/number}","milestones_url":"https://api.github.com/repos/Sylius/Sylius/milestones{/number}","notifications_url":"https://api.github.com/repos/Sylius/Sylius/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sylius/Sylius/labels{/name}","releases_url":"https://api.github.com/repos/Sylius/Sylius/releases{/id}","created_at":"2011-11-05T22:05:52Z","updated_at":"2014-12-19T13:17:52Z","pushed_at":"2014-12-19T13:17:51Z","git_url":"git://github.com/Sylius/Sylius.git","ssh_url":"git@github.com:Sylius/Sylius.git","clone_url":"https://github.com/Sylius/Sylius.git","svn_url":"https://github.com/Sylius/Sylius","homepage":"Sylius.org","size":37741,"stargazers_count":1481,"watchers_count":1481,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":505,"mirror_url":null,"open_issues_count":372,"forks":505,"open_issues":372,"watchers":1481,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/1441"},"html":{"href":"https://github.com/Sylius/Sylius/pull/1441"},"issue":{"href":"https://api.github.com/repos/Sylius/Sylius/issues/1441"},"comments":{"href":"https://api.github.com/repos/Sylius/Sylius/issues/1441/comments"},"review_comments":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/1441/comments"},"review_comment":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/1441/commits"},"statuses":{"href":"https://api.github.com/repos/Sylius/Sylius/statuses/d9edc82644eac40eca0b37bde5a5f73996dfe26c"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":3,"deletions":1,"changed_files":1}}