GitHub PullRequestReviewCommentEvent at 2014-01-22 17:42:32
Repository: barclamp-nova
Actor: vuntz
Payload: {"comment":{"url":"https://api.github.com/repos/crowbar/barclamp-nova/pulls/comments/9083871","id":9083871,"diff_hunk":"@@ -1,14 +1,26 @@\n def upgrade ta, td, a, d\n-  a['vcenter'] = {}\n-  a['vcenter']['host'] = ta['vcenter']['host']\n-  a['vcenter']['user'] = ta['vcenter']['user']\n-  a['vcenter']['password'] = ta['vcenter']['password']\n-  a['vcenter']['clusters'] = ta['vcenter']['clusters']\n-  a['vcenter']['interface'] = ta['vcenter']['interface']\n+  unless a[:esxi].nil?\n+    a[:vcenter] = {}\n+    a[:vcenter][:host] = a[:esxi][:host]\n+    a[:vcenter][:user] = a[:esxi][:login]\n+    a[:vcenter][:password] = a[:esxi][:password]\n+    a[:vcenter][:clusters] = [ a[:esxi][:cluster] ]\n+    a[:vcenter][:interface] = a[:esxi][:interface]","path":"chef/data_bags/crowbar/migrate/nova/004_add_vmware_attributes.rb","position":14,"original_position":14,"commit_id":"074262561dcf8b4642242d6ae31a7aa5a55d3c28","original_commit_id":"074262561dcf8b4642242d6ae31a7aa5a55d3c28","user":{"login":"vuntz","id":1758783,"avatar_url":"https://gravatar.com/avatar/d7cc6451b64c4351e27db322d114d4aa?d=https%3A%2F%2Fidenticons.github.com%2F5bd1faa634caaa43d77e72c5bf9b4da0.png&r=x","gravatar_id":"d7cc6451b64c4351e27db322d114d4aa","url":"https://api.github.com/users/vuntz","html_url":"https://github.com/vuntz","followers_url":"https://api.github.com/users/vuntz/followers","following_url":"https://api.github.com/users/vuntz/following{/other_user}","gists_url":"https://api.github.com/users/vuntz/gists{/gist_id}","starred_url":"https://api.github.com/users/vuntz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuntz/subscriptions","organizations_url":"https://api.github.com/users/vuntz/orgs","repos_url":"https://api.github.com/users/vuntz/repos","events_url":"https://api.github.com/users/vuntz/events{/privacy}","received_events_url":"https://api.github.com/users/vuntz/received_events","type":"User","site_admin":false},"body":"That part is wrong, it should be ```a[:vcenter][:interface] = ta[:vcenter][:interface]```","created_at":"2014-01-22T17:42:32Z","updated_at":"2014-01-22T17:42:32Z","html_url":"https://github.com/crowbar/barclamp-nova/pull/300#discussion_r9083871","pull_request_url":"https://api.github.com/repos/crowbar/barclamp-nova/pulls/300","_links":{"self":{"href":"https://api.github.com/repos/crowbar/barclamp-nova/pulls/comments/9083871"},"html":{"href":"https://github.com/crowbar/barclamp-nova/pull/300#discussion_r9083871"},"pull_request":{"href":"https://api.github.com/repos/crowbar/barclamp-nova/pulls/300"}}}}