GitHub PullRequestReviewCommentEvent at 2014-11-15 20:25:06
Repository: resteeth
Actor: nurkiewicz
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Codearte/resteeth/pulls/comments/20404739","id":20404739,"diff_hunk":"@@ -86,6 +86,18 @@\n \t\t\t<version>${spock.version}</version>\n \t\t\t<scope>test</scope>\n \t\t</dependency>\n+\t\t<dependency>\n+\t\t\t<groupId>cglib</groupId>\n+\t\t\t<artifactId>cglib</artifactId>\n+\t\t\t<version>3.1</version>\n+\t\t\t<scope>test</scope>\n+\t\t</dependency>\n+\t\t<dependency>\n+\t\t\t<groupId>org.objenesis</groupId>\n+\t\t\t<artifactId>objenesis</artifactId>\n+\t\t\t<version>2.1</version>\n+\t\t\t<scope>test</scope>\n+\t\t</dependency>","path":"pom.xml","position":15,"original_position":15,"commit_id":"e59eb57e929472bc9bf2a3f2dfc5e9873cf74364","original_commit_id":"e59eb57e929472bc9bf2a3f2dfc5e9873cf74364","user":{"login":"nurkiewicz","id":164045,"avatar_url":"https://avatars.githubusercontent.com/u/164045?v=3","gravatar_id":"","url":"https://api.github.com/users/nurkiewicz","html_url":"https://github.com/nurkiewicz","followers_url":"https://api.github.com/users/nurkiewicz/followers","following_url":"https://api.github.com/users/nurkiewicz/following{/other_user}","gists_url":"https://api.github.com/users/nurkiewicz/gists{/gist_id}","starred_url":"https://api.github.com/users/nurkiewicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nurkiewicz/subscriptions","organizations_url":"https://api.github.com/users/nurkiewicz/orgs","repos_url":"https://api.github.com/users/nurkiewicz/repos","events_url":"https://api.github.com/users/nurkiewicz/events{/privacy}","received_events_url":"https://api.github.com/users/nurkiewicz/received_events","type":"User","site_admin":false},"body":"Mocking of some classes wasn't working without it. Try removing these dependencies, maybe it became obsolete in the meantime.","created_at":"2014-11-15T20:25:06Z","updated_at":"2014-11-15T20:25:06Z","html_url":"https://github.com/Codearte/resteeth/pull/17#discussion_r20404739","pull_request_url":"https://api.github.com/repos/Codearte/resteeth/pulls/17","_links":{"self":{"href":"https://api.github.com/repos/Codearte/resteeth/pulls/comments/20404739"},"html":{"href":"https://github.com/Codearte/resteeth/pull/17#discussion_r20404739"},"pull_request":{"href":"https://api.github.com/repos/Codearte/resteeth/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/Codearte/resteeth/pulls/17","id":24492843,"html_url":"https://github.com/Codearte/resteeth/pull/17","diff_url":"https://github.com/Codearte/resteeth/pull/17.diff","patch_url":"https://github.com/Codearte/resteeth/pull/17.patch","issue_url":"https://api.github.com/repos/Codearte/resteeth/issues/17","number":17,"state":"open","locked":false,"title":"Interceptors mechanism (fixes #6)","user":{"login":"nurkiewicz","id":164045,"avatar_url":"https://avatars.githubusercontent.com/u/164045?v=3","gravatar_id":"","url":"https://api.github.com/users/nurkiewicz","html_url":"https://github.com/nurkiewicz","followers_url":"https://api.github.com/users/nurkiewicz/followers","following_url":"https://api.github.com/users/nurkiewicz/following{/other_user}","gists_url":"https://api.github.com/users/nurkiewicz/gists{/gist_id}","starred_url":"https://api.github.com/users/nurkiewicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nurkiewicz/subscriptions","organizations_url":"https://api.github.com/users/nurkiewicz/orgs","repos_url":"https://api.github.com/users/nurkiewicz/repos","events_url":"https://api.github.com/users/nurkiewicz/events{/privacy}","received_events_url":"https://api.github.com/users/nurkiewicz/received_events","type":"User","site_admin":false},"body":"Changes REST invocation flow from simple `RestClientMethodInterceptor` -> `RestTemplateInvoker` to much more flexible and extensible interceptor/handler architecture. Basically each REST call is wrapped in `RestInvocation` value object and passed to first `RestInvocationHandler` (with highest priority). Each handler can either process invocation or pass is further (`invocation.proceed()`, see `LoggingHandler`). Last handler must handle the request, typically this will be `RestTemplateInvoker` (added automatically to the end of handlers chain).\r\n\r\nHandlers are auto-discovered in application context and sorted using `Ordered` interface. This architecture makes it very easy to implement a lot of custom functionality:\r\n\r\n* logging (built-in)\r\n* profiling (built-in, measuring time)\r\n* caching\r\n* unmarshalling/deserializing\r\n* transparent retry mechanism\r\n* modifying HTTP headers, parameters, etc. (see `UserAgentHandler`), (see #8)\r\n* wrapping calls, e.g. in Hystrix\r\n* using arbitrary HTTP client\r\n* implementing `@Async` (see #7)\r\n* handling arbitrary annotations (see #10)\r\n\r\nAnd a lot more. It's basically specialized AOP inside the library.","created_at":"2014-11-15T19:19:37Z","updated_at":"2014-11-15T20:25:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bd676eb4b1c9f7134e083a0599e603fbb019d1f5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Codearte/resteeth/pulls/17/commits","review_comments_url":"https://api.github.com/repos/Codearte/resteeth/pulls/17/comments","review_comment_url":"https://api.github.com/repos/Codearte/resteeth/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Codearte/resteeth/issues/17/comments","statuses_url":"https://api.github.com/repos/Codearte/resteeth/statuses/e59eb57e929472bc9bf2a3f2dfc5e9873cf74364","head":{"label":"nurkiewicz:interceptors","ref":"interceptors","sha":"e59eb57e929472bc9bf2a3f2dfc5e9873cf74364","user":{"login":"nurkiewicz","id":164045,"avatar_url":"https://avatars.githubusercontent.com/u/164045?v=3","gravatar_id":"","url":"https://api.github.com/users/nurkiewicz","html_url":"https://github.com/nurkiewicz","followers_url":"https://api.github.com/users/nurkiewicz/followers","following_url":"https://api.github.com/users/nurkiewicz/following{/other_user}","gists_url":"https://api.github.com/users/nurkiewicz/gists{/gist_id}","starred_url":"https://api.github.com/users/nurkiewicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nurkiewicz/subscriptions","organizations_url":"https://api.github.com/users/nurkiewicz/orgs","repos_url":"https://api.github.com/users/nurkiewicz/repos","events_url":"https://api.github.com/users/nurkiewicz/events{/privacy}","received_events_url":"https://api.github.com/users/nurkiewicz/received_events","type":"User","site_admin":false},"repo":{"id":26531006,"name":"resteeth","full_name":"nurkiewicz/resteeth","owner":{"login":"nurkiewicz","id":164045,"avatar_url":"https://avatars.githubusercontent.com/u/164045?v=3","gravatar_id":"","url":"https://api.github.com/users/nurkiewicz","html_url":"https://github.com/nurkiewicz","followers_url":"https://api.github.com/users/nurkiewicz/followers","following_url":"https://api.github.com/users/nurkiewicz/following{/other_user}","gists_url":"https://api.github.com/users/nurkiewicz/gists{/gist_id}","starred_url":"https://api.github.com/users/nurkiewicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nurkiewicz/subscriptions","organizations_url":"https://api.github.com/users/nurkiewicz/orgs","repos_url":"https://api.github.com/users/nurkiewicz/repos","events_url":"https://api.github.com/users/nurkiewicz/events{/privacy}","received_events_url":"https://api.github.com/users/nurkiewicz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nurkiewicz/resteeth","description":"","fork":true,"url":"https://api.github.com/repos/nurkiewicz/resteeth","forks_url":"https://api.github.com/repos/nurkiewicz/resteeth/forks","keys_url":"https://api.github.com/repos/nurkiewicz/resteeth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nurkiewicz/resteeth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nurkiewicz/resteeth/teams","hooks_url":"https://api.github.com/repos/nurkiewicz/resteeth/hooks","issue_events_url":"https://api.github.com/repos/nurkiewicz/resteeth/issues/events{/number}","events_url":"https://api.github.com/repos/nurkiewicz/resteeth/events","assignees_url":"https://api.github.com/repos/nurkiewicz/resteeth/assignees{/user}","branches_url":"https://api.github.com/repos/nurkiewicz/resteeth/branches{/branch}","tags_url":"https://api.github.com/repos/nurkiewicz/resteeth/tags","blobs_url":"https://api.github.com/repos/nurkiewicz/resteeth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nurkiewicz/resteeth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nurkiewicz/resteeth/git/refs{/sha}","trees_url":"https://api.github.com/repos/nurkiewicz/resteeth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nurkiewicz/resteeth/statuses/{sha}","languages_url":"https://api.github.com/repos/nurkiewicz/resteeth/languages","stargazers_url":"https://api.github.com/repos/nurkiewicz/resteeth/stargazers","contributors_url":"https://api.github.com/repos/nurkiewicz/resteeth/contributors","subscribers_url":"https://api.github.com/repos/nurkiewicz/resteeth/subscribers","subscription_url":"https://api.github.com/repos/nurkiewicz/resteeth/subscription","commits_url":"https://api.github.com/repos/nurkiewicz/resteeth/commits{/sha}","git_commits_url":"https://api.github.com/repos/nurkiewicz/resteeth/git/commits{/sha}","comments_url":"https://api.github.com/repos/nurkiewicz/resteeth/comments{/number}","issue_comment_url":"https://api.github.com/repos/nurkiewicz/resteeth/issues/comments/{number}","contents_url":"https://api.github.com/repos/nurkiewicz/resteeth/contents/{+path}","compare_url":"https://api.github.com/repos/nurkiewicz/resteeth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nurkiewicz/resteeth/merges","archive_url":"https://api.github.com/repos/nurkiewicz/resteeth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nurkiewicz/resteeth/downloads","issues_url":"https://api.github.com/repos/nurkiewicz/resteeth/issues{/number}","pulls_url":"https://api.github.com/repos/nurkiewicz/resteeth/pulls{/number}","milestones_url":"https://api.github.com/repos/nurkiewicz/resteeth/milestones{/number}","notifications_url":"https://api.github.com/repos/nurkiewicz/resteeth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nurkiewicz/resteeth/labels{/name}","releases_url":"https://api.github.com/repos/nurkiewicz/resteeth/releases{/id}","created_at":"2014-11-12T10:32:41Z","updated_at":"2014-11-15T18:48:12Z","pushed_at":"2014-11-15T19:50:47Z","git_url":"git://github.com/nurkiewicz/resteeth.git","ssh_url":"git@github.com:nurkiewicz/resteeth.git","clone_url":"https://github.com/nurkiewicz/resteeth.git","svn_url":"https://github.com/nurkiewicz/resteeth","homepage":null,"size":315,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Codearte:master","ref":"master","sha":"0ed3f15f3ab455942fe4bd85fa3c3ff6ede36e46","user":{"login":"Codearte","id":5014314,"avatar_url":"https://avatars.githubusercontent.com/u/5014314?v=3","gravatar_id":"","url":"https://api.github.com/users/Codearte","html_url":"https://github.com/Codearte","followers_url":"https://api.github.com/users/Codearte/followers","following_url":"https://api.github.com/users/Codearte/following{/other_user}","gists_url":"https://api.github.com/users/Codearte/gists{/gist_id}","starred_url":"https://api.github.com/users/Codearte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Codearte/subscriptions","organizations_url":"https://api.github.com/users/Codearte/orgs","repos_url":"https://api.github.com/users/Codearte/repos","events_url":"https://api.github.com/users/Codearte/events{/privacy}","received_events_url":"https://api.github.com/users/Codearte/received_events","type":"Organization","site_admin":false},"repo":{"id":26138766,"name":"resteeth","full_name":"Codearte/resteeth","owner":{"login":"Codearte","id":5014314,"avatar_url":"https://avatars.githubusercontent.com/u/5014314?v=3","gravatar_id":"","url":"https://api.github.com/users/Codearte","html_url":"https://github.com/Codearte","followers_url":"https://api.github.com/users/Codearte/followers","following_url":"https://api.github.com/users/Codearte/following{/other_user}","gists_url":"https://api.github.com/users/Codearte/gists{/gist_id}","starred_url":"https://api.github.com/users/Codearte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Codearte/subscriptions","organizations_url":"https://api.github.com/users/Codearte/orgs","repos_url":"https://api.github.com/users/Codearte/repos","events_url":"https://api.github.com/users/Codearte/events{/privacy}","received_events_url":"https://api.github.com/users/Codearte/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Codearte/resteeth","description":"","fork":false,"url":"https://api.github.com/repos/Codearte/resteeth","forks_url":"https://api.github.com/repos/Codearte/resteeth/forks","keys_url":"https://api.github.com/repos/Codearte/resteeth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Codearte/resteeth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Codearte/resteeth/teams","hooks_url":"https://api.github.com/repos/Codearte/resteeth/hooks","issue_events_url":"https://api.github.com/repos/Codearte/resteeth/issues/events{/number}","events_url":"https://api.github.com/repos/Codearte/resteeth/events","assignees_url":"https://api.github.com/repos/Codearte/resteeth/assignees{/user}","branches_url":"https://api.github.com/repos/Codearte/resteeth/branches{/branch}","tags_url":"https://api.github.com/repos/Codearte/resteeth/tags","blobs_url":"https://api.github.com/repos/Codearte/resteeth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Codearte/resteeth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Codearte/resteeth/git/refs{/sha}","trees_url":"https://api.github.com/repos/Codearte/resteeth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Codearte/resteeth/statuses/{sha}","languages_url":"https://api.github.com/repos/Codearte/resteeth/languages","stargazers_url":"https://api.github.com/repos/Codearte/resteeth/stargazers","contributors_url":"https://api.github.com/repos/Codearte/resteeth/contributors","subscribers_url":"https://api.github.com/repos/Codearte/resteeth/subscribers","subscription_url":"https://api.github.com/repos/Codearte/resteeth/subscription","commits_url":"https://api.github.com/repos/Codearte/resteeth/commits{/sha}","git_commits_url":"https://api.github.com/repos/Codearte/resteeth/git/commits{/sha}","comments_url":"https://api.github.com/repos/Codearte/resteeth/comments{/number}","issue_comment_url":"https://api.github.com/repos/Codearte/resteeth/issues/comments/{number}","contents_url":"https://api.github.com/repos/Codearte/resteeth/contents/{+path}","compare_url":"https://api.github.com/repos/Codearte/resteeth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Codearte/resteeth/merges","archive_url":"https://api.github.com/repos/Codearte/resteeth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Codearte/resteeth/downloads","issues_url":"https://api.github.com/repos/Codearte/resteeth/issues{/number}","pulls_url":"https://api.github.com/repos/Codearte/resteeth/pulls{/number}","milestones_url":"https://api.github.com/repos/Codearte/resteeth/milestones{/number}","notifications_url":"https://api.github.com/repos/Codearte/resteeth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Codearte/resteeth/labels{/name}","releases_url":"https://api.github.com/repos/Codearte/resteeth/releases{/id}","created_at":"2014-11-03T21:06:58Z","updated_at":"2014-11-12T23:49:47Z","pushed_at":"2014-11-15T20:11:13Z","git_url":"git://github.com/Codearte/resteeth.git","ssh_url":"git@github.com:Codearte/resteeth.git","clone_url":"https://github.com/Codearte/resteeth.git","svn_url":"https://github.com/Codearte/resteeth","homepage":null,"size":315,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":9,"forks":2,"open_issues":9,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Codearte/resteeth/pulls/17"},"html":{"href":"https://github.com/Codearte/resteeth/pull/17"},"issue":{"href":"https://api.github.com/repos/Codearte/resteeth/issues/17"},"comments":{"href":"https://api.github.com/repos/Codearte/resteeth/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/Codearte/resteeth/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/Codearte/resteeth/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Codearte/resteeth/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/Codearte/resteeth/statuses/e59eb57e929472bc9bf2a3f2dfc5e9873cf74364"}}}}