GitHub PullRequestReviewCommentEvent at 2014-10-01 11:03:17
Repository: gemini-coverage
Actor: j0tunn
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/bem/gemini-coverage/pulls/comments/18271882","id":18271882,"diff_hunk":"@@ -99,15 +99,17 @@ module.exports = inherit({\n      */\n     _getTests: function() {\n         var self = this.__self;\n-        return QFS.list(this._testsPath)\n+        return QFS.exists(this._testsPath)\n+            .then(function(exists) {\n+                return exists ? QFS.list(this._testsPath) : [];\n+            }.bind(this))\n             .then(function(tests) {\n                 return tests\n                     .filter(RegExp.prototype.test.bind(self._TESTS_PATTERN))\n                     .map(function(test) {\n                         return test.match(self._TESTS_PATTERN)[1];\n                     });\n-            })\n-            .then(self._throwIfNotFound('Tests were not found'));\n+            });","path":"lib/scanner.js","position":17,"original_position":17,"commit_id":"f903391b9167ab4f1b98a56676062a9b009b05fa","original_commit_id":"f903391b9167ab4f1b98a56676062a9b009b05fa","user":{"login":"j0tunn","id":7701229,"avatar_url":"https://avatars.githubusercontent.com/u/7701229?v=2","gravatar_id":"","url":"https://api.github.com/users/j0tunn","html_url":"https://github.com/j0tunn","followers_url":"https://api.github.com/users/j0tunn/followers","following_url":"https://api.github.com/users/j0tunn/following{/other_user}","gists_url":"https://api.github.com/users/j0tunn/gists{/gist_id}","starred_url":"https://api.github.com/users/j0tunn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j0tunn/subscriptions","organizations_url":"https://api.github.com/users/j0tunn/orgs","repos_url":"https://api.github.com/users/j0tunn/repos","events_url":"https://api.github.com/users/j0tunn/events{/privacy}","received_events_url":"https://api.github.com/users/j0tunn/received_events","type":"User","site_admin":false},"body":"ну так ничего и не будет делаться, только код понятней будет","created_at":"2014-10-01T11:03:17Z","updated_at":"2014-10-01T11:03:17Z","html_url":"https://github.com/bem/gemini-coverage/pull/5#discussion_r18271882","pull_request_url":"https://api.github.com/repos/bem/gemini-coverage/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/bem/gemini-coverage/pulls/comments/18271882"},"html":{"href":"https://github.com/bem/gemini-coverage/pull/5#discussion_r18271882"},"pull_request":{"href":"https://api.github.com/repos/bem/gemini-coverage/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/bem/gemini-coverage/pulls/5","id":22064295,"html_url":"https://github.com/bem/gemini-coverage/pull/5","diff_url":"https://github.com/bem/gemini-coverage/pull/5.diff","patch_url":"https://github.com/bem/gemini-coverage/pull/5.patch","issue_url":"https://api.github.com/repos/bem/gemini-coverage/issues/5","number":5,"state":"open","locked":false,"title":"No tests - no coverage, but no error","user":{"login":"j0tunn","id":7701229,"avatar_url":"https://avatars.githubusercontent.com/u/7701229?v=2","gravatar_id":"","url":"https://api.github.com/users/j0tunn","html_url":"https://github.com/j0tunn","followers_url":"https://api.github.com/users/j0tunn/followers","following_url":"https://api.github.com/users/j0tunn/following{/other_user}","gists_url":"https://api.github.com/users/j0tunn/gists{/gist_id}","starred_url":"https://api.github.com/users/j0tunn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j0tunn/subscriptions","organizations_url":"https://api.github.com/users/j0tunn/orgs","repos_url":"https://api.github.com/users/j0tunn/repos","events_url":"https://api.github.com/users/j0tunn/events{/privacy}","received_events_url":"https://api.github.com/users/j0tunn/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-10-01T10:38:08Z","updated_at":"2014-10-01T11:03:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bb7a861dbbb269eafb012d04a649ba2b9e4d7c0b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bem/gemini-coverage/pulls/5/commits","review_comments_url":"https://api.github.com/repos/bem/gemini-coverage/pulls/5/comments","review_comment_url":"https://api.github.com/repos/bem/gemini-coverage/pulls/comments/{number}","comments_url":"https://api.github.com/repos/bem/gemini-coverage/issues/5/comments","statuses_url":"https://api.github.com/repos/bem/gemini-coverage/statuses/f903391b9167ab4f1b98a56676062a9b009b05fa","head":{"label":"j0tunn:no.gemini.folder","ref":"no.gemini.folder","sha":"f903391b9167ab4f1b98a56676062a9b009b05fa","user":{"login":"j0tunn","id":7701229,"avatar_url":"https://avatars.githubusercontent.com/u/7701229?v=2","gravatar_id":"","url":"https://api.github.com/users/j0tunn","html_url":"https://github.com/j0tunn","followers_url":"https://api.github.com/users/j0tunn/followers","following_url":"https://api.github.com/users/j0tunn/following{/other_user}","gists_url":"https://api.github.com/users/j0tunn/gists{/gist_id}","starred_url":"https://api.github.com/users/j0tunn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j0tunn/subscriptions","organizations_url":"https://api.github.com/users/j0tunn/orgs","repos_url":"https://api.github.com/users/j0tunn/repos","events_url":"https://api.github.com/users/j0tunn/events{/privacy}","received_events_url":"https://api.github.com/users/j0tunn/received_events","type":"User","site_admin":false},"repo":{"id":24674279,"name":"gemini-coverage","full_name":"j0tunn/gemini-coverage","owner":{"login":"j0tunn","id":7701229,"avatar_url":"https://avatars.githubusercontent.com/u/7701229?v=2","gravatar_id":"","url":"https://api.github.com/users/j0tunn","html_url":"https://github.com/j0tunn","followers_url":"https://api.github.com/users/j0tunn/followers","following_url":"https://api.github.com/users/j0tunn/following{/other_user}","gists_url":"https://api.github.com/users/j0tunn/gists{/gist_id}","starred_url":"https://api.github.com/users/j0tunn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j0tunn/subscriptions","organizations_url":"https://api.github.com/users/j0tunn/orgs","repos_url":"https://api.github.com/users/j0tunn/repos","events_url":"https://api.github.com/users/j0tunn/events{/privacy}","received_events_url":"https://api.github.com/users/j0tunn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/j0tunn/gemini-coverage","description":"Simple gemini coverage","fork":true,"url":"https://api.github.com/repos/j0tunn/gemini-coverage","forks_url":"https://api.github.com/repos/j0tunn/gemini-coverage/forks","keys_url":"https://api.github.com/repos/j0tunn/gemini-coverage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/j0tunn/gemini-coverage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/j0tunn/gemini-coverage/teams","hooks_url":"https://api.github.com/repos/j0tunn/gemini-coverage/hooks","issue_events_url":"https://api.github.com/repos/j0tunn/gemini-coverage/issues/events{/number}","events_url":"https://api.github.com/repos/j0tunn/gemini-coverage/events","assignees_url":"https://api.github.com/repos/j0tunn/gemini-coverage/assignees{/user}","branches_url":"https://api.github.com/repos/j0tunn/gemini-coverage/branches{/branch}","tags_url":"https://api.github.com/repos/j0tunn/gemini-coverage/tags","blobs_url":"https://api.github.com/repos/j0tunn/gemini-coverage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/j0tunn/gemini-coverage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/j0tunn/gemini-coverage/git/refs{/sha}","trees_url":"https://api.github.com/repos/j0tunn/gemini-coverage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/j0tunn/gemini-coverage/statuses/{sha}","languages_url":"https://api.github.com/repos/j0tunn/gemini-coverage/languages","stargazers_url":"https://api.github.com/repos/j0tunn/gemini-coverage/stargazers","contributors_url":"https://api.github.com/repos/j0tunn/gemini-coverage/contributors","subscribers_url":"https://api.github.com/repos/j0tunn/gemini-coverage/subscribers","subscription_url":"https://api.github.com/repos/j0tunn/gemini-coverage/subscription","commits_url":"https://api.github.com/repos/j0tunn/gemini-coverage/commits{/sha}","git_commits_url":"https://api.github.com/repos/j0tunn/gemini-coverage/git/commits{/sha}","comments_url":"https://api.github.com/repos/j0tunn/gemini-coverage/comments{/number}","issue_comment_url":"https://api.github.com/repos/j0tunn/gemini-coverage/issues/comments/{number}","contents_url":"https://api.github.com/repos/j0tunn/gemini-coverage/contents/{+path}","compare_url":"https://api.github.com/repos/j0tunn/gemini-coverage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/j0tunn/gemini-coverage/merges","archive_url":"https://api.github.com/repos/j0tunn/gemini-coverage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/j0tunn/gemini-coverage/downloads","issues_url":"https://api.github.com/repos/j0tunn/gemini-coverage/issues{/number}","pulls_url":"https://api.github.com/repos/j0tunn/gemini-coverage/pulls{/number}","milestones_url":"https://api.github.com/repos/j0tunn/gemini-coverage/milestones{/number}","notifications_url":"https://api.github.com/repos/j0tunn/gemini-coverage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/j0tunn/gemini-coverage/labels{/name}","releases_url":"https://api.github.com/repos/j0tunn/gemini-coverage/releases{/id}","created_at":"2014-10-01T10:26:28Z","updated_at":"2014-09-04T13:55:30Z","pushed_at":"2014-10-01T10:59:43Z","git_url":"git://github.com/j0tunn/gemini-coverage.git","ssh_url":"git@github.com:j0tunn/gemini-coverage.git","clone_url":"https://github.com/j0tunn/gemini-coverage.git","svn_url":"https://github.com/j0tunn/gemini-coverage","homepage":null,"size":368,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bem:master","ref":"master","sha":"a96e36c3991bd188a72d6fad391c0aae3285f8e7","user":{"login":"bem","id":223412,"avatar_url":"https://avatars.githubusercontent.com/u/223412?v=2","gravatar_id":"","url":"https://api.github.com/users/bem","html_url":"https://github.com/bem","followers_url":"https://api.github.com/users/bem/followers","following_url":"https://api.github.com/users/bem/following{/other_user}","gists_url":"https://api.github.com/users/bem/gists{/gist_id}","starred_url":"https://api.github.com/users/bem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bem/subscriptions","organizations_url":"https://api.github.com/users/bem/orgs","repos_url":"https://api.github.com/users/bem/repos","events_url":"https://api.github.com/users/bem/events{/privacy}","received_events_url":"https://api.github.com/users/bem/received_events","type":"Organization","site_admin":false},"repo":{"id":23026607,"name":"gemini-coverage","full_name":"bem/gemini-coverage","owner":{"login":"bem","id":223412,"avatar_url":"https://avatars.githubusercontent.com/u/223412?v=2","gravatar_id":"","url":"https://api.github.com/users/bem","html_url":"https://github.com/bem","followers_url":"https://api.github.com/users/bem/followers","following_url":"https://api.github.com/users/bem/following{/other_user}","gists_url":"https://api.github.com/users/bem/gists{/gist_id}","starred_url":"https://api.github.com/users/bem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bem/subscriptions","organizations_url":"https://api.github.com/users/bem/orgs","repos_url":"https://api.github.com/users/bem/repos","events_url":"https://api.github.com/users/bem/events{/privacy}","received_events_url":"https://api.github.com/users/bem/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bem/gemini-coverage","description":"Simple gemini coverage","fork":false,"url":"https://api.github.com/repos/bem/gemini-coverage","forks_url":"https://api.github.com/repos/bem/gemini-coverage/forks","keys_url":"https://api.github.com/repos/bem/gemini-coverage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bem/gemini-coverage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bem/gemini-coverage/teams","hooks_url":"https://api.github.com/repos/bem/gemini-coverage/hooks","issue_events_url":"https://api.github.com/repos/bem/gemini-coverage/issues/events{/number}","events_url":"https://api.github.com/repos/bem/gemini-coverage/events","assignees_url":"https://api.github.com/repos/bem/gemini-coverage/assignees{/user}","branches_url":"https://api.github.com/repos/bem/gemini-coverage/branches{/branch}","tags_url":"https://api.github.com/repos/bem/gemini-coverage/tags","blobs_url":"https://api.github.com/repos/bem/gemini-coverage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bem/gemini-coverage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bem/gemini-coverage/git/refs{/sha}","trees_url":"https://api.github.com/repos/bem/gemini-coverage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bem/gemini-coverage/statuses/{sha}","languages_url":"https://api.github.com/repos/bem/gemini-coverage/languages","stargazers_url":"https://api.github.com/repos/bem/gemini-coverage/stargazers","contributors_url":"https://api.github.com/repos/bem/gemini-coverage/contributors","subscribers_url":"https://api.github.com/repos/bem/gemini-coverage/subscribers","subscription_url":"https://api.github.com/repos/bem/gemini-coverage/subscription","commits_url":"https://api.github.com/repos/bem/gemini-coverage/commits{/sha}","git_commits_url":"https://api.github.com/repos/bem/gemini-coverage/git/commits{/sha}","comments_url":"https://api.github.com/repos/bem/gemini-coverage/comments{/number}","issue_comment_url":"https://api.github.com/repos/bem/gemini-coverage/issues/comments/{number}","contents_url":"https://api.github.com/repos/bem/gemini-coverage/contents/{+path}","compare_url":"https://api.github.com/repos/bem/gemini-coverage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bem/gemini-coverage/merges","archive_url":"https://api.github.com/repos/bem/gemini-coverage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bem/gemini-coverage/downloads","issues_url":"https://api.github.com/repos/bem/gemini-coverage/issues{/number}","pulls_url":"https://api.github.com/repos/bem/gemini-coverage/pulls{/number}","milestones_url":"https://api.github.com/repos/bem/gemini-coverage/milestones{/number}","notifications_url":"https://api.github.com/repos/bem/gemini-coverage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bem/gemini-coverage/labels{/name}","releases_url":"https://api.github.com/repos/bem/gemini-coverage/releases{/id}","created_at":"2014-08-16T20:35:31Z","updated_at":"2014-09-04T13:55:30Z","pushed_at":"2014-09-24T14:52:54Z","git_url":"git://github.com/bem/gemini-coverage.git","ssh_url":"git@github.com:bem/gemini-coverage.git","clone_url":"https://github.com/bem/gemini-coverage.git","svn_url":"https://github.com/bem/gemini-coverage","homepage":null,"size":368,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bem/gemini-coverage/pulls/5"},"html":{"href":"https://github.com/bem/gemini-coverage/pull/5"},"issue":{"href":"https://api.github.com/repos/bem/gemini-coverage/issues/5"},"comments":{"href":"https://api.github.com/repos/bem/gemini-coverage/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/bem/gemini-coverage/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/bem/gemini-coverage/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/bem/gemini-coverage/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/bem/gemini-coverage/statuses/f903391b9167ab4f1b98a56676062a9b009b05fa"}}}}