GitHub PullRequestReviewCommentEvent at 2014-06-11 10:46:57
Repository: phpmyadmin
Actor: dhananjay92
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/pulls/comments/13643005","id":13643005,"diff_hunk":"@@ -205,3 +205,5 @@\n     . $querydisplay_tab . '\" />';\n echo '</form>';\n echo '</div>';\n+\n+?>","path":"querywindow.php","position":5,"original_position":5,"commit_id":"064100f4f80108d0d086ecd9290b8f73e2c28e0d","original_commit_id":"064100f4f80108d0d086ecd9290b8f73e2c28e0d","user":{"login":"dhananjay92","id":6269279,"avatar_url":"https://avatars.githubusercontent.com/u/6269279?","gravatar_id":"599b15af43f2893df8378c6215fada1e","url":"https://api.github.com/users/dhananjay92","html_url":"https://github.com/dhananjay92","followers_url":"https://api.github.com/users/dhananjay92/followers","following_url":"https://api.github.com/users/dhananjay92/following{/other_user}","gists_url":"https://api.github.com/users/dhananjay92/gists{/gist_id}","starred_url":"https://api.github.com/users/dhananjay92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhananjay92/subscriptions","organizations_url":"https://api.github.com/users/dhananjay92/orgs","repos_url":"https://api.github.com/users/dhananjay92/repos","events_url":"https://api.github.com/users/dhananjay92/events{/privacy}","received_events_url":"https://api.github.com/users/dhananjay92/received_events","type":"User","site_admin":false},"body":"@nijel : Should I keep these added closing php brackets or remove them too?","created_at":"2014-06-11T10:46:57Z","updated_at":"2014-06-11T10:46:57Z","html_url":"https://github.com/phpmyadmin/phpmyadmin/pull/1219#discussion_r13643005","pull_request_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/pulls/1219","_links":{"self":{"href":"https://api.github.com/repos/phpmyadmin/phpmyadmin/pulls/comments/13643005"},"html":{"href":"https://github.com/phpmyadmin/phpmyadmin/pull/1219#discussion_r13643005"},"pull_request":{"href":"https://api.github.com/repos/phpmyadmin/phpmyadmin/pulls/1219"}}},"pull_request":{"url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/pulls/1219","id":16952955,"html_url":"https://github.com/phpmyadmin/phpmyadmin/pull/1219","diff_url":"https://github.com/phpmyadmin/phpmyadmin/pull/1219.diff","patch_url":"https://github.com/phpmyadmin/phpmyadmin/pull/1219.patch","issue_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/issues/1219","number":1219,"state":"open","title":"Commits for review: Add php Error Reporting Functionality to PMA (Rebased)","user":{"login":"dhananjay92","id":6269279,"avatar_url":"https://avatars.githubusercontent.com/u/6269279?","gravatar_id":"599b15af43f2893df8378c6215fada1e","url":"https://api.github.com/users/dhananjay92","html_url":"https://github.com/dhananjay92","followers_url":"https://api.github.com/users/dhananjay92/followers","following_url":"https://api.github.com/users/dhananjay92/following{/other_user}","gists_url":"https://api.github.com/users/dhananjay92/gists{/gist_id}","starred_url":"https://api.github.com/users/dhananjay92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhananjay92/subscriptions","organizations_url":"https://api.github.com/users/dhananjay92/orgs","repos_url":"https://api.github.com/users/dhananjay92/repos","events_url":"https://api.github.com/users/dhananjay92/events{/privacy}","received_events_url":"https://api.github.com/users/dhananjay92/received_events","type":"User","site_admin":false},"body":"*In continuation with Pull#1207.*\r\n**Things Done:**\r\n - [x] Rebasing with upstream. (There were few conflicts which I had to resolve.)\r\n - [x] Some displayed message improvements.\r\n - [x] Found & stopped one more false alarm.\r\n\r\n**~~Things yet TODO:~~**  *Done now*\r\n - [x] Remove inline JavaScripts as suggested in [Pull#1207](https://github.com/phpmyadmin/phpmyadmin/pull/1207#discussion_r13531075).\r\n\r\n~~Will push **TODO** changes soon.~~ *Done now*\r\n\r\nTill then, kindly review other parts. :smiley: ","created_at":"2014-06-10T17:17:49Z","updated_at":"2014-06-11T10:46:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c0c0d3bd10821f9069c64efaae154e3a508b4346","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/pulls/1219/commits","review_comments_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/pulls/1219/comments","review_comment_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/pulls/comments/{number}","comments_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/issues/1219/comments","statuses_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/statuses/064100f4f80108d0d086ecd9290b8f73e2c28e0d","head":{"label":"dhananjay92:dhananjay-gsoc-rebased","ref":"dhananjay-gsoc-rebased","sha":"064100f4f80108d0d086ecd9290b8f73e2c28e0d","user":{"login":"dhananjay92","id":6269279,"avatar_url":"https://avatars.githubusercontent.com/u/6269279?","gravatar_id":"599b15af43f2893df8378c6215fada1e","url":"https://api.github.com/users/dhananjay92","html_url":"https://github.com/dhananjay92","followers_url":"https://api.github.com/users/dhananjay92/followers","following_url":"https://api.github.com/users/dhananjay92/following{/other_user}","gists_url":"https://api.github.com/users/dhananjay92/gists{/gist_id}","starred_url":"https://api.github.com/users/dhananjay92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhananjay92/subscriptions","organizations_url":"https://api.github.com/users/dhananjay92/orgs","repos_url":"https://api.github.com/users/dhananjay92/repos","events_url":"https://api.github.com/users/dhananjay92/events{/privacy}","received_events_url":"https://api.github.com/users/dhananjay92/received_events","type":"User","site_admin":false},"repo":{"id":16661971,"name":"phpmyadmin","full_name":"dhananjay92/phpmyadmin","owner":{"login":"dhananjay92","id":6269279,"avatar_url":"https://avatars.githubusercontent.com/u/6269279?","gravatar_id":"599b15af43f2893df8378c6215fada1e","url":"https://api.github.com/users/dhananjay92","html_url":"https://github.com/dhananjay92","followers_url":"https://api.github.com/users/dhananjay92/followers","following_url":"https://api.github.com/users/dhananjay92/following{/other_user}","gists_url":"https://api.github.com/users/dhananjay92/gists{/gist_id}","starred_url":"https://api.github.com/users/dhananjay92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhananjay92/subscriptions","organizations_url":"https://api.github.com/users/dhananjay92/orgs","repos_url":"https://api.github.com/users/dhananjay92/repos","events_url":"https://api.github.com/users/dhananjay92/events{/privacy}","received_events_url":"https://api.github.com/users/dhananjay92/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dhananjay92/phpmyadmin","description":"Dhananjay's copy of phpMyAdmin. :smiley:","fork":true,"url":"https://api.github.com/repos/dhananjay92/phpmyadmin","forks_url":"https://api.github.com/repos/dhananjay92/phpmyadmin/forks","keys_url":"https://api.github.com/repos/dhananjay92/phpmyadmin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dhananjay92/phpmyadmin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dhananjay92/phpmyadmin/teams","hooks_url":"https://api.github.com/repos/dhananjay92/phpmyadmin/hooks","issue_events_url":"https://api.github.com/repos/dhananjay92/phpmyadmin/issues/events{/number}","events_url":"https://api.github.com/repos/dhananjay92/phpmyadmin/events","assignees_url":"https://api.github.com/repos/dhananjay92/phpmyadmin/assignees{/user}","branches_url":"https://api.github.com/repos/dhananjay92/phpmyadmin/branches{/branch}","tags_url":"https://api.github.com/repos/dhananjay92/phpmyadmin/tags","blobs_url":"https://api.github.com/repos/dhananjay92/phpmyadmin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dhananjay92/phpmyadmin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dhananjay92/phpmyadmin/git/refs{/sha}","trees_url":"https://api.github.com/repos/dhananjay92/phpmyadmin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dhananjay92/phpmyadmin/statuses/{sha}","languages_url":"https://api.github.com/repos/dhananjay92/phpmyadmin/languages","stargazers_url":"https://api.github.com/repos/dhananjay92/phpmyadmin/stargazers","contributors_url":"https://api.github.com/repos/dhananjay92/phpmyadmin/contributors","subscribers_url":"https://api.github.com/repos/dhananjay92/phpmyadmin/subscribers","subscription_url":"https://api.github.com/repos/dhananjay92/phpmyadmin/subscription","commits_url":"https://api.github.com/repos/dhananjay92/phpmyadmin/commits{/sha}","git_commits_url":"https://api.github.com/repos/dhananjay92/phpmyadmin/git/commits{/sha}","comments_url":"https://api.github.com/repos/dhananjay92/phpmyadmin/comments{/number}","issue_comment_url":"https://api.github.com/repos/dhananjay92/phpmyadmin/issues/comments/{number}","contents_url":"https://api.github.com/repos/dhananjay92/phpmyadmin/contents/{+path}","compare_url":"https://api.github.com/repos/dhananjay92/phpmyadmin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dhananjay92/phpmyadmin/merges","archive_url":"https://api.github.com/repos/dhananjay92/phpmyadmin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dhananjay92/phpmyadmin/downloads","issues_url":"https://api.github.com/repos/dhananjay92/phpmyadmin/issues{/number}","pulls_url":"https://api.github.com/repos/dhananjay92/phpmyadmin/pulls{/number}","milestones_url":"https://api.github.com/repos/dhananjay92/phpmyadmin/milestones{/number}","notifications_url":"https://api.github.com/repos/dhananjay92/phpmyadmin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dhananjay92/phpmyadmin/labels{/name}","releases_url":"https://api.github.com/repos/dhananjay92/phpmyadmin/releases{/id}","created_at":"2014-02-09T07:12:45Z","updated_at":"2014-06-11T10:35:57Z","pushed_at":"2014-06-11T10:35:56Z","git_url":"git://github.com/dhananjay92/phpmyadmin.git","ssh_url":"git@github.com:dhananjay92/phpmyadmin.git","clone_url":"https://github.com/dhananjay92/phpmyadmin.git","svn_url":"https://github.com/dhananjay92/phpmyadmin","homepage":"http://www.phpmyadmin.net/","size":482054,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":1,"default_branch":"dhananjay-gsoc-dev"}},"base":{"label":"phpmyadmin:master","ref":"master","sha":"2ca90016082ece7c9d1af7d1bfe7c00d466b4e0f","user":{"login":"phpmyadmin","id":1351977,"avatar_url":"https://avatars.githubusercontent.com/u/1351977?","gravatar_id":"4be7d922dc46f22e6b0cf1162f0e329b","url":"https://api.github.com/users/phpmyadmin","html_url":"https://github.com/phpmyadmin","followers_url":"https://api.github.com/users/phpmyadmin/followers","following_url":"https://api.github.com/users/phpmyadmin/following{/other_user}","gists_url":"https://api.github.com/users/phpmyadmin/gists{/gist_id}","starred_url":"https://api.github.com/users/phpmyadmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phpmyadmin/subscriptions","organizations_url":"https://api.github.com/users/phpmyadmin/orgs","repos_url":"https://api.github.com/users/phpmyadmin/repos","events_url":"https://api.github.com/users/phpmyadmin/events{/privacy}","received_events_url":"https://api.github.com/users/phpmyadmin/received_events","type":"Organization","site_admin":false},"repo":{"id":3217621,"name":"phpmyadmin","full_name":"phpmyadmin/phpmyadmin","owner":{"login":"phpmyadmin","id":1351977,"avatar_url":"https://avatars.githubusercontent.com/u/1351977?","gravatar_id":"4be7d922dc46f22e6b0cf1162f0e329b","url":"https://api.github.com/users/phpmyadmin","html_url":"https://github.com/phpmyadmin","followers_url":"https://api.github.com/users/phpmyadmin/followers","following_url":"https://api.github.com/users/phpmyadmin/following{/other_user}","gists_url":"https://api.github.com/users/phpmyadmin/gists{/gist_id}","starred_url":"https://api.github.com/users/phpmyadmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phpmyadmin/subscriptions","organizations_url":"https://api.github.com/users/phpmyadmin/orgs","repos_url":"https://api.github.com/users/phpmyadmin/repos","events_url":"https://api.github.com/users/phpmyadmin/events{/privacy}","received_events_url":"https://api.github.com/users/phpmyadmin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/phpmyadmin/phpmyadmin","description":"phpMyAdmin itself","fork":false,"url":"https://api.github.com/repos/phpmyadmin/phpmyadmin","forks_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/forks","keys_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/teams","hooks_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/hooks","issue_events_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/issues/events{/number}","events_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/events","assignees_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/assignees{/user}","branches_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/branches{/branch}","tags_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/tags","blobs_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/git/refs{/sha}","trees_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/statuses/{sha}","languages_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/languages","stargazers_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/stargazers","contributors_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/contributors","subscribers_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/subscribers","subscription_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/subscription","commits_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/commits{/sha}","git_commits_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/git/commits{/sha}","comments_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/comments{/number}","issue_comment_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/issues/comments/{number}","contents_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/contents/{+path}","compare_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/merges","archive_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/downloads","issues_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/issues{/number}","pulls_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/pulls{/number}","milestones_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/milestones{/number}","notifications_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/labels{/name}","releases_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/releases{/id}","created_at":"2012-01-19T13:21:52Z","updated_at":"2014-06-11T07:06:50Z","pushed_at":"2014-06-11T07:06:53Z","git_url":"git://github.com/phpmyadmin/phpmyadmin.git","ssh_url":"git@github.com:phpmyadmin/phpmyadmin.git","clone_url":"https://github.com/phpmyadmin/phpmyadmin.git","svn_url":"https://github.com/phpmyadmin/phpmyadmin","homepage":"http://www.phpmyadmin.net/","size":611881,"stargazers_count":856,"watchers_count":856,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":477,"mirror_url":null,"open_issues_count":6,"forks":477,"open_issues":6,"watchers":856,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/phpmyadmin/phpmyadmin/pulls/1219"},"html":{"href":"https://github.com/phpmyadmin/phpmyadmin/pull/1219"},"issue":{"href":"https://api.github.com/repos/phpmyadmin/phpmyadmin/issues/1219"},"comments":{"href":"https://api.github.com/repos/phpmyadmin/phpmyadmin/issues/1219/comments"},"review_comments":{"href":"https://api.github.com/repos/phpmyadmin/phpmyadmin/pulls/1219/comments"},"review_comment":{"href":"https://api.github.com/repos/phpmyadmin/phpmyadmin/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/phpmyadmin/phpmyadmin/pulls/1219/commits"},"statuses":{"href":"https://api.github.com/repos/phpmyadmin/phpmyadmin/statuses/064100f4f80108d0d086ecd9290b8f73e2c28e0d"}}}}