GitHub PullRequestEvent at 2014-07-04 11:22:00
Repository: mapserver
Actor: tbonfort
Payload: {"action":"closed","number":4952,"pull_request":{"url":"https://api.github.com/repos/mapserver/mapserver/pulls/4952","id":17944445,"html_url":"https://github.com/mapserver/mapserver/pull/4952","diff_url":"https://github.com/mapserver/mapserver/pull/4952.diff","patch_url":"https://github.com/mapserver/mapserver/pull/4952.patch","issue_url":"https://api.github.com/repos/mapserver/mapserver/issues/4952","number":4952,"state":"closed","title":"Fix illegal use of stack-allocated objects in maprendering","user":{"login":"pmauduit","id":594335,"avatar_url":"https://avatars.githubusercontent.com/u/594335?","gravatar_id":"41de86dcd9ad40e0b19bbdec7a614024","url":"https://api.github.com/users/pmauduit","html_url":"https://github.com/pmauduit","followers_url":"https://api.github.com/users/pmauduit/followers","following_url":"https://api.github.com/users/pmauduit/following{/other_user}","gists_url":"https://api.github.com/users/pmauduit/gists{/gist_id}","starred_url":"https://api.github.com/users/pmauduit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmauduit/subscriptions","organizations_url":"https://api.github.com/users/pmauduit/orgs","repos_url":"https://api.github.com/users/pmauduit/repos","events_url":"https://api.github.com/users/pmauduit/events{/privacy}","received_events_url":"https://api.github.com/users/pmauduit/received_events","type":"User","site_admin":false},"body":"pointObj and lineObj defined in the else block in msDrawLabelBounds()\r\nare valid only in the \"else\" block context. Once outside (e.g. in the\r\n\"return msDrawShadeSymbol()\"), the variables should not be considered\r\nvalid anymore ; it led in some cases in underlying calls to\r\nmsSmallAlloc() with a negative integer, resulting in a \"unable to\r\nallocate memory\" error.\r\n\r\nFirst version of this patch extracted the pointObj / lineObj variables\r\njust before the \"if\" call, the current one was proposed by @gberaudo.","created_at":"2014-07-03T13:39:16Z","updated_at":"2014-07-04T11:21:59Z","closed_at":"2014-07-04T11:21:59Z","merged_at":"2014-07-04T11:21:59Z","merge_commit_sha":"e1ad820de6638153c62f9687608e811fa893bede","assignee":{"login":"tbonfort","id":358469,"avatar_url":"https://avatars.githubusercontent.com/u/358469?","gravatar_id":"ba1312a46d36c13fb91bc8f625b6c175","url":"https://api.github.com/users/tbonfort","html_url":"https://github.com/tbonfort","followers_url":"https://api.github.com/users/tbonfort/followers","following_url":"https://api.github.com/users/tbonfort/following{/other_user}","gists_url":"https://api.github.com/users/tbonfort/gists{/gist_id}","starred_url":"https://api.github.com/users/tbonfort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbonfort/subscriptions","organizations_url":"https://api.github.com/users/tbonfort/orgs","repos_url":"https://api.github.com/users/tbonfort/repos","events_url":"https://api.github.com/users/tbonfort/events{/privacy}","received_events_url":"https://api.github.com/users/tbonfort/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/mapserver/mapserver/milestones/38","labels_url":"https://api.github.com/repos/mapserver/mapserver/milestones/38/labels","id":364391,"number":38,"title":"7.0 Release","description":"","creator":{"login":"tbonfort","id":358469,"avatar_url":"https://avatars.githubusercontent.com/u/358469?","gravatar_id":"ba1312a46d36c13fb91bc8f625b6c175","url":"https://api.github.com/users/tbonfort","html_url":"https://github.com/tbonfort","followers_url":"https://api.github.com/users/tbonfort/followers","following_url":"https://api.github.com/users/tbonfort/following{/other_user}","gists_url":"https://api.github.com/users/tbonfort/gists{/gist_id}","starred_url":"https://api.github.com/users/tbonfort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbonfort/subscriptions","organizations_url":"https://api.github.com/users/tbonfort/orgs","repos_url":"https://api.github.com/users/tbonfort/repos","events_url":"https://api.github.com/users/tbonfort/events{/privacy}","received_events_url":"https://api.github.com/users/tbonfort/received_events","type":"User","site_admin":false},"open_issues":19,"closed_issues":25,"state":"open","created_at":"2013-06-26T14:43:57Z","updated_at":"2014-07-04T11:21:59Z","due_on":null},"commits_url":"https://api.github.com/repos/mapserver/mapserver/pulls/4952/commits","review_comments_url":"https://api.github.com/repos/mapserver/mapserver/pulls/4952/comments","review_comment_url":"https://api.github.com/repos/mapserver/mapserver/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mapserver/mapserver/issues/4952/comments","statuses_url":"https://api.github.com/repos/mapserver/mapserver/statuses/f7772c36c39e28fe4e53d6632aedcc32c542877c","head":{"label":"pmauduit:fix-illegal-use-stack","ref":"fix-illegal-use-stack","sha":"f7772c36c39e28fe4e53d6632aedcc32c542877c","user":{"login":"pmauduit","id":594335,"avatar_url":"https://avatars.githubusercontent.com/u/594335?","gravatar_id":"41de86dcd9ad40e0b19bbdec7a614024","url":"https://api.github.com/users/pmauduit","html_url":"https://github.com/pmauduit","followers_url":"https://api.github.com/users/pmauduit/followers","following_url":"https://api.github.com/users/pmauduit/following{/other_user}","gists_url":"https://api.github.com/users/pmauduit/gists{/gist_id}","starred_url":"https://api.github.com/users/pmauduit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmauduit/subscriptions","organizations_url":"https://api.github.com/users/pmauduit/orgs","repos_url":"https://api.github.com/users/pmauduit/repos","events_url":"https://api.github.com/users/pmauduit/events{/privacy}","received_events_url":"https://api.github.com/users/pmauduit/received_events","type":"User","site_admin":false},"repo":{"id":16585728,"name":"mapserver","full_name":"pmauduit/mapserver","owner":{"login":"pmauduit","id":594335,"avatar_url":"https://avatars.githubusercontent.com/u/594335?","gravatar_id":"41de86dcd9ad40e0b19bbdec7a614024","url":"https://api.github.com/users/pmauduit","html_url":"https://github.com/pmauduit","followers_url":"https://api.github.com/users/pmauduit/followers","following_url":"https://api.github.com/users/pmauduit/following{/other_user}","gists_url":"https://api.github.com/users/pmauduit/gists{/gist_id}","starred_url":"https://api.github.com/users/pmauduit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmauduit/subscriptions","organizations_url":"https://api.github.com/users/pmauduit/orgs","repos_url":"https://api.github.com/users/pmauduit/repos","events_url":"https://api.github.com/users/pmauduit/events{/privacy}","received_events_url":"https://api.github.com/users/pmauduit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pmauduit/mapserver","description":"","fork":true,"url":"https://api.github.com/repos/pmauduit/mapserver","forks_url":"https://api.github.com/repos/pmauduit/mapserver/forks","keys_url":"https://api.github.com/repos/pmauduit/mapserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pmauduit/mapserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pmauduit/mapserver/teams","hooks_url":"https://api.github.com/repos/pmauduit/mapserver/hooks","issue_events_url":"https://api.github.com/repos/pmauduit/mapserver/issues/events{/number}","events_url":"https://api.github.com/repos/pmauduit/mapserver/events","assignees_url":"https://api.github.com/repos/pmauduit/mapserver/assignees{/user}","branches_url":"https://api.github.com/repos/pmauduit/mapserver/branches{/branch}","tags_url":"https://api.github.com/repos/pmauduit/mapserver/tags","blobs_url":"https://api.github.com/repos/pmauduit/mapserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pmauduit/mapserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pmauduit/mapserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/pmauduit/mapserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pmauduit/mapserver/statuses/{sha}","languages_url":"https://api.github.com/repos/pmauduit/mapserver/languages","stargazers_url":"https://api.github.com/repos/pmauduit/mapserver/stargazers","contributors_url":"https://api.github.com/repos/pmauduit/mapserver/contributors","subscribers_url":"https://api.github.com/repos/pmauduit/mapserver/subscribers","subscription_url":"https://api.github.com/repos/pmauduit/mapserver/subscription","commits_url":"https://api.github.com/repos/pmauduit/mapserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/pmauduit/mapserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/pmauduit/mapserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/pmauduit/mapserver/issues/comments/{number}","contents_url":"https://api.github.com/repos/pmauduit/mapserver/contents/{+path}","compare_url":"https://api.github.com/repos/pmauduit/mapserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pmauduit/mapserver/merges","archive_url":"https://api.github.com/repos/pmauduit/mapserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pmauduit/mapserver/downloads","issues_url":"https://api.github.com/repos/pmauduit/mapserver/issues{/number}","pulls_url":"https://api.github.com/repos/pmauduit/mapserver/pulls{/number}","milestones_url":"https://api.github.com/repos/pmauduit/mapserver/milestones{/number}","notifications_url":"https://api.github.com/repos/pmauduit/mapserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pmauduit/mapserver/labels{/name}","releases_url":"https://api.github.com/repos/pmauduit/mapserver/releases{/id}","created_at":"2014-02-06T16:38:37Z","updated_at":"2014-02-11T16:14:15Z","pushed_at":"2014-07-03T13:37:57Z","git_url":"git://github.com/pmauduit/mapserver.git","ssh_url":"git@github.com:pmauduit/mapserver.git","clone_url":"https://github.com/pmauduit/mapserver.git","svn_url":"https://github.com/pmauduit/mapserver","homepage":"http://www.mapserver.org","size":20352,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mapserver:master","ref":"master","sha":"0c573e45783477e8fb8aa2a3a8cbe565dd67836c","user":{"login":"mapserver","id":1552283,"avatar_url":"https://avatars.githubusercontent.com/u/1552283?","gravatar_id":"00f6749a88ca40c6bb306812a1c5e429","url":"https://api.github.com/users/mapserver","html_url":"https://github.com/mapserver","followers_url":"https://api.github.com/users/mapserver/followers","following_url":"https://api.github.com/users/mapserver/following{/other_user}","gists_url":"https://api.github.com/users/mapserver/gists{/gist_id}","starred_url":"https://api.github.com/users/mapserver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapserver/subscriptions","organizations_url":"https://api.github.com/users/mapserver/orgs","repos_url":"https://api.github.com/users/mapserver/repos","events_url":"https://api.github.com/users/mapserver/events{/privacy}","received_events_url":"https://api.github.com/users/mapserver/received_events","type":"Organization","site_admin":false},"repo":{"id":3921611,"name":"mapserver","full_name":"mapserver/mapserver","owner":{"login":"mapserver","id":1552283,"avatar_url":"https://avatars.githubusercontent.com/u/1552283?","gravatar_id":"00f6749a88ca40c6bb306812a1c5e429","url":"https://api.github.com/users/mapserver","html_url":"https://github.com/mapserver","followers_url":"https://api.github.com/users/mapserver/followers","following_url":"https://api.github.com/users/mapserver/following{/other_user}","gists_url":"https://api.github.com/users/mapserver/gists{/gist_id}","starred_url":"https://api.github.com/users/mapserver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapserver/subscriptions","organizations_url":"https://api.github.com/users/mapserver/orgs","repos_url":"https://api.github.com/users/mapserver/repos","events_url":"https://api.github.com/users/mapserver/events{/privacy}","received_events_url":"https://api.github.com/users/mapserver/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapserver/mapserver","description":"","fork":false,"url":"https://api.github.com/repos/mapserver/mapserver","forks_url":"https://api.github.com/repos/mapserver/mapserver/forks","keys_url":"https://api.github.com/repos/mapserver/mapserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapserver/mapserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapserver/mapserver/teams","hooks_url":"https://api.github.com/repos/mapserver/mapserver/hooks","issue_events_url":"https://api.github.com/repos/mapserver/mapserver/issues/events{/number}","events_url":"https://api.github.com/repos/mapserver/mapserver/events","assignees_url":"https://api.github.com/repos/mapserver/mapserver/assignees{/user}","branches_url":"https://api.github.com/repos/mapserver/mapserver/branches{/branch}","tags_url":"https://api.github.com/repos/mapserver/mapserver/tags","blobs_url":"https://api.github.com/repos/mapserver/mapserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapserver/mapserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapserver/mapserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapserver/mapserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapserver/mapserver/statuses/{sha}","languages_url":"https://api.github.com/repos/mapserver/mapserver/languages","stargazers_url":"https://api.github.com/repos/mapserver/mapserver/stargazers","contributors_url":"https://api.github.com/repos/mapserver/mapserver/contributors","subscribers_url":"https://api.github.com/repos/mapserver/mapserver/subscribers","subscription_url":"https://api.github.com/repos/mapserver/mapserver/subscription","commits_url":"https://api.github.com/repos/mapserver/mapserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapserver/mapserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapserver/mapserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapserver/mapserver/issues/comments/{number}","contents_url":"https://api.github.com/repos/mapserver/mapserver/contents/{+path}","compare_url":"https://api.github.com/repos/mapserver/mapserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapserver/mapserver/merges","archive_url":"https://api.github.com/repos/mapserver/mapserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapserver/mapserver/downloads","issues_url":"https://api.github.com/repos/mapserver/mapserver/issues{/number}","pulls_url":"https://api.github.com/repos/mapserver/mapserver/pulls{/number}","milestones_url":"https://api.github.com/repos/mapserver/mapserver/milestones{/number}","notifications_url":"https://api.github.com/repos/mapserver/mapserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapserver/mapserver/labels{/name}","releases_url":"https://api.github.com/repos/mapserver/mapserver/releases{/id}","created_at":"2012-04-03T19:10:40Z","updated_at":"2014-07-03T13:06:41Z","pushed_at":"2014-07-04T11:21:59Z","git_url":"git://github.com/mapserver/mapserver.git","ssh_url":"git@github.com:mapserver/mapserver.git","clone_url":"https://github.com/mapserver/mapserver.git","svn_url":"https://github.com/mapserver/mapserver","homepage":"http://www.mapserver.org","size":38079,"stargazers_count":164,"watchers_count":164,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":104,"mirror_url":null,"open_issues_count":623,"forks":104,"open_issues":623,"watchers":164,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapserver/mapserver/pulls/4952"},"html":{"href":"https://github.com/mapserver/mapserver/pull/4952"},"issue":{"href":"https://api.github.com/repos/mapserver/mapserver/issues/4952"},"comments":{"href":"https://api.github.com/repos/mapserver/mapserver/issues/4952/comments"},"review_comments":{"href":"https://api.github.com/repos/mapserver/mapserver/pulls/4952/comments"},"review_comment":{"href":"https://api.github.com/repos/mapserver/mapserver/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mapserver/mapserver/pulls/4952/commits"},"statuses":{"href":"https://api.github.com/repos/mapserver/mapserver/statuses/f7772c36c39e28fe4e53d6632aedcc32c542877c"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"tbonfort","id":358469,"avatar_url":"https://avatars.githubusercontent.com/u/358469?","gravatar_id":"ba1312a46d36c13fb91bc8f625b6c175","url":"https://api.github.com/users/tbonfort","html_url":"https://github.com/tbonfort","followers_url":"https://api.github.com/users/tbonfort/followers","following_url":"https://api.github.com/users/tbonfort/following{/other_user}","gists_url":"https://api.github.com/users/tbonfort/gists{/gist_id}","starred_url":"https://api.github.com/users/tbonfort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbonfort/subscriptions","organizations_url":"https://api.github.com/users/tbonfort/orgs","repos_url":"https://api.github.com/users/tbonfort/repos","events_url":"https://api.github.com/users/tbonfort/events{/privacy}","received_events_url":"https://api.github.com/users/tbonfort/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":3,"deletions":2,"changed_files":1}}