GitHub PullRequestReviewCommentEvent at 2014-09-03 10:29:51
Repository: Dynamo
Actor: marimano
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments/17041241","id":17041241,"diff_hunk":"@@ -175,8 +249,12 @@ private void NodesDataModified(object sender, RenderCompletionEventArgs e, strin\n                     }\n                 }\n \n-                var execNode = new ExecutedNode(node, data);\n-                nodes.Add(execNode);\n+                // send only updated nodes back\n+                if (node.IsUpdated)\n+                {\n+                    var execNode = new ExecutedNode(node, data);\n+                    nodes.Add(execNode);\n+                }","path":"src/DynamoWebServer/Messages/MessageHandler.cs","position":132,"original_position":132,"commit_id":"2e91c1355ccd2dd379cf9a2f00569b2a03681706","original_commit_id":"2e91c1355ccd2dd379cf9a2f00569b2a03681706","user":{"login":"marimano","id":7658189,"avatar_url":"https://avatars.githubusercontent.com/u/7658189?v=2","gravatar_id":"384fd24c1d351fc17e2827ae0f19351e","url":"https://api.github.com/users/marimano","html_url":"https://github.com/marimano","followers_url":"https://api.github.com/users/marimano/followers","following_url":"https://api.github.com/users/marimano/following{/other_user}","gists_url":"https://api.github.com/users/marimano/gists{/gist_id}","starred_url":"https://api.github.com/users/marimano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marimano/subscriptions","organizations_url":"https://api.github.com/users/marimano/orgs","repos_url":"https://api.github.com/users/marimano/repos","events_url":"https://api.github.com/users/marimano/events{/privacy}","received_events_url":"https://api.github.com/users/marimano/received_events","type":"User","site_admin":false},"body":"there is no need in sending information about a node that wasn't changed after previous running.\r\nthis change had to be in the \"Changing the way of geometry transmission\" PR.","created_at":"2014-09-03T10:29:51Z","updated_at":"2014-09-03T10:29:51Z","html_url":"https://github.com/DynamoDS/Dynamo/pull/2298#discussion_r17041241","pull_request_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/2298","_links":{"self":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments/17041241"},"html":{"href":"https://github.com/DynamoDS/Dynamo/pull/2298#discussion_r17041241"},"pull_request":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/2298"}}},"pull_request":{"url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/2298","id":20620777,"html_url":"https://github.com/DynamoDS/Dynamo/pull/2298","diff_url":"https://github.com/DynamoDS/Dynamo/pull/2298.diff","patch_url":"https://github.com/DynamoDS/Dynamo/pull/2298.patch","issue_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/2298","number":2298,"state":"open","locked":false,"title":"Saving workspace functionality","user":{"login":"marimano","id":7658189,"avatar_url":"https://avatars.githubusercontent.com/u/7658189?v=2","gravatar_id":"384fd24c1d351fc17e2827ae0f19351e","url":"https://api.github.com/users/marimano","html_url":"https://github.com/marimano","followers_url":"https://api.github.com/users/marimano/followers","following_url":"https://api.github.com/users/marimano/following{/other_user}","gists_url":"https://api.github.com/users/marimano/gists{/gist_id}","starred_url":"https://api.github.com/users/marimano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marimano/subscriptions","organizations_url":"https://api.github.com/users/marimano/orgs","repos_url":"https://api.github.com/users/marimano/repos","events_url":"https://api.github.com/users/marimano/events{/privacy}","received_events_url":"https://api.github.com/users/marimano/received_events","type":"User","site_admin":false},"body":"Saving workspace functionality:\r\n- the Dynamo receives a message about saving, saves all workspaces as files and sends them back to the Flood.\r\n\r\nPart of changes that had to be uploaded with \"Changing the way of geometry transmission\" but wasn't:\r\n- receiving a geometry message, process it and send back the geometry data\r\n\r\nEnhancements of the code (there is not a lot of them, so I add them into this PR):\r\n- checking for not null, correct guid, removing old code, etc","created_at":"2014-09-02T15:37:21Z","updated_at":"2014-09-03T10:29:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c72d02379314fc1becf6dffbc2a0c0014621cf02","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/2298/commits","review_comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/2298/comments","review_comment_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments/{number}","comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/2298/comments","statuses_url":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/2e91c1355ccd2dd379cf9a2f00569b2a03681706","head":{"label":"marimano:Saving-workspace","ref":"Saving-workspace","sha":"2e91c1355ccd2dd379cf9a2f00569b2a03681706","user":{"login":"marimano","id":7658189,"avatar_url":"https://avatars.githubusercontent.com/u/7658189?v=2","gravatar_id":"384fd24c1d351fc17e2827ae0f19351e","url":"https://api.github.com/users/marimano","html_url":"https://github.com/marimano","followers_url":"https://api.github.com/users/marimano/followers","following_url":"https://api.github.com/users/marimano/following{/other_user}","gists_url":"https://api.github.com/users/marimano/gists{/gist_id}","starred_url":"https://api.github.com/users/marimano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marimano/subscriptions","organizations_url":"https://api.github.com/users/marimano/orgs","repos_url":"https://api.github.com/users/marimano/repos","events_url":"https://api.github.com/users/marimano/events{/privacy}","received_events_url":"https://api.github.com/users/marimano/received_events","type":"User","site_admin":false},"repo":{"id":22464277,"name":"Dynamo","full_name":"marimano/Dynamo","owner":{"login":"marimano","id":7658189,"avatar_url":"https://avatars.githubusercontent.com/u/7658189?v=2","gravatar_id":"384fd24c1d351fc17e2827ae0f19351e","url":"https://api.github.com/users/marimano","html_url":"https://github.com/marimano","followers_url":"https://api.github.com/users/marimano/followers","following_url":"https://api.github.com/users/marimano/following{/other_user}","gists_url":"https://api.github.com/users/marimano/gists{/gist_id}","starred_url":"https://api.github.com/users/marimano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marimano/subscriptions","organizations_url":"https://api.github.com/users/marimano/orgs","repos_url":"https://api.github.com/users/marimano/repos","events_url":"https://api.github.com/users/marimano/events{/privacy}","received_events_url":"https://api.github.com/users/marimano/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marimano/Dynamo","description":"Visual Programming For Revit","fork":true,"url":"https://api.github.com/repos/marimano/Dynamo","forks_url":"https://api.github.com/repos/marimano/Dynamo/forks","keys_url":"https://api.github.com/repos/marimano/Dynamo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marimano/Dynamo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marimano/Dynamo/teams","hooks_url":"https://api.github.com/repos/marimano/Dynamo/hooks","issue_events_url":"https://api.github.com/repos/marimano/Dynamo/issues/events{/number}","events_url":"https://api.github.com/repos/marimano/Dynamo/events","assignees_url":"https://api.github.com/repos/marimano/Dynamo/assignees{/user}","branches_url":"https://api.github.com/repos/marimano/Dynamo/branches{/branch}","tags_url":"https://api.github.com/repos/marimano/Dynamo/tags","blobs_url":"https://api.github.com/repos/marimano/Dynamo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marimano/Dynamo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marimano/Dynamo/git/refs{/sha}","trees_url":"https://api.github.com/repos/marimano/Dynamo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marimano/Dynamo/statuses/{sha}","languages_url":"https://api.github.com/repos/marimano/Dynamo/languages","stargazers_url":"https://api.github.com/repos/marimano/Dynamo/stargazers","contributors_url":"https://api.github.com/repos/marimano/Dynamo/contributors","subscribers_url":"https://api.github.com/repos/marimano/Dynamo/subscribers","subscription_url":"https://api.github.com/repos/marimano/Dynamo/subscription","commits_url":"https://api.github.com/repos/marimano/Dynamo/commits{/sha}","git_commits_url":"https://api.github.com/repos/marimano/Dynamo/git/commits{/sha}","comments_url":"https://api.github.com/repos/marimano/Dynamo/comments{/number}","issue_comment_url":"https://api.github.com/repos/marimano/Dynamo/issues/comments/{number}","contents_url":"https://api.github.com/repos/marimano/Dynamo/contents/{+path}","compare_url":"https://api.github.com/repos/marimano/Dynamo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marimano/Dynamo/merges","archive_url":"https://api.github.com/repos/marimano/Dynamo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marimano/Dynamo/downloads","issues_url":"https://api.github.com/repos/marimano/Dynamo/issues{/number}","pulls_url":"https://api.github.com/repos/marimano/Dynamo/pulls{/number}","milestones_url":"https://api.github.com/repos/marimano/Dynamo/milestones{/number}","notifications_url":"https://api.github.com/repos/marimano/Dynamo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marimano/Dynamo/labels{/name}","releases_url":"https://api.github.com/repos/marimano/Dynamo/releases{/id}","created_at":"2014-07-31T09:45:07Z","updated_at":"2014-07-31T02:37:47Z","pushed_at":"2014-09-02T15:24:39Z","git_url":"git://github.com/marimano/Dynamo.git","ssh_url":"git@github.com:marimano/Dynamo.git","clone_url":"https://github.com/marimano/Dynamo.git","svn_url":"https://github.com/marimano/Dynamo","homepage":"http://dynamobim.org","size":558668,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DynamoDS:Reach","ref":"Reach","sha":"a40cba3fb7a1a60a5836a05c9b3b5356c3742115","user":{"login":"DynamoDS","id":6528209,"avatar_url":"https://avatars.githubusercontent.com/u/6528209?v=2","gravatar_id":null,"url":"https://api.github.com/users/DynamoDS","html_url":"https://github.com/DynamoDS","followers_url":"https://api.github.com/users/DynamoDS/followers","following_url":"https://api.github.com/users/DynamoDS/following{/other_user}","gists_url":"https://api.github.com/users/DynamoDS/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoDS/subscriptions","organizations_url":"https://api.github.com/users/DynamoDS/orgs","repos_url":"https://api.github.com/users/DynamoDS/repos","events_url":"https://api.github.com/users/DynamoDS/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoDS/received_events","type":"Organization","site_admin":false},"repo":{"id":3395179,"name":"Dynamo","full_name":"DynamoDS/Dynamo","owner":{"login":"DynamoDS","id":6528209,"avatar_url":"https://avatars.githubusercontent.com/u/6528209?v=2","gravatar_id":null,"url":"https://api.github.com/users/DynamoDS","html_url":"https://github.com/DynamoDS","followers_url":"https://api.github.com/users/DynamoDS/followers","following_url":"https://api.github.com/users/DynamoDS/following{/other_user}","gists_url":"https://api.github.com/users/DynamoDS/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoDS/subscriptions","organizations_url":"https://api.github.com/users/DynamoDS/orgs","repos_url":"https://api.github.com/users/DynamoDS/repos","events_url":"https://api.github.com/users/DynamoDS/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoDS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DynamoDS/Dynamo","description":"Visual Programming For Revit","fork":false,"url":"https://api.github.com/repos/DynamoDS/Dynamo","forks_url":"https://api.github.com/repos/DynamoDS/Dynamo/forks","keys_url":"https://api.github.com/repos/DynamoDS/Dynamo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DynamoDS/Dynamo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DynamoDS/Dynamo/teams","hooks_url":"https://api.github.com/repos/DynamoDS/Dynamo/hooks","issue_events_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/events{/number}","events_url":"https://api.github.com/repos/DynamoDS/Dynamo/events","assignees_url":"https://api.github.com/repos/DynamoDS/Dynamo/assignees{/user}","branches_url":"https://api.github.com/repos/DynamoDS/Dynamo/branches{/branch}","tags_url":"https://api.github.com/repos/DynamoDS/Dynamo/tags","blobs_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/refs{/sha}","trees_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/{sha}","languages_url":"https://api.github.com/repos/DynamoDS/Dynamo/languages","stargazers_url":"https://api.github.com/repos/DynamoDS/Dynamo/stargazers","contributors_url":"https://api.github.com/repos/DynamoDS/Dynamo/contributors","subscribers_url":"https://api.github.com/repos/DynamoDS/Dynamo/subscribers","subscription_url":"https://api.github.com/repos/DynamoDS/Dynamo/subscription","commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/commits{/sha}","git_commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/commits{/sha}","comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/comments{/number}","issue_comment_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/comments/{number}","contents_url":"https://api.github.com/repos/DynamoDS/Dynamo/contents/{+path}","compare_url":"https://api.github.com/repos/DynamoDS/Dynamo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DynamoDS/Dynamo/merges","archive_url":"https://api.github.com/repos/DynamoDS/Dynamo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DynamoDS/Dynamo/downloads","issues_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues{/number}","pulls_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls{/number}","milestones_url":"https://api.github.com/repos/DynamoDS/Dynamo/milestones{/number}","notifications_url":"https://api.github.com/repos/DynamoDS/Dynamo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DynamoDS/Dynamo/labels{/name}","releases_url":"https://api.github.com/repos/DynamoDS/Dynamo/releases{/id}","created_at":"2012-02-09T07:35:33Z","updated_at":"2014-09-03T02:19:42Z","pushed_at":"2014-09-03T04:12:07Z","git_url":"git://github.com/DynamoDS/Dynamo.git","ssh_url":"git@github.com:DynamoDS/Dynamo.git","clone_url":"https://github.com/DynamoDS/Dynamo.git","svn_url":"https://github.com/DynamoDS/Dynamo","homepage":"http://dynamobim.org","size":720555,"stargazers_count":137,"watchers_count":137,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":106,"mirror_url":null,"open_issues_count":385,"forks":106,"open_issues":385,"watchers":137,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/2298"},"html":{"href":"https://github.com/DynamoDS/Dynamo/pull/2298"},"issue":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/issues/2298"},"comments":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/issues/2298/comments"},"review_comments":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/2298/comments"},"review_comment":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/2298/commits"},"statuses":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/2e91c1355ccd2dd379cf9a2f00569b2a03681706"}}}}