GitHub PullRequestEvent at 2014-08-15 17:46:43
Repository: framework
Actor: Shadowfiend
Payload: {"action":"closed","number":1604,"pull_request":{"url":"https://api.github.com/repos/lift/framework/pulls/1604","id":19361512,"html_url":"https://github.com/lift/framework/pull/1604","diff_url":"https://github.com/lift/framework/pull/1604.diff","patch_url":"https://github.com/lift/framework/pull/1604.patch","issue_url":"https://api.github.com/repos/lift/framework/issues/1604","number":1604,"state":"closed","locked":false,"title":"Remove automatic lift:surround with=\"default\" insertion","user":{"login":"pbrant","id":24168,"avatar_url":"https://avatars.githubusercontent.com/u/24168?v=2","gravatar_id":"733c2efe4575b87039f963563fba066a","url":"https://api.github.com/users/pbrant","html_url":"https://github.com/pbrant","followers_url":"https://api.github.com/users/pbrant/followers","following_url":"https://api.github.com/users/pbrant/following{/other_user}","gists_url":"https://api.github.com/users/pbrant/gists{/gist_id}","starred_url":"https://api.github.com/users/pbrant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbrant/subscriptions","organizations_url":"https://api.github.com/users/pbrant/orgs","repos_url":"https://api.github.com/users/pbrant/repos","events_url":"https://api.github.com/users/pbrant/events{/privacy}","received_events_url":"https://api.github.com/users/pbrant/received_events","type":"User","site_admin":false},"body":"Here is a first try at this (which may need some more Markdown-related work).\r\n\r\nRemove automatic lift:surround with=\"default\" insertion, but wrap top level templates in <html></html> if the template contains multiple top level nodes and does not already contain <html>. This is necessary to support Markdown templates.\r\n\r\nFixes #1599 ","created_at":"2014-08-05T18:53:57Z","updated_at":"2014-08-15T17:46:43Z","closed_at":"2014-08-15T17:46:43Z","merged_at":"2014-08-15T17:46:43Z","merge_commit_sha":"280d4af0f9c7e711f7a42aac2947f68d5da1c891","assignee":null,"milestone":{"url":"https://api.github.com/repos/lift/framework/milestones/53","labels_url":"https://api.github.com/repos/lift/framework/milestones/53/labels","id":388592,"number":53,"title":"3.0-M2","description":"","creator":{"login":"fmpwizard","id":62802,"avatar_url":"https://avatars.githubusercontent.com/u/62802?v=2","gravatar_id":"ffd17116dd89d84c2783d1b2a63d8370","url":"https://api.github.com/users/fmpwizard","html_url":"https://github.com/fmpwizard","followers_url":"https://api.github.com/users/fmpwizard/followers","following_url":"https://api.github.com/users/fmpwizard/following{/other_user}","gists_url":"https://api.github.com/users/fmpwizard/gists{/gist_id}","starred_url":"https://api.github.com/users/fmpwizard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fmpwizard/subscriptions","organizations_url":"https://api.github.com/users/fmpwizard/orgs","repos_url":"https://api.github.com/users/fmpwizard/repos","events_url":"https://api.github.com/users/fmpwizard/events{/privacy}","received_events_url":"https://api.github.com/users/fmpwizard/received_events","type":"User","site_admin":false},"open_issues":39,"closed_issues":29,"state":"open","created_at":"2013-07-28T04:58:09Z","updated_at":"2014-08-15T17:46:43Z","due_on":null},"commits_url":"https://api.github.com/repos/lift/framework/pulls/1604/commits","review_comments_url":"https://api.github.com/repos/lift/framework/pulls/1604/comments","review_comment_url":"https://api.github.com/repos/lift/framework/pulls/comments/{number}","comments_url":"https://api.github.com/repos/lift/framework/issues/1604/comments","statuses_url":"https://api.github.com/repos/lift/framework/statuses/19664c51820286ccb914fdd5aa9c24d4adbe0a43","head":{"label":"lift:pmb_surround","ref":"pmb_surround","sha":"19664c51820286ccb914fdd5aa9c24d4adbe0a43","user":{"login":"lift","id":317975,"avatar_url":"https://avatars.githubusercontent.com/u/317975?v=2","gravatar_id":"9ed0b3a677a32bc9220d89e63b3054aa","url":"https://api.github.com/users/lift","html_url":"https://github.com/lift","followers_url":"https://api.github.com/users/lift/followers","following_url":"https://api.github.com/users/lift/following{/other_user}","gists_url":"https://api.github.com/users/lift/gists{/gist_id}","starred_url":"https://api.github.com/users/lift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lift/subscriptions","organizations_url":"https://api.github.com/users/lift/orgs","repos_url":"https://api.github.com/users/lift/repos","events_url":"https://api.github.com/users/lift/events{/privacy}","received_events_url":"https://api.github.com/users/lift/received_events","type":"Organization","site_admin":false},"repo":{"id":1295197,"name":"framework","full_name":"lift/framework","owner":{"login":"lift","id":317975,"avatar_url":"https://avatars.githubusercontent.com/u/317975?v=2","gravatar_id":"9ed0b3a677a32bc9220d89e63b3054aa","url":"https://api.github.com/users/lift","html_url":"https://github.com/lift","followers_url":"https://api.github.com/users/lift/followers","following_url":"https://api.github.com/users/lift/following{/other_user}","gists_url":"https://api.github.com/users/lift/gists{/gist_id}","starred_url":"https://api.github.com/users/lift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lift/subscriptions","organizations_url":"https://api.github.com/users/lift/orgs","repos_url":"https://api.github.com/users/lift/repos","events_url":"https://api.github.com/users/lift/events{/privacy}","received_events_url":"https://api.github.com/users/lift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lift/framework","description":"Lift Framework","fork":false,"url":"https://api.github.com/repos/lift/framework","forks_url":"https://api.github.com/repos/lift/framework/forks","keys_url":"https://api.github.com/repos/lift/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lift/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lift/framework/teams","hooks_url":"https://api.github.com/repos/lift/framework/hooks","issue_events_url":"https://api.github.com/repos/lift/framework/issues/events{/number}","events_url":"https://api.github.com/repos/lift/framework/events","assignees_url":"https://api.github.com/repos/lift/framework/assignees{/user}","branches_url":"https://api.github.com/repos/lift/framework/branches{/branch}","tags_url":"https://api.github.com/repos/lift/framework/tags","blobs_url":"https://api.github.com/repos/lift/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lift/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lift/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/lift/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lift/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/lift/framework/languages","stargazers_url":"https://api.github.com/repos/lift/framework/stargazers","contributors_url":"https://api.github.com/repos/lift/framework/contributors","subscribers_url":"https://api.github.com/repos/lift/framework/subscribers","subscription_url":"https://api.github.com/repos/lift/framework/subscription","commits_url":"https://api.github.com/repos/lift/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/lift/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/lift/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/lift/framework/issues/comments/{number}","contents_url":"https://api.github.com/repos/lift/framework/contents/{+path}","compare_url":"https://api.github.com/repos/lift/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lift/framework/merges","archive_url":"https://api.github.com/repos/lift/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lift/framework/downloads","issues_url":"https://api.github.com/repos/lift/framework/issues{/number}","pulls_url":"https://api.github.com/repos/lift/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/lift/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/lift/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lift/framework/labels{/name}","releases_url":"https://api.github.com/repos/lift/framework/releases{/id}","created_at":"2011-01-26T13:25:28Z","updated_at":"2014-08-14T13:24:00Z","pushed_at":"2014-08-15T17:46:43Z","git_url":"git://github.com/lift/framework.git","ssh_url":"git@github.com:lift/framework.git","clone_url":"https://github.com/lift/framework.git","svn_url":"https://github.com/lift/framework","homepage":"http://liftweb.net","size":31340,"stargazers_count":806,"watchers_count":806,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":196,"mirror_url":null,"open_issues_count":127,"forks":196,"open_issues":127,"watchers":806,"default_branch":"master"}},"base":{"label":"lift:master","ref":"master","sha":"cc613f84995e574c82608d59f14434b925cf32d5","user":{"login":"lift","id":317975,"avatar_url":"https://avatars.githubusercontent.com/u/317975?v=2","gravatar_id":"9ed0b3a677a32bc9220d89e63b3054aa","url":"https://api.github.com/users/lift","html_url":"https://github.com/lift","followers_url":"https://api.github.com/users/lift/followers","following_url":"https://api.github.com/users/lift/following{/other_user}","gists_url":"https://api.github.com/users/lift/gists{/gist_id}","starred_url":"https://api.github.com/users/lift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lift/subscriptions","organizations_url":"https://api.github.com/users/lift/orgs","repos_url":"https://api.github.com/users/lift/repos","events_url":"https://api.github.com/users/lift/events{/privacy}","received_events_url":"https://api.github.com/users/lift/received_events","type":"Organization","site_admin":false},"repo":{"id":1295197,"name":"framework","full_name":"lift/framework","owner":{"login":"lift","id":317975,"avatar_url":"https://avatars.githubusercontent.com/u/317975?v=2","gravatar_id":"9ed0b3a677a32bc9220d89e63b3054aa","url":"https://api.github.com/users/lift","html_url":"https://github.com/lift","followers_url":"https://api.github.com/users/lift/followers","following_url":"https://api.github.com/users/lift/following{/other_user}","gists_url":"https://api.github.com/users/lift/gists{/gist_id}","starred_url":"https://api.github.com/users/lift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lift/subscriptions","organizations_url":"https://api.github.com/users/lift/orgs","repos_url":"https://api.github.com/users/lift/repos","events_url":"https://api.github.com/users/lift/events{/privacy}","received_events_url":"https://api.github.com/users/lift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lift/framework","description":"Lift Framework","fork":false,"url":"https://api.github.com/repos/lift/framework","forks_url":"https://api.github.com/repos/lift/framework/forks","keys_url":"https://api.github.com/repos/lift/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lift/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lift/framework/teams","hooks_url":"https://api.github.com/repos/lift/framework/hooks","issue_events_url":"https://api.github.com/repos/lift/framework/issues/events{/number}","events_url":"https://api.github.com/repos/lift/framework/events","assignees_url":"https://api.github.com/repos/lift/framework/assignees{/user}","branches_url":"https://api.github.com/repos/lift/framework/branches{/branch}","tags_url":"https://api.github.com/repos/lift/framework/tags","blobs_url":"https://api.github.com/repos/lift/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lift/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lift/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/lift/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lift/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/lift/framework/languages","stargazers_url":"https://api.github.com/repos/lift/framework/stargazers","contributors_url":"https://api.github.com/repos/lift/framework/contributors","subscribers_url":"https://api.github.com/repos/lift/framework/subscribers","subscription_url":"https://api.github.com/repos/lift/framework/subscription","commits_url":"https://api.github.com/repos/lift/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/lift/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/lift/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/lift/framework/issues/comments/{number}","contents_url":"https://api.github.com/repos/lift/framework/contents/{+path}","compare_url":"https://api.github.com/repos/lift/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lift/framework/merges","archive_url":"https://api.github.com/repos/lift/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lift/framework/downloads","issues_url":"https://api.github.com/repos/lift/framework/issues{/number}","pulls_url":"https://api.github.com/repos/lift/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/lift/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/lift/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lift/framework/labels{/name}","releases_url":"https://api.github.com/repos/lift/framework/releases{/id}","created_at":"2011-01-26T13:25:28Z","updated_at":"2014-08-14T13:24:00Z","pushed_at":"2014-08-15T17:46:43Z","git_url":"git://github.com/lift/framework.git","ssh_url":"git@github.com:lift/framework.git","clone_url":"https://github.com/lift/framework.git","svn_url":"https://github.com/lift/framework","homepage":"http://liftweb.net","size":31340,"stargazers_count":806,"watchers_count":806,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":196,"mirror_url":null,"open_issues_count":127,"forks":196,"open_issues":127,"watchers":806,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lift/framework/pulls/1604"},"html":{"href":"https://github.com/lift/framework/pull/1604"},"issue":{"href":"https://api.github.com/repos/lift/framework/issues/1604"},"comments":{"href":"https://api.github.com/repos/lift/framework/issues/1604/comments"},"review_comments":{"href":"https://api.github.com/repos/lift/framework/pulls/1604/comments"},"review_comment":{"href":"https://api.github.com/repos/lift/framework/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/lift/framework/pulls/1604/commits"},"statuses":{"href":"https://api.github.com/repos/lift/framework/statuses/19664c51820286ccb914fdd5aa9c24d4adbe0a43"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"Shadowfiend","id":8245,"avatar_url":"https://avatars.githubusercontent.com/u/8245?v=2","gravatar_id":"36b4b730bc6d058fd0737fc44119ed6f","url":"https://api.github.com/users/Shadowfiend","html_url":"https://github.com/Shadowfiend","followers_url":"https://api.github.com/users/Shadowfiend/followers","following_url":"https://api.github.com/users/Shadowfiend/following{/other_user}","gists_url":"https://api.github.com/users/Shadowfiend/gists{/gist_id}","starred_url":"https://api.github.com/users/Shadowfiend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shadowfiend/subscriptions","organizations_url":"https://api.github.com/users/Shadowfiend/orgs","repos_url":"https://api.github.com/users/Shadowfiend/repos","events_url":"https://api.github.com/users/Shadowfiend/events{/privacy}","received_events_url":"https://api.github.com/users/Shadowfiend/received_events","type":"User","site_admin":false},"comments":4,"review_comments":3,"commits":3,"additions":24,"deletions":21,"changed_files":2}}