Warningfix knut

Warningsfixes by Knut.
I am also in favor of using the pragma to remove the error. If we know what
we are doing, the error is a false positive and should be removed.

This seems better to me than to "just satisfy" the compiler - see also
http://xkcd.com/424/


On 8 August 2014 10:41, Stephan Aiche <notifications@github.com> wrote:

> In src/openms/include/OpenMS/FILTERING/TRANSFORMERS/SpectraMerger.h:
>
> > @@ -151,7 +151,7 @@ namespace OpenMS
> >        Int rt_block_size(param_.getValue("block_method:rt_block_size"));
> >        DoubleReal rt_max_length = (param_.getValue("block_method:rt_max_length"));
> >
> > -      if (rt_max_length == 0)  // no rt restriction set?
> > +      if ( std::abs(rt_max_length) <= std::numeric_limits<DoubleReal>::epsilon())  // no rt restriction set?
>
> alternative would be to hide it behind a function template <typename
> FloatType> is_exact_zero(const FloatType x); and hide the warning for
> this comparison with the corresponding #pragma clang diagnostic ignored ..
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/OpenMS/OpenMS/pull/769/files#r15982881>.
>